gdb/ChangeLog

   1 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
   4         * features/arm/arm-with-iwmmxt.c: Remove.
   5         * features/arm/arm-with-iwmmxt.xml: Remove.
   6         * features/arm/arm-with-m-fpa-layout.c: Remove.
   7         * features/arm/arm-with-m-fpa-layout.xml: Remove.
   8         * features/arm/arm-with-m-vfp-d16.c: Remove.
   9         * features/arm/arm-with-m-vfp-d16.xml: Remove.
  10         * features/arm/arm-with-m.c: Remove.
  11         * features/arm/arm-with-m.xml: Remove.
  12         * features/arm/arm-with-neon.c: Remove.
  13         * features/arm/arm-with-neon.xml: Remove.
  14         * features/arm/arm-with-vfpv2.c: Remove.
  15         * features/arm/arm-with-vfpv2.xml: Remove.
  16         * features/arm/arm-with-vfpv3.c: Remove.
  17         * features/arm/arm-with-vfpv3.xml: Remove.
  18
  19 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  20
  21         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
  22
  23 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  24
  25         * arch/aarch32.c (aarch32_create_target_description): Create
  26         target descriptions using features.
  27         * arch/arm.c (arm_create_target_description)
  28         (arm_create_mprofile_target_description): Likewise.
  29         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
  30
  31 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
  32
  33         * Makefile.in: Add new files.
  34         * aarch32-tdep.c: New file.
  35         * aarch32-tdep.h: New file.
  36         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  37         Call aarch32_read_description.
  38         * arch/aarch32.c: New file.
  39         * arch/aarch32.h: New file.
  40         * arch/arm.c (arm_create_target_description)
  41         (arm_create_mprofile_target_description): New function.
  42         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  43         (arm_create_target_description)
  44         (arm_create_mprofile_target_description): New declaration.
  45         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
  46         read_description functions.
  47         * arm-linux-nat.c (arm_linux_nat_target::read_description):
  48         Likewise.
  49         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  50         * arm-tdep.c (tdesc_arm_list): New variable.
  51         (arm_register_g_packet_guesses): Call create description functions.
  52         (arm_read_description) (arm_read_mprofile_description): New
  53         function.
  54         * arm-tdep.h (arm_read_description)
  55         (arm_read_mprofile_description): Add declaration.
  56         * configure.tgt: Add new files.
  57
  58 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
  59
  60         * top.c (new_ui_command): Open specified terminal just once.
  61
  62 2019-07-18  Tom Tromey  <tromey@adacore.com>
  63
  64         * symtab.c (main_name): Constify return type.
  65         * symfile.c (set_initial_language): Update.
  66         * symtab.h (main_name): Constify return type.
  67
  68 2019-07-17  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-winsource.c (tui_update_source_window)
  71         (tui_update_source_window_as_is)
  72         (tui_update_source_windows_with_line): Remove return.
  73         * tui/tui-disasm.c (tui_show_disassem)
  74         (tui_show_disassem_and_update_source): Remove return.
  75         * tui/tui.c (tui_reset): Remove return.
  76         * tui/tui-wingeneral.c
  77         (tui_check_and_display_highlight_if_needed): Remove return.
  78
  79 2019-07-17  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
  82
  83 2019-07-17  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui-winsource.h (struct tui_exec_info_window)
  86         (struct tui_source_window_base): Move from tui-data.h.
  87         * tui/tui-winsource.c: Move many method definitions from
  88         elsewhere.  Remove "structuring" comments.
  89         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
  90         (tui_source_window_base::refresh_window): Move to
  91         tui-winsource.c.
  92         * tui/tui-win.c (tui_source_window_base::refresh_all)
  93         (tui_source_window_base::update_tab_width)
  94         (tui_source_window_base::set_new_height)
  95         (tui_source_window_base::do_make_visible_with_new_height): Move to
  96         tui-winsource.c.
  97         * tui/tui-source.h: Update.
  98         * tui/tui-source.c (tui_source_window_base::reset): Move to
  99         tui-winsource.c.
 100         * tui/tui-disasm.h: Update.
 101         * tui/tui-data.h (struct tui_exec_info_window): Move to
 102         tui-winsource.h.
 103         (struct tui_source_window_base): Likewise.
 104         * tui/tui-data.c (tui_source_window_base::clear_detail)
 105         (tui_source_window_base, ~tui_source_window_base): Move to
 106         tui-winsource.c.
 107
 108 2019-07-17  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui-win.c (tui_resize_all)
 111         (tui_source_window_base::update_tab_width)
 112         (tui_adjust_win_heights): Update.
 113         (tui_win_info::make_invisible_and_set_new_height): Rename from
 114         make_invisible_and_set_new_height.
 115         * tui/tui-data.h (struct tui_win_info)
 116         <make_invisible_and_set_new_height>: New method.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui.c: Update.
 121         * tui/tui-source.h (struct tui_source_window): Move from
 122         tui-data.h.
 123         * tui/tui-layout.c: Update.
 124         * tui/tui-disasm.c: Update.
 125         * tui/tui-data.h (struct tui_source_window): Move to
 126         tui-source.h.
 127
 128 2019-07-17  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 131         tui-data.h.
 132         * tui/tui-data.h (struct tui_disasm_window): Move to
 133         tui-disasm.h.
 134
 135 2019-07-17  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-regs.h (struct tui_data_item_window): Move from
 138         tui-data.h.
 139         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 140         * tui/tui-data.h (struct tui_data_item_window): Move to
 141         tui-regs.h.
 142         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 143
 144 2019-07-17  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui.c: Update.
 147         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 148         (tui_cmd_window::max_height): Move to tui-command.c.
 149         * tui/tui-layout.c: Update.
 150         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 151         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 152         tui-command.c.
 153         * tui/tui-command.h (struct tui_cmd_window): Move from
 154         tui-data.h.
 155         * tui/tui-command.c: Remove "structuring" comments.
 156         (tui_cmd_window::clear_detail)
 157         (tui_cmd_window::do_make_visible_with_new_height)
 158         (tui_cmd_window::max_height): Move from elsewhere.
 159
 160 2019-07-17  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 163         Now static.
 164         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 165         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 166
 167 2019-07-17  Tom Tromey  <tom@tromey.com>
 168
 169         * tui/tui.c: Update.
 170         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 171         tui-regs.c.
 172         * tui/tui-windata.h: Remove file.
 173         * tui/tui-windata.c: Remove file.
 174         * tui/tui-win.c (tui_data_window::set_new_height)
 175         (tui_data_window::do_make_visible_with_new_height): Move to
 176         tui-regs.c.
 177         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 178         * tui/tui-regs.c: Remove "structuring" comments.
 179         (tui_data_window::first_data_item_displayed)
 180         (tui_data_window::delete_data_content_windows)
 181         (tui_data_window::erase_data_content)
 182         (tui_data_window::display_all_data)
 183         (tui_data_window::refresh_all)
 184         (tui_data_window::do_scroll_vertical)
 185         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 186         (tui_data_window::do_make_visible_with_new_height)
 187         (tui_data_window::refresh_window): Move from elsewhere.
 188         (_initialize_tui_regs): Move to end of file.
 189         * tui/tui-layout.c: Update.
 190         * tui/tui-hooks.c: Update.
 191         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 192         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 193         tui-regs.c.
 194         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 195
 196 2019-07-17  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 199         seen.
 200
 201 2019-07-17  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-win.c (tui_source_window_base::set_new_height)
 204         (tui_source_window_base::do_make_visible_with_new_height): Use
 205         m_has_locator field directly.
 206         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 207         method.
 208         (struct tui_source_window_base) <has_locator>: Likewise.
 209
 210 2019-07-17  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 213         Don't declare.
 214         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 215         Remove.
 216         * tui/tui-win.c (tui_source_window_base::set_new_height)
 217         (tui_source_window_base::set_new_height)
 218         (make_invisible_and_set_new_height)
 219         (tui_source_window_base::do_make_visible_with_new_height)
 220         (tui_source_window_base::do_make_visible_with_new_height):
 221         Update.
 222         * tui/tui-layout.c (show_source_disasm_command, show_data)
 223         (show_source_or_disasm_and_command): Update.
 224         * tui/tui-layout.c (show_layout): Update.
 225
 226 2019-07-17  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-layout.c (make_data_window): Remove.
 229         (show_data): Unify creation and re-initialization cases.
 230
 231 2019-07-17  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-layout.c (make_source_window, make_disasm_window):
 234         Remove.
 235         (show_data): Unify creation and re-initialization cases.
 236
 237 2019-07-17  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui-layout.c (make_command_window): Remove.
 240         (show_source_disasm_command, show_source_or_disasm_and_command):
 241         Unify creation and re-initialization cases.
 242
 243 2019-07-17  Tom Tromey  <tom@tromey.com>
 244
 245         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 246         creation and re-initialization cases.
 247
 248 2019-07-17  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-regs.c (tui_get_register): Return void.
 251
 252 2019-07-17  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 255         Simplify.
 256
 257 2019-07-17  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 260         resetting.
 261
 262 2019-07-17  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 265         * tui/tui-regs.c (tui_reg_layout): New function.
 266         (tui_show_registers, tui_reg_command): Use it.
 267         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 268         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 269         parameters.
 270         (tui_layout_command): Remove.
 271
 272 2019-07-17  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-layout.h (tui/tui-layout): Return void.
 275         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 276
 277 2019-07-17  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-layout.c (show_source_disasm_command, show_data):
 280         Update.
 281         (reset_locator): Remove.
 282         (show_source_or_disasm_and_command): Update.
 283
 284 2019-07-17  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-source.c (tui_source_window_base::reset): Remove
 287         win_type parameter.
 288         * tui/tui-layout.c (make_command_window, make_source_window)
 289         (make_disasm_window, make_data_window)
 290         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 291         (reset_locator, show_source_or_disasm_and_command): Update.
 292         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 293         win_type parameter.
 294         (struct tui_source_window_base) <reset>: Likewise.
 295
 296 2019-07-17  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-layout.c (show_source_disasm_command): Use
 299         reset_locator.
 300         (reset_locator): New function.
 301         (init_and_make_win): Remove.
 302         (show_source_or_disasm_and_command): Use reset_locator.
 303
 304 2019-07-17  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 307         condition.
 308         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 309         Remove condition.
 310         * tui/tui-source.c (tui_source_window_base::reset): New method.
 311         * tui/tui-layout.c (make_command_window): Don't call
 312         init_and_make_win.
 313         (make_source_window, make_disasm_window): Don't call
 314         make_source_or_disasm_window.
 315         (make_data_window): Don't call init_and_make_win.  Change calling
 316         convention.
 317         (show_source_disasm_command, show_data): Simplify.
 318         (make_source_or_disasm_window): Remove.
 319         (show_source_or_disasm_and_command): Simplify.
 320         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 321         (struct tui_source_window_base) <reset>: Likewise.
 322         <execution_info>: Remove initializer.
 323         * tui/tui-data.c (tui_source_window_base): Initialize
 324         execution_info.
 325
 326 2019-07-17  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 329         variable.
 330
 331 2019-07-17  Tom Tromey  <tom@tromey.com>
 332
 333         * tui/tui.c (tui_rl_other_window): Update.
 334         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 335         superclass method first.  Always iterate over regs_content.
 336         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 337         method.
 338         * tui/tui-win.c (tui_set_focus_command): Update.
 339
 340 2019-07-17  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-win.c (tui_set_focus_command): Rename from
 343         tui_set_focus.  Call tui_enable.
 344         (tui_set_focus_command): Remove.
 345
 346 2019-07-17  Tom Tromey  <tom@tromey.com>
 347
 348         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 349         refresh_window.
 350         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 351         touchwin.
 352         (tui_data_window::refresh_window): Call refresh_window on data
 353         items.  Always call superclass refresh_window.
 354         (tui_win_info::refresh): Remove.
 355         (tui_source_window_base::refresh_window): Update.
 356         (tui_refresh_all): Update.
 357         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 358         refresh_window.
 359         (show_source_or_disasm_and_command): Likewise.
 360         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 361         (struct tui_source_window_base) <refresh>: Likewise.
 362
 363 2019-07-17  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-winsource.c (tui_clear_source_content)
 366         (tui_show_source_content): Update.
 367         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 368         whether content is empty.
 369         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 370         Remove.
 371
 372 2019-07-17  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 375         window's contents.
 376         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 377         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 378
 379 2019-07-17  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 382         (struct tui_data_item_window): Update.
 383
 384 2019-07-17  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 387         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 388         defines.
 389
 390 2019-07-17  Tom Tromey  <tom@tromey.com>
 391
 392         * tui/tui-winsource.h (tui_erase_source_content)
 393         (tui_clear_source_content): Remove "display_prompt" parameter.
 394         * tui/tui-winsource.c (tui_update_source_window_as_is)
 395         (tui_update_source_windows_with_addr): Update.
 396         (tui_clear_source_content): Remove "display_prompt" parameter.
 397         (tui_erase_source_content): Likewise.  Simplify.
 398         (tui_show_source_content): Update.
 399         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 400         * tui/tui-stack.c (tui_show_frame_info): Update.
 401         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 402         Remove defines.
 403
 404 2019-07-17  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 407         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 408         parameter.
 409         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 410         parameter.
 411
 412 2019-07-17  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-winsource.c (tui_clear_source_content)
 415         (tui_show_source_content, tui_show_exec_info_content)
 416         (tui_clear_exec_info_content): Update.
 417         * tui/tui-stack.c (tui_show_locator_content): Update.
 418         (tui_show_frame_info): Update.
 419         * tui/tui-source.h (tui_source_window): Don't declare.
 420         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 421         from tui_source_is_displayed.
 422         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 423         Remove field.
 424         (struct tui_source_window_base) <content_in_use>: New field.  Now
 425         bool.
 426         (struct tui_source_window) <showing_source_p>: New method.
 427         (TUI_SRC_WIN): Change cast.
 428         * tui/tui-data.c (tui_initialize_static_data): Update.
 429
 430 2019-07-17  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 433         location_matches_p.
 434         * tui/tui-source.c (tui_source_window::location_matches_p): New
 435         method.
 436         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 437         method.
 438         * tui/tui-data.h (struct tui_source_window_base)
 439         <location_matches_p>: New method.
 440         (struct tui_source_window, struct tui_disasm_window)
 441         <location_matches_p>: Likewise.
 442
 443 2019-07-17  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-win.c (tui_set_win_height_command): Rename from
 446         tui_set_win_height.
 447         (tui_set_win_height_command): Remove.
 448
 449 2019-07-17  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-source.c (tui_source_window): New constructor.  Add
 452         observer.
 453         (~tui_source_window): New destructor.
 454         (tui_source_window::style_changed): New method.
 455         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 456         (tui_attach_detach_observers): Update.
 457         * tui/tui-data.h (struct tui_source_window): Make constructor not
 458         inline.  Add destructor.
 459         (struct tui_source_window) <style_changed>: New method.
 460         <m_observable>: New member.
 461
 462 2019-07-17  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 465         * tui/tui-win.c (tui_resize_all): Fix typo.
 466
 467 2019-07-17  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 470         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 471         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 472         * tui/tui-win.c (window_name_completer): Use foreach.
 473         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 474         (update_tab_width): Likewise.
 475         * tui/tui-layout.c (show_layout): Update.
 476         * tui/tui-data.h (class tui_window_iterator): New.
 477         (struct all_tui_windows): New.
 478         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 479
 480 2019-07-17  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 483         parameter.  Don't reference globals.
 484         (tui_reg_command): Update.
 485
 486 2019-07-17  Tom Tromey  <tom@tromey.com>
 487
 488         * tui/tui-regs.c (tui_show_registers): Simplify.
 489
 490 2019-07-17  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-regs.c (tui_show_registers): Update.
 493         (tui_show_register_group): Add win_info parameter.
 494
 495 2019-07-17  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 498         Rename from tui_display_reg_element_at_line.
 499         (tui_data_window::display_registers_from_line): Update.
 500         * tui/tui-data.h (struct tui_data_window)
 501         <display_reg_element_at_line>: New method.
 502
 503 2019-07-17  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui-regs.h (tui_display_registers_from)
 506         (tui_display_registers_from_line): Don't declare.
 507         * tui/tui-windata.c (tui_data_window::display_all_data)
 508         (tui_data_window::refresh_all)
 509         (tui_data_window::do_scroll_vertical): Update.
 510         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 511         from tui_display_registers_from.
 512         (tui_display_reg_element_at_line): Update.
 513         (tui_data_window::display_registers_from_line): Rename from
 514         tui_display_registers_from_line.
 515         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 516         display_registers_from_line>: New methods.
 517
 518 2019-07-17  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 521         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 522         from tui_erase_data_content.
 523         (tui_data_window::display_all_data)
 524         (tui_data_window::refresh_all)
 525         (tui_data_window::do_scroll_vertical): Update.
 526         * tui/tui-regs.c (tui_show_registers): Update.
 527         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 528         New method.
 529
 530 2019-07-17  Tom Tromey  <tom@tromey.com>
 531
 532         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 533         declare.
 534         * tui/tui-windata.c
 535         (tui_data_window::delete_data_content_windows): Rename from
 536         tui_delete_data_content_windows.
 537         (tui_data_window::display_all_data)
 538         (tui_data_window::do_scroll_vertical): Update.
 539         * tui/tui-data.h (struct tui_data_window)
 540         <delete_data_content_windows>: New method.
 541
 542 2019-07-17  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 545         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 546
 547 2019-07-17  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 550         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 551         from tui_display_all_data.
 552         * tui/tui-win.c
 553         (tui_data_window::do_make_visible_with_new_height): Update.
 554         * tui/tui-regs.c (tui_show_registers): Update.
 555         * tui/tui-layout.c (tui_set_layout): Update.
 556         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 557         method.
 558
 559 2019-07-17  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 562         * tui/tui-windata.c (tui_display_data_from): Remove.
 563         (tui_data_window::refresh_all): Update.
 564
 565 2019-07-17  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 568         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 569         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 570         tui_display_registers_from_line.
 571         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 572         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 573         "force_display" parameter.
 574
 575 2019-07-17  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 578         declare.
 579         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 580         Rename from tui_first_reg_element_no_inline.
 581         (tui_display_reg_element_at_line)
 582         (tui_display_registers_from_line): Update.
 583         * tui/tui-data.h (struct tui_data_window)
 584         <first_reg_element_no_inline>: New method.
 585
 586 2019-07-17  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-windata.c (tui_display_data_from)
 589         (tui_data_window::do_scroll_vertical): Update.
 590         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 591         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 592         Rename from tui_line_from_reg_element_no.
 593         (tui_display_registers_from_line): Update.
 594         * tui/tui-data.h (struct tui_data_window)
 595         <line_from_reg_element_no>: New method.
 596
 597 2019-07-17  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 600         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 601         tui_last_regs_line_no.
 602         (tui_display_reg_element_at_line)
 603         (tui_display_registers_from_line): Update.
 604         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 605         method.
 606
 607 2019-07-17  Tom Tromey  <tom@tromey.com>
 608
 609         PR tui/24722:
 610         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 611         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 612         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 613         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 614         (tui_update_breakpoint_info): Likewise.
 615         * tui/tui-hooks.c (tui_event_create_breakpoint)
 616         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 617         Update.
 618
 619 2019-07-17  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 622
 623 2019-07-17  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui-winsource.c (tui_update_source_window_as_is)
 626         (tui_update_source_windows_with_addr): Update.
 627         * tui/tui-source.h (tui_set_source_content)
 628         (tui_show_symtab_source): Add "win_info" parameter.
 629         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 630         parameter.
 631         (tui_show_symtab_source): Likewise.
 632
 633 2019-07-17  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-wingeneral.c
 636         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 637
 638 2019-07-17  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 641         (struct tui_cmd_window) <can_scroll>: New method.
 642         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 643         method.
 644
 645 2019-07-17  Tom Tromey  <tromey@adacore.com>
 646
 647         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 648         do_field_signed>: Rename.  Change type of "value".
 649         * ui-out.c (ui_out::field_signed): Rename from field_int.
 650         Change type of "value".
 651         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 652         type of "value".
 653         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 654         do_field_int.  Change type of "value".
 655         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 656         do_field_int.  Change type of "value".
 657         * tracepoint.c (trace_status_mi, tfind_1)
 658         (print_one_static_tracepoint_marker): Update.
 659         * thread.c (print_thread_info_1, print_selected_thread_frame):
 660         Update.
 661         * stack.c (print_frame, print_frame_info): Update.
 662         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 663         Update.
 664         * source.c (print_source_lines_base): Update.
 665         * skip.c (info_skip_command): Update.
 666         * record-btrace.c (btrace_ui_out_decode_error)
 667         (btrace_call_history_src_line): Update.
 668         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 669         Update.
 670         * progspace.c (print_program_space): Update.
 671         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 672         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 673         do_field_int.  Change type of "value".
 674         * mi/mi-out.c (mi_ui_out::do_table_begin)
 675         (mi_ui_out::do_table_header): Update.
 676         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 677         type of "value".
 678         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 679         (mi_cmd_data_list_changed_registers, output_register)
 680         (mi_cmd_data_read_memory, mi_load_progress)
 681         (mi_cmd_trace_frame_collected): Update.
 682         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 683         Update.
 684         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 685         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 686         (mi_cmd_var_list_children, varobj_update_one): Update.
 687         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 688         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 689         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 690         * inferior.c (print_inferior): Update.
 691         * gdb_bfd.c (print_one_bfd): Update.
 692         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 693         Update.
 694         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 695         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 696         do_field_int.  Change type of "value".
 697         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 698         do_field_int.  Change type of "value".
 699         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 700         (print_one_breakpoint_location, print_it_catch_fork)
 701         (print_one_catch_fork, print_it_catch_vfork)
 702         (print_one_catch_vfork, print_it_catch_solib)
 703         (print_it_catch_exec, print_it_ranged_breakpoint)
 704         (print_mention_watchpoint, print_mention_masked_watchpoint)
 705         (bkpt_print_it, update_static_tracepoint): Update.
 706         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 707         * break-catch-syscall.c (print_it_catch_syscall): Update.
 708         * ada-tasks.c (print_ada_task_info): Update.
 709         * ada-lang.c (print_it_exception, print_mention_exception):
 710         Update.
 711
 712 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 713
 714         PR breakpoints/24541
 715         * gdbarch.c: Regenerate.
 716         * gdbarch.h: Regenerate.
 717         * gdbarch.sh: Adjust return type and parameter types for
 718         'stap_adjust_register'.
 719         (i386_stap_adjust_register): Adjust signature and return new
 720         register name.
 721         * stap-probe.c (stap_parse_register_operand): Adjust use of
 722         'gdbarch_stap_adjust_register'.
 723
 724 2019-07-17  Tom Tromey  <tromey@adacore.com>
 725
 726         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 727         declare VEC.
 728         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 729         std::vector.
 730         (struct s390_process_info): Add initializers.
 731         (s390_add_process): Use new.
 732         (s390_linux_nat_target::low_forget_process): Use delete.
 733         (s390_linux_nat_target::low_new_fork)
 734         (s390_linux_nat_target::stopped_by_watchpoint)
 735         (s390_linux_nat_target::low_prepare_to_resume)
 736         (s390_linux_nat_target::insert_watchpoint)
 737         (s390_linux_nat_target::insert_hw_breakpoint)
 738         (s390_linux_nat_target::remove_watchpoint)
 739         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 740
 741 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 742
 743         * aarch64-fbsd-nat.c: Include regcache.h.
 744         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 745         argument.
 746         (aarch64_fbsd_nat_target::fetch_registers)
 747         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 748         variable.
 749         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 750
 751 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 752
 753         * fbsd-nat.c: Include gdbarch.h.
 754
 755 2019-07-15  Tom Tromey  <tromey@adacore.com>
 756
 757         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 758
 759 2019-07-15  Tom Tromey  <tromey@adacore.com>
 760
 761         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 762         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 763         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 764         * cli-out.c (cli_ui_out::do_field_int): New method.
 765         * ui-out.c (ui_out::field_unsigned): New method.
 766         * symfile.c (generic_load): Use field_unsigned.
 767         (print_transfer_performance): Likewise.
 768         * record-btrace.c (ui_out_field_uint): Remove.
 769         (btrace_call_history_insn_range, btrace_call_history): Use
 770         field_unsigned.
 771         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 772         field_unsigned.
 773         * ui-out.h (class ui_out) <field_unsigned>: New method.
 774         <do_field_unsigned>: Likewise.
 775
 776 2019-07-15  Tom Tromey  <tromey@adacore.com>
 777
 778         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 779         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 780         * target.c (flash_erase_command): Use field_string.
 781         * infrun.c (print_signal_received_reason): Use field_string.
 782         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 783         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 784         field_string.
 785         * ada-tasks.c (print_ada_task_info): Use field_string.
 786
 787 2019-07-15  Tom Tromey  <tromey@adacore.com>
 788
 789         * target.c (flash_erase_command): Use field_core_addr.
 790         * symfile.c (generic_load): Use field_core_addr.
 791         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 792         Use field_core_addr.
 793         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 794         field_core_addr.
 795
 796 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 797
 798         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 799         value if its desired type is smaller than a CORE_ADDR and signed.
 800
 801 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 802
 803         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 804         of changes to field names, and use new is_reference field to
 805         decide if a property is a reference or not.
 806         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 807         field.
 808         (struct dwarf2_property_baton): Update header comment, rename
 809         'referenced_type' to 'property_type' and update comments.
 810         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 811         default property type, store in property baton, update to take
 812         accound of renamed field.
 813         (read_func_scope): Update call to attr_to_dynamic_prop.
 814         (read_array_type): Likewise.
 815         (dwarf2_per_cu_addr_sized_int_type): New function.
 816         (read_subrange_index_type): Move type finding code to
 817         dwarf2_per_cu_addr_sized_int_type.
 818         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 819         (dwarf2_per_cu_addr_type): New function.
 820         (set_die_type): Update calls to attr_to_dynamic_prop.
 821
 822 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 823
 824         * dwarf2read.c (read_subrange_index_type): New function.
 825         (read_subrange_type): Move code into new function and call it.
 826         * gdbtypes.c (create_range_type): Add some asserts.
 827
 828 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 829
 830         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 831         update return statements.
 832         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 833         declaration, and update comment to match.
 834         * gdbtypes.c (resolve_dynamic_array): Update call to
 835         dwarf2_evaluate_property to match new return type.
 836
 837 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 838
 839         * valarith.c (value_subscripted_rvalue): Change lowerbound
 840         parameter type from int to LONGEST.
 841         * value.h (value_subscripted_rvalue): Likewise in declaration.
 842
 843 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 844
 845         * cli/cli-utils.c (info_print_command_completer): New function.
 846         * cli/cli-utils.h: Add 'completer.h' include, and forward
 847         declaration for 'struct cmd_list_element'.
 848         (info_print_command_completer): Declare.
 849         * stack.c (_initialize_stack): Add completer for 'info locals' and
 850         'info args'.
 851         * symtab.c (_initialize_symtab): Add completer for 'info
 852         variables' and 'info functions'.
 853         * NEWS: Mention completion for additional info commands.
 854
 855 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 856
 857         * cli/cli-utils.c (extract_info_print_args): Delete.
 858         (extract_arg_maybe_quoted): Delete.
 859         (info_print_options_defs): New variable.
 860         (make_info_print_options_def_group): New function.
 861         (extract_info_print_options): Define new function.
 862         * cli/cli-utils.h (extract_info_print_args): Delete.
 863         (struct info_print_options): New structure.
 864         (extract_info_print_options): Declare new function.
 865         * stack.c (info_locals_command): Update to use new
 866         extract_info_print_options, also add a header comment.
 867         (info_args_command): Likewise.
 868         * symtab.c (info_variables_command): Likewise.
 869         (info_functions_command): Likewise.
 870
 871 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 872
 873         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 874         to extract string arguments.
 875         * common/common-utils.c (extract_string_maybe_quoted): New function.
 876         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 877
 878 2019-07-11  Tom Tromey  <tromey@adacore.com>
 879
 880         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 881         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 882         * top.h (gdbinit): Don't declare.
 883         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 884         into...
 885         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 886         * top.c (gdb_init): Don't call init_cli_cmds.
 887         (gdbinit): Remove.
 888         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 889
 890 2019-07-11  Tom Tromey  <tromey@adacore.com>
 891
 892         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 893         after it has been moved.
 894
 895 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 896
 897         * valops.c (value_must_coerce_to_target): Change return type to
 898         bool.
 899         * value.h (value_must_coerce_to_target): Likewise.
 900
 901 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 902
 903         * breakpoint.c (is_hardware_watchpoint): Remove
 904         forward-declaration.
 905         (is_masked_watchpoint): Change return type to bool.
 906         (is_tracepoint): Likewise.
 907         (is_breakpoint): Likewise.
 908         (is_hardware_watchpoint): Likewise.
 909         (is_watchpoint): Likewise.
 910         (is_no_memory_software_watchpoint): Likewise.
 911         (is_catchpoint): Likewise.
 912         (breakpoint_1): Make FILTER parameter's return type bool.
 913         is_masked_watchpoint): Change return type to bool.
 914         (save_breakpoints): Make FILTER parameter's return type bool.
 915         * breakpoint.h (is_breakpoint): Change return type to bool.
 916         (is_watchpoint): Likewise.
 917         (is_catchpoint): Likewise.
 918         (is_tracepoint): Likewise.
 919
 920 2019-07-10  Tom Tromey  <tom@tromey.com>
 921
 922         * defs.h: Don't include gdbarch.h.
 923         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 924         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 925         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 926         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 927         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 928         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 929         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 930         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 931         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 932         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 933         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 934         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 935         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 936         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 937         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 938         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 939         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 940         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 941         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 942         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 943         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 944         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 945         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 946         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 947         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 948         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 949         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 950
 951 2019-07-10  Tom Tromey  <tromey@adacore.com>
 952
 953         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 954         * breakpoint.c (init_ada_exception_breakpoint): Register as
 955         bp_catchpoint.
 956         (print_one_breakpoint_location, print_one_breakpoint): Use
 957         is_ada_exception_catchpoint.
 958         * ada-lang.c (class ada_catchpoint_location): Pass
 959         bp_loc_software_breakpoint to bp_location constructor.
 960         (is_ada_exception_catchpoint): New function.
 961
 962 2019-07-10  Tom Tromey  <tromey@adacore.com>
 963
 964         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 965         VEC.
 966         (struct arm_exidx_entry): New method operator<.
 967         (struct arm_exidx_data) <section_maps>: Change type.
 968         (arm_exidx_data_free): Remove.
 969         (arm_exidx_data_key): Change type.  Move lower.
 970         (arm_exidx_new_objfile): Update.
 971         (arm_compare_exidx_entries): Remove.
 972         (arm_find_exidx_entry, _initialize_arm_tdep)
 973
 974 2019-07-10  Tom Tromey  <tromey@adacore.com>
 975
 976         * solib-spu.c (ocl_program_data_key): Change type.
 977         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 978         Update.
 979
 980 2019-07-10  Tom Tromey  <tromey@adacore.com>
 981
 982         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 983         (struct solib_aix_inferior_data) <library_list>: Change type.
 984         (solib_aix_inferior_data_handle): Change type.
 985         (get_solib_aix_inferior_data): Update.
 986         (solib_aix_free_library_list): Remove.
 987         (library_list_start_library): Update.
 988         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 989         return type.
 990         (solib_aix_get_library_list)
 991         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 992         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 993
 994 2019-07-10  Tom Tromey  <tromey@adacore.com>
 995
 996         * solib-dsbt.c (struct dsbt_info): Add initializers.
 997         (solib_dsbt_pspace_data): Change type.
 998         (dsbt_pspace_data_cleanup): Remove.
 999         (get_dsbt_info, _initialize_dsbt_solib): Update.
1000
1001 2019-07-10  Tom Tromey  <tromey@adacore.com>
1002
1003         * spu-tdep.c (spu_overlay_data): Change type.
1004         (spu_get_overlay_table, spu_overlay_new_objfile)
1005         (_initialize_spu_tdep): Update.
1006
1007 2019-07-10  Tom Tromey  <tromey@adacore.com>
1008
1009         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1010         destructor.
1011         (dbx_objfile_data_key): Change type and declare later.
1012         (DBX_SYMFILE_INFO): Rewrite.
1013         * dbxread.c (dbx_objfile_data_key): Change type.
1014         (dbx_symfile_init): Update.
1015         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1016         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1017         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1018
1019 2019-07-10  Tom Tromey  <tromey@adacore.com>
1020
1021         * jit.c (jit_program_space_key): Change type.  Move lower.
1022         (get_jit_program_space_data): Update.
1023         (jit_program_space_data_cleanup): Remove.
1024         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1025         Update.
1026         (struct jit_program_space_data): Add initializers.
1027
1028 2019-07-10  Tom Tromey  <tromey@adacore.com>
1029
1030         * solib-darwin.c (struct darwin_info): Add initializers.
1031         (solib_darwin_pspace_data): Change type.
1032         (darwin_pspace_data_cleanup): Remove.
1033         (get_darwin_info, _initialize_darwin_solib): Update.
1034
1035 2019-07-10  Tom Tromey  <tromey@adacore.com>
1036
1037         * remote-sim.c (struct sim_inferior_data): Add initializers,
1038         constructor, and destructor.
1039         (sim_inferior_data_key): Change type.  Move lower.
1040         (check_for_duplicate_sim_descriptor): Update.
1041         (get_sim_inferior_data): Use new.  Update.
1042         (~sim_inferior_data_cleanup): Rename from
1043         sim_inferior_data_cleanup.  Simplify.
1044         (gdbsim_close_inferior, simulator_command)
1045         (sim_command_completer, _initialize_remote_sim): Update.
1046         (next_pid, INITIAL_PID): Move earlier.
1047
1048 2019-07-10  Tom Tromey  <tromey@adacore.com>
1049
1050         * python/python-internal.h (create_thread_object): Return
1051         gdbpy_ref.
1052         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1053         * python/py-inferior.c (struct threadlist_entry): Add
1054         constructor.
1055         <thread_obj>: Now a gdbpy_ref.
1056         (thread_to_thread_object): Update.
1057         (add_thread_object): Use new.
1058         (delete_thread_object): Use delete.
1059         (infpy_threads): Update.
1060         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1061         GIL.
1062
1063 2019-07-10  Tom Tromey  <tromey@adacore.com>
1064
1065         * valops.c (value_cast): Specialize error message for Ada.
1066
1067 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1068
1069         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1070
1071 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1072
1073         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1074         bpstat_should_step): Return bool, adjust comments.
1075         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1076         bpstat_should_step): Likewise.
1077
1078 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1079
1080         * features/Makefile: Use feature target descriptions for Arm.
1081         * features/arm/arm-core.c: Generate new file.
1082         * features/arm/arm-fpa.c: Likewise.
1083         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1084         * features/arm/arm-m-profile.c: Likewise.
1085         * features/arm/arm-vfpv2.c: Likewise.
1086         * features/arm/arm-vfpv3.c: Likewise.
1087         * features/arm/xscale-iwmmxt.c: Likewise.
1088         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1089
1090 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1091
1092         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1093         ptrace earlier.
1094
1095 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1096
1097         * features/aarch64-pauth.c: Regenerate.
1098
1099 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1100
1101         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1102         bool.
1103         (bpstat_what): Use false instead of 0.
1104
1105 2019-07-09  Pedro Alves  <palves@redhat.com>
1106
1107         * break-catch-throw.c (is_exception_catchpoint): New.
1108         * breakpoint.c (print_one_breakpoint_location): New parameter
1109         'raw_loc'.  Handle it.  Use
1110         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1111         looking at the breakpoint's type.
1112         (print_one_breakpoint): If handling "maint info breakpoints", also
1113         print locations of exception catchpoints.
1114         * breakpoint.h (is_exception_catchpoint): Declare.
1115
1116 2019-07-09  Pedro Alves  <palves@redhat.com>
1117
1118         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1119         "addr" field.
1120         (allocate_location_exception_catchpoint): New.
1121         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1122         (initialize_throw_catchpoint_ops): Install
1123         allocate_location_exception_catchpoint as allocate_location
1124         method.
1125         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1126         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1127         bp_loc_other.
1128         (breakpoint_address_is_meaningful): Delete.
1129         (bl_address_is_meaningful): New.
1130         (breakpoint_locations_match): Adjust comment.
1131         (bp_location_from_bp_type): New, factored out of...
1132         (bp_location::bp_location(breakpoint *)): ... this.
1133         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1134         factored out of...
1135         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1136         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1137         breakpoint_address_is_meaningful.
1138         (bp_locations_compare): Adjust comment.
1139         (update_global_location_list): Use bl_address_is_meaningful
1140         instead of breakpoint_address_is_meaningful.
1141         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1142         explicit.
1143         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1144         * python/py-breakpoint.c (bppy_get_location): No longer check
1145         whether location is null.
1146
1147 2019-07-09  Pedro Alves  <palves@redhat.com>
1148
1149         PR c++/15468
1150         * breakpoint.c (print_one_breakpoint_location): Remove
1151         single-location assert.
1152
1153 2019-07-09  Tom Tromey  <tom@tromey.com>
1154
1155         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1156         * configure: Rebuild.
1157         * configure.ac: Change common to gdbsupport.
1158         * gdbsupport: Rename from common.
1159         * acinclude.m4: Change common to gdbsupport.
1160         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1161         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1162         gdbsupport.
1163         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1164         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1165         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1166         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1167         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1168         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1169         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1170         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1171         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1172         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1173         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1174         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1175         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1176         coff-pe-read.c, command.h, compile/compile-c-support.c,
1177         compile/compile-c.h, compile/compile-cplus-symbols.c,
1178         compile/compile-cplus-types.c, compile/compile-cplus.h,
1179         compile/compile-loc2c.c, compile/compile.c, completer.c,
1180         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1181         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1182         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1183         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1184         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1185         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1186         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1187         features/aarch64-core.c, features/aarch64-fpu.c,
1188         features/aarch64-pauth.c, features/aarch64-sve.c,
1189         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1190         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1191         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1192         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1193         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1194         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1195         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1196         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1197         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1198         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1199         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1200         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1201         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1202         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1203         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1204         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1205         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1206         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1207         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1208         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1209         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1210         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1211         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1212         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1213         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1214         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1215         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1216         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1217         minsyms.c, mips-linux-tdep.c, namespace.h,
1218         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1219         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1220         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1221         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1222         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1223         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1224         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1225         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1226         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1227         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1228         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1229         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1230         procfs.c, producer.c, progspace.h, psymtab.h,
1231         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1232         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1233         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1234         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1235         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1236         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1237         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1238         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1239         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1240         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1241         target-memory.c, target.c, target.h, target/waitstatus.c,
1242         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1243         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1244         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1245         unittests/array-view-selftests.c,
1246         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1247         unittests/common-utils-selftests.c,
1248         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1249         unittests/format_pieces-selftests.c,
1250         unittests/function-view-selftests.c,
1251         unittests/lookup_name_info-selftests.c,
1252         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1253         unittests/mkdir-recursive-selftests.c,
1254         unittests/observable-selftests.c,
1255         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1256         unittests/parse-connection-spec-selftests.c,
1257         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1258         unittests/scoped_fd-selftests.c,
1259         unittests/scoped_mmap-selftests.c,
1260         unittests/scoped_restore-selftests.c,
1261         unittests/string_view-selftests.c, unittests/style-selftests.c,
1262         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1263         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1264         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1265         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1266         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1267         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1268
1269 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1270
1271         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1272         bool value.
1273         (decode_digits_ordinary): Set explicit_line field in sal.
1274         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1275         symtab_and_line that was set on an explicit line number in
1276         assembler code.  Do always update the recorded symtab and line if
1277         we do skip the prologue.
1278
1279 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1280
1281         * breakpoint.c (set_breakpoint_location_function): Remove
1282         explicit_loc parameter.
1283         (momentary_breakpoint_from_master): Update call to
1284         set_breakpoint_location_function.
1285         (add_location_to_breakpoint): Likewise.
1286
1287 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1290         required features based on default bfd type when no specific bfd
1291         is present.
1292
1293 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1294
1295         * NEWS: Mention that GDB printf and eval commands can now print
1296         C-style and Ada-style convenience var strings without
1297         calling the inferior.
1298         * printcmd.c (printf_c_string): Locally print GDB internal var
1299         instead of transiting via the inferior.
1300         (printf_wide_c_string): Likewise.
1301
1302 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1303
1304         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1305
1306 2019-07-04  Tom Tromey  <tom@tromey.com>
1307
1308         PR tui/24724:
1309         * tui/tui-winsource.c (tui_clear_source_content): Update.
1310         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1311         (tui_update_breakpoint_info): Update.
1312         (tui_set_exec_info_content): Update.
1313         * tui/tui-source.c (tui_set_source_content_nil): Update.
1314         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1315         has_break.
1316         * tui/tui-data.h (enum tui_bp_flag): New.
1317         (tui_bp_flags): New enum flags type.
1318         (struct tui_source_element) <break_mode>: Change type.  Rename
1319         from has_break.
1320         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1321         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1322         constants.
1323         * tui/tui-winsource.h: Fix comment.
1324
1325 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1326
1327         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1328         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1329         (store_fpregs_to_thread)
1330         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1331         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1332         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1333         (IWMMXT_REGS_SIZE): Add define.
1334         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1335         (fetch_vfp_regs, store_vfp_regs)
1336         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1337         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1338
1339 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1340
1341         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1342         defines.
1343         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1344         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1345         (ARM_INT_REGISTER_SIZE): ...to this.
1346         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1347         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1348         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1349         (arm_linux_collect_gregset, supply_nwfpe_register)
1350         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1351         defines.
1352         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1353         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1354         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1355         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1356         (arm_return_in_memory, arm_store_return_value)
1357         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1358         (arm_record_ld_st_multiple): Likewise.
1359         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1360         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1361
1362 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1363
1364         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1365         AARCH64_DISPLACED_MODIFIED_INSNS.
1366         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1367         (aarch64_displaced_step_copy_insn): Likewise.
1368         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1369         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1370         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1371         ARM_DISPLACED_MODIFIED_INSNS.
1372         * arm-tdep.c (arm_gdbarch_init): Likewise.
1373         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1374         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1375         (struct arm_displaced_step_closure): Use
1376         ARM_DISPLACED_MODIFIED_INSNS.
1377
1378 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1379
1380         * features/Makefile: Remove unused xml files.
1381         * features/aarch64.xml: Remove.
1382         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1383         * features/i386/amd64-avx-avx512.xml: Remove.
1384         * features/i386/amd64-avx-linux.xml: Remove.
1385         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1386         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1387         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1388         * features/i386/amd64-avx-mpx.xml: Remove.
1389         * features/i386/amd64-avx.xml: Remove.
1390         * features/i386/amd64-linux.xml: Remove.
1391         * features/i386/amd64-mpx-linux.xml: Remove.
1392         * features/i386/amd64-mpx.xml: Remove.
1393         * features/i386/amd64.xml: Remove.
1394         * features/i386/i386-avx-avx512-linux.xml: Remove.
1395         * features/i386/i386-avx-avx512.xml: Remove.
1396         * features/i386/i386-avx-linux.xml: Remove.
1397         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1398         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1399         * features/i386/i386-avx-mpx-linux.xml: Remove.
1400         * features/i386/i386-avx-mpx.xml: Remove.
1401         * features/i386/i386-avx.xml: Remove.
1402         * features/i386/i386-linux.xml: Remove.
1403         * features/i386/i386-mmx-linux.xml: Remove.
1404         * features/i386/i386-mmx.xml: Remove.
1405         * features/i386/i386-mpx-linux.xml: Remove.
1406         * features/i386/i386-mpx.xml: Remove.
1407         * features/i386/i386.xml: Remove.
1408         * features/i386/x32-avx-avx512-linux.xml: Remove.
1409         * features/i386/x32-avx-linux.xml: Remove.
1410         * features/i386/x32-linux.xml: Remove.
1411
1412 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1413
1414         * regformats/aarch64.dat: Remove.
1415         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1416         * regformats/i386/amd64-avx-linux.dat: Remove.
1417         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1418         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1419         * regformats/i386/amd64-linux.dat: Remove.
1420         * regformats/i386/amd64-mpx-linux.dat: Remove.
1421         * regformats/i386/amd64.dat: Remove.
1422         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1423         * regformats/i386/i386-avx-linux.dat: Remove.
1424         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1425         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1426         * regformats/i386/i386-linux.dat: Remove.
1427         * regformats/i386/i386-mmx-linux.dat: Remove.
1428         * regformats/i386/i386-mpx-linux.dat: Remove.
1429         * regformats/i386/i386.dat: Remove.
1430         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1431         * regformats/i386/x32-avx-linux.dat: Remove.
1432         * regformats/i386/x32-linux.dat: Remove.
1433
1434 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1435
1436         * aarch64-tdep.c: Remove xml self tests.
1437         * amd64-linux-tdep.c: Likewise.
1438         * amd64-tdep.c: Likewise.
1439         * i386-linux-tdep.c: Likewise.
1440         * i386-tdep.c: Likewise.
1441
1442 2019-07-03  Pedro Alves  <palves@redhat.com>
1443
1444         PR cli/24732
1445         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1446         (pipe_cmd_option_defs): New.
1447         (make_pipe_cmd_options_def_group): New.
1448         (pipe_command): Use gdb::option::process_options.
1449         (pipe_command_completer): New function.
1450         (_initialize_cli_cmds): Install completer for "pipe" command.
1451
1452 2019-07-03  Pedro Alves  <palves@redhat.com>
1453
1454         * cli/cli-option.c (union option_value) <string>: New field.
1455         (struct option_def_and_value): Add ctor, move ctor, dtor and
1456         use DISABLE_COPY_AND_ASSIGN.
1457         (option_def_and_value::clear_value): New.
1458         (parse_option, save_option_value_in_ctx, get_val_type_str)
1459         (add_setshow_cmds_for_options): Handle var_string.
1460         * cli-option.h (union option_def::var_address) <string>: New
1461         field.
1462         (struct string_option_def): New.
1463         * maint-test-options.c (struct test_options_opts): Add default
1464         ctor and use DISABLE_COPY_AND_ASSIGN.
1465         <string_opt>: New field.
1466         (test_options_opts::~test_options_opts): New.
1467         (test_options_opts::dump): Also dump "-string".
1468         (test_options_option_defs): Install "string.
1469
1470 2019-07-03  Pedro Alves  <palves@redhat.com>
1471
1472         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1473         option_value with a null enumeration.
1474         (complete_options): Save the option values in the context.
1475         (save_option_value_in_ctx): New, factored out from ...
1476         (process_options): ... here.
1477         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1478         of the function.
1479         * maint-test-options.c (test_options_opts::dump): New, factored
1480         out from ...
1481         (maintenance_test_options_command_mode): ... here.
1482         (maintenance_test_options_command_completion_result): Delete.
1483         (maintenance_test_options_command_completion_text): Update
1484         comment.
1485         (maintenance_show_test_options_completion_result): Change
1486         prototype.  Just print
1487         maintenance_test_options_command_completion_text.
1488         (save_completion_result): New.
1489         (maintenance_test_options_completer_mode): Pass options context to
1490         complete_options, and then save a dump.
1491         (_initialize_maint_test_options): Use add_cmd to install "maint
1492         show test-options-completion-result".
1493
1494 2019-07-03  Pedro Alves  <palves@redhat.com>
1495
1496         * NEWS (New commands): Mention "with" and "maint with".
1497         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1498         (with_command, with_command_completer): New.
1499         (pipe_command): Adjust to new repeat_previous
1500         interface.
1501         (_initialize_cli_cmds): Install the "with" command and its "w"
1502         alias.
1503         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1504         declarations.
1505         * cli/cli-setshow.c (parse_cli_var_uinteger)
1506         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1507         argument strings for all var_types.
1508         (get_setshow_command_value_string): New, factored out from ...
1509         (do_show_command): ... this.
1510         * cli/cli-setshow.h: Include <string>.
1511         (get_setshow_command_value_string): Declare.
1512         * command.h (repeat_previous): Now returns const char *.  Adjust
1513         comment.
1514         * maint.c: Include "cli/cli-cmds.h".
1515         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1516         (_initialize_maint_cmds): Register the "maintenance with" command.
1517         * top.c (repeat_previous): Move bits from pipe_command here:
1518         Return the saved command line, if any; error out if there's no
1519         command to relaunch.
1520
1521 2019-07-03  Pedro Alves  <palves@redhat.com>
1522
1523         * NEWS (New commands): Mention "maint set/show test-settings"
1524         instead of "maint test-settings".
1525         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1526         (maintenance_test_settings_set_list): Rename to ...
1527         (maintenance_set_test_settings_list): ... this.
1528         (maintenance_test_settings_show_list): Rename to  ...
1529         (maintenance_show_test_settings_list): ... this.
1530         (maintenance_test_settings_cmd): Delete.
1531         (maintenance_test_settings_set_cmd): ...
1532         (maintenance_set_test_settings_cmd): ... this.
1533         (maintenance_test_settings_show_cmd): ...
1534         (maintenance_show_test_settings_cmd): ... this.
1535         (maintenance_test_settings_show_value_cmd):
1536         (maintenance_show_test_settings_value_cmd): ... this.
1537         (_initialize_maint_test_settings): No longer install the "maint
1538         test-settings" prefix command.  Rename "maint test-settings set"
1539         to "maint set test-settings", and "maint test-settings show" to
1540         "maint show test-settings".  Adjust all subcommands.
1541
1542 2019-07-03  Pedro Alves  <palves@redhat.com>
1543
1544         * maint-test-settings.c: Fix file's intro comment.  Replace all
1545         references to "test-options" with references to "test-settings",
1546         in comments.
1547
1548 2019-07-03  Pedro Alves  <palves@redhat.com>
1549
1550         * maint-test-settings.c (maintenance_test_settings_xxx)
1551         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1552         New.
1553         (maintenance_test_settings_enums): Use them.
1554         (maintenance_test_settings_enum): Default to
1555         maintenance_test_settings_xxx.
1556         (_initialize_maint_test_settings): Initialize
1557         MAINTENANCE_TEST_SETTINGS_FILENAME.
1558
1559 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1560
1561         * breakpoint.h (remove_breakpoints_inf): Change return type to
1562         void, move function documentation here.
1563         * breakpoint.c (remove_breakpoints_inf): Change return type to
1564         void, move function documentation to header.
1565
1566 2019-07-02  Pedro Alves  <palves@redhat.com>
1567
1568         * NEWS (Completion improvements): Mention "info threads".
1569         * thread.c (struct info_threads_opts, info_threads_option_defs)
1570         (make_info_threads_options_def_group): New.
1571         (info_threads_command): Use gdb::option::process_options.
1572         (info_threads_command_completer): New.
1573         (_initialize_thread): Use gdb::option::build_help to build the
1574         help text for "info threads".
1575
1576 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1577
1578         * defs.h (generic_load): Move from here...
1579         * symfile.h (generic_load): ... to here.  Rename name parameter
1580         to args.
1581         * symfile.c (generic_load): Add comment.
1582
1583 2019-07-01  Tom Tromey  <tromey@adacore.com>
1584
1585         * dwarf2read.c
1586         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1587         declaration of without_params.  Fix formatting.
1588
1589 2019-07-01  Tom Tromey  <tromey@adacore.com>
1590
1591         * ada-exp.y (find_primitive_type): Update.
1592         * ada-lang.h (ada_lookup_symbol): Update.
1593         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1594         parameter.
1595         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1596
1597 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1598
1599         PR breakpoints/24541
1600         * gdbarch.c: Regenerate.
1601         * gdbarch.h: Regenerate.
1602         * gdbarch.sh: Add 'stap_adjust_register'.
1603         * i386-tdep.c: Include '<unordered_set>'.
1604         (i386_stap_adjust_register): New function.
1605         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1606         * stap-probe.c (stap_parse_register_operand): Call
1607         'gdbarch_stap_adjust_register'.
1608
1609 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1610
1611         PR python/24742
1612         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1613         * python/python.c (do_start_initialization): Use 'xmalloc'
1614         instead of 'PyMem_Malloc'.
1615
1616 2019-06-28  Tom Tromey  <tromey@adacore.com>
1617
1618         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1619         for Ada.
1620
1621 2019-06-27  Tom Tromey  <tromey@adacore.com>
1622
1623         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1624         objfile_key.
1625         (arm_find_mapping_symbol, arm_record_special_symbol)
1626         (_initialize_arm_tdep): Update.
1627         (arm_objfile_data_free): Remove.
1628
1629 2019-06-27  Tom Tromey  <tromey@adacore.com>
1630
1631         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1632         to cp_print_static_field.
1633
1634 2019-06-26  Tom Tromey  <tromey@adacore.com>
1635
1636         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1637         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1638         declare.
1639
1640 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1641
1642         * features/aarch64-core.c (create_feature_aarch64_core):
1643         Regenerate.
1644         * features/aarch64-core.xml: Add cpsr flags.
1645
1646 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1647
1648         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1649         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1650
1651 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1652
1653         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1654         field.
1655         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1656         use.
1657         (arm_record_special_symbol): Don't insert new symbol in sorted
1658         position, push it at the end.
1659
1660 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1661
1662         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1663         (arm_mapping_symbol_s): Remove.
1664         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1665         (arm_mapping_symbol_vec): New typedef.
1666         (struct arm_per_objfile): Add constructor.
1667         <section_maps>: Change type to
1668         std::unique_ptr<arm_mapping_symbol_vec[]>.
1669         (arm_compare_mapping_symbols): Remove.
1670         (arm_find_mapping_symbol): Adjust to section_maps type change.
1671         (arm_objfile_data_free): Call delete on arm_per_objfile.
1672         (arm_record_special_symbol): Adjust to section_maps type change.
1673         Allocate arm_per_objfile with new.
1674
1675 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1676
1677         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1678         with the command prefix.
1679
1680 2019-06-25  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1683         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1684
1685 2019-06-25  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1688         type.
1689         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1690         protected.
1691
1692 2019-06-25  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-winsource.c
1695         (tui_source_window_base::set_is_exec_point_at): Add check against
1696         LOA_ADDRESS.
1697
1698 2019-06-25  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-source.c (tui_set_source_content): Don't check before
1701         xfree.
1702         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1703
1704 2019-06-25  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-winsource.h (tui_update_source_window_as_is)
1707         (tui_alloc_source_buffer, tui_line_is_displayed)
1708         (tui_addr_is_displayed): Change type of win_info.
1709         * tui/tui-winsource.c (tui_update_source_window_as_is)
1710         (tui_clear_source_content, tui_show_source_line)
1711         (tui_show_source_content, tui_source_window_base::refill)
1712         (tui_source_window_base::set_is_exec_point_at)
1713         (tui_source_window_base::set_is_exec_point_at)
1714         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1715         (tui_alloc_source_buffer, tui_line_is_displayed)
1716         (tui_addr_is_displayed): Change type of win_info.  Update.
1717         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1718         (tui_source_window_base::do_make_visible_with_new_height):
1719         Update.
1720         * tui/tui-source.c (tui_set_source_content)
1721         (tui_set_source_content_nil)
1722         (tui_source_window::do_scroll_vertical): Update.
1723         * tui/tui-layout.c (show_layout): Update.
1724         * tui/tui-disasm.c (tui_set_disassem_content)
1725         (tui_disasm_window::do_scroll_vertical): Update.
1726         * tui/tui-data.h (tui_win_content): Remove.
1727         (struct tui_gen_win_info) <content, content_size>: Remove.
1728         (struct tui_source_element): Add initializers and destructor.
1729         (union tui_which_element, struct tui_win_element): Remove.
1730         (struct tui_source_window_base) <content>: New field.
1731         (struct tui_data_window): Remove destructor.
1732         (tui_alloc_content, tui_free_win_content)
1733         (tui_free_all_source_wins_content): Don't declare.
1734         * tui/tui-data.c (tui_initialize_static_data): Update.
1735         (init_content_element, tui_alloc_content): Remove.
1736         (~tui_gen_win_info): Update.
1737         (~tui_data_window, tui_free_all_source_wins_content)
1738         (tui_free_win_content, free_content, free_content_elements):
1739         Remove.
1740
1741 2019-06-25  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-winsource.h (tui_clear_source_content)
1744         (tui_erase_source_content, tui_show_source_content): Change type
1745         of win_info.
1746         * tui/tui-winsource.c (tui_clear_source_content)
1747         (tui_erase_source_content, tui_show_source_content): Change type
1748         of win_info.
1749         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1750         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1751         win_info.
1752         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1753         win_info.
1754         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1755
1756 2019-06-25  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-winsource.c (tui_clear_source_content)
1759         (tui_source_window_base::set_is_exec_point_at): Update.
1760         * tui/tui-source.c (tui_set_source_content_nil): Update.
1761         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1762         a bool.
1763         * tui/tui-data.c (init_content_element): Update.
1764
1765 2019-06-25  Tom Tromey  <tom@tromey.com>
1766
1767         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1768         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1769         * tui/tui-layout.c (init_and_make_win): Update.
1770         * tui/tui.h (enum tui_win_type): Update.
1771         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1772         tui_win_is_auxillary.
1773         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1774         tui_win_is_auxillary.
1775
1776 2019-06-25  Tom Tromey  <tom@tromey.com>
1777
1778         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1779         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1780         (tui_delete_data_content_windows, tui_display_all_data)
1781         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1782         Update.
1783         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1784         * tui/tui-regs.c (tui_last_regs_line_no)
1785         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1786         (tui_show_registers): Update.
1787         (tui_show_register_group): Return void.  Update.
1788         (tui_display_registers_from, tui_display_reg_element_at_line)
1789         (tui_display_registers_from_line, tui_check_register_values):
1790         Update.
1791         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1792         member.
1793         (struct tui_data_window) <regs_content>: Now a std::vector.
1794         <regs_content_count>: Remove.
1795         (tui_add_content_elements, tui_free_data_content): Don't declare.
1796         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1797         (init_content_element): Remove DATA_WIN case.  Add assert.
1798         (tui_add_content_elements): Remove.
1799         (tui_data_window): Update.
1800         (tui_free_data_content): Remove.
1801         (free_content_elements): Remove DATA_WIN case.
1802
1803 2019-06-25  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-data.c (tui_data_item_window): Update.
1806         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1807         * tui/tui-windata.c (tui_display_all_data)
1808         (tui_display_data_from_line): Update.
1809         (tui_check_data_values): Remove.
1810         * tui/tui-regs.c (tui_show_register_group)
1811         (tui_display_reg_element_at_line): Update.
1812         * tui/tui-hooks.c (tui_register_changed)
1813         (tui_refresh_frame_and_register_information): Call
1814         tui_check_register_values.
1815         * tui/tui-data.h (struct tui_data_window) <data_content,
1816         data_content_count, data_type>: Remove.
1817         (enum tui_data_type): Remove.
1818
1819         * tui/tui-data.c (tui_data_window::clear_detail)
1820         (~tui_data_window): Update.
1821
1822 2019-06-25  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1825         declare.
1826         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1827         Rename from tui_first_data_item_displayed.  Update.
1828         (tui_data_window::refresh_all)
1829         (tui_data_window::do_scroll_vertical): Update.
1830         * tui/tui-data.h (struct tui_data_window)
1831         <first_data_item_displayed>: Declare new method.
1832
1833 2019-06-25  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1836         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1837         contents...
1838         (tui_initialize_static_data): ...here.
1839
1840 2019-06-25  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1843         (tui_display_registers_from, tui_check_register_values): Update.
1844         (tui_display_register): Remove win_info parameter; update.
1845         (tui_get_register): Change type of parameters.
1846         * tui/tui-data.h (struct tui_data_element): Remove.
1847         (union tui_which_element) <data>: Remove.
1848         <data_window>: Change type.
1849         (struct tui_data_item_window): New.
1850         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1851         case.  Add assert.
1852         (~tui_data_item_window): New destructor.
1853         (free_content_elements): Remove DATA_ITEM_WIN case.
1854
1855 2019-06-25  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1858         Remove.
1859
1860 2019-06-25  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-data.h (struct tui_command_element): Remove.
1863         (union tui_which_element) <command>: Remove.
1864         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1865         assert.
1866         (free_content_elements): Remove CMD_WIN case.
1867
1868 2019-06-25  Tom Tromey  <tom@tromey.com>
1869
1870         * tui/tui-layout.c (tui_set_layout): Update.
1871         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1872         * tui/tui-data.c (layout_def): Update.
1873
1874 2019-06-25  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1877         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1878         (tui_source_window_base::set_new_height): Update.
1879         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1880         Update.
1881         (tui_set_locator_fullname, tui_set_locator_info)
1882         (tui_show_frame_info): Update.
1883         * tui/tui-source.c (tui_set_source_content)
1884         (tui_source_is_displayed): Update.
1885         * tui/tui-layout.c (show_source_disasm_command, show_data)
1886         (show_source_or_disasm_and_command): Update.
1887         * tui/tui-disasm.c (tui_set_disassem_content)
1888         (tui_get_begin_asm_address): Update.
1889         * tui/tui-data.h (struct tui_locator_element): Remove.
1890         (union tui_which_element) <locator>: Remove.
1891         (struct tui_locator_window): New.
1892         (tui_locator_win_info_ptr): Change return type.
1893         * tui/tui-data.c (_locator): Change type.
1894         (tui_locator_win_info_ptr): Change return type.
1895         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1896         (tui_alloc_content): Add assert.
1897
1898 2019-06-25  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-winsource.c
1901         (tui_exec_info_window::maybe_allocate_content): New method.
1902         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1903         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1904         (make_source_or_disasm_window): Add cast.
1905         * tui/tui-data.h (union tui_which_element) <simple_string>:
1906         Remove.
1907         (struct tui_source_info): New.
1908         (struct tui_source_window_base) <execution_info>: Change type.
1909         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1910         case, and add assert.
1911         (tui_alloc_content): Add assert.
1912
1913 2019-06-25  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1916         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1917         * tui/tui-data.c (tui_alloc_win_info): Remove.
1918
1919 2019-06-25  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1922         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1923         can_highlight.
1924
1925 2019-06-25  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1928         make_visible_with_new_height method.
1929         (tui_win_info::make_visible_with_new_height): New method.
1930         (tui_source_window_base::do_make_visible_with_new_height)
1931         (tui_data_window::do_make_visible_with_new_height)
1932         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1933         (make_visible_with_new_height): Remove.
1934         (tui_resize_all, tui_adjust_win_heights): Use
1935         make_visible_with_new_height method.
1936         * tui/tui-data.h (struct tui_win_info)
1937         <do_make_visible_with_new_height, make_visible_with_new_height>:
1938         New methods.
1939         (struct tui_source_window_base, struct tui_data_window)
1940         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1941         methods.
1942
1943 2019-06-25  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1946         method.
1947         (update_tab_width): Call update_tab_width method.
1948         * tui/tui-data.h (struct tui_win_info)
1949         (struct tui_source_window_base) <update_tab_width>: New methods.
1950
1951 2019-06-25  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1954         parameter.
1955         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1956         parameter.
1957         (tui_gen_win_info::make_visible): Update.
1958         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1959         parameter.
1960         * tui/tui-data.h (enum tui_box): New enum.
1961         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1962
1963 2019-06-25  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1966         init_and_make_win for EXEC_INFO_WIN.
1967         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1968         longer inline.
1969         (struct tui_win_info) <~tui_win_info>: Inline.
1970         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1971         Don't declare.
1972         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1973         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1974         Remove.
1975         (tui_initialize_static_data): Update.
1976         (~tui_gen_win_info): Handle more cleanup here.
1977         (~tui_source_window_base): Delete "execution_info".
1978         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1979
1980 2019-06-25  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui-layout.c (make_command_window): Don't set
1983         can_highlight.
1984         (show_source_disasm_command): Call the reset method.
1985         (show_data): Don't set can_highlight.  Call the reset method.
1986         (tui_gen_win_info::reset): Rename from init_gen_win_info
1987         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1988         (show_source_or_disasm_and_command): Call the reset method.
1989         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1990         (struct tui_cmd_window): Set can_highlight.
1991
1992 2019-06-25  Tom Tromey  <tom@tromey.com>
1993
1994         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1995         from make_visible.
1996         (tui_make_visible, tui_make_invisible): Rewrite.
1997         (tui_win_info::make_visible): Remove.
1998         (tui_source_window_base::make_visible): Update.
1999         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2000         method.  Moved from...
2001         (struct tui_win_info) <make_visible>: ...here.
2002
2003 2019-06-25  Tom Tromey  <tom@tromey.com>
2004
2005         * tui/tui-winsource.c
2006         (tui_source_window_base::do_scroll_horizontal): Remove direction
2007         parameter.
2008         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2009         direction parameter.
2010         * tui/tui-win.c (tui_win_info::forward_scroll)
2011         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2012         (tui_win_info::right_scroll): Update.
2013         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2014         direction parameter.
2015         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2016         direction parameter.
2017         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2018         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2019         Remove direction parameter.
2020         (struct tui_source_window_base, struct tui_source_window)
2021         (struct tui_disasm_window, struct tui_data_window)
2022         (struct tui_cmd_window): Update.
2023
2024 2019-06-25  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-winsource.h (tui_set_exec_info_content)
2027         (tui_show_exec_info_content, tui_erase_exec_info_content)
2028         (tui_clear_exec_info_content, tui_update_exec_info): Change
2029         argument to tui_source_window_base.
2030         * tui/tui-winsource.c (tui_set_exec_info_content)
2031         (tui_show_exec_info_content, tui_erase_exec_info_content)
2032         (tui_clear_exec_info_content, tui_update_exec_info): Change
2033         argument to tui_source_window_base.
2034
2035 2019-06-25  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2038         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2039
2040 2019-06-25  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2043         check.
2044
2045 2019-06-25  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2048         type to void.
2049         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2050         type to void.
2051         * tui/tui-source.c (tui_set_source_content): Update.
2052         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2053
2054 2019-06-25  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-win.c (window_name_completer, tui_set_focus)
2057         (tui_all_windows_info): Use name method.
2058         * tui/tui-data.h (struct tui_gen_win_info)
2059         (struct tui_source_window, struct tui_disasm_window)
2060         (struct tui_data_window, struct tui_cmd_window) <name>: New
2061         method.
2062         (tui_win_name): Don't declare.
2063         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2064         (tui_win_name): Remove.
2065
2066 2019-06-25  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-winsource.h (tui_update_source_window)
2069         (tui_update_source_window_as_is): Change parameter type.
2070         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2071         to be a tui_source_window_base.
2072         (tui_update_source_window_as_is): Likewise.
2073         * tui/tui-win.c (make_visible_with_new_height): Update.
2074
2075 2019-06-25  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-winsource.c (tui_erase_source_content)
2078         (tui_show_source_content, tui_show_exec_info_content)
2079         (tui_erase_exec_info_content): Use refresh_window method.
2080         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2081         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2082         from tui_refresh_win.
2083         (tui_data_window::refresh_window): New method.
2084         (tui_win_info::refresh, tui_source_window_base::refresh)
2085         (tui_refresh_all): Use refresh_window method.
2086         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2087         method.
2088         * tui/tui-regs.c (tui_display_register): Call refresh_window
2089         method.
2090         * tui/tui-layout.c (show_source_disasm_command)
2091         (show_source_or_disasm_and_command): Call refresh_window method.
2092         * tui/tui-data.h (struct tui_gen_win_info)
2093         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2094         New method.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui.c (tui_rl_other_window, tui_enable)
2099         (tui_is_window_visible, tui_get_command_dimension): Update.
2100         * tui/tui-winsource.c (tui_update_source_window_as_is)
2101         (tui_clear_source_content, tui_erase_source_content)
2102         (tui_show_source_line, tui_source_window_base::refill)
2103         (tui_source_window_base::do_scroll_horizontal)
2104         (tui_source_window_base::set_is_exec_point_at)
2105         (tui_update_breakpoint_info, tui_set_exec_info_content)
2106         (tui_alloc_source_buffer, tui_line_is_displayed)
2107         (tui_addr_is_displayed): Update.
2108         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2109         (tui_check_and_display_highlight_if_needed)
2110         (tui_win_info::make_visible, tui_win_info::refresh)
2111         (tui_refresh_all): Update.
2112         * tui/tui-windata.c (tui_first_data_item_displayed)
2113         (tui_delete_data_content_windows, tui_erase_data_content)
2114         (tui_display_all_data, tui_data_window::refresh_all)
2115         (tui_check_data_values): Update.
2116         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2117         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2118         (tui_win_info::backward_scroll, tui_refresh_all_win)
2119         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2120         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2121         (tui_source_window_base::set_new_height)
2122         (tui_data_window::set_new_height)
2123         (make_invisible_and_set_new_height)
2124         (make_visible_with_new_height, new_height_ok)
2125         (parse_scrolling_args): Update.
2126         * tui/tui-stack.c (tui_show_frame_info): Update.
2127         * tui/tui-source.c (tui_set_source_content)
2128         (tui_set_source_content_nil, tui_source_is_displayed)
2129         (tui_source_window::do_scroll_vertical): Update.
2130         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2131         (tui_display_registers_from, tui_display_reg_element_at_line)
2132         (tui_check_register_values, tui_reg_command): Update.
2133         * tui/tui-layout.c (tui_default_win_height)
2134         (show_source_disasm_command, show_data, init_and_make_win)
2135         (show_source_or_disasm_and_command): Update.
2136         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2137         (tui_redisplay_readline, tui_mld_flush)
2138         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2139         (tui_getc): Update.
2140         * tui/tui-disasm.c (tui_set_disassem_content)
2141         (tui_disasm_window::do_scroll_vertical): Update.
2142         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2143         Now virtual.
2144         (struct tui_win_info): Derive from tui_gen_win_info.
2145         <~tui_win_info>: Mark as override.
2146         <generic>: Remove member.
2147         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2148         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2149         (~tui_data_window, ~tui_win_info)
2150         (tui_free_all_source_wins_content): Update.
2151         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2152
2153 2019-06-25  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-layout.c (init_and_make_win): Use new.
2156         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2157         destructor, initializers.
2158         (tui_alloc_generic_win_info): Don't declare.
2159         * tui/tui-data.c (_locator): Add argument to constructor.
2160         (source_win, disasm_win): New globals.
2161         (exec_info): Remove.
2162         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2163         Update.
2164         (tui_alloc_generic_win_info): Remove.
2165         (init_content_element): Use new.
2166         (tui_win_info::tui_win_info): Update.
2167         (free_content_elements) <case DATA_WIN>: Use delete.
2168
2169 2019-06-25  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2172         * tui/tui-windata.c (tui_first_data_item_displayed)
2173         (tui_delete_data_content_windows): Update.
2174         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2175         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2176         (tui_display_registers_from, tui_check_register_values): Update.
2177         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2178         pointer.
2179         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2180         window.
2181         (tui_free_data_content): Update.
2182         (free_content_elements) <case DATA_WIN>: Free the window.
2183
2184 2019-06-25  Tom Tromey  <tom@tromey.com>
2185
2186         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2187         Update.
2188         * tui/tui-layout.c (make_command_window)
2189         (show_source_disasm_command, show_data, init_and_make_win)
2190         (show_source_or_disasm_and_command): Update.
2191         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2192         method.
2193         <can_highight, is_highlighted>: Now bool.
2194         (tui_set_win_highlight): Don't declare.
2195         * tui/tui-data.c (tui_set_win_highlight): Remove.
2196
2197 2019-06-25  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-wingeneral.c (make_visible): Remove check of window
2200         type.
2201
2202 2019-06-25  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-win.c (tui_win_info::max_height)
2205         (tui_cmd_window::max_height): New methods.
2206         (new_height_ok): Call max_height.
2207         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2208         <max_height>: New method.
2209
2210 2019-06-25  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-win.c (tui_source_window_base::set_new_height)
2213         (tui_data_window::set_new_height): New methods.
2214         (make_invisible_and_set_new_height): Call set_new_height method.
2215         * tui/tui-data.h (struct tui_win_info)
2216         (struct tui_source_window_base, struct tui_data_window)
2217         <set_new_height>: New method.
2218
2219 2019-06-25  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2222         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2223         tui_refresh_data_win.
2224         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2225         method.
2226         (tui_refresh_all_win): Call the refresh_all method.
2227         (tui_set_focus): Likewise.
2228         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2229         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2230         Likewise.
2231
2232 2019-06-25  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-winsource.h (tui_refill_source_window)
2235         (tui_set_is_exec_point_at): Don't declare.
2236         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2237         (tui_source_window_base::refill): Rename from
2238         tui_refill_source_window.
2239         (tui_source_window_base::do_scroll_horizontal): Update.
2240         (tui_source_window_base::set_is_exec_point_at): Rename from
2241         tui_set_is_exec_point_at.
2242         (tui_update_all_breakpoint_info): Update.
2243         * tui/tui-stack.c (tui_show_frame_info): Update.
2244         * tui/tui-layout.c (show_data): Add cast.
2245         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2246         * tui/tui-data.h (struct tui_source_window_base) <refill,
2247         set_is_exec_point_at>: New methods.
2248         (tui_source_windows, tui_add_to_source_windows): Update types.
2249         (tui_add_to_source_windows): Remove redundant declaration.
2250         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2251         (tui_source_windows): Change return type.
2252         (tui_clear_source_windows_detail): Update.
2253         (tui_add_to_source_windows): Change type of parameter.
2254         (tui_free_all_source_wins_content): Update.
2255
2256 2019-06-25  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-wingeneral.c (tui_win_info::refresh)
2259         (tui_source_window_base::refresh): New methods.
2260         (tui_refresh_all): Call the refresh method.
2261         * tui/tui-data.h (struct tui_win_info)
2262         (struct tui_source_window_base) <refresh>: New method.
2263
2264 2019-06-25  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui.h (tui_is_window_visible): Return bool.
2267         * tui/tui.c (tui_is_window_visible): Return bool.
2268         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2269         (tui_make_visible, tui_make_invisible)
2270         (tui_win_info::make_visible)
2271         (tui_source_window_base::make_visible, make_all_visible)
2272         (tui_make_all_visible, tui_make_all_invisible): Update.
2273         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2274         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2275         bool.
2276         (struct tui_win_info, struct tui_source_window_base)
2277         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2278         * tui/tui-data.c (tui_init_generic_part): Update.
2279
2280 2019-06-25  Tom Tromey  <tom@tromey.com>
2281
2282         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2283         (tui_source_window_base::make_visible): New methods.
2284         (make_all_visible): Make method call.
2285         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2286         (struct tui_source_window_base, struct tui_cmd_window): Override
2287         make_visible.
2288         (tui_win_is_source_type): Don't declare.
2289         * tui/tui-data.c (tui_win_is_source_type): Remove.
2290
2291 2019-06-25  Tom Tromey  <tom@tromey.com>
2292
2293         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2294         NULL check.
2295
2296 2019-06-25  Tom Tromey  <tom@tromey.com>
2297
2298         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2299         Inline constructor.  Add initializers for members.
2300         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2301         constructors; now inline in class.
2302
2303 2019-06-25  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-regs.c (tui_show_registers): Update.
2306         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2307         bool.
2308         * tui/tui-data.c (tui_data_window::clear_detail)
2309         (tui_data_window): Update.
2310
2311 2019-06-25  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-windata.c (tui_display_all_data)
2314         (tui_display_data_from_line, tui_display_data_from)
2315         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2316         Update.
2317         * tui/tui-regs.c (tui_last_regs_line_no)
2318         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2319         (tui_show_registers, tui_show_register_group)
2320         (tui_display_registers_from, tui_display_reg_element_at_line)
2321         (tui_display_registers_from_line, tui_check_register_values)
2322         (tui_reg_next, tui_reg_prev): Update.
2323         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2324         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2325         tui_data_window.
2326         (struct tui_win_info) <detail>: Remove.  Add new fields from
2327         tui_data_info.
2328         (TUI_DATA_WIN): Add cast.
2329         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2330         (~tui_data_window): Simplify.
2331
2332 2019-06-25  Tom Tromey  <tom@tromey.com>
2333
2334         * tui/tui-layout.c (show_source_disasm_command)
2335         (show_source_or_disasm_and_command): Update.
2336         * tui/tui-io.c (update_cmdwin_start_line)
2337         (tui_redisplay_readline): Update.
2338         * tui/tui-data.h (struct tui_command_info): Remove.
2339         (struct tui_win_info) <detail>: Remove command_info member.
2340         (struct tui_data_window) <start_line>: New member, from
2341         tui_command_info.
2342         (TUI_CMD_WIN): Add casts.
2343
2344 2019-06-25  Tom Tromey  <tom@tromey.com>
2345
2346         * tui/tui-winsource.c (tui_update_source_window)
2347         (tui_refill_source_window)
2348         (tui_source_window_base::do_scroll_horizontal)
2349         (tui_update_breakpoint_info, tui_set_exec_info_content)
2350         (tui_show_exec_info_content, tui_erase_exec_info_content)
2351         (tui_clear_exec_info_content): Update.
2352         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2353         Update.
2354         * tui/tui-win.c (make_invisible_and_set_new_height)
2355         (make_visible_with_new_height): Update.
2356         * tui/tui-source.c (tui_set_source_content)
2357         (tui_show_symtab_source): Update.
2358         * tui/tui-layout.c (extract_display_start_addr)
2359         (show_source_disasm_command, show_data)
2360         (make_source_or_disasm_window)
2361         (show_source_or_disasm_and_command): Update.
2362         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2363         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2364         "gdbarch".
2365         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2366         to tui_source_window_base.
2367         (struct tui_win_info) <detail>: Remove source_info member.
2368         (struct tui_source_window_base) <has_locator>: Inline.
2369         Move contents from tui_source_info; rename has_locator member to
2370         m_has_locator.
2371         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2372         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2373         header file.
2374         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2375         Simplify.
2376         (tui_free_all_source_wins_content): Cast to
2377         tui_source_window_base.
2378
2379 2019-06-25  Tom Tromey  <tom@tromey.com>
2380
2381         * tui/tui-win.c (make_invisible_and_set_new_height)
2382         (make_visible_with_new_height): Call has_locator method.
2383         * tui/tui-layout.c (show_source_disasm_command, show_data)
2384         (show_source_or_disasm_and_command): Update for bool change.
2385         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2386         (tui_win_info) <has_locator>: New method.
2387         (struct tui_source_window_base) <has_locator>: New method.
2388         (tui_win_has_locator): Don't declare.
2389         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2390         from tui_win_has_locator.
2391         (tui_source_window_base): Use false, not FALSE.
2392
2393 2019-06-25  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2396         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2397         clear_detail method directly.
2398         (tui_clear_win_detail): Remove.
2399
2400 2019-06-25  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2403         "this", not TUI_DISASM_WIN.
2404
2405 2019-06-25  Tom Tromey  <tom@tromey.com>
2406
2407         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2408         declare.
2409         * tui/tui-winsource.c
2410         (tui_source_window_base::do_scroll_horizontal): Rename from
2411         tui_horizontal_source_scroll.
2412         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2413         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2414         from tui_vertical_data_scroll.
2415         * tui/tui-win.h (tui_scroll): Don't declare.
2416         * tui/tui-win.c (tui_win_info::forward_scroll)
2417         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2418         (tui_win_info::right_scroll): Rename and update.
2419         (tui_scroll_forward_command, tui_scroll_backward_command)
2420         (tui_scroll_left_command, tui_scroll_right_command): Update.
2421         (tui_scroll): Remove.
2422         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2423         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2424         from tui_vertical_source_scroll.
2425         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2426         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2427         from tui_vertical_disassem_scroll.
2428         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2429         do_scroll_horizontal>: New methods.
2430         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2431         Likewise.
2432         (struct tui_source_window_base): Add do_scroll_horizontal.
2433         (struct tui_source_window, struct tui_disasm_window): Add
2434         do_scroll_vertical.
2435         (struct tui_data_window, struct tui_cmd_window): Add
2436         do_scroll_horizontal and do_scroll_vertical.
2437         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2438
2439 2019-06-25  Tom Tromey  <tom@tromey.com>
2440
2441         * tui/tui-data.h (struct tui_source_window_base): New struct.
2442         (struct tui_source_window): Derive from tui_source_window_base.
2443         (struct tui_disasm_window): New struct.
2444         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2445         from tui_source_window::clear_detail.
2446         (tui_source_window_base): Rename from tui_source_window.
2447         (~tui_source_window_base): Rename from ~tui_source_window.
2448         (tui_alloc_win_info): Create a tui_disasm_window.
2449
2450 2019-06-25  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-data.h (struct tui_source_window)
2453         (struct tui_data_window): Declare destructors.
2454         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2455         destructors.
2456         (tui_win_info): Simplify.
2457
2458 2019-06-25  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-winsource.c (tui_display_main)
2461         (tui_update_source_windows_with_addr)
2462         (tui_update_all_breakpoint_info): Update.
2463         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2464         (new_height_ok, parse_scrolling_args): Update.
2465         * tui/tui-stack.c (tui_show_frame_info): Update.
2466         * tui/tui-data.h (struct tui_list): Remove.
2467         (tui_source_windows): Return a reference to a std::vector.
2468         * tui/tui-data.c (source_windows): Now a std::vector.
2469         (tui_source_windows): Change return type.
2470         (tui_clear_source_windows): Rewrite.
2471         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2472         (tui_free_all_source_wins_content): Rewrite.
2473
2474 2019-06-25  Tom Tromey  <tom@tromey.com>
2475
2476         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2477         (struct tui_data_window, struct tui_cmd_window): Declare
2478         clear_detail method.
2479         * tui/tui-data.c (tui_source_window::clear_detail)
2480         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2481         methods.
2482         (tui_clear_win_detail): Simplify.
2483
2484 2019-06-25  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-layout.c (make_source_window, make_disasm_window)
2487         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2488         Return the new window.
2489         (show_source_disasm_command, show_data)
2490         (show_source_or_disasm_and_command): Update.
2491
2492 2019-06-25  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2495         parameter.  Return the new window.
2496         (show_source_disasm_command): Update and remove NULL check.
2497         (show_source_or_disasm_and_command): Update.
2498
2499 2019-06-25  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2502
2503 2019-06-25  Tom Tromey  <tom@tromey.com>
2504
2505         * tui/tui-data.h (struct tui_win_info): Make constructor
2506         protected.  Make destructor virtual.  Add initializers.
2507         (tui_source_window, tui_data_window, tui_cmd_window): New
2508         classes.
2509         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2510         constructor.  Add "type" parameter.
2511         (tui_source_window, tui_data_window, tui_cmd_window): New
2512         constructors.
2513         (tui_alloc_win_info): Instantiate the appropriate subclass.
2514
2515 2019-06-25  Tom Tromey  <tom@tromey.com>
2516
2517         * tui/tui-win.c (tui_resize_all): Use delete.
2518         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2519         destructor.
2520         (tui_free_window): Don't declare.
2521         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2522         Update.
2523
2524 2019-06-25  Tom Tromey  <tom@tromey.com>
2525
2526         * tui/tui-data.h (struct tui_win_info): Add constructor.
2527         * tui/tui-data.c (tui_alloc_win_info): Use new.
2528         (tui_free_window): Use delete.
2529
2530 2019-06-22  Tom Tromey  <tom@tromey.com>
2531
2532         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2533         declare.
2534         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2535
2536 2019-06-22  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2539         declare.
2540         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2541
2542 2019-06-22  Tom de Vries  <tdevries@suse.de>
2543
2544         * dwarf2read.c (create_addrmap_from_aranges)
2545         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2546         instead of '%zu'.
2547
2548 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2549
2550         * dwarf2read.h (dwarf2_section_info_def): Remove.
2551         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2552         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2553         std::vector<dwarf2_section_info>.
2554         (struct dwo_file) <~dwo_file>: Remove.
2555         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2556         types field.
2557         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2558         (dwarf2_read_debug_names): Likewise.
2559         (create_debug_types_hash_table): Change parameter type to
2560         array_view, adjust code accordingly.
2561         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2562         (partial_die_info::fixup): Likewise.
2563         (determine_prefix): Likewise.
2564         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2565
2566 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2567
2568         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2569         gdb_bfd_ref_ptr.
2570         <~dwo_file>: Remove call to gdb_bfd_unref.
2571         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2572         gdb_bfd_ref_ptr::get.
2573
2574 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2575
2576         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2577         type to htab_up.
2578         * dwarf2read.c (struct dwo_file): Initialize fields.
2579         <~dwo_file>: New.
2580         (free_dwo_file): Remove, move content to ~dwo_file.
2581         (struct dwo_file_deleter): Remove.
2582         (dwo_file_up>: Remove custom deleter.
2583         (free_dwo_files): Remove.
2584         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2585         dwo_files.
2586         (process_skeletonless_type_units): Call unique_ptr::get.
2587         (allocate_dwo_file_hash_table): Add deleter to created hash
2588         table.  Change return type to htab_up.
2589         (lookup_dwo_file_slot): Don't memset dwo_file, call
2590         unique_ptr::get.
2591         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2592         (create_dwo_unit_in_dwp_v2): Likewise.
2593         (open_and_init_dwo_file): Likewise.
2594         (free_dwo_file_from_slot): Remove.
2595
2596 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2597
2598         * dwarf2read.h (struct dwarf2_section_info) <readin,
2599         is_virtual>: Change type to bool.
2600         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2601         true instead of 1.
2602
2603 2019-06-19  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-data.h (tui_init_content_element): Don't declare.
2606
2607 2019-06-19  Tom Tromey  <tom@tromey.com>
2608
2609         * tui/tui-data.h (tui_init_win_info): Don't declare.
2610
2611 2019-06-19  Tom de Vries  <tdevries@suse.de>
2612
2613         * dwarf2read.h (abstract_to_concrete): Change type to
2614         std::unordered_map<sect_offset, std::vector<sect_offset>,
2615         gdb::hash_enum<sect_offset>>.
2616
2617 2019-06-19  Tom Tromey  <tromey@adacore.com>
2618
2619         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2620         EVAL_AVOID_SIDE_EFFECTS specially.
2621
2622 2019-06-19  Tom Tromey  <tromey@adacore.com>
2623
2624         * source-cache.c (highlighter): New global.
2625         (source_cache::get_source_lines): Create a highlighter on demand.
2626
2627 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2628
2629         * defs.h (deprecated_interactive_hook): Delete declaration.
2630         * interps.c (clear_interpreter_hooks): Remove use of
2631         deprecated_interactive_hook.
2632         * top.c (deprecated_interactive_hook): Delete definition.
2633         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2634
2635 2019-06-18  Tom de Vries  <tdevries@suse.de>
2636
2637         PR gdb/24515
2638         * dwarf2read.h (abstract_to_concrete): Change type from
2639         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2640         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2641         * dwarf2read.c (read_variable): Update.
2642         (dwarf2_fetch_die_loc_sect_off): Update.
2643
2644 2019-06-17  Tom de Vries  <tdevries@suse.de>
2645
2646         PR gdb/24617
2647         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2648         accessing parent[parent_len - 1].
2649
2650 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2651
2652         PR gdb/24364
2653         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2654         call dtrace_process_dof with NULL dof.
2655
2656 2019-06-16  Tom de Vries  <tdevries@suse.de>
2657
2658         PR gdb/24445
2659         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2660
2661 2019-06-16  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2664         (make_all_visible): Use address of member.
2665
2666 2019-06-16  Tom Tromey  <tom@tromey.com>
2667
2668         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2669         (tui_free_window, free_content, free_content_elements): Remove
2670         unnecessary cast.
2671         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2672         cast.
2673         * tui/tui-regs.c (tui_show_register_group)
2674         (tui_display_registers_from, tui_display_reg_element_at_line):
2675         Remove unnecessary cast.
2676
2677 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2678
2679         * linux-nat.c (normal_mask): Delete.
2680         (_initialize_linux_nat): Don't initialise normal_mask.
2681
2682 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2683
2684         PR gdb/24445
2685         * dwarf-index-write.h (write_psymtabs_to_index): Add
2686         dwz_basename parameter.
2687         * dwarf-index-write.c (write_gdbindex): Move file writing to
2688         write_gdbindex_1.  Change return type void.
2689         (assert_file_size): Move up, remove filename parameter.
2690         (write_gdbindex_1): New function.
2691         (write_debug_names): Change return type to void, call
2692         assert_file_size.
2693         (struct index_wip_file): New struct.
2694         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2695         file logic to index_wip_file.  Write index for dwz file if
2696         needed.
2697         (save_gdb_index_command): Pass basename of dwz file, if present.
2698         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2699         build-id of dwz file, if present.
2700         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2701         (dwarf2_get_dwz_file): Likewise.
2702         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2703         (dwarf2_get_dwz_file): Likewise.
2704
2705 2019-06-16  Tom Tromey  <tom@tromey.com>
2706
2707         * coffread.c (process_coff_symbol): Use xstrdup.
2708         * value.c (create_internalvar): Use xstrdup.
2709
2710 2019-06-16  Tom Tromey  <tom@tromey.com>
2711
2712         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2713         * breakpoint.c (stopin_command, stopat_command)
2714         (until_break_command, decode_location_default): Remove unnecessary
2715         cast.
2716         * utils.c (subset_compare): Remove unnecessary cast.
2717         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2718         cast.
2719         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2720         cast.
2721         * infcmd.c (path_command): Remove unnecessary cast.
2722         * coffread.c (decode_type): Remove unnecessary cast.
2723         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2724         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2725         * tui/tui-stack.c (tui_show_locator_content)
2726         (tui_show_frame_info): Remove unnecessary cast.
2727         * tui/tui-win.c (tui_scroll_forward_command)
2728         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2729         (parse_scrolling_args): Remove unnecessary cast.
2730         * tui/tui-data.c (init_win_info, tui_del_window)
2731         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2732         (free_content_elements): Remove unnecessary cast.
2733         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2734         unnecessary cast.
2735         * tui/tui-source.c (tui_set_source_content)
2736         (tui_vertical_source_scroll): Remove unnecessary cast.
2737         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2738         cast.
2739         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2740         * tui/tui-regs.c (tui_display_registers_from)
2741         (tui_display_register): Remove unnecessary cast.
2742         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2743         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2744         (make_visible): Remove unnecessary cast.
2745         * tui/tui-winsource.c (tui_erase_source_content)
2746         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2747         unnecessary cast.
2748         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2749         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2750         * stabsread.c (read_type, read_array_type, read_range_type):
2751         Remove unnecessary cast.
2752         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2753         (parse_symbol, parse_type, upgrade_type, parse_external)
2754         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2755         unnecessary cast.
2756         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2757
2758 2019-06-16  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-data.c (tui_alloc_generic_win_info)
2761         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2762         checks.
2763
2764 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2765             Andrew Burgess  <andrew.burgess@embecosm.com>
2766
2767         * f-typeprint.c (f_print_type): Don't return early for not
2768         associated or not allocated types.
2769         (f_type_print_varspec_suffix): Add print_rank parameter and print
2770         ranks of array types in case they dangling.
2771         (f_type_print_base): Add print_rank parameter.
2772
2773 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2774
2775         * NEWS: Mention new MI commands.
2776         * break-catch-throw.c (enum exception_event_kind): Move to
2777         breakpoint.h.
2778         (print_mention_exception_catchpoint): Output text as a single
2779         message.
2780         (catch_exception_command_1): Rename to...
2781         (catch_exception_event): ...this, make non-static, update header
2782         command, and change some parameter types.
2783         (catch_catch_command): Update for changes to
2784         catch_exception_command_1.
2785         (catch_throw_command): Likewise.
2786         (catch_rethrow_command): Likewise.
2787         * breakpoint.c (enum exception_event_kind): Delete.
2788         * breakpoint.h (enum exception_event_kind): Moved here from
2789         break-catch-throw.c.
2790         (catch_exception_event): Declare.
2791         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2792         (mi_cmd_catch_throw): New function.
2793         (mi_cmd_catch_rethrow): New function.
2794         (mi_cmd_catch_catch): New function.
2795         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2796         'catch-catch' entries.
2797         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2798         (mi_cmd_catch_rethrow): Declare.
2799         (mi_cmd_catch_catch): Declare.
2800
2801 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2802
2803         * annotate.c (annotate_source_line): Change return type to void,
2804         update implementation to match.
2805         * annotate.h (annotate_source_line): Change return type to void,
2806         update header comment.
2807         * stack.c (print_frame_info): Don't change what frame information
2808         is printed based on whether annotations are on or not.
2809
2810 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2811
2812         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2813         (annotate_source): Make static.
2814         (annotate_source_line): Moved from source.c and renamed from
2815         identify_source_line.  Update the return type.
2816         * annotate.h (annotate_source): Delete declaration.
2817         (annotate_source_line): Declaration moved from source.h, and
2818         renamed from identify_source_line.  Return type updated.
2819         * source.c (identify_source_line): Moved to annotate.c and renamed
2820         to annotate_source_line.
2821         (info_line_command): Remove check of annotation_level.
2822         * source.h (identify_source_line): Move declaration to annotate.h
2823         and rename to annotate_source_line.
2824         * stack.c: Add 'annotate.h' include.
2825         (print_frame_info): Remove check of annotation_level before
2826         calling annotate_source_line.
2827
2828 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2829
2830         * source-cache.c (source_cache::get_plain_source_lines): Use
2831         open_source_file_with_line_charpos instead of just
2832         open_source_file, remove call to find_source_lines.
2833         (source_cache::get_source_lines): Likewise.
2834         * source.c (find_source_lines): Make static.
2835         (get_filename_and_charpos): Renamed into...
2836         (open_source_file_with_line_charpos): ..this along with changes to
2837         return a scoped_fd, and some other minor clean ups.
2838         (identify_source_line): Use open_source_file_with_line_charpos.
2839         (search_command_helper): Use open_source_file_with_line_charpos
2840         instead of just open_source_file, remove call to
2841         find_source_lines.
2842         * source.h (open_source_file_with_line_charpos): Declare new
2843         function.
2844         (find_source_lines): Delete declaration.
2845
2846 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2847
2848         * source.c (get_filename_and_charpos): Remove fullname
2849         parameter.
2850         (identify_source_line): Update call to get_filename_and_charpos.
2851
2852 2019-06-14  Tom Tromey  <tromey@adacore.com>
2853
2854         PR gdb/24502:
2855         * ui-style.h (skip_ansi_escape): Update comment.
2856         * ui-file.h (class no_terminal_escape_file): New class.
2857         * ui-file.c (no_terminal_escape_file::write)
2858         (no_terminal_escape_file::puts): New methods.
2859         * cli/cli-logging.c (handle_redirections): Use
2860         no_terminal_escape_file.
2861
2862 2019-06-14  Tom Tromey  <tromey@adacore.com>
2863
2864         * NEWS: Move convenience variable news above Python news.
2865
2866 2019-06-14  Tom Tromey  <tom@tromey.com>
2867
2868         * gnulib: Move directory to top-level.
2869         * configure.ac: Don't configure gnulib.
2870         * configure: Rebuild.
2871         * common/common-defs.h: Use new path to gnulib.
2872         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2873         (GNULIB_H): Remove.
2874         (INCGNU): Look in new gnulib location.
2875         (HFILES_NO_SRCDIR): Remove gnulib files.
2876         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2877         (generated_files): Remove GNULIB_H.
2878         ($(LIBGNU), all-lib): Remove targets.
2879         (distclean): Don't mention GNULIB_BUILDDIR.
2880         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2881
2882 2019-06-14  Tom Tromey  <tromey@adacore.com>
2883
2884         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2885         Warn if symbol file does not provide any symbols.
2886
2887 2019-06-14  Tom Tromey  <tromey@adacore.com>
2888
2889         * source.c (find_and_open_source): Respect basenames_may_differ.
2890
2891 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2892
2893         * annotate.c (annotate_breakpoints_invalid): Make use of
2894         scoped_restore_terminal_state.
2895         (annotate_frames_invalid): Likewise.
2896
2897 2019-06-14  Tom Tromey  <tromey@adacore.com>
2898
2899         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2900         allow assignment to an internalvar.
2901
2902 2019-06-14  Tom Tromey  <tromey@adacore.com>
2903
2904         * ada-lex.l: Allow "_" in attribute names.
2905
2906 2019-06-14  Tom Tromey  <tromey@adacore.com>
2907
2908         PR gdb/24653:
2909         * regcache.c (registers_changed): Don't call alloca.
2910         * top.c (execute_command): Don't call alloca.
2911
2912 2019-06-13  Pedro Alves  <palves@redhat.com>
2913
2914         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2915         'expression'.  When parsing an expression, error out if there's
2916         junk after "unlimited".
2917         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2918         (do_set_command): Adjust calls to is_unlimited_literal.
2919
2920 2019-06-13  Pedro Alves  <palves@redhat.com>
2921
2922         * compile/compile.c (make_compile_options_def_group): Add braces
2923         around array_view initializer.
2924         * thread.c (make_thread_apply_all_options_def_group)
2925         (make_thread_apply_all_options_def_group): Likewise.
2926
2927 2019-06-13  Pedro Alves  <palves@redhat.com>
2928
2929         * NEWS (New commands): Mention "maint test-options
2930         require-delimiter", "maint test-options unknown-is-error", "maint
2931         test-options unknown-is-operand" and "maint show
2932         test-options-completion-result".
2933         (New command options, command completion): New section.
2934         (Completion improvements): New section.
2935         Mention that you can abbreviate "unlimited".
2936
2937 2019-06-13  Pedro Alves  <palves@redhat.com>
2938
2939         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2940         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2941         * unittests/cli-utils-selftests.c (test_parse_flags)
2942         (test_parse_flags_qcs): Delete.
2943         (test_cli_utils): Don't call deleted functions.
2944
2945 2019-06-13  Pedro Alves  <palves@redhat.com>
2946
2947         * thread.c: Include "cli/cli-option.h".
2948         (tp_array_compar_ascending): Global.
2949         (tp_array_compar): Delete function.
2950         (tp_array_compar_ascending, tp_array_compar_descending): New
2951         functions.
2952         (ascending_option_def, qcs_flag_option_def)
2953         (thr_qcs_flags_option_defs)
2954         (make_thread_apply_all_options_def_group)
2955         (make_thread_apply_options_def_group): New.
2956         (thread_apply_all_command): Use gdb::option::process_options.
2957         (thread_apply_command_completer)
2958         (thread_apply_all_command_completer): New.
2959         (thread_apply_command): Use gdb::option::process_options.
2960         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2961         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2962         to generate help text of "thread apply".  Adjust "taas"'s help.
2963         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2964         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2965
2966 2019-06-13  Pedro Alves  <palves@redhat.com>
2967
2968         * thread.c (thread_apply_command): Check for invalid TID with
2969         isdigit instead of !isalpha.
2970
2971 2019-06-13  Pedro Alves  <palves@redhat.com>
2972
2973         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2974         (validate_flags_qcs): New.
2975         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2976         (validate_flags_qcs): Declare.
2977         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2978         (make_frame_apply_options_def_group): New.
2979         (frame_apply_command_count): Process options with
2980         gdb::option::process_options.
2981         (frame_apply_completer): New.
2982         (frame_apply_level_completer, frame_apply_all_completer)
2983         (frame_apply_completer): New.
2984         (_initialize_stack): Update help of "frame apply", "frame apply
2985         level", "frame apply all" and "faas" to mention supported options
2986         and install command completers.
2987         * stack.h (frame_apply_all_completer): Declare.
2988         * thread.c: Include "stack.h".
2989         (tfaas_command): Add "--".
2990         (_initialize_thread): Update help "tfaas" to mention supported
2991         options and install command completer.
2992
2993 2019-06-13  Pedro Alves  <palves@redhat.com>
2994
2995         * completer.c (complete_nested_command_line): New.
2996         (gdb_completion_word_break_characters_throw): Add assertion.
2997         * completer.h (complete_nested_command_line): Declare.
2998
2999 2019-06-13  Pedro Alves  <palves@redhat.com>
3000
3001         * stack.c (parse_backtrace_qualifiers): New.
3002         (backtrace_command): Use it.
3003         (backtrace_command_completer): Complete on qualifiers.
3004
3005 2019-06-13  Pedro Alves  <palves@redhat.com>
3006
3007         * frame.c: Include "cli/cli-option.h.
3008         (user_set_backtrace_options): New.
3009         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3010         Delete.
3011         (get_prev_frame): Adjust.
3012         (boolean_option_def, uinteger_option_def)
3013         (set_backtrace_option_defs): New.
3014         (_initialize_frame): Adjust and use
3015         gdb::option::add_setshow_cmds_for_options to install "set
3016         backtrace past-main" and "set backtrace past-entry".
3017         * frame.h: Include "cli/cli-option.h".
3018         (struct frame_print_options): Forward declare.
3019         (print_frame_arguments_all, print_frame_arguments_scalars)
3020         (print_frame_arguments_none): Declare.
3021         (print_entry_values): Delete declaration.
3022         (struct frame_print_options, user_frame_print_options): New.
3023         (struct set_backtrace_options): New.
3024         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3025         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3026         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3027         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3028         (list_args_or_locals): Add frame_print_options parameter.
3029         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3030         * python/py-framefilter.c (enumerate_args): Pass down
3031         USER_FRAME_PRINT_OPTIONS.
3032         * stack.c: Include "cli/cli-option.h".
3033         (print_frame_arguments_all, print_frame_arguments_scalars)
3034         (print_frame_arguments_none): Declare.
3035         (print_raw_frame_arguments, print_entry_values): Delete.
3036         (user_frame_print_options): New.
3037         (boolean_option_def, enum_option_def, frame_print_option_defs):
3038         New.
3039         (struct backtrace_cmd_options): New.
3040         (bt_flag_option_def): New.
3041         (backtrace_command_option_defs): New.
3042         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3043         (print_frame_arg, read_frame_arg, print_frame_args)
3044         (print_frame_info, print_frame): Add frame_print_options parameter
3045         and use it.
3046         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3047         (backtrace_command_1): Add frame_print_options and
3048         backtrace_cmd_options parameters and use them.
3049         (make_backtrace_options_def_group): New.
3050         (backtrace_command): Process command options with
3051         gdb::option::process_options.
3052         (backtrace_command_completer): New.
3053         (_initialize_stack): Extend "backtrace"'s help to mention
3054         supported options.  Install completer for "backtrace".
3055         Install some settings commands with add_setshow_cmds_for_options.
3056
3057 2019-06-13  Pedro Alves  <palves@redhat.com>
3058
3059         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3060         and that "set/show print raw frame-arguments" are now deprecated.
3061
3062         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3063         command.
3064         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3065         * stack.c (_initialize_stack): Install "set/show print
3066         raw-frame-arguments", and deprecate "set/show print raw
3067         frame-arguments".
3068         * valprint.c (_initialize_valprint): Deprecate "set/show print
3069         raw".
3070
3071 2019-06-13  Pedro Alves  <palves@redhat.com>
3072
3073         * compile/compile.c (struct compile_options): New.
3074         (compile_flag_option_def, compile_command_option_defs)
3075         (make_compile_options_def_group): New.
3076         (compile_file_command): Handle options with
3077         gdb::option::process_options.
3078         (compile_file_command_completer): New function.
3079         (compile_code_command): Handle options with
3080         gdb::option::process_options.
3081         (compile_code_command_completer): New function.
3082         (_initialize_compiler): Install completers for "compile code" and
3083         "compile file".  Mention available options in "compile code" and
3084         "compile code"'s help.
3085         * completer.c (advance_to_completion_word): New, factored out from
3086         ...
3087         (advance_to_expression_complete_word_point): ... this.
3088         (advance_to_filename_complete_word_point): New.
3089         * completer.h (advance_to_filename_complete_word_point): New
3090         declaration.
3091
3092 2019-06-13  Pedro Alves  <palves@redhat.com>
3093
3094         * compile/compile.c: Include "cli/cli-option.h".
3095         (compile_print_value): Scope data pointer is now a
3096         value_print_options pointer; adjust.
3097         (compile_print_command): Process options.  Scope data pointer is
3098         now a value_print_options pointer; adjust.
3099         (_initialize_compile): Update "compile print"'s help to include
3100         supported options.  Install a completer for "compile print".
3101         * cp-valprint.c (show_vtblprint, show_objectprint)
3102         (show_static_field_print): Delete.
3103         (_initialize_cp_valprint): Don't install "set print
3104         static-members", "set print vtbl", "set print object" here.
3105         * printcmd.c: Include "cli/cli-option.h" and
3106         "common/gdb_optional.h".
3107         (print_command_parse_format): Rework to fill in a
3108         value_print_options instead of a format_data.
3109         (print_value): Change parameter type from format_data pointer to
3110         value_print_options reference.  Adjust.
3111         (print_command_1): Process options.  Adjust to pass down a
3112         value_print_options.
3113         (print_command_completer): New.
3114         (_initialize_printcmd): Install print_command_completer as
3115         handle_brkchars completer for the "print" command.  Update
3116         "print"'s help to include supported options.
3117         * valprint.c: Include "cli/cli-option.h".
3118         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3119         here from cp-valprint.c.
3120         (boolean_option_def, uinteger_option_def)
3121         (value_print_option_defs, make_value_print_options_def_group):
3122         New.  Use gdb::option::add_setshow_cmds_for_options to install
3123         "set print elements", "set print null-stop", "set print repeats",
3124         "set print pretty", "set print union", "set print array", "set
3125         print address", "set print symbol", "set print array-indexes".
3126         * valprint.h: Include <string> and "cli/cli-option.h".
3127         (make_value_print_options_def_group): Declare.
3128         (print_value): Change parameter type from format_data pointer to
3129         value_print_options reference.
3130         (print_command_completer): Declare.
3131
3132 2019-06-13  Pedro Alves  <palves@redhat.com>
3133
3134         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3135         (COMMON_SFILES): Add maint-test-settings.c.
3136         * cli/cli-decode.c (boolean_enums): New global, factored out from
3137         ...
3138         (add_setshow_boolean_cmd): ... here.
3139         * cli/cli-decode.h (boolean_enums): Declare.
3140         * cli/cli-option.c: New file.
3141         * cli/cli-option.h: New file.
3142         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3143         factored out from ...
3144         (parse_cli_boolean_value(const char *)): ... this.
3145         (is_unlimited_literal): Change parameter type to pointer to
3146         pointer.  Adjust and advance ARG pointer.
3147         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3148         (parse_cli_var_enum): New, factored out from ...
3149         (do_set_command): ... this.  Adjust.
3150         * cli/cli-setshow.h (parse_cli_boolean_value)
3151         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3152         (parse_cli_var_enum): Declare.
3153         * cli/cli-utils.c: Include "cli/cli-option.h".
3154         (get_ulongest): New.
3155         * cli/cli-utils.h (get_ulongest): Declare.
3156         (check_for_argument): New overloads.
3157         * maint-test-options.c: New file.
3158
3159 2019-06-13  Pedro Alves  <palves@redhat.com>
3160
3161         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3162         parse a range if "-" is at the end of the string.
3163
3164 2019-06-13  Pedro Alves  <palves@redhat.com>
3165
3166         * cli/cli-setshow.c (parse_auto_binary_operation)
3167         (parse_cli_boolean_value): Don't allow "o".
3168
3169 2019-06-13  Pedro Alves  <palves@redhat.com>
3170
3171         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3172         * NEWS: Mention maint test-settings KIND.
3173         * maint-test-settings.c: New file.
3174
3175 2019-06-13  Pedro Alves  <palves@redhat.com>
3176
3177         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3178         completer.
3179         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3180         "set" completers.
3181
3182 2019-06-13  Pedro Alves  <palves@redhat.com>
3183
3184         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3185         after item.
3186
3187 2019-06-13  Pedro Alves  <palves@redhat.com>
3188
3189         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3190
3191 2019-06-13  Pedro Alves <palves@redhat.com>
3192
3193         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3194         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3195         call.
3196         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3197         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3198         calls.
3199         (check_for_argument): Skip spaces after argument.
3200
3201 2019-06-13  Pedro Alves  <palves@redhat.com>
3202
3203         * thread.c (thread_apply_command): Adjust TID parsing.
3204         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3205         detected before end of string.
3206         (tid_is_in_list): Error out if LIST is invalid.
3207
3208 2019-06-13  Pedro Alves  <palves@redhat.com>
3209
3210         * completer.c (complete_line_internal_1): Rewind completion word
3211         point.
3212         (completion_tracker::advance_custom_word_point_by): Change
3213         parameter type to int.
3214         * completer.h (completion_tracker::advance_custom_word_point_by):
3215         Likewise.
3216
3217 2019-06-13  Pedro Alves  <palves@redhat.com>
3218
3219         * completer.c (advance_to_completion_word): Handle delimiters.
3220
3221 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3222
3223         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3224
3225 2019-06-11  Tom Tromey  <tom@tromey.com>
3226
3227         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3228         (xmalloc_failed): Move to alloc.c.
3229         * alloc.c: New file.
3230         * Makefile.in (COMMON_SFILES): Add alloc.c.
3231
3232 2019-06-11  Tom Tromey  <tom@tromey.com>
3233
3234         * nat/linux-waitpid.c: Don't include server.h.
3235         (linux_debug): Remove.
3236         (my_waitpid): Update.
3237
3238 2019-06-11  Tom Tromey  <tromey@adacore.com>
3239
3240         * infcall.c (_initialize_infcall): Remove trailing newline from
3241         help.
3242         * user-regs.c (_initialize_user_regs): Remove trailing newline
3243         from help.
3244         * typeprint.c (_initialize_typeprint): Remove trailing newline
3245         from help.
3246         * reverse.c (_initialize_reverse): Remove trailing newlines from
3247         help.
3248         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3249         from help.
3250         * language.c (add_set_language_command): Remove trailing newline
3251         from help.
3252         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3253         help.
3254         * disasm.c (_initialize_disasm): Remove trailing newline from
3255         help.
3256         * top.c (init_main): Remove trailing newline from help.
3257         * interps.c (_initialize_interpreter): Remove trailing newline
3258         from help.
3259         * btrace.c (_initialize_btrace): Remove trailing newlines from
3260         help.
3261         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3262         from help.
3263         * python/python.c (_initialize_python): Remove trailing newline
3264         from help.
3265         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3266         help.
3267         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3268         from help.  Reformat some text.
3269         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3270         from help.
3271         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3272         newline from help.
3273
3274 2019-06-11  Tom Tromey  <tromey@adacore.com>
3275
3276         * darwin-nat.c (darwin_decode_exception_message)
3277         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3278
3279 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3280
3281         * valops.c (value_slice): Check for not allocated or not
3282         associated values.
3283
3284 2019-06-10  Tom de Vries  <tdevries@suse.de>
3285
3286         PR gdb/24618
3287         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3288         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3289         invalid.
3290
3291 2019-06-10  Tom de Vries  <tdevries@suse.de>
3292
3293         PR gdb/24611
3294         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3295         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3296
3297 2019-06-10  Tom de Vries  <tdevries@suse.de>
3298
3299         PR symtab/24545
3300         * symtab.c (struct demangled_name_entry): Add language field.
3301         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3302         static minimal symbol".  Set and use language field.
3303
3304 2019-06-10  Tom Tromey  <tromey@adacore.com>
3305
3306         * ada-lang.c (_initialize_ada_language): Update help text.
3307
3308 2019-06-10  Tom Tromey  <tromey@adacore.com>
3309
3310         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3311         with a newline.
3312         * guile/guile.c (handle_boot_error): Don't end warning with a
3313         newline.
3314         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3315         warning with a newline.
3316         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3317         newline.
3318         (s12z_frame_cache): Likewise.
3319         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3320         a newline.
3321         * solib-svr4.c (disable_probes_interface): Don't end warning with
3322         a newline.
3323         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3324         newline.
3325         * python/python.c (do_finish_initialization): Don't end warning
3326         with a newline.
3327
3328 2019-06-10  Tom Tromey  <tom@tromey.com>
3329
3330         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3331         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3332         gdbpy_enter.
3333
3334 2019-06-10  Tom Tromey  <tromey@adacore.com>
3335
3336         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3337         data.
3338         (elf_new_init): Don't call stabsread_new_init.
3339         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3340         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3341         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3342
3343 2019-06-10  Tom de Vries  <tdevries@suse.de>
3344
3345         PR symtab/16264
3346         PR symtab/24517
3347         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3348
3349 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3350
3351         * source.c (find_and_open_source): Also rewrite relative file
3352         names.
3353
3354 2019-04-26  Amos Bird  <amosbird@gmail.com>
3355
3356         * annotate.c (annotate_thread_exited): Add "thread-exited"
3357         annotation.
3358
3359 2019-06-06  Tom Tromey  <tromey@adacore.com>
3360
3361         * maint.h (class scoped_command_stats): Use
3362         DISABLE_COPY_AND_ASSIGN.
3363         <print_time>: New method.
3364         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3365         print_time.
3366         (scoped_command_stats::print_time): New method.
3367
3368 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3369
3370         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3371         instructions of lengths 6 or 8 bytes.
3372
3373 2019-06-04  Pedro Alves  <palves@redhat.com>
3374
3375         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3376
3377         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3378         * breakpoint.c (condition_completer): Likewise.
3379         * cli/cli-dump.c (scan_expression): Likewise.
3380         * common/filestuff.c (mkdir_recursive): Likewise.
3381         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3382         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3383         (gdb_abspath): Likewise.
3384         * compile/compile-cplus-types.c
3385         (compile_cplus_instance::decl_name): Likewise.
3386         * completer.c (complete_explicit_location):
3387         (signal_completer, reg_or_group_completer_1): Likewise.
3388         * cp-support.c (cp_remove_params_if_any): Likewise.
3389         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3390         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3391         * infcmd.c (strip_bg_char): Likewise.
3392         * linespec.c (copy_token_string): Likewise.
3393         * mi/mi-main.c (output_cores): Likewise.
3394         * psymtab.c (psymtab_search_name):
3395         * symfile.c (test_set_ext_lang_command): Likewise.
3396         * target.c (target_fileio_read_stralloc): Likewise.
3397         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3398         * value.c (complete_internalvar): Likewise.
3399
3400 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3401
3402         Add objfile property to gdb.Type.
3403         * NEWS: Mention Python API addition.
3404         * python/py-type.c (typy_get_objfile): New method.
3405
3406 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3407
3408         * NEWS: Mention the new set|show style [title|highlight].
3409         Mention changes to "show style", "help" and "apropos".
3410
3411 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3412
3413         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3414         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3415         instead of print_help_for_command.
3416         (print_doc_of_command): New function.
3417         (help_list): Add 'apropos -v word' suggestion.
3418         (print_help_for_command): Style the command name using title style.
3419         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3420         (_initialize_cli_cmds): Describe -v in apropos_command help.
3421
3422 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3423
3424         * cli/cli-style.h (cli_style_option): Add name in constructor,
3425         add m_name class member, add constructor with intensity,
3426         add name class function.
3427         (cli_style_option::add_setshow_commands): Remove name argument.
3428         (highlight_style, title_style): New styles.
3429         * cli/cli-style.c (do_show): New function that shows a style
3430         characteristic styling the style name with itself.
3431         (set_style_name): New function.
3432         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3433         Update all callers according to the changes in cli/cli-style.h.
3434         * utils.h (fputs_highlighted): New function.
3435         * utils.c (fputs_highlighted): Likewise.
3436
3437 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3438
3439         * NEWS: Mention new pipe command and new convenience variables.
3440
3441 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3442
3443         * cli/cli-cmds.c (pipe_command): New function.
3444         (_initialize_cli_cmds): Call add_com for pipe_command.
3445         Define | as an alias for pipe.
3446         (exit_status_set_internal_vars): New function.
3447         (shell_escape): Call exit_status_set_internal_vars.
3448         cli/cli-decode.c (find_command_name_length): Recognize | as
3449         a single character command.
3450
3451 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3452
3453         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3454         top.c (execute_command_to_ui_file): New function, mostly a copy
3455         of execute_command_to_string.
3456         (execute_command_to_string): Implement by calling
3457         execute_command_to_ui_file.
3458
3459 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3460
3461         * top.h (saved_command_line): Remove declaration.
3462         * top.c (previous_saved_command_line, previous_repeat_arguments):
3463         New variables.
3464         (saved_command_line): Make static, define together with other
3465         'repeat variables'.
3466         (dont_repeat): Clear repeat_arguments.
3467         (repeat_previous, get_saved_command_line, save_command_line):
3468         New functions.
3469         (gdb_init): Initialize saved_command_line
3470         and previous_saved_command_line.
3471         * main.c (captured_main_1): Remove saved_command_line initialization.
3472         * event-top.c (handle_line_of_input): Update to use
3473         the new 'repeat' related functions instead of direct access to
3474         saved_command_line.
3475         * command.h (repeat_previous, get_saved_command_line,
3476         save_command_line): New declarations.
3477         (dont_repeat): Add comment.
3478
3479 2019-05-30  Tom Tromey  <tromey@adacore.com>
3480
3481         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3482         Fix comment.
3483         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3484
3485 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3486
3487         PR cli/24587
3488         * completer.c (complete): Initialize variable word.
3489
3490 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3491
3492         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3493         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3494         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3495         'body' is NULL to the outter 'if', protecting the '!is_define'
3496         situation as well.
3497
3498 2019-05-29  Tom Tromey  <tromey@adacore.com>
3499
3500         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3501         (dwarf_unknown): New function.
3502         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3503         (dwarf_type_encoding_name): Use dwarf_unknown.
3504
3505 2019-05-29  Tom Tromey  <tromey@adacore.com>
3506
3507         PR c++/20020:
3508         * cp-valprint.c (cp_print_value_fields): Call
3509         cp_print_static_field inside "try".
3510
3511 2019-05-29  Tom Tromey  <tromey@adacore.com>
3512
3513         * inflow.c (struct terminal_info): Add default operator=.
3514         * configure: Rebuild.
3515         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3516         -Wdeprecated-copy-dtor, -Wredundant-move.
3517
3518 2019-05-29  Tom Tromey  <tromey@adacore.com>
3519
3520         * NEWS: Add entry.
3521         * infcmd.c (print_return_value_1): Handle finish_print
3522         option.
3523         (show_print_finish): New function.
3524         (_initialize_infcmd): Add "set/show print finish" commands.
3525         * valprint.c (user_print_options): Initialize new member.
3526         * valprint.h (struct value_print_options) <finish_print>: New
3527         member.
3528
3529 2019-05-28  Tom Tromey  <tromey@adacore.com>
3530
3531         * ada-lang.c (ada_remove_Xbn_suffix)
3532         (find_old_style_renaming_symbol)
3533         (parse_old_style_renaming): Remove.
3534         (ada_find_renaming_symbol): Don't call
3535         find_old_style_renaming_symbol.
3536         (ada_is_renaming_symbol): Rename from
3537         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3538         bool.  Now static.
3539         (ada_read_var_value): Update and simplify.
3540         * ada-exp.y (write_var_or_type): Remove old code.
3541
3542 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3543
3544         * event-top.c: Remove include comment.
3545         * inflow.c (class scoped_ignore_sigttou): Move from here...
3546         * inflow.h (class scoped_ignore_sigttou): ...to here.
3547         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3548         * top.c:  Remove include comment.
3549
3550 2019-05-27  Tom Tromey  <tom@tromey.com>
3551
3552         * NEWS: Fix typo.
3553
3554 2019-05-22  Tom Tromey  <tromey@adacore.com>
3555
3556         * target.c (target_follow_exec): Constify parameter.
3557         * target-delegates.c: Rebuild.
3558         * remote.c (remote_target::follow_exec): Constify parameter.
3559         * infrun.c (follow_exec): Constify parameter.
3560         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3561         (target_follow_exec): Likewise.
3562
3563 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3564
3565         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3566         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3567
3568 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3569
3570         * NEWS: Add debugredirect and testsuite sections.
3571
3572 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3573
3574         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3575         target descriptions using exclusively floating point register name
3576         aliases.
3577
3578 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3579
3580         PR gdb/18644:
3581         * f-lang.c (build_fortran_types): Handle the case where
3582         gdbarch_floatformat_for_type returns a nullptr.
3583
3584 2019-05-21  Tom de Vries  <tdevries@suse.de>
3585
3586         PR cli/24587
3587         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3588
3589 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3590
3591         PR gdb/18644:
3592         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3593         16-byte floats.
3594         * i386-tdep.c (i386_floatformat_for_type): Use
3595         floatformats_ia64_quad for the 16-byte floating point component
3596         within a fortran 32-byte complex number.
3597
3598 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3599
3600         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3601         delete default constructor.
3602         (find_partial_die): Update to return const struct.
3603         (partial_die_parent_scope): Move variable declaration into scope
3604         of its use and change its type to auto.
3605         (guess_partial_die_structure_name): Likewise.
3606         (partial_die_info::fixup): Likewise.
3607
3608 2019-05-17  Tom Tromey  <tromey@adacore.com>
3609
3610         * source.c (find_and_open_source): Remove cast.
3611
3612 2019-05-17  Tom Tromey  <tromey@adacore.com>
3613
3614         * annotate.c (annotate_source): Make "filename" const.
3615         * annotate.h (annotate_source): Use const.
3616
3617 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3618
3619         * disasm.c (set_disassembler_options): Send errors to stderr.
3620
3621 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3622
3623         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3624         (cli_interp_base::set_logging): Check debug_redirect.
3625         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3626         * cli/cli-logging.c (debug_redirect): Add static variable.
3627         (pop_output_files): Add default param.
3628         (handle_redirections): Print debug setting.
3629         (show_logging_command): Likewise.
3630         (_initialize_cli_logging): Add debugredirect command.
3631         * interps.c (current_interp_set_logging): Add debug_redirect
3632         parameter.
3633         * interps.h (set_logging): Add debug_redirect parameter.
3634         (current_interp_set_logging): Likewise.
3635         * mi/mi-common.h: Likewise.
3636         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3637
3638 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3639             Tom Tromey  <tromey@adacore.com>
3640
3641         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3642         directly.
3643         * cli/cli-interp.h (make_logging_output): Remove declaration.
3644         * cli/cli-logging.c (make_logging_output): Remove function.
3645         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3646         directly.
3647         * ui-file.c (tee_file::tee_file): Remove bools.
3648         (tee_file::~tee_file): Remove deletes.
3649         * ui-file.h (tee_file): Remove bools.
3650
3651 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3652
3653         * mi/mi-cmds.h (mi_cmd_complete): New function.
3654         * mi/mi-main.c (mi_cmd_complete): Likewise.
3655         * mi/mi-cmds.c: Define new MI command -complete.
3656         * NEWS: Mention new -complete command.
3657
3658 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3659
3660         * completer.h (complete): New function.
3661         * completer.c (complete): Likewise.
3662         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3663         function defined in completer.h.
3664
3665 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3666
3667         * MAINTAINERS (Write After Approval): Add myself.
3668
3669 2019-05-17  Tom de Vries  <tdevries@suse.de>
3670
3671         PR gdb/24094
3672         * dwarf2read.c (struct cu_partial_die_info): New struct.
3673         (find_partial_die): Return cu_partial_die_info.
3674         (partial_die_parent_scope, guess_partial_die_structure_name)
3675         (partial_die_info::fixup): Handle new return type of find_partial_die.
3676
3677 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3678
3679         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3680         "std::string", simplifying the algorithm.
3681
3682 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3683
3684         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3685         (stap_static_probe_ops::get_probes): Likewise.
3686
3687 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3688
3689         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3690         '-')" and "else if".
3691         (stap_parse_single_operand): Join checks for
3692         "gdbarch_stap_parse_special_token_p" and
3693         "gdbarch_stap_parse_special_token" in the same "if" statement.
3694         Invert check when verifying for operation on register
3695         displacement.
3696
3697 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3698
3699         * stap-probe.c (stap_get_opcode): Update comment.
3700         (stap_get_expected_argument_type): Likewise.
3701         (handle_stap_probe): Likewise.
3702
3703 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3704
3705         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3706         return type to 'bool'.  Adjust comment.  Use 'bool' when
3707         appropriate.
3708         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3709         * stap-probe.c (stap_parse_argument_1): Likewise.
3710         (stap_is_operator): Likewise.
3711         (stap_is_generic_prefix): Likewise.
3712         (stap_is_register_prefix): Likewise.
3713         (stap_is_register_indirection_prefix): Likewise.
3714         (stap_is_integer_prefix): Likewise.
3715         (stap_generic_check_suffix): Likewise.
3716         (stap_check_integer_suffix): Likewise.
3717         (stap_check_register_suffix): Likewise.
3718         (stap_check_register_indirection_suffix): Likewise.
3719         (stap_parse_register_operand): Likewise.
3720         (stap_parse_single_operand): Likewise.
3721         (stap_parse_argument_1): Likewise.
3722         (stap_probe::get_argument_count): Likewise.
3723         (stap_is_operator): Likewise.
3724
3725 2019-05-16  Tom Tromey  <tromey@adacore.com>
3726
3727         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3728         keyword to foreach.
3729
3730 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3731
3732         * linux-thread-db.c (try_thread_db_load_1): Change return type
3733         to bool.
3734         (try_thread_db_load): Likewise.
3735         (try_thread_db_load_from_pdir_1): Likewise.
3736         (try_thread_db_load_from_pdir): Likewise.
3737         (try_thread_db_load_from_sdir): Likewise.
3738         (try_thread_db_load_from_dir): Likewise.
3739         (thread_db_load_search): Likewise.
3740         (has_libpthread): Likewise.
3741         (thread_db_load): Likewise.
3742
3743 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3744
3745         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3746         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3747         NULL, and complain/return if that's the case.
3748
3749 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3750
3751         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3752         (advance, posn, abstract_read_memory): New functions.
3753         [struct mem_read_abstraction]: New struct.
3754         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3755
3756 2019-05-14  Tom Tromey  <tromey@adacore.com>
3757
3758         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3759         value is not lval_memory.
3760
3761 2019-05-14  Tom Tromey  <tromey@adacore.com>
3762
3763         * solib.c (info_sharedlibrary_command): Style the file name.
3764
3765 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3766
3767         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3768         (aarch64_vnv_type): Likewise.
3769         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3770         * common/tdesc.c: Likewise.
3771         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3772         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3773         * features/aarch64-fpu.xml: Add ieee half view.
3774         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3775         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3776         * gdbtypes.h (struct builtin_type): Likewise.
3777         (struct objfile_type): Likewise.
3778
3779 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3780
3781         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3782         typo.
3783         * location.h (string_to_event_location): Likewise.
3784
3785 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3786
3787         GDB 8.3 released.
3788
3789 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3790
3791         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3792         New variable declaration.
3793         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3794         New variable.
3795         (print_one_breakpoint): Use ui_out::test_flags and new global
3796         variable to compute use_fixed_output.
3797         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3798         Remove.
3799         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3800         (mi_multi_location_breakpoint_output_fixed): Remove.
3801         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3802         new variable.
3803         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3804         fix_multi_location_breakpoint_output flag if version >= 3.
3805         * ui-out.h (enum ui_out_flag)
3806         <fix_multi_location_breakpoint_output>: New enumerator.
3807
3808 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3809
3810         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3811
3812 2019-05-10  Tom Tromey  <tromey@adacore.com>
3813
3814         * ada-lang.c (catch_ada_completer): New function.
3815         (_initialize_ada_language): Use it.
3816
3817 2019-05-10  Tom Tromey  <tromey@adacore.com>
3818
3819         * thread.c (print_thread_info): Make "requested_threads" const.
3820         * gdbthread.h (print_thread_info): Make "requested_threads"
3821         const.
3822         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3823         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3824
3825 2019-05-08  Tom Tromey  <tom@tromey.com>
3826
3827         * gdbtypes.c (objfile_type_data): Change type.
3828         (objfile_type, _initialize_gdbtypes): Update.
3829
3830 2019-05-08  Tom Tromey  <tom@tromey.com>
3831
3832         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3833         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3834         (_initialize_dwarf2_frame): Update.
3835
3836 2019-05-08  Tom Tromey  <tom@tromey.com>
3837
3838         * objc-lang.c (objc_objfile_data): Change type.
3839         (find_methods): Update.
3840         (_initialize_objc_lang): Remove.
3841
3842 2019-05-08  Tom Tromey  <tom@tromey.com>
3843
3844         * stabsread.c (rs6000_builtin_type_data): Change type.
3845         (rs6000_builtin_type, _initialize_stabsread): Update.
3846
3847 2019-05-08  Tom Tromey  <tom@tromey.com>
3848
3849         * mips-tdep.c (mips_pdr_data): Remove.
3850         (_initialize_mips_tdep): Update.
3851
3852 2019-05-08  Tom Tromey  <tom@tromey.com>
3853
3854         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3855         (hppa_init_objfile_priv_data, read_unwind_info)
3856         (find_unwind_entry, _initialize_hppa_tdep): Update.
3857
3858 2019-05-08  Tom Tromey  <tom@tromey.com>
3859
3860         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3861         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3862         on obstack.
3863         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3864
3865 2019-05-08  Tom Tromey  <tom@tromey.com>
3866
3867         * mdebugread.c (basic_type_data): Change type.
3868         (basic_type, _initialize_mdebugread): Update.
3869
3870 2019-05-08  Tom Tromey  <tom@tromey.com>
3871
3872         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3873
3874 2019-05-08  Tom Tromey  <tom@tromey.com>
3875
3876         * nto-tdep.c (nto_inferior_data_reg): Change type.
3877         (nto_inferior_data): Update.
3878         (nto_inferior_data_cleanup, nto_new_inferior_data)
3879         (_initialize_nto_tdep): Remove.
3880         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3881
3882 2019-05-08  Tom Tromey  <tom@tromey.com>
3883
3884         * ada-lang.c (struct ada_inferior_data): Add initializers.
3885         (ada_inferior_data): Change type.
3886         (ada_inferior_data_cleanup): Remove.
3887         (get_ada_inferior_data, ada_inferior_exit)
3888         (struct ada_pspace_data): Add initializers, destructor.
3889         (ada_pspace_data_handle): Change type.
3890         (get_ada_pspace_data): Update.
3891         (ada_pspace_data_cleanup): Remove.
3892
3893 2019-05-08  Tom Tromey  <tom@tromey.com>
3894
3895         * coffread.c (struct coff_symfile_info): Add initializers.
3896         (coff_objfile_data_key): Move lower.  Change type.
3897         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3898         Update.
3899         (coff_free_info): Remove.
3900
3901 2019-05-08  Tom Tromey  <tom@tromey.com>
3902
3903         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3904         (fbsd_pspace_data_handle): Move lower.  Change type.
3905         (get_fbsd_pspace_data): Update.
3906         (fbsd_pspace_data_cleanup): Remove.
3907         (_initialize_fbsd_tdep): Update.
3908
3909 2019-05-08  Tom Tromey  <tom@tromey.com>
3910
3911         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3912         (get_ada_tasks_pspace_data): Update.
3913         (ada_tasks_pspace_data_cleanup): Remove.
3914         (_initialize_tasks): Update.
3915         (ada_tasks_inferior_data_handle): Change type.
3916         (get_ada_tasks_inferior_data): Update.
3917         (ada_tasks_inferior_data_cleanup): Remove.
3918         (struct ada_tasks_pspace_data): Add initializers.
3919
3920 2019-05-08  Tom Tromey  <tom@tromey.com>
3921
3922         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3923         * symfile-debug.c (debug_sym_get_probes): Change type.
3924         * stap-probe.c (handle_stap_probe):
3925         (stap_static_probe_ops::get_probes): Change type.
3926         * probe.h (class static_probe_ops) <get_probes>: Change type.
3927         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3928         (parse_probes_in_pspace): Update.
3929         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3930         Update.
3931         (any_static_probe_ops::get_probes): Change type.
3932         * elfread.c (elfread_data): New typedef.
3933         (probe_key): Change type.
3934         (elf_get_probes): Likewise.  Update.
3935         (probe_key_free): Remove.
3936         (_initialize_elfread): Update.
3937         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3938         Change type.
3939         (dtrace_process_dof_probe, dtrace_process_dof)
3940         (dtrace_static_probe_ops::get_probe): Change type.
3941
3942 2019-05-08  Tom Tromey  <tom@tromey.com>
3943
3944         * xcoffread.c (struct xcoff_symfile_info): Rename from
3945         coff_symfile_info.  Add initializers.
3946         (xcoff_objfile_data_key): Move lower.  Change type.
3947         (XCOFF_DATA): Rewrite.
3948         (xcoff_free_info): Remove.
3949         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3950         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3951         (xcoff_initial_scan): Update.
3952
3953 2019-05-08  Tom Tromey  <tom@tromey.com>
3954
3955         * solib-svr4.c (struct svr4_info): Add initializers and
3956         destructor.
3957         <probes_table>: Now an htab_up.
3958         (solib_svr4_pspace_data): Change type.
3959         (free_probes_table): Simplify.
3960         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3961         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3962         (probes_table_remove_objfile_probes, register_solib_event_probe)
3963         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3964         (_initialize_svr4_solib): Update.
3965
3966 2019-05-08  Tom Tromey  <tom@tromey.com>
3967
3968         * remote.c (remote_pspace_data): Change type.
3969         (remote_pspace_data_cleanup): Remove.
3970         (get_remote_exec_file, set_pspace_remote_exec_file)
3971         (_initialize_remote): Update.
3972
3973 2019-05-08  Tom Tromey  <tom@tromey.com>
3974
3975         * breakpoint.c (breakpoint_objfile_key): Change type.
3976         (get_breakpoint_objfile_data): Update.
3977         (free_breakpoint_objfile_data): Remove.
3978         (_initialize_breakpoint): Update.
3979
3980 2019-05-08  Tom Tromey  <tom@tromey.com>
3981
3982         * linux-tdep.c (struct linux_info): Add initializers.
3983         (linux_inferior_data): Move.  Change type.
3984         (invalidate_linux_cache_inf): Update.
3985         (linux_inferior_data_cleanup): Remove.
3986         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3987
3988 2019-05-08  Tom Tromey  <tom@tromey.com>
3989
3990         * auxv.c (auxv_inferior_data): Move.  Change type.
3991         (auxv_inferior_data_cleanup): Remove.
3992         (invalidate_auxv_cache_inf): Rewrite.
3993         (get_auxv_inferior_data, _initialize_auxv): Update.
3994
3995 2019-05-08  Tom Tromey  <tom@tromey.com>
3996
3997         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3998         (symfile_debug_objfile_data_key): Change type.
3999         (symfile_debug_installed, debug_qf_has_symbols)
4000         (debug_qf_find_last_source_symtab)
4001         (debug_qf_forget_cached_source_info)
4002         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4003         (debug_qf_print_stats, debug_qf_dump)
4004         (debug_qf_expand_symtabs_for_function)
4005         (debug_qf_expand_all_symtabs)
4006         (debug_qf_expand_symtabs_with_fullname)
4007         (debug_qf_map_matching_symbols)
4008         (debug_qf_expand_symtabs_matching)
4009         (debug_qf_find_pc_sect_compunit_symtab)
4010         (debug_qf_map_symbol_filenames)
4011         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4012         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4013         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4014         (debug_sym_read_linetable, debug_sym_relocate): Update.
4015         (symfile_debug_free_objfile): Remove.
4016         (install_symfile_debug_logging, _initialize_symfile_debug):
4017         Update.
4018
4019 2019-05-08  Tom Tromey  <tom@tromey.com>
4020
4021         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4022         allocate_on_obstack.
4023         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4024         (get_dwarf2_per_objfile): Update.
4025         (set_dwarf2_per_objfile): Remove.
4026         (dwarf2_has_info, dwarf2_get_section_info): Update.
4027         (dwarf2_free_objfile): Remove.
4028         (_initialize_dwarf2_read): Update.
4029
4030 2019-05-08  Tom Tromey  <tom@tromey.com>
4031
4032         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4033         initializers.
4034         <unsupported_script_warning_printed,
4035         script_not_found_warning_printed>: Now bool.
4036         (auto_load_pspace_data): Change type.
4037         (~auto_load_pspace_info): Rename from
4038         auto_load_pspace_data_cleanup.
4039         (get_auto_load_pspace_data, init_loaded_scripts_info)
4040         (clear_section_scripts, maybe_print_unsupported_script_warning)
4041         (maybe_print_script_not_found_warning, _initialize_auto_load):
4042         Update.
4043
4044 2019-05-08  Tom Tromey  <tom@tromey.com>
4045
4046         * objfiles.c (objfile_pspace_info): Add destructor and
4047         initializers.
4048         (objfiles_pspace_data): Change type.
4049         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4050         (get_objfile_pspace_data): Update.
4051         (objfiles_bfd_data): Change type.
4052         (get_objfile_bfd_data): Update.
4053         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4054
4055 2019-05-08  Tom Tromey  <tom@tromey.com>
4056
4057         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4058         Change type.
4059         (get_catch_syscall_inferior_data): Update.
4060         (catch_syscall_inferior_data_cleanup): Remove.
4061         (_initialize_break_catch_syscall): Update.
4062
4063 2019-05-08  Tom Tromey  <tom@tromey.com>
4064
4065         * inflow.c (struct terminal_info): Add destructor and
4066         initializers.
4067         (inflow_inferior_data): Change type.
4068         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4069         (get_inflow_inferior_data, inflow_inferior_exit)
4070         (swap_terminal_info, _initialize_inflow): Update.
4071
4072 2019-05-08  Tom Tromey  <tom@tromey.com>
4073
4074         * target-dcache.c (target_dcache_cleanup): Remove.
4075         (target_dcache_aspace_key): Change type.
4076         (target_dcache_init_p, target_dcache_invalidate)
4077         (target_dcache_get, target_dcache_get_or_init)
4078         (_initialize_target_dcache): Update.
4079         * dcache.h (struct dcache_deleter): New.
4080
4081 2019-05-08  Tom Tromey  <tom@tromey.com>
4082
4083         * symtab.c (struct symbol_cache): Add destructor and
4084         initializers.
4085         (symbol_cache_key): Move.  Change type.
4086         (make_symbol_cache, free_symbol_cache): Remove.
4087         (get_symbol_cache): Update.
4088         (symbol_cache_cleanup): Remove.
4089         (ALL_PSPACES, symbol_cache_flush)
4090         (maintenance_print_symbol_cache)
4091         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4092         Update.
4093
4094 2019-05-08  Tom Tromey  <tom@tromey.com>
4095
4096         * symtab.c (struct main_info): Add destructor and initializers.
4097         (main_progspace_key): Move.  Change type.
4098         (get_main_info): Update.
4099         (main_info_cleanup): Remove.
4100         (_initialize_symtab): Update.
4101
4102 2019-05-08  Tom Tromey  <tom@tromey.com>
4103
4104         * registry.h (DECLARE_REGISTRY): Define the _key class.
4105
4106 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4107
4108         * NEWS: Merge two 'New commands' sections.
4109
4110 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4111
4112         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4113         parameter and use Ada language definition instead.
4114         (ada_val_print_ptr): Remove unused language parameter.
4115         (ada_val_print_num): Remove language parameter and use Ada language
4116         definition instead.
4117         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4118         parameter.
4119         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4120         parameter and use Ada language definition instead.
4121         (ada_val_print_1): Update all ada_val_print_xxx calls.
4122         Remove language parameter.
4123         (ada_val_print): Update ada_val_print_1 call.
4124
4125 2019-05-08  Tom Tromey  <tromey@adacore.com>
4126
4127         * remote.c (remote_hw_watchpoint_limit)
4128         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4129         Now static.
4130
4131 2019-05-08  Tom Tromey  <tromey@adacore.com>
4132
4133         * maint.c (_initialize_maint_cmds): Move initialization code to
4134         remote.c.
4135         (watchdog, show_watchdog): Move to remote.c.
4136         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4137         "watchdog" static.
4138         (_initialize_remote): Move initialization code from maint.c.
4139         * defs.h (watchdog): Don't declare.
4140
4141 2019-05-08  Tom Tromey  <tromey@adacore.com>
4142
4143         * tui/tui-interp.c: Include main.h.
4144         * interps.c: Include main.h.
4145         * main.h (interpreter_p): Declare.
4146         * defs.h (interpreter_p): Don't declare.
4147
4148 2019-05-08  Tom Tromey  <tromey@adacore.com>
4149
4150         * dwarf2loc.c: Include dwarf2read.h.
4151         * defs.h (read_unsigned_leb128): Don't declare.
4152         * dwarf2read.h (read_unsigned_leb128): Declare.
4153
4154 2019-05-08  Tom Tromey  <tromey@adacore.com>
4155
4156         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4157         method.
4158
4159 2019-05-08  Tom Tromey  <tromey@adacore.com>
4160
4161         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4162         when no wrap column is set.
4163
4164 2019-05-08  Tom Tromey  <tromey@adacore.com>
4165
4166         * c-lang.c (c_get_string): Handle non-C-style arrays.
4167
4168 2019-05-08  Tom Tromey  <tromey@adacore.com>
4169
4170         * typeprint.c (print_offset_data::update): Print the bit offset,
4171         not the number of bits remaining.
4172
4173 2019-05-08  Tom Tromey  <tromey@adacore.com>
4174
4175         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4176         padding at end of comment.
4177
4178 2019-05-08  Tom Tromey  <tromey@adacore.com>
4179
4180         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4181         Compare main types.
4182
4183 2019-05-06  Tom Tromey  <tom@tromey.com>
4184
4185         * common/scoped_mmap.c: Include common-defs.h.
4186         * common/scoped_mmap.h: Don't include config.h.
4187
4188 2019-05-04  Tom Tromey  <tom@tromey.com>
4189
4190         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4191         (struct aarch64_call_info): Add initializers.
4192         <si>: Now a std::vector.
4193         (pass_on_stack, aarch64_push_dummy_call): Update.
4194
4195 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4196             Tom Tromey  <tom@tromey.com>
4197
4198         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4199         (ppc_threads): Now a std::vector.  Now static.
4200         (hwdebug_find_thread_points_by_tid)
4201         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4202         Update.
4203
4204 2019-05-04  Tom Tromey  <tom@tromey.com>
4205
4206         * arc-tdep.c (arc_tdesc_init): Return bool.
4207
4208 2019-05-04  Tom Tromey  <tom@tromey.com>
4209
4210         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4211         Use gdb_assert_not_reached.
4212
4213 2019-05-04  Tom Tromey  <tom@tromey.com>
4214
4215         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4216         "false".
4217
4218 2019-05-04  Tom Tromey  <tom@tromey.com>
4219
4220         * arc-tdep.c (arc_tdesc_init): Use bool.
4221
4222 2019-05-04  Tom Tromey  <tom@tromey.com>
4223
4224         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4225
4226 2019-05-04  Tom Tromey  <tom@tromey.com>
4227
4228         * cli/cli-cmds.c (valid_command_p): Return bool.
4229
4230 2019-05-04  Tom Tromey  <tom@tromey.com>
4231
4232         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4233         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4234
4235 2019-05-04  Raul Tambre  <raul@tambre.ee>
4236
4237         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4238         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4239         operator for comparison.
4240
4241 2019-05-04  Tom Tromey  <tom@tromey.com>
4242
4243         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4244         (lookup_partial_symbol, print_partial_symbols)
4245         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4246         (psymbol_compare): Update.
4247         (add_psymbol_to_bcache): Clear the entire psymbol.
4248         (maintenance_check_psymtabs): Update.
4249         * psympriv.h (struct partial_symbol): Don't derive from
4250         general_symbol_info.
4251         <obj_section, unrelocated_address, address,
4252         set_unrelocated_address>: Update.
4253         <ginfo>: New member.
4254         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4255         (debug_names::write_psymbols): Update.
4256
4257 2019-05-04  Tom de Vries  <tdevries@suse.de>
4258
4259         * contrib/cc-with-tweaks.sh: Support -n arg.
4260
4261 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4262
4263         * corelow.c (core_target::detach): Ensure frame cache and
4264         register caches are cleared.
4265         inferior.c (exit_inferior_1): Likewise.
4266
4267 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4268             Tom Tromey  <tom@tromey.com>
4269
4270         * dictionary.c (collate_pending_symbols_by_language): Remove
4271         "struct" from foreach.
4272         * symtab.c (lookup_global_symbol_from_objfile)
4273         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4274         foreach.
4275         * ser-tcp.c (net_open): Remove "struct" from foreach.
4276         * objfiles.c (objfile_relocate, objfile_rebase)
4277         (objfile_has_symbols): Remove "struct" from foreach.
4278         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4279         from foreach.
4280         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4281         foreach.
4282         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4283         "struct" from foreach.
4284         * ada-lang.c (create_excep_cond_exprs)
4285         (ada_exception_catchpoint_cond_string): Remove "struct" from
4286         foreach.
4287
4288 2019-05-03  Tom Tromey  <tromey@adacore.com>
4289
4290         * ada-exp.y (convert_char_literal): Check suffix of each
4291         enumerator.
4292
4293 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4294
4295         PR ada/21406:
4296         * ada-exp.y (yywrap): Don't define.
4297         * ada-lex.l (%option): Add noyywrap
4298         (yywrap): Remove.
4299
4300 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4301
4302         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4303         _WIN32_WINNT to the XP level, unless already defined to a higher
4304         level.
4305
4306         * unittests/parse-connection-spec-selftests.c:
4307         * ser-tcp.c:
4308         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4309         override.
4310
4311         * symfile.c (find_separate_debug_file): Remove colon from the
4312         drive spec of DOS/Windows file names of the target, so that the
4313         file name produced from DEBUGDIR and the target's directory will
4314         be valid on DOS/Windows systems.
4315
4316 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4317
4318         * rust-lang.c (val_print_struct): Handle printing structures
4319         containing strings.
4320
4321 2019-05-02  Tom Tromey  <tromey@adacore.com>
4322
4323         * valarith.c (_initialize_valarith): Remove.
4324
4325 2019-05-01  Tom Tromey  <tromey@adacore.com>
4326
4327         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4328         bitfields.
4329
4330 2019-05-01  Tom Tromey  <tromey@adacore.com>
4331
4332         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4333         for big-endian copies.
4334
4335 2019-04-30  Ali Tamur  <tamur@google.com>
4336         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4337         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4338         (read_3_bytes): New function.
4339
4340 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4341
4342         * windows-nat.c (main_thread_id): Delete.
4343         (handle_output_debug_string): Replace main_thread_id by
4344         current_event.dwThreadId.
4345         (fake_create_process): Likewise.
4346         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4347         Do not set main_thread_id.
4348         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4349         current_event.dwThreadId.
4350         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4351
4352 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4353
4354         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4355         Use current_event.dwThreadId instead of main_thread_id.
4356
4357 2019-04-30  Tom Tromey  <tromey@adacore.com>
4358
4359         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4360         (create_excep_cond_exprs): Iterate over program spaces.
4361         (ada_exception_catchpoint_cond_string): Examine all minimal
4362         symbols for exception types.
4363
4364 2019-04-30  Tom Tromey  <tromey@adacore.com>
4365
4366         PR c++/24470:
4367         * dwarf2read.c (process_structure_scope): Handle case where type
4368         has template parameters but no symbol was created.
4369
4370 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4371             Chris January  <chris.january@arm.com>
4372
4373         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4374         qualifier.
4375         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4376
4377 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4378
4379         * f-typeprint.c (f_print_type): Update rules for printing
4380         whitespace.
4381         (f_type_print_varspec_suffix): Likewise.
4382
4383 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4384             Chris January  <chris.january@arm.com>
4385
4386         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4387         function arguments.
4388
4389 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4390
4391         * f-lang.c (build_fortran_types): Change name of void type to
4392         lower case.
4393         * f-typeprint.c (f_type_print_base): Print the name of the void
4394         type, rather than a fixed string.
4395         * f-valprint.c (f_decorations): Use lower case void string.
4396
4397 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4398             Chris January  <chris.january@arm.com>
4399
4400         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4401         types for Fortran.
4402
4403 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4404             Chris January  <chris.january@arm.com>
4405             David Lecomber  <david.lecomber@arm.com>
4406
4407         * f-exp.y (BINOP_INTRINSIC): New token.
4408         (exp): New parser rule handling BINOP_INTRINSIC.
4409         (f77_keywords): Add new builtin procedures.
4410         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4411         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4412         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4413         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4414         (print_unop_subexp_f): New function.
4415         (print_binop_subexp_f): New function.
4416         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4417         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4418         (dump_subexp_body_f): Likewise.
4419         (operator_check_f): Likewise.
4420         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4421         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4422
4423 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4424
4425         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4426         UNOP_KIND.
4427         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4428         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4429         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4430         (operator_length_f): New fuction.
4431         (print_subexp_f): New function.
4432         (op_name_f): New function.
4433         (dump_subexp_body_f): New function.
4434         (operator_check_f): New function.
4435         (exp_descriptor_f): Replace standard expression handling functions
4436         with new functions.
4437         * gdb/fortran-operator.def: New file.
4438         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4439         * gdb/std-operator.def: Remove UNOP_KIND.
4440
4441 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4442
4443         * std-operator.def: Remove unbalanced, stray double quote
4444         character.
4445
4446 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4447             Chris January  <chris.january@arm.com>
4448             Daniel Everett  <daniel.everett@arm.com>
4449             Nick Forrington  <nick.forrington@arm.com>
4450             Richard Bunt  <richard.bunt@arm.com>
4451
4452         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4453         of depth when printing anonymous structs or unions.
4454         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4455         Don't print either the top-level value, or the children if the
4456         max-depth is exceeded.
4457         (ppscm_print_children): When printing the key of a map, allow one
4458         extra level of depth.
4459         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4460         print either the top-level value, or the children if the max-depth
4461         is exceeded.
4462         (print_children): When printing the key of a map, allow one extra
4463         level of depth.
4464         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4465         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4466         (user_print_options): Initialise max_depth field.
4467         (val_print_scalar_or_string_type_p): New function.
4468         (val_print): Check to see if the max depth has been reached.
4469         (val_print_check_max_depth): Define new function.
4470         (show_print_max_depth): New function.
4471         (_initialize_valprint): Add 'print max-depth' option.
4472         * valprint.h (struct value_print_options) <max_depth>: New field.
4473         (val_print_check_max_depth): Declare new function.
4474         * NEWS: Document new feature.
4475
4476 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4477
4478         * ada-lang.c (ada_language_defn): Initialise new field.
4479         * c-lang.c (c_is_string_type_p): New function.
4480         (c_language_defn): Initialise new field.
4481         (cplus_language_defn): Initialise new field.
4482         (asm_language_defn): Initialise new field.
4483         (minimal_language_defn): Initialise new field.
4484         * c-lang.h (c_is_string_type_p): Declare new function.
4485         * d-lang.c (d_language_defn): Initialise new field.
4486         * f-lang.c (f_is_string_type_p): New function.
4487         (f_language_defn): Initialise new field.
4488         * go-lang.c (go_is_string_type_p): New function.
4489         (go_language_defn): Initialise new field.
4490         * language.c (default_is_string_type_p): New function.
4491         (unknown_language_defn): Initialise new field.
4492         (auto_language_defn): Initialise new field.
4493         * language.h (struct language_defn) <la_is_string_type_p>: New
4494         member variable.
4495         (default_is_string_type_p): Declare new function.
4496         * m2-lang.c (m2_language_defn): Initialise new field.
4497         * objc-lang.c (objc_language_defn): Initialise new field.
4498         * opencl-lang.c (opencl_language_defn): Initialise new field.
4499         * p-lang.c (pascal_is_string_type_p): New function.
4500         (pascal_language_defn): Initialise new field.
4501         * rust-lang.c (rust_is_string_type_p): New function.
4502         (rust_language_defn): Initialise new field.
4503
4504 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4505
4506         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4507         New field.
4508         * ada-lang.c (ada_language_defn): Initialise new field.
4509         * c-lang.c (c_language_defn): Likewise.
4510         (cplus_language_defn): Likewise.
4511         (asm_language_defn): Likewise.
4512         (minimal_language_defn): Likewise.
4513         * d-lang.c (d_language_defn): Likewise.
4514         * f-lang.c (f_language_defn): Likewise.
4515         * go-lang.c (go_language_defn): Likewise.
4516         * language.c (unknown_language_defn): Likewise.
4517         (auto_language_defn): Likewise.
4518         * m2-lang.c (m2_language_defn): Likewise.
4519         * objc-lang.c (objc_language_defn): Likewise.
4520         * opencl-lang.c (opencl_language_defn): Likewise.
4521         * p-lang.c (pascal_language_defn): Likewise.
4522         * rust-lang.c (rust_language_defn): Likewise.
4523
4524 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4525
4526         * ada-lang.c (ada_is_character_type): Change return type to bool.
4527         (ada_is_string_type): Likewise.
4528         * ada-lang.h (ada_is_character_type): Update declaration
4529         (ada_is_string_type): Likewise.
4530
4531 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4532
4533         Support style in 'frame|thread apply'
4534
4535         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4536         * record.c (record_start, record_stop): Update callers of
4537         execute_command_to_string with false.
4538         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4539         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4540         methods.
4541         (class string_file): New constructor with term_out parameter.
4542         Override methods term_out and can_emit_style_escape.  New member
4543         term_out.
4544         (class stdio_file): Override can_emit_style_escape.
4545         (class tee_file): Override term_out and can_emit_style_escape.
4546         * utils.h (can_emit_style_escape): Remove.
4547         * utils.c (can_emit_style_escape): Likewise.
4548         Update all callers of can_emit_style_escape (SOMESTREAM) to
4549         SOMESTREAM->can_emit_style_escape.
4550         * source-cache.c (source_cache::get_source_lines): Likewise.
4551         * stack.c (frame_apply_command_count): Call execute_command_to_string
4552         passing the term_out characteristic of the current gdb_stdout.
4553         * thread.c (thr_try_catch_cmd): Likewise.
4554         * top.c (execute_command_to_string): pass term_out parameter
4555         to construct the string_file for the command output.
4556         * ui-file.c (term_cli_styling): New function (most code moved
4557         from utils.c can_emit_style_escape).
4558         (string_file::string_file, string_file::can_emit_style_escape,
4559         stdio_file::can_emit_style_escape, tee_file::term_out,
4560         tee_file::can_emit_style_escape): New functions.
4561
4562 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4563
4564         * NEWS: Mention the new set|show may-call-functions.
4565         * infcall.c (may_call_functions_p): New variable.
4566         (show_may_call_functions_p): New function.
4567         (call_function_by_hand_dummy): Throws an error if not
4568         may-call-functions.
4569         (_initialize_infcall): Call add_setshow_boolean_cmd for
4570         may-call-functions.
4571
4572 2019-04-25  Keith Seitz  <keiths@redhat.com>
4573
4574         PR c++/24367
4575         * cp-support.c (inspect_type): Don't attempt substitutions
4576         of symbol with the same name.
4577
4578 2019-04-25  Tom Tromey  <tromey@adacore.com>
4579
4580         PR gdb/24475:
4581         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4582         static.
4583
4584 2019-04-25  Tom Tromey  <tromey@adacore.com>
4585
4586         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4587         rvalue reference.
4588         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4589         (gdb_xml_parser::parse): Use std::move.
4590         * python/python-internal.h (gdbpy_convert_exception): Take a const
4591         reference.
4592         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4593         std::move.
4594         * python/py-utils.c (gdbpy_convert_exception): Take a const
4595         reference.
4596         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4597         Use std::move.
4598         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4599         Use std::move.
4600         * mi/mi-main.c (mi_print_exception): Take a const reference.
4601         * main.c (handle_command_errors): Take a const reference.
4602         * linespec.c (parse_linespec): Use std::move.
4603         * infcall.c (run_inferior_call): Use std::move.
4604         (call_function_by_hand_dummy): Use std::move.
4605         * exec.c (try_open_exec_file): Use std::move.
4606         * exceptions.h (exception_print, exception_fprintf)
4607         (exception_print_same): Update.
4608         * exceptions.c (print_exception, exception_print)
4609         (exception_fprintf, exception_print_same): Change parameters to
4610         const reference.
4611         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4612         * common/new-op.c: Use std::move.
4613         * common/common-exceptions.h (struct gdb_exception): Add move
4614         constructor.
4615         (struct gdb_exception_error, struct gdb_exception_quit, struct
4616         gdb_quit_bad_alloc): Change constructor to move constructor.
4617         (throw_exception): Change parameter to rvalue reference.
4618         * common/common-exceptions.c (throw_exception): Take rvalue
4619         reference.
4620         * cli/cli-interp.c (safe_execute_command): Use std::move.
4621         * breakpoint.c (insert_bp_location, location_to_sals): Use
4622         std::move.
4623
4624 2019-04-25  Tom Tromey  <tromey@adacore.com>
4625
4626         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4627         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4628         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4629         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4630         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4631         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4632         guile/scm-value.c: Use unpack.
4633         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4634         gdbscm_gdb_exception.
4635         (gdbscm_throw_gdb_exception): Likewise.
4636         (struct gdbscm_gdb_exception): New.
4637         (unpack): New function.
4638         (gdbscm_wrap): Use unpack.
4639
4640 2019-04-25  Tom Tromey  <tromey@adacore.com>
4641
4642         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4643         (gdb_rl_callback_handler): Use std::move.
4644         * common/common-exceptions.h (struct gdb_exception): Add move
4645         assignment operator.
4646         (throw_exception_sjlj): Change "exception" to const reference.
4647         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4648         (throw_exception_sjlj): Change "exception" to const reference.
4649
4650 2019-04-25  Tom Tromey  <tromey@adacore.com>
4651
4652         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4653         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4654         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4655         Update.
4656         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4657         Update.
4658         * mi/mi-interp.c (mi_interp::exec): Update.
4659         * linespec.c (parse_linespec): Update.
4660         * infcall.c (run_inferior_call): Update.
4661         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4662         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4663         (gdbscm_lookup_global_symbol): Update.
4664         * guile/scm-param.c (gdbscm_parameter_value): Update.
4665         * guile/scm-frame.c (gdbscm_frame_read_register)
4666         (gdbscm_frame_read_var): Update.
4667         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4668         * exec.c (try_open_exec_file): Update.
4669         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4670         (gdb_rl_callback_handler): Update.
4671         * common/common-exceptions.h (exception_none): Don't declare.
4672         * common/common-exceptions.c (exception_none): Don't define.
4673         (struct catcher) <exception>: Update.
4674         * cli/cli-interp.c (safe_execute_command): Update.
4675         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4676
4677 2019-04-25  Ali Tamur  <tamur@google.com>
4678
4679         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4680         (read_attribute_value): Likewise.
4681         (dwarf2_read_addr_index): Update comment.
4682         (read_str_index): Add DW_FORM_strx.
4683         (dwarf2_string_attr): Likewise.
4684         (dwarf2_const_value_attr): Likewise.
4685         (dump_die_shallow): Likewise.
4686         (dwarf2_fetch_constant_bytes): Likewise.
4687         (skip_form_bytes): Likewise.
4688         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4689
4690 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4691
4692         PR corefiles/11608
4693         PR corefiles/18187
4694         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4695         OFFSET.  Verify if current mapping contains an ELF header.
4696         (linux_find_memory_regions_full): Adjust call to
4697         dump_mapping_p.
4698
4699 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4700             Kang Li <kanglictf@gmail.com>
4701
4702         PR gdb/21600
4703
4704         * dwarf2-frame.c (read_initial_length): Be consistent about using
4705         unsigned representation of length.
4706         (decode_frame_entry_1): Likewise.  Check for wraparound of
4707         end pointer as well as buffer overflow.
4708
4709 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4710
4711         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4712         "vq".
4713
4714 2019-04-24  Tom Tromey  <tromey@adacore.com>
4715
4716         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4717
4718 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4719
4720         * s12z-tdep.c (s12z_unwind_pc): Delete.
4721         (s12z_unwind_sp): Delete.
4722         (s12z_gdbarch_init): Don't register deleted functions with
4723         gdbarch.
4724
4725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4726
4727         * rl78-tdep.c (rl78_unwind_sp): Delete.
4728         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4729
4730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4731
4732         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4733         (xstormy16_unwind_pc): Delete.
4734         (xstormy16_dummy_id): Delete.
4735         (xstormy16_gdbarch_init): Don't register deleted functions with
4736         gdbarch.
4737
4738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4739
4740         * vax-tdep.c (vax_unwind_pc): Delete.
4741         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4742
4743 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4744
4745         * v850-tdep.c (v850_unwind_sp): Delete.
4746         (v850_unwind_pc): Delete.
4747         (v850_dummy_id): Delete.
4748         (v850_gdbarch_init): Don't register deleted functions with
4749         gdbarch.
4750
4751 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4752
4753         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4754         (tilegx_unwind_pc): Delete.
4755         (tilegx_unwind_dummy_id): Delete.
4756         (tilegx_gdbarch_init): Don't register deleted functions with
4757         gdbarch.
4758
4759 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4760
4761         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4762         (tic6x_dummy_id): Delete.
4763         (tic6x_gdbarch_init): Don't register deleted functions with
4764         gdbarch.
4765
4766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4767
4768         * sparc-tdep.c (sparc_unwind_pc): Delete.
4769         (sparc32_gdbarch_init): Don't register deleted function with
4770         gdbarch.
4771
4772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4773
4774         * sh-tdep.c (sh_unwind_sp): Delete.
4775         (sh_unwind_pc): Delete.
4776         (sh_dummy_id): Delete.
4777         (sh_gdbarch_init): Don't register deleted functions with
4778         gdbarch.
4779
4780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4781
4782         * score-tdep.c (score_unwind_sp): Delete.
4783         (score_unwind_pc): Delete.
4784         (score_dummy_id): Delete.
4785         (score_gdbarch_init): Don't register deleted functions with
4786         gdbarch.
4787
4788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4789
4790         * rx-tdep.c (rx_unwind_pc): Delete.
4791         (rx_unwind_sp): Delete.
4792         (rx_dummy_id): Delete.
4793         (rx_gdbarch_init): Don't register deleted functions with
4794         gdbarch.  Update comment.
4795
4796 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4797
4798         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4799         (rs6000_dummy_id): Delete.
4800         (rs6000_gdbarch_init): Don't register deleted functions with
4801         gdbarch.
4802
4803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4804
4805         * or1k-tdep.c (or1k_dummy_id): Delete.
4806         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4807
4808 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4809
4810         * nios2-tdep.c (nios2_dummy_id): Delete.
4811         (nios2_unwind_sp): Delete.
4812         (nios2_gdbarch_init): Don't register deleted functions with
4813         gdbarch.
4814
4815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4816
4817         * nds32-tdep.c (nds32_dummy_id): Delete.
4818         (nds32_unwind_pc): Delete.
4819         (nds32_unwind_sp): Delete.
4820         (nds32_gdbarch_init): Don't register deleted functions with
4821         gdbarch.
4822
4823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4824
4825         * msp430-tdep.c (msp430_unwind_pc): Delete.
4826         (msp430_unwind_sp): Delete.
4827         (msp430_dummy_id): Delete.
4828         (msp430_gdbarch_init): Don't register deleted functions with
4829         gdbarch.
4830
4831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4832
4833         * moxie-tdep.c (moxie_unwind_sp): Delete.
4834         (moxie_unwind_pc): Delete.
4835         (moxie_dummy_id): Delete.
4836         (moxie_gdbarch_init): Don't register deleted functions with
4837         gdbarch.
4838
4839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4840
4841         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4842         (mn10300_unwind_pc): Delete.
4843         (mn10300_unwind_sp): Delete.
4844         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4845         mn10300_unwind_sp.
4846         (mn10300_frame_unwind_init): Don't register deleted functions with
4847         gdbarch.
4848
4849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4850
4851         * mep-tdep.c (mep_unwind_pc): Delete.
4852         (mep_unwind_sp): Delete.
4853         (mep_dummy_id): Delete.
4854         (mep_gdbarch_init): Don't register deleted functions with
4855         gdbarch.
4856
4857 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4858
4859         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4860         (m68hc11_unwind_sp): Delete.
4861         (m68hc11_gdbarch_init): Don't register deleted functions with
4862         gdbarch.
4863
4864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4865
4866         * m32r-tdep.c (m32r_unwind_sp): Delete.
4867         (m32r_unwind_pc): Delete.
4868         (m32r_dummy_id): Delete.
4869         (m32r_gdbarch_init): Don't register deleted functions with
4870         gdbarch.
4871
4872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4873
4874         * m32c-tdep.c (m32c_unwind_pc): Delete.
4875         (m32c_unwind_sp): Delete.
4876         (m32c_dummy_id): Delete.
4877         (m32c_gdbarch_init): Don't register deleted functions with
4878         gdbarch.
4879
4880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4883         (lm32_unwind_pc): Delete.
4884         (lm32_dummy_id): Delete.
4885         (lm32_gdbarch_init): Don't register deleted functions with
4886         gdbarch.
4887
4888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4889
4890         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4891         (iq2000_unwind_pc): Delete.
4892         (iq2000_dummy_id): Delete.
4893         (iq2000_gdbarch_init): Don't register deleted functions with
4894         gdbarch.
4895
4896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4897
4898         * nds32-tdep.c (nds32_type_align): Delete.
4899         (nds32_push_dummy_call): Use type_align instead.
4900
4901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4902
4903         * arm-tdep.c (arm_type_align): Only handle vector override case.
4904         (arm_push_dummy_call): Use type_align.
4905         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4906
4907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4908
4909         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4910         case.
4911         (pass_on_stack): Use type_align.
4912         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4913         function.
4914
4915 2019-04-23  Tom Tromey  <tromey@adacore.com>
4916
4917         * dwarf2read.c (line_header::file_name_at): Remove unused
4918         overload.
4919
4920 2019-04-23  Tom de Vries  <tdevries@suse.de>
4921
4922         PR gdb/24438
4923         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4924         invocation.
4925
4926
4927 2019-03-27  Ali Tamur  <tamur@google.com>
4928
4929         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4930         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4931         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4932         (dwarf_expr_context::get_addr_index): Likewise
4933         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4934         (symbol_needs_eval_context::get_addr_index): Likewise
4935         (disassemble_dwarf_expression): Add DW_OP_addrx
4936         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4937         (read_cutu_die_from_dwo): Update comment
4938         (skip_one_die): Add DW_FORM_addrx
4939         (read_attribute_value): Likewise
4940         (var_decode_location): Add DW_OP_addrx
4941         (dwarf2_const_value_attr): Add DW_FORM_addrx
4942         (dump_die_shallow): Likewise
4943         (dwarf2_fetch_constant_bytes): Likewise
4944         (decode_locdesc): Add DW_OP_addrx
4945         (skip_form_bytes): Add DW_FORM_addrx
4946
4947 2019-04-22  Ali Tamur  <tamur@google.com>
4948
4949         * MAINTAINERS (Write After Approval): Add self.
4950
4951 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4952
4953         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4954         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4955         (open_symbol_file_object): Likewise.
4956         (svr4_default_sos): Add info parameter.
4957         (svr4_read_so_list): Likewise.
4958         (svr4_current_sos_direct): Adjust functions calls to pass down
4959         info.
4960         (svr4_current_sos_1): Add info parameter.
4961         (svr4_current_sos): Call get_svr4_info, pass info down to
4962         svr4_current_sos_1.
4963         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4964         get_svr4_info.
4965         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4966         get_svr4_info.
4967         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4968         to get_svr4_info.
4969         (probes_table_remove_objfile_probes): Likewise.
4970         (register_solib_event_probe): Add info parameter.
4971         (solist_update_incremental): Pass info parameter down to
4972         svr4_read_so_list.
4973         (disable_probes_interface): Add info parameter.
4974         (svr4_handle_solib_event): Pass current_program_space to
4975         get_svr4_info.  Adjust disable_probes_interface cleanup.
4976         (svr4_create_probe_breakpoints): Add info parameter, pass it
4977         down to register_solib_event_probe.
4978         (svr4_create_solib_event_breakpoints): Add info parameter,
4979         pass it down to svr4_create_probe_breakpoints.
4980         (enable_break): Pass info down to
4981         svr4_create_solib_event_breakpoints.
4982         (svr4_solib_create_inferior_hook): Pass current_program_space to
4983         get_svr4_info.
4984         (svr4_clear_solib): Likewise.
4985
4986 2019-04-22  Pedro Alves  <palves@redhat.com>
4987
4988         * solib-svr4.c (svr4_free_objfile_observer): New.
4989         (probe_and_action::objfile): New field.
4990         (probes_table_htab_remove_objfile_probes)
4991         (probes_table_remove_objfile_probes): New functions.
4992         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4993         in the new probe_and_action.  Don't store the probe in 'lookup'.
4994         (svr4_create_probe_breakpoints): Pass objfile to
4995         register_solib_event_probe.
4996         (_initialize_svr4_solib): Register a free_objfile observer.
4997
4998 2019-04-19  Tom Tromey  <tom@tromey.com>
4999
5000         * common/queue.h: Remove.
5001
5002 2019-04-19  Tom Tromey  <tom@tromey.com>
5003
5004         * event-loop.c: Don't include "common/queue.h".
5005
5006 2019-04-19  Tom Tromey  <tom@tromey.com>
5007
5008         * remote.c (remote_target): Use delete.
5009         * remote-notif.h: Include <list>, not "common/queue.h".
5010         (notif_client_p): Remove typedef.
5011         (remote_notif_state): Add constructor, destructor, initializer.
5012         <notif_queue>: Now a std::list.
5013         (remote_notif_state_xfree): Don't declare.
5014         * remote-notif.c (remote_notif_process, handle_notification)
5015         (remote_notif_state_allocate): Update.
5016         (~remote_notif_state): Rename from remote_notif_state_xfree.
5017
5018 2019-04-19  Tom Tromey  <tom@tromey.com>
5019
5020         * symfile.c (reread_symbols): Update.
5021         * objfiles.c (objfile_register_static_link)
5022         (objfile_lookup_static_link): Update
5023         (~objfile) Don't delete static_links.
5024         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5025
5026 2019-04-19  Tom Tromey  <tom@tromey.com>
5027
5028         * type-stack.h (struct type_stack) <insert>: Constify string.
5029         * type-stack.c (type_stack::insert): Constify string.
5030         * gdbtypes.h (lookup_template_type): Update.
5031         (address_space_name_to_int): Update.
5032         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5033         const.
5034         (lookup_template_type): Make name const.
5035         * c-exp.y: Update rules.
5036         (lex_one_token, classify_name, classify_inner_name)
5037         (c_print_token): Update.
5038         * p-exp.y: Update rules.
5039         (yylex): Update.
5040         * f-exp.y: Update rules.
5041         (yylex): Update.
5042         * d-exp.y: Update rules.
5043         (lex_one_token, classify_name, classify_inner_name): Update.
5044         * parse.c (write_dollar_variable, copy_name): Return std::string.
5045         * parser-defs.h (copy_name): Change return type.
5046         * m2-exp.y: Update rules.
5047         (yylex): Update.
5048         * go-exp.y (lex_one_token): Update.
5049         Update rules.
5050         (classify_unsafe_function, classify_packaged_name)
5051         (classify_name, yylex): Update.
5052
5053 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5054
5055         * configure.ac: add --enable-source-highlight switch.
5056         * configure: Regenerate.
5057         * top.c (print_gdb_version): plumb --enable-source-highlight
5058         status to "show configuration".
5059
5060 2019-04-19  Tom Tromey  <tromey@adacore.com>
5061
5062         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5063         Check ADA_TYPE_P.
5064         (empty_record, ada_template_to_fixed_record_type_1)
5065         (template_to_static_fixed_type)
5066         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5067         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5068         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5069         macros.
5070
5071 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5072
5073         PR symtab/24423:
5074         * source.c (print_source_lines_base): Advance "iter" when a
5075         control character is seen.
5076
5077 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5078
5079         * inferior.h (struct infcall_suspend_state_deleter):
5080         Catch exception in destructor to avoid crash.
5081
5082 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5083
5084         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5085         close to the add_com "shell".
5086
5087 2019-04-18  Tom Tromey  <tromey@adacore.com>
5088
5089         * process-stratum-target.h (class process_stratum_target)
5090         <stratum>: Add "final".
5091
5092 2019-04-17  Tom Tromey  <tromey@adacore.com>
5093
5094         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5095         against nullptr before use.
5096
5097 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5098
5099         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5100
5101 2019-04-17  Jim Wilson  <jimw@sifive.com>
5102             Andrew Burgess  <andrew.burgess@embecosm.com>
5103
5104         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5105         code read might fail, assume 4-byte breakpoint in that case.
5106
5107 2019-04-15  Leszek Swirski  <leszeks@google.com>
5108
5109         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5110         rather than a hand-rolled POD check when checking for forced MEMORY
5111         classification.
5112
5113 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5114
5115         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5116         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5117         function.
5118         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5119         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5120         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5121         declaration.
5122
5123 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5124
5125         * aarch64-linux-nat.c
5126         (aarch64_linux_nat_target::thread_architecture): Add override.
5127         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5128         each VQ.
5129
5130 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5131
5132         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5133
5134 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5135
5136         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5137         target types of size 96-bits, add some additional comments, and
5138         check that the builtin type we found was the correct size.
5139
5140 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5141
5142         * utils.c (prompt_for_continue): Don't restore the styling at the
5143         end, as applied_style has the wrong value.  This fixes styling in
5144         long lists of file names that are interrupted by the "Continue?"
5145         prompt.
5146
5147 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5148
5149         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5150         * c-lang.c (c_language_defn): Likewise.
5151         (cplus_language_defn): Likewise.
5152         (asm_language_defn): Likewise.
5153         (minimal_language_defn): Likewise.
5154         * d-lang.c (d_language_defn): Likewise.
5155         * f-lang.c (f_language_defn): Likewise.
5156         * go-lang.c (go_language_defn): Likewise.
5157         * language.c (unknown_language_defn): Likewise.
5158         (auto_language_defn): Likewise.
5159         * language.h (struct language_defn): Remove la_magic field.
5160         (LANG_MAGIC): Delete.
5161         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5162         * objc-lang.c (objc_language_defn): Likewise.
5163         * opencl-lang.c (opencl_language_defn): Likewise.
5164         * p-lang.c (pascal_language_defn): Likewise.
5165         * rust-lang.c (rust_language_defn): Likewise.
5166
5167 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5168
5169         * riscv-tdep.c (riscv_type_align): New function.
5170         (riscv_type_alignment): Delete.
5171         (riscv_arg_location): Use 'type_align'.
5172         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5173
5174 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5175
5176         * gdbtypes.c (type_align): A struct with no non-static fields also
5177         has alignment of 1.
5178
5179 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5180
5181         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5182         component to 0.
5183         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5184         member.
5185         (riscv_struct_info::analyse): New implementation using new
5186         analyse_inner member function.
5187         (riscv_struct_info::field_offset): New member function.
5188         (riscv_struct_info::m_offsets): New member variable.
5189         (riscv_struct_info::analyse_inner): New private member function,
5190         takes the old implementation of riscv_struct_info::analyse but
5191         extended to track field offsets.
5192         (riscv_call_arg_struct): Update the struct folding special cases
5193         to handle cases where empty C++ structs, which are non-zero
5194         length, are found.
5195         (riscv_arg_location): Initialise the length of each location, a
5196         non-zero length now indicates the location is in use.
5197         (riscv_push_dummy_call): Allow for the first location having a
5198         non-zero offset when setting up arguments.
5199         (riscv_return_value): Likewise, but for return values.
5200
5201 2019-04-11  Tom Tromey  <tromey@adacore.com>
5202
5203         * utils.c (internal_vproblem): Make "msg" const.
5204
5205 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5206
5207         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5208         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5209         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5210         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5211
5212 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5213
5214         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5215         function.
5216         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5217         of amd64_collect_native_gregset.
5218         (amd64_linux_nat_target::store_registers): Likewise.
5219
5220 2019-04-10  Tom Tromey  <tom@tromey.com>
5221
5222         * symtab.c (lookup_global_symbol_from_objfile)
5223         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5224         * objfiles.h (class separate_debug_iterator): New.
5225         (class separate_debug_range): New.
5226         (struct objfile) <separate_debug_objfiles>: New method.
5227         (objfile_separate_debug_iterate): Don't declare.
5228         * objfiles.c (separate_debug_iterator::operator++): Rename from
5229         objfile_separate_debug_iterate.
5230         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5231         iterator.
5232         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5233         iterator.
5234
5235 2019-04-10  Tom Tromey  <tom@tromey.com>
5236
5237         * symfile.c (reread_symbols): Remove old comment.
5238         * objfiles.c (free_all_objfiles): Fix a typo.
5239
5240 2019-04-10  Tom Tromey  <tom@tromey.com>
5241
5242         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5243         * minsyms.c (lookup_minimal_symbol): Use foreach.
5244         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5245         (lookup_minimal_symbol_solib_trampoline): Likewise.
5246         * symfile.c (reread_symbols): Use foreach.
5247
5248 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5249             Tom Tromey  <tromey@adacore.com>
5250
5251         PR rust/24414:
5252         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5253         (rust_lex_int_test): Change "value" to be LONGEST.
5254         (rust_lex_tests): Add test for long integer literal.
5255
5256 2019-04-09  Tom Tromey  <tromey@adacore.com>
5257
5258         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5259         to bool.
5260         (extended_remote_target::attach): Update.
5261         (remote_target::remote_notice_new_inferior): Update.
5262         (remote_target::add_current_inferior_and_thread): Update.
5263         * inferior.c (exit_inferior_1): Use "false".
5264         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5265
5266 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5267
5268         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5269         the "start" command.
5270
5271 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5272
5273         * python/py-inferior.c (infpy_thread_from_thread_handle):
5274         Adjust comments to reflect renaming of thread_from_thread_handle
5275         to thread_from_handle.  Adjust keywords.  Fix type error message.
5276         (inferior_object_methods): Add thread_from_handle.  Retain
5277         thread_from_thread_handle, but mark it as deprecated.
5278
5279 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5280
5281         * gdbthread.h (find_thread_by_handle): Revise declaration.
5282         * thread.c (find_thread_by_handle): Likewise.  Adjust
5283         implementation too.
5284         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5285         support for buffer objects as handles.
5286
5287 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5288
5289         * python/py-infthread.c (thpy_thread_handle): New function.
5290         (thread_object_methods): Register thpy_thread_handle.
5291
5292 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5293
5294         * gdbthread.h (thread_to_thread_handle): Declare.
5295         * thread.c (gdbtypes.h): Include.
5296         (thread_to_thread_handle): New function.
5297
5298         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5299         (target_thread_info_to_thread_handle): Declare.
5300         * target.c (target_thread_info_to_thread_handle): New function.
5301         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5302         * target-delegates.c: Regenerate.
5303
5304         * linux-thread-db.c (class thread_db_target): Add method
5305         thread_info_to_thread_handle.
5306         (thread_db_target::thread_info_to_thread_handle): Define.
5307         * remote.c (class remote_target): Add new method
5308         thread_info_to_thread_handle.
5309         (remote_target::thread_info_to_thread_handle): Define.
5310
5311 2019-04-08  Pedro Alves  <palves@redhat.com>
5312
5313         * common/common-exceptions.c (throw_exception): Don't create
5314         named object to throw; throw directly.
5315         (throw_it): Likewise.  Don't initialize gdb_exception::message
5316         here, with new; pass FMT and AP to the ctor instead.
5317         * common/common-exceptions.h: Include <string>.
5318         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5319         const char *, va_list)): New ctor.  Use std::make_shared.
5320         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5321         errors)): Delete.
5322         (gdb_exception_error::gdb_exception_error(enum errors, const char
5323         *, va_list)): New.
5324         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5325         Add assertion.
5326         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5327         errors)): Delete.
5328         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5329         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5330         Add assertion.
5331
5332 2019-04-08  Tom Tromey  <tom@tromey.com>
5333
5334         * valops.c (value_rtti_indirect_type): Replace throw_exception
5335         with throw.
5336         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5337         with throw.
5338         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5339         throw.
5340         * target.c (target_translate_tls_address): Replace throw_exception
5341         with throw.
5342         * stack.c (frame_apply_command_count): Replace throw_exception
5343         with throw.
5344         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5345         throw.
5346         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5347         with throw.
5348         * rs6000-tdep.c (rs6000_frame_cache)
5349         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5350         * remote.c: Replace throw_exception with throw.
5351         * record-full.c (record_full_message, record_full_wait_1)
5352         (record_full_restore): Replace throw_exception with throw.
5353         * record-btrace.c:
5354         (get_thread_current_frame_id, record_btrace_start_replaying)
5355         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5356         (cmd_record_btrace_start): Replace throw_exception with throw.
5357         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5358         throw.
5359         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5360         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5361         * linespec.c:
5362         (find_linespec_symbols): Replace throw_exception with throw.
5363         * infrun.c (displaced_step_prepare, resume): Replace
5364         throw_exception with throw.
5365         * infcmd.c (post_create_inferior): Replace throw_exception with
5366         throw.
5367         * inf-loop.c (inferior_event_handler): Replace throw_exception
5368         with throw.
5369         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5370         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5371         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5372         (get_prev_frame_always, get_frame_pc_if_available)
5373         (get_frame_address_in_block_if_available, get_frame_language):
5374         Replace throw_exception with throw.
5375         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5376         throw_exception with throw.
5377         * eval.c (fetch_subexp_value, evaluate_var_value)
5378         (evaluate_funcall, evaluate_subexp_standard): Replace
5379         throw_exception with throw.
5380         * dwarf2loc.c (call_site_find_chain)
5381         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5382         Replace throw_exception with throw.
5383         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5384         with throw.
5385         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5386         throw.
5387         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5388         * completer.c (complete_line_internal): Replace throw_exception
5389         with throw.
5390         * compile/compile-object-run.c (compile_object_run): Replace
5391         throw_exception with throw.
5392         * cli/cli-script.c (process_next_line): Replace throw_exception
5393         with throw.
5394         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5395         (btrace_enable, btrace_maint_update_pt_packets): Replace
5396         throw_exception with throw.
5397         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5398         throw_exception with throw.
5399         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5400         throw_exception with throw.
5401         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5402         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5403         * aarch64-tdep.c (aarch64_make_prologue_cache)
5404         (aarch64_make_stub_cache): Replace throw_exception with throw.
5405
5406 2019-04-08  Tom Tromey  <tom@tromey.com>
5407
5408         * common/common-exceptions.c (throw_exception): Rename from
5409         throw_exception_cxx.  Remove old copy.  Make argument const.
5410         (throw_it): Create and throw exception objects directly.
5411         * common/common-exceptions.h (throw_exception): Make argument
5412         const.
5413         (struct gdb_exception_error): Add constructor.
5414         (struct gdb_exception_quit): Add constructor.
5415
5416 2019-04-08  Tom Tromey  <tom@tromey.com>
5417
5418         * common/common-exceptions.h (exception_rethrow): Don't declare.
5419         (TRY_SJLJ): Update comment.
5420         (TRY, CATCH, END_CATCH): Remove.
5421         * common/common-exceptions.c (exception_rethrow): Remove.
5422
5423 2019-04-08  Tom Tromey  <tom@tromey.com>
5424
5425         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5426         Remove.
5427         (gdb_exception_error): Rename from
5428         gdb_exception_RETURN_MASK_ERROR.
5429         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5430         (gdb_quit_bad_alloc): Update.
5431         * aarch64-tdep.c: Update.
5432         * ada-lang.c: Update.
5433         * ada-typeprint.c: Update.
5434         * ada-valprint.c: Update.
5435         * amd64-tdep.c: Update.
5436         * arch-utils.c: Update.
5437         * break-catch-throw.c: Update.
5438         * breakpoint.c: Update.
5439         * btrace.c: Update.
5440         * c-varobj.c: Update.
5441         * cli/cli-cmds.c: Update.
5442         * cli/cli-interp.c: Update.
5443         * cli/cli-script.c: Update.
5444         * common/common-exceptions.c: Update.
5445         * common/new-op.c: Update.
5446         * common/selftest.c: Update.
5447         * compile/compile-c-symbols.c: Update.
5448         * compile/compile-cplus-symbols.c: Update.
5449         * compile/compile-object-load.c: Update.
5450         * compile/compile-object-run.c: Update.
5451         * completer.c: Update.
5452         * corelow.c: Update.
5453         * cp-abi.c: Update.
5454         * cp-support.c: Update.
5455         * cp-valprint.c: Update.
5456         * darwin-nat.c: Update.
5457         * disasm-selftests.c: Update.
5458         * dtrace-probe.c: Update.
5459         * dwarf-index-cache.c: Update.
5460         * dwarf-index-write.c: Update.
5461         * dwarf2-frame-tailcall.c: Update.
5462         * dwarf2-frame.c: Update.
5463         * dwarf2loc.c: Update.
5464         * dwarf2read.c: Update.
5465         * eval.c: Update.
5466         * event-loop.c: Update.
5467         * event-top.c: Update.
5468         * exec.c: Update.
5469         * f-valprint.c: Update.
5470         * fbsd-tdep.c: Update.
5471         * frame-unwind.c: Update.
5472         * frame.c: Update.
5473         * gdbtypes.c: Update.
5474         * gnu-v3-abi.c: Update.
5475         * guile/guile-internal.h: Update.
5476         * guile/scm-block.c: Update.
5477         * guile/scm-breakpoint.c: Update.
5478         * guile/scm-cmd.c: Update.
5479         * guile/scm-disasm.c: Update.
5480         * guile/scm-frame.c: Update.
5481         * guile/scm-lazy-string.c: Update.
5482         * guile/scm-math.c: Update.
5483         * guile/scm-param.c: Update.
5484         * guile/scm-ports.c: Update.
5485         * guile/scm-pretty-print.c: Update.
5486         * guile/scm-symbol.c: Update.
5487         * guile/scm-symtab.c: Update.
5488         * guile/scm-type.c: Update.
5489         * guile/scm-value.c: Update.
5490         * i386-linux-tdep.c: Update.
5491         * i386-tdep.c: Update.
5492         * inf-loop.c: Update.
5493         * infcall.c: Update.
5494         * infcmd.c: Update.
5495         * infrun.c: Update.
5496         * jit.c: Update.
5497         * language.c: Update.
5498         * linespec.c: Update.
5499         * linux-fork.c: Update.
5500         * linux-nat.c: Update.
5501         * linux-tdep.c: Update.
5502         * linux-thread-db.c: Update.
5503         * main.c: Update.
5504         * mi/mi-cmd-break.c: Update.
5505         * mi/mi-cmd-stack.c: Update.
5506         * mi/mi-interp.c: Update.
5507         * mi/mi-main.c: Update.
5508         * objc-lang.c: Update.
5509         * p-valprint.c: Update.
5510         * parse.c: Update.
5511         * ppc-linux-tdep.c: Update.
5512         * printcmd.c: Update.
5513         * python/py-arch.c: Update.
5514         * python/py-breakpoint.c: Update.
5515         * python/py-cmd.c: Update.
5516         * python/py-finishbreakpoint.c: Update.
5517         * python/py-frame.c: Update.
5518         * python/py-framefilter.c: Update.
5519         * python/py-gdb-readline.c: Update.
5520         * python/py-inferior.c: Update.
5521         * python/py-infthread.c: Update.
5522         * python/py-lazy-string.c: Update.
5523         * python/py-linetable.c: Update.
5524         * python/py-objfile.c: Update.
5525         * python/py-param.c: Update.
5526         * python/py-prettyprint.c: Update.
5527         * python/py-progspace.c: Update.
5528         * python/py-record-btrace.c: Update.
5529         * python/py-record.c: Update.
5530         * python/py-symbol.c: Update.
5531         * python/py-type.c: Update.
5532         * python/py-unwind.c: Update.
5533         * python/py-utils.c: Update.
5534         * python/py-value.c: Update.
5535         * python/python.c: Update.
5536         * record-btrace.c: Update.
5537         * record-full.c: Update.
5538         * remote-fileio.c: Update.
5539         * remote.c: Update.
5540         * riscv-tdep.c: Update.
5541         * rs6000-aix-tdep.c: Update.
5542         * rs6000-tdep.c: Update.
5543         * rust-exp.y: Update.
5544         * rust-lang.c: Update.
5545         * s390-tdep.c: Update.
5546         * selftest-arch.c: Update.
5547         * solib-dsbt.c: Update.
5548         * solib-frv.c: Update.
5549         * solib-spu.c: Update.
5550         * solib-svr4.c: Update.
5551         * solib.c: Update.
5552         * sparc64-linux-tdep.c: Update.
5553         * stack.c: Update.
5554         * symfile-mem.c: Update.
5555         * symmisc.c: Update.
5556         * target.c: Update.
5557         * thread.c: Update.
5558         * top.c: Update.
5559         * tracefile-tfile.c: Update.
5560         * tui/tui.c: Update.
5561         * typeprint.c: Update.
5562         * unittests/cli-utils-selftests.c: Update.
5563         * unittests/parse-connection-spec-selftests.c: Update.
5564         * valops.c: Update.
5565         * valprint.c: Update.
5566         * value.c: Update.
5567         * varobj.c: Update.
5568         * windows-nat.c: Update.
5569         * x86-linux-nat.c: Update.
5570         * xml-support.c: Update.
5571
5572 2019-04-08  Tom Tromey  <tom@tromey.com>
5573
5574         * xml-support.c: Use C++ exception handling.
5575         * x86-linux-nat.c: Use C++ exception handling.
5576         * windows-nat.c: Use C++ exception handling.
5577         * varobj.c: Use C++ exception handling.
5578         * value.c: Use C++ exception handling.
5579         * valprint.c: Use C++ exception handling.
5580         * valops.c: Use C++ exception handling.
5581         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5582         handling.
5583         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5584         * typeprint.c: Use C++ exception handling.
5585         * tui/tui.c: Use C++ exception handling.
5586         * tracefile-tfile.c: Use C++ exception handling.
5587         * top.c: Use C++ exception handling.
5588         * thread.c: Use C++ exception handling.
5589         * target.c: Use C++ exception handling.
5590         * symmisc.c: Use C++ exception handling.
5591         * symfile-mem.c: Use C++ exception handling.
5592         * stack.c: Use C++ exception handling.
5593         * sparc64-linux-tdep.c: Use C++ exception handling.
5594         * solib.c: Use C++ exception handling.
5595         * solib-svr4.c: Use C++ exception handling.
5596         * solib-spu.c: Use C++ exception handling.
5597         * solib-frv.c: Use C++ exception handling.
5598         * solib-dsbt.c: Use C++ exception handling.
5599         * selftest-arch.c: Use C++ exception handling.
5600         * s390-tdep.c: Use C++ exception handling.
5601         * rust-lang.c: Use C++ exception handling.
5602         * rust-exp.y: Use C++ exception handling.
5603         * rs6000-tdep.c: Use C++ exception handling.
5604         * rs6000-aix-tdep.c: Use C++ exception handling.
5605         * riscv-tdep.c: Use C++ exception handling.
5606         * remote.c: Use C++ exception handling.
5607         * remote-fileio.c: Use C++ exception handling.
5608         * record-full.c: Use C++ exception handling.
5609         * record-btrace.c: Use C++ exception handling.
5610         * python/python.c: Use C++ exception handling.
5611         * python/py-value.c: Use C++ exception handling.
5612         * python/py-utils.c: Use C++ exception handling.
5613         * python/py-unwind.c: Use C++ exception handling.
5614         * python/py-type.c: Use C++ exception handling.
5615         * python/py-symbol.c: Use C++ exception handling.
5616         * python/py-record.c: Use C++ exception handling.
5617         * python/py-record-btrace.c: Use C++ exception handling.
5618         * python/py-progspace.c: Use C++ exception handling.
5619         * python/py-prettyprint.c: Use C++ exception handling.
5620         * python/py-param.c: Use C++ exception handling.
5621         * python/py-objfile.c: Use C++ exception handling.
5622         * python/py-linetable.c: Use C++ exception handling.
5623         * python/py-lazy-string.c: Use C++ exception handling.
5624         * python/py-infthread.c: Use C++ exception handling.
5625         * python/py-inferior.c: Use C++ exception handling.
5626         * python/py-gdb-readline.c: Use C++ exception handling.
5627         * python/py-framefilter.c: Use C++ exception handling.
5628         * python/py-frame.c: Use C++ exception handling.
5629         * python/py-finishbreakpoint.c: Use C++ exception handling.
5630         * python/py-cmd.c: Use C++ exception handling.
5631         * python/py-breakpoint.c: Use C++ exception handling.
5632         * python/py-arch.c: Use C++ exception handling.
5633         * printcmd.c: Use C++ exception handling.
5634         * ppc-linux-tdep.c: Use C++ exception handling.
5635         * parse.c: Use C++ exception handling.
5636         * p-valprint.c: Use C++ exception handling.
5637         * objc-lang.c: Use C++ exception handling.
5638         * mi/mi-main.c: Use C++ exception handling.
5639         * mi/mi-interp.c: Use C++ exception handling.
5640         * mi/mi-cmd-stack.c: Use C++ exception handling.
5641         * mi/mi-cmd-break.c: Use C++ exception handling.
5642         * main.c: Use C++ exception handling.
5643         * linux-thread-db.c: Use C++ exception handling.
5644         * linux-tdep.c: Use C++ exception handling.
5645         * linux-nat.c: Use C++ exception handling.
5646         * linux-fork.c: Use C++ exception handling.
5647         * linespec.c: Use C++ exception handling.
5648         * language.c: Use C++ exception handling.
5649         * jit.c: Use C++ exception handling.
5650         * infrun.c: Use C++ exception handling.
5651         * infcmd.c: Use C++ exception handling.
5652         * infcall.c: Use C++ exception handling.
5653         * inf-loop.c: Use C++ exception handling.
5654         * i386-tdep.c: Use C++ exception handling.
5655         * i386-linux-tdep.c: Use C++ exception handling.
5656         * guile/scm-value.c: Use C++ exception handling.
5657         * guile/scm-type.c: Use C++ exception handling.
5658         * guile/scm-symtab.c: Use C++ exception handling.
5659         * guile/scm-symbol.c: Use C++ exception handling.
5660         * guile/scm-pretty-print.c: Use C++ exception handling.
5661         * guile/scm-ports.c: Use C++ exception handling.
5662         * guile/scm-param.c: Use C++ exception handling.
5663         * guile/scm-math.c: Use C++ exception handling.
5664         * guile/scm-lazy-string.c: Use C++ exception handling.
5665         * guile/scm-frame.c: Use C++ exception handling.
5666         * guile/scm-disasm.c: Use C++ exception handling.
5667         * guile/scm-cmd.c: Use C++ exception handling.
5668         * guile/scm-breakpoint.c: Use C++ exception handling.
5669         * guile/scm-block.c: Use C++ exception handling.
5670         * guile/guile-internal.h: Use C++ exception handling.
5671         * gnu-v3-abi.c: Use C++ exception handling.
5672         * gdbtypes.c: Use C++ exception handling.
5673         * frame.c: Use C++ exception handling.
5674         * frame-unwind.c: Use C++ exception handling.
5675         * fbsd-tdep.c: Use C++ exception handling.
5676         * f-valprint.c: Use C++ exception handling.
5677         * exec.c: Use C++ exception handling.
5678         * event-top.c: Use C++ exception handling.
5679         * event-loop.c: Use C++ exception handling.
5680         * eval.c: Use C++ exception handling.
5681         * dwarf2read.c: Use C++ exception handling.
5682         * dwarf2loc.c: Use C++ exception handling.
5683         * dwarf2-frame.c: Use C++ exception handling.
5684         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5685         * dwarf-index-write.c: Use C++ exception handling.
5686         * dwarf-index-cache.c: Use C++ exception handling.
5687         * dtrace-probe.c: Use C++ exception handling.
5688         * disasm-selftests.c: Use C++ exception handling.
5689         * darwin-nat.c: Use C++ exception handling.
5690         * cp-valprint.c: Use C++ exception handling.
5691         * cp-support.c: Use C++ exception handling.
5692         * cp-abi.c: Use C++ exception handling.
5693         * corelow.c: Use C++ exception handling.
5694         * completer.c: Use C++ exception handling.
5695         * compile/compile-object-run.c: Use C++ exception handling.
5696         * compile/compile-object-load.c: Use C++ exception handling.
5697         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5698         * compile/compile-c-symbols.c: Use C++ exception handling.
5699         * common/selftest.c: Use C++ exception handling.
5700         * common/new-op.c: Use C++ exception handling.
5701         * cli/cli-script.c: Use C++ exception handling.
5702         * cli/cli-interp.c: Use C++ exception handling.
5703         * cli/cli-cmds.c: Use C++ exception handling.
5704         * c-varobj.c: Use C++ exception handling.
5705         * btrace.c: Use C++ exception handling.
5706         * breakpoint.c: Use C++ exception handling.
5707         * break-catch-throw.c: Use C++ exception handling.
5708         * arch-utils.c: Use C++ exception handling.
5709         * amd64-tdep.c: Use C++ exception handling.
5710         * ada-valprint.c: Use C++ exception handling.
5711         * ada-typeprint.c: Use C++ exception handling.
5712         * ada-lang.c: Use C++ exception handling.
5713         * aarch64-tdep.c: Use C++ exception handling.
5714
5715 2019-04-08  Tom Tromey  <tom@tromey.com>
5716
5717         * xml-support.c (gdb_xml_parser::parse): Update.
5718         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5719         * value.c (show_convenience): Update.
5720         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5721         (test_parse_flags_qcs): Update.
5722         * thread.c (thr_try_catch_cmd): Update.
5723         * target.c (target_translate_tls_address): Update.
5724         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5725         (info_frame_command_core, frame_apply_command_count): Update.
5726         * rust-exp.y (rust_lex_exception_test): Update.
5727         * riscv-tdep.c (riscv_print_one_register_info): Update.
5728         * remote.c (remote_target::enable_btrace): Update.
5729         * record-btrace.c (record_btrace_enable_warn): Update.
5730         * python/py-utils.c (gdbpy_convert_exception): Update.
5731         * printcmd.c (do_one_display, print_variable_and_value): Update.
5732         * mi/mi-main.c (mi_print_exception): Update.
5733         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5734         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5735         * linux-nat.c (linux_nat_target::attach): Update.
5736         * linux-fork.c (class scoped_switch_fork_info): Update.
5737         * infrun.c (displaced_step_prepare): Update.
5738         * infcall.c (call_function_by_hand_dummy): Update.
5739         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5740         * gnu-v3-abi.c (print_one_vtable): Update.
5741         * frame.c (get_prev_frame_always): Update.
5742         * f-valprint.c (info_common_command_for_block): Update.
5743         * exec.c (try_open_exec_file): Update.
5744         * exceptions.c (print_exception, exception_print)
5745         (exception_fprintf, exception_print_same): Update.
5746         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5747         * dwarf-index-cache.c (index_cache::store)
5748         (index_cache::lookup_gdb_index): Update.
5749         * darwin-nat.c (maybe_cache_shell): Update.
5750         * cp-valprint.c (cp_print_value_fields): Update.
5751         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5752         (gcc_cplus_symbol_address): Update.
5753         * compile/compile-c-symbols.c (gcc_convert_symbol)
5754         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5755         * common/selftest.c: Update.
5756         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5757         a std::string.
5758         (exception_try_scope_entry, exception_try_scope_exit): Don't
5759         declare.
5760         (struct exception_try_scope): Remove.
5761         (TRY): Don't use exception_try_scope.
5762         (struct gdb_exception): Add constructor, operator=.
5763         <what>: New method.
5764         (struct gdb_exception_RETURN_MASK_ALL)
5765         (struct gdb_exception_RETURN_MASK_ERROR)
5766         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5767         (struct gdb_quit_bad_alloc): Update.
5768         * common/common-exceptions.c (exception_none): Change
5769         initializer.
5770         (struct catcher) <state, exception>: Initialize inline.
5771         <prev>: Remove member.
5772         (current_catcher): Remove.
5773         (catchers): New global.
5774         (exceptions_state_mc_init): Simplify.
5775         (catcher_pop): Remove.
5776         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5777         (try_scope_depth, exception_try_scope_entry)
5778         (exception_try_scope_exit): Remove.
5779         (throw_exception_sjlj): Update.
5780         (exception_messages, exception_messages_size): Remove.
5781         (throw_it): Simplify.
5782         (gdb_exception_sliced_copy): Remove.
5783         (throw_exception_cxx): Update.
5784         * cli/cli-script.c (script_from_file): Update.
5785         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5786         Update.
5787         * ada-valprint.c (ada_val_print): Update.
5788         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5789         (create_excep_cond_exprs): Update.
5790
5791 2019-04-08  Tom Tromey  <tom@tromey.com>
5792
5793         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5794         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5795         (TRY, CATCH, END_CATCH): Remove some definitions.
5796         * common/common-exceptions.c: Don't use GDB_XCPT.
5797         (catcher_list_size): Remove.
5798         (throw_exception, throw_it): Simplify.
5799
5800 2019-04-05  Tom Tromey  <tom@tromey.com>
5801
5802         Revert the header-sorting patch.
5803         * ft32-tdep.c: Revert.
5804         * frv-tdep.c: Revert.
5805         * frv-linux-tdep.c: Revert.
5806         * frame.c: Revert.
5807         * frame-unwind.c: Revert.
5808         * frame-base.c: Revert.
5809         * fork-child.c: Revert.
5810         * findvar.c: Revert.
5811         * findcmd.c: Revert.
5812         * filesystem.c: Revert.
5813         * filename-seen-cache.h: Revert.
5814         * filename-seen-cache.c: Revert.
5815         * fbsd-tdep.c: Revert.
5816         * fbsd-nat.h: Revert.
5817         * fbsd-nat.c: Revert.
5818         * f-valprint.c: Revert.
5819         * f-typeprint.c: Revert.
5820         * f-lang.c: Revert.
5821         * extension.h: Revert.
5822         * extension.c: Revert.
5823         * extension-priv.h: Revert.
5824         * expprint.c: Revert.
5825         * exec.h: Revert.
5826         * exec.c: Revert.
5827         * exceptions.c: Revert.
5828         * event-top.c: Revert.
5829         * event-loop.c: Revert.
5830         * eval.c: Revert.
5831         * elfread.c: Revert.
5832         * dwarf2read.h: Revert.
5833         * dwarf2read.c: Revert.
5834         * dwarf2loc.c: Revert.
5835         * dwarf2expr.h: Revert.
5836         * dwarf2expr.c: Revert.
5837         * dwarf2-frame.c: Revert.
5838         * dwarf2-frame-tailcall.c: Revert.
5839         * dwarf-index-write.h: Revert.
5840         * dwarf-index-write.c: Revert.
5841         * dwarf-index-common.c: Revert.
5842         * dwarf-index-cache.h: Revert.
5843         * dwarf-index-cache.c: Revert.
5844         * dummy-frame.c: Revert.
5845         * dtrace-probe.c: Revert.
5846         * disasm.h: Revert.
5847         * disasm.c: Revert.
5848         * disasm-selftests.c: Revert.
5849         * dictionary.c: Revert.
5850         * dicos-tdep.c: Revert.
5851         * demangle.c: Revert.
5852         * dcache.h: Revert.
5853         * dcache.c: Revert.
5854         * darwin-nat.h: Revert.
5855         * darwin-nat.c: Revert.
5856         * darwin-nat-info.c: Revert.
5857         * d-valprint.c: Revert.
5858         * d-namespace.c: Revert.
5859         * d-lang.c: Revert.
5860         * ctf.c: Revert.
5861         * csky-tdep.c: Revert.
5862         * csky-linux-tdep.c: Revert.
5863         * cris-tdep.c: Revert.
5864         * cris-linux-tdep.c: Revert.
5865         * cp-valprint.c: Revert.
5866         * cp-support.c: Revert.
5867         * cp-namespace.c: Revert.
5868         * cp-abi.c: Revert.
5869         * corelow.c: Revert.
5870         * corefile.c: Revert.
5871         * continuations.c: Revert.
5872         * completer.h: Revert.
5873         * completer.c: Revert.
5874         * complaints.c: Revert.
5875         * coffread.c: Revert.
5876         * coff-pe-read.c: Revert.
5877         * cli-out.h: Revert.
5878         * cli-out.c: Revert.
5879         * charset.c: Revert.
5880         * c-varobj.c: Revert.
5881         * c-valprint.c: Revert.
5882         * c-typeprint.c: Revert.
5883         * c-lang.c: Revert.
5884         * buildsym.c: Revert.
5885         * buildsym-legacy.c: Revert.
5886         * build-id.h: Revert.
5887         * build-id.c: Revert.
5888         * btrace.c: Revert.
5889         * bsd-uthread.c: Revert.
5890         * breakpoint.h: Revert.
5891         * breakpoint.c: Revert.
5892         * break-catch-throw.c: Revert.
5893         * break-catch-syscall.c: Revert.
5894         * break-catch-sig.c: Revert.
5895         * blockframe.c: Revert.
5896         * block.c: Revert.
5897         * bfin-tdep.c: Revert.
5898         * bfin-linux-tdep.c: Revert.
5899         * bfd-target.c: Revert.
5900         * bcache.c: Revert.
5901         * ax-general.c: Revert.
5902         * ax-gdb.h: Revert.
5903         * ax-gdb.c: Revert.
5904         * avr-tdep.c: Revert.
5905         * auxv.c: Revert.
5906         * auto-load.c: Revert.
5907         * arm-wince-tdep.c: Revert.
5908         * arm-tdep.c: Revert.
5909         * arm-symbian-tdep.c: Revert.
5910         * arm-pikeos-tdep.c: Revert.
5911         * arm-obsd-tdep.c: Revert.
5912         * arm-nbsd-tdep.c: Revert.
5913         * arm-nbsd-nat.c: Revert.
5914         * arm-linux-tdep.c: Revert.
5915         * arm-linux-nat.c: Revert.
5916         * arm-fbsd-tdep.c: Revert.
5917         * arm-fbsd-nat.c: Revert.
5918         * arm-bsd-tdep.c: Revert.
5919         * arch-utils.c: Revert.
5920         * arc-tdep.c: Revert.
5921         * arc-newlib-tdep.c: Revert.
5922         * annotate.h: Revert.
5923         * annotate.c: Revert.
5924         * amd64-windows-tdep.c: Revert.
5925         * amd64-windows-nat.c: Revert.
5926         * amd64-tdep.c: Revert.
5927         * amd64-sol2-tdep.c: Revert.
5928         * amd64-obsd-tdep.c: Revert.
5929         * amd64-obsd-nat.c: Revert.
5930         * amd64-nbsd-tdep.c: Revert.
5931         * amd64-nbsd-nat.c: Revert.
5932         * amd64-nat.c: Revert.
5933         * amd64-linux-tdep.c: Revert.
5934         * amd64-linux-nat.c: Revert.
5935         * amd64-fbsd-tdep.c: Revert.
5936         * amd64-fbsd-nat.c: Revert.
5937         * amd64-dicos-tdep.c: Revert.
5938         * amd64-darwin-tdep.c: Revert.
5939         * amd64-bsd-nat.c: Revert.
5940         * alpha-tdep.c: Revert.
5941         * alpha-obsd-tdep.c: Revert.
5942         * alpha-nbsd-tdep.c: Revert.
5943         * alpha-mdebug-tdep.c: Revert.
5944         * alpha-linux-tdep.c: Revert.
5945         * alpha-linux-nat.c: Revert.
5946         * alpha-bsd-tdep.c: Revert.
5947         * alpha-bsd-nat.c: Revert.
5948         * aix-thread.c: Revert.
5949         * agent.c: Revert.
5950         * addrmap.c: Revert.
5951         * ada-varobj.c: Revert.
5952         * ada-valprint.c: Revert.
5953         * ada-typeprint.c: Revert.
5954         * ada-tasks.c: Revert.
5955         * ada-lang.c: Revert.
5956         * aarch64-tdep.c: Revert.
5957         * aarch64-ravenscar-thread.c: Revert.
5958         * aarch64-newlib-tdep.c: Revert.
5959         * aarch64-linux-tdep.c: Revert.
5960         * aarch64-linux-nat.c: Revert.
5961         * aarch64-fbsd-tdep.c: Revert.
5962         * aarch64-fbsd-nat.c: Revert.
5963         * aarch32-linux-nat.c: Revert.
5964
5965 2019-04-05  Tom Tromey  <tom@tromey.com>
5966
5967         * ft32-tdep.c: Sort headers.
5968         * frv-tdep.c: Sort headers.
5969         * frv-linux-tdep.c: Sort headers.
5970         * frame.c: Sort headers.
5971         * frame-unwind.c: Sort headers.
5972         * frame-base.c: Sort headers.
5973         * fork-child.c: Sort headers.
5974         * findvar.c: Sort headers.
5975         * findcmd.c: Sort headers.
5976         * filesystem.c: Sort headers.
5977         * filename-seen-cache.h: Sort headers.
5978         * filename-seen-cache.c: Sort headers.
5979         * fbsd-tdep.c: Sort headers.
5980         * fbsd-nat.h: Sort headers.
5981         * fbsd-nat.c: Sort headers.
5982         * f-valprint.c: Sort headers.
5983         * f-typeprint.c: Sort headers.
5984         * f-lang.c: Sort headers.
5985         * extension.h: Sort headers.
5986         * extension.c: Sort headers.
5987         * extension-priv.h: Sort headers.
5988         * expprint.c: Sort headers.
5989         * exec.h: Sort headers.
5990         * exec.c: Sort headers.
5991         * exceptions.c: Sort headers.
5992         * event-top.c: Sort headers.
5993         * event-loop.c: Sort headers.
5994         * eval.c: Sort headers.
5995         * elfread.c: Sort headers.
5996         * dwarf2read.h: Sort headers.
5997         * dwarf2read.c: Sort headers.
5998         * dwarf2loc.c: Sort headers.
5999         * dwarf2expr.h: Sort headers.
6000         * dwarf2expr.c: Sort headers.
6001         * dwarf2-frame.c: Sort headers.
6002         * dwarf2-frame-tailcall.c: Sort headers.
6003         * dwarf-index-write.h: Sort headers.
6004         * dwarf-index-write.c: Sort headers.
6005         * dwarf-index-common.c: Sort headers.
6006         * dwarf-index-cache.h: Sort headers.
6007         * dwarf-index-cache.c: Sort headers.
6008         * dummy-frame.c: Sort headers.
6009         * dtrace-probe.c: Sort headers.
6010         * disasm.h: Sort headers.
6011         * disasm.c: Sort headers.
6012         * disasm-selftests.c: Sort headers.
6013         * dictionary.c: Sort headers.
6014         * dicos-tdep.c: Sort headers.
6015         * demangle.c: Sort headers.
6016         * dcache.h: Sort headers.
6017         * dcache.c: Sort headers.
6018         * darwin-nat.h: Sort headers.
6019         * darwin-nat.c: Sort headers.
6020         * darwin-nat-info.c: Sort headers.
6021         * d-valprint.c: Sort headers.
6022         * d-namespace.c: Sort headers.
6023         * d-lang.c: Sort headers.
6024         * ctf.c: Sort headers.
6025         * csky-tdep.c: Sort headers.
6026         * csky-linux-tdep.c: Sort headers.
6027         * cris-tdep.c: Sort headers.
6028         * cris-linux-tdep.c: Sort headers.
6029         * cp-valprint.c: Sort headers.
6030         * cp-support.c: Sort headers.
6031         * cp-namespace.c: Sort headers.
6032         * cp-abi.c: Sort headers.
6033         * corelow.c: Sort headers.
6034         * corefile.c: Sort headers.
6035         * continuations.c: Sort headers.
6036         * completer.h: Sort headers.
6037         * completer.c: Sort headers.
6038         * complaints.c: Sort headers.
6039         * coffread.c: Sort headers.
6040         * coff-pe-read.c: Sort headers.
6041         * cli-out.h: Sort headers.
6042         * cli-out.c: Sort headers.
6043         * charset.c: Sort headers.
6044         * c-varobj.c: Sort headers.
6045         * c-valprint.c: Sort headers.
6046         * c-typeprint.c: Sort headers.
6047         * c-lang.c: Sort headers.
6048         * buildsym.c: Sort headers.
6049         * buildsym-legacy.c: Sort headers.
6050         * build-id.h: Sort headers.
6051         * build-id.c: Sort headers.
6052         * btrace.c: Sort headers.
6053         * bsd-uthread.c: Sort headers.
6054         * breakpoint.h: Sort headers.
6055         * breakpoint.c: Sort headers.
6056         * break-catch-throw.c: Sort headers.
6057         * break-catch-syscall.c: Sort headers.
6058         * break-catch-sig.c: Sort headers.
6059         * blockframe.c: Sort headers.
6060         * block.c: Sort headers.
6061         * bfin-tdep.c: Sort headers.
6062         * bfin-linux-tdep.c: Sort headers.
6063         * bfd-target.c: Sort headers.
6064         * bcache.c: Sort headers.
6065         * ax-general.c: Sort headers.
6066         * ax-gdb.h: Sort headers.
6067         * ax-gdb.c: Sort headers.
6068         * avr-tdep.c: Sort headers.
6069         * auxv.c: Sort headers.
6070         * auto-load.c: Sort headers.
6071         * arm-wince-tdep.c: Sort headers.
6072         * arm-tdep.c: Sort headers.
6073         * arm-symbian-tdep.c: Sort headers.
6074         * arm-pikeos-tdep.c: Sort headers.
6075         * arm-obsd-tdep.c: Sort headers.
6076         * arm-nbsd-tdep.c: Sort headers.
6077         * arm-nbsd-nat.c: Sort headers.
6078         * arm-linux-tdep.c: Sort headers.
6079         * arm-linux-nat.c: Sort headers.
6080         * arm-fbsd-tdep.c: Sort headers.
6081         * arm-fbsd-nat.c: Sort headers.
6082         * arm-bsd-tdep.c: Sort headers.
6083         * arch-utils.c: Sort headers.
6084         * arc-tdep.c: Sort headers.
6085         * arc-newlib-tdep.c: Sort headers.
6086         * annotate.h: Sort headers.
6087         * annotate.c: Sort headers.
6088         * amd64-windows-tdep.c: Sort headers.
6089         * amd64-windows-nat.c: Sort headers.
6090         * amd64-tdep.c: Sort headers.
6091         * amd64-sol2-tdep.c: Sort headers.
6092         * amd64-obsd-tdep.c: Sort headers.
6093         * amd64-obsd-nat.c: Sort headers.
6094         * amd64-nbsd-tdep.c: Sort headers.
6095         * amd64-nbsd-nat.c: Sort headers.
6096         * amd64-nat.c: Sort headers.
6097         * amd64-linux-tdep.c: Sort headers.
6098         * amd64-linux-nat.c: Sort headers.
6099         * amd64-fbsd-tdep.c: Sort headers.
6100         * amd64-fbsd-nat.c: Sort headers.
6101         * amd64-dicos-tdep.c: Sort headers.
6102         * amd64-darwin-tdep.c: Sort headers.
6103         * amd64-bsd-nat.c: Sort headers.
6104         * alpha-tdep.c: Sort headers.
6105         * alpha-obsd-tdep.c: Sort headers.
6106         * alpha-nbsd-tdep.c: Sort headers.
6107         * alpha-mdebug-tdep.c: Sort headers.
6108         * alpha-linux-tdep.c: Sort headers.
6109         * alpha-linux-nat.c: Sort headers.
6110         * alpha-bsd-tdep.c: Sort headers.
6111         * alpha-bsd-nat.c: Sort headers.
6112         * aix-thread.c: Sort headers.
6113         * agent.c: Sort headers.
6114         * addrmap.c: Sort headers.
6115         * ada-varobj.c: Sort headers.
6116         * ada-valprint.c: Sort headers.
6117         * ada-typeprint.c: Sort headers.
6118         * ada-tasks.c: Sort headers.
6119         * ada-lang.c: Sort headers.
6120         * aarch64-tdep.c: Sort headers.
6121         * aarch64-ravenscar-thread.c: Sort headers.
6122         * aarch64-newlib-tdep.c: Sort headers.
6123         * aarch64-linux-tdep.c: Sort headers.
6124         * aarch64-linux-nat.c: Sort headers.
6125         * aarch64-fbsd-tdep.c: Sort headers.
6126         * aarch64-fbsd-nat.c: Sort headers.
6127         * aarch32-linux-nat.c: Sort headers.
6128
6129 2019-04-04  Tom Tromey  <tom@tromey.com>
6130
6131         * varobj.c (varobj_create): Update.
6132         * rust-exp.y (struct rust_parser) <update_innermost_block,
6133         lookup_symbol>: New methods.
6134         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6135         Rename.
6136         (rust_parser::rust_lookup_type)
6137         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6138         * printcmd.c (display_command, do_one_display): Update.
6139         * parser-defs.h (struct parser_state) <parser_state>: Add
6140         "tracker" parameter.
6141         (block_tracker): New member.
6142         (class innermost_block_tracker) <innermost_block_tracker>: Add
6143         "types" parameter.
6144         <reset>: Remove method.
6145         (innermost_block): Don't declare.
6146         (null_post_parser): Update.
6147         * parse.c (innermost_block): Remove global.
6148         (write_dollar_variable): Update.
6149         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6150         Remove "tracker_types" parameter.
6151         (parse_expression): Add "tracker" parameter.
6152         (parse_expression_for_completion): Update.
6153         (null_post_parser): Add "tracker" parameter.
6154         * p-exp.y: Update rules.
6155         * m2-exp.y: Update rules.
6156         * language.h (struct language_defn) <la_post_parser>: Add
6157         "tracker" parameter.
6158         * go-exp.y: Update rules.
6159         * f-exp.y: Update rules.
6160         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6161         parameter.
6162         * d-exp.y: Update rules.
6163         * c-exp.y: Update rules.
6164         * breakpoint.c (set_breakpoint_condition): Create an
6165         innermost_block_tracker.
6166         (watch_command_1): Likewise.
6167         * ada-lang.c (resolve): Add "tracker" parameter.
6168         (resolve_subexp): Likewise.
6169         * ada-exp.y (write_var_from_sym): Update.
6170
6171 2019-04-04  Tom Tromey  <tom@tromey.com>
6172
6173         * type-stack.h: New file.
6174         * type-stack.c: New file.
6175         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6176         type-stack.h.
6177         (insert_into_type_stack, insert_type, push_type, push_type_int)
6178         (insert_type_address_space, pop_type, pop_type_int)
6179         (pop_typelist, pop_type_stack, append_type_stack)
6180         (push_type_stack, get_type_stack, push_typelist)
6181         (follow_type_instance_flags, follow_types): Don't declare.
6182         * parse.c (type_stack): Remove global.
6183         (parse_exp_in_context): Update.
6184         (insert_into_type_stack, insert_type, push_type, push_type_int)
6185         (insert_type_address_space, pop_type, pop_type_int)
6186         (pop_typelist, pop_type_stack, append_type_stack)
6187         (push_type_stack, get_type_stack, push_typelist)
6188         (follow_type_instance_flags, follow_types): Remove (moved to
6189         type-stack.c).
6190         * f-exp.y (type_stack): New global.
6191         Update rules.
6192         (push_kind_type, f_parse): Update.
6193         * d-exp.y (type_stack): New global.
6194         Update rules.
6195         (d_parse): Update.
6196         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6197         Update rules.
6198         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6199         (HFILES_NO_SRCDIR): Add type-stack.h.
6200
6201 2019-04-04  Tom Tromey  <tom@tromey.com>
6202
6203         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6204         (rust_parser::convert_ast_to_expression, rust_parse)
6205         (rust_lex_test_completion, rust_lex_tests): Update.
6206         * parser-defs.h (struct expr_completion_state): New.
6207         (struct parser_state) <parser_state>: Add completion parameter.
6208         <mark_struct_expression, mark_completion_tag>: New methods.
6209         <parse_completion, m_completion_state>: New members.
6210         (prefixify_expression, null_post_parser): Update.
6211         (mark_struct_expression, mark_completion_tag): Don't declare.
6212         * parse.c (parse_completion, expout_last_struct)
6213         (expout_tag_completion_type, expout_completion_name): Remove
6214         globals.
6215         (parser_state::mark_struct_expression)
6216         (parser_state::mark_completion_tag): Now methods.
6217         (prefixify_expression): Add last_struct parameter.
6218         (prefixify_subexp): Likewise.
6219         (parse_exp_1): Update.
6220         (parse_exp_in_context): Add cstate parameter.  Update.
6221         (parse_expression_for_completion): Create an
6222         expr_completion_state.
6223         (null_post_parser): Add "completion" parameter.
6224         * p-exp.y: Update rules.
6225         (yylex): Update.
6226         * language.h (struct language_defn) <la_post_parser>: Add
6227         "completing" parameter.
6228         * go-exp.y: Update rules.
6229         (lex_one_token): Update.
6230         * expression.h (parse_completion): Don't declare.
6231         * d-exp.y: Update rules.
6232         (lex_one_token): Update rules.
6233         * c-exp.y: Update rules.
6234         (lex_one_token): Update.
6235         * ada-lang.c (resolve): Add "parse_completion" parameter.
6236         (resolve_subexp): Likewise.
6237         (ada_resolve_function): Likewise.
6238
6239 2019-04-04  Tom Tromey  <tom@tromey.com>
6240
6241         * parser-defs.h (struct parser_state) <start_arglist,
6242         end_arglist>: New methods.
6243         <arglist_len, m_funcall_chain>: New members.
6244         (arglist_len, start_arglist, end_arglist): Don't declare.
6245         * parse.c (arglist_len, funcall_chain): Remove global.
6246         (start_arglist, end_arglist): Remove functions.
6247         (parse_exp_in_context): Update.
6248         * p-exp.y: Update rules.
6249         * m2-exp.y: Update rules.
6250         * go-exp.y: Update rules.
6251         * f-exp.y: Update rules.
6252         * d-exp.y: Update rules.
6253         * c-exp.y: Update rules.
6254
6255 2019-04-04  Tom Tromey  <tom@tromey.com>
6256
6257         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6258         lex_operator, push_back>: New methods.
6259         Update all rules.
6260         (rust_parser::lex_hex, lex_escape): Rename and update.
6261         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6262         (rust_parser::lex_operator): Rename and update.
6263         (rust_parser::lex_number, rustyylex, rustyyerror)
6264         (rust_lex_test_init, rust_lex_test_sequence)
6265         (rust_lex_test_push_back, rust_lex_tests): Update.
6266         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6267         parameter.
6268         <lexptr, prev_lexptr>: New members.
6269         (lexptr, prev_lexptr): Don't declare.
6270         * parse.c (lexptr, prev_lexptr): Remove globals.
6271         (parse_exp_in_context): Update.
6272         * p-exp.y (yylex, yyerror): Update.
6273         * m2-exp.y (parse_number, yylex, yyerror): Update.
6274         * go-exp.y (lex_one_token, yyerror): Update.
6275         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6276         * d-exp.y (lex_one_token, yyerror): Update.
6277         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6278         (lex_one_token, yyerror): Update.
6279         * ada-lex.l (YY_INPUT): Update.
6280         (rewind_to_char): Update.
6281         * ada-exp.y (yyerror): Update.
6282
6283 2019-04-04  Tom Tromey  <tom@tromey.com>
6284
6285         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6286         * parser-defs.h (struct parser_state) <parser_state>: Add new
6287         parameter.
6288         <comma_terminates>: New member.
6289         (comma_terminates): Don't declare global.
6290         * parse.c (comma_terminates): Remove global.
6291         (parse_exp_in_context): Update.
6292         * p-exp.y (yylex): Update.
6293         * m2-exp.y (yylex): Update.
6294         * go-exp.y (lex_one_token): Update.
6295         * f-exp.y (yylex): Update.
6296         * d-exp.y (lex_one_token): Update.
6297         * c-exp.y (lex_one_token): Update.
6298         * ada-lex.l: Update.
6299
6300 2019-04-04  Tom Tromey  <tom@tromey.com>
6301
6302         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6303         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6304         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6305         * parser-defs.h (paren_depth): Don't declare.
6306         * parse.c (paren_depth): Remove global.
6307         (parse_exp_in_context): Update.
6308         * p-exp.y (paren_depth): New global.
6309         (pascal_parse): Initialize it.
6310         * m2-exp.y (paren_depth): New global.
6311         (m2_parse): Initialize it.
6312         * go-exp.y (paren_depth): New global.
6313         (go_parse): Initialize it.
6314         * f-exp.y (paren_depth): New global.
6315         (f_parse): Initialize it.
6316         * d-exp.y (paren_depth): New global.
6317         (d_parse): Initialize it.
6318         * c-exp.y (paren_depth): New global.
6319         (c_parse): Initialize it.
6320         * ada-lex.l (paren_depth): New global.
6321         (lexer_init): Initialize it.
6322
6323 2019-04-04  Tom Tromey  <tom@tromey.com>
6324
6325         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6326         (rust_parser::convert_ast_to_type)
6327         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6328         * parser-defs.h (struct parser_state) <parser_state>: Add
6329         parameters.  Initialize new members.
6330         <expression_context_block, expression_context_pc>: New members.
6331         * parse.c (expression_context_block, expression_context_pc):
6332         Remove globals.
6333         (parse_exp_in_context): Update.
6334         * p-exp.y: Update all rules.
6335         (yylex): Update.
6336         * m2-exp.y: Update all rules.
6337         (yylex): Update.
6338         * go-exp.y (yylex): Update.
6339         * f-exp.y (yylex): Update.
6340         * d-exp.y: Update all rules.
6341         (yylex): Update.
6342         * c-exp.y: Update all rules.
6343         (lex_one_token, classify_name, yylex, c_parse): Update.
6344         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6345
6346 2019-04-04  Tom Tromey  <tom@tromey.com>
6347
6348         * gdbarch.h, gdbarch.c: Rebuild.
6349         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6350         * stap-probe.h:
6351         (struct stap_parse_info): Replace "parser_state" with
6352         "expr_builder".
6353         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6354         (parser_state): New class.
6355         * parse.c (expr_builder): Rename.
6356         (expr_builder::release): Rename.
6357         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6358         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6359         (write_exp_elt_longcst, write_exp_elt_floatcst)
6360         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6361         (write_exp_string_vector, write_exp_bitstring)
6362         (write_exp_msymbol, mark_struct_expression)
6363         (write_dollar_variable)
6364         (insert_type_address_space, increase_expout_size): Replace
6365         "parser_state" with "expr_builder".
6366         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6367         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6368         "parser_state" with "expr_builder".
6369
6370 2019-04-04  Tom Tromey  <tom@tromey.com>
6371
6372         * rust-exp.y: Replace "parse_language" with method call.
6373         * p-exp.y:
6374         (yylex): Replace "parse_language" with method call.
6375         * m2-exp.y:
6376         (yylex): Replace "parse_language" with method call.
6377         * go-exp.y (classify_name): Replace "parse_language" with method
6378         call.
6379         * f-exp.y (yylex): Replace "parse_language" with method call.
6380         * d-exp.y (lex_one_token): Replace "parse_language" with method
6381         call.
6382         * c-exp.y:
6383         (lex_one_token, classify_name, yylex): Replace "parse_language"
6384         with method call.
6385         * ada-exp.y (find_primitive_type, type_char)
6386         (type_system_address): Replace "parse_language" with method call.
6387
6388 2019-04-04  Tom Tromey  <tom@tromey.com>
6389
6390         * rust-exp.y: Replace "parse_gdbarch" with method call.
6391         * parse.c (write_dollar_variable, insert_type_address_space):
6392         Replace "parse_gdbarch" with method call.
6393         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6394         call.
6395         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6396         call.
6397         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6398         "parse_gdbarch" with method call.
6399         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6400         with method call.
6401         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6402         "parse_gdbarch" with method call.
6403         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6404         "parse_gdbarch" with method call.
6405         * c-exp.y (parse_type, parse_number, classify_name): Replace
6406         "parse_gdbarch" with method call.
6407         * ada-lex.l: Replace "parse_gdbarch" with method call.
6408         * ada-exp.y (parse_type, find_primitive_type, type_char)
6409         (type_system_address): Replace "parse_gdbarch" with method call.
6410
6411 2019-04-04  Tom Tromey  <tom@tromey.com>
6412
6413         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6414         * stap-probe.c (stap_parse_argument): Update.
6415         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6416         initial_size parameter.
6417         * rust-exp.y (rust_lex_tests): Update.
6418         * parse.c (parser_state): Update.
6419         (parse_exp_in_context): Update.
6420         * parser-defs.h (struct parser_state) <parser_state>: Remove
6421         "initial_size" parameter.
6422
6423 2019-04-04  Tom Tromey  <tom@tromey.com>
6424
6425         * parser-defs.h (increase_expout_size): Don't declare.
6426         * parse.c (increase_expout_size): Now static.
6427
6428 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6429
6430         * gnu-nat.c (gnu_nat_target::wait): Fix
6431         target_waitstatus_to_string call.
6432
6433 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6434
6435         * eval.c (evaluate_subexp_standard): Handle internal functions
6436         during Fortran function call handling.
6437
6438 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6439
6440         * NEWS: Mention new internal functions.
6441         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6442         (read_base_type): Use dwarf2_init_complex_target_type.
6443         * value.c (creal_internal_fn): New function.
6444         (cimag_internal_fn): New function.
6445         (_initialize_values): Register new internal functions.
6446
6447 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6448
6449         * infrun.c (stop_all_threads): If debug_infrun, always
6450         trace the wait status after wait_one, using
6451         target_waitstatus_to_string and target_pid_to_str.
6452         (handle_inferior_event): Replace various trace of
6453         wait status kind by a single trace.
6454         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6455         wait status kind image by target_waitstatus_to_string.
6456         * target/waitstatus.c (target_waitstatus_to_string): Fix
6457         obsolete comment.
6458
6459 2019-04-01  Tom Tromey  <tromey@adacore.com>
6460
6461         PR symtab/23331:
6462         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6463
6464 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6465             Pedro Alves  <palves@redhat.com>
6466
6467         * top.c (quit_force): Call 'finalize_values'.
6468         * value.c (finalize_values): New function.
6469         * value.h (finalize_values): Declare.
6470
6471 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6472
6473         * NEWS: Announce $_gdb_major and $_gdb_minor.
6474
6475         * top.c (init_gdb_version_vars): New function.
6476         (gdb_init): Call init_gdb_version_vars.
6477
6478 2019-03-29  Tom Tromey  <tromey@adacore.com>
6479
6480         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6481         help text.  Remove dead code.
6482
6483 2019-03-29  Keith Seitz  <keiths@redhat.com>
6484
6485         From Siddhesh Poyarekar:
6486         * f-lang.h (f77_get_upperbound): Return LONGEST.
6487         (f77_get_lowerbound): Likewise.
6488         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6489         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6490         print them.
6491         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6492         plongest to format print it.
6493         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6494         (f77_get_upperbound): Likewise.
6495         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6496         LOWER_BOUND to LONGEST.
6497         (f77_create_arrayprint_offset_tbl): Likewise.
6498
6499 2019-03-29  Keith Seitz  <keiths@redhat.com>
6500
6501         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6502         %s/pulongest for TYPE_LENGTH instead of %d in format
6503         strings.
6504         * ada-typerint.c (ada_print_type): Likewise.
6505         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6506         * compile/compile-c-support.c (generate_register_struct): Likewise.
6507         * gdbtypes.c (recursive_dump_type): Likewise.
6508         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6509         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6510         instead of %d in format strings.
6511         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6512         to std::min to ULONGEST.
6513         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6514         instead of %d in format strings.
6515         * tracepoint.c (info_scope_command): Likewise.
6516         * typeprint.c (print_offset_data::update)
6517         (print_offset_data::finish): Likewise.
6518         * xtensa-tdep.c (xtensa_store_return_value)
6519         (xtensa_push_dummy_call): Likewise.
6520
6521 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6522
6523         * windows-nat.c (display_selector): Fixed format specifications
6524         for 64-bit Cygwin.
6525
6526 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6527
6528         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6529
6530 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6531
6532         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6533         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6534         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6535         (nios2_linux_init_abi): Install it.
6536
6537 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6538
6539         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6540
6541 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6542
6543         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6544
6545 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6546             Tom Tromey  <tromey@adacore.com>
6547
6548         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6549
6550 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6551
6552         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6553         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6554         method to compute the bounds of range types. Also print "[evaluated]"
6555         if the bounds' values come from a dynamic evaluation.
6556
6557 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6558
6559         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6560         whitespace when pretty printing is on.
6561
6562 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6563
6564         * ppc-linux-nat.c: Add include.
6565
6566 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6567
6568         * NEWS: Mention AArch64 Pointer Authentication.
6569
6570 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6571
6572         * arm-linux-nat.c: Add include.
6573
6574 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6575
6576         * source-cache.c (source_cache::get_source_lines): Re-read
6577         fullname after calling open_source_file.
6578
6579 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6580
6581         * NEWS: Mention TLS support for FreeBSD.
6582
6583 2019-03-25  Tom Tromey  <tromey@adacore.com>
6584
6585         * minsyms.c (BUNCH_SIZE): Update comment.
6586         (~minimal_symbol_reader): Remove old comment.
6587         (compact_minimal_symbols): Update comment.
6588         (minimal_symbol_reader::install): Remove old comment.  Update
6589         other comments.
6590
6591 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6592
6593         * s390-linux-nat.c: Add include.
6594
6595 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6596
6597         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6598         Call linux_get_hwcap.
6599         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6600         Likewise.
6601         (aarch64_linux_get_hwcap): Remove function.
6602         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6603         declaration.
6604         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6605         linux_get_hwcap.
6606         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6607         * linux-tdep.c (linux_get_hwcap): Add function.
6608         (linux_get_hwcap2): Likewise.
6609         * linux-tdep.h (linux_get_hwcap): Add declaration.
6610         (linux_get_hwcap2): Likewise.
6611         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6612         (ppc_linux_get_hwcap2): Likewise.
6613         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6614         linux_get_hwcap.
6615         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6616         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6617         (ppc_linux_nat_target::read_description): Likewise.
6618         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6619         * s390-linux-nat.c: Likewise.
6620         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6621
6622 2019-03-24  Tom Tromey  <tom@tromey.com>
6623
6624         * ada-lang.c (standard_lookup): Simplify initialization.
6625         (ada_lookup_symbol_nonlocal): Simplify return.
6626         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6627         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6628         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6629         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6630         initialization.
6631         * solib.c (solib_global_lookup): Simplify.
6632         * symtab.c (null_block_symbol): Remove.
6633         (symbol_cache_lookup): Simplify returns.
6634         (lookup_language_this): Simplify returns.
6635         (lookup_symbol_aux): Simplify return.
6636         (lookup_local_symbol): Simplify returns.
6637         (lookup_global_symbol_from_objfile): Simplify return.
6638         (lookup_symbol_in_objfile_symtabs)
6639         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6640         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6641         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6642         * cp-namespace.c (cp_lookup_bare_symbol)
6643         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6644         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6645         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6646         (cp_lookup_symbol_via_imports): Simplify initialization.
6647         (find_symbol_in_baseclass): Likewise.
6648         * symtab.h (null_block_symbol): Remove.
6649         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6650         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6651         (d_lookup_symbol_module): Likewise.
6652         (find_symbol_in_baseclass): Simplify initialization.
6653
6654 2019-03-24  Tom Tromey  <tom@tromey.com>
6655
6656         * expression.h: Don't include symtab.h.
6657         (struct block): Forward declare.
6658
6659 2019-03-24  Tom Tromey  <tom@tromey.com>
6660
6661         * c-exp.y (typebase): Remove casts.
6662         * gdbtypes.c (lookup_unsigned_typename, )
6663         (lookup_signed_typename): Remove cast.
6664         * eval.c (parse_to_comma_and_eval): Remove cast.
6665         * parse.c (write_dollar_variable): Remove cast.
6666         * block.h (struct block) <superblock>: Now const.
6667         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6668         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6669         (map_block): Make "block" const.
6670         * symfile.h (struct quick_symbol_functions)
6671         <map_matching_symbols>: Constify block argument to "callback".
6672         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6673         const.
6674         (find_pc_sect_compunit_symtab): Make "b" const.
6675         (find_symbol_at_address): Likewise.
6676         (search_symbols): Likewise.
6677         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6678         (dw2_debug_names_lookup_symbol): Likewise.
6679         (dw2_map_matching_symbols): Update.
6680         * p-valprint.c (pascal_val_print): Remove "block".
6681         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6682         (aux_add_nonlocal_symbols): Make "block" const.
6683         (resolve_subexp): Remove cast.
6684         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6685         const.
6686         (iterate_over_file_blocks): Likewise.
6687         * f-exp.y (%union) <bval>: Remove.
6688         * coffread.c (patch_opaque_types): Make "b" const.
6689         * spu-tdep.c (spu_catch_start): Make "block" const.
6690         * c-valprint.c (print_unpacked_pointer): Remove "block".
6691         * symmisc.c (dump_symtab_1): Make "b" const.
6692         (block_depth): Make "block" const.
6693         * d-exp.y (%union) <bval>: Remove.
6694         * cp-support.h (cp_lookup_rtti_type): Update.
6695         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6696         * psymtab.c (psym_lookup_symbol): Make "block" const.
6697         (maintenance_check_psymtabs): Make "b" const.
6698         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6699         (enumerate_locals, enumerate_args): Update.
6700         * python/py-symtab.c (stpy_global_block): Make "block" const.
6701         (stpy_static_block): Likewise.
6702         * inline-frame.c (block_starting_point_at): Make "new_block"
6703         const.
6704         * block.c (find_block_in_blockvector): Make return type const.
6705         (blockvector_for_pc_sect): Make "b" const.
6706         (find_block_in_blockvector): Make "b" const.
6707
6708 2019-03-23  Tom Tromey  <tom@tromey.com>
6709
6710         * varobj.c (varobj_create): Update.
6711         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6712         * printcmd.c (display_command, do_one_display): Don't reset
6713         innermost_block.
6714         * parser-defs.h (enum innermost_block_tracker_type): Move to
6715         expression.h.
6716         (innermost_block): Update comment.
6717         * parse.c (parse_exp_1): Add tracker_types parameter.
6718         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6719         tracker_types parameter.  Reset innermost_block.
6720         (parse_exp_in_context): Remove.
6721         (parse_expression_for_completion): Update.
6722         * objfiles.c (~objfile): Don't reset expression_context_block or
6723         innermost_block.
6724         * expression.h (enum innermost_block_tracker_type): Move from
6725         parser-defs.h.
6726         (parse_exp_1): Add tracker_types parameter.
6727         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6728         reset innermost_block.
6729
6730 2019-03-23  Tom Tromey  <tom@tromey.com>
6731
6732         * objfiles.h: Include bcache.h.
6733
6734 2019-03-23  Tom Tromey  <tom@tromey.com>
6735
6736         * linespec.c (get_current_search_block): Use
6737         scoped_restore_current_language.
6738         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6739
6740 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6741             Jiong Wang  <jiong.wang@arm.com>
6742
6743         * aarch64-linux-tdep.c
6744         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6745         section.
6746         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6747
6748 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6749             Jiong Wang  <jiong.wang@arm.com>
6750
6751         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6752         instructions.
6753         (aarch64_analyze_prologue_test): Add PACIASP test.
6754         (aarch64_prologue_prev_register): Unmask PC value.
6755
6756 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6757             Jiong Wang  <jiong.wang@arm.com>
6758
6759         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6760         (aarch64_dwarf2_prev_register): Unmask PC value.
6761         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6762         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6763         DW_CFA_AARCH64_negate_ra_state.
6764         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6765
6766 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6767             Jiong Wang  <jiong.wang@arm.com>
6768
6769         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6770         registers.
6771         (aarch64_pseudo_register_name): Likewise.
6772         (aarch64_pseudo_register_type): Likewise.
6773         (aarch64_pseudo_register_reggroup_p): Likewise.
6774         (aarch64_gdbarch_init): Add pauth registers.
6775         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6776         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6777         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6778         (struct gdbarch_tdep): Add regnum for ra_state.
6779
6780 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6781             Jiong Wang  <jiong.wang@arm.com>
6782
6783         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6784
6785 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6786             Jiong Wang  <jiong.wang@arm.com>
6787
6788         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6789         function.
6790         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6791         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6792         (aarch64_gdbarch_init): Add puth registers.
6793         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6794         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6795         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6796
6797 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6798             Jiong Wang  <jiong.wang@arm.com>
6799
6800         * aarch64-linux-nat.c
6801         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6802         * aarch64-linux-tdep.c
6803         (aarch64_linux_core_read_description): Likewise.
6804         (aarch64_linux_get_hwcap): New function.
6805         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6806         (aarch64_linux_get_hwcap): New declaration.
6807
6808 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6809             Jiong Wang  <jiong.wang@arm.com>
6810
6811         * aarch64-linux-nat.c
6812         (aarch64_linux_nat_target::read_description): Add pauth param.
6813         * aarch64-linux-tdep.c
6814         (aarch64_linux_core_read_description): Likewise.
6815         * aarch64-tdep.c (struct target_desc): Add in pauth.
6816         (aarch64_read_description): Add pauth param.
6817         (aarch64_gdbarch_init): Likewise.
6818         * aarch64-tdep.h (aarch64_read_description): Likewise.
6819         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6820         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6821         * features/Makefile: Add new files.
6822         * features/aarch64-pauth.c: New file.
6823         * features/aarch64-pauth.xml: New file.
6824
6825 2019-03-20  Tom Tromey  <tromey@adacore.com>
6826
6827         * infrun.c (handle_inferior_event): Rename from
6828         handle_inferior_event_1.  Create a scoped_value_mark.
6829         (handle_inferior_event): Remove.
6830
6831 2019-03-19  Tom Tromey  <tromey@adacore.com>
6832
6833         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6834         * infrun.h (print_stop_event): Add "displays" parameter.
6835         * infrun.c (print_stop_event): Add "displays" parameter.
6836
6837 2019-03-19  Pedro Alves  <palves@redhat.com>
6838
6839         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6840         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6841         to -1.  Fix TABs vs spaces.
6842         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6843         * tui/tui-out.h (tui_ui_out) Add intro comments.
6844         <m_line, m_start_of_line>: In-class initialize, and add describing
6845         comment.
6846
6847 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6848
6849         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6850         variable names.
6851         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6852
6853 2019-03-18  Pedro Alves  <palves@redhat.com>
6854             Eli Zaretskii <eliz@gnu.org>
6855
6856         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6857         m_line and m_start_of_line.
6858
6859 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6860
6861         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6862         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6863         it returns a newline.  This fixes a regression in TU mode, whereby
6864         the next line is output on the same screen line as the user input.
6865
6866 2019-03-18  Tom Tromey  <tromey@adacore.com>
6867
6868         * minsyms.c (minimal_symbol_reader::install): Remove call to
6869         obstack_blank.
6870
6871 2019-03-18  Pedro Alves  <palves@redhat.com>
6872
6873         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6874         New globals.
6875         (apply_style): New, factored out from ...
6876         (apply_ansi_escape): ... this.  Handle reverse video mode.
6877         (tui_set_reverse_mode): New function.
6878         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6879         * tui/tui-winsource.c (tui_show_source_line): Use
6880         tui_set_reverse_mode instead of setting A_STANDOUT.
6881         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6882         New setter methods.
6883
6884 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6885
6886         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6887         Handle tabs.
6888
6889 2019-03-18  Tom Tromey  <tromey@adacore.com>
6890
6891         * ada-lang.c (empty_array): Add "high" parameter.
6892         (ada_evaluate_subexp): Update.
6893
6894 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6895
6896         * unittests/string_view-selftests.c: Define
6897         _initialize_string_view_selftests unconditionally.
6898
6899 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6900
6901         PR gdb/24350
6902         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6903
6904 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6905
6906         PR gdb/24351
6907         * windows-nat.c (display_selector): Fix format specifiers.
6908
6909 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6910
6911         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6912         tui_refill_source_window instead of tui_refresh_win, to update the
6913         current execution line.  This fixes redisplay of the current line
6914         when stepping through the code with "next" or "step".
6915
6916 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6917
6918         * source-cache.c (source_cache::get_source_lines): Call
6919         find_source_lines to initialize s->nlines.  This fixes vertical
6920         scrolling of TUI source window when the DOWN arrow is pressed.
6921
6922 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6923
6924         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6925         linux-thread-db.c (_initialize_thread_db): Likewise.
6926
6927 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6928
6929         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6930         wclrtoeol in tui_show_source_line".  This reverts changes made in
6931         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6932
6933 2019-03-15  Tom Tromey  <tom@tromey.com>
6934
6935         * symtab.h (struct minimal_symbol): Derive from
6936         general_symbol_info.
6937         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6938         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6939         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6940         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6941         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6942         (MSYMBOL_SEARCH_NAME): Update.
6943         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6944         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6945         * minsyms.c (minimal_symbol_reader::record_full): Update.
6946
6947 2019-03-15  Tom Tromey  <tom@tromey.com>
6948
6949         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6950
6951 2019-03-15  Tom Tromey  <tom@tromey.com>
6952
6953         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6954         unique_xmalloc_ptr.
6955         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6956         Update.
6957         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6958         (build_minimal_symbol_hash_tables)
6959         (minimal_symbol_reader::install): Update.
6960
6961 2019-03-15  Tom Tromey  <tom@tromey.com>
6962
6963         * symtab.c (create_demangled_names_hash): Update.
6964         (symbol_set_names): Update.
6965         * objfiles.h (struct objfile_per_bfd_storage)
6966         <demangled_names_hash>: Now an htab_up.
6967         * objfiles.c (objfile_per_bfd_storage): Simplify.
6968
6969 2019-03-15  Tom Tromey  <tom@tromey.com>
6970
6971         * objfiles.h (struct objfile_per_bfd_storage): Declare
6972         destructor.
6973         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6974         New.
6975         (get_objfile_bfd_data): Use new.  Don't initialize
6976         language_of_main.
6977         (free_objfile_per_bfd_storage): Remove.
6978         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6979
6980 2019-03-15  Tom Tromey  <tom@tromey.com>
6981
6982         * symfile.c (reread_symbols): Update.
6983         * objfiles.c (objfile::objfile): Update.
6984         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6985         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6986         comment.
6987         (minimal_symbol_reader::install): Update.
6988         (terminate_minimal_symbol_table): Remove.
6989         * jit.c (jit_object_close_impl): Update.
6990
6991 2019-03-15  Tom Tromey  <tom@tromey.com>
6992
6993         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6994         initializations.
6995
6996 2019-03-15  Tom Tromey  <tom@tromey.com>
6997
6998         * objfiles.h (struct objfile_per_bfd_storage)
6999         <demangled_hash_languages>: Now a bitset.
7000         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7001         (lookup_minimal_symbol): Update.
7002
7003 2019-03-15  Tom Tromey  <tom@tromey.com>
7004
7005         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7006         Don't return the symbol.
7007         * coffread.c (record_minimal_symbol): Use record_full.
7008
7009 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7010
7011         The MS-Windows port of ncurses fails to switch to a color pair if
7012         one or both of the colors are the implicit default colors.  This
7013         change records the default colors when TUI is initialized, and
7014         then specifies them explicitly when a color pair uses the default
7015         colors.  This allows color styling in TUI mode on MS-Windows.
7016
7017         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7018         ncurses_norm_attr.
7019         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7020         colors in ncurses_norm_attr.
7021         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7022         "none", replace it with the default color recorded in
7023         ncurses_norm_attr.
7024
7025 2019-03-14  Tom Tromey  <tromey@adacore.com>
7026
7027         * source-cache.h (class source_cache) <get_source_lines>: Return
7028         std::string.
7029         * source-cache.c (source_cache::extract_lines): Handle case where
7030         first_pos==npos.  Return std::string.
7031         (source_cache::get_source_lines): Update.
7032
7033 2019-03-14  Tom Tromey  <tromey@adacore.com>
7034
7035         * NEWS: Add item for "style sources" commands.
7036         * source-cache.c (source_cache::get_source_lines): Check
7037         source_styling.
7038         * cli/cli-style.c (source_styling): New global.
7039         (_initialize_cli_style): Add "style sources" commands.
7040         (show_style_sources): New function.
7041         * cli/cli-style.h (source_styling): Declare.
7042
7043 2019-03-14  Pedro Alves  <palves@redhat.com>
7044             Tom Tromey  <tromey@adacore.com>
7045
7046         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7047         * tui/tui-winsource.c (tui_refill_source_window): New function,
7048         from...
7049         (tui_horizontal_source_scroll): ... here.  Move some logic.
7050         * cli/cli-style.c (set_style_enabled): Notify new observable.
7051         * tui/tui-hooks.c (tui_redisplay_source): New function.
7052         (tui_attach_detach_observers): Attach or detach
7053         tui_redisplay_source.
7054         * observable.h (source_styling_changed): New observable.
7055         * observable.c: Define source_styling_changed observable.
7056
7057 2019-03-13  Tom Tromey  <tromey@adacore.com>
7058
7059         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7060         (i386_gnu_nat_target::store_registers): Update.
7061         * target-debug.h (target_debug_print_std_string): New macro.
7062         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7063         * windows-tdep.c (display_one_tib): Update.
7064         * tui/tui-stack.c (tui_make_status_line): Update.
7065         * top.c (print_inferior_quit_action): Update.
7066         * thread.c (thr_try_catch_cmd): Update.
7067         (add_thread_with_info): Update.
7068         (thread_target_id_str): Update.
7069         (thr_try_catch_cmd): Update.
7070         (thread_command): Update.
7071         (thread_find_command): Update.
7072         * record-btrace.c (record_btrace_target::info_record)
7073         (record_btrace_resume_thread, record_btrace_target::resume)
7074         (record_btrace_cancel_resume, record_btrace_step_thread)
7075         (record_btrace_target::wait, record_btrace_target::wait)
7076         (record_btrace_target::wait, record_btrace_target::stop): Update.
7077         * progspace.c (print_program_space): Update.
7078         * process-stratum-target.c
7079         (process_stratum_target::thread_address_space): Update.
7080         * linux-fork.c (linux_fork_mourn_inferior)
7081         (detach_checkpoint_command, info_checkpoints_command)
7082         (linux_fork_context): Update.
7083         (linux_fork_detach): Update.
7084         (class scoped_switch_fork_info): Update.
7085         (delete_checkpoint_command): Update.
7086         * infrun.c (follow_fork_inferior): Update.
7087         (follow_fork_inferior): Update.
7088         (proceed_after_vfork_done): Update.
7089         (handle_vfork_child_exec_or_exit): Update.
7090         (follow_exec): Update.
7091         (displaced_step_prepare_throw): Update.
7092         (displaced_step_restore): Update.
7093         (start_step_over): Update.
7094         (resume_1): Update.
7095         (clear_proceed_status_thread): Update.
7096         (proceed): Update.
7097         (print_target_wait_results): Update.
7098         (do_target_wait): Update.
7099         (context_switch): Update.
7100         (stop_all_threads): Update.
7101         (restart_threads): Update.
7102         (finish_step_over): Update.
7103         (handle_signal_stop): Update.
7104         (switch_back_to_stepped_thread): Update.
7105         (keep_going_pass_signal): Update.
7106         (print_exited_reason): Update.
7107         (normal_stop): Update.
7108         * inferior.c (inferior_pid_to_str): Change return type.
7109         (print_selected_inferior): Update.
7110         (add_inferior): Update.
7111         (detach_inferior): Update.
7112         * dummy-frame.c (fprint_dummy_frames): Update.
7113         * dcache.c (dcache_info_1): Update.
7114         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7115         (btrace_fetch, btrace_clear): Update.
7116         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7117         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7118         type.
7119         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7120         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7121         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7122         * gdbarch.c, gdbarch.h: Rebuild.
7123         * gdbarch.sh (core_pid_to_str): Change return type.
7124         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7125         return type.
7126         (windows_nat_target::pid_to_str): Change return type.
7127         (windows_delete_thread): Update.
7128         (windows_nat_target::attach): Update.
7129         (windows_nat_target::files_info): Update.
7130         * target-delegates.c: Rebuild.
7131         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7132         return type.
7133         (sol_thread_target::pid_to_str): Change return type.
7134         * remote.c (class remote_target) <pid_to_str>: Change return
7135         type.
7136         (remote_target::pid_to_str): Change return type.
7137         (extended_remote_target::attach, remote_target::remote_stop_ns)
7138         (remote_target::remote_notif_remove_queued_reply)
7139         (remote_target::push_stop_reply, remote_target::disable_btrace):
7140         Update.
7141         (extended_remote_target::attach): Update.
7142         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7143         type.
7144         (gdbsim_target::pid_to_str): Change return type.
7145         * ravenscar-thread.c (struct ravenscar_thread_target)
7146         <pid_to_str>: Change return type.
7147         (ravenscar_thread_target::pid_to_str): Change return type.
7148         * procfs.c (class procfs_target) <pid_to_str>: Change return
7149         type.
7150         (procfs_target::pid_to_str): Change return type.
7151         (procfs_target::attach): Update.
7152         (procfs_target::detach): Update.
7153         (procfs_target::fetch_registers): Update.
7154         (procfs_target::store_registers): Update.
7155         (procfs_target::wait): Update.
7156         (procfs_target::files_info): Update.
7157         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7158         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7159         return type.
7160         (nto_procfs_target::pid_to_str): Change return type.
7161         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7162         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7163         return type.
7164         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7165         (exit_lwp): Update.
7166         (attach_proc_task_lwp_callback, get_detach_signal)
7167         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7168         (linux_nat_target::resume, wait_lwp, stop_callback)
7169         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7170         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7171         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7172         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7173         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7174         type.
7175         (inf_ptrace_target::attach): Update.
7176         (inf_ptrace_target::files_info): Update.
7177         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7178         type.
7179         (go32_nat_target::pid_to_str): Change return type.
7180         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7181         (gnu_nat_target::wait): Update.
7182         (gnu_nat_target::wait): Update.
7183         (gnu_nat_target::resume): Update.
7184         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7185         (fbsd_nat_target::wait): Update.
7186         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7187         type.
7188         (darwin_nat_target::attach): Update.
7189         * corelow.c (class core_target) <pid_to_str>: Change return type.
7190         (core_target::pid_to_str): Change return type.
7191         * target.c (normal_pid_to_str): Change return type.
7192         (default_pid_to_str): Likewise.
7193         (target_pid_to_str): Change return type.
7194         (target_translate_tls_address): Update.
7195         (target_announce_detach): Update.
7196         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7197         return type.
7198         (bsd_uthread_target::pid_to_str): Change return type.
7199         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7200         type.
7201         (bsd_kvm_target::pid_to_str): Change return type.
7202         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7203         return type.
7204         (aix_thread_target::pid_to_str): Change return type.
7205         * target.h (struct target_ops) <pid_to_str>: Change return type.
7206         (target_pid_to_str, normal_pid_to_str): Likewise.
7207         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7208         type.
7209         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7210         type.
7211         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7212         return type.
7213         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7214         type.
7215         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7216         type.
7217         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7218         return type.
7219
7220 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7221
7222         * NEWS: Mention that the new default MI version is 3.  Mention
7223         changes to the output of commands and events that deal with
7224         multi-location breakpoints.
7225         * breakpoint.c: Include "mi/mi-out.h".
7226         (print_one_breakpoint): Change output syntax if using MI version
7227         >= 3.
7228         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7229         New.
7230         (mi_multi_location_breakpoint_output_fixed): New.
7231         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7232         (mi_cmd_fix_multi_location_breakpoint_output): New.
7233         (mi_multi_location_breakpoint_output_fixed): New.
7234         * mi/mi-cmds.c (mi_cmds): Register command
7235         -fix-multi-location-breakpoint-output.
7236         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7237         interpreter "mi".
7238
7239 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7240
7241         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7242         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7243         instantiate mi_ui_out based on interpreter name.
7244         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7245         * mi/mi-main.c (mi_load_progress): Likewise.
7246
7247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7248
7249         * NEWS: Combine separate "New targets" sections for 8.3.
7250
7251 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7252
7253         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7254         (ppcfbsd_init_abi): Install gdbarch
7255         "fetch_tls_load_module_address" and "get_thread_local_address"
7256         methods.
7257
7258 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7259
7260         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7261         (riscv_fbsd_init_abi): Install gdbarch
7262         "fetch_tls_load_module_address" and "get_thread_local_address"
7263         methods.
7264
7265 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7266
7267         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7268         (i386fbsd_init_abi): Install gdbarch
7269         "fetch_tls_load_module_address" and "get_thread_local_address"
7270         methods.
7271
7272 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7273
7274         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7275         (amd64fbsd_init_abi): Install gdbarch
7276         "fetch_tls_load_module_address" and "get_thread_local_address"
7277         methods.
7278
7279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7280
7281         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7282         (struct fbsd_pspace_data): New type.
7283         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7284         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7285         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7286         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7287         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7288
7289 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7290
7291         * gdbtypes.c (lookup_struct_elt): New function.
7292         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7293         * gdbtypes.h (struct struct_elt): New type.
7294         (lookup_struct_elt): New prototype.
7295
7296 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7297
7298         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7299         remove disabled code block.
7300
7301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7302
7303         * gdbarch.sh (get_thread_local_address): New method.
7304         * gdbarch.h, gdbarch.c: Regenerate.
7305         * target.c (target_translate_tls_address): Use
7306         gdbarch_get_thread_local_address if present instead of
7307         target::get_thread_local_address.
7308
7309 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7310
7311         * target.h (target::get_thread_local_address): Update comment.
7312
7313 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7314
7315         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7316         objfile->separate_debug_objfile_backlink if not NULL.
7317
7318 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7319
7320         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7321         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7322         (amd64bsd_store_inferior_registers): Likewise.
7323         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7324         Enable segment base registers.
7325         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7326         PT_GETFSBASE and PT_GETGSBASE.
7327         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7328         PT_SETGSBASE.
7329         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7330         segment base registers.
7331         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7332
7333 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7334
7335         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7336         Update calls to i386_target_description to add 'segments'
7337         parameter.
7338         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7339         add segment base registers.
7340         * arch/i386.c (i386_create_target_description): Add 'segments'
7341         parameter to enable segment base registers.
7342         * arch/i386.h (i386_create_target_description): Likewise.
7343         * features/i386/32bit-segments.xml: New file.
7344         * features/i386/32bit-segments.c: Generate.
7345         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7346         call to i386_target_description to add 'segments' parameter.
7347         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7348         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7349         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7350         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7351         if feature is present.
7352         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7353         Add 'segments' parameter to call to i386_target_description.
7354         (i386_target_description): Add 'segments' parameter to enable
7355         segment base registers.
7356         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7357         to call to i386_target_description.
7358         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7359         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7360         Define I386_NUM_REGS.
7361         (i386_target_description): Add 'segments' parameter to enable
7362         segment base registers.
7363
7364 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7365
7366         PR/24325
7367         * source-cache.c: #undef open and close, to avoid unresolved
7368         externals during linking.
7369
7370 2019-03-12  Tom Tromey  <tromey@adacore.com>
7371
7372         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7373         const.  Add initializers.
7374         (_initialize_remote): Don't initialize ptid globals.
7375
7376 2019-03-12  Pedro Alves  <palves@redhat.com>
7377
7378         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7379
7380 2019-03-12  Pedro Alves  <palves@redhat.com>
7381
7382         * cp-name-parser.y (main): Remove unused 'len' variable.
7383
7384 2019-03-12  Tom Tromey  <tromey@adacore.com>
7385
7386         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7387         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7388
7389 2019-03-12  Tom Tromey  <tromey@adacore.com>
7390
7391         * linux-nat.c (iterate_over_lwps): Update.
7392         (stop_callback): Remove parameter.
7393         (stop_wait_callback, detach_callback, resume_set_callback)
7394         (select_singlestep_lwp_callback, set_ignore_sigint)
7395         (status_callback, resumed_callback, resume_clear_callback)
7396         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7397         data parameter.
7398         (linux_nat_target::detach, linux_nat_target::resume)
7399         (linux_stop_and_wait_all_lwps, select_event_lwp)
7400         (linux_nat_filter_event, linux_nat_wait_1)
7401         (linux_nat_target::kill, linux_nat_target::stop)
7402         (linux_nat_target::stop): Update.
7403         (linux_nat_resume_callback): Change type.
7404         (resume_stopped_resumed_lwps, count_events_callback)
7405         (select_event_lwp_callback): Likewise.
7406         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7407         * arm-linux-nat.c (struct update_registers_data): Remove.
7408         (update_registers_callback): Change type.
7409         (arm_linux_insert_hw_breakpoint1): Update.
7410         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7411         parameter.
7412         (x86_linux_dr_set_addr): Update.
7413         (x86_linux_dr_set_control): Update.
7414         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7415         (iterate_over_lwps): Use gdb::function_view.
7416         * nat/aarch64-linux-hw-point.c (struct
7417         aarch64_dr_update_callback_param): Remove.
7418         (debug_reg_change_callback): Change type.
7419         (aarch64_notify_debug_reg_change): Update.
7420         * s390-linux-nat.c (s390_refresh_per_info): Update.
7421
7422 2019-03-11  Tom Tromey  <tromey@adacore.com>
7423
7424         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7425         redundant assignment to "this_cu".
7426
7427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7428
7429         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7430
7431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7432
7433         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7434         from...
7435         (rank_one_type): ... this.
7436
7437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7438
7439         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7440         from...
7441         (rank_one_type): ... this.
7442
7443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7444
7445         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7446         from...
7447         (rank_one_type): ... this.
7448
7449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7450
7451         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7452         from...
7453         (rank_one_type): ... this.
7454
7455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7456
7457         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7458         from...
7459         (rank_one_type): ... this.
7460
7461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7462
7463         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7464         from...
7465         (rank_one_type): ... this.
7466
7467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7468
7469         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7470         from...
7471         (rank_one_type): ... this.
7472
7473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7474
7475         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7476         from...
7477         (rank_one_type): ... this.
7478
7479 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7480
7481         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7482         from...
7483         (rank_one_type): ... this.
7484
7485 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7486
7487         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7488         from...
7489         (rank_one_type): ... this.
7490
7491 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7492
7493         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7494         from...
7495         (rank_one_type): ... this.
7496
7497 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7498
7499         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7500         from...
7501         (rank_one_type): ... this.
7502
7503 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7504
7505         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7506         inferior-events' shows the example events.
7507
7508 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7509
7510         Support styling on native MS-Windows console
7511
7512         PR/24315
7513         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7514         on MS-Windows if $TERM is not defined.
7515
7516         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7517
7518         * posix-hdep.c (gdb_console_fputs):
7519         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7520         functions.
7521         * ui-file.h (gdb_console_fputs): Add prototype.
7522
7523         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7524         back to fputs only if the former returns zero.
7525
7526 2019-03-07  Tom Tromey  <tom@tromey.com>
7527
7528         * symmisc.c (print_symbol_bcache_statistics): Update.
7529         (print_objfile_statistics): Update.
7530         * symfile.c (allocate_symtab): Update.
7531         * stabsread.c: Don't include bcache.h.
7532         * psymtab.h (struct psymbol_bcache): Don't declare.
7533         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7534         (psymbol_bcache_init, psymbol_bcache_free)
7535         (psymbol_bcache_get_bcache): Don't declare.
7536         * psymtab.c (struct psymbol_bcache): Remove.
7537         (psymtab_storage::psymtab_storage): Update.
7538         (psymtab_storage::~psymtab_storage): Update.
7539         (psymbol_bcache_init, psymbol_bcache_free)
7540         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7541         (add_psymbol_to_bcache): Update.
7542         (allocate_psymtab): Update.
7543         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7544         macro_cache>: No longer pointers.
7545         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7546         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7547         * macrotab.c (macro_bcache): Update.
7548         * macroexp.c: Don't include bcache.h.
7549         * gdbtypes.c (check_types_worklist): Update.
7550         (types_deeply_equal): Remove TRY/CATCH.  Update.
7551         * elfread.c (elf_symtab_read): Update.
7552         * dwarf2read.c: Don't include bcache.h.
7553         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7554         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7555         (print_bcache_statistics, bcache_memory_used): Don't declare.
7556         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7557         methods.  Rename all data members.
7558         * bcache.c (struct bcache): Move to bcache.h.
7559         (bcache::expand_hash_table): Rename from expand_hash_table.
7560         (bcache): Remove.
7561         (bcache::insert): Rename from bcache_full.
7562         (bcache::compare): Rename from bcache_compare.
7563         (bcache_xmalloc): Remove.
7564         (bcache::~bcache): Rename from bcache_xfree.
7565         (bcache::print_statistics): Rename from print_bcache_statistics.
7566         (bcache::memory_used): Rename from bcache_memory_used.
7567
7568 2019-03-07  Pedro Alves  <palves@redhat.com>
7569
7570         * infrun.c (normal_stop): Also check for
7571         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7572
7573 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7574
7575         * f-lang.c (value_from_host_double): Moved to...
7576         * value.c (value_from_host_double): ...here.
7577         * value.h (value_from_host_double): Declare.
7578         * guile/scm-math.c (vlscm_convert_typed_number): Use
7579         value_from_host_double.
7580         (vlscm_convert_number): Likewise.
7581         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7582         * python/py-value.c (convert_value_from_python): Likewise.
7583
7584 2019-03-06  Tom Tromey  <tom@tromey.com>
7585
7586         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7587
7588 2019-03-06  Tom Tromey  <tom@tromey.com>
7589
7590         * utils.h (free_current_contents): Don't declare.
7591         * utils.c (free_current_contents): Remove.
7592
7593 2019-03-06  Tom Tromey  <tom@tromey.com>
7594
7595         * top.c (quit_force): Update.
7596         * main.c (captured_command_loop): Update.
7597         * common/new-op.c (operator new): Update.
7598         * common/common-exceptions.c (struct catcher)
7599         <save_cleanup_chain>: Remove member.
7600         (exceptions_state_mc_init): Update.
7601         (exception_try_scope_entry): Return nullptr.
7602         (exception_try_scope_exit, exception_rethrow)
7603         (throw_exception_sjlj, throw_exception_cxx): Update.
7604         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7605         (all_cleanups, do_cleanups, discard_cleanups)
7606         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7607         (restore_cleanups, restore_final_cleanups): Don't declare.
7608         (do_final_cleanups): Remove parameter.
7609         * common/cleanups.c (cleanup_chain, make_cleanup)
7610         (make_cleanup_dtor, all_cleanups, do_cleanups)
7611         (discard_my_cleanups, discard_cleanups)
7612         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7613         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7614         (null_cleanup): Remove.
7615         (do_final_cleanups): Remove parameter.
7616
7617 2019-03-06  Tom Tromey  <tom@tromey.com>
7618
7619         * remote.c (remote_target::remote_parse_stop_reply): Use
7620         unique_xmalloc_ptr.
7621
7622 2019-03-06  Tom Tromey  <tom@tromey.com>
7623
7624         * stabsread.c (struct stabs_field_info): Rename from field_info.
7625         <list, fnlist>: Add initializers.
7626         <obstack>: New member.
7627         (read_member_functions, read_struct_fields, read_baseclasses):
7628         Allocate on obstack.  Don't use cleanups.
7629         (read_one_struct_field, read_member_functions, read_struct_fields)
7630         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7631         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7632         (read_struct_type): Update.
7633
7634 2019-03-06  Tom Tromey  <tom@tromey.com>
7635
7636         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7637         * common/filestuff.h (make_cleanup_close): Don't declare.
7638         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7639         Remove.
7640
7641 2019-03-06  Tom Tromey  <tom@tromey.com>
7642
7643         * solib-aix.c: Use make_scope_exit.
7644
7645 2019-03-06  Tom Tromey  <tom@tromey.com>
7646
7647         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7648         Use make_scope_exit.
7649
7650 2019-03-06  Tom Tromey  <tom@tromey.com>
7651
7652         * solib-svr4.c (disable_probes_interface): Remove parameter.
7653         (svr4_handle_solib_event): Use make_scope_exit.
7654
7655 2019-03-06  Tom Tromey  <tom@tromey.com>
7656
7657         * remote.c (struct stop_reply_deleter): Remove.
7658         (stop_reply_up): Update.
7659         (struct stop_reply): Derive from notif_event.  Don't typedef.
7660         <regcache>: Now a std::vector.
7661         (stop_reply_xfree): Remove.
7662         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7663         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7664         (remote_target::discard_pending_stop_replies): Use delete.
7665         (remote_target::remote_parse_stop_reply): Update.
7666         (remote_target::process_stop_reply): Update.
7667         * remote-notif.h (struct notif_event): Add virtual destructor.
7668         Remove "dtr" member.
7669         (struct notif_client) <alloc_event>: Return a unique_ptr.
7670         (notif_event_xfree): Don't declare.
7671         (notif_event_up): New typedef.
7672         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7673         (notif_event_xfree, do_notif_event_xfree): Remove.
7674         (remote_notif_state_xfree): Update.
7675
7676 2019-03-06  Tom Tromey  <tom@tromey.com>
7677
7678         * infrun.c (displaced_step_clear_cleanup): Now a
7679         forward_scope_exit type.
7680         (displaced_step_prepare_throw): Update.
7681         (displaced_step_fixup): Update.
7682
7683 2019-03-06  Tom Tromey  <tom@tromey.com>
7684
7685         * inferior.h (class inferior): Update comment.
7686         * gdbthread.h (class thread_info): Update comment.
7687
7688 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7689             Tom Tromey  <tom@tromey.com>
7690
7691         * stabsread.h (struct stab_section_list): Remove.
7692         (coffstab_build_psymtabs): Update.
7693         * dbxread.c (symbuf_sections): Now a std::vector.
7694         (sect_idx): New global.
7695         (fill_symbuf): Update.
7696         (coffstab_build_psymtabs): Change type of stabsects parameter.
7697         Update.
7698         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7699         std::vector.
7700         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7701         (coff_locate_sections): Update.
7702         (coff_symfile_read): Remove cleanups.  Update.
7703         (init_stringtab): Add storage parameter.
7704         (free_stringtab, free_stringtab_cleanup): Remove.
7705         (init_lineno): Add storage parameter.
7706         (free_linetab, free_linetab_cleanup): Remove.
7707
7708 2019-03-06  Pedro Alves  <palves@redhat.com>
7709
7710         * linux-fork.c (fork_info::clobber_regs): Delete.
7711         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7712         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7713         comment.  Adjust.
7714         (scoped_switch_fork_info::scoped_switch_fork_info)
7715         (checkpoint_command, linux_fork_context): Adjust
7716         fork_save_infrun_state calls.
7717
7718 2019-03-06  Pedro Alves  <palves@redhat.com>
7719
7720         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7721         (inf_has_multiple_threads): Return 'bool' and rewrite using
7722         inferior_info::threads().
7723
7724 2019-03-06  Pedro Alves  <palves@redhat.com>
7725
7726         * linux-fork.c: Include <list>.
7727         (fork_list): Now a std::list instance.
7728         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7729         (forks_exist_p, find_last_fork): Adjust.
7730         (new_fork): Delete.
7731         (one_fork_p): New.
7732         (add_fork): Adjust.
7733         (free_fork): Delete, folded into fork_info::~fork_info().
7734         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7735         Adjust.
7736         (init_fork_list): Delete.
7737         (linux_fork_killall, linux_fork_mourn_inferior)
7738         (linux_fork_detach, info_checkpoints_command): Adjust.
7739         (_initialize_linux_fork): No longer call init_fork_list.
7740
7741 2019-03-06  Pedro Alves  <palves@redhat.com>
7742
7743         * linux-fork.c (new_fork): New, split out of ...
7744         (add_fork): ... this.  Return void.  Move "first fork" special
7745         case from here, to ...
7746         (checkpoint_command): ... here.
7747         * linux-linux.h (add_fork): Return void.
7748
7749 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7750
7751         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7752
7753 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7754             Chris January  <chris.january@arm.com>
7755             David Lecomber  <david.lecomber@arm.com>
7756
7757         * f-exp.y: New token, UNOP_INTRINSIC.
7758         (exp): New pattern using UNOP_INTRINSIC token.
7759         (f77_keywords): Add 'abs' keyword.
7760         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7761         (value_from_host_double): New function.
7762         (evaluate_subexp_f): Support UNOP_ABS.
7763
7764 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7765
7766         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7767         types.
7768
7769 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7770
7771         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7772         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7773         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7774
7775 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7776
7777         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7778
7779 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7780             Chris January  <chris.january@arm.com>
7781
7782         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7783         * f-exp.y: Define 'KIND' token.
7784         (exp): New pattern for KIND expressions.
7785         (ptype): Handle types with a kind extension.
7786         (direct_abs_decl): Extend to spot kind extensions.
7787         (f77_keywords): Add 'kind' to the list.
7788         (push_kind_type): New function.
7789         (convert_to_kind_type): New function.
7790         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7791         * parse.c (operator_length_standard): Likewise.
7792         * parser-defs.h (enum type_pieces): Add tp_kind.
7793         * std-operator.def: Add UNOP_KIND.
7794
7795 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7796
7797         * f-exp.y (f_parse): Set yydebug.
7798
7799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7800
7801         * f-lang.c (evaluate_subexp_f): New function.
7802         (exp_descriptor_f): New global.
7803         (f_language_defn): Use exp_descriptor_f instead of
7804         exp_descriptor_standard.
7805
7806 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7807
7808         * f-exp.y (struct token): Add comments.
7809         (dot_ops): Remove uppercase versions and the end marker.
7810         (f77_keywords): Likewise.
7811         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7812         entries in the dot_ops array are case insensitive, and use
7813         strncasecmp to compare strings.  Also some whitespace cleanup in
7814         this area.  Similar for the f77_keywords array, except entries in
7815         this list might be case sensitive.
7816
7817 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7818
7819         * f-exp.y (struct f77_boolean_val): Add comments.
7820         (boolean_values): Remove uppercase versions, and end marker.
7821         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7822         and use strncasecmp to achieve case insensitivity.  Additionally,
7823         perform whitespace cleanup around this code.
7824
7825 2019-03-06  Tom Tromey  <tromey@adacore.com>
7826
7827         * remote-sim.c (gdbsim_target_open): Use result of
7828         gdb_argv::release.
7829
7830 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7831         Dirk Schubert  <dirk.schubert@arm.com>
7832         Chris January  <chris.january@arm.com>
7833
7834         * eval.c (evaluate_subexp_standard): Call Fortran argument
7835         wrapping logic.
7836         * f-lang.c (struct value): A value which can be passed into a
7837         Fortran function call.
7838         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7839         where appropriate.
7840         (struct type): Value ready for a Fortran function call.
7841         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7842         is needed.
7843         * f-lang.h (fortran_argument_convert): Declaration.
7844         (fortran_preserve_arg_pointer): Declaration.
7845         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7846
7847 2019-03-05  Tom Tromey  <tromey@adacore.com>
7848
7849         * python/py-prettyprint.c (print_string_repr): Remove #if.
7850         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7851
7852 2019-03-05  Tom Tromey  <tromey@adacore.com>
7853
7854         * target.c (the_dummy_target): Move later.  Change type to
7855         "dummy_target".
7856         (initialize_targets): Don't initialize the_dummy_target.
7857
7858 2019-03-05  Tom Tromey  <tromey@adacore.com>
7859
7860         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7861         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7862
7863 2019-03-05  Tom Tromey  <tromey@adacore.com>
7864
7865         * windows-nat.c (windows_nat_target::attach)
7866         (windows_nat_target::detach): Don't call gdb_flush.
7867         * valprint.c (generic_val_print, val_print, val_print_string):
7868         Don't call gdb_flush.
7869         * utils.c (defaulted_query): Don't call gdb_flush.
7870         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7871         * target.c (target_announce_detach): Don't call gdb_flush.
7872         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7873         * remote.c (extended_remote_target::attach): Don't call
7874         gdb_flush.
7875         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7876         * printcmd.c (do_examine): Don't call gdb_flush.
7877         (info_display_command): Don't call gdb_flush.
7878         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7879         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7880         * memattr.c (info_mem_command): Don't call gdb_flush.
7881         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7882         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7883         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7884         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7885         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7886         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7887         (gnu_nat_target::detach): Don't call gdb_flush.
7888         * f-valprint.c (f_val_print): Don't call gdb_flush.
7889         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7890         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7891         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7892         gdb_flush.
7893         * c-valprint.c (c_val_print): Don't call gdb_flush.
7894         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7895
7896 2019-03-05  Tom Tromey  <tromey@adacore.com>
7897
7898         * varobj.c (update_dynamic_varobj_children): Update.
7899         (install_default_visualizer): Use reset, not release.
7900         * value.c (set_internalvar): Update.
7901         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7902         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7903         ATTRIBUTE_UNUSED_RESULT.
7904
7905 2019-03-05  Tom Tromey  <tromey@adacore.com>
7906
7907         * remote.c (class scoped_remote_fd) <release>: Add
7908         ATTRIBUTE_UNUSED_RESULT.
7909
7910 2019-03-05  Tom Tromey  <tromey@adacore.com>
7911
7912         * macroexp.c (struct macro_buffer) <release>: Add
7913         ATTRIBUTE_UNUSED_RESULT.
7914
7915 2019-03-05  Tom Tromey  <tromey@adacore.com>
7916
7917         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7918         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7919         ATTRIBUTE_UNUSED_RESULT.
7920
7921 2019-03-05  Tom Tromey  <tromey@adacore.com>
7922
7923         * common/scoped_fd.h (class scoped_fd) <release>: Add
7924         ATTRIBUTE_UNUSED_RESULT.
7925
7926 2019-03-05  Tom Tromey  <tromey@adacore.com>
7927
7928         * parser-defs.h (struct parser_state) <release>: Add
7929         ATTRIBUTE_UNUSED_RESULT.
7930
7931 2019-03-05  Tom Tromey  <tromey@adacore.com>
7932
7933         * utils.h (class gdb_argv) <release>: Add
7934         ATTRIBUTE_UNUSED_RESULT.
7935         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7936
7937 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7938
7939         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7940         for-loop range, to avoid compiler warnings.
7941
7942         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7943         avoid compiler warnings about unused variables.
7944
7945         * NEWS: Mention end of support for native debugging on MS-Windows
7946         before XP.
7947
7948         PR gdb/24292
7949         * common/netstuff.c:
7950         * gdbserver/gdbreplay.c
7951         * gdbserver/remote-utils.c:
7952         * ser-tcp.c:
7953         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7954         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7955         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7956         'getaddrinfo' and 'freeaddrinfo' were not available before
7957         Windows XP, and mingw.org's MinGW headers by default define
7958         _WIN32_WINNT to 0x500.
7959
7960 2019-03-01  Gary Benson <gbenson@redhat.com>
7961
7962         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7963
7964 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7965             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7966
7967         PR gdb/8527
7968         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7969         set_sigint_trap, clear_sigint_trap.
7970
7971 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7972
7973         * target.c (target_detach): Clear the regcache and the
7974         frame cache.
7975
7976 2019-02-27  Pedro Alves  <palves@redhat.com>
7977
7978         * utils.c (set_screen_size): When we cap the height/width sizes,
7979         tweak the corresponding command variable to show "unlimited":
7980
7981 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7982             Pedro Alves  <palves@redhat.com>
7983
7984         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7985         before calling rl_set_screen_size.
7986
7987 2019-02-27  Tom Tromey  <tromey@adacore.com>
7988
7989         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7990         define.
7991         * python/py-value.c: Remove Python 2.4 workaround.
7992         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7993         workaround.
7994         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7995         Python 2.4 workaround.
7996         * python/python-internal.h: Remove Python 2.4 comment.
7997         (Py_ssize_t): Don't define.
7998         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7999         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8000         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8001         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8002         * python/python.c (do_start_initialization): Remove Python 2.4
8003         workaround.
8004         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8005         (print_children): Remove Python 2.4 workaround.
8006         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8007         workaround.
8008         (CHARBUFFERPROC_NAME): Remove.
8009         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8010         Python 2.4 workaround.
8011
8012 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8013
8014         * NEWS: Note minimum Python version.
8015
8016 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8017
8018         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8019         code from these functions.  Remove corresponding ifdefs.  Use
8020         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8021         Remove gotos and target of gotos.
8022         (infpy_search_memory): Likewise.
8023
8024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8025
8026         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8027         (hppa_gdbarch_init): Don't register deleted functions with
8028         gdbarch.
8029
8030 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8031
8032         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8033         (h8300_unwind_sp): Delete.
8034         (h8300_dummy_id): Delete.
8035         (h8300_gdbarch_init): Don't register deleted functions with
8036         gdbarch.
8037
8038 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8039
8040         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8041         (ft32_unwind_pc): Delete.
8042         (ft32_unwind_sp): Delete.
8043         (ft32_gdbarch_init): Don't register deleted functions with
8044         gdbarch.
8045
8046 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8047
8048         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8049         (frv_unwind_pc): Delete.
8050         (frv_unwind_sp): Delete.
8051         (frv_gdbarch_init): Don't register deleted functions with
8052         gdbarch.
8053
8054 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8055
8056         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8057         (riscv_unwind_pc): Delete.
8058         (riscv_unwind_sp): Delete.
8059         (riscv_gdbarch_init): Don't register deleted functions with
8060         gdbarch.
8061
8062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8063
8064         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8065         (csky_unwind_pc): Delete.
8066         (csky_unwind_sp): Delete.
8067         (csky_gdbarch_init): Don't register deleted functions with
8068         gdbarch.
8069
8070 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8071
8072         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8073         (cris_unwind_pc): Delete.
8074         (cris_unwind_sp): Delete.
8075         (cris_gdbarch_init): Don't register deleted functions with
8076         gdbarch.
8077
8078 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8079
8080         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8081         (bfin_unwind_pc): Delete.
8082         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8083
8084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8085
8086         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8087         (arm_unwind_pc): Delete.
8088         (arm_unwind_sp): Delete.
8089         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8090
8091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8092
8093         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8094         (arc_unwind_pc): Delete.
8095         (arc_unwind_sp): Delete.
8096         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8097
8098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8099
8100         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8101         (alpha_unwind_pc): Delete.
8102         (alpha_gdbarch_init): Don't register deleted functions with
8103         gdbarch.
8104
8105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8106
8107         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8108         (aarch64_unwind_pc): Delete.
8109         (aarch64_unwind_sp): Delete.
8110         (aarch64_gdbarch_init): Don't register deleted functions with
8111         gdbarch.
8112
8113 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8114
8115         * gdbtypes.c (type_align): Don't consider static members when
8116         computing structure alignment.
8117
8118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8119
8120         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8121         return 0 for other types.
8122         * arch-utils.c (default_type_align): Always return 0.
8123         * gdbarch.h: Regenerate.
8124         * gdbarch.sh (type_align): Extend comment.
8125         * gdbtypes.c (type_align): Add additional comments, always call
8126         gdbarch_type_align before applying the default rules.
8127         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8128         generic code will then apply a suitable default.
8129         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8130         types, return 0 for other types.
8131
8132 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8133
8134         * NEWS: Create a new section for the next release branch.
8135         Rename the section of the current branch, now that it has
8136         been cut.
8137
8138 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8139
8140         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8141         * version.in: Bump version to 8.3.50.DATE-git.
8142
8143 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8144
8145         * aix-thread.c (ptid_cmp): Remove unused variable.
8146         (get_signaled_thread): Likewise.
8147         (store_regs_user_thread): Likewise.
8148         (store_regs_kernel_thread): Likewise.
8149         (fetch_regs_kernel_thread): Remove shadowed variable.
8150
8151 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8152
8153         * features/riscv/32bit-cpu.xml: Add register numbers.
8154         * features/riscv/32bit-fpu.c: Regenerate.
8155         * features/riscv/32bit-fpu.xml: Add register numbers.
8156         * features/riscv/64bit-cpu.xml: Add register numbers.
8157         * features/riscv/64bit-fpu.c: Regenerate.
8158         * features/riscv/64bit-fpu.xml: Add register numbers.
8159
8160 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8161
8162         * NEWS: Mention two argument form of gdb.Value constructor.
8163         * python/py-value.c (convert_buffer_and_type_to_value): New
8164         function.
8165         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8166         Add support for handling an optional second argument.  Call
8167         convert_buffer_and_type_to_value as appropriate.
8168         * python/python-internal.h (Py_buffer_deleter): New struct.
8169         (Py_buffer_up): New typedef.
8170
8171 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8172
8173         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8174         instead of releasing ownership.
8175
8176 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8177
8178         * dwarf2read.c (open_and_init_dwp_file): Call
8179         elf_numsections instead of bfd_count_sections to initialize
8180         dwp_file->num_sections.
8181
8182 2019-02-25  Tom Tromey  <tromey@adacore.com>
8183
8184         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8185
8186 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8187
8188         * gcore.in: Add '--readnever' option when invoking GDB.
8189
8190 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8191
8192         * MAINTAINERS: Update my email address.
8193
8194 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8195
8196         * build-id.c (build_id_to_debug_bfd_1): New function.
8197         (build_id_to_debug_bfd): Look for separate debug file in
8198         sysroot.
8199
8200 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8201
8202         * gdbarch.sh: Update the copyright year range that is placed into
8203         generated files.
8204
8205 2019-02-22  Keith Seitz  <keiths@redhat.com>
8206
8207         PR symtab/23853
8208         * linespec.c (create_sals_line_offset): Search for the default
8209         symtab's filename instead of its fullname.
8210
8211 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8212
8213         * NEWS: Update style defaults.
8214
8215 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8216
8217         * main.c (captured_main_1): Disable styling in batch mode.
8218
8219 2019-02-20  Tom Tromey  <tom@tromey.com>
8220
8221         * symtab.c (symtab_symbol_info): Fix typos.
8222
8223 2019-02-20  Tom Tromey  <tromey@adacore.com>
8224
8225         * findcmd.c (_initialize_mem_search): Use upper case for
8226         metasyntactic variables.
8227
8228 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8229
8230         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8231         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8232
8233 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8234
8235         * top.h (source_file_name): Change to std::string.
8236         * top.c (source_file_name): Likewise.
8237         (command_line_input): Adjust.
8238         * cli/cli-script.c (script_from_file): Adjust.
8239
8240 2019-02-19  Tom Tromey  <tromey@adacore.com>
8241
8242         * ravenscar-thread.c
8243         (ravenscar_thread_target::update_thread_list): Don't call
8244         ada_build_task_list.
8245         * ada-lang.h (ada_build_task_list): Don't declare.
8246         * ada-tasks.c (struct ada_tasks_inferior_data)
8247         <task_list_valid_p>: Now bool.
8248         (read_known_tasks, ada_task_list_changed)
8249         (ada_tasks_invalidate_inferior_data): Update.
8250         (read_known_tasks_array): Return bool.
8251         (read_known_tasks_list): Likewise.
8252         (read_known_tasks): Return void.
8253         (ada_build_task_list): Now static.
8254
8255 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8256
8257         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8258         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8259
8260 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8261
8262         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8263         variant for ada_tasks_pspace_data_handle and
8264         ada_tasks_inferior_data_handle.
8265         (ada_tasks_pspace_data_cleanup): New function.
8266         (ada_tasks_inferior_data_cleanup): New function.
8267
8268 2019-02-17  Tom Tromey  <tom@tromey.com>
8269
8270         * macrotab.h (macro_source_fullname): Return a std::string.
8271         * macrotab.c (macro_include, check_for_redefinition)
8272         (macro_undef, macro_lookup_definition, foreach_macro)
8273         (foreach_macro_in_scope): Update.
8274         (macro_source_fullname): Return a std::string.
8275         * macrocmd.c (show_pp_source_pos): Update.
8276
8277 2019-02-17  Tom Tromey  <tom@tromey.com>
8278
8279         * macrocmd.c (show_pp_source_pos): Style the file names.
8280
8281 2019-02-17  Tom Tromey  <tom@tromey.com>
8282
8283         PR tui/24197:
8284         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8285
8286 2019-02-17  Tom Tromey  <tom@tromey.com>
8287
8288         * ada-lang.c (user_select_syms): Use filtered printing.
8289         * utils.c (wrap_style): New global.
8290         (desired_style): Remove.
8291         (emit_style_escape): Add stream parameter.
8292         (set_output_style, reset_terminal_style, prompt_for_continue):
8293         Update.
8294         (flush_wrap_buffer): Only flush gdb_stdout.
8295         (wrap_here): Set wrap_style.
8296         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8297         treat escape sequences as a character.  Change when wrap buffer is
8298         flushed.
8299         (fputs_styled): Do not set the output style when the default is
8300         requested.
8301         * ui-style.h (struct ui_file_style) <is_default>: New method.
8302         * source.c (print_source_lines_base): Emit escape sequences in one
8303         piece.
8304
8305 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8306
8307         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8308         integers and enumeration types.
8309
8310 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8311
8312         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8313         instead of lookup_symbol_in_language
8314         (do_exact_match): New function.
8315         (ada_get_symbol_name_matcher): Return do_exact_match when
8316         doing a verbatim match.
8317
8318 2019-02-15  Tom Tromey  <tromey@adacore.com>
8319
8320         * ravenscar-thread.c (ravenscar_thread_target::resume)
8321         (ravenscar_thread_target::wait): Special case wildcard requests.
8322
8323 2019-02-15  Tom Tromey  <tromey@adacore.com>
8324
8325         * ravenscar-thread.c (base_ptid): Remove.
8326         (struct ravenscar_thread_target) <close>: New method.
8327         <m_base_ptid>: New member.
8328         <update_inferior_ptid, active_task, task_is_currently_active,
8329         runtime_initialized>: Declare methods.
8330         <ravenscar_thread_target>: Add constructor.
8331         (ravenscar_thread_target::task_is_currently_active)
8332         (ravenscar_thread_target::update_inferior_ptid)
8333         (ravenscar_runtime_initialized): Rename.  Now methods.
8334         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8335         (ravenscar_thread_target::update_thread_list): Update.
8336         (ravenscar_thread_target::active_task): Now method.
8337         (ravenscar_thread_target::store_registers)
8338         (ravenscar_thread_target::prepare_to_store)
8339         (ravenscar_thread_target::prepare_to_store)
8340         (ravenscar_thread_target::mourn_inferior): Update.
8341         (ravenscar_inferior_created): Use "new" to create target.
8342         (ravenscar_thread_target::get_ada_task_ptid): Update.
8343         (_initialize_ravenscar): Don't initialize base_ptid.
8344         (ravenscar_ops): Remove global.
8345
8346 2019-02-15  Tom Tromey  <tromey@adacore.com>
8347
8348         * target.h (push_target): Declare new overload.
8349         * target.c (push_target): New overload, taking an rvalue reference.
8350         * remote.c (remote_target::open_1): Use push_target overload.
8351         * corelow.c (core_target_open): Use push_target overload.
8352
8353 2019-02-15  Tom Tromey  <tromey@adacore.com>
8354
8355         * ravenscar-thread.c (is_ravenscar_task)
8356         (ravenscar_task_is_currently_active): Return bool.
8357         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8358         (_initialize_ravenscar): Remove "(void)".
8359         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8360         Return bool.
8361
8362 2019-02-15  Tom Tromey  <tromey@adacore.com>
8363
8364         * ravenscar-thread.c (ravenscar_runtime_initializer)
8365         (has_ravenscar_runtime, get_running_thread_id)
8366         (ravenscar_thread_target::resume): Fix indentation.
8367
8368 2019-02-15  Tom Tromey  <tromey@adacore.com>
8369
8370         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8371         from ravenscar_arch_ops.
8372         (sparc_ravenscar_ops::fetch_registers)
8373         (sparc_ravenscar_ops::store_registers): Now methods.
8374         (sparc_ravenscar_prepare_to_store): Remove.
8375         (sparc_ravenscar_ops): Redefine.
8376         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8377         methods and destructor.  Remove members.
8378         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8379         (ravenscar_thread_target::store_registers)
8380         (ravenscar_thread_target::prepare_to_store): Update.
8381         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8382         Remove.
8383         (struct ppc_ravenscar_powerpc_ops): Derive from
8384         ravenscar_arch_ops.
8385         (ppc_ravenscar_powerpc_ops::fetch_registers)
8386         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8387         (ppc_ravenscar_powerpc_ops): Redefine.
8388         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8389         (ppc_ravenscar_e500_ops::fetch_registers)
8390         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8391         (ppc_ravenscar_e500_ops): Redefine.
8392         * aarch64-ravenscar-thread.c
8393         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8394         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8395         (aarch64_ravenscar_fetch_registers)
8396         (aarch64_ravenscar_store_registers): Now methods.
8397         (aarch64_ravenscar_ops): Redefine.
8398
8399 2019-02-15  Tom Tromey  <tromey@adacore.com>
8400
8401         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8402         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8403         (ravenscar_thread_target::stopped_by_watchpoint)
8404         (ravenscar_thread_target::stopped_data_address)
8405         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8406
8407 2019-02-15  Tom Tromey  <tromey@adacore.com>
8408
8409         * ravenscar-thread.c: Fix some typos.
8410
8411 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8412             Tom Tromey  <tromey@adacore.com>
8413
8414         * ada-lang.c (ada_exception_sal): Change addr_string to a
8415         std::string.
8416         (create_ada_exception_catchpoint): Update.
8417
8418 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8419             Tom Tromey  <tromey@adacore.com>
8420
8421         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8422         (bp_location_ops): Remove.
8423         (base_breakpoint_allocate_location): Update.
8424         (free_bp_location): Update.
8425         * ada-lang.c (class ada_catchpoint_location)
8426         <ada_catchpoint_location>: Remove ops parameter.
8427         (ada_catchpoint_location_dtor): Remove.
8428         (ada_catchpoint_location_ops): Remove.
8429         (allocate_location_exception): Update.
8430         * breakpoint.h (struct bp_location_ops): Remove.
8431         (class bp_location) <bp_location>: Remove bp_location_ops
8432         parameter.
8433         <~bp_location>: Add destructor.
8434         <ops>: Remove.
8435
8436 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8437             Pedro Alves  <palves@redhat.com>
8438
8439         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8440         'PATH_MAX'.
8441
8442 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8443             Samuel Thibault  <samuel.thibault@gnu.org>
8444             Thomas Schwinge  <thomas@codesourcery.com>
8445
8446         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8447         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8448
8449 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8450
8451         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8452         (check_empty): Use "const char *".
8453
8454         * gnu-nat.c (gnu_nat_target::detach): Instead of
8455         'detach_inferior (pid)' call
8456         'detach_inferior (find_inferior_pid (pid))'.
8457
8458         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8459         'nat/fork-inferior.o'.
8460         * gnu-nat.c: #include "nat/fork-inferior.h".
8461
8462         * gnu-nat.c (gnu_nat_target::detach): Instead of
8463         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8464         * gnu-nat.h: #include "inf-child.h".
8465         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8466         'i386_gnu_nat_target::fetch_registers'.
8467         (gnu_store_registers): Rename/move to
8468         'i386_gnu_nat_target::store_registers'.
8469
8470         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8471         * gnu-nat.h (mach_thread_info): New function.
8472         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8473
8474         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8475
8476 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8477
8478         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8479
8480 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8481
8482         * windows-nat.c (windows_add_thread): Add new parameter
8483         "main_thread_p" with default value set to false.  Update
8484         function documentation as well as all callers.
8485         (windows_delete_thread): Likewise.
8486         (fake_create_process): Update call to windows_add_thread.
8487         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8488         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8489         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8490         call to windows_delete_thread.
8491
8492 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8493
8494         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8495
8496 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8497
8498         * symfile.c (find_separate_debug_file): Use canonical path of
8499         sysroot with child_path instead of gdb_sysroot if it is valid.
8500
8501 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8502
8503         * symfile.c (find_separate_debug_file): Use child_path to
8504         determine if an object file is under a sysroot.
8505
8506 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8507
8508         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8509         unittests/child-path-selftests.c.
8510         * common/pathstuff.c (child_path): New function.
8511         * common/pathstuff.h (child_path): New prototype.
8512         * unittests/child-path-selftests.c: New file.
8513
8514 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8515
8516         * symfile.c (find_separate_debug_file): Look for separate debug
8517         files in debug directories under the sysroot.
8518
8519 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8520
8521         * symtab.h (struct minimal_symbol data_p): New const method.
8522         (struct minimal_symbol text_p): Likewise.
8523         * symtab.c (output_source_filename): Use file name style
8524         to print file name.
8525         (print_symbol_info): Likewise.
8526         (print_msymbol_info): Use address style to print addresses.
8527         Use function name style to print executable text symbols.
8528         (expand_symtab_containing_pc): Use data_p.
8529         (find_pc_sect_compunit_symtab): Likewise.
8530
8531 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8532
8533         * breakpoint.c (describe_other_breakpoints): Use address style
8534         to print addresses.
8535         (say_where): Likewise.
8536
8537 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8538
8539         * ada-typeprint.c (print_func_type): Print function name
8540         style to print function name.
8541         * c-typeprint.c (c_print_type_1): Likewise.
8542
8543 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8544
8545         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8546         for execve.
8547
8548 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8549
8550         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8551         type_stack.
8552
8553 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8554
8555         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8556         TYPE_CODE_REF types.
8557
8558 2019-02-08  Jim Wilson  <jimw@sifive.com>
8559
8560         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8561         (riscv_linux_fregset): New.
8562         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8563
8564 2019-02-07  Tom Tromey  <tom@tromey.com>
8565
8566         * thread.c (thread_cancel_execution_command): Update.
8567         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8568         methods.
8569         (struct thread_fsm_ops): Remove.
8570         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8571         (thread_fsm_should_stop, thread_fsm_return_value)
8572         (thread_fsm_set_finished, thread_fsm_finished_p)
8573         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8574         Don't declare.
8575         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8576         * infrun.c (clear_proceed_status_thread)
8577         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8578         (print_stop_event): Update.
8579         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8580         Add constructor.
8581         (step_command_fsm_ops): Remove.
8582         (new_step_command_fsm): Remove.
8583         (step_1): Update.
8584         (step_command_fsm::should_stop): Rename from
8585         step_command_fsm_should_stop.
8586         (step_command_fsm::clean_up): Rename from
8587         step_command_fsm_clean_up.
8588         (step_command_fsm::do_async_reply_reason): Rename from
8589         step_command_fsm_async_reply_reason.
8590         (struct until_next_fsm): Inherit from thread_fsm.  Add
8591         constructor.
8592         (until_next_fsm_ops): Remove.
8593         (new_until_next_fsm): Remove.
8594         (until_next_fsm::should_stop): Rename from
8595         until_next_fsm_should_stop.
8596         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8597         (until_next_fsm::do_async_reply_reason): Rename from
8598         until_next_fsm_async_reply_reason.
8599         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8600         constructor.  Change type of breakpoint.
8601         (finish_command_fsm_ops): Remove.
8602         (new_finish_command_fsm): Remove.
8603         (finish_command_fsm::should_stop): Rename from
8604         finish_command_fsm_should_stop.
8605         (finish_command_fsm::clean_up): Rename from
8606         finish_command_fsm_clean_up.
8607         (finish_command_fsm::return_value): Rename from
8608         finish_command_fsm_return_value.
8609         (finish_command_fsm::do_async_reply_reason): Rename from
8610         finish_command_fsm_async_reply_reason.
8611         (finish_command): Update.
8612         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8613         Add constructor.
8614         (call_thread_fsm_ops): Remove.
8615         (call_thread_fsm::call_thread_fsm): Rename from
8616         new_call_thread_fsm.
8617         (call_thread_fsm::should_stop): Rename from
8618         call_thread_fsm_should_stop.
8619         (call_thread_fsm::should_notify_stop): Rename from
8620         call_thread_fsm_should_notify_stop.
8621         (run_inferior_call, call_function_by_hand_dummy): Update.
8622         * cli/cli-interp.c (should_print_stop_to_console): Update.
8623         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8624         Add constructor.  Change type of location_breakpoint,
8625         caller_breakpoint.
8626         (until_break_fsm_ops): Remove.
8627         (new_until_break_fsm): Remove.
8628         (until_break_fsm::should_stop): Rename from
8629         until_break_fsm_should_stop.
8630         (until_break_fsm::clean_up): Rename from
8631         until_break_fsm_clean_up.
8632         (until_break_fsm::do_async_reply_reason): Rename from
8633         until_break_fsm_async_reply_reason.
8634         (until_break_command): Update.
8635         * thread-fsm.c: Remove.
8636         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8637
8638 2019-02-07  Tom Tromey  <tom@tromey.com>
8639
8640         * yy-remap.h: Add include guard.
8641         * xtensa-tdep.h: Add include guard.
8642         * xcoffread.h: Rename include guard.
8643         * varobj-iter.h: Add include guard.
8644         * tui/tui.h: Rename include guard.
8645         * tui/tui-winsource.h: Rename include guard.
8646         * tui/tui-wingeneral.h: Rename include guard.
8647         * tui/tui-windata.h: Rename include guard.
8648         * tui/tui-win.h: Rename include guard.
8649         * tui/tui-stack.h: Rename include guard.
8650         * tui/tui-source.h: Rename include guard.
8651         * tui/tui-regs.h: Rename include guard.
8652         * tui/tui-out.h: Rename include guard.
8653         * tui/tui-layout.h: Rename include guard.
8654         * tui/tui-io.h: Rename include guard.
8655         * tui/tui-hooks.h: Rename include guard.
8656         * tui/tui-file.h: Rename include guard.
8657         * tui/tui-disasm.h: Rename include guard.
8658         * tui/tui-data.h: Rename include guard.
8659         * tui/tui-command.h: Rename include guard.
8660         * tic6x-tdep.h: Add include guard.
8661         * target/waitstatus.h: Rename include guard.
8662         * target/wait.h: Rename include guard.
8663         * target/target.h: Rename include guard.
8664         * target/resume.h: Rename include guard.
8665         * target-float.h: Rename include guard.
8666         * stabsread.h: Add include guard.
8667         * rs6000-tdep.h: Add include guard.
8668         * riscv-fbsd-tdep.h: Add include guard.
8669         * regformats/regdef.h: Rename include guard.
8670         * record.h: Rename include guard.
8671         * python/python.h: Rename include guard.
8672         * python/python-internal.h: Rename include guard.
8673         * python/py-stopevent.h: Rename include guard.
8674         * python/py-ref.h: Rename include guard.
8675         * python/py-record.h: Rename include guard.
8676         * python/py-record-full.h: Rename include guard.
8677         * python/py-record-btrace.h: Rename include guard.
8678         * python/py-instruction.h: Rename include guard.
8679         * python/py-events.h: Rename include guard.
8680         * python/py-event.h: Rename include guard.
8681         * procfs.h: Add include guard.
8682         * proc-utils.h: Add include guard.
8683         * p-lang.h: Add include guard.
8684         * or1k-tdep.h: Rename include guard.
8685         * observable.h: Rename include guard.
8686         * nto-tdep.h: Rename include guard.
8687         * nat/x86-linux.h: Rename include guard.
8688         * nat/x86-linux-dregs.h: Rename include guard.
8689         * nat/x86-gcc-cpuid.h: Add include guard.
8690         * nat/x86-dregs.h: Rename include guard.
8691         * nat/x86-cpuid.h: Rename include guard.
8692         * nat/ppc-linux.h: Rename include guard.
8693         * nat/mips-linux-watch.h: Rename include guard.
8694         * nat/linux-waitpid.h: Rename include guard.
8695         * nat/linux-ptrace.h: Rename include guard.
8696         * nat/linux-procfs.h: Rename include guard.
8697         * nat/linux-osdata.h: Rename include guard.
8698         * nat/linux-nat.h: Rename include guard.
8699         * nat/linux-namespaces.h: Rename include guard.
8700         * nat/linux-btrace.h: Rename include guard.
8701         * nat/glibc_thread_db.h: Rename include guard.
8702         * nat/gdb_thread_db.h: Rename include guard.
8703         * nat/gdb_ptrace.h: Rename include guard.
8704         * nat/fork-inferior.h: Rename include guard.
8705         * nat/amd64-linux-siginfo.h: Rename include guard.
8706         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8707         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8708         * nat/aarch64-linux.h: Rename include guard.
8709         * nat/aarch64-linux-hw-point.h: Rename include guard.
8710         * mn10300-tdep.h: Add include guard.
8711         * mips-linux-tdep.h: Add include guard.
8712         * mi/mi-parse.h: Rename include guard.
8713         * mi/mi-out.h: Rename include guard.
8714         * mi/mi-main.h: Rename include guard.
8715         * mi/mi-interp.h: Rename include guard.
8716         * mi/mi-getopt.h: Rename include guard.
8717         * mi/mi-console.h: Rename include guard.
8718         * mi/mi-common.h: Rename include guard.
8719         * mi/mi-cmds.h: Rename include guard.
8720         * mi/mi-cmd-break.h: Rename include guard.
8721         * m2-lang.h: Add include guard.
8722         * location.h: Rename include guard.
8723         * linux-record.h: Rename include guard.
8724         * linux-nat.h: Add include guard.
8725         * linux-fork.h: Add include guard.
8726         * i386-darwin-tdep.h: Rename include guard.
8727         * hppa-linux-offsets.h: Add include guard.
8728         * guile/guile.h: Rename include guard.
8729         * guile/guile-internal.h: Rename include guard.
8730         * gnu-nat.h: Rename include guard.
8731         * gdb-stabs.h: Rename include guard.
8732         * frv-tdep.h: Add include guard.
8733         * f-lang.h: Add include guard.
8734         * event-loop.h: Add include guard.
8735         * darwin-nat.h: Rename include guard.
8736         * cp-abi.h: Rename include guard.
8737         * config/sparc/nm-sol2.h: Rename include guard.
8738         * config/nm-nto.h: Rename include guard.
8739         * config/nm-linux.h: Add include guard.
8740         * config/i386/nm-i386gnu.h: Rename include guard.
8741         * config/djgpp/nl_types.h: Rename include guard.
8742         * config/djgpp/langinfo.h: Rename include guard.
8743         * compile/gcc-cp-plugin.h: Add include guard.
8744         * compile/gcc-c-plugin.h: Add include guard.
8745         * compile/compile.h: Rename include guard.
8746         * compile/compile-object-run.h: Rename include guard.
8747         * compile/compile-object-load.h: Rename include guard.
8748         * compile/compile-internal.h: Rename include guard.
8749         * compile/compile-cplus.h: Rename include guard.
8750         * compile/compile-c.h: Rename include guard.
8751         * common/xml-utils.h: Rename include guard.
8752         * common/x86-xstate.h: Rename include guard.
8753         * common/version.h: Rename include guard.
8754         * common/vec.h: Rename include guard.
8755         * common/tdesc.h: Rename include guard.
8756         * common/selftest.h: Rename include guard.
8757         * common/scoped_restore.h: Rename include guard.
8758         * common/scoped_mmap.h: Rename include guard.
8759         * common/scoped_fd.h: Rename include guard.
8760         * common/safe-iterator.h: Rename include guard.
8761         * common/run-time-clock.h: Rename include guard.
8762         * common/refcounted-object.h: Rename include guard.
8763         * common/queue.h: Rename include guard.
8764         * common/ptid.h: Rename include guard.
8765         * common/print-utils.h: Rename include guard.
8766         * common/preprocessor.h: Rename include guard.
8767         * common/pathstuff.h: Rename include guard.
8768         * common/observable.h: Rename include guard.
8769         * common/netstuff.h: Rename include guard.
8770         * common/job-control.h: Rename include guard.
8771         * common/host-defs.h: Rename include guard.
8772         * common/gdb_wait.h: Rename include guard.
8773         * common/gdb_vecs.h: Rename include guard.
8774         * common/gdb_unlinker.h: Rename include guard.
8775         * common/gdb_unique_ptr.h: Rename include guard.
8776         * common/gdb_tilde_expand.h: Rename include guard.
8777         * common/gdb_sys_time.h: Rename include guard.
8778         * common/gdb_string_view.h: Rename include guard.
8779         * common/gdb_splay_tree.h: Rename include guard.
8780         * common/gdb_setjmp.h: Rename include guard.
8781         * common/gdb_ref_ptr.h: Rename include guard.
8782         * common/gdb_optional.h: Rename include guard.
8783         * common/gdb_locale.h: Rename include guard.
8784         * common/gdb_assert.h: Rename include guard.
8785         * common/filtered-iterator.h: Rename include guard.
8786         * common/filestuff.h: Rename include guard.
8787         * common/fileio.h: Rename include guard.
8788         * common/environ.h: Rename include guard.
8789         * common/common-utils.h: Rename include guard.
8790         * common/common-types.h: Rename include guard.
8791         * common/common-regcache.h: Rename include guard.
8792         * common/common-inferior.h: Rename include guard.
8793         * common/common-gdbthread.h: Rename include guard.
8794         * common/common-exceptions.h: Rename include guard.
8795         * common/common-defs.h: Rename include guard.
8796         * common/common-debug.h: Rename include guard.
8797         * common/cleanups.h: Rename include guard.
8798         * common/buffer.h: Rename include guard.
8799         * common/btrace-common.h: Rename include guard.
8800         * common/break-common.h: Rename include guard.
8801         * cli/cli-utils.h: Rename include guard.
8802         * cli/cli-style.h: Rename include guard.
8803         * cli/cli-setshow.h: Rename include guard.
8804         * cli/cli-script.h: Rename include guard.
8805         * cli/cli-interp.h: Rename include guard.
8806         * cli/cli-decode.h: Rename include guard.
8807         * cli/cli-cmds.h: Rename include guard.
8808         * charset-list.h: Add include guard.
8809         * buildsym-legacy.h: Rename include guard.
8810         * bfin-tdep.h: Add include guard.
8811         * ax.h: Rename include guard.
8812         * arm-linux-tdep.h: Add include guard.
8813         * arm-fbsd-tdep.h: Add include guard.
8814         * arch/xtensa.h: Rename include guard.
8815         * arch/tic6x.h: Add include guard.
8816         * arch/i386.h: Add include guard.
8817         * arch/arm.h: Rename include guard.
8818         * arch/arm-linux.h: Rename include guard.
8819         * arch/arm-get-next-pcs.h: Rename include guard.
8820         * arch/amd64.h: Add include guard.
8821         * arch/aarch64-insn.h: Rename include guard.
8822         * arch-utils.h: Rename include guard.
8823         * annotate.h: Add include guard.
8824         * amd64-darwin-tdep.h: Rename include guard.
8825         * aarch64-linux-tdep.h: Add include guard.
8826         * aarch64-fbsd-tdep.h: Add include guard.
8827         * aarch32-linux-nat.h: Add include guard.
8828
8829 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8830
8831         * macrotab.c (macro_define_internal): New function that
8832         factorizes macro_define_object_internal and macro_define_function
8833         code.
8834         (macro_define_object_internal): Use macro_define_internal.
8835         (macro_define_function): Likewise.
8836
8837 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8838
8839         * macrocmd.c (extract_identifier): Return
8840         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8841         callers.
8842
8843 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8844
8845         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8846
8847 2019-02-05  Tom Tromey  <tom@tromey.com>
8848
8849         * target.c (target_stack::unpush): Move assertion earlier.
8850
8851 2019-01-30  Tom Tromey  <tom@tromey.com>
8852
8853         PR python/23615:
8854         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8855         (gdbpy_parse_and_eval): Likewise.
8856         * python/python-internal.h (gdbpy_allow_threads): New class.
8857
8858 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8859
8860         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8861         (aarch64_fbsd_fpregmap): Move earlier.
8862         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8863         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8864         instead of individual calls to trad_frame_set_reg_addr.
8865         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8866         earlier.
8867         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8868         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8869         instead of individual calls to trad_frame_set_reg_addr.
8870
8871 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8872
8873         * CONTRIBUTE: Replace contribution list with wiki link.
8874
8875 2019-01-25  Tom Tromey  <tom@tromey.com>
8876
8877         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8878
8879 2019-01-25  Tom Tromey  <tom@tromey.com>
8880
8881         * xtensa-linux-nat.c: Fix common/ includes.
8882         * xml-support.h: Fix common/ includes.
8883         * xml-support.c: Fix common/ includes.
8884         * x86-linux-nat.c: Fix common/ includes.
8885         * windows-nat.c: Fix common/ includes.
8886         * varobj.h: Fix common/ includes.
8887         * varobj.c: Fix common/ includes.
8888         * value.c: Fix common/ includes.
8889         * valops.c: Fix common/ includes.
8890         * utils.c: Fix common/ includes.
8891         * unittests/xml-utils-selftests.c: Fix common/ includes.
8892         * unittests/utils-selftests.c: Fix common/ includes.
8893         * unittests/unpack-selftests.c: Fix common/ includes.
8894         * unittests/tracepoint-selftests.c: Fix common/ includes.
8895         * unittests/style-selftests.c: Fix common/ includes.
8896         * unittests/string_view-selftests.c: Fix common/ includes.
8897         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8898         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8899         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8900         * unittests/rsp-low-selftests.c: Fix common/ includes.
8901         * unittests/parse-connection-spec-selftests.c: Fix common/
8902         includes.
8903         * unittests/optional-selftests.c: Fix common/ includes.
8904         * unittests/offset-type-selftests.c: Fix common/ includes.
8905         * unittests/observable-selftests.c: Fix common/ includes.
8906         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8907         * unittests/memrange-selftests.c: Fix common/ includes.
8908         * unittests/memory-map-selftests.c: Fix common/ includes.
8909         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8910         * unittests/function-view-selftests.c: Fix common/ includes.
8911         * unittests/environ-selftests.c: Fix common/ includes.
8912         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8913         * unittests/common-utils-selftests.c: Fix common/ includes.
8914         * unittests/cli-utils-selftests.c: Fix common/ includes.
8915         * unittests/array-view-selftests.c: Fix common/ includes.
8916         * ui-file.c: Fix common/ includes.
8917         * tui/tui-io.c: Fix common/ includes.
8918         * tracepoint.h: Fix common/ includes.
8919         * tracepoint.c: Fix common/ includes.
8920         * tracefile-tfile.c: Fix common/ includes.
8921         * top.h: Fix common/ includes.
8922         * top.c: Fix common/ includes.
8923         * thread.c: Fix common/ includes.
8924         * target/waitstatus.h: Fix common/ includes.
8925         * target/waitstatus.c: Fix common/ includes.
8926         * target.h: Fix common/ includes.
8927         * target.c: Fix common/ includes.
8928         * target-memory.c: Fix common/ includes.
8929         * target-descriptions.c: Fix common/ includes.
8930         * symtab.h: Fix common/ includes.
8931         * symfile.c: Fix common/ includes.
8932         * stap-probe.c: Fix common/ includes.
8933         * spu-linux-nat.c: Fix common/ includes.
8934         * sparc-nat.c: Fix common/ includes.
8935         * source.c: Fix common/ includes.
8936         * solib.c: Fix common/ includes.
8937         * solib-target.c: Fix common/ includes.
8938         * ser-unix.c: Fix common/ includes.
8939         * ser-tcp.c: Fix common/ includes.
8940         * ser-pipe.c: Fix common/ includes.
8941         * ser-base.c: Fix common/ includes.
8942         * selftest-arch.c: Fix common/ includes.
8943         * s12z-tdep.c: Fix common/ includes.
8944         * rust-exp.y: Fix common/ includes.
8945         * rs6000-aix-tdep.c: Fix common/ includes.
8946         * riscv-tdep.c: Fix common/ includes.
8947         * remote.c: Fix common/ includes.
8948         * remote-notif.h: Fix common/ includes.
8949         * remote-fileio.h: Fix common/ includes.
8950         * remote-fileio.c: Fix common/ includes.
8951         * regcache.h: Fix common/ includes.
8952         * regcache.c: Fix common/ includes.
8953         * record-btrace.c: Fix common/ includes.
8954         * python/python.c: Fix common/ includes.
8955         * python/py-type.c: Fix common/ includes.
8956         * python/py-inferior.c: Fix common/ includes.
8957         * progspace.h: Fix common/ includes.
8958         * producer.c: Fix common/ includes.
8959         * procfs.c: Fix common/ includes.
8960         * proc-api.c: Fix common/ includes.
8961         * printcmd.c: Fix common/ includes.
8962         * ppc-linux-nat.c: Fix common/ includes.
8963         * parser-defs.h: Fix common/ includes.
8964         * osdata.c: Fix common/ includes.
8965         * obsd-nat.c: Fix common/ includes.
8966         * nat/x86-linux.c: Fix common/ includes.
8967         * nat/x86-linux-dregs.c: Fix common/ includes.
8968         * nat/x86-dregs.h: Fix common/ includes.
8969         * nat/x86-dregs.c: Fix common/ includes.
8970         * nat/ppc-linux.c: Fix common/ includes.
8971         * nat/mips-linux-watch.h: Fix common/ includes.
8972         * nat/mips-linux-watch.c: Fix common/ includes.
8973         * nat/linux-waitpid.c: Fix common/ includes.
8974         * nat/linux-ptrace.h: Fix common/ includes.
8975         * nat/linux-ptrace.c: Fix common/ includes.
8976         * nat/linux-procfs.c: Fix common/ includes.
8977         * nat/linux-personality.c: Fix common/ includes.
8978         * nat/linux-osdata.c: Fix common/ includes.
8979         * nat/linux-namespaces.c: Fix common/ includes.
8980         * nat/linux-btrace.h: Fix common/ includes.
8981         * nat/linux-btrace.c: Fix common/ includes.
8982         * nat/fork-inferior.c: Fix common/ includes.
8983         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8984         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8985         * nat/aarch64-linux.c: Fix common/ includes.
8986         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8987         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8988         * namespace.h: Fix common/ includes.
8989         * mips-linux-tdep.c: Fix common/ includes.
8990         * minsyms.c: Fix common/ includes.
8991         * mi/mi-parse.h: Fix common/ includes.
8992         * mi/mi-main.c: Fix common/ includes.
8993         * mi/mi-cmd-env.c: Fix common/ includes.
8994         * memrange.h: Fix common/ includes.
8995         * memattr.c: Fix common/ includes.
8996         * maint.h: Fix common/ includes.
8997         * maint.c: Fix common/ includes.
8998         * main.c: Fix common/ includes.
8999         * machoread.c: Fix common/ includes.
9000         * location.c: Fix common/ includes.
9001         * linux-thread-db.c: Fix common/ includes.
9002         * linux-nat.c: Fix common/ includes.
9003         * linux-fork.c: Fix common/ includes.
9004         * inline-frame.c: Fix common/ includes.
9005         * infrun.c: Fix common/ includes.
9006         * inflow.c: Fix common/ includes.
9007         * inferior.h: Fix common/ includes.
9008         * inferior.c: Fix common/ includes.
9009         * infcmd.c: Fix common/ includes.
9010         * inf-ptrace.c: Fix common/ includes.
9011         * inf-child.c: Fix common/ includes.
9012         * ia64-linux-nat.c: Fix common/ includes.
9013         * i387-tdep.c: Fix common/ includes.
9014         * i386-tdep.c: Fix common/ includes.
9015         * i386-linux-tdep.c: Fix common/ includes.
9016         * i386-linux-nat.c: Fix common/ includes.
9017         * i386-go32-tdep.c: Fix common/ includes.
9018         * i386-fbsd-tdep.c: Fix common/ includes.
9019         * i386-fbsd-nat.c: Fix common/ includes.
9020         * guile/scm-type.c: Fix common/ includes.
9021         * guile/guile.c: Fix common/ includes.
9022         * go32-nat.c: Fix common/ includes.
9023         * gnu-nat.c: Fix common/ includes.
9024         * gdbthread.h: Fix common/ includes.
9025         * gdbarch-selftests.c: Fix common/ includes.
9026         * gdb_usleep.c: Fix common/ includes.
9027         * gdb_select.h: Fix common/ includes.
9028         * gdb_bfd.c: Fix common/ includes.
9029         * gcore.c: Fix common/ includes.
9030         * fork-child.c: Fix common/ includes.
9031         * findvar.c: Fix common/ includes.
9032         * fbsd-nat.c: Fix common/ includes.
9033         * event-top.c: Fix common/ includes.
9034         * event-loop.c: Fix common/ includes.
9035         * dwarf2read.c: Fix common/ includes.
9036         * dwarf2loc.c: Fix common/ includes.
9037         * dwarf2-frame.c: Fix common/ includes.
9038         * dwarf-index-cache.c: Fix common/ includes.
9039         * dtrace-probe.c: Fix common/ includes.
9040         * disasm-selftests.c: Fix common/ includes.
9041         * defs.h: Fix common/ includes.
9042         * csky-tdep.c: Fix common/ includes.
9043         * cp-valprint.c: Fix common/ includes.
9044         * cp-support.h: Fix common/ includes.
9045         * cp-support.c: Fix common/ includes.
9046         * corelow.c: Fix common/ includes.
9047         * completer.h: Fix common/ includes.
9048         * completer.c: Fix common/ includes.
9049         * compile/compile.c: Fix common/ includes.
9050         * compile/compile-loc2c.c: Fix common/ includes.
9051         * compile/compile-cplus-types.c: Fix common/ includes.
9052         * compile/compile-cplus-symbols.c: Fix common/ includes.
9053         * command.h: Fix common/ includes.
9054         * cli/cli-dump.c: Fix common/ includes.
9055         * cli/cli-cmds.c: Fix common/ includes.
9056         * charset.c: Fix common/ includes.
9057         * build-id.c: Fix common/ includes.
9058         * btrace.h: Fix common/ includes.
9059         * btrace.c: Fix common/ includes.
9060         * breakpoint.h: Fix common/ includes.
9061         * breakpoint.c: Fix common/ includes.
9062         * ax.h:
9063         (enum agent_op): Fix common/ includes.
9064         * ax-general.c (struct aop_map): Fix common/ includes.
9065         * ax-gdb.c: Fix common/ includes.
9066         * auxv.c: Fix common/ includes.
9067         * auto-load.c: Fix common/ includes.
9068         * arm-tdep.c: Fix common/ includes.
9069         * arch/riscv.c: Fix common/ includes.
9070         * arch/ppc-linux-common.c: Fix common/ includes.
9071         * arch/i386.c: Fix common/ includes.
9072         * arch/arm.c: Fix common/ includes.
9073         * arch/arm-linux.c: Fix common/ includes.
9074         * arch/arm-get-next-pcs.c: Fix common/ includes.
9075         * arch/amd64.c: Fix common/ includes.
9076         * arch/aarch64.c: Fix common/ includes.
9077         * arch/aarch64-insn.c: Fix common/ includes.
9078         * arch-utils.c: Fix common/ includes.
9079         * amd64-windows-tdep.c: Fix common/ includes.
9080         * amd64-tdep.c: Fix common/ includes.
9081         * amd64-sol2-tdep.c: Fix common/ includes.
9082         * amd64-obsd-tdep.c: Fix common/ includes.
9083         * amd64-nbsd-tdep.c: Fix common/ includes.
9084         * amd64-linux-tdep.c: Fix common/ includes.
9085         * amd64-linux-nat.c: Fix common/ includes.
9086         * amd64-fbsd-tdep.c: Fix common/ includes.
9087         * amd64-fbsd-nat.c: Fix common/ includes.
9088         * amd64-dicos-tdep.c: Fix common/ includes.
9089         * amd64-darwin-tdep.c: Fix common/ includes.
9090         * agent.c: Fix common/ includes.
9091         * ada-lang.h: Fix common/ includes.
9092         * ada-lang.c: Fix common/ includes.
9093         * aarch64-tdep.c: Fix common/ includes.
9094
9095 2019-01-25  Tom Tromey  <tom@tromey.com>
9096
9097         * common/create-version.sh: Use common/version.h.
9098
9099 2019-01-24  Pedro Alves  <palves@redhat.com>
9100
9101         * infrun.c (signal_stop, signal_print, signal_program)
9102         (signal_catch, signal_pass): Now arrays instead of pointers.
9103         (update_signals_program_target, do_target_resume)
9104         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9105         * linux-nat.c (linux_nat_target::pass_signals)
9106         (linux_nat_target::create_inferior, linux_nat_target::attach):
9107         Adjust.
9108         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9109         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9110         * procfs.c (procfs_target::pass_signals): Adjust.
9111         * record-full.c (record_full_target::resume): Adjust.
9112         * remote.c (remote_target::pass_signals)
9113         (remote_target::program_signals): Adjust.
9114         * target-debug.h (target_debug_print_signals): Now takes a
9115         gdb::array_view as parameter.  Adjust.
9116         * target.h (target_ops) <pass_signals, program_signals>: Replace
9117         pointer and length parameters with gdb::array_view.
9118         (target_pass_signals, target_program_signals): Likewise.
9119         * target-delegates.c: Regenerate.
9120
9121 2019-01-24  Pedro Alves  <palves@redhat.com>
9122
9123         * common/forward-scope-exit.h
9124         (forward_scope_exit::forward_scope_exit): Pass arguments to
9125         m_bind_function directly, instead of creating a std::bind and
9126         copying that.
9127
9128 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9129
9130         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9131         for static members.
9132         (pass_in_v_vfp_candidate): Likewise.
9133
9134 2019-01-23  Tom Tromey  <tom@tromey.com>
9135             Pedro Alves  <palves@redhat.com>
9136
9137         * regcache.c (class regcache_invalidator): Remove.
9138         (regcache::raw_write): Use make_scope_exit.
9139
9140 2019-01-23  Tom Tromey  <tom@tromey.com>
9141
9142         * ui-out.h (class ui_out_emit_type): Update comment.
9143
9144 2019-01-23  Tom Tromey  <tom@tromey.com>
9145
9146         * infrun.c (fetch_inferior_event): Update comment.
9147
9148 2019-01-23  Tom Tromey  <tom@tromey.com>
9149             Pedro Alves  <palves@redhat.com>
9150
9151         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9152         parameter.
9153         (fetch_inferior_event): Use SCOPE_EXIT.
9154
9155
9156 2019-01-23  Tom Tromey  <tom@tromey.com>
9157             Pedro Alves  <palves@redhat.com>
9158
9159         * infrun.c (disable_thread_events): Delete.
9160         (stop_all_threads): Use SCOPE_EXIT.
9161
9162 2019-01-23  Tom Tromey  <tom@tromey.com>
9163             Pedro Alves  <palves@redhat.com>
9164
9165         * symfile.c: Include forward-scope-exit.h.
9166         (clear_symtab_users_cleanup): Replace forward declaration with
9167         a FORWARD_SCOPE_EXIT.
9168         (syms_from_objfile_1): Use the forward_scope_exit and
9169         gdb::optional instead of cleanup_function.
9170         (reread_symbols): Use the forward_scope_exit instead of
9171         cleanup_function.
9172         (clear_symtab_users_cleanup): Remove function.
9173
9174 2019-01-23  Tom Tromey  <tom@tromey.com>
9175             Pedro Alves  <palves@redhat.com>
9176
9177         * linux-nat.c: Include scope-exit.h.
9178         (cleanup_target_stop): Remove.
9179         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9180         SCOPE_EXIT.
9181
9182 2019-01-23  Tom Tromey  <tom@tromey.com>
9183             Pedro Alves  <palves@redhat.com>
9184
9185         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9186         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9187
9188 2019-01-23  Tom Tromey  <tom@tromey.com>
9189             Andrew Burgess  <andrew.burgess@embecosm.com>
9190             Pedro Alves  <palves@redhat.com>
9191
9192         * infrun.c (fetch_inferior_event): Use scope_exit.
9193         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9194         * top.c (execute_command): Use scope_exit.
9195         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9196         * utils.c (do_bpstat_clear_actions_cleanup)
9197         (make_bpstat_clear_actions_cleanup): Remove.
9198
9199 2019-01-23  Tom Tromey  <tom@tromey.com>
9200             Pedro Alves  <palves@redhat.com>
9201
9202         * infrun.c: Include "common/scope-exit.h"
9203         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9204         (wait_for_inferior): Use SCOPE_EXIT.
9205         (fetch_inferior_event): Use scope_exit.
9206
9207 2019-01-23  Tom Tromey  <tom@tromey.com>
9208             Pedro Alves  <palves@redhat.com>
9209
9210         * breakpoint.c (create_breakpoint): Remove cleanup.
9211
9212 2019-01-23  Tom Tromey  <tom@tromey.com>
9213             Andrew Burgess  <andrew.burgess@embecosm.com>
9214             Pedro Alves  <palves@redhat.com>
9215
9216 2019-01-23  Pedro Alves  <palves@redhat.com>
9217
9218         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9219
9220 2019-01-23  Pedro Alves  <palves@redhat.com>
9221             Andrew Burgess  <andrew.burgess@embecosm.com>
9222
9223         * gdbthread.h: Include "common/forward-scope-exit.h".
9224         (scoped_finish_thread_state): Redefine custom class in terms of
9225         forward_scope_exit.
9226
9227 2019-01-23  Pedro Alves  <palves@redhat.com>
9228             Andrew Burgess  <andrew.burgess@embecosm.com>
9229
9230         * common/forward-scope-exit.h: New file.
9231
9232 2019-01-23  Pedro Alves  <palves@redhat.com>
9233             Andrew Burgess  <andrew.burgess@embecosm.com>
9234             Tom Tromey  <tom@tromey.com>
9235
9236         * common/scope-exit.h: New file.
9237
9238 2019-01-23  Pedro Alves  <palves@redhat.com>
9239
9240         * common/preprocessor.h (ESC): Rename to ...
9241         (ESC_PARENS): ... this.
9242         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9243         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9244
9245 2019-01-23  Tom Tromey  <tom@tromey.com>
9246
9247         * language.h (class scoped_switch_to_sym_language_if_auto):
9248         Initialize m_lang in both cases.
9249
9250 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9251
9252         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9253         with XCNEW.
9254
9255 2019-01-22  Tom Tromey  <tom@tromey.com>
9256
9257         * corelow.c: Do not include sys/file.h.
9258
9259 2019-01-22  Tom Tromey  <tom@tromey.com>
9260
9261         * tui/tui-wingeneral.h: Include gdb_curses.h.
9262
9263 2019-01-22  Tom Tromey  <tom@tromey.com>
9264
9265         * source-cache.h (class source_cache) <get_source_lines,
9266         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9267
9268 2019-01-22  Tom Tromey  <tom@tromey.com>
9269
9270         * remote-fileio.h (struct remote_target): Declare.
9271
9272 2019-01-22  Tom Tromey  <tom@tromey.com>
9273
9274         * python/py-arch.c: Do not include py-ref.h.
9275         * python/py-bpevent.c: Do not include py-ref.h.
9276         * python/py-cmd.c: Do not include py-ref.h.
9277         * python/py-continueevent.c: Do not include py-ref.h.
9278         * python/py-event.h: Do not include py-ref.h.
9279         * python/py-evtregistry.c: Do not include py-ref.h.
9280         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9281         * python/py-frame.c: Do not include py-ref.h.
9282         * python/py-framefilter.c: Do not include py-ref.h.
9283         * python/py-function.c: Do not include py-ref.h.
9284         * python/py-infevents.c: Do not include py-ref.h.
9285         * python/py-linetable.c: Do not include py-ref.h.
9286         * python/py-objfile.c: Do not include py-ref.h.
9287         * python/py-param.c: Do not include py-ref.h.
9288         * python/py-prettyprint.c: Do not include py-ref.h.
9289         * python/py-progspace.c: Do not include py-ref.h.
9290         * python/py-symbol.c: Do not include py-ref.h.
9291         * python/py-symtab.c: Do not include py-ref.h.
9292         * python/py-type.c: Do not include py-ref.h.
9293         * python/py-unwind.c: Do not include py-ref.h.
9294         * python/py-utils.c: Do not include py-ref.h.
9295         * python/py-value.c: Do not include py-ref.h.
9296         * python/py-varobj.c: Do not include py-ref.h.
9297         * python/py-xmethods.c: Do not include py-ref.h.
9298         * python/python.c: Do not include py-ref.h.
9299         * varobj.c: Do not include py-ref.h.
9300
9301 2019-01-22  Tom Tromey  <tom@tromey.com>
9302
9303         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9304         keyword for bcache.
9305
9306 2019-01-22  Tom Tromey  <tom@tromey.com>
9307
9308         * compile/compile-cplus-types.c: Remove a comment by #include.
9309
9310 2019-01-22  Tom Tromey  <tom@tromey.com>
9311
9312         * compile/gcc-c-plugin.h: Include compile-internal.h.
9313
9314 2019-01-22  Tom Tromey  <tom@tromey.com>
9315
9316         * stabsread.c (EXTERN): Do not define.
9317         (symnum, next_symbol_text_func, processing_gcc_compilation)
9318         (within_function, global_sym_chain, global_stabs)
9319         (previous_stab_code, this_object_header_files)
9320         (n_this_object_header_files)
9321         (n_allocated_this_object_header_files): Define.
9322         * stabsread.h (EXTERN): Never define.  Use "extern".
9323
9324 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9325
9326         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9327         history_value.
9328
9329 2019-01-21  Tom Tromey  <tom@tromey.com>
9330
9331         * ui-out.c: Fix includes.
9332         * tui/tui-source.c: Fix includes.
9333         * target.c: Fix includes.
9334         * remote.c: Fix includes.
9335         * regcache.c: Fix includes.
9336         * python/py-block.c: Fix includes.
9337         * printcmd.c: Fix includes.
9338         * or1k-tdep.c: Fix includes.
9339         * mi/mi-main.c: Fix includes.
9340         * m32r-tdep.c: Fix includes.
9341         * csky-tdep.c: Fix includes.
9342         * compile/compile-cplus-types.c: Fix includes.
9343         * cli/cli-interp.c: Fix includes.
9344
9345 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9346
9347         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9348         for padding.
9349
9350 2019-01-16  Tom Tromey  <tom@tromey.com>
9351
9352         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9353         earlier.
9354         (struct objfile) <msymbols_range>: Move from top level.
9355         <msymbols>: New method.
9356         (class objfile_msymbols): Remove.
9357         * symtab.c (default_collect_symbol_completion_matches_break_on):
9358         Update.
9359         * symmisc.c (dump_msymbols): Update.
9360         * stabsread.c (scan_file_globals): Update.
9361         * objc-lang.c (info_selectors_command, info_classes_command)
9362         (find_methods): Update.
9363         * minsyms.c (find_solib_trampoline_target): Update.
9364         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9365         * coffread.c (coff_symfile_read): Update.
9366         * ada-lang.c (ada_lookup_simple_minsym)
9367         (ada_collect_symbol_completion_matches): Update.
9368
9369 2019-01-16  Tom Tromey  <tom@tromey.com>
9370
9371         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9372         type.  Remove no-argument constructor.
9373         <iterator::operator++>: Simplify.
9374         <begin>: Update.
9375         <end>: Use minimal_symbol_count.
9376
9377 2019-01-16  Tom Tromey  <tom@tromey.com>
9378
9379         * objfiles.h (struct objfile) <psymtabs>: New method.
9380         (class objfile_psymtabs): Remove.
9381         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9382         typedef.
9383         <range>: New method.
9384         (require_partial_symbols): Change return type.
9385         * psymtab.c (require_partial_symbols)
9386         (psym_expand_symtabs_matching): Update.
9387         * mdebugread.c (parse_partial_symbols): Update.
9388         * dbxread.c (dbx_end_psymtab): Update.
9389
9390 2019-01-15  Tom Tromey  <tom@tromey.com>
9391
9392         * symtab.c (lookup_objfile_from_block)
9393         (lookup_symbol_in_objfile_symtabs)
9394         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9395         (find_line_symtab, info_sources_command)
9396         (default_collect_symbol_completion_matches_break_on)
9397         (make_source_files_completion_list): Update.
9398         * symmisc.c (print_objfile_statistics, dump_objfile)
9399         (maintenance_print_symbols, maintenance_info_symtabs)
9400         (maintenance_check_symtabs, maintenance_info_line_tables):
9401         Update.
9402         * source.c (select_source_symtab)
9403         (forget_cached_source_info_for_objfile): Update.
9404         * objfiles.h (class objfile_compunits): Remove.
9405         (struct objfile) <compunits_range>: New typedef.
9406         (compunits): New method.
9407         * objfiles.c (objfile_relocate1): Update.
9408         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9409         * maint.c (count_symtabs_and_blocks): Update.
9410         * linespec.c (iterate_over_all_matching_symtabs): Update.
9411         * cp-support.c (add_symbol_overload_list_qualified): Update.
9412         * coffread.c (coff_symtab_read): Update.
9413         * ada-lang.c (add_nonlocal_symbols)
9414         (ada_collect_symbol_completion_matches)
9415         (ada_add_global_exceptions): Update.
9416
9417 2019-01-15  Tom Tromey  <tom@tromey.com>
9418
9419         * progspace.h (program_space) <objfiles_safe_range>: New
9420         typedef.
9421         <objfiles_safe>: New method.
9422         * objfiles.h (class all_objfiles_safe): Remove.
9423         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9424         * jit.c (jit_inferior_exit_hook): Update.
9425
9426 2019-01-17  Tom Tromey  <tom@tromey.com>
9427
9428         * progspace.h (program_space) <objfiles_range>: New typedef.
9429         <objfiles>: New method.
9430         <objfiles_head>: Rename from objfiles.
9431         (object_files): Update.
9432         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9433         * guile/scm-pretty-print.c
9434         (ppscm_find_pretty_printer_from_objfiles): Update.
9435         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9436         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9437         Update.
9438         * python/py-progspace.c (pspy_get_objfiles): Update.
9439         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9440         Update.
9441         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9442         (objfpy_lookup_objfile_by_build_id): Update.
9443         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9444         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9445         Update.
9446         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9447         (expand_symtab_containing_pc, lookup_objfile_from_block)
9448         (lookup_static_symbol, basic_lookup_transparent_type)
9449         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9450         (find_line_symtab, info_sources_command)
9451         (default_collect_symbol_completion_matches_break_on)
9452         (make_source_files_completion_list, find_main_name): Update.
9453         * symmisc.c (print_symbol_bcache_statistics)
9454         (print_objfile_statistics, maintenance_print_symbols)
9455         (maintenance_print_msymbols, maintenance_print_objfiles)
9456         (maintenance_info_symtabs, maintenance_check_symtabs)
9457         (maintenance_expand_symtabs, maintenance_info_line_tables):
9458         Update.
9459         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9460         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9461         (map_overlay_command, unmap_overlay_command)
9462         (simple_overlay_update, expand_symtabs_matching)
9463         (map_symbol_filenames): Update.
9464         * symfile-debug.c (set_debug_symfile): Update.
9465         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9466         Update.
9467         * source.c (select_source_symtab, forget_cached_source_info):
9468         Update.
9469         * solib.c (solib_read_symbols): Update.
9470         * solib-spu.c (append_ocl_sos): Update.
9471         * psymtab.c (maintenance_print_psymbols)
9472         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9473         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9474         * printcmd.c (info_symbol_command): Update.
9475         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9476         Update.
9477         * objfiles.h (class all_objfiles): Remove.
9478         * objfiles.c (have_partial_symbols, have_full_symbols)
9479         (have_minimal_symbols, qsort_cmp, update_section_map)
9480         (shared_objfile_contains_address_p)
9481         (default_iterate_over_objfiles_in_search_order): Update.
9482         * objc-lang.c (info_selectors_command, info_classes_command)
9483         (find_methods): Update.
9484         * minsyms.c (find_solib_trampoline_target): Update.
9485         * maint.c (maintenance_info_sections)
9486         (maintenance_translate_address, count_symtabs_and_blocks):
9487         Update.
9488         * main.c (captured_main_1): Update.
9489         * linux-thread-db.c (try_thread_db_load_from_pdir)
9490         (has_libpthread): Update.
9491         * linespec.c (iterate_over_all_matching_symtabs)
9492         (search_minsyms_for_name): Update.
9493         * jit.c (jit_find_objf_with_entry_addr): Update.
9494         * hppa-tdep.c (find_unwind_entry)
9495         (hppa_lookup_stub_minimal_symbol): Update.
9496         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9497         Update.
9498         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9499         (elf_gnu_ifunc_resolve_by_got): Update.
9500         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9501         * dwarf-index-write.c (save_gdb_index_command): Update.
9502         * cp-support.c (add_symbol_overload_list_qualified): Update.
9503         * breakpoint.c (create_overlay_event_breakpoint)
9504         (create_longjmp_master_breakpoint)
9505         (create_std_terminate_master_breakpoint)
9506         (create_exception_master_breakpoint): Update.
9507         * blockframe.c (find_pc_partial_function): Update.
9508         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9509         (ada_collect_symbol_completion_matches)
9510         (ada_add_global_exceptions): Update.
9511
9512 2019-01-17  Tom Tromey  <tom@tromey.com>
9513
9514         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9515         declare VEC.
9516         (solib_target_parse_libraries): Change return type.
9517         (library_list_start_segment, library_list_start_section)
9518         (library_list_end_library, library_list_start_library); Update.
9519         (solib_target_free_library_list): Remove.
9520         (solib_target_parse_libraries): Remove cleanup.  Change return
9521         type.
9522         (solib_target_current_sos): Update.
9523
9524 2019-01-17  Tom Tromey  <tromey@bapiya>
9525
9526         * valprint.c: Replace "the the" with "the".
9527         * symtab.c: Replace "the the" with "the".
9528         * solib.c: Replace "the the" with "the".
9529         * solib-dsbt.c: Replace "the the" with "the".
9530         * linespec.c: Replace "the the" with "the".
9531         * dwarf2loc.h: Replace "the the" with "the".
9532         * amd64-windows-tdep.c: Replace "the the" with "the".
9533         * aarch64-tdep.c: Replace "the the" with "the".
9534
9535 2019-01-16  Keith Seitz  <keiths@redhat.com>
9536
9537         PR gdb/23773
9538         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9539         <builder>: Rename to ..
9540         <m_builder>: ... this and make private.
9541         (dwarf2_cu::get_builder): New method.  Change all users of
9542         `builder' to use this method.
9543         (dwarf2_start_symtab): Move to ...
9544         (dwarf2_cu::start_symtab): ... here.  Update all callers
9545         (setup_type_unit_groups): Move to ...
9546         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9547         callers.
9548         (dwarf2_cu::reset_builder): New method.
9549         (process_full_compunit, process_full_type_unit): Use
9550         dwarf2_cu::reset_builder.
9551         (follow_die_offset): Record the ancestor CU if it is different
9552         from the followed DIE's CU.
9553         (follow_die_sig_1): Likewise.
9554
9555 2019-01-15  Tom Tromey  <tom@tromey.com>
9556
9557         * remote.c (class remote_state) <buf>: Now a char_vector.
9558         <buf_size>: Remove.
9559         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9560         parameter.
9561         (remote_target::getpkt_or_notif_sane_1)
9562         (remote_target::getpkt_sane)
9563         (remote_target::getpkt_or_notif_sane): Likewise.
9564         (class remote_target) <putpkt>: New overload.
9565         (remote_target::read_frame): Change type of "buf_p".  Remove
9566         sizeof_p parameter.
9567         (packet_ok): New overload.
9568         (packet_check_result): New overload.
9569         Update all uses.
9570
9571 2019-01-14  Tom Tromey  <tom@tromey.com>
9572
9573         * remote-notif.c (handle_notification, remote_notif_ack)
9574         (remote_notif_parse): Make "buf" const.
9575         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9576         const.
9577         (remote_notif_parse, remote_notif_ack, handle_notification):
9578         Likewise.
9579         * remote.c (remote_notif_stop_parse): Make "buf" const.
9580         (remote_target::remote_parse_stop_reply): Make "buf" const.
9581         (remote_notif_stop_ack): Make "buf" const.
9582
9583 2019-01-14  Tom Tromey  <tom@tromey.com>
9584
9585         * remote.c (remote_console_output): Make parameter const.
9586
9587 2019-01-14  Tom Tromey  <tom@tromey.com>
9588
9589         * target-debug.h (target_debug_print_signals): Constify.
9590         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9591         * procfs.c (procfs_target::pass_signals): Update.
9592         * linux-nat.c (linux_nat_target::pass_signals): Update.
9593         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9594         * target-delegates.c: Rebuild.
9595         * remote.c (remote_target::program_signals): Update.
9596         (remote_target::pass_signals): Update.
9597         * target.c (target_pass_signals): Constify argument.
9598         (target_program_signals): Likewise.
9599         * target.h (struct target_ops) <pass_signals, program_signals>:
9600         Constify argument.
9601         (target_pass_signals, target_program_signals): Constify argument.
9602
9603 2019-01-14  Tom Tromey  <tom@tromey.com>
9604
9605         PR tui/28819:
9606         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9607
9608 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9609
9610         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9611         field.
9612         * rs6000-tdep.c: Include reggroups.h.
9613         (IS_V_ALIAS_PSEUDOREG): Define.
9614         (rs6000_register_name): Return names for the "vX" aliases.
9615         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9616         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9617         aliases.  Call default_register_reggroup_p for all other
9618         pseudo-registers.
9619         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9620         New functions.
9621         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9622         Handle "vX" aliases.
9623         (v_alias_pseudo_register_collect): New function.
9624         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9625         (rs6000_gdbarch_init): Initialize "vX" aliases as
9626         pseudo-registers.  Restore registration of
9627         rs6000_pseudo_register_reggroup_p with
9628         set_tdesc_pseudo_register_reggroup_p.
9629
9630 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9631
9632         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9633         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9634         set_gdbarch_num_pseudo_regs.
9635
9636 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9637
9638         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9639         Remove arg prefixname, add do_set and do_show.
9640         Add member functions set_list and show_list.
9641         * cli/cli-style.c (class cli_style_option): Update accordingly.
9642         (style_set_list): Move to file scope.
9643         (style_show_list): Likewise.
9644         (set_style): Call help_list.
9645         (show_style): Call cmd_show_list.
9646         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9647         Update to use the new macro.
9648
9649 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9650
9651         * ada-lang.c (_initialize_ada_language): Expand the help text
9652         for the "catch exception" command.
9653
9654 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9655
9656         * symtab.c (matching_obj_sections): Initialize obj,
9657         declare it closer to its usage.
9658
9659 2019-01-10  Tom Tromey  <tom@tromey.com>
9660
9661         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9662         (basic_inf_threads_range): Remove.
9663         (inf_threads_range, inf_non_exited_threads_range)
9664         (safe_inf_threads_range): Use next_adapter.
9665
9666 2019-01-10  Keith Seitz  <keiths@redhat.com>
9667
9668         PR gdb/23712
9669         PR symtab/23010
9670         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9671         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9672
9673 2019-01-10  Keith Seitz  <keiths@redhat.com>
9674
9675         PR gdb/23712
9676         PR symtab/23010
9677         * dictionary.c (pending_to_vector): Remove.
9678         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9679         Remove _1 suffix, replacing functions of the same name.  Update
9680         all callers.
9681         (dict_create_hashed, dict_create_hashed_expandable)
9682         (dict_create_linear, dict_create_linear_expandable, dict_free)
9683         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9684         Make functions static.
9685
9686 2019-01-10  Keith Seitz  <keiths@redhat.com>
9687
9688         PR gdb/23712
9689         PR symtab/23010
9690         * dictionary.h (struct dictionary): Replace declaration with
9691         multidictionary.
9692         (dict_create_hashed, dict_create_hashed_expandable)
9693         (dict_create_linear, dict_create_linear_expandable)
9694         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9695         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9696         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9697         taking multidictionary argument.
9698         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9699         * block.h (struct block) <dict>: Change to multidictionary
9700         and rename `multidict'.
9701         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9702         symmisc.c: Update all dictionary references to multidictionary.
9703
9704 2019-01-10  Keith Seitz  <keiths@redhat.com>
9705
9706         PR gdb/23712
9707         PR symtab/23010
9708         * dictionary.c: Include unordered_map.
9709         (pending_to_vector): New function.
9710         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9711         Rewrite the non-"_1" functions to take vector instead
9712         of linked list.
9713         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9714         "new" _1 versions of the same name.
9715         (multidictionary): Define.
9716         (std::hash<enum language): New definition.
9717         (collate_pending_symbols_by_language, mdict_create_hashed)
9718         (mdict_create_hashed_expandable, mdict_create_linear)
9719         (mdict_create_linear_expandable, mdict_free)
9720         (find_language_dictionary, create_new_language_dictionary)
9721         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9722         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9723         (mdict_size, mdict_empty): New functions.
9724         * dictionary.h (mdict_iterator): Define.
9725
9726 2019-01-10  Pedro Alves  <palves@redhat.com>
9727
9728         * breakpoint.c (read_uploaded_action)
9729         (create_tracepoint_from_upload): Adjust to use
9730         gdb::unique_xmalloc_ptr.
9731         * ctf.c (ctf_write_uploaded_tp):
9732         (SET_ARRAY_FIELD): Use emplace_back.
9733         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9734         * tracefile-tfile.c (tfile_write_uploaded_tp):
9735         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9736         gdb::unique_xmalloc_ptr.
9737         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9738         at_string, cond_string, cmd_strings>: Replace char pointers
9739         with gdb::unique_xmalloc_ptr.
9740
9741 2019-01-10  Pedro Alves  <palves@redhat.com>
9742
9743         * solib-target.c (library_list_start_library): Don't xstrdup name.
9744
9745 2019-01-10  Pedro Alves  <palves@redhat.com>
9746
9747         * mdebugread.c (parse_partial_symbols): Use
9748         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9749
9750 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9751
9752         * linux-fork.c (scoped_switch_fork_info)
9753         <~scoped_switch_fork_info>: Fix incorrect variable name.
9754
9755 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9756
9757         * linux-fork.c (scoped_switch_fork_info)
9758         <scoped_switch_fork_info>: Make explicit.
9759         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9760
9761 2019-01-10  Tom Tromey  <tom@tromey.com>
9762
9763         * objfiles.h (objfile::reset_psymtabs): Update.
9764         * objfiles.c (objfile::objfile): Update.
9765         * psymtab.h (psymtab_storage::obstack): Update.
9766         (psymtab_storage::m_obstack): Use gdb::optional.
9767         (class psymtab_storage): Update comment.  Remove objfile
9768         parameter.
9769         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9770
9771 2019-01-10  Tom Tromey  <tom@tromey.com>
9772
9773         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9774         <free_psymtabs>: Now private.
9775         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9776         (allocate_psymtab): Use new method.
9777
9778 2019-01-10  Tom Tromey  <tom@tromey.com>
9779
9780         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9781         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9782         * mdebugread.c (parse_partial_symbols): Use
9783         allocate_dependencies.
9784         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9785         allocate_dependencies.
9786         (process_psymtab_comp_unit_reader)
9787         (build_type_psymtab_dependencies): Likewise.
9788         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9789
9790 2019-01-10  Tom Tromey  <tom@tromey.com>
9791
9792         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9793         PSYMBOL_SET_LANGUAGE.
9794         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9795
9796 2019-01-10  Tom Tromey  <tom@tromey.com>
9797
9798         * psymtab.h (psymtab_storage::obstack): New method.
9799         <m_obstack>: Rename from obstack; now private.
9800         * psymtab.c (psymtab_storage): Update.
9801         * dwarf2read.c (create_addrmap_from_index)
9802         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9803         Update.
9804
9805 2019-01-10  Tom Tromey  <tom@tromey.com>
9806
9807         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9808         * objfiles.h (objfile::reset_psymtabs): New method.
9809
9810 2019-01-10  Tom Tromey  <tom@tromey.com>
9811
9812         * symmisc.c (print_symbol_bcache_statistics): Update.
9813         (print_objfile_statistics): Update.
9814         * symfile.c (reread_symbols): Update.
9815         * psymtab.h (class psymtab_storage): New.
9816         * psymtab.c (psymtab_storage): New constructor.
9817         (~psymtab_storage): New destructor.
9818         (require_partial_symbols): Update.
9819         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9820         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9821         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9822         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9823         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9824         (start_psymtab_common, end_psymtab_common)
9825         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9826         (allocate_psymtab): Update.
9827         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9828         Update.
9829         (dump_psymtab_addrmap, maintenance_print_psymbols)
9830         (maintenance_check_psymtabs): Update.
9831         (class objfile_psymtabs): Move to objfiles.h.
9832         * psympriv.h (discard_psymtab): Now inline.
9833         (psymtab_discarder::psymtab_discarder): Update.
9834         (psymtab_discarder::~psymtab_discarder): Update.
9835         (ALL_OBJFILE_PSYMTABS): Rewrite.
9836         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9837         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9838         Remove fields.
9839         <partial_symtabs>: New field.
9840         (class objfile_psymtabs): Move from psymtab.h.  Update.
9841         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9842         psymbol_cache.
9843         (objfile::~objfile): Don't destroy psymbol_cache.
9844         * mdebugread.c (parse_partial_symbols): Update.
9845         * dwarf2read.c (create_addrmap_from_index)
9846         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9847         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9848         (add_partial_subprogram, dwarf2_ranges_read): Update.
9849         * dwarf-index-write.c (write_address_map)
9850         (write_one_signatured_type, recursively_write_psymbols)
9851         (class debug_names, class debug_names, write_psymtabs_to_index):
9852         Update.
9853
9854 2019-01-10  Tom Tromey  <tom@tromey.com>
9855
9856         * symtab.h (SYMBOL_SET_NAMES): Update.
9857         (symbol_set_names): Update.
9858         (MSYMBOL_SET_NAMES): Update.
9859         * symtab.c (symbol_set_names): Change argument to be an
9860         objfile_per_bfd_storage.
9861         * psymtab.c (add_psymbol_to_bcache): Update.
9862         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9863
9864 2019-01-10  Tom Tromey  <tom@tromey.com>
9865
9866         * symtab.c (create_demangled_names_hash): Change argument to be an
9867         objfile_per_bfd_storage.
9868         (symbol_set_names): Update.
9869
9870 2019-01-10  Tom Tromey  <tom@tromey.com>
9871
9872         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9873         init_psymbol_list.
9874         * psymtab.c (init_psymbol_list): Do nothing if already called.
9875         * psympriv.h (init_psymbol_list): Add comment.
9876         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9877         init_psymbol_list.
9878         * dbxread.c (dbx_symfile_read): Unconditionally call
9879         init_psymbol_list.
9880
9881 2019-01-10  Tom Tromey  <tom@tromey.com>
9882
9883         * xcoffread.c (scan_xcoff_symtab): Update.
9884         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9885         "where".
9886         * mdebugread.c (parse_partial_symbols)
9887         (handle_psymbol_enumerators): Update.
9888         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9889         * dbxread.c (read_dbx_symtab): Update.
9890         * psympriv.h (psymbol_placement): New enum.
9891         (add_psymbol_to_list): Update.
9892
9893 2019-01-10  Tom Tromey  <tom@tromey.com>
9894
9895         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9896         static_psymbols parameters.
9897         (scan_xcoff_symtab): Update.
9898         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9899         static_psymbols parameters.
9900         * psympriv.h (start_psymtab_common): Update.
9901         * mdebugread.c (parse_partial_symbols): Update.
9902         * dwarf2read.c (create_partial_symtab): Update.
9903         * dbxread.c (read_dbx_symtab): Update.
9904         (start_psymtab): Remove global_psymbols and static_psymbols
9905         parameters.
9906
9907 2019-01-10  Tom Tromey  <tom@tromey.com>
9908
9909         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9910         * psymtab.c (allocate_psymtab): Add comment.
9911         * psympriv.h (allocate_psymtab): Add comment.
9912         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9913         initializations.
9914         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9915
9916 2019-01-10  Tom Tromey  <tom@tromey.com>
9917
9918         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9919         Don't declare.
9920         * mipsread.c: Include mdebugread.h.
9921         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9922         Declare.
9923         * elfread.c: Include mdebugread.h.
9924
9925 2019-01-09  Tom Tromey  <tom@tromey.com>
9926
9927         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9928         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9929         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9930         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9931         (psym_lookup_symbol, psym_find_last_source_symtab)
9932         (psym_forget_cached_source_info, psym_print_stats)
9933         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9934         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9935         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9936         (psym_find_compunit_symtab_by_address)
9937         (maintenance_print_psymbols, maintenance_info_psymtabs)
9938         (maintenance_check_psymtabs): Use ranged for.
9939         * psymtab.h (class objfile_psymtabs): New.
9940         (require_partial_symbols): Return objfile_psymtabs.
9941         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9942
9943 2019-01-09  Tom Tromey  <tom@tromey.com>
9944
9945         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9946         (find_pc_mapped_section, list_overlays_command)
9947         (map_overlay_command, unmap_overlay_command)
9948         (simple_overlay_update): Use all_objfiles.
9949         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9950         * printcmd.c (info_symbol_command): Use all_objfiles.
9951         * objfiles.h (ALL_OBJSECTIONS): Remove.
9952         * maint.c (maintenance_translate_address): Use all_objfiles.
9953         * gcore.c (gcore_create_callback): Use all_objfiles.
9954         (objfile_find_memory_regions): Likewise.
9955
9956 2019-01-09  Tom Tromey  <tom@tromey.com>
9957
9958         * symtab.c (find_line_symtab, info_sources_command)
9959         (make_source_files_completion_list): Use objfile_compunits.
9960         * source.c (select_source_symtab): Use objfile_compunits.
9961         * objfiles.h (struct objfile): Update comment.
9962         (ALL_OBJFILES): Remove.
9963         (ALL_FILETABS): Remove.
9964         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9965         objfile_compunits.
9966
9967 2019-01-09  Tom Tromey  <tom@tromey.com>
9968
9969         * symmisc.c (print_objfile_statistics, dump_objfile)
9970         (maintenance_print_symbols): Use compunit_filetabs.
9971         * source.c (forget_cached_source_info_for_objfile): Use
9972         compunit_filetabs.
9973         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9974         (ALL_FILETABS): Use compunit_filetabs.
9975         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9976         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9977
9978 2019-01-09  Tom Tromey  <tom@tromey.com>
9979
9980         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9981         (compunit_filetabs): New.
9982         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9983         compunit_filetabs.
9984         (info_sources_command, make_source_files_completion_list): Remove
9985         declaration.
9986         * symmisc.c (print_objfile_statistics, dump_objfile)
9987         (maintenance_print_symbols): Remove declaration.
9988         (maintenance_info_symtabs): Use compunit_filetabs.
9989         (maintenance_info_line_tables): Likewise.
9990         * source.c (select_source_symtab): Change local variable name.
9991         (forget_cached_source_info_for_objfile): Remove declaration.
9992         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9993         * objfiles.c (objfile_relocate1): Remove declaration.
9994         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9995         declaration.
9996         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9997         * coffread.c (coff_symtab_read): Remove declaration.
9998         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9999         compunit_filetabs.
10000
10001 2019-01-09  Tom Tromey  <tom@tromey.com>
10002
10003         * symtab.c (lookup_objfile_from_block)
10004         (find_pc_sect_compunit_symtab, search_symbols)
10005         (default_collect_symbol_completion_matches_break_on): Use
10006         objfile_compunits.
10007         * objfiles.h (ALL_COMPUNITS): Remove.
10008         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10009         * cp-support.c (add_symbol_overload_list_qualified): Use
10010         objfile_compunits.
10011         * ada-lang.c (ada_collect_symbol_completion_matches)
10012         (ada_add_global_exceptions): Use objfile_compunits.
10013
10014 2019-01-09  Tom Tromey  <tom@tromey.com>
10015
10016         * source.c (select_source_symtab)
10017         (forget_cached_source_info_for_objfile): Remove declaration.
10018         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10019         declaration.
10020         * maint.c (count_symtabs_and_blocks): Remove declaration.
10021         * cp-support.c (add_symbol_overload_list_qualified): Remove
10022         declaration.
10023         * coffread.c (coff_symtab_read): Remove declaration.
10024         * symtab.c (lookup_symbol_in_objfile_symtabs)
10025         (basic_lookup_transparent_type_1): Use objfile_compunits.
10026         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10027         (info_sources_command, search_symbols)
10028         (default_collect_symbol_completion_matches_break_on)
10029         (make_source_files_completion_list): Remove declaration.
10030         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10031         (ada_collect_symbol_completion_matches)
10032         (ada_add_global_exceptions): Remove declaration.
10033         * linespec.c (iterate_over_all_matching_symtabs): Use
10034         objfile_compunits.
10035         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10036         (class objfile_compunits): New.
10037         (ALL_COMPUNITS): Use objfile_compunits.
10038         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10039         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10040         objfile_compunits.
10041         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10042
10043 2019-01-09  Tom Tromey  <tom@tromey.com>
10044
10045         * symtab.c (search_symbols)
10046         (default_collect_symbol_completion_matches_break_on): Use
10047         objfile_msymbols.
10048         * ada-lang.c (ada_lookup_simple_minsym)
10049         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10050         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10051         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10052         objfile_msymbols.
10053         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10054         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10055         * objc-lang.c (find_methods): Use objfile_msymbols.
10056         (info_selectors_command, info_classes_command): Likewise.
10057         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10058         * objfiles.h (class objfile_msymbols): New.
10059         (ALL_OBJFILE_MSYMBOLS): Remove.
10060         (ALL_MSYMBOLS): Remove.
10061
10062 2019-01-09  Tom Tromey  <tom@tromey.com>
10063
10064         * common/next-iterator.h (next_adapter): Add Iterator template
10065         parameter.
10066         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10067         (class all_objfiles_safe): New.
10068         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10069         * objfiles.c (put_objfile_before): Update comment.
10070         (add_separate_debug_objfile): Likewise.
10071         (free_all_objfiles): Use all_objfiles_safe.
10072         (objfile_purge_solibs): Likewise.
10073
10074 2019-01-09  Tom Tromey  <tom@tromey.com>
10075
10076         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10077         (expand_symtab_containing_pc, lookup_static_symbol)
10078         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10079         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10080         all_objfiles.
10081         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10082         * breakpoint.c (create_overlay_event_breakpoint)
10083         (create_longjmp_master_breakpoint)
10084         (create_std_terminate_master_breakpoint)
10085         (create_exception_master_breakpoint): Use all_objfiles.
10086         * linux-thread-db.c (try_thread_db_load_from_pdir)
10087         (has_libpthread): Use all_objfiles.
10088         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10089         * linespec.c (iterate_over_all_matching_symtabs)
10090         (search_minsyms_for_name): Use all_objfiles.
10091         * maint.c (maintenance_info_sections): Use all_objfiles.
10092         * main.c (captured_main_1): Use all_objfiles.
10093         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10094         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10095         * guile/scm-pretty-print.c
10096         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10097         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10098         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10099         (maintenance_print_msymbols): Use all_objfiles.
10100         * source.c (select_source_symtab): Use all_objfiles.
10101         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10102         * symfile.c (remove_symbol_file_command)
10103         (expand_symtabs_matching, map_symbol_filenames): Use
10104         all_objfiles.
10105         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10106         all_objfiles.
10107         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10108         * objc-lang.c (find_methods): Use all_objfiles.
10109         * objfiles.c (have_partial_symbols, have_full_symbols)
10110         (have_minimal_symbols, qsort_cmp)
10111         (default_iterate_over_objfiles_in_search_order): Use
10112         all_objfiles.
10113         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10114         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10115         (maintenance_check_psymtabs): Use all_objfiles.
10116         (ALL_PSYMTABS): Remove.
10117         * compile/compile-object-run.c (do_module_cleanup): Use
10118         all_objfiles.
10119         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10120         * cp-support.c (add_symbol_overload_list_qualified): Use
10121         all_objfiles.
10122         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10123         Use all_objfiles.
10124         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10125         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10126         all_objfiles.
10127         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10128         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10129         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10130         Uses all_objfiles.
10131         * solib.c (solib_read_symbols): Use all_objfiles
10132
10133 2019-01-09  Tom Tromey  <tom@tromey.com>
10134
10135         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10136         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10137         all_objfiles.
10138         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10139         * symmisc.c (print_symbol_bcache_statistics)
10140         (print_objfile_statistics, maintenance_print_objfiles)
10141         (maintenance_info_symtabs, maintenance_check_symtabs)
10142         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10143         all_objfiles.
10144         * source.c (forget_cached_source_info): Use all_objfiles.
10145         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10146         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10147         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10148         * objfiles.c (update_section_map): Use all_objfiles.
10149         (shared_objfile_contains_address_p): Likewise.
10150         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10151         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10152
10153 2019-01-09  Tom Tromey  <tom@tromey.com>
10154
10155         * common/next-iterator.h: New file.
10156         * objfiles.h (class all_objfiles): New.
10157         (struct objfile_iterator): New.
10158
10159 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10160
10161         * NEWS: Move the description of the changed "frame", "select-frame",
10162          and "info frame" commands to the Changed commands section.
10163
10164 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10165
10166         * gdbtypes.c (check_stub_method_group): Remove handling of old
10167         mangling schemes.
10168         * linespec.c (find_methods): Likewise.
10169         * stabsread.c (read_member_functions): Likewise.
10170         * valops.c (search_struct_method): Likewise.
10171         (value_struct_elt_for_reference): Likewise.
10172         * NEWS: Mention this change.
10173
10174 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10175
10176         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10177         print_source_lines.
10178         * source.c (print_source_lines_base): Update line number check.
10179         (print_source_lines): New function.
10180         (source_lines_range::source_lines_range): New function.
10181         * source.h (class source_lines_range): New class.
10182         (print_source_lines): New declaration.
10183
10184 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10185
10186         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10187
10188 2019-01-08  Tom Tromey  <tom@tromey.com>
10189             Simon Marchi  <simon.marchi@ericsson.com>
10190
10191         PR gdb/24060
10192         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10193         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10194         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10195         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10196         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10197         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10198
10199 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10200
10201         * source.c (select_source_symtab): Move header comment to
10202         declaration in source.h.
10203         (forget_cached_source_info_for_objfile): Likewise.
10204         (forget_cached_source_info): Likewise.
10205         (identify_source_line): Likewise.
10206         * source.h (identify_source_line): Move declaration from symtab.h
10207         and add comment from source.c
10208         (print_source_lines): Likewise.
10209         (forget_cached_source_info_for_objfile): Likewise.
10210         (forget_cached_source_info): Likewise.
10211         (select_source_symtab): Likewise.
10212         (enum print_source_lines_flag): Move definition from symtab.h.
10213         * symtab.h (identify_source_line): Move declaration to source.h.
10214         (print_source_lines): Likewise.
10215         (forget_cached_source_info_for_objfile): Likewise.
10216         (forget_cached_source_info): Likewise.
10217         (select_source_symtab): Likewise.
10218         (enum print_source_lines_flag): Move definition to source.h.
10219         * tui/tui-hooks.c: Add 'source.h' include.
10220
10221 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10222
10223         * source.c (print_source_lines_base): Handle requests to print
10224         reverse line number sequences, and guard against empty lines
10225         string.
10226
10227 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10228
10229         * source.c (print_source_lines_base): Fix skip of '\r' if next
10230         character is '\n'.
10231
10232 2019-01-06  Tom Tromey  <tom@tromey.com>
10233
10234         * c-exp.y (struct c_parse_state) <macro_original_text,
10235         expansion_obstack>: New member.
10236         (macro_original_text, expansion_obstack): Remove globals.
10237         (scan_macro_expansion, scanning_macro_expansion)
10238         (finished_macro_expansion): Update.
10239         (scan_macro_cleanup): Remove.
10240         (yylex, c_parse): Update.
10241
10242 2019-01-06  Tom Tromey  <tom@tromey.com>
10243
10244         * c-exp.y (struct c_parse_state) <strings>: New member.
10245         (operator_stoken): Update.
10246
10247 2019-01-06  Tom Tromey  <tom@tromey.com>
10248
10249         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10250         (union type_stack_elt) <typelist_val>: Now a pointer to
10251         std::vector.
10252         (type_stack_cleanup): Don't declare.
10253         (push_typelist): Update.
10254         * parse.c (pop_typelist): Return a std::vector.
10255         (push_typelist): Take a std::vector.
10256         (follow_types): Update.  Do not free args.
10257         (type_stack_cleanup): Remove.
10258         * c-exp.y (struct c_parse_state): New.
10259         (cpstate): New global.
10260         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10261         (nonempty_typelist): Update.
10262         (func_mod): Create a new vector.
10263         (c_parse): Create a c_parse_state.
10264         (check_parameter_typelist): Do not delete params.
10265         (function_method): Update.  Do not delete type_list.
10266
10267 2019-01-06  Tom Tromey  <tom@tromey.com>
10268
10269         PR gdb/28155:
10270         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10271         check_typedef.
10272         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10273         (print_return_value): Likewise.
10274
10275 2019-01-05  Tom Tromey  <tom@tromey.com>
10276
10277         * contrib/cleanup_check.py: Remove.
10278         * contrib/gcc-with-excheck: Remove.
10279         * contrib/exsummary.py: Remove.
10280         * contrib/excheck.py: Remove.
10281
10282 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10283
10284         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10285         NULL. Initialize tpprev to NULL instead of assigning it
10286         to NULL on the next statement.
10287         * windows-nat.c (windows_delete_thread): Remove check for
10288         main_thread_id before printing thread exit notifications.
10289         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10290         Remove thread ID check against main_thread_id.
10291         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10292         windows_delete_thread.
10293         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10294
10295 2019-01-04  Tom Tromey  <tom@tromey.com>
10296
10297         * compile/compile.c (_initialize_compile): Use upper case for
10298         metasyntactic variables.
10299         * symmisc.c (_initialize_symmisc): Use upper case for
10300         metasyntactic variables.
10301         * psymtab.c (_initialize_psymtab): Use upper case for
10302         metasyntactic variables.
10303         * demangle.c (demangle_command): Use upper case for metasyntactic
10304         variables.
10305         (_initialize_demangler): Likewise.
10306         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10307         variables.
10308
10309 2019-01-03  Tom Tromey  <tom@tromey.com>
10310
10311         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10312
10313 2019-01-03  Tom Tromey  <tom@tromey.com>
10314
10315         * python/py-symtab.c (salpy_str): Update.
10316         (struct salpy_sal_object) <symtab>: Now a PyObject.
10317         (salpy_dealloc): Update.
10318         (del_objfile_sal): Use gdbpy_ref.
10319
10320 2019-01-03  Tom Tromey  <tom@tromey.com>
10321
10322         * python/py-type.c (convert_field): Use new_reference.  Return
10323         gdbpy_ref.
10324         (make_fielditem): Return gdbpy_ref.
10325         (typy_fields): Update.
10326         (typy_getitem): Update.
10327         (field_name): Return gdbpy_ref.  Use new_reference.
10328         (typy_iterator_iternext): Update.
10329
10330 2019-01-03  Tom Tromey  <tom@tromey.com>
10331
10332         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10333
10334 2019-01-03  Tom Tromey  <tom@tromey.com>
10335
10336         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10337         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10338         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10339         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10340         (pspy_set_type_printers): Likewise.
10341         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10342         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10343         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10344         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10345         (objfpy_set_type_printers): Likewise.
10346
10347 2019-01-03  Tom Tromey  <tom@tromey.com>
10348
10349         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10350         (gdbpy_print_stack): Use gdbpy_err_fetch.
10351         * python/python-internal.h (class gdbpy_err_fetch): New class.
10352         (class gdbpy_enter) <m_error_type, m_error_value,
10353         m_error_traceback>: Remove.
10354         <m_error>: New member.
10355         (gdbpy_exception_to_string): Don't declare.
10356         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10357         * python/py-value.c (convert_value_from_python): Use
10358         gdbpy_err_fetch.
10359         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10360         gdbpy_exception_to_string.
10361         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10362         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10363         gdbpy_err_fetch.
10364
10365 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10366
10367         * linux-nat.c (delete_lwp_cleanup): Delete.
10368         (struct lwp_deleter): New struct.
10369         (lwp_info_up): New typedef.
10370         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10371         lwp_info_up.
10372
10373 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10374
10375         * linux-fork.c (class scoped_switch_fork_info): New class.
10376         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10377
10378 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10379
10380         * valops.c (find_overload_match): Remove use of null_cleanup, and
10381         calls to do_cleanups.
10382
10383 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10384
10385         * compile/compile-cplus-types.c
10386         (compile_cplus_instance::decl_name): Handle changes to
10387         cp_func_name.
10388         * cp-support.c (cp_func_name): Update header comment, update
10389         return type.
10390         * cp-support.h (cp_func_name): Update return type in declaration.
10391         * valops.c (find_overload_match): Move temp_func local to top
10392         level of function and change its type.  Use temp_func to hold and
10393         delete temporary string obtained from cp_func_name.
10394
10395 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10396
10397         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10398         gdb::char_vector, remove cleanup, and update uses of `msg`.
10399
10400 2019-01-03  Jim Wilson  <jimw@sifive.com>
10401
10402         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10403
10404 2019-01-02  Tom Tromey  <tom@tromey.com>
10405
10406         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10407         (tdesc_parse_xml): Remove cleanups.
10408         * target-descriptions.h (make_cleanup_free_target_description):
10409         Don't declare.
10410         (target_desc_deleter): New struct.
10411         (target_desc_up): New typedef.
10412         * target-descriptions.c (target_desc_deleter::operator()): Rename
10413         from free_target_description.
10414         (make_cleanup_free_target_description): Remove.
10415
10416 2019-01-02  Tom Tromey  <tom@tromey.com>
10417
10418         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10419         constructor, destructor.
10420         (linespec_parser): Remove typedef.
10421         (~linespec_parser): Rename from linespec_parser_delete.
10422         (linespec_lex_to_end, linespec_complete_label)
10423         (linespec_complete): Update.
10424         (decode_line_full): Remove cleanups.
10425         (decode_line_1): Update.
10426
10427 2019-01-02  Tom Tromey  <tom@tromey.com>
10428
10429         * python/python-internal.h (inferior_to_inferior_object): Change
10430         return type.
10431         * python/py-exitedevent.c (create_exited_event_object): Update.
10432         * python/py-inferior.c (inferior_to_inferior_object): Return
10433         gdbpy_ref.
10434         (python_new_inferior, python_inferior_deleted)
10435         (thread_to_thread_object, delete_thread_object)
10436         (build_inferior_list, gdbpy_selected_inferior): Update.
10437         * python/py-infthread.c (create_thread_object): Update.  Also fail
10438         if inferior_to_inferior_object fails.
10439
10440 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10441
10442         * inferior.h (class inferior) <displaced_step_state>: New field.
10443         * infrun.h (struct displaced_step_state): Move here from
10444         infrun.c.  Initialize fields, add constructor.
10445         <inf>: Remove field.
10446         <reset>: New method.
10447         * infrun.c (struct displaced_step_inferior_state): Move to
10448         infrun.h.
10449         (displaced_step_inferior_states): Remove.
10450         (get_displaced_stepping_state): Adust.
10451         (displaced_step_in_progress_any_inferior): Adjust.
10452         (displaced_step_in_progress_thread): Adjust.
10453         (displaced_step_in_progress): Adjust.
10454         (add_displaced_stepping_state): Remove.
10455         (get_displaced_step_closure_by_addr): Adjust.
10456         (remove_displaced_stepping_state): Remove.
10457         (infrun_inferior_exit): Call displaced_step_state.reset.
10458         (use_displaced_stepping): Don't check for NULL.
10459         (displaced_step_prepare_throw): Call
10460         get_displaced_stepping_state.
10461         (displaced_step_fixup): Don't check for NULL.
10462         (prepare_for_detach): Don't check for NULL.
10463
10464 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10465
10466         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10467          in case of call that did not complete.
10468
10469 2019-01-02  Andrey Utkin  <autkin@undo.io>
10470
10471         * symfile.c (find_separate_debug_file): Fix search of debug files for
10472         remote debuggee.
10473
10474 2019-01-02  Tom Tromey  <tom@tromey.com>
10475
10476         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10477         indentation.
10478         * python/py-frame.c (frapy_older): Remove cast.
10479         (frapy_newer): Likewise.
10480         * python/py-breakpoint.c (local_setattro): Remove cast.
10481         * python/py-arch.c (archpy_name): Remove local variable.
10482         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10483
10484 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10485
10486         * unittests/basic_string_view/element_access/char/empty.cc:
10487         Fix year range in copyright header.
10488
10489 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10490
10491         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10492         Delete.
10493         <operator==>: Update with for removed field.
10494         <hash>: Likewise.
10495         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10496         <isa_features>: ...this.
10497         <abi_features>: New field.
10498         (riscv_isa_flen): Update comment.
10499         (riscv_abi_xlen): New declaration.
10500         (riscv_abi_flen): New declaration.
10501         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10502         isa_features.
10503         (riscv_abi_xlen): New function.
10504         (riscv_isa_flen): Update to get answer from isa_features.
10505         (riscv_abi_flen): New function.
10506         (riscv_has_fp_abi): Update to get answer from abi_features.
10507         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10508         xlen and flen.
10509         (riscv_call_info) <xlen, flen>: Update comment.
10510         (riscv_call_arg_struct): Remove invalid assertions
10511         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10512         is removed.
10513         (riscv_gdbarch_init): Gather isa features and abi features
10514         separately, ensure both match on the gdbarch when reusing an old
10515         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10516         a target with 64-bit float hardware.
10517
10518 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10519
10520         * source.c (search_command_helper): Stop reverse search
10521         when line 1 has been searched.
10522
10523 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10524
10525         * record-full.c (record_full_base_target::close): Rewrite
10526         record_full_core_buf_list free logic.
10527
10528 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10529
10530         * break-catch-syscall.c (print_one_catch_syscall): xfree
10531         the last text.
10532
10533 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10534
10535         * top.c (print_gdb_version): Update Copyright year in version
10536         message.
10537
10538 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10539
10540         Update copyright year range in all GDB files.
10541
10542 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10543
10544         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10545
10546 For older changes see ChangeLog-2018.
10547 \f
10548 Local Variables:
10549 mode: change-log
10550 left-margin: 8
10551 fill-column: 74
10552 version-control: never
10553 coding: utf-8
10554 End:
10555