gdb/ChangeLog

   1 2019-01-23  Tom Tromey  <tom@tromey.com>
   2             Pedro Alves  <palves@redhat.com>
   3
   4         * infrun.c: Include "common/scope-exit.h"
   5         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
   6         (wait_for_inferior): Use SCOPE_EXIT.
   7         (fetch_inferior_event): Use scope_exit.
   8
   9 2019-01-23  Tom Tromey  <tom@tromey.com>
  10             Pedro Alves  <palves@redhat.com>
  11
  12         * breakpoint.c (create_breakpoint): Remove cleanup.
  13
  14 2019-01-23  Tom Tromey  <tom@tromey.com>
  15             Andrew Burgess  <andrew.burgess@embecosm.com>
  16             Pedro Alves  <palves@redhat.com>
  17
  18 2019-01-23  Pedro Alves  <palves@redhat.com>
  19
  20         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
  21
  22 2019-01-23  Pedro Alves  <palves@redhat.com>
  23             Andrew Burgess  <andrew.burgess@embecosm.com>
  24
  25         * gdbthread.h: Include "common/forward-scope-exit.h".
  26         (scoped_finish_thread_state): Redefine custom class in terms of
  27         forward_scope_exit.
  28
  29 2019-01-23  Pedro Alves  <palves@redhat.com>
  30             Andrew Burgess  <andrew.burgess@embecosm.com>
  31
  32         * common/forward-scope-exit.h: New file.
  33
  34 2019-01-23  Pedro Alves  <palves@redhat.com>
  35             Andrew Burgess  <andrew.burgess@embecosm.com>
  36             Tom Tromey  <tom@tromey.com>
  37
  38         * common/scope-exit.h: New file.
  39
  40 2019-01-23  Pedro Alves  <palves@redhat.com>
  41
  42         * common/preprocessor.h (ESC): Rename to ...
  43         (ESC_PARENS): ... this.
  44         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
  45         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
  46
  47 2019-01-23  Tom Tromey  <tom@tromey.com>
  48
  49         * language.h (class scoped_switch_to_sym_language_if_auto):
  50         Initialize m_lang in both cases.
  51
  52 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
  53
  54         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
  55         with XCNEW.
  56
  57 2019-01-22  Tom Tromey  <tom@tromey.com>
  58
  59         * corelow.c: Do not include sys/file.h.
  60
  61 2019-01-22  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-wingeneral.h: Include gdb_curses.h.
  64
  65 2019-01-22  Tom Tromey  <tom@tromey.com>
  66
  67         * source-cache.h (class source_cache) <get_source_lines,
  68         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
  69
  70 2019-01-22  Tom Tromey  <tom@tromey.com>
  71
  72         * remote-fileio.h (struct remote_target): Declare.
  73
  74 2019-01-22  Tom Tromey  <tom@tromey.com>
  75
  76         * python/py-arch.c: Do not include py-ref.h.
  77         * python/py-bpevent.c: Do not include py-ref.h.
  78         * python/py-cmd.c: Do not include py-ref.h.
  79         * python/py-continueevent.c: Do not include py-ref.h.
  80         * python/py-event.h: Do not include py-ref.h.
  81         * python/py-evtregistry.c: Do not include py-ref.h.
  82         * python/py-finishbreakpoint.c: Do not include py-ref.h.
  83         * python/py-frame.c: Do not include py-ref.h.
  84         * python/py-framefilter.c: Do not include py-ref.h.
  85         * python/py-function.c: Do not include py-ref.h.
  86         * python/py-infevents.c: Do not include py-ref.h.
  87         * python/py-linetable.c: Do not include py-ref.h.
  88         * python/py-objfile.c: Do not include py-ref.h.
  89         * python/py-param.c: Do not include py-ref.h.
  90         * python/py-prettyprint.c: Do not include py-ref.h.
  91         * python/py-progspace.c: Do not include py-ref.h.
  92         * python/py-symbol.c: Do not include py-ref.h.
  93         * python/py-symtab.c: Do not include py-ref.h.
  94         * python/py-type.c: Do not include py-ref.h.
  95         * python/py-unwind.c: Do not include py-ref.h.
  96         * python/py-utils.c: Do not include py-ref.h.
  97         * python/py-value.c: Do not include py-ref.h.
  98         * python/py-varobj.c: Do not include py-ref.h.
  99         * python/py-xmethods.c: Do not include py-ref.h.
 100         * python/python.c: Do not include py-ref.h.
 101         * varobj.c: Do not include py-ref.h.
 102
 103 2019-01-22  Tom Tromey  <tom@tromey.com>
 104
 105         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 106         keyword for bcache.
 107
 108 2019-01-22  Tom Tromey  <tom@tromey.com>
 109
 110         * compile/compile-cplus-types.c: Remove a comment by #include.
 111
 112 2019-01-22  Tom Tromey  <tom@tromey.com>
 113
 114         * compile/gcc-c-plugin.h: Include compile-internal.h.
 115
 116 2019-01-22  Tom Tromey  <tom@tromey.com>
 117
 118         * stabsread.c (EXTERN): Do not define.
 119         (symnum, next_symbol_text_func, processing_gcc_compilation)
 120         (within_function, global_sym_chain, global_stabs)
 121         (previous_stab_code, this_object_header_files)
 122         (n_this_object_header_files)
 123         (n_allocated_this_object_header_files): Define.
 124         * stabsread.h (EXTERN): Never define.  Use "extern".
 125
 126 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 127
 128         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 129         history_value.
 130
 131 2019-01-21  Tom Tromey  <tom@tromey.com>
 132
 133         * ui-out.c: Fix includes.
 134         * tui/tui-source.c: Fix includes.
 135         * target.c: Fix includes.
 136         * remote.c: Fix includes.
 137         * regcache.c: Fix includes.
 138         * python/py-block.c: Fix includes.
 139         * printcmd.c: Fix includes.
 140         * or1k-tdep.c: Fix includes.
 141         * mi/mi-main.c: Fix includes.
 142         * m32r-tdep.c: Fix includes.
 143         * csky-tdep.c: Fix includes.
 144         * compile/compile-cplus-types.c: Fix includes.
 145         * cli/cli-interp.c: Fix includes.
 146
 147 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 148
 149         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 150         for padding.
 151
 152 2019-01-16  Tom Tromey  <tom@tromey.com>
 153
 154         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 155         earlier.
 156         (struct objfile) <msymbols_range>: Move from top level.
 157         <msymbols>: New method.
 158         (class objfile_msymbols): Remove.
 159         * symtab.c (default_collect_symbol_completion_matches_break_on):
 160         Update.
 161         * symmisc.c (dump_msymbols): Update.
 162         * stabsread.c (scan_file_globals): Update.
 163         * objc-lang.c (info_selectors_command, info_classes_command)
 164         (find_methods): Update.
 165         * minsyms.c (find_solib_trampoline_target): Update.
 166         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 167         * coffread.c (coff_symfile_read): Update.
 168         * ada-lang.c (ada_lookup_simple_minsym)
 169         (ada_collect_symbol_completion_matches): Update.
 170
 171 2019-01-16  Tom Tromey  <tom@tromey.com>
 172
 173         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 174         type.  Remove no-argument constructor.
 175         <iterator::operator++>: Simplify.
 176         <begin>: Update.
 177         <end>: Use minimal_symbol_count.
 178
 179 2019-01-16  Tom Tromey  <tom@tromey.com>
 180
 181         * objfiles.h (struct objfile) <psymtabs>: New method.
 182         (class objfile_psymtabs): Remove.
 183         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 184         typedef.
 185         <range>: New method.
 186         (require_partial_symbols): Change return type.
 187         * psymtab.c (require_partial_symbols)
 188         (psym_expand_symtabs_matching): Update.
 189         * mdebugread.c (parse_partial_symbols): Update.
 190         * dbxread.c (dbx_end_psymtab): Update.
 191
 192 2019-01-15  Tom Tromey  <tom@tromey.com>
 193
 194         * symtab.c (lookup_objfile_from_block)
 195         (lookup_symbol_in_objfile_symtabs)
 196         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 197         (find_line_symtab, info_sources_command)
 198         (default_collect_symbol_completion_matches_break_on)
 199         (make_source_files_completion_list): Update.
 200         * symmisc.c (print_objfile_statistics, dump_objfile)
 201         (maintenance_print_symbols, maintenance_info_symtabs)
 202         (maintenance_check_symtabs, maintenance_info_line_tables):
 203         Update.
 204         * source.c (select_source_symtab)
 205         (forget_cached_source_info_for_objfile): Update.
 206         * objfiles.h (class objfile_compunits): Remove.
 207         (struct objfile) <compunits_range>: New typedef.
 208         (compunits): New method.
 209         * objfiles.c (objfile_relocate1): Update.
 210         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 211         * maint.c (count_symtabs_and_blocks): Update.
 212         * linespec.c (iterate_over_all_matching_symtabs): Update.
 213         * cp-support.c (add_symbol_overload_list_qualified): Update.
 214         * coffread.c (coff_symtab_read): Update.
 215         * ada-lang.c (add_nonlocal_symbols)
 216         (ada_collect_symbol_completion_matches)
 217         (ada_add_global_exceptions): Update.
 218
 219 2019-01-15  Tom Tromey  <tom@tromey.com>
 220
 221         * progspace.h (program_space) <objfiles_safe_range>: New
 222         typedef.
 223         <objfiles_safe>: New method.
 224         * objfiles.h (class all_objfiles_safe): Remove.
 225         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 226         * jit.c (jit_inferior_exit_hook): Update.
 227
 228 2019-01-17  Tom Tromey  <tom@tromey.com>
 229
 230         * progspace.h (program_space) <objfiles_range>: New typedef.
 231         <objfiles>: New method.
 232         <objfiles_head>: Rename from objfiles.
 233         (object_files): Update.
 234         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 235         * guile/scm-pretty-print.c
 236         (ppscm_find_pretty_printer_from_objfiles): Update.
 237         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 238         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 239         Update.
 240         * python/py-progspace.c (pspy_get_objfiles): Update.
 241         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 242         Update.
 243         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 244         (objfpy_lookup_objfile_by_build_id): Update.
 245         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 246         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 247         Update.
 248         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 249         (expand_symtab_containing_pc, lookup_objfile_from_block)
 250         (lookup_static_symbol, basic_lookup_transparent_type)
 251         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 252         (find_line_symtab, info_sources_command)
 253         (default_collect_symbol_completion_matches_break_on)
 254         (make_source_files_completion_list, find_main_name): Update.
 255         * symmisc.c (print_symbol_bcache_statistics)
 256         (print_objfile_statistics, maintenance_print_symbols)
 257         (maintenance_print_msymbols, maintenance_print_objfiles)
 258         (maintenance_info_symtabs, maintenance_check_symtabs)
 259         (maintenance_expand_symtabs, maintenance_info_line_tables):
 260         Update.
 261         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 262         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 263         (map_overlay_command, unmap_overlay_command)
 264         (simple_overlay_update, expand_symtabs_matching)
 265         (map_symbol_filenames): Update.
 266         * symfile-debug.c (set_debug_symfile): Update.
 267         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 268         Update.
 269         * source.c (select_source_symtab, forget_cached_source_info):
 270         Update.
 271         * solib.c (solib_read_symbols): Update.
 272         * solib-spu.c (append_ocl_sos): Update.
 273         * psymtab.c (maintenance_print_psymbols)
 274         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 275         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 276         * printcmd.c (info_symbol_command): Update.
 277         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 278         Update.
 279         * objfiles.h (class all_objfiles): Remove.
 280         * objfiles.c (have_partial_symbols, have_full_symbols)
 281         (have_minimal_symbols, qsort_cmp, update_section_map)
 282         (shared_objfile_contains_address_p)
 283         (default_iterate_over_objfiles_in_search_order): Update.
 284         * objc-lang.c (info_selectors_command, info_classes_command)
 285         (find_methods): Update.
 286         * minsyms.c (find_solib_trampoline_target): Update.
 287         * maint.c (maintenance_info_sections)
 288         (maintenance_translate_address, count_symtabs_and_blocks):
 289         Update.
 290         * main.c (captured_main_1): Update.
 291         * linux-thread-db.c (try_thread_db_load_from_pdir)
 292         (has_libpthread): Update.
 293         * linespec.c (iterate_over_all_matching_symtabs)
 294         (search_minsyms_for_name): Update.
 295         * jit.c (jit_find_objf_with_entry_addr): Update.
 296         * hppa-tdep.c (find_unwind_entry)
 297         (hppa_lookup_stub_minimal_symbol): Update.
 298         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 299         Update.
 300         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 301         (elf_gnu_ifunc_resolve_by_got): Update.
 302         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 303         * dwarf-index-write.c (save_gdb_index_command): Update.
 304         * cp-support.c (add_symbol_overload_list_qualified): Update.
 305         * breakpoint.c (create_overlay_event_breakpoint)
 306         (create_longjmp_master_breakpoint)
 307         (create_std_terminate_master_breakpoint)
 308         (create_exception_master_breakpoint): Update.
 309         * blockframe.c (find_pc_partial_function): Update.
 310         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 311         (ada_collect_symbol_completion_matches)
 312         (ada_add_global_exceptions): Update.
 313
 314 2019-01-17  Tom Tromey  <tom@tromey.com>
 315
 316         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 317         declare VEC.
 318         (solib_target_parse_libraries): Change return type.
 319         (library_list_start_segment, library_list_start_section)
 320         (library_list_end_library, library_list_start_library); Update.
 321         (solib_target_free_library_list): Remove.
 322         (solib_target_parse_libraries): Remove cleanup.  Change return
 323         type.
 324         (solib_target_current_sos): Update.
 325
 326 2019-01-17  Tom Tromey  <tromey@bapiya>
 327
 328         * valprint.c: Replace "the the" with "the".
 329         * symtab.c: Replace "the the" with "the".
 330         * solib.c: Replace "the the" with "the".
 331         * solib-dsbt.c: Replace "the the" with "the".
 332         * linespec.c: Replace "the the" with "the".
 333         * dwarf2loc.h: Replace "the the" with "the".
 334         * amd64-windows-tdep.c: Replace "the the" with "the".
 335         * aarch64-tdep.c: Replace "the the" with "the".
 336
 337 2019-01-16  Keith Seitz  <keiths@redhat.com>
 338
 339         PR gdb/23773
 340         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 341         <builder>: Rename to ..
 342         <m_builder>: ... this and make private.
 343         (dwarf2_cu::get_builder): New method.  Change all users of
 344         `builder' to use this method.
 345         (dwarf2_start_symtab): Move to ...
 346         (dwarf2_cu::start_symtab): ... here.  Update all callers
 347         (setup_type_unit_groups): Move to ...
 348         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 349         callers.
 350         (dwarf2_cu::reset_builder): New method.
 351         (process_full_compunit, process_full_type_unit): Use
 352         dwarf2_cu::reset_builder.
 353         (follow_die_offset): Record the ancestor CU if it is different
 354         from the followed DIE's CU.
 355         (follow_die_sig_1): Likewise.
 356
 357 2019-01-15  Tom Tromey  <tom@tromey.com>
 358
 359         * remote.c (class remote_state) <buf>: Now a char_vector.
 360         <buf_size>: Remove.
 361         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 362         parameter.
 363         (remote_target::getpkt_or_notif_sane_1)
 364         (remote_target::getpkt_sane)
 365         (remote_target::getpkt_or_notif_sane): Likewise.
 366         (class remote_target) <putpkt>: New overload.
 367         (remote_target::read_frame): Change type of "buf_p".  Remove
 368         sizeof_p parameter.
 369         (packet_ok): New overload.
 370         (packet_check_result): New overload.
 371         Update all uses.
 372
 373 2019-01-14  Tom Tromey  <tom@tromey.com>
 374
 375         * remote-notif.c (handle_notification, remote_notif_ack)
 376         (remote_notif_parse): Make "buf" const.
 377         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 378         const.
 379         (remote_notif_parse, remote_notif_ack, handle_notification):
 380         Likewise.
 381         * remote.c (remote_notif_stop_parse): Make "buf" const.
 382         (remote_target::remote_parse_stop_reply): Make "buf" const.
 383         (remote_notif_stop_ack): Make "buf" const.
 384
 385 2019-01-14  Tom Tromey  <tom@tromey.com>
 386
 387         * remote.c (remote_console_output): Make parameter const.
 388
 389 2019-01-14  Tom Tromey  <tom@tromey.com>
 390
 391         * target-debug.h (target_debug_print_signals): Constify.
 392         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 393         * procfs.c (procfs_target::pass_signals): Update.
 394         * linux-nat.c (linux_nat_target::pass_signals): Update.
 395         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 396         * target-delegates.c: Rebuild.
 397         * remote.c (remote_target::program_signals): Update.
 398         (remote_target::pass_signals): Update.
 399         * target.c (target_pass_signals): Constify argument.
 400         (target_program_signals): Likewise.
 401         * target.h (struct target_ops) <pass_signals, program_signals>:
 402         Constify argument.
 403         (target_pass_signals, target_program_signals): Constify argument.
 404
 405 2019-01-14  Tom Tromey  <tom@tromey.com>
 406
 407         PR tui/28819:
 408         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 409
 410 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 411
 412         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 413         field.
 414         * rs6000-tdep.c: Include reggroups.h.
 415         (IS_V_ALIAS_PSEUDOREG): Define.
 416         (rs6000_register_name): Return names for the "vX" aliases.
 417         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 418         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 419         aliases.  Call default_register_reggroup_p for all other
 420         pseudo-registers.
 421         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 422         New functions.
 423         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 424         Handle "vX" aliases.
 425         (v_alias_pseudo_register_collect): New function.
 426         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 427         (rs6000_gdbarch_init): Initialize "vX" aliases as
 428         pseudo-registers.  Restore registration of
 429         rs6000_pseudo_register_reggroup_p with
 430         set_tdesc_pseudo_register_reggroup_p.
 431
 432 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 433
 434         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 435         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 436         set_gdbarch_num_pseudo_regs.
 437
 438 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 439
 440         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 441         Remove arg prefixname, add do_set and do_show.
 442         Add member functions set_list and show_list.
 443         * cli/cli-style.c (class cli_style_option): Update accordingly.
 444         (style_set_list): Move to file scope.
 445         (style_show_list): Likewise.
 446         (set_style): Call help_list.
 447         (show_style): Call cmd_show_list.
 448         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 449         Update to use the new macro.
 450
 451 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 452
 453         * ada-lang.c (_initialize_ada_language): Expand the help text
 454         for the "catch exception" command.
 455
 456 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 457
 458         * symtab.c (matching_obj_sections): Initialize obj,
 459         declare it closer to its usage.
 460
 461 2019-01-10  Tom Tromey  <tom@tromey.com>
 462
 463         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 464         (basic_inf_threads_range): Remove.
 465         (inf_threads_range, inf_non_exited_threads_range)
 466         (safe_inf_threads_range): Use next_adapter.
 467
 468 2019-01-10  Keith Seitz  <keiths@redhat.com>
 469
 470         PR gdb/23712
 471         PR symtab/23010
 472         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 473         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 474
 475 2019-01-10  Keith Seitz  <keiths@redhat.com>
 476
 477         PR gdb/23712
 478         PR symtab/23010
 479         * dictionary.c (pending_to_vector): Remove.
 480         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 481         Remove _1 suffix, replacing functions of the same name.  Update
 482         all callers.
 483         (dict_create_hashed, dict_create_hashed_expandable)
 484         (dict_create_linear, dict_create_linear_expandable, dict_free)
 485         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 486         Make functions static.
 487
 488 2019-01-10  Keith Seitz  <keiths@redhat.com>
 489
 490         PR gdb/23712
 491         PR symtab/23010
 492         * dictionary.h (struct dictionary): Replace declaration with
 493         multidictionary.
 494         (dict_create_hashed, dict_create_hashed_expandable)
 495         (dict_create_linear, dict_create_linear_expandable)
 496         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 497         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 498         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 499         taking multidictionary argument.
 500         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 501         * block.h (struct block) <dict>: Change to multidictionary
 502         and rename `multidict'.
 503         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 504         symmisc.c: Update all dictionary references to multidictionary.
 505
 506 2019-01-10  Keith Seitz  <keiths@redhat.com>
 507
 508         PR gdb/23712
 509         PR symtab/23010
 510         * dictionary.c: Include unordered_map.
 511         (pending_to_vector): New function.
 512         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 513         Rewrite the non-"_1" functions to take vector instead
 514         of linked list.
 515         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 516         "new" _1 versions of the same name.
 517         (multidictionary): Define.
 518         (std::hash<enum language): New definition.
 519         (collate_pending_symbols_by_language, mdict_create_hashed)
 520         (mdict_create_hashed_expandable, mdict_create_linear)
 521         (mdict_create_linear_expandable, mdict_free)
 522         (find_language_dictionary, create_new_language_dictionary)
 523         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 524         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 525         (mdict_size, mdict_empty): New functions.
 526         * dictionary.h (mdict_iterator): Define.
 527
 528 2019-01-10  Pedro Alves  <palves@redhat.com>
 529
 530         * breakpoint.c (read_uploaded_action)
 531         (create_tracepoint_from_upload): Adjust to use
 532         gdb::unique_xmalloc_ptr.
 533         * ctf.c (ctf_write_uploaded_tp):
 534         (SET_ARRAY_FIELD): Use emplace_back.
 535         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 536         * tracefile-tfile.c (tfile_write_uploaded_tp):
 537         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 538         gdb::unique_xmalloc_ptr.
 539         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 540         at_string, cond_string, cmd_strings>: Replace char pointers
 541         with gdb::unique_xmalloc_ptr.
 542
 543 2019-01-10  Pedro Alves  <palves@redhat.com>
 544
 545         * solib-target.c (library_list_start_library): Don't xstrdup name.
 546
 547 2019-01-10  Pedro Alves  <palves@redhat.com>
 548
 549         * mdebugread.c (parse_partial_symbols): Use
 550         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 551
 552 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 553
 554         * linux-fork.c (scoped_switch_fork_info)
 555         <~scoped_switch_fork_info>: Fix incorrect variable name.
 556
 557 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 558
 559         * linux-fork.c (scoped_switch_fork_info)
 560         <scoped_switch_fork_info>: Make explicit.
 561         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 562
 563 2019-01-10  Tom Tromey  <tom@tromey.com>
 564
 565         * objfiles.h (objfile::reset_psymtabs): Update.
 566         * objfiles.c (objfile::objfile): Update.
 567         * psymtab.h (psymtab_storage::obstack): Update.
 568         (psymtab_storage::m_obstack): Use gdb::optional.
 569         (class psymtab_storage): Update comment.  Remove objfile
 570         parameter.
 571         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 572
 573 2019-01-10  Tom Tromey  <tom@tromey.com>
 574
 575         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 576         <free_psymtabs>: Now private.
 577         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 578         (allocate_psymtab): Use new method.
 579
 580 2019-01-10  Tom Tromey  <tom@tromey.com>
 581
 582         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 583         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 584         * mdebugread.c (parse_partial_symbols): Use
 585         allocate_dependencies.
 586         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 587         allocate_dependencies.
 588         (process_psymtab_comp_unit_reader)
 589         (build_type_psymtab_dependencies): Likewise.
 590         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 591
 592 2019-01-10  Tom Tromey  <tom@tromey.com>
 593
 594         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 595         PSYMBOL_SET_LANGUAGE.
 596         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 597
 598 2019-01-10  Tom Tromey  <tom@tromey.com>
 599
 600         * psymtab.h (psymtab_storage::obstack): New method.
 601         <m_obstack>: Rename from obstack; now private.
 602         * psymtab.c (psymtab_storage): Update.
 603         * dwarf2read.c (create_addrmap_from_index)
 604         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 605         Update.
 606
 607 2019-01-10  Tom Tromey  <tom@tromey.com>
 608
 609         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 610         * objfiles.h (objfile::reset_psymtabs): New method.
 611
 612 2019-01-10  Tom Tromey  <tom@tromey.com>
 613
 614         * symmisc.c (print_symbol_bcache_statistics): Update.
 615         (print_objfile_statistics): Update.
 616         * symfile.c (reread_symbols): Update.
 617         * psymtab.h (class psymtab_storage): New.
 618         * psymtab.c (psymtab_storage): New constructor.
 619         (~psymtab_storage): New destructor.
 620         (require_partial_symbols): Update.
 621         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 622         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 623         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 624         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 625         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 626         (start_psymtab_common, end_psymtab_common)
 627         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 628         (allocate_psymtab): Update.
 629         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 630         Update.
 631         (dump_psymtab_addrmap, maintenance_print_psymbols)
 632         (maintenance_check_psymtabs): Update.
 633         (class objfile_psymtabs): Move to objfiles.h.
 634         * psympriv.h (discard_psymtab): Now inline.
 635         (psymtab_discarder::psymtab_discarder): Update.
 636         (psymtab_discarder::~psymtab_discarder): Update.
 637         (ALL_OBJFILE_PSYMTABS): Rewrite.
 638         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 639         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 640         Remove fields.
 641         <partial_symtabs>: New field.
 642         (class objfile_psymtabs): Move from psymtab.h.  Update.
 643         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 644         psymbol_cache.
 645         (objfile::~objfile): Don't destroy psymbol_cache.
 646         * mdebugread.c (parse_partial_symbols): Update.
 647         * dwarf2read.c (create_addrmap_from_index)
 648         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 649         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 650         (add_partial_subprogram, dwarf2_ranges_read): Update.
 651         * dwarf-index-write.c (write_address_map)
 652         (write_one_signatured_type, recursively_write_psymbols)
 653         (class debug_names, class debug_names, write_psymtabs_to_index):
 654         Update.
 655
 656 2019-01-10  Tom Tromey  <tom@tromey.com>
 657
 658         * symtab.h (SYMBOL_SET_NAMES): Update.
 659         (symbol_set_names): Update.
 660         (MSYMBOL_SET_NAMES): Update.
 661         * symtab.c (symbol_set_names): Change argument to be an
 662         objfile_per_bfd_storage.
 663         * psymtab.c (add_psymbol_to_bcache): Update.
 664         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 665
 666 2019-01-10  Tom Tromey  <tom@tromey.com>
 667
 668         * symtab.c (create_demangled_names_hash): Change argument to be an
 669         objfile_per_bfd_storage.
 670         (symbol_set_names): Update.
 671
 672 2019-01-10  Tom Tromey  <tom@tromey.com>
 673
 674         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 675         init_psymbol_list.
 676         * psymtab.c (init_psymbol_list): Do nothing if already called.
 677         * psympriv.h (init_psymbol_list): Add comment.
 678         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 679         init_psymbol_list.
 680         * dbxread.c (dbx_symfile_read): Unconditionally call
 681         init_psymbol_list.
 682
 683 2019-01-10  Tom Tromey  <tom@tromey.com>
 684
 685         * xcoffread.c (scan_xcoff_symtab): Update.
 686         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 687         "where".
 688         * mdebugread.c (parse_partial_symbols)
 689         (handle_psymbol_enumerators): Update.
 690         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 691         * dbxread.c (read_dbx_symtab): Update.
 692         * psympriv.h (psymbol_placement): New enum.
 693         (add_psymbol_to_list): Update.
 694
 695 2019-01-10  Tom Tromey  <tom@tromey.com>
 696
 697         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 698         static_psymbols parameters.
 699         (scan_xcoff_symtab): Update.
 700         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 701         static_psymbols parameters.
 702         * psympriv.h (start_psymtab_common): Update.
 703         * mdebugread.c (parse_partial_symbols): Update.
 704         * dwarf2read.c (create_partial_symtab): Update.
 705         * dbxread.c (read_dbx_symtab): Update.
 706         (start_psymtab): Remove global_psymbols and static_psymbols
 707         parameters.
 708
 709 2019-01-10  Tom Tromey  <tom@tromey.com>
 710
 711         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 712         * psymtab.c (allocate_psymtab): Add comment.
 713         * psympriv.h (allocate_psymtab): Add comment.
 714         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 715         initializations.
 716         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 717
 718 2019-01-10  Tom Tromey  <tom@tromey.com>
 719
 720         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 721         Don't declare.
 722         * mipsread.c: Include mdebugread.h.
 723         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 724         Declare.
 725         * elfread.c: Include mdebugread.h.
 726
 727 2019-01-09  Tom Tromey  <tom@tromey.com>
 728
 729         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 730         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 731         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 732         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 733         (psym_lookup_symbol, psym_find_last_source_symtab)
 734         (psym_forget_cached_source_info, psym_print_stats)
 735         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 736         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 737         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 738         (psym_find_compunit_symtab_by_address)
 739         (maintenance_print_psymbols, maintenance_info_psymtabs)
 740         (maintenance_check_psymtabs): Use ranged for.
 741         * psymtab.h (class objfile_psymtabs): New.
 742         (require_partial_symbols): Return objfile_psymtabs.
 743         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 744
 745 2019-01-09  Tom Tromey  <tom@tromey.com>
 746
 747         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 748         (find_pc_mapped_section, list_overlays_command)
 749         (map_overlay_command, unmap_overlay_command)
 750         (simple_overlay_update): Use all_objfiles.
 751         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 752         * printcmd.c (info_symbol_command): Use all_objfiles.
 753         * objfiles.h (ALL_OBJSECTIONS): Remove.
 754         * maint.c (maintenance_translate_address): Use all_objfiles.
 755         * gcore.c (gcore_create_callback): Use all_objfiles.
 756         (objfile_find_memory_regions): Likewise.
 757
 758 2019-01-09  Tom Tromey  <tom@tromey.com>
 759
 760         * symtab.c (find_line_symtab, info_sources_command)
 761         (make_source_files_completion_list): Use objfile_compunits.
 762         * source.c (select_source_symtab): Use objfile_compunits.
 763         * objfiles.h (struct objfile): Update comment.
 764         (ALL_OBJFILES): Remove.
 765         (ALL_FILETABS): Remove.
 766         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 767         objfile_compunits.
 768
 769 2019-01-09  Tom Tromey  <tom@tromey.com>
 770
 771         * symmisc.c (print_objfile_statistics, dump_objfile)
 772         (maintenance_print_symbols): Use compunit_filetabs.
 773         * source.c (forget_cached_source_info_for_objfile): Use
 774         compunit_filetabs.
 775         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 776         (ALL_FILETABS): Use compunit_filetabs.
 777         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 778         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 779
 780 2019-01-09  Tom Tromey  <tom@tromey.com>
 781
 782         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 783         (compunit_filetabs): New.
 784         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 785         compunit_filetabs.
 786         (info_sources_command, make_source_files_completion_list): Remove
 787         declaration.
 788         * symmisc.c (print_objfile_statistics, dump_objfile)
 789         (maintenance_print_symbols): Remove declaration.
 790         (maintenance_info_symtabs): Use compunit_filetabs.
 791         (maintenance_info_line_tables): Likewise.
 792         * source.c (select_source_symtab): Change local variable name.
 793         (forget_cached_source_info_for_objfile): Remove declaration.
 794         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 795         * objfiles.c (objfile_relocate1): Remove declaration.
 796         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 797         declaration.
 798         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 799         * coffread.c (coff_symtab_read): Remove declaration.
 800         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 801         compunit_filetabs.
 802
 803 2019-01-09  Tom Tromey  <tom@tromey.com>
 804
 805         * symtab.c (lookup_objfile_from_block)
 806         (find_pc_sect_compunit_symtab, search_symbols)
 807         (default_collect_symbol_completion_matches_break_on): Use
 808         objfile_compunits.
 809         * objfiles.h (ALL_COMPUNITS): Remove.
 810         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 811         * cp-support.c (add_symbol_overload_list_qualified): Use
 812         objfile_compunits.
 813         * ada-lang.c (ada_collect_symbol_completion_matches)
 814         (ada_add_global_exceptions): Use objfile_compunits.
 815
 816 2019-01-09  Tom Tromey  <tom@tromey.com>
 817
 818         * source.c (select_source_symtab)
 819         (forget_cached_source_info_for_objfile): Remove declaration.
 820         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 821         declaration.
 822         * maint.c (count_symtabs_and_blocks): Remove declaration.
 823         * cp-support.c (add_symbol_overload_list_qualified): Remove
 824         declaration.
 825         * coffread.c (coff_symtab_read): Remove declaration.
 826         * symtab.c (lookup_symbol_in_objfile_symtabs)
 827         (basic_lookup_transparent_type_1): Use objfile_compunits.
 828         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 829         (info_sources_command, search_symbols)
 830         (default_collect_symbol_completion_matches_break_on)
 831         (make_source_files_completion_list): Remove declaration.
 832         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 833         (ada_collect_symbol_completion_matches)
 834         (ada_add_global_exceptions): Remove declaration.
 835         * linespec.c (iterate_over_all_matching_symtabs): Use
 836         objfile_compunits.
 837         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 838         (class objfile_compunits): New.
 839         (ALL_COMPUNITS): Use objfile_compunits.
 840         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 841         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 842         objfile_compunits.
 843         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 844
 845 2019-01-09  Tom Tromey  <tom@tromey.com>
 846
 847         * symtab.c (search_symbols)
 848         (default_collect_symbol_completion_matches_break_on): Use
 849         objfile_msymbols.
 850         * ada-lang.c (ada_lookup_simple_minsym)
 851         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 852         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 853         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 854         objfile_msymbols.
 855         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 856         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 857         * objc-lang.c (find_methods): Use objfile_msymbols.
 858         (info_selectors_command, info_classes_command): Likewise.
 859         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 860         * objfiles.h (class objfile_msymbols): New.
 861         (ALL_OBJFILE_MSYMBOLS): Remove.
 862         (ALL_MSYMBOLS): Remove.
 863
 864 2019-01-09  Tom Tromey  <tom@tromey.com>
 865
 866         * common/next-iterator.h (next_adapter): Add Iterator template
 867         parameter.
 868         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 869         (class all_objfiles_safe): New.
 870         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 871         * objfiles.c (put_objfile_before): Update comment.
 872         (add_separate_debug_objfile): Likewise.
 873         (free_all_objfiles): Use all_objfiles_safe.
 874         (objfile_purge_solibs): Likewise.
 875
 876 2019-01-09  Tom Tromey  <tom@tromey.com>
 877
 878         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 879         (expand_symtab_containing_pc, lookup_static_symbol)
 880         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 881         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 882         all_objfiles.
 883         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 884         * breakpoint.c (create_overlay_event_breakpoint)
 885         (create_longjmp_master_breakpoint)
 886         (create_std_terminate_master_breakpoint)
 887         (create_exception_master_breakpoint): Use all_objfiles.
 888         * linux-thread-db.c (try_thread_db_load_from_pdir)
 889         (has_libpthread): Use all_objfiles.
 890         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 891         * linespec.c (iterate_over_all_matching_symtabs)
 892         (search_minsyms_for_name): Use all_objfiles.
 893         * maint.c (maintenance_info_sections): Use all_objfiles.
 894         * main.c (captured_main_1): Use all_objfiles.
 895         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 896         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 897         * guile/scm-pretty-print.c
 898         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 899         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 900         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 901         (maintenance_print_msymbols): Use all_objfiles.
 902         * source.c (select_source_symtab): Use all_objfiles.
 903         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 904         * symfile.c (remove_symbol_file_command)
 905         (expand_symtabs_matching, map_symbol_filenames): Use
 906         all_objfiles.
 907         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 908         all_objfiles.
 909         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 910         * objc-lang.c (find_methods): Use all_objfiles.
 911         * objfiles.c (have_partial_symbols, have_full_symbols)
 912         (have_minimal_symbols, qsort_cmp)
 913         (default_iterate_over_objfiles_in_search_order): Use
 914         all_objfiles.
 915         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 916         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 917         (maintenance_check_psymtabs): Use all_objfiles.
 918         (ALL_PSYMTABS): Remove.
 919         * compile/compile-object-run.c (do_module_cleanup): Use
 920         all_objfiles.
 921         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 922         * cp-support.c (add_symbol_overload_list_qualified): Use
 923         all_objfiles.
 924         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 925         Use all_objfiles.
 926         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 927         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 928         all_objfiles.
 929         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 930         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 931         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 932         Uses all_objfiles.
 933         * solib.c (solib_read_symbols): Use all_objfiles
 934
 935 2019-01-09  Tom Tromey  <tom@tromey.com>
 936
 937         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 938         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 939         all_objfiles.
 940         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 941         * symmisc.c (print_symbol_bcache_statistics)
 942         (print_objfile_statistics, maintenance_print_objfiles)
 943         (maintenance_info_symtabs, maintenance_check_symtabs)
 944         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 945         all_objfiles.
 946         * source.c (forget_cached_source_info): Use all_objfiles.
 947         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 948         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 949         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 950         * objfiles.c (update_section_map): Use all_objfiles.
 951         (shared_objfile_contains_address_p): Likewise.
 952         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 953         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 954
 955 2019-01-09  Tom Tromey  <tom@tromey.com>
 956
 957         * common/next-iterator.h: New file.
 958         * objfiles.h (class all_objfiles): New.
 959         (struct objfile_iterator): New.
 960
 961 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 962
 963         * NEWS: Move the description of the changed "frame", "select-frame",
 964          and "info frame" commands to the Changed commands section.
 965
 966 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 967
 968         * gdbtypes.c (check_stub_method_group): Remove handling of old
 969         mangling schemes.
 970         * linespec.c (find_methods): Likewise.
 971         * stabsread.c (read_member_functions): Likewise.
 972         * valops.c (search_struct_method): Likewise.
 973         (value_struct_elt_for_reference): Likewise.
 974         * NEWS: Mention this change.
 975
 976 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 977
 978         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 979         print_source_lines.
 980         * source.c (print_source_lines_base): Update line number check.
 981         (print_source_lines): New function.
 982         (source_lines_range::source_lines_range): New function.
 983         * source.h (class source_lines_range): New class.
 984         (print_source_lines): New declaration.
 985
 986 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 987
 988         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 989
 990 2019-01-08  Tom Tromey  <tom@tromey.com>
 991             Simon Marchi  <simon.marchi@ericsson.com>
 992
 993         PR gdb/24060
 994         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 995         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 996         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 997         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 998         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 999         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1000
1001 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1002
1003         * source.c (select_source_symtab): Move header comment to
1004         declaration in source.h.
1005         (forget_cached_source_info_for_objfile): Likewise.
1006         (forget_cached_source_info): Likewise.
1007         (identify_source_line): Likewise.
1008         * source.h (identify_source_line): Move declaration from symtab.h
1009         and add comment from source.c
1010         (print_source_lines): Likewise.
1011         (forget_cached_source_info_for_objfile): Likewise.
1012         (forget_cached_source_info): Likewise.
1013         (select_source_symtab): Likewise.
1014         (enum print_source_lines_flag): Move definition from symtab.h.
1015         * symtab.h (identify_source_line): Move declaration to source.h.
1016         (print_source_lines): Likewise.
1017         (forget_cached_source_info_for_objfile): Likewise.
1018         (forget_cached_source_info): Likewise.
1019         (select_source_symtab): Likewise.
1020         (enum print_source_lines_flag): Move definition to source.h.
1021         * tui/tui-hooks.c: Add 'source.h' include.
1022
1023 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1024
1025         * source.c (print_source_lines_base): Handle requests to print
1026         reverse line number sequences, and guard against empty lines
1027         string.
1028
1029 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * source.c (print_source_lines_base): Fix skip of '\r' if next
1032         character is '\n'.
1033
1034 2019-01-06  Tom Tromey  <tom@tromey.com>
1035
1036         * c-exp.y (struct c_parse_state) <macro_original_text,
1037         expansion_obstack>: New member.
1038         (macro_original_text, expansion_obstack): Remove globals.
1039         (scan_macro_expansion, scanning_macro_expansion)
1040         (finished_macro_expansion): Update.
1041         (scan_macro_cleanup): Remove.
1042         (yylex, c_parse): Update.
1043
1044 2019-01-06  Tom Tromey  <tom@tromey.com>
1045
1046         * c-exp.y (struct c_parse_state) <strings>: New member.
1047         (operator_stoken): Update.
1048
1049 2019-01-06  Tom Tromey  <tom@tromey.com>
1050
1051         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1052         (union type_stack_elt) <typelist_val>: Now a pointer to
1053         std::vector.
1054         (type_stack_cleanup): Don't declare.
1055         (push_typelist): Update.
1056         * parse.c (pop_typelist): Return a std::vector.
1057         (push_typelist): Take a std::vector.
1058         (follow_types): Update.  Do not free args.
1059         (type_stack_cleanup): Remove.
1060         * c-exp.y (struct c_parse_state): New.
1061         (cpstate): New global.
1062         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1063         (nonempty_typelist): Update.
1064         (func_mod): Create a new vector.
1065         (c_parse): Create a c_parse_state.
1066         (check_parameter_typelist): Do not delete params.
1067         (function_method): Update.  Do not delete type_list.
1068
1069 2019-01-06  Tom Tromey  <tom@tromey.com>
1070
1071         PR gdb/28155:
1072         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1073         check_typedef.
1074         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1075         (print_return_value): Likewise.
1076
1077 2019-01-05  Tom Tromey  <tom@tromey.com>
1078
1079         * contrib/cleanup_check.py: Remove.
1080         * contrib/gcc-with-excheck: Remove.
1081         * contrib/exsummary.py: Remove.
1082         * contrib/excheck.py: Remove.
1083
1084 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1085
1086         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1087         NULL. Initialize tpprev to NULL instead of assigning it
1088         to NULL on the next statement.
1089         * windows-nat.c (windows_delete_thread): Remove check for
1090         main_thread_id before printing thread exit notifications.
1091         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1092         Remove thread ID check against main_thread_id.
1093         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1094         windows_delete_thread.
1095         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1096
1097 2019-01-04  Tom Tromey  <tom@tromey.com>
1098
1099         * compile/compile.c (_initialize_compile): Use upper case for
1100         metasyntactic variables.
1101         * symmisc.c (_initialize_symmisc): Use upper case for
1102         metasyntactic variables.
1103         * psymtab.c (_initialize_psymtab): Use upper case for
1104         metasyntactic variables.
1105         * demangle.c (demangle_command): Use upper case for metasyntactic
1106         variables.
1107         (_initialize_demangler): Likewise.
1108         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1109         variables.
1110
1111 2019-01-03  Tom Tromey  <tom@tromey.com>
1112
1113         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1114
1115 2019-01-03  Tom Tromey  <tom@tromey.com>
1116
1117         * python/py-symtab.c (salpy_str): Update.
1118         (struct salpy_sal_object) <symtab>: Now a PyObject.
1119         (salpy_dealloc): Update.
1120         (del_objfile_sal): Use gdbpy_ref.
1121
1122 2019-01-03  Tom Tromey  <tom@tromey.com>
1123
1124         * python/py-type.c (convert_field): Use new_reference.  Return
1125         gdbpy_ref.
1126         (make_fielditem): Return gdbpy_ref.
1127         (typy_fields): Update.
1128         (typy_getitem): Update.
1129         (field_name): Return gdbpy_ref.  Use new_reference.
1130         (typy_iterator_iternext): Update.
1131
1132 2019-01-03  Tom Tromey  <tom@tromey.com>
1133
1134         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1135
1136 2019-01-03  Tom Tromey  <tom@tromey.com>
1137
1138         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1139         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1140         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1141         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1142         (pspy_set_type_printers): Likewise.
1143         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1144         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1145         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1146         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1147         (objfpy_set_type_printers): Likewise.
1148
1149 2019-01-03  Tom Tromey  <tom@tromey.com>
1150
1151         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1152         (gdbpy_print_stack): Use gdbpy_err_fetch.
1153         * python/python-internal.h (class gdbpy_err_fetch): New class.
1154         (class gdbpy_enter) <m_error_type, m_error_value,
1155         m_error_traceback>: Remove.
1156         <m_error>: New member.
1157         (gdbpy_exception_to_string): Don't declare.
1158         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1159         * python/py-value.c (convert_value_from_python): Use
1160         gdbpy_err_fetch.
1161         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1162         gdbpy_exception_to_string.
1163         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1164         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1165         gdbpy_err_fetch.
1166
1167 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1168
1169         * linux-nat.c (delete_lwp_cleanup): Delete.
1170         (struct lwp_deleter): New struct.
1171         (lwp_info_up): New typedef.
1172         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1173         lwp_info_up.
1174
1175 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1176
1177         * linux-fork.c (class scoped_switch_fork_info): New class.
1178         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1179
1180 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * valops.c (find_overload_match): Remove use of null_cleanup, and
1183         calls to do_cleanups.
1184
1185 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1186
1187         * compile/compile-cplus-types.c
1188         (compile_cplus_instance::decl_name): Handle changes to
1189         cp_func_name.
1190         * cp-support.c (cp_func_name): Update header comment, update
1191         return type.
1192         * cp-support.h (cp_func_name): Update return type in declaration.
1193         * valops.c (find_overload_match): Move temp_func local to top
1194         level of function and change its type.  Use temp_func to hold and
1195         delete temporary string obtained from cp_func_name.
1196
1197 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1200         gdb::char_vector, remove cleanup, and update uses of `msg`.
1201
1202 2019-01-03  Jim Wilson  <jimw@sifive.com>
1203
1204         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1205
1206 2019-01-02  Tom Tromey  <tom@tromey.com>
1207
1208         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1209         (tdesc_parse_xml): Remove cleanups.
1210         * target-descriptions.h (make_cleanup_free_target_description):
1211         Don't declare.
1212         (target_desc_deleter): New struct.
1213         (target_desc_up): New typedef.
1214         * target-descriptions.c (target_desc_deleter::operator()): Rename
1215         from free_target_description.
1216         (make_cleanup_free_target_description): Remove.
1217
1218 2019-01-02  Tom Tromey  <tom@tromey.com>
1219
1220         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1221         constructor, destructor.
1222         (linespec_parser): Remove typedef.
1223         (~linespec_parser): Rename from linespec_parser_delete.
1224         (linespec_lex_to_end, linespec_complete_label)
1225         (linespec_complete): Update.
1226         (decode_line_full): Remove cleanups.
1227         (decode_line_1): Update.
1228
1229 2019-01-02  Tom Tromey  <tom@tromey.com>
1230
1231         * python/python-internal.h (inferior_to_inferior_object): Change
1232         return type.
1233         * python/py-exitedevent.c (create_exited_event_object): Update.
1234         * python/py-inferior.c (inferior_to_inferior_object): Return
1235         gdbpy_ref.
1236         (python_new_inferior, python_inferior_deleted)
1237         (thread_to_thread_object, delete_thread_object)
1238         (build_inferior_list, gdbpy_selected_inferior): Update.
1239         * python/py-infthread.c (create_thread_object): Update.  Also fail
1240         if inferior_to_inferior_object fails.
1241
1242 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1243
1244         * inferior.h (class inferior) <displaced_step_state>: New field.
1245         * infrun.h (struct displaced_step_state): Move here from
1246         infrun.c.  Initialize fields, add constructor.
1247         <inf>: Remove field.
1248         <reset>: New method.
1249         * infrun.c (struct displaced_step_inferior_state): Move to
1250         infrun.h.
1251         (displaced_step_inferior_states): Remove.
1252         (get_displaced_stepping_state): Adust.
1253         (displaced_step_in_progress_any_inferior): Adjust.
1254         (displaced_step_in_progress_thread): Adjust.
1255         (displaced_step_in_progress): Adjust.
1256         (add_displaced_stepping_state): Remove.
1257         (get_displaced_step_closure_by_addr): Adjust.
1258         (remove_displaced_stepping_state): Remove.
1259         (infrun_inferior_exit): Call displaced_step_state.reset.
1260         (use_displaced_stepping): Don't check for NULL.
1261         (displaced_step_prepare_throw): Call
1262         get_displaced_stepping_state.
1263         (displaced_step_fixup): Don't check for NULL.
1264         (prepare_for_detach): Don't check for NULL.
1265
1266 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1267
1268         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1269          in case of call that did not complete.
1270
1271 2019-01-02  Andrey Utkin  <autkin@undo.io>
1272
1273         * symfile.c (find_separate_debug_file): Fix search of debug files for
1274         remote debuggee.
1275
1276 2019-01-02  Tom Tromey  <tom@tromey.com>
1277
1278         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1279         indentation.
1280         * python/py-frame.c (frapy_older): Remove cast.
1281         (frapy_newer): Likewise.
1282         * python/py-breakpoint.c (local_setattro): Remove cast.
1283         * python/py-arch.c (archpy_name): Remove local variable.
1284         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1285
1286 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1287
1288         * unittests/basic_string_view/element_access/char/empty.cc:
1289         Fix year range in copyright header.
1290
1291 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1292
1293         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1294         Delete.
1295         <operator==>: Update with for removed field.
1296         <hash>: Likewise.
1297         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1298         <isa_features>: ...this.
1299         <abi_features>: New field.
1300         (riscv_isa_flen): Update comment.
1301         (riscv_abi_xlen): New declaration.
1302         (riscv_abi_flen): New declaration.
1303         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1304         isa_features.
1305         (riscv_abi_xlen): New function.
1306         (riscv_isa_flen): Update to get answer from isa_features.
1307         (riscv_abi_flen): New function.
1308         (riscv_has_fp_abi): Update to get answer from abi_features.
1309         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1310         xlen and flen.
1311         (riscv_call_info) <xlen, flen>: Update comment.
1312         (riscv_call_arg_struct): Remove invalid assertions
1313         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1314         is removed.
1315         (riscv_gdbarch_init): Gather isa features and abi features
1316         separately, ensure both match on the gdbarch when reusing an old
1317         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1318         a target with 64-bit float hardware.
1319
1320 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1321
1322         * source.c (search_command_helper): Stop reverse search
1323         when line 1 has been searched.
1324
1325 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1326
1327         * record-full.c (record_full_base_target::close): Rewrite
1328         record_full_core_buf_list free logic.
1329
1330 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1331
1332         * break-catch-syscall.c (print_one_catch_syscall): xfree
1333         the last text.
1334
1335 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1336
1337         * top.c (print_gdb_version): Update Copyright year in version
1338         message.
1339
1340 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1341
1342         Update copyright year range in all GDB files.
1343
1344 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1345
1346         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1347
1348 For older changes see ChangeLog-2018.
1349 \f
1350 Local Variables:
1351 mode: change-log
1352 left-margin: 8
1353 fill-column: 74
1354 version-control: never
1355 coding: utf-8
1356 End:
1357