gdb/ChangeLog

   1 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
   4         comments.
   5         (print_frame_info_auto, print_frame_info_source_line,
   6         print_frame_info_location, print_frame_info_source_and_location,
   7         print_frame_info_location_and_address, print_frame_info_short_location):
   8         New declarations.
   9         (struct frame_print_options): New member print_frame_info.
  10         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
  11         * stack.h (get_user_print_what_frame_info): New declaration.
  12         (frame_show_address): New declaration.
  13         * stack.c (print_frame_arguments_choices): New value 'presence'.
  14         (print_frame_info_auto, print_frame_info_source_line,
  15         print_frame_info_location, print_frame_info_source_and_location,
  16         print_frame_info_location_and_address, print_frame_info_short_location,
  17         print_frame_info_choices, print_frame_info_print_what): New definitions.
  18         (print_frame_args): Only print dots for args if print frame-arguments
  19         is 'presence'.
  20         (frame_print_option_defs): New element for "frame-info".
  21         (get_user_print_what_frame_info): New function.
  22         (frame_show_address): Make non static.  Move comment to stack.h.
  23         (print_frame_info_to_print_what): New function.
  24         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
  25         to decide what to print.
  26         (backtrace_command_1): Handle the new print_frame_arguments_presence
  27         value.
  28         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
  29         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
  30         (py_print_frame): In non-mi mode, use LOCATION as default for
  31         print_what, similarly to frame information printed directly by
  32         backtrace command. Handle frame-info user option in non MI mode.
  33
  34 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  35
  36         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
  37         Add case for debugging 32-bit target on 64-bit host.  Revise
  38         comment.
  39
  40 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  41
  42         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
  43         instead of find_function_entry_range_from_pc.
  44
  45 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  46
  47         * stack.c (find_frame_funname): Remove code which preferred
  48         minsym over symtab sym in "certain pathological cases".
  49
  50         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
  51         parameter.  Change type of "do_demangle" to bool.
  52         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  53         Pass suitable "prefer_sym_over_minsym" flag to
  54         build_address_symbolic().  Don't output "+" for negative offsets.
  55         * printcmd.c (print_address_symbolic): Update invocation of
  56         build_address_symbolic to include a "prefer_sym_over_minsym"
  57         flag.
  58         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
  59         Restrict cases in which use of minimal symbol is preferred to that
  60         of a found symbol.  Update comments.
  61
  62         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
  63         for entry pc when entry pc is out of range for that FDE.
  64
  65         * printcmd.c (print_address_symbolic): Print negative offsets.
  66         (build_address_symbolic): Force signed arithmetic when computing
  67         offset.
  68
  69 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
  70
  71         PR gdb/24839:
  72         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
  73         type.
  74
  75 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
  76
  77         * python/py-objfile.c (add_separate_debug_file): Fix comment about
  78         this function's Python signature.
  79
  80
  81 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
  82
  83         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
  84         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  85         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  86         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
  87         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
  88
  89
  90 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
  91
  92         * h8300-tdep.c (h8300_register_name_common): New.
  93         h8300_register_name): Use h8300_register_name_common.
  94         (h8300s_register_name): Likewise.
  95         (h8300sx_register_name): Likewise.
  96         (h8300h_register_nam): New.
  97         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
  98
  99
 100 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 101
 102         * arm-tdep.c (arm_skip_cmse_entry): New function.
 103         (arm_is_sgstubs_section): New function.
 104         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 105
 106 2019-07-22  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 109         Don't self-assign.
 110
 111 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 112
 113         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 114         type_print.
 115
 116 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 117
 118         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 119         so that GDB doesn't match any msymbols when searching in the
 120         TYPES_DOMAIN.
 121         (print_symbol_info): Print using typedef_print or type_print based
 122         on the type of the symbol.  Add updated FIXME comment moved from...
 123         (_initialize_symtab): ... move and update FIXME comment to above.
 124
 125 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 126
 127         * NEWS: Mention adding -q option to "info types".
 128         * symtab.c (struct info_types_options): New struct.
 129         (info_types_options_defs): New variable.
 130         (make_info_types_options_def_group): New function.
 131         (info_types_command): Use gdb::option framework to parse options.
 132         (info_types_command_completer): New function.
 133         (_initialize_symtab): Extend the help text on "info types" and
 134         register command completer.
 135
 136 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 137
 138         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 139         (lookup_symbol_in_objfile): Change int to block_enum and add a
 140         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 141
 142 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 143
 144         * MAINTAINERS (Write After Approval): Add self.
 145
 146 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 147
 148         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 149         instruction to the dummy code region.
 150
 151 2019-07-19  Tom Tromey  <tromey@adacore.com>
 152
 153         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 154         (ARGSUSED, PARAMS, __func__): Remove rules.
 155
 156 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 157
 158         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 159         * features/arm/arm-with-iwmmxt.c: Remove.
 160         * features/arm/arm-with-iwmmxt.xml: Remove.
 161         * features/arm/arm-with-m-fpa-layout.c: Remove.
 162         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 163         * features/arm/arm-with-m-vfp-d16.c: Remove.
 164         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 165         * features/arm/arm-with-m.c: Remove.
 166         * features/arm/arm-with-m.xml: Remove.
 167         * features/arm/arm-with-neon.c: Remove.
 168         * features/arm/arm-with-neon.xml: Remove.
 169         * features/arm/arm-with-vfpv2.c: Remove.
 170         * features/arm/arm-with-vfpv2.xml: Remove.
 171         * features/arm/arm-with-vfpv3.c: Remove.
 172         * features/arm/arm-with-vfpv3.xml: Remove.
 173
 174 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 175
 176         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 177
 178 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 179
 180         * arch/aarch32.c (aarch32_create_target_description): Create
 181         target descriptions using features.
 182         * arch/arm.c (arm_create_target_description)
 183         (arm_create_mprofile_target_description): Likewise.
 184         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 185
 186 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 187
 188         * Makefile.in: Add new files.
 189         * aarch32-tdep.c: New file.
 190         * aarch32-tdep.h: New file.
 191         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 192         Call aarch32_read_description.
 193         * arch/aarch32.c: New file.
 194         * arch/aarch32.h: New file.
 195         * arch/arm.c (arm_create_target_description)
 196         (arm_create_mprofile_target_description): New function.
 197         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 198         (arm_create_target_description)
 199         (arm_create_mprofile_target_description): New declaration.
 200         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 201         read_description functions.
 202         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 203         Likewise.
 204         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 205         * arm-tdep.c (tdesc_arm_list): New variable.
 206         (arm_register_g_packet_guesses): Call create description functions.
 207         (arm_read_description) (arm_read_mprofile_description): New
 208         function.
 209         * arm-tdep.h (arm_read_description)
 210         (arm_read_mprofile_description): Add declaration.
 211         * configure.tgt: Add new files.
 212
 213 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 214
 215         * top.c (new_ui_command): Open specified terminal just once.
 216
 217 2019-07-18  Tom Tromey  <tromey@adacore.com>
 218
 219         * symtab.c (main_name): Constify return type.
 220         * symfile.c (set_initial_language): Update.
 221         * symtab.h (main_name): Constify return type.
 222
 223 2019-07-17  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-winsource.c (tui_update_source_window)
 226         (tui_update_source_window_as_is)
 227         (tui_update_source_windows_with_line): Remove return.
 228         * tui/tui-disasm.c (tui_show_disassem)
 229         (tui_show_disassem_and_update_source): Remove return.
 230         * tui/tui.c (tui_reset): Remove return.
 231         * tui/tui-wingeneral.c
 232         (tui_check_and_display_highlight_if_needed): Remove return.
 233
 234 2019-07-17  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 237
 238 2019-07-17  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui-winsource.h (struct tui_exec_info_window)
 241         (struct tui_source_window_base): Move from tui-data.h.
 242         * tui/tui-winsource.c: Move many method definitions from
 243         elsewhere.  Remove "structuring" comments.
 244         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 245         (tui_source_window_base::refresh_window): Move to
 246         tui-winsource.c.
 247         * tui/tui-win.c (tui_source_window_base::refresh_all)
 248         (tui_source_window_base::update_tab_width)
 249         (tui_source_window_base::set_new_height)
 250         (tui_source_window_base::do_make_visible_with_new_height): Move to
 251         tui-winsource.c.
 252         * tui/tui-source.h: Update.
 253         * tui/tui-source.c (tui_source_window_base::reset): Move to
 254         tui-winsource.c.
 255         * tui/tui-disasm.h: Update.
 256         * tui/tui-data.h (struct tui_exec_info_window): Move to
 257         tui-winsource.h.
 258         (struct tui_source_window_base): Likewise.
 259         * tui/tui-data.c (tui_source_window_base::clear_detail)
 260         (tui_source_window_base, ~tui_source_window_base): Move to
 261         tui-winsource.c.
 262
 263 2019-07-17  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-win.c (tui_resize_all)
 266         (tui_source_window_base::update_tab_width)
 267         (tui_adjust_win_heights): Update.
 268         (tui_win_info::make_invisible_and_set_new_height): Rename from
 269         make_invisible_and_set_new_height.
 270         * tui/tui-data.h (struct tui_win_info)
 271         <make_invisible_and_set_new_height>: New method.
 272
 273 2019-07-17  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui.c: Update.
 276         * tui/tui-source.h (struct tui_source_window): Move from
 277         tui-data.h.
 278         * tui/tui-layout.c: Update.
 279         * tui/tui-disasm.c: Update.
 280         * tui/tui-data.h (struct tui_source_window): Move to
 281         tui-source.h.
 282
 283 2019-07-17  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 286         tui-data.h.
 287         * tui/tui-data.h (struct tui_disasm_window): Move to
 288         tui-disasm.h.
 289
 290 2019-07-17  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-regs.h (struct tui_data_item_window): Move from
 293         tui-data.h.
 294         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 295         * tui/tui-data.h (struct tui_data_item_window): Move to
 296         tui-regs.h.
 297         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 298
 299 2019-07-17  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui.c: Update.
 302         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 303         (tui_cmd_window::max_height): Move to tui-command.c.
 304         * tui/tui-layout.c: Update.
 305         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 306         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 307         tui-command.c.
 308         * tui/tui-command.h (struct tui_cmd_window): Move from
 309         tui-data.h.
 310         * tui/tui-command.c: Remove "structuring" comments.
 311         (tui_cmd_window::clear_detail)
 312         (tui_cmd_window::do_make_visible_with_new_height)
 313         (tui_cmd_window::max_height): Move from elsewhere.
 314
 315 2019-07-17  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 318         Now static.
 319         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 320         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 321
 322 2019-07-17  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui.c: Update.
 325         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 326         tui-regs.c.
 327         * tui/tui-windata.h: Remove file.
 328         * tui/tui-windata.c: Remove file.
 329         * tui/tui-win.c (tui_data_window::set_new_height)
 330         (tui_data_window::do_make_visible_with_new_height): Move to
 331         tui-regs.c.
 332         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 333         * tui/tui-regs.c: Remove "structuring" comments.
 334         (tui_data_window::first_data_item_displayed)
 335         (tui_data_window::delete_data_content_windows)
 336         (tui_data_window::erase_data_content)
 337         (tui_data_window::display_all_data)
 338         (tui_data_window::refresh_all)
 339         (tui_data_window::do_scroll_vertical)
 340         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 341         (tui_data_window::do_make_visible_with_new_height)
 342         (tui_data_window::refresh_window): Move from elsewhere.
 343         (_initialize_tui_regs): Move to end of file.
 344         * tui/tui-layout.c: Update.
 345         * tui/tui-hooks.c: Update.
 346         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 347         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 348         tui-regs.c.
 349         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 350
 351 2019-07-17  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 354         seen.
 355
 356 2019-07-17  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-win.c (tui_source_window_base::set_new_height)
 359         (tui_source_window_base::do_make_visible_with_new_height): Use
 360         m_has_locator field directly.
 361         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 362         method.
 363         (struct tui_source_window_base) <has_locator>: Likewise.
 364
 365 2019-07-17  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 368         Don't declare.
 369         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 370         Remove.
 371         * tui/tui-win.c (tui_source_window_base::set_new_height)
 372         (tui_source_window_base::set_new_height)
 373         (make_invisible_and_set_new_height)
 374         (tui_source_window_base::do_make_visible_with_new_height)
 375         (tui_source_window_base::do_make_visible_with_new_height):
 376         Update.
 377         * tui/tui-layout.c (show_source_disasm_command, show_data)
 378         (show_source_or_disasm_and_command): Update.
 379         * tui/tui-layout.c (show_layout): Update.
 380
 381 2019-07-17  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-layout.c (make_data_window): Remove.
 384         (show_data): Unify creation and re-initialization cases.
 385
 386 2019-07-17  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-layout.c (make_source_window, make_disasm_window):
 389         Remove.
 390         (show_data): Unify creation and re-initialization cases.
 391
 392 2019-07-17  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-layout.c (make_command_window): Remove.
 395         (show_source_disasm_command, show_source_or_disasm_and_command):
 396         Unify creation and re-initialization cases.
 397
 398 2019-07-17  Tom Tromey  <tom@tromey.com>
 399
 400         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 401         creation and re-initialization cases.
 402
 403 2019-07-17  Tom Tromey  <tom@tromey.com>
 404
 405         * tui/tui-regs.c (tui_get_register): Return void.
 406
 407 2019-07-17  Tom Tromey  <tom@tromey.com>
 408
 409         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 410         Simplify.
 411
 412 2019-07-17  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 415         resetting.
 416
 417 2019-07-17  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 420         * tui/tui-regs.c (tui_reg_layout): New function.
 421         (tui_show_registers, tui_reg_command): Use it.
 422         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 423         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 424         parameters.
 425         (tui_layout_command): Remove.
 426
 427 2019-07-17  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-layout.h (tui/tui-layout): Return void.
 430         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 431
 432 2019-07-17  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-layout.c (show_source_disasm_command, show_data):
 435         Update.
 436         (reset_locator): Remove.
 437         (show_source_or_disasm_and_command): Update.
 438
 439 2019-07-17  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-source.c (tui_source_window_base::reset): Remove
 442         win_type parameter.
 443         * tui/tui-layout.c (make_command_window, make_source_window)
 444         (make_disasm_window, make_data_window)
 445         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 446         (reset_locator, show_source_or_disasm_and_command): Update.
 447         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 448         win_type parameter.
 449         (struct tui_source_window_base) <reset>: Likewise.
 450
 451 2019-07-17  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-layout.c (show_source_disasm_command): Use
 454         reset_locator.
 455         (reset_locator): New function.
 456         (init_and_make_win): Remove.
 457         (show_source_or_disasm_and_command): Use reset_locator.
 458
 459 2019-07-17  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 462         condition.
 463         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 464         Remove condition.
 465         * tui/tui-source.c (tui_source_window_base::reset): New method.
 466         * tui/tui-layout.c (make_command_window): Don't call
 467         init_and_make_win.
 468         (make_source_window, make_disasm_window): Don't call
 469         make_source_or_disasm_window.
 470         (make_data_window): Don't call init_and_make_win.  Change calling
 471         convention.
 472         (show_source_disasm_command, show_data): Simplify.
 473         (make_source_or_disasm_window): Remove.
 474         (show_source_or_disasm_and_command): Simplify.
 475         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 476         (struct tui_source_window_base) <reset>: Likewise.
 477         <execution_info>: Remove initializer.
 478         * tui/tui-data.c (tui_source_window_base): Initialize
 479         execution_info.
 480
 481 2019-07-17  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 484         variable.
 485
 486 2019-07-17  Tom Tromey  <tom@tromey.com>
 487
 488         * tui/tui.c (tui_rl_other_window): Update.
 489         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 490         superclass method first.  Always iterate over regs_content.
 491         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 492         method.
 493         * tui/tui-win.c (tui_set_focus_command): Update.
 494
 495 2019-07-17  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-win.c (tui_set_focus_command): Rename from
 498         tui_set_focus.  Call tui_enable.
 499         (tui_set_focus_command): Remove.
 500
 501 2019-07-17  Tom Tromey  <tom@tromey.com>
 502
 503         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 504         refresh_window.
 505         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 506         touchwin.
 507         (tui_data_window::refresh_window): Call refresh_window on data
 508         items.  Always call superclass refresh_window.
 509         (tui_win_info::refresh): Remove.
 510         (tui_source_window_base::refresh_window): Update.
 511         (tui_refresh_all): Update.
 512         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 513         refresh_window.
 514         (show_source_or_disasm_and_command): Likewise.
 515         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 516         (struct tui_source_window_base) <refresh>: Likewise.
 517
 518 2019-07-17  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-winsource.c (tui_clear_source_content)
 521         (tui_show_source_content): Update.
 522         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 523         whether content is empty.
 524         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 525         Remove.
 526
 527 2019-07-17  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 530         window's contents.
 531         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 532         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 533
 534 2019-07-17  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 537         (struct tui_data_item_window): Update.
 538
 539 2019-07-17  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 542         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 543         defines.
 544
 545 2019-07-17  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui-winsource.h (tui_erase_source_content)
 548         (tui_clear_source_content): Remove "display_prompt" parameter.
 549         * tui/tui-winsource.c (tui_update_source_window_as_is)
 550         (tui_update_source_windows_with_addr): Update.
 551         (tui_clear_source_content): Remove "display_prompt" parameter.
 552         (tui_erase_source_content): Likewise.  Simplify.
 553         (tui_show_source_content): Update.
 554         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 555         * tui/tui-stack.c (tui_show_frame_info): Update.
 556         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 557         Remove defines.
 558
 559 2019-07-17  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 562         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 563         parameter.
 564         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 565         parameter.
 566
 567 2019-07-17  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-winsource.c (tui_clear_source_content)
 570         (tui_show_source_content, tui_show_exec_info_content)
 571         (tui_clear_exec_info_content): Update.
 572         * tui/tui-stack.c (tui_show_locator_content): Update.
 573         (tui_show_frame_info): Update.
 574         * tui/tui-source.h (tui_source_window): Don't declare.
 575         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 576         from tui_source_is_displayed.
 577         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 578         Remove field.
 579         (struct tui_source_window_base) <content_in_use>: New field.  Now
 580         bool.
 581         (struct tui_source_window) <showing_source_p>: New method.
 582         (TUI_SRC_WIN): Change cast.
 583         * tui/tui-data.c (tui_initialize_static_data): Update.
 584
 585 2019-07-17  Tom Tromey  <tom@tromey.com>
 586
 587         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 588         location_matches_p.
 589         * tui/tui-source.c (tui_source_window::location_matches_p): New
 590         method.
 591         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 592         method.
 593         * tui/tui-data.h (struct tui_source_window_base)
 594         <location_matches_p>: New method.
 595         (struct tui_source_window, struct tui_disasm_window)
 596         <location_matches_p>: Likewise.
 597
 598 2019-07-17  Tom Tromey  <tom@tromey.com>
 599
 600         * tui/tui-win.c (tui_set_win_height_command): Rename from
 601         tui_set_win_height.
 602         (tui_set_win_height_command): Remove.
 603
 604 2019-07-17  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-source.c (tui_source_window): New constructor.  Add
 607         observer.
 608         (~tui_source_window): New destructor.
 609         (tui_source_window::style_changed): New method.
 610         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 611         (tui_attach_detach_observers): Update.
 612         * tui/tui-data.h (struct tui_source_window): Make constructor not
 613         inline.  Add destructor.
 614         (struct tui_source_window) <style_changed>: New method.
 615         <m_observable>: New member.
 616
 617 2019-07-17  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 620         * tui/tui-win.c (tui_resize_all): Fix typo.
 621
 622 2019-07-17  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 625         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 626         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 627         * tui/tui-win.c (window_name_completer): Use foreach.
 628         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 629         (update_tab_width): Likewise.
 630         * tui/tui-layout.c (show_layout): Update.
 631         * tui/tui-data.h (class tui_window_iterator): New.
 632         (struct all_tui_windows): New.
 633         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 634
 635 2019-07-17  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 638         parameter.  Don't reference globals.
 639         (tui_reg_command): Update.
 640
 641 2019-07-17  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-regs.c (tui_show_registers): Simplify.
 644
 645 2019-07-17  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui-regs.c (tui_show_registers): Update.
 648         (tui_show_register_group): Add win_info parameter.
 649
 650 2019-07-17  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 653         Rename from tui_display_reg_element_at_line.
 654         (tui_data_window::display_registers_from_line): Update.
 655         * tui/tui-data.h (struct tui_data_window)
 656         <display_reg_element_at_line>: New method.
 657
 658 2019-07-17  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-regs.h (tui_display_registers_from)
 661         (tui_display_registers_from_line): Don't declare.
 662         * tui/tui-windata.c (tui_data_window::display_all_data)
 663         (tui_data_window::refresh_all)
 664         (tui_data_window::do_scroll_vertical): Update.
 665         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 666         from tui_display_registers_from.
 667         (tui_display_reg_element_at_line): Update.
 668         (tui_data_window::display_registers_from_line): Rename from
 669         tui_display_registers_from_line.
 670         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 671         display_registers_from_line>: New methods.
 672
 673 2019-07-17  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 676         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 677         from tui_erase_data_content.
 678         (tui_data_window::display_all_data)
 679         (tui_data_window::refresh_all)
 680         (tui_data_window::do_scroll_vertical): Update.
 681         * tui/tui-regs.c (tui_show_registers): Update.
 682         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 683         New method.
 684
 685 2019-07-17  Tom Tromey  <tom@tromey.com>
 686
 687         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 688         declare.
 689         * tui/tui-windata.c
 690         (tui_data_window::delete_data_content_windows): Rename from
 691         tui_delete_data_content_windows.
 692         (tui_data_window::display_all_data)
 693         (tui_data_window::do_scroll_vertical): Update.
 694         * tui/tui-data.h (struct tui_data_window)
 695         <delete_data_content_windows>: New method.
 696
 697 2019-07-17  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 700         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 701
 702 2019-07-17  Tom Tromey  <tom@tromey.com>
 703
 704         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 705         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 706         from tui_display_all_data.
 707         * tui/tui-win.c
 708         (tui_data_window::do_make_visible_with_new_height): Update.
 709         * tui/tui-regs.c (tui_show_registers): Update.
 710         * tui/tui-layout.c (tui_set_layout): Update.
 711         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 712         method.
 713
 714 2019-07-17  Tom Tromey  <tom@tromey.com>
 715
 716         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 717         * tui/tui-windata.c (tui_display_data_from): Remove.
 718         (tui_data_window::refresh_all): Update.
 719
 720 2019-07-17  Tom Tromey  <tom@tromey.com>
 721
 722         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 723         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 724         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 725         tui_display_registers_from_line.
 726         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 727         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 728         "force_display" parameter.
 729
 730 2019-07-17  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 733         declare.
 734         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 735         Rename from tui_first_reg_element_no_inline.
 736         (tui_display_reg_element_at_line)
 737         (tui_display_registers_from_line): Update.
 738         * tui/tui-data.h (struct tui_data_window)
 739         <first_reg_element_no_inline>: New method.
 740
 741 2019-07-17  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui-windata.c (tui_display_data_from)
 744         (tui_data_window::do_scroll_vertical): Update.
 745         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 746         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 747         Rename from tui_line_from_reg_element_no.
 748         (tui_display_registers_from_line): Update.
 749         * tui/tui-data.h (struct tui_data_window)
 750         <line_from_reg_element_no>: New method.
 751
 752 2019-07-17  Tom Tromey  <tom@tromey.com>
 753
 754         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 755         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 756         tui_last_regs_line_no.
 757         (tui_display_reg_element_at_line)
 758         (tui_display_registers_from_line): Update.
 759         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 760         method.
 761
 762 2019-07-17  Tom Tromey  <tom@tromey.com>
 763
 764         PR tui/24722:
 765         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 766         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 767         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 768         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 769         (tui_update_breakpoint_info): Likewise.
 770         * tui/tui-hooks.c (tui_event_create_breakpoint)
 771         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 772         Update.
 773
 774 2019-07-17  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 777
 778 2019-07-17  Tom Tromey  <tom@tromey.com>
 779
 780         * tui/tui-winsource.c (tui_update_source_window_as_is)
 781         (tui_update_source_windows_with_addr): Update.
 782         * tui/tui-source.h (tui_set_source_content)
 783         (tui_show_symtab_source): Add "win_info" parameter.
 784         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 785         parameter.
 786         (tui_show_symtab_source): Likewise.
 787
 788 2019-07-17  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-wingeneral.c
 791         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 792
 793 2019-07-17  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 796         (struct tui_cmd_window) <can_scroll>: New method.
 797         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 798         method.
 799
 800 2019-07-17  Tom Tromey  <tromey@adacore.com>
 801
 802         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 803         do_field_signed>: Rename.  Change type of "value".
 804         * ui-out.c (ui_out::field_signed): Rename from field_int.
 805         Change type of "value".
 806         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 807         type of "value".
 808         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 809         do_field_int.  Change type of "value".
 810         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 811         do_field_int.  Change type of "value".
 812         * tracepoint.c (trace_status_mi, tfind_1)
 813         (print_one_static_tracepoint_marker): Update.
 814         * thread.c (print_thread_info_1, print_selected_thread_frame):
 815         Update.
 816         * stack.c (print_frame, print_frame_info): Update.
 817         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 818         Update.
 819         * source.c (print_source_lines_base): Update.
 820         * skip.c (info_skip_command): Update.
 821         * record-btrace.c (btrace_ui_out_decode_error)
 822         (btrace_call_history_src_line): Update.
 823         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 824         Update.
 825         * progspace.c (print_program_space): Update.
 826         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 827         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 828         do_field_int.  Change type of "value".
 829         * mi/mi-out.c (mi_ui_out::do_table_begin)
 830         (mi_ui_out::do_table_header): Update.
 831         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 832         type of "value".
 833         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 834         (mi_cmd_data_list_changed_registers, output_register)
 835         (mi_cmd_data_read_memory, mi_load_progress)
 836         (mi_cmd_trace_frame_collected): Update.
 837         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 838         Update.
 839         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 840         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 841         (mi_cmd_var_list_children, varobj_update_one): Update.
 842         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 843         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 844         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 845         * inferior.c (print_inferior): Update.
 846         * gdb_bfd.c (print_one_bfd): Update.
 847         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 848         Update.
 849         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 850         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 851         do_field_int.  Change type of "value".
 852         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 853         do_field_int.  Change type of "value".
 854         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 855         (print_one_breakpoint_location, print_it_catch_fork)
 856         (print_one_catch_fork, print_it_catch_vfork)
 857         (print_one_catch_vfork, print_it_catch_solib)
 858         (print_it_catch_exec, print_it_ranged_breakpoint)
 859         (print_mention_watchpoint, print_mention_masked_watchpoint)
 860         (bkpt_print_it, update_static_tracepoint): Update.
 861         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 862         * break-catch-syscall.c (print_it_catch_syscall): Update.
 863         * ada-tasks.c (print_ada_task_info): Update.
 864         * ada-lang.c (print_it_exception, print_mention_exception):
 865         Update.
 866
 867 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         PR breakpoints/24541
 870         * gdbarch.c: Regenerate.
 871         * gdbarch.h: Regenerate.
 872         * gdbarch.sh: Adjust return type and parameter types for
 873         'stap_adjust_register'.
 874         (i386_stap_adjust_register): Adjust signature and return new
 875         register name.
 876         * stap-probe.c (stap_parse_register_operand): Adjust use of
 877         'gdbarch_stap_adjust_register'.
 878
 879 2019-07-17  Tom Tromey  <tromey@adacore.com>
 880
 881         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 882         declare VEC.
 883         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 884         std::vector.
 885         (struct s390_process_info): Add initializers.
 886         (s390_add_process): Use new.
 887         (s390_linux_nat_target::low_forget_process): Use delete.
 888         (s390_linux_nat_target::low_new_fork)
 889         (s390_linux_nat_target::stopped_by_watchpoint)
 890         (s390_linux_nat_target::low_prepare_to_resume)
 891         (s390_linux_nat_target::insert_watchpoint)
 892         (s390_linux_nat_target::insert_hw_breakpoint)
 893         (s390_linux_nat_target::remove_watchpoint)
 894         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 895
 896 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 897
 898         * aarch64-fbsd-nat.c: Include regcache.h.
 899         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 900         argument.
 901         (aarch64_fbsd_nat_target::fetch_registers)
 902         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 903         variable.
 904         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 905
 906 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 907
 908         * fbsd-nat.c: Include gdbarch.h.
 909
 910 2019-07-15  Tom Tromey  <tromey@adacore.com>
 911
 912         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 913
 914 2019-07-15  Tom Tromey  <tromey@adacore.com>
 915
 916         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 917         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 918         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 919         * cli-out.c (cli_ui_out::do_field_int): New method.
 920         * ui-out.c (ui_out::field_unsigned): New method.
 921         * symfile.c (generic_load): Use field_unsigned.
 922         (print_transfer_performance): Likewise.
 923         * record-btrace.c (ui_out_field_uint): Remove.
 924         (btrace_call_history_insn_range, btrace_call_history): Use
 925         field_unsigned.
 926         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 927         field_unsigned.
 928         * ui-out.h (class ui_out) <field_unsigned>: New method.
 929         <do_field_unsigned>: Likewise.
 930
 931 2019-07-15  Tom Tromey  <tromey@adacore.com>
 932
 933         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 934         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 935         * target.c (flash_erase_command): Use field_string.
 936         * infrun.c (print_signal_received_reason): Use field_string.
 937         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 938         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 939         field_string.
 940         * ada-tasks.c (print_ada_task_info): Use field_string.
 941
 942 2019-07-15  Tom Tromey  <tromey@adacore.com>
 943
 944         * target.c (flash_erase_command): Use field_core_addr.
 945         * symfile.c (generic_load): Use field_core_addr.
 946         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 947         Use field_core_addr.
 948         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 949         field_core_addr.
 950
 951 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 952
 953         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 954         value if its desired type is smaller than a CORE_ADDR and signed.
 955
 956 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 957
 958         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 959         of changes to field names, and use new is_reference field to
 960         decide if a property is a reference or not.
 961         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 962         field.
 963         (struct dwarf2_property_baton): Update header comment, rename
 964         'referenced_type' to 'property_type' and update comments.
 965         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 966         default property type, store in property baton, update to take
 967         accound of renamed field.
 968         (read_func_scope): Update call to attr_to_dynamic_prop.
 969         (read_array_type): Likewise.
 970         (dwarf2_per_cu_addr_sized_int_type): New function.
 971         (read_subrange_index_type): Move type finding code to
 972         dwarf2_per_cu_addr_sized_int_type.
 973         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 974         (dwarf2_per_cu_addr_type): New function.
 975         (set_die_type): Update calls to attr_to_dynamic_prop.
 976
 977 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 978
 979         * dwarf2read.c (read_subrange_index_type): New function.
 980         (read_subrange_type): Move code into new function and call it.
 981         * gdbtypes.c (create_range_type): Add some asserts.
 982
 983 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 984
 985         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 986         update return statements.
 987         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 988         declaration, and update comment to match.
 989         * gdbtypes.c (resolve_dynamic_array): Update call to
 990         dwarf2_evaluate_property to match new return type.
 991
 992 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 993
 994         * valarith.c (value_subscripted_rvalue): Change lowerbound
 995         parameter type from int to LONGEST.
 996         * value.h (value_subscripted_rvalue): Likewise in declaration.
 997
 998 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 999
1000         * cli/cli-utils.c (info_print_command_completer): New function.
1001         * cli/cli-utils.h: Add 'completer.h' include, and forward
1002         declaration for 'struct cmd_list_element'.
1003         (info_print_command_completer): Declare.
1004         * stack.c (_initialize_stack): Add completer for 'info locals' and
1005         'info args'.
1006         * symtab.c (_initialize_symtab): Add completer for 'info
1007         variables' and 'info functions'.
1008         * NEWS: Mention completion for additional info commands.
1009
1010 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1011
1012         * cli/cli-utils.c (extract_info_print_args): Delete.
1013         (extract_arg_maybe_quoted): Delete.
1014         (info_print_options_defs): New variable.
1015         (make_info_print_options_def_group): New function.
1016         (extract_info_print_options): Define new function.
1017         * cli/cli-utils.h (extract_info_print_args): Delete.
1018         (struct info_print_options): New structure.
1019         (extract_info_print_options): Declare new function.
1020         * stack.c (info_locals_command): Update to use new
1021         extract_info_print_options, also add a header comment.
1022         (info_args_command): Likewise.
1023         * symtab.c (info_variables_command): Likewise.
1024         (info_functions_command): Likewise.
1025
1026 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1027
1028         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1029         to extract string arguments.
1030         * common/common-utils.c (extract_string_maybe_quoted): New function.
1031         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1032
1033 2019-07-11  Tom Tromey  <tromey@adacore.com>
1034
1035         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1036         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1037         * top.h (gdbinit): Don't declare.
1038         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1039         into...
1040         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1041         * top.c (gdb_init): Don't call init_cli_cmds.
1042         (gdbinit): Remove.
1043         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1044
1045 2019-07-11  Tom Tromey  <tromey@adacore.com>
1046
1047         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1048         after it has been moved.
1049
1050 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1051
1052         * valops.c (value_must_coerce_to_target): Change return type to
1053         bool.
1054         * value.h (value_must_coerce_to_target): Likewise.
1055
1056 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1057
1058         * breakpoint.c (is_hardware_watchpoint): Remove
1059         forward-declaration.
1060         (is_masked_watchpoint): Change return type to bool.
1061         (is_tracepoint): Likewise.
1062         (is_breakpoint): Likewise.
1063         (is_hardware_watchpoint): Likewise.
1064         (is_watchpoint): Likewise.
1065         (is_no_memory_software_watchpoint): Likewise.
1066         (is_catchpoint): Likewise.
1067         (breakpoint_1): Make FILTER parameter's return type bool.
1068         is_masked_watchpoint): Change return type to bool.
1069         (save_breakpoints): Make FILTER parameter's return type bool.
1070         * breakpoint.h (is_breakpoint): Change return type to bool.
1071         (is_watchpoint): Likewise.
1072         (is_catchpoint): Likewise.
1073         (is_tracepoint): Likewise.
1074
1075 2019-07-10  Tom Tromey  <tom@tromey.com>
1076
1077         * defs.h: Don't include gdbarch.h.
1078         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1079         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1080         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1081         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1082         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1083         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1084         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1085         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1086         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1087         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1088         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1089         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1090         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1091         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1092         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1093         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1094         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1095         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1096         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1097         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1098         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1099         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1100         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1101         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1102         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1103         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1104         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1105
1106 2019-07-10  Tom Tromey  <tromey@adacore.com>
1107
1108         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1109         * breakpoint.c (init_ada_exception_breakpoint): Register as
1110         bp_catchpoint.
1111         (print_one_breakpoint_location, print_one_breakpoint): Use
1112         is_ada_exception_catchpoint.
1113         * ada-lang.c (class ada_catchpoint_location): Pass
1114         bp_loc_software_breakpoint to bp_location constructor.
1115         (is_ada_exception_catchpoint): New function.
1116
1117 2019-07-10  Tom Tromey  <tromey@adacore.com>
1118
1119         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1120         VEC.
1121         (struct arm_exidx_entry): New method operator<.
1122         (struct arm_exidx_data) <section_maps>: Change type.
1123         (arm_exidx_data_free): Remove.
1124         (arm_exidx_data_key): Change type.  Move lower.
1125         (arm_exidx_new_objfile): Update.
1126         (arm_compare_exidx_entries): Remove.
1127         (arm_find_exidx_entry, _initialize_arm_tdep)
1128
1129 2019-07-10  Tom Tromey  <tromey@adacore.com>
1130
1131         * solib-spu.c (ocl_program_data_key): Change type.
1132         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1133         Update.
1134
1135 2019-07-10  Tom Tromey  <tromey@adacore.com>
1136
1137         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1138         (struct solib_aix_inferior_data) <library_list>: Change type.
1139         (solib_aix_inferior_data_handle): Change type.
1140         (get_solib_aix_inferior_data): Update.
1141         (solib_aix_free_library_list): Remove.
1142         (library_list_start_library): Update.
1143         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1144         return type.
1145         (solib_aix_get_library_list)
1146         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1147         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1148
1149 2019-07-10  Tom Tromey  <tromey@adacore.com>
1150
1151         * solib-dsbt.c (struct dsbt_info): Add initializers.
1152         (solib_dsbt_pspace_data): Change type.
1153         (dsbt_pspace_data_cleanup): Remove.
1154         (get_dsbt_info, _initialize_dsbt_solib): Update.
1155
1156 2019-07-10  Tom Tromey  <tromey@adacore.com>
1157
1158         * spu-tdep.c (spu_overlay_data): Change type.
1159         (spu_get_overlay_table, spu_overlay_new_objfile)
1160         (_initialize_spu_tdep): Update.
1161
1162 2019-07-10  Tom Tromey  <tromey@adacore.com>
1163
1164         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1165         destructor.
1166         (dbx_objfile_data_key): Change type and declare later.
1167         (DBX_SYMFILE_INFO): Rewrite.
1168         * dbxread.c (dbx_objfile_data_key): Change type.
1169         (dbx_symfile_init): Update.
1170         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1171         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1172         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1173
1174 2019-07-10  Tom Tromey  <tromey@adacore.com>
1175
1176         * jit.c (jit_program_space_key): Change type.  Move lower.
1177         (get_jit_program_space_data): Update.
1178         (jit_program_space_data_cleanup): Remove.
1179         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1180         Update.
1181         (struct jit_program_space_data): Add initializers.
1182
1183 2019-07-10  Tom Tromey  <tromey@adacore.com>
1184
1185         * solib-darwin.c (struct darwin_info): Add initializers.
1186         (solib_darwin_pspace_data): Change type.
1187         (darwin_pspace_data_cleanup): Remove.
1188         (get_darwin_info, _initialize_darwin_solib): Update.
1189
1190 2019-07-10  Tom Tromey  <tromey@adacore.com>
1191
1192         * remote-sim.c (struct sim_inferior_data): Add initializers,
1193         constructor, and destructor.
1194         (sim_inferior_data_key): Change type.  Move lower.
1195         (check_for_duplicate_sim_descriptor): Update.
1196         (get_sim_inferior_data): Use new.  Update.
1197         (~sim_inferior_data_cleanup): Rename from
1198         sim_inferior_data_cleanup.  Simplify.
1199         (gdbsim_close_inferior, simulator_command)
1200         (sim_command_completer, _initialize_remote_sim): Update.
1201         (next_pid, INITIAL_PID): Move earlier.
1202
1203 2019-07-10  Tom Tromey  <tromey@adacore.com>
1204
1205         * python/python-internal.h (create_thread_object): Return
1206         gdbpy_ref.
1207         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1208         * python/py-inferior.c (struct threadlist_entry): Add
1209         constructor.
1210         <thread_obj>: Now a gdbpy_ref.
1211         (thread_to_thread_object): Update.
1212         (add_thread_object): Use new.
1213         (delete_thread_object): Use delete.
1214         (infpy_threads): Update.
1215         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1216         GIL.
1217
1218 2019-07-10  Tom Tromey  <tromey@adacore.com>
1219
1220         * valops.c (value_cast): Specialize error message for Ada.
1221
1222 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1223
1224         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1225
1226 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1227
1228         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1229         bpstat_should_step): Return bool, adjust comments.
1230         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1231         bpstat_should_step): Likewise.
1232
1233 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1234
1235         * features/Makefile: Use feature target descriptions for Arm.
1236         * features/arm/arm-core.c: Generate new file.
1237         * features/arm/arm-fpa.c: Likewise.
1238         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1239         * features/arm/arm-m-profile.c: Likewise.
1240         * features/arm/arm-vfpv2.c: Likewise.
1241         * features/arm/arm-vfpv3.c: Likewise.
1242         * features/arm/xscale-iwmmxt.c: Likewise.
1243         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1244
1245 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1246
1247         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1248         ptrace earlier.
1249
1250 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1251
1252         * features/aarch64-pauth.c: Regenerate.
1253
1254 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1255
1256         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1257         bool.
1258         (bpstat_what): Use false instead of 0.
1259
1260 2019-07-09  Pedro Alves  <palves@redhat.com>
1261
1262         * break-catch-throw.c (is_exception_catchpoint): New.
1263         * breakpoint.c (print_one_breakpoint_location): New parameter
1264         'raw_loc'.  Handle it.  Use
1265         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1266         looking at the breakpoint's type.
1267         (print_one_breakpoint): If handling "maint info breakpoints", also
1268         print locations of exception catchpoints.
1269         * breakpoint.h (is_exception_catchpoint): Declare.
1270
1271 2019-07-09  Pedro Alves  <palves@redhat.com>
1272
1273         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1274         "addr" field.
1275         (allocate_location_exception_catchpoint): New.
1276         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1277         (initialize_throw_catchpoint_ops): Install
1278         allocate_location_exception_catchpoint as allocate_location
1279         method.
1280         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1281         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1282         bp_loc_other.
1283         (breakpoint_address_is_meaningful): Delete.
1284         (bl_address_is_meaningful): New.
1285         (breakpoint_locations_match): Adjust comment.
1286         (bp_location_from_bp_type): New, factored out of...
1287         (bp_location::bp_location(breakpoint *)): ... this.
1288         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1289         factored out of...
1290         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1291         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1292         breakpoint_address_is_meaningful.
1293         (bp_locations_compare): Adjust comment.
1294         (update_global_location_list): Use bl_address_is_meaningful
1295         instead of breakpoint_address_is_meaningful.
1296         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1297         explicit.
1298         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1299         * python/py-breakpoint.c (bppy_get_location): No longer check
1300         whether location is null.
1301
1302 2019-07-09  Pedro Alves  <palves@redhat.com>
1303
1304         PR c++/15468
1305         * breakpoint.c (print_one_breakpoint_location): Remove
1306         single-location assert.
1307
1308 2019-07-09  Tom Tromey  <tom@tromey.com>
1309
1310         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1311         * configure: Rebuild.
1312         * configure.ac: Change common to gdbsupport.
1313         * gdbsupport: Rename from common.
1314         * acinclude.m4: Change common to gdbsupport.
1315         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1316         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1317         gdbsupport.
1318         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1319         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1320         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1321         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1322         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1323         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1324         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1325         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1326         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1327         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1328         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1329         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1330         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1331         coff-pe-read.c, command.h, compile/compile-c-support.c,
1332         compile/compile-c.h, compile/compile-cplus-symbols.c,
1333         compile/compile-cplus-types.c, compile/compile-cplus.h,
1334         compile/compile-loc2c.c, compile/compile.c, completer.c,
1335         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1336         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1337         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1338         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1339         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1340         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1341         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1342         features/aarch64-core.c, features/aarch64-fpu.c,
1343         features/aarch64-pauth.c, features/aarch64-sve.c,
1344         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1345         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1346         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1347         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1348         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1349         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1350         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1351         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1352         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1353         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1354         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1355         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1356         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1357         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1358         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1359         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1360         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1361         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1362         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1363         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1364         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1365         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1366         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1367         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1368         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1369         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1370         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1371         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1372         minsyms.c, mips-linux-tdep.c, namespace.h,
1373         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1374         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1375         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1376         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1377         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1378         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1379         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1380         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1381         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1382         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1383         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1384         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1385         procfs.c, producer.c, progspace.h, psymtab.h,
1386         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1387         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1388         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1389         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1390         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1391         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1392         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1393         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1394         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1395         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1396         target-memory.c, target.c, target.h, target/waitstatus.c,
1397         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1398         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1399         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1400         unittests/array-view-selftests.c,
1401         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1402         unittests/common-utils-selftests.c,
1403         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1404         unittests/format_pieces-selftests.c,
1405         unittests/function-view-selftests.c,
1406         unittests/lookup_name_info-selftests.c,
1407         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1408         unittests/mkdir-recursive-selftests.c,
1409         unittests/observable-selftests.c,
1410         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1411         unittests/parse-connection-spec-selftests.c,
1412         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1413         unittests/scoped_fd-selftests.c,
1414         unittests/scoped_mmap-selftests.c,
1415         unittests/scoped_restore-selftests.c,
1416         unittests/string_view-selftests.c, unittests/style-selftests.c,
1417         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1418         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1419         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1420         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1421         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1422         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1423
1424 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1425
1426         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1427         bool value.
1428         (decode_digits_ordinary): Set explicit_line field in sal.
1429         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1430         symtab_and_line that was set on an explicit line number in
1431         assembler code.  Do always update the recorded symtab and line if
1432         we do skip the prologue.
1433
1434 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1435
1436         * breakpoint.c (set_breakpoint_location_function): Remove
1437         explicit_loc parameter.
1438         (momentary_breakpoint_from_master): Update call to
1439         set_breakpoint_location_function.
1440         (add_location_to_breakpoint): Likewise.
1441
1442 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1443
1444         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1445         required features based on default bfd type when no specific bfd
1446         is present.
1447
1448 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1449
1450         * NEWS: Mention that GDB printf and eval commands can now print
1451         C-style and Ada-style convenience var strings without
1452         calling the inferior.
1453         * printcmd.c (printf_c_string): Locally print GDB internal var
1454         instead of transiting via the inferior.
1455         (printf_wide_c_string): Likewise.
1456
1457 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1458
1459         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1460
1461 2019-07-04  Tom Tromey  <tom@tromey.com>
1462
1463         PR tui/24724:
1464         * tui/tui-winsource.c (tui_clear_source_content): Update.
1465         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1466         (tui_update_breakpoint_info): Update.
1467         (tui_set_exec_info_content): Update.
1468         * tui/tui-source.c (tui_set_source_content_nil): Update.
1469         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1470         has_break.
1471         * tui/tui-data.h (enum tui_bp_flag): New.
1472         (tui_bp_flags): New enum flags type.
1473         (struct tui_source_element) <break_mode>: Change type.  Rename
1474         from has_break.
1475         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1476         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1477         constants.
1478         * tui/tui-winsource.h: Fix comment.
1479
1480 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1481
1482         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1483         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1484         (store_fpregs_to_thread)
1485         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1486         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1487         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1488         (IWMMXT_REGS_SIZE): Add define.
1489         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1490         (fetch_vfp_regs, store_vfp_regs)
1491         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1492         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1493
1494 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1495
1496         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1497         defines.
1498         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1499         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1500         (ARM_INT_REGISTER_SIZE): ...to this.
1501         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1502         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1503         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1504         (arm_linux_collect_gregset, supply_nwfpe_register)
1505         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1506         defines.
1507         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1508         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1509         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1510         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1511         (arm_return_in_memory, arm_store_return_value)
1512         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1513         (arm_record_ld_st_multiple): Likewise.
1514         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1515         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1516
1517 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1518
1519         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1520         AARCH64_DISPLACED_MODIFIED_INSNS.
1521         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1522         (aarch64_displaced_step_copy_insn): Likewise.
1523         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1524         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1525         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1526         ARM_DISPLACED_MODIFIED_INSNS.
1527         * arm-tdep.c (arm_gdbarch_init): Likewise.
1528         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1529         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1530         (struct arm_displaced_step_closure): Use
1531         ARM_DISPLACED_MODIFIED_INSNS.
1532
1533 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1534
1535         * features/Makefile: Remove unused xml files.
1536         * features/aarch64.xml: Remove.
1537         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1538         * features/i386/amd64-avx-avx512.xml: Remove.
1539         * features/i386/amd64-avx-linux.xml: Remove.
1540         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1541         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1542         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1543         * features/i386/amd64-avx-mpx.xml: Remove.
1544         * features/i386/amd64-avx.xml: Remove.
1545         * features/i386/amd64-linux.xml: Remove.
1546         * features/i386/amd64-mpx-linux.xml: Remove.
1547         * features/i386/amd64-mpx.xml: Remove.
1548         * features/i386/amd64.xml: Remove.
1549         * features/i386/i386-avx-avx512-linux.xml: Remove.
1550         * features/i386/i386-avx-avx512.xml: Remove.
1551         * features/i386/i386-avx-linux.xml: Remove.
1552         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1553         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1554         * features/i386/i386-avx-mpx-linux.xml: Remove.
1555         * features/i386/i386-avx-mpx.xml: Remove.
1556         * features/i386/i386-avx.xml: Remove.
1557         * features/i386/i386-linux.xml: Remove.
1558         * features/i386/i386-mmx-linux.xml: Remove.
1559         * features/i386/i386-mmx.xml: Remove.
1560         * features/i386/i386-mpx-linux.xml: Remove.
1561         * features/i386/i386-mpx.xml: Remove.
1562         * features/i386/i386.xml: Remove.
1563         * features/i386/x32-avx-avx512-linux.xml: Remove.
1564         * features/i386/x32-avx-linux.xml: Remove.
1565         * features/i386/x32-linux.xml: Remove.
1566
1567 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1568
1569         * regformats/aarch64.dat: Remove.
1570         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1571         * regformats/i386/amd64-avx-linux.dat: Remove.
1572         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1573         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1574         * regformats/i386/amd64-linux.dat: Remove.
1575         * regformats/i386/amd64-mpx-linux.dat: Remove.
1576         * regformats/i386/amd64.dat: Remove.
1577         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1578         * regformats/i386/i386-avx-linux.dat: Remove.
1579         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1580         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1581         * regformats/i386/i386-linux.dat: Remove.
1582         * regformats/i386/i386-mmx-linux.dat: Remove.
1583         * regformats/i386/i386-mpx-linux.dat: Remove.
1584         * regformats/i386/i386.dat: Remove.
1585         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1586         * regformats/i386/x32-avx-linux.dat: Remove.
1587         * regformats/i386/x32-linux.dat: Remove.
1588
1589 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1590
1591         * aarch64-tdep.c: Remove xml self tests.
1592         * amd64-linux-tdep.c: Likewise.
1593         * amd64-tdep.c: Likewise.
1594         * i386-linux-tdep.c: Likewise.
1595         * i386-tdep.c: Likewise.
1596
1597 2019-07-03  Pedro Alves  <palves@redhat.com>
1598
1599         PR cli/24732
1600         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1601         (pipe_cmd_option_defs): New.
1602         (make_pipe_cmd_options_def_group): New.
1603         (pipe_command): Use gdb::option::process_options.
1604         (pipe_command_completer): New function.
1605         (_initialize_cli_cmds): Install completer for "pipe" command.
1606
1607 2019-07-03  Pedro Alves  <palves@redhat.com>
1608
1609         * cli/cli-option.c (union option_value) <string>: New field.
1610         (struct option_def_and_value): Add ctor, move ctor, dtor and
1611         use DISABLE_COPY_AND_ASSIGN.
1612         (option_def_and_value::clear_value): New.
1613         (parse_option, save_option_value_in_ctx, get_val_type_str)
1614         (add_setshow_cmds_for_options): Handle var_string.
1615         * cli-option.h (union option_def::var_address) <string>: New
1616         field.
1617         (struct string_option_def): New.
1618         * maint-test-options.c (struct test_options_opts): Add default
1619         ctor and use DISABLE_COPY_AND_ASSIGN.
1620         <string_opt>: New field.
1621         (test_options_opts::~test_options_opts): New.
1622         (test_options_opts::dump): Also dump "-string".
1623         (test_options_option_defs): Install "string.
1624
1625 2019-07-03  Pedro Alves  <palves@redhat.com>
1626
1627         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1628         option_value with a null enumeration.
1629         (complete_options): Save the option values in the context.
1630         (save_option_value_in_ctx): New, factored out from ...
1631         (process_options): ... here.
1632         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1633         of the function.
1634         * maint-test-options.c (test_options_opts::dump): New, factored
1635         out from ...
1636         (maintenance_test_options_command_mode): ... here.
1637         (maintenance_test_options_command_completion_result): Delete.
1638         (maintenance_test_options_command_completion_text): Update
1639         comment.
1640         (maintenance_show_test_options_completion_result): Change
1641         prototype.  Just print
1642         maintenance_test_options_command_completion_text.
1643         (save_completion_result): New.
1644         (maintenance_test_options_completer_mode): Pass options context to
1645         complete_options, and then save a dump.
1646         (_initialize_maint_test_options): Use add_cmd to install "maint
1647         show test-options-completion-result".
1648
1649 2019-07-03  Pedro Alves  <palves@redhat.com>
1650
1651         * NEWS (New commands): Mention "with" and "maint with".
1652         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1653         (with_command, with_command_completer): New.
1654         (pipe_command): Adjust to new repeat_previous
1655         interface.
1656         (_initialize_cli_cmds): Install the "with" command and its "w"
1657         alias.
1658         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1659         declarations.
1660         * cli/cli-setshow.c (parse_cli_var_uinteger)
1661         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1662         argument strings for all var_types.
1663         (get_setshow_command_value_string): New, factored out from ...
1664         (do_show_command): ... this.
1665         * cli/cli-setshow.h: Include <string>.
1666         (get_setshow_command_value_string): Declare.
1667         * command.h (repeat_previous): Now returns const char *.  Adjust
1668         comment.
1669         * maint.c: Include "cli/cli-cmds.h".
1670         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1671         (_initialize_maint_cmds): Register the "maintenance with" command.
1672         * top.c (repeat_previous): Move bits from pipe_command here:
1673         Return the saved command line, if any; error out if there's no
1674         command to relaunch.
1675
1676 2019-07-03  Pedro Alves  <palves@redhat.com>
1677
1678         * NEWS (New commands): Mention "maint set/show test-settings"
1679         instead of "maint test-settings".
1680         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1681         (maintenance_test_settings_set_list): Rename to ...
1682         (maintenance_set_test_settings_list): ... this.
1683         (maintenance_test_settings_show_list): Rename to  ...
1684         (maintenance_show_test_settings_list): ... this.
1685         (maintenance_test_settings_cmd): Delete.
1686         (maintenance_test_settings_set_cmd): ...
1687         (maintenance_set_test_settings_cmd): ... this.
1688         (maintenance_test_settings_show_cmd): ...
1689         (maintenance_show_test_settings_cmd): ... this.
1690         (maintenance_test_settings_show_value_cmd):
1691         (maintenance_show_test_settings_value_cmd): ... this.
1692         (_initialize_maint_test_settings): No longer install the "maint
1693         test-settings" prefix command.  Rename "maint test-settings set"
1694         to "maint set test-settings", and "maint test-settings show" to
1695         "maint show test-settings".  Adjust all subcommands.
1696
1697 2019-07-03  Pedro Alves  <palves@redhat.com>
1698
1699         * maint-test-settings.c: Fix file's intro comment.  Replace all
1700         references to "test-options" with references to "test-settings",
1701         in comments.
1702
1703 2019-07-03  Pedro Alves  <palves@redhat.com>
1704
1705         * maint-test-settings.c (maintenance_test_settings_xxx)
1706         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1707         New.
1708         (maintenance_test_settings_enums): Use them.
1709         (maintenance_test_settings_enum): Default to
1710         maintenance_test_settings_xxx.
1711         (_initialize_maint_test_settings): Initialize
1712         MAINTENANCE_TEST_SETTINGS_FILENAME.
1713
1714 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1715
1716         * breakpoint.h (remove_breakpoints_inf): Change return type to
1717         void, move function documentation here.
1718         * breakpoint.c (remove_breakpoints_inf): Change return type to
1719         void, move function documentation to header.
1720
1721 2019-07-02  Pedro Alves  <palves@redhat.com>
1722
1723         * NEWS (Completion improvements): Mention "info threads".
1724         * thread.c (struct info_threads_opts, info_threads_option_defs)
1725         (make_info_threads_options_def_group): New.
1726         (info_threads_command): Use gdb::option::process_options.
1727         (info_threads_command_completer): New.
1728         (_initialize_thread): Use gdb::option::build_help to build the
1729         help text for "info threads".
1730
1731 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1732
1733         * defs.h (generic_load): Move from here...
1734         * symfile.h (generic_load): ... to here.  Rename name parameter
1735         to args.
1736         * symfile.c (generic_load): Add comment.
1737
1738 2019-07-01  Tom Tromey  <tromey@adacore.com>
1739
1740         * dwarf2read.c
1741         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1742         declaration of without_params.  Fix formatting.
1743
1744 2019-07-01  Tom Tromey  <tromey@adacore.com>
1745
1746         * ada-exp.y (find_primitive_type): Update.
1747         * ada-lang.h (ada_lookup_symbol): Update.
1748         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1749         parameter.
1750         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1751
1752 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1753
1754         PR breakpoints/24541
1755         * gdbarch.c: Regenerate.
1756         * gdbarch.h: Regenerate.
1757         * gdbarch.sh: Add 'stap_adjust_register'.
1758         * i386-tdep.c: Include '<unordered_set>'.
1759         (i386_stap_adjust_register): New function.
1760         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1761         * stap-probe.c (stap_parse_register_operand): Call
1762         'gdbarch_stap_adjust_register'.
1763
1764 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1765
1766         PR python/24742
1767         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1768         * python/python.c (do_start_initialization): Use 'xmalloc'
1769         instead of 'PyMem_Malloc'.
1770
1771 2019-06-28  Tom Tromey  <tromey@adacore.com>
1772
1773         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1774         for Ada.
1775
1776 2019-06-27  Tom Tromey  <tromey@adacore.com>
1777
1778         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1779         objfile_key.
1780         (arm_find_mapping_symbol, arm_record_special_symbol)
1781         (_initialize_arm_tdep): Update.
1782         (arm_objfile_data_free): Remove.
1783
1784 2019-06-27  Tom Tromey  <tromey@adacore.com>
1785
1786         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1787         to cp_print_static_field.
1788
1789 2019-06-26  Tom Tromey  <tromey@adacore.com>
1790
1791         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1792         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1793         declare.
1794
1795 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1796
1797         * features/aarch64-core.c (create_feature_aarch64_core):
1798         Regenerate.
1799         * features/aarch64-core.xml: Add cpsr flags.
1800
1801 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1802
1803         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1804         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1805
1806 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1807
1808         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1809         field.
1810         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1811         use.
1812         (arm_record_special_symbol): Don't insert new symbol in sorted
1813         position, push it at the end.
1814
1815 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1816
1817         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1818         (arm_mapping_symbol_s): Remove.
1819         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1820         (arm_mapping_symbol_vec): New typedef.
1821         (struct arm_per_objfile): Add constructor.
1822         <section_maps>: Change type to
1823         std::unique_ptr<arm_mapping_symbol_vec[]>.
1824         (arm_compare_mapping_symbols): Remove.
1825         (arm_find_mapping_symbol): Adjust to section_maps type change.
1826         (arm_objfile_data_free): Call delete on arm_per_objfile.
1827         (arm_record_special_symbol): Adjust to section_maps type change.
1828         Allocate arm_per_objfile with new.
1829
1830 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1831
1832         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1833         with the command prefix.
1834
1835 2019-06-25  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1838         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1839
1840 2019-06-25  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1843         type.
1844         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1845         protected.
1846
1847 2019-06-25  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-winsource.c
1850         (tui_source_window_base::set_is_exec_point_at): Add check against
1851         LOA_ADDRESS.
1852
1853 2019-06-25  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-source.c (tui_set_source_content): Don't check before
1856         xfree.
1857         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1858
1859 2019-06-25  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-winsource.h (tui_update_source_window_as_is)
1862         (tui_alloc_source_buffer, tui_line_is_displayed)
1863         (tui_addr_is_displayed): Change type of win_info.
1864         * tui/tui-winsource.c (tui_update_source_window_as_is)
1865         (tui_clear_source_content, tui_show_source_line)
1866         (tui_show_source_content, tui_source_window_base::refill)
1867         (tui_source_window_base::set_is_exec_point_at)
1868         (tui_source_window_base::set_is_exec_point_at)
1869         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1870         (tui_alloc_source_buffer, tui_line_is_displayed)
1871         (tui_addr_is_displayed): Change type of win_info.  Update.
1872         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1873         (tui_source_window_base::do_make_visible_with_new_height):
1874         Update.
1875         * tui/tui-source.c (tui_set_source_content)
1876         (tui_set_source_content_nil)
1877         (tui_source_window::do_scroll_vertical): Update.
1878         * tui/tui-layout.c (show_layout): Update.
1879         * tui/tui-disasm.c (tui_set_disassem_content)
1880         (tui_disasm_window::do_scroll_vertical): Update.
1881         * tui/tui-data.h (tui_win_content): Remove.
1882         (struct tui_gen_win_info) <content, content_size>: Remove.
1883         (struct tui_source_element): Add initializers and destructor.
1884         (union tui_which_element, struct tui_win_element): Remove.
1885         (struct tui_source_window_base) <content>: New field.
1886         (struct tui_data_window): Remove destructor.
1887         (tui_alloc_content, tui_free_win_content)
1888         (tui_free_all_source_wins_content): Don't declare.
1889         * tui/tui-data.c (tui_initialize_static_data): Update.
1890         (init_content_element, tui_alloc_content): Remove.
1891         (~tui_gen_win_info): Update.
1892         (~tui_data_window, tui_free_all_source_wins_content)
1893         (tui_free_win_content, free_content, free_content_elements):
1894         Remove.
1895
1896 2019-06-25  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-winsource.h (tui_clear_source_content)
1899         (tui_erase_source_content, tui_show_source_content): Change type
1900         of win_info.
1901         * tui/tui-winsource.c (tui_clear_source_content)
1902         (tui_erase_source_content, tui_show_source_content): Change type
1903         of win_info.
1904         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1905         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1906         win_info.
1907         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1908         win_info.
1909         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1910
1911 2019-06-25  Tom Tromey  <tom@tromey.com>
1912
1913         * tui/tui-winsource.c (tui_clear_source_content)
1914         (tui_source_window_base::set_is_exec_point_at): Update.
1915         * tui/tui-source.c (tui_set_source_content_nil): Update.
1916         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1917         a bool.
1918         * tui/tui-data.c (init_content_element): Update.
1919
1920 2019-06-25  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1923         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1924         * tui/tui-layout.c (init_and_make_win): Update.
1925         * tui/tui.h (enum tui_win_type): Update.
1926         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1927         tui_win_is_auxillary.
1928         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1929         tui_win_is_auxillary.
1930
1931 2019-06-25  Tom Tromey  <tom@tromey.com>
1932
1933         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1934         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1935         (tui_delete_data_content_windows, tui_display_all_data)
1936         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1937         Update.
1938         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1939         * tui/tui-regs.c (tui_last_regs_line_no)
1940         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1941         (tui_show_registers): Update.
1942         (tui_show_register_group): Return void.  Update.
1943         (tui_display_registers_from, tui_display_reg_element_at_line)
1944         (tui_display_registers_from_line, tui_check_register_values):
1945         Update.
1946         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1947         member.
1948         (struct tui_data_window) <regs_content>: Now a std::vector.
1949         <regs_content_count>: Remove.
1950         (tui_add_content_elements, tui_free_data_content): Don't declare.
1951         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1952         (init_content_element): Remove DATA_WIN case.  Add assert.
1953         (tui_add_content_elements): Remove.
1954         (tui_data_window): Update.
1955         (tui_free_data_content): Remove.
1956         (free_content_elements): Remove DATA_WIN case.
1957
1958 2019-06-25  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-data.c (tui_data_item_window): Update.
1961         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1962         * tui/tui-windata.c (tui_display_all_data)
1963         (tui_display_data_from_line): Update.
1964         (tui_check_data_values): Remove.
1965         * tui/tui-regs.c (tui_show_register_group)
1966         (tui_display_reg_element_at_line): Update.
1967         * tui/tui-hooks.c (tui_register_changed)
1968         (tui_refresh_frame_and_register_information): Call
1969         tui_check_register_values.
1970         * tui/tui-data.h (struct tui_data_window) <data_content,
1971         data_content_count, data_type>: Remove.
1972         (enum tui_data_type): Remove.
1973
1974         * tui/tui-data.c (tui_data_window::clear_detail)
1975         (~tui_data_window): Update.
1976
1977 2019-06-25  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1980         declare.
1981         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1982         Rename from tui_first_data_item_displayed.  Update.
1983         (tui_data_window::refresh_all)
1984         (tui_data_window::do_scroll_vertical): Update.
1985         * tui/tui-data.h (struct tui_data_window)
1986         <first_data_item_displayed>: Declare new method.
1987
1988 2019-06-25  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1991         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1992         contents...
1993         (tui_initialize_static_data): ...here.
1994
1995 2019-06-25  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1998         (tui_display_registers_from, tui_check_register_values): Update.
1999         (tui_display_register): Remove win_info parameter; update.
2000         (tui_get_register): Change type of parameters.
2001         * tui/tui-data.h (struct tui_data_element): Remove.
2002         (union tui_which_element) <data>: Remove.
2003         <data_window>: Change type.
2004         (struct tui_data_item_window): New.
2005         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2006         case.  Add assert.
2007         (~tui_data_item_window): New destructor.
2008         (free_content_elements): Remove DATA_ITEM_WIN case.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2013         Remove.
2014
2015 2019-06-25  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-data.h (struct tui_command_element): Remove.
2018         (union tui_which_element) <command>: Remove.
2019         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2020         assert.
2021         (free_content_elements): Remove CMD_WIN case.
2022
2023 2019-06-25  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-layout.c (tui_set_layout): Update.
2026         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2027         * tui/tui-data.c (layout_def): Update.
2028
2029 2019-06-25  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2032         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2033         (tui_source_window_base::set_new_height): Update.
2034         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2035         Update.
2036         (tui_set_locator_fullname, tui_set_locator_info)
2037         (tui_show_frame_info): Update.
2038         * tui/tui-source.c (tui_set_source_content)
2039         (tui_source_is_displayed): Update.
2040         * tui/tui-layout.c (show_source_disasm_command, show_data)
2041         (show_source_or_disasm_and_command): Update.
2042         * tui/tui-disasm.c (tui_set_disassem_content)
2043         (tui_get_begin_asm_address): Update.
2044         * tui/tui-data.h (struct tui_locator_element): Remove.
2045         (union tui_which_element) <locator>: Remove.
2046         (struct tui_locator_window): New.
2047         (tui_locator_win_info_ptr): Change return type.
2048         * tui/tui-data.c (_locator): Change type.
2049         (tui_locator_win_info_ptr): Change return type.
2050         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2051         (tui_alloc_content): Add assert.
2052
2053 2019-06-25  Tom Tromey  <tom@tromey.com>
2054
2055         * tui/tui-winsource.c
2056         (tui_exec_info_window::maybe_allocate_content): New method.
2057         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2058         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2059         (make_source_or_disasm_window): Add cast.
2060         * tui/tui-data.h (union tui_which_element) <simple_string>:
2061         Remove.
2062         (struct tui_source_info): New.
2063         (struct tui_source_window_base) <execution_info>: Change type.
2064         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2065         case, and add assert.
2066         (tui_alloc_content): Add assert.
2067
2068 2019-06-25  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2071         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2072         * tui/tui-data.c (tui_alloc_win_info): Remove.
2073
2074 2019-06-25  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2077         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2078         can_highlight.
2079
2080 2019-06-25  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2083         make_visible_with_new_height method.
2084         (tui_win_info::make_visible_with_new_height): New method.
2085         (tui_source_window_base::do_make_visible_with_new_height)
2086         (tui_data_window::do_make_visible_with_new_height)
2087         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2088         (make_visible_with_new_height): Remove.
2089         (tui_resize_all, tui_adjust_win_heights): Use
2090         make_visible_with_new_height method.
2091         * tui/tui-data.h (struct tui_win_info)
2092         <do_make_visible_with_new_height, make_visible_with_new_height>:
2093         New methods.
2094         (struct tui_source_window_base, struct tui_data_window)
2095         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2096         methods.
2097
2098 2019-06-25  Tom Tromey  <tom@tromey.com>
2099
2100         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2101         method.
2102         (update_tab_width): Call update_tab_width method.
2103         * tui/tui-data.h (struct tui_win_info)
2104         (struct tui_source_window_base) <update_tab_width>: New methods.
2105
2106 2019-06-25  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2109         parameter.
2110         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2111         parameter.
2112         (tui_gen_win_info::make_visible): Update.
2113         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2114         parameter.
2115         * tui/tui-data.h (enum tui_box): New enum.
2116         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2117
2118 2019-06-25  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2121         init_and_make_win for EXEC_INFO_WIN.
2122         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2123         longer inline.
2124         (struct tui_win_info) <~tui_win_info>: Inline.
2125         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2126         Don't declare.
2127         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2128         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2129         Remove.
2130         (tui_initialize_static_data): Update.
2131         (~tui_gen_win_info): Handle more cleanup here.
2132         (~tui_source_window_base): Delete "execution_info".
2133         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2134
2135 2019-06-25  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-layout.c (make_command_window): Don't set
2138         can_highlight.
2139         (show_source_disasm_command): Call the reset method.
2140         (show_data): Don't set can_highlight.  Call the reset method.
2141         (tui_gen_win_info::reset): Rename from init_gen_win_info
2142         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2143         (show_source_or_disasm_and_command): Call the reset method.
2144         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2145         (struct tui_cmd_window): Set can_highlight.
2146
2147 2019-06-25  Tom Tromey  <tom@tromey.com>
2148
2149         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2150         from make_visible.
2151         (tui_make_visible, tui_make_invisible): Rewrite.
2152         (tui_win_info::make_visible): Remove.
2153         (tui_source_window_base::make_visible): Update.
2154         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2155         method.  Moved from...
2156         (struct tui_win_info) <make_visible>: ...here.
2157
2158 2019-06-25  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-winsource.c
2161         (tui_source_window_base::do_scroll_horizontal): Remove direction
2162         parameter.
2163         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2164         direction parameter.
2165         * tui/tui-win.c (tui_win_info::forward_scroll)
2166         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2167         (tui_win_info::right_scroll): Update.
2168         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2169         direction parameter.
2170         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2171         direction parameter.
2172         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2173         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2174         Remove direction parameter.
2175         (struct tui_source_window_base, struct tui_source_window)
2176         (struct tui_disasm_window, struct tui_data_window)
2177         (struct tui_cmd_window): Update.
2178
2179 2019-06-25  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-winsource.h (tui_set_exec_info_content)
2182         (tui_show_exec_info_content, tui_erase_exec_info_content)
2183         (tui_clear_exec_info_content, tui_update_exec_info): Change
2184         argument to tui_source_window_base.
2185         * tui/tui-winsource.c (tui_set_exec_info_content)
2186         (tui_show_exec_info_content, tui_erase_exec_info_content)
2187         (tui_clear_exec_info_content, tui_update_exec_info): Change
2188         argument to tui_source_window_base.
2189
2190 2019-06-25  Tom Tromey  <tom@tromey.com>
2191
2192         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2193         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2194
2195 2019-06-25  Tom Tromey  <tom@tromey.com>
2196
2197         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2198         check.
2199
2200 2019-06-25  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2203         type to void.
2204         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2205         type to void.
2206         * tui/tui-source.c (tui_set_source_content): Update.
2207         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2208
2209 2019-06-25  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-win.c (window_name_completer, tui_set_focus)
2212         (tui_all_windows_info): Use name method.
2213         * tui/tui-data.h (struct tui_gen_win_info)
2214         (struct tui_source_window, struct tui_disasm_window)
2215         (struct tui_data_window, struct tui_cmd_window) <name>: New
2216         method.
2217         (tui_win_name): Don't declare.
2218         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2219         (tui_win_name): Remove.
2220
2221 2019-06-25  Tom Tromey  <tom@tromey.com>
2222
2223         * tui/tui-winsource.h (tui_update_source_window)
2224         (tui_update_source_window_as_is): Change parameter type.
2225         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2226         to be a tui_source_window_base.
2227         (tui_update_source_window_as_is): Likewise.
2228         * tui/tui-win.c (make_visible_with_new_height): Update.
2229
2230 2019-06-25  Tom Tromey  <tom@tromey.com>
2231
2232         * tui/tui-winsource.c (tui_erase_source_content)
2233         (tui_show_source_content, tui_show_exec_info_content)
2234         (tui_erase_exec_info_content): Use refresh_window method.
2235         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2236         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2237         from tui_refresh_win.
2238         (tui_data_window::refresh_window): New method.
2239         (tui_win_info::refresh, tui_source_window_base::refresh)
2240         (tui_refresh_all): Use refresh_window method.
2241         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2242         method.
2243         * tui/tui-regs.c (tui_display_register): Call refresh_window
2244         method.
2245         * tui/tui-layout.c (show_source_disasm_command)
2246         (show_source_or_disasm_and_command): Call refresh_window method.
2247         * tui/tui-data.h (struct tui_gen_win_info)
2248         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2249         New method.
2250
2251 2019-06-25  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui.c (tui_rl_other_window, tui_enable)
2254         (tui_is_window_visible, tui_get_command_dimension): Update.
2255         * tui/tui-winsource.c (tui_update_source_window_as_is)
2256         (tui_clear_source_content, tui_erase_source_content)
2257         (tui_show_source_line, tui_source_window_base::refill)
2258         (tui_source_window_base::do_scroll_horizontal)
2259         (tui_source_window_base::set_is_exec_point_at)
2260         (tui_update_breakpoint_info, tui_set_exec_info_content)
2261         (tui_alloc_source_buffer, tui_line_is_displayed)
2262         (tui_addr_is_displayed): Update.
2263         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2264         (tui_check_and_display_highlight_if_needed)
2265         (tui_win_info::make_visible, tui_win_info::refresh)
2266         (tui_refresh_all): Update.
2267         * tui/tui-windata.c (tui_first_data_item_displayed)
2268         (tui_delete_data_content_windows, tui_erase_data_content)
2269         (tui_display_all_data, tui_data_window::refresh_all)
2270         (tui_check_data_values): Update.
2271         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2272         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2273         (tui_win_info::backward_scroll, tui_refresh_all_win)
2274         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2275         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2276         (tui_source_window_base::set_new_height)
2277         (tui_data_window::set_new_height)
2278         (make_invisible_and_set_new_height)
2279         (make_visible_with_new_height, new_height_ok)
2280         (parse_scrolling_args): Update.
2281         * tui/tui-stack.c (tui_show_frame_info): Update.
2282         * tui/tui-source.c (tui_set_source_content)
2283         (tui_set_source_content_nil, tui_source_is_displayed)
2284         (tui_source_window::do_scroll_vertical): Update.
2285         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2286         (tui_display_registers_from, tui_display_reg_element_at_line)
2287         (tui_check_register_values, tui_reg_command): Update.
2288         * tui/tui-layout.c (tui_default_win_height)
2289         (show_source_disasm_command, show_data, init_and_make_win)
2290         (show_source_or_disasm_and_command): Update.
2291         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2292         (tui_redisplay_readline, tui_mld_flush)
2293         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2294         (tui_getc): Update.
2295         * tui/tui-disasm.c (tui_set_disassem_content)
2296         (tui_disasm_window::do_scroll_vertical): Update.
2297         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2298         Now virtual.
2299         (struct tui_win_info): Derive from tui_gen_win_info.
2300         <~tui_win_info>: Mark as override.
2301         <generic>: Remove member.
2302         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2303         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2304         (~tui_data_window, ~tui_win_info)
2305         (tui_free_all_source_wins_content): Update.
2306         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2307
2308 2019-06-25  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-layout.c (init_and_make_win): Use new.
2311         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2312         destructor, initializers.
2313         (tui_alloc_generic_win_info): Don't declare.
2314         * tui/tui-data.c (_locator): Add argument to constructor.
2315         (source_win, disasm_win): New globals.
2316         (exec_info): Remove.
2317         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2318         Update.
2319         (tui_alloc_generic_win_info): Remove.
2320         (init_content_element): Use new.
2321         (tui_win_info::tui_win_info): Update.
2322         (free_content_elements) <case DATA_WIN>: Use delete.
2323
2324 2019-06-25  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2327         * tui/tui-windata.c (tui_first_data_item_displayed)
2328         (tui_delete_data_content_windows): Update.
2329         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2330         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2331         (tui_display_registers_from, tui_check_register_values): Update.
2332         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2333         pointer.
2334         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2335         window.
2336         (tui_free_data_content): Update.
2337         (free_content_elements) <case DATA_WIN>: Free the window.
2338
2339 2019-06-25  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2342         Update.
2343         * tui/tui-layout.c (make_command_window)
2344         (show_source_disasm_command, show_data, init_and_make_win)
2345         (show_source_or_disasm_and_command): Update.
2346         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2347         method.
2348         <can_highight, is_highlighted>: Now bool.
2349         (tui_set_win_highlight): Don't declare.
2350         * tui/tui-data.c (tui_set_win_highlight): Remove.
2351
2352 2019-06-25  Tom Tromey  <tom@tromey.com>
2353
2354         * tui/tui-wingeneral.c (make_visible): Remove check of window
2355         type.
2356
2357 2019-06-25  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-win.c (tui_win_info::max_height)
2360         (tui_cmd_window::max_height): New methods.
2361         (new_height_ok): Call max_height.
2362         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2363         <max_height>: New method.
2364
2365 2019-06-25  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-win.c (tui_source_window_base::set_new_height)
2368         (tui_data_window::set_new_height): New methods.
2369         (make_invisible_and_set_new_height): Call set_new_height method.
2370         * tui/tui-data.h (struct tui_win_info)
2371         (struct tui_source_window_base, struct tui_data_window)
2372         <set_new_height>: New method.
2373
2374 2019-06-25  Tom Tromey  <tom@tromey.com>
2375
2376         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2377         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2378         tui_refresh_data_win.
2379         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2380         method.
2381         (tui_refresh_all_win): Call the refresh_all method.
2382         (tui_set_focus): Likewise.
2383         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2384         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2385         Likewise.
2386
2387 2019-06-25  Tom Tromey  <tom@tromey.com>
2388
2389         * tui/tui-winsource.h (tui_refill_source_window)
2390         (tui_set_is_exec_point_at): Don't declare.
2391         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2392         (tui_source_window_base::refill): Rename from
2393         tui_refill_source_window.
2394         (tui_source_window_base::do_scroll_horizontal): Update.
2395         (tui_source_window_base::set_is_exec_point_at): Rename from
2396         tui_set_is_exec_point_at.
2397         (tui_update_all_breakpoint_info): Update.
2398         * tui/tui-stack.c (tui_show_frame_info): Update.
2399         * tui/tui-layout.c (show_data): Add cast.
2400         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2401         * tui/tui-data.h (struct tui_source_window_base) <refill,
2402         set_is_exec_point_at>: New methods.
2403         (tui_source_windows, tui_add_to_source_windows): Update types.
2404         (tui_add_to_source_windows): Remove redundant declaration.
2405         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2406         (tui_source_windows): Change return type.
2407         (tui_clear_source_windows_detail): Update.
2408         (tui_add_to_source_windows): Change type of parameter.
2409         (tui_free_all_source_wins_content): Update.
2410
2411 2019-06-25  Tom Tromey  <tom@tromey.com>
2412
2413         * tui/tui-wingeneral.c (tui_win_info::refresh)
2414         (tui_source_window_base::refresh): New methods.
2415         (tui_refresh_all): Call the refresh method.
2416         * tui/tui-data.h (struct tui_win_info)
2417         (struct tui_source_window_base) <refresh>: New method.
2418
2419 2019-06-25  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui.h (tui_is_window_visible): Return bool.
2422         * tui/tui.c (tui_is_window_visible): Return bool.
2423         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2424         (tui_make_visible, tui_make_invisible)
2425         (tui_win_info::make_visible)
2426         (tui_source_window_base::make_visible, make_all_visible)
2427         (tui_make_all_visible, tui_make_all_invisible): Update.
2428         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2429         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2430         bool.
2431         (struct tui_win_info, struct tui_source_window_base)
2432         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2433         * tui/tui-data.c (tui_init_generic_part): Update.
2434
2435 2019-06-25  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2438         (tui_source_window_base::make_visible): New methods.
2439         (make_all_visible): Make method call.
2440         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2441         (struct tui_source_window_base, struct tui_cmd_window): Override
2442         make_visible.
2443         (tui_win_is_source_type): Don't declare.
2444         * tui/tui-data.c (tui_win_is_source_type): Remove.
2445
2446 2019-06-25  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2449         NULL check.
2450
2451 2019-06-25  Tom Tromey  <tom@tromey.com>
2452
2453         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2454         Inline constructor.  Add initializers for members.
2455         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2456         constructors; now inline in class.
2457
2458 2019-06-25  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-regs.c (tui_show_registers): Update.
2461         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2462         bool.
2463         * tui/tui-data.c (tui_data_window::clear_detail)
2464         (tui_data_window): Update.
2465
2466 2019-06-25  Tom Tromey  <tom@tromey.com>
2467
2468         * tui/tui-windata.c (tui_display_all_data)
2469         (tui_display_data_from_line, tui_display_data_from)
2470         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2471         Update.
2472         * tui/tui-regs.c (tui_last_regs_line_no)
2473         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2474         (tui_show_registers, tui_show_register_group)
2475         (tui_display_registers_from, tui_display_reg_element_at_line)
2476         (tui_display_registers_from_line, tui_check_register_values)
2477         (tui_reg_next, tui_reg_prev): Update.
2478         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2479         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2480         tui_data_window.
2481         (struct tui_win_info) <detail>: Remove.  Add new fields from
2482         tui_data_info.
2483         (TUI_DATA_WIN): Add cast.
2484         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2485         (~tui_data_window): Simplify.
2486
2487 2019-06-25  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-layout.c (show_source_disasm_command)
2490         (show_source_or_disasm_and_command): Update.
2491         * tui/tui-io.c (update_cmdwin_start_line)
2492         (tui_redisplay_readline): Update.
2493         * tui/tui-data.h (struct tui_command_info): Remove.
2494         (struct tui_win_info) <detail>: Remove command_info member.
2495         (struct tui_data_window) <start_line>: New member, from
2496         tui_command_info.
2497         (TUI_CMD_WIN): Add casts.
2498
2499 2019-06-25  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-winsource.c (tui_update_source_window)
2502         (tui_refill_source_window)
2503         (tui_source_window_base::do_scroll_horizontal)
2504         (tui_update_breakpoint_info, tui_set_exec_info_content)
2505         (tui_show_exec_info_content, tui_erase_exec_info_content)
2506         (tui_clear_exec_info_content): Update.
2507         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2508         Update.
2509         * tui/tui-win.c (make_invisible_and_set_new_height)
2510         (make_visible_with_new_height): Update.
2511         * tui/tui-source.c (tui_set_source_content)
2512         (tui_show_symtab_source): Update.
2513         * tui/tui-layout.c (extract_display_start_addr)
2514         (show_source_disasm_command, show_data)
2515         (make_source_or_disasm_window)
2516         (show_source_or_disasm_and_command): Update.
2517         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2518         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2519         "gdbarch".
2520         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2521         to tui_source_window_base.
2522         (struct tui_win_info) <detail>: Remove source_info member.
2523         (struct tui_source_window_base) <has_locator>: Inline.
2524         Move contents from tui_source_info; rename has_locator member to
2525         m_has_locator.
2526         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2527         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2528         header file.
2529         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2530         Simplify.
2531         (tui_free_all_source_wins_content): Cast to
2532         tui_source_window_base.
2533
2534 2019-06-25  Tom Tromey  <tom@tromey.com>
2535
2536         * tui/tui-win.c (make_invisible_and_set_new_height)
2537         (make_visible_with_new_height): Call has_locator method.
2538         * tui/tui-layout.c (show_source_disasm_command, show_data)
2539         (show_source_or_disasm_and_command): Update for bool change.
2540         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2541         (tui_win_info) <has_locator>: New method.
2542         (struct tui_source_window_base) <has_locator>: New method.
2543         (tui_win_has_locator): Don't declare.
2544         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2545         from tui_win_has_locator.
2546         (tui_source_window_base): Use false, not FALSE.
2547
2548 2019-06-25  Tom Tromey  <tom@tromey.com>
2549
2550         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2551         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2552         clear_detail method directly.
2553         (tui_clear_win_detail): Remove.
2554
2555 2019-06-25  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2558         "this", not TUI_DISASM_WIN.
2559
2560 2019-06-25  Tom Tromey  <tom@tromey.com>
2561
2562         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2563         declare.
2564         * tui/tui-winsource.c
2565         (tui_source_window_base::do_scroll_horizontal): Rename from
2566         tui_horizontal_source_scroll.
2567         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2568         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2569         from tui_vertical_data_scroll.
2570         * tui/tui-win.h (tui_scroll): Don't declare.
2571         * tui/tui-win.c (tui_win_info::forward_scroll)
2572         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2573         (tui_win_info::right_scroll): Rename and update.
2574         (tui_scroll_forward_command, tui_scroll_backward_command)
2575         (tui_scroll_left_command, tui_scroll_right_command): Update.
2576         (tui_scroll): Remove.
2577         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2578         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2579         from tui_vertical_source_scroll.
2580         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2581         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2582         from tui_vertical_disassem_scroll.
2583         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2584         do_scroll_horizontal>: New methods.
2585         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2586         Likewise.
2587         (struct tui_source_window_base): Add do_scroll_horizontal.
2588         (struct tui_source_window, struct tui_disasm_window): Add
2589         do_scroll_vertical.
2590         (struct tui_data_window, struct tui_cmd_window): Add
2591         do_scroll_horizontal and do_scroll_vertical.
2592         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2593
2594 2019-06-25  Tom Tromey  <tom@tromey.com>
2595
2596         * tui/tui-data.h (struct tui_source_window_base): New struct.
2597         (struct tui_source_window): Derive from tui_source_window_base.
2598         (struct tui_disasm_window): New struct.
2599         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2600         from tui_source_window::clear_detail.
2601         (tui_source_window_base): Rename from tui_source_window.
2602         (~tui_source_window_base): Rename from ~tui_source_window.
2603         (tui_alloc_win_info): Create a tui_disasm_window.
2604
2605 2019-06-25  Tom Tromey  <tom@tromey.com>
2606
2607         * tui/tui-data.h (struct tui_source_window)
2608         (struct tui_data_window): Declare destructors.
2609         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2610         destructors.
2611         (tui_win_info): Simplify.
2612
2613 2019-06-25  Tom Tromey  <tom@tromey.com>
2614
2615         * tui/tui-winsource.c (tui_display_main)
2616         (tui_update_source_windows_with_addr)
2617         (tui_update_all_breakpoint_info): Update.
2618         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2619         (new_height_ok, parse_scrolling_args): Update.
2620         * tui/tui-stack.c (tui_show_frame_info): Update.
2621         * tui/tui-data.h (struct tui_list): Remove.
2622         (tui_source_windows): Return a reference to a std::vector.
2623         * tui/tui-data.c (source_windows): Now a std::vector.
2624         (tui_source_windows): Change return type.
2625         (tui_clear_source_windows): Rewrite.
2626         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2627         (tui_free_all_source_wins_content): Rewrite.
2628
2629 2019-06-25  Tom Tromey  <tom@tromey.com>
2630
2631         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2632         (struct tui_data_window, struct tui_cmd_window): Declare
2633         clear_detail method.
2634         * tui/tui-data.c (tui_source_window::clear_detail)
2635         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2636         methods.
2637         (tui_clear_win_detail): Simplify.
2638
2639 2019-06-25  Tom Tromey  <tom@tromey.com>
2640
2641         * tui/tui-layout.c (make_source_window, make_disasm_window)
2642         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2643         Return the new window.
2644         (show_source_disasm_command, show_data)
2645         (show_source_or_disasm_and_command): Update.
2646
2647 2019-06-25  Tom Tromey  <tom@tromey.com>
2648
2649         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2650         parameter.  Return the new window.
2651         (show_source_disasm_command): Update and remove NULL check.
2652         (show_source_or_disasm_and_command): Update.
2653
2654 2019-06-25  Tom Tromey  <tom@tromey.com>
2655
2656         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2657
2658 2019-06-25  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui-data.h (struct tui_win_info): Make constructor
2661         protected.  Make destructor virtual.  Add initializers.
2662         (tui_source_window, tui_data_window, tui_cmd_window): New
2663         classes.
2664         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2665         constructor.  Add "type" parameter.
2666         (tui_source_window, tui_data_window, tui_cmd_window): New
2667         constructors.
2668         (tui_alloc_win_info): Instantiate the appropriate subclass.
2669
2670 2019-06-25  Tom Tromey  <tom@tromey.com>
2671
2672         * tui/tui-win.c (tui_resize_all): Use delete.
2673         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2674         destructor.
2675         (tui_free_window): Don't declare.
2676         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2677         Update.
2678
2679 2019-06-25  Tom Tromey  <tom@tromey.com>
2680
2681         * tui/tui-data.h (struct tui_win_info): Add constructor.
2682         * tui/tui-data.c (tui_alloc_win_info): Use new.
2683         (tui_free_window): Use delete.
2684
2685 2019-06-22  Tom Tromey  <tom@tromey.com>
2686
2687         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2688         declare.
2689         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2690
2691 2019-06-22  Tom Tromey  <tom@tromey.com>
2692
2693         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2694         declare.
2695         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2696
2697 2019-06-22  Tom de Vries  <tdevries@suse.de>
2698
2699         * dwarf2read.c (create_addrmap_from_aranges)
2700         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2701         instead of '%zu'.
2702
2703 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2704
2705         * dwarf2read.h (dwarf2_section_info_def): Remove.
2706         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2707         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2708         std::vector<dwarf2_section_info>.
2709         (struct dwo_file) <~dwo_file>: Remove.
2710         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2711         types field.
2712         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2713         (dwarf2_read_debug_names): Likewise.
2714         (create_debug_types_hash_table): Change parameter type to
2715         array_view, adjust code accordingly.
2716         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2717         (partial_die_info::fixup): Likewise.
2718         (determine_prefix): Likewise.
2719         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2720
2721 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2722
2723         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2724         gdb_bfd_ref_ptr.
2725         <~dwo_file>: Remove call to gdb_bfd_unref.
2726         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2727         gdb_bfd_ref_ptr::get.
2728
2729 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2730
2731         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2732         type to htab_up.
2733         * dwarf2read.c (struct dwo_file): Initialize fields.
2734         <~dwo_file>: New.
2735         (free_dwo_file): Remove, move content to ~dwo_file.
2736         (struct dwo_file_deleter): Remove.
2737         (dwo_file_up>: Remove custom deleter.
2738         (free_dwo_files): Remove.
2739         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2740         dwo_files.
2741         (process_skeletonless_type_units): Call unique_ptr::get.
2742         (allocate_dwo_file_hash_table): Add deleter to created hash
2743         table.  Change return type to htab_up.
2744         (lookup_dwo_file_slot): Don't memset dwo_file, call
2745         unique_ptr::get.
2746         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2747         (create_dwo_unit_in_dwp_v2): Likewise.
2748         (open_and_init_dwo_file): Likewise.
2749         (free_dwo_file_from_slot): Remove.
2750
2751 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2752
2753         * dwarf2read.h (struct dwarf2_section_info) <readin,
2754         is_virtual>: Change type to bool.
2755         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2756         true instead of 1.
2757
2758 2019-06-19  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-data.h (tui_init_content_element): Don't declare.
2761
2762 2019-06-19  Tom Tromey  <tom@tromey.com>
2763
2764         * tui/tui-data.h (tui_init_win_info): Don't declare.
2765
2766 2019-06-19  Tom de Vries  <tdevries@suse.de>
2767
2768         * dwarf2read.h (abstract_to_concrete): Change type to
2769         std::unordered_map<sect_offset, std::vector<sect_offset>,
2770         gdb::hash_enum<sect_offset>>.
2771
2772 2019-06-19  Tom Tromey  <tromey@adacore.com>
2773
2774         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2775         EVAL_AVOID_SIDE_EFFECTS specially.
2776
2777 2019-06-19  Tom Tromey  <tromey@adacore.com>
2778
2779         * source-cache.c (highlighter): New global.
2780         (source_cache::get_source_lines): Create a highlighter on demand.
2781
2782 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2783
2784         * defs.h (deprecated_interactive_hook): Delete declaration.
2785         * interps.c (clear_interpreter_hooks): Remove use of
2786         deprecated_interactive_hook.
2787         * top.c (deprecated_interactive_hook): Delete definition.
2788         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2789
2790 2019-06-18  Tom de Vries  <tdevries@suse.de>
2791
2792         PR gdb/24515
2793         * dwarf2read.h (abstract_to_concrete): Change type from
2794         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2795         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2796         * dwarf2read.c (read_variable): Update.
2797         (dwarf2_fetch_die_loc_sect_off): Update.
2798
2799 2019-06-17  Tom de Vries  <tdevries@suse.de>
2800
2801         PR gdb/24617
2802         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2803         accessing parent[parent_len - 1].
2804
2805 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2806
2807         PR gdb/24364
2808         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2809         call dtrace_process_dof with NULL dof.
2810
2811 2019-06-16  Tom de Vries  <tdevries@suse.de>
2812
2813         PR gdb/24445
2814         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2815
2816 2019-06-16  Tom Tromey  <tom@tromey.com>
2817
2818         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2819         (make_all_visible): Use address of member.
2820
2821 2019-06-16  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2824         (tui_free_window, free_content, free_content_elements): Remove
2825         unnecessary cast.
2826         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2827         cast.
2828         * tui/tui-regs.c (tui_show_register_group)
2829         (tui_display_registers_from, tui_display_reg_element_at_line):
2830         Remove unnecessary cast.
2831
2832 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2833
2834         * linux-nat.c (normal_mask): Delete.
2835         (_initialize_linux_nat): Don't initialise normal_mask.
2836
2837 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2838
2839         PR gdb/24445
2840         * dwarf-index-write.h (write_psymtabs_to_index): Add
2841         dwz_basename parameter.
2842         * dwarf-index-write.c (write_gdbindex): Move file writing to
2843         write_gdbindex_1.  Change return type void.
2844         (assert_file_size): Move up, remove filename parameter.
2845         (write_gdbindex_1): New function.
2846         (write_debug_names): Change return type to void, call
2847         assert_file_size.
2848         (struct index_wip_file): New struct.
2849         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2850         file logic to index_wip_file.  Write index for dwz file if
2851         needed.
2852         (save_gdb_index_command): Pass basename of dwz file, if present.
2853         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2854         build-id of dwz file, if present.
2855         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2856         (dwarf2_get_dwz_file): Likewise.
2857         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2858         (dwarf2_get_dwz_file): Likewise.
2859
2860 2019-06-16  Tom Tromey  <tom@tromey.com>
2861
2862         * coffread.c (process_coff_symbol): Use xstrdup.
2863         * value.c (create_internalvar): Use xstrdup.
2864
2865 2019-06-16  Tom Tromey  <tom@tromey.com>
2866
2867         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2868         * breakpoint.c (stopin_command, stopat_command)
2869         (until_break_command, decode_location_default): Remove unnecessary
2870         cast.
2871         * utils.c (subset_compare): Remove unnecessary cast.
2872         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2873         cast.
2874         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2875         cast.
2876         * infcmd.c (path_command): Remove unnecessary cast.
2877         * coffread.c (decode_type): Remove unnecessary cast.
2878         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2879         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2880         * tui/tui-stack.c (tui_show_locator_content)
2881         (tui_show_frame_info): Remove unnecessary cast.
2882         * tui/tui-win.c (tui_scroll_forward_command)
2883         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2884         (parse_scrolling_args): Remove unnecessary cast.
2885         * tui/tui-data.c (init_win_info, tui_del_window)
2886         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2887         (free_content_elements): Remove unnecessary cast.
2888         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2889         unnecessary cast.
2890         * tui/tui-source.c (tui_set_source_content)
2891         (tui_vertical_source_scroll): Remove unnecessary cast.
2892         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2893         cast.
2894         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2895         * tui/tui-regs.c (tui_display_registers_from)
2896         (tui_display_register): Remove unnecessary cast.
2897         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2898         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2899         (make_visible): Remove unnecessary cast.
2900         * tui/tui-winsource.c (tui_erase_source_content)
2901         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2902         unnecessary cast.
2903         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2904         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2905         * stabsread.c (read_type, read_array_type, read_range_type):
2906         Remove unnecessary cast.
2907         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2908         (parse_symbol, parse_type, upgrade_type, parse_external)
2909         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2910         unnecessary cast.
2911         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2912
2913 2019-06-16  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-data.c (tui_alloc_generic_win_info)
2916         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2917         checks.
2918
2919 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2920             Andrew Burgess  <andrew.burgess@embecosm.com>
2921
2922         * f-typeprint.c (f_print_type): Don't return early for not
2923         associated or not allocated types.
2924         (f_type_print_varspec_suffix): Add print_rank parameter and print
2925         ranks of array types in case they dangling.
2926         (f_type_print_base): Add print_rank parameter.
2927
2928 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2929
2930         * NEWS: Mention new MI commands.
2931         * break-catch-throw.c (enum exception_event_kind): Move to
2932         breakpoint.h.
2933         (print_mention_exception_catchpoint): Output text as a single
2934         message.
2935         (catch_exception_command_1): Rename to...
2936         (catch_exception_event): ...this, make non-static, update header
2937         command, and change some parameter types.
2938         (catch_catch_command): Update for changes to
2939         catch_exception_command_1.
2940         (catch_throw_command): Likewise.
2941         (catch_rethrow_command): Likewise.
2942         * breakpoint.c (enum exception_event_kind): Delete.
2943         * breakpoint.h (enum exception_event_kind): Moved here from
2944         break-catch-throw.c.
2945         (catch_exception_event): Declare.
2946         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2947         (mi_cmd_catch_throw): New function.
2948         (mi_cmd_catch_rethrow): New function.
2949         (mi_cmd_catch_catch): New function.
2950         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2951         'catch-catch' entries.
2952         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2953         (mi_cmd_catch_rethrow): Declare.
2954         (mi_cmd_catch_catch): Declare.
2955
2956 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2957
2958         * annotate.c (annotate_source_line): Change return type to void,
2959         update implementation to match.
2960         * annotate.h (annotate_source_line): Change return type to void,
2961         update header comment.
2962         * stack.c (print_frame_info): Don't change what frame information
2963         is printed based on whether annotations are on or not.
2964
2965 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2966
2967         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2968         (annotate_source): Make static.
2969         (annotate_source_line): Moved from source.c and renamed from
2970         identify_source_line.  Update the return type.
2971         * annotate.h (annotate_source): Delete declaration.
2972         (annotate_source_line): Declaration moved from source.h, and
2973         renamed from identify_source_line.  Return type updated.
2974         * source.c (identify_source_line): Moved to annotate.c and renamed
2975         to annotate_source_line.
2976         (info_line_command): Remove check of annotation_level.
2977         * source.h (identify_source_line): Move declaration to annotate.h
2978         and rename to annotate_source_line.
2979         * stack.c: Add 'annotate.h' include.
2980         (print_frame_info): Remove check of annotation_level before
2981         calling annotate_source_line.
2982
2983 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2984
2985         * source-cache.c (source_cache::get_plain_source_lines): Use
2986         open_source_file_with_line_charpos instead of just
2987         open_source_file, remove call to find_source_lines.
2988         (source_cache::get_source_lines): Likewise.
2989         * source.c (find_source_lines): Make static.
2990         (get_filename_and_charpos): Renamed into...
2991         (open_source_file_with_line_charpos): ..this along with changes to
2992         return a scoped_fd, and some other minor clean ups.
2993         (identify_source_line): Use open_source_file_with_line_charpos.
2994         (search_command_helper): Use open_source_file_with_line_charpos
2995         instead of just open_source_file, remove call to
2996         find_source_lines.
2997         * source.h (open_source_file_with_line_charpos): Declare new
2998         function.
2999         (find_source_lines): Delete declaration.
3000
3001 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3002
3003         * source.c (get_filename_and_charpos): Remove fullname
3004         parameter.
3005         (identify_source_line): Update call to get_filename_and_charpos.
3006
3007 2019-06-14  Tom Tromey  <tromey@adacore.com>
3008
3009         PR gdb/24502:
3010         * ui-style.h (skip_ansi_escape): Update comment.
3011         * ui-file.h (class no_terminal_escape_file): New class.
3012         * ui-file.c (no_terminal_escape_file::write)
3013         (no_terminal_escape_file::puts): New methods.
3014         * cli/cli-logging.c (handle_redirections): Use
3015         no_terminal_escape_file.
3016
3017 2019-06-14  Tom Tromey  <tromey@adacore.com>
3018
3019         * NEWS: Move convenience variable news above Python news.
3020
3021 2019-06-14  Tom Tromey  <tom@tromey.com>
3022
3023         * gnulib: Move directory to top-level.
3024         * configure.ac: Don't configure gnulib.
3025         * configure: Rebuild.
3026         * common/common-defs.h: Use new path to gnulib.
3027         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3028         (GNULIB_H): Remove.
3029         (INCGNU): Look in new gnulib location.
3030         (HFILES_NO_SRCDIR): Remove gnulib files.
3031         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3032         (generated_files): Remove GNULIB_H.
3033         ($(LIBGNU), all-lib): Remove targets.
3034         (distclean): Don't mention GNULIB_BUILDDIR.
3035         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3036
3037 2019-06-14  Tom Tromey  <tromey@adacore.com>
3038
3039         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3040         Warn if symbol file does not provide any symbols.
3041
3042 2019-06-14  Tom Tromey  <tromey@adacore.com>
3043
3044         * source.c (find_and_open_source): Respect basenames_may_differ.
3045
3046 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3047
3048         * annotate.c (annotate_breakpoints_invalid): Make use of
3049         scoped_restore_terminal_state.
3050         (annotate_frames_invalid): Likewise.
3051
3052 2019-06-14  Tom Tromey  <tromey@adacore.com>
3053
3054         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3055         allow assignment to an internalvar.
3056
3057 2019-06-14  Tom Tromey  <tromey@adacore.com>
3058
3059         * ada-lex.l: Allow "_" in attribute names.
3060
3061 2019-06-14  Tom Tromey  <tromey@adacore.com>
3062
3063         PR gdb/24653:
3064         * regcache.c (registers_changed): Don't call alloca.
3065         * top.c (execute_command): Don't call alloca.
3066
3067 2019-06-13  Pedro Alves  <palves@redhat.com>
3068
3069         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3070         'expression'.  When parsing an expression, error out if there's
3071         junk after "unlimited".
3072         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3073         (do_set_command): Adjust calls to is_unlimited_literal.
3074
3075 2019-06-13  Pedro Alves  <palves@redhat.com>
3076
3077         * compile/compile.c (make_compile_options_def_group): Add braces
3078         around array_view initializer.
3079         * thread.c (make_thread_apply_all_options_def_group)
3080         (make_thread_apply_all_options_def_group): Likewise.
3081
3082 2019-06-13  Pedro Alves  <palves@redhat.com>
3083
3084         * NEWS (New commands): Mention "maint test-options
3085         require-delimiter", "maint test-options unknown-is-error", "maint
3086         test-options unknown-is-operand" and "maint show
3087         test-options-completion-result".
3088         (New command options, command completion): New section.
3089         (Completion improvements): New section.
3090         Mention that you can abbreviate "unlimited".
3091
3092 2019-06-13  Pedro Alves  <palves@redhat.com>
3093
3094         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3095         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3096         * unittests/cli-utils-selftests.c (test_parse_flags)
3097         (test_parse_flags_qcs): Delete.
3098         (test_cli_utils): Don't call deleted functions.
3099
3100 2019-06-13  Pedro Alves  <palves@redhat.com>
3101
3102         * thread.c: Include "cli/cli-option.h".
3103         (tp_array_compar_ascending): Global.
3104         (tp_array_compar): Delete function.
3105         (tp_array_compar_ascending, tp_array_compar_descending): New
3106         functions.
3107         (ascending_option_def, qcs_flag_option_def)
3108         (thr_qcs_flags_option_defs)
3109         (make_thread_apply_all_options_def_group)
3110         (make_thread_apply_options_def_group): New.
3111         (thread_apply_all_command): Use gdb::option::process_options.
3112         (thread_apply_command_completer)
3113         (thread_apply_all_command_completer): New.
3114         (thread_apply_command): Use gdb::option::process_options.
3115         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3116         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3117         to generate help text of "thread apply".  Adjust "taas"'s help.
3118         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3119         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3120
3121 2019-06-13  Pedro Alves  <palves@redhat.com>
3122
3123         * thread.c (thread_apply_command): Check for invalid TID with
3124         isdigit instead of !isalpha.
3125
3126 2019-06-13  Pedro Alves  <palves@redhat.com>
3127
3128         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3129         (validate_flags_qcs): New.
3130         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3131         (validate_flags_qcs): Declare.
3132         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3133         (make_frame_apply_options_def_group): New.
3134         (frame_apply_command_count): Process options with
3135         gdb::option::process_options.
3136         (frame_apply_completer): New.
3137         (frame_apply_level_completer, frame_apply_all_completer)
3138         (frame_apply_completer): New.
3139         (_initialize_stack): Update help of "frame apply", "frame apply
3140         level", "frame apply all" and "faas" to mention supported options
3141         and install command completers.
3142         * stack.h (frame_apply_all_completer): Declare.
3143         * thread.c: Include "stack.h".
3144         (tfaas_command): Add "--".
3145         (_initialize_thread): Update help "tfaas" to mention supported
3146         options and install command completer.
3147
3148 2019-06-13  Pedro Alves  <palves@redhat.com>
3149
3150         * completer.c (complete_nested_command_line): New.
3151         (gdb_completion_word_break_characters_throw): Add assertion.
3152         * completer.h (complete_nested_command_line): Declare.
3153
3154 2019-06-13  Pedro Alves  <palves@redhat.com>
3155
3156         * stack.c (parse_backtrace_qualifiers): New.
3157         (backtrace_command): Use it.
3158         (backtrace_command_completer): Complete on qualifiers.
3159
3160 2019-06-13  Pedro Alves  <palves@redhat.com>
3161
3162         * frame.c: Include "cli/cli-option.h.
3163         (user_set_backtrace_options): New.
3164         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3165         Delete.
3166         (get_prev_frame): Adjust.
3167         (boolean_option_def, uinteger_option_def)
3168         (set_backtrace_option_defs): New.
3169         (_initialize_frame): Adjust and use
3170         gdb::option::add_setshow_cmds_for_options to install "set
3171         backtrace past-main" and "set backtrace past-entry".
3172         * frame.h: Include "cli/cli-option.h".
3173         (struct frame_print_options): Forward declare.
3174         (print_frame_arguments_all, print_frame_arguments_scalars)
3175         (print_frame_arguments_none): Declare.
3176         (print_entry_values): Delete declaration.
3177         (struct frame_print_options, user_frame_print_options): New.
3178         (struct set_backtrace_options): New.
3179         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3180         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3181         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3182         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3183         (list_args_or_locals): Add frame_print_options parameter.
3184         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3185         * python/py-framefilter.c (enumerate_args): Pass down
3186         USER_FRAME_PRINT_OPTIONS.
3187         * stack.c: Include "cli/cli-option.h".
3188         (print_frame_arguments_all, print_frame_arguments_scalars)
3189         (print_frame_arguments_none): Declare.
3190         (print_raw_frame_arguments, print_entry_values): Delete.
3191         (user_frame_print_options): New.
3192         (boolean_option_def, enum_option_def, frame_print_option_defs):
3193         New.
3194         (struct backtrace_cmd_options): New.
3195         (bt_flag_option_def): New.
3196         (backtrace_command_option_defs): New.
3197         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3198         (print_frame_arg, read_frame_arg, print_frame_args)
3199         (print_frame_info, print_frame): Add frame_print_options parameter
3200         and use it.
3201         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3202         (backtrace_command_1): Add frame_print_options and
3203         backtrace_cmd_options parameters and use them.
3204         (make_backtrace_options_def_group): New.
3205         (backtrace_command): Process command options with
3206         gdb::option::process_options.
3207         (backtrace_command_completer): New.
3208         (_initialize_stack): Extend "backtrace"'s help to mention
3209         supported options.  Install completer for "backtrace".
3210         Install some settings commands with add_setshow_cmds_for_options.
3211
3212 2019-06-13  Pedro Alves  <palves@redhat.com>
3213
3214         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3215         and that "set/show print raw frame-arguments" are now deprecated.
3216
3217         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3218         command.
3219         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3220         * stack.c (_initialize_stack): Install "set/show print
3221         raw-frame-arguments", and deprecate "set/show print raw
3222         frame-arguments".
3223         * valprint.c (_initialize_valprint): Deprecate "set/show print
3224         raw".
3225
3226 2019-06-13  Pedro Alves  <palves@redhat.com>
3227
3228         * compile/compile.c (struct compile_options): New.
3229         (compile_flag_option_def, compile_command_option_defs)
3230         (make_compile_options_def_group): New.
3231         (compile_file_command): Handle options with
3232         gdb::option::process_options.
3233         (compile_file_command_completer): New function.
3234         (compile_code_command): Handle options with
3235         gdb::option::process_options.
3236         (compile_code_command_completer): New function.
3237         (_initialize_compiler): Install completers for "compile code" and
3238         "compile file".  Mention available options in "compile code" and
3239         "compile code"'s help.
3240         * completer.c (advance_to_completion_word): New, factored out from
3241         ...
3242         (advance_to_expression_complete_word_point): ... this.
3243         (advance_to_filename_complete_word_point): New.
3244         * completer.h (advance_to_filename_complete_word_point): New
3245         declaration.
3246
3247 2019-06-13  Pedro Alves  <palves@redhat.com>
3248
3249         * compile/compile.c: Include "cli/cli-option.h".
3250         (compile_print_value): Scope data pointer is now a
3251         value_print_options pointer; adjust.
3252         (compile_print_command): Process options.  Scope data pointer is
3253         now a value_print_options pointer; adjust.
3254         (_initialize_compile): Update "compile print"'s help to include
3255         supported options.  Install a completer for "compile print".
3256         * cp-valprint.c (show_vtblprint, show_objectprint)
3257         (show_static_field_print): Delete.
3258         (_initialize_cp_valprint): Don't install "set print
3259         static-members", "set print vtbl", "set print object" here.
3260         * printcmd.c: Include "cli/cli-option.h" and
3261         "common/gdb_optional.h".
3262         (print_command_parse_format): Rework to fill in a
3263         value_print_options instead of a format_data.
3264         (print_value): Change parameter type from format_data pointer to
3265         value_print_options reference.  Adjust.
3266         (print_command_1): Process options.  Adjust to pass down a
3267         value_print_options.
3268         (print_command_completer): New.
3269         (_initialize_printcmd): Install print_command_completer as
3270         handle_brkchars completer for the "print" command.  Update
3271         "print"'s help to include supported options.
3272         * valprint.c: Include "cli/cli-option.h".
3273         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3274         here from cp-valprint.c.
3275         (boolean_option_def, uinteger_option_def)
3276         (value_print_option_defs, make_value_print_options_def_group):
3277         New.  Use gdb::option::add_setshow_cmds_for_options to install
3278         "set print elements", "set print null-stop", "set print repeats",
3279         "set print pretty", "set print union", "set print array", "set
3280         print address", "set print symbol", "set print array-indexes".
3281         * valprint.h: Include <string> and "cli/cli-option.h".
3282         (make_value_print_options_def_group): Declare.
3283         (print_value): Change parameter type from format_data pointer to
3284         value_print_options reference.
3285         (print_command_completer): Declare.
3286
3287 2019-06-13  Pedro Alves  <palves@redhat.com>
3288
3289         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3290         (COMMON_SFILES): Add maint-test-settings.c.
3291         * cli/cli-decode.c (boolean_enums): New global, factored out from
3292         ...
3293         (add_setshow_boolean_cmd): ... here.
3294         * cli/cli-decode.h (boolean_enums): Declare.
3295         * cli/cli-option.c: New file.
3296         * cli/cli-option.h: New file.
3297         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3298         factored out from ...
3299         (parse_cli_boolean_value(const char *)): ... this.
3300         (is_unlimited_literal): Change parameter type to pointer to
3301         pointer.  Adjust and advance ARG pointer.
3302         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3303         (parse_cli_var_enum): New, factored out from ...
3304         (do_set_command): ... this.  Adjust.
3305         * cli/cli-setshow.h (parse_cli_boolean_value)
3306         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3307         (parse_cli_var_enum): Declare.
3308         * cli/cli-utils.c: Include "cli/cli-option.h".
3309         (get_ulongest): New.
3310         * cli/cli-utils.h (get_ulongest): Declare.
3311         (check_for_argument): New overloads.
3312         * maint-test-options.c: New file.
3313
3314 2019-06-13  Pedro Alves  <palves@redhat.com>
3315
3316         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3317         parse a range if "-" is at the end of the string.
3318
3319 2019-06-13  Pedro Alves  <palves@redhat.com>
3320
3321         * cli/cli-setshow.c (parse_auto_binary_operation)
3322         (parse_cli_boolean_value): Don't allow "o".
3323
3324 2019-06-13  Pedro Alves  <palves@redhat.com>
3325
3326         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3327         * NEWS: Mention maint test-settings KIND.
3328         * maint-test-settings.c: New file.
3329
3330 2019-06-13  Pedro Alves  <palves@redhat.com>
3331
3332         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3333         completer.
3334         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3335         "set" completers.
3336
3337 2019-06-13  Pedro Alves  <palves@redhat.com>
3338
3339         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3340         after item.
3341
3342 2019-06-13  Pedro Alves  <palves@redhat.com>
3343
3344         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3345
3346 2019-06-13  Pedro Alves <palves@redhat.com>
3347
3348         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3349         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3350         call.
3351         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3352         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3353         calls.
3354         (check_for_argument): Skip spaces after argument.
3355
3356 2019-06-13  Pedro Alves  <palves@redhat.com>
3357
3358         * thread.c (thread_apply_command): Adjust TID parsing.
3359         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3360         detected before end of string.
3361         (tid_is_in_list): Error out if LIST is invalid.
3362
3363 2019-06-13  Pedro Alves  <palves@redhat.com>
3364
3365         * completer.c (complete_line_internal_1): Rewind completion word
3366         point.
3367         (completion_tracker::advance_custom_word_point_by): Change
3368         parameter type to int.
3369         * completer.h (completion_tracker::advance_custom_word_point_by):
3370         Likewise.
3371
3372 2019-06-13  Pedro Alves  <palves@redhat.com>
3373
3374         * completer.c (advance_to_completion_word): Handle delimiters.
3375
3376 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3377
3378         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3379
3380 2019-06-11  Tom Tromey  <tom@tromey.com>
3381
3382         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3383         (xmalloc_failed): Move to alloc.c.
3384         * alloc.c: New file.
3385         * Makefile.in (COMMON_SFILES): Add alloc.c.
3386
3387 2019-06-11  Tom Tromey  <tom@tromey.com>
3388
3389         * nat/linux-waitpid.c: Don't include server.h.
3390         (linux_debug): Remove.
3391         (my_waitpid): Update.
3392
3393 2019-06-11  Tom Tromey  <tromey@adacore.com>
3394
3395         * infcall.c (_initialize_infcall): Remove trailing newline from
3396         help.
3397         * user-regs.c (_initialize_user_regs): Remove trailing newline
3398         from help.
3399         * typeprint.c (_initialize_typeprint): Remove trailing newline
3400         from help.
3401         * reverse.c (_initialize_reverse): Remove trailing newlines from
3402         help.
3403         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3404         from help.
3405         * language.c (add_set_language_command): Remove trailing newline
3406         from help.
3407         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3408         help.
3409         * disasm.c (_initialize_disasm): Remove trailing newline from
3410         help.
3411         * top.c (init_main): Remove trailing newline from help.
3412         * interps.c (_initialize_interpreter): Remove trailing newline
3413         from help.
3414         * btrace.c (_initialize_btrace): Remove trailing newlines from
3415         help.
3416         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3417         from help.
3418         * python/python.c (_initialize_python): Remove trailing newline
3419         from help.
3420         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3421         help.
3422         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3423         from help.  Reformat some text.
3424         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3425         from help.
3426         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3427         newline from help.
3428
3429 2019-06-11  Tom Tromey  <tromey@adacore.com>
3430
3431         * darwin-nat.c (darwin_decode_exception_message)
3432         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3433
3434 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3435
3436         * valops.c (value_slice): Check for not allocated or not
3437         associated values.
3438
3439 2019-06-10  Tom de Vries  <tdevries@suse.de>
3440
3441         PR gdb/24618
3442         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3443         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3444         invalid.
3445
3446 2019-06-10  Tom de Vries  <tdevries@suse.de>
3447
3448         PR gdb/24611
3449         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3450         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3451
3452 2019-06-10  Tom de Vries  <tdevries@suse.de>
3453
3454         PR symtab/24545
3455         * symtab.c (struct demangled_name_entry): Add language field.
3456         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3457         static minimal symbol".  Set and use language field.
3458
3459 2019-06-10  Tom Tromey  <tromey@adacore.com>
3460
3461         * ada-lang.c (_initialize_ada_language): Update help text.
3462
3463 2019-06-10  Tom Tromey  <tromey@adacore.com>
3464
3465         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3466         with a newline.
3467         * guile/guile.c (handle_boot_error): Don't end warning with a
3468         newline.
3469         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3470         warning with a newline.
3471         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3472         newline.
3473         (s12z_frame_cache): Likewise.
3474         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3475         a newline.
3476         * solib-svr4.c (disable_probes_interface): Don't end warning with
3477         a newline.
3478         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3479         newline.
3480         * python/python.c (do_finish_initialization): Don't end warning
3481         with a newline.
3482
3483 2019-06-10  Tom Tromey  <tom@tromey.com>
3484
3485         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3486         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3487         gdbpy_enter.
3488
3489 2019-06-10  Tom Tromey  <tromey@adacore.com>
3490
3491         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3492         data.
3493         (elf_new_init): Don't call stabsread_new_init.
3494         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3495         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3496         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3497
3498 2019-06-10  Tom de Vries  <tdevries@suse.de>
3499
3500         PR symtab/16264
3501         PR symtab/24517
3502         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3503
3504 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3505
3506         * source.c (find_and_open_source): Also rewrite relative file
3507         names.
3508
3509 2019-04-26  Amos Bird  <amosbird@gmail.com>
3510
3511         * annotate.c (annotate_thread_exited): Add "thread-exited"
3512         annotation.
3513
3514 2019-06-06  Tom Tromey  <tromey@adacore.com>
3515
3516         * maint.h (class scoped_command_stats): Use
3517         DISABLE_COPY_AND_ASSIGN.
3518         <print_time>: New method.
3519         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3520         print_time.
3521         (scoped_command_stats::print_time): New method.
3522
3523 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3524
3525         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3526         instructions of lengths 6 or 8 bytes.
3527
3528 2019-06-04  Pedro Alves  <palves@redhat.com>
3529
3530         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3531
3532         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3533         * breakpoint.c (condition_completer): Likewise.
3534         * cli/cli-dump.c (scan_expression): Likewise.
3535         * common/filestuff.c (mkdir_recursive): Likewise.
3536         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3537         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3538         (gdb_abspath): Likewise.
3539         * compile/compile-cplus-types.c
3540         (compile_cplus_instance::decl_name): Likewise.
3541         * completer.c (complete_explicit_location):
3542         (signal_completer, reg_or_group_completer_1): Likewise.
3543         * cp-support.c (cp_remove_params_if_any): Likewise.
3544         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3545         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3546         * infcmd.c (strip_bg_char): Likewise.
3547         * linespec.c (copy_token_string): Likewise.
3548         * mi/mi-main.c (output_cores): Likewise.
3549         * psymtab.c (psymtab_search_name):
3550         * symfile.c (test_set_ext_lang_command): Likewise.
3551         * target.c (target_fileio_read_stralloc): Likewise.
3552         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3553         * value.c (complete_internalvar): Likewise.
3554
3555 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3556
3557         Add objfile property to gdb.Type.
3558         * NEWS: Mention Python API addition.
3559         * python/py-type.c (typy_get_objfile): New method.
3560
3561 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3562
3563         * NEWS: Mention the new set|show style [title|highlight].
3564         Mention changes to "show style", "help" and "apropos".
3565
3566 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3567
3568         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3569         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3570         instead of print_help_for_command.
3571         (print_doc_of_command): New function.
3572         (help_list): Add 'apropos -v word' suggestion.
3573         (print_help_for_command): Style the command name using title style.
3574         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3575         (_initialize_cli_cmds): Describe -v in apropos_command help.
3576
3577 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3578
3579         * cli/cli-style.h (cli_style_option): Add name in constructor,
3580         add m_name class member, add constructor with intensity,
3581         add name class function.
3582         (cli_style_option::add_setshow_commands): Remove name argument.
3583         (highlight_style, title_style): New styles.
3584         * cli/cli-style.c (do_show): New function that shows a style
3585         characteristic styling the style name with itself.
3586         (set_style_name): New function.
3587         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3588         Update all callers according to the changes in cli/cli-style.h.
3589         * utils.h (fputs_highlighted): New function.
3590         * utils.c (fputs_highlighted): Likewise.
3591
3592 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3593
3594         * NEWS: Mention new pipe command and new convenience variables.
3595
3596 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3597
3598         * cli/cli-cmds.c (pipe_command): New function.
3599         (_initialize_cli_cmds): Call add_com for pipe_command.
3600         Define | as an alias for pipe.
3601         (exit_status_set_internal_vars): New function.
3602         (shell_escape): Call exit_status_set_internal_vars.
3603         cli/cli-decode.c (find_command_name_length): Recognize | as
3604         a single character command.
3605
3606 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3607
3608         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3609         top.c (execute_command_to_ui_file): New function, mostly a copy
3610         of execute_command_to_string.
3611         (execute_command_to_string): Implement by calling
3612         execute_command_to_ui_file.
3613
3614 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3615
3616         * top.h (saved_command_line): Remove declaration.
3617         * top.c (previous_saved_command_line, previous_repeat_arguments):
3618         New variables.
3619         (saved_command_line): Make static, define together with other
3620         'repeat variables'.
3621         (dont_repeat): Clear repeat_arguments.
3622         (repeat_previous, get_saved_command_line, save_command_line):
3623         New functions.
3624         (gdb_init): Initialize saved_command_line
3625         and previous_saved_command_line.
3626         * main.c (captured_main_1): Remove saved_command_line initialization.
3627         * event-top.c (handle_line_of_input): Update to use
3628         the new 'repeat' related functions instead of direct access to
3629         saved_command_line.
3630         * command.h (repeat_previous, get_saved_command_line,
3631         save_command_line): New declarations.
3632         (dont_repeat): Add comment.
3633
3634 2019-05-30  Tom Tromey  <tromey@adacore.com>
3635
3636         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3637         Fix comment.
3638         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3639
3640 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3641
3642         PR cli/24587
3643         * completer.c (complete): Initialize variable word.
3644
3645 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3646
3647         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3648         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3649         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3650         'body' is NULL to the outter 'if', protecting the '!is_define'
3651         situation as well.
3652
3653 2019-05-29  Tom Tromey  <tromey@adacore.com>
3654
3655         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3656         (dwarf_unknown): New function.
3657         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3658         (dwarf_type_encoding_name): Use dwarf_unknown.
3659
3660 2019-05-29  Tom Tromey  <tromey@adacore.com>
3661
3662         PR c++/20020:
3663         * cp-valprint.c (cp_print_value_fields): Call
3664         cp_print_static_field inside "try".
3665
3666 2019-05-29  Tom Tromey  <tromey@adacore.com>
3667
3668         * inflow.c (struct terminal_info): Add default operator=.
3669         * configure: Rebuild.
3670         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3671         -Wdeprecated-copy-dtor, -Wredundant-move.
3672
3673 2019-05-29  Tom Tromey  <tromey@adacore.com>
3674
3675         * NEWS: Add entry.
3676         * infcmd.c (print_return_value_1): Handle finish_print
3677         option.
3678         (show_print_finish): New function.
3679         (_initialize_infcmd): Add "set/show print finish" commands.
3680         * valprint.c (user_print_options): Initialize new member.
3681         * valprint.h (struct value_print_options) <finish_print>: New
3682         member.
3683
3684 2019-05-28  Tom Tromey  <tromey@adacore.com>
3685
3686         * ada-lang.c (ada_remove_Xbn_suffix)
3687         (find_old_style_renaming_symbol)
3688         (parse_old_style_renaming): Remove.
3689         (ada_find_renaming_symbol): Don't call
3690         find_old_style_renaming_symbol.
3691         (ada_is_renaming_symbol): Rename from
3692         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3693         bool.  Now static.
3694         (ada_read_var_value): Update and simplify.
3695         * ada-exp.y (write_var_or_type): Remove old code.
3696
3697 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3698
3699         * event-top.c: Remove include comment.
3700         * inflow.c (class scoped_ignore_sigttou): Move from here...
3701         * inflow.h (class scoped_ignore_sigttou): ...to here.
3702         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3703         * top.c:  Remove include comment.
3704
3705 2019-05-27  Tom Tromey  <tom@tromey.com>
3706
3707         * NEWS: Fix typo.
3708
3709 2019-05-22  Tom Tromey  <tromey@adacore.com>
3710
3711         * target.c (target_follow_exec): Constify parameter.
3712         * target-delegates.c: Rebuild.
3713         * remote.c (remote_target::follow_exec): Constify parameter.
3714         * infrun.c (follow_exec): Constify parameter.
3715         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3716         (target_follow_exec): Likewise.
3717
3718 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3719
3720         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3721         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3722
3723 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3724
3725         * NEWS: Add debugredirect and testsuite sections.
3726
3727 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3728
3729         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3730         target descriptions using exclusively floating point register name
3731         aliases.
3732
3733 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3734
3735         PR gdb/18644:
3736         * f-lang.c (build_fortran_types): Handle the case where
3737         gdbarch_floatformat_for_type returns a nullptr.
3738
3739 2019-05-21  Tom de Vries  <tdevries@suse.de>
3740
3741         PR cli/24587
3742         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3743
3744 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3745
3746         PR gdb/18644:
3747         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3748         16-byte floats.
3749         * i386-tdep.c (i386_floatformat_for_type): Use
3750         floatformats_ia64_quad for the 16-byte floating point component
3751         within a fortran 32-byte complex number.
3752
3753 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3754
3755         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3756         delete default constructor.
3757         (find_partial_die): Update to return const struct.
3758         (partial_die_parent_scope): Move variable declaration into scope
3759         of its use and change its type to auto.
3760         (guess_partial_die_structure_name): Likewise.
3761         (partial_die_info::fixup): Likewise.
3762
3763 2019-05-17  Tom Tromey  <tromey@adacore.com>
3764
3765         * source.c (find_and_open_source): Remove cast.
3766
3767 2019-05-17  Tom Tromey  <tromey@adacore.com>
3768
3769         * annotate.c (annotate_source): Make "filename" const.
3770         * annotate.h (annotate_source): Use const.
3771
3772 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3773
3774         * disasm.c (set_disassembler_options): Send errors to stderr.
3775
3776 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3777
3778         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3779         (cli_interp_base::set_logging): Check debug_redirect.
3780         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3781         * cli/cli-logging.c (debug_redirect): Add static variable.
3782         (pop_output_files): Add default param.
3783         (handle_redirections): Print debug setting.
3784         (show_logging_command): Likewise.
3785         (_initialize_cli_logging): Add debugredirect command.
3786         * interps.c (current_interp_set_logging): Add debug_redirect
3787         parameter.
3788         * interps.h (set_logging): Add debug_redirect parameter.
3789         (current_interp_set_logging): Likewise.
3790         * mi/mi-common.h: Likewise.
3791         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3792
3793 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3794             Tom Tromey  <tromey@adacore.com>
3795
3796         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3797         directly.
3798         * cli/cli-interp.h (make_logging_output): Remove declaration.
3799         * cli/cli-logging.c (make_logging_output): Remove function.
3800         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3801         directly.
3802         * ui-file.c (tee_file::tee_file): Remove bools.
3803         (tee_file::~tee_file): Remove deletes.
3804         * ui-file.h (tee_file): Remove bools.
3805
3806 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3807
3808         * mi/mi-cmds.h (mi_cmd_complete): New function.
3809         * mi/mi-main.c (mi_cmd_complete): Likewise.
3810         * mi/mi-cmds.c: Define new MI command -complete.
3811         * NEWS: Mention new -complete command.
3812
3813 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3814
3815         * completer.h (complete): New function.
3816         * completer.c (complete): Likewise.
3817         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3818         function defined in completer.h.
3819
3820 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3821
3822         * MAINTAINERS (Write After Approval): Add myself.
3823
3824 2019-05-17  Tom de Vries  <tdevries@suse.de>
3825
3826         PR gdb/24094
3827         * dwarf2read.c (struct cu_partial_die_info): New struct.
3828         (find_partial_die): Return cu_partial_die_info.
3829         (partial_die_parent_scope, guess_partial_die_structure_name)
3830         (partial_die_info::fixup): Handle new return type of find_partial_die.
3831
3832 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3833
3834         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3835         "std::string", simplifying the algorithm.
3836
3837 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3838
3839         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3840         (stap_static_probe_ops::get_probes): Likewise.
3841
3842 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3843
3844         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3845         '-')" and "else if".
3846         (stap_parse_single_operand): Join checks for
3847         "gdbarch_stap_parse_special_token_p" and
3848         "gdbarch_stap_parse_special_token" in the same "if" statement.
3849         Invert check when verifying for operation on register
3850         displacement.
3851
3852 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3853
3854         * stap-probe.c (stap_get_opcode): Update comment.
3855         (stap_get_expected_argument_type): Likewise.
3856         (handle_stap_probe): Likewise.
3857
3858 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3859
3860         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3861         return type to 'bool'.  Adjust comment.  Use 'bool' when
3862         appropriate.
3863         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3864         * stap-probe.c (stap_parse_argument_1): Likewise.
3865         (stap_is_operator): Likewise.
3866         (stap_is_generic_prefix): Likewise.
3867         (stap_is_register_prefix): Likewise.
3868         (stap_is_register_indirection_prefix): Likewise.
3869         (stap_is_integer_prefix): Likewise.
3870         (stap_generic_check_suffix): Likewise.
3871         (stap_check_integer_suffix): Likewise.
3872         (stap_check_register_suffix): Likewise.
3873         (stap_check_register_indirection_suffix): Likewise.
3874         (stap_parse_register_operand): Likewise.
3875         (stap_parse_single_operand): Likewise.
3876         (stap_parse_argument_1): Likewise.
3877         (stap_probe::get_argument_count): Likewise.
3878         (stap_is_operator): Likewise.
3879
3880 2019-05-16  Tom Tromey  <tromey@adacore.com>
3881
3882         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3883         keyword to foreach.
3884
3885 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3886
3887         * linux-thread-db.c (try_thread_db_load_1): Change return type
3888         to bool.
3889         (try_thread_db_load): Likewise.
3890         (try_thread_db_load_from_pdir_1): Likewise.
3891         (try_thread_db_load_from_pdir): Likewise.
3892         (try_thread_db_load_from_sdir): Likewise.
3893         (try_thread_db_load_from_dir): Likewise.
3894         (thread_db_load_search): Likewise.
3895         (has_libpthread): Likewise.
3896         (thread_db_load): Likewise.
3897
3898 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3899
3900         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3901         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3902         NULL, and complain/return if that's the case.
3903
3904 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3905
3906         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3907         (advance, posn, abstract_read_memory): New functions.
3908         [struct mem_read_abstraction]: New struct.
3909         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3910
3911 2019-05-14  Tom Tromey  <tromey@adacore.com>
3912
3913         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3914         value is not lval_memory.
3915
3916 2019-05-14  Tom Tromey  <tromey@adacore.com>
3917
3918         * solib.c (info_sharedlibrary_command): Style the file name.
3919
3920 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3921
3922         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3923         (aarch64_vnv_type): Likewise.
3924         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3925         * common/tdesc.c: Likewise.
3926         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3927         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3928         * features/aarch64-fpu.xml: Add ieee half view.
3929         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3930         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3931         * gdbtypes.h (struct builtin_type): Likewise.
3932         (struct objfile_type): Likewise.
3933
3934 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3935
3936         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3937         typo.
3938         * location.h (string_to_event_location): Likewise.
3939
3940 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3941
3942         GDB 8.3 released.
3943
3944 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3945
3946         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3947         New variable declaration.
3948         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3949         New variable.
3950         (print_one_breakpoint): Use ui_out::test_flags and new global
3951         variable to compute use_fixed_output.
3952         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3953         Remove.
3954         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3955         (mi_multi_location_breakpoint_output_fixed): Remove.
3956         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3957         new variable.
3958         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3959         fix_multi_location_breakpoint_output flag if version >= 3.
3960         * ui-out.h (enum ui_out_flag)
3961         <fix_multi_location_breakpoint_output>: New enumerator.
3962
3963 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3964
3965         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3966
3967 2019-05-10  Tom Tromey  <tromey@adacore.com>
3968
3969         * ada-lang.c (catch_ada_completer): New function.
3970         (_initialize_ada_language): Use it.
3971
3972 2019-05-10  Tom Tromey  <tromey@adacore.com>
3973
3974         * thread.c (print_thread_info): Make "requested_threads" const.
3975         * gdbthread.h (print_thread_info): Make "requested_threads"
3976         const.
3977         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3978         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3979
3980 2019-05-08  Tom Tromey  <tom@tromey.com>
3981
3982         * gdbtypes.c (objfile_type_data): Change type.
3983         (objfile_type, _initialize_gdbtypes): Update.
3984
3985 2019-05-08  Tom Tromey  <tom@tromey.com>
3986
3987         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3988         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3989         (_initialize_dwarf2_frame): Update.
3990
3991 2019-05-08  Tom Tromey  <tom@tromey.com>
3992
3993         * objc-lang.c (objc_objfile_data): Change type.
3994         (find_methods): Update.
3995         (_initialize_objc_lang): Remove.
3996
3997 2019-05-08  Tom Tromey  <tom@tromey.com>
3998
3999         * stabsread.c (rs6000_builtin_type_data): Change type.
4000         (rs6000_builtin_type, _initialize_stabsread): Update.
4001
4002 2019-05-08  Tom Tromey  <tom@tromey.com>
4003
4004         * mips-tdep.c (mips_pdr_data): Remove.
4005         (_initialize_mips_tdep): Update.
4006
4007 2019-05-08  Tom Tromey  <tom@tromey.com>
4008
4009         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4010         (hppa_init_objfile_priv_data, read_unwind_info)
4011         (find_unwind_entry, _initialize_hppa_tdep): Update.
4012
4013 2019-05-08  Tom Tromey  <tom@tromey.com>
4014
4015         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4016         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4017         on obstack.
4018         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4019
4020 2019-05-08  Tom Tromey  <tom@tromey.com>
4021
4022         * mdebugread.c (basic_type_data): Change type.
4023         (basic_type, _initialize_mdebugread): Update.
4024
4025 2019-05-08  Tom Tromey  <tom@tromey.com>
4026
4027         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4028
4029 2019-05-08  Tom Tromey  <tom@tromey.com>
4030
4031         * nto-tdep.c (nto_inferior_data_reg): Change type.
4032         (nto_inferior_data): Update.
4033         (nto_inferior_data_cleanup, nto_new_inferior_data)
4034         (_initialize_nto_tdep): Remove.
4035         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4036
4037 2019-05-08  Tom Tromey  <tom@tromey.com>
4038
4039         * ada-lang.c (struct ada_inferior_data): Add initializers.
4040         (ada_inferior_data): Change type.
4041         (ada_inferior_data_cleanup): Remove.
4042         (get_ada_inferior_data, ada_inferior_exit)
4043         (struct ada_pspace_data): Add initializers, destructor.
4044         (ada_pspace_data_handle): Change type.
4045         (get_ada_pspace_data): Update.
4046         (ada_pspace_data_cleanup): Remove.
4047
4048 2019-05-08  Tom Tromey  <tom@tromey.com>
4049
4050         * coffread.c (struct coff_symfile_info): Add initializers.
4051         (coff_objfile_data_key): Move lower.  Change type.
4052         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4053         Update.
4054         (coff_free_info): Remove.
4055
4056 2019-05-08  Tom Tromey  <tom@tromey.com>
4057
4058         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4059         (fbsd_pspace_data_handle): Move lower.  Change type.
4060         (get_fbsd_pspace_data): Update.
4061         (fbsd_pspace_data_cleanup): Remove.
4062         (_initialize_fbsd_tdep): Update.
4063
4064 2019-05-08  Tom Tromey  <tom@tromey.com>
4065
4066         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4067         (get_ada_tasks_pspace_data): Update.
4068         (ada_tasks_pspace_data_cleanup): Remove.
4069         (_initialize_tasks): Update.
4070         (ada_tasks_inferior_data_handle): Change type.
4071         (get_ada_tasks_inferior_data): Update.
4072         (ada_tasks_inferior_data_cleanup): Remove.
4073         (struct ada_tasks_pspace_data): Add initializers.
4074
4075 2019-05-08  Tom Tromey  <tom@tromey.com>
4076
4077         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4078         * symfile-debug.c (debug_sym_get_probes): Change type.
4079         * stap-probe.c (handle_stap_probe):
4080         (stap_static_probe_ops::get_probes): Change type.
4081         * probe.h (class static_probe_ops) <get_probes>: Change type.
4082         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4083         (parse_probes_in_pspace): Update.
4084         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4085         Update.
4086         (any_static_probe_ops::get_probes): Change type.
4087         * elfread.c (elfread_data): New typedef.
4088         (probe_key): Change type.
4089         (elf_get_probes): Likewise.  Update.
4090         (probe_key_free): Remove.
4091         (_initialize_elfread): Update.
4092         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4093         Change type.
4094         (dtrace_process_dof_probe, dtrace_process_dof)
4095         (dtrace_static_probe_ops::get_probe): Change type.
4096
4097 2019-05-08  Tom Tromey  <tom@tromey.com>
4098
4099         * xcoffread.c (struct xcoff_symfile_info): Rename from
4100         coff_symfile_info.  Add initializers.
4101         (xcoff_objfile_data_key): Move lower.  Change type.
4102         (XCOFF_DATA): Rewrite.
4103         (xcoff_free_info): Remove.
4104         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4105         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4106         (xcoff_initial_scan): Update.
4107
4108 2019-05-08  Tom Tromey  <tom@tromey.com>
4109
4110         * solib-svr4.c (struct svr4_info): Add initializers and
4111         destructor.
4112         <probes_table>: Now an htab_up.
4113         (solib_svr4_pspace_data): Change type.
4114         (free_probes_table): Simplify.
4115         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4116         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4117         (probes_table_remove_objfile_probes, register_solib_event_probe)
4118         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4119         (_initialize_svr4_solib): Update.
4120
4121 2019-05-08  Tom Tromey  <tom@tromey.com>
4122
4123         * remote.c (remote_pspace_data): Change type.
4124         (remote_pspace_data_cleanup): Remove.
4125         (get_remote_exec_file, set_pspace_remote_exec_file)
4126         (_initialize_remote): Update.
4127
4128 2019-05-08  Tom Tromey  <tom@tromey.com>
4129
4130         * breakpoint.c (breakpoint_objfile_key): Change type.
4131         (get_breakpoint_objfile_data): Update.
4132         (free_breakpoint_objfile_data): Remove.
4133         (_initialize_breakpoint): Update.
4134
4135 2019-05-08  Tom Tromey  <tom@tromey.com>
4136
4137         * linux-tdep.c (struct linux_info): Add initializers.
4138         (linux_inferior_data): Move.  Change type.
4139         (invalidate_linux_cache_inf): Update.
4140         (linux_inferior_data_cleanup): Remove.
4141         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4142
4143 2019-05-08  Tom Tromey  <tom@tromey.com>
4144
4145         * auxv.c (auxv_inferior_data): Move.  Change type.
4146         (auxv_inferior_data_cleanup): Remove.
4147         (invalidate_auxv_cache_inf): Rewrite.
4148         (get_auxv_inferior_data, _initialize_auxv): Update.
4149
4150 2019-05-08  Tom Tromey  <tom@tromey.com>
4151
4152         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4153         (symfile_debug_objfile_data_key): Change type.
4154         (symfile_debug_installed, debug_qf_has_symbols)
4155         (debug_qf_find_last_source_symtab)
4156         (debug_qf_forget_cached_source_info)
4157         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4158         (debug_qf_print_stats, debug_qf_dump)
4159         (debug_qf_expand_symtabs_for_function)
4160         (debug_qf_expand_all_symtabs)
4161         (debug_qf_expand_symtabs_with_fullname)
4162         (debug_qf_map_matching_symbols)
4163         (debug_qf_expand_symtabs_matching)
4164         (debug_qf_find_pc_sect_compunit_symtab)
4165         (debug_qf_map_symbol_filenames)
4166         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4167         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4168         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4169         (debug_sym_read_linetable, debug_sym_relocate): Update.
4170         (symfile_debug_free_objfile): Remove.
4171         (install_symfile_debug_logging, _initialize_symfile_debug):
4172         Update.
4173
4174 2019-05-08  Tom Tromey  <tom@tromey.com>
4175
4176         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4177         allocate_on_obstack.
4178         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4179         (get_dwarf2_per_objfile): Update.
4180         (set_dwarf2_per_objfile): Remove.
4181         (dwarf2_has_info, dwarf2_get_section_info): Update.
4182         (dwarf2_free_objfile): Remove.
4183         (_initialize_dwarf2_read): Update.
4184
4185 2019-05-08  Tom Tromey  <tom@tromey.com>
4186
4187         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4188         initializers.
4189         <unsupported_script_warning_printed,
4190         script_not_found_warning_printed>: Now bool.
4191         (auto_load_pspace_data): Change type.
4192         (~auto_load_pspace_info): Rename from
4193         auto_load_pspace_data_cleanup.
4194         (get_auto_load_pspace_data, init_loaded_scripts_info)
4195         (clear_section_scripts, maybe_print_unsupported_script_warning)
4196         (maybe_print_script_not_found_warning, _initialize_auto_load):
4197         Update.
4198
4199 2019-05-08  Tom Tromey  <tom@tromey.com>
4200
4201         * objfiles.c (objfile_pspace_info): Add destructor and
4202         initializers.
4203         (objfiles_pspace_data): Change type.
4204         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4205         (get_objfile_pspace_data): Update.
4206         (objfiles_bfd_data): Change type.
4207         (get_objfile_bfd_data): Update.
4208         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4209
4210 2019-05-08  Tom Tromey  <tom@tromey.com>
4211
4212         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4213         Change type.
4214         (get_catch_syscall_inferior_data): Update.
4215         (catch_syscall_inferior_data_cleanup): Remove.
4216         (_initialize_break_catch_syscall): Update.
4217
4218 2019-05-08  Tom Tromey  <tom@tromey.com>
4219
4220         * inflow.c (struct terminal_info): Add destructor and
4221         initializers.
4222         (inflow_inferior_data): Change type.
4223         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4224         (get_inflow_inferior_data, inflow_inferior_exit)
4225         (swap_terminal_info, _initialize_inflow): Update.
4226
4227 2019-05-08  Tom Tromey  <tom@tromey.com>
4228
4229         * target-dcache.c (target_dcache_cleanup): Remove.
4230         (target_dcache_aspace_key): Change type.
4231         (target_dcache_init_p, target_dcache_invalidate)
4232         (target_dcache_get, target_dcache_get_or_init)
4233         (_initialize_target_dcache): Update.
4234         * dcache.h (struct dcache_deleter): New.
4235
4236 2019-05-08  Tom Tromey  <tom@tromey.com>
4237
4238         * symtab.c (struct symbol_cache): Add destructor and
4239         initializers.
4240         (symbol_cache_key): Move.  Change type.
4241         (make_symbol_cache, free_symbol_cache): Remove.
4242         (get_symbol_cache): Update.
4243         (symbol_cache_cleanup): Remove.
4244         (ALL_PSPACES, symbol_cache_flush)
4245         (maintenance_print_symbol_cache)
4246         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4247         Update.
4248
4249 2019-05-08  Tom Tromey  <tom@tromey.com>
4250
4251         * symtab.c (struct main_info): Add destructor and initializers.
4252         (main_progspace_key): Move.  Change type.
4253         (get_main_info): Update.
4254         (main_info_cleanup): Remove.
4255         (_initialize_symtab): Update.
4256
4257 2019-05-08  Tom Tromey  <tom@tromey.com>
4258
4259         * registry.h (DECLARE_REGISTRY): Define the _key class.
4260
4261 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4262
4263         * NEWS: Merge two 'New commands' sections.
4264
4265 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4266
4267         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4268         parameter and use Ada language definition instead.
4269         (ada_val_print_ptr): Remove unused language parameter.
4270         (ada_val_print_num): Remove language parameter and use Ada language
4271         definition instead.
4272         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4273         parameter.
4274         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4275         parameter and use Ada language definition instead.
4276         (ada_val_print_1): Update all ada_val_print_xxx calls.
4277         Remove language parameter.
4278         (ada_val_print): Update ada_val_print_1 call.
4279
4280 2019-05-08  Tom Tromey  <tromey@adacore.com>
4281
4282         * remote.c (remote_hw_watchpoint_limit)
4283         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4284         Now static.
4285
4286 2019-05-08  Tom Tromey  <tromey@adacore.com>
4287
4288         * maint.c (_initialize_maint_cmds): Move initialization code to
4289         remote.c.
4290         (watchdog, show_watchdog): Move to remote.c.
4291         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4292         "watchdog" static.
4293         (_initialize_remote): Move initialization code from maint.c.
4294         * defs.h (watchdog): Don't declare.
4295
4296 2019-05-08  Tom Tromey  <tromey@adacore.com>
4297
4298         * tui/tui-interp.c: Include main.h.
4299         * interps.c: Include main.h.
4300         * main.h (interpreter_p): Declare.
4301         * defs.h (interpreter_p): Don't declare.
4302
4303 2019-05-08  Tom Tromey  <tromey@adacore.com>
4304
4305         * dwarf2loc.c: Include dwarf2read.h.
4306         * defs.h (read_unsigned_leb128): Don't declare.
4307         * dwarf2read.h (read_unsigned_leb128): Declare.
4308
4309 2019-05-08  Tom Tromey  <tromey@adacore.com>
4310
4311         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4312         method.
4313
4314 2019-05-08  Tom Tromey  <tromey@adacore.com>
4315
4316         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4317         when no wrap column is set.
4318
4319 2019-05-08  Tom Tromey  <tromey@adacore.com>
4320
4321         * c-lang.c (c_get_string): Handle non-C-style arrays.
4322
4323 2019-05-08  Tom Tromey  <tromey@adacore.com>
4324
4325         * typeprint.c (print_offset_data::update): Print the bit offset,
4326         not the number of bits remaining.
4327
4328 2019-05-08  Tom Tromey  <tromey@adacore.com>
4329
4330         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4331         padding at end of comment.
4332
4333 2019-05-08  Tom Tromey  <tromey@adacore.com>
4334
4335         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4336         Compare main types.
4337
4338 2019-05-06  Tom Tromey  <tom@tromey.com>
4339
4340         * common/scoped_mmap.c: Include common-defs.h.
4341         * common/scoped_mmap.h: Don't include config.h.
4342
4343 2019-05-04  Tom Tromey  <tom@tromey.com>
4344
4345         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4346         (struct aarch64_call_info): Add initializers.
4347         <si>: Now a std::vector.
4348         (pass_on_stack, aarch64_push_dummy_call): Update.
4349
4350 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4351             Tom Tromey  <tom@tromey.com>
4352
4353         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4354         (ppc_threads): Now a std::vector.  Now static.
4355         (hwdebug_find_thread_points_by_tid)
4356         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4357         Update.
4358
4359 2019-05-04  Tom Tromey  <tom@tromey.com>
4360
4361         * arc-tdep.c (arc_tdesc_init): Return bool.
4362
4363 2019-05-04  Tom Tromey  <tom@tromey.com>
4364
4365         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4366         Use gdb_assert_not_reached.
4367
4368 2019-05-04  Tom Tromey  <tom@tromey.com>
4369
4370         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4371         "false".
4372
4373 2019-05-04  Tom Tromey  <tom@tromey.com>
4374
4375         * arc-tdep.c (arc_tdesc_init): Use bool.
4376
4377 2019-05-04  Tom Tromey  <tom@tromey.com>
4378
4379         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4380
4381 2019-05-04  Tom Tromey  <tom@tromey.com>
4382
4383         * cli/cli-cmds.c (valid_command_p): Return bool.
4384
4385 2019-05-04  Tom Tromey  <tom@tromey.com>
4386
4387         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4388         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4389
4390 2019-05-04  Raul Tambre  <raul@tambre.ee>
4391
4392         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4393         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4394         operator for comparison.
4395
4396 2019-05-04  Tom Tromey  <tom@tromey.com>
4397
4398         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4399         (lookup_partial_symbol, print_partial_symbols)
4400         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4401         (psymbol_compare): Update.
4402         (add_psymbol_to_bcache): Clear the entire psymbol.
4403         (maintenance_check_psymtabs): Update.
4404         * psympriv.h (struct partial_symbol): Don't derive from
4405         general_symbol_info.
4406         <obj_section, unrelocated_address, address,
4407         set_unrelocated_address>: Update.
4408         <ginfo>: New member.
4409         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4410         (debug_names::write_psymbols): Update.
4411
4412 2019-05-04  Tom de Vries  <tdevries@suse.de>
4413
4414         * contrib/cc-with-tweaks.sh: Support -n arg.
4415
4416 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4417
4418         * corelow.c (core_target::detach): Ensure frame cache and
4419         register caches are cleared.
4420         inferior.c (exit_inferior_1): Likewise.
4421
4422 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4423             Tom Tromey  <tom@tromey.com>
4424
4425         * dictionary.c (collate_pending_symbols_by_language): Remove
4426         "struct" from foreach.
4427         * symtab.c (lookup_global_symbol_from_objfile)
4428         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4429         foreach.
4430         * ser-tcp.c (net_open): Remove "struct" from foreach.
4431         * objfiles.c (objfile_relocate, objfile_rebase)
4432         (objfile_has_symbols): Remove "struct" from foreach.
4433         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4434         from foreach.
4435         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4436         foreach.
4437         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4438         "struct" from foreach.
4439         * ada-lang.c (create_excep_cond_exprs)
4440         (ada_exception_catchpoint_cond_string): Remove "struct" from
4441         foreach.
4442
4443 2019-05-03  Tom Tromey  <tromey@adacore.com>
4444
4445         * ada-exp.y (convert_char_literal): Check suffix of each
4446         enumerator.
4447
4448 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4449
4450         PR ada/21406:
4451         * ada-exp.y (yywrap): Don't define.
4452         * ada-lex.l (%option): Add noyywrap
4453         (yywrap): Remove.
4454
4455 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4456
4457         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4458         _WIN32_WINNT to the XP level, unless already defined to a higher
4459         level.
4460
4461         * unittests/parse-connection-spec-selftests.c:
4462         * ser-tcp.c:
4463         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4464         override.
4465
4466         * symfile.c (find_separate_debug_file): Remove colon from the
4467         drive spec of DOS/Windows file names of the target, so that the
4468         file name produced from DEBUGDIR and the target's directory will
4469         be valid on DOS/Windows systems.
4470
4471 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4472
4473         * rust-lang.c (val_print_struct): Handle printing structures
4474         containing strings.
4475
4476 2019-05-02  Tom Tromey  <tromey@adacore.com>
4477
4478         * valarith.c (_initialize_valarith): Remove.
4479
4480 2019-05-01  Tom Tromey  <tromey@adacore.com>
4481
4482         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4483         bitfields.
4484
4485 2019-05-01  Tom Tromey  <tromey@adacore.com>
4486
4487         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4488         for big-endian copies.
4489
4490 2019-04-30  Ali Tamur  <tamur@google.com>
4491         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4492         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4493         (read_3_bytes): New function.
4494
4495 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4496
4497         * windows-nat.c (main_thread_id): Delete.
4498         (handle_output_debug_string): Replace main_thread_id by
4499         current_event.dwThreadId.
4500         (fake_create_process): Likewise.
4501         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4502         Do not set main_thread_id.
4503         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4504         current_event.dwThreadId.
4505         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4506
4507 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4508
4509         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4510         Use current_event.dwThreadId instead of main_thread_id.
4511
4512 2019-04-30  Tom Tromey  <tromey@adacore.com>
4513
4514         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4515         (create_excep_cond_exprs): Iterate over program spaces.
4516         (ada_exception_catchpoint_cond_string): Examine all minimal
4517         symbols for exception types.
4518
4519 2019-04-30  Tom Tromey  <tromey@adacore.com>
4520
4521         PR c++/24470:
4522         * dwarf2read.c (process_structure_scope): Handle case where type
4523         has template parameters but no symbol was created.
4524
4525 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4526             Chris January  <chris.january@arm.com>
4527
4528         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4529         qualifier.
4530         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4531
4532 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4533
4534         * f-typeprint.c (f_print_type): Update rules for printing
4535         whitespace.
4536         (f_type_print_varspec_suffix): Likewise.
4537
4538 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4539             Chris January  <chris.january@arm.com>
4540
4541         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4542         function arguments.
4543
4544 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4545
4546         * f-lang.c (build_fortran_types): Change name of void type to
4547         lower case.
4548         * f-typeprint.c (f_type_print_base): Print the name of the void
4549         type, rather than a fixed string.
4550         * f-valprint.c (f_decorations): Use lower case void string.
4551
4552 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4553             Chris January  <chris.january@arm.com>
4554
4555         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4556         types for Fortran.
4557
4558 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4559             Chris January  <chris.january@arm.com>
4560             David Lecomber  <david.lecomber@arm.com>
4561
4562         * f-exp.y (BINOP_INTRINSIC): New token.
4563         (exp): New parser rule handling BINOP_INTRINSIC.
4564         (f77_keywords): Add new builtin procedures.
4565         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4566         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4567         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4568         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4569         (print_unop_subexp_f): New function.
4570         (print_binop_subexp_f): New function.
4571         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4572         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4573         (dump_subexp_body_f): Likewise.
4574         (operator_check_f): Likewise.
4575         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4576         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4577
4578 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4579
4580         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4581         UNOP_KIND.
4582         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4583         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4584         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4585         (operator_length_f): New fuction.
4586         (print_subexp_f): New function.
4587         (op_name_f): New function.
4588         (dump_subexp_body_f): New function.
4589         (operator_check_f): New function.
4590         (exp_descriptor_f): Replace standard expression handling functions
4591         with new functions.
4592         * gdb/fortran-operator.def: New file.
4593         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4594         * gdb/std-operator.def: Remove UNOP_KIND.
4595
4596 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * std-operator.def: Remove unbalanced, stray double quote
4599         character.
4600
4601 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4602             Chris January  <chris.january@arm.com>
4603             Daniel Everett  <daniel.everett@arm.com>
4604             Nick Forrington  <nick.forrington@arm.com>
4605             Richard Bunt  <richard.bunt@arm.com>
4606
4607         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4608         of depth when printing anonymous structs or unions.
4609         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4610         Don't print either the top-level value, or the children if the
4611         max-depth is exceeded.
4612         (ppscm_print_children): When printing the key of a map, allow one
4613         extra level of depth.
4614         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4615         print either the top-level value, or the children if the max-depth
4616         is exceeded.
4617         (print_children): When printing the key of a map, allow one extra
4618         level of depth.
4619         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4620         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4621         (user_print_options): Initialise max_depth field.
4622         (val_print_scalar_or_string_type_p): New function.
4623         (val_print): Check to see if the max depth has been reached.
4624         (val_print_check_max_depth): Define new function.
4625         (show_print_max_depth): New function.
4626         (_initialize_valprint): Add 'print max-depth' option.
4627         * valprint.h (struct value_print_options) <max_depth>: New field.
4628         (val_print_check_max_depth): Declare new function.
4629         * NEWS: Document new feature.
4630
4631 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4632
4633         * ada-lang.c (ada_language_defn): Initialise new field.
4634         * c-lang.c (c_is_string_type_p): New function.
4635         (c_language_defn): Initialise new field.
4636         (cplus_language_defn): Initialise new field.
4637         (asm_language_defn): Initialise new field.
4638         (minimal_language_defn): Initialise new field.
4639         * c-lang.h (c_is_string_type_p): Declare new function.
4640         * d-lang.c (d_language_defn): Initialise new field.
4641         * f-lang.c (f_is_string_type_p): New function.
4642         (f_language_defn): Initialise new field.
4643         * go-lang.c (go_is_string_type_p): New function.
4644         (go_language_defn): Initialise new field.
4645         * language.c (default_is_string_type_p): New function.
4646         (unknown_language_defn): Initialise new field.
4647         (auto_language_defn): Initialise new field.
4648         * language.h (struct language_defn) <la_is_string_type_p>: New
4649         member variable.
4650         (default_is_string_type_p): Declare new function.
4651         * m2-lang.c (m2_language_defn): Initialise new field.
4652         * objc-lang.c (objc_language_defn): Initialise new field.
4653         * opencl-lang.c (opencl_language_defn): Initialise new field.
4654         * p-lang.c (pascal_is_string_type_p): New function.
4655         (pascal_language_defn): Initialise new field.
4656         * rust-lang.c (rust_is_string_type_p): New function.
4657         (rust_language_defn): Initialise new field.
4658
4659 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4660
4661         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4662         New field.
4663         * ada-lang.c (ada_language_defn): Initialise new field.
4664         * c-lang.c (c_language_defn): Likewise.
4665         (cplus_language_defn): Likewise.
4666         (asm_language_defn): Likewise.
4667         (minimal_language_defn): Likewise.
4668         * d-lang.c (d_language_defn): Likewise.
4669         * f-lang.c (f_language_defn): Likewise.
4670         * go-lang.c (go_language_defn): Likewise.
4671         * language.c (unknown_language_defn): Likewise.
4672         (auto_language_defn): Likewise.
4673         * m2-lang.c (m2_language_defn): Likewise.
4674         * objc-lang.c (objc_language_defn): Likewise.
4675         * opencl-lang.c (opencl_language_defn): Likewise.
4676         * p-lang.c (pascal_language_defn): Likewise.
4677         * rust-lang.c (rust_language_defn): Likewise.
4678
4679 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4680
4681         * ada-lang.c (ada_is_character_type): Change return type to bool.
4682         (ada_is_string_type): Likewise.
4683         * ada-lang.h (ada_is_character_type): Update declaration
4684         (ada_is_string_type): Likewise.
4685
4686 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4687
4688         Support style in 'frame|thread apply'
4689
4690         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4691         * record.c (record_start, record_stop): Update callers of
4692         execute_command_to_string with false.
4693         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4694         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4695         methods.
4696         (class string_file): New constructor with term_out parameter.
4697         Override methods term_out and can_emit_style_escape.  New member
4698         term_out.
4699         (class stdio_file): Override can_emit_style_escape.
4700         (class tee_file): Override term_out and can_emit_style_escape.
4701         * utils.h (can_emit_style_escape): Remove.
4702         * utils.c (can_emit_style_escape): Likewise.
4703         Update all callers of can_emit_style_escape (SOMESTREAM) to
4704         SOMESTREAM->can_emit_style_escape.
4705         * source-cache.c (source_cache::get_source_lines): Likewise.
4706         * stack.c (frame_apply_command_count): Call execute_command_to_string
4707         passing the term_out characteristic of the current gdb_stdout.
4708         * thread.c (thr_try_catch_cmd): Likewise.
4709         * top.c (execute_command_to_string): pass term_out parameter
4710         to construct the string_file for the command output.
4711         * ui-file.c (term_cli_styling): New function (most code moved
4712         from utils.c can_emit_style_escape).
4713         (string_file::string_file, string_file::can_emit_style_escape,
4714         stdio_file::can_emit_style_escape, tee_file::term_out,
4715         tee_file::can_emit_style_escape): New functions.
4716
4717 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4718
4719         * NEWS: Mention the new set|show may-call-functions.
4720         * infcall.c (may_call_functions_p): New variable.
4721         (show_may_call_functions_p): New function.
4722         (call_function_by_hand_dummy): Throws an error if not
4723         may-call-functions.
4724         (_initialize_infcall): Call add_setshow_boolean_cmd for
4725         may-call-functions.
4726
4727 2019-04-25  Keith Seitz  <keiths@redhat.com>
4728
4729         PR c++/24367
4730         * cp-support.c (inspect_type): Don't attempt substitutions
4731         of symbol with the same name.
4732
4733 2019-04-25  Tom Tromey  <tromey@adacore.com>
4734
4735         PR gdb/24475:
4736         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4737         static.
4738
4739 2019-04-25  Tom Tromey  <tromey@adacore.com>
4740
4741         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4742         rvalue reference.
4743         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4744         (gdb_xml_parser::parse): Use std::move.
4745         * python/python-internal.h (gdbpy_convert_exception): Take a const
4746         reference.
4747         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4748         std::move.
4749         * python/py-utils.c (gdbpy_convert_exception): Take a const
4750         reference.
4751         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4752         Use std::move.
4753         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4754         Use std::move.
4755         * mi/mi-main.c (mi_print_exception): Take a const reference.
4756         * main.c (handle_command_errors): Take a const reference.
4757         * linespec.c (parse_linespec): Use std::move.
4758         * infcall.c (run_inferior_call): Use std::move.
4759         (call_function_by_hand_dummy): Use std::move.
4760         * exec.c (try_open_exec_file): Use std::move.
4761         * exceptions.h (exception_print, exception_fprintf)
4762         (exception_print_same): Update.
4763         * exceptions.c (print_exception, exception_print)
4764         (exception_fprintf, exception_print_same): Change parameters to
4765         const reference.
4766         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4767         * common/new-op.c: Use std::move.
4768         * common/common-exceptions.h (struct gdb_exception): Add move
4769         constructor.
4770         (struct gdb_exception_error, struct gdb_exception_quit, struct
4771         gdb_quit_bad_alloc): Change constructor to move constructor.
4772         (throw_exception): Change parameter to rvalue reference.
4773         * common/common-exceptions.c (throw_exception): Take rvalue
4774         reference.
4775         * cli/cli-interp.c (safe_execute_command): Use std::move.
4776         * breakpoint.c (insert_bp_location, location_to_sals): Use
4777         std::move.
4778
4779 2019-04-25  Tom Tromey  <tromey@adacore.com>
4780
4781         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4782         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4783         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4784         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4785         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4786         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4787         guile/scm-value.c: Use unpack.
4788         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4789         gdbscm_gdb_exception.
4790         (gdbscm_throw_gdb_exception): Likewise.
4791         (struct gdbscm_gdb_exception): New.
4792         (unpack): New function.
4793         (gdbscm_wrap): Use unpack.
4794
4795 2019-04-25  Tom Tromey  <tromey@adacore.com>
4796
4797         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4798         (gdb_rl_callback_handler): Use std::move.
4799         * common/common-exceptions.h (struct gdb_exception): Add move
4800         assignment operator.
4801         (throw_exception_sjlj): Change "exception" to const reference.
4802         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4803         (throw_exception_sjlj): Change "exception" to const reference.
4804
4805 2019-04-25  Tom Tromey  <tromey@adacore.com>
4806
4807         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4808         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4809         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4810         Update.
4811         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4812         Update.
4813         * mi/mi-interp.c (mi_interp::exec): Update.
4814         * linespec.c (parse_linespec): Update.
4815         * infcall.c (run_inferior_call): Update.
4816         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4817         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4818         (gdbscm_lookup_global_symbol): Update.
4819         * guile/scm-param.c (gdbscm_parameter_value): Update.
4820         * guile/scm-frame.c (gdbscm_frame_read_register)
4821         (gdbscm_frame_read_var): Update.
4822         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4823         * exec.c (try_open_exec_file): Update.
4824         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4825         (gdb_rl_callback_handler): Update.
4826         * common/common-exceptions.h (exception_none): Don't declare.
4827         * common/common-exceptions.c (exception_none): Don't define.
4828         (struct catcher) <exception>: Update.
4829         * cli/cli-interp.c (safe_execute_command): Update.
4830         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4831
4832 2019-04-25  Ali Tamur  <tamur@google.com>
4833
4834         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4835         (read_attribute_value): Likewise.
4836         (dwarf2_read_addr_index): Update comment.
4837         (read_str_index): Add DW_FORM_strx.
4838         (dwarf2_string_attr): Likewise.
4839         (dwarf2_const_value_attr): Likewise.
4840         (dump_die_shallow): Likewise.
4841         (dwarf2_fetch_constant_bytes): Likewise.
4842         (skip_form_bytes): Likewise.
4843         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4844
4845 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4846
4847         PR corefiles/11608
4848         PR corefiles/18187
4849         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4850         OFFSET.  Verify if current mapping contains an ELF header.
4851         (linux_find_memory_regions_full): Adjust call to
4852         dump_mapping_p.
4853
4854 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4855             Kang Li <kanglictf@gmail.com>
4856
4857         PR gdb/21600
4858
4859         * dwarf2-frame.c (read_initial_length): Be consistent about using
4860         unsigned representation of length.
4861         (decode_frame_entry_1): Likewise.  Check for wraparound of
4862         end pointer as well as buffer overflow.
4863
4864 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4865
4866         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4867         "vq".
4868
4869 2019-04-24  Tom Tromey  <tromey@adacore.com>
4870
4871         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4872
4873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4874
4875         * s12z-tdep.c (s12z_unwind_pc): Delete.
4876         (s12z_unwind_sp): Delete.
4877         (s12z_gdbarch_init): Don't register deleted functions with
4878         gdbarch.
4879
4880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * rl78-tdep.c (rl78_unwind_sp): Delete.
4883         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4884
4885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4886
4887         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4888         (xstormy16_unwind_pc): Delete.
4889         (xstormy16_dummy_id): Delete.
4890         (xstormy16_gdbarch_init): Don't register deleted functions with
4891         gdbarch.
4892
4893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4894
4895         * vax-tdep.c (vax_unwind_pc): Delete.
4896         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4897
4898 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4899
4900         * v850-tdep.c (v850_unwind_sp): Delete.
4901         (v850_unwind_pc): Delete.
4902         (v850_dummy_id): Delete.
4903         (v850_gdbarch_init): Don't register deleted functions with
4904         gdbarch.
4905
4906 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4907
4908         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4909         (tilegx_unwind_pc): Delete.
4910         (tilegx_unwind_dummy_id): Delete.
4911         (tilegx_gdbarch_init): Don't register deleted functions with
4912         gdbarch.
4913
4914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4915
4916         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4917         (tic6x_dummy_id): Delete.
4918         (tic6x_gdbarch_init): Don't register deleted functions with
4919         gdbarch.
4920
4921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4922
4923         * sparc-tdep.c (sparc_unwind_pc): Delete.
4924         (sparc32_gdbarch_init): Don't register deleted function with
4925         gdbarch.
4926
4927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4928
4929         * sh-tdep.c (sh_unwind_sp): Delete.
4930         (sh_unwind_pc): Delete.
4931         (sh_dummy_id): Delete.
4932         (sh_gdbarch_init): Don't register deleted functions with
4933         gdbarch.
4934
4935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4936
4937         * score-tdep.c (score_unwind_sp): Delete.
4938         (score_unwind_pc): Delete.
4939         (score_dummy_id): Delete.
4940         (score_gdbarch_init): Don't register deleted functions with
4941         gdbarch.
4942
4943 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4944
4945         * rx-tdep.c (rx_unwind_pc): Delete.
4946         (rx_unwind_sp): Delete.
4947         (rx_dummy_id): Delete.
4948         (rx_gdbarch_init): Don't register deleted functions with
4949         gdbarch.  Update comment.
4950
4951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4952
4953         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4954         (rs6000_dummy_id): Delete.
4955         (rs6000_gdbarch_init): Don't register deleted functions with
4956         gdbarch.
4957
4958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4959
4960         * or1k-tdep.c (or1k_dummy_id): Delete.
4961         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4962
4963 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4964
4965         * nios2-tdep.c (nios2_dummy_id): Delete.
4966         (nios2_unwind_sp): Delete.
4967         (nios2_gdbarch_init): Don't register deleted functions with
4968         gdbarch.
4969
4970 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4971
4972         * nds32-tdep.c (nds32_dummy_id): Delete.
4973         (nds32_unwind_pc): Delete.
4974         (nds32_unwind_sp): Delete.
4975         (nds32_gdbarch_init): Don't register deleted functions with
4976         gdbarch.
4977
4978 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4979
4980         * msp430-tdep.c (msp430_unwind_pc): Delete.
4981         (msp430_unwind_sp): Delete.
4982         (msp430_dummy_id): Delete.
4983         (msp430_gdbarch_init): Don't register deleted functions with
4984         gdbarch.
4985
4986 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4987
4988         * moxie-tdep.c (moxie_unwind_sp): Delete.
4989         (moxie_unwind_pc): Delete.
4990         (moxie_dummy_id): Delete.
4991         (moxie_gdbarch_init): Don't register deleted functions with
4992         gdbarch.
4993
4994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4997         (mn10300_unwind_pc): Delete.
4998         (mn10300_unwind_sp): Delete.
4999         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5000         mn10300_unwind_sp.
5001         (mn10300_frame_unwind_init): Don't register deleted functions with
5002         gdbarch.
5003
5004 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5005
5006         * mep-tdep.c (mep_unwind_pc): Delete.
5007         (mep_unwind_sp): Delete.
5008         (mep_dummy_id): Delete.
5009         (mep_gdbarch_init): Don't register deleted functions with
5010         gdbarch.
5011
5012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5013
5014         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5015         (m68hc11_unwind_sp): Delete.
5016         (m68hc11_gdbarch_init): Don't register deleted functions with
5017         gdbarch.
5018
5019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5020
5021         * m32r-tdep.c (m32r_unwind_sp): Delete.
5022         (m32r_unwind_pc): Delete.
5023         (m32r_dummy_id): Delete.
5024         (m32r_gdbarch_init): Don't register deleted functions with
5025         gdbarch.
5026
5027 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5028
5029         * m32c-tdep.c (m32c_unwind_pc): Delete.
5030         (m32c_unwind_sp): Delete.
5031         (m32c_dummy_id): Delete.
5032         (m32c_gdbarch_init): Don't register deleted functions with
5033         gdbarch.
5034
5035 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5036
5037         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5038         (lm32_unwind_pc): Delete.
5039         (lm32_dummy_id): Delete.
5040         (lm32_gdbarch_init): Don't register deleted functions with
5041         gdbarch.
5042
5043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5044
5045         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5046         (iq2000_unwind_pc): Delete.
5047         (iq2000_dummy_id): Delete.
5048         (iq2000_gdbarch_init): Don't register deleted functions with
5049         gdbarch.
5050
5051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5052
5053         * nds32-tdep.c (nds32_type_align): Delete.
5054         (nds32_push_dummy_call): Use type_align instead.
5055
5056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5057
5058         * arm-tdep.c (arm_type_align): Only handle vector override case.
5059         (arm_push_dummy_call): Use type_align.
5060         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5061
5062 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5063
5064         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5065         case.
5066         (pass_on_stack): Use type_align.
5067         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5068         function.
5069
5070 2019-04-23  Tom Tromey  <tromey@adacore.com>
5071
5072         * dwarf2read.c (line_header::file_name_at): Remove unused
5073         overload.
5074
5075 2019-04-23  Tom de Vries  <tdevries@suse.de>
5076
5077         PR gdb/24438
5078         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5079         invocation.
5080
5081
5082 2019-03-27  Ali Tamur  <tamur@google.com>
5083
5084         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5085         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5086         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5087         (dwarf_expr_context::get_addr_index): Likewise
5088         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5089         (symbol_needs_eval_context::get_addr_index): Likewise
5090         (disassemble_dwarf_expression): Add DW_OP_addrx
5091         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5092         (read_cutu_die_from_dwo): Update comment
5093         (skip_one_die): Add DW_FORM_addrx
5094         (read_attribute_value): Likewise
5095         (var_decode_location): Add DW_OP_addrx
5096         (dwarf2_const_value_attr): Add DW_FORM_addrx
5097         (dump_die_shallow): Likewise
5098         (dwarf2_fetch_constant_bytes): Likewise
5099         (decode_locdesc): Add DW_OP_addrx
5100         (skip_form_bytes): Add DW_FORM_addrx
5101
5102 2019-04-22  Ali Tamur  <tamur@google.com>
5103
5104         * MAINTAINERS (Write After Approval): Add self.
5105
5106 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5107
5108         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5109         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5110         (open_symbol_file_object): Likewise.
5111         (svr4_default_sos): Add info parameter.
5112         (svr4_read_so_list): Likewise.
5113         (svr4_current_sos_direct): Adjust functions calls to pass down
5114         info.
5115         (svr4_current_sos_1): Add info parameter.
5116         (svr4_current_sos): Call get_svr4_info, pass info down to
5117         svr4_current_sos_1.
5118         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5119         get_svr4_info.
5120         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5121         get_svr4_info.
5122         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5123         to get_svr4_info.
5124         (probes_table_remove_objfile_probes): Likewise.
5125         (register_solib_event_probe): Add info parameter.
5126         (solist_update_incremental): Pass info parameter down to
5127         svr4_read_so_list.
5128         (disable_probes_interface): Add info parameter.
5129         (svr4_handle_solib_event): Pass current_program_space to
5130         get_svr4_info.  Adjust disable_probes_interface cleanup.
5131         (svr4_create_probe_breakpoints): Add info parameter, pass it
5132         down to register_solib_event_probe.
5133         (svr4_create_solib_event_breakpoints): Add info parameter,
5134         pass it down to svr4_create_probe_breakpoints.
5135         (enable_break): Pass info down to
5136         svr4_create_solib_event_breakpoints.
5137         (svr4_solib_create_inferior_hook): Pass current_program_space to
5138         get_svr4_info.
5139         (svr4_clear_solib): Likewise.
5140
5141 2019-04-22  Pedro Alves  <palves@redhat.com>
5142
5143         * solib-svr4.c (svr4_free_objfile_observer): New.
5144         (probe_and_action::objfile): New field.
5145         (probes_table_htab_remove_objfile_probes)
5146         (probes_table_remove_objfile_probes): New functions.
5147         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5148         in the new probe_and_action.  Don't store the probe in 'lookup'.
5149         (svr4_create_probe_breakpoints): Pass objfile to
5150         register_solib_event_probe.
5151         (_initialize_svr4_solib): Register a free_objfile observer.
5152
5153 2019-04-19  Tom Tromey  <tom@tromey.com>
5154
5155         * common/queue.h: Remove.
5156
5157 2019-04-19  Tom Tromey  <tom@tromey.com>
5158
5159         * event-loop.c: Don't include "common/queue.h".
5160
5161 2019-04-19  Tom Tromey  <tom@tromey.com>
5162
5163         * remote.c (remote_target): Use delete.
5164         * remote-notif.h: Include <list>, not "common/queue.h".
5165         (notif_client_p): Remove typedef.
5166         (remote_notif_state): Add constructor, destructor, initializer.
5167         <notif_queue>: Now a std::list.
5168         (remote_notif_state_xfree): Don't declare.
5169         * remote-notif.c (remote_notif_process, handle_notification)
5170         (remote_notif_state_allocate): Update.
5171         (~remote_notif_state): Rename from remote_notif_state_xfree.
5172
5173 2019-04-19  Tom Tromey  <tom@tromey.com>
5174
5175         * symfile.c (reread_symbols): Update.
5176         * objfiles.c (objfile_register_static_link)
5177         (objfile_lookup_static_link): Update
5178         (~objfile) Don't delete static_links.
5179         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5180
5181 2019-04-19  Tom Tromey  <tom@tromey.com>
5182
5183         * type-stack.h (struct type_stack) <insert>: Constify string.
5184         * type-stack.c (type_stack::insert): Constify string.
5185         * gdbtypes.h (lookup_template_type): Update.
5186         (address_space_name_to_int): Update.
5187         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5188         const.
5189         (lookup_template_type): Make name const.
5190         * c-exp.y: Update rules.
5191         (lex_one_token, classify_name, classify_inner_name)
5192         (c_print_token): Update.
5193         * p-exp.y: Update rules.
5194         (yylex): Update.
5195         * f-exp.y: Update rules.
5196         (yylex): Update.
5197         * d-exp.y: Update rules.
5198         (lex_one_token, classify_name, classify_inner_name): Update.
5199         * parse.c (write_dollar_variable, copy_name): Return std::string.
5200         * parser-defs.h (copy_name): Change return type.
5201         * m2-exp.y: Update rules.
5202         (yylex): Update.
5203         * go-exp.y (lex_one_token): Update.
5204         Update rules.
5205         (classify_unsafe_function, classify_packaged_name)
5206         (classify_name, yylex): Update.
5207
5208 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5209
5210         * configure.ac: add --enable-source-highlight switch.
5211         * configure: Regenerate.
5212         * top.c (print_gdb_version): plumb --enable-source-highlight
5213         status to "show configuration".
5214
5215 2019-04-19  Tom Tromey  <tromey@adacore.com>
5216
5217         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5218         Check ADA_TYPE_P.
5219         (empty_record, ada_template_to_fixed_record_type_1)
5220         (template_to_static_fixed_type)
5221         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5222         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5223         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5224         macros.
5225
5226 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5227
5228         PR symtab/24423:
5229         * source.c (print_source_lines_base): Advance "iter" when a
5230         control character is seen.
5231
5232 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5233
5234         * inferior.h (struct infcall_suspend_state_deleter):
5235         Catch exception in destructor to avoid crash.
5236
5237 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5238
5239         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5240         close to the add_com "shell".
5241
5242 2019-04-18  Tom Tromey  <tromey@adacore.com>
5243
5244         * process-stratum-target.h (class process_stratum_target)
5245         <stratum>: Add "final".
5246
5247 2019-04-17  Tom Tromey  <tromey@adacore.com>
5248
5249         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5250         against nullptr before use.
5251
5252 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5253
5254         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5255
5256 2019-04-17  Jim Wilson  <jimw@sifive.com>
5257             Andrew Burgess  <andrew.burgess@embecosm.com>
5258
5259         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5260         code read might fail, assume 4-byte breakpoint in that case.
5261
5262 2019-04-15  Leszek Swirski  <leszeks@google.com>
5263
5264         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5265         rather than a hand-rolled POD check when checking for forced MEMORY
5266         classification.
5267
5268 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5269
5270         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5271         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5272         function.
5273         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5274         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5275         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5276         declaration.
5277
5278 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5279
5280         * aarch64-linux-nat.c
5281         (aarch64_linux_nat_target::thread_architecture): Add override.
5282         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5283         each VQ.
5284
5285 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5286
5287         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5288
5289 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5290
5291         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5292         target types of size 96-bits, add some additional comments, and
5293         check that the builtin type we found was the correct size.
5294
5295 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5296
5297         * utils.c (prompt_for_continue): Don't restore the styling at the
5298         end, as applied_style has the wrong value.  This fixes styling in
5299         long lists of file names that are interrupted by the "Continue?"
5300         prompt.
5301
5302 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5303
5304         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5305         * c-lang.c (c_language_defn): Likewise.
5306         (cplus_language_defn): Likewise.
5307         (asm_language_defn): Likewise.
5308         (minimal_language_defn): Likewise.
5309         * d-lang.c (d_language_defn): Likewise.
5310         * f-lang.c (f_language_defn): Likewise.
5311         * go-lang.c (go_language_defn): Likewise.
5312         * language.c (unknown_language_defn): Likewise.
5313         (auto_language_defn): Likewise.
5314         * language.h (struct language_defn): Remove la_magic field.
5315         (LANG_MAGIC): Delete.
5316         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5317         * objc-lang.c (objc_language_defn): Likewise.
5318         * opencl-lang.c (opencl_language_defn): Likewise.
5319         * p-lang.c (pascal_language_defn): Likewise.
5320         * rust-lang.c (rust_language_defn): Likewise.
5321
5322 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5323
5324         * riscv-tdep.c (riscv_type_align): New function.
5325         (riscv_type_alignment): Delete.
5326         (riscv_arg_location): Use 'type_align'.
5327         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5328
5329 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5330
5331         * gdbtypes.c (type_align): A struct with no non-static fields also
5332         has alignment of 1.
5333
5334 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5335
5336         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5337         component to 0.
5338         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5339         member.
5340         (riscv_struct_info::analyse): New implementation using new
5341         analyse_inner member function.
5342         (riscv_struct_info::field_offset): New member function.
5343         (riscv_struct_info::m_offsets): New member variable.
5344         (riscv_struct_info::analyse_inner): New private member function,
5345         takes the old implementation of riscv_struct_info::analyse but
5346         extended to track field offsets.
5347         (riscv_call_arg_struct): Update the struct folding special cases
5348         to handle cases where empty C++ structs, which are non-zero
5349         length, are found.
5350         (riscv_arg_location): Initialise the length of each location, a
5351         non-zero length now indicates the location is in use.
5352         (riscv_push_dummy_call): Allow for the first location having a
5353         non-zero offset when setting up arguments.
5354         (riscv_return_value): Likewise, but for return values.
5355
5356 2019-04-11  Tom Tromey  <tromey@adacore.com>
5357
5358         * utils.c (internal_vproblem): Make "msg" const.
5359
5360 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5361
5362         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5363         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5364         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5365         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5366
5367 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5368
5369         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5370         function.
5371         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5372         of amd64_collect_native_gregset.
5373         (amd64_linux_nat_target::store_registers): Likewise.
5374
5375 2019-04-10  Tom Tromey  <tom@tromey.com>
5376
5377         * symtab.c (lookup_global_symbol_from_objfile)
5378         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5379         * objfiles.h (class separate_debug_iterator): New.
5380         (class separate_debug_range): New.
5381         (struct objfile) <separate_debug_objfiles>: New method.
5382         (objfile_separate_debug_iterate): Don't declare.
5383         * objfiles.c (separate_debug_iterator::operator++): Rename from
5384         objfile_separate_debug_iterate.
5385         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5386         iterator.
5387         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5388         iterator.
5389
5390 2019-04-10  Tom Tromey  <tom@tromey.com>
5391
5392         * symfile.c (reread_symbols): Remove old comment.
5393         * objfiles.c (free_all_objfiles): Fix a typo.
5394
5395 2019-04-10  Tom Tromey  <tom@tromey.com>
5396
5397         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5398         * minsyms.c (lookup_minimal_symbol): Use foreach.
5399         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5400         (lookup_minimal_symbol_solib_trampoline): Likewise.
5401         * symfile.c (reread_symbols): Use foreach.
5402
5403 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5404             Tom Tromey  <tromey@adacore.com>
5405
5406         PR rust/24414:
5407         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5408         (rust_lex_int_test): Change "value" to be LONGEST.
5409         (rust_lex_tests): Add test for long integer literal.
5410
5411 2019-04-09  Tom Tromey  <tromey@adacore.com>
5412
5413         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5414         to bool.
5415         (extended_remote_target::attach): Update.
5416         (remote_target::remote_notice_new_inferior): Update.
5417         (remote_target::add_current_inferior_and_thread): Update.
5418         * inferior.c (exit_inferior_1): Use "false".
5419         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5420
5421 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5422
5423         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5424         the "start" command.
5425
5426 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5427
5428         * python/py-inferior.c (infpy_thread_from_thread_handle):
5429         Adjust comments to reflect renaming of thread_from_thread_handle
5430         to thread_from_handle.  Adjust keywords.  Fix type error message.
5431         (inferior_object_methods): Add thread_from_handle.  Retain
5432         thread_from_thread_handle, but mark it as deprecated.
5433
5434 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5435
5436         * gdbthread.h (find_thread_by_handle): Revise declaration.
5437         * thread.c (find_thread_by_handle): Likewise.  Adjust
5438         implementation too.
5439         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5440         support for buffer objects as handles.
5441
5442 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5443
5444         * python/py-infthread.c (thpy_thread_handle): New function.
5445         (thread_object_methods): Register thpy_thread_handle.
5446
5447 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5448
5449         * gdbthread.h (thread_to_thread_handle): Declare.
5450         * thread.c (gdbtypes.h): Include.
5451         (thread_to_thread_handle): New function.
5452
5453         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5454         (target_thread_info_to_thread_handle): Declare.
5455         * target.c (target_thread_info_to_thread_handle): New function.
5456         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5457         * target-delegates.c: Regenerate.
5458
5459         * linux-thread-db.c (class thread_db_target): Add method
5460         thread_info_to_thread_handle.
5461         (thread_db_target::thread_info_to_thread_handle): Define.
5462         * remote.c (class remote_target): Add new method
5463         thread_info_to_thread_handle.
5464         (remote_target::thread_info_to_thread_handle): Define.
5465
5466 2019-04-08  Pedro Alves  <palves@redhat.com>
5467
5468         * common/common-exceptions.c (throw_exception): Don't create
5469         named object to throw; throw directly.
5470         (throw_it): Likewise.  Don't initialize gdb_exception::message
5471         here, with new; pass FMT and AP to the ctor instead.
5472         * common/common-exceptions.h: Include <string>.
5473         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5474         const char *, va_list)): New ctor.  Use std::make_shared.
5475         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5476         errors)): Delete.
5477         (gdb_exception_error::gdb_exception_error(enum errors, const char
5478         *, va_list)): New.
5479         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5480         Add assertion.
5481         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5482         errors)): Delete.
5483         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5484         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5485         Add assertion.
5486
5487 2019-04-08  Tom Tromey  <tom@tromey.com>
5488
5489         * valops.c (value_rtti_indirect_type): Replace throw_exception
5490         with throw.
5491         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5492         with throw.
5493         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5494         throw.
5495         * target.c (target_translate_tls_address): Replace throw_exception
5496         with throw.
5497         * stack.c (frame_apply_command_count): Replace throw_exception
5498         with throw.
5499         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5500         throw.
5501         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5502         with throw.
5503         * rs6000-tdep.c (rs6000_frame_cache)
5504         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5505         * remote.c: Replace throw_exception with throw.
5506         * record-full.c (record_full_message, record_full_wait_1)
5507         (record_full_restore): Replace throw_exception with throw.
5508         * record-btrace.c:
5509         (get_thread_current_frame_id, record_btrace_start_replaying)
5510         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5511         (cmd_record_btrace_start): Replace throw_exception with throw.
5512         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5513         throw.
5514         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5515         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5516         * linespec.c:
5517         (find_linespec_symbols): Replace throw_exception with throw.
5518         * infrun.c (displaced_step_prepare, resume): Replace
5519         throw_exception with throw.
5520         * infcmd.c (post_create_inferior): Replace throw_exception with
5521         throw.
5522         * inf-loop.c (inferior_event_handler): Replace throw_exception
5523         with throw.
5524         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5525         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5526         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5527         (get_prev_frame_always, get_frame_pc_if_available)
5528         (get_frame_address_in_block_if_available, get_frame_language):
5529         Replace throw_exception with throw.
5530         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5531         throw_exception with throw.
5532         * eval.c (fetch_subexp_value, evaluate_var_value)
5533         (evaluate_funcall, evaluate_subexp_standard): Replace
5534         throw_exception with throw.
5535         * dwarf2loc.c (call_site_find_chain)
5536         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5537         Replace throw_exception with throw.
5538         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5539         with throw.
5540         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5541         throw.
5542         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5543         * completer.c (complete_line_internal): Replace throw_exception
5544         with throw.
5545         * compile/compile-object-run.c (compile_object_run): Replace
5546         throw_exception with throw.
5547         * cli/cli-script.c (process_next_line): Replace throw_exception
5548         with throw.
5549         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5550         (btrace_enable, btrace_maint_update_pt_packets): Replace
5551         throw_exception with throw.
5552         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5553         throw_exception with throw.
5554         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5555         throw_exception with throw.
5556         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5557         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5558         * aarch64-tdep.c (aarch64_make_prologue_cache)
5559         (aarch64_make_stub_cache): Replace throw_exception with throw.
5560
5561 2019-04-08  Tom Tromey  <tom@tromey.com>
5562
5563         * common/common-exceptions.c (throw_exception): Rename from
5564         throw_exception_cxx.  Remove old copy.  Make argument const.
5565         (throw_it): Create and throw exception objects directly.
5566         * common/common-exceptions.h (throw_exception): Make argument
5567         const.
5568         (struct gdb_exception_error): Add constructor.
5569         (struct gdb_exception_quit): Add constructor.
5570
5571 2019-04-08  Tom Tromey  <tom@tromey.com>
5572
5573         * common/common-exceptions.h (exception_rethrow): Don't declare.
5574         (TRY_SJLJ): Update comment.
5575         (TRY, CATCH, END_CATCH): Remove.
5576         * common/common-exceptions.c (exception_rethrow): Remove.
5577
5578 2019-04-08  Tom Tromey  <tom@tromey.com>
5579
5580         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5581         Remove.
5582         (gdb_exception_error): Rename from
5583         gdb_exception_RETURN_MASK_ERROR.
5584         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5585         (gdb_quit_bad_alloc): Update.
5586         * aarch64-tdep.c: Update.
5587         * ada-lang.c: Update.
5588         * ada-typeprint.c: Update.
5589         * ada-valprint.c: Update.
5590         * amd64-tdep.c: Update.
5591         * arch-utils.c: Update.
5592         * break-catch-throw.c: Update.
5593         * breakpoint.c: Update.
5594         * btrace.c: Update.
5595         * c-varobj.c: Update.
5596         * cli/cli-cmds.c: Update.
5597         * cli/cli-interp.c: Update.
5598         * cli/cli-script.c: Update.
5599         * common/common-exceptions.c: Update.
5600         * common/new-op.c: Update.
5601         * common/selftest.c: Update.
5602         * compile/compile-c-symbols.c: Update.
5603         * compile/compile-cplus-symbols.c: Update.
5604         * compile/compile-object-load.c: Update.
5605         * compile/compile-object-run.c: Update.
5606         * completer.c: Update.
5607         * corelow.c: Update.
5608         * cp-abi.c: Update.
5609         * cp-support.c: Update.
5610         * cp-valprint.c: Update.
5611         * darwin-nat.c: Update.
5612         * disasm-selftests.c: Update.
5613         * dtrace-probe.c: Update.
5614         * dwarf-index-cache.c: Update.
5615         * dwarf-index-write.c: Update.
5616         * dwarf2-frame-tailcall.c: Update.
5617         * dwarf2-frame.c: Update.
5618         * dwarf2loc.c: Update.
5619         * dwarf2read.c: Update.
5620         * eval.c: Update.
5621         * event-loop.c: Update.
5622         * event-top.c: Update.
5623         * exec.c: Update.
5624         * f-valprint.c: Update.
5625         * fbsd-tdep.c: Update.
5626         * frame-unwind.c: Update.
5627         * frame.c: Update.
5628         * gdbtypes.c: Update.
5629         * gnu-v3-abi.c: Update.
5630         * guile/guile-internal.h: Update.
5631         * guile/scm-block.c: Update.
5632         * guile/scm-breakpoint.c: Update.
5633         * guile/scm-cmd.c: Update.
5634         * guile/scm-disasm.c: Update.
5635         * guile/scm-frame.c: Update.
5636         * guile/scm-lazy-string.c: Update.
5637         * guile/scm-math.c: Update.
5638         * guile/scm-param.c: Update.
5639         * guile/scm-ports.c: Update.
5640         * guile/scm-pretty-print.c: Update.
5641         * guile/scm-symbol.c: Update.
5642         * guile/scm-symtab.c: Update.
5643         * guile/scm-type.c: Update.
5644         * guile/scm-value.c: Update.
5645         * i386-linux-tdep.c: Update.
5646         * i386-tdep.c: Update.
5647         * inf-loop.c: Update.
5648         * infcall.c: Update.
5649         * infcmd.c: Update.
5650         * infrun.c: Update.
5651         * jit.c: Update.
5652         * language.c: Update.
5653         * linespec.c: Update.
5654         * linux-fork.c: Update.
5655         * linux-nat.c: Update.
5656         * linux-tdep.c: Update.
5657         * linux-thread-db.c: Update.
5658         * main.c: Update.
5659         * mi/mi-cmd-break.c: Update.
5660         * mi/mi-cmd-stack.c: Update.
5661         * mi/mi-interp.c: Update.
5662         * mi/mi-main.c: Update.
5663         * objc-lang.c: Update.
5664         * p-valprint.c: Update.
5665         * parse.c: Update.
5666         * ppc-linux-tdep.c: Update.
5667         * printcmd.c: Update.
5668         * python/py-arch.c: Update.
5669         * python/py-breakpoint.c: Update.
5670         * python/py-cmd.c: Update.
5671         * python/py-finishbreakpoint.c: Update.
5672         * python/py-frame.c: Update.
5673         * python/py-framefilter.c: Update.
5674         * python/py-gdb-readline.c: Update.
5675         * python/py-inferior.c: Update.
5676         * python/py-infthread.c: Update.
5677         * python/py-lazy-string.c: Update.
5678         * python/py-linetable.c: Update.
5679         * python/py-objfile.c: Update.
5680         * python/py-param.c: Update.
5681         * python/py-prettyprint.c: Update.
5682         * python/py-progspace.c: Update.
5683         * python/py-record-btrace.c: Update.
5684         * python/py-record.c: Update.
5685         * python/py-symbol.c: Update.
5686         * python/py-type.c: Update.
5687         * python/py-unwind.c: Update.
5688         * python/py-utils.c: Update.
5689         * python/py-value.c: Update.
5690         * python/python.c: Update.
5691         * record-btrace.c: Update.
5692         * record-full.c: Update.
5693         * remote-fileio.c: Update.
5694         * remote.c: Update.
5695         * riscv-tdep.c: Update.
5696         * rs6000-aix-tdep.c: Update.
5697         * rs6000-tdep.c: Update.
5698         * rust-exp.y: Update.
5699         * rust-lang.c: Update.
5700         * s390-tdep.c: Update.
5701         * selftest-arch.c: Update.
5702         * solib-dsbt.c: Update.
5703         * solib-frv.c: Update.
5704         * solib-spu.c: Update.
5705         * solib-svr4.c: Update.
5706         * solib.c: Update.
5707         * sparc64-linux-tdep.c: Update.
5708         * stack.c: Update.
5709         * symfile-mem.c: Update.
5710         * symmisc.c: Update.
5711         * target.c: Update.
5712         * thread.c: Update.
5713         * top.c: Update.
5714         * tracefile-tfile.c: Update.
5715         * tui/tui.c: Update.
5716         * typeprint.c: Update.
5717         * unittests/cli-utils-selftests.c: Update.
5718         * unittests/parse-connection-spec-selftests.c: Update.
5719         * valops.c: Update.
5720         * valprint.c: Update.
5721         * value.c: Update.
5722         * varobj.c: Update.
5723         * windows-nat.c: Update.
5724         * x86-linux-nat.c: Update.
5725         * xml-support.c: Update.
5726
5727 2019-04-08  Tom Tromey  <tom@tromey.com>
5728
5729         * xml-support.c: Use C++ exception handling.
5730         * x86-linux-nat.c: Use C++ exception handling.
5731         * windows-nat.c: Use C++ exception handling.
5732         * varobj.c: Use C++ exception handling.
5733         * value.c: Use C++ exception handling.
5734         * valprint.c: Use C++ exception handling.
5735         * valops.c: Use C++ exception handling.
5736         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5737         handling.
5738         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5739         * typeprint.c: Use C++ exception handling.
5740         * tui/tui.c: Use C++ exception handling.
5741         * tracefile-tfile.c: Use C++ exception handling.
5742         * top.c: Use C++ exception handling.
5743         * thread.c: Use C++ exception handling.
5744         * target.c: Use C++ exception handling.
5745         * symmisc.c: Use C++ exception handling.
5746         * symfile-mem.c: Use C++ exception handling.
5747         * stack.c: Use C++ exception handling.
5748         * sparc64-linux-tdep.c: Use C++ exception handling.
5749         * solib.c: Use C++ exception handling.
5750         * solib-svr4.c: Use C++ exception handling.
5751         * solib-spu.c: Use C++ exception handling.
5752         * solib-frv.c: Use C++ exception handling.
5753         * solib-dsbt.c: Use C++ exception handling.
5754         * selftest-arch.c: Use C++ exception handling.
5755         * s390-tdep.c: Use C++ exception handling.
5756         * rust-lang.c: Use C++ exception handling.
5757         * rust-exp.y: Use C++ exception handling.
5758         * rs6000-tdep.c: Use C++ exception handling.
5759         * rs6000-aix-tdep.c: Use C++ exception handling.
5760         * riscv-tdep.c: Use C++ exception handling.
5761         * remote.c: Use C++ exception handling.
5762         * remote-fileio.c: Use C++ exception handling.
5763         * record-full.c: Use C++ exception handling.
5764         * record-btrace.c: Use C++ exception handling.
5765         * python/python.c: Use C++ exception handling.
5766         * python/py-value.c: Use C++ exception handling.
5767         * python/py-utils.c: Use C++ exception handling.
5768         * python/py-unwind.c: Use C++ exception handling.
5769         * python/py-type.c: Use C++ exception handling.
5770         * python/py-symbol.c: Use C++ exception handling.
5771         * python/py-record.c: Use C++ exception handling.
5772         * python/py-record-btrace.c: Use C++ exception handling.
5773         * python/py-progspace.c: Use C++ exception handling.
5774         * python/py-prettyprint.c: Use C++ exception handling.
5775         * python/py-param.c: Use C++ exception handling.
5776         * python/py-objfile.c: Use C++ exception handling.
5777         * python/py-linetable.c: Use C++ exception handling.
5778         * python/py-lazy-string.c: Use C++ exception handling.
5779         * python/py-infthread.c: Use C++ exception handling.
5780         * python/py-inferior.c: Use C++ exception handling.
5781         * python/py-gdb-readline.c: Use C++ exception handling.
5782         * python/py-framefilter.c: Use C++ exception handling.
5783         * python/py-frame.c: Use C++ exception handling.
5784         * python/py-finishbreakpoint.c: Use C++ exception handling.
5785         * python/py-cmd.c: Use C++ exception handling.
5786         * python/py-breakpoint.c: Use C++ exception handling.
5787         * python/py-arch.c: Use C++ exception handling.
5788         * printcmd.c: Use C++ exception handling.
5789         * ppc-linux-tdep.c: Use C++ exception handling.
5790         * parse.c: Use C++ exception handling.
5791         * p-valprint.c: Use C++ exception handling.
5792         * objc-lang.c: Use C++ exception handling.
5793         * mi/mi-main.c: Use C++ exception handling.
5794         * mi/mi-interp.c: Use C++ exception handling.
5795         * mi/mi-cmd-stack.c: Use C++ exception handling.
5796         * mi/mi-cmd-break.c: Use C++ exception handling.
5797         * main.c: Use C++ exception handling.
5798         * linux-thread-db.c: Use C++ exception handling.
5799         * linux-tdep.c: Use C++ exception handling.
5800         * linux-nat.c: Use C++ exception handling.
5801         * linux-fork.c: Use C++ exception handling.
5802         * linespec.c: Use C++ exception handling.
5803         * language.c: Use C++ exception handling.
5804         * jit.c: Use C++ exception handling.
5805         * infrun.c: Use C++ exception handling.
5806         * infcmd.c: Use C++ exception handling.
5807         * infcall.c: Use C++ exception handling.
5808         * inf-loop.c: Use C++ exception handling.
5809         * i386-tdep.c: Use C++ exception handling.
5810         * i386-linux-tdep.c: Use C++ exception handling.
5811         * guile/scm-value.c: Use C++ exception handling.
5812         * guile/scm-type.c: Use C++ exception handling.
5813         * guile/scm-symtab.c: Use C++ exception handling.
5814         * guile/scm-symbol.c: Use C++ exception handling.
5815         * guile/scm-pretty-print.c: Use C++ exception handling.
5816         * guile/scm-ports.c: Use C++ exception handling.
5817         * guile/scm-param.c: Use C++ exception handling.
5818         * guile/scm-math.c: Use C++ exception handling.
5819         * guile/scm-lazy-string.c: Use C++ exception handling.
5820         * guile/scm-frame.c: Use C++ exception handling.
5821         * guile/scm-disasm.c: Use C++ exception handling.
5822         * guile/scm-cmd.c: Use C++ exception handling.
5823         * guile/scm-breakpoint.c: Use C++ exception handling.
5824         * guile/scm-block.c: Use C++ exception handling.
5825         * guile/guile-internal.h: Use C++ exception handling.
5826         * gnu-v3-abi.c: Use C++ exception handling.
5827         * gdbtypes.c: Use C++ exception handling.
5828         * frame.c: Use C++ exception handling.
5829         * frame-unwind.c: Use C++ exception handling.
5830         * fbsd-tdep.c: Use C++ exception handling.
5831         * f-valprint.c: Use C++ exception handling.
5832         * exec.c: Use C++ exception handling.
5833         * event-top.c: Use C++ exception handling.
5834         * event-loop.c: Use C++ exception handling.
5835         * eval.c: Use C++ exception handling.
5836         * dwarf2read.c: Use C++ exception handling.
5837         * dwarf2loc.c: Use C++ exception handling.
5838         * dwarf2-frame.c: Use C++ exception handling.
5839         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5840         * dwarf-index-write.c: Use C++ exception handling.
5841         * dwarf-index-cache.c: Use C++ exception handling.
5842         * dtrace-probe.c: Use C++ exception handling.
5843         * disasm-selftests.c: Use C++ exception handling.
5844         * darwin-nat.c: Use C++ exception handling.
5845         * cp-valprint.c: Use C++ exception handling.
5846         * cp-support.c: Use C++ exception handling.
5847         * cp-abi.c: Use C++ exception handling.
5848         * corelow.c: Use C++ exception handling.
5849         * completer.c: Use C++ exception handling.
5850         * compile/compile-object-run.c: Use C++ exception handling.
5851         * compile/compile-object-load.c: Use C++ exception handling.
5852         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5853         * compile/compile-c-symbols.c: Use C++ exception handling.
5854         * common/selftest.c: Use C++ exception handling.
5855         * common/new-op.c: Use C++ exception handling.
5856         * cli/cli-script.c: Use C++ exception handling.
5857         * cli/cli-interp.c: Use C++ exception handling.
5858         * cli/cli-cmds.c: Use C++ exception handling.
5859         * c-varobj.c: Use C++ exception handling.
5860         * btrace.c: Use C++ exception handling.
5861         * breakpoint.c: Use C++ exception handling.
5862         * break-catch-throw.c: Use C++ exception handling.
5863         * arch-utils.c: Use C++ exception handling.
5864         * amd64-tdep.c: Use C++ exception handling.
5865         * ada-valprint.c: Use C++ exception handling.
5866         * ada-typeprint.c: Use C++ exception handling.
5867         * ada-lang.c: Use C++ exception handling.
5868         * aarch64-tdep.c: Use C++ exception handling.
5869
5870 2019-04-08  Tom Tromey  <tom@tromey.com>
5871
5872         * xml-support.c (gdb_xml_parser::parse): Update.
5873         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5874         * value.c (show_convenience): Update.
5875         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5876         (test_parse_flags_qcs): Update.
5877         * thread.c (thr_try_catch_cmd): Update.
5878         * target.c (target_translate_tls_address): Update.
5879         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5880         (info_frame_command_core, frame_apply_command_count): Update.
5881         * rust-exp.y (rust_lex_exception_test): Update.
5882         * riscv-tdep.c (riscv_print_one_register_info): Update.
5883         * remote.c (remote_target::enable_btrace): Update.
5884         * record-btrace.c (record_btrace_enable_warn): Update.
5885         * python/py-utils.c (gdbpy_convert_exception): Update.
5886         * printcmd.c (do_one_display, print_variable_and_value): Update.
5887         * mi/mi-main.c (mi_print_exception): Update.
5888         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5889         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5890         * linux-nat.c (linux_nat_target::attach): Update.
5891         * linux-fork.c (class scoped_switch_fork_info): Update.
5892         * infrun.c (displaced_step_prepare): Update.
5893         * infcall.c (call_function_by_hand_dummy): Update.
5894         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5895         * gnu-v3-abi.c (print_one_vtable): Update.
5896         * frame.c (get_prev_frame_always): Update.
5897         * f-valprint.c (info_common_command_for_block): Update.
5898         * exec.c (try_open_exec_file): Update.
5899         * exceptions.c (print_exception, exception_print)
5900         (exception_fprintf, exception_print_same): Update.
5901         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5902         * dwarf-index-cache.c (index_cache::store)
5903         (index_cache::lookup_gdb_index): Update.
5904         * darwin-nat.c (maybe_cache_shell): Update.
5905         * cp-valprint.c (cp_print_value_fields): Update.
5906         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5907         (gcc_cplus_symbol_address): Update.
5908         * compile/compile-c-symbols.c (gcc_convert_symbol)
5909         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5910         * common/selftest.c: Update.
5911         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5912         a std::string.
5913         (exception_try_scope_entry, exception_try_scope_exit): Don't
5914         declare.
5915         (struct exception_try_scope): Remove.
5916         (TRY): Don't use exception_try_scope.
5917         (struct gdb_exception): Add constructor, operator=.
5918         <what>: New method.
5919         (struct gdb_exception_RETURN_MASK_ALL)
5920         (struct gdb_exception_RETURN_MASK_ERROR)
5921         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5922         (struct gdb_quit_bad_alloc): Update.
5923         * common/common-exceptions.c (exception_none): Change
5924         initializer.
5925         (struct catcher) <state, exception>: Initialize inline.
5926         <prev>: Remove member.
5927         (current_catcher): Remove.
5928         (catchers): New global.
5929         (exceptions_state_mc_init): Simplify.
5930         (catcher_pop): Remove.
5931         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5932         (try_scope_depth, exception_try_scope_entry)
5933         (exception_try_scope_exit): Remove.
5934         (throw_exception_sjlj): Update.
5935         (exception_messages, exception_messages_size): Remove.
5936         (throw_it): Simplify.
5937         (gdb_exception_sliced_copy): Remove.
5938         (throw_exception_cxx): Update.
5939         * cli/cli-script.c (script_from_file): Update.
5940         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5941         Update.
5942         * ada-valprint.c (ada_val_print): Update.
5943         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5944         (create_excep_cond_exprs): Update.
5945
5946 2019-04-08  Tom Tromey  <tom@tromey.com>
5947
5948         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5949         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5950         (TRY, CATCH, END_CATCH): Remove some definitions.
5951         * common/common-exceptions.c: Don't use GDB_XCPT.
5952         (catcher_list_size): Remove.
5953         (throw_exception, throw_it): Simplify.
5954
5955 2019-04-05  Tom Tromey  <tom@tromey.com>
5956
5957         Revert the header-sorting patch.
5958         * ft32-tdep.c: Revert.
5959         * frv-tdep.c: Revert.
5960         * frv-linux-tdep.c: Revert.
5961         * frame.c: Revert.
5962         * frame-unwind.c: Revert.
5963         * frame-base.c: Revert.
5964         * fork-child.c: Revert.
5965         * findvar.c: Revert.
5966         * findcmd.c: Revert.
5967         * filesystem.c: Revert.
5968         * filename-seen-cache.h: Revert.
5969         * filename-seen-cache.c: Revert.
5970         * fbsd-tdep.c: Revert.
5971         * fbsd-nat.h: Revert.
5972         * fbsd-nat.c: Revert.
5973         * f-valprint.c: Revert.
5974         * f-typeprint.c: Revert.
5975         * f-lang.c: Revert.
5976         * extension.h: Revert.
5977         * extension.c: Revert.
5978         * extension-priv.h: Revert.
5979         * expprint.c: Revert.
5980         * exec.h: Revert.
5981         * exec.c: Revert.
5982         * exceptions.c: Revert.
5983         * event-top.c: Revert.
5984         * event-loop.c: Revert.
5985         * eval.c: Revert.
5986         * elfread.c: Revert.
5987         * dwarf2read.h: Revert.
5988         * dwarf2read.c: Revert.
5989         * dwarf2loc.c: Revert.
5990         * dwarf2expr.h: Revert.
5991         * dwarf2expr.c: Revert.
5992         * dwarf2-frame.c: Revert.
5993         * dwarf2-frame-tailcall.c: Revert.
5994         * dwarf-index-write.h: Revert.
5995         * dwarf-index-write.c: Revert.
5996         * dwarf-index-common.c: Revert.
5997         * dwarf-index-cache.h: Revert.
5998         * dwarf-index-cache.c: Revert.
5999         * dummy-frame.c: Revert.
6000         * dtrace-probe.c: Revert.
6001         * disasm.h: Revert.
6002         * disasm.c: Revert.
6003         * disasm-selftests.c: Revert.
6004         * dictionary.c: Revert.
6005         * dicos-tdep.c: Revert.
6006         * demangle.c: Revert.
6007         * dcache.h: Revert.
6008         * dcache.c: Revert.
6009         * darwin-nat.h: Revert.
6010         * darwin-nat.c: Revert.
6011         * darwin-nat-info.c: Revert.
6012         * d-valprint.c: Revert.
6013         * d-namespace.c: Revert.
6014         * d-lang.c: Revert.
6015         * ctf.c: Revert.
6016         * csky-tdep.c: Revert.
6017         * csky-linux-tdep.c: Revert.
6018         * cris-tdep.c: Revert.
6019         * cris-linux-tdep.c: Revert.
6020         * cp-valprint.c: Revert.
6021         * cp-support.c: Revert.
6022         * cp-namespace.c: Revert.
6023         * cp-abi.c: Revert.
6024         * corelow.c: Revert.
6025         * corefile.c: Revert.
6026         * continuations.c: Revert.
6027         * completer.h: Revert.
6028         * completer.c: Revert.
6029         * complaints.c: Revert.
6030         * coffread.c: Revert.
6031         * coff-pe-read.c: Revert.
6032         * cli-out.h: Revert.
6033         * cli-out.c: Revert.
6034         * charset.c: Revert.
6035         * c-varobj.c: Revert.
6036         * c-valprint.c: Revert.
6037         * c-typeprint.c: Revert.
6038         * c-lang.c: Revert.
6039         * buildsym.c: Revert.
6040         * buildsym-legacy.c: Revert.
6041         * build-id.h: Revert.
6042         * build-id.c: Revert.
6043         * btrace.c: Revert.
6044         * bsd-uthread.c: Revert.
6045         * breakpoint.h: Revert.
6046         * breakpoint.c: Revert.
6047         * break-catch-throw.c: Revert.
6048         * break-catch-syscall.c: Revert.
6049         * break-catch-sig.c: Revert.
6050         * blockframe.c: Revert.
6051         * block.c: Revert.
6052         * bfin-tdep.c: Revert.
6053         * bfin-linux-tdep.c: Revert.
6054         * bfd-target.c: Revert.
6055         * bcache.c: Revert.
6056         * ax-general.c: Revert.
6057         * ax-gdb.h: Revert.
6058         * ax-gdb.c: Revert.
6059         * avr-tdep.c: Revert.
6060         * auxv.c: Revert.
6061         * auto-load.c: Revert.
6062         * arm-wince-tdep.c: Revert.
6063         * arm-tdep.c: Revert.
6064         * arm-symbian-tdep.c: Revert.
6065         * arm-pikeos-tdep.c: Revert.
6066         * arm-obsd-tdep.c: Revert.
6067         * arm-nbsd-tdep.c: Revert.
6068         * arm-nbsd-nat.c: Revert.
6069         * arm-linux-tdep.c: Revert.
6070         * arm-linux-nat.c: Revert.
6071         * arm-fbsd-tdep.c: Revert.
6072         * arm-fbsd-nat.c: Revert.
6073         * arm-bsd-tdep.c: Revert.
6074         * arch-utils.c: Revert.
6075         * arc-tdep.c: Revert.
6076         * arc-newlib-tdep.c: Revert.
6077         * annotate.h: Revert.
6078         * annotate.c: Revert.
6079         * amd64-windows-tdep.c: Revert.
6080         * amd64-windows-nat.c: Revert.
6081         * amd64-tdep.c: Revert.
6082         * amd64-sol2-tdep.c: Revert.
6083         * amd64-obsd-tdep.c: Revert.
6084         * amd64-obsd-nat.c: Revert.
6085         * amd64-nbsd-tdep.c: Revert.
6086         * amd64-nbsd-nat.c: Revert.
6087         * amd64-nat.c: Revert.
6088         * amd64-linux-tdep.c: Revert.
6089         * amd64-linux-nat.c: Revert.
6090         * amd64-fbsd-tdep.c: Revert.
6091         * amd64-fbsd-nat.c: Revert.
6092         * amd64-dicos-tdep.c: Revert.
6093         * amd64-darwin-tdep.c: Revert.
6094         * amd64-bsd-nat.c: Revert.
6095         * alpha-tdep.c: Revert.
6096         * alpha-obsd-tdep.c: Revert.
6097         * alpha-nbsd-tdep.c: Revert.
6098         * alpha-mdebug-tdep.c: Revert.
6099         * alpha-linux-tdep.c: Revert.
6100         * alpha-linux-nat.c: Revert.
6101         * alpha-bsd-tdep.c: Revert.
6102         * alpha-bsd-nat.c: Revert.
6103         * aix-thread.c: Revert.
6104         * agent.c: Revert.
6105         * addrmap.c: Revert.
6106         * ada-varobj.c: Revert.
6107         * ada-valprint.c: Revert.
6108         * ada-typeprint.c: Revert.
6109         * ada-tasks.c: Revert.
6110         * ada-lang.c: Revert.
6111         * aarch64-tdep.c: Revert.
6112         * aarch64-ravenscar-thread.c: Revert.
6113         * aarch64-newlib-tdep.c: Revert.
6114         * aarch64-linux-tdep.c: Revert.
6115         * aarch64-linux-nat.c: Revert.
6116         * aarch64-fbsd-tdep.c: Revert.
6117         * aarch64-fbsd-nat.c: Revert.
6118         * aarch32-linux-nat.c: Revert.
6119
6120 2019-04-05  Tom Tromey  <tom@tromey.com>
6121
6122         * ft32-tdep.c: Sort headers.
6123         * frv-tdep.c: Sort headers.
6124         * frv-linux-tdep.c: Sort headers.
6125         * frame.c: Sort headers.
6126         * frame-unwind.c: Sort headers.
6127         * frame-base.c: Sort headers.
6128         * fork-child.c: Sort headers.
6129         * findvar.c: Sort headers.
6130         * findcmd.c: Sort headers.
6131         * filesystem.c: Sort headers.
6132         * filename-seen-cache.h: Sort headers.
6133         * filename-seen-cache.c: Sort headers.
6134         * fbsd-tdep.c: Sort headers.
6135         * fbsd-nat.h: Sort headers.
6136         * fbsd-nat.c: Sort headers.
6137         * f-valprint.c: Sort headers.
6138         * f-typeprint.c: Sort headers.
6139         * f-lang.c: Sort headers.
6140         * extension.h: Sort headers.
6141         * extension.c: Sort headers.
6142         * extension-priv.h: Sort headers.
6143         * expprint.c: Sort headers.
6144         * exec.h: Sort headers.
6145         * exec.c: Sort headers.
6146         * exceptions.c: Sort headers.
6147         * event-top.c: Sort headers.
6148         * event-loop.c: Sort headers.
6149         * eval.c: Sort headers.
6150         * elfread.c: Sort headers.
6151         * dwarf2read.h: Sort headers.
6152         * dwarf2read.c: Sort headers.
6153         * dwarf2loc.c: Sort headers.
6154         * dwarf2expr.h: Sort headers.
6155         * dwarf2expr.c: Sort headers.
6156         * dwarf2-frame.c: Sort headers.
6157         * dwarf2-frame-tailcall.c: Sort headers.
6158         * dwarf-index-write.h: Sort headers.
6159         * dwarf-index-write.c: Sort headers.
6160         * dwarf-index-common.c: Sort headers.
6161         * dwarf-index-cache.h: Sort headers.
6162         * dwarf-index-cache.c: Sort headers.
6163         * dummy-frame.c: Sort headers.
6164         * dtrace-probe.c: Sort headers.
6165         * disasm.h: Sort headers.
6166         * disasm.c: Sort headers.
6167         * disasm-selftests.c: Sort headers.
6168         * dictionary.c: Sort headers.
6169         * dicos-tdep.c: Sort headers.
6170         * demangle.c: Sort headers.
6171         * dcache.h: Sort headers.
6172         * dcache.c: Sort headers.
6173         * darwin-nat.h: Sort headers.
6174         * darwin-nat.c: Sort headers.
6175         * darwin-nat-info.c: Sort headers.
6176         * d-valprint.c: Sort headers.
6177         * d-namespace.c: Sort headers.
6178         * d-lang.c: Sort headers.
6179         * ctf.c: Sort headers.
6180         * csky-tdep.c: Sort headers.
6181         * csky-linux-tdep.c: Sort headers.
6182         * cris-tdep.c: Sort headers.
6183         * cris-linux-tdep.c: Sort headers.
6184         * cp-valprint.c: Sort headers.
6185         * cp-support.c: Sort headers.
6186         * cp-namespace.c: Sort headers.
6187         * cp-abi.c: Sort headers.
6188         * corelow.c: Sort headers.
6189         * corefile.c: Sort headers.
6190         * continuations.c: Sort headers.
6191         * completer.h: Sort headers.
6192         * completer.c: Sort headers.
6193         * complaints.c: Sort headers.
6194         * coffread.c: Sort headers.
6195         * coff-pe-read.c: Sort headers.
6196         * cli-out.h: Sort headers.
6197         * cli-out.c: Sort headers.
6198         * charset.c: Sort headers.
6199         * c-varobj.c: Sort headers.
6200         * c-valprint.c: Sort headers.
6201         * c-typeprint.c: Sort headers.
6202         * c-lang.c: Sort headers.
6203         * buildsym.c: Sort headers.
6204         * buildsym-legacy.c: Sort headers.
6205         * build-id.h: Sort headers.
6206         * build-id.c: Sort headers.
6207         * btrace.c: Sort headers.
6208         * bsd-uthread.c: Sort headers.
6209         * breakpoint.h: Sort headers.
6210         * breakpoint.c: Sort headers.
6211         * break-catch-throw.c: Sort headers.
6212         * break-catch-syscall.c: Sort headers.
6213         * break-catch-sig.c: Sort headers.
6214         * blockframe.c: Sort headers.
6215         * block.c: Sort headers.
6216         * bfin-tdep.c: Sort headers.
6217         * bfin-linux-tdep.c: Sort headers.
6218         * bfd-target.c: Sort headers.
6219         * bcache.c: Sort headers.
6220         * ax-general.c: Sort headers.
6221         * ax-gdb.h: Sort headers.
6222         * ax-gdb.c: Sort headers.
6223         * avr-tdep.c: Sort headers.
6224         * auxv.c: Sort headers.
6225         * auto-load.c: Sort headers.
6226         * arm-wince-tdep.c: Sort headers.
6227         * arm-tdep.c: Sort headers.
6228         * arm-symbian-tdep.c: Sort headers.
6229         * arm-pikeos-tdep.c: Sort headers.
6230         * arm-obsd-tdep.c: Sort headers.
6231         * arm-nbsd-tdep.c: Sort headers.
6232         * arm-nbsd-nat.c: Sort headers.
6233         * arm-linux-tdep.c: Sort headers.
6234         * arm-linux-nat.c: Sort headers.
6235         * arm-fbsd-tdep.c: Sort headers.
6236         * arm-fbsd-nat.c: Sort headers.
6237         * arm-bsd-tdep.c: Sort headers.
6238         * arch-utils.c: Sort headers.
6239         * arc-tdep.c: Sort headers.
6240         * arc-newlib-tdep.c: Sort headers.
6241         * annotate.h: Sort headers.
6242         * annotate.c: Sort headers.
6243         * amd64-windows-tdep.c: Sort headers.
6244         * amd64-windows-nat.c: Sort headers.
6245         * amd64-tdep.c: Sort headers.
6246         * amd64-sol2-tdep.c: Sort headers.
6247         * amd64-obsd-tdep.c: Sort headers.
6248         * amd64-obsd-nat.c: Sort headers.
6249         * amd64-nbsd-tdep.c: Sort headers.
6250         * amd64-nbsd-nat.c: Sort headers.
6251         * amd64-nat.c: Sort headers.
6252         * amd64-linux-tdep.c: Sort headers.
6253         * amd64-linux-nat.c: Sort headers.
6254         * amd64-fbsd-tdep.c: Sort headers.
6255         * amd64-fbsd-nat.c: Sort headers.
6256         * amd64-dicos-tdep.c: Sort headers.
6257         * amd64-darwin-tdep.c: Sort headers.
6258         * amd64-bsd-nat.c: Sort headers.
6259         * alpha-tdep.c: Sort headers.
6260         * alpha-obsd-tdep.c: Sort headers.
6261         * alpha-nbsd-tdep.c: Sort headers.
6262         * alpha-mdebug-tdep.c: Sort headers.
6263         * alpha-linux-tdep.c: Sort headers.
6264         * alpha-linux-nat.c: Sort headers.
6265         * alpha-bsd-tdep.c: Sort headers.
6266         * alpha-bsd-nat.c: Sort headers.
6267         * aix-thread.c: Sort headers.
6268         * agent.c: Sort headers.
6269         * addrmap.c: Sort headers.
6270         * ada-varobj.c: Sort headers.
6271         * ada-valprint.c: Sort headers.
6272         * ada-typeprint.c: Sort headers.
6273         * ada-tasks.c: Sort headers.
6274         * ada-lang.c: Sort headers.
6275         * aarch64-tdep.c: Sort headers.
6276         * aarch64-ravenscar-thread.c: Sort headers.
6277         * aarch64-newlib-tdep.c: Sort headers.
6278         * aarch64-linux-tdep.c: Sort headers.
6279         * aarch64-linux-nat.c: Sort headers.
6280         * aarch64-fbsd-tdep.c: Sort headers.
6281         * aarch64-fbsd-nat.c: Sort headers.
6282         * aarch32-linux-nat.c: Sort headers.
6283
6284 2019-04-04  Tom Tromey  <tom@tromey.com>
6285
6286         * varobj.c (varobj_create): Update.
6287         * rust-exp.y (struct rust_parser) <update_innermost_block,
6288         lookup_symbol>: New methods.
6289         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6290         Rename.
6291         (rust_parser::rust_lookup_type)
6292         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6293         * printcmd.c (display_command, do_one_display): Update.
6294         * parser-defs.h (struct parser_state) <parser_state>: Add
6295         "tracker" parameter.
6296         (block_tracker): New member.
6297         (class innermost_block_tracker) <innermost_block_tracker>: Add
6298         "types" parameter.
6299         <reset>: Remove method.
6300         (innermost_block): Don't declare.
6301         (null_post_parser): Update.
6302         * parse.c (innermost_block): Remove global.
6303         (write_dollar_variable): Update.
6304         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6305         Remove "tracker_types" parameter.
6306         (parse_expression): Add "tracker" parameter.
6307         (parse_expression_for_completion): Update.
6308         (null_post_parser): Add "tracker" parameter.
6309         * p-exp.y: Update rules.
6310         * m2-exp.y: Update rules.
6311         * language.h (struct language_defn) <la_post_parser>: Add
6312         "tracker" parameter.
6313         * go-exp.y: Update rules.
6314         * f-exp.y: Update rules.
6315         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6316         parameter.
6317         * d-exp.y: Update rules.
6318         * c-exp.y: Update rules.
6319         * breakpoint.c (set_breakpoint_condition): Create an
6320         innermost_block_tracker.
6321         (watch_command_1): Likewise.
6322         * ada-lang.c (resolve): Add "tracker" parameter.
6323         (resolve_subexp): Likewise.
6324         * ada-exp.y (write_var_from_sym): Update.
6325
6326 2019-04-04  Tom Tromey  <tom@tromey.com>
6327
6328         * type-stack.h: New file.
6329         * type-stack.c: New file.
6330         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6331         type-stack.h.
6332         (insert_into_type_stack, insert_type, push_type, push_type_int)
6333         (insert_type_address_space, pop_type, pop_type_int)
6334         (pop_typelist, pop_type_stack, append_type_stack)
6335         (push_type_stack, get_type_stack, push_typelist)
6336         (follow_type_instance_flags, follow_types): Don't declare.
6337         * parse.c (type_stack): Remove global.
6338         (parse_exp_in_context): Update.
6339         (insert_into_type_stack, insert_type, push_type, push_type_int)
6340         (insert_type_address_space, pop_type, pop_type_int)
6341         (pop_typelist, pop_type_stack, append_type_stack)
6342         (push_type_stack, get_type_stack, push_typelist)
6343         (follow_type_instance_flags, follow_types): Remove (moved to
6344         type-stack.c).
6345         * f-exp.y (type_stack): New global.
6346         Update rules.
6347         (push_kind_type, f_parse): Update.
6348         * d-exp.y (type_stack): New global.
6349         Update rules.
6350         (d_parse): Update.
6351         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6352         Update rules.
6353         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6354         (HFILES_NO_SRCDIR): Add type-stack.h.
6355
6356 2019-04-04  Tom Tromey  <tom@tromey.com>
6357
6358         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6359         (rust_parser::convert_ast_to_expression, rust_parse)
6360         (rust_lex_test_completion, rust_lex_tests): Update.
6361         * parser-defs.h (struct expr_completion_state): New.
6362         (struct parser_state) <parser_state>: Add completion parameter.
6363         <mark_struct_expression, mark_completion_tag>: New methods.
6364         <parse_completion, m_completion_state>: New members.
6365         (prefixify_expression, null_post_parser): Update.
6366         (mark_struct_expression, mark_completion_tag): Don't declare.
6367         * parse.c (parse_completion, expout_last_struct)
6368         (expout_tag_completion_type, expout_completion_name): Remove
6369         globals.
6370         (parser_state::mark_struct_expression)
6371         (parser_state::mark_completion_tag): Now methods.
6372         (prefixify_expression): Add last_struct parameter.
6373         (prefixify_subexp): Likewise.
6374         (parse_exp_1): Update.
6375         (parse_exp_in_context): Add cstate parameter.  Update.
6376         (parse_expression_for_completion): Create an
6377         expr_completion_state.
6378         (null_post_parser): Add "completion" parameter.
6379         * p-exp.y: Update rules.
6380         (yylex): Update.
6381         * language.h (struct language_defn) <la_post_parser>: Add
6382         "completing" parameter.
6383         * go-exp.y: Update rules.
6384         (lex_one_token): Update.
6385         * expression.h (parse_completion): Don't declare.
6386         * d-exp.y: Update rules.
6387         (lex_one_token): Update rules.
6388         * c-exp.y: Update rules.
6389         (lex_one_token): Update.
6390         * ada-lang.c (resolve): Add "parse_completion" parameter.
6391         (resolve_subexp): Likewise.
6392         (ada_resolve_function): Likewise.
6393
6394 2019-04-04  Tom Tromey  <tom@tromey.com>
6395
6396         * parser-defs.h (struct parser_state) <start_arglist,
6397         end_arglist>: New methods.
6398         <arglist_len, m_funcall_chain>: New members.
6399         (arglist_len, start_arglist, end_arglist): Don't declare.
6400         * parse.c (arglist_len, funcall_chain): Remove global.
6401         (start_arglist, end_arglist): Remove functions.
6402         (parse_exp_in_context): Update.
6403         * p-exp.y: Update rules.
6404         * m2-exp.y: Update rules.
6405         * go-exp.y: Update rules.
6406         * f-exp.y: Update rules.
6407         * d-exp.y: Update rules.
6408         * c-exp.y: Update rules.
6409
6410 2019-04-04  Tom Tromey  <tom@tromey.com>
6411
6412         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6413         lex_operator, push_back>: New methods.
6414         Update all rules.
6415         (rust_parser::lex_hex, lex_escape): Rename and update.
6416         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6417         (rust_parser::lex_operator): Rename and update.
6418         (rust_parser::lex_number, rustyylex, rustyyerror)
6419         (rust_lex_test_init, rust_lex_test_sequence)
6420         (rust_lex_test_push_back, rust_lex_tests): Update.
6421         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6422         parameter.
6423         <lexptr, prev_lexptr>: New members.
6424         (lexptr, prev_lexptr): Don't declare.
6425         * parse.c (lexptr, prev_lexptr): Remove globals.
6426         (parse_exp_in_context): Update.
6427         * p-exp.y (yylex, yyerror): Update.
6428         * m2-exp.y (parse_number, yylex, yyerror): Update.
6429         * go-exp.y (lex_one_token, yyerror): Update.
6430         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6431         * d-exp.y (lex_one_token, yyerror): Update.
6432         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6433         (lex_one_token, yyerror): Update.
6434         * ada-lex.l (YY_INPUT): Update.
6435         (rewind_to_char): Update.
6436         * ada-exp.y (yyerror): Update.
6437
6438 2019-04-04  Tom Tromey  <tom@tromey.com>
6439
6440         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6441         * parser-defs.h (struct parser_state) <parser_state>: Add new
6442         parameter.
6443         <comma_terminates>: New member.
6444         (comma_terminates): Don't declare global.
6445         * parse.c (comma_terminates): Remove global.
6446         (parse_exp_in_context): Update.
6447         * p-exp.y (yylex): Update.
6448         * m2-exp.y (yylex): Update.
6449         * go-exp.y (lex_one_token): Update.
6450         * f-exp.y (yylex): Update.
6451         * d-exp.y (lex_one_token): Update.
6452         * c-exp.y (lex_one_token): Update.
6453         * ada-lex.l: Update.
6454
6455 2019-04-04  Tom Tromey  <tom@tromey.com>
6456
6457         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6458         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6459         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6460         * parser-defs.h (paren_depth): Don't declare.
6461         * parse.c (paren_depth): Remove global.
6462         (parse_exp_in_context): Update.
6463         * p-exp.y (paren_depth): New global.
6464         (pascal_parse): Initialize it.
6465         * m2-exp.y (paren_depth): New global.
6466         (m2_parse): Initialize it.
6467         * go-exp.y (paren_depth): New global.
6468         (go_parse): Initialize it.
6469         * f-exp.y (paren_depth): New global.
6470         (f_parse): Initialize it.
6471         * d-exp.y (paren_depth): New global.
6472         (d_parse): Initialize it.
6473         * c-exp.y (paren_depth): New global.
6474         (c_parse): Initialize it.
6475         * ada-lex.l (paren_depth): New global.
6476         (lexer_init): Initialize it.
6477
6478 2019-04-04  Tom Tromey  <tom@tromey.com>
6479
6480         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6481         (rust_parser::convert_ast_to_type)
6482         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6483         * parser-defs.h (struct parser_state) <parser_state>: Add
6484         parameters.  Initialize new members.
6485         <expression_context_block, expression_context_pc>: New members.
6486         * parse.c (expression_context_block, expression_context_pc):
6487         Remove globals.
6488         (parse_exp_in_context): Update.
6489         * p-exp.y: Update all rules.
6490         (yylex): Update.
6491         * m2-exp.y: Update all rules.
6492         (yylex): Update.
6493         * go-exp.y (yylex): Update.
6494         * f-exp.y (yylex): Update.
6495         * d-exp.y: Update all rules.
6496         (yylex): Update.
6497         * c-exp.y: Update all rules.
6498         (lex_one_token, classify_name, yylex, c_parse): Update.
6499         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6500
6501 2019-04-04  Tom Tromey  <tom@tromey.com>
6502
6503         * gdbarch.h, gdbarch.c: Rebuild.
6504         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6505         * stap-probe.h:
6506         (struct stap_parse_info): Replace "parser_state" with
6507         "expr_builder".
6508         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6509         (parser_state): New class.
6510         * parse.c (expr_builder): Rename.
6511         (expr_builder::release): Rename.
6512         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6513         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6514         (write_exp_elt_longcst, write_exp_elt_floatcst)
6515         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6516         (write_exp_string_vector, write_exp_bitstring)
6517         (write_exp_msymbol, mark_struct_expression)
6518         (write_dollar_variable)
6519         (insert_type_address_space, increase_expout_size): Replace
6520         "parser_state" with "expr_builder".
6521         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6522         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6523         "parser_state" with "expr_builder".
6524
6525 2019-04-04  Tom Tromey  <tom@tromey.com>
6526
6527         * rust-exp.y: Replace "parse_language" with method call.
6528         * p-exp.y:
6529         (yylex): Replace "parse_language" with method call.
6530         * m2-exp.y:
6531         (yylex): Replace "parse_language" with method call.
6532         * go-exp.y (classify_name): Replace "parse_language" with method
6533         call.
6534         * f-exp.y (yylex): Replace "parse_language" with method call.
6535         * d-exp.y (lex_one_token): Replace "parse_language" with method
6536         call.
6537         * c-exp.y:
6538         (lex_one_token, classify_name, yylex): Replace "parse_language"
6539         with method call.
6540         * ada-exp.y (find_primitive_type, type_char)
6541         (type_system_address): Replace "parse_language" with method call.
6542
6543 2019-04-04  Tom Tromey  <tom@tromey.com>
6544
6545         * rust-exp.y: Replace "parse_gdbarch" with method call.
6546         * parse.c (write_dollar_variable, insert_type_address_space):
6547         Replace "parse_gdbarch" with method call.
6548         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6549         call.
6550         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6551         call.
6552         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6553         "parse_gdbarch" with method call.
6554         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6555         with method call.
6556         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6557         "parse_gdbarch" with method call.
6558         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6559         "parse_gdbarch" with method call.
6560         * c-exp.y (parse_type, parse_number, classify_name): Replace
6561         "parse_gdbarch" with method call.
6562         * ada-lex.l: Replace "parse_gdbarch" with method call.
6563         * ada-exp.y (parse_type, find_primitive_type, type_char)
6564         (type_system_address): Replace "parse_gdbarch" with method call.
6565
6566 2019-04-04  Tom Tromey  <tom@tromey.com>
6567
6568         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6569         * stap-probe.c (stap_parse_argument): Update.
6570         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6571         initial_size parameter.
6572         * rust-exp.y (rust_lex_tests): Update.
6573         * parse.c (parser_state): Update.
6574         (parse_exp_in_context): Update.
6575         * parser-defs.h (struct parser_state) <parser_state>: Remove
6576         "initial_size" parameter.
6577
6578 2019-04-04  Tom Tromey  <tom@tromey.com>
6579
6580         * parser-defs.h (increase_expout_size): Don't declare.
6581         * parse.c (increase_expout_size): Now static.
6582
6583 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6584
6585         * gnu-nat.c (gnu_nat_target::wait): Fix
6586         target_waitstatus_to_string call.
6587
6588 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6589
6590         * eval.c (evaluate_subexp_standard): Handle internal functions
6591         during Fortran function call handling.
6592
6593 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6594
6595         * NEWS: Mention new internal functions.
6596         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6597         (read_base_type): Use dwarf2_init_complex_target_type.
6598         * value.c (creal_internal_fn): New function.
6599         (cimag_internal_fn): New function.
6600         (_initialize_values): Register new internal functions.
6601
6602 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6603
6604         * infrun.c (stop_all_threads): If debug_infrun, always
6605         trace the wait status after wait_one, using
6606         target_waitstatus_to_string and target_pid_to_str.
6607         (handle_inferior_event): Replace various trace of
6608         wait status kind by a single trace.
6609         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6610         wait status kind image by target_waitstatus_to_string.
6611         * target/waitstatus.c (target_waitstatus_to_string): Fix
6612         obsolete comment.
6613
6614 2019-04-01  Tom Tromey  <tromey@adacore.com>
6615
6616         PR symtab/23331:
6617         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6618
6619 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6620             Pedro Alves  <palves@redhat.com>
6621
6622         * top.c (quit_force): Call 'finalize_values'.
6623         * value.c (finalize_values): New function.
6624         * value.h (finalize_values): Declare.
6625
6626 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6627
6628         * NEWS: Announce $_gdb_major and $_gdb_minor.
6629
6630         * top.c (init_gdb_version_vars): New function.
6631         (gdb_init): Call init_gdb_version_vars.
6632
6633 2019-03-29  Tom Tromey  <tromey@adacore.com>
6634
6635         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6636         help text.  Remove dead code.
6637
6638 2019-03-29  Keith Seitz  <keiths@redhat.com>
6639
6640         From Siddhesh Poyarekar:
6641         * f-lang.h (f77_get_upperbound): Return LONGEST.
6642         (f77_get_lowerbound): Likewise.
6643         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6644         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6645         print them.
6646         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6647         plongest to format print it.
6648         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6649         (f77_get_upperbound): Likewise.
6650         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6651         LOWER_BOUND to LONGEST.
6652         (f77_create_arrayprint_offset_tbl): Likewise.
6653
6654 2019-03-29  Keith Seitz  <keiths@redhat.com>
6655
6656         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6657         %s/pulongest for TYPE_LENGTH instead of %d in format
6658         strings.
6659         * ada-typerint.c (ada_print_type): Likewise.
6660         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6661         * compile/compile-c-support.c (generate_register_struct): Likewise.
6662         * gdbtypes.c (recursive_dump_type): Likewise.
6663         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6664         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6665         instead of %d in format strings.
6666         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6667         to std::min to ULONGEST.
6668         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6669         instead of %d in format strings.
6670         * tracepoint.c (info_scope_command): Likewise.
6671         * typeprint.c (print_offset_data::update)
6672         (print_offset_data::finish): Likewise.
6673         * xtensa-tdep.c (xtensa_store_return_value)
6674         (xtensa_push_dummy_call): Likewise.
6675
6676 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6677
6678         * windows-nat.c (display_selector): Fixed format specifications
6679         for 64-bit Cygwin.
6680
6681 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6682
6683         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6684
6685 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6686
6687         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6688         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6689         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6690         (nios2_linux_init_abi): Install it.
6691
6692 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6693
6694         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6695
6696 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6697
6698         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6699
6700 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6701             Tom Tromey  <tromey@adacore.com>
6702
6703         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6704
6705 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6706
6707         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6708         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6709         method to compute the bounds of range types. Also print "[evaluated]"
6710         if the bounds' values come from a dynamic evaluation.
6711
6712 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6713
6714         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6715         whitespace when pretty printing is on.
6716
6717 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6718
6719         * ppc-linux-nat.c: Add include.
6720
6721 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6722
6723         * NEWS: Mention AArch64 Pointer Authentication.
6724
6725 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6726
6727         * arm-linux-nat.c: Add include.
6728
6729 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6730
6731         * source-cache.c (source_cache::get_source_lines): Re-read
6732         fullname after calling open_source_file.
6733
6734 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6735
6736         * NEWS: Mention TLS support for FreeBSD.
6737
6738 2019-03-25  Tom Tromey  <tromey@adacore.com>
6739
6740         * minsyms.c (BUNCH_SIZE): Update comment.
6741         (~minimal_symbol_reader): Remove old comment.
6742         (compact_minimal_symbols): Update comment.
6743         (minimal_symbol_reader::install): Remove old comment.  Update
6744         other comments.
6745
6746 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6747
6748         * s390-linux-nat.c: Add include.
6749
6750 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6751
6752         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6753         Call linux_get_hwcap.
6754         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6755         Likewise.
6756         (aarch64_linux_get_hwcap): Remove function.
6757         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6758         declaration.
6759         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6760         linux_get_hwcap.
6761         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6762         * linux-tdep.c (linux_get_hwcap): Add function.
6763         (linux_get_hwcap2): Likewise.
6764         * linux-tdep.h (linux_get_hwcap): Add declaration.
6765         (linux_get_hwcap2): Likewise.
6766         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6767         (ppc_linux_get_hwcap2): Likewise.
6768         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6769         linux_get_hwcap.
6770         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6771         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6772         (ppc_linux_nat_target::read_description): Likewise.
6773         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6774         * s390-linux-nat.c: Likewise.
6775         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6776
6777 2019-03-24  Tom Tromey  <tom@tromey.com>
6778
6779         * ada-lang.c (standard_lookup): Simplify initialization.
6780         (ada_lookup_symbol_nonlocal): Simplify return.
6781         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6782         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6783         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6784         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6785         initialization.
6786         * solib.c (solib_global_lookup): Simplify.
6787         * symtab.c (null_block_symbol): Remove.
6788         (symbol_cache_lookup): Simplify returns.
6789         (lookup_language_this): Simplify returns.
6790         (lookup_symbol_aux): Simplify return.
6791         (lookup_local_symbol): Simplify returns.
6792         (lookup_global_symbol_from_objfile): Simplify return.
6793         (lookup_symbol_in_objfile_symtabs)
6794         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6795         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6796         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6797         * cp-namespace.c (cp_lookup_bare_symbol)
6798         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6799         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6800         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6801         (cp_lookup_symbol_via_imports): Simplify initialization.
6802         (find_symbol_in_baseclass): Likewise.
6803         * symtab.h (null_block_symbol): Remove.
6804         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6805         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6806         (d_lookup_symbol_module): Likewise.
6807         (find_symbol_in_baseclass): Simplify initialization.
6808
6809 2019-03-24  Tom Tromey  <tom@tromey.com>
6810
6811         * expression.h: Don't include symtab.h.
6812         (struct block): Forward declare.
6813
6814 2019-03-24  Tom Tromey  <tom@tromey.com>
6815
6816         * c-exp.y (typebase): Remove casts.
6817         * gdbtypes.c (lookup_unsigned_typename, )
6818         (lookup_signed_typename): Remove cast.
6819         * eval.c (parse_to_comma_and_eval): Remove cast.
6820         * parse.c (write_dollar_variable): Remove cast.
6821         * block.h (struct block) <superblock>: Now const.
6822         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6823         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6824         (map_block): Make "block" const.
6825         * symfile.h (struct quick_symbol_functions)
6826         <map_matching_symbols>: Constify block argument to "callback".
6827         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6828         const.
6829         (find_pc_sect_compunit_symtab): Make "b" const.
6830         (find_symbol_at_address): Likewise.
6831         (search_symbols): Likewise.
6832         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6833         (dw2_debug_names_lookup_symbol): Likewise.
6834         (dw2_map_matching_symbols): Update.
6835         * p-valprint.c (pascal_val_print): Remove "block".
6836         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6837         (aux_add_nonlocal_symbols): Make "block" const.
6838         (resolve_subexp): Remove cast.
6839         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6840         const.
6841         (iterate_over_file_blocks): Likewise.
6842         * f-exp.y (%union) <bval>: Remove.
6843         * coffread.c (patch_opaque_types): Make "b" const.
6844         * spu-tdep.c (spu_catch_start): Make "block" const.
6845         * c-valprint.c (print_unpacked_pointer): Remove "block".
6846         * symmisc.c (dump_symtab_1): Make "b" const.
6847         (block_depth): Make "block" const.
6848         * d-exp.y (%union) <bval>: Remove.
6849         * cp-support.h (cp_lookup_rtti_type): Update.
6850         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6851         * psymtab.c (psym_lookup_symbol): Make "block" const.
6852         (maintenance_check_psymtabs): Make "b" const.
6853         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6854         (enumerate_locals, enumerate_args): Update.
6855         * python/py-symtab.c (stpy_global_block): Make "block" const.
6856         (stpy_static_block): Likewise.
6857         * inline-frame.c (block_starting_point_at): Make "new_block"
6858         const.
6859         * block.c (find_block_in_blockvector): Make return type const.
6860         (blockvector_for_pc_sect): Make "b" const.
6861         (find_block_in_blockvector): Make "b" const.
6862
6863 2019-03-23  Tom Tromey  <tom@tromey.com>
6864
6865         * varobj.c (varobj_create): Update.
6866         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6867         * printcmd.c (display_command, do_one_display): Don't reset
6868         innermost_block.
6869         * parser-defs.h (enum innermost_block_tracker_type): Move to
6870         expression.h.
6871         (innermost_block): Update comment.
6872         * parse.c (parse_exp_1): Add tracker_types parameter.
6873         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6874         tracker_types parameter.  Reset innermost_block.
6875         (parse_exp_in_context): Remove.
6876         (parse_expression_for_completion): Update.
6877         * objfiles.c (~objfile): Don't reset expression_context_block or
6878         innermost_block.
6879         * expression.h (enum innermost_block_tracker_type): Move from
6880         parser-defs.h.
6881         (parse_exp_1): Add tracker_types parameter.
6882         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6883         reset innermost_block.
6884
6885 2019-03-23  Tom Tromey  <tom@tromey.com>
6886
6887         * objfiles.h: Include bcache.h.
6888
6889 2019-03-23  Tom Tromey  <tom@tromey.com>
6890
6891         * linespec.c (get_current_search_block): Use
6892         scoped_restore_current_language.
6893         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6894
6895 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6896             Jiong Wang  <jiong.wang@arm.com>
6897
6898         * aarch64-linux-tdep.c
6899         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6900         section.
6901         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6902
6903 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6904             Jiong Wang  <jiong.wang@arm.com>
6905
6906         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6907         instructions.
6908         (aarch64_analyze_prologue_test): Add PACIASP test.
6909         (aarch64_prologue_prev_register): Unmask PC value.
6910
6911 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6912             Jiong Wang  <jiong.wang@arm.com>
6913
6914         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6915         (aarch64_dwarf2_prev_register): Unmask PC value.
6916         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6917         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6918         DW_CFA_AARCH64_negate_ra_state.
6919         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6920
6921 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6922             Jiong Wang  <jiong.wang@arm.com>
6923
6924         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6925         registers.
6926         (aarch64_pseudo_register_name): Likewise.
6927         (aarch64_pseudo_register_type): Likewise.
6928         (aarch64_pseudo_register_reggroup_p): Likewise.
6929         (aarch64_gdbarch_init): Add pauth registers.
6930         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6931         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6932         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6933         (struct gdbarch_tdep): Add regnum for ra_state.
6934
6935 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6936             Jiong Wang  <jiong.wang@arm.com>
6937
6938         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6939
6940 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6941             Jiong Wang  <jiong.wang@arm.com>
6942
6943         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6944         function.
6945         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6946         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6947         (aarch64_gdbarch_init): Add puth registers.
6948         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6949         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6950         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6951
6952 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6953             Jiong Wang  <jiong.wang@arm.com>
6954
6955         * aarch64-linux-nat.c
6956         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6957         * aarch64-linux-tdep.c
6958         (aarch64_linux_core_read_description): Likewise.
6959         (aarch64_linux_get_hwcap): New function.
6960         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6961         (aarch64_linux_get_hwcap): New declaration.
6962
6963 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6964             Jiong Wang  <jiong.wang@arm.com>
6965
6966         * aarch64-linux-nat.c
6967         (aarch64_linux_nat_target::read_description): Add pauth param.
6968         * aarch64-linux-tdep.c
6969         (aarch64_linux_core_read_description): Likewise.
6970         * aarch64-tdep.c (struct target_desc): Add in pauth.
6971         (aarch64_read_description): Add pauth param.
6972         (aarch64_gdbarch_init): Likewise.
6973         * aarch64-tdep.h (aarch64_read_description): Likewise.
6974         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6975         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6976         * features/Makefile: Add new files.
6977         * features/aarch64-pauth.c: New file.
6978         * features/aarch64-pauth.xml: New file.
6979
6980 2019-03-20  Tom Tromey  <tromey@adacore.com>
6981
6982         * infrun.c (handle_inferior_event): Rename from
6983         handle_inferior_event_1.  Create a scoped_value_mark.
6984         (handle_inferior_event): Remove.
6985
6986 2019-03-19  Tom Tromey  <tromey@adacore.com>
6987
6988         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6989         * infrun.h (print_stop_event): Add "displays" parameter.
6990         * infrun.c (print_stop_event): Add "displays" parameter.
6991
6992 2019-03-19  Pedro Alves  <palves@redhat.com>
6993
6994         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6995         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6996         to -1.  Fix TABs vs spaces.
6997         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6998         * tui/tui-out.h (tui_ui_out) Add intro comments.
6999         <m_line, m_start_of_line>: In-class initialize, and add describing
7000         comment.
7001
7002 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7003
7004         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7005         variable names.
7006         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7007
7008 2019-03-18  Pedro Alves  <palves@redhat.com>
7009             Eli Zaretskii <eliz@gnu.org>
7010
7011         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7012         m_line and m_start_of_line.
7013
7014 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7015
7016         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7017         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7018         it returns a newline.  This fixes a regression in TU mode, whereby
7019         the next line is output on the same screen line as the user input.
7020
7021 2019-03-18  Tom Tromey  <tromey@adacore.com>
7022
7023         * minsyms.c (minimal_symbol_reader::install): Remove call to
7024         obstack_blank.
7025
7026 2019-03-18  Pedro Alves  <palves@redhat.com>
7027
7028         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7029         New globals.
7030         (apply_style): New, factored out from ...
7031         (apply_ansi_escape): ... this.  Handle reverse video mode.
7032         (tui_set_reverse_mode): New function.
7033         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7034         * tui/tui-winsource.c (tui_show_source_line): Use
7035         tui_set_reverse_mode instead of setting A_STANDOUT.
7036         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7037         New setter methods.
7038
7039 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7040
7041         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7042         Handle tabs.
7043
7044 2019-03-18  Tom Tromey  <tromey@adacore.com>
7045
7046         * ada-lang.c (empty_array): Add "high" parameter.
7047         (ada_evaluate_subexp): Update.
7048
7049 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7050
7051         * unittests/string_view-selftests.c: Define
7052         _initialize_string_view_selftests unconditionally.
7053
7054 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7055
7056         PR gdb/24350
7057         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7058
7059 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7060
7061         PR gdb/24351
7062         * windows-nat.c (display_selector): Fix format specifiers.
7063
7064 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7065
7066         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7067         tui_refill_source_window instead of tui_refresh_win, to update the
7068         current execution line.  This fixes redisplay of the current line
7069         when stepping through the code with "next" or "step".
7070
7071 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7072
7073         * source-cache.c (source_cache::get_source_lines): Call
7074         find_source_lines to initialize s->nlines.  This fixes vertical
7075         scrolling of TUI source window when the DOWN arrow is pressed.
7076
7077 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7078
7079         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7080         linux-thread-db.c (_initialize_thread_db): Likewise.
7081
7082 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7083
7084         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7085         wclrtoeol in tui_show_source_line".  This reverts changes made in
7086         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7087
7088 2019-03-15  Tom Tromey  <tom@tromey.com>
7089
7090         * symtab.h (struct minimal_symbol): Derive from
7091         general_symbol_info.
7092         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7093         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7094         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7095         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7096         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7097         (MSYMBOL_SEARCH_NAME): Update.
7098         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7099         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7100         * minsyms.c (minimal_symbol_reader::record_full): Update.
7101
7102 2019-03-15  Tom Tromey  <tom@tromey.com>
7103
7104         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7105
7106 2019-03-15  Tom Tromey  <tom@tromey.com>
7107
7108         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7109         unique_xmalloc_ptr.
7110         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7111         Update.
7112         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7113         (build_minimal_symbol_hash_tables)
7114         (minimal_symbol_reader::install): Update.
7115
7116 2019-03-15  Tom Tromey  <tom@tromey.com>
7117
7118         * symtab.c (create_demangled_names_hash): Update.
7119         (symbol_set_names): Update.
7120         * objfiles.h (struct objfile_per_bfd_storage)
7121         <demangled_names_hash>: Now an htab_up.
7122         * objfiles.c (objfile_per_bfd_storage): Simplify.
7123
7124 2019-03-15  Tom Tromey  <tom@tromey.com>
7125
7126         * objfiles.h (struct objfile_per_bfd_storage): Declare
7127         destructor.
7128         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7129         New.
7130         (get_objfile_bfd_data): Use new.  Don't initialize
7131         language_of_main.
7132         (free_objfile_per_bfd_storage): Remove.
7133         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7134
7135 2019-03-15  Tom Tromey  <tom@tromey.com>
7136
7137         * symfile.c (reread_symbols): Update.
7138         * objfiles.c (objfile::objfile): Update.
7139         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7140         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7141         comment.
7142         (minimal_symbol_reader::install): Update.
7143         (terminate_minimal_symbol_table): Remove.
7144         * jit.c (jit_object_close_impl): Update.
7145
7146 2019-03-15  Tom Tromey  <tom@tromey.com>
7147
7148         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7149         initializations.
7150
7151 2019-03-15  Tom Tromey  <tom@tromey.com>
7152
7153         * objfiles.h (struct objfile_per_bfd_storage)
7154         <demangled_hash_languages>: Now a bitset.
7155         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7156         (lookup_minimal_symbol): Update.
7157
7158 2019-03-15  Tom Tromey  <tom@tromey.com>
7159
7160         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7161         Don't return the symbol.
7162         * coffread.c (record_minimal_symbol): Use record_full.
7163
7164 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7165
7166         The MS-Windows port of ncurses fails to switch to a color pair if
7167         one or both of the colors are the implicit default colors.  This
7168         change records the default colors when TUI is initialized, and
7169         then specifies them explicitly when a color pair uses the default
7170         colors.  This allows color styling in TUI mode on MS-Windows.
7171
7172         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7173         ncurses_norm_attr.
7174         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7175         colors in ncurses_norm_attr.
7176         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7177         "none", replace it with the default color recorded in
7178         ncurses_norm_attr.
7179
7180 2019-03-14  Tom Tromey  <tromey@adacore.com>
7181
7182         * source-cache.h (class source_cache) <get_source_lines>: Return
7183         std::string.
7184         * source-cache.c (source_cache::extract_lines): Handle case where
7185         first_pos==npos.  Return std::string.
7186         (source_cache::get_source_lines): Update.
7187
7188 2019-03-14  Tom Tromey  <tromey@adacore.com>
7189
7190         * NEWS: Add item for "style sources" commands.
7191         * source-cache.c (source_cache::get_source_lines): Check
7192         source_styling.
7193         * cli/cli-style.c (source_styling): New global.
7194         (_initialize_cli_style): Add "style sources" commands.
7195         (show_style_sources): New function.
7196         * cli/cli-style.h (source_styling): Declare.
7197
7198 2019-03-14  Pedro Alves  <palves@redhat.com>
7199             Tom Tromey  <tromey@adacore.com>
7200
7201         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7202         * tui/tui-winsource.c (tui_refill_source_window): New function,
7203         from...
7204         (tui_horizontal_source_scroll): ... here.  Move some logic.
7205         * cli/cli-style.c (set_style_enabled): Notify new observable.
7206         * tui/tui-hooks.c (tui_redisplay_source): New function.
7207         (tui_attach_detach_observers): Attach or detach
7208         tui_redisplay_source.
7209         * observable.h (source_styling_changed): New observable.
7210         * observable.c: Define source_styling_changed observable.
7211
7212 2019-03-13  Tom Tromey  <tromey@adacore.com>
7213
7214         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7215         (i386_gnu_nat_target::store_registers): Update.
7216         * target-debug.h (target_debug_print_std_string): New macro.
7217         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7218         * windows-tdep.c (display_one_tib): Update.
7219         * tui/tui-stack.c (tui_make_status_line): Update.
7220         * top.c (print_inferior_quit_action): Update.
7221         * thread.c (thr_try_catch_cmd): Update.
7222         (add_thread_with_info): Update.
7223         (thread_target_id_str): Update.
7224         (thr_try_catch_cmd): Update.
7225         (thread_command): Update.
7226         (thread_find_command): Update.
7227         * record-btrace.c (record_btrace_target::info_record)
7228         (record_btrace_resume_thread, record_btrace_target::resume)
7229         (record_btrace_cancel_resume, record_btrace_step_thread)
7230         (record_btrace_target::wait, record_btrace_target::wait)
7231         (record_btrace_target::wait, record_btrace_target::stop): Update.
7232         * progspace.c (print_program_space): Update.
7233         * process-stratum-target.c
7234         (process_stratum_target::thread_address_space): Update.
7235         * linux-fork.c (linux_fork_mourn_inferior)
7236         (detach_checkpoint_command, info_checkpoints_command)
7237         (linux_fork_context): Update.
7238         (linux_fork_detach): Update.
7239         (class scoped_switch_fork_info): Update.
7240         (delete_checkpoint_command): Update.
7241         * infrun.c (follow_fork_inferior): Update.
7242         (follow_fork_inferior): Update.
7243         (proceed_after_vfork_done): Update.
7244         (handle_vfork_child_exec_or_exit): Update.
7245         (follow_exec): Update.
7246         (displaced_step_prepare_throw): Update.
7247         (displaced_step_restore): Update.
7248         (start_step_over): Update.
7249         (resume_1): Update.
7250         (clear_proceed_status_thread): Update.
7251         (proceed): Update.
7252         (print_target_wait_results): Update.
7253         (do_target_wait): Update.
7254         (context_switch): Update.
7255         (stop_all_threads): Update.
7256         (restart_threads): Update.
7257         (finish_step_over): Update.
7258         (handle_signal_stop): Update.
7259         (switch_back_to_stepped_thread): Update.
7260         (keep_going_pass_signal): Update.
7261         (print_exited_reason): Update.
7262         (normal_stop): Update.
7263         * inferior.c (inferior_pid_to_str): Change return type.
7264         (print_selected_inferior): Update.
7265         (add_inferior): Update.
7266         (detach_inferior): Update.
7267         * dummy-frame.c (fprint_dummy_frames): Update.
7268         * dcache.c (dcache_info_1): Update.
7269         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7270         (btrace_fetch, btrace_clear): Update.
7271         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7272         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7273         type.
7274         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7275         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7276         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7277         * gdbarch.c, gdbarch.h: Rebuild.
7278         * gdbarch.sh (core_pid_to_str): Change return type.
7279         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7280         return type.
7281         (windows_nat_target::pid_to_str): Change return type.
7282         (windows_delete_thread): Update.
7283         (windows_nat_target::attach): Update.
7284         (windows_nat_target::files_info): Update.
7285         * target-delegates.c: Rebuild.
7286         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7287         return type.
7288         (sol_thread_target::pid_to_str): Change return type.
7289         * remote.c (class remote_target) <pid_to_str>: Change return
7290         type.
7291         (remote_target::pid_to_str): Change return type.
7292         (extended_remote_target::attach, remote_target::remote_stop_ns)
7293         (remote_target::remote_notif_remove_queued_reply)
7294         (remote_target::push_stop_reply, remote_target::disable_btrace):
7295         Update.
7296         (extended_remote_target::attach): Update.
7297         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7298         type.
7299         (gdbsim_target::pid_to_str): Change return type.
7300         * ravenscar-thread.c (struct ravenscar_thread_target)
7301         <pid_to_str>: Change return type.
7302         (ravenscar_thread_target::pid_to_str): Change return type.
7303         * procfs.c (class procfs_target) <pid_to_str>: Change return
7304         type.
7305         (procfs_target::pid_to_str): Change return type.
7306         (procfs_target::attach): Update.
7307         (procfs_target::detach): Update.
7308         (procfs_target::fetch_registers): Update.
7309         (procfs_target::store_registers): Update.
7310         (procfs_target::wait): Update.
7311         (procfs_target::files_info): Update.
7312         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7313         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7314         return type.
7315         (nto_procfs_target::pid_to_str): Change return type.
7316         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7317         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7318         return type.
7319         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7320         (exit_lwp): Update.
7321         (attach_proc_task_lwp_callback, get_detach_signal)
7322         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7323         (linux_nat_target::resume, wait_lwp, stop_callback)
7324         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7325         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7326         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7327         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7328         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7329         type.
7330         (inf_ptrace_target::attach): Update.
7331         (inf_ptrace_target::files_info): Update.
7332         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7333         type.
7334         (go32_nat_target::pid_to_str): Change return type.
7335         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7336         (gnu_nat_target::wait): Update.
7337         (gnu_nat_target::wait): Update.
7338         (gnu_nat_target::resume): Update.
7339         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7340         (fbsd_nat_target::wait): Update.
7341         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7342         type.
7343         (darwin_nat_target::attach): Update.
7344         * corelow.c (class core_target) <pid_to_str>: Change return type.
7345         (core_target::pid_to_str): Change return type.
7346         * target.c (normal_pid_to_str): Change return type.
7347         (default_pid_to_str): Likewise.
7348         (target_pid_to_str): Change return type.
7349         (target_translate_tls_address): Update.
7350         (target_announce_detach): Update.
7351         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7352         return type.
7353         (bsd_uthread_target::pid_to_str): Change return type.
7354         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7355         type.
7356         (bsd_kvm_target::pid_to_str): Change return type.
7357         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7358         return type.
7359         (aix_thread_target::pid_to_str): Change return type.
7360         * target.h (struct target_ops) <pid_to_str>: Change return type.
7361         (target_pid_to_str, normal_pid_to_str): Likewise.
7362         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7363         type.
7364         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7365         type.
7366         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7367         return type.
7368         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7369         type.
7370         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7371         type.
7372         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7373         return type.
7374
7375 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7376
7377         * NEWS: Mention that the new default MI version is 3.  Mention
7378         changes to the output of commands and events that deal with
7379         multi-location breakpoints.
7380         * breakpoint.c: Include "mi/mi-out.h".
7381         (print_one_breakpoint): Change output syntax if using MI version
7382         >= 3.
7383         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7384         New.
7385         (mi_multi_location_breakpoint_output_fixed): New.
7386         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7387         (mi_cmd_fix_multi_location_breakpoint_output): New.
7388         (mi_multi_location_breakpoint_output_fixed): New.
7389         * mi/mi-cmds.c (mi_cmds): Register command
7390         -fix-multi-location-breakpoint-output.
7391         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7392         interpreter "mi".
7393
7394 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7395
7396         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7397         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7398         instantiate mi_ui_out based on interpreter name.
7399         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7400         * mi/mi-main.c (mi_load_progress): Likewise.
7401
7402 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7403
7404         * NEWS: Combine separate "New targets" sections for 8.3.
7405
7406 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7407
7408         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7409         (ppcfbsd_init_abi): Install gdbarch
7410         "fetch_tls_load_module_address" and "get_thread_local_address"
7411         methods.
7412
7413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7414
7415         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7416         (riscv_fbsd_init_abi): Install gdbarch
7417         "fetch_tls_load_module_address" and "get_thread_local_address"
7418         methods.
7419
7420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7421
7422         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7423         (i386fbsd_init_abi): Install gdbarch
7424         "fetch_tls_load_module_address" and "get_thread_local_address"
7425         methods.
7426
7427 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7428
7429         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7430         (amd64fbsd_init_abi): Install gdbarch
7431         "fetch_tls_load_module_address" and "get_thread_local_address"
7432         methods.
7433
7434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7435
7436         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7437         (struct fbsd_pspace_data): New type.
7438         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7439         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7440         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7441         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7442         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7443
7444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7445
7446         * gdbtypes.c (lookup_struct_elt): New function.
7447         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7448         * gdbtypes.h (struct struct_elt): New type.
7449         (lookup_struct_elt): New prototype.
7450
7451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7452
7453         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7454         remove disabled code block.
7455
7456 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7457
7458         * gdbarch.sh (get_thread_local_address): New method.
7459         * gdbarch.h, gdbarch.c: Regenerate.
7460         * target.c (target_translate_tls_address): Use
7461         gdbarch_get_thread_local_address if present instead of
7462         target::get_thread_local_address.
7463
7464 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7465
7466         * target.h (target::get_thread_local_address): Update comment.
7467
7468 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7469
7470         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7471         objfile->separate_debug_objfile_backlink if not NULL.
7472
7473 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7474
7475         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7476         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7477         (amd64bsd_store_inferior_registers): Likewise.
7478         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7479         Enable segment base registers.
7480         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7481         PT_GETFSBASE and PT_GETGSBASE.
7482         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7483         PT_SETGSBASE.
7484         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7485         segment base registers.
7486         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7487
7488 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7489
7490         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7491         Update calls to i386_target_description to add 'segments'
7492         parameter.
7493         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7494         add segment base registers.
7495         * arch/i386.c (i386_create_target_description): Add 'segments'
7496         parameter to enable segment base registers.
7497         * arch/i386.h (i386_create_target_description): Likewise.
7498         * features/i386/32bit-segments.xml: New file.
7499         * features/i386/32bit-segments.c: Generate.
7500         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7501         call to i386_target_description to add 'segments' parameter.
7502         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7503         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7504         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7505         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7506         if feature is present.
7507         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7508         Add 'segments' parameter to call to i386_target_description.
7509         (i386_target_description): Add 'segments' parameter to enable
7510         segment base registers.
7511         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7512         to call to i386_target_description.
7513         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7514         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7515         Define I386_NUM_REGS.
7516         (i386_target_description): Add 'segments' parameter to enable
7517         segment base registers.
7518
7519 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7520
7521         PR/24325
7522         * source-cache.c: #undef open and close, to avoid unresolved
7523         externals during linking.
7524
7525 2019-03-12  Tom Tromey  <tromey@adacore.com>
7526
7527         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7528         const.  Add initializers.
7529         (_initialize_remote): Don't initialize ptid globals.
7530
7531 2019-03-12  Pedro Alves  <palves@redhat.com>
7532
7533         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7534
7535 2019-03-12  Pedro Alves  <palves@redhat.com>
7536
7537         * cp-name-parser.y (main): Remove unused 'len' variable.
7538
7539 2019-03-12  Tom Tromey  <tromey@adacore.com>
7540
7541         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7542         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7543
7544 2019-03-12  Tom Tromey  <tromey@adacore.com>
7545
7546         * linux-nat.c (iterate_over_lwps): Update.
7547         (stop_callback): Remove parameter.
7548         (stop_wait_callback, detach_callback, resume_set_callback)
7549         (select_singlestep_lwp_callback, set_ignore_sigint)
7550         (status_callback, resumed_callback, resume_clear_callback)
7551         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7552         data parameter.
7553         (linux_nat_target::detach, linux_nat_target::resume)
7554         (linux_stop_and_wait_all_lwps, select_event_lwp)
7555         (linux_nat_filter_event, linux_nat_wait_1)
7556         (linux_nat_target::kill, linux_nat_target::stop)
7557         (linux_nat_target::stop): Update.
7558         (linux_nat_resume_callback): Change type.
7559         (resume_stopped_resumed_lwps, count_events_callback)
7560         (select_event_lwp_callback): Likewise.
7561         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7562         * arm-linux-nat.c (struct update_registers_data): Remove.
7563         (update_registers_callback): Change type.
7564         (arm_linux_insert_hw_breakpoint1): Update.
7565         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7566         parameter.
7567         (x86_linux_dr_set_addr): Update.
7568         (x86_linux_dr_set_control): Update.
7569         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7570         (iterate_over_lwps): Use gdb::function_view.
7571         * nat/aarch64-linux-hw-point.c (struct
7572         aarch64_dr_update_callback_param): Remove.
7573         (debug_reg_change_callback): Change type.
7574         (aarch64_notify_debug_reg_change): Update.
7575         * s390-linux-nat.c (s390_refresh_per_info): Update.
7576
7577 2019-03-11  Tom Tromey  <tromey@adacore.com>
7578
7579         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7580         redundant assignment to "this_cu".
7581
7582 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7583
7584         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7585
7586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7587
7588         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7589         from...
7590         (rank_one_type): ... this.
7591
7592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7593
7594         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7595         from...
7596         (rank_one_type): ... this.
7597
7598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7599
7600         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7601         from...
7602         (rank_one_type): ... this.
7603
7604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7605
7606         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7607         from...
7608         (rank_one_type): ... this.
7609
7610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7611
7612         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7613         from...
7614         (rank_one_type): ... this.
7615
7616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7617
7618         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7619         from...
7620         (rank_one_type): ... this.
7621
7622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7623
7624         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7625         from...
7626         (rank_one_type): ... this.
7627
7628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7629
7630         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7631         from...
7632         (rank_one_type): ... this.
7633
7634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7635
7636         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7637         from...
7638         (rank_one_type): ... this.
7639
7640 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7641
7642         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7643         from...
7644         (rank_one_type): ... this.
7645
7646 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7647
7648         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7649         from...
7650         (rank_one_type): ... this.
7651
7652 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7653
7654         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7655         from...
7656         (rank_one_type): ... this.
7657
7658 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7659
7660         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7661         inferior-events' shows the example events.
7662
7663 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7664
7665         Support styling on native MS-Windows console
7666
7667         PR/24315
7668         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7669         on MS-Windows if $TERM is not defined.
7670
7671         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7672
7673         * posix-hdep.c (gdb_console_fputs):
7674         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7675         functions.
7676         * ui-file.h (gdb_console_fputs): Add prototype.
7677
7678         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7679         back to fputs only if the former returns zero.
7680
7681 2019-03-07  Tom Tromey  <tom@tromey.com>
7682
7683         * symmisc.c (print_symbol_bcache_statistics): Update.
7684         (print_objfile_statistics): Update.
7685         * symfile.c (allocate_symtab): Update.
7686         * stabsread.c: Don't include bcache.h.
7687         * psymtab.h (struct psymbol_bcache): Don't declare.
7688         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7689         (psymbol_bcache_init, psymbol_bcache_free)
7690         (psymbol_bcache_get_bcache): Don't declare.
7691         * psymtab.c (struct psymbol_bcache): Remove.
7692         (psymtab_storage::psymtab_storage): Update.
7693         (psymtab_storage::~psymtab_storage): Update.
7694         (psymbol_bcache_init, psymbol_bcache_free)
7695         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7696         (add_psymbol_to_bcache): Update.
7697         (allocate_psymtab): Update.
7698         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7699         macro_cache>: No longer pointers.
7700         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7701         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7702         * macrotab.c (macro_bcache): Update.
7703         * macroexp.c: Don't include bcache.h.
7704         * gdbtypes.c (check_types_worklist): Update.
7705         (types_deeply_equal): Remove TRY/CATCH.  Update.
7706         * elfread.c (elf_symtab_read): Update.
7707         * dwarf2read.c: Don't include bcache.h.
7708         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7709         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7710         (print_bcache_statistics, bcache_memory_used): Don't declare.
7711         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7712         methods.  Rename all data members.
7713         * bcache.c (struct bcache): Move to bcache.h.
7714         (bcache::expand_hash_table): Rename from expand_hash_table.
7715         (bcache): Remove.
7716         (bcache::insert): Rename from bcache_full.
7717         (bcache::compare): Rename from bcache_compare.
7718         (bcache_xmalloc): Remove.
7719         (bcache::~bcache): Rename from bcache_xfree.
7720         (bcache::print_statistics): Rename from print_bcache_statistics.
7721         (bcache::memory_used): Rename from bcache_memory_used.
7722
7723 2019-03-07  Pedro Alves  <palves@redhat.com>
7724
7725         * infrun.c (normal_stop): Also check for
7726         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7727
7728 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7729
7730         * f-lang.c (value_from_host_double): Moved to...
7731         * value.c (value_from_host_double): ...here.
7732         * value.h (value_from_host_double): Declare.
7733         * guile/scm-math.c (vlscm_convert_typed_number): Use
7734         value_from_host_double.
7735         (vlscm_convert_number): Likewise.
7736         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7737         * python/py-value.c (convert_value_from_python): Likewise.
7738
7739 2019-03-06  Tom Tromey  <tom@tromey.com>
7740
7741         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7742
7743 2019-03-06  Tom Tromey  <tom@tromey.com>
7744
7745         * utils.h (free_current_contents): Don't declare.
7746         * utils.c (free_current_contents): Remove.
7747
7748 2019-03-06  Tom Tromey  <tom@tromey.com>
7749
7750         * top.c (quit_force): Update.
7751         * main.c (captured_command_loop): Update.
7752         * common/new-op.c (operator new): Update.
7753         * common/common-exceptions.c (struct catcher)
7754         <save_cleanup_chain>: Remove member.
7755         (exceptions_state_mc_init): Update.
7756         (exception_try_scope_entry): Return nullptr.
7757         (exception_try_scope_exit, exception_rethrow)
7758         (throw_exception_sjlj, throw_exception_cxx): Update.
7759         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7760         (all_cleanups, do_cleanups, discard_cleanups)
7761         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7762         (restore_cleanups, restore_final_cleanups): Don't declare.
7763         (do_final_cleanups): Remove parameter.
7764         * common/cleanups.c (cleanup_chain, make_cleanup)
7765         (make_cleanup_dtor, all_cleanups, do_cleanups)
7766         (discard_my_cleanups, discard_cleanups)
7767         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7768         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7769         (null_cleanup): Remove.
7770         (do_final_cleanups): Remove parameter.
7771
7772 2019-03-06  Tom Tromey  <tom@tromey.com>
7773
7774         * remote.c (remote_target::remote_parse_stop_reply): Use
7775         unique_xmalloc_ptr.
7776
7777 2019-03-06  Tom Tromey  <tom@tromey.com>
7778
7779         * stabsread.c (struct stabs_field_info): Rename from field_info.
7780         <list, fnlist>: Add initializers.
7781         <obstack>: New member.
7782         (read_member_functions, read_struct_fields, read_baseclasses):
7783         Allocate on obstack.  Don't use cleanups.
7784         (read_one_struct_field, read_member_functions, read_struct_fields)
7785         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7786         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7787         (read_struct_type): Update.
7788
7789 2019-03-06  Tom Tromey  <tom@tromey.com>
7790
7791         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7792         * common/filestuff.h (make_cleanup_close): Don't declare.
7793         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7794         Remove.
7795
7796 2019-03-06  Tom Tromey  <tom@tromey.com>
7797
7798         * solib-aix.c: Use make_scope_exit.
7799
7800 2019-03-06  Tom Tromey  <tom@tromey.com>
7801
7802         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7803         Use make_scope_exit.
7804
7805 2019-03-06  Tom Tromey  <tom@tromey.com>
7806
7807         * solib-svr4.c (disable_probes_interface): Remove parameter.
7808         (svr4_handle_solib_event): Use make_scope_exit.
7809
7810 2019-03-06  Tom Tromey  <tom@tromey.com>
7811
7812         * remote.c (struct stop_reply_deleter): Remove.
7813         (stop_reply_up): Update.
7814         (struct stop_reply): Derive from notif_event.  Don't typedef.
7815         <regcache>: Now a std::vector.
7816         (stop_reply_xfree): Remove.
7817         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7818         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7819         (remote_target::discard_pending_stop_replies): Use delete.
7820         (remote_target::remote_parse_stop_reply): Update.
7821         (remote_target::process_stop_reply): Update.
7822         * remote-notif.h (struct notif_event): Add virtual destructor.
7823         Remove "dtr" member.
7824         (struct notif_client) <alloc_event>: Return a unique_ptr.
7825         (notif_event_xfree): Don't declare.
7826         (notif_event_up): New typedef.
7827         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7828         (notif_event_xfree, do_notif_event_xfree): Remove.
7829         (remote_notif_state_xfree): Update.
7830
7831 2019-03-06  Tom Tromey  <tom@tromey.com>
7832
7833         * infrun.c (displaced_step_clear_cleanup): Now a
7834         forward_scope_exit type.
7835         (displaced_step_prepare_throw): Update.
7836         (displaced_step_fixup): Update.
7837
7838 2019-03-06  Tom Tromey  <tom@tromey.com>
7839
7840         * inferior.h (class inferior): Update comment.
7841         * gdbthread.h (class thread_info): Update comment.
7842
7843 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7844             Tom Tromey  <tom@tromey.com>
7845
7846         * stabsread.h (struct stab_section_list): Remove.
7847         (coffstab_build_psymtabs): Update.
7848         * dbxread.c (symbuf_sections): Now a std::vector.
7849         (sect_idx): New global.
7850         (fill_symbuf): Update.
7851         (coffstab_build_psymtabs): Change type of stabsects parameter.
7852         Update.
7853         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7854         std::vector.
7855         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7856         (coff_locate_sections): Update.
7857         (coff_symfile_read): Remove cleanups.  Update.
7858         (init_stringtab): Add storage parameter.
7859         (free_stringtab, free_stringtab_cleanup): Remove.
7860         (init_lineno): Add storage parameter.
7861         (free_linetab, free_linetab_cleanup): Remove.
7862
7863 2019-03-06  Pedro Alves  <palves@redhat.com>
7864
7865         * linux-fork.c (fork_info::clobber_regs): Delete.
7866         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7867         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7868         comment.  Adjust.
7869         (scoped_switch_fork_info::scoped_switch_fork_info)
7870         (checkpoint_command, linux_fork_context): Adjust
7871         fork_save_infrun_state calls.
7872
7873 2019-03-06  Pedro Alves  <palves@redhat.com>
7874
7875         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7876         (inf_has_multiple_threads): Return 'bool' and rewrite using
7877         inferior_info::threads().
7878
7879 2019-03-06  Pedro Alves  <palves@redhat.com>
7880
7881         * linux-fork.c: Include <list>.
7882         (fork_list): Now a std::list instance.
7883         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7884         (forks_exist_p, find_last_fork): Adjust.
7885         (new_fork): Delete.
7886         (one_fork_p): New.
7887         (add_fork): Adjust.
7888         (free_fork): Delete, folded into fork_info::~fork_info().
7889         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7890         Adjust.
7891         (init_fork_list): Delete.
7892         (linux_fork_killall, linux_fork_mourn_inferior)
7893         (linux_fork_detach, info_checkpoints_command): Adjust.
7894         (_initialize_linux_fork): No longer call init_fork_list.
7895
7896 2019-03-06  Pedro Alves  <palves@redhat.com>
7897
7898         * linux-fork.c (new_fork): New, split out of ...
7899         (add_fork): ... this.  Return void.  Move "first fork" special
7900         case from here, to ...
7901         (checkpoint_command): ... here.
7902         * linux-linux.h (add_fork): Return void.
7903
7904 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7905
7906         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7907
7908 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7909             Chris January  <chris.january@arm.com>
7910             David Lecomber  <david.lecomber@arm.com>
7911
7912         * f-exp.y: New token, UNOP_INTRINSIC.
7913         (exp): New pattern using UNOP_INTRINSIC token.
7914         (f77_keywords): Add 'abs' keyword.
7915         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7916         (value_from_host_double): New function.
7917         (evaluate_subexp_f): Support UNOP_ABS.
7918
7919 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7920
7921         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7922         types.
7923
7924 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7925
7926         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7927         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7928         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7929
7930 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7931
7932         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7933
7934 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7935             Chris January  <chris.january@arm.com>
7936
7937         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7938         * f-exp.y: Define 'KIND' token.
7939         (exp): New pattern for KIND expressions.
7940         (ptype): Handle types with a kind extension.
7941         (direct_abs_decl): Extend to spot kind extensions.
7942         (f77_keywords): Add 'kind' to the list.
7943         (push_kind_type): New function.
7944         (convert_to_kind_type): New function.
7945         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7946         * parse.c (operator_length_standard): Likewise.
7947         * parser-defs.h (enum type_pieces): Add tp_kind.
7948         * std-operator.def: Add UNOP_KIND.
7949
7950 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7951
7952         * f-exp.y (f_parse): Set yydebug.
7953
7954 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7955
7956         * f-lang.c (evaluate_subexp_f): New function.
7957         (exp_descriptor_f): New global.
7958         (f_language_defn): Use exp_descriptor_f instead of
7959         exp_descriptor_standard.
7960
7961 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7962
7963         * f-exp.y (struct token): Add comments.
7964         (dot_ops): Remove uppercase versions and the end marker.
7965         (f77_keywords): Likewise.
7966         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7967         entries in the dot_ops array are case insensitive, and use
7968         strncasecmp to compare strings.  Also some whitespace cleanup in
7969         this area.  Similar for the f77_keywords array, except entries in
7970         this list might be case sensitive.
7971
7972 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7973
7974         * f-exp.y (struct f77_boolean_val): Add comments.
7975         (boolean_values): Remove uppercase versions, and end marker.
7976         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7977         and use strncasecmp to achieve case insensitivity.  Additionally,
7978         perform whitespace cleanup around this code.
7979
7980 2019-03-06  Tom Tromey  <tromey@adacore.com>
7981
7982         * remote-sim.c (gdbsim_target_open): Use result of
7983         gdb_argv::release.
7984
7985 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7986         Dirk Schubert  <dirk.schubert@arm.com>
7987         Chris January  <chris.january@arm.com>
7988
7989         * eval.c (evaluate_subexp_standard): Call Fortran argument
7990         wrapping logic.
7991         * f-lang.c (struct value): A value which can be passed into a
7992         Fortran function call.
7993         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7994         where appropriate.
7995         (struct type): Value ready for a Fortran function call.
7996         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7997         is needed.
7998         * f-lang.h (fortran_argument_convert): Declaration.
7999         (fortran_preserve_arg_pointer): Declaration.
8000         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8001
8002 2019-03-05  Tom Tromey  <tromey@adacore.com>
8003
8004         * python/py-prettyprint.c (print_string_repr): Remove #if.
8005         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8006
8007 2019-03-05  Tom Tromey  <tromey@adacore.com>
8008
8009         * target.c (the_dummy_target): Move later.  Change type to
8010         "dummy_target".
8011         (initialize_targets): Don't initialize the_dummy_target.
8012
8013 2019-03-05  Tom Tromey  <tromey@adacore.com>
8014
8015         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8016         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8017
8018 2019-03-05  Tom Tromey  <tromey@adacore.com>
8019
8020         * windows-nat.c (windows_nat_target::attach)
8021         (windows_nat_target::detach): Don't call gdb_flush.
8022         * valprint.c (generic_val_print, val_print, val_print_string):
8023         Don't call gdb_flush.
8024         * utils.c (defaulted_query): Don't call gdb_flush.
8025         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8026         * target.c (target_announce_detach): Don't call gdb_flush.
8027         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8028         * remote.c (extended_remote_target::attach): Don't call
8029         gdb_flush.
8030         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8031         * printcmd.c (do_examine): Don't call gdb_flush.
8032         (info_display_command): Don't call gdb_flush.
8033         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8034         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8035         * memattr.c (info_mem_command): Don't call gdb_flush.
8036         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8037         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8038         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8039         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8040         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8041         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8042         (gnu_nat_target::detach): Don't call gdb_flush.
8043         * f-valprint.c (f_val_print): Don't call gdb_flush.
8044         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8045         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8046         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8047         gdb_flush.
8048         * c-valprint.c (c_val_print): Don't call gdb_flush.
8049         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8050
8051 2019-03-05  Tom Tromey  <tromey@adacore.com>
8052
8053         * varobj.c (update_dynamic_varobj_children): Update.
8054         (install_default_visualizer): Use reset, not release.
8055         * value.c (set_internalvar): Update.
8056         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8057         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8058         ATTRIBUTE_UNUSED_RESULT.
8059
8060 2019-03-05  Tom Tromey  <tromey@adacore.com>
8061
8062         * remote.c (class scoped_remote_fd) <release>: Add
8063         ATTRIBUTE_UNUSED_RESULT.
8064
8065 2019-03-05  Tom Tromey  <tromey@adacore.com>
8066
8067         * macroexp.c (struct macro_buffer) <release>: Add
8068         ATTRIBUTE_UNUSED_RESULT.
8069
8070 2019-03-05  Tom Tromey  <tromey@adacore.com>
8071
8072         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8073         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8074         ATTRIBUTE_UNUSED_RESULT.
8075
8076 2019-03-05  Tom Tromey  <tromey@adacore.com>
8077
8078         * common/scoped_fd.h (class scoped_fd) <release>: Add
8079         ATTRIBUTE_UNUSED_RESULT.
8080
8081 2019-03-05  Tom Tromey  <tromey@adacore.com>
8082
8083         * parser-defs.h (struct parser_state) <release>: Add
8084         ATTRIBUTE_UNUSED_RESULT.
8085
8086 2019-03-05  Tom Tromey  <tromey@adacore.com>
8087
8088         * utils.h (class gdb_argv) <release>: Add
8089         ATTRIBUTE_UNUSED_RESULT.
8090         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8091
8092 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8093
8094         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8095         for-loop range, to avoid compiler warnings.
8096
8097         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8098         avoid compiler warnings about unused variables.
8099
8100         * NEWS: Mention end of support for native debugging on MS-Windows
8101         before XP.
8102
8103         PR gdb/24292
8104         * common/netstuff.c:
8105         * gdbserver/gdbreplay.c
8106         * gdbserver/remote-utils.c:
8107         * ser-tcp.c:
8108         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8109         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8110         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8111         'getaddrinfo' and 'freeaddrinfo' were not available before
8112         Windows XP, and mingw.org's MinGW headers by default define
8113         _WIN32_WINNT to 0x500.
8114
8115 2019-03-01  Gary Benson <gbenson@redhat.com>
8116
8117         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8118
8119 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8120             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8121
8122         PR gdb/8527
8123         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8124         set_sigint_trap, clear_sigint_trap.
8125
8126 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8127
8128         * target.c (target_detach): Clear the regcache and the
8129         frame cache.
8130
8131 2019-02-27  Pedro Alves  <palves@redhat.com>
8132
8133         * utils.c (set_screen_size): When we cap the height/width sizes,
8134         tweak the corresponding command variable to show "unlimited":
8135
8136 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8137             Pedro Alves  <palves@redhat.com>
8138
8139         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8140         before calling rl_set_screen_size.
8141
8142 2019-02-27  Tom Tromey  <tromey@adacore.com>
8143
8144         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8145         define.
8146         * python/py-value.c: Remove Python 2.4 workaround.
8147         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8148         workaround.
8149         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8150         Python 2.4 workaround.
8151         * python/python-internal.h: Remove Python 2.4 comment.
8152         (Py_ssize_t): Don't define.
8153         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8154         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8155         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8156         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8157         * python/python.c (do_start_initialization): Remove Python 2.4
8158         workaround.
8159         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8160         (print_children): Remove Python 2.4 workaround.
8161         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8162         workaround.
8163         (CHARBUFFERPROC_NAME): Remove.
8164         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8165         Python 2.4 workaround.
8166
8167 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8168
8169         * NEWS: Note minimum Python version.
8170
8171 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8172
8173         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8174         code from these functions.  Remove corresponding ifdefs.  Use
8175         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8176         Remove gotos and target of gotos.
8177         (infpy_search_memory): Likewise.
8178
8179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8180
8181         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8182         (hppa_gdbarch_init): Don't register deleted functions with
8183         gdbarch.
8184
8185 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8186
8187         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8188         (h8300_unwind_sp): Delete.
8189         (h8300_dummy_id): Delete.
8190         (h8300_gdbarch_init): Don't register deleted functions with
8191         gdbarch.
8192
8193 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8194
8195         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8196         (ft32_unwind_pc): Delete.
8197         (ft32_unwind_sp): Delete.
8198         (ft32_gdbarch_init): Don't register deleted functions with
8199         gdbarch.
8200
8201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8202
8203         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8204         (frv_unwind_pc): Delete.
8205         (frv_unwind_sp): Delete.
8206         (frv_gdbarch_init): Don't register deleted functions with
8207         gdbarch.
8208
8209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8210
8211         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8212         (riscv_unwind_pc): Delete.
8213         (riscv_unwind_sp): Delete.
8214         (riscv_gdbarch_init): Don't register deleted functions with
8215         gdbarch.
8216
8217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8218
8219         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8220         (csky_unwind_pc): Delete.
8221         (csky_unwind_sp): Delete.
8222         (csky_gdbarch_init): Don't register deleted functions with
8223         gdbarch.
8224
8225 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8226
8227         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8228         (cris_unwind_pc): Delete.
8229         (cris_unwind_sp): Delete.
8230         (cris_gdbarch_init): Don't register deleted functions with
8231         gdbarch.
8232
8233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8234
8235         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8236         (bfin_unwind_pc): Delete.
8237         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8238
8239 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8240
8241         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8242         (arm_unwind_pc): Delete.
8243         (arm_unwind_sp): Delete.
8244         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8245
8246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8247
8248         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8249         (arc_unwind_pc): Delete.
8250         (arc_unwind_sp): Delete.
8251         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8252
8253 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8254
8255         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8256         (alpha_unwind_pc): Delete.
8257         (alpha_gdbarch_init): Don't register deleted functions with
8258         gdbarch.
8259
8260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8261
8262         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8263         (aarch64_unwind_pc): Delete.
8264         (aarch64_unwind_sp): Delete.
8265         (aarch64_gdbarch_init): Don't register deleted functions with
8266         gdbarch.
8267
8268 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8269
8270         * gdbtypes.c (type_align): Don't consider static members when
8271         computing structure alignment.
8272
8273 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8274
8275         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8276         return 0 for other types.
8277         * arch-utils.c (default_type_align): Always return 0.
8278         * gdbarch.h: Regenerate.
8279         * gdbarch.sh (type_align): Extend comment.
8280         * gdbtypes.c (type_align): Add additional comments, always call
8281         gdbarch_type_align before applying the default rules.
8282         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8283         generic code will then apply a suitable default.
8284         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8285         types, return 0 for other types.
8286
8287 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8288
8289         * NEWS: Create a new section for the next release branch.
8290         Rename the section of the current branch, now that it has
8291         been cut.
8292
8293 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8294
8295         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8296         * version.in: Bump version to 8.3.50.DATE-git.
8297
8298 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8299
8300         * aix-thread.c (ptid_cmp): Remove unused variable.
8301         (get_signaled_thread): Likewise.
8302         (store_regs_user_thread): Likewise.
8303         (store_regs_kernel_thread): Likewise.
8304         (fetch_regs_kernel_thread): Remove shadowed variable.
8305
8306 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8307
8308         * features/riscv/32bit-cpu.xml: Add register numbers.
8309         * features/riscv/32bit-fpu.c: Regenerate.
8310         * features/riscv/32bit-fpu.xml: Add register numbers.
8311         * features/riscv/64bit-cpu.xml: Add register numbers.
8312         * features/riscv/64bit-fpu.c: Regenerate.
8313         * features/riscv/64bit-fpu.xml: Add register numbers.
8314
8315 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8316
8317         * NEWS: Mention two argument form of gdb.Value constructor.
8318         * python/py-value.c (convert_buffer_and_type_to_value): New
8319         function.
8320         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8321         Add support for handling an optional second argument.  Call
8322         convert_buffer_and_type_to_value as appropriate.
8323         * python/python-internal.h (Py_buffer_deleter): New struct.
8324         (Py_buffer_up): New typedef.
8325
8326 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8327
8328         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8329         instead of releasing ownership.
8330
8331 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8332
8333         * dwarf2read.c (open_and_init_dwp_file): Call
8334         elf_numsections instead of bfd_count_sections to initialize
8335         dwp_file->num_sections.
8336
8337 2019-02-25  Tom Tromey  <tromey@adacore.com>
8338
8339         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8340
8341 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8342
8343         * gcore.in: Add '--readnever' option when invoking GDB.
8344
8345 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8346
8347         * MAINTAINERS: Update my email address.
8348
8349 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8350
8351         * build-id.c (build_id_to_debug_bfd_1): New function.
8352         (build_id_to_debug_bfd): Look for separate debug file in
8353         sysroot.
8354
8355 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8356
8357         * gdbarch.sh: Update the copyright year range that is placed into
8358         generated files.
8359
8360 2019-02-22  Keith Seitz  <keiths@redhat.com>
8361
8362         PR symtab/23853
8363         * linespec.c (create_sals_line_offset): Search for the default
8364         symtab's filename instead of its fullname.
8365
8366 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8367
8368         * NEWS: Update style defaults.
8369
8370 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8371
8372         * main.c (captured_main_1): Disable styling in batch mode.
8373
8374 2019-02-20  Tom Tromey  <tom@tromey.com>
8375
8376         * symtab.c (symtab_symbol_info): Fix typos.
8377
8378 2019-02-20  Tom Tromey  <tromey@adacore.com>
8379
8380         * findcmd.c (_initialize_mem_search): Use upper case for
8381         metasyntactic variables.
8382
8383 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8384
8385         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8386         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8387
8388 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8389
8390         * top.h (source_file_name): Change to std::string.
8391         * top.c (source_file_name): Likewise.
8392         (command_line_input): Adjust.
8393         * cli/cli-script.c (script_from_file): Adjust.
8394
8395 2019-02-19  Tom Tromey  <tromey@adacore.com>
8396
8397         * ravenscar-thread.c
8398         (ravenscar_thread_target::update_thread_list): Don't call
8399         ada_build_task_list.
8400         * ada-lang.h (ada_build_task_list): Don't declare.
8401         * ada-tasks.c (struct ada_tasks_inferior_data)
8402         <task_list_valid_p>: Now bool.
8403         (read_known_tasks, ada_task_list_changed)
8404         (ada_tasks_invalidate_inferior_data): Update.
8405         (read_known_tasks_array): Return bool.
8406         (read_known_tasks_list): Likewise.
8407         (read_known_tasks): Return void.
8408         (ada_build_task_list): Now static.
8409
8410 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8411
8412         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8413         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8414
8415 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8416
8417         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8418         variant for ada_tasks_pspace_data_handle and
8419         ada_tasks_inferior_data_handle.
8420         (ada_tasks_pspace_data_cleanup): New function.
8421         (ada_tasks_inferior_data_cleanup): New function.
8422
8423 2019-02-17  Tom Tromey  <tom@tromey.com>
8424
8425         * macrotab.h (macro_source_fullname): Return a std::string.
8426         * macrotab.c (macro_include, check_for_redefinition)
8427         (macro_undef, macro_lookup_definition, foreach_macro)
8428         (foreach_macro_in_scope): Update.
8429         (macro_source_fullname): Return a std::string.
8430         * macrocmd.c (show_pp_source_pos): Update.
8431
8432 2019-02-17  Tom Tromey  <tom@tromey.com>
8433
8434         * macrocmd.c (show_pp_source_pos): Style the file names.
8435
8436 2019-02-17  Tom Tromey  <tom@tromey.com>
8437
8438         PR tui/24197:
8439         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8440
8441 2019-02-17  Tom Tromey  <tom@tromey.com>
8442
8443         * ada-lang.c (user_select_syms): Use filtered printing.
8444         * utils.c (wrap_style): New global.
8445         (desired_style): Remove.
8446         (emit_style_escape): Add stream parameter.
8447         (set_output_style, reset_terminal_style, prompt_for_continue):
8448         Update.
8449         (flush_wrap_buffer): Only flush gdb_stdout.
8450         (wrap_here): Set wrap_style.
8451         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8452         treat escape sequences as a character.  Change when wrap buffer is
8453         flushed.
8454         (fputs_styled): Do not set the output style when the default is
8455         requested.
8456         * ui-style.h (struct ui_file_style) <is_default>: New method.
8457         * source.c (print_source_lines_base): Emit escape sequences in one
8458         piece.
8459
8460 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8461
8462         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8463         integers and enumeration types.
8464
8465 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8466
8467         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8468         instead of lookup_symbol_in_language
8469         (do_exact_match): New function.
8470         (ada_get_symbol_name_matcher): Return do_exact_match when
8471         doing a verbatim match.
8472
8473 2019-02-15  Tom Tromey  <tromey@adacore.com>
8474
8475         * ravenscar-thread.c (ravenscar_thread_target::resume)
8476         (ravenscar_thread_target::wait): Special case wildcard requests.
8477
8478 2019-02-15  Tom Tromey  <tromey@adacore.com>
8479
8480         * ravenscar-thread.c (base_ptid): Remove.
8481         (struct ravenscar_thread_target) <close>: New method.
8482         <m_base_ptid>: New member.
8483         <update_inferior_ptid, active_task, task_is_currently_active,
8484         runtime_initialized>: Declare methods.
8485         <ravenscar_thread_target>: Add constructor.
8486         (ravenscar_thread_target::task_is_currently_active)
8487         (ravenscar_thread_target::update_inferior_ptid)
8488         (ravenscar_runtime_initialized): Rename.  Now methods.
8489         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8490         (ravenscar_thread_target::update_thread_list): Update.
8491         (ravenscar_thread_target::active_task): Now method.
8492         (ravenscar_thread_target::store_registers)
8493         (ravenscar_thread_target::prepare_to_store)
8494         (ravenscar_thread_target::prepare_to_store)
8495         (ravenscar_thread_target::mourn_inferior): Update.
8496         (ravenscar_inferior_created): Use "new" to create target.
8497         (ravenscar_thread_target::get_ada_task_ptid): Update.
8498         (_initialize_ravenscar): Don't initialize base_ptid.
8499         (ravenscar_ops): Remove global.
8500
8501 2019-02-15  Tom Tromey  <tromey@adacore.com>
8502
8503         * target.h (push_target): Declare new overload.
8504         * target.c (push_target): New overload, taking an rvalue reference.
8505         * remote.c (remote_target::open_1): Use push_target overload.
8506         * corelow.c (core_target_open): Use push_target overload.
8507
8508 2019-02-15  Tom Tromey  <tromey@adacore.com>
8509
8510         * ravenscar-thread.c (is_ravenscar_task)
8511         (ravenscar_task_is_currently_active): Return bool.
8512         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8513         (_initialize_ravenscar): Remove "(void)".
8514         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8515         Return bool.
8516
8517 2019-02-15  Tom Tromey  <tromey@adacore.com>
8518
8519         * ravenscar-thread.c (ravenscar_runtime_initializer)
8520         (has_ravenscar_runtime, get_running_thread_id)
8521         (ravenscar_thread_target::resume): Fix indentation.
8522
8523 2019-02-15  Tom Tromey  <tromey@adacore.com>
8524
8525         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8526         from ravenscar_arch_ops.
8527         (sparc_ravenscar_ops::fetch_registers)
8528         (sparc_ravenscar_ops::store_registers): Now methods.
8529         (sparc_ravenscar_prepare_to_store): Remove.
8530         (sparc_ravenscar_ops): Redefine.
8531         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8532         methods and destructor.  Remove members.
8533         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8534         (ravenscar_thread_target::store_registers)
8535         (ravenscar_thread_target::prepare_to_store): Update.
8536         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8537         Remove.
8538         (struct ppc_ravenscar_powerpc_ops): Derive from
8539         ravenscar_arch_ops.
8540         (ppc_ravenscar_powerpc_ops::fetch_registers)
8541         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8542         (ppc_ravenscar_powerpc_ops): Redefine.
8543         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8544         (ppc_ravenscar_e500_ops::fetch_registers)
8545         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8546         (ppc_ravenscar_e500_ops): Redefine.
8547         * aarch64-ravenscar-thread.c
8548         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8549         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8550         (aarch64_ravenscar_fetch_registers)
8551         (aarch64_ravenscar_store_registers): Now methods.
8552         (aarch64_ravenscar_ops): Redefine.
8553
8554 2019-02-15  Tom Tromey  <tromey@adacore.com>
8555
8556         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8557         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8558         (ravenscar_thread_target::stopped_by_watchpoint)
8559         (ravenscar_thread_target::stopped_data_address)
8560         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8561
8562 2019-02-15  Tom Tromey  <tromey@adacore.com>
8563
8564         * ravenscar-thread.c: Fix some typos.
8565
8566 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8567             Tom Tromey  <tromey@adacore.com>
8568
8569         * ada-lang.c (ada_exception_sal): Change addr_string to a
8570         std::string.
8571         (create_ada_exception_catchpoint): Update.
8572
8573 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8574             Tom Tromey  <tromey@adacore.com>
8575
8576         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8577         (bp_location_ops): Remove.
8578         (base_breakpoint_allocate_location): Update.
8579         (free_bp_location): Update.
8580         * ada-lang.c (class ada_catchpoint_location)
8581         <ada_catchpoint_location>: Remove ops parameter.
8582         (ada_catchpoint_location_dtor): Remove.
8583         (ada_catchpoint_location_ops): Remove.
8584         (allocate_location_exception): Update.
8585         * breakpoint.h (struct bp_location_ops): Remove.
8586         (class bp_location) <bp_location>: Remove bp_location_ops
8587         parameter.
8588         <~bp_location>: Add destructor.
8589         <ops>: Remove.
8590
8591 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8592             Pedro Alves  <palves@redhat.com>
8593
8594         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8595         'PATH_MAX'.
8596
8597 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8598             Samuel Thibault  <samuel.thibault@gnu.org>
8599             Thomas Schwinge  <thomas@codesourcery.com>
8600
8601         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8602         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8603
8604 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8605
8606         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8607         (check_empty): Use "const char *".
8608
8609         * gnu-nat.c (gnu_nat_target::detach): Instead of
8610         'detach_inferior (pid)' call
8611         'detach_inferior (find_inferior_pid (pid))'.
8612
8613         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8614         'nat/fork-inferior.o'.
8615         * gnu-nat.c: #include "nat/fork-inferior.h".
8616
8617         * gnu-nat.c (gnu_nat_target::detach): Instead of
8618         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8619         * gnu-nat.h: #include "inf-child.h".
8620         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8621         'i386_gnu_nat_target::fetch_registers'.
8622         (gnu_store_registers): Rename/move to
8623         'i386_gnu_nat_target::store_registers'.
8624
8625         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8626         * gnu-nat.h (mach_thread_info): New function.
8627         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8628
8629         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8630
8631 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8632
8633         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8634
8635 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8636
8637         * windows-nat.c (windows_add_thread): Add new parameter
8638         "main_thread_p" with default value set to false.  Update
8639         function documentation as well as all callers.
8640         (windows_delete_thread): Likewise.
8641         (fake_create_process): Update call to windows_add_thread.
8642         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8643         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8644         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8645         call to windows_delete_thread.
8646
8647 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8648
8649         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8650
8651 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8652
8653         * symfile.c (find_separate_debug_file): Use canonical path of
8654         sysroot with child_path instead of gdb_sysroot if it is valid.
8655
8656 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8657
8658         * symfile.c (find_separate_debug_file): Use child_path to
8659         determine if an object file is under a sysroot.
8660
8661 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8662
8663         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8664         unittests/child-path-selftests.c.
8665         * common/pathstuff.c (child_path): New function.
8666         * common/pathstuff.h (child_path): New prototype.
8667         * unittests/child-path-selftests.c: New file.
8668
8669 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8670
8671         * symfile.c (find_separate_debug_file): Look for separate debug
8672         files in debug directories under the sysroot.
8673
8674 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8675
8676         * symtab.h (struct minimal_symbol data_p): New const method.
8677         (struct minimal_symbol text_p): Likewise.
8678         * symtab.c (output_source_filename): Use file name style
8679         to print file name.
8680         (print_symbol_info): Likewise.
8681         (print_msymbol_info): Use address style to print addresses.
8682         Use function name style to print executable text symbols.
8683         (expand_symtab_containing_pc): Use data_p.
8684         (find_pc_sect_compunit_symtab): Likewise.
8685
8686 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8687
8688         * breakpoint.c (describe_other_breakpoints): Use address style
8689         to print addresses.
8690         (say_where): Likewise.
8691
8692 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8693
8694         * ada-typeprint.c (print_func_type): Print function name
8695         style to print function name.
8696         * c-typeprint.c (c_print_type_1): Likewise.
8697
8698 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8699
8700         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8701         for execve.
8702
8703 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8704
8705         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8706         type_stack.
8707
8708 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8709
8710         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8711         TYPE_CODE_REF types.
8712
8713 2019-02-08  Jim Wilson  <jimw@sifive.com>
8714
8715         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8716         (riscv_linux_fregset): New.
8717         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8718
8719 2019-02-07  Tom Tromey  <tom@tromey.com>
8720
8721         * thread.c (thread_cancel_execution_command): Update.
8722         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8723         methods.
8724         (struct thread_fsm_ops): Remove.
8725         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8726         (thread_fsm_should_stop, thread_fsm_return_value)
8727         (thread_fsm_set_finished, thread_fsm_finished_p)
8728         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8729         Don't declare.
8730         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8731         * infrun.c (clear_proceed_status_thread)
8732         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8733         (print_stop_event): Update.
8734         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8735         Add constructor.
8736         (step_command_fsm_ops): Remove.
8737         (new_step_command_fsm): Remove.
8738         (step_1): Update.
8739         (step_command_fsm::should_stop): Rename from
8740         step_command_fsm_should_stop.
8741         (step_command_fsm::clean_up): Rename from
8742         step_command_fsm_clean_up.
8743         (step_command_fsm::do_async_reply_reason): Rename from
8744         step_command_fsm_async_reply_reason.
8745         (struct until_next_fsm): Inherit from thread_fsm.  Add
8746         constructor.
8747         (until_next_fsm_ops): Remove.
8748         (new_until_next_fsm): Remove.
8749         (until_next_fsm::should_stop): Rename from
8750         until_next_fsm_should_stop.
8751         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8752         (until_next_fsm::do_async_reply_reason): Rename from
8753         until_next_fsm_async_reply_reason.
8754         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8755         constructor.  Change type of breakpoint.
8756         (finish_command_fsm_ops): Remove.
8757         (new_finish_command_fsm): Remove.
8758         (finish_command_fsm::should_stop): Rename from
8759         finish_command_fsm_should_stop.
8760         (finish_command_fsm::clean_up): Rename from
8761         finish_command_fsm_clean_up.
8762         (finish_command_fsm::return_value): Rename from
8763         finish_command_fsm_return_value.
8764         (finish_command_fsm::do_async_reply_reason): Rename from
8765         finish_command_fsm_async_reply_reason.
8766         (finish_command): Update.
8767         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8768         Add constructor.
8769         (call_thread_fsm_ops): Remove.
8770         (call_thread_fsm::call_thread_fsm): Rename from
8771         new_call_thread_fsm.
8772         (call_thread_fsm::should_stop): Rename from
8773         call_thread_fsm_should_stop.
8774         (call_thread_fsm::should_notify_stop): Rename from
8775         call_thread_fsm_should_notify_stop.
8776         (run_inferior_call, call_function_by_hand_dummy): Update.
8777         * cli/cli-interp.c (should_print_stop_to_console): Update.
8778         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8779         Add constructor.  Change type of location_breakpoint,
8780         caller_breakpoint.
8781         (until_break_fsm_ops): Remove.
8782         (new_until_break_fsm): Remove.
8783         (until_break_fsm::should_stop): Rename from
8784         until_break_fsm_should_stop.
8785         (until_break_fsm::clean_up): Rename from
8786         until_break_fsm_clean_up.
8787         (until_break_fsm::do_async_reply_reason): Rename from
8788         until_break_fsm_async_reply_reason.
8789         (until_break_command): Update.
8790         * thread-fsm.c: Remove.
8791         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8792
8793 2019-02-07  Tom Tromey  <tom@tromey.com>
8794
8795         * yy-remap.h: Add include guard.
8796         * xtensa-tdep.h: Add include guard.
8797         * xcoffread.h: Rename include guard.
8798         * varobj-iter.h: Add include guard.
8799         * tui/tui.h: Rename include guard.
8800         * tui/tui-winsource.h: Rename include guard.
8801         * tui/tui-wingeneral.h: Rename include guard.
8802         * tui/tui-windata.h: Rename include guard.
8803         * tui/tui-win.h: Rename include guard.
8804         * tui/tui-stack.h: Rename include guard.
8805         * tui/tui-source.h: Rename include guard.
8806         * tui/tui-regs.h: Rename include guard.
8807         * tui/tui-out.h: Rename include guard.
8808         * tui/tui-layout.h: Rename include guard.
8809         * tui/tui-io.h: Rename include guard.
8810         * tui/tui-hooks.h: Rename include guard.
8811         * tui/tui-file.h: Rename include guard.
8812         * tui/tui-disasm.h: Rename include guard.
8813         * tui/tui-data.h: Rename include guard.
8814         * tui/tui-command.h: Rename include guard.
8815         * tic6x-tdep.h: Add include guard.
8816         * target/waitstatus.h: Rename include guard.
8817         * target/wait.h: Rename include guard.
8818         * target/target.h: Rename include guard.
8819         * target/resume.h: Rename include guard.
8820         * target-float.h: Rename include guard.
8821         * stabsread.h: Add include guard.
8822         * rs6000-tdep.h: Add include guard.
8823         * riscv-fbsd-tdep.h: Add include guard.
8824         * regformats/regdef.h: Rename include guard.
8825         * record.h: Rename include guard.
8826         * python/python.h: Rename include guard.
8827         * python/python-internal.h: Rename include guard.
8828         * python/py-stopevent.h: Rename include guard.
8829         * python/py-ref.h: Rename include guard.
8830         * python/py-record.h: Rename include guard.
8831         * python/py-record-full.h: Rename include guard.
8832         * python/py-record-btrace.h: Rename include guard.
8833         * python/py-instruction.h: Rename include guard.
8834         * python/py-events.h: Rename include guard.
8835         * python/py-event.h: Rename include guard.
8836         * procfs.h: Add include guard.
8837         * proc-utils.h: Add include guard.
8838         * p-lang.h: Add include guard.
8839         * or1k-tdep.h: Rename include guard.
8840         * observable.h: Rename include guard.
8841         * nto-tdep.h: Rename include guard.
8842         * nat/x86-linux.h: Rename include guard.
8843         * nat/x86-linux-dregs.h: Rename include guard.
8844         * nat/x86-gcc-cpuid.h: Add include guard.
8845         * nat/x86-dregs.h: Rename include guard.
8846         * nat/x86-cpuid.h: Rename include guard.
8847         * nat/ppc-linux.h: Rename include guard.
8848         * nat/mips-linux-watch.h: Rename include guard.
8849         * nat/linux-waitpid.h: Rename include guard.
8850         * nat/linux-ptrace.h: Rename include guard.
8851         * nat/linux-procfs.h: Rename include guard.
8852         * nat/linux-osdata.h: Rename include guard.
8853         * nat/linux-nat.h: Rename include guard.
8854         * nat/linux-namespaces.h: Rename include guard.
8855         * nat/linux-btrace.h: Rename include guard.
8856         * nat/glibc_thread_db.h: Rename include guard.
8857         * nat/gdb_thread_db.h: Rename include guard.
8858         * nat/gdb_ptrace.h: Rename include guard.
8859         * nat/fork-inferior.h: Rename include guard.
8860         * nat/amd64-linux-siginfo.h: Rename include guard.
8861         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8862         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8863         * nat/aarch64-linux.h: Rename include guard.
8864         * nat/aarch64-linux-hw-point.h: Rename include guard.
8865         * mn10300-tdep.h: Add include guard.
8866         * mips-linux-tdep.h: Add include guard.
8867         * mi/mi-parse.h: Rename include guard.
8868         * mi/mi-out.h: Rename include guard.
8869         * mi/mi-main.h: Rename include guard.
8870         * mi/mi-interp.h: Rename include guard.
8871         * mi/mi-getopt.h: Rename include guard.
8872         * mi/mi-console.h: Rename include guard.
8873         * mi/mi-common.h: Rename include guard.
8874         * mi/mi-cmds.h: Rename include guard.
8875         * mi/mi-cmd-break.h: Rename include guard.
8876         * m2-lang.h: Add include guard.
8877         * location.h: Rename include guard.
8878         * linux-record.h: Rename include guard.
8879         * linux-nat.h: Add include guard.
8880         * linux-fork.h: Add include guard.
8881         * i386-darwin-tdep.h: Rename include guard.
8882         * hppa-linux-offsets.h: Add include guard.
8883         * guile/guile.h: Rename include guard.
8884         * guile/guile-internal.h: Rename include guard.
8885         * gnu-nat.h: Rename include guard.
8886         * gdb-stabs.h: Rename include guard.
8887         * frv-tdep.h: Add include guard.
8888         * f-lang.h: Add include guard.
8889         * event-loop.h: Add include guard.
8890         * darwin-nat.h: Rename include guard.
8891         * cp-abi.h: Rename include guard.
8892         * config/sparc/nm-sol2.h: Rename include guard.
8893         * config/nm-nto.h: Rename include guard.
8894         * config/nm-linux.h: Add include guard.
8895         * config/i386/nm-i386gnu.h: Rename include guard.
8896         * config/djgpp/nl_types.h: Rename include guard.
8897         * config/djgpp/langinfo.h: Rename include guard.
8898         * compile/gcc-cp-plugin.h: Add include guard.
8899         * compile/gcc-c-plugin.h: Add include guard.
8900         * compile/compile.h: Rename include guard.
8901         * compile/compile-object-run.h: Rename include guard.
8902         * compile/compile-object-load.h: Rename include guard.
8903         * compile/compile-internal.h: Rename include guard.
8904         * compile/compile-cplus.h: Rename include guard.
8905         * compile/compile-c.h: Rename include guard.
8906         * common/xml-utils.h: Rename include guard.
8907         * common/x86-xstate.h: Rename include guard.
8908         * common/version.h: Rename include guard.
8909         * common/vec.h: Rename include guard.
8910         * common/tdesc.h: Rename include guard.
8911         * common/selftest.h: Rename include guard.
8912         * common/scoped_restore.h: Rename include guard.
8913         * common/scoped_mmap.h: Rename include guard.
8914         * common/scoped_fd.h: Rename include guard.
8915         * common/safe-iterator.h: Rename include guard.
8916         * common/run-time-clock.h: Rename include guard.
8917         * common/refcounted-object.h: Rename include guard.
8918         * common/queue.h: Rename include guard.
8919         * common/ptid.h: Rename include guard.
8920         * common/print-utils.h: Rename include guard.
8921         * common/preprocessor.h: Rename include guard.
8922         * common/pathstuff.h: Rename include guard.
8923         * common/observable.h: Rename include guard.
8924         * common/netstuff.h: Rename include guard.
8925         * common/job-control.h: Rename include guard.
8926         * common/host-defs.h: Rename include guard.
8927         * common/gdb_wait.h: Rename include guard.
8928         * common/gdb_vecs.h: Rename include guard.
8929         * common/gdb_unlinker.h: Rename include guard.
8930         * common/gdb_unique_ptr.h: Rename include guard.
8931         * common/gdb_tilde_expand.h: Rename include guard.
8932         * common/gdb_sys_time.h: Rename include guard.
8933         * common/gdb_string_view.h: Rename include guard.
8934         * common/gdb_splay_tree.h: Rename include guard.
8935         * common/gdb_setjmp.h: Rename include guard.
8936         * common/gdb_ref_ptr.h: Rename include guard.
8937         * common/gdb_optional.h: Rename include guard.
8938         * common/gdb_locale.h: Rename include guard.
8939         * common/gdb_assert.h: Rename include guard.
8940         * common/filtered-iterator.h: Rename include guard.
8941         * common/filestuff.h: Rename include guard.
8942         * common/fileio.h: Rename include guard.
8943         * common/environ.h: Rename include guard.
8944         * common/common-utils.h: Rename include guard.
8945         * common/common-types.h: Rename include guard.
8946         * common/common-regcache.h: Rename include guard.
8947         * common/common-inferior.h: Rename include guard.
8948         * common/common-gdbthread.h: Rename include guard.
8949         * common/common-exceptions.h: Rename include guard.
8950         * common/common-defs.h: Rename include guard.
8951         * common/common-debug.h: Rename include guard.
8952         * common/cleanups.h: Rename include guard.
8953         * common/buffer.h: Rename include guard.
8954         * common/btrace-common.h: Rename include guard.
8955         * common/break-common.h: Rename include guard.
8956         * cli/cli-utils.h: Rename include guard.
8957         * cli/cli-style.h: Rename include guard.
8958         * cli/cli-setshow.h: Rename include guard.
8959         * cli/cli-script.h: Rename include guard.
8960         * cli/cli-interp.h: Rename include guard.
8961         * cli/cli-decode.h: Rename include guard.
8962         * cli/cli-cmds.h: Rename include guard.
8963         * charset-list.h: Add include guard.
8964         * buildsym-legacy.h: Rename include guard.
8965         * bfin-tdep.h: Add include guard.
8966         * ax.h: Rename include guard.
8967         * arm-linux-tdep.h: Add include guard.
8968         * arm-fbsd-tdep.h: Add include guard.
8969         * arch/xtensa.h: Rename include guard.
8970         * arch/tic6x.h: Add include guard.
8971         * arch/i386.h: Add include guard.
8972         * arch/arm.h: Rename include guard.
8973         * arch/arm-linux.h: Rename include guard.
8974         * arch/arm-get-next-pcs.h: Rename include guard.
8975         * arch/amd64.h: Add include guard.
8976         * arch/aarch64-insn.h: Rename include guard.
8977         * arch-utils.h: Rename include guard.
8978         * annotate.h: Add include guard.
8979         * amd64-darwin-tdep.h: Rename include guard.
8980         * aarch64-linux-tdep.h: Add include guard.
8981         * aarch64-fbsd-tdep.h: Add include guard.
8982         * aarch32-linux-nat.h: Add include guard.
8983
8984 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8985
8986         * macrotab.c (macro_define_internal): New function that
8987         factorizes macro_define_object_internal and macro_define_function
8988         code.
8989         (macro_define_object_internal): Use macro_define_internal.
8990         (macro_define_function): Likewise.
8991
8992 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8993
8994         * macrocmd.c (extract_identifier): Return
8995         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8996         callers.
8997
8998 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8999
9000         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9001
9002 2019-02-05  Tom Tromey  <tom@tromey.com>
9003
9004         * target.c (target_stack::unpush): Move assertion earlier.
9005
9006 2019-01-30  Tom Tromey  <tom@tromey.com>
9007
9008         PR python/23615:
9009         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9010         (gdbpy_parse_and_eval): Likewise.
9011         * python/python-internal.h (gdbpy_allow_threads): New class.
9012
9013 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9014
9015         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9016         (aarch64_fbsd_fpregmap): Move earlier.
9017         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9018         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9019         instead of individual calls to trad_frame_set_reg_addr.
9020         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9021         earlier.
9022         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9023         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9024         instead of individual calls to trad_frame_set_reg_addr.
9025
9026 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9027
9028         * CONTRIBUTE: Replace contribution list with wiki link.
9029
9030 2019-01-25  Tom Tromey  <tom@tromey.com>
9031
9032         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9033
9034 2019-01-25  Tom Tromey  <tom@tromey.com>
9035
9036         * xtensa-linux-nat.c: Fix common/ includes.
9037         * xml-support.h: Fix common/ includes.
9038         * xml-support.c: Fix common/ includes.
9039         * x86-linux-nat.c: Fix common/ includes.
9040         * windows-nat.c: Fix common/ includes.
9041         * varobj.h: Fix common/ includes.
9042         * varobj.c: Fix common/ includes.
9043         * value.c: Fix common/ includes.
9044         * valops.c: Fix common/ includes.
9045         * utils.c: Fix common/ includes.
9046         * unittests/xml-utils-selftests.c: Fix common/ includes.
9047         * unittests/utils-selftests.c: Fix common/ includes.
9048         * unittests/unpack-selftests.c: Fix common/ includes.
9049         * unittests/tracepoint-selftests.c: Fix common/ includes.
9050         * unittests/style-selftests.c: Fix common/ includes.
9051         * unittests/string_view-selftests.c: Fix common/ includes.
9052         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9053         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9054         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9055         * unittests/rsp-low-selftests.c: Fix common/ includes.
9056         * unittests/parse-connection-spec-selftests.c: Fix common/
9057         includes.
9058         * unittests/optional-selftests.c: Fix common/ includes.
9059         * unittests/offset-type-selftests.c: Fix common/ includes.
9060         * unittests/observable-selftests.c: Fix common/ includes.
9061         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9062         * unittests/memrange-selftests.c: Fix common/ includes.
9063         * unittests/memory-map-selftests.c: Fix common/ includes.
9064         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9065         * unittests/function-view-selftests.c: Fix common/ includes.
9066         * unittests/environ-selftests.c: Fix common/ includes.
9067         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9068         * unittests/common-utils-selftests.c: Fix common/ includes.
9069         * unittests/cli-utils-selftests.c: Fix common/ includes.
9070         * unittests/array-view-selftests.c: Fix common/ includes.
9071         * ui-file.c: Fix common/ includes.
9072         * tui/tui-io.c: Fix common/ includes.
9073         * tracepoint.h: Fix common/ includes.
9074         * tracepoint.c: Fix common/ includes.
9075         * tracefile-tfile.c: Fix common/ includes.
9076         * top.h: Fix common/ includes.
9077         * top.c: Fix common/ includes.
9078         * thread.c: Fix common/ includes.
9079         * target/waitstatus.h: Fix common/ includes.
9080         * target/waitstatus.c: Fix common/ includes.
9081         * target.h: Fix common/ includes.
9082         * target.c: Fix common/ includes.
9083         * target-memory.c: Fix common/ includes.
9084         * target-descriptions.c: Fix common/ includes.
9085         * symtab.h: Fix common/ includes.
9086         * symfile.c: Fix common/ includes.
9087         * stap-probe.c: Fix common/ includes.
9088         * spu-linux-nat.c: Fix common/ includes.
9089         * sparc-nat.c: Fix common/ includes.
9090         * source.c: Fix common/ includes.
9091         * solib.c: Fix common/ includes.
9092         * solib-target.c: Fix common/ includes.
9093         * ser-unix.c: Fix common/ includes.
9094         * ser-tcp.c: Fix common/ includes.
9095         * ser-pipe.c: Fix common/ includes.
9096         * ser-base.c: Fix common/ includes.
9097         * selftest-arch.c: Fix common/ includes.
9098         * s12z-tdep.c: Fix common/ includes.
9099         * rust-exp.y: Fix common/ includes.
9100         * rs6000-aix-tdep.c: Fix common/ includes.
9101         * riscv-tdep.c: Fix common/ includes.
9102         * remote.c: Fix common/ includes.
9103         * remote-notif.h: Fix common/ includes.
9104         * remote-fileio.h: Fix common/ includes.
9105         * remote-fileio.c: Fix common/ includes.
9106         * regcache.h: Fix common/ includes.
9107         * regcache.c: Fix common/ includes.
9108         * record-btrace.c: Fix common/ includes.
9109         * python/python.c: Fix common/ includes.
9110         * python/py-type.c: Fix common/ includes.
9111         * python/py-inferior.c: Fix common/ includes.
9112         * progspace.h: Fix common/ includes.
9113         * producer.c: Fix common/ includes.
9114         * procfs.c: Fix common/ includes.
9115         * proc-api.c: Fix common/ includes.
9116         * printcmd.c: Fix common/ includes.
9117         * ppc-linux-nat.c: Fix common/ includes.
9118         * parser-defs.h: Fix common/ includes.
9119         * osdata.c: Fix common/ includes.
9120         * obsd-nat.c: Fix common/ includes.
9121         * nat/x86-linux.c: Fix common/ includes.
9122         * nat/x86-linux-dregs.c: Fix common/ includes.
9123         * nat/x86-dregs.h: Fix common/ includes.
9124         * nat/x86-dregs.c: Fix common/ includes.
9125         * nat/ppc-linux.c: Fix common/ includes.
9126         * nat/mips-linux-watch.h: Fix common/ includes.
9127         * nat/mips-linux-watch.c: Fix common/ includes.
9128         * nat/linux-waitpid.c: Fix common/ includes.
9129         * nat/linux-ptrace.h: Fix common/ includes.
9130         * nat/linux-ptrace.c: Fix common/ includes.
9131         * nat/linux-procfs.c: Fix common/ includes.
9132         * nat/linux-personality.c: Fix common/ includes.
9133         * nat/linux-osdata.c: Fix common/ includes.
9134         * nat/linux-namespaces.c: Fix common/ includes.
9135         * nat/linux-btrace.h: Fix common/ includes.
9136         * nat/linux-btrace.c: Fix common/ includes.
9137         * nat/fork-inferior.c: Fix common/ includes.
9138         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9139         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9140         * nat/aarch64-linux.c: Fix common/ includes.
9141         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9142         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9143         * namespace.h: Fix common/ includes.
9144         * mips-linux-tdep.c: Fix common/ includes.
9145         * minsyms.c: Fix common/ includes.
9146         * mi/mi-parse.h: Fix common/ includes.
9147         * mi/mi-main.c: Fix common/ includes.
9148         * mi/mi-cmd-env.c: Fix common/ includes.
9149         * memrange.h: Fix common/ includes.
9150         * memattr.c: Fix common/ includes.
9151         * maint.h: Fix common/ includes.
9152         * maint.c: Fix common/ includes.
9153         * main.c: Fix common/ includes.
9154         * machoread.c: Fix common/ includes.
9155         * location.c: Fix common/ includes.
9156         * linux-thread-db.c: Fix common/ includes.
9157         * linux-nat.c: Fix common/ includes.
9158         * linux-fork.c: Fix common/ includes.
9159         * inline-frame.c: Fix common/ includes.
9160         * infrun.c: Fix common/ includes.
9161         * inflow.c: Fix common/ includes.
9162         * inferior.h: Fix common/ includes.
9163         * inferior.c: Fix common/ includes.
9164         * infcmd.c: Fix common/ includes.
9165         * inf-ptrace.c: Fix common/ includes.
9166         * inf-child.c: Fix common/ includes.
9167         * ia64-linux-nat.c: Fix common/ includes.
9168         * i387-tdep.c: Fix common/ includes.
9169         * i386-tdep.c: Fix common/ includes.
9170         * i386-linux-tdep.c: Fix common/ includes.
9171         * i386-linux-nat.c: Fix common/ includes.
9172         * i386-go32-tdep.c: Fix common/ includes.
9173         * i386-fbsd-tdep.c: Fix common/ includes.
9174         * i386-fbsd-nat.c: Fix common/ includes.
9175         * guile/scm-type.c: Fix common/ includes.
9176         * guile/guile.c: Fix common/ includes.
9177         * go32-nat.c: Fix common/ includes.
9178         * gnu-nat.c: Fix common/ includes.
9179         * gdbthread.h: Fix common/ includes.
9180         * gdbarch-selftests.c: Fix common/ includes.
9181         * gdb_usleep.c: Fix common/ includes.
9182         * gdb_select.h: Fix common/ includes.
9183         * gdb_bfd.c: Fix common/ includes.
9184         * gcore.c: Fix common/ includes.
9185         * fork-child.c: Fix common/ includes.
9186         * findvar.c: Fix common/ includes.
9187         * fbsd-nat.c: Fix common/ includes.
9188         * event-top.c: Fix common/ includes.
9189         * event-loop.c: Fix common/ includes.
9190         * dwarf2read.c: Fix common/ includes.
9191         * dwarf2loc.c: Fix common/ includes.
9192         * dwarf2-frame.c: Fix common/ includes.
9193         * dwarf-index-cache.c: Fix common/ includes.
9194         * dtrace-probe.c: Fix common/ includes.
9195         * disasm-selftests.c: Fix common/ includes.
9196         * defs.h: Fix common/ includes.
9197         * csky-tdep.c: Fix common/ includes.
9198         * cp-valprint.c: Fix common/ includes.
9199         * cp-support.h: Fix common/ includes.
9200         * cp-support.c: Fix common/ includes.
9201         * corelow.c: Fix common/ includes.
9202         * completer.h: Fix common/ includes.
9203         * completer.c: Fix common/ includes.
9204         * compile/compile.c: Fix common/ includes.
9205         * compile/compile-loc2c.c: Fix common/ includes.
9206         * compile/compile-cplus-types.c: Fix common/ includes.
9207         * compile/compile-cplus-symbols.c: Fix common/ includes.
9208         * command.h: Fix common/ includes.
9209         * cli/cli-dump.c: Fix common/ includes.
9210         * cli/cli-cmds.c: Fix common/ includes.
9211         * charset.c: Fix common/ includes.
9212         * build-id.c: Fix common/ includes.
9213         * btrace.h: Fix common/ includes.
9214         * btrace.c: Fix common/ includes.
9215         * breakpoint.h: Fix common/ includes.
9216         * breakpoint.c: Fix common/ includes.
9217         * ax.h:
9218         (enum agent_op): Fix common/ includes.
9219         * ax-general.c (struct aop_map): Fix common/ includes.
9220         * ax-gdb.c: Fix common/ includes.
9221         * auxv.c: Fix common/ includes.
9222         * auto-load.c: Fix common/ includes.
9223         * arm-tdep.c: Fix common/ includes.
9224         * arch/riscv.c: Fix common/ includes.
9225         * arch/ppc-linux-common.c: Fix common/ includes.
9226         * arch/i386.c: Fix common/ includes.
9227         * arch/arm.c: Fix common/ includes.
9228         * arch/arm-linux.c: Fix common/ includes.
9229         * arch/arm-get-next-pcs.c: Fix common/ includes.
9230         * arch/amd64.c: Fix common/ includes.
9231         * arch/aarch64.c: Fix common/ includes.
9232         * arch/aarch64-insn.c: Fix common/ includes.
9233         * arch-utils.c: Fix common/ includes.
9234         * amd64-windows-tdep.c: Fix common/ includes.
9235         * amd64-tdep.c: Fix common/ includes.
9236         * amd64-sol2-tdep.c: Fix common/ includes.
9237         * amd64-obsd-tdep.c: Fix common/ includes.
9238         * amd64-nbsd-tdep.c: Fix common/ includes.
9239         * amd64-linux-tdep.c: Fix common/ includes.
9240         * amd64-linux-nat.c: Fix common/ includes.
9241         * amd64-fbsd-tdep.c: Fix common/ includes.
9242         * amd64-fbsd-nat.c: Fix common/ includes.
9243         * amd64-dicos-tdep.c: Fix common/ includes.
9244         * amd64-darwin-tdep.c: Fix common/ includes.
9245         * agent.c: Fix common/ includes.
9246         * ada-lang.h: Fix common/ includes.
9247         * ada-lang.c: Fix common/ includes.
9248         * aarch64-tdep.c: Fix common/ includes.
9249
9250 2019-01-25  Tom Tromey  <tom@tromey.com>
9251
9252         * common/create-version.sh: Use common/version.h.
9253
9254 2019-01-24  Pedro Alves  <palves@redhat.com>
9255
9256         * infrun.c (signal_stop, signal_print, signal_program)
9257         (signal_catch, signal_pass): Now arrays instead of pointers.
9258         (update_signals_program_target, do_target_resume)
9259         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9260         * linux-nat.c (linux_nat_target::pass_signals)
9261         (linux_nat_target::create_inferior, linux_nat_target::attach):
9262         Adjust.
9263         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9264         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9265         * procfs.c (procfs_target::pass_signals): Adjust.
9266         * record-full.c (record_full_target::resume): Adjust.
9267         * remote.c (remote_target::pass_signals)
9268         (remote_target::program_signals): Adjust.
9269         * target-debug.h (target_debug_print_signals): Now takes a
9270         gdb::array_view as parameter.  Adjust.
9271         * target.h (target_ops) <pass_signals, program_signals>: Replace
9272         pointer and length parameters with gdb::array_view.
9273         (target_pass_signals, target_program_signals): Likewise.
9274         * target-delegates.c: Regenerate.
9275
9276 2019-01-24  Pedro Alves  <palves@redhat.com>
9277
9278         * common/forward-scope-exit.h
9279         (forward_scope_exit::forward_scope_exit): Pass arguments to
9280         m_bind_function directly, instead of creating a std::bind and
9281         copying that.
9282
9283 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9284
9285         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9286         for static members.
9287         (pass_in_v_vfp_candidate): Likewise.
9288
9289 2019-01-23  Tom Tromey  <tom@tromey.com>
9290             Pedro Alves  <palves@redhat.com>
9291
9292         * regcache.c (class regcache_invalidator): Remove.
9293         (regcache::raw_write): Use make_scope_exit.
9294
9295 2019-01-23  Tom Tromey  <tom@tromey.com>
9296
9297         * ui-out.h (class ui_out_emit_type): Update comment.
9298
9299 2019-01-23  Tom Tromey  <tom@tromey.com>
9300
9301         * infrun.c (fetch_inferior_event): Update comment.
9302
9303 2019-01-23  Tom Tromey  <tom@tromey.com>
9304             Pedro Alves  <palves@redhat.com>
9305
9306         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9307         parameter.
9308         (fetch_inferior_event): Use SCOPE_EXIT.
9309
9310
9311 2019-01-23  Tom Tromey  <tom@tromey.com>
9312             Pedro Alves  <palves@redhat.com>
9313
9314         * infrun.c (disable_thread_events): Delete.
9315         (stop_all_threads): Use SCOPE_EXIT.
9316
9317 2019-01-23  Tom Tromey  <tom@tromey.com>
9318             Pedro Alves  <palves@redhat.com>
9319
9320         * symfile.c: Include forward-scope-exit.h.
9321         (clear_symtab_users_cleanup): Replace forward declaration with
9322         a FORWARD_SCOPE_EXIT.
9323         (syms_from_objfile_1): Use the forward_scope_exit and
9324         gdb::optional instead of cleanup_function.
9325         (reread_symbols): Use the forward_scope_exit instead of
9326         cleanup_function.
9327         (clear_symtab_users_cleanup): Remove function.
9328
9329 2019-01-23  Tom Tromey  <tom@tromey.com>
9330             Pedro Alves  <palves@redhat.com>
9331
9332         * linux-nat.c: Include scope-exit.h.
9333         (cleanup_target_stop): Remove.
9334         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9335         SCOPE_EXIT.
9336
9337 2019-01-23  Tom Tromey  <tom@tromey.com>
9338             Pedro Alves  <palves@redhat.com>
9339
9340         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9341         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9342
9343 2019-01-23  Tom Tromey  <tom@tromey.com>
9344             Andrew Burgess  <andrew.burgess@embecosm.com>
9345             Pedro Alves  <palves@redhat.com>
9346
9347         * infrun.c (fetch_inferior_event): Use scope_exit.
9348         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9349         * top.c (execute_command): Use scope_exit.
9350         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9351         * utils.c (do_bpstat_clear_actions_cleanup)
9352         (make_bpstat_clear_actions_cleanup): Remove.
9353
9354 2019-01-23  Tom Tromey  <tom@tromey.com>
9355             Pedro Alves  <palves@redhat.com>
9356
9357         * infrun.c: Include "common/scope-exit.h"
9358         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9359         (wait_for_inferior): Use SCOPE_EXIT.
9360         (fetch_inferior_event): Use scope_exit.
9361
9362 2019-01-23  Tom Tromey  <tom@tromey.com>
9363             Pedro Alves  <palves@redhat.com>
9364
9365         * breakpoint.c (create_breakpoint): Remove cleanup.
9366
9367 2019-01-23  Tom Tromey  <tom@tromey.com>
9368             Andrew Burgess  <andrew.burgess@embecosm.com>
9369             Pedro Alves  <palves@redhat.com>
9370
9371 2019-01-23  Pedro Alves  <palves@redhat.com>
9372
9373         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9374
9375 2019-01-23  Pedro Alves  <palves@redhat.com>
9376             Andrew Burgess  <andrew.burgess@embecosm.com>
9377
9378         * gdbthread.h: Include "common/forward-scope-exit.h".
9379         (scoped_finish_thread_state): Redefine custom class in terms of
9380         forward_scope_exit.
9381
9382 2019-01-23  Pedro Alves  <palves@redhat.com>
9383             Andrew Burgess  <andrew.burgess@embecosm.com>
9384
9385         * common/forward-scope-exit.h: New file.
9386
9387 2019-01-23  Pedro Alves  <palves@redhat.com>
9388             Andrew Burgess  <andrew.burgess@embecosm.com>
9389             Tom Tromey  <tom@tromey.com>
9390
9391         * common/scope-exit.h: New file.
9392
9393 2019-01-23  Pedro Alves  <palves@redhat.com>
9394
9395         * common/preprocessor.h (ESC): Rename to ...
9396         (ESC_PARENS): ... this.
9397         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9398         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9399
9400 2019-01-23  Tom Tromey  <tom@tromey.com>
9401
9402         * language.h (class scoped_switch_to_sym_language_if_auto):
9403         Initialize m_lang in both cases.
9404
9405 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9406
9407         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9408         with XCNEW.
9409
9410 2019-01-22  Tom Tromey  <tom@tromey.com>
9411
9412         * corelow.c: Do not include sys/file.h.
9413
9414 2019-01-22  Tom Tromey  <tom@tromey.com>
9415
9416         * tui/tui-wingeneral.h: Include gdb_curses.h.
9417
9418 2019-01-22  Tom Tromey  <tom@tromey.com>
9419
9420         * source-cache.h (class source_cache) <get_source_lines,
9421         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9422
9423 2019-01-22  Tom Tromey  <tom@tromey.com>
9424
9425         * remote-fileio.h (struct remote_target): Declare.
9426
9427 2019-01-22  Tom Tromey  <tom@tromey.com>
9428
9429         * python/py-arch.c: Do not include py-ref.h.
9430         * python/py-bpevent.c: Do not include py-ref.h.
9431         * python/py-cmd.c: Do not include py-ref.h.
9432         * python/py-continueevent.c: Do not include py-ref.h.
9433         * python/py-event.h: Do not include py-ref.h.
9434         * python/py-evtregistry.c: Do not include py-ref.h.
9435         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9436         * python/py-frame.c: Do not include py-ref.h.
9437         * python/py-framefilter.c: Do not include py-ref.h.
9438         * python/py-function.c: Do not include py-ref.h.
9439         * python/py-infevents.c: Do not include py-ref.h.
9440         * python/py-linetable.c: Do not include py-ref.h.
9441         * python/py-objfile.c: Do not include py-ref.h.
9442         * python/py-param.c: Do not include py-ref.h.
9443         * python/py-prettyprint.c: Do not include py-ref.h.
9444         * python/py-progspace.c: Do not include py-ref.h.
9445         * python/py-symbol.c: Do not include py-ref.h.
9446         * python/py-symtab.c: Do not include py-ref.h.
9447         * python/py-type.c: Do not include py-ref.h.
9448         * python/py-unwind.c: Do not include py-ref.h.
9449         * python/py-utils.c: Do not include py-ref.h.
9450         * python/py-value.c: Do not include py-ref.h.
9451         * python/py-varobj.c: Do not include py-ref.h.
9452         * python/py-xmethods.c: Do not include py-ref.h.
9453         * python/python.c: Do not include py-ref.h.
9454         * varobj.c: Do not include py-ref.h.
9455
9456 2019-01-22  Tom Tromey  <tom@tromey.com>
9457
9458         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9459         keyword for bcache.
9460
9461 2019-01-22  Tom Tromey  <tom@tromey.com>
9462
9463         * compile/compile-cplus-types.c: Remove a comment by #include.
9464
9465 2019-01-22  Tom Tromey  <tom@tromey.com>
9466
9467         * compile/gcc-c-plugin.h: Include compile-internal.h.
9468
9469 2019-01-22  Tom Tromey  <tom@tromey.com>
9470
9471         * stabsread.c (EXTERN): Do not define.
9472         (symnum, next_symbol_text_func, processing_gcc_compilation)
9473         (within_function, global_sym_chain, global_stabs)
9474         (previous_stab_code, this_object_header_files)
9475         (n_this_object_header_files)
9476         (n_allocated_this_object_header_files): Define.
9477         * stabsread.h (EXTERN): Never define.  Use "extern".
9478
9479 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9480
9481         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9482         history_value.
9483
9484 2019-01-21  Tom Tromey  <tom@tromey.com>
9485
9486         * ui-out.c: Fix includes.
9487         * tui/tui-source.c: Fix includes.
9488         * target.c: Fix includes.
9489         * remote.c: Fix includes.
9490         * regcache.c: Fix includes.
9491         * python/py-block.c: Fix includes.
9492         * printcmd.c: Fix includes.
9493         * or1k-tdep.c: Fix includes.
9494         * mi/mi-main.c: Fix includes.
9495         * m32r-tdep.c: Fix includes.
9496         * csky-tdep.c: Fix includes.
9497         * compile/compile-cplus-types.c: Fix includes.
9498         * cli/cli-interp.c: Fix includes.
9499
9500 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9501
9502         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9503         for padding.
9504
9505 2019-01-16  Tom Tromey  <tom@tromey.com>
9506
9507         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9508         earlier.
9509         (struct objfile) <msymbols_range>: Move from top level.
9510         <msymbols>: New method.
9511         (class objfile_msymbols): Remove.
9512         * symtab.c (default_collect_symbol_completion_matches_break_on):
9513         Update.
9514         * symmisc.c (dump_msymbols): Update.
9515         * stabsread.c (scan_file_globals): Update.
9516         * objc-lang.c (info_selectors_command, info_classes_command)
9517         (find_methods): Update.
9518         * minsyms.c (find_solib_trampoline_target): Update.
9519         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9520         * coffread.c (coff_symfile_read): Update.
9521         * ada-lang.c (ada_lookup_simple_minsym)
9522         (ada_collect_symbol_completion_matches): Update.
9523
9524 2019-01-16  Tom Tromey  <tom@tromey.com>
9525
9526         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9527         type.  Remove no-argument constructor.
9528         <iterator::operator++>: Simplify.
9529         <begin>: Update.
9530         <end>: Use minimal_symbol_count.
9531
9532 2019-01-16  Tom Tromey  <tom@tromey.com>
9533
9534         * objfiles.h (struct objfile) <psymtabs>: New method.
9535         (class objfile_psymtabs): Remove.
9536         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9537         typedef.
9538         <range>: New method.
9539         (require_partial_symbols): Change return type.
9540         * psymtab.c (require_partial_symbols)
9541         (psym_expand_symtabs_matching): Update.
9542         * mdebugread.c (parse_partial_symbols): Update.
9543         * dbxread.c (dbx_end_psymtab): Update.
9544
9545 2019-01-15  Tom Tromey  <tom@tromey.com>
9546
9547         * symtab.c (lookup_objfile_from_block)
9548         (lookup_symbol_in_objfile_symtabs)
9549         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9550         (find_line_symtab, info_sources_command)
9551         (default_collect_symbol_completion_matches_break_on)
9552         (make_source_files_completion_list): Update.
9553         * symmisc.c (print_objfile_statistics, dump_objfile)
9554         (maintenance_print_symbols, maintenance_info_symtabs)
9555         (maintenance_check_symtabs, maintenance_info_line_tables):
9556         Update.
9557         * source.c (select_source_symtab)
9558         (forget_cached_source_info_for_objfile): Update.
9559         * objfiles.h (class objfile_compunits): Remove.
9560         (struct objfile) <compunits_range>: New typedef.
9561         (compunits): New method.
9562         * objfiles.c (objfile_relocate1): Update.
9563         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9564         * maint.c (count_symtabs_and_blocks): Update.
9565         * linespec.c (iterate_over_all_matching_symtabs): Update.
9566         * cp-support.c (add_symbol_overload_list_qualified): Update.
9567         * coffread.c (coff_symtab_read): Update.
9568         * ada-lang.c (add_nonlocal_symbols)
9569         (ada_collect_symbol_completion_matches)
9570         (ada_add_global_exceptions): Update.
9571
9572 2019-01-15  Tom Tromey  <tom@tromey.com>
9573
9574         * progspace.h (program_space) <objfiles_safe_range>: New
9575         typedef.
9576         <objfiles_safe>: New method.
9577         * objfiles.h (class all_objfiles_safe): Remove.
9578         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9579         * jit.c (jit_inferior_exit_hook): Update.
9580
9581 2019-01-17  Tom Tromey  <tom@tromey.com>
9582
9583         * progspace.h (program_space) <objfiles_range>: New typedef.
9584         <objfiles>: New method.
9585         <objfiles_head>: Rename from objfiles.
9586         (object_files): Update.
9587         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9588         * guile/scm-pretty-print.c
9589         (ppscm_find_pretty_printer_from_objfiles): Update.
9590         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9591         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9592         Update.
9593         * python/py-progspace.c (pspy_get_objfiles): Update.
9594         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9595         Update.
9596         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9597         (objfpy_lookup_objfile_by_build_id): Update.
9598         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9599         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9600         Update.
9601         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9602         (expand_symtab_containing_pc, lookup_objfile_from_block)
9603         (lookup_static_symbol, basic_lookup_transparent_type)
9604         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9605         (find_line_symtab, info_sources_command)
9606         (default_collect_symbol_completion_matches_break_on)
9607         (make_source_files_completion_list, find_main_name): Update.
9608         * symmisc.c (print_symbol_bcache_statistics)
9609         (print_objfile_statistics, maintenance_print_symbols)
9610         (maintenance_print_msymbols, maintenance_print_objfiles)
9611         (maintenance_info_symtabs, maintenance_check_symtabs)
9612         (maintenance_expand_symtabs, maintenance_info_line_tables):
9613         Update.
9614         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9615         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9616         (map_overlay_command, unmap_overlay_command)
9617         (simple_overlay_update, expand_symtabs_matching)
9618         (map_symbol_filenames): Update.
9619         * symfile-debug.c (set_debug_symfile): Update.
9620         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9621         Update.
9622         * source.c (select_source_symtab, forget_cached_source_info):
9623         Update.
9624         * solib.c (solib_read_symbols): Update.
9625         * solib-spu.c (append_ocl_sos): Update.
9626         * psymtab.c (maintenance_print_psymbols)
9627         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9628         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9629         * printcmd.c (info_symbol_command): Update.
9630         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9631         Update.
9632         * objfiles.h (class all_objfiles): Remove.
9633         * objfiles.c (have_partial_symbols, have_full_symbols)
9634         (have_minimal_symbols, qsort_cmp, update_section_map)
9635         (shared_objfile_contains_address_p)
9636         (default_iterate_over_objfiles_in_search_order): Update.
9637         * objc-lang.c (info_selectors_command, info_classes_command)
9638         (find_methods): Update.
9639         * minsyms.c (find_solib_trampoline_target): Update.
9640         * maint.c (maintenance_info_sections)
9641         (maintenance_translate_address, count_symtabs_and_blocks):
9642         Update.
9643         * main.c (captured_main_1): Update.
9644         * linux-thread-db.c (try_thread_db_load_from_pdir)
9645         (has_libpthread): Update.
9646         * linespec.c (iterate_over_all_matching_symtabs)
9647         (search_minsyms_for_name): Update.
9648         * jit.c (jit_find_objf_with_entry_addr): Update.
9649         * hppa-tdep.c (find_unwind_entry)
9650         (hppa_lookup_stub_minimal_symbol): Update.
9651         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9652         Update.
9653         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9654         (elf_gnu_ifunc_resolve_by_got): Update.
9655         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9656         * dwarf-index-write.c (save_gdb_index_command): Update.
9657         * cp-support.c (add_symbol_overload_list_qualified): Update.
9658         * breakpoint.c (create_overlay_event_breakpoint)
9659         (create_longjmp_master_breakpoint)
9660         (create_std_terminate_master_breakpoint)
9661         (create_exception_master_breakpoint): Update.
9662         * blockframe.c (find_pc_partial_function): Update.
9663         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9664         (ada_collect_symbol_completion_matches)
9665         (ada_add_global_exceptions): Update.
9666
9667 2019-01-17  Tom Tromey  <tom@tromey.com>
9668
9669         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9670         declare VEC.
9671         (solib_target_parse_libraries): Change return type.
9672         (library_list_start_segment, library_list_start_section)
9673         (library_list_end_library, library_list_start_library); Update.
9674         (solib_target_free_library_list): Remove.
9675         (solib_target_parse_libraries): Remove cleanup.  Change return
9676         type.
9677         (solib_target_current_sos): Update.
9678
9679 2019-01-17  Tom Tromey  <tromey@bapiya>
9680
9681         * valprint.c: Replace "the the" with "the".
9682         * symtab.c: Replace "the the" with "the".
9683         * solib.c: Replace "the the" with "the".
9684         * solib-dsbt.c: Replace "the the" with "the".
9685         * linespec.c: Replace "the the" with "the".
9686         * dwarf2loc.h: Replace "the the" with "the".
9687         * amd64-windows-tdep.c: Replace "the the" with "the".
9688         * aarch64-tdep.c: Replace "the the" with "the".
9689
9690 2019-01-16  Keith Seitz  <keiths@redhat.com>
9691
9692         PR gdb/23773
9693         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9694         <builder>: Rename to ..
9695         <m_builder>: ... this and make private.
9696         (dwarf2_cu::get_builder): New method.  Change all users of
9697         `builder' to use this method.
9698         (dwarf2_start_symtab): Move to ...
9699         (dwarf2_cu::start_symtab): ... here.  Update all callers
9700         (setup_type_unit_groups): Move to ...
9701         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9702         callers.
9703         (dwarf2_cu::reset_builder): New method.
9704         (process_full_compunit, process_full_type_unit): Use
9705         dwarf2_cu::reset_builder.
9706         (follow_die_offset): Record the ancestor CU if it is different
9707         from the followed DIE's CU.
9708         (follow_die_sig_1): Likewise.
9709
9710 2019-01-15  Tom Tromey  <tom@tromey.com>
9711
9712         * remote.c (class remote_state) <buf>: Now a char_vector.
9713         <buf_size>: Remove.
9714         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9715         parameter.
9716         (remote_target::getpkt_or_notif_sane_1)
9717         (remote_target::getpkt_sane)
9718         (remote_target::getpkt_or_notif_sane): Likewise.
9719         (class remote_target) <putpkt>: New overload.
9720         (remote_target::read_frame): Change type of "buf_p".  Remove
9721         sizeof_p parameter.
9722         (packet_ok): New overload.
9723         (packet_check_result): New overload.
9724         Update all uses.
9725
9726 2019-01-14  Tom Tromey  <tom@tromey.com>
9727
9728         * remote-notif.c (handle_notification, remote_notif_ack)
9729         (remote_notif_parse): Make "buf" const.
9730         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9731         const.
9732         (remote_notif_parse, remote_notif_ack, handle_notification):
9733         Likewise.
9734         * remote.c (remote_notif_stop_parse): Make "buf" const.
9735         (remote_target::remote_parse_stop_reply): Make "buf" const.
9736         (remote_notif_stop_ack): Make "buf" const.
9737
9738 2019-01-14  Tom Tromey  <tom@tromey.com>
9739
9740         * remote.c (remote_console_output): Make parameter const.
9741
9742 2019-01-14  Tom Tromey  <tom@tromey.com>
9743
9744         * target-debug.h (target_debug_print_signals): Constify.
9745         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9746         * procfs.c (procfs_target::pass_signals): Update.
9747         * linux-nat.c (linux_nat_target::pass_signals): Update.
9748         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9749         * target-delegates.c: Rebuild.
9750         * remote.c (remote_target::program_signals): Update.
9751         (remote_target::pass_signals): Update.
9752         * target.c (target_pass_signals): Constify argument.
9753         (target_program_signals): Likewise.
9754         * target.h (struct target_ops) <pass_signals, program_signals>:
9755         Constify argument.
9756         (target_pass_signals, target_program_signals): Constify argument.
9757
9758 2019-01-14  Tom Tromey  <tom@tromey.com>
9759
9760         PR tui/28819:
9761         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9762
9763 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9764
9765         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9766         field.
9767         * rs6000-tdep.c: Include reggroups.h.
9768         (IS_V_ALIAS_PSEUDOREG): Define.
9769         (rs6000_register_name): Return names for the "vX" aliases.
9770         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9771         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9772         aliases.  Call default_register_reggroup_p for all other
9773         pseudo-registers.
9774         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9775         New functions.
9776         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9777         Handle "vX" aliases.
9778         (v_alias_pseudo_register_collect): New function.
9779         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9780         (rs6000_gdbarch_init): Initialize "vX" aliases as
9781         pseudo-registers.  Restore registration of
9782         rs6000_pseudo_register_reggroup_p with
9783         set_tdesc_pseudo_register_reggroup_p.
9784
9785 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9786
9787         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9788         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9789         set_gdbarch_num_pseudo_regs.
9790
9791 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9792
9793         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9794         Remove arg prefixname, add do_set and do_show.
9795         Add member functions set_list and show_list.
9796         * cli/cli-style.c (class cli_style_option): Update accordingly.
9797         (style_set_list): Move to file scope.
9798         (style_show_list): Likewise.
9799         (set_style): Call help_list.
9800         (show_style): Call cmd_show_list.
9801         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9802         Update to use the new macro.
9803
9804 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9805
9806         * ada-lang.c (_initialize_ada_language): Expand the help text
9807         for the "catch exception" command.
9808
9809 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9810
9811         * symtab.c (matching_obj_sections): Initialize obj,
9812         declare it closer to its usage.
9813
9814 2019-01-10  Tom Tromey  <tom@tromey.com>
9815
9816         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9817         (basic_inf_threads_range): Remove.
9818         (inf_threads_range, inf_non_exited_threads_range)
9819         (safe_inf_threads_range): Use next_adapter.
9820
9821 2019-01-10  Keith Seitz  <keiths@redhat.com>
9822
9823         PR gdb/23712
9824         PR symtab/23010
9825         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9826         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9827
9828 2019-01-10  Keith Seitz  <keiths@redhat.com>
9829
9830         PR gdb/23712
9831         PR symtab/23010
9832         * dictionary.c (pending_to_vector): Remove.
9833         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9834         Remove _1 suffix, replacing functions of the same name.  Update
9835         all callers.
9836         (dict_create_hashed, dict_create_hashed_expandable)
9837         (dict_create_linear, dict_create_linear_expandable, dict_free)
9838         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9839         Make functions static.
9840
9841 2019-01-10  Keith Seitz  <keiths@redhat.com>
9842
9843         PR gdb/23712
9844         PR symtab/23010
9845         * dictionary.h (struct dictionary): Replace declaration with
9846         multidictionary.
9847         (dict_create_hashed, dict_create_hashed_expandable)
9848         (dict_create_linear, dict_create_linear_expandable)
9849         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9850         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9851         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9852         taking multidictionary argument.
9853         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9854         * block.h (struct block) <dict>: Change to multidictionary
9855         and rename `multidict'.
9856         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9857         symmisc.c: Update all dictionary references to multidictionary.
9858
9859 2019-01-10  Keith Seitz  <keiths@redhat.com>
9860
9861         PR gdb/23712
9862         PR symtab/23010
9863         * dictionary.c: Include unordered_map.
9864         (pending_to_vector): New function.
9865         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9866         Rewrite the non-"_1" functions to take vector instead
9867         of linked list.
9868         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9869         "new" _1 versions of the same name.
9870         (multidictionary): Define.
9871         (std::hash<enum language): New definition.
9872         (collate_pending_symbols_by_language, mdict_create_hashed)
9873         (mdict_create_hashed_expandable, mdict_create_linear)
9874         (mdict_create_linear_expandable, mdict_free)
9875         (find_language_dictionary, create_new_language_dictionary)
9876         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9877         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9878         (mdict_size, mdict_empty): New functions.
9879         * dictionary.h (mdict_iterator): Define.
9880
9881 2019-01-10  Pedro Alves  <palves@redhat.com>
9882
9883         * breakpoint.c (read_uploaded_action)
9884         (create_tracepoint_from_upload): Adjust to use
9885         gdb::unique_xmalloc_ptr.
9886         * ctf.c (ctf_write_uploaded_tp):
9887         (SET_ARRAY_FIELD): Use emplace_back.
9888         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9889         * tracefile-tfile.c (tfile_write_uploaded_tp):
9890         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9891         gdb::unique_xmalloc_ptr.
9892         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9893         at_string, cond_string, cmd_strings>: Replace char pointers
9894         with gdb::unique_xmalloc_ptr.
9895
9896 2019-01-10  Pedro Alves  <palves@redhat.com>
9897
9898         * solib-target.c (library_list_start_library): Don't xstrdup name.
9899
9900 2019-01-10  Pedro Alves  <palves@redhat.com>
9901
9902         * mdebugread.c (parse_partial_symbols): Use
9903         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9904
9905 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9906
9907         * linux-fork.c (scoped_switch_fork_info)
9908         <~scoped_switch_fork_info>: Fix incorrect variable name.
9909
9910 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9911
9912         * linux-fork.c (scoped_switch_fork_info)
9913         <scoped_switch_fork_info>: Make explicit.
9914         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9915
9916 2019-01-10  Tom Tromey  <tom@tromey.com>
9917
9918         * objfiles.h (objfile::reset_psymtabs): Update.
9919         * objfiles.c (objfile::objfile): Update.
9920         * psymtab.h (psymtab_storage::obstack): Update.
9921         (psymtab_storage::m_obstack): Use gdb::optional.
9922         (class psymtab_storage): Update comment.  Remove objfile
9923         parameter.
9924         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9925
9926 2019-01-10  Tom Tromey  <tom@tromey.com>
9927
9928         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9929         <free_psymtabs>: Now private.
9930         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9931         (allocate_psymtab): Use new method.
9932
9933 2019-01-10  Tom Tromey  <tom@tromey.com>
9934
9935         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9936         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9937         * mdebugread.c (parse_partial_symbols): Use
9938         allocate_dependencies.
9939         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9940         allocate_dependencies.
9941         (process_psymtab_comp_unit_reader)
9942         (build_type_psymtab_dependencies): Likewise.
9943         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9944
9945 2019-01-10  Tom Tromey  <tom@tromey.com>
9946
9947         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9948         PSYMBOL_SET_LANGUAGE.
9949         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9950
9951 2019-01-10  Tom Tromey  <tom@tromey.com>
9952
9953         * psymtab.h (psymtab_storage::obstack): New method.
9954         <m_obstack>: Rename from obstack; now private.
9955         * psymtab.c (psymtab_storage): Update.
9956         * dwarf2read.c (create_addrmap_from_index)
9957         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9958         Update.
9959
9960 2019-01-10  Tom Tromey  <tom@tromey.com>
9961
9962         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9963         * objfiles.h (objfile::reset_psymtabs): New method.
9964
9965 2019-01-10  Tom Tromey  <tom@tromey.com>
9966
9967         * symmisc.c (print_symbol_bcache_statistics): Update.
9968         (print_objfile_statistics): Update.
9969         * symfile.c (reread_symbols): Update.
9970         * psymtab.h (class psymtab_storage): New.
9971         * psymtab.c (psymtab_storage): New constructor.
9972         (~psymtab_storage): New destructor.
9973         (require_partial_symbols): Update.
9974         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9975         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9976         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9977         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9978         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9979         (start_psymtab_common, end_psymtab_common)
9980         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9981         (allocate_psymtab): Update.
9982         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9983         Update.
9984         (dump_psymtab_addrmap, maintenance_print_psymbols)
9985         (maintenance_check_psymtabs): Update.
9986         (class objfile_psymtabs): Move to objfiles.h.
9987         * psympriv.h (discard_psymtab): Now inline.
9988         (psymtab_discarder::psymtab_discarder): Update.
9989         (psymtab_discarder::~psymtab_discarder): Update.
9990         (ALL_OBJFILE_PSYMTABS): Rewrite.
9991         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9992         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9993         Remove fields.
9994         <partial_symtabs>: New field.
9995         (class objfile_psymtabs): Move from psymtab.h.  Update.
9996         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9997         psymbol_cache.
9998         (objfile::~objfile): Don't destroy psymbol_cache.
9999         * mdebugread.c (parse_partial_symbols): Update.
10000         * dwarf2read.c (create_addrmap_from_index)
10001         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10002         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10003         (add_partial_subprogram, dwarf2_ranges_read): Update.
10004         * dwarf-index-write.c (write_address_map)
10005         (write_one_signatured_type, recursively_write_psymbols)
10006         (class debug_names, class debug_names, write_psymtabs_to_index):
10007         Update.
10008
10009 2019-01-10  Tom Tromey  <tom@tromey.com>
10010
10011         * symtab.h (SYMBOL_SET_NAMES): Update.
10012         (symbol_set_names): Update.
10013         (MSYMBOL_SET_NAMES): Update.
10014         * symtab.c (symbol_set_names): Change argument to be an
10015         objfile_per_bfd_storage.
10016         * psymtab.c (add_psymbol_to_bcache): Update.
10017         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10018
10019 2019-01-10  Tom Tromey  <tom@tromey.com>
10020
10021         * symtab.c (create_demangled_names_hash): Change argument to be an
10022         objfile_per_bfd_storage.
10023         (symbol_set_names): Update.
10024
10025 2019-01-10  Tom Tromey  <tom@tromey.com>
10026
10027         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10028         init_psymbol_list.
10029         * psymtab.c (init_psymbol_list): Do nothing if already called.
10030         * psympriv.h (init_psymbol_list): Add comment.
10031         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10032         init_psymbol_list.
10033         * dbxread.c (dbx_symfile_read): Unconditionally call
10034         init_psymbol_list.
10035
10036 2019-01-10  Tom Tromey  <tom@tromey.com>
10037
10038         * xcoffread.c (scan_xcoff_symtab): Update.
10039         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10040         "where".
10041         * mdebugread.c (parse_partial_symbols)
10042         (handle_psymbol_enumerators): Update.
10043         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10044         * dbxread.c (read_dbx_symtab): Update.
10045         * psympriv.h (psymbol_placement): New enum.
10046         (add_psymbol_to_list): Update.
10047
10048 2019-01-10  Tom Tromey  <tom@tromey.com>
10049
10050         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10051         static_psymbols parameters.
10052         (scan_xcoff_symtab): Update.
10053         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10054         static_psymbols parameters.
10055         * psympriv.h (start_psymtab_common): Update.
10056         * mdebugread.c (parse_partial_symbols): Update.
10057         * dwarf2read.c (create_partial_symtab): Update.
10058         * dbxread.c (read_dbx_symtab): Update.
10059         (start_psymtab): Remove global_psymbols and static_psymbols
10060         parameters.
10061
10062 2019-01-10  Tom Tromey  <tom@tromey.com>
10063
10064         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10065         * psymtab.c (allocate_psymtab): Add comment.
10066         * psympriv.h (allocate_psymtab): Add comment.
10067         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10068         initializations.
10069         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10070
10071 2019-01-10  Tom Tromey  <tom@tromey.com>
10072
10073         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10074         Don't declare.
10075         * mipsread.c: Include mdebugread.h.
10076         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10077         Declare.
10078         * elfread.c: Include mdebugread.h.
10079
10080 2019-01-09  Tom Tromey  <tom@tromey.com>
10081
10082         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10083         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10084         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10085         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10086         (psym_lookup_symbol, psym_find_last_source_symtab)
10087         (psym_forget_cached_source_info, psym_print_stats)
10088         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10089         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10090         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10091         (psym_find_compunit_symtab_by_address)
10092         (maintenance_print_psymbols, maintenance_info_psymtabs)
10093         (maintenance_check_psymtabs): Use ranged for.
10094         * psymtab.h (class objfile_psymtabs): New.
10095         (require_partial_symbols): Return objfile_psymtabs.
10096         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10097
10098 2019-01-09  Tom Tromey  <tom@tromey.com>
10099
10100         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10101         (find_pc_mapped_section, list_overlays_command)
10102         (map_overlay_command, unmap_overlay_command)
10103         (simple_overlay_update): Use all_objfiles.
10104         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10105         * printcmd.c (info_symbol_command): Use all_objfiles.
10106         * objfiles.h (ALL_OBJSECTIONS): Remove.
10107         * maint.c (maintenance_translate_address): Use all_objfiles.
10108         * gcore.c (gcore_create_callback): Use all_objfiles.
10109         (objfile_find_memory_regions): Likewise.
10110
10111 2019-01-09  Tom Tromey  <tom@tromey.com>
10112
10113         * symtab.c (find_line_symtab, info_sources_command)
10114         (make_source_files_completion_list): Use objfile_compunits.
10115         * source.c (select_source_symtab): Use objfile_compunits.
10116         * objfiles.h (struct objfile): Update comment.
10117         (ALL_OBJFILES): Remove.
10118         (ALL_FILETABS): Remove.
10119         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10120         objfile_compunits.
10121
10122 2019-01-09  Tom Tromey  <tom@tromey.com>
10123
10124         * symmisc.c (print_objfile_statistics, dump_objfile)
10125         (maintenance_print_symbols): Use compunit_filetabs.
10126         * source.c (forget_cached_source_info_for_objfile): Use
10127         compunit_filetabs.
10128         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10129         (ALL_FILETABS): Use compunit_filetabs.
10130         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10131         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10132
10133 2019-01-09  Tom Tromey  <tom@tromey.com>
10134
10135         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10136         (compunit_filetabs): New.
10137         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10138         compunit_filetabs.
10139         (info_sources_command, make_source_files_completion_list): Remove
10140         declaration.
10141         * symmisc.c (print_objfile_statistics, dump_objfile)
10142         (maintenance_print_symbols): Remove declaration.
10143         (maintenance_info_symtabs): Use compunit_filetabs.
10144         (maintenance_info_line_tables): Likewise.
10145         * source.c (select_source_symtab): Change local variable name.
10146         (forget_cached_source_info_for_objfile): Remove declaration.
10147         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10148         * objfiles.c (objfile_relocate1): Remove declaration.
10149         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10150         declaration.
10151         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10152         * coffread.c (coff_symtab_read): Remove declaration.
10153         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10154         compunit_filetabs.
10155
10156 2019-01-09  Tom Tromey  <tom@tromey.com>
10157
10158         * symtab.c (lookup_objfile_from_block)
10159         (find_pc_sect_compunit_symtab, search_symbols)
10160         (default_collect_symbol_completion_matches_break_on): Use
10161         objfile_compunits.
10162         * objfiles.h (ALL_COMPUNITS): Remove.
10163         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10164         * cp-support.c (add_symbol_overload_list_qualified): Use
10165         objfile_compunits.
10166         * ada-lang.c (ada_collect_symbol_completion_matches)
10167         (ada_add_global_exceptions): Use objfile_compunits.
10168
10169 2019-01-09  Tom Tromey  <tom@tromey.com>
10170
10171         * source.c (select_source_symtab)
10172         (forget_cached_source_info_for_objfile): Remove declaration.
10173         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10174         declaration.
10175         * maint.c (count_symtabs_and_blocks): Remove declaration.
10176         * cp-support.c (add_symbol_overload_list_qualified): Remove
10177         declaration.
10178         * coffread.c (coff_symtab_read): Remove declaration.
10179         * symtab.c (lookup_symbol_in_objfile_symtabs)
10180         (basic_lookup_transparent_type_1): Use objfile_compunits.
10181         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10182         (info_sources_command, search_symbols)
10183         (default_collect_symbol_completion_matches_break_on)
10184         (make_source_files_completion_list): Remove declaration.
10185         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10186         (ada_collect_symbol_completion_matches)
10187         (ada_add_global_exceptions): Remove declaration.
10188         * linespec.c (iterate_over_all_matching_symtabs): Use
10189         objfile_compunits.
10190         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10191         (class objfile_compunits): New.
10192         (ALL_COMPUNITS): Use objfile_compunits.
10193         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10194         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10195         objfile_compunits.
10196         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10197
10198 2019-01-09  Tom Tromey  <tom@tromey.com>
10199
10200         * symtab.c (search_symbols)
10201         (default_collect_symbol_completion_matches_break_on): Use
10202         objfile_msymbols.
10203         * ada-lang.c (ada_lookup_simple_minsym)
10204         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10205         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10206         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10207         objfile_msymbols.
10208         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10209         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10210         * objc-lang.c (find_methods): Use objfile_msymbols.
10211         (info_selectors_command, info_classes_command): Likewise.
10212         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10213         * objfiles.h (class objfile_msymbols): New.
10214         (ALL_OBJFILE_MSYMBOLS): Remove.
10215         (ALL_MSYMBOLS): Remove.
10216
10217 2019-01-09  Tom Tromey  <tom@tromey.com>
10218
10219         * common/next-iterator.h (next_adapter): Add Iterator template
10220         parameter.
10221         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10222         (class all_objfiles_safe): New.
10223         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10224         * objfiles.c (put_objfile_before): Update comment.
10225         (add_separate_debug_objfile): Likewise.
10226         (free_all_objfiles): Use all_objfiles_safe.
10227         (objfile_purge_solibs): Likewise.
10228
10229 2019-01-09  Tom Tromey  <tom@tromey.com>
10230
10231         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10232         (expand_symtab_containing_pc, lookup_static_symbol)
10233         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10234         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10235         all_objfiles.
10236         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10237         * breakpoint.c (create_overlay_event_breakpoint)
10238         (create_longjmp_master_breakpoint)
10239         (create_std_terminate_master_breakpoint)
10240         (create_exception_master_breakpoint): Use all_objfiles.
10241         * linux-thread-db.c (try_thread_db_load_from_pdir)
10242         (has_libpthread): Use all_objfiles.
10243         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10244         * linespec.c (iterate_over_all_matching_symtabs)
10245         (search_minsyms_for_name): Use all_objfiles.
10246         * maint.c (maintenance_info_sections): Use all_objfiles.
10247         * main.c (captured_main_1): Use all_objfiles.
10248         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10249         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10250         * guile/scm-pretty-print.c
10251         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10252         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10253         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10254         (maintenance_print_msymbols): Use all_objfiles.
10255         * source.c (select_source_symtab): Use all_objfiles.
10256         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10257         * symfile.c (remove_symbol_file_command)
10258         (expand_symtabs_matching, map_symbol_filenames): Use
10259         all_objfiles.
10260         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10261         all_objfiles.
10262         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10263         * objc-lang.c (find_methods): Use all_objfiles.
10264         * objfiles.c (have_partial_symbols, have_full_symbols)
10265         (have_minimal_symbols, qsort_cmp)
10266         (default_iterate_over_objfiles_in_search_order): Use
10267         all_objfiles.
10268         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10269         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10270         (maintenance_check_psymtabs): Use all_objfiles.
10271         (ALL_PSYMTABS): Remove.
10272         * compile/compile-object-run.c (do_module_cleanup): Use
10273         all_objfiles.
10274         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10275         * cp-support.c (add_symbol_overload_list_qualified): Use
10276         all_objfiles.
10277         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10278         Use all_objfiles.
10279         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10280         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10281         all_objfiles.
10282         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10283         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10284         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10285         Uses all_objfiles.
10286         * solib.c (solib_read_symbols): Use all_objfiles
10287
10288 2019-01-09  Tom Tromey  <tom@tromey.com>
10289
10290         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10291         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10292         all_objfiles.
10293         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10294         * symmisc.c (print_symbol_bcache_statistics)
10295         (print_objfile_statistics, maintenance_print_objfiles)
10296         (maintenance_info_symtabs, maintenance_check_symtabs)
10297         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10298         all_objfiles.
10299         * source.c (forget_cached_source_info): Use all_objfiles.
10300         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10301         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10302         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10303         * objfiles.c (update_section_map): Use all_objfiles.
10304         (shared_objfile_contains_address_p): Likewise.
10305         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10306         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10307
10308 2019-01-09  Tom Tromey  <tom@tromey.com>
10309
10310         * common/next-iterator.h: New file.
10311         * objfiles.h (class all_objfiles): New.
10312         (struct objfile_iterator): New.
10313
10314 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10315
10316         * NEWS: Move the description of the changed "frame", "select-frame",
10317          and "info frame" commands to the Changed commands section.
10318
10319 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10320
10321         * gdbtypes.c (check_stub_method_group): Remove handling of old
10322         mangling schemes.
10323         * linespec.c (find_methods): Likewise.
10324         * stabsread.c (read_member_functions): Likewise.
10325         * valops.c (search_struct_method): Likewise.
10326         (value_struct_elt_for_reference): Likewise.
10327         * NEWS: Mention this change.
10328
10329 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10330
10331         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10332         print_source_lines.
10333         * source.c (print_source_lines_base): Update line number check.
10334         (print_source_lines): New function.
10335         (source_lines_range::source_lines_range): New function.
10336         * source.h (class source_lines_range): New class.
10337         (print_source_lines): New declaration.
10338
10339 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10340
10341         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10342
10343 2019-01-08  Tom Tromey  <tom@tromey.com>
10344             Simon Marchi  <simon.marchi@ericsson.com>
10345
10346         PR gdb/24060
10347         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10348         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10349         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10350         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10351         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10352         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10353
10354 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10355
10356         * source.c (select_source_symtab): Move header comment to
10357         declaration in source.h.
10358         (forget_cached_source_info_for_objfile): Likewise.
10359         (forget_cached_source_info): Likewise.
10360         (identify_source_line): Likewise.
10361         * source.h (identify_source_line): Move declaration from symtab.h
10362         and add comment from source.c
10363         (print_source_lines): Likewise.
10364         (forget_cached_source_info_for_objfile): Likewise.
10365         (forget_cached_source_info): Likewise.
10366         (select_source_symtab): Likewise.
10367         (enum print_source_lines_flag): Move definition from symtab.h.
10368         * symtab.h (identify_source_line): Move declaration to source.h.
10369         (print_source_lines): Likewise.
10370         (forget_cached_source_info_for_objfile): Likewise.
10371         (forget_cached_source_info): Likewise.
10372         (select_source_symtab): Likewise.
10373         (enum print_source_lines_flag): Move definition to source.h.
10374         * tui/tui-hooks.c: Add 'source.h' include.
10375
10376 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10377
10378         * source.c (print_source_lines_base): Handle requests to print
10379         reverse line number sequences, and guard against empty lines
10380         string.
10381
10382 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10383
10384         * source.c (print_source_lines_base): Fix skip of '\r' if next
10385         character is '\n'.
10386
10387 2019-01-06  Tom Tromey  <tom@tromey.com>
10388
10389         * c-exp.y (struct c_parse_state) <macro_original_text,
10390         expansion_obstack>: New member.
10391         (macro_original_text, expansion_obstack): Remove globals.
10392         (scan_macro_expansion, scanning_macro_expansion)
10393         (finished_macro_expansion): Update.
10394         (scan_macro_cleanup): Remove.
10395         (yylex, c_parse): Update.
10396
10397 2019-01-06  Tom Tromey  <tom@tromey.com>
10398
10399         * c-exp.y (struct c_parse_state) <strings>: New member.
10400         (operator_stoken): Update.
10401
10402 2019-01-06  Tom Tromey  <tom@tromey.com>
10403
10404         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10405         (union type_stack_elt) <typelist_val>: Now a pointer to
10406         std::vector.
10407         (type_stack_cleanup): Don't declare.
10408         (push_typelist): Update.
10409         * parse.c (pop_typelist): Return a std::vector.
10410         (push_typelist): Take a std::vector.
10411         (follow_types): Update.  Do not free args.
10412         (type_stack_cleanup): Remove.
10413         * c-exp.y (struct c_parse_state): New.
10414         (cpstate): New global.
10415         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10416         (nonempty_typelist): Update.
10417         (func_mod): Create a new vector.
10418         (c_parse): Create a c_parse_state.
10419         (check_parameter_typelist): Do not delete params.
10420         (function_method): Update.  Do not delete type_list.
10421
10422 2019-01-06  Tom Tromey  <tom@tromey.com>
10423
10424         PR gdb/28155:
10425         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10426         check_typedef.
10427         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10428         (print_return_value): Likewise.
10429
10430 2019-01-05  Tom Tromey  <tom@tromey.com>
10431
10432         * contrib/cleanup_check.py: Remove.
10433         * contrib/gcc-with-excheck: Remove.
10434         * contrib/exsummary.py: Remove.
10435         * contrib/excheck.py: Remove.
10436
10437 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10438
10439         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10440         NULL. Initialize tpprev to NULL instead of assigning it
10441         to NULL on the next statement.
10442         * windows-nat.c (windows_delete_thread): Remove check for
10443         main_thread_id before printing thread exit notifications.
10444         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10445         Remove thread ID check against main_thread_id.
10446         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10447         windows_delete_thread.
10448         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10449
10450 2019-01-04  Tom Tromey  <tom@tromey.com>
10451
10452         * compile/compile.c (_initialize_compile): Use upper case for
10453         metasyntactic variables.
10454         * symmisc.c (_initialize_symmisc): Use upper case for
10455         metasyntactic variables.
10456         * psymtab.c (_initialize_psymtab): Use upper case for
10457         metasyntactic variables.
10458         * demangle.c (demangle_command): Use upper case for metasyntactic
10459         variables.
10460         (_initialize_demangler): Likewise.
10461         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10462         variables.
10463
10464 2019-01-03  Tom Tromey  <tom@tromey.com>
10465
10466         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10467
10468 2019-01-03  Tom Tromey  <tom@tromey.com>
10469
10470         * python/py-symtab.c (salpy_str): Update.
10471         (struct salpy_sal_object) <symtab>: Now a PyObject.
10472         (salpy_dealloc): Update.
10473         (del_objfile_sal): Use gdbpy_ref.
10474
10475 2019-01-03  Tom Tromey  <tom@tromey.com>
10476
10477         * python/py-type.c (convert_field): Use new_reference.  Return
10478         gdbpy_ref.
10479         (make_fielditem): Return gdbpy_ref.
10480         (typy_fields): Update.
10481         (typy_getitem): Update.
10482         (field_name): Return gdbpy_ref.  Use new_reference.
10483         (typy_iterator_iternext): Update.
10484
10485 2019-01-03  Tom Tromey  <tom@tromey.com>
10486
10487         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10488
10489 2019-01-03  Tom Tromey  <tom@tromey.com>
10490
10491         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10492         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10493         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10494         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10495         (pspy_set_type_printers): Likewise.
10496         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10497         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10498         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10499         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10500         (objfpy_set_type_printers): Likewise.
10501
10502 2019-01-03  Tom Tromey  <tom@tromey.com>
10503
10504         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10505         (gdbpy_print_stack): Use gdbpy_err_fetch.
10506         * python/python-internal.h (class gdbpy_err_fetch): New class.
10507         (class gdbpy_enter) <m_error_type, m_error_value,
10508         m_error_traceback>: Remove.
10509         <m_error>: New member.
10510         (gdbpy_exception_to_string): Don't declare.
10511         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10512         * python/py-value.c (convert_value_from_python): Use
10513         gdbpy_err_fetch.
10514         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10515         gdbpy_exception_to_string.
10516         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10517         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10518         gdbpy_err_fetch.
10519
10520 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10521
10522         * linux-nat.c (delete_lwp_cleanup): Delete.
10523         (struct lwp_deleter): New struct.
10524         (lwp_info_up): New typedef.
10525         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10526         lwp_info_up.
10527
10528 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10529
10530         * linux-fork.c (class scoped_switch_fork_info): New class.
10531         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10532
10533 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10534
10535         * valops.c (find_overload_match): Remove use of null_cleanup, and
10536         calls to do_cleanups.
10537
10538 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10539
10540         * compile/compile-cplus-types.c
10541         (compile_cplus_instance::decl_name): Handle changes to
10542         cp_func_name.
10543         * cp-support.c (cp_func_name): Update header comment, update
10544         return type.
10545         * cp-support.h (cp_func_name): Update return type in declaration.
10546         * valops.c (find_overload_match): Move temp_func local to top
10547         level of function and change its type.  Use temp_func to hold and
10548         delete temporary string obtained from cp_func_name.
10549
10550 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10551
10552         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10553         gdb::char_vector, remove cleanup, and update uses of `msg`.
10554
10555 2019-01-03  Jim Wilson  <jimw@sifive.com>
10556
10557         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10558
10559 2019-01-02  Tom Tromey  <tom@tromey.com>
10560
10561         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10562         (tdesc_parse_xml): Remove cleanups.
10563         * target-descriptions.h (make_cleanup_free_target_description):
10564         Don't declare.
10565         (target_desc_deleter): New struct.
10566         (target_desc_up): New typedef.
10567         * target-descriptions.c (target_desc_deleter::operator()): Rename
10568         from free_target_description.
10569         (make_cleanup_free_target_description): Remove.
10570
10571 2019-01-02  Tom Tromey  <tom@tromey.com>
10572
10573         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10574         constructor, destructor.
10575         (linespec_parser): Remove typedef.
10576         (~linespec_parser): Rename from linespec_parser_delete.
10577         (linespec_lex_to_end, linespec_complete_label)
10578         (linespec_complete): Update.
10579         (decode_line_full): Remove cleanups.
10580         (decode_line_1): Update.
10581
10582 2019-01-02  Tom Tromey  <tom@tromey.com>
10583
10584         * python/python-internal.h (inferior_to_inferior_object): Change
10585         return type.
10586         * python/py-exitedevent.c (create_exited_event_object): Update.
10587         * python/py-inferior.c (inferior_to_inferior_object): Return
10588         gdbpy_ref.
10589         (python_new_inferior, python_inferior_deleted)
10590         (thread_to_thread_object, delete_thread_object)
10591         (build_inferior_list, gdbpy_selected_inferior): Update.
10592         * python/py-infthread.c (create_thread_object): Update.  Also fail
10593         if inferior_to_inferior_object fails.
10594
10595 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10596
10597         * inferior.h (class inferior) <displaced_step_state>: New field.
10598         * infrun.h (struct displaced_step_state): Move here from
10599         infrun.c.  Initialize fields, add constructor.
10600         <inf>: Remove field.
10601         <reset>: New method.
10602         * infrun.c (struct displaced_step_inferior_state): Move to
10603         infrun.h.
10604         (displaced_step_inferior_states): Remove.
10605         (get_displaced_stepping_state): Adust.
10606         (displaced_step_in_progress_any_inferior): Adjust.
10607         (displaced_step_in_progress_thread): Adjust.
10608         (displaced_step_in_progress): Adjust.
10609         (add_displaced_stepping_state): Remove.
10610         (get_displaced_step_closure_by_addr): Adjust.
10611         (remove_displaced_stepping_state): Remove.
10612         (infrun_inferior_exit): Call displaced_step_state.reset.
10613         (use_displaced_stepping): Don't check for NULL.
10614         (displaced_step_prepare_throw): Call
10615         get_displaced_stepping_state.
10616         (displaced_step_fixup): Don't check for NULL.
10617         (prepare_for_detach): Don't check for NULL.
10618
10619 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10620
10621         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10622          in case of call that did not complete.
10623
10624 2019-01-02  Andrey Utkin  <autkin@undo.io>
10625
10626         * symfile.c (find_separate_debug_file): Fix search of debug files for
10627         remote debuggee.
10628
10629 2019-01-02  Tom Tromey  <tom@tromey.com>
10630
10631         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10632         indentation.
10633         * python/py-frame.c (frapy_older): Remove cast.
10634         (frapy_newer): Likewise.
10635         * python/py-breakpoint.c (local_setattro): Remove cast.
10636         * python/py-arch.c (archpy_name): Remove local variable.
10637         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10638
10639 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10640
10641         * unittests/basic_string_view/element_access/char/empty.cc:
10642         Fix year range in copyright header.
10643
10644 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10645
10646         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10647         Delete.
10648         <operator==>: Update with for removed field.
10649         <hash>: Likewise.
10650         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10651         <isa_features>: ...this.
10652         <abi_features>: New field.
10653         (riscv_isa_flen): Update comment.
10654         (riscv_abi_xlen): New declaration.
10655         (riscv_abi_flen): New declaration.
10656         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10657         isa_features.
10658         (riscv_abi_xlen): New function.
10659         (riscv_isa_flen): Update to get answer from isa_features.
10660         (riscv_abi_flen): New function.
10661         (riscv_has_fp_abi): Update to get answer from abi_features.
10662         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10663         xlen and flen.
10664         (riscv_call_info) <xlen, flen>: Update comment.
10665         (riscv_call_arg_struct): Remove invalid assertions
10666         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10667         is removed.
10668         (riscv_gdbarch_init): Gather isa features and abi features
10669         separately, ensure both match on the gdbarch when reusing an old
10670         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10671         a target with 64-bit float hardware.
10672
10673 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10674
10675         * source.c (search_command_helper): Stop reverse search
10676         when line 1 has been searched.
10677
10678 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10679
10680         * record-full.c (record_full_base_target::close): Rewrite
10681         record_full_core_buf_list free logic.
10682
10683 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10684
10685         * break-catch-syscall.c (print_one_catch_syscall): xfree
10686         the last text.
10687
10688 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10689
10690         * top.c (print_gdb_version): Update Copyright year in version
10691         message.
10692
10693 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10694
10695         Update copyright year range in all GDB files.
10696
10697 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10698
10699         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10700
10701 For older changes see ChangeLog-2018.
10702 \f
10703 Local Variables:
10704 mode: change-log
10705 left-margin: 8
10706 fill-column: 74
10707 version-control: never
10708 coding: utf-8
10709 End:
10710