gdb/ChangeLog

   1 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
   2
   3         PR/24325
   4         * source-cache.c: #undef open and close, to avoid unresolved
   5         externals during linking.
   6
   7 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
   8
   9         Support styling on native MS-Windows console
  10
  11         PR/24315
  12         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
  13         on MS-Windows if $TERM is not defined.
  14
  15         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
  16
  17         * posix-hdep.c (gdb_console_fputs):
  18         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
  19         functions.
  20         * ui-file.h (gdb_console_fputs): Add prototype.
  21
  22         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
  23         back to fputs only if the former returns zero.
  24
  25 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
  26             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  27
  28         PR gdb/8527
  29         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
  30         set_sigint_trap, clear_sigint_trap.
  31
  32 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  33
  34         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
  35         for-loop range, to avoid compiler warnings.
  36
  37         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
  38         avoid compiler warnings about unused variables.
  39
  40 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  41
  42         * NEWS: Mention end of support for native debugging on MS-Windows
  43         before XP.
  44
  45 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  46
  47         PR gdb/24292
  48         * common/netstuff.c:
  49         * gdbserver/gdbreplay.c
  50         * gdbserver/remote-utils.c:
  51         * ser-tcp.c:
  52         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
  53         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
  54         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
  55         'getaddrinfo' and 'freeaddrinfo' were not available before
  56         Windows XP, and mingw.org's MinGW headers by default define
  57         _WIN32_WINNT to 0x500.
  58
  59 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
  60
  61         * NEWS: Note minimum Python version.
  62
  63 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  64
  65         * version.in: Set GDB version number to 8.2.90.DATE-git.
  66
  67 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  68
  69         GDB 8.2.90 released.
  70
  71 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  72
  73         * version.in: Set GDB version number to 8.2.90.
  74
  75 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  76
  77         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
  78
  79 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  80
  81         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
  82         * version.in: Bump version to 8.2.90.DATE-git.
  83
  84 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
  85
  86         * aix-thread.c (ptid_cmp): Remove unused variable.
  87         (get_signaled_thread): Likewise.
  88         (store_regs_user_thread): Likewise.
  89         (store_regs_kernel_thread): Likewise.
  90         (fetch_regs_kernel_thread): Remove shadowed variable.
  91
  92 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  93
  94         * features/riscv/32bit-cpu.xml: Add register numbers.
  95         * features/riscv/32bit-fpu.c: Regenerate.
  96         * features/riscv/32bit-fpu.xml: Add register numbers.
  97         * features/riscv/64bit-cpu.xml: Add register numbers.
  98         * features/riscv/64bit-fpu.c: Regenerate.
  99         * features/riscv/64bit-fpu.xml: Add register numbers.
 100
 101 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 102
 103         * NEWS: Mention two argument form of gdb.Value constructor.
 104         * python/py-value.c (convert_buffer_and_type_to_value): New
 105         function.
 106         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 107         Add support for handling an optional second argument.  Call
 108         convert_buffer_and_type_to_value as appropriate.
 109         * python/python-internal.h (Py_buffer_deleter): New struct.
 110         (Py_buffer_up): New typedef.
 111
 112 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 113
 114         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 115         instead of releasing ownership.
 116
 117 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 118
 119         * dwarf2read.c (open_and_init_dwp_file): Call
 120         elf_numsections instead of bfd_count_sections to initialize
 121         dwp_file->num_sections.
 122
 123 2019-02-25  Tom Tromey  <tromey@adacore.com>
 124
 125         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 126
 127 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 128
 129         * gcore.in: Add '--readnever' option when invoking GDB.
 130
 131 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 132
 133         * MAINTAINERS: Update my email address.
 134
 135 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 136
 137         * build-id.c (build_id_to_debug_bfd_1): New function.
 138         (build_id_to_debug_bfd): Look for separate debug file in
 139         sysroot.
 140
 141 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 142
 143         * gdbarch.sh: Update the copyright year range that is placed into
 144         generated files.
 145
 146 2019-02-22  Keith Seitz  <keiths@redhat.com>
 147
 148         PR symtab/23853
 149         * linespec.c (create_sals_line_offset): Search for the default
 150         symtab's filename instead of its fullname.
 151
 152 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 153
 154         * NEWS: Update style defaults.
 155
 156 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 157
 158         * main.c (captured_main_1): Disable styling in batch mode.
 159
 160 2019-02-20  Tom Tromey  <tom@tromey.com>
 161
 162         * symtab.c (symtab_symbol_info): Fix typos.
 163
 164 2019-02-20  Tom Tromey  <tromey@adacore.com>
 165
 166         * findcmd.c (_initialize_mem_search): Use upper case for
 167         metasyntactic variables.
 168
 169 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 170
 171         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 172         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 173
 174 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 175
 176         * top.h (source_file_name): Change to std::string.
 177         * top.c (source_file_name): Likewise.
 178         (command_line_input): Adjust.
 179         * cli/cli-script.c (script_from_file): Adjust.
 180
 181 2019-02-19  Tom Tromey  <tromey@adacore.com>
 182
 183         * ravenscar-thread.c
 184         (ravenscar_thread_target::update_thread_list): Don't call
 185         ada_build_task_list.
 186         * ada-lang.h (ada_build_task_list): Don't declare.
 187         * ada-tasks.c (struct ada_tasks_inferior_data)
 188         <task_list_valid_p>: Now bool.
 189         (read_known_tasks, ada_task_list_changed)
 190         (ada_tasks_invalidate_inferior_data): Update.
 191         (read_known_tasks_array): Return bool.
 192         (read_known_tasks_list): Likewise.
 193         (read_known_tasks): Return void.
 194         (ada_build_task_list): Now static.
 195
 196 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 197
 198         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 199         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 200
 201 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 202
 203         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 204         variant for ada_tasks_pspace_data_handle and
 205         ada_tasks_inferior_data_handle.
 206         (ada_tasks_pspace_data_cleanup): New function.
 207         (ada_tasks_inferior_data_cleanup): New function.
 208
 209 2019-02-17  Tom Tromey  <tom@tromey.com>
 210
 211         * macrotab.h (macro_source_fullname): Return a std::string.
 212         * macrotab.c (macro_include, check_for_redefinition)
 213         (macro_undef, macro_lookup_definition, foreach_macro)
 214         (foreach_macro_in_scope): Update.
 215         (macro_source_fullname): Return a std::string.
 216         * macrocmd.c (show_pp_source_pos): Update.
 217
 218 2019-02-17  Tom Tromey  <tom@tromey.com>
 219
 220         * macrocmd.c (show_pp_source_pos): Style the file names.
 221
 222 2019-02-17  Tom Tromey  <tom@tromey.com>
 223
 224         PR tui/24197:
 225         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 226
 227 2019-02-17  Tom Tromey  <tom@tromey.com>
 228
 229         * ada-lang.c (user_select_syms): Use filtered printing.
 230         * utils.c (wrap_style): New global.
 231         (desired_style): Remove.
 232         (emit_style_escape): Add stream parameter.
 233         (set_output_style, reset_terminal_style, prompt_for_continue):
 234         Update.
 235         (flush_wrap_buffer): Only flush gdb_stdout.
 236         (wrap_here): Set wrap_style.
 237         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 238         treat escape sequences as a character.  Change when wrap buffer is
 239         flushed.
 240         (fputs_styled): Do not set the output style when the default is
 241         requested.
 242         * ui-style.h (struct ui_file_style) <is_default>: New method.
 243         * source.c (print_source_lines_base): Emit escape sequences in one
 244         piece.
 245
 246 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 247
 248         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 249         integers and enumeration types.
 250
 251 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 252
 253         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 254         instead of lookup_symbol_in_language
 255         (do_exact_match): New function.
 256         (ada_get_symbol_name_matcher): Return do_exact_match when
 257         doing a verbatim match.
 258
 259 2019-02-15  Tom Tromey  <tromey@adacore.com>
 260
 261         * ravenscar-thread.c (ravenscar_thread_target::resume)
 262         (ravenscar_thread_target::wait): Special case wildcard requests.
 263
 264 2019-02-15  Tom Tromey  <tromey@adacore.com>
 265
 266         * ravenscar-thread.c (base_ptid): Remove.
 267         (struct ravenscar_thread_target) <close>: New method.
 268         <m_base_ptid>: New member.
 269         <update_inferior_ptid, active_task, task_is_currently_active,
 270         runtime_initialized>: Declare methods.
 271         <ravenscar_thread_target>: Add constructor.
 272         (ravenscar_thread_target::task_is_currently_active)
 273         (ravenscar_thread_target::update_inferior_ptid)
 274         (ravenscar_runtime_initialized): Rename.  Now methods.
 275         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 276         (ravenscar_thread_target::update_thread_list): Update.
 277         (ravenscar_thread_target::active_task): Now method.
 278         (ravenscar_thread_target::store_registers)
 279         (ravenscar_thread_target::prepare_to_store)
 280         (ravenscar_thread_target::prepare_to_store)
 281         (ravenscar_thread_target::mourn_inferior): Update.
 282         (ravenscar_inferior_created): Use "new" to create target.
 283         (ravenscar_thread_target::get_ada_task_ptid): Update.
 284         (_initialize_ravenscar): Don't initialize base_ptid.
 285         (ravenscar_ops): Remove global.
 286
 287 2019-02-15  Tom Tromey  <tromey@adacore.com>
 288
 289         * target.h (push_target): Declare new overload.
 290         * target.c (push_target): New overload, taking an rvalue reference.
 291         * remote.c (remote_target::open_1): Use push_target overload.
 292         * corelow.c (core_target_open): Use push_target overload.
 293
 294 2019-02-15  Tom Tromey  <tromey@adacore.com>
 295
 296         * ravenscar-thread.c (is_ravenscar_task)
 297         (ravenscar_task_is_currently_active): Return bool.
 298         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 299         (_initialize_ravenscar): Remove "(void)".
 300         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 301         Return bool.
 302
 303 2019-02-15  Tom Tromey  <tromey@adacore.com>
 304
 305         * ravenscar-thread.c (ravenscar_runtime_initializer)
 306         (has_ravenscar_runtime, get_running_thread_id)
 307         (ravenscar_thread_target::resume): Fix indentation.
 308
 309 2019-02-15  Tom Tromey  <tromey@adacore.com>
 310
 311         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 312         from ravenscar_arch_ops.
 313         (sparc_ravenscar_ops::fetch_registers)
 314         (sparc_ravenscar_ops::store_registers): Now methods.
 315         (sparc_ravenscar_prepare_to_store): Remove.
 316         (sparc_ravenscar_ops): Redefine.
 317         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 318         methods and destructor.  Remove members.
 319         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 320         (ravenscar_thread_target::store_registers)
 321         (ravenscar_thread_target::prepare_to_store): Update.
 322         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 323         Remove.
 324         (struct ppc_ravenscar_powerpc_ops): Derive from
 325         ravenscar_arch_ops.
 326         (ppc_ravenscar_powerpc_ops::fetch_registers)
 327         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 328         (ppc_ravenscar_powerpc_ops): Redefine.
 329         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 330         (ppc_ravenscar_e500_ops::fetch_registers)
 331         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 332         (ppc_ravenscar_e500_ops): Redefine.
 333         * aarch64-ravenscar-thread.c
 334         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 335         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 336         (aarch64_ravenscar_fetch_registers)
 337         (aarch64_ravenscar_store_registers): Now methods.
 338         (aarch64_ravenscar_ops): Redefine.
 339
 340 2019-02-15  Tom Tromey  <tromey@adacore.com>
 341
 342         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 343         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 344         (ravenscar_thread_target::stopped_by_watchpoint)
 345         (ravenscar_thread_target::stopped_data_address)
 346         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 347
 348 2019-02-15  Tom Tromey  <tromey@adacore.com>
 349
 350         * ravenscar-thread.c: Fix some typos.
 351
 352 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 353             Tom Tromey  <tromey@adacore.com>
 354
 355         * ada-lang.c (ada_exception_sal): Change addr_string to a
 356         std::string.
 357         (create_ada_exception_catchpoint): Update.
 358
 359 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 360             Tom Tromey  <tromey@adacore.com>
 361
 362         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 363         (bp_location_ops): Remove.
 364         (base_breakpoint_allocate_location): Update.
 365         (free_bp_location): Update.
 366         * ada-lang.c (class ada_catchpoint_location)
 367         <ada_catchpoint_location>: Remove ops parameter.
 368         (ada_catchpoint_location_dtor): Remove.
 369         (ada_catchpoint_location_ops): Remove.
 370         (allocate_location_exception): Update.
 371         * breakpoint.h (struct bp_location_ops): Remove.
 372         (class bp_location) <bp_location>: Remove bp_location_ops
 373         parameter.
 374         <~bp_location>: Add destructor.
 375         <ops>: Remove.
 376
 377 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 378             Pedro Alves  <palves@redhat.com>
 379
 380         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 381         'PATH_MAX'.
 382
 383 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 384             Samuel Thibault  <samuel.thibault@gnu.org>
 385             Thomas Schwinge  <thomas@codesourcery.com>
 386
 387         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 388         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 389
 390 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 391
 392         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 393         (check_empty): Use "const char *".
 394
 395         * gnu-nat.c (gnu_nat_target::detach): Instead of
 396         'detach_inferior (pid)' call
 397         'detach_inferior (find_inferior_pid (pid))'.
 398
 399         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 400         'nat/fork-inferior.o'.
 401         * gnu-nat.c: #include "nat/fork-inferior.h".
 402
 403         * gnu-nat.c (gnu_nat_target::detach): Instead of
 404         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 405         * gnu-nat.h: #include "inf-child.h".
 406         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 407         'i386_gnu_nat_target::fetch_registers'.
 408         (gnu_store_registers): Rename/move to
 409         'i386_gnu_nat_target::store_registers'.
 410
 411         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 412         * gnu-nat.h (mach_thread_info): New function.
 413         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 414
 415         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 416
 417 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 418
 419         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 420
 421 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 422
 423         * windows-nat.c (windows_add_thread): Add new parameter
 424         "main_thread_p" with default value set to false.  Update
 425         function documentation as well as all callers.
 426         (windows_delete_thread): Likewise.
 427         (fake_create_process): Update call to windows_add_thread.
 428         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 429         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 430         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 431         call to windows_delete_thread.
 432
 433 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 434
 435         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 436
 437 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 438
 439         * symfile.c (find_separate_debug_file): Use canonical path of
 440         sysroot with child_path instead of gdb_sysroot if it is valid.
 441
 442 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 443
 444         * symfile.c (find_separate_debug_file): Use child_path to
 445         determine if an object file is under a sysroot.
 446
 447 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 448
 449         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 450         unittests/child-path-selftests.c.
 451         * common/pathstuff.c (child_path): New function.
 452         * common/pathstuff.h (child_path): New prototype.
 453         * unittests/child-path-selftests.c: New file.
 454
 455 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 456
 457         * symfile.c (find_separate_debug_file): Look for separate debug
 458         files in debug directories under the sysroot.
 459
 460 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 461
 462         * symtab.h (struct minimal_symbol data_p): New const method.
 463         (struct minimal_symbol text_p): Likewise.
 464         * symtab.c (output_source_filename): Use file name style
 465         to print file name.
 466         (print_symbol_info): Likewise.
 467         (print_msymbol_info): Use address style to print addresses.
 468         Use function name style to print executable text symbols.
 469         (expand_symtab_containing_pc): Use data_p.
 470         (find_pc_sect_compunit_symtab): Likewise.
 471
 472 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 473
 474         * breakpoint.c (describe_other_breakpoints): Use address style
 475         to print addresses.
 476         (say_where): Likewise.
 477
 478 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 479
 480         * ada-typeprint.c (print_func_type): Print function name
 481         style to print function name.
 482         * c-typeprint.c (c_print_type_1): Likewise.
 483
 484 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 485
 486         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 487         for execve.
 488
 489 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 490
 491         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 492         type_stack.
 493
 494 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 495
 496         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 497         TYPE_CODE_REF types.
 498
 499 2019-02-08  Jim Wilson  <jimw@sifive.com>
 500
 501         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 502         (riscv_linux_fregset): New.
 503         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 504
 505 2019-02-07  Tom Tromey  <tom@tromey.com>
 506
 507         * thread.c (thread_cancel_execution_command): Update.
 508         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 509         methods.
 510         (struct thread_fsm_ops): Remove.
 511         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 512         (thread_fsm_should_stop, thread_fsm_return_value)
 513         (thread_fsm_set_finished, thread_fsm_finished_p)
 514         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 515         Don't declare.
 516         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 517         * infrun.c (clear_proceed_status_thread)
 518         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 519         (print_stop_event): Update.
 520         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 521         Add constructor.
 522         (step_command_fsm_ops): Remove.
 523         (new_step_command_fsm): Remove.
 524         (step_1): Update.
 525         (step_command_fsm::should_stop): Rename from
 526         step_command_fsm_should_stop.
 527         (step_command_fsm::clean_up): Rename from
 528         step_command_fsm_clean_up.
 529         (step_command_fsm::do_async_reply_reason): Rename from
 530         step_command_fsm_async_reply_reason.
 531         (struct until_next_fsm): Inherit from thread_fsm.  Add
 532         constructor.
 533         (until_next_fsm_ops): Remove.
 534         (new_until_next_fsm): Remove.
 535         (until_next_fsm::should_stop): Rename from
 536         until_next_fsm_should_stop.
 537         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 538         (until_next_fsm::do_async_reply_reason): Rename from
 539         until_next_fsm_async_reply_reason.
 540         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 541         constructor.  Change type of breakpoint.
 542         (finish_command_fsm_ops): Remove.
 543         (new_finish_command_fsm): Remove.
 544         (finish_command_fsm::should_stop): Rename from
 545         finish_command_fsm_should_stop.
 546         (finish_command_fsm::clean_up): Rename from
 547         finish_command_fsm_clean_up.
 548         (finish_command_fsm::return_value): Rename from
 549         finish_command_fsm_return_value.
 550         (finish_command_fsm::do_async_reply_reason): Rename from
 551         finish_command_fsm_async_reply_reason.
 552         (finish_command): Update.
 553         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 554         Add constructor.
 555         (call_thread_fsm_ops): Remove.
 556         (call_thread_fsm::call_thread_fsm): Rename from
 557         new_call_thread_fsm.
 558         (call_thread_fsm::should_stop): Rename from
 559         call_thread_fsm_should_stop.
 560         (call_thread_fsm::should_notify_stop): Rename from
 561         call_thread_fsm_should_notify_stop.
 562         (run_inferior_call, call_function_by_hand_dummy): Update.
 563         * cli/cli-interp.c (should_print_stop_to_console): Update.
 564         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 565         Add constructor.  Change type of location_breakpoint,
 566         caller_breakpoint.
 567         (until_break_fsm_ops): Remove.
 568         (new_until_break_fsm): Remove.
 569         (until_break_fsm::should_stop): Rename from
 570         until_break_fsm_should_stop.
 571         (until_break_fsm::clean_up): Rename from
 572         until_break_fsm_clean_up.
 573         (until_break_fsm::do_async_reply_reason): Rename from
 574         until_break_fsm_async_reply_reason.
 575         (until_break_command): Update.
 576         * thread-fsm.c: Remove.
 577         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 578
 579 2019-02-07  Tom Tromey  <tom@tromey.com>
 580
 581         * yy-remap.h: Add include guard.
 582         * xtensa-tdep.h: Add include guard.
 583         * xcoffread.h: Rename include guard.
 584         * varobj-iter.h: Add include guard.
 585         * tui/tui.h: Rename include guard.
 586         * tui/tui-winsource.h: Rename include guard.
 587         * tui/tui-wingeneral.h: Rename include guard.
 588         * tui/tui-windata.h: Rename include guard.
 589         * tui/tui-win.h: Rename include guard.
 590         * tui/tui-stack.h: Rename include guard.
 591         * tui/tui-source.h: Rename include guard.
 592         * tui/tui-regs.h: Rename include guard.
 593         * tui/tui-out.h: Rename include guard.
 594         * tui/tui-layout.h: Rename include guard.
 595         * tui/tui-io.h: Rename include guard.
 596         * tui/tui-hooks.h: Rename include guard.
 597         * tui/tui-file.h: Rename include guard.
 598         * tui/tui-disasm.h: Rename include guard.
 599         * tui/tui-data.h: Rename include guard.
 600         * tui/tui-command.h: Rename include guard.
 601         * tic6x-tdep.h: Add include guard.
 602         * target/waitstatus.h: Rename include guard.
 603         * target/wait.h: Rename include guard.
 604         * target/target.h: Rename include guard.
 605         * target/resume.h: Rename include guard.
 606         * target-float.h: Rename include guard.
 607         * stabsread.h: Add include guard.
 608         * rs6000-tdep.h: Add include guard.
 609         * riscv-fbsd-tdep.h: Add include guard.
 610         * regformats/regdef.h: Rename include guard.
 611         * record.h: Rename include guard.
 612         * python/python.h: Rename include guard.
 613         * python/python-internal.h: Rename include guard.
 614         * python/py-stopevent.h: Rename include guard.
 615         * python/py-ref.h: Rename include guard.
 616         * python/py-record.h: Rename include guard.
 617         * python/py-record-full.h: Rename include guard.
 618         * python/py-record-btrace.h: Rename include guard.
 619         * python/py-instruction.h: Rename include guard.
 620         * python/py-events.h: Rename include guard.
 621         * python/py-event.h: Rename include guard.
 622         * procfs.h: Add include guard.
 623         * proc-utils.h: Add include guard.
 624         * p-lang.h: Add include guard.
 625         * or1k-tdep.h: Rename include guard.
 626         * observable.h: Rename include guard.
 627         * nto-tdep.h: Rename include guard.
 628         * nat/x86-linux.h: Rename include guard.
 629         * nat/x86-linux-dregs.h: Rename include guard.
 630         * nat/x86-gcc-cpuid.h: Add include guard.
 631         * nat/x86-dregs.h: Rename include guard.
 632         * nat/x86-cpuid.h: Rename include guard.
 633         * nat/ppc-linux.h: Rename include guard.
 634         * nat/mips-linux-watch.h: Rename include guard.
 635         * nat/linux-waitpid.h: Rename include guard.
 636         * nat/linux-ptrace.h: Rename include guard.
 637         * nat/linux-procfs.h: Rename include guard.
 638         * nat/linux-osdata.h: Rename include guard.
 639         * nat/linux-nat.h: Rename include guard.
 640         * nat/linux-namespaces.h: Rename include guard.
 641         * nat/linux-btrace.h: Rename include guard.
 642         * nat/glibc_thread_db.h: Rename include guard.
 643         * nat/gdb_thread_db.h: Rename include guard.
 644         * nat/gdb_ptrace.h: Rename include guard.
 645         * nat/fork-inferior.h: Rename include guard.
 646         * nat/amd64-linux-siginfo.h: Rename include guard.
 647         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 648         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 649         * nat/aarch64-linux.h: Rename include guard.
 650         * nat/aarch64-linux-hw-point.h: Rename include guard.
 651         * mn10300-tdep.h: Add include guard.
 652         * mips-linux-tdep.h: Add include guard.
 653         * mi/mi-parse.h: Rename include guard.
 654         * mi/mi-out.h: Rename include guard.
 655         * mi/mi-main.h: Rename include guard.
 656         * mi/mi-interp.h: Rename include guard.
 657         * mi/mi-getopt.h: Rename include guard.
 658         * mi/mi-console.h: Rename include guard.
 659         * mi/mi-common.h: Rename include guard.
 660         * mi/mi-cmds.h: Rename include guard.
 661         * mi/mi-cmd-break.h: Rename include guard.
 662         * m2-lang.h: Add include guard.
 663         * location.h: Rename include guard.
 664         * linux-record.h: Rename include guard.
 665         * linux-nat.h: Add include guard.
 666         * linux-fork.h: Add include guard.
 667         * i386-darwin-tdep.h: Rename include guard.
 668         * hppa-linux-offsets.h: Add include guard.
 669         * guile/guile.h: Rename include guard.
 670         * guile/guile-internal.h: Rename include guard.
 671         * gnu-nat.h: Rename include guard.
 672         * gdb-stabs.h: Rename include guard.
 673         * frv-tdep.h: Add include guard.
 674         * f-lang.h: Add include guard.
 675         * event-loop.h: Add include guard.
 676         * darwin-nat.h: Rename include guard.
 677         * cp-abi.h: Rename include guard.
 678         * config/sparc/nm-sol2.h: Rename include guard.
 679         * config/nm-nto.h: Rename include guard.
 680         * config/nm-linux.h: Add include guard.
 681         * config/i386/nm-i386gnu.h: Rename include guard.
 682         * config/djgpp/nl_types.h: Rename include guard.
 683         * config/djgpp/langinfo.h: Rename include guard.
 684         * compile/gcc-cp-plugin.h: Add include guard.
 685         * compile/gcc-c-plugin.h: Add include guard.
 686         * compile/compile.h: Rename include guard.
 687         * compile/compile-object-run.h: Rename include guard.
 688         * compile/compile-object-load.h: Rename include guard.
 689         * compile/compile-internal.h: Rename include guard.
 690         * compile/compile-cplus.h: Rename include guard.
 691         * compile/compile-c.h: Rename include guard.
 692         * common/xml-utils.h: Rename include guard.
 693         * common/x86-xstate.h: Rename include guard.
 694         * common/version.h: Rename include guard.
 695         * common/vec.h: Rename include guard.
 696         * common/tdesc.h: Rename include guard.
 697         * common/selftest.h: Rename include guard.
 698         * common/scoped_restore.h: Rename include guard.
 699         * common/scoped_mmap.h: Rename include guard.
 700         * common/scoped_fd.h: Rename include guard.
 701         * common/safe-iterator.h: Rename include guard.
 702         * common/run-time-clock.h: Rename include guard.
 703         * common/refcounted-object.h: Rename include guard.
 704         * common/queue.h: Rename include guard.
 705         * common/ptid.h: Rename include guard.
 706         * common/print-utils.h: Rename include guard.
 707         * common/preprocessor.h: Rename include guard.
 708         * common/pathstuff.h: Rename include guard.
 709         * common/observable.h: Rename include guard.
 710         * common/netstuff.h: Rename include guard.
 711         * common/job-control.h: Rename include guard.
 712         * common/host-defs.h: Rename include guard.
 713         * common/gdb_wait.h: Rename include guard.
 714         * common/gdb_vecs.h: Rename include guard.
 715         * common/gdb_unlinker.h: Rename include guard.
 716         * common/gdb_unique_ptr.h: Rename include guard.
 717         * common/gdb_tilde_expand.h: Rename include guard.
 718         * common/gdb_sys_time.h: Rename include guard.
 719         * common/gdb_string_view.h: Rename include guard.
 720         * common/gdb_splay_tree.h: Rename include guard.
 721         * common/gdb_setjmp.h: Rename include guard.
 722         * common/gdb_ref_ptr.h: Rename include guard.
 723         * common/gdb_optional.h: Rename include guard.
 724         * common/gdb_locale.h: Rename include guard.
 725         * common/gdb_assert.h: Rename include guard.
 726         * common/filtered-iterator.h: Rename include guard.
 727         * common/filestuff.h: Rename include guard.
 728         * common/fileio.h: Rename include guard.
 729         * common/environ.h: Rename include guard.
 730         * common/common-utils.h: Rename include guard.
 731         * common/common-types.h: Rename include guard.
 732         * common/common-regcache.h: Rename include guard.
 733         * common/common-inferior.h: Rename include guard.
 734         * common/common-gdbthread.h: Rename include guard.
 735         * common/common-exceptions.h: Rename include guard.
 736         * common/common-defs.h: Rename include guard.
 737         * common/common-debug.h: Rename include guard.
 738         * common/cleanups.h: Rename include guard.
 739         * common/buffer.h: Rename include guard.
 740         * common/btrace-common.h: Rename include guard.
 741         * common/break-common.h: Rename include guard.
 742         * cli/cli-utils.h: Rename include guard.
 743         * cli/cli-style.h: Rename include guard.
 744         * cli/cli-setshow.h: Rename include guard.
 745         * cli/cli-script.h: Rename include guard.
 746         * cli/cli-interp.h: Rename include guard.
 747         * cli/cli-decode.h: Rename include guard.
 748         * cli/cli-cmds.h: Rename include guard.
 749         * charset-list.h: Add include guard.
 750         * buildsym-legacy.h: Rename include guard.
 751         * bfin-tdep.h: Add include guard.
 752         * ax.h: Rename include guard.
 753         * arm-linux-tdep.h: Add include guard.
 754         * arm-fbsd-tdep.h: Add include guard.
 755         * arch/xtensa.h: Rename include guard.
 756         * arch/tic6x.h: Add include guard.
 757         * arch/i386.h: Add include guard.
 758         * arch/arm.h: Rename include guard.
 759         * arch/arm-linux.h: Rename include guard.
 760         * arch/arm-get-next-pcs.h: Rename include guard.
 761         * arch/amd64.h: Add include guard.
 762         * arch/aarch64-insn.h: Rename include guard.
 763         * arch-utils.h: Rename include guard.
 764         * annotate.h: Add include guard.
 765         * amd64-darwin-tdep.h: Rename include guard.
 766         * aarch64-linux-tdep.h: Add include guard.
 767         * aarch64-fbsd-tdep.h: Add include guard.
 768         * aarch32-linux-nat.h: Add include guard.
 769
 770 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 771
 772         * macrotab.c (macro_define_internal): New function that
 773         factorizes macro_define_object_internal and macro_define_function
 774         code.
 775         (macro_define_object_internal): Use macro_define_internal.
 776         (macro_define_function): Likewise.
 777
 778 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 779
 780         * macrocmd.c (extract_identifier): Return
 781         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 782         callers.
 783
 784 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 785
 786         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 787
 788 2019-02-05  Tom Tromey  <tom@tromey.com>
 789
 790         * target.c (target_stack::unpush): Move assertion earlier.
 791
 792 2019-01-30  Tom Tromey  <tom@tromey.com>
 793
 794         PR python/23615:
 795         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 796         (gdbpy_parse_and_eval): Likewise.
 797         * python/python-internal.h (gdbpy_allow_threads): New class.
 798
 799 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 800
 801         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 802         (aarch64_fbsd_fpregmap): Move earlier.
 803         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 804         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 805         instead of individual calls to trad_frame_set_reg_addr.
 806         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 807         earlier.
 808         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 809         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 810         instead of individual calls to trad_frame_set_reg_addr.
 811
 812 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 813
 814         * CONTRIBUTE: Replace contribution list with wiki link.
 815
 816 2019-01-25  Tom Tromey  <tom@tromey.com>
 817
 818         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 819
 820 2019-01-25  Tom Tromey  <tom@tromey.com>
 821
 822         * xtensa-linux-nat.c: Fix common/ includes.
 823         * xml-support.h: Fix common/ includes.
 824         * xml-support.c: Fix common/ includes.
 825         * x86-linux-nat.c: Fix common/ includes.
 826         * windows-nat.c: Fix common/ includes.
 827         * varobj.h: Fix common/ includes.
 828         * varobj.c: Fix common/ includes.
 829         * value.c: Fix common/ includes.
 830         * valops.c: Fix common/ includes.
 831         * utils.c: Fix common/ includes.
 832         * unittests/xml-utils-selftests.c: Fix common/ includes.
 833         * unittests/utils-selftests.c: Fix common/ includes.
 834         * unittests/unpack-selftests.c: Fix common/ includes.
 835         * unittests/tracepoint-selftests.c: Fix common/ includes.
 836         * unittests/style-selftests.c: Fix common/ includes.
 837         * unittests/string_view-selftests.c: Fix common/ includes.
 838         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 839         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 840         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 841         * unittests/rsp-low-selftests.c: Fix common/ includes.
 842         * unittests/parse-connection-spec-selftests.c: Fix common/
 843         includes.
 844         * unittests/optional-selftests.c: Fix common/ includes.
 845         * unittests/offset-type-selftests.c: Fix common/ includes.
 846         * unittests/observable-selftests.c: Fix common/ includes.
 847         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 848         * unittests/memrange-selftests.c: Fix common/ includes.
 849         * unittests/memory-map-selftests.c: Fix common/ includes.
 850         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 851         * unittests/function-view-selftests.c: Fix common/ includes.
 852         * unittests/environ-selftests.c: Fix common/ includes.
 853         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 854         * unittests/common-utils-selftests.c: Fix common/ includes.
 855         * unittests/cli-utils-selftests.c: Fix common/ includes.
 856         * unittests/array-view-selftests.c: Fix common/ includes.
 857         * ui-file.c: Fix common/ includes.
 858         * tui/tui-io.c: Fix common/ includes.
 859         * tracepoint.h: Fix common/ includes.
 860         * tracepoint.c: Fix common/ includes.
 861         * tracefile-tfile.c: Fix common/ includes.
 862         * top.h: Fix common/ includes.
 863         * top.c: Fix common/ includes.
 864         * thread.c: Fix common/ includes.
 865         * target/waitstatus.h: Fix common/ includes.
 866         * target/waitstatus.c: Fix common/ includes.
 867         * target.h: Fix common/ includes.
 868         * target.c: Fix common/ includes.
 869         * target-memory.c: Fix common/ includes.
 870         * target-descriptions.c: Fix common/ includes.
 871         * symtab.h: Fix common/ includes.
 872         * symfile.c: Fix common/ includes.
 873         * stap-probe.c: Fix common/ includes.
 874         * spu-linux-nat.c: Fix common/ includes.
 875         * sparc-nat.c: Fix common/ includes.
 876         * source.c: Fix common/ includes.
 877         * solib.c: Fix common/ includes.
 878         * solib-target.c: Fix common/ includes.
 879         * ser-unix.c: Fix common/ includes.
 880         * ser-tcp.c: Fix common/ includes.
 881         * ser-pipe.c: Fix common/ includes.
 882         * ser-base.c: Fix common/ includes.
 883         * selftest-arch.c: Fix common/ includes.
 884         * s12z-tdep.c: Fix common/ includes.
 885         * rust-exp.y: Fix common/ includes.
 886         * rs6000-aix-tdep.c: Fix common/ includes.
 887         * riscv-tdep.c: Fix common/ includes.
 888         * remote.c: Fix common/ includes.
 889         * remote-notif.h: Fix common/ includes.
 890         * remote-fileio.h: Fix common/ includes.
 891         * remote-fileio.c: Fix common/ includes.
 892         * regcache.h: Fix common/ includes.
 893         * regcache.c: Fix common/ includes.
 894         * record-btrace.c: Fix common/ includes.
 895         * python/python.c: Fix common/ includes.
 896         * python/py-type.c: Fix common/ includes.
 897         * python/py-inferior.c: Fix common/ includes.
 898         * progspace.h: Fix common/ includes.
 899         * producer.c: Fix common/ includes.
 900         * procfs.c: Fix common/ includes.
 901         * proc-api.c: Fix common/ includes.
 902         * printcmd.c: Fix common/ includes.
 903         * ppc-linux-nat.c: Fix common/ includes.
 904         * parser-defs.h: Fix common/ includes.
 905         * osdata.c: Fix common/ includes.
 906         * obsd-nat.c: Fix common/ includes.
 907         * nat/x86-linux.c: Fix common/ includes.
 908         * nat/x86-linux-dregs.c: Fix common/ includes.
 909         * nat/x86-dregs.h: Fix common/ includes.
 910         * nat/x86-dregs.c: Fix common/ includes.
 911         * nat/ppc-linux.c: Fix common/ includes.
 912         * nat/mips-linux-watch.h: Fix common/ includes.
 913         * nat/mips-linux-watch.c: Fix common/ includes.
 914         * nat/linux-waitpid.c: Fix common/ includes.
 915         * nat/linux-ptrace.h: Fix common/ includes.
 916         * nat/linux-ptrace.c: Fix common/ includes.
 917         * nat/linux-procfs.c: Fix common/ includes.
 918         * nat/linux-personality.c: Fix common/ includes.
 919         * nat/linux-osdata.c: Fix common/ includes.
 920         * nat/linux-namespaces.c: Fix common/ includes.
 921         * nat/linux-btrace.h: Fix common/ includes.
 922         * nat/linux-btrace.c: Fix common/ includes.
 923         * nat/fork-inferior.c: Fix common/ includes.
 924         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 925         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 926         * nat/aarch64-linux.c: Fix common/ includes.
 927         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 928         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 929         * namespace.h: Fix common/ includes.
 930         * mips-linux-tdep.c: Fix common/ includes.
 931         * minsyms.c: Fix common/ includes.
 932         * mi/mi-parse.h: Fix common/ includes.
 933         * mi/mi-main.c: Fix common/ includes.
 934         * mi/mi-cmd-env.c: Fix common/ includes.
 935         * memrange.h: Fix common/ includes.
 936         * memattr.c: Fix common/ includes.
 937         * maint.h: Fix common/ includes.
 938         * maint.c: Fix common/ includes.
 939         * main.c: Fix common/ includes.
 940         * machoread.c: Fix common/ includes.
 941         * location.c: Fix common/ includes.
 942         * linux-thread-db.c: Fix common/ includes.
 943         * linux-nat.c: Fix common/ includes.
 944         * linux-fork.c: Fix common/ includes.
 945         * inline-frame.c: Fix common/ includes.
 946         * infrun.c: Fix common/ includes.
 947         * inflow.c: Fix common/ includes.
 948         * inferior.h: Fix common/ includes.
 949         * inferior.c: Fix common/ includes.
 950         * infcmd.c: Fix common/ includes.
 951         * inf-ptrace.c: Fix common/ includes.
 952         * inf-child.c: Fix common/ includes.
 953         * ia64-linux-nat.c: Fix common/ includes.
 954         * i387-tdep.c: Fix common/ includes.
 955         * i386-tdep.c: Fix common/ includes.
 956         * i386-linux-tdep.c: Fix common/ includes.
 957         * i386-linux-nat.c: Fix common/ includes.
 958         * i386-go32-tdep.c: Fix common/ includes.
 959         * i386-fbsd-tdep.c: Fix common/ includes.
 960         * i386-fbsd-nat.c: Fix common/ includes.
 961         * guile/scm-type.c: Fix common/ includes.
 962         * guile/guile.c: Fix common/ includes.
 963         * go32-nat.c: Fix common/ includes.
 964         * gnu-nat.c: Fix common/ includes.
 965         * gdbthread.h: Fix common/ includes.
 966         * gdbarch-selftests.c: Fix common/ includes.
 967         * gdb_usleep.c: Fix common/ includes.
 968         * gdb_select.h: Fix common/ includes.
 969         * gdb_bfd.c: Fix common/ includes.
 970         * gcore.c: Fix common/ includes.
 971         * fork-child.c: Fix common/ includes.
 972         * findvar.c: Fix common/ includes.
 973         * fbsd-nat.c: Fix common/ includes.
 974         * event-top.c: Fix common/ includes.
 975         * event-loop.c: Fix common/ includes.
 976         * dwarf2read.c: Fix common/ includes.
 977         * dwarf2loc.c: Fix common/ includes.
 978         * dwarf2-frame.c: Fix common/ includes.
 979         * dwarf-index-cache.c: Fix common/ includes.
 980         * dtrace-probe.c: Fix common/ includes.
 981         * disasm-selftests.c: Fix common/ includes.
 982         * defs.h: Fix common/ includes.
 983         * csky-tdep.c: Fix common/ includes.
 984         * cp-valprint.c: Fix common/ includes.
 985         * cp-support.h: Fix common/ includes.
 986         * cp-support.c: Fix common/ includes.
 987         * corelow.c: Fix common/ includes.
 988         * completer.h: Fix common/ includes.
 989         * completer.c: Fix common/ includes.
 990         * compile/compile.c: Fix common/ includes.
 991         * compile/compile-loc2c.c: Fix common/ includes.
 992         * compile/compile-cplus-types.c: Fix common/ includes.
 993         * compile/compile-cplus-symbols.c: Fix common/ includes.
 994         * command.h: Fix common/ includes.
 995         * cli/cli-dump.c: Fix common/ includes.
 996         * cli/cli-cmds.c: Fix common/ includes.
 997         * charset.c: Fix common/ includes.
 998         * build-id.c: Fix common/ includes.
 999         * btrace.h: Fix common/ includes.
1000         * btrace.c: Fix common/ includes.
1001         * breakpoint.h: Fix common/ includes.
1002         * breakpoint.c: Fix common/ includes.
1003         * ax.h:
1004         (enum agent_op): Fix common/ includes.
1005         * ax-general.c (struct aop_map): Fix common/ includes.
1006         * ax-gdb.c: Fix common/ includes.
1007         * auxv.c: Fix common/ includes.
1008         * auto-load.c: Fix common/ includes.
1009         * arm-tdep.c: Fix common/ includes.
1010         * arch/riscv.c: Fix common/ includes.
1011         * arch/ppc-linux-common.c: Fix common/ includes.
1012         * arch/i386.c: Fix common/ includes.
1013         * arch/arm.c: Fix common/ includes.
1014         * arch/arm-linux.c: Fix common/ includes.
1015         * arch/arm-get-next-pcs.c: Fix common/ includes.
1016         * arch/amd64.c: Fix common/ includes.
1017         * arch/aarch64.c: Fix common/ includes.
1018         * arch/aarch64-insn.c: Fix common/ includes.
1019         * arch-utils.c: Fix common/ includes.
1020         * amd64-windows-tdep.c: Fix common/ includes.
1021         * amd64-tdep.c: Fix common/ includes.
1022         * amd64-sol2-tdep.c: Fix common/ includes.
1023         * amd64-obsd-tdep.c: Fix common/ includes.
1024         * amd64-nbsd-tdep.c: Fix common/ includes.
1025         * amd64-linux-tdep.c: Fix common/ includes.
1026         * amd64-linux-nat.c: Fix common/ includes.
1027         * amd64-fbsd-tdep.c: Fix common/ includes.
1028         * amd64-fbsd-nat.c: Fix common/ includes.
1029         * amd64-dicos-tdep.c: Fix common/ includes.
1030         * amd64-darwin-tdep.c: Fix common/ includes.
1031         * agent.c: Fix common/ includes.
1032         * ada-lang.h: Fix common/ includes.
1033         * ada-lang.c: Fix common/ includes.
1034         * aarch64-tdep.c: Fix common/ includes.
1035
1036 2019-01-25  Tom Tromey  <tom@tromey.com>
1037
1038         * common/create-version.sh: Use common/version.h.
1039
1040 2019-01-24  Pedro Alves  <palves@redhat.com>
1041
1042         * infrun.c (signal_stop, signal_print, signal_program)
1043         (signal_catch, signal_pass): Now arrays instead of pointers.
1044         (update_signals_program_target, do_target_resume)
1045         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1046         * linux-nat.c (linux_nat_target::pass_signals)
1047         (linux_nat_target::create_inferior, linux_nat_target::attach):
1048         Adjust.
1049         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1050         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1051         * procfs.c (procfs_target::pass_signals): Adjust.
1052         * record-full.c (record_full_target::resume): Adjust.
1053         * remote.c (remote_target::pass_signals)
1054         (remote_target::program_signals): Adjust.
1055         * target-debug.h (target_debug_print_signals): Now takes a
1056         gdb::array_view as parameter.  Adjust.
1057         * target.h (target_ops) <pass_signals, program_signals>: Replace
1058         pointer and length parameters with gdb::array_view.
1059         (target_pass_signals, target_program_signals): Likewise.
1060         * target-delegates.c: Regenerate.
1061
1062 2019-01-24  Pedro Alves  <palves@redhat.com>
1063
1064         * common/forward-scope-exit.h
1065         (forward_scope_exit::forward_scope_exit): Pass arguments to
1066         m_bind_function directly, instead of creating a std::bind and
1067         copying that.
1068
1069 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1070
1071         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1072         for static members.
1073         (pass_in_v_vfp_candidate): Likewise.
1074
1075 2019-01-23  Tom Tromey  <tom@tromey.com>
1076             Pedro Alves  <palves@redhat.com>
1077
1078         * regcache.c (class regcache_invalidator): Remove.
1079         (regcache::raw_write): Use make_scope_exit.
1080
1081 2019-01-23  Tom Tromey  <tom@tromey.com>
1082
1083         * ui-out.h (class ui_out_emit_type): Update comment.
1084
1085 2019-01-23  Tom Tromey  <tom@tromey.com>
1086
1087         * infrun.c (fetch_inferior_event): Update comment.
1088
1089 2019-01-23  Tom Tromey  <tom@tromey.com>
1090             Pedro Alves  <palves@redhat.com>
1091
1092         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1093         parameter.
1094         (fetch_inferior_event): Use SCOPE_EXIT.
1095
1096
1097 2019-01-23  Tom Tromey  <tom@tromey.com>
1098             Pedro Alves  <palves@redhat.com>
1099
1100         * infrun.c (disable_thread_events): Delete.
1101         (stop_all_threads): Use SCOPE_EXIT.
1102
1103 2019-01-23  Tom Tromey  <tom@tromey.com>
1104             Pedro Alves  <palves@redhat.com>
1105
1106         * symfile.c: Include forward-scope-exit.h.
1107         (clear_symtab_users_cleanup): Replace forward declaration with
1108         a FORWARD_SCOPE_EXIT.
1109         (syms_from_objfile_1): Use the forward_scope_exit and
1110         gdb::optional instead of cleanup_function.
1111         (reread_symbols): Use the forward_scope_exit instead of
1112         cleanup_function.
1113         (clear_symtab_users_cleanup): Remove function.
1114
1115 2019-01-23  Tom Tromey  <tom@tromey.com>
1116             Pedro Alves  <palves@redhat.com>
1117
1118         * linux-nat.c: Include scope-exit.h.
1119         (cleanup_target_stop): Remove.
1120         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1121         SCOPE_EXIT.
1122
1123 2019-01-23  Tom Tromey  <tom@tromey.com>
1124             Pedro Alves  <palves@redhat.com>
1125
1126         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1127         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1128
1129 2019-01-23  Tom Tromey  <tom@tromey.com>
1130             Andrew Burgess  <andrew.burgess@embecosm.com>
1131             Pedro Alves  <palves@redhat.com>
1132
1133         * infrun.c (fetch_inferior_event): Use scope_exit.
1134         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1135         * top.c (execute_command): Use scope_exit.
1136         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1137         * utils.c (do_bpstat_clear_actions_cleanup)
1138         (make_bpstat_clear_actions_cleanup): Remove.
1139
1140 2019-01-23  Tom Tromey  <tom@tromey.com>
1141             Pedro Alves  <palves@redhat.com>
1142
1143         * infrun.c: Include "common/scope-exit.h"
1144         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1145         (wait_for_inferior): Use SCOPE_EXIT.
1146         (fetch_inferior_event): Use scope_exit.
1147
1148 2019-01-23  Tom Tromey  <tom@tromey.com>
1149             Pedro Alves  <palves@redhat.com>
1150
1151         * breakpoint.c (create_breakpoint): Remove cleanup.
1152
1153 2019-01-23  Tom Tromey  <tom@tromey.com>
1154             Andrew Burgess  <andrew.burgess@embecosm.com>
1155             Pedro Alves  <palves@redhat.com>
1156
1157 2019-01-23  Pedro Alves  <palves@redhat.com>
1158
1159         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1160
1161 2019-01-23  Pedro Alves  <palves@redhat.com>
1162             Andrew Burgess  <andrew.burgess@embecosm.com>
1163
1164         * gdbthread.h: Include "common/forward-scope-exit.h".
1165         (scoped_finish_thread_state): Redefine custom class in terms of
1166         forward_scope_exit.
1167
1168 2019-01-23  Pedro Alves  <palves@redhat.com>
1169             Andrew Burgess  <andrew.burgess@embecosm.com>
1170
1171         * common/forward-scope-exit.h: New file.
1172
1173 2019-01-23  Pedro Alves  <palves@redhat.com>
1174             Andrew Burgess  <andrew.burgess@embecosm.com>
1175             Tom Tromey  <tom@tromey.com>
1176
1177         * common/scope-exit.h: New file.
1178
1179 2019-01-23  Pedro Alves  <palves@redhat.com>
1180
1181         * common/preprocessor.h (ESC): Rename to ...
1182         (ESC_PARENS): ... this.
1183         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1184         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1185
1186 2019-01-23  Tom Tromey  <tom@tromey.com>
1187
1188         * language.h (class scoped_switch_to_sym_language_if_auto):
1189         Initialize m_lang in both cases.
1190
1191 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1192
1193         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1194         with XCNEW.
1195
1196 2019-01-22  Tom Tromey  <tom@tromey.com>
1197
1198         * corelow.c: Do not include sys/file.h.
1199
1200 2019-01-22  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-wingeneral.h: Include gdb_curses.h.
1203
1204 2019-01-22  Tom Tromey  <tom@tromey.com>
1205
1206         * source-cache.h (class source_cache) <get_source_lines,
1207         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1208
1209 2019-01-22  Tom Tromey  <tom@tromey.com>
1210
1211         * remote-fileio.h (struct remote_target): Declare.
1212
1213 2019-01-22  Tom Tromey  <tom@tromey.com>
1214
1215         * python/py-arch.c: Do not include py-ref.h.
1216         * python/py-bpevent.c: Do not include py-ref.h.
1217         * python/py-cmd.c: Do not include py-ref.h.
1218         * python/py-continueevent.c: Do not include py-ref.h.
1219         * python/py-event.h: Do not include py-ref.h.
1220         * python/py-evtregistry.c: Do not include py-ref.h.
1221         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1222         * python/py-frame.c: Do not include py-ref.h.
1223         * python/py-framefilter.c: Do not include py-ref.h.
1224         * python/py-function.c: Do not include py-ref.h.
1225         * python/py-infevents.c: Do not include py-ref.h.
1226         * python/py-linetable.c: Do not include py-ref.h.
1227         * python/py-objfile.c: Do not include py-ref.h.
1228         * python/py-param.c: Do not include py-ref.h.
1229         * python/py-prettyprint.c: Do not include py-ref.h.
1230         * python/py-progspace.c: Do not include py-ref.h.
1231         * python/py-symbol.c: Do not include py-ref.h.
1232         * python/py-symtab.c: Do not include py-ref.h.
1233         * python/py-type.c: Do not include py-ref.h.
1234         * python/py-unwind.c: Do not include py-ref.h.
1235         * python/py-utils.c: Do not include py-ref.h.
1236         * python/py-value.c: Do not include py-ref.h.
1237         * python/py-varobj.c: Do not include py-ref.h.
1238         * python/py-xmethods.c: Do not include py-ref.h.
1239         * python/python.c: Do not include py-ref.h.
1240         * varobj.c: Do not include py-ref.h.
1241
1242 2019-01-22  Tom Tromey  <tom@tromey.com>
1243
1244         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1245         keyword for bcache.
1246
1247 2019-01-22  Tom Tromey  <tom@tromey.com>
1248
1249         * compile/compile-cplus-types.c: Remove a comment by #include.
1250
1251 2019-01-22  Tom Tromey  <tom@tromey.com>
1252
1253         * compile/gcc-c-plugin.h: Include compile-internal.h.
1254
1255 2019-01-22  Tom Tromey  <tom@tromey.com>
1256
1257         * stabsread.c (EXTERN): Do not define.
1258         (symnum, next_symbol_text_func, processing_gcc_compilation)
1259         (within_function, global_sym_chain, global_stabs)
1260         (previous_stab_code, this_object_header_files)
1261         (n_this_object_header_files)
1262         (n_allocated_this_object_header_files): Define.
1263         * stabsread.h (EXTERN): Never define.  Use "extern".
1264
1265 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1266
1267         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1268         history_value.
1269
1270 2019-01-21  Tom Tromey  <tom@tromey.com>
1271
1272         * ui-out.c: Fix includes.
1273         * tui/tui-source.c: Fix includes.
1274         * target.c: Fix includes.
1275         * remote.c: Fix includes.
1276         * regcache.c: Fix includes.
1277         * python/py-block.c: Fix includes.
1278         * printcmd.c: Fix includes.
1279         * or1k-tdep.c: Fix includes.
1280         * mi/mi-main.c: Fix includes.
1281         * m32r-tdep.c: Fix includes.
1282         * csky-tdep.c: Fix includes.
1283         * compile/compile-cplus-types.c: Fix includes.
1284         * cli/cli-interp.c: Fix includes.
1285
1286 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1287
1288         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1289         for padding.
1290
1291 2019-01-16  Tom Tromey  <tom@tromey.com>
1292
1293         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1294         earlier.
1295         (struct objfile) <msymbols_range>: Move from top level.
1296         <msymbols>: New method.
1297         (class objfile_msymbols): Remove.
1298         * symtab.c (default_collect_symbol_completion_matches_break_on):
1299         Update.
1300         * symmisc.c (dump_msymbols): Update.
1301         * stabsread.c (scan_file_globals): Update.
1302         * objc-lang.c (info_selectors_command, info_classes_command)
1303         (find_methods): Update.
1304         * minsyms.c (find_solib_trampoline_target): Update.
1305         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1306         * coffread.c (coff_symfile_read): Update.
1307         * ada-lang.c (ada_lookup_simple_minsym)
1308         (ada_collect_symbol_completion_matches): Update.
1309
1310 2019-01-16  Tom Tromey  <tom@tromey.com>
1311
1312         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1313         type.  Remove no-argument constructor.
1314         <iterator::operator++>: Simplify.
1315         <begin>: Update.
1316         <end>: Use minimal_symbol_count.
1317
1318 2019-01-16  Tom Tromey  <tom@tromey.com>
1319
1320         * objfiles.h (struct objfile) <psymtabs>: New method.
1321         (class objfile_psymtabs): Remove.
1322         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1323         typedef.
1324         <range>: New method.
1325         (require_partial_symbols): Change return type.
1326         * psymtab.c (require_partial_symbols)
1327         (psym_expand_symtabs_matching): Update.
1328         * mdebugread.c (parse_partial_symbols): Update.
1329         * dbxread.c (dbx_end_psymtab): Update.
1330
1331 2019-01-15  Tom Tromey  <tom@tromey.com>
1332
1333         * symtab.c (lookup_objfile_from_block)
1334         (lookup_symbol_in_objfile_symtabs)
1335         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1336         (find_line_symtab, info_sources_command)
1337         (default_collect_symbol_completion_matches_break_on)
1338         (make_source_files_completion_list): Update.
1339         * symmisc.c (print_objfile_statistics, dump_objfile)
1340         (maintenance_print_symbols, maintenance_info_symtabs)
1341         (maintenance_check_symtabs, maintenance_info_line_tables):
1342         Update.
1343         * source.c (select_source_symtab)
1344         (forget_cached_source_info_for_objfile): Update.
1345         * objfiles.h (class objfile_compunits): Remove.
1346         (struct objfile) <compunits_range>: New typedef.
1347         (compunits): New method.
1348         * objfiles.c (objfile_relocate1): Update.
1349         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1350         * maint.c (count_symtabs_and_blocks): Update.
1351         * linespec.c (iterate_over_all_matching_symtabs): Update.
1352         * cp-support.c (add_symbol_overload_list_qualified): Update.
1353         * coffread.c (coff_symtab_read): Update.
1354         * ada-lang.c (add_nonlocal_symbols)
1355         (ada_collect_symbol_completion_matches)
1356         (ada_add_global_exceptions): Update.
1357
1358 2019-01-15  Tom Tromey  <tom@tromey.com>
1359
1360         * progspace.h (program_space) <objfiles_safe_range>: New
1361         typedef.
1362         <objfiles_safe>: New method.
1363         * objfiles.h (class all_objfiles_safe): Remove.
1364         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1365         * jit.c (jit_inferior_exit_hook): Update.
1366
1367 2019-01-17  Tom Tromey  <tom@tromey.com>
1368
1369         * progspace.h (program_space) <objfiles_range>: New typedef.
1370         <objfiles>: New method.
1371         <objfiles_head>: Rename from objfiles.
1372         (object_files): Update.
1373         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1374         * guile/scm-pretty-print.c
1375         (ppscm_find_pretty_printer_from_objfiles): Update.
1376         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1377         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1378         Update.
1379         * python/py-progspace.c (pspy_get_objfiles): Update.
1380         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1381         Update.
1382         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1383         (objfpy_lookup_objfile_by_build_id): Update.
1384         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1385         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1386         Update.
1387         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1388         (expand_symtab_containing_pc, lookup_objfile_from_block)
1389         (lookup_static_symbol, basic_lookup_transparent_type)
1390         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1391         (find_line_symtab, info_sources_command)
1392         (default_collect_symbol_completion_matches_break_on)
1393         (make_source_files_completion_list, find_main_name): Update.
1394         * symmisc.c (print_symbol_bcache_statistics)
1395         (print_objfile_statistics, maintenance_print_symbols)
1396         (maintenance_print_msymbols, maintenance_print_objfiles)
1397         (maintenance_info_symtabs, maintenance_check_symtabs)
1398         (maintenance_expand_symtabs, maintenance_info_line_tables):
1399         Update.
1400         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1401         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1402         (map_overlay_command, unmap_overlay_command)
1403         (simple_overlay_update, expand_symtabs_matching)
1404         (map_symbol_filenames): Update.
1405         * symfile-debug.c (set_debug_symfile): Update.
1406         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1407         Update.
1408         * source.c (select_source_symtab, forget_cached_source_info):
1409         Update.
1410         * solib.c (solib_read_symbols): Update.
1411         * solib-spu.c (append_ocl_sos): Update.
1412         * psymtab.c (maintenance_print_psymbols)
1413         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1414         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1415         * printcmd.c (info_symbol_command): Update.
1416         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1417         Update.
1418         * objfiles.h (class all_objfiles): Remove.
1419         * objfiles.c (have_partial_symbols, have_full_symbols)
1420         (have_minimal_symbols, qsort_cmp, update_section_map)
1421         (shared_objfile_contains_address_p)
1422         (default_iterate_over_objfiles_in_search_order): Update.
1423         * objc-lang.c (info_selectors_command, info_classes_command)
1424         (find_methods): Update.
1425         * minsyms.c (find_solib_trampoline_target): Update.
1426         * maint.c (maintenance_info_sections)
1427         (maintenance_translate_address, count_symtabs_and_blocks):
1428         Update.
1429         * main.c (captured_main_1): Update.
1430         * linux-thread-db.c (try_thread_db_load_from_pdir)
1431         (has_libpthread): Update.
1432         * linespec.c (iterate_over_all_matching_symtabs)
1433         (search_minsyms_for_name): Update.
1434         * jit.c (jit_find_objf_with_entry_addr): Update.
1435         * hppa-tdep.c (find_unwind_entry)
1436         (hppa_lookup_stub_minimal_symbol): Update.
1437         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1438         Update.
1439         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1440         (elf_gnu_ifunc_resolve_by_got): Update.
1441         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1442         * dwarf-index-write.c (save_gdb_index_command): Update.
1443         * cp-support.c (add_symbol_overload_list_qualified): Update.
1444         * breakpoint.c (create_overlay_event_breakpoint)
1445         (create_longjmp_master_breakpoint)
1446         (create_std_terminate_master_breakpoint)
1447         (create_exception_master_breakpoint): Update.
1448         * blockframe.c (find_pc_partial_function): Update.
1449         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1450         (ada_collect_symbol_completion_matches)
1451         (ada_add_global_exceptions): Update.
1452
1453 2019-01-17  Tom Tromey  <tom@tromey.com>
1454
1455         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1456         declare VEC.
1457         (solib_target_parse_libraries): Change return type.
1458         (library_list_start_segment, library_list_start_section)
1459         (library_list_end_library, library_list_start_library); Update.
1460         (solib_target_free_library_list): Remove.
1461         (solib_target_parse_libraries): Remove cleanup.  Change return
1462         type.
1463         (solib_target_current_sos): Update.
1464
1465 2019-01-17  Tom Tromey  <tromey@bapiya>
1466
1467         * valprint.c: Replace "the the" with "the".
1468         * symtab.c: Replace "the the" with "the".
1469         * solib.c: Replace "the the" with "the".
1470         * solib-dsbt.c: Replace "the the" with "the".
1471         * linespec.c: Replace "the the" with "the".
1472         * dwarf2loc.h: Replace "the the" with "the".
1473         * amd64-windows-tdep.c: Replace "the the" with "the".
1474         * aarch64-tdep.c: Replace "the the" with "the".
1475
1476 2019-01-16  Keith Seitz  <keiths@redhat.com>
1477
1478         PR gdb/23773
1479         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1480         <builder>: Rename to ..
1481         <m_builder>: ... this and make private.
1482         (dwarf2_cu::get_builder): New method.  Change all users of
1483         `builder' to use this method.
1484         (dwarf2_start_symtab): Move to ...
1485         (dwarf2_cu::start_symtab): ... here.  Update all callers
1486         (setup_type_unit_groups): Move to ...
1487         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1488         callers.
1489         (dwarf2_cu::reset_builder): New method.
1490         (process_full_compunit, process_full_type_unit): Use
1491         dwarf2_cu::reset_builder.
1492         (follow_die_offset): Record the ancestor CU if it is different
1493         from the followed DIE's CU.
1494         (follow_die_sig_1): Likewise.
1495
1496 2019-01-15  Tom Tromey  <tom@tromey.com>
1497
1498         * remote.c (class remote_state) <buf>: Now a char_vector.
1499         <buf_size>: Remove.
1500         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1501         parameter.
1502         (remote_target::getpkt_or_notif_sane_1)
1503         (remote_target::getpkt_sane)
1504         (remote_target::getpkt_or_notif_sane): Likewise.
1505         (class remote_target) <putpkt>: New overload.
1506         (remote_target::read_frame): Change type of "buf_p".  Remove
1507         sizeof_p parameter.
1508         (packet_ok): New overload.
1509         (packet_check_result): New overload.
1510         Update all uses.
1511
1512 2019-01-14  Tom Tromey  <tom@tromey.com>
1513
1514         * remote-notif.c (handle_notification, remote_notif_ack)
1515         (remote_notif_parse): Make "buf" const.
1516         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1517         const.
1518         (remote_notif_parse, remote_notif_ack, handle_notification):
1519         Likewise.
1520         * remote.c (remote_notif_stop_parse): Make "buf" const.
1521         (remote_target::remote_parse_stop_reply): Make "buf" const.
1522         (remote_notif_stop_ack): Make "buf" const.
1523
1524 2019-01-14  Tom Tromey  <tom@tromey.com>
1525
1526         * remote.c (remote_console_output): Make parameter const.
1527
1528 2019-01-14  Tom Tromey  <tom@tromey.com>
1529
1530         * target-debug.h (target_debug_print_signals): Constify.
1531         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1532         * procfs.c (procfs_target::pass_signals): Update.
1533         * linux-nat.c (linux_nat_target::pass_signals): Update.
1534         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1535         * target-delegates.c: Rebuild.
1536         * remote.c (remote_target::program_signals): Update.
1537         (remote_target::pass_signals): Update.
1538         * target.c (target_pass_signals): Constify argument.
1539         (target_program_signals): Likewise.
1540         * target.h (struct target_ops) <pass_signals, program_signals>:
1541         Constify argument.
1542         (target_pass_signals, target_program_signals): Constify argument.
1543
1544 2019-01-14  Tom Tromey  <tom@tromey.com>
1545
1546         PR tui/28819:
1547         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1548
1549 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1550
1551         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1552         field.
1553         * rs6000-tdep.c: Include reggroups.h.
1554         (IS_V_ALIAS_PSEUDOREG): Define.
1555         (rs6000_register_name): Return names for the "vX" aliases.
1556         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1557         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1558         aliases.  Call default_register_reggroup_p for all other
1559         pseudo-registers.
1560         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1561         New functions.
1562         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1563         Handle "vX" aliases.
1564         (v_alias_pseudo_register_collect): New function.
1565         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1566         (rs6000_gdbarch_init): Initialize "vX" aliases as
1567         pseudo-registers.  Restore registration of
1568         rs6000_pseudo_register_reggroup_p with
1569         set_tdesc_pseudo_register_reggroup_p.
1570
1571 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1572
1573         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1574         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1575         set_gdbarch_num_pseudo_regs.
1576
1577 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1578
1579         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1580         Remove arg prefixname, add do_set and do_show.
1581         Add member functions set_list and show_list.
1582         * cli/cli-style.c (class cli_style_option): Update accordingly.
1583         (style_set_list): Move to file scope.
1584         (style_show_list): Likewise.
1585         (set_style): Call help_list.
1586         (show_style): Call cmd_show_list.
1587         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1588         Update to use the new macro.
1589
1590 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1591
1592         * ada-lang.c (_initialize_ada_language): Expand the help text
1593         for the "catch exception" command.
1594
1595 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1596
1597         * symtab.c (matching_obj_sections): Initialize obj,
1598         declare it closer to its usage.
1599
1600 2019-01-10  Tom Tromey  <tom@tromey.com>
1601
1602         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1603         (basic_inf_threads_range): Remove.
1604         (inf_threads_range, inf_non_exited_threads_range)
1605         (safe_inf_threads_range): Use next_adapter.
1606
1607 2019-01-10  Keith Seitz  <keiths@redhat.com>
1608
1609         PR gdb/23712
1610         PR symtab/23010
1611         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1612         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1613
1614 2019-01-10  Keith Seitz  <keiths@redhat.com>
1615
1616         PR gdb/23712
1617         PR symtab/23010
1618         * dictionary.c (pending_to_vector): Remove.
1619         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1620         Remove _1 suffix, replacing functions of the same name.  Update
1621         all callers.
1622         (dict_create_hashed, dict_create_hashed_expandable)
1623         (dict_create_linear, dict_create_linear_expandable, dict_free)
1624         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1625         Make functions static.
1626
1627 2019-01-10  Keith Seitz  <keiths@redhat.com>
1628
1629         PR gdb/23712
1630         PR symtab/23010
1631         * dictionary.h (struct dictionary): Replace declaration with
1632         multidictionary.
1633         (dict_create_hashed, dict_create_hashed_expandable)
1634         (dict_create_linear, dict_create_linear_expandable)
1635         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1636         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1637         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1638         taking multidictionary argument.
1639         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1640         * block.h (struct block) <dict>: Change to multidictionary
1641         and rename `multidict'.
1642         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1643         symmisc.c: Update all dictionary references to multidictionary.
1644
1645 2019-01-10  Keith Seitz  <keiths@redhat.com>
1646
1647         PR gdb/23712
1648         PR symtab/23010
1649         * dictionary.c: Include unordered_map.
1650         (pending_to_vector): New function.
1651         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1652         Rewrite the non-"_1" functions to take vector instead
1653         of linked list.
1654         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1655         "new" _1 versions of the same name.
1656         (multidictionary): Define.
1657         (std::hash<enum language): New definition.
1658         (collate_pending_symbols_by_language, mdict_create_hashed)
1659         (mdict_create_hashed_expandable, mdict_create_linear)
1660         (mdict_create_linear_expandable, mdict_free)
1661         (find_language_dictionary, create_new_language_dictionary)
1662         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1663         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1664         (mdict_size, mdict_empty): New functions.
1665         * dictionary.h (mdict_iterator): Define.
1666
1667 2019-01-10  Pedro Alves  <palves@redhat.com>
1668
1669         * breakpoint.c (read_uploaded_action)
1670         (create_tracepoint_from_upload): Adjust to use
1671         gdb::unique_xmalloc_ptr.
1672         * ctf.c (ctf_write_uploaded_tp):
1673         (SET_ARRAY_FIELD): Use emplace_back.
1674         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1675         * tracefile-tfile.c (tfile_write_uploaded_tp):
1676         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1677         gdb::unique_xmalloc_ptr.
1678         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1679         at_string, cond_string, cmd_strings>: Replace char pointers
1680         with gdb::unique_xmalloc_ptr.
1681
1682 2019-01-10  Pedro Alves  <palves@redhat.com>
1683
1684         * solib-target.c (library_list_start_library): Don't xstrdup name.
1685
1686 2019-01-10  Pedro Alves  <palves@redhat.com>
1687
1688         * mdebugread.c (parse_partial_symbols): Use
1689         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1690
1691 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1692
1693         * linux-fork.c (scoped_switch_fork_info)
1694         <~scoped_switch_fork_info>: Fix incorrect variable name.
1695
1696 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1697
1698         * linux-fork.c (scoped_switch_fork_info)
1699         <scoped_switch_fork_info>: Make explicit.
1700         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1701
1702 2019-01-10  Tom Tromey  <tom@tromey.com>
1703
1704         * objfiles.h (objfile::reset_psymtabs): Update.
1705         * objfiles.c (objfile::objfile): Update.
1706         * psymtab.h (psymtab_storage::obstack): Update.
1707         (psymtab_storage::m_obstack): Use gdb::optional.
1708         (class psymtab_storage): Update comment.  Remove objfile
1709         parameter.
1710         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1711
1712 2019-01-10  Tom Tromey  <tom@tromey.com>
1713
1714         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1715         <free_psymtabs>: Now private.
1716         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1717         (allocate_psymtab): Use new method.
1718
1719 2019-01-10  Tom Tromey  <tom@tromey.com>
1720
1721         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1722         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1723         * mdebugread.c (parse_partial_symbols): Use
1724         allocate_dependencies.
1725         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1726         allocate_dependencies.
1727         (process_psymtab_comp_unit_reader)
1728         (build_type_psymtab_dependencies): Likewise.
1729         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1730
1731 2019-01-10  Tom Tromey  <tom@tromey.com>
1732
1733         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1734         PSYMBOL_SET_LANGUAGE.
1735         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1736
1737 2019-01-10  Tom Tromey  <tom@tromey.com>
1738
1739         * psymtab.h (psymtab_storage::obstack): New method.
1740         <m_obstack>: Rename from obstack; now private.
1741         * psymtab.c (psymtab_storage): Update.
1742         * dwarf2read.c (create_addrmap_from_index)
1743         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1744         Update.
1745
1746 2019-01-10  Tom Tromey  <tom@tromey.com>
1747
1748         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1749         * objfiles.h (objfile::reset_psymtabs): New method.
1750
1751 2019-01-10  Tom Tromey  <tom@tromey.com>
1752
1753         * symmisc.c (print_symbol_bcache_statistics): Update.
1754         (print_objfile_statistics): Update.
1755         * symfile.c (reread_symbols): Update.
1756         * psymtab.h (class psymtab_storage): New.
1757         * psymtab.c (psymtab_storage): New constructor.
1758         (~psymtab_storage): New destructor.
1759         (require_partial_symbols): Update.
1760         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1761         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1762         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1763         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1764         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1765         (start_psymtab_common, end_psymtab_common)
1766         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1767         (allocate_psymtab): Update.
1768         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1769         Update.
1770         (dump_psymtab_addrmap, maintenance_print_psymbols)
1771         (maintenance_check_psymtabs): Update.
1772         (class objfile_psymtabs): Move to objfiles.h.
1773         * psympriv.h (discard_psymtab): Now inline.
1774         (psymtab_discarder::psymtab_discarder): Update.
1775         (psymtab_discarder::~psymtab_discarder): Update.
1776         (ALL_OBJFILE_PSYMTABS): Rewrite.
1777         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1778         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1779         Remove fields.
1780         <partial_symtabs>: New field.
1781         (class objfile_psymtabs): Move from psymtab.h.  Update.
1782         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1783         psymbol_cache.
1784         (objfile::~objfile): Don't destroy psymbol_cache.
1785         * mdebugread.c (parse_partial_symbols): Update.
1786         * dwarf2read.c (create_addrmap_from_index)
1787         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1788         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1789         (add_partial_subprogram, dwarf2_ranges_read): Update.
1790         * dwarf-index-write.c (write_address_map)
1791         (write_one_signatured_type, recursively_write_psymbols)
1792         (class debug_names, class debug_names, write_psymtabs_to_index):
1793         Update.
1794
1795 2019-01-10  Tom Tromey  <tom@tromey.com>
1796
1797         * symtab.h (SYMBOL_SET_NAMES): Update.
1798         (symbol_set_names): Update.
1799         (MSYMBOL_SET_NAMES): Update.
1800         * symtab.c (symbol_set_names): Change argument to be an
1801         objfile_per_bfd_storage.
1802         * psymtab.c (add_psymbol_to_bcache): Update.
1803         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1804
1805 2019-01-10  Tom Tromey  <tom@tromey.com>
1806
1807         * symtab.c (create_demangled_names_hash): Change argument to be an
1808         objfile_per_bfd_storage.
1809         (symbol_set_names): Update.
1810
1811 2019-01-10  Tom Tromey  <tom@tromey.com>
1812
1813         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1814         init_psymbol_list.
1815         * psymtab.c (init_psymbol_list): Do nothing if already called.
1816         * psympriv.h (init_psymbol_list): Add comment.
1817         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1818         init_psymbol_list.
1819         * dbxread.c (dbx_symfile_read): Unconditionally call
1820         init_psymbol_list.
1821
1822 2019-01-10  Tom Tromey  <tom@tromey.com>
1823
1824         * xcoffread.c (scan_xcoff_symtab): Update.
1825         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1826         "where".
1827         * mdebugread.c (parse_partial_symbols)
1828         (handle_psymbol_enumerators): Update.
1829         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1830         * dbxread.c (read_dbx_symtab): Update.
1831         * psympriv.h (psymbol_placement): New enum.
1832         (add_psymbol_to_list): Update.
1833
1834 2019-01-10  Tom Tromey  <tom@tromey.com>
1835
1836         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1837         static_psymbols parameters.
1838         (scan_xcoff_symtab): Update.
1839         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1840         static_psymbols parameters.
1841         * psympriv.h (start_psymtab_common): Update.
1842         * mdebugread.c (parse_partial_symbols): Update.
1843         * dwarf2read.c (create_partial_symtab): Update.
1844         * dbxread.c (read_dbx_symtab): Update.
1845         (start_psymtab): Remove global_psymbols and static_psymbols
1846         parameters.
1847
1848 2019-01-10  Tom Tromey  <tom@tromey.com>
1849
1850         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1851         * psymtab.c (allocate_psymtab): Add comment.
1852         * psympriv.h (allocate_psymtab): Add comment.
1853         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1854         initializations.
1855         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1856
1857 2019-01-10  Tom Tromey  <tom@tromey.com>
1858
1859         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1860         Don't declare.
1861         * mipsread.c: Include mdebugread.h.
1862         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1863         Declare.
1864         * elfread.c: Include mdebugread.h.
1865
1866 2019-01-09  Tom Tromey  <tom@tromey.com>
1867
1868         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1869         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1870         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1871         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1872         (psym_lookup_symbol, psym_find_last_source_symtab)
1873         (psym_forget_cached_source_info, psym_print_stats)
1874         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1875         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1876         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1877         (psym_find_compunit_symtab_by_address)
1878         (maintenance_print_psymbols, maintenance_info_psymtabs)
1879         (maintenance_check_psymtabs): Use ranged for.
1880         * psymtab.h (class objfile_psymtabs): New.
1881         (require_partial_symbols): Return objfile_psymtabs.
1882         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1883
1884 2019-01-09  Tom Tromey  <tom@tromey.com>
1885
1886         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1887         (find_pc_mapped_section, list_overlays_command)
1888         (map_overlay_command, unmap_overlay_command)
1889         (simple_overlay_update): Use all_objfiles.
1890         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1891         * printcmd.c (info_symbol_command): Use all_objfiles.
1892         * objfiles.h (ALL_OBJSECTIONS): Remove.
1893         * maint.c (maintenance_translate_address): Use all_objfiles.
1894         * gcore.c (gcore_create_callback): Use all_objfiles.
1895         (objfile_find_memory_regions): Likewise.
1896
1897 2019-01-09  Tom Tromey  <tom@tromey.com>
1898
1899         * symtab.c (find_line_symtab, info_sources_command)
1900         (make_source_files_completion_list): Use objfile_compunits.
1901         * source.c (select_source_symtab): Use objfile_compunits.
1902         * objfiles.h (struct objfile): Update comment.
1903         (ALL_OBJFILES): Remove.
1904         (ALL_FILETABS): Remove.
1905         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1906         objfile_compunits.
1907
1908 2019-01-09  Tom Tromey  <tom@tromey.com>
1909
1910         * symmisc.c (print_objfile_statistics, dump_objfile)
1911         (maintenance_print_symbols): Use compunit_filetabs.
1912         * source.c (forget_cached_source_info_for_objfile): Use
1913         compunit_filetabs.
1914         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1915         (ALL_FILETABS): Use compunit_filetabs.
1916         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1917         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1918
1919 2019-01-09  Tom Tromey  <tom@tromey.com>
1920
1921         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1922         (compunit_filetabs): New.
1923         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1924         compunit_filetabs.
1925         (info_sources_command, make_source_files_completion_list): Remove
1926         declaration.
1927         * symmisc.c (print_objfile_statistics, dump_objfile)
1928         (maintenance_print_symbols): Remove declaration.
1929         (maintenance_info_symtabs): Use compunit_filetabs.
1930         (maintenance_info_line_tables): Likewise.
1931         * source.c (select_source_symtab): Change local variable name.
1932         (forget_cached_source_info_for_objfile): Remove declaration.
1933         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1934         * objfiles.c (objfile_relocate1): Remove declaration.
1935         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1936         declaration.
1937         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1938         * coffread.c (coff_symtab_read): Remove declaration.
1939         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1940         compunit_filetabs.
1941
1942 2019-01-09  Tom Tromey  <tom@tromey.com>
1943
1944         * symtab.c (lookup_objfile_from_block)
1945         (find_pc_sect_compunit_symtab, search_symbols)
1946         (default_collect_symbol_completion_matches_break_on): Use
1947         objfile_compunits.
1948         * objfiles.h (ALL_COMPUNITS): Remove.
1949         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1950         * cp-support.c (add_symbol_overload_list_qualified): Use
1951         objfile_compunits.
1952         * ada-lang.c (ada_collect_symbol_completion_matches)
1953         (ada_add_global_exceptions): Use objfile_compunits.
1954
1955 2019-01-09  Tom Tromey  <tom@tromey.com>
1956
1957         * source.c (select_source_symtab)
1958         (forget_cached_source_info_for_objfile): Remove declaration.
1959         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1960         declaration.
1961         * maint.c (count_symtabs_and_blocks): Remove declaration.
1962         * cp-support.c (add_symbol_overload_list_qualified): Remove
1963         declaration.
1964         * coffread.c (coff_symtab_read): Remove declaration.
1965         * symtab.c (lookup_symbol_in_objfile_symtabs)
1966         (basic_lookup_transparent_type_1): Use objfile_compunits.
1967         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1968         (info_sources_command, search_symbols)
1969         (default_collect_symbol_completion_matches_break_on)
1970         (make_source_files_completion_list): Remove declaration.
1971         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1972         (ada_collect_symbol_completion_matches)
1973         (ada_add_global_exceptions): Remove declaration.
1974         * linespec.c (iterate_over_all_matching_symtabs): Use
1975         objfile_compunits.
1976         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1977         (class objfile_compunits): New.
1978         (ALL_COMPUNITS): Use objfile_compunits.
1979         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1980         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1981         objfile_compunits.
1982         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1983
1984 2019-01-09  Tom Tromey  <tom@tromey.com>
1985
1986         * symtab.c (search_symbols)
1987         (default_collect_symbol_completion_matches_break_on): Use
1988         objfile_msymbols.
1989         * ada-lang.c (ada_lookup_simple_minsym)
1990         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1991         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1992         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1993         objfile_msymbols.
1994         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1995         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1996         * objc-lang.c (find_methods): Use objfile_msymbols.
1997         (info_selectors_command, info_classes_command): Likewise.
1998         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1999         * objfiles.h (class objfile_msymbols): New.
2000         (ALL_OBJFILE_MSYMBOLS): Remove.
2001         (ALL_MSYMBOLS): Remove.
2002
2003 2019-01-09  Tom Tromey  <tom@tromey.com>
2004
2005         * common/next-iterator.h (next_adapter): Add Iterator template
2006         parameter.
2007         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2008         (class all_objfiles_safe): New.
2009         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2010         * objfiles.c (put_objfile_before): Update comment.
2011         (add_separate_debug_objfile): Likewise.
2012         (free_all_objfiles): Use all_objfiles_safe.
2013         (objfile_purge_solibs): Likewise.
2014
2015 2019-01-09  Tom Tromey  <tom@tromey.com>
2016
2017         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2018         (expand_symtab_containing_pc, lookup_static_symbol)
2019         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2020         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2021         all_objfiles.
2022         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2023         * breakpoint.c (create_overlay_event_breakpoint)
2024         (create_longjmp_master_breakpoint)
2025         (create_std_terminate_master_breakpoint)
2026         (create_exception_master_breakpoint): Use all_objfiles.
2027         * linux-thread-db.c (try_thread_db_load_from_pdir)
2028         (has_libpthread): Use all_objfiles.
2029         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2030         * linespec.c (iterate_over_all_matching_symtabs)
2031         (search_minsyms_for_name): Use all_objfiles.
2032         * maint.c (maintenance_info_sections): Use all_objfiles.
2033         * main.c (captured_main_1): Use all_objfiles.
2034         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2035         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2036         * guile/scm-pretty-print.c
2037         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2038         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2039         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2040         (maintenance_print_msymbols): Use all_objfiles.
2041         * source.c (select_source_symtab): Use all_objfiles.
2042         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2043         * symfile.c (remove_symbol_file_command)
2044         (expand_symtabs_matching, map_symbol_filenames): Use
2045         all_objfiles.
2046         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2047         all_objfiles.
2048         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2049         * objc-lang.c (find_methods): Use all_objfiles.
2050         * objfiles.c (have_partial_symbols, have_full_symbols)
2051         (have_minimal_symbols, qsort_cmp)
2052         (default_iterate_over_objfiles_in_search_order): Use
2053         all_objfiles.
2054         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2055         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2056         (maintenance_check_psymtabs): Use all_objfiles.
2057         (ALL_PSYMTABS): Remove.
2058         * compile/compile-object-run.c (do_module_cleanup): Use
2059         all_objfiles.
2060         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2061         * cp-support.c (add_symbol_overload_list_qualified): Use
2062         all_objfiles.
2063         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2064         Use all_objfiles.
2065         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2066         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2067         all_objfiles.
2068         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2069         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2070         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2071         Uses all_objfiles.
2072         * solib.c (solib_read_symbols): Use all_objfiles
2073
2074 2019-01-09  Tom Tromey  <tom@tromey.com>
2075
2076         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2077         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2078         all_objfiles.
2079         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2080         * symmisc.c (print_symbol_bcache_statistics)
2081         (print_objfile_statistics, maintenance_print_objfiles)
2082         (maintenance_info_symtabs, maintenance_check_symtabs)
2083         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2084         all_objfiles.
2085         * source.c (forget_cached_source_info): Use all_objfiles.
2086         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2087         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2088         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2089         * objfiles.c (update_section_map): Use all_objfiles.
2090         (shared_objfile_contains_address_p): Likewise.
2091         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2092         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2093
2094 2019-01-09  Tom Tromey  <tom@tromey.com>
2095
2096         * common/next-iterator.h: New file.
2097         * objfiles.h (class all_objfiles): New.
2098         (struct objfile_iterator): New.
2099
2100 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2101
2102         * NEWS: Move the description of the changed "frame", "select-frame",
2103          and "info frame" commands to the Changed commands section.
2104
2105 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2106
2107         * gdbtypes.c (check_stub_method_group): Remove handling of old
2108         mangling schemes.
2109         * linespec.c (find_methods): Likewise.
2110         * stabsread.c (read_member_functions): Likewise.
2111         * valops.c (search_struct_method): Likewise.
2112         (value_struct_elt_for_reference): Likewise.
2113         * NEWS: Mention this change.
2114
2115 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2116
2117         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2118         print_source_lines.
2119         * source.c (print_source_lines_base): Update line number check.
2120         (print_source_lines): New function.
2121         (source_lines_range::source_lines_range): New function.
2122         * source.h (class source_lines_range): New class.
2123         (print_source_lines): New declaration.
2124
2125 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2126
2127         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2128
2129 2019-01-08  Tom Tromey  <tom@tromey.com>
2130             Simon Marchi  <simon.marchi@ericsson.com>
2131
2132         PR gdb/24060
2133         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2134         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2135         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2136         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2137         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2138         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2139
2140 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2141
2142         * source.c (select_source_symtab): Move header comment to
2143         declaration in source.h.
2144         (forget_cached_source_info_for_objfile): Likewise.
2145         (forget_cached_source_info): Likewise.
2146         (identify_source_line): Likewise.
2147         * source.h (identify_source_line): Move declaration from symtab.h
2148         and add comment from source.c
2149         (print_source_lines): Likewise.
2150         (forget_cached_source_info_for_objfile): Likewise.
2151         (forget_cached_source_info): Likewise.
2152         (select_source_symtab): Likewise.
2153         (enum print_source_lines_flag): Move definition from symtab.h.
2154         * symtab.h (identify_source_line): Move declaration to source.h.
2155         (print_source_lines): Likewise.
2156         (forget_cached_source_info_for_objfile): Likewise.
2157         (forget_cached_source_info): Likewise.
2158         (select_source_symtab): Likewise.
2159         (enum print_source_lines_flag): Move definition to source.h.
2160         * tui/tui-hooks.c: Add 'source.h' include.
2161
2162 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2163
2164         * source.c (print_source_lines_base): Handle requests to print
2165         reverse line number sequences, and guard against empty lines
2166         string.
2167
2168 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2169
2170         * source.c (print_source_lines_base): Fix skip of '\r' if next
2171         character is '\n'.
2172
2173 2019-01-06  Tom Tromey  <tom@tromey.com>
2174
2175         * c-exp.y (struct c_parse_state) <macro_original_text,
2176         expansion_obstack>: New member.
2177         (macro_original_text, expansion_obstack): Remove globals.
2178         (scan_macro_expansion, scanning_macro_expansion)
2179         (finished_macro_expansion): Update.
2180         (scan_macro_cleanup): Remove.
2181         (yylex, c_parse): Update.
2182
2183 2019-01-06  Tom Tromey  <tom@tromey.com>
2184
2185         * c-exp.y (struct c_parse_state) <strings>: New member.
2186         (operator_stoken): Update.
2187
2188 2019-01-06  Tom Tromey  <tom@tromey.com>
2189
2190         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2191         (union type_stack_elt) <typelist_val>: Now a pointer to
2192         std::vector.
2193         (type_stack_cleanup): Don't declare.
2194         (push_typelist): Update.
2195         * parse.c (pop_typelist): Return a std::vector.
2196         (push_typelist): Take a std::vector.
2197         (follow_types): Update.  Do not free args.
2198         (type_stack_cleanup): Remove.
2199         * c-exp.y (struct c_parse_state): New.
2200         (cpstate): New global.
2201         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2202         (nonempty_typelist): Update.
2203         (func_mod): Create a new vector.
2204         (c_parse): Create a c_parse_state.
2205         (check_parameter_typelist): Do not delete params.
2206         (function_method): Update.  Do not delete type_list.
2207
2208 2019-01-06  Tom Tromey  <tom@tromey.com>
2209
2210         PR gdb/28155:
2211         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2212         check_typedef.
2213         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2214         (print_return_value): Likewise.
2215
2216 2019-01-05  Tom Tromey  <tom@tromey.com>
2217
2218         * contrib/cleanup_check.py: Remove.
2219         * contrib/gcc-with-excheck: Remove.
2220         * contrib/exsummary.py: Remove.
2221         * contrib/excheck.py: Remove.
2222
2223 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2224
2225         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2226         NULL. Initialize tpprev to NULL instead of assigning it
2227         to NULL on the next statement.
2228         * windows-nat.c (windows_delete_thread): Remove check for
2229         main_thread_id before printing thread exit notifications.
2230         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2231         Remove thread ID check against main_thread_id.
2232         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2233         windows_delete_thread.
2234         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2235
2236 2019-01-04  Tom Tromey  <tom@tromey.com>
2237
2238         * compile/compile.c (_initialize_compile): Use upper case for
2239         metasyntactic variables.
2240         * symmisc.c (_initialize_symmisc): Use upper case for
2241         metasyntactic variables.
2242         * psymtab.c (_initialize_psymtab): Use upper case for
2243         metasyntactic variables.
2244         * demangle.c (demangle_command): Use upper case for metasyntactic
2245         variables.
2246         (_initialize_demangler): Likewise.
2247         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2248         variables.
2249
2250 2019-01-03  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2253
2254 2019-01-03  Tom Tromey  <tom@tromey.com>
2255
2256         * python/py-symtab.c (salpy_str): Update.
2257         (struct salpy_sal_object) <symtab>: Now a PyObject.
2258         (salpy_dealloc): Update.
2259         (del_objfile_sal): Use gdbpy_ref.
2260
2261 2019-01-03  Tom Tromey  <tom@tromey.com>
2262
2263         * python/py-type.c (convert_field): Use new_reference.  Return
2264         gdbpy_ref.
2265         (make_fielditem): Return gdbpy_ref.
2266         (typy_fields): Update.
2267         (typy_getitem): Update.
2268         (field_name): Return gdbpy_ref.  Use new_reference.
2269         (typy_iterator_iternext): Update.
2270
2271 2019-01-03  Tom Tromey  <tom@tromey.com>
2272
2273         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2274
2275 2019-01-03  Tom Tromey  <tom@tromey.com>
2276
2277         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2278         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2279         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2280         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2281         (pspy_set_type_printers): Likewise.
2282         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2283         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2284         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2285         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2286         (objfpy_set_type_printers): Likewise.
2287
2288 2019-01-03  Tom Tromey  <tom@tromey.com>
2289
2290         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2291         (gdbpy_print_stack): Use gdbpy_err_fetch.
2292         * python/python-internal.h (class gdbpy_err_fetch): New class.
2293         (class gdbpy_enter) <m_error_type, m_error_value,
2294         m_error_traceback>: Remove.
2295         <m_error>: New member.
2296         (gdbpy_exception_to_string): Don't declare.
2297         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2298         * python/py-value.c (convert_value_from_python): Use
2299         gdbpy_err_fetch.
2300         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2301         gdbpy_exception_to_string.
2302         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2303         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2304         gdbpy_err_fetch.
2305
2306 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * linux-nat.c (delete_lwp_cleanup): Delete.
2309         (struct lwp_deleter): New struct.
2310         (lwp_info_up): New typedef.
2311         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2312         lwp_info_up.
2313
2314 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2315
2316         * linux-fork.c (class scoped_switch_fork_info): New class.
2317         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2318
2319 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2320
2321         * valops.c (find_overload_match): Remove use of null_cleanup, and
2322         calls to do_cleanups.
2323
2324 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2325
2326         * compile/compile-cplus-types.c
2327         (compile_cplus_instance::decl_name): Handle changes to
2328         cp_func_name.
2329         * cp-support.c (cp_func_name): Update header comment, update
2330         return type.
2331         * cp-support.h (cp_func_name): Update return type in declaration.
2332         * valops.c (find_overload_match): Move temp_func local to top
2333         level of function and change its type.  Use temp_func to hold and
2334         delete temporary string obtained from cp_func_name.
2335
2336 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2337
2338         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2339         gdb::char_vector, remove cleanup, and update uses of `msg`.
2340
2341 2019-01-03  Jim Wilson  <jimw@sifive.com>
2342
2343         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2344
2345 2019-01-02  Tom Tromey  <tom@tromey.com>
2346
2347         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2348         (tdesc_parse_xml): Remove cleanups.
2349         * target-descriptions.h (make_cleanup_free_target_description):
2350         Don't declare.
2351         (target_desc_deleter): New struct.
2352         (target_desc_up): New typedef.
2353         * target-descriptions.c (target_desc_deleter::operator()): Rename
2354         from free_target_description.
2355         (make_cleanup_free_target_description): Remove.
2356
2357 2019-01-02  Tom Tromey  <tom@tromey.com>
2358
2359         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2360         constructor, destructor.
2361         (linespec_parser): Remove typedef.
2362         (~linespec_parser): Rename from linespec_parser_delete.
2363         (linespec_lex_to_end, linespec_complete_label)
2364         (linespec_complete): Update.
2365         (decode_line_full): Remove cleanups.
2366         (decode_line_1): Update.
2367
2368 2019-01-02  Tom Tromey  <tom@tromey.com>
2369
2370         * python/python-internal.h (inferior_to_inferior_object): Change
2371         return type.
2372         * python/py-exitedevent.c (create_exited_event_object): Update.
2373         * python/py-inferior.c (inferior_to_inferior_object): Return
2374         gdbpy_ref.
2375         (python_new_inferior, python_inferior_deleted)
2376         (thread_to_thread_object, delete_thread_object)
2377         (build_inferior_list, gdbpy_selected_inferior): Update.
2378         * python/py-infthread.c (create_thread_object): Update.  Also fail
2379         if inferior_to_inferior_object fails.
2380
2381 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2382
2383         * inferior.h (class inferior) <displaced_step_state>: New field.
2384         * infrun.h (struct displaced_step_state): Move here from
2385         infrun.c.  Initialize fields, add constructor.
2386         <inf>: Remove field.
2387         <reset>: New method.
2388         * infrun.c (struct displaced_step_inferior_state): Move to
2389         infrun.h.
2390         (displaced_step_inferior_states): Remove.
2391         (get_displaced_stepping_state): Adust.
2392         (displaced_step_in_progress_any_inferior): Adjust.
2393         (displaced_step_in_progress_thread): Adjust.
2394         (displaced_step_in_progress): Adjust.
2395         (add_displaced_stepping_state): Remove.
2396         (get_displaced_step_closure_by_addr): Adjust.
2397         (remove_displaced_stepping_state): Remove.
2398         (infrun_inferior_exit): Call displaced_step_state.reset.
2399         (use_displaced_stepping): Don't check for NULL.
2400         (displaced_step_prepare_throw): Call
2401         get_displaced_stepping_state.
2402         (displaced_step_fixup): Don't check for NULL.
2403         (prepare_for_detach): Don't check for NULL.
2404
2405 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2406
2407         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2408          in case of call that did not complete.
2409
2410 2019-01-02  Andrey Utkin  <autkin@undo.io>
2411
2412         * symfile.c (find_separate_debug_file): Fix search of debug files for
2413         remote debuggee.
2414
2415 2019-01-02  Tom Tromey  <tom@tromey.com>
2416
2417         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2418         indentation.
2419         * python/py-frame.c (frapy_older): Remove cast.
2420         (frapy_newer): Likewise.
2421         * python/py-breakpoint.c (local_setattro): Remove cast.
2422         * python/py-arch.c (archpy_name): Remove local variable.
2423         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2424
2425 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2426
2427         * unittests/basic_string_view/element_access/char/empty.cc:
2428         Fix year range in copyright header.
2429
2430 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2431
2432         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2433         Delete.
2434         <operator==>: Update with for removed field.
2435         <hash>: Likewise.
2436         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2437         <isa_features>: ...this.
2438         <abi_features>: New field.
2439         (riscv_isa_flen): Update comment.
2440         (riscv_abi_xlen): New declaration.
2441         (riscv_abi_flen): New declaration.
2442         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2443         isa_features.
2444         (riscv_abi_xlen): New function.
2445         (riscv_isa_flen): Update to get answer from isa_features.
2446         (riscv_abi_flen): New function.
2447         (riscv_has_fp_abi): Update to get answer from abi_features.
2448         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2449         xlen and flen.
2450         (riscv_call_info) <xlen, flen>: Update comment.
2451         (riscv_call_arg_struct): Remove invalid assertions
2452         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2453         is removed.
2454         (riscv_gdbarch_init): Gather isa features and abi features
2455         separately, ensure both match on the gdbarch when reusing an old
2456         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2457         a target with 64-bit float hardware.
2458
2459 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2460
2461         * source.c (search_command_helper): Stop reverse search
2462         when line 1 has been searched.
2463
2464 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2465
2466         * record-full.c (record_full_base_target::close): Rewrite
2467         record_full_core_buf_list free logic.
2468
2469 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2470
2471         * break-catch-syscall.c (print_one_catch_syscall): xfree
2472         the last text.
2473
2474 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2475
2476         * top.c (print_gdb_version): Update Copyright year in version
2477         message.
2478
2479 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2480
2481         Update copyright year range in all GDB files.
2482
2483 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2484
2485         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2486
2487 For older changes see ChangeLog-2018.
2488 \f
2489 Local Variables:
2490 mode: change-log
2491 left-margin: 8
2492 fill-column: 74
2493 version-control: never
2494 coding: utf-8
2495 End:
2496