gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (make_source_window, make_disasm_window):
   4         Remove.
   5         (show_data): Unify creation and re-initialization cases.
   6
   7 2019-07-17  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-layout.c (make_command_window): Remove.
  10         (show_source_disasm_command, show_source_or_disasm_and_command):
  11         Unify creation and re-initialization cases.
  12
  13 2019-07-17  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
  16         creation and re-initialization cases.
  17
  18 2019-07-17  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-regs.c (tui_get_register): Return void.
  21
  22 2019-07-17  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
  25         Simplify.
  26
  27 2019-07-17  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-layout.c (show_source_disasm_command): Simplify window
  30         resetting.
  31
  32 2019-07-17  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui.h (tui_set_layout_by_name): Don't declare.
  35         * tui/tui-regs.c (tui_reg_layout): New function.
  36         (tui_show_registers, tui_reg_command): Use it.
  37         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
  38         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
  39         parameters.
  40         (tui_layout_command): Remove.
  41
  42 2019-07-17  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-layout.h (tui/tui-layout): Return void.
  45         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
  46
  47 2019-07-17  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-layout.c (show_source_disasm_command, show_data):
  50         Update.
  51         (reset_locator): Remove.
  52         (show_source_or_disasm_and_command): Update.
  53
  54 2019-07-17  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-source.c (tui_source_window_base::reset): Remove
  57         win_type parameter.
  58         * tui/tui-layout.c (make_command_window, make_source_window)
  59         (make_disasm_window, make_data_window)
  60         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  61         (reset_locator, show_source_or_disasm_and_command): Update.
  62         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  63         win_type parameter.
  64         (struct tui_source_window_base) <reset>: Likewise.
  65
  66 2019-07-17  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-layout.c (show_source_disasm_command): Use
  69         reset_locator.
  70         (reset_locator): New function.
  71         (init_and_make_win): Remove.
  72         (show_source_or_disasm_and_command): Use reset_locator.
  73
  74 2019-07-17  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  77         condition.
  78         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
  79         Remove condition.
  80         * tui/tui-source.c (tui_source_window_base::reset): New method.
  81         * tui/tui-layout.c (make_command_window): Don't call
  82         init_and_make_win.
  83         (make_source_window, make_disasm_window): Don't call
  84         make_source_or_disasm_window.
  85         (make_data_window): Don't call init_and_make_win.  Change calling
  86         convention.
  87         (show_source_disasm_command, show_data): Simplify.
  88         (make_source_or_disasm_window): Remove.
  89         (show_source_or_disasm_and_command): Simplify.
  90         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  91         (struct tui_source_window_base) <reset>: Likewise.
  92         <execution_info>: Remove initializer.
  93         * tui/tui-data.c (tui_source_window_base): Initialize
  94         execution_info.
  95
  96 2019-07-17  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
  99         variable.
 100
 101 2019-07-17  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui.c (tui_rl_other_window): Update.
 104         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 105         superclass method first.  Always iterate over regs_content.
 106         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 107         method.
 108         * tui/tui-win.c (tui_set_focus_command): Update.
 109
 110 2019-07-17  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-win.c (tui_set_focus_command): Rename from
 113         tui_set_focus.  Call tui_enable.
 114         (tui_set_focus_command): Remove.
 115
 116 2019-07-17  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 119         refresh_window.
 120         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 121         touchwin.
 122         (tui_data_window::refresh_window): Call refresh_window on data
 123         items.  Always call superclass refresh_window.
 124         (tui_win_info::refresh): Remove.
 125         (tui_source_window_base::refresh_window): Update.
 126         (tui_refresh_all): Update.
 127         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 128         refresh_window.
 129         (show_source_or_disasm_and_command): Likewise.
 130         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 131         (struct tui_source_window_base) <refresh>: Likewise.
 132
 133 2019-07-17  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-winsource.c (tui_clear_source_content)
 136         (tui_show_source_content): Update.
 137         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 138         whether content is empty.
 139         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 140         Remove.
 141
 142 2019-07-17  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 145         window's contents.
 146         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 147         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 148
 149 2019-07-17  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 152         (struct tui_data_item_window): Update.
 153
 154 2019-07-17  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 157         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 158         defines.
 159
 160 2019-07-17  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-winsource.h (tui_erase_source_content)
 163         (tui_clear_source_content): Remove "display_prompt" parameter.
 164         * tui/tui-winsource.c (tui_update_source_window_as_is)
 165         (tui_update_source_windows_with_addr): Update.
 166         (tui_clear_source_content): Remove "display_prompt" parameter.
 167         (tui_erase_source_content): Likewise.  Simplify.
 168         (tui_show_source_content): Update.
 169         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 170         * tui/tui-stack.c (tui_show_frame_info): Update.
 171         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 172         Remove defines.
 173
 174 2019-07-17  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 177         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 178         parameter.
 179         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 180         parameter.
 181
 182 2019-07-17  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-winsource.c (tui_clear_source_content)
 185         (tui_show_source_content, tui_show_exec_info_content)
 186         (tui_clear_exec_info_content): Update.
 187         * tui/tui-stack.c (tui_show_locator_content): Update.
 188         (tui_show_frame_info): Update.
 189         * tui/tui-source.h (tui_source_window): Don't declare.
 190         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 191         from tui_source_is_displayed.
 192         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 193         Remove field.
 194         (struct tui_source_window_base) <content_in_use>: New field.  Now
 195         bool.
 196         (struct tui_source_window) <showing_source_p>: New method.
 197         (TUI_SRC_WIN): Change cast.
 198         * tui/tui-data.c (tui_initialize_static_data): Update.
 199
 200 2019-07-17  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 203         location_matches_p.
 204         * tui/tui-source.c (tui_source_window::location_matches_p): New
 205         method.
 206         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 207         method.
 208         * tui/tui-data.h (struct tui_source_window_base)
 209         <location_matches_p>: New method.
 210         (struct tui_source_window, struct tui_disasm_window)
 211         <location_matches_p>: Likewise.
 212
 213 2019-07-17  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-win.c (tui_set_win_height_command): Rename from
 216         tui_set_win_height.
 217         (tui_set_win_height_command): Remove.
 218
 219 2019-07-17  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-source.c (tui_source_window): New constructor.  Add
 222         observer.
 223         (~tui_source_window): New destructor.
 224         (tui_source_window::style_changed): New method.
 225         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 226         (tui_attach_detach_observers): Update.
 227         * tui/tui-data.h (struct tui_source_window): Make constructor not
 228         inline.  Add destructor.
 229         (struct tui_source_window) <style_changed>: New method.
 230         <m_observable>: New member.
 231
 232 2019-07-17  Tom Tromey  <tom@tromey.com>
 233
 234         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 235         * tui/tui-win.c (tui_resize_all): Fix typo.
 236
 237 2019-07-17  Tom Tromey  <tom@tromey.com>
 238
 239         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 240         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 241         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 242         * tui/tui-win.c (window_name_completer): Use foreach.
 243         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 244         (update_tab_width): Likewise.
 245         * tui/tui-layout.c (show_layout): Update.
 246         * tui/tui-data.h (class tui_window_iterator): New.
 247         (struct all_tui_windows): New.
 248         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 249
 250 2019-07-17  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 253         parameter.  Don't reference globals.
 254         (tui_reg_command): Update.
 255
 256 2019-07-17  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-regs.c (tui_show_registers): Simplify.
 259
 260 2019-07-17  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-regs.c (tui_show_registers): Update.
 263         (tui_show_register_group): Add win_info parameter.
 264
 265 2019-07-17  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 268         Rename from tui_display_reg_element_at_line.
 269         (tui_data_window::display_registers_from_line): Update.
 270         * tui/tui-data.h (struct tui_data_window)
 271         <display_reg_element_at_line>: New method.
 272
 273 2019-07-17  Tom Tromey  <tom@tromey.com>
 274
 275         * tui/tui-regs.h (tui_display_registers_from)
 276         (tui_display_registers_from_line): Don't declare.
 277         * tui/tui-windata.c (tui_data_window::display_all_data)
 278         (tui_data_window::refresh_all)
 279         (tui_data_window::do_scroll_vertical): Update.
 280         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 281         from tui_display_registers_from.
 282         (tui_display_reg_element_at_line): Update.
 283         (tui_data_window::display_registers_from_line): Rename from
 284         tui_display_registers_from_line.
 285         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 286         display_registers_from_line>: New methods.
 287
 288 2019-07-17  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 291         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 292         from tui_erase_data_content.
 293         (tui_data_window::display_all_data)
 294         (tui_data_window::refresh_all)
 295         (tui_data_window::do_scroll_vertical): Update.
 296         * tui/tui-regs.c (tui_show_registers): Update.
 297         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 298         New method.
 299
 300 2019-07-17  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 303         declare.
 304         * tui/tui-windata.c
 305         (tui_data_window::delete_data_content_windows): Rename from
 306         tui_delete_data_content_windows.
 307         (tui_data_window::display_all_data)
 308         (tui_data_window::do_scroll_vertical): Update.
 309         * tui/tui-data.h (struct tui_data_window)
 310         <delete_data_content_windows>: New method.
 311
 312 2019-07-17  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 315         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 316
 317 2019-07-17  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 320         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 321         from tui_display_all_data.
 322         * tui/tui-win.c
 323         (tui_data_window::do_make_visible_with_new_height): Update.
 324         * tui/tui-regs.c (tui_show_registers): Update.
 325         * tui/tui-layout.c (tui_set_layout): Update.
 326         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 327         method.
 328
 329 2019-07-17  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 332         * tui/tui-windata.c (tui_display_data_from): Remove.
 333         (tui_data_window::refresh_all): Update.
 334
 335 2019-07-17  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 338         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 339         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 340         tui_display_registers_from_line.
 341         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 342         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 343         "force_display" parameter.
 344
 345 2019-07-17  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 348         declare.
 349         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 350         Rename from tui_first_reg_element_no_inline.
 351         (tui_display_reg_element_at_line)
 352         (tui_display_registers_from_line): Update.
 353         * tui/tui-data.h (struct tui_data_window)
 354         <first_reg_element_no_inline>: New method.
 355
 356 2019-07-17  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-windata.c (tui_display_data_from)
 359         (tui_data_window::do_scroll_vertical): Update.
 360         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 361         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 362         Rename from tui_line_from_reg_element_no.
 363         (tui_display_registers_from_line): Update.
 364         * tui/tui-data.h (struct tui_data_window)
 365         <line_from_reg_element_no>: New method.
 366
 367 2019-07-17  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 370         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 371         tui_last_regs_line_no.
 372         (tui_display_reg_element_at_line)
 373         (tui_display_registers_from_line): Update.
 374         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 375         method.
 376
 377 2019-07-17  Tom Tromey  <tom@tromey.com>
 378
 379         PR tui/24722:
 380         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 381         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 382         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 383         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 384         (tui_update_breakpoint_info): Likewise.
 385         * tui/tui-hooks.c (tui_event_create_breakpoint)
 386         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 387         Update.
 388
 389 2019-07-17  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 392
 393 2019-07-17  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-winsource.c (tui_update_source_window_as_is)
 396         (tui_update_source_windows_with_addr): Update.
 397         * tui/tui-source.h (tui_set_source_content)
 398         (tui_show_symtab_source): Add "win_info" parameter.
 399         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 400         parameter.
 401         (tui_show_symtab_source): Likewise.
 402
 403 2019-07-17  Tom Tromey  <tom@tromey.com>
 404
 405         * tui/tui-wingeneral.c
 406         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 407
 408 2019-07-17  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 411         (struct tui_cmd_window) <can_scroll>: New method.
 412         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 413         method.
 414
 415 2019-07-17  Tom Tromey  <tromey@adacore.com>
 416
 417         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 418         do_field_signed>: Rename.  Change type of "value".
 419         * ui-out.c (ui_out::field_signed): Rename from field_int.
 420         Change type of "value".
 421         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 422         type of "value".
 423         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 424         do_field_int.  Change type of "value".
 425         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 426         do_field_int.  Change type of "value".
 427         * tracepoint.c (trace_status_mi, tfind_1)
 428         (print_one_static_tracepoint_marker): Update.
 429         * thread.c (print_thread_info_1, print_selected_thread_frame):
 430         Update.
 431         * stack.c (print_frame, print_frame_info): Update.
 432         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 433         Update.
 434         * source.c (print_source_lines_base): Update.
 435         * skip.c (info_skip_command): Update.
 436         * record-btrace.c (btrace_ui_out_decode_error)
 437         (btrace_call_history_src_line): Update.
 438         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 439         Update.
 440         * progspace.c (print_program_space): Update.
 441         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 442         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 443         do_field_int.  Change type of "value".
 444         * mi/mi-out.c (mi_ui_out::do_table_begin)
 445         (mi_ui_out::do_table_header): Update.
 446         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 447         type of "value".
 448         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 449         (mi_cmd_data_list_changed_registers, output_register)
 450         (mi_cmd_data_read_memory, mi_load_progress)
 451         (mi_cmd_trace_frame_collected): Update.
 452         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 453         Update.
 454         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 455         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 456         (mi_cmd_var_list_children, varobj_update_one): Update.
 457         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 458         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 459         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 460         * inferior.c (print_inferior): Update.
 461         * gdb_bfd.c (print_one_bfd): Update.
 462         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 463         Update.
 464         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 465         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 466         do_field_int.  Change type of "value".
 467         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 468         do_field_int.  Change type of "value".
 469         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 470         (print_one_breakpoint_location, print_it_catch_fork)
 471         (print_one_catch_fork, print_it_catch_vfork)
 472         (print_one_catch_vfork, print_it_catch_solib)
 473         (print_it_catch_exec, print_it_ranged_breakpoint)
 474         (print_mention_watchpoint, print_mention_masked_watchpoint)
 475         (bkpt_print_it, update_static_tracepoint): Update.
 476         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 477         * break-catch-syscall.c (print_it_catch_syscall): Update.
 478         * ada-tasks.c (print_ada_task_info): Update.
 479         * ada-lang.c (print_it_exception, print_mention_exception):
 480         Update.
 481
 482 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 483
 484         PR breakpoints/24541
 485         * gdbarch.c: Regenerate.
 486         * gdbarch.h: Regenerate.
 487         * gdbarch.sh: Adjust return type and parameter types for
 488         'stap_adjust_register'.
 489         (i386_stap_adjust_register): Adjust signature and return new
 490         register name.
 491         * stap-probe.c (stap_parse_register_operand): Adjust use of
 492         'gdbarch_stap_adjust_register'.
 493
 494 2019-07-17  Tom Tromey  <tromey@adacore.com>
 495
 496         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 497         declare VEC.
 498         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 499         std::vector.
 500         (struct s390_process_info): Add initializers.
 501         (s390_add_process): Use new.
 502         (s390_linux_nat_target::low_forget_process): Use delete.
 503         (s390_linux_nat_target::low_new_fork)
 504         (s390_linux_nat_target::stopped_by_watchpoint)
 505         (s390_linux_nat_target::low_prepare_to_resume)
 506         (s390_linux_nat_target::insert_watchpoint)
 507         (s390_linux_nat_target::insert_hw_breakpoint)
 508         (s390_linux_nat_target::remove_watchpoint)
 509         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 510
 511 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 512
 513         * aarch64-fbsd-nat.c: Include regcache.h.
 514         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 515         argument.
 516         (aarch64_fbsd_nat_target::fetch_registers)
 517         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 518         variable.
 519         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 520
 521 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 522
 523         * fbsd-nat.c: Include gdbarch.h.
 524
 525 2019-07-15  Tom Tromey  <tromey@adacore.com>
 526
 527         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 528
 529 2019-07-15  Tom Tromey  <tromey@adacore.com>
 530
 531         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 532         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 533         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 534         * cli-out.c (cli_ui_out::do_field_int): New method.
 535         * ui-out.c (ui_out::field_unsigned): New method.
 536         * symfile.c (generic_load): Use field_unsigned.
 537         (print_transfer_performance): Likewise.
 538         * record-btrace.c (ui_out_field_uint): Remove.
 539         (btrace_call_history_insn_range, btrace_call_history): Use
 540         field_unsigned.
 541         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 542         field_unsigned.
 543         * ui-out.h (class ui_out) <field_unsigned>: New method.
 544         <do_field_unsigned>: Likewise.
 545
 546 2019-07-15  Tom Tromey  <tromey@adacore.com>
 547
 548         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 549         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 550         * target.c (flash_erase_command): Use field_string.
 551         * infrun.c (print_signal_received_reason): Use field_string.
 552         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 553         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 554         field_string.
 555         * ada-tasks.c (print_ada_task_info): Use field_string.
 556
 557 2019-07-15  Tom Tromey  <tromey@adacore.com>
 558
 559         * target.c (flash_erase_command): Use field_core_addr.
 560         * symfile.c (generic_load): Use field_core_addr.
 561         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 562         Use field_core_addr.
 563         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 564         field_core_addr.
 565
 566 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 567
 568         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 569         value if its desired type is smaller than a CORE_ADDR and signed.
 570
 571 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 572
 573         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 574         of changes to field names, and use new is_reference field to
 575         decide if a property is a reference or not.
 576         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 577         field.
 578         (struct dwarf2_property_baton): Update header comment, rename
 579         'referenced_type' to 'property_type' and update comments.
 580         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 581         default property type, store in property baton, update to take
 582         accound of renamed field.
 583         (read_func_scope): Update call to attr_to_dynamic_prop.
 584         (read_array_type): Likewise.
 585         (dwarf2_per_cu_addr_sized_int_type): New function.
 586         (read_subrange_index_type): Move type finding code to
 587         dwarf2_per_cu_addr_sized_int_type.
 588         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 589         (dwarf2_per_cu_addr_type): New function.
 590         (set_die_type): Update calls to attr_to_dynamic_prop.
 591
 592 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 593
 594         * dwarf2read.c (read_subrange_index_type): New function.
 595         (read_subrange_type): Move code into new function and call it.
 596         * gdbtypes.c (create_range_type): Add some asserts.
 597
 598 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 599
 600         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 601         update return statements.
 602         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 603         declaration, and update comment to match.
 604         * gdbtypes.c (resolve_dynamic_array): Update call to
 605         dwarf2_evaluate_property to match new return type.
 606
 607 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 608
 609         * valarith.c (value_subscripted_rvalue): Change lowerbound
 610         parameter type from int to LONGEST.
 611         * value.h (value_subscripted_rvalue): Likewise in declaration.
 612
 613 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 614
 615         * cli/cli-utils.c (info_print_command_completer): New function.
 616         * cli/cli-utils.h: Add 'completer.h' include, and forward
 617         declaration for 'struct cmd_list_element'.
 618         (info_print_command_completer): Declare.
 619         * stack.c (_initialize_stack): Add completer for 'info locals' and
 620         'info args'.
 621         * symtab.c (_initialize_symtab): Add completer for 'info
 622         variables' and 'info functions'.
 623         * NEWS: Mention completion for additional info commands.
 624
 625 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 626
 627         * cli/cli-utils.c (extract_info_print_args): Delete.
 628         (extract_arg_maybe_quoted): Delete.
 629         (info_print_options_defs): New variable.
 630         (make_info_print_options_def_group): New function.
 631         (extract_info_print_options): Define new function.
 632         * cli/cli-utils.h (extract_info_print_args): Delete.
 633         (struct info_print_options): New structure.
 634         (extract_info_print_options): Declare new function.
 635         * stack.c (info_locals_command): Update to use new
 636         extract_info_print_options, also add a header comment.
 637         (info_args_command): Likewise.
 638         * symtab.c (info_variables_command): Likewise.
 639         (info_functions_command): Likewise.
 640
 641 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 642
 643         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 644         to extract string arguments.
 645         * common/common-utils.c (extract_string_maybe_quoted): New function.
 646         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 647
 648 2019-07-11  Tom Tromey  <tromey@adacore.com>
 649
 650         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 651         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 652         * top.h (gdbinit): Don't declare.
 653         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 654         into...
 655         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 656         * top.c (gdb_init): Don't call init_cli_cmds.
 657         (gdbinit): Remove.
 658         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 659
 660 2019-07-11  Tom Tromey  <tromey@adacore.com>
 661
 662         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 663         after it has been moved.
 664
 665 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 666
 667         * valops.c (value_must_coerce_to_target): Change return type to
 668         bool.
 669         * value.h (value_must_coerce_to_target): Likewise.
 670
 671 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 672
 673         * breakpoint.c (is_hardware_watchpoint): Remove
 674         forward-declaration.
 675         (is_masked_watchpoint): Change return type to bool.
 676         (is_tracepoint): Likewise.
 677         (is_breakpoint): Likewise.
 678         (is_hardware_watchpoint): Likewise.
 679         (is_watchpoint): Likewise.
 680         (is_no_memory_software_watchpoint): Likewise.
 681         (is_catchpoint): Likewise.
 682         (breakpoint_1): Make FILTER parameter's return type bool.
 683         is_masked_watchpoint): Change return type to bool.
 684         (save_breakpoints): Make FILTER parameter's return type bool.
 685         * breakpoint.h (is_breakpoint): Change return type to bool.
 686         (is_watchpoint): Likewise.
 687         (is_catchpoint): Likewise.
 688         (is_tracepoint): Likewise.
 689
 690 2019-07-10  Tom Tromey  <tom@tromey.com>
 691
 692         * defs.h: Don't include gdbarch.h.
 693         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 694         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 695         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 696         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 697         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 698         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 699         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 700         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 701         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 702         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 703         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 704         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 705         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 706         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 707         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 708         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 709         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 710         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 711         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 712         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 713         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 714         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 715         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 716         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 717         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 718         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 719         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 720
 721 2019-07-10  Tom Tromey  <tromey@adacore.com>
 722
 723         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 724         * breakpoint.c (init_ada_exception_breakpoint): Register as
 725         bp_catchpoint.
 726         (print_one_breakpoint_location, print_one_breakpoint): Use
 727         is_ada_exception_catchpoint.
 728         * ada-lang.c (class ada_catchpoint_location): Pass
 729         bp_loc_software_breakpoint to bp_location constructor.
 730         (is_ada_exception_catchpoint): New function.
 731
 732 2019-07-10  Tom Tromey  <tromey@adacore.com>
 733
 734         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 735         VEC.
 736         (struct arm_exidx_entry): New method operator<.
 737         (struct arm_exidx_data) <section_maps>: Change type.
 738         (arm_exidx_data_free): Remove.
 739         (arm_exidx_data_key): Change type.  Move lower.
 740         (arm_exidx_new_objfile): Update.
 741         (arm_compare_exidx_entries): Remove.
 742         (arm_find_exidx_entry, _initialize_arm_tdep)
 743
 744 2019-07-10  Tom Tromey  <tromey@adacore.com>
 745
 746         * solib-spu.c (ocl_program_data_key): Change type.
 747         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 748         Update.
 749
 750 2019-07-10  Tom Tromey  <tromey@adacore.com>
 751
 752         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 753         (struct solib_aix_inferior_data) <library_list>: Change type.
 754         (solib_aix_inferior_data_handle): Change type.
 755         (get_solib_aix_inferior_data): Update.
 756         (solib_aix_free_library_list): Remove.
 757         (library_list_start_library): Update.
 758         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 759         return type.
 760         (solib_aix_get_library_list)
 761         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 762         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 763
 764 2019-07-10  Tom Tromey  <tromey@adacore.com>
 765
 766         * solib-dsbt.c (struct dsbt_info): Add initializers.
 767         (solib_dsbt_pspace_data): Change type.
 768         (dsbt_pspace_data_cleanup): Remove.
 769         (get_dsbt_info, _initialize_dsbt_solib): Update.
 770
 771 2019-07-10  Tom Tromey  <tromey@adacore.com>
 772
 773         * spu-tdep.c (spu_overlay_data): Change type.
 774         (spu_get_overlay_table, spu_overlay_new_objfile)
 775         (_initialize_spu_tdep): Update.
 776
 777 2019-07-10  Tom Tromey  <tromey@adacore.com>
 778
 779         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 780         destructor.
 781         (dbx_objfile_data_key): Change type and declare later.
 782         (DBX_SYMFILE_INFO): Rewrite.
 783         * dbxread.c (dbx_objfile_data_key): Change type.
 784         (dbx_symfile_init): Update.
 785         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 786         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 787         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 788
 789 2019-07-10  Tom Tromey  <tromey@adacore.com>
 790
 791         * jit.c (jit_program_space_key): Change type.  Move lower.
 792         (get_jit_program_space_data): Update.
 793         (jit_program_space_data_cleanup): Remove.
 794         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 795         Update.
 796         (struct jit_program_space_data): Add initializers.
 797
 798 2019-07-10  Tom Tromey  <tromey@adacore.com>
 799
 800         * solib-darwin.c (struct darwin_info): Add initializers.
 801         (solib_darwin_pspace_data): Change type.
 802         (darwin_pspace_data_cleanup): Remove.
 803         (get_darwin_info, _initialize_darwin_solib): Update.
 804
 805 2019-07-10  Tom Tromey  <tromey@adacore.com>
 806
 807         * remote-sim.c (struct sim_inferior_data): Add initializers,
 808         constructor, and destructor.
 809         (sim_inferior_data_key): Change type.  Move lower.
 810         (check_for_duplicate_sim_descriptor): Update.
 811         (get_sim_inferior_data): Use new.  Update.
 812         (~sim_inferior_data_cleanup): Rename from
 813         sim_inferior_data_cleanup.  Simplify.
 814         (gdbsim_close_inferior, simulator_command)
 815         (sim_command_completer, _initialize_remote_sim): Update.
 816         (next_pid, INITIAL_PID): Move earlier.
 817
 818 2019-07-10  Tom Tromey  <tromey@adacore.com>
 819
 820         * python/python-internal.h (create_thread_object): Return
 821         gdbpy_ref.
 822         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 823         * python/py-inferior.c (struct threadlist_entry): Add
 824         constructor.
 825         <thread_obj>: Now a gdbpy_ref.
 826         (thread_to_thread_object): Update.
 827         (add_thread_object): Use new.
 828         (delete_thread_object): Use delete.
 829         (infpy_threads): Update.
 830         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 831         GIL.
 832
 833 2019-07-10  Tom Tromey  <tromey@adacore.com>
 834
 835         * valops.c (value_cast): Specialize error message for Ada.
 836
 837 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 838
 839         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 840
 841 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 842
 843         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 844         bpstat_should_step): Return bool, adjust comments.
 845         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 846         bpstat_should_step): Likewise.
 847
 848 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 849
 850         * features/Makefile: Use feature target descriptions for Arm.
 851         * features/arm/arm-core.c: Generate new file.
 852         * features/arm/arm-fpa.c: Likewise.
 853         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 854         * features/arm/arm-m-profile.c: Likewise.
 855         * features/arm/arm-vfpv2.c: Likewise.
 856         * features/arm/arm-vfpv3.c: Likewise.
 857         * features/arm/xscale-iwmmxt.c: Likewise.
 858         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 859
 860 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 861
 862         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 863         ptrace earlier.
 864
 865 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 866
 867         * features/aarch64-pauth.c: Regenerate.
 868
 869 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 870
 871         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 872         bool.
 873         (bpstat_what): Use false instead of 0.
 874
 875 2019-07-09  Pedro Alves  <palves@redhat.com>
 876
 877         * break-catch-throw.c (is_exception_catchpoint): New.
 878         * breakpoint.c (print_one_breakpoint_location): New parameter
 879         'raw_loc'.  Handle it.  Use
 880         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 881         looking at the breakpoint's type.
 882         (print_one_breakpoint): If handling "maint info breakpoints", also
 883         print locations of exception catchpoints.
 884         * breakpoint.h (is_exception_catchpoint): Declare.
 885
 886 2019-07-09  Pedro Alves  <palves@redhat.com>
 887
 888         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 889         "addr" field.
 890         (allocate_location_exception_catchpoint): New.
 891         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 892         (initialize_throw_catchpoint_ops): Install
 893         allocate_location_exception_catchpoint as allocate_location
 894         method.
 895         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 896         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 897         bp_loc_other.
 898         (breakpoint_address_is_meaningful): Delete.
 899         (bl_address_is_meaningful): New.
 900         (breakpoint_locations_match): Adjust comment.
 901         (bp_location_from_bp_type): New, factored out of...
 902         (bp_location::bp_location(breakpoint *)): ... this.
 903         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 904         factored out of...
 905         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 906         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 907         breakpoint_address_is_meaningful.
 908         (bp_locations_compare): Adjust comment.
 909         (update_global_location_list): Use bl_address_is_meaningful
 910         instead of breakpoint_address_is_meaningful.
 911         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 912         explicit.
 913         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 914         * python/py-breakpoint.c (bppy_get_location): No longer check
 915         whether location is null.
 916
 917 2019-07-09  Pedro Alves  <palves@redhat.com>
 918
 919         PR c++/15468
 920         * breakpoint.c (print_one_breakpoint_location): Remove
 921         single-location assert.
 922
 923 2019-07-09  Tom Tromey  <tom@tromey.com>
 924
 925         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 926         * configure: Rebuild.
 927         * configure.ac: Change common to gdbsupport.
 928         * gdbsupport: Rename from common.
 929         * acinclude.m4: Change common to gdbsupport.
 930         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 931         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 932         gdbsupport.
 933         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 934         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 935         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 936         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 937         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 938         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 939         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 940         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 941         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 942         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 943         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 944         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 945         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 946         coff-pe-read.c, command.h, compile/compile-c-support.c,
 947         compile/compile-c.h, compile/compile-cplus-symbols.c,
 948         compile/compile-cplus-types.c, compile/compile-cplus.h,
 949         compile/compile-loc2c.c, compile/compile.c, completer.c,
 950         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 951         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 952         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 953         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 954         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 955         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 956         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 957         features/aarch64-core.c, features/aarch64-fpu.c,
 958         features/aarch64-pauth.c, features/aarch64-sve.c,
 959         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 960         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 961         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 962         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 963         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 964         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 965         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 966         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 967         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 968         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 969         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 970         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 971         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 972         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 973         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 974         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 975         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 976         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 977         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 978         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 979         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 980         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 981         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 982         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 983         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 984         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 985         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 986         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 987         minsyms.c, mips-linux-tdep.c, namespace.h,
 988         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 989         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 990         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 991         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 992         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 993         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 994         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 995         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 996         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 997         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 998         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 999         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1000         procfs.c, producer.c, progspace.h, psymtab.h,
1001         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1002         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1003         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1004         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1005         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1006         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1007         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1008         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1009         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1010         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1011         target-memory.c, target.c, target.h, target/waitstatus.c,
1012         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1013         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1014         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1015         unittests/array-view-selftests.c,
1016         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1017         unittests/common-utils-selftests.c,
1018         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1019         unittests/format_pieces-selftests.c,
1020         unittests/function-view-selftests.c,
1021         unittests/lookup_name_info-selftests.c,
1022         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1023         unittests/mkdir-recursive-selftests.c,
1024         unittests/observable-selftests.c,
1025         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1026         unittests/parse-connection-spec-selftests.c,
1027         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1028         unittests/scoped_fd-selftests.c,
1029         unittests/scoped_mmap-selftests.c,
1030         unittests/scoped_restore-selftests.c,
1031         unittests/string_view-selftests.c, unittests/style-selftests.c,
1032         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1033         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1034         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1035         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1036         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1037         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1038
1039 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1040
1041         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1042         bool value.
1043         (decode_digits_ordinary): Set explicit_line field in sal.
1044         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1045         symtab_and_line that was set on an explicit line number in
1046         assembler code.  Do always update the recorded symtab and line if
1047         we do skip the prologue.
1048
1049 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1050
1051         * breakpoint.c (set_breakpoint_location_function): Remove
1052         explicit_loc parameter.
1053         (momentary_breakpoint_from_master): Update call to
1054         set_breakpoint_location_function.
1055         (add_location_to_breakpoint): Likewise.
1056
1057 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1058
1059         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1060         required features based on default bfd type when no specific bfd
1061         is present.
1062
1063 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1064
1065         * NEWS: Mention that GDB printf and eval commands can now print
1066         C-style and Ada-style convenience var strings without
1067         calling the inferior.
1068         * printcmd.c (printf_c_string): Locally print GDB internal var
1069         instead of transiting via the inferior.
1070         (printf_wide_c_string): Likewise.
1071
1072 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1073
1074         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1075
1076 2019-07-04  Tom Tromey  <tom@tromey.com>
1077
1078         PR tui/24724:
1079         * tui/tui-winsource.c (tui_clear_source_content): Update.
1080         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1081         (tui_update_breakpoint_info): Update.
1082         (tui_set_exec_info_content): Update.
1083         * tui/tui-source.c (tui_set_source_content_nil): Update.
1084         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1085         has_break.
1086         * tui/tui-data.h (enum tui_bp_flag): New.
1087         (tui_bp_flags): New enum flags type.
1088         (struct tui_source_element) <break_mode>: Change type.  Rename
1089         from has_break.
1090         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1091         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1092         constants.
1093         * tui/tui-winsource.h: Fix comment.
1094
1095 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1096
1097         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1098         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1099         (store_fpregs_to_thread)
1100         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1101         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1102         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1103         (IWMMXT_REGS_SIZE): Add define.
1104         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1105         (fetch_vfp_regs, store_vfp_regs)
1106         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1107         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1108
1109 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1110
1111         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1112         defines.
1113         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1114         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1115         (ARM_INT_REGISTER_SIZE): ...to this.
1116         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1117         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1118         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1119         (arm_linux_collect_gregset, supply_nwfpe_register)
1120         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1121         defines.
1122         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1123         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1124         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1125         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1126         (arm_return_in_memory, arm_store_return_value)
1127         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1128         (arm_record_ld_st_multiple): Likewise.
1129         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1130         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1131
1132 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1133
1134         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1135         AARCH64_DISPLACED_MODIFIED_INSNS.
1136         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1137         (aarch64_displaced_step_copy_insn): Likewise.
1138         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1139         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1140         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1141         ARM_DISPLACED_MODIFIED_INSNS.
1142         * arm-tdep.c (arm_gdbarch_init): Likewise.
1143         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1144         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1145         (struct arm_displaced_step_closure): Use
1146         ARM_DISPLACED_MODIFIED_INSNS.
1147
1148 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1149
1150         * features/Makefile: Remove unused xml files.
1151         * features/aarch64.xml: Remove.
1152         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1153         * features/i386/amd64-avx-avx512.xml: Remove.
1154         * features/i386/amd64-avx-linux.xml: Remove.
1155         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1156         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1157         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1158         * features/i386/amd64-avx-mpx.xml: Remove.
1159         * features/i386/amd64-avx.xml: Remove.
1160         * features/i386/amd64-linux.xml: Remove.
1161         * features/i386/amd64-mpx-linux.xml: Remove.
1162         * features/i386/amd64-mpx.xml: Remove.
1163         * features/i386/amd64.xml: Remove.
1164         * features/i386/i386-avx-avx512-linux.xml: Remove.
1165         * features/i386/i386-avx-avx512.xml: Remove.
1166         * features/i386/i386-avx-linux.xml: Remove.
1167         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1168         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1169         * features/i386/i386-avx-mpx-linux.xml: Remove.
1170         * features/i386/i386-avx-mpx.xml: Remove.
1171         * features/i386/i386-avx.xml: Remove.
1172         * features/i386/i386-linux.xml: Remove.
1173         * features/i386/i386-mmx-linux.xml: Remove.
1174         * features/i386/i386-mmx.xml: Remove.
1175         * features/i386/i386-mpx-linux.xml: Remove.
1176         * features/i386/i386-mpx.xml: Remove.
1177         * features/i386/i386.xml: Remove.
1178         * features/i386/x32-avx-avx512-linux.xml: Remove.
1179         * features/i386/x32-avx-linux.xml: Remove.
1180         * features/i386/x32-linux.xml: Remove.
1181
1182 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1183
1184         * regformats/aarch64.dat: Remove.
1185         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1186         * regformats/i386/amd64-avx-linux.dat: Remove.
1187         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1188         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1189         * regformats/i386/amd64-linux.dat: Remove.
1190         * regformats/i386/amd64-mpx-linux.dat: Remove.
1191         * regformats/i386/amd64.dat: Remove.
1192         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1193         * regformats/i386/i386-avx-linux.dat: Remove.
1194         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1195         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1196         * regformats/i386/i386-linux.dat: Remove.
1197         * regformats/i386/i386-mmx-linux.dat: Remove.
1198         * regformats/i386/i386-mpx-linux.dat: Remove.
1199         * regformats/i386/i386.dat: Remove.
1200         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1201         * regformats/i386/x32-avx-linux.dat: Remove.
1202         * regformats/i386/x32-linux.dat: Remove.
1203
1204 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1205
1206         * aarch64-tdep.c: Remove xml self tests.
1207         * amd64-linux-tdep.c: Likewise.
1208         * amd64-tdep.c: Likewise.
1209         * i386-linux-tdep.c: Likewise.
1210         * i386-tdep.c: Likewise.
1211
1212 2019-07-03  Pedro Alves  <palves@redhat.com>
1213
1214         PR cli/24732
1215         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1216         (pipe_cmd_option_defs): New.
1217         (make_pipe_cmd_options_def_group): New.
1218         (pipe_command): Use gdb::option::process_options.
1219         (pipe_command_completer): New function.
1220         (_initialize_cli_cmds): Install completer for "pipe" command.
1221
1222 2019-07-03  Pedro Alves  <palves@redhat.com>
1223
1224         * cli/cli-option.c (union option_value) <string>: New field.
1225         (struct option_def_and_value): Add ctor, move ctor, dtor and
1226         use DISABLE_COPY_AND_ASSIGN.
1227         (option_def_and_value::clear_value): New.
1228         (parse_option, save_option_value_in_ctx, get_val_type_str)
1229         (add_setshow_cmds_for_options): Handle var_string.
1230         * cli-option.h (union option_def::var_address) <string>: New
1231         field.
1232         (struct string_option_def): New.
1233         * maint-test-options.c (struct test_options_opts): Add default
1234         ctor and use DISABLE_COPY_AND_ASSIGN.
1235         <string_opt>: New field.
1236         (test_options_opts::~test_options_opts): New.
1237         (test_options_opts::dump): Also dump "-string".
1238         (test_options_option_defs): Install "string.
1239
1240 2019-07-03  Pedro Alves  <palves@redhat.com>
1241
1242         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1243         option_value with a null enumeration.
1244         (complete_options): Save the option values in the context.
1245         (save_option_value_in_ctx): New, factored out from ...
1246         (process_options): ... here.
1247         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1248         of the function.
1249         * maint-test-options.c (test_options_opts::dump): New, factored
1250         out from ...
1251         (maintenance_test_options_command_mode): ... here.
1252         (maintenance_test_options_command_completion_result): Delete.
1253         (maintenance_test_options_command_completion_text): Update
1254         comment.
1255         (maintenance_show_test_options_completion_result): Change
1256         prototype.  Just print
1257         maintenance_test_options_command_completion_text.
1258         (save_completion_result): New.
1259         (maintenance_test_options_completer_mode): Pass options context to
1260         complete_options, and then save a dump.
1261         (_initialize_maint_test_options): Use add_cmd to install "maint
1262         show test-options-completion-result".
1263
1264 2019-07-03  Pedro Alves  <palves@redhat.com>
1265
1266         * NEWS (New commands): Mention "with" and "maint with".
1267         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1268         (with_command, with_command_completer): New.
1269         (pipe_command): Adjust to new repeat_previous
1270         interface.
1271         (_initialize_cli_cmds): Install the "with" command and its "w"
1272         alias.
1273         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1274         declarations.
1275         * cli/cli-setshow.c (parse_cli_var_uinteger)
1276         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1277         argument strings for all var_types.
1278         (get_setshow_command_value_string): New, factored out from ...
1279         (do_show_command): ... this.
1280         * cli/cli-setshow.h: Include <string>.
1281         (get_setshow_command_value_string): Declare.
1282         * command.h (repeat_previous): Now returns const char *.  Adjust
1283         comment.
1284         * maint.c: Include "cli/cli-cmds.h".
1285         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1286         (_initialize_maint_cmds): Register the "maintenance with" command.
1287         * top.c (repeat_previous): Move bits from pipe_command here:
1288         Return the saved command line, if any; error out if there's no
1289         command to relaunch.
1290
1291 2019-07-03  Pedro Alves  <palves@redhat.com>
1292
1293         * NEWS (New commands): Mention "maint set/show test-settings"
1294         instead of "maint test-settings".
1295         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1296         (maintenance_test_settings_set_list): Rename to ...
1297         (maintenance_set_test_settings_list): ... this.
1298         (maintenance_test_settings_show_list): Rename to  ...
1299         (maintenance_show_test_settings_list): ... this.
1300         (maintenance_test_settings_cmd): Delete.
1301         (maintenance_test_settings_set_cmd): ...
1302         (maintenance_set_test_settings_cmd): ... this.
1303         (maintenance_test_settings_show_cmd): ...
1304         (maintenance_show_test_settings_cmd): ... this.
1305         (maintenance_test_settings_show_value_cmd):
1306         (maintenance_show_test_settings_value_cmd): ... this.
1307         (_initialize_maint_test_settings): No longer install the "maint
1308         test-settings" prefix command.  Rename "maint test-settings set"
1309         to "maint set test-settings", and "maint test-settings show" to
1310         "maint show test-settings".  Adjust all subcommands.
1311
1312 2019-07-03  Pedro Alves  <palves@redhat.com>
1313
1314         * maint-test-settings.c: Fix file's intro comment.  Replace all
1315         references to "test-options" with references to "test-settings",
1316         in comments.
1317
1318 2019-07-03  Pedro Alves  <palves@redhat.com>
1319
1320         * maint-test-settings.c (maintenance_test_settings_xxx)
1321         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1322         New.
1323         (maintenance_test_settings_enums): Use them.
1324         (maintenance_test_settings_enum): Default to
1325         maintenance_test_settings_xxx.
1326         (_initialize_maint_test_settings): Initialize
1327         MAINTENANCE_TEST_SETTINGS_FILENAME.
1328
1329 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1330
1331         * breakpoint.h (remove_breakpoints_inf): Change return type to
1332         void, move function documentation here.
1333         * breakpoint.c (remove_breakpoints_inf): Change return type to
1334         void, move function documentation to header.
1335
1336 2019-07-02  Pedro Alves  <palves@redhat.com>
1337
1338         * NEWS (Completion improvements): Mention "info threads".
1339         * thread.c (struct info_threads_opts, info_threads_option_defs)
1340         (make_info_threads_options_def_group): New.
1341         (info_threads_command): Use gdb::option::process_options.
1342         (info_threads_command_completer): New.
1343         (_initialize_thread): Use gdb::option::build_help to build the
1344         help text for "info threads".
1345
1346 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1347
1348         * defs.h (generic_load): Move from here...
1349         * symfile.h (generic_load): ... to here.  Rename name parameter
1350         to args.
1351         * symfile.c (generic_load): Add comment.
1352
1353 2019-07-01  Tom Tromey  <tromey@adacore.com>
1354
1355         * dwarf2read.c
1356         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1357         declaration of without_params.  Fix formatting.
1358
1359 2019-07-01  Tom Tromey  <tromey@adacore.com>
1360
1361         * ada-exp.y (find_primitive_type): Update.
1362         * ada-lang.h (ada_lookup_symbol): Update.
1363         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1364         parameter.
1365         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1366
1367 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1368
1369         PR breakpoints/24541
1370         * gdbarch.c: Regenerate.
1371         * gdbarch.h: Regenerate.
1372         * gdbarch.sh: Add 'stap_adjust_register'.
1373         * i386-tdep.c: Include '<unordered_set>'.
1374         (i386_stap_adjust_register): New function.
1375         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1376         * stap-probe.c (stap_parse_register_operand): Call
1377         'gdbarch_stap_adjust_register'.
1378
1379 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1380
1381         PR python/24742
1382         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1383         * python/python.c (do_start_initialization): Use 'xmalloc'
1384         instead of 'PyMem_Malloc'.
1385
1386 2019-06-28  Tom Tromey  <tromey@adacore.com>
1387
1388         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1389         for Ada.
1390
1391 2019-06-27  Tom Tromey  <tromey@adacore.com>
1392
1393         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1394         objfile_key.
1395         (arm_find_mapping_symbol, arm_record_special_symbol)
1396         (_initialize_arm_tdep): Update.
1397         (arm_objfile_data_free): Remove.
1398
1399 2019-06-27  Tom Tromey  <tromey@adacore.com>
1400
1401         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1402         to cp_print_static_field.
1403
1404 2019-06-26  Tom Tromey  <tromey@adacore.com>
1405
1406         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1407         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1408         declare.
1409
1410 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1411
1412         * features/aarch64-core.c (create_feature_aarch64_core):
1413         Regenerate.
1414         * features/aarch64-core.xml: Add cpsr flags.
1415
1416 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1417
1418         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1419         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1420
1421 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1422
1423         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1424         field.
1425         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1426         use.
1427         (arm_record_special_symbol): Don't insert new symbol in sorted
1428         position, push it at the end.
1429
1430 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1431
1432         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1433         (arm_mapping_symbol_s): Remove.
1434         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1435         (arm_mapping_symbol_vec): New typedef.
1436         (struct arm_per_objfile): Add constructor.
1437         <section_maps>: Change type to
1438         std::unique_ptr<arm_mapping_symbol_vec[]>.
1439         (arm_compare_mapping_symbols): Remove.
1440         (arm_find_mapping_symbol): Adjust to section_maps type change.
1441         (arm_objfile_data_free): Call delete on arm_per_objfile.
1442         (arm_record_special_symbol): Adjust to section_maps type change.
1443         Allocate arm_per_objfile with new.
1444
1445 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1446
1447         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1448         with the command prefix.
1449
1450 2019-06-25  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1453         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1454
1455 2019-06-25  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1458         type.
1459         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1460         protected.
1461
1462 2019-06-25  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-winsource.c
1465         (tui_source_window_base::set_is_exec_point_at): Add check against
1466         LOA_ADDRESS.
1467
1468 2019-06-25  Tom Tromey  <tom@tromey.com>
1469
1470         * tui/tui-source.c (tui_set_source_content): Don't check before
1471         xfree.
1472         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1473
1474 2019-06-25  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui-winsource.h (tui_update_source_window_as_is)
1477         (tui_alloc_source_buffer, tui_line_is_displayed)
1478         (tui_addr_is_displayed): Change type of win_info.
1479         * tui/tui-winsource.c (tui_update_source_window_as_is)
1480         (tui_clear_source_content, tui_show_source_line)
1481         (tui_show_source_content, tui_source_window_base::refill)
1482         (tui_source_window_base::set_is_exec_point_at)
1483         (tui_source_window_base::set_is_exec_point_at)
1484         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1485         (tui_alloc_source_buffer, tui_line_is_displayed)
1486         (tui_addr_is_displayed): Change type of win_info.  Update.
1487         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1488         (tui_source_window_base::do_make_visible_with_new_height):
1489         Update.
1490         * tui/tui-source.c (tui_set_source_content)
1491         (tui_set_source_content_nil)
1492         (tui_source_window::do_scroll_vertical): Update.
1493         * tui/tui-layout.c (show_layout): Update.
1494         * tui/tui-disasm.c (tui_set_disassem_content)
1495         (tui_disasm_window::do_scroll_vertical): Update.
1496         * tui/tui-data.h (tui_win_content): Remove.
1497         (struct tui_gen_win_info) <content, content_size>: Remove.
1498         (struct tui_source_element): Add initializers and destructor.
1499         (union tui_which_element, struct tui_win_element): Remove.
1500         (struct tui_source_window_base) <content>: New field.
1501         (struct tui_data_window): Remove destructor.
1502         (tui_alloc_content, tui_free_win_content)
1503         (tui_free_all_source_wins_content): Don't declare.
1504         * tui/tui-data.c (tui_initialize_static_data): Update.
1505         (init_content_element, tui_alloc_content): Remove.
1506         (~tui_gen_win_info): Update.
1507         (~tui_data_window, tui_free_all_source_wins_content)
1508         (tui_free_win_content, free_content, free_content_elements):
1509         Remove.
1510
1511 2019-06-25  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-winsource.h (tui_clear_source_content)
1514         (tui_erase_source_content, tui_show_source_content): Change type
1515         of win_info.
1516         * tui/tui-winsource.c (tui_clear_source_content)
1517         (tui_erase_source_content, tui_show_source_content): Change type
1518         of win_info.
1519         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1520         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1521         win_info.
1522         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1523         win_info.
1524         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1525
1526 2019-06-25  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-winsource.c (tui_clear_source_content)
1529         (tui_source_window_base::set_is_exec_point_at): Update.
1530         * tui/tui-source.c (tui_set_source_content_nil): Update.
1531         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1532         a bool.
1533         * tui/tui-data.c (init_content_element): Update.
1534
1535 2019-06-25  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1538         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1539         * tui/tui-layout.c (init_and_make_win): Update.
1540         * tui/tui.h (enum tui_win_type): Update.
1541         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1542         tui_win_is_auxillary.
1543         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1544         tui_win_is_auxillary.
1545
1546 2019-06-25  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1549         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1550         (tui_delete_data_content_windows, tui_display_all_data)
1551         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1552         Update.
1553         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1554         * tui/tui-regs.c (tui_last_regs_line_no)
1555         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1556         (tui_show_registers): Update.
1557         (tui_show_register_group): Return void.  Update.
1558         (tui_display_registers_from, tui_display_reg_element_at_line)
1559         (tui_display_registers_from_line, tui_check_register_values):
1560         Update.
1561         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1562         member.
1563         (struct tui_data_window) <regs_content>: Now a std::vector.
1564         <regs_content_count>: Remove.
1565         (tui_add_content_elements, tui_free_data_content): Don't declare.
1566         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1567         (init_content_element): Remove DATA_WIN case.  Add assert.
1568         (tui_add_content_elements): Remove.
1569         (tui_data_window): Update.
1570         (tui_free_data_content): Remove.
1571         (free_content_elements): Remove DATA_WIN case.
1572
1573 2019-06-25  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-data.c (tui_data_item_window): Update.
1576         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1577         * tui/tui-windata.c (tui_display_all_data)
1578         (tui_display_data_from_line): Update.
1579         (tui_check_data_values): Remove.
1580         * tui/tui-regs.c (tui_show_register_group)
1581         (tui_display_reg_element_at_line): Update.
1582         * tui/tui-hooks.c (tui_register_changed)
1583         (tui_refresh_frame_and_register_information): Call
1584         tui_check_register_values.
1585         * tui/tui-data.h (struct tui_data_window) <data_content,
1586         data_content_count, data_type>: Remove.
1587         (enum tui_data_type): Remove.
1588
1589         * tui/tui-data.c (tui_data_window::clear_detail)
1590         (~tui_data_window): Update.
1591
1592 2019-06-25  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1595         declare.
1596         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1597         Rename from tui_first_data_item_displayed.  Update.
1598         (tui_data_window::refresh_all)
1599         (tui_data_window::do_scroll_vertical): Update.
1600         * tui/tui-data.h (struct tui_data_window)
1601         <first_data_item_displayed>: Declare new method.
1602
1603 2019-06-25  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1606         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1607         contents...
1608         (tui_initialize_static_data): ...here.
1609
1610 2019-06-25  Tom Tromey  <tom@tromey.com>
1611
1612         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1613         (tui_display_registers_from, tui_check_register_values): Update.
1614         (tui_display_register): Remove win_info parameter; update.
1615         (tui_get_register): Change type of parameters.
1616         * tui/tui-data.h (struct tui_data_element): Remove.
1617         (union tui_which_element) <data>: Remove.
1618         <data_window>: Change type.
1619         (struct tui_data_item_window): New.
1620         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1621         case.  Add assert.
1622         (~tui_data_item_window): New destructor.
1623         (free_content_elements): Remove DATA_ITEM_WIN case.
1624
1625 2019-06-25  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1628         Remove.
1629
1630 2019-06-25  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-data.h (struct tui_command_element): Remove.
1633         (union tui_which_element) <command>: Remove.
1634         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1635         assert.
1636         (free_content_elements): Remove CMD_WIN case.
1637
1638 2019-06-25  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-layout.c (tui_set_layout): Update.
1641         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1642         * tui/tui-data.c (layout_def): Update.
1643
1644 2019-06-25  Tom Tromey  <tom@tromey.com>
1645
1646         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1647         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1648         (tui_source_window_base::set_new_height): Update.
1649         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1650         Update.
1651         (tui_set_locator_fullname, tui_set_locator_info)
1652         (tui_show_frame_info): Update.
1653         * tui/tui-source.c (tui_set_source_content)
1654         (tui_source_is_displayed): Update.
1655         * tui/tui-layout.c (show_source_disasm_command, show_data)
1656         (show_source_or_disasm_and_command): Update.
1657         * tui/tui-disasm.c (tui_set_disassem_content)
1658         (tui_get_begin_asm_address): Update.
1659         * tui/tui-data.h (struct tui_locator_element): Remove.
1660         (union tui_which_element) <locator>: Remove.
1661         (struct tui_locator_window): New.
1662         (tui_locator_win_info_ptr): Change return type.
1663         * tui/tui-data.c (_locator): Change type.
1664         (tui_locator_win_info_ptr): Change return type.
1665         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1666         (tui_alloc_content): Add assert.
1667
1668 2019-06-25  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-winsource.c
1671         (tui_exec_info_window::maybe_allocate_content): New method.
1672         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1673         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1674         (make_source_or_disasm_window): Add cast.
1675         * tui/tui-data.h (union tui_which_element) <simple_string>:
1676         Remove.
1677         (struct tui_source_info): New.
1678         (struct tui_source_window_base) <execution_info>: Change type.
1679         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1680         case, and add assert.
1681         (tui_alloc_content): Add assert.
1682
1683 2019-06-25  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1686         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1687         * tui/tui-data.c (tui_alloc_win_info): Remove.
1688
1689 2019-06-25  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1692         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1693         can_highlight.
1694
1695 2019-06-25  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1698         make_visible_with_new_height method.
1699         (tui_win_info::make_visible_with_new_height): New method.
1700         (tui_source_window_base::do_make_visible_with_new_height)
1701         (tui_data_window::do_make_visible_with_new_height)
1702         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1703         (make_visible_with_new_height): Remove.
1704         (tui_resize_all, tui_adjust_win_heights): Use
1705         make_visible_with_new_height method.
1706         * tui/tui-data.h (struct tui_win_info)
1707         <do_make_visible_with_new_height, make_visible_with_new_height>:
1708         New methods.
1709         (struct tui_source_window_base, struct tui_data_window)
1710         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1711         methods.
1712
1713 2019-06-25  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1716         method.
1717         (update_tab_width): Call update_tab_width method.
1718         * tui/tui-data.h (struct tui_win_info)
1719         (struct tui_source_window_base) <update_tab_width>: New methods.
1720
1721 2019-06-25  Tom Tromey  <tom@tromey.com>
1722
1723         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1724         parameter.
1725         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1726         parameter.
1727         (tui_gen_win_info::make_visible): Update.
1728         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1729         parameter.
1730         * tui/tui-data.h (enum tui_box): New enum.
1731         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1732
1733 2019-06-25  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1736         init_and_make_win for EXEC_INFO_WIN.
1737         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1738         longer inline.
1739         (struct tui_win_info) <~tui_win_info>: Inline.
1740         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1741         Don't declare.
1742         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1743         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1744         Remove.
1745         (tui_initialize_static_data): Update.
1746         (~tui_gen_win_info): Handle more cleanup here.
1747         (~tui_source_window_base): Delete "execution_info".
1748         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1749
1750 2019-06-25  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-layout.c (make_command_window): Don't set
1753         can_highlight.
1754         (show_source_disasm_command): Call the reset method.
1755         (show_data): Don't set can_highlight.  Call the reset method.
1756         (tui_gen_win_info::reset): Rename from init_gen_win_info
1757         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1758         (show_source_or_disasm_and_command): Call the reset method.
1759         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1760         (struct tui_cmd_window): Set can_highlight.
1761
1762 2019-06-25  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1765         from make_visible.
1766         (tui_make_visible, tui_make_invisible): Rewrite.
1767         (tui_win_info::make_visible): Remove.
1768         (tui_source_window_base::make_visible): Update.
1769         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1770         method.  Moved from...
1771         (struct tui_win_info) <make_visible>: ...here.
1772
1773 2019-06-25  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui-winsource.c
1776         (tui_source_window_base::do_scroll_horizontal): Remove direction
1777         parameter.
1778         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1779         direction parameter.
1780         * tui/tui-win.c (tui_win_info::forward_scroll)
1781         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1782         (tui_win_info::right_scroll): Update.
1783         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1784         direction parameter.
1785         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1786         direction parameter.
1787         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1788         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1789         Remove direction parameter.
1790         (struct tui_source_window_base, struct tui_source_window)
1791         (struct tui_disasm_window, struct tui_data_window)
1792         (struct tui_cmd_window): Update.
1793
1794 2019-06-25  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-winsource.h (tui_set_exec_info_content)
1797         (tui_show_exec_info_content, tui_erase_exec_info_content)
1798         (tui_clear_exec_info_content, tui_update_exec_info): Change
1799         argument to tui_source_window_base.
1800         * tui/tui-winsource.c (tui_set_exec_info_content)
1801         (tui_show_exec_info_content, tui_erase_exec_info_content)
1802         (tui_clear_exec_info_content, tui_update_exec_info): Change
1803         argument to tui_source_window_base.
1804
1805 2019-06-25  Tom Tromey  <tom@tromey.com>
1806
1807         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1808         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1809
1810 2019-06-25  Tom Tromey  <tom@tromey.com>
1811
1812         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1813         check.
1814
1815 2019-06-25  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1818         type to void.
1819         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1820         type to void.
1821         * tui/tui-source.c (tui_set_source_content): Update.
1822         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1823
1824 2019-06-25  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-win.c (window_name_completer, tui_set_focus)
1827         (tui_all_windows_info): Use name method.
1828         * tui/tui-data.h (struct tui_gen_win_info)
1829         (struct tui_source_window, struct tui_disasm_window)
1830         (struct tui_data_window, struct tui_cmd_window) <name>: New
1831         method.
1832         (tui_win_name): Don't declare.
1833         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1834         (tui_win_name): Remove.
1835
1836 2019-06-25  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-winsource.h (tui_update_source_window)
1839         (tui_update_source_window_as_is): Change parameter type.
1840         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1841         to be a tui_source_window_base.
1842         (tui_update_source_window_as_is): Likewise.
1843         * tui/tui-win.c (make_visible_with_new_height): Update.
1844
1845 2019-06-25  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-winsource.c (tui_erase_source_content)
1848         (tui_show_source_content, tui_show_exec_info_content)
1849         (tui_erase_exec_info_content): Use refresh_window method.
1850         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1851         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1852         from tui_refresh_win.
1853         (tui_data_window::refresh_window): New method.
1854         (tui_win_info::refresh, tui_source_window_base::refresh)
1855         (tui_refresh_all): Use refresh_window method.
1856         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1857         method.
1858         * tui/tui-regs.c (tui_display_register): Call refresh_window
1859         method.
1860         * tui/tui-layout.c (show_source_disasm_command)
1861         (show_source_or_disasm_and_command): Call refresh_window method.
1862         * tui/tui-data.h (struct tui_gen_win_info)
1863         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1864         New method.
1865
1866 2019-06-25  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui.c (tui_rl_other_window, tui_enable)
1869         (tui_is_window_visible, tui_get_command_dimension): Update.
1870         * tui/tui-winsource.c (tui_update_source_window_as_is)
1871         (tui_clear_source_content, tui_erase_source_content)
1872         (tui_show_source_line, tui_source_window_base::refill)
1873         (tui_source_window_base::do_scroll_horizontal)
1874         (tui_source_window_base::set_is_exec_point_at)
1875         (tui_update_breakpoint_info, tui_set_exec_info_content)
1876         (tui_alloc_source_buffer, tui_line_is_displayed)
1877         (tui_addr_is_displayed): Update.
1878         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1879         (tui_check_and_display_highlight_if_needed)
1880         (tui_win_info::make_visible, tui_win_info::refresh)
1881         (tui_refresh_all): Update.
1882         * tui/tui-windata.c (tui_first_data_item_displayed)
1883         (tui_delete_data_content_windows, tui_erase_data_content)
1884         (tui_display_all_data, tui_data_window::refresh_all)
1885         (tui_check_data_values): Update.
1886         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1887         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1888         (tui_win_info::backward_scroll, tui_refresh_all_win)
1889         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1890         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1891         (tui_source_window_base::set_new_height)
1892         (tui_data_window::set_new_height)
1893         (make_invisible_and_set_new_height)
1894         (make_visible_with_new_height, new_height_ok)
1895         (parse_scrolling_args): Update.
1896         * tui/tui-stack.c (tui_show_frame_info): Update.
1897         * tui/tui-source.c (tui_set_source_content)
1898         (tui_set_source_content_nil, tui_source_is_displayed)
1899         (tui_source_window::do_scroll_vertical): Update.
1900         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1901         (tui_display_registers_from, tui_display_reg_element_at_line)
1902         (tui_check_register_values, tui_reg_command): Update.
1903         * tui/tui-layout.c (tui_default_win_height)
1904         (show_source_disasm_command, show_data, init_and_make_win)
1905         (show_source_or_disasm_and_command): Update.
1906         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1907         (tui_redisplay_readline, tui_mld_flush)
1908         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1909         (tui_getc): Update.
1910         * tui/tui-disasm.c (tui_set_disassem_content)
1911         (tui_disasm_window::do_scroll_vertical): Update.
1912         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1913         Now virtual.
1914         (struct tui_win_info): Derive from tui_gen_win_info.
1915         <~tui_win_info>: Mark as override.
1916         <generic>: Remove member.
1917         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1918         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1919         (~tui_data_window, ~tui_win_info)
1920         (tui_free_all_source_wins_content): Update.
1921         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1922
1923 2019-06-25  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-layout.c (init_and_make_win): Use new.
1926         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1927         destructor, initializers.
1928         (tui_alloc_generic_win_info): Don't declare.
1929         * tui/tui-data.c (_locator): Add argument to constructor.
1930         (source_win, disasm_win): New globals.
1931         (exec_info): Remove.
1932         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1933         Update.
1934         (tui_alloc_generic_win_info): Remove.
1935         (init_content_element): Use new.
1936         (tui_win_info::tui_win_info): Update.
1937         (free_content_elements) <case DATA_WIN>: Use delete.
1938
1939 2019-06-25  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1942         * tui/tui-windata.c (tui_first_data_item_displayed)
1943         (tui_delete_data_content_windows): Update.
1944         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1945         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1946         (tui_display_registers_from, tui_check_register_values): Update.
1947         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1948         pointer.
1949         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1950         window.
1951         (tui_free_data_content): Update.
1952         (free_content_elements) <case DATA_WIN>: Free the window.
1953
1954 2019-06-25  Tom Tromey  <tom@tromey.com>
1955
1956         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1957         Update.
1958         * tui/tui-layout.c (make_command_window)
1959         (show_source_disasm_command, show_data, init_and_make_win)
1960         (show_source_or_disasm_and_command): Update.
1961         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1962         method.
1963         <can_highight, is_highlighted>: Now bool.
1964         (tui_set_win_highlight): Don't declare.
1965         * tui/tui-data.c (tui_set_win_highlight): Remove.
1966
1967 2019-06-25  Tom Tromey  <tom@tromey.com>
1968
1969         * tui/tui-wingeneral.c (make_visible): Remove check of window
1970         type.
1971
1972 2019-06-25  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-win.c (tui_win_info::max_height)
1975         (tui_cmd_window::max_height): New methods.
1976         (new_height_ok): Call max_height.
1977         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1978         <max_height>: New method.
1979
1980 2019-06-25  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui-win.c (tui_source_window_base::set_new_height)
1983         (tui_data_window::set_new_height): New methods.
1984         (make_invisible_and_set_new_height): Call set_new_height method.
1985         * tui/tui-data.h (struct tui_win_info)
1986         (struct tui_source_window_base, struct tui_data_window)
1987         <set_new_height>: New method.
1988
1989 2019-06-25  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1992         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1993         tui_refresh_data_win.
1994         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1995         method.
1996         (tui_refresh_all_win): Call the refresh_all method.
1997         (tui_set_focus): Likewise.
1998         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1999         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2000         Likewise.
2001
2002 2019-06-25  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-winsource.h (tui_refill_source_window)
2005         (tui_set_is_exec_point_at): Don't declare.
2006         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2007         (tui_source_window_base::refill): Rename from
2008         tui_refill_source_window.
2009         (tui_source_window_base::do_scroll_horizontal): Update.
2010         (tui_source_window_base::set_is_exec_point_at): Rename from
2011         tui_set_is_exec_point_at.
2012         (tui_update_all_breakpoint_info): Update.
2013         * tui/tui-stack.c (tui_show_frame_info): Update.
2014         * tui/tui-layout.c (show_data): Add cast.
2015         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2016         * tui/tui-data.h (struct tui_source_window_base) <refill,
2017         set_is_exec_point_at>: New methods.
2018         (tui_source_windows, tui_add_to_source_windows): Update types.
2019         (tui_add_to_source_windows): Remove redundant declaration.
2020         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2021         (tui_source_windows): Change return type.
2022         (tui_clear_source_windows_detail): Update.
2023         (tui_add_to_source_windows): Change type of parameter.
2024         (tui_free_all_source_wins_content): Update.
2025
2026 2019-06-25  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-wingeneral.c (tui_win_info::refresh)
2029         (tui_source_window_base::refresh): New methods.
2030         (tui_refresh_all): Call the refresh method.
2031         * tui/tui-data.h (struct tui_win_info)
2032         (struct tui_source_window_base) <refresh>: New method.
2033
2034 2019-06-25  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui.h (tui_is_window_visible): Return bool.
2037         * tui/tui.c (tui_is_window_visible): Return bool.
2038         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2039         (tui_make_visible, tui_make_invisible)
2040         (tui_win_info::make_visible)
2041         (tui_source_window_base::make_visible, make_all_visible)
2042         (tui_make_all_visible, tui_make_all_invisible): Update.
2043         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2044         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2045         bool.
2046         (struct tui_win_info, struct tui_source_window_base)
2047         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2048         * tui/tui-data.c (tui_init_generic_part): Update.
2049
2050 2019-06-25  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2053         (tui_source_window_base::make_visible): New methods.
2054         (make_all_visible): Make method call.
2055         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2056         (struct tui_source_window_base, struct tui_cmd_window): Override
2057         make_visible.
2058         (tui_win_is_source_type): Don't declare.
2059         * tui/tui-data.c (tui_win_is_source_type): Remove.
2060
2061 2019-06-25  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2064         NULL check.
2065
2066 2019-06-25  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2069         Inline constructor.  Add initializers for members.
2070         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2071         constructors; now inline in class.
2072
2073 2019-06-25  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-regs.c (tui_show_registers): Update.
2076         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2077         bool.
2078         * tui/tui-data.c (tui_data_window::clear_detail)
2079         (tui_data_window): Update.
2080
2081 2019-06-25  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-windata.c (tui_display_all_data)
2084         (tui_display_data_from_line, tui_display_data_from)
2085         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2086         Update.
2087         * tui/tui-regs.c (tui_last_regs_line_no)
2088         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2089         (tui_show_registers, tui_show_register_group)
2090         (tui_display_registers_from, tui_display_reg_element_at_line)
2091         (tui_display_registers_from_line, tui_check_register_values)
2092         (tui_reg_next, tui_reg_prev): Update.
2093         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2094         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2095         tui_data_window.
2096         (struct tui_win_info) <detail>: Remove.  Add new fields from
2097         tui_data_info.
2098         (TUI_DATA_WIN): Add cast.
2099         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2100         (~tui_data_window): Simplify.
2101
2102 2019-06-25  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-layout.c (show_source_disasm_command)
2105         (show_source_or_disasm_and_command): Update.
2106         * tui/tui-io.c (update_cmdwin_start_line)
2107         (tui_redisplay_readline): Update.
2108         * tui/tui-data.h (struct tui_command_info): Remove.
2109         (struct tui_win_info) <detail>: Remove command_info member.
2110         (struct tui_data_window) <start_line>: New member, from
2111         tui_command_info.
2112         (TUI_CMD_WIN): Add casts.
2113
2114 2019-06-25  Tom Tromey  <tom@tromey.com>
2115
2116         * tui/tui-winsource.c (tui_update_source_window)
2117         (tui_refill_source_window)
2118         (tui_source_window_base::do_scroll_horizontal)
2119         (tui_update_breakpoint_info, tui_set_exec_info_content)
2120         (tui_show_exec_info_content, tui_erase_exec_info_content)
2121         (tui_clear_exec_info_content): Update.
2122         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2123         Update.
2124         * tui/tui-win.c (make_invisible_and_set_new_height)
2125         (make_visible_with_new_height): Update.
2126         * tui/tui-source.c (tui_set_source_content)
2127         (tui_show_symtab_source): Update.
2128         * tui/tui-layout.c (extract_display_start_addr)
2129         (show_source_disasm_command, show_data)
2130         (make_source_or_disasm_window)
2131         (show_source_or_disasm_and_command): Update.
2132         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2133         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2134         "gdbarch".
2135         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2136         to tui_source_window_base.
2137         (struct tui_win_info) <detail>: Remove source_info member.
2138         (struct tui_source_window_base) <has_locator>: Inline.
2139         Move contents from tui_source_info; rename has_locator member to
2140         m_has_locator.
2141         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2142         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2143         header file.
2144         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2145         Simplify.
2146         (tui_free_all_source_wins_content): Cast to
2147         tui_source_window_base.
2148
2149 2019-06-25  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-win.c (make_invisible_and_set_new_height)
2152         (make_visible_with_new_height): Call has_locator method.
2153         * tui/tui-layout.c (show_source_disasm_command, show_data)
2154         (show_source_or_disasm_and_command): Update for bool change.
2155         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2156         (tui_win_info) <has_locator>: New method.
2157         (struct tui_source_window_base) <has_locator>: New method.
2158         (tui_win_has_locator): Don't declare.
2159         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2160         from tui_win_has_locator.
2161         (tui_source_window_base): Use false, not FALSE.
2162
2163 2019-06-25  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2166         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2167         clear_detail method directly.
2168         (tui_clear_win_detail): Remove.
2169
2170 2019-06-25  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2173         "this", not TUI_DISASM_WIN.
2174
2175 2019-06-25  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2178         declare.
2179         * tui/tui-winsource.c
2180         (tui_source_window_base::do_scroll_horizontal): Rename from
2181         tui_horizontal_source_scroll.
2182         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2183         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2184         from tui_vertical_data_scroll.
2185         * tui/tui-win.h (tui_scroll): Don't declare.
2186         * tui/tui-win.c (tui_win_info::forward_scroll)
2187         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2188         (tui_win_info::right_scroll): Rename and update.
2189         (tui_scroll_forward_command, tui_scroll_backward_command)
2190         (tui_scroll_left_command, tui_scroll_right_command): Update.
2191         (tui_scroll): Remove.
2192         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2193         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2194         from tui_vertical_source_scroll.
2195         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2196         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2197         from tui_vertical_disassem_scroll.
2198         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2199         do_scroll_horizontal>: New methods.
2200         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2201         Likewise.
2202         (struct tui_source_window_base): Add do_scroll_horizontal.
2203         (struct tui_source_window, struct tui_disasm_window): Add
2204         do_scroll_vertical.
2205         (struct tui_data_window, struct tui_cmd_window): Add
2206         do_scroll_horizontal and do_scroll_vertical.
2207         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2208
2209 2019-06-25  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-data.h (struct tui_source_window_base): New struct.
2212         (struct tui_source_window): Derive from tui_source_window_base.
2213         (struct tui_disasm_window): New struct.
2214         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2215         from tui_source_window::clear_detail.
2216         (tui_source_window_base): Rename from tui_source_window.
2217         (~tui_source_window_base): Rename from ~tui_source_window.
2218         (tui_alloc_win_info): Create a tui_disasm_window.
2219
2220 2019-06-25  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-data.h (struct tui_source_window)
2223         (struct tui_data_window): Declare destructors.
2224         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2225         destructors.
2226         (tui_win_info): Simplify.
2227
2228 2019-06-25  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-winsource.c (tui_display_main)
2231         (tui_update_source_windows_with_addr)
2232         (tui_update_all_breakpoint_info): Update.
2233         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2234         (new_height_ok, parse_scrolling_args): Update.
2235         * tui/tui-stack.c (tui_show_frame_info): Update.
2236         * tui/tui-data.h (struct tui_list): Remove.
2237         (tui_source_windows): Return a reference to a std::vector.
2238         * tui/tui-data.c (source_windows): Now a std::vector.
2239         (tui_source_windows): Change return type.
2240         (tui_clear_source_windows): Rewrite.
2241         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2242         (tui_free_all_source_wins_content): Rewrite.
2243
2244 2019-06-25  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2247         (struct tui_data_window, struct tui_cmd_window): Declare
2248         clear_detail method.
2249         * tui/tui-data.c (tui_source_window::clear_detail)
2250         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2251         methods.
2252         (tui_clear_win_detail): Simplify.
2253
2254 2019-06-25  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-layout.c (make_source_window, make_disasm_window)
2257         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2258         Return the new window.
2259         (show_source_disasm_command, show_data)
2260         (show_source_or_disasm_and_command): Update.
2261
2262 2019-06-25  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2265         parameter.  Return the new window.
2266         (show_source_disasm_command): Update and remove NULL check.
2267         (show_source_or_disasm_and_command): Update.
2268
2269 2019-06-25  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2272
2273 2019-06-25  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-data.h (struct tui_win_info): Make constructor
2276         protected.  Make destructor virtual.  Add initializers.
2277         (tui_source_window, tui_data_window, tui_cmd_window): New
2278         classes.
2279         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2280         constructor.  Add "type" parameter.
2281         (tui_source_window, tui_data_window, tui_cmd_window): New
2282         constructors.
2283         (tui_alloc_win_info): Instantiate the appropriate subclass.
2284
2285 2019-06-25  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-win.c (tui_resize_all): Use delete.
2288         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2289         destructor.
2290         (tui_free_window): Don't declare.
2291         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2292         Update.
2293
2294 2019-06-25  Tom Tromey  <tom@tromey.com>
2295
2296         * tui/tui-data.h (struct tui_win_info): Add constructor.
2297         * tui/tui-data.c (tui_alloc_win_info): Use new.
2298         (tui_free_window): Use delete.
2299
2300 2019-06-22  Tom Tromey  <tom@tromey.com>
2301
2302         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2303         declare.
2304         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2305
2306 2019-06-22  Tom Tromey  <tom@tromey.com>
2307
2308         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2309         declare.
2310         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2311
2312 2019-06-22  Tom de Vries  <tdevries@suse.de>
2313
2314         * dwarf2read.c (create_addrmap_from_aranges)
2315         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2316         instead of '%zu'.
2317
2318 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2319
2320         * dwarf2read.h (dwarf2_section_info_def): Remove.
2321         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2322         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2323         std::vector<dwarf2_section_info>.
2324         (struct dwo_file) <~dwo_file>: Remove.
2325         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2326         types field.
2327         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2328         (dwarf2_read_debug_names): Likewise.
2329         (create_debug_types_hash_table): Change parameter type to
2330         array_view, adjust code accordingly.
2331         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2332         (partial_die_info::fixup): Likewise.
2333         (determine_prefix): Likewise.
2334         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2335
2336 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2337
2338         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2339         gdb_bfd_ref_ptr.
2340         <~dwo_file>: Remove call to gdb_bfd_unref.
2341         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2342         gdb_bfd_ref_ptr::get.
2343
2344 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2345
2346         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2347         type to htab_up.
2348         * dwarf2read.c (struct dwo_file): Initialize fields.
2349         <~dwo_file>: New.
2350         (free_dwo_file): Remove, move content to ~dwo_file.
2351         (struct dwo_file_deleter): Remove.
2352         (dwo_file_up>: Remove custom deleter.
2353         (free_dwo_files): Remove.
2354         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2355         dwo_files.
2356         (process_skeletonless_type_units): Call unique_ptr::get.
2357         (allocate_dwo_file_hash_table): Add deleter to created hash
2358         table.  Change return type to htab_up.
2359         (lookup_dwo_file_slot): Don't memset dwo_file, call
2360         unique_ptr::get.
2361         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2362         (create_dwo_unit_in_dwp_v2): Likewise.
2363         (open_and_init_dwo_file): Likewise.
2364         (free_dwo_file_from_slot): Remove.
2365
2366 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2367
2368         * dwarf2read.h (struct dwarf2_section_info) <readin,
2369         is_virtual>: Change type to bool.
2370         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2371         true instead of 1.
2372
2373 2019-06-19  Tom Tromey  <tom@tromey.com>
2374
2375         * tui/tui-data.h (tui_init_content_element): Don't declare.
2376
2377 2019-06-19  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-data.h (tui_init_win_info): Don't declare.
2380
2381 2019-06-19  Tom de Vries  <tdevries@suse.de>
2382
2383         * dwarf2read.h (abstract_to_concrete): Change type to
2384         std::unordered_map<sect_offset, std::vector<sect_offset>,
2385         gdb::hash_enum<sect_offset>>.
2386
2387 2019-06-19  Tom Tromey  <tromey@adacore.com>
2388
2389         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2390         EVAL_AVOID_SIDE_EFFECTS specially.
2391
2392 2019-06-19  Tom Tromey  <tromey@adacore.com>
2393
2394         * source-cache.c (highlighter): New global.
2395         (source_cache::get_source_lines): Create a highlighter on demand.
2396
2397 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2398
2399         * defs.h (deprecated_interactive_hook): Delete declaration.
2400         * interps.c (clear_interpreter_hooks): Remove use of
2401         deprecated_interactive_hook.
2402         * top.c (deprecated_interactive_hook): Delete definition.
2403         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2404
2405 2019-06-18  Tom de Vries  <tdevries@suse.de>
2406
2407         PR gdb/24515
2408         * dwarf2read.h (abstract_to_concrete): Change type from
2409         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2410         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2411         * dwarf2read.c (read_variable): Update.
2412         (dwarf2_fetch_die_loc_sect_off): Update.
2413
2414 2019-06-17  Tom de Vries  <tdevries@suse.de>
2415
2416         PR gdb/24617
2417         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2418         accessing parent[parent_len - 1].
2419
2420 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2421
2422         PR gdb/24364
2423         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2424         call dtrace_process_dof with NULL dof.
2425
2426 2019-06-16  Tom de Vries  <tdevries@suse.de>
2427
2428         PR gdb/24445
2429         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2430
2431 2019-06-16  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2434         (make_all_visible): Use address of member.
2435
2436 2019-06-16  Tom Tromey  <tom@tromey.com>
2437
2438         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2439         (tui_free_window, free_content, free_content_elements): Remove
2440         unnecessary cast.
2441         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2442         cast.
2443         * tui/tui-regs.c (tui_show_register_group)
2444         (tui_display_registers_from, tui_display_reg_element_at_line):
2445         Remove unnecessary cast.
2446
2447 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2448
2449         * linux-nat.c (normal_mask): Delete.
2450         (_initialize_linux_nat): Don't initialise normal_mask.
2451
2452 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2453
2454         PR gdb/24445
2455         * dwarf-index-write.h (write_psymtabs_to_index): Add
2456         dwz_basename parameter.
2457         * dwarf-index-write.c (write_gdbindex): Move file writing to
2458         write_gdbindex_1.  Change return type void.
2459         (assert_file_size): Move up, remove filename parameter.
2460         (write_gdbindex_1): New function.
2461         (write_debug_names): Change return type to void, call
2462         assert_file_size.
2463         (struct index_wip_file): New struct.
2464         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2465         file logic to index_wip_file.  Write index for dwz file if
2466         needed.
2467         (save_gdb_index_command): Pass basename of dwz file, if present.
2468         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2469         build-id of dwz file, if present.
2470         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2471         (dwarf2_get_dwz_file): Likewise.
2472         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2473         (dwarf2_get_dwz_file): Likewise.
2474
2475 2019-06-16  Tom Tromey  <tom@tromey.com>
2476
2477         * coffread.c (process_coff_symbol): Use xstrdup.
2478         * value.c (create_internalvar): Use xstrdup.
2479
2480 2019-06-16  Tom Tromey  <tom@tromey.com>
2481
2482         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2483         * breakpoint.c (stopin_command, stopat_command)
2484         (until_break_command, decode_location_default): Remove unnecessary
2485         cast.
2486         * utils.c (subset_compare): Remove unnecessary cast.
2487         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2488         cast.
2489         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2490         cast.
2491         * infcmd.c (path_command): Remove unnecessary cast.
2492         * coffread.c (decode_type): Remove unnecessary cast.
2493         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2494         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2495         * tui/tui-stack.c (tui_show_locator_content)
2496         (tui_show_frame_info): Remove unnecessary cast.
2497         * tui/tui-win.c (tui_scroll_forward_command)
2498         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2499         (parse_scrolling_args): Remove unnecessary cast.
2500         * tui/tui-data.c (init_win_info, tui_del_window)
2501         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2502         (free_content_elements): Remove unnecessary cast.
2503         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2504         unnecessary cast.
2505         * tui/tui-source.c (tui_set_source_content)
2506         (tui_vertical_source_scroll): Remove unnecessary cast.
2507         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2508         cast.
2509         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2510         * tui/tui-regs.c (tui_display_registers_from)
2511         (tui_display_register): Remove unnecessary cast.
2512         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2513         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2514         (make_visible): Remove unnecessary cast.
2515         * tui/tui-winsource.c (tui_erase_source_content)
2516         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2517         unnecessary cast.
2518         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2519         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2520         * stabsread.c (read_type, read_array_type, read_range_type):
2521         Remove unnecessary cast.
2522         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2523         (parse_symbol, parse_type, upgrade_type, parse_external)
2524         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2525         unnecessary cast.
2526         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2527
2528 2019-06-16  Tom Tromey  <tom@tromey.com>
2529
2530         * tui/tui-data.c (tui_alloc_generic_win_info)
2531         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2532         checks.
2533
2534 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2535             Andrew Burgess  <andrew.burgess@embecosm.com>
2536
2537         * f-typeprint.c (f_print_type): Don't return early for not
2538         associated or not allocated types.
2539         (f_type_print_varspec_suffix): Add print_rank parameter and print
2540         ranks of array types in case they dangling.
2541         (f_type_print_base): Add print_rank parameter.
2542
2543 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2544
2545         * NEWS: Mention new MI commands.
2546         * break-catch-throw.c (enum exception_event_kind): Move to
2547         breakpoint.h.
2548         (print_mention_exception_catchpoint): Output text as a single
2549         message.
2550         (catch_exception_command_1): Rename to...
2551         (catch_exception_event): ...this, make non-static, update header
2552         command, and change some parameter types.
2553         (catch_catch_command): Update for changes to
2554         catch_exception_command_1.
2555         (catch_throw_command): Likewise.
2556         (catch_rethrow_command): Likewise.
2557         * breakpoint.c (enum exception_event_kind): Delete.
2558         * breakpoint.h (enum exception_event_kind): Moved here from
2559         break-catch-throw.c.
2560         (catch_exception_event): Declare.
2561         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2562         (mi_cmd_catch_throw): New function.
2563         (mi_cmd_catch_rethrow): New function.
2564         (mi_cmd_catch_catch): New function.
2565         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2566         'catch-catch' entries.
2567         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2568         (mi_cmd_catch_rethrow): Declare.
2569         (mi_cmd_catch_catch): Declare.
2570
2571 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2572
2573         * annotate.c (annotate_source_line): Change return type to void,
2574         update implementation to match.
2575         * annotate.h (annotate_source_line): Change return type to void,
2576         update header comment.
2577         * stack.c (print_frame_info): Don't change what frame information
2578         is printed based on whether annotations are on or not.
2579
2580 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2581
2582         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2583         (annotate_source): Make static.
2584         (annotate_source_line): Moved from source.c and renamed from
2585         identify_source_line.  Update the return type.
2586         * annotate.h (annotate_source): Delete declaration.
2587         (annotate_source_line): Declaration moved from source.h, and
2588         renamed from identify_source_line.  Return type updated.
2589         * source.c (identify_source_line): Moved to annotate.c and renamed
2590         to annotate_source_line.
2591         (info_line_command): Remove check of annotation_level.
2592         * source.h (identify_source_line): Move declaration to annotate.h
2593         and rename to annotate_source_line.
2594         * stack.c: Add 'annotate.h' include.
2595         (print_frame_info): Remove check of annotation_level before
2596         calling annotate_source_line.
2597
2598 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2599
2600         * source-cache.c (source_cache::get_plain_source_lines): Use
2601         open_source_file_with_line_charpos instead of just
2602         open_source_file, remove call to find_source_lines.
2603         (source_cache::get_source_lines): Likewise.
2604         * source.c (find_source_lines): Make static.
2605         (get_filename_and_charpos): Renamed into...
2606         (open_source_file_with_line_charpos): ..this along with changes to
2607         return a scoped_fd, and some other minor clean ups.
2608         (identify_source_line): Use open_source_file_with_line_charpos.
2609         (search_command_helper): Use open_source_file_with_line_charpos
2610         instead of just open_source_file, remove call to
2611         find_source_lines.
2612         * source.h (open_source_file_with_line_charpos): Declare new
2613         function.
2614         (find_source_lines): Delete declaration.
2615
2616 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2617
2618         * source.c (get_filename_and_charpos): Remove fullname
2619         parameter.
2620         (identify_source_line): Update call to get_filename_and_charpos.
2621
2622 2019-06-14  Tom Tromey  <tromey@adacore.com>
2623
2624         PR gdb/24502:
2625         * ui-style.h (skip_ansi_escape): Update comment.
2626         * ui-file.h (class no_terminal_escape_file): New class.
2627         * ui-file.c (no_terminal_escape_file::write)
2628         (no_terminal_escape_file::puts): New methods.
2629         * cli/cli-logging.c (handle_redirections): Use
2630         no_terminal_escape_file.
2631
2632 2019-06-14  Tom Tromey  <tromey@adacore.com>
2633
2634         * NEWS: Move convenience variable news above Python news.
2635
2636 2019-06-14  Tom Tromey  <tom@tromey.com>
2637
2638         * gnulib: Move directory to top-level.
2639         * configure.ac: Don't configure gnulib.
2640         * configure: Rebuild.
2641         * common/common-defs.h: Use new path to gnulib.
2642         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2643         (GNULIB_H): Remove.
2644         (INCGNU): Look in new gnulib location.
2645         (HFILES_NO_SRCDIR): Remove gnulib files.
2646         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2647         (generated_files): Remove GNULIB_H.
2648         ($(LIBGNU), all-lib): Remove targets.
2649         (distclean): Don't mention GNULIB_BUILDDIR.
2650         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2651
2652 2019-06-14  Tom Tromey  <tromey@adacore.com>
2653
2654         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2655         Warn if symbol file does not provide any symbols.
2656
2657 2019-06-14  Tom Tromey  <tromey@adacore.com>
2658
2659         * source.c (find_and_open_source): Respect basenames_may_differ.
2660
2661 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2662
2663         * annotate.c (annotate_breakpoints_invalid): Make use of
2664         scoped_restore_terminal_state.
2665         (annotate_frames_invalid): Likewise.
2666
2667 2019-06-14  Tom Tromey  <tromey@adacore.com>
2668
2669         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2670         allow assignment to an internalvar.
2671
2672 2019-06-14  Tom Tromey  <tromey@adacore.com>
2673
2674         * ada-lex.l: Allow "_" in attribute names.
2675
2676 2019-06-14  Tom Tromey  <tromey@adacore.com>
2677
2678         PR gdb/24653:
2679         * regcache.c (registers_changed): Don't call alloca.
2680         * top.c (execute_command): Don't call alloca.
2681
2682 2019-06-13  Pedro Alves  <palves@redhat.com>
2683
2684         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2685         'expression'.  When parsing an expression, error out if there's
2686         junk after "unlimited".
2687         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2688         (do_set_command): Adjust calls to is_unlimited_literal.
2689
2690 2019-06-13  Pedro Alves  <palves@redhat.com>
2691
2692         * compile/compile.c (make_compile_options_def_group): Add braces
2693         around array_view initializer.
2694         * thread.c (make_thread_apply_all_options_def_group)
2695         (make_thread_apply_all_options_def_group): Likewise.
2696
2697 2019-06-13  Pedro Alves  <palves@redhat.com>
2698
2699         * NEWS (New commands): Mention "maint test-options
2700         require-delimiter", "maint test-options unknown-is-error", "maint
2701         test-options unknown-is-operand" and "maint show
2702         test-options-completion-result".
2703         (New command options, command completion): New section.
2704         (Completion improvements): New section.
2705         Mention that you can abbreviate "unlimited".
2706
2707 2019-06-13  Pedro Alves  <palves@redhat.com>
2708
2709         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2710         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2711         * unittests/cli-utils-selftests.c (test_parse_flags)
2712         (test_parse_flags_qcs): Delete.
2713         (test_cli_utils): Don't call deleted functions.
2714
2715 2019-06-13  Pedro Alves  <palves@redhat.com>
2716
2717         * thread.c: Include "cli/cli-option.h".
2718         (tp_array_compar_ascending): Global.
2719         (tp_array_compar): Delete function.
2720         (tp_array_compar_ascending, tp_array_compar_descending): New
2721         functions.
2722         (ascending_option_def, qcs_flag_option_def)
2723         (thr_qcs_flags_option_defs)
2724         (make_thread_apply_all_options_def_group)
2725         (make_thread_apply_options_def_group): New.
2726         (thread_apply_all_command): Use gdb::option::process_options.
2727         (thread_apply_command_completer)
2728         (thread_apply_all_command_completer): New.
2729         (thread_apply_command): Use gdb::option::process_options.
2730         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2731         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2732         to generate help text of "thread apply".  Adjust "taas"'s help.
2733         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2734         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2735
2736 2019-06-13  Pedro Alves  <palves@redhat.com>
2737
2738         * thread.c (thread_apply_command): Check for invalid TID with
2739         isdigit instead of !isalpha.
2740
2741 2019-06-13  Pedro Alves  <palves@redhat.com>
2742
2743         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2744         (validate_flags_qcs): New.
2745         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2746         (validate_flags_qcs): Declare.
2747         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2748         (make_frame_apply_options_def_group): New.
2749         (frame_apply_command_count): Process options with
2750         gdb::option::process_options.
2751         (frame_apply_completer): New.
2752         (frame_apply_level_completer, frame_apply_all_completer)
2753         (frame_apply_completer): New.
2754         (_initialize_stack): Update help of "frame apply", "frame apply
2755         level", "frame apply all" and "faas" to mention supported options
2756         and install command completers.
2757         * stack.h (frame_apply_all_completer): Declare.
2758         * thread.c: Include "stack.h".
2759         (tfaas_command): Add "--".
2760         (_initialize_thread): Update help "tfaas" to mention supported
2761         options and install command completer.
2762
2763 2019-06-13  Pedro Alves  <palves@redhat.com>
2764
2765         * completer.c (complete_nested_command_line): New.
2766         (gdb_completion_word_break_characters_throw): Add assertion.
2767         * completer.h (complete_nested_command_line): Declare.
2768
2769 2019-06-13  Pedro Alves  <palves@redhat.com>
2770
2771         * stack.c (parse_backtrace_qualifiers): New.
2772         (backtrace_command): Use it.
2773         (backtrace_command_completer): Complete on qualifiers.
2774
2775 2019-06-13  Pedro Alves  <palves@redhat.com>
2776
2777         * frame.c: Include "cli/cli-option.h.
2778         (user_set_backtrace_options): New.
2779         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2780         Delete.
2781         (get_prev_frame): Adjust.
2782         (boolean_option_def, uinteger_option_def)
2783         (set_backtrace_option_defs): New.
2784         (_initialize_frame): Adjust and use
2785         gdb::option::add_setshow_cmds_for_options to install "set
2786         backtrace past-main" and "set backtrace past-entry".
2787         * frame.h: Include "cli/cli-option.h".
2788         (struct frame_print_options): Forward declare.
2789         (print_frame_arguments_all, print_frame_arguments_scalars)
2790         (print_frame_arguments_none): Declare.
2791         (print_entry_values): Delete declaration.
2792         (struct frame_print_options, user_frame_print_options): New.
2793         (struct set_backtrace_options): New.
2794         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2795         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2796         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2797         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2798         (list_args_or_locals): Add frame_print_options parameter.
2799         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2800         * python/py-framefilter.c (enumerate_args): Pass down
2801         USER_FRAME_PRINT_OPTIONS.
2802         * stack.c: Include "cli/cli-option.h".
2803         (print_frame_arguments_all, print_frame_arguments_scalars)
2804         (print_frame_arguments_none): Declare.
2805         (print_raw_frame_arguments, print_entry_values): Delete.
2806         (user_frame_print_options): New.
2807         (boolean_option_def, enum_option_def, frame_print_option_defs):
2808         New.
2809         (struct backtrace_cmd_options): New.
2810         (bt_flag_option_def): New.
2811         (backtrace_command_option_defs): New.
2812         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2813         (print_frame_arg, read_frame_arg, print_frame_args)
2814         (print_frame_info, print_frame): Add frame_print_options parameter
2815         and use it.
2816         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2817         (backtrace_command_1): Add frame_print_options and
2818         backtrace_cmd_options parameters and use them.
2819         (make_backtrace_options_def_group): New.
2820         (backtrace_command): Process command options with
2821         gdb::option::process_options.
2822         (backtrace_command_completer): New.
2823         (_initialize_stack): Extend "backtrace"'s help to mention
2824         supported options.  Install completer for "backtrace".
2825         Install some settings commands with add_setshow_cmds_for_options.
2826
2827 2019-06-13  Pedro Alves  <palves@redhat.com>
2828
2829         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2830         and that "set/show print raw frame-arguments" are now deprecated.
2831
2832         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2833         command.
2834         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2835         * stack.c (_initialize_stack): Install "set/show print
2836         raw-frame-arguments", and deprecate "set/show print raw
2837         frame-arguments".
2838         * valprint.c (_initialize_valprint): Deprecate "set/show print
2839         raw".
2840
2841 2019-06-13  Pedro Alves  <palves@redhat.com>
2842
2843         * compile/compile.c (struct compile_options): New.
2844         (compile_flag_option_def, compile_command_option_defs)
2845         (make_compile_options_def_group): New.
2846         (compile_file_command): Handle options with
2847         gdb::option::process_options.
2848         (compile_file_command_completer): New function.
2849         (compile_code_command): Handle options with
2850         gdb::option::process_options.
2851         (compile_code_command_completer): New function.
2852         (_initialize_compiler): Install completers for "compile code" and
2853         "compile file".  Mention available options in "compile code" and
2854         "compile code"'s help.
2855         * completer.c (advance_to_completion_word): New, factored out from
2856         ...
2857         (advance_to_expression_complete_word_point): ... this.
2858         (advance_to_filename_complete_word_point): New.
2859         * completer.h (advance_to_filename_complete_word_point): New
2860         declaration.
2861
2862 2019-06-13  Pedro Alves  <palves@redhat.com>
2863
2864         * compile/compile.c: Include "cli/cli-option.h".
2865         (compile_print_value): Scope data pointer is now a
2866         value_print_options pointer; adjust.
2867         (compile_print_command): Process options.  Scope data pointer is
2868         now a value_print_options pointer; adjust.
2869         (_initialize_compile): Update "compile print"'s help to include
2870         supported options.  Install a completer for "compile print".
2871         * cp-valprint.c (show_vtblprint, show_objectprint)
2872         (show_static_field_print): Delete.
2873         (_initialize_cp_valprint): Don't install "set print
2874         static-members", "set print vtbl", "set print object" here.
2875         * printcmd.c: Include "cli/cli-option.h" and
2876         "common/gdb_optional.h".
2877         (print_command_parse_format): Rework to fill in a
2878         value_print_options instead of a format_data.
2879         (print_value): Change parameter type from format_data pointer to
2880         value_print_options reference.  Adjust.
2881         (print_command_1): Process options.  Adjust to pass down a
2882         value_print_options.
2883         (print_command_completer): New.
2884         (_initialize_printcmd): Install print_command_completer as
2885         handle_brkchars completer for the "print" command.  Update
2886         "print"'s help to include supported options.
2887         * valprint.c: Include "cli/cli-option.h".
2888         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2889         here from cp-valprint.c.
2890         (boolean_option_def, uinteger_option_def)
2891         (value_print_option_defs, make_value_print_options_def_group):
2892         New.  Use gdb::option::add_setshow_cmds_for_options to install
2893         "set print elements", "set print null-stop", "set print repeats",
2894         "set print pretty", "set print union", "set print array", "set
2895         print address", "set print symbol", "set print array-indexes".
2896         * valprint.h: Include <string> and "cli/cli-option.h".
2897         (make_value_print_options_def_group): Declare.
2898         (print_value): Change parameter type from format_data pointer to
2899         value_print_options reference.
2900         (print_command_completer): Declare.
2901
2902 2019-06-13  Pedro Alves  <palves@redhat.com>
2903
2904         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2905         (COMMON_SFILES): Add maint-test-settings.c.
2906         * cli/cli-decode.c (boolean_enums): New global, factored out from
2907         ...
2908         (add_setshow_boolean_cmd): ... here.
2909         * cli/cli-decode.h (boolean_enums): Declare.
2910         * cli/cli-option.c: New file.
2911         * cli/cli-option.h: New file.
2912         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2913         factored out from ...
2914         (parse_cli_boolean_value(const char *)): ... this.
2915         (is_unlimited_literal): Change parameter type to pointer to
2916         pointer.  Adjust and advance ARG pointer.
2917         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2918         (parse_cli_var_enum): New, factored out from ...
2919         (do_set_command): ... this.  Adjust.
2920         * cli/cli-setshow.h (parse_cli_boolean_value)
2921         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2922         (parse_cli_var_enum): Declare.
2923         * cli/cli-utils.c: Include "cli/cli-option.h".
2924         (get_ulongest): New.
2925         * cli/cli-utils.h (get_ulongest): Declare.
2926         (check_for_argument): New overloads.
2927         * maint-test-options.c: New file.
2928
2929 2019-06-13  Pedro Alves  <palves@redhat.com>
2930
2931         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2932         parse a range if "-" is at the end of the string.
2933
2934 2019-06-13  Pedro Alves  <palves@redhat.com>
2935
2936         * cli/cli-setshow.c (parse_auto_binary_operation)
2937         (parse_cli_boolean_value): Don't allow "o".
2938
2939 2019-06-13  Pedro Alves  <palves@redhat.com>
2940
2941         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2942         * NEWS: Mention maint test-settings KIND.
2943         * maint-test-settings.c: New file.
2944
2945 2019-06-13  Pedro Alves  <palves@redhat.com>
2946
2947         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2948         completer.
2949         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2950         "set" completers.
2951
2952 2019-06-13  Pedro Alves  <palves@redhat.com>
2953
2954         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2955         after item.
2956
2957 2019-06-13  Pedro Alves  <palves@redhat.com>
2958
2959         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2960
2961 2019-06-13  Pedro Alves <palves@redhat.com>
2962
2963         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2964         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2965         call.
2966         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2967         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2968         calls.
2969         (check_for_argument): Skip spaces after argument.
2970
2971 2019-06-13  Pedro Alves  <palves@redhat.com>
2972
2973         * thread.c (thread_apply_command): Adjust TID parsing.
2974         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2975         detected before end of string.
2976         (tid_is_in_list): Error out if LIST is invalid.
2977
2978 2019-06-13  Pedro Alves  <palves@redhat.com>
2979
2980         * completer.c (complete_line_internal_1): Rewind completion word
2981         point.
2982         (completion_tracker::advance_custom_word_point_by): Change
2983         parameter type to int.
2984         * completer.h (completion_tracker::advance_custom_word_point_by):
2985         Likewise.
2986
2987 2019-06-13  Pedro Alves  <palves@redhat.com>
2988
2989         * completer.c (advance_to_completion_word): Handle delimiters.
2990
2991 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2992
2993         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2994
2995 2019-06-11  Tom Tromey  <tom@tromey.com>
2996
2997         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2998         (xmalloc_failed): Move to alloc.c.
2999         * alloc.c: New file.
3000         * Makefile.in (COMMON_SFILES): Add alloc.c.
3001
3002 2019-06-11  Tom Tromey  <tom@tromey.com>
3003
3004         * nat/linux-waitpid.c: Don't include server.h.
3005         (linux_debug): Remove.
3006         (my_waitpid): Update.
3007
3008 2019-06-11  Tom Tromey  <tromey@adacore.com>
3009
3010         * infcall.c (_initialize_infcall): Remove trailing newline from
3011         help.
3012         * user-regs.c (_initialize_user_regs): Remove trailing newline
3013         from help.
3014         * typeprint.c (_initialize_typeprint): Remove trailing newline
3015         from help.
3016         * reverse.c (_initialize_reverse): Remove trailing newlines from
3017         help.
3018         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3019         from help.
3020         * language.c (add_set_language_command): Remove trailing newline
3021         from help.
3022         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3023         help.
3024         * disasm.c (_initialize_disasm): Remove trailing newline from
3025         help.
3026         * top.c (init_main): Remove trailing newline from help.
3027         * interps.c (_initialize_interpreter): Remove trailing newline
3028         from help.
3029         * btrace.c (_initialize_btrace): Remove trailing newlines from
3030         help.
3031         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3032         from help.
3033         * python/python.c (_initialize_python): Remove trailing newline
3034         from help.
3035         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3036         help.
3037         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3038         from help.  Reformat some text.
3039         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3040         from help.
3041         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3042         newline from help.
3043
3044 2019-06-11  Tom Tromey  <tromey@adacore.com>
3045
3046         * darwin-nat.c (darwin_decode_exception_message)
3047         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3048
3049 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3050
3051         * valops.c (value_slice): Check for not allocated or not
3052         associated values.
3053
3054 2019-06-10  Tom de Vries  <tdevries@suse.de>
3055
3056         PR gdb/24618
3057         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3058         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3059         invalid.
3060
3061 2019-06-10  Tom de Vries  <tdevries@suse.de>
3062
3063         PR gdb/24611
3064         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3065         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3066
3067 2019-06-10  Tom de Vries  <tdevries@suse.de>
3068
3069         PR symtab/24545
3070         * symtab.c (struct demangled_name_entry): Add language field.
3071         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3072         static minimal symbol".  Set and use language field.
3073
3074 2019-06-10  Tom Tromey  <tromey@adacore.com>
3075
3076         * ada-lang.c (_initialize_ada_language): Update help text.
3077
3078 2019-06-10  Tom Tromey  <tromey@adacore.com>
3079
3080         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3081         with a newline.
3082         * guile/guile.c (handle_boot_error): Don't end warning with a
3083         newline.
3084         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3085         warning with a newline.
3086         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3087         newline.
3088         (s12z_frame_cache): Likewise.
3089         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3090         a newline.
3091         * solib-svr4.c (disable_probes_interface): Don't end warning with
3092         a newline.
3093         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3094         newline.
3095         * python/python.c (do_finish_initialization): Don't end warning
3096         with a newline.
3097
3098 2019-06-10  Tom Tromey  <tom@tromey.com>
3099
3100         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3101         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3102         gdbpy_enter.
3103
3104 2019-06-10  Tom Tromey  <tromey@adacore.com>
3105
3106         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3107         data.
3108         (elf_new_init): Don't call stabsread_new_init.
3109         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3110         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3111         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3112
3113 2019-06-10  Tom de Vries  <tdevries@suse.de>
3114
3115         PR symtab/16264
3116         PR symtab/24517
3117         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3118
3119 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3120
3121         * source.c (find_and_open_source): Also rewrite relative file
3122         names.
3123
3124 2019-04-26  Amos Bird  <amosbird@gmail.com>
3125
3126         * annotate.c (annotate_thread_exited): Add "thread-exited"
3127         annotation.
3128
3129 2019-06-06  Tom Tromey  <tromey@adacore.com>
3130
3131         * maint.h (class scoped_command_stats): Use
3132         DISABLE_COPY_AND_ASSIGN.
3133         <print_time>: New method.
3134         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3135         print_time.
3136         (scoped_command_stats::print_time): New method.
3137
3138 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3139
3140         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3141         instructions of lengths 6 or 8 bytes.
3142
3143 2019-06-04  Pedro Alves  <palves@redhat.com>
3144
3145         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3146
3147         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3148         * breakpoint.c (condition_completer): Likewise.
3149         * cli/cli-dump.c (scan_expression): Likewise.
3150         * common/filestuff.c (mkdir_recursive): Likewise.
3151         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3152         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3153         (gdb_abspath): Likewise.
3154         * compile/compile-cplus-types.c
3155         (compile_cplus_instance::decl_name): Likewise.
3156         * completer.c (complete_explicit_location):
3157         (signal_completer, reg_or_group_completer_1): Likewise.
3158         * cp-support.c (cp_remove_params_if_any): Likewise.
3159         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3160         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3161         * infcmd.c (strip_bg_char): Likewise.
3162         * linespec.c (copy_token_string): Likewise.
3163         * mi/mi-main.c (output_cores): Likewise.
3164         * psymtab.c (psymtab_search_name):
3165         * symfile.c (test_set_ext_lang_command): Likewise.
3166         * target.c (target_fileio_read_stralloc): Likewise.
3167         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3168         * value.c (complete_internalvar): Likewise.
3169
3170 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3171
3172         Add objfile property to gdb.Type.
3173         * NEWS: Mention Python API addition.
3174         * python/py-type.c (typy_get_objfile): New method.
3175
3176 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3177
3178         * NEWS: Mention the new set|show style [title|highlight].
3179         Mention changes to "show style", "help" and "apropos".
3180
3181 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3182
3183         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3184         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3185         instead of print_help_for_command.
3186         (print_doc_of_command): New function.
3187         (help_list): Add 'apropos -v word' suggestion.
3188         (print_help_for_command): Style the command name using title style.
3189         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3190         (_initialize_cli_cmds): Describe -v in apropos_command help.
3191
3192 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3193
3194         * cli/cli-style.h (cli_style_option): Add name in constructor,
3195         add m_name class member, add constructor with intensity,
3196         add name class function.
3197         (cli_style_option::add_setshow_commands): Remove name argument.
3198         (highlight_style, title_style): New styles.
3199         * cli/cli-style.c (do_show): New function that shows a style
3200         characteristic styling the style name with itself.
3201         (set_style_name): New function.
3202         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3203         Update all callers according to the changes in cli/cli-style.h.
3204         * utils.h (fputs_highlighted): New function.
3205         * utils.c (fputs_highlighted): Likewise.
3206
3207 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3208
3209         * NEWS: Mention new pipe command and new convenience variables.
3210
3211 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3212
3213         * cli/cli-cmds.c (pipe_command): New function.
3214         (_initialize_cli_cmds): Call add_com for pipe_command.
3215         Define | as an alias for pipe.
3216         (exit_status_set_internal_vars): New function.
3217         (shell_escape): Call exit_status_set_internal_vars.
3218         cli/cli-decode.c (find_command_name_length): Recognize | as
3219         a single character command.
3220
3221 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3222
3223         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3224         top.c (execute_command_to_ui_file): New function, mostly a copy
3225         of execute_command_to_string.
3226         (execute_command_to_string): Implement by calling
3227         execute_command_to_ui_file.
3228
3229 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3230
3231         * top.h (saved_command_line): Remove declaration.
3232         * top.c (previous_saved_command_line, previous_repeat_arguments):
3233         New variables.
3234         (saved_command_line): Make static, define together with other
3235         'repeat variables'.
3236         (dont_repeat): Clear repeat_arguments.
3237         (repeat_previous, get_saved_command_line, save_command_line):
3238         New functions.
3239         (gdb_init): Initialize saved_command_line
3240         and previous_saved_command_line.
3241         * main.c (captured_main_1): Remove saved_command_line initialization.
3242         * event-top.c (handle_line_of_input): Update to use
3243         the new 'repeat' related functions instead of direct access to
3244         saved_command_line.
3245         * command.h (repeat_previous, get_saved_command_line,
3246         save_command_line): New declarations.
3247         (dont_repeat): Add comment.
3248
3249 2019-05-30  Tom Tromey  <tromey@adacore.com>
3250
3251         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3252         Fix comment.
3253         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3254
3255 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3256
3257         PR cli/24587
3258         * completer.c (complete): Initialize variable word.
3259
3260 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3261
3262         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3263         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3264         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3265         'body' is NULL to the outter 'if', protecting the '!is_define'
3266         situation as well.
3267
3268 2019-05-29  Tom Tromey  <tromey@adacore.com>
3269
3270         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3271         (dwarf_unknown): New function.
3272         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3273         (dwarf_type_encoding_name): Use dwarf_unknown.
3274
3275 2019-05-29  Tom Tromey  <tromey@adacore.com>
3276
3277         PR c++/20020:
3278         * cp-valprint.c (cp_print_value_fields): Call
3279         cp_print_static_field inside "try".
3280
3281 2019-05-29  Tom Tromey  <tromey@adacore.com>
3282
3283         * inflow.c (struct terminal_info): Add default operator=.
3284         * configure: Rebuild.
3285         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3286         -Wdeprecated-copy-dtor, -Wredundant-move.
3287
3288 2019-05-29  Tom Tromey  <tromey@adacore.com>
3289
3290         * NEWS: Add entry.
3291         * infcmd.c (print_return_value_1): Handle finish_print
3292         option.
3293         (show_print_finish): New function.
3294         (_initialize_infcmd): Add "set/show print finish" commands.
3295         * valprint.c (user_print_options): Initialize new member.
3296         * valprint.h (struct value_print_options) <finish_print>: New
3297         member.
3298
3299 2019-05-28  Tom Tromey  <tromey@adacore.com>
3300
3301         * ada-lang.c (ada_remove_Xbn_suffix)
3302         (find_old_style_renaming_symbol)
3303         (parse_old_style_renaming): Remove.
3304         (ada_find_renaming_symbol): Don't call
3305         find_old_style_renaming_symbol.
3306         (ada_is_renaming_symbol): Rename from
3307         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3308         bool.  Now static.
3309         (ada_read_var_value): Update and simplify.
3310         * ada-exp.y (write_var_or_type): Remove old code.
3311
3312 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3313
3314         * event-top.c: Remove include comment.
3315         * inflow.c (class scoped_ignore_sigttou): Move from here...
3316         * inflow.h (class scoped_ignore_sigttou): ...to here.
3317         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3318         * top.c:  Remove include comment.
3319
3320 2019-05-27  Tom Tromey  <tom@tromey.com>
3321
3322         * NEWS: Fix typo.
3323
3324 2019-05-22  Tom Tromey  <tromey@adacore.com>
3325
3326         * target.c (target_follow_exec): Constify parameter.
3327         * target-delegates.c: Rebuild.
3328         * remote.c (remote_target::follow_exec): Constify parameter.
3329         * infrun.c (follow_exec): Constify parameter.
3330         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3331         (target_follow_exec): Likewise.
3332
3333 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3334
3335         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3336         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3337
3338 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3339
3340         * NEWS: Add debugredirect and testsuite sections.
3341
3342 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3343
3344         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3345         target descriptions using exclusively floating point register name
3346         aliases.
3347
3348 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3349
3350         PR gdb/18644:
3351         * f-lang.c (build_fortran_types): Handle the case where
3352         gdbarch_floatformat_for_type returns a nullptr.
3353
3354 2019-05-21  Tom de Vries  <tdevries@suse.de>
3355
3356         PR cli/24587
3357         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3358
3359 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3360
3361         PR gdb/18644:
3362         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3363         16-byte floats.
3364         * i386-tdep.c (i386_floatformat_for_type): Use
3365         floatformats_ia64_quad for the 16-byte floating point component
3366         within a fortran 32-byte complex number.
3367
3368 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3369
3370         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3371         delete default constructor.
3372         (find_partial_die): Update to return const struct.
3373         (partial_die_parent_scope): Move variable declaration into scope
3374         of its use and change its type to auto.
3375         (guess_partial_die_structure_name): Likewise.
3376         (partial_die_info::fixup): Likewise.
3377
3378 2019-05-17  Tom Tromey  <tromey@adacore.com>
3379
3380         * source.c (find_and_open_source): Remove cast.
3381
3382 2019-05-17  Tom Tromey  <tromey@adacore.com>
3383
3384         * annotate.c (annotate_source): Make "filename" const.
3385         * annotate.h (annotate_source): Use const.
3386
3387 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3388
3389         * disasm.c (set_disassembler_options): Send errors to stderr.
3390
3391 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3392
3393         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3394         (cli_interp_base::set_logging): Check debug_redirect.
3395         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3396         * cli/cli-logging.c (debug_redirect): Add static variable.
3397         (pop_output_files): Add default param.
3398         (handle_redirections): Print debug setting.
3399         (show_logging_command): Likewise.
3400         (_initialize_cli_logging): Add debugredirect command.
3401         * interps.c (current_interp_set_logging): Add debug_redirect
3402         parameter.
3403         * interps.h (set_logging): Add debug_redirect parameter.
3404         (current_interp_set_logging): Likewise.
3405         * mi/mi-common.h: Likewise.
3406         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3407
3408 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3409             Tom Tromey  <tromey@adacore.com>
3410
3411         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3412         directly.
3413         * cli/cli-interp.h (make_logging_output): Remove declaration.
3414         * cli/cli-logging.c (make_logging_output): Remove function.
3415         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3416         directly.
3417         * ui-file.c (tee_file::tee_file): Remove bools.
3418         (tee_file::~tee_file): Remove deletes.
3419         * ui-file.h (tee_file): Remove bools.
3420
3421 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3422
3423         * mi/mi-cmds.h (mi_cmd_complete): New function.
3424         * mi/mi-main.c (mi_cmd_complete): Likewise.
3425         * mi/mi-cmds.c: Define new MI command -complete.
3426         * NEWS: Mention new -complete command.
3427
3428 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3429
3430         * completer.h (complete): New function.
3431         * completer.c (complete): Likewise.
3432         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3433         function defined in completer.h.
3434
3435 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3436
3437         * MAINTAINERS (Write After Approval): Add myself.
3438
3439 2019-05-17  Tom de Vries  <tdevries@suse.de>
3440
3441         PR gdb/24094
3442         * dwarf2read.c (struct cu_partial_die_info): New struct.
3443         (find_partial_die): Return cu_partial_die_info.
3444         (partial_die_parent_scope, guess_partial_die_structure_name)
3445         (partial_die_info::fixup): Handle new return type of find_partial_die.
3446
3447 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3448
3449         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3450         "std::string", simplifying the algorithm.
3451
3452 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3453
3454         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3455         (stap_static_probe_ops::get_probes): Likewise.
3456
3457 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3458
3459         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3460         '-')" and "else if".
3461         (stap_parse_single_operand): Join checks for
3462         "gdbarch_stap_parse_special_token_p" and
3463         "gdbarch_stap_parse_special_token" in the same "if" statement.
3464         Invert check when verifying for operation on register
3465         displacement.
3466
3467 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3468
3469         * stap-probe.c (stap_get_opcode): Update comment.
3470         (stap_get_expected_argument_type): Likewise.
3471         (handle_stap_probe): Likewise.
3472
3473 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3474
3475         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3476         return type to 'bool'.  Adjust comment.  Use 'bool' when
3477         appropriate.
3478         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3479         * stap-probe.c (stap_parse_argument_1): Likewise.
3480         (stap_is_operator): Likewise.
3481         (stap_is_generic_prefix): Likewise.
3482         (stap_is_register_prefix): Likewise.
3483         (stap_is_register_indirection_prefix): Likewise.
3484         (stap_is_integer_prefix): Likewise.
3485         (stap_generic_check_suffix): Likewise.
3486         (stap_check_integer_suffix): Likewise.
3487         (stap_check_register_suffix): Likewise.
3488         (stap_check_register_indirection_suffix): Likewise.
3489         (stap_parse_register_operand): Likewise.
3490         (stap_parse_single_operand): Likewise.
3491         (stap_parse_argument_1): Likewise.
3492         (stap_probe::get_argument_count): Likewise.
3493         (stap_is_operator): Likewise.
3494
3495 2019-05-16  Tom Tromey  <tromey@adacore.com>
3496
3497         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3498         keyword to foreach.
3499
3500 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3501
3502         * linux-thread-db.c (try_thread_db_load_1): Change return type
3503         to bool.
3504         (try_thread_db_load): Likewise.
3505         (try_thread_db_load_from_pdir_1): Likewise.
3506         (try_thread_db_load_from_pdir): Likewise.
3507         (try_thread_db_load_from_sdir): Likewise.
3508         (try_thread_db_load_from_dir): Likewise.
3509         (thread_db_load_search): Likewise.
3510         (has_libpthread): Likewise.
3511         (thread_db_load): Likewise.
3512
3513 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3514
3515         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3516         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3517         NULL, and complain/return if that's the case.
3518
3519 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3520
3521         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3522         (advance, posn, abstract_read_memory): New functions.
3523         [struct mem_read_abstraction]: New struct.
3524         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3525
3526 2019-05-14  Tom Tromey  <tromey@adacore.com>
3527
3528         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3529         value is not lval_memory.
3530
3531 2019-05-14  Tom Tromey  <tromey@adacore.com>
3532
3533         * solib.c (info_sharedlibrary_command): Style the file name.
3534
3535 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3536
3537         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3538         (aarch64_vnv_type): Likewise.
3539         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3540         * common/tdesc.c: Likewise.
3541         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3542         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3543         * features/aarch64-fpu.xml: Add ieee half view.
3544         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3545         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3546         * gdbtypes.h (struct builtin_type): Likewise.
3547         (struct objfile_type): Likewise.
3548
3549 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3550
3551         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3552         typo.
3553         * location.h (string_to_event_location): Likewise.
3554
3555 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3556
3557         GDB 8.3 released.
3558
3559 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3560
3561         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3562         New variable declaration.
3563         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3564         New variable.
3565         (print_one_breakpoint): Use ui_out::test_flags and new global
3566         variable to compute use_fixed_output.
3567         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3568         Remove.
3569         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3570         (mi_multi_location_breakpoint_output_fixed): Remove.
3571         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3572         new variable.
3573         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3574         fix_multi_location_breakpoint_output flag if version >= 3.
3575         * ui-out.h (enum ui_out_flag)
3576         <fix_multi_location_breakpoint_output>: New enumerator.
3577
3578 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3579
3580         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3581
3582 2019-05-10  Tom Tromey  <tromey@adacore.com>
3583
3584         * ada-lang.c (catch_ada_completer): New function.
3585         (_initialize_ada_language): Use it.
3586
3587 2019-05-10  Tom Tromey  <tromey@adacore.com>
3588
3589         * thread.c (print_thread_info): Make "requested_threads" const.
3590         * gdbthread.h (print_thread_info): Make "requested_threads"
3591         const.
3592         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3593         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3594
3595 2019-05-08  Tom Tromey  <tom@tromey.com>
3596
3597         * gdbtypes.c (objfile_type_data): Change type.
3598         (objfile_type, _initialize_gdbtypes): Update.
3599
3600 2019-05-08  Tom Tromey  <tom@tromey.com>
3601
3602         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3603         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3604         (_initialize_dwarf2_frame): Update.
3605
3606 2019-05-08  Tom Tromey  <tom@tromey.com>
3607
3608         * objc-lang.c (objc_objfile_data): Change type.
3609         (find_methods): Update.
3610         (_initialize_objc_lang): Remove.
3611
3612 2019-05-08  Tom Tromey  <tom@tromey.com>
3613
3614         * stabsread.c (rs6000_builtin_type_data): Change type.
3615         (rs6000_builtin_type, _initialize_stabsread): Update.
3616
3617 2019-05-08  Tom Tromey  <tom@tromey.com>
3618
3619         * mips-tdep.c (mips_pdr_data): Remove.
3620         (_initialize_mips_tdep): Update.
3621
3622 2019-05-08  Tom Tromey  <tom@tromey.com>
3623
3624         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3625         (hppa_init_objfile_priv_data, read_unwind_info)
3626         (find_unwind_entry, _initialize_hppa_tdep): Update.
3627
3628 2019-05-08  Tom Tromey  <tom@tromey.com>
3629
3630         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3631         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3632         on obstack.
3633         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3634
3635 2019-05-08  Tom Tromey  <tom@tromey.com>
3636
3637         * mdebugread.c (basic_type_data): Change type.
3638         (basic_type, _initialize_mdebugread): Update.
3639
3640 2019-05-08  Tom Tromey  <tom@tromey.com>
3641
3642         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3643
3644 2019-05-08  Tom Tromey  <tom@tromey.com>
3645
3646         * nto-tdep.c (nto_inferior_data_reg): Change type.
3647         (nto_inferior_data): Update.
3648         (nto_inferior_data_cleanup, nto_new_inferior_data)
3649         (_initialize_nto_tdep): Remove.
3650         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3651
3652 2019-05-08  Tom Tromey  <tom@tromey.com>
3653
3654         * ada-lang.c (struct ada_inferior_data): Add initializers.
3655         (ada_inferior_data): Change type.
3656         (ada_inferior_data_cleanup): Remove.
3657         (get_ada_inferior_data, ada_inferior_exit)
3658         (struct ada_pspace_data): Add initializers, destructor.
3659         (ada_pspace_data_handle): Change type.
3660         (get_ada_pspace_data): Update.
3661         (ada_pspace_data_cleanup): Remove.
3662
3663 2019-05-08  Tom Tromey  <tom@tromey.com>
3664
3665         * coffread.c (struct coff_symfile_info): Add initializers.
3666         (coff_objfile_data_key): Move lower.  Change type.
3667         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3668         Update.
3669         (coff_free_info): Remove.
3670
3671 2019-05-08  Tom Tromey  <tom@tromey.com>
3672
3673         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3674         (fbsd_pspace_data_handle): Move lower.  Change type.
3675         (get_fbsd_pspace_data): Update.
3676         (fbsd_pspace_data_cleanup): Remove.
3677         (_initialize_fbsd_tdep): Update.
3678
3679 2019-05-08  Tom Tromey  <tom@tromey.com>
3680
3681         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3682         (get_ada_tasks_pspace_data): Update.
3683         (ada_tasks_pspace_data_cleanup): Remove.
3684         (_initialize_tasks): Update.
3685         (ada_tasks_inferior_data_handle): Change type.
3686         (get_ada_tasks_inferior_data): Update.
3687         (ada_tasks_inferior_data_cleanup): Remove.
3688         (struct ada_tasks_pspace_data): Add initializers.
3689
3690 2019-05-08  Tom Tromey  <tom@tromey.com>
3691
3692         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3693         * symfile-debug.c (debug_sym_get_probes): Change type.
3694         * stap-probe.c (handle_stap_probe):
3695         (stap_static_probe_ops::get_probes): Change type.
3696         * probe.h (class static_probe_ops) <get_probes>: Change type.
3697         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3698         (parse_probes_in_pspace): Update.
3699         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3700         Update.
3701         (any_static_probe_ops::get_probes): Change type.
3702         * elfread.c (elfread_data): New typedef.
3703         (probe_key): Change type.
3704         (elf_get_probes): Likewise.  Update.
3705         (probe_key_free): Remove.
3706         (_initialize_elfread): Update.
3707         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3708         Change type.
3709         (dtrace_process_dof_probe, dtrace_process_dof)
3710         (dtrace_static_probe_ops::get_probe): Change type.
3711
3712 2019-05-08  Tom Tromey  <tom@tromey.com>
3713
3714         * xcoffread.c (struct xcoff_symfile_info): Rename from
3715         coff_symfile_info.  Add initializers.
3716         (xcoff_objfile_data_key): Move lower.  Change type.
3717         (XCOFF_DATA): Rewrite.
3718         (xcoff_free_info): Remove.
3719         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3720         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3721         (xcoff_initial_scan): Update.
3722
3723 2019-05-08  Tom Tromey  <tom@tromey.com>
3724
3725         * solib-svr4.c (struct svr4_info): Add initializers and
3726         destructor.
3727         <probes_table>: Now an htab_up.
3728         (solib_svr4_pspace_data): Change type.
3729         (free_probes_table): Simplify.
3730         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3731         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3732         (probes_table_remove_objfile_probes, register_solib_event_probe)
3733         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3734         (_initialize_svr4_solib): Update.
3735
3736 2019-05-08  Tom Tromey  <tom@tromey.com>
3737
3738         * remote.c (remote_pspace_data): Change type.
3739         (remote_pspace_data_cleanup): Remove.
3740         (get_remote_exec_file, set_pspace_remote_exec_file)
3741         (_initialize_remote): Update.
3742
3743 2019-05-08  Tom Tromey  <tom@tromey.com>
3744
3745         * breakpoint.c (breakpoint_objfile_key): Change type.
3746         (get_breakpoint_objfile_data): Update.
3747         (free_breakpoint_objfile_data): Remove.
3748         (_initialize_breakpoint): Update.
3749
3750 2019-05-08  Tom Tromey  <tom@tromey.com>
3751
3752         * linux-tdep.c (struct linux_info): Add initializers.
3753         (linux_inferior_data): Move.  Change type.
3754         (invalidate_linux_cache_inf): Update.
3755         (linux_inferior_data_cleanup): Remove.
3756         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3757
3758 2019-05-08  Tom Tromey  <tom@tromey.com>
3759
3760         * auxv.c (auxv_inferior_data): Move.  Change type.
3761         (auxv_inferior_data_cleanup): Remove.
3762         (invalidate_auxv_cache_inf): Rewrite.
3763         (get_auxv_inferior_data, _initialize_auxv): Update.
3764
3765 2019-05-08  Tom Tromey  <tom@tromey.com>
3766
3767         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3768         (symfile_debug_objfile_data_key): Change type.
3769         (symfile_debug_installed, debug_qf_has_symbols)
3770         (debug_qf_find_last_source_symtab)
3771         (debug_qf_forget_cached_source_info)
3772         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3773         (debug_qf_print_stats, debug_qf_dump)
3774         (debug_qf_expand_symtabs_for_function)
3775         (debug_qf_expand_all_symtabs)
3776         (debug_qf_expand_symtabs_with_fullname)
3777         (debug_qf_map_matching_symbols)
3778         (debug_qf_expand_symtabs_matching)
3779         (debug_qf_find_pc_sect_compunit_symtab)
3780         (debug_qf_map_symbol_filenames)
3781         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3782         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3783         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3784         (debug_sym_read_linetable, debug_sym_relocate): Update.
3785         (symfile_debug_free_objfile): Remove.
3786         (install_symfile_debug_logging, _initialize_symfile_debug):
3787         Update.
3788
3789 2019-05-08  Tom Tromey  <tom@tromey.com>
3790
3791         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3792         allocate_on_obstack.
3793         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3794         (get_dwarf2_per_objfile): Update.
3795         (set_dwarf2_per_objfile): Remove.
3796         (dwarf2_has_info, dwarf2_get_section_info): Update.
3797         (dwarf2_free_objfile): Remove.
3798         (_initialize_dwarf2_read): Update.
3799
3800 2019-05-08  Tom Tromey  <tom@tromey.com>
3801
3802         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3803         initializers.
3804         <unsupported_script_warning_printed,
3805         script_not_found_warning_printed>: Now bool.
3806         (auto_load_pspace_data): Change type.
3807         (~auto_load_pspace_info): Rename from
3808         auto_load_pspace_data_cleanup.
3809         (get_auto_load_pspace_data, init_loaded_scripts_info)
3810         (clear_section_scripts, maybe_print_unsupported_script_warning)
3811         (maybe_print_script_not_found_warning, _initialize_auto_load):
3812         Update.
3813
3814 2019-05-08  Tom Tromey  <tom@tromey.com>
3815
3816         * objfiles.c (objfile_pspace_info): Add destructor and
3817         initializers.
3818         (objfiles_pspace_data): Change type.
3819         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3820         (get_objfile_pspace_data): Update.
3821         (objfiles_bfd_data): Change type.
3822         (get_objfile_bfd_data): Update.
3823         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3824
3825 2019-05-08  Tom Tromey  <tom@tromey.com>
3826
3827         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3828         Change type.
3829         (get_catch_syscall_inferior_data): Update.
3830         (catch_syscall_inferior_data_cleanup): Remove.
3831         (_initialize_break_catch_syscall): Update.
3832
3833 2019-05-08  Tom Tromey  <tom@tromey.com>
3834
3835         * inflow.c (struct terminal_info): Add destructor and
3836         initializers.
3837         (inflow_inferior_data): Change type.
3838         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3839         (get_inflow_inferior_data, inflow_inferior_exit)
3840         (swap_terminal_info, _initialize_inflow): Update.
3841
3842 2019-05-08  Tom Tromey  <tom@tromey.com>
3843
3844         * target-dcache.c (target_dcache_cleanup): Remove.
3845         (target_dcache_aspace_key): Change type.
3846         (target_dcache_init_p, target_dcache_invalidate)
3847         (target_dcache_get, target_dcache_get_or_init)
3848         (_initialize_target_dcache): Update.
3849         * dcache.h (struct dcache_deleter): New.
3850
3851 2019-05-08  Tom Tromey  <tom@tromey.com>
3852
3853         * symtab.c (struct symbol_cache): Add destructor and
3854         initializers.
3855         (symbol_cache_key): Move.  Change type.
3856         (make_symbol_cache, free_symbol_cache): Remove.
3857         (get_symbol_cache): Update.
3858         (symbol_cache_cleanup): Remove.
3859         (ALL_PSPACES, symbol_cache_flush)
3860         (maintenance_print_symbol_cache)
3861         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3862         Update.
3863
3864 2019-05-08  Tom Tromey  <tom@tromey.com>
3865
3866         * symtab.c (struct main_info): Add destructor and initializers.
3867         (main_progspace_key): Move.  Change type.
3868         (get_main_info): Update.
3869         (main_info_cleanup): Remove.
3870         (_initialize_symtab): Update.
3871
3872 2019-05-08  Tom Tromey  <tom@tromey.com>
3873
3874         * registry.h (DECLARE_REGISTRY): Define the _key class.
3875
3876 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * NEWS: Merge two 'New commands' sections.
3879
3880 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3881
3882         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3883         parameter and use Ada language definition instead.
3884         (ada_val_print_ptr): Remove unused language parameter.
3885         (ada_val_print_num): Remove language parameter and use Ada language
3886         definition instead.
3887         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3888         parameter.
3889         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3890         parameter and use Ada language definition instead.
3891         (ada_val_print_1): Update all ada_val_print_xxx calls.
3892         Remove language parameter.
3893         (ada_val_print): Update ada_val_print_1 call.
3894
3895 2019-05-08  Tom Tromey  <tromey@adacore.com>
3896
3897         * remote.c (remote_hw_watchpoint_limit)
3898         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3899         Now static.
3900
3901 2019-05-08  Tom Tromey  <tromey@adacore.com>
3902
3903         * maint.c (_initialize_maint_cmds): Move initialization code to
3904         remote.c.
3905         (watchdog, show_watchdog): Move to remote.c.
3906         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3907         "watchdog" static.
3908         (_initialize_remote): Move initialization code from maint.c.
3909         * defs.h (watchdog): Don't declare.
3910
3911 2019-05-08  Tom Tromey  <tromey@adacore.com>
3912
3913         * tui/tui-interp.c: Include main.h.
3914         * interps.c: Include main.h.
3915         * main.h (interpreter_p): Declare.
3916         * defs.h (interpreter_p): Don't declare.
3917
3918 2019-05-08  Tom Tromey  <tromey@adacore.com>
3919
3920         * dwarf2loc.c: Include dwarf2read.h.
3921         * defs.h (read_unsigned_leb128): Don't declare.
3922         * dwarf2read.h (read_unsigned_leb128): Declare.
3923
3924 2019-05-08  Tom Tromey  <tromey@adacore.com>
3925
3926         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3927         method.
3928
3929 2019-05-08  Tom Tromey  <tromey@adacore.com>
3930
3931         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3932         when no wrap column is set.
3933
3934 2019-05-08  Tom Tromey  <tromey@adacore.com>
3935
3936         * c-lang.c (c_get_string): Handle non-C-style arrays.
3937
3938 2019-05-08  Tom Tromey  <tromey@adacore.com>
3939
3940         * typeprint.c (print_offset_data::update): Print the bit offset,
3941         not the number of bits remaining.
3942
3943 2019-05-08  Tom Tromey  <tromey@adacore.com>
3944
3945         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3946         padding at end of comment.
3947
3948 2019-05-08  Tom Tromey  <tromey@adacore.com>
3949
3950         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3951         Compare main types.
3952
3953 2019-05-06  Tom Tromey  <tom@tromey.com>
3954
3955         * common/scoped_mmap.c: Include common-defs.h.
3956         * common/scoped_mmap.h: Don't include config.h.
3957
3958 2019-05-04  Tom Tromey  <tom@tromey.com>
3959
3960         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3961         (struct aarch64_call_info): Add initializers.
3962         <si>: Now a std::vector.
3963         (pass_on_stack, aarch64_push_dummy_call): Update.
3964
3965 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3966             Tom Tromey  <tom@tromey.com>
3967
3968         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3969         (ppc_threads): Now a std::vector.  Now static.
3970         (hwdebug_find_thread_points_by_tid)
3971         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3972         Update.
3973
3974 2019-05-04  Tom Tromey  <tom@tromey.com>
3975
3976         * arc-tdep.c (arc_tdesc_init): Return bool.
3977
3978 2019-05-04  Tom Tromey  <tom@tromey.com>
3979
3980         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3981         Use gdb_assert_not_reached.
3982
3983 2019-05-04  Tom Tromey  <tom@tromey.com>
3984
3985         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3986         "false".
3987
3988 2019-05-04  Tom Tromey  <tom@tromey.com>
3989
3990         * arc-tdep.c (arc_tdesc_init): Use bool.
3991
3992 2019-05-04  Tom Tromey  <tom@tromey.com>
3993
3994         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3995
3996 2019-05-04  Tom Tromey  <tom@tromey.com>
3997
3998         * cli/cli-cmds.c (valid_command_p): Return bool.
3999
4000 2019-05-04  Tom Tromey  <tom@tromey.com>
4001
4002         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4003         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4004
4005 2019-05-04  Raul Tambre  <raul@tambre.ee>
4006
4007         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4008         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4009         operator for comparison.
4010
4011 2019-05-04  Tom Tromey  <tom@tromey.com>
4012
4013         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4014         (lookup_partial_symbol, print_partial_symbols)
4015         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4016         (psymbol_compare): Update.
4017         (add_psymbol_to_bcache): Clear the entire psymbol.
4018         (maintenance_check_psymtabs): Update.
4019         * psympriv.h (struct partial_symbol): Don't derive from
4020         general_symbol_info.
4021         <obj_section, unrelocated_address, address,
4022         set_unrelocated_address>: Update.
4023         <ginfo>: New member.
4024         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4025         (debug_names::write_psymbols): Update.
4026
4027 2019-05-04  Tom de Vries  <tdevries@suse.de>
4028
4029         * contrib/cc-with-tweaks.sh: Support -n arg.
4030
4031 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4032
4033         * corelow.c (core_target::detach): Ensure frame cache and
4034         register caches are cleared.
4035         inferior.c (exit_inferior_1): Likewise.
4036
4037 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4038             Tom Tromey  <tom@tromey.com>
4039
4040         * dictionary.c (collate_pending_symbols_by_language): Remove
4041         "struct" from foreach.
4042         * symtab.c (lookup_global_symbol_from_objfile)
4043         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4044         foreach.
4045         * ser-tcp.c (net_open): Remove "struct" from foreach.
4046         * objfiles.c (objfile_relocate, objfile_rebase)
4047         (objfile_has_symbols): Remove "struct" from foreach.
4048         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4049         from foreach.
4050         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4051         foreach.
4052         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4053         "struct" from foreach.
4054         * ada-lang.c (create_excep_cond_exprs)
4055         (ada_exception_catchpoint_cond_string): Remove "struct" from
4056         foreach.
4057
4058 2019-05-03  Tom Tromey  <tromey@adacore.com>
4059
4060         * ada-exp.y (convert_char_literal): Check suffix of each
4061         enumerator.
4062
4063 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4064
4065         PR ada/21406:
4066         * ada-exp.y (yywrap): Don't define.
4067         * ada-lex.l (%option): Add noyywrap
4068         (yywrap): Remove.
4069
4070 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4071
4072         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4073         _WIN32_WINNT to the XP level, unless already defined to a higher
4074         level.
4075
4076         * unittests/parse-connection-spec-selftests.c:
4077         * ser-tcp.c:
4078         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4079         override.
4080
4081         * symfile.c (find_separate_debug_file): Remove colon from the
4082         drive spec of DOS/Windows file names of the target, so that the
4083         file name produced from DEBUGDIR and the target's directory will
4084         be valid on DOS/Windows systems.
4085
4086 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4087
4088         * rust-lang.c (val_print_struct): Handle printing structures
4089         containing strings.
4090
4091 2019-05-02  Tom Tromey  <tromey@adacore.com>
4092
4093         * valarith.c (_initialize_valarith): Remove.
4094
4095 2019-05-01  Tom Tromey  <tromey@adacore.com>
4096
4097         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4098         bitfields.
4099
4100 2019-05-01  Tom Tromey  <tromey@adacore.com>
4101
4102         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4103         for big-endian copies.
4104
4105 2019-04-30  Ali Tamur  <tamur@google.com>
4106         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4107         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4108         (read_3_bytes): New function.
4109
4110 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4111
4112         * windows-nat.c (main_thread_id): Delete.
4113         (handle_output_debug_string): Replace main_thread_id by
4114         current_event.dwThreadId.
4115         (fake_create_process): Likewise.
4116         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4117         Do not set main_thread_id.
4118         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4119         current_event.dwThreadId.
4120         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4121
4122 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4123
4124         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4125         Use current_event.dwThreadId instead of main_thread_id.
4126
4127 2019-04-30  Tom Tromey  <tromey@adacore.com>
4128
4129         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4130         (create_excep_cond_exprs): Iterate over program spaces.
4131         (ada_exception_catchpoint_cond_string): Examine all minimal
4132         symbols for exception types.
4133
4134 2019-04-30  Tom Tromey  <tromey@adacore.com>
4135
4136         PR c++/24470:
4137         * dwarf2read.c (process_structure_scope): Handle case where type
4138         has template parameters but no symbol was created.
4139
4140 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4141             Chris January  <chris.january@arm.com>
4142
4143         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4144         qualifier.
4145         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4146
4147 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4148
4149         * f-typeprint.c (f_print_type): Update rules for printing
4150         whitespace.
4151         (f_type_print_varspec_suffix): Likewise.
4152
4153 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4154             Chris January  <chris.january@arm.com>
4155
4156         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4157         function arguments.
4158
4159 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4160
4161         * f-lang.c (build_fortran_types): Change name of void type to
4162         lower case.
4163         * f-typeprint.c (f_type_print_base): Print the name of the void
4164         type, rather than a fixed string.
4165         * f-valprint.c (f_decorations): Use lower case void string.
4166
4167 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4168             Chris January  <chris.january@arm.com>
4169
4170         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4171         types for Fortran.
4172
4173 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4174             Chris January  <chris.january@arm.com>
4175             David Lecomber  <david.lecomber@arm.com>
4176
4177         * f-exp.y (BINOP_INTRINSIC): New token.
4178         (exp): New parser rule handling BINOP_INTRINSIC.
4179         (f77_keywords): Add new builtin procedures.
4180         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4181         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4182         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4183         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4184         (print_unop_subexp_f): New function.
4185         (print_binop_subexp_f): New function.
4186         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4187         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4188         (dump_subexp_body_f): Likewise.
4189         (operator_check_f): Likewise.
4190         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4191         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4192
4193 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4194
4195         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4196         UNOP_KIND.
4197         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4198         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4199         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4200         (operator_length_f): New fuction.
4201         (print_subexp_f): New function.
4202         (op_name_f): New function.
4203         (dump_subexp_body_f): New function.
4204         (operator_check_f): New function.
4205         (exp_descriptor_f): Replace standard expression handling functions
4206         with new functions.
4207         * gdb/fortran-operator.def: New file.
4208         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4209         * gdb/std-operator.def: Remove UNOP_KIND.
4210
4211 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4212
4213         * std-operator.def: Remove unbalanced, stray double quote
4214         character.
4215
4216 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4217             Chris January  <chris.january@arm.com>
4218             Daniel Everett  <daniel.everett@arm.com>
4219             Nick Forrington  <nick.forrington@arm.com>
4220             Richard Bunt  <richard.bunt@arm.com>
4221
4222         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4223         of depth when printing anonymous structs or unions.
4224         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4225         Don't print either the top-level value, or the children if the
4226         max-depth is exceeded.
4227         (ppscm_print_children): When printing the key of a map, allow one
4228         extra level of depth.
4229         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4230         print either the top-level value, or the children if the max-depth
4231         is exceeded.
4232         (print_children): When printing the key of a map, allow one extra
4233         level of depth.
4234         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4235         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4236         (user_print_options): Initialise max_depth field.
4237         (val_print_scalar_or_string_type_p): New function.
4238         (val_print): Check to see if the max depth has been reached.
4239         (val_print_check_max_depth): Define new function.
4240         (show_print_max_depth): New function.
4241         (_initialize_valprint): Add 'print max-depth' option.
4242         * valprint.h (struct value_print_options) <max_depth>: New field.
4243         (val_print_check_max_depth): Declare new function.
4244         * NEWS: Document new feature.
4245
4246 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * ada-lang.c (ada_language_defn): Initialise new field.
4249         * c-lang.c (c_is_string_type_p): New function.
4250         (c_language_defn): Initialise new field.
4251         (cplus_language_defn): Initialise new field.
4252         (asm_language_defn): Initialise new field.
4253         (minimal_language_defn): Initialise new field.
4254         * c-lang.h (c_is_string_type_p): Declare new function.
4255         * d-lang.c (d_language_defn): Initialise new field.
4256         * f-lang.c (f_is_string_type_p): New function.
4257         (f_language_defn): Initialise new field.
4258         * go-lang.c (go_is_string_type_p): New function.
4259         (go_language_defn): Initialise new field.
4260         * language.c (default_is_string_type_p): New function.
4261         (unknown_language_defn): Initialise new field.
4262         (auto_language_defn): Initialise new field.
4263         * language.h (struct language_defn) <la_is_string_type_p>: New
4264         member variable.
4265         (default_is_string_type_p): Declare new function.
4266         * m2-lang.c (m2_language_defn): Initialise new field.
4267         * objc-lang.c (objc_language_defn): Initialise new field.
4268         * opencl-lang.c (opencl_language_defn): Initialise new field.
4269         * p-lang.c (pascal_is_string_type_p): New function.
4270         (pascal_language_defn): Initialise new field.
4271         * rust-lang.c (rust_is_string_type_p): New function.
4272         (rust_language_defn): Initialise new field.
4273
4274 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4275
4276         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4277         New field.
4278         * ada-lang.c (ada_language_defn): Initialise new field.
4279         * c-lang.c (c_language_defn): Likewise.
4280         (cplus_language_defn): Likewise.
4281         (asm_language_defn): Likewise.
4282         (minimal_language_defn): Likewise.
4283         * d-lang.c (d_language_defn): Likewise.
4284         * f-lang.c (f_language_defn): Likewise.
4285         * go-lang.c (go_language_defn): Likewise.
4286         * language.c (unknown_language_defn): Likewise.
4287         (auto_language_defn): Likewise.
4288         * m2-lang.c (m2_language_defn): Likewise.
4289         * objc-lang.c (objc_language_defn): Likewise.
4290         * opencl-lang.c (opencl_language_defn): Likewise.
4291         * p-lang.c (pascal_language_defn): Likewise.
4292         * rust-lang.c (rust_language_defn): Likewise.
4293
4294 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4295
4296         * ada-lang.c (ada_is_character_type): Change return type to bool.
4297         (ada_is_string_type): Likewise.
4298         * ada-lang.h (ada_is_character_type): Update declaration
4299         (ada_is_string_type): Likewise.
4300
4301 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4302
4303         Support style in 'frame|thread apply'
4304
4305         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4306         * record.c (record_start, record_stop): Update callers of
4307         execute_command_to_string with false.
4308         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4309         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4310         methods.
4311         (class string_file): New constructor with term_out parameter.
4312         Override methods term_out and can_emit_style_escape.  New member
4313         term_out.
4314         (class stdio_file): Override can_emit_style_escape.
4315         (class tee_file): Override term_out and can_emit_style_escape.
4316         * utils.h (can_emit_style_escape): Remove.
4317         * utils.c (can_emit_style_escape): Likewise.
4318         Update all callers of can_emit_style_escape (SOMESTREAM) to
4319         SOMESTREAM->can_emit_style_escape.
4320         * source-cache.c (source_cache::get_source_lines): Likewise.
4321         * stack.c (frame_apply_command_count): Call execute_command_to_string
4322         passing the term_out characteristic of the current gdb_stdout.
4323         * thread.c (thr_try_catch_cmd): Likewise.
4324         * top.c (execute_command_to_string): pass term_out parameter
4325         to construct the string_file for the command output.
4326         * ui-file.c (term_cli_styling): New function (most code moved
4327         from utils.c can_emit_style_escape).
4328         (string_file::string_file, string_file::can_emit_style_escape,
4329         stdio_file::can_emit_style_escape, tee_file::term_out,
4330         tee_file::can_emit_style_escape): New functions.
4331
4332 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4333
4334         * NEWS: Mention the new set|show may-call-functions.
4335         * infcall.c (may_call_functions_p): New variable.
4336         (show_may_call_functions_p): New function.
4337         (call_function_by_hand_dummy): Throws an error if not
4338         may-call-functions.
4339         (_initialize_infcall): Call add_setshow_boolean_cmd for
4340         may-call-functions.
4341
4342 2019-04-25  Keith Seitz  <keiths@redhat.com>
4343
4344         PR c++/24367
4345         * cp-support.c (inspect_type): Don't attempt substitutions
4346         of symbol with the same name.
4347
4348 2019-04-25  Tom Tromey  <tromey@adacore.com>
4349
4350         PR gdb/24475:
4351         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4352         static.
4353
4354 2019-04-25  Tom Tromey  <tromey@adacore.com>
4355
4356         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4357         rvalue reference.
4358         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4359         (gdb_xml_parser::parse): Use std::move.
4360         * python/python-internal.h (gdbpy_convert_exception): Take a const
4361         reference.
4362         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4363         std::move.
4364         * python/py-utils.c (gdbpy_convert_exception): Take a const
4365         reference.
4366         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4367         Use std::move.
4368         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4369         Use std::move.
4370         * mi/mi-main.c (mi_print_exception): Take a const reference.
4371         * main.c (handle_command_errors): Take a const reference.
4372         * linespec.c (parse_linespec): Use std::move.
4373         * infcall.c (run_inferior_call): Use std::move.
4374         (call_function_by_hand_dummy): Use std::move.
4375         * exec.c (try_open_exec_file): Use std::move.
4376         * exceptions.h (exception_print, exception_fprintf)
4377         (exception_print_same): Update.
4378         * exceptions.c (print_exception, exception_print)
4379         (exception_fprintf, exception_print_same): Change parameters to
4380         const reference.
4381         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4382         * common/new-op.c: Use std::move.
4383         * common/common-exceptions.h (struct gdb_exception): Add move
4384         constructor.
4385         (struct gdb_exception_error, struct gdb_exception_quit, struct
4386         gdb_quit_bad_alloc): Change constructor to move constructor.
4387         (throw_exception): Change parameter to rvalue reference.
4388         * common/common-exceptions.c (throw_exception): Take rvalue
4389         reference.
4390         * cli/cli-interp.c (safe_execute_command): Use std::move.
4391         * breakpoint.c (insert_bp_location, location_to_sals): Use
4392         std::move.
4393
4394 2019-04-25  Tom Tromey  <tromey@adacore.com>
4395
4396         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4397         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4398         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4399         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4400         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4401         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4402         guile/scm-value.c: Use unpack.
4403         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4404         gdbscm_gdb_exception.
4405         (gdbscm_throw_gdb_exception): Likewise.
4406         (struct gdbscm_gdb_exception): New.
4407         (unpack): New function.
4408         (gdbscm_wrap): Use unpack.
4409
4410 2019-04-25  Tom Tromey  <tromey@adacore.com>
4411
4412         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4413         (gdb_rl_callback_handler): Use std::move.
4414         * common/common-exceptions.h (struct gdb_exception): Add move
4415         assignment operator.
4416         (throw_exception_sjlj): Change "exception" to const reference.
4417         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4418         (throw_exception_sjlj): Change "exception" to const reference.
4419
4420 2019-04-25  Tom Tromey  <tromey@adacore.com>
4421
4422         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4423         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4424         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4425         Update.
4426         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4427         Update.
4428         * mi/mi-interp.c (mi_interp::exec): Update.
4429         * linespec.c (parse_linespec): Update.
4430         * infcall.c (run_inferior_call): Update.
4431         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4432         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4433         (gdbscm_lookup_global_symbol): Update.
4434         * guile/scm-param.c (gdbscm_parameter_value): Update.
4435         * guile/scm-frame.c (gdbscm_frame_read_register)
4436         (gdbscm_frame_read_var): Update.
4437         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4438         * exec.c (try_open_exec_file): Update.
4439         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4440         (gdb_rl_callback_handler): Update.
4441         * common/common-exceptions.h (exception_none): Don't declare.
4442         * common/common-exceptions.c (exception_none): Don't define.
4443         (struct catcher) <exception>: Update.
4444         * cli/cli-interp.c (safe_execute_command): Update.
4445         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4446
4447 2019-04-25  Ali Tamur  <tamur@google.com>
4448
4449         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4450         (read_attribute_value): Likewise.
4451         (dwarf2_read_addr_index): Update comment.
4452         (read_str_index): Add DW_FORM_strx.
4453         (dwarf2_string_attr): Likewise.
4454         (dwarf2_const_value_attr): Likewise.
4455         (dump_die_shallow): Likewise.
4456         (dwarf2_fetch_constant_bytes): Likewise.
4457         (skip_form_bytes): Likewise.
4458         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4459
4460 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4461
4462         PR corefiles/11608
4463         PR corefiles/18187
4464         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4465         OFFSET.  Verify if current mapping contains an ELF header.
4466         (linux_find_memory_regions_full): Adjust call to
4467         dump_mapping_p.
4468
4469 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4470             Kang Li <kanglictf@gmail.com>
4471
4472         PR gdb/21600
4473
4474         * dwarf2-frame.c (read_initial_length): Be consistent about using
4475         unsigned representation of length.
4476         (decode_frame_entry_1): Likewise.  Check for wraparound of
4477         end pointer as well as buffer overflow.
4478
4479 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4480
4481         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4482         "vq".
4483
4484 2019-04-24  Tom Tromey  <tromey@adacore.com>
4485
4486         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4487
4488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4489
4490         * s12z-tdep.c (s12z_unwind_pc): Delete.
4491         (s12z_unwind_sp): Delete.
4492         (s12z_gdbarch_init): Don't register deleted functions with
4493         gdbarch.
4494
4495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4496
4497         * rl78-tdep.c (rl78_unwind_sp): Delete.
4498         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4499
4500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4501
4502         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4503         (xstormy16_unwind_pc): Delete.
4504         (xstormy16_dummy_id): Delete.
4505         (xstormy16_gdbarch_init): Don't register deleted functions with
4506         gdbarch.
4507
4508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4509
4510         * vax-tdep.c (vax_unwind_pc): Delete.
4511         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4512
4513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4514
4515         * v850-tdep.c (v850_unwind_sp): Delete.
4516         (v850_unwind_pc): Delete.
4517         (v850_dummy_id): Delete.
4518         (v850_gdbarch_init): Don't register deleted functions with
4519         gdbarch.
4520
4521 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4524         (tilegx_unwind_pc): Delete.
4525         (tilegx_unwind_dummy_id): Delete.
4526         (tilegx_gdbarch_init): Don't register deleted functions with
4527         gdbarch.
4528
4529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4532         (tic6x_dummy_id): Delete.
4533         (tic6x_gdbarch_init): Don't register deleted functions with
4534         gdbarch.
4535
4536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4537
4538         * sparc-tdep.c (sparc_unwind_pc): Delete.
4539         (sparc32_gdbarch_init): Don't register deleted function with
4540         gdbarch.
4541
4542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4543
4544         * sh-tdep.c (sh_unwind_sp): Delete.
4545         (sh_unwind_pc): Delete.
4546         (sh_dummy_id): Delete.
4547         (sh_gdbarch_init): Don't register deleted functions with
4548         gdbarch.
4549
4550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4551
4552         * score-tdep.c (score_unwind_sp): Delete.
4553         (score_unwind_pc): Delete.
4554         (score_dummy_id): Delete.
4555         (score_gdbarch_init): Don't register deleted functions with
4556         gdbarch.
4557
4558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4559
4560         * rx-tdep.c (rx_unwind_pc): Delete.
4561         (rx_unwind_sp): Delete.
4562         (rx_dummy_id): Delete.
4563         (rx_gdbarch_init): Don't register deleted functions with
4564         gdbarch.  Update comment.
4565
4566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4569         (rs6000_dummy_id): Delete.
4570         (rs6000_gdbarch_init): Don't register deleted functions with
4571         gdbarch.
4572
4573 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4574
4575         * or1k-tdep.c (or1k_dummy_id): Delete.
4576         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4577
4578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4579
4580         * nios2-tdep.c (nios2_dummy_id): Delete.
4581         (nios2_unwind_sp): Delete.
4582         (nios2_gdbarch_init): Don't register deleted functions with
4583         gdbarch.
4584
4585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * nds32-tdep.c (nds32_dummy_id): Delete.
4588         (nds32_unwind_pc): Delete.
4589         (nds32_unwind_sp): Delete.
4590         (nds32_gdbarch_init): Don't register deleted functions with
4591         gdbarch.
4592
4593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * msp430-tdep.c (msp430_unwind_pc): Delete.
4596         (msp430_unwind_sp): Delete.
4597         (msp430_dummy_id): Delete.
4598         (msp430_gdbarch_init): Don't register deleted functions with
4599         gdbarch.
4600
4601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4602
4603         * moxie-tdep.c (moxie_unwind_sp): Delete.
4604         (moxie_unwind_pc): Delete.
4605         (moxie_dummy_id): Delete.
4606         (moxie_gdbarch_init): Don't register deleted functions with
4607         gdbarch.
4608
4609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4610
4611         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4612         (mn10300_unwind_pc): Delete.
4613         (mn10300_unwind_sp): Delete.
4614         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4615         mn10300_unwind_sp.
4616         (mn10300_frame_unwind_init): Don't register deleted functions with
4617         gdbarch.
4618
4619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4620
4621         * mep-tdep.c (mep_unwind_pc): Delete.
4622         (mep_unwind_sp): Delete.
4623         (mep_dummy_id): Delete.
4624         (mep_gdbarch_init): Don't register deleted functions with
4625         gdbarch.
4626
4627 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4628
4629         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4630         (m68hc11_unwind_sp): Delete.
4631         (m68hc11_gdbarch_init): Don't register deleted functions with
4632         gdbarch.
4633
4634 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4635
4636         * m32r-tdep.c (m32r_unwind_sp): Delete.
4637         (m32r_unwind_pc): Delete.
4638         (m32r_dummy_id): Delete.
4639         (m32r_gdbarch_init): Don't register deleted functions with
4640         gdbarch.
4641
4642 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4643
4644         * m32c-tdep.c (m32c_unwind_pc): Delete.
4645         (m32c_unwind_sp): Delete.
4646         (m32c_dummy_id): Delete.
4647         (m32c_gdbarch_init): Don't register deleted functions with
4648         gdbarch.
4649
4650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4651
4652         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4653         (lm32_unwind_pc): Delete.
4654         (lm32_dummy_id): Delete.
4655         (lm32_gdbarch_init): Don't register deleted functions with
4656         gdbarch.
4657
4658 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4659
4660         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4661         (iq2000_unwind_pc): Delete.
4662         (iq2000_dummy_id): Delete.
4663         (iq2000_gdbarch_init): Don't register deleted functions with
4664         gdbarch.
4665
4666 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4667
4668         * nds32-tdep.c (nds32_type_align): Delete.
4669         (nds32_push_dummy_call): Use type_align instead.
4670
4671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4672
4673         * arm-tdep.c (arm_type_align): Only handle vector override case.
4674         (arm_push_dummy_call): Use type_align.
4675         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4676
4677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4678
4679         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4680         case.
4681         (pass_on_stack): Use type_align.
4682         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4683         function.
4684
4685 2019-04-23  Tom Tromey  <tromey@adacore.com>
4686
4687         * dwarf2read.c (line_header::file_name_at): Remove unused
4688         overload.
4689
4690 2019-04-23  Tom de Vries  <tdevries@suse.de>
4691
4692         PR gdb/24438
4693         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4694         invocation.
4695
4696
4697 2019-03-27  Ali Tamur  <tamur@google.com>
4698
4699         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4700         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4701         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4702         (dwarf_expr_context::get_addr_index): Likewise
4703         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4704         (symbol_needs_eval_context::get_addr_index): Likewise
4705         (disassemble_dwarf_expression): Add DW_OP_addrx
4706         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4707         (read_cutu_die_from_dwo): Update comment
4708         (skip_one_die): Add DW_FORM_addrx
4709         (read_attribute_value): Likewise
4710         (var_decode_location): Add DW_OP_addrx
4711         (dwarf2_const_value_attr): Add DW_FORM_addrx
4712         (dump_die_shallow): Likewise
4713         (dwarf2_fetch_constant_bytes): Likewise
4714         (decode_locdesc): Add DW_OP_addrx
4715         (skip_form_bytes): Add DW_FORM_addrx
4716
4717 2019-04-22  Ali Tamur  <tamur@google.com>
4718
4719         * MAINTAINERS (Write After Approval): Add self.
4720
4721 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4722
4723         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4724         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4725         (open_symbol_file_object): Likewise.
4726         (svr4_default_sos): Add info parameter.
4727         (svr4_read_so_list): Likewise.
4728         (svr4_current_sos_direct): Adjust functions calls to pass down
4729         info.
4730         (svr4_current_sos_1): Add info parameter.
4731         (svr4_current_sos): Call get_svr4_info, pass info down to
4732         svr4_current_sos_1.
4733         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4734         get_svr4_info.
4735         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4736         get_svr4_info.
4737         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4738         to get_svr4_info.
4739         (probes_table_remove_objfile_probes): Likewise.
4740         (register_solib_event_probe): Add info parameter.
4741         (solist_update_incremental): Pass info parameter down to
4742         svr4_read_so_list.
4743         (disable_probes_interface): Add info parameter.
4744         (svr4_handle_solib_event): Pass current_program_space to
4745         get_svr4_info.  Adjust disable_probes_interface cleanup.
4746         (svr4_create_probe_breakpoints): Add info parameter, pass it
4747         down to register_solib_event_probe.
4748         (svr4_create_solib_event_breakpoints): Add info parameter,
4749         pass it down to svr4_create_probe_breakpoints.
4750         (enable_break): Pass info down to
4751         svr4_create_solib_event_breakpoints.
4752         (svr4_solib_create_inferior_hook): Pass current_program_space to
4753         get_svr4_info.
4754         (svr4_clear_solib): Likewise.
4755
4756 2019-04-22  Pedro Alves  <palves@redhat.com>
4757
4758         * solib-svr4.c (svr4_free_objfile_observer): New.
4759         (probe_and_action::objfile): New field.
4760         (probes_table_htab_remove_objfile_probes)
4761         (probes_table_remove_objfile_probes): New functions.
4762         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4763         in the new probe_and_action.  Don't store the probe in 'lookup'.
4764         (svr4_create_probe_breakpoints): Pass objfile to
4765         register_solib_event_probe.
4766         (_initialize_svr4_solib): Register a free_objfile observer.
4767
4768 2019-04-19  Tom Tromey  <tom@tromey.com>
4769
4770         * common/queue.h: Remove.
4771
4772 2019-04-19  Tom Tromey  <tom@tromey.com>
4773
4774         * event-loop.c: Don't include "common/queue.h".
4775
4776 2019-04-19  Tom Tromey  <tom@tromey.com>
4777
4778         * remote.c (remote_target): Use delete.
4779         * remote-notif.h: Include <list>, not "common/queue.h".
4780         (notif_client_p): Remove typedef.
4781         (remote_notif_state): Add constructor, destructor, initializer.
4782         <notif_queue>: Now a std::list.
4783         (remote_notif_state_xfree): Don't declare.
4784         * remote-notif.c (remote_notif_process, handle_notification)
4785         (remote_notif_state_allocate): Update.
4786         (~remote_notif_state): Rename from remote_notif_state_xfree.
4787
4788 2019-04-19  Tom Tromey  <tom@tromey.com>
4789
4790         * symfile.c (reread_symbols): Update.
4791         * objfiles.c (objfile_register_static_link)
4792         (objfile_lookup_static_link): Update
4793         (~objfile) Don't delete static_links.
4794         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4795
4796 2019-04-19  Tom Tromey  <tom@tromey.com>
4797
4798         * type-stack.h (struct type_stack) <insert>: Constify string.
4799         * type-stack.c (type_stack::insert): Constify string.
4800         * gdbtypes.h (lookup_template_type): Update.
4801         (address_space_name_to_int): Update.
4802         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4803         const.
4804         (lookup_template_type): Make name const.
4805         * c-exp.y: Update rules.
4806         (lex_one_token, classify_name, classify_inner_name)
4807         (c_print_token): Update.
4808         * p-exp.y: Update rules.
4809         (yylex): Update.
4810         * f-exp.y: Update rules.
4811         (yylex): Update.
4812         * d-exp.y: Update rules.
4813         (lex_one_token, classify_name, classify_inner_name): Update.
4814         * parse.c (write_dollar_variable, copy_name): Return std::string.
4815         * parser-defs.h (copy_name): Change return type.
4816         * m2-exp.y: Update rules.
4817         (yylex): Update.
4818         * go-exp.y (lex_one_token): Update.
4819         Update rules.
4820         (classify_unsafe_function, classify_packaged_name)
4821         (classify_name, yylex): Update.
4822
4823 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4824
4825         * configure.ac: add --enable-source-highlight switch.
4826         * configure: Regenerate.
4827         * top.c (print_gdb_version): plumb --enable-source-highlight
4828         status to "show configuration".
4829
4830 2019-04-19  Tom Tromey  <tromey@adacore.com>
4831
4832         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4833         Check ADA_TYPE_P.
4834         (empty_record, ada_template_to_fixed_record_type_1)
4835         (template_to_static_fixed_type)
4836         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4837         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4838         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4839         macros.
4840
4841 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4842
4843         PR symtab/24423:
4844         * source.c (print_source_lines_base): Advance "iter" when a
4845         control character is seen.
4846
4847 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4848
4849         * inferior.h (struct infcall_suspend_state_deleter):
4850         Catch exception in destructor to avoid crash.
4851
4852 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4853
4854         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4855         close to the add_com "shell".
4856
4857 2019-04-18  Tom Tromey  <tromey@adacore.com>
4858
4859         * process-stratum-target.h (class process_stratum_target)
4860         <stratum>: Add "final".
4861
4862 2019-04-17  Tom Tromey  <tromey@adacore.com>
4863
4864         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4865         against nullptr before use.
4866
4867 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4868
4869         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4870
4871 2019-04-17  Jim Wilson  <jimw@sifive.com>
4872             Andrew Burgess  <andrew.burgess@embecosm.com>
4873
4874         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4875         code read might fail, assume 4-byte breakpoint in that case.
4876
4877 2019-04-15  Leszek Swirski  <leszeks@google.com>
4878
4879         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4880         rather than a hand-rolled POD check when checking for forced MEMORY
4881         classification.
4882
4883 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4884
4885         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4886         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4887         function.
4888         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4889         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4890         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4891         declaration.
4892
4893 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4894
4895         * aarch64-linux-nat.c
4896         (aarch64_linux_nat_target::thread_architecture): Add override.
4897         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4898         each VQ.
4899
4900 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4901
4902         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4903
4904 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4905
4906         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4907         target types of size 96-bits, add some additional comments, and
4908         check that the builtin type we found was the correct size.
4909
4910 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4911
4912         * utils.c (prompt_for_continue): Don't restore the styling at the
4913         end, as applied_style has the wrong value.  This fixes styling in
4914         long lists of file names that are interrupted by the "Continue?"
4915         prompt.
4916
4917 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4918
4919         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4920         * c-lang.c (c_language_defn): Likewise.
4921         (cplus_language_defn): Likewise.
4922         (asm_language_defn): Likewise.
4923         (minimal_language_defn): Likewise.
4924         * d-lang.c (d_language_defn): Likewise.
4925         * f-lang.c (f_language_defn): Likewise.
4926         * go-lang.c (go_language_defn): Likewise.
4927         * language.c (unknown_language_defn): Likewise.
4928         (auto_language_defn): Likewise.
4929         * language.h (struct language_defn): Remove la_magic field.
4930         (LANG_MAGIC): Delete.
4931         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4932         * objc-lang.c (objc_language_defn): Likewise.
4933         * opencl-lang.c (opencl_language_defn): Likewise.
4934         * p-lang.c (pascal_language_defn): Likewise.
4935         * rust-lang.c (rust_language_defn): Likewise.
4936
4937 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4938
4939         * riscv-tdep.c (riscv_type_align): New function.
4940         (riscv_type_alignment): Delete.
4941         (riscv_arg_location): Use 'type_align'.
4942         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4943
4944 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4945
4946         * gdbtypes.c (type_align): A struct with no non-static fields also
4947         has alignment of 1.
4948
4949 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4950
4951         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4952         component to 0.
4953         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4954         member.
4955         (riscv_struct_info::analyse): New implementation using new
4956         analyse_inner member function.
4957         (riscv_struct_info::field_offset): New member function.
4958         (riscv_struct_info::m_offsets): New member variable.
4959         (riscv_struct_info::analyse_inner): New private member function,
4960         takes the old implementation of riscv_struct_info::analyse but
4961         extended to track field offsets.
4962         (riscv_call_arg_struct): Update the struct folding special cases
4963         to handle cases where empty C++ structs, which are non-zero
4964         length, are found.
4965         (riscv_arg_location): Initialise the length of each location, a
4966         non-zero length now indicates the location is in use.
4967         (riscv_push_dummy_call): Allow for the first location having a
4968         non-zero offset when setting up arguments.
4969         (riscv_return_value): Likewise, but for return values.
4970
4971 2019-04-11  Tom Tromey  <tromey@adacore.com>
4972
4973         * utils.c (internal_vproblem): Make "msg" const.
4974
4975 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4976
4977         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4978         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4979         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4980         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4981
4982 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4983
4984         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4985         function.
4986         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4987         of amd64_collect_native_gregset.
4988         (amd64_linux_nat_target::store_registers): Likewise.
4989
4990 2019-04-10  Tom Tromey  <tom@tromey.com>
4991
4992         * symtab.c (lookup_global_symbol_from_objfile)
4993         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4994         * objfiles.h (class separate_debug_iterator): New.
4995         (class separate_debug_range): New.
4996         (struct objfile) <separate_debug_objfiles>: New method.
4997         (objfile_separate_debug_iterate): Don't declare.
4998         * objfiles.c (separate_debug_iterator::operator++): Rename from
4999         objfile_separate_debug_iterate.
5000         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5001         iterator.
5002         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5003         iterator.
5004
5005 2019-04-10  Tom Tromey  <tom@tromey.com>
5006
5007         * symfile.c (reread_symbols): Remove old comment.
5008         * objfiles.c (free_all_objfiles): Fix a typo.
5009
5010 2019-04-10  Tom Tromey  <tom@tromey.com>
5011
5012         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5013         * minsyms.c (lookup_minimal_symbol): Use foreach.
5014         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5015         (lookup_minimal_symbol_solib_trampoline): Likewise.
5016         * symfile.c (reread_symbols): Use foreach.
5017
5018 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5019             Tom Tromey  <tromey@adacore.com>
5020
5021         PR rust/24414:
5022         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5023         (rust_lex_int_test): Change "value" to be LONGEST.
5024         (rust_lex_tests): Add test for long integer literal.
5025
5026 2019-04-09  Tom Tromey  <tromey@adacore.com>
5027
5028         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5029         to bool.
5030         (extended_remote_target::attach): Update.
5031         (remote_target::remote_notice_new_inferior): Update.
5032         (remote_target::add_current_inferior_and_thread): Update.
5033         * inferior.c (exit_inferior_1): Use "false".
5034         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5035
5036 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5037
5038         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5039         the "start" command.
5040
5041 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5042
5043         * python/py-inferior.c (infpy_thread_from_thread_handle):
5044         Adjust comments to reflect renaming of thread_from_thread_handle
5045         to thread_from_handle.  Adjust keywords.  Fix type error message.
5046         (inferior_object_methods): Add thread_from_handle.  Retain
5047         thread_from_thread_handle, but mark it as deprecated.
5048
5049 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5050
5051         * gdbthread.h (find_thread_by_handle): Revise declaration.
5052         * thread.c (find_thread_by_handle): Likewise.  Adjust
5053         implementation too.
5054         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5055         support for buffer objects as handles.
5056
5057 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5058
5059         * python/py-infthread.c (thpy_thread_handle): New function.
5060         (thread_object_methods): Register thpy_thread_handle.
5061
5062 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5063
5064         * gdbthread.h (thread_to_thread_handle): Declare.
5065         * thread.c (gdbtypes.h): Include.
5066         (thread_to_thread_handle): New function.
5067
5068         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5069         (target_thread_info_to_thread_handle): Declare.
5070         * target.c (target_thread_info_to_thread_handle): New function.
5071         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5072         * target-delegates.c: Regenerate.
5073
5074         * linux-thread-db.c (class thread_db_target): Add method
5075         thread_info_to_thread_handle.
5076         (thread_db_target::thread_info_to_thread_handle): Define.
5077         * remote.c (class remote_target): Add new method
5078         thread_info_to_thread_handle.
5079         (remote_target::thread_info_to_thread_handle): Define.
5080
5081 2019-04-08  Pedro Alves  <palves@redhat.com>
5082
5083         * common/common-exceptions.c (throw_exception): Don't create
5084         named object to throw; throw directly.
5085         (throw_it): Likewise.  Don't initialize gdb_exception::message
5086         here, with new; pass FMT and AP to the ctor instead.
5087         * common/common-exceptions.h: Include <string>.
5088         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5089         const char *, va_list)): New ctor.  Use std::make_shared.
5090         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5091         errors)): Delete.
5092         (gdb_exception_error::gdb_exception_error(enum errors, const char
5093         *, va_list)): New.
5094         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5095         Add assertion.
5096         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5097         errors)): Delete.
5098         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5099         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5100         Add assertion.
5101
5102 2019-04-08  Tom Tromey  <tom@tromey.com>
5103
5104         * valops.c (value_rtti_indirect_type): Replace throw_exception
5105         with throw.
5106         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5107         with throw.
5108         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5109         throw.
5110         * target.c (target_translate_tls_address): Replace throw_exception
5111         with throw.
5112         * stack.c (frame_apply_command_count): Replace throw_exception
5113         with throw.
5114         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5115         throw.
5116         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5117         with throw.
5118         * rs6000-tdep.c (rs6000_frame_cache)
5119         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5120         * remote.c: Replace throw_exception with throw.
5121         * record-full.c (record_full_message, record_full_wait_1)
5122         (record_full_restore): Replace throw_exception with throw.
5123         * record-btrace.c:
5124         (get_thread_current_frame_id, record_btrace_start_replaying)
5125         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5126         (cmd_record_btrace_start): Replace throw_exception with throw.
5127         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5128         throw.
5129         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5130         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5131         * linespec.c:
5132         (find_linespec_symbols): Replace throw_exception with throw.
5133         * infrun.c (displaced_step_prepare, resume): Replace
5134         throw_exception with throw.
5135         * infcmd.c (post_create_inferior): Replace throw_exception with
5136         throw.
5137         * inf-loop.c (inferior_event_handler): Replace throw_exception
5138         with throw.
5139         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5140         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5141         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5142         (get_prev_frame_always, get_frame_pc_if_available)
5143         (get_frame_address_in_block_if_available, get_frame_language):
5144         Replace throw_exception with throw.
5145         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5146         throw_exception with throw.
5147         * eval.c (fetch_subexp_value, evaluate_var_value)
5148         (evaluate_funcall, evaluate_subexp_standard): Replace
5149         throw_exception with throw.
5150         * dwarf2loc.c (call_site_find_chain)
5151         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5152         Replace throw_exception with throw.
5153         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5154         with throw.
5155         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5156         throw.
5157         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5158         * completer.c (complete_line_internal): Replace throw_exception
5159         with throw.
5160         * compile/compile-object-run.c (compile_object_run): Replace
5161         throw_exception with throw.
5162         * cli/cli-script.c (process_next_line): Replace throw_exception
5163         with throw.
5164         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5165         (btrace_enable, btrace_maint_update_pt_packets): Replace
5166         throw_exception with throw.
5167         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5168         throw_exception with throw.
5169         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5170         throw_exception with throw.
5171         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5172         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5173         * aarch64-tdep.c (aarch64_make_prologue_cache)
5174         (aarch64_make_stub_cache): Replace throw_exception with throw.
5175
5176 2019-04-08  Tom Tromey  <tom@tromey.com>
5177
5178         * common/common-exceptions.c (throw_exception): Rename from
5179         throw_exception_cxx.  Remove old copy.  Make argument const.
5180         (throw_it): Create and throw exception objects directly.
5181         * common/common-exceptions.h (throw_exception): Make argument
5182         const.
5183         (struct gdb_exception_error): Add constructor.
5184         (struct gdb_exception_quit): Add constructor.
5185
5186 2019-04-08  Tom Tromey  <tom@tromey.com>
5187
5188         * common/common-exceptions.h (exception_rethrow): Don't declare.
5189         (TRY_SJLJ): Update comment.
5190         (TRY, CATCH, END_CATCH): Remove.
5191         * common/common-exceptions.c (exception_rethrow): Remove.
5192
5193 2019-04-08  Tom Tromey  <tom@tromey.com>
5194
5195         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5196         Remove.
5197         (gdb_exception_error): Rename from
5198         gdb_exception_RETURN_MASK_ERROR.
5199         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5200         (gdb_quit_bad_alloc): Update.
5201         * aarch64-tdep.c: Update.
5202         * ada-lang.c: Update.
5203         * ada-typeprint.c: Update.
5204         * ada-valprint.c: Update.
5205         * amd64-tdep.c: Update.
5206         * arch-utils.c: Update.
5207         * break-catch-throw.c: Update.
5208         * breakpoint.c: Update.
5209         * btrace.c: Update.
5210         * c-varobj.c: Update.
5211         * cli/cli-cmds.c: Update.
5212         * cli/cli-interp.c: Update.
5213         * cli/cli-script.c: Update.
5214         * common/common-exceptions.c: Update.
5215         * common/new-op.c: Update.
5216         * common/selftest.c: Update.
5217         * compile/compile-c-symbols.c: Update.
5218         * compile/compile-cplus-symbols.c: Update.
5219         * compile/compile-object-load.c: Update.
5220         * compile/compile-object-run.c: Update.
5221         * completer.c: Update.
5222         * corelow.c: Update.
5223         * cp-abi.c: Update.
5224         * cp-support.c: Update.
5225         * cp-valprint.c: Update.
5226         * darwin-nat.c: Update.
5227         * disasm-selftests.c: Update.
5228         * dtrace-probe.c: Update.
5229         * dwarf-index-cache.c: Update.
5230         * dwarf-index-write.c: Update.
5231         * dwarf2-frame-tailcall.c: Update.
5232         * dwarf2-frame.c: Update.
5233         * dwarf2loc.c: Update.
5234         * dwarf2read.c: Update.
5235         * eval.c: Update.
5236         * event-loop.c: Update.
5237         * event-top.c: Update.
5238         * exec.c: Update.
5239         * f-valprint.c: Update.
5240         * fbsd-tdep.c: Update.
5241         * frame-unwind.c: Update.
5242         * frame.c: Update.
5243         * gdbtypes.c: Update.
5244         * gnu-v3-abi.c: Update.
5245         * guile/guile-internal.h: Update.
5246         * guile/scm-block.c: Update.
5247         * guile/scm-breakpoint.c: Update.
5248         * guile/scm-cmd.c: Update.
5249         * guile/scm-disasm.c: Update.
5250         * guile/scm-frame.c: Update.
5251         * guile/scm-lazy-string.c: Update.
5252         * guile/scm-math.c: Update.
5253         * guile/scm-param.c: Update.
5254         * guile/scm-ports.c: Update.
5255         * guile/scm-pretty-print.c: Update.
5256         * guile/scm-symbol.c: Update.
5257         * guile/scm-symtab.c: Update.
5258         * guile/scm-type.c: Update.
5259         * guile/scm-value.c: Update.
5260         * i386-linux-tdep.c: Update.
5261         * i386-tdep.c: Update.
5262         * inf-loop.c: Update.
5263         * infcall.c: Update.
5264         * infcmd.c: Update.
5265         * infrun.c: Update.
5266         * jit.c: Update.
5267         * language.c: Update.
5268         * linespec.c: Update.
5269         * linux-fork.c: Update.
5270         * linux-nat.c: Update.
5271         * linux-tdep.c: Update.
5272         * linux-thread-db.c: Update.
5273         * main.c: Update.
5274         * mi/mi-cmd-break.c: Update.
5275         * mi/mi-cmd-stack.c: Update.
5276         * mi/mi-interp.c: Update.
5277         * mi/mi-main.c: Update.
5278         * objc-lang.c: Update.
5279         * p-valprint.c: Update.
5280         * parse.c: Update.
5281         * ppc-linux-tdep.c: Update.
5282         * printcmd.c: Update.
5283         * python/py-arch.c: Update.
5284         * python/py-breakpoint.c: Update.
5285         * python/py-cmd.c: Update.
5286         * python/py-finishbreakpoint.c: Update.
5287         * python/py-frame.c: Update.
5288         * python/py-framefilter.c: Update.
5289         * python/py-gdb-readline.c: Update.
5290         * python/py-inferior.c: Update.
5291         * python/py-infthread.c: Update.
5292         * python/py-lazy-string.c: Update.
5293         * python/py-linetable.c: Update.
5294         * python/py-objfile.c: Update.
5295         * python/py-param.c: Update.
5296         * python/py-prettyprint.c: Update.
5297         * python/py-progspace.c: Update.
5298         * python/py-record-btrace.c: Update.
5299         * python/py-record.c: Update.
5300         * python/py-symbol.c: Update.
5301         * python/py-type.c: Update.
5302         * python/py-unwind.c: Update.
5303         * python/py-utils.c: Update.
5304         * python/py-value.c: Update.
5305         * python/python.c: Update.
5306         * record-btrace.c: Update.
5307         * record-full.c: Update.
5308         * remote-fileio.c: Update.
5309         * remote.c: Update.
5310         * riscv-tdep.c: Update.
5311         * rs6000-aix-tdep.c: Update.
5312         * rs6000-tdep.c: Update.
5313         * rust-exp.y: Update.
5314         * rust-lang.c: Update.
5315         * s390-tdep.c: Update.
5316         * selftest-arch.c: Update.
5317         * solib-dsbt.c: Update.
5318         * solib-frv.c: Update.
5319         * solib-spu.c: Update.
5320         * solib-svr4.c: Update.
5321         * solib.c: Update.
5322         * sparc64-linux-tdep.c: Update.
5323         * stack.c: Update.
5324         * symfile-mem.c: Update.
5325         * symmisc.c: Update.
5326         * target.c: Update.
5327         * thread.c: Update.
5328         * top.c: Update.
5329         * tracefile-tfile.c: Update.
5330         * tui/tui.c: Update.
5331         * typeprint.c: Update.
5332         * unittests/cli-utils-selftests.c: Update.
5333         * unittests/parse-connection-spec-selftests.c: Update.
5334         * valops.c: Update.
5335         * valprint.c: Update.
5336         * value.c: Update.
5337         * varobj.c: Update.
5338         * windows-nat.c: Update.
5339         * x86-linux-nat.c: Update.
5340         * xml-support.c: Update.
5341
5342 2019-04-08  Tom Tromey  <tom@tromey.com>
5343
5344         * xml-support.c: Use C++ exception handling.
5345         * x86-linux-nat.c: Use C++ exception handling.
5346         * windows-nat.c: Use C++ exception handling.
5347         * varobj.c: Use C++ exception handling.
5348         * value.c: Use C++ exception handling.
5349         * valprint.c: Use C++ exception handling.
5350         * valops.c: Use C++ exception handling.
5351         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5352         handling.
5353         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5354         * typeprint.c: Use C++ exception handling.
5355         * tui/tui.c: Use C++ exception handling.
5356         * tracefile-tfile.c: Use C++ exception handling.
5357         * top.c: Use C++ exception handling.
5358         * thread.c: Use C++ exception handling.
5359         * target.c: Use C++ exception handling.
5360         * symmisc.c: Use C++ exception handling.
5361         * symfile-mem.c: Use C++ exception handling.
5362         * stack.c: Use C++ exception handling.
5363         * sparc64-linux-tdep.c: Use C++ exception handling.
5364         * solib.c: Use C++ exception handling.
5365         * solib-svr4.c: Use C++ exception handling.
5366         * solib-spu.c: Use C++ exception handling.
5367         * solib-frv.c: Use C++ exception handling.
5368         * solib-dsbt.c: Use C++ exception handling.
5369         * selftest-arch.c: Use C++ exception handling.
5370         * s390-tdep.c: Use C++ exception handling.
5371         * rust-lang.c: Use C++ exception handling.
5372         * rust-exp.y: Use C++ exception handling.
5373         * rs6000-tdep.c: Use C++ exception handling.
5374         * rs6000-aix-tdep.c: Use C++ exception handling.
5375         * riscv-tdep.c: Use C++ exception handling.
5376         * remote.c: Use C++ exception handling.
5377         * remote-fileio.c: Use C++ exception handling.
5378         * record-full.c: Use C++ exception handling.
5379         * record-btrace.c: Use C++ exception handling.
5380         * python/python.c: Use C++ exception handling.
5381         * python/py-value.c: Use C++ exception handling.
5382         * python/py-utils.c: Use C++ exception handling.
5383         * python/py-unwind.c: Use C++ exception handling.
5384         * python/py-type.c: Use C++ exception handling.
5385         * python/py-symbol.c: Use C++ exception handling.
5386         * python/py-record.c: Use C++ exception handling.
5387         * python/py-record-btrace.c: Use C++ exception handling.
5388         * python/py-progspace.c: Use C++ exception handling.
5389         * python/py-prettyprint.c: Use C++ exception handling.
5390         * python/py-param.c: Use C++ exception handling.
5391         * python/py-objfile.c: Use C++ exception handling.
5392         * python/py-linetable.c: Use C++ exception handling.
5393         * python/py-lazy-string.c: Use C++ exception handling.
5394         * python/py-infthread.c: Use C++ exception handling.
5395         * python/py-inferior.c: Use C++ exception handling.
5396         * python/py-gdb-readline.c: Use C++ exception handling.
5397         * python/py-framefilter.c: Use C++ exception handling.
5398         * python/py-frame.c: Use C++ exception handling.
5399         * python/py-finishbreakpoint.c: Use C++ exception handling.
5400         * python/py-cmd.c: Use C++ exception handling.
5401         * python/py-breakpoint.c: Use C++ exception handling.
5402         * python/py-arch.c: Use C++ exception handling.
5403         * printcmd.c: Use C++ exception handling.
5404         * ppc-linux-tdep.c: Use C++ exception handling.
5405         * parse.c: Use C++ exception handling.
5406         * p-valprint.c: Use C++ exception handling.
5407         * objc-lang.c: Use C++ exception handling.
5408         * mi/mi-main.c: Use C++ exception handling.
5409         * mi/mi-interp.c: Use C++ exception handling.
5410         * mi/mi-cmd-stack.c: Use C++ exception handling.
5411         * mi/mi-cmd-break.c: Use C++ exception handling.
5412         * main.c: Use C++ exception handling.
5413         * linux-thread-db.c: Use C++ exception handling.
5414         * linux-tdep.c: Use C++ exception handling.
5415         * linux-nat.c: Use C++ exception handling.
5416         * linux-fork.c: Use C++ exception handling.
5417         * linespec.c: Use C++ exception handling.
5418         * language.c: Use C++ exception handling.
5419         * jit.c: Use C++ exception handling.
5420         * infrun.c: Use C++ exception handling.
5421         * infcmd.c: Use C++ exception handling.
5422         * infcall.c: Use C++ exception handling.
5423         * inf-loop.c: Use C++ exception handling.
5424         * i386-tdep.c: Use C++ exception handling.
5425         * i386-linux-tdep.c: Use C++ exception handling.
5426         * guile/scm-value.c: Use C++ exception handling.
5427         * guile/scm-type.c: Use C++ exception handling.
5428         * guile/scm-symtab.c: Use C++ exception handling.
5429         * guile/scm-symbol.c: Use C++ exception handling.
5430         * guile/scm-pretty-print.c: Use C++ exception handling.
5431         * guile/scm-ports.c: Use C++ exception handling.
5432         * guile/scm-param.c: Use C++ exception handling.
5433         * guile/scm-math.c: Use C++ exception handling.
5434         * guile/scm-lazy-string.c: Use C++ exception handling.
5435         * guile/scm-frame.c: Use C++ exception handling.
5436         * guile/scm-disasm.c: Use C++ exception handling.
5437         * guile/scm-cmd.c: Use C++ exception handling.
5438         * guile/scm-breakpoint.c: Use C++ exception handling.
5439         * guile/scm-block.c: Use C++ exception handling.
5440         * guile/guile-internal.h: Use C++ exception handling.
5441         * gnu-v3-abi.c: Use C++ exception handling.
5442         * gdbtypes.c: Use C++ exception handling.
5443         * frame.c: Use C++ exception handling.
5444         * frame-unwind.c: Use C++ exception handling.
5445         * fbsd-tdep.c: Use C++ exception handling.
5446         * f-valprint.c: Use C++ exception handling.
5447         * exec.c: Use C++ exception handling.
5448         * event-top.c: Use C++ exception handling.
5449         * event-loop.c: Use C++ exception handling.
5450         * eval.c: Use C++ exception handling.
5451         * dwarf2read.c: Use C++ exception handling.
5452         * dwarf2loc.c: Use C++ exception handling.
5453         * dwarf2-frame.c: Use C++ exception handling.
5454         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5455         * dwarf-index-write.c: Use C++ exception handling.
5456         * dwarf-index-cache.c: Use C++ exception handling.
5457         * dtrace-probe.c: Use C++ exception handling.
5458         * disasm-selftests.c: Use C++ exception handling.
5459         * darwin-nat.c: Use C++ exception handling.
5460         * cp-valprint.c: Use C++ exception handling.
5461         * cp-support.c: Use C++ exception handling.
5462         * cp-abi.c: Use C++ exception handling.
5463         * corelow.c: Use C++ exception handling.
5464         * completer.c: Use C++ exception handling.
5465         * compile/compile-object-run.c: Use C++ exception handling.
5466         * compile/compile-object-load.c: Use C++ exception handling.
5467         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5468         * compile/compile-c-symbols.c: Use C++ exception handling.
5469         * common/selftest.c: Use C++ exception handling.
5470         * common/new-op.c: Use C++ exception handling.
5471         * cli/cli-script.c: Use C++ exception handling.
5472         * cli/cli-interp.c: Use C++ exception handling.
5473         * cli/cli-cmds.c: Use C++ exception handling.
5474         * c-varobj.c: Use C++ exception handling.
5475         * btrace.c: Use C++ exception handling.
5476         * breakpoint.c: Use C++ exception handling.
5477         * break-catch-throw.c: Use C++ exception handling.
5478         * arch-utils.c: Use C++ exception handling.
5479         * amd64-tdep.c: Use C++ exception handling.
5480         * ada-valprint.c: Use C++ exception handling.
5481         * ada-typeprint.c: Use C++ exception handling.
5482         * ada-lang.c: Use C++ exception handling.
5483         * aarch64-tdep.c: Use C++ exception handling.
5484
5485 2019-04-08  Tom Tromey  <tom@tromey.com>
5486
5487         * xml-support.c (gdb_xml_parser::parse): Update.
5488         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5489         * value.c (show_convenience): Update.
5490         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5491         (test_parse_flags_qcs): Update.
5492         * thread.c (thr_try_catch_cmd): Update.
5493         * target.c (target_translate_tls_address): Update.
5494         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5495         (info_frame_command_core, frame_apply_command_count): Update.
5496         * rust-exp.y (rust_lex_exception_test): Update.
5497         * riscv-tdep.c (riscv_print_one_register_info): Update.
5498         * remote.c (remote_target::enable_btrace): Update.
5499         * record-btrace.c (record_btrace_enable_warn): Update.
5500         * python/py-utils.c (gdbpy_convert_exception): Update.
5501         * printcmd.c (do_one_display, print_variable_and_value): Update.
5502         * mi/mi-main.c (mi_print_exception): Update.
5503         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5504         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5505         * linux-nat.c (linux_nat_target::attach): Update.
5506         * linux-fork.c (class scoped_switch_fork_info): Update.
5507         * infrun.c (displaced_step_prepare): Update.
5508         * infcall.c (call_function_by_hand_dummy): Update.
5509         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5510         * gnu-v3-abi.c (print_one_vtable): Update.
5511         * frame.c (get_prev_frame_always): Update.
5512         * f-valprint.c (info_common_command_for_block): Update.
5513         * exec.c (try_open_exec_file): Update.
5514         * exceptions.c (print_exception, exception_print)
5515         (exception_fprintf, exception_print_same): Update.
5516         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5517         * dwarf-index-cache.c (index_cache::store)
5518         (index_cache::lookup_gdb_index): Update.
5519         * darwin-nat.c (maybe_cache_shell): Update.
5520         * cp-valprint.c (cp_print_value_fields): Update.
5521         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5522         (gcc_cplus_symbol_address): Update.
5523         * compile/compile-c-symbols.c (gcc_convert_symbol)
5524         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5525         * common/selftest.c: Update.
5526         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5527         a std::string.
5528         (exception_try_scope_entry, exception_try_scope_exit): Don't
5529         declare.
5530         (struct exception_try_scope): Remove.
5531         (TRY): Don't use exception_try_scope.
5532         (struct gdb_exception): Add constructor, operator=.
5533         <what>: New method.
5534         (struct gdb_exception_RETURN_MASK_ALL)
5535         (struct gdb_exception_RETURN_MASK_ERROR)
5536         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5537         (struct gdb_quit_bad_alloc): Update.
5538         * common/common-exceptions.c (exception_none): Change
5539         initializer.
5540         (struct catcher) <state, exception>: Initialize inline.
5541         <prev>: Remove member.
5542         (current_catcher): Remove.
5543         (catchers): New global.
5544         (exceptions_state_mc_init): Simplify.
5545         (catcher_pop): Remove.
5546         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5547         (try_scope_depth, exception_try_scope_entry)
5548         (exception_try_scope_exit): Remove.
5549         (throw_exception_sjlj): Update.
5550         (exception_messages, exception_messages_size): Remove.
5551         (throw_it): Simplify.
5552         (gdb_exception_sliced_copy): Remove.
5553         (throw_exception_cxx): Update.
5554         * cli/cli-script.c (script_from_file): Update.
5555         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5556         Update.
5557         * ada-valprint.c (ada_val_print): Update.
5558         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5559         (create_excep_cond_exprs): Update.
5560
5561 2019-04-08  Tom Tromey  <tom@tromey.com>
5562
5563         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5564         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5565         (TRY, CATCH, END_CATCH): Remove some definitions.
5566         * common/common-exceptions.c: Don't use GDB_XCPT.
5567         (catcher_list_size): Remove.
5568         (throw_exception, throw_it): Simplify.
5569
5570 2019-04-05  Tom Tromey  <tom@tromey.com>
5571
5572         Revert the header-sorting patch.
5573         * ft32-tdep.c: Revert.
5574         * frv-tdep.c: Revert.
5575         * frv-linux-tdep.c: Revert.
5576         * frame.c: Revert.
5577         * frame-unwind.c: Revert.
5578         * frame-base.c: Revert.
5579         * fork-child.c: Revert.
5580         * findvar.c: Revert.
5581         * findcmd.c: Revert.
5582         * filesystem.c: Revert.
5583         * filename-seen-cache.h: Revert.
5584         * filename-seen-cache.c: Revert.
5585         * fbsd-tdep.c: Revert.
5586         * fbsd-nat.h: Revert.
5587         * fbsd-nat.c: Revert.
5588         * f-valprint.c: Revert.
5589         * f-typeprint.c: Revert.
5590         * f-lang.c: Revert.
5591         * extension.h: Revert.
5592         * extension.c: Revert.
5593         * extension-priv.h: Revert.
5594         * expprint.c: Revert.
5595         * exec.h: Revert.
5596         * exec.c: Revert.
5597         * exceptions.c: Revert.
5598         * event-top.c: Revert.
5599         * event-loop.c: Revert.
5600         * eval.c: Revert.
5601         * elfread.c: Revert.
5602         * dwarf2read.h: Revert.
5603         * dwarf2read.c: Revert.
5604         * dwarf2loc.c: Revert.
5605         * dwarf2expr.h: Revert.
5606         * dwarf2expr.c: Revert.
5607         * dwarf2-frame.c: Revert.
5608         * dwarf2-frame-tailcall.c: Revert.
5609         * dwarf-index-write.h: Revert.
5610         * dwarf-index-write.c: Revert.
5611         * dwarf-index-common.c: Revert.
5612         * dwarf-index-cache.h: Revert.
5613         * dwarf-index-cache.c: Revert.
5614         * dummy-frame.c: Revert.
5615         * dtrace-probe.c: Revert.
5616         * disasm.h: Revert.
5617         * disasm.c: Revert.
5618         * disasm-selftests.c: Revert.
5619         * dictionary.c: Revert.
5620         * dicos-tdep.c: Revert.
5621         * demangle.c: Revert.
5622         * dcache.h: Revert.
5623         * dcache.c: Revert.
5624         * darwin-nat.h: Revert.
5625         * darwin-nat.c: Revert.
5626         * darwin-nat-info.c: Revert.
5627         * d-valprint.c: Revert.
5628         * d-namespace.c: Revert.
5629         * d-lang.c: Revert.
5630         * ctf.c: Revert.
5631         * csky-tdep.c: Revert.
5632         * csky-linux-tdep.c: Revert.
5633         * cris-tdep.c: Revert.
5634         * cris-linux-tdep.c: Revert.
5635         * cp-valprint.c: Revert.
5636         * cp-support.c: Revert.
5637         * cp-namespace.c: Revert.
5638         * cp-abi.c: Revert.
5639         * corelow.c: Revert.
5640         * corefile.c: Revert.
5641         * continuations.c: Revert.
5642         * completer.h: Revert.
5643         * completer.c: Revert.
5644         * complaints.c: Revert.
5645         * coffread.c: Revert.
5646         * coff-pe-read.c: Revert.
5647         * cli-out.h: Revert.
5648         * cli-out.c: Revert.
5649         * charset.c: Revert.
5650         * c-varobj.c: Revert.
5651         * c-valprint.c: Revert.
5652         * c-typeprint.c: Revert.
5653         * c-lang.c: Revert.
5654         * buildsym.c: Revert.
5655         * buildsym-legacy.c: Revert.
5656         * build-id.h: Revert.
5657         * build-id.c: Revert.
5658         * btrace.c: Revert.
5659         * bsd-uthread.c: Revert.
5660         * breakpoint.h: Revert.
5661         * breakpoint.c: Revert.
5662         * break-catch-throw.c: Revert.
5663         * break-catch-syscall.c: Revert.
5664         * break-catch-sig.c: Revert.
5665         * blockframe.c: Revert.
5666         * block.c: Revert.
5667         * bfin-tdep.c: Revert.
5668         * bfin-linux-tdep.c: Revert.
5669         * bfd-target.c: Revert.
5670         * bcache.c: Revert.
5671         * ax-general.c: Revert.
5672         * ax-gdb.h: Revert.
5673         * ax-gdb.c: Revert.
5674         * avr-tdep.c: Revert.
5675         * auxv.c: Revert.
5676         * auto-load.c: Revert.
5677         * arm-wince-tdep.c: Revert.
5678         * arm-tdep.c: Revert.
5679         * arm-symbian-tdep.c: Revert.
5680         * arm-pikeos-tdep.c: Revert.
5681         * arm-obsd-tdep.c: Revert.
5682         * arm-nbsd-tdep.c: Revert.
5683         * arm-nbsd-nat.c: Revert.
5684         * arm-linux-tdep.c: Revert.
5685         * arm-linux-nat.c: Revert.
5686         * arm-fbsd-tdep.c: Revert.
5687         * arm-fbsd-nat.c: Revert.
5688         * arm-bsd-tdep.c: Revert.
5689         * arch-utils.c: Revert.
5690         * arc-tdep.c: Revert.
5691         * arc-newlib-tdep.c: Revert.
5692         * annotate.h: Revert.
5693         * annotate.c: Revert.
5694         * amd64-windows-tdep.c: Revert.
5695         * amd64-windows-nat.c: Revert.
5696         * amd64-tdep.c: Revert.
5697         * amd64-sol2-tdep.c: Revert.
5698         * amd64-obsd-tdep.c: Revert.
5699         * amd64-obsd-nat.c: Revert.
5700         * amd64-nbsd-tdep.c: Revert.
5701         * amd64-nbsd-nat.c: Revert.
5702         * amd64-nat.c: Revert.
5703         * amd64-linux-tdep.c: Revert.
5704         * amd64-linux-nat.c: Revert.
5705         * amd64-fbsd-tdep.c: Revert.
5706         * amd64-fbsd-nat.c: Revert.
5707         * amd64-dicos-tdep.c: Revert.
5708         * amd64-darwin-tdep.c: Revert.
5709         * amd64-bsd-nat.c: Revert.
5710         * alpha-tdep.c: Revert.
5711         * alpha-obsd-tdep.c: Revert.
5712         * alpha-nbsd-tdep.c: Revert.
5713         * alpha-mdebug-tdep.c: Revert.
5714         * alpha-linux-tdep.c: Revert.
5715         * alpha-linux-nat.c: Revert.
5716         * alpha-bsd-tdep.c: Revert.
5717         * alpha-bsd-nat.c: Revert.
5718         * aix-thread.c: Revert.
5719         * agent.c: Revert.
5720         * addrmap.c: Revert.
5721         * ada-varobj.c: Revert.
5722         * ada-valprint.c: Revert.
5723         * ada-typeprint.c: Revert.
5724         * ada-tasks.c: Revert.
5725         * ada-lang.c: Revert.
5726         * aarch64-tdep.c: Revert.
5727         * aarch64-ravenscar-thread.c: Revert.
5728         * aarch64-newlib-tdep.c: Revert.
5729         * aarch64-linux-tdep.c: Revert.
5730         * aarch64-linux-nat.c: Revert.
5731         * aarch64-fbsd-tdep.c: Revert.
5732         * aarch64-fbsd-nat.c: Revert.
5733         * aarch32-linux-nat.c: Revert.
5734
5735 2019-04-05  Tom Tromey  <tom@tromey.com>
5736
5737         * ft32-tdep.c: Sort headers.
5738         * frv-tdep.c: Sort headers.
5739         * frv-linux-tdep.c: Sort headers.
5740         * frame.c: Sort headers.
5741         * frame-unwind.c: Sort headers.
5742         * frame-base.c: Sort headers.
5743         * fork-child.c: Sort headers.
5744         * findvar.c: Sort headers.
5745         * findcmd.c: Sort headers.
5746         * filesystem.c: Sort headers.
5747         * filename-seen-cache.h: Sort headers.
5748         * filename-seen-cache.c: Sort headers.
5749         * fbsd-tdep.c: Sort headers.
5750         * fbsd-nat.h: Sort headers.
5751         * fbsd-nat.c: Sort headers.
5752         * f-valprint.c: Sort headers.
5753         * f-typeprint.c: Sort headers.
5754         * f-lang.c: Sort headers.
5755         * extension.h: Sort headers.
5756         * extension.c: Sort headers.
5757         * extension-priv.h: Sort headers.
5758         * expprint.c: Sort headers.
5759         * exec.h: Sort headers.
5760         * exec.c: Sort headers.
5761         * exceptions.c: Sort headers.
5762         * event-top.c: Sort headers.
5763         * event-loop.c: Sort headers.
5764         * eval.c: Sort headers.
5765         * elfread.c: Sort headers.
5766         * dwarf2read.h: Sort headers.
5767         * dwarf2read.c: Sort headers.
5768         * dwarf2loc.c: Sort headers.
5769         * dwarf2expr.h: Sort headers.
5770         * dwarf2expr.c: Sort headers.
5771         * dwarf2-frame.c: Sort headers.
5772         * dwarf2-frame-tailcall.c: Sort headers.
5773         * dwarf-index-write.h: Sort headers.
5774         * dwarf-index-write.c: Sort headers.
5775         * dwarf-index-common.c: Sort headers.
5776         * dwarf-index-cache.h: Sort headers.
5777         * dwarf-index-cache.c: Sort headers.
5778         * dummy-frame.c: Sort headers.
5779         * dtrace-probe.c: Sort headers.
5780         * disasm.h: Sort headers.
5781         * disasm.c: Sort headers.
5782         * disasm-selftests.c: Sort headers.
5783         * dictionary.c: Sort headers.
5784         * dicos-tdep.c: Sort headers.
5785         * demangle.c: Sort headers.
5786         * dcache.h: Sort headers.
5787         * dcache.c: Sort headers.
5788         * darwin-nat.h: Sort headers.
5789         * darwin-nat.c: Sort headers.
5790         * darwin-nat-info.c: Sort headers.
5791         * d-valprint.c: Sort headers.
5792         * d-namespace.c: Sort headers.
5793         * d-lang.c: Sort headers.
5794         * ctf.c: Sort headers.
5795         * csky-tdep.c: Sort headers.
5796         * csky-linux-tdep.c: Sort headers.
5797         * cris-tdep.c: Sort headers.
5798         * cris-linux-tdep.c: Sort headers.
5799         * cp-valprint.c: Sort headers.
5800         * cp-support.c: Sort headers.
5801         * cp-namespace.c: Sort headers.
5802         * cp-abi.c: Sort headers.
5803         * corelow.c: Sort headers.
5804         * corefile.c: Sort headers.
5805         * continuations.c: Sort headers.
5806         * completer.h: Sort headers.
5807         * completer.c: Sort headers.
5808         * complaints.c: Sort headers.
5809         * coffread.c: Sort headers.
5810         * coff-pe-read.c: Sort headers.
5811         * cli-out.h: Sort headers.
5812         * cli-out.c: Sort headers.
5813         * charset.c: Sort headers.
5814         * c-varobj.c: Sort headers.
5815         * c-valprint.c: Sort headers.
5816         * c-typeprint.c: Sort headers.
5817         * c-lang.c: Sort headers.
5818         * buildsym.c: Sort headers.
5819         * buildsym-legacy.c: Sort headers.
5820         * build-id.h: Sort headers.
5821         * build-id.c: Sort headers.
5822         * btrace.c: Sort headers.
5823         * bsd-uthread.c: Sort headers.
5824         * breakpoint.h: Sort headers.
5825         * breakpoint.c: Sort headers.
5826         * break-catch-throw.c: Sort headers.
5827         * break-catch-syscall.c: Sort headers.
5828         * break-catch-sig.c: Sort headers.
5829         * blockframe.c: Sort headers.
5830         * block.c: Sort headers.
5831         * bfin-tdep.c: Sort headers.
5832         * bfin-linux-tdep.c: Sort headers.
5833         * bfd-target.c: Sort headers.
5834         * bcache.c: Sort headers.
5835         * ax-general.c: Sort headers.
5836         * ax-gdb.h: Sort headers.
5837         * ax-gdb.c: Sort headers.
5838         * avr-tdep.c: Sort headers.
5839         * auxv.c: Sort headers.
5840         * auto-load.c: Sort headers.
5841         * arm-wince-tdep.c: Sort headers.
5842         * arm-tdep.c: Sort headers.
5843         * arm-symbian-tdep.c: Sort headers.
5844         * arm-pikeos-tdep.c: Sort headers.
5845         * arm-obsd-tdep.c: Sort headers.
5846         * arm-nbsd-tdep.c: Sort headers.
5847         * arm-nbsd-nat.c: Sort headers.
5848         * arm-linux-tdep.c: Sort headers.
5849         * arm-linux-nat.c: Sort headers.
5850         * arm-fbsd-tdep.c: Sort headers.
5851         * arm-fbsd-nat.c: Sort headers.
5852         * arm-bsd-tdep.c: Sort headers.
5853         * arch-utils.c: Sort headers.
5854         * arc-tdep.c: Sort headers.
5855         * arc-newlib-tdep.c: Sort headers.
5856         * annotate.h: Sort headers.
5857         * annotate.c: Sort headers.
5858         * amd64-windows-tdep.c: Sort headers.
5859         * amd64-windows-nat.c: Sort headers.
5860         * amd64-tdep.c: Sort headers.
5861         * amd64-sol2-tdep.c: Sort headers.
5862         * amd64-obsd-tdep.c: Sort headers.
5863         * amd64-obsd-nat.c: Sort headers.
5864         * amd64-nbsd-tdep.c: Sort headers.
5865         * amd64-nbsd-nat.c: Sort headers.
5866         * amd64-nat.c: Sort headers.
5867         * amd64-linux-tdep.c: Sort headers.
5868         * amd64-linux-nat.c: Sort headers.
5869         * amd64-fbsd-tdep.c: Sort headers.
5870         * amd64-fbsd-nat.c: Sort headers.
5871         * amd64-dicos-tdep.c: Sort headers.
5872         * amd64-darwin-tdep.c: Sort headers.
5873         * amd64-bsd-nat.c: Sort headers.
5874         * alpha-tdep.c: Sort headers.
5875         * alpha-obsd-tdep.c: Sort headers.
5876         * alpha-nbsd-tdep.c: Sort headers.
5877         * alpha-mdebug-tdep.c: Sort headers.
5878         * alpha-linux-tdep.c: Sort headers.
5879         * alpha-linux-nat.c: Sort headers.
5880         * alpha-bsd-tdep.c: Sort headers.
5881         * alpha-bsd-nat.c: Sort headers.
5882         * aix-thread.c: Sort headers.
5883         * agent.c: Sort headers.
5884         * addrmap.c: Sort headers.
5885         * ada-varobj.c: Sort headers.
5886         * ada-valprint.c: Sort headers.
5887         * ada-typeprint.c: Sort headers.
5888         * ada-tasks.c: Sort headers.
5889         * ada-lang.c: Sort headers.
5890         * aarch64-tdep.c: Sort headers.
5891         * aarch64-ravenscar-thread.c: Sort headers.
5892         * aarch64-newlib-tdep.c: Sort headers.
5893         * aarch64-linux-tdep.c: Sort headers.
5894         * aarch64-linux-nat.c: Sort headers.
5895         * aarch64-fbsd-tdep.c: Sort headers.
5896         * aarch64-fbsd-nat.c: Sort headers.
5897         * aarch32-linux-nat.c: Sort headers.
5898
5899 2019-04-04  Tom Tromey  <tom@tromey.com>
5900
5901         * varobj.c (varobj_create): Update.
5902         * rust-exp.y (struct rust_parser) <update_innermost_block,
5903         lookup_symbol>: New methods.
5904         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5905         Rename.
5906         (rust_parser::rust_lookup_type)
5907         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5908         * printcmd.c (display_command, do_one_display): Update.
5909         * parser-defs.h (struct parser_state) <parser_state>: Add
5910         "tracker" parameter.
5911         (block_tracker): New member.
5912         (class innermost_block_tracker) <innermost_block_tracker>: Add
5913         "types" parameter.
5914         <reset>: Remove method.
5915         (innermost_block): Don't declare.
5916         (null_post_parser): Update.
5917         * parse.c (innermost_block): Remove global.
5918         (write_dollar_variable): Update.
5919         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5920         Remove "tracker_types" parameter.
5921         (parse_expression): Add "tracker" parameter.
5922         (parse_expression_for_completion): Update.
5923         (null_post_parser): Add "tracker" parameter.
5924         * p-exp.y: Update rules.
5925         * m2-exp.y: Update rules.
5926         * language.h (struct language_defn) <la_post_parser>: Add
5927         "tracker" parameter.
5928         * go-exp.y: Update rules.
5929         * f-exp.y: Update rules.
5930         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5931         parameter.
5932         * d-exp.y: Update rules.
5933         * c-exp.y: Update rules.
5934         * breakpoint.c (set_breakpoint_condition): Create an
5935         innermost_block_tracker.
5936         (watch_command_1): Likewise.
5937         * ada-lang.c (resolve): Add "tracker" parameter.
5938         (resolve_subexp): Likewise.
5939         * ada-exp.y (write_var_from_sym): Update.
5940
5941 2019-04-04  Tom Tromey  <tom@tromey.com>
5942
5943         * type-stack.h: New file.
5944         * type-stack.c: New file.
5945         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5946         type-stack.h.
5947         (insert_into_type_stack, insert_type, push_type, push_type_int)
5948         (insert_type_address_space, pop_type, pop_type_int)
5949         (pop_typelist, pop_type_stack, append_type_stack)
5950         (push_type_stack, get_type_stack, push_typelist)
5951         (follow_type_instance_flags, follow_types): Don't declare.
5952         * parse.c (type_stack): Remove global.
5953         (parse_exp_in_context): Update.
5954         (insert_into_type_stack, insert_type, push_type, push_type_int)
5955         (insert_type_address_space, pop_type, pop_type_int)
5956         (pop_typelist, pop_type_stack, append_type_stack)
5957         (push_type_stack, get_type_stack, push_typelist)
5958         (follow_type_instance_flags, follow_types): Remove (moved to
5959         type-stack.c).
5960         * f-exp.y (type_stack): New global.
5961         Update rules.
5962         (push_kind_type, f_parse): Update.
5963         * d-exp.y (type_stack): New global.
5964         Update rules.
5965         (d_parse): Update.
5966         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5967         Update rules.
5968         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5969         (HFILES_NO_SRCDIR): Add type-stack.h.
5970
5971 2019-04-04  Tom Tromey  <tom@tromey.com>
5972
5973         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5974         (rust_parser::convert_ast_to_expression, rust_parse)
5975         (rust_lex_test_completion, rust_lex_tests): Update.
5976         * parser-defs.h (struct expr_completion_state): New.
5977         (struct parser_state) <parser_state>: Add completion parameter.
5978         <mark_struct_expression, mark_completion_tag>: New methods.
5979         <parse_completion, m_completion_state>: New members.
5980         (prefixify_expression, null_post_parser): Update.
5981         (mark_struct_expression, mark_completion_tag): Don't declare.
5982         * parse.c (parse_completion, expout_last_struct)
5983         (expout_tag_completion_type, expout_completion_name): Remove
5984         globals.
5985         (parser_state::mark_struct_expression)
5986         (parser_state::mark_completion_tag): Now methods.
5987         (prefixify_expression): Add last_struct parameter.
5988         (prefixify_subexp): Likewise.
5989         (parse_exp_1): Update.
5990         (parse_exp_in_context): Add cstate parameter.  Update.
5991         (parse_expression_for_completion): Create an
5992         expr_completion_state.
5993         (null_post_parser): Add "completion" parameter.
5994         * p-exp.y: Update rules.
5995         (yylex): Update.
5996         * language.h (struct language_defn) <la_post_parser>: Add
5997         "completing" parameter.
5998         * go-exp.y: Update rules.
5999         (lex_one_token): Update.
6000         * expression.h (parse_completion): Don't declare.
6001         * d-exp.y: Update rules.
6002         (lex_one_token): Update rules.
6003         * c-exp.y: Update rules.
6004         (lex_one_token): Update.
6005         * ada-lang.c (resolve): Add "parse_completion" parameter.
6006         (resolve_subexp): Likewise.
6007         (ada_resolve_function): Likewise.
6008
6009 2019-04-04  Tom Tromey  <tom@tromey.com>
6010
6011         * parser-defs.h (struct parser_state) <start_arglist,
6012         end_arglist>: New methods.
6013         <arglist_len, m_funcall_chain>: New members.
6014         (arglist_len, start_arglist, end_arglist): Don't declare.
6015         * parse.c (arglist_len, funcall_chain): Remove global.
6016         (start_arglist, end_arglist): Remove functions.
6017         (parse_exp_in_context): Update.
6018         * p-exp.y: Update rules.
6019         * m2-exp.y: Update rules.
6020         * go-exp.y: Update rules.
6021         * f-exp.y: Update rules.
6022         * d-exp.y: Update rules.
6023         * c-exp.y: Update rules.
6024
6025 2019-04-04  Tom Tromey  <tom@tromey.com>
6026
6027         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6028         lex_operator, push_back>: New methods.
6029         Update all rules.
6030         (rust_parser::lex_hex, lex_escape): Rename and update.
6031         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6032         (rust_parser::lex_operator): Rename and update.
6033         (rust_parser::lex_number, rustyylex, rustyyerror)
6034         (rust_lex_test_init, rust_lex_test_sequence)
6035         (rust_lex_test_push_back, rust_lex_tests): Update.
6036         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6037         parameter.
6038         <lexptr, prev_lexptr>: New members.
6039         (lexptr, prev_lexptr): Don't declare.
6040         * parse.c (lexptr, prev_lexptr): Remove globals.
6041         (parse_exp_in_context): Update.
6042         * p-exp.y (yylex, yyerror): Update.
6043         * m2-exp.y (parse_number, yylex, yyerror): Update.
6044         * go-exp.y (lex_one_token, yyerror): Update.
6045         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6046         * d-exp.y (lex_one_token, yyerror): Update.
6047         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6048         (lex_one_token, yyerror): Update.
6049         * ada-lex.l (YY_INPUT): Update.
6050         (rewind_to_char): Update.
6051         * ada-exp.y (yyerror): Update.
6052
6053 2019-04-04  Tom Tromey  <tom@tromey.com>
6054
6055         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6056         * parser-defs.h (struct parser_state) <parser_state>: Add new
6057         parameter.
6058         <comma_terminates>: New member.
6059         (comma_terminates): Don't declare global.
6060         * parse.c (comma_terminates): Remove global.
6061         (parse_exp_in_context): Update.
6062         * p-exp.y (yylex): Update.
6063         * m2-exp.y (yylex): Update.
6064         * go-exp.y (lex_one_token): Update.
6065         * f-exp.y (yylex): Update.
6066         * d-exp.y (lex_one_token): Update.
6067         * c-exp.y (lex_one_token): Update.
6068         * ada-lex.l: Update.
6069
6070 2019-04-04  Tom Tromey  <tom@tromey.com>
6071
6072         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6073         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6074         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6075         * parser-defs.h (paren_depth): Don't declare.
6076         * parse.c (paren_depth): Remove global.
6077         (parse_exp_in_context): Update.
6078         * p-exp.y (paren_depth): New global.
6079         (pascal_parse): Initialize it.
6080         * m2-exp.y (paren_depth): New global.
6081         (m2_parse): Initialize it.
6082         * go-exp.y (paren_depth): New global.
6083         (go_parse): Initialize it.
6084         * f-exp.y (paren_depth): New global.
6085         (f_parse): Initialize it.
6086         * d-exp.y (paren_depth): New global.
6087         (d_parse): Initialize it.
6088         * c-exp.y (paren_depth): New global.
6089         (c_parse): Initialize it.
6090         * ada-lex.l (paren_depth): New global.
6091         (lexer_init): Initialize it.
6092
6093 2019-04-04  Tom Tromey  <tom@tromey.com>
6094
6095         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6096         (rust_parser::convert_ast_to_type)
6097         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6098         * parser-defs.h (struct parser_state) <parser_state>: Add
6099         parameters.  Initialize new members.
6100         <expression_context_block, expression_context_pc>: New members.
6101         * parse.c (expression_context_block, expression_context_pc):
6102         Remove globals.
6103         (parse_exp_in_context): Update.
6104         * p-exp.y: Update all rules.
6105         (yylex): Update.
6106         * m2-exp.y: Update all rules.
6107         (yylex): Update.
6108         * go-exp.y (yylex): Update.
6109         * f-exp.y (yylex): Update.
6110         * d-exp.y: Update all rules.
6111         (yylex): Update.
6112         * c-exp.y: Update all rules.
6113         (lex_one_token, classify_name, yylex, c_parse): Update.
6114         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6115
6116 2019-04-04  Tom Tromey  <tom@tromey.com>
6117
6118         * gdbarch.h, gdbarch.c: Rebuild.
6119         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6120         * stap-probe.h:
6121         (struct stap_parse_info): Replace "parser_state" with
6122         "expr_builder".
6123         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6124         (parser_state): New class.
6125         * parse.c (expr_builder): Rename.
6126         (expr_builder::release): Rename.
6127         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6128         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6129         (write_exp_elt_longcst, write_exp_elt_floatcst)
6130         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6131         (write_exp_string_vector, write_exp_bitstring)
6132         (write_exp_msymbol, mark_struct_expression)
6133         (write_dollar_variable)
6134         (insert_type_address_space, increase_expout_size): Replace
6135         "parser_state" with "expr_builder".
6136         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6137         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6138         "parser_state" with "expr_builder".
6139
6140 2019-04-04  Tom Tromey  <tom@tromey.com>
6141
6142         * rust-exp.y: Replace "parse_language" with method call.
6143         * p-exp.y:
6144         (yylex): Replace "parse_language" with method call.
6145         * m2-exp.y:
6146         (yylex): Replace "parse_language" with method call.
6147         * go-exp.y (classify_name): Replace "parse_language" with method
6148         call.
6149         * f-exp.y (yylex): Replace "parse_language" with method call.
6150         * d-exp.y (lex_one_token): Replace "parse_language" with method
6151         call.
6152         * c-exp.y:
6153         (lex_one_token, classify_name, yylex): Replace "parse_language"
6154         with method call.
6155         * ada-exp.y (find_primitive_type, type_char)
6156         (type_system_address): Replace "parse_language" with method call.
6157
6158 2019-04-04  Tom Tromey  <tom@tromey.com>
6159
6160         * rust-exp.y: Replace "parse_gdbarch" with method call.
6161         * parse.c (write_dollar_variable, insert_type_address_space):
6162         Replace "parse_gdbarch" with method call.
6163         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6164         call.
6165         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6166         call.
6167         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6168         "parse_gdbarch" with method call.
6169         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6170         with method call.
6171         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6172         "parse_gdbarch" with method call.
6173         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6174         "parse_gdbarch" with method call.
6175         * c-exp.y (parse_type, parse_number, classify_name): Replace
6176         "parse_gdbarch" with method call.
6177         * ada-lex.l: Replace "parse_gdbarch" with method call.
6178         * ada-exp.y (parse_type, find_primitive_type, type_char)
6179         (type_system_address): Replace "parse_gdbarch" with method call.
6180
6181 2019-04-04  Tom Tromey  <tom@tromey.com>
6182
6183         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6184         * stap-probe.c (stap_parse_argument): Update.
6185         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6186         initial_size parameter.
6187         * rust-exp.y (rust_lex_tests): Update.
6188         * parse.c (parser_state): Update.
6189         (parse_exp_in_context): Update.
6190         * parser-defs.h (struct parser_state) <parser_state>: Remove
6191         "initial_size" parameter.
6192
6193 2019-04-04  Tom Tromey  <tom@tromey.com>
6194
6195         * parser-defs.h (increase_expout_size): Don't declare.
6196         * parse.c (increase_expout_size): Now static.
6197
6198 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6199
6200         * gnu-nat.c (gnu_nat_target::wait): Fix
6201         target_waitstatus_to_string call.
6202
6203 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6204
6205         * eval.c (evaluate_subexp_standard): Handle internal functions
6206         during Fortran function call handling.
6207
6208 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6209
6210         * NEWS: Mention new internal functions.
6211         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6212         (read_base_type): Use dwarf2_init_complex_target_type.
6213         * value.c (creal_internal_fn): New function.
6214         (cimag_internal_fn): New function.
6215         (_initialize_values): Register new internal functions.
6216
6217 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6218
6219         * infrun.c (stop_all_threads): If debug_infrun, always
6220         trace the wait status after wait_one, using
6221         target_waitstatus_to_string and target_pid_to_str.
6222         (handle_inferior_event): Replace various trace of
6223         wait status kind by a single trace.
6224         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6225         wait status kind image by target_waitstatus_to_string.
6226         * target/waitstatus.c (target_waitstatus_to_string): Fix
6227         obsolete comment.
6228
6229 2019-04-01  Tom Tromey  <tromey@adacore.com>
6230
6231         PR symtab/23331:
6232         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6233
6234 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6235             Pedro Alves  <palves@redhat.com>
6236
6237         * top.c (quit_force): Call 'finalize_values'.
6238         * value.c (finalize_values): New function.
6239         * value.h (finalize_values): Declare.
6240
6241 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6242
6243         * NEWS: Announce $_gdb_major and $_gdb_minor.
6244
6245         * top.c (init_gdb_version_vars): New function.
6246         (gdb_init): Call init_gdb_version_vars.
6247
6248 2019-03-29  Tom Tromey  <tromey@adacore.com>
6249
6250         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6251         help text.  Remove dead code.
6252
6253 2019-03-29  Keith Seitz  <keiths@redhat.com>
6254
6255         From Siddhesh Poyarekar:
6256         * f-lang.h (f77_get_upperbound): Return LONGEST.
6257         (f77_get_lowerbound): Likewise.
6258         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6259         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6260         print them.
6261         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6262         plongest to format print it.
6263         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6264         (f77_get_upperbound): Likewise.
6265         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6266         LOWER_BOUND to LONGEST.
6267         (f77_create_arrayprint_offset_tbl): Likewise.
6268
6269 2019-03-29  Keith Seitz  <keiths@redhat.com>
6270
6271         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6272         %s/pulongest for TYPE_LENGTH instead of %d in format
6273         strings.
6274         * ada-typerint.c (ada_print_type): Likewise.
6275         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6276         * compile/compile-c-support.c (generate_register_struct): Likewise.
6277         * gdbtypes.c (recursive_dump_type): Likewise.
6278         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6279         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6280         instead of %d in format strings.
6281         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6282         to std::min to ULONGEST.
6283         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6284         instead of %d in format strings.
6285         * tracepoint.c (info_scope_command): Likewise.
6286         * typeprint.c (print_offset_data::update)
6287         (print_offset_data::finish): Likewise.
6288         * xtensa-tdep.c (xtensa_store_return_value)
6289         (xtensa_push_dummy_call): Likewise.
6290
6291 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6292
6293         * windows-nat.c (display_selector): Fixed format specifications
6294         for 64-bit Cygwin.
6295
6296 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6297
6298         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6299
6300 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6301
6302         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6303         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6304         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6305         (nios2_linux_init_abi): Install it.
6306
6307 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6308
6309         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6310
6311 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6312
6313         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6314
6315 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6316             Tom Tromey  <tromey@adacore.com>
6317
6318         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6319
6320 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6321
6322         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6323         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6324         method to compute the bounds of range types. Also print "[evaluated]"
6325         if the bounds' values come from a dynamic evaluation.
6326
6327 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6328
6329         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6330         whitespace when pretty printing is on.
6331
6332 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6333
6334         * ppc-linux-nat.c: Add include.
6335
6336 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6337
6338         * NEWS: Mention AArch64 Pointer Authentication.
6339
6340 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6341
6342         * arm-linux-nat.c: Add include.
6343
6344 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6345
6346         * source-cache.c (source_cache::get_source_lines): Re-read
6347         fullname after calling open_source_file.
6348
6349 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6350
6351         * NEWS: Mention TLS support for FreeBSD.
6352
6353 2019-03-25  Tom Tromey  <tromey@adacore.com>
6354
6355         * minsyms.c (BUNCH_SIZE): Update comment.
6356         (~minimal_symbol_reader): Remove old comment.
6357         (compact_minimal_symbols): Update comment.
6358         (minimal_symbol_reader::install): Remove old comment.  Update
6359         other comments.
6360
6361 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6362
6363         * s390-linux-nat.c: Add include.
6364
6365 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6366
6367         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6368         Call linux_get_hwcap.
6369         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6370         Likewise.
6371         (aarch64_linux_get_hwcap): Remove function.
6372         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6373         declaration.
6374         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6375         linux_get_hwcap.
6376         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6377         * linux-tdep.c (linux_get_hwcap): Add function.
6378         (linux_get_hwcap2): Likewise.
6379         * linux-tdep.h (linux_get_hwcap): Add declaration.
6380         (linux_get_hwcap2): Likewise.
6381         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6382         (ppc_linux_get_hwcap2): Likewise.
6383         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6384         linux_get_hwcap.
6385         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6386         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6387         (ppc_linux_nat_target::read_description): Likewise.
6388         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6389         * s390-linux-nat.c: Likewise.
6390         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6391
6392 2019-03-24  Tom Tromey  <tom@tromey.com>
6393
6394         * ada-lang.c (standard_lookup): Simplify initialization.
6395         (ada_lookup_symbol_nonlocal): Simplify return.
6396         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6397         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6398         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6399         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6400         initialization.
6401         * solib.c (solib_global_lookup): Simplify.
6402         * symtab.c (null_block_symbol): Remove.
6403         (symbol_cache_lookup): Simplify returns.
6404         (lookup_language_this): Simplify returns.
6405         (lookup_symbol_aux): Simplify return.
6406         (lookup_local_symbol): Simplify returns.
6407         (lookup_global_symbol_from_objfile): Simplify return.
6408         (lookup_symbol_in_objfile_symtabs)
6409         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6410         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6411         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6412         * cp-namespace.c (cp_lookup_bare_symbol)
6413         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6414         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6415         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6416         (cp_lookup_symbol_via_imports): Simplify initialization.
6417         (find_symbol_in_baseclass): Likewise.
6418         * symtab.h (null_block_symbol): Remove.
6419         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6420         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6421         (d_lookup_symbol_module): Likewise.
6422         (find_symbol_in_baseclass): Simplify initialization.
6423
6424 2019-03-24  Tom Tromey  <tom@tromey.com>
6425
6426         * expression.h: Don't include symtab.h.
6427         (struct block): Forward declare.
6428
6429 2019-03-24  Tom Tromey  <tom@tromey.com>
6430
6431         * c-exp.y (typebase): Remove casts.
6432         * gdbtypes.c (lookup_unsigned_typename, )
6433         (lookup_signed_typename): Remove cast.
6434         * eval.c (parse_to_comma_and_eval): Remove cast.
6435         * parse.c (write_dollar_variable): Remove cast.
6436         * block.h (struct block) <superblock>: Now const.
6437         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6438         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6439         (map_block): Make "block" const.
6440         * symfile.h (struct quick_symbol_functions)
6441         <map_matching_symbols>: Constify block argument to "callback".
6442         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6443         const.
6444         (find_pc_sect_compunit_symtab): Make "b" const.
6445         (find_symbol_at_address): Likewise.
6446         (search_symbols): Likewise.
6447         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6448         (dw2_debug_names_lookup_symbol): Likewise.
6449         (dw2_map_matching_symbols): Update.
6450         * p-valprint.c (pascal_val_print): Remove "block".
6451         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6452         (aux_add_nonlocal_symbols): Make "block" const.
6453         (resolve_subexp): Remove cast.
6454         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6455         const.
6456         (iterate_over_file_blocks): Likewise.
6457         * f-exp.y (%union) <bval>: Remove.
6458         * coffread.c (patch_opaque_types): Make "b" const.
6459         * spu-tdep.c (spu_catch_start): Make "block" const.
6460         * c-valprint.c (print_unpacked_pointer): Remove "block".
6461         * symmisc.c (dump_symtab_1): Make "b" const.
6462         (block_depth): Make "block" const.
6463         * d-exp.y (%union) <bval>: Remove.
6464         * cp-support.h (cp_lookup_rtti_type): Update.
6465         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6466         * psymtab.c (psym_lookup_symbol): Make "block" const.
6467         (maintenance_check_psymtabs): Make "b" const.
6468         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6469         (enumerate_locals, enumerate_args): Update.
6470         * python/py-symtab.c (stpy_global_block): Make "block" const.
6471         (stpy_static_block): Likewise.
6472         * inline-frame.c (block_starting_point_at): Make "new_block"
6473         const.
6474         * block.c (find_block_in_blockvector): Make return type const.
6475         (blockvector_for_pc_sect): Make "b" const.
6476         (find_block_in_blockvector): Make "b" const.
6477
6478 2019-03-23  Tom Tromey  <tom@tromey.com>
6479
6480         * varobj.c (varobj_create): Update.
6481         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6482         * printcmd.c (display_command, do_one_display): Don't reset
6483         innermost_block.
6484         * parser-defs.h (enum innermost_block_tracker_type): Move to
6485         expression.h.
6486         (innermost_block): Update comment.
6487         * parse.c (parse_exp_1): Add tracker_types parameter.
6488         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6489         tracker_types parameter.  Reset innermost_block.
6490         (parse_exp_in_context): Remove.
6491         (parse_expression_for_completion): Update.
6492         * objfiles.c (~objfile): Don't reset expression_context_block or
6493         innermost_block.
6494         * expression.h (enum innermost_block_tracker_type): Move from
6495         parser-defs.h.
6496         (parse_exp_1): Add tracker_types parameter.
6497         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6498         reset innermost_block.
6499
6500 2019-03-23  Tom Tromey  <tom@tromey.com>
6501
6502         * objfiles.h: Include bcache.h.
6503
6504 2019-03-23  Tom Tromey  <tom@tromey.com>
6505
6506         * linespec.c (get_current_search_block): Use
6507         scoped_restore_current_language.
6508         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6509
6510 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6511             Jiong Wang  <jiong.wang@arm.com>
6512
6513         * aarch64-linux-tdep.c
6514         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6515         section.
6516         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6517
6518 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6519             Jiong Wang  <jiong.wang@arm.com>
6520
6521         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6522         instructions.
6523         (aarch64_analyze_prologue_test): Add PACIASP test.
6524         (aarch64_prologue_prev_register): Unmask PC value.
6525
6526 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6527             Jiong Wang  <jiong.wang@arm.com>
6528
6529         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6530         (aarch64_dwarf2_prev_register): Unmask PC value.
6531         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6532         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6533         DW_CFA_AARCH64_negate_ra_state.
6534         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6535
6536 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6537             Jiong Wang  <jiong.wang@arm.com>
6538
6539         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6540         registers.
6541         (aarch64_pseudo_register_name): Likewise.
6542         (aarch64_pseudo_register_type): Likewise.
6543         (aarch64_pseudo_register_reggroup_p): Likewise.
6544         (aarch64_gdbarch_init): Add pauth registers.
6545         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6546         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6547         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6548         (struct gdbarch_tdep): Add regnum for ra_state.
6549
6550 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6551             Jiong Wang  <jiong.wang@arm.com>
6552
6553         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6554
6555 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6556             Jiong Wang  <jiong.wang@arm.com>
6557
6558         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6559         function.
6560         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6561         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6562         (aarch64_gdbarch_init): Add puth registers.
6563         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6564         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6565         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6566
6567 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6568             Jiong Wang  <jiong.wang@arm.com>
6569
6570         * aarch64-linux-nat.c
6571         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6572         * aarch64-linux-tdep.c
6573         (aarch64_linux_core_read_description): Likewise.
6574         (aarch64_linux_get_hwcap): New function.
6575         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6576         (aarch64_linux_get_hwcap): New declaration.
6577
6578 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6579             Jiong Wang  <jiong.wang@arm.com>
6580
6581         * aarch64-linux-nat.c
6582         (aarch64_linux_nat_target::read_description): Add pauth param.
6583         * aarch64-linux-tdep.c
6584         (aarch64_linux_core_read_description): Likewise.
6585         * aarch64-tdep.c (struct target_desc): Add in pauth.
6586         (aarch64_read_description): Add pauth param.
6587         (aarch64_gdbarch_init): Likewise.
6588         * aarch64-tdep.h (aarch64_read_description): Likewise.
6589         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6590         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6591         * features/Makefile: Add new files.
6592         * features/aarch64-pauth.c: New file.
6593         * features/aarch64-pauth.xml: New file.
6594
6595 2019-03-20  Tom Tromey  <tromey@adacore.com>
6596
6597         * infrun.c (handle_inferior_event): Rename from
6598         handle_inferior_event_1.  Create a scoped_value_mark.
6599         (handle_inferior_event): Remove.
6600
6601 2019-03-19  Tom Tromey  <tromey@adacore.com>
6602
6603         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6604         * infrun.h (print_stop_event): Add "displays" parameter.
6605         * infrun.c (print_stop_event): Add "displays" parameter.
6606
6607 2019-03-19  Pedro Alves  <palves@redhat.com>
6608
6609         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6610         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6611         to -1.  Fix TABs vs spaces.
6612         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6613         * tui/tui-out.h (tui_ui_out) Add intro comments.
6614         <m_line, m_start_of_line>: In-class initialize, and add describing
6615         comment.
6616
6617 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6618
6619         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6620         variable names.
6621         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6622
6623 2019-03-18  Pedro Alves  <palves@redhat.com>
6624             Eli Zaretskii <eliz@gnu.org>
6625
6626         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6627         m_line and m_start_of_line.
6628
6629 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6630
6631         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6632         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6633         it returns a newline.  This fixes a regression in TU mode, whereby
6634         the next line is output on the same screen line as the user input.
6635
6636 2019-03-18  Tom Tromey  <tromey@adacore.com>
6637
6638         * minsyms.c (minimal_symbol_reader::install): Remove call to
6639         obstack_blank.
6640
6641 2019-03-18  Pedro Alves  <palves@redhat.com>
6642
6643         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6644         New globals.
6645         (apply_style): New, factored out from ...
6646         (apply_ansi_escape): ... this.  Handle reverse video mode.
6647         (tui_set_reverse_mode): New function.
6648         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6649         * tui/tui-winsource.c (tui_show_source_line): Use
6650         tui_set_reverse_mode instead of setting A_STANDOUT.
6651         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6652         New setter methods.
6653
6654 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6655
6656         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6657         Handle tabs.
6658
6659 2019-03-18  Tom Tromey  <tromey@adacore.com>
6660
6661         * ada-lang.c (empty_array): Add "high" parameter.
6662         (ada_evaluate_subexp): Update.
6663
6664 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6665
6666         * unittests/string_view-selftests.c: Define
6667         _initialize_string_view_selftests unconditionally.
6668
6669 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6670
6671         PR gdb/24350
6672         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6673
6674 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6675
6676         PR gdb/24351
6677         * windows-nat.c (display_selector): Fix format specifiers.
6678
6679 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6680
6681         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6682         tui_refill_source_window instead of tui_refresh_win, to update the
6683         current execution line.  This fixes redisplay of the current line
6684         when stepping through the code with "next" or "step".
6685
6686 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6687
6688         * source-cache.c (source_cache::get_source_lines): Call
6689         find_source_lines to initialize s->nlines.  This fixes vertical
6690         scrolling of TUI source window when the DOWN arrow is pressed.
6691
6692 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6693
6694         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6695         linux-thread-db.c (_initialize_thread_db): Likewise.
6696
6697 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6698
6699         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6700         wclrtoeol in tui_show_source_line".  This reverts changes made in
6701         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6702
6703 2019-03-15  Tom Tromey  <tom@tromey.com>
6704
6705         * symtab.h (struct minimal_symbol): Derive from
6706         general_symbol_info.
6707         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6708         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6709         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6710         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6711         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6712         (MSYMBOL_SEARCH_NAME): Update.
6713         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6714         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6715         * minsyms.c (minimal_symbol_reader::record_full): Update.
6716
6717 2019-03-15  Tom Tromey  <tom@tromey.com>
6718
6719         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6720
6721 2019-03-15  Tom Tromey  <tom@tromey.com>
6722
6723         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6724         unique_xmalloc_ptr.
6725         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6726         Update.
6727         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6728         (build_minimal_symbol_hash_tables)
6729         (minimal_symbol_reader::install): Update.
6730
6731 2019-03-15  Tom Tromey  <tom@tromey.com>
6732
6733         * symtab.c (create_demangled_names_hash): Update.
6734         (symbol_set_names): Update.
6735         * objfiles.h (struct objfile_per_bfd_storage)
6736         <demangled_names_hash>: Now an htab_up.
6737         * objfiles.c (objfile_per_bfd_storage): Simplify.
6738
6739 2019-03-15  Tom Tromey  <tom@tromey.com>
6740
6741         * objfiles.h (struct objfile_per_bfd_storage): Declare
6742         destructor.
6743         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6744         New.
6745         (get_objfile_bfd_data): Use new.  Don't initialize
6746         language_of_main.
6747         (free_objfile_per_bfd_storage): Remove.
6748         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6749
6750 2019-03-15  Tom Tromey  <tom@tromey.com>
6751
6752         * symfile.c (reread_symbols): Update.
6753         * objfiles.c (objfile::objfile): Update.
6754         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6755         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6756         comment.
6757         (minimal_symbol_reader::install): Update.
6758         (terminate_minimal_symbol_table): Remove.
6759         * jit.c (jit_object_close_impl): Update.
6760
6761 2019-03-15  Tom Tromey  <tom@tromey.com>
6762
6763         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6764         initializations.
6765
6766 2019-03-15  Tom Tromey  <tom@tromey.com>
6767
6768         * objfiles.h (struct objfile_per_bfd_storage)
6769         <demangled_hash_languages>: Now a bitset.
6770         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6771         (lookup_minimal_symbol): Update.
6772
6773 2019-03-15  Tom Tromey  <tom@tromey.com>
6774
6775         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6776         Don't return the symbol.
6777         * coffread.c (record_minimal_symbol): Use record_full.
6778
6779 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6780
6781         The MS-Windows port of ncurses fails to switch to a color pair if
6782         one or both of the colors are the implicit default colors.  This
6783         change records the default colors when TUI is initialized, and
6784         then specifies them explicitly when a color pair uses the default
6785         colors.  This allows color styling in TUI mode on MS-Windows.
6786
6787         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6788         ncurses_norm_attr.
6789         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6790         colors in ncurses_norm_attr.
6791         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6792         "none", replace it with the default color recorded in
6793         ncurses_norm_attr.
6794
6795 2019-03-14  Tom Tromey  <tromey@adacore.com>
6796
6797         * source-cache.h (class source_cache) <get_source_lines>: Return
6798         std::string.
6799         * source-cache.c (source_cache::extract_lines): Handle case where
6800         first_pos==npos.  Return std::string.
6801         (source_cache::get_source_lines): Update.
6802
6803 2019-03-14  Tom Tromey  <tromey@adacore.com>
6804
6805         * NEWS: Add item for "style sources" commands.
6806         * source-cache.c (source_cache::get_source_lines): Check
6807         source_styling.
6808         * cli/cli-style.c (source_styling): New global.
6809         (_initialize_cli_style): Add "style sources" commands.
6810         (show_style_sources): New function.
6811         * cli/cli-style.h (source_styling): Declare.
6812
6813 2019-03-14  Pedro Alves  <palves@redhat.com>
6814             Tom Tromey  <tromey@adacore.com>
6815
6816         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6817         * tui/tui-winsource.c (tui_refill_source_window): New function,
6818         from...
6819         (tui_horizontal_source_scroll): ... here.  Move some logic.
6820         * cli/cli-style.c (set_style_enabled): Notify new observable.
6821         * tui/tui-hooks.c (tui_redisplay_source): New function.
6822         (tui_attach_detach_observers): Attach or detach
6823         tui_redisplay_source.
6824         * observable.h (source_styling_changed): New observable.
6825         * observable.c: Define source_styling_changed observable.
6826
6827 2019-03-13  Tom Tromey  <tromey@adacore.com>
6828
6829         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6830         (i386_gnu_nat_target::store_registers): Update.
6831         * target-debug.h (target_debug_print_std_string): New macro.
6832         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6833         * windows-tdep.c (display_one_tib): Update.
6834         * tui/tui-stack.c (tui_make_status_line): Update.
6835         * top.c (print_inferior_quit_action): Update.
6836         * thread.c (thr_try_catch_cmd): Update.
6837         (add_thread_with_info): Update.
6838         (thread_target_id_str): Update.
6839         (thr_try_catch_cmd): Update.
6840         (thread_command): Update.
6841         (thread_find_command): Update.
6842         * record-btrace.c (record_btrace_target::info_record)
6843         (record_btrace_resume_thread, record_btrace_target::resume)
6844         (record_btrace_cancel_resume, record_btrace_step_thread)
6845         (record_btrace_target::wait, record_btrace_target::wait)
6846         (record_btrace_target::wait, record_btrace_target::stop): Update.
6847         * progspace.c (print_program_space): Update.
6848         * process-stratum-target.c
6849         (process_stratum_target::thread_address_space): Update.
6850         * linux-fork.c (linux_fork_mourn_inferior)
6851         (detach_checkpoint_command, info_checkpoints_command)
6852         (linux_fork_context): Update.
6853         (linux_fork_detach): Update.
6854         (class scoped_switch_fork_info): Update.
6855         (delete_checkpoint_command): Update.
6856         * infrun.c (follow_fork_inferior): Update.
6857         (follow_fork_inferior): Update.
6858         (proceed_after_vfork_done): Update.
6859         (handle_vfork_child_exec_or_exit): Update.
6860         (follow_exec): Update.
6861         (displaced_step_prepare_throw): Update.
6862         (displaced_step_restore): Update.
6863         (start_step_over): Update.
6864         (resume_1): Update.
6865         (clear_proceed_status_thread): Update.
6866         (proceed): Update.
6867         (print_target_wait_results): Update.
6868         (do_target_wait): Update.
6869         (context_switch): Update.
6870         (stop_all_threads): Update.
6871         (restart_threads): Update.
6872         (finish_step_over): Update.
6873         (handle_signal_stop): Update.
6874         (switch_back_to_stepped_thread): Update.
6875         (keep_going_pass_signal): Update.
6876         (print_exited_reason): Update.
6877         (normal_stop): Update.
6878         * inferior.c (inferior_pid_to_str): Change return type.
6879         (print_selected_inferior): Update.
6880         (add_inferior): Update.
6881         (detach_inferior): Update.
6882         * dummy-frame.c (fprint_dummy_frames): Update.
6883         * dcache.c (dcache_info_1): Update.
6884         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6885         (btrace_fetch, btrace_clear): Update.
6886         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6887         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6888         type.
6889         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6890         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6891         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6892         * gdbarch.c, gdbarch.h: Rebuild.
6893         * gdbarch.sh (core_pid_to_str): Change return type.
6894         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6895         return type.
6896         (windows_nat_target::pid_to_str): Change return type.
6897         (windows_delete_thread): Update.
6898         (windows_nat_target::attach): Update.
6899         (windows_nat_target::files_info): Update.
6900         * target-delegates.c: Rebuild.
6901         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6902         return type.
6903         (sol_thread_target::pid_to_str): Change return type.
6904         * remote.c (class remote_target) <pid_to_str>: Change return
6905         type.
6906         (remote_target::pid_to_str): Change return type.
6907         (extended_remote_target::attach, remote_target::remote_stop_ns)
6908         (remote_target::remote_notif_remove_queued_reply)
6909         (remote_target::push_stop_reply, remote_target::disable_btrace):
6910         Update.
6911         (extended_remote_target::attach): Update.
6912         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6913         type.
6914         (gdbsim_target::pid_to_str): Change return type.
6915         * ravenscar-thread.c (struct ravenscar_thread_target)
6916         <pid_to_str>: Change return type.
6917         (ravenscar_thread_target::pid_to_str): Change return type.
6918         * procfs.c (class procfs_target) <pid_to_str>: Change return
6919         type.
6920         (procfs_target::pid_to_str): Change return type.
6921         (procfs_target::attach): Update.
6922         (procfs_target::detach): Update.
6923         (procfs_target::fetch_registers): Update.
6924         (procfs_target::store_registers): Update.
6925         (procfs_target::wait): Update.
6926         (procfs_target::files_info): Update.
6927         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6928         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6929         return type.
6930         (nto_procfs_target::pid_to_str): Change return type.
6931         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6932         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6933         return type.
6934         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6935         (exit_lwp): Update.
6936         (attach_proc_task_lwp_callback, get_detach_signal)
6937         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6938         (linux_nat_target::resume, wait_lwp, stop_callback)
6939         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6940         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6941         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6942         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6943         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6944         type.
6945         (inf_ptrace_target::attach): Update.
6946         (inf_ptrace_target::files_info): Update.
6947         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6948         type.
6949         (go32_nat_target::pid_to_str): Change return type.
6950         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6951         (gnu_nat_target::wait): Update.
6952         (gnu_nat_target::wait): Update.
6953         (gnu_nat_target::resume): Update.
6954         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6955         (fbsd_nat_target::wait): Update.
6956         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6957         type.
6958         (darwin_nat_target::attach): Update.
6959         * corelow.c (class core_target) <pid_to_str>: Change return type.
6960         (core_target::pid_to_str): Change return type.
6961         * target.c (normal_pid_to_str): Change return type.
6962         (default_pid_to_str): Likewise.
6963         (target_pid_to_str): Change return type.
6964         (target_translate_tls_address): Update.
6965         (target_announce_detach): Update.
6966         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6967         return type.
6968         (bsd_uthread_target::pid_to_str): Change return type.
6969         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6970         type.
6971         (bsd_kvm_target::pid_to_str): Change return type.
6972         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6973         return type.
6974         (aix_thread_target::pid_to_str): Change return type.
6975         * target.h (struct target_ops) <pid_to_str>: Change return type.
6976         (target_pid_to_str, normal_pid_to_str): Likewise.
6977         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6978         type.
6979         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6980         type.
6981         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6982         return type.
6983         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6984         type.
6985         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6986         type.
6987         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6988         return type.
6989
6990 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6991
6992         * NEWS: Mention that the new default MI version is 3.  Mention
6993         changes to the output of commands and events that deal with
6994         multi-location breakpoints.
6995         * breakpoint.c: Include "mi/mi-out.h".
6996         (print_one_breakpoint): Change output syntax if using MI version
6997         >= 3.
6998         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6999         New.
7000         (mi_multi_location_breakpoint_output_fixed): New.
7001         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7002         (mi_cmd_fix_multi_location_breakpoint_output): New.
7003         (mi_multi_location_breakpoint_output_fixed): New.
7004         * mi/mi-cmds.c (mi_cmds): Register command
7005         -fix-multi-location-breakpoint-output.
7006         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7007         interpreter "mi".
7008
7009 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7010
7011         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7012         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7013         instantiate mi_ui_out based on interpreter name.
7014         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7015         * mi/mi-main.c (mi_load_progress): Likewise.
7016
7017 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7018
7019         * NEWS: Combine separate "New targets" sections for 8.3.
7020
7021 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7022
7023         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7024         (ppcfbsd_init_abi): Install gdbarch
7025         "fetch_tls_load_module_address" and "get_thread_local_address"
7026         methods.
7027
7028 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7029
7030         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7031         (riscv_fbsd_init_abi): Install gdbarch
7032         "fetch_tls_load_module_address" and "get_thread_local_address"
7033         methods.
7034
7035 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7036
7037         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7038         (i386fbsd_init_abi): Install gdbarch
7039         "fetch_tls_load_module_address" and "get_thread_local_address"
7040         methods.
7041
7042 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7043
7044         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7045         (amd64fbsd_init_abi): Install gdbarch
7046         "fetch_tls_load_module_address" and "get_thread_local_address"
7047         methods.
7048
7049 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7050
7051         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7052         (struct fbsd_pspace_data): New type.
7053         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7054         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7055         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7056         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7057         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7058
7059 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7060
7061         * gdbtypes.c (lookup_struct_elt): New function.
7062         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7063         * gdbtypes.h (struct struct_elt): New type.
7064         (lookup_struct_elt): New prototype.
7065
7066 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7067
7068         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7069         remove disabled code block.
7070
7071 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7072
7073         * gdbarch.sh (get_thread_local_address): New method.
7074         * gdbarch.h, gdbarch.c: Regenerate.
7075         * target.c (target_translate_tls_address): Use
7076         gdbarch_get_thread_local_address if present instead of
7077         target::get_thread_local_address.
7078
7079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7080
7081         * target.h (target::get_thread_local_address): Update comment.
7082
7083 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7084
7085         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7086         objfile->separate_debug_objfile_backlink if not NULL.
7087
7088 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7089
7090         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7091         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7092         (amd64bsd_store_inferior_registers): Likewise.
7093         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7094         Enable segment base registers.
7095         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7096         PT_GETFSBASE and PT_GETGSBASE.
7097         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7098         PT_SETGSBASE.
7099         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7100         segment base registers.
7101         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7102
7103 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7104
7105         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7106         Update calls to i386_target_description to add 'segments'
7107         parameter.
7108         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7109         add segment base registers.
7110         * arch/i386.c (i386_create_target_description): Add 'segments'
7111         parameter to enable segment base registers.
7112         * arch/i386.h (i386_create_target_description): Likewise.
7113         * features/i386/32bit-segments.xml: New file.
7114         * features/i386/32bit-segments.c: Generate.
7115         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7116         call to i386_target_description to add 'segments' parameter.
7117         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7118         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7119         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7120         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7121         if feature is present.
7122         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7123         Add 'segments' parameter to call to i386_target_description.
7124         (i386_target_description): Add 'segments' parameter to enable
7125         segment base registers.
7126         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7127         to call to i386_target_description.
7128         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7129         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7130         Define I386_NUM_REGS.
7131         (i386_target_description): Add 'segments' parameter to enable
7132         segment base registers.
7133
7134 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7135
7136         PR/24325
7137         * source-cache.c: #undef open and close, to avoid unresolved
7138         externals during linking.
7139
7140 2019-03-12  Tom Tromey  <tromey@adacore.com>
7141
7142         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7143         const.  Add initializers.
7144         (_initialize_remote): Don't initialize ptid globals.
7145
7146 2019-03-12  Pedro Alves  <palves@redhat.com>
7147
7148         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7149
7150 2019-03-12  Pedro Alves  <palves@redhat.com>
7151
7152         * cp-name-parser.y (main): Remove unused 'len' variable.
7153
7154 2019-03-12  Tom Tromey  <tromey@adacore.com>
7155
7156         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7157         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7158
7159 2019-03-12  Tom Tromey  <tromey@adacore.com>
7160
7161         * linux-nat.c (iterate_over_lwps): Update.
7162         (stop_callback): Remove parameter.
7163         (stop_wait_callback, detach_callback, resume_set_callback)
7164         (select_singlestep_lwp_callback, set_ignore_sigint)
7165         (status_callback, resumed_callback, resume_clear_callback)
7166         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7167         data parameter.
7168         (linux_nat_target::detach, linux_nat_target::resume)
7169         (linux_stop_and_wait_all_lwps, select_event_lwp)
7170         (linux_nat_filter_event, linux_nat_wait_1)
7171         (linux_nat_target::kill, linux_nat_target::stop)
7172         (linux_nat_target::stop): Update.
7173         (linux_nat_resume_callback): Change type.
7174         (resume_stopped_resumed_lwps, count_events_callback)
7175         (select_event_lwp_callback): Likewise.
7176         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7177         * arm-linux-nat.c (struct update_registers_data): Remove.
7178         (update_registers_callback): Change type.
7179         (arm_linux_insert_hw_breakpoint1): Update.
7180         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7181         parameter.
7182         (x86_linux_dr_set_addr): Update.
7183         (x86_linux_dr_set_control): Update.
7184         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7185         (iterate_over_lwps): Use gdb::function_view.
7186         * nat/aarch64-linux-hw-point.c (struct
7187         aarch64_dr_update_callback_param): Remove.
7188         (debug_reg_change_callback): Change type.
7189         (aarch64_notify_debug_reg_change): Update.
7190         * s390-linux-nat.c (s390_refresh_per_info): Update.
7191
7192 2019-03-11  Tom Tromey  <tromey@adacore.com>
7193
7194         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7195         redundant assignment to "this_cu".
7196
7197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7198
7199         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7200
7201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7202
7203         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7204         from...
7205         (rank_one_type): ... this.
7206
7207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7208
7209         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7210         from...
7211         (rank_one_type): ... this.
7212
7213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7214
7215         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7216         from...
7217         (rank_one_type): ... this.
7218
7219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7220
7221         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7222         from...
7223         (rank_one_type): ... this.
7224
7225 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7226
7227         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7228         from...
7229         (rank_one_type): ... this.
7230
7231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7232
7233         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7234         from...
7235         (rank_one_type): ... this.
7236
7237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7238
7239         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7240         from...
7241         (rank_one_type): ... this.
7242
7243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7244
7245         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7246         from...
7247         (rank_one_type): ... this.
7248
7249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7250
7251         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7252         from...
7253         (rank_one_type): ... this.
7254
7255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7256
7257         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7258         from...
7259         (rank_one_type): ... this.
7260
7261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7262
7263         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7264         from...
7265         (rank_one_type): ... this.
7266
7267 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7268
7269         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7270         from...
7271         (rank_one_type): ... this.
7272
7273 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7274
7275         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7276         inferior-events' shows the example events.
7277
7278 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7279
7280         Support styling on native MS-Windows console
7281
7282         PR/24315
7283         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7284         on MS-Windows if $TERM is not defined.
7285
7286         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7287
7288         * posix-hdep.c (gdb_console_fputs):
7289         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7290         functions.
7291         * ui-file.h (gdb_console_fputs): Add prototype.
7292
7293         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7294         back to fputs only if the former returns zero.
7295
7296 2019-03-07  Tom Tromey  <tom@tromey.com>
7297
7298         * symmisc.c (print_symbol_bcache_statistics): Update.
7299         (print_objfile_statistics): Update.
7300         * symfile.c (allocate_symtab): Update.
7301         * stabsread.c: Don't include bcache.h.
7302         * psymtab.h (struct psymbol_bcache): Don't declare.
7303         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7304         (psymbol_bcache_init, psymbol_bcache_free)
7305         (psymbol_bcache_get_bcache): Don't declare.
7306         * psymtab.c (struct psymbol_bcache): Remove.
7307         (psymtab_storage::psymtab_storage): Update.
7308         (psymtab_storage::~psymtab_storage): Update.
7309         (psymbol_bcache_init, psymbol_bcache_free)
7310         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7311         (add_psymbol_to_bcache): Update.
7312         (allocate_psymtab): Update.
7313         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7314         macro_cache>: No longer pointers.
7315         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7316         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7317         * macrotab.c (macro_bcache): Update.
7318         * macroexp.c: Don't include bcache.h.
7319         * gdbtypes.c (check_types_worklist): Update.
7320         (types_deeply_equal): Remove TRY/CATCH.  Update.
7321         * elfread.c (elf_symtab_read): Update.
7322         * dwarf2read.c: Don't include bcache.h.
7323         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7324         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7325         (print_bcache_statistics, bcache_memory_used): Don't declare.
7326         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7327         methods.  Rename all data members.
7328         * bcache.c (struct bcache): Move to bcache.h.
7329         (bcache::expand_hash_table): Rename from expand_hash_table.
7330         (bcache): Remove.
7331         (bcache::insert): Rename from bcache_full.
7332         (bcache::compare): Rename from bcache_compare.
7333         (bcache_xmalloc): Remove.
7334         (bcache::~bcache): Rename from bcache_xfree.
7335         (bcache::print_statistics): Rename from print_bcache_statistics.
7336         (bcache::memory_used): Rename from bcache_memory_used.
7337
7338 2019-03-07  Pedro Alves  <palves@redhat.com>
7339
7340         * infrun.c (normal_stop): Also check for
7341         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7342
7343 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7344
7345         * f-lang.c (value_from_host_double): Moved to...
7346         * value.c (value_from_host_double): ...here.
7347         * value.h (value_from_host_double): Declare.
7348         * guile/scm-math.c (vlscm_convert_typed_number): Use
7349         value_from_host_double.
7350         (vlscm_convert_number): Likewise.
7351         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7352         * python/py-value.c (convert_value_from_python): Likewise.
7353
7354 2019-03-06  Tom Tromey  <tom@tromey.com>
7355
7356         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7357
7358 2019-03-06  Tom Tromey  <tom@tromey.com>
7359
7360         * utils.h (free_current_contents): Don't declare.
7361         * utils.c (free_current_contents): Remove.
7362
7363 2019-03-06  Tom Tromey  <tom@tromey.com>
7364
7365         * top.c (quit_force): Update.
7366         * main.c (captured_command_loop): Update.
7367         * common/new-op.c (operator new): Update.
7368         * common/common-exceptions.c (struct catcher)
7369         <save_cleanup_chain>: Remove member.
7370         (exceptions_state_mc_init): Update.
7371         (exception_try_scope_entry): Return nullptr.
7372         (exception_try_scope_exit, exception_rethrow)
7373         (throw_exception_sjlj, throw_exception_cxx): Update.
7374         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7375         (all_cleanups, do_cleanups, discard_cleanups)
7376         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7377         (restore_cleanups, restore_final_cleanups): Don't declare.
7378         (do_final_cleanups): Remove parameter.
7379         * common/cleanups.c (cleanup_chain, make_cleanup)
7380         (make_cleanup_dtor, all_cleanups, do_cleanups)
7381         (discard_my_cleanups, discard_cleanups)
7382         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7383         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7384         (null_cleanup): Remove.
7385         (do_final_cleanups): Remove parameter.
7386
7387 2019-03-06  Tom Tromey  <tom@tromey.com>
7388
7389         * remote.c (remote_target::remote_parse_stop_reply): Use
7390         unique_xmalloc_ptr.
7391
7392 2019-03-06  Tom Tromey  <tom@tromey.com>
7393
7394         * stabsread.c (struct stabs_field_info): Rename from field_info.
7395         <list, fnlist>: Add initializers.
7396         <obstack>: New member.
7397         (read_member_functions, read_struct_fields, read_baseclasses):
7398         Allocate on obstack.  Don't use cleanups.
7399         (read_one_struct_field, read_member_functions, read_struct_fields)
7400         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7401         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7402         (read_struct_type): Update.
7403
7404 2019-03-06  Tom Tromey  <tom@tromey.com>
7405
7406         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7407         * common/filestuff.h (make_cleanup_close): Don't declare.
7408         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7409         Remove.
7410
7411 2019-03-06  Tom Tromey  <tom@tromey.com>
7412
7413         * solib-aix.c: Use make_scope_exit.
7414
7415 2019-03-06  Tom Tromey  <tom@tromey.com>
7416
7417         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7418         Use make_scope_exit.
7419
7420 2019-03-06  Tom Tromey  <tom@tromey.com>
7421
7422         * solib-svr4.c (disable_probes_interface): Remove parameter.
7423         (svr4_handle_solib_event): Use make_scope_exit.
7424
7425 2019-03-06  Tom Tromey  <tom@tromey.com>
7426
7427         * remote.c (struct stop_reply_deleter): Remove.
7428         (stop_reply_up): Update.
7429         (struct stop_reply): Derive from notif_event.  Don't typedef.
7430         <regcache>: Now a std::vector.
7431         (stop_reply_xfree): Remove.
7432         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7433         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7434         (remote_target::discard_pending_stop_replies): Use delete.
7435         (remote_target::remote_parse_stop_reply): Update.
7436         (remote_target::process_stop_reply): Update.
7437         * remote-notif.h (struct notif_event): Add virtual destructor.
7438         Remove "dtr" member.
7439         (struct notif_client) <alloc_event>: Return a unique_ptr.
7440         (notif_event_xfree): Don't declare.
7441         (notif_event_up): New typedef.
7442         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7443         (notif_event_xfree, do_notif_event_xfree): Remove.
7444         (remote_notif_state_xfree): Update.
7445
7446 2019-03-06  Tom Tromey  <tom@tromey.com>
7447
7448         * infrun.c (displaced_step_clear_cleanup): Now a
7449         forward_scope_exit type.
7450         (displaced_step_prepare_throw): Update.
7451         (displaced_step_fixup): Update.
7452
7453 2019-03-06  Tom Tromey  <tom@tromey.com>
7454
7455         * inferior.h (class inferior): Update comment.
7456         * gdbthread.h (class thread_info): Update comment.
7457
7458 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7459             Tom Tromey  <tom@tromey.com>
7460
7461         * stabsread.h (struct stab_section_list): Remove.
7462         (coffstab_build_psymtabs): Update.
7463         * dbxread.c (symbuf_sections): Now a std::vector.
7464         (sect_idx): New global.
7465         (fill_symbuf): Update.
7466         (coffstab_build_psymtabs): Change type of stabsects parameter.
7467         Update.
7468         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7469         std::vector.
7470         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7471         (coff_locate_sections): Update.
7472         (coff_symfile_read): Remove cleanups.  Update.
7473         (init_stringtab): Add storage parameter.
7474         (free_stringtab, free_stringtab_cleanup): Remove.
7475         (init_lineno): Add storage parameter.
7476         (free_linetab, free_linetab_cleanup): Remove.
7477
7478 2019-03-06  Pedro Alves  <palves@redhat.com>
7479
7480         * linux-fork.c (fork_info::clobber_regs): Delete.
7481         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7482         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7483         comment.  Adjust.
7484         (scoped_switch_fork_info::scoped_switch_fork_info)
7485         (checkpoint_command, linux_fork_context): Adjust
7486         fork_save_infrun_state calls.
7487
7488 2019-03-06  Pedro Alves  <palves@redhat.com>
7489
7490         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7491         (inf_has_multiple_threads): Return 'bool' and rewrite using
7492         inferior_info::threads().
7493
7494 2019-03-06  Pedro Alves  <palves@redhat.com>
7495
7496         * linux-fork.c: Include <list>.
7497         (fork_list): Now a std::list instance.
7498         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7499         (forks_exist_p, find_last_fork): Adjust.
7500         (new_fork): Delete.
7501         (one_fork_p): New.
7502         (add_fork): Adjust.
7503         (free_fork): Delete, folded into fork_info::~fork_info().
7504         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7505         Adjust.
7506         (init_fork_list): Delete.
7507         (linux_fork_killall, linux_fork_mourn_inferior)
7508         (linux_fork_detach, info_checkpoints_command): Adjust.
7509         (_initialize_linux_fork): No longer call init_fork_list.
7510
7511 2019-03-06  Pedro Alves  <palves@redhat.com>
7512
7513         * linux-fork.c (new_fork): New, split out of ...
7514         (add_fork): ... this.  Return void.  Move "first fork" special
7515         case from here, to ...
7516         (checkpoint_command): ... here.
7517         * linux-linux.h (add_fork): Return void.
7518
7519 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7520
7521         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7522
7523 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7524             Chris January  <chris.january@arm.com>
7525             David Lecomber  <david.lecomber@arm.com>
7526
7527         * f-exp.y: New token, UNOP_INTRINSIC.
7528         (exp): New pattern using UNOP_INTRINSIC token.
7529         (f77_keywords): Add 'abs' keyword.
7530         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7531         (value_from_host_double): New function.
7532         (evaluate_subexp_f): Support UNOP_ABS.
7533
7534 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7535
7536         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7537         types.
7538
7539 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7540
7541         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7542         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7543         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7544
7545 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7546
7547         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7548
7549 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7550             Chris January  <chris.january@arm.com>
7551
7552         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7553         * f-exp.y: Define 'KIND' token.
7554         (exp): New pattern for KIND expressions.
7555         (ptype): Handle types with a kind extension.
7556         (direct_abs_decl): Extend to spot kind extensions.
7557         (f77_keywords): Add 'kind' to the list.
7558         (push_kind_type): New function.
7559         (convert_to_kind_type): New function.
7560         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7561         * parse.c (operator_length_standard): Likewise.
7562         * parser-defs.h (enum type_pieces): Add tp_kind.
7563         * std-operator.def: Add UNOP_KIND.
7564
7565 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7566
7567         * f-exp.y (f_parse): Set yydebug.
7568
7569 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7570
7571         * f-lang.c (evaluate_subexp_f): New function.
7572         (exp_descriptor_f): New global.
7573         (f_language_defn): Use exp_descriptor_f instead of
7574         exp_descriptor_standard.
7575
7576 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7577
7578         * f-exp.y (struct token): Add comments.
7579         (dot_ops): Remove uppercase versions and the end marker.
7580         (f77_keywords): Likewise.
7581         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7582         entries in the dot_ops array are case insensitive, and use
7583         strncasecmp to compare strings.  Also some whitespace cleanup in
7584         this area.  Similar for the f77_keywords array, except entries in
7585         this list might be case sensitive.
7586
7587 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7588
7589         * f-exp.y (struct f77_boolean_val): Add comments.
7590         (boolean_values): Remove uppercase versions, and end marker.
7591         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7592         and use strncasecmp to achieve case insensitivity.  Additionally,
7593         perform whitespace cleanup around this code.
7594
7595 2019-03-06  Tom Tromey  <tromey@adacore.com>
7596
7597         * remote-sim.c (gdbsim_target_open): Use result of
7598         gdb_argv::release.
7599
7600 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7601         Dirk Schubert  <dirk.schubert@arm.com>
7602         Chris January  <chris.january@arm.com>
7603
7604         * eval.c (evaluate_subexp_standard): Call Fortran argument
7605         wrapping logic.
7606         * f-lang.c (struct value): A value which can be passed into a
7607         Fortran function call.
7608         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7609         where appropriate.
7610         (struct type): Value ready for a Fortran function call.
7611         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7612         is needed.
7613         * f-lang.h (fortran_argument_convert): Declaration.
7614         (fortran_preserve_arg_pointer): Declaration.
7615         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7616
7617 2019-03-05  Tom Tromey  <tromey@adacore.com>
7618
7619         * python/py-prettyprint.c (print_string_repr): Remove #if.
7620         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7621
7622 2019-03-05  Tom Tromey  <tromey@adacore.com>
7623
7624         * target.c (the_dummy_target): Move later.  Change type to
7625         "dummy_target".
7626         (initialize_targets): Don't initialize the_dummy_target.
7627
7628 2019-03-05  Tom Tromey  <tromey@adacore.com>
7629
7630         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7631         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7632
7633 2019-03-05  Tom Tromey  <tromey@adacore.com>
7634
7635         * windows-nat.c (windows_nat_target::attach)
7636         (windows_nat_target::detach): Don't call gdb_flush.
7637         * valprint.c (generic_val_print, val_print, val_print_string):
7638         Don't call gdb_flush.
7639         * utils.c (defaulted_query): Don't call gdb_flush.
7640         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7641         * target.c (target_announce_detach): Don't call gdb_flush.
7642         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7643         * remote.c (extended_remote_target::attach): Don't call
7644         gdb_flush.
7645         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7646         * printcmd.c (do_examine): Don't call gdb_flush.
7647         (info_display_command): Don't call gdb_flush.
7648         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7649         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7650         * memattr.c (info_mem_command): Don't call gdb_flush.
7651         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7652         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7653         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7654         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7655         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7656         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7657         (gnu_nat_target::detach): Don't call gdb_flush.
7658         * f-valprint.c (f_val_print): Don't call gdb_flush.
7659         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7660         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7661         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7662         gdb_flush.
7663         * c-valprint.c (c_val_print): Don't call gdb_flush.
7664         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7665
7666 2019-03-05  Tom Tromey  <tromey@adacore.com>
7667
7668         * varobj.c (update_dynamic_varobj_children): Update.
7669         (install_default_visualizer): Use reset, not release.
7670         * value.c (set_internalvar): Update.
7671         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7672         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7673         ATTRIBUTE_UNUSED_RESULT.
7674
7675 2019-03-05  Tom Tromey  <tromey@adacore.com>
7676
7677         * remote.c (class scoped_remote_fd) <release>: Add
7678         ATTRIBUTE_UNUSED_RESULT.
7679
7680 2019-03-05  Tom Tromey  <tromey@adacore.com>
7681
7682         * macroexp.c (struct macro_buffer) <release>: Add
7683         ATTRIBUTE_UNUSED_RESULT.
7684
7685 2019-03-05  Tom Tromey  <tromey@adacore.com>
7686
7687         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7688         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7689         ATTRIBUTE_UNUSED_RESULT.
7690
7691 2019-03-05  Tom Tromey  <tromey@adacore.com>
7692
7693         * common/scoped_fd.h (class scoped_fd) <release>: Add
7694         ATTRIBUTE_UNUSED_RESULT.
7695
7696 2019-03-05  Tom Tromey  <tromey@adacore.com>
7697
7698         * parser-defs.h (struct parser_state) <release>: Add
7699         ATTRIBUTE_UNUSED_RESULT.
7700
7701 2019-03-05  Tom Tromey  <tromey@adacore.com>
7702
7703         * utils.h (class gdb_argv) <release>: Add
7704         ATTRIBUTE_UNUSED_RESULT.
7705         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7706
7707 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7708
7709         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7710         for-loop range, to avoid compiler warnings.
7711
7712         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7713         avoid compiler warnings about unused variables.
7714
7715         * NEWS: Mention end of support for native debugging on MS-Windows
7716         before XP.
7717
7718         PR gdb/24292
7719         * common/netstuff.c:
7720         * gdbserver/gdbreplay.c
7721         * gdbserver/remote-utils.c:
7722         * ser-tcp.c:
7723         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7724         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7725         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7726         'getaddrinfo' and 'freeaddrinfo' were not available before
7727         Windows XP, and mingw.org's MinGW headers by default define
7728         _WIN32_WINNT to 0x500.
7729
7730 2019-03-01  Gary Benson <gbenson@redhat.com>
7731
7732         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7733
7734 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7735             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7736
7737         PR gdb/8527
7738         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7739         set_sigint_trap, clear_sigint_trap.
7740
7741 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7742
7743         * target.c (target_detach): Clear the regcache and the
7744         frame cache.
7745
7746 2019-02-27  Pedro Alves  <palves@redhat.com>
7747
7748         * utils.c (set_screen_size): When we cap the height/width sizes,
7749         tweak the corresponding command variable to show "unlimited":
7750
7751 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7752             Pedro Alves  <palves@redhat.com>
7753
7754         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7755         before calling rl_set_screen_size.
7756
7757 2019-02-27  Tom Tromey  <tromey@adacore.com>
7758
7759         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7760         define.
7761         * python/py-value.c: Remove Python 2.4 workaround.
7762         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7763         workaround.
7764         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7765         Python 2.4 workaround.
7766         * python/python-internal.h: Remove Python 2.4 comment.
7767         (Py_ssize_t): Don't define.
7768         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7769         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7770         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7771         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7772         * python/python.c (do_start_initialization): Remove Python 2.4
7773         workaround.
7774         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7775         (print_children): Remove Python 2.4 workaround.
7776         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7777         workaround.
7778         (CHARBUFFERPROC_NAME): Remove.
7779         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7780         Python 2.4 workaround.
7781
7782 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7783
7784         * NEWS: Note minimum Python version.
7785
7786 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7787
7788         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7789         code from these functions.  Remove corresponding ifdefs.  Use
7790         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7791         Remove gotos and target of gotos.
7792         (infpy_search_memory): Likewise.
7793
7794 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7795
7796         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7797         (hppa_gdbarch_init): Don't register deleted functions with
7798         gdbarch.
7799
7800 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7801
7802         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7803         (h8300_unwind_sp): Delete.
7804         (h8300_dummy_id): Delete.
7805         (h8300_gdbarch_init): Don't register deleted functions with
7806         gdbarch.
7807
7808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7809
7810         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7811         (ft32_unwind_pc): Delete.
7812         (ft32_unwind_sp): Delete.
7813         (ft32_gdbarch_init): Don't register deleted functions with
7814         gdbarch.
7815
7816 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7817
7818         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7819         (frv_unwind_pc): Delete.
7820         (frv_unwind_sp): Delete.
7821         (frv_gdbarch_init): Don't register deleted functions with
7822         gdbarch.
7823
7824 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7825
7826         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7827         (riscv_unwind_pc): Delete.
7828         (riscv_unwind_sp): Delete.
7829         (riscv_gdbarch_init): Don't register deleted functions with
7830         gdbarch.
7831
7832 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7833
7834         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7835         (csky_unwind_pc): Delete.
7836         (csky_unwind_sp): Delete.
7837         (csky_gdbarch_init): Don't register deleted functions with
7838         gdbarch.
7839
7840 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7841
7842         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7843         (cris_unwind_pc): Delete.
7844         (cris_unwind_sp): Delete.
7845         (cris_gdbarch_init): Don't register deleted functions with
7846         gdbarch.
7847
7848 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7849
7850         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7851         (bfin_unwind_pc): Delete.
7852         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7853
7854 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7855
7856         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7857         (arm_unwind_pc): Delete.
7858         (arm_unwind_sp): Delete.
7859         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7860
7861 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7862
7863         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7864         (arc_unwind_pc): Delete.
7865         (arc_unwind_sp): Delete.
7866         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7867
7868 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7869
7870         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7871         (alpha_unwind_pc): Delete.
7872         (alpha_gdbarch_init): Don't register deleted functions with
7873         gdbarch.
7874
7875 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7876
7877         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7878         (aarch64_unwind_pc): Delete.
7879         (aarch64_unwind_sp): Delete.
7880         (aarch64_gdbarch_init): Don't register deleted functions with
7881         gdbarch.
7882
7883 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7884
7885         * gdbtypes.c (type_align): Don't consider static members when
7886         computing structure alignment.
7887
7888 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7889
7890         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7891         return 0 for other types.
7892         * arch-utils.c (default_type_align): Always return 0.
7893         * gdbarch.h: Regenerate.
7894         * gdbarch.sh (type_align): Extend comment.
7895         * gdbtypes.c (type_align): Add additional comments, always call
7896         gdbarch_type_align before applying the default rules.
7897         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7898         generic code will then apply a suitable default.
7899         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7900         types, return 0 for other types.
7901
7902 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7903
7904         * NEWS: Create a new section for the next release branch.
7905         Rename the section of the current branch, now that it has
7906         been cut.
7907
7908 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7909
7910         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7911         * version.in: Bump version to 8.3.50.DATE-git.
7912
7913 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7914
7915         * aix-thread.c (ptid_cmp): Remove unused variable.
7916         (get_signaled_thread): Likewise.
7917         (store_regs_user_thread): Likewise.
7918         (store_regs_kernel_thread): Likewise.
7919         (fetch_regs_kernel_thread): Remove shadowed variable.
7920
7921 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7922
7923         * features/riscv/32bit-cpu.xml: Add register numbers.
7924         * features/riscv/32bit-fpu.c: Regenerate.
7925         * features/riscv/32bit-fpu.xml: Add register numbers.
7926         * features/riscv/64bit-cpu.xml: Add register numbers.
7927         * features/riscv/64bit-fpu.c: Regenerate.
7928         * features/riscv/64bit-fpu.xml: Add register numbers.
7929
7930 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7931
7932         * NEWS: Mention two argument form of gdb.Value constructor.
7933         * python/py-value.c (convert_buffer_and_type_to_value): New
7934         function.
7935         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7936         Add support for handling an optional second argument.  Call
7937         convert_buffer_and_type_to_value as appropriate.
7938         * python/python-internal.h (Py_buffer_deleter): New struct.
7939         (Py_buffer_up): New typedef.
7940
7941 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7942
7943         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7944         instead of releasing ownership.
7945
7946 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7947
7948         * dwarf2read.c (open_and_init_dwp_file): Call
7949         elf_numsections instead of bfd_count_sections to initialize
7950         dwp_file->num_sections.
7951
7952 2019-02-25  Tom Tromey  <tromey@adacore.com>
7953
7954         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7955
7956 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7957
7958         * gcore.in: Add '--readnever' option when invoking GDB.
7959
7960 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7961
7962         * MAINTAINERS: Update my email address.
7963
7964 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7965
7966         * build-id.c (build_id_to_debug_bfd_1): New function.
7967         (build_id_to_debug_bfd): Look for separate debug file in
7968         sysroot.
7969
7970 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7971
7972         * gdbarch.sh: Update the copyright year range that is placed into
7973         generated files.
7974
7975 2019-02-22  Keith Seitz  <keiths@redhat.com>
7976
7977         PR symtab/23853
7978         * linespec.c (create_sals_line_offset): Search for the default
7979         symtab's filename instead of its fullname.
7980
7981 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7982
7983         * NEWS: Update style defaults.
7984
7985 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7986
7987         * main.c (captured_main_1): Disable styling in batch mode.
7988
7989 2019-02-20  Tom Tromey  <tom@tromey.com>
7990
7991         * symtab.c (symtab_symbol_info): Fix typos.
7992
7993 2019-02-20  Tom Tromey  <tromey@adacore.com>
7994
7995         * findcmd.c (_initialize_mem_search): Use upper case for
7996         metasyntactic variables.
7997
7998 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7999
8000         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8001         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8002
8003 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8004
8005         * top.h (source_file_name): Change to std::string.
8006         * top.c (source_file_name): Likewise.
8007         (command_line_input): Adjust.
8008         * cli/cli-script.c (script_from_file): Adjust.
8009
8010 2019-02-19  Tom Tromey  <tromey@adacore.com>
8011
8012         * ravenscar-thread.c
8013         (ravenscar_thread_target::update_thread_list): Don't call
8014         ada_build_task_list.
8015         * ada-lang.h (ada_build_task_list): Don't declare.
8016         * ada-tasks.c (struct ada_tasks_inferior_data)
8017         <task_list_valid_p>: Now bool.
8018         (read_known_tasks, ada_task_list_changed)
8019         (ada_tasks_invalidate_inferior_data): Update.
8020         (read_known_tasks_array): Return bool.
8021         (read_known_tasks_list): Likewise.
8022         (read_known_tasks): Return void.
8023         (ada_build_task_list): Now static.
8024
8025 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8026
8027         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8028         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8029
8030 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8031
8032         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8033         variant for ada_tasks_pspace_data_handle and
8034         ada_tasks_inferior_data_handle.
8035         (ada_tasks_pspace_data_cleanup): New function.
8036         (ada_tasks_inferior_data_cleanup): New function.
8037
8038 2019-02-17  Tom Tromey  <tom@tromey.com>
8039
8040         * macrotab.h (macro_source_fullname): Return a std::string.
8041         * macrotab.c (macro_include, check_for_redefinition)
8042         (macro_undef, macro_lookup_definition, foreach_macro)
8043         (foreach_macro_in_scope): Update.
8044         (macro_source_fullname): Return a std::string.
8045         * macrocmd.c (show_pp_source_pos): Update.
8046
8047 2019-02-17  Tom Tromey  <tom@tromey.com>
8048
8049         * macrocmd.c (show_pp_source_pos): Style the file names.
8050
8051 2019-02-17  Tom Tromey  <tom@tromey.com>
8052
8053         PR tui/24197:
8054         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8055
8056 2019-02-17  Tom Tromey  <tom@tromey.com>
8057
8058         * ada-lang.c (user_select_syms): Use filtered printing.
8059         * utils.c (wrap_style): New global.
8060         (desired_style): Remove.
8061         (emit_style_escape): Add stream parameter.
8062         (set_output_style, reset_terminal_style, prompt_for_continue):
8063         Update.
8064         (flush_wrap_buffer): Only flush gdb_stdout.
8065         (wrap_here): Set wrap_style.
8066         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8067         treat escape sequences as a character.  Change when wrap buffer is
8068         flushed.
8069         (fputs_styled): Do not set the output style when the default is
8070         requested.
8071         * ui-style.h (struct ui_file_style) <is_default>: New method.
8072         * source.c (print_source_lines_base): Emit escape sequences in one
8073         piece.
8074
8075 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8076
8077         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8078         integers and enumeration types.
8079
8080 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8081
8082         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8083         instead of lookup_symbol_in_language
8084         (do_exact_match): New function.
8085         (ada_get_symbol_name_matcher): Return do_exact_match when
8086         doing a verbatim match.
8087
8088 2019-02-15  Tom Tromey  <tromey@adacore.com>
8089
8090         * ravenscar-thread.c (ravenscar_thread_target::resume)
8091         (ravenscar_thread_target::wait): Special case wildcard requests.
8092
8093 2019-02-15  Tom Tromey  <tromey@adacore.com>
8094
8095         * ravenscar-thread.c (base_ptid): Remove.
8096         (struct ravenscar_thread_target) <close>: New method.
8097         <m_base_ptid>: New member.
8098         <update_inferior_ptid, active_task, task_is_currently_active,
8099         runtime_initialized>: Declare methods.
8100         <ravenscar_thread_target>: Add constructor.
8101         (ravenscar_thread_target::task_is_currently_active)
8102         (ravenscar_thread_target::update_inferior_ptid)
8103         (ravenscar_runtime_initialized): Rename.  Now methods.
8104         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8105         (ravenscar_thread_target::update_thread_list): Update.
8106         (ravenscar_thread_target::active_task): Now method.
8107         (ravenscar_thread_target::store_registers)
8108         (ravenscar_thread_target::prepare_to_store)
8109         (ravenscar_thread_target::prepare_to_store)
8110         (ravenscar_thread_target::mourn_inferior): Update.
8111         (ravenscar_inferior_created): Use "new" to create target.
8112         (ravenscar_thread_target::get_ada_task_ptid): Update.
8113         (_initialize_ravenscar): Don't initialize base_ptid.
8114         (ravenscar_ops): Remove global.
8115
8116 2019-02-15  Tom Tromey  <tromey@adacore.com>
8117
8118         * target.h (push_target): Declare new overload.
8119         * target.c (push_target): New overload, taking an rvalue reference.
8120         * remote.c (remote_target::open_1): Use push_target overload.
8121         * corelow.c (core_target_open): Use push_target overload.
8122
8123 2019-02-15  Tom Tromey  <tromey@adacore.com>
8124
8125         * ravenscar-thread.c (is_ravenscar_task)
8126         (ravenscar_task_is_currently_active): Return bool.
8127         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8128         (_initialize_ravenscar): Remove "(void)".
8129         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8130         Return bool.
8131
8132 2019-02-15  Tom Tromey  <tromey@adacore.com>
8133
8134         * ravenscar-thread.c (ravenscar_runtime_initializer)
8135         (has_ravenscar_runtime, get_running_thread_id)
8136         (ravenscar_thread_target::resume): Fix indentation.
8137
8138 2019-02-15  Tom Tromey  <tromey@adacore.com>
8139
8140         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8141         from ravenscar_arch_ops.
8142         (sparc_ravenscar_ops::fetch_registers)
8143         (sparc_ravenscar_ops::store_registers): Now methods.
8144         (sparc_ravenscar_prepare_to_store): Remove.
8145         (sparc_ravenscar_ops): Redefine.
8146         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8147         methods and destructor.  Remove members.
8148         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8149         (ravenscar_thread_target::store_registers)
8150         (ravenscar_thread_target::prepare_to_store): Update.
8151         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8152         Remove.
8153         (struct ppc_ravenscar_powerpc_ops): Derive from
8154         ravenscar_arch_ops.
8155         (ppc_ravenscar_powerpc_ops::fetch_registers)
8156         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8157         (ppc_ravenscar_powerpc_ops): Redefine.
8158         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8159         (ppc_ravenscar_e500_ops::fetch_registers)
8160         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8161         (ppc_ravenscar_e500_ops): Redefine.
8162         * aarch64-ravenscar-thread.c
8163         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8164         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8165         (aarch64_ravenscar_fetch_registers)
8166         (aarch64_ravenscar_store_registers): Now methods.
8167         (aarch64_ravenscar_ops): Redefine.
8168
8169 2019-02-15  Tom Tromey  <tromey@adacore.com>
8170
8171         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8172         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8173         (ravenscar_thread_target::stopped_by_watchpoint)
8174         (ravenscar_thread_target::stopped_data_address)
8175         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8176
8177 2019-02-15  Tom Tromey  <tromey@adacore.com>
8178
8179         * ravenscar-thread.c: Fix some typos.
8180
8181 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8182             Tom Tromey  <tromey@adacore.com>
8183
8184         * ada-lang.c (ada_exception_sal): Change addr_string to a
8185         std::string.
8186         (create_ada_exception_catchpoint): Update.
8187
8188 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8189             Tom Tromey  <tromey@adacore.com>
8190
8191         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8192         (bp_location_ops): Remove.
8193         (base_breakpoint_allocate_location): Update.
8194         (free_bp_location): Update.
8195         * ada-lang.c (class ada_catchpoint_location)
8196         <ada_catchpoint_location>: Remove ops parameter.
8197         (ada_catchpoint_location_dtor): Remove.
8198         (ada_catchpoint_location_ops): Remove.
8199         (allocate_location_exception): Update.
8200         * breakpoint.h (struct bp_location_ops): Remove.
8201         (class bp_location) <bp_location>: Remove bp_location_ops
8202         parameter.
8203         <~bp_location>: Add destructor.
8204         <ops>: Remove.
8205
8206 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8207             Pedro Alves  <palves@redhat.com>
8208
8209         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8210         'PATH_MAX'.
8211
8212 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8213             Samuel Thibault  <samuel.thibault@gnu.org>
8214             Thomas Schwinge  <thomas@codesourcery.com>
8215
8216         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8217         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8218
8219 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8220
8221         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8222         (check_empty): Use "const char *".
8223
8224         * gnu-nat.c (gnu_nat_target::detach): Instead of
8225         'detach_inferior (pid)' call
8226         'detach_inferior (find_inferior_pid (pid))'.
8227
8228         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8229         'nat/fork-inferior.o'.
8230         * gnu-nat.c: #include "nat/fork-inferior.h".
8231
8232         * gnu-nat.c (gnu_nat_target::detach): Instead of
8233         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8234         * gnu-nat.h: #include "inf-child.h".
8235         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8236         'i386_gnu_nat_target::fetch_registers'.
8237         (gnu_store_registers): Rename/move to
8238         'i386_gnu_nat_target::store_registers'.
8239
8240         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8241         * gnu-nat.h (mach_thread_info): New function.
8242         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8243
8244         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8245
8246 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8247
8248         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8249
8250 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8251
8252         * windows-nat.c (windows_add_thread): Add new parameter
8253         "main_thread_p" with default value set to false.  Update
8254         function documentation as well as all callers.
8255         (windows_delete_thread): Likewise.
8256         (fake_create_process): Update call to windows_add_thread.
8257         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8258         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8259         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8260         call to windows_delete_thread.
8261
8262 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8263
8264         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8265
8266 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8267
8268         * symfile.c (find_separate_debug_file): Use canonical path of
8269         sysroot with child_path instead of gdb_sysroot if it is valid.
8270
8271 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8272
8273         * symfile.c (find_separate_debug_file): Use child_path to
8274         determine if an object file is under a sysroot.
8275
8276 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8277
8278         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8279         unittests/child-path-selftests.c.
8280         * common/pathstuff.c (child_path): New function.
8281         * common/pathstuff.h (child_path): New prototype.
8282         * unittests/child-path-selftests.c: New file.
8283
8284 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8285
8286         * symfile.c (find_separate_debug_file): Look for separate debug
8287         files in debug directories under the sysroot.
8288
8289 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8290
8291         * symtab.h (struct minimal_symbol data_p): New const method.
8292         (struct minimal_symbol text_p): Likewise.
8293         * symtab.c (output_source_filename): Use file name style
8294         to print file name.
8295         (print_symbol_info): Likewise.
8296         (print_msymbol_info): Use address style to print addresses.
8297         Use function name style to print executable text symbols.
8298         (expand_symtab_containing_pc): Use data_p.
8299         (find_pc_sect_compunit_symtab): Likewise.
8300
8301 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8302
8303         * breakpoint.c (describe_other_breakpoints): Use address style
8304         to print addresses.
8305         (say_where): Likewise.
8306
8307 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8308
8309         * ada-typeprint.c (print_func_type): Print function name
8310         style to print function name.
8311         * c-typeprint.c (c_print_type_1): Likewise.
8312
8313 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8314
8315         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8316         for execve.
8317
8318 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8319
8320         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8321         type_stack.
8322
8323 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8324
8325         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8326         TYPE_CODE_REF types.
8327
8328 2019-02-08  Jim Wilson  <jimw@sifive.com>
8329
8330         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8331         (riscv_linux_fregset): New.
8332         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8333
8334 2019-02-07  Tom Tromey  <tom@tromey.com>
8335
8336         * thread.c (thread_cancel_execution_command): Update.
8337         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8338         methods.
8339         (struct thread_fsm_ops): Remove.
8340         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8341         (thread_fsm_should_stop, thread_fsm_return_value)
8342         (thread_fsm_set_finished, thread_fsm_finished_p)
8343         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8344         Don't declare.
8345         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8346         * infrun.c (clear_proceed_status_thread)
8347         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8348         (print_stop_event): Update.
8349         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8350         Add constructor.
8351         (step_command_fsm_ops): Remove.
8352         (new_step_command_fsm): Remove.
8353         (step_1): Update.
8354         (step_command_fsm::should_stop): Rename from
8355         step_command_fsm_should_stop.
8356         (step_command_fsm::clean_up): Rename from
8357         step_command_fsm_clean_up.
8358         (step_command_fsm::do_async_reply_reason): Rename from
8359         step_command_fsm_async_reply_reason.
8360         (struct until_next_fsm): Inherit from thread_fsm.  Add
8361         constructor.
8362         (until_next_fsm_ops): Remove.
8363         (new_until_next_fsm): Remove.
8364         (until_next_fsm::should_stop): Rename from
8365         until_next_fsm_should_stop.
8366         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8367         (until_next_fsm::do_async_reply_reason): Rename from
8368         until_next_fsm_async_reply_reason.
8369         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8370         constructor.  Change type of breakpoint.
8371         (finish_command_fsm_ops): Remove.
8372         (new_finish_command_fsm): Remove.
8373         (finish_command_fsm::should_stop): Rename from
8374         finish_command_fsm_should_stop.
8375         (finish_command_fsm::clean_up): Rename from
8376         finish_command_fsm_clean_up.
8377         (finish_command_fsm::return_value): Rename from
8378         finish_command_fsm_return_value.
8379         (finish_command_fsm::do_async_reply_reason): Rename from
8380         finish_command_fsm_async_reply_reason.
8381         (finish_command): Update.
8382         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8383         Add constructor.
8384         (call_thread_fsm_ops): Remove.
8385         (call_thread_fsm::call_thread_fsm): Rename from
8386         new_call_thread_fsm.
8387         (call_thread_fsm::should_stop): Rename from
8388         call_thread_fsm_should_stop.
8389         (call_thread_fsm::should_notify_stop): Rename from
8390         call_thread_fsm_should_notify_stop.
8391         (run_inferior_call, call_function_by_hand_dummy): Update.
8392         * cli/cli-interp.c (should_print_stop_to_console): Update.
8393         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8394         Add constructor.  Change type of location_breakpoint,
8395         caller_breakpoint.
8396         (until_break_fsm_ops): Remove.
8397         (new_until_break_fsm): Remove.
8398         (until_break_fsm::should_stop): Rename from
8399         until_break_fsm_should_stop.
8400         (until_break_fsm::clean_up): Rename from
8401         until_break_fsm_clean_up.
8402         (until_break_fsm::do_async_reply_reason): Rename from
8403         until_break_fsm_async_reply_reason.
8404         (until_break_command): Update.
8405         * thread-fsm.c: Remove.
8406         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8407
8408 2019-02-07  Tom Tromey  <tom@tromey.com>
8409
8410         * yy-remap.h: Add include guard.
8411         * xtensa-tdep.h: Add include guard.
8412         * xcoffread.h: Rename include guard.
8413         * varobj-iter.h: Add include guard.
8414         * tui/tui.h: Rename include guard.
8415         * tui/tui-winsource.h: Rename include guard.
8416         * tui/tui-wingeneral.h: Rename include guard.
8417         * tui/tui-windata.h: Rename include guard.
8418         * tui/tui-win.h: Rename include guard.
8419         * tui/tui-stack.h: Rename include guard.
8420         * tui/tui-source.h: Rename include guard.
8421         * tui/tui-regs.h: Rename include guard.
8422         * tui/tui-out.h: Rename include guard.
8423         * tui/tui-layout.h: Rename include guard.
8424         * tui/tui-io.h: Rename include guard.
8425         * tui/tui-hooks.h: Rename include guard.
8426         * tui/tui-file.h: Rename include guard.
8427         * tui/tui-disasm.h: Rename include guard.
8428         * tui/tui-data.h: Rename include guard.
8429         * tui/tui-command.h: Rename include guard.
8430         * tic6x-tdep.h: Add include guard.
8431         * target/waitstatus.h: Rename include guard.
8432         * target/wait.h: Rename include guard.
8433         * target/target.h: Rename include guard.
8434         * target/resume.h: Rename include guard.
8435         * target-float.h: Rename include guard.
8436         * stabsread.h: Add include guard.
8437         * rs6000-tdep.h: Add include guard.
8438         * riscv-fbsd-tdep.h: Add include guard.
8439         * regformats/regdef.h: Rename include guard.
8440         * record.h: Rename include guard.
8441         * python/python.h: Rename include guard.
8442         * python/python-internal.h: Rename include guard.
8443         * python/py-stopevent.h: Rename include guard.
8444         * python/py-ref.h: Rename include guard.
8445         * python/py-record.h: Rename include guard.
8446         * python/py-record-full.h: Rename include guard.
8447         * python/py-record-btrace.h: Rename include guard.
8448         * python/py-instruction.h: Rename include guard.
8449         * python/py-events.h: Rename include guard.
8450         * python/py-event.h: Rename include guard.
8451         * procfs.h: Add include guard.
8452         * proc-utils.h: Add include guard.
8453         * p-lang.h: Add include guard.
8454         * or1k-tdep.h: Rename include guard.
8455         * observable.h: Rename include guard.
8456         * nto-tdep.h: Rename include guard.
8457         * nat/x86-linux.h: Rename include guard.
8458         * nat/x86-linux-dregs.h: Rename include guard.
8459         * nat/x86-gcc-cpuid.h: Add include guard.
8460         * nat/x86-dregs.h: Rename include guard.
8461         * nat/x86-cpuid.h: Rename include guard.
8462         * nat/ppc-linux.h: Rename include guard.
8463         * nat/mips-linux-watch.h: Rename include guard.
8464         * nat/linux-waitpid.h: Rename include guard.
8465         * nat/linux-ptrace.h: Rename include guard.
8466         * nat/linux-procfs.h: Rename include guard.
8467         * nat/linux-osdata.h: Rename include guard.
8468         * nat/linux-nat.h: Rename include guard.
8469         * nat/linux-namespaces.h: Rename include guard.
8470         * nat/linux-btrace.h: Rename include guard.
8471         * nat/glibc_thread_db.h: Rename include guard.
8472         * nat/gdb_thread_db.h: Rename include guard.
8473         * nat/gdb_ptrace.h: Rename include guard.
8474         * nat/fork-inferior.h: Rename include guard.
8475         * nat/amd64-linux-siginfo.h: Rename include guard.
8476         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8477         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8478         * nat/aarch64-linux.h: Rename include guard.
8479         * nat/aarch64-linux-hw-point.h: Rename include guard.
8480         * mn10300-tdep.h: Add include guard.
8481         * mips-linux-tdep.h: Add include guard.
8482         * mi/mi-parse.h: Rename include guard.
8483         * mi/mi-out.h: Rename include guard.
8484         * mi/mi-main.h: Rename include guard.
8485         * mi/mi-interp.h: Rename include guard.
8486         * mi/mi-getopt.h: Rename include guard.
8487         * mi/mi-console.h: Rename include guard.
8488         * mi/mi-common.h: Rename include guard.
8489         * mi/mi-cmds.h: Rename include guard.
8490         * mi/mi-cmd-break.h: Rename include guard.
8491         * m2-lang.h: Add include guard.
8492         * location.h: Rename include guard.
8493         * linux-record.h: Rename include guard.
8494         * linux-nat.h: Add include guard.
8495         * linux-fork.h: Add include guard.
8496         * i386-darwin-tdep.h: Rename include guard.
8497         * hppa-linux-offsets.h: Add include guard.
8498         * guile/guile.h: Rename include guard.
8499         * guile/guile-internal.h: Rename include guard.
8500         * gnu-nat.h: Rename include guard.
8501         * gdb-stabs.h: Rename include guard.
8502         * frv-tdep.h: Add include guard.
8503         * f-lang.h: Add include guard.
8504         * event-loop.h: Add include guard.
8505         * darwin-nat.h: Rename include guard.
8506         * cp-abi.h: Rename include guard.
8507         * config/sparc/nm-sol2.h: Rename include guard.
8508         * config/nm-nto.h: Rename include guard.
8509         * config/nm-linux.h: Add include guard.
8510         * config/i386/nm-i386gnu.h: Rename include guard.
8511         * config/djgpp/nl_types.h: Rename include guard.
8512         * config/djgpp/langinfo.h: Rename include guard.
8513         * compile/gcc-cp-plugin.h: Add include guard.
8514         * compile/gcc-c-plugin.h: Add include guard.
8515         * compile/compile.h: Rename include guard.
8516         * compile/compile-object-run.h: Rename include guard.
8517         * compile/compile-object-load.h: Rename include guard.
8518         * compile/compile-internal.h: Rename include guard.
8519         * compile/compile-cplus.h: Rename include guard.
8520         * compile/compile-c.h: Rename include guard.
8521         * common/xml-utils.h: Rename include guard.
8522         * common/x86-xstate.h: Rename include guard.
8523         * common/version.h: Rename include guard.
8524         * common/vec.h: Rename include guard.
8525         * common/tdesc.h: Rename include guard.
8526         * common/selftest.h: Rename include guard.
8527         * common/scoped_restore.h: Rename include guard.
8528         * common/scoped_mmap.h: Rename include guard.
8529         * common/scoped_fd.h: Rename include guard.
8530         * common/safe-iterator.h: Rename include guard.
8531         * common/run-time-clock.h: Rename include guard.
8532         * common/refcounted-object.h: Rename include guard.
8533         * common/queue.h: Rename include guard.
8534         * common/ptid.h: Rename include guard.
8535         * common/print-utils.h: Rename include guard.
8536         * common/preprocessor.h: Rename include guard.
8537         * common/pathstuff.h: Rename include guard.
8538         * common/observable.h: Rename include guard.
8539         * common/netstuff.h: Rename include guard.
8540         * common/job-control.h: Rename include guard.
8541         * common/host-defs.h: Rename include guard.
8542         * common/gdb_wait.h: Rename include guard.
8543         * common/gdb_vecs.h: Rename include guard.
8544         * common/gdb_unlinker.h: Rename include guard.
8545         * common/gdb_unique_ptr.h: Rename include guard.
8546         * common/gdb_tilde_expand.h: Rename include guard.
8547         * common/gdb_sys_time.h: Rename include guard.
8548         * common/gdb_string_view.h: Rename include guard.
8549         * common/gdb_splay_tree.h: Rename include guard.
8550         * common/gdb_setjmp.h: Rename include guard.
8551         * common/gdb_ref_ptr.h: Rename include guard.
8552         * common/gdb_optional.h: Rename include guard.
8553         * common/gdb_locale.h: Rename include guard.
8554         * common/gdb_assert.h: Rename include guard.
8555         * common/filtered-iterator.h: Rename include guard.
8556         * common/filestuff.h: Rename include guard.
8557         * common/fileio.h: Rename include guard.
8558         * common/environ.h: Rename include guard.
8559         * common/common-utils.h: Rename include guard.
8560         * common/common-types.h: Rename include guard.
8561         * common/common-regcache.h: Rename include guard.
8562         * common/common-inferior.h: Rename include guard.
8563         * common/common-gdbthread.h: Rename include guard.
8564         * common/common-exceptions.h: Rename include guard.
8565         * common/common-defs.h: Rename include guard.
8566         * common/common-debug.h: Rename include guard.
8567         * common/cleanups.h: Rename include guard.
8568         * common/buffer.h: Rename include guard.
8569         * common/btrace-common.h: Rename include guard.
8570         * common/break-common.h: Rename include guard.
8571         * cli/cli-utils.h: Rename include guard.
8572         * cli/cli-style.h: Rename include guard.
8573         * cli/cli-setshow.h: Rename include guard.
8574         * cli/cli-script.h: Rename include guard.
8575         * cli/cli-interp.h: Rename include guard.
8576         * cli/cli-decode.h: Rename include guard.
8577         * cli/cli-cmds.h: Rename include guard.
8578         * charset-list.h: Add include guard.
8579         * buildsym-legacy.h: Rename include guard.
8580         * bfin-tdep.h: Add include guard.
8581         * ax.h: Rename include guard.
8582         * arm-linux-tdep.h: Add include guard.
8583         * arm-fbsd-tdep.h: Add include guard.
8584         * arch/xtensa.h: Rename include guard.
8585         * arch/tic6x.h: Add include guard.
8586         * arch/i386.h: Add include guard.
8587         * arch/arm.h: Rename include guard.
8588         * arch/arm-linux.h: Rename include guard.
8589         * arch/arm-get-next-pcs.h: Rename include guard.
8590         * arch/amd64.h: Add include guard.
8591         * arch/aarch64-insn.h: Rename include guard.
8592         * arch-utils.h: Rename include guard.
8593         * annotate.h: Add include guard.
8594         * amd64-darwin-tdep.h: Rename include guard.
8595         * aarch64-linux-tdep.h: Add include guard.
8596         * aarch64-fbsd-tdep.h: Add include guard.
8597         * aarch32-linux-nat.h: Add include guard.
8598
8599 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8600
8601         * macrotab.c (macro_define_internal): New function that
8602         factorizes macro_define_object_internal and macro_define_function
8603         code.
8604         (macro_define_object_internal): Use macro_define_internal.
8605         (macro_define_function): Likewise.
8606
8607 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8608
8609         * macrocmd.c (extract_identifier): Return
8610         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8611         callers.
8612
8613 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8614
8615         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8616
8617 2019-02-05  Tom Tromey  <tom@tromey.com>
8618
8619         * target.c (target_stack::unpush): Move assertion earlier.
8620
8621 2019-01-30  Tom Tromey  <tom@tromey.com>
8622
8623         PR python/23615:
8624         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8625         (gdbpy_parse_and_eval): Likewise.
8626         * python/python-internal.h (gdbpy_allow_threads): New class.
8627
8628 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8629
8630         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8631         (aarch64_fbsd_fpregmap): Move earlier.
8632         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8633         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8634         instead of individual calls to trad_frame_set_reg_addr.
8635         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8636         earlier.
8637         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8638         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8639         instead of individual calls to trad_frame_set_reg_addr.
8640
8641 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8642
8643         * CONTRIBUTE: Replace contribution list with wiki link.
8644
8645 2019-01-25  Tom Tromey  <tom@tromey.com>
8646
8647         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8648
8649 2019-01-25  Tom Tromey  <tom@tromey.com>
8650
8651         * xtensa-linux-nat.c: Fix common/ includes.
8652         * xml-support.h: Fix common/ includes.
8653         * xml-support.c: Fix common/ includes.
8654         * x86-linux-nat.c: Fix common/ includes.
8655         * windows-nat.c: Fix common/ includes.
8656         * varobj.h: Fix common/ includes.
8657         * varobj.c: Fix common/ includes.
8658         * value.c: Fix common/ includes.
8659         * valops.c: Fix common/ includes.
8660         * utils.c: Fix common/ includes.
8661         * unittests/xml-utils-selftests.c: Fix common/ includes.
8662         * unittests/utils-selftests.c: Fix common/ includes.
8663         * unittests/unpack-selftests.c: Fix common/ includes.
8664         * unittests/tracepoint-selftests.c: Fix common/ includes.
8665         * unittests/style-selftests.c: Fix common/ includes.
8666         * unittests/string_view-selftests.c: Fix common/ includes.
8667         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8668         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8669         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8670         * unittests/rsp-low-selftests.c: Fix common/ includes.
8671         * unittests/parse-connection-spec-selftests.c: Fix common/
8672         includes.
8673         * unittests/optional-selftests.c: Fix common/ includes.
8674         * unittests/offset-type-selftests.c: Fix common/ includes.
8675         * unittests/observable-selftests.c: Fix common/ includes.
8676         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8677         * unittests/memrange-selftests.c: Fix common/ includes.
8678         * unittests/memory-map-selftests.c: Fix common/ includes.
8679         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8680         * unittests/function-view-selftests.c: Fix common/ includes.
8681         * unittests/environ-selftests.c: Fix common/ includes.
8682         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8683         * unittests/common-utils-selftests.c: Fix common/ includes.
8684         * unittests/cli-utils-selftests.c: Fix common/ includes.
8685         * unittests/array-view-selftests.c: Fix common/ includes.
8686         * ui-file.c: Fix common/ includes.
8687         * tui/tui-io.c: Fix common/ includes.
8688         * tracepoint.h: Fix common/ includes.
8689         * tracepoint.c: Fix common/ includes.
8690         * tracefile-tfile.c: Fix common/ includes.
8691         * top.h: Fix common/ includes.
8692         * top.c: Fix common/ includes.
8693         * thread.c: Fix common/ includes.
8694         * target/waitstatus.h: Fix common/ includes.
8695         * target/waitstatus.c: Fix common/ includes.
8696         * target.h: Fix common/ includes.
8697         * target.c: Fix common/ includes.
8698         * target-memory.c: Fix common/ includes.
8699         * target-descriptions.c: Fix common/ includes.
8700         * symtab.h: Fix common/ includes.
8701         * symfile.c: Fix common/ includes.
8702         * stap-probe.c: Fix common/ includes.
8703         * spu-linux-nat.c: Fix common/ includes.
8704         * sparc-nat.c: Fix common/ includes.
8705         * source.c: Fix common/ includes.
8706         * solib.c: Fix common/ includes.
8707         * solib-target.c: Fix common/ includes.
8708         * ser-unix.c: Fix common/ includes.
8709         * ser-tcp.c: Fix common/ includes.
8710         * ser-pipe.c: Fix common/ includes.
8711         * ser-base.c: Fix common/ includes.
8712         * selftest-arch.c: Fix common/ includes.
8713         * s12z-tdep.c: Fix common/ includes.
8714         * rust-exp.y: Fix common/ includes.
8715         * rs6000-aix-tdep.c: Fix common/ includes.
8716         * riscv-tdep.c: Fix common/ includes.
8717         * remote.c: Fix common/ includes.
8718         * remote-notif.h: Fix common/ includes.
8719         * remote-fileio.h: Fix common/ includes.
8720         * remote-fileio.c: Fix common/ includes.
8721         * regcache.h: Fix common/ includes.
8722         * regcache.c: Fix common/ includes.
8723         * record-btrace.c: Fix common/ includes.
8724         * python/python.c: Fix common/ includes.
8725         * python/py-type.c: Fix common/ includes.
8726         * python/py-inferior.c: Fix common/ includes.
8727         * progspace.h: Fix common/ includes.
8728         * producer.c: Fix common/ includes.
8729         * procfs.c: Fix common/ includes.
8730         * proc-api.c: Fix common/ includes.
8731         * printcmd.c: Fix common/ includes.
8732         * ppc-linux-nat.c: Fix common/ includes.
8733         * parser-defs.h: Fix common/ includes.
8734         * osdata.c: Fix common/ includes.
8735         * obsd-nat.c: Fix common/ includes.
8736         * nat/x86-linux.c: Fix common/ includes.
8737         * nat/x86-linux-dregs.c: Fix common/ includes.
8738         * nat/x86-dregs.h: Fix common/ includes.
8739         * nat/x86-dregs.c: Fix common/ includes.
8740         * nat/ppc-linux.c: Fix common/ includes.
8741         * nat/mips-linux-watch.h: Fix common/ includes.
8742         * nat/mips-linux-watch.c: Fix common/ includes.
8743         * nat/linux-waitpid.c: Fix common/ includes.
8744         * nat/linux-ptrace.h: Fix common/ includes.
8745         * nat/linux-ptrace.c: Fix common/ includes.
8746         * nat/linux-procfs.c: Fix common/ includes.
8747         * nat/linux-personality.c: Fix common/ includes.
8748         * nat/linux-osdata.c: Fix common/ includes.
8749         * nat/linux-namespaces.c: Fix common/ includes.
8750         * nat/linux-btrace.h: Fix common/ includes.
8751         * nat/linux-btrace.c: Fix common/ includes.
8752         * nat/fork-inferior.c: Fix common/ includes.
8753         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8754         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8755         * nat/aarch64-linux.c: Fix common/ includes.
8756         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8757         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8758         * namespace.h: Fix common/ includes.
8759         * mips-linux-tdep.c: Fix common/ includes.
8760         * minsyms.c: Fix common/ includes.
8761         * mi/mi-parse.h: Fix common/ includes.
8762         * mi/mi-main.c: Fix common/ includes.
8763         * mi/mi-cmd-env.c: Fix common/ includes.
8764         * memrange.h: Fix common/ includes.
8765         * memattr.c: Fix common/ includes.
8766         * maint.h: Fix common/ includes.
8767         * maint.c: Fix common/ includes.
8768         * main.c: Fix common/ includes.
8769         * machoread.c: Fix common/ includes.
8770         * location.c: Fix common/ includes.
8771         * linux-thread-db.c: Fix common/ includes.
8772         * linux-nat.c: Fix common/ includes.
8773         * linux-fork.c: Fix common/ includes.
8774         * inline-frame.c: Fix common/ includes.
8775         * infrun.c: Fix common/ includes.
8776         * inflow.c: Fix common/ includes.
8777         * inferior.h: Fix common/ includes.
8778         * inferior.c: Fix common/ includes.
8779         * infcmd.c: Fix common/ includes.
8780         * inf-ptrace.c: Fix common/ includes.
8781         * inf-child.c: Fix common/ includes.
8782         * ia64-linux-nat.c: Fix common/ includes.
8783         * i387-tdep.c: Fix common/ includes.
8784         * i386-tdep.c: Fix common/ includes.
8785         * i386-linux-tdep.c: Fix common/ includes.
8786         * i386-linux-nat.c: Fix common/ includes.
8787         * i386-go32-tdep.c: Fix common/ includes.
8788         * i386-fbsd-tdep.c: Fix common/ includes.
8789         * i386-fbsd-nat.c: Fix common/ includes.
8790         * guile/scm-type.c: Fix common/ includes.
8791         * guile/guile.c: Fix common/ includes.
8792         * go32-nat.c: Fix common/ includes.
8793         * gnu-nat.c: Fix common/ includes.
8794         * gdbthread.h: Fix common/ includes.
8795         * gdbarch-selftests.c: Fix common/ includes.
8796         * gdb_usleep.c: Fix common/ includes.
8797         * gdb_select.h: Fix common/ includes.
8798         * gdb_bfd.c: Fix common/ includes.
8799         * gcore.c: Fix common/ includes.
8800         * fork-child.c: Fix common/ includes.
8801         * findvar.c: Fix common/ includes.
8802         * fbsd-nat.c: Fix common/ includes.
8803         * event-top.c: Fix common/ includes.
8804         * event-loop.c: Fix common/ includes.
8805         * dwarf2read.c: Fix common/ includes.
8806         * dwarf2loc.c: Fix common/ includes.
8807         * dwarf2-frame.c: Fix common/ includes.
8808         * dwarf-index-cache.c: Fix common/ includes.
8809         * dtrace-probe.c: Fix common/ includes.
8810         * disasm-selftests.c: Fix common/ includes.
8811         * defs.h: Fix common/ includes.
8812         * csky-tdep.c: Fix common/ includes.
8813         * cp-valprint.c: Fix common/ includes.
8814         * cp-support.h: Fix common/ includes.
8815         * cp-support.c: Fix common/ includes.
8816         * corelow.c: Fix common/ includes.
8817         * completer.h: Fix common/ includes.
8818         * completer.c: Fix common/ includes.
8819         * compile/compile.c: Fix common/ includes.
8820         * compile/compile-loc2c.c: Fix common/ includes.
8821         * compile/compile-cplus-types.c: Fix common/ includes.
8822         * compile/compile-cplus-symbols.c: Fix common/ includes.
8823         * command.h: Fix common/ includes.
8824         * cli/cli-dump.c: Fix common/ includes.
8825         * cli/cli-cmds.c: Fix common/ includes.
8826         * charset.c: Fix common/ includes.
8827         * build-id.c: Fix common/ includes.
8828         * btrace.h: Fix common/ includes.
8829         * btrace.c: Fix common/ includes.
8830         * breakpoint.h: Fix common/ includes.
8831         * breakpoint.c: Fix common/ includes.
8832         * ax.h:
8833         (enum agent_op): Fix common/ includes.
8834         * ax-general.c (struct aop_map): Fix common/ includes.
8835         * ax-gdb.c: Fix common/ includes.
8836         * auxv.c: Fix common/ includes.
8837         * auto-load.c: Fix common/ includes.
8838         * arm-tdep.c: Fix common/ includes.
8839         * arch/riscv.c: Fix common/ includes.
8840         * arch/ppc-linux-common.c: Fix common/ includes.
8841         * arch/i386.c: Fix common/ includes.
8842         * arch/arm.c: Fix common/ includes.
8843         * arch/arm-linux.c: Fix common/ includes.
8844         * arch/arm-get-next-pcs.c: Fix common/ includes.
8845         * arch/amd64.c: Fix common/ includes.
8846         * arch/aarch64.c: Fix common/ includes.
8847         * arch/aarch64-insn.c: Fix common/ includes.
8848         * arch-utils.c: Fix common/ includes.
8849         * amd64-windows-tdep.c: Fix common/ includes.
8850         * amd64-tdep.c: Fix common/ includes.
8851         * amd64-sol2-tdep.c: Fix common/ includes.
8852         * amd64-obsd-tdep.c: Fix common/ includes.
8853         * amd64-nbsd-tdep.c: Fix common/ includes.
8854         * amd64-linux-tdep.c: Fix common/ includes.
8855         * amd64-linux-nat.c: Fix common/ includes.
8856         * amd64-fbsd-tdep.c: Fix common/ includes.
8857         * amd64-fbsd-nat.c: Fix common/ includes.
8858         * amd64-dicos-tdep.c: Fix common/ includes.
8859         * amd64-darwin-tdep.c: Fix common/ includes.
8860         * agent.c: Fix common/ includes.
8861         * ada-lang.h: Fix common/ includes.
8862         * ada-lang.c: Fix common/ includes.
8863         * aarch64-tdep.c: Fix common/ includes.
8864
8865 2019-01-25  Tom Tromey  <tom@tromey.com>
8866
8867         * common/create-version.sh: Use common/version.h.
8868
8869 2019-01-24  Pedro Alves  <palves@redhat.com>
8870
8871         * infrun.c (signal_stop, signal_print, signal_program)
8872         (signal_catch, signal_pass): Now arrays instead of pointers.
8873         (update_signals_program_target, do_target_resume)
8874         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8875         * linux-nat.c (linux_nat_target::pass_signals)
8876         (linux_nat_target::create_inferior, linux_nat_target::attach):
8877         Adjust.
8878         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8879         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8880         * procfs.c (procfs_target::pass_signals): Adjust.
8881         * record-full.c (record_full_target::resume): Adjust.
8882         * remote.c (remote_target::pass_signals)
8883         (remote_target::program_signals): Adjust.
8884         * target-debug.h (target_debug_print_signals): Now takes a
8885         gdb::array_view as parameter.  Adjust.
8886         * target.h (target_ops) <pass_signals, program_signals>: Replace
8887         pointer and length parameters with gdb::array_view.
8888         (target_pass_signals, target_program_signals): Likewise.
8889         * target-delegates.c: Regenerate.
8890
8891 2019-01-24  Pedro Alves  <palves@redhat.com>
8892
8893         * common/forward-scope-exit.h
8894         (forward_scope_exit::forward_scope_exit): Pass arguments to
8895         m_bind_function directly, instead of creating a std::bind and
8896         copying that.
8897
8898 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8899
8900         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8901         for static members.
8902         (pass_in_v_vfp_candidate): Likewise.
8903
8904 2019-01-23  Tom Tromey  <tom@tromey.com>
8905             Pedro Alves  <palves@redhat.com>
8906
8907         * regcache.c (class regcache_invalidator): Remove.
8908         (regcache::raw_write): Use make_scope_exit.
8909
8910 2019-01-23  Tom Tromey  <tom@tromey.com>
8911
8912         * ui-out.h (class ui_out_emit_type): Update comment.
8913
8914 2019-01-23  Tom Tromey  <tom@tromey.com>
8915
8916         * infrun.c (fetch_inferior_event): Update comment.
8917
8918 2019-01-23  Tom Tromey  <tom@tromey.com>
8919             Pedro Alves  <palves@redhat.com>
8920
8921         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8922         parameter.
8923         (fetch_inferior_event): Use SCOPE_EXIT.
8924
8925
8926 2019-01-23  Tom Tromey  <tom@tromey.com>
8927             Pedro Alves  <palves@redhat.com>
8928
8929         * infrun.c (disable_thread_events): Delete.
8930         (stop_all_threads): Use SCOPE_EXIT.
8931
8932 2019-01-23  Tom Tromey  <tom@tromey.com>
8933             Pedro Alves  <palves@redhat.com>
8934
8935         * symfile.c: Include forward-scope-exit.h.
8936         (clear_symtab_users_cleanup): Replace forward declaration with
8937         a FORWARD_SCOPE_EXIT.
8938         (syms_from_objfile_1): Use the forward_scope_exit and
8939         gdb::optional instead of cleanup_function.
8940         (reread_symbols): Use the forward_scope_exit instead of
8941         cleanup_function.
8942         (clear_symtab_users_cleanup): Remove function.
8943
8944 2019-01-23  Tom Tromey  <tom@tromey.com>
8945             Pedro Alves  <palves@redhat.com>
8946
8947         * linux-nat.c: Include scope-exit.h.
8948         (cleanup_target_stop): Remove.
8949         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8950         SCOPE_EXIT.
8951
8952 2019-01-23  Tom Tromey  <tom@tromey.com>
8953             Pedro Alves  <palves@redhat.com>
8954
8955         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8956         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8957
8958 2019-01-23  Tom Tromey  <tom@tromey.com>
8959             Andrew Burgess  <andrew.burgess@embecosm.com>
8960             Pedro Alves  <palves@redhat.com>
8961
8962         * infrun.c (fetch_inferior_event): Use scope_exit.
8963         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8964         * top.c (execute_command): Use scope_exit.
8965         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8966         * utils.c (do_bpstat_clear_actions_cleanup)
8967         (make_bpstat_clear_actions_cleanup): Remove.
8968
8969 2019-01-23  Tom Tromey  <tom@tromey.com>
8970             Pedro Alves  <palves@redhat.com>
8971
8972         * infrun.c: Include "common/scope-exit.h"
8973         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8974         (wait_for_inferior): Use SCOPE_EXIT.
8975         (fetch_inferior_event): Use scope_exit.
8976
8977 2019-01-23  Tom Tromey  <tom@tromey.com>
8978             Pedro Alves  <palves@redhat.com>
8979
8980         * breakpoint.c (create_breakpoint): Remove cleanup.
8981
8982 2019-01-23  Tom Tromey  <tom@tromey.com>
8983             Andrew Burgess  <andrew.burgess@embecosm.com>
8984             Pedro Alves  <palves@redhat.com>
8985
8986 2019-01-23  Pedro Alves  <palves@redhat.com>
8987
8988         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8989
8990 2019-01-23  Pedro Alves  <palves@redhat.com>
8991             Andrew Burgess  <andrew.burgess@embecosm.com>
8992
8993         * gdbthread.h: Include "common/forward-scope-exit.h".
8994         (scoped_finish_thread_state): Redefine custom class in terms of
8995         forward_scope_exit.
8996
8997 2019-01-23  Pedro Alves  <palves@redhat.com>
8998             Andrew Burgess  <andrew.burgess@embecosm.com>
8999
9000         * common/forward-scope-exit.h: New file.
9001
9002 2019-01-23  Pedro Alves  <palves@redhat.com>
9003             Andrew Burgess  <andrew.burgess@embecosm.com>
9004             Tom Tromey  <tom@tromey.com>
9005
9006         * common/scope-exit.h: New file.
9007
9008 2019-01-23  Pedro Alves  <palves@redhat.com>
9009
9010         * common/preprocessor.h (ESC): Rename to ...
9011         (ESC_PARENS): ... this.
9012         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9013         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9014
9015 2019-01-23  Tom Tromey  <tom@tromey.com>
9016
9017         * language.h (class scoped_switch_to_sym_language_if_auto):
9018         Initialize m_lang in both cases.
9019
9020 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9021
9022         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9023         with XCNEW.
9024
9025 2019-01-22  Tom Tromey  <tom@tromey.com>
9026
9027         * corelow.c: Do not include sys/file.h.
9028
9029 2019-01-22  Tom Tromey  <tom@tromey.com>
9030
9031         * tui/tui-wingeneral.h: Include gdb_curses.h.
9032
9033 2019-01-22  Tom Tromey  <tom@tromey.com>
9034
9035         * source-cache.h (class source_cache) <get_source_lines,
9036         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9037
9038 2019-01-22  Tom Tromey  <tom@tromey.com>
9039
9040         * remote-fileio.h (struct remote_target): Declare.
9041
9042 2019-01-22  Tom Tromey  <tom@tromey.com>
9043
9044         * python/py-arch.c: Do not include py-ref.h.
9045         * python/py-bpevent.c: Do not include py-ref.h.
9046         * python/py-cmd.c: Do not include py-ref.h.
9047         * python/py-continueevent.c: Do not include py-ref.h.
9048         * python/py-event.h: Do not include py-ref.h.
9049         * python/py-evtregistry.c: Do not include py-ref.h.
9050         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9051         * python/py-frame.c: Do not include py-ref.h.
9052         * python/py-framefilter.c: Do not include py-ref.h.
9053         * python/py-function.c: Do not include py-ref.h.
9054         * python/py-infevents.c: Do not include py-ref.h.
9055         * python/py-linetable.c: Do not include py-ref.h.
9056         * python/py-objfile.c: Do not include py-ref.h.
9057         * python/py-param.c: Do not include py-ref.h.
9058         * python/py-prettyprint.c: Do not include py-ref.h.
9059         * python/py-progspace.c: Do not include py-ref.h.
9060         * python/py-symbol.c: Do not include py-ref.h.
9061         * python/py-symtab.c: Do not include py-ref.h.
9062         * python/py-type.c: Do not include py-ref.h.
9063         * python/py-unwind.c: Do not include py-ref.h.
9064         * python/py-utils.c: Do not include py-ref.h.
9065         * python/py-value.c: Do not include py-ref.h.
9066         * python/py-varobj.c: Do not include py-ref.h.
9067         * python/py-xmethods.c: Do not include py-ref.h.
9068         * python/python.c: Do not include py-ref.h.
9069         * varobj.c: Do not include py-ref.h.
9070
9071 2019-01-22  Tom Tromey  <tom@tromey.com>
9072
9073         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9074         keyword for bcache.
9075
9076 2019-01-22  Tom Tromey  <tom@tromey.com>
9077
9078         * compile/compile-cplus-types.c: Remove a comment by #include.
9079
9080 2019-01-22  Tom Tromey  <tom@tromey.com>
9081
9082         * compile/gcc-c-plugin.h: Include compile-internal.h.
9083
9084 2019-01-22  Tom Tromey  <tom@tromey.com>
9085
9086         * stabsread.c (EXTERN): Do not define.
9087         (symnum, next_symbol_text_func, processing_gcc_compilation)
9088         (within_function, global_sym_chain, global_stabs)
9089         (previous_stab_code, this_object_header_files)
9090         (n_this_object_header_files)
9091         (n_allocated_this_object_header_files): Define.
9092         * stabsread.h (EXTERN): Never define.  Use "extern".
9093
9094 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9095
9096         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9097         history_value.
9098
9099 2019-01-21  Tom Tromey  <tom@tromey.com>
9100
9101         * ui-out.c: Fix includes.
9102         * tui/tui-source.c: Fix includes.
9103         * target.c: Fix includes.
9104         * remote.c: Fix includes.
9105         * regcache.c: Fix includes.
9106         * python/py-block.c: Fix includes.
9107         * printcmd.c: Fix includes.
9108         * or1k-tdep.c: Fix includes.
9109         * mi/mi-main.c: Fix includes.
9110         * m32r-tdep.c: Fix includes.
9111         * csky-tdep.c: Fix includes.
9112         * compile/compile-cplus-types.c: Fix includes.
9113         * cli/cli-interp.c: Fix includes.
9114
9115 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9116
9117         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9118         for padding.
9119
9120 2019-01-16  Tom Tromey  <tom@tromey.com>
9121
9122         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9123         earlier.
9124         (struct objfile) <msymbols_range>: Move from top level.
9125         <msymbols>: New method.
9126         (class objfile_msymbols): Remove.
9127         * symtab.c (default_collect_symbol_completion_matches_break_on):
9128         Update.
9129         * symmisc.c (dump_msymbols): Update.
9130         * stabsread.c (scan_file_globals): Update.
9131         * objc-lang.c (info_selectors_command, info_classes_command)
9132         (find_methods): Update.
9133         * minsyms.c (find_solib_trampoline_target): Update.
9134         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9135         * coffread.c (coff_symfile_read): Update.
9136         * ada-lang.c (ada_lookup_simple_minsym)
9137         (ada_collect_symbol_completion_matches): Update.
9138
9139 2019-01-16  Tom Tromey  <tom@tromey.com>
9140
9141         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9142         type.  Remove no-argument constructor.
9143         <iterator::operator++>: Simplify.
9144         <begin>: Update.
9145         <end>: Use minimal_symbol_count.
9146
9147 2019-01-16  Tom Tromey  <tom@tromey.com>
9148
9149         * objfiles.h (struct objfile) <psymtabs>: New method.
9150         (class objfile_psymtabs): Remove.
9151         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9152         typedef.
9153         <range>: New method.
9154         (require_partial_symbols): Change return type.
9155         * psymtab.c (require_partial_symbols)
9156         (psym_expand_symtabs_matching): Update.
9157         * mdebugread.c (parse_partial_symbols): Update.
9158         * dbxread.c (dbx_end_psymtab): Update.
9159
9160 2019-01-15  Tom Tromey  <tom@tromey.com>
9161
9162         * symtab.c (lookup_objfile_from_block)
9163         (lookup_symbol_in_objfile_symtabs)
9164         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9165         (find_line_symtab, info_sources_command)
9166         (default_collect_symbol_completion_matches_break_on)
9167         (make_source_files_completion_list): Update.
9168         * symmisc.c (print_objfile_statistics, dump_objfile)
9169         (maintenance_print_symbols, maintenance_info_symtabs)
9170         (maintenance_check_symtabs, maintenance_info_line_tables):
9171         Update.
9172         * source.c (select_source_symtab)
9173         (forget_cached_source_info_for_objfile): Update.
9174         * objfiles.h (class objfile_compunits): Remove.
9175         (struct objfile) <compunits_range>: New typedef.
9176         (compunits): New method.
9177         * objfiles.c (objfile_relocate1): Update.
9178         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9179         * maint.c (count_symtabs_and_blocks): Update.
9180         * linespec.c (iterate_over_all_matching_symtabs): Update.
9181         * cp-support.c (add_symbol_overload_list_qualified): Update.
9182         * coffread.c (coff_symtab_read): Update.
9183         * ada-lang.c (add_nonlocal_symbols)
9184         (ada_collect_symbol_completion_matches)
9185         (ada_add_global_exceptions): Update.
9186
9187 2019-01-15  Tom Tromey  <tom@tromey.com>
9188
9189         * progspace.h (program_space) <objfiles_safe_range>: New
9190         typedef.
9191         <objfiles_safe>: New method.
9192         * objfiles.h (class all_objfiles_safe): Remove.
9193         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9194         * jit.c (jit_inferior_exit_hook): Update.
9195
9196 2019-01-17  Tom Tromey  <tom@tromey.com>
9197
9198         * progspace.h (program_space) <objfiles_range>: New typedef.
9199         <objfiles>: New method.
9200         <objfiles_head>: Rename from objfiles.
9201         (object_files): Update.
9202         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9203         * guile/scm-pretty-print.c
9204         (ppscm_find_pretty_printer_from_objfiles): Update.
9205         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9206         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9207         Update.
9208         * python/py-progspace.c (pspy_get_objfiles): Update.
9209         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9210         Update.
9211         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9212         (objfpy_lookup_objfile_by_build_id): Update.
9213         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9214         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9215         Update.
9216         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9217         (expand_symtab_containing_pc, lookup_objfile_from_block)
9218         (lookup_static_symbol, basic_lookup_transparent_type)
9219         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9220         (find_line_symtab, info_sources_command)
9221         (default_collect_symbol_completion_matches_break_on)
9222         (make_source_files_completion_list, find_main_name): Update.
9223         * symmisc.c (print_symbol_bcache_statistics)
9224         (print_objfile_statistics, maintenance_print_symbols)
9225         (maintenance_print_msymbols, maintenance_print_objfiles)
9226         (maintenance_info_symtabs, maintenance_check_symtabs)
9227         (maintenance_expand_symtabs, maintenance_info_line_tables):
9228         Update.
9229         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9230         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9231         (map_overlay_command, unmap_overlay_command)
9232         (simple_overlay_update, expand_symtabs_matching)
9233         (map_symbol_filenames): Update.
9234         * symfile-debug.c (set_debug_symfile): Update.
9235         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9236         Update.
9237         * source.c (select_source_symtab, forget_cached_source_info):
9238         Update.
9239         * solib.c (solib_read_symbols): Update.
9240         * solib-spu.c (append_ocl_sos): Update.
9241         * psymtab.c (maintenance_print_psymbols)
9242         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9243         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9244         * printcmd.c (info_symbol_command): Update.
9245         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9246         Update.
9247         * objfiles.h (class all_objfiles): Remove.
9248         * objfiles.c (have_partial_symbols, have_full_symbols)
9249         (have_minimal_symbols, qsort_cmp, update_section_map)
9250         (shared_objfile_contains_address_p)
9251         (default_iterate_over_objfiles_in_search_order): Update.
9252         * objc-lang.c (info_selectors_command, info_classes_command)
9253         (find_methods): Update.
9254         * minsyms.c (find_solib_trampoline_target): Update.
9255         * maint.c (maintenance_info_sections)
9256         (maintenance_translate_address, count_symtabs_and_blocks):
9257         Update.
9258         * main.c (captured_main_1): Update.
9259         * linux-thread-db.c (try_thread_db_load_from_pdir)
9260         (has_libpthread): Update.
9261         * linespec.c (iterate_over_all_matching_symtabs)
9262         (search_minsyms_for_name): Update.
9263         * jit.c (jit_find_objf_with_entry_addr): Update.
9264         * hppa-tdep.c (find_unwind_entry)
9265         (hppa_lookup_stub_minimal_symbol): Update.
9266         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9267         Update.
9268         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9269         (elf_gnu_ifunc_resolve_by_got): Update.
9270         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9271         * dwarf-index-write.c (save_gdb_index_command): Update.
9272         * cp-support.c (add_symbol_overload_list_qualified): Update.
9273         * breakpoint.c (create_overlay_event_breakpoint)
9274         (create_longjmp_master_breakpoint)
9275         (create_std_terminate_master_breakpoint)
9276         (create_exception_master_breakpoint): Update.
9277         * blockframe.c (find_pc_partial_function): Update.
9278         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9279         (ada_collect_symbol_completion_matches)
9280         (ada_add_global_exceptions): Update.
9281
9282 2019-01-17  Tom Tromey  <tom@tromey.com>
9283
9284         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9285         declare VEC.
9286         (solib_target_parse_libraries): Change return type.
9287         (library_list_start_segment, library_list_start_section)
9288         (library_list_end_library, library_list_start_library); Update.
9289         (solib_target_free_library_list): Remove.
9290         (solib_target_parse_libraries): Remove cleanup.  Change return
9291         type.
9292         (solib_target_current_sos): Update.
9293
9294 2019-01-17  Tom Tromey  <tromey@bapiya>
9295
9296         * valprint.c: Replace "the the" with "the".
9297         * symtab.c: Replace "the the" with "the".
9298         * solib.c: Replace "the the" with "the".
9299         * solib-dsbt.c: Replace "the the" with "the".
9300         * linespec.c: Replace "the the" with "the".
9301         * dwarf2loc.h: Replace "the the" with "the".
9302         * amd64-windows-tdep.c: Replace "the the" with "the".
9303         * aarch64-tdep.c: Replace "the the" with "the".
9304
9305 2019-01-16  Keith Seitz  <keiths@redhat.com>
9306
9307         PR gdb/23773
9308         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9309         <builder>: Rename to ..
9310         <m_builder>: ... this and make private.
9311         (dwarf2_cu::get_builder): New method.  Change all users of
9312         `builder' to use this method.
9313         (dwarf2_start_symtab): Move to ...
9314         (dwarf2_cu::start_symtab): ... here.  Update all callers
9315         (setup_type_unit_groups): Move to ...
9316         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9317         callers.
9318         (dwarf2_cu::reset_builder): New method.
9319         (process_full_compunit, process_full_type_unit): Use
9320         dwarf2_cu::reset_builder.
9321         (follow_die_offset): Record the ancestor CU if it is different
9322         from the followed DIE's CU.
9323         (follow_die_sig_1): Likewise.
9324
9325 2019-01-15  Tom Tromey  <tom@tromey.com>
9326
9327         * remote.c (class remote_state) <buf>: Now a char_vector.
9328         <buf_size>: Remove.
9329         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9330         parameter.
9331         (remote_target::getpkt_or_notif_sane_1)
9332         (remote_target::getpkt_sane)
9333         (remote_target::getpkt_or_notif_sane): Likewise.
9334         (class remote_target) <putpkt>: New overload.
9335         (remote_target::read_frame): Change type of "buf_p".  Remove
9336         sizeof_p parameter.
9337         (packet_ok): New overload.
9338         (packet_check_result): New overload.
9339         Update all uses.
9340
9341 2019-01-14  Tom Tromey  <tom@tromey.com>
9342
9343         * remote-notif.c (handle_notification, remote_notif_ack)
9344         (remote_notif_parse): Make "buf" const.
9345         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9346         const.
9347         (remote_notif_parse, remote_notif_ack, handle_notification):
9348         Likewise.
9349         * remote.c (remote_notif_stop_parse): Make "buf" const.
9350         (remote_target::remote_parse_stop_reply): Make "buf" const.
9351         (remote_notif_stop_ack): Make "buf" const.
9352
9353 2019-01-14  Tom Tromey  <tom@tromey.com>
9354
9355         * remote.c (remote_console_output): Make parameter const.
9356
9357 2019-01-14  Tom Tromey  <tom@tromey.com>
9358
9359         * target-debug.h (target_debug_print_signals): Constify.
9360         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9361         * procfs.c (procfs_target::pass_signals): Update.
9362         * linux-nat.c (linux_nat_target::pass_signals): Update.
9363         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9364         * target-delegates.c: Rebuild.
9365         * remote.c (remote_target::program_signals): Update.
9366         (remote_target::pass_signals): Update.
9367         * target.c (target_pass_signals): Constify argument.
9368         (target_program_signals): Likewise.
9369         * target.h (struct target_ops) <pass_signals, program_signals>:
9370         Constify argument.
9371         (target_pass_signals, target_program_signals): Constify argument.
9372
9373 2019-01-14  Tom Tromey  <tom@tromey.com>
9374
9375         PR tui/28819:
9376         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9377
9378 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9379
9380         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9381         field.
9382         * rs6000-tdep.c: Include reggroups.h.
9383         (IS_V_ALIAS_PSEUDOREG): Define.
9384         (rs6000_register_name): Return names for the "vX" aliases.
9385         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9386         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9387         aliases.  Call default_register_reggroup_p for all other
9388         pseudo-registers.
9389         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9390         New functions.
9391         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9392         Handle "vX" aliases.
9393         (v_alias_pseudo_register_collect): New function.
9394         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9395         (rs6000_gdbarch_init): Initialize "vX" aliases as
9396         pseudo-registers.  Restore registration of
9397         rs6000_pseudo_register_reggroup_p with
9398         set_tdesc_pseudo_register_reggroup_p.
9399
9400 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9401
9402         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9403         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9404         set_gdbarch_num_pseudo_regs.
9405
9406 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9407
9408         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9409         Remove arg prefixname, add do_set and do_show.
9410         Add member functions set_list and show_list.
9411         * cli/cli-style.c (class cli_style_option): Update accordingly.
9412         (style_set_list): Move to file scope.
9413         (style_show_list): Likewise.
9414         (set_style): Call help_list.
9415         (show_style): Call cmd_show_list.
9416         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9417         Update to use the new macro.
9418
9419 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9420
9421         * ada-lang.c (_initialize_ada_language): Expand the help text
9422         for the "catch exception" command.
9423
9424 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9425
9426         * symtab.c (matching_obj_sections): Initialize obj,
9427         declare it closer to its usage.
9428
9429 2019-01-10  Tom Tromey  <tom@tromey.com>
9430
9431         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9432         (basic_inf_threads_range): Remove.
9433         (inf_threads_range, inf_non_exited_threads_range)
9434         (safe_inf_threads_range): Use next_adapter.
9435
9436 2019-01-10  Keith Seitz  <keiths@redhat.com>
9437
9438         PR gdb/23712
9439         PR symtab/23010
9440         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9441         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9442
9443 2019-01-10  Keith Seitz  <keiths@redhat.com>
9444
9445         PR gdb/23712
9446         PR symtab/23010
9447         * dictionary.c (pending_to_vector): Remove.
9448         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9449         Remove _1 suffix, replacing functions of the same name.  Update
9450         all callers.
9451         (dict_create_hashed, dict_create_hashed_expandable)
9452         (dict_create_linear, dict_create_linear_expandable, dict_free)
9453         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9454         Make functions static.
9455
9456 2019-01-10  Keith Seitz  <keiths@redhat.com>
9457
9458         PR gdb/23712
9459         PR symtab/23010
9460         * dictionary.h (struct dictionary): Replace declaration with
9461         multidictionary.
9462         (dict_create_hashed, dict_create_hashed_expandable)
9463         (dict_create_linear, dict_create_linear_expandable)
9464         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9465         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9466         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9467         taking multidictionary argument.
9468         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9469         * block.h (struct block) <dict>: Change to multidictionary
9470         and rename `multidict'.
9471         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9472         symmisc.c: Update all dictionary references to multidictionary.
9473
9474 2019-01-10  Keith Seitz  <keiths@redhat.com>
9475
9476         PR gdb/23712
9477         PR symtab/23010
9478         * dictionary.c: Include unordered_map.
9479         (pending_to_vector): New function.
9480         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9481         Rewrite the non-"_1" functions to take vector instead
9482         of linked list.
9483         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9484         "new" _1 versions of the same name.
9485         (multidictionary): Define.
9486         (std::hash<enum language): New definition.
9487         (collate_pending_symbols_by_language, mdict_create_hashed)
9488         (mdict_create_hashed_expandable, mdict_create_linear)
9489         (mdict_create_linear_expandable, mdict_free)
9490         (find_language_dictionary, create_new_language_dictionary)
9491         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9492         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9493         (mdict_size, mdict_empty): New functions.
9494         * dictionary.h (mdict_iterator): Define.
9495
9496 2019-01-10  Pedro Alves  <palves@redhat.com>
9497
9498         * breakpoint.c (read_uploaded_action)
9499         (create_tracepoint_from_upload): Adjust to use
9500         gdb::unique_xmalloc_ptr.
9501         * ctf.c (ctf_write_uploaded_tp):
9502         (SET_ARRAY_FIELD): Use emplace_back.
9503         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9504         * tracefile-tfile.c (tfile_write_uploaded_tp):
9505         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9506         gdb::unique_xmalloc_ptr.
9507         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9508         at_string, cond_string, cmd_strings>: Replace char pointers
9509         with gdb::unique_xmalloc_ptr.
9510
9511 2019-01-10  Pedro Alves  <palves@redhat.com>
9512
9513         * solib-target.c (library_list_start_library): Don't xstrdup name.
9514
9515 2019-01-10  Pedro Alves  <palves@redhat.com>
9516
9517         * mdebugread.c (parse_partial_symbols): Use
9518         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9519
9520 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9521
9522         * linux-fork.c (scoped_switch_fork_info)
9523         <~scoped_switch_fork_info>: Fix incorrect variable name.
9524
9525 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9526
9527         * linux-fork.c (scoped_switch_fork_info)
9528         <scoped_switch_fork_info>: Make explicit.
9529         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9530
9531 2019-01-10  Tom Tromey  <tom@tromey.com>
9532
9533         * objfiles.h (objfile::reset_psymtabs): Update.
9534         * objfiles.c (objfile::objfile): Update.
9535         * psymtab.h (psymtab_storage::obstack): Update.
9536         (psymtab_storage::m_obstack): Use gdb::optional.
9537         (class psymtab_storage): Update comment.  Remove objfile
9538         parameter.
9539         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9540
9541 2019-01-10  Tom Tromey  <tom@tromey.com>
9542
9543         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9544         <free_psymtabs>: Now private.
9545         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9546         (allocate_psymtab): Use new method.
9547
9548 2019-01-10  Tom Tromey  <tom@tromey.com>
9549
9550         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9551         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9552         * mdebugread.c (parse_partial_symbols): Use
9553         allocate_dependencies.
9554         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9555         allocate_dependencies.
9556         (process_psymtab_comp_unit_reader)
9557         (build_type_psymtab_dependencies): Likewise.
9558         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9559
9560 2019-01-10  Tom Tromey  <tom@tromey.com>
9561
9562         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9563         PSYMBOL_SET_LANGUAGE.
9564         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9565
9566 2019-01-10  Tom Tromey  <tom@tromey.com>
9567
9568         * psymtab.h (psymtab_storage::obstack): New method.
9569         <m_obstack>: Rename from obstack; now private.
9570         * psymtab.c (psymtab_storage): Update.
9571         * dwarf2read.c (create_addrmap_from_index)
9572         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9573         Update.
9574
9575 2019-01-10  Tom Tromey  <tom@tromey.com>
9576
9577         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9578         * objfiles.h (objfile::reset_psymtabs): New method.
9579
9580 2019-01-10  Tom Tromey  <tom@tromey.com>
9581
9582         * symmisc.c (print_symbol_bcache_statistics): Update.
9583         (print_objfile_statistics): Update.
9584         * symfile.c (reread_symbols): Update.
9585         * psymtab.h (class psymtab_storage): New.
9586         * psymtab.c (psymtab_storage): New constructor.
9587         (~psymtab_storage): New destructor.
9588         (require_partial_symbols): Update.
9589         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9590         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9591         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9592         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9593         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9594         (start_psymtab_common, end_psymtab_common)
9595         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9596         (allocate_psymtab): Update.
9597         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9598         Update.
9599         (dump_psymtab_addrmap, maintenance_print_psymbols)
9600         (maintenance_check_psymtabs): Update.
9601         (class objfile_psymtabs): Move to objfiles.h.
9602         * psympriv.h (discard_psymtab): Now inline.
9603         (psymtab_discarder::psymtab_discarder): Update.
9604         (psymtab_discarder::~psymtab_discarder): Update.
9605         (ALL_OBJFILE_PSYMTABS): Rewrite.
9606         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9607         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9608         Remove fields.
9609         <partial_symtabs>: New field.
9610         (class objfile_psymtabs): Move from psymtab.h.  Update.
9611         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9612         psymbol_cache.
9613         (objfile::~objfile): Don't destroy psymbol_cache.
9614         * mdebugread.c (parse_partial_symbols): Update.
9615         * dwarf2read.c (create_addrmap_from_index)
9616         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9617         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9618         (add_partial_subprogram, dwarf2_ranges_read): Update.
9619         * dwarf-index-write.c (write_address_map)
9620         (write_one_signatured_type, recursively_write_psymbols)
9621         (class debug_names, class debug_names, write_psymtabs_to_index):
9622         Update.
9623
9624 2019-01-10  Tom Tromey  <tom@tromey.com>
9625
9626         * symtab.h (SYMBOL_SET_NAMES): Update.
9627         (symbol_set_names): Update.
9628         (MSYMBOL_SET_NAMES): Update.
9629         * symtab.c (symbol_set_names): Change argument to be an
9630         objfile_per_bfd_storage.
9631         * psymtab.c (add_psymbol_to_bcache): Update.
9632         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9633
9634 2019-01-10  Tom Tromey  <tom@tromey.com>
9635
9636         * symtab.c (create_demangled_names_hash): Change argument to be an
9637         objfile_per_bfd_storage.
9638         (symbol_set_names): Update.
9639
9640 2019-01-10  Tom Tromey  <tom@tromey.com>
9641
9642         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9643         init_psymbol_list.
9644         * psymtab.c (init_psymbol_list): Do nothing if already called.
9645         * psympriv.h (init_psymbol_list): Add comment.
9646         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9647         init_psymbol_list.
9648         * dbxread.c (dbx_symfile_read): Unconditionally call
9649         init_psymbol_list.
9650
9651 2019-01-10  Tom Tromey  <tom@tromey.com>
9652
9653         * xcoffread.c (scan_xcoff_symtab): Update.
9654         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9655         "where".
9656         * mdebugread.c (parse_partial_symbols)
9657         (handle_psymbol_enumerators): Update.
9658         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9659         * dbxread.c (read_dbx_symtab): Update.
9660         * psympriv.h (psymbol_placement): New enum.
9661         (add_psymbol_to_list): Update.
9662
9663 2019-01-10  Tom Tromey  <tom@tromey.com>
9664
9665         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9666         static_psymbols parameters.
9667         (scan_xcoff_symtab): Update.
9668         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9669         static_psymbols parameters.
9670         * psympriv.h (start_psymtab_common): Update.
9671         * mdebugread.c (parse_partial_symbols): Update.
9672         * dwarf2read.c (create_partial_symtab): Update.
9673         * dbxread.c (read_dbx_symtab): Update.
9674         (start_psymtab): Remove global_psymbols and static_psymbols
9675         parameters.
9676
9677 2019-01-10  Tom Tromey  <tom@tromey.com>
9678
9679         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9680         * psymtab.c (allocate_psymtab): Add comment.
9681         * psympriv.h (allocate_psymtab): Add comment.
9682         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9683         initializations.
9684         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9685
9686 2019-01-10  Tom Tromey  <tom@tromey.com>
9687
9688         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9689         Don't declare.
9690         * mipsread.c: Include mdebugread.h.
9691         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9692         Declare.
9693         * elfread.c: Include mdebugread.h.
9694
9695 2019-01-09  Tom Tromey  <tom@tromey.com>
9696
9697         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9698         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9699         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9700         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9701         (psym_lookup_symbol, psym_find_last_source_symtab)
9702         (psym_forget_cached_source_info, psym_print_stats)
9703         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9704         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9705         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9706         (psym_find_compunit_symtab_by_address)
9707         (maintenance_print_psymbols, maintenance_info_psymtabs)
9708         (maintenance_check_psymtabs): Use ranged for.
9709         * psymtab.h (class objfile_psymtabs): New.
9710         (require_partial_symbols): Return objfile_psymtabs.
9711         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9712
9713 2019-01-09  Tom Tromey  <tom@tromey.com>
9714
9715         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9716         (find_pc_mapped_section, list_overlays_command)
9717         (map_overlay_command, unmap_overlay_command)
9718         (simple_overlay_update): Use all_objfiles.
9719         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9720         * printcmd.c (info_symbol_command): Use all_objfiles.
9721         * objfiles.h (ALL_OBJSECTIONS): Remove.
9722         * maint.c (maintenance_translate_address): Use all_objfiles.
9723         * gcore.c (gcore_create_callback): Use all_objfiles.
9724         (objfile_find_memory_regions): Likewise.
9725
9726 2019-01-09  Tom Tromey  <tom@tromey.com>
9727
9728         * symtab.c (find_line_symtab, info_sources_command)
9729         (make_source_files_completion_list): Use objfile_compunits.
9730         * source.c (select_source_symtab): Use objfile_compunits.
9731         * objfiles.h (struct objfile): Update comment.
9732         (ALL_OBJFILES): Remove.
9733         (ALL_FILETABS): Remove.
9734         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9735         objfile_compunits.
9736
9737 2019-01-09  Tom Tromey  <tom@tromey.com>
9738
9739         * symmisc.c (print_objfile_statistics, dump_objfile)
9740         (maintenance_print_symbols): Use compunit_filetabs.
9741         * source.c (forget_cached_source_info_for_objfile): Use
9742         compunit_filetabs.
9743         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9744         (ALL_FILETABS): Use compunit_filetabs.
9745         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9746         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9747
9748 2019-01-09  Tom Tromey  <tom@tromey.com>
9749
9750         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9751         (compunit_filetabs): New.
9752         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9753         compunit_filetabs.
9754         (info_sources_command, make_source_files_completion_list): Remove
9755         declaration.
9756         * symmisc.c (print_objfile_statistics, dump_objfile)
9757         (maintenance_print_symbols): Remove declaration.
9758         (maintenance_info_symtabs): Use compunit_filetabs.
9759         (maintenance_info_line_tables): Likewise.
9760         * source.c (select_source_symtab): Change local variable name.
9761         (forget_cached_source_info_for_objfile): Remove declaration.
9762         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9763         * objfiles.c (objfile_relocate1): Remove declaration.
9764         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9765         declaration.
9766         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9767         * coffread.c (coff_symtab_read): Remove declaration.
9768         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9769         compunit_filetabs.
9770
9771 2019-01-09  Tom Tromey  <tom@tromey.com>
9772
9773         * symtab.c (lookup_objfile_from_block)
9774         (find_pc_sect_compunit_symtab, search_symbols)
9775         (default_collect_symbol_completion_matches_break_on): Use
9776         objfile_compunits.
9777         * objfiles.h (ALL_COMPUNITS): Remove.
9778         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9779         * cp-support.c (add_symbol_overload_list_qualified): Use
9780         objfile_compunits.
9781         * ada-lang.c (ada_collect_symbol_completion_matches)
9782         (ada_add_global_exceptions): Use objfile_compunits.
9783
9784 2019-01-09  Tom Tromey  <tom@tromey.com>
9785
9786         * source.c (select_source_symtab)
9787         (forget_cached_source_info_for_objfile): Remove declaration.
9788         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9789         declaration.
9790         * maint.c (count_symtabs_and_blocks): Remove declaration.
9791         * cp-support.c (add_symbol_overload_list_qualified): Remove
9792         declaration.
9793         * coffread.c (coff_symtab_read): Remove declaration.
9794         * symtab.c (lookup_symbol_in_objfile_symtabs)
9795         (basic_lookup_transparent_type_1): Use objfile_compunits.
9796         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9797         (info_sources_command, search_symbols)
9798         (default_collect_symbol_completion_matches_break_on)
9799         (make_source_files_completion_list): Remove declaration.
9800         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9801         (ada_collect_symbol_completion_matches)
9802         (ada_add_global_exceptions): Remove declaration.
9803         * linespec.c (iterate_over_all_matching_symtabs): Use
9804         objfile_compunits.
9805         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9806         (class objfile_compunits): New.
9807         (ALL_COMPUNITS): Use objfile_compunits.
9808         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9809         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9810         objfile_compunits.
9811         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9812
9813 2019-01-09  Tom Tromey  <tom@tromey.com>
9814
9815         * symtab.c (search_symbols)
9816         (default_collect_symbol_completion_matches_break_on): Use
9817         objfile_msymbols.
9818         * ada-lang.c (ada_lookup_simple_minsym)
9819         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9820         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9821         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9822         objfile_msymbols.
9823         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9824         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9825         * objc-lang.c (find_methods): Use objfile_msymbols.
9826         (info_selectors_command, info_classes_command): Likewise.
9827         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9828         * objfiles.h (class objfile_msymbols): New.
9829         (ALL_OBJFILE_MSYMBOLS): Remove.
9830         (ALL_MSYMBOLS): Remove.
9831
9832 2019-01-09  Tom Tromey  <tom@tromey.com>
9833
9834         * common/next-iterator.h (next_adapter): Add Iterator template
9835         parameter.
9836         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9837         (class all_objfiles_safe): New.
9838         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9839         * objfiles.c (put_objfile_before): Update comment.
9840         (add_separate_debug_objfile): Likewise.
9841         (free_all_objfiles): Use all_objfiles_safe.
9842         (objfile_purge_solibs): Likewise.
9843
9844 2019-01-09  Tom Tromey  <tom@tromey.com>
9845
9846         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9847         (expand_symtab_containing_pc, lookup_static_symbol)
9848         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9849         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9850         all_objfiles.
9851         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9852         * breakpoint.c (create_overlay_event_breakpoint)
9853         (create_longjmp_master_breakpoint)
9854         (create_std_terminate_master_breakpoint)
9855         (create_exception_master_breakpoint): Use all_objfiles.
9856         * linux-thread-db.c (try_thread_db_load_from_pdir)
9857         (has_libpthread): Use all_objfiles.
9858         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9859         * linespec.c (iterate_over_all_matching_symtabs)
9860         (search_minsyms_for_name): Use all_objfiles.
9861         * maint.c (maintenance_info_sections): Use all_objfiles.
9862         * main.c (captured_main_1): Use all_objfiles.
9863         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9864         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9865         * guile/scm-pretty-print.c
9866         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9867         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9868         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9869         (maintenance_print_msymbols): Use all_objfiles.
9870         * source.c (select_source_symtab): Use all_objfiles.
9871         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9872         * symfile.c (remove_symbol_file_command)
9873         (expand_symtabs_matching, map_symbol_filenames): Use
9874         all_objfiles.
9875         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9876         all_objfiles.
9877         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9878         * objc-lang.c (find_methods): Use all_objfiles.
9879         * objfiles.c (have_partial_symbols, have_full_symbols)
9880         (have_minimal_symbols, qsort_cmp)
9881         (default_iterate_over_objfiles_in_search_order): Use
9882         all_objfiles.
9883         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9884         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9885         (maintenance_check_psymtabs): Use all_objfiles.
9886         (ALL_PSYMTABS): Remove.
9887         * compile/compile-object-run.c (do_module_cleanup): Use
9888         all_objfiles.
9889         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9890         * cp-support.c (add_symbol_overload_list_qualified): Use
9891         all_objfiles.
9892         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9893         Use all_objfiles.
9894         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9895         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9896         all_objfiles.
9897         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9898         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9899         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9900         Uses all_objfiles.
9901         * solib.c (solib_read_symbols): Use all_objfiles
9902
9903 2019-01-09  Tom Tromey  <tom@tromey.com>
9904
9905         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9906         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9907         all_objfiles.
9908         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9909         * symmisc.c (print_symbol_bcache_statistics)
9910         (print_objfile_statistics, maintenance_print_objfiles)
9911         (maintenance_info_symtabs, maintenance_check_symtabs)
9912         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9913         all_objfiles.
9914         * source.c (forget_cached_source_info): Use all_objfiles.
9915         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9916         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9917         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9918         * objfiles.c (update_section_map): Use all_objfiles.
9919         (shared_objfile_contains_address_p): Likewise.
9920         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9921         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9922
9923 2019-01-09  Tom Tromey  <tom@tromey.com>
9924
9925         * common/next-iterator.h: New file.
9926         * objfiles.h (class all_objfiles): New.
9927         (struct objfile_iterator): New.
9928
9929 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9930
9931         * NEWS: Move the description of the changed "frame", "select-frame",
9932          and "info frame" commands to the Changed commands section.
9933
9934 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9935
9936         * gdbtypes.c (check_stub_method_group): Remove handling of old
9937         mangling schemes.
9938         * linespec.c (find_methods): Likewise.
9939         * stabsread.c (read_member_functions): Likewise.
9940         * valops.c (search_struct_method): Likewise.
9941         (value_struct_elt_for_reference): Likewise.
9942         * NEWS: Mention this change.
9943
9944 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9945
9946         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9947         print_source_lines.
9948         * source.c (print_source_lines_base): Update line number check.
9949         (print_source_lines): New function.
9950         (source_lines_range::source_lines_range): New function.
9951         * source.h (class source_lines_range): New class.
9952         (print_source_lines): New declaration.
9953
9954 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9955
9956         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9957
9958 2019-01-08  Tom Tromey  <tom@tromey.com>
9959             Simon Marchi  <simon.marchi@ericsson.com>
9960
9961         PR gdb/24060
9962         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9963         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9964         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9965         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9966         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9967         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9968
9969 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9970
9971         * source.c (select_source_symtab): Move header comment to
9972         declaration in source.h.
9973         (forget_cached_source_info_for_objfile): Likewise.
9974         (forget_cached_source_info): Likewise.
9975         (identify_source_line): Likewise.
9976         * source.h (identify_source_line): Move declaration from symtab.h
9977         and add comment from source.c
9978         (print_source_lines): Likewise.
9979         (forget_cached_source_info_for_objfile): Likewise.
9980         (forget_cached_source_info): Likewise.
9981         (select_source_symtab): Likewise.
9982         (enum print_source_lines_flag): Move definition from symtab.h.
9983         * symtab.h (identify_source_line): Move declaration to source.h.
9984         (print_source_lines): Likewise.
9985         (forget_cached_source_info_for_objfile): Likewise.
9986         (forget_cached_source_info): Likewise.
9987         (select_source_symtab): Likewise.
9988         (enum print_source_lines_flag): Move definition to source.h.
9989         * tui/tui-hooks.c: Add 'source.h' include.
9990
9991 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9992
9993         * source.c (print_source_lines_base): Handle requests to print
9994         reverse line number sequences, and guard against empty lines
9995         string.
9996
9997 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9998
9999         * source.c (print_source_lines_base): Fix skip of '\r' if next
10000         character is '\n'.
10001
10002 2019-01-06  Tom Tromey  <tom@tromey.com>
10003
10004         * c-exp.y (struct c_parse_state) <macro_original_text,
10005         expansion_obstack>: New member.
10006         (macro_original_text, expansion_obstack): Remove globals.
10007         (scan_macro_expansion, scanning_macro_expansion)
10008         (finished_macro_expansion): Update.
10009         (scan_macro_cleanup): Remove.
10010         (yylex, c_parse): Update.
10011
10012 2019-01-06  Tom Tromey  <tom@tromey.com>
10013
10014         * c-exp.y (struct c_parse_state) <strings>: New member.
10015         (operator_stoken): Update.
10016
10017 2019-01-06  Tom Tromey  <tom@tromey.com>
10018
10019         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10020         (union type_stack_elt) <typelist_val>: Now a pointer to
10021         std::vector.
10022         (type_stack_cleanup): Don't declare.
10023         (push_typelist): Update.
10024         * parse.c (pop_typelist): Return a std::vector.
10025         (push_typelist): Take a std::vector.
10026         (follow_types): Update.  Do not free args.
10027         (type_stack_cleanup): Remove.
10028         * c-exp.y (struct c_parse_state): New.
10029         (cpstate): New global.
10030         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10031         (nonempty_typelist): Update.
10032         (func_mod): Create a new vector.
10033         (c_parse): Create a c_parse_state.
10034         (check_parameter_typelist): Do not delete params.
10035         (function_method): Update.  Do not delete type_list.
10036
10037 2019-01-06  Tom Tromey  <tom@tromey.com>
10038
10039         PR gdb/28155:
10040         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10041         check_typedef.
10042         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10043         (print_return_value): Likewise.
10044
10045 2019-01-05  Tom Tromey  <tom@tromey.com>
10046
10047         * contrib/cleanup_check.py: Remove.
10048         * contrib/gcc-with-excheck: Remove.
10049         * contrib/exsummary.py: Remove.
10050         * contrib/excheck.py: Remove.
10051
10052 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10053
10054         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10055         NULL. Initialize tpprev to NULL instead of assigning it
10056         to NULL on the next statement.
10057         * windows-nat.c (windows_delete_thread): Remove check for
10058         main_thread_id before printing thread exit notifications.
10059         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10060         Remove thread ID check against main_thread_id.
10061         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10062         windows_delete_thread.
10063         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10064
10065 2019-01-04  Tom Tromey  <tom@tromey.com>
10066
10067         * compile/compile.c (_initialize_compile): Use upper case for
10068         metasyntactic variables.
10069         * symmisc.c (_initialize_symmisc): Use upper case for
10070         metasyntactic variables.
10071         * psymtab.c (_initialize_psymtab): Use upper case for
10072         metasyntactic variables.
10073         * demangle.c (demangle_command): Use upper case for metasyntactic
10074         variables.
10075         (_initialize_demangler): Likewise.
10076         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10077         variables.
10078
10079 2019-01-03  Tom Tromey  <tom@tromey.com>
10080
10081         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10082
10083 2019-01-03  Tom Tromey  <tom@tromey.com>
10084
10085         * python/py-symtab.c (salpy_str): Update.
10086         (struct salpy_sal_object) <symtab>: Now a PyObject.
10087         (salpy_dealloc): Update.
10088         (del_objfile_sal): Use gdbpy_ref.
10089
10090 2019-01-03  Tom Tromey  <tom@tromey.com>
10091
10092         * python/py-type.c (convert_field): Use new_reference.  Return
10093         gdbpy_ref.
10094         (make_fielditem): Return gdbpy_ref.
10095         (typy_fields): Update.
10096         (typy_getitem): Update.
10097         (field_name): Return gdbpy_ref.  Use new_reference.
10098         (typy_iterator_iternext): Update.
10099
10100 2019-01-03  Tom Tromey  <tom@tromey.com>
10101
10102         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10103
10104 2019-01-03  Tom Tromey  <tom@tromey.com>
10105
10106         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10107         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10108         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10109         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10110         (pspy_set_type_printers): Likewise.
10111         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10112         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10113         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10114         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10115         (objfpy_set_type_printers): Likewise.
10116
10117 2019-01-03  Tom Tromey  <tom@tromey.com>
10118
10119         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10120         (gdbpy_print_stack): Use gdbpy_err_fetch.
10121         * python/python-internal.h (class gdbpy_err_fetch): New class.
10122         (class gdbpy_enter) <m_error_type, m_error_value,
10123         m_error_traceback>: Remove.
10124         <m_error>: New member.
10125         (gdbpy_exception_to_string): Don't declare.
10126         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10127         * python/py-value.c (convert_value_from_python): Use
10128         gdbpy_err_fetch.
10129         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10130         gdbpy_exception_to_string.
10131         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10132         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10133         gdbpy_err_fetch.
10134
10135 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10136
10137         * linux-nat.c (delete_lwp_cleanup): Delete.
10138         (struct lwp_deleter): New struct.
10139         (lwp_info_up): New typedef.
10140         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10141         lwp_info_up.
10142
10143 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10144
10145         * linux-fork.c (class scoped_switch_fork_info): New class.
10146         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10147
10148 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10149
10150         * valops.c (find_overload_match): Remove use of null_cleanup, and
10151         calls to do_cleanups.
10152
10153 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10154
10155         * compile/compile-cplus-types.c
10156         (compile_cplus_instance::decl_name): Handle changes to
10157         cp_func_name.
10158         * cp-support.c (cp_func_name): Update header comment, update
10159         return type.
10160         * cp-support.h (cp_func_name): Update return type in declaration.
10161         * valops.c (find_overload_match): Move temp_func local to top
10162         level of function and change its type.  Use temp_func to hold and
10163         delete temporary string obtained from cp_func_name.
10164
10165 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10166
10167         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10168         gdb::char_vector, remove cleanup, and update uses of `msg`.
10169
10170 2019-01-03  Jim Wilson  <jimw@sifive.com>
10171
10172         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10173
10174 2019-01-02  Tom Tromey  <tom@tromey.com>
10175
10176         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10177         (tdesc_parse_xml): Remove cleanups.
10178         * target-descriptions.h (make_cleanup_free_target_description):
10179         Don't declare.
10180         (target_desc_deleter): New struct.
10181         (target_desc_up): New typedef.
10182         * target-descriptions.c (target_desc_deleter::operator()): Rename
10183         from free_target_description.
10184         (make_cleanup_free_target_description): Remove.
10185
10186 2019-01-02  Tom Tromey  <tom@tromey.com>
10187
10188         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10189         constructor, destructor.
10190         (linespec_parser): Remove typedef.
10191         (~linespec_parser): Rename from linespec_parser_delete.
10192         (linespec_lex_to_end, linespec_complete_label)
10193         (linespec_complete): Update.
10194         (decode_line_full): Remove cleanups.
10195         (decode_line_1): Update.
10196
10197 2019-01-02  Tom Tromey  <tom@tromey.com>
10198
10199         * python/python-internal.h (inferior_to_inferior_object): Change
10200         return type.
10201         * python/py-exitedevent.c (create_exited_event_object): Update.
10202         * python/py-inferior.c (inferior_to_inferior_object): Return
10203         gdbpy_ref.
10204         (python_new_inferior, python_inferior_deleted)
10205         (thread_to_thread_object, delete_thread_object)
10206         (build_inferior_list, gdbpy_selected_inferior): Update.
10207         * python/py-infthread.c (create_thread_object): Update.  Also fail
10208         if inferior_to_inferior_object fails.
10209
10210 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10211
10212         * inferior.h (class inferior) <displaced_step_state>: New field.
10213         * infrun.h (struct displaced_step_state): Move here from
10214         infrun.c.  Initialize fields, add constructor.
10215         <inf>: Remove field.
10216         <reset>: New method.
10217         * infrun.c (struct displaced_step_inferior_state): Move to
10218         infrun.h.
10219         (displaced_step_inferior_states): Remove.
10220         (get_displaced_stepping_state): Adust.
10221         (displaced_step_in_progress_any_inferior): Adjust.
10222         (displaced_step_in_progress_thread): Adjust.
10223         (displaced_step_in_progress): Adjust.
10224         (add_displaced_stepping_state): Remove.
10225         (get_displaced_step_closure_by_addr): Adjust.
10226         (remove_displaced_stepping_state): Remove.
10227         (infrun_inferior_exit): Call displaced_step_state.reset.
10228         (use_displaced_stepping): Don't check for NULL.
10229         (displaced_step_prepare_throw): Call
10230         get_displaced_stepping_state.
10231         (displaced_step_fixup): Don't check for NULL.
10232         (prepare_for_detach): Don't check for NULL.
10233
10234 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10235
10236         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10237          in case of call that did not complete.
10238
10239 2019-01-02  Andrey Utkin  <autkin@undo.io>
10240
10241         * symfile.c (find_separate_debug_file): Fix search of debug files for
10242         remote debuggee.
10243
10244 2019-01-02  Tom Tromey  <tom@tromey.com>
10245
10246         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10247         indentation.
10248         * python/py-frame.c (frapy_older): Remove cast.
10249         (frapy_newer): Likewise.
10250         * python/py-breakpoint.c (local_setattro): Remove cast.
10251         * python/py-arch.c (archpy_name): Remove local variable.
10252         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10253
10254 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10255
10256         * unittests/basic_string_view/element_access/char/empty.cc:
10257         Fix year range in copyright header.
10258
10259 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10260
10261         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10262         Delete.
10263         <operator==>: Update with for removed field.
10264         <hash>: Likewise.
10265         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10266         <isa_features>: ...this.
10267         <abi_features>: New field.
10268         (riscv_isa_flen): Update comment.
10269         (riscv_abi_xlen): New declaration.
10270         (riscv_abi_flen): New declaration.
10271         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10272         isa_features.
10273         (riscv_abi_xlen): New function.
10274         (riscv_isa_flen): Update to get answer from isa_features.
10275         (riscv_abi_flen): New function.
10276         (riscv_has_fp_abi): Update to get answer from abi_features.
10277         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10278         xlen and flen.
10279         (riscv_call_info) <xlen, flen>: Update comment.
10280         (riscv_call_arg_struct): Remove invalid assertions
10281         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10282         is removed.
10283         (riscv_gdbarch_init): Gather isa features and abi features
10284         separately, ensure both match on the gdbarch when reusing an old
10285         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10286         a target with 64-bit float hardware.
10287
10288 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10289
10290         * source.c (search_command_helper): Stop reverse search
10291         when line 1 has been searched.
10292
10293 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10294
10295         * record-full.c (record_full_base_target::close): Rewrite
10296         record_full_core_buf_list free logic.
10297
10298 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10299
10300         * break-catch-syscall.c (print_one_catch_syscall): xfree
10301         the last text.
10302
10303 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10304
10305         * top.c (print_gdb_version): Update Copyright year in version
10306         message.
10307
10308 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10309
10310         Update copyright year range in all GDB files.
10311
10312 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10313
10314         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10315
10316 For older changes see ChangeLog-2018.
10317 \f
10318 Local Variables:
10319 mode: change-log
10320 left-margin: 8
10321 fill-column: 74
10322 version-control: never
10323 coding: utf-8
10324 End:
10325