Make do_is_mi_like_p const.
[external/binutils.git] / gdb / ChangeLog
1 2018-04-30  Tom Tromey  <tom@tromey.com>
2
3         * ui-out.c: Update.
4         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
5         * ui-out.h (ui_out::is_mi_like_p): Now const.
6         (ui_out::do_is_mi_like_p): Now const.
7         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
8
9 2018-04-30  Tom Tromey  <tom@tromey.com>
10
11         * varobj.c (varobj_set_visualizer): Use new_reference.
12         * python/python.c (gdbpy_decode_line): Use new_reference.
13         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
14         new_reference.
15
16 2018-04-30  Tom Tromey  <tom@tromey.com>
17
18         * varobj.c (install_new_value): Use new_reference.
19         * value.h (value_incref): Return void.  Swap intro comment with
20         value_decref.
21         * value.c (set_value_parent): Use new_reference.
22         (value_incref): Return void.  Update intro comment.
23         (release_value): Use new_reference.
24         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
25
26 2018-04-30  Tom Tromey  <tom@tromey.com>
27
28         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
29         * gdb_bfd.h (new_bfd_ref): Remove.
30         (gdb_bfd_open): Update comment.
31         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
32         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
33         (gdb_bfd_fdopenr): Use new_reference.
34         * exec.c (exec_file_attach): Use new_reference.
35
36 2018-04-30  Tom Tromey  <tom@tromey.com>
37
38         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
39         method.
40
41 2018-04-30  Tom Tromey  <tom@tromey.com>
42
43         * jit.c (jit_read_code_entry): Use type_align.
44         * i386-tdep.c (i386_gdbarch_init): Don't call
45         set_gdbarch_long_long_align_bit.
46         * gdbarch.sh: Remove long_long_align_bit.
47         * gdbarch.c, gdbarch.h: Rebuild.
48         * arc-tdep.c (arc_type_align): New function.
49         (arc_gdbarch_init): Use arc_type_align.  Don't call
50         set_gdbarch_long_long_align_bit.
51
52 2018-04-30  Tom Tromey  <tom@tromey.com>
53
54         * rust-lang.c (rust_type_alignment): Remove.
55         (rust_composite_type): Use type_align.
56
57 2018-04-30  Tom Tromey  <tom@tromey.com>
58
59         * NEWS: Mention Type.align.
60         * python/py-type.c (typy_get_alignof): New function.
61         (type_object_getset): Add "alignof".
62
63 2018-04-30  Tom Tromey  <tom@tromey.com>
64
65         PR exp/17095:
66         * NEWS: Update.
67         * std-operator.def (UNOP_ALIGNOF): New operator.
68         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
69         New.
70         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
71         * c-lang.c (c_op_print_tab): Add alignof.
72         * c-exp.y (ALIGNOF): New token.
73         (exp): Add "ALIGNOF" production.
74         (ident_tokens): Add _Alignof and alignof.
75
76 2018-04-30  Tom Tromey  <tom@tromey.com>
77
78         * i386-tdep.c (i386_type_align): New function.
79         (i386_gdbarch_init): Update.
80         * gdbarch.sh (type_align): New method.
81         * gdbarch.c, gdbarch.h: Rebuild.
82         * arch-utils.h (default_type_align): Declare.
83         * arch-utils.c (default_type_align): New function.
84         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
85         (struct type) <align_log2>: New field.
86         <instance_flags>: Now a bitfield.
87         (TYPE_RAW_ALIGN): New macro.
88         (type_align, type_raw_align, set_type_align): Declare.
89         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
90         functions.
91         * dwarf2read.c (quirk_rust_enum): Set type alignment.
92         (get_alignment, maybe_set_alignment): New functions.
93         (read_structure_type, read_enumeration_type, read_array_type)
94         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
95         (read_subrange_type, read_base_type): Set type alignment.
96
97 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
98
99         * dwarf2read.c (read_index_from_section): Use bool.
100
101 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
102
103         PR gdb/22950
104         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
105         with #ifdef.
106
107 2018-04-29  John Reiser  <jreiser@BitWagon.com>
108
109         PR build/22873
110         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
111         last step, and do it atomically.
112
113 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
114
115         * compile/compile-c-types.c (convert_int, convert_float):
116         Update for C FE v1.
117
118 2018-04-27  Tom Tromey  <tom@tromey.com>
119
120         PR rust/22545:
121         * rust-lang.c (rust_inclusive_range_type_p): New function.
122         (rust_range): Handle inclusive ranges.
123         (rust_compute_range): Likewise.
124         * rust-exp.y (struct rust_op) <inclusive>: New field.
125         (DOTDOTEQ): New constant.
126         (range_expr): Add "..=" productions.
127         (operator_tokens): Add "..=" token.
128         (ast_range): Add "inclusive" parameter.
129         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
130         ranges.
131         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
132         bounds values.
133         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
134         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
135         Update comments.
136         * expprint.c (print_subexp_standard): Handle new bounds values.
137         (dump_subexp_body_standard): Likewise.
138
139 2018-04-27  Tom Tromey  <tom@tromey.com>
140
141         * configure: Rebuild.
142         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
143         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
144         "OVERRIDE".
145         (class symbol_needs_eval_context): Likewise.
146         * dwarf2read.c (mock_mapped_index::symbol_name_count)
147         (mock_mapped_index::symbol_name_at): Use "override".  Remove
148         "virtual".
149         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
150         "override".
151         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
152         * aarch64-tdep.c (instruction_reader::read): Use "override".
153         (instruction_reader_test::read): Likewise.
154         * arm-tdep.c (instruction_reader::read): Use "override".
155         (instruction_reader_thumb::read): Likewise.
156
157 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
158
159         PR remote/9665
160         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
161         instead of remote_send.
162         (remote_send): Remove.
163
164 2018-04-26  Pedro Alves  <palves@redhat.com>
165
166         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
167         find_function_start_sal instead of find_pc_line.
168
169 2018-04-26  Pedro Alves  <palves@redhat.com>
170
171         * breakpoint.c (set_breakpoint_location_function): Handle
172         mst_data_gnu_ifunc.
173         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
174         * elfread.c (elf_symtab_read): Give data symbols with
175         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
176         (elf_rel_plt_read): Update comment.
177         * linespec.c (convert_linespec_to_sals): Handle
178         mst_data_gnu_ifunc.
179         (minsym_found): Handle mst_data_gnu_ifunc.
180         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
181         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
182         * parse.c (find_minsym_type_and_address): Handle
183         mst_data_gnu_ifunc.
184         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
185         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
186         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
187         comment.
188         <mst_data_gnu_ifunc>: New enumerator.
189
190 2018-04-26  Pedro Alves  <palves@redhat.com>
191
192         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
193         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
194         'want_trampoline' parameter by a lookup_msym_prefer parameter.
195         Handle it.
196         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
197         (lookup_minimal_symbol_by_pc): Adjust.
198         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
199         (lookup_solib_trampoline_symbol_by_pc): Adjust.
200         * minsyms.h (lookup_msym_prefer): New enum.
201         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
202         parameter by a lookup_msym_prefer parameter.
203
204 2018-04-26  Pedro Alves  <palves@redhat.com>
205
206         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
207         ends in "@plt" instead of looking at the symbol's section.
208
209 2018-04-26  Pedro Alves  <palves@redhat.com>
210
211         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
212         all references.
213         (find_pc_partial_function_gnu_ifunc): Rename to ...
214         (find_pc_partial_function): ... this, and remove references to
215         'is_gnu_ifunc_p'.
216         (find_pc_partial_function): Delete old implementation.
217         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
218
219 2018-04-26  Pedro Alves  <palves@redhat.com>
220
221         * linespec.c (struct bound_minimal_symbol_search_key): New.
222         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
223         skip first line if we found a GNU ifunc minimal symbol by name.
224         (compare_msymbols): Change parameters to work with a destructured
225         lhs minsym.
226         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
227         functions.
228
229 2018-04-26  Pedro Alves  <palves@redhat.com>
230
231         * breakpoint.c (set_breakpoint_location_function): Don't resolve
232         ifunc targets here.  Instead, if we have an ifunc minsym, use its
233         address/name.
234         (add_location_to_breakpoint): Store the minsym and the objfile in
235         the breakpoint location.
236         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
237         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
238         Record the minsym in the sal.
239         * symtab.h (symtab_and_line) <msymbol>: New field.
240
241 2018-04-26  Pedro Alves  <palves@redhat.com>
242
243         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
244         unless we actually resolved the ifunc.
245
246 2018-04-26  Pedro Alves  <palves@redhat.com>
247
248         * c-exp.y (variable production): Prefer ifunc minsyms over
249         regular function symbols.
250         * symtab.c (find_gnu_ifunc): New function.
251         * minsyms.h (lookup_msym_prefer): New enum.
252         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
253         parameter by a lookup_msym_prefer parameter.
254         * symtab.h (find_gnu_ifunc): New declaration.
255
256 2018-04-26  Pedro Alves  <palves@redhat.com>
257
258         * blockframe.c (find_gnu_ifunc_target_type): New function.
259         (find_function_type): New.
260         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
261         return a value with a memory address.
262         (eval_call): For calls to GNU ifunc functions, try to find the
263         type of the target function from the type that the resolver
264         returns.
265         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
266         symbols.
267         * infcall.c (find_function_return_type): Delete.
268         (find_function_addr): Add 'function_type' parameter.  For calls to
269         GNU ifunc functions, try to find the type of the target function
270         from the type that the resolver returns, and return it via
271         FUNCTION_TYPE.
272         (call_function_by_hand_dummy): Adjust to use the function type
273         returned by find_function_addr.
274         (find_function_addr): Add 'function_type' parameter and move
275         description here.
276         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
277         declarations.
278
279 2018-04-26  Pedro Alves  <palves@redhat.com>
280
281         * c-exp.y (variable production): Skip finding an alias for ifunc
282         symbols.
283
284 2018-04-26  Pedro Alves  <palves@redhat.com>
285
286         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
287
288 2018-04-25  Pedro Alves  <palves@redhat.com>
289
290         * infcmd.c (kill_command): Print the pid as string, not the whole
291         thread's ptid.  Add comment.  s/has been killed/killed/ in output
292         message.
293         * remote.c (remote_detach_1): Print the pid as string, not the
294         whole thread's ptid.
295
296 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
297             Sergio Durigan Junior  <sergiodj@redhat.com>
298             Pedro Alves  <palves@redhat.com>
299
300         * infcmd.c (kill_command): Print message when inferior has
301         been killed.
302         * inferior.c (print_inferior_events): Remove 'static'.  Set as
303         '1'.
304         (add_inferior): Improve message printed when
305         'print_inferior_events' is on.
306         (exit_inferior): Remove message printed when
307         'print_inferior_events' is on.
308         (detach_inferior): Improve message printed when
309         'print_inferior_events' is on.
310         (initialize_inferiors): Use 'add_inferior_silent' to set
311         'current_inferior_'.
312         * inferior.h (print_inferior_events): Declare here as
313         'extern'.
314         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
315         '[Detaching...]' messages when 'print_inferior_events' is on.
316         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
317         as prefix/suffix for messages.  Remove periods.  Fix erroneous
318         'Detaching after fork from child...', replace it by '... from
319         parent...'.
320         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
321         prefix/suffix when printing 'Detaching...' messages.  Print
322         them when 'print_inferior_events' is on.
323         * remote.c (remote_detach_1): Print message when detaching
324         from inferior and '!is_fork_parent'.
325
326 2018-04-24  Tom Tromey  <tom@tromey.com>
327
328         * cli-out.h: Reindent.
329
330 2018-04-24  Tom Tromey  <tom@tromey.com>
331
332         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
333         (cli_ui_out::do_field_string): Use fputs_filtered.
334         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
335
336 2018-04-23  Tom Tromey  <tom@tromey.com>
337
338         * guile/scm-frame.c (gdbscm_frame_read_var): Use
339         gdb::unique_xmalloc_ptr.
340
341 2018-04-23  Tom Tromey  <tom@tromey.com>
342
343         * configure: Rebuild.
344
345 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
346
347         PR gdb/23095
348         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
349         prepare_for_testing.  Set normal_bp to r_debug_state if target
350         is bsd.
351
352 2018-04-21  Pedro Alves  <palves@redhat.com>
353             Rajendra SY  <rajendra.sy@gmail.com>
354
355         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
356         * remote.c (extended_remote_attach): In all-stop mode, mark the
357         thread as executing.
358
359 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
360
361         * thread.c (thread_apply_all_command): Fix comment.
362         (thread_command): Fix comment.
363
364 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
365
366         * common/tdesc.h (tdesc_create_feature): Remove xml filename
367         parameter.
368         * features/aarch64-core.c (create_feature_aarch64_core):
369         Regenerate.
370         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
371         Likewise.
372         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
373         Likewise.
374         * features/i386/32bit-avx512.c
375         (create_feature_i386_32bit_avx512): Likewise.
376         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
377         Likewise.
378         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
379         Likewise.
380         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
381         Likewise.
382         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
383         Likewise.
384         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
385         Likewise.
386         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
387         Likewise.
388         * features/i386/64bit-avx512.c
389         (create_feature_i386_64bit_avx512): Likewise.
390         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
391         Likewise.
392         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
393         Likewise.
394         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
395         Likewise.
396         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
397         Likewise.
398         * features/i386/64bit-segments.c
399         (create_feature_i386_64bit_segments): Likewise.
400         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
401         Likewise.
402         * features/i386/x32-core.c
403         (create_feature_i386_x32_core): Likewise.
404         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
405         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
406         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
407         * target-descriptions.c: In generated code, don't pass xml
408         filename.
409
410 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
411
412         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
413         (print_xml_feature::visit_post): Likewise.
414         (print_xml_feature::visit): Likewise.
415         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
416         (print_xml_feature): Add new class.
417         * regformats/regdat.sh: Null xmltarget on feature targets.
418         * target-descriptions.c (struct target_desc): Add xmltarget.
419         (maintenance_check_tdesc_xml_convert): Add unittest function.
420         (tdesc_get_features_xml): Add function to get xml.
421         (maintenance_check_xml_descriptions): Test xml generation.
422         * xml-tdesc.c (string_read_description_xml): Add function.
423         * xml-tdesc.h (string_read_description_xml): Add declaration.
424
425 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
426
427         * features/Makefile: Add feature marker to targets with new style
428         target descriptions.
429         * regformats/aarch64.dat: Regenerate.
430         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
431         * regformats/i386/amd64-avx-linux.dat: Likewise.
432         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
433         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
434         * regformats/i386/amd64-linux.dat: Likewise.
435         * regformats/i386/amd64-mpx-linux.dat: Likewise.
436         * regformats/i386/amd64.dat: Likewise.
437         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
438         * regformats/i386/i386-avx-linux.dat: Likewise.
439         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
440         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
441         * regformats/i386/i386-linux.dat: Likewise.
442         * regformats/i386/i386-mmx-linux.dat: Likewise.
443         * regformats/i386/i386-mpx-linux.dat: Likewise.
444         * regformats/i386/i386.dat: Likewise.
445         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
446         * regformats/i386/x32-avx-linux.dat: Likewise.
447         * regformats/i386/x32-linux.dat: Likewise.
448         * regformats/tic6x-c62x-linux.dat: Likewise.
449         * regformats/tic6x-c64x-linux.dat: Likewise.
450         * regformats/tic6x-c64xp-linux.dat: Likewise.
451         * regformats/regdat.sh: Parse feature marker.
452
453 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
454
455         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
456         (tdesc_osabi_name): Likewise.
457         * target-descriptions.c (tdesc_architecture_name): Add new
458         function.
459         (tdesc_osabi_name): Likewise.
460
461 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
462
463         * common/tdesc.c (tdesc_predefined_type): Move to here.
464         (tdesc_named_type): Likewise.
465         (tdesc_create_vector): Likewise.
466         (tdesc_create_struct): Likewise.
467         (tdesc_set_struct_size): Likewise.
468         (tdesc_create_union): Likewise.
469         (tdesc_create_flags): Likewise.
470         (tdesc_create_enum): Likewise.
471         (tdesc_add_field): Likewise.
472         (tdesc_add_typed_bitfield): Likewise.
473         (tdesc_add_bitfield): Likewise.
474         (tdesc_add_flag): Likewise.
475         (tdesc_add_enum_value): Likewise.
476         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
477         (struct tdesc_type_vector): Likewise.
478         (struct tdesc_type_field): Likewise.
479         (struct tdesc_type_with_fields): Likewise.
480         (tdesc_create_enum): Add declaration.
481         (tdesc_add_typed_bitfield): Likewise.
482         (tdesc_add_enum_value): Likewise.
483         * target-descriptions.c (tdesc_type_field): Move from here.
484         (tdesc_type_builtin): Likewise.
485         (tdesc_type_vector): Likewise.
486         (tdesc_type_with_fields): Likewise.
487         (tdesc_predefined_types): Likewise.
488         (tdesc_named_type): Likewise.
489         (tdesc_create_vector): Likewise.
490         (tdesc_create_struct): Likewise.
491         (tdesc_set_struct_size): Likewise.
492         (tdesc_create_union): Likewise.
493         (tdesc_create_flags): Likewise.
494         (tdesc_create_enum): Likewise.
495         (tdesc_add_field): Likewise.
496         (tdesc_add_typed_bitfield): Likewise.
497         (tdesc_add_bitfield): Likewise.
498         (tdesc_add_flag): Likewise.
499         (tdesc_add_enum_value): Likewise.
500         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
501         (tdesc_add_typed_bitfield): Likewise.
502         (tdesc_add_enum_value): Likewise.
503
504 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
505
506         * common/tdesc.c (tdesc_feature::accept): Move to here.
507         (tdesc_feature::operator==): Likewise.
508         (tdesc_create_reg): Likewise.
509         * common/tdesc.h (tdesc_type_kind): Likewise.
510         (struct tdesc_type): Likewise.
511         (struct tdesc_feature): Likewise.
512         * regformats/regdat.sh: Create a feature.
513         * target-descriptions.c (tdesc_type_kind): Move from here.
514         (tdesc_type): Likewise.
515         (tdesc_type_up): Likewise.
516         (tdesc_feature): Likewise.
517         (tdesc_create_reg): Likewise.
518
519 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
520
521         * Makefile.in: Add arch/tdesc.c
522         * common/tdesc.c: New file.
523         * common/tdesc.h (tdesc_element_visitor): Move to here.
524         (tdesc_element): Likewise.
525         (tdesc_reg): Likewise.
526         (tdesc_reg_up): Likewise.
527         * regformats/regdef.h (reg): Add offset to constructors.
528         * target-descriptions.c (tdesc_element_visitor): Move from here.
529         (tdesc_element): Likewise.
530         (tdesc_reg): Likewise.
531         (tdesc_reg_up): Likewise.
532
533 2018-04-17  Tom Tromey  <tom@tromey.com>
534
535         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
536         discriminant field.
537
538 2018-04-17  Tom Tromey  <tom@tromey.com>
539
540         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
541
542 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
543
544         * symtab.c (print_symbol_info): Skip printing filename and line
545         number when `last' is NULL.
546         (symtab_symbol_info): Use empty string instead of NULL for first
547         invocation of print_symbol_info.
548         (rbreak_command): Pass NULL to `last' parameter of
549         print_symbol_info.
550
551 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
552
553         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
554         instead of nullptr.
555
556 2018-04-16  Pedro Alves  <palves@redhat.com>
557
558         * MAINTAINERS (sh): Remove.
559         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
560         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
561         (ALLDEPFILES): Remove sh64-tdep.c.
562         * NEWS: Mentions that support for SH-5/SH64 is removed.
563         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
564         (sh*-*-openbsd*): Ditto.
565         (sh64-*-elf*): Remove.
566         (sh*): Remove.
567         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
568         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
569         * sh-tdep.c: No longer include "sh64-tdep.h".
570         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
571         * sh64-tdep.c, sh64-tdep.h: Remove files.
572
573 2018-04-16  Pedro Alves  <palves@redhat.com>
574
575         * MAINTAINERS: Remove m88k.
576         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
577         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
578         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
579         * NEWS: Mention that support for m88k was removed.
580         * configure.host (m88*-*-*): Remove support.
581         * configure.nat (m88k-*-*): Remove support.
582         * configure.tgt (m88*-*-openbsd*): Remove.
583         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
584
585 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
586
587         * configure.tgt (x86_tobjs): New variable.
588         (amd64_tobjs, i386_tobjs): Use it.
589
590 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
591
592         * symtab.c (print_symbol_info): Precede the symbol definition by
593         the line number when available.
594         * NEWS: Advertise this enhancement.
595
596 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
597
598         * NEWS (New options): announce set/show record btrace cpu.
599         * btrace.c: Include record-btrace.h.
600         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
601         the vendor is unknown.
602         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
603         Maybe overwrite the btrace configuration's cpu.
604         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
605         (btrace_fetch): Add cpu parameter.  Update callers.
606         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
607         Maybe overwrite the btrace configuration's cpu.  Skip enabling
608         errata workarounds if the vendor is unknown.
609         * python/py-record-btrace.c: Include record-btrace.h.
610         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
611         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
612         * record-btrace.c (record_btrace_cpu_state_kind): New.
613         (record_btrace_cpu): New.
614         (set_record_btrace_cpu_cmdlist): New.
615         (record_btrace_get_cpu): New.
616         (require_btrace_thread, record_btrace_info)
617         (record_btrace_resume_thread): Call record_btrace_get_cpu.
618         (cmd_set_record_btrace_cpu_none): New.
619         (cmd_set_record_btrace_cpu_auto): New.
620         (cmd_set_record_btrace_cpu): New.
621         (cmd_show_record_btrace_cpu): New.
622         (_initialize_record_btrace): Initialize set/show record btrace cpu
623         commands.
624         * record-btrace.h (record_btrace_get_cpu): New.
625
626 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
627
628         * record.c (set_record_command): Fix typo in message.
629
630 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
631
632         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
633
634 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
635
636         * infrun.c (process_event_stop_test): Call
637         gdbarch_in_indirect_branch_thunk.
638         * gdbarch.sh (in_indirect_branch_thunk): New.
639         * gdbarch.c: Regenerated.
640         * gdbarch.h: Regenerated.
641         * x86-tdep.h: New.
642         * x86-tdep.c: New.
643         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
644         (HFILES_NO_SRCDIR): Add x86-tdep.h.
645         (ALLDEPFILES): Add x86-tdep.c.
646         * arch-utils.h (default_in_indirect_branch_thunk): New.
647         * arch-utils.c (default_in_indirect_branch_thunk): New.
648         * i386-tdep: Include x86-tdep.h.
649         (i386_in_indirect_branch_thunk): New.
650         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
651         function.
652         * amd64-tdep: Include x86-tdep.h.
653         (amd64_in_indirect_branch_thunk): New.
654         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
655
656 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
657
658         PR gdb/23053
659         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
660         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
661         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
662         regression.
663
664 2018-04-12  Tom Tromey  <tom@tromey.com>
665
666         * rust-lang.c (rust_print_struct_def): Remove univariant code.
667         (rust_evaluate_subexp): Likewise.
668
669 2018-04-12  Pedro Alves  <palves@redhat.com>
670
671         * procfs.c (procfs_detach): Make forward declaration's prototype
672         match definition's protototype.
673         (proc_get_LDT_entry): Remove stale do_cleanups call.
674
675 2018-04-12  Pedro Alves  <palves@redhat.com>
676
677         * target.h (target_ops::to_has_exited): Delete.
678         (target_has_exited): Delete.
679         * target-delegates.c: Regenerate.
680
681 2018-04-11  Pedro Alves  <palves@redhat.com>
682
683         * target.c (fileio_fh_t::t): Add comment.
684         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
685         (target_fileio_close): Handle a NULL target.
686         (invalidate_fileio_fh): New.
687         (target_close): Call it.
688         * remote.c (remote_hostio_send_command): No longer check whether
689         remote_desc is open.
690
691 2018-04-11  Pedro Alves  <palves@redhat.com>
692
693         * target.c (fileio_fh_t): Make it a named struct instead of a
694         typedef.
695         (fileio_fh_t::is_closed): New method.
696         (DEF_VEC_O (fileio_fh_t)): Remove.
697         (fileio_fhandles): Now a std::vector.
698         (is_closed_fileio_fh): Delete.
699         (acquire_fileio_fd): Adjust.  Rename parameters.
700         (release_fileio_fd): Adjust.
701         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
702         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
703         (target_fileio_close): Adjust.
704
705 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
706
707         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
708         index.
709
710 2018-04-10  Pedro Alves  <palves@redhat.com>
711
712         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
713         (scoped_finish_thread_state): New class.
714         * infcmd.c (run_command_1): Use it instead of finish_thread_state
715         cleanup.
716         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
717         (fetch_inferior_event, normal_stop): Likewise.
718         * thread.c (finish_thread_state_cleanup): Delete.
719
720 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
721             Pedro Alves  <palves@redhat.com>
722
723         * value.c: Include "selftest.h" and "common/array-view.h".
724         (struct range) <operator ==>: New.
725         (test_ranges_contain): New.
726         (check_ranges_vector): New.
727         (test_insert_into_bit_range_vector): New.
728         (_initialize_values): Register selftests.
729         * common/array-view.h (operator==, operator!=): New.
730
731 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
732
733         * common/gdb_vecs.h (unordered_remove): Add overload that takes
734         an iterator.
735         * inline-frame.c: Include <algorithm>.
736         (struct inline_state): Add constructor.
737         (inline_state_s): Remove.
738         (DEF_VEC_O(inline_state_s)): Remove.
739         (inline_states): Change type to std::vector.
740         (find_inline_frame_state): Adjust to std::vector.
741         (allocate_inline_frame_state): Remove.
742         (clear_inline_frame_state): Adjust to std::vector.
743         (skip_inline_frames): Adjust to std::vector.
744
745 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
746
747         * tracepoint.h (struct trace_state_variable): Add constructor.
748         <name>: Change type to std::string.
749         * tracepoint.c (tsv_s): Remove.
750         (DEF_VEC_O(tsv_s)): Remove.
751         (tvariables): Change to std::vector.
752         (create_trace_state_variable): Adjust to std::vector.
753         (find_trace_state_variable): Likewise.
754         (find_trace_state_variable_by_number): Likewise.
755         (delete_trace_state_variable): Likewise.
756         (trace_variable_command): Adjust to std::string.
757         (delete_trace_variable_command): Likewise.
758         (tvariables_info_1): Adjust to std::vector.
759         (save_trace_state_variables): Likewise.
760         (start_tracing): Likewise.
761         (merge_uploaded_trace_state_variables): Adjust to std::vector
762         and std::string.
763         * target.h (struct target_ops)
764         <to_download_trace_state_variable>: Pass reference to
765         trace_state_variable.
766         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
767         * target-delegates.c: Re-generate.
768         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
769         (mi_tsv_deleted): Likewise.
770         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
771         * remote.c (remote_download_trace_state_variable): Change
772         pointer to reference and adjust.
773         * make-target-delegates (parse_argtypes): Handle references.
774         (write_function_header): Likewise.
775         (munge_type): Likewise.
776
777 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
778
779         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
780         string_view-selftests.c.
781         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
782         testsuite.
783         * unittests/basic_string_view/cons/char/1.cc: Likewise.
784         * unittests/basic_string_view/cons/char/2.cc: Likewise.
785         * unittests/basic_string_view/cons/char/3.cc: Likewise.
786         * unittests/basic_string_view/element_access/char/1.cc:
787         Likewise.
788         * unittests/basic_string_view/element_access/char/empty.cc:
789         Likewise.
790         * unittests/basic_string_view/element_access/char/front_back.cc:
791         Likewise.
792         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
793         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
794         Likewise.
795         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
796         Likewise.
797         * unittests/basic_string_view/modifiers/swap/char/1.cc:
798         Likewise.
799         * unittests/basic_string_view/operations/compare/char/1.cc:
800         Likewise.
801         * unittests/basic_string_view/operations/compare/char/13650.cc:
802         Likewise.
803         * unittests/basic_string_view/operations/copy/char/1.cc:
804         Likewise.
805         * unittests/basic_string_view/operations/data/char/1.cc:
806         Likewise.
807         * unittests/basic_string_view/operations/find/char/1.cc:
808         Likewise.
809         * unittests/basic_string_view/operations/find/char/2.cc:
810         Likewise.
811         * unittests/basic_string_view/operations/find/char/3.cc:
812         Likewise.
813         * unittests/basic_string_view/operations/find/char/4.cc:
814         Likewise.
815         * unittests/basic_string_view/operations/rfind/char/1.cc:
816         Likewise.
817         * unittests/basic_string_view/operations/rfind/char/2.cc:
818         Likewise.
819         * unittests/basic_string_view/operations/rfind/char/3.cc:
820         Likewise.
821         * unittests/basic_string_view/operations/substr/char/1.cc:
822         Likewise.
823         * unittests/basic_string_view/operators/char/2.cc: Likewise.
824         * unittests/string_view-selftests.c: New file.
825
826 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
827
828         * unittests/basic_string_view/capacity/1.cc: New file.
829         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
830         * unittests/basic_string_view/cons/char/1.cc: New file.
831         * unittests/basic_string_view/cons/char/2.cc: New file.
832         * unittests/basic_string_view/cons/char/3.cc: New file.
833         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
834         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
835         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
836         * unittests/basic_string_view/element_access/char/1.cc: New file.
837         * unittests/basic_string_view/element_access/char/2.cc: New file.
838         * unittests/basic_string_view/element_access/char/empty.cc: New file.
839         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
840         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
841         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
842         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
843         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
844         * unittests/basic_string_view/include.cc: New file.
845         * unittests/basic_string_view/inserters/char/1.cc: New file.
846         * unittests/basic_string_view/inserters/char/2.cc: New file.
847         * unittests/basic_string_view/inserters/char/3.cc: New file.
848         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
849         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
850         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
851         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
852         * unittests/basic_string_view/literals/types.cc: New file.
853         * unittests/basic_string_view/literals/values.cc: New file.
854         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
855         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
856         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
857         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
858         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
859         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
860         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
861         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
862         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
863         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
864         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
865         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
866         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
867         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
868         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
869         * unittests/basic_string_view/operations/data/char/1.cc: New file.
870         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
871         * unittests/basic_string_view/operations/find/char/1.cc: New file.
872         * unittests/basic_string_view/operations/find/char/2.cc: New file.
873         * unittests/basic_string_view/operations/find/char/3.cc: New file.
874         * unittests/basic_string_view/operations/find/char/4.cc: New file.
875         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
876         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
877         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
878         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
879         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
880         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
881         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
882         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
883         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
884         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
885         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
886         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
887         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
888         * unittests/basic_string_view/operators/char/2.cc: New file.
889         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
890         * unittests/basic_string_view/range_access/char/1.cc: New file.
891         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
892         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
893         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
894         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
895         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
896         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
897         * unittests/basic_string_view/requirements/typedefs.cc: New file.
898         * unittests/basic_string_view/typedefs.cc: New file.
899         * unittests/basic_string_view/types/1.cc: New file.
900
901 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
902
903         * common/gdb_string_view.h: Remove libstdc++ implementation
904         details, adjust to gdb reality.
905         * common/gdb_string_view.tcc: Likewise.
906         * cli/cli-script.c (struct string_view): Remove.
907         (user_args) <m_args>: Change element type to gdb::string_view.
908         (user_args::insert_args): Adjust.
909
910 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
911
912         * common/gdb_string_view.h: New file.
913         * common/gdb_string_view.tcc: New file.
914
915 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
916
917         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
918         * configure: Re-generate.
919
920 2018-04-09  Pedro Alves  <palves@redhat.com>
921
922         * gdbarch.sh: Include "observable.h" instead of "observer.h".
923         (set_target_gdbarch): Call
924         gdb::observers::architecture_changed.notify instead of
925         observer_notify_architecture_changed.
926
927 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
928
929         * tracepoint.c (struct current_traceframe_cleanup): Remove.
930         (do_restore_current_traceframe_cleanup): Remove.
931         (restore_current_traceframe_cleanup_dtor): Remove.
932         (make_cleanup_restore_current_traceframe): Remove.
933         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
934         New.
935         * tracepoint.h (struct scoped_restore_current_traceframe): New.
936         * infrun.c (fetch_inferior_event): Use
937         scoped_restore_current_traceframe.
938
939 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
940
941         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
942         Remove.
943         <n_allocated_type_units>: Remove.
944         <all_type_units>: Change to std::vector.
945         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
946         to std::vector change.
947         (dwarf2_per_objfile::get_cutu): Likewise.
948         (dwarf2_per_objfile::get_tu): Likewise.
949         (create_signatured_type_table_from_index): Likewise.
950         (create_signatured_type_table_from_debug_names): Likewise.
951         (dw2_symtab_iter_next): Likewise.
952         (dw2_print_stats): Likewise.
953         (dw2_expand_all_symtabs): Likewise.
954         (dw2_expand_marked_cus): Likewise.
955         (dw2_debug_names_iterator::next): Likewise.
956         (dwarf2_initialize_objfile): Likewise.
957         (add_signatured_type_cu_to_table): Likewise.
958         (create_all_type_units): Likewise.
959         (add_type_unit): Likewise.
960         (struct tu_abbrev_offset): Add constructor.
961         (build_type_psymtabs_1): Adjust to std::vector change.
962         (print_tu_stats): Likewise.
963         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
964         (write_debug_names): Likewise.
965
966 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
967
968         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
969         Make an std::vector.
970         <n_comp_units>: Remove.
971         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
972         to std::vector change.
973         (dwarf2_per_objfile::get_cutu): Likewise.
974         (dwarf2_per_objfile::get_cu): Likewise.
975         (create_cus_from_index): Likewise.
976         (create_addrmap_from_index): Likewise.
977         (create_addrmap_from_aranges): Likewise.
978         (dwarf2_read_index): Likewise.
979         (dw2_find_last_source_symtab): Likewise.
980         (dw2_map_symtabs_matching_filename): Likewise.
981         (dw2_symtab_iter_next): Likewise.
982         (dw2_print_stats): Likewise.
983         (dw2_expand_all_symtabs): Likewise.
984         (dw2_expand_symtabs_with_fullname): Likewise.
985         (dw2_expand_marked_cus): Likewise.
986         (dw2_map_symbol_filenames): Likewise.
987         (create_cus_from_debug_names): Likewise.
988         (dwarf2_read_debug_names): Likewise.
989         (dw2_debug_names_iterator::next): Likewise.
990         (dwarf2_initialize_objfile): Likewise.
991         (set_partial_user): Likewise.
992         (dwarf2_build_psymtabs_hard): Likewise.
993         (read_comp_units_from_section): Remove arguments, adjust to
994         std::vector change.
995         (create_all_comp_units): Adjust to std::vector and
996         read_comp_units_from_section changes.
997         (dwarf2_find_containing_comp_unit): Adjust to std::vector
998         change.
999         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
1000         (psyms_seen_size): Likewise.
1001         (write_gdbindex): Likewise.
1002         (write_debug_names): Likewise.
1003
1004 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1005
1006         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
1007         with dwarf2_per_objfile.
1008         (create_cus_from_index): Likewise.
1009         (create_signatured_type_table_from_index): Likewise.
1010         (dwarf2_read_index): Likewise.
1011         (dwarf2_initialize_objfile): Likewise.
1012         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
1013         per_cu rather than get_dwarf2_per_objfile.
1014
1015 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1016
1017         * dwarf2read.h (struct signatured_type): Forward declare.
1018         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
1019         New methods.
1020         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
1021         (dw2_get_cutu): ...this.
1022         (dwarf2_per_objfile::get_cu): Rename from...
1023         (dw2_get_cu): ...this.
1024         (dwarf2_per_objfile::get_tu): New.
1025         (create_addrmap_from_index): Adjust.
1026         (create_addrmap_from_aranges): Adjust.
1027         (dw2_find_last_source_symtab): Adjust.
1028         (dw2_map_symtabs_matching_filename): Adjust.
1029         (dw2_symtab_iter_next): Adjust.
1030         (dw2_print_stats): Adjust.
1031         (dw2_expand_all_symtabs): Adjust.
1032         (dw2_expand_symtabs_with_fullname): Adjust.
1033         (dw2_expand_marked_cus): Adjust.
1034         (dw_expand_symtabs_matching_file_matcher): Adjust.
1035         (dw2_map_symbol_filenames): Adjust.
1036         (dw2_debug_names_iterator::next): Adjust.
1037         (dwarf2_initialize_objfile): Adjust.
1038         (set_partial_user): Adjust.
1039         (dwarf2_build_psymtabs_hard): Adjust.
1040
1041 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1042
1043         * dwarf2read.c (create_signatured_type_table_from_debug_names):
1044         Remove unused variables.
1045         (dw2_map_symtabs_matching_filename): Likewise.
1046         (dwarf2_record_block_ranges): Likewise.
1047         (dwarf2_read_addr_index): Likewise.
1048         (follow_die_offset): Likewise.
1049
1050 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1051
1052         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
1053         to symbol_file_add_main.
1054
1055 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1056
1057         PR mi/22299
1058         * mi/mi-console.c (do_fputc_async_safe): New.
1059         (mi_console_file::write_async_safe): New.
1060         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
1061         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
1062         New.
1063         * ui-file.c (ui_file::putstrn): Adjust call to
1064         fputstrn_unfiltered.
1065         * utils.c (printchar): Replace do_fputs and do_fprintf
1066         parameters by do_fputc.
1067         (fputstr_filtered): Adjust call to printchar.
1068         (fputstr_unfiltered): Likewise.
1069         (fputstrn_filtered): Likewise.
1070         (fputstrn_unfiltered): Add do_fputc parameter, pass to
1071         printchar.
1072         * utils.h (do_fputc_ftype): New typedef.
1073         (fputstrn_unfiltered): Add do_fputc parameter.
1074
1075 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1076
1077         * regformats/i386/i386-avx.dat: Remove.
1078
1079 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
1080
1081         PR gdb/22979
1082         * amd64-tdep.c (amd64_none_init_abi): New function.
1083         (amd64_x32_none_init_abi): New function.
1084         (_initialize_amd64_tdep): Register handlers for x86-64 and
1085         x64_32 with GDB_OSABI_NONE.
1086         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
1087         GDB_OSABI_NONE osabi.
1088
1089 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
1090
1091         PR gdb/22980
1092         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
1093         GDB_OSABI_NONE.
1094         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
1095         * osabi.c (gdb_osabi_names): Add "unknown" entry.
1096
1097 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
1098
1099         * common/byte-vector.h (char_vector): New type.
1100         * target.h (target_read_alloc): Return
1101         gdb::optional<byte_vector>.
1102         (target_read_stralloc): Return gdb::optional<char_vector>.
1103         (target_get_osdata): Return gdb::optional<char_vector>.
1104         * target.c (target_read_alloc_1): Templatize.  Replacement
1105         manual memory management with vector.
1106         (target_read_alloc): Change return type, adjust.
1107         (target_read_stralloc): Change return type, adjust.
1108         (target_get_osdata): Change return type, adjust.
1109         * auxv.c (struct auxv_info) <length>: Remove.
1110         <data>: Change type to gdb::optional<byte_vector>.
1111         (auxv_inferior_data_cleanup): Free auxv_info with delete.
1112         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
1113         (target_auxv_search): Adjust.
1114         (fprint_target_auxv): Adjust.
1115         * avr-tdep.c (avr_io_reg_read_command): Adjust.
1116         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
1117         (linux_make_corefile_notes): Adjust.
1118         * osdata.c (get_osdata): Adjust.
1119         * remote.c (remote_get_threads_with_qxfer): Adjust.
1120         (remote_memory_map): Adjust.
1121         (remote_traceframe_info): Adjust.
1122         (btrace_read_config): Adjust.
1123         (remote_read_btrace): Adjust.
1124         (remote_pid_to_exec_file): Adjust.
1125         * solib-aix.c (solib_aix_get_library_list): Adjust.
1126         * solib-dsbt.c (decode_loadmap): Don't free buf.
1127         (dsbt_get_initial_loadmaps): Adjust.
1128         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
1129         * solib-target.c (solib_target_current_sos): Adjust.
1130         * tracepoint.c (sdata_make_value): Adjust.
1131         * xml-support.c (xinclude_start_include): Adjust.
1132         (xml_fetch_content_from_file): Adjust.
1133         * xml-support.h (xml_fetch_another): Change return type.
1134         (xml_fetch_content_from_file): Change return type.
1135         * xml-syscall.c (xml_init_syscalls_info): Adjust.
1136         * xml-tdesc.c (file_read_description_xml): Adjust.
1137         (fetch_available_features_from_target): Change return type.
1138         (target_fetch_description_xml): Adjust.
1139         (target_read_description_xml): Adjust.
1140
1141 2018-04-06  Tom Tromey  <tom@tromey.com>
1142
1143         * value.c (~value): Update.
1144         (struct value) <contents>: Now unique_xmalloc_ptr.
1145         (value_contents_bits_eq, allocate_value_contents)
1146         (value_contents_raw, value_contents_all_raw)
1147         (value_contents_for_printing, value_contents_for_printing_const)
1148         (set_value_enclosing_type): Update.
1149
1150 2018-04-06  Tom Tromey  <tom@tromey.com>
1151
1152         * value.c (range_s): Remove typedef, VEC.
1153         (struct range): Add operator<.
1154         (range_lessthan): Remove.
1155         (ranges_contain): Change type.
1156         (~value): Update.
1157         (struct value) <unavailable, optimized_out>: Now std::vector.
1158         (value_entirely_available)
1159         (value_entirely_covered_by_range_vector)
1160         (value_entirely_unavailable, value_entirely_optimized_out):
1161         Update.
1162         (insert_into_bit_range_vector): Change argument type.
1163         (find_first_range_overlap): Likewise.
1164         (struct ranges_and_idx, value_contents_bits_eq)
1165         (require_not_optimized_out, require_available): Update.
1166         (ranges_copy_adjusted): Change argument types.
1167         (value_optimized_out, value_copy, value_fetch_lazy): Update.
1168
1169 2018-04-06  Tom Tromey  <tom@tromey.com>
1170
1171         * value.c (~value): Update.
1172         (struct value) <parent>: Now a value_ref_ptr.
1173         (value_parent, set_value_parent, value_address, value_copy):
1174         Update.
1175
1176 2018-04-06  Tom Tromey  <tom@tromey.com>
1177
1178         * value.c (struct value): Add constructor, destructor, and member
1179         initializers.
1180         (allocate_value_lazy, value_decref): Update.
1181
1182 2018-04-06  Tom Tromey  <tom@tromey.com>
1183
1184         * value.c (struct value) <released, next>: Remove.
1185         (all_values): Now a std::vector.
1186         (allocate_value_lazy): Update.
1187         (value_next): Remove.
1188         (value_mark, value_free_to_mark, release_value)
1189         (value_release_to_mark): Update.
1190
1191 2018-04-06  Tom Tromey  <tom@tromey.com>
1192
1193         * value.h (fetch_subexp_value, value_release_to_mark): Update.
1194         (free_value_chain): Remove.
1195         * value.c (free_value_chain): Remove.
1196         (value_release_to_mark): Return a std::vector.
1197         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
1198         std::vector.
1199         (check_condition): Update.
1200         * eval.c (fetch_subexp_value): Change "val_chain" to a
1201         std::vector.
1202         * breakpoint.c (update_watchpoint): Update.
1203         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
1204
1205 2018-04-06  Tom Tromey  <tom@tromey.com>
1206
1207         * value.h (free_all_values): Remove.
1208         * value.c (free_all_values): Remove.
1209
1210 2018-04-06  Tom Tromey  <tom@tromey.com>
1211
1212         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
1213         (value_history_chain, value_history_count): Remove.
1214         (value_history): New global.
1215         (record_latest_value, access_value_history, show_values)
1216         (preserve_values): Update.
1217
1218 2018-04-06  Tom Tromey  <tom@tromey.com>
1219
1220         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
1221         * varobj.c (varobj_set_display_format, varobj_set_value)
1222         (install_default_visualizer, construct_visualizer)
1223         (install_new_value, ~varobj, varobj_get_value_type)
1224         (my_value_of_variable, varobj_editable_p): Update.
1225         * c-varobj.c (c_describe_child, c_value_of_variable)
1226         (cplus_number_of_children, cplus_describe_child): Update.
1227         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
1228         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
1229         (ada_value_of_variable, ada_value_is_changeable_p): Update.
1230
1231 2018-04-06  Tom Tromey  <tom@tromey.com>
1232
1233         * printcmd.c (last_examine_address): Change type to
1234         value_ref_ptr.
1235         (do_examine, x_command): Update.
1236
1237 2018-04-06  Tom Tromey  <tom@tromey.com>
1238
1239         * value.c (release_value): Update.
1240         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
1241         (struct bpstats) <val>: Now a value_ref_ptr.
1242         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
1243         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
1244         (~watchpoint, print_it_watchpoint, watch_command_1)
1245         (invalidate_bp_value_on_memory_change): Update.
1246
1247 2018-04-06  Tom Tromey  <tom@tromey.com>
1248
1249         * varobj.c (varobj_clear_saved_item)
1250         (update_dynamic_varobj_children, install_new_value, ~varobj):
1251         Update.
1252         * value.h (value_incref): Move declaration earlier.
1253         (value_decref): Rename from value_free.
1254         (struct value_ref_policy): New.
1255         (value_ref_ptr): New typedef.
1256         (struct value_deleter): Remove.
1257         (gdb_value_up): Remove typedef.
1258         (release_value): Change return type.
1259         (release_value_or_incref): Remove.
1260         * value.c (set_value_parent): Update.
1261         (value_incref): Change return type.
1262         (value_decref): Rename from value_free.
1263         (value_free_to_mark, free_all_values, free_value_chain): Update.
1264         (release_value): Return value_ref_ptr.
1265         (release_value_or_incref): Remove.
1266         (record_latest_value, set_internalvar, clear_internalvar):
1267         Update.
1268         * stack.c (info_frame_command): Don't call value_free.
1269         * python/py-value.c (valpy_dealloc, valpy_new)
1270         (value_to_value_object): Update.
1271         * printcmd.c (do_examine): Update.
1272         * opencl-lang.c (lval_func_free_closure): Update.
1273         * mi/mi-main.c (register_changed_p): Don't call value_free.
1274         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
1275         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
1276         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
1277         value_free.
1278         * guile/scm-value.c (vlscm_free_value_smob)
1279         (vlscm_scm_from_value): Update.
1280         * frame.c (frame_register_unwind, frame_unwind_register_signed)
1281         (frame_unwind_register_unsigned, get_frame_register_bytes)
1282         (put_frame_register_bytes): Don't call value_free.
1283         * findvar.c (address_from_register): Don't call value_free.
1284         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
1285         * dwarf2loc.c (entry_data_value_free_closure)
1286         (value_of_dwarf_reg_entry, free_pieced_value_closure)
1287         (dwarf2_evaluate_loc_desc_full): Update.
1288         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
1289         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
1290         (~watchpoint, watch_command_1)
1291         (invalidate_bp_value_on_memory_change): Update.
1292         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
1293
1294 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
1295
1296         PR gdb/23022
1297         * warning.m4: Add -Wno-error=deprecated-register.
1298         * configure: Re-generate.
1299
1300 2018-04-05  Tom Tromey  <tom@tromey.com>
1301
1302         * linespec.h: Remove include of "vec.h".
1303
1304 2018-04-05  Tom Tromey  <tom@tromey.com>
1305
1306         * linespec.c (typep): Remove typedef.
1307         (find_methods, find_superclass_methods): Take a std::vector.
1308         (find_method): Use std::vector.
1309
1310 2018-04-05  Tom Tromey  <tom@tromey.com>
1311
1312         * utils.c (compare_strings): Remove.
1313         * utils.h (compare_strings): Remove.
1314         * objc-lang.h (find_imps): Update.
1315         * objc-lang.c (find_methods): Take a std::vector.
1316         (uniquify_strings, find_imps): Likewise.
1317         * linespec.c (find_methods): Take a std::vector.
1318         (decode_objc): Use std::vector.
1319         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
1320         a std::vector.
1321         (find_method, find_function_symbols): Use std::vector.
1322
1323 2018-04-05  Tom Tromey  <tom@tromey.com>
1324
1325         * completer.c (completion_tracker::completion_tracker): Remove
1326         cast.
1327         (completion_tracker::discard_completions): Likewise.
1328         * breakpoint.c (ambiguous_names_p): Remove cast.
1329         * ada-lang.c (_initialize_ada_language): Remove cast.
1330         * utils.h (streq): Update.
1331         (streq_hash): Add new declaration.
1332         * utils.c (streq): Return bool.
1333         (streq_hash): New function.
1334
1335 2018-04-05  Tom Tromey  <tom@tromey.com>
1336
1337         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
1338         Remove a string copy.
1339
1340 2018-04-05  Tom Tromey  <tom@tromey.com>
1341
1342         * linespec.c (filter_results): Use std::vector.
1343         (decode_line_2, decode_line_full): Update.
1344
1345 2018-04-05  Tom Tromey  <tom@tromey.com>
1346
1347         * linespec.c (canonical_to_fullform): Return std::string.
1348         (filter_results): Update.
1349         (struct decode_line_2_item): Add constructor.
1350         <fullform, displayform>: Now std::string.
1351         (decode_line_2_compare_items): Now a std::sort comparator.
1352         (decode_line_2): Update.
1353
1354 2018-04-05  Tom Tromey  <tom@tromey.com>
1355
1356         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
1357         (unexpected_linespec_error): Update.
1358         (linespec_parse_basic, parse_linespec): Update.
1359
1360 2018-04-05  Tom Tromey  <tom@tromey.com>
1361
1362         * linespec.c (linespec_parse_basic): Reindent.
1363
1364 2018-04-05  Tom Tromey  <tom@tromey.com>
1365
1366         * minsyms.h (iterate_over_minimal_symbols): Update.
1367         * minsyms.c (iterate_over_minimal_symbols): Take a
1368         gdb::function_view.
1369         * linespec.c (struct collect_minsyms): Remove.
1370         (compare_msyms): Now a std::sort comparator.
1371         (add_minsym): Add parameters.
1372         (search_minsyms_for_name): Update.  Use std::vector.
1373
1374 2018-04-03  Tom Tromey  <tom@tromey.com>
1375
1376         * mipsread.c (read_alphacoff_dynamic_symtab): Use
1377         gdb::byte_vector.
1378
1379 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
1380
1381         * MAINTAINERS (Write After Approval): Add Weimin Pan.
1382
1383 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
1384
1385         PR gdb/16959
1386         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when 
1387         printing static type.
1388
1389 2018-04-01  Tom Tromey  <tom@tromey.com>
1390
1391         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
1392         (rs6000_xfer_shared_libraries): Update.
1393
1394 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
1395
1396         * common/gdb_vecs.h (char_ptr): Remove.
1397         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
1398
1399 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
1400
1401         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
1402         with std::vector.
1403         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
1404
1405 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
1406
1407         * tracepoint.h (struct uploaded_tp): Initialize fields.
1408         <actions, step_actions, cmd_strings>: Change type to
1409         std::vector<char *>.
1410         * tracepoint.c (get_uploaded_tp): Allocate with new.
1411         (free_uploaded_tps): Free with delete.
1412         (parse_tracepoint_definition): Adjust to std::vector change.
1413         * breakpoint.c (read_uploaded_action): Likewise.
1414         (create_tracepoint_from_upload): Likewise.
1415         * ctf.c (ctf_write_uploaded_tp): Likewise.
1416         (SET_ARRAY_FIELD): Likewise.
1417         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
1418
1419 2018-03-30  Tom Tromey  <tom@tromey.com>
1420
1421         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
1422         std::unique_ptr.
1423         (svr4_keep_data_in_core): Update.
1424         (svr4_read_so_list): Update.
1425
1426 2018-03-30  Tom Tromey  <tom@tromey.com>
1427
1428         * windows-nat.c (handle_output_debug_string, handle_exception):
1429         Update.
1430         * target.h (target_read_string): Update.
1431         * target.c (target_read_string): Change "string" to
1432         unique_xmalloc_ptr.
1433         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
1434         Update.
1435         * solib-frv.c (frv_current_sos): Update.
1436         * solib-dsbt.c (dsbt_current_sos): Update.
1437         * solib-darwin.c (darwin_current_sos): Update.
1438         * linux-thread-db.c (inferior_has_bug): Update.
1439         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
1440         Update.  Remove alloca.
1441         * ada-lang.c (ada_main_name): Update.
1442
1443 2018-03-30  Tom Tromey  <tom@tromey.com>
1444
1445         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
1446         (struct dwo_file_deleter): New.
1447         (dwo_file_up): New typedef.
1448         (open_and_init_dwo_file): Use dwo_file_up.
1449         (free_dwo_file_cleanup): Remove.
1450
1451 2018-03-30  Tom Tromey  <tom@tromey.com>
1452
1453         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
1454         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
1455
1456 2018-03-30  Tom Tromey  <tom@tromey.com>
1457
1458         * dwarf2read.c (class free_cached_comp_units): New class.
1459         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
1460         (free_cached_comp_units): Remove function.
1461
1462 2018-03-30  Tom Tromey  <tom@tromey.com>
1463
1464         * utils.h (make_cleanup_unpush_target): Remove.
1465         * inf-ptrace.c (struct target_unpusher): New.
1466         (target_unpush_up) New typedef.
1467         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
1468         target_unpush_up.
1469         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
1470
1471 2018-03-27  Tom Tromey  <tom@tromey.com>
1472
1473         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
1474
1475 2018-03-27  Pedro Alves  <palves@redhat.com>
1476             Tom Tromey  <tom@tromey.com>
1477
1478         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
1479         destructor.  Now a class.
1480         (gdb_readline_wrapper_cleanup): Remove function.
1481         (gdb_readline_wrapper): Remove cleanups.
1482
1483 2018-03-27  Tom Tromey  <tom@tromey.com>
1484
1485         * typeprint.h (struct type_print_options) <local_typedefs,
1486         global_typedefs>: Remove "struct" keyword.
1487         (class typedef_hash_table): New class.
1488         (recursively_update_typedef_hash, add_template_parameters)
1489         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
1490         (find_typedef_in_hash): Don't declare.
1491         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
1492         (typedef_hash_table::recursively_update): Rename from
1493         recursively_update_typedef_hash.  Now a member.
1494         (typedef_hash_table::add_template_parameters): Rename from
1495         add_template_parameters.  Now a member.
1496         (typedef_hash_table::typedef_hash_table): Now a constructor;
1497         rename from create_typedef_hash.
1498         (typedef_hash_table::~typedef_hash_table): Now a destructor;
1499         rename from free_typedef_hash.
1500         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
1501         (do_free_global_table): Remove.
1502         (typedef_hash_table::typedef_hash_table): New constructor; renamed
1503         from copy_type_recursive.
1504         (create_global_typedef_table): Remove.
1505         (typedef_hash_table::find_global_typedef): Now a member of
1506         typedef_hash_table.
1507         (typedef_hash_table::find_typedef): Rename from
1508         find_typedef_in_hash; now a member.
1509         (whatis_exp): Update.
1510         * extension.h (struct ext_lang_type_printers): Add constructor and
1511         destructor.
1512         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
1513         declare.
1514         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
1515         Now a constructor; rename from start_ext_lang_type_printers.
1516         (ext_lang_type_printers): Now a destructor; rename from
1517         free_ext_lang_type_printers.
1518         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
1519         Update.
1520         (c_type_print_base_struct_union): Update.  Remove cleanups.
1521
1522 2018-03-27  Tom Tromey  <tom@tromey.com>
1523
1524         * dwarf-index-write.c: Include <cmath>.
1525
1526 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
1527
1528         * NEWS: Add entry describing new "set|show varsize-limit" command.
1529         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
1530         command.
1531         * printcmd.c (_initialize_printcmd): Add "set var" alias of
1532         "set variable".
1533
1534 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
1535
1536         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
1537         dwarf-index-write.c
1538         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
1539         * dwarf-index-common.c: New file.
1540         * dwarf-index-common.h: New file.
1541         * dwarf-index-write.c: New file.
1542         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
1543         (struct dwarf2_section_info): Move from here.
1544         (dwarf2_section_info_def): Likewise.
1545         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
1546         (offset_type): Likewise.
1547         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
1548         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
1549         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
1550         (byte_swap): Likewise.
1551         (MAYBE_SWAP): Likewise.
1552         (dwarf2_per_cu_ptr): Likewise.
1553         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
1554         (struct tu_stats): Likewise.
1555         (struct dwarf2_per_objfile): Likewise.
1556         (struct dwarf2_per_cu_data): Likewise.
1557         (struct signatured_type): Likewise.
1558         (sig_type_ptr): Likewise.
1559         (DEF_VEC_P (sig_type_ptr)): Likewise.
1560         (INDEX4_SUFFIX): Likewise.
1561         (INDEX5_SUFFIX): Likewise.
1562         (DEBUG_STR_SUFFIX): Likewise.
1563         (dwarf2_read_section): Make non-static.
1564         (mapped_index_string_hash): Move from here.
1565         (dwarf5_djb_hash): Likewise.
1566         (file_write): Likewise.
1567         (class data_buf): Likewise.
1568         (struct symtab_index_entry): Likewise.
1569         (struct mapped_symtab): Likewise.
1570         (find_slot): Likewise.
1571         (hash_expand): Likewise.
1572         (add_index_entry): Likewise.
1573         (uniquify_cu_indices): Likewise.
1574         (class c_str_view): Likewise.
1575         (class c_str_view_hasher): Likewise.
1576         (class vector_hasher): Likewise.
1577         (write_hash_table): Likewise.
1578         (psym_index_map): Likewise.
1579         (struct addrmap_index_data): Likewise.
1580         (add_address_entry): Likewise.
1581         (add_address_entry_worker): Likewise.
1582         (write_address_map): Likewise.
1583         (symbol_kind): Likewise.
1584         (write_psymbols): Likewise.
1585         (struct signatured_type_index_data): Likewise.
1586         (write_one_signatured_type): Likewise.
1587         (recursively_count_psymbols): Likewise.
1588         (recursively_write_psymbols): Likewise.
1589         (class debug_names): Likewise.
1590         (check_dwarf64_offsets): Likewise.
1591         (psyms_seen_size): Likewise.
1592         (write_gdbindex): Likewise.
1593         (write_debug_names): Likewise.
1594         (assert_file_size): Likewise.
1595         (write_psymtabs_to_index): Likewise.
1596         (save_gdb_index_command): Likewise.
1597         (_initialize_dwarf2_read): Don't register the "save gdb-index"
1598         command.
1599         * dwarf2read.h: New file.
1600
1601 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
1602
1603         PR gdb/22670
1604         * dwarf2read.c (dwarf2_physname): Do not return the demangled
1605         symbol name if the CU's language stores symbol names in linkage
1606         format.
1607         * language.h (struct language_defn)
1608         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
1609         all instances of this struct.
1610
1611 2018-03-26  Tom Tromey  <tom@tromey.com>
1612
1613         * stack.c (backtrace_command_1): Remove verbose code.
1614
1615 2018-03-26  Tom Tromey  <tom@tromey.com>
1616
1617         * python/py-framefilter.c (py_print_type): Don't catch
1618         exceptions.  Return void.
1619         (py_print_value): Likewise.
1620         (py_print_single_arg): Likewise.
1621         (enumerate_args): Don't catch exceptions.
1622         (py_print_args): Likewise.
1623         (py_print_frame): Likewise.
1624         (gdbpy_apply_frame_filter): Catch exceptions here.
1625
1626 2018-03-26  Tom Tromey  <tom@tromey.com>
1627
1628         * stack.c (_initialize_stack): Remove trailing newlines from help
1629         text.  Add "Usage" line to "backtrace" help.
1630
1631 2018-03-26  Tom Tromey  <tom@tromey.com>
1632
1633         PR python/16486:
1634         * python/py-framefilter.c (py_print_args): Call wrap_hint.
1635
1636 2018-03-26  Tom Tromey  <tom@tromey.com>
1637
1638         * python/py-framefilter.c (py_print_single_arg): Return
1639         EXT_LANG_BT_ERROR from catch.
1640
1641 2018-03-26  Tom Tromey  <tom@tromey.com>
1642
1643         PR backtrace/15584:
1644         * stack.c (backtrace_command_1): Move some code into no-filters
1645         "if".
1646
1647 2018-03-26  Tom Tromey  <tom@tromey.com>
1648
1649         * python/py-framefilter.c (throw_quit_or_print_exception): New
1650         function.
1651         (gdbpy_apply_frame_filter): Use it.
1652
1653 2018-03-26  Tom Tromey  <tom@tromey.com>
1654
1655         PR cli/17716:
1656         * python/py-framefilter.c (py_print_type, py_print_value)
1657         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
1658         RETURN_MASK_ERROR.
1659
1660 2018-03-26  Tom Tromey  <tom@tromey.com>
1661
1662         * python/py-framefilter.c (enumerate_args): Use
1663         gdb::unique_xmalloc_ptr.
1664
1665 2018-03-26  Tom Tromey  <tom@tromey.com>
1666
1667         * python/py-framefilter.c (py_print_frame): Return
1668         EXT_LANG_BT_OK.
1669         (gdbpy_apply_frame_filter): Update comment.
1670         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
1671         Remove.
1672         <EXT_LANG_BT_NO_FILTERS>: Change value.
1673
1674 2018-03-26  Tom Tromey  <tom@tromey.com>
1675
1676         PR backtrace/15582:
1677         * stack.c (backtrace_command): Parse "hide" argument.
1678         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
1679         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
1680         constant.
1681
1682 2018-03-26  Tom Tromey  <tom@tromey.com>
1683
1684         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
1685         add "flags".
1686         (backtrace_command): Remove "fulltrace", add "flags".
1687
1688 2018-03-26  Tom Tromey  <tom@tromey.com>
1689
1690         * stack.c (backtrace_command): Rewrite command line parsing.
1691
1692 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
1693
1694         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
1695
1696 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
1697
1698         * filename-seen-cache.h: Add include guard.
1699
1700 2018-03-26  Keith Seitz  <keiths@redhat.com>
1701
1702         * symfile.c (place_section): Remove "struct" from section_addr_info
1703         in comment.
1704         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
1705         "struct" keyword from section_addr_info.
1706
1707 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
1708
1709         * regformats/regdef.h (reg): Add constructors.
1710
1711 2018-03-25  Pedro Alves  <palves@redhat.com>
1712
1713         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
1714         if then/else bodies in var_func_name extraction.
1715
1716 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
1717
1718         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
1719         lookup_minimal_symbol() to find symbol entry.
1720         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
1721
1722 2018-03-23  Keith Seitz  <keiths@redhat.com>
1723
1724         PR c++/22968
1725         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
1726         nested type definitions for C++, too.
1727
1728 2018-03-23  Tom Tromey  <tom@tromey.com>
1729
1730         * machoread.c (struct oso_el): Add a constructor.  Don't define as
1731         a typedef.
1732         (macho_register_oso): Remove.
1733         (macho_symtab_read): Take a std::vector.
1734         (oso_el_compare_name): Now a std::sort comparator.
1735         (macho_symfile_read_all_oso): Take a std::vector.
1736         (macho_symfile_read): Use std::vector.  Remove cleanups.
1737
1738 2018-03-22  Tom Tromey  <tom@tromey.com>
1739
1740         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
1741         (record_full_goto_bookmark): Use std::string.
1742
1743 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1744
1745         PR tdep/18295
1746         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
1747         a single mask.
1748
1749 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1750
1751         * rs6000-tdep.c (store_insn_p): New function.
1752         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
1753         and cr_reg to their unshifted values. Use store_insn_p to
1754         match LR saves using either R1 or fdata->alloca_reg. Use
1755         store_insn_p to match CR saves. Set alloca_reg_offset
1756         when alloca_reg and framep are set. Remove lr_reg shift
1757         when assigning to fdata->lr_register.
1758
1759 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
1760
1761         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
1762         command line args instead of emitting a warning.
1763
1764 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
1765
1766         * tracepoint.h (struct static_tracepoint_marker): Initialize
1767         fields, define default constructor, move constructor and move
1768         assignment, disable the rest.
1769         <str_id, extra>: Make std::string.
1770         (release_static_tracepoint_marker): Remove.
1771         (free_current_marker): Remove.
1772         * tracepoint.c (free_current_marker): Remove.
1773         (parse_static_tracepoint_marker_definition): Adjust to
1774         std::string, use new hex2str overload.
1775         (release_static_tracepoint_marker): Remove.
1776         (print_one_static_tracepoint_marker): Get marker by reference
1777         and adjust to std::string.
1778         (info_static_tracepoint_markers_command): Adjust to std::vector
1779         changes
1780         * target.h (static_tracepoint_marker_p): Remove typedef.
1781         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
1782         (struct target_ops) <to_static_tracepoint_marker_at>: Return
1783         bool.
1784         <to_static_tracepoint_markers_by_strid>: Return std::vector.
1785         * target-debug.h
1786         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
1787         (target_debug_print_std_vector_static_tracepoint_marker): New.
1788         (target_debug_print_struct_static_tracepoint_marker_p): Rename
1789         to...
1790         (target_debug_print_static_tracepoint_marker_p): ... this.
1791         * target-delegates.c: Re-generate.
1792         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
1793         Make std::string.
1794         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
1795         (decode_static_tracepoint_spec): Adjust to std::vector.
1796         (tracepoint_print_one_detail): Adjust to std::string.
1797         (strace_marker_decode_location): Adjust to std::string.
1798         (update_static_tracepoint): Adjust to std::string, remove call
1799         to release_static_tracepoint_marker.
1800         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
1801         Adjust to std::vector.
1802         * remote.c (remote_static_tracepoint_marker_at): Return bool.
1803         (remote_static_tracepoint_markers_by_strid): Adjust to
1804         std::vector.
1805         * common/rsp-low.h (hex2str): New overload with explicit count
1806         of bytes.
1807         * common/rsp-low.c (hex2str): New overload with explicit count
1808         of bytes.
1809         * unittests/rsp-low-selftests.c (test_hex2str): New function.
1810         (_initialize_rsp_low_selftests): Add test_hex2str test.
1811         * unittests/tracepoint-selftests.c
1812         (test_parse_static_tracepoint_marker_definition): Adjust to
1813         std::string.
1814
1815 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
1816
1817         * tracepoint.c (parse_static_tracepoint_marker_definition):
1818         Consider case where the definition is followed by more
1819         definitions.
1820         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1821         tracepoint-selftests.c.
1822         * unittests/tracepoint-selftests.c: New.
1823
1824 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1825
1826         * MAINTAINERS (Write After Approval): Add Pedro Franco de
1827         Carvalho.
1828
1829 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
1830
1831         * symtab.c (find_pc_sect_line): fixed indentation.
1832
1833 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
1834
1835         * symtab.c (find_pc_sect_line): now uses binary search.
1836
1837 2018-03-19  Tom Tromey  <tom@tromey.com>
1838
1839         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
1840         "IDENT" production.
1841
1842 2018-03-19  Pedro Alves  <palves@redhat.com>
1843             Tom Tromey  <tom@tromey.com>
1844
1845         * unittests/observable-selftests.c: New file.
1846         * common/observable.h: New file.
1847         * observable.h: New file.
1848         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
1849         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
1850         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
1851         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
1852         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
1853         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
1854         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
1855         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
1856         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
1857         python/py-breakpoint.c, python/py-finishbreakpoint.c,
1858         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
1859         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
1860         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
1861         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
1862         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
1863         tui/tui-interp.c, valops.c: Update all users.
1864         * tui/tui-hooks.c (tui_bp_created_observer)
1865         (tui_bp_deleted_observer, tui_bp_modified_observer)
1866         (tui_inferior_exit_observer, tui_before_prompt_observer)
1867         (tui_normal_stop_observer, tui_register_changed_observer):
1868         Remove.
1869         (tui_observers_token): New global.
1870         (attach_or_detach, tui_attach_detach_observers): New functions.
1871         (tui_install_hooks, tui_remove_hooks): Use
1872         tui_attach_detach_observers.
1873         * record-btrace.c (record_btrace_thread_observer): Remove.
1874         (record_btrace_thread_observer_token): New global.
1875         * observer.sh: Remove.
1876         * observer.c: Rename to observable.c.
1877         * observable.c (namespace gdb_observers): Define new objects.
1878         (observer_debug): Move into gdb_observers namespace.
1879         (struct observer, struct observer_list, xalloc_observer_list_node)
1880         (xfree_observer_list_node, generic_observer_attach)
1881         (generic_observer_detach, generic_observer_notify): Remove.
1882         (_initialize_observer): Update.
1883         Don't include observer.inc.
1884         * Makefile.in (generated_files): Remove observer.h, observer.inc.
1885         (clean mostlyclean): Likewise.
1886         (observer.h, observer.inc): Remove targets.
1887         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
1888         (COMMON_SFILES): Use observable.c, not observer.c.
1889         * .gitignore: Remove observer.h.
1890
1891 2018-03-18  Tom Tromey  <tom@tromey.com>
1892
1893         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
1894         gdb::def_vector.
1895         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
1896
1897 2018-03-17  Tom Tromey  <tom@tromey.com>
1898
1899         * auto-load.c (auto_load_objfile_script_1): Use std::string.
1900
1901 2018-03-17  Tom Tromey  <tom@tromey.com>
1902
1903         * target.c (class scoped_target_fd): New.
1904         (target_fileio_close_cleanup): Remove.
1905         (target_fileio_read_alloc_1): Use scoped_target_fd.
1906
1907 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
1908
1909         * silent-rules.mk: New.
1910         * Makefile.in: Include silent-rules.mk
1911         (srcdir, VPATH, top_srcdir): Move up.
1912         (COMPILE): Add ECHO_CXX.
1913         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
1914         (init.c): Add ECHO_INIT_C.
1915         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
1916         (version.c): Add ECHO_GEN.
1917         (printcmd.o): Add ECHO_CXX.
1918         (target-float.o): Add ECHO_CXX.
1919         (ada-exp.o): Add ECHO_CXX.
1920         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
1921         (insight$(EXEEXT)): Add ECHO_CXXLD.
1922         * gnulib/configure.ac: Add AM_SILENT_RULES.
1923         * gnulib/aclocal.m4: Re-generate.
1924         * gnulib/configure: Re-generate.
1925         * gnulib/import/Makefile.in: Re-generate.
1926
1927 2018-03-16  Tom Tromey  <tom@tromey.com>
1928
1929         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
1930         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
1931         * utils.c (do_free_section_addr_info)
1932         (make_cleanup_free_section_addr_info): Remove.
1933         * symfile.h (struct other_sections): Add constructor.
1934         (struct section_addr_info): Remove.
1935         (section_addr_info): New typedef.
1936         (struct sym_fns) <sym_offsets>: Change type of parameter.
1937         (build_section_addr_info_from_objfile)
1938         (relative_addr_info_to_section_offsets, addr_info_make_relative)
1939         (default_symfile_offsets, symbol_file_add)
1940         (symbol_file_add_from_bfd)
1941         (build_section_addr_info_from_section_table): Update.
1942         (alloc_section_addr_info, free_section_addr_info): Don't declare.
1943         * symfile.c (alloc_section_addr_info): Remove.
1944         (build_section_addr_info_from_section_table): Change return type.
1945         Update.
1946         (build_section_addr_info_from_bfd)
1947         (build_section_addr_info_from_objfile): Likewise.
1948         (free_section_addr_info): Remove.
1949         (relative_addr_info_to_section_offsets): Change type of "addrs".
1950         (addrs_section_compar): Now a std::sort comparator.
1951         (addrs_section_sort): Change return type.
1952         (addr_info_make_relative): Change type of "addrs".  Update.
1953         (default_symfile_offsets, syms_from_objfile_1)
1954         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
1955         (symbol_file_add_separate): Update.
1956         (symbol_file_add): Change type of "addrs".  Update.
1957         (add_symbol_file_command): Update.  Remove cleanups.
1958         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
1959         cleanups.
1960         * symfile-debug.c (debug_sym_offsets): Change type of "info".
1961         * solib.c (solib_read_symbols): Update.
1962         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
1963         * machoread.c (macho_symfile_offsets): Update.
1964         * jit.c (jit_bfd_try_read_symtab): Update.
1965
1966 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
1967
1968         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1969         unittests/utils-selftests.c.
1970         * unittests/utils-selftests.c: New file.
1971
1972 2018-03-14  Tom Tromey  <tom@tromey.com>
1973
1974         PR cli/14977:
1975         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
1976         for NULL.
1977
1978 2018-03-14  Tom Tromey  <tom@tromey.com>
1979
1980         PR cli/19918:
1981         * printcmd.c (printf_pointer): Allow "-" in format.
1982
1983 2018-03-14  Tom Tromey  <tom@tromey.com>
1984
1985         * printcmd.c (_initialize_printcmd): Add usage to printf.
1986
1987 2018-03-14  Yao Qi  <qiyao@sourceware.org>
1988
1989         * MAINTAINERS: Update my email address.
1990
1991 2018-03-13  Tom Tromey  <tom@tromey.com>
1992
1993         * machoread.c (macho_check_dsym): Change filenamep to a
1994         std::string*.
1995         (macho_symfile_read): Update.
1996         * symfile.c (load_command): Use std::string.
1997
1998 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1999
2000         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
2001         to error message string.
2002         (riscv_register_name): Use xsnprintf instead of sprintf.
2003         (riscv_insn::fetch_instruction): Use gdb_assert instead of
2004         internal_error.
2005         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
2006         error.
2007         (riscv_push_dummy_call): Likewise.
2008
2009 2018-03-12  Tom Tromey  <tom@tromey.com>
2010
2011         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
2012         Use gdb::byte_vector.
2013         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
2014
2015 2018-03-12  Yao Qi  <yao.qi@linaro.org>
2016
2017         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
2018         parameter type to readable_regcache.
2019         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
2020         the declaration.
2021
2022 2018-03-11  Tom Tromey  <tom@tromey.com>
2023
2024         * dwarf2read.c (struct nextfield): Add initializers.
2025         (struct nextfnfield): Remove.
2026         (struct fnfieldlist): Add initializers.  Remove "length" and
2027         "head", use std::vector.
2028         (struct decl_field_list): Remove.
2029         (struct field_info): Add initializers.
2030         <fields, baseclasses>: Now std::vector.
2031         <nbaseclasses, nfnfields, typedef_field_list_count,
2032         nested_types_list_count>: Remove.
2033         (dwarf2_add_field, dwarf2_add_type_defn)
2034         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
2035         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
2036         (process_structure_scope): Update.
2037
2038 2018-03-11  Tom Tromey  <tom@tromey.com>
2039
2040         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
2041         for use by std::sort.
2042         (build_type_psymtabs_1): Use std::vector.
2043
2044 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
2045
2046         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
2047         and LIBMPFR in the printed configuration.
2048
2049 2018-03-08  Tom Tromey  <tom@tromey.com>
2050
2051         * source.c (get_filename_and_charpos): Use scoped_fd.
2052         * nto-procfs.c (procfs_open_1): Use scoped_fd.
2053         (procfs_pidlist): Likewise.
2054         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
2055         (iterate_over_mappings): Likewise.
2056
2057 2018-03-08  Tom Tromey  <tom@tromey.com>
2058
2059         * infcall.c (struct call_return_meta_info)
2060         <stack_temporaries_enabled>: Remove.
2061         (get_call_return_value, call_function_by_hand_dummy): Update.
2062         * thread.c (disable_thread_stack_temporaries): Remove.
2063         (enable_thread_stack_temporaries): Remove.
2064         (thread_stack_temporaries_enabled_p): Return bool.
2065         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
2066         (get_last_thread_stack_temporary): Update.
2067         * eval.c (evaluate_subexp): Update.
2068         * gdbthread.h (class enable_thread_stack_temporaries): Now a
2069         class, not a function.
2070         (value_ptr, value_vec): Remove typedefs.
2071         (class thread_info) <stack_temporaries_enabled>: Now bool.
2072         <stack_temporaries>: Now a std::vector.
2073         (thread_stack_temporaries_enabled_p)
2074         (value_in_thread_stack_temporaries): Return bool.
2075
2076 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
2077
2078         * remote.c (putpkt_binary): Fix omitted bytes reporting.
2079         (getpkt_or_notif_sane_1): Likewise.
2080
2081 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
2082
2083         * build-id.c (build_id_to_debug_bfd): Use std::string.
2084
2085 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
2086
2087         * build-id.c (find_separate_debug_file_by_buildid): Return
2088         std::string.
2089         * build-id.h (find_separate_debug_file_by_buildid): Return
2090         std::string.
2091         * coffread.c (coff_symfile_read): Adjust to std::string.
2092         * elfread.c (elf_symfile_read): Adjust to std::string.
2093         * symfile.c (separate_debug_file_exists): Change parameter to
2094         std::string.
2095         (find_separate_debug_file): Return std::string.
2096         (find_separate_debug_file_by_debuglink): Return std::string.
2097         * symfile.h (find_separate_debug_file_by_debuglink): Return
2098         std::string.
2099
2100 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
2101
2102         * common/xml-utils.c (xml_escape_text): Move code to...
2103         (xml_escape_text_append): ... this new function.
2104         * common/xml-utils.h (xml_escape_text_append): New declaration.
2105         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
2106         New function.
2107         (_initialize_xml_utils): register test_xml_escape_text_append as
2108         a selftest.
2109
2110 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
2111
2112         * defs.h: Remove MAX_REGISTER_SIZE.
2113         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
2114         asserts.
2115         * python/py-unwind.c (pyuw_sniffer): Likewise.
2116
2117 2018-03-07  Tom Tromey  <tom@tromey.com>
2118
2119         * linux-tdep.c (linux_info_proc): Update.
2120         * target.h (struct target_ops) <to_fileio_readlink>: Return
2121         optional<string>.
2122         (target_fileio_readlink): Return optional<string>.
2123         * remote.c (remote_hostio_readlink): Return optional<string>.
2124         * inf-child.c (inf_child_fileio_readlink): Return
2125         optional<string>.
2126         * target.c (target_fileio_readlink): Return optional<string>.
2127
2128 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2129
2130         * regcache.c (cooked_read_test): Add riscv to the list of
2131         architectures that have a save_reggroup.
2132
2133 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
2134
2135         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
2136         value is not a dynamic class object.
2137
2138 2018-03-06  Tom Tromey  <tom@tromey.com>
2139
2140         * rust-exp.y: Formatting fixes.
2141
2142 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2143
2144         * riscv-tdep.c (riscv_register_name): Remove target description
2145         support.
2146         (riscv_gdbarch_init): Remove target description check.
2147
2148 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2149
2150         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
2151         comment.
2152         * riscv-tdep.h: Likewise.
2153
2154 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2155
2156         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
2157         (riscv_pseudo_register_write): Delete.
2158         (riscv_gdbarch_init): Remove all use of pseudo registers.
2159
2160 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
2161
2162         * record-btrace.c (btrace_print_lines): Replace cleanup
2163         parameter with RAII equivalents.
2164         (btrace_insn_history): Replace cleanup with RAII equivalents.
2165         * ui-out.h (make_cleanup_ui_out_list_begin_end,
2166         make_cleanup_ui_out_tuple_begin_end): Remove.
2167         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
2168         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
2169         make_cleanup_ui_out_list_begin_end): Remove.
2170
2171 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
2172
2173         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
2174         parameter types to std::vector.  Use bool.
2175         (record_btrace_wait): Replace VEC(tp_t) with
2176         std::vector<thread_info *>.
2177         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
2178
2179 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
2180
2181         * record-btrace.c (record_btrace_disable_callback): Remove.
2182         (struct scoped_btrace_disable): New.
2183         (record_btrace_open): Use scoped_btrace_disable.
2184
2185 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2186
2187         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
2188         reading values from registers.
2189
2190 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2191
2192         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
2193         where appropriate.
2194
2195 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2196
2197         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
2198         change parameter type.  Use GDB's print functions, and use
2199         core_addr_to_string where appropriate.
2200         (riscv_push_dummy_call): Use core_addr_to_string where
2201         appropriate, update call to riscv_print_arg_location, and reindent
2202         a few lines.
2203         (riscv_return_value): Update call to riscv_print_arg_location.
2204
2205 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2206             Tim Newsome <tim@sifive.com>
2207             Albert Ou <a0u@eecs.berkeley.edu>
2208             Darius Rad <darius@bluespec.com>
2209
2210         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
2211         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
2212         (ALLDEPFILES): Add riscv-tdep.c
2213         * configure.tgt: Add riscv support.
2214         * riscv-tdep.c: New file.
2215         * riscv-tdep.h: New file.
2216         * NEWS: Mention new target.
2217         * MAINTAINERS: Add entry for riscv.
2218
2219 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2220
2221         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
2222         fields within aggregates.
2223
2224 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
2225
2226         * record-btrace.c (btrace_print_lines): Change type of flags to
2227         gdb_disassembly_flags.
2228
2229 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
2230
2231         * fbsd-nat.c: Include "inf-ptrace.h".
2232         (USE_SIGTRAP_SIGINFO): Conditionally define.
2233         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
2234         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
2235         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
2236         function.
2237         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
2238         Likewise.
2239         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
2240         Likewise.
2241         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
2242         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
2243         "supports_stopped_by_hw_breakpoint" target methods.
2244
2245 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
2246
2247         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
2248         * fbsd-nat.c (debug_fbsd_nat): New variable.
2249         (show_fbsd_nat_debug): New function.
2250         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
2251         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
2252
2253 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
2254
2255         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
2256         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
2257         prototype.
2258         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
2259         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
2260         method.
2261
2262 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
2263
2264         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
2265         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
2266
2267 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
2268
2269         * charset.c (struct charset_vector): New.
2270         (charsets): Change type to charset_vector.
2271         (find_charset_names): Adjust.
2272         (add_one): Adjust.
2273         (_initialize_charset): Adjust.
2274
2275 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
2276
2277         * progspace.h (struct program_space) <deleted_solibs>: Change
2278         type to std::vector<std::string>.
2279         * progspace.c (clear_program_space_solib_cache): Adjust.
2280         * breakpoint.c (print_solib_event): Adjust.
2281         (check_status_catch_solib): Adjust.
2282         * solib.c (update_solib_list): Adjust.
2283         * ui-out.h (class ui_out) <field_string>: New overload.
2284         * ui-out.c (ui_out::field_string): New overload.
2285
2286 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
2287
2288         * progspace.h (struct program_space): Add constructor and
2289         destructor, initialize fields.
2290         (add_program_space): Remove.
2291         * progspace.c (add_program_space): Rename to...
2292         (program_space::program_space): ... this.
2293         (release_program_space): Rename to...
2294         (program_space::~program_space): ... this.
2295         (delete_program_space): Use delete to delete program_space.
2296         (initialize_progspace): Use new to allocate program_space.
2297         * inferior.c (add_inferior_with_spaces): Likewise.
2298         (clone_inferior_command): Likewise.
2299         * infrun.c (follow_fork_inferior): Likewise.
2300         (handle_vfork_child_exec_or_exit): Likewise.
2301
2302 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
2303
2304         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
2305         (delim_string_to_char_ptr_vec): Return std::vector of
2306         gdb::unique_xmalloc_ptr.
2307         (dirnames_to_char_ptr_vec_append): Take std::vector of
2308         gdb::unique_xmalloc_ptr.
2309         (dirnames_to_char_ptr_vec): Return std::vector of
2310         gdb::unique_xmalloc_ptr.
2311         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
2312         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
2313         (delim_string_to_char_ptr_vec): Return an std::vector of
2314         gdb::unique_xmalloc_ptr, adjust the code.
2315         (dirnames_to_char_ptr_vec_append): Take an std::vector of
2316         gdb::unique_xmalloc_ptr, adjust the code.
2317         (dirnames_to_char_ptr_vec): Return an std::vector of
2318         gdb::unique_xmalloc_ptr, adjust the code.
2319         * auto-load.c (auto_load_safe_path_vec): Change type to
2320         std::vector of gdb::unique_xmalloc_ptr.
2321         (auto_load_expand_dir_vars): Return an std::vector of
2322         gdb::unique_xmalloc_ptr, adjust the code.
2323         (auto_load_safe_path_vec_update): Adjust.
2324         (filename_is_in_auto_load_safe_path_vec): Adjust.
2325         (auto_load_objfile_script_1): Adjust.
2326         * build-id.c (build_id_to_debug_bfd): Adjust.
2327         * linux-thread-db.c (thread_db_load_search): Adjust.
2328         * source.c (add_path): Adjust.
2329         (openp): Adjust.
2330         * symfile.c (find_separate_debug_file): Adjust.
2331         * utils.c (do_free_char_ptr_vec): Remove.
2332         (make_cleanup_free_char_ptr_vec): Remove.
2333
2334 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2335
2336         PR gdb/22907
2337         * common/pathstuff.c: Conditionally include "<windows.h>".
2338
2339 2018-03-01  Georg Sauthoff  <mail@georg.so>
2340
2341         PR gdb/22888
2342         * gcore.in: Quote variables and switch interpreter to bash.
2343
2344 2018-03-01  Tom Tromey  <tom@tromey.com>
2345
2346         * dwarf2read.c (alloc_discriminant_info): Fix default_index
2347         assertion.  Add assertion for discriminant_index.
2348         (quirk_rust_enum): Use correct base type name in univariant case.
2349
2350 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
2351
2352         * record.c (get_call_history_modifiers): Return a
2353         record_print_flags.
2354         (cmd_record_call_history): Adjust.
2355         * record-btrace.c (record_btrace_call_history): Adjust.
2356         (record_btrace_call_history_range): Adjust.
2357         (record_btrace_call_history_from): Adjust.
2358         * target-debug.h (target_debug_print_record_print_flags): New.
2359         * target-delegates.c: Re-generate.
2360         * target.c (target_call_history): Change flags type.
2361         (target_call_history_from): Likewise.
2362         (target_call_history_range): Likewise.
2363         * target.h (struct target_ops) <target_call_history>: Likewise.
2364         (target_call_history_from): Likewise.
2365         (target_call_history_range): Likewise.
2366
2367 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2368             Simon Marchi  <simon.marchi@polymtl.ca>
2369
2370         * common/common-utils.c: Include "sys/stat.h".
2371         (is_regular_file): Move here from "source.c"; change return
2372         type to "bool".
2373         * common/common-utils.h (is_regular_file): New prototype.
2374         * common/pathstuff.c (contains_dir_separator): New function.
2375         * common/pathstuff.h (contains_dir_separator): New prototype.
2376         * source.c: Don't include "sys/stat.h".
2377         (is_regular_file): Move to "common/common-utils.c".
2378
2379 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2380
2381         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
2382         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
2383         * auto-load.c: Include "common/pathstuff.h".
2384         * common/common-def.h (current_directory): Move here.
2385         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
2386         function.
2387         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
2388         prototype.
2389         * common/pathstuff.c: New file.
2390         * common/pathstuff.h: New file.
2391         * compile/compile.c: Include "common/pathstuff.h".
2392         * defs.h (current_directory): Move to "common/common-defs.h".
2393         * dwarf2read.c: Include "common/pathstuff.h".
2394         * exec.c: Likewise.
2395         * guile/scm-safe-call.c: Likewise.
2396         * linux-thread-db.c: Likewise.
2397         * main.c: Likewise.
2398         * nto-tdep.c: Likewise.
2399         * objfiles.c: Likewise.
2400         * source.c: Likewise.
2401         * symtab.c: Likewise.
2402         * utils.c: Include "common/pathstuff.h".
2403         (gdb_realpath): Move to "common/pathstuff.c".
2404         (gdb_realpath_keepfile): Likewise.
2405         (gdb_abspath): Likewise.
2406         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
2407         (gdb_realpath_keepfile): Likewise.
2408         (gdb_abspath): Likewise.
2409
2410 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
2411
2412         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
2413         wildcard process pid for super_resume for kernels with a
2414         specific bug.
2415
2416 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
2417
2418         * compile/compile.c (get_args): Add additional comments
2419         explaining function.
2420
2421 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
2422             Tom Tromey  <tom@tromey.com>
2423
2424         * target.h (memory_write_request_s): Remove typedef.  Don't define
2425         VEC.
2426         (target_write_memory_blocks): Change argument to std::vector.
2427         (struct memory_write_request): Add constructor.
2428         * target-memory.c (compare_block_starting_address): Return bool.
2429         Change argument types.
2430         (claim_memory): Change arguments to use std::vector.
2431         (split_regular_and_flash_blocks, blocks_to_erase)
2432         (compute_garbled_blocks): Likewise.
2433         (cleanup_request_data, cleanup_write_requests_vector): Remove.
2434         (target_write_memory_blocks): Change argument to std::vector.
2435         * symfile.c (struct load_section_data): Add constructor and
2436         destructor.  Use std::vector for "requests".
2437         (struct load_progress_data): Add initializers.
2438         (load_section_callback): Update.  Use "new".
2439         (clear_memory_write_data): Remove.
2440         (generic_load): Update.
2441
2442 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
2443
2444         * arch/aarch64.h: Use common/tdesc.h.
2445
2446 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
2447
2448         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
2449         architecture with a 64-bit ABI.
2450
2451 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
2452
2453         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
2454         ahead of target description loading.
2455
2456 2018-02-26  Tom Tromey  <tom@tromey.com>
2457
2458         * stack.c (backtrace_command_1): Update.
2459         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
2460         of "flags".
2461         * python/py-framefilter.c (py_print_frame)
2462         (gdbpy_apply_frame_filter): Change type of "flags".
2463         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
2464         of "flags".
2465         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
2466         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
2467         * extension.h (enum frame_filter_flag): Rename from
2468         frame_filter_flags.
2469         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
2470         (apply_ext_lang_frame_filter): Change type of "flags".
2471         * extension.c (apply_ext_lang_frame_filter): Change type of
2472         "flags".
2473         * extension-priv.h (struct extension_language_ops)
2474         <apply_frame_filter>: Change type of "flags".
2475
2476 2018-02-26  Tom Tromey  <tom@tromey.com>
2477
2478         PR python/16497:
2479         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
2480         off-by-one in py_end computation.
2481         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
2482         PRINT_MORE_FRAMES.
2483         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
2484         constant.
2485
2486 2018-02-26  Tom Tromey  <tom@tromey.com>
2487
2488         * dwarf2read.c (struct variant_field): New.
2489         (struct nextfield) <variant>: New field.
2490         (dwarf2_add_field): Handle DW_TAG_variant_part.
2491         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
2492         discriminated union.
2493         (read_structure_type): Handle DW_TAG_variant_part.
2494         (handle_struct_member_die): New function, extracted from
2495         process_structure_scope.  Handle DW_TAG_variant.
2496         (process_structure_scope): Handle discriminated unions.  Call
2497         handle_struct_member_die.
2498
2499 2018-02-26  Tom Tromey  <tom@tromey.com>
2500
2501         * rust-lang.h (rust_last_path_segment): Declare.
2502         * rust-lang.c (rust_last_path_segment): Now public.  Change
2503         contract.
2504         (struct disr_info): Remove.
2505         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
2506         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
2507         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
2508         (rust_enum_p, rust_enum_variant): New function.
2509         (rust_underscore_fields): Remove "offset" parameter.
2510         (rust_print_enum): New function.
2511         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
2512         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
2513         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
2514         enums.
2515         (rust_internal_print_type): New function, from rust_print_type.
2516         Remove enum code.
2517         (rust_print_type): Call rust_internal_print_type.
2518         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
2519         Update enum handling.
2520         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
2521         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
2522         (rust_union_quirks): New functions.
2523         (process_full_comp_unit, process_full_type_unit): Call
2524         rust_union_quirks.
2525         (process_structure_scope): Update rust_unions if necessary.
2526
2527 2018-02-26  Tom Tromey  <tom@tromey.com>
2528
2529         * value.h (value_union_variant): Declare.
2530         * valops.c (value_union_variant): New function.
2531         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
2532         (struct discriminant_info): New.
2533         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
2534         enumerator.
2535         (struct main_type) <flag_discriminated_union>: New field.
2536
2537 2018-02-26  Tom Tromey  <tom@tromey.com>
2538
2539         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2540         unittests/unpack-selftests.c.
2541         * unittests/unpack-selftests.c: New file.
2542         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
2543
2544 2018-02-26  Yao Qi  <yao.qi@linaro.org>
2545
2546         * dwarf2read.c (struct partial_die_info) <read>: New method.
2547         (read_partial_die): Remove the declaration.
2548         (load_partial_dies): Update.
2549         (partial_die_info::partial_die_info):
2550         (read_partial_die): Change it to partial_die_info::read.
2551
2552 2018-02-26  Yao Qi  <yao.qi@linaro.org>
2553
2554         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
2555         (fixup_partial_die): Remove declaration.
2556         (scan_partial_symbols): Update.
2557         (partial_die_parent_scope): Likewise.
2558         (partial_die_full_name): Likewise.
2559         (fixup_partial_die): Change it to partial_die_info::fixup.
2560
2561 2018-02-26  Yao Qi  <yao.qi@linaro.org>
2562
2563         * dwarf2read.c (read_partial_die): Update the declaration.
2564         (load_partial_dies): Caller update.
2565         (read_partial_die): Remove one argument abbrev_len.
2566
2567 2018-02-26  Yao Qi  <yao.qi@linaro.org>
2568
2569         * dwarf2read.c (struct partial_die_info): Add ctor, delete
2570         assignment operator.
2571         (load_partial_dies): Use ctor and copy ctor.
2572         (read_partial_die): Update.
2573         (dwarf2_cu::find_partial_die): Use ctor.
2574
2575 2018-02-26  Yao Qi  <yao.qi@linaro.org>
2576
2577         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
2578         (find_partial_die_in_comp_unit): Change it to
2579         dwarf2_cu::find_partial_die.
2580         (find_partial_die): Update.
2581
2582 2018-02-26  Yao Qi  <yao.qi@linaro.org>
2583
2584         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
2585         is NULL.
2586
2587 2018-02-26  Yao Qi  <yao.qi@linaro.org>
2588
2589         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
2590
2591 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
2592
2593         * arch/amd64.h: Use common/tdesc.h.
2594         * arch/i386.c: Likewise.
2595         * arch/i386.h: Likewise.
2596         * arch/tic6x.c: Likewise.
2597         * arch/tdesc.h: Move file from here...
2598         * common/tdesc.h: ...to here.
2599         * features/aarch64-core.c: Regenerate.
2600         * features/aarch64-fpu.c: Regenerate.
2601         * features/i386/32bit-avx.c: Regenerate.
2602         * features/i386/32bit-avx512.c: Regenerate.
2603         * features/i386/32bit-core.c: Regenerate.
2604         * features/i386/32bit-linux.c: Regenerate.
2605         * features/i386/32bit-mpx.c: Regenerate.
2606         * features/i386/32bit-pkeys.c: Regenerate.
2607         * features/i386/32bit-sse.c: Regenerate.
2608         * features/i386/64bit-avx.c: Regenerate.
2609         * features/i386/64bit-avx512.c: Regenerate.
2610         * features/i386/64bit-core.c: Regenerate.
2611         * features/i386/64bit-linux.c: Regenerate.
2612         * features/i386/64bit-mpx.c: Regenerate.
2613         * features/i386/64bit-pkeys.c: Regenerate.
2614         * features/i386/64bit-segments.c: Regenerate.
2615         * features/i386/64bit-sse.c: Regenerate.
2616         * features/i386/x32-core.c: Regenerate.
2617         * features/tic6x-c6xp.c: Regenerate.
2618         * features/tic6x-core.c: Regenerate.
2619         * features/tic6x-gp.c: Regenerate.
2620         * target-descriptions.c: Use common/tdesc.h.
2621         * target-descriptions.h: Likewise.
2622
2623 2018-02-24  Tom Tromey  <tom@tromey.com>
2624
2625         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
2626         (try_thread_db_load_from_dir, thread_db_load_search): Use
2627         std::string.
2628         (info_auto_load_libthread_db_compare): Return bool.  Change
2629         argument types.
2630         (info_auto_load_libthread_db): Use std::vector, std::string.
2631         Remove cleanups.
2632
2633 2018-02-24  Tom Tromey  <tom@tromey.com>
2634
2635         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
2636         std::string.
2637         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
2638         std::string*.
2639         * gdbarch.c: Rebuild.
2640         * gdbarch.h: Rebuild.
2641         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
2642         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
2643         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
2644         std::string*.
2645
2646 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
2647
2648         * gdbtypes.h (sect_offset): Change type to uint64_t.
2649         (sect_offset_str): New function.
2650         * dwarf2read.c (create_addrmap_from_aranges): Use
2651         sect_offset_str.
2652         (error_check_comp_unit_head): Likewise.
2653         (create_debug_type_hash_table): Likewise.
2654         (read_cutu_die_from_dwo): Likewise.
2655         (init_cutu_and_read_dies): Likewise.
2656         (init_cutu_and_read_dies_no_follow): Likewise.
2657         (process_psymtab_comp_unit_reader): Likewise.
2658         (partial_die_parent_scope): Likewise.
2659         (peek_die_abbrev): Likewise.
2660         (process_queue): Likewise.
2661         (dwarf2_physname): Likewise.
2662         (read_namespace_alias): Likewise.
2663         (read_import_statement): Likewise.
2664         (create_dwo_cu_reader): Likewise.
2665         (create_cus_hash_table): Likewise.
2666         (lookup_dwo_cutu): Likewise.
2667         (inherit_abstract_dies): Likewise.
2668         (read_func_scope): Likewise.
2669         (read_call_site_scope): Likewise.
2670         (dwarf2_add_member_fn): Likewise.
2671         (read_common_block): Likewise.
2672         (read_module_type): Likewise.
2673         (read_typedef): Likewise.
2674         (read_subrange_type): Likewise.
2675         (load_partial_dies): Likewise.
2676         (read_partial_die): Likewise.
2677         (find_partial_die): Likewise.
2678         (read_str_index): Likewise.
2679         (dwarf2_string_attr): Likewise.
2680         (build_error_marker_type): Likewise.
2681         (lookup_die_type): Likewise.
2682         (dump_die_shallow): Likewise.
2683         (follow_die_ref): Likewise.
2684         (dwarf2_fetch_die_loc_sect_off): Likewise.
2685         (dwarf2_fetch_constant_bytes): Likewise.
2686         (follow_die_sig): Likewise.
2687         (get_signatured_type): Likewise.
2688         (get_DW_AT_signature_type): Likewise.
2689         (dwarf2_find_containing_comp_unit): Likewise.
2690         (set_die_type): Likewise.
2691
2692 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
2693
2694         * arch/aarch64.c: Include "common-defs.h".
2695         * arch/amd64.c: Likewise.
2696         * arch/i386.c: Likewise.
2697
2698 2018-02-21  Tom Tromey  <tom@tromey.com>
2699
2700         * value.h: (extract_field_op): Update.
2701         * eval.c (extract_field_op): Return a const char *.
2702         * expression.h (parse_expression_for_completion): Update.
2703         * completer.c (complete_expression): Update.
2704         (add_struct_fields): Make fieldname const.
2705         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
2706         (mark_completion_tag, parse_exp_in_context_1): Update.
2707         (parse_expression_for_completion): Change "name" to
2708         unique_xmalloc_ptr*.
2709
2710 2018-02-21  Tom Tromey  <tom@tromey.com>
2711
2712         * infcall.c (call_function_by_hand_dummy): Use std::vector.
2713
2714 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2715
2716         * avr-tdep.c (avr_read_pc): Change parameter type to
2717         readable_regcache.
2718         * gdbarch.sh (read_pc): Likewise.
2719         * gdbarch.c: Re-generated.
2720         * gdbarch.h: Re-generated.
2721         * hppa-tdep.c (hppa_read_pc): Change parameter type to
2722         readable_regcache.
2723         * ia64-tdep.c (ia64_read_pc): Likewise.
2724         * mips-tdep.c (mips_read_pc): Likewise.
2725         * spu-tdep.c (spu_read_pc): Likewise.
2726
2727 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2728
2729         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
2730         * regcache-dump.c: New file.
2731         * regcache.c: Move register_dump to regcache-dump.c.
2732         (maintenance_print_registers): Likewise.
2733         (maintenance_print_raw_registers): Likewise.
2734         (maintenance_print_cooked_registers): Likewise.
2735         (maintenance_print_register_groups): Likewise.
2736         (maintenance_print_remote_registers): Likewise.
2737         (_initialize_regcache): Likewise.
2738         * regcache.h (register_dump): Moved from regcache.c.
2739
2740 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2741
2742         * regcache.c (regcache::regcache): Update.
2743         (regcache::invalidate): Move it to detached_regcache::invalidate.
2744         (get_thread_arch_aspace_regcache): Update.
2745         (regcache::raw_update): Update.
2746         (regcache::cooked_read): Remove some code.
2747         (regcache::cooked_read_value): Likewise.
2748         (regcache::raw_write): Remove assert on m_readonly_p.
2749         (regcache::raw_supply_integer): Move it to
2750         detached_regcache::raw_supply_integer.
2751         (regcache::raw_supply_zeroed): Likewise.
2752         * regcache.h (detached_regcache) <raw_supply_integer>: New
2753         declaration.
2754         <raw_supply_zeroed, invalidate>: Likewise.
2755         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
2756         <invalidate>: Likewise.
2757         <m_readonly_p>: Removed.
2758
2759 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2760
2761         * infcmd.c (get_return_value): Let stop_regs point to
2762         get_current_regcache.
2763         * regcache.c (regcache::regcache): Remove.
2764         (register_dump_reg_buffer): New class.
2765         (regcache_print): Adjust.
2766         * regcache.h (regcache): Remove constructors.
2767
2768 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2769
2770         * regcache.c (class register_dump): New class.
2771         (register_dump_regcache, register_dump_none): New class.
2772         (register_dump_remote, register_dump_groups): New class.
2773         (regcache_print): Update.
2774         * regcache.h (regcache_dump_what): Move it to regcache.c.
2775         (regcache) <dump>: Remove.
2776
2777 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2778
2779         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
2780          reg_buffer_rw *.
2781         (jit_unwind_reg_set_impl): Call raw_supply.
2782         (jit_frame_sniffer): Use reg_buffer_rw.
2783         * record-full.c (record_full_core_regbuf): Change its type.
2784         (record_full_core_open_1): Use reg_buffer_rw.
2785         (record_full_close): Likewise.
2786         (record_full_core_fetch_registers): Use regcache->raw_supply.
2787         (record_full_core_store_registers): Likewise.
2788         * regcache.c (regcache::get_register_status): Move it to
2789         reg_buffer.
2790         (regcache_raw_set_cached_value): Remove.
2791         (regcache::raw_set_cached_value): Remove.
2792         (regcache::raw_write): Call raw_supply.
2793         (regcache::raw_supply): Move it to reg_buffer_rw.
2794         * regcache.h (regcache_raw_set_cached_value): Remove.
2795         (reg_buffer_rw): New class.
2796
2797 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2798
2799         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
2800         readonly_detached_regcache.
2801         (dummy_frame_prev_register): Use regcache->cooked_read.
2802         * frame.c (frame_save_as_regcache): Change return type.
2803         (frame_pop): Update.
2804         * frame.h (frame_save_as_regcache): Update declaration.
2805         * inferior.h (get_infcall_suspend_state_regcache): Update
2806         declaration.
2807         * infrun.c (infcall_suspend_state) <registers>: use
2808         readonly_detached_regcache.
2809         (save_infcall_suspend_state): Don't use regcache_dup.
2810         (get_infcall_suspend_state_regcache): Change return type.
2811         * linux-fork.c (struct fork_info) <savedregs>: Change to
2812         readonly_detached_regcache.
2813         <pc>: New field.
2814         (fork_save_infrun_state): Don't use regcache_dup.
2815         (info_checkpoints_command): Adjust.
2816         * mi/mi-main.c (register_changed_p): Update declaration.
2817         (mi_cmd_data_list_changed_registers): Use
2818         readonly_detached_regcache.
2819         (register_changed_p): Change parameter type to
2820         readonly_detached_regcache.
2821         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
2822         readonly_detached_regcache.
2823         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
2824         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
2825         New.
2826         (regcache::save): Move it to reg_buffer.
2827         (regcache::restore): Change parameter type.
2828         (regcache_dup): Remove.
2829         * regcache.h (reg_buffer) <save>: New method.
2830         (readonly_detached_regcache): New class.
2831         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
2832         readonly_detached_regcache.
2833         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
2834
2835 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2836
2837         * frame.c (frame_save_as_regcache): Use regcache method save.
2838         (frame_pop): Use regcache method restore.
2839         * infrun.c (restore_infcall_suspend_state): Likewise.
2840         * linux-fork.c (fork_load_infrun_state): Likewise.
2841         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
2842         save.
2843         * regcache.c (regcache_save): Remove.
2844         (regcache::restore): More asserts.
2845         (regcache_cpy): Remove.
2846         * regcache.h (regcache_save): Remove the declaration.
2847         (regcache::restore): Move from private to public.
2848         Remove the friend declaration of regcache_cpy.
2849         (regcache_cpy): Remove declaration.
2850
2851 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2852
2853         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
2854         parameter type to 'readable_regcache *'.
2855         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
2856         * arm-tdep.c (arm_neon_quad_read): Likewise.
2857         (arm_pseudo_read): Likewise.
2858         * avr-tdep.c (avr_pseudo_register_read): Likewise.
2859         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
2860         * frv-tdep.c (frv_pseudo_register_read): Likewise.
2861         * gdbarch.c: Re-generated.
2862         * gdbarch.h: Re-generated.
2863         * gdbarch.sh (pseudo_register_read): Change parameter type to
2864         'readable_regcache *'.
2865         (pseudo_register_read_value): Likewise.
2866         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
2867         (h8300_pseudo_register_read): Likewise.
2868         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
2869         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
2870         (i386_pseudo_register_read_into_value): Likewise.
2871         (i386_pseudo_register_read_value): Likewise.
2872         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
2873         declaration.
2874         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
2875         * m32c-tdep.c (m32c_raw_read): Likewise.
2876         (m32c_read_flg): Likewise.
2877         (m32c_banked_register): Likewise.
2878         (m32c_banked_read): Likewise.
2879         (m32c_sb_read): Likewise.
2880         (m32c_part_read): Likewise.
2881         (m32c_cat_read): Likewise.
2882         (m32c_r3r2r1r0_read): Likewise.
2883         (m32c_pseudo_register_read): Likewise.
2884         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
2885         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
2886         (mep_pseudo_cr64_read): Likewise.
2887         (mep_pseudo_register_read): Likewise.
2888         * mips-tdep.c (mips_pseudo_register_read): Likewise.
2889         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
2890         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
2891         * regcache.c (regcache::raw_read): Move it to readable_regcache.
2892         (regcache::cooked_read): Likewise.
2893         (regcache::cooked_read_value): Likewise.
2894         (regcache_cooked_read_signed):
2895         (regcache::cooked_read): Likewise.
2896         * regcache.h (readable_regcache): New class.
2897         (regcache): Inherit readable_regcache.  Move some methods to
2898         readable_regcache.
2899         * rl78-tdep.c (rl78_pseudo_register_read): Change
2900         parameter type to 'readable_regcache *'.
2901         * rs6000-tdep.c (do_regcache_raw_read): Remove.
2902         (e500_pseudo_register_read): Change parameter type to
2903         'readable_regcache *'.
2904         (dfp_pseudo_register_read): Likewise.
2905         (vsx_pseudo_register_read): Likewise.
2906         (efpr_pseudo_register_read): Likewise.
2907         * s390-tdep.c (s390_pseudo_register_read): Likewise.
2908         * sh-tdep.c (sh_pseudo_register_read): Likewise.
2909         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
2910         (sh64_pseudo_register_read): Likewise.
2911         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
2912         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
2913         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
2914         (spu_pseudo_register_read): Likewise.
2915         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
2916         (xtensa_pseudo_register_read): Likewise.
2917
2918 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2919
2920         * regcache.c (regcache::regcache): Call reg_buffer ctor.
2921         (regcache::arch): Move it to reg_buffer::arch.
2922         (regcache::register_buffer): Likewise.
2923         (regcache::assert_regnum): Likewise.
2924         (regcache::num_raw_registers): Likewise.
2925         * regcache.h (reg_buffer): New class.
2926         (regcache): Inherit reg_buffer.
2927
2928 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
2929
2930         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
2931         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
2932
2933 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
2934
2935         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
2936
2937 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
2938
2939         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
2940         (SFILES): Remove common/*.c files.
2941         (COMMON_OBS): Remove some *.o files built from common/*.c files.
2942         * common/common.host: Add common reference.
2943         * configure.ac: Likewise.
2944         * configure: Regenerate.
2945
2946 2018-02-16  Yao Qi  <yao.qi@linaro.org>
2947
2948         * block.c (block_namespace_info): Inherit allocate_on_obstack.
2949         (block_initialize_namespace): Use new.
2950         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
2951         (dwarf2_free_objfile): Use delete.
2952         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
2953         (copy_type_recursive): Use new.
2954         * gdb_obstack.h (allocate_on_obstack): New.
2955
2956 2018-02-15  Yao Qi  <yao.qi@linaro.org>
2957
2958         PR gdb/22849
2959         * inferior.c (exit_inferior_1): Reset inf->control.
2960
2961 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
2962
2963         * ada-lang.c (ada_to_fixed_value_create): Delete advance
2964         declaration.
2965
2966 2018-02-14  Pedro Alves  <palves@redhat.com>
2967
2968         * frame-unwind.c (frame_unwind_try_unwinder): Always call
2969         frame_cleanup_after_sniffer on exception.
2970
2971 2018-02-14  Tom Tromey  <tom@tromey.com>
2972
2973         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
2974         const.
2975         (solib_bfd_open): Make pathname const.
2976         * solib.c (solib_bfd_open): Make pathname const.
2977         * solib-spu.c (spu_bfd_fopen): Make name const.
2978         (spu_bfd_open): Make pathname const.
2979         * solib-darwin.c (darwin_bfd_open): Make pathname const.
2980         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
2981
2982 2018-02-14  Tom Tromey  <tom@tromey.com>
2983
2984         * symfile.c (symfile_bfd_open): Update.
2985         * source.h (openp, source_full_path_of, find_and_open_source):
2986         Change argument type to unique_xmalloc_ptr.
2987         * source.c (openp): Take a unique_xmalloc_ptr.
2988         (source_full_path_of, find_and_open_source): Likewise.
2989         (open_source_file, symtab_to_fullname): Update.
2990         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
2991         unique_xmalloc_ptr.
2992         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
2993         (exec_file_find): Update.
2994         * psymtab.c (psymtab_to_fullname): Update.
2995         * nto-tdep.h (nto_find_and_open_solib): Update.
2996         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
2997         unique_xmalloc_ptr.
2998         * exec.c (exec_file_attach): Update.
2999         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
3000         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
3001
3002 2018-02-14  Tom Tromey  <tom@tromey.com>
3003
3004         * solib.c: Include source.h.
3005         * nto-tdep.c: Include source.h.
3006         * mi/mi-cmd-env.c: Include source.h.
3007         * infcmd.c: Include source.h.
3008         * exec.c: Include source.h.
3009         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
3010         (add_path, directory_switch, source_path, init_source_path): Move
3011         declarations...
3012         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
3013         (add_path, directory_switch, source_path, init_source_path):
3014         ...here.
3015
3016 2018-02-14  Tom Tromey  <tom@tromey.com>
3017
3018         * solist.h (exec_file_find, solib_find): Return
3019         unique_xmalloc_ptr.
3020         (solib_bfd_fopen): Take a const char *.
3021         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
3022         (exec_file_find, solib_find): Likewise.
3023         (solib_bfd_fopen): Do not take ownership of "pathname".
3024         (solib_bfd_open): Use unique_xmalloc_ptr.
3025         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
3026         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
3027         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
3028         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
3029
3030 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
3031
3032         * ada-lang.c (name_match_type_from_name): Remove reference to
3033         ada_name_for_lookup in function's documentation.
3034         * ada-lang.h (ada_name_for_lookup): Delete declaration.
3035
3036 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
3037
3038         * defs.h (enum openp_flags): New enum.
3039         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
3040         Move to enum openp_flags.
3041         (openp_flags): New enum flags.
3042         (openp): Change parameter type to openp_flags.
3043         * source.c (openp): Change parameter type to openp_flags.
3044         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
3045         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
3046
3047 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
3048
3049         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
3050         per-command.
3051
3052 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3053
3054         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
3055         into...
3056         (class dwarf2_queue_guard): ...the destructor of this new class.
3057         (dw2_do_instantiate_symtab): Create instance of the new class
3058         dwarf2_queue_guard, remove cleanup.
3059
3060 2018-02-09  Tom Tromey  <tom@tromey.com>
3061
3062         * source.c (find_source_lines): Don't reference past the end of
3063         the vector.
3064
3065 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
3066
3067         * remote.c (remote_btrace_maybe_reopen): Change error message.
3068         * btrace.c (btrace_enable): Likewise.
3069         (parse_xml_btrace): Likewise.
3070         (parse_xml_btrace_conf): Likewise.
3071
3072 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
3073
3074         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
3075         (linux_enable_pt, linux_enable_bts): Call
3076         diagnose_perf_event_open_fail.
3077
3078 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
3079
3080         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
3081         Remove parameter and change return type.  Update callers.  Move it.
3082         (linux_enable_bts, linux_enable_pt): Improve error message.
3083         (linux_enable_pt): Remove zero buffer size check.
3084         (linux_enable_btrace): Improve error messages.  Remove NULL return
3085         check.
3086
3087 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
3088
3089         * btrace.c (btrace_enable): Remove target_supports_btrace call.
3090         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
3091         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
3092         (linux_supports_pt, linux_supports_btrace): Remove.
3093         (linux_enable_bts): Call cpu_supports_bts.
3094         * nat/linux-btrace.h (linux_supports_btrace): Remove.
3095         * remote.c (remote_supports_btrace): Remove.
3096         (init_remote_ops): Remove remote_supports_btrace.
3097         * target-delegates.c: Regenerated.
3098         * target.c (target_supports_btrace): Remove.
3099         * target.h (target_ops) <to_supports_btrace>: Remove
3100         (target_supports_btrace): Remove.
3101         * x86-linux-nat.c (x86_linux_create_target): Remove
3102         linux_supports_btrace.
3103
3104 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
3105
3106         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
3107         btrace failed.
3108         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
3109         exception and use message in own exception.
3110
3111 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
3112
3113         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
3114         (perf_event_pt_event_type): Use gdb_file_up.
3115         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
3116         scoped_fd, and scoped_mmap.
3117
3118 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
3119
3120         * common/scoped_mmap.h: New.
3121         * unittests/scoped_mmap-selftest.c: New.
3122         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3123         unittests/scoped_mmap-selftest.c.
3124
3125 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
3126
3127         * common/scoped_fd.h: New.
3128         * unittests/scoped_fd-selftest.c: New.
3129         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3130         unittests/scoped_fd-selftest.c.
3131
3132 2018-02-09  Tom Tromey  <tom@tromey.com>
3133
3134         * auto-load.c (auto_load_section_scripts): Use
3135         gdb::unique_xmalloc_ptr.
3136
3137 2018-02-09  Tom Tromey  <tom@tromey.com>
3138
3139         * auto-load.c (execute_script_contents): Use std::string.
3140
3141 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
3142
3143         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
3144         Python function, rather than a new command.
3145
3146 2018-02-08  Tom Tromey  <tom@tromey.com>
3147
3148         * solib.c (solib_find_1): Use std::string.
3149         (solib_bfd_fopen): Use unique_xmalloc_ptr.
3150
3151 2018-02-08  Tom Tromey  <tom@tromey.com>
3152
3153         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
3154
3155 2018-02-08  Tom Tromey  <tom@tromey.com>
3156
3157         * source.c (find_source_lines): Use gdb::def_vector.
3158
3159 2018-02-08  Tom Tromey  <tom@tromey.com>
3160
3161         * macrocmd.c (struct temporary_macro_definition): New.
3162         (macro_define_command): Use temporary_macro_definition.  Remove
3163         cleanups.
3164         (free_macro_definition_ptr): Remove.
3165
3166 2018-02-08  Tom Tromey  <tom@tromey.com>
3167
3168         * macroexp.c (maybe_expand): Use std::string.
3169
3170 2018-02-08  Tom Tromey  <tom@tromey.com>
3171
3172         * macroexp.c (struct macro_buffer): Add initializers for some
3173         members.
3174         (init_buffer, init_shared_buffer, free_buffer)
3175         (free_buffer_return_text): Remove.
3176         (macro_buffer): New constructors.
3177         (~macro_buffer): New destructor.
3178         (macro_buffer::set_shared): New method.
3179         (macro_buffer::resize_buffer, macro_buffer::appendc)
3180         (macro_buffer::appendmem): Now methods, not free functions.
3181         (set_token, append_tokens_without_splicing, stringify)
3182         (macro_stringify): Update.
3183         (gather_arguments): Change return type.  Remove argc_p argument,
3184         add args_ptr argument.  Use std::vector.
3185         (substitute_args): Remove argc argument.  Accept std::vector.
3186         (expand): Update.  Use std::vector.
3187         (scan, macro_expand, macro_expand_next): Update.
3188
3189 2018-02-08  Tom Tromey  <tom@tromey.com>
3190
3191         * symtab.c (default_collect_symbol_completion_matches_break_on):
3192         Use unique_xmalloc_ptr.
3193         * macroscope.h: (sal_macro_scope, user_macro_scope)
3194         (default_macro_scope): Return unique_xmalloc_ptr.
3195         * macroscope.c (sal_macro_scope, user_macro_scope)
3196         (default_macro_scope): Return unique_xmalloc_ptr.
3197         * macroexp.h (macro_expand, macro_expand_once): Return
3198         unique_xmalloc_ptr.
3199         * macroexp.c (macro_expand, macro_expand_once): Return
3200         unique_xmalloc_ptr.
3201         * macrocmd.c (macro_expand_command, macro_expand_once_command)
3202         (info_macro_command, info_macros_command): Use
3203         unique_xmalloc_ptr.
3204         * compile/compile-c-support.c (write_macro_definitions): Use
3205         unique_xmalloc_ptr.
3206         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
3207
3208 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
3209
3210         * value.c (value_static_field): Assign field type instead of
3211         containing type when returning an optimized out value.
3212
3213 2018-02-06  Yao Qi  <yao.qi@linaro.org>
3214
3215         * ft32-tdep.c (ft32_read_pc): Remove.
3216         (ft32_write_pc): Remove.
3217         (ft32_gdbarch_init): Update.
3218         * m32r-tdep.c (m32r_read_pc): Remove.
3219         (m32r_gdbarch_init): Update.
3220         * mep-tdep.c (mep_read_pc): Remove.
3221         (mep_gdbarch_init): Update.
3222         * microblaze-tdep.c (microblaze_write_pc): Remove.
3223         (microblaze_gdbarch_init): Update.
3224         * mn10300-tdep.c (mn10300_read_pc): Remove.
3225         (mn10300_write_pc): Remove.
3226         (mn10300_gdbarch_init): Update.
3227         * moxie-tdep.c (moxie_read_pc): Remove.
3228         (moxie_write_pc): Remove.
3229         (moxie_gdbarch_init): Update.
3230
3231 2018-02-06  Yao Qi  <yao.qi@linaro.org>
3232
3233         * expprint.c (print_subexp_standard): Handle
3234         OP_F77_UNDETERMINED_ARGLIST.
3235         (dump_subexp_body_standard): Likewise.
3236
3237 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
3238
3239         * target-descriptions.c (tdesc_element_visitor) Add empty
3240         implementations.
3241         (tdesc_type): Move make_gdb_type from here.
3242         (tdesc_type_builtin): Likewise.
3243         (tdesc_type_vector): Likewise.
3244         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
3245         (make_gdb_type_struct): Move from tdesc_type_with_fields.
3246         (make_gdb_type_union): Likewise.
3247         (make_gdb_type_flags): Likewise.
3248         (make_gdb_type_enum): Likewise.
3249         (make_gdb_type): New function.
3250         (tdesc_register_type): Use static make_gdb_type.
3251
3252 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
3253
3254         * infcmd.c (default_print_one_register_info): Align natural-format
3255         column values consistently one under another.
3256         (pad_to_column): New function.
3257
3258 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
3259
3260         * dwarf2read.c (dwarf2_physname): Move commment.
3261
3262 2018-02-01  Leszek Swirski  <leszeks@google.com>
3263
3264         * varobj.c (varobj_formatted_print_options): Allow recursive
3265         pretty printing if pretty printing is enabled.
3266
3267 2018-02-01  Leszek Swirski  <leszeks@google.com>
3268
3269         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
3270         names after a structop as a filename.
3271
3272 2018-02-01  Yao Qi  <yao.qi@linaro.org>
3273
3274         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
3275         (arm_record_coproc_data_proc): Likewise.
3276
3277 2018-02-01  Yao Qi  <yao.qi@linaro.org>
3278
3279         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
3280
3281 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
3282
3283         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
3284         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
3285
3286 2018-01-31  Pedro Alves  <palves@redhat.com>
3287
3288         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
3289         * inflow.c (child_terminal_save_inferior): Wrap reference to
3290         tcgetpgrp in HAVE_TERMIOS_H.
3291         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
3292         _WIN32.
3293         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
3294         always iterate over all inferiors.
3295         (gdbsim_cntrl_c): Adjust.
3296         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
3297
3298 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
3299
3300         * gdbtypes.c (lookup_array_range_type): Make sure the array's
3301         index type is objfile-owned if the element type is as well.
3302
3303 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
3304
3305         GDB 8.1 released.
3306
3307 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
3308
3309         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
3310         "features/s390x-linux64.c".
3311         (_initialize_s390_linux_tdep): Remove initialization of tdescs
3312         s390_linux32 and s390x_linux64.
3313         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
3314         default tdesc.
3315         * s390-tdep.c: Include "features/s390-linux32.c" and
3316         "features/s390x-linux64.c".
3317         (s390_tdesc_valid): Add check for tdesc_has_registers.
3318         (s390_gdbarch_init): Make sure there is always a valid tdesc.
3319         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
3320         tdesc_s390x_linux64.
3321         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
3322         tdesc_s390x_linux64 to...
3323         * s390-tdep.h: ...here.
3324
3325 2018-01-30  Pedro Alves  <palves@redhat.com>
3326
3327         PR gdb/13211
3328         * config.in, configure: Regenerate.
3329         * configure.ac: Check for getpgid.
3330         * go32-nat.c (go32_pass_ctrlc): New.
3331         (go32_target): Install it.
3332         * inf-child.c (inf_child_target): Install
3333         child_terminal_save_inferior, child_pass_ctrlc and
3334         child_interrupt.
3335         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
3336         (inf_ptrace_target): No longer install it.
3337         * infcmd.c (interrupt_target_1): Adjust.
3338         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
3339         (child_interrupt): Declare.
3340         (inferior::terminal_state): New.
3341         * inflow.c (struct terminal_info): Update comments.
3342         (inferior_process_group): Delete.
3343         (terminal_is_ours): Delete.
3344         (gdb_tty_state): New.
3345         (child_terminal_init): Adjust.
3346         (is_gdb_terminal, sharing_input_terminal_1)
3347         (sharing_input_terminal): New functions.
3348         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
3349         Set the process's actual process group in the foreground if
3350         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
3351         mark terminal as the inferior's if not sharing GDB's terminal.
3352         Don't check attach_flag.
3353         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
3354         pass down a target_terminal_state.
3355         (child_terminal_save_inferior): New, factored out from ...
3356         (child_terminal_ours_1): ... this.  Handle
3357         target_terminal_state::is_ours_for_output.
3358         (child_interrupt, child_pass_ctrlc): New.
3359         (inflow_inferior_exit): Clear the inferior's terminal_state.
3360         (copy_terminal_info): Copy the inferior's terminal state.
3361         (_initialize_inflow): Remove reference to terminal_is_ours.
3362         * inflow.h (inferior_process_group): Delete.
3363         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
3364         * procfs.c (procfs_target): Don't install procfs_interrupt.
3365         (procfs_interrupt): Delete.
3366         * remote.c (remote_serial_quit_handler): Adjust.
3367         (remote_interrupt): Remove ptid parameter.  Adjust.
3368         * target-delegates.c: Regenerate.
3369         * target.c: Include "terminal.h".
3370         (target_terminal::terminal_state): Rename to ...
3371         (target_terminal::m_terminal_state): ... this.
3372         (target_terminal::init): Adjust.
3373         (target_terminal::inferior): Adjust to per-inferior
3374         terminal_state.
3375         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
3376         (target_terminal::ours, target_terminal::ours_for_output): Use
3377         target_terminal_is_ours_kind.
3378         (target_interrupt): Remove ptid parameter.  Adjust.
3379         (default_target_pass_ctrlc): Adjust.
3380         * target.h (target_ops::to_terminal_save_inferior): New field.
3381         (target_ops::to_interrupt): Remove ptid_t parameter.
3382         (target_interrupt): Remove ptid_t parameter.  Update comment.
3383         (target_pass_ctrlc): Update comment.
3384         * target/target.h (target_terminal_state): New scoped enum,
3385         factored out of ...
3386         (target_terminal::terminal_state): ... here.
3387         (target_terminal::inferior): Update comments.
3388         (target_terminal::restore_inferior): New.
3389         (target_terminal::is_inferior, target_terminal::is_ours)
3390         (target_terminal::is_ours_for_output): Adjust.
3391         (target_terminal::scoped_restore_terminal_state): Adjust to
3392         rename, and call restore_inferior() instead of inferior().
3393         (target_terminal::scoped_restore_terminal_state::m_state): Change
3394         type.
3395         (target_terminal::terminal_state): Rename to ...
3396         (target_terminal::m_terminal_state): ... this and change type.
3397
3398 2018-01-30  Pedro Alves  <palves@redhat.com>
3399
3400         * linux-nat.c (wait_for_signal): New function.
3401         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
3402         directly.
3403         (async_terminal_is_ours)
3404         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
3405         (linux_nat_add_target): Don't override
3406         to_terminal_inferior/to_terminal_ours.
3407
3408 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3409
3410         * remote.c (remote_follow_fork): Don't call "detach_inferior".
3411
3412 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
3413
3414         * dwarf2read.c (free_dwo_files): Add forward-declaration.
3415         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
3416         dwarf2_per_objfile_free here.
3417         (dwarf2_per_objfile_free): Remove.
3418         (_initialize_dwarf2_read): Don't register
3419         dwarf2_per_objfile_free as a registry cleanup.
3420
3421 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
3422
3423         Avoid compilation errors in MinGW native builds
3424
3425         The error is triggered by including python-internal.h, and the
3426         error message is:
3427
3428              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
3429                       from build-gnulib/import/math.h:27,
3430                       from d:/usr/Python26/include/pyport.h:235,
3431                       from d:/usr/Python26/include/Python.h:58,
3432                       from python/python-internal.h:94,
3433                       from python/py-arch.c:24:
3434              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
3435         using ::hypot;
3436                 ^~~~~
3437
3438         This happens because Python headers define 'hypot' to expand t
3439         '_hypot' in the Windows builds.
3440         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
3441         'hypoth'.  This avoids a compilation error.
3442
3443 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
3444
3445         * MAINTAINERS (Write After Approval): Fix ordering.
3446
3447 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
3448
3449         * MAINTAINERS (Write After Approval): Add Alan Hayward.
3450
3451 2018-01-26  Alan Modra  <amodra@gmail.com>
3452
3453         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
3454         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
3455         Remove nop.  Make const.  Comment.
3456         (powerpc32_plt_stub_so_2): New.
3457         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
3458         Correct count.  Update uses.
3459         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
3460         Move common code reading PLT entry word.  Correct
3461         powerpc32_plt_stub PLT address calculation.
3462         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
3463         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
3464         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
3465         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
3466         (ppc64_standard_linkage8): Likewise.
3467         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
3468         Correct insns description.
3469         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
3470
3471 2018-01-24  Pedro Alves  <palves@redhat.com>
3472
3473         GCC PR libstdc++/83906
3474         * gdbtypes.c (operator==(const dynamic_prop &,
3475         const dynamic_prop &)): New.
3476         (operator==(const range_bounds &, const range_bounds &)): New.
3477         (check_types_equal): Use them instead of memcmp.
3478         * gdbtypes.h (operator==(const dynamic_prop &,
3479         const dynamic_prop &)): Declare.
3480         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
3481         (operator==(const range_bounds &, const range_bounds &)): Declare.
3482         (operator!=(const range_bounds &, const range_bounds &)): Declare.
3483
3484 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
3485
3486         * s390-linux-tdep.c (s390_record_address_mask)
3487         (s390_record_calc_disp_common, s390_record_calc_disp)
3488         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
3489         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
3490         (s390_process_record): Move to s390-tdep.c.
3491         (s390_linux_init_abi_any): Adjust.
3492         * s390-tdep.c (s390_record_address_mask)
3493         (s390_record_calc_disp_common, s390_record_calc_disp)
3494         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
3495         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
3496         (s390_process_record): Moved from s390-linux-tdep.c
3497         (s390_gdbarch_init): Adjust.
3498
3499 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
3500
3501         * s390-linux-nat.c (s390-tdep.h): New include.
3502         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
3503         (HFILES_NO_SRCDIR): Add s390-tdep.h.
3504         (ALLDEPFILES): Add s390-tdep.c.
3505         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
3506         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
3507         * s390-tdep.h: ...this.  New file.
3508         * s390-linux-tdep.c (s390-tdep.h): New include.
3509         (_initialize_s390_tdep): Rename to...
3510         (_initialize_s390_linux_tdep): ...this and adjust.
3511         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
3512         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
3513         s390-tdep.h.
3514         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
3515         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
3516         (s390_is_partial_instruction, s390_software_single_step)
3517         (is_non_branch_ril, s390_displaced_step_copy_insn)
3518         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
3519         (s390_prologue_data, s390_addr, s390_store, s390_load)
3520         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
3521         (s390_register_call_saved, s390_guess_tracepoint_registers)
3522         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
3523         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
3524         (s390_pseudo_register_name, s390_pseudo_register_type)
3525         (s390_pseudo_register_read, s390_pseudo_register_write)
3526         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
3527         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
3528         (s390_addr_bits_remove, s390_address_class_type_flags)
3529         (s390_address_class_type_flags_to_name)
3530         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
3531         (s390_function_arg_float, s390_function_arg_vector)
3532         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
3533         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
3534         (s390_frame_align, s390_register_return_value, s390_return_value)
3535         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
3536         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
3537         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
3538         (s390_trad_frame_prev_register, s390_unwind_cache)
3539         (s390_prologue_frame_unwind_cache)
3540         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
3541         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
3542         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
3543         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
3544         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
3545         (s390_frame_base_address, s390_local_base_address)
3546         (s390_frame_base, s390_gcc_target_options)
3547         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
3548         (s390_validate_reg_range, s390_tdesc_valid)
3549         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
3550         * s390-tdep.c: ...this.  New file.
3551
3552 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
3553
3554         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
3555         (s390_process_record, s390_gdbarch_tdep_alloc)
3556         (s390_linux_init_abi_any): Use/set new hook.
3557
3558 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
3559
3560         * s390-linux-tdep.c (osabi.h): New include.
3561         (s390_linux_init_abi_31, s390_linux_init_abi_64)
3562         (s390_linux_init_abi_any): New functions.
3563         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
3564
3565 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
3566
3567         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
3568         tdesc_has_registers check
3569
3570 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
3571
3572         * s390-linux-tdep.c (s390_tdesc_valid): New function.
3573         (s390_validate_reg_range): New macro.
3574         (s390_gdbarch_init): Adjust.
3575
3576 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
3577
3578         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
3579         (s390_gdbarch_tdep_alloc): Adjust.
3580         (s390_gdbarch_init): Adjust.
3581
3582 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
3583
3584         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
3585         <have_tdb>: Change type to bool.
3586         (s390_gdbarch_tdep_alloc): Adjust.
3587         (s390_gdbarch_init): Adjust.
3588
3589 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
3590
3591         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
3592         (gdbarch_tdep) <have_upper, have_vx>: New fields.
3593         (s390_gdbarch_tdep_alloc): New function.
3594         (s390_gdbarch_init): Allocate tdep at start and use its fields
3595         instead of separate variables.
3596
3597 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
3598
3599         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
3600         when looking for cached gdbarch and add comment for remaining.
3601
3602 2018-01-22  Pedro Alves  <palves@redhat.com>
3603             Sergio Durigan Junior  <sergiodj@redhat.com>
3604
3605         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
3606         case.
3607
3608 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
3609
3610         * MAINTAINERS: Update my company e-mail address.
3611
3612 2018-01-22  Yao Qi  <yao.qi@linaro.org>
3613
3614         * regcache.c (cooked_write_test): New function.
3615         (_initialize_regcache): Register the test.
3616
3617 2018-01-22  Yao Qi  <yao.qi@linaro.org>
3618
3619         * ia64-tdep.c (ia64_pseudo_register_read): Call
3620         regcache->cooked_read instead of regcache_cooked_read_unsigned.
3621         * m32c-tdep.c (m32c_cat_read): Likewise.
3622         (m32c_r3r2r1r0_read): Likewise.
3623         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
3624         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
3625
3626 2018-01-22  Yao Qi  <yao.qi@linaro.org>
3627
3628         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
3629         method raw_read instead of regcache_raw_read.
3630         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
3631         * arm-tdep.c (arm_neon_quad_read): Likewise.
3632         * avr-tdep.c (avr_pseudo_register_read): Likewise.
3633         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
3634         * frv-tdep.c (frv_pseudo_register_read): Likewise.
3635         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
3636         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
3637         (i386_pseudo_register_read_into_value): Likewise.
3638         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
3639         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
3640         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
3641         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
3642         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
3643         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
3644         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
3645         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
3646         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
3647
3648 2018-01-22  Yao Qi  <yao.qi@linaro.org>
3649
3650         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
3651         * configure.tgt: Remove target mt.
3652         * mt-tdep.c: Remove.
3653         * regcache.c (cooked_read_test): Remove the check for mt.
3654
3655 2018-01-22  Yao Qi  <yao.qi@linaro.org>
3656
3657         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
3658         instead of gdbarch_pseudo_register_read_value.
3659
3660 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
3661
3662         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
3663         language is Ada.
3664
3665 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
3666
3667         * linespec.c (create_sals_line_offset): Remove code that preserved
3668         the symtab_and_line's line number.
3669
3670 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3671
3672         * varobj.c (varobj_create): Don't set valid_block when creating a
3673         floating varobj.
3674
3675 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3676
3677         * varobj.c (varobj_create): Remove out of date comment.
3678
3679 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3680
3681         PR mi/20395
3682         * ada-exp.y (write_var_from_sym): Pass extra parameter when
3683         updating innermost block.
3684         * parse.c (innermost_block_tracker::update): Take extra type
3685         parameter, and check types match before updating innermost block.
3686         (write_dollar_variable): Update innermost block for registers.
3687         * parser-defs.h (enum innermost_block_tracker_type): New enum.
3688         (innermost_block_tracker::innermost_block_tracker): Initialise
3689         m_types member.
3690         (innermost_block_tracker::reset): Take type parameter.
3691         (innermost_block_tracker::update): Take type parameter, and pass
3692         type through as needed.
3693         (innermost_block_tracker::m_types): New member.
3694         * varobj.c (varobj_create): Pass type when reseting innermost
3695         block.
3696
3697 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3698
3699         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
3700         * ada-lang.c (resolve_subexp): Likewise.
3701         * breakpoint.c (set_breakpoint_condition) Likewise.
3702         (watch_command_1) Likewise.
3703         * c-exp.y (variable): Likewise.
3704         * d-exp.y (PrimaryExpression): Likewise.
3705         * f-exp.y (variable): Likewise.
3706         * go-exp.y (variable): Likewise.
3707         * m2-exp.y (variable): Likewise.
3708         * objfiles.c (objfile::~objfile): Likewise.
3709         * p-exp.y (variable): Likewise.
3710         * parse.c (innermost_block): Change type.
3711         * parser-defs.h (class innermost_block_tracker): New.
3712         (innermost_block): Change to innermost_block_tracker.
3713         * printcmd.c (display_command): Switch to innermost_block API.
3714         (do_one_display): Likewise.
3715         * rust-exp.y (do_one_display): Likewise.
3716         * symfile.c (clear_symtab_users): Likewise.
3717         * varobj.c (varobj_create): Switch to innermost_block API, replace
3718         use of innermost_block with block stored on varobj object.
3719
3720 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3721
3722         * expression.h (innermost_block): Remove declaration.
3723         * varobj.c: Add 'parser-defs.h' include.
3724
3725 2018-01-19  Tom Tromey  <tom@tromey.com>
3726
3727         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
3728         symbols in the static and global blocks.
3729
3730 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
3731
3732         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
3733         gdb_ptrace.h, and move including gdb_wait.h ...
3734         * nat/linux-ptrace.h: ... to here.
3735
3736 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
3737
3738         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
3739         inf_ptrace_detach_success.
3740         (inf_ptrace_detach_success): Add inferior parameter, use it
3741         instead of inferior_ptid, pass it to detach_inferior.
3742         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
3743         parameter.
3744         * inferior.c (detach_inferior): Add overload that takes an
3745         inferior object.
3746         * inferior.h (detach_inferior): Likewise.
3747         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
3748         use inferior_ptid, adjust call to inf_ptrace_detach_success.
3749         * linux-thread-db.c (thread_db_detach): Use inf parameter.
3750
3751 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
3752
3753         * target.h (struct target_ops) <to_detach>: Add inferior
3754         parameter.
3755         (target_detach): Likewise.
3756         * target.c (dispose_inferior): Pass inferior down.
3757         (target_detach): Pass inferior down.  Assert that it is equal to
3758         the current inferior.
3759         * aix-thread.c (aix_thread_detach): Pass inferior down.
3760         * corefile.c (core_file_command): Pass current_inferior() down.
3761         * corelow.c (core_detach): Add inferior parameter.
3762         * darwin-nat.c (darwin_detach): Likewise.
3763         * gnu-nat.c (gnu_detach): Likewise.
3764         * inf-ptrace.c (inf_ptrace_detach): Likewise.
3765         * infcmd.c (detach_command): Pass current_inferior() down to
3766         target_detach.
3767         * infrun.c (follow_fork_inferior): Pass parent_inf to
3768         target_detach.
3769         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
3770         target_detach.
3771         * linux-nat.c (linux_nat_detach): Add inferior parameter.
3772         * linux-thread-db.c (thread_db_detach): Likewise.
3773         * nto-procfs.c (procfs_detach): Likewise.
3774         * procfs.c (procfs_detach): Likewise.
3775         * record.c (record_detach): Likewise.
3776         * record.h (struct inferior): Forward-declare.
3777         (record_detach): Add inferior parameter.
3778         * remote-sim.c (gdbsim_detach): Likewise.
3779         * remote.c (remote_detach_1): Likewise.
3780         (remote_detach): Likewise.
3781         (extended_remote_detach): Likewise.
3782         * sol-thread.c (sol_thread_detach): Likewise.
3783         * target-debug.h (target_debug_print_inferior_p): New macro.
3784         * target-delegates.c: Re-generate.
3785         * top.c (kill_or_detach): Pass inferior down to target_detach.
3786         * windows-nat.c (windows_detach): Add inferior parameter.
3787
3788 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
3789
3790         * target.h (struct target_ops) <to_detach>: Remove args
3791         parameter.
3792         (target_detach): Likewise.
3793         * target.c (dispose_inferior): Adjust.
3794         (target_detach): Remove args parameter, adjust.
3795         * aix-thread.c (aix_thread_detach): Adjust.
3796         * corefile.c (core_file_command): Adjust.
3797         * corelow.c (core_detach): Adjust.
3798         * darwin-nat.c (darwin_detach): Adjust.
3799         * gnu-nat.c (gnu_detach): Adjust.
3800         * inf-ptrace.c (inf_ptrace_detach): Adjust.
3801         * infcmd.c (detach_command): Adjust
3802         * infrun.c (follow_fork_inferior): Adjust.
3803         (handle_vfork_child_exec_or_exit): Adjust.
3804         * linux-fork.c (linux_fork_detach): Remove args parameter.
3805         * linux-fork.h (linux_fork_detach): Likewise.
3806         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
3807         * linux-thread-db.c (thread_db_detach): Likewise.
3808         * nto-procfs.c (procfs_detach): Likewise.
3809         * procfs.c (procfs_detach): Likewise.
3810         (do_detach): Remove signo parameter.
3811         * record.c (record_detach): Remove args parameter.
3812         * record.h (record_detach): Likewise.
3813         * remote-sim.c (gdbsim_detach): Likewise.
3814         * remote.c (remote_detach_1): Likewise.
3815         (remote_detach): Likewise.
3816         (extended_remote_detach): Likewise.
3817         * sol-thread.c (sol_thread_detach): Likewise.
3818         * target-delegates.c: Re-generate.
3819         * top.c (struct qt_args) <args>: Remove field.
3820         (kill_or_detach): Don't pass args.
3821         (quit_force): Don't set args.
3822         * windows-nat.c (windows_detach): Remove args parameter.
3823
3824 2018-01-19  Yao Qi  <yao.qi@linaro.org>
3825
3826         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
3827         (arm_linux_init_abi): Install it.
3828
3829 2018-01-19  Yao Qi  <yao.qi@linaro.org>
3830
3831         * osabi.c (gdb_osabi_names): Extend the regexp for
3832         arm-linux-gnueabihf.
3833
3834 2018-01-18  Yao Qi  <yao.qi@linaro.org>
3835
3836         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
3837         m_abbrevs.
3838         (abbrev_table::add_abbrev): Update.
3839         (abbrev_table::lookup_abbrev): Update.
3840
3841 2018-01-18  Yao Qi  <yao.qi@linaro.org>
3842
3843         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
3844
3845 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
3846
3847         * compile/compile.c (compile_to_object): Convert "triplet_rx"
3848         to "std::string".
3849
3850 2018-01-17  Tom Tromey  <tom@tromey.com>
3851
3852         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
3853
3854 2018-01-17  Tom Tromey  <tom@tromey.com>
3855
3856         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
3857         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
3858         (create_array_type_with_stride): Update.
3859         * dwarf2read.c (set_die_type): Update.
3860
3861 2018-01-17  Tom Tromey  <tom@tromey.com>
3862
3863         * dwarf2read.c (delayed_method_info): Remove typedef.
3864         (dwarf2_cu::method_info): Now a std::vector.
3865         (add_to_method_list): Update.
3866         (free_delayed_list): Remove.
3867         (compute_delayed_physnames): Update.
3868         (process_full_comp_unit, process_full_type_unit): Clear the method
3869         list.  Remove cleanups.
3870         (psymtab_include_file_name): Add name_holder parameter.  Use
3871         unique_xmalloc_ptr.
3872         (dwarf_decode_lines): Update.
3873
3874 2018-01-17  Tom Tromey  <tom@tromey.com>
3875             Simon Marchi  <simon.marchi@ericsson.com>
3876
3877         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
3878         (dwarf2_per_objfile::free_cached_comp_units)
3879         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
3880         (init_cutu_and_read_dies_no_follow): Update.
3881         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
3882         (dwarf2_cu::~dwarf2_cu): New.
3883         (free_heap_comp_unit, free_stack_comp_unit): Remove.
3884         (age_cached_comp_units, free_one_cached_comp_unit): Update.
3885
3886 2018-01-17  Tom Tromey  <tom@tromey.com>
3887             Simon Marchi  <simon.marchi@ericsson.com>
3888
3889         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
3890         (struct die_reader_specs) <abbrev_table>: New member.
3891         (struct abbrev_table): Add constructor.
3892         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
3893         <abbrev_obstack>: Now an auto_obstack.
3894         (abbrev_table_up): New typedef.
3895         (init_cu_die_reader): Add abbrev_table parameter.
3896         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
3897         Add result_dwo_abbrev_table.
3898         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
3899         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
3900         Update.
3901         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
3902         parameter.
3903         (skip_children): Update.
3904         (abbrev_table::alloc_abbrev): Rename from
3905         abbrev_table_alloc_abbrev.
3906         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
3907         (abbrev_table::lookup_abbrev): Rename from
3908         abbrev_table_lookup_abbrev.
3909         (abbrev_table_read_table): Return abbrev_table_up.
3910         (abbrev_table_free, abbrev_table_free_cleanup)
3911         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
3912         (load_partial_dies): Update.
3913
3914 2018-01-17  Tom Tromey  <tom@tromey.com>
3915
3916         * dwarf2read.c (dwarf2_compute_name): Update comment.
3917         (read_func_scope, read_variable): Update.
3918         (new_symbol): Remove.
3919         (new_symbol_full): Rename to new_symbol.
3920
3921 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
3922
3923         PR gdb/16577
3924         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
3925         a warning instead of throwing an error, set section size to 0 and return
3926         NULL.
3927         * gdb_bfd.h (gdb_bfd_map_section): Update description.
3928
3929 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
3930
3931         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
3932         std::string.
3933         (linux_ptrace_attach_fail_reason_string): Likewise.
3934         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
3935         Likewise.
3936         (linux_ptrace_attach_fail_reason_string): Likewise.
3937         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
3938
3939 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
3940
3941         * linux-nat.c (linux_nat_attach): Remove xstrdup.
3942
3943 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
3944
3945         PR gdb/21559
3946         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
3947         checking for fs_base/gs_base fields in struct user_regs_struct.
3948         * configure: Regenerate.
3949
3950 2018-01-17  Yao Qi  <yao.qi@linaro.org>
3951
3952         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
3953         function.
3954         (aarch64_linux_init_abi): Install it to gdbarch hook
3955         gcc_target_options.
3956
3957 2018-01-15  Pedro Alves  <palves@redhat.com>
3958
3959         * common/signals-state-save-restore.c
3960         (save_original_signals_state): Fix typos.
3961
3962 2017-01-12  Tom Tromey  <tom@tromey.com>
3963             Sergio Durigan Junior  <sergiodj@redhat.com>
3964
3965         * Makefile.in (install-only): Install gdb-add-index.
3966
3967 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
3968
3969         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
3970
3971 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3972
3973         * infrun.c (keep_going_pass_signal): Clear step-over info when
3974         insert_breakpoints fails.
3975
3976 2018-01-11  Pedro Alves  <palves@redhat.com>
3977
3978         PR gdb/22583
3979         * infrun.c (resume): Rename to ...
3980         (resume_1): ... this.
3981         (resume): Reimplement as wrapper around resume_1.
3982
3983 2018-01-11  Pedro Alves  <palves@redhat.com>
3984
3985         PR remote/22597
3986         * remote.c (remote_parse_stop_reply): Default to the last-set
3987         general thread instead of to 'magic_null_ptid'.
3988
3989 2018-01-10  Pedro Alves  <palves@redhat.com>
3990
3991         * language.h (language_get_symbol_name_matcher): Rename ...
3992         (get_symbol_name_matcher): ... this.
3993         * language.c (language_get_symbol_name_matcher): Ditto.
3994         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
3995         callers adjusted.
3996
3997 2018-01-10  Pedro Alves  <palves@redhat.com>
3998
3999         PR gdb/22670
4000         * dwarf2read.c
4001         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
4002         Adjust to use language_get_symbol_name_matcher instead of
4003         language_defn::la_get_symbol_name_matcher.
4004         * language.c (language_get_symbol_name_matcher): If in Ada mode
4005         and the lookup name is a verbatim match, return Ada's matcher.
4006         * language.h (language_get_symbol_name_matcher): Adjust comment.
4007         (ada_lookup_name_info::verbatim_p):: New method.
4008
4009 2018-01-10  Pedro Alves  <palves@redhat.com>
4010
4011         PR gdb/22670
4012         * ada-lang.c (ada_collect_symbol_completion_matches): If the
4013         minsym's language is language_auto or language_cplus, pass down
4014         language_ada instead.
4015         * symtab.c (compare_symbol_name): Don't frob symbol language here.
4016
4017 2018-01-10  Pedro Alves  <palves@redhat.com>
4018
4019         PR gdb/22670
4020         * minsyms.c (linkage_name_str): New function.
4021         (iterate_over_minimal_symbols): Use it.
4022
4023 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
4024
4025         * NEWS: Document that 'info proc' now works on FreeBSD.
4026
4027 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
4028
4029         * configure.ac: Check for kinfo_getfile in libutil.
4030         * configure: Regenerate.
4031         * config.in: Regenerate.
4032         * fbsd-nat.c: Include "fbsd-tdep.h".
4033         (fbsd_fetch_cmdline): New.
4034         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
4035         rather than calling error.
4036         (fbsd_info_proc): New.
4037         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
4038         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
4039         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
4040
4041 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
4042
4043         * fbsd-nat.c (struct free_deleter): Remove.
4044         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
4045
4046 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
4047
4048         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
4049         NULL for an empty pathname.
4050
4051 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
4052
4053         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
4054         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
4055         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
4056         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
4057         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
4058         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
4059         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
4060         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
4061         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
4062         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
4063         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
4064         (fbsd_core_fetch_timeval, fbsd_print_sigset)
4065         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
4066         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
4067         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
4068
4069 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
4070
4071         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
4072         (gnu_xfer_auxv): New function.
4073         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
4074         TARGET_OBJECT_AUXV.
4075
4076 2018-01-08  Yao Qi  <yao.qi@linaro.org>
4077             Simon Marchi  <simon.marchi@ericsson.com>
4078
4079         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
4080         common/selftest.c.
4081         (COMMON_OBS): Remove selftest.o.
4082         * configure.ac: Append selftest-arch.c and common/selftest.c to
4083         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
4084         * configure: Re-generated.
4085         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
4086         GDB_SELF_TEST.
4087         (maintenance_info_selftests): Likewise.
4088
4089 2018-01-08  Xavier Roirand  <roirand@adacore.com>
4090
4091         * ada-valprint.c (val_print_packed_array_elements): Use
4092         proper number of elements when printing an array indexed
4093         by an enumeration type.
4094
4095 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
4096
4097         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
4098         (dw2_get_file_names_reader): Adjust.
4099         (lookup_dwo_signatured_type): Adjust.
4100         (lookup_dwp_signatured_type): Adjust.
4101         (lookup_signatured_type): Adjust.
4102         (create_type_unit_group): Adjust.
4103         (get_type_unit_group): Adjust.
4104         (process_psymtab_comp_unit_reader): Adjust.
4105         (build_type_psymtabs_reader): Adjust.
4106         (scan_partial_symbols): Adjust.
4107         (add_partial_symbol): Adjust.
4108         (add_partial_subprogram): Adjust.
4109         (peek_die_abbrev): Adjust.
4110         (fixup_go_packaging): Adjust.
4111         (process_imported_unit_die): Adjust.
4112         (dwarf2_compute_name): Adjust.
4113         (dwarf2_physname): Adjust.
4114         (read_import_statement): Adjust.
4115         (handle_DW_AT_stmt_list): Adjust.
4116         (read_file_scope): Adjust.
4117         (read_func_scope): Adjust.
4118         (read_lexical_block_scope): Adjust.
4119         (read_call_site_scope): Adjust.
4120         (read_variable): Adjust.
4121         (dwarf2_rnglists_process): Adjust.
4122         (dwarf2_ranges_process): Adjust.
4123         (dwarf2_ranges_read): Adjust.
4124         (dwarf2_get_pc_bounds): Adjust.
4125         (dwarf2_record_block_ranges): Adjust.
4126         (dwarf2_add_field): Adjust.
4127         (dwarf2_add_member_fn): Adjust.
4128         (read_structure_type): Adjust.
4129         (process_structure_scope): Adjust.
4130         (read_enumeration_type): Adjust.
4131         (read_array_type): Adjust.
4132         (mark_common_block_symbol_computed): Adjust.
4133         (read_common_block): Adjust.
4134         (read_namespace_type): Adjust.
4135         (read_namespace): Adjust.
4136         (read_module_type): Adjust.
4137         (read_tag_pointer_type): Adjust.
4138         (read_tag_ptr_to_member_type): Adjust.
4139         (read_tag_string_type): Adjust.
4140         (read_subroutine_type): Adjust.
4141         (read_typedef): Adjust.
4142         (read_base_type): Adjust.
4143         (attr_to_dynamic_prop): Adjust.
4144         (read_subrange_type): Adjust.
4145         (read_unspecified_type): Adjust.
4146         (dwarf2_read_abbrevs): Adjust.
4147         (load_partial_dies): Adjust.
4148         (read_partial_die): Adjust.
4149         (find_partial_die): Adjust.
4150         (guess_partial_die_structure_name): Adjust.
4151         (fixup_partial_die): Adjust.
4152         (read_attribute_value): Adjust.
4153         (read_addr_index): Adjust.
4154         (read_addr_index_from_leb128): Adjust.
4155         (read_str_index): Adjust.
4156         (dwarf2_string_attr): Adjust.
4157         (get_debug_line_section): Adjust.
4158         (dwarf_decode_line_header): Adjust.
4159         (lnp_state_machine::check_line_address): Adjust.
4160         (dwarf_decode_lines_1): Adjust.
4161         (dwarf_decode_lines): Adjust.
4162         (dwarf2_start_symtab): Adjust.
4163         (var_decode_location): Adjust.
4164         (new_symbol_full): Adjust.
4165         (dwarf2_const_value_data): Adjust.
4166         (dwarf2_const_value_attr): Adjust.
4167         (dwarf2_const_value): Adjust.
4168         (die_type): Adjust.
4169         (die_containing_type): Adjust.
4170         (build_error_marker_type): Adjust.
4171         (lookup_die_type): Adjust.
4172         (guess_full_die_structure_name): Adjust.
4173         (anonymous_struct_prefix): Adjust.
4174         (determine_prefix): Adjust.
4175         (dwarf2_name): Adjust.
4176         (follow_die_ref_or_sig): Adjust.
4177         (follow_die_offset): Adjust.
4178         (follow_die_ref): Adjust.
4179         (follow_die_sig_1): Adjust.
4180         (follow_die_sig): Adjust.
4181         (get_signatured_type): Adjust.
4182         (get_DW_AT_signature_type): Adjust.
4183         (decode_locdesc): Adjust.
4184         (dwarf_decode_macros): Adjust.
4185         (cu_debug_loc_section): Adjust.
4186         (fill_in_loclist_baton): Adjust.
4187         (dwarf2_symbol_mark_computed): Adjust.
4188         (init_one_comp_unit): Don't assign
4189         dwarf2_cu::dwarf2_per_objfile.
4190         (set_die_type): Adjust.
4191
4192 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
4193
4194         * dwarf2read.c (struct mapped_debug_names): Add constructor.
4195         <dwarf2_per_objfile>: New field.
4196         (dwarf2_per_objfile): Remove global.
4197         (get_dwarf2_per_objfile): New function.
4198         (set_dwarf2_per_objfile): New function.
4199         (dwarf2_build_psymtabs_hard): Change objfile parameter to
4200         dwarf2_per_objfile.
4201         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
4202         (read_abbrev_offset): Likewise.
4203         (read_indirect_string): Likewise.
4204         (read_indirect_line_string): Likewise.
4205         (read_indirect_string_at_offset): Likewise.
4206         (read_indirect_string_from_dwz): Likewise.
4207         (dwarf2_find_containing_comp_unit): Change objfile parameter to
4208         dwarf2_per_objfile.
4209         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
4210         (create_all_comp_units): Change objfile parameter to
4211         dwarf2_per_objfile.
4212         (create_all_type_units): Likewise.
4213         (process_queue): Add dwarf2_per_objfile parameter.
4214         (read_and_check_comp_unit_head): Likewise.
4215         (lookup_dwo_unit_in_dwp): Likewise.
4216         (get_dwp_file): Likewise.
4217         (process_cu_includes): Likewise.
4218         (struct free_dwo_file_cleanup_data): New struct.
4219         (dwarf2_has_info): Use get_dwarf2_per_objfile and
4220         set_dwarf2_per_objfile.
4221         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
4222         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
4223         context, adjust calls.
4224         (dw2_instantiate_symtab): Likewise.
4225         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
4226         (dw2_get_cu): Likewise.
4227         (create_cu_from_index_list): Change objfile parameter to
4228         dwarf2_per_objfile.
4229         (create_cus_from_index_list): Get dwarf2_per_objfile from
4230         context, adjust calls.
4231         (create_cus_from_index): Likewise.
4232         (create_signatured_type_table_from_index): Change objfile
4233         parameter to dwarf2_per_objfile.
4234         (create_signatured_type_table_from_debug_names): Change objfile
4235         parameter to dwarf2_per_objfile.
4236         (create_addrmap_from_index): Likewise.
4237         (create_addrmap_from_aranges): Likewise.
4238         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
4239         (dw2_setup): Remove.
4240         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
4241         context.
4242         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
4243         get_dwarf2_per_objfile.
4244         (dw2_forget_cached_source_info): Likewise.
4245         (dw2_map_symtabs_matching_filename): Likewise.
4246         (struct dw2_symtab_iterator) <index>: Remove.
4247         <dwarf2_per_objfile>: New field.
4248         (dw2_symtab_iter_init): Replace index parameter with
4249         dwarf2_per_objfile.
4250         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
4251         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
4252         (dw2_print_stats): Likewise.
4253         (dw2_dump): Likewise.
4254         (dw2_expand_symtabs_for_function): Likewise.
4255         (dw2_expand_all_symtabs): Likewise.
4256         (dw2_expand_symtabs_with_fullname): Likewise.
4257         (dw2_expand_marked_cus): Replace index and objfile parameters
4258         with dwarf2_per_objfile.
4259         (dw_expand_symtabs_matching_file_matcher): Add
4260         dwarf2_per_objfile parameter and adjust calls.
4261         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
4262         adjust calls.
4263         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
4264         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
4265         adjust calls.
4266         (create_cus_from_debug_names_list): Replace objfile parameter
4267         with dwarf2_per_objfile and adjust calls.
4268         (create_cus_from_debug_names): Likewise.
4269         (dwarf2_read_debug_names): Likewise.
4270         (mapped_debug_names::namei_to_name): Adjust call.
4271         (dw2_debug_names_iterator::next): Likewise.
4272         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
4273         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
4274         (dw2_debug_names_dump): Likewise.
4275         (dw2_debug_names_expand_symtabs_for_function): Likewise.
4276         (dw2_debug_names_expand_symtabs_matching): Likewise.
4277         (dwarf2_initialize_objfile): Likewise.
4278         (dwarf2_build_psymtabs): Likewise.
4279         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
4280         this_cu.
4281         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
4282         (read_and_check_comp_unit_head): Likewise.
4283         (read_abbrev_offset): Likewise.
4284         (create_debug_type_hash_table): Likewise.
4285         (create_debug_types_hash_table): Likewise.
4286         (create_all_type_units): Replace objfile parameter with
4287         dwarf2_per_objfile.
4288         (add_type_unit): Add dwarf2_per_objfile parameter.
4289         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
4290         with dwarf2_per_objfile.
4291         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
4292         (lookup_dwp_signatured_type): Likewise.
4293         (lookup_signatured_type): Likewise.
4294         (read_cutu_die_from_dwo): Likewise.
4295         (init_tu_and_read_dwo_dies): Likewise.
4296         (init_cutu_and_read_dies): Likewise.
4297         (init_cutu_and_read_dies_no_follow): Likewise.
4298         (allocate_type_unit_groups_table): Add objfile parameter.
4299         (create_type_unit_group): Use dwarf2_per_objfile from cu.
4300         (get_type_unit_group): Likewise.
4301         (process_psymtab_comp_unit): Update call.
4302         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
4303         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
4304         (print_tu_stats): Likewise.
4305         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
4306         in void* parameter.
4307         (build_type_psymtabs): Change objfile parameter to
4308         dwarf2_per_objfile.
4309         (process_skeletonless_type_unit): Use dwarf2_per_objfile
4310         passed in void* parameter.
4311         (process_skeletonless_type_units): Change objfile parameter to
4312         dwarf2_per_objfile.
4313         (set_partial_user): Likewise.
4314         (dwarf2_build_psymtabs_hard): Likewise.
4315         (read_comp_units_from_section): Likewise.
4316         (create_all_comp_units): Likewise.
4317         (scan_partial_symbols): Update calls.
4318         (add_partial_symbol): Likewise.
4319         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
4320         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
4321         (process_queue): Add dwarf2_per_objfile parameter.
4322         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
4323         (compute_compunit_symtab_includes): Likewise.
4324         (process_cu_includes): Add dwarf2_per_objfile parameter.
4325         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
4326         (process_full_type_unit): Likewise.
4327         (process_imported_unit_die): Update call.
4328         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
4329         (read_file_scope): Likewise.
4330         (allocate_dwo_file_hash_table): Add objfile parameter.
4331         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
4332         (create_cus_hash_table): Likewise.
4333         (create_dwp_hash_table): Likewise.
4334         (create_dwo_unit_in_dwp_v1): Likewise.
4335         (create_dwp_v2_section): Likewise.
4336         (create_dwo_unit_in_dwp_v2): Likewise.
4337         (lookup_dwo_unit_in_dwp): Likewise.
4338         (try_open_dwop_file): Likewise.
4339         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
4340         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
4341         cleanup to include a reference to dwarf2_per_objfile.
4342         (open_dwp_file): Add dwarf2_per_objfile parameter.
4343         (open_and_init_dwp_file): Likewise.
4344         (get_dwp_file): Likewise.
4345         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
4346         (queue_and_load_all_dwo_tus): Update call.
4347         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
4348         data.
4349         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
4350         (dwarf2_ranges_process): Likewise.
4351         (dwarf2_get_pc_bounds): Likewise.
4352         (mark_common_block_symbol_computed): Likewise.
4353         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
4354         (dwarf2_read_abbrevs): Update call.
4355         (read_partial_die): Use dwarf2_per_objfile from cu.
4356         (find_partial_die): Likewise.
4357         (fixup_partial_die): Likewise.
4358         (read_attribute_value): Likewise.
4359         (read_indirect_string_at_offset_from): Add objfile parameter.
4360         (read_indirect_string_at_offset): Add dwarf2_per_objfile
4361         parameter.
4362         (read_indirect_string_from_dwz): Add objfile parameter.
4363         (read_indirect_string): Add objfile parameter.
4364         (read_addr_index_1): Add dwarf2_per_objfile parameter.
4365         (read_addr_index): Use dwarf2_per_objfile from cu.
4366         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
4367         call dw2_setup.
4368         (read_str_index): Use dwarf2_per_objfile from cu.
4369         (get_debug_line_section): Likewise.
4370         (read_formatted_entries): Add dwarf2_per_objfile parameter.
4371         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
4372         (new_symbol_full): Use dwarf2_per_objfile from cu.
4373         (build_error_marker_type): Likewise.
4374         (lookup_die_type): Likewise.
4375         (determine_prefix): Likewise.
4376         (follow_die_offset): Likewise.
4377         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
4378         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
4379         (dwarf2_fetch_die_type_sect_off): Likewise.
4380         (dwarf2_get_die_type): Likewise.
4381         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
4382         (get_signatured_type): Likewise.
4383         (get_DW_AT_signature_type): Likewise.
4384         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
4385         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
4386         (cu_debug_loc_section): Likewise.
4387         (fill_in_loclist_baton): Likewise.
4388         (dwarf2_symbol_mark_computed): Likewise.
4389         (dwarf2_find_containing_comp_unit): Change objfile parameter to
4390         dwarf2_per_objfile.
4391         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
4392         parameter.
4393         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
4394         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
4395         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
4396         (set_die_type): Use dwarf2_free_objfile from cu.
4397         (get_die_type_at_offset): Likewise.
4398         (dwarf2_per_objfile_free): Don't assign global variable.
4399         (debug_names) <constructor>: Add dwarf2_per_objfile
4400         parameter, update m_debugstrlookup construction.
4401         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
4402         parameter.
4403         <m_dwarf2_per_objfile>: New field.
4404         <lookup>: Use m_dwarf2_per_objfile.
4405         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
4406         (psyms_seen_size): Likewise.
4407         (write_gdbindex): Replace objfile parameter with
4408         dwarf2_per_objfile.
4409         (write_debug_names): Likewise.
4410         (write_psymtabs_to_index): Likewise.
4411         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
4412         calls.
4413
4414 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
4415
4416         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
4417         <dwarf2_per_objfile>: New field.
4418         (struct dwarf2_per_cu_data) <objfile>: Remove.
4419         <dwarf2_per_objfile>: New field.
4420         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
4421         of objfile.
4422         (create_signatured_type_table_from_index): Likewise.
4423         (create_debug_type_hash_table): Likewise.
4424         (fill_in_sig_entry_from_dwo_entry): Likewise.
4425         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
4426         (create_type_unit_group): Assign dwarf2_per_objfile instead of
4427         objfile.
4428         (create_partial_symtab): Access objfile through
4429         dwarf2_per_objfile.
4430         (process_psymtab_comp_unit_reader): Likewise.
4431         (read_comp_units_from_section): Likewise.
4432         (scan_partial_symbols): Likewise.
4433         (add_partial_symbol): Likewise.
4434         (add_partial_subprogram): Likewise.
4435         (peek_die_abbrev): Likewise.
4436         (fixup_go_packaging): Likewise.
4437         (process_full_comp_unit): Likewise.
4438         (process_full_type_unit): Likewise.
4439         (process_imported_unit_die): Likewise.
4440         (dwarf2_compute_name): Likewise.
4441         (dwarf2_physname): Likewise.
4442         (read_import_statement): Likewise.
4443         (create_cus_hash_table): Assign dwarf2_physname instead of
4444         objfile.
4445         (read_func_scope): Access objfile through dwarf2_per_objfile.
4446         (read_lexical_block_scope): Likewise.
4447         (read_call_site_scope): Likewise.
4448         (read_variable): Likewise.
4449         (dwarf2_rnglists_process): Likewise.
4450         (dwarf2_ranges_process): Likewise.
4451         (dwarf2_ranges_read): Likewise.
4452         (dwarf2_record_block_ranges): Likewise.
4453         (dwarf2_add_field): Likewise.
4454         (dwarf2_add_member_fn): Likewise.
4455         (read_structure_type): Likewise.
4456         (process_structure_scope): Likewise.
4457         (read_enumeration_type): Likewise.
4458         (read_array_type): Likewise.
4459         (read_common_block): Likewise.
4460         (read_namespace_type): Likewise.
4461         (read_namespace): Likewise.
4462         (read_module_type): Likewise.
4463         (read_tag_pointer_type): Likewise.
4464         (read_tag_ptr_to_member_type): Likewise.
4465         (read_tag_string_type): Likewise.
4466         (read_subroutine_type): Likewise.
4467         (read_typedef): Likewise.
4468         (read_base_type): Likewise.
4469         (attr_to_dynamic_prop): Likewise.
4470         (read_subrange_type): Likewise.
4471         (read_unspecified_type): Likewise.
4472         (load_partial_dies): Likewise.
4473         (read_partial_die): Likewise.
4474         (find_partial_die): Likewise.
4475         (guess_partial_die_structure_name): Likewise.
4476         (fixup_partial_die): Likewise.
4477         (read_attribute_value): Likewise.
4478         (read_addr_index_from_leb128): Likewise.
4479         (dwarf2_read_addr_index): Likewise.
4480         (dwarf2_string_attr): Likewise.
4481         (lnp_state_machine::check_line_address): Likewise.
4482         (dwarf_decode_lines_1): Likewise.
4483         (dwarf_decode_lines): Likewise.
4484         (dwarf2_start_symtab): Likewise.
4485         (var_decode_location): Likewise.
4486         (new_symbol_full): Likewise.
4487         (dwarf2_const_value_data): Likewise.
4488         (dwarf2_const_value_attr): Likewise.
4489         (dwarf2_const_value): Likewise.
4490         (die_type): Likewise.
4491         (die_containing_type): Likewise.
4492         (lookup_die_type): Likewise.
4493         (guess_full_die_structure_name): Likewise.
4494         (anonymous_struct_prefix): Likewise.
4495         (dwarf2_name): Likewise.
4496         (follow_die_ref_or_sig): Likewise.
4497         (follow_die_offset): Likewise.
4498         (follow_die_ref): Likewise.
4499         (dwarf2_fetch_die_loc_sect_off): Likewise.
4500         (dwarf2_fetch_constant_bytes): Likewise.
4501         (dwarf2_fetch_die_type_sect_off): Likewise.
4502         (dwarf2_get_die_type): Likewise.
4503         (follow_die_sig): Likewise.
4504         (decode_locdesc): Likewise.
4505         (dwarf2_per_cu_objfile): Likewise.
4506         (dwarf2_per_cu_text_offset): Likewise.
4507         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
4508         objfile.
4509         (set_die_type): Access objfile through
4510         dwarf2_per_objfile.
4511
4512 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
4513
4514         * valprint.c (converted_character_d): Remove typedef.
4515         (DEF_VEC_O (converted_character_d)): Remove.
4516         (count_next_character): Use std::vector.
4517         (print_converted_chars_to_obstack): Likewise.
4518         (generic_printstr): Likewise.
4519
4520 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
4521
4522         * xml-support.h (struct gdb_xml_value): Add constructor.
4523         <value>: Change type to unique_xmalloc_ptr.
4524         (gdb_xml_value_s): Remove typedef.
4525         (DEF_VEC_O (gdb_xml_value_s)): Remove.
4526         (gdb_xml_element_start_handler): Change parameter type to
4527         std::vector.
4528         (xml_find_attribute): Likewise.
4529         * xml-support.c (xml_find_attribute): Change parameter type to
4530         std::vector and adjust.
4531         (gdb_xml_values_cleanup): Remove.
4532         (gdb_xml_parser::start_element): Adjust to std::vector.
4533         (xinclude_start_include): Change paraeter type to std::vector
4534         and adjust.
4535         * btrace.c (check_xml_btrace_version): Likewise.
4536         (parse_xml_btrace_block): Likewise.
4537         (parse_xml_btrace_pt_config_cpu): Likewise.
4538         (parse_xml_btrace_pt): Likewise.
4539         (parse_xml_btrace_conf_bts): Likewise.
4540         (parse_xml_btrace_conf_pt): Likewise.
4541         * memory-map.c (memory_map_start_memory): Likewise.
4542         (memory_map_start_property): Likewise.
4543         * osdata.c (osdata_start_osdata): Likewise.
4544         (osdata_start_item): Likewise.
4545         (osdata_start_column): Likewise.
4546         * remote.c (start_thread): Likewise.
4547         * solib-aix.c (library_list_start_library): Likewise.
4548         (library_list_start_list): Likewise.
4549         * solib-svr4.c (library_list_start_library): Likewise.
4550         (svr4_library_list_start_list): Likewise.
4551         * solib-target.c (library_list_start_segment): Likewise.
4552         (library_list_start_section): Likewise.
4553         (library_list_start_library): Likewise.
4554         (library_list_start_list): Likewise.
4555         * tracepoint.c (traceframe_info_start_memory): Likewise.
4556         (traceframe_info_start_tvar): Likewise.
4557         * xml-syscall.c (syscall_start_syscall): Likewise.
4558         * xml-tdesc.c (tdesc_start_target): Likewise.
4559         (tdesc_start_feature): Likewise.
4560         (tdesc_start_reg): Likewise.
4561         (tdesc_start_union): Likewise.
4562         (tdesc_start_struct): Likewise.
4563         (tdesc_start_flags): Likewise.
4564         (tdesc_start_enum): Likewise.
4565         (tdesc_start_field): Likewise.
4566         (tdesc_start_enum_value): Likewise.
4567         (tdesc_start_vector): Likewise.
4568
4569 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
4570
4571         * extension.h (struct xmethod_worker) <clone>: Remove.
4572         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
4573         Remove.
4574         (python_xmethod_worker::clone): Remove.
4575         * valops.c (find_overload_match): Use std::move instead of
4576         clone.
4577
4578 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
4579
4580         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
4581         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
4582         <free_xmethod_worker_data>: Remove.
4583         <get_matching_xmethod_workers>: Chance VEC to std::vector.
4584         <get_xmethod_arg_types>: Remove.
4585         <get_xmethod_result_type>: Remove.
4586         <invoke_xmethod>: Remove.
4587         * extension.c (new_xmethod_worker): Remove.
4588         (clone_xmethod_worker): Remove.
4589         (get_matching_xmethod_workers): Return void, pass std::vector by
4590         pointer.
4591         (get_xmethod_arg_types): Rename to...
4592         (xmethod_worker::get_arg_types): ... this, and adjust.
4593         (get_xmethod_result_type): Rename to...
4594         (xmethod_worker::get_result_type): ... this, and adjust.
4595         (invoke_xmethod): Remove.
4596         (free_xmethod_worker): Remove.
4597         (free_xmethod_worker_vec): Remove.
4598         * extension.h (enum ext_lang_rc): Move here from
4599         extension-priv.h.
4600         (struct xmethod_worker): Add constructor and destructor.
4601         <data>: Remove.
4602         <value>: Remove.
4603         <invoke, clone, do_get_result_type, do_get_arg_types>: New
4604         virtual pure methods.
4605         <get_arg_types, get_result_type>: New methods.
4606         (xmethod_worker_ptr): Remove typedef.
4607         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
4608         (xmethod_worker_vec): Remove typedef.
4609         (xmethod_worker_up): New typedef.
4610         (invoke_xmethod): Remove.
4611         (clone_xmethod_worker): Remove.
4612         (free_xmethod_worker): Remove.
4613         (free_xmethod_worker_vec): Remove.
4614         (get_xmethod_arg_types): Remove.
4615         (get_xmethod_result_type): Remove.
4616         * valops.c (find_method_list): Use std::vector, don't use
4617         intermediate vector.
4618         (value_find_oload_method_list): Use std::vector.
4619         (find_overload_match): Use std::vector.
4620         (find_oload_champ): Use std::vector.
4621         * value.c (value_free): Use operator delete.
4622         (value_of_xmethod): Rename to...
4623         (value_from_xmethod): ... this.  Don't assign
4624         xmethod_worker::value, take rvalue-reference.
4625         (result_type_of_xmethod): Adjust.
4626         (call_xmethod): Adjust.
4627         * value.h: Include extension.h.
4628         (struct xmethod_worker): Don't forward-declare.
4629         (value_of_xmethod): Rename to...
4630         (value_from_xmethod): ... this, take rvalue-reference.
4631         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
4632         (struct python_xmethod_worker): ... this, add constructor and
4633         destructor.
4634         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
4635         (gdbpy_free_xmethod_worker_data): Rename to...
4636         (python_xmethod_worker::~python_xmethod_worker): ... this and
4637         adjust.
4638         (gdbpy_clone_xmethod_worker_data): Rename to...
4639         (python_xmethod_worker::clone): ... this and adjust.
4640         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
4641         temporary vector.
4642         (gdbpy_get_xmethod_arg_types): Rename to...
4643         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
4644         (gdbpy_get_xmethod_result_type): Rename to...
4645         (python_xmethod_worker::do_get_result_type): ... this and
4646         adjust.
4647         (gdbpy_invoke_xmethod): Rename to...
4648         (python_xmethod_worker::invoke): ... this and adjust.
4649         (new_python_xmethod_worker): Rename to...
4650         (python_xmethod_worker::python_xmethod_worker): ... this and
4651         adjust.
4652         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
4653         Remove.
4654         (gdbpy_free_xmethod_worker_data): Remove.
4655         (gdbpy_get_matching_xmethod_workers): Use std::vector.
4656         (gdbpy_get_xmethod_arg_types): Remove.
4657         (gdbpy_get_xmethod_result_type): Remove.
4658         (gdbpy_invoke_xmethod): Remove.
4659         * python/python.c (python_extension_ops): Remove obsolete
4660         callbacks.
4661
4662 2018-01-05  Pedro Alves  <palves@redhat.com>
4663
4664         PR gdb/18653
4665         * common/signals-state-save-restore.c
4666         (save_original_signals_state): New parameter 'quiet'.  Warn if we
4667         find a custom handler preinstalled, instead of internal erroring.
4668         But only warn if !quiet.
4669         * common/signals-state-save-restore.h
4670         (save_original_signals_state): New parameter 'quiet'.
4671         * main.c (captured_main_1): Move save_original_signals_state call
4672         after option handling, and pass QUIET.
4673
4674 2018-01-05  Pedro Alves  <palves@redhat.com>
4675
4676         * spu-tdep.c (spu_catch_start): Pass
4677         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
4678
4679 2018-01-05  Pedro Alves  <palves@redhat.com>
4680
4681         PR gdb/22670
4682         * ada-lang.c (literal_symbol_name_matcher): New function.
4683         (ada_get_symbol_name_matcher): Use it for
4684         symbol_name_match_type::SEARCH_NAME.
4685         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
4686         it down instead of assuming symbol_name_match_type::FULL.
4687         * block.h (block_lookup_symbol): New parameter 'match_type'.
4688         * c-valprint.c (print_unpacked_pointer): Use
4689         lookup_symbol_search_name instead of lookup_symbol.
4690         * compile/compile-object-load.c (get_out_value_type): Pass down
4691         symbol_name_match_type::SEARCH_NAME.
4692         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
4693         symbol_name_match_type::FULL.
4694         * cp-support.c (cp_get_symbol_name_matcher): Handle
4695         symbol_name_match_type::SEARCH_NAME.
4696         * infrun.c (insert_exception_resume_breakpoint): Use
4697         lookup_symbol_search_name.
4698         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
4699         * psymtab.c (maintenance_check_psymtabs): Use
4700         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
4701         * stack.c (print_frame_args): Use lookup_symbol_search_name and
4702         SYMBOL_SEARCH_NAME.
4703         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
4704         if symbol_name_match_type::SEARCH_NAME.
4705         (lookup_symbol_in_language): Pass down
4706         symbol_name_match_type::FULL.
4707         (lookup_symbol_search_name): New.
4708         (lookup_language_this): Pass down
4709         symbol_name_match_type::SEARCH_NAME.
4710         (lookup_symbol_aux, lookup_local_symbol): New parameter
4711         'match_type'.  Pass it down.
4712         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
4713         (lookup_symbol_search_name): New declaration.
4714         (lookup_symbol_in_block): New 'match_type' parameter.
4715
4716 2018-01-05  Pedro Alves  <palves@redhat.com>
4717
4718         PR gdb/22670
4719         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
4720         ada_lookup_symbol.
4721         (ada_lookup_symbol): Reimplement in terms of
4722         ada_lookup_symbol_list, bits factored out from
4723         ada_lookup_encoded_symbol.
4724
4725 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
4726
4727         * ada-exp.y (write_object_renaming): When subscripting an array
4728         using a symbol as the index, pass the block in call to
4729         ada_lookup_encoded_symbol when looking that symbol up.
4730
4731 2018-01-05  Jerome Guitton  <guitton@adacore.com>
4732
4733         * ada-lang.c (ada_array_length): Use ada_index_type instead of
4734         TYPE_INDEX_TYPE.
4735
4736 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
4737
4738         * ada-lang.c (ada_to_fixed_value_create): Add handling of
4739         the case where VALUE_LVAL (val0) is not lval_memory.
4740
4741 2018-01-05  Xavier Roirand  <roirand@adacore.com>
4742
4743         * ada-valprint.c (print_optional_low_bound): Handle
4744         character-indexed array printing like boolean-indexed array
4745         printing.
4746
4747 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
4748
4749         * NEWS: Create a new section for the next release branch.
4750         Rename the section of the current branch, now that it has
4751         been cut.
4752
4753 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
4754
4755         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
4756         * version.in: Bump version to 8.1.50.DATE-git.
4757
4758 2018-01-03  Xavier Roirand  <roirand@adacore.com>
4759
4760         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
4761         Add field.
4762         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
4763         Add field.
4764         (default_exception_support_info) <catch_handlers_sym>: Add field.
4765         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
4766         (ada_exception_name_addr_1): Add "catch handlers" handling.
4767         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
4768         Update all callers.
4769         (create_excep_cond_exprs) <ex>: Add parameter.
4770         (re_set_exception): Update create_excep_cond_exprs call.
4771         (print_it_exception, print_one_exception, print_mention_exception)
4772         (print_recreate_exception): Add "catch handler" handling.
4773         (allocate_location_catch_handlers, re_set_catch_handlers)
4774         (check_status_catch_handlers, print_it_catch_handlers)
4775         (print_one_catch_handlers, print_mention_catch_handlers)
4776         (print_recreate_catch_handlers): New function.
4777         (catch_handlers_breakpoint_ops): New variable.
4778         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
4779         Add parameter.  Add "catch handler" handling.
4780         (ada_exception_sym_name, ada_exception_breakpoint_ops):
4781         Add "catch handler" handling.
4782         (ada_exception_catchpoint_cond_string): Add "catch handler"
4783         handling.
4784         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
4785         call.
4786         (catch_ada_handlers_command): New function.
4787         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
4788         operations structure.
4789         (_initialize_ada_language): Add "catch handlers" command entry.
4790         * NEWS: Document "catch handlers" feature.
4791
4792 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
4793
4794         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
4795         account when creating the array type of the slice.
4796         (ada_value_slice): Likewise.
4797
4798 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
4799
4800         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
4801         New enum value.
4802         (create_array_type_with_stride): Add byte_stride_prop parameter.
4803         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
4804         New parameter.  Update all callers in this file.
4805         (array_type_has_dynamic_stride): New function.
4806         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
4807         of arrays with dynamic byte strides.
4808         * dwarf2read.c (read_array_type): Add support for dynamic
4809         DW_AT_byte_stride attributes.
4810
4811 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
4812
4813         * dwarf2read.c (read_unspecified_type): Treat
4814         DW_TAG_enumeration_type DIEs from Ada units as stubs.
4815
4816 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
4817
4818         Update copyright year range in all GDB files.
4819
4820 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
4821
4822         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
4823         and gdb/testsuite/gdb.base/step-line.c.
4824
4825 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
4826
4827         * copyright.py (main): Dump the contents of
4828         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
4829         even if BY_HAND is empty.
4830
4831 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
4832
4833         * top.c (print_gdb_version): Update Copyright year in version
4834         message.
4835
4836 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
4837
4838         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
4839
4840 For older changes see ChangeLog-2017.
4841 \f
4842 Local Variables:
4843 mode: change-log
4844 left-margin: 8
4845 fill-column: 74
4846 version-control: never
4847 coding: utf-8
4848 End: