gdb/ChangeLog

   1 2019-07-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * solib-spu.c (ocl_program_data_key): Change type.
   4         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
   5         Update.
   6
   7 2019-07-10  Tom Tromey  <tromey@adacore.com>
   8
   9         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
  10         (struct solib_aix_inferior_data) <library_list>: Change type.
  11         (solib_aix_inferior_data_handle): Change type.
  12         (get_solib_aix_inferior_data): Update.
  13         (solib_aix_free_library_list): Remove.
  14         (library_list_start_library): Update.
  15         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
  16         return type.
  17         (solib_aix_get_library_list)
  18         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
  19         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
  20
  21 2019-07-10  Tom Tromey  <tromey@adacore.com>
  22
  23         * solib-dsbt.c (struct dsbt_info): Add initializers.
  24         (solib_dsbt_pspace_data): Change type.
  25         (dsbt_pspace_data_cleanup): Remove.
  26         (get_dsbt_info, _initialize_dsbt_solib): Update.
  27
  28 2019-07-10  Tom Tromey  <tromey@adacore.com>
  29
  30         * spu-tdep.c (spu_overlay_data): Change type.
  31         (spu_get_overlay_table, spu_overlay_new_objfile)
  32         (_initialize_spu_tdep): Update.
  33
  34 2019-07-10  Tom Tromey  <tromey@adacore.com>
  35
  36         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
  37         destructor.
  38         (dbx_objfile_data_key): Change type and declare later.
  39         (DBX_SYMFILE_INFO): Rewrite.
  40         * dbxread.c (dbx_objfile_data_key): Change type.
  41         (dbx_symfile_init): Update.
  42         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
  43         (coffstab_build_psymtabs, elfstab_build_psymtabs)
  44         (stabsect_build_psymtabs, _initialize_dbxread): Update.
  45
  46 2019-07-10  Tom Tromey  <tromey@adacore.com>
  47
  48         * jit.c (jit_program_space_key): Change type.  Move lower.
  49         (get_jit_program_space_data): Update.
  50         (jit_program_space_data_cleanup): Remove.
  51         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
  52         Update.
  53         (struct jit_program_space_data): Add initializers.
  54
  55 2019-07-10  Tom Tromey  <tromey@adacore.com>
  56
  57         * solib-darwin.c (struct darwin_info): Add initializers.
  58         (solib_darwin_pspace_data): Change type.
  59         (darwin_pspace_data_cleanup): Remove.
  60         (get_darwin_info, _initialize_darwin_solib): Update.
  61
  62 2019-07-10  Tom Tromey  <tromey@adacore.com>
  63
  64         * remote-sim.c (struct sim_inferior_data): Add initializers,
  65         constructor, and destructor.
  66         (sim_inferior_data_key): Change type.  Move lower.
  67         (check_for_duplicate_sim_descriptor): Update.
  68         (get_sim_inferior_data): Use new.  Update.
  69         (~sim_inferior_data_cleanup): Rename from
  70         sim_inferior_data_cleanup.  Simplify.
  71         (gdbsim_close_inferior, simulator_command)
  72         (sim_command_completer, _initialize_remote_sim): Update.
  73         (next_pid, INITIAL_PID): Move earlier.
  74
  75 2019-07-10  Tom Tromey  <tromey@adacore.com>
  76
  77         * python/python-internal.h (create_thread_object): Return
  78         gdbpy_ref.
  79         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
  80         * python/py-inferior.c (struct threadlist_entry): Add
  81         constructor.
  82         <thread_obj>: Now a gdbpy_ref.
  83         (thread_to_thread_object): Update.
  84         (add_thread_object): Use new.
  85         (delete_thread_object): Use delete.
  86         (infpy_threads): Update.
  87         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
  88         GIL.
  89
  90 2019-07-10  Tom Tromey  <tromey@adacore.com>
  91
  92         * valops.c (value_cast): Specialize error message for Ada.
  93
  94 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  95
  96         * breakpoint.c (breakpoint_1): Update doc and parameter names.
  97
  98 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  99
 100         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 101         bpstat_should_step): Return bool, adjust comments.
 102         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 103         bpstat_should_step): Likewise.
 104
 105 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 106
 107         * features/Makefile: Use feature target descriptions for Arm.
 108         * features/arm/arm-core.c: Generate new file.
 109         * features/arm/arm-fpa.c: Likewise.
 110         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 111         * features/arm/arm-m-profile.c: Likewise.
 112         * features/arm/arm-vfpv2.c: Likewise.
 113         * features/arm/arm-vfpv3.c: Likewise.
 114         * features/arm/xscale-iwmmxt.c: Likewise.
 115         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 116
 117 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 118
 119         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 120         ptrace earlier.
 121
 122 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 123
 124         * features/aarch64-pauth.c: Regenerate.
 125
 126 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 127
 128         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 129         bool.
 130         (bpstat_what): Use false instead of 0.
 131
 132 2019-07-09  Pedro Alves  <palves@redhat.com>
 133
 134         * break-catch-throw.c (is_exception_catchpoint): New.
 135         * breakpoint.c (print_one_breakpoint_location): New parameter
 136         'raw_loc'.  Handle it.  Use
 137         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 138         looking at the breakpoint's type.
 139         (print_one_breakpoint): If handling "maint info breakpoints", also
 140         print locations of exception catchpoints.
 141         * breakpoint.h (is_exception_catchpoint): Declare.
 142
 143 2019-07-09  Pedro Alves  <palves@redhat.com>
 144
 145         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 146         "addr" field.
 147         (allocate_location_exception_catchpoint): New.
 148         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 149         (initialize_throw_catchpoint_ops): Install
 150         allocate_location_exception_catchpoint as allocate_location
 151         method.
 152         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 153         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 154         bp_loc_other.
 155         (breakpoint_address_is_meaningful): Delete.
 156         (bl_address_is_meaningful): New.
 157         (breakpoint_locations_match): Adjust comment.
 158         (bp_location_from_bp_type): New, factored out of...
 159         (bp_location::bp_location(breakpoint *)): ... this.
 160         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 161         factored out of...
 162         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 163         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 164         breakpoint_address_is_meaningful.
 165         (bp_locations_compare): Adjust comment.
 166         (update_global_location_list): Use bl_address_is_meaningful
 167         instead of breakpoint_address_is_meaningful.
 168         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 169         explicit.
 170         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 171         * python/py-breakpoint.c (bppy_get_location): No longer check
 172         whether location is null.
 173
 174 2019-07-09  Pedro Alves  <palves@redhat.com>
 175
 176         PR c++/15468
 177         * breakpoint.c (print_one_breakpoint_location): Remove
 178         single-location assert.
 179
 180 2019-07-09  Tom Tromey  <tom@tromey.com>
 181
 182         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 183         * configure: Rebuild.
 184         * configure.ac: Change common to gdbsupport.
 185         * gdbsupport: Rename from common.
 186         * acinclude.m4: Change common to gdbsupport.
 187         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 188         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 189         gdbsupport.
 190         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 191         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 192         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 193         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 194         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 195         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 196         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 197         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 198         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 199         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 200         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 201         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 202         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 203         coff-pe-read.c, command.h, compile/compile-c-support.c,
 204         compile/compile-c.h, compile/compile-cplus-symbols.c,
 205         compile/compile-cplus-types.c, compile/compile-cplus.h,
 206         compile/compile-loc2c.c, compile/compile.c, completer.c,
 207         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 208         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 209         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 210         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 211         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 212         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 213         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 214         features/aarch64-core.c, features/aarch64-fpu.c,
 215         features/aarch64-pauth.c, features/aarch64-sve.c,
 216         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 217         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 218         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 219         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 220         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 221         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 222         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 223         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 224         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 225         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 226         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 227         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 228         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 229         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 230         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 231         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 232         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 233         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 234         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 235         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 236         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 237         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 238         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 239         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 240         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 241         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 242         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 243         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 244         minsyms.c, mips-linux-tdep.c, namespace.h,
 245         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 246         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 247         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 248         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 249         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 250         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 251         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 252         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 253         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 254         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 255         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 256         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 257         procfs.c, producer.c, progspace.h, psymtab.h,
 258         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 259         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 260         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 261         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 262         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 263         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 264         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 265         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 266         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 267         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 268         target-memory.c, target.c, target.h, target/waitstatus.c,
 269         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 270         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 271         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 272         unittests/array-view-selftests.c,
 273         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 274         unittests/common-utils-selftests.c,
 275         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 276         unittests/format_pieces-selftests.c,
 277         unittests/function-view-selftests.c,
 278         unittests/lookup_name_info-selftests.c,
 279         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 280         unittests/mkdir-recursive-selftests.c,
 281         unittests/observable-selftests.c,
 282         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 283         unittests/parse-connection-spec-selftests.c,
 284         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 285         unittests/scoped_fd-selftests.c,
 286         unittests/scoped_mmap-selftests.c,
 287         unittests/scoped_restore-selftests.c,
 288         unittests/string_view-selftests.c, unittests/style-selftests.c,
 289         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 290         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 291         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 292         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 293         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 294         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 295
 296 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 297
 298         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 299         bool value.
 300         (decode_digits_ordinary): Set explicit_line field in sal.
 301         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 302         symtab_and_line that was set on an explicit line number in
 303         assembler code.  Do always update the recorded symtab and line if
 304         we do skip the prologue.
 305
 306 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 307
 308         * breakpoint.c (set_breakpoint_location_function): Remove
 309         explicit_loc parameter.
 310         (momentary_breakpoint_from_master): Update call to
 311         set_breakpoint_location_function.
 312         (add_location_to_breakpoint): Likewise.
 313
 314 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 315
 316         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 317         required features based on default bfd type when no specific bfd
 318         is present.
 319
 320 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 321
 322         * NEWS: Mention that GDB printf and eval commands can now print
 323         C-style and Ada-style convenience var strings without
 324         calling the inferior.
 325         * printcmd.c (printf_c_string): Locally print GDB internal var
 326         instead of transiting via the inferior.
 327         (printf_wide_c_string): Likewise.
 328
 329 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 330
 331         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 332
 333 2019-07-04  Tom Tromey  <tom@tromey.com>
 334
 335         PR tui/24724:
 336         * tui/tui-winsource.c (tui_clear_source_content): Update.
 337         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 338         (tui_update_breakpoint_info): Update.
 339         (tui_set_exec_info_content): Update.
 340         * tui/tui-source.c (tui_set_source_content_nil): Update.
 341         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 342         has_break.
 343         * tui/tui-data.h (enum tui_bp_flag): New.
 344         (tui_bp_flags): New enum flags type.
 345         (struct tui_source_element) <break_mode>: Change type.  Rename
 346         from has_break.
 347         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 348         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 349         constants.
 350         * tui/tui-winsource.h: Fix comment.
 351
 352 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 353
 354         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 355         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 356         (store_fpregs_to_thread)
 357         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 358         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 359         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 360         (IWMMXT_REGS_SIZE): Add define.
 361         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 362         (fetch_vfp_regs, store_vfp_regs)
 363         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 364         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 365
 366 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 367
 368         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 369         defines.
 370         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 371         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 372         (ARM_INT_REGISTER_SIZE): ...to this.
 373         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 374         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 375         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 376         (arm_linux_collect_gregset, supply_nwfpe_register)
 377         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 378         defines.
 379         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 380         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 381         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 382         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 383         (arm_return_in_memory, arm_store_return_value)
 384         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 385         (arm_record_ld_st_multiple): Likewise.
 386         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 387         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 388
 389 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 390
 391         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 392         AARCH64_DISPLACED_MODIFIED_INSNS.
 393         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 394         (aarch64_displaced_step_copy_insn): Likewise.
 395         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 396         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 397         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 398         ARM_DISPLACED_MODIFIED_INSNS.
 399         * arm-tdep.c (arm_gdbarch_init): Likewise.
 400         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 401         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 402         (struct arm_displaced_step_closure): Use
 403         ARM_DISPLACED_MODIFIED_INSNS.
 404
 405 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 406
 407         * features/Makefile: Remove unused xml files.
 408         * features/aarch64.xml: Remove.
 409         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 410         * features/i386/amd64-avx-avx512.xml: Remove.
 411         * features/i386/amd64-avx-linux.xml: Remove.
 412         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 413         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 414         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 415         * features/i386/amd64-avx-mpx.xml: Remove.
 416         * features/i386/amd64-avx.xml: Remove.
 417         * features/i386/amd64-linux.xml: Remove.
 418         * features/i386/amd64-mpx-linux.xml: Remove.
 419         * features/i386/amd64-mpx.xml: Remove.
 420         * features/i386/amd64.xml: Remove.
 421         * features/i386/i386-avx-avx512-linux.xml: Remove.
 422         * features/i386/i386-avx-avx512.xml: Remove.
 423         * features/i386/i386-avx-linux.xml: Remove.
 424         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 425         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 426         * features/i386/i386-avx-mpx-linux.xml: Remove.
 427         * features/i386/i386-avx-mpx.xml: Remove.
 428         * features/i386/i386-avx.xml: Remove.
 429         * features/i386/i386-linux.xml: Remove.
 430         * features/i386/i386-mmx-linux.xml: Remove.
 431         * features/i386/i386-mmx.xml: Remove.
 432         * features/i386/i386-mpx-linux.xml: Remove.
 433         * features/i386/i386-mpx.xml: Remove.
 434         * features/i386/i386.xml: Remove.
 435         * features/i386/x32-avx-avx512-linux.xml: Remove.
 436         * features/i386/x32-avx-linux.xml: Remove.
 437         * features/i386/x32-linux.xml: Remove.
 438
 439 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 440
 441         * regformats/aarch64.dat: Remove.
 442         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 443         * regformats/i386/amd64-avx-linux.dat: Remove.
 444         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 445         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 446         * regformats/i386/amd64-linux.dat: Remove.
 447         * regformats/i386/amd64-mpx-linux.dat: Remove.
 448         * regformats/i386/amd64.dat: Remove.
 449         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 450         * regformats/i386/i386-avx-linux.dat: Remove.
 451         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 452         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 453         * regformats/i386/i386-linux.dat: Remove.
 454         * regformats/i386/i386-mmx-linux.dat: Remove.
 455         * regformats/i386/i386-mpx-linux.dat: Remove.
 456         * regformats/i386/i386.dat: Remove.
 457         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 458         * regformats/i386/x32-avx-linux.dat: Remove.
 459         * regformats/i386/x32-linux.dat: Remove.
 460
 461 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 462
 463         * aarch64-tdep.c: Remove xml self tests.
 464         * amd64-linux-tdep.c: Likewise.
 465         * amd64-tdep.c: Likewise.
 466         * i386-linux-tdep.c: Likewise.
 467         * i386-tdep.c: Likewise.
 468
 469 2019-07-03  Pedro Alves  <palves@redhat.com>
 470
 471         PR cli/24732
 472         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 473         (pipe_cmd_option_defs): New.
 474         (make_pipe_cmd_options_def_group): New.
 475         (pipe_command): Use gdb::option::process_options.
 476         (pipe_command_completer): New function.
 477         (_initialize_cli_cmds): Install completer for "pipe" command.
 478
 479 2019-07-03  Pedro Alves  <palves@redhat.com>
 480
 481         * cli/cli-option.c (union option_value) <string>: New field.
 482         (struct option_def_and_value): Add ctor, move ctor, dtor and
 483         use DISABLE_COPY_AND_ASSIGN.
 484         (option_def_and_value::clear_value): New.
 485         (parse_option, save_option_value_in_ctx, get_val_type_str)
 486         (add_setshow_cmds_for_options): Handle var_string.
 487         * cli-option.h (union option_def::var_address) <string>: New
 488         field.
 489         (struct string_option_def): New.
 490         * maint-test-options.c (struct test_options_opts): Add default
 491         ctor and use DISABLE_COPY_AND_ASSIGN.
 492         <string_opt>: New field.
 493         (test_options_opts::~test_options_opts): New.
 494         (test_options_opts::dump): Also dump "-string".
 495         (test_options_option_defs): Install "string.
 496
 497 2019-07-03  Pedro Alves  <palves@redhat.com>
 498
 499         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 500         option_value with a null enumeration.
 501         (complete_options): Save the option values in the context.
 502         (save_option_value_in_ctx): New, factored out from ...
 503         (process_options): ... here.
 504         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 505         of the function.
 506         * maint-test-options.c (test_options_opts::dump): New, factored
 507         out from ...
 508         (maintenance_test_options_command_mode): ... here.
 509         (maintenance_test_options_command_completion_result): Delete.
 510         (maintenance_test_options_command_completion_text): Update
 511         comment.
 512         (maintenance_show_test_options_completion_result): Change
 513         prototype.  Just print
 514         maintenance_test_options_command_completion_text.
 515         (save_completion_result): New.
 516         (maintenance_test_options_completer_mode): Pass options context to
 517         complete_options, and then save a dump.
 518         (_initialize_maint_test_options): Use add_cmd to install "maint
 519         show test-options-completion-result".
 520
 521 2019-07-03  Pedro Alves  <palves@redhat.com>
 522
 523         * NEWS (New commands): Mention "with" and "maint with".
 524         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 525         (with_command, with_command_completer): New.
 526         (pipe_command): Adjust to new repeat_previous
 527         interface.
 528         (_initialize_cli_cmds): Install the "with" command and its "w"
 529         alias.
 530         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 531         declarations.
 532         * cli/cli-setshow.c (parse_cli_var_uinteger)
 533         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 534         argument strings for all var_types.
 535         (get_setshow_command_value_string): New, factored out from ...
 536         (do_show_command): ... this.
 537         * cli/cli-setshow.h: Include <string>.
 538         (get_setshow_command_value_string): Declare.
 539         * command.h (repeat_previous): Now returns const char *.  Adjust
 540         comment.
 541         * maint.c: Include "cli/cli-cmds.h".
 542         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 543         (_initialize_maint_cmds): Register the "maintenance with" command.
 544         * top.c (repeat_previous): Move bits from pipe_command here:
 545         Return the saved command line, if any; error out if there's no
 546         command to relaunch.
 547
 548 2019-07-03  Pedro Alves  <palves@redhat.com>
 549
 550         * NEWS (New commands): Mention "maint set/show test-settings"
 551         instead of "maint test-settings".
 552         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 553         (maintenance_test_settings_set_list): Rename to ...
 554         (maintenance_set_test_settings_list): ... this.
 555         (maintenance_test_settings_show_list): Rename to  ...
 556         (maintenance_show_test_settings_list): ... this.
 557         (maintenance_test_settings_cmd): Delete.
 558         (maintenance_test_settings_set_cmd): ...
 559         (maintenance_set_test_settings_cmd): ... this.
 560         (maintenance_test_settings_show_cmd): ...
 561         (maintenance_show_test_settings_cmd): ... this.
 562         (maintenance_test_settings_show_value_cmd):
 563         (maintenance_show_test_settings_value_cmd): ... this.
 564         (_initialize_maint_test_settings): No longer install the "maint
 565         test-settings" prefix command.  Rename "maint test-settings set"
 566         to "maint set test-settings", and "maint test-settings show" to
 567         "maint show test-settings".  Adjust all subcommands.
 568
 569 2019-07-03  Pedro Alves  <palves@redhat.com>
 570
 571         * maint-test-settings.c: Fix file's intro comment.  Replace all
 572         references to "test-options" with references to "test-settings",
 573         in comments.
 574
 575 2019-07-03  Pedro Alves  <palves@redhat.com>
 576
 577         * maint-test-settings.c (maintenance_test_settings_xxx)
 578         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 579         New.
 580         (maintenance_test_settings_enums): Use them.
 581         (maintenance_test_settings_enum): Default to
 582         maintenance_test_settings_xxx.
 583         (_initialize_maint_test_settings): Initialize
 584         MAINTENANCE_TEST_SETTINGS_FILENAME.
 585
 586 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 587
 588         * breakpoint.h (remove_breakpoints_inf): Change return type to
 589         void, move function documentation here.
 590         * breakpoint.c (remove_breakpoints_inf): Change return type to
 591         void, move function documentation to header.
 592
 593 2019-07-02  Pedro Alves  <palves@redhat.com>
 594
 595         * NEWS (Completion improvements): Mention "info threads".
 596         * thread.c (struct info_threads_opts, info_threads_option_defs)
 597         (make_info_threads_options_def_group): New.
 598         (info_threads_command): Use gdb::option::process_options.
 599         (info_threads_command_completer): New.
 600         (_initialize_thread): Use gdb::option::build_help to build the
 601         help text for "info threads".
 602
 603 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 604
 605         * defs.h (generic_load): Move from here...
 606         * symfile.h (generic_load): ... to here.  Rename name parameter
 607         to args.
 608         * symfile.c (generic_load): Add comment.
 609
 610 2019-07-01  Tom Tromey  <tromey@adacore.com>
 611
 612         * dwarf2read.c
 613         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 614         declaration of without_params.  Fix formatting.
 615
 616 2019-07-01  Tom Tromey  <tromey@adacore.com>
 617
 618         * ada-exp.y (find_primitive_type): Update.
 619         * ada-lang.h (ada_lookup_symbol): Update.
 620         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 621         parameter.
 622         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 623
 624 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 625
 626         PR breakpoints/24541
 627         * gdbarch.c: Regenerate.
 628         * gdbarch.h: Regenerate.
 629         * gdbarch.sh: Add 'stap_adjust_register'.
 630         * i386-tdep.c: Include '<unordered_set>'.
 631         (i386_stap_adjust_register): New function.
 632         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 633         * stap-probe.c (stap_parse_register_operand): Call
 634         'gdbarch_stap_adjust_register'.
 635
 636 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 637
 638         PR python/24742
 639         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 640         * python/python.c (do_start_initialization): Use 'xmalloc'
 641         instead of 'PyMem_Malloc'.
 642
 643 2019-06-28  Tom Tromey  <tromey@adacore.com>
 644
 645         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 646         for Ada.
 647
 648 2019-06-27  Tom Tromey  <tromey@adacore.com>
 649
 650         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 651         objfile_key.
 652         (arm_find_mapping_symbol, arm_record_special_symbol)
 653         (_initialize_arm_tdep): Update.
 654         (arm_objfile_data_free): Remove.
 655
 656 2019-06-27  Tom Tromey  <tromey@adacore.com>
 657
 658         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 659         to cp_print_static_field.
 660
 661 2019-06-26  Tom Tromey  <tromey@adacore.com>
 662
 663         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 664         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 665         declare.
 666
 667 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 668
 669         * features/aarch64-core.c (create_feature_aarch64_core):
 670         Regenerate.
 671         * features/aarch64-core.xml: Add cpsr flags.
 672
 673 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 674
 675         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 676         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 677
 678 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 679
 680         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 681         field.
 682         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 683         use.
 684         (arm_record_special_symbol): Don't insert new symbol in sorted
 685         position, push it at the end.
 686
 687 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 688
 689         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 690         (arm_mapping_symbol_s): Remove.
 691         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 692         (arm_mapping_symbol_vec): New typedef.
 693         (struct arm_per_objfile): Add constructor.
 694         <section_maps>: Change type to
 695         std::unique_ptr<arm_mapping_symbol_vec[]>.
 696         (arm_compare_mapping_symbols): Remove.
 697         (arm_find_mapping_symbol): Adjust to section_maps type change.
 698         (arm_objfile_data_free): Call delete on arm_per_objfile.
 699         (arm_record_special_symbol): Adjust to section_maps type change.
 700         Allocate arm_per_objfile with new.
 701
 702 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 703
 704         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 705         with the command prefix.
 706
 707 2019-06-25  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 710         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 711
 712 2019-06-25  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 715         type.
 716         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 717         protected.
 718
 719 2019-06-25  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-winsource.c
 722         (tui_source_window_base::set_is_exec_point_at): Add check against
 723         LOA_ADDRESS.
 724
 725 2019-06-25  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-source.c (tui_set_source_content): Don't check before
 728         xfree.
 729         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 730
 731 2019-06-25  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-winsource.h (tui_update_source_window_as_is)
 734         (tui_alloc_source_buffer, tui_line_is_displayed)
 735         (tui_addr_is_displayed): Change type of win_info.
 736         * tui/tui-winsource.c (tui_update_source_window_as_is)
 737         (tui_clear_source_content, tui_show_source_line)
 738         (tui_show_source_content, tui_source_window_base::refill)
 739         (tui_source_window_base::set_is_exec_point_at)
 740         (tui_source_window_base::set_is_exec_point_at)
 741         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 742         (tui_alloc_source_buffer, tui_line_is_displayed)
 743         (tui_addr_is_displayed): Change type of win_info.  Update.
 744         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 745         (tui_source_window_base::do_make_visible_with_new_height):
 746         Update.
 747         * tui/tui-source.c (tui_set_source_content)
 748         (tui_set_source_content_nil)
 749         (tui_source_window::do_scroll_vertical): Update.
 750         * tui/tui-layout.c (show_layout): Update.
 751         * tui/tui-disasm.c (tui_set_disassem_content)
 752         (tui_disasm_window::do_scroll_vertical): Update.
 753         * tui/tui-data.h (tui_win_content): Remove.
 754         (struct tui_gen_win_info) <content, content_size>: Remove.
 755         (struct tui_source_element): Add initializers and destructor.
 756         (union tui_which_element, struct tui_win_element): Remove.
 757         (struct tui_source_window_base) <content>: New field.
 758         (struct tui_data_window): Remove destructor.
 759         (tui_alloc_content, tui_free_win_content)
 760         (tui_free_all_source_wins_content): Don't declare.
 761         * tui/tui-data.c (tui_initialize_static_data): Update.
 762         (init_content_element, tui_alloc_content): Remove.
 763         (~tui_gen_win_info): Update.
 764         (~tui_data_window, tui_free_all_source_wins_content)
 765         (tui_free_win_content, free_content, free_content_elements):
 766         Remove.
 767
 768 2019-06-25  Tom Tromey  <tom@tromey.com>
 769
 770         * tui/tui-winsource.h (tui_clear_source_content)
 771         (tui_erase_source_content, tui_show_source_content): Change type
 772         of win_info.
 773         * tui/tui-winsource.c (tui_clear_source_content)
 774         (tui_erase_source_content, tui_show_source_content): Change type
 775         of win_info.
 776         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 777         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 778         win_info.
 779         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 780         win_info.
 781         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 782
 783 2019-06-25  Tom Tromey  <tom@tromey.com>
 784
 785         * tui/tui-winsource.c (tui_clear_source_content)
 786         (tui_source_window_base::set_is_exec_point_at): Update.
 787         * tui/tui-source.c (tui_set_source_content_nil): Update.
 788         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 789         a bool.
 790         * tui/tui-data.c (init_content_element): Update.
 791
 792 2019-06-25  Tom Tromey  <tom@tromey.com>
 793
 794         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 795         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 796         * tui/tui-layout.c (init_and_make_win): Update.
 797         * tui/tui.h (enum tui_win_type): Update.
 798         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 799         tui_win_is_auxillary.
 800         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 801         tui_win_is_auxillary.
 802
 803 2019-06-25  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 806         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 807         (tui_delete_data_content_windows, tui_display_all_data)
 808         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 809         Update.
 810         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 811         * tui/tui-regs.c (tui_last_regs_line_no)
 812         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 813         (tui_show_registers): Update.
 814         (tui_show_register_group): Return void.  Update.
 815         (tui_display_registers_from, tui_display_reg_element_at_line)
 816         (tui_display_registers_from_line, tui_check_register_values):
 817         Update.
 818         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 819         member.
 820         (struct tui_data_window) <regs_content>: Now a std::vector.
 821         <regs_content_count>: Remove.
 822         (tui_add_content_elements, tui_free_data_content): Don't declare.
 823         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 824         (init_content_element): Remove DATA_WIN case.  Add assert.
 825         (tui_add_content_elements): Remove.
 826         (tui_data_window): Update.
 827         (tui_free_data_content): Remove.
 828         (free_content_elements): Remove DATA_WIN case.
 829
 830 2019-06-25  Tom Tromey  <tom@tromey.com>
 831
 832         * tui/tui-data.c (tui_data_item_window): Update.
 833         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 834         * tui/tui-windata.c (tui_display_all_data)
 835         (tui_display_data_from_line): Update.
 836         (tui_check_data_values): Remove.
 837         * tui/tui-regs.c (tui_show_register_group)
 838         (tui_display_reg_element_at_line): Update.
 839         * tui/tui-hooks.c (tui_register_changed)
 840         (tui_refresh_frame_and_register_information): Call
 841         tui_check_register_values.
 842         * tui/tui-data.h (struct tui_data_window) <data_content,
 843         data_content_count, data_type>: Remove.
 844         (enum tui_data_type): Remove.
 845
 846         * tui/tui-data.c (tui_data_window::clear_detail)
 847         (~tui_data_window): Update.
 848
 849 2019-06-25  Tom Tromey  <tom@tromey.com>
 850
 851         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 852         declare.
 853         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 854         Rename from tui_first_data_item_displayed.  Update.
 855         (tui_data_window::refresh_all)
 856         (tui_data_window::do_scroll_vertical): Update.
 857         * tui/tui-data.h (struct tui_data_window)
 858         <first_data_item_displayed>: Declare new method.
 859
 860 2019-06-25  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 863         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 864         contents...
 865         (tui_initialize_static_data): ...here.
 866
 867 2019-06-25  Tom Tromey  <tom@tromey.com>
 868
 869         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 870         (tui_display_registers_from, tui_check_register_values): Update.
 871         (tui_display_register): Remove win_info parameter; update.
 872         (tui_get_register): Change type of parameters.
 873         * tui/tui-data.h (struct tui_data_element): Remove.
 874         (union tui_which_element) <data>: Remove.
 875         <data_window>: Change type.
 876         (struct tui_data_item_window): New.
 877         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 878         case.  Add assert.
 879         (~tui_data_item_window): New destructor.
 880         (free_content_elements): Remove DATA_ITEM_WIN case.
 881
 882 2019-06-25  Tom Tromey  <tom@tromey.com>
 883
 884         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 885         Remove.
 886
 887 2019-06-25  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui-data.h (struct tui_command_element): Remove.
 890         (union tui_which_element) <command>: Remove.
 891         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 892         assert.
 893         (free_content_elements): Remove CMD_WIN case.
 894
 895 2019-06-25  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-layout.c (tui_set_layout): Update.
 898         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 899         * tui/tui-data.c (layout_def): Update.
 900
 901 2019-06-25  Tom Tromey  <tom@tromey.com>
 902
 903         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 904         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 905         (tui_source_window_base::set_new_height): Update.
 906         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 907         Update.
 908         (tui_set_locator_fullname, tui_set_locator_info)
 909         (tui_show_frame_info): Update.
 910         * tui/tui-source.c (tui_set_source_content)
 911         (tui_source_is_displayed): Update.
 912         * tui/tui-layout.c (show_source_disasm_command, show_data)
 913         (show_source_or_disasm_and_command): Update.
 914         * tui/tui-disasm.c (tui_set_disassem_content)
 915         (tui_get_begin_asm_address): Update.
 916         * tui/tui-data.h (struct tui_locator_element): Remove.
 917         (union tui_which_element) <locator>: Remove.
 918         (struct tui_locator_window): New.
 919         (tui_locator_win_info_ptr): Change return type.
 920         * tui/tui-data.c (_locator): Change type.
 921         (tui_locator_win_info_ptr): Change return type.
 922         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 923         (tui_alloc_content): Add assert.
 924
 925 2019-06-25  Tom Tromey  <tom@tromey.com>
 926
 927         * tui/tui-winsource.c
 928         (tui_exec_info_window::maybe_allocate_content): New method.
 929         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 930         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 931         (make_source_or_disasm_window): Add cast.
 932         * tui/tui-data.h (union tui_which_element) <simple_string>:
 933         Remove.
 934         (struct tui_source_info): New.
 935         (struct tui_source_window_base) <execution_info>: Change type.
 936         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 937         case, and add assert.
 938         (tui_alloc_content): Add assert.
 939
 940 2019-06-25  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 943         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 944         * tui/tui-data.c (tui_alloc_win_info): Remove.
 945
 946 2019-06-25  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 949         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 950         can_highlight.
 951
 952 2019-06-25  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 955         make_visible_with_new_height method.
 956         (tui_win_info::make_visible_with_new_height): New method.
 957         (tui_source_window_base::do_make_visible_with_new_height)
 958         (tui_data_window::do_make_visible_with_new_height)
 959         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 960         (make_visible_with_new_height): Remove.
 961         (tui_resize_all, tui_adjust_win_heights): Use
 962         make_visible_with_new_height method.
 963         * tui/tui-data.h (struct tui_win_info)
 964         <do_make_visible_with_new_height, make_visible_with_new_height>:
 965         New methods.
 966         (struct tui_source_window_base, struct tui_data_window)
 967         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 968         methods.
 969
 970 2019-06-25  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 973         method.
 974         (update_tab_width): Call update_tab_width method.
 975         * tui/tui-data.h (struct tui_win_info)
 976         (struct tui_source_window_base) <update_tab_width>: New methods.
 977
 978 2019-06-25  Tom Tromey  <tom@tromey.com>
 979
 980         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 981         parameter.
 982         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 983         parameter.
 984         (tui_gen_win_info::make_visible): Update.
 985         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 986         parameter.
 987         * tui/tui-data.h (enum tui_box): New enum.
 988         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 989
 990 2019-06-25  Tom Tromey  <tom@tromey.com>
 991
 992         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 993         init_and_make_win for EXEC_INFO_WIN.
 994         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 995         longer inline.
 996         (struct tui_win_info) <~tui_win_info>: Inline.
 997         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 998         Don't declare.
 999         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1000         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1001         Remove.
1002         (tui_initialize_static_data): Update.
1003         (~tui_gen_win_info): Handle more cleanup here.
1004         (~tui_source_window_base): Delete "execution_info".
1005         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1006
1007 2019-06-25  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui-layout.c (make_command_window): Don't set
1010         can_highlight.
1011         (show_source_disasm_command): Call the reset method.
1012         (show_data): Don't set can_highlight.  Call the reset method.
1013         (tui_gen_win_info::reset): Rename from init_gen_win_info
1014         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1015         (show_source_or_disasm_and_command): Call the reset method.
1016         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1017         (struct tui_cmd_window): Set can_highlight.
1018
1019 2019-06-25  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1022         from make_visible.
1023         (tui_make_visible, tui_make_invisible): Rewrite.
1024         (tui_win_info::make_visible): Remove.
1025         (tui_source_window_base::make_visible): Update.
1026         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1027         method.  Moved from...
1028         (struct tui_win_info) <make_visible>: ...here.
1029
1030 2019-06-25  Tom Tromey  <tom@tromey.com>
1031
1032         * tui/tui-winsource.c
1033         (tui_source_window_base::do_scroll_horizontal): Remove direction
1034         parameter.
1035         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1036         direction parameter.
1037         * tui/tui-win.c (tui_win_info::forward_scroll)
1038         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1039         (tui_win_info::right_scroll): Update.
1040         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1041         direction parameter.
1042         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1043         direction parameter.
1044         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1045         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1046         Remove direction parameter.
1047         (struct tui_source_window_base, struct tui_source_window)
1048         (struct tui_disasm_window, struct tui_data_window)
1049         (struct tui_cmd_window): Update.
1050
1051 2019-06-25  Tom Tromey  <tom@tromey.com>
1052
1053         * tui/tui-winsource.h (tui_set_exec_info_content)
1054         (tui_show_exec_info_content, tui_erase_exec_info_content)
1055         (tui_clear_exec_info_content, tui_update_exec_info): Change
1056         argument to tui_source_window_base.
1057         * tui/tui-winsource.c (tui_set_exec_info_content)
1058         (tui_show_exec_info_content, tui_erase_exec_info_content)
1059         (tui_clear_exec_info_content, tui_update_exec_info): Change
1060         argument to tui_source_window_base.
1061
1062 2019-06-25  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1065         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1066
1067 2019-06-25  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1070         check.
1071
1072 2019-06-25  Tom Tromey  <tom@tromey.com>
1073
1074         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1075         type to void.
1076         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1077         type to void.
1078         * tui/tui-source.c (tui_set_source_content): Update.
1079         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1080
1081 2019-06-25  Tom Tromey  <tom@tromey.com>
1082
1083         * tui/tui-win.c (window_name_completer, tui_set_focus)
1084         (tui_all_windows_info): Use name method.
1085         * tui/tui-data.h (struct tui_gen_win_info)
1086         (struct tui_source_window, struct tui_disasm_window)
1087         (struct tui_data_window, struct tui_cmd_window) <name>: New
1088         method.
1089         (tui_win_name): Don't declare.
1090         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1091         (tui_win_name): Remove.
1092
1093 2019-06-25  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-winsource.h (tui_update_source_window)
1096         (tui_update_source_window_as_is): Change parameter type.
1097         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1098         to be a tui_source_window_base.
1099         (tui_update_source_window_as_is): Likewise.
1100         * tui/tui-win.c (make_visible_with_new_height): Update.
1101
1102 2019-06-25  Tom Tromey  <tom@tromey.com>
1103
1104         * tui/tui-winsource.c (tui_erase_source_content)
1105         (tui_show_source_content, tui_show_exec_info_content)
1106         (tui_erase_exec_info_content): Use refresh_window method.
1107         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1108         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1109         from tui_refresh_win.
1110         (tui_data_window::refresh_window): New method.
1111         (tui_win_info::refresh, tui_source_window_base::refresh)
1112         (tui_refresh_all): Use refresh_window method.
1113         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1114         method.
1115         * tui/tui-regs.c (tui_display_register): Call refresh_window
1116         method.
1117         * tui/tui-layout.c (show_source_disasm_command)
1118         (show_source_or_disasm_and_command): Call refresh_window method.
1119         * tui/tui-data.h (struct tui_gen_win_info)
1120         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1121         New method.
1122
1123 2019-06-25  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui.c (tui_rl_other_window, tui_enable)
1126         (tui_is_window_visible, tui_get_command_dimension): Update.
1127         * tui/tui-winsource.c (tui_update_source_window_as_is)
1128         (tui_clear_source_content, tui_erase_source_content)
1129         (tui_show_source_line, tui_source_window_base::refill)
1130         (tui_source_window_base::do_scroll_horizontal)
1131         (tui_source_window_base::set_is_exec_point_at)
1132         (tui_update_breakpoint_info, tui_set_exec_info_content)
1133         (tui_alloc_source_buffer, tui_line_is_displayed)
1134         (tui_addr_is_displayed): Update.
1135         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1136         (tui_check_and_display_highlight_if_needed)
1137         (tui_win_info::make_visible, tui_win_info::refresh)
1138         (tui_refresh_all): Update.
1139         * tui/tui-windata.c (tui_first_data_item_displayed)
1140         (tui_delete_data_content_windows, tui_erase_data_content)
1141         (tui_display_all_data, tui_data_window::refresh_all)
1142         (tui_check_data_values): Update.
1143         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1144         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1145         (tui_win_info::backward_scroll, tui_refresh_all_win)
1146         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1147         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1148         (tui_source_window_base::set_new_height)
1149         (tui_data_window::set_new_height)
1150         (make_invisible_and_set_new_height)
1151         (make_visible_with_new_height, new_height_ok)
1152         (parse_scrolling_args): Update.
1153         * tui/tui-stack.c (tui_show_frame_info): Update.
1154         * tui/tui-source.c (tui_set_source_content)
1155         (tui_set_source_content_nil, tui_source_is_displayed)
1156         (tui_source_window::do_scroll_vertical): Update.
1157         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1158         (tui_display_registers_from, tui_display_reg_element_at_line)
1159         (tui_check_register_values, tui_reg_command): Update.
1160         * tui/tui-layout.c (tui_default_win_height)
1161         (show_source_disasm_command, show_data, init_and_make_win)
1162         (show_source_or_disasm_and_command): Update.
1163         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1164         (tui_redisplay_readline, tui_mld_flush)
1165         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1166         (tui_getc): Update.
1167         * tui/tui-disasm.c (tui_set_disassem_content)
1168         (tui_disasm_window::do_scroll_vertical): Update.
1169         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1170         Now virtual.
1171         (struct tui_win_info): Derive from tui_gen_win_info.
1172         <~tui_win_info>: Mark as override.
1173         <generic>: Remove member.
1174         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1175         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1176         (~tui_data_window, ~tui_win_info)
1177         (tui_free_all_source_wins_content): Update.
1178         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1179
1180 2019-06-25  Tom Tromey  <tom@tromey.com>
1181
1182         * tui/tui-layout.c (init_and_make_win): Use new.
1183         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1184         destructor, initializers.
1185         (tui_alloc_generic_win_info): Don't declare.
1186         * tui/tui-data.c (_locator): Add argument to constructor.
1187         (source_win, disasm_win): New globals.
1188         (exec_info): Remove.
1189         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1190         Update.
1191         (tui_alloc_generic_win_info): Remove.
1192         (init_content_element): Use new.
1193         (tui_win_info::tui_win_info): Update.
1194         (free_content_elements) <case DATA_WIN>: Use delete.
1195
1196 2019-06-25  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1199         * tui/tui-windata.c (tui_first_data_item_displayed)
1200         (tui_delete_data_content_windows): Update.
1201         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1202         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1203         (tui_display_registers_from, tui_check_register_values): Update.
1204         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1205         pointer.
1206         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1207         window.
1208         (tui_free_data_content): Update.
1209         (free_content_elements) <case DATA_WIN>: Free the window.
1210
1211 2019-06-25  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1214         Update.
1215         * tui/tui-layout.c (make_command_window)
1216         (show_source_disasm_command, show_data, init_and_make_win)
1217         (show_source_or_disasm_and_command): Update.
1218         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1219         method.
1220         <can_highight, is_highlighted>: Now bool.
1221         (tui_set_win_highlight): Don't declare.
1222         * tui/tui-data.c (tui_set_win_highlight): Remove.
1223
1224 2019-06-25  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-wingeneral.c (make_visible): Remove check of window
1227         type.
1228
1229 2019-06-25  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui-win.c (tui_win_info::max_height)
1232         (tui_cmd_window::max_height): New methods.
1233         (new_height_ok): Call max_height.
1234         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1235         <max_height>: New method.
1236
1237 2019-06-25  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-win.c (tui_source_window_base::set_new_height)
1240         (tui_data_window::set_new_height): New methods.
1241         (make_invisible_and_set_new_height): Call set_new_height method.
1242         * tui/tui-data.h (struct tui_win_info)
1243         (struct tui_source_window_base, struct tui_data_window)
1244         <set_new_height>: New method.
1245
1246 2019-06-25  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1249         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1250         tui_refresh_data_win.
1251         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1252         method.
1253         (tui_refresh_all_win): Call the refresh_all method.
1254         (tui_set_focus): Likewise.
1255         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1256         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1257         Likewise.
1258
1259 2019-06-25  Tom Tromey  <tom@tromey.com>
1260
1261         * tui/tui-winsource.h (tui_refill_source_window)
1262         (tui_set_is_exec_point_at): Don't declare.
1263         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1264         (tui_source_window_base::refill): Rename from
1265         tui_refill_source_window.
1266         (tui_source_window_base::do_scroll_horizontal): Update.
1267         (tui_source_window_base::set_is_exec_point_at): Rename from
1268         tui_set_is_exec_point_at.
1269         (tui_update_all_breakpoint_info): Update.
1270         * tui/tui-stack.c (tui_show_frame_info): Update.
1271         * tui/tui-layout.c (show_data): Add cast.
1272         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1273         * tui/tui-data.h (struct tui_source_window_base) <refill,
1274         set_is_exec_point_at>: New methods.
1275         (tui_source_windows, tui_add_to_source_windows): Update types.
1276         (tui_add_to_source_windows): Remove redundant declaration.
1277         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1278         (tui_source_windows): Change return type.
1279         (tui_clear_source_windows_detail): Update.
1280         (tui_add_to_source_windows): Change type of parameter.
1281         (tui_free_all_source_wins_content): Update.
1282
1283 2019-06-25  Tom Tromey  <tom@tromey.com>
1284
1285         * tui/tui-wingeneral.c (tui_win_info::refresh)
1286         (tui_source_window_base::refresh): New methods.
1287         (tui_refresh_all): Call the refresh method.
1288         * tui/tui-data.h (struct tui_win_info)
1289         (struct tui_source_window_base) <refresh>: New method.
1290
1291 2019-06-25  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui.h (tui_is_window_visible): Return bool.
1294         * tui/tui.c (tui_is_window_visible): Return bool.
1295         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1296         (tui_make_visible, tui_make_invisible)
1297         (tui_win_info::make_visible)
1298         (tui_source_window_base::make_visible, make_all_visible)
1299         (tui_make_all_visible, tui_make_all_invisible): Update.
1300         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1301         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1302         bool.
1303         (struct tui_win_info, struct tui_source_window_base)
1304         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1305         * tui/tui-data.c (tui_init_generic_part): Update.
1306
1307 2019-06-25  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1310         (tui_source_window_base::make_visible): New methods.
1311         (make_all_visible): Make method call.
1312         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1313         (struct tui_source_window_base, struct tui_cmd_window): Override
1314         make_visible.
1315         (tui_win_is_source_type): Don't declare.
1316         * tui/tui-data.c (tui_win_is_source_type): Remove.
1317
1318 2019-06-25  Tom Tromey  <tom@tromey.com>
1319
1320         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1321         NULL check.
1322
1323 2019-06-25  Tom Tromey  <tom@tromey.com>
1324
1325         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1326         Inline constructor.  Add initializers for members.
1327         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1328         constructors; now inline in class.
1329
1330 2019-06-25  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-regs.c (tui_show_registers): Update.
1333         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1334         bool.
1335         * tui/tui-data.c (tui_data_window::clear_detail)
1336         (tui_data_window): Update.
1337
1338 2019-06-25  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-windata.c (tui_display_all_data)
1341         (tui_display_data_from_line, tui_display_data_from)
1342         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1343         Update.
1344         * tui/tui-regs.c (tui_last_regs_line_no)
1345         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1346         (tui_show_registers, tui_show_register_group)
1347         (tui_display_registers_from, tui_display_reg_element_at_line)
1348         (tui_display_registers_from_line, tui_check_register_values)
1349         (tui_reg_next, tui_reg_prev): Update.
1350         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1351         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1352         tui_data_window.
1353         (struct tui_win_info) <detail>: Remove.  Add new fields from
1354         tui_data_info.
1355         (TUI_DATA_WIN): Add cast.
1356         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1357         (~tui_data_window): Simplify.
1358
1359 2019-06-25  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-layout.c (show_source_disasm_command)
1362         (show_source_or_disasm_and_command): Update.
1363         * tui/tui-io.c (update_cmdwin_start_line)
1364         (tui_redisplay_readline): Update.
1365         * tui/tui-data.h (struct tui_command_info): Remove.
1366         (struct tui_win_info) <detail>: Remove command_info member.
1367         (struct tui_data_window) <start_line>: New member, from
1368         tui_command_info.
1369         (TUI_CMD_WIN): Add casts.
1370
1371 2019-06-25  Tom Tromey  <tom@tromey.com>
1372
1373         * tui/tui-winsource.c (tui_update_source_window)
1374         (tui_refill_source_window)
1375         (tui_source_window_base::do_scroll_horizontal)
1376         (tui_update_breakpoint_info, tui_set_exec_info_content)
1377         (tui_show_exec_info_content, tui_erase_exec_info_content)
1378         (tui_clear_exec_info_content): Update.
1379         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1380         Update.
1381         * tui/tui-win.c (make_invisible_and_set_new_height)
1382         (make_visible_with_new_height): Update.
1383         * tui/tui-source.c (tui_set_source_content)
1384         (tui_show_symtab_source): Update.
1385         * tui/tui-layout.c (extract_display_start_addr)
1386         (show_source_disasm_command, show_data)
1387         (make_source_or_disasm_window)
1388         (show_source_or_disasm_and_command): Update.
1389         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1390         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1391         "gdbarch".
1392         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1393         to tui_source_window_base.
1394         (struct tui_win_info) <detail>: Remove source_info member.
1395         (struct tui_source_window_base) <has_locator>: Inline.
1396         Move contents from tui_source_info; rename has_locator member to
1397         m_has_locator.
1398         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1399         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1400         header file.
1401         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1402         Simplify.
1403         (tui_free_all_source_wins_content): Cast to
1404         tui_source_window_base.
1405
1406 2019-06-25  Tom Tromey  <tom@tromey.com>
1407
1408         * tui/tui-win.c (make_invisible_and_set_new_height)
1409         (make_visible_with_new_height): Call has_locator method.
1410         * tui/tui-layout.c (show_source_disasm_command, show_data)
1411         (show_source_or_disasm_and_command): Update for bool change.
1412         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1413         (tui_win_info) <has_locator>: New method.
1414         (struct tui_source_window_base) <has_locator>: New method.
1415         (tui_win_has_locator): Don't declare.
1416         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1417         from tui_win_has_locator.
1418         (tui_source_window_base): Use false, not FALSE.
1419
1420 2019-06-25  Tom Tromey  <tom@tromey.com>
1421
1422         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1423         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1424         clear_detail method directly.
1425         (tui_clear_win_detail): Remove.
1426
1427 2019-06-25  Tom Tromey  <tom@tromey.com>
1428
1429         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1430         "this", not TUI_DISASM_WIN.
1431
1432 2019-06-25  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1435         declare.
1436         * tui/tui-winsource.c
1437         (tui_source_window_base::do_scroll_horizontal): Rename from
1438         tui_horizontal_source_scroll.
1439         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1440         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1441         from tui_vertical_data_scroll.
1442         * tui/tui-win.h (tui_scroll): Don't declare.
1443         * tui/tui-win.c (tui_win_info::forward_scroll)
1444         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1445         (tui_win_info::right_scroll): Rename and update.
1446         (tui_scroll_forward_command, tui_scroll_backward_command)
1447         (tui_scroll_left_command, tui_scroll_right_command): Update.
1448         (tui_scroll): Remove.
1449         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1450         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1451         from tui_vertical_source_scroll.
1452         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1453         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1454         from tui_vertical_disassem_scroll.
1455         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1456         do_scroll_horizontal>: New methods.
1457         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1458         Likewise.
1459         (struct tui_source_window_base): Add do_scroll_horizontal.
1460         (struct tui_source_window, struct tui_disasm_window): Add
1461         do_scroll_vertical.
1462         (struct tui_data_window, struct tui_cmd_window): Add
1463         do_scroll_horizontal and do_scroll_vertical.
1464         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1465
1466 2019-06-25  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui-data.h (struct tui_source_window_base): New struct.
1469         (struct tui_source_window): Derive from tui_source_window_base.
1470         (struct tui_disasm_window): New struct.
1471         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1472         from tui_source_window::clear_detail.
1473         (tui_source_window_base): Rename from tui_source_window.
1474         (~tui_source_window_base): Rename from ~tui_source_window.
1475         (tui_alloc_win_info): Create a tui_disasm_window.
1476
1477 2019-06-25  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-data.h (struct tui_source_window)
1480         (struct tui_data_window): Declare destructors.
1481         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1482         destructors.
1483         (tui_win_info): Simplify.
1484
1485 2019-06-25  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-winsource.c (tui_display_main)
1488         (tui_update_source_windows_with_addr)
1489         (tui_update_all_breakpoint_info): Update.
1490         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1491         (new_height_ok, parse_scrolling_args): Update.
1492         * tui/tui-stack.c (tui_show_frame_info): Update.
1493         * tui/tui-data.h (struct tui_list): Remove.
1494         (tui_source_windows): Return a reference to a std::vector.
1495         * tui/tui-data.c (source_windows): Now a std::vector.
1496         (tui_source_windows): Change return type.
1497         (tui_clear_source_windows): Rewrite.
1498         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1499         (tui_free_all_source_wins_content): Rewrite.
1500
1501 2019-06-25  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1504         (struct tui_data_window, struct tui_cmd_window): Declare
1505         clear_detail method.
1506         * tui/tui-data.c (tui_source_window::clear_detail)
1507         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1508         methods.
1509         (tui_clear_win_detail): Simplify.
1510
1511 2019-06-25  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-layout.c (make_source_window, make_disasm_window)
1514         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1515         Return the new window.
1516         (show_source_disasm_command, show_data)
1517         (show_source_or_disasm_and_command): Update.
1518
1519 2019-06-25  Tom Tromey  <tom@tromey.com>
1520
1521         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1522         parameter.  Return the new window.
1523         (show_source_disasm_command): Update and remove NULL check.
1524         (show_source_or_disasm_and_command): Update.
1525
1526 2019-06-25  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1529
1530 2019-06-25  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-data.h (struct tui_win_info): Make constructor
1533         protected.  Make destructor virtual.  Add initializers.
1534         (tui_source_window, tui_data_window, tui_cmd_window): New
1535         classes.
1536         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1537         constructor.  Add "type" parameter.
1538         (tui_source_window, tui_data_window, tui_cmd_window): New
1539         constructors.
1540         (tui_alloc_win_info): Instantiate the appropriate subclass.
1541
1542 2019-06-25  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-win.c (tui_resize_all): Use delete.
1545         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1546         destructor.
1547         (tui_free_window): Don't declare.
1548         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1549         Update.
1550
1551 2019-06-25  Tom Tromey  <tom@tromey.com>
1552
1553         * tui/tui-data.h (struct tui_win_info): Add constructor.
1554         * tui/tui-data.c (tui_alloc_win_info): Use new.
1555         (tui_free_window): Use delete.
1556
1557 2019-06-22  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1560         declare.
1561         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1562
1563 2019-06-22  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1566         declare.
1567         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1568
1569 2019-06-22  Tom de Vries  <tdevries@suse.de>
1570
1571         * dwarf2read.c (create_addrmap_from_aranges)
1572         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1573         instead of '%zu'.
1574
1575 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1576
1577         * dwarf2read.h (dwarf2_section_info_def): Remove.
1578         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1579         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1580         std::vector<dwarf2_section_info>.
1581         (struct dwo_file) <~dwo_file>: Remove.
1582         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1583         types field.
1584         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1585         (dwarf2_read_debug_names): Likewise.
1586         (create_debug_types_hash_table): Change parameter type to
1587         array_view, adjust code accordingly.
1588         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1589         (partial_die_info::fixup): Likewise.
1590         (determine_prefix): Likewise.
1591         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1592
1593 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1594
1595         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1596         gdb_bfd_ref_ptr.
1597         <~dwo_file>: Remove call to gdb_bfd_unref.
1598         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1599         gdb_bfd_ref_ptr::get.
1600
1601 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1602
1603         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1604         type to htab_up.
1605         * dwarf2read.c (struct dwo_file): Initialize fields.
1606         <~dwo_file>: New.
1607         (free_dwo_file): Remove, move content to ~dwo_file.
1608         (struct dwo_file_deleter): Remove.
1609         (dwo_file_up>: Remove custom deleter.
1610         (free_dwo_files): Remove.
1611         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1612         dwo_files.
1613         (process_skeletonless_type_units): Call unique_ptr::get.
1614         (allocate_dwo_file_hash_table): Add deleter to created hash
1615         table.  Change return type to htab_up.
1616         (lookup_dwo_file_slot): Don't memset dwo_file, call
1617         unique_ptr::get.
1618         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1619         (create_dwo_unit_in_dwp_v2): Likewise.
1620         (open_and_init_dwo_file): Likewise.
1621         (free_dwo_file_from_slot): Remove.
1622
1623 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1624
1625         * dwarf2read.h (struct dwarf2_section_info) <readin,
1626         is_virtual>: Change type to bool.
1627         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1628         true instead of 1.
1629
1630 2019-06-19  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-data.h (tui_init_content_element): Don't declare.
1633
1634 2019-06-19  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-data.h (tui_init_win_info): Don't declare.
1637
1638 2019-06-19  Tom de Vries  <tdevries@suse.de>
1639
1640         * dwarf2read.h (abstract_to_concrete): Change type to
1641         std::unordered_map<sect_offset, std::vector<sect_offset>,
1642         gdb::hash_enum<sect_offset>>.
1643
1644 2019-06-19  Tom Tromey  <tromey@adacore.com>
1645
1646         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1647         EVAL_AVOID_SIDE_EFFECTS specially.
1648
1649 2019-06-19  Tom Tromey  <tromey@adacore.com>
1650
1651         * source-cache.c (highlighter): New global.
1652         (source_cache::get_source_lines): Create a highlighter on demand.
1653
1654 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1655
1656         * defs.h (deprecated_interactive_hook): Delete declaration.
1657         * interps.c (clear_interpreter_hooks): Remove use of
1658         deprecated_interactive_hook.
1659         * top.c (deprecated_interactive_hook): Delete definition.
1660         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1661
1662 2019-06-18  Tom de Vries  <tdevries@suse.de>
1663
1664         PR gdb/24515
1665         * dwarf2read.h (abstract_to_concrete): Change type from
1666         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1667         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1668         * dwarf2read.c (read_variable): Update.
1669         (dwarf2_fetch_die_loc_sect_off): Update.
1670
1671 2019-06-17  Tom de Vries  <tdevries@suse.de>
1672
1673         PR gdb/24617
1674         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1675         accessing parent[parent_len - 1].
1676
1677 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1678
1679         PR gdb/24364
1680         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1681         call dtrace_process_dof with NULL dof.
1682
1683 2019-06-16  Tom de Vries  <tdevries@suse.de>
1684
1685         PR gdb/24445
1686         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1687
1688 2019-06-16  Tom Tromey  <tom@tromey.com>
1689
1690         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1691         (make_all_visible): Use address of member.
1692
1693 2019-06-16  Tom Tromey  <tom@tromey.com>
1694
1695         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1696         (tui_free_window, free_content, free_content_elements): Remove
1697         unnecessary cast.
1698         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1699         cast.
1700         * tui/tui-regs.c (tui_show_register_group)
1701         (tui_display_registers_from, tui_display_reg_element_at_line):
1702         Remove unnecessary cast.
1703
1704 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1705
1706         * linux-nat.c (normal_mask): Delete.
1707         (_initialize_linux_nat): Don't initialise normal_mask.
1708
1709 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1710
1711         PR gdb/24445
1712         * dwarf-index-write.h (write_psymtabs_to_index): Add
1713         dwz_basename parameter.
1714         * dwarf-index-write.c (write_gdbindex): Move file writing to
1715         write_gdbindex_1.  Change return type void.
1716         (assert_file_size): Move up, remove filename parameter.
1717         (write_gdbindex_1): New function.
1718         (write_debug_names): Change return type to void, call
1719         assert_file_size.
1720         (struct index_wip_file): New struct.
1721         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1722         file logic to index_wip_file.  Write index for dwz file if
1723         needed.
1724         (save_gdb_index_command): Pass basename of dwz file, if present.
1725         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1726         build-id of dwz file, if present.
1727         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1728         (dwarf2_get_dwz_file): Likewise.
1729         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1730         (dwarf2_get_dwz_file): Likewise.
1731
1732 2019-06-16  Tom Tromey  <tom@tromey.com>
1733
1734         * coffread.c (process_coff_symbol): Use xstrdup.
1735         * value.c (create_internalvar): Use xstrdup.
1736
1737 2019-06-16  Tom Tromey  <tom@tromey.com>
1738
1739         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1740         * breakpoint.c (stopin_command, stopat_command)
1741         (until_break_command, decode_location_default): Remove unnecessary
1742         cast.
1743         * utils.c (subset_compare): Remove unnecessary cast.
1744         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1745         cast.
1746         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1747         cast.
1748         * infcmd.c (path_command): Remove unnecessary cast.
1749         * coffread.c (decode_type): Remove unnecessary cast.
1750         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1751         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1752         * tui/tui-stack.c (tui_show_locator_content)
1753         (tui_show_frame_info): Remove unnecessary cast.
1754         * tui/tui-win.c (tui_scroll_forward_command)
1755         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1756         (parse_scrolling_args): Remove unnecessary cast.
1757         * tui/tui-data.c (init_win_info, tui_del_window)
1758         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1759         (free_content_elements): Remove unnecessary cast.
1760         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1761         unnecessary cast.
1762         * tui/tui-source.c (tui_set_source_content)
1763         (tui_vertical_source_scroll): Remove unnecessary cast.
1764         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1765         cast.
1766         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1767         * tui/tui-regs.c (tui_display_registers_from)
1768         (tui_display_register): Remove unnecessary cast.
1769         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1770         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1771         (make_visible): Remove unnecessary cast.
1772         * tui/tui-winsource.c (tui_erase_source_content)
1773         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1774         unnecessary cast.
1775         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1776         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1777         * stabsread.c (read_type, read_array_type, read_range_type):
1778         Remove unnecessary cast.
1779         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1780         (parse_symbol, parse_type, upgrade_type, parse_external)
1781         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1782         unnecessary cast.
1783         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1784
1785 2019-06-16  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui-data.c (tui_alloc_generic_win_info)
1788         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1789         checks.
1790
1791 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1792             Andrew Burgess  <andrew.burgess@embecosm.com>
1793
1794         * f-typeprint.c (f_print_type): Don't return early for not
1795         associated or not allocated types.
1796         (f_type_print_varspec_suffix): Add print_rank parameter and print
1797         ranks of array types in case they dangling.
1798         (f_type_print_base): Add print_rank parameter.
1799
1800 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1801
1802         * NEWS: Mention new MI commands.
1803         * break-catch-throw.c (enum exception_event_kind): Move to
1804         breakpoint.h.
1805         (print_mention_exception_catchpoint): Output text as a single
1806         message.
1807         (catch_exception_command_1): Rename to...
1808         (catch_exception_event): ...this, make non-static, update header
1809         command, and change some parameter types.
1810         (catch_catch_command): Update for changes to
1811         catch_exception_command_1.
1812         (catch_throw_command): Likewise.
1813         (catch_rethrow_command): Likewise.
1814         * breakpoint.c (enum exception_event_kind): Delete.
1815         * breakpoint.h (enum exception_event_kind): Moved here from
1816         break-catch-throw.c.
1817         (catch_exception_event): Declare.
1818         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1819         (mi_cmd_catch_throw): New function.
1820         (mi_cmd_catch_rethrow): New function.
1821         (mi_cmd_catch_catch): New function.
1822         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1823         'catch-catch' entries.
1824         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1825         (mi_cmd_catch_rethrow): Declare.
1826         (mi_cmd_catch_catch): Declare.
1827
1828 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1829
1830         * annotate.c (annotate_source_line): Change return type to void,
1831         update implementation to match.
1832         * annotate.h (annotate_source_line): Change return type to void,
1833         update header comment.
1834         * stack.c (print_frame_info): Don't change what frame information
1835         is printed based on whether annotations are on or not.
1836
1837 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1838
1839         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1840         (annotate_source): Make static.
1841         (annotate_source_line): Moved from source.c and renamed from
1842         identify_source_line.  Update the return type.
1843         * annotate.h (annotate_source): Delete declaration.
1844         (annotate_source_line): Declaration moved from source.h, and
1845         renamed from identify_source_line.  Return type updated.
1846         * source.c (identify_source_line): Moved to annotate.c and renamed
1847         to annotate_source_line.
1848         (info_line_command): Remove check of annotation_level.
1849         * source.h (identify_source_line): Move declaration to annotate.h
1850         and rename to annotate_source_line.
1851         * stack.c: Add 'annotate.h' include.
1852         (print_frame_info): Remove check of annotation_level before
1853         calling annotate_source_line.
1854
1855 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1856
1857         * source-cache.c (source_cache::get_plain_source_lines): Use
1858         open_source_file_with_line_charpos instead of just
1859         open_source_file, remove call to find_source_lines.
1860         (source_cache::get_source_lines): Likewise.
1861         * source.c (find_source_lines): Make static.
1862         (get_filename_and_charpos): Renamed into...
1863         (open_source_file_with_line_charpos): ..this along with changes to
1864         return a scoped_fd, and some other minor clean ups.
1865         (identify_source_line): Use open_source_file_with_line_charpos.
1866         (search_command_helper): Use open_source_file_with_line_charpos
1867         instead of just open_source_file, remove call to
1868         find_source_lines.
1869         * source.h (open_source_file_with_line_charpos): Declare new
1870         function.
1871         (find_source_lines): Delete declaration.
1872
1873 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1874
1875         * source.c (get_filename_and_charpos): Remove fullname
1876         parameter.
1877         (identify_source_line): Update call to get_filename_and_charpos.
1878
1879 2019-06-14  Tom Tromey  <tromey@adacore.com>
1880
1881         PR gdb/24502:
1882         * ui-style.h (skip_ansi_escape): Update comment.
1883         * ui-file.h (class no_terminal_escape_file): New class.
1884         * ui-file.c (no_terminal_escape_file::write)
1885         (no_terminal_escape_file::puts): New methods.
1886         * cli/cli-logging.c (handle_redirections): Use
1887         no_terminal_escape_file.
1888
1889 2019-06-14  Tom Tromey  <tromey@adacore.com>
1890
1891         * NEWS: Move convenience variable news above Python news.
1892
1893 2019-06-14  Tom Tromey  <tom@tromey.com>
1894
1895         * gnulib: Move directory to top-level.
1896         * configure.ac: Don't configure gnulib.
1897         * configure: Rebuild.
1898         * common/common-defs.h: Use new path to gnulib.
1899         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1900         (GNULIB_H): Remove.
1901         (INCGNU): Look in new gnulib location.
1902         (HFILES_NO_SRCDIR): Remove gnulib files.
1903         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1904         (generated_files): Remove GNULIB_H.
1905         ($(LIBGNU), all-lib): Remove targets.
1906         (distclean): Don't mention GNULIB_BUILDDIR.
1907         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1908
1909 2019-06-14  Tom Tromey  <tromey@adacore.com>
1910
1911         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1912         Warn if symbol file does not provide any symbols.
1913
1914 2019-06-14  Tom Tromey  <tromey@adacore.com>
1915
1916         * source.c (find_and_open_source): Respect basenames_may_differ.
1917
1918 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * annotate.c (annotate_breakpoints_invalid): Make use of
1921         scoped_restore_terminal_state.
1922         (annotate_frames_invalid): Likewise.
1923
1924 2019-06-14  Tom Tromey  <tromey@adacore.com>
1925
1926         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1927         allow assignment to an internalvar.
1928
1929 2019-06-14  Tom Tromey  <tromey@adacore.com>
1930
1931         * ada-lex.l: Allow "_" in attribute names.
1932
1933 2019-06-14  Tom Tromey  <tromey@adacore.com>
1934
1935         PR gdb/24653:
1936         * regcache.c (registers_changed): Don't call alloca.
1937         * top.c (execute_command): Don't call alloca.
1938
1939 2019-06-13  Pedro Alves  <palves@redhat.com>
1940
1941         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1942         'expression'.  When parsing an expression, error out if there's
1943         junk after "unlimited".
1944         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1945         (do_set_command): Adjust calls to is_unlimited_literal.
1946
1947 2019-06-13  Pedro Alves  <palves@redhat.com>
1948
1949         * compile/compile.c (make_compile_options_def_group): Add braces
1950         around array_view initializer.
1951         * thread.c (make_thread_apply_all_options_def_group)
1952         (make_thread_apply_all_options_def_group): Likewise.
1953
1954 2019-06-13  Pedro Alves  <palves@redhat.com>
1955
1956         * NEWS (New commands): Mention "maint test-options
1957         require-delimiter", "maint test-options unknown-is-error", "maint
1958         test-options unknown-is-operand" and "maint show
1959         test-options-completion-result".
1960         (New command options, command completion): New section.
1961         (Completion improvements): New section.
1962         Mention that you can abbreviate "unlimited".
1963
1964 2019-06-13  Pedro Alves  <palves@redhat.com>
1965
1966         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1967         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1968         * unittests/cli-utils-selftests.c (test_parse_flags)
1969         (test_parse_flags_qcs): Delete.
1970         (test_cli_utils): Don't call deleted functions.
1971
1972 2019-06-13  Pedro Alves  <palves@redhat.com>
1973
1974         * thread.c: Include "cli/cli-option.h".
1975         (tp_array_compar_ascending): Global.
1976         (tp_array_compar): Delete function.
1977         (tp_array_compar_ascending, tp_array_compar_descending): New
1978         functions.
1979         (ascending_option_def, qcs_flag_option_def)
1980         (thr_qcs_flags_option_defs)
1981         (make_thread_apply_all_options_def_group)
1982         (make_thread_apply_options_def_group): New.
1983         (thread_apply_all_command): Use gdb::option::process_options.
1984         (thread_apply_command_completer)
1985         (thread_apply_all_command_completer): New.
1986         (thread_apply_command): Use gdb::option::process_options.
1987         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1988         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1989         to generate help text of "thread apply".  Adjust "taas"'s help.
1990         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1991         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1992
1993 2019-06-13  Pedro Alves  <palves@redhat.com>
1994
1995         * thread.c (thread_apply_command): Check for invalid TID with
1996         isdigit instead of !isalpha.
1997
1998 2019-06-13  Pedro Alves  <palves@redhat.com>
1999
2000         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2001         (validate_flags_qcs): New.
2002         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2003         (validate_flags_qcs): Declare.
2004         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2005         (make_frame_apply_options_def_group): New.
2006         (frame_apply_command_count): Process options with
2007         gdb::option::process_options.
2008         (frame_apply_completer): New.
2009         (frame_apply_level_completer, frame_apply_all_completer)
2010         (frame_apply_completer): New.
2011         (_initialize_stack): Update help of "frame apply", "frame apply
2012         level", "frame apply all" and "faas" to mention supported options
2013         and install command completers.
2014         * stack.h (frame_apply_all_completer): Declare.
2015         * thread.c: Include "stack.h".
2016         (tfaas_command): Add "--".
2017         (_initialize_thread): Update help "tfaas" to mention supported
2018         options and install command completer.
2019
2020 2019-06-13  Pedro Alves  <palves@redhat.com>
2021
2022         * completer.c (complete_nested_command_line): New.
2023         (gdb_completion_word_break_characters_throw): Add assertion.
2024         * completer.h (complete_nested_command_line): Declare.
2025
2026 2019-06-13  Pedro Alves  <palves@redhat.com>
2027
2028         * stack.c (parse_backtrace_qualifiers): New.
2029         (backtrace_command): Use it.
2030         (backtrace_command_completer): Complete on qualifiers.
2031
2032 2019-06-13  Pedro Alves  <palves@redhat.com>
2033
2034         * frame.c: Include "cli/cli-option.h.
2035         (user_set_backtrace_options): New.
2036         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2037         Delete.
2038         (get_prev_frame): Adjust.
2039         (boolean_option_def, uinteger_option_def)
2040         (set_backtrace_option_defs): New.
2041         (_initialize_frame): Adjust and use
2042         gdb::option::add_setshow_cmds_for_options to install "set
2043         backtrace past-main" and "set backtrace past-entry".
2044         * frame.h: Include "cli/cli-option.h".
2045         (struct frame_print_options): Forward declare.
2046         (print_frame_arguments_all, print_frame_arguments_scalars)
2047         (print_frame_arguments_none): Declare.
2048         (print_entry_values): Delete declaration.
2049         (struct frame_print_options, user_frame_print_options): New.
2050         (struct set_backtrace_options): New.
2051         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2052         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2053         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2054         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2055         (list_args_or_locals): Add frame_print_options parameter.
2056         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2057         * python/py-framefilter.c (enumerate_args): Pass down
2058         USER_FRAME_PRINT_OPTIONS.
2059         * stack.c: Include "cli/cli-option.h".
2060         (print_frame_arguments_all, print_frame_arguments_scalars)
2061         (print_frame_arguments_none): Declare.
2062         (print_raw_frame_arguments, print_entry_values): Delete.
2063         (user_frame_print_options): New.
2064         (boolean_option_def, enum_option_def, frame_print_option_defs):
2065         New.
2066         (struct backtrace_cmd_options): New.
2067         (bt_flag_option_def): New.
2068         (backtrace_command_option_defs): New.
2069         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2070         (print_frame_arg, read_frame_arg, print_frame_args)
2071         (print_frame_info, print_frame): Add frame_print_options parameter
2072         and use it.
2073         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2074         (backtrace_command_1): Add frame_print_options and
2075         backtrace_cmd_options parameters and use them.
2076         (make_backtrace_options_def_group): New.
2077         (backtrace_command): Process command options with
2078         gdb::option::process_options.
2079         (backtrace_command_completer): New.
2080         (_initialize_stack): Extend "backtrace"'s help to mention
2081         supported options.  Install completer for "backtrace".
2082         Install some settings commands with add_setshow_cmds_for_options.
2083
2084 2019-06-13  Pedro Alves  <palves@redhat.com>
2085
2086         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2087         and that "set/show print raw frame-arguments" are now deprecated.
2088
2089         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2090         command.
2091         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2092         * stack.c (_initialize_stack): Install "set/show print
2093         raw-frame-arguments", and deprecate "set/show print raw
2094         frame-arguments".
2095         * valprint.c (_initialize_valprint): Deprecate "set/show print
2096         raw".
2097
2098 2019-06-13  Pedro Alves  <palves@redhat.com>
2099
2100         * compile/compile.c (struct compile_options): New.
2101         (compile_flag_option_def, compile_command_option_defs)
2102         (make_compile_options_def_group): New.
2103         (compile_file_command): Handle options with
2104         gdb::option::process_options.
2105         (compile_file_command_completer): New function.
2106         (compile_code_command): Handle options with
2107         gdb::option::process_options.
2108         (compile_code_command_completer): New function.
2109         (_initialize_compiler): Install completers for "compile code" and
2110         "compile file".  Mention available options in "compile code" and
2111         "compile code"'s help.
2112         * completer.c (advance_to_completion_word): New, factored out from
2113         ...
2114         (advance_to_expression_complete_word_point): ... this.
2115         (advance_to_filename_complete_word_point): New.
2116         * completer.h (advance_to_filename_complete_word_point): New
2117         declaration.
2118
2119 2019-06-13  Pedro Alves  <palves@redhat.com>
2120
2121         * compile/compile.c: Include "cli/cli-option.h".
2122         (compile_print_value): Scope data pointer is now a
2123         value_print_options pointer; adjust.
2124         (compile_print_command): Process options.  Scope data pointer is
2125         now a value_print_options pointer; adjust.
2126         (_initialize_compile): Update "compile print"'s help to include
2127         supported options.  Install a completer for "compile print".
2128         * cp-valprint.c (show_vtblprint, show_objectprint)
2129         (show_static_field_print): Delete.
2130         (_initialize_cp_valprint): Don't install "set print
2131         static-members", "set print vtbl", "set print object" here.
2132         * printcmd.c: Include "cli/cli-option.h" and
2133         "common/gdb_optional.h".
2134         (print_command_parse_format): Rework to fill in a
2135         value_print_options instead of a format_data.
2136         (print_value): Change parameter type from format_data pointer to
2137         value_print_options reference.  Adjust.
2138         (print_command_1): Process options.  Adjust to pass down a
2139         value_print_options.
2140         (print_command_completer): New.
2141         (_initialize_printcmd): Install print_command_completer as
2142         handle_brkchars completer for the "print" command.  Update
2143         "print"'s help to include supported options.
2144         * valprint.c: Include "cli/cli-option.h".
2145         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2146         here from cp-valprint.c.
2147         (boolean_option_def, uinteger_option_def)
2148         (value_print_option_defs, make_value_print_options_def_group):
2149         New.  Use gdb::option::add_setshow_cmds_for_options to install
2150         "set print elements", "set print null-stop", "set print repeats",
2151         "set print pretty", "set print union", "set print array", "set
2152         print address", "set print symbol", "set print array-indexes".
2153         * valprint.h: Include <string> and "cli/cli-option.h".
2154         (make_value_print_options_def_group): Declare.
2155         (print_value): Change parameter type from format_data pointer to
2156         value_print_options reference.
2157         (print_command_completer): Declare.
2158
2159 2019-06-13  Pedro Alves  <palves@redhat.com>
2160
2161         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2162         (COMMON_SFILES): Add maint-test-settings.c.
2163         * cli/cli-decode.c (boolean_enums): New global, factored out from
2164         ...
2165         (add_setshow_boolean_cmd): ... here.
2166         * cli/cli-decode.h (boolean_enums): Declare.
2167         * cli/cli-option.c: New file.
2168         * cli/cli-option.h: New file.
2169         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2170         factored out from ...
2171         (parse_cli_boolean_value(const char *)): ... this.
2172         (is_unlimited_literal): Change parameter type to pointer to
2173         pointer.  Adjust and advance ARG pointer.
2174         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2175         (parse_cli_var_enum): New, factored out from ...
2176         (do_set_command): ... this.  Adjust.
2177         * cli/cli-setshow.h (parse_cli_boolean_value)
2178         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2179         (parse_cli_var_enum): Declare.
2180         * cli/cli-utils.c: Include "cli/cli-option.h".
2181         (get_ulongest): New.
2182         * cli/cli-utils.h (get_ulongest): Declare.
2183         (check_for_argument): New overloads.
2184         * maint-test-options.c: New file.
2185
2186 2019-06-13  Pedro Alves  <palves@redhat.com>
2187
2188         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2189         parse a range if "-" is at the end of the string.
2190
2191 2019-06-13  Pedro Alves  <palves@redhat.com>
2192
2193         * cli/cli-setshow.c (parse_auto_binary_operation)
2194         (parse_cli_boolean_value): Don't allow "o".
2195
2196 2019-06-13  Pedro Alves  <palves@redhat.com>
2197
2198         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2199         * NEWS: Mention maint test-settings KIND.
2200         * maint-test-settings.c: New file.
2201
2202 2019-06-13  Pedro Alves  <palves@redhat.com>
2203
2204         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2205         completer.
2206         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2207         "set" completers.
2208
2209 2019-06-13  Pedro Alves  <palves@redhat.com>
2210
2211         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2212         after item.
2213
2214 2019-06-13  Pedro Alves  <palves@redhat.com>
2215
2216         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2217
2218 2019-06-13  Pedro Alves <palves@redhat.com>
2219
2220         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2221         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2222         call.
2223         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2224         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2225         calls.
2226         (check_for_argument): Skip spaces after argument.
2227
2228 2019-06-13  Pedro Alves  <palves@redhat.com>
2229
2230         * thread.c (thread_apply_command): Adjust TID parsing.
2231         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2232         detected before end of string.
2233         (tid_is_in_list): Error out if LIST is invalid.
2234
2235 2019-06-13  Pedro Alves  <palves@redhat.com>
2236
2237         * completer.c (complete_line_internal_1): Rewind completion word
2238         point.
2239         (completion_tracker::advance_custom_word_point_by): Change
2240         parameter type to int.
2241         * completer.h (completion_tracker::advance_custom_word_point_by):
2242         Likewise.
2243
2244 2019-06-13  Pedro Alves  <palves@redhat.com>
2245
2246         * completer.c (advance_to_completion_word): Handle delimiters.
2247
2248 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2249
2250         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2251
2252 2019-06-11  Tom Tromey  <tom@tromey.com>
2253
2254         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2255         (xmalloc_failed): Move to alloc.c.
2256         * alloc.c: New file.
2257         * Makefile.in (COMMON_SFILES): Add alloc.c.
2258
2259 2019-06-11  Tom Tromey  <tom@tromey.com>
2260
2261         * nat/linux-waitpid.c: Don't include server.h.
2262         (linux_debug): Remove.
2263         (my_waitpid): Update.
2264
2265 2019-06-11  Tom Tromey  <tromey@adacore.com>
2266
2267         * infcall.c (_initialize_infcall): Remove trailing newline from
2268         help.
2269         * user-regs.c (_initialize_user_regs): Remove trailing newline
2270         from help.
2271         * typeprint.c (_initialize_typeprint): Remove trailing newline
2272         from help.
2273         * reverse.c (_initialize_reverse): Remove trailing newlines from
2274         help.
2275         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2276         from help.
2277         * language.c (add_set_language_command): Remove trailing newline
2278         from help.
2279         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2280         help.
2281         * disasm.c (_initialize_disasm): Remove trailing newline from
2282         help.
2283         * top.c (init_main): Remove trailing newline from help.
2284         * interps.c (_initialize_interpreter): Remove trailing newline
2285         from help.
2286         * btrace.c (_initialize_btrace): Remove trailing newlines from
2287         help.
2288         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2289         from help.
2290         * python/python.c (_initialize_python): Remove trailing newline
2291         from help.
2292         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2293         help.
2294         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2295         from help.  Reformat some text.
2296         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2297         from help.
2298         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2299         newline from help.
2300
2301 2019-06-11  Tom Tromey  <tromey@adacore.com>
2302
2303         * darwin-nat.c (darwin_decode_exception_message)
2304         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2305
2306 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * valops.c (value_slice): Check for not allocated or not
2309         associated values.
2310
2311 2019-06-10  Tom de Vries  <tdevries@suse.de>
2312
2313         PR gdb/24618
2314         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2315         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2316         invalid.
2317
2318 2019-06-10  Tom de Vries  <tdevries@suse.de>
2319
2320         PR gdb/24611
2321         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2322         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2323
2324 2019-06-10  Tom de Vries  <tdevries@suse.de>
2325
2326         PR symtab/24545
2327         * symtab.c (struct demangled_name_entry): Add language field.
2328         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2329         static minimal symbol".  Set and use language field.
2330
2331 2019-06-10  Tom Tromey  <tromey@adacore.com>
2332
2333         * ada-lang.c (_initialize_ada_language): Update help text.
2334
2335 2019-06-10  Tom Tromey  <tromey@adacore.com>
2336
2337         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2338         with a newline.
2339         * guile/guile.c (handle_boot_error): Don't end warning with a
2340         newline.
2341         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2342         warning with a newline.
2343         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2344         newline.
2345         (s12z_frame_cache): Likewise.
2346         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2347         a newline.
2348         * solib-svr4.c (disable_probes_interface): Don't end warning with
2349         a newline.
2350         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2351         newline.
2352         * python/python.c (do_finish_initialization): Don't end warning
2353         with a newline.
2354
2355 2019-06-10  Tom Tromey  <tom@tromey.com>
2356
2357         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2358         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2359         gdbpy_enter.
2360
2361 2019-06-10  Tom Tromey  <tromey@adacore.com>
2362
2363         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2364         data.
2365         (elf_new_init): Don't call stabsread_new_init.
2366         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2367         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2368         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2369
2370 2019-06-10  Tom de Vries  <tdevries@suse.de>
2371
2372         PR symtab/16264
2373         PR symtab/24517
2374         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2375
2376 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2377
2378         * source.c (find_and_open_source): Also rewrite relative file
2379         names.
2380
2381 2019-04-26  Amos Bird  <amosbird@gmail.com>
2382
2383         * annotate.c (annotate_thread_exited): Add "thread-exited"
2384         annotation.
2385
2386 2019-06-06  Tom Tromey  <tromey@adacore.com>
2387
2388         * maint.h (class scoped_command_stats): Use
2389         DISABLE_COPY_AND_ASSIGN.
2390         <print_time>: New method.
2391         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2392         print_time.
2393         (scoped_command_stats::print_time): New method.
2394
2395 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2396
2397         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2398         instructions of lengths 6 or 8 bytes.
2399
2400 2019-06-04  Pedro Alves  <palves@redhat.com>
2401
2402         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2403
2404         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2405         * breakpoint.c (condition_completer): Likewise.
2406         * cli/cli-dump.c (scan_expression): Likewise.
2407         * common/filestuff.c (mkdir_recursive): Likewise.
2408         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2409         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2410         (gdb_abspath): Likewise.
2411         * compile/compile-cplus-types.c
2412         (compile_cplus_instance::decl_name): Likewise.
2413         * completer.c (complete_explicit_location):
2414         (signal_completer, reg_or_group_completer_1): Likewise.
2415         * cp-support.c (cp_remove_params_if_any): Likewise.
2416         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2417         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2418         * infcmd.c (strip_bg_char): Likewise.
2419         * linespec.c (copy_token_string): Likewise.
2420         * mi/mi-main.c (output_cores): Likewise.
2421         * psymtab.c (psymtab_search_name):
2422         * symfile.c (test_set_ext_lang_command): Likewise.
2423         * target.c (target_fileio_read_stralloc): Likewise.
2424         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2425         * value.c (complete_internalvar): Likewise.
2426
2427 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2428
2429         Add objfile property to gdb.Type.
2430         * NEWS: Mention Python API addition.
2431         * python/py-type.c (typy_get_objfile): New method.
2432
2433 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2434
2435         * NEWS: Mention the new set|show style [title|highlight].
2436         Mention changes to "show style", "help" and "apropos".
2437
2438 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2439
2440         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2441         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2442         instead of print_help_for_command.
2443         (print_doc_of_command): New function.
2444         (help_list): Add 'apropos -v word' suggestion.
2445         (print_help_for_command): Style the command name using title style.
2446         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2447         (_initialize_cli_cmds): Describe -v in apropos_command help.
2448
2449 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2450
2451         * cli/cli-style.h (cli_style_option): Add name in constructor,
2452         add m_name class member, add constructor with intensity,
2453         add name class function.
2454         (cli_style_option::add_setshow_commands): Remove name argument.
2455         (highlight_style, title_style): New styles.
2456         * cli/cli-style.c (do_show): New function that shows a style
2457         characteristic styling the style name with itself.
2458         (set_style_name): New function.
2459         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2460         Update all callers according to the changes in cli/cli-style.h.
2461         * utils.h (fputs_highlighted): New function.
2462         * utils.c (fputs_highlighted): Likewise.
2463
2464 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2465
2466         * NEWS: Mention new pipe command and new convenience variables.
2467
2468 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2469
2470         * cli/cli-cmds.c (pipe_command): New function.
2471         (_initialize_cli_cmds): Call add_com for pipe_command.
2472         Define | as an alias for pipe.
2473         (exit_status_set_internal_vars): New function.
2474         (shell_escape): Call exit_status_set_internal_vars.
2475         cli/cli-decode.c (find_command_name_length): Recognize | as
2476         a single character command.
2477
2478 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2479
2480         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2481         top.c (execute_command_to_ui_file): New function, mostly a copy
2482         of execute_command_to_string.
2483         (execute_command_to_string): Implement by calling
2484         execute_command_to_ui_file.
2485
2486 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2487
2488         * top.h (saved_command_line): Remove declaration.
2489         * top.c (previous_saved_command_line, previous_repeat_arguments):
2490         New variables.
2491         (saved_command_line): Make static, define together with other
2492         'repeat variables'.
2493         (dont_repeat): Clear repeat_arguments.
2494         (repeat_previous, get_saved_command_line, save_command_line):
2495         New functions.
2496         (gdb_init): Initialize saved_command_line
2497         and previous_saved_command_line.
2498         * main.c (captured_main_1): Remove saved_command_line initialization.
2499         * event-top.c (handle_line_of_input): Update to use
2500         the new 'repeat' related functions instead of direct access to
2501         saved_command_line.
2502         * command.h (repeat_previous, get_saved_command_line,
2503         save_command_line): New declarations.
2504         (dont_repeat): Add comment.
2505
2506 2019-05-30  Tom Tromey  <tromey@adacore.com>
2507
2508         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2509         Fix comment.
2510         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2511
2512 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2513
2514         PR cli/24587
2515         * completer.c (complete): Initialize variable word.
2516
2517 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2518
2519         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2520         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2521         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2522         'body' is NULL to the outter 'if', protecting the '!is_define'
2523         situation as well.
2524
2525 2019-05-29  Tom Tromey  <tromey@adacore.com>
2526
2527         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2528         (dwarf_unknown): New function.
2529         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2530         (dwarf_type_encoding_name): Use dwarf_unknown.
2531
2532 2019-05-29  Tom Tromey  <tromey@adacore.com>
2533
2534         PR c++/20020:
2535         * cp-valprint.c (cp_print_value_fields): Call
2536         cp_print_static_field inside "try".
2537
2538 2019-05-29  Tom Tromey  <tromey@adacore.com>
2539
2540         * inflow.c (struct terminal_info): Add default operator=.
2541         * configure: Rebuild.
2542         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2543         -Wdeprecated-copy-dtor, -Wredundant-move.
2544
2545 2019-05-29  Tom Tromey  <tromey@adacore.com>
2546
2547         * NEWS: Add entry.
2548         * infcmd.c (print_return_value_1): Handle finish_print
2549         option.
2550         (show_print_finish): New function.
2551         (_initialize_infcmd): Add "set/show print finish" commands.
2552         * valprint.c (user_print_options): Initialize new member.
2553         * valprint.h (struct value_print_options) <finish_print>: New
2554         member.
2555
2556 2019-05-28  Tom Tromey  <tromey@adacore.com>
2557
2558         * ada-lang.c (ada_remove_Xbn_suffix)
2559         (find_old_style_renaming_symbol)
2560         (parse_old_style_renaming): Remove.
2561         (ada_find_renaming_symbol): Don't call
2562         find_old_style_renaming_symbol.
2563         (ada_is_renaming_symbol): Rename from
2564         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2565         bool.  Now static.
2566         (ada_read_var_value): Update and simplify.
2567         * ada-exp.y (write_var_or_type): Remove old code.
2568
2569 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2570
2571         * event-top.c: Remove include comment.
2572         * inflow.c (class scoped_ignore_sigttou): Move from here...
2573         * inflow.h (class scoped_ignore_sigttou): ...to here.
2574         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2575         * top.c:  Remove include comment.
2576
2577 2019-05-27  Tom Tromey  <tom@tromey.com>
2578
2579         * NEWS: Fix typo.
2580
2581 2019-05-22  Tom Tromey  <tromey@adacore.com>
2582
2583         * target.c (target_follow_exec): Constify parameter.
2584         * target-delegates.c: Rebuild.
2585         * remote.c (remote_target::follow_exec): Constify parameter.
2586         * infrun.c (follow_exec): Constify parameter.
2587         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2588         (target_follow_exec): Likewise.
2589
2590 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2591
2592         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2593         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2594
2595 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2596
2597         * NEWS: Add debugredirect and testsuite sections.
2598
2599 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2600
2601         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2602         target descriptions using exclusively floating point register name
2603         aliases.
2604
2605 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         PR gdb/18644:
2608         * f-lang.c (build_fortran_types): Handle the case where
2609         gdbarch_floatformat_for_type returns a nullptr.
2610
2611 2019-05-21  Tom de Vries  <tdevries@suse.de>
2612
2613         PR cli/24587
2614         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2615
2616 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2617
2618         PR gdb/18644:
2619         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2620         16-byte floats.
2621         * i386-tdep.c (i386_floatformat_for_type): Use
2622         floatformats_ia64_quad for the 16-byte floating point component
2623         within a fortran 32-byte complex number.
2624
2625 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2626
2627         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2628         delete default constructor.
2629         (find_partial_die): Update to return const struct.
2630         (partial_die_parent_scope): Move variable declaration into scope
2631         of its use and change its type to auto.
2632         (guess_partial_die_structure_name): Likewise.
2633         (partial_die_info::fixup): Likewise.
2634
2635 2019-05-17  Tom Tromey  <tromey@adacore.com>
2636
2637         * source.c (find_and_open_source): Remove cast.
2638
2639 2019-05-17  Tom Tromey  <tromey@adacore.com>
2640
2641         * annotate.c (annotate_source): Make "filename" const.
2642         * annotate.h (annotate_source): Use const.
2643
2644 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2645
2646         * disasm.c (set_disassembler_options): Send errors to stderr.
2647
2648 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2649
2650         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2651         (cli_interp_base::set_logging): Check debug_redirect.
2652         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2653         * cli/cli-logging.c (debug_redirect): Add static variable.
2654         (pop_output_files): Add default param.
2655         (handle_redirections): Print debug setting.
2656         (show_logging_command): Likewise.
2657         (_initialize_cli_logging): Add debugredirect command.
2658         * interps.c (current_interp_set_logging): Add debug_redirect
2659         parameter.
2660         * interps.h (set_logging): Add debug_redirect parameter.
2661         (current_interp_set_logging): Likewise.
2662         * mi/mi-common.h: Likewise.
2663         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2664
2665 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2666             Tom Tromey  <tromey@adacore.com>
2667
2668         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2669         directly.
2670         * cli/cli-interp.h (make_logging_output): Remove declaration.
2671         * cli/cli-logging.c (make_logging_output): Remove function.
2672         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2673         directly.
2674         * ui-file.c (tee_file::tee_file): Remove bools.
2675         (tee_file::~tee_file): Remove deletes.
2676         * ui-file.h (tee_file): Remove bools.
2677
2678 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2679
2680         * mi/mi-cmds.h (mi_cmd_complete): New function.
2681         * mi/mi-main.c (mi_cmd_complete): Likewise.
2682         * mi/mi-cmds.c: Define new MI command -complete.
2683         * NEWS: Mention new -complete command.
2684
2685 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2686
2687         * completer.h (complete): New function.
2688         * completer.c (complete): Likewise.
2689         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2690         function defined in completer.h.
2691
2692 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2693
2694         * MAINTAINERS (Write After Approval): Add myself.
2695
2696 2019-05-17  Tom de Vries  <tdevries@suse.de>
2697
2698         PR gdb/24094
2699         * dwarf2read.c (struct cu_partial_die_info): New struct.
2700         (find_partial_die): Return cu_partial_die_info.
2701         (partial_die_parent_scope, guess_partial_die_structure_name)
2702         (partial_die_info::fixup): Handle new return type of find_partial_die.
2703
2704 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2705
2706         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2707         "std::string", simplifying the algorithm.
2708
2709 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2710
2711         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2712         (stap_static_probe_ops::get_probes): Likewise.
2713
2714 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2715
2716         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2717         '-')" and "else if".
2718         (stap_parse_single_operand): Join checks for
2719         "gdbarch_stap_parse_special_token_p" and
2720         "gdbarch_stap_parse_special_token" in the same "if" statement.
2721         Invert check when verifying for operation on register
2722         displacement.
2723
2724 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2725
2726         * stap-probe.c (stap_get_opcode): Update comment.
2727         (stap_get_expected_argument_type): Likewise.
2728         (handle_stap_probe): Likewise.
2729
2730 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2731
2732         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2733         return type to 'bool'.  Adjust comment.  Use 'bool' when
2734         appropriate.
2735         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2736         * stap-probe.c (stap_parse_argument_1): Likewise.
2737         (stap_is_operator): Likewise.
2738         (stap_is_generic_prefix): Likewise.
2739         (stap_is_register_prefix): Likewise.
2740         (stap_is_register_indirection_prefix): Likewise.
2741         (stap_is_integer_prefix): Likewise.
2742         (stap_generic_check_suffix): Likewise.
2743         (stap_check_integer_suffix): Likewise.
2744         (stap_check_register_suffix): Likewise.
2745         (stap_check_register_indirection_suffix): Likewise.
2746         (stap_parse_register_operand): Likewise.
2747         (stap_parse_single_operand): Likewise.
2748         (stap_parse_argument_1): Likewise.
2749         (stap_probe::get_argument_count): Likewise.
2750         (stap_is_operator): Likewise.
2751
2752 2019-05-16  Tom Tromey  <tromey@adacore.com>
2753
2754         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2755         keyword to foreach.
2756
2757 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2758
2759         * linux-thread-db.c (try_thread_db_load_1): Change return type
2760         to bool.
2761         (try_thread_db_load): Likewise.
2762         (try_thread_db_load_from_pdir_1): Likewise.
2763         (try_thread_db_load_from_pdir): Likewise.
2764         (try_thread_db_load_from_sdir): Likewise.
2765         (try_thread_db_load_from_dir): Likewise.
2766         (thread_db_load_search): Likewise.
2767         (has_libpthread): Likewise.
2768         (thread_db_load): Likewise.
2769
2770 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2771
2772         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2773         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2774         NULL, and complain/return if that's the case.
2775
2776 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2777
2778         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2779         (advance, posn, abstract_read_memory): New functions.
2780         [struct mem_read_abstraction]: New struct.
2781         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2782
2783 2019-05-14  Tom Tromey  <tromey@adacore.com>
2784
2785         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2786         value is not lval_memory.
2787
2788 2019-05-14  Tom Tromey  <tromey@adacore.com>
2789
2790         * solib.c (info_sharedlibrary_command): Style the file name.
2791
2792 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2793
2794         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2795         (aarch64_vnv_type): Likewise.
2796         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2797         * common/tdesc.c: Likewise.
2798         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2799         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2800         * features/aarch64-fpu.xml: Add ieee half view.
2801         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2802         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2803         * gdbtypes.h (struct builtin_type): Likewise.
2804         (struct objfile_type): Likewise.
2805
2806 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2807
2808         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2809         typo.
2810         * location.h (string_to_event_location): Likewise.
2811
2812 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2813
2814         GDB 8.3 released.
2815
2816 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2817
2818         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2819         New variable declaration.
2820         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2821         New variable.
2822         (print_one_breakpoint): Use ui_out::test_flags and new global
2823         variable to compute use_fixed_output.
2824         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2825         Remove.
2826         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2827         (mi_multi_location_breakpoint_output_fixed): Remove.
2828         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2829         new variable.
2830         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2831         fix_multi_location_breakpoint_output flag if version >= 3.
2832         * ui-out.h (enum ui_out_flag)
2833         <fix_multi_location_breakpoint_output>: New enumerator.
2834
2835 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2836
2837         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2838
2839 2019-05-10  Tom Tromey  <tromey@adacore.com>
2840
2841         * ada-lang.c (catch_ada_completer): New function.
2842         (_initialize_ada_language): Use it.
2843
2844 2019-05-10  Tom Tromey  <tromey@adacore.com>
2845
2846         * thread.c (print_thread_info): Make "requested_threads" const.
2847         * gdbthread.h (print_thread_info): Make "requested_threads"
2848         const.
2849         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2850         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2851
2852 2019-05-08  Tom Tromey  <tom@tromey.com>
2853
2854         * gdbtypes.c (objfile_type_data): Change type.
2855         (objfile_type, _initialize_gdbtypes): Update.
2856
2857 2019-05-08  Tom Tromey  <tom@tromey.com>
2858
2859         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2860         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2861         (_initialize_dwarf2_frame): Update.
2862
2863 2019-05-08  Tom Tromey  <tom@tromey.com>
2864
2865         * objc-lang.c (objc_objfile_data): Change type.
2866         (find_methods): Update.
2867         (_initialize_objc_lang): Remove.
2868
2869 2019-05-08  Tom Tromey  <tom@tromey.com>
2870
2871         * stabsread.c (rs6000_builtin_type_data): Change type.
2872         (rs6000_builtin_type, _initialize_stabsread): Update.
2873
2874 2019-05-08  Tom Tromey  <tom@tromey.com>
2875
2876         * mips-tdep.c (mips_pdr_data): Remove.
2877         (_initialize_mips_tdep): Update.
2878
2879 2019-05-08  Tom Tromey  <tom@tromey.com>
2880
2881         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2882         (hppa_init_objfile_priv_data, read_unwind_info)
2883         (find_unwind_entry, _initialize_hppa_tdep): Update.
2884
2885 2019-05-08  Tom Tromey  <tom@tromey.com>
2886
2887         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2888         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2889         on obstack.
2890         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2891
2892 2019-05-08  Tom Tromey  <tom@tromey.com>
2893
2894         * mdebugread.c (basic_type_data): Change type.
2895         (basic_type, _initialize_mdebugread): Update.
2896
2897 2019-05-08  Tom Tromey  <tom@tromey.com>
2898
2899         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2900
2901 2019-05-08  Tom Tromey  <tom@tromey.com>
2902
2903         * nto-tdep.c (nto_inferior_data_reg): Change type.
2904         (nto_inferior_data): Update.
2905         (nto_inferior_data_cleanup, nto_new_inferior_data)
2906         (_initialize_nto_tdep): Remove.
2907         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2908
2909 2019-05-08  Tom Tromey  <tom@tromey.com>
2910
2911         * ada-lang.c (struct ada_inferior_data): Add initializers.
2912         (ada_inferior_data): Change type.
2913         (ada_inferior_data_cleanup): Remove.
2914         (get_ada_inferior_data, ada_inferior_exit)
2915         (struct ada_pspace_data): Add initializers, destructor.
2916         (ada_pspace_data_handle): Change type.
2917         (get_ada_pspace_data): Update.
2918         (ada_pspace_data_cleanup): Remove.
2919
2920 2019-05-08  Tom Tromey  <tom@tromey.com>
2921
2922         * coffread.c (struct coff_symfile_info): Add initializers.
2923         (coff_objfile_data_key): Move lower.  Change type.
2924         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2925         Update.
2926         (coff_free_info): Remove.
2927
2928 2019-05-08  Tom Tromey  <tom@tromey.com>
2929
2930         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2931         (fbsd_pspace_data_handle): Move lower.  Change type.
2932         (get_fbsd_pspace_data): Update.
2933         (fbsd_pspace_data_cleanup): Remove.
2934         (_initialize_fbsd_tdep): Update.
2935
2936 2019-05-08  Tom Tromey  <tom@tromey.com>
2937
2938         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2939         (get_ada_tasks_pspace_data): Update.
2940         (ada_tasks_pspace_data_cleanup): Remove.
2941         (_initialize_tasks): Update.
2942         (ada_tasks_inferior_data_handle): Change type.
2943         (get_ada_tasks_inferior_data): Update.
2944         (ada_tasks_inferior_data_cleanup): Remove.
2945         (struct ada_tasks_pspace_data): Add initializers.
2946
2947 2019-05-08  Tom Tromey  <tom@tromey.com>
2948
2949         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2950         * symfile-debug.c (debug_sym_get_probes): Change type.
2951         * stap-probe.c (handle_stap_probe):
2952         (stap_static_probe_ops::get_probes): Change type.
2953         * probe.h (class static_probe_ops) <get_probes>: Change type.
2954         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2955         (parse_probes_in_pspace): Update.
2956         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2957         Update.
2958         (any_static_probe_ops::get_probes): Change type.
2959         * elfread.c (elfread_data): New typedef.
2960         (probe_key): Change type.
2961         (elf_get_probes): Likewise.  Update.
2962         (probe_key_free): Remove.
2963         (_initialize_elfread): Update.
2964         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2965         Change type.
2966         (dtrace_process_dof_probe, dtrace_process_dof)
2967         (dtrace_static_probe_ops::get_probe): Change type.
2968
2969 2019-05-08  Tom Tromey  <tom@tromey.com>
2970
2971         * xcoffread.c (struct xcoff_symfile_info): Rename from
2972         coff_symfile_info.  Add initializers.
2973         (xcoff_objfile_data_key): Move lower.  Change type.
2974         (XCOFF_DATA): Rewrite.
2975         (xcoff_free_info): Remove.
2976         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2977         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2978         (xcoff_initial_scan): Update.
2979
2980 2019-05-08  Tom Tromey  <tom@tromey.com>
2981
2982         * solib-svr4.c (struct svr4_info): Add initializers and
2983         destructor.
2984         <probes_table>: Now an htab_up.
2985         (solib_svr4_pspace_data): Change type.
2986         (free_probes_table): Simplify.
2987         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2988         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2989         (probes_table_remove_objfile_probes, register_solib_event_probe)
2990         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2991         (_initialize_svr4_solib): Update.
2992
2993 2019-05-08  Tom Tromey  <tom@tromey.com>
2994
2995         * remote.c (remote_pspace_data): Change type.
2996         (remote_pspace_data_cleanup): Remove.
2997         (get_remote_exec_file, set_pspace_remote_exec_file)
2998         (_initialize_remote): Update.
2999
3000 2019-05-08  Tom Tromey  <tom@tromey.com>
3001
3002         * breakpoint.c (breakpoint_objfile_key): Change type.
3003         (get_breakpoint_objfile_data): Update.
3004         (free_breakpoint_objfile_data): Remove.
3005         (_initialize_breakpoint): Update.
3006
3007 2019-05-08  Tom Tromey  <tom@tromey.com>
3008
3009         * linux-tdep.c (struct linux_info): Add initializers.
3010         (linux_inferior_data): Move.  Change type.
3011         (invalidate_linux_cache_inf): Update.
3012         (linux_inferior_data_cleanup): Remove.
3013         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3014
3015 2019-05-08  Tom Tromey  <tom@tromey.com>
3016
3017         * auxv.c (auxv_inferior_data): Move.  Change type.
3018         (auxv_inferior_data_cleanup): Remove.
3019         (invalidate_auxv_cache_inf): Rewrite.
3020         (get_auxv_inferior_data, _initialize_auxv): Update.
3021
3022 2019-05-08  Tom Tromey  <tom@tromey.com>
3023
3024         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3025         (symfile_debug_objfile_data_key): Change type.
3026         (symfile_debug_installed, debug_qf_has_symbols)
3027         (debug_qf_find_last_source_symtab)
3028         (debug_qf_forget_cached_source_info)
3029         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3030         (debug_qf_print_stats, debug_qf_dump)
3031         (debug_qf_expand_symtabs_for_function)
3032         (debug_qf_expand_all_symtabs)
3033         (debug_qf_expand_symtabs_with_fullname)
3034         (debug_qf_map_matching_symbols)
3035         (debug_qf_expand_symtabs_matching)
3036         (debug_qf_find_pc_sect_compunit_symtab)
3037         (debug_qf_map_symbol_filenames)
3038         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3039         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3040         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3041         (debug_sym_read_linetable, debug_sym_relocate): Update.
3042         (symfile_debug_free_objfile): Remove.
3043         (install_symfile_debug_logging, _initialize_symfile_debug):
3044         Update.
3045
3046 2019-05-08  Tom Tromey  <tom@tromey.com>
3047
3048         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3049         allocate_on_obstack.
3050         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3051         (get_dwarf2_per_objfile): Update.
3052         (set_dwarf2_per_objfile): Remove.
3053         (dwarf2_has_info, dwarf2_get_section_info): Update.
3054         (dwarf2_free_objfile): Remove.
3055         (_initialize_dwarf2_read): Update.
3056
3057 2019-05-08  Tom Tromey  <tom@tromey.com>
3058
3059         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3060         initializers.
3061         <unsupported_script_warning_printed,
3062         script_not_found_warning_printed>: Now bool.
3063         (auto_load_pspace_data): Change type.
3064         (~auto_load_pspace_info): Rename from
3065         auto_load_pspace_data_cleanup.
3066         (get_auto_load_pspace_data, init_loaded_scripts_info)
3067         (clear_section_scripts, maybe_print_unsupported_script_warning)
3068         (maybe_print_script_not_found_warning, _initialize_auto_load):
3069         Update.
3070
3071 2019-05-08  Tom Tromey  <tom@tromey.com>
3072
3073         * objfiles.c (objfile_pspace_info): Add destructor and
3074         initializers.
3075         (objfiles_pspace_data): Change type.
3076         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3077         (get_objfile_pspace_data): Update.
3078         (objfiles_bfd_data): Change type.
3079         (get_objfile_bfd_data): Update.
3080         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3081
3082 2019-05-08  Tom Tromey  <tom@tromey.com>
3083
3084         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3085         Change type.
3086         (get_catch_syscall_inferior_data): Update.
3087         (catch_syscall_inferior_data_cleanup): Remove.
3088         (_initialize_break_catch_syscall): Update.
3089
3090 2019-05-08  Tom Tromey  <tom@tromey.com>
3091
3092         * inflow.c (struct terminal_info): Add destructor and
3093         initializers.
3094         (inflow_inferior_data): Change type.
3095         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3096         (get_inflow_inferior_data, inflow_inferior_exit)
3097         (swap_terminal_info, _initialize_inflow): Update.
3098
3099 2019-05-08  Tom Tromey  <tom@tromey.com>
3100
3101         * target-dcache.c (target_dcache_cleanup): Remove.
3102         (target_dcache_aspace_key): Change type.
3103         (target_dcache_init_p, target_dcache_invalidate)
3104         (target_dcache_get, target_dcache_get_or_init)
3105         (_initialize_target_dcache): Update.
3106         * dcache.h (struct dcache_deleter): New.
3107
3108 2019-05-08  Tom Tromey  <tom@tromey.com>
3109
3110         * symtab.c (struct symbol_cache): Add destructor and
3111         initializers.
3112         (symbol_cache_key): Move.  Change type.
3113         (make_symbol_cache, free_symbol_cache): Remove.
3114         (get_symbol_cache): Update.
3115         (symbol_cache_cleanup): Remove.
3116         (ALL_PSPACES, symbol_cache_flush)
3117         (maintenance_print_symbol_cache)
3118         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3119         Update.
3120
3121 2019-05-08  Tom Tromey  <tom@tromey.com>
3122
3123         * symtab.c (struct main_info): Add destructor and initializers.
3124         (main_progspace_key): Move.  Change type.
3125         (get_main_info): Update.
3126         (main_info_cleanup): Remove.
3127         (_initialize_symtab): Update.
3128
3129 2019-05-08  Tom Tromey  <tom@tromey.com>
3130
3131         * registry.h (DECLARE_REGISTRY): Define the _key class.
3132
3133 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3134
3135         * NEWS: Merge two 'New commands' sections.
3136
3137 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3138
3139         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3140         parameter and use Ada language definition instead.
3141         (ada_val_print_ptr): Remove unused language parameter.
3142         (ada_val_print_num): Remove language parameter and use Ada language
3143         definition instead.
3144         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3145         parameter.
3146         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3147         parameter and use Ada language definition instead.
3148         (ada_val_print_1): Update all ada_val_print_xxx calls.
3149         Remove language parameter.
3150         (ada_val_print): Update ada_val_print_1 call.
3151
3152 2019-05-08  Tom Tromey  <tromey@adacore.com>
3153
3154         * remote.c (remote_hw_watchpoint_limit)
3155         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3156         Now static.
3157
3158 2019-05-08  Tom Tromey  <tromey@adacore.com>
3159
3160         * maint.c (_initialize_maint_cmds): Move initialization code to
3161         remote.c.
3162         (watchdog, show_watchdog): Move to remote.c.
3163         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3164         "watchdog" static.
3165         (_initialize_remote): Move initialization code from maint.c.
3166         * defs.h (watchdog): Don't declare.
3167
3168 2019-05-08  Tom Tromey  <tromey@adacore.com>
3169
3170         * tui/tui-interp.c: Include main.h.
3171         * interps.c: Include main.h.
3172         * main.h (interpreter_p): Declare.
3173         * defs.h (interpreter_p): Don't declare.
3174
3175 2019-05-08  Tom Tromey  <tromey@adacore.com>
3176
3177         * dwarf2loc.c: Include dwarf2read.h.
3178         * defs.h (read_unsigned_leb128): Don't declare.
3179         * dwarf2read.h (read_unsigned_leb128): Declare.
3180
3181 2019-05-08  Tom Tromey  <tromey@adacore.com>
3182
3183         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3184         method.
3185
3186 2019-05-08  Tom Tromey  <tromey@adacore.com>
3187
3188         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3189         when no wrap column is set.
3190
3191 2019-05-08  Tom Tromey  <tromey@adacore.com>
3192
3193         * c-lang.c (c_get_string): Handle non-C-style arrays.
3194
3195 2019-05-08  Tom Tromey  <tromey@adacore.com>
3196
3197         * typeprint.c (print_offset_data::update): Print the bit offset,
3198         not the number of bits remaining.
3199
3200 2019-05-08  Tom Tromey  <tromey@adacore.com>
3201
3202         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3203         padding at end of comment.
3204
3205 2019-05-08  Tom Tromey  <tromey@adacore.com>
3206
3207         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3208         Compare main types.
3209
3210 2019-05-06  Tom Tromey  <tom@tromey.com>
3211
3212         * common/scoped_mmap.c: Include common-defs.h.
3213         * common/scoped_mmap.h: Don't include config.h.
3214
3215 2019-05-04  Tom Tromey  <tom@tromey.com>
3216
3217         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3218         (struct aarch64_call_info): Add initializers.
3219         <si>: Now a std::vector.
3220         (pass_on_stack, aarch64_push_dummy_call): Update.
3221
3222 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3223             Tom Tromey  <tom@tromey.com>
3224
3225         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3226         (ppc_threads): Now a std::vector.  Now static.
3227         (hwdebug_find_thread_points_by_tid)
3228         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3229         Update.
3230
3231 2019-05-04  Tom Tromey  <tom@tromey.com>
3232
3233         * arc-tdep.c (arc_tdesc_init): Return bool.
3234
3235 2019-05-04  Tom Tromey  <tom@tromey.com>
3236
3237         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3238         Use gdb_assert_not_reached.
3239
3240 2019-05-04  Tom Tromey  <tom@tromey.com>
3241
3242         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3243         "false".
3244
3245 2019-05-04  Tom Tromey  <tom@tromey.com>
3246
3247         * arc-tdep.c (arc_tdesc_init): Use bool.
3248
3249 2019-05-04  Tom Tromey  <tom@tromey.com>
3250
3251         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3252
3253 2019-05-04  Tom Tromey  <tom@tromey.com>
3254
3255         * cli/cli-cmds.c (valid_command_p): Return bool.
3256
3257 2019-05-04  Tom Tromey  <tom@tromey.com>
3258
3259         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3260         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3261
3262 2019-05-04  Raul Tambre  <raul@tambre.ee>
3263
3264         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3265         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3266         operator for comparison.
3267
3268 2019-05-04  Tom Tromey  <tom@tromey.com>
3269
3270         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3271         (lookup_partial_symbol, print_partial_symbols)
3272         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3273         (psymbol_compare): Update.
3274         (add_psymbol_to_bcache): Clear the entire psymbol.
3275         (maintenance_check_psymtabs): Update.
3276         * psympriv.h (struct partial_symbol): Don't derive from
3277         general_symbol_info.
3278         <obj_section, unrelocated_address, address,
3279         set_unrelocated_address>: Update.
3280         <ginfo>: New member.
3281         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3282         (debug_names::write_psymbols): Update.
3283
3284 2019-05-04  Tom de Vries  <tdevries@suse.de>
3285
3286         * contrib/cc-with-tweaks.sh: Support -n arg.
3287
3288 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3289
3290         * corelow.c (core_target::detach): Ensure frame cache and
3291         register caches are cleared.
3292         inferior.c (exit_inferior_1): Likewise.
3293
3294 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3295             Tom Tromey  <tom@tromey.com>
3296
3297         * dictionary.c (collate_pending_symbols_by_language): Remove
3298         "struct" from foreach.
3299         * symtab.c (lookup_global_symbol_from_objfile)
3300         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3301         foreach.
3302         * ser-tcp.c (net_open): Remove "struct" from foreach.
3303         * objfiles.c (objfile_relocate, objfile_rebase)
3304         (objfile_has_symbols): Remove "struct" from foreach.
3305         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3306         from foreach.
3307         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3308         foreach.
3309         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3310         "struct" from foreach.
3311         * ada-lang.c (create_excep_cond_exprs)
3312         (ada_exception_catchpoint_cond_string): Remove "struct" from
3313         foreach.
3314
3315 2019-05-03  Tom Tromey  <tromey@adacore.com>
3316
3317         * ada-exp.y (convert_char_literal): Check suffix of each
3318         enumerator.
3319
3320 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3321
3322         PR ada/21406:
3323         * ada-exp.y (yywrap): Don't define.
3324         * ada-lex.l (%option): Add noyywrap
3325         (yywrap): Remove.
3326
3327 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3328
3329         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3330         _WIN32_WINNT to the XP level, unless already defined to a higher
3331         level.
3332
3333         * unittests/parse-connection-spec-selftests.c:
3334         * ser-tcp.c:
3335         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3336         override.
3337
3338         * symfile.c (find_separate_debug_file): Remove colon from the
3339         drive spec of DOS/Windows file names of the target, so that the
3340         file name produced from DEBUGDIR and the target's directory will
3341         be valid on DOS/Windows systems.
3342
3343 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3344
3345         * rust-lang.c (val_print_struct): Handle printing structures
3346         containing strings.
3347
3348 2019-05-02  Tom Tromey  <tromey@adacore.com>
3349
3350         * valarith.c (_initialize_valarith): Remove.
3351
3352 2019-05-01  Tom Tromey  <tromey@adacore.com>
3353
3354         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3355         bitfields.
3356
3357 2019-05-01  Tom Tromey  <tromey@adacore.com>
3358
3359         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3360         for big-endian copies.
3361
3362 2019-04-30  Ali Tamur  <tamur@google.com>
3363         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3364         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3365         (read_3_bytes): New function.
3366
3367 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3368
3369         * windows-nat.c (main_thread_id): Delete.
3370         (handle_output_debug_string): Replace main_thread_id by
3371         current_event.dwThreadId.
3372         (fake_create_process): Likewise.
3373         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3374         Do not set main_thread_id.
3375         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3376         current_event.dwThreadId.
3377         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3378
3379 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3380
3381         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3382         Use current_event.dwThreadId instead of main_thread_id.
3383
3384 2019-04-30  Tom Tromey  <tromey@adacore.com>
3385
3386         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3387         (create_excep_cond_exprs): Iterate over program spaces.
3388         (ada_exception_catchpoint_cond_string): Examine all minimal
3389         symbols for exception types.
3390
3391 2019-04-30  Tom Tromey  <tromey@adacore.com>
3392
3393         PR c++/24470:
3394         * dwarf2read.c (process_structure_scope): Handle case where type
3395         has template parameters but no symbol was created.
3396
3397 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3398             Chris January  <chris.january@arm.com>
3399
3400         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3401         qualifier.
3402         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3403
3404 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3405
3406         * f-typeprint.c (f_print_type): Update rules for printing
3407         whitespace.
3408         (f_type_print_varspec_suffix): Likewise.
3409
3410 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3411             Chris January  <chris.january@arm.com>
3412
3413         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3414         function arguments.
3415
3416 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3417
3418         * f-lang.c (build_fortran_types): Change name of void type to
3419         lower case.
3420         * f-typeprint.c (f_type_print_base): Print the name of the void
3421         type, rather than a fixed string.
3422         * f-valprint.c (f_decorations): Use lower case void string.
3423
3424 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3425             Chris January  <chris.january@arm.com>
3426
3427         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3428         types for Fortran.
3429
3430 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3431             Chris January  <chris.january@arm.com>
3432             David Lecomber  <david.lecomber@arm.com>
3433
3434         * f-exp.y (BINOP_INTRINSIC): New token.
3435         (exp): New parser rule handling BINOP_INTRINSIC.
3436         (f77_keywords): Add new builtin procedures.
3437         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3438         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3439         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3440         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3441         (print_unop_subexp_f): New function.
3442         (print_binop_subexp_f): New function.
3443         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3444         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3445         (dump_subexp_body_f): Likewise.
3446         (operator_check_f): Likewise.
3447         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3448         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3449
3450 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3451
3452         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3453         UNOP_KIND.
3454         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3455         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3456         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3457         (operator_length_f): New fuction.
3458         (print_subexp_f): New function.
3459         (op_name_f): New function.
3460         (dump_subexp_body_f): New function.
3461         (operator_check_f): New function.
3462         (exp_descriptor_f): Replace standard expression handling functions
3463         with new functions.
3464         * gdb/fortran-operator.def: New file.
3465         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3466         * gdb/std-operator.def: Remove UNOP_KIND.
3467
3468 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3469
3470         * std-operator.def: Remove unbalanced, stray double quote
3471         character.
3472
3473 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3474             Chris January  <chris.january@arm.com>
3475             Daniel Everett  <daniel.everett@arm.com>
3476             Nick Forrington  <nick.forrington@arm.com>
3477             Richard Bunt  <richard.bunt@arm.com>
3478
3479         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3480         of depth when printing anonymous structs or unions.
3481         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3482         Don't print either the top-level value, or the children if the
3483         max-depth is exceeded.
3484         (ppscm_print_children): When printing the key of a map, allow one
3485         extra level of depth.
3486         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3487         print either the top-level value, or the children if the max-depth
3488         is exceeded.
3489         (print_children): When printing the key of a map, allow one extra
3490         level of depth.
3491         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3492         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3493         (user_print_options): Initialise max_depth field.
3494         (val_print_scalar_or_string_type_p): New function.
3495         (val_print): Check to see if the max depth has been reached.
3496         (val_print_check_max_depth): Define new function.
3497         (show_print_max_depth): New function.
3498         (_initialize_valprint): Add 'print max-depth' option.
3499         * valprint.h (struct value_print_options) <max_depth>: New field.
3500         (val_print_check_max_depth): Declare new function.
3501         * NEWS: Document new feature.
3502
3503 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3504
3505         * ada-lang.c (ada_language_defn): Initialise new field.
3506         * c-lang.c (c_is_string_type_p): New function.
3507         (c_language_defn): Initialise new field.
3508         (cplus_language_defn): Initialise new field.
3509         (asm_language_defn): Initialise new field.
3510         (minimal_language_defn): Initialise new field.
3511         * c-lang.h (c_is_string_type_p): Declare new function.
3512         * d-lang.c (d_language_defn): Initialise new field.
3513         * f-lang.c (f_is_string_type_p): New function.
3514         (f_language_defn): Initialise new field.
3515         * go-lang.c (go_is_string_type_p): New function.
3516         (go_language_defn): Initialise new field.
3517         * language.c (default_is_string_type_p): New function.
3518         (unknown_language_defn): Initialise new field.
3519         (auto_language_defn): Initialise new field.
3520         * language.h (struct language_defn) <la_is_string_type_p>: New
3521         member variable.
3522         (default_is_string_type_p): Declare new function.
3523         * m2-lang.c (m2_language_defn): Initialise new field.
3524         * objc-lang.c (objc_language_defn): Initialise new field.
3525         * opencl-lang.c (opencl_language_defn): Initialise new field.
3526         * p-lang.c (pascal_is_string_type_p): New function.
3527         (pascal_language_defn): Initialise new field.
3528         * rust-lang.c (rust_is_string_type_p): New function.
3529         (rust_language_defn): Initialise new field.
3530
3531 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3532
3533         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3534         New field.
3535         * ada-lang.c (ada_language_defn): Initialise new field.
3536         * c-lang.c (c_language_defn): Likewise.
3537         (cplus_language_defn): Likewise.
3538         (asm_language_defn): Likewise.
3539         (minimal_language_defn): Likewise.
3540         * d-lang.c (d_language_defn): Likewise.
3541         * f-lang.c (f_language_defn): Likewise.
3542         * go-lang.c (go_language_defn): Likewise.
3543         * language.c (unknown_language_defn): Likewise.
3544         (auto_language_defn): Likewise.
3545         * m2-lang.c (m2_language_defn): Likewise.
3546         * objc-lang.c (objc_language_defn): Likewise.
3547         * opencl-lang.c (opencl_language_defn): Likewise.
3548         * p-lang.c (pascal_language_defn): Likewise.
3549         * rust-lang.c (rust_language_defn): Likewise.
3550
3551 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3552
3553         * ada-lang.c (ada_is_character_type): Change return type to bool.
3554         (ada_is_string_type): Likewise.
3555         * ada-lang.h (ada_is_character_type): Update declaration
3556         (ada_is_string_type): Likewise.
3557
3558 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3559
3560         Support style in 'frame|thread apply'
3561
3562         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3563         * record.c (record_start, record_stop): Update callers of
3564         execute_command_to_string with false.
3565         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3566         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3567         methods.
3568         (class string_file): New constructor with term_out parameter.
3569         Override methods term_out and can_emit_style_escape.  New member
3570         term_out.
3571         (class stdio_file): Override can_emit_style_escape.
3572         (class tee_file): Override term_out and can_emit_style_escape.
3573         * utils.h (can_emit_style_escape): Remove.
3574         * utils.c (can_emit_style_escape): Likewise.
3575         Update all callers of can_emit_style_escape (SOMESTREAM) to
3576         SOMESTREAM->can_emit_style_escape.
3577         * source-cache.c (source_cache::get_source_lines): Likewise.
3578         * stack.c (frame_apply_command_count): Call execute_command_to_string
3579         passing the term_out characteristic of the current gdb_stdout.
3580         * thread.c (thr_try_catch_cmd): Likewise.
3581         * top.c (execute_command_to_string): pass term_out parameter
3582         to construct the string_file for the command output.
3583         * ui-file.c (term_cli_styling): New function (most code moved
3584         from utils.c can_emit_style_escape).
3585         (string_file::string_file, string_file::can_emit_style_escape,
3586         stdio_file::can_emit_style_escape, tee_file::term_out,
3587         tee_file::can_emit_style_escape): New functions.
3588
3589 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3590
3591         * NEWS: Mention the new set|show may-call-functions.
3592         * infcall.c (may_call_functions_p): New variable.
3593         (show_may_call_functions_p): New function.
3594         (call_function_by_hand_dummy): Throws an error if not
3595         may-call-functions.
3596         (_initialize_infcall): Call add_setshow_boolean_cmd for
3597         may-call-functions.
3598
3599 2019-04-25  Keith Seitz  <keiths@redhat.com>
3600
3601         PR c++/24367
3602         * cp-support.c (inspect_type): Don't attempt substitutions
3603         of symbol with the same name.
3604
3605 2019-04-25  Tom Tromey  <tromey@adacore.com>
3606
3607         PR gdb/24475:
3608         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3609         static.
3610
3611 2019-04-25  Tom Tromey  <tromey@adacore.com>
3612
3613         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3614         rvalue reference.
3615         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3616         (gdb_xml_parser::parse): Use std::move.
3617         * python/python-internal.h (gdbpy_convert_exception): Take a const
3618         reference.
3619         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3620         std::move.
3621         * python/py-utils.c (gdbpy_convert_exception): Take a const
3622         reference.
3623         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3624         Use std::move.
3625         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3626         Use std::move.
3627         * mi/mi-main.c (mi_print_exception): Take a const reference.
3628         * main.c (handle_command_errors): Take a const reference.
3629         * linespec.c (parse_linespec): Use std::move.
3630         * infcall.c (run_inferior_call): Use std::move.
3631         (call_function_by_hand_dummy): Use std::move.
3632         * exec.c (try_open_exec_file): Use std::move.
3633         * exceptions.h (exception_print, exception_fprintf)
3634         (exception_print_same): Update.
3635         * exceptions.c (print_exception, exception_print)
3636         (exception_fprintf, exception_print_same): Change parameters to
3637         const reference.
3638         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3639         * common/new-op.c: Use std::move.
3640         * common/common-exceptions.h (struct gdb_exception): Add move
3641         constructor.
3642         (struct gdb_exception_error, struct gdb_exception_quit, struct
3643         gdb_quit_bad_alloc): Change constructor to move constructor.
3644         (throw_exception): Change parameter to rvalue reference.
3645         * common/common-exceptions.c (throw_exception): Take rvalue
3646         reference.
3647         * cli/cli-interp.c (safe_execute_command): Use std::move.
3648         * breakpoint.c (insert_bp_location, location_to_sals): Use
3649         std::move.
3650
3651 2019-04-25  Tom Tromey  <tromey@adacore.com>
3652
3653         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3654         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3655         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3656         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3657         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3658         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3659         guile/scm-value.c: Use unpack.
3660         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3661         gdbscm_gdb_exception.
3662         (gdbscm_throw_gdb_exception): Likewise.
3663         (struct gdbscm_gdb_exception): New.
3664         (unpack): New function.
3665         (gdbscm_wrap): Use unpack.
3666
3667 2019-04-25  Tom Tromey  <tromey@adacore.com>
3668
3669         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3670         (gdb_rl_callback_handler): Use std::move.
3671         * common/common-exceptions.h (struct gdb_exception): Add move
3672         assignment operator.
3673         (throw_exception_sjlj): Change "exception" to const reference.
3674         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3675         (throw_exception_sjlj): Change "exception" to const reference.
3676
3677 2019-04-25  Tom Tromey  <tromey@adacore.com>
3678
3679         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3680         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3681         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3682         Update.
3683         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3684         Update.
3685         * mi/mi-interp.c (mi_interp::exec): Update.
3686         * linespec.c (parse_linespec): Update.
3687         * infcall.c (run_inferior_call): Update.
3688         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3689         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3690         (gdbscm_lookup_global_symbol): Update.
3691         * guile/scm-param.c (gdbscm_parameter_value): Update.
3692         * guile/scm-frame.c (gdbscm_frame_read_register)
3693         (gdbscm_frame_read_var): Update.
3694         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3695         * exec.c (try_open_exec_file): Update.
3696         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3697         (gdb_rl_callback_handler): Update.
3698         * common/common-exceptions.h (exception_none): Don't declare.
3699         * common/common-exceptions.c (exception_none): Don't define.
3700         (struct catcher) <exception>: Update.
3701         * cli/cli-interp.c (safe_execute_command): Update.
3702         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3703
3704 2019-04-25  Ali Tamur  <tamur@google.com>
3705
3706         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3707         (read_attribute_value): Likewise.
3708         (dwarf2_read_addr_index): Update comment.
3709         (read_str_index): Add DW_FORM_strx.
3710         (dwarf2_string_attr): Likewise.
3711         (dwarf2_const_value_attr): Likewise.
3712         (dump_die_shallow): Likewise.
3713         (dwarf2_fetch_constant_bytes): Likewise.
3714         (skip_form_bytes): Likewise.
3715         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3716
3717 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3718
3719         PR corefiles/11608
3720         PR corefiles/18187
3721         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3722         OFFSET.  Verify if current mapping contains an ELF header.
3723         (linux_find_memory_regions_full): Adjust call to
3724         dump_mapping_p.
3725
3726 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3727             Kang Li <kanglictf@gmail.com>
3728
3729         PR gdb/21600
3730
3731         * dwarf2-frame.c (read_initial_length): Be consistent about using
3732         unsigned representation of length.
3733         (decode_frame_entry_1): Likewise.  Check for wraparound of
3734         end pointer as well as buffer overflow.
3735
3736 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3737
3738         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3739         "vq".
3740
3741 2019-04-24  Tom Tromey  <tromey@adacore.com>
3742
3743         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3744
3745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * s12z-tdep.c (s12z_unwind_pc): Delete.
3748         (s12z_unwind_sp): Delete.
3749         (s12z_gdbarch_init): Don't register deleted functions with
3750         gdbarch.
3751
3752 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3753
3754         * rl78-tdep.c (rl78_unwind_sp): Delete.
3755         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3756
3757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3760         (xstormy16_unwind_pc): Delete.
3761         (xstormy16_dummy_id): Delete.
3762         (xstormy16_gdbarch_init): Don't register deleted functions with
3763         gdbarch.
3764
3765 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3766
3767         * vax-tdep.c (vax_unwind_pc): Delete.
3768         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3769
3770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3771
3772         * v850-tdep.c (v850_unwind_sp): Delete.
3773         (v850_unwind_pc): Delete.
3774         (v850_dummy_id): Delete.
3775         (v850_gdbarch_init): Don't register deleted functions with
3776         gdbarch.
3777
3778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3779
3780         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3781         (tilegx_unwind_pc): Delete.
3782         (tilegx_unwind_dummy_id): Delete.
3783         (tilegx_gdbarch_init): Don't register deleted functions with
3784         gdbarch.
3785
3786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3787
3788         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3789         (tic6x_dummy_id): Delete.
3790         (tic6x_gdbarch_init): Don't register deleted functions with
3791         gdbarch.
3792
3793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3794
3795         * sparc-tdep.c (sparc_unwind_pc): Delete.
3796         (sparc32_gdbarch_init): Don't register deleted function with
3797         gdbarch.
3798
3799 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * sh-tdep.c (sh_unwind_sp): Delete.
3802         (sh_unwind_pc): Delete.
3803         (sh_dummy_id): Delete.
3804         (sh_gdbarch_init): Don't register deleted functions with
3805         gdbarch.
3806
3807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3808
3809         * score-tdep.c (score_unwind_sp): Delete.
3810         (score_unwind_pc): Delete.
3811         (score_dummy_id): Delete.
3812         (score_gdbarch_init): Don't register deleted functions with
3813         gdbarch.
3814
3815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3816
3817         * rx-tdep.c (rx_unwind_pc): Delete.
3818         (rx_unwind_sp): Delete.
3819         (rx_dummy_id): Delete.
3820         (rx_gdbarch_init): Don't register deleted functions with
3821         gdbarch.  Update comment.
3822
3823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3826         (rs6000_dummy_id): Delete.
3827         (rs6000_gdbarch_init): Don't register deleted functions with
3828         gdbarch.
3829
3830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * or1k-tdep.c (or1k_dummy_id): Delete.
3833         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3834
3835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3836
3837         * nios2-tdep.c (nios2_dummy_id): Delete.
3838         (nios2_unwind_sp): Delete.
3839         (nios2_gdbarch_init): Don't register deleted functions with
3840         gdbarch.
3841
3842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3843
3844         * nds32-tdep.c (nds32_dummy_id): Delete.
3845         (nds32_unwind_pc): Delete.
3846         (nds32_unwind_sp): Delete.
3847         (nds32_gdbarch_init): Don't register deleted functions with
3848         gdbarch.
3849
3850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3851
3852         * msp430-tdep.c (msp430_unwind_pc): Delete.
3853         (msp430_unwind_sp): Delete.
3854         (msp430_dummy_id): Delete.
3855         (msp430_gdbarch_init): Don't register deleted functions with
3856         gdbarch.
3857
3858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * moxie-tdep.c (moxie_unwind_sp): Delete.
3861         (moxie_unwind_pc): Delete.
3862         (moxie_dummy_id): Delete.
3863         (moxie_gdbarch_init): Don't register deleted functions with
3864         gdbarch.
3865
3866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3867
3868         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3869         (mn10300_unwind_pc): Delete.
3870         (mn10300_unwind_sp): Delete.
3871         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3872         mn10300_unwind_sp.
3873         (mn10300_frame_unwind_init): Don't register deleted functions with
3874         gdbarch.
3875
3876 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * mep-tdep.c (mep_unwind_pc): Delete.
3879         (mep_unwind_sp): Delete.
3880         (mep_dummy_id): Delete.
3881         (mep_gdbarch_init): Don't register deleted functions with
3882         gdbarch.
3883
3884 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3885
3886         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3887         (m68hc11_unwind_sp): Delete.
3888         (m68hc11_gdbarch_init): Don't register deleted functions with
3889         gdbarch.
3890
3891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3892
3893         * m32r-tdep.c (m32r_unwind_sp): Delete.
3894         (m32r_unwind_pc): Delete.
3895         (m32r_dummy_id): Delete.
3896         (m32r_gdbarch_init): Don't register deleted functions with
3897         gdbarch.
3898
3899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3900
3901         * m32c-tdep.c (m32c_unwind_pc): Delete.
3902         (m32c_unwind_sp): Delete.
3903         (m32c_dummy_id): Delete.
3904         (m32c_gdbarch_init): Don't register deleted functions with
3905         gdbarch.
3906
3907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3910         (lm32_unwind_pc): Delete.
3911         (lm32_dummy_id): Delete.
3912         (lm32_gdbarch_init): Don't register deleted functions with
3913         gdbarch.
3914
3915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3916
3917         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3918         (iq2000_unwind_pc): Delete.
3919         (iq2000_dummy_id): Delete.
3920         (iq2000_gdbarch_init): Don't register deleted functions with
3921         gdbarch.
3922
3923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3924
3925         * nds32-tdep.c (nds32_type_align): Delete.
3926         (nds32_push_dummy_call): Use type_align instead.
3927
3928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * arm-tdep.c (arm_type_align): Only handle vector override case.
3931         (arm_push_dummy_call): Use type_align.
3932         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3933
3934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3935
3936         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3937         case.
3938         (pass_on_stack): Use type_align.
3939         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3940         function.
3941
3942 2019-04-23  Tom Tromey  <tromey@adacore.com>
3943
3944         * dwarf2read.c (line_header::file_name_at): Remove unused
3945         overload.
3946
3947 2019-04-23  Tom de Vries  <tdevries@suse.de>
3948
3949         PR gdb/24438
3950         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3951         invocation.
3952
3953
3954 2019-03-27  Ali Tamur  <tamur@google.com>
3955
3956         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3957         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3958         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3959         (dwarf_expr_context::get_addr_index): Likewise
3960         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3961         (symbol_needs_eval_context::get_addr_index): Likewise
3962         (disassemble_dwarf_expression): Add DW_OP_addrx
3963         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3964         (read_cutu_die_from_dwo): Update comment
3965         (skip_one_die): Add DW_FORM_addrx
3966         (read_attribute_value): Likewise
3967         (var_decode_location): Add DW_OP_addrx
3968         (dwarf2_const_value_attr): Add DW_FORM_addrx
3969         (dump_die_shallow): Likewise
3970         (dwarf2_fetch_constant_bytes): Likewise
3971         (decode_locdesc): Add DW_OP_addrx
3972         (skip_form_bytes): Add DW_FORM_addrx
3973
3974 2019-04-22  Ali Tamur  <tamur@google.com>
3975
3976         * MAINTAINERS (Write After Approval): Add self.
3977
3978 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3979
3980         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3981         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3982         (open_symbol_file_object): Likewise.
3983         (svr4_default_sos): Add info parameter.
3984         (svr4_read_so_list): Likewise.
3985         (svr4_current_sos_direct): Adjust functions calls to pass down
3986         info.
3987         (svr4_current_sos_1): Add info parameter.
3988         (svr4_current_sos): Call get_svr4_info, pass info down to
3989         svr4_current_sos_1.
3990         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3991         get_svr4_info.
3992         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3993         get_svr4_info.
3994         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3995         to get_svr4_info.
3996         (probes_table_remove_objfile_probes): Likewise.
3997         (register_solib_event_probe): Add info parameter.
3998         (solist_update_incremental): Pass info parameter down to
3999         svr4_read_so_list.
4000         (disable_probes_interface): Add info parameter.
4001         (svr4_handle_solib_event): Pass current_program_space to
4002         get_svr4_info.  Adjust disable_probes_interface cleanup.
4003         (svr4_create_probe_breakpoints): Add info parameter, pass it
4004         down to register_solib_event_probe.
4005         (svr4_create_solib_event_breakpoints): Add info parameter,
4006         pass it down to svr4_create_probe_breakpoints.
4007         (enable_break): Pass info down to
4008         svr4_create_solib_event_breakpoints.
4009         (svr4_solib_create_inferior_hook): Pass current_program_space to
4010         get_svr4_info.
4011         (svr4_clear_solib): Likewise.
4012
4013 2019-04-22  Pedro Alves  <palves@redhat.com>
4014
4015         * solib-svr4.c (svr4_free_objfile_observer): New.
4016         (probe_and_action::objfile): New field.
4017         (probes_table_htab_remove_objfile_probes)
4018         (probes_table_remove_objfile_probes): New functions.
4019         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4020         in the new probe_and_action.  Don't store the probe in 'lookup'.
4021         (svr4_create_probe_breakpoints): Pass objfile to
4022         register_solib_event_probe.
4023         (_initialize_svr4_solib): Register a free_objfile observer.
4024
4025 2019-04-19  Tom Tromey  <tom@tromey.com>
4026
4027         * common/queue.h: Remove.
4028
4029 2019-04-19  Tom Tromey  <tom@tromey.com>
4030
4031         * event-loop.c: Don't include "common/queue.h".
4032
4033 2019-04-19  Tom Tromey  <tom@tromey.com>
4034
4035         * remote.c (remote_target): Use delete.
4036         * remote-notif.h: Include <list>, not "common/queue.h".
4037         (notif_client_p): Remove typedef.
4038         (remote_notif_state): Add constructor, destructor, initializer.
4039         <notif_queue>: Now a std::list.
4040         (remote_notif_state_xfree): Don't declare.
4041         * remote-notif.c (remote_notif_process, handle_notification)
4042         (remote_notif_state_allocate): Update.
4043         (~remote_notif_state): Rename from remote_notif_state_xfree.
4044
4045 2019-04-19  Tom Tromey  <tom@tromey.com>
4046
4047         * symfile.c (reread_symbols): Update.
4048         * objfiles.c (objfile_register_static_link)
4049         (objfile_lookup_static_link): Update
4050         (~objfile) Don't delete static_links.
4051         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4052
4053 2019-04-19  Tom Tromey  <tom@tromey.com>
4054
4055         * type-stack.h (struct type_stack) <insert>: Constify string.
4056         * type-stack.c (type_stack::insert): Constify string.
4057         * gdbtypes.h (lookup_template_type): Update.
4058         (address_space_name_to_int): Update.
4059         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4060         const.
4061         (lookup_template_type): Make name const.
4062         * c-exp.y: Update rules.
4063         (lex_one_token, classify_name, classify_inner_name)
4064         (c_print_token): Update.
4065         * p-exp.y: Update rules.
4066         (yylex): Update.
4067         * f-exp.y: Update rules.
4068         (yylex): Update.
4069         * d-exp.y: Update rules.
4070         (lex_one_token, classify_name, classify_inner_name): Update.
4071         * parse.c (write_dollar_variable, copy_name): Return std::string.
4072         * parser-defs.h (copy_name): Change return type.
4073         * m2-exp.y: Update rules.
4074         (yylex): Update.
4075         * go-exp.y (lex_one_token): Update.
4076         Update rules.
4077         (classify_unsafe_function, classify_packaged_name)
4078         (classify_name, yylex): Update.
4079
4080 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4081
4082         * configure.ac: add --enable-source-highlight switch.
4083         * configure: Regenerate.
4084         * top.c (print_gdb_version): plumb --enable-source-highlight
4085         status to "show configuration".
4086
4087 2019-04-19  Tom Tromey  <tromey@adacore.com>
4088
4089         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4090         Check ADA_TYPE_P.
4091         (empty_record, ada_template_to_fixed_record_type_1)
4092         (template_to_static_fixed_type)
4093         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4094         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4095         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4096         macros.
4097
4098 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4099
4100         PR symtab/24423:
4101         * source.c (print_source_lines_base): Advance "iter" when a
4102         control character is seen.
4103
4104 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4105
4106         * inferior.h (struct infcall_suspend_state_deleter):
4107         Catch exception in destructor to avoid crash.
4108
4109 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4110
4111         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4112         close to the add_com "shell".
4113
4114 2019-04-18  Tom Tromey  <tromey@adacore.com>
4115
4116         * process-stratum-target.h (class process_stratum_target)
4117         <stratum>: Add "final".
4118
4119 2019-04-17  Tom Tromey  <tromey@adacore.com>
4120
4121         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4122         against nullptr before use.
4123
4124 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4125
4126         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4127
4128 2019-04-17  Jim Wilson  <jimw@sifive.com>
4129             Andrew Burgess  <andrew.burgess@embecosm.com>
4130
4131         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4132         code read might fail, assume 4-byte breakpoint in that case.
4133
4134 2019-04-15  Leszek Swirski  <leszeks@google.com>
4135
4136         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4137         rather than a hand-rolled POD check when checking for forced MEMORY
4138         classification.
4139
4140 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4141
4142         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4143         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4144         function.
4145         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4146         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4147         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4148         declaration.
4149
4150 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4151
4152         * aarch64-linux-nat.c
4153         (aarch64_linux_nat_target::thread_architecture): Add override.
4154         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4155         each VQ.
4156
4157 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4158
4159         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4160
4161 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4162
4163         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4164         target types of size 96-bits, add some additional comments, and
4165         check that the builtin type we found was the correct size.
4166
4167 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4168
4169         * utils.c (prompt_for_continue): Don't restore the styling at the
4170         end, as applied_style has the wrong value.  This fixes styling in
4171         long lists of file names that are interrupted by the "Continue?"
4172         prompt.
4173
4174 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4175
4176         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4177         * c-lang.c (c_language_defn): Likewise.
4178         (cplus_language_defn): Likewise.
4179         (asm_language_defn): Likewise.
4180         (minimal_language_defn): Likewise.
4181         * d-lang.c (d_language_defn): Likewise.
4182         * f-lang.c (f_language_defn): Likewise.
4183         * go-lang.c (go_language_defn): Likewise.
4184         * language.c (unknown_language_defn): Likewise.
4185         (auto_language_defn): Likewise.
4186         * language.h (struct language_defn): Remove la_magic field.
4187         (LANG_MAGIC): Delete.
4188         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4189         * objc-lang.c (objc_language_defn): Likewise.
4190         * opencl-lang.c (opencl_language_defn): Likewise.
4191         * p-lang.c (pascal_language_defn): Likewise.
4192         * rust-lang.c (rust_language_defn): Likewise.
4193
4194 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4195
4196         * riscv-tdep.c (riscv_type_align): New function.
4197         (riscv_type_alignment): Delete.
4198         (riscv_arg_location): Use 'type_align'.
4199         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4200
4201 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4202
4203         * gdbtypes.c (type_align): A struct with no non-static fields also
4204         has alignment of 1.
4205
4206 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4207
4208         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4209         component to 0.
4210         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4211         member.
4212         (riscv_struct_info::analyse): New implementation using new
4213         analyse_inner member function.
4214         (riscv_struct_info::field_offset): New member function.
4215         (riscv_struct_info::m_offsets): New member variable.
4216         (riscv_struct_info::analyse_inner): New private member function,
4217         takes the old implementation of riscv_struct_info::analyse but
4218         extended to track field offsets.
4219         (riscv_call_arg_struct): Update the struct folding special cases
4220         to handle cases where empty C++ structs, which are non-zero
4221         length, are found.
4222         (riscv_arg_location): Initialise the length of each location, a
4223         non-zero length now indicates the location is in use.
4224         (riscv_push_dummy_call): Allow for the first location having a
4225         non-zero offset when setting up arguments.
4226         (riscv_return_value): Likewise, but for return values.
4227
4228 2019-04-11  Tom Tromey  <tromey@adacore.com>
4229
4230         * utils.c (internal_vproblem): Make "msg" const.
4231
4232 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4233
4234         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4235         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4236         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4237         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4238
4239 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4240
4241         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4242         function.
4243         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4244         of amd64_collect_native_gregset.
4245         (amd64_linux_nat_target::store_registers): Likewise.
4246
4247 2019-04-10  Tom Tromey  <tom@tromey.com>
4248
4249         * symtab.c (lookup_global_symbol_from_objfile)
4250         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4251         * objfiles.h (class separate_debug_iterator): New.
4252         (class separate_debug_range): New.
4253         (struct objfile) <separate_debug_objfiles>: New method.
4254         (objfile_separate_debug_iterate): Don't declare.
4255         * objfiles.c (separate_debug_iterator::operator++): Rename from
4256         objfile_separate_debug_iterate.
4257         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4258         iterator.
4259         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4260         iterator.
4261
4262 2019-04-10  Tom Tromey  <tom@tromey.com>
4263
4264         * symfile.c (reread_symbols): Remove old comment.
4265         * objfiles.c (free_all_objfiles): Fix a typo.
4266
4267 2019-04-10  Tom Tromey  <tom@tromey.com>
4268
4269         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4270         * minsyms.c (lookup_minimal_symbol): Use foreach.
4271         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4272         (lookup_minimal_symbol_solib_trampoline): Likewise.
4273         * symfile.c (reread_symbols): Use foreach.
4274
4275 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4276             Tom Tromey  <tromey@adacore.com>
4277
4278         PR rust/24414:
4279         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4280         (rust_lex_int_test): Change "value" to be LONGEST.
4281         (rust_lex_tests): Add test for long integer literal.
4282
4283 2019-04-09  Tom Tromey  <tromey@adacore.com>
4284
4285         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4286         to bool.
4287         (extended_remote_target::attach): Update.
4288         (remote_target::remote_notice_new_inferior): Update.
4289         (remote_target::add_current_inferior_and_thread): Update.
4290         * inferior.c (exit_inferior_1): Use "false".
4291         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4292
4293 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4294
4295         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4296         the "start" command.
4297
4298 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4299
4300         * python/py-inferior.c (infpy_thread_from_thread_handle):
4301         Adjust comments to reflect renaming of thread_from_thread_handle
4302         to thread_from_handle.  Adjust keywords.  Fix type error message.
4303         (inferior_object_methods): Add thread_from_handle.  Retain
4304         thread_from_thread_handle, but mark it as deprecated.
4305
4306 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4307
4308         * gdbthread.h (find_thread_by_handle): Revise declaration.
4309         * thread.c (find_thread_by_handle): Likewise.  Adjust
4310         implementation too.
4311         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4312         support for buffer objects as handles.
4313
4314 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4315
4316         * python/py-infthread.c (thpy_thread_handle): New function.
4317         (thread_object_methods): Register thpy_thread_handle.
4318
4319 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4320
4321         * gdbthread.h (thread_to_thread_handle): Declare.
4322         * thread.c (gdbtypes.h): Include.
4323         (thread_to_thread_handle): New function.
4324
4325         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4326         (target_thread_info_to_thread_handle): Declare.
4327         * target.c (target_thread_info_to_thread_handle): New function.
4328         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4329         * target-delegates.c: Regenerate.
4330
4331         * linux-thread-db.c (class thread_db_target): Add method
4332         thread_info_to_thread_handle.
4333         (thread_db_target::thread_info_to_thread_handle): Define.
4334         * remote.c (class remote_target): Add new method
4335         thread_info_to_thread_handle.
4336         (remote_target::thread_info_to_thread_handle): Define.
4337
4338 2019-04-08  Pedro Alves  <palves@redhat.com>
4339
4340         * common/common-exceptions.c (throw_exception): Don't create
4341         named object to throw; throw directly.
4342         (throw_it): Likewise.  Don't initialize gdb_exception::message
4343         here, with new; pass FMT and AP to the ctor instead.
4344         * common/common-exceptions.h: Include <string>.
4345         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4346         const char *, va_list)): New ctor.  Use std::make_shared.
4347         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4348         errors)): Delete.
4349         (gdb_exception_error::gdb_exception_error(enum errors, const char
4350         *, va_list)): New.
4351         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4352         Add assertion.
4353         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4354         errors)): Delete.
4355         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4356         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4357         Add assertion.
4358
4359 2019-04-08  Tom Tromey  <tom@tromey.com>
4360
4361         * valops.c (value_rtti_indirect_type): Replace throw_exception
4362         with throw.
4363         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4364         with throw.
4365         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4366         throw.
4367         * target.c (target_translate_tls_address): Replace throw_exception
4368         with throw.
4369         * stack.c (frame_apply_command_count): Replace throw_exception
4370         with throw.
4371         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4372         throw.
4373         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4374         with throw.
4375         * rs6000-tdep.c (rs6000_frame_cache)
4376         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4377         * remote.c: Replace throw_exception with throw.
4378         * record-full.c (record_full_message, record_full_wait_1)
4379         (record_full_restore): Replace throw_exception with throw.
4380         * record-btrace.c:
4381         (get_thread_current_frame_id, record_btrace_start_replaying)
4382         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4383         (cmd_record_btrace_start): Replace throw_exception with throw.
4384         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4385         throw.
4386         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4387         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4388         * linespec.c:
4389         (find_linespec_symbols): Replace throw_exception with throw.
4390         * infrun.c (displaced_step_prepare, resume): Replace
4391         throw_exception with throw.
4392         * infcmd.c (post_create_inferior): Replace throw_exception with
4393         throw.
4394         * inf-loop.c (inferior_event_handler): Replace throw_exception
4395         with throw.
4396         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4397         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4398         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4399         (get_prev_frame_always, get_frame_pc_if_available)
4400         (get_frame_address_in_block_if_available, get_frame_language):
4401         Replace throw_exception with throw.
4402         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4403         throw_exception with throw.
4404         * eval.c (fetch_subexp_value, evaluate_var_value)
4405         (evaluate_funcall, evaluate_subexp_standard): Replace
4406         throw_exception with throw.
4407         * dwarf2loc.c (call_site_find_chain)
4408         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4409         Replace throw_exception with throw.
4410         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4411         with throw.
4412         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4413         throw.
4414         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4415         * completer.c (complete_line_internal): Replace throw_exception
4416         with throw.
4417         * compile/compile-object-run.c (compile_object_run): Replace
4418         throw_exception with throw.
4419         * cli/cli-script.c (process_next_line): Replace throw_exception
4420         with throw.
4421         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4422         (btrace_enable, btrace_maint_update_pt_packets): Replace
4423         throw_exception with throw.
4424         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4425         throw_exception with throw.
4426         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4427         throw_exception with throw.
4428         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4429         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4430         * aarch64-tdep.c (aarch64_make_prologue_cache)
4431         (aarch64_make_stub_cache): Replace throw_exception with throw.
4432
4433 2019-04-08  Tom Tromey  <tom@tromey.com>
4434
4435         * common/common-exceptions.c (throw_exception): Rename from
4436         throw_exception_cxx.  Remove old copy.  Make argument const.
4437         (throw_it): Create and throw exception objects directly.
4438         * common/common-exceptions.h (throw_exception): Make argument
4439         const.
4440         (struct gdb_exception_error): Add constructor.
4441         (struct gdb_exception_quit): Add constructor.
4442
4443 2019-04-08  Tom Tromey  <tom@tromey.com>
4444
4445         * common/common-exceptions.h (exception_rethrow): Don't declare.
4446         (TRY_SJLJ): Update comment.
4447         (TRY, CATCH, END_CATCH): Remove.
4448         * common/common-exceptions.c (exception_rethrow): Remove.
4449
4450 2019-04-08  Tom Tromey  <tom@tromey.com>
4451
4452         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4453         Remove.
4454         (gdb_exception_error): Rename from
4455         gdb_exception_RETURN_MASK_ERROR.
4456         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4457         (gdb_quit_bad_alloc): Update.
4458         * aarch64-tdep.c: Update.
4459         * ada-lang.c: Update.
4460         * ada-typeprint.c: Update.
4461         * ada-valprint.c: Update.
4462         * amd64-tdep.c: Update.
4463         * arch-utils.c: Update.
4464         * break-catch-throw.c: Update.
4465         * breakpoint.c: Update.
4466         * btrace.c: Update.
4467         * c-varobj.c: Update.
4468         * cli/cli-cmds.c: Update.
4469         * cli/cli-interp.c: Update.
4470         * cli/cli-script.c: Update.
4471         * common/common-exceptions.c: Update.
4472         * common/new-op.c: Update.
4473         * common/selftest.c: Update.
4474         * compile/compile-c-symbols.c: Update.
4475         * compile/compile-cplus-symbols.c: Update.
4476         * compile/compile-object-load.c: Update.
4477         * compile/compile-object-run.c: Update.
4478         * completer.c: Update.
4479         * corelow.c: Update.
4480         * cp-abi.c: Update.
4481         * cp-support.c: Update.
4482         * cp-valprint.c: Update.
4483         * darwin-nat.c: Update.
4484         * disasm-selftests.c: Update.
4485         * dtrace-probe.c: Update.
4486         * dwarf-index-cache.c: Update.
4487         * dwarf-index-write.c: Update.
4488         * dwarf2-frame-tailcall.c: Update.
4489         * dwarf2-frame.c: Update.
4490         * dwarf2loc.c: Update.
4491         * dwarf2read.c: Update.
4492         * eval.c: Update.
4493         * event-loop.c: Update.
4494         * event-top.c: Update.
4495         * exec.c: Update.
4496         * f-valprint.c: Update.
4497         * fbsd-tdep.c: Update.
4498         * frame-unwind.c: Update.
4499         * frame.c: Update.
4500         * gdbtypes.c: Update.
4501         * gnu-v3-abi.c: Update.
4502         * guile/guile-internal.h: Update.
4503         * guile/scm-block.c: Update.
4504         * guile/scm-breakpoint.c: Update.
4505         * guile/scm-cmd.c: Update.
4506         * guile/scm-disasm.c: Update.
4507         * guile/scm-frame.c: Update.
4508         * guile/scm-lazy-string.c: Update.
4509         * guile/scm-math.c: Update.
4510         * guile/scm-param.c: Update.
4511         * guile/scm-ports.c: Update.
4512         * guile/scm-pretty-print.c: Update.
4513         * guile/scm-symbol.c: Update.
4514         * guile/scm-symtab.c: Update.
4515         * guile/scm-type.c: Update.
4516         * guile/scm-value.c: Update.
4517         * i386-linux-tdep.c: Update.
4518         * i386-tdep.c: Update.
4519         * inf-loop.c: Update.
4520         * infcall.c: Update.
4521         * infcmd.c: Update.
4522         * infrun.c: Update.
4523         * jit.c: Update.
4524         * language.c: Update.
4525         * linespec.c: Update.
4526         * linux-fork.c: Update.
4527         * linux-nat.c: Update.
4528         * linux-tdep.c: Update.
4529         * linux-thread-db.c: Update.
4530         * main.c: Update.
4531         * mi/mi-cmd-break.c: Update.
4532         * mi/mi-cmd-stack.c: Update.
4533         * mi/mi-interp.c: Update.
4534         * mi/mi-main.c: Update.
4535         * objc-lang.c: Update.
4536         * p-valprint.c: Update.
4537         * parse.c: Update.
4538         * ppc-linux-tdep.c: Update.
4539         * printcmd.c: Update.
4540         * python/py-arch.c: Update.
4541         * python/py-breakpoint.c: Update.
4542         * python/py-cmd.c: Update.
4543         * python/py-finishbreakpoint.c: Update.
4544         * python/py-frame.c: Update.
4545         * python/py-framefilter.c: Update.
4546         * python/py-gdb-readline.c: Update.
4547         * python/py-inferior.c: Update.
4548         * python/py-infthread.c: Update.
4549         * python/py-lazy-string.c: Update.
4550         * python/py-linetable.c: Update.
4551         * python/py-objfile.c: Update.
4552         * python/py-param.c: Update.
4553         * python/py-prettyprint.c: Update.
4554         * python/py-progspace.c: Update.
4555         * python/py-record-btrace.c: Update.
4556         * python/py-record.c: Update.
4557         * python/py-symbol.c: Update.
4558         * python/py-type.c: Update.
4559         * python/py-unwind.c: Update.
4560         * python/py-utils.c: Update.
4561         * python/py-value.c: Update.
4562         * python/python.c: Update.
4563         * record-btrace.c: Update.
4564         * record-full.c: Update.
4565         * remote-fileio.c: Update.
4566         * remote.c: Update.
4567         * riscv-tdep.c: Update.
4568         * rs6000-aix-tdep.c: Update.
4569         * rs6000-tdep.c: Update.
4570         * rust-exp.y: Update.
4571         * rust-lang.c: Update.
4572         * s390-tdep.c: Update.
4573         * selftest-arch.c: Update.
4574         * solib-dsbt.c: Update.
4575         * solib-frv.c: Update.
4576         * solib-spu.c: Update.
4577         * solib-svr4.c: Update.
4578         * solib.c: Update.
4579         * sparc64-linux-tdep.c: Update.
4580         * stack.c: Update.
4581         * symfile-mem.c: Update.
4582         * symmisc.c: Update.
4583         * target.c: Update.
4584         * thread.c: Update.
4585         * top.c: Update.
4586         * tracefile-tfile.c: Update.
4587         * tui/tui.c: Update.
4588         * typeprint.c: Update.
4589         * unittests/cli-utils-selftests.c: Update.
4590         * unittests/parse-connection-spec-selftests.c: Update.
4591         * valops.c: Update.
4592         * valprint.c: Update.
4593         * value.c: Update.
4594         * varobj.c: Update.
4595         * windows-nat.c: Update.
4596         * x86-linux-nat.c: Update.
4597         * xml-support.c: Update.
4598
4599 2019-04-08  Tom Tromey  <tom@tromey.com>
4600
4601         * xml-support.c: Use C++ exception handling.
4602         * x86-linux-nat.c: Use C++ exception handling.
4603         * windows-nat.c: Use C++ exception handling.
4604         * varobj.c: Use C++ exception handling.
4605         * value.c: Use C++ exception handling.
4606         * valprint.c: Use C++ exception handling.
4607         * valops.c: Use C++ exception handling.
4608         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4609         handling.
4610         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4611         * typeprint.c: Use C++ exception handling.
4612         * tui/tui.c: Use C++ exception handling.
4613         * tracefile-tfile.c: Use C++ exception handling.
4614         * top.c: Use C++ exception handling.
4615         * thread.c: Use C++ exception handling.
4616         * target.c: Use C++ exception handling.
4617         * symmisc.c: Use C++ exception handling.
4618         * symfile-mem.c: Use C++ exception handling.
4619         * stack.c: Use C++ exception handling.
4620         * sparc64-linux-tdep.c: Use C++ exception handling.
4621         * solib.c: Use C++ exception handling.
4622         * solib-svr4.c: Use C++ exception handling.
4623         * solib-spu.c: Use C++ exception handling.
4624         * solib-frv.c: Use C++ exception handling.
4625         * solib-dsbt.c: Use C++ exception handling.
4626         * selftest-arch.c: Use C++ exception handling.
4627         * s390-tdep.c: Use C++ exception handling.
4628         * rust-lang.c: Use C++ exception handling.
4629         * rust-exp.y: Use C++ exception handling.
4630         * rs6000-tdep.c: Use C++ exception handling.
4631         * rs6000-aix-tdep.c: Use C++ exception handling.
4632         * riscv-tdep.c: Use C++ exception handling.
4633         * remote.c: Use C++ exception handling.
4634         * remote-fileio.c: Use C++ exception handling.
4635         * record-full.c: Use C++ exception handling.
4636         * record-btrace.c: Use C++ exception handling.
4637         * python/python.c: Use C++ exception handling.
4638         * python/py-value.c: Use C++ exception handling.
4639         * python/py-utils.c: Use C++ exception handling.
4640         * python/py-unwind.c: Use C++ exception handling.
4641         * python/py-type.c: Use C++ exception handling.
4642         * python/py-symbol.c: Use C++ exception handling.
4643         * python/py-record.c: Use C++ exception handling.
4644         * python/py-record-btrace.c: Use C++ exception handling.
4645         * python/py-progspace.c: Use C++ exception handling.
4646         * python/py-prettyprint.c: Use C++ exception handling.
4647         * python/py-param.c: Use C++ exception handling.
4648         * python/py-objfile.c: Use C++ exception handling.
4649         * python/py-linetable.c: Use C++ exception handling.
4650         * python/py-lazy-string.c: Use C++ exception handling.
4651         * python/py-infthread.c: Use C++ exception handling.
4652         * python/py-inferior.c: Use C++ exception handling.
4653         * python/py-gdb-readline.c: Use C++ exception handling.
4654         * python/py-framefilter.c: Use C++ exception handling.
4655         * python/py-frame.c: Use C++ exception handling.
4656         * python/py-finishbreakpoint.c: Use C++ exception handling.
4657         * python/py-cmd.c: Use C++ exception handling.
4658         * python/py-breakpoint.c: Use C++ exception handling.
4659         * python/py-arch.c: Use C++ exception handling.
4660         * printcmd.c: Use C++ exception handling.
4661         * ppc-linux-tdep.c: Use C++ exception handling.
4662         * parse.c: Use C++ exception handling.
4663         * p-valprint.c: Use C++ exception handling.
4664         * objc-lang.c: Use C++ exception handling.
4665         * mi/mi-main.c: Use C++ exception handling.
4666         * mi/mi-interp.c: Use C++ exception handling.
4667         * mi/mi-cmd-stack.c: Use C++ exception handling.
4668         * mi/mi-cmd-break.c: Use C++ exception handling.
4669         * main.c: Use C++ exception handling.
4670         * linux-thread-db.c: Use C++ exception handling.
4671         * linux-tdep.c: Use C++ exception handling.
4672         * linux-nat.c: Use C++ exception handling.
4673         * linux-fork.c: Use C++ exception handling.
4674         * linespec.c: Use C++ exception handling.
4675         * language.c: Use C++ exception handling.
4676         * jit.c: Use C++ exception handling.
4677         * infrun.c: Use C++ exception handling.
4678         * infcmd.c: Use C++ exception handling.
4679         * infcall.c: Use C++ exception handling.
4680         * inf-loop.c: Use C++ exception handling.
4681         * i386-tdep.c: Use C++ exception handling.
4682         * i386-linux-tdep.c: Use C++ exception handling.
4683         * guile/scm-value.c: Use C++ exception handling.
4684         * guile/scm-type.c: Use C++ exception handling.
4685         * guile/scm-symtab.c: Use C++ exception handling.
4686         * guile/scm-symbol.c: Use C++ exception handling.
4687         * guile/scm-pretty-print.c: Use C++ exception handling.
4688         * guile/scm-ports.c: Use C++ exception handling.
4689         * guile/scm-param.c: Use C++ exception handling.
4690         * guile/scm-math.c: Use C++ exception handling.
4691         * guile/scm-lazy-string.c: Use C++ exception handling.
4692         * guile/scm-frame.c: Use C++ exception handling.
4693         * guile/scm-disasm.c: Use C++ exception handling.
4694         * guile/scm-cmd.c: Use C++ exception handling.
4695         * guile/scm-breakpoint.c: Use C++ exception handling.
4696         * guile/scm-block.c: Use C++ exception handling.
4697         * guile/guile-internal.h: Use C++ exception handling.
4698         * gnu-v3-abi.c: Use C++ exception handling.
4699         * gdbtypes.c: Use C++ exception handling.
4700         * frame.c: Use C++ exception handling.
4701         * frame-unwind.c: Use C++ exception handling.
4702         * fbsd-tdep.c: Use C++ exception handling.
4703         * f-valprint.c: Use C++ exception handling.
4704         * exec.c: Use C++ exception handling.
4705         * event-top.c: Use C++ exception handling.
4706         * event-loop.c: Use C++ exception handling.
4707         * eval.c: Use C++ exception handling.
4708         * dwarf2read.c: Use C++ exception handling.
4709         * dwarf2loc.c: Use C++ exception handling.
4710         * dwarf2-frame.c: Use C++ exception handling.
4711         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4712         * dwarf-index-write.c: Use C++ exception handling.
4713         * dwarf-index-cache.c: Use C++ exception handling.
4714         * dtrace-probe.c: Use C++ exception handling.
4715         * disasm-selftests.c: Use C++ exception handling.
4716         * darwin-nat.c: Use C++ exception handling.
4717         * cp-valprint.c: Use C++ exception handling.
4718         * cp-support.c: Use C++ exception handling.
4719         * cp-abi.c: Use C++ exception handling.
4720         * corelow.c: Use C++ exception handling.
4721         * completer.c: Use C++ exception handling.
4722         * compile/compile-object-run.c: Use C++ exception handling.
4723         * compile/compile-object-load.c: Use C++ exception handling.
4724         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4725         * compile/compile-c-symbols.c: Use C++ exception handling.
4726         * common/selftest.c: Use C++ exception handling.
4727         * common/new-op.c: Use C++ exception handling.
4728         * cli/cli-script.c: Use C++ exception handling.
4729         * cli/cli-interp.c: Use C++ exception handling.
4730         * cli/cli-cmds.c: Use C++ exception handling.
4731         * c-varobj.c: Use C++ exception handling.
4732         * btrace.c: Use C++ exception handling.
4733         * breakpoint.c: Use C++ exception handling.
4734         * break-catch-throw.c: Use C++ exception handling.
4735         * arch-utils.c: Use C++ exception handling.
4736         * amd64-tdep.c: Use C++ exception handling.
4737         * ada-valprint.c: Use C++ exception handling.
4738         * ada-typeprint.c: Use C++ exception handling.
4739         * ada-lang.c: Use C++ exception handling.
4740         * aarch64-tdep.c: Use C++ exception handling.
4741
4742 2019-04-08  Tom Tromey  <tom@tromey.com>
4743
4744         * xml-support.c (gdb_xml_parser::parse): Update.
4745         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4746         * value.c (show_convenience): Update.
4747         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4748         (test_parse_flags_qcs): Update.
4749         * thread.c (thr_try_catch_cmd): Update.
4750         * target.c (target_translate_tls_address): Update.
4751         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4752         (info_frame_command_core, frame_apply_command_count): Update.
4753         * rust-exp.y (rust_lex_exception_test): Update.
4754         * riscv-tdep.c (riscv_print_one_register_info): Update.
4755         * remote.c (remote_target::enable_btrace): Update.
4756         * record-btrace.c (record_btrace_enable_warn): Update.
4757         * python/py-utils.c (gdbpy_convert_exception): Update.
4758         * printcmd.c (do_one_display, print_variable_and_value): Update.
4759         * mi/mi-main.c (mi_print_exception): Update.
4760         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4761         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4762         * linux-nat.c (linux_nat_target::attach): Update.
4763         * linux-fork.c (class scoped_switch_fork_info): Update.
4764         * infrun.c (displaced_step_prepare): Update.
4765         * infcall.c (call_function_by_hand_dummy): Update.
4766         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4767         * gnu-v3-abi.c (print_one_vtable): Update.
4768         * frame.c (get_prev_frame_always): Update.
4769         * f-valprint.c (info_common_command_for_block): Update.
4770         * exec.c (try_open_exec_file): Update.
4771         * exceptions.c (print_exception, exception_print)
4772         (exception_fprintf, exception_print_same): Update.
4773         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4774         * dwarf-index-cache.c (index_cache::store)
4775         (index_cache::lookup_gdb_index): Update.
4776         * darwin-nat.c (maybe_cache_shell): Update.
4777         * cp-valprint.c (cp_print_value_fields): Update.
4778         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4779         (gcc_cplus_symbol_address): Update.
4780         * compile/compile-c-symbols.c (gcc_convert_symbol)
4781         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4782         * common/selftest.c: Update.
4783         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4784         a std::string.
4785         (exception_try_scope_entry, exception_try_scope_exit): Don't
4786         declare.
4787         (struct exception_try_scope): Remove.
4788         (TRY): Don't use exception_try_scope.
4789         (struct gdb_exception): Add constructor, operator=.
4790         <what>: New method.
4791         (struct gdb_exception_RETURN_MASK_ALL)
4792         (struct gdb_exception_RETURN_MASK_ERROR)
4793         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4794         (struct gdb_quit_bad_alloc): Update.
4795         * common/common-exceptions.c (exception_none): Change
4796         initializer.
4797         (struct catcher) <state, exception>: Initialize inline.
4798         <prev>: Remove member.
4799         (current_catcher): Remove.
4800         (catchers): New global.
4801         (exceptions_state_mc_init): Simplify.
4802         (catcher_pop): Remove.
4803         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4804         (try_scope_depth, exception_try_scope_entry)
4805         (exception_try_scope_exit): Remove.
4806         (throw_exception_sjlj): Update.
4807         (exception_messages, exception_messages_size): Remove.
4808         (throw_it): Simplify.
4809         (gdb_exception_sliced_copy): Remove.
4810         (throw_exception_cxx): Update.
4811         * cli/cli-script.c (script_from_file): Update.
4812         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4813         Update.
4814         * ada-valprint.c (ada_val_print): Update.
4815         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4816         (create_excep_cond_exprs): Update.
4817
4818 2019-04-08  Tom Tromey  <tom@tromey.com>
4819
4820         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4821         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4822         (TRY, CATCH, END_CATCH): Remove some definitions.
4823         * common/common-exceptions.c: Don't use GDB_XCPT.
4824         (catcher_list_size): Remove.
4825         (throw_exception, throw_it): Simplify.
4826
4827 2019-04-05  Tom Tromey  <tom@tromey.com>
4828
4829         Revert the header-sorting patch.
4830         * ft32-tdep.c: Revert.
4831         * frv-tdep.c: Revert.
4832         * frv-linux-tdep.c: Revert.
4833         * frame.c: Revert.
4834         * frame-unwind.c: Revert.
4835         * frame-base.c: Revert.
4836         * fork-child.c: Revert.
4837         * findvar.c: Revert.
4838         * findcmd.c: Revert.
4839         * filesystem.c: Revert.
4840         * filename-seen-cache.h: Revert.
4841         * filename-seen-cache.c: Revert.
4842         * fbsd-tdep.c: Revert.
4843         * fbsd-nat.h: Revert.
4844         * fbsd-nat.c: Revert.
4845         * f-valprint.c: Revert.
4846         * f-typeprint.c: Revert.
4847         * f-lang.c: Revert.
4848         * extension.h: Revert.
4849         * extension.c: Revert.
4850         * extension-priv.h: Revert.
4851         * expprint.c: Revert.
4852         * exec.h: Revert.
4853         * exec.c: Revert.
4854         * exceptions.c: Revert.
4855         * event-top.c: Revert.
4856         * event-loop.c: Revert.
4857         * eval.c: Revert.
4858         * elfread.c: Revert.
4859         * dwarf2read.h: Revert.
4860         * dwarf2read.c: Revert.
4861         * dwarf2loc.c: Revert.
4862         * dwarf2expr.h: Revert.
4863         * dwarf2expr.c: Revert.
4864         * dwarf2-frame.c: Revert.
4865         * dwarf2-frame-tailcall.c: Revert.
4866         * dwarf-index-write.h: Revert.
4867         * dwarf-index-write.c: Revert.
4868         * dwarf-index-common.c: Revert.
4869         * dwarf-index-cache.h: Revert.
4870         * dwarf-index-cache.c: Revert.
4871         * dummy-frame.c: Revert.
4872         * dtrace-probe.c: Revert.
4873         * disasm.h: Revert.
4874         * disasm.c: Revert.
4875         * disasm-selftests.c: Revert.
4876         * dictionary.c: Revert.
4877         * dicos-tdep.c: Revert.
4878         * demangle.c: Revert.
4879         * dcache.h: Revert.
4880         * dcache.c: Revert.
4881         * darwin-nat.h: Revert.
4882         * darwin-nat.c: Revert.
4883         * darwin-nat-info.c: Revert.
4884         * d-valprint.c: Revert.
4885         * d-namespace.c: Revert.
4886         * d-lang.c: Revert.
4887         * ctf.c: Revert.
4888         * csky-tdep.c: Revert.
4889         * csky-linux-tdep.c: Revert.
4890         * cris-tdep.c: Revert.
4891         * cris-linux-tdep.c: Revert.
4892         * cp-valprint.c: Revert.
4893         * cp-support.c: Revert.
4894         * cp-namespace.c: Revert.
4895         * cp-abi.c: Revert.
4896         * corelow.c: Revert.
4897         * corefile.c: Revert.
4898         * continuations.c: Revert.
4899         * completer.h: Revert.
4900         * completer.c: Revert.
4901         * complaints.c: Revert.
4902         * coffread.c: Revert.
4903         * coff-pe-read.c: Revert.
4904         * cli-out.h: Revert.
4905         * cli-out.c: Revert.
4906         * charset.c: Revert.
4907         * c-varobj.c: Revert.
4908         * c-valprint.c: Revert.
4909         * c-typeprint.c: Revert.
4910         * c-lang.c: Revert.
4911         * buildsym.c: Revert.
4912         * buildsym-legacy.c: Revert.
4913         * build-id.h: Revert.
4914         * build-id.c: Revert.
4915         * btrace.c: Revert.
4916         * bsd-uthread.c: Revert.
4917         * breakpoint.h: Revert.
4918         * breakpoint.c: Revert.
4919         * break-catch-throw.c: Revert.
4920         * break-catch-syscall.c: Revert.
4921         * break-catch-sig.c: Revert.
4922         * blockframe.c: Revert.
4923         * block.c: Revert.
4924         * bfin-tdep.c: Revert.
4925         * bfin-linux-tdep.c: Revert.
4926         * bfd-target.c: Revert.
4927         * bcache.c: Revert.
4928         * ax-general.c: Revert.
4929         * ax-gdb.h: Revert.
4930         * ax-gdb.c: Revert.
4931         * avr-tdep.c: Revert.
4932         * auxv.c: Revert.
4933         * auto-load.c: Revert.
4934         * arm-wince-tdep.c: Revert.
4935         * arm-tdep.c: Revert.
4936         * arm-symbian-tdep.c: Revert.
4937         * arm-pikeos-tdep.c: Revert.
4938         * arm-obsd-tdep.c: Revert.
4939         * arm-nbsd-tdep.c: Revert.
4940         * arm-nbsd-nat.c: Revert.
4941         * arm-linux-tdep.c: Revert.
4942         * arm-linux-nat.c: Revert.
4943         * arm-fbsd-tdep.c: Revert.
4944         * arm-fbsd-nat.c: Revert.
4945         * arm-bsd-tdep.c: Revert.
4946         * arch-utils.c: Revert.
4947         * arc-tdep.c: Revert.
4948         * arc-newlib-tdep.c: Revert.
4949         * annotate.h: Revert.
4950         * annotate.c: Revert.
4951         * amd64-windows-tdep.c: Revert.
4952         * amd64-windows-nat.c: Revert.
4953         * amd64-tdep.c: Revert.
4954         * amd64-sol2-tdep.c: Revert.
4955         * amd64-obsd-tdep.c: Revert.
4956         * amd64-obsd-nat.c: Revert.
4957         * amd64-nbsd-tdep.c: Revert.
4958         * amd64-nbsd-nat.c: Revert.
4959         * amd64-nat.c: Revert.
4960         * amd64-linux-tdep.c: Revert.
4961         * amd64-linux-nat.c: Revert.
4962         * amd64-fbsd-tdep.c: Revert.
4963         * amd64-fbsd-nat.c: Revert.
4964         * amd64-dicos-tdep.c: Revert.
4965         * amd64-darwin-tdep.c: Revert.
4966         * amd64-bsd-nat.c: Revert.
4967         * alpha-tdep.c: Revert.
4968         * alpha-obsd-tdep.c: Revert.
4969         * alpha-nbsd-tdep.c: Revert.
4970         * alpha-mdebug-tdep.c: Revert.
4971         * alpha-linux-tdep.c: Revert.
4972         * alpha-linux-nat.c: Revert.
4973         * alpha-bsd-tdep.c: Revert.
4974         * alpha-bsd-nat.c: Revert.
4975         * aix-thread.c: Revert.
4976         * agent.c: Revert.
4977         * addrmap.c: Revert.
4978         * ada-varobj.c: Revert.
4979         * ada-valprint.c: Revert.
4980         * ada-typeprint.c: Revert.
4981         * ada-tasks.c: Revert.
4982         * ada-lang.c: Revert.
4983         * aarch64-tdep.c: Revert.
4984         * aarch64-ravenscar-thread.c: Revert.
4985         * aarch64-newlib-tdep.c: Revert.
4986         * aarch64-linux-tdep.c: Revert.
4987         * aarch64-linux-nat.c: Revert.
4988         * aarch64-fbsd-tdep.c: Revert.
4989         * aarch64-fbsd-nat.c: Revert.
4990         * aarch32-linux-nat.c: Revert.
4991
4992 2019-04-05  Tom Tromey  <tom@tromey.com>
4993
4994         * ft32-tdep.c: Sort headers.
4995         * frv-tdep.c: Sort headers.
4996         * frv-linux-tdep.c: Sort headers.
4997         * frame.c: Sort headers.
4998         * frame-unwind.c: Sort headers.
4999         * frame-base.c: Sort headers.
5000         * fork-child.c: Sort headers.
5001         * findvar.c: Sort headers.
5002         * findcmd.c: Sort headers.
5003         * filesystem.c: Sort headers.
5004         * filename-seen-cache.h: Sort headers.
5005         * filename-seen-cache.c: Sort headers.
5006         * fbsd-tdep.c: Sort headers.
5007         * fbsd-nat.h: Sort headers.
5008         * fbsd-nat.c: Sort headers.
5009         * f-valprint.c: Sort headers.
5010         * f-typeprint.c: Sort headers.
5011         * f-lang.c: Sort headers.
5012         * extension.h: Sort headers.
5013         * extension.c: Sort headers.
5014         * extension-priv.h: Sort headers.
5015         * expprint.c: Sort headers.
5016         * exec.h: Sort headers.
5017         * exec.c: Sort headers.
5018         * exceptions.c: Sort headers.
5019         * event-top.c: Sort headers.
5020         * event-loop.c: Sort headers.
5021         * eval.c: Sort headers.
5022         * elfread.c: Sort headers.
5023         * dwarf2read.h: Sort headers.
5024         * dwarf2read.c: Sort headers.
5025         * dwarf2loc.c: Sort headers.
5026         * dwarf2expr.h: Sort headers.
5027         * dwarf2expr.c: Sort headers.
5028         * dwarf2-frame.c: Sort headers.
5029         * dwarf2-frame-tailcall.c: Sort headers.
5030         * dwarf-index-write.h: Sort headers.
5031         * dwarf-index-write.c: Sort headers.
5032         * dwarf-index-common.c: Sort headers.
5033         * dwarf-index-cache.h: Sort headers.
5034         * dwarf-index-cache.c: Sort headers.
5035         * dummy-frame.c: Sort headers.
5036         * dtrace-probe.c: Sort headers.
5037         * disasm.h: Sort headers.
5038         * disasm.c: Sort headers.
5039         * disasm-selftests.c: Sort headers.
5040         * dictionary.c: Sort headers.
5041         * dicos-tdep.c: Sort headers.
5042         * demangle.c: Sort headers.
5043         * dcache.h: Sort headers.
5044         * dcache.c: Sort headers.
5045         * darwin-nat.h: Sort headers.
5046         * darwin-nat.c: Sort headers.
5047         * darwin-nat-info.c: Sort headers.
5048         * d-valprint.c: Sort headers.
5049         * d-namespace.c: Sort headers.
5050         * d-lang.c: Sort headers.
5051         * ctf.c: Sort headers.
5052         * csky-tdep.c: Sort headers.
5053         * csky-linux-tdep.c: Sort headers.
5054         * cris-tdep.c: Sort headers.
5055         * cris-linux-tdep.c: Sort headers.
5056         * cp-valprint.c: Sort headers.
5057         * cp-support.c: Sort headers.
5058         * cp-namespace.c: Sort headers.
5059         * cp-abi.c: Sort headers.
5060         * corelow.c: Sort headers.
5061         * corefile.c: Sort headers.
5062         * continuations.c: Sort headers.
5063         * completer.h: Sort headers.
5064         * completer.c: Sort headers.
5065         * complaints.c: Sort headers.
5066         * coffread.c: Sort headers.
5067         * coff-pe-read.c: Sort headers.
5068         * cli-out.h: Sort headers.
5069         * cli-out.c: Sort headers.
5070         * charset.c: Sort headers.
5071         * c-varobj.c: Sort headers.
5072         * c-valprint.c: Sort headers.
5073         * c-typeprint.c: Sort headers.
5074         * c-lang.c: Sort headers.
5075         * buildsym.c: Sort headers.
5076         * buildsym-legacy.c: Sort headers.
5077         * build-id.h: Sort headers.
5078         * build-id.c: Sort headers.
5079         * btrace.c: Sort headers.
5080         * bsd-uthread.c: Sort headers.
5081         * breakpoint.h: Sort headers.
5082         * breakpoint.c: Sort headers.
5083         * break-catch-throw.c: Sort headers.
5084         * break-catch-syscall.c: Sort headers.
5085         * break-catch-sig.c: Sort headers.
5086         * blockframe.c: Sort headers.
5087         * block.c: Sort headers.
5088         * bfin-tdep.c: Sort headers.
5089         * bfin-linux-tdep.c: Sort headers.
5090         * bfd-target.c: Sort headers.
5091         * bcache.c: Sort headers.
5092         * ax-general.c: Sort headers.
5093         * ax-gdb.h: Sort headers.
5094         * ax-gdb.c: Sort headers.
5095         * avr-tdep.c: Sort headers.
5096         * auxv.c: Sort headers.
5097         * auto-load.c: Sort headers.
5098         * arm-wince-tdep.c: Sort headers.
5099         * arm-tdep.c: Sort headers.
5100         * arm-symbian-tdep.c: Sort headers.
5101         * arm-pikeos-tdep.c: Sort headers.
5102         * arm-obsd-tdep.c: Sort headers.
5103         * arm-nbsd-tdep.c: Sort headers.
5104         * arm-nbsd-nat.c: Sort headers.
5105         * arm-linux-tdep.c: Sort headers.
5106         * arm-linux-nat.c: Sort headers.
5107         * arm-fbsd-tdep.c: Sort headers.
5108         * arm-fbsd-nat.c: Sort headers.
5109         * arm-bsd-tdep.c: Sort headers.
5110         * arch-utils.c: Sort headers.
5111         * arc-tdep.c: Sort headers.
5112         * arc-newlib-tdep.c: Sort headers.
5113         * annotate.h: Sort headers.
5114         * annotate.c: Sort headers.
5115         * amd64-windows-tdep.c: Sort headers.
5116         * amd64-windows-nat.c: Sort headers.
5117         * amd64-tdep.c: Sort headers.
5118         * amd64-sol2-tdep.c: Sort headers.
5119         * amd64-obsd-tdep.c: Sort headers.
5120         * amd64-obsd-nat.c: Sort headers.
5121         * amd64-nbsd-tdep.c: Sort headers.
5122         * amd64-nbsd-nat.c: Sort headers.
5123         * amd64-nat.c: Sort headers.
5124         * amd64-linux-tdep.c: Sort headers.
5125         * amd64-linux-nat.c: Sort headers.
5126         * amd64-fbsd-tdep.c: Sort headers.
5127         * amd64-fbsd-nat.c: Sort headers.
5128         * amd64-dicos-tdep.c: Sort headers.
5129         * amd64-darwin-tdep.c: Sort headers.
5130         * amd64-bsd-nat.c: Sort headers.
5131         * alpha-tdep.c: Sort headers.
5132         * alpha-obsd-tdep.c: Sort headers.
5133         * alpha-nbsd-tdep.c: Sort headers.
5134         * alpha-mdebug-tdep.c: Sort headers.
5135         * alpha-linux-tdep.c: Sort headers.
5136         * alpha-linux-nat.c: Sort headers.
5137         * alpha-bsd-tdep.c: Sort headers.
5138         * alpha-bsd-nat.c: Sort headers.
5139         * aix-thread.c: Sort headers.
5140         * agent.c: Sort headers.
5141         * addrmap.c: Sort headers.
5142         * ada-varobj.c: Sort headers.
5143         * ada-valprint.c: Sort headers.
5144         * ada-typeprint.c: Sort headers.
5145         * ada-tasks.c: Sort headers.
5146         * ada-lang.c: Sort headers.
5147         * aarch64-tdep.c: Sort headers.
5148         * aarch64-ravenscar-thread.c: Sort headers.
5149         * aarch64-newlib-tdep.c: Sort headers.
5150         * aarch64-linux-tdep.c: Sort headers.
5151         * aarch64-linux-nat.c: Sort headers.
5152         * aarch64-fbsd-tdep.c: Sort headers.
5153         * aarch64-fbsd-nat.c: Sort headers.
5154         * aarch32-linux-nat.c: Sort headers.
5155
5156 2019-04-04  Tom Tromey  <tom@tromey.com>
5157
5158         * varobj.c (varobj_create): Update.
5159         * rust-exp.y (struct rust_parser) <update_innermost_block,
5160         lookup_symbol>: New methods.
5161         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5162         Rename.
5163         (rust_parser::rust_lookup_type)
5164         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5165         * printcmd.c (display_command, do_one_display): Update.
5166         * parser-defs.h (struct parser_state) <parser_state>: Add
5167         "tracker" parameter.
5168         (block_tracker): New member.
5169         (class innermost_block_tracker) <innermost_block_tracker>: Add
5170         "types" parameter.
5171         <reset>: Remove method.
5172         (innermost_block): Don't declare.
5173         (null_post_parser): Update.
5174         * parse.c (innermost_block): Remove global.
5175         (write_dollar_variable): Update.
5176         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5177         Remove "tracker_types" parameter.
5178         (parse_expression): Add "tracker" parameter.
5179         (parse_expression_for_completion): Update.
5180         (null_post_parser): Add "tracker" parameter.
5181         * p-exp.y: Update rules.
5182         * m2-exp.y: Update rules.
5183         * language.h (struct language_defn) <la_post_parser>: Add
5184         "tracker" parameter.
5185         * go-exp.y: Update rules.
5186         * f-exp.y: Update rules.
5187         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5188         parameter.
5189         * d-exp.y: Update rules.
5190         * c-exp.y: Update rules.
5191         * breakpoint.c (set_breakpoint_condition): Create an
5192         innermost_block_tracker.
5193         (watch_command_1): Likewise.
5194         * ada-lang.c (resolve): Add "tracker" parameter.
5195         (resolve_subexp): Likewise.
5196         * ada-exp.y (write_var_from_sym): Update.
5197
5198 2019-04-04  Tom Tromey  <tom@tromey.com>
5199
5200         * type-stack.h: New file.
5201         * type-stack.c: New file.
5202         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5203         type-stack.h.
5204         (insert_into_type_stack, insert_type, push_type, push_type_int)
5205         (insert_type_address_space, pop_type, pop_type_int)
5206         (pop_typelist, pop_type_stack, append_type_stack)
5207         (push_type_stack, get_type_stack, push_typelist)
5208         (follow_type_instance_flags, follow_types): Don't declare.
5209         * parse.c (type_stack): Remove global.
5210         (parse_exp_in_context): Update.
5211         (insert_into_type_stack, insert_type, push_type, push_type_int)
5212         (insert_type_address_space, pop_type, pop_type_int)
5213         (pop_typelist, pop_type_stack, append_type_stack)
5214         (push_type_stack, get_type_stack, push_typelist)
5215         (follow_type_instance_flags, follow_types): Remove (moved to
5216         type-stack.c).
5217         * f-exp.y (type_stack): New global.
5218         Update rules.
5219         (push_kind_type, f_parse): Update.
5220         * d-exp.y (type_stack): New global.
5221         Update rules.
5222         (d_parse): Update.
5223         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5224         Update rules.
5225         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5226         (HFILES_NO_SRCDIR): Add type-stack.h.
5227
5228 2019-04-04  Tom Tromey  <tom@tromey.com>
5229
5230         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5231         (rust_parser::convert_ast_to_expression, rust_parse)
5232         (rust_lex_test_completion, rust_lex_tests): Update.
5233         * parser-defs.h (struct expr_completion_state): New.
5234         (struct parser_state) <parser_state>: Add completion parameter.
5235         <mark_struct_expression, mark_completion_tag>: New methods.
5236         <parse_completion, m_completion_state>: New members.
5237         (prefixify_expression, null_post_parser): Update.
5238         (mark_struct_expression, mark_completion_tag): Don't declare.
5239         * parse.c (parse_completion, expout_last_struct)
5240         (expout_tag_completion_type, expout_completion_name): Remove
5241         globals.
5242         (parser_state::mark_struct_expression)
5243         (parser_state::mark_completion_tag): Now methods.
5244         (prefixify_expression): Add last_struct parameter.
5245         (prefixify_subexp): Likewise.
5246         (parse_exp_1): Update.
5247         (parse_exp_in_context): Add cstate parameter.  Update.
5248         (parse_expression_for_completion): Create an
5249         expr_completion_state.
5250         (null_post_parser): Add "completion" parameter.
5251         * p-exp.y: Update rules.
5252         (yylex): Update.
5253         * language.h (struct language_defn) <la_post_parser>: Add
5254         "completing" parameter.
5255         * go-exp.y: Update rules.
5256         (lex_one_token): Update.
5257         * expression.h (parse_completion): Don't declare.
5258         * d-exp.y: Update rules.
5259         (lex_one_token): Update rules.
5260         * c-exp.y: Update rules.
5261         (lex_one_token): Update.
5262         * ada-lang.c (resolve): Add "parse_completion" parameter.
5263         (resolve_subexp): Likewise.
5264         (ada_resolve_function): Likewise.
5265
5266 2019-04-04  Tom Tromey  <tom@tromey.com>
5267
5268         * parser-defs.h (struct parser_state) <start_arglist,
5269         end_arglist>: New methods.
5270         <arglist_len, m_funcall_chain>: New members.
5271         (arglist_len, start_arglist, end_arglist): Don't declare.
5272         * parse.c (arglist_len, funcall_chain): Remove global.
5273         (start_arglist, end_arglist): Remove functions.
5274         (parse_exp_in_context): Update.
5275         * p-exp.y: Update rules.
5276         * m2-exp.y: Update rules.
5277         * go-exp.y: Update rules.
5278         * f-exp.y: Update rules.
5279         * d-exp.y: Update rules.
5280         * c-exp.y: Update rules.
5281
5282 2019-04-04  Tom Tromey  <tom@tromey.com>
5283
5284         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5285         lex_operator, push_back>: New methods.
5286         Update all rules.
5287         (rust_parser::lex_hex, lex_escape): Rename and update.
5288         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5289         (rust_parser::lex_operator): Rename and update.
5290         (rust_parser::lex_number, rustyylex, rustyyerror)
5291         (rust_lex_test_init, rust_lex_test_sequence)
5292         (rust_lex_test_push_back, rust_lex_tests): Update.
5293         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5294         parameter.
5295         <lexptr, prev_lexptr>: New members.
5296         (lexptr, prev_lexptr): Don't declare.
5297         * parse.c (lexptr, prev_lexptr): Remove globals.
5298         (parse_exp_in_context): Update.
5299         * p-exp.y (yylex, yyerror): Update.
5300         * m2-exp.y (parse_number, yylex, yyerror): Update.
5301         * go-exp.y (lex_one_token, yyerror): Update.
5302         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5303         * d-exp.y (lex_one_token, yyerror): Update.
5304         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5305         (lex_one_token, yyerror): Update.
5306         * ada-lex.l (YY_INPUT): Update.
5307         (rewind_to_char): Update.
5308         * ada-exp.y (yyerror): Update.
5309
5310 2019-04-04  Tom Tromey  <tom@tromey.com>
5311
5312         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5313         * parser-defs.h (struct parser_state) <parser_state>: Add new
5314         parameter.
5315         <comma_terminates>: New member.
5316         (comma_terminates): Don't declare global.
5317         * parse.c (comma_terminates): Remove global.
5318         (parse_exp_in_context): Update.
5319         * p-exp.y (yylex): Update.
5320         * m2-exp.y (yylex): Update.
5321         * go-exp.y (lex_one_token): Update.
5322         * f-exp.y (yylex): Update.
5323         * d-exp.y (lex_one_token): Update.
5324         * c-exp.y (lex_one_token): Update.
5325         * ada-lex.l: Update.
5326
5327 2019-04-04  Tom Tromey  <tom@tromey.com>
5328
5329         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5330         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5331         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5332         * parser-defs.h (paren_depth): Don't declare.
5333         * parse.c (paren_depth): Remove global.
5334         (parse_exp_in_context): Update.
5335         * p-exp.y (paren_depth): New global.
5336         (pascal_parse): Initialize it.
5337         * m2-exp.y (paren_depth): New global.
5338         (m2_parse): Initialize it.
5339         * go-exp.y (paren_depth): New global.
5340         (go_parse): Initialize it.
5341         * f-exp.y (paren_depth): New global.
5342         (f_parse): Initialize it.
5343         * d-exp.y (paren_depth): New global.
5344         (d_parse): Initialize it.
5345         * c-exp.y (paren_depth): New global.
5346         (c_parse): Initialize it.
5347         * ada-lex.l (paren_depth): New global.
5348         (lexer_init): Initialize it.
5349
5350 2019-04-04  Tom Tromey  <tom@tromey.com>
5351
5352         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5353         (rust_parser::convert_ast_to_type)
5354         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5355         * parser-defs.h (struct parser_state) <parser_state>: Add
5356         parameters.  Initialize new members.
5357         <expression_context_block, expression_context_pc>: New members.
5358         * parse.c (expression_context_block, expression_context_pc):
5359         Remove globals.
5360         (parse_exp_in_context): Update.
5361         * p-exp.y: Update all rules.
5362         (yylex): Update.
5363         * m2-exp.y: Update all rules.
5364         (yylex): Update.
5365         * go-exp.y (yylex): Update.
5366         * f-exp.y (yylex): Update.
5367         * d-exp.y: Update all rules.
5368         (yylex): Update.
5369         * c-exp.y: Update all rules.
5370         (lex_one_token, classify_name, yylex, c_parse): Update.
5371         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5372
5373 2019-04-04  Tom Tromey  <tom@tromey.com>
5374
5375         * gdbarch.h, gdbarch.c: Rebuild.
5376         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5377         * stap-probe.h:
5378         (struct stap_parse_info): Replace "parser_state" with
5379         "expr_builder".
5380         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5381         (parser_state): New class.
5382         * parse.c (expr_builder): Rename.
5383         (expr_builder::release): Rename.
5384         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5385         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5386         (write_exp_elt_longcst, write_exp_elt_floatcst)
5387         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5388         (write_exp_string_vector, write_exp_bitstring)
5389         (write_exp_msymbol, mark_struct_expression)
5390         (write_dollar_variable)
5391         (insert_type_address_space, increase_expout_size): Replace
5392         "parser_state" with "expr_builder".
5393         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5394         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5395         "parser_state" with "expr_builder".
5396
5397 2019-04-04  Tom Tromey  <tom@tromey.com>
5398
5399         * rust-exp.y: Replace "parse_language" with method call.
5400         * p-exp.y:
5401         (yylex): Replace "parse_language" with method call.
5402         * m2-exp.y:
5403         (yylex): Replace "parse_language" with method call.
5404         * go-exp.y (classify_name): Replace "parse_language" with method
5405         call.
5406         * f-exp.y (yylex): Replace "parse_language" with method call.
5407         * d-exp.y (lex_one_token): Replace "parse_language" with method
5408         call.
5409         * c-exp.y:
5410         (lex_one_token, classify_name, yylex): Replace "parse_language"
5411         with method call.
5412         * ada-exp.y (find_primitive_type, type_char)
5413         (type_system_address): Replace "parse_language" with method call.
5414
5415 2019-04-04  Tom Tromey  <tom@tromey.com>
5416
5417         * rust-exp.y: Replace "parse_gdbarch" with method call.
5418         * parse.c (write_dollar_variable, insert_type_address_space):
5419         Replace "parse_gdbarch" with method call.
5420         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5421         call.
5422         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5423         call.
5424         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5425         "parse_gdbarch" with method call.
5426         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5427         with method call.
5428         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5429         "parse_gdbarch" with method call.
5430         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5431         "parse_gdbarch" with method call.
5432         * c-exp.y (parse_type, parse_number, classify_name): Replace
5433         "parse_gdbarch" with method call.
5434         * ada-lex.l: Replace "parse_gdbarch" with method call.
5435         * ada-exp.y (parse_type, find_primitive_type, type_char)
5436         (type_system_address): Replace "parse_gdbarch" with method call.
5437
5438 2019-04-04  Tom Tromey  <tom@tromey.com>
5439
5440         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5441         * stap-probe.c (stap_parse_argument): Update.
5442         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5443         initial_size parameter.
5444         * rust-exp.y (rust_lex_tests): Update.
5445         * parse.c (parser_state): Update.
5446         (parse_exp_in_context): Update.
5447         * parser-defs.h (struct parser_state) <parser_state>: Remove
5448         "initial_size" parameter.
5449
5450 2019-04-04  Tom Tromey  <tom@tromey.com>
5451
5452         * parser-defs.h (increase_expout_size): Don't declare.
5453         * parse.c (increase_expout_size): Now static.
5454
5455 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5456
5457         * gnu-nat.c (gnu_nat_target::wait): Fix
5458         target_waitstatus_to_string call.
5459
5460 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5461
5462         * eval.c (evaluate_subexp_standard): Handle internal functions
5463         during Fortran function call handling.
5464
5465 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5466
5467         * NEWS: Mention new internal functions.
5468         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5469         (read_base_type): Use dwarf2_init_complex_target_type.
5470         * value.c (creal_internal_fn): New function.
5471         (cimag_internal_fn): New function.
5472         (_initialize_values): Register new internal functions.
5473
5474 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5475
5476         * infrun.c (stop_all_threads): If debug_infrun, always
5477         trace the wait status after wait_one, using
5478         target_waitstatus_to_string and target_pid_to_str.
5479         (handle_inferior_event): Replace various trace of
5480         wait status kind by a single trace.
5481         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5482         wait status kind image by target_waitstatus_to_string.
5483         * target/waitstatus.c (target_waitstatus_to_string): Fix
5484         obsolete comment.
5485
5486 2019-04-01  Tom Tromey  <tromey@adacore.com>
5487
5488         PR symtab/23331:
5489         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5490
5491 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5492             Pedro Alves  <palves@redhat.com>
5493
5494         * top.c (quit_force): Call 'finalize_values'.
5495         * value.c (finalize_values): New function.
5496         * value.h (finalize_values): Declare.
5497
5498 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5499
5500         * NEWS: Announce $_gdb_major and $_gdb_minor.
5501
5502         * top.c (init_gdb_version_vars): New function.
5503         (gdb_init): Call init_gdb_version_vars.
5504
5505 2019-03-29  Tom Tromey  <tromey@adacore.com>
5506
5507         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5508         help text.  Remove dead code.
5509
5510 2019-03-29  Keith Seitz  <keiths@redhat.com>
5511
5512         From Siddhesh Poyarekar:
5513         * f-lang.h (f77_get_upperbound): Return LONGEST.
5514         (f77_get_lowerbound): Likewise.
5515         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5516         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5517         print them.
5518         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5519         plongest to format print it.
5520         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5521         (f77_get_upperbound): Likewise.
5522         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5523         LOWER_BOUND to LONGEST.
5524         (f77_create_arrayprint_offset_tbl): Likewise.
5525
5526 2019-03-29  Keith Seitz  <keiths@redhat.com>
5527
5528         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5529         %s/pulongest for TYPE_LENGTH instead of %d in format
5530         strings.
5531         * ada-typerint.c (ada_print_type): Likewise.
5532         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5533         * compile/compile-c-support.c (generate_register_struct): Likewise.
5534         * gdbtypes.c (recursive_dump_type): Likewise.
5535         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5536         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5537         instead of %d in format strings.
5538         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5539         to std::min to ULONGEST.
5540         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5541         instead of %d in format strings.
5542         * tracepoint.c (info_scope_command): Likewise.
5543         * typeprint.c (print_offset_data::update)
5544         (print_offset_data::finish): Likewise.
5545         * xtensa-tdep.c (xtensa_store_return_value)
5546         (xtensa_push_dummy_call): Likewise.
5547
5548 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5549
5550         * windows-nat.c (display_selector): Fixed format specifications
5551         for 64-bit Cygwin.
5552
5553 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5554
5555         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5556
5557 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5558
5559         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5560         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5561         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5562         (nios2_linux_init_abi): Install it.
5563
5564 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5565
5566         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5567
5568 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5569
5570         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5571
5572 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5573             Tom Tromey  <tromey@adacore.com>
5574
5575         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5576
5577 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5578
5579         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5580         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5581         method to compute the bounds of range types. Also print "[evaluated]"
5582         if the bounds' values come from a dynamic evaluation.
5583
5584 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5585
5586         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5587         whitespace when pretty printing is on.
5588
5589 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5590
5591         * ppc-linux-nat.c: Add include.
5592
5593 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5594
5595         * NEWS: Mention AArch64 Pointer Authentication.
5596
5597 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5598
5599         * arm-linux-nat.c: Add include.
5600
5601 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5602
5603         * source-cache.c (source_cache::get_source_lines): Re-read
5604         fullname after calling open_source_file.
5605
5606 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5607
5608         * NEWS: Mention TLS support for FreeBSD.
5609
5610 2019-03-25  Tom Tromey  <tromey@adacore.com>
5611
5612         * minsyms.c (BUNCH_SIZE): Update comment.
5613         (~minimal_symbol_reader): Remove old comment.
5614         (compact_minimal_symbols): Update comment.
5615         (minimal_symbol_reader::install): Remove old comment.  Update
5616         other comments.
5617
5618 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5619
5620         * s390-linux-nat.c: Add include.
5621
5622 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5623
5624         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5625         Call linux_get_hwcap.
5626         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5627         Likewise.
5628         (aarch64_linux_get_hwcap): Remove function.
5629         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5630         declaration.
5631         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5632         linux_get_hwcap.
5633         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5634         * linux-tdep.c (linux_get_hwcap): Add function.
5635         (linux_get_hwcap2): Likewise.
5636         * linux-tdep.h (linux_get_hwcap): Add declaration.
5637         (linux_get_hwcap2): Likewise.
5638         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5639         (ppc_linux_get_hwcap2): Likewise.
5640         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5641         linux_get_hwcap.
5642         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5643         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5644         (ppc_linux_nat_target::read_description): Likewise.
5645         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5646         * s390-linux-nat.c: Likewise.
5647         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5648
5649 2019-03-24  Tom Tromey  <tom@tromey.com>
5650
5651         * ada-lang.c (standard_lookup): Simplify initialization.
5652         (ada_lookup_symbol_nonlocal): Simplify return.
5653         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5654         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5655         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5656         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5657         initialization.
5658         * solib.c (solib_global_lookup): Simplify.
5659         * symtab.c (null_block_symbol): Remove.
5660         (symbol_cache_lookup): Simplify returns.
5661         (lookup_language_this): Simplify returns.
5662         (lookup_symbol_aux): Simplify return.
5663         (lookup_local_symbol): Simplify returns.
5664         (lookup_global_symbol_from_objfile): Simplify return.
5665         (lookup_symbol_in_objfile_symtabs)
5666         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5667         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5668         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5669         * cp-namespace.c (cp_lookup_bare_symbol)
5670         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5671         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5672         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5673         (cp_lookup_symbol_via_imports): Simplify initialization.
5674         (find_symbol_in_baseclass): Likewise.
5675         * symtab.h (null_block_symbol): Remove.
5676         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5677         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5678         (d_lookup_symbol_module): Likewise.
5679         (find_symbol_in_baseclass): Simplify initialization.
5680
5681 2019-03-24  Tom Tromey  <tom@tromey.com>
5682
5683         * expression.h: Don't include symtab.h.
5684         (struct block): Forward declare.
5685
5686 2019-03-24  Tom Tromey  <tom@tromey.com>
5687
5688         * c-exp.y (typebase): Remove casts.
5689         * gdbtypes.c (lookup_unsigned_typename, )
5690         (lookup_signed_typename): Remove cast.
5691         * eval.c (parse_to_comma_and_eval): Remove cast.
5692         * parse.c (write_dollar_variable): Remove cast.
5693         * block.h (struct block) <superblock>: Now const.
5694         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5695         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5696         (map_block): Make "block" const.
5697         * symfile.h (struct quick_symbol_functions)
5698         <map_matching_symbols>: Constify block argument to "callback".
5699         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5700         const.
5701         (find_pc_sect_compunit_symtab): Make "b" const.
5702         (find_symbol_at_address): Likewise.
5703         (search_symbols): Likewise.
5704         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5705         (dw2_debug_names_lookup_symbol): Likewise.
5706         (dw2_map_matching_symbols): Update.
5707         * p-valprint.c (pascal_val_print): Remove "block".
5708         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5709         (aux_add_nonlocal_symbols): Make "block" const.
5710         (resolve_subexp): Remove cast.
5711         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5712         const.
5713         (iterate_over_file_blocks): Likewise.
5714         * f-exp.y (%union) <bval>: Remove.
5715         * coffread.c (patch_opaque_types): Make "b" const.
5716         * spu-tdep.c (spu_catch_start): Make "block" const.
5717         * c-valprint.c (print_unpacked_pointer): Remove "block".
5718         * symmisc.c (dump_symtab_1): Make "b" const.
5719         (block_depth): Make "block" const.
5720         * d-exp.y (%union) <bval>: Remove.
5721         * cp-support.h (cp_lookup_rtti_type): Update.
5722         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5723         * psymtab.c (psym_lookup_symbol): Make "block" const.
5724         (maintenance_check_psymtabs): Make "b" const.
5725         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5726         (enumerate_locals, enumerate_args): Update.
5727         * python/py-symtab.c (stpy_global_block): Make "block" const.
5728         (stpy_static_block): Likewise.
5729         * inline-frame.c (block_starting_point_at): Make "new_block"
5730         const.
5731         * block.c (find_block_in_blockvector): Make return type const.
5732         (blockvector_for_pc_sect): Make "b" const.
5733         (find_block_in_blockvector): Make "b" const.
5734
5735 2019-03-23  Tom Tromey  <tom@tromey.com>
5736
5737         * varobj.c (varobj_create): Update.
5738         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5739         * printcmd.c (display_command, do_one_display): Don't reset
5740         innermost_block.
5741         * parser-defs.h (enum innermost_block_tracker_type): Move to
5742         expression.h.
5743         (innermost_block): Update comment.
5744         * parse.c (parse_exp_1): Add tracker_types parameter.
5745         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5746         tracker_types parameter.  Reset innermost_block.
5747         (parse_exp_in_context): Remove.
5748         (parse_expression_for_completion): Update.
5749         * objfiles.c (~objfile): Don't reset expression_context_block or
5750         innermost_block.
5751         * expression.h (enum innermost_block_tracker_type): Move from
5752         parser-defs.h.
5753         (parse_exp_1): Add tracker_types parameter.
5754         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5755         reset innermost_block.
5756
5757 2019-03-23  Tom Tromey  <tom@tromey.com>
5758
5759         * objfiles.h: Include bcache.h.
5760
5761 2019-03-23  Tom Tromey  <tom@tromey.com>
5762
5763         * linespec.c (get_current_search_block): Use
5764         scoped_restore_current_language.
5765         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5766
5767 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5768             Jiong Wang  <jiong.wang@arm.com>
5769
5770         * aarch64-linux-tdep.c
5771         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5772         section.
5773         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5774
5775 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5776             Jiong Wang  <jiong.wang@arm.com>
5777
5778         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5779         instructions.
5780         (aarch64_analyze_prologue_test): Add PACIASP test.
5781         (aarch64_prologue_prev_register): Unmask PC value.
5782
5783 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5784             Jiong Wang  <jiong.wang@arm.com>
5785
5786         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5787         (aarch64_dwarf2_prev_register): Unmask PC value.
5788         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5789         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5790         DW_CFA_AARCH64_negate_ra_state.
5791         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5792
5793 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5794             Jiong Wang  <jiong.wang@arm.com>
5795
5796         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5797         registers.
5798         (aarch64_pseudo_register_name): Likewise.
5799         (aarch64_pseudo_register_type): Likewise.
5800         (aarch64_pseudo_register_reggroup_p): Likewise.
5801         (aarch64_gdbarch_init): Add pauth registers.
5802         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5803         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5804         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5805         (struct gdbarch_tdep): Add regnum for ra_state.
5806
5807 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5808             Jiong Wang  <jiong.wang@arm.com>
5809
5810         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5811
5812 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5813             Jiong Wang  <jiong.wang@arm.com>
5814
5815         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5816         function.
5817         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5818         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5819         (aarch64_gdbarch_init): Add puth registers.
5820         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5821         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5822         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5823
5824 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5825             Jiong Wang  <jiong.wang@arm.com>
5826
5827         * aarch64-linux-nat.c
5828         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5829         * aarch64-linux-tdep.c
5830         (aarch64_linux_core_read_description): Likewise.
5831         (aarch64_linux_get_hwcap): New function.
5832         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5833         (aarch64_linux_get_hwcap): New declaration.
5834
5835 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5836             Jiong Wang  <jiong.wang@arm.com>
5837
5838         * aarch64-linux-nat.c
5839         (aarch64_linux_nat_target::read_description): Add pauth param.
5840         * aarch64-linux-tdep.c
5841         (aarch64_linux_core_read_description): Likewise.
5842         * aarch64-tdep.c (struct target_desc): Add in pauth.
5843         (aarch64_read_description): Add pauth param.
5844         (aarch64_gdbarch_init): Likewise.
5845         * aarch64-tdep.h (aarch64_read_description): Likewise.
5846         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5847         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5848         * features/Makefile: Add new files.
5849         * features/aarch64-pauth.c: New file.
5850         * features/aarch64-pauth.xml: New file.
5851
5852 2019-03-20  Tom Tromey  <tromey@adacore.com>
5853
5854         * infrun.c (handle_inferior_event): Rename from
5855         handle_inferior_event_1.  Create a scoped_value_mark.
5856         (handle_inferior_event): Remove.
5857
5858 2019-03-19  Tom Tromey  <tromey@adacore.com>
5859
5860         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5861         * infrun.h (print_stop_event): Add "displays" parameter.
5862         * infrun.c (print_stop_event): Add "displays" parameter.
5863
5864 2019-03-19  Pedro Alves  <palves@redhat.com>
5865
5866         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5867         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5868         to -1.  Fix TABs vs spaces.
5869         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5870         * tui/tui-out.h (tui_ui_out) Add intro comments.
5871         <m_line, m_start_of_line>: In-class initialize, and add describing
5872         comment.
5873
5874 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5875
5876         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5877         variable names.
5878         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5879
5880 2019-03-18  Pedro Alves  <palves@redhat.com>
5881             Eli Zaretskii <eliz@gnu.org>
5882
5883         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5884         m_line and m_start_of_line.
5885
5886 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5887
5888         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5889         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5890         it returns a newline.  This fixes a regression in TU mode, whereby
5891         the next line is output on the same screen line as the user input.
5892
5893 2019-03-18  Tom Tromey  <tromey@adacore.com>
5894
5895         * minsyms.c (minimal_symbol_reader::install): Remove call to
5896         obstack_blank.
5897
5898 2019-03-18  Pedro Alves  <palves@redhat.com>
5899
5900         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5901         New globals.
5902         (apply_style): New, factored out from ...
5903         (apply_ansi_escape): ... this.  Handle reverse video mode.
5904         (tui_set_reverse_mode): New function.
5905         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5906         * tui/tui-winsource.c (tui_show_source_line): Use
5907         tui_set_reverse_mode instead of setting A_STANDOUT.
5908         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5909         New setter methods.
5910
5911 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5912
5913         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5914         Handle tabs.
5915
5916 2019-03-18  Tom Tromey  <tromey@adacore.com>
5917
5918         * ada-lang.c (empty_array): Add "high" parameter.
5919         (ada_evaluate_subexp): Update.
5920
5921 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5922
5923         * unittests/string_view-selftests.c: Define
5924         _initialize_string_view_selftests unconditionally.
5925
5926 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5927
5928         PR gdb/24350
5929         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5930
5931 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5932
5933         PR gdb/24351
5934         * windows-nat.c (display_selector): Fix format specifiers.
5935
5936 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5937
5938         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5939         tui_refill_source_window instead of tui_refresh_win, to update the
5940         current execution line.  This fixes redisplay of the current line
5941         when stepping through the code with "next" or "step".
5942
5943 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5944
5945         * source-cache.c (source_cache::get_source_lines): Call
5946         find_source_lines to initialize s->nlines.  This fixes vertical
5947         scrolling of TUI source window when the DOWN arrow is pressed.
5948
5949 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5950
5951         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5952         linux-thread-db.c (_initialize_thread_db): Likewise.
5953
5954 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5955
5956         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5957         wclrtoeol in tui_show_source_line".  This reverts changes made in
5958         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5959
5960 2019-03-15  Tom Tromey  <tom@tromey.com>
5961
5962         * symtab.h (struct minimal_symbol): Derive from
5963         general_symbol_info.
5964         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5965         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5966         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5967         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5968         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5969         (MSYMBOL_SEARCH_NAME): Update.
5970         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5971         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5972         * minsyms.c (minimal_symbol_reader::record_full): Update.
5973
5974 2019-03-15  Tom Tromey  <tom@tromey.com>
5975
5976         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5977
5978 2019-03-15  Tom Tromey  <tom@tromey.com>
5979
5980         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5981         unique_xmalloc_ptr.
5982         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5983         Update.
5984         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5985         (build_minimal_symbol_hash_tables)
5986         (minimal_symbol_reader::install): Update.
5987
5988 2019-03-15  Tom Tromey  <tom@tromey.com>
5989
5990         * symtab.c (create_demangled_names_hash): Update.
5991         (symbol_set_names): Update.
5992         * objfiles.h (struct objfile_per_bfd_storage)
5993         <demangled_names_hash>: Now an htab_up.
5994         * objfiles.c (objfile_per_bfd_storage): Simplify.
5995
5996 2019-03-15  Tom Tromey  <tom@tromey.com>
5997
5998         * objfiles.h (struct objfile_per_bfd_storage): Declare
5999         destructor.
6000         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6001         New.
6002         (get_objfile_bfd_data): Use new.  Don't initialize
6003         language_of_main.
6004         (free_objfile_per_bfd_storage): Remove.
6005         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6006
6007 2019-03-15  Tom Tromey  <tom@tromey.com>
6008
6009         * symfile.c (reread_symbols): Update.
6010         * objfiles.c (objfile::objfile): Update.
6011         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6012         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6013         comment.
6014         (minimal_symbol_reader::install): Update.
6015         (terminate_minimal_symbol_table): Remove.
6016         * jit.c (jit_object_close_impl): Update.
6017
6018 2019-03-15  Tom Tromey  <tom@tromey.com>
6019
6020         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6021         initializations.
6022
6023 2019-03-15  Tom Tromey  <tom@tromey.com>
6024
6025         * objfiles.h (struct objfile_per_bfd_storage)
6026         <demangled_hash_languages>: Now a bitset.
6027         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6028         (lookup_minimal_symbol): Update.
6029
6030 2019-03-15  Tom Tromey  <tom@tromey.com>
6031
6032         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6033         Don't return the symbol.
6034         * coffread.c (record_minimal_symbol): Use record_full.
6035
6036 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6037
6038         The MS-Windows port of ncurses fails to switch to a color pair if
6039         one or both of the colors are the implicit default colors.  This
6040         change records the default colors when TUI is initialized, and
6041         then specifies them explicitly when a color pair uses the default
6042         colors.  This allows color styling in TUI mode on MS-Windows.
6043
6044         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6045         ncurses_norm_attr.
6046         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6047         colors in ncurses_norm_attr.
6048         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6049         "none", replace it with the default color recorded in
6050         ncurses_norm_attr.
6051
6052 2019-03-14  Tom Tromey  <tromey@adacore.com>
6053
6054         * source-cache.h (class source_cache) <get_source_lines>: Return
6055         std::string.
6056         * source-cache.c (source_cache::extract_lines): Handle case where
6057         first_pos==npos.  Return std::string.
6058         (source_cache::get_source_lines): Update.
6059
6060 2019-03-14  Tom Tromey  <tromey@adacore.com>
6061
6062         * NEWS: Add item for "style sources" commands.
6063         * source-cache.c (source_cache::get_source_lines): Check
6064         source_styling.
6065         * cli/cli-style.c (source_styling): New global.
6066         (_initialize_cli_style): Add "style sources" commands.
6067         (show_style_sources): New function.
6068         * cli/cli-style.h (source_styling): Declare.
6069
6070 2019-03-14  Pedro Alves  <palves@redhat.com>
6071             Tom Tromey  <tromey@adacore.com>
6072
6073         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6074         * tui/tui-winsource.c (tui_refill_source_window): New function,
6075         from...
6076         (tui_horizontal_source_scroll): ... here.  Move some logic.
6077         * cli/cli-style.c (set_style_enabled): Notify new observable.
6078         * tui/tui-hooks.c (tui_redisplay_source): New function.
6079         (tui_attach_detach_observers): Attach or detach
6080         tui_redisplay_source.
6081         * observable.h (source_styling_changed): New observable.
6082         * observable.c: Define source_styling_changed observable.
6083
6084 2019-03-13  Tom Tromey  <tromey@adacore.com>
6085
6086         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6087         (i386_gnu_nat_target::store_registers): Update.
6088         * target-debug.h (target_debug_print_std_string): New macro.
6089         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6090         * windows-tdep.c (display_one_tib): Update.
6091         * tui/tui-stack.c (tui_make_status_line): Update.
6092         * top.c (print_inferior_quit_action): Update.
6093         * thread.c (thr_try_catch_cmd): Update.
6094         (add_thread_with_info): Update.
6095         (thread_target_id_str): Update.
6096         (thr_try_catch_cmd): Update.
6097         (thread_command): Update.
6098         (thread_find_command): Update.
6099         * record-btrace.c (record_btrace_target::info_record)
6100         (record_btrace_resume_thread, record_btrace_target::resume)
6101         (record_btrace_cancel_resume, record_btrace_step_thread)
6102         (record_btrace_target::wait, record_btrace_target::wait)
6103         (record_btrace_target::wait, record_btrace_target::stop): Update.
6104         * progspace.c (print_program_space): Update.
6105         * process-stratum-target.c
6106         (process_stratum_target::thread_address_space): Update.
6107         * linux-fork.c (linux_fork_mourn_inferior)
6108         (detach_checkpoint_command, info_checkpoints_command)
6109         (linux_fork_context): Update.
6110         (linux_fork_detach): Update.
6111         (class scoped_switch_fork_info): Update.
6112         (delete_checkpoint_command): Update.
6113         * infrun.c (follow_fork_inferior): Update.
6114         (follow_fork_inferior): Update.
6115         (proceed_after_vfork_done): Update.
6116         (handle_vfork_child_exec_or_exit): Update.
6117         (follow_exec): Update.
6118         (displaced_step_prepare_throw): Update.
6119         (displaced_step_restore): Update.
6120         (start_step_over): Update.
6121         (resume_1): Update.
6122         (clear_proceed_status_thread): Update.
6123         (proceed): Update.
6124         (print_target_wait_results): Update.
6125         (do_target_wait): Update.
6126         (context_switch): Update.
6127         (stop_all_threads): Update.
6128         (restart_threads): Update.
6129         (finish_step_over): Update.
6130         (handle_signal_stop): Update.
6131         (switch_back_to_stepped_thread): Update.
6132         (keep_going_pass_signal): Update.
6133         (print_exited_reason): Update.
6134         (normal_stop): Update.
6135         * inferior.c (inferior_pid_to_str): Change return type.
6136         (print_selected_inferior): Update.
6137         (add_inferior): Update.
6138         (detach_inferior): Update.
6139         * dummy-frame.c (fprint_dummy_frames): Update.
6140         * dcache.c (dcache_info_1): Update.
6141         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6142         (btrace_fetch, btrace_clear): Update.
6143         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6144         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6145         type.
6146         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6147         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6148         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6149         * gdbarch.c, gdbarch.h: Rebuild.
6150         * gdbarch.sh (core_pid_to_str): Change return type.
6151         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6152         return type.
6153         (windows_nat_target::pid_to_str): Change return type.
6154         (windows_delete_thread): Update.
6155         (windows_nat_target::attach): Update.
6156         (windows_nat_target::files_info): Update.
6157         * target-delegates.c: Rebuild.
6158         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6159         return type.
6160         (sol_thread_target::pid_to_str): Change return type.
6161         * remote.c (class remote_target) <pid_to_str>: Change return
6162         type.
6163         (remote_target::pid_to_str): Change return type.
6164         (extended_remote_target::attach, remote_target::remote_stop_ns)
6165         (remote_target::remote_notif_remove_queued_reply)
6166         (remote_target::push_stop_reply, remote_target::disable_btrace):
6167         Update.
6168         (extended_remote_target::attach): Update.
6169         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6170         type.
6171         (gdbsim_target::pid_to_str): Change return type.
6172         * ravenscar-thread.c (struct ravenscar_thread_target)
6173         <pid_to_str>: Change return type.
6174         (ravenscar_thread_target::pid_to_str): Change return type.
6175         * procfs.c (class procfs_target) <pid_to_str>: Change return
6176         type.
6177         (procfs_target::pid_to_str): Change return type.
6178         (procfs_target::attach): Update.
6179         (procfs_target::detach): Update.
6180         (procfs_target::fetch_registers): Update.
6181         (procfs_target::store_registers): Update.
6182         (procfs_target::wait): Update.
6183         (procfs_target::files_info): Update.
6184         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6185         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6186         return type.
6187         (nto_procfs_target::pid_to_str): Change return type.
6188         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6189         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6190         return type.
6191         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6192         (exit_lwp): Update.
6193         (attach_proc_task_lwp_callback, get_detach_signal)
6194         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6195         (linux_nat_target::resume, wait_lwp, stop_callback)
6196         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6197         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6198         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6199         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6200         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6201         type.
6202         (inf_ptrace_target::attach): Update.
6203         (inf_ptrace_target::files_info): Update.
6204         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6205         type.
6206         (go32_nat_target::pid_to_str): Change return type.
6207         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6208         (gnu_nat_target::wait): Update.
6209         (gnu_nat_target::wait): Update.
6210         (gnu_nat_target::resume): Update.
6211         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6212         (fbsd_nat_target::wait): Update.
6213         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6214         type.
6215         (darwin_nat_target::attach): Update.
6216         * corelow.c (class core_target) <pid_to_str>: Change return type.
6217         (core_target::pid_to_str): Change return type.
6218         * target.c (normal_pid_to_str): Change return type.
6219         (default_pid_to_str): Likewise.
6220         (target_pid_to_str): Change return type.
6221         (target_translate_tls_address): Update.
6222         (target_announce_detach): Update.
6223         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6224         return type.
6225         (bsd_uthread_target::pid_to_str): Change return type.
6226         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6227         type.
6228         (bsd_kvm_target::pid_to_str): Change return type.
6229         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6230         return type.
6231         (aix_thread_target::pid_to_str): Change return type.
6232         * target.h (struct target_ops) <pid_to_str>: Change return type.
6233         (target_pid_to_str, normal_pid_to_str): Likewise.
6234         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6235         type.
6236         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6237         type.
6238         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6239         return type.
6240         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6241         type.
6242         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6243         type.
6244         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6245         return type.
6246
6247 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6248
6249         * NEWS: Mention that the new default MI version is 3.  Mention
6250         changes to the output of commands and events that deal with
6251         multi-location breakpoints.
6252         * breakpoint.c: Include "mi/mi-out.h".
6253         (print_one_breakpoint): Change output syntax if using MI version
6254         >= 3.
6255         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6256         New.
6257         (mi_multi_location_breakpoint_output_fixed): New.
6258         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6259         (mi_cmd_fix_multi_location_breakpoint_output): New.
6260         (mi_multi_location_breakpoint_output_fixed): New.
6261         * mi/mi-cmds.c (mi_cmds): Register command
6262         -fix-multi-location-breakpoint-output.
6263         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6264         interpreter "mi".
6265
6266 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6267
6268         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6269         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6270         instantiate mi_ui_out based on interpreter name.
6271         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6272         * mi/mi-main.c (mi_load_progress): Likewise.
6273
6274 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6275
6276         * NEWS: Combine separate "New targets" sections for 8.3.
6277
6278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6279
6280         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6281         (ppcfbsd_init_abi): Install gdbarch
6282         "fetch_tls_load_module_address" and "get_thread_local_address"
6283         methods.
6284
6285 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6286
6287         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6288         (riscv_fbsd_init_abi): Install gdbarch
6289         "fetch_tls_load_module_address" and "get_thread_local_address"
6290         methods.
6291
6292 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6293
6294         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6295         (i386fbsd_init_abi): Install gdbarch
6296         "fetch_tls_load_module_address" and "get_thread_local_address"
6297         methods.
6298
6299 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6300
6301         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6302         (amd64fbsd_init_abi): Install gdbarch
6303         "fetch_tls_load_module_address" and "get_thread_local_address"
6304         methods.
6305
6306 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6307
6308         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6309         (struct fbsd_pspace_data): New type.
6310         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6311         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6312         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6313         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6314         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6315
6316 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6317
6318         * gdbtypes.c (lookup_struct_elt): New function.
6319         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6320         * gdbtypes.h (struct struct_elt): New type.
6321         (lookup_struct_elt): New prototype.
6322
6323 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6324
6325         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6326         remove disabled code block.
6327
6328 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6329
6330         * gdbarch.sh (get_thread_local_address): New method.
6331         * gdbarch.h, gdbarch.c: Regenerate.
6332         * target.c (target_translate_tls_address): Use
6333         gdbarch_get_thread_local_address if present instead of
6334         target::get_thread_local_address.
6335
6336 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6337
6338         * target.h (target::get_thread_local_address): Update comment.
6339
6340 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6341
6342         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6343         objfile->separate_debug_objfile_backlink if not NULL.
6344
6345 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6346
6347         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6348         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6349         (amd64bsd_store_inferior_registers): Likewise.
6350         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6351         Enable segment base registers.
6352         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6353         PT_GETFSBASE and PT_GETGSBASE.
6354         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6355         PT_SETGSBASE.
6356         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6357         segment base registers.
6358         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6359
6360 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6361
6362         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6363         Update calls to i386_target_description to add 'segments'
6364         parameter.
6365         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6366         add segment base registers.
6367         * arch/i386.c (i386_create_target_description): Add 'segments'
6368         parameter to enable segment base registers.
6369         * arch/i386.h (i386_create_target_description): Likewise.
6370         * features/i386/32bit-segments.xml: New file.
6371         * features/i386/32bit-segments.c: Generate.
6372         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6373         call to i386_target_description to add 'segments' parameter.
6374         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6375         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6376         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6377         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6378         if feature is present.
6379         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6380         Add 'segments' parameter to call to i386_target_description.
6381         (i386_target_description): Add 'segments' parameter to enable
6382         segment base registers.
6383         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6384         to call to i386_target_description.
6385         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6386         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6387         Define I386_NUM_REGS.
6388         (i386_target_description): Add 'segments' parameter to enable
6389         segment base registers.
6390
6391 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6392
6393         PR/24325
6394         * source-cache.c: #undef open and close, to avoid unresolved
6395         externals during linking.
6396
6397 2019-03-12  Tom Tromey  <tromey@adacore.com>
6398
6399         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6400         const.  Add initializers.
6401         (_initialize_remote): Don't initialize ptid globals.
6402
6403 2019-03-12  Pedro Alves  <palves@redhat.com>
6404
6405         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6406
6407 2019-03-12  Pedro Alves  <palves@redhat.com>
6408
6409         * cp-name-parser.y (main): Remove unused 'len' variable.
6410
6411 2019-03-12  Tom Tromey  <tromey@adacore.com>
6412
6413         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6414         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6415
6416 2019-03-12  Tom Tromey  <tromey@adacore.com>
6417
6418         * linux-nat.c (iterate_over_lwps): Update.
6419         (stop_callback): Remove parameter.
6420         (stop_wait_callback, detach_callback, resume_set_callback)
6421         (select_singlestep_lwp_callback, set_ignore_sigint)
6422         (status_callback, resumed_callback, resume_clear_callback)
6423         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6424         data parameter.
6425         (linux_nat_target::detach, linux_nat_target::resume)
6426         (linux_stop_and_wait_all_lwps, select_event_lwp)
6427         (linux_nat_filter_event, linux_nat_wait_1)
6428         (linux_nat_target::kill, linux_nat_target::stop)
6429         (linux_nat_target::stop): Update.
6430         (linux_nat_resume_callback): Change type.
6431         (resume_stopped_resumed_lwps, count_events_callback)
6432         (select_event_lwp_callback): Likewise.
6433         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6434         * arm-linux-nat.c (struct update_registers_data): Remove.
6435         (update_registers_callback): Change type.
6436         (arm_linux_insert_hw_breakpoint1): Update.
6437         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6438         parameter.
6439         (x86_linux_dr_set_addr): Update.
6440         (x86_linux_dr_set_control): Update.
6441         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6442         (iterate_over_lwps): Use gdb::function_view.
6443         * nat/aarch64-linux-hw-point.c (struct
6444         aarch64_dr_update_callback_param): Remove.
6445         (debug_reg_change_callback): Change type.
6446         (aarch64_notify_debug_reg_change): Update.
6447         * s390-linux-nat.c (s390_refresh_per_info): Update.
6448
6449 2019-03-11  Tom Tromey  <tromey@adacore.com>
6450
6451         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6452         redundant assignment to "this_cu".
6453
6454 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6455
6456         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6457
6458 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6459
6460         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6461         from...
6462         (rank_one_type): ... this.
6463
6464 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6465
6466         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6467         from...
6468         (rank_one_type): ... this.
6469
6470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6471
6472         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6473         from...
6474         (rank_one_type): ... this.
6475
6476 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6477
6478         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6479         from...
6480         (rank_one_type): ... this.
6481
6482 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6483
6484         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6485         from...
6486         (rank_one_type): ... this.
6487
6488 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6489
6490         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6491         from...
6492         (rank_one_type): ... this.
6493
6494 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6495
6496         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6497         from...
6498         (rank_one_type): ... this.
6499
6500 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6501
6502         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6503         from...
6504         (rank_one_type): ... this.
6505
6506 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6507
6508         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6509         from...
6510         (rank_one_type): ... this.
6511
6512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6513
6514         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6515         from...
6516         (rank_one_type): ... this.
6517
6518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6519
6520         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6521         from...
6522         (rank_one_type): ... this.
6523
6524 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6525
6526         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6527         from...
6528         (rank_one_type): ... this.
6529
6530 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6531
6532         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6533         inferior-events' shows the example events.
6534
6535 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6536
6537         Support styling on native MS-Windows console
6538
6539         PR/24315
6540         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6541         on MS-Windows if $TERM is not defined.
6542
6543         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6544
6545         * posix-hdep.c (gdb_console_fputs):
6546         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6547         functions.
6548         * ui-file.h (gdb_console_fputs): Add prototype.
6549
6550         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6551         back to fputs only if the former returns zero.
6552
6553 2019-03-07  Tom Tromey  <tom@tromey.com>
6554
6555         * symmisc.c (print_symbol_bcache_statistics): Update.
6556         (print_objfile_statistics): Update.
6557         * symfile.c (allocate_symtab): Update.
6558         * stabsread.c: Don't include bcache.h.
6559         * psymtab.h (struct psymbol_bcache): Don't declare.
6560         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6561         (psymbol_bcache_init, psymbol_bcache_free)
6562         (psymbol_bcache_get_bcache): Don't declare.
6563         * psymtab.c (struct psymbol_bcache): Remove.
6564         (psymtab_storage::psymtab_storage): Update.
6565         (psymtab_storage::~psymtab_storage): Update.
6566         (psymbol_bcache_init, psymbol_bcache_free)
6567         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6568         (add_psymbol_to_bcache): Update.
6569         (allocate_psymtab): Update.
6570         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6571         macro_cache>: No longer pointers.
6572         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6573         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6574         * macrotab.c (macro_bcache): Update.
6575         * macroexp.c: Don't include bcache.h.
6576         * gdbtypes.c (check_types_worklist): Update.
6577         (types_deeply_equal): Remove TRY/CATCH.  Update.
6578         * elfread.c (elf_symtab_read): Update.
6579         * dwarf2read.c: Don't include bcache.h.
6580         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6581         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6582         (print_bcache_statistics, bcache_memory_used): Don't declare.
6583         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6584         methods.  Rename all data members.
6585         * bcache.c (struct bcache): Move to bcache.h.
6586         (bcache::expand_hash_table): Rename from expand_hash_table.
6587         (bcache): Remove.
6588         (bcache::insert): Rename from bcache_full.
6589         (bcache::compare): Rename from bcache_compare.
6590         (bcache_xmalloc): Remove.
6591         (bcache::~bcache): Rename from bcache_xfree.
6592         (bcache::print_statistics): Rename from print_bcache_statistics.
6593         (bcache::memory_used): Rename from bcache_memory_used.
6594
6595 2019-03-07  Pedro Alves  <palves@redhat.com>
6596
6597         * infrun.c (normal_stop): Also check for
6598         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6599
6600 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6601
6602         * f-lang.c (value_from_host_double): Moved to...
6603         * value.c (value_from_host_double): ...here.
6604         * value.h (value_from_host_double): Declare.
6605         * guile/scm-math.c (vlscm_convert_typed_number): Use
6606         value_from_host_double.
6607         (vlscm_convert_number): Likewise.
6608         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6609         * python/py-value.c (convert_value_from_python): Likewise.
6610
6611 2019-03-06  Tom Tromey  <tom@tromey.com>
6612
6613         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6614
6615 2019-03-06  Tom Tromey  <tom@tromey.com>
6616
6617         * utils.h (free_current_contents): Don't declare.
6618         * utils.c (free_current_contents): Remove.
6619
6620 2019-03-06  Tom Tromey  <tom@tromey.com>
6621
6622         * top.c (quit_force): Update.
6623         * main.c (captured_command_loop): Update.
6624         * common/new-op.c (operator new): Update.
6625         * common/common-exceptions.c (struct catcher)
6626         <save_cleanup_chain>: Remove member.
6627         (exceptions_state_mc_init): Update.
6628         (exception_try_scope_entry): Return nullptr.
6629         (exception_try_scope_exit, exception_rethrow)
6630         (throw_exception_sjlj, throw_exception_cxx): Update.
6631         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6632         (all_cleanups, do_cleanups, discard_cleanups)
6633         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6634         (restore_cleanups, restore_final_cleanups): Don't declare.
6635         (do_final_cleanups): Remove parameter.
6636         * common/cleanups.c (cleanup_chain, make_cleanup)
6637         (make_cleanup_dtor, all_cleanups, do_cleanups)
6638         (discard_my_cleanups, discard_cleanups)
6639         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6640         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6641         (null_cleanup): Remove.
6642         (do_final_cleanups): Remove parameter.
6643
6644 2019-03-06  Tom Tromey  <tom@tromey.com>
6645
6646         * remote.c (remote_target::remote_parse_stop_reply): Use
6647         unique_xmalloc_ptr.
6648
6649 2019-03-06  Tom Tromey  <tom@tromey.com>
6650
6651         * stabsread.c (struct stabs_field_info): Rename from field_info.
6652         <list, fnlist>: Add initializers.
6653         <obstack>: New member.
6654         (read_member_functions, read_struct_fields, read_baseclasses):
6655         Allocate on obstack.  Don't use cleanups.
6656         (read_one_struct_field, read_member_functions, read_struct_fields)
6657         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6658         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6659         (read_struct_type): Update.
6660
6661 2019-03-06  Tom Tromey  <tom@tromey.com>
6662
6663         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6664         * common/filestuff.h (make_cleanup_close): Don't declare.
6665         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6666         Remove.
6667
6668 2019-03-06  Tom Tromey  <tom@tromey.com>
6669
6670         * solib-aix.c: Use make_scope_exit.
6671
6672 2019-03-06  Tom Tromey  <tom@tromey.com>
6673
6674         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6675         Use make_scope_exit.
6676
6677 2019-03-06  Tom Tromey  <tom@tromey.com>
6678
6679         * solib-svr4.c (disable_probes_interface): Remove parameter.
6680         (svr4_handle_solib_event): Use make_scope_exit.
6681
6682 2019-03-06  Tom Tromey  <tom@tromey.com>
6683
6684         * remote.c (struct stop_reply_deleter): Remove.
6685         (stop_reply_up): Update.
6686         (struct stop_reply): Derive from notif_event.  Don't typedef.
6687         <regcache>: Now a std::vector.
6688         (stop_reply_xfree): Remove.
6689         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6690         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6691         (remote_target::discard_pending_stop_replies): Use delete.
6692         (remote_target::remote_parse_stop_reply): Update.
6693         (remote_target::process_stop_reply): Update.
6694         * remote-notif.h (struct notif_event): Add virtual destructor.
6695         Remove "dtr" member.
6696         (struct notif_client) <alloc_event>: Return a unique_ptr.
6697         (notif_event_xfree): Don't declare.
6698         (notif_event_up): New typedef.
6699         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6700         (notif_event_xfree, do_notif_event_xfree): Remove.
6701         (remote_notif_state_xfree): Update.
6702
6703 2019-03-06  Tom Tromey  <tom@tromey.com>
6704
6705         * infrun.c (displaced_step_clear_cleanup): Now a
6706         forward_scope_exit type.
6707         (displaced_step_prepare_throw): Update.
6708         (displaced_step_fixup): Update.
6709
6710 2019-03-06  Tom Tromey  <tom@tromey.com>
6711
6712         * inferior.h (class inferior): Update comment.
6713         * gdbthread.h (class thread_info): Update comment.
6714
6715 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6716             Tom Tromey  <tom@tromey.com>
6717
6718         * stabsread.h (struct stab_section_list): Remove.
6719         (coffstab_build_psymtabs): Update.
6720         * dbxread.c (symbuf_sections): Now a std::vector.
6721         (sect_idx): New global.
6722         (fill_symbuf): Update.
6723         (coffstab_build_psymtabs): Change type of stabsects parameter.
6724         Update.
6725         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6726         std::vector.
6727         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6728         (coff_locate_sections): Update.
6729         (coff_symfile_read): Remove cleanups.  Update.
6730         (init_stringtab): Add storage parameter.
6731         (free_stringtab, free_stringtab_cleanup): Remove.
6732         (init_lineno): Add storage parameter.
6733         (free_linetab, free_linetab_cleanup): Remove.
6734
6735 2019-03-06  Pedro Alves  <palves@redhat.com>
6736
6737         * linux-fork.c (fork_info::clobber_regs): Delete.
6738         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6739         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6740         comment.  Adjust.
6741         (scoped_switch_fork_info::scoped_switch_fork_info)
6742         (checkpoint_command, linux_fork_context): Adjust
6743         fork_save_infrun_state calls.
6744
6745 2019-03-06  Pedro Alves  <palves@redhat.com>
6746
6747         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6748         (inf_has_multiple_threads): Return 'bool' and rewrite using
6749         inferior_info::threads().
6750
6751 2019-03-06  Pedro Alves  <palves@redhat.com>
6752
6753         * linux-fork.c: Include <list>.
6754         (fork_list): Now a std::list instance.
6755         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6756         (forks_exist_p, find_last_fork): Adjust.
6757         (new_fork): Delete.
6758         (one_fork_p): New.
6759         (add_fork): Adjust.
6760         (free_fork): Delete, folded into fork_info::~fork_info().
6761         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6762         Adjust.
6763         (init_fork_list): Delete.
6764         (linux_fork_killall, linux_fork_mourn_inferior)
6765         (linux_fork_detach, info_checkpoints_command): Adjust.
6766         (_initialize_linux_fork): No longer call init_fork_list.
6767
6768 2019-03-06  Pedro Alves  <palves@redhat.com>
6769
6770         * linux-fork.c (new_fork): New, split out of ...
6771         (add_fork): ... this.  Return void.  Move "first fork" special
6772         case from here, to ...
6773         (checkpoint_command): ... here.
6774         * linux-linux.h (add_fork): Return void.
6775
6776 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6777
6778         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6779
6780 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6781             Chris January  <chris.january@arm.com>
6782             David Lecomber  <david.lecomber@arm.com>
6783
6784         * f-exp.y: New token, UNOP_INTRINSIC.
6785         (exp): New pattern using UNOP_INTRINSIC token.
6786         (f77_keywords): Add 'abs' keyword.
6787         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6788         (value_from_host_double): New function.
6789         (evaluate_subexp_f): Support UNOP_ABS.
6790
6791 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6792
6793         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6794         types.
6795
6796 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6797
6798         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6799         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6800         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6801
6802 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6803
6804         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6805
6806 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6807             Chris January  <chris.january@arm.com>
6808
6809         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6810         * f-exp.y: Define 'KIND' token.
6811         (exp): New pattern for KIND expressions.
6812         (ptype): Handle types with a kind extension.
6813         (direct_abs_decl): Extend to spot kind extensions.
6814         (f77_keywords): Add 'kind' to the list.
6815         (push_kind_type): New function.
6816         (convert_to_kind_type): New function.
6817         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6818         * parse.c (operator_length_standard): Likewise.
6819         * parser-defs.h (enum type_pieces): Add tp_kind.
6820         * std-operator.def: Add UNOP_KIND.
6821
6822 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6823
6824         * f-exp.y (f_parse): Set yydebug.
6825
6826 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6827
6828         * f-lang.c (evaluate_subexp_f): New function.
6829         (exp_descriptor_f): New global.
6830         (f_language_defn): Use exp_descriptor_f instead of
6831         exp_descriptor_standard.
6832
6833 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6834
6835         * f-exp.y (struct token): Add comments.
6836         (dot_ops): Remove uppercase versions and the end marker.
6837         (f77_keywords): Likewise.
6838         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6839         entries in the dot_ops array are case insensitive, and use
6840         strncasecmp to compare strings.  Also some whitespace cleanup in
6841         this area.  Similar for the f77_keywords array, except entries in
6842         this list might be case sensitive.
6843
6844 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6845
6846         * f-exp.y (struct f77_boolean_val): Add comments.
6847         (boolean_values): Remove uppercase versions, and end marker.
6848         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6849         and use strncasecmp to achieve case insensitivity.  Additionally,
6850         perform whitespace cleanup around this code.
6851
6852 2019-03-06  Tom Tromey  <tromey@adacore.com>
6853
6854         * remote-sim.c (gdbsim_target_open): Use result of
6855         gdb_argv::release.
6856
6857 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6858         Dirk Schubert  <dirk.schubert@arm.com>
6859         Chris January  <chris.january@arm.com>
6860
6861         * eval.c (evaluate_subexp_standard): Call Fortran argument
6862         wrapping logic.
6863         * f-lang.c (struct value): A value which can be passed into a
6864         Fortran function call.
6865         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6866         where appropriate.
6867         (struct type): Value ready for a Fortran function call.
6868         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6869         is needed.
6870         * f-lang.h (fortran_argument_convert): Declaration.
6871         (fortran_preserve_arg_pointer): Declaration.
6872         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6873
6874 2019-03-05  Tom Tromey  <tromey@adacore.com>
6875
6876         * python/py-prettyprint.c (print_string_repr): Remove #if.
6877         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6878
6879 2019-03-05  Tom Tromey  <tromey@adacore.com>
6880
6881         * target.c (the_dummy_target): Move later.  Change type to
6882         "dummy_target".
6883         (initialize_targets): Don't initialize the_dummy_target.
6884
6885 2019-03-05  Tom Tromey  <tromey@adacore.com>
6886
6887         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6888         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6889
6890 2019-03-05  Tom Tromey  <tromey@adacore.com>
6891
6892         * windows-nat.c (windows_nat_target::attach)
6893         (windows_nat_target::detach): Don't call gdb_flush.
6894         * valprint.c (generic_val_print, val_print, val_print_string):
6895         Don't call gdb_flush.
6896         * utils.c (defaulted_query): Don't call gdb_flush.
6897         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6898         * target.c (target_announce_detach): Don't call gdb_flush.
6899         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6900         * remote.c (extended_remote_target::attach): Don't call
6901         gdb_flush.
6902         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6903         * printcmd.c (do_examine): Don't call gdb_flush.
6904         (info_display_command): Don't call gdb_flush.
6905         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6906         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6907         * memattr.c (info_mem_command): Don't call gdb_flush.
6908         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6909         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6910         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6911         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6912         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6913         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6914         (gnu_nat_target::detach): Don't call gdb_flush.
6915         * f-valprint.c (f_val_print): Don't call gdb_flush.
6916         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6917         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6918         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6919         gdb_flush.
6920         * c-valprint.c (c_val_print): Don't call gdb_flush.
6921         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6922
6923 2019-03-05  Tom Tromey  <tromey@adacore.com>
6924
6925         * varobj.c (update_dynamic_varobj_children): Update.
6926         (install_default_visualizer): Use reset, not release.
6927         * value.c (set_internalvar): Update.
6928         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6929         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6930         ATTRIBUTE_UNUSED_RESULT.
6931
6932 2019-03-05  Tom Tromey  <tromey@adacore.com>
6933
6934         * remote.c (class scoped_remote_fd) <release>: Add
6935         ATTRIBUTE_UNUSED_RESULT.
6936
6937 2019-03-05  Tom Tromey  <tromey@adacore.com>
6938
6939         * macroexp.c (struct macro_buffer) <release>: Add
6940         ATTRIBUTE_UNUSED_RESULT.
6941
6942 2019-03-05  Tom Tromey  <tromey@adacore.com>
6943
6944         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6945         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6946         ATTRIBUTE_UNUSED_RESULT.
6947
6948 2019-03-05  Tom Tromey  <tromey@adacore.com>
6949
6950         * common/scoped_fd.h (class scoped_fd) <release>: Add
6951         ATTRIBUTE_UNUSED_RESULT.
6952
6953 2019-03-05  Tom Tromey  <tromey@adacore.com>
6954
6955         * parser-defs.h (struct parser_state) <release>: Add
6956         ATTRIBUTE_UNUSED_RESULT.
6957
6958 2019-03-05  Tom Tromey  <tromey@adacore.com>
6959
6960         * utils.h (class gdb_argv) <release>: Add
6961         ATTRIBUTE_UNUSED_RESULT.
6962         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6963
6964 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6965
6966         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6967         for-loop range, to avoid compiler warnings.
6968
6969         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6970         avoid compiler warnings about unused variables.
6971
6972         * NEWS: Mention end of support for native debugging on MS-Windows
6973         before XP.
6974
6975         PR gdb/24292
6976         * common/netstuff.c:
6977         * gdbserver/gdbreplay.c
6978         * gdbserver/remote-utils.c:
6979         * ser-tcp.c:
6980         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6981         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6982         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6983         'getaddrinfo' and 'freeaddrinfo' were not available before
6984         Windows XP, and mingw.org's MinGW headers by default define
6985         _WIN32_WINNT to 0x500.
6986
6987 2019-03-01  Gary Benson <gbenson@redhat.com>
6988
6989         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6990
6991 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6992             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6993
6994         PR gdb/8527
6995         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6996         set_sigint_trap, clear_sigint_trap.
6997
6998 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6999
7000         * target.c (target_detach): Clear the regcache and the
7001         frame cache.
7002
7003 2019-02-27  Pedro Alves  <palves@redhat.com>
7004
7005         * utils.c (set_screen_size): When we cap the height/width sizes,
7006         tweak the corresponding command variable to show "unlimited":
7007
7008 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7009             Pedro Alves  <palves@redhat.com>
7010
7011         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7012         before calling rl_set_screen_size.
7013
7014 2019-02-27  Tom Tromey  <tromey@adacore.com>
7015
7016         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7017         define.
7018         * python/py-value.c: Remove Python 2.4 workaround.
7019         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7020         workaround.
7021         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7022         Python 2.4 workaround.
7023         * python/python-internal.h: Remove Python 2.4 comment.
7024         (Py_ssize_t): Don't define.
7025         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7026         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7027         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7028         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7029         * python/python.c (do_start_initialization): Remove Python 2.4
7030         workaround.
7031         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7032         (print_children): Remove Python 2.4 workaround.
7033         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7034         workaround.
7035         (CHARBUFFERPROC_NAME): Remove.
7036         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7037         Python 2.4 workaround.
7038
7039 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7040
7041         * NEWS: Note minimum Python version.
7042
7043 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7044
7045         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7046         code from these functions.  Remove corresponding ifdefs.  Use
7047         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7048         Remove gotos and target of gotos.
7049         (infpy_search_memory): Likewise.
7050
7051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7052
7053         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7054         (hppa_gdbarch_init): Don't register deleted functions with
7055         gdbarch.
7056
7057 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7058
7059         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7060         (h8300_unwind_sp): Delete.
7061         (h8300_dummy_id): Delete.
7062         (h8300_gdbarch_init): Don't register deleted functions with
7063         gdbarch.
7064
7065 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7066
7067         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7068         (ft32_unwind_pc): Delete.
7069         (ft32_unwind_sp): Delete.
7070         (ft32_gdbarch_init): Don't register deleted functions with
7071         gdbarch.
7072
7073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7074
7075         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7076         (frv_unwind_pc): Delete.
7077         (frv_unwind_sp): Delete.
7078         (frv_gdbarch_init): Don't register deleted functions with
7079         gdbarch.
7080
7081 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7082
7083         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7084         (riscv_unwind_pc): Delete.
7085         (riscv_unwind_sp): Delete.
7086         (riscv_gdbarch_init): Don't register deleted functions with
7087         gdbarch.
7088
7089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7090
7091         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7092         (csky_unwind_pc): Delete.
7093         (csky_unwind_sp): Delete.
7094         (csky_gdbarch_init): Don't register deleted functions with
7095         gdbarch.
7096
7097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7098
7099         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7100         (cris_unwind_pc): Delete.
7101         (cris_unwind_sp): Delete.
7102         (cris_gdbarch_init): Don't register deleted functions with
7103         gdbarch.
7104
7105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7106
7107         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7108         (bfin_unwind_pc): Delete.
7109         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7110
7111 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7112
7113         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7114         (arm_unwind_pc): Delete.
7115         (arm_unwind_sp): Delete.
7116         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7117
7118 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7119
7120         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7121         (arc_unwind_pc): Delete.
7122         (arc_unwind_sp): Delete.
7123         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7124
7125 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7126
7127         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7128         (alpha_unwind_pc): Delete.
7129         (alpha_gdbarch_init): Don't register deleted functions with
7130         gdbarch.
7131
7132 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7133
7134         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7135         (aarch64_unwind_pc): Delete.
7136         (aarch64_unwind_sp): Delete.
7137         (aarch64_gdbarch_init): Don't register deleted functions with
7138         gdbarch.
7139
7140 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7141
7142         * gdbtypes.c (type_align): Don't consider static members when
7143         computing structure alignment.
7144
7145 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7146
7147         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7148         return 0 for other types.
7149         * arch-utils.c (default_type_align): Always return 0.
7150         * gdbarch.h: Regenerate.
7151         * gdbarch.sh (type_align): Extend comment.
7152         * gdbtypes.c (type_align): Add additional comments, always call
7153         gdbarch_type_align before applying the default rules.
7154         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7155         generic code will then apply a suitable default.
7156         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7157         types, return 0 for other types.
7158
7159 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7160
7161         * NEWS: Create a new section for the next release branch.
7162         Rename the section of the current branch, now that it has
7163         been cut.
7164
7165 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7166
7167         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7168         * version.in: Bump version to 8.3.50.DATE-git.
7169
7170 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7171
7172         * aix-thread.c (ptid_cmp): Remove unused variable.
7173         (get_signaled_thread): Likewise.
7174         (store_regs_user_thread): Likewise.
7175         (store_regs_kernel_thread): Likewise.
7176         (fetch_regs_kernel_thread): Remove shadowed variable.
7177
7178 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7179
7180         * features/riscv/32bit-cpu.xml: Add register numbers.
7181         * features/riscv/32bit-fpu.c: Regenerate.
7182         * features/riscv/32bit-fpu.xml: Add register numbers.
7183         * features/riscv/64bit-cpu.xml: Add register numbers.
7184         * features/riscv/64bit-fpu.c: Regenerate.
7185         * features/riscv/64bit-fpu.xml: Add register numbers.
7186
7187 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7188
7189         * NEWS: Mention two argument form of gdb.Value constructor.
7190         * python/py-value.c (convert_buffer_and_type_to_value): New
7191         function.
7192         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7193         Add support for handling an optional second argument.  Call
7194         convert_buffer_and_type_to_value as appropriate.
7195         * python/python-internal.h (Py_buffer_deleter): New struct.
7196         (Py_buffer_up): New typedef.
7197
7198 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7199
7200         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7201         instead of releasing ownership.
7202
7203 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7204
7205         * dwarf2read.c (open_and_init_dwp_file): Call
7206         elf_numsections instead of bfd_count_sections to initialize
7207         dwp_file->num_sections.
7208
7209 2019-02-25  Tom Tromey  <tromey@adacore.com>
7210
7211         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7212
7213 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7214
7215         * gcore.in: Add '--readnever' option when invoking GDB.
7216
7217 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7218
7219         * MAINTAINERS: Update my email address.
7220
7221 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7222
7223         * build-id.c (build_id_to_debug_bfd_1): New function.
7224         (build_id_to_debug_bfd): Look for separate debug file in
7225         sysroot.
7226
7227 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7228
7229         * gdbarch.sh: Update the copyright year range that is placed into
7230         generated files.
7231
7232 2019-02-22  Keith Seitz  <keiths@redhat.com>
7233
7234         PR symtab/23853
7235         * linespec.c (create_sals_line_offset): Search for the default
7236         symtab's filename instead of its fullname.
7237
7238 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7239
7240         * NEWS: Update style defaults.
7241
7242 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7243
7244         * main.c (captured_main_1): Disable styling in batch mode.
7245
7246 2019-02-20  Tom Tromey  <tom@tromey.com>
7247
7248         * symtab.c (symtab_symbol_info): Fix typos.
7249
7250 2019-02-20  Tom Tromey  <tromey@adacore.com>
7251
7252         * findcmd.c (_initialize_mem_search): Use upper case for
7253         metasyntactic variables.
7254
7255 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7256
7257         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7258         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7259
7260 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7261
7262         * top.h (source_file_name): Change to std::string.
7263         * top.c (source_file_name): Likewise.
7264         (command_line_input): Adjust.
7265         * cli/cli-script.c (script_from_file): Adjust.
7266
7267 2019-02-19  Tom Tromey  <tromey@adacore.com>
7268
7269         * ravenscar-thread.c
7270         (ravenscar_thread_target::update_thread_list): Don't call
7271         ada_build_task_list.
7272         * ada-lang.h (ada_build_task_list): Don't declare.
7273         * ada-tasks.c (struct ada_tasks_inferior_data)
7274         <task_list_valid_p>: Now bool.
7275         (read_known_tasks, ada_task_list_changed)
7276         (ada_tasks_invalidate_inferior_data): Update.
7277         (read_known_tasks_array): Return bool.
7278         (read_known_tasks_list): Likewise.
7279         (read_known_tasks): Return void.
7280         (ada_build_task_list): Now static.
7281
7282 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7283
7284         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7285         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7286
7287 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7288
7289         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7290         variant for ada_tasks_pspace_data_handle and
7291         ada_tasks_inferior_data_handle.
7292         (ada_tasks_pspace_data_cleanup): New function.
7293         (ada_tasks_inferior_data_cleanup): New function.
7294
7295 2019-02-17  Tom Tromey  <tom@tromey.com>
7296
7297         * macrotab.h (macro_source_fullname): Return a std::string.
7298         * macrotab.c (macro_include, check_for_redefinition)
7299         (macro_undef, macro_lookup_definition, foreach_macro)
7300         (foreach_macro_in_scope): Update.
7301         (macro_source_fullname): Return a std::string.
7302         * macrocmd.c (show_pp_source_pos): Update.
7303
7304 2019-02-17  Tom Tromey  <tom@tromey.com>
7305
7306         * macrocmd.c (show_pp_source_pos): Style the file names.
7307
7308 2019-02-17  Tom Tromey  <tom@tromey.com>
7309
7310         PR tui/24197:
7311         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7312
7313 2019-02-17  Tom Tromey  <tom@tromey.com>
7314
7315         * ada-lang.c (user_select_syms): Use filtered printing.
7316         * utils.c (wrap_style): New global.
7317         (desired_style): Remove.
7318         (emit_style_escape): Add stream parameter.
7319         (set_output_style, reset_terminal_style, prompt_for_continue):
7320         Update.
7321         (flush_wrap_buffer): Only flush gdb_stdout.
7322         (wrap_here): Set wrap_style.
7323         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7324         treat escape sequences as a character.  Change when wrap buffer is
7325         flushed.
7326         (fputs_styled): Do not set the output style when the default is
7327         requested.
7328         * ui-style.h (struct ui_file_style) <is_default>: New method.
7329         * source.c (print_source_lines_base): Emit escape sequences in one
7330         piece.
7331
7332 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7333
7334         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7335         integers and enumeration types.
7336
7337 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7338
7339         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7340         instead of lookup_symbol_in_language
7341         (do_exact_match): New function.
7342         (ada_get_symbol_name_matcher): Return do_exact_match when
7343         doing a verbatim match.
7344
7345 2019-02-15  Tom Tromey  <tromey@adacore.com>
7346
7347         * ravenscar-thread.c (ravenscar_thread_target::resume)
7348         (ravenscar_thread_target::wait): Special case wildcard requests.
7349
7350 2019-02-15  Tom Tromey  <tromey@adacore.com>
7351
7352         * ravenscar-thread.c (base_ptid): Remove.
7353         (struct ravenscar_thread_target) <close>: New method.
7354         <m_base_ptid>: New member.
7355         <update_inferior_ptid, active_task, task_is_currently_active,
7356         runtime_initialized>: Declare methods.
7357         <ravenscar_thread_target>: Add constructor.
7358         (ravenscar_thread_target::task_is_currently_active)
7359         (ravenscar_thread_target::update_inferior_ptid)
7360         (ravenscar_runtime_initialized): Rename.  Now methods.
7361         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7362         (ravenscar_thread_target::update_thread_list): Update.
7363         (ravenscar_thread_target::active_task): Now method.
7364         (ravenscar_thread_target::store_registers)
7365         (ravenscar_thread_target::prepare_to_store)
7366         (ravenscar_thread_target::prepare_to_store)
7367         (ravenscar_thread_target::mourn_inferior): Update.
7368         (ravenscar_inferior_created): Use "new" to create target.
7369         (ravenscar_thread_target::get_ada_task_ptid): Update.
7370         (_initialize_ravenscar): Don't initialize base_ptid.
7371         (ravenscar_ops): Remove global.
7372
7373 2019-02-15  Tom Tromey  <tromey@adacore.com>
7374
7375         * target.h (push_target): Declare new overload.
7376         * target.c (push_target): New overload, taking an rvalue reference.
7377         * remote.c (remote_target::open_1): Use push_target overload.
7378         * corelow.c (core_target_open): Use push_target overload.
7379
7380 2019-02-15  Tom Tromey  <tromey@adacore.com>
7381
7382         * ravenscar-thread.c (is_ravenscar_task)
7383         (ravenscar_task_is_currently_active): Return bool.
7384         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7385         (_initialize_ravenscar): Remove "(void)".
7386         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7387         Return bool.
7388
7389 2019-02-15  Tom Tromey  <tromey@adacore.com>
7390
7391         * ravenscar-thread.c (ravenscar_runtime_initializer)
7392         (has_ravenscar_runtime, get_running_thread_id)
7393         (ravenscar_thread_target::resume): Fix indentation.
7394
7395 2019-02-15  Tom Tromey  <tromey@adacore.com>
7396
7397         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7398         from ravenscar_arch_ops.
7399         (sparc_ravenscar_ops::fetch_registers)
7400         (sparc_ravenscar_ops::store_registers): Now methods.
7401         (sparc_ravenscar_prepare_to_store): Remove.
7402         (sparc_ravenscar_ops): Redefine.
7403         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7404         methods and destructor.  Remove members.
7405         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7406         (ravenscar_thread_target::store_registers)
7407         (ravenscar_thread_target::prepare_to_store): Update.
7408         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7409         Remove.
7410         (struct ppc_ravenscar_powerpc_ops): Derive from
7411         ravenscar_arch_ops.
7412         (ppc_ravenscar_powerpc_ops::fetch_registers)
7413         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7414         (ppc_ravenscar_powerpc_ops): Redefine.
7415         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7416         (ppc_ravenscar_e500_ops::fetch_registers)
7417         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7418         (ppc_ravenscar_e500_ops): Redefine.
7419         * aarch64-ravenscar-thread.c
7420         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7421         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7422         (aarch64_ravenscar_fetch_registers)
7423         (aarch64_ravenscar_store_registers): Now methods.
7424         (aarch64_ravenscar_ops): Redefine.
7425
7426 2019-02-15  Tom Tromey  <tromey@adacore.com>
7427
7428         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7429         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7430         (ravenscar_thread_target::stopped_by_watchpoint)
7431         (ravenscar_thread_target::stopped_data_address)
7432         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7433
7434 2019-02-15  Tom Tromey  <tromey@adacore.com>
7435
7436         * ravenscar-thread.c: Fix some typos.
7437
7438 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7439             Tom Tromey  <tromey@adacore.com>
7440
7441         * ada-lang.c (ada_exception_sal): Change addr_string to a
7442         std::string.
7443         (create_ada_exception_catchpoint): Update.
7444
7445 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7446             Tom Tromey  <tromey@adacore.com>
7447
7448         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7449         (bp_location_ops): Remove.
7450         (base_breakpoint_allocate_location): Update.
7451         (free_bp_location): Update.
7452         * ada-lang.c (class ada_catchpoint_location)
7453         <ada_catchpoint_location>: Remove ops parameter.
7454         (ada_catchpoint_location_dtor): Remove.
7455         (ada_catchpoint_location_ops): Remove.
7456         (allocate_location_exception): Update.
7457         * breakpoint.h (struct bp_location_ops): Remove.
7458         (class bp_location) <bp_location>: Remove bp_location_ops
7459         parameter.
7460         <~bp_location>: Add destructor.
7461         <ops>: Remove.
7462
7463 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7464             Pedro Alves  <palves@redhat.com>
7465
7466         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7467         'PATH_MAX'.
7468
7469 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7470             Samuel Thibault  <samuel.thibault@gnu.org>
7471             Thomas Schwinge  <thomas@codesourcery.com>
7472
7473         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7474         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7475
7476 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7477
7478         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7479         (check_empty): Use "const char *".
7480
7481         * gnu-nat.c (gnu_nat_target::detach): Instead of
7482         'detach_inferior (pid)' call
7483         'detach_inferior (find_inferior_pid (pid))'.
7484
7485         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7486         'nat/fork-inferior.o'.
7487         * gnu-nat.c: #include "nat/fork-inferior.h".
7488
7489         * gnu-nat.c (gnu_nat_target::detach): Instead of
7490         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7491         * gnu-nat.h: #include "inf-child.h".
7492         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7493         'i386_gnu_nat_target::fetch_registers'.
7494         (gnu_store_registers): Rename/move to
7495         'i386_gnu_nat_target::store_registers'.
7496
7497         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7498         * gnu-nat.h (mach_thread_info): New function.
7499         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7500
7501         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7502
7503 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7504
7505         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7506
7507 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7508
7509         * windows-nat.c (windows_add_thread): Add new parameter
7510         "main_thread_p" with default value set to false.  Update
7511         function documentation as well as all callers.
7512         (windows_delete_thread): Likewise.
7513         (fake_create_process): Update call to windows_add_thread.
7514         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7515         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7516         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7517         call to windows_delete_thread.
7518
7519 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7520
7521         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7522
7523 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7524
7525         * symfile.c (find_separate_debug_file): Use canonical path of
7526         sysroot with child_path instead of gdb_sysroot if it is valid.
7527
7528 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7529
7530         * symfile.c (find_separate_debug_file): Use child_path to
7531         determine if an object file is under a sysroot.
7532
7533 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7534
7535         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7536         unittests/child-path-selftests.c.
7537         * common/pathstuff.c (child_path): New function.
7538         * common/pathstuff.h (child_path): New prototype.
7539         * unittests/child-path-selftests.c: New file.
7540
7541 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7542
7543         * symfile.c (find_separate_debug_file): Look for separate debug
7544         files in debug directories under the sysroot.
7545
7546 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7547
7548         * symtab.h (struct minimal_symbol data_p): New const method.
7549         (struct minimal_symbol text_p): Likewise.
7550         * symtab.c (output_source_filename): Use file name style
7551         to print file name.
7552         (print_symbol_info): Likewise.
7553         (print_msymbol_info): Use address style to print addresses.
7554         Use function name style to print executable text symbols.
7555         (expand_symtab_containing_pc): Use data_p.
7556         (find_pc_sect_compunit_symtab): Likewise.
7557
7558 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7559
7560         * breakpoint.c (describe_other_breakpoints): Use address style
7561         to print addresses.
7562         (say_where): Likewise.
7563
7564 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7565
7566         * ada-typeprint.c (print_func_type): Print function name
7567         style to print function name.
7568         * c-typeprint.c (c_print_type_1): Likewise.
7569
7570 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7571
7572         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7573         for execve.
7574
7575 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7576
7577         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7578         type_stack.
7579
7580 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7581
7582         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7583         TYPE_CODE_REF types.
7584
7585 2019-02-08  Jim Wilson  <jimw@sifive.com>
7586
7587         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7588         (riscv_linux_fregset): New.
7589         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7590
7591 2019-02-07  Tom Tromey  <tom@tromey.com>
7592
7593         * thread.c (thread_cancel_execution_command): Update.
7594         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7595         methods.
7596         (struct thread_fsm_ops): Remove.
7597         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7598         (thread_fsm_should_stop, thread_fsm_return_value)
7599         (thread_fsm_set_finished, thread_fsm_finished_p)
7600         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7601         Don't declare.
7602         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7603         * infrun.c (clear_proceed_status_thread)
7604         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7605         (print_stop_event): Update.
7606         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7607         Add constructor.
7608         (step_command_fsm_ops): Remove.
7609         (new_step_command_fsm): Remove.
7610         (step_1): Update.
7611         (step_command_fsm::should_stop): Rename from
7612         step_command_fsm_should_stop.
7613         (step_command_fsm::clean_up): Rename from
7614         step_command_fsm_clean_up.
7615         (step_command_fsm::do_async_reply_reason): Rename from
7616         step_command_fsm_async_reply_reason.
7617         (struct until_next_fsm): Inherit from thread_fsm.  Add
7618         constructor.
7619         (until_next_fsm_ops): Remove.
7620         (new_until_next_fsm): Remove.
7621         (until_next_fsm::should_stop): Rename from
7622         until_next_fsm_should_stop.
7623         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7624         (until_next_fsm::do_async_reply_reason): Rename from
7625         until_next_fsm_async_reply_reason.
7626         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7627         constructor.  Change type of breakpoint.
7628         (finish_command_fsm_ops): Remove.
7629         (new_finish_command_fsm): Remove.
7630         (finish_command_fsm::should_stop): Rename from
7631         finish_command_fsm_should_stop.
7632         (finish_command_fsm::clean_up): Rename from
7633         finish_command_fsm_clean_up.
7634         (finish_command_fsm::return_value): Rename from
7635         finish_command_fsm_return_value.
7636         (finish_command_fsm::do_async_reply_reason): Rename from
7637         finish_command_fsm_async_reply_reason.
7638         (finish_command): Update.
7639         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7640         Add constructor.
7641         (call_thread_fsm_ops): Remove.
7642         (call_thread_fsm::call_thread_fsm): Rename from
7643         new_call_thread_fsm.
7644         (call_thread_fsm::should_stop): Rename from
7645         call_thread_fsm_should_stop.
7646         (call_thread_fsm::should_notify_stop): Rename from
7647         call_thread_fsm_should_notify_stop.
7648         (run_inferior_call, call_function_by_hand_dummy): Update.
7649         * cli/cli-interp.c (should_print_stop_to_console): Update.
7650         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7651         Add constructor.  Change type of location_breakpoint,
7652         caller_breakpoint.
7653         (until_break_fsm_ops): Remove.
7654         (new_until_break_fsm): Remove.
7655         (until_break_fsm::should_stop): Rename from
7656         until_break_fsm_should_stop.
7657         (until_break_fsm::clean_up): Rename from
7658         until_break_fsm_clean_up.
7659         (until_break_fsm::do_async_reply_reason): Rename from
7660         until_break_fsm_async_reply_reason.
7661         (until_break_command): Update.
7662         * thread-fsm.c: Remove.
7663         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7664
7665 2019-02-07  Tom Tromey  <tom@tromey.com>
7666
7667         * yy-remap.h: Add include guard.
7668         * xtensa-tdep.h: Add include guard.
7669         * xcoffread.h: Rename include guard.
7670         * varobj-iter.h: Add include guard.
7671         * tui/tui.h: Rename include guard.
7672         * tui/tui-winsource.h: Rename include guard.
7673         * tui/tui-wingeneral.h: Rename include guard.
7674         * tui/tui-windata.h: Rename include guard.
7675         * tui/tui-win.h: Rename include guard.
7676         * tui/tui-stack.h: Rename include guard.
7677         * tui/tui-source.h: Rename include guard.
7678         * tui/tui-regs.h: Rename include guard.
7679         * tui/tui-out.h: Rename include guard.
7680         * tui/tui-layout.h: Rename include guard.
7681         * tui/tui-io.h: Rename include guard.
7682         * tui/tui-hooks.h: Rename include guard.
7683         * tui/tui-file.h: Rename include guard.
7684         * tui/tui-disasm.h: Rename include guard.
7685         * tui/tui-data.h: Rename include guard.
7686         * tui/tui-command.h: Rename include guard.
7687         * tic6x-tdep.h: Add include guard.
7688         * target/waitstatus.h: Rename include guard.
7689         * target/wait.h: Rename include guard.
7690         * target/target.h: Rename include guard.
7691         * target/resume.h: Rename include guard.
7692         * target-float.h: Rename include guard.
7693         * stabsread.h: Add include guard.
7694         * rs6000-tdep.h: Add include guard.
7695         * riscv-fbsd-tdep.h: Add include guard.
7696         * regformats/regdef.h: Rename include guard.
7697         * record.h: Rename include guard.
7698         * python/python.h: Rename include guard.
7699         * python/python-internal.h: Rename include guard.
7700         * python/py-stopevent.h: Rename include guard.
7701         * python/py-ref.h: Rename include guard.
7702         * python/py-record.h: Rename include guard.
7703         * python/py-record-full.h: Rename include guard.
7704         * python/py-record-btrace.h: Rename include guard.
7705         * python/py-instruction.h: Rename include guard.
7706         * python/py-events.h: Rename include guard.
7707         * python/py-event.h: Rename include guard.
7708         * procfs.h: Add include guard.
7709         * proc-utils.h: Add include guard.
7710         * p-lang.h: Add include guard.
7711         * or1k-tdep.h: Rename include guard.
7712         * observable.h: Rename include guard.
7713         * nto-tdep.h: Rename include guard.
7714         * nat/x86-linux.h: Rename include guard.
7715         * nat/x86-linux-dregs.h: Rename include guard.
7716         * nat/x86-gcc-cpuid.h: Add include guard.
7717         * nat/x86-dregs.h: Rename include guard.
7718         * nat/x86-cpuid.h: Rename include guard.
7719         * nat/ppc-linux.h: Rename include guard.
7720         * nat/mips-linux-watch.h: Rename include guard.
7721         * nat/linux-waitpid.h: Rename include guard.
7722         * nat/linux-ptrace.h: Rename include guard.
7723         * nat/linux-procfs.h: Rename include guard.
7724         * nat/linux-osdata.h: Rename include guard.
7725         * nat/linux-nat.h: Rename include guard.
7726         * nat/linux-namespaces.h: Rename include guard.
7727         * nat/linux-btrace.h: Rename include guard.
7728         * nat/glibc_thread_db.h: Rename include guard.
7729         * nat/gdb_thread_db.h: Rename include guard.
7730         * nat/gdb_ptrace.h: Rename include guard.
7731         * nat/fork-inferior.h: Rename include guard.
7732         * nat/amd64-linux-siginfo.h: Rename include guard.
7733         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7734         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7735         * nat/aarch64-linux.h: Rename include guard.
7736         * nat/aarch64-linux-hw-point.h: Rename include guard.
7737         * mn10300-tdep.h: Add include guard.
7738         * mips-linux-tdep.h: Add include guard.
7739         * mi/mi-parse.h: Rename include guard.
7740         * mi/mi-out.h: Rename include guard.
7741         * mi/mi-main.h: Rename include guard.
7742         * mi/mi-interp.h: Rename include guard.
7743         * mi/mi-getopt.h: Rename include guard.
7744         * mi/mi-console.h: Rename include guard.
7745         * mi/mi-common.h: Rename include guard.
7746         * mi/mi-cmds.h: Rename include guard.
7747         * mi/mi-cmd-break.h: Rename include guard.
7748         * m2-lang.h: Add include guard.
7749         * location.h: Rename include guard.
7750         * linux-record.h: Rename include guard.
7751         * linux-nat.h: Add include guard.
7752         * linux-fork.h: Add include guard.
7753         * i386-darwin-tdep.h: Rename include guard.
7754         * hppa-linux-offsets.h: Add include guard.
7755         * guile/guile.h: Rename include guard.
7756         * guile/guile-internal.h: Rename include guard.
7757         * gnu-nat.h: Rename include guard.
7758         * gdb-stabs.h: Rename include guard.
7759         * frv-tdep.h: Add include guard.
7760         * f-lang.h: Add include guard.
7761         * event-loop.h: Add include guard.
7762         * darwin-nat.h: Rename include guard.
7763         * cp-abi.h: Rename include guard.
7764         * config/sparc/nm-sol2.h: Rename include guard.
7765         * config/nm-nto.h: Rename include guard.
7766         * config/nm-linux.h: Add include guard.
7767         * config/i386/nm-i386gnu.h: Rename include guard.
7768         * config/djgpp/nl_types.h: Rename include guard.
7769         * config/djgpp/langinfo.h: Rename include guard.
7770         * compile/gcc-cp-plugin.h: Add include guard.
7771         * compile/gcc-c-plugin.h: Add include guard.
7772         * compile/compile.h: Rename include guard.
7773         * compile/compile-object-run.h: Rename include guard.
7774         * compile/compile-object-load.h: Rename include guard.
7775         * compile/compile-internal.h: Rename include guard.
7776         * compile/compile-cplus.h: Rename include guard.
7777         * compile/compile-c.h: Rename include guard.
7778         * common/xml-utils.h: Rename include guard.
7779         * common/x86-xstate.h: Rename include guard.
7780         * common/version.h: Rename include guard.
7781         * common/vec.h: Rename include guard.
7782         * common/tdesc.h: Rename include guard.
7783         * common/selftest.h: Rename include guard.
7784         * common/scoped_restore.h: Rename include guard.
7785         * common/scoped_mmap.h: Rename include guard.
7786         * common/scoped_fd.h: Rename include guard.
7787         * common/safe-iterator.h: Rename include guard.
7788         * common/run-time-clock.h: Rename include guard.
7789         * common/refcounted-object.h: Rename include guard.
7790         * common/queue.h: Rename include guard.
7791         * common/ptid.h: Rename include guard.
7792         * common/print-utils.h: Rename include guard.
7793         * common/preprocessor.h: Rename include guard.
7794         * common/pathstuff.h: Rename include guard.
7795         * common/observable.h: Rename include guard.
7796         * common/netstuff.h: Rename include guard.
7797         * common/job-control.h: Rename include guard.
7798         * common/host-defs.h: Rename include guard.
7799         * common/gdb_wait.h: Rename include guard.
7800         * common/gdb_vecs.h: Rename include guard.
7801         * common/gdb_unlinker.h: Rename include guard.
7802         * common/gdb_unique_ptr.h: Rename include guard.
7803         * common/gdb_tilde_expand.h: Rename include guard.
7804         * common/gdb_sys_time.h: Rename include guard.
7805         * common/gdb_string_view.h: Rename include guard.
7806         * common/gdb_splay_tree.h: Rename include guard.
7807         * common/gdb_setjmp.h: Rename include guard.
7808         * common/gdb_ref_ptr.h: Rename include guard.
7809         * common/gdb_optional.h: Rename include guard.
7810         * common/gdb_locale.h: Rename include guard.
7811         * common/gdb_assert.h: Rename include guard.
7812         * common/filtered-iterator.h: Rename include guard.
7813         * common/filestuff.h: Rename include guard.
7814         * common/fileio.h: Rename include guard.
7815         * common/environ.h: Rename include guard.
7816         * common/common-utils.h: Rename include guard.
7817         * common/common-types.h: Rename include guard.
7818         * common/common-regcache.h: Rename include guard.
7819         * common/common-inferior.h: Rename include guard.
7820         * common/common-gdbthread.h: Rename include guard.
7821         * common/common-exceptions.h: Rename include guard.
7822         * common/common-defs.h: Rename include guard.
7823         * common/common-debug.h: Rename include guard.
7824         * common/cleanups.h: Rename include guard.
7825         * common/buffer.h: Rename include guard.
7826         * common/btrace-common.h: Rename include guard.
7827         * common/break-common.h: Rename include guard.
7828         * cli/cli-utils.h: Rename include guard.
7829         * cli/cli-style.h: Rename include guard.
7830         * cli/cli-setshow.h: Rename include guard.
7831         * cli/cli-script.h: Rename include guard.
7832         * cli/cli-interp.h: Rename include guard.
7833         * cli/cli-decode.h: Rename include guard.
7834         * cli/cli-cmds.h: Rename include guard.
7835         * charset-list.h: Add include guard.
7836         * buildsym-legacy.h: Rename include guard.
7837         * bfin-tdep.h: Add include guard.
7838         * ax.h: Rename include guard.
7839         * arm-linux-tdep.h: Add include guard.
7840         * arm-fbsd-tdep.h: Add include guard.
7841         * arch/xtensa.h: Rename include guard.
7842         * arch/tic6x.h: Add include guard.
7843         * arch/i386.h: Add include guard.
7844         * arch/arm.h: Rename include guard.
7845         * arch/arm-linux.h: Rename include guard.
7846         * arch/arm-get-next-pcs.h: Rename include guard.
7847         * arch/amd64.h: Add include guard.
7848         * arch/aarch64-insn.h: Rename include guard.
7849         * arch-utils.h: Rename include guard.
7850         * annotate.h: Add include guard.
7851         * amd64-darwin-tdep.h: Rename include guard.
7852         * aarch64-linux-tdep.h: Add include guard.
7853         * aarch64-fbsd-tdep.h: Add include guard.
7854         * aarch32-linux-nat.h: Add include guard.
7855
7856 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7857
7858         * macrotab.c (macro_define_internal): New function that
7859         factorizes macro_define_object_internal and macro_define_function
7860         code.
7861         (macro_define_object_internal): Use macro_define_internal.
7862         (macro_define_function): Likewise.
7863
7864 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7865
7866         * macrocmd.c (extract_identifier): Return
7867         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7868         callers.
7869
7870 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7871
7872         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7873
7874 2019-02-05  Tom Tromey  <tom@tromey.com>
7875
7876         * target.c (target_stack::unpush): Move assertion earlier.
7877
7878 2019-01-30  Tom Tromey  <tom@tromey.com>
7879
7880         PR python/23615:
7881         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7882         (gdbpy_parse_and_eval): Likewise.
7883         * python/python-internal.h (gdbpy_allow_threads): New class.
7884
7885 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7886
7887         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7888         (aarch64_fbsd_fpregmap): Move earlier.
7889         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7890         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7891         instead of individual calls to trad_frame_set_reg_addr.
7892         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7893         earlier.
7894         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7895         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7896         instead of individual calls to trad_frame_set_reg_addr.
7897
7898 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7899
7900         * CONTRIBUTE: Replace contribution list with wiki link.
7901
7902 2019-01-25  Tom Tromey  <tom@tromey.com>
7903
7904         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7905
7906 2019-01-25  Tom Tromey  <tom@tromey.com>
7907
7908         * xtensa-linux-nat.c: Fix common/ includes.
7909         * xml-support.h: Fix common/ includes.
7910         * xml-support.c: Fix common/ includes.
7911         * x86-linux-nat.c: Fix common/ includes.
7912         * windows-nat.c: Fix common/ includes.
7913         * varobj.h: Fix common/ includes.
7914         * varobj.c: Fix common/ includes.
7915         * value.c: Fix common/ includes.
7916         * valops.c: Fix common/ includes.
7917         * utils.c: Fix common/ includes.
7918         * unittests/xml-utils-selftests.c: Fix common/ includes.
7919         * unittests/utils-selftests.c: Fix common/ includes.
7920         * unittests/unpack-selftests.c: Fix common/ includes.
7921         * unittests/tracepoint-selftests.c: Fix common/ includes.
7922         * unittests/style-selftests.c: Fix common/ includes.
7923         * unittests/string_view-selftests.c: Fix common/ includes.
7924         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7925         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7926         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7927         * unittests/rsp-low-selftests.c: Fix common/ includes.
7928         * unittests/parse-connection-spec-selftests.c: Fix common/
7929         includes.
7930         * unittests/optional-selftests.c: Fix common/ includes.
7931         * unittests/offset-type-selftests.c: Fix common/ includes.
7932         * unittests/observable-selftests.c: Fix common/ includes.
7933         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7934         * unittests/memrange-selftests.c: Fix common/ includes.
7935         * unittests/memory-map-selftests.c: Fix common/ includes.
7936         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7937         * unittests/function-view-selftests.c: Fix common/ includes.
7938         * unittests/environ-selftests.c: Fix common/ includes.
7939         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7940         * unittests/common-utils-selftests.c: Fix common/ includes.
7941         * unittests/cli-utils-selftests.c: Fix common/ includes.
7942         * unittests/array-view-selftests.c: Fix common/ includes.
7943         * ui-file.c: Fix common/ includes.
7944         * tui/tui-io.c: Fix common/ includes.
7945         * tracepoint.h: Fix common/ includes.
7946         * tracepoint.c: Fix common/ includes.
7947         * tracefile-tfile.c: Fix common/ includes.
7948         * top.h: Fix common/ includes.
7949         * top.c: Fix common/ includes.
7950         * thread.c: Fix common/ includes.
7951         * target/waitstatus.h: Fix common/ includes.
7952         * target/waitstatus.c: Fix common/ includes.
7953         * target.h: Fix common/ includes.
7954         * target.c: Fix common/ includes.
7955         * target-memory.c: Fix common/ includes.
7956         * target-descriptions.c: Fix common/ includes.
7957         * symtab.h: Fix common/ includes.
7958         * symfile.c: Fix common/ includes.
7959         * stap-probe.c: Fix common/ includes.
7960         * spu-linux-nat.c: Fix common/ includes.
7961         * sparc-nat.c: Fix common/ includes.
7962         * source.c: Fix common/ includes.
7963         * solib.c: Fix common/ includes.
7964         * solib-target.c: Fix common/ includes.
7965         * ser-unix.c: Fix common/ includes.
7966         * ser-tcp.c: Fix common/ includes.
7967         * ser-pipe.c: Fix common/ includes.
7968         * ser-base.c: Fix common/ includes.
7969         * selftest-arch.c: Fix common/ includes.
7970         * s12z-tdep.c: Fix common/ includes.
7971         * rust-exp.y: Fix common/ includes.
7972         * rs6000-aix-tdep.c: Fix common/ includes.
7973         * riscv-tdep.c: Fix common/ includes.
7974         * remote.c: Fix common/ includes.
7975         * remote-notif.h: Fix common/ includes.
7976         * remote-fileio.h: Fix common/ includes.
7977         * remote-fileio.c: Fix common/ includes.
7978         * regcache.h: Fix common/ includes.
7979         * regcache.c: Fix common/ includes.
7980         * record-btrace.c: Fix common/ includes.
7981         * python/python.c: Fix common/ includes.
7982         * python/py-type.c: Fix common/ includes.
7983         * python/py-inferior.c: Fix common/ includes.
7984         * progspace.h: Fix common/ includes.
7985         * producer.c: Fix common/ includes.
7986         * procfs.c: Fix common/ includes.
7987         * proc-api.c: Fix common/ includes.
7988         * printcmd.c: Fix common/ includes.
7989         * ppc-linux-nat.c: Fix common/ includes.
7990         * parser-defs.h: Fix common/ includes.
7991         * osdata.c: Fix common/ includes.
7992         * obsd-nat.c: Fix common/ includes.
7993         * nat/x86-linux.c: Fix common/ includes.
7994         * nat/x86-linux-dregs.c: Fix common/ includes.
7995         * nat/x86-dregs.h: Fix common/ includes.
7996         * nat/x86-dregs.c: Fix common/ includes.
7997         * nat/ppc-linux.c: Fix common/ includes.
7998         * nat/mips-linux-watch.h: Fix common/ includes.
7999         * nat/mips-linux-watch.c: Fix common/ includes.
8000         * nat/linux-waitpid.c: Fix common/ includes.
8001         * nat/linux-ptrace.h: Fix common/ includes.
8002         * nat/linux-ptrace.c: Fix common/ includes.
8003         * nat/linux-procfs.c: Fix common/ includes.
8004         * nat/linux-personality.c: Fix common/ includes.
8005         * nat/linux-osdata.c: Fix common/ includes.
8006         * nat/linux-namespaces.c: Fix common/ includes.
8007         * nat/linux-btrace.h: Fix common/ includes.
8008         * nat/linux-btrace.c: Fix common/ includes.
8009         * nat/fork-inferior.c: Fix common/ includes.
8010         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8011         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8012         * nat/aarch64-linux.c: Fix common/ includes.
8013         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8014         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8015         * namespace.h: Fix common/ includes.
8016         * mips-linux-tdep.c: Fix common/ includes.
8017         * minsyms.c: Fix common/ includes.
8018         * mi/mi-parse.h: Fix common/ includes.
8019         * mi/mi-main.c: Fix common/ includes.
8020         * mi/mi-cmd-env.c: Fix common/ includes.
8021         * memrange.h: Fix common/ includes.
8022         * memattr.c: Fix common/ includes.
8023         * maint.h: Fix common/ includes.
8024         * maint.c: Fix common/ includes.
8025         * main.c: Fix common/ includes.
8026         * machoread.c: Fix common/ includes.
8027         * location.c: Fix common/ includes.
8028         * linux-thread-db.c: Fix common/ includes.
8029         * linux-nat.c: Fix common/ includes.
8030         * linux-fork.c: Fix common/ includes.
8031         * inline-frame.c: Fix common/ includes.
8032         * infrun.c: Fix common/ includes.
8033         * inflow.c: Fix common/ includes.
8034         * inferior.h: Fix common/ includes.
8035         * inferior.c: Fix common/ includes.
8036         * infcmd.c: Fix common/ includes.
8037         * inf-ptrace.c: Fix common/ includes.
8038         * inf-child.c: Fix common/ includes.
8039         * ia64-linux-nat.c: Fix common/ includes.
8040         * i387-tdep.c: Fix common/ includes.
8041         * i386-tdep.c: Fix common/ includes.
8042         * i386-linux-tdep.c: Fix common/ includes.
8043         * i386-linux-nat.c: Fix common/ includes.
8044         * i386-go32-tdep.c: Fix common/ includes.
8045         * i386-fbsd-tdep.c: Fix common/ includes.
8046         * i386-fbsd-nat.c: Fix common/ includes.
8047         * guile/scm-type.c: Fix common/ includes.
8048         * guile/guile.c: Fix common/ includes.
8049         * go32-nat.c: Fix common/ includes.
8050         * gnu-nat.c: Fix common/ includes.
8051         * gdbthread.h: Fix common/ includes.
8052         * gdbarch-selftests.c: Fix common/ includes.
8053         * gdb_usleep.c: Fix common/ includes.
8054         * gdb_select.h: Fix common/ includes.
8055         * gdb_bfd.c: Fix common/ includes.
8056         * gcore.c: Fix common/ includes.
8057         * fork-child.c: Fix common/ includes.
8058         * findvar.c: Fix common/ includes.
8059         * fbsd-nat.c: Fix common/ includes.
8060         * event-top.c: Fix common/ includes.
8061         * event-loop.c: Fix common/ includes.
8062         * dwarf2read.c: Fix common/ includes.
8063         * dwarf2loc.c: Fix common/ includes.
8064         * dwarf2-frame.c: Fix common/ includes.
8065         * dwarf-index-cache.c: Fix common/ includes.
8066         * dtrace-probe.c: Fix common/ includes.
8067         * disasm-selftests.c: Fix common/ includes.
8068         * defs.h: Fix common/ includes.
8069         * csky-tdep.c: Fix common/ includes.
8070         * cp-valprint.c: Fix common/ includes.
8071         * cp-support.h: Fix common/ includes.
8072         * cp-support.c: Fix common/ includes.
8073         * corelow.c: Fix common/ includes.
8074         * completer.h: Fix common/ includes.
8075         * completer.c: Fix common/ includes.
8076         * compile/compile.c: Fix common/ includes.
8077         * compile/compile-loc2c.c: Fix common/ includes.
8078         * compile/compile-cplus-types.c: Fix common/ includes.
8079         * compile/compile-cplus-symbols.c: Fix common/ includes.
8080         * command.h: Fix common/ includes.
8081         * cli/cli-dump.c: Fix common/ includes.
8082         * cli/cli-cmds.c: Fix common/ includes.
8083         * charset.c: Fix common/ includes.
8084         * build-id.c: Fix common/ includes.
8085         * btrace.h: Fix common/ includes.
8086         * btrace.c: Fix common/ includes.
8087         * breakpoint.h: Fix common/ includes.
8088         * breakpoint.c: Fix common/ includes.
8089         * ax.h:
8090         (enum agent_op): Fix common/ includes.
8091         * ax-general.c (struct aop_map): Fix common/ includes.
8092         * ax-gdb.c: Fix common/ includes.
8093         * auxv.c: Fix common/ includes.
8094         * auto-load.c: Fix common/ includes.
8095         * arm-tdep.c: Fix common/ includes.
8096         * arch/riscv.c: Fix common/ includes.
8097         * arch/ppc-linux-common.c: Fix common/ includes.
8098         * arch/i386.c: Fix common/ includes.
8099         * arch/arm.c: Fix common/ includes.
8100         * arch/arm-linux.c: Fix common/ includes.
8101         * arch/arm-get-next-pcs.c: Fix common/ includes.
8102         * arch/amd64.c: Fix common/ includes.
8103         * arch/aarch64.c: Fix common/ includes.
8104         * arch/aarch64-insn.c: Fix common/ includes.
8105         * arch-utils.c: Fix common/ includes.
8106         * amd64-windows-tdep.c: Fix common/ includes.
8107         * amd64-tdep.c: Fix common/ includes.
8108         * amd64-sol2-tdep.c: Fix common/ includes.
8109         * amd64-obsd-tdep.c: Fix common/ includes.
8110         * amd64-nbsd-tdep.c: Fix common/ includes.
8111         * amd64-linux-tdep.c: Fix common/ includes.
8112         * amd64-linux-nat.c: Fix common/ includes.
8113         * amd64-fbsd-tdep.c: Fix common/ includes.
8114         * amd64-fbsd-nat.c: Fix common/ includes.
8115         * amd64-dicos-tdep.c: Fix common/ includes.
8116         * amd64-darwin-tdep.c: Fix common/ includes.
8117         * agent.c: Fix common/ includes.
8118         * ada-lang.h: Fix common/ includes.
8119         * ada-lang.c: Fix common/ includes.
8120         * aarch64-tdep.c: Fix common/ includes.
8121
8122 2019-01-25  Tom Tromey  <tom@tromey.com>
8123
8124         * common/create-version.sh: Use common/version.h.
8125
8126 2019-01-24  Pedro Alves  <palves@redhat.com>
8127
8128         * infrun.c (signal_stop, signal_print, signal_program)
8129         (signal_catch, signal_pass): Now arrays instead of pointers.
8130         (update_signals_program_target, do_target_resume)
8131         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8132         * linux-nat.c (linux_nat_target::pass_signals)
8133         (linux_nat_target::create_inferior, linux_nat_target::attach):
8134         Adjust.
8135         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8136         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8137         * procfs.c (procfs_target::pass_signals): Adjust.
8138         * record-full.c (record_full_target::resume): Adjust.
8139         * remote.c (remote_target::pass_signals)
8140         (remote_target::program_signals): Adjust.
8141         * target-debug.h (target_debug_print_signals): Now takes a
8142         gdb::array_view as parameter.  Adjust.
8143         * target.h (target_ops) <pass_signals, program_signals>: Replace
8144         pointer and length parameters with gdb::array_view.
8145         (target_pass_signals, target_program_signals): Likewise.
8146         * target-delegates.c: Regenerate.
8147
8148 2019-01-24  Pedro Alves  <palves@redhat.com>
8149
8150         * common/forward-scope-exit.h
8151         (forward_scope_exit::forward_scope_exit): Pass arguments to
8152         m_bind_function directly, instead of creating a std::bind and
8153         copying that.
8154
8155 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8156
8157         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8158         for static members.
8159         (pass_in_v_vfp_candidate): Likewise.
8160
8161 2019-01-23  Tom Tromey  <tom@tromey.com>
8162             Pedro Alves  <palves@redhat.com>
8163
8164         * regcache.c (class regcache_invalidator): Remove.
8165         (regcache::raw_write): Use make_scope_exit.
8166
8167 2019-01-23  Tom Tromey  <tom@tromey.com>
8168
8169         * ui-out.h (class ui_out_emit_type): Update comment.
8170
8171 2019-01-23  Tom Tromey  <tom@tromey.com>
8172
8173         * infrun.c (fetch_inferior_event): Update comment.
8174
8175 2019-01-23  Tom Tromey  <tom@tromey.com>
8176             Pedro Alves  <palves@redhat.com>
8177
8178         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8179         parameter.
8180         (fetch_inferior_event): Use SCOPE_EXIT.
8181
8182
8183 2019-01-23  Tom Tromey  <tom@tromey.com>
8184             Pedro Alves  <palves@redhat.com>
8185
8186         * infrun.c (disable_thread_events): Delete.
8187         (stop_all_threads): Use SCOPE_EXIT.
8188
8189 2019-01-23  Tom Tromey  <tom@tromey.com>
8190             Pedro Alves  <palves@redhat.com>
8191
8192         * symfile.c: Include forward-scope-exit.h.
8193         (clear_symtab_users_cleanup): Replace forward declaration with
8194         a FORWARD_SCOPE_EXIT.
8195         (syms_from_objfile_1): Use the forward_scope_exit and
8196         gdb::optional instead of cleanup_function.
8197         (reread_symbols): Use the forward_scope_exit instead of
8198         cleanup_function.
8199         (clear_symtab_users_cleanup): Remove function.
8200
8201 2019-01-23  Tom Tromey  <tom@tromey.com>
8202             Pedro Alves  <palves@redhat.com>
8203
8204         * linux-nat.c: Include scope-exit.h.
8205         (cleanup_target_stop): Remove.
8206         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8207         SCOPE_EXIT.
8208
8209 2019-01-23  Tom Tromey  <tom@tromey.com>
8210             Pedro Alves  <palves@redhat.com>
8211
8212         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8213         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8214
8215 2019-01-23  Tom Tromey  <tom@tromey.com>
8216             Andrew Burgess  <andrew.burgess@embecosm.com>
8217             Pedro Alves  <palves@redhat.com>
8218
8219         * infrun.c (fetch_inferior_event): Use scope_exit.
8220         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8221         * top.c (execute_command): Use scope_exit.
8222         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8223         * utils.c (do_bpstat_clear_actions_cleanup)
8224         (make_bpstat_clear_actions_cleanup): Remove.
8225
8226 2019-01-23  Tom Tromey  <tom@tromey.com>
8227             Pedro Alves  <palves@redhat.com>
8228
8229         * infrun.c: Include "common/scope-exit.h"
8230         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8231         (wait_for_inferior): Use SCOPE_EXIT.
8232         (fetch_inferior_event): Use scope_exit.
8233
8234 2019-01-23  Tom Tromey  <tom@tromey.com>
8235             Pedro Alves  <palves@redhat.com>
8236
8237         * breakpoint.c (create_breakpoint): Remove cleanup.
8238
8239 2019-01-23  Tom Tromey  <tom@tromey.com>
8240             Andrew Burgess  <andrew.burgess@embecosm.com>
8241             Pedro Alves  <palves@redhat.com>
8242
8243 2019-01-23  Pedro Alves  <palves@redhat.com>
8244
8245         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8246
8247 2019-01-23  Pedro Alves  <palves@redhat.com>
8248             Andrew Burgess  <andrew.burgess@embecosm.com>
8249
8250         * gdbthread.h: Include "common/forward-scope-exit.h".
8251         (scoped_finish_thread_state): Redefine custom class in terms of
8252         forward_scope_exit.
8253
8254 2019-01-23  Pedro Alves  <palves@redhat.com>
8255             Andrew Burgess  <andrew.burgess@embecosm.com>
8256
8257         * common/forward-scope-exit.h: New file.
8258
8259 2019-01-23  Pedro Alves  <palves@redhat.com>
8260             Andrew Burgess  <andrew.burgess@embecosm.com>
8261             Tom Tromey  <tom@tromey.com>
8262
8263         * common/scope-exit.h: New file.
8264
8265 2019-01-23  Pedro Alves  <palves@redhat.com>
8266
8267         * common/preprocessor.h (ESC): Rename to ...
8268         (ESC_PARENS): ... this.
8269         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8270         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8271
8272 2019-01-23  Tom Tromey  <tom@tromey.com>
8273
8274         * language.h (class scoped_switch_to_sym_language_if_auto):
8275         Initialize m_lang in both cases.
8276
8277 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8278
8279         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8280         with XCNEW.
8281
8282 2019-01-22  Tom Tromey  <tom@tromey.com>
8283
8284         * corelow.c: Do not include sys/file.h.
8285
8286 2019-01-22  Tom Tromey  <tom@tromey.com>
8287
8288         * tui/tui-wingeneral.h: Include gdb_curses.h.
8289
8290 2019-01-22  Tom Tromey  <tom@tromey.com>
8291
8292         * source-cache.h (class source_cache) <get_source_lines,
8293         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8294
8295 2019-01-22  Tom Tromey  <tom@tromey.com>
8296
8297         * remote-fileio.h (struct remote_target): Declare.
8298
8299 2019-01-22  Tom Tromey  <tom@tromey.com>
8300
8301         * python/py-arch.c: Do not include py-ref.h.
8302         * python/py-bpevent.c: Do not include py-ref.h.
8303         * python/py-cmd.c: Do not include py-ref.h.
8304         * python/py-continueevent.c: Do not include py-ref.h.
8305         * python/py-event.h: Do not include py-ref.h.
8306         * python/py-evtregistry.c: Do not include py-ref.h.
8307         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8308         * python/py-frame.c: Do not include py-ref.h.
8309         * python/py-framefilter.c: Do not include py-ref.h.
8310         * python/py-function.c: Do not include py-ref.h.
8311         * python/py-infevents.c: Do not include py-ref.h.
8312         * python/py-linetable.c: Do not include py-ref.h.
8313         * python/py-objfile.c: Do not include py-ref.h.
8314         * python/py-param.c: Do not include py-ref.h.
8315         * python/py-prettyprint.c: Do not include py-ref.h.
8316         * python/py-progspace.c: Do not include py-ref.h.
8317         * python/py-symbol.c: Do not include py-ref.h.
8318         * python/py-symtab.c: Do not include py-ref.h.
8319         * python/py-type.c: Do not include py-ref.h.
8320         * python/py-unwind.c: Do not include py-ref.h.
8321         * python/py-utils.c: Do not include py-ref.h.
8322         * python/py-value.c: Do not include py-ref.h.
8323         * python/py-varobj.c: Do not include py-ref.h.
8324         * python/py-xmethods.c: Do not include py-ref.h.
8325         * python/python.c: Do not include py-ref.h.
8326         * varobj.c: Do not include py-ref.h.
8327
8328 2019-01-22  Tom Tromey  <tom@tromey.com>
8329
8330         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8331         keyword for bcache.
8332
8333 2019-01-22  Tom Tromey  <tom@tromey.com>
8334
8335         * compile/compile-cplus-types.c: Remove a comment by #include.
8336
8337 2019-01-22  Tom Tromey  <tom@tromey.com>
8338
8339         * compile/gcc-c-plugin.h: Include compile-internal.h.
8340
8341 2019-01-22  Tom Tromey  <tom@tromey.com>
8342
8343         * stabsread.c (EXTERN): Do not define.
8344         (symnum, next_symbol_text_func, processing_gcc_compilation)
8345         (within_function, global_sym_chain, global_stabs)
8346         (previous_stab_code, this_object_header_files)
8347         (n_this_object_header_files)
8348         (n_allocated_this_object_header_files): Define.
8349         * stabsread.h (EXTERN): Never define.  Use "extern".
8350
8351 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8352
8353         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8354         history_value.
8355
8356 2019-01-21  Tom Tromey  <tom@tromey.com>
8357
8358         * ui-out.c: Fix includes.
8359         * tui/tui-source.c: Fix includes.
8360         * target.c: Fix includes.
8361         * remote.c: Fix includes.
8362         * regcache.c: Fix includes.
8363         * python/py-block.c: Fix includes.
8364         * printcmd.c: Fix includes.
8365         * or1k-tdep.c: Fix includes.
8366         * mi/mi-main.c: Fix includes.
8367         * m32r-tdep.c: Fix includes.
8368         * csky-tdep.c: Fix includes.
8369         * compile/compile-cplus-types.c: Fix includes.
8370         * cli/cli-interp.c: Fix includes.
8371
8372 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8373
8374         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8375         for padding.
8376
8377 2019-01-16  Tom Tromey  <tom@tromey.com>
8378
8379         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8380         earlier.
8381         (struct objfile) <msymbols_range>: Move from top level.
8382         <msymbols>: New method.
8383         (class objfile_msymbols): Remove.
8384         * symtab.c (default_collect_symbol_completion_matches_break_on):
8385         Update.
8386         * symmisc.c (dump_msymbols): Update.
8387         * stabsread.c (scan_file_globals): Update.
8388         * objc-lang.c (info_selectors_command, info_classes_command)
8389         (find_methods): Update.
8390         * minsyms.c (find_solib_trampoline_target): Update.
8391         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8392         * coffread.c (coff_symfile_read): Update.
8393         * ada-lang.c (ada_lookup_simple_minsym)
8394         (ada_collect_symbol_completion_matches): Update.
8395
8396 2019-01-16  Tom Tromey  <tom@tromey.com>
8397
8398         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8399         type.  Remove no-argument constructor.
8400         <iterator::operator++>: Simplify.
8401         <begin>: Update.
8402         <end>: Use minimal_symbol_count.
8403
8404 2019-01-16  Tom Tromey  <tom@tromey.com>
8405
8406         * objfiles.h (struct objfile) <psymtabs>: New method.
8407         (class objfile_psymtabs): Remove.
8408         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8409         typedef.
8410         <range>: New method.
8411         (require_partial_symbols): Change return type.
8412         * psymtab.c (require_partial_symbols)
8413         (psym_expand_symtabs_matching): Update.
8414         * mdebugread.c (parse_partial_symbols): Update.
8415         * dbxread.c (dbx_end_psymtab): Update.
8416
8417 2019-01-15  Tom Tromey  <tom@tromey.com>
8418
8419         * symtab.c (lookup_objfile_from_block)
8420         (lookup_symbol_in_objfile_symtabs)
8421         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8422         (find_line_symtab, info_sources_command)
8423         (default_collect_symbol_completion_matches_break_on)
8424         (make_source_files_completion_list): Update.
8425         * symmisc.c (print_objfile_statistics, dump_objfile)
8426         (maintenance_print_symbols, maintenance_info_symtabs)
8427         (maintenance_check_symtabs, maintenance_info_line_tables):
8428         Update.
8429         * source.c (select_source_symtab)
8430         (forget_cached_source_info_for_objfile): Update.
8431         * objfiles.h (class objfile_compunits): Remove.
8432         (struct objfile) <compunits_range>: New typedef.
8433         (compunits): New method.
8434         * objfiles.c (objfile_relocate1): Update.
8435         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8436         * maint.c (count_symtabs_and_blocks): Update.
8437         * linespec.c (iterate_over_all_matching_symtabs): Update.
8438         * cp-support.c (add_symbol_overload_list_qualified): Update.
8439         * coffread.c (coff_symtab_read): Update.
8440         * ada-lang.c (add_nonlocal_symbols)
8441         (ada_collect_symbol_completion_matches)
8442         (ada_add_global_exceptions): Update.
8443
8444 2019-01-15  Tom Tromey  <tom@tromey.com>
8445
8446         * progspace.h (program_space) <objfiles_safe_range>: New
8447         typedef.
8448         <objfiles_safe>: New method.
8449         * objfiles.h (class all_objfiles_safe): Remove.
8450         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8451         * jit.c (jit_inferior_exit_hook): Update.
8452
8453 2019-01-17  Tom Tromey  <tom@tromey.com>
8454
8455         * progspace.h (program_space) <objfiles_range>: New typedef.
8456         <objfiles>: New method.
8457         <objfiles_head>: Rename from objfiles.
8458         (object_files): Update.
8459         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8460         * guile/scm-pretty-print.c
8461         (ppscm_find_pretty_printer_from_objfiles): Update.
8462         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8463         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8464         Update.
8465         * python/py-progspace.c (pspy_get_objfiles): Update.
8466         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8467         Update.
8468         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8469         (objfpy_lookup_objfile_by_build_id): Update.
8470         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8471         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8472         Update.
8473         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8474         (expand_symtab_containing_pc, lookup_objfile_from_block)
8475         (lookup_static_symbol, basic_lookup_transparent_type)
8476         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8477         (find_line_symtab, info_sources_command)
8478         (default_collect_symbol_completion_matches_break_on)
8479         (make_source_files_completion_list, find_main_name): Update.
8480         * symmisc.c (print_symbol_bcache_statistics)
8481         (print_objfile_statistics, maintenance_print_symbols)
8482         (maintenance_print_msymbols, maintenance_print_objfiles)
8483         (maintenance_info_symtabs, maintenance_check_symtabs)
8484         (maintenance_expand_symtabs, maintenance_info_line_tables):
8485         Update.
8486         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8487         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8488         (map_overlay_command, unmap_overlay_command)
8489         (simple_overlay_update, expand_symtabs_matching)
8490         (map_symbol_filenames): Update.
8491         * symfile-debug.c (set_debug_symfile): Update.
8492         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8493         Update.
8494         * source.c (select_source_symtab, forget_cached_source_info):
8495         Update.
8496         * solib.c (solib_read_symbols): Update.
8497         * solib-spu.c (append_ocl_sos): Update.
8498         * psymtab.c (maintenance_print_psymbols)
8499         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8500         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8501         * printcmd.c (info_symbol_command): Update.
8502         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8503         Update.
8504         * objfiles.h (class all_objfiles): Remove.
8505         * objfiles.c (have_partial_symbols, have_full_symbols)
8506         (have_minimal_symbols, qsort_cmp, update_section_map)
8507         (shared_objfile_contains_address_p)
8508         (default_iterate_over_objfiles_in_search_order): Update.
8509         * objc-lang.c (info_selectors_command, info_classes_command)
8510         (find_methods): Update.
8511         * minsyms.c (find_solib_trampoline_target): Update.
8512         * maint.c (maintenance_info_sections)
8513         (maintenance_translate_address, count_symtabs_and_blocks):
8514         Update.
8515         * main.c (captured_main_1): Update.
8516         * linux-thread-db.c (try_thread_db_load_from_pdir)
8517         (has_libpthread): Update.
8518         * linespec.c (iterate_over_all_matching_symtabs)
8519         (search_minsyms_for_name): Update.
8520         * jit.c (jit_find_objf_with_entry_addr): Update.
8521         * hppa-tdep.c (find_unwind_entry)
8522         (hppa_lookup_stub_minimal_symbol): Update.
8523         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8524         Update.
8525         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8526         (elf_gnu_ifunc_resolve_by_got): Update.
8527         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8528         * dwarf-index-write.c (save_gdb_index_command): Update.
8529         * cp-support.c (add_symbol_overload_list_qualified): Update.
8530         * breakpoint.c (create_overlay_event_breakpoint)
8531         (create_longjmp_master_breakpoint)
8532         (create_std_terminate_master_breakpoint)
8533         (create_exception_master_breakpoint): Update.
8534         * blockframe.c (find_pc_partial_function): Update.
8535         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8536         (ada_collect_symbol_completion_matches)
8537         (ada_add_global_exceptions): Update.
8538
8539 2019-01-17  Tom Tromey  <tom@tromey.com>
8540
8541         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8542         declare VEC.
8543         (solib_target_parse_libraries): Change return type.
8544         (library_list_start_segment, library_list_start_section)
8545         (library_list_end_library, library_list_start_library); Update.
8546         (solib_target_free_library_list): Remove.
8547         (solib_target_parse_libraries): Remove cleanup.  Change return
8548         type.
8549         (solib_target_current_sos): Update.
8550
8551 2019-01-17  Tom Tromey  <tromey@bapiya>
8552
8553         * valprint.c: Replace "the the" with "the".
8554         * symtab.c: Replace "the the" with "the".
8555         * solib.c: Replace "the the" with "the".
8556         * solib-dsbt.c: Replace "the the" with "the".
8557         * linespec.c: Replace "the the" with "the".
8558         * dwarf2loc.h: Replace "the the" with "the".
8559         * amd64-windows-tdep.c: Replace "the the" with "the".
8560         * aarch64-tdep.c: Replace "the the" with "the".
8561
8562 2019-01-16  Keith Seitz  <keiths@redhat.com>
8563
8564         PR gdb/23773
8565         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8566         <builder>: Rename to ..
8567         <m_builder>: ... this and make private.
8568         (dwarf2_cu::get_builder): New method.  Change all users of
8569         `builder' to use this method.
8570         (dwarf2_start_symtab): Move to ...
8571         (dwarf2_cu::start_symtab): ... here.  Update all callers
8572         (setup_type_unit_groups): Move to ...
8573         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8574         callers.
8575         (dwarf2_cu::reset_builder): New method.
8576         (process_full_compunit, process_full_type_unit): Use
8577         dwarf2_cu::reset_builder.
8578         (follow_die_offset): Record the ancestor CU if it is different
8579         from the followed DIE's CU.
8580         (follow_die_sig_1): Likewise.
8581
8582 2019-01-15  Tom Tromey  <tom@tromey.com>
8583
8584         * remote.c (class remote_state) <buf>: Now a char_vector.
8585         <buf_size>: Remove.
8586         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8587         parameter.
8588         (remote_target::getpkt_or_notif_sane_1)
8589         (remote_target::getpkt_sane)
8590         (remote_target::getpkt_or_notif_sane): Likewise.
8591         (class remote_target) <putpkt>: New overload.
8592         (remote_target::read_frame): Change type of "buf_p".  Remove
8593         sizeof_p parameter.
8594         (packet_ok): New overload.
8595         (packet_check_result): New overload.
8596         Update all uses.
8597
8598 2019-01-14  Tom Tromey  <tom@tromey.com>
8599
8600         * remote-notif.c (handle_notification, remote_notif_ack)
8601         (remote_notif_parse): Make "buf" const.
8602         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8603         const.
8604         (remote_notif_parse, remote_notif_ack, handle_notification):
8605         Likewise.
8606         * remote.c (remote_notif_stop_parse): Make "buf" const.
8607         (remote_target::remote_parse_stop_reply): Make "buf" const.
8608         (remote_notif_stop_ack): Make "buf" const.
8609
8610 2019-01-14  Tom Tromey  <tom@tromey.com>
8611
8612         * remote.c (remote_console_output): Make parameter const.
8613
8614 2019-01-14  Tom Tromey  <tom@tromey.com>
8615
8616         * target-debug.h (target_debug_print_signals): Constify.
8617         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8618         * procfs.c (procfs_target::pass_signals): Update.
8619         * linux-nat.c (linux_nat_target::pass_signals): Update.
8620         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8621         * target-delegates.c: Rebuild.
8622         * remote.c (remote_target::program_signals): Update.
8623         (remote_target::pass_signals): Update.
8624         * target.c (target_pass_signals): Constify argument.
8625         (target_program_signals): Likewise.
8626         * target.h (struct target_ops) <pass_signals, program_signals>:
8627         Constify argument.
8628         (target_pass_signals, target_program_signals): Constify argument.
8629
8630 2019-01-14  Tom Tromey  <tom@tromey.com>
8631
8632         PR tui/28819:
8633         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8634
8635 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8636
8637         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8638         field.
8639         * rs6000-tdep.c: Include reggroups.h.
8640         (IS_V_ALIAS_PSEUDOREG): Define.
8641         (rs6000_register_name): Return names for the "vX" aliases.
8642         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8643         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8644         aliases.  Call default_register_reggroup_p for all other
8645         pseudo-registers.
8646         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8647         New functions.
8648         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8649         Handle "vX" aliases.
8650         (v_alias_pseudo_register_collect): New function.
8651         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8652         (rs6000_gdbarch_init): Initialize "vX" aliases as
8653         pseudo-registers.  Restore registration of
8654         rs6000_pseudo_register_reggroup_p with
8655         set_tdesc_pseudo_register_reggroup_p.
8656
8657 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8658
8659         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8660         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8661         set_gdbarch_num_pseudo_regs.
8662
8663 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8664
8665         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8666         Remove arg prefixname, add do_set and do_show.
8667         Add member functions set_list and show_list.
8668         * cli/cli-style.c (class cli_style_option): Update accordingly.
8669         (style_set_list): Move to file scope.
8670         (style_show_list): Likewise.
8671         (set_style): Call help_list.
8672         (show_style): Call cmd_show_list.
8673         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8674         Update to use the new macro.
8675
8676 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8677
8678         * ada-lang.c (_initialize_ada_language): Expand the help text
8679         for the "catch exception" command.
8680
8681 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8682
8683         * symtab.c (matching_obj_sections): Initialize obj,
8684         declare it closer to its usage.
8685
8686 2019-01-10  Tom Tromey  <tom@tromey.com>
8687
8688         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8689         (basic_inf_threads_range): Remove.
8690         (inf_threads_range, inf_non_exited_threads_range)
8691         (safe_inf_threads_range): Use next_adapter.
8692
8693 2019-01-10  Keith Seitz  <keiths@redhat.com>
8694
8695         PR gdb/23712
8696         PR symtab/23010
8697         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8698         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8699
8700 2019-01-10  Keith Seitz  <keiths@redhat.com>
8701
8702         PR gdb/23712
8703         PR symtab/23010
8704         * dictionary.c (pending_to_vector): Remove.
8705         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8706         Remove _1 suffix, replacing functions of the same name.  Update
8707         all callers.
8708         (dict_create_hashed, dict_create_hashed_expandable)
8709         (dict_create_linear, dict_create_linear_expandable, dict_free)
8710         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8711         Make functions static.
8712
8713 2019-01-10  Keith Seitz  <keiths@redhat.com>
8714
8715         PR gdb/23712
8716         PR symtab/23010
8717         * dictionary.h (struct dictionary): Replace declaration with
8718         multidictionary.
8719         (dict_create_hashed, dict_create_hashed_expandable)
8720         (dict_create_linear, dict_create_linear_expandable)
8721         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8722         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8723         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8724         taking multidictionary argument.
8725         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8726         * block.h (struct block) <dict>: Change to multidictionary
8727         and rename `multidict'.
8728         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8729         symmisc.c: Update all dictionary references to multidictionary.
8730
8731 2019-01-10  Keith Seitz  <keiths@redhat.com>
8732
8733         PR gdb/23712
8734         PR symtab/23010
8735         * dictionary.c: Include unordered_map.
8736         (pending_to_vector): New function.
8737         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8738         Rewrite the non-"_1" functions to take vector instead
8739         of linked list.
8740         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8741         "new" _1 versions of the same name.
8742         (multidictionary): Define.
8743         (std::hash<enum language): New definition.
8744         (collate_pending_symbols_by_language, mdict_create_hashed)
8745         (mdict_create_hashed_expandable, mdict_create_linear)
8746         (mdict_create_linear_expandable, mdict_free)
8747         (find_language_dictionary, create_new_language_dictionary)
8748         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8749         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8750         (mdict_size, mdict_empty): New functions.
8751         * dictionary.h (mdict_iterator): Define.
8752
8753 2019-01-10  Pedro Alves  <palves@redhat.com>
8754
8755         * breakpoint.c (read_uploaded_action)
8756         (create_tracepoint_from_upload): Adjust to use
8757         gdb::unique_xmalloc_ptr.
8758         * ctf.c (ctf_write_uploaded_tp):
8759         (SET_ARRAY_FIELD): Use emplace_back.
8760         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8761         * tracefile-tfile.c (tfile_write_uploaded_tp):
8762         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8763         gdb::unique_xmalloc_ptr.
8764         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8765         at_string, cond_string, cmd_strings>: Replace char pointers
8766         with gdb::unique_xmalloc_ptr.
8767
8768 2019-01-10  Pedro Alves  <palves@redhat.com>
8769
8770         * solib-target.c (library_list_start_library): Don't xstrdup name.
8771
8772 2019-01-10  Pedro Alves  <palves@redhat.com>
8773
8774         * mdebugread.c (parse_partial_symbols): Use
8775         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8776
8777 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8778
8779         * linux-fork.c (scoped_switch_fork_info)
8780         <~scoped_switch_fork_info>: Fix incorrect variable name.
8781
8782 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8783
8784         * linux-fork.c (scoped_switch_fork_info)
8785         <scoped_switch_fork_info>: Make explicit.
8786         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8787
8788 2019-01-10  Tom Tromey  <tom@tromey.com>
8789
8790         * objfiles.h (objfile::reset_psymtabs): Update.
8791         * objfiles.c (objfile::objfile): Update.
8792         * psymtab.h (psymtab_storage::obstack): Update.
8793         (psymtab_storage::m_obstack): Use gdb::optional.
8794         (class psymtab_storage): Update comment.  Remove objfile
8795         parameter.
8796         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8797
8798 2019-01-10  Tom Tromey  <tom@tromey.com>
8799
8800         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8801         <free_psymtabs>: Now private.
8802         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8803         (allocate_psymtab): Use new method.
8804
8805 2019-01-10  Tom Tromey  <tom@tromey.com>
8806
8807         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8808         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8809         * mdebugread.c (parse_partial_symbols): Use
8810         allocate_dependencies.
8811         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8812         allocate_dependencies.
8813         (process_psymtab_comp_unit_reader)
8814         (build_type_psymtab_dependencies): Likewise.
8815         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8816
8817 2019-01-10  Tom Tromey  <tom@tromey.com>
8818
8819         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8820         PSYMBOL_SET_LANGUAGE.
8821         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8822
8823 2019-01-10  Tom Tromey  <tom@tromey.com>
8824
8825         * psymtab.h (psymtab_storage::obstack): New method.
8826         <m_obstack>: Rename from obstack; now private.
8827         * psymtab.c (psymtab_storage): Update.
8828         * dwarf2read.c (create_addrmap_from_index)
8829         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8830         Update.
8831
8832 2019-01-10  Tom Tromey  <tom@tromey.com>
8833
8834         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8835         * objfiles.h (objfile::reset_psymtabs): New method.
8836
8837 2019-01-10  Tom Tromey  <tom@tromey.com>
8838
8839         * symmisc.c (print_symbol_bcache_statistics): Update.
8840         (print_objfile_statistics): Update.
8841         * symfile.c (reread_symbols): Update.
8842         * psymtab.h (class psymtab_storage): New.
8843         * psymtab.c (psymtab_storage): New constructor.
8844         (~psymtab_storage): New destructor.
8845         (require_partial_symbols): Update.
8846         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8847         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8848         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8849         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8850         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8851         (start_psymtab_common, end_psymtab_common)
8852         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8853         (allocate_psymtab): Update.
8854         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8855         Update.
8856         (dump_psymtab_addrmap, maintenance_print_psymbols)
8857         (maintenance_check_psymtabs): Update.
8858         (class objfile_psymtabs): Move to objfiles.h.
8859         * psympriv.h (discard_psymtab): Now inline.
8860         (psymtab_discarder::psymtab_discarder): Update.
8861         (psymtab_discarder::~psymtab_discarder): Update.
8862         (ALL_OBJFILE_PSYMTABS): Rewrite.
8863         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8864         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8865         Remove fields.
8866         <partial_symtabs>: New field.
8867         (class objfile_psymtabs): Move from psymtab.h.  Update.
8868         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8869         psymbol_cache.
8870         (objfile::~objfile): Don't destroy psymbol_cache.
8871         * mdebugread.c (parse_partial_symbols): Update.
8872         * dwarf2read.c (create_addrmap_from_index)
8873         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8874         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8875         (add_partial_subprogram, dwarf2_ranges_read): Update.
8876         * dwarf-index-write.c (write_address_map)
8877         (write_one_signatured_type, recursively_write_psymbols)
8878         (class debug_names, class debug_names, write_psymtabs_to_index):
8879         Update.
8880
8881 2019-01-10  Tom Tromey  <tom@tromey.com>
8882
8883         * symtab.h (SYMBOL_SET_NAMES): Update.
8884         (symbol_set_names): Update.
8885         (MSYMBOL_SET_NAMES): Update.
8886         * symtab.c (symbol_set_names): Change argument to be an
8887         objfile_per_bfd_storage.
8888         * psymtab.c (add_psymbol_to_bcache): Update.
8889         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8890
8891 2019-01-10  Tom Tromey  <tom@tromey.com>
8892
8893         * symtab.c (create_demangled_names_hash): Change argument to be an
8894         objfile_per_bfd_storage.
8895         (symbol_set_names): Update.
8896
8897 2019-01-10  Tom Tromey  <tom@tromey.com>
8898
8899         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8900         init_psymbol_list.
8901         * psymtab.c (init_psymbol_list): Do nothing if already called.
8902         * psympriv.h (init_psymbol_list): Add comment.
8903         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8904         init_psymbol_list.
8905         * dbxread.c (dbx_symfile_read): Unconditionally call
8906         init_psymbol_list.
8907
8908 2019-01-10  Tom Tromey  <tom@tromey.com>
8909
8910         * xcoffread.c (scan_xcoff_symtab): Update.
8911         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8912         "where".
8913         * mdebugread.c (parse_partial_symbols)
8914         (handle_psymbol_enumerators): Update.
8915         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8916         * dbxread.c (read_dbx_symtab): Update.
8917         * psympriv.h (psymbol_placement): New enum.
8918         (add_psymbol_to_list): Update.
8919
8920 2019-01-10  Tom Tromey  <tom@tromey.com>
8921
8922         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8923         static_psymbols parameters.
8924         (scan_xcoff_symtab): Update.
8925         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8926         static_psymbols parameters.
8927         * psympriv.h (start_psymtab_common): Update.
8928         * mdebugread.c (parse_partial_symbols): Update.
8929         * dwarf2read.c (create_partial_symtab): Update.
8930         * dbxread.c (read_dbx_symtab): Update.
8931         (start_psymtab): Remove global_psymbols and static_psymbols
8932         parameters.
8933
8934 2019-01-10  Tom Tromey  <tom@tromey.com>
8935
8936         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8937         * psymtab.c (allocate_psymtab): Add comment.
8938         * psympriv.h (allocate_psymtab): Add comment.
8939         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8940         initializations.
8941         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8942
8943 2019-01-10  Tom Tromey  <tom@tromey.com>
8944
8945         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8946         Don't declare.
8947         * mipsread.c: Include mdebugread.h.
8948         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8949         Declare.
8950         * elfread.c: Include mdebugread.h.
8951
8952 2019-01-09  Tom Tromey  <tom@tromey.com>
8953
8954         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8955         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8956         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8957         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8958         (psym_lookup_symbol, psym_find_last_source_symtab)
8959         (psym_forget_cached_source_info, psym_print_stats)
8960         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8961         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8962         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8963         (psym_find_compunit_symtab_by_address)
8964         (maintenance_print_psymbols, maintenance_info_psymtabs)
8965         (maintenance_check_psymtabs): Use ranged for.
8966         * psymtab.h (class objfile_psymtabs): New.
8967         (require_partial_symbols): Return objfile_psymtabs.
8968         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8969
8970 2019-01-09  Tom Tromey  <tom@tromey.com>
8971
8972         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8973         (find_pc_mapped_section, list_overlays_command)
8974         (map_overlay_command, unmap_overlay_command)
8975         (simple_overlay_update): Use all_objfiles.
8976         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8977         * printcmd.c (info_symbol_command): Use all_objfiles.
8978         * objfiles.h (ALL_OBJSECTIONS): Remove.
8979         * maint.c (maintenance_translate_address): Use all_objfiles.
8980         * gcore.c (gcore_create_callback): Use all_objfiles.
8981         (objfile_find_memory_regions): Likewise.
8982
8983 2019-01-09  Tom Tromey  <tom@tromey.com>
8984
8985         * symtab.c (find_line_symtab, info_sources_command)
8986         (make_source_files_completion_list): Use objfile_compunits.
8987         * source.c (select_source_symtab): Use objfile_compunits.
8988         * objfiles.h (struct objfile): Update comment.
8989         (ALL_OBJFILES): Remove.
8990         (ALL_FILETABS): Remove.
8991         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8992         objfile_compunits.
8993
8994 2019-01-09  Tom Tromey  <tom@tromey.com>
8995
8996         * symmisc.c (print_objfile_statistics, dump_objfile)
8997         (maintenance_print_symbols): Use compunit_filetabs.
8998         * source.c (forget_cached_source_info_for_objfile): Use
8999         compunit_filetabs.
9000         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9001         (ALL_FILETABS): Use compunit_filetabs.
9002         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9003         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9004
9005 2019-01-09  Tom Tromey  <tom@tromey.com>
9006
9007         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9008         (compunit_filetabs): New.
9009         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9010         compunit_filetabs.
9011         (info_sources_command, make_source_files_completion_list): Remove
9012         declaration.
9013         * symmisc.c (print_objfile_statistics, dump_objfile)
9014         (maintenance_print_symbols): Remove declaration.
9015         (maintenance_info_symtabs): Use compunit_filetabs.
9016         (maintenance_info_line_tables): Likewise.
9017         * source.c (select_source_symtab): Change local variable name.
9018         (forget_cached_source_info_for_objfile): Remove declaration.
9019         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9020         * objfiles.c (objfile_relocate1): Remove declaration.
9021         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9022         declaration.
9023         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9024         * coffread.c (coff_symtab_read): Remove declaration.
9025         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9026         compunit_filetabs.
9027
9028 2019-01-09  Tom Tromey  <tom@tromey.com>
9029
9030         * symtab.c (lookup_objfile_from_block)
9031         (find_pc_sect_compunit_symtab, search_symbols)
9032         (default_collect_symbol_completion_matches_break_on): Use
9033         objfile_compunits.
9034         * objfiles.h (ALL_COMPUNITS): Remove.
9035         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9036         * cp-support.c (add_symbol_overload_list_qualified): Use
9037         objfile_compunits.
9038         * ada-lang.c (ada_collect_symbol_completion_matches)
9039         (ada_add_global_exceptions): Use objfile_compunits.
9040
9041 2019-01-09  Tom Tromey  <tom@tromey.com>
9042
9043         * source.c (select_source_symtab)
9044         (forget_cached_source_info_for_objfile): Remove declaration.
9045         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9046         declaration.
9047         * maint.c (count_symtabs_and_blocks): Remove declaration.
9048         * cp-support.c (add_symbol_overload_list_qualified): Remove
9049         declaration.
9050         * coffread.c (coff_symtab_read): Remove declaration.
9051         * symtab.c (lookup_symbol_in_objfile_symtabs)
9052         (basic_lookup_transparent_type_1): Use objfile_compunits.
9053         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9054         (info_sources_command, search_symbols)
9055         (default_collect_symbol_completion_matches_break_on)
9056         (make_source_files_completion_list): Remove declaration.
9057         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9058         (ada_collect_symbol_completion_matches)
9059         (ada_add_global_exceptions): Remove declaration.
9060         * linespec.c (iterate_over_all_matching_symtabs): Use
9061         objfile_compunits.
9062         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9063         (class objfile_compunits): New.
9064         (ALL_COMPUNITS): Use objfile_compunits.
9065         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9066         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9067         objfile_compunits.
9068         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9069
9070 2019-01-09  Tom Tromey  <tom@tromey.com>
9071
9072         * symtab.c (search_symbols)
9073         (default_collect_symbol_completion_matches_break_on): Use
9074         objfile_msymbols.
9075         * ada-lang.c (ada_lookup_simple_minsym)
9076         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9077         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9078         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9079         objfile_msymbols.
9080         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9081         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9082         * objc-lang.c (find_methods): Use objfile_msymbols.
9083         (info_selectors_command, info_classes_command): Likewise.
9084         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9085         * objfiles.h (class objfile_msymbols): New.
9086         (ALL_OBJFILE_MSYMBOLS): Remove.
9087         (ALL_MSYMBOLS): Remove.
9088
9089 2019-01-09  Tom Tromey  <tom@tromey.com>
9090
9091         * common/next-iterator.h (next_adapter): Add Iterator template
9092         parameter.
9093         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9094         (class all_objfiles_safe): New.
9095         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9096         * objfiles.c (put_objfile_before): Update comment.
9097         (add_separate_debug_objfile): Likewise.
9098         (free_all_objfiles): Use all_objfiles_safe.
9099         (objfile_purge_solibs): Likewise.
9100
9101 2019-01-09  Tom Tromey  <tom@tromey.com>
9102
9103         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9104         (expand_symtab_containing_pc, lookup_static_symbol)
9105         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9106         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9107         all_objfiles.
9108         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9109         * breakpoint.c (create_overlay_event_breakpoint)
9110         (create_longjmp_master_breakpoint)
9111         (create_std_terminate_master_breakpoint)
9112         (create_exception_master_breakpoint): Use all_objfiles.
9113         * linux-thread-db.c (try_thread_db_load_from_pdir)
9114         (has_libpthread): Use all_objfiles.
9115         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9116         * linespec.c (iterate_over_all_matching_symtabs)
9117         (search_minsyms_for_name): Use all_objfiles.
9118         * maint.c (maintenance_info_sections): Use all_objfiles.
9119         * main.c (captured_main_1): Use all_objfiles.
9120         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9121         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9122         * guile/scm-pretty-print.c
9123         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9124         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9125         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9126         (maintenance_print_msymbols): Use all_objfiles.
9127         * source.c (select_source_symtab): Use all_objfiles.
9128         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9129         * symfile.c (remove_symbol_file_command)
9130         (expand_symtabs_matching, map_symbol_filenames): Use
9131         all_objfiles.
9132         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9133         all_objfiles.
9134         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9135         * objc-lang.c (find_methods): Use all_objfiles.
9136         * objfiles.c (have_partial_symbols, have_full_symbols)
9137         (have_minimal_symbols, qsort_cmp)
9138         (default_iterate_over_objfiles_in_search_order): Use
9139         all_objfiles.
9140         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9141         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9142         (maintenance_check_psymtabs): Use all_objfiles.
9143         (ALL_PSYMTABS): Remove.
9144         * compile/compile-object-run.c (do_module_cleanup): Use
9145         all_objfiles.
9146         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9147         * cp-support.c (add_symbol_overload_list_qualified): Use
9148         all_objfiles.
9149         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9150         Use all_objfiles.
9151         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9152         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9153         all_objfiles.
9154         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9155         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9156         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9157         Uses all_objfiles.
9158         * solib.c (solib_read_symbols): Use all_objfiles
9159
9160 2019-01-09  Tom Tromey  <tom@tromey.com>
9161
9162         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9163         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9164         all_objfiles.
9165         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9166         * symmisc.c (print_symbol_bcache_statistics)
9167         (print_objfile_statistics, maintenance_print_objfiles)
9168         (maintenance_info_symtabs, maintenance_check_symtabs)
9169         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9170         all_objfiles.
9171         * source.c (forget_cached_source_info): Use all_objfiles.
9172         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9173         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9174         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9175         * objfiles.c (update_section_map): Use all_objfiles.
9176         (shared_objfile_contains_address_p): Likewise.
9177         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9178         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9179
9180 2019-01-09  Tom Tromey  <tom@tromey.com>
9181
9182         * common/next-iterator.h: New file.
9183         * objfiles.h (class all_objfiles): New.
9184         (struct objfile_iterator): New.
9185
9186 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9187
9188         * NEWS: Move the description of the changed "frame", "select-frame",
9189          and "info frame" commands to the Changed commands section.
9190
9191 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9192
9193         * gdbtypes.c (check_stub_method_group): Remove handling of old
9194         mangling schemes.
9195         * linespec.c (find_methods): Likewise.
9196         * stabsread.c (read_member_functions): Likewise.
9197         * valops.c (search_struct_method): Likewise.
9198         (value_struct_elt_for_reference): Likewise.
9199         * NEWS: Mention this change.
9200
9201 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9202
9203         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9204         print_source_lines.
9205         * source.c (print_source_lines_base): Update line number check.
9206         (print_source_lines): New function.
9207         (source_lines_range::source_lines_range): New function.
9208         * source.h (class source_lines_range): New class.
9209         (print_source_lines): New declaration.
9210
9211 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9212
9213         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9214
9215 2019-01-08  Tom Tromey  <tom@tromey.com>
9216             Simon Marchi  <simon.marchi@ericsson.com>
9217
9218         PR gdb/24060
9219         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9220         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9221         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9222         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9223         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9224         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9225
9226 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9227
9228         * source.c (select_source_symtab): Move header comment to
9229         declaration in source.h.
9230         (forget_cached_source_info_for_objfile): Likewise.
9231         (forget_cached_source_info): Likewise.
9232         (identify_source_line): Likewise.
9233         * source.h (identify_source_line): Move declaration from symtab.h
9234         and add comment from source.c
9235         (print_source_lines): Likewise.
9236         (forget_cached_source_info_for_objfile): Likewise.
9237         (forget_cached_source_info): Likewise.
9238         (select_source_symtab): Likewise.
9239         (enum print_source_lines_flag): Move definition from symtab.h.
9240         * symtab.h (identify_source_line): Move declaration to source.h.
9241         (print_source_lines): Likewise.
9242         (forget_cached_source_info_for_objfile): Likewise.
9243         (forget_cached_source_info): Likewise.
9244         (select_source_symtab): Likewise.
9245         (enum print_source_lines_flag): Move definition to source.h.
9246         * tui/tui-hooks.c: Add 'source.h' include.
9247
9248 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9249
9250         * source.c (print_source_lines_base): Handle requests to print
9251         reverse line number sequences, and guard against empty lines
9252         string.
9253
9254 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9255
9256         * source.c (print_source_lines_base): Fix skip of '\r' if next
9257         character is '\n'.
9258
9259 2019-01-06  Tom Tromey  <tom@tromey.com>
9260
9261         * c-exp.y (struct c_parse_state) <macro_original_text,
9262         expansion_obstack>: New member.
9263         (macro_original_text, expansion_obstack): Remove globals.
9264         (scan_macro_expansion, scanning_macro_expansion)
9265         (finished_macro_expansion): Update.
9266         (scan_macro_cleanup): Remove.
9267         (yylex, c_parse): Update.
9268
9269 2019-01-06  Tom Tromey  <tom@tromey.com>
9270
9271         * c-exp.y (struct c_parse_state) <strings>: New member.
9272         (operator_stoken): Update.
9273
9274 2019-01-06  Tom Tromey  <tom@tromey.com>
9275
9276         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9277         (union type_stack_elt) <typelist_val>: Now a pointer to
9278         std::vector.
9279         (type_stack_cleanup): Don't declare.
9280         (push_typelist): Update.
9281         * parse.c (pop_typelist): Return a std::vector.
9282         (push_typelist): Take a std::vector.
9283         (follow_types): Update.  Do not free args.
9284         (type_stack_cleanup): Remove.
9285         * c-exp.y (struct c_parse_state): New.
9286         (cpstate): New global.
9287         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9288         (nonempty_typelist): Update.
9289         (func_mod): Create a new vector.
9290         (c_parse): Create a c_parse_state.
9291         (check_parameter_typelist): Do not delete params.
9292         (function_method): Update.  Do not delete type_list.
9293
9294 2019-01-06  Tom Tromey  <tom@tromey.com>
9295
9296         PR gdb/28155:
9297         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9298         check_typedef.
9299         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9300         (print_return_value): Likewise.
9301
9302 2019-01-05  Tom Tromey  <tom@tromey.com>
9303
9304         * contrib/cleanup_check.py: Remove.
9305         * contrib/gcc-with-excheck: Remove.
9306         * contrib/exsummary.py: Remove.
9307         * contrib/excheck.py: Remove.
9308
9309 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9310
9311         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9312         NULL. Initialize tpprev to NULL instead of assigning it
9313         to NULL on the next statement.
9314         * windows-nat.c (windows_delete_thread): Remove check for
9315         main_thread_id before printing thread exit notifications.
9316         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9317         Remove thread ID check against main_thread_id.
9318         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9319         windows_delete_thread.
9320         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9321
9322 2019-01-04  Tom Tromey  <tom@tromey.com>
9323
9324         * compile/compile.c (_initialize_compile): Use upper case for
9325         metasyntactic variables.
9326         * symmisc.c (_initialize_symmisc): Use upper case for
9327         metasyntactic variables.
9328         * psymtab.c (_initialize_psymtab): Use upper case for
9329         metasyntactic variables.
9330         * demangle.c (demangle_command): Use upper case for metasyntactic
9331         variables.
9332         (_initialize_demangler): Likewise.
9333         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9334         variables.
9335
9336 2019-01-03  Tom Tromey  <tom@tromey.com>
9337
9338         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9339
9340 2019-01-03  Tom Tromey  <tom@tromey.com>
9341
9342         * python/py-symtab.c (salpy_str): Update.
9343         (struct salpy_sal_object) <symtab>: Now a PyObject.
9344         (salpy_dealloc): Update.
9345         (del_objfile_sal): Use gdbpy_ref.
9346
9347 2019-01-03  Tom Tromey  <tom@tromey.com>
9348
9349         * python/py-type.c (convert_field): Use new_reference.  Return
9350         gdbpy_ref.
9351         (make_fielditem): Return gdbpy_ref.
9352         (typy_fields): Update.
9353         (typy_getitem): Update.
9354         (field_name): Return gdbpy_ref.  Use new_reference.
9355         (typy_iterator_iternext): Update.
9356
9357 2019-01-03  Tom Tromey  <tom@tromey.com>
9358
9359         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9360
9361 2019-01-03  Tom Tromey  <tom@tromey.com>
9362
9363         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9364         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9365         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9366         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9367         (pspy_set_type_printers): Likewise.
9368         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9369         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9370         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9371         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9372         (objfpy_set_type_printers): Likewise.
9373
9374 2019-01-03  Tom Tromey  <tom@tromey.com>
9375
9376         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9377         (gdbpy_print_stack): Use gdbpy_err_fetch.
9378         * python/python-internal.h (class gdbpy_err_fetch): New class.
9379         (class gdbpy_enter) <m_error_type, m_error_value,
9380         m_error_traceback>: Remove.
9381         <m_error>: New member.
9382         (gdbpy_exception_to_string): Don't declare.
9383         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9384         * python/py-value.c (convert_value_from_python): Use
9385         gdbpy_err_fetch.
9386         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9387         gdbpy_exception_to_string.
9388         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9389         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9390         gdbpy_err_fetch.
9391
9392 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9393
9394         * linux-nat.c (delete_lwp_cleanup): Delete.
9395         (struct lwp_deleter): New struct.
9396         (lwp_info_up): New typedef.
9397         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9398         lwp_info_up.
9399
9400 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9401
9402         * linux-fork.c (class scoped_switch_fork_info): New class.
9403         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9404
9405 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9406
9407         * valops.c (find_overload_match): Remove use of null_cleanup, and
9408         calls to do_cleanups.
9409
9410 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9411
9412         * compile/compile-cplus-types.c
9413         (compile_cplus_instance::decl_name): Handle changes to
9414         cp_func_name.
9415         * cp-support.c (cp_func_name): Update header comment, update
9416         return type.
9417         * cp-support.h (cp_func_name): Update return type in declaration.
9418         * valops.c (find_overload_match): Move temp_func local to top
9419         level of function and change its type.  Use temp_func to hold and
9420         delete temporary string obtained from cp_func_name.
9421
9422 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9423
9424         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9425         gdb::char_vector, remove cleanup, and update uses of `msg`.
9426
9427 2019-01-03  Jim Wilson  <jimw@sifive.com>
9428
9429         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9430
9431 2019-01-02  Tom Tromey  <tom@tromey.com>
9432
9433         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9434         (tdesc_parse_xml): Remove cleanups.
9435         * target-descriptions.h (make_cleanup_free_target_description):
9436         Don't declare.
9437         (target_desc_deleter): New struct.
9438         (target_desc_up): New typedef.
9439         * target-descriptions.c (target_desc_deleter::operator()): Rename
9440         from free_target_description.
9441         (make_cleanup_free_target_description): Remove.
9442
9443 2019-01-02  Tom Tromey  <tom@tromey.com>
9444
9445         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9446         constructor, destructor.
9447         (linespec_parser): Remove typedef.
9448         (~linespec_parser): Rename from linespec_parser_delete.
9449         (linespec_lex_to_end, linespec_complete_label)
9450         (linespec_complete): Update.
9451         (decode_line_full): Remove cleanups.
9452         (decode_line_1): Update.
9453
9454 2019-01-02  Tom Tromey  <tom@tromey.com>
9455
9456         * python/python-internal.h (inferior_to_inferior_object): Change
9457         return type.
9458         * python/py-exitedevent.c (create_exited_event_object): Update.
9459         * python/py-inferior.c (inferior_to_inferior_object): Return
9460         gdbpy_ref.
9461         (python_new_inferior, python_inferior_deleted)
9462         (thread_to_thread_object, delete_thread_object)
9463         (build_inferior_list, gdbpy_selected_inferior): Update.
9464         * python/py-infthread.c (create_thread_object): Update.  Also fail
9465         if inferior_to_inferior_object fails.
9466
9467 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9468
9469         * inferior.h (class inferior) <displaced_step_state>: New field.
9470         * infrun.h (struct displaced_step_state): Move here from
9471         infrun.c.  Initialize fields, add constructor.
9472         <inf>: Remove field.
9473         <reset>: New method.
9474         * infrun.c (struct displaced_step_inferior_state): Move to
9475         infrun.h.
9476         (displaced_step_inferior_states): Remove.
9477         (get_displaced_stepping_state): Adust.
9478         (displaced_step_in_progress_any_inferior): Adjust.
9479         (displaced_step_in_progress_thread): Adjust.
9480         (displaced_step_in_progress): Adjust.
9481         (add_displaced_stepping_state): Remove.
9482         (get_displaced_step_closure_by_addr): Adjust.
9483         (remove_displaced_stepping_state): Remove.
9484         (infrun_inferior_exit): Call displaced_step_state.reset.
9485         (use_displaced_stepping): Don't check for NULL.
9486         (displaced_step_prepare_throw): Call
9487         get_displaced_stepping_state.
9488         (displaced_step_fixup): Don't check for NULL.
9489         (prepare_for_detach): Don't check for NULL.
9490
9491 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9492
9493         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9494          in case of call that did not complete.
9495
9496 2019-01-02  Andrey Utkin  <autkin@undo.io>
9497
9498         * symfile.c (find_separate_debug_file): Fix search of debug files for
9499         remote debuggee.
9500
9501 2019-01-02  Tom Tromey  <tom@tromey.com>
9502
9503         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9504         indentation.
9505         * python/py-frame.c (frapy_older): Remove cast.
9506         (frapy_newer): Likewise.
9507         * python/py-breakpoint.c (local_setattro): Remove cast.
9508         * python/py-arch.c (archpy_name): Remove local variable.
9509         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9510
9511 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9512
9513         * unittests/basic_string_view/element_access/char/empty.cc:
9514         Fix year range in copyright header.
9515
9516 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9517
9518         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9519         Delete.
9520         <operator==>: Update with for removed field.
9521         <hash>: Likewise.
9522         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9523         <isa_features>: ...this.
9524         <abi_features>: New field.
9525         (riscv_isa_flen): Update comment.
9526         (riscv_abi_xlen): New declaration.
9527         (riscv_abi_flen): New declaration.
9528         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9529         isa_features.
9530         (riscv_abi_xlen): New function.
9531         (riscv_isa_flen): Update to get answer from isa_features.
9532         (riscv_abi_flen): New function.
9533         (riscv_has_fp_abi): Update to get answer from abi_features.
9534         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9535         xlen and flen.
9536         (riscv_call_info) <xlen, flen>: Update comment.
9537         (riscv_call_arg_struct): Remove invalid assertions
9538         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9539         is removed.
9540         (riscv_gdbarch_init): Gather isa features and abi features
9541         separately, ensure both match on the gdbarch when reusing an old
9542         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9543         a target with 64-bit float hardware.
9544
9545 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9546
9547         * source.c (search_command_helper): Stop reverse search
9548         when line 1 has been searched.
9549
9550 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9551
9552         * record-full.c (record_full_base_target::close): Rewrite
9553         record_full_core_buf_list free logic.
9554
9555 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9556
9557         * break-catch-syscall.c (print_one_catch_syscall): xfree
9558         the last text.
9559
9560 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9561
9562         * top.c (print_gdb_version): Update Copyright year in version
9563         message.
9564
9565 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9566
9567         Update copyright year range in all GDB files.
9568
9569 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9570
9571         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9572
9573 For older changes see ChangeLog-2018.
9574 \f
9575 Local Variables:
9576 mode: change-log
9577 left-margin: 8
9578 fill-column: 74
9579 version-control: never
9580 coding: utf-8
9581 End:
9582