gdb/ChangeLog

   1 2019-02-15  Tom Tromey  <tromey@adacore.com>
   2
   3         * ravenscar-thread.c (ravenscar_thread_target::resume)
   4         (ravenscar_thread_target::wait): Special case wildcard requests.
   5
   6 2019-02-15  Tom Tromey  <tromey@adacore.com>
   7
   8         * ravenscar-thread.c (base_ptid): Remove.
   9         (struct ravenscar_thread_target) <close>: New method.
  10         <m_base_ptid>: New member.
  11         <update_inferior_ptid, active_task, task_is_currently_active,
  12         runtime_initialized>: Declare methods.
  13         <ravenscar_thread_target>: Add constructor.
  14         (ravenscar_thread_target::task_is_currently_active)
  15         (ravenscar_thread_target::update_inferior_ptid)
  16         (ravenscar_runtime_initialized): Rename.  Now methods.
  17         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
  18         (ravenscar_thread_target::update_thread_list): Update.
  19         (ravenscar_thread_target::active_task): Now method.
  20         (ravenscar_thread_target::store_registers)
  21         (ravenscar_thread_target::prepare_to_store)
  22         (ravenscar_thread_target::prepare_to_store)
  23         (ravenscar_thread_target::mourn_inferior): Update.
  24         (ravenscar_inferior_created): Use "new" to create target.
  25         (ravenscar_thread_target::get_ada_task_ptid): Update.
  26         (_initialize_ravenscar): Don't initialize base_ptid.
  27         (ravenscar_ops): Remove global.
  28
  29 2019-02-15  Tom Tromey  <tromey@adacore.com>
  30
  31         * target.h (push_target): Declare new overload.
  32         * target.c (push_target): New overload, taking an rvalue reference.
  33         * remote.c (remote_target::open_1): Use push_target overload.
  34         * corelow.c (core_target_open): Use push_target overload.
  35
  36 2019-02-15  Tom Tromey  <tromey@adacore.com>
  37
  38         * ravenscar-thread.c (is_ravenscar_task)
  39         (ravenscar_task_is_currently_active): Return bool.
  40         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
  41         (_initialize_ravenscar): Remove "(void)".
  42         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
  43         Return bool.
  44
  45 2019-02-15  Tom Tromey  <tromey@adacore.com>
  46
  47         * ravenscar-thread.c (ravenscar_runtime_initializer)
  48         (has_ravenscar_runtime, get_running_thread_id)
  49         (ravenscar_thread_target::resume): Fix indentation.
  50
  51 2019-02-15  Tom Tromey  <tromey@adacore.com>
  52
  53         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
  54         from ravenscar_arch_ops.
  55         (sparc_ravenscar_ops::fetch_registers)
  56         (sparc_ravenscar_ops::store_registers): Now methods.
  57         (sparc_ravenscar_prepare_to_store): Remove.
  58         (sparc_ravenscar_ops): Redefine.
  59         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
  60         methods and destructor.  Remove members.
  61         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
  62         (ravenscar_thread_target::store_registers)
  63         (ravenscar_thread_target::prepare_to_store): Update.
  64         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
  65         Remove.
  66         (struct ppc_ravenscar_powerpc_ops): Derive from
  67         ravenscar_arch_ops.
  68         (ppc_ravenscar_powerpc_ops::fetch_registers)
  69         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
  70         (ppc_ravenscar_powerpc_ops): Redefine.
  71         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
  72         (ppc_ravenscar_e500_ops::fetch_registers)
  73         (ppc_ravenscar_e500_ops::store_registers): Now methods.
  74         (ppc_ravenscar_e500_ops): Redefine.
  75         * aarch64-ravenscar-thread.c
  76         (aarch64_ravenscar_generic_prepare_to_store): Remove.
  77         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
  78         (aarch64_ravenscar_fetch_registers)
  79         (aarch64_ravenscar_store_registers): Now methods.
  80         (aarch64_ravenscar_ops): Redefine.
  81
  82 2019-02-15  Tom Tromey  <tromey@adacore.com>
  83
  84         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
  85         (ravenscar_thread_target::stopped_by_hw_breakpoint)
  86         (ravenscar_thread_target::stopped_by_watchpoint)
  87         (ravenscar_thread_target::stopped_data_address)
  88         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
  89
  90 2019-02-15  Tom Tromey  <tromey@adacore.com>
  91
  92         * ravenscar-thread.c: Fix some typos.
  93
  94 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  95             Tom Tromey  <tromey@adacore.com>
  96
  97         * ada-lang.c (ada_exception_sal): Change addr_string to a
  98         std::string.
  99         (create_ada_exception_catchpoint): Update.
 100
 101 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 102             Tom Tromey  <tromey@adacore.com>
 103
 104         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 105         (bp_location_ops): Remove.
 106         (base_breakpoint_allocate_location): Update.
 107         (free_bp_location): Update.
 108         * ada-lang.c (class ada_catchpoint_location)
 109         <ada_catchpoint_location>: Remove ops parameter.
 110         (ada_catchpoint_location_dtor): Remove.
 111         (ada_catchpoint_location_ops): Remove.
 112         (allocate_location_exception): Update.
 113         * breakpoint.h (struct bp_location_ops): Remove.
 114         (class bp_location) <bp_location>: Remove bp_location_ops
 115         parameter.
 116         <~bp_location>: Add destructor.
 117         <ops>: Remove.
 118
 119 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 120             Pedro Alves  <palves@redhat.com>
 121
 122         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 123         'PATH_MAX'.
 124
 125 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 126             Samuel Thibault  <samuel.thibault@gnu.org>
 127             Thomas Schwinge  <thomas@codesourcery.com>
 128
 129         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 130         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 131
 132 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 133
 134         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 135         (check_empty): Use "const char *".
 136
 137         * gnu-nat.c (gnu_nat_target::detach): Instead of
 138         'detach_inferior (pid)' call
 139         'detach_inferior (find_inferior_pid (pid))'.
 140
 141         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 142         'nat/fork-inferior.o'.
 143         * gnu-nat.c: #include "nat/fork-inferior.h".
 144
 145         * gnu-nat.c (gnu_nat_target::detach): Instead of
 146         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 147         * gnu-nat.h: #include "inf-child.h".
 148         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 149         'i386_gnu_nat_target::fetch_registers'.
 150         (gnu_store_registers): Rename/move to
 151         'i386_gnu_nat_target::store_registers'.
 152
 153         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 154         * gnu-nat.h (mach_thread_info): New function.
 155         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 156
 157         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 158
 159 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 160
 161         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 162
 163 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 164
 165         * windows-nat.c (windows_add_thread): Add new parameter
 166         "main_thread_p" with default value set to false.  Update
 167         function documentation as well as all callers.
 168         (windows_delete_thread): Likewise.
 169         (fake_create_process): Update call to windows_add_thread.
 170         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 171         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 172         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 173         call to windows_delete_thread.
 174
 175 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 176
 177         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 178
 179 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 180
 181         * symfile.c (find_separate_debug_file): Use canonical path of
 182         sysroot with child_path instead of gdb_sysroot if it is valid.
 183
 184 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 185
 186         * symfile.c (find_separate_debug_file): Use child_path to
 187         determine if an object file is under a sysroot.
 188
 189 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 190
 191         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 192         unittests/child-path-selftests.c.
 193         * common/pathstuff.c (child_path): New function.
 194         * common/pathstuff.h (child_path): New prototype.
 195         * unittests/child-path-selftests.c: New file.
 196
 197 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 198
 199         * symfile.c (find_separate_debug_file): Look for separate debug
 200         files in debug directories under the sysroot.
 201
 202 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 203
 204         * symtab.h (struct minimal_symbol data_p): New const method.
 205         (struct minimal_symbol text_p): Likewise.
 206         * symtab.c (output_source_filename): Use file name style
 207         to print file name.
 208         (print_symbol_info): Likewise.
 209         (print_msymbol_info): Use address style to print addresses.
 210         Use function name style to print executable text symbols.
 211         (expand_symtab_containing_pc): Use data_p.
 212         (find_pc_sect_compunit_symtab): Likewise.
 213
 214 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 215
 216         * breakpoint.c (describe_other_breakpoints): Use address style
 217         to print addresses.
 218         (say_where): Likewise.
 219
 220 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 221
 222         * ada-typeprint.c (print_func_type): Print function name
 223         style to print function name.
 224         * c-typeprint.c (c_print_type_1): Likewise.
 225
 226 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 227
 228         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 229         for execve.
 230
 231 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 232
 233         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 234         type_stack.
 235
 236 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 237
 238         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 239         TYPE_CODE_REF types.
 240
 241 2019-02-08  Jim Wilson  <jimw@sifive.com>
 242
 243         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 244         (riscv_linux_fregset): New.
 245         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 246
 247 2019-02-07  Tom Tromey  <tom@tromey.com>
 248
 249         * thread.c (thread_cancel_execution_command): Update.
 250         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 251         methods.
 252         (struct thread_fsm_ops): Remove.
 253         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 254         (thread_fsm_should_stop, thread_fsm_return_value)
 255         (thread_fsm_set_finished, thread_fsm_finished_p)
 256         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 257         Don't declare.
 258         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 259         * infrun.c (clear_proceed_status_thread)
 260         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 261         (print_stop_event): Update.
 262         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 263         Add constructor.
 264         (step_command_fsm_ops): Remove.
 265         (new_step_command_fsm): Remove.
 266         (step_1): Update.
 267         (step_command_fsm::should_stop): Rename from
 268         step_command_fsm_should_stop.
 269         (step_command_fsm::clean_up): Rename from
 270         step_command_fsm_clean_up.
 271         (step_command_fsm::do_async_reply_reason): Rename from
 272         step_command_fsm_async_reply_reason.
 273         (struct until_next_fsm): Inherit from thread_fsm.  Add
 274         constructor.
 275         (until_next_fsm_ops): Remove.
 276         (new_until_next_fsm): Remove.
 277         (until_next_fsm::should_stop): Rename from
 278         until_next_fsm_should_stop.
 279         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 280         (until_next_fsm::do_async_reply_reason): Rename from
 281         until_next_fsm_async_reply_reason.
 282         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 283         constructor.  Change type of breakpoint.
 284         (finish_command_fsm_ops): Remove.
 285         (new_finish_command_fsm): Remove.
 286         (finish_command_fsm::should_stop): Rename from
 287         finish_command_fsm_should_stop.
 288         (finish_command_fsm::clean_up): Rename from
 289         finish_command_fsm_clean_up.
 290         (finish_command_fsm::return_value): Rename from
 291         finish_command_fsm_return_value.
 292         (finish_command_fsm::do_async_reply_reason): Rename from
 293         finish_command_fsm_async_reply_reason.
 294         (finish_command): Update.
 295         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 296         Add constructor.
 297         (call_thread_fsm_ops): Remove.
 298         (call_thread_fsm::call_thread_fsm): Rename from
 299         new_call_thread_fsm.
 300         (call_thread_fsm::should_stop): Rename from
 301         call_thread_fsm_should_stop.
 302         (call_thread_fsm::should_notify_stop): Rename from
 303         call_thread_fsm_should_notify_stop.
 304         (run_inferior_call, call_function_by_hand_dummy): Update.
 305         * cli/cli-interp.c (should_print_stop_to_console): Update.
 306         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 307         Add constructor.  Change type of location_breakpoint,
 308         caller_breakpoint.
 309         (until_break_fsm_ops): Remove.
 310         (new_until_break_fsm): Remove.
 311         (until_break_fsm::should_stop): Rename from
 312         until_break_fsm_should_stop.
 313         (until_break_fsm::clean_up): Rename from
 314         until_break_fsm_clean_up.
 315         (until_break_fsm::do_async_reply_reason): Rename from
 316         until_break_fsm_async_reply_reason.
 317         (until_break_command): Update.
 318         * thread-fsm.c: Remove.
 319         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 320
 321 2019-02-07  Tom Tromey  <tom@tromey.com>
 322
 323         * yy-remap.h: Add include guard.
 324         * xtensa-tdep.h: Add include guard.
 325         * xcoffread.h: Rename include guard.
 326         * varobj-iter.h: Add include guard.
 327         * tui/tui.h: Rename include guard.
 328         * tui/tui-winsource.h: Rename include guard.
 329         * tui/tui-wingeneral.h: Rename include guard.
 330         * tui/tui-windata.h: Rename include guard.
 331         * tui/tui-win.h: Rename include guard.
 332         * tui/tui-stack.h: Rename include guard.
 333         * tui/tui-source.h: Rename include guard.
 334         * tui/tui-regs.h: Rename include guard.
 335         * tui/tui-out.h: Rename include guard.
 336         * tui/tui-layout.h: Rename include guard.
 337         * tui/tui-io.h: Rename include guard.
 338         * tui/tui-hooks.h: Rename include guard.
 339         * tui/tui-file.h: Rename include guard.
 340         * tui/tui-disasm.h: Rename include guard.
 341         * tui/tui-data.h: Rename include guard.
 342         * tui/tui-command.h: Rename include guard.
 343         * tic6x-tdep.h: Add include guard.
 344         * target/waitstatus.h: Rename include guard.
 345         * target/wait.h: Rename include guard.
 346         * target/target.h: Rename include guard.
 347         * target/resume.h: Rename include guard.
 348         * target-float.h: Rename include guard.
 349         * stabsread.h: Add include guard.
 350         * rs6000-tdep.h: Add include guard.
 351         * riscv-fbsd-tdep.h: Add include guard.
 352         * regformats/regdef.h: Rename include guard.
 353         * record.h: Rename include guard.
 354         * python/python.h: Rename include guard.
 355         * python/python-internal.h: Rename include guard.
 356         * python/py-stopevent.h: Rename include guard.
 357         * python/py-ref.h: Rename include guard.
 358         * python/py-record.h: Rename include guard.
 359         * python/py-record-full.h: Rename include guard.
 360         * python/py-record-btrace.h: Rename include guard.
 361         * python/py-instruction.h: Rename include guard.
 362         * python/py-events.h: Rename include guard.
 363         * python/py-event.h: Rename include guard.
 364         * procfs.h: Add include guard.
 365         * proc-utils.h: Add include guard.
 366         * p-lang.h: Add include guard.
 367         * or1k-tdep.h: Rename include guard.
 368         * observable.h: Rename include guard.
 369         * nto-tdep.h: Rename include guard.
 370         * nat/x86-linux.h: Rename include guard.
 371         * nat/x86-linux-dregs.h: Rename include guard.
 372         * nat/x86-gcc-cpuid.h: Add include guard.
 373         * nat/x86-dregs.h: Rename include guard.
 374         * nat/x86-cpuid.h: Rename include guard.
 375         * nat/ppc-linux.h: Rename include guard.
 376         * nat/mips-linux-watch.h: Rename include guard.
 377         * nat/linux-waitpid.h: Rename include guard.
 378         * nat/linux-ptrace.h: Rename include guard.
 379         * nat/linux-procfs.h: Rename include guard.
 380         * nat/linux-osdata.h: Rename include guard.
 381         * nat/linux-nat.h: Rename include guard.
 382         * nat/linux-namespaces.h: Rename include guard.
 383         * nat/linux-btrace.h: Rename include guard.
 384         * nat/glibc_thread_db.h: Rename include guard.
 385         * nat/gdb_thread_db.h: Rename include guard.
 386         * nat/gdb_ptrace.h: Rename include guard.
 387         * nat/fork-inferior.h: Rename include guard.
 388         * nat/amd64-linux-siginfo.h: Rename include guard.
 389         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 390         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 391         * nat/aarch64-linux.h: Rename include guard.
 392         * nat/aarch64-linux-hw-point.h: Rename include guard.
 393         * mn10300-tdep.h: Add include guard.
 394         * mips-linux-tdep.h: Add include guard.
 395         * mi/mi-parse.h: Rename include guard.
 396         * mi/mi-out.h: Rename include guard.
 397         * mi/mi-main.h: Rename include guard.
 398         * mi/mi-interp.h: Rename include guard.
 399         * mi/mi-getopt.h: Rename include guard.
 400         * mi/mi-console.h: Rename include guard.
 401         * mi/mi-common.h: Rename include guard.
 402         * mi/mi-cmds.h: Rename include guard.
 403         * mi/mi-cmd-break.h: Rename include guard.
 404         * m2-lang.h: Add include guard.
 405         * location.h: Rename include guard.
 406         * linux-record.h: Rename include guard.
 407         * linux-nat.h: Add include guard.
 408         * linux-fork.h: Add include guard.
 409         * i386-darwin-tdep.h: Rename include guard.
 410         * hppa-linux-offsets.h: Add include guard.
 411         * guile/guile.h: Rename include guard.
 412         * guile/guile-internal.h: Rename include guard.
 413         * gnu-nat.h: Rename include guard.
 414         * gdb-stabs.h: Rename include guard.
 415         * frv-tdep.h: Add include guard.
 416         * f-lang.h: Add include guard.
 417         * event-loop.h: Add include guard.
 418         * darwin-nat.h: Rename include guard.
 419         * cp-abi.h: Rename include guard.
 420         * config/sparc/nm-sol2.h: Rename include guard.
 421         * config/nm-nto.h: Rename include guard.
 422         * config/nm-linux.h: Add include guard.
 423         * config/i386/nm-i386gnu.h: Rename include guard.
 424         * config/djgpp/nl_types.h: Rename include guard.
 425         * config/djgpp/langinfo.h: Rename include guard.
 426         * compile/gcc-cp-plugin.h: Add include guard.
 427         * compile/gcc-c-plugin.h: Add include guard.
 428         * compile/compile.h: Rename include guard.
 429         * compile/compile-object-run.h: Rename include guard.
 430         * compile/compile-object-load.h: Rename include guard.
 431         * compile/compile-internal.h: Rename include guard.
 432         * compile/compile-cplus.h: Rename include guard.
 433         * compile/compile-c.h: Rename include guard.
 434         * common/xml-utils.h: Rename include guard.
 435         * common/x86-xstate.h: Rename include guard.
 436         * common/version.h: Rename include guard.
 437         * common/vec.h: Rename include guard.
 438         * common/tdesc.h: Rename include guard.
 439         * common/selftest.h: Rename include guard.
 440         * common/scoped_restore.h: Rename include guard.
 441         * common/scoped_mmap.h: Rename include guard.
 442         * common/scoped_fd.h: Rename include guard.
 443         * common/safe-iterator.h: Rename include guard.
 444         * common/run-time-clock.h: Rename include guard.
 445         * common/refcounted-object.h: Rename include guard.
 446         * common/queue.h: Rename include guard.
 447         * common/ptid.h: Rename include guard.
 448         * common/print-utils.h: Rename include guard.
 449         * common/preprocessor.h: Rename include guard.
 450         * common/pathstuff.h: Rename include guard.
 451         * common/observable.h: Rename include guard.
 452         * common/netstuff.h: Rename include guard.
 453         * common/job-control.h: Rename include guard.
 454         * common/host-defs.h: Rename include guard.
 455         * common/gdb_wait.h: Rename include guard.
 456         * common/gdb_vecs.h: Rename include guard.
 457         * common/gdb_unlinker.h: Rename include guard.
 458         * common/gdb_unique_ptr.h: Rename include guard.
 459         * common/gdb_tilde_expand.h: Rename include guard.
 460         * common/gdb_sys_time.h: Rename include guard.
 461         * common/gdb_string_view.h: Rename include guard.
 462         * common/gdb_splay_tree.h: Rename include guard.
 463         * common/gdb_setjmp.h: Rename include guard.
 464         * common/gdb_ref_ptr.h: Rename include guard.
 465         * common/gdb_optional.h: Rename include guard.
 466         * common/gdb_locale.h: Rename include guard.
 467         * common/gdb_assert.h: Rename include guard.
 468         * common/filtered-iterator.h: Rename include guard.
 469         * common/filestuff.h: Rename include guard.
 470         * common/fileio.h: Rename include guard.
 471         * common/environ.h: Rename include guard.
 472         * common/common-utils.h: Rename include guard.
 473         * common/common-types.h: Rename include guard.
 474         * common/common-regcache.h: Rename include guard.
 475         * common/common-inferior.h: Rename include guard.
 476         * common/common-gdbthread.h: Rename include guard.
 477         * common/common-exceptions.h: Rename include guard.
 478         * common/common-defs.h: Rename include guard.
 479         * common/common-debug.h: Rename include guard.
 480         * common/cleanups.h: Rename include guard.
 481         * common/buffer.h: Rename include guard.
 482         * common/btrace-common.h: Rename include guard.
 483         * common/break-common.h: Rename include guard.
 484         * cli/cli-utils.h: Rename include guard.
 485         * cli/cli-style.h: Rename include guard.
 486         * cli/cli-setshow.h: Rename include guard.
 487         * cli/cli-script.h: Rename include guard.
 488         * cli/cli-interp.h: Rename include guard.
 489         * cli/cli-decode.h: Rename include guard.
 490         * cli/cli-cmds.h: Rename include guard.
 491         * charset-list.h: Add include guard.
 492         * buildsym-legacy.h: Rename include guard.
 493         * bfin-tdep.h: Add include guard.
 494         * ax.h: Rename include guard.
 495         * arm-linux-tdep.h: Add include guard.
 496         * arm-fbsd-tdep.h: Add include guard.
 497         * arch/xtensa.h: Rename include guard.
 498         * arch/tic6x.h: Add include guard.
 499         * arch/i386.h: Add include guard.
 500         * arch/arm.h: Rename include guard.
 501         * arch/arm-linux.h: Rename include guard.
 502         * arch/arm-get-next-pcs.h: Rename include guard.
 503         * arch/amd64.h: Add include guard.
 504         * arch/aarch64-insn.h: Rename include guard.
 505         * arch-utils.h: Rename include guard.
 506         * annotate.h: Add include guard.
 507         * amd64-darwin-tdep.h: Rename include guard.
 508         * aarch64-linux-tdep.h: Add include guard.
 509         * aarch64-fbsd-tdep.h: Add include guard.
 510         * aarch32-linux-nat.h: Add include guard.
 511
 512 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 513
 514         * macrotab.c (macro_define_internal): New function that
 515         factorizes macro_define_object_internal and macro_define_function
 516         code.
 517         (macro_define_object_internal): Use macro_define_internal.
 518         (macro_define_function): Likewise.
 519
 520 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 521
 522         * macrocmd.c (extract_identifier): Return
 523         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 524         callers.
 525
 526 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 527
 528         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 529
 530 2019-02-05  Tom Tromey  <tom@tromey.com>
 531
 532         * target.c (target_stack::unpush): Move assertion earlier.
 533
 534 2019-01-30  Tom Tromey  <tom@tromey.com>
 535
 536         PR python/23615:
 537         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 538         (gdbpy_parse_and_eval): Likewise.
 539         * python/python-internal.h (gdbpy_allow_threads): New class.
 540
 541 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 542
 543         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 544         (aarch64_fbsd_fpregmap): Move earlier.
 545         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 546         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 547         instead of individual calls to trad_frame_set_reg_addr.
 548         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 549         earlier.
 550         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 551         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 552         instead of individual calls to trad_frame_set_reg_addr.
 553
 554 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 555
 556         * CONTRIBUTE: Replace contribution list with wiki link.
 557
 558 2019-01-25  Tom Tromey  <tom@tromey.com>
 559
 560         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 561
 562 2019-01-25  Tom Tromey  <tom@tromey.com>
 563
 564         * xtensa-linux-nat.c: Fix common/ includes.
 565         * xml-support.h: Fix common/ includes.
 566         * xml-support.c: Fix common/ includes.
 567         * x86-linux-nat.c: Fix common/ includes.
 568         * windows-nat.c: Fix common/ includes.
 569         * varobj.h: Fix common/ includes.
 570         * varobj.c: Fix common/ includes.
 571         * value.c: Fix common/ includes.
 572         * valops.c: Fix common/ includes.
 573         * utils.c: Fix common/ includes.
 574         * unittests/xml-utils-selftests.c: Fix common/ includes.
 575         * unittests/utils-selftests.c: Fix common/ includes.
 576         * unittests/unpack-selftests.c: Fix common/ includes.
 577         * unittests/tracepoint-selftests.c: Fix common/ includes.
 578         * unittests/style-selftests.c: Fix common/ includes.
 579         * unittests/string_view-selftests.c: Fix common/ includes.
 580         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 581         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 582         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 583         * unittests/rsp-low-selftests.c: Fix common/ includes.
 584         * unittests/parse-connection-spec-selftests.c: Fix common/
 585         includes.
 586         * unittests/optional-selftests.c: Fix common/ includes.
 587         * unittests/offset-type-selftests.c: Fix common/ includes.
 588         * unittests/observable-selftests.c: Fix common/ includes.
 589         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 590         * unittests/memrange-selftests.c: Fix common/ includes.
 591         * unittests/memory-map-selftests.c: Fix common/ includes.
 592         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 593         * unittests/function-view-selftests.c: Fix common/ includes.
 594         * unittests/environ-selftests.c: Fix common/ includes.
 595         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 596         * unittests/common-utils-selftests.c: Fix common/ includes.
 597         * unittests/cli-utils-selftests.c: Fix common/ includes.
 598         * unittests/array-view-selftests.c: Fix common/ includes.
 599         * ui-file.c: Fix common/ includes.
 600         * tui/tui-io.c: Fix common/ includes.
 601         * tracepoint.h: Fix common/ includes.
 602         * tracepoint.c: Fix common/ includes.
 603         * tracefile-tfile.c: Fix common/ includes.
 604         * top.h: Fix common/ includes.
 605         * top.c: Fix common/ includes.
 606         * thread.c: Fix common/ includes.
 607         * target/waitstatus.h: Fix common/ includes.
 608         * target/waitstatus.c: Fix common/ includes.
 609         * target.h: Fix common/ includes.
 610         * target.c: Fix common/ includes.
 611         * target-memory.c: Fix common/ includes.
 612         * target-descriptions.c: Fix common/ includes.
 613         * symtab.h: Fix common/ includes.
 614         * symfile.c: Fix common/ includes.
 615         * stap-probe.c: Fix common/ includes.
 616         * spu-linux-nat.c: Fix common/ includes.
 617         * sparc-nat.c: Fix common/ includes.
 618         * source.c: Fix common/ includes.
 619         * solib.c: Fix common/ includes.
 620         * solib-target.c: Fix common/ includes.
 621         * ser-unix.c: Fix common/ includes.
 622         * ser-tcp.c: Fix common/ includes.
 623         * ser-pipe.c: Fix common/ includes.
 624         * ser-base.c: Fix common/ includes.
 625         * selftest-arch.c: Fix common/ includes.
 626         * s12z-tdep.c: Fix common/ includes.
 627         * rust-exp.y: Fix common/ includes.
 628         * rs6000-aix-tdep.c: Fix common/ includes.
 629         * riscv-tdep.c: Fix common/ includes.
 630         * remote.c: Fix common/ includes.
 631         * remote-notif.h: Fix common/ includes.
 632         * remote-fileio.h: Fix common/ includes.
 633         * remote-fileio.c: Fix common/ includes.
 634         * regcache.h: Fix common/ includes.
 635         * regcache.c: Fix common/ includes.
 636         * record-btrace.c: Fix common/ includes.
 637         * python/python.c: Fix common/ includes.
 638         * python/py-type.c: Fix common/ includes.
 639         * python/py-inferior.c: Fix common/ includes.
 640         * progspace.h: Fix common/ includes.
 641         * producer.c: Fix common/ includes.
 642         * procfs.c: Fix common/ includes.
 643         * proc-api.c: Fix common/ includes.
 644         * printcmd.c: Fix common/ includes.
 645         * ppc-linux-nat.c: Fix common/ includes.
 646         * parser-defs.h: Fix common/ includes.
 647         * osdata.c: Fix common/ includes.
 648         * obsd-nat.c: Fix common/ includes.
 649         * nat/x86-linux.c: Fix common/ includes.
 650         * nat/x86-linux-dregs.c: Fix common/ includes.
 651         * nat/x86-dregs.h: Fix common/ includes.
 652         * nat/x86-dregs.c: Fix common/ includes.
 653         * nat/ppc-linux.c: Fix common/ includes.
 654         * nat/mips-linux-watch.h: Fix common/ includes.
 655         * nat/mips-linux-watch.c: Fix common/ includes.
 656         * nat/linux-waitpid.c: Fix common/ includes.
 657         * nat/linux-ptrace.h: Fix common/ includes.
 658         * nat/linux-ptrace.c: Fix common/ includes.
 659         * nat/linux-procfs.c: Fix common/ includes.
 660         * nat/linux-personality.c: Fix common/ includes.
 661         * nat/linux-osdata.c: Fix common/ includes.
 662         * nat/linux-namespaces.c: Fix common/ includes.
 663         * nat/linux-btrace.h: Fix common/ includes.
 664         * nat/linux-btrace.c: Fix common/ includes.
 665         * nat/fork-inferior.c: Fix common/ includes.
 666         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 667         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 668         * nat/aarch64-linux.c: Fix common/ includes.
 669         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 670         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 671         * namespace.h: Fix common/ includes.
 672         * mips-linux-tdep.c: Fix common/ includes.
 673         * minsyms.c: Fix common/ includes.
 674         * mi/mi-parse.h: Fix common/ includes.
 675         * mi/mi-main.c: Fix common/ includes.
 676         * mi/mi-cmd-env.c: Fix common/ includes.
 677         * memrange.h: Fix common/ includes.
 678         * memattr.c: Fix common/ includes.
 679         * maint.h: Fix common/ includes.
 680         * maint.c: Fix common/ includes.
 681         * main.c: Fix common/ includes.
 682         * machoread.c: Fix common/ includes.
 683         * location.c: Fix common/ includes.
 684         * linux-thread-db.c: Fix common/ includes.
 685         * linux-nat.c: Fix common/ includes.
 686         * linux-fork.c: Fix common/ includes.
 687         * inline-frame.c: Fix common/ includes.
 688         * infrun.c: Fix common/ includes.
 689         * inflow.c: Fix common/ includes.
 690         * inferior.h: Fix common/ includes.
 691         * inferior.c: Fix common/ includes.
 692         * infcmd.c: Fix common/ includes.
 693         * inf-ptrace.c: Fix common/ includes.
 694         * inf-child.c: Fix common/ includes.
 695         * ia64-linux-nat.c: Fix common/ includes.
 696         * i387-tdep.c: Fix common/ includes.
 697         * i386-tdep.c: Fix common/ includes.
 698         * i386-linux-tdep.c: Fix common/ includes.
 699         * i386-linux-nat.c: Fix common/ includes.
 700         * i386-go32-tdep.c: Fix common/ includes.
 701         * i386-fbsd-tdep.c: Fix common/ includes.
 702         * i386-fbsd-nat.c: Fix common/ includes.
 703         * guile/scm-type.c: Fix common/ includes.
 704         * guile/guile.c: Fix common/ includes.
 705         * go32-nat.c: Fix common/ includes.
 706         * gnu-nat.c: Fix common/ includes.
 707         * gdbthread.h: Fix common/ includes.
 708         * gdbarch-selftests.c: Fix common/ includes.
 709         * gdb_usleep.c: Fix common/ includes.
 710         * gdb_select.h: Fix common/ includes.
 711         * gdb_bfd.c: Fix common/ includes.
 712         * gcore.c: Fix common/ includes.
 713         * fork-child.c: Fix common/ includes.
 714         * findvar.c: Fix common/ includes.
 715         * fbsd-nat.c: Fix common/ includes.
 716         * event-top.c: Fix common/ includes.
 717         * event-loop.c: Fix common/ includes.
 718         * dwarf2read.c: Fix common/ includes.
 719         * dwarf2loc.c: Fix common/ includes.
 720         * dwarf2-frame.c: Fix common/ includes.
 721         * dwarf-index-cache.c: Fix common/ includes.
 722         * dtrace-probe.c: Fix common/ includes.
 723         * disasm-selftests.c: Fix common/ includes.
 724         * defs.h: Fix common/ includes.
 725         * csky-tdep.c: Fix common/ includes.
 726         * cp-valprint.c: Fix common/ includes.
 727         * cp-support.h: Fix common/ includes.
 728         * cp-support.c: Fix common/ includes.
 729         * corelow.c: Fix common/ includes.
 730         * completer.h: Fix common/ includes.
 731         * completer.c: Fix common/ includes.
 732         * compile/compile.c: Fix common/ includes.
 733         * compile/compile-loc2c.c: Fix common/ includes.
 734         * compile/compile-cplus-types.c: Fix common/ includes.
 735         * compile/compile-cplus-symbols.c: Fix common/ includes.
 736         * command.h: Fix common/ includes.
 737         * cli/cli-dump.c: Fix common/ includes.
 738         * cli/cli-cmds.c: Fix common/ includes.
 739         * charset.c: Fix common/ includes.
 740         * build-id.c: Fix common/ includes.
 741         * btrace.h: Fix common/ includes.
 742         * btrace.c: Fix common/ includes.
 743         * breakpoint.h: Fix common/ includes.
 744         * breakpoint.c: Fix common/ includes.
 745         * ax.h:
 746         (enum agent_op): Fix common/ includes.
 747         * ax-general.c (struct aop_map): Fix common/ includes.
 748         * ax-gdb.c: Fix common/ includes.
 749         * auxv.c: Fix common/ includes.
 750         * auto-load.c: Fix common/ includes.
 751         * arm-tdep.c: Fix common/ includes.
 752         * arch/riscv.c: Fix common/ includes.
 753         * arch/ppc-linux-common.c: Fix common/ includes.
 754         * arch/i386.c: Fix common/ includes.
 755         * arch/arm.c: Fix common/ includes.
 756         * arch/arm-linux.c: Fix common/ includes.
 757         * arch/arm-get-next-pcs.c: Fix common/ includes.
 758         * arch/amd64.c: Fix common/ includes.
 759         * arch/aarch64.c: Fix common/ includes.
 760         * arch/aarch64-insn.c: Fix common/ includes.
 761         * arch-utils.c: Fix common/ includes.
 762         * amd64-windows-tdep.c: Fix common/ includes.
 763         * amd64-tdep.c: Fix common/ includes.
 764         * amd64-sol2-tdep.c: Fix common/ includes.
 765         * amd64-obsd-tdep.c: Fix common/ includes.
 766         * amd64-nbsd-tdep.c: Fix common/ includes.
 767         * amd64-linux-tdep.c: Fix common/ includes.
 768         * amd64-linux-nat.c: Fix common/ includes.
 769         * amd64-fbsd-tdep.c: Fix common/ includes.
 770         * amd64-fbsd-nat.c: Fix common/ includes.
 771         * amd64-dicos-tdep.c: Fix common/ includes.
 772         * amd64-darwin-tdep.c: Fix common/ includes.
 773         * agent.c: Fix common/ includes.
 774         * ada-lang.h: Fix common/ includes.
 775         * ada-lang.c: Fix common/ includes.
 776         * aarch64-tdep.c: Fix common/ includes.
 777
 778 2019-01-25  Tom Tromey  <tom@tromey.com>
 779
 780         * common/create-version.sh: Use common/version.h.
 781
 782 2019-01-24  Pedro Alves  <palves@redhat.com>
 783
 784         * infrun.c (signal_stop, signal_print, signal_program)
 785         (signal_catch, signal_pass): Now arrays instead of pointers.
 786         (update_signals_program_target, do_target_resume)
 787         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 788         * linux-nat.c (linux_nat_target::pass_signals)
 789         (linux_nat_target::create_inferior, linux_nat_target::attach):
 790         Adjust.
 791         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 792         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 793         * procfs.c (procfs_target::pass_signals): Adjust.
 794         * record-full.c (record_full_target::resume): Adjust.
 795         * remote.c (remote_target::pass_signals)
 796         (remote_target::program_signals): Adjust.
 797         * target-debug.h (target_debug_print_signals): Now takes a
 798         gdb::array_view as parameter.  Adjust.
 799         * target.h (target_ops) <pass_signals, program_signals>: Replace
 800         pointer and length parameters with gdb::array_view.
 801         (target_pass_signals, target_program_signals): Likewise.
 802         * target-delegates.c: Regenerate.
 803
 804 2019-01-24  Pedro Alves  <palves@redhat.com>
 805
 806         * common/forward-scope-exit.h
 807         (forward_scope_exit::forward_scope_exit): Pass arguments to
 808         m_bind_function directly, instead of creating a std::bind and
 809         copying that.
 810
 811 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 812
 813         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 814         for static members.
 815         (pass_in_v_vfp_candidate): Likewise.
 816
 817 2019-01-23  Tom Tromey  <tom@tromey.com>
 818             Pedro Alves  <palves@redhat.com>
 819
 820         * regcache.c (class regcache_invalidator): Remove.
 821         (regcache::raw_write): Use make_scope_exit.
 822
 823 2019-01-23  Tom Tromey  <tom@tromey.com>
 824
 825         * ui-out.h (class ui_out_emit_type): Update comment.
 826
 827 2019-01-23  Tom Tromey  <tom@tromey.com>
 828
 829         * infrun.c (fetch_inferior_event): Update comment.
 830
 831 2019-01-23  Tom Tromey  <tom@tromey.com>
 832             Pedro Alves  <palves@redhat.com>
 833
 834         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 835         parameter.
 836         (fetch_inferior_event): Use SCOPE_EXIT.
 837
 838
 839 2019-01-23  Tom Tromey  <tom@tromey.com>
 840             Pedro Alves  <palves@redhat.com>
 841
 842         * infrun.c (disable_thread_events): Delete.
 843         (stop_all_threads): Use SCOPE_EXIT.
 844
 845 2019-01-23  Tom Tromey  <tom@tromey.com>
 846             Pedro Alves  <palves@redhat.com>
 847
 848         * symfile.c: Include forward-scope-exit.h.
 849         (clear_symtab_users_cleanup): Replace forward declaration with
 850         a FORWARD_SCOPE_EXIT.
 851         (syms_from_objfile_1): Use the forward_scope_exit and
 852         gdb::optional instead of cleanup_function.
 853         (reread_symbols): Use the forward_scope_exit instead of
 854         cleanup_function.
 855         (clear_symtab_users_cleanup): Remove function.
 856
 857 2019-01-23  Tom Tromey  <tom@tromey.com>
 858             Pedro Alves  <palves@redhat.com>
 859
 860         * linux-nat.c: Include scope-exit.h.
 861         (cleanup_target_stop): Remove.
 862         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 863         SCOPE_EXIT.
 864
 865 2019-01-23  Tom Tromey  <tom@tromey.com>
 866             Pedro Alves  <palves@redhat.com>
 867
 868         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 869         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 870
 871 2019-01-23  Tom Tromey  <tom@tromey.com>
 872             Andrew Burgess  <andrew.burgess@embecosm.com>
 873             Pedro Alves  <palves@redhat.com>
 874
 875         * infrun.c (fetch_inferior_event): Use scope_exit.
 876         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 877         * top.c (execute_command): Use scope_exit.
 878         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 879         * utils.c (do_bpstat_clear_actions_cleanup)
 880         (make_bpstat_clear_actions_cleanup): Remove.
 881
 882 2019-01-23  Tom Tromey  <tom@tromey.com>
 883             Pedro Alves  <palves@redhat.com>
 884
 885         * infrun.c: Include "common/scope-exit.h"
 886         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 887         (wait_for_inferior): Use SCOPE_EXIT.
 888         (fetch_inferior_event): Use scope_exit.
 889
 890 2019-01-23  Tom Tromey  <tom@tromey.com>
 891             Pedro Alves  <palves@redhat.com>
 892
 893         * breakpoint.c (create_breakpoint): Remove cleanup.
 894
 895 2019-01-23  Tom Tromey  <tom@tromey.com>
 896             Andrew Burgess  <andrew.burgess@embecosm.com>
 897             Pedro Alves  <palves@redhat.com>
 898
 899 2019-01-23  Pedro Alves  <palves@redhat.com>
 900
 901         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 902
 903 2019-01-23  Pedro Alves  <palves@redhat.com>
 904             Andrew Burgess  <andrew.burgess@embecosm.com>
 905
 906         * gdbthread.h: Include "common/forward-scope-exit.h".
 907         (scoped_finish_thread_state): Redefine custom class in terms of
 908         forward_scope_exit.
 909
 910 2019-01-23  Pedro Alves  <palves@redhat.com>
 911             Andrew Burgess  <andrew.burgess@embecosm.com>
 912
 913         * common/forward-scope-exit.h: New file.
 914
 915 2019-01-23  Pedro Alves  <palves@redhat.com>
 916             Andrew Burgess  <andrew.burgess@embecosm.com>
 917             Tom Tromey  <tom@tromey.com>
 918
 919         * common/scope-exit.h: New file.
 920
 921 2019-01-23  Pedro Alves  <palves@redhat.com>
 922
 923         * common/preprocessor.h (ESC): Rename to ...
 924         (ESC_PARENS): ... this.
 925         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 926         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 927
 928 2019-01-23  Tom Tromey  <tom@tromey.com>
 929
 930         * language.h (class scoped_switch_to_sym_language_if_auto):
 931         Initialize m_lang in both cases.
 932
 933 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 934
 935         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 936         with XCNEW.
 937
 938 2019-01-22  Tom Tromey  <tom@tromey.com>
 939
 940         * corelow.c: Do not include sys/file.h.
 941
 942 2019-01-22  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-wingeneral.h: Include gdb_curses.h.
 945
 946 2019-01-22  Tom Tromey  <tom@tromey.com>
 947
 948         * source-cache.h (class source_cache) <get_source_lines,
 949         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 950
 951 2019-01-22  Tom Tromey  <tom@tromey.com>
 952
 953         * remote-fileio.h (struct remote_target): Declare.
 954
 955 2019-01-22  Tom Tromey  <tom@tromey.com>
 956
 957         * python/py-arch.c: Do not include py-ref.h.
 958         * python/py-bpevent.c: Do not include py-ref.h.
 959         * python/py-cmd.c: Do not include py-ref.h.
 960         * python/py-continueevent.c: Do not include py-ref.h.
 961         * python/py-event.h: Do not include py-ref.h.
 962         * python/py-evtregistry.c: Do not include py-ref.h.
 963         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 964         * python/py-frame.c: Do not include py-ref.h.
 965         * python/py-framefilter.c: Do not include py-ref.h.
 966         * python/py-function.c: Do not include py-ref.h.
 967         * python/py-infevents.c: Do not include py-ref.h.
 968         * python/py-linetable.c: Do not include py-ref.h.
 969         * python/py-objfile.c: Do not include py-ref.h.
 970         * python/py-param.c: Do not include py-ref.h.
 971         * python/py-prettyprint.c: Do not include py-ref.h.
 972         * python/py-progspace.c: Do not include py-ref.h.
 973         * python/py-symbol.c: Do not include py-ref.h.
 974         * python/py-symtab.c: Do not include py-ref.h.
 975         * python/py-type.c: Do not include py-ref.h.
 976         * python/py-unwind.c: Do not include py-ref.h.
 977         * python/py-utils.c: Do not include py-ref.h.
 978         * python/py-value.c: Do not include py-ref.h.
 979         * python/py-varobj.c: Do not include py-ref.h.
 980         * python/py-xmethods.c: Do not include py-ref.h.
 981         * python/python.c: Do not include py-ref.h.
 982         * varobj.c: Do not include py-ref.h.
 983
 984 2019-01-22  Tom Tromey  <tom@tromey.com>
 985
 986         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 987         keyword for bcache.
 988
 989 2019-01-22  Tom Tromey  <tom@tromey.com>
 990
 991         * compile/compile-cplus-types.c: Remove a comment by #include.
 992
 993 2019-01-22  Tom Tromey  <tom@tromey.com>
 994
 995         * compile/gcc-c-plugin.h: Include compile-internal.h.
 996
 997 2019-01-22  Tom Tromey  <tom@tromey.com>
 998
 999         * stabsread.c (EXTERN): Do not define.
1000         (symnum, next_symbol_text_func, processing_gcc_compilation)
1001         (within_function, global_sym_chain, global_stabs)
1002         (previous_stab_code, this_object_header_files)
1003         (n_this_object_header_files)
1004         (n_allocated_this_object_header_files): Define.
1005         * stabsread.h (EXTERN): Never define.  Use "extern".
1006
1007 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1008
1009         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1010         history_value.
1011
1012 2019-01-21  Tom Tromey  <tom@tromey.com>
1013
1014         * ui-out.c: Fix includes.
1015         * tui/tui-source.c: Fix includes.
1016         * target.c: Fix includes.
1017         * remote.c: Fix includes.
1018         * regcache.c: Fix includes.
1019         * python/py-block.c: Fix includes.
1020         * printcmd.c: Fix includes.
1021         * or1k-tdep.c: Fix includes.
1022         * mi/mi-main.c: Fix includes.
1023         * m32r-tdep.c: Fix includes.
1024         * csky-tdep.c: Fix includes.
1025         * compile/compile-cplus-types.c: Fix includes.
1026         * cli/cli-interp.c: Fix includes.
1027
1028 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1029
1030         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1031         for padding.
1032
1033 2019-01-16  Tom Tromey  <tom@tromey.com>
1034
1035         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1036         earlier.
1037         (struct objfile) <msymbols_range>: Move from top level.
1038         <msymbols>: New method.
1039         (class objfile_msymbols): Remove.
1040         * symtab.c (default_collect_symbol_completion_matches_break_on):
1041         Update.
1042         * symmisc.c (dump_msymbols): Update.
1043         * stabsread.c (scan_file_globals): Update.
1044         * objc-lang.c (info_selectors_command, info_classes_command)
1045         (find_methods): Update.
1046         * minsyms.c (find_solib_trampoline_target): Update.
1047         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1048         * coffread.c (coff_symfile_read): Update.
1049         * ada-lang.c (ada_lookup_simple_minsym)
1050         (ada_collect_symbol_completion_matches): Update.
1051
1052 2019-01-16  Tom Tromey  <tom@tromey.com>
1053
1054         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1055         type.  Remove no-argument constructor.
1056         <iterator::operator++>: Simplify.
1057         <begin>: Update.
1058         <end>: Use minimal_symbol_count.
1059
1060 2019-01-16  Tom Tromey  <tom@tromey.com>
1061
1062         * objfiles.h (struct objfile) <psymtabs>: New method.
1063         (class objfile_psymtabs): Remove.
1064         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1065         typedef.
1066         <range>: New method.
1067         (require_partial_symbols): Change return type.
1068         * psymtab.c (require_partial_symbols)
1069         (psym_expand_symtabs_matching): Update.
1070         * mdebugread.c (parse_partial_symbols): Update.
1071         * dbxread.c (dbx_end_psymtab): Update.
1072
1073 2019-01-15  Tom Tromey  <tom@tromey.com>
1074
1075         * symtab.c (lookup_objfile_from_block)
1076         (lookup_symbol_in_objfile_symtabs)
1077         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1078         (find_line_symtab, info_sources_command)
1079         (default_collect_symbol_completion_matches_break_on)
1080         (make_source_files_completion_list): Update.
1081         * symmisc.c (print_objfile_statistics, dump_objfile)
1082         (maintenance_print_symbols, maintenance_info_symtabs)
1083         (maintenance_check_symtabs, maintenance_info_line_tables):
1084         Update.
1085         * source.c (select_source_symtab)
1086         (forget_cached_source_info_for_objfile): Update.
1087         * objfiles.h (class objfile_compunits): Remove.
1088         (struct objfile) <compunits_range>: New typedef.
1089         (compunits): New method.
1090         * objfiles.c (objfile_relocate1): Update.
1091         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1092         * maint.c (count_symtabs_and_blocks): Update.
1093         * linespec.c (iterate_over_all_matching_symtabs): Update.
1094         * cp-support.c (add_symbol_overload_list_qualified): Update.
1095         * coffread.c (coff_symtab_read): Update.
1096         * ada-lang.c (add_nonlocal_symbols)
1097         (ada_collect_symbol_completion_matches)
1098         (ada_add_global_exceptions): Update.
1099
1100 2019-01-15  Tom Tromey  <tom@tromey.com>
1101
1102         * progspace.h (program_space) <objfiles_safe_range>: New
1103         typedef.
1104         <objfiles_safe>: New method.
1105         * objfiles.h (class all_objfiles_safe): Remove.
1106         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1107         * jit.c (jit_inferior_exit_hook): Update.
1108
1109 2019-01-17  Tom Tromey  <tom@tromey.com>
1110
1111         * progspace.h (program_space) <objfiles_range>: New typedef.
1112         <objfiles>: New method.
1113         <objfiles_head>: Rename from objfiles.
1114         (object_files): Update.
1115         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1116         * guile/scm-pretty-print.c
1117         (ppscm_find_pretty_printer_from_objfiles): Update.
1118         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1119         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1120         Update.
1121         * python/py-progspace.c (pspy_get_objfiles): Update.
1122         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1123         Update.
1124         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1125         (objfpy_lookup_objfile_by_build_id): Update.
1126         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1127         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1128         Update.
1129         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1130         (expand_symtab_containing_pc, lookup_objfile_from_block)
1131         (lookup_static_symbol, basic_lookup_transparent_type)
1132         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1133         (find_line_symtab, info_sources_command)
1134         (default_collect_symbol_completion_matches_break_on)
1135         (make_source_files_completion_list, find_main_name): Update.
1136         * symmisc.c (print_symbol_bcache_statistics)
1137         (print_objfile_statistics, maintenance_print_symbols)
1138         (maintenance_print_msymbols, maintenance_print_objfiles)
1139         (maintenance_info_symtabs, maintenance_check_symtabs)
1140         (maintenance_expand_symtabs, maintenance_info_line_tables):
1141         Update.
1142         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1143         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1144         (map_overlay_command, unmap_overlay_command)
1145         (simple_overlay_update, expand_symtabs_matching)
1146         (map_symbol_filenames): Update.
1147         * symfile-debug.c (set_debug_symfile): Update.
1148         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1149         Update.
1150         * source.c (select_source_symtab, forget_cached_source_info):
1151         Update.
1152         * solib.c (solib_read_symbols): Update.
1153         * solib-spu.c (append_ocl_sos): Update.
1154         * psymtab.c (maintenance_print_psymbols)
1155         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1156         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1157         * printcmd.c (info_symbol_command): Update.
1158         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1159         Update.
1160         * objfiles.h (class all_objfiles): Remove.
1161         * objfiles.c (have_partial_symbols, have_full_symbols)
1162         (have_minimal_symbols, qsort_cmp, update_section_map)
1163         (shared_objfile_contains_address_p)
1164         (default_iterate_over_objfiles_in_search_order): Update.
1165         * objc-lang.c (info_selectors_command, info_classes_command)
1166         (find_methods): Update.
1167         * minsyms.c (find_solib_trampoline_target): Update.
1168         * maint.c (maintenance_info_sections)
1169         (maintenance_translate_address, count_symtabs_and_blocks):
1170         Update.
1171         * main.c (captured_main_1): Update.
1172         * linux-thread-db.c (try_thread_db_load_from_pdir)
1173         (has_libpthread): Update.
1174         * linespec.c (iterate_over_all_matching_symtabs)
1175         (search_minsyms_for_name): Update.
1176         * jit.c (jit_find_objf_with_entry_addr): Update.
1177         * hppa-tdep.c (find_unwind_entry)
1178         (hppa_lookup_stub_minimal_symbol): Update.
1179         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1180         Update.
1181         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1182         (elf_gnu_ifunc_resolve_by_got): Update.
1183         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1184         * dwarf-index-write.c (save_gdb_index_command): Update.
1185         * cp-support.c (add_symbol_overload_list_qualified): Update.
1186         * breakpoint.c (create_overlay_event_breakpoint)
1187         (create_longjmp_master_breakpoint)
1188         (create_std_terminate_master_breakpoint)
1189         (create_exception_master_breakpoint): Update.
1190         * blockframe.c (find_pc_partial_function): Update.
1191         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1192         (ada_collect_symbol_completion_matches)
1193         (ada_add_global_exceptions): Update.
1194
1195 2019-01-17  Tom Tromey  <tom@tromey.com>
1196
1197         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1198         declare VEC.
1199         (solib_target_parse_libraries): Change return type.
1200         (library_list_start_segment, library_list_start_section)
1201         (library_list_end_library, library_list_start_library); Update.
1202         (solib_target_free_library_list): Remove.
1203         (solib_target_parse_libraries): Remove cleanup.  Change return
1204         type.
1205         (solib_target_current_sos): Update.
1206
1207 2019-01-17  Tom Tromey  <tromey@bapiya>
1208
1209         * valprint.c: Replace "the the" with "the".
1210         * symtab.c: Replace "the the" with "the".
1211         * solib.c: Replace "the the" with "the".
1212         * solib-dsbt.c: Replace "the the" with "the".
1213         * linespec.c: Replace "the the" with "the".
1214         * dwarf2loc.h: Replace "the the" with "the".
1215         * amd64-windows-tdep.c: Replace "the the" with "the".
1216         * aarch64-tdep.c: Replace "the the" with "the".
1217
1218 2019-01-16  Keith Seitz  <keiths@redhat.com>
1219
1220         PR gdb/23773
1221         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1222         <builder>: Rename to ..
1223         <m_builder>: ... this and make private.
1224         (dwarf2_cu::get_builder): New method.  Change all users of
1225         `builder' to use this method.
1226         (dwarf2_start_symtab): Move to ...
1227         (dwarf2_cu::start_symtab): ... here.  Update all callers
1228         (setup_type_unit_groups): Move to ...
1229         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1230         callers.
1231         (dwarf2_cu::reset_builder): New method.
1232         (process_full_compunit, process_full_type_unit): Use
1233         dwarf2_cu::reset_builder.
1234         (follow_die_offset): Record the ancestor CU if it is different
1235         from the followed DIE's CU.
1236         (follow_die_sig_1): Likewise.
1237
1238 2019-01-15  Tom Tromey  <tom@tromey.com>
1239
1240         * remote.c (class remote_state) <buf>: Now a char_vector.
1241         <buf_size>: Remove.
1242         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1243         parameter.
1244         (remote_target::getpkt_or_notif_sane_1)
1245         (remote_target::getpkt_sane)
1246         (remote_target::getpkt_or_notif_sane): Likewise.
1247         (class remote_target) <putpkt>: New overload.
1248         (remote_target::read_frame): Change type of "buf_p".  Remove
1249         sizeof_p parameter.
1250         (packet_ok): New overload.
1251         (packet_check_result): New overload.
1252         Update all uses.
1253
1254 2019-01-14  Tom Tromey  <tom@tromey.com>
1255
1256         * remote-notif.c (handle_notification, remote_notif_ack)
1257         (remote_notif_parse): Make "buf" const.
1258         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1259         const.
1260         (remote_notif_parse, remote_notif_ack, handle_notification):
1261         Likewise.
1262         * remote.c (remote_notif_stop_parse): Make "buf" const.
1263         (remote_target::remote_parse_stop_reply): Make "buf" const.
1264         (remote_notif_stop_ack): Make "buf" const.
1265
1266 2019-01-14  Tom Tromey  <tom@tromey.com>
1267
1268         * remote.c (remote_console_output): Make parameter const.
1269
1270 2019-01-14  Tom Tromey  <tom@tromey.com>
1271
1272         * target-debug.h (target_debug_print_signals): Constify.
1273         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1274         * procfs.c (procfs_target::pass_signals): Update.
1275         * linux-nat.c (linux_nat_target::pass_signals): Update.
1276         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1277         * target-delegates.c: Rebuild.
1278         * remote.c (remote_target::program_signals): Update.
1279         (remote_target::pass_signals): Update.
1280         * target.c (target_pass_signals): Constify argument.
1281         (target_program_signals): Likewise.
1282         * target.h (struct target_ops) <pass_signals, program_signals>:
1283         Constify argument.
1284         (target_pass_signals, target_program_signals): Constify argument.
1285
1286 2019-01-14  Tom Tromey  <tom@tromey.com>
1287
1288         PR tui/28819:
1289         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1290
1291 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1292
1293         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1294         field.
1295         * rs6000-tdep.c: Include reggroups.h.
1296         (IS_V_ALIAS_PSEUDOREG): Define.
1297         (rs6000_register_name): Return names for the "vX" aliases.
1298         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1299         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1300         aliases.  Call default_register_reggroup_p for all other
1301         pseudo-registers.
1302         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1303         New functions.
1304         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1305         Handle "vX" aliases.
1306         (v_alias_pseudo_register_collect): New function.
1307         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1308         (rs6000_gdbarch_init): Initialize "vX" aliases as
1309         pseudo-registers.  Restore registration of
1310         rs6000_pseudo_register_reggroup_p with
1311         set_tdesc_pseudo_register_reggroup_p.
1312
1313 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1314
1315         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1316         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1317         set_gdbarch_num_pseudo_regs.
1318
1319 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1320
1321         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1322         Remove arg prefixname, add do_set and do_show.
1323         Add member functions set_list and show_list.
1324         * cli/cli-style.c (class cli_style_option): Update accordingly.
1325         (style_set_list): Move to file scope.
1326         (style_show_list): Likewise.
1327         (set_style): Call help_list.
1328         (show_style): Call cmd_show_list.
1329         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1330         Update to use the new macro.
1331
1332 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1333
1334         * ada-lang.c (_initialize_ada_language): Expand the help text
1335         for the "catch exception" command.
1336
1337 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1338
1339         * symtab.c (matching_obj_sections): Initialize obj,
1340         declare it closer to its usage.
1341
1342 2019-01-10  Tom Tromey  <tom@tromey.com>
1343
1344         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1345         (basic_inf_threads_range): Remove.
1346         (inf_threads_range, inf_non_exited_threads_range)
1347         (safe_inf_threads_range): Use next_adapter.
1348
1349 2019-01-10  Keith Seitz  <keiths@redhat.com>
1350
1351         PR gdb/23712
1352         PR symtab/23010
1353         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1354         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1355
1356 2019-01-10  Keith Seitz  <keiths@redhat.com>
1357
1358         PR gdb/23712
1359         PR symtab/23010
1360         * dictionary.c (pending_to_vector): Remove.
1361         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1362         Remove _1 suffix, replacing functions of the same name.  Update
1363         all callers.
1364         (dict_create_hashed, dict_create_hashed_expandable)
1365         (dict_create_linear, dict_create_linear_expandable, dict_free)
1366         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1367         Make functions static.
1368
1369 2019-01-10  Keith Seitz  <keiths@redhat.com>
1370
1371         PR gdb/23712
1372         PR symtab/23010
1373         * dictionary.h (struct dictionary): Replace declaration with
1374         multidictionary.
1375         (dict_create_hashed, dict_create_hashed_expandable)
1376         (dict_create_linear, dict_create_linear_expandable)
1377         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1378         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1379         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1380         taking multidictionary argument.
1381         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1382         * block.h (struct block) <dict>: Change to multidictionary
1383         and rename `multidict'.
1384         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1385         symmisc.c: Update all dictionary references to multidictionary.
1386
1387 2019-01-10  Keith Seitz  <keiths@redhat.com>
1388
1389         PR gdb/23712
1390         PR symtab/23010
1391         * dictionary.c: Include unordered_map.
1392         (pending_to_vector): New function.
1393         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1394         Rewrite the non-"_1" functions to take vector instead
1395         of linked list.
1396         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1397         "new" _1 versions of the same name.
1398         (multidictionary): Define.
1399         (std::hash<enum language): New definition.
1400         (collate_pending_symbols_by_language, mdict_create_hashed)
1401         (mdict_create_hashed_expandable, mdict_create_linear)
1402         (mdict_create_linear_expandable, mdict_free)
1403         (find_language_dictionary, create_new_language_dictionary)
1404         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1405         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1406         (mdict_size, mdict_empty): New functions.
1407         * dictionary.h (mdict_iterator): Define.
1408
1409 2019-01-10  Pedro Alves  <palves@redhat.com>
1410
1411         * breakpoint.c (read_uploaded_action)
1412         (create_tracepoint_from_upload): Adjust to use
1413         gdb::unique_xmalloc_ptr.
1414         * ctf.c (ctf_write_uploaded_tp):
1415         (SET_ARRAY_FIELD): Use emplace_back.
1416         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1417         * tracefile-tfile.c (tfile_write_uploaded_tp):
1418         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1419         gdb::unique_xmalloc_ptr.
1420         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1421         at_string, cond_string, cmd_strings>: Replace char pointers
1422         with gdb::unique_xmalloc_ptr.
1423
1424 2019-01-10  Pedro Alves  <palves@redhat.com>
1425
1426         * solib-target.c (library_list_start_library): Don't xstrdup name.
1427
1428 2019-01-10  Pedro Alves  <palves@redhat.com>
1429
1430         * mdebugread.c (parse_partial_symbols): Use
1431         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1432
1433 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1434
1435         * linux-fork.c (scoped_switch_fork_info)
1436         <~scoped_switch_fork_info>: Fix incorrect variable name.
1437
1438 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1439
1440         * linux-fork.c (scoped_switch_fork_info)
1441         <scoped_switch_fork_info>: Make explicit.
1442         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1443
1444 2019-01-10  Tom Tromey  <tom@tromey.com>
1445
1446         * objfiles.h (objfile::reset_psymtabs): Update.
1447         * objfiles.c (objfile::objfile): Update.
1448         * psymtab.h (psymtab_storage::obstack): Update.
1449         (psymtab_storage::m_obstack): Use gdb::optional.
1450         (class psymtab_storage): Update comment.  Remove objfile
1451         parameter.
1452         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1453
1454 2019-01-10  Tom Tromey  <tom@tromey.com>
1455
1456         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1457         <free_psymtabs>: Now private.
1458         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1459         (allocate_psymtab): Use new method.
1460
1461 2019-01-10  Tom Tromey  <tom@tromey.com>
1462
1463         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1464         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1465         * mdebugread.c (parse_partial_symbols): Use
1466         allocate_dependencies.
1467         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1468         allocate_dependencies.
1469         (process_psymtab_comp_unit_reader)
1470         (build_type_psymtab_dependencies): Likewise.
1471         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1472
1473 2019-01-10  Tom Tromey  <tom@tromey.com>
1474
1475         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1476         PSYMBOL_SET_LANGUAGE.
1477         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1478
1479 2019-01-10  Tom Tromey  <tom@tromey.com>
1480
1481         * psymtab.h (psymtab_storage::obstack): New method.
1482         <m_obstack>: Rename from obstack; now private.
1483         * psymtab.c (psymtab_storage): Update.
1484         * dwarf2read.c (create_addrmap_from_index)
1485         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1486         Update.
1487
1488 2019-01-10  Tom Tromey  <tom@tromey.com>
1489
1490         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1491         * objfiles.h (objfile::reset_psymtabs): New method.
1492
1493 2019-01-10  Tom Tromey  <tom@tromey.com>
1494
1495         * symmisc.c (print_symbol_bcache_statistics): Update.
1496         (print_objfile_statistics): Update.
1497         * symfile.c (reread_symbols): Update.
1498         * psymtab.h (class psymtab_storage): New.
1499         * psymtab.c (psymtab_storage): New constructor.
1500         (~psymtab_storage): New destructor.
1501         (require_partial_symbols): Update.
1502         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1503         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1504         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1505         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1506         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1507         (start_psymtab_common, end_psymtab_common)
1508         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1509         (allocate_psymtab): Update.
1510         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1511         Update.
1512         (dump_psymtab_addrmap, maintenance_print_psymbols)
1513         (maintenance_check_psymtabs): Update.
1514         (class objfile_psymtabs): Move to objfiles.h.
1515         * psympriv.h (discard_psymtab): Now inline.
1516         (psymtab_discarder::psymtab_discarder): Update.
1517         (psymtab_discarder::~psymtab_discarder): Update.
1518         (ALL_OBJFILE_PSYMTABS): Rewrite.
1519         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1520         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1521         Remove fields.
1522         <partial_symtabs>: New field.
1523         (class objfile_psymtabs): Move from psymtab.h.  Update.
1524         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1525         psymbol_cache.
1526         (objfile::~objfile): Don't destroy psymbol_cache.
1527         * mdebugread.c (parse_partial_symbols): Update.
1528         * dwarf2read.c (create_addrmap_from_index)
1529         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1530         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1531         (add_partial_subprogram, dwarf2_ranges_read): Update.
1532         * dwarf-index-write.c (write_address_map)
1533         (write_one_signatured_type, recursively_write_psymbols)
1534         (class debug_names, class debug_names, write_psymtabs_to_index):
1535         Update.
1536
1537 2019-01-10  Tom Tromey  <tom@tromey.com>
1538
1539         * symtab.h (SYMBOL_SET_NAMES): Update.
1540         (symbol_set_names): Update.
1541         (MSYMBOL_SET_NAMES): Update.
1542         * symtab.c (symbol_set_names): Change argument to be an
1543         objfile_per_bfd_storage.
1544         * psymtab.c (add_psymbol_to_bcache): Update.
1545         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1546
1547 2019-01-10  Tom Tromey  <tom@tromey.com>
1548
1549         * symtab.c (create_demangled_names_hash): Change argument to be an
1550         objfile_per_bfd_storage.
1551         (symbol_set_names): Update.
1552
1553 2019-01-10  Tom Tromey  <tom@tromey.com>
1554
1555         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1556         init_psymbol_list.
1557         * psymtab.c (init_psymbol_list): Do nothing if already called.
1558         * psympriv.h (init_psymbol_list): Add comment.
1559         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1560         init_psymbol_list.
1561         * dbxread.c (dbx_symfile_read): Unconditionally call
1562         init_psymbol_list.
1563
1564 2019-01-10  Tom Tromey  <tom@tromey.com>
1565
1566         * xcoffread.c (scan_xcoff_symtab): Update.
1567         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1568         "where".
1569         * mdebugread.c (parse_partial_symbols)
1570         (handle_psymbol_enumerators): Update.
1571         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1572         * dbxread.c (read_dbx_symtab): Update.
1573         * psympriv.h (psymbol_placement): New enum.
1574         (add_psymbol_to_list): Update.
1575
1576 2019-01-10  Tom Tromey  <tom@tromey.com>
1577
1578         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1579         static_psymbols parameters.
1580         (scan_xcoff_symtab): Update.
1581         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1582         static_psymbols parameters.
1583         * psympriv.h (start_psymtab_common): Update.
1584         * mdebugread.c (parse_partial_symbols): Update.
1585         * dwarf2read.c (create_partial_symtab): Update.
1586         * dbxread.c (read_dbx_symtab): Update.
1587         (start_psymtab): Remove global_psymbols and static_psymbols
1588         parameters.
1589
1590 2019-01-10  Tom Tromey  <tom@tromey.com>
1591
1592         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1593         * psymtab.c (allocate_psymtab): Add comment.
1594         * psympriv.h (allocate_psymtab): Add comment.
1595         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1596         initializations.
1597         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1598
1599 2019-01-10  Tom Tromey  <tom@tromey.com>
1600
1601         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1602         Don't declare.
1603         * mipsread.c: Include mdebugread.h.
1604         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1605         Declare.
1606         * elfread.c: Include mdebugread.h.
1607
1608 2019-01-09  Tom Tromey  <tom@tromey.com>
1609
1610         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1611         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1612         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1613         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1614         (psym_lookup_symbol, psym_find_last_source_symtab)
1615         (psym_forget_cached_source_info, psym_print_stats)
1616         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1617         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1618         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1619         (psym_find_compunit_symtab_by_address)
1620         (maintenance_print_psymbols, maintenance_info_psymtabs)
1621         (maintenance_check_psymtabs): Use ranged for.
1622         * psymtab.h (class objfile_psymtabs): New.
1623         (require_partial_symbols): Return objfile_psymtabs.
1624         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1625
1626 2019-01-09  Tom Tromey  <tom@tromey.com>
1627
1628         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1629         (find_pc_mapped_section, list_overlays_command)
1630         (map_overlay_command, unmap_overlay_command)
1631         (simple_overlay_update): Use all_objfiles.
1632         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1633         * printcmd.c (info_symbol_command): Use all_objfiles.
1634         * objfiles.h (ALL_OBJSECTIONS): Remove.
1635         * maint.c (maintenance_translate_address): Use all_objfiles.
1636         * gcore.c (gcore_create_callback): Use all_objfiles.
1637         (objfile_find_memory_regions): Likewise.
1638
1639 2019-01-09  Tom Tromey  <tom@tromey.com>
1640
1641         * symtab.c (find_line_symtab, info_sources_command)
1642         (make_source_files_completion_list): Use objfile_compunits.
1643         * source.c (select_source_symtab): Use objfile_compunits.
1644         * objfiles.h (struct objfile): Update comment.
1645         (ALL_OBJFILES): Remove.
1646         (ALL_FILETABS): Remove.
1647         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1648         objfile_compunits.
1649
1650 2019-01-09  Tom Tromey  <tom@tromey.com>
1651
1652         * symmisc.c (print_objfile_statistics, dump_objfile)
1653         (maintenance_print_symbols): Use compunit_filetabs.
1654         * source.c (forget_cached_source_info_for_objfile): Use
1655         compunit_filetabs.
1656         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1657         (ALL_FILETABS): Use compunit_filetabs.
1658         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1659         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1660
1661 2019-01-09  Tom Tromey  <tom@tromey.com>
1662
1663         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1664         (compunit_filetabs): New.
1665         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1666         compunit_filetabs.
1667         (info_sources_command, make_source_files_completion_list): Remove
1668         declaration.
1669         * symmisc.c (print_objfile_statistics, dump_objfile)
1670         (maintenance_print_symbols): Remove declaration.
1671         (maintenance_info_symtabs): Use compunit_filetabs.
1672         (maintenance_info_line_tables): Likewise.
1673         * source.c (select_source_symtab): Change local variable name.
1674         (forget_cached_source_info_for_objfile): Remove declaration.
1675         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1676         * objfiles.c (objfile_relocate1): Remove declaration.
1677         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1678         declaration.
1679         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1680         * coffread.c (coff_symtab_read): Remove declaration.
1681         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1682         compunit_filetabs.
1683
1684 2019-01-09  Tom Tromey  <tom@tromey.com>
1685
1686         * symtab.c (lookup_objfile_from_block)
1687         (find_pc_sect_compunit_symtab, search_symbols)
1688         (default_collect_symbol_completion_matches_break_on): Use
1689         objfile_compunits.
1690         * objfiles.h (ALL_COMPUNITS): Remove.
1691         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1692         * cp-support.c (add_symbol_overload_list_qualified): Use
1693         objfile_compunits.
1694         * ada-lang.c (ada_collect_symbol_completion_matches)
1695         (ada_add_global_exceptions): Use objfile_compunits.
1696
1697 2019-01-09  Tom Tromey  <tom@tromey.com>
1698
1699         * source.c (select_source_symtab)
1700         (forget_cached_source_info_for_objfile): Remove declaration.
1701         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1702         declaration.
1703         * maint.c (count_symtabs_and_blocks): Remove declaration.
1704         * cp-support.c (add_symbol_overload_list_qualified): Remove
1705         declaration.
1706         * coffread.c (coff_symtab_read): Remove declaration.
1707         * symtab.c (lookup_symbol_in_objfile_symtabs)
1708         (basic_lookup_transparent_type_1): Use objfile_compunits.
1709         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1710         (info_sources_command, search_symbols)
1711         (default_collect_symbol_completion_matches_break_on)
1712         (make_source_files_completion_list): Remove declaration.
1713         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1714         (ada_collect_symbol_completion_matches)
1715         (ada_add_global_exceptions): Remove declaration.
1716         * linespec.c (iterate_over_all_matching_symtabs): Use
1717         objfile_compunits.
1718         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1719         (class objfile_compunits): New.
1720         (ALL_COMPUNITS): Use objfile_compunits.
1721         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1722         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1723         objfile_compunits.
1724         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1725
1726 2019-01-09  Tom Tromey  <tom@tromey.com>
1727
1728         * symtab.c (search_symbols)
1729         (default_collect_symbol_completion_matches_break_on): Use
1730         objfile_msymbols.
1731         * ada-lang.c (ada_lookup_simple_minsym)
1732         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1733         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1734         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1735         objfile_msymbols.
1736         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1737         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1738         * objc-lang.c (find_methods): Use objfile_msymbols.
1739         (info_selectors_command, info_classes_command): Likewise.
1740         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1741         * objfiles.h (class objfile_msymbols): New.
1742         (ALL_OBJFILE_MSYMBOLS): Remove.
1743         (ALL_MSYMBOLS): Remove.
1744
1745 2019-01-09  Tom Tromey  <tom@tromey.com>
1746
1747         * common/next-iterator.h (next_adapter): Add Iterator template
1748         parameter.
1749         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1750         (class all_objfiles_safe): New.
1751         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1752         * objfiles.c (put_objfile_before): Update comment.
1753         (add_separate_debug_objfile): Likewise.
1754         (free_all_objfiles): Use all_objfiles_safe.
1755         (objfile_purge_solibs): Likewise.
1756
1757 2019-01-09  Tom Tromey  <tom@tromey.com>
1758
1759         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1760         (expand_symtab_containing_pc, lookup_static_symbol)
1761         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1762         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1763         all_objfiles.
1764         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1765         * breakpoint.c (create_overlay_event_breakpoint)
1766         (create_longjmp_master_breakpoint)
1767         (create_std_terminate_master_breakpoint)
1768         (create_exception_master_breakpoint): Use all_objfiles.
1769         * linux-thread-db.c (try_thread_db_load_from_pdir)
1770         (has_libpthread): Use all_objfiles.
1771         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1772         * linespec.c (iterate_over_all_matching_symtabs)
1773         (search_minsyms_for_name): Use all_objfiles.
1774         * maint.c (maintenance_info_sections): Use all_objfiles.
1775         * main.c (captured_main_1): Use all_objfiles.
1776         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1777         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1778         * guile/scm-pretty-print.c
1779         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1780         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1781         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1782         (maintenance_print_msymbols): Use all_objfiles.
1783         * source.c (select_source_symtab): Use all_objfiles.
1784         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1785         * symfile.c (remove_symbol_file_command)
1786         (expand_symtabs_matching, map_symbol_filenames): Use
1787         all_objfiles.
1788         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1789         all_objfiles.
1790         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1791         * objc-lang.c (find_methods): Use all_objfiles.
1792         * objfiles.c (have_partial_symbols, have_full_symbols)
1793         (have_minimal_symbols, qsort_cmp)
1794         (default_iterate_over_objfiles_in_search_order): Use
1795         all_objfiles.
1796         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1797         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1798         (maintenance_check_psymtabs): Use all_objfiles.
1799         (ALL_PSYMTABS): Remove.
1800         * compile/compile-object-run.c (do_module_cleanup): Use
1801         all_objfiles.
1802         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1803         * cp-support.c (add_symbol_overload_list_qualified): Use
1804         all_objfiles.
1805         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1806         Use all_objfiles.
1807         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1808         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1809         all_objfiles.
1810         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1811         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1812         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1813         Uses all_objfiles.
1814         * solib.c (solib_read_symbols): Use all_objfiles
1815
1816 2019-01-09  Tom Tromey  <tom@tromey.com>
1817
1818         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1819         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1820         all_objfiles.
1821         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1822         * symmisc.c (print_symbol_bcache_statistics)
1823         (print_objfile_statistics, maintenance_print_objfiles)
1824         (maintenance_info_symtabs, maintenance_check_symtabs)
1825         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1826         all_objfiles.
1827         * source.c (forget_cached_source_info): Use all_objfiles.
1828         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1829         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1830         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1831         * objfiles.c (update_section_map): Use all_objfiles.
1832         (shared_objfile_contains_address_p): Likewise.
1833         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1834         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1835
1836 2019-01-09  Tom Tromey  <tom@tromey.com>
1837
1838         * common/next-iterator.h: New file.
1839         * objfiles.h (class all_objfiles): New.
1840         (struct objfile_iterator): New.
1841
1842 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1843
1844         * NEWS: Move the description of the changed "frame", "select-frame",
1845          and "info frame" commands to the Changed commands section.
1846
1847 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1848
1849         * gdbtypes.c (check_stub_method_group): Remove handling of old
1850         mangling schemes.
1851         * linespec.c (find_methods): Likewise.
1852         * stabsread.c (read_member_functions): Likewise.
1853         * valops.c (search_struct_method): Likewise.
1854         (value_struct_elt_for_reference): Likewise.
1855         * NEWS: Mention this change.
1856
1857 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1858
1859         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1860         print_source_lines.
1861         * source.c (print_source_lines_base): Update line number check.
1862         (print_source_lines): New function.
1863         (source_lines_range::source_lines_range): New function.
1864         * source.h (class source_lines_range): New class.
1865         (print_source_lines): New declaration.
1866
1867 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1868
1869         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1870
1871 2019-01-08  Tom Tromey  <tom@tromey.com>
1872             Simon Marchi  <simon.marchi@ericsson.com>
1873
1874         PR gdb/24060
1875         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1876         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1877         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1878         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1879         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1880         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1881
1882 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1883
1884         * source.c (select_source_symtab): Move header comment to
1885         declaration in source.h.
1886         (forget_cached_source_info_for_objfile): Likewise.
1887         (forget_cached_source_info): Likewise.
1888         (identify_source_line): Likewise.
1889         * source.h (identify_source_line): Move declaration from symtab.h
1890         and add comment from source.c
1891         (print_source_lines): Likewise.
1892         (forget_cached_source_info_for_objfile): Likewise.
1893         (forget_cached_source_info): Likewise.
1894         (select_source_symtab): Likewise.
1895         (enum print_source_lines_flag): Move definition from symtab.h.
1896         * symtab.h (identify_source_line): Move declaration to source.h.
1897         (print_source_lines): Likewise.
1898         (forget_cached_source_info_for_objfile): Likewise.
1899         (forget_cached_source_info): Likewise.
1900         (select_source_symtab): Likewise.
1901         (enum print_source_lines_flag): Move definition to source.h.
1902         * tui/tui-hooks.c: Add 'source.h' include.
1903
1904 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1905
1906         * source.c (print_source_lines_base): Handle requests to print
1907         reverse line number sequences, and guard against empty lines
1908         string.
1909
1910 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1911
1912         * source.c (print_source_lines_base): Fix skip of '\r' if next
1913         character is '\n'.
1914
1915 2019-01-06  Tom Tromey  <tom@tromey.com>
1916
1917         * c-exp.y (struct c_parse_state) <macro_original_text,
1918         expansion_obstack>: New member.
1919         (macro_original_text, expansion_obstack): Remove globals.
1920         (scan_macro_expansion, scanning_macro_expansion)
1921         (finished_macro_expansion): Update.
1922         (scan_macro_cleanup): Remove.
1923         (yylex, c_parse): Update.
1924
1925 2019-01-06  Tom Tromey  <tom@tromey.com>
1926
1927         * c-exp.y (struct c_parse_state) <strings>: New member.
1928         (operator_stoken): Update.
1929
1930 2019-01-06  Tom Tromey  <tom@tromey.com>
1931
1932         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1933         (union type_stack_elt) <typelist_val>: Now a pointer to
1934         std::vector.
1935         (type_stack_cleanup): Don't declare.
1936         (push_typelist): Update.
1937         * parse.c (pop_typelist): Return a std::vector.
1938         (push_typelist): Take a std::vector.
1939         (follow_types): Update.  Do not free args.
1940         (type_stack_cleanup): Remove.
1941         * c-exp.y (struct c_parse_state): New.
1942         (cpstate): New global.
1943         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1944         (nonempty_typelist): Update.
1945         (func_mod): Create a new vector.
1946         (c_parse): Create a c_parse_state.
1947         (check_parameter_typelist): Do not delete params.
1948         (function_method): Update.  Do not delete type_list.
1949
1950 2019-01-06  Tom Tromey  <tom@tromey.com>
1951
1952         PR gdb/28155:
1953         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1954         check_typedef.
1955         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1956         (print_return_value): Likewise.
1957
1958 2019-01-05  Tom Tromey  <tom@tromey.com>
1959
1960         * contrib/cleanup_check.py: Remove.
1961         * contrib/gcc-with-excheck: Remove.
1962         * contrib/exsummary.py: Remove.
1963         * contrib/excheck.py: Remove.
1964
1965 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1966
1967         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1968         NULL. Initialize tpprev to NULL instead of assigning it
1969         to NULL on the next statement.
1970         * windows-nat.c (windows_delete_thread): Remove check for
1971         main_thread_id before printing thread exit notifications.
1972         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1973         Remove thread ID check against main_thread_id.
1974         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1975         windows_delete_thread.
1976         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1977
1978 2019-01-04  Tom Tromey  <tom@tromey.com>
1979
1980         * compile/compile.c (_initialize_compile): Use upper case for
1981         metasyntactic variables.
1982         * symmisc.c (_initialize_symmisc): Use upper case for
1983         metasyntactic variables.
1984         * psymtab.c (_initialize_psymtab): Use upper case for
1985         metasyntactic variables.
1986         * demangle.c (demangle_command): Use upper case for metasyntactic
1987         variables.
1988         (_initialize_demangler): Likewise.
1989         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1990         variables.
1991
1992 2019-01-03  Tom Tromey  <tom@tromey.com>
1993
1994         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1995
1996 2019-01-03  Tom Tromey  <tom@tromey.com>
1997
1998         * python/py-symtab.c (salpy_str): Update.
1999         (struct salpy_sal_object) <symtab>: Now a PyObject.
2000         (salpy_dealloc): Update.
2001         (del_objfile_sal): Use gdbpy_ref.
2002
2003 2019-01-03  Tom Tromey  <tom@tromey.com>
2004
2005         * python/py-type.c (convert_field): Use new_reference.  Return
2006         gdbpy_ref.
2007         (make_fielditem): Return gdbpy_ref.
2008         (typy_fields): Update.
2009         (typy_getitem): Update.
2010         (field_name): Return gdbpy_ref.  Use new_reference.
2011         (typy_iterator_iternext): Update.
2012
2013 2019-01-03  Tom Tromey  <tom@tromey.com>
2014
2015         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2016
2017 2019-01-03  Tom Tromey  <tom@tromey.com>
2018
2019         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2020         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2021         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2022         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2023         (pspy_set_type_printers): Likewise.
2024         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2025         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2026         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2027         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2028         (objfpy_set_type_printers): Likewise.
2029
2030 2019-01-03  Tom Tromey  <tom@tromey.com>
2031
2032         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2033         (gdbpy_print_stack): Use gdbpy_err_fetch.
2034         * python/python-internal.h (class gdbpy_err_fetch): New class.
2035         (class gdbpy_enter) <m_error_type, m_error_value,
2036         m_error_traceback>: Remove.
2037         <m_error>: New member.
2038         (gdbpy_exception_to_string): Don't declare.
2039         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2040         * python/py-value.c (convert_value_from_python): Use
2041         gdbpy_err_fetch.
2042         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2043         gdbpy_exception_to_string.
2044         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2045         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2046         gdbpy_err_fetch.
2047
2048 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2049
2050         * linux-nat.c (delete_lwp_cleanup): Delete.
2051         (struct lwp_deleter): New struct.
2052         (lwp_info_up): New typedef.
2053         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2054         lwp_info_up.
2055
2056 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2057
2058         * linux-fork.c (class scoped_switch_fork_info): New class.
2059         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2060
2061 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2062
2063         * valops.c (find_overload_match): Remove use of null_cleanup, and
2064         calls to do_cleanups.
2065
2066 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2067
2068         * compile/compile-cplus-types.c
2069         (compile_cplus_instance::decl_name): Handle changes to
2070         cp_func_name.
2071         * cp-support.c (cp_func_name): Update header comment, update
2072         return type.
2073         * cp-support.h (cp_func_name): Update return type in declaration.
2074         * valops.c (find_overload_match): Move temp_func local to top
2075         level of function and change its type.  Use temp_func to hold and
2076         delete temporary string obtained from cp_func_name.
2077
2078 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2079
2080         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2081         gdb::char_vector, remove cleanup, and update uses of `msg`.
2082
2083 2019-01-03  Jim Wilson  <jimw@sifive.com>
2084
2085         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2086
2087 2019-01-02  Tom Tromey  <tom@tromey.com>
2088
2089         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2090         (tdesc_parse_xml): Remove cleanups.
2091         * target-descriptions.h (make_cleanup_free_target_description):
2092         Don't declare.
2093         (target_desc_deleter): New struct.
2094         (target_desc_up): New typedef.
2095         * target-descriptions.c (target_desc_deleter::operator()): Rename
2096         from free_target_description.
2097         (make_cleanup_free_target_description): Remove.
2098
2099 2019-01-02  Tom Tromey  <tom@tromey.com>
2100
2101         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2102         constructor, destructor.
2103         (linespec_parser): Remove typedef.
2104         (~linespec_parser): Rename from linespec_parser_delete.
2105         (linespec_lex_to_end, linespec_complete_label)
2106         (linespec_complete): Update.
2107         (decode_line_full): Remove cleanups.
2108         (decode_line_1): Update.
2109
2110 2019-01-02  Tom Tromey  <tom@tromey.com>
2111
2112         * python/python-internal.h (inferior_to_inferior_object): Change
2113         return type.
2114         * python/py-exitedevent.c (create_exited_event_object): Update.
2115         * python/py-inferior.c (inferior_to_inferior_object): Return
2116         gdbpy_ref.
2117         (python_new_inferior, python_inferior_deleted)
2118         (thread_to_thread_object, delete_thread_object)
2119         (build_inferior_list, gdbpy_selected_inferior): Update.
2120         * python/py-infthread.c (create_thread_object): Update.  Also fail
2121         if inferior_to_inferior_object fails.
2122
2123 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2124
2125         * inferior.h (class inferior) <displaced_step_state>: New field.
2126         * infrun.h (struct displaced_step_state): Move here from
2127         infrun.c.  Initialize fields, add constructor.
2128         <inf>: Remove field.
2129         <reset>: New method.
2130         * infrun.c (struct displaced_step_inferior_state): Move to
2131         infrun.h.
2132         (displaced_step_inferior_states): Remove.
2133         (get_displaced_stepping_state): Adust.
2134         (displaced_step_in_progress_any_inferior): Adjust.
2135         (displaced_step_in_progress_thread): Adjust.
2136         (displaced_step_in_progress): Adjust.
2137         (add_displaced_stepping_state): Remove.
2138         (get_displaced_step_closure_by_addr): Adjust.
2139         (remove_displaced_stepping_state): Remove.
2140         (infrun_inferior_exit): Call displaced_step_state.reset.
2141         (use_displaced_stepping): Don't check for NULL.
2142         (displaced_step_prepare_throw): Call
2143         get_displaced_stepping_state.
2144         (displaced_step_fixup): Don't check for NULL.
2145         (prepare_for_detach): Don't check for NULL.
2146
2147 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2148
2149         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2150          in case of call that did not complete.
2151
2152 2019-01-02  Andrey Utkin  <autkin@undo.io>
2153
2154         * symfile.c (find_separate_debug_file): Fix search of debug files for
2155         remote debuggee.
2156
2157 2019-01-02  Tom Tromey  <tom@tromey.com>
2158
2159         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2160         indentation.
2161         * python/py-frame.c (frapy_older): Remove cast.
2162         (frapy_newer): Likewise.
2163         * python/py-breakpoint.c (local_setattro): Remove cast.
2164         * python/py-arch.c (archpy_name): Remove local variable.
2165         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2166
2167 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2168
2169         * unittests/basic_string_view/element_access/char/empty.cc:
2170         Fix year range in copyright header.
2171
2172 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2173
2174         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2175         Delete.
2176         <operator==>: Update with for removed field.
2177         <hash>: Likewise.
2178         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2179         <isa_features>: ...this.
2180         <abi_features>: New field.
2181         (riscv_isa_flen): Update comment.
2182         (riscv_abi_xlen): New declaration.
2183         (riscv_abi_flen): New declaration.
2184         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2185         isa_features.
2186         (riscv_abi_xlen): New function.
2187         (riscv_isa_flen): Update to get answer from isa_features.
2188         (riscv_abi_flen): New function.
2189         (riscv_has_fp_abi): Update to get answer from abi_features.
2190         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2191         xlen and flen.
2192         (riscv_call_info) <xlen, flen>: Update comment.
2193         (riscv_call_arg_struct): Remove invalid assertions
2194         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2195         is removed.
2196         (riscv_gdbarch_init): Gather isa features and abi features
2197         separately, ensure both match on the gdbarch when reusing an old
2198         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2199         a target with 64-bit float hardware.
2200
2201 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2202
2203         * source.c (search_command_helper): Stop reverse search
2204         when line 1 has been searched.
2205
2206 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2207
2208         * record-full.c (record_full_base_target::close): Rewrite
2209         record_full_core_buf_list free logic.
2210
2211 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2212
2213         * break-catch-syscall.c (print_one_catch_syscall): xfree
2214         the last text.
2215
2216 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2217
2218         * top.c (print_gdb_version): Update Copyright year in version
2219         message.
2220
2221 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2222
2223         Update copyright year range in all GDB files.
2224
2225 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2226
2227         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2228
2229 For older changes see ChangeLog-2018.
2230 \f
2231 Local Variables:
2232 mode: change-log
2233 left-margin: 8
2234 fill-column: 74
2235 version-control: never
2236 coding: utf-8
2237 End:
2238