gdb/ChangeLog

   1 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
   4         (alpha_unwind_pc): Delete.
   5         (alpha_gdbarch_init): Don't register deleted functions with
   6         gdbarch.
   7
   8 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
   9
  10         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
  11         (aarch64_unwind_pc): Delete.
  12         (aarch64_unwind_sp): Delete.
  13         (aarch64_gdbarch_init): Don't register deleted functions with
  14         gdbarch.
  15
  16 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  17
  18         * gdbtypes.c (type_align): Don't consider static members when
  19         computing structure alignment.
  20
  21 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  22
  23         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
  24         return 0 for other types.
  25         * arch-utils.c (default_type_align): Always return 0.
  26         * gdbarch.h: Regenerate.
  27         * gdbarch.sh (type_align): Extend comment.
  28         * gdbtypes.c (type_align): Add additional comments, always call
  29         gdbarch_type_align before applying the default rules.
  30         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
  31         generic code will then apply a suitable default.
  32         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
  33         types, return 0 for other types.
  34
  35 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  36
  37         * NEWS: Create a new section for the next release branch.
  38         Rename the section of the current branch, now that it has
  39         been cut.
  40
  41 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  42
  43         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
  44         * version.in: Bump version to 8.3.50.DATE-git.
  45
  46 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
  47
  48         * aix-thread.c (ptid_cmp): Remove unused variable.
  49         (get_signaled_thread): Likewise.
  50         (store_regs_user_thread): Likewise.
  51         (store_regs_kernel_thread): Likewise.
  52         (fetch_regs_kernel_thread): Remove shadowed variable.
  53
  54 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  55
  56         * features/riscv/32bit-cpu.xml: Add register numbers.
  57         * features/riscv/32bit-fpu.c: Regenerate.
  58         * features/riscv/32bit-fpu.xml: Add register numbers.
  59         * features/riscv/64bit-cpu.xml: Add register numbers.
  60         * features/riscv/64bit-fpu.c: Regenerate.
  61         * features/riscv/64bit-fpu.xml: Add register numbers.
  62
  63 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
  64
  65         * NEWS: Mention two argument form of gdb.Value constructor.
  66         * python/py-value.c (convert_buffer_and_type_to_value): New
  67         function.
  68         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
  69         Add support for handling an optional second argument.  Call
  70         convert_buffer_and_type_to_value as appropriate.
  71         * python/python-internal.h (Py_buffer_deleter): New struct.
  72         (Py_buffer_up): New typedef.
  73
  74 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
  75
  76         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
  77         instead of releasing ownership.
  78
  79 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
  80
  81         * dwarf2read.c (open_and_init_dwp_file): Call
  82         elf_numsections instead of bfd_count_sections to initialize
  83         dwp_file->num_sections.
  84
  85 2019-02-25  Tom Tromey  <tromey@adacore.com>
  86
  87         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
  88
  89 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  90
  91         * gcore.in: Add '--readnever' option when invoking GDB.
  92
  93 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  94
  95         * MAINTAINERS: Update my email address.
  96
  97 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  98
  99         * build-id.c (build_id_to_debug_bfd_1): New function.
 100         (build_id_to_debug_bfd): Look for separate debug file in
 101         sysroot.
 102
 103 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 104
 105         * gdbarch.sh: Update the copyright year range that is placed into
 106         generated files.
 107
 108 2019-02-22  Keith Seitz  <keiths@redhat.com>
 109
 110         PR symtab/23853
 111         * linespec.c (create_sals_line_offset): Search for the default
 112         symtab's filename instead of its fullname.
 113
 114 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 115
 116         * NEWS: Update style defaults.
 117
 118 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 119
 120         * main.c (captured_main_1): Disable styling in batch mode.
 121
 122 2019-02-20  Tom Tromey  <tom@tromey.com>
 123
 124         * symtab.c (symtab_symbol_info): Fix typos.
 125
 126 2019-02-20  Tom Tromey  <tromey@adacore.com>
 127
 128         * findcmd.c (_initialize_mem_search): Use upper case for
 129         metasyntactic variables.
 130
 131 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 132
 133         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 134         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 135
 136 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 137
 138         * top.h (source_file_name): Change to std::string.
 139         * top.c (source_file_name): Likewise.
 140         (command_line_input): Adjust.
 141         * cli/cli-script.c (script_from_file): Adjust.
 142
 143 2019-02-19  Tom Tromey  <tromey@adacore.com>
 144
 145         * ravenscar-thread.c
 146         (ravenscar_thread_target::update_thread_list): Don't call
 147         ada_build_task_list.
 148         * ada-lang.h (ada_build_task_list): Don't declare.
 149         * ada-tasks.c (struct ada_tasks_inferior_data)
 150         <task_list_valid_p>: Now bool.
 151         (read_known_tasks, ada_task_list_changed)
 152         (ada_tasks_invalidate_inferior_data): Update.
 153         (read_known_tasks_array): Return bool.
 154         (read_known_tasks_list): Likewise.
 155         (read_known_tasks): Return void.
 156         (ada_build_task_list): Now static.
 157
 158 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 159
 160         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 161         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 162
 163 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 164
 165         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 166         variant for ada_tasks_pspace_data_handle and
 167         ada_tasks_inferior_data_handle.
 168         (ada_tasks_pspace_data_cleanup): New function.
 169         (ada_tasks_inferior_data_cleanup): New function.
 170
 171 2019-02-17  Tom Tromey  <tom@tromey.com>
 172
 173         * macrotab.h (macro_source_fullname): Return a std::string.
 174         * macrotab.c (macro_include, check_for_redefinition)
 175         (macro_undef, macro_lookup_definition, foreach_macro)
 176         (foreach_macro_in_scope): Update.
 177         (macro_source_fullname): Return a std::string.
 178         * macrocmd.c (show_pp_source_pos): Update.
 179
 180 2019-02-17  Tom Tromey  <tom@tromey.com>
 181
 182         * macrocmd.c (show_pp_source_pos): Style the file names.
 183
 184 2019-02-17  Tom Tromey  <tom@tromey.com>
 185
 186         PR tui/24197:
 187         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 188
 189 2019-02-17  Tom Tromey  <tom@tromey.com>
 190
 191         * ada-lang.c (user_select_syms): Use filtered printing.
 192         * utils.c (wrap_style): New global.
 193         (desired_style): Remove.
 194         (emit_style_escape): Add stream parameter.
 195         (set_output_style, reset_terminal_style, prompt_for_continue):
 196         Update.
 197         (flush_wrap_buffer): Only flush gdb_stdout.
 198         (wrap_here): Set wrap_style.
 199         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 200         treat escape sequences as a character.  Change when wrap buffer is
 201         flushed.
 202         (fputs_styled): Do not set the output style when the default is
 203         requested.
 204         * ui-style.h (struct ui_file_style) <is_default>: New method.
 205         * source.c (print_source_lines_base): Emit escape sequences in one
 206         piece.
 207
 208 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 209
 210         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 211         integers and enumeration types.
 212
 213 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 214
 215         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 216         instead of lookup_symbol_in_language
 217         (do_exact_match): New function.
 218         (ada_get_symbol_name_matcher): Return do_exact_match when
 219         doing a verbatim match.
 220
 221 2019-02-15  Tom Tromey  <tromey@adacore.com>
 222
 223         * ravenscar-thread.c (ravenscar_thread_target::resume)
 224         (ravenscar_thread_target::wait): Special case wildcard requests.
 225
 226 2019-02-15  Tom Tromey  <tromey@adacore.com>
 227
 228         * ravenscar-thread.c (base_ptid): Remove.
 229         (struct ravenscar_thread_target) <close>: New method.
 230         <m_base_ptid>: New member.
 231         <update_inferior_ptid, active_task, task_is_currently_active,
 232         runtime_initialized>: Declare methods.
 233         <ravenscar_thread_target>: Add constructor.
 234         (ravenscar_thread_target::task_is_currently_active)
 235         (ravenscar_thread_target::update_inferior_ptid)
 236         (ravenscar_runtime_initialized): Rename.  Now methods.
 237         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 238         (ravenscar_thread_target::update_thread_list): Update.
 239         (ravenscar_thread_target::active_task): Now method.
 240         (ravenscar_thread_target::store_registers)
 241         (ravenscar_thread_target::prepare_to_store)
 242         (ravenscar_thread_target::prepare_to_store)
 243         (ravenscar_thread_target::mourn_inferior): Update.
 244         (ravenscar_inferior_created): Use "new" to create target.
 245         (ravenscar_thread_target::get_ada_task_ptid): Update.
 246         (_initialize_ravenscar): Don't initialize base_ptid.
 247         (ravenscar_ops): Remove global.
 248
 249 2019-02-15  Tom Tromey  <tromey@adacore.com>
 250
 251         * target.h (push_target): Declare new overload.
 252         * target.c (push_target): New overload, taking an rvalue reference.
 253         * remote.c (remote_target::open_1): Use push_target overload.
 254         * corelow.c (core_target_open): Use push_target overload.
 255
 256 2019-02-15  Tom Tromey  <tromey@adacore.com>
 257
 258         * ravenscar-thread.c (is_ravenscar_task)
 259         (ravenscar_task_is_currently_active): Return bool.
 260         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 261         (_initialize_ravenscar): Remove "(void)".
 262         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 263         Return bool.
 264
 265 2019-02-15  Tom Tromey  <tromey@adacore.com>
 266
 267         * ravenscar-thread.c (ravenscar_runtime_initializer)
 268         (has_ravenscar_runtime, get_running_thread_id)
 269         (ravenscar_thread_target::resume): Fix indentation.
 270
 271 2019-02-15  Tom Tromey  <tromey@adacore.com>
 272
 273         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 274         from ravenscar_arch_ops.
 275         (sparc_ravenscar_ops::fetch_registers)
 276         (sparc_ravenscar_ops::store_registers): Now methods.
 277         (sparc_ravenscar_prepare_to_store): Remove.
 278         (sparc_ravenscar_ops): Redefine.
 279         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 280         methods and destructor.  Remove members.
 281         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 282         (ravenscar_thread_target::store_registers)
 283         (ravenscar_thread_target::prepare_to_store): Update.
 284         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 285         Remove.
 286         (struct ppc_ravenscar_powerpc_ops): Derive from
 287         ravenscar_arch_ops.
 288         (ppc_ravenscar_powerpc_ops::fetch_registers)
 289         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 290         (ppc_ravenscar_powerpc_ops): Redefine.
 291         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 292         (ppc_ravenscar_e500_ops::fetch_registers)
 293         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 294         (ppc_ravenscar_e500_ops): Redefine.
 295         * aarch64-ravenscar-thread.c
 296         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 297         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 298         (aarch64_ravenscar_fetch_registers)
 299         (aarch64_ravenscar_store_registers): Now methods.
 300         (aarch64_ravenscar_ops): Redefine.
 301
 302 2019-02-15  Tom Tromey  <tromey@adacore.com>
 303
 304         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 305         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 306         (ravenscar_thread_target::stopped_by_watchpoint)
 307         (ravenscar_thread_target::stopped_data_address)
 308         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 309
 310 2019-02-15  Tom Tromey  <tromey@adacore.com>
 311
 312         * ravenscar-thread.c: Fix some typos.
 313
 314 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 315             Tom Tromey  <tromey@adacore.com>
 316
 317         * ada-lang.c (ada_exception_sal): Change addr_string to a
 318         std::string.
 319         (create_ada_exception_catchpoint): Update.
 320
 321 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 322             Tom Tromey  <tromey@adacore.com>
 323
 324         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 325         (bp_location_ops): Remove.
 326         (base_breakpoint_allocate_location): Update.
 327         (free_bp_location): Update.
 328         * ada-lang.c (class ada_catchpoint_location)
 329         <ada_catchpoint_location>: Remove ops parameter.
 330         (ada_catchpoint_location_dtor): Remove.
 331         (ada_catchpoint_location_ops): Remove.
 332         (allocate_location_exception): Update.
 333         * breakpoint.h (struct bp_location_ops): Remove.
 334         (class bp_location) <bp_location>: Remove bp_location_ops
 335         parameter.
 336         <~bp_location>: Add destructor.
 337         <ops>: Remove.
 338
 339 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 340             Pedro Alves  <palves@redhat.com>
 341
 342         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 343         'PATH_MAX'.
 344
 345 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 346             Samuel Thibault  <samuel.thibault@gnu.org>
 347             Thomas Schwinge  <thomas@codesourcery.com>
 348
 349         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 350         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 351
 352 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 353
 354         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 355         (check_empty): Use "const char *".
 356
 357         * gnu-nat.c (gnu_nat_target::detach): Instead of
 358         'detach_inferior (pid)' call
 359         'detach_inferior (find_inferior_pid (pid))'.
 360
 361         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 362         'nat/fork-inferior.o'.
 363         * gnu-nat.c: #include "nat/fork-inferior.h".
 364
 365         * gnu-nat.c (gnu_nat_target::detach): Instead of
 366         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 367         * gnu-nat.h: #include "inf-child.h".
 368         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 369         'i386_gnu_nat_target::fetch_registers'.
 370         (gnu_store_registers): Rename/move to
 371         'i386_gnu_nat_target::store_registers'.
 372
 373         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 374         * gnu-nat.h (mach_thread_info): New function.
 375         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 376
 377         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 378
 379 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 380
 381         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 382
 383 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 384
 385         * windows-nat.c (windows_add_thread): Add new parameter
 386         "main_thread_p" with default value set to false.  Update
 387         function documentation as well as all callers.
 388         (windows_delete_thread): Likewise.
 389         (fake_create_process): Update call to windows_add_thread.
 390         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 391         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 392         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 393         call to windows_delete_thread.
 394
 395 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 396
 397         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 398
 399 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 400
 401         * symfile.c (find_separate_debug_file): Use canonical path of
 402         sysroot with child_path instead of gdb_sysroot if it is valid.
 403
 404 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 405
 406         * symfile.c (find_separate_debug_file): Use child_path to
 407         determine if an object file is under a sysroot.
 408
 409 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 410
 411         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 412         unittests/child-path-selftests.c.
 413         * common/pathstuff.c (child_path): New function.
 414         * common/pathstuff.h (child_path): New prototype.
 415         * unittests/child-path-selftests.c: New file.
 416
 417 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 418
 419         * symfile.c (find_separate_debug_file): Look for separate debug
 420         files in debug directories under the sysroot.
 421
 422 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 423
 424         * symtab.h (struct minimal_symbol data_p): New const method.
 425         (struct minimal_symbol text_p): Likewise.
 426         * symtab.c (output_source_filename): Use file name style
 427         to print file name.
 428         (print_symbol_info): Likewise.
 429         (print_msymbol_info): Use address style to print addresses.
 430         Use function name style to print executable text symbols.
 431         (expand_symtab_containing_pc): Use data_p.
 432         (find_pc_sect_compunit_symtab): Likewise.
 433
 434 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 435
 436         * breakpoint.c (describe_other_breakpoints): Use address style
 437         to print addresses.
 438         (say_where): Likewise.
 439
 440 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 441
 442         * ada-typeprint.c (print_func_type): Print function name
 443         style to print function name.
 444         * c-typeprint.c (c_print_type_1): Likewise.
 445
 446 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 447
 448         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 449         for execve.
 450
 451 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 452
 453         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 454         type_stack.
 455
 456 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 457
 458         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 459         TYPE_CODE_REF types.
 460
 461 2019-02-08  Jim Wilson  <jimw@sifive.com>
 462
 463         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 464         (riscv_linux_fregset): New.
 465         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 466
 467 2019-02-07  Tom Tromey  <tom@tromey.com>
 468
 469         * thread.c (thread_cancel_execution_command): Update.
 470         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 471         methods.
 472         (struct thread_fsm_ops): Remove.
 473         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 474         (thread_fsm_should_stop, thread_fsm_return_value)
 475         (thread_fsm_set_finished, thread_fsm_finished_p)
 476         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 477         Don't declare.
 478         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 479         * infrun.c (clear_proceed_status_thread)
 480         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 481         (print_stop_event): Update.
 482         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 483         Add constructor.
 484         (step_command_fsm_ops): Remove.
 485         (new_step_command_fsm): Remove.
 486         (step_1): Update.
 487         (step_command_fsm::should_stop): Rename from
 488         step_command_fsm_should_stop.
 489         (step_command_fsm::clean_up): Rename from
 490         step_command_fsm_clean_up.
 491         (step_command_fsm::do_async_reply_reason): Rename from
 492         step_command_fsm_async_reply_reason.
 493         (struct until_next_fsm): Inherit from thread_fsm.  Add
 494         constructor.
 495         (until_next_fsm_ops): Remove.
 496         (new_until_next_fsm): Remove.
 497         (until_next_fsm::should_stop): Rename from
 498         until_next_fsm_should_stop.
 499         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 500         (until_next_fsm::do_async_reply_reason): Rename from
 501         until_next_fsm_async_reply_reason.
 502         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 503         constructor.  Change type of breakpoint.
 504         (finish_command_fsm_ops): Remove.
 505         (new_finish_command_fsm): Remove.
 506         (finish_command_fsm::should_stop): Rename from
 507         finish_command_fsm_should_stop.
 508         (finish_command_fsm::clean_up): Rename from
 509         finish_command_fsm_clean_up.
 510         (finish_command_fsm::return_value): Rename from
 511         finish_command_fsm_return_value.
 512         (finish_command_fsm::do_async_reply_reason): Rename from
 513         finish_command_fsm_async_reply_reason.
 514         (finish_command): Update.
 515         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 516         Add constructor.
 517         (call_thread_fsm_ops): Remove.
 518         (call_thread_fsm::call_thread_fsm): Rename from
 519         new_call_thread_fsm.
 520         (call_thread_fsm::should_stop): Rename from
 521         call_thread_fsm_should_stop.
 522         (call_thread_fsm::should_notify_stop): Rename from
 523         call_thread_fsm_should_notify_stop.
 524         (run_inferior_call, call_function_by_hand_dummy): Update.
 525         * cli/cli-interp.c (should_print_stop_to_console): Update.
 526         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 527         Add constructor.  Change type of location_breakpoint,
 528         caller_breakpoint.
 529         (until_break_fsm_ops): Remove.
 530         (new_until_break_fsm): Remove.
 531         (until_break_fsm::should_stop): Rename from
 532         until_break_fsm_should_stop.
 533         (until_break_fsm::clean_up): Rename from
 534         until_break_fsm_clean_up.
 535         (until_break_fsm::do_async_reply_reason): Rename from
 536         until_break_fsm_async_reply_reason.
 537         (until_break_command): Update.
 538         * thread-fsm.c: Remove.
 539         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 540
 541 2019-02-07  Tom Tromey  <tom@tromey.com>
 542
 543         * yy-remap.h: Add include guard.
 544         * xtensa-tdep.h: Add include guard.
 545         * xcoffread.h: Rename include guard.
 546         * varobj-iter.h: Add include guard.
 547         * tui/tui.h: Rename include guard.
 548         * tui/tui-winsource.h: Rename include guard.
 549         * tui/tui-wingeneral.h: Rename include guard.
 550         * tui/tui-windata.h: Rename include guard.
 551         * tui/tui-win.h: Rename include guard.
 552         * tui/tui-stack.h: Rename include guard.
 553         * tui/tui-source.h: Rename include guard.
 554         * tui/tui-regs.h: Rename include guard.
 555         * tui/tui-out.h: Rename include guard.
 556         * tui/tui-layout.h: Rename include guard.
 557         * tui/tui-io.h: Rename include guard.
 558         * tui/tui-hooks.h: Rename include guard.
 559         * tui/tui-file.h: Rename include guard.
 560         * tui/tui-disasm.h: Rename include guard.
 561         * tui/tui-data.h: Rename include guard.
 562         * tui/tui-command.h: Rename include guard.
 563         * tic6x-tdep.h: Add include guard.
 564         * target/waitstatus.h: Rename include guard.
 565         * target/wait.h: Rename include guard.
 566         * target/target.h: Rename include guard.
 567         * target/resume.h: Rename include guard.
 568         * target-float.h: Rename include guard.
 569         * stabsread.h: Add include guard.
 570         * rs6000-tdep.h: Add include guard.
 571         * riscv-fbsd-tdep.h: Add include guard.
 572         * regformats/regdef.h: Rename include guard.
 573         * record.h: Rename include guard.
 574         * python/python.h: Rename include guard.
 575         * python/python-internal.h: Rename include guard.
 576         * python/py-stopevent.h: Rename include guard.
 577         * python/py-ref.h: Rename include guard.
 578         * python/py-record.h: Rename include guard.
 579         * python/py-record-full.h: Rename include guard.
 580         * python/py-record-btrace.h: Rename include guard.
 581         * python/py-instruction.h: Rename include guard.
 582         * python/py-events.h: Rename include guard.
 583         * python/py-event.h: Rename include guard.
 584         * procfs.h: Add include guard.
 585         * proc-utils.h: Add include guard.
 586         * p-lang.h: Add include guard.
 587         * or1k-tdep.h: Rename include guard.
 588         * observable.h: Rename include guard.
 589         * nto-tdep.h: Rename include guard.
 590         * nat/x86-linux.h: Rename include guard.
 591         * nat/x86-linux-dregs.h: Rename include guard.
 592         * nat/x86-gcc-cpuid.h: Add include guard.
 593         * nat/x86-dregs.h: Rename include guard.
 594         * nat/x86-cpuid.h: Rename include guard.
 595         * nat/ppc-linux.h: Rename include guard.
 596         * nat/mips-linux-watch.h: Rename include guard.
 597         * nat/linux-waitpid.h: Rename include guard.
 598         * nat/linux-ptrace.h: Rename include guard.
 599         * nat/linux-procfs.h: Rename include guard.
 600         * nat/linux-osdata.h: Rename include guard.
 601         * nat/linux-nat.h: Rename include guard.
 602         * nat/linux-namespaces.h: Rename include guard.
 603         * nat/linux-btrace.h: Rename include guard.
 604         * nat/glibc_thread_db.h: Rename include guard.
 605         * nat/gdb_thread_db.h: Rename include guard.
 606         * nat/gdb_ptrace.h: Rename include guard.
 607         * nat/fork-inferior.h: Rename include guard.
 608         * nat/amd64-linux-siginfo.h: Rename include guard.
 609         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 610         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 611         * nat/aarch64-linux.h: Rename include guard.
 612         * nat/aarch64-linux-hw-point.h: Rename include guard.
 613         * mn10300-tdep.h: Add include guard.
 614         * mips-linux-tdep.h: Add include guard.
 615         * mi/mi-parse.h: Rename include guard.
 616         * mi/mi-out.h: Rename include guard.
 617         * mi/mi-main.h: Rename include guard.
 618         * mi/mi-interp.h: Rename include guard.
 619         * mi/mi-getopt.h: Rename include guard.
 620         * mi/mi-console.h: Rename include guard.
 621         * mi/mi-common.h: Rename include guard.
 622         * mi/mi-cmds.h: Rename include guard.
 623         * mi/mi-cmd-break.h: Rename include guard.
 624         * m2-lang.h: Add include guard.
 625         * location.h: Rename include guard.
 626         * linux-record.h: Rename include guard.
 627         * linux-nat.h: Add include guard.
 628         * linux-fork.h: Add include guard.
 629         * i386-darwin-tdep.h: Rename include guard.
 630         * hppa-linux-offsets.h: Add include guard.
 631         * guile/guile.h: Rename include guard.
 632         * guile/guile-internal.h: Rename include guard.
 633         * gnu-nat.h: Rename include guard.
 634         * gdb-stabs.h: Rename include guard.
 635         * frv-tdep.h: Add include guard.
 636         * f-lang.h: Add include guard.
 637         * event-loop.h: Add include guard.
 638         * darwin-nat.h: Rename include guard.
 639         * cp-abi.h: Rename include guard.
 640         * config/sparc/nm-sol2.h: Rename include guard.
 641         * config/nm-nto.h: Rename include guard.
 642         * config/nm-linux.h: Add include guard.
 643         * config/i386/nm-i386gnu.h: Rename include guard.
 644         * config/djgpp/nl_types.h: Rename include guard.
 645         * config/djgpp/langinfo.h: Rename include guard.
 646         * compile/gcc-cp-plugin.h: Add include guard.
 647         * compile/gcc-c-plugin.h: Add include guard.
 648         * compile/compile.h: Rename include guard.
 649         * compile/compile-object-run.h: Rename include guard.
 650         * compile/compile-object-load.h: Rename include guard.
 651         * compile/compile-internal.h: Rename include guard.
 652         * compile/compile-cplus.h: Rename include guard.
 653         * compile/compile-c.h: Rename include guard.
 654         * common/xml-utils.h: Rename include guard.
 655         * common/x86-xstate.h: Rename include guard.
 656         * common/version.h: Rename include guard.
 657         * common/vec.h: Rename include guard.
 658         * common/tdesc.h: Rename include guard.
 659         * common/selftest.h: Rename include guard.
 660         * common/scoped_restore.h: Rename include guard.
 661         * common/scoped_mmap.h: Rename include guard.
 662         * common/scoped_fd.h: Rename include guard.
 663         * common/safe-iterator.h: Rename include guard.
 664         * common/run-time-clock.h: Rename include guard.
 665         * common/refcounted-object.h: Rename include guard.
 666         * common/queue.h: Rename include guard.
 667         * common/ptid.h: Rename include guard.
 668         * common/print-utils.h: Rename include guard.
 669         * common/preprocessor.h: Rename include guard.
 670         * common/pathstuff.h: Rename include guard.
 671         * common/observable.h: Rename include guard.
 672         * common/netstuff.h: Rename include guard.
 673         * common/job-control.h: Rename include guard.
 674         * common/host-defs.h: Rename include guard.
 675         * common/gdb_wait.h: Rename include guard.
 676         * common/gdb_vecs.h: Rename include guard.
 677         * common/gdb_unlinker.h: Rename include guard.
 678         * common/gdb_unique_ptr.h: Rename include guard.
 679         * common/gdb_tilde_expand.h: Rename include guard.
 680         * common/gdb_sys_time.h: Rename include guard.
 681         * common/gdb_string_view.h: Rename include guard.
 682         * common/gdb_splay_tree.h: Rename include guard.
 683         * common/gdb_setjmp.h: Rename include guard.
 684         * common/gdb_ref_ptr.h: Rename include guard.
 685         * common/gdb_optional.h: Rename include guard.
 686         * common/gdb_locale.h: Rename include guard.
 687         * common/gdb_assert.h: Rename include guard.
 688         * common/filtered-iterator.h: Rename include guard.
 689         * common/filestuff.h: Rename include guard.
 690         * common/fileio.h: Rename include guard.
 691         * common/environ.h: Rename include guard.
 692         * common/common-utils.h: Rename include guard.
 693         * common/common-types.h: Rename include guard.
 694         * common/common-regcache.h: Rename include guard.
 695         * common/common-inferior.h: Rename include guard.
 696         * common/common-gdbthread.h: Rename include guard.
 697         * common/common-exceptions.h: Rename include guard.
 698         * common/common-defs.h: Rename include guard.
 699         * common/common-debug.h: Rename include guard.
 700         * common/cleanups.h: Rename include guard.
 701         * common/buffer.h: Rename include guard.
 702         * common/btrace-common.h: Rename include guard.
 703         * common/break-common.h: Rename include guard.
 704         * cli/cli-utils.h: Rename include guard.
 705         * cli/cli-style.h: Rename include guard.
 706         * cli/cli-setshow.h: Rename include guard.
 707         * cli/cli-script.h: Rename include guard.
 708         * cli/cli-interp.h: Rename include guard.
 709         * cli/cli-decode.h: Rename include guard.
 710         * cli/cli-cmds.h: Rename include guard.
 711         * charset-list.h: Add include guard.
 712         * buildsym-legacy.h: Rename include guard.
 713         * bfin-tdep.h: Add include guard.
 714         * ax.h: Rename include guard.
 715         * arm-linux-tdep.h: Add include guard.
 716         * arm-fbsd-tdep.h: Add include guard.
 717         * arch/xtensa.h: Rename include guard.
 718         * arch/tic6x.h: Add include guard.
 719         * arch/i386.h: Add include guard.
 720         * arch/arm.h: Rename include guard.
 721         * arch/arm-linux.h: Rename include guard.
 722         * arch/arm-get-next-pcs.h: Rename include guard.
 723         * arch/amd64.h: Add include guard.
 724         * arch/aarch64-insn.h: Rename include guard.
 725         * arch-utils.h: Rename include guard.
 726         * annotate.h: Add include guard.
 727         * amd64-darwin-tdep.h: Rename include guard.
 728         * aarch64-linux-tdep.h: Add include guard.
 729         * aarch64-fbsd-tdep.h: Add include guard.
 730         * aarch32-linux-nat.h: Add include guard.
 731
 732 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 733
 734         * macrotab.c (macro_define_internal): New function that
 735         factorizes macro_define_object_internal and macro_define_function
 736         code.
 737         (macro_define_object_internal): Use macro_define_internal.
 738         (macro_define_function): Likewise.
 739
 740 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 741
 742         * macrocmd.c (extract_identifier): Return
 743         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 744         callers.
 745
 746 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 747
 748         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 749
 750 2019-02-05  Tom Tromey  <tom@tromey.com>
 751
 752         * target.c (target_stack::unpush): Move assertion earlier.
 753
 754 2019-01-30  Tom Tromey  <tom@tromey.com>
 755
 756         PR python/23615:
 757         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 758         (gdbpy_parse_and_eval): Likewise.
 759         * python/python-internal.h (gdbpy_allow_threads): New class.
 760
 761 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 762
 763         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 764         (aarch64_fbsd_fpregmap): Move earlier.
 765         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 766         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 767         instead of individual calls to trad_frame_set_reg_addr.
 768         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 769         earlier.
 770         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 771         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 772         instead of individual calls to trad_frame_set_reg_addr.
 773
 774 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 775
 776         * CONTRIBUTE: Replace contribution list with wiki link.
 777
 778 2019-01-25  Tom Tromey  <tom@tromey.com>
 779
 780         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 781
 782 2019-01-25  Tom Tromey  <tom@tromey.com>
 783
 784         * xtensa-linux-nat.c: Fix common/ includes.
 785         * xml-support.h: Fix common/ includes.
 786         * xml-support.c: Fix common/ includes.
 787         * x86-linux-nat.c: Fix common/ includes.
 788         * windows-nat.c: Fix common/ includes.
 789         * varobj.h: Fix common/ includes.
 790         * varobj.c: Fix common/ includes.
 791         * value.c: Fix common/ includes.
 792         * valops.c: Fix common/ includes.
 793         * utils.c: Fix common/ includes.
 794         * unittests/xml-utils-selftests.c: Fix common/ includes.
 795         * unittests/utils-selftests.c: Fix common/ includes.
 796         * unittests/unpack-selftests.c: Fix common/ includes.
 797         * unittests/tracepoint-selftests.c: Fix common/ includes.
 798         * unittests/style-selftests.c: Fix common/ includes.
 799         * unittests/string_view-selftests.c: Fix common/ includes.
 800         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 801         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 802         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 803         * unittests/rsp-low-selftests.c: Fix common/ includes.
 804         * unittests/parse-connection-spec-selftests.c: Fix common/
 805         includes.
 806         * unittests/optional-selftests.c: Fix common/ includes.
 807         * unittests/offset-type-selftests.c: Fix common/ includes.
 808         * unittests/observable-selftests.c: Fix common/ includes.
 809         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 810         * unittests/memrange-selftests.c: Fix common/ includes.
 811         * unittests/memory-map-selftests.c: Fix common/ includes.
 812         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 813         * unittests/function-view-selftests.c: Fix common/ includes.
 814         * unittests/environ-selftests.c: Fix common/ includes.
 815         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 816         * unittests/common-utils-selftests.c: Fix common/ includes.
 817         * unittests/cli-utils-selftests.c: Fix common/ includes.
 818         * unittests/array-view-selftests.c: Fix common/ includes.
 819         * ui-file.c: Fix common/ includes.
 820         * tui/tui-io.c: Fix common/ includes.
 821         * tracepoint.h: Fix common/ includes.
 822         * tracepoint.c: Fix common/ includes.
 823         * tracefile-tfile.c: Fix common/ includes.
 824         * top.h: Fix common/ includes.
 825         * top.c: Fix common/ includes.
 826         * thread.c: Fix common/ includes.
 827         * target/waitstatus.h: Fix common/ includes.
 828         * target/waitstatus.c: Fix common/ includes.
 829         * target.h: Fix common/ includes.
 830         * target.c: Fix common/ includes.
 831         * target-memory.c: Fix common/ includes.
 832         * target-descriptions.c: Fix common/ includes.
 833         * symtab.h: Fix common/ includes.
 834         * symfile.c: Fix common/ includes.
 835         * stap-probe.c: Fix common/ includes.
 836         * spu-linux-nat.c: Fix common/ includes.
 837         * sparc-nat.c: Fix common/ includes.
 838         * source.c: Fix common/ includes.
 839         * solib.c: Fix common/ includes.
 840         * solib-target.c: Fix common/ includes.
 841         * ser-unix.c: Fix common/ includes.
 842         * ser-tcp.c: Fix common/ includes.
 843         * ser-pipe.c: Fix common/ includes.
 844         * ser-base.c: Fix common/ includes.
 845         * selftest-arch.c: Fix common/ includes.
 846         * s12z-tdep.c: Fix common/ includes.
 847         * rust-exp.y: Fix common/ includes.
 848         * rs6000-aix-tdep.c: Fix common/ includes.
 849         * riscv-tdep.c: Fix common/ includes.
 850         * remote.c: Fix common/ includes.
 851         * remote-notif.h: Fix common/ includes.
 852         * remote-fileio.h: Fix common/ includes.
 853         * remote-fileio.c: Fix common/ includes.
 854         * regcache.h: Fix common/ includes.
 855         * regcache.c: Fix common/ includes.
 856         * record-btrace.c: Fix common/ includes.
 857         * python/python.c: Fix common/ includes.
 858         * python/py-type.c: Fix common/ includes.
 859         * python/py-inferior.c: Fix common/ includes.
 860         * progspace.h: Fix common/ includes.
 861         * producer.c: Fix common/ includes.
 862         * procfs.c: Fix common/ includes.
 863         * proc-api.c: Fix common/ includes.
 864         * printcmd.c: Fix common/ includes.
 865         * ppc-linux-nat.c: Fix common/ includes.
 866         * parser-defs.h: Fix common/ includes.
 867         * osdata.c: Fix common/ includes.
 868         * obsd-nat.c: Fix common/ includes.
 869         * nat/x86-linux.c: Fix common/ includes.
 870         * nat/x86-linux-dregs.c: Fix common/ includes.
 871         * nat/x86-dregs.h: Fix common/ includes.
 872         * nat/x86-dregs.c: Fix common/ includes.
 873         * nat/ppc-linux.c: Fix common/ includes.
 874         * nat/mips-linux-watch.h: Fix common/ includes.
 875         * nat/mips-linux-watch.c: Fix common/ includes.
 876         * nat/linux-waitpid.c: Fix common/ includes.
 877         * nat/linux-ptrace.h: Fix common/ includes.
 878         * nat/linux-ptrace.c: Fix common/ includes.
 879         * nat/linux-procfs.c: Fix common/ includes.
 880         * nat/linux-personality.c: Fix common/ includes.
 881         * nat/linux-osdata.c: Fix common/ includes.
 882         * nat/linux-namespaces.c: Fix common/ includes.
 883         * nat/linux-btrace.h: Fix common/ includes.
 884         * nat/linux-btrace.c: Fix common/ includes.
 885         * nat/fork-inferior.c: Fix common/ includes.
 886         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 887         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 888         * nat/aarch64-linux.c: Fix common/ includes.
 889         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 890         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 891         * namespace.h: Fix common/ includes.
 892         * mips-linux-tdep.c: Fix common/ includes.
 893         * minsyms.c: Fix common/ includes.
 894         * mi/mi-parse.h: Fix common/ includes.
 895         * mi/mi-main.c: Fix common/ includes.
 896         * mi/mi-cmd-env.c: Fix common/ includes.
 897         * memrange.h: Fix common/ includes.
 898         * memattr.c: Fix common/ includes.
 899         * maint.h: Fix common/ includes.
 900         * maint.c: Fix common/ includes.
 901         * main.c: Fix common/ includes.
 902         * machoread.c: Fix common/ includes.
 903         * location.c: Fix common/ includes.
 904         * linux-thread-db.c: Fix common/ includes.
 905         * linux-nat.c: Fix common/ includes.
 906         * linux-fork.c: Fix common/ includes.
 907         * inline-frame.c: Fix common/ includes.
 908         * infrun.c: Fix common/ includes.
 909         * inflow.c: Fix common/ includes.
 910         * inferior.h: Fix common/ includes.
 911         * inferior.c: Fix common/ includes.
 912         * infcmd.c: Fix common/ includes.
 913         * inf-ptrace.c: Fix common/ includes.
 914         * inf-child.c: Fix common/ includes.
 915         * ia64-linux-nat.c: Fix common/ includes.
 916         * i387-tdep.c: Fix common/ includes.
 917         * i386-tdep.c: Fix common/ includes.
 918         * i386-linux-tdep.c: Fix common/ includes.
 919         * i386-linux-nat.c: Fix common/ includes.
 920         * i386-go32-tdep.c: Fix common/ includes.
 921         * i386-fbsd-tdep.c: Fix common/ includes.
 922         * i386-fbsd-nat.c: Fix common/ includes.
 923         * guile/scm-type.c: Fix common/ includes.
 924         * guile/guile.c: Fix common/ includes.
 925         * go32-nat.c: Fix common/ includes.
 926         * gnu-nat.c: Fix common/ includes.
 927         * gdbthread.h: Fix common/ includes.
 928         * gdbarch-selftests.c: Fix common/ includes.
 929         * gdb_usleep.c: Fix common/ includes.
 930         * gdb_select.h: Fix common/ includes.
 931         * gdb_bfd.c: Fix common/ includes.
 932         * gcore.c: Fix common/ includes.
 933         * fork-child.c: Fix common/ includes.
 934         * findvar.c: Fix common/ includes.
 935         * fbsd-nat.c: Fix common/ includes.
 936         * event-top.c: Fix common/ includes.
 937         * event-loop.c: Fix common/ includes.
 938         * dwarf2read.c: Fix common/ includes.
 939         * dwarf2loc.c: Fix common/ includes.
 940         * dwarf2-frame.c: Fix common/ includes.
 941         * dwarf-index-cache.c: Fix common/ includes.
 942         * dtrace-probe.c: Fix common/ includes.
 943         * disasm-selftests.c: Fix common/ includes.
 944         * defs.h: Fix common/ includes.
 945         * csky-tdep.c: Fix common/ includes.
 946         * cp-valprint.c: Fix common/ includes.
 947         * cp-support.h: Fix common/ includes.
 948         * cp-support.c: Fix common/ includes.
 949         * corelow.c: Fix common/ includes.
 950         * completer.h: Fix common/ includes.
 951         * completer.c: Fix common/ includes.
 952         * compile/compile.c: Fix common/ includes.
 953         * compile/compile-loc2c.c: Fix common/ includes.
 954         * compile/compile-cplus-types.c: Fix common/ includes.
 955         * compile/compile-cplus-symbols.c: Fix common/ includes.
 956         * command.h: Fix common/ includes.
 957         * cli/cli-dump.c: Fix common/ includes.
 958         * cli/cli-cmds.c: Fix common/ includes.
 959         * charset.c: Fix common/ includes.
 960         * build-id.c: Fix common/ includes.
 961         * btrace.h: Fix common/ includes.
 962         * btrace.c: Fix common/ includes.
 963         * breakpoint.h: Fix common/ includes.
 964         * breakpoint.c: Fix common/ includes.
 965         * ax.h:
 966         (enum agent_op): Fix common/ includes.
 967         * ax-general.c (struct aop_map): Fix common/ includes.
 968         * ax-gdb.c: Fix common/ includes.
 969         * auxv.c: Fix common/ includes.
 970         * auto-load.c: Fix common/ includes.
 971         * arm-tdep.c: Fix common/ includes.
 972         * arch/riscv.c: Fix common/ includes.
 973         * arch/ppc-linux-common.c: Fix common/ includes.
 974         * arch/i386.c: Fix common/ includes.
 975         * arch/arm.c: Fix common/ includes.
 976         * arch/arm-linux.c: Fix common/ includes.
 977         * arch/arm-get-next-pcs.c: Fix common/ includes.
 978         * arch/amd64.c: Fix common/ includes.
 979         * arch/aarch64.c: Fix common/ includes.
 980         * arch/aarch64-insn.c: Fix common/ includes.
 981         * arch-utils.c: Fix common/ includes.
 982         * amd64-windows-tdep.c: Fix common/ includes.
 983         * amd64-tdep.c: Fix common/ includes.
 984         * amd64-sol2-tdep.c: Fix common/ includes.
 985         * amd64-obsd-tdep.c: Fix common/ includes.
 986         * amd64-nbsd-tdep.c: Fix common/ includes.
 987         * amd64-linux-tdep.c: Fix common/ includes.
 988         * amd64-linux-nat.c: Fix common/ includes.
 989         * amd64-fbsd-tdep.c: Fix common/ includes.
 990         * amd64-fbsd-nat.c: Fix common/ includes.
 991         * amd64-dicos-tdep.c: Fix common/ includes.
 992         * amd64-darwin-tdep.c: Fix common/ includes.
 993         * agent.c: Fix common/ includes.
 994         * ada-lang.h: Fix common/ includes.
 995         * ada-lang.c: Fix common/ includes.
 996         * aarch64-tdep.c: Fix common/ includes.
 997
 998 2019-01-25  Tom Tromey  <tom@tromey.com>
 999
1000         * common/create-version.sh: Use common/version.h.
1001
1002 2019-01-24  Pedro Alves  <palves@redhat.com>
1003
1004         * infrun.c (signal_stop, signal_print, signal_program)
1005         (signal_catch, signal_pass): Now arrays instead of pointers.
1006         (update_signals_program_target, do_target_resume)
1007         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1008         * linux-nat.c (linux_nat_target::pass_signals)
1009         (linux_nat_target::create_inferior, linux_nat_target::attach):
1010         Adjust.
1011         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1012         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1013         * procfs.c (procfs_target::pass_signals): Adjust.
1014         * record-full.c (record_full_target::resume): Adjust.
1015         * remote.c (remote_target::pass_signals)
1016         (remote_target::program_signals): Adjust.
1017         * target-debug.h (target_debug_print_signals): Now takes a
1018         gdb::array_view as parameter.  Adjust.
1019         * target.h (target_ops) <pass_signals, program_signals>: Replace
1020         pointer and length parameters with gdb::array_view.
1021         (target_pass_signals, target_program_signals): Likewise.
1022         * target-delegates.c: Regenerate.
1023
1024 2019-01-24  Pedro Alves  <palves@redhat.com>
1025
1026         * common/forward-scope-exit.h
1027         (forward_scope_exit::forward_scope_exit): Pass arguments to
1028         m_bind_function directly, instead of creating a std::bind and
1029         copying that.
1030
1031 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1032
1033         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1034         for static members.
1035         (pass_in_v_vfp_candidate): Likewise.
1036
1037 2019-01-23  Tom Tromey  <tom@tromey.com>
1038             Pedro Alves  <palves@redhat.com>
1039
1040         * regcache.c (class regcache_invalidator): Remove.
1041         (regcache::raw_write): Use make_scope_exit.
1042
1043 2019-01-23  Tom Tromey  <tom@tromey.com>
1044
1045         * ui-out.h (class ui_out_emit_type): Update comment.
1046
1047 2019-01-23  Tom Tromey  <tom@tromey.com>
1048
1049         * infrun.c (fetch_inferior_event): Update comment.
1050
1051 2019-01-23  Tom Tromey  <tom@tromey.com>
1052             Pedro Alves  <palves@redhat.com>
1053
1054         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1055         parameter.
1056         (fetch_inferior_event): Use SCOPE_EXIT.
1057
1058
1059 2019-01-23  Tom Tromey  <tom@tromey.com>
1060             Pedro Alves  <palves@redhat.com>
1061
1062         * infrun.c (disable_thread_events): Delete.
1063         (stop_all_threads): Use SCOPE_EXIT.
1064
1065 2019-01-23  Tom Tromey  <tom@tromey.com>
1066             Pedro Alves  <palves@redhat.com>
1067
1068         * symfile.c: Include forward-scope-exit.h.
1069         (clear_symtab_users_cleanup): Replace forward declaration with
1070         a FORWARD_SCOPE_EXIT.
1071         (syms_from_objfile_1): Use the forward_scope_exit and
1072         gdb::optional instead of cleanup_function.
1073         (reread_symbols): Use the forward_scope_exit instead of
1074         cleanup_function.
1075         (clear_symtab_users_cleanup): Remove function.
1076
1077 2019-01-23  Tom Tromey  <tom@tromey.com>
1078             Pedro Alves  <palves@redhat.com>
1079
1080         * linux-nat.c: Include scope-exit.h.
1081         (cleanup_target_stop): Remove.
1082         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1083         SCOPE_EXIT.
1084
1085 2019-01-23  Tom Tromey  <tom@tromey.com>
1086             Pedro Alves  <palves@redhat.com>
1087
1088         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1089         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1090
1091 2019-01-23  Tom Tromey  <tom@tromey.com>
1092             Andrew Burgess  <andrew.burgess@embecosm.com>
1093             Pedro Alves  <palves@redhat.com>
1094
1095         * infrun.c (fetch_inferior_event): Use scope_exit.
1096         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1097         * top.c (execute_command): Use scope_exit.
1098         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1099         * utils.c (do_bpstat_clear_actions_cleanup)
1100         (make_bpstat_clear_actions_cleanup): Remove.
1101
1102 2019-01-23  Tom Tromey  <tom@tromey.com>
1103             Pedro Alves  <palves@redhat.com>
1104
1105         * infrun.c: Include "common/scope-exit.h"
1106         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1107         (wait_for_inferior): Use SCOPE_EXIT.
1108         (fetch_inferior_event): Use scope_exit.
1109
1110 2019-01-23  Tom Tromey  <tom@tromey.com>
1111             Pedro Alves  <palves@redhat.com>
1112
1113         * breakpoint.c (create_breakpoint): Remove cleanup.
1114
1115 2019-01-23  Tom Tromey  <tom@tromey.com>
1116             Andrew Burgess  <andrew.burgess@embecosm.com>
1117             Pedro Alves  <palves@redhat.com>
1118
1119 2019-01-23  Pedro Alves  <palves@redhat.com>
1120
1121         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1122
1123 2019-01-23  Pedro Alves  <palves@redhat.com>
1124             Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * gdbthread.h: Include "common/forward-scope-exit.h".
1127         (scoped_finish_thread_state): Redefine custom class in terms of
1128         forward_scope_exit.
1129
1130 2019-01-23  Pedro Alves  <palves@redhat.com>
1131             Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * common/forward-scope-exit.h: New file.
1134
1135 2019-01-23  Pedro Alves  <palves@redhat.com>
1136             Andrew Burgess  <andrew.burgess@embecosm.com>
1137             Tom Tromey  <tom@tromey.com>
1138
1139         * common/scope-exit.h: New file.
1140
1141 2019-01-23  Pedro Alves  <palves@redhat.com>
1142
1143         * common/preprocessor.h (ESC): Rename to ...
1144         (ESC_PARENS): ... this.
1145         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1146         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1147
1148 2019-01-23  Tom Tromey  <tom@tromey.com>
1149
1150         * language.h (class scoped_switch_to_sym_language_if_auto):
1151         Initialize m_lang in both cases.
1152
1153 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1154
1155         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1156         with XCNEW.
1157
1158 2019-01-22  Tom Tromey  <tom@tromey.com>
1159
1160         * corelow.c: Do not include sys/file.h.
1161
1162 2019-01-22  Tom Tromey  <tom@tromey.com>
1163
1164         * tui/tui-wingeneral.h: Include gdb_curses.h.
1165
1166 2019-01-22  Tom Tromey  <tom@tromey.com>
1167
1168         * source-cache.h (class source_cache) <get_source_lines,
1169         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1170
1171 2019-01-22  Tom Tromey  <tom@tromey.com>
1172
1173         * remote-fileio.h (struct remote_target): Declare.
1174
1175 2019-01-22  Tom Tromey  <tom@tromey.com>
1176
1177         * python/py-arch.c: Do not include py-ref.h.
1178         * python/py-bpevent.c: Do not include py-ref.h.
1179         * python/py-cmd.c: Do not include py-ref.h.
1180         * python/py-continueevent.c: Do not include py-ref.h.
1181         * python/py-event.h: Do not include py-ref.h.
1182         * python/py-evtregistry.c: Do not include py-ref.h.
1183         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1184         * python/py-frame.c: Do not include py-ref.h.
1185         * python/py-framefilter.c: Do not include py-ref.h.
1186         * python/py-function.c: Do not include py-ref.h.
1187         * python/py-infevents.c: Do not include py-ref.h.
1188         * python/py-linetable.c: Do not include py-ref.h.
1189         * python/py-objfile.c: Do not include py-ref.h.
1190         * python/py-param.c: Do not include py-ref.h.
1191         * python/py-prettyprint.c: Do not include py-ref.h.
1192         * python/py-progspace.c: Do not include py-ref.h.
1193         * python/py-symbol.c: Do not include py-ref.h.
1194         * python/py-symtab.c: Do not include py-ref.h.
1195         * python/py-type.c: Do not include py-ref.h.
1196         * python/py-unwind.c: Do not include py-ref.h.
1197         * python/py-utils.c: Do not include py-ref.h.
1198         * python/py-value.c: Do not include py-ref.h.
1199         * python/py-varobj.c: Do not include py-ref.h.
1200         * python/py-xmethods.c: Do not include py-ref.h.
1201         * python/python.c: Do not include py-ref.h.
1202         * varobj.c: Do not include py-ref.h.
1203
1204 2019-01-22  Tom Tromey  <tom@tromey.com>
1205
1206         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1207         keyword for bcache.
1208
1209 2019-01-22  Tom Tromey  <tom@tromey.com>
1210
1211         * compile/compile-cplus-types.c: Remove a comment by #include.
1212
1213 2019-01-22  Tom Tromey  <tom@tromey.com>
1214
1215         * compile/gcc-c-plugin.h: Include compile-internal.h.
1216
1217 2019-01-22  Tom Tromey  <tom@tromey.com>
1218
1219         * stabsread.c (EXTERN): Do not define.
1220         (symnum, next_symbol_text_func, processing_gcc_compilation)
1221         (within_function, global_sym_chain, global_stabs)
1222         (previous_stab_code, this_object_header_files)
1223         (n_this_object_header_files)
1224         (n_allocated_this_object_header_files): Define.
1225         * stabsread.h (EXTERN): Never define.  Use "extern".
1226
1227 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1228
1229         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1230         history_value.
1231
1232 2019-01-21  Tom Tromey  <tom@tromey.com>
1233
1234         * ui-out.c: Fix includes.
1235         * tui/tui-source.c: Fix includes.
1236         * target.c: Fix includes.
1237         * remote.c: Fix includes.
1238         * regcache.c: Fix includes.
1239         * python/py-block.c: Fix includes.
1240         * printcmd.c: Fix includes.
1241         * or1k-tdep.c: Fix includes.
1242         * mi/mi-main.c: Fix includes.
1243         * m32r-tdep.c: Fix includes.
1244         * csky-tdep.c: Fix includes.
1245         * compile/compile-cplus-types.c: Fix includes.
1246         * cli/cli-interp.c: Fix includes.
1247
1248 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1249
1250         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1251         for padding.
1252
1253 2019-01-16  Tom Tromey  <tom@tromey.com>
1254
1255         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1256         earlier.
1257         (struct objfile) <msymbols_range>: Move from top level.
1258         <msymbols>: New method.
1259         (class objfile_msymbols): Remove.
1260         * symtab.c (default_collect_symbol_completion_matches_break_on):
1261         Update.
1262         * symmisc.c (dump_msymbols): Update.
1263         * stabsread.c (scan_file_globals): Update.
1264         * objc-lang.c (info_selectors_command, info_classes_command)
1265         (find_methods): Update.
1266         * minsyms.c (find_solib_trampoline_target): Update.
1267         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1268         * coffread.c (coff_symfile_read): Update.
1269         * ada-lang.c (ada_lookup_simple_minsym)
1270         (ada_collect_symbol_completion_matches): Update.
1271
1272 2019-01-16  Tom Tromey  <tom@tromey.com>
1273
1274         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1275         type.  Remove no-argument constructor.
1276         <iterator::operator++>: Simplify.
1277         <begin>: Update.
1278         <end>: Use minimal_symbol_count.
1279
1280 2019-01-16  Tom Tromey  <tom@tromey.com>
1281
1282         * objfiles.h (struct objfile) <psymtabs>: New method.
1283         (class objfile_psymtabs): Remove.
1284         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1285         typedef.
1286         <range>: New method.
1287         (require_partial_symbols): Change return type.
1288         * psymtab.c (require_partial_symbols)
1289         (psym_expand_symtabs_matching): Update.
1290         * mdebugread.c (parse_partial_symbols): Update.
1291         * dbxread.c (dbx_end_psymtab): Update.
1292
1293 2019-01-15  Tom Tromey  <tom@tromey.com>
1294
1295         * symtab.c (lookup_objfile_from_block)
1296         (lookup_symbol_in_objfile_symtabs)
1297         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1298         (find_line_symtab, info_sources_command)
1299         (default_collect_symbol_completion_matches_break_on)
1300         (make_source_files_completion_list): Update.
1301         * symmisc.c (print_objfile_statistics, dump_objfile)
1302         (maintenance_print_symbols, maintenance_info_symtabs)
1303         (maintenance_check_symtabs, maintenance_info_line_tables):
1304         Update.
1305         * source.c (select_source_symtab)
1306         (forget_cached_source_info_for_objfile): Update.
1307         * objfiles.h (class objfile_compunits): Remove.
1308         (struct objfile) <compunits_range>: New typedef.
1309         (compunits): New method.
1310         * objfiles.c (objfile_relocate1): Update.
1311         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1312         * maint.c (count_symtabs_and_blocks): Update.
1313         * linespec.c (iterate_over_all_matching_symtabs): Update.
1314         * cp-support.c (add_symbol_overload_list_qualified): Update.
1315         * coffread.c (coff_symtab_read): Update.
1316         * ada-lang.c (add_nonlocal_symbols)
1317         (ada_collect_symbol_completion_matches)
1318         (ada_add_global_exceptions): Update.
1319
1320 2019-01-15  Tom Tromey  <tom@tromey.com>
1321
1322         * progspace.h (program_space) <objfiles_safe_range>: New
1323         typedef.
1324         <objfiles_safe>: New method.
1325         * objfiles.h (class all_objfiles_safe): Remove.
1326         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1327         * jit.c (jit_inferior_exit_hook): Update.
1328
1329 2019-01-17  Tom Tromey  <tom@tromey.com>
1330
1331         * progspace.h (program_space) <objfiles_range>: New typedef.
1332         <objfiles>: New method.
1333         <objfiles_head>: Rename from objfiles.
1334         (object_files): Update.
1335         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1336         * guile/scm-pretty-print.c
1337         (ppscm_find_pretty_printer_from_objfiles): Update.
1338         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1339         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1340         Update.
1341         * python/py-progspace.c (pspy_get_objfiles): Update.
1342         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1343         Update.
1344         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1345         (objfpy_lookup_objfile_by_build_id): Update.
1346         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1347         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1348         Update.
1349         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1350         (expand_symtab_containing_pc, lookup_objfile_from_block)
1351         (lookup_static_symbol, basic_lookup_transparent_type)
1352         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1353         (find_line_symtab, info_sources_command)
1354         (default_collect_symbol_completion_matches_break_on)
1355         (make_source_files_completion_list, find_main_name): Update.
1356         * symmisc.c (print_symbol_bcache_statistics)
1357         (print_objfile_statistics, maintenance_print_symbols)
1358         (maintenance_print_msymbols, maintenance_print_objfiles)
1359         (maintenance_info_symtabs, maintenance_check_symtabs)
1360         (maintenance_expand_symtabs, maintenance_info_line_tables):
1361         Update.
1362         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1363         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1364         (map_overlay_command, unmap_overlay_command)
1365         (simple_overlay_update, expand_symtabs_matching)
1366         (map_symbol_filenames): Update.
1367         * symfile-debug.c (set_debug_symfile): Update.
1368         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1369         Update.
1370         * source.c (select_source_symtab, forget_cached_source_info):
1371         Update.
1372         * solib.c (solib_read_symbols): Update.
1373         * solib-spu.c (append_ocl_sos): Update.
1374         * psymtab.c (maintenance_print_psymbols)
1375         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1376         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1377         * printcmd.c (info_symbol_command): Update.
1378         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1379         Update.
1380         * objfiles.h (class all_objfiles): Remove.
1381         * objfiles.c (have_partial_symbols, have_full_symbols)
1382         (have_minimal_symbols, qsort_cmp, update_section_map)
1383         (shared_objfile_contains_address_p)
1384         (default_iterate_over_objfiles_in_search_order): Update.
1385         * objc-lang.c (info_selectors_command, info_classes_command)
1386         (find_methods): Update.
1387         * minsyms.c (find_solib_trampoline_target): Update.
1388         * maint.c (maintenance_info_sections)
1389         (maintenance_translate_address, count_symtabs_and_blocks):
1390         Update.
1391         * main.c (captured_main_1): Update.
1392         * linux-thread-db.c (try_thread_db_load_from_pdir)
1393         (has_libpthread): Update.
1394         * linespec.c (iterate_over_all_matching_symtabs)
1395         (search_minsyms_for_name): Update.
1396         * jit.c (jit_find_objf_with_entry_addr): Update.
1397         * hppa-tdep.c (find_unwind_entry)
1398         (hppa_lookup_stub_minimal_symbol): Update.
1399         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1400         Update.
1401         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1402         (elf_gnu_ifunc_resolve_by_got): Update.
1403         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1404         * dwarf-index-write.c (save_gdb_index_command): Update.
1405         * cp-support.c (add_symbol_overload_list_qualified): Update.
1406         * breakpoint.c (create_overlay_event_breakpoint)
1407         (create_longjmp_master_breakpoint)
1408         (create_std_terminate_master_breakpoint)
1409         (create_exception_master_breakpoint): Update.
1410         * blockframe.c (find_pc_partial_function): Update.
1411         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1412         (ada_collect_symbol_completion_matches)
1413         (ada_add_global_exceptions): Update.
1414
1415 2019-01-17  Tom Tromey  <tom@tromey.com>
1416
1417         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1418         declare VEC.
1419         (solib_target_parse_libraries): Change return type.
1420         (library_list_start_segment, library_list_start_section)
1421         (library_list_end_library, library_list_start_library); Update.
1422         (solib_target_free_library_list): Remove.
1423         (solib_target_parse_libraries): Remove cleanup.  Change return
1424         type.
1425         (solib_target_current_sos): Update.
1426
1427 2019-01-17  Tom Tromey  <tromey@bapiya>
1428
1429         * valprint.c: Replace "the the" with "the".
1430         * symtab.c: Replace "the the" with "the".
1431         * solib.c: Replace "the the" with "the".
1432         * solib-dsbt.c: Replace "the the" with "the".
1433         * linespec.c: Replace "the the" with "the".
1434         * dwarf2loc.h: Replace "the the" with "the".
1435         * amd64-windows-tdep.c: Replace "the the" with "the".
1436         * aarch64-tdep.c: Replace "the the" with "the".
1437
1438 2019-01-16  Keith Seitz  <keiths@redhat.com>
1439
1440         PR gdb/23773
1441         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1442         <builder>: Rename to ..
1443         <m_builder>: ... this and make private.
1444         (dwarf2_cu::get_builder): New method.  Change all users of
1445         `builder' to use this method.
1446         (dwarf2_start_symtab): Move to ...
1447         (dwarf2_cu::start_symtab): ... here.  Update all callers
1448         (setup_type_unit_groups): Move to ...
1449         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1450         callers.
1451         (dwarf2_cu::reset_builder): New method.
1452         (process_full_compunit, process_full_type_unit): Use
1453         dwarf2_cu::reset_builder.
1454         (follow_die_offset): Record the ancestor CU if it is different
1455         from the followed DIE's CU.
1456         (follow_die_sig_1): Likewise.
1457
1458 2019-01-15  Tom Tromey  <tom@tromey.com>
1459
1460         * remote.c (class remote_state) <buf>: Now a char_vector.
1461         <buf_size>: Remove.
1462         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1463         parameter.
1464         (remote_target::getpkt_or_notif_sane_1)
1465         (remote_target::getpkt_sane)
1466         (remote_target::getpkt_or_notif_sane): Likewise.
1467         (class remote_target) <putpkt>: New overload.
1468         (remote_target::read_frame): Change type of "buf_p".  Remove
1469         sizeof_p parameter.
1470         (packet_ok): New overload.
1471         (packet_check_result): New overload.
1472         Update all uses.
1473
1474 2019-01-14  Tom Tromey  <tom@tromey.com>
1475
1476         * remote-notif.c (handle_notification, remote_notif_ack)
1477         (remote_notif_parse): Make "buf" const.
1478         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1479         const.
1480         (remote_notif_parse, remote_notif_ack, handle_notification):
1481         Likewise.
1482         * remote.c (remote_notif_stop_parse): Make "buf" const.
1483         (remote_target::remote_parse_stop_reply): Make "buf" const.
1484         (remote_notif_stop_ack): Make "buf" const.
1485
1486 2019-01-14  Tom Tromey  <tom@tromey.com>
1487
1488         * remote.c (remote_console_output): Make parameter const.
1489
1490 2019-01-14  Tom Tromey  <tom@tromey.com>
1491
1492         * target-debug.h (target_debug_print_signals): Constify.
1493         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1494         * procfs.c (procfs_target::pass_signals): Update.
1495         * linux-nat.c (linux_nat_target::pass_signals): Update.
1496         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1497         * target-delegates.c: Rebuild.
1498         * remote.c (remote_target::program_signals): Update.
1499         (remote_target::pass_signals): Update.
1500         * target.c (target_pass_signals): Constify argument.
1501         (target_program_signals): Likewise.
1502         * target.h (struct target_ops) <pass_signals, program_signals>:
1503         Constify argument.
1504         (target_pass_signals, target_program_signals): Constify argument.
1505
1506 2019-01-14  Tom Tromey  <tom@tromey.com>
1507
1508         PR tui/28819:
1509         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1510
1511 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1512
1513         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1514         field.
1515         * rs6000-tdep.c: Include reggroups.h.
1516         (IS_V_ALIAS_PSEUDOREG): Define.
1517         (rs6000_register_name): Return names for the "vX" aliases.
1518         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1519         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1520         aliases.  Call default_register_reggroup_p for all other
1521         pseudo-registers.
1522         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1523         New functions.
1524         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1525         Handle "vX" aliases.
1526         (v_alias_pseudo_register_collect): New function.
1527         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1528         (rs6000_gdbarch_init): Initialize "vX" aliases as
1529         pseudo-registers.  Restore registration of
1530         rs6000_pseudo_register_reggroup_p with
1531         set_tdesc_pseudo_register_reggroup_p.
1532
1533 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1534
1535         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1536         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1537         set_gdbarch_num_pseudo_regs.
1538
1539 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1540
1541         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1542         Remove arg prefixname, add do_set and do_show.
1543         Add member functions set_list and show_list.
1544         * cli/cli-style.c (class cli_style_option): Update accordingly.
1545         (style_set_list): Move to file scope.
1546         (style_show_list): Likewise.
1547         (set_style): Call help_list.
1548         (show_style): Call cmd_show_list.
1549         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1550         Update to use the new macro.
1551
1552 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1553
1554         * ada-lang.c (_initialize_ada_language): Expand the help text
1555         for the "catch exception" command.
1556
1557 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1558
1559         * symtab.c (matching_obj_sections): Initialize obj,
1560         declare it closer to its usage.
1561
1562 2019-01-10  Tom Tromey  <tom@tromey.com>
1563
1564         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1565         (basic_inf_threads_range): Remove.
1566         (inf_threads_range, inf_non_exited_threads_range)
1567         (safe_inf_threads_range): Use next_adapter.
1568
1569 2019-01-10  Keith Seitz  <keiths@redhat.com>
1570
1571         PR gdb/23712
1572         PR symtab/23010
1573         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1574         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1575
1576 2019-01-10  Keith Seitz  <keiths@redhat.com>
1577
1578         PR gdb/23712
1579         PR symtab/23010
1580         * dictionary.c (pending_to_vector): Remove.
1581         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1582         Remove _1 suffix, replacing functions of the same name.  Update
1583         all callers.
1584         (dict_create_hashed, dict_create_hashed_expandable)
1585         (dict_create_linear, dict_create_linear_expandable, dict_free)
1586         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1587         Make functions static.
1588
1589 2019-01-10  Keith Seitz  <keiths@redhat.com>
1590
1591         PR gdb/23712
1592         PR symtab/23010
1593         * dictionary.h (struct dictionary): Replace declaration with
1594         multidictionary.
1595         (dict_create_hashed, dict_create_hashed_expandable)
1596         (dict_create_linear, dict_create_linear_expandable)
1597         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1598         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1599         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1600         taking multidictionary argument.
1601         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1602         * block.h (struct block) <dict>: Change to multidictionary
1603         and rename `multidict'.
1604         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1605         symmisc.c: Update all dictionary references to multidictionary.
1606
1607 2019-01-10  Keith Seitz  <keiths@redhat.com>
1608
1609         PR gdb/23712
1610         PR symtab/23010
1611         * dictionary.c: Include unordered_map.
1612         (pending_to_vector): New function.
1613         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1614         Rewrite the non-"_1" functions to take vector instead
1615         of linked list.
1616         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1617         "new" _1 versions of the same name.
1618         (multidictionary): Define.
1619         (std::hash<enum language): New definition.
1620         (collate_pending_symbols_by_language, mdict_create_hashed)
1621         (mdict_create_hashed_expandable, mdict_create_linear)
1622         (mdict_create_linear_expandable, mdict_free)
1623         (find_language_dictionary, create_new_language_dictionary)
1624         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1625         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1626         (mdict_size, mdict_empty): New functions.
1627         * dictionary.h (mdict_iterator): Define.
1628
1629 2019-01-10  Pedro Alves  <palves@redhat.com>
1630
1631         * breakpoint.c (read_uploaded_action)
1632         (create_tracepoint_from_upload): Adjust to use
1633         gdb::unique_xmalloc_ptr.
1634         * ctf.c (ctf_write_uploaded_tp):
1635         (SET_ARRAY_FIELD): Use emplace_back.
1636         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1637         * tracefile-tfile.c (tfile_write_uploaded_tp):
1638         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1639         gdb::unique_xmalloc_ptr.
1640         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1641         at_string, cond_string, cmd_strings>: Replace char pointers
1642         with gdb::unique_xmalloc_ptr.
1643
1644 2019-01-10  Pedro Alves  <palves@redhat.com>
1645
1646         * solib-target.c (library_list_start_library): Don't xstrdup name.
1647
1648 2019-01-10  Pedro Alves  <palves@redhat.com>
1649
1650         * mdebugread.c (parse_partial_symbols): Use
1651         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1652
1653 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1654
1655         * linux-fork.c (scoped_switch_fork_info)
1656         <~scoped_switch_fork_info>: Fix incorrect variable name.
1657
1658 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1659
1660         * linux-fork.c (scoped_switch_fork_info)
1661         <scoped_switch_fork_info>: Make explicit.
1662         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1663
1664 2019-01-10  Tom Tromey  <tom@tromey.com>
1665
1666         * objfiles.h (objfile::reset_psymtabs): Update.
1667         * objfiles.c (objfile::objfile): Update.
1668         * psymtab.h (psymtab_storage::obstack): Update.
1669         (psymtab_storage::m_obstack): Use gdb::optional.
1670         (class psymtab_storage): Update comment.  Remove objfile
1671         parameter.
1672         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1673
1674 2019-01-10  Tom Tromey  <tom@tromey.com>
1675
1676         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1677         <free_psymtabs>: Now private.
1678         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1679         (allocate_psymtab): Use new method.
1680
1681 2019-01-10  Tom Tromey  <tom@tromey.com>
1682
1683         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1684         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1685         * mdebugread.c (parse_partial_symbols): Use
1686         allocate_dependencies.
1687         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1688         allocate_dependencies.
1689         (process_psymtab_comp_unit_reader)
1690         (build_type_psymtab_dependencies): Likewise.
1691         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1692
1693 2019-01-10  Tom Tromey  <tom@tromey.com>
1694
1695         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1696         PSYMBOL_SET_LANGUAGE.
1697         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1698
1699 2019-01-10  Tom Tromey  <tom@tromey.com>
1700
1701         * psymtab.h (psymtab_storage::obstack): New method.
1702         <m_obstack>: Rename from obstack; now private.
1703         * psymtab.c (psymtab_storage): Update.
1704         * dwarf2read.c (create_addrmap_from_index)
1705         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1706         Update.
1707
1708 2019-01-10  Tom Tromey  <tom@tromey.com>
1709
1710         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1711         * objfiles.h (objfile::reset_psymtabs): New method.
1712
1713 2019-01-10  Tom Tromey  <tom@tromey.com>
1714
1715         * symmisc.c (print_symbol_bcache_statistics): Update.
1716         (print_objfile_statistics): Update.
1717         * symfile.c (reread_symbols): Update.
1718         * psymtab.h (class psymtab_storage): New.
1719         * psymtab.c (psymtab_storage): New constructor.
1720         (~psymtab_storage): New destructor.
1721         (require_partial_symbols): Update.
1722         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1723         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1724         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1725         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1726         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1727         (start_psymtab_common, end_psymtab_common)
1728         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1729         (allocate_psymtab): Update.
1730         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1731         Update.
1732         (dump_psymtab_addrmap, maintenance_print_psymbols)
1733         (maintenance_check_psymtabs): Update.
1734         (class objfile_psymtabs): Move to objfiles.h.
1735         * psympriv.h (discard_psymtab): Now inline.
1736         (psymtab_discarder::psymtab_discarder): Update.
1737         (psymtab_discarder::~psymtab_discarder): Update.
1738         (ALL_OBJFILE_PSYMTABS): Rewrite.
1739         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1740         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1741         Remove fields.
1742         <partial_symtabs>: New field.
1743         (class objfile_psymtabs): Move from psymtab.h.  Update.
1744         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1745         psymbol_cache.
1746         (objfile::~objfile): Don't destroy psymbol_cache.
1747         * mdebugread.c (parse_partial_symbols): Update.
1748         * dwarf2read.c (create_addrmap_from_index)
1749         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1750         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1751         (add_partial_subprogram, dwarf2_ranges_read): Update.
1752         * dwarf-index-write.c (write_address_map)
1753         (write_one_signatured_type, recursively_write_psymbols)
1754         (class debug_names, class debug_names, write_psymtabs_to_index):
1755         Update.
1756
1757 2019-01-10  Tom Tromey  <tom@tromey.com>
1758
1759         * symtab.h (SYMBOL_SET_NAMES): Update.
1760         (symbol_set_names): Update.
1761         (MSYMBOL_SET_NAMES): Update.
1762         * symtab.c (symbol_set_names): Change argument to be an
1763         objfile_per_bfd_storage.
1764         * psymtab.c (add_psymbol_to_bcache): Update.
1765         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1766
1767 2019-01-10  Tom Tromey  <tom@tromey.com>
1768
1769         * symtab.c (create_demangled_names_hash): Change argument to be an
1770         objfile_per_bfd_storage.
1771         (symbol_set_names): Update.
1772
1773 2019-01-10  Tom Tromey  <tom@tromey.com>
1774
1775         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1776         init_psymbol_list.
1777         * psymtab.c (init_psymbol_list): Do nothing if already called.
1778         * psympriv.h (init_psymbol_list): Add comment.
1779         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1780         init_psymbol_list.
1781         * dbxread.c (dbx_symfile_read): Unconditionally call
1782         init_psymbol_list.
1783
1784 2019-01-10  Tom Tromey  <tom@tromey.com>
1785
1786         * xcoffread.c (scan_xcoff_symtab): Update.
1787         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1788         "where".
1789         * mdebugread.c (parse_partial_symbols)
1790         (handle_psymbol_enumerators): Update.
1791         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1792         * dbxread.c (read_dbx_symtab): Update.
1793         * psympriv.h (psymbol_placement): New enum.
1794         (add_psymbol_to_list): Update.
1795
1796 2019-01-10  Tom Tromey  <tom@tromey.com>
1797
1798         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1799         static_psymbols parameters.
1800         (scan_xcoff_symtab): Update.
1801         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1802         static_psymbols parameters.
1803         * psympriv.h (start_psymtab_common): Update.
1804         * mdebugread.c (parse_partial_symbols): Update.
1805         * dwarf2read.c (create_partial_symtab): Update.
1806         * dbxread.c (read_dbx_symtab): Update.
1807         (start_psymtab): Remove global_psymbols and static_psymbols
1808         parameters.
1809
1810 2019-01-10  Tom Tromey  <tom@tromey.com>
1811
1812         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1813         * psymtab.c (allocate_psymtab): Add comment.
1814         * psympriv.h (allocate_psymtab): Add comment.
1815         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1816         initializations.
1817         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1818
1819 2019-01-10  Tom Tromey  <tom@tromey.com>
1820
1821         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1822         Don't declare.
1823         * mipsread.c: Include mdebugread.h.
1824         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1825         Declare.
1826         * elfread.c: Include mdebugread.h.
1827
1828 2019-01-09  Tom Tromey  <tom@tromey.com>
1829
1830         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1831         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1832         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1833         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1834         (psym_lookup_symbol, psym_find_last_source_symtab)
1835         (psym_forget_cached_source_info, psym_print_stats)
1836         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1837         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1838         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1839         (psym_find_compunit_symtab_by_address)
1840         (maintenance_print_psymbols, maintenance_info_psymtabs)
1841         (maintenance_check_psymtabs): Use ranged for.
1842         * psymtab.h (class objfile_psymtabs): New.
1843         (require_partial_symbols): Return objfile_psymtabs.
1844         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1845
1846 2019-01-09  Tom Tromey  <tom@tromey.com>
1847
1848         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1849         (find_pc_mapped_section, list_overlays_command)
1850         (map_overlay_command, unmap_overlay_command)
1851         (simple_overlay_update): Use all_objfiles.
1852         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1853         * printcmd.c (info_symbol_command): Use all_objfiles.
1854         * objfiles.h (ALL_OBJSECTIONS): Remove.
1855         * maint.c (maintenance_translate_address): Use all_objfiles.
1856         * gcore.c (gcore_create_callback): Use all_objfiles.
1857         (objfile_find_memory_regions): Likewise.
1858
1859 2019-01-09  Tom Tromey  <tom@tromey.com>
1860
1861         * symtab.c (find_line_symtab, info_sources_command)
1862         (make_source_files_completion_list): Use objfile_compunits.
1863         * source.c (select_source_symtab): Use objfile_compunits.
1864         * objfiles.h (struct objfile): Update comment.
1865         (ALL_OBJFILES): Remove.
1866         (ALL_FILETABS): Remove.
1867         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1868         objfile_compunits.
1869
1870 2019-01-09  Tom Tromey  <tom@tromey.com>
1871
1872         * symmisc.c (print_objfile_statistics, dump_objfile)
1873         (maintenance_print_symbols): Use compunit_filetabs.
1874         * source.c (forget_cached_source_info_for_objfile): Use
1875         compunit_filetabs.
1876         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1877         (ALL_FILETABS): Use compunit_filetabs.
1878         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1879         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1880
1881 2019-01-09  Tom Tromey  <tom@tromey.com>
1882
1883         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1884         (compunit_filetabs): New.
1885         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1886         compunit_filetabs.
1887         (info_sources_command, make_source_files_completion_list): Remove
1888         declaration.
1889         * symmisc.c (print_objfile_statistics, dump_objfile)
1890         (maintenance_print_symbols): Remove declaration.
1891         (maintenance_info_symtabs): Use compunit_filetabs.
1892         (maintenance_info_line_tables): Likewise.
1893         * source.c (select_source_symtab): Change local variable name.
1894         (forget_cached_source_info_for_objfile): Remove declaration.
1895         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1896         * objfiles.c (objfile_relocate1): Remove declaration.
1897         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1898         declaration.
1899         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1900         * coffread.c (coff_symtab_read): Remove declaration.
1901         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1902         compunit_filetabs.
1903
1904 2019-01-09  Tom Tromey  <tom@tromey.com>
1905
1906         * symtab.c (lookup_objfile_from_block)
1907         (find_pc_sect_compunit_symtab, search_symbols)
1908         (default_collect_symbol_completion_matches_break_on): Use
1909         objfile_compunits.
1910         * objfiles.h (ALL_COMPUNITS): Remove.
1911         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1912         * cp-support.c (add_symbol_overload_list_qualified): Use
1913         objfile_compunits.
1914         * ada-lang.c (ada_collect_symbol_completion_matches)
1915         (ada_add_global_exceptions): Use objfile_compunits.
1916
1917 2019-01-09  Tom Tromey  <tom@tromey.com>
1918
1919         * source.c (select_source_symtab)
1920         (forget_cached_source_info_for_objfile): Remove declaration.
1921         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1922         declaration.
1923         * maint.c (count_symtabs_and_blocks): Remove declaration.
1924         * cp-support.c (add_symbol_overload_list_qualified): Remove
1925         declaration.
1926         * coffread.c (coff_symtab_read): Remove declaration.
1927         * symtab.c (lookup_symbol_in_objfile_symtabs)
1928         (basic_lookup_transparent_type_1): Use objfile_compunits.
1929         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1930         (info_sources_command, search_symbols)
1931         (default_collect_symbol_completion_matches_break_on)
1932         (make_source_files_completion_list): Remove declaration.
1933         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1934         (ada_collect_symbol_completion_matches)
1935         (ada_add_global_exceptions): Remove declaration.
1936         * linespec.c (iterate_over_all_matching_symtabs): Use
1937         objfile_compunits.
1938         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1939         (class objfile_compunits): New.
1940         (ALL_COMPUNITS): Use objfile_compunits.
1941         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1942         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1943         objfile_compunits.
1944         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1945
1946 2019-01-09  Tom Tromey  <tom@tromey.com>
1947
1948         * symtab.c (search_symbols)
1949         (default_collect_symbol_completion_matches_break_on): Use
1950         objfile_msymbols.
1951         * ada-lang.c (ada_lookup_simple_minsym)
1952         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1953         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1954         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1955         objfile_msymbols.
1956         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1957         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1958         * objc-lang.c (find_methods): Use objfile_msymbols.
1959         (info_selectors_command, info_classes_command): Likewise.
1960         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1961         * objfiles.h (class objfile_msymbols): New.
1962         (ALL_OBJFILE_MSYMBOLS): Remove.
1963         (ALL_MSYMBOLS): Remove.
1964
1965 2019-01-09  Tom Tromey  <tom@tromey.com>
1966
1967         * common/next-iterator.h (next_adapter): Add Iterator template
1968         parameter.
1969         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1970         (class all_objfiles_safe): New.
1971         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1972         * objfiles.c (put_objfile_before): Update comment.
1973         (add_separate_debug_objfile): Likewise.
1974         (free_all_objfiles): Use all_objfiles_safe.
1975         (objfile_purge_solibs): Likewise.
1976
1977 2019-01-09  Tom Tromey  <tom@tromey.com>
1978
1979         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1980         (expand_symtab_containing_pc, lookup_static_symbol)
1981         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1982         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1983         all_objfiles.
1984         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1985         * breakpoint.c (create_overlay_event_breakpoint)
1986         (create_longjmp_master_breakpoint)
1987         (create_std_terminate_master_breakpoint)
1988         (create_exception_master_breakpoint): Use all_objfiles.
1989         * linux-thread-db.c (try_thread_db_load_from_pdir)
1990         (has_libpthread): Use all_objfiles.
1991         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1992         * linespec.c (iterate_over_all_matching_symtabs)
1993         (search_minsyms_for_name): Use all_objfiles.
1994         * maint.c (maintenance_info_sections): Use all_objfiles.
1995         * main.c (captured_main_1): Use all_objfiles.
1996         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1997         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1998         * guile/scm-pretty-print.c
1999         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2000         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2001         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2002         (maintenance_print_msymbols): Use all_objfiles.
2003         * source.c (select_source_symtab): Use all_objfiles.
2004         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2005         * symfile.c (remove_symbol_file_command)
2006         (expand_symtabs_matching, map_symbol_filenames): Use
2007         all_objfiles.
2008         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2009         all_objfiles.
2010         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2011         * objc-lang.c (find_methods): Use all_objfiles.
2012         * objfiles.c (have_partial_symbols, have_full_symbols)
2013         (have_minimal_symbols, qsort_cmp)
2014         (default_iterate_over_objfiles_in_search_order): Use
2015         all_objfiles.
2016         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2017         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2018         (maintenance_check_psymtabs): Use all_objfiles.
2019         (ALL_PSYMTABS): Remove.
2020         * compile/compile-object-run.c (do_module_cleanup): Use
2021         all_objfiles.
2022         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2023         * cp-support.c (add_symbol_overload_list_qualified): Use
2024         all_objfiles.
2025         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2026         Use all_objfiles.
2027         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2028         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2029         all_objfiles.
2030         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2031         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2032         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2033         Uses all_objfiles.
2034         * solib.c (solib_read_symbols): Use all_objfiles
2035
2036 2019-01-09  Tom Tromey  <tom@tromey.com>
2037
2038         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2039         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2040         all_objfiles.
2041         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2042         * symmisc.c (print_symbol_bcache_statistics)
2043         (print_objfile_statistics, maintenance_print_objfiles)
2044         (maintenance_info_symtabs, maintenance_check_symtabs)
2045         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2046         all_objfiles.
2047         * source.c (forget_cached_source_info): Use all_objfiles.
2048         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2049         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2050         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2051         * objfiles.c (update_section_map): Use all_objfiles.
2052         (shared_objfile_contains_address_p): Likewise.
2053         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2054         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2055
2056 2019-01-09  Tom Tromey  <tom@tromey.com>
2057
2058         * common/next-iterator.h: New file.
2059         * objfiles.h (class all_objfiles): New.
2060         (struct objfile_iterator): New.
2061
2062 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2063
2064         * NEWS: Move the description of the changed "frame", "select-frame",
2065          and "info frame" commands to the Changed commands section.
2066
2067 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2068
2069         * gdbtypes.c (check_stub_method_group): Remove handling of old
2070         mangling schemes.
2071         * linespec.c (find_methods): Likewise.
2072         * stabsread.c (read_member_functions): Likewise.
2073         * valops.c (search_struct_method): Likewise.
2074         (value_struct_elt_for_reference): Likewise.
2075         * NEWS: Mention this change.
2076
2077 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2078
2079         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2080         print_source_lines.
2081         * source.c (print_source_lines_base): Update line number check.
2082         (print_source_lines): New function.
2083         (source_lines_range::source_lines_range): New function.
2084         * source.h (class source_lines_range): New class.
2085         (print_source_lines): New declaration.
2086
2087 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2088
2089         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2090
2091 2019-01-08  Tom Tromey  <tom@tromey.com>
2092             Simon Marchi  <simon.marchi@ericsson.com>
2093
2094         PR gdb/24060
2095         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2096         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2097         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2098         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2099         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2100         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2101
2102 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2103
2104         * source.c (select_source_symtab): Move header comment to
2105         declaration in source.h.
2106         (forget_cached_source_info_for_objfile): Likewise.
2107         (forget_cached_source_info): Likewise.
2108         (identify_source_line): Likewise.
2109         * source.h (identify_source_line): Move declaration from symtab.h
2110         and add comment from source.c
2111         (print_source_lines): Likewise.
2112         (forget_cached_source_info_for_objfile): Likewise.
2113         (forget_cached_source_info): Likewise.
2114         (select_source_symtab): Likewise.
2115         (enum print_source_lines_flag): Move definition from symtab.h.
2116         * symtab.h (identify_source_line): Move declaration to source.h.
2117         (print_source_lines): Likewise.
2118         (forget_cached_source_info_for_objfile): Likewise.
2119         (forget_cached_source_info): Likewise.
2120         (select_source_symtab): Likewise.
2121         (enum print_source_lines_flag): Move definition to source.h.
2122         * tui/tui-hooks.c: Add 'source.h' include.
2123
2124 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2125
2126         * source.c (print_source_lines_base): Handle requests to print
2127         reverse line number sequences, and guard against empty lines
2128         string.
2129
2130 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2131
2132         * source.c (print_source_lines_base): Fix skip of '\r' if next
2133         character is '\n'.
2134
2135 2019-01-06  Tom Tromey  <tom@tromey.com>
2136
2137         * c-exp.y (struct c_parse_state) <macro_original_text,
2138         expansion_obstack>: New member.
2139         (macro_original_text, expansion_obstack): Remove globals.
2140         (scan_macro_expansion, scanning_macro_expansion)
2141         (finished_macro_expansion): Update.
2142         (scan_macro_cleanup): Remove.
2143         (yylex, c_parse): Update.
2144
2145 2019-01-06  Tom Tromey  <tom@tromey.com>
2146
2147         * c-exp.y (struct c_parse_state) <strings>: New member.
2148         (operator_stoken): Update.
2149
2150 2019-01-06  Tom Tromey  <tom@tromey.com>
2151
2152         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2153         (union type_stack_elt) <typelist_val>: Now a pointer to
2154         std::vector.
2155         (type_stack_cleanup): Don't declare.
2156         (push_typelist): Update.
2157         * parse.c (pop_typelist): Return a std::vector.
2158         (push_typelist): Take a std::vector.
2159         (follow_types): Update.  Do not free args.
2160         (type_stack_cleanup): Remove.
2161         * c-exp.y (struct c_parse_state): New.
2162         (cpstate): New global.
2163         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2164         (nonempty_typelist): Update.
2165         (func_mod): Create a new vector.
2166         (c_parse): Create a c_parse_state.
2167         (check_parameter_typelist): Do not delete params.
2168         (function_method): Update.  Do not delete type_list.
2169
2170 2019-01-06  Tom Tromey  <tom@tromey.com>
2171
2172         PR gdb/28155:
2173         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2174         check_typedef.
2175         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2176         (print_return_value): Likewise.
2177
2178 2019-01-05  Tom Tromey  <tom@tromey.com>
2179
2180         * contrib/cleanup_check.py: Remove.
2181         * contrib/gcc-with-excheck: Remove.
2182         * contrib/exsummary.py: Remove.
2183         * contrib/excheck.py: Remove.
2184
2185 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2186
2187         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2188         NULL. Initialize tpprev to NULL instead of assigning it
2189         to NULL on the next statement.
2190         * windows-nat.c (windows_delete_thread): Remove check for
2191         main_thread_id before printing thread exit notifications.
2192         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2193         Remove thread ID check against main_thread_id.
2194         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2195         windows_delete_thread.
2196         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2197
2198 2019-01-04  Tom Tromey  <tom@tromey.com>
2199
2200         * compile/compile.c (_initialize_compile): Use upper case for
2201         metasyntactic variables.
2202         * symmisc.c (_initialize_symmisc): Use upper case for
2203         metasyntactic variables.
2204         * psymtab.c (_initialize_psymtab): Use upper case for
2205         metasyntactic variables.
2206         * demangle.c (demangle_command): Use upper case for metasyntactic
2207         variables.
2208         (_initialize_demangler): Likewise.
2209         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2210         variables.
2211
2212 2019-01-03  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2215
2216 2019-01-03  Tom Tromey  <tom@tromey.com>
2217
2218         * python/py-symtab.c (salpy_str): Update.
2219         (struct salpy_sal_object) <symtab>: Now a PyObject.
2220         (salpy_dealloc): Update.
2221         (del_objfile_sal): Use gdbpy_ref.
2222
2223 2019-01-03  Tom Tromey  <tom@tromey.com>
2224
2225         * python/py-type.c (convert_field): Use new_reference.  Return
2226         gdbpy_ref.
2227         (make_fielditem): Return gdbpy_ref.
2228         (typy_fields): Update.
2229         (typy_getitem): Update.
2230         (field_name): Return gdbpy_ref.  Use new_reference.
2231         (typy_iterator_iternext): Update.
2232
2233 2019-01-03  Tom Tromey  <tom@tromey.com>
2234
2235         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2236
2237 2019-01-03  Tom Tromey  <tom@tromey.com>
2238
2239         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2240         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2241         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2242         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2243         (pspy_set_type_printers): Likewise.
2244         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2245         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2246         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2247         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2248         (objfpy_set_type_printers): Likewise.
2249
2250 2019-01-03  Tom Tromey  <tom@tromey.com>
2251
2252         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2253         (gdbpy_print_stack): Use gdbpy_err_fetch.
2254         * python/python-internal.h (class gdbpy_err_fetch): New class.
2255         (class gdbpy_enter) <m_error_type, m_error_value,
2256         m_error_traceback>: Remove.
2257         <m_error>: New member.
2258         (gdbpy_exception_to_string): Don't declare.
2259         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2260         * python/py-value.c (convert_value_from_python): Use
2261         gdbpy_err_fetch.
2262         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2263         gdbpy_exception_to_string.
2264         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2265         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2266         gdbpy_err_fetch.
2267
2268 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2269
2270         * linux-nat.c (delete_lwp_cleanup): Delete.
2271         (struct lwp_deleter): New struct.
2272         (lwp_info_up): New typedef.
2273         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2274         lwp_info_up.
2275
2276 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2277
2278         * linux-fork.c (class scoped_switch_fork_info): New class.
2279         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2280
2281 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2282
2283         * valops.c (find_overload_match): Remove use of null_cleanup, and
2284         calls to do_cleanups.
2285
2286 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * compile/compile-cplus-types.c
2289         (compile_cplus_instance::decl_name): Handle changes to
2290         cp_func_name.
2291         * cp-support.c (cp_func_name): Update header comment, update
2292         return type.
2293         * cp-support.h (cp_func_name): Update return type in declaration.
2294         * valops.c (find_overload_match): Move temp_func local to top
2295         level of function and change its type.  Use temp_func to hold and
2296         delete temporary string obtained from cp_func_name.
2297
2298 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2299
2300         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2301         gdb::char_vector, remove cleanup, and update uses of `msg`.
2302
2303 2019-01-03  Jim Wilson  <jimw@sifive.com>
2304
2305         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2306
2307 2019-01-02  Tom Tromey  <tom@tromey.com>
2308
2309         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2310         (tdesc_parse_xml): Remove cleanups.
2311         * target-descriptions.h (make_cleanup_free_target_description):
2312         Don't declare.
2313         (target_desc_deleter): New struct.
2314         (target_desc_up): New typedef.
2315         * target-descriptions.c (target_desc_deleter::operator()): Rename
2316         from free_target_description.
2317         (make_cleanup_free_target_description): Remove.
2318
2319 2019-01-02  Tom Tromey  <tom@tromey.com>
2320
2321         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2322         constructor, destructor.
2323         (linespec_parser): Remove typedef.
2324         (~linespec_parser): Rename from linespec_parser_delete.
2325         (linespec_lex_to_end, linespec_complete_label)
2326         (linespec_complete): Update.
2327         (decode_line_full): Remove cleanups.
2328         (decode_line_1): Update.
2329
2330 2019-01-02  Tom Tromey  <tom@tromey.com>
2331
2332         * python/python-internal.h (inferior_to_inferior_object): Change
2333         return type.
2334         * python/py-exitedevent.c (create_exited_event_object): Update.
2335         * python/py-inferior.c (inferior_to_inferior_object): Return
2336         gdbpy_ref.
2337         (python_new_inferior, python_inferior_deleted)
2338         (thread_to_thread_object, delete_thread_object)
2339         (build_inferior_list, gdbpy_selected_inferior): Update.
2340         * python/py-infthread.c (create_thread_object): Update.  Also fail
2341         if inferior_to_inferior_object fails.
2342
2343 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2344
2345         * inferior.h (class inferior) <displaced_step_state>: New field.
2346         * infrun.h (struct displaced_step_state): Move here from
2347         infrun.c.  Initialize fields, add constructor.
2348         <inf>: Remove field.
2349         <reset>: New method.
2350         * infrun.c (struct displaced_step_inferior_state): Move to
2351         infrun.h.
2352         (displaced_step_inferior_states): Remove.
2353         (get_displaced_stepping_state): Adust.
2354         (displaced_step_in_progress_any_inferior): Adjust.
2355         (displaced_step_in_progress_thread): Adjust.
2356         (displaced_step_in_progress): Adjust.
2357         (add_displaced_stepping_state): Remove.
2358         (get_displaced_step_closure_by_addr): Adjust.
2359         (remove_displaced_stepping_state): Remove.
2360         (infrun_inferior_exit): Call displaced_step_state.reset.
2361         (use_displaced_stepping): Don't check for NULL.
2362         (displaced_step_prepare_throw): Call
2363         get_displaced_stepping_state.
2364         (displaced_step_fixup): Don't check for NULL.
2365         (prepare_for_detach): Don't check for NULL.
2366
2367 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2368
2369         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2370          in case of call that did not complete.
2371
2372 2019-01-02  Andrey Utkin  <autkin@undo.io>
2373
2374         * symfile.c (find_separate_debug_file): Fix search of debug files for
2375         remote debuggee.
2376
2377 2019-01-02  Tom Tromey  <tom@tromey.com>
2378
2379         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2380         indentation.
2381         * python/py-frame.c (frapy_older): Remove cast.
2382         (frapy_newer): Likewise.
2383         * python/py-breakpoint.c (local_setattro): Remove cast.
2384         * python/py-arch.c (archpy_name): Remove local variable.
2385         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2386
2387 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2388
2389         * unittests/basic_string_view/element_access/char/empty.cc:
2390         Fix year range in copyright header.
2391
2392 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2393
2394         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2395         Delete.
2396         <operator==>: Update with for removed field.
2397         <hash>: Likewise.
2398         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2399         <isa_features>: ...this.
2400         <abi_features>: New field.
2401         (riscv_isa_flen): Update comment.
2402         (riscv_abi_xlen): New declaration.
2403         (riscv_abi_flen): New declaration.
2404         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2405         isa_features.
2406         (riscv_abi_xlen): New function.
2407         (riscv_isa_flen): Update to get answer from isa_features.
2408         (riscv_abi_flen): New function.
2409         (riscv_has_fp_abi): Update to get answer from abi_features.
2410         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2411         xlen and flen.
2412         (riscv_call_info) <xlen, flen>: Update comment.
2413         (riscv_call_arg_struct): Remove invalid assertions
2414         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2415         is removed.
2416         (riscv_gdbarch_init): Gather isa features and abi features
2417         separately, ensure both match on the gdbarch when reusing an old
2418         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2419         a target with 64-bit float hardware.
2420
2421 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2422
2423         * source.c (search_command_helper): Stop reverse search
2424         when line 1 has been searched.
2425
2426 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2427
2428         * record-full.c (record_full_base_target::close): Rewrite
2429         record_full_core_buf_list free logic.
2430
2431 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2432
2433         * break-catch-syscall.c (print_one_catch_syscall): xfree
2434         the last text.
2435
2436 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2437
2438         * top.c (print_gdb_version): Update Copyright year in version
2439         message.
2440
2441 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2442
2443         Update copyright year range in all GDB files.
2444
2445 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2446
2447         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2448
2449 For older changes see ChangeLog-2018.
2450 \f
2451 Local Variables:
2452 mode: change-log
2453 left-margin: 8
2454 fill-column: 74
2455 version-control: never
2456 coding: utf-8
2457 End:
2458