gdb/ChangeLog

   1 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
   2
   3         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
   4         for-loop range, to avoid compiler warnings.
   5
   6         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
   7         avoid compiler warnings about unused variables.
   8
   9 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  10
  11         * NEWS: Mention end of support for native debugging on MS-Windows
  12         before XP.
  13
  14 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  15
  16         PR gdb/24292
  17         * common/netstuff.c:
  18         * gdbserver/gdbreplay.c
  19         * gdbserver/remote-utils.c:
  20         * ser-tcp.c:
  21         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
  22         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
  23         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
  24         'getaddrinfo' and 'freeaddrinfo' were not available before
  25         Windows XP, and mingw.org's MinGW headers by default define
  26         _WIN32_WINNT to 0x500.
  27
  28 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
  29
  30         * NEWS: Note minimum Python version.
  31
  32 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  33
  34         * version.in: Set GDB version number to 8.2.90.DATE-git.
  35
  36 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  37
  38         GDB 8.2.90 released.
  39
  40 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  41
  42         * version.in: Set GDB version number to 8.2.90.
  43
  44 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  45
  46         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
  47
  48 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  49
  50         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
  51         * version.in: Bump version to 8.2.90.DATE-git.
  52
  53 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
  54
  55         * aix-thread.c (ptid_cmp): Remove unused variable.
  56         (get_signaled_thread): Likewise.
  57         (store_regs_user_thread): Likewise.
  58         (store_regs_kernel_thread): Likewise.
  59         (fetch_regs_kernel_thread): Remove shadowed variable.
  60
  61 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  62
  63         * features/riscv/32bit-cpu.xml: Add register numbers.
  64         * features/riscv/32bit-fpu.c: Regenerate.
  65         * features/riscv/32bit-fpu.xml: Add register numbers.
  66         * features/riscv/64bit-cpu.xml: Add register numbers.
  67         * features/riscv/64bit-fpu.c: Regenerate.
  68         * features/riscv/64bit-fpu.xml: Add register numbers.
  69
  70 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
  71
  72         * NEWS: Mention two argument form of gdb.Value constructor.
  73         * python/py-value.c (convert_buffer_and_type_to_value): New
  74         function.
  75         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
  76         Add support for handling an optional second argument.  Call
  77         convert_buffer_and_type_to_value as appropriate.
  78         * python/python-internal.h (Py_buffer_deleter): New struct.
  79         (Py_buffer_up): New typedef.
  80
  81 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
  82
  83         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
  84         instead of releasing ownership.
  85
  86 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
  87
  88         * dwarf2read.c (open_and_init_dwp_file): Call
  89         elf_numsections instead of bfd_count_sections to initialize
  90         dwp_file->num_sections.
  91
  92 2019-02-25  Tom Tromey  <tromey@adacore.com>
  93
  94         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
  95
  96 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  97
  98         * gcore.in: Add '--readnever' option when invoking GDB.
  99
 100 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 101
 102         * MAINTAINERS: Update my email address.
 103
 104 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 105
 106         * build-id.c (build_id_to_debug_bfd_1): New function.
 107         (build_id_to_debug_bfd): Look for separate debug file in
 108         sysroot.
 109
 110 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 111
 112         * gdbarch.sh: Update the copyright year range that is placed into
 113         generated files.
 114
 115 2019-02-22  Keith Seitz  <keiths@redhat.com>
 116
 117         PR symtab/23853
 118         * linespec.c (create_sals_line_offset): Search for the default
 119         symtab's filename instead of its fullname.
 120
 121 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 122
 123         * NEWS: Update style defaults.
 124
 125 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 126
 127         * main.c (captured_main_1): Disable styling in batch mode.
 128
 129 2019-02-20  Tom Tromey  <tom@tromey.com>
 130
 131         * symtab.c (symtab_symbol_info): Fix typos.
 132
 133 2019-02-20  Tom Tromey  <tromey@adacore.com>
 134
 135         * findcmd.c (_initialize_mem_search): Use upper case for
 136         metasyntactic variables.
 137
 138 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 139
 140         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 141         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 142
 143 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 144
 145         * top.h (source_file_name): Change to std::string.
 146         * top.c (source_file_name): Likewise.
 147         (command_line_input): Adjust.
 148         * cli/cli-script.c (script_from_file): Adjust.
 149
 150 2019-02-19  Tom Tromey  <tromey@adacore.com>
 151
 152         * ravenscar-thread.c
 153         (ravenscar_thread_target::update_thread_list): Don't call
 154         ada_build_task_list.
 155         * ada-lang.h (ada_build_task_list): Don't declare.
 156         * ada-tasks.c (struct ada_tasks_inferior_data)
 157         <task_list_valid_p>: Now bool.
 158         (read_known_tasks, ada_task_list_changed)
 159         (ada_tasks_invalidate_inferior_data): Update.
 160         (read_known_tasks_array): Return bool.
 161         (read_known_tasks_list): Likewise.
 162         (read_known_tasks): Return void.
 163         (ada_build_task_list): Now static.
 164
 165 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 166
 167         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 168         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 169
 170 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 171
 172         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 173         variant for ada_tasks_pspace_data_handle and
 174         ada_tasks_inferior_data_handle.
 175         (ada_tasks_pspace_data_cleanup): New function.
 176         (ada_tasks_inferior_data_cleanup): New function.
 177
 178 2019-02-17  Tom Tromey  <tom@tromey.com>
 179
 180         * macrotab.h (macro_source_fullname): Return a std::string.
 181         * macrotab.c (macro_include, check_for_redefinition)
 182         (macro_undef, macro_lookup_definition, foreach_macro)
 183         (foreach_macro_in_scope): Update.
 184         (macro_source_fullname): Return a std::string.
 185         * macrocmd.c (show_pp_source_pos): Update.
 186
 187 2019-02-17  Tom Tromey  <tom@tromey.com>
 188
 189         * macrocmd.c (show_pp_source_pos): Style the file names.
 190
 191 2019-02-17  Tom Tromey  <tom@tromey.com>
 192
 193         PR tui/24197:
 194         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 195
 196 2019-02-17  Tom Tromey  <tom@tromey.com>
 197
 198         * ada-lang.c (user_select_syms): Use filtered printing.
 199         * utils.c (wrap_style): New global.
 200         (desired_style): Remove.
 201         (emit_style_escape): Add stream parameter.
 202         (set_output_style, reset_terminal_style, prompt_for_continue):
 203         Update.
 204         (flush_wrap_buffer): Only flush gdb_stdout.
 205         (wrap_here): Set wrap_style.
 206         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 207         treat escape sequences as a character.  Change when wrap buffer is
 208         flushed.
 209         (fputs_styled): Do not set the output style when the default is
 210         requested.
 211         * ui-style.h (struct ui_file_style) <is_default>: New method.
 212         * source.c (print_source_lines_base): Emit escape sequences in one
 213         piece.
 214
 215 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 216
 217         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 218         integers and enumeration types.
 219
 220 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 221
 222         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 223         instead of lookup_symbol_in_language
 224         (do_exact_match): New function.
 225         (ada_get_symbol_name_matcher): Return do_exact_match when
 226         doing a verbatim match.
 227
 228 2019-02-15  Tom Tromey  <tromey@adacore.com>
 229
 230         * ravenscar-thread.c (ravenscar_thread_target::resume)
 231         (ravenscar_thread_target::wait): Special case wildcard requests.
 232
 233 2019-02-15  Tom Tromey  <tromey@adacore.com>
 234
 235         * ravenscar-thread.c (base_ptid): Remove.
 236         (struct ravenscar_thread_target) <close>: New method.
 237         <m_base_ptid>: New member.
 238         <update_inferior_ptid, active_task, task_is_currently_active,
 239         runtime_initialized>: Declare methods.
 240         <ravenscar_thread_target>: Add constructor.
 241         (ravenscar_thread_target::task_is_currently_active)
 242         (ravenscar_thread_target::update_inferior_ptid)
 243         (ravenscar_runtime_initialized): Rename.  Now methods.
 244         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 245         (ravenscar_thread_target::update_thread_list): Update.
 246         (ravenscar_thread_target::active_task): Now method.
 247         (ravenscar_thread_target::store_registers)
 248         (ravenscar_thread_target::prepare_to_store)
 249         (ravenscar_thread_target::prepare_to_store)
 250         (ravenscar_thread_target::mourn_inferior): Update.
 251         (ravenscar_inferior_created): Use "new" to create target.
 252         (ravenscar_thread_target::get_ada_task_ptid): Update.
 253         (_initialize_ravenscar): Don't initialize base_ptid.
 254         (ravenscar_ops): Remove global.
 255
 256 2019-02-15  Tom Tromey  <tromey@adacore.com>
 257
 258         * target.h (push_target): Declare new overload.
 259         * target.c (push_target): New overload, taking an rvalue reference.
 260         * remote.c (remote_target::open_1): Use push_target overload.
 261         * corelow.c (core_target_open): Use push_target overload.
 262
 263 2019-02-15  Tom Tromey  <tromey@adacore.com>
 264
 265         * ravenscar-thread.c (is_ravenscar_task)
 266         (ravenscar_task_is_currently_active): Return bool.
 267         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 268         (_initialize_ravenscar): Remove "(void)".
 269         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 270         Return bool.
 271
 272 2019-02-15  Tom Tromey  <tromey@adacore.com>
 273
 274         * ravenscar-thread.c (ravenscar_runtime_initializer)
 275         (has_ravenscar_runtime, get_running_thread_id)
 276         (ravenscar_thread_target::resume): Fix indentation.
 277
 278 2019-02-15  Tom Tromey  <tromey@adacore.com>
 279
 280         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 281         from ravenscar_arch_ops.
 282         (sparc_ravenscar_ops::fetch_registers)
 283         (sparc_ravenscar_ops::store_registers): Now methods.
 284         (sparc_ravenscar_prepare_to_store): Remove.
 285         (sparc_ravenscar_ops): Redefine.
 286         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 287         methods and destructor.  Remove members.
 288         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 289         (ravenscar_thread_target::store_registers)
 290         (ravenscar_thread_target::prepare_to_store): Update.
 291         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 292         Remove.
 293         (struct ppc_ravenscar_powerpc_ops): Derive from
 294         ravenscar_arch_ops.
 295         (ppc_ravenscar_powerpc_ops::fetch_registers)
 296         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 297         (ppc_ravenscar_powerpc_ops): Redefine.
 298         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 299         (ppc_ravenscar_e500_ops::fetch_registers)
 300         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 301         (ppc_ravenscar_e500_ops): Redefine.
 302         * aarch64-ravenscar-thread.c
 303         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 304         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 305         (aarch64_ravenscar_fetch_registers)
 306         (aarch64_ravenscar_store_registers): Now methods.
 307         (aarch64_ravenscar_ops): Redefine.
 308
 309 2019-02-15  Tom Tromey  <tromey@adacore.com>
 310
 311         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 312         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 313         (ravenscar_thread_target::stopped_by_watchpoint)
 314         (ravenscar_thread_target::stopped_data_address)
 315         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 316
 317 2019-02-15  Tom Tromey  <tromey@adacore.com>
 318
 319         * ravenscar-thread.c: Fix some typos.
 320
 321 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 322             Tom Tromey  <tromey@adacore.com>
 323
 324         * ada-lang.c (ada_exception_sal): Change addr_string to a
 325         std::string.
 326         (create_ada_exception_catchpoint): Update.
 327
 328 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 329             Tom Tromey  <tromey@adacore.com>
 330
 331         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 332         (bp_location_ops): Remove.
 333         (base_breakpoint_allocate_location): Update.
 334         (free_bp_location): Update.
 335         * ada-lang.c (class ada_catchpoint_location)
 336         <ada_catchpoint_location>: Remove ops parameter.
 337         (ada_catchpoint_location_dtor): Remove.
 338         (ada_catchpoint_location_ops): Remove.
 339         (allocate_location_exception): Update.
 340         * breakpoint.h (struct bp_location_ops): Remove.
 341         (class bp_location) <bp_location>: Remove bp_location_ops
 342         parameter.
 343         <~bp_location>: Add destructor.
 344         <ops>: Remove.
 345
 346 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 347             Pedro Alves  <palves@redhat.com>
 348
 349         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 350         'PATH_MAX'.
 351
 352 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 353             Samuel Thibault  <samuel.thibault@gnu.org>
 354             Thomas Schwinge  <thomas@codesourcery.com>
 355
 356         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 357         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 358
 359 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 360
 361         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 362         (check_empty): Use "const char *".
 363
 364         * gnu-nat.c (gnu_nat_target::detach): Instead of
 365         'detach_inferior (pid)' call
 366         'detach_inferior (find_inferior_pid (pid))'.
 367
 368         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 369         'nat/fork-inferior.o'.
 370         * gnu-nat.c: #include "nat/fork-inferior.h".
 371
 372         * gnu-nat.c (gnu_nat_target::detach): Instead of
 373         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 374         * gnu-nat.h: #include "inf-child.h".
 375         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 376         'i386_gnu_nat_target::fetch_registers'.
 377         (gnu_store_registers): Rename/move to
 378         'i386_gnu_nat_target::store_registers'.
 379
 380         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 381         * gnu-nat.h (mach_thread_info): New function.
 382         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 383
 384         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 385
 386 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 387
 388         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 389
 390 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 391
 392         * windows-nat.c (windows_add_thread): Add new parameter
 393         "main_thread_p" with default value set to false.  Update
 394         function documentation as well as all callers.
 395         (windows_delete_thread): Likewise.
 396         (fake_create_process): Update call to windows_add_thread.
 397         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 398         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 399         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 400         call to windows_delete_thread.
 401
 402 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 403
 404         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 405
 406 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 407
 408         * symfile.c (find_separate_debug_file): Use canonical path of
 409         sysroot with child_path instead of gdb_sysroot if it is valid.
 410
 411 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 412
 413         * symfile.c (find_separate_debug_file): Use child_path to
 414         determine if an object file is under a sysroot.
 415
 416 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 417
 418         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 419         unittests/child-path-selftests.c.
 420         * common/pathstuff.c (child_path): New function.
 421         * common/pathstuff.h (child_path): New prototype.
 422         * unittests/child-path-selftests.c: New file.
 423
 424 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 425
 426         * symfile.c (find_separate_debug_file): Look for separate debug
 427         files in debug directories under the sysroot.
 428
 429 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 430
 431         * symtab.h (struct minimal_symbol data_p): New const method.
 432         (struct minimal_symbol text_p): Likewise.
 433         * symtab.c (output_source_filename): Use file name style
 434         to print file name.
 435         (print_symbol_info): Likewise.
 436         (print_msymbol_info): Use address style to print addresses.
 437         Use function name style to print executable text symbols.
 438         (expand_symtab_containing_pc): Use data_p.
 439         (find_pc_sect_compunit_symtab): Likewise.
 440
 441 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 442
 443         * breakpoint.c (describe_other_breakpoints): Use address style
 444         to print addresses.
 445         (say_where): Likewise.
 446
 447 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 448
 449         * ada-typeprint.c (print_func_type): Print function name
 450         style to print function name.
 451         * c-typeprint.c (c_print_type_1): Likewise.
 452
 453 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 454
 455         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 456         for execve.
 457
 458 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 459
 460         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 461         type_stack.
 462
 463 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 464
 465         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 466         TYPE_CODE_REF types.
 467
 468 2019-02-08  Jim Wilson  <jimw@sifive.com>
 469
 470         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 471         (riscv_linux_fregset): New.
 472         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 473
 474 2019-02-07  Tom Tromey  <tom@tromey.com>
 475
 476         * thread.c (thread_cancel_execution_command): Update.
 477         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 478         methods.
 479         (struct thread_fsm_ops): Remove.
 480         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 481         (thread_fsm_should_stop, thread_fsm_return_value)
 482         (thread_fsm_set_finished, thread_fsm_finished_p)
 483         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 484         Don't declare.
 485         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 486         * infrun.c (clear_proceed_status_thread)
 487         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 488         (print_stop_event): Update.
 489         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 490         Add constructor.
 491         (step_command_fsm_ops): Remove.
 492         (new_step_command_fsm): Remove.
 493         (step_1): Update.
 494         (step_command_fsm::should_stop): Rename from
 495         step_command_fsm_should_stop.
 496         (step_command_fsm::clean_up): Rename from
 497         step_command_fsm_clean_up.
 498         (step_command_fsm::do_async_reply_reason): Rename from
 499         step_command_fsm_async_reply_reason.
 500         (struct until_next_fsm): Inherit from thread_fsm.  Add
 501         constructor.
 502         (until_next_fsm_ops): Remove.
 503         (new_until_next_fsm): Remove.
 504         (until_next_fsm::should_stop): Rename from
 505         until_next_fsm_should_stop.
 506         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 507         (until_next_fsm::do_async_reply_reason): Rename from
 508         until_next_fsm_async_reply_reason.
 509         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 510         constructor.  Change type of breakpoint.
 511         (finish_command_fsm_ops): Remove.
 512         (new_finish_command_fsm): Remove.
 513         (finish_command_fsm::should_stop): Rename from
 514         finish_command_fsm_should_stop.
 515         (finish_command_fsm::clean_up): Rename from
 516         finish_command_fsm_clean_up.
 517         (finish_command_fsm::return_value): Rename from
 518         finish_command_fsm_return_value.
 519         (finish_command_fsm::do_async_reply_reason): Rename from
 520         finish_command_fsm_async_reply_reason.
 521         (finish_command): Update.
 522         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 523         Add constructor.
 524         (call_thread_fsm_ops): Remove.
 525         (call_thread_fsm::call_thread_fsm): Rename from
 526         new_call_thread_fsm.
 527         (call_thread_fsm::should_stop): Rename from
 528         call_thread_fsm_should_stop.
 529         (call_thread_fsm::should_notify_stop): Rename from
 530         call_thread_fsm_should_notify_stop.
 531         (run_inferior_call, call_function_by_hand_dummy): Update.
 532         * cli/cli-interp.c (should_print_stop_to_console): Update.
 533         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 534         Add constructor.  Change type of location_breakpoint,
 535         caller_breakpoint.
 536         (until_break_fsm_ops): Remove.
 537         (new_until_break_fsm): Remove.
 538         (until_break_fsm::should_stop): Rename from
 539         until_break_fsm_should_stop.
 540         (until_break_fsm::clean_up): Rename from
 541         until_break_fsm_clean_up.
 542         (until_break_fsm::do_async_reply_reason): Rename from
 543         until_break_fsm_async_reply_reason.
 544         (until_break_command): Update.
 545         * thread-fsm.c: Remove.
 546         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 547
 548 2019-02-07  Tom Tromey  <tom@tromey.com>
 549
 550         * yy-remap.h: Add include guard.
 551         * xtensa-tdep.h: Add include guard.
 552         * xcoffread.h: Rename include guard.
 553         * varobj-iter.h: Add include guard.
 554         * tui/tui.h: Rename include guard.
 555         * tui/tui-winsource.h: Rename include guard.
 556         * tui/tui-wingeneral.h: Rename include guard.
 557         * tui/tui-windata.h: Rename include guard.
 558         * tui/tui-win.h: Rename include guard.
 559         * tui/tui-stack.h: Rename include guard.
 560         * tui/tui-source.h: Rename include guard.
 561         * tui/tui-regs.h: Rename include guard.
 562         * tui/tui-out.h: Rename include guard.
 563         * tui/tui-layout.h: Rename include guard.
 564         * tui/tui-io.h: Rename include guard.
 565         * tui/tui-hooks.h: Rename include guard.
 566         * tui/tui-file.h: Rename include guard.
 567         * tui/tui-disasm.h: Rename include guard.
 568         * tui/tui-data.h: Rename include guard.
 569         * tui/tui-command.h: Rename include guard.
 570         * tic6x-tdep.h: Add include guard.
 571         * target/waitstatus.h: Rename include guard.
 572         * target/wait.h: Rename include guard.
 573         * target/target.h: Rename include guard.
 574         * target/resume.h: Rename include guard.
 575         * target-float.h: Rename include guard.
 576         * stabsread.h: Add include guard.
 577         * rs6000-tdep.h: Add include guard.
 578         * riscv-fbsd-tdep.h: Add include guard.
 579         * regformats/regdef.h: Rename include guard.
 580         * record.h: Rename include guard.
 581         * python/python.h: Rename include guard.
 582         * python/python-internal.h: Rename include guard.
 583         * python/py-stopevent.h: Rename include guard.
 584         * python/py-ref.h: Rename include guard.
 585         * python/py-record.h: Rename include guard.
 586         * python/py-record-full.h: Rename include guard.
 587         * python/py-record-btrace.h: Rename include guard.
 588         * python/py-instruction.h: Rename include guard.
 589         * python/py-events.h: Rename include guard.
 590         * python/py-event.h: Rename include guard.
 591         * procfs.h: Add include guard.
 592         * proc-utils.h: Add include guard.
 593         * p-lang.h: Add include guard.
 594         * or1k-tdep.h: Rename include guard.
 595         * observable.h: Rename include guard.
 596         * nto-tdep.h: Rename include guard.
 597         * nat/x86-linux.h: Rename include guard.
 598         * nat/x86-linux-dregs.h: Rename include guard.
 599         * nat/x86-gcc-cpuid.h: Add include guard.
 600         * nat/x86-dregs.h: Rename include guard.
 601         * nat/x86-cpuid.h: Rename include guard.
 602         * nat/ppc-linux.h: Rename include guard.
 603         * nat/mips-linux-watch.h: Rename include guard.
 604         * nat/linux-waitpid.h: Rename include guard.
 605         * nat/linux-ptrace.h: Rename include guard.
 606         * nat/linux-procfs.h: Rename include guard.
 607         * nat/linux-osdata.h: Rename include guard.
 608         * nat/linux-nat.h: Rename include guard.
 609         * nat/linux-namespaces.h: Rename include guard.
 610         * nat/linux-btrace.h: Rename include guard.
 611         * nat/glibc_thread_db.h: Rename include guard.
 612         * nat/gdb_thread_db.h: Rename include guard.
 613         * nat/gdb_ptrace.h: Rename include guard.
 614         * nat/fork-inferior.h: Rename include guard.
 615         * nat/amd64-linux-siginfo.h: Rename include guard.
 616         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 617         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 618         * nat/aarch64-linux.h: Rename include guard.
 619         * nat/aarch64-linux-hw-point.h: Rename include guard.
 620         * mn10300-tdep.h: Add include guard.
 621         * mips-linux-tdep.h: Add include guard.
 622         * mi/mi-parse.h: Rename include guard.
 623         * mi/mi-out.h: Rename include guard.
 624         * mi/mi-main.h: Rename include guard.
 625         * mi/mi-interp.h: Rename include guard.
 626         * mi/mi-getopt.h: Rename include guard.
 627         * mi/mi-console.h: Rename include guard.
 628         * mi/mi-common.h: Rename include guard.
 629         * mi/mi-cmds.h: Rename include guard.
 630         * mi/mi-cmd-break.h: Rename include guard.
 631         * m2-lang.h: Add include guard.
 632         * location.h: Rename include guard.
 633         * linux-record.h: Rename include guard.
 634         * linux-nat.h: Add include guard.
 635         * linux-fork.h: Add include guard.
 636         * i386-darwin-tdep.h: Rename include guard.
 637         * hppa-linux-offsets.h: Add include guard.
 638         * guile/guile.h: Rename include guard.
 639         * guile/guile-internal.h: Rename include guard.
 640         * gnu-nat.h: Rename include guard.
 641         * gdb-stabs.h: Rename include guard.
 642         * frv-tdep.h: Add include guard.
 643         * f-lang.h: Add include guard.
 644         * event-loop.h: Add include guard.
 645         * darwin-nat.h: Rename include guard.
 646         * cp-abi.h: Rename include guard.
 647         * config/sparc/nm-sol2.h: Rename include guard.
 648         * config/nm-nto.h: Rename include guard.
 649         * config/nm-linux.h: Add include guard.
 650         * config/i386/nm-i386gnu.h: Rename include guard.
 651         * config/djgpp/nl_types.h: Rename include guard.
 652         * config/djgpp/langinfo.h: Rename include guard.
 653         * compile/gcc-cp-plugin.h: Add include guard.
 654         * compile/gcc-c-plugin.h: Add include guard.
 655         * compile/compile.h: Rename include guard.
 656         * compile/compile-object-run.h: Rename include guard.
 657         * compile/compile-object-load.h: Rename include guard.
 658         * compile/compile-internal.h: Rename include guard.
 659         * compile/compile-cplus.h: Rename include guard.
 660         * compile/compile-c.h: Rename include guard.
 661         * common/xml-utils.h: Rename include guard.
 662         * common/x86-xstate.h: Rename include guard.
 663         * common/version.h: Rename include guard.
 664         * common/vec.h: Rename include guard.
 665         * common/tdesc.h: Rename include guard.
 666         * common/selftest.h: Rename include guard.
 667         * common/scoped_restore.h: Rename include guard.
 668         * common/scoped_mmap.h: Rename include guard.
 669         * common/scoped_fd.h: Rename include guard.
 670         * common/safe-iterator.h: Rename include guard.
 671         * common/run-time-clock.h: Rename include guard.
 672         * common/refcounted-object.h: Rename include guard.
 673         * common/queue.h: Rename include guard.
 674         * common/ptid.h: Rename include guard.
 675         * common/print-utils.h: Rename include guard.
 676         * common/preprocessor.h: Rename include guard.
 677         * common/pathstuff.h: Rename include guard.
 678         * common/observable.h: Rename include guard.
 679         * common/netstuff.h: Rename include guard.
 680         * common/job-control.h: Rename include guard.
 681         * common/host-defs.h: Rename include guard.
 682         * common/gdb_wait.h: Rename include guard.
 683         * common/gdb_vecs.h: Rename include guard.
 684         * common/gdb_unlinker.h: Rename include guard.
 685         * common/gdb_unique_ptr.h: Rename include guard.
 686         * common/gdb_tilde_expand.h: Rename include guard.
 687         * common/gdb_sys_time.h: Rename include guard.
 688         * common/gdb_string_view.h: Rename include guard.
 689         * common/gdb_splay_tree.h: Rename include guard.
 690         * common/gdb_setjmp.h: Rename include guard.
 691         * common/gdb_ref_ptr.h: Rename include guard.
 692         * common/gdb_optional.h: Rename include guard.
 693         * common/gdb_locale.h: Rename include guard.
 694         * common/gdb_assert.h: Rename include guard.
 695         * common/filtered-iterator.h: Rename include guard.
 696         * common/filestuff.h: Rename include guard.
 697         * common/fileio.h: Rename include guard.
 698         * common/environ.h: Rename include guard.
 699         * common/common-utils.h: Rename include guard.
 700         * common/common-types.h: Rename include guard.
 701         * common/common-regcache.h: Rename include guard.
 702         * common/common-inferior.h: Rename include guard.
 703         * common/common-gdbthread.h: Rename include guard.
 704         * common/common-exceptions.h: Rename include guard.
 705         * common/common-defs.h: Rename include guard.
 706         * common/common-debug.h: Rename include guard.
 707         * common/cleanups.h: Rename include guard.
 708         * common/buffer.h: Rename include guard.
 709         * common/btrace-common.h: Rename include guard.
 710         * common/break-common.h: Rename include guard.
 711         * cli/cli-utils.h: Rename include guard.
 712         * cli/cli-style.h: Rename include guard.
 713         * cli/cli-setshow.h: Rename include guard.
 714         * cli/cli-script.h: Rename include guard.
 715         * cli/cli-interp.h: Rename include guard.
 716         * cli/cli-decode.h: Rename include guard.
 717         * cli/cli-cmds.h: Rename include guard.
 718         * charset-list.h: Add include guard.
 719         * buildsym-legacy.h: Rename include guard.
 720         * bfin-tdep.h: Add include guard.
 721         * ax.h: Rename include guard.
 722         * arm-linux-tdep.h: Add include guard.
 723         * arm-fbsd-tdep.h: Add include guard.
 724         * arch/xtensa.h: Rename include guard.
 725         * arch/tic6x.h: Add include guard.
 726         * arch/i386.h: Add include guard.
 727         * arch/arm.h: Rename include guard.
 728         * arch/arm-linux.h: Rename include guard.
 729         * arch/arm-get-next-pcs.h: Rename include guard.
 730         * arch/amd64.h: Add include guard.
 731         * arch/aarch64-insn.h: Rename include guard.
 732         * arch-utils.h: Rename include guard.
 733         * annotate.h: Add include guard.
 734         * amd64-darwin-tdep.h: Rename include guard.
 735         * aarch64-linux-tdep.h: Add include guard.
 736         * aarch64-fbsd-tdep.h: Add include guard.
 737         * aarch32-linux-nat.h: Add include guard.
 738
 739 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 740
 741         * macrotab.c (macro_define_internal): New function that
 742         factorizes macro_define_object_internal and macro_define_function
 743         code.
 744         (macro_define_object_internal): Use macro_define_internal.
 745         (macro_define_function): Likewise.
 746
 747 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 748
 749         * macrocmd.c (extract_identifier): Return
 750         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 751         callers.
 752
 753 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 754
 755         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 756
 757 2019-02-05  Tom Tromey  <tom@tromey.com>
 758
 759         * target.c (target_stack::unpush): Move assertion earlier.
 760
 761 2019-01-30  Tom Tromey  <tom@tromey.com>
 762
 763         PR python/23615:
 764         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 765         (gdbpy_parse_and_eval): Likewise.
 766         * python/python-internal.h (gdbpy_allow_threads): New class.
 767
 768 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 769
 770         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 771         (aarch64_fbsd_fpregmap): Move earlier.
 772         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 773         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 774         instead of individual calls to trad_frame_set_reg_addr.
 775         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 776         earlier.
 777         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 778         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 779         instead of individual calls to trad_frame_set_reg_addr.
 780
 781 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 782
 783         * CONTRIBUTE: Replace contribution list with wiki link.
 784
 785 2019-01-25  Tom Tromey  <tom@tromey.com>
 786
 787         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 788
 789 2019-01-25  Tom Tromey  <tom@tromey.com>
 790
 791         * xtensa-linux-nat.c: Fix common/ includes.
 792         * xml-support.h: Fix common/ includes.
 793         * xml-support.c: Fix common/ includes.
 794         * x86-linux-nat.c: Fix common/ includes.
 795         * windows-nat.c: Fix common/ includes.
 796         * varobj.h: Fix common/ includes.
 797         * varobj.c: Fix common/ includes.
 798         * value.c: Fix common/ includes.
 799         * valops.c: Fix common/ includes.
 800         * utils.c: Fix common/ includes.
 801         * unittests/xml-utils-selftests.c: Fix common/ includes.
 802         * unittests/utils-selftests.c: Fix common/ includes.
 803         * unittests/unpack-selftests.c: Fix common/ includes.
 804         * unittests/tracepoint-selftests.c: Fix common/ includes.
 805         * unittests/style-selftests.c: Fix common/ includes.
 806         * unittests/string_view-selftests.c: Fix common/ includes.
 807         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 808         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 809         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 810         * unittests/rsp-low-selftests.c: Fix common/ includes.
 811         * unittests/parse-connection-spec-selftests.c: Fix common/
 812         includes.
 813         * unittests/optional-selftests.c: Fix common/ includes.
 814         * unittests/offset-type-selftests.c: Fix common/ includes.
 815         * unittests/observable-selftests.c: Fix common/ includes.
 816         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 817         * unittests/memrange-selftests.c: Fix common/ includes.
 818         * unittests/memory-map-selftests.c: Fix common/ includes.
 819         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 820         * unittests/function-view-selftests.c: Fix common/ includes.
 821         * unittests/environ-selftests.c: Fix common/ includes.
 822         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 823         * unittests/common-utils-selftests.c: Fix common/ includes.
 824         * unittests/cli-utils-selftests.c: Fix common/ includes.
 825         * unittests/array-view-selftests.c: Fix common/ includes.
 826         * ui-file.c: Fix common/ includes.
 827         * tui/tui-io.c: Fix common/ includes.
 828         * tracepoint.h: Fix common/ includes.
 829         * tracepoint.c: Fix common/ includes.
 830         * tracefile-tfile.c: Fix common/ includes.
 831         * top.h: Fix common/ includes.
 832         * top.c: Fix common/ includes.
 833         * thread.c: Fix common/ includes.
 834         * target/waitstatus.h: Fix common/ includes.
 835         * target/waitstatus.c: Fix common/ includes.
 836         * target.h: Fix common/ includes.
 837         * target.c: Fix common/ includes.
 838         * target-memory.c: Fix common/ includes.
 839         * target-descriptions.c: Fix common/ includes.
 840         * symtab.h: Fix common/ includes.
 841         * symfile.c: Fix common/ includes.
 842         * stap-probe.c: Fix common/ includes.
 843         * spu-linux-nat.c: Fix common/ includes.
 844         * sparc-nat.c: Fix common/ includes.
 845         * source.c: Fix common/ includes.
 846         * solib.c: Fix common/ includes.
 847         * solib-target.c: Fix common/ includes.
 848         * ser-unix.c: Fix common/ includes.
 849         * ser-tcp.c: Fix common/ includes.
 850         * ser-pipe.c: Fix common/ includes.
 851         * ser-base.c: Fix common/ includes.
 852         * selftest-arch.c: Fix common/ includes.
 853         * s12z-tdep.c: Fix common/ includes.
 854         * rust-exp.y: Fix common/ includes.
 855         * rs6000-aix-tdep.c: Fix common/ includes.
 856         * riscv-tdep.c: Fix common/ includes.
 857         * remote.c: Fix common/ includes.
 858         * remote-notif.h: Fix common/ includes.
 859         * remote-fileio.h: Fix common/ includes.
 860         * remote-fileio.c: Fix common/ includes.
 861         * regcache.h: Fix common/ includes.
 862         * regcache.c: Fix common/ includes.
 863         * record-btrace.c: Fix common/ includes.
 864         * python/python.c: Fix common/ includes.
 865         * python/py-type.c: Fix common/ includes.
 866         * python/py-inferior.c: Fix common/ includes.
 867         * progspace.h: Fix common/ includes.
 868         * producer.c: Fix common/ includes.
 869         * procfs.c: Fix common/ includes.
 870         * proc-api.c: Fix common/ includes.
 871         * printcmd.c: Fix common/ includes.
 872         * ppc-linux-nat.c: Fix common/ includes.
 873         * parser-defs.h: Fix common/ includes.
 874         * osdata.c: Fix common/ includes.
 875         * obsd-nat.c: Fix common/ includes.
 876         * nat/x86-linux.c: Fix common/ includes.
 877         * nat/x86-linux-dregs.c: Fix common/ includes.
 878         * nat/x86-dregs.h: Fix common/ includes.
 879         * nat/x86-dregs.c: Fix common/ includes.
 880         * nat/ppc-linux.c: Fix common/ includes.
 881         * nat/mips-linux-watch.h: Fix common/ includes.
 882         * nat/mips-linux-watch.c: Fix common/ includes.
 883         * nat/linux-waitpid.c: Fix common/ includes.
 884         * nat/linux-ptrace.h: Fix common/ includes.
 885         * nat/linux-ptrace.c: Fix common/ includes.
 886         * nat/linux-procfs.c: Fix common/ includes.
 887         * nat/linux-personality.c: Fix common/ includes.
 888         * nat/linux-osdata.c: Fix common/ includes.
 889         * nat/linux-namespaces.c: Fix common/ includes.
 890         * nat/linux-btrace.h: Fix common/ includes.
 891         * nat/linux-btrace.c: Fix common/ includes.
 892         * nat/fork-inferior.c: Fix common/ includes.
 893         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 894         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 895         * nat/aarch64-linux.c: Fix common/ includes.
 896         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 897         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 898         * namespace.h: Fix common/ includes.
 899         * mips-linux-tdep.c: Fix common/ includes.
 900         * minsyms.c: Fix common/ includes.
 901         * mi/mi-parse.h: Fix common/ includes.
 902         * mi/mi-main.c: Fix common/ includes.
 903         * mi/mi-cmd-env.c: Fix common/ includes.
 904         * memrange.h: Fix common/ includes.
 905         * memattr.c: Fix common/ includes.
 906         * maint.h: Fix common/ includes.
 907         * maint.c: Fix common/ includes.
 908         * main.c: Fix common/ includes.
 909         * machoread.c: Fix common/ includes.
 910         * location.c: Fix common/ includes.
 911         * linux-thread-db.c: Fix common/ includes.
 912         * linux-nat.c: Fix common/ includes.
 913         * linux-fork.c: Fix common/ includes.
 914         * inline-frame.c: Fix common/ includes.
 915         * infrun.c: Fix common/ includes.
 916         * inflow.c: Fix common/ includes.
 917         * inferior.h: Fix common/ includes.
 918         * inferior.c: Fix common/ includes.
 919         * infcmd.c: Fix common/ includes.
 920         * inf-ptrace.c: Fix common/ includes.
 921         * inf-child.c: Fix common/ includes.
 922         * ia64-linux-nat.c: Fix common/ includes.
 923         * i387-tdep.c: Fix common/ includes.
 924         * i386-tdep.c: Fix common/ includes.
 925         * i386-linux-tdep.c: Fix common/ includes.
 926         * i386-linux-nat.c: Fix common/ includes.
 927         * i386-go32-tdep.c: Fix common/ includes.
 928         * i386-fbsd-tdep.c: Fix common/ includes.
 929         * i386-fbsd-nat.c: Fix common/ includes.
 930         * guile/scm-type.c: Fix common/ includes.
 931         * guile/guile.c: Fix common/ includes.
 932         * go32-nat.c: Fix common/ includes.
 933         * gnu-nat.c: Fix common/ includes.
 934         * gdbthread.h: Fix common/ includes.
 935         * gdbarch-selftests.c: Fix common/ includes.
 936         * gdb_usleep.c: Fix common/ includes.
 937         * gdb_select.h: Fix common/ includes.
 938         * gdb_bfd.c: Fix common/ includes.
 939         * gcore.c: Fix common/ includes.
 940         * fork-child.c: Fix common/ includes.
 941         * findvar.c: Fix common/ includes.
 942         * fbsd-nat.c: Fix common/ includes.
 943         * event-top.c: Fix common/ includes.
 944         * event-loop.c: Fix common/ includes.
 945         * dwarf2read.c: Fix common/ includes.
 946         * dwarf2loc.c: Fix common/ includes.
 947         * dwarf2-frame.c: Fix common/ includes.
 948         * dwarf-index-cache.c: Fix common/ includes.
 949         * dtrace-probe.c: Fix common/ includes.
 950         * disasm-selftests.c: Fix common/ includes.
 951         * defs.h: Fix common/ includes.
 952         * csky-tdep.c: Fix common/ includes.
 953         * cp-valprint.c: Fix common/ includes.
 954         * cp-support.h: Fix common/ includes.
 955         * cp-support.c: Fix common/ includes.
 956         * corelow.c: Fix common/ includes.
 957         * completer.h: Fix common/ includes.
 958         * completer.c: Fix common/ includes.
 959         * compile/compile.c: Fix common/ includes.
 960         * compile/compile-loc2c.c: Fix common/ includes.
 961         * compile/compile-cplus-types.c: Fix common/ includes.
 962         * compile/compile-cplus-symbols.c: Fix common/ includes.
 963         * command.h: Fix common/ includes.
 964         * cli/cli-dump.c: Fix common/ includes.
 965         * cli/cli-cmds.c: Fix common/ includes.
 966         * charset.c: Fix common/ includes.
 967         * build-id.c: Fix common/ includes.
 968         * btrace.h: Fix common/ includes.
 969         * btrace.c: Fix common/ includes.
 970         * breakpoint.h: Fix common/ includes.
 971         * breakpoint.c: Fix common/ includes.
 972         * ax.h:
 973         (enum agent_op): Fix common/ includes.
 974         * ax-general.c (struct aop_map): Fix common/ includes.
 975         * ax-gdb.c: Fix common/ includes.
 976         * auxv.c: Fix common/ includes.
 977         * auto-load.c: Fix common/ includes.
 978         * arm-tdep.c: Fix common/ includes.
 979         * arch/riscv.c: Fix common/ includes.
 980         * arch/ppc-linux-common.c: Fix common/ includes.
 981         * arch/i386.c: Fix common/ includes.
 982         * arch/arm.c: Fix common/ includes.
 983         * arch/arm-linux.c: Fix common/ includes.
 984         * arch/arm-get-next-pcs.c: Fix common/ includes.
 985         * arch/amd64.c: Fix common/ includes.
 986         * arch/aarch64.c: Fix common/ includes.
 987         * arch/aarch64-insn.c: Fix common/ includes.
 988         * arch-utils.c: Fix common/ includes.
 989         * amd64-windows-tdep.c: Fix common/ includes.
 990         * amd64-tdep.c: Fix common/ includes.
 991         * amd64-sol2-tdep.c: Fix common/ includes.
 992         * amd64-obsd-tdep.c: Fix common/ includes.
 993         * amd64-nbsd-tdep.c: Fix common/ includes.
 994         * amd64-linux-tdep.c: Fix common/ includes.
 995         * amd64-linux-nat.c: Fix common/ includes.
 996         * amd64-fbsd-tdep.c: Fix common/ includes.
 997         * amd64-fbsd-nat.c: Fix common/ includes.
 998         * amd64-dicos-tdep.c: Fix common/ includes.
 999         * amd64-darwin-tdep.c: Fix common/ includes.
1000         * agent.c: Fix common/ includes.
1001         * ada-lang.h: Fix common/ includes.
1002         * ada-lang.c: Fix common/ includes.
1003         * aarch64-tdep.c: Fix common/ includes.
1004
1005 2019-01-25  Tom Tromey  <tom@tromey.com>
1006
1007         * common/create-version.sh: Use common/version.h.
1008
1009 2019-01-24  Pedro Alves  <palves@redhat.com>
1010
1011         * infrun.c (signal_stop, signal_print, signal_program)
1012         (signal_catch, signal_pass): Now arrays instead of pointers.
1013         (update_signals_program_target, do_target_resume)
1014         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1015         * linux-nat.c (linux_nat_target::pass_signals)
1016         (linux_nat_target::create_inferior, linux_nat_target::attach):
1017         Adjust.
1018         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1019         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1020         * procfs.c (procfs_target::pass_signals): Adjust.
1021         * record-full.c (record_full_target::resume): Adjust.
1022         * remote.c (remote_target::pass_signals)
1023         (remote_target::program_signals): Adjust.
1024         * target-debug.h (target_debug_print_signals): Now takes a
1025         gdb::array_view as parameter.  Adjust.
1026         * target.h (target_ops) <pass_signals, program_signals>: Replace
1027         pointer and length parameters with gdb::array_view.
1028         (target_pass_signals, target_program_signals): Likewise.
1029         * target-delegates.c: Regenerate.
1030
1031 2019-01-24  Pedro Alves  <palves@redhat.com>
1032
1033         * common/forward-scope-exit.h
1034         (forward_scope_exit::forward_scope_exit): Pass arguments to
1035         m_bind_function directly, instead of creating a std::bind and
1036         copying that.
1037
1038 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1039
1040         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1041         for static members.
1042         (pass_in_v_vfp_candidate): Likewise.
1043
1044 2019-01-23  Tom Tromey  <tom@tromey.com>
1045             Pedro Alves  <palves@redhat.com>
1046
1047         * regcache.c (class regcache_invalidator): Remove.
1048         (regcache::raw_write): Use make_scope_exit.
1049
1050 2019-01-23  Tom Tromey  <tom@tromey.com>
1051
1052         * ui-out.h (class ui_out_emit_type): Update comment.
1053
1054 2019-01-23  Tom Tromey  <tom@tromey.com>
1055
1056         * infrun.c (fetch_inferior_event): Update comment.
1057
1058 2019-01-23  Tom Tromey  <tom@tromey.com>
1059             Pedro Alves  <palves@redhat.com>
1060
1061         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1062         parameter.
1063         (fetch_inferior_event): Use SCOPE_EXIT.
1064
1065
1066 2019-01-23  Tom Tromey  <tom@tromey.com>
1067             Pedro Alves  <palves@redhat.com>
1068
1069         * infrun.c (disable_thread_events): Delete.
1070         (stop_all_threads): Use SCOPE_EXIT.
1071
1072 2019-01-23  Tom Tromey  <tom@tromey.com>
1073             Pedro Alves  <palves@redhat.com>
1074
1075         * symfile.c: Include forward-scope-exit.h.
1076         (clear_symtab_users_cleanup): Replace forward declaration with
1077         a FORWARD_SCOPE_EXIT.
1078         (syms_from_objfile_1): Use the forward_scope_exit and
1079         gdb::optional instead of cleanup_function.
1080         (reread_symbols): Use the forward_scope_exit instead of
1081         cleanup_function.
1082         (clear_symtab_users_cleanup): Remove function.
1083
1084 2019-01-23  Tom Tromey  <tom@tromey.com>
1085             Pedro Alves  <palves@redhat.com>
1086
1087         * linux-nat.c: Include scope-exit.h.
1088         (cleanup_target_stop): Remove.
1089         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1090         SCOPE_EXIT.
1091
1092 2019-01-23  Tom Tromey  <tom@tromey.com>
1093             Pedro Alves  <palves@redhat.com>
1094
1095         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1096         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1097
1098 2019-01-23  Tom Tromey  <tom@tromey.com>
1099             Andrew Burgess  <andrew.burgess@embecosm.com>
1100             Pedro Alves  <palves@redhat.com>
1101
1102         * infrun.c (fetch_inferior_event): Use scope_exit.
1103         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1104         * top.c (execute_command): Use scope_exit.
1105         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1106         * utils.c (do_bpstat_clear_actions_cleanup)
1107         (make_bpstat_clear_actions_cleanup): Remove.
1108
1109 2019-01-23  Tom Tromey  <tom@tromey.com>
1110             Pedro Alves  <palves@redhat.com>
1111
1112         * infrun.c: Include "common/scope-exit.h"
1113         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1114         (wait_for_inferior): Use SCOPE_EXIT.
1115         (fetch_inferior_event): Use scope_exit.
1116
1117 2019-01-23  Tom Tromey  <tom@tromey.com>
1118             Pedro Alves  <palves@redhat.com>
1119
1120         * breakpoint.c (create_breakpoint): Remove cleanup.
1121
1122 2019-01-23  Tom Tromey  <tom@tromey.com>
1123             Andrew Burgess  <andrew.burgess@embecosm.com>
1124             Pedro Alves  <palves@redhat.com>
1125
1126 2019-01-23  Pedro Alves  <palves@redhat.com>
1127
1128         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1129
1130 2019-01-23  Pedro Alves  <palves@redhat.com>
1131             Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * gdbthread.h: Include "common/forward-scope-exit.h".
1134         (scoped_finish_thread_state): Redefine custom class in terms of
1135         forward_scope_exit.
1136
1137 2019-01-23  Pedro Alves  <palves@redhat.com>
1138             Andrew Burgess  <andrew.burgess@embecosm.com>
1139
1140         * common/forward-scope-exit.h: New file.
1141
1142 2019-01-23  Pedro Alves  <palves@redhat.com>
1143             Andrew Burgess  <andrew.burgess@embecosm.com>
1144             Tom Tromey  <tom@tromey.com>
1145
1146         * common/scope-exit.h: New file.
1147
1148 2019-01-23  Pedro Alves  <palves@redhat.com>
1149
1150         * common/preprocessor.h (ESC): Rename to ...
1151         (ESC_PARENS): ... this.
1152         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1153         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1154
1155 2019-01-23  Tom Tromey  <tom@tromey.com>
1156
1157         * language.h (class scoped_switch_to_sym_language_if_auto):
1158         Initialize m_lang in both cases.
1159
1160 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1161
1162         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1163         with XCNEW.
1164
1165 2019-01-22  Tom Tromey  <tom@tromey.com>
1166
1167         * corelow.c: Do not include sys/file.h.
1168
1169 2019-01-22  Tom Tromey  <tom@tromey.com>
1170
1171         * tui/tui-wingeneral.h: Include gdb_curses.h.
1172
1173 2019-01-22  Tom Tromey  <tom@tromey.com>
1174
1175         * source-cache.h (class source_cache) <get_source_lines,
1176         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1177
1178 2019-01-22  Tom Tromey  <tom@tromey.com>
1179
1180         * remote-fileio.h (struct remote_target): Declare.
1181
1182 2019-01-22  Tom Tromey  <tom@tromey.com>
1183
1184         * python/py-arch.c: Do not include py-ref.h.
1185         * python/py-bpevent.c: Do not include py-ref.h.
1186         * python/py-cmd.c: Do not include py-ref.h.
1187         * python/py-continueevent.c: Do not include py-ref.h.
1188         * python/py-event.h: Do not include py-ref.h.
1189         * python/py-evtregistry.c: Do not include py-ref.h.
1190         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1191         * python/py-frame.c: Do not include py-ref.h.
1192         * python/py-framefilter.c: Do not include py-ref.h.
1193         * python/py-function.c: Do not include py-ref.h.
1194         * python/py-infevents.c: Do not include py-ref.h.
1195         * python/py-linetable.c: Do not include py-ref.h.
1196         * python/py-objfile.c: Do not include py-ref.h.
1197         * python/py-param.c: Do not include py-ref.h.
1198         * python/py-prettyprint.c: Do not include py-ref.h.
1199         * python/py-progspace.c: Do not include py-ref.h.
1200         * python/py-symbol.c: Do not include py-ref.h.
1201         * python/py-symtab.c: Do not include py-ref.h.
1202         * python/py-type.c: Do not include py-ref.h.
1203         * python/py-unwind.c: Do not include py-ref.h.
1204         * python/py-utils.c: Do not include py-ref.h.
1205         * python/py-value.c: Do not include py-ref.h.
1206         * python/py-varobj.c: Do not include py-ref.h.
1207         * python/py-xmethods.c: Do not include py-ref.h.
1208         * python/python.c: Do not include py-ref.h.
1209         * varobj.c: Do not include py-ref.h.
1210
1211 2019-01-22  Tom Tromey  <tom@tromey.com>
1212
1213         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1214         keyword for bcache.
1215
1216 2019-01-22  Tom Tromey  <tom@tromey.com>
1217
1218         * compile/compile-cplus-types.c: Remove a comment by #include.
1219
1220 2019-01-22  Tom Tromey  <tom@tromey.com>
1221
1222         * compile/gcc-c-plugin.h: Include compile-internal.h.
1223
1224 2019-01-22  Tom Tromey  <tom@tromey.com>
1225
1226         * stabsread.c (EXTERN): Do not define.
1227         (symnum, next_symbol_text_func, processing_gcc_compilation)
1228         (within_function, global_sym_chain, global_stabs)
1229         (previous_stab_code, this_object_header_files)
1230         (n_this_object_header_files)
1231         (n_allocated_this_object_header_files): Define.
1232         * stabsread.h (EXTERN): Never define.  Use "extern".
1233
1234 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1235
1236         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1237         history_value.
1238
1239 2019-01-21  Tom Tromey  <tom@tromey.com>
1240
1241         * ui-out.c: Fix includes.
1242         * tui/tui-source.c: Fix includes.
1243         * target.c: Fix includes.
1244         * remote.c: Fix includes.
1245         * regcache.c: Fix includes.
1246         * python/py-block.c: Fix includes.
1247         * printcmd.c: Fix includes.
1248         * or1k-tdep.c: Fix includes.
1249         * mi/mi-main.c: Fix includes.
1250         * m32r-tdep.c: Fix includes.
1251         * csky-tdep.c: Fix includes.
1252         * compile/compile-cplus-types.c: Fix includes.
1253         * cli/cli-interp.c: Fix includes.
1254
1255 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1256
1257         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1258         for padding.
1259
1260 2019-01-16  Tom Tromey  <tom@tromey.com>
1261
1262         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1263         earlier.
1264         (struct objfile) <msymbols_range>: Move from top level.
1265         <msymbols>: New method.
1266         (class objfile_msymbols): Remove.
1267         * symtab.c (default_collect_symbol_completion_matches_break_on):
1268         Update.
1269         * symmisc.c (dump_msymbols): Update.
1270         * stabsread.c (scan_file_globals): Update.
1271         * objc-lang.c (info_selectors_command, info_classes_command)
1272         (find_methods): Update.
1273         * minsyms.c (find_solib_trampoline_target): Update.
1274         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1275         * coffread.c (coff_symfile_read): Update.
1276         * ada-lang.c (ada_lookup_simple_minsym)
1277         (ada_collect_symbol_completion_matches): Update.
1278
1279 2019-01-16  Tom Tromey  <tom@tromey.com>
1280
1281         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1282         type.  Remove no-argument constructor.
1283         <iterator::operator++>: Simplify.
1284         <begin>: Update.
1285         <end>: Use minimal_symbol_count.
1286
1287 2019-01-16  Tom Tromey  <tom@tromey.com>
1288
1289         * objfiles.h (struct objfile) <psymtabs>: New method.
1290         (class objfile_psymtabs): Remove.
1291         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1292         typedef.
1293         <range>: New method.
1294         (require_partial_symbols): Change return type.
1295         * psymtab.c (require_partial_symbols)
1296         (psym_expand_symtabs_matching): Update.
1297         * mdebugread.c (parse_partial_symbols): Update.
1298         * dbxread.c (dbx_end_psymtab): Update.
1299
1300 2019-01-15  Tom Tromey  <tom@tromey.com>
1301
1302         * symtab.c (lookup_objfile_from_block)
1303         (lookup_symbol_in_objfile_symtabs)
1304         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1305         (find_line_symtab, info_sources_command)
1306         (default_collect_symbol_completion_matches_break_on)
1307         (make_source_files_completion_list): Update.
1308         * symmisc.c (print_objfile_statistics, dump_objfile)
1309         (maintenance_print_symbols, maintenance_info_symtabs)
1310         (maintenance_check_symtabs, maintenance_info_line_tables):
1311         Update.
1312         * source.c (select_source_symtab)
1313         (forget_cached_source_info_for_objfile): Update.
1314         * objfiles.h (class objfile_compunits): Remove.
1315         (struct objfile) <compunits_range>: New typedef.
1316         (compunits): New method.
1317         * objfiles.c (objfile_relocate1): Update.
1318         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1319         * maint.c (count_symtabs_and_blocks): Update.
1320         * linespec.c (iterate_over_all_matching_symtabs): Update.
1321         * cp-support.c (add_symbol_overload_list_qualified): Update.
1322         * coffread.c (coff_symtab_read): Update.
1323         * ada-lang.c (add_nonlocal_symbols)
1324         (ada_collect_symbol_completion_matches)
1325         (ada_add_global_exceptions): Update.
1326
1327 2019-01-15  Tom Tromey  <tom@tromey.com>
1328
1329         * progspace.h (program_space) <objfiles_safe_range>: New
1330         typedef.
1331         <objfiles_safe>: New method.
1332         * objfiles.h (class all_objfiles_safe): Remove.
1333         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1334         * jit.c (jit_inferior_exit_hook): Update.
1335
1336 2019-01-17  Tom Tromey  <tom@tromey.com>
1337
1338         * progspace.h (program_space) <objfiles_range>: New typedef.
1339         <objfiles>: New method.
1340         <objfiles_head>: Rename from objfiles.
1341         (object_files): Update.
1342         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1343         * guile/scm-pretty-print.c
1344         (ppscm_find_pretty_printer_from_objfiles): Update.
1345         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1346         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1347         Update.
1348         * python/py-progspace.c (pspy_get_objfiles): Update.
1349         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1350         Update.
1351         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1352         (objfpy_lookup_objfile_by_build_id): Update.
1353         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1354         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1355         Update.
1356         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1357         (expand_symtab_containing_pc, lookup_objfile_from_block)
1358         (lookup_static_symbol, basic_lookup_transparent_type)
1359         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1360         (find_line_symtab, info_sources_command)
1361         (default_collect_symbol_completion_matches_break_on)
1362         (make_source_files_completion_list, find_main_name): Update.
1363         * symmisc.c (print_symbol_bcache_statistics)
1364         (print_objfile_statistics, maintenance_print_symbols)
1365         (maintenance_print_msymbols, maintenance_print_objfiles)
1366         (maintenance_info_symtabs, maintenance_check_symtabs)
1367         (maintenance_expand_symtabs, maintenance_info_line_tables):
1368         Update.
1369         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1370         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1371         (map_overlay_command, unmap_overlay_command)
1372         (simple_overlay_update, expand_symtabs_matching)
1373         (map_symbol_filenames): Update.
1374         * symfile-debug.c (set_debug_symfile): Update.
1375         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1376         Update.
1377         * source.c (select_source_symtab, forget_cached_source_info):
1378         Update.
1379         * solib.c (solib_read_symbols): Update.
1380         * solib-spu.c (append_ocl_sos): Update.
1381         * psymtab.c (maintenance_print_psymbols)
1382         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1383         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1384         * printcmd.c (info_symbol_command): Update.
1385         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1386         Update.
1387         * objfiles.h (class all_objfiles): Remove.
1388         * objfiles.c (have_partial_symbols, have_full_symbols)
1389         (have_minimal_symbols, qsort_cmp, update_section_map)
1390         (shared_objfile_contains_address_p)
1391         (default_iterate_over_objfiles_in_search_order): Update.
1392         * objc-lang.c (info_selectors_command, info_classes_command)
1393         (find_methods): Update.
1394         * minsyms.c (find_solib_trampoline_target): Update.
1395         * maint.c (maintenance_info_sections)
1396         (maintenance_translate_address, count_symtabs_and_blocks):
1397         Update.
1398         * main.c (captured_main_1): Update.
1399         * linux-thread-db.c (try_thread_db_load_from_pdir)
1400         (has_libpthread): Update.
1401         * linespec.c (iterate_over_all_matching_symtabs)
1402         (search_minsyms_for_name): Update.
1403         * jit.c (jit_find_objf_with_entry_addr): Update.
1404         * hppa-tdep.c (find_unwind_entry)
1405         (hppa_lookup_stub_minimal_symbol): Update.
1406         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1407         Update.
1408         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1409         (elf_gnu_ifunc_resolve_by_got): Update.
1410         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1411         * dwarf-index-write.c (save_gdb_index_command): Update.
1412         * cp-support.c (add_symbol_overload_list_qualified): Update.
1413         * breakpoint.c (create_overlay_event_breakpoint)
1414         (create_longjmp_master_breakpoint)
1415         (create_std_terminate_master_breakpoint)
1416         (create_exception_master_breakpoint): Update.
1417         * blockframe.c (find_pc_partial_function): Update.
1418         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1419         (ada_collect_symbol_completion_matches)
1420         (ada_add_global_exceptions): Update.
1421
1422 2019-01-17  Tom Tromey  <tom@tromey.com>
1423
1424         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1425         declare VEC.
1426         (solib_target_parse_libraries): Change return type.
1427         (library_list_start_segment, library_list_start_section)
1428         (library_list_end_library, library_list_start_library); Update.
1429         (solib_target_free_library_list): Remove.
1430         (solib_target_parse_libraries): Remove cleanup.  Change return
1431         type.
1432         (solib_target_current_sos): Update.
1433
1434 2019-01-17  Tom Tromey  <tromey@bapiya>
1435
1436         * valprint.c: Replace "the the" with "the".
1437         * symtab.c: Replace "the the" with "the".
1438         * solib.c: Replace "the the" with "the".
1439         * solib-dsbt.c: Replace "the the" with "the".
1440         * linespec.c: Replace "the the" with "the".
1441         * dwarf2loc.h: Replace "the the" with "the".
1442         * amd64-windows-tdep.c: Replace "the the" with "the".
1443         * aarch64-tdep.c: Replace "the the" with "the".
1444
1445 2019-01-16  Keith Seitz  <keiths@redhat.com>
1446
1447         PR gdb/23773
1448         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1449         <builder>: Rename to ..
1450         <m_builder>: ... this and make private.
1451         (dwarf2_cu::get_builder): New method.  Change all users of
1452         `builder' to use this method.
1453         (dwarf2_start_symtab): Move to ...
1454         (dwarf2_cu::start_symtab): ... here.  Update all callers
1455         (setup_type_unit_groups): Move to ...
1456         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1457         callers.
1458         (dwarf2_cu::reset_builder): New method.
1459         (process_full_compunit, process_full_type_unit): Use
1460         dwarf2_cu::reset_builder.
1461         (follow_die_offset): Record the ancestor CU if it is different
1462         from the followed DIE's CU.
1463         (follow_die_sig_1): Likewise.
1464
1465 2019-01-15  Tom Tromey  <tom@tromey.com>
1466
1467         * remote.c (class remote_state) <buf>: Now a char_vector.
1468         <buf_size>: Remove.
1469         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1470         parameter.
1471         (remote_target::getpkt_or_notif_sane_1)
1472         (remote_target::getpkt_sane)
1473         (remote_target::getpkt_or_notif_sane): Likewise.
1474         (class remote_target) <putpkt>: New overload.
1475         (remote_target::read_frame): Change type of "buf_p".  Remove
1476         sizeof_p parameter.
1477         (packet_ok): New overload.
1478         (packet_check_result): New overload.
1479         Update all uses.
1480
1481 2019-01-14  Tom Tromey  <tom@tromey.com>
1482
1483         * remote-notif.c (handle_notification, remote_notif_ack)
1484         (remote_notif_parse): Make "buf" const.
1485         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1486         const.
1487         (remote_notif_parse, remote_notif_ack, handle_notification):
1488         Likewise.
1489         * remote.c (remote_notif_stop_parse): Make "buf" const.
1490         (remote_target::remote_parse_stop_reply): Make "buf" const.
1491         (remote_notif_stop_ack): Make "buf" const.
1492
1493 2019-01-14  Tom Tromey  <tom@tromey.com>
1494
1495         * remote.c (remote_console_output): Make parameter const.
1496
1497 2019-01-14  Tom Tromey  <tom@tromey.com>
1498
1499         * target-debug.h (target_debug_print_signals): Constify.
1500         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1501         * procfs.c (procfs_target::pass_signals): Update.
1502         * linux-nat.c (linux_nat_target::pass_signals): Update.
1503         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1504         * target-delegates.c: Rebuild.
1505         * remote.c (remote_target::program_signals): Update.
1506         (remote_target::pass_signals): Update.
1507         * target.c (target_pass_signals): Constify argument.
1508         (target_program_signals): Likewise.
1509         * target.h (struct target_ops) <pass_signals, program_signals>:
1510         Constify argument.
1511         (target_pass_signals, target_program_signals): Constify argument.
1512
1513 2019-01-14  Tom Tromey  <tom@tromey.com>
1514
1515         PR tui/28819:
1516         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1517
1518 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1519
1520         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1521         field.
1522         * rs6000-tdep.c: Include reggroups.h.
1523         (IS_V_ALIAS_PSEUDOREG): Define.
1524         (rs6000_register_name): Return names for the "vX" aliases.
1525         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1526         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1527         aliases.  Call default_register_reggroup_p for all other
1528         pseudo-registers.
1529         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1530         New functions.
1531         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1532         Handle "vX" aliases.
1533         (v_alias_pseudo_register_collect): New function.
1534         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1535         (rs6000_gdbarch_init): Initialize "vX" aliases as
1536         pseudo-registers.  Restore registration of
1537         rs6000_pseudo_register_reggroup_p with
1538         set_tdesc_pseudo_register_reggroup_p.
1539
1540 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1541
1542         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1543         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1544         set_gdbarch_num_pseudo_regs.
1545
1546 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1547
1548         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1549         Remove arg prefixname, add do_set and do_show.
1550         Add member functions set_list and show_list.
1551         * cli/cli-style.c (class cli_style_option): Update accordingly.
1552         (style_set_list): Move to file scope.
1553         (style_show_list): Likewise.
1554         (set_style): Call help_list.
1555         (show_style): Call cmd_show_list.
1556         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1557         Update to use the new macro.
1558
1559 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1560
1561         * ada-lang.c (_initialize_ada_language): Expand the help text
1562         for the "catch exception" command.
1563
1564 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1565
1566         * symtab.c (matching_obj_sections): Initialize obj,
1567         declare it closer to its usage.
1568
1569 2019-01-10  Tom Tromey  <tom@tromey.com>
1570
1571         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1572         (basic_inf_threads_range): Remove.
1573         (inf_threads_range, inf_non_exited_threads_range)
1574         (safe_inf_threads_range): Use next_adapter.
1575
1576 2019-01-10  Keith Seitz  <keiths@redhat.com>
1577
1578         PR gdb/23712
1579         PR symtab/23010
1580         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1581         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1582
1583 2019-01-10  Keith Seitz  <keiths@redhat.com>
1584
1585         PR gdb/23712
1586         PR symtab/23010
1587         * dictionary.c (pending_to_vector): Remove.
1588         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1589         Remove _1 suffix, replacing functions of the same name.  Update
1590         all callers.
1591         (dict_create_hashed, dict_create_hashed_expandable)
1592         (dict_create_linear, dict_create_linear_expandable, dict_free)
1593         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1594         Make functions static.
1595
1596 2019-01-10  Keith Seitz  <keiths@redhat.com>
1597
1598         PR gdb/23712
1599         PR symtab/23010
1600         * dictionary.h (struct dictionary): Replace declaration with
1601         multidictionary.
1602         (dict_create_hashed, dict_create_hashed_expandable)
1603         (dict_create_linear, dict_create_linear_expandable)
1604         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1605         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1606         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1607         taking multidictionary argument.
1608         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1609         * block.h (struct block) <dict>: Change to multidictionary
1610         and rename `multidict'.
1611         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1612         symmisc.c: Update all dictionary references to multidictionary.
1613
1614 2019-01-10  Keith Seitz  <keiths@redhat.com>
1615
1616         PR gdb/23712
1617         PR symtab/23010
1618         * dictionary.c: Include unordered_map.
1619         (pending_to_vector): New function.
1620         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1621         Rewrite the non-"_1" functions to take vector instead
1622         of linked list.
1623         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1624         "new" _1 versions of the same name.
1625         (multidictionary): Define.
1626         (std::hash<enum language): New definition.
1627         (collate_pending_symbols_by_language, mdict_create_hashed)
1628         (mdict_create_hashed_expandable, mdict_create_linear)
1629         (mdict_create_linear_expandable, mdict_free)
1630         (find_language_dictionary, create_new_language_dictionary)
1631         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1632         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1633         (mdict_size, mdict_empty): New functions.
1634         * dictionary.h (mdict_iterator): Define.
1635
1636 2019-01-10  Pedro Alves  <palves@redhat.com>
1637
1638         * breakpoint.c (read_uploaded_action)
1639         (create_tracepoint_from_upload): Adjust to use
1640         gdb::unique_xmalloc_ptr.
1641         * ctf.c (ctf_write_uploaded_tp):
1642         (SET_ARRAY_FIELD): Use emplace_back.
1643         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1644         * tracefile-tfile.c (tfile_write_uploaded_tp):
1645         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1646         gdb::unique_xmalloc_ptr.
1647         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1648         at_string, cond_string, cmd_strings>: Replace char pointers
1649         with gdb::unique_xmalloc_ptr.
1650
1651 2019-01-10  Pedro Alves  <palves@redhat.com>
1652
1653         * solib-target.c (library_list_start_library): Don't xstrdup name.
1654
1655 2019-01-10  Pedro Alves  <palves@redhat.com>
1656
1657         * mdebugread.c (parse_partial_symbols): Use
1658         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1659
1660 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1661
1662         * linux-fork.c (scoped_switch_fork_info)
1663         <~scoped_switch_fork_info>: Fix incorrect variable name.
1664
1665 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1666
1667         * linux-fork.c (scoped_switch_fork_info)
1668         <scoped_switch_fork_info>: Make explicit.
1669         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1670
1671 2019-01-10  Tom Tromey  <tom@tromey.com>
1672
1673         * objfiles.h (objfile::reset_psymtabs): Update.
1674         * objfiles.c (objfile::objfile): Update.
1675         * psymtab.h (psymtab_storage::obstack): Update.
1676         (psymtab_storage::m_obstack): Use gdb::optional.
1677         (class psymtab_storage): Update comment.  Remove objfile
1678         parameter.
1679         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1680
1681 2019-01-10  Tom Tromey  <tom@tromey.com>
1682
1683         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1684         <free_psymtabs>: Now private.
1685         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1686         (allocate_psymtab): Use new method.
1687
1688 2019-01-10  Tom Tromey  <tom@tromey.com>
1689
1690         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1691         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1692         * mdebugread.c (parse_partial_symbols): Use
1693         allocate_dependencies.
1694         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1695         allocate_dependencies.
1696         (process_psymtab_comp_unit_reader)
1697         (build_type_psymtab_dependencies): Likewise.
1698         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1699
1700 2019-01-10  Tom Tromey  <tom@tromey.com>
1701
1702         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1703         PSYMBOL_SET_LANGUAGE.
1704         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1705
1706 2019-01-10  Tom Tromey  <tom@tromey.com>
1707
1708         * psymtab.h (psymtab_storage::obstack): New method.
1709         <m_obstack>: Rename from obstack; now private.
1710         * psymtab.c (psymtab_storage): Update.
1711         * dwarf2read.c (create_addrmap_from_index)
1712         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1713         Update.
1714
1715 2019-01-10  Tom Tromey  <tom@tromey.com>
1716
1717         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1718         * objfiles.h (objfile::reset_psymtabs): New method.
1719
1720 2019-01-10  Tom Tromey  <tom@tromey.com>
1721
1722         * symmisc.c (print_symbol_bcache_statistics): Update.
1723         (print_objfile_statistics): Update.
1724         * symfile.c (reread_symbols): Update.
1725         * psymtab.h (class psymtab_storage): New.
1726         * psymtab.c (psymtab_storage): New constructor.
1727         (~psymtab_storage): New destructor.
1728         (require_partial_symbols): Update.
1729         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1730         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1731         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1732         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1733         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1734         (start_psymtab_common, end_psymtab_common)
1735         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1736         (allocate_psymtab): Update.
1737         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1738         Update.
1739         (dump_psymtab_addrmap, maintenance_print_psymbols)
1740         (maintenance_check_psymtabs): Update.
1741         (class objfile_psymtabs): Move to objfiles.h.
1742         * psympriv.h (discard_psymtab): Now inline.
1743         (psymtab_discarder::psymtab_discarder): Update.
1744         (psymtab_discarder::~psymtab_discarder): Update.
1745         (ALL_OBJFILE_PSYMTABS): Rewrite.
1746         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1747         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1748         Remove fields.
1749         <partial_symtabs>: New field.
1750         (class objfile_psymtabs): Move from psymtab.h.  Update.
1751         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1752         psymbol_cache.
1753         (objfile::~objfile): Don't destroy psymbol_cache.
1754         * mdebugread.c (parse_partial_symbols): Update.
1755         * dwarf2read.c (create_addrmap_from_index)
1756         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1757         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1758         (add_partial_subprogram, dwarf2_ranges_read): Update.
1759         * dwarf-index-write.c (write_address_map)
1760         (write_one_signatured_type, recursively_write_psymbols)
1761         (class debug_names, class debug_names, write_psymtabs_to_index):
1762         Update.
1763
1764 2019-01-10  Tom Tromey  <tom@tromey.com>
1765
1766         * symtab.h (SYMBOL_SET_NAMES): Update.
1767         (symbol_set_names): Update.
1768         (MSYMBOL_SET_NAMES): Update.
1769         * symtab.c (symbol_set_names): Change argument to be an
1770         objfile_per_bfd_storage.
1771         * psymtab.c (add_psymbol_to_bcache): Update.
1772         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1773
1774 2019-01-10  Tom Tromey  <tom@tromey.com>
1775
1776         * symtab.c (create_demangled_names_hash): Change argument to be an
1777         objfile_per_bfd_storage.
1778         (symbol_set_names): Update.
1779
1780 2019-01-10  Tom Tromey  <tom@tromey.com>
1781
1782         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1783         init_psymbol_list.
1784         * psymtab.c (init_psymbol_list): Do nothing if already called.
1785         * psympriv.h (init_psymbol_list): Add comment.
1786         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1787         init_psymbol_list.
1788         * dbxread.c (dbx_symfile_read): Unconditionally call
1789         init_psymbol_list.
1790
1791 2019-01-10  Tom Tromey  <tom@tromey.com>
1792
1793         * xcoffread.c (scan_xcoff_symtab): Update.
1794         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1795         "where".
1796         * mdebugread.c (parse_partial_symbols)
1797         (handle_psymbol_enumerators): Update.
1798         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1799         * dbxread.c (read_dbx_symtab): Update.
1800         * psympriv.h (psymbol_placement): New enum.
1801         (add_psymbol_to_list): Update.
1802
1803 2019-01-10  Tom Tromey  <tom@tromey.com>
1804
1805         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1806         static_psymbols parameters.
1807         (scan_xcoff_symtab): Update.
1808         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1809         static_psymbols parameters.
1810         * psympriv.h (start_psymtab_common): Update.
1811         * mdebugread.c (parse_partial_symbols): Update.
1812         * dwarf2read.c (create_partial_symtab): Update.
1813         * dbxread.c (read_dbx_symtab): Update.
1814         (start_psymtab): Remove global_psymbols and static_psymbols
1815         parameters.
1816
1817 2019-01-10  Tom Tromey  <tom@tromey.com>
1818
1819         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1820         * psymtab.c (allocate_psymtab): Add comment.
1821         * psympriv.h (allocate_psymtab): Add comment.
1822         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1823         initializations.
1824         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1825
1826 2019-01-10  Tom Tromey  <tom@tromey.com>
1827
1828         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1829         Don't declare.
1830         * mipsread.c: Include mdebugread.h.
1831         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1832         Declare.
1833         * elfread.c: Include mdebugread.h.
1834
1835 2019-01-09  Tom Tromey  <tom@tromey.com>
1836
1837         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1838         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1839         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1840         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1841         (psym_lookup_symbol, psym_find_last_source_symtab)
1842         (psym_forget_cached_source_info, psym_print_stats)
1843         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1844         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1845         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1846         (psym_find_compunit_symtab_by_address)
1847         (maintenance_print_psymbols, maintenance_info_psymtabs)
1848         (maintenance_check_psymtabs): Use ranged for.
1849         * psymtab.h (class objfile_psymtabs): New.
1850         (require_partial_symbols): Return objfile_psymtabs.
1851         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1852
1853 2019-01-09  Tom Tromey  <tom@tromey.com>
1854
1855         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1856         (find_pc_mapped_section, list_overlays_command)
1857         (map_overlay_command, unmap_overlay_command)
1858         (simple_overlay_update): Use all_objfiles.
1859         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1860         * printcmd.c (info_symbol_command): Use all_objfiles.
1861         * objfiles.h (ALL_OBJSECTIONS): Remove.
1862         * maint.c (maintenance_translate_address): Use all_objfiles.
1863         * gcore.c (gcore_create_callback): Use all_objfiles.
1864         (objfile_find_memory_regions): Likewise.
1865
1866 2019-01-09  Tom Tromey  <tom@tromey.com>
1867
1868         * symtab.c (find_line_symtab, info_sources_command)
1869         (make_source_files_completion_list): Use objfile_compunits.
1870         * source.c (select_source_symtab): Use objfile_compunits.
1871         * objfiles.h (struct objfile): Update comment.
1872         (ALL_OBJFILES): Remove.
1873         (ALL_FILETABS): Remove.
1874         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1875         objfile_compunits.
1876
1877 2019-01-09  Tom Tromey  <tom@tromey.com>
1878
1879         * symmisc.c (print_objfile_statistics, dump_objfile)
1880         (maintenance_print_symbols): Use compunit_filetabs.
1881         * source.c (forget_cached_source_info_for_objfile): Use
1882         compunit_filetabs.
1883         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1884         (ALL_FILETABS): Use compunit_filetabs.
1885         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1886         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1887
1888 2019-01-09  Tom Tromey  <tom@tromey.com>
1889
1890         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1891         (compunit_filetabs): New.
1892         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1893         compunit_filetabs.
1894         (info_sources_command, make_source_files_completion_list): Remove
1895         declaration.
1896         * symmisc.c (print_objfile_statistics, dump_objfile)
1897         (maintenance_print_symbols): Remove declaration.
1898         (maintenance_info_symtabs): Use compunit_filetabs.
1899         (maintenance_info_line_tables): Likewise.
1900         * source.c (select_source_symtab): Change local variable name.
1901         (forget_cached_source_info_for_objfile): Remove declaration.
1902         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1903         * objfiles.c (objfile_relocate1): Remove declaration.
1904         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1905         declaration.
1906         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1907         * coffread.c (coff_symtab_read): Remove declaration.
1908         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1909         compunit_filetabs.
1910
1911 2019-01-09  Tom Tromey  <tom@tromey.com>
1912
1913         * symtab.c (lookup_objfile_from_block)
1914         (find_pc_sect_compunit_symtab, search_symbols)
1915         (default_collect_symbol_completion_matches_break_on): Use
1916         objfile_compunits.
1917         * objfiles.h (ALL_COMPUNITS): Remove.
1918         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1919         * cp-support.c (add_symbol_overload_list_qualified): Use
1920         objfile_compunits.
1921         * ada-lang.c (ada_collect_symbol_completion_matches)
1922         (ada_add_global_exceptions): Use objfile_compunits.
1923
1924 2019-01-09  Tom Tromey  <tom@tromey.com>
1925
1926         * source.c (select_source_symtab)
1927         (forget_cached_source_info_for_objfile): Remove declaration.
1928         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1929         declaration.
1930         * maint.c (count_symtabs_and_blocks): Remove declaration.
1931         * cp-support.c (add_symbol_overload_list_qualified): Remove
1932         declaration.
1933         * coffread.c (coff_symtab_read): Remove declaration.
1934         * symtab.c (lookup_symbol_in_objfile_symtabs)
1935         (basic_lookup_transparent_type_1): Use objfile_compunits.
1936         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1937         (info_sources_command, search_symbols)
1938         (default_collect_symbol_completion_matches_break_on)
1939         (make_source_files_completion_list): Remove declaration.
1940         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1941         (ada_collect_symbol_completion_matches)
1942         (ada_add_global_exceptions): Remove declaration.
1943         * linespec.c (iterate_over_all_matching_symtabs): Use
1944         objfile_compunits.
1945         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1946         (class objfile_compunits): New.
1947         (ALL_COMPUNITS): Use objfile_compunits.
1948         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1949         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1950         objfile_compunits.
1951         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1952
1953 2019-01-09  Tom Tromey  <tom@tromey.com>
1954
1955         * symtab.c (search_symbols)
1956         (default_collect_symbol_completion_matches_break_on): Use
1957         objfile_msymbols.
1958         * ada-lang.c (ada_lookup_simple_minsym)
1959         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1960         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1961         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1962         objfile_msymbols.
1963         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1964         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1965         * objc-lang.c (find_methods): Use objfile_msymbols.
1966         (info_selectors_command, info_classes_command): Likewise.
1967         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1968         * objfiles.h (class objfile_msymbols): New.
1969         (ALL_OBJFILE_MSYMBOLS): Remove.
1970         (ALL_MSYMBOLS): Remove.
1971
1972 2019-01-09  Tom Tromey  <tom@tromey.com>
1973
1974         * common/next-iterator.h (next_adapter): Add Iterator template
1975         parameter.
1976         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1977         (class all_objfiles_safe): New.
1978         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1979         * objfiles.c (put_objfile_before): Update comment.
1980         (add_separate_debug_objfile): Likewise.
1981         (free_all_objfiles): Use all_objfiles_safe.
1982         (objfile_purge_solibs): Likewise.
1983
1984 2019-01-09  Tom Tromey  <tom@tromey.com>
1985
1986         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1987         (expand_symtab_containing_pc, lookup_static_symbol)
1988         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1989         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1990         all_objfiles.
1991         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1992         * breakpoint.c (create_overlay_event_breakpoint)
1993         (create_longjmp_master_breakpoint)
1994         (create_std_terminate_master_breakpoint)
1995         (create_exception_master_breakpoint): Use all_objfiles.
1996         * linux-thread-db.c (try_thread_db_load_from_pdir)
1997         (has_libpthread): Use all_objfiles.
1998         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1999         * linespec.c (iterate_over_all_matching_symtabs)
2000         (search_minsyms_for_name): Use all_objfiles.
2001         * maint.c (maintenance_info_sections): Use all_objfiles.
2002         * main.c (captured_main_1): Use all_objfiles.
2003         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2004         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2005         * guile/scm-pretty-print.c
2006         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2007         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2008         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2009         (maintenance_print_msymbols): Use all_objfiles.
2010         * source.c (select_source_symtab): Use all_objfiles.
2011         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2012         * symfile.c (remove_symbol_file_command)
2013         (expand_symtabs_matching, map_symbol_filenames): Use
2014         all_objfiles.
2015         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2016         all_objfiles.
2017         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2018         * objc-lang.c (find_methods): Use all_objfiles.
2019         * objfiles.c (have_partial_symbols, have_full_symbols)
2020         (have_minimal_symbols, qsort_cmp)
2021         (default_iterate_over_objfiles_in_search_order): Use
2022         all_objfiles.
2023         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2024         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2025         (maintenance_check_psymtabs): Use all_objfiles.
2026         (ALL_PSYMTABS): Remove.
2027         * compile/compile-object-run.c (do_module_cleanup): Use
2028         all_objfiles.
2029         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2030         * cp-support.c (add_symbol_overload_list_qualified): Use
2031         all_objfiles.
2032         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2033         Use all_objfiles.
2034         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2035         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2036         all_objfiles.
2037         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2038         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2039         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2040         Uses all_objfiles.
2041         * solib.c (solib_read_symbols): Use all_objfiles
2042
2043 2019-01-09  Tom Tromey  <tom@tromey.com>
2044
2045         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2046         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2047         all_objfiles.
2048         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2049         * symmisc.c (print_symbol_bcache_statistics)
2050         (print_objfile_statistics, maintenance_print_objfiles)
2051         (maintenance_info_symtabs, maintenance_check_symtabs)
2052         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2053         all_objfiles.
2054         * source.c (forget_cached_source_info): Use all_objfiles.
2055         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2056         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2057         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2058         * objfiles.c (update_section_map): Use all_objfiles.
2059         (shared_objfile_contains_address_p): Likewise.
2060         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2061         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2062
2063 2019-01-09  Tom Tromey  <tom@tromey.com>
2064
2065         * common/next-iterator.h: New file.
2066         * objfiles.h (class all_objfiles): New.
2067         (struct objfile_iterator): New.
2068
2069 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2070
2071         * NEWS: Move the description of the changed "frame", "select-frame",
2072          and "info frame" commands to the Changed commands section.
2073
2074 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2075
2076         * gdbtypes.c (check_stub_method_group): Remove handling of old
2077         mangling schemes.
2078         * linespec.c (find_methods): Likewise.
2079         * stabsread.c (read_member_functions): Likewise.
2080         * valops.c (search_struct_method): Likewise.
2081         (value_struct_elt_for_reference): Likewise.
2082         * NEWS: Mention this change.
2083
2084 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2085
2086         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2087         print_source_lines.
2088         * source.c (print_source_lines_base): Update line number check.
2089         (print_source_lines): New function.
2090         (source_lines_range::source_lines_range): New function.
2091         * source.h (class source_lines_range): New class.
2092         (print_source_lines): New declaration.
2093
2094 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2095
2096         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2097
2098 2019-01-08  Tom Tromey  <tom@tromey.com>
2099             Simon Marchi  <simon.marchi@ericsson.com>
2100
2101         PR gdb/24060
2102         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2103         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2104         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2105         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2106         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2107         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2108
2109 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2110
2111         * source.c (select_source_symtab): Move header comment to
2112         declaration in source.h.
2113         (forget_cached_source_info_for_objfile): Likewise.
2114         (forget_cached_source_info): Likewise.
2115         (identify_source_line): Likewise.
2116         * source.h (identify_source_line): Move declaration from symtab.h
2117         and add comment from source.c
2118         (print_source_lines): Likewise.
2119         (forget_cached_source_info_for_objfile): Likewise.
2120         (forget_cached_source_info): Likewise.
2121         (select_source_symtab): Likewise.
2122         (enum print_source_lines_flag): Move definition from symtab.h.
2123         * symtab.h (identify_source_line): Move declaration to source.h.
2124         (print_source_lines): Likewise.
2125         (forget_cached_source_info_for_objfile): Likewise.
2126         (forget_cached_source_info): Likewise.
2127         (select_source_symtab): Likewise.
2128         (enum print_source_lines_flag): Move definition to source.h.
2129         * tui/tui-hooks.c: Add 'source.h' include.
2130
2131 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2132
2133         * source.c (print_source_lines_base): Handle requests to print
2134         reverse line number sequences, and guard against empty lines
2135         string.
2136
2137 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2138
2139         * source.c (print_source_lines_base): Fix skip of '\r' if next
2140         character is '\n'.
2141
2142 2019-01-06  Tom Tromey  <tom@tromey.com>
2143
2144         * c-exp.y (struct c_parse_state) <macro_original_text,
2145         expansion_obstack>: New member.
2146         (macro_original_text, expansion_obstack): Remove globals.
2147         (scan_macro_expansion, scanning_macro_expansion)
2148         (finished_macro_expansion): Update.
2149         (scan_macro_cleanup): Remove.
2150         (yylex, c_parse): Update.
2151
2152 2019-01-06  Tom Tromey  <tom@tromey.com>
2153
2154         * c-exp.y (struct c_parse_state) <strings>: New member.
2155         (operator_stoken): Update.
2156
2157 2019-01-06  Tom Tromey  <tom@tromey.com>
2158
2159         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2160         (union type_stack_elt) <typelist_val>: Now a pointer to
2161         std::vector.
2162         (type_stack_cleanup): Don't declare.
2163         (push_typelist): Update.
2164         * parse.c (pop_typelist): Return a std::vector.
2165         (push_typelist): Take a std::vector.
2166         (follow_types): Update.  Do not free args.
2167         (type_stack_cleanup): Remove.
2168         * c-exp.y (struct c_parse_state): New.
2169         (cpstate): New global.
2170         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2171         (nonempty_typelist): Update.
2172         (func_mod): Create a new vector.
2173         (c_parse): Create a c_parse_state.
2174         (check_parameter_typelist): Do not delete params.
2175         (function_method): Update.  Do not delete type_list.
2176
2177 2019-01-06  Tom Tromey  <tom@tromey.com>
2178
2179         PR gdb/28155:
2180         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2181         check_typedef.
2182         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2183         (print_return_value): Likewise.
2184
2185 2019-01-05  Tom Tromey  <tom@tromey.com>
2186
2187         * contrib/cleanup_check.py: Remove.
2188         * contrib/gcc-with-excheck: Remove.
2189         * contrib/exsummary.py: Remove.
2190         * contrib/excheck.py: Remove.
2191
2192 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2193
2194         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2195         NULL. Initialize tpprev to NULL instead of assigning it
2196         to NULL on the next statement.
2197         * windows-nat.c (windows_delete_thread): Remove check for
2198         main_thread_id before printing thread exit notifications.
2199         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2200         Remove thread ID check against main_thread_id.
2201         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2202         windows_delete_thread.
2203         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2204
2205 2019-01-04  Tom Tromey  <tom@tromey.com>
2206
2207         * compile/compile.c (_initialize_compile): Use upper case for
2208         metasyntactic variables.
2209         * symmisc.c (_initialize_symmisc): Use upper case for
2210         metasyntactic variables.
2211         * psymtab.c (_initialize_psymtab): Use upper case for
2212         metasyntactic variables.
2213         * demangle.c (demangle_command): Use upper case for metasyntactic
2214         variables.
2215         (_initialize_demangler): Likewise.
2216         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2217         variables.
2218
2219 2019-01-03  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2222
2223 2019-01-03  Tom Tromey  <tom@tromey.com>
2224
2225         * python/py-symtab.c (salpy_str): Update.
2226         (struct salpy_sal_object) <symtab>: Now a PyObject.
2227         (salpy_dealloc): Update.
2228         (del_objfile_sal): Use gdbpy_ref.
2229
2230 2019-01-03  Tom Tromey  <tom@tromey.com>
2231
2232         * python/py-type.c (convert_field): Use new_reference.  Return
2233         gdbpy_ref.
2234         (make_fielditem): Return gdbpy_ref.
2235         (typy_fields): Update.
2236         (typy_getitem): Update.
2237         (field_name): Return gdbpy_ref.  Use new_reference.
2238         (typy_iterator_iternext): Update.
2239
2240 2019-01-03  Tom Tromey  <tom@tromey.com>
2241
2242         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2243
2244 2019-01-03  Tom Tromey  <tom@tromey.com>
2245
2246         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2247         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2248         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2249         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2250         (pspy_set_type_printers): Likewise.
2251         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2252         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2253         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2254         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2255         (objfpy_set_type_printers): Likewise.
2256
2257 2019-01-03  Tom Tromey  <tom@tromey.com>
2258
2259         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2260         (gdbpy_print_stack): Use gdbpy_err_fetch.
2261         * python/python-internal.h (class gdbpy_err_fetch): New class.
2262         (class gdbpy_enter) <m_error_type, m_error_value,
2263         m_error_traceback>: Remove.
2264         <m_error>: New member.
2265         (gdbpy_exception_to_string): Don't declare.
2266         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2267         * python/py-value.c (convert_value_from_python): Use
2268         gdbpy_err_fetch.
2269         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2270         gdbpy_exception_to_string.
2271         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2272         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2273         gdbpy_err_fetch.
2274
2275 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2276
2277         * linux-nat.c (delete_lwp_cleanup): Delete.
2278         (struct lwp_deleter): New struct.
2279         (lwp_info_up): New typedef.
2280         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2281         lwp_info_up.
2282
2283 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2284
2285         * linux-fork.c (class scoped_switch_fork_info): New class.
2286         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2287
2288 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * valops.c (find_overload_match): Remove use of null_cleanup, and
2291         calls to do_cleanups.
2292
2293 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         * compile/compile-cplus-types.c
2296         (compile_cplus_instance::decl_name): Handle changes to
2297         cp_func_name.
2298         * cp-support.c (cp_func_name): Update header comment, update
2299         return type.
2300         * cp-support.h (cp_func_name): Update return type in declaration.
2301         * valops.c (find_overload_match): Move temp_func local to top
2302         level of function and change its type.  Use temp_func to hold and
2303         delete temporary string obtained from cp_func_name.
2304
2305 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2306
2307         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2308         gdb::char_vector, remove cleanup, and update uses of `msg`.
2309
2310 2019-01-03  Jim Wilson  <jimw@sifive.com>
2311
2312         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2313
2314 2019-01-02  Tom Tromey  <tom@tromey.com>
2315
2316         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2317         (tdesc_parse_xml): Remove cleanups.
2318         * target-descriptions.h (make_cleanup_free_target_description):
2319         Don't declare.
2320         (target_desc_deleter): New struct.
2321         (target_desc_up): New typedef.
2322         * target-descriptions.c (target_desc_deleter::operator()): Rename
2323         from free_target_description.
2324         (make_cleanup_free_target_description): Remove.
2325
2326 2019-01-02  Tom Tromey  <tom@tromey.com>
2327
2328         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2329         constructor, destructor.
2330         (linespec_parser): Remove typedef.
2331         (~linespec_parser): Rename from linespec_parser_delete.
2332         (linespec_lex_to_end, linespec_complete_label)
2333         (linespec_complete): Update.
2334         (decode_line_full): Remove cleanups.
2335         (decode_line_1): Update.
2336
2337 2019-01-02  Tom Tromey  <tom@tromey.com>
2338
2339         * python/python-internal.h (inferior_to_inferior_object): Change
2340         return type.
2341         * python/py-exitedevent.c (create_exited_event_object): Update.
2342         * python/py-inferior.c (inferior_to_inferior_object): Return
2343         gdbpy_ref.
2344         (python_new_inferior, python_inferior_deleted)
2345         (thread_to_thread_object, delete_thread_object)
2346         (build_inferior_list, gdbpy_selected_inferior): Update.
2347         * python/py-infthread.c (create_thread_object): Update.  Also fail
2348         if inferior_to_inferior_object fails.
2349
2350 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2351
2352         * inferior.h (class inferior) <displaced_step_state>: New field.
2353         * infrun.h (struct displaced_step_state): Move here from
2354         infrun.c.  Initialize fields, add constructor.
2355         <inf>: Remove field.
2356         <reset>: New method.
2357         * infrun.c (struct displaced_step_inferior_state): Move to
2358         infrun.h.
2359         (displaced_step_inferior_states): Remove.
2360         (get_displaced_stepping_state): Adust.
2361         (displaced_step_in_progress_any_inferior): Adjust.
2362         (displaced_step_in_progress_thread): Adjust.
2363         (displaced_step_in_progress): Adjust.
2364         (add_displaced_stepping_state): Remove.
2365         (get_displaced_step_closure_by_addr): Adjust.
2366         (remove_displaced_stepping_state): Remove.
2367         (infrun_inferior_exit): Call displaced_step_state.reset.
2368         (use_displaced_stepping): Don't check for NULL.
2369         (displaced_step_prepare_throw): Call
2370         get_displaced_stepping_state.
2371         (displaced_step_fixup): Don't check for NULL.
2372         (prepare_for_detach): Don't check for NULL.
2373
2374 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2375
2376         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2377          in case of call that did not complete.
2378
2379 2019-01-02  Andrey Utkin  <autkin@undo.io>
2380
2381         * symfile.c (find_separate_debug_file): Fix search of debug files for
2382         remote debuggee.
2383
2384 2019-01-02  Tom Tromey  <tom@tromey.com>
2385
2386         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2387         indentation.
2388         * python/py-frame.c (frapy_older): Remove cast.
2389         (frapy_newer): Likewise.
2390         * python/py-breakpoint.c (local_setattro): Remove cast.
2391         * python/py-arch.c (archpy_name): Remove local variable.
2392         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2393
2394 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2395
2396         * unittests/basic_string_view/element_access/char/empty.cc:
2397         Fix year range in copyright header.
2398
2399 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2400
2401         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2402         Delete.
2403         <operator==>: Update with for removed field.
2404         <hash>: Likewise.
2405         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2406         <isa_features>: ...this.
2407         <abi_features>: New field.
2408         (riscv_isa_flen): Update comment.
2409         (riscv_abi_xlen): New declaration.
2410         (riscv_abi_flen): New declaration.
2411         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2412         isa_features.
2413         (riscv_abi_xlen): New function.
2414         (riscv_isa_flen): Update to get answer from isa_features.
2415         (riscv_abi_flen): New function.
2416         (riscv_has_fp_abi): Update to get answer from abi_features.
2417         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2418         xlen and flen.
2419         (riscv_call_info) <xlen, flen>: Update comment.
2420         (riscv_call_arg_struct): Remove invalid assertions
2421         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2422         is removed.
2423         (riscv_gdbarch_init): Gather isa features and abi features
2424         separately, ensure both match on the gdbarch when reusing an old
2425         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2426         a target with 64-bit float hardware.
2427
2428 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2429
2430         * source.c (search_command_helper): Stop reverse search
2431         when line 1 has been searched.
2432
2433 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2434
2435         * record-full.c (record_full_base_target::close): Rewrite
2436         record_full_core_buf_list free logic.
2437
2438 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2439
2440         * break-catch-syscall.c (print_one_catch_syscall): xfree
2441         the last text.
2442
2443 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2444
2445         * top.c (print_gdb_version): Update Copyright year in version
2446         message.
2447
2448 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2449
2450         Update copyright year range in all GDB files.
2451
2452 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2453
2454         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2455
2456 For older changes see ChangeLog-2018.
2457 \f
2458 Local Variables:
2459 mode: change-log
2460 left-margin: 8
2461 fill-column: 74
2462 version-control: never
2463 coding: utf-8
2464 End:
2465