gdb/ChangeLog

   1 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
   2
   3         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
   4
   5 2019-02-05  Tom Tromey  <tom@tromey.com>
   6
   7         * target.c (target_stack::unpush): Move assertion earlier.
   8
   9 2019-01-30  Tom Tromey  <tom@tromey.com>
  10
  11         PR python/23615:
  12         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
  13         (gdbpy_parse_and_eval): Likewise.
  14         * python/python-internal.h (gdbpy_allow_threads): New class.
  15
  16 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
  17
  18         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
  19         (aarch64_fbsd_fpregmap): Move earlier.
  20         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
  21         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
  22         instead of individual calls to trad_frame_set_reg_addr.
  23         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
  24         earlier.
  25         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
  26         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
  27         instead of individual calls to trad_frame_set_reg_addr.
  28
  29 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
  30
  31         * CONTRIBUTE: Replace contribution list with wiki link.
  32
  33 2019-01-25  Tom Tromey  <tom@tromey.com>
  34
  35         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
  36
  37 2019-01-25  Tom Tromey  <tom@tromey.com>
  38
  39         * xtensa-linux-nat.c: Fix common/ includes.
  40         * xml-support.h: Fix common/ includes.
  41         * xml-support.c: Fix common/ includes.
  42         * x86-linux-nat.c: Fix common/ includes.
  43         * windows-nat.c: Fix common/ includes.
  44         * varobj.h: Fix common/ includes.
  45         * varobj.c: Fix common/ includes.
  46         * value.c: Fix common/ includes.
  47         * valops.c: Fix common/ includes.
  48         * utils.c: Fix common/ includes.
  49         * unittests/xml-utils-selftests.c: Fix common/ includes.
  50         * unittests/utils-selftests.c: Fix common/ includes.
  51         * unittests/unpack-selftests.c: Fix common/ includes.
  52         * unittests/tracepoint-selftests.c: Fix common/ includes.
  53         * unittests/style-selftests.c: Fix common/ includes.
  54         * unittests/string_view-selftests.c: Fix common/ includes.
  55         * unittests/scoped_restore-selftests.c: Fix common/ includes.
  56         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
  57         * unittests/scoped_fd-selftests.c: Fix common/ includes.
  58         * unittests/rsp-low-selftests.c: Fix common/ includes.
  59         * unittests/parse-connection-spec-selftests.c: Fix common/
  60         includes.
  61         * unittests/optional-selftests.c: Fix common/ includes.
  62         * unittests/offset-type-selftests.c: Fix common/ includes.
  63         * unittests/observable-selftests.c: Fix common/ includes.
  64         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
  65         * unittests/memrange-selftests.c: Fix common/ includes.
  66         * unittests/memory-map-selftests.c: Fix common/ includes.
  67         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
  68         * unittests/function-view-selftests.c: Fix common/ includes.
  69         * unittests/environ-selftests.c: Fix common/ includes.
  70         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
  71         * unittests/common-utils-selftests.c: Fix common/ includes.
  72         * unittests/cli-utils-selftests.c: Fix common/ includes.
  73         * unittests/array-view-selftests.c: Fix common/ includes.
  74         * ui-file.c: Fix common/ includes.
  75         * tui/tui-io.c: Fix common/ includes.
  76         * tracepoint.h: Fix common/ includes.
  77         * tracepoint.c: Fix common/ includes.
  78         * tracefile-tfile.c: Fix common/ includes.
  79         * top.h: Fix common/ includes.
  80         * top.c: Fix common/ includes.
  81         * thread.c: Fix common/ includes.
  82         * target/waitstatus.h: Fix common/ includes.
  83         * target/waitstatus.c: Fix common/ includes.
  84         * target.h: Fix common/ includes.
  85         * target.c: Fix common/ includes.
  86         * target-memory.c: Fix common/ includes.
  87         * target-descriptions.c: Fix common/ includes.
  88         * symtab.h: Fix common/ includes.
  89         * symfile.c: Fix common/ includes.
  90         * stap-probe.c: Fix common/ includes.
  91         * spu-linux-nat.c: Fix common/ includes.
  92         * sparc-nat.c: Fix common/ includes.
  93         * source.c: Fix common/ includes.
  94         * solib.c: Fix common/ includes.
  95         * solib-target.c: Fix common/ includes.
  96         * ser-unix.c: Fix common/ includes.
  97         * ser-tcp.c: Fix common/ includes.
  98         * ser-pipe.c: Fix common/ includes.
  99         * ser-base.c: Fix common/ includes.
 100         * selftest-arch.c: Fix common/ includes.
 101         * s12z-tdep.c: Fix common/ includes.
 102         * rust-exp.y: Fix common/ includes.
 103         * rs6000-aix-tdep.c: Fix common/ includes.
 104         * riscv-tdep.c: Fix common/ includes.
 105         * remote.c: Fix common/ includes.
 106         * remote-notif.h: Fix common/ includes.
 107         * remote-fileio.h: Fix common/ includes.
 108         * remote-fileio.c: Fix common/ includes.
 109         * regcache.h: Fix common/ includes.
 110         * regcache.c: Fix common/ includes.
 111         * record-btrace.c: Fix common/ includes.
 112         * python/python.c: Fix common/ includes.
 113         * python/py-type.c: Fix common/ includes.
 114         * python/py-inferior.c: Fix common/ includes.
 115         * progspace.h: Fix common/ includes.
 116         * producer.c: Fix common/ includes.
 117         * procfs.c: Fix common/ includes.
 118         * proc-api.c: Fix common/ includes.
 119         * printcmd.c: Fix common/ includes.
 120         * ppc-linux-nat.c: Fix common/ includes.
 121         * parser-defs.h: Fix common/ includes.
 122         * osdata.c: Fix common/ includes.
 123         * obsd-nat.c: Fix common/ includes.
 124         * nat/x86-linux.c: Fix common/ includes.
 125         * nat/x86-linux-dregs.c: Fix common/ includes.
 126         * nat/x86-dregs.h: Fix common/ includes.
 127         * nat/x86-dregs.c: Fix common/ includes.
 128         * nat/ppc-linux.c: Fix common/ includes.
 129         * nat/mips-linux-watch.h: Fix common/ includes.
 130         * nat/mips-linux-watch.c: Fix common/ includes.
 131         * nat/linux-waitpid.c: Fix common/ includes.
 132         * nat/linux-ptrace.h: Fix common/ includes.
 133         * nat/linux-ptrace.c: Fix common/ includes.
 134         * nat/linux-procfs.c: Fix common/ includes.
 135         * nat/linux-personality.c: Fix common/ includes.
 136         * nat/linux-osdata.c: Fix common/ includes.
 137         * nat/linux-namespaces.c: Fix common/ includes.
 138         * nat/linux-btrace.h: Fix common/ includes.
 139         * nat/linux-btrace.c: Fix common/ includes.
 140         * nat/fork-inferior.c: Fix common/ includes.
 141         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 142         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 143         * nat/aarch64-linux.c: Fix common/ includes.
 144         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 145         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 146         * namespace.h: Fix common/ includes.
 147         * mips-linux-tdep.c: Fix common/ includes.
 148         * minsyms.c: Fix common/ includes.
 149         * mi/mi-parse.h: Fix common/ includes.
 150         * mi/mi-main.c: Fix common/ includes.
 151         * mi/mi-cmd-env.c: Fix common/ includes.
 152         * memrange.h: Fix common/ includes.
 153         * memattr.c: Fix common/ includes.
 154         * maint.h: Fix common/ includes.
 155         * maint.c: Fix common/ includes.
 156         * main.c: Fix common/ includes.
 157         * machoread.c: Fix common/ includes.
 158         * location.c: Fix common/ includes.
 159         * linux-thread-db.c: Fix common/ includes.
 160         * linux-nat.c: Fix common/ includes.
 161         * linux-fork.c: Fix common/ includes.
 162         * inline-frame.c: Fix common/ includes.
 163         * infrun.c: Fix common/ includes.
 164         * inflow.c: Fix common/ includes.
 165         * inferior.h: Fix common/ includes.
 166         * inferior.c: Fix common/ includes.
 167         * infcmd.c: Fix common/ includes.
 168         * inf-ptrace.c: Fix common/ includes.
 169         * inf-child.c: Fix common/ includes.
 170         * ia64-linux-nat.c: Fix common/ includes.
 171         * i387-tdep.c: Fix common/ includes.
 172         * i386-tdep.c: Fix common/ includes.
 173         * i386-linux-tdep.c: Fix common/ includes.
 174         * i386-linux-nat.c: Fix common/ includes.
 175         * i386-go32-tdep.c: Fix common/ includes.
 176         * i386-fbsd-tdep.c: Fix common/ includes.
 177         * i386-fbsd-nat.c: Fix common/ includes.
 178         * guile/scm-type.c: Fix common/ includes.
 179         * guile/guile.c: Fix common/ includes.
 180         * go32-nat.c: Fix common/ includes.
 181         * gnu-nat.c: Fix common/ includes.
 182         * gdbthread.h: Fix common/ includes.
 183         * gdbarch-selftests.c: Fix common/ includes.
 184         * gdb_usleep.c: Fix common/ includes.
 185         * gdb_select.h: Fix common/ includes.
 186         * gdb_bfd.c: Fix common/ includes.
 187         * gcore.c: Fix common/ includes.
 188         * fork-child.c: Fix common/ includes.
 189         * findvar.c: Fix common/ includes.
 190         * fbsd-nat.c: Fix common/ includes.
 191         * event-top.c: Fix common/ includes.
 192         * event-loop.c: Fix common/ includes.
 193         * dwarf2read.c: Fix common/ includes.
 194         * dwarf2loc.c: Fix common/ includes.
 195         * dwarf2-frame.c: Fix common/ includes.
 196         * dwarf-index-cache.c: Fix common/ includes.
 197         * dtrace-probe.c: Fix common/ includes.
 198         * disasm-selftests.c: Fix common/ includes.
 199         * defs.h: Fix common/ includes.
 200         * csky-tdep.c: Fix common/ includes.
 201         * cp-valprint.c: Fix common/ includes.
 202         * cp-support.h: Fix common/ includes.
 203         * cp-support.c: Fix common/ includes.
 204         * corelow.c: Fix common/ includes.
 205         * completer.h: Fix common/ includes.
 206         * completer.c: Fix common/ includes.
 207         * compile/compile.c: Fix common/ includes.
 208         * compile/compile-loc2c.c: Fix common/ includes.
 209         * compile/compile-cplus-types.c: Fix common/ includes.
 210         * compile/compile-cplus-symbols.c: Fix common/ includes.
 211         * command.h: Fix common/ includes.
 212         * cli/cli-dump.c: Fix common/ includes.
 213         * cli/cli-cmds.c: Fix common/ includes.
 214         * charset.c: Fix common/ includes.
 215         * build-id.c: Fix common/ includes.
 216         * btrace.h: Fix common/ includes.
 217         * btrace.c: Fix common/ includes.
 218         * breakpoint.h: Fix common/ includes.
 219         * breakpoint.c: Fix common/ includes.
 220         * ax.h:
 221         (enum agent_op): Fix common/ includes.
 222         * ax-general.c (struct aop_map): Fix common/ includes.
 223         * ax-gdb.c: Fix common/ includes.
 224         * auxv.c: Fix common/ includes.
 225         * auto-load.c: Fix common/ includes.
 226         * arm-tdep.c: Fix common/ includes.
 227         * arch/riscv.c: Fix common/ includes.
 228         * arch/ppc-linux-common.c: Fix common/ includes.
 229         * arch/i386.c: Fix common/ includes.
 230         * arch/arm.c: Fix common/ includes.
 231         * arch/arm-linux.c: Fix common/ includes.
 232         * arch/arm-get-next-pcs.c: Fix common/ includes.
 233         * arch/amd64.c: Fix common/ includes.
 234         * arch/aarch64.c: Fix common/ includes.
 235         * arch/aarch64-insn.c: Fix common/ includes.
 236         * arch-utils.c: Fix common/ includes.
 237         * amd64-windows-tdep.c: Fix common/ includes.
 238         * amd64-tdep.c: Fix common/ includes.
 239         * amd64-sol2-tdep.c: Fix common/ includes.
 240         * amd64-obsd-tdep.c: Fix common/ includes.
 241         * amd64-nbsd-tdep.c: Fix common/ includes.
 242         * amd64-linux-tdep.c: Fix common/ includes.
 243         * amd64-linux-nat.c: Fix common/ includes.
 244         * amd64-fbsd-tdep.c: Fix common/ includes.
 245         * amd64-fbsd-nat.c: Fix common/ includes.
 246         * amd64-dicos-tdep.c: Fix common/ includes.
 247         * amd64-darwin-tdep.c: Fix common/ includes.
 248         * agent.c: Fix common/ includes.
 249         * ada-lang.h: Fix common/ includes.
 250         * ada-lang.c: Fix common/ includes.
 251         * aarch64-tdep.c: Fix common/ includes.
 252
 253 2019-01-25  Tom Tromey  <tom@tromey.com>
 254
 255         * common/create-version.sh: Use common/version.h.
 256
 257 2019-01-24  Pedro Alves  <palves@redhat.com>
 258
 259         * infrun.c (signal_stop, signal_print, signal_program)
 260         (signal_catch, signal_pass): Now arrays instead of pointers.
 261         (update_signals_program_target, do_target_resume)
 262         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 263         * linux-nat.c (linux_nat_target::pass_signals)
 264         (linux_nat_target::create_inferior, linux_nat_target::attach):
 265         Adjust.
 266         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 267         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 268         * procfs.c (procfs_target::pass_signals): Adjust.
 269         * record-full.c (record_full_target::resume): Adjust.
 270         * remote.c (remote_target::pass_signals)
 271         (remote_target::program_signals): Adjust.
 272         * target-debug.h (target_debug_print_signals): Now takes a
 273         gdb::array_view as parameter.  Adjust.
 274         * target.h (target_ops) <pass_signals, program_signals>: Replace
 275         pointer and length parameters with gdb::array_view.
 276         (target_pass_signals, target_program_signals): Likewise.
 277         * target-delegates.c: Regenerate.
 278
 279 2019-01-24  Pedro Alves  <palves@redhat.com>
 280
 281         * common/forward-scope-exit.h
 282         (forward_scope_exit::forward_scope_exit): Pass arguments to
 283         m_bind_function directly, instead of creating a std::bind and
 284         copying that.
 285
 286 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 287
 288         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 289         for static members.
 290         (pass_in_v_vfp_candidate): Likewise.
 291
 292 2019-01-23  Tom Tromey  <tom@tromey.com>
 293             Pedro Alves  <palves@redhat.com>
 294
 295         * regcache.c (class regcache_invalidator): Remove.
 296         (regcache::raw_write): Use make_scope_exit.
 297
 298 2019-01-23  Tom Tromey  <tom@tromey.com>
 299
 300         * ui-out.h (class ui_out_emit_type): Update comment.
 301
 302 2019-01-23  Tom Tromey  <tom@tromey.com>
 303
 304         * infrun.c (fetch_inferior_event): Update comment.
 305
 306 2019-01-23  Tom Tromey  <tom@tromey.com>
 307             Pedro Alves  <palves@redhat.com>
 308
 309         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 310         parameter.
 311         (fetch_inferior_event): Use SCOPE_EXIT.
 312
 313
 314 2019-01-23  Tom Tromey  <tom@tromey.com>
 315             Pedro Alves  <palves@redhat.com>
 316
 317         * infrun.c (disable_thread_events): Delete.
 318         (stop_all_threads): Use SCOPE_EXIT.
 319
 320 2019-01-23  Tom Tromey  <tom@tromey.com>
 321             Pedro Alves  <palves@redhat.com>
 322
 323         * symfile.c: Include forward-scope-exit.h.
 324         (clear_symtab_users_cleanup): Replace forward declaration with
 325         a FORWARD_SCOPE_EXIT.
 326         (syms_from_objfile_1): Use the forward_scope_exit and
 327         gdb::optional instead of cleanup_function.
 328         (reread_symbols): Use the forward_scope_exit instead of
 329         cleanup_function.
 330         (clear_symtab_users_cleanup): Remove function.
 331
 332 2019-01-23  Tom Tromey  <tom@tromey.com>
 333             Pedro Alves  <palves@redhat.com>
 334
 335         * linux-nat.c: Include scope-exit.h.
 336         (cleanup_target_stop): Remove.
 337         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 338         SCOPE_EXIT.
 339
 340 2019-01-23  Tom Tromey  <tom@tromey.com>
 341             Pedro Alves  <palves@redhat.com>
 342
 343         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 344         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 345
 346 2019-01-23  Tom Tromey  <tom@tromey.com>
 347             Andrew Burgess  <andrew.burgess@embecosm.com>
 348             Pedro Alves  <palves@redhat.com>
 349
 350         * infrun.c (fetch_inferior_event): Use scope_exit.
 351         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 352         * top.c (execute_command): Use scope_exit.
 353         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 354         * utils.c (do_bpstat_clear_actions_cleanup)
 355         (make_bpstat_clear_actions_cleanup): Remove.
 356
 357 2019-01-23  Tom Tromey  <tom@tromey.com>
 358             Pedro Alves  <palves@redhat.com>
 359
 360         * infrun.c: Include "common/scope-exit.h"
 361         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 362         (wait_for_inferior): Use SCOPE_EXIT.
 363         (fetch_inferior_event): Use scope_exit.
 364
 365 2019-01-23  Tom Tromey  <tom@tromey.com>
 366             Pedro Alves  <palves@redhat.com>
 367
 368         * breakpoint.c (create_breakpoint): Remove cleanup.
 369
 370 2019-01-23  Tom Tromey  <tom@tromey.com>
 371             Andrew Burgess  <andrew.burgess@embecosm.com>
 372             Pedro Alves  <palves@redhat.com>
 373
 374 2019-01-23  Pedro Alves  <palves@redhat.com>
 375
 376         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 377
 378 2019-01-23  Pedro Alves  <palves@redhat.com>
 379             Andrew Burgess  <andrew.burgess@embecosm.com>
 380
 381         * gdbthread.h: Include "common/forward-scope-exit.h".
 382         (scoped_finish_thread_state): Redefine custom class in terms of
 383         forward_scope_exit.
 384
 385 2019-01-23  Pedro Alves  <palves@redhat.com>
 386             Andrew Burgess  <andrew.burgess@embecosm.com>
 387
 388         * common/forward-scope-exit.h: New file.
 389
 390 2019-01-23  Pedro Alves  <palves@redhat.com>
 391             Andrew Burgess  <andrew.burgess@embecosm.com>
 392             Tom Tromey  <tom@tromey.com>
 393
 394         * common/scope-exit.h: New file.
 395
 396 2019-01-23  Pedro Alves  <palves@redhat.com>
 397
 398         * common/preprocessor.h (ESC): Rename to ...
 399         (ESC_PARENS): ... this.
 400         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 401         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 402
 403 2019-01-23  Tom Tromey  <tom@tromey.com>
 404
 405         * language.h (class scoped_switch_to_sym_language_if_auto):
 406         Initialize m_lang in both cases.
 407
 408 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 409
 410         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 411         with XCNEW.
 412
 413 2019-01-22  Tom Tromey  <tom@tromey.com>
 414
 415         * corelow.c: Do not include sys/file.h.
 416
 417 2019-01-22  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-wingeneral.h: Include gdb_curses.h.
 420
 421 2019-01-22  Tom Tromey  <tom@tromey.com>
 422
 423         * source-cache.h (class source_cache) <get_source_lines,
 424         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 425
 426 2019-01-22  Tom Tromey  <tom@tromey.com>
 427
 428         * remote-fileio.h (struct remote_target): Declare.
 429
 430 2019-01-22  Tom Tromey  <tom@tromey.com>
 431
 432         * python/py-arch.c: Do not include py-ref.h.
 433         * python/py-bpevent.c: Do not include py-ref.h.
 434         * python/py-cmd.c: Do not include py-ref.h.
 435         * python/py-continueevent.c: Do not include py-ref.h.
 436         * python/py-event.h: Do not include py-ref.h.
 437         * python/py-evtregistry.c: Do not include py-ref.h.
 438         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 439         * python/py-frame.c: Do not include py-ref.h.
 440         * python/py-framefilter.c: Do not include py-ref.h.
 441         * python/py-function.c: Do not include py-ref.h.
 442         * python/py-infevents.c: Do not include py-ref.h.
 443         * python/py-linetable.c: Do not include py-ref.h.
 444         * python/py-objfile.c: Do not include py-ref.h.
 445         * python/py-param.c: Do not include py-ref.h.
 446         * python/py-prettyprint.c: Do not include py-ref.h.
 447         * python/py-progspace.c: Do not include py-ref.h.
 448         * python/py-symbol.c: Do not include py-ref.h.
 449         * python/py-symtab.c: Do not include py-ref.h.
 450         * python/py-type.c: Do not include py-ref.h.
 451         * python/py-unwind.c: Do not include py-ref.h.
 452         * python/py-utils.c: Do not include py-ref.h.
 453         * python/py-value.c: Do not include py-ref.h.
 454         * python/py-varobj.c: Do not include py-ref.h.
 455         * python/py-xmethods.c: Do not include py-ref.h.
 456         * python/python.c: Do not include py-ref.h.
 457         * varobj.c: Do not include py-ref.h.
 458
 459 2019-01-22  Tom Tromey  <tom@tromey.com>
 460
 461         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 462         keyword for bcache.
 463
 464 2019-01-22  Tom Tromey  <tom@tromey.com>
 465
 466         * compile/compile-cplus-types.c: Remove a comment by #include.
 467
 468 2019-01-22  Tom Tromey  <tom@tromey.com>
 469
 470         * compile/gcc-c-plugin.h: Include compile-internal.h.
 471
 472 2019-01-22  Tom Tromey  <tom@tromey.com>
 473
 474         * stabsread.c (EXTERN): Do not define.
 475         (symnum, next_symbol_text_func, processing_gcc_compilation)
 476         (within_function, global_sym_chain, global_stabs)
 477         (previous_stab_code, this_object_header_files)
 478         (n_this_object_header_files)
 479         (n_allocated_this_object_header_files): Define.
 480         * stabsread.h (EXTERN): Never define.  Use "extern".
 481
 482 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 483
 484         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 485         history_value.
 486
 487 2019-01-21  Tom Tromey  <tom@tromey.com>
 488
 489         * ui-out.c: Fix includes.
 490         * tui/tui-source.c: Fix includes.
 491         * target.c: Fix includes.
 492         * remote.c: Fix includes.
 493         * regcache.c: Fix includes.
 494         * python/py-block.c: Fix includes.
 495         * printcmd.c: Fix includes.
 496         * or1k-tdep.c: Fix includes.
 497         * mi/mi-main.c: Fix includes.
 498         * m32r-tdep.c: Fix includes.
 499         * csky-tdep.c: Fix includes.
 500         * compile/compile-cplus-types.c: Fix includes.
 501         * cli/cli-interp.c: Fix includes.
 502
 503 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 504
 505         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 506         for padding.
 507
 508 2019-01-16  Tom Tromey  <tom@tromey.com>
 509
 510         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 511         earlier.
 512         (struct objfile) <msymbols_range>: Move from top level.
 513         <msymbols>: New method.
 514         (class objfile_msymbols): Remove.
 515         * symtab.c (default_collect_symbol_completion_matches_break_on):
 516         Update.
 517         * symmisc.c (dump_msymbols): Update.
 518         * stabsread.c (scan_file_globals): Update.
 519         * objc-lang.c (info_selectors_command, info_classes_command)
 520         (find_methods): Update.
 521         * minsyms.c (find_solib_trampoline_target): Update.
 522         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 523         * coffread.c (coff_symfile_read): Update.
 524         * ada-lang.c (ada_lookup_simple_minsym)
 525         (ada_collect_symbol_completion_matches): Update.
 526
 527 2019-01-16  Tom Tromey  <tom@tromey.com>
 528
 529         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 530         type.  Remove no-argument constructor.
 531         <iterator::operator++>: Simplify.
 532         <begin>: Update.
 533         <end>: Use minimal_symbol_count.
 534
 535 2019-01-16  Tom Tromey  <tom@tromey.com>
 536
 537         * objfiles.h (struct objfile) <psymtabs>: New method.
 538         (class objfile_psymtabs): Remove.
 539         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 540         typedef.
 541         <range>: New method.
 542         (require_partial_symbols): Change return type.
 543         * psymtab.c (require_partial_symbols)
 544         (psym_expand_symtabs_matching): Update.
 545         * mdebugread.c (parse_partial_symbols): Update.
 546         * dbxread.c (dbx_end_psymtab): Update.
 547
 548 2019-01-15  Tom Tromey  <tom@tromey.com>
 549
 550         * symtab.c (lookup_objfile_from_block)
 551         (lookup_symbol_in_objfile_symtabs)
 552         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 553         (find_line_symtab, info_sources_command)
 554         (default_collect_symbol_completion_matches_break_on)
 555         (make_source_files_completion_list): Update.
 556         * symmisc.c (print_objfile_statistics, dump_objfile)
 557         (maintenance_print_symbols, maintenance_info_symtabs)
 558         (maintenance_check_symtabs, maintenance_info_line_tables):
 559         Update.
 560         * source.c (select_source_symtab)
 561         (forget_cached_source_info_for_objfile): Update.
 562         * objfiles.h (class objfile_compunits): Remove.
 563         (struct objfile) <compunits_range>: New typedef.
 564         (compunits): New method.
 565         * objfiles.c (objfile_relocate1): Update.
 566         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 567         * maint.c (count_symtabs_and_blocks): Update.
 568         * linespec.c (iterate_over_all_matching_symtabs): Update.
 569         * cp-support.c (add_symbol_overload_list_qualified): Update.
 570         * coffread.c (coff_symtab_read): Update.
 571         * ada-lang.c (add_nonlocal_symbols)
 572         (ada_collect_symbol_completion_matches)
 573         (ada_add_global_exceptions): Update.
 574
 575 2019-01-15  Tom Tromey  <tom@tromey.com>
 576
 577         * progspace.h (program_space) <objfiles_safe_range>: New
 578         typedef.
 579         <objfiles_safe>: New method.
 580         * objfiles.h (class all_objfiles_safe): Remove.
 581         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 582         * jit.c (jit_inferior_exit_hook): Update.
 583
 584 2019-01-17  Tom Tromey  <tom@tromey.com>
 585
 586         * progspace.h (program_space) <objfiles_range>: New typedef.
 587         <objfiles>: New method.
 588         <objfiles_head>: Rename from objfiles.
 589         (object_files): Update.
 590         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 591         * guile/scm-pretty-print.c
 592         (ppscm_find_pretty_printer_from_objfiles): Update.
 593         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 594         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 595         Update.
 596         * python/py-progspace.c (pspy_get_objfiles): Update.
 597         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 598         Update.
 599         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 600         (objfpy_lookup_objfile_by_build_id): Update.
 601         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 602         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 603         Update.
 604         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 605         (expand_symtab_containing_pc, lookup_objfile_from_block)
 606         (lookup_static_symbol, basic_lookup_transparent_type)
 607         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 608         (find_line_symtab, info_sources_command)
 609         (default_collect_symbol_completion_matches_break_on)
 610         (make_source_files_completion_list, find_main_name): Update.
 611         * symmisc.c (print_symbol_bcache_statistics)
 612         (print_objfile_statistics, maintenance_print_symbols)
 613         (maintenance_print_msymbols, maintenance_print_objfiles)
 614         (maintenance_info_symtabs, maintenance_check_symtabs)
 615         (maintenance_expand_symtabs, maintenance_info_line_tables):
 616         Update.
 617         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 618         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 619         (map_overlay_command, unmap_overlay_command)
 620         (simple_overlay_update, expand_symtabs_matching)
 621         (map_symbol_filenames): Update.
 622         * symfile-debug.c (set_debug_symfile): Update.
 623         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 624         Update.
 625         * source.c (select_source_symtab, forget_cached_source_info):
 626         Update.
 627         * solib.c (solib_read_symbols): Update.
 628         * solib-spu.c (append_ocl_sos): Update.
 629         * psymtab.c (maintenance_print_psymbols)
 630         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 631         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 632         * printcmd.c (info_symbol_command): Update.
 633         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 634         Update.
 635         * objfiles.h (class all_objfiles): Remove.
 636         * objfiles.c (have_partial_symbols, have_full_symbols)
 637         (have_minimal_symbols, qsort_cmp, update_section_map)
 638         (shared_objfile_contains_address_p)
 639         (default_iterate_over_objfiles_in_search_order): Update.
 640         * objc-lang.c (info_selectors_command, info_classes_command)
 641         (find_methods): Update.
 642         * minsyms.c (find_solib_trampoline_target): Update.
 643         * maint.c (maintenance_info_sections)
 644         (maintenance_translate_address, count_symtabs_and_blocks):
 645         Update.
 646         * main.c (captured_main_1): Update.
 647         * linux-thread-db.c (try_thread_db_load_from_pdir)
 648         (has_libpthread): Update.
 649         * linespec.c (iterate_over_all_matching_symtabs)
 650         (search_minsyms_for_name): Update.
 651         * jit.c (jit_find_objf_with_entry_addr): Update.
 652         * hppa-tdep.c (find_unwind_entry)
 653         (hppa_lookup_stub_minimal_symbol): Update.
 654         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 655         Update.
 656         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 657         (elf_gnu_ifunc_resolve_by_got): Update.
 658         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 659         * dwarf-index-write.c (save_gdb_index_command): Update.
 660         * cp-support.c (add_symbol_overload_list_qualified): Update.
 661         * breakpoint.c (create_overlay_event_breakpoint)
 662         (create_longjmp_master_breakpoint)
 663         (create_std_terminate_master_breakpoint)
 664         (create_exception_master_breakpoint): Update.
 665         * blockframe.c (find_pc_partial_function): Update.
 666         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 667         (ada_collect_symbol_completion_matches)
 668         (ada_add_global_exceptions): Update.
 669
 670 2019-01-17  Tom Tromey  <tom@tromey.com>
 671
 672         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 673         declare VEC.
 674         (solib_target_parse_libraries): Change return type.
 675         (library_list_start_segment, library_list_start_section)
 676         (library_list_end_library, library_list_start_library); Update.
 677         (solib_target_free_library_list): Remove.
 678         (solib_target_parse_libraries): Remove cleanup.  Change return
 679         type.
 680         (solib_target_current_sos): Update.
 681
 682 2019-01-17  Tom Tromey  <tromey@bapiya>
 683
 684         * valprint.c: Replace "the the" with "the".
 685         * symtab.c: Replace "the the" with "the".
 686         * solib.c: Replace "the the" with "the".
 687         * solib-dsbt.c: Replace "the the" with "the".
 688         * linespec.c: Replace "the the" with "the".
 689         * dwarf2loc.h: Replace "the the" with "the".
 690         * amd64-windows-tdep.c: Replace "the the" with "the".
 691         * aarch64-tdep.c: Replace "the the" with "the".
 692
 693 2019-01-16  Keith Seitz  <keiths@redhat.com>
 694
 695         PR gdb/23773
 696         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 697         <builder>: Rename to ..
 698         <m_builder>: ... this and make private.
 699         (dwarf2_cu::get_builder): New method.  Change all users of
 700         `builder' to use this method.
 701         (dwarf2_start_symtab): Move to ...
 702         (dwarf2_cu::start_symtab): ... here.  Update all callers
 703         (setup_type_unit_groups): Move to ...
 704         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 705         callers.
 706         (dwarf2_cu::reset_builder): New method.
 707         (process_full_compunit, process_full_type_unit): Use
 708         dwarf2_cu::reset_builder.
 709         (follow_die_offset): Record the ancestor CU if it is different
 710         from the followed DIE's CU.
 711         (follow_die_sig_1): Likewise.
 712
 713 2019-01-15  Tom Tromey  <tom@tromey.com>
 714
 715         * remote.c (class remote_state) <buf>: Now a char_vector.
 716         <buf_size>: Remove.
 717         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 718         parameter.
 719         (remote_target::getpkt_or_notif_sane_1)
 720         (remote_target::getpkt_sane)
 721         (remote_target::getpkt_or_notif_sane): Likewise.
 722         (class remote_target) <putpkt>: New overload.
 723         (remote_target::read_frame): Change type of "buf_p".  Remove
 724         sizeof_p parameter.
 725         (packet_ok): New overload.
 726         (packet_check_result): New overload.
 727         Update all uses.
 728
 729 2019-01-14  Tom Tromey  <tom@tromey.com>
 730
 731         * remote-notif.c (handle_notification, remote_notif_ack)
 732         (remote_notif_parse): Make "buf" const.
 733         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 734         const.
 735         (remote_notif_parse, remote_notif_ack, handle_notification):
 736         Likewise.
 737         * remote.c (remote_notif_stop_parse): Make "buf" const.
 738         (remote_target::remote_parse_stop_reply): Make "buf" const.
 739         (remote_notif_stop_ack): Make "buf" const.
 740
 741 2019-01-14  Tom Tromey  <tom@tromey.com>
 742
 743         * remote.c (remote_console_output): Make parameter const.
 744
 745 2019-01-14  Tom Tromey  <tom@tromey.com>
 746
 747         * target-debug.h (target_debug_print_signals): Constify.
 748         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 749         * procfs.c (procfs_target::pass_signals): Update.
 750         * linux-nat.c (linux_nat_target::pass_signals): Update.
 751         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 752         * target-delegates.c: Rebuild.
 753         * remote.c (remote_target::program_signals): Update.
 754         (remote_target::pass_signals): Update.
 755         * target.c (target_pass_signals): Constify argument.
 756         (target_program_signals): Likewise.
 757         * target.h (struct target_ops) <pass_signals, program_signals>:
 758         Constify argument.
 759         (target_pass_signals, target_program_signals): Constify argument.
 760
 761 2019-01-14  Tom Tromey  <tom@tromey.com>
 762
 763         PR tui/28819:
 764         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 765
 766 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 767
 768         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 769         field.
 770         * rs6000-tdep.c: Include reggroups.h.
 771         (IS_V_ALIAS_PSEUDOREG): Define.
 772         (rs6000_register_name): Return names for the "vX" aliases.
 773         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 774         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 775         aliases.  Call default_register_reggroup_p for all other
 776         pseudo-registers.
 777         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 778         New functions.
 779         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 780         Handle "vX" aliases.
 781         (v_alias_pseudo_register_collect): New function.
 782         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 783         (rs6000_gdbarch_init): Initialize "vX" aliases as
 784         pseudo-registers.  Restore registration of
 785         rs6000_pseudo_register_reggroup_p with
 786         set_tdesc_pseudo_register_reggroup_p.
 787
 788 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 789
 790         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 791         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 792         set_gdbarch_num_pseudo_regs.
 793
 794 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 795
 796         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 797         Remove arg prefixname, add do_set and do_show.
 798         Add member functions set_list and show_list.
 799         * cli/cli-style.c (class cli_style_option): Update accordingly.
 800         (style_set_list): Move to file scope.
 801         (style_show_list): Likewise.
 802         (set_style): Call help_list.
 803         (show_style): Call cmd_show_list.
 804         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 805         Update to use the new macro.
 806
 807 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 808
 809         * ada-lang.c (_initialize_ada_language): Expand the help text
 810         for the "catch exception" command.
 811
 812 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 813
 814         * symtab.c (matching_obj_sections): Initialize obj,
 815         declare it closer to its usage.
 816
 817 2019-01-10  Tom Tromey  <tom@tromey.com>
 818
 819         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 820         (basic_inf_threads_range): Remove.
 821         (inf_threads_range, inf_non_exited_threads_range)
 822         (safe_inf_threads_range): Use next_adapter.
 823
 824 2019-01-10  Keith Seitz  <keiths@redhat.com>
 825
 826         PR gdb/23712
 827         PR symtab/23010
 828         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 829         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 830
 831 2019-01-10  Keith Seitz  <keiths@redhat.com>
 832
 833         PR gdb/23712
 834         PR symtab/23010
 835         * dictionary.c (pending_to_vector): Remove.
 836         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 837         Remove _1 suffix, replacing functions of the same name.  Update
 838         all callers.
 839         (dict_create_hashed, dict_create_hashed_expandable)
 840         (dict_create_linear, dict_create_linear_expandable, dict_free)
 841         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 842         Make functions static.
 843
 844 2019-01-10  Keith Seitz  <keiths@redhat.com>
 845
 846         PR gdb/23712
 847         PR symtab/23010
 848         * dictionary.h (struct dictionary): Replace declaration with
 849         multidictionary.
 850         (dict_create_hashed, dict_create_hashed_expandable)
 851         (dict_create_linear, dict_create_linear_expandable)
 852         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 853         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 854         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 855         taking multidictionary argument.
 856         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 857         * block.h (struct block) <dict>: Change to multidictionary
 858         and rename `multidict'.
 859         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 860         symmisc.c: Update all dictionary references to multidictionary.
 861
 862 2019-01-10  Keith Seitz  <keiths@redhat.com>
 863
 864         PR gdb/23712
 865         PR symtab/23010
 866         * dictionary.c: Include unordered_map.
 867         (pending_to_vector): New function.
 868         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 869         Rewrite the non-"_1" functions to take vector instead
 870         of linked list.
 871         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 872         "new" _1 versions of the same name.
 873         (multidictionary): Define.
 874         (std::hash<enum language): New definition.
 875         (collate_pending_symbols_by_language, mdict_create_hashed)
 876         (mdict_create_hashed_expandable, mdict_create_linear)
 877         (mdict_create_linear_expandable, mdict_free)
 878         (find_language_dictionary, create_new_language_dictionary)
 879         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 880         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 881         (mdict_size, mdict_empty): New functions.
 882         * dictionary.h (mdict_iterator): Define.
 883
 884 2019-01-10  Pedro Alves  <palves@redhat.com>
 885
 886         * breakpoint.c (read_uploaded_action)
 887         (create_tracepoint_from_upload): Adjust to use
 888         gdb::unique_xmalloc_ptr.
 889         * ctf.c (ctf_write_uploaded_tp):
 890         (SET_ARRAY_FIELD): Use emplace_back.
 891         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 892         * tracefile-tfile.c (tfile_write_uploaded_tp):
 893         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 894         gdb::unique_xmalloc_ptr.
 895         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 896         at_string, cond_string, cmd_strings>: Replace char pointers
 897         with gdb::unique_xmalloc_ptr.
 898
 899 2019-01-10  Pedro Alves  <palves@redhat.com>
 900
 901         * solib-target.c (library_list_start_library): Don't xstrdup name.
 902
 903 2019-01-10  Pedro Alves  <palves@redhat.com>
 904
 905         * mdebugread.c (parse_partial_symbols): Use
 906         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 907
 908 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         * linux-fork.c (scoped_switch_fork_info)
 911         <~scoped_switch_fork_info>: Fix incorrect variable name.
 912
 913 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * linux-fork.c (scoped_switch_fork_info)
 916         <scoped_switch_fork_info>: Make explicit.
 917         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 918
 919 2019-01-10  Tom Tromey  <tom@tromey.com>
 920
 921         * objfiles.h (objfile::reset_psymtabs): Update.
 922         * objfiles.c (objfile::objfile): Update.
 923         * psymtab.h (psymtab_storage::obstack): Update.
 924         (psymtab_storage::m_obstack): Use gdb::optional.
 925         (class psymtab_storage): Update comment.  Remove objfile
 926         parameter.
 927         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 928
 929 2019-01-10  Tom Tromey  <tom@tromey.com>
 930
 931         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 932         <free_psymtabs>: Now private.
 933         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 934         (allocate_psymtab): Use new method.
 935
 936 2019-01-10  Tom Tromey  <tom@tromey.com>
 937
 938         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 939         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 940         * mdebugread.c (parse_partial_symbols): Use
 941         allocate_dependencies.
 942         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 943         allocate_dependencies.
 944         (process_psymtab_comp_unit_reader)
 945         (build_type_psymtab_dependencies): Likewise.
 946         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 947
 948 2019-01-10  Tom Tromey  <tom@tromey.com>
 949
 950         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 951         PSYMBOL_SET_LANGUAGE.
 952         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 953
 954 2019-01-10  Tom Tromey  <tom@tromey.com>
 955
 956         * psymtab.h (psymtab_storage::obstack): New method.
 957         <m_obstack>: Rename from obstack; now private.
 958         * psymtab.c (psymtab_storage): Update.
 959         * dwarf2read.c (create_addrmap_from_index)
 960         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 961         Update.
 962
 963 2019-01-10  Tom Tromey  <tom@tromey.com>
 964
 965         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 966         * objfiles.h (objfile::reset_psymtabs): New method.
 967
 968 2019-01-10  Tom Tromey  <tom@tromey.com>
 969
 970         * symmisc.c (print_symbol_bcache_statistics): Update.
 971         (print_objfile_statistics): Update.
 972         * symfile.c (reread_symbols): Update.
 973         * psymtab.h (class psymtab_storage): New.
 974         * psymtab.c (psymtab_storage): New constructor.
 975         (~psymtab_storage): New destructor.
 976         (require_partial_symbols): Update.
 977         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 978         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 979         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 980         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 981         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 982         (start_psymtab_common, end_psymtab_common)
 983         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 984         (allocate_psymtab): Update.
 985         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 986         Update.
 987         (dump_psymtab_addrmap, maintenance_print_psymbols)
 988         (maintenance_check_psymtabs): Update.
 989         (class objfile_psymtabs): Move to objfiles.h.
 990         * psympriv.h (discard_psymtab): Now inline.
 991         (psymtab_discarder::psymtab_discarder): Update.
 992         (psymtab_discarder::~psymtab_discarder): Update.
 993         (ALL_OBJFILE_PSYMTABS): Rewrite.
 994         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 995         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 996         Remove fields.
 997         <partial_symtabs>: New field.
 998         (class objfile_psymtabs): Move from psymtab.h.  Update.
 999         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1000         psymbol_cache.
1001         (objfile::~objfile): Don't destroy psymbol_cache.
1002         * mdebugread.c (parse_partial_symbols): Update.
1003         * dwarf2read.c (create_addrmap_from_index)
1004         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1005         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1006         (add_partial_subprogram, dwarf2_ranges_read): Update.
1007         * dwarf-index-write.c (write_address_map)
1008         (write_one_signatured_type, recursively_write_psymbols)
1009         (class debug_names, class debug_names, write_psymtabs_to_index):
1010         Update.
1011
1012 2019-01-10  Tom Tromey  <tom@tromey.com>
1013
1014         * symtab.h (SYMBOL_SET_NAMES): Update.
1015         (symbol_set_names): Update.
1016         (MSYMBOL_SET_NAMES): Update.
1017         * symtab.c (symbol_set_names): Change argument to be an
1018         objfile_per_bfd_storage.
1019         * psymtab.c (add_psymbol_to_bcache): Update.
1020         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1021
1022 2019-01-10  Tom Tromey  <tom@tromey.com>
1023
1024         * symtab.c (create_demangled_names_hash): Change argument to be an
1025         objfile_per_bfd_storage.
1026         (symbol_set_names): Update.
1027
1028 2019-01-10  Tom Tromey  <tom@tromey.com>
1029
1030         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1031         init_psymbol_list.
1032         * psymtab.c (init_psymbol_list): Do nothing if already called.
1033         * psympriv.h (init_psymbol_list): Add comment.
1034         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1035         init_psymbol_list.
1036         * dbxread.c (dbx_symfile_read): Unconditionally call
1037         init_psymbol_list.
1038
1039 2019-01-10  Tom Tromey  <tom@tromey.com>
1040
1041         * xcoffread.c (scan_xcoff_symtab): Update.
1042         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1043         "where".
1044         * mdebugread.c (parse_partial_symbols)
1045         (handle_psymbol_enumerators): Update.
1046         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1047         * dbxread.c (read_dbx_symtab): Update.
1048         * psympriv.h (psymbol_placement): New enum.
1049         (add_psymbol_to_list): Update.
1050
1051 2019-01-10  Tom Tromey  <tom@tromey.com>
1052
1053         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1054         static_psymbols parameters.
1055         (scan_xcoff_symtab): Update.
1056         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1057         static_psymbols parameters.
1058         * psympriv.h (start_psymtab_common): Update.
1059         * mdebugread.c (parse_partial_symbols): Update.
1060         * dwarf2read.c (create_partial_symtab): Update.
1061         * dbxread.c (read_dbx_symtab): Update.
1062         (start_psymtab): Remove global_psymbols and static_psymbols
1063         parameters.
1064
1065 2019-01-10  Tom Tromey  <tom@tromey.com>
1066
1067         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1068         * psymtab.c (allocate_psymtab): Add comment.
1069         * psympriv.h (allocate_psymtab): Add comment.
1070         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1071         initializations.
1072         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1073
1074 2019-01-10  Tom Tromey  <tom@tromey.com>
1075
1076         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1077         Don't declare.
1078         * mipsread.c: Include mdebugread.h.
1079         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1080         Declare.
1081         * elfread.c: Include mdebugread.h.
1082
1083 2019-01-09  Tom Tromey  <tom@tromey.com>
1084
1085         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1086         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1087         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1088         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1089         (psym_lookup_symbol, psym_find_last_source_symtab)
1090         (psym_forget_cached_source_info, psym_print_stats)
1091         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1092         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1093         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1094         (psym_find_compunit_symtab_by_address)
1095         (maintenance_print_psymbols, maintenance_info_psymtabs)
1096         (maintenance_check_psymtabs): Use ranged for.
1097         * psymtab.h (class objfile_psymtabs): New.
1098         (require_partial_symbols): Return objfile_psymtabs.
1099         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1100
1101 2019-01-09  Tom Tromey  <tom@tromey.com>
1102
1103         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1104         (find_pc_mapped_section, list_overlays_command)
1105         (map_overlay_command, unmap_overlay_command)
1106         (simple_overlay_update): Use all_objfiles.
1107         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1108         * printcmd.c (info_symbol_command): Use all_objfiles.
1109         * objfiles.h (ALL_OBJSECTIONS): Remove.
1110         * maint.c (maintenance_translate_address): Use all_objfiles.
1111         * gcore.c (gcore_create_callback): Use all_objfiles.
1112         (objfile_find_memory_regions): Likewise.
1113
1114 2019-01-09  Tom Tromey  <tom@tromey.com>
1115
1116         * symtab.c (find_line_symtab, info_sources_command)
1117         (make_source_files_completion_list): Use objfile_compunits.
1118         * source.c (select_source_symtab): Use objfile_compunits.
1119         * objfiles.h (struct objfile): Update comment.
1120         (ALL_OBJFILES): Remove.
1121         (ALL_FILETABS): Remove.
1122         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1123         objfile_compunits.
1124
1125 2019-01-09  Tom Tromey  <tom@tromey.com>
1126
1127         * symmisc.c (print_objfile_statistics, dump_objfile)
1128         (maintenance_print_symbols): Use compunit_filetabs.
1129         * source.c (forget_cached_source_info_for_objfile): Use
1130         compunit_filetabs.
1131         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1132         (ALL_FILETABS): Use compunit_filetabs.
1133         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1134         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1135
1136 2019-01-09  Tom Tromey  <tom@tromey.com>
1137
1138         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1139         (compunit_filetabs): New.
1140         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1141         compunit_filetabs.
1142         (info_sources_command, make_source_files_completion_list): Remove
1143         declaration.
1144         * symmisc.c (print_objfile_statistics, dump_objfile)
1145         (maintenance_print_symbols): Remove declaration.
1146         (maintenance_info_symtabs): Use compunit_filetabs.
1147         (maintenance_info_line_tables): Likewise.
1148         * source.c (select_source_symtab): Change local variable name.
1149         (forget_cached_source_info_for_objfile): Remove declaration.
1150         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1151         * objfiles.c (objfile_relocate1): Remove declaration.
1152         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1153         declaration.
1154         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1155         * coffread.c (coff_symtab_read): Remove declaration.
1156         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1157         compunit_filetabs.
1158
1159 2019-01-09  Tom Tromey  <tom@tromey.com>
1160
1161         * symtab.c (lookup_objfile_from_block)
1162         (find_pc_sect_compunit_symtab, search_symbols)
1163         (default_collect_symbol_completion_matches_break_on): Use
1164         objfile_compunits.
1165         * objfiles.h (ALL_COMPUNITS): Remove.
1166         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1167         * cp-support.c (add_symbol_overload_list_qualified): Use
1168         objfile_compunits.
1169         * ada-lang.c (ada_collect_symbol_completion_matches)
1170         (ada_add_global_exceptions): Use objfile_compunits.
1171
1172 2019-01-09  Tom Tromey  <tom@tromey.com>
1173
1174         * source.c (select_source_symtab)
1175         (forget_cached_source_info_for_objfile): Remove declaration.
1176         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1177         declaration.
1178         * maint.c (count_symtabs_and_blocks): Remove declaration.
1179         * cp-support.c (add_symbol_overload_list_qualified): Remove
1180         declaration.
1181         * coffread.c (coff_symtab_read): Remove declaration.
1182         * symtab.c (lookup_symbol_in_objfile_symtabs)
1183         (basic_lookup_transparent_type_1): Use objfile_compunits.
1184         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1185         (info_sources_command, search_symbols)
1186         (default_collect_symbol_completion_matches_break_on)
1187         (make_source_files_completion_list): Remove declaration.
1188         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1189         (ada_collect_symbol_completion_matches)
1190         (ada_add_global_exceptions): Remove declaration.
1191         * linespec.c (iterate_over_all_matching_symtabs): Use
1192         objfile_compunits.
1193         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1194         (class objfile_compunits): New.
1195         (ALL_COMPUNITS): Use objfile_compunits.
1196         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1197         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1198         objfile_compunits.
1199         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1200
1201 2019-01-09  Tom Tromey  <tom@tromey.com>
1202
1203         * symtab.c (search_symbols)
1204         (default_collect_symbol_completion_matches_break_on): Use
1205         objfile_msymbols.
1206         * ada-lang.c (ada_lookup_simple_minsym)
1207         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1208         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1209         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1210         objfile_msymbols.
1211         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1212         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1213         * objc-lang.c (find_methods): Use objfile_msymbols.
1214         (info_selectors_command, info_classes_command): Likewise.
1215         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1216         * objfiles.h (class objfile_msymbols): New.
1217         (ALL_OBJFILE_MSYMBOLS): Remove.
1218         (ALL_MSYMBOLS): Remove.
1219
1220 2019-01-09  Tom Tromey  <tom@tromey.com>
1221
1222         * common/next-iterator.h (next_adapter): Add Iterator template
1223         parameter.
1224         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1225         (class all_objfiles_safe): New.
1226         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1227         * objfiles.c (put_objfile_before): Update comment.
1228         (add_separate_debug_objfile): Likewise.
1229         (free_all_objfiles): Use all_objfiles_safe.
1230         (objfile_purge_solibs): Likewise.
1231
1232 2019-01-09  Tom Tromey  <tom@tromey.com>
1233
1234         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1235         (expand_symtab_containing_pc, lookup_static_symbol)
1236         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1237         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1238         all_objfiles.
1239         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1240         * breakpoint.c (create_overlay_event_breakpoint)
1241         (create_longjmp_master_breakpoint)
1242         (create_std_terminate_master_breakpoint)
1243         (create_exception_master_breakpoint): Use all_objfiles.
1244         * linux-thread-db.c (try_thread_db_load_from_pdir)
1245         (has_libpthread): Use all_objfiles.
1246         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1247         * linespec.c (iterate_over_all_matching_symtabs)
1248         (search_minsyms_for_name): Use all_objfiles.
1249         * maint.c (maintenance_info_sections): Use all_objfiles.
1250         * main.c (captured_main_1): Use all_objfiles.
1251         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1252         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1253         * guile/scm-pretty-print.c
1254         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1255         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1256         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1257         (maintenance_print_msymbols): Use all_objfiles.
1258         * source.c (select_source_symtab): Use all_objfiles.
1259         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1260         * symfile.c (remove_symbol_file_command)
1261         (expand_symtabs_matching, map_symbol_filenames): Use
1262         all_objfiles.
1263         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1264         all_objfiles.
1265         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1266         * objc-lang.c (find_methods): Use all_objfiles.
1267         * objfiles.c (have_partial_symbols, have_full_symbols)
1268         (have_minimal_symbols, qsort_cmp)
1269         (default_iterate_over_objfiles_in_search_order): Use
1270         all_objfiles.
1271         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1272         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1273         (maintenance_check_psymtabs): Use all_objfiles.
1274         (ALL_PSYMTABS): Remove.
1275         * compile/compile-object-run.c (do_module_cleanup): Use
1276         all_objfiles.
1277         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1278         * cp-support.c (add_symbol_overload_list_qualified): Use
1279         all_objfiles.
1280         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1281         Use all_objfiles.
1282         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1283         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1284         all_objfiles.
1285         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1286         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1287         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1288         Uses all_objfiles.
1289         * solib.c (solib_read_symbols): Use all_objfiles
1290
1291 2019-01-09  Tom Tromey  <tom@tromey.com>
1292
1293         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1294         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1295         all_objfiles.
1296         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1297         * symmisc.c (print_symbol_bcache_statistics)
1298         (print_objfile_statistics, maintenance_print_objfiles)
1299         (maintenance_info_symtabs, maintenance_check_symtabs)
1300         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1301         all_objfiles.
1302         * source.c (forget_cached_source_info): Use all_objfiles.
1303         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1304         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1305         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1306         * objfiles.c (update_section_map): Use all_objfiles.
1307         (shared_objfile_contains_address_p): Likewise.
1308         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1309         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1310
1311 2019-01-09  Tom Tromey  <tom@tromey.com>
1312
1313         * common/next-iterator.h: New file.
1314         * objfiles.h (class all_objfiles): New.
1315         (struct objfile_iterator): New.
1316
1317 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1318
1319         * NEWS: Move the description of the changed "frame", "select-frame",
1320          and "info frame" commands to the Changed commands section.
1321
1322 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1323
1324         * gdbtypes.c (check_stub_method_group): Remove handling of old
1325         mangling schemes.
1326         * linespec.c (find_methods): Likewise.
1327         * stabsread.c (read_member_functions): Likewise.
1328         * valops.c (search_struct_method): Likewise.
1329         (value_struct_elt_for_reference): Likewise.
1330         * NEWS: Mention this change.
1331
1332 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1333
1334         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1335         print_source_lines.
1336         * source.c (print_source_lines_base): Update line number check.
1337         (print_source_lines): New function.
1338         (source_lines_range::source_lines_range): New function.
1339         * source.h (class source_lines_range): New class.
1340         (print_source_lines): New declaration.
1341
1342 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1343
1344         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1345
1346 2019-01-08  Tom Tromey  <tom@tromey.com>
1347             Simon Marchi  <simon.marchi@ericsson.com>
1348
1349         PR gdb/24060
1350         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1351         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1352         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1353         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1354         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1355         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1356
1357 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1358
1359         * source.c (select_source_symtab): Move header comment to
1360         declaration in source.h.
1361         (forget_cached_source_info_for_objfile): Likewise.
1362         (forget_cached_source_info): Likewise.
1363         (identify_source_line): Likewise.
1364         * source.h (identify_source_line): Move declaration from symtab.h
1365         and add comment from source.c
1366         (print_source_lines): Likewise.
1367         (forget_cached_source_info_for_objfile): Likewise.
1368         (forget_cached_source_info): Likewise.
1369         (select_source_symtab): Likewise.
1370         (enum print_source_lines_flag): Move definition from symtab.h.
1371         * symtab.h (identify_source_line): Move declaration to source.h.
1372         (print_source_lines): Likewise.
1373         (forget_cached_source_info_for_objfile): Likewise.
1374         (forget_cached_source_info): Likewise.
1375         (select_source_symtab): Likewise.
1376         (enum print_source_lines_flag): Move definition to source.h.
1377         * tui/tui-hooks.c: Add 'source.h' include.
1378
1379 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1380
1381         * source.c (print_source_lines_base): Handle requests to print
1382         reverse line number sequences, and guard against empty lines
1383         string.
1384
1385 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * source.c (print_source_lines_base): Fix skip of '\r' if next
1388         character is '\n'.
1389
1390 2019-01-06  Tom Tromey  <tom@tromey.com>
1391
1392         * c-exp.y (struct c_parse_state) <macro_original_text,
1393         expansion_obstack>: New member.
1394         (macro_original_text, expansion_obstack): Remove globals.
1395         (scan_macro_expansion, scanning_macro_expansion)
1396         (finished_macro_expansion): Update.
1397         (scan_macro_cleanup): Remove.
1398         (yylex, c_parse): Update.
1399
1400 2019-01-06  Tom Tromey  <tom@tromey.com>
1401
1402         * c-exp.y (struct c_parse_state) <strings>: New member.
1403         (operator_stoken): Update.
1404
1405 2019-01-06  Tom Tromey  <tom@tromey.com>
1406
1407         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1408         (union type_stack_elt) <typelist_val>: Now a pointer to
1409         std::vector.
1410         (type_stack_cleanup): Don't declare.
1411         (push_typelist): Update.
1412         * parse.c (pop_typelist): Return a std::vector.
1413         (push_typelist): Take a std::vector.
1414         (follow_types): Update.  Do not free args.
1415         (type_stack_cleanup): Remove.
1416         * c-exp.y (struct c_parse_state): New.
1417         (cpstate): New global.
1418         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1419         (nonempty_typelist): Update.
1420         (func_mod): Create a new vector.
1421         (c_parse): Create a c_parse_state.
1422         (check_parameter_typelist): Do not delete params.
1423         (function_method): Update.  Do not delete type_list.
1424
1425 2019-01-06  Tom Tromey  <tom@tromey.com>
1426
1427         PR gdb/28155:
1428         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1429         check_typedef.
1430         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1431         (print_return_value): Likewise.
1432
1433 2019-01-05  Tom Tromey  <tom@tromey.com>
1434
1435         * contrib/cleanup_check.py: Remove.
1436         * contrib/gcc-with-excheck: Remove.
1437         * contrib/exsummary.py: Remove.
1438         * contrib/excheck.py: Remove.
1439
1440 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1441
1442         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1443         NULL. Initialize tpprev to NULL instead of assigning it
1444         to NULL on the next statement.
1445         * windows-nat.c (windows_delete_thread): Remove check for
1446         main_thread_id before printing thread exit notifications.
1447         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1448         Remove thread ID check against main_thread_id.
1449         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1450         windows_delete_thread.
1451         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1452
1453 2019-01-04  Tom Tromey  <tom@tromey.com>
1454
1455         * compile/compile.c (_initialize_compile): Use upper case for
1456         metasyntactic variables.
1457         * symmisc.c (_initialize_symmisc): Use upper case for
1458         metasyntactic variables.
1459         * psymtab.c (_initialize_psymtab): Use upper case for
1460         metasyntactic variables.
1461         * demangle.c (demangle_command): Use upper case for metasyntactic
1462         variables.
1463         (_initialize_demangler): Likewise.
1464         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1465         variables.
1466
1467 2019-01-03  Tom Tromey  <tom@tromey.com>
1468
1469         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1470
1471 2019-01-03  Tom Tromey  <tom@tromey.com>
1472
1473         * python/py-symtab.c (salpy_str): Update.
1474         (struct salpy_sal_object) <symtab>: Now a PyObject.
1475         (salpy_dealloc): Update.
1476         (del_objfile_sal): Use gdbpy_ref.
1477
1478 2019-01-03  Tom Tromey  <tom@tromey.com>
1479
1480         * python/py-type.c (convert_field): Use new_reference.  Return
1481         gdbpy_ref.
1482         (make_fielditem): Return gdbpy_ref.
1483         (typy_fields): Update.
1484         (typy_getitem): Update.
1485         (field_name): Return gdbpy_ref.  Use new_reference.
1486         (typy_iterator_iternext): Update.
1487
1488 2019-01-03  Tom Tromey  <tom@tromey.com>
1489
1490         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1491
1492 2019-01-03  Tom Tromey  <tom@tromey.com>
1493
1494         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1495         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1496         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1497         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1498         (pspy_set_type_printers): Likewise.
1499         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1500         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1501         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1502         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1503         (objfpy_set_type_printers): Likewise.
1504
1505 2019-01-03  Tom Tromey  <tom@tromey.com>
1506
1507         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1508         (gdbpy_print_stack): Use gdbpy_err_fetch.
1509         * python/python-internal.h (class gdbpy_err_fetch): New class.
1510         (class gdbpy_enter) <m_error_type, m_error_value,
1511         m_error_traceback>: Remove.
1512         <m_error>: New member.
1513         (gdbpy_exception_to_string): Don't declare.
1514         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1515         * python/py-value.c (convert_value_from_python): Use
1516         gdbpy_err_fetch.
1517         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1518         gdbpy_exception_to_string.
1519         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1520         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1521         gdbpy_err_fetch.
1522
1523 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1524
1525         * linux-nat.c (delete_lwp_cleanup): Delete.
1526         (struct lwp_deleter): New struct.
1527         (lwp_info_up): New typedef.
1528         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1529         lwp_info_up.
1530
1531 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1532
1533         * linux-fork.c (class scoped_switch_fork_info): New class.
1534         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1535
1536 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1537
1538         * valops.c (find_overload_match): Remove use of null_cleanup, and
1539         calls to do_cleanups.
1540
1541 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1542
1543         * compile/compile-cplus-types.c
1544         (compile_cplus_instance::decl_name): Handle changes to
1545         cp_func_name.
1546         * cp-support.c (cp_func_name): Update header comment, update
1547         return type.
1548         * cp-support.h (cp_func_name): Update return type in declaration.
1549         * valops.c (find_overload_match): Move temp_func local to top
1550         level of function and change its type.  Use temp_func to hold and
1551         delete temporary string obtained from cp_func_name.
1552
1553 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1554
1555         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1556         gdb::char_vector, remove cleanup, and update uses of `msg`.
1557
1558 2019-01-03  Jim Wilson  <jimw@sifive.com>
1559
1560         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1561
1562 2019-01-02  Tom Tromey  <tom@tromey.com>
1563
1564         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1565         (tdesc_parse_xml): Remove cleanups.
1566         * target-descriptions.h (make_cleanup_free_target_description):
1567         Don't declare.
1568         (target_desc_deleter): New struct.
1569         (target_desc_up): New typedef.
1570         * target-descriptions.c (target_desc_deleter::operator()): Rename
1571         from free_target_description.
1572         (make_cleanup_free_target_description): Remove.
1573
1574 2019-01-02  Tom Tromey  <tom@tromey.com>
1575
1576         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1577         constructor, destructor.
1578         (linespec_parser): Remove typedef.
1579         (~linespec_parser): Rename from linespec_parser_delete.
1580         (linespec_lex_to_end, linespec_complete_label)
1581         (linespec_complete): Update.
1582         (decode_line_full): Remove cleanups.
1583         (decode_line_1): Update.
1584
1585 2019-01-02  Tom Tromey  <tom@tromey.com>
1586
1587         * python/python-internal.h (inferior_to_inferior_object): Change
1588         return type.
1589         * python/py-exitedevent.c (create_exited_event_object): Update.
1590         * python/py-inferior.c (inferior_to_inferior_object): Return
1591         gdbpy_ref.
1592         (python_new_inferior, python_inferior_deleted)
1593         (thread_to_thread_object, delete_thread_object)
1594         (build_inferior_list, gdbpy_selected_inferior): Update.
1595         * python/py-infthread.c (create_thread_object): Update.  Also fail
1596         if inferior_to_inferior_object fails.
1597
1598 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1599
1600         * inferior.h (class inferior) <displaced_step_state>: New field.
1601         * infrun.h (struct displaced_step_state): Move here from
1602         infrun.c.  Initialize fields, add constructor.
1603         <inf>: Remove field.
1604         <reset>: New method.
1605         * infrun.c (struct displaced_step_inferior_state): Move to
1606         infrun.h.
1607         (displaced_step_inferior_states): Remove.
1608         (get_displaced_stepping_state): Adust.
1609         (displaced_step_in_progress_any_inferior): Adjust.
1610         (displaced_step_in_progress_thread): Adjust.
1611         (displaced_step_in_progress): Adjust.
1612         (add_displaced_stepping_state): Remove.
1613         (get_displaced_step_closure_by_addr): Adjust.
1614         (remove_displaced_stepping_state): Remove.
1615         (infrun_inferior_exit): Call displaced_step_state.reset.
1616         (use_displaced_stepping): Don't check for NULL.
1617         (displaced_step_prepare_throw): Call
1618         get_displaced_stepping_state.
1619         (displaced_step_fixup): Don't check for NULL.
1620         (prepare_for_detach): Don't check for NULL.
1621
1622 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1623
1624         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1625          in case of call that did not complete.
1626
1627 2019-01-02  Andrey Utkin  <autkin@undo.io>
1628
1629         * symfile.c (find_separate_debug_file): Fix search of debug files for
1630         remote debuggee.
1631
1632 2019-01-02  Tom Tromey  <tom@tromey.com>
1633
1634         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1635         indentation.
1636         * python/py-frame.c (frapy_older): Remove cast.
1637         (frapy_newer): Likewise.
1638         * python/py-breakpoint.c (local_setattro): Remove cast.
1639         * python/py-arch.c (archpy_name): Remove local variable.
1640         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1641
1642 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1643
1644         * unittests/basic_string_view/element_access/char/empty.cc:
1645         Fix year range in copyright header.
1646
1647 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1648
1649         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1650         Delete.
1651         <operator==>: Update with for removed field.
1652         <hash>: Likewise.
1653         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1654         <isa_features>: ...this.
1655         <abi_features>: New field.
1656         (riscv_isa_flen): Update comment.
1657         (riscv_abi_xlen): New declaration.
1658         (riscv_abi_flen): New declaration.
1659         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1660         isa_features.
1661         (riscv_abi_xlen): New function.
1662         (riscv_isa_flen): Update to get answer from isa_features.
1663         (riscv_abi_flen): New function.
1664         (riscv_has_fp_abi): Update to get answer from abi_features.
1665         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1666         xlen and flen.
1667         (riscv_call_info) <xlen, flen>: Update comment.
1668         (riscv_call_arg_struct): Remove invalid assertions
1669         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1670         is removed.
1671         (riscv_gdbarch_init): Gather isa features and abi features
1672         separately, ensure both match on the gdbarch when reusing an old
1673         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1674         a target with 64-bit float hardware.
1675
1676 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1677
1678         * source.c (search_command_helper): Stop reverse search
1679         when line 1 has been searched.
1680
1681 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1682
1683         * record-full.c (record_full_base_target::close): Rewrite
1684         record_full_core_buf_list free logic.
1685
1686 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1687
1688         * break-catch-syscall.c (print_one_catch_syscall): xfree
1689         the last text.
1690
1691 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1692
1693         * top.c (print_gdb_version): Update Copyright year in version
1694         message.
1695
1696 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1697
1698         Update copyright year range in all GDB files.
1699
1700 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1701
1702         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1703
1704 For older changes see ChangeLog-2018.
1705 \f
1706 Local Variables:
1707 mode: change-log
1708 left-margin: 8
1709 fill-column: 74
1710 version-control: never
1711 coding: utf-8
1712 End:
1713