Split rank_one_type_parm_char from rank_one_type
[external/binutils.git] / gdb / ChangeLog
1 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2
3         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4         from...
5         (rank_one_type): ... this.
6
7 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8
9         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10         from...
11         (rank_one_type): ... this.
12
13 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14
15         * gdbtypes.c (rank_one_type_parm_int): New function extracted
16         from...
17         (rank_one_type): ... this.
18
19 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
20
21         * gdbtypes.c (rank_one_type_parm_func): New function extracted
22         from...
23         (rank_one_type): ... this.
24
25 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
26
27         * gdbtypes.c (rank_one_type_parm_array): New function extracted
28         from...
29         (rank_one_type): ... this.
30
31 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
32
33         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
34         from...
35         (rank_one_type): ... this.
36
37 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
38
39         * inferior.c (initialize_inferiors): Ensure 'help set/show print
40         inferior-events' shows the example events.
41
42 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
43
44         Support styling on native MS-Windows console
45
46         PR/24315
47         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
48         on MS-Windows if $TERM is not defined.
49
50         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
51
52         * posix-hdep.c (gdb_console_fputs):
53         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
54         functions.
55         * ui-file.h (gdb_console_fputs): Add prototype.
56
57         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
58         back to fputs only if the former returns zero.
59
60 2019-03-07  Tom Tromey  <tom@tromey.com>
61
62         * symmisc.c (print_symbol_bcache_statistics): Update.
63         (print_objfile_statistics): Update.
64         * symfile.c (allocate_symtab): Update.
65         * stabsread.c: Don't include bcache.h.
66         * psymtab.h (struct psymbol_bcache): Don't declare.
67         (class psymtab_storage) <psymbol_cache>: Now a bcache.
68         (psymbol_bcache_init, psymbol_bcache_free)
69         (psymbol_bcache_get_bcache): Don't declare.
70         * psymtab.c (struct psymbol_bcache): Remove.
71         (psymtab_storage::psymtab_storage): Update.
72         (psymtab_storage::~psymtab_storage): Update.
73         (psymbol_bcache_init, psymbol_bcache_free)
74         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
75         (add_psymbol_to_bcache): Update.
76         (allocate_psymtab): Update.
77         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
78         macro_cache>: No longer pointers.
79         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
80         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
81         * macrotab.c (macro_bcache): Update.
82         * macroexp.c: Don't include bcache.h.
83         * gdbtypes.c (check_types_worklist): Update.
84         (types_deeply_equal): Remove TRY/CATCH.  Update.
85         * elfread.c (elf_symtab_read): Update.
86         * dwarf2read.c: Don't include bcache.h.
87         * buildsym.c (buildsym_compunit::get_macro_table): Update.
88         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
89         (print_bcache_statistics, bcache_memory_used): Don't declare.
90         (struct bcache): Move from bcache.c.  Add constructor, destructor,
91         methods.  Rename all data members.
92         * bcache.c (struct bcache): Move to bcache.h.
93         (bcache::expand_hash_table): Rename from expand_hash_table.
94         (bcache): Remove.
95         (bcache::insert): Rename from bcache_full.
96         (bcache::compare): Rename from bcache_compare.
97         (bcache_xmalloc): Remove.
98         (bcache::~bcache): Rename from bcache_xfree.
99         (bcache::print_statistics): Rename from print_bcache_statistics.
100         (bcache::memory_used): Rename from bcache_memory_used.
101
102 2019-03-07  Pedro Alves  <palves@redhat.com>
103
104         * infrun.c (normal_stop): Also check for
105         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
106
107 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
108
109         * f-lang.c (value_from_host_double): Moved to...
110         * value.c (value_from_host_double): ...here.
111         * value.h (value_from_host_double): Declare.
112         * guile/scm-math.c (vlscm_convert_typed_number): Use
113         value_from_host_double.
114         (vlscm_convert_number): Likewise.
115         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
116         * python/py-value.c (convert_value_from_python): Likewise.
117
118 2019-03-06  Tom Tromey  <tom@tromey.com>
119
120         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
121
122 2019-03-06  Tom Tromey  <tom@tromey.com>
123
124         * utils.h (free_current_contents): Don't declare.
125         * utils.c (free_current_contents): Remove.
126
127 2019-03-06  Tom Tromey  <tom@tromey.com>
128
129         * top.c (quit_force): Update.
130         * main.c (captured_command_loop): Update.
131         * common/new-op.c (operator new): Update.
132         * common/common-exceptions.c (struct catcher)
133         <save_cleanup_chain>: Remove member.
134         (exceptions_state_mc_init): Update.
135         (exception_try_scope_entry): Return nullptr.
136         (exception_try_scope_exit, exception_rethrow)
137         (throw_exception_sjlj, throw_exception_cxx): Update.
138         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
139         (all_cleanups, do_cleanups, discard_cleanups)
140         (discard_final_cleanups, save_cleanups, save_final_cleanups)
141         (restore_cleanups, restore_final_cleanups): Don't declare.
142         (do_final_cleanups): Remove parameter.
143         * common/cleanups.c (cleanup_chain, make_cleanup)
144         (make_cleanup_dtor, all_cleanups, do_cleanups)
145         (discard_my_cleanups, discard_cleanups)
146         (discard_final_cleanups, save_my_cleanups, save_cleanups)
147         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
148         (null_cleanup): Remove.
149         (do_final_cleanups): Remove parameter.
150
151 2019-03-06  Tom Tromey  <tom@tromey.com>
152
153         * remote.c (remote_target::remote_parse_stop_reply): Use
154         unique_xmalloc_ptr.
155
156 2019-03-06  Tom Tromey  <tom@tromey.com>
157
158         * stabsread.c (struct stabs_field_info): Rename from field_info.
159         <list, fnlist>: Add initializers.
160         <obstack>: New member.
161         (read_member_functions, read_struct_fields, read_baseclasses):
162         Allocate on obstack.  Don't use cleanups.
163         (read_one_struct_field, read_member_functions, read_struct_fields)
164         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
165         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
166         (read_struct_type): Update.
167
168 2019-03-06  Tom Tromey  <tom@tromey.com>
169
170         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
171         * common/filestuff.h (make_cleanup_close): Don't declare.
172         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
173         Remove.
174
175 2019-03-06  Tom Tromey  <tom@tromey.com>
176
177         * solib-aix.c: Use make_scope_exit.
178
179 2019-03-06  Tom Tromey  <tom@tromey.com>
180
181         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
182         Use make_scope_exit.
183
184 2019-03-06  Tom Tromey  <tom@tromey.com>
185
186         * solib-svr4.c (disable_probes_interface): Remove parameter.
187         (svr4_handle_solib_event): Use make_scope_exit.
188
189 2019-03-06  Tom Tromey  <tom@tromey.com>
190
191         * remote.c (struct stop_reply_deleter): Remove.
192         (stop_reply_up): Update.
193         (struct stop_reply): Derive from notif_event.  Don't typedef.
194         <regcache>: Now a std::vector.
195         (stop_reply_xfree): Remove.
196         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
197         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
198         (remote_target::discard_pending_stop_replies): Use delete.
199         (remote_target::remote_parse_stop_reply): Update.
200         (remote_target::process_stop_reply): Update.
201         * remote-notif.h (struct notif_event): Add virtual destructor.
202         Remove "dtr" member.
203         (struct notif_client) <alloc_event>: Return a unique_ptr.
204         (notif_event_xfree): Don't declare.
205         (notif_event_up): New typedef.
206         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
207         (notif_event_xfree, do_notif_event_xfree): Remove.
208         (remote_notif_state_xfree): Update.
209
210 2019-03-06  Tom Tromey  <tom@tromey.com>
211
212         * infrun.c (displaced_step_clear_cleanup): Now a
213         forward_scope_exit type.
214         (displaced_step_prepare_throw): Update.
215         (displaced_step_fixup): Update.
216
217 2019-03-06  Tom Tromey  <tom@tromey.com>
218
219         * inferior.h (class inferior): Update comment.
220         * gdbthread.h (class thread_info): Update comment.
221
222 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
223             Tom Tromey  <tom@tromey.com>
224
225         * stabsread.h (struct stab_section_list): Remove.
226         (coffstab_build_psymtabs): Update.
227         * dbxread.c (symbuf_sections): Now a std::vector.
228         (sect_idx): New global.
229         (fill_symbuf): Update.
230         (coffstab_build_psymtabs): Change type of stabsects parameter.
231         Update.
232         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
233         std::vector.
234         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
235         (coff_locate_sections): Update.
236         (coff_symfile_read): Remove cleanups.  Update.
237         (init_stringtab): Add storage parameter.
238         (free_stringtab, free_stringtab_cleanup): Remove.
239         (init_lineno): Add storage parameter.
240         (free_linetab, free_linetab_cleanup): Remove.
241
242 2019-03-06  Pedro Alves  <palves@redhat.com>
243
244         * linux-fork.c (fork_info::clobber_regs): Delete.
245         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
246         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
247         comment.  Adjust.
248         (scoped_switch_fork_info::scoped_switch_fork_info)
249         (checkpoint_command, linux_fork_context): Adjust
250         fork_save_infrun_state calls.
251
252 2019-03-06  Pedro Alves  <palves@redhat.com>
253
254         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
255         (inf_has_multiple_threads): Return 'bool' and rewrite using
256         inferior_info::threads().
257
258 2019-03-06  Pedro Alves  <palves@redhat.com>
259
260         * linux-fork.c: Include <list>.
261         (fork_list): Now a std::list instance.
262         (fork_info): Add ctor, dtor, and in-class initialize all fields.
263         (forks_exist_p, find_last_fork): Adjust.
264         (new_fork): Delete.
265         (one_fork_p): New.
266         (add_fork): Adjust.
267         (free_fork): Delete, folded into fork_info::~fork_info().
268         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
269         Adjust.
270         (init_fork_list): Delete.
271         (linux_fork_killall, linux_fork_mourn_inferior)
272         (linux_fork_detach, info_checkpoints_command): Adjust.
273         (_initialize_linux_fork): No longer call init_fork_list.
274
275 2019-03-06  Pedro Alves  <palves@redhat.com>
276
277         * linux-fork.c (new_fork): New, split out of ...
278         (add_fork): ... this.  Return void.  Move "first fork" special
279         case from here, to ...
280         (checkpoint_command): ... here.
281         * linux-linux.h (add_fork): Return void.
282
283 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
284
285         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
286
287 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
288             Chris January  <chris.january@arm.com>
289             David Lecomber  <david.lecomber@arm.com>
290
291         * f-exp.y: New token, UNOP_INTRINSIC.
292         (exp): New pattern using UNOP_INTRINSIC token.
293         (f77_keywords): Add 'abs' keyword.
294         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
295         (value_from_host_double): New function.
296         (evaluate_subexp_f): Support UNOP_ABS.
297
298 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
299
300         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
301         types.
302
303 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
304
305         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
306         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
307         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
308
309 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
310
311         * f-exp.y (convert_to_kind_type): Handle more type kinds.
312
313 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
314             Chris January  <chris.january@arm.com>
315
316         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
317         * f-exp.y: Define 'KIND' token.
318         (exp): New pattern for KIND expressions.
319         (ptype): Handle types with a kind extension.
320         (direct_abs_decl): Extend to spot kind extensions.
321         (f77_keywords): Add 'kind' to the list.
322         (push_kind_type): New function.
323         (convert_to_kind_type): New function.
324         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
325         * parse.c (operator_length_standard): Likewise.
326         * parser-defs.h (enum type_pieces): Add tp_kind.
327         * std-operator.def: Add UNOP_KIND.
328
329 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
330
331         * f-exp.y (f_parse): Set yydebug.
332
333 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
334
335         * f-lang.c (evaluate_subexp_f): New function.
336         (exp_descriptor_f): New global.
337         (f_language_defn): Use exp_descriptor_f instead of
338         exp_descriptor_standard.
339
340 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
341
342         * f-exp.y (struct token): Add comments.
343         (dot_ops): Remove uppercase versions and the end marker.
344         (f77_keywords): Likewise.
345         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
346         entries in the dot_ops array are case insensitive, and use
347         strncasecmp to compare strings.  Also some whitespace cleanup in
348         this area.  Similar for the f77_keywords array, except entries in
349         this list might be case sensitive.
350
351 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
352
353         * f-exp.y (struct f77_boolean_val): Add comments.
354         (boolean_values): Remove uppercase versions, and end marker.
355         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
356         and use strncasecmp to achieve case insensitivity.  Additionally,
357         perform whitespace cleanup around this code.
358
359 2019-03-06  Tom Tromey  <tromey@adacore.com>
360
361         * remote-sim.c (gdbsim_target_open): Use result of
362         gdb_argv::release.
363
364 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
365         Dirk Schubert  <dirk.schubert@arm.com>
366         Chris January  <chris.january@arm.com>
367
368         * eval.c (evaluate_subexp_standard): Call Fortran argument
369         wrapping logic.
370         * f-lang.c (struct value): A value which can be passed into a
371         Fortran function call.
372         (fortran_argument_convert): Wrap Fortran arguments in a pointer
373         where appropriate.
374         (struct type): Value ready for a Fortran function call.
375         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
376         is needed.
377         * f-lang.h (fortran_argument_convert): Declaration.
378         (fortran_preserve_arg_pointer): Declaration.
379         * infcall.c (value_arg_coerce): Call Fortran argument logic.
380
381 2019-03-05  Tom Tromey  <tromey@adacore.com>
382
383         * python/py-prettyprint.c (print_string_repr): Remove #if.
384         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
385
386 2019-03-05  Tom Tromey  <tromey@adacore.com>
387
388         * target.c (the_dummy_target): Move later.  Change type to
389         "dummy_target".
390         (initialize_targets): Don't initialize the_dummy_target.
391
392 2019-03-05  Tom Tromey  <tromey@adacore.com>
393
394         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
395         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
396
397 2019-03-05  Tom Tromey  <tromey@adacore.com>
398
399         * windows-nat.c (windows_nat_target::attach)
400         (windows_nat_target::detach): Don't call gdb_flush.
401         * valprint.c (generic_val_print, val_print, val_print_string):
402         Don't call gdb_flush.
403         * utils.c (defaulted_query): Don't call gdb_flush.
404         * typeprint.c (print_type_scalar): Don't call gdb_flush.
405         * target.c (target_announce_detach): Don't call gdb_flush.
406         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
407         * remote.c (extended_remote_target::attach): Don't call
408         gdb_flush.
409         * procfs.c (procfs_target::detach): Don't call gdb_flush.
410         * printcmd.c (do_examine): Don't call gdb_flush.
411         (info_display_command): Don't call gdb_flush.
412         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
413         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
414         * memattr.c (info_mem_command): Don't call gdb_flush.
415         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
416         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
417         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
418         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
419         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
420         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
421         (gnu_nat_target::detach): Don't call gdb_flush.
422         * f-valprint.c (f_val_print): Don't call gdb_flush.
423         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
424         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
425         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
426         gdb_flush.
427         * c-valprint.c (c_val_print): Don't call gdb_flush.
428         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
429
430 2019-03-05  Tom Tromey  <tromey@adacore.com>
431
432         * varobj.c (update_dynamic_varobj_children): Update.
433         (install_default_visualizer): Use reset, not release.
434         * value.c (set_internalvar): Update.
435         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
436         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
437         ATTRIBUTE_UNUSED_RESULT.
438
439 2019-03-05  Tom Tromey  <tromey@adacore.com>
440
441         * remote.c (class scoped_remote_fd) <release>: Add
442         ATTRIBUTE_UNUSED_RESULT.
443
444 2019-03-05  Tom Tromey  <tromey@adacore.com>
445
446         * macroexp.c (struct macro_buffer) <release>: Add
447         ATTRIBUTE_UNUSED_RESULT.
448
449 2019-03-05  Tom Tromey  <tromey@adacore.com>
450
451         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
452         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
453         ATTRIBUTE_UNUSED_RESULT.
454
455 2019-03-05  Tom Tromey  <tromey@adacore.com>
456
457         * common/scoped_fd.h (class scoped_fd) <release>: Add
458         ATTRIBUTE_UNUSED_RESULT.
459
460 2019-03-05  Tom Tromey  <tromey@adacore.com>
461
462         * parser-defs.h (struct parser_state) <release>: Add
463         ATTRIBUTE_UNUSED_RESULT.
464
465 2019-03-05  Tom Tromey  <tromey@adacore.com>
466
467         * utils.h (class gdb_argv) <release>: Add
468         ATTRIBUTE_UNUSED_RESULT.
469         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
470
471 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
472
473         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
474         for-loop range, to avoid compiler warnings.
475
476         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
477         avoid compiler warnings about unused variables.
478
479         * NEWS: Mention end of support for native debugging on MS-Windows
480         before XP.
481
482         PR gdb/24292
483         * common/netstuff.c:
484         * gdbserver/gdbreplay.c
485         * gdbserver/remote-utils.c:
486         * ser-tcp.c:
487         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
488         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
489         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
490         'getaddrinfo' and 'freeaddrinfo' were not available before
491         Windows XP, and mingw.org's MinGW headers by default define
492         _WIN32_WINNT to 0x500.
493
494 2019-03-01  Gary Benson <gbenson@redhat.com>
495
496         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
497
498 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
499             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
500
501         PR gdb/8527
502         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
503         set_sigint_trap, clear_sigint_trap.
504
505 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
506
507         * target.c (target_detach): Clear the regcache and the
508         frame cache.
509
510 2019-02-27  Pedro Alves  <palves@redhat.com>
511
512         * utils.c (set_screen_size): When we cap the height/width sizes,
513         tweak the corresponding command variable to show "unlimited":
514
515 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
516             Pedro Alves  <palves@redhat.com>
517
518         * utils.c (set_screen_size): Reduce "infinite" rows and columns
519         before calling rl_set_screen_size.
520
521 2019-02-27  Tom Tromey  <tromey@adacore.com>
522
523         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
524         define.
525         * python/py-value.c: Remove Python 2.4 workaround.
526         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
527         workaround.
528         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
529         Python 2.4 workaround.
530         * python/python-internal.h: Remove Python 2.4 comment.
531         (Py_ssize_t): Don't define.
532         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
533         (gdb_Py_DECREF): Remove Python 2.4 workaround.
534         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
535         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
536         * python/python.c (do_start_initialization): Remove Python 2.4
537         workaround.
538         * python/py-prettyprint.c (class dummy_python_frame): Remove.
539         (print_children): Remove Python 2.4 workaround.
540         * python/py-inferior.c (buffer_procs): Remove Python 2.4
541         workaround.
542         (CHARBUFFERPROC_NAME): Remove.
543         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
544         Python 2.4 workaround.
545
546 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
547
548         * NEWS: Note minimum Python version.
549
550 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
551
552         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
553         code from these functions.  Remove corresponding ifdefs.  Use
554         Py_buffer_up instead of explicit calls to PyBuffer_Release.
555         Remove gotos and target of gotos.
556         (infpy_search_memory): Likewise.
557
558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
559
560         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
561         (hppa_gdbarch_init): Don't register deleted functions with
562         gdbarch.
563
564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
565
566         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
567         (h8300_unwind_sp): Delete.
568         (h8300_dummy_id): Delete.
569         (h8300_gdbarch_init): Don't register deleted functions with
570         gdbarch.
571
572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
573
574         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
575         (ft32_unwind_pc): Delete.
576         (ft32_unwind_sp): Delete.
577         (ft32_gdbarch_init): Don't register deleted functions with
578         gdbarch.
579
580 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
581
582         * gdb/frv-tdep.c (frv_dummy_id): Delete.
583         (frv_unwind_pc): Delete.
584         (frv_unwind_sp): Delete.
585         (frv_gdbarch_init): Don't register deleted functions with
586         gdbarch.
587
588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
589
590         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
591         (riscv_unwind_pc): Delete.
592         (riscv_unwind_sp): Delete.
593         (riscv_gdbarch_init): Don't register deleted functions with
594         gdbarch.
595
596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
597
598         * gdb/csky-tdep.c (csky_dummy_id): Delete.
599         (csky_unwind_pc): Delete.
600         (csky_unwind_sp): Delete.
601         (csky_gdbarch_init): Don't register deleted functions with
602         gdbarch.
603
604 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
605
606         * gdb/cris-tdep.c (cris_dummy_id): Delete.
607         (cris_unwind_pc): Delete.
608         (cris_unwind_sp): Delete.
609         (cris_gdbarch_init): Don't register deleted functions with
610         gdbarch.
611
612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
613
614         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
615         (bfin_unwind_pc): Delete.
616         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
617
618 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
619
620         * gdb/arm-tdep.c (arm_dummy_id): Delete.
621         (arm_unwind_pc): Delete.
622         (arm_unwind_sp): Delete.
623         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
624
625 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
626
627         * gdb/arc-tdep.c (arc_dummy_id): Delete.
628         (arc_unwind_pc): Delete.
629         (arc_unwind_sp): Delete.
630         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
631
632 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
633
634         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
635         (alpha_unwind_pc): Delete.
636         (alpha_gdbarch_init): Don't register deleted functions with
637         gdbarch.
638
639 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
640
641         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
642         (aarch64_unwind_pc): Delete.
643         (aarch64_unwind_sp): Delete.
644         (aarch64_gdbarch_init): Don't register deleted functions with
645         gdbarch.
646
647 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
648
649         * gdbtypes.c (type_align): Don't consider static members when
650         computing structure alignment.
651
652 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
653
654         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
655         return 0 for other types.
656         * arch-utils.c (default_type_align): Always return 0.
657         * gdbarch.h: Regenerate.
658         * gdbarch.sh (type_align): Extend comment.
659         * gdbtypes.c (type_align): Add additional comments, always call
660         gdbarch_type_align before applying the default rules.
661         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
662         generic code will then apply a suitable default.
663         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
664         types, return 0 for other types.
665
666 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
667
668         * NEWS: Create a new section for the next release branch.
669         Rename the section of the current branch, now that it has
670         been cut.
671
672 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
673
674         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
675         * version.in: Bump version to 8.3.50.DATE-git.
676
677 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
678
679         * aix-thread.c (ptid_cmp): Remove unused variable.
680         (get_signaled_thread): Likewise.
681         (store_regs_user_thread): Likewise.
682         (store_regs_kernel_thread): Likewise.
683         (fetch_regs_kernel_thread): Remove shadowed variable.
684
685 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
686
687         * features/riscv/32bit-cpu.xml: Add register numbers.
688         * features/riscv/32bit-fpu.c: Regenerate.
689         * features/riscv/32bit-fpu.xml: Add register numbers.
690         * features/riscv/64bit-cpu.xml: Add register numbers.
691         * features/riscv/64bit-fpu.c: Regenerate.
692         * features/riscv/64bit-fpu.xml: Add register numbers.
693
694 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
695
696         * NEWS: Mention two argument form of gdb.Value constructor.
697         * python/py-value.c (convert_buffer_and_type_to_value): New
698         function.
699         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
700         Add support for handling an optional second argument.  Call
701         convert_buffer_and_type_to_value as appropriate.
702         * python/python-internal.h (Py_buffer_deleter): New struct.
703         (Py_buffer_up): New typedef.
704
705 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
706
707         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
708         instead of releasing ownership.
709
710 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
711
712         * dwarf2read.c (open_and_init_dwp_file): Call
713         elf_numsections instead of bfd_count_sections to initialize
714         dwp_file->num_sections.
715
716 2019-02-25  Tom Tromey  <tromey@adacore.com>
717
718         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
719
720 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
721
722         * gcore.in: Add '--readnever' option when invoking GDB.
723
724 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
725
726         * MAINTAINERS: Update my email address.
727
728 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
729
730         * build-id.c (build_id_to_debug_bfd_1): New function.
731         (build_id_to_debug_bfd): Look for separate debug file in
732         sysroot.
733
734 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
735
736         * gdbarch.sh: Update the copyright year range that is placed into
737         generated files.
738
739 2019-02-22  Keith Seitz  <keiths@redhat.com>
740
741         PR symtab/23853
742         * linespec.c (create_sals_line_offset): Search for the default
743         symtab's filename instead of its fullname.
744
745 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
746
747         * NEWS: Update style defaults.
748
749 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
750
751         * main.c (captured_main_1): Disable styling in batch mode.
752
753 2019-02-20  Tom Tromey  <tom@tromey.com>
754
755         * symtab.c (symtab_symbol_info): Fix typos.
756
757 2019-02-20  Tom Tromey  <tromey@adacore.com>
758
759         * findcmd.c (_initialize_mem_search): Use upper case for
760         metasyntactic variables.
761
762 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
763
764         * aarch64-tdep.c (aarch64_add_reggroups): New function.
765         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
766
767 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
768
769         * top.h (source_file_name): Change to std::string.
770         * top.c (source_file_name): Likewise.
771         (command_line_input): Adjust.
772         * cli/cli-script.c (script_from_file): Adjust.
773
774 2019-02-19  Tom Tromey  <tromey@adacore.com>
775
776         * ravenscar-thread.c
777         (ravenscar_thread_target::update_thread_list): Don't call
778         ada_build_task_list.
779         * ada-lang.h (ada_build_task_list): Don't declare.
780         * ada-tasks.c (struct ada_tasks_inferior_data)
781         <task_list_valid_p>: Now bool.
782         (read_known_tasks, ada_task_list_changed)
783         (ada_tasks_invalidate_inferior_data): Update.
784         (read_known_tasks_array): Return bool.
785         (read_known_tasks_list): Likewise.
786         (read_known_tasks): Return void.
787         (ada_build_task_list): Now static.
788
789 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
790
791         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
792         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
793
794 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
795
796         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
797         variant for ada_tasks_pspace_data_handle and
798         ada_tasks_inferior_data_handle.
799         (ada_tasks_pspace_data_cleanup): New function.
800         (ada_tasks_inferior_data_cleanup): New function.
801
802 2019-02-17  Tom Tromey  <tom@tromey.com>
803
804         * macrotab.h (macro_source_fullname): Return a std::string.
805         * macrotab.c (macro_include, check_for_redefinition)
806         (macro_undef, macro_lookup_definition, foreach_macro)
807         (foreach_macro_in_scope): Update.
808         (macro_source_fullname): Return a std::string.
809         * macrocmd.c (show_pp_source_pos): Update.
810
811 2019-02-17  Tom Tromey  <tom@tromey.com>
812
813         * macrocmd.c (show_pp_source_pos): Style the file names.
814
815 2019-02-17  Tom Tromey  <tom@tromey.com>
816
817         PR tui/24197:
818         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
819
820 2019-02-17  Tom Tromey  <tom@tromey.com>
821
822         * ada-lang.c (user_select_syms): Use filtered printing.
823         * utils.c (wrap_style): New global.
824         (desired_style): Remove.
825         (emit_style_escape): Add stream parameter.
826         (set_output_style, reset_terminal_style, prompt_for_continue):
827         Update.
828         (flush_wrap_buffer): Only flush gdb_stdout.
829         (wrap_here): Set wrap_style.
830         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
831         treat escape sequences as a character.  Change when wrap buffer is
832         flushed.
833         (fputs_styled): Do not set the output style when the default is
834         requested.
835         * ui-style.h (struct ui_file_style) <is_default>: New method.
836         * source.c (print_source_lines_base): Emit escape sequences in one
837         piece.
838
839 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
840
841         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
842         integers and enumeration types.
843
844 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
845
846         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
847         instead of lookup_symbol_in_language
848         (do_exact_match): New function.
849         (ada_get_symbol_name_matcher): Return do_exact_match when
850         doing a verbatim match.
851
852 2019-02-15  Tom Tromey  <tromey@adacore.com>
853
854         * ravenscar-thread.c (ravenscar_thread_target::resume)
855         (ravenscar_thread_target::wait): Special case wildcard requests.
856
857 2019-02-15  Tom Tromey  <tromey@adacore.com>
858
859         * ravenscar-thread.c (base_ptid): Remove.
860         (struct ravenscar_thread_target) <close>: New method.
861         <m_base_ptid>: New member.
862         <update_inferior_ptid, active_task, task_is_currently_active,
863         runtime_initialized>: Declare methods.
864         <ravenscar_thread_target>: Add constructor.
865         (ravenscar_thread_target::task_is_currently_active)
866         (ravenscar_thread_target::update_inferior_ptid)
867         (ravenscar_runtime_initialized): Rename.  Now methods.
868         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
869         (ravenscar_thread_target::update_thread_list): Update.
870         (ravenscar_thread_target::active_task): Now method.
871         (ravenscar_thread_target::store_registers)
872         (ravenscar_thread_target::prepare_to_store)
873         (ravenscar_thread_target::prepare_to_store)
874         (ravenscar_thread_target::mourn_inferior): Update.
875         (ravenscar_inferior_created): Use "new" to create target.
876         (ravenscar_thread_target::get_ada_task_ptid): Update.
877         (_initialize_ravenscar): Don't initialize base_ptid.
878         (ravenscar_ops): Remove global.
879
880 2019-02-15  Tom Tromey  <tromey@adacore.com>
881
882         * target.h (push_target): Declare new overload.
883         * target.c (push_target): New overload, taking an rvalue reference.
884         * remote.c (remote_target::open_1): Use push_target overload.
885         * corelow.c (core_target_open): Use push_target overload.
886
887 2019-02-15  Tom Tromey  <tromey@adacore.com>
888
889         * ravenscar-thread.c (is_ravenscar_task)
890         (ravenscar_task_is_currently_active): Return bool.
891         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
892         (_initialize_ravenscar): Remove "(void)".
893         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
894         Return bool.
895
896 2019-02-15  Tom Tromey  <tromey@adacore.com>
897
898         * ravenscar-thread.c (ravenscar_runtime_initializer)
899         (has_ravenscar_runtime, get_running_thread_id)
900         (ravenscar_thread_target::resume): Fix indentation.
901
902 2019-02-15  Tom Tromey  <tromey@adacore.com>
903
904         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
905         from ravenscar_arch_ops.
906         (sparc_ravenscar_ops::fetch_registers)
907         (sparc_ravenscar_ops::store_registers): Now methods.
908         (sparc_ravenscar_prepare_to_store): Remove.
909         (sparc_ravenscar_ops): Redefine.
910         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
911         methods and destructor.  Remove members.
912         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
913         (ravenscar_thread_target::store_registers)
914         (ravenscar_thread_target::prepare_to_store): Update.
915         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
916         Remove.
917         (struct ppc_ravenscar_powerpc_ops): Derive from
918         ravenscar_arch_ops.
919         (ppc_ravenscar_powerpc_ops::fetch_registers)
920         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
921         (ppc_ravenscar_powerpc_ops): Redefine.
922         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
923         (ppc_ravenscar_e500_ops::fetch_registers)
924         (ppc_ravenscar_e500_ops::store_registers): Now methods.
925         (ppc_ravenscar_e500_ops): Redefine.
926         * aarch64-ravenscar-thread.c
927         (aarch64_ravenscar_generic_prepare_to_store): Remove.
928         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
929         (aarch64_ravenscar_fetch_registers)
930         (aarch64_ravenscar_store_registers): Now methods.
931         (aarch64_ravenscar_ops): Redefine.
932
933 2019-02-15  Tom Tromey  <tromey@adacore.com>
934
935         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
936         (ravenscar_thread_target::stopped_by_hw_breakpoint)
937         (ravenscar_thread_target::stopped_by_watchpoint)
938         (ravenscar_thread_target::stopped_data_address)
939         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
940
941 2019-02-15  Tom Tromey  <tromey@adacore.com>
942
943         * ravenscar-thread.c: Fix some typos.
944
945 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
946             Tom Tromey  <tromey@adacore.com>
947
948         * ada-lang.c (ada_exception_sal): Change addr_string to a
949         std::string.
950         (create_ada_exception_catchpoint): Update.
951
952 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
953             Tom Tromey  <tromey@adacore.com>
954
955         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
956         (bp_location_ops): Remove.
957         (base_breakpoint_allocate_location): Update.
958         (free_bp_location): Update.
959         * ada-lang.c (class ada_catchpoint_location)
960         <ada_catchpoint_location>: Remove ops parameter.
961         (ada_catchpoint_location_dtor): Remove.
962         (ada_catchpoint_location_ops): Remove.
963         (allocate_location_exception): Update.
964         * breakpoint.h (struct bp_location_ops): Remove.
965         (class bp_location) <bp_location>: Remove bp_location_ops
966         parameter.
967         <~bp_location>: Add destructor.
968         <ops>: Remove.
969
970 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
971             Pedro Alves  <palves@redhat.com>
972
973         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
974         'PATH_MAX'.
975
976 2019-02-14  David Michael  <fedora.dm0@gmail.com>
977             Samuel Thibault  <samuel.thibault@gnu.org>
978             Thomas Schwinge  <thomas@codesourcery.com>
979
980         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
981         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
982
983 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
984
985         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
986         (check_empty): Use "const char *".
987
988         * gnu-nat.c (gnu_nat_target::detach): Instead of
989         'detach_inferior (pid)' call
990         'detach_inferior (find_inferior_pid (pid))'.
991
992         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
993         'nat/fork-inferior.o'.
994         * gnu-nat.c: #include "nat/fork-inferior.h".
995
996         * gnu-nat.c (gnu_nat_target::detach): Instead of
997         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
998         * gnu-nat.h: #include "inf-child.h".
999         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1000         'i386_gnu_nat_target::fetch_registers'.
1001         (gnu_store_registers): Rename/move to
1002         'i386_gnu_nat_target::store_registers'.
1003
1004         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1005         * gnu-nat.h (mach_thread_info): New function.
1006         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1007
1008         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1009
1010 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1011
1012         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1013
1014 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1015
1016         * windows-nat.c (windows_add_thread): Add new parameter
1017         "main_thread_p" with default value set to false.  Update
1018         function documentation as well as all callers.
1019         (windows_delete_thread): Likewise.
1020         (fake_create_process): Update call to windows_add_thread.
1021         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1022         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1023         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1024         call to windows_delete_thread.
1025
1026 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1027
1028         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1029
1030 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1031
1032         * symfile.c (find_separate_debug_file): Use canonical path of
1033         sysroot with child_path instead of gdb_sysroot if it is valid.
1034
1035 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1036
1037         * symfile.c (find_separate_debug_file): Use child_path to
1038         determine if an object file is under a sysroot.
1039
1040 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1041
1042         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1043         unittests/child-path-selftests.c.
1044         * common/pathstuff.c (child_path): New function.
1045         * common/pathstuff.h (child_path): New prototype.
1046         * unittests/child-path-selftests.c: New file.
1047
1048 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1049
1050         * symfile.c (find_separate_debug_file): Look for separate debug
1051         files in debug directories under the sysroot.
1052
1053 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1054
1055         * symtab.h (struct minimal_symbol data_p): New const method.
1056         (struct minimal_symbol text_p): Likewise.
1057         * symtab.c (output_source_filename): Use file name style
1058         to print file name.
1059         (print_symbol_info): Likewise.
1060         (print_msymbol_info): Use address style to print addresses.
1061         Use function name style to print executable text symbols.
1062         (expand_symtab_containing_pc): Use data_p.
1063         (find_pc_sect_compunit_symtab): Likewise.
1064
1065 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1066
1067         * breakpoint.c (describe_other_breakpoints): Use address style
1068         to print addresses.
1069         (say_where): Likewise.
1070
1071 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1072
1073         * ada-typeprint.c (print_func_type): Print function name
1074         style to print function name.
1075         * c-typeprint.c (c_print_type_1): Likewise.
1076
1077 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1078
1079         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1080         for execve.
1081
1082 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1083
1084         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1085         type_stack.
1086
1087 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1088
1089         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1090         TYPE_CODE_REF types.
1091
1092 2019-02-08  Jim Wilson  <jimw@sifive.com>
1093
1094         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1095         (riscv_linux_fregset): New.
1096         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1097
1098 2019-02-07  Tom Tromey  <tom@tromey.com>
1099
1100         * thread.c (thread_cancel_execution_command): Update.
1101         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1102         methods.
1103         (struct thread_fsm_ops): Remove.
1104         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1105         (thread_fsm_should_stop, thread_fsm_return_value)
1106         (thread_fsm_set_finished, thread_fsm_finished_p)
1107         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1108         Don't declare.
1109         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1110         * infrun.c (clear_proceed_status_thread)
1111         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1112         (print_stop_event): Update.
1113         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1114         Add constructor.
1115         (step_command_fsm_ops): Remove.
1116         (new_step_command_fsm): Remove.
1117         (step_1): Update.
1118         (step_command_fsm::should_stop): Rename from
1119         step_command_fsm_should_stop.
1120         (step_command_fsm::clean_up): Rename from
1121         step_command_fsm_clean_up.
1122         (step_command_fsm::do_async_reply_reason): Rename from
1123         step_command_fsm_async_reply_reason.
1124         (struct until_next_fsm): Inherit from thread_fsm.  Add
1125         constructor.
1126         (until_next_fsm_ops): Remove.
1127         (new_until_next_fsm): Remove.
1128         (until_next_fsm::should_stop): Rename from
1129         until_next_fsm_should_stop.
1130         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1131         (until_next_fsm::do_async_reply_reason): Rename from
1132         until_next_fsm_async_reply_reason.
1133         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1134         constructor.  Change type of breakpoint.
1135         (finish_command_fsm_ops): Remove.
1136         (new_finish_command_fsm): Remove.
1137         (finish_command_fsm::should_stop): Rename from
1138         finish_command_fsm_should_stop.
1139         (finish_command_fsm::clean_up): Rename from
1140         finish_command_fsm_clean_up.
1141         (finish_command_fsm::return_value): Rename from
1142         finish_command_fsm_return_value.
1143         (finish_command_fsm::do_async_reply_reason): Rename from
1144         finish_command_fsm_async_reply_reason.
1145         (finish_command): Update.
1146         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1147         Add constructor.
1148         (call_thread_fsm_ops): Remove.
1149         (call_thread_fsm::call_thread_fsm): Rename from
1150         new_call_thread_fsm.
1151         (call_thread_fsm::should_stop): Rename from
1152         call_thread_fsm_should_stop.
1153         (call_thread_fsm::should_notify_stop): Rename from
1154         call_thread_fsm_should_notify_stop.
1155         (run_inferior_call, call_function_by_hand_dummy): Update.
1156         * cli/cli-interp.c (should_print_stop_to_console): Update.
1157         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1158         Add constructor.  Change type of location_breakpoint,
1159         caller_breakpoint.
1160         (until_break_fsm_ops): Remove.
1161         (new_until_break_fsm): Remove.
1162         (until_break_fsm::should_stop): Rename from
1163         until_break_fsm_should_stop.
1164         (until_break_fsm::clean_up): Rename from
1165         until_break_fsm_clean_up.
1166         (until_break_fsm::do_async_reply_reason): Rename from
1167         until_break_fsm_async_reply_reason.
1168         (until_break_command): Update.
1169         * thread-fsm.c: Remove.
1170         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1171
1172 2019-02-07  Tom Tromey  <tom@tromey.com>
1173
1174         * yy-remap.h: Add include guard.
1175         * xtensa-tdep.h: Add include guard.
1176         * xcoffread.h: Rename include guard.
1177         * varobj-iter.h: Add include guard.
1178         * tui/tui.h: Rename include guard.
1179         * tui/tui-winsource.h: Rename include guard.
1180         * tui/tui-wingeneral.h: Rename include guard.
1181         * tui/tui-windata.h: Rename include guard.
1182         * tui/tui-win.h: Rename include guard.
1183         * tui/tui-stack.h: Rename include guard.
1184         * tui/tui-source.h: Rename include guard.
1185         * tui/tui-regs.h: Rename include guard.
1186         * tui/tui-out.h: Rename include guard.
1187         * tui/tui-layout.h: Rename include guard.
1188         * tui/tui-io.h: Rename include guard.
1189         * tui/tui-hooks.h: Rename include guard.
1190         * tui/tui-file.h: Rename include guard.
1191         * tui/tui-disasm.h: Rename include guard.
1192         * tui/tui-data.h: Rename include guard.
1193         * tui/tui-command.h: Rename include guard.
1194         * tic6x-tdep.h: Add include guard.
1195         * target/waitstatus.h: Rename include guard.
1196         * target/wait.h: Rename include guard.
1197         * target/target.h: Rename include guard.
1198         * target/resume.h: Rename include guard.
1199         * target-float.h: Rename include guard.
1200         * stabsread.h: Add include guard.
1201         * rs6000-tdep.h: Add include guard.
1202         * riscv-fbsd-tdep.h: Add include guard.
1203         * regformats/regdef.h: Rename include guard.
1204         * record.h: Rename include guard.
1205         * python/python.h: Rename include guard.
1206         * python/python-internal.h: Rename include guard.
1207         * python/py-stopevent.h: Rename include guard.
1208         * python/py-ref.h: Rename include guard.
1209         * python/py-record.h: Rename include guard.
1210         * python/py-record-full.h: Rename include guard.
1211         * python/py-record-btrace.h: Rename include guard.
1212         * python/py-instruction.h: Rename include guard.
1213         * python/py-events.h: Rename include guard.
1214         * python/py-event.h: Rename include guard.
1215         * procfs.h: Add include guard.
1216         * proc-utils.h: Add include guard.
1217         * p-lang.h: Add include guard.
1218         * or1k-tdep.h: Rename include guard.
1219         * observable.h: Rename include guard.
1220         * nto-tdep.h: Rename include guard.
1221         * nat/x86-linux.h: Rename include guard.
1222         * nat/x86-linux-dregs.h: Rename include guard.
1223         * nat/x86-gcc-cpuid.h: Add include guard.
1224         * nat/x86-dregs.h: Rename include guard.
1225         * nat/x86-cpuid.h: Rename include guard.
1226         * nat/ppc-linux.h: Rename include guard.
1227         * nat/mips-linux-watch.h: Rename include guard.
1228         * nat/linux-waitpid.h: Rename include guard.
1229         * nat/linux-ptrace.h: Rename include guard.
1230         * nat/linux-procfs.h: Rename include guard.
1231         * nat/linux-osdata.h: Rename include guard.
1232         * nat/linux-nat.h: Rename include guard.
1233         * nat/linux-namespaces.h: Rename include guard.
1234         * nat/linux-btrace.h: Rename include guard.
1235         * nat/glibc_thread_db.h: Rename include guard.
1236         * nat/gdb_thread_db.h: Rename include guard.
1237         * nat/gdb_ptrace.h: Rename include guard.
1238         * nat/fork-inferior.h: Rename include guard.
1239         * nat/amd64-linux-siginfo.h: Rename include guard.
1240         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1241         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1242         * nat/aarch64-linux.h: Rename include guard.
1243         * nat/aarch64-linux-hw-point.h: Rename include guard.
1244         * mn10300-tdep.h: Add include guard.
1245         * mips-linux-tdep.h: Add include guard.
1246         * mi/mi-parse.h: Rename include guard.
1247         * mi/mi-out.h: Rename include guard.
1248         * mi/mi-main.h: Rename include guard.
1249         * mi/mi-interp.h: Rename include guard.
1250         * mi/mi-getopt.h: Rename include guard.
1251         * mi/mi-console.h: Rename include guard.
1252         * mi/mi-common.h: Rename include guard.
1253         * mi/mi-cmds.h: Rename include guard.
1254         * mi/mi-cmd-break.h: Rename include guard.
1255         * m2-lang.h: Add include guard.
1256         * location.h: Rename include guard.
1257         * linux-record.h: Rename include guard.
1258         * linux-nat.h: Add include guard.
1259         * linux-fork.h: Add include guard.
1260         * i386-darwin-tdep.h: Rename include guard.
1261         * hppa-linux-offsets.h: Add include guard.
1262         * guile/guile.h: Rename include guard.
1263         * guile/guile-internal.h: Rename include guard.
1264         * gnu-nat.h: Rename include guard.
1265         * gdb-stabs.h: Rename include guard.
1266         * frv-tdep.h: Add include guard.
1267         * f-lang.h: Add include guard.
1268         * event-loop.h: Add include guard.
1269         * darwin-nat.h: Rename include guard.
1270         * cp-abi.h: Rename include guard.
1271         * config/sparc/nm-sol2.h: Rename include guard.
1272         * config/nm-nto.h: Rename include guard.
1273         * config/nm-linux.h: Add include guard.
1274         * config/i386/nm-i386gnu.h: Rename include guard.
1275         * config/djgpp/nl_types.h: Rename include guard.
1276         * config/djgpp/langinfo.h: Rename include guard.
1277         * compile/gcc-cp-plugin.h: Add include guard.
1278         * compile/gcc-c-plugin.h: Add include guard.
1279         * compile/compile.h: Rename include guard.
1280         * compile/compile-object-run.h: Rename include guard.
1281         * compile/compile-object-load.h: Rename include guard.
1282         * compile/compile-internal.h: Rename include guard.
1283         * compile/compile-cplus.h: Rename include guard.
1284         * compile/compile-c.h: Rename include guard.
1285         * common/xml-utils.h: Rename include guard.
1286         * common/x86-xstate.h: Rename include guard.
1287         * common/version.h: Rename include guard.
1288         * common/vec.h: Rename include guard.
1289         * common/tdesc.h: Rename include guard.
1290         * common/selftest.h: Rename include guard.
1291         * common/scoped_restore.h: Rename include guard.
1292         * common/scoped_mmap.h: Rename include guard.
1293         * common/scoped_fd.h: Rename include guard.
1294         * common/safe-iterator.h: Rename include guard.
1295         * common/run-time-clock.h: Rename include guard.
1296         * common/refcounted-object.h: Rename include guard.
1297         * common/queue.h: Rename include guard.
1298         * common/ptid.h: Rename include guard.
1299         * common/print-utils.h: Rename include guard.
1300         * common/preprocessor.h: Rename include guard.
1301         * common/pathstuff.h: Rename include guard.
1302         * common/observable.h: Rename include guard.
1303         * common/netstuff.h: Rename include guard.
1304         * common/job-control.h: Rename include guard.
1305         * common/host-defs.h: Rename include guard.
1306         * common/gdb_wait.h: Rename include guard.
1307         * common/gdb_vecs.h: Rename include guard.
1308         * common/gdb_unlinker.h: Rename include guard.
1309         * common/gdb_unique_ptr.h: Rename include guard.
1310         * common/gdb_tilde_expand.h: Rename include guard.
1311         * common/gdb_sys_time.h: Rename include guard.
1312         * common/gdb_string_view.h: Rename include guard.
1313         * common/gdb_splay_tree.h: Rename include guard.
1314         * common/gdb_setjmp.h: Rename include guard.
1315         * common/gdb_ref_ptr.h: Rename include guard.
1316         * common/gdb_optional.h: Rename include guard.
1317         * common/gdb_locale.h: Rename include guard.
1318         * common/gdb_assert.h: Rename include guard.
1319         * common/filtered-iterator.h: Rename include guard.
1320         * common/filestuff.h: Rename include guard.
1321         * common/fileio.h: Rename include guard.
1322         * common/environ.h: Rename include guard.
1323         * common/common-utils.h: Rename include guard.
1324         * common/common-types.h: Rename include guard.
1325         * common/common-regcache.h: Rename include guard.
1326         * common/common-inferior.h: Rename include guard.
1327         * common/common-gdbthread.h: Rename include guard.
1328         * common/common-exceptions.h: Rename include guard.
1329         * common/common-defs.h: Rename include guard.
1330         * common/common-debug.h: Rename include guard.
1331         * common/cleanups.h: Rename include guard.
1332         * common/buffer.h: Rename include guard.
1333         * common/btrace-common.h: Rename include guard.
1334         * common/break-common.h: Rename include guard.
1335         * cli/cli-utils.h: Rename include guard.
1336         * cli/cli-style.h: Rename include guard.
1337         * cli/cli-setshow.h: Rename include guard.
1338         * cli/cli-script.h: Rename include guard.
1339         * cli/cli-interp.h: Rename include guard.
1340         * cli/cli-decode.h: Rename include guard.
1341         * cli/cli-cmds.h: Rename include guard.
1342         * charset-list.h: Add include guard.
1343         * buildsym-legacy.h: Rename include guard.
1344         * bfin-tdep.h: Add include guard.
1345         * ax.h: Rename include guard.
1346         * arm-linux-tdep.h: Add include guard.
1347         * arm-fbsd-tdep.h: Add include guard.
1348         * arch/xtensa.h: Rename include guard.
1349         * arch/tic6x.h: Add include guard.
1350         * arch/i386.h: Add include guard.
1351         * arch/arm.h: Rename include guard.
1352         * arch/arm-linux.h: Rename include guard.
1353         * arch/arm-get-next-pcs.h: Rename include guard.
1354         * arch/amd64.h: Add include guard.
1355         * arch/aarch64-insn.h: Rename include guard.
1356         * arch-utils.h: Rename include guard.
1357         * annotate.h: Add include guard.
1358         * amd64-darwin-tdep.h: Rename include guard.
1359         * aarch64-linux-tdep.h: Add include guard.
1360         * aarch64-fbsd-tdep.h: Add include guard.
1361         * aarch32-linux-nat.h: Add include guard.
1362
1363 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1364
1365         * macrotab.c (macro_define_internal): New function that
1366         factorizes macro_define_object_internal and macro_define_function
1367         code.
1368         (macro_define_object_internal): Use macro_define_internal.
1369         (macro_define_function): Likewise.
1370
1371 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1372
1373         * macrocmd.c (extract_identifier): Return
1374         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1375         callers.
1376
1377 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1378
1379         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1380
1381 2019-02-05  Tom Tromey  <tom@tromey.com>
1382
1383         * target.c (target_stack::unpush): Move assertion earlier.
1384
1385 2019-01-30  Tom Tromey  <tom@tromey.com>
1386
1387         PR python/23615:
1388         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1389         (gdbpy_parse_and_eval): Likewise.
1390         * python/python-internal.h (gdbpy_allow_threads): New class.
1391
1392 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1393
1394         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1395         (aarch64_fbsd_fpregmap): Move earlier.
1396         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1397         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1398         instead of individual calls to trad_frame_set_reg_addr.
1399         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1400         earlier.
1401         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1402         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1403         instead of individual calls to trad_frame_set_reg_addr.
1404
1405 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1406
1407         * CONTRIBUTE: Replace contribution list with wiki link.
1408
1409 2019-01-25  Tom Tromey  <tom@tromey.com>
1410
1411         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1412
1413 2019-01-25  Tom Tromey  <tom@tromey.com>
1414
1415         * xtensa-linux-nat.c: Fix common/ includes.
1416         * xml-support.h: Fix common/ includes.
1417         * xml-support.c: Fix common/ includes.
1418         * x86-linux-nat.c: Fix common/ includes.
1419         * windows-nat.c: Fix common/ includes.
1420         * varobj.h: Fix common/ includes.
1421         * varobj.c: Fix common/ includes.
1422         * value.c: Fix common/ includes.
1423         * valops.c: Fix common/ includes.
1424         * utils.c: Fix common/ includes.
1425         * unittests/xml-utils-selftests.c: Fix common/ includes.
1426         * unittests/utils-selftests.c: Fix common/ includes.
1427         * unittests/unpack-selftests.c: Fix common/ includes.
1428         * unittests/tracepoint-selftests.c: Fix common/ includes.
1429         * unittests/style-selftests.c: Fix common/ includes.
1430         * unittests/string_view-selftests.c: Fix common/ includes.
1431         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1432         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1433         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1434         * unittests/rsp-low-selftests.c: Fix common/ includes.
1435         * unittests/parse-connection-spec-selftests.c: Fix common/
1436         includes.
1437         * unittests/optional-selftests.c: Fix common/ includes.
1438         * unittests/offset-type-selftests.c: Fix common/ includes.
1439         * unittests/observable-selftests.c: Fix common/ includes.
1440         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1441         * unittests/memrange-selftests.c: Fix common/ includes.
1442         * unittests/memory-map-selftests.c: Fix common/ includes.
1443         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1444         * unittests/function-view-selftests.c: Fix common/ includes.
1445         * unittests/environ-selftests.c: Fix common/ includes.
1446         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1447         * unittests/common-utils-selftests.c: Fix common/ includes.
1448         * unittests/cli-utils-selftests.c: Fix common/ includes.
1449         * unittests/array-view-selftests.c: Fix common/ includes.
1450         * ui-file.c: Fix common/ includes.
1451         * tui/tui-io.c: Fix common/ includes.
1452         * tracepoint.h: Fix common/ includes.
1453         * tracepoint.c: Fix common/ includes.
1454         * tracefile-tfile.c: Fix common/ includes.
1455         * top.h: Fix common/ includes.
1456         * top.c: Fix common/ includes.
1457         * thread.c: Fix common/ includes.
1458         * target/waitstatus.h: Fix common/ includes.
1459         * target/waitstatus.c: Fix common/ includes.
1460         * target.h: Fix common/ includes.
1461         * target.c: Fix common/ includes.
1462         * target-memory.c: Fix common/ includes.
1463         * target-descriptions.c: Fix common/ includes.
1464         * symtab.h: Fix common/ includes.
1465         * symfile.c: Fix common/ includes.
1466         * stap-probe.c: Fix common/ includes.
1467         * spu-linux-nat.c: Fix common/ includes.
1468         * sparc-nat.c: Fix common/ includes.
1469         * source.c: Fix common/ includes.
1470         * solib.c: Fix common/ includes.
1471         * solib-target.c: Fix common/ includes.
1472         * ser-unix.c: Fix common/ includes.
1473         * ser-tcp.c: Fix common/ includes.
1474         * ser-pipe.c: Fix common/ includes.
1475         * ser-base.c: Fix common/ includes.
1476         * selftest-arch.c: Fix common/ includes.
1477         * s12z-tdep.c: Fix common/ includes.
1478         * rust-exp.y: Fix common/ includes.
1479         * rs6000-aix-tdep.c: Fix common/ includes.
1480         * riscv-tdep.c: Fix common/ includes.
1481         * remote.c: Fix common/ includes.
1482         * remote-notif.h: Fix common/ includes.
1483         * remote-fileio.h: Fix common/ includes.
1484         * remote-fileio.c: Fix common/ includes.
1485         * regcache.h: Fix common/ includes.
1486         * regcache.c: Fix common/ includes.
1487         * record-btrace.c: Fix common/ includes.
1488         * python/python.c: Fix common/ includes.
1489         * python/py-type.c: Fix common/ includes.
1490         * python/py-inferior.c: Fix common/ includes.
1491         * progspace.h: Fix common/ includes.
1492         * producer.c: Fix common/ includes.
1493         * procfs.c: Fix common/ includes.
1494         * proc-api.c: Fix common/ includes.
1495         * printcmd.c: Fix common/ includes.
1496         * ppc-linux-nat.c: Fix common/ includes.
1497         * parser-defs.h: Fix common/ includes.
1498         * osdata.c: Fix common/ includes.
1499         * obsd-nat.c: Fix common/ includes.
1500         * nat/x86-linux.c: Fix common/ includes.
1501         * nat/x86-linux-dregs.c: Fix common/ includes.
1502         * nat/x86-dregs.h: Fix common/ includes.
1503         * nat/x86-dregs.c: Fix common/ includes.
1504         * nat/ppc-linux.c: Fix common/ includes.
1505         * nat/mips-linux-watch.h: Fix common/ includes.
1506         * nat/mips-linux-watch.c: Fix common/ includes.
1507         * nat/linux-waitpid.c: Fix common/ includes.
1508         * nat/linux-ptrace.h: Fix common/ includes.
1509         * nat/linux-ptrace.c: Fix common/ includes.
1510         * nat/linux-procfs.c: Fix common/ includes.
1511         * nat/linux-personality.c: Fix common/ includes.
1512         * nat/linux-osdata.c: Fix common/ includes.
1513         * nat/linux-namespaces.c: Fix common/ includes.
1514         * nat/linux-btrace.h: Fix common/ includes.
1515         * nat/linux-btrace.c: Fix common/ includes.
1516         * nat/fork-inferior.c: Fix common/ includes.
1517         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1518         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1519         * nat/aarch64-linux.c: Fix common/ includes.
1520         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1521         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1522         * namespace.h: Fix common/ includes.
1523         * mips-linux-tdep.c: Fix common/ includes.
1524         * minsyms.c: Fix common/ includes.
1525         * mi/mi-parse.h: Fix common/ includes.
1526         * mi/mi-main.c: Fix common/ includes.
1527         * mi/mi-cmd-env.c: Fix common/ includes.
1528         * memrange.h: Fix common/ includes.
1529         * memattr.c: Fix common/ includes.
1530         * maint.h: Fix common/ includes.
1531         * maint.c: Fix common/ includes.
1532         * main.c: Fix common/ includes.
1533         * machoread.c: Fix common/ includes.
1534         * location.c: Fix common/ includes.
1535         * linux-thread-db.c: Fix common/ includes.
1536         * linux-nat.c: Fix common/ includes.
1537         * linux-fork.c: Fix common/ includes.
1538         * inline-frame.c: Fix common/ includes.
1539         * infrun.c: Fix common/ includes.
1540         * inflow.c: Fix common/ includes.
1541         * inferior.h: Fix common/ includes.
1542         * inferior.c: Fix common/ includes.
1543         * infcmd.c: Fix common/ includes.
1544         * inf-ptrace.c: Fix common/ includes.
1545         * inf-child.c: Fix common/ includes.
1546         * ia64-linux-nat.c: Fix common/ includes.
1547         * i387-tdep.c: Fix common/ includes.
1548         * i386-tdep.c: Fix common/ includes.
1549         * i386-linux-tdep.c: Fix common/ includes.
1550         * i386-linux-nat.c: Fix common/ includes.
1551         * i386-go32-tdep.c: Fix common/ includes.
1552         * i386-fbsd-tdep.c: Fix common/ includes.
1553         * i386-fbsd-nat.c: Fix common/ includes.
1554         * guile/scm-type.c: Fix common/ includes.
1555         * guile/guile.c: Fix common/ includes.
1556         * go32-nat.c: Fix common/ includes.
1557         * gnu-nat.c: Fix common/ includes.
1558         * gdbthread.h: Fix common/ includes.
1559         * gdbarch-selftests.c: Fix common/ includes.
1560         * gdb_usleep.c: Fix common/ includes.
1561         * gdb_select.h: Fix common/ includes.
1562         * gdb_bfd.c: Fix common/ includes.
1563         * gcore.c: Fix common/ includes.
1564         * fork-child.c: Fix common/ includes.
1565         * findvar.c: Fix common/ includes.
1566         * fbsd-nat.c: Fix common/ includes.
1567         * event-top.c: Fix common/ includes.
1568         * event-loop.c: Fix common/ includes.
1569         * dwarf2read.c: Fix common/ includes.
1570         * dwarf2loc.c: Fix common/ includes.
1571         * dwarf2-frame.c: Fix common/ includes.
1572         * dwarf-index-cache.c: Fix common/ includes.
1573         * dtrace-probe.c: Fix common/ includes.
1574         * disasm-selftests.c: Fix common/ includes.
1575         * defs.h: Fix common/ includes.
1576         * csky-tdep.c: Fix common/ includes.
1577         * cp-valprint.c: Fix common/ includes.
1578         * cp-support.h: Fix common/ includes.
1579         * cp-support.c: Fix common/ includes.
1580         * corelow.c: Fix common/ includes.
1581         * completer.h: Fix common/ includes.
1582         * completer.c: Fix common/ includes.
1583         * compile/compile.c: Fix common/ includes.
1584         * compile/compile-loc2c.c: Fix common/ includes.
1585         * compile/compile-cplus-types.c: Fix common/ includes.
1586         * compile/compile-cplus-symbols.c: Fix common/ includes.
1587         * command.h: Fix common/ includes.
1588         * cli/cli-dump.c: Fix common/ includes.
1589         * cli/cli-cmds.c: Fix common/ includes.
1590         * charset.c: Fix common/ includes.
1591         * build-id.c: Fix common/ includes.
1592         * btrace.h: Fix common/ includes.
1593         * btrace.c: Fix common/ includes.
1594         * breakpoint.h: Fix common/ includes.
1595         * breakpoint.c: Fix common/ includes.
1596         * ax.h: 
1597         (enum agent_op): Fix common/ includes.
1598         * ax-general.c (struct aop_map): Fix common/ includes.
1599         * ax-gdb.c: Fix common/ includes.
1600         * auxv.c: Fix common/ includes.
1601         * auto-load.c: Fix common/ includes.
1602         * arm-tdep.c: Fix common/ includes.
1603         * arch/riscv.c: Fix common/ includes.
1604         * arch/ppc-linux-common.c: Fix common/ includes.
1605         * arch/i386.c: Fix common/ includes.
1606         * arch/arm.c: Fix common/ includes.
1607         * arch/arm-linux.c: Fix common/ includes.
1608         * arch/arm-get-next-pcs.c: Fix common/ includes.
1609         * arch/amd64.c: Fix common/ includes.
1610         * arch/aarch64.c: Fix common/ includes.
1611         * arch/aarch64-insn.c: Fix common/ includes.
1612         * arch-utils.c: Fix common/ includes.
1613         * amd64-windows-tdep.c: Fix common/ includes.
1614         * amd64-tdep.c: Fix common/ includes.
1615         * amd64-sol2-tdep.c: Fix common/ includes.
1616         * amd64-obsd-tdep.c: Fix common/ includes.
1617         * amd64-nbsd-tdep.c: Fix common/ includes.
1618         * amd64-linux-tdep.c: Fix common/ includes.
1619         * amd64-linux-nat.c: Fix common/ includes.
1620         * amd64-fbsd-tdep.c: Fix common/ includes.
1621         * amd64-fbsd-nat.c: Fix common/ includes.
1622         * amd64-dicos-tdep.c: Fix common/ includes.
1623         * amd64-darwin-tdep.c: Fix common/ includes.
1624         * agent.c: Fix common/ includes.
1625         * ada-lang.h: Fix common/ includes.
1626         * ada-lang.c: Fix common/ includes.
1627         * aarch64-tdep.c: Fix common/ includes.
1628
1629 2019-01-25  Tom Tromey  <tom@tromey.com>
1630
1631         * common/create-version.sh: Use common/version.h.
1632
1633 2019-01-24  Pedro Alves  <palves@redhat.com>
1634
1635         * infrun.c (signal_stop, signal_print, signal_program)
1636         (signal_catch, signal_pass): Now arrays instead of pointers.
1637         (update_signals_program_target, do_target_resume)
1638         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1639         * linux-nat.c (linux_nat_target::pass_signals)
1640         (linux_nat_target::create_inferior, linux_nat_target::attach):
1641         Adjust.
1642         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1643         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1644         * procfs.c (procfs_target::pass_signals): Adjust.
1645         * record-full.c (record_full_target::resume): Adjust.
1646         * remote.c (remote_target::pass_signals)
1647         (remote_target::program_signals): Adjust.
1648         * target-debug.h (target_debug_print_signals): Now takes a
1649         gdb::array_view as parameter.  Adjust.
1650         * target.h (target_ops) <pass_signals, program_signals>: Replace
1651         pointer and length parameters with gdb::array_view.
1652         (target_pass_signals, target_program_signals): Likewise.
1653         * target-delegates.c: Regenerate.
1654
1655 2019-01-24  Pedro Alves  <palves@redhat.com>
1656
1657         * common/forward-scope-exit.h
1658         (forward_scope_exit::forward_scope_exit): Pass arguments to
1659         m_bind_function directly, instead of creating a std::bind and
1660         copying that.
1661
1662 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1663
1664         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1665         for static members.
1666         (pass_in_v_vfp_candidate): Likewise.
1667
1668 2019-01-23  Tom Tromey  <tom@tromey.com>
1669             Pedro Alves  <palves@redhat.com>
1670
1671         * regcache.c (class regcache_invalidator): Remove.
1672         (regcache::raw_write): Use make_scope_exit.
1673
1674 2019-01-23  Tom Tromey  <tom@tromey.com>
1675
1676         * ui-out.h (class ui_out_emit_type): Update comment.
1677
1678 2019-01-23  Tom Tromey  <tom@tromey.com>
1679
1680         * infrun.c (fetch_inferior_event): Update comment.
1681
1682 2019-01-23  Tom Tromey  <tom@tromey.com>
1683             Pedro Alves  <palves@redhat.com>
1684
1685         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1686         parameter.
1687         (fetch_inferior_event): Use SCOPE_EXIT.
1688
1689
1690 2019-01-23  Tom Tromey  <tom@tromey.com>
1691             Pedro Alves  <palves@redhat.com>
1692
1693         * infrun.c (disable_thread_events): Delete.
1694         (stop_all_threads): Use SCOPE_EXIT.
1695
1696 2019-01-23  Tom Tromey  <tom@tromey.com>
1697             Pedro Alves  <palves@redhat.com>
1698
1699         * symfile.c: Include forward-scope-exit.h.
1700         (clear_symtab_users_cleanup): Replace forward declaration with
1701         a FORWARD_SCOPE_EXIT.
1702         (syms_from_objfile_1): Use the forward_scope_exit and
1703         gdb::optional instead of cleanup_function.
1704         (reread_symbols): Use the forward_scope_exit instead of
1705         cleanup_function.
1706         (clear_symtab_users_cleanup): Remove function.
1707
1708 2019-01-23  Tom Tromey  <tom@tromey.com>
1709             Pedro Alves  <palves@redhat.com>
1710
1711         * linux-nat.c: Include scope-exit.h.
1712         (cleanup_target_stop): Remove.
1713         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1714         SCOPE_EXIT.
1715
1716 2019-01-23  Tom Tromey  <tom@tromey.com>
1717             Pedro Alves  <palves@redhat.com>
1718
1719         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1720         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1721
1722 2019-01-23  Tom Tromey  <tom@tromey.com>
1723             Andrew Burgess  <andrew.burgess@embecosm.com>
1724             Pedro Alves  <palves@redhat.com>
1725
1726         * infrun.c (fetch_inferior_event): Use scope_exit.
1727         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1728         * top.c (execute_command): Use scope_exit.
1729         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1730         * utils.c (do_bpstat_clear_actions_cleanup)
1731         (make_bpstat_clear_actions_cleanup): Remove.
1732
1733 2019-01-23  Tom Tromey  <tom@tromey.com>
1734             Pedro Alves  <palves@redhat.com>
1735
1736         * infrun.c: Include "common/scope-exit.h"
1737         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1738         (wait_for_inferior): Use SCOPE_EXIT.
1739         (fetch_inferior_event): Use scope_exit.
1740
1741 2019-01-23  Tom Tromey  <tom@tromey.com>
1742             Pedro Alves  <palves@redhat.com>
1743
1744         * breakpoint.c (create_breakpoint): Remove cleanup.
1745
1746 2019-01-23  Tom Tromey  <tom@tromey.com>
1747             Andrew Burgess  <andrew.burgess@embecosm.com>
1748             Pedro Alves  <palves@redhat.com>
1749
1750 2019-01-23  Pedro Alves  <palves@redhat.com>
1751
1752         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1753
1754 2019-01-23  Pedro Alves  <palves@redhat.com>
1755             Andrew Burgess  <andrew.burgess@embecosm.com>
1756
1757         * gdbthread.h: Include "common/forward-scope-exit.h".
1758         (scoped_finish_thread_state): Redefine custom class in terms of
1759         forward_scope_exit.
1760
1761 2019-01-23  Pedro Alves  <palves@redhat.com>
1762             Andrew Burgess  <andrew.burgess@embecosm.com>
1763
1764         * common/forward-scope-exit.h: New file.
1765
1766 2019-01-23  Pedro Alves  <palves@redhat.com>
1767             Andrew Burgess  <andrew.burgess@embecosm.com>
1768             Tom Tromey  <tom@tromey.com>
1769
1770         * common/scope-exit.h: New file.
1771
1772 2019-01-23  Pedro Alves  <palves@redhat.com>
1773
1774         * common/preprocessor.h (ESC): Rename to ...
1775         (ESC_PARENS): ... this.
1776         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1777         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1778
1779 2019-01-23  Tom Tromey  <tom@tromey.com>
1780
1781         * language.h (class scoped_switch_to_sym_language_if_auto):
1782         Initialize m_lang in both cases.
1783
1784 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1785
1786         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1787         with XCNEW.
1788
1789 2019-01-22  Tom Tromey  <tom@tromey.com>
1790
1791         * corelow.c: Do not include sys/file.h.
1792
1793 2019-01-22  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui-wingeneral.h: Include gdb_curses.h.
1796
1797 2019-01-22  Tom Tromey  <tom@tromey.com>
1798
1799         * source-cache.h (class source_cache) <get_source_lines,
1800         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1801
1802 2019-01-22  Tom Tromey  <tom@tromey.com>
1803
1804         * remote-fileio.h (struct remote_target): Declare.
1805
1806 2019-01-22  Tom Tromey  <tom@tromey.com>
1807
1808         * python/py-arch.c: Do not include py-ref.h.
1809         * python/py-bpevent.c: Do not include py-ref.h.
1810         * python/py-cmd.c: Do not include py-ref.h.
1811         * python/py-continueevent.c: Do not include py-ref.h.
1812         * python/py-event.h: Do not include py-ref.h.
1813         * python/py-evtregistry.c: Do not include py-ref.h.
1814         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1815         * python/py-frame.c: Do not include py-ref.h.
1816         * python/py-framefilter.c: Do not include py-ref.h.
1817         * python/py-function.c: Do not include py-ref.h.
1818         * python/py-infevents.c: Do not include py-ref.h.
1819         * python/py-linetable.c: Do not include py-ref.h.
1820         * python/py-objfile.c: Do not include py-ref.h.
1821         * python/py-param.c: Do not include py-ref.h.
1822         * python/py-prettyprint.c: Do not include py-ref.h.
1823         * python/py-progspace.c: Do not include py-ref.h.
1824         * python/py-symbol.c: Do not include py-ref.h.
1825         * python/py-symtab.c: Do not include py-ref.h.
1826         * python/py-type.c: Do not include py-ref.h.
1827         * python/py-unwind.c: Do not include py-ref.h.
1828         * python/py-utils.c: Do not include py-ref.h.
1829         * python/py-value.c: Do not include py-ref.h.
1830         * python/py-varobj.c: Do not include py-ref.h.
1831         * python/py-xmethods.c: Do not include py-ref.h.
1832         * python/python.c: Do not include py-ref.h.
1833         * varobj.c: Do not include py-ref.h.
1834
1835 2019-01-22  Tom Tromey  <tom@tromey.com>
1836
1837         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1838         keyword for bcache.
1839
1840 2019-01-22  Tom Tromey  <tom@tromey.com>
1841
1842         * compile/compile-cplus-types.c: Remove a comment by #include.
1843
1844 2019-01-22  Tom Tromey  <tom@tromey.com>
1845
1846         * compile/gcc-c-plugin.h: Include compile-internal.h.
1847
1848 2019-01-22  Tom Tromey  <tom@tromey.com>
1849
1850         * stabsread.c (EXTERN): Do not define.
1851         (symnum, next_symbol_text_func, processing_gcc_compilation)
1852         (within_function, global_sym_chain, global_stabs)
1853         (previous_stab_code, this_object_header_files)
1854         (n_this_object_header_files)
1855         (n_allocated_this_object_header_files): Define.
1856         * stabsread.h (EXTERN): Never define.  Use "extern".
1857
1858 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1859
1860         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1861         history_value.
1862
1863 2019-01-21  Tom Tromey  <tom@tromey.com>
1864
1865         * ui-out.c: Fix includes.
1866         * tui/tui-source.c: Fix includes.
1867         * target.c: Fix includes.
1868         * remote.c: Fix includes.
1869         * regcache.c: Fix includes.
1870         * python/py-block.c: Fix includes.
1871         * printcmd.c: Fix includes.
1872         * or1k-tdep.c: Fix includes.
1873         * mi/mi-main.c: Fix includes.
1874         * m32r-tdep.c: Fix includes.
1875         * csky-tdep.c: Fix includes.
1876         * compile/compile-cplus-types.c: Fix includes.
1877         * cli/cli-interp.c: Fix includes.
1878
1879 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1880
1881         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1882         for padding.
1883
1884 2019-01-16  Tom Tromey  <tom@tromey.com>
1885
1886         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1887         earlier.
1888         (struct objfile) <msymbols_range>: Move from top level.
1889         <msymbols>: New method.
1890         (class objfile_msymbols): Remove.
1891         * symtab.c (default_collect_symbol_completion_matches_break_on):
1892         Update.
1893         * symmisc.c (dump_msymbols): Update.
1894         * stabsread.c (scan_file_globals): Update.
1895         * objc-lang.c (info_selectors_command, info_classes_command)
1896         (find_methods): Update.
1897         * minsyms.c (find_solib_trampoline_target): Update.
1898         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1899         * coffread.c (coff_symfile_read): Update.
1900         * ada-lang.c (ada_lookup_simple_minsym)
1901         (ada_collect_symbol_completion_matches): Update.
1902
1903 2019-01-16  Tom Tromey  <tom@tromey.com>
1904
1905         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1906         type.  Remove no-argument constructor.
1907         <iterator::operator++>: Simplify.
1908         <begin>: Update.
1909         <end>: Use minimal_symbol_count.
1910
1911 2019-01-16  Tom Tromey  <tom@tromey.com>
1912
1913         * objfiles.h (struct objfile) <psymtabs>: New method.
1914         (class objfile_psymtabs): Remove.
1915         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1916         typedef.
1917         <range>: New method.
1918         (require_partial_symbols): Change return type.
1919         * psymtab.c (require_partial_symbols)
1920         (psym_expand_symtabs_matching): Update.
1921         * mdebugread.c (parse_partial_symbols): Update.
1922         * dbxread.c (dbx_end_psymtab): Update.
1923
1924 2019-01-15  Tom Tromey  <tom@tromey.com>
1925
1926         * symtab.c (lookup_objfile_from_block)
1927         (lookup_symbol_in_objfile_symtabs)
1928         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1929         (find_line_symtab, info_sources_command)
1930         (default_collect_symbol_completion_matches_break_on)
1931         (make_source_files_completion_list): Update.
1932         * symmisc.c (print_objfile_statistics, dump_objfile)
1933         (maintenance_print_symbols, maintenance_info_symtabs)
1934         (maintenance_check_symtabs, maintenance_info_line_tables):
1935         Update.
1936         * source.c (select_source_symtab)
1937         (forget_cached_source_info_for_objfile): Update.
1938         * objfiles.h (class objfile_compunits): Remove.
1939         (struct objfile) <compunits_range>: New typedef.
1940         (compunits): New method.
1941         * objfiles.c (objfile_relocate1): Update.
1942         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1943         * maint.c (count_symtabs_and_blocks): Update.
1944         * linespec.c (iterate_over_all_matching_symtabs): Update.
1945         * cp-support.c (add_symbol_overload_list_qualified): Update.
1946         * coffread.c (coff_symtab_read): Update.
1947         * ada-lang.c (add_nonlocal_symbols)
1948         (ada_collect_symbol_completion_matches)
1949         (ada_add_global_exceptions): Update.
1950
1951 2019-01-15  Tom Tromey  <tom@tromey.com>
1952
1953         * progspace.h (program_space) <objfiles_safe_range>: New
1954         typedef.
1955         <objfiles_safe>: New method.
1956         * objfiles.h (class all_objfiles_safe): Remove.
1957         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1958         * jit.c (jit_inferior_exit_hook): Update.
1959
1960 2019-01-17  Tom Tromey  <tom@tromey.com>
1961
1962         * progspace.h (program_space) <objfiles_range>: New typedef.
1963         <objfiles>: New method.
1964         <objfiles_head>: Rename from objfiles.
1965         (object_files): Update.
1966         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1967         * guile/scm-pretty-print.c
1968         (ppscm_find_pretty_printer_from_objfiles): Update.
1969         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1970         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1971         Update.
1972         * python/py-progspace.c (pspy_get_objfiles): Update.
1973         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1974         Update.
1975         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1976         (objfpy_lookup_objfile_by_build_id): Update.
1977         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1978         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1979         Update.
1980         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1981         (expand_symtab_containing_pc, lookup_objfile_from_block)
1982         (lookup_static_symbol, basic_lookup_transparent_type)
1983         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1984         (find_line_symtab, info_sources_command)
1985         (default_collect_symbol_completion_matches_break_on)
1986         (make_source_files_completion_list, find_main_name): Update.
1987         * symmisc.c (print_symbol_bcache_statistics)
1988         (print_objfile_statistics, maintenance_print_symbols)
1989         (maintenance_print_msymbols, maintenance_print_objfiles)
1990         (maintenance_info_symtabs, maintenance_check_symtabs)
1991         (maintenance_expand_symtabs, maintenance_info_line_tables):
1992         Update.
1993         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1994         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1995         (map_overlay_command, unmap_overlay_command)
1996         (simple_overlay_update, expand_symtabs_matching)
1997         (map_symbol_filenames): Update.
1998         * symfile-debug.c (set_debug_symfile): Update.
1999         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2000         Update.
2001         * source.c (select_source_symtab, forget_cached_source_info):
2002         Update.
2003         * solib.c (solib_read_symbols): Update.
2004         * solib-spu.c (append_ocl_sos): Update.
2005         * psymtab.c (maintenance_print_psymbols)
2006         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2007         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2008         * printcmd.c (info_symbol_command): Update.
2009         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2010         Update.
2011         * objfiles.h (class all_objfiles): Remove.
2012         * objfiles.c (have_partial_symbols, have_full_symbols)
2013         (have_minimal_symbols, qsort_cmp, update_section_map)
2014         (shared_objfile_contains_address_p)
2015         (default_iterate_over_objfiles_in_search_order): Update.
2016         * objc-lang.c (info_selectors_command, info_classes_command)
2017         (find_methods): Update.
2018         * minsyms.c (find_solib_trampoline_target): Update.
2019         * maint.c (maintenance_info_sections)
2020         (maintenance_translate_address, count_symtabs_and_blocks):
2021         Update.
2022         * main.c (captured_main_1): Update.
2023         * linux-thread-db.c (try_thread_db_load_from_pdir)
2024         (has_libpthread): Update.
2025         * linespec.c (iterate_over_all_matching_symtabs)
2026         (search_minsyms_for_name): Update.
2027         * jit.c (jit_find_objf_with_entry_addr): Update.
2028         * hppa-tdep.c (find_unwind_entry)
2029         (hppa_lookup_stub_minimal_symbol): Update.
2030         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2031         Update.
2032         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2033         (elf_gnu_ifunc_resolve_by_got): Update.
2034         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2035         * dwarf-index-write.c (save_gdb_index_command): Update.
2036         * cp-support.c (add_symbol_overload_list_qualified): Update.
2037         * breakpoint.c (create_overlay_event_breakpoint)
2038         (create_longjmp_master_breakpoint)
2039         (create_std_terminate_master_breakpoint)
2040         (create_exception_master_breakpoint): Update.
2041         * blockframe.c (find_pc_partial_function): Update.
2042         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2043         (ada_collect_symbol_completion_matches)
2044         (ada_add_global_exceptions): Update.
2045
2046 2019-01-17  Tom Tromey  <tom@tromey.com>
2047
2048         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2049         declare VEC.
2050         (solib_target_parse_libraries): Change return type.
2051         (library_list_start_segment, library_list_start_section)
2052         (library_list_end_library, library_list_start_library); Update.
2053         (solib_target_free_library_list): Remove.
2054         (solib_target_parse_libraries): Remove cleanup.  Change return
2055         type.
2056         (solib_target_current_sos): Update.
2057
2058 2019-01-17  Tom Tromey  <tromey@bapiya>
2059
2060         * valprint.c: Replace "the the" with "the".
2061         * symtab.c: Replace "the the" with "the".
2062         * solib.c: Replace "the the" with "the".
2063         * solib-dsbt.c: Replace "the the" with "the".
2064         * linespec.c: Replace "the the" with "the".
2065         * dwarf2loc.h: Replace "the the" with "the".
2066         * amd64-windows-tdep.c: Replace "the the" with "the".
2067         * aarch64-tdep.c: Replace "the the" with "the".
2068
2069 2019-01-16  Keith Seitz  <keiths@redhat.com>
2070
2071         PR gdb/23773
2072         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2073         <builder>: Rename to ..
2074         <m_builder>: ... this and make private.
2075         (dwarf2_cu::get_builder): New method.  Change all users of
2076         `builder' to use this method.
2077         (dwarf2_start_symtab): Move to ...
2078         (dwarf2_cu::start_symtab): ... here.  Update all callers
2079         (setup_type_unit_groups): Move to ...
2080         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2081         callers.
2082         (dwarf2_cu::reset_builder): New method.
2083         (process_full_compunit, process_full_type_unit): Use
2084         dwarf2_cu::reset_builder.
2085         (follow_die_offset): Record the ancestor CU if it is different
2086         from the followed DIE's CU.
2087         (follow_die_sig_1): Likewise.
2088
2089 2019-01-15  Tom Tromey  <tom@tromey.com>
2090
2091         * remote.c (class remote_state) <buf>: Now a char_vector.
2092         <buf_size>: Remove.
2093         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2094         parameter.
2095         (remote_target::getpkt_or_notif_sane_1)
2096         (remote_target::getpkt_sane)
2097         (remote_target::getpkt_or_notif_sane): Likewise.
2098         (class remote_target) <putpkt>: New overload.
2099         (remote_target::read_frame): Change type of "buf_p".  Remove
2100         sizeof_p parameter.
2101         (packet_ok): New overload.
2102         (packet_check_result): New overload.
2103         Update all uses.
2104
2105 2019-01-14  Tom Tromey  <tom@tromey.com>
2106
2107         * remote-notif.c (handle_notification, remote_notif_ack)
2108         (remote_notif_parse): Make "buf" const.
2109         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2110         const.
2111         (remote_notif_parse, remote_notif_ack, handle_notification):
2112         Likewise.
2113         * remote.c (remote_notif_stop_parse): Make "buf" const.
2114         (remote_target::remote_parse_stop_reply): Make "buf" const.
2115         (remote_notif_stop_ack): Make "buf" const.
2116
2117 2019-01-14  Tom Tromey  <tom@tromey.com>
2118
2119         * remote.c (remote_console_output): Make parameter const.
2120
2121 2019-01-14  Tom Tromey  <tom@tromey.com>
2122
2123         * target-debug.h (target_debug_print_signals): Constify.
2124         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2125         * procfs.c (procfs_target::pass_signals): Update.
2126         * linux-nat.c (linux_nat_target::pass_signals): Update.
2127         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2128         * target-delegates.c: Rebuild.
2129         * remote.c (remote_target::program_signals): Update.
2130         (remote_target::pass_signals): Update.
2131         * target.c (target_pass_signals): Constify argument.
2132         (target_program_signals): Likewise.
2133         * target.h (struct target_ops) <pass_signals, program_signals>:
2134         Constify argument.
2135         (target_pass_signals, target_program_signals): Constify argument.
2136
2137 2019-01-14  Tom Tromey  <tom@tromey.com>
2138
2139         PR tui/28819:
2140         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2141
2142 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2143
2144         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2145         field.
2146         * rs6000-tdep.c: Include reggroups.h.
2147         (IS_V_ALIAS_PSEUDOREG): Define.
2148         (rs6000_register_name): Return names for the "vX" aliases.
2149         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2150         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2151         aliases.  Call default_register_reggroup_p for all other
2152         pseudo-registers.
2153         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2154         New functions.
2155         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2156         Handle "vX" aliases.
2157         (v_alias_pseudo_register_collect): New function.
2158         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2159         (rs6000_gdbarch_init): Initialize "vX" aliases as
2160         pseudo-registers.  Restore registration of
2161         rs6000_pseudo_register_reggroup_p with
2162         set_tdesc_pseudo_register_reggroup_p.
2163
2164 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2165
2166         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2167         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2168         set_gdbarch_num_pseudo_regs.
2169
2170 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2171
2172         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2173         Remove arg prefixname, add do_set and do_show.
2174         Add member functions set_list and show_list.
2175         * cli/cli-style.c (class cli_style_option): Update accordingly.
2176         (style_set_list): Move to file scope.
2177         (style_show_list): Likewise.
2178         (set_style): Call help_list.
2179         (show_style): Call cmd_show_list.
2180         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2181         Update to use the new macro.
2182
2183 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2184
2185         * ada-lang.c (_initialize_ada_language): Expand the help text
2186         for the "catch exception" command.
2187
2188 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2189
2190         * symtab.c (matching_obj_sections): Initialize obj,
2191         declare it closer to its usage.
2192
2193 2019-01-10  Tom Tromey  <tom@tromey.com>
2194
2195         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2196         (basic_inf_threads_range): Remove.
2197         (inf_threads_range, inf_non_exited_threads_range)
2198         (safe_inf_threads_range): Use next_adapter.
2199
2200 2019-01-10  Keith Seitz  <keiths@redhat.com>
2201
2202         PR gdb/23712
2203         PR symtab/23010
2204         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2205         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2206
2207 2019-01-10  Keith Seitz  <keiths@redhat.com>
2208
2209         PR gdb/23712
2210         PR symtab/23010
2211         * dictionary.c (pending_to_vector): Remove.
2212         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2213         Remove _1 suffix, replacing functions of the same name.  Update
2214         all callers.
2215         (dict_create_hashed, dict_create_hashed_expandable)
2216         (dict_create_linear, dict_create_linear_expandable, dict_free)
2217         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2218         Make functions static.
2219
2220 2019-01-10  Keith Seitz  <keiths@redhat.com>
2221
2222         PR gdb/23712
2223         PR symtab/23010
2224         * dictionary.h (struct dictionary): Replace declaration with
2225         multidictionary.
2226         (dict_create_hashed, dict_create_hashed_expandable)
2227         (dict_create_linear, dict_create_linear_expandable)
2228         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2229         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2230         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2231         taking multidictionary argument.
2232         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2233         * block.h (struct block) <dict>: Change to multidictionary
2234         and rename `multidict'.
2235         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2236         symmisc.c: Update all dictionary references to multidictionary.
2237
2238 2019-01-10  Keith Seitz  <keiths@redhat.com>
2239
2240         PR gdb/23712
2241         PR symtab/23010
2242         * dictionary.c: Include unordered_map.
2243         (pending_to_vector): New function.
2244         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2245         Rewrite the non-"_1" functions to take vector instead
2246         of linked list.
2247         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2248         "new" _1 versions of the same name.
2249         (multidictionary): Define.
2250         (std::hash<enum language): New definition.
2251         (collate_pending_symbols_by_language, mdict_create_hashed)
2252         (mdict_create_hashed_expandable, mdict_create_linear)
2253         (mdict_create_linear_expandable, mdict_free)
2254         (find_language_dictionary, create_new_language_dictionary)
2255         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2256         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2257         (mdict_size, mdict_empty): New functions.
2258         * dictionary.h (mdict_iterator): Define.
2259
2260 2019-01-10  Pedro Alves  <palves@redhat.com>
2261
2262         * breakpoint.c (read_uploaded_action)
2263         (create_tracepoint_from_upload): Adjust to use
2264         gdb::unique_xmalloc_ptr.
2265         * ctf.c (ctf_write_uploaded_tp):
2266         (SET_ARRAY_FIELD): Use emplace_back.
2267         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2268         * tracefile-tfile.c (tfile_write_uploaded_tp):
2269         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2270         gdb::unique_xmalloc_ptr.
2271         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2272         at_string, cond_string, cmd_strings>: Replace char pointers
2273         with gdb::unique_xmalloc_ptr.
2274
2275 2019-01-10  Pedro Alves  <palves@redhat.com>
2276
2277         * solib-target.c (library_list_start_library): Don't xstrdup name.
2278
2279 2019-01-10  Pedro Alves  <palves@redhat.com>
2280
2281         * mdebugread.c (parse_partial_symbols): Use
2282         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2283
2284 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2285
2286         * linux-fork.c (scoped_switch_fork_info)
2287         <~scoped_switch_fork_info>: Fix incorrect variable name.
2288
2289 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2290
2291         * linux-fork.c (scoped_switch_fork_info)
2292         <scoped_switch_fork_info>: Make explicit.
2293         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2294
2295 2019-01-10  Tom Tromey  <tom@tromey.com>
2296
2297         * objfiles.h (objfile::reset_psymtabs): Update.
2298         * objfiles.c (objfile::objfile): Update.
2299         * psymtab.h (psymtab_storage::obstack): Update.
2300         (psymtab_storage::m_obstack): Use gdb::optional.
2301         (class psymtab_storage): Update comment.  Remove objfile
2302         parameter.
2303         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2304
2305 2019-01-10  Tom Tromey  <tom@tromey.com>
2306
2307         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2308         <free_psymtabs>: Now private.
2309         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2310         (allocate_psymtab): Use new method.
2311
2312 2019-01-10  Tom Tromey  <tom@tromey.com>
2313
2314         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2315         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2316         * mdebugread.c (parse_partial_symbols): Use
2317         allocate_dependencies.
2318         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2319         allocate_dependencies.
2320         (process_psymtab_comp_unit_reader)
2321         (build_type_psymtab_dependencies): Likewise.
2322         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2323
2324 2019-01-10  Tom Tromey  <tom@tromey.com>
2325
2326         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2327         PSYMBOL_SET_LANGUAGE.
2328         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2329
2330 2019-01-10  Tom Tromey  <tom@tromey.com>
2331
2332         * psymtab.h (psymtab_storage::obstack): New method.
2333         <m_obstack>: Rename from obstack; now private.
2334         * psymtab.c (psymtab_storage): Update.
2335         * dwarf2read.c (create_addrmap_from_index)
2336         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2337         Update.
2338
2339 2019-01-10  Tom Tromey  <tom@tromey.com>
2340
2341         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2342         * objfiles.h (objfile::reset_psymtabs): New method.
2343
2344 2019-01-10  Tom Tromey  <tom@tromey.com>
2345
2346         * symmisc.c (print_symbol_bcache_statistics): Update.
2347         (print_objfile_statistics): Update.
2348         * symfile.c (reread_symbols): Update.
2349         * psymtab.h (class psymtab_storage): New.
2350         * psymtab.c (psymtab_storage): New constructor.
2351         (~psymtab_storage): New destructor.
2352         (require_partial_symbols): Update.
2353         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2354         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2355         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2356         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2357         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2358         (start_psymtab_common, end_psymtab_common)
2359         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2360         (allocate_psymtab): Update.
2361         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2362         Update.
2363         (dump_psymtab_addrmap, maintenance_print_psymbols)
2364         (maintenance_check_psymtabs): Update.
2365         (class objfile_psymtabs): Move to objfiles.h.
2366         * psympriv.h (discard_psymtab): Now inline.
2367         (psymtab_discarder::psymtab_discarder): Update.
2368         (psymtab_discarder::~psymtab_discarder): Update.
2369         (ALL_OBJFILE_PSYMTABS): Rewrite.
2370         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2371         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2372         Remove fields.
2373         <partial_symtabs>: New field.
2374         (class objfile_psymtabs): Move from psymtab.h.  Update.
2375         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2376         psymbol_cache.
2377         (objfile::~objfile): Don't destroy psymbol_cache.
2378         * mdebugread.c (parse_partial_symbols): Update.
2379         * dwarf2read.c (create_addrmap_from_index)
2380         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2381         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2382         (add_partial_subprogram, dwarf2_ranges_read): Update.
2383         * dwarf-index-write.c (write_address_map)
2384         (write_one_signatured_type, recursively_write_psymbols)
2385         (class debug_names, class debug_names, write_psymtabs_to_index):
2386         Update.
2387
2388 2019-01-10  Tom Tromey  <tom@tromey.com>
2389
2390         * symtab.h (SYMBOL_SET_NAMES): Update.
2391         (symbol_set_names): Update.
2392         (MSYMBOL_SET_NAMES): Update.
2393         * symtab.c (symbol_set_names): Change argument to be an
2394         objfile_per_bfd_storage.
2395         * psymtab.c (add_psymbol_to_bcache): Update.
2396         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2397
2398 2019-01-10  Tom Tromey  <tom@tromey.com>
2399
2400         * symtab.c (create_demangled_names_hash): Change argument to be an
2401         objfile_per_bfd_storage.
2402         (symbol_set_names): Update.
2403
2404 2019-01-10  Tom Tromey  <tom@tromey.com>
2405
2406         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2407         init_psymbol_list.
2408         * psymtab.c (init_psymbol_list): Do nothing if already called.
2409         * psympriv.h (init_psymbol_list): Add comment.
2410         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2411         init_psymbol_list.
2412         * dbxread.c (dbx_symfile_read): Unconditionally call
2413         init_psymbol_list.
2414
2415 2019-01-10  Tom Tromey  <tom@tromey.com>
2416
2417         * xcoffread.c (scan_xcoff_symtab): Update.
2418         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2419         "where".
2420         * mdebugread.c (parse_partial_symbols)
2421         (handle_psymbol_enumerators): Update.
2422         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2423         * dbxread.c (read_dbx_symtab): Update.
2424         * psympriv.h (psymbol_placement): New enum.
2425         (add_psymbol_to_list): Update.
2426
2427 2019-01-10  Tom Tromey  <tom@tromey.com>
2428
2429         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2430         static_psymbols parameters.
2431         (scan_xcoff_symtab): Update.
2432         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2433         static_psymbols parameters.
2434         * psympriv.h (start_psymtab_common): Update.
2435         * mdebugread.c (parse_partial_symbols): Update.
2436         * dwarf2read.c (create_partial_symtab): Update.
2437         * dbxread.c (read_dbx_symtab): Update.
2438         (start_psymtab): Remove global_psymbols and static_psymbols
2439         parameters.
2440
2441 2019-01-10  Tom Tromey  <tom@tromey.com>
2442
2443         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2444         * psymtab.c (allocate_psymtab): Add comment.
2445         * psympriv.h (allocate_psymtab): Add comment.
2446         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2447         initializations.
2448         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2449
2450 2019-01-10  Tom Tromey  <tom@tromey.com>
2451
2452         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2453         Don't declare.
2454         * mipsread.c: Include mdebugread.h.
2455         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2456         Declare.
2457         * elfread.c: Include mdebugread.h.
2458
2459 2019-01-09  Tom Tromey  <tom@tromey.com>
2460
2461         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2462         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2463         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2464         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2465         (psym_lookup_symbol, psym_find_last_source_symtab)
2466         (psym_forget_cached_source_info, psym_print_stats)
2467         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2468         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2469         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2470         (psym_find_compunit_symtab_by_address)
2471         (maintenance_print_psymbols, maintenance_info_psymtabs)
2472         (maintenance_check_psymtabs): Use ranged for.
2473         * psymtab.h (class objfile_psymtabs): New.
2474         (require_partial_symbols): Return objfile_psymtabs.
2475         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2476
2477 2019-01-09  Tom Tromey  <tom@tromey.com>
2478
2479         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2480         (find_pc_mapped_section, list_overlays_command)
2481         (map_overlay_command, unmap_overlay_command)
2482         (simple_overlay_update): Use all_objfiles.
2483         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2484         * printcmd.c (info_symbol_command): Use all_objfiles.
2485         * objfiles.h (ALL_OBJSECTIONS): Remove.
2486         * maint.c (maintenance_translate_address): Use all_objfiles.
2487         * gcore.c (gcore_create_callback): Use all_objfiles.
2488         (objfile_find_memory_regions): Likewise.
2489
2490 2019-01-09  Tom Tromey  <tom@tromey.com>
2491
2492         * symtab.c (find_line_symtab, info_sources_command)
2493         (make_source_files_completion_list): Use objfile_compunits.
2494         * source.c (select_source_symtab): Use objfile_compunits.
2495         * objfiles.h (struct objfile): Update comment.
2496         (ALL_OBJFILES): Remove.
2497         (ALL_FILETABS): Remove.
2498         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2499         objfile_compunits.
2500
2501 2019-01-09  Tom Tromey  <tom@tromey.com>
2502
2503         * symmisc.c (print_objfile_statistics, dump_objfile)
2504         (maintenance_print_symbols): Use compunit_filetabs.
2505         * source.c (forget_cached_source_info_for_objfile): Use
2506         compunit_filetabs.
2507         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2508         (ALL_FILETABS): Use compunit_filetabs.
2509         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2510         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2511
2512 2019-01-09  Tom Tromey  <tom@tromey.com>
2513
2514         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2515         (compunit_filetabs): New.
2516         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2517         compunit_filetabs.
2518         (info_sources_command, make_source_files_completion_list): Remove
2519         declaration.
2520         * symmisc.c (print_objfile_statistics, dump_objfile)
2521         (maintenance_print_symbols): Remove declaration.
2522         (maintenance_info_symtabs): Use compunit_filetabs.
2523         (maintenance_info_line_tables): Likewise.
2524         * source.c (select_source_symtab): Change local variable name.
2525         (forget_cached_source_info_for_objfile): Remove declaration.
2526         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2527         * objfiles.c (objfile_relocate1): Remove declaration.
2528         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2529         declaration.
2530         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2531         * coffread.c (coff_symtab_read): Remove declaration.
2532         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2533         compunit_filetabs.
2534
2535 2019-01-09  Tom Tromey  <tom@tromey.com>
2536
2537         * symtab.c (lookup_objfile_from_block)
2538         (find_pc_sect_compunit_symtab, search_symbols)
2539         (default_collect_symbol_completion_matches_break_on): Use
2540         objfile_compunits.
2541         * objfiles.h (ALL_COMPUNITS): Remove.
2542         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2543         * cp-support.c (add_symbol_overload_list_qualified): Use
2544         objfile_compunits.
2545         * ada-lang.c (ada_collect_symbol_completion_matches)
2546         (ada_add_global_exceptions): Use objfile_compunits.
2547
2548 2019-01-09  Tom Tromey  <tom@tromey.com>
2549
2550         * source.c (select_source_symtab)
2551         (forget_cached_source_info_for_objfile): Remove declaration.
2552         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2553         declaration.
2554         * maint.c (count_symtabs_and_blocks): Remove declaration.
2555         * cp-support.c (add_symbol_overload_list_qualified): Remove
2556         declaration.
2557         * coffread.c (coff_symtab_read): Remove declaration.
2558         * symtab.c (lookup_symbol_in_objfile_symtabs)
2559         (basic_lookup_transparent_type_1): Use objfile_compunits.
2560         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2561         (info_sources_command, search_symbols)
2562         (default_collect_symbol_completion_matches_break_on)
2563         (make_source_files_completion_list): Remove declaration.
2564         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2565         (ada_collect_symbol_completion_matches)
2566         (ada_add_global_exceptions): Remove declaration.
2567         * linespec.c (iterate_over_all_matching_symtabs): Use
2568         objfile_compunits.
2569         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2570         (class objfile_compunits): New.
2571         (ALL_COMPUNITS): Use objfile_compunits.
2572         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2573         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2574         objfile_compunits.
2575         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2576
2577 2019-01-09  Tom Tromey  <tom@tromey.com>
2578
2579         * symtab.c (search_symbols)
2580         (default_collect_symbol_completion_matches_break_on): Use
2581         objfile_msymbols.
2582         * ada-lang.c (ada_lookup_simple_minsym)
2583         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2584         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2585         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2586         objfile_msymbols.
2587         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2588         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2589         * objc-lang.c (find_methods): Use objfile_msymbols.
2590         (info_selectors_command, info_classes_command): Likewise.
2591         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2592         * objfiles.h (class objfile_msymbols): New.
2593         (ALL_OBJFILE_MSYMBOLS): Remove.
2594         (ALL_MSYMBOLS): Remove.
2595
2596 2019-01-09  Tom Tromey  <tom@tromey.com>
2597
2598         * common/next-iterator.h (next_adapter): Add Iterator template
2599         parameter.
2600         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2601         (class all_objfiles_safe): New.
2602         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2603         * objfiles.c (put_objfile_before): Update comment.
2604         (add_separate_debug_objfile): Likewise.
2605         (free_all_objfiles): Use all_objfiles_safe.
2606         (objfile_purge_solibs): Likewise.
2607
2608 2019-01-09  Tom Tromey  <tom@tromey.com>
2609
2610         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2611         (expand_symtab_containing_pc, lookup_static_symbol)
2612         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2613         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2614         all_objfiles.
2615         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2616         * breakpoint.c (create_overlay_event_breakpoint)
2617         (create_longjmp_master_breakpoint)
2618         (create_std_terminate_master_breakpoint)
2619         (create_exception_master_breakpoint): Use all_objfiles.
2620         * linux-thread-db.c (try_thread_db_load_from_pdir)
2621         (has_libpthread): Use all_objfiles.
2622         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2623         * linespec.c (iterate_over_all_matching_symtabs)
2624         (search_minsyms_for_name): Use all_objfiles.
2625         * maint.c (maintenance_info_sections): Use all_objfiles.
2626         * main.c (captured_main_1): Use all_objfiles.
2627         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2628         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2629         * guile/scm-pretty-print.c
2630         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2631         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2632         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2633         (maintenance_print_msymbols): Use all_objfiles.
2634         * source.c (select_source_symtab): Use all_objfiles.
2635         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2636         * symfile.c (remove_symbol_file_command)
2637         (expand_symtabs_matching, map_symbol_filenames): Use
2638         all_objfiles.
2639         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2640         all_objfiles.
2641         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2642         * objc-lang.c (find_methods): Use all_objfiles.
2643         * objfiles.c (have_partial_symbols, have_full_symbols)
2644         (have_minimal_symbols, qsort_cmp)
2645         (default_iterate_over_objfiles_in_search_order): Use
2646         all_objfiles.
2647         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2648         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2649         (maintenance_check_psymtabs): Use all_objfiles.
2650         (ALL_PSYMTABS): Remove.
2651         * compile/compile-object-run.c (do_module_cleanup): Use
2652         all_objfiles.
2653         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2654         * cp-support.c (add_symbol_overload_list_qualified): Use
2655         all_objfiles.
2656         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2657         Use all_objfiles.
2658         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2659         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2660         all_objfiles.
2661         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2662         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2663         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2664         Uses all_objfiles.
2665         * solib.c (solib_read_symbols): Use all_objfiles
2666
2667 2019-01-09  Tom Tromey  <tom@tromey.com>
2668
2669         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2670         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2671         all_objfiles.
2672         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2673         * symmisc.c (print_symbol_bcache_statistics)
2674         (print_objfile_statistics, maintenance_print_objfiles)
2675         (maintenance_info_symtabs, maintenance_check_symtabs)
2676         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2677         all_objfiles.
2678         * source.c (forget_cached_source_info): Use all_objfiles.
2679         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2680         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2681         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2682         * objfiles.c (update_section_map): Use all_objfiles.
2683         (shared_objfile_contains_address_p): Likewise.
2684         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2685         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2686
2687 2019-01-09  Tom Tromey  <tom@tromey.com>
2688
2689         * common/next-iterator.h: New file.
2690         * objfiles.h (class all_objfiles): New.
2691         (struct objfile_iterator): New.
2692
2693 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2694
2695         * NEWS: Move the description of the changed "frame", "select-frame",
2696          and "info frame" commands to the Changed commands section.
2697
2698 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2699
2700         * gdbtypes.c (check_stub_method_group): Remove handling of old
2701         mangling schemes.
2702         * linespec.c (find_methods): Likewise.
2703         * stabsread.c (read_member_functions): Likewise.
2704         * valops.c (search_struct_method): Likewise.
2705         (value_struct_elt_for_reference): Likewise.
2706         * NEWS: Mention this change.
2707
2708 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2709
2710         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2711         print_source_lines.
2712         * source.c (print_source_lines_base): Update line number check.
2713         (print_source_lines): New function.
2714         (source_lines_range::source_lines_range): New function.
2715         * source.h (class source_lines_range): New class.
2716         (print_source_lines): New declaration.
2717
2718 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2719
2720         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2721
2722 2019-01-08  Tom Tromey  <tom@tromey.com>
2723             Simon Marchi  <simon.marchi@ericsson.com>
2724
2725         PR gdb/24060
2726         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2727         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2728         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2729         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2730         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2731         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2732
2733 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2734
2735         * source.c (select_source_symtab): Move header comment to
2736         declaration in source.h.
2737         (forget_cached_source_info_for_objfile): Likewise.
2738         (forget_cached_source_info): Likewise.
2739         (identify_source_line): Likewise.
2740         * source.h (identify_source_line): Move declaration from symtab.h
2741         and add comment from source.c
2742         (print_source_lines): Likewise.
2743         (forget_cached_source_info_for_objfile): Likewise.
2744         (forget_cached_source_info): Likewise.
2745         (select_source_symtab): Likewise.
2746         (enum print_source_lines_flag): Move definition from symtab.h.
2747         * symtab.h (identify_source_line): Move declaration to source.h.
2748         (print_source_lines): Likewise.
2749         (forget_cached_source_info_for_objfile): Likewise.
2750         (forget_cached_source_info): Likewise.
2751         (select_source_symtab): Likewise.
2752         (enum print_source_lines_flag): Move definition to source.h.
2753         * tui/tui-hooks.c: Add 'source.h' include.
2754
2755 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2756
2757         * source.c (print_source_lines_base): Handle requests to print
2758         reverse line number sequences, and guard against empty lines
2759         string.
2760
2761 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2762
2763         * source.c (print_source_lines_base): Fix skip of '\r' if next
2764         character is '\n'.
2765
2766 2019-01-06  Tom Tromey  <tom@tromey.com>
2767
2768         * c-exp.y (struct c_parse_state) <macro_original_text,
2769         expansion_obstack>: New member.
2770         (macro_original_text, expansion_obstack): Remove globals.
2771         (scan_macro_expansion, scanning_macro_expansion)
2772         (finished_macro_expansion): Update.
2773         (scan_macro_cleanup): Remove.
2774         (yylex, c_parse): Update.
2775
2776 2019-01-06  Tom Tromey  <tom@tromey.com>
2777
2778         * c-exp.y (struct c_parse_state) <strings>: New member.
2779         (operator_stoken): Update.
2780
2781 2019-01-06  Tom Tromey  <tom@tromey.com>
2782
2783         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2784         (union type_stack_elt) <typelist_val>: Now a pointer to
2785         std::vector.
2786         (type_stack_cleanup): Don't declare.
2787         (push_typelist): Update.
2788         * parse.c (pop_typelist): Return a std::vector.
2789         (push_typelist): Take a std::vector.
2790         (follow_types): Update.  Do not free args.
2791         (type_stack_cleanup): Remove.
2792         * c-exp.y (struct c_parse_state): New.
2793         (cpstate): New global.
2794         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2795         (nonempty_typelist): Update.
2796         (func_mod): Create a new vector.
2797         (c_parse): Create a c_parse_state.
2798         (check_parameter_typelist): Do not delete params.
2799         (function_method): Update.  Do not delete type_list.
2800
2801 2019-01-06  Tom Tromey  <tom@tromey.com>
2802
2803         PR gdb/28155:
2804         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2805         check_typedef.
2806         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2807         (print_return_value): Likewise.
2808
2809 2019-01-05  Tom Tromey  <tom@tromey.com>
2810
2811         * contrib/cleanup_check.py: Remove.
2812         * contrib/gcc-with-excheck: Remove.
2813         * contrib/exsummary.py: Remove.
2814         * contrib/excheck.py: Remove.
2815
2816 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2817
2818         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2819         NULL. Initialize tpprev to NULL instead of assigning it
2820         to NULL on the next statement.
2821         * windows-nat.c (windows_delete_thread): Remove check for
2822         main_thread_id before printing thread exit notifications.
2823         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2824         Remove thread ID check against main_thread_id.
2825         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2826         windows_delete_thread.
2827         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2828
2829 2019-01-04  Tom Tromey  <tom@tromey.com>
2830
2831         * compile/compile.c (_initialize_compile): Use upper case for
2832         metasyntactic variables.
2833         * symmisc.c (_initialize_symmisc): Use upper case for
2834         metasyntactic variables.
2835         * psymtab.c (_initialize_psymtab): Use upper case for
2836         metasyntactic variables.
2837         * demangle.c (demangle_command): Use upper case for metasyntactic
2838         variables.
2839         (_initialize_demangler): Likewise.
2840         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2841         variables.
2842
2843 2019-01-03  Tom Tromey  <tom@tromey.com>
2844
2845         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2846
2847 2019-01-03  Tom Tromey  <tom@tromey.com>
2848
2849         * python/py-symtab.c (salpy_str): Update.
2850         (struct salpy_sal_object) <symtab>: Now a PyObject.
2851         (salpy_dealloc): Update.
2852         (del_objfile_sal): Use gdbpy_ref.
2853
2854 2019-01-03  Tom Tromey  <tom@tromey.com>
2855
2856         * python/py-type.c (convert_field): Use new_reference.  Return
2857         gdbpy_ref.
2858         (make_fielditem): Return gdbpy_ref.
2859         (typy_fields): Update.
2860         (typy_getitem): Update.
2861         (field_name): Return gdbpy_ref.  Use new_reference.
2862         (typy_iterator_iternext): Update.
2863
2864 2019-01-03  Tom Tromey  <tom@tromey.com>
2865
2866         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2867
2868 2019-01-03  Tom Tromey  <tom@tromey.com>
2869
2870         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2871         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2872         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2873         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2874         (pspy_set_type_printers): Likewise.
2875         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2876         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2877         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2878         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2879         (objfpy_set_type_printers): Likewise.
2880
2881 2019-01-03  Tom Tromey  <tom@tromey.com>
2882
2883         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2884         (gdbpy_print_stack): Use gdbpy_err_fetch.
2885         * python/python-internal.h (class gdbpy_err_fetch): New class.
2886         (class gdbpy_enter) <m_error_type, m_error_value,
2887         m_error_traceback>: Remove.
2888         <m_error>: New member.
2889         (gdbpy_exception_to_string): Don't declare.
2890         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2891         * python/py-value.c (convert_value_from_python): Use
2892         gdbpy_err_fetch.
2893         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2894         gdbpy_exception_to_string.
2895         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2896         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2897         gdbpy_err_fetch.
2898
2899 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2900
2901         * linux-nat.c (delete_lwp_cleanup): Delete.
2902         (struct lwp_deleter): New struct.
2903         (lwp_info_up): New typedef.
2904         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2905         lwp_info_up.
2906
2907 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2908
2909         * linux-fork.c (class scoped_switch_fork_info): New class.
2910         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2911
2912 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2913
2914         * valops.c (find_overload_match): Remove use of null_cleanup, and
2915         calls to do_cleanups.
2916
2917 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2918
2919         * compile/compile-cplus-types.c
2920         (compile_cplus_instance::decl_name): Handle changes to
2921         cp_func_name.
2922         * cp-support.c (cp_func_name): Update header comment, update
2923         return type.
2924         * cp-support.h (cp_func_name): Update return type in declaration.
2925         * valops.c (find_overload_match): Move temp_func local to top
2926         level of function and change its type.  Use temp_func to hold and
2927         delete temporary string obtained from cp_func_name.
2928
2929 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2930
2931         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2932         gdb::char_vector, remove cleanup, and update uses of `msg`.
2933
2934 2019-01-03  Jim Wilson  <jimw@sifive.com>
2935
2936         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2937
2938 2019-01-02  Tom Tromey  <tom@tromey.com>
2939
2940         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2941         (tdesc_parse_xml): Remove cleanups.
2942         * target-descriptions.h (make_cleanup_free_target_description):
2943         Don't declare.
2944         (target_desc_deleter): New struct.
2945         (target_desc_up): New typedef.
2946         * target-descriptions.c (target_desc_deleter::operator()): Rename
2947         from free_target_description.
2948         (make_cleanup_free_target_description): Remove.
2949
2950 2019-01-02  Tom Tromey  <tom@tromey.com>
2951
2952         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2953         constructor, destructor.
2954         (linespec_parser): Remove typedef.
2955         (~linespec_parser): Rename from linespec_parser_delete.
2956         (linespec_lex_to_end, linespec_complete_label)
2957         (linespec_complete): Update.
2958         (decode_line_full): Remove cleanups.
2959         (decode_line_1): Update.
2960
2961 2019-01-02  Tom Tromey  <tom@tromey.com>
2962
2963         * python/python-internal.h (inferior_to_inferior_object): Change
2964         return type.
2965         * python/py-exitedevent.c (create_exited_event_object): Update.
2966         * python/py-inferior.c (inferior_to_inferior_object): Return
2967         gdbpy_ref.
2968         (python_new_inferior, python_inferior_deleted)
2969         (thread_to_thread_object, delete_thread_object)
2970         (build_inferior_list, gdbpy_selected_inferior): Update.
2971         * python/py-infthread.c (create_thread_object): Update.  Also fail
2972         if inferior_to_inferior_object fails.
2973
2974 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2975
2976         * inferior.h (class inferior) <displaced_step_state>: New field.
2977         * infrun.h (struct displaced_step_state): Move here from
2978         infrun.c.  Initialize fields, add constructor.
2979         <inf>: Remove field.
2980         <reset>: New method.
2981         * infrun.c (struct displaced_step_inferior_state): Move to
2982         infrun.h.
2983         (displaced_step_inferior_states): Remove.
2984         (get_displaced_stepping_state): Adust.
2985         (displaced_step_in_progress_any_inferior): Adjust.
2986         (displaced_step_in_progress_thread): Adjust.
2987         (displaced_step_in_progress): Adjust.
2988         (add_displaced_stepping_state): Remove.
2989         (get_displaced_step_closure_by_addr): Adjust.
2990         (remove_displaced_stepping_state): Remove.
2991         (infrun_inferior_exit): Call displaced_step_state.reset.
2992         (use_displaced_stepping): Don't check for NULL.
2993         (displaced_step_prepare_throw): Call
2994         get_displaced_stepping_state.
2995         (displaced_step_fixup): Don't check for NULL.
2996         (prepare_for_detach): Don't check for NULL.
2997
2998 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2999
3000         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3001          in case of call that did not complete.
3002
3003 2019-01-02  Andrey Utkin  <autkin@undo.io>
3004
3005         * symfile.c (find_separate_debug_file): Fix search of debug files for
3006         remote debuggee.
3007
3008 2019-01-02  Tom Tromey  <tom@tromey.com>
3009
3010         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3011         indentation.
3012         * python/py-frame.c (frapy_older): Remove cast.
3013         (frapy_newer): Likewise.
3014         * python/py-breakpoint.c (local_setattro): Remove cast.
3015         * python/py-arch.c (archpy_name): Remove local variable.
3016         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3017
3018 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3019
3020         * unittests/basic_string_view/element_access/char/empty.cc:
3021         Fix year range in copyright header.
3022
3023 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3024
3025         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3026         Delete.
3027         <operator==>: Update with for removed field.
3028         <hash>: Likewise.
3029         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3030         <isa_features>: ...this.
3031         <abi_features>: New field.
3032         (riscv_isa_flen): Update comment.
3033         (riscv_abi_xlen): New declaration.
3034         (riscv_abi_flen): New declaration.
3035         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3036         isa_features.
3037         (riscv_abi_xlen): New function.
3038         (riscv_isa_flen): Update to get answer from isa_features.
3039         (riscv_abi_flen): New function.
3040         (riscv_has_fp_abi): Update to get answer from abi_features.
3041         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3042         xlen and flen.
3043         (riscv_call_info) <xlen, flen>: Update comment.
3044         (riscv_call_arg_struct): Remove invalid assertions
3045         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3046         is removed.
3047         (riscv_gdbarch_init): Gather isa features and abi features
3048         separately, ensure both match on the gdbarch when reusing an old
3049         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3050         a target with 64-bit float hardware.
3051
3052 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3053
3054         * source.c (search_command_helper): Stop reverse search
3055         when line 1 has been searched.
3056
3057 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3058
3059         * record-full.c (record_full_base_target::close): Rewrite
3060         record_full_core_buf_list free logic.
3061
3062 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3063
3064         * break-catch-syscall.c (print_one_catch_syscall): xfree
3065         the last text.
3066
3067 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3068
3069         * top.c (print_gdb_version): Update Copyright year in version
3070         message.
3071
3072 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3073
3074         Update copyright year range in all GDB files.
3075
3076 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3077
3078         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3079
3080 For older changes see ChangeLog-2018.
3081 \f
3082 Local Variables:
3083 mode: change-log
3084 left-margin: 8
3085 fill-column: 74
3086 version-control: never
3087 coding: utf-8
3088 End:
3089