gdb/ChangeLog

   1 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
   2
   3         PR build/24886
   4         * configure.ac: Drop enable-libmcheck support.
   5         * configure, config.in: Rebuild.
   6         * libmcheck.m4: Remove.
   7         * acinclude.m4: Don't include it.
   8         * Makefile.in: Don't distribute it.
   9         * top.c (print_gdb_configuration): Don't mention it.
  10
  11 2019-08-06  Tom Tromey  <tom@tromey.com>
  12
  13         * utils.c (set_output_style): Sometimes pass stream to
  14         emit_style_escape.
  15         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
  16         * record-btrace.c (btrace_insn_history): Update.
  17         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
  18         method.
  19         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
  20         Update initializers.
  21         <m_uiout>: New field.
  22         <m_di>: Move lower.
  23         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  24         Remove "uiout" parameter.
  25         (dump_insns): Update.
  26         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
  27         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
  28
  29 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
  30
  31         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
  32         (error_in_psymtab_expansion): Likewise.
  33         (lookup_symbol_via_quick_fns): Likewise.
  34         (basic_lookup_transparent_type_quick): Likewise.
  35         (basic_lookup_transparent_type_1): Likewise.
  36
  37 2019-08-06  Tom Tromey  <tromey@adacore.com>
  38
  39         * source.c (last_source_error): Now bool.
  40         (print_source_lines_base): Make "noprint" bool.  Only open
  41         source file when last_source_visited changes.
  42
  43 2019-08-06  Tom Tromey  <tromey@adacore.com>
  44
  45         * annotate.c (annotate_source_line): Use g_source_cache.
  46         * source-cache.c (source_cache::get_plain_source_lines): Change
  47         parameters.  Populate m_offset_cache.
  48         (source_cache::ensure): New method.
  49         (source_cache::get_line_charpos): New method.
  50         (extract_lines): Move lower.  Change parameters.
  51         (source_cache::get_source_lines): Move lower.
  52         * source-cache.h (class source_cache): Update comment.
  53         <get_line_charpos>: New method.
  54         <get_source_lines>: Update comment.
  55         <clear>: Clear m_offset_cache.
  56         <get_plain_source_lines>: Change parameters.
  57         <ensure>: New method
  58         <m_offset_cache>: New member.
  59         * source.c (forget_cached_source_info_for_objfile): Update.
  60         (info_source_command): Use g_source_cache.
  61         (find_source_lines, open_source_file_with_line_charpos): Remove.
  62         (print_source_lines_base, search_command_helper): Use g_source_cache.
  63         * source.h (open_source_file_with_line_charpos): Don't declare.
  64         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
  65         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
  66         Use g_source_cache.
  67
  68 2019-08-06  Tom Tromey  <tromey@adacore.com>
  69
  70         * source-cache.c (source_cache::get_plain_source_lines):
  71         Remove "first_line" and "last_line" parameters.
  72         (source_cache::get_source_lines): Cache plain text.
  73         * source-cache.h (class source_cache)
  74         <get_plain_source_lines>: Update.
  75
  76 2019-08-06  Tom Tromey  <tromey@adacore.com>
  77
  78         * source-cache.c (extract_lines): No longer a method.
  79         Changed type of parameter.  Include final newline.
  80         (selftests::extract_lines_test): New function.
  81         (_initialize_source_cache): Likewise.
  82         * source-cache.h (class source_cache)
  83         <extract_lines>: Don't declare.
  84
  85 2019-08-06  Tom Tromey  <tromey@adacore.com>
  86
  87         * breakpoint.c (init_breakpoint_sal): Update.
  88         (breakpoint): Update.
  89         * breakpoint.h (struct breakpoint) <filter>: Now a
  90         unique_xmalloc_ptr.
  91
  92 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
  93
  94         * NEWS: Mention dictionary access on blocks.
  95         * python/py-block.c (blpy_getitem): New function.
  96         (block_object_as_mapping): New struct.
  97         (block_object_type): Use new struct for tp_as_mapping field.
  98
  99 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 100
 101         * objfiles.h (objfile): Add a comment describing partial symbols.
 102
 103 2019-08-05  Tom Tromey  <tromey@adacore.com>
 104
 105         * compile/compile.c (_initialize_compile): Use _(), not N_().
 106         * thread.c (_initialize_thread): Use _(), not N_().
 107         * stack.c (_initialize_stack): Use _(), not N_().
 108         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 109
 110 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 111
 112         * dwarf2read.c (struct dw2_symtab_iterator):
 113         <want_specific_block>: Remove.
 114         <block_index>: Change type to gdb::optional.
 115         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 116         change type of BLOCK_INDEX parameter to gdb::optional.
 117         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 118         (dw2_lookup_symbol): Don't pass argument for
 119         WANT_SPECIFIC_BLOCK.
 120         (dw2_expand_symtabs_for_function): Don't pass argument for
 121         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 122         (class dw2_debug_names_iterator)
 123         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 124         parameter, change BLOCK_INDEX type to gdb::optional.
 125         <m_want_specific_block>: Remove.
 126         <m_block_index>: Change type to gdb::optional.
 127         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 128         gdb::optional.  Re-write in function of gdb::optional.
 129         (dw2_debug_names_lookup_symbol): Don't pass argument for
 130         WANT_SPECIFIC_BLOCK.
 131         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 132         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 133         BLOCK_INDEX.
 134
 135 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 136
 137         * NEWS: Mention changes to "info sources" command.
 138
 139 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 140
 141         * symtab.c (filename_partial_match_opts): New struct type.
 142         (struct output_source_filename_data): New members
 143         regexp, c_regexp, partial_match.
 144         (output_source_filename): Use new members to decide to print file.
 145         (info_sources_option_defs): New variable.
 146         (make_info_sources_options_def_group, print_info_sources_header,
 147         info_sources_command_completer):
 148         New functions.
 149         (info_sources_command): Read new optional arguments.
 150         (_initialize_symtab): Update info sources help.
 151
 152 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 153
 154         * ada-lang.c (exception_support_info_v0): Renamed from...
 155         (default_exception_support_info): ... this.  Create new
 156         definition for v1.
 157         (ada_has_this_exception_support): Look up catch_handlers_sym.
 158         (ada_exception_support_info_sniffer): Try v0 after default.
 159
 160 2019-08-01  Tom Tromey  <tromey@adacore.com>
 161
 162         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 163         gdbarch.h.
 164
 165 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 166
 167         * s12z-tdep.c: Fix include path for s12z-opc.h.
 168
 169 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 170
 171         * NEWS: Require GNU make 3.82.
 172
 173 2019-07-16  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 176         declare.
 177
 178 2019-07-30  Tom Tromey  <tromey@adacore.com>
 179
 180         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 181
 182 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 183
 184         * printcmd.c (print_address_symbolic): Print negative offsets.
 185         (build_address_symbolic): Force signed arithmetic when computing
 186         offset.
 187
 188 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 189
 190         PR/24474: Add a function to lookup static variables.
 191         * NEWS: Mention this new function.
 192         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 193         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 194         * python/python.c (python_GdbMethods): Add new function.
 195
 196 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 197
 198         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 199         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 200         (objfpy_lookup_static_symbol): New function.
 201         (objfile_object_methods): Add new functions.
 202
 203 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 204
 205         * NEWS: Mention 'set|show print frame-info'.  Mention new
 206         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 207         backtrace argument.  Mention that python frame filtering code
 208         is now consistent with what 'backtrace' command prints.
 209
 210 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 211
 212         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 213         comments.
 214         (print_frame_info_auto, print_frame_info_source_line,
 215         print_frame_info_location, print_frame_info_source_and_location,
 216         print_frame_info_location_and_address, print_frame_info_short_location):
 217         New declarations.
 218         (struct frame_print_options): New member print_frame_info.
 219         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 220         * stack.h (get_user_print_what_frame_info): New declaration.
 221         (frame_show_address): New declaration.
 222         * stack.c (print_frame_arguments_choices): New value 'presence'.
 223         (print_frame_info_auto, print_frame_info_source_line,
 224         print_frame_info_location, print_frame_info_source_and_location,
 225         print_frame_info_location_and_address, print_frame_info_short_location,
 226         print_frame_info_choices, print_frame_info_print_what): New definitions.
 227         (print_frame_args): Only print dots for args if print frame-arguments
 228         is 'presence'.
 229         (frame_print_option_defs): New element for "frame-info".
 230         (get_user_print_what_frame_info): New function.
 231         (frame_show_address): Make non static.  Move comment to stack.h.
 232         (print_frame_info_to_print_what): New function.
 233         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 234         to decide what to print.
 235         (backtrace_command_1): Handle the new print_frame_arguments_presence
 236         value.
 237         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 238         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 239         (py_print_frame): In non-mi mode, use LOCATION as default for
 240         print_what, similarly to frame information printed directly by
 241         backtrace command. Handle frame-info user option in non MI mode.
 242
 243 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 244
 245         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 246         Add case for debugging 32-bit target on 64-bit host.  Revise
 247         comment.
 248
 249 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 250
 251         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 252         instead of find_function_entry_range_from_pc.
 253
 254 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 255
 256         * stack.c (find_frame_funname): Remove code which preferred
 257         minsym over symtab sym in "certain pathological cases".
 258
 259         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 260         parameter.  Change type of "do_demangle" to bool.
 261         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 262         Pass suitable "prefer_sym_over_minsym" flag to
 263         build_address_symbolic().  Don't output "+" for negative offsets.
 264         * printcmd.c (print_address_symbolic): Update invocation of
 265         build_address_symbolic to include a "prefer_sym_over_minsym"
 266         flag.
 267         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 268         Restrict cases in which use of minimal symbol is preferred to that
 269         of a found symbol.  Update comments.
 270
 271         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 272         for entry pc when entry pc is out of range for that FDE.
 273
 274 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 275
 276         PR gdb/24839:
 277         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 278         type.
 279
 280 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 281
 282         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 283         this function's Python signature.
 284
 285
 286 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 287
 288         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 289         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 290         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 291         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 292         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 293
 294
 295 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 296
 297         * h8300-tdep.c (h8300_register_name_common): New.
 298         h8300_register_name): Use h8300_register_name_common.
 299         (h8300s_register_name): Likewise.
 300         (h8300sx_register_name): Likewise.
 301         (h8300h_register_nam): New.
 302         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 303
 304
 305 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 306
 307         * arm-tdep.c (arm_skip_cmse_entry): New function.
 308         (arm_is_sgstubs_section): New function.
 309         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 310
 311 2019-07-22  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 314         Don't self-assign.
 315
 316 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 317
 318         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 319         type_print.
 320
 321 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 322
 323         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 324         so that GDB doesn't match any msymbols when searching in the
 325         TYPES_DOMAIN.
 326         (print_symbol_info): Print using typedef_print or type_print based
 327         on the type of the symbol.  Add updated FIXME comment moved from...
 328         (_initialize_symtab): ... move and update FIXME comment to above.
 329
 330 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 331
 332         * NEWS: Mention adding -q option to "info types".
 333         * symtab.c (struct info_types_options): New struct.
 334         (info_types_options_defs): New variable.
 335         (make_info_types_options_def_group): New function.
 336         (info_types_command): Use gdb::option framework to parse options.
 337         (info_types_command_completer): New function.
 338         (_initialize_symtab): Extend the help text on "info types" and
 339         register command completer.
 340
 341 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 342
 343         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 344         (lookup_symbol_in_objfile): Change int to block_enum and add a
 345         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 346
 347 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 348
 349         * MAINTAINERS (Write After Approval): Add self.
 350
 351 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 352
 353         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 354         instruction to the dummy code region.
 355
 356 2019-07-19  Tom Tromey  <tromey@adacore.com>
 357
 358         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 359         (ARGSUSED, PARAMS, __func__): Remove rules.
 360
 361 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 362
 363         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 364         * features/arm/arm-with-iwmmxt.c: Remove.
 365         * features/arm/arm-with-iwmmxt.xml: Remove.
 366         * features/arm/arm-with-m-fpa-layout.c: Remove.
 367         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 368         * features/arm/arm-with-m-vfp-d16.c: Remove.
 369         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 370         * features/arm/arm-with-m.c: Remove.
 371         * features/arm/arm-with-m.xml: Remove.
 372         * features/arm/arm-with-neon.c: Remove.
 373         * features/arm/arm-with-neon.xml: Remove.
 374         * features/arm/arm-with-vfpv2.c: Remove.
 375         * features/arm/arm-with-vfpv2.xml: Remove.
 376         * features/arm/arm-with-vfpv3.c: Remove.
 377         * features/arm/arm-with-vfpv3.xml: Remove.
 378
 379 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 380
 381         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 382
 383 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 384
 385         * arch/aarch32.c (aarch32_create_target_description): Create
 386         target descriptions using features.
 387         * arch/arm.c (arm_create_target_description)
 388         (arm_create_mprofile_target_description): Likewise.
 389         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 390
 391 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 392
 393         * Makefile.in: Add new files.
 394         * aarch32-tdep.c: New file.
 395         * aarch32-tdep.h: New file.
 396         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 397         Call aarch32_read_description.
 398         * arch/aarch32.c: New file.
 399         * arch/aarch32.h: New file.
 400         * arch/arm.c (arm_create_target_description)
 401         (arm_create_mprofile_target_description): New function.
 402         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 403         (arm_create_target_description)
 404         (arm_create_mprofile_target_description): New declaration.
 405         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 406         read_description functions.
 407         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 408         Likewise.
 409         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 410         * arm-tdep.c (tdesc_arm_list): New variable.
 411         (arm_register_g_packet_guesses): Call create description functions.
 412         (arm_read_description) (arm_read_mprofile_description): New
 413         function.
 414         * arm-tdep.h (arm_read_description)
 415         (arm_read_mprofile_description): Add declaration.
 416         * configure.tgt: Add new files.
 417
 418 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 419
 420         * top.c (new_ui_command): Open specified terminal just once.
 421
 422 2019-07-18  Tom Tromey  <tromey@adacore.com>
 423
 424         * symtab.c (main_name): Constify return type.
 425         * symfile.c (set_initial_language): Update.
 426         * symtab.h (main_name): Constify return type.
 427
 428 2019-07-17  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-winsource.c (tui_update_source_window)
 431         (tui_update_source_window_as_is)
 432         (tui_update_source_windows_with_line): Remove return.
 433         * tui/tui-disasm.c (tui_show_disassem)
 434         (tui_show_disassem_and_update_source): Remove return.
 435         * tui/tui.c (tui_reset): Remove return.
 436         * tui/tui-wingeneral.c
 437         (tui_check_and_display_highlight_if_needed): Remove return.
 438
 439 2019-07-17  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 442
 443 2019-07-17  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-winsource.h (struct tui_exec_info_window)
 446         (struct tui_source_window_base): Move from tui-data.h.
 447         * tui/tui-winsource.c: Move many method definitions from
 448         elsewhere.  Remove "structuring" comments.
 449         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 450         (tui_source_window_base::refresh_window): Move to
 451         tui-winsource.c.
 452         * tui/tui-win.c (tui_source_window_base::refresh_all)
 453         (tui_source_window_base::update_tab_width)
 454         (tui_source_window_base::set_new_height)
 455         (tui_source_window_base::do_make_visible_with_new_height): Move to
 456         tui-winsource.c.
 457         * tui/tui-source.h: Update.
 458         * tui/tui-source.c (tui_source_window_base::reset): Move to
 459         tui-winsource.c.
 460         * tui/tui-disasm.h: Update.
 461         * tui/tui-data.h (struct tui_exec_info_window): Move to
 462         tui-winsource.h.
 463         (struct tui_source_window_base): Likewise.
 464         * tui/tui-data.c (tui_source_window_base::clear_detail)
 465         (tui_source_window_base, ~tui_source_window_base): Move to
 466         tui-winsource.c.
 467
 468 2019-07-17  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-win.c (tui_resize_all)
 471         (tui_source_window_base::update_tab_width)
 472         (tui_adjust_win_heights): Update.
 473         (tui_win_info::make_invisible_and_set_new_height): Rename from
 474         make_invisible_and_set_new_height.
 475         * tui/tui-data.h (struct tui_win_info)
 476         <make_invisible_and_set_new_height>: New method.
 477
 478 2019-07-17  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui.c: Update.
 481         * tui/tui-source.h (struct tui_source_window): Move from
 482         tui-data.h.
 483         * tui/tui-layout.c: Update.
 484         * tui/tui-disasm.c: Update.
 485         * tui/tui-data.h (struct tui_source_window): Move to
 486         tui-source.h.
 487
 488 2019-07-17  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 491         tui-data.h.
 492         * tui/tui-data.h (struct tui_disasm_window): Move to
 493         tui-disasm.h.
 494
 495 2019-07-17  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-regs.h (struct tui_data_item_window): Move from
 498         tui-data.h.
 499         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 500         * tui/tui-data.h (struct tui_data_item_window): Move to
 501         tui-regs.h.
 502         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 503
 504 2019-07-17  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui.c: Update.
 507         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 508         (tui_cmd_window::max_height): Move to tui-command.c.
 509         * tui/tui-layout.c: Update.
 510         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 511         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 512         tui-command.c.
 513         * tui/tui-command.h (struct tui_cmd_window): Move from
 514         tui-data.h.
 515         * tui/tui-command.c: Remove "structuring" comments.
 516         (tui_cmd_window::clear_detail)
 517         (tui_cmd_window::do_make_visible_with_new_height)
 518         (tui_cmd_window::max_height): Move from elsewhere.
 519
 520 2019-07-17  Tom Tromey  <tom@tromey.com>
 521
 522         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 523         Now static.
 524         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 525         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 526
 527 2019-07-17  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui.c: Update.
 530         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 531         tui-regs.c.
 532         * tui/tui-windata.h: Remove file.
 533         * tui/tui-windata.c: Remove file.
 534         * tui/tui-win.c (tui_data_window::set_new_height)
 535         (tui_data_window::do_make_visible_with_new_height): Move to
 536         tui-regs.c.
 537         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 538         * tui/tui-regs.c: Remove "structuring" comments.
 539         (tui_data_window::first_data_item_displayed)
 540         (tui_data_window::delete_data_content_windows)
 541         (tui_data_window::erase_data_content)
 542         (tui_data_window::display_all_data)
 543         (tui_data_window::refresh_all)
 544         (tui_data_window::do_scroll_vertical)
 545         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 546         (tui_data_window::do_make_visible_with_new_height)
 547         (tui_data_window::refresh_window): Move from elsewhere.
 548         (_initialize_tui_regs): Move to end of file.
 549         * tui/tui-layout.c: Update.
 550         * tui/tui-hooks.c: Update.
 551         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 552         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 553         tui-regs.c.
 554         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 555
 556 2019-07-17  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 559         seen.
 560
 561 2019-07-17  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-win.c (tui_source_window_base::set_new_height)
 564         (tui_source_window_base::do_make_visible_with_new_height): Use
 565         m_has_locator field directly.
 566         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 567         method.
 568         (struct tui_source_window_base) <has_locator>: Likewise.
 569
 570 2019-07-17  Tom Tromey  <tom@tromey.com>
 571
 572         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 573         Don't declare.
 574         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 575         Remove.
 576         * tui/tui-win.c (tui_source_window_base::set_new_height)
 577         (tui_source_window_base::set_new_height)
 578         (make_invisible_and_set_new_height)
 579         (tui_source_window_base::do_make_visible_with_new_height)
 580         (tui_source_window_base::do_make_visible_with_new_height):
 581         Update.
 582         * tui/tui-layout.c (show_source_disasm_command, show_data)
 583         (show_source_or_disasm_and_command): Update.
 584         * tui/tui-layout.c (show_layout): Update.
 585
 586 2019-07-17  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-layout.c (make_data_window): Remove.
 589         (show_data): Unify creation and re-initialization cases.
 590
 591 2019-07-17  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-layout.c (make_source_window, make_disasm_window):
 594         Remove.
 595         (show_data): Unify creation and re-initialization cases.
 596
 597 2019-07-17  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-layout.c (make_command_window): Remove.
 600         (show_source_disasm_command, show_source_or_disasm_and_command):
 601         Unify creation and re-initialization cases.
 602
 603 2019-07-17  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 606         creation and re-initialization cases.
 607
 608 2019-07-17  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-regs.c (tui_get_register): Return void.
 611
 612 2019-07-17  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 615         Simplify.
 616
 617 2019-07-17  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 620         resetting.
 621
 622 2019-07-17  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 625         * tui/tui-regs.c (tui_reg_layout): New function.
 626         (tui_show_registers, tui_reg_command): Use it.
 627         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 628         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 629         parameters.
 630         (tui_layout_command): Remove.
 631
 632 2019-07-17  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-layout.h (tui/tui-layout): Return void.
 635         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 636
 637 2019-07-17  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-layout.c (show_source_disasm_command, show_data):
 640         Update.
 641         (reset_locator): Remove.
 642         (show_source_or_disasm_and_command): Update.
 643
 644 2019-07-17  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-source.c (tui_source_window_base::reset): Remove
 647         win_type parameter.
 648         * tui/tui-layout.c (make_command_window, make_source_window)
 649         (make_disasm_window, make_data_window)
 650         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 651         (reset_locator, show_source_or_disasm_and_command): Update.
 652         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 653         win_type parameter.
 654         (struct tui_source_window_base) <reset>: Likewise.
 655
 656 2019-07-17  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-layout.c (show_source_disasm_command): Use
 659         reset_locator.
 660         (reset_locator): New function.
 661         (init_and_make_win): Remove.
 662         (show_source_or_disasm_and_command): Use reset_locator.
 663
 664 2019-07-17  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 667         condition.
 668         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 669         Remove condition.
 670         * tui/tui-source.c (tui_source_window_base::reset): New method.
 671         * tui/tui-layout.c (make_command_window): Don't call
 672         init_and_make_win.
 673         (make_source_window, make_disasm_window): Don't call
 674         make_source_or_disasm_window.
 675         (make_data_window): Don't call init_and_make_win.  Change calling
 676         convention.
 677         (show_source_disasm_command, show_data): Simplify.
 678         (make_source_or_disasm_window): Remove.
 679         (show_source_or_disasm_and_command): Simplify.
 680         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 681         (struct tui_source_window_base) <reset>: Likewise.
 682         <execution_info>: Remove initializer.
 683         * tui/tui-data.c (tui_source_window_base): Initialize
 684         execution_info.
 685
 686 2019-07-17  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 689         variable.
 690
 691 2019-07-17  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui.c (tui_rl_other_window): Update.
 694         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 695         superclass method first.  Always iterate over regs_content.
 696         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 697         method.
 698         * tui/tui-win.c (tui_set_focus_command): Update.
 699
 700 2019-07-17  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui-win.c (tui_set_focus_command): Rename from
 703         tui_set_focus.  Call tui_enable.
 704         (tui_set_focus_command): Remove.
 705
 706 2019-07-17  Tom Tromey  <tom@tromey.com>
 707
 708         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 709         refresh_window.
 710         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 711         touchwin.
 712         (tui_data_window::refresh_window): Call refresh_window on data
 713         items.  Always call superclass refresh_window.
 714         (tui_win_info::refresh): Remove.
 715         (tui_source_window_base::refresh_window): Update.
 716         (tui_refresh_all): Update.
 717         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 718         refresh_window.
 719         (show_source_or_disasm_and_command): Likewise.
 720         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 721         (struct tui_source_window_base) <refresh>: Likewise.
 722
 723 2019-07-17  Tom Tromey  <tom@tromey.com>
 724
 725         * tui/tui-winsource.c (tui_clear_source_content)
 726         (tui_show_source_content): Update.
 727         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 728         whether content is empty.
 729         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 730         Remove.
 731
 732 2019-07-17  Tom Tromey  <tom@tromey.com>
 733
 734         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 735         window's contents.
 736         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 737         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 738
 739 2019-07-17  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 742         (struct tui_data_item_window): Update.
 743
 744 2019-07-17  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 747         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 748         defines.
 749
 750 2019-07-17  Tom Tromey  <tom@tromey.com>
 751
 752         * tui/tui-winsource.h (tui_erase_source_content)
 753         (tui_clear_source_content): Remove "display_prompt" parameter.
 754         * tui/tui-winsource.c (tui_update_source_window_as_is)
 755         (tui_update_source_windows_with_addr): Update.
 756         (tui_clear_source_content): Remove "display_prompt" parameter.
 757         (tui_erase_source_content): Likewise.  Simplify.
 758         (tui_show_source_content): Update.
 759         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 760         * tui/tui-stack.c (tui_show_frame_info): Update.
 761         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 762         Remove defines.
 763
 764 2019-07-17  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 767         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 768         parameter.
 769         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 770         parameter.
 771
 772 2019-07-17  Tom Tromey  <tom@tromey.com>
 773
 774         * tui/tui-winsource.c (tui_clear_source_content)
 775         (tui_show_source_content, tui_show_exec_info_content)
 776         (tui_clear_exec_info_content): Update.
 777         * tui/tui-stack.c (tui_show_locator_content): Update.
 778         (tui_show_frame_info): Update.
 779         * tui/tui-source.h (tui_source_window): Don't declare.
 780         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 781         from tui_source_is_displayed.
 782         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 783         Remove field.
 784         (struct tui_source_window_base) <content_in_use>: New field.  Now
 785         bool.
 786         (struct tui_source_window) <showing_source_p>: New method.
 787         (TUI_SRC_WIN): Change cast.
 788         * tui/tui-data.c (tui_initialize_static_data): Update.
 789
 790 2019-07-17  Tom Tromey  <tom@tromey.com>
 791
 792         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 793         location_matches_p.
 794         * tui/tui-source.c (tui_source_window::location_matches_p): New
 795         method.
 796         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 797         method.
 798         * tui/tui-data.h (struct tui_source_window_base)
 799         <location_matches_p>: New method.
 800         (struct tui_source_window, struct tui_disasm_window)
 801         <location_matches_p>: Likewise.
 802
 803 2019-07-17  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-win.c (tui_set_win_height_command): Rename from
 806         tui_set_win_height.
 807         (tui_set_win_height_command): Remove.
 808
 809 2019-07-17  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-source.c (tui_source_window): New constructor.  Add
 812         observer.
 813         (~tui_source_window): New destructor.
 814         (tui_source_window::style_changed): New method.
 815         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 816         (tui_attach_detach_observers): Update.
 817         * tui/tui-data.h (struct tui_source_window): Make constructor not
 818         inline.  Add destructor.
 819         (struct tui_source_window) <style_changed>: New method.
 820         <m_observable>: New member.
 821
 822 2019-07-17  Tom Tromey  <tom@tromey.com>
 823
 824         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 825         * tui/tui-win.c (tui_resize_all): Fix typo.
 826
 827 2019-07-17  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 830         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 831         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 832         * tui/tui-win.c (window_name_completer): Use foreach.
 833         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 834         (update_tab_width): Likewise.
 835         * tui/tui-layout.c (show_layout): Update.
 836         * tui/tui-data.h (class tui_window_iterator): New.
 837         (struct all_tui_windows): New.
 838         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 839
 840 2019-07-17  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 843         parameter.  Don't reference globals.
 844         (tui_reg_command): Update.
 845
 846 2019-07-17  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-regs.c (tui_show_registers): Simplify.
 849
 850 2019-07-17  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-regs.c (tui_show_registers): Update.
 853         (tui_show_register_group): Add win_info parameter.
 854
 855 2019-07-17  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 858         Rename from tui_display_reg_element_at_line.
 859         (tui_data_window::display_registers_from_line): Update.
 860         * tui/tui-data.h (struct tui_data_window)
 861         <display_reg_element_at_line>: New method.
 862
 863 2019-07-17  Tom Tromey  <tom@tromey.com>
 864
 865         * tui/tui-regs.h (tui_display_registers_from)
 866         (tui_display_registers_from_line): Don't declare.
 867         * tui/tui-windata.c (tui_data_window::display_all_data)
 868         (tui_data_window::refresh_all)
 869         (tui_data_window::do_scroll_vertical): Update.
 870         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 871         from tui_display_registers_from.
 872         (tui_display_reg_element_at_line): Update.
 873         (tui_data_window::display_registers_from_line): Rename from
 874         tui_display_registers_from_line.
 875         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 876         display_registers_from_line>: New methods.
 877
 878 2019-07-17  Tom Tromey  <tom@tromey.com>
 879
 880         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 881         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 882         from tui_erase_data_content.
 883         (tui_data_window::display_all_data)
 884         (tui_data_window::refresh_all)
 885         (tui_data_window::do_scroll_vertical): Update.
 886         * tui/tui-regs.c (tui_show_registers): Update.
 887         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 888         New method.
 889
 890 2019-07-17  Tom Tromey  <tom@tromey.com>
 891
 892         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 893         declare.
 894         * tui/tui-windata.c
 895         (tui_data_window::delete_data_content_windows): Rename from
 896         tui_delete_data_content_windows.
 897         (tui_data_window::display_all_data)
 898         (tui_data_window::do_scroll_vertical): Update.
 899         * tui/tui-data.h (struct tui_data_window)
 900         <delete_data_content_windows>: New method.
 901
 902 2019-07-17  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 905         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 906
 907 2019-07-17  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 910         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 911         from tui_display_all_data.
 912         * tui/tui-win.c
 913         (tui_data_window::do_make_visible_with_new_height): Update.
 914         * tui/tui-regs.c (tui_show_registers): Update.
 915         * tui/tui-layout.c (tui_set_layout): Update.
 916         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 917         method.
 918
 919 2019-07-17  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 922         * tui/tui-windata.c (tui_display_data_from): Remove.
 923         (tui_data_window::refresh_all): Update.
 924
 925 2019-07-17  Tom Tromey  <tom@tromey.com>
 926
 927         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 928         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 929         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 930         tui_display_registers_from_line.
 931         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 932         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 933         "force_display" parameter.
 934
 935 2019-07-17  Tom Tromey  <tom@tromey.com>
 936
 937         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 938         declare.
 939         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 940         Rename from tui_first_reg_element_no_inline.
 941         (tui_display_reg_element_at_line)
 942         (tui_display_registers_from_line): Update.
 943         * tui/tui-data.h (struct tui_data_window)
 944         <first_reg_element_no_inline>: New method.
 945
 946 2019-07-17  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-windata.c (tui_display_data_from)
 949         (tui_data_window::do_scroll_vertical): Update.
 950         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 951         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 952         Rename from tui_line_from_reg_element_no.
 953         (tui_display_registers_from_line): Update.
 954         * tui/tui-data.h (struct tui_data_window)
 955         <line_from_reg_element_no>: New method.
 956
 957 2019-07-17  Tom Tromey  <tom@tromey.com>
 958
 959         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 960         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 961         tui_last_regs_line_no.
 962         (tui_display_reg_element_at_line)
 963         (tui_display_registers_from_line): Update.
 964         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 965         method.
 966
 967 2019-07-17  Tom Tromey  <tom@tromey.com>
 968
 969         PR tui/24722:
 970         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 971         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 972         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 973         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 974         (tui_update_breakpoint_info): Likewise.
 975         * tui/tui-hooks.c (tui_event_create_breakpoint)
 976         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 977         Update.
 978
 979 2019-07-17  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 982
 983 2019-07-17  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-winsource.c (tui_update_source_window_as_is)
 986         (tui_update_source_windows_with_addr): Update.
 987         * tui/tui-source.h (tui_set_source_content)
 988         (tui_show_symtab_source): Add "win_info" parameter.
 989         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 990         parameter.
 991         (tui_show_symtab_source): Likewise.
 992
 993 2019-07-17  Tom Tromey  <tom@tromey.com>
 994
 995         * tui/tui-wingeneral.c
 996         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 997
 998 2019-07-17  Tom Tromey  <tom@tromey.com>
 999
1000         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1001         (struct tui_cmd_window) <can_scroll>: New method.
1002         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1003         method.
1004
1005 2019-07-17  Tom Tromey  <tromey@adacore.com>
1006
1007         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1008         do_field_signed>: Rename.  Change type of "value".
1009         * ui-out.c (ui_out::field_signed): Rename from field_int.
1010         Change type of "value".
1011         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1012         type of "value".
1013         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1014         do_field_int.  Change type of "value".
1015         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1016         do_field_int.  Change type of "value".
1017         * tracepoint.c (trace_status_mi, tfind_1)
1018         (print_one_static_tracepoint_marker): Update.
1019         * thread.c (print_thread_info_1, print_selected_thread_frame):
1020         Update.
1021         * stack.c (print_frame, print_frame_info): Update.
1022         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1023         Update.
1024         * source.c (print_source_lines_base): Update.
1025         * skip.c (info_skip_command): Update.
1026         * record-btrace.c (btrace_ui_out_decode_error)
1027         (btrace_call_history_src_line): Update.
1028         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1029         Update.
1030         * progspace.c (print_program_space): Update.
1031         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1032         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1033         do_field_int.  Change type of "value".
1034         * mi/mi-out.c (mi_ui_out::do_table_begin)
1035         (mi_ui_out::do_table_header): Update.
1036         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1037         type of "value".
1038         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1039         (mi_cmd_data_list_changed_registers, output_register)
1040         (mi_cmd_data_read_memory, mi_load_progress)
1041         (mi_cmd_trace_frame_collected): Update.
1042         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1043         Update.
1044         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1045         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1046         (mi_cmd_var_list_children, varobj_update_one): Update.
1047         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1048         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1049         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1050         * inferior.c (print_inferior): Update.
1051         * gdb_bfd.c (print_one_bfd): Update.
1052         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1053         Update.
1054         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1055         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1056         do_field_int.  Change type of "value".
1057         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1058         do_field_int.  Change type of "value".
1059         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1060         (print_one_breakpoint_location, print_it_catch_fork)
1061         (print_one_catch_fork, print_it_catch_vfork)
1062         (print_one_catch_vfork, print_it_catch_solib)
1063         (print_it_catch_exec, print_it_ranged_breakpoint)
1064         (print_mention_watchpoint, print_mention_masked_watchpoint)
1065         (bkpt_print_it, update_static_tracepoint): Update.
1066         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1067         * break-catch-syscall.c (print_it_catch_syscall): Update.
1068         * ada-tasks.c (print_ada_task_info): Update.
1069         * ada-lang.c (print_it_exception, print_mention_exception):
1070         Update.
1071
1072 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1073
1074         PR breakpoints/24541
1075         * gdbarch.c: Regenerate.
1076         * gdbarch.h: Regenerate.
1077         * gdbarch.sh: Adjust return type and parameter types for
1078         'stap_adjust_register'.
1079         (i386_stap_adjust_register): Adjust signature and return new
1080         register name.
1081         * stap-probe.c (stap_parse_register_operand): Adjust use of
1082         'gdbarch_stap_adjust_register'.
1083
1084 2019-07-17  Tom Tromey  <tromey@adacore.com>
1085
1086         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1087         declare VEC.
1088         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1089         std::vector.
1090         (struct s390_process_info): Add initializers.
1091         (s390_add_process): Use new.
1092         (s390_linux_nat_target::low_forget_process): Use delete.
1093         (s390_linux_nat_target::low_new_fork)
1094         (s390_linux_nat_target::stopped_by_watchpoint)
1095         (s390_linux_nat_target::low_prepare_to_resume)
1096         (s390_linux_nat_target::insert_watchpoint)
1097         (s390_linux_nat_target::insert_hw_breakpoint)
1098         (s390_linux_nat_target::remove_watchpoint)
1099         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1100
1101 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1102
1103         * aarch64-fbsd-nat.c: Include regcache.h.
1104         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1105         argument.
1106         (aarch64_fbsd_nat_target::fetch_registers)
1107         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1108         variable.
1109         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1110
1111 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1112
1113         * fbsd-nat.c: Include gdbarch.h.
1114
1115 2019-07-15  Tom Tromey  <tromey@adacore.com>
1116
1117         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1118
1119 2019-07-15  Tom Tromey  <tromey@adacore.com>
1120
1121         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1122         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1123         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1124         * cli-out.c (cli_ui_out::do_field_int): New method.
1125         * ui-out.c (ui_out::field_unsigned): New method.
1126         * symfile.c (generic_load): Use field_unsigned.
1127         (print_transfer_performance): Likewise.
1128         * record-btrace.c (ui_out_field_uint): Remove.
1129         (btrace_call_history_insn_range, btrace_call_history): Use
1130         field_unsigned.
1131         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1132         field_unsigned.
1133         * ui-out.h (class ui_out) <field_unsigned>: New method.
1134         <do_field_unsigned>: Likewise.
1135
1136 2019-07-15  Tom Tromey  <tromey@adacore.com>
1137
1138         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1139         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1140         * target.c (flash_erase_command): Use field_string.
1141         * infrun.c (print_signal_received_reason): Use field_string.
1142         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1143         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1144         field_string.
1145         * ada-tasks.c (print_ada_task_info): Use field_string.
1146
1147 2019-07-15  Tom Tromey  <tromey@adacore.com>
1148
1149         * target.c (flash_erase_command): Use field_core_addr.
1150         * symfile.c (generic_load): Use field_core_addr.
1151         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1152         Use field_core_addr.
1153         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1154         field_core_addr.
1155
1156 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1157
1158         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1159         value if its desired type is smaller than a CORE_ADDR and signed.
1160
1161 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1162
1163         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1164         of changes to field names, and use new is_reference field to
1165         decide if a property is a reference or not.
1166         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1167         field.
1168         (struct dwarf2_property_baton): Update header comment, rename
1169         'referenced_type' to 'property_type' and update comments.
1170         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1171         default property type, store in property baton, update to take
1172         accound of renamed field.
1173         (read_func_scope): Update call to attr_to_dynamic_prop.
1174         (read_array_type): Likewise.
1175         (dwarf2_per_cu_addr_sized_int_type): New function.
1176         (read_subrange_index_type): Move type finding code to
1177         dwarf2_per_cu_addr_sized_int_type.
1178         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1179         (dwarf2_per_cu_addr_type): New function.
1180         (set_die_type): Update calls to attr_to_dynamic_prop.
1181
1182 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1183
1184         * dwarf2read.c (read_subrange_index_type): New function.
1185         (read_subrange_type): Move code into new function and call it.
1186         * gdbtypes.c (create_range_type): Add some asserts.
1187
1188 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1189
1190         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1191         update return statements.
1192         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1193         declaration, and update comment to match.
1194         * gdbtypes.c (resolve_dynamic_array): Update call to
1195         dwarf2_evaluate_property to match new return type.
1196
1197 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * valarith.c (value_subscripted_rvalue): Change lowerbound
1200         parameter type from int to LONGEST.
1201         * value.h (value_subscripted_rvalue): Likewise in declaration.
1202
1203 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1204
1205         * cli/cli-utils.c (info_print_command_completer): New function.
1206         * cli/cli-utils.h: Add 'completer.h' include, and forward
1207         declaration for 'struct cmd_list_element'.
1208         (info_print_command_completer): Declare.
1209         * stack.c (_initialize_stack): Add completer for 'info locals' and
1210         'info args'.
1211         * symtab.c (_initialize_symtab): Add completer for 'info
1212         variables' and 'info functions'.
1213         * NEWS: Mention completion for additional info commands.
1214
1215 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1216
1217         * cli/cli-utils.c (extract_info_print_args): Delete.
1218         (extract_arg_maybe_quoted): Delete.
1219         (info_print_options_defs): New variable.
1220         (make_info_print_options_def_group): New function.
1221         (extract_info_print_options): Define new function.
1222         * cli/cli-utils.h (extract_info_print_args): Delete.
1223         (struct info_print_options): New structure.
1224         (extract_info_print_options): Declare new function.
1225         * stack.c (info_locals_command): Update to use new
1226         extract_info_print_options, also add a header comment.
1227         (info_args_command): Likewise.
1228         * symtab.c (info_variables_command): Likewise.
1229         (info_functions_command): Likewise.
1230
1231 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1234         to extract string arguments.
1235         * common/common-utils.c (extract_string_maybe_quoted): New function.
1236         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1237
1238 2019-07-11  Tom Tromey  <tromey@adacore.com>
1239
1240         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1241         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1242         * top.h (gdbinit): Don't declare.
1243         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1244         into...
1245         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1246         * top.c (gdb_init): Don't call init_cli_cmds.
1247         (gdbinit): Remove.
1248         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1249
1250 2019-07-11  Tom Tromey  <tromey@adacore.com>
1251
1252         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1253         after it has been moved.
1254
1255 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1256
1257         * valops.c (value_must_coerce_to_target): Change return type to
1258         bool.
1259         * value.h (value_must_coerce_to_target): Likewise.
1260
1261 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1262
1263         * breakpoint.c (is_hardware_watchpoint): Remove
1264         forward-declaration.
1265         (is_masked_watchpoint): Change return type to bool.
1266         (is_tracepoint): Likewise.
1267         (is_breakpoint): Likewise.
1268         (is_hardware_watchpoint): Likewise.
1269         (is_watchpoint): Likewise.
1270         (is_no_memory_software_watchpoint): Likewise.
1271         (is_catchpoint): Likewise.
1272         (breakpoint_1): Make FILTER parameter's return type bool.
1273         is_masked_watchpoint): Change return type to bool.
1274         (save_breakpoints): Make FILTER parameter's return type bool.
1275         * breakpoint.h (is_breakpoint): Change return type to bool.
1276         (is_watchpoint): Likewise.
1277         (is_catchpoint): Likewise.
1278         (is_tracepoint): Likewise.
1279
1280 2019-07-10  Tom Tromey  <tom@tromey.com>
1281
1282         * defs.h: Don't include gdbarch.h.
1283         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1284         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1285         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1286         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1287         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1288         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1289         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1290         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1291         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1292         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1293         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1294         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1295         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1296         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1297         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1298         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1299         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1300         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1301         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1302         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1303         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1304         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1305         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1306         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1307         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1308         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1309         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1310
1311 2019-07-10  Tom Tromey  <tromey@adacore.com>
1312
1313         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1314         * breakpoint.c (init_ada_exception_breakpoint): Register as
1315         bp_catchpoint.
1316         (print_one_breakpoint_location, print_one_breakpoint): Use
1317         is_ada_exception_catchpoint.
1318         * ada-lang.c (class ada_catchpoint_location): Pass
1319         bp_loc_software_breakpoint to bp_location constructor.
1320         (is_ada_exception_catchpoint): New function.
1321
1322 2019-07-10  Tom Tromey  <tromey@adacore.com>
1323
1324         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1325         VEC.
1326         (struct arm_exidx_entry): New method operator<.
1327         (struct arm_exidx_data) <section_maps>: Change type.
1328         (arm_exidx_data_free): Remove.
1329         (arm_exidx_data_key): Change type.  Move lower.
1330         (arm_exidx_new_objfile): Update.
1331         (arm_compare_exidx_entries): Remove.
1332         (arm_find_exidx_entry, _initialize_arm_tdep)
1333
1334 2019-07-10  Tom Tromey  <tromey@adacore.com>
1335
1336         * solib-spu.c (ocl_program_data_key): Change type.
1337         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1338         Update.
1339
1340 2019-07-10  Tom Tromey  <tromey@adacore.com>
1341
1342         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1343         (struct solib_aix_inferior_data) <library_list>: Change type.
1344         (solib_aix_inferior_data_handle): Change type.
1345         (get_solib_aix_inferior_data): Update.
1346         (solib_aix_free_library_list): Remove.
1347         (library_list_start_library): Update.
1348         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1349         return type.
1350         (solib_aix_get_library_list)
1351         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1352         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1353
1354 2019-07-10  Tom Tromey  <tromey@adacore.com>
1355
1356         * solib-dsbt.c (struct dsbt_info): Add initializers.
1357         (solib_dsbt_pspace_data): Change type.
1358         (dsbt_pspace_data_cleanup): Remove.
1359         (get_dsbt_info, _initialize_dsbt_solib): Update.
1360
1361 2019-07-10  Tom Tromey  <tromey@adacore.com>
1362
1363         * spu-tdep.c (spu_overlay_data): Change type.
1364         (spu_get_overlay_table, spu_overlay_new_objfile)
1365         (_initialize_spu_tdep): Update.
1366
1367 2019-07-10  Tom Tromey  <tromey@adacore.com>
1368
1369         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1370         destructor.
1371         (dbx_objfile_data_key): Change type and declare later.
1372         (DBX_SYMFILE_INFO): Rewrite.
1373         * dbxread.c (dbx_objfile_data_key): Change type.
1374         (dbx_symfile_init): Update.
1375         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1376         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1377         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1378
1379 2019-07-10  Tom Tromey  <tromey@adacore.com>
1380
1381         * jit.c (jit_program_space_key): Change type.  Move lower.
1382         (get_jit_program_space_data): Update.
1383         (jit_program_space_data_cleanup): Remove.
1384         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1385         Update.
1386         (struct jit_program_space_data): Add initializers.
1387
1388 2019-07-10  Tom Tromey  <tromey@adacore.com>
1389
1390         * solib-darwin.c (struct darwin_info): Add initializers.
1391         (solib_darwin_pspace_data): Change type.
1392         (darwin_pspace_data_cleanup): Remove.
1393         (get_darwin_info, _initialize_darwin_solib): Update.
1394
1395 2019-07-10  Tom Tromey  <tromey@adacore.com>
1396
1397         * remote-sim.c (struct sim_inferior_data): Add initializers,
1398         constructor, and destructor.
1399         (sim_inferior_data_key): Change type.  Move lower.
1400         (check_for_duplicate_sim_descriptor): Update.
1401         (get_sim_inferior_data): Use new.  Update.
1402         (~sim_inferior_data_cleanup): Rename from
1403         sim_inferior_data_cleanup.  Simplify.
1404         (gdbsim_close_inferior, simulator_command)
1405         (sim_command_completer, _initialize_remote_sim): Update.
1406         (next_pid, INITIAL_PID): Move earlier.
1407
1408 2019-07-10  Tom Tromey  <tromey@adacore.com>
1409
1410         * python/python-internal.h (create_thread_object): Return
1411         gdbpy_ref.
1412         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1413         * python/py-inferior.c (struct threadlist_entry): Add
1414         constructor.
1415         <thread_obj>: Now a gdbpy_ref.
1416         (thread_to_thread_object): Update.
1417         (add_thread_object): Use new.
1418         (delete_thread_object): Use delete.
1419         (infpy_threads): Update.
1420         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1421         GIL.
1422
1423 2019-07-10  Tom Tromey  <tromey@adacore.com>
1424
1425         * valops.c (value_cast): Specialize error message for Ada.
1426
1427 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1428
1429         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1430
1431 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1432
1433         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1434         bpstat_should_step): Return bool, adjust comments.
1435         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1436         bpstat_should_step): Likewise.
1437
1438 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1439
1440         * features/Makefile: Use feature target descriptions for Arm.
1441         * features/arm/arm-core.c: Generate new file.
1442         * features/arm/arm-fpa.c: Likewise.
1443         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1444         * features/arm/arm-m-profile.c: Likewise.
1445         * features/arm/arm-vfpv2.c: Likewise.
1446         * features/arm/arm-vfpv3.c: Likewise.
1447         * features/arm/xscale-iwmmxt.c: Likewise.
1448         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1449
1450 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1451
1452         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1453         ptrace earlier.
1454
1455 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1456
1457         * features/aarch64-pauth.c: Regenerate.
1458
1459 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1460
1461         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1462         bool.
1463         (bpstat_what): Use false instead of 0.
1464
1465 2019-07-09  Pedro Alves  <palves@redhat.com>
1466
1467         * break-catch-throw.c (is_exception_catchpoint): New.
1468         * breakpoint.c (print_one_breakpoint_location): New parameter
1469         'raw_loc'.  Handle it.  Use
1470         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1471         looking at the breakpoint's type.
1472         (print_one_breakpoint): If handling "maint info breakpoints", also
1473         print locations of exception catchpoints.
1474         * breakpoint.h (is_exception_catchpoint): Declare.
1475
1476 2019-07-09  Pedro Alves  <palves@redhat.com>
1477
1478         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1479         "addr" field.
1480         (allocate_location_exception_catchpoint): New.
1481         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1482         (initialize_throw_catchpoint_ops): Install
1483         allocate_location_exception_catchpoint as allocate_location
1484         method.
1485         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1486         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1487         bp_loc_other.
1488         (breakpoint_address_is_meaningful): Delete.
1489         (bl_address_is_meaningful): New.
1490         (breakpoint_locations_match): Adjust comment.
1491         (bp_location_from_bp_type): New, factored out of...
1492         (bp_location::bp_location(breakpoint *)): ... this.
1493         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1494         factored out of...
1495         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1496         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1497         breakpoint_address_is_meaningful.
1498         (bp_locations_compare): Adjust comment.
1499         (update_global_location_list): Use bl_address_is_meaningful
1500         instead of breakpoint_address_is_meaningful.
1501         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1502         explicit.
1503         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1504         * python/py-breakpoint.c (bppy_get_location): No longer check
1505         whether location is null.
1506
1507 2019-07-09  Pedro Alves  <palves@redhat.com>
1508
1509         PR c++/15468
1510         * breakpoint.c (print_one_breakpoint_location): Remove
1511         single-location assert.
1512
1513 2019-07-09  Tom Tromey  <tom@tromey.com>
1514
1515         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1516         * configure: Rebuild.
1517         * configure.ac: Change common to gdbsupport.
1518         * gdbsupport: Rename from common.
1519         * acinclude.m4: Change common to gdbsupport.
1520         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1521         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1522         gdbsupport.
1523         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1524         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1525         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1526         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1527         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1528         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1529         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1530         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1531         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1532         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1533         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1534         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1535         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1536         coff-pe-read.c, command.h, compile/compile-c-support.c,
1537         compile/compile-c.h, compile/compile-cplus-symbols.c,
1538         compile/compile-cplus-types.c, compile/compile-cplus.h,
1539         compile/compile-loc2c.c, compile/compile.c, completer.c,
1540         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1541         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1542         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1543         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1544         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1545         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1546         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1547         features/aarch64-core.c, features/aarch64-fpu.c,
1548         features/aarch64-pauth.c, features/aarch64-sve.c,
1549         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1550         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1551         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1552         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1553         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1554         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1555         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1556         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1557         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1558         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1559         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1560         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1561         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1562         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1563         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1564         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1565         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1566         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1567         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1568         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1569         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1570         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1571         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1572         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1573         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1574         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1575         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1576         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1577         minsyms.c, mips-linux-tdep.c, namespace.h,
1578         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1579         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1580         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1581         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1582         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1583         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1584         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1585         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1586         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1587         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1588         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1589         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1590         procfs.c, producer.c, progspace.h, psymtab.h,
1591         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1592         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1593         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1594         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1595         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1596         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1597         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1598         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1599         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1600         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1601         target-memory.c, target.c, target.h, target/waitstatus.c,
1602         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1603         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1604         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1605         unittests/array-view-selftests.c,
1606         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1607         unittests/common-utils-selftests.c,
1608         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1609         unittests/format_pieces-selftests.c,
1610         unittests/function-view-selftests.c,
1611         unittests/lookup_name_info-selftests.c,
1612         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1613         unittests/mkdir-recursive-selftests.c,
1614         unittests/observable-selftests.c,
1615         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1616         unittests/parse-connection-spec-selftests.c,
1617         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1618         unittests/scoped_fd-selftests.c,
1619         unittests/scoped_mmap-selftests.c,
1620         unittests/scoped_restore-selftests.c,
1621         unittests/string_view-selftests.c, unittests/style-selftests.c,
1622         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1623         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1624         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1625         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1626         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1627         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1628
1629 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1630
1631         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1632         bool value.
1633         (decode_digits_ordinary): Set explicit_line field in sal.
1634         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1635         symtab_and_line that was set on an explicit line number in
1636         assembler code.  Do always update the recorded symtab and line if
1637         we do skip the prologue.
1638
1639 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1640
1641         * breakpoint.c (set_breakpoint_location_function): Remove
1642         explicit_loc parameter.
1643         (momentary_breakpoint_from_master): Update call to
1644         set_breakpoint_location_function.
1645         (add_location_to_breakpoint): Likewise.
1646
1647 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1648
1649         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1650         required features based on default bfd type when no specific bfd
1651         is present.
1652
1653 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1654
1655         * NEWS: Mention that GDB printf and eval commands can now print
1656         C-style and Ada-style convenience var strings without
1657         calling the inferior.
1658         * printcmd.c (printf_c_string): Locally print GDB internal var
1659         instead of transiting via the inferior.
1660         (printf_wide_c_string): Likewise.
1661
1662 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1663
1664         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1665
1666 2019-07-04  Tom Tromey  <tom@tromey.com>
1667
1668         PR tui/24724:
1669         * tui/tui-winsource.c (tui_clear_source_content): Update.
1670         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1671         (tui_update_breakpoint_info): Update.
1672         (tui_set_exec_info_content): Update.
1673         * tui/tui-source.c (tui_set_source_content_nil): Update.
1674         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1675         has_break.
1676         * tui/tui-data.h (enum tui_bp_flag): New.
1677         (tui_bp_flags): New enum flags type.
1678         (struct tui_source_element) <break_mode>: Change type.  Rename
1679         from has_break.
1680         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1681         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1682         constants.
1683         * tui/tui-winsource.h: Fix comment.
1684
1685 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1686
1687         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1688         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1689         (store_fpregs_to_thread)
1690         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1691         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1692         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1693         (IWMMXT_REGS_SIZE): Add define.
1694         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1695         (fetch_vfp_regs, store_vfp_regs)
1696         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1697         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1698
1699 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1700
1701         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1702         defines.
1703         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1704         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1705         (ARM_INT_REGISTER_SIZE): ...to this.
1706         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1707         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1708         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1709         (arm_linux_collect_gregset, supply_nwfpe_register)
1710         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1711         defines.
1712         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1713         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1714         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1715         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1716         (arm_return_in_memory, arm_store_return_value)
1717         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1718         (arm_record_ld_st_multiple): Likewise.
1719         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1720         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1721
1722 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1723
1724         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1725         AARCH64_DISPLACED_MODIFIED_INSNS.
1726         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1727         (aarch64_displaced_step_copy_insn): Likewise.
1728         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1729         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1730         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1731         ARM_DISPLACED_MODIFIED_INSNS.
1732         * arm-tdep.c (arm_gdbarch_init): Likewise.
1733         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1734         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1735         (struct arm_displaced_step_closure): Use
1736         ARM_DISPLACED_MODIFIED_INSNS.
1737
1738 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1739
1740         * features/Makefile: Remove unused xml files.
1741         * features/aarch64.xml: Remove.
1742         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1743         * features/i386/amd64-avx-avx512.xml: Remove.
1744         * features/i386/amd64-avx-linux.xml: Remove.
1745         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1746         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1747         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1748         * features/i386/amd64-avx-mpx.xml: Remove.
1749         * features/i386/amd64-avx.xml: Remove.
1750         * features/i386/amd64-linux.xml: Remove.
1751         * features/i386/amd64-mpx-linux.xml: Remove.
1752         * features/i386/amd64-mpx.xml: Remove.
1753         * features/i386/amd64.xml: Remove.
1754         * features/i386/i386-avx-avx512-linux.xml: Remove.
1755         * features/i386/i386-avx-avx512.xml: Remove.
1756         * features/i386/i386-avx-linux.xml: Remove.
1757         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1758         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1759         * features/i386/i386-avx-mpx-linux.xml: Remove.
1760         * features/i386/i386-avx-mpx.xml: Remove.
1761         * features/i386/i386-avx.xml: Remove.
1762         * features/i386/i386-linux.xml: Remove.
1763         * features/i386/i386-mmx-linux.xml: Remove.
1764         * features/i386/i386-mmx.xml: Remove.
1765         * features/i386/i386-mpx-linux.xml: Remove.
1766         * features/i386/i386-mpx.xml: Remove.
1767         * features/i386/i386.xml: Remove.
1768         * features/i386/x32-avx-avx512-linux.xml: Remove.
1769         * features/i386/x32-avx-linux.xml: Remove.
1770         * features/i386/x32-linux.xml: Remove.
1771
1772 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1773
1774         * regformats/aarch64.dat: Remove.
1775         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1776         * regformats/i386/amd64-avx-linux.dat: Remove.
1777         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1778         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1779         * regformats/i386/amd64-linux.dat: Remove.
1780         * regformats/i386/amd64-mpx-linux.dat: Remove.
1781         * regformats/i386/amd64.dat: Remove.
1782         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1783         * regformats/i386/i386-avx-linux.dat: Remove.
1784         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1785         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1786         * regformats/i386/i386-linux.dat: Remove.
1787         * regformats/i386/i386-mmx-linux.dat: Remove.
1788         * regformats/i386/i386-mpx-linux.dat: Remove.
1789         * regformats/i386/i386.dat: Remove.
1790         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1791         * regformats/i386/x32-avx-linux.dat: Remove.
1792         * regformats/i386/x32-linux.dat: Remove.
1793
1794 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1795
1796         * aarch64-tdep.c: Remove xml self tests.
1797         * amd64-linux-tdep.c: Likewise.
1798         * amd64-tdep.c: Likewise.
1799         * i386-linux-tdep.c: Likewise.
1800         * i386-tdep.c: Likewise.
1801
1802 2019-07-03  Pedro Alves  <palves@redhat.com>
1803
1804         PR cli/24732
1805         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1806         (pipe_cmd_option_defs): New.
1807         (make_pipe_cmd_options_def_group): New.
1808         (pipe_command): Use gdb::option::process_options.
1809         (pipe_command_completer): New function.
1810         (_initialize_cli_cmds): Install completer for "pipe" command.
1811
1812 2019-07-03  Pedro Alves  <palves@redhat.com>
1813
1814         * cli/cli-option.c (union option_value) <string>: New field.
1815         (struct option_def_and_value): Add ctor, move ctor, dtor and
1816         use DISABLE_COPY_AND_ASSIGN.
1817         (option_def_and_value::clear_value): New.
1818         (parse_option, save_option_value_in_ctx, get_val_type_str)
1819         (add_setshow_cmds_for_options): Handle var_string.
1820         * cli-option.h (union option_def::var_address) <string>: New
1821         field.
1822         (struct string_option_def): New.
1823         * maint-test-options.c (struct test_options_opts): Add default
1824         ctor and use DISABLE_COPY_AND_ASSIGN.
1825         <string_opt>: New field.
1826         (test_options_opts::~test_options_opts): New.
1827         (test_options_opts::dump): Also dump "-string".
1828         (test_options_option_defs): Install "string.
1829
1830 2019-07-03  Pedro Alves  <palves@redhat.com>
1831
1832         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1833         option_value with a null enumeration.
1834         (complete_options): Save the option values in the context.
1835         (save_option_value_in_ctx): New, factored out from ...
1836         (process_options): ... here.
1837         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1838         of the function.
1839         * maint-test-options.c (test_options_opts::dump): New, factored
1840         out from ...
1841         (maintenance_test_options_command_mode): ... here.
1842         (maintenance_test_options_command_completion_result): Delete.
1843         (maintenance_test_options_command_completion_text): Update
1844         comment.
1845         (maintenance_show_test_options_completion_result): Change
1846         prototype.  Just print
1847         maintenance_test_options_command_completion_text.
1848         (save_completion_result): New.
1849         (maintenance_test_options_completer_mode): Pass options context to
1850         complete_options, and then save a dump.
1851         (_initialize_maint_test_options): Use add_cmd to install "maint
1852         show test-options-completion-result".
1853
1854 2019-07-03  Pedro Alves  <palves@redhat.com>
1855
1856         * NEWS (New commands): Mention "with" and "maint with".
1857         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1858         (with_command, with_command_completer): New.
1859         (pipe_command): Adjust to new repeat_previous
1860         interface.
1861         (_initialize_cli_cmds): Install the "with" command and its "w"
1862         alias.
1863         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1864         declarations.
1865         * cli/cli-setshow.c (parse_cli_var_uinteger)
1866         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1867         argument strings for all var_types.
1868         (get_setshow_command_value_string): New, factored out from ...
1869         (do_show_command): ... this.
1870         * cli/cli-setshow.h: Include <string>.
1871         (get_setshow_command_value_string): Declare.
1872         * command.h (repeat_previous): Now returns const char *.  Adjust
1873         comment.
1874         * maint.c: Include "cli/cli-cmds.h".
1875         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1876         (_initialize_maint_cmds): Register the "maintenance with" command.
1877         * top.c (repeat_previous): Move bits from pipe_command here:
1878         Return the saved command line, if any; error out if there's no
1879         command to relaunch.
1880
1881 2019-07-03  Pedro Alves  <palves@redhat.com>
1882
1883         * NEWS (New commands): Mention "maint set/show test-settings"
1884         instead of "maint test-settings".
1885         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1886         (maintenance_test_settings_set_list): Rename to ...
1887         (maintenance_set_test_settings_list): ... this.
1888         (maintenance_test_settings_show_list): Rename to  ...
1889         (maintenance_show_test_settings_list): ... this.
1890         (maintenance_test_settings_cmd): Delete.
1891         (maintenance_test_settings_set_cmd): ...
1892         (maintenance_set_test_settings_cmd): ... this.
1893         (maintenance_test_settings_show_cmd): ...
1894         (maintenance_show_test_settings_cmd): ... this.
1895         (maintenance_test_settings_show_value_cmd):
1896         (maintenance_show_test_settings_value_cmd): ... this.
1897         (_initialize_maint_test_settings): No longer install the "maint
1898         test-settings" prefix command.  Rename "maint test-settings set"
1899         to "maint set test-settings", and "maint test-settings show" to
1900         "maint show test-settings".  Adjust all subcommands.
1901
1902 2019-07-03  Pedro Alves  <palves@redhat.com>
1903
1904         * maint-test-settings.c: Fix file's intro comment.  Replace all
1905         references to "test-options" with references to "test-settings",
1906         in comments.
1907
1908 2019-07-03  Pedro Alves  <palves@redhat.com>
1909
1910         * maint-test-settings.c (maintenance_test_settings_xxx)
1911         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1912         New.
1913         (maintenance_test_settings_enums): Use them.
1914         (maintenance_test_settings_enum): Default to
1915         maintenance_test_settings_xxx.
1916         (_initialize_maint_test_settings): Initialize
1917         MAINTENANCE_TEST_SETTINGS_FILENAME.
1918
1919 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1920
1921         * breakpoint.h (remove_breakpoints_inf): Change return type to
1922         void, move function documentation here.
1923         * breakpoint.c (remove_breakpoints_inf): Change return type to
1924         void, move function documentation to header.
1925
1926 2019-07-02  Pedro Alves  <palves@redhat.com>
1927
1928         * NEWS (Completion improvements): Mention "info threads".
1929         * thread.c (struct info_threads_opts, info_threads_option_defs)
1930         (make_info_threads_options_def_group): New.
1931         (info_threads_command): Use gdb::option::process_options.
1932         (info_threads_command_completer): New.
1933         (_initialize_thread): Use gdb::option::build_help to build the
1934         help text for "info threads".
1935
1936 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1937
1938         * defs.h (generic_load): Move from here...
1939         * symfile.h (generic_load): ... to here.  Rename name parameter
1940         to args.
1941         * symfile.c (generic_load): Add comment.
1942
1943 2019-07-01  Tom Tromey  <tromey@adacore.com>
1944
1945         * dwarf2read.c
1946         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1947         declaration of without_params.  Fix formatting.
1948
1949 2019-07-01  Tom Tromey  <tromey@adacore.com>
1950
1951         * ada-exp.y (find_primitive_type): Update.
1952         * ada-lang.h (ada_lookup_symbol): Update.
1953         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1954         parameter.
1955         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1956
1957 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1958
1959         PR breakpoints/24541
1960         * gdbarch.c: Regenerate.
1961         * gdbarch.h: Regenerate.
1962         * gdbarch.sh: Add 'stap_adjust_register'.
1963         * i386-tdep.c: Include '<unordered_set>'.
1964         (i386_stap_adjust_register): New function.
1965         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1966         * stap-probe.c (stap_parse_register_operand): Call
1967         'gdbarch_stap_adjust_register'.
1968
1969 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1970
1971         PR python/24742
1972         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1973         * python/python.c (do_start_initialization): Use 'xmalloc'
1974         instead of 'PyMem_Malloc'.
1975
1976 2019-06-28  Tom Tromey  <tromey@adacore.com>
1977
1978         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1979         for Ada.
1980
1981 2019-06-27  Tom Tromey  <tromey@adacore.com>
1982
1983         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1984         objfile_key.
1985         (arm_find_mapping_symbol, arm_record_special_symbol)
1986         (_initialize_arm_tdep): Update.
1987         (arm_objfile_data_free): Remove.
1988
1989 2019-06-27  Tom Tromey  <tromey@adacore.com>
1990
1991         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1992         to cp_print_static_field.
1993
1994 2019-06-26  Tom Tromey  <tromey@adacore.com>
1995
1996         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1997         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1998         declare.
1999
2000 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2001
2002         * features/aarch64-core.c (create_feature_aarch64_core):
2003         Regenerate.
2004         * features/aarch64-core.xml: Add cpsr flags.
2005
2006 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2007
2008         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2009         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2010
2011 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2012
2013         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2014         field.
2015         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2016         use.
2017         (arm_record_special_symbol): Don't insert new symbol in sorted
2018         position, push it at the end.
2019
2020 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2021
2022         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2023         (arm_mapping_symbol_s): Remove.
2024         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2025         (arm_mapping_symbol_vec): New typedef.
2026         (struct arm_per_objfile): Add constructor.
2027         <section_maps>: Change type to
2028         std::unique_ptr<arm_mapping_symbol_vec[]>.
2029         (arm_compare_mapping_symbols): Remove.
2030         (arm_find_mapping_symbol): Adjust to section_maps type change.
2031         (arm_objfile_data_free): Call delete on arm_per_objfile.
2032         (arm_record_special_symbol): Adjust to section_maps type change.
2033         Allocate arm_per_objfile with new.
2034
2035 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2036
2037         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2038         with the command prefix.
2039
2040 2019-06-25  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2043         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2044
2045 2019-06-25  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2048         type.
2049         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2050         protected.
2051
2052 2019-06-25  Tom Tromey  <tom@tromey.com>
2053
2054         * tui/tui-winsource.c
2055         (tui_source_window_base::set_is_exec_point_at): Add check against
2056         LOA_ADDRESS.
2057
2058 2019-06-25  Tom Tromey  <tom@tromey.com>
2059
2060         * tui/tui-source.c (tui_set_source_content): Don't check before
2061         xfree.
2062         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2063
2064 2019-06-25  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-winsource.h (tui_update_source_window_as_is)
2067         (tui_alloc_source_buffer, tui_line_is_displayed)
2068         (tui_addr_is_displayed): Change type of win_info.
2069         * tui/tui-winsource.c (tui_update_source_window_as_is)
2070         (tui_clear_source_content, tui_show_source_line)
2071         (tui_show_source_content, tui_source_window_base::refill)
2072         (tui_source_window_base::set_is_exec_point_at)
2073         (tui_source_window_base::set_is_exec_point_at)
2074         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2075         (tui_alloc_source_buffer, tui_line_is_displayed)
2076         (tui_addr_is_displayed): Change type of win_info.  Update.
2077         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2078         (tui_source_window_base::do_make_visible_with_new_height):
2079         Update.
2080         * tui/tui-source.c (tui_set_source_content)
2081         (tui_set_source_content_nil)
2082         (tui_source_window::do_scroll_vertical): Update.
2083         * tui/tui-layout.c (show_layout): Update.
2084         * tui/tui-disasm.c (tui_set_disassem_content)
2085         (tui_disasm_window::do_scroll_vertical): Update.
2086         * tui/tui-data.h (tui_win_content): Remove.
2087         (struct tui_gen_win_info) <content, content_size>: Remove.
2088         (struct tui_source_element): Add initializers and destructor.
2089         (union tui_which_element, struct tui_win_element): Remove.
2090         (struct tui_source_window_base) <content>: New field.
2091         (struct tui_data_window): Remove destructor.
2092         (tui_alloc_content, tui_free_win_content)
2093         (tui_free_all_source_wins_content): Don't declare.
2094         * tui/tui-data.c (tui_initialize_static_data): Update.
2095         (init_content_element, tui_alloc_content): Remove.
2096         (~tui_gen_win_info): Update.
2097         (~tui_data_window, tui_free_all_source_wins_content)
2098         (tui_free_win_content, free_content, free_content_elements):
2099         Remove.
2100
2101 2019-06-25  Tom Tromey  <tom@tromey.com>
2102
2103         * tui/tui-winsource.h (tui_clear_source_content)
2104         (tui_erase_source_content, tui_show_source_content): Change type
2105         of win_info.
2106         * tui/tui-winsource.c (tui_clear_source_content)
2107         (tui_erase_source_content, tui_show_source_content): Change type
2108         of win_info.
2109         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2110         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2111         win_info.
2112         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2113         win_info.
2114         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2115
2116 2019-06-25  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-winsource.c (tui_clear_source_content)
2119         (tui_source_window_base::set_is_exec_point_at): Update.
2120         * tui/tui-source.c (tui_set_source_content_nil): Update.
2121         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2122         a bool.
2123         * tui/tui-data.c (init_content_element): Update.
2124
2125 2019-06-25  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2128         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2129         * tui/tui-layout.c (init_and_make_win): Update.
2130         * tui/tui.h (enum tui_win_type): Update.
2131         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2132         tui_win_is_auxillary.
2133         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2134         tui_win_is_auxillary.
2135
2136 2019-06-25  Tom Tromey  <tom@tromey.com>
2137
2138         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2139         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2140         (tui_delete_data_content_windows, tui_display_all_data)
2141         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2142         Update.
2143         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2144         * tui/tui-regs.c (tui_last_regs_line_no)
2145         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2146         (tui_show_registers): Update.
2147         (tui_show_register_group): Return void.  Update.
2148         (tui_display_registers_from, tui_display_reg_element_at_line)
2149         (tui_display_registers_from_line, tui_check_register_values):
2150         Update.
2151         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2152         member.
2153         (struct tui_data_window) <regs_content>: Now a std::vector.
2154         <regs_content_count>: Remove.
2155         (tui_add_content_elements, tui_free_data_content): Don't declare.
2156         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2157         (init_content_element): Remove DATA_WIN case.  Add assert.
2158         (tui_add_content_elements): Remove.
2159         (tui_data_window): Update.
2160         (tui_free_data_content): Remove.
2161         (free_content_elements): Remove DATA_WIN case.
2162
2163 2019-06-25  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-data.c (tui_data_item_window): Update.
2166         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2167         * tui/tui-windata.c (tui_display_all_data)
2168         (tui_display_data_from_line): Update.
2169         (tui_check_data_values): Remove.
2170         * tui/tui-regs.c (tui_show_register_group)
2171         (tui_display_reg_element_at_line): Update.
2172         * tui/tui-hooks.c (tui_register_changed)
2173         (tui_refresh_frame_and_register_information): Call
2174         tui_check_register_values.
2175         * tui/tui-data.h (struct tui_data_window) <data_content,
2176         data_content_count, data_type>: Remove.
2177         (enum tui_data_type): Remove.
2178
2179         * tui/tui-data.c (tui_data_window::clear_detail)
2180         (~tui_data_window): Update.
2181
2182 2019-06-25  Tom Tromey  <tom@tromey.com>
2183
2184         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2185         declare.
2186         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2187         Rename from tui_first_data_item_displayed.  Update.
2188         (tui_data_window::refresh_all)
2189         (tui_data_window::do_scroll_vertical): Update.
2190         * tui/tui-data.h (struct tui_data_window)
2191         <first_data_item_displayed>: Declare new method.
2192
2193 2019-06-25  Tom Tromey  <tom@tromey.com>
2194
2195         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2196         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2197         contents...
2198         (tui_initialize_static_data): ...here.
2199
2200 2019-06-25  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2203         (tui_display_registers_from, tui_check_register_values): Update.
2204         (tui_display_register): Remove win_info parameter; update.
2205         (tui_get_register): Change type of parameters.
2206         * tui/tui-data.h (struct tui_data_element): Remove.
2207         (union tui_which_element) <data>: Remove.
2208         <data_window>: Change type.
2209         (struct tui_data_item_window): New.
2210         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2211         case.  Add assert.
2212         (~tui_data_item_window): New destructor.
2213         (free_content_elements): Remove DATA_ITEM_WIN case.
2214
2215 2019-06-25  Tom Tromey  <tom@tromey.com>
2216
2217         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2218         Remove.
2219
2220 2019-06-25  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-data.h (struct tui_command_element): Remove.
2223         (union tui_which_element) <command>: Remove.
2224         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2225         assert.
2226         (free_content_elements): Remove CMD_WIN case.
2227
2228 2019-06-25  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-layout.c (tui_set_layout): Update.
2231         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2232         * tui/tui-data.c (layout_def): Update.
2233
2234 2019-06-25  Tom Tromey  <tom@tromey.com>
2235
2236         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2237         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2238         (tui_source_window_base::set_new_height): Update.
2239         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2240         Update.
2241         (tui_set_locator_fullname, tui_set_locator_info)
2242         (tui_show_frame_info): Update.
2243         * tui/tui-source.c (tui_set_source_content)
2244         (tui_source_is_displayed): Update.
2245         * tui/tui-layout.c (show_source_disasm_command, show_data)
2246         (show_source_or_disasm_and_command): Update.
2247         * tui/tui-disasm.c (tui_set_disassem_content)
2248         (tui_get_begin_asm_address): Update.
2249         * tui/tui-data.h (struct tui_locator_element): Remove.
2250         (union tui_which_element) <locator>: Remove.
2251         (struct tui_locator_window): New.
2252         (tui_locator_win_info_ptr): Change return type.
2253         * tui/tui-data.c (_locator): Change type.
2254         (tui_locator_win_info_ptr): Change return type.
2255         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2256         (tui_alloc_content): Add assert.
2257
2258 2019-06-25  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui-winsource.c
2261         (tui_exec_info_window::maybe_allocate_content): New method.
2262         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2263         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2264         (make_source_or_disasm_window): Add cast.
2265         * tui/tui-data.h (union tui_which_element) <simple_string>:
2266         Remove.
2267         (struct tui_source_info): New.
2268         (struct tui_source_window_base) <execution_info>: Change type.
2269         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2270         case, and add assert.
2271         (tui_alloc_content): Add assert.
2272
2273 2019-06-25  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2276         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2277         * tui/tui-data.c (tui_alloc_win_info): Remove.
2278
2279 2019-06-25  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2282         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2283         can_highlight.
2284
2285 2019-06-25  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2288         make_visible_with_new_height method.
2289         (tui_win_info::make_visible_with_new_height): New method.
2290         (tui_source_window_base::do_make_visible_with_new_height)
2291         (tui_data_window::do_make_visible_with_new_height)
2292         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2293         (make_visible_with_new_height): Remove.
2294         (tui_resize_all, tui_adjust_win_heights): Use
2295         make_visible_with_new_height method.
2296         * tui/tui-data.h (struct tui_win_info)
2297         <do_make_visible_with_new_height, make_visible_with_new_height>:
2298         New methods.
2299         (struct tui_source_window_base, struct tui_data_window)
2300         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2301         methods.
2302
2303 2019-06-25  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2306         method.
2307         (update_tab_width): Call update_tab_width method.
2308         * tui/tui-data.h (struct tui_win_info)
2309         (struct tui_source_window_base) <update_tab_width>: New methods.
2310
2311 2019-06-25  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2314         parameter.
2315         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2316         parameter.
2317         (tui_gen_win_info::make_visible): Update.
2318         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2319         parameter.
2320         * tui/tui-data.h (enum tui_box): New enum.
2321         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2322
2323 2019-06-25  Tom Tromey  <tom@tromey.com>
2324
2325         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2326         init_and_make_win for EXEC_INFO_WIN.
2327         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2328         longer inline.
2329         (struct tui_win_info) <~tui_win_info>: Inline.
2330         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2331         Don't declare.
2332         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2333         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2334         Remove.
2335         (tui_initialize_static_data): Update.
2336         (~tui_gen_win_info): Handle more cleanup here.
2337         (~tui_source_window_base): Delete "execution_info".
2338         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2339
2340 2019-06-25  Tom Tromey  <tom@tromey.com>
2341
2342         * tui/tui-layout.c (make_command_window): Don't set
2343         can_highlight.
2344         (show_source_disasm_command): Call the reset method.
2345         (show_data): Don't set can_highlight.  Call the reset method.
2346         (tui_gen_win_info::reset): Rename from init_gen_win_info
2347         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2348         (show_source_or_disasm_and_command): Call the reset method.
2349         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2350         (struct tui_cmd_window): Set can_highlight.
2351
2352 2019-06-25  Tom Tromey  <tom@tromey.com>
2353
2354         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2355         from make_visible.
2356         (tui_make_visible, tui_make_invisible): Rewrite.
2357         (tui_win_info::make_visible): Remove.
2358         (tui_source_window_base::make_visible): Update.
2359         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2360         method.  Moved from...
2361         (struct tui_win_info) <make_visible>: ...here.
2362
2363 2019-06-25  Tom Tromey  <tom@tromey.com>
2364
2365         * tui/tui-winsource.c
2366         (tui_source_window_base::do_scroll_horizontal): Remove direction
2367         parameter.
2368         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2369         direction parameter.
2370         * tui/tui-win.c (tui_win_info::forward_scroll)
2371         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2372         (tui_win_info::right_scroll): Update.
2373         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2374         direction parameter.
2375         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2376         direction parameter.
2377         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2378         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2379         Remove direction parameter.
2380         (struct tui_source_window_base, struct tui_source_window)
2381         (struct tui_disasm_window, struct tui_data_window)
2382         (struct tui_cmd_window): Update.
2383
2384 2019-06-25  Tom Tromey  <tom@tromey.com>
2385
2386         * tui/tui-winsource.h (tui_set_exec_info_content)
2387         (tui_show_exec_info_content, tui_erase_exec_info_content)
2388         (tui_clear_exec_info_content, tui_update_exec_info): Change
2389         argument to tui_source_window_base.
2390         * tui/tui-winsource.c (tui_set_exec_info_content)
2391         (tui_show_exec_info_content, tui_erase_exec_info_content)
2392         (tui_clear_exec_info_content, tui_update_exec_info): Change
2393         argument to tui_source_window_base.
2394
2395 2019-06-25  Tom Tromey  <tom@tromey.com>
2396
2397         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2398         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2399
2400 2019-06-25  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2403         check.
2404
2405 2019-06-25  Tom Tromey  <tom@tromey.com>
2406
2407         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2408         type to void.
2409         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2410         type to void.
2411         * tui/tui-source.c (tui_set_source_content): Update.
2412         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2413
2414 2019-06-25  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui-win.c (window_name_completer, tui_set_focus)
2417         (tui_all_windows_info): Use name method.
2418         * tui/tui-data.h (struct tui_gen_win_info)
2419         (struct tui_source_window, struct tui_disasm_window)
2420         (struct tui_data_window, struct tui_cmd_window) <name>: New
2421         method.
2422         (tui_win_name): Don't declare.
2423         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2424         (tui_win_name): Remove.
2425
2426 2019-06-25  Tom Tromey  <tom@tromey.com>
2427
2428         * tui/tui-winsource.h (tui_update_source_window)
2429         (tui_update_source_window_as_is): Change parameter type.
2430         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2431         to be a tui_source_window_base.
2432         (tui_update_source_window_as_is): Likewise.
2433         * tui/tui-win.c (make_visible_with_new_height): Update.
2434
2435 2019-06-25  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-winsource.c (tui_erase_source_content)
2438         (tui_show_source_content, tui_show_exec_info_content)
2439         (tui_erase_exec_info_content): Use refresh_window method.
2440         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2441         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2442         from tui_refresh_win.
2443         (tui_data_window::refresh_window): New method.
2444         (tui_win_info::refresh, tui_source_window_base::refresh)
2445         (tui_refresh_all): Use refresh_window method.
2446         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2447         method.
2448         * tui/tui-regs.c (tui_display_register): Call refresh_window
2449         method.
2450         * tui/tui-layout.c (show_source_disasm_command)
2451         (show_source_or_disasm_and_command): Call refresh_window method.
2452         * tui/tui-data.h (struct tui_gen_win_info)
2453         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2454         New method.
2455
2456 2019-06-25  Tom Tromey  <tom@tromey.com>
2457
2458         * tui/tui.c (tui_rl_other_window, tui_enable)
2459         (tui_is_window_visible, tui_get_command_dimension): Update.
2460         * tui/tui-winsource.c (tui_update_source_window_as_is)
2461         (tui_clear_source_content, tui_erase_source_content)
2462         (tui_show_source_line, tui_source_window_base::refill)
2463         (tui_source_window_base::do_scroll_horizontal)
2464         (tui_source_window_base::set_is_exec_point_at)
2465         (tui_update_breakpoint_info, tui_set_exec_info_content)
2466         (tui_alloc_source_buffer, tui_line_is_displayed)
2467         (tui_addr_is_displayed): Update.
2468         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2469         (tui_check_and_display_highlight_if_needed)
2470         (tui_win_info::make_visible, tui_win_info::refresh)
2471         (tui_refresh_all): Update.
2472         * tui/tui-windata.c (tui_first_data_item_displayed)
2473         (tui_delete_data_content_windows, tui_erase_data_content)
2474         (tui_display_all_data, tui_data_window::refresh_all)
2475         (tui_check_data_values): Update.
2476         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2477         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2478         (tui_win_info::backward_scroll, tui_refresh_all_win)
2479         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2480         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2481         (tui_source_window_base::set_new_height)
2482         (tui_data_window::set_new_height)
2483         (make_invisible_and_set_new_height)
2484         (make_visible_with_new_height, new_height_ok)
2485         (parse_scrolling_args): Update.
2486         * tui/tui-stack.c (tui_show_frame_info): Update.
2487         * tui/tui-source.c (tui_set_source_content)
2488         (tui_set_source_content_nil, tui_source_is_displayed)
2489         (tui_source_window::do_scroll_vertical): Update.
2490         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2491         (tui_display_registers_from, tui_display_reg_element_at_line)
2492         (tui_check_register_values, tui_reg_command): Update.
2493         * tui/tui-layout.c (tui_default_win_height)
2494         (show_source_disasm_command, show_data, init_and_make_win)
2495         (show_source_or_disasm_and_command): Update.
2496         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2497         (tui_redisplay_readline, tui_mld_flush)
2498         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2499         (tui_getc): Update.
2500         * tui/tui-disasm.c (tui_set_disassem_content)
2501         (tui_disasm_window::do_scroll_vertical): Update.
2502         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2503         Now virtual.
2504         (struct tui_win_info): Derive from tui_gen_win_info.
2505         <~tui_win_info>: Mark as override.
2506         <generic>: Remove member.
2507         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2508         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2509         (~tui_data_window, ~tui_win_info)
2510         (tui_free_all_source_wins_content): Update.
2511         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2512
2513 2019-06-25  Tom Tromey  <tom@tromey.com>
2514
2515         * tui/tui-layout.c (init_and_make_win): Use new.
2516         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2517         destructor, initializers.
2518         (tui_alloc_generic_win_info): Don't declare.
2519         * tui/tui-data.c (_locator): Add argument to constructor.
2520         (source_win, disasm_win): New globals.
2521         (exec_info): Remove.
2522         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2523         Update.
2524         (tui_alloc_generic_win_info): Remove.
2525         (init_content_element): Use new.
2526         (tui_win_info::tui_win_info): Update.
2527         (free_content_elements) <case DATA_WIN>: Use delete.
2528
2529 2019-06-25  Tom Tromey  <tom@tromey.com>
2530
2531         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2532         * tui/tui-windata.c (tui_first_data_item_displayed)
2533         (tui_delete_data_content_windows): Update.
2534         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2535         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2536         (tui_display_registers_from, tui_check_register_values): Update.
2537         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2538         pointer.
2539         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2540         window.
2541         (tui_free_data_content): Update.
2542         (free_content_elements) <case DATA_WIN>: Free the window.
2543
2544 2019-06-25  Tom Tromey  <tom@tromey.com>
2545
2546         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2547         Update.
2548         * tui/tui-layout.c (make_command_window)
2549         (show_source_disasm_command, show_data, init_and_make_win)
2550         (show_source_or_disasm_and_command): Update.
2551         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2552         method.
2553         <can_highight, is_highlighted>: Now bool.
2554         (tui_set_win_highlight): Don't declare.
2555         * tui/tui-data.c (tui_set_win_highlight): Remove.
2556
2557 2019-06-25  Tom Tromey  <tom@tromey.com>
2558
2559         * tui/tui-wingeneral.c (make_visible): Remove check of window
2560         type.
2561
2562 2019-06-25  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-win.c (tui_win_info::max_height)
2565         (tui_cmd_window::max_height): New methods.
2566         (new_height_ok): Call max_height.
2567         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2568         <max_height>: New method.
2569
2570 2019-06-25  Tom Tromey  <tom@tromey.com>
2571
2572         * tui/tui-win.c (tui_source_window_base::set_new_height)
2573         (tui_data_window::set_new_height): New methods.
2574         (make_invisible_and_set_new_height): Call set_new_height method.
2575         * tui/tui-data.h (struct tui_win_info)
2576         (struct tui_source_window_base, struct tui_data_window)
2577         <set_new_height>: New method.
2578
2579 2019-06-25  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2582         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2583         tui_refresh_data_win.
2584         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2585         method.
2586         (tui_refresh_all_win): Call the refresh_all method.
2587         (tui_set_focus): Likewise.
2588         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2589         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2590         Likewise.
2591
2592 2019-06-25  Tom Tromey  <tom@tromey.com>
2593
2594         * tui/tui-winsource.h (tui_refill_source_window)
2595         (tui_set_is_exec_point_at): Don't declare.
2596         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2597         (tui_source_window_base::refill): Rename from
2598         tui_refill_source_window.
2599         (tui_source_window_base::do_scroll_horizontal): Update.
2600         (tui_source_window_base::set_is_exec_point_at): Rename from
2601         tui_set_is_exec_point_at.
2602         (tui_update_all_breakpoint_info): Update.
2603         * tui/tui-stack.c (tui_show_frame_info): Update.
2604         * tui/tui-layout.c (show_data): Add cast.
2605         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2606         * tui/tui-data.h (struct tui_source_window_base) <refill,
2607         set_is_exec_point_at>: New methods.
2608         (tui_source_windows, tui_add_to_source_windows): Update types.
2609         (tui_add_to_source_windows): Remove redundant declaration.
2610         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2611         (tui_source_windows): Change return type.
2612         (tui_clear_source_windows_detail): Update.
2613         (tui_add_to_source_windows): Change type of parameter.
2614         (tui_free_all_source_wins_content): Update.
2615
2616 2019-06-25  Tom Tromey  <tom@tromey.com>
2617
2618         * tui/tui-wingeneral.c (tui_win_info::refresh)
2619         (tui_source_window_base::refresh): New methods.
2620         (tui_refresh_all): Call the refresh method.
2621         * tui/tui-data.h (struct tui_win_info)
2622         (struct tui_source_window_base) <refresh>: New method.
2623
2624 2019-06-25  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui.h (tui_is_window_visible): Return bool.
2627         * tui/tui.c (tui_is_window_visible): Return bool.
2628         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2629         (tui_make_visible, tui_make_invisible)
2630         (tui_win_info::make_visible)
2631         (tui_source_window_base::make_visible, make_all_visible)
2632         (tui_make_all_visible, tui_make_all_invisible): Update.
2633         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2634         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2635         bool.
2636         (struct tui_win_info, struct tui_source_window_base)
2637         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2638         * tui/tui-data.c (tui_init_generic_part): Update.
2639
2640 2019-06-25  Tom Tromey  <tom@tromey.com>
2641
2642         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2643         (tui_source_window_base::make_visible): New methods.
2644         (make_all_visible): Make method call.
2645         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2646         (struct tui_source_window_base, struct tui_cmd_window): Override
2647         make_visible.
2648         (tui_win_is_source_type): Don't declare.
2649         * tui/tui-data.c (tui_win_is_source_type): Remove.
2650
2651 2019-06-25  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2654         NULL check.
2655
2656 2019-06-25  Tom Tromey  <tom@tromey.com>
2657
2658         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2659         Inline constructor.  Add initializers for members.
2660         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2661         constructors; now inline in class.
2662
2663 2019-06-25  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-regs.c (tui_show_registers): Update.
2666         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2667         bool.
2668         * tui/tui-data.c (tui_data_window::clear_detail)
2669         (tui_data_window): Update.
2670
2671 2019-06-25  Tom Tromey  <tom@tromey.com>
2672
2673         * tui/tui-windata.c (tui_display_all_data)
2674         (tui_display_data_from_line, tui_display_data_from)
2675         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2676         Update.
2677         * tui/tui-regs.c (tui_last_regs_line_no)
2678         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2679         (tui_show_registers, tui_show_register_group)
2680         (tui_display_registers_from, tui_display_reg_element_at_line)
2681         (tui_display_registers_from_line, tui_check_register_values)
2682         (tui_reg_next, tui_reg_prev): Update.
2683         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2684         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2685         tui_data_window.
2686         (struct tui_win_info) <detail>: Remove.  Add new fields from
2687         tui_data_info.
2688         (TUI_DATA_WIN): Add cast.
2689         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2690         (~tui_data_window): Simplify.
2691
2692 2019-06-25  Tom Tromey  <tom@tromey.com>
2693
2694         * tui/tui-layout.c (show_source_disasm_command)
2695         (show_source_or_disasm_and_command): Update.
2696         * tui/tui-io.c (update_cmdwin_start_line)
2697         (tui_redisplay_readline): Update.
2698         * tui/tui-data.h (struct tui_command_info): Remove.
2699         (struct tui_win_info) <detail>: Remove command_info member.
2700         (struct tui_data_window) <start_line>: New member, from
2701         tui_command_info.
2702         (TUI_CMD_WIN): Add casts.
2703
2704 2019-06-25  Tom Tromey  <tom@tromey.com>
2705
2706         * tui/tui-winsource.c (tui_update_source_window)
2707         (tui_refill_source_window)
2708         (tui_source_window_base::do_scroll_horizontal)
2709         (tui_update_breakpoint_info, tui_set_exec_info_content)
2710         (tui_show_exec_info_content, tui_erase_exec_info_content)
2711         (tui_clear_exec_info_content): Update.
2712         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2713         Update.
2714         * tui/tui-win.c (make_invisible_and_set_new_height)
2715         (make_visible_with_new_height): Update.
2716         * tui/tui-source.c (tui_set_source_content)
2717         (tui_show_symtab_source): Update.
2718         * tui/tui-layout.c (extract_display_start_addr)
2719         (show_source_disasm_command, show_data)
2720         (make_source_or_disasm_window)
2721         (show_source_or_disasm_and_command): Update.
2722         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2723         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2724         "gdbarch".
2725         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2726         to tui_source_window_base.
2727         (struct tui_win_info) <detail>: Remove source_info member.
2728         (struct tui_source_window_base) <has_locator>: Inline.
2729         Move contents from tui_source_info; rename has_locator member to
2730         m_has_locator.
2731         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2732         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2733         header file.
2734         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2735         Simplify.
2736         (tui_free_all_source_wins_content): Cast to
2737         tui_source_window_base.
2738
2739 2019-06-25  Tom Tromey  <tom@tromey.com>
2740
2741         * tui/tui-win.c (make_invisible_and_set_new_height)
2742         (make_visible_with_new_height): Call has_locator method.
2743         * tui/tui-layout.c (show_source_disasm_command, show_data)
2744         (show_source_or_disasm_and_command): Update for bool change.
2745         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2746         (tui_win_info) <has_locator>: New method.
2747         (struct tui_source_window_base) <has_locator>: New method.
2748         (tui_win_has_locator): Don't declare.
2749         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2750         from tui_win_has_locator.
2751         (tui_source_window_base): Use false, not FALSE.
2752
2753 2019-06-25  Tom Tromey  <tom@tromey.com>
2754
2755         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2756         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2757         clear_detail method directly.
2758         (tui_clear_win_detail): Remove.
2759
2760 2019-06-25  Tom Tromey  <tom@tromey.com>
2761
2762         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2763         "this", not TUI_DISASM_WIN.
2764
2765 2019-06-25  Tom Tromey  <tom@tromey.com>
2766
2767         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2768         declare.
2769         * tui/tui-winsource.c
2770         (tui_source_window_base::do_scroll_horizontal): Rename from
2771         tui_horizontal_source_scroll.
2772         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2773         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2774         from tui_vertical_data_scroll.
2775         * tui/tui-win.h (tui_scroll): Don't declare.
2776         * tui/tui-win.c (tui_win_info::forward_scroll)
2777         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2778         (tui_win_info::right_scroll): Rename and update.
2779         (tui_scroll_forward_command, tui_scroll_backward_command)
2780         (tui_scroll_left_command, tui_scroll_right_command): Update.
2781         (tui_scroll): Remove.
2782         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2783         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2784         from tui_vertical_source_scroll.
2785         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2786         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2787         from tui_vertical_disassem_scroll.
2788         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2789         do_scroll_horizontal>: New methods.
2790         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2791         Likewise.
2792         (struct tui_source_window_base): Add do_scroll_horizontal.
2793         (struct tui_source_window, struct tui_disasm_window): Add
2794         do_scroll_vertical.
2795         (struct tui_data_window, struct tui_cmd_window): Add
2796         do_scroll_horizontal and do_scroll_vertical.
2797         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2798
2799 2019-06-25  Tom Tromey  <tom@tromey.com>
2800
2801         * tui/tui-data.h (struct tui_source_window_base): New struct.
2802         (struct tui_source_window): Derive from tui_source_window_base.
2803         (struct tui_disasm_window): New struct.
2804         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2805         from tui_source_window::clear_detail.
2806         (tui_source_window_base): Rename from tui_source_window.
2807         (~tui_source_window_base): Rename from ~tui_source_window.
2808         (tui_alloc_win_info): Create a tui_disasm_window.
2809
2810 2019-06-25  Tom Tromey  <tom@tromey.com>
2811
2812         * tui/tui-data.h (struct tui_source_window)
2813         (struct tui_data_window): Declare destructors.
2814         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2815         destructors.
2816         (tui_win_info): Simplify.
2817
2818 2019-06-25  Tom Tromey  <tom@tromey.com>
2819
2820         * tui/tui-winsource.c (tui_display_main)
2821         (tui_update_source_windows_with_addr)
2822         (tui_update_all_breakpoint_info): Update.
2823         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2824         (new_height_ok, parse_scrolling_args): Update.
2825         * tui/tui-stack.c (tui_show_frame_info): Update.
2826         * tui/tui-data.h (struct tui_list): Remove.
2827         (tui_source_windows): Return a reference to a std::vector.
2828         * tui/tui-data.c (source_windows): Now a std::vector.
2829         (tui_source_windows): Change return type.
2830         (tui_clear_source_windows): Rewrite.
2831         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2832         (tui_free_all_source_wins_content): Rewrite.
2833
2834 2019-06-25  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2837         (struct tui_data_window, struct tui_cmd_window): Declare
2838         clear_detail method.
2839         * tui/tui-data.c (tui_source_window::clear_detail)
2840         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2841         methods.
2842         (tui_clear_win_detail): Simplify.
2843
2844 2019-06-25  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui-layout.c (make_source_window, make_disasm_window)
2847         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2848         Return the new window.
2849         (show_source_disasm_command, show_data)
2850         (show_source_or_disasm_and_command): Update.
2851
2852 2019-06-25  Tom Tromey  <tom@tromey.com>
2853
2854         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2855         parameter.  Return the new window.
2856         (show_source_disasm_command): Update and remove NULL check.
2857         (show_source_or_disasm_and_command): Update.
2858
2859 2019-06-25  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2862
2863 2019-06-25  Tom Tromey  <tom@tromey.com>
2864
2865         * tui/tui-data.h (struct tui_win_info): Make constructor
2866         protected.  Make destructor virtual.  Add initializers.
2867         (tui_source_window, tui_data_window, tui_cmd_window): New
2868         classes.
2869         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2870         constructor.  Add "type" parameter.
2871         (tui_source_window, tui_data_window, tui_cmd_window): New
2872         constructors.
2873         (tui_alloc_win_info): Instantiate the appropriate subclass.
2874
2875 2019-06-25  Tom Tromey  <tom@tromey.com>
2876
2877         * tui/tui-win.c (tui_resize_all): Use delete.
2878         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2879         destructor.
2880         (tui_free_window): Don't declare.
2881         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2882         Update.
2883
2884 2019-06-25  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-data.h (struct tui_win_info): Add constructor.
2887         * tui/tui-data.c (tui_alloc_win_info): Use new.
2888         (tui_free_window): Use delete.
2889
2890 2019-06-22  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2893         declare.
2894         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2895
2896 2019-06-22  Tom Tromey  <tom@tromey.com>
2897
2898         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2899         declare.
2900         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2901
2902 2019-06-22  Tom de Vries  <tdevries@suse.de>
2903
2904         * dwarf2read.c (create_addrmap_from_aranges)
2905         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2906         instead of '%zu'.
2907
2908 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2909
2910         * dwarf2read.h (dwarf2_section_info_def): Remove.
2911         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2912         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2913         std::vector<dwarf2_section_info>.
2914         (struct dwo_file) <~dwo_file>: Remove.
2915         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2916         types field.
2917         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2918         (dwarf2_read_debug_names): Likewise.
2919         (create_debug_types_hash_table): Change parameter type to
2920         array_view, adjust code accordingly.
2921         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2922         (partial_die_info::fixup): Likewise.
2923         (determine_prefix): Likewise.
2924         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2925
2926 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2927
2928         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2929         gdb_bfd_ref_ptr.
2930         <~dwo_file>: Remove call to gdb_bfd_unref.
2931         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2932         gdb_bfd_ref_ptr::get.
2933
2934 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2935
2936         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2937         type to htab_up.
2938         * dwarf2read.c (struct dwo_file): Initialize fields.
2939         <~dwo_file>: New.
2940         (free_dwo_file): Remove, move content to ~dwo_file.
2941         (struct dwo_file_deleter): Remove.
2942         (dwo_file_up>: Remove custom deleter.
2943         (free_dwo_files): Remove.
2944         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2945         dwo_files.
2946         (process_skeletonless_type_units): Call unique_ptr::get.
2947         (allocate_dwo_file_hash_table): Add deleter to created hash
2948         table.  Change return type to htab_up.
2949         (lookup_dwo_file_slot): Don't memset dwo_file, call
2950         unique_ptr::get.
2951         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2952         (create_dwo_unit_in_dwp_v2): Likewise.
2953         (open_and_init_dwo_file): Likewise.
2954         (free_dwo_file_from_slot): Remove.
2955
2956 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2957
2958         * dwarf2read.h (struct dwarf2_section_info) <readin,
2959         is_virtual>: Change type to bool.
2960         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2961         true instead of 1.
2962
2963 2019-06-19  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-data.h (tui_init_content_element): Don't declare.
2966
2967 2019-06-19  Tom Tromey  <tom@tromey.com>
2968
2969         * tui/tui-data.h (tui_init_win_info): Don't declare.
2970
2971 2019-06-19  Tom de Vries  <tdevries@suse.de>
2972
2973         * dwarf2read.h (abstract_to_concrete): Change type to
2974         std::unordered_map<sect_offset, std::vector<sect_offset>,
2975         gdb::hash_enum<sect_offset>>.
2976
2977 2019-06-19  Tom Tromey  <tromey@adacore.com>
2978
2979         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2980         EVAL_AVOID_SIDE_EFFECTS specially.
2981
2982 2019-06-19  Tom Tromey  <tromey@adacore.com>
2983
2984         * source-cache.c (highlighter): New global.
2985         (source_cache::get_source_lines): Create a highlighter on demand.
2986
2987 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2988
2989         * defs.h (deprecated_interactive_hook): Delete declaration.
2990         * interps.c (clear_interpreter_hooks): Remove use of
2991         deprecated_interactive_hook.
2992         * top.c (deprecated_interactive_hook): Delete definition.
2993         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2994
2995 2019-06-18  Tom de Vries  <tdevries@suse.de>
2996
2997         PR gdb/24515
2998         * dwarf2read.h (abstract_to_concrete): Change type from
2999         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3000         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3001         * dwarf2read.c (read_variable): Update.
3002         (dwarf2_fetch_die_loc_sect_off): Update.
3003
3004 2019-06-17  Tom de Vries  <tdevries@suse.de>
3005
3006         PR gdb/24617
3007         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3008         accessing parent[parent_len - 1].
3009
3010 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3011
3012         PR gdb/24364
3013         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3014         call dtrace_process_dof with NULL dof.
3015
3016 2019-06-16  Tom de Vries  <tdevries@suse.de>
3017
3018         PR gdb/24445
3019         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3020
3021 2019-06-16  Tom Tromey  <tom@tromey.com>
3022
3023         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3024         (make_all_visible): Use address of member.
3025
3026 2019-06-16  Tom Tromey  <tom@tromey.com>
3027
3028         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3029         (tui_free_window, free_content, free_content_elements): Remove
3030         unnecessary cast.
3031         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3032         cast.
3033         * tui/tui-regs.c (tui_show_register_group)
3034         (tui_display_registers_from, tui_display_reg_element_at_line):
3035         Remove unnecessary cast.
3036
3037 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3038
3039         * linux-nat.c (normal_mask): Delete.
3040         (_initialize_linux_nat): Don't initialise normal_mask.
3041
3042 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3043
3044         PR gdb/24445
3045         * dwarf-index-write.h (write_psymtabs_to_index): Add
3046         dwz_basename parameter.
3047         * dwarf-index-write.c (write_gdbindex): Move file writing to
3048         write_gdbindex_1.  Change return type void.
3049         (assert_file_size): Move up, remove filename parameter.
3050         (write_gdbindex_1): New function.
3051         (write_debug_names): Change return type to void, call
3052         assert_file_size.
3053         (struct index_wip_file): New struct.
3054         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3055         file logic to index_wip_file.  Write index for dwz file if
3056         needed.
3057         (save_gdb_index_command): Pass basename of dwz file, if present.
3058         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3059         build-id of dwz file, if present.
3060         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3061         (dwarf2_get_dwz_file): Likewise.
3062         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3063         (dwarf2_get_dwz_file): Likewise.
3064
3065 2019-06-16  Tom Tromey  <tom@tromey.com>
3066
3067         * coffread.c (process_coff_symbol): Use xstrdup.
3068         * value.c (create_internalvar): Use xstrdup.
3069
3070 2019-06-16  Tom Tromey  <tom@tromey.com>
3071
3072         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3073         * breakpoint.c (stopin_command, stopat_command)
3074         (until_break_command, decode_location_default): Remove unnecessary
3075         cast.
3076         * utils.c (subset_compare): Remove unnecessary cast.
3077         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3078         cast.
3079         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3080         cast.
3081         * infcmd.c (path_command): Remove unnecessary cast.
3082         * coffread.c (decode_type): Remove unnecessary cast.
3083         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3084         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3085         * tui/tui-stack.c (tui_show_locator_content)
3086         (tui_show_frame_info): Remove unnecessary cast.
3087         * tui/tui-win.c (tui_scroll_forward_command)
3088         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3089         (parse_scrolling_args): Remove unnecessary cast.
3090         * tui/tui-data.c (init_win_info, tui_del_window)
3091         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3092         (free_content_elements): Remove unnecessary cast.
3093         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3094         unnecessary cast.
3095         * tui/tui-source.c (tui_set_source_content)
3096         (tui_vertical_source_scroll): Remove unnecessary cast.
3097         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3098         cast.
3099         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3100         * tui/tui-regs.c (tui_display_registers_from)
3101         (tui_display_register): Remove unnecessary cast.
3102         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3103         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3104         (make_visible): Remove unnecessary cast.
3105         * tui/tui-winsource.c (tui_erase_source_content)
3106         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3107         unnecessary cast.
3108         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3109         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3110         * stabsread.c (read_type, read_array_type, read_range_type):
3111         Remove unnecessary cast.
3112         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3113         (parse_symbol, parse_type, upgrade_type, parse_external)
3114         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3115         unnecessary cast.
3116         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3117
3118 2019-06-16  Tom Tromey  <tom@tromey.com>
3119
3120         * tui/tui-data.c (tui_alloc_generic_win_info)
3121         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3122         checks.
3123
3124 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3125             Andrew Burgess  <andrew.burgess@embecosm.com>
3126
3127         * f-typeprint.c (f_print_type): Don't return early for not
3128         associated or not allocated types.
3129         (f_type_print_varspec_suffix): Add print_rank parameter and print
3130         ranks of array types in case they dangling.
3131         (f_type_print_base): Add print_rank parameter.
3132
3133 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3134
3135         * NEWS: Mention new MI commands.
3136         * break-catch-throw.c (enum exception_event_kind): Move to
3137         breakpoint.h.
3138         (print_mention_exception_catchpoint): Output text as a single
3139         message.
3140         (catch_exception_command_1): Rename to...
3141         (catch_exception_event): ...this, make non-static, update header
3142         command, and change some parameter types.
3143         (catch_catch_command): Update for changes to
3144         catch_exception_command_1.
3145         (catch_throw_command): Likewise.
3146         (catch_rethrow_command): Likewise.
3147         * breakpoint.c (enum exception_event_kind): Delete.
3148         * breakpoint.h (enum exception_event_kind): Moved here from
3149         break-catch-throw.c.
3150         (catch_exception_event): Declare.
3151         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3152         (mi_cmd_catch_throw): New function.
3153         (mi_cmd_catch_rethrow): New function.
3154         (mi_cmd_catch_catch): New function.
3155         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3156         'catch-catch' entries.
3157         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3158         (mi_cmd_catch_rethrow): Declare.
3159         (mi_cmd_catch_catch): Declare.
3160
3161 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3162
3163         * annotate.c (annotate_source_line): Change return type to void,
3164         update implementation to match.
3165         * annotate.h (annotate_source_line): Change return type to void,
3166         update header comment.
3167         * stack.c (print_frame_info): Don't change what frame information
3168         is printed based on whether annotations are on or not.
3169
3170 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3171
3172         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3173         (annotate_source): Make static.
3174         (annotate_source_line): Moved from source.c and renamed from
3175         identify_source_line.  Update the return type.
3176         * annotate.h (annotate_source): Delete declaration.
3177         (annotate_source_line): Declaration moved from source.h, and
3178         renamed from identify_source_line.  Return type updated.
3179         * source.c (identify_source_line): Moved to annotate.c and renamed
3180         to annotate_source_line.
3181         (info_line_command): Remove check of annotation_level.
3182         * source.h (identify_source_line): Move declaration to annotate.h
3183         and rename to annotate_source_line.
3184         * stack.c: Add 'annotate.h' include.
3185         (print_frame_info): Remove check of annotation_level before
3186         calling annotate_source_line.
3187
3188 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3189
3190         * source-cache.c (source_cache::get_plain_source_lines): Use
3191         open_source_file_with_line_charpos instead of just
3192         open_source_file, remove call to find_source_lines.
3193         (source_cache::get_source_lines): Likewise.
3194         * source.c (find_source_lines): Make static.
3195         (get_filename_and_charpos): Renamed into...
3196         (open_source_file_with_line_charpos): ..this along with changes to
3197         return a scoped_fd, and some other minor clean ups.
3198         (identify_source_line): Use open_source_file_with_line_charpos.
3199         (search_command_helper): Use open_source_file_with_line_charpos
3200         instead of just open_source_file, remove call to
3201         find_source_lines.
3202         * source.h (open_source_file_with_line_charpos): Declare new
3203         function.
3204         (find_source_lines): Delete declaration.
3205
3206 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3207
3208         * source.c (get_filename_and_charpos): Remove fullname
3209         parameter.
3210         (identify_source_line): Update call to get_filename_and_charpos.
3211
3212 2019-06-14  Tom Tromey  <tromey@adacore.com>
3213
3214         PR gdb/24502:
3215         * ui-style.h (skip_ansi_escape): Update comment.
3216         * ui-file.h (class no_terminal_escape_file): New class.
3217         * ui-file.c (no_terminal_escape_file::write)
3218         (no_terminal_escape_file::puts): New methods.
3219         * cli/cli-logging.c (handle_redirections): Use
3220         no_terminal_escape_file.
3221
3222 2019-06-14  Tom Tromey  <tromey@adacore.com>
3223
3224         * NEWS: Move convenience variable news above Python news.
3225
3226 2019-06-14  Tom Tromey  <tom@tromey.com>
3227
3228         * gnulib: Move directory to top-level.
3229         * configure.ac: Don't configure gnulib.
3230         * configure: Rebuild.
3231         * common/common-defs.h: Use new path to gnulib.
3232         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3233         (GNULIB_H): Remove.
3234         (INCGNU): Look in new gnulib location.
3235         (HFILES_NO_SRCDIR): Remove gnulib files.
3236         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3237         (generated_files): Remove GNULIB_H.
3238         ($(LIBGNU), all-lib): Remove targets.
3239         (distclean): Don't mention GNULIB_BUILDDIR.
3240         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3241
3242 2019-06-14  Tom Tromey  <tromey@adacore.com>
3243
3244         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3245         Warn if symbol file does not provide any symbols.
3246
3247 2019-06-14  Tom Tromey  <tromey@adacore.com>
3248
3249         * source.c (find_and_open_source): Respect basenames_may_differ.
3250
3251 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3252
3253         * annotate.c (annotate_breakpoints_invalid): Make use of
3254         scoped_restore_terminal_state.
3255         (annotate_frames_invalid): Likewise.
3256
3257 2019-06-14  Tom Tromey  <tromey@adacore.com>
3258
3259         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3260         allow assignment to an internalvar.
3261
3262 2019-06-14  Tom Tromey  <tromey@adacore.com>
3263
3264         * ada-lex.l: Allow "_" in attribute names.
3265
3266 2019-06-14  Tom Tromey  <tromey@adacore.com>
3267
3268         PR gdb/24653:
3269         * regcache.c (registers_changed): Don't call alloca.
3270         * top.c (execute_command): Don't call alloca.
3271
3272 2019-06-13  Pedro Alves  <palves@redhat.com>
3273
3274         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3275         'expression'.  When parsing an expression, error out if there's
3276         junk after "unlimited".
3277         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3278         (do_set_command): Adjust calls to is_unlimited_literal.
3279
3280 2019-06-13  Pedro Alves  <palves@redhat.com>
3281
3282         * compile/compile.c (make_compile_options_def_group): Add braces
3283         around array_view initializer.
3284         * thread.c (make_thread_apply_all_options_def_group)
3285         (make_thread_apply_all_options_def_group): Likewise.
3286
3287 2019-06-13  Pedro Alves  <palves@redhat.com>
3288
3289         * NEWS (New commands): Mention "maint test-options
3290         require-delimiter", "maint test-options unknown-is-error", "maint
3291         test-options unknown-is-operand" and "maint show
3292         test-options-completion-result".
3293         (New command options, command completion): New section.
3294         (Completion improvements): New section.
3295         Mention that you can abbreviate "unlimited".
3296
3297 2019-06-13  Pedro Alves  <palves@redhat.com>
3298
3299         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3300         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3301         * unittests/cli-utils-selftests.c (test_parse_flags)
3302         (test_parse_flags_qcs): Delete.
3303         (test_cli_utils): Don't call deleted functions.
3304
3305 2019-06-13  Pedro Alves  <palves@redhat.com>
3306
3307         * thread.c: Include "cli/cli-option.h".
3308         (tp_array_compar_ascending): Global.
3309         (tp_array_compar): Delete function.
3310         (tp_array_compar_ascending, tp_array_compar_descending): New
3311         functions.
3312         (ascending_option_def, qcs_flag_option_def)
3313         (thr_qcs_flags_option_defs)
3314         (make_thread_apply_all_options_def_group)
3315         (make_thread_apply_options_def_group): New.
3316         (thread_apply_all_command): Use gdb::option::process_options.
3317         (thread_apply_command_completer)
3318         (thread_apply_all_command_completer): New.
3319         (thread_apply_command): Use gdb::option::process_options.
3320         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3321         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3322         to generate help text of "thread apply".  Adjust "taas"'s help.
3323         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3324         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3325
3326 2019-06-13  Pedro Alves  <palves@redhat.com>
3327
3328         * thread.c (thread_apply_command): Check for invalid TID with
3329         isdigit instead of !isalpha.
3330
3331 2019-06-13  Pedro Alves  <palves@redhat.com>
3332
3333         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3334         (validate_flags_qcs): New.
3335         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3336         (validate_flags_qcs): Declare.
3337         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3338         (make_frame_apply_options_def_group): New.
3339         (frame_apply_command_count): Process options with
3340         gdb::option::process_options.
3341         (frame_apply_completer): New.
3342         (frame_apply_level_completer, frame_apply_all_completer)
3343         (frame_apply_completer): New.
3344         (_initialize_stack): Update help of "frame apply", "frame apply
3345         level", "frame apply all" and "faas" to mention supported options
3346         and install command completers.
3347         * stack.h (frame_apply_all_completer): Declare.
3348         * thread.c: Include "stack.h".
3349         (tfaas_command): Add "--".
3350         (_initialize_thread): Update help "tfaas" to mention supported
3351         options and install command completer.
3352
3353 2019-06-13  Pedro Alves  <palves@redhat.com>
3354
3355         * completer.c (complete_nested_command_line): New.
3356         (gdb_completion_word_break_characters_throw): Add assertion.
3357         * completer.h (complete_nested_command_line): Declare.
3358
3359 2019-06-13  Pedro Alves  <palves@redhat.com>
3360
3361         * stack.c (parse_backtrace_qualifiers): New.
3362         (backtrace_command): Use it.
3363         (backtrace_command_completer): Complete on qualifiers.
3364
3365 2019-06-13  Pedro Alves  <palves@redhat.com>
3366
3367         * frame.c: Include "cli/cli-option.h.
3368         (user_set_backtrace_options): New.
3369         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3370         Delete.
3371         (get_prev_frame): Adjust.
3372         (boolean_option_def, uinteger_option_def)
3373         (set_backtrace_option_defs): New.
3374         (_initialize_frame): Adjust and use
3375         gdb::option::add_setshow_cmds_for_options to install "set
3376         backtrace past-main" and "set backtrace past-entry".
3377         * frame.h: Include "cli/cli-option.h".
3378         (struct frame_print_options): Forward declare.
3379         (print_frame_arguments_all, print_frame_arguments_scalars)
3380         (print_frame_arguments_none): Declare.
3381         (print_entry_values): Delete declaration.
3382         (struct frame_print_options, user_frame_print_options): New.
3383         (struct set_backtrace_options): New.
3384         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3385         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3386         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3387         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3388         (list_args_or_locals): Add frame_print_options parameter.
3389         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3390         * python/py-framefilter.c (enumerate_args): Pass down
3391         USER_FRAME_PRINT_OPTIONS.
3392         * stack.c: Include "cli/cli-option.h".
3393         (print_frame_arguments_all, print_frame_arguments_scalars)
3394         (print_frame_arguments_none): Declare.
3395         (print_raw_frame_arguments, print_entry_values): Delete.
3396         (user_frame_print_options): New.
3397         (boolean_option_def, enum_option_def, frame_print_option_defs):
3398         New.
3399         (struct backtrace_cmd_options): New.
3400         (bt_flag_option_def): New.
3401         (backtrace_command_option_defs): New.
3402         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3403         (print_frame_arg, read_frame_arg, print_frame_args)
3404         (print_frame_info, print_frame): Add frame_print_options parameter
3405         and use it.
3406         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3407         (backtrace_command_1): Add frame_print_options and
3408         backtrace_cmd_options parameters and use them.
3409         (make_backtrace_options_def_group): New.
3410         (backtrace_command): Process command options with
3411         gdb::option::process_options.
3412         (backtrace_command_completer): New.
3413         (_initialize_stack): Extend "backtrace"'s help to mention
3414         supported options.  Install completer for "backtrace".
3415         Install some settings commands with add_setshow_cmds_for_options.
3416
3417 2019-06-13  Pedro Alves  <palves@redhat.com>
3418
3419         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3420         and that "set/show print raw frame-arguments" are now deprecated.
3421
3422         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3423         command.
3424         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3425         * stack.c (_initialize_stack): Install "set/show print
3426         raw-frame-arguments", and deprecate "set/show print raw
3427         frame-arguments".
3428         * valprint.c (_initialize_valprint): Deprecate "set/show print
3429         raw".
3430
3431 2019-06-13  Pedro Alves  <palves@redhat.com>
3432
3433         * compile/compile.c (struct compile_options): New.
3434         (compile_flag_option_def, compile_command_option_defs)
3435         (make_compile_options_def_group): New.
3436         (compile_file_command): Handle options with
3437         gdb::option::process_options.
3438         (compile_file_command_completer): New function.
3439         (compile_code_command): Handle options with
3440         gdb::option::process_options.
3441         (compile_code_command_completer): New function.
3442         (_initialize_compiler): Install completers for "compile code" and
3443         "compile file".  Mention available options in "compile code" and
3444         "compile code"'s help.
3445         * completer.c (advance_to_completion_word): New, factored out from
3446         ...
3447         (advance_to_expression_complete_word_point): ... this.
3448         (advance_to_filename_complete_word_point): New.
3449         * completer.h (advance_to_filename_complete_word_point): New
3450         declaration.
3451
3452 2019-06-13  Pedro Alves  <palves@redhat.com>
3453
3454         * compile/compile.c: Include "cli/cli-option.h".
3455         (compile_print_value): Scope data pointer is now a
3456         value_print_options pointer; adjust.
3457         (compile_print_command): Process options.  Scope data pointer is
3458         now a value_print_options pointer; adjust.
3459         (_initialize_compile): Update "compile print"'s help to include
3460         supported options.  Install a completer for "compile print".
3461         * cp-valprint.c (show_vtblprint, show_objectprint)
3462         (show_static_field_print): Delete.
3463         (_initialize_cp_valprint): Don't install "set print
3464         static-members", "set print vtbl", "set print object" here.
3465         * printcmd.c: Include "cli/cli-option.h" and
3466         "common/gdb_optional.h".
3467         (print_command_parse_format): Rework to fill in a
3468         value_print_options instead of a format_data.
3469         (print_value): Change parameter type from format_data pointer to
3470         value_print_options reference.  Adjust.
3471         (print_command_1): Process options.  Adjust to pass down a
3472         value_print_options.
3473         (print_command_completer): New.
3474         (_initialize_printcmd): Install print_command_completer as
3475         handle_brkchars completer for the "print" command.  Update
3476         "print"'s help to include supported options.
3477         * valprint.c: Include "cli/cli-option.h".
3478         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3479         here from cp-valprint.c.
3480         (boolean_option_def, uinteger_option_def)
3481         (value_print_option_defs, make_value_print_options_def_group):
3482         New.  Use gdb::option::add_setshow_cmds_for_options to install
3483         "set print elements", "set print null-stop", "set print repeats",
3484         "set print pretty", "set print union", "set print array", "set
3485         print address", "set print symbol", "set print array-indexes".
3486         * valprint.h: Include <string> and "cli/cli-option.h".
3487         (make_value_print_options_def_group): Declare.
3488         (print_value): Change parameter type from format_data pointer to
3489         value_print_options reference.
3490         (print_command_completer): Declare.
3491
3492 2019-06-13  Pedro Alves  <palves@redhat.com>
3493
3494         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3495         (COMMON_SFILES): Add maint-test-settings.c.
3496         * cli/cli-decode.c (boolean_enums): New global, factored out from
3497         ...
3498         (add_setshow_boolean_cmd): ... here.
3499         * cli/cli-decode.h (boolean_enums): Declare.
3500         * cli/cli-option.c: New file.
3501         * cli/cli-option.h: New file.
3502         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3503         factored out from ...
3504         (parse_cli_boolean_value(const char *)): ... this.
3505         (is_unlimited_literal): Change parameter type to pointer to
3506         pointer.  Adjust and advance ARG pointer.
3507         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3508         (parse_cli_var_enum): New, factored out from ...
3509         (do_set_command): ... this.  Adjust.
3510         * cli/cli-setshow.h (parse_cli_boolean_value)
3511         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3512         (parse_cli_var_enum): Declare.
3513         * cli/cli-utils.c: Include "cli/cli-option.h".
3514         (get_ulongest): New.
3515         * cli/cli-utils.h (get_ulongest): Declare.
3516         (check_for_argument): New overloads.
3517         * maint-test-options.c: New file.
3518
3519 2019-06-13  Pedro Alves  <palves@redhat.com>
3520
3521         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3522         parse a range if "-" is at the end of the string.
3523
3524 2019-06-13  Pedro Alves  <palves@redhat.com>
3525
3526         * cli/cli-setshow.c (parse_auto_binary_operation)
3527         (parse_cli_boolean_value): Don't allow "o".
3528
3529 2019-06-13  Pedro Alves  <palves@redhat.com>
3530
3531         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3532         * NEWS: Mention maint test-settings KIND.
3533         * maint-test-settings.c: New file.
3534
3535 2019-06-13  Pedro Alves  <palves@redhat.com>
3536
3537         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3538         completer.
3539         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3540         "set" completers.
3541
3542 2019-06-13  Pedro Alves  <palves@redhat.com>
3543
3544         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3545         after item.
3546
3547 2019-06-13  Pedro Alves  <palves@redhat.com>
3548
3549         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3550
3551 2019-06-13  Pedro Alves <palves@redhat.com>
3552
3553         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3554         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3555         call.
3556         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3557         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3558         calls.
3559         (check_for_argument): Skip spaces after argument.
3560
3561 2019-06-13  Pedro Alves  <palves@redhat.com>
3562
3563         * thread.c (thread_apply_command): Adjust TID parsing.
3564         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3565         detected before end of string.
3566         (tid_is_in_list): Error out if LIST is invalid.
3567
3568 2019-06-13  Pedro Alves  <palves@redhat.com>
3569
3570         * completer.c (complete_line_internal_1): Rewind completion word
3571         point.
3572         (completion_tracker::advance_custom_word_point_by): Change
3573         parameter type to int.
3574         * completer.h (completion_tracker::advance_custom_word_point_by):
3575         Likewise.
3576
3577 2019-06-13  Pedro Alves  <palves@redhat.com>
3578
3579         * completer.c (advance_to_completion_word): Handle delimiters.
3580
3581 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3582
3583         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3584
3585 2019-06-11  Tom Tromey  <tom@tromey.com>
3586
3587         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3588         (xmalloc_failed): Move to alloc.c.
3589         * alloc.c: New file.
3590         * Makefile.in (COMMON_SFILES): Add alloc.c.
3591
3592 2019-06-11  Tom Tromey  <tom@tromey.com>
3593
3594         * nat/linux-waitpid.c: Don't include server.h.
3595         (linux_debug): Remove.
3596         (my_waitpid): Update.
3597
3598 2019-06-11  Tom Tromey  <tromey@adacore.com>
3599
3600         * infcall.c (_initialize_infcall): Remove trailing newline from
3601         help.
3602         * user-regs.c (_initialize_user_regs): Remove trailing newline
3603         from help.
3604         * typeprint.c (_initialize_typeprint): Remove trailing newline
3605         from help.
3606         * reverse.c (_initialize_reverse): Remove trailing newlines from
3607         help.
3608         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3609         from help.
3610         * language.c (add_set_language_command): Remove trailing newline
3611         from help.
3612         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3613         help.
3614         * disasm.c (_initialize_disasm): Remove trailing newline from
3615         help.
3616         * top.c (init_main): Remove trailing newline from help.
3617         * interps.c (_initialize_interpreter): Remove trailing newline
3618         from help.
3619         * btrace.c (_initialize_btrace): Remove trailing newlines from
3620         help.
3621         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3622         from help.
3623         * python/python.c (_initialize_python): Remove trailing newline
3624         from help.
3625         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3626         help.
3627         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3628         from help.  Reformat some text.
3629         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3630         from help.
3631         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3632         newline from help.
3633
3634 2019-06-11  Tom Tromey  <tromey@adacore.com>
3635
3636         * darwin-nat.c (darwin_decode_exception_message)
3637         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3638
3639 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3640
3641         * valops.c (value_slice): Check for not allocated or not
3642         associated values.
3643
3644 2019-06-10  Tom de Vries  <tdevries@suse.de>
3645
3646         PR gdb/24618
3647         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3648         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3649         invalid.
3650
3651 2019-06-10  Tom de Vries  <tdevries@suse.de>
3652
3653         PR gdb/24611
3654         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3655         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3656
3657 2019-06-10  Tom de Vries  <tdevries@suse.de>
3658
3659         PR symtab/24545
3660         * symtab.c (struct demangled_name_entry): Add language field.
3661         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3662         static minimal symbol".  Set and use language field.
3663
3664 2019-06-10  Tom Tromey  <tromey@adacore.com>
3665
3666         * ada-lang.c (_initialize_ada_language): Update help text.
3667
3668 2019-06-10  Tom Tromey  <tromey@adacore.com>
3669
3670         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3671         with a newline.
3672         * guile/guile.c (handle_boot_error): Don't end warning with a
3673         newline.
3674         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3675         warning with a newline.
3676         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3677         newline.
3678         (s12z_frame_cache): Likewise.
3679         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3680         a newline.
3681         * solib-svr4.c (disable_probes_interface): Don't end warning with
3682         a newline.
3683         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3684         newline.
3685         * python/python.c (do_finish_initialization): Don't end warning
3686         with a newline.
3687
3688 2019-06-10  Tom Tromey  <tom@tromey.com>
3689
3690         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3691         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3692         gdbpy_enter.
3693
3694 2019-06-10  Tom Tromey  <tromey@adacore.com>
3695
3696         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3697         data.
3698         (elf_new_init): Don't call stabsread_new_init.
3699         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3700         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3701         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3702
3703 2019-06-10  Tom de Vries  <tdevries@suse.de>
3704
3705         PR symtab/16264
3706         PR symtab/24517
3707         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3708
3709 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3710
3711         * source.c (find_and_open_source): Also rewrite relative file
3712         names.
3713
3714 2019-04-26  Amos Bird  <amosbird@gmail.com>
3715
3716         * annotate.c (annotate_thread_exited): Add "thread-exited"
3717         annotation.
3718
3719 2019-06-06  Tom Tromey  <tromey@adacore.com>
3720
3721         * maint.h (class scoped_command_stats): Use
3722         DISABLE_COPY_AND_ASSIGN.
3723         <print_time>: New method.
3724         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3725         print_time.
3726         (scoped_command_stats::print_time): New method.
3727
3728 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3729
3730         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3731         instructions of lengths 6 or 8 bytes.
3732
3733 2019-06-04  Pedro Alves  <palves@redhat.com>
3734
3735         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3736
3737         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3738         * breakpoint.c (condition_completer): Likewise.
3739         * cli/cli-dump.c (scan_expression): Likewise.
3740         * common/filestuff.c (mkdir_recursive): Likewise.
3741         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3742         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3743         (gdb_abspath): Likewise.
3744         * compile/compile-cplus-types.c
3745         (compile_cplus_instance::decl_name): Likewise.
3746         * completer.c (complete_explicit_location):
3747         (signal_completer, reg_or_group_completer_1): Likewise.
3748         * cp-support.c (cp_remove_params_if_any): Likewise.
3749         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3750         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3751         * infcmd.c (strip_bg_char): Likewise.
3752         * linespec.c (copy_token_string): Likewise.
3753         * mi/mi-main.c (output_cores): Likewise.
3754         * psymtab.c (psymtab_search_name):
3755         * symfile.c (test_set_ext_lang_command): Likewise.
3756         * target.c (target_fileio_read_stralloc): Likewise.
3757         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3758         * value.c (complete_internalvar): Likewise.
3759
3760 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3761
3762         Add objfile property to gdb.Type.
3763         * NEWS: Mention Python API addition.
3764         * python/py-type.c (typy_get_objfile): New method.
3765
3766 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3767
3768         * NEWS: Mention the new set|show style [title|highlight].
3769         Mention changes to "show style", "help" and "apropos".
3770
3771 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3772
3773         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3774         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3775         instead of print_help_for_command.
3776         (print_doc_of_command): New function.
3777         (help_list): Add 'apropos -v word' suggestion.
3778         (print_help_for_command): Style the command name using title style.
3779         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3780         (_initialize_cli_cmds): Describe -v in apropos_command help.
3781
3782 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3783
3784         * cli/cli-style.h (cli_style_option): Add name in constructor,
3785         add m_name class member, add constructor with intensity,
3786         add name class function.
3787         (cli_style_option::add_setshow_commands): Remove name argument.
3788         (highlight_style, title_style): New styles.
3789         * cli/cli-style.c (do_show): New function that shows a style
3790         characteristic styling the style name with itself.
3791         (set_style_name): New function.
3792         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3793         Update all callers according to the changes in cli/cli-style.h.
3794         * utils.h (fputs_highlighted): New function.
3795         * utils.c (fputs_highlighted): Likewise.
3796
3797 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3798
3799         * NEWS: Mention new pipe command and new convenience variables.
3800
3801 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3802
3803         * cli/cli-cmds.c (pipe_command): New function.
3804         (_initialize_cli_cmds): Call add_com for pipe_command.
3805         Define | as an alias for pipe.
3806         (exit_status_set_internal_vars): New function.
3807         (shell_escape): Call exit_status_set_internal_vars.
3808         cli/cli-decode.c (find_command_name_length): Recognize | as
3809         a single character command.
3810
3811 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3812
3813         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3814         top.c (execute_command_to_ui_file): New function, mostly a copy
3815         of execute_command_to_string.
3816         (execute_command_to_string): Implement by calling
3817         execute_command_to_ui_file.
3818
3819 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3820
3821         * top.h (saved_command_line): Remove declaration.
3822         * top.c (previous_saved_command_line, previous_repeat_arguments):
3823         New variables.
3824         (saved_command_line): Make static, define together with other
3825         'repeat variables'.
3826         (dont_repeat): Clear repeat_arguments.
3827         (repeat_previous, get_saved_command_line, save_command_line):
3828         New functions.
3829         (gdb_init): Initialize saved_command_line
3830         and previous_saved_command_line.
3831         * main.c (captured_main_1): Remove saved_command_line initialization.
3832         * event-top.c (handle_line_of_input): Update to use
3833         the new 'repeat' related functions instead of direct access to
3834         saved_command_line.
3835         * command.h (repeat_previous, get_saved_command_line,
3836         save_command_line): New declarations.
3837         (dont_repeat): Add comment.
3838
3839 2019-05-30  Tom Tromey  <tromey@adacore.com>
3840
3841         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3842         Fix comment.
3843         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3844
3845 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3846
3847         PR cli/24587
3848         * completer.c (complete): Initialize variable word.
3849
3850 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3851
3852         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3853         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3854         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3855         'body' is NULL to the outter 'if', protecting the '!is_define'
3856         situation as well.
3857
3858 2019-05-29  Tom Tromey  <tromey@adacore.com>
3859
3860         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3861         (dwarf_unknown): New function.
3862         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3863         (dwarf_type_encoding_name): Use dwarf_unknown.
3864
3865 2019-05-29  Tom Tromey  <tromey@adacore.com>
3866
3867         PR c++/20020:
3868         * cp-valprint.c (cp_print_value_fields): Call
3869         cp_print_static_field inside "try".
3870
3871 2019-05-29  Tom Tromey  <tromey@adacore.com>
3872
3873         * inflow.c (struct terminal_info): Add default operator=.
3874         * configure: Rebuild.
3875         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3876         -Wdeprecated-copy-dtor, -Wredundant-move.
3877
3878 2019-05-29  Tom Tromey  <tromey@adacore.com>
3879
3880         * NEWS: Add entry.
3881         * infcmd.c (print_return_value_1): Handle finish_print
3882         option.
3883         (show_print_finish): New function.
3884         (_initialize_infcmd): Add "set/show print finish" commands.
3885         * valprint.c (user_print_options): Initialize new member.
3886         * valprint.h (struct value_print_options) <finish_print>: New
3887         member.
3888
3889 2019-05-28  Tom Tromey  <tromey@adacore.com>
3890
3891         * ada-lang.c (ada_remove_Xbn_suffix)
3892         (find_old_style_renaming_symbol)
3893         (parse_old_style_renaming): Remove.
3894         (ada_find_renaming_symbol): Don't call
3895         find_old_style_renaming_symbol.
3896         (ada_is_renaming_symbol): Rename from
3897         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3898         bool.  Now static.
3899         (ada_read_var_value): Update and simplify.
3900         * ada-exp.y (write_var_or_type): Remove old code.
3901
3902 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3903
3904         * event-top.c: Remove include comment.
3905         * inflow.c (class scoped_ignore_sigttou): Move from here...
3906         * inflow.h (class scoped_ignore_sigttou): ...to here.
3907         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3908         * top.c:  Remove include comment.
3909
3910 2019-05-27  Tom Tromey  <tom@tromey.com>
3911
3912         * NEWS: Fix typo.
3913
3914 2019-05-22  Tom Tromey  <tromey@adacore.com>
3915
3916         * target.c (target_follow_exec): Constify parameter.
3917         * target-delegates.c: Rebuild.
3918         * remote.c (remote_target::follow_exec): Constify parameter.
3919         * infrun.c (follow_exec): Constify parameter.
3920         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3921         (target_follow_exec): Likewise.
3922
3923 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3924
3925         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3926         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3927
3928 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3929
3930         * NEWS: Add debugredirect and testsuite sections.
3931
3932 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3933
3934         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3935         target descriptions using exclusively floating point register name
3936         aliases.
3937
3938 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         PR gdb/18644:
3941         * f-lang.c (build_fortran_types): Handle the case where
3942         gdbarch_floatformat_for_type returns a nullptr.
3943
3944 2019-05-21  Tom de Vries  <tdevries@suse.de>
3945
3946         PR cli/24587
3947         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3948
3949 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3950
3951         PR gdb/18644:
3952         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3953         16-byte floats.
3954         * i386-tdep.c (i386_floatformat_for_type): Use
3955         floatformats_ia64_quad for the 16-byte floating point component
3956         within a fortran 32-byte complex number.
3957
3958 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3959
3960         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3961         delete default constructor.
3962         (find_partial_die): Update to return const struct.
3963         (partial_die_parent_scope): Move variable declaration into scope
3964         of its use and change its type to auto.
3965         (guess_partial_die_structure_name): Likewise.
3966         (partial_die_info::fixup): Likewise.
3967
3968 2019-05-17  Tom Tromey  <tromey@adacore.com>
3969
3970         * source.c (find_and_open_source): Remove cast.
3971
3972 2019-05-17  Tom Tromey  <tromey@adacore.com>
3973
3974         * annotate.c (annotate_source): Make "filename" const.
3975         * annotate.h (annotate_source): Use const.
3976
3977 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3978
3979         * disasm.c (set_disassembler_options): Send errors to stderr.
3980
3981 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3982
3983         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3984         (cli_interp_base::set_logging): Check debug_redirect.
3985         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3986         * cli/cli-logging.c (debug_redirect): Add static variable.
3987         (pop_output_files): Add default param.
3988         (handle_redirections): Print debug setting.
3989         (show_logging_command): Likewise.
3990         (_initialize_cli_logging): Add debugredirect command.
3991         * interps.c (current_interp_set_logging): Add debug_redirect
3992         parameter.
3993         * interps.h (set_logging): Add debug_redirect parameter.
3994         (current_interp_set_logging): Likewise.
3995         * mi/mi-common.h: Likewise.
3996         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3997
3998 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3999             Tom Tromey  <tromey@adacore.com>
4000
4001         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4002         directly.
4003         * cli/cli-interp.h (make_logging_output): Remove declaration.
4004         * cli/cli-logging.c (make_logging_output): Remove function.
4005         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4006         directly.
4007         * ui-file.c (tee_file::tee_file): Remove bools.
4008         (tee_file::~tee_file): Remove deletes.
4009         * ui-file.h (tee_file): Remove bools.
4010
4011 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4012
4013         * mi/mi-cmds.h (mi_cmd_complete): New function.
4014         * mi/mi-main.c (mi_cmd_complete): Likewise.
4015         * mi/mi-cmds.c: Define new MI command -complete.
4016         * NEWS: Mention new -complete command.
4017
4018 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4019
4020         * completer.h (complete): New function.
4021         * completer.c (complete): Likewise.
4022         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4023         function defined in completer.h.
4024
4025 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4026
4027         * MAINTAINERS (Write After Approval): Add myself.
4028
4029 2019-05-17  Tom de Vries  <tdevries@suse.de>
4030
4031         PR gdb/24094
4032         * dwarf2read.c (struct cu_partial_die_info): New struct.
4033         (find_partial_die): Return cu_partial_die_info.
4034         (partial_die_parent_scope, guess_partial_die_structure_name)
4035         (partial_die_info::fixup): Handle new return type of find_partial_die.
4036
4037 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4038
4039         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4040         "std::string", simplifying the algorithm.
4041
4042 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4043
4044         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4045         (stap_static_probe_ops::get_probes): Likewise.
4046
4047 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4048
4049         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4050         '-')" and "else if".
4051         (stap_parse_single_operand): Join checks for
4052         "gdbarch_stap_parse_special_token_p" and
4053         "gdbarch_stap_parse_special_token" in the same "if" statement.
4054         Invert check when verifying for operation on register
4055         displacement.
4056
4057 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4058
4059         * stap-probe.c (stap_get_opcode): Update comment.
4060         (stap_get_expected_argument_type): Likewise.
4061         (handle_stap_probe): Likewise.
4062
4063 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4064
4065         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4066         return type to 'bool'.  Adjust comment.  Use 'bool' when
4067         appropriate.
4068         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4069         * stap-probe.c (stap_parse_argument_1): Likewise.
4070         (stap_is_operator): Likewise.
4071         (stap_is_generic_prefix): Likewise.
4072         (stap_is_register_prefix): Likewise.
4073         (stap_is_register_indirection_prefix): Likewise.
4074         (stap_is_integer_prefix): Likewise.
4075         (stap_generic_check_suffix): Likewise.
4076         (stap_check_integer_suffix): Likewise.
4077         (stap_check_register_suffix): Likewise.
4078         (stap_check_register_indirection_suffix): Likewise.
4079         (stap_parse_register_operand): Likewise.
4080         (stap_parse_single_operand): Likewise.
4081         (stap_parse_argument_1): Likewise.
4082         (stap_probe::get_argument_count): Likewise.
4083         (stap_is_operator): Likewise.
4084
4085 2019-05-16  Tom Tromey  <tromey@adacore.com>
4086
4087         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4088         keyword to foreach.
4089
4090 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4091
4092         * linux-thread-db.c (try_thread_db_load_1): Change return type
4093         to bool.
4094         (try_thread_db_load): Likewise.
4095         (try_thread_db_load_from_pdir_1): Likewise.
4096         (try_thread_db_load_from_pdir): Likewise.
4097         (try_thread_db_load_from_sdir): Likewise.
4098         (try_thread_db_load_from_dir): Likewise.
4099         (thread_db_load_search): Likewise.
4100         (has_libpthread): Likewise.
4101         (thread_db_load): Likewise.
4102
4103 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4104
4105         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4106         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4107         NULL, and complain/return if that's the case.
4108
4109 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4110
4111         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4112         (advance, posn, abstract_read_memory): New functions.
4113         [struct mem_read_abstraction]: New struct.
4114         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4115
4116 2019-05-14  Tom Tromey  <tromey@adacore.com>
4117
4118         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4119         value is not lval_memory.
4120
4121 2019-05-14  Tom Tromey  <tromey@adacore.com>
4122
4123         * solib.c (info_sharedlibrary_command): Style the file name.
4124
4125 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4126
4127         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4128         (aarch64_vnv_type): Likewise.
4129         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4130         * common/tdesc.c: Likewise.
4131         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4132         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4133         * features/aarch64-fpu.xml: Add ieee half view.
4134         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4135         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4136         * gdbtypes.h (struct builtin_type): Likewise.
4137         (struct objfile_type): Likewise.
4138
4139 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4140
4141         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4142         typo.
4143         * location.h (string_to_event_location): Likewise.
4144
4145 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4146
4147         GDB 8.3 released.
4148
4149 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4150
4151         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4152         New variable declaration.
4153         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4154         New variable.
4155         (print_one_breakpoint): Use ui_out::test_flags and new global
4156         variable to compute use_fixed_output.
4157         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4158         Remove.
4159         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4160         (mi_multi_location_breakpoint_output_fixed): Remove.
4161         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4162         new variable.
4163         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4164         fix_multi_location_breakpoint_output flag if version >= 3.
4165         * ui-out.h (enum ui_out_flag)
4166         <fix_multi_location_breakpoint_output>: New enumerator.
4167
4168 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4169
4170         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4171
4172 2019-05-10  Tom Tromey  <tromey@adacore.com>
4173
4174         * ada-lang.c (catch_ada_completer): New function.
4175         (_initialize_ada_language): Use it.
4176
4177 2019-05-10  Tom Tromey  <tromey@adacore.com>
4178
4179         * thread.c (print_thread_info): Make "requested_threads" const.
4180         * gdbthread.h (print_thread_info): Make "requested_threads"
4181         const.
4182         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4183         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4184
4185 2019-05-08  Tom Tromey  <tom@tromey.com>
4186
4187         * gdbtypes.c (objfile_type_data): Change type.
4188         (objfile_type, _initialize_gdbtypes): Update.
4189
4190 2019-05-08  Tom Tromey  <tom@tromey.com>
4191
4192         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4193         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4194         (_initialize_dwarf2_frame): Update.
4195
4196 2019-05-08  Tom Tromey  <tom@tromey.com>
4197
4198         * objc-lang.c (objc_objfile_data): Change type.
4199         (find_methods): Update.
4200         (_initialize_objc_lang): Remove.
4201
4202 2019-05-08  Tom Tromey  <tom@tromey.com>
4203
4204         * stabsread.c (rs6000_builtin_type_data): Change type.
4205         (rs6000_builtin_type, _initialize_stabsread): Update.
4206
4207 2019-05-08  Tom Tromey  <tom@tromey.com>
4208
4209         * mips-tdep.c (mips_pdr_data): Remove.
4210         (_initialize_mips_tdep): Update.
4211
4212 2019-05-08  Tom Tromey  <tom@tromey.com>
4213
4214         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4215         (hppa_init_objfile_priv_data, read_unwind_info)
4216         (find_unwind_entry, _initialize_hppa_tdep): Update.
4217
4218 2019-05-08  Tom Tromey  <tom@tromey.com>
4219
4220         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4221         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4222         on obstack.
4223         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4224
4225 2019-05-08  Tom Tromey  <tom@tromey.com>
4226
4227         * mdebugread.c (basic_type_data): Change type.
4228         (basic_type, _initialize_mdebugread): Update.
4229
4230 2019-05-08  Tom Tromey  <tom@tromey.com>
4231
4232         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4233
4234 2019-05-08  Tom Tromey  <tom@tromey.com>
4235
4236         * nto-tdep.c (nto_inferior_data_reg): Change type.
4237         (nto_inferior_data): Update.
4238         (nto_inferior_data_cleanup, nto_new_inferior_data)
4239         (_initialize_nto_tdep): Remove.
4240         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4241
4242 2019-05-08  Tom Tromey  <tom@tromey.com>
4243
4244         * ada-lang.c (struct ada_inferior_data): Add initializers.
4245         (ada_inferior_data): Change type.
4246         (ada_inferior_data_cleanup): Remove.
4247         (get_ada_inferior_data, ada_inferior_exit)
4248         (struct ada_pspace_data): Add initializers, destructor.
4249         (ada_pspace_data_handle): Change type.
4250         (get_ada_pspace_data): Update.
4251         (ada_pspace_data_cleanup): Remove.
4252
4253 2019-05-08  Tom Tromey  <tom@tromey.com>
4254
4255         * coffread.c (struct coff_symfile_info): Add initializers.
4256         (coff_objfile_data_key): Move lower.  Change type.
4257         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4258         Update.
4259         (coff_free_info): Remove.
4260
4261 2019-05-08  Tom Tromey  <tom@tromey.com>
4262
4263         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4264         (fbsd_pspace_data_handle): Move lower.  Change type.
4265         (get_fbsd_pspace_data): Update.
4266         (fbsd_pspace_data_cleanup): Remove.
4267         (_initialize_fbsd_tdep): Update.
4268
4269 2019-05-08  Tom Tromey  <tom@tromey.com>
4270
4271         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4272         (get_ada_tasks_pspace_data): Update.
4273         (ada_tasks_pspace_data_cleanup): Remove.
4274         (_initialize_tasks): Update.
4275         (ada_tasks_inferior_data_handle): Change type.
4276         (get_ada_tasks_inferior_data): Update.
4277         (ada_tasks_inferior_data_cleanup): Remove.
4278         (struct ada_tasks_pspace_data): Add initializers.
4279
4280 2019-05-08  Tom Tromey  <tom@tromey.com>
4281
4282         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4283         * symfile-debug.c (debug_sym_get_probes): Change type.
4284         * stap-probe.c (handle_stap_probe):
4285         (stap_static_probe_ops::get_probes): Change type.
4286         * probe.h (class static_probe_ops) <get_probes>: Change type.
4287         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4288         (parse_probes_in_pspace): Update.
4289         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4290         Update.
4291         (any_static_probe_ops::get_probes): Change type.
4292         * elfread.c (elfread_data): New typedef.
4293         (probe_key): Change type.
4294         (elf_get_probes): Likewise.  Update.
4295         (probe_key_free): Remove.
4296         (_initialize_elfread): Update.
4297         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4298         Change type.
4299         (dtrace_process_dof_probe, dtrace_process_dof)
4300         (dtrace_static_probe_ops::get_probe): Change type.
4301
4302 2019-05-08  Tom Tromey  <tom@tromey.com>
4303
4304         * xcoffread.c (struct xcoff_symfile_info): Rename from
4305         coff_symfile_info.  Add initializers.
4306         (xcoff_objfile_data_key): Move lower.  Change type.
4307         (XCOFF_DATA): Rewrite.
4308         (xcoff_free_info): Remove.
4309         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4310         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4311         (xcoff_initial_scan): Update.
4312
4313 2019-05-08  Tom Tromey  <tom@tromey.com>
4314
4315         * solib-svr4.c (struct svr4_info): Add initializers and
4316         destructor.
4317         <probes_table>: Now an htab_up.
4318         (solib_svr4_pspace_data): Change type.
4319         (free_probes_table): Simplify.
4320         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4321         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4322         (probes_table_remove_objfile_probes, register_solib_event_probe)
4323         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4324         (_initialize_svr4_solib): Update.
4325
4326 2019-05-08  Tom Tromey  <tom@tromey.com>
4327
4328         * remote.c (remote_pspace_data): Change type.
4329         (remote_pspace_data_cleanup): Remove.
4330         (get_remote_exec_file, set_pspace_remote_exec_file)
4331         (_initialize_remote): Update.
4332
4333 2019-05-08  Tom Tromey  <tom@tromey.com>
4334
4335         * breakpoint.c (breakpoint_objfile_key): Change type.
4336         (get_breakpoint_objfile_data): Update.
4337         (free_breakpoint_objfile_data): Remove.
4338         (_initialize_breakpoint): Update.
4339
4340 2019-05-08  Tom Tromey  <tom@tromey.com>
4341
4342         * linux-tdep.c (struct linux_info): Add initializers.
4343         (linux_inferior_data): Move.  Change type.
4344         (invalidate_linux_cache_inf): Update.
4345         (linux_inferior_data_cleanup): Remove.
4346         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4347
4348 2019-05-08  Tom Tromey  <tom@tromey.com>
4349
4350         * auxv.c (auxv_inferior_data): Move.  Change type.
4351         (auxv_inferior_data_cleanup): Remove.
4352         (invalidate_auxv_cache_inf): Rewrite.
4353         (get_auxv_inferior_data, _initialize_auxv): Update.
4354
4355 2019-05-08  Tom Tromey  <tom@tromey.com>
4356
4357         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4358         (symfile_debug_objfile_data_key): Change type.
4359         (symfile_debug_installed, debug_qf_has_symbols)
4360         (debug_qf_find_last_source_symtab)
4361         (debug_qf_forget_cached_source_info)
4362         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4363         (debug_qf_print_stats, debug_qf_dump)
4364         (debug_qf_expand_symtabs_for_function)
4365         (debug_qf_expand_all_symtabs)
4366         (debug_qf_expand_symtabs_with_fullname)
4367         (debug_qf_map_matching_symbols)
4368         (debug_qf_expand_symtabs_matching)
4369         (debug_qf_find_pc_sect_compunit_symtab)
4370         (debug_qf_map_symbol_filenames)
4371         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4372         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4373         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4374         (debug_sym_read_linetable, debug_sym_relocate): Update.
4375         (symfile_debug_free_objfile): Remove.
4376         (install_symfile_debug_logging, _initialize_symfile_debug):
4377         Update.
4378
4379 2019-05-08  Tom Tromey  <tom@tromey.com>
4380
4381         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4382         allocate_on_obstack.
4383         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4384         (get_dwarf2_per_objfile): Update.
4385         (set_dwarf2_per_objfile): Remove.
4386         (dwarf2_has_info, dwarf2_get_section_info): Update.
4387         (dwarf2_free_objfile): Remove.
4388         (_initialize_dwarf2_read): Update.
4389
4390 2019-05-08  Tom Tromey  <tom@tromey.com>
4391
4392         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4393         initializers.
4394         <unsupported_script_warning_printed,
4395         script_not_found_warning_printed>: Now bool.
4396         (auto_load_pspace_data): Change type.
4397         (~auto_load_pspace_info): Rename from
4398         auto_load_pspace_data_cleanup.
4399         (get_auto_load_pspace_data, init_loaded_scripts_info)
4400         (clear_section_scripts, maybe_print_unsupported_script_warning)
4401         (maybe_print_script_not_found_warning, _initialize_auto_load):
4402         Update.
4403
4404 2019-05-08  Tom Tromey  <tom@tromey.com>
4405
4406         * objfiles.c (objfile_pspace_info): Add destructor and
4407         initializers.
4408         (objfiles_pspace_data): Change type.
4409         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4410         (get_objfile_pspace_data): Update.
4411         (objfiles_bfd_data): Change type.
4412         (get_objfile_bfd_data): Update.
4413         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4414
4415 2019-05-08  Tom Tromey  <tom@tromey.com>
4416
4417         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4418         Change type.
4419         (get_catch_syscall_inferior_data): Update.
4420         (catch_syscall_inferior_data_cleanup): Remove.
4421         (_initialize_break_catch_syscall): Update.
4422
4423 2019-05-08  Tom Tromey  <tom@tromey.com>
4424
4425         * inflow.c (struct terminal_info): Add destructor and
4426         initializers.
4427         (inflow_inferior_data): Change type.
4428         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4429         (get_inflow_inferior_data, inflow_inferior_exit)
4430         (swap_terminal_info, _initialize_inflow): Update.
4431
4432 2019-05-08  Tom Tromey  <tom@tromey.com>
4433
4434         * target-dcache.c (target_dcache_cleanup): Remove.
4435         (target_dcache_aspace_key): Change type.
4436         (target_dcache_init_p, target_dcache_invalidate)
4437         (target_dcache_get, target_dcache_get_or_init)
4438         (_initialize_target_dcache): Update.
4439         * dcache.h (struct dcache_deleter): New.
4440
4441 2019-05-08  Tom Tromey  <tom@tromey.com>
4442
4443         * symtab.c (struct symbol_cache): Add destructor and
4444         initializers.
4445         (symbol_cache_key): Move.  Change type.
4446         (make_symbol_cache, free_symbol_cache): Remove.
4447         (get_symbol_cache): Update.
4448         (symbol_cache_cleanup): Remove.
4449         (ALL_PSPACES, symbol_cache_flush)
4450         (maintenance_print_symbol_cache)
4451         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4452         Update.
4453
4454 2019-05-08  Tom Tromey  <tom@tromey.com>
4455
4456         * symtab.c (struct main_info): Add destructor and initializers.
4457         (main_progspace_key): Move.  Change type.
4458         (get_main_info): Update.
4459         (main_info_cleanup): Remove.
4460         (_initialize_symtab): Update.
4461
4462 2019-05-08  Tom Tromey  <tom@tromey.com>
4463
4464         * registry.h (DECLARE_REGISTRY): Define the _key class.
4465
4466 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4467
4468         * NEWS: Merge two 'New commands' sections.
4469
4470 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4471
4472         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4473         parameter and use Ada language definition instead.
4474         (ada_val_print_ptr): Remove unused language parameter.
4475         (ada_val_print_num): Remove language parameter and use Ada language
4476         definition instead.
4477         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4478         parameter.
4479         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4480         parameter and use Ada language definition instead.
4481         (ada_val_print_1): Update all ada_val_print_xxx calls.
4482         Remove language parameter.
4483         (ada_val_print): Update ada_val_print_1 call.
4484
4485 2019-05-08  Tom Tromey  <tromey@adacore.com>
4486
4487         * remote.c (remote_hw_watchpoint_limit)
4488         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4489         Now static.
4490
4491 2019-05-08  Tom Tromey  <tromey@adacore.com>
4492
4493         * maint.c (_initialize_maint_cmds): Move initialization code to
4494         remote.c.
4495         (watchdog, show_watchdog): Move to remote.c.
4496         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4497         "watchdog" static.
4498         (_initialize_remote): Move initialization code from maint.c.
4499         * defs.h (watchdog): Don't declare.
4500
4501 2019-05-08  Tom Tromey  <tromey@adacore.com>
4502
4503         * tui/tui-interp.c: Include main.h.
4504         * interps.c: Include main.h.
4505         * main.h (interpreter_p): Declare.
4506         * defs.h (interpreter_p): Don't declare.
4507
4508 2019-05-08  Tom Tromey  <tromey@adacore.com>
4509
4510         * dwarf2loc.c: Include dwarf2read.h.
4511         * defs.h (read_unsigned_leb128): Don't declare.
4512         * dwarf2read.h (read_unsigned_leb128): Declare.
4513
4514 2019-05-08  Tom Tromey  <tromey@adacore.com>
4515
4516         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4517         method.
4518
4519 2019-05-08  Tom Tromey  <tromey@adacore.com>
4520
4521         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4522         when no wrap column is set.
4523
4524 2019-05-08  Tom Tromey  <tromey@adacore.com>
4525
4526         * c-lang.c (c_get_string): Handle non-C-style arrays.
4527
4528 2019-05-08  Tom Tromey  <tromey@adacore.com>
4529
4530         * typeprint.c (print_offset_data::update): Print the bit offset,
4531         not the number of bits remaining.
4532
4533 2019-05-08  Tom Tromey  <tromey@adacore.com>
4534
4535         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4536         padding at end of comment.
4537
4538 2019-05-08  Tom Tromey  <tromey@adacore.com>
4539
4540         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4541         Compare main types.
4542
4543 2019-05-06  Tom Tromey  <tom@tromey.com>
4544
4545         * common/scoped_mmap.c: Include common-defs.h.
4546         * common/scoped_mmap.h: Don't include config.h.
4547
4548 2019-05-04  Tom Tromey  <tom@tromey.com>
4549
4550         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4551         (struct aarch64_call_info): Add initializers.
4552         <si>: Now a std::vector.
4553         (pass_on_stack, aarch64_push_dummy_call): Update.
4554
4555 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4556             Tom Tromey  <tom@tromey.com>
4557
4558         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4559         (ppc_threads): Now a std::vector.  Now static.
4560         (hwdebug_find_thread_points_by_tid)
4561         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4562         Update.
4563
4564 2019-05-04  Tom Tromey  <tom@tromey.com>
4565
4566         * arc-tdep.c (arc_tdesc_init): Return bool.
4567
4568 2019-05-04  Tom Tromey  <tom@tromey.com>
4569
4570         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4571         Use gdb_assert_not_reached.
4572
4573 2019-05-04  Tom Tromey  <tom@tromey.com>
4574
4575         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4576         "false".
4577
4578 2019-05-04  Tom Tromey  <tom@tromey.com>
4579
4580         * arc-tdep.c (arc_tdesc_init): Use bool.
4581
4582 2019-05-04  Tom Tromey  <tom@tromey.com>
4583
4584         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4585
4586 2019-05-04  Tom Tromey  <tom@tromey.com>
4587
4588         * cli/cli-cmds.c (valid_command_p): Return bool.
4589
4590 2019-05-04  Tom Tromey  <tom@tromey.com>
4591
4592         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4593         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4594
4595 2019-05-04  Raul Tambre  <raul@tambre.ee>
4596
4597         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4598         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4599         operator for comparison.
4600
4601 2019-05-04  Tom Tromey  <tom@tromey.com>
4602
4603         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4604         (lookup_partial_symbol, print_partial_symbols)
4605         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4606         (psymbol_compare): Update.
4607         (add_psymbol_to_bcache): Clear the entire psymbol.
4608         (maintenance_check_psymtabs): Update.
4609         * psympriv.h (struct partial_symbol): Don't derive from
4610         general_symbol_info.
4611         <obj_section, unrelocated_address, address,
4612         set_unrelocated_address>: Update.
4613         <ginfo>: New member.
4614         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4615         (debug_names::write_psymbols): Update.
4616
4617 2019-05-04  Tom de Vries  <tdevries@suse.de>
4618
4619         * contrib/cc-with-tweaks.sh: Support -n arg.
4620
4621 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4622
4623         * corelow.c (core_target::detach): Ensure frame cache and
4624         register caches are cleared.
4625         inferior.c (exit_inferior_1): Likewise.
4626
4627 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4628             Tom Tromey  <tom@tromey.com>
4629
4630         * dictionary.c (collate_pending_symbols_by_language): Remove
4631         "struct" from foreach.
4632         * symtab.c (lookup_global_symbol_from_objfile)
4633         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4634         foreach.
4635         * ser-tcp.c (net_open): Remove "struct" from foreach.
4636         * objfiles.c (objfile_relocate, objfile_rebase)
4637         (objfile_has_symbols): Remove "struct" from foreach.
4638         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4639         from foreach.
4640         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4641         foreach.
4642         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4643         "struct" from foreach.
4644         * ada-lang.c (create_excep_cond_exprs)
4645         (ada_exception_catchpoint_cond_string): Remove "struct" from
4646         foreach.
4647
4648 2019-05-03  Tom Tromey  <tromey@adacore.com>
4649
4650         * ada-exp.y (convert_char_literal): Check suffix of each
4651         enumerator.
4652
4653 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4654
4655         PR ada/21406:
4656         * ada-exp.y (yywrap): Don't define.
4657         * ada-lex.l (%option): Add noyywrap
4658         (yywrap): Remove.
4659
4660 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4661
4662         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4663         _WIN32_WINNT to the XP level, unless already defined to a higher
4664         level.
4665
4666         * unittests/parse-connection-spec-selftests.c:
4667         * ser-tcp.c:
4668         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4669         override.
4670
4671         * symfile.c (find_separate_debug_file): Remove colon from the
4672         drive spec of DOS/Windows file names of the target, so that the
4673         file name produced from DEBUGDIR and the target's directory will
4674         be valid on DOS/Windows systems.
4675
4676 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4677
4678         * rust-lang.c (val_print_struct): Handle printing structures
4679         containing strings.
4680
4681 2019-05-02  Tom Tromey  <tromey@adacore.com>
4682
4683         * valarith.c (_initialize_valarith): Remove.
4684
4685 2019-05-01  Tom Tromey  <tromey@adacore.com>
4686
4687         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4688         bitfields.
4689
4690 2019-05-01  Tom Tromey  <tromey@adacore.com>
4691
4692         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4693         for big-endian copies.
4694
4695 2019-04-30  Ali Tamur  <tamur@google.com>
4696         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4697         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4698         (read_3_bytes): New function.
4699
4700 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4701
4702         * windows-nat.c (main_thread_id): Delete.
4703         (handle_output_debug_string): Replace main_thread_id by
4704         current_event.dwThreadId.
4705         (fake_create_process): Likewise.
4706         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4707         Do not set main_thread_id.
4708         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4709         current_event.dwThreadId.
4710         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4711
4712 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4713
4714         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4715         Use current_event.dwThreadId instead of main_thread_id.
4716
4717 2019-04-30  Tom Tromey  <tromey@adacore.com>
4718
4719         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4720         (create_excep_cond_exprs): Iterate over program spaces.
4721         (ada_exception_catchpoint_cond_string): Examine all minimal
4722         symbols for exception types.
4723
4724 2019-04-30  Tom Tromey  <tromey@adacore.com>
4725
4726         PR c++/24470:
4727         * dwarf2read.c (process_structure_scope): Handle case where type
4728         has template parameters but no symbol was created.
4729
4730 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4731             Chris January  <chris.january@arm.com>
4732
4733         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4734         qualifier.
4735         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4736
4737 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4738
4739         * f-typeprint.c (f_print_type): Update rules for printing
4740         whitespace.
4741         (f_type_print_varspec_suffix): Likewise.
4742
4743 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4744             Chris January  <chris.january@arm.com>
4745
4746         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4747         function arguments.
4748
4749 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4750
4751         * f-lang.c (build_fortran_types): Change name of void type to
4752         lower case.
4753         * f-typeprint.c (f_type_print_base): Print the name of the void
4754         type, rather than a fixed string.
4755         * f-valprint.c (f_decorations): Use lower case void string.
4756
4757 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4758             Chris January  <chris.january@arm.com>
4759
4760         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4761         types for Fortran.
4762
4763 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4764             Chris January  <chris.january@arm.com>
4765             David Lecomber  <david.lecomber@arm.com>
4766
4767         * f-exp.y (BINOP_INTRINSIC): New token.
4768         (exp): New parser rule handling BINOP_INTRINSIC.
4769         (f77_keywords): Add new builtin procedures.
4770         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4771         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4772         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4773         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4774         (print_unop_subexp_f): New function.
4775         (print_binop_subexp_f): New function.
4776         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4777         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4778         (dump_subexp_body_f): Likewise.
4779         (operator_check_f): Likewise.
4780         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4781         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4782
4783 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4784
4785         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4786         UNOP_KIND.
4787         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4788         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4789         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4790         (operator_length_f): New fuction.
4791         (print_subexp_f): New function.
4792         (op_name_f): New function.
4793         (dump_subexp_body_f): New function.
4794         (operator_check_f): New function.
4795         (exp_descriptor_f): Replace standard expression handling functions
4796         with new functions.
4797         * gdb/fortran-operator.def: New file.
4798         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4799         * gdb/std-operator.def: Remove UNOP_KIND.
4800
4801 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4802
4803         * std-operator.def: Remove unbalanced, stray double quote
4804         character.
4805
4806 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4807             Chris January  <chris.january@arm.com>
4808             Daniel Everett  <daniel.everett@arm.com>
4809             Nick Forrington  <nick.forrington@arm.com>
4810             Richard Bunt  <richard.bunt@arm.com>
4811
4812         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4813         of depth when printing anonymous structs or unions.
4814         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4815         Don't print either the top-level value, or the children if the
4816         max-depth is exceeded.
4817         (ppscm_print_children): When printing the key of a map, allow one
4818         extra level of depth.
4819         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4820         print either the top-level value, or the children if the max-depth
4821         is exceeded.
4822         (print_children): When printing the key of a map, allow one extra
4823         level of depth.
4824         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4825         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4826         (user_print_options): Initialise max_depth field.
4827         (val_print_scalar_or_string_type_p): New function.
4828         (val_print): Check to see if the max depth has been reached.
4829         (val_print_check_max_depth): Define new function.
4830         (show_print_max_depth): New function.
4831         (_initialize_valprint): Add 'print max-depth' option.
4832         * valprint.h (struct value_print_options) <max_depth>: New field.
4833         (val_print_check_max_depth): Declare new function.
4834         * NEWS: Document new feature.
4835
4836 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4837
4838         * ada-lang.c (ada_language_defn): Initialise new field.
4839         * c-lang.c (c_is_string_type_p): New function.
4840         (c_language_defn): Initialise new field.
4841         (cplus_language_defn): Initialise new field.
4842         (asm_language_defn): Initialise new field.
4843         (minimal_language_defn): Initialise new field.
4844         * c-lang.h (c_is_string_type_p): Declare new function.
4845         * d-lang.c (d_language_defn): Initialise new field.
4846         * f-lang.c (f_is_string_type_p): New function.
4847         (f_language_defn): Initialise new field.
4848         * go-lang.c (go_is_string_type_p): New function.
4849         (go_language_defn): Initialise new field.
4850         * language.c (default_is_string_type_p): New function.
4851         (unknown_language_defn): Initialise new field.
4852         (auto_language_defn): Initialise new field.
4853         * language.h (struct language_defn) <la_is_string_type_p>: New
4854         member variable.
4855         (default_is_string_type_p): Declare new function.
4856         * m2-lang.c (m2_language_defn): Initialise new field.
4857         * objc-lang.c (objc_language_defn): Initialise new field.
4858         * opencl-lang.c (opencl_language_defn): Initialise new field.
4859         * p-lang.c (pascal_is_string_type_p): New function.
4860         (pascal_language_defn): Initialise new field.
4861         * rust-lang.c (rust_is_string_type_p): New function.
4862         (rust_language_defn): Initialise new field.
4863
4864 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4865
4866         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4867         New field.
4868         * ada-lang.c (ada_language_defn): Initialise new field.
4869         * c-lang.c (c_language_defn): Likewise.
4870         (cplus_language_defn): Likewise.
4871         (asm_language_defn): Likewise.
4872         (minimal_language_defn): Likewise.
4873         * d-lang.c (d_language_defn): Likewise.
4874         * f-lang.c (f_language_defn): Likewise.
4875         * go-lang.c (go_language_defn): Likewise.
4876         * language.c (unknown_language_defn): Likewise.
4877         (auto_language_defn): Likewise.
4878         * m2-lang.c (m2_language_defn): Likewise.
4879         * objc-lang.c (objc_language_defn): Likewise.
4880         * opencl-lang.c (opencl_language_defn): Likewise.
4881         * p-lang.c (pascal_language_defn): Likewise.
4882         * rust-lang.c (rust_language_defn): Likewise.
4883
4884 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * ada-lang.c (ada_is_character_type): Change return type to bool.
4887         (ada_is_string_type): Likewise.
4888         * ada-lang.h (ada_is_character_type): Update declaration
4889         (ada_is_string_type): Likewise.
4890
4891 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4892
4893         Support style in 'frame|thread apply'
4894
4895         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4896         * record.c (record_start, record_stop): Update callers of
4897         execute_command_to_string with false.
4898         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4899         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4900         methods.
4901         (class string_file): New constructor with term_out parameter.
4902         Override methods term_out and can_emit_style_escape.  New member
4903         term_out.
4904         (class stdio_file): Override can_emit_style_escape.
4905         (class tee_file): Override term_out and can_emit_style_escape.
4906         * utils.h (can_emit_style_escape): Remove.
4907         * utils.c (can_emit_style_escape): Likewise.
4908         Update all callers of can_emit_style_escape (SOMESTREAM) to
4909         SOMESTREAM->can_emit_style_escape.
4910         * source-cache.c (source_cache::get_source_lines): Likewise.
4911         * stack.c (frame_apply_command_count): Call execute_command_to_string
4912         passing the term_out characteristic of the current gdb_stdout.
4913         * thread.c (thr_try_catch_cmd): Likewise.
4914         * top.c (execute_command_to_string): pass term_out parameter
4915         to construct the string_file for the command output.
4916         * ui-file.c (term_cli_styling): New function (most code moved
4917         from utils.c can_emit_style_escape).
4918         (string_file::string_file, string_file::can_emit_style_escape,
4919         stdio_file::can_emit_style_escape, tee_file::term_out,
4920         tee_file::can_emit_style_escape): New functions.
4921
4922 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4923
4924         * NEWS: Mention the new set|show may-call-functions.
4925         * infcall.c (may_call_functions_p): New variable.
4926         (show_may_call_functions_p): New function.
4927         (call_function_by_hand_dummy): Throws an error if not
4928         may-call-functions.
4929         (_initialize_infcall): Call add_setshow_boolean_cmd for
4930         may-call-functions.
4931
4932 2019-04-25  Keith Seitz  <keiths@redhat.com>
4933
4934         PR c++/24367
4935         * cp-support.c (inspect_type): Don't attempt substitutions
4936         of symbol with the same name.
4937
4938 2019-04-25  Tom Tromey  <tromey@adacore.com>
4939
4940         PR gdb/24475:
4941         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4942         static.
4943
4944 2019-04-25  Tom Tromey  <tromey@adacore.com>
4945
4946         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4947         rvalue reference.
4948         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4949         (gdb_xml_parser::parse): Use std::move.
4950         * python/python-internal.h (gdbpy_convert_exception): Take a const
4951         reference.
4952         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4953         std::move.
4954         * python/py-utils.c (gdbpy_convert_exception): Take a const
4955         reference.
4956         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4957         Use std::move.
4958         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4959         Use std::move.
4960         * mi/mi-main.c (mi_print_exception): Take a const reference.
4961         * main.c (handle_command_errors): Take a const reference.
4962         * linespec.c (parse_linespec): Use std::move.
4963         * infcall.c (run_inferior_call): Use std::move.
4964         (call_function_by_hand_dummy): Use std::move.
4965         * exec.c (try_open_exec_file): Use std::move.
4966         * exceptions.h (exception_print, exception_fprintf)
4967         (exception_print_same): Update.
4968         * exceptions.c (print_exception, exception_print)
4969         (exception_fprintf, exception_print_same): Change parameters to
4970         const reference.
4971         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4972         * common/new-op.c: Use std::move.
4973         * common/common-exceptions.h (struct gdb_exception): Add move
4974         constructor.
4975         (struct gdb_exception_error, struct gdb_exception_quit, struct
4976         gdb_quit_bad_alloc): Change constructor to move constructor.
4977         (throw_exception): Change parameter to rvalue reference.
4978         * common/common-exceptions.c (throw_exception): Take rvalue
4979         reference.
4980         * cli/cli-interp.c (safe_execute_command): Use std::move.
4981         * breakpoint.c (insert_bp_location, location_to_sals): Use
4982         std::move.
4983
4984 2019-04-25  Tom Tromey  <tromey@adacore.com>
4985
4986         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4987         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4988         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4989         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4990         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4991         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4992         guile/scm-value.c: Use unpack.
4993         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4994         gdbscm_gdb_exception.
4995         (gdbscm_throw_gdb_exception): Likewise.
4996         (struct gdbscm_gdb_exception): New.
4997         (unpack): New function.
4998         (gdbscm_wrap): Use unpack.
4999
5000 2019-04-25  Tom Tromey  <tromey@adacore.com>
5001
5002         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5003         (gdb_rl_callback_handler): Use std::move.
5004         * common/common-exceptions.h (struct gdb_exception): Add move
5005         assignment operator.
5006         (throw_exception_sjlj): Change "exception" to const reference.
5007         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5008         (throw_exception_sjlj): Change "exception" to const reference.
5009
5010 2019-04-25  Tom Tromey  <tromey@adacore.com>
5011
5012         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5013         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5014         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5015         Update.
5016         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5017         Update.
5018         * mi/mi-interp.c (mi_interp::exec): Update.
5019         * linespec.c (parse_linespec): Update.
5020         * infcall.c (run_inferior_call): Update.
5021         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5022         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5023         (gdbscm_lookup_global_symbol): Update.
5024         * guile/scm-param.c (gdbscm_parameter_value): Update.
5025         * guile/scm-frame.c (gdbscm_frame_read_register)
5026         (gdbscm_frame_read_var): Update.
5027         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5028         * exec.c (try_open_exec_file): Update.
5029         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5030         (gdb_rl_callback_handler): Update.
5031         * common/common-exceptions.h (exception_none): Don't declare.
5032         * common/common-exceptions.c (exception_none): Don't define.
5033         (struct catcher) <exception>: Update.
5034         * cli/cli-interp.c (safe_execute_command): Update.
5035         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5036
5037 2019-04-25  Ali Tamur  <tamur@google.com>
5038
5039         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5040         (read_attribute_value): Likewise.
5041         (dwarf2_read_addr_index): Update comment.
5042         (read_str_index): Add DW_FORM_strx.
5043         (dwarf2_string_attr): Likewise.
5044         (dwarf2_const_value_attr): Likewise.
5045         (dump_die_shallow): Likewise.
5046         (dwarf2_fetch_constant_bytes): Likewise.
5047         (skip_form_bytes): Likewise.
5048         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5049
5050 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5051
5052         PR corefiles/11608
5053         PR corefiles/18187
5054         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5055         OFFSET.  Verify if current mapping contains an ELF header.
5056         (linux_find_memory_regions_full): Adjust call to
5057         dump_mapping_p.
5058
5059 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5060             Kang Li <kanglictf@gmail.com>
5061
5062         PR gdb/21600
5063
5064         * dwarf2-frame.c (read_initial_length): Be consistent about using
5065         unsigned representation of length.
5066         (decode_frame_entry_1): Likewise.  Check for wraparound of
5067         end pointer as well as buffer overflow.
5068
5069 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5070
5071         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5072         "vq".
5073
5074 2019-04-24  Tom Tromey  <tromey@adacore.com>
5075
5076         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5077
5078 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5079
5080         * s12z-tdep.c (s12z_unwind_pc): Delete.
5081         (s12z_unwind_sp): Delete.
5082         (s12z_gdbarch_init): Don't register deleted functions with
5083         gdbarch.
5084
5085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5086
5087         * rl78-tdep.c (rl78_unwind_sp): Delete.
5088         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5089
5090 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5091
5092         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5093         (xstormy16_unwind_pc): Delete.
5094         (xstormy16_dummy_id): Delete.
5095         (xstormy16_gdbarch_init): Don't register deleted functions with
5096         gdbarch.
5097
5098 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5099
5100         * vax-tdep.c (vax_unwind_pc): Delete.
5101         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5102
5103 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5104
5105         * v850-tdep.c (v850_unwind_sp): Delete.
5106         (v850_unwind_pc): Delete.
5107         (v850_dummy_id): Delete.
5108         (v850_gdbarch_init): Don't register deleted functions with
5109         gdbarch.
5110
5111 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5112
5113         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5114         (tilegx_unwind_pc): Delete.
5115         (tilegx_unwind_dummy_id): Delete.
5116         (tilegx_gdbarch_init): Don't register deleted functions with
5117         gdbarch.
5118
5119 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5120
5121         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5122         (tic6x_dummy_id): Delete.
5123         (tic6x_gdbarch_init): Don't register deleted functions with
5124         gdbarch.
5125
5126 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5127
5128         * sparc-tdep.c (sparc_unwind_pc): Delete.
5129         (sparc32_gdbarch_init): Don't register deleted function with
5130         gdbarch.
5131
5132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5133
5134         * sh-tdep.c (sh_unwind_sp): Delete.
5135         (sh_unwind_pc): Delete.
5136         (sh_dummy_id): Delete.
5137         (sh_gdbarch_init): Don't register deleted functions with
5138         gdbarch.
5139
5140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5141
5142         * score-tdep.c (score_unwind_sp): Delete.
5143         (score_unwind_pc): Delete.
5144         (score_dummy_id): Delete.
5145         (score_gdbarch_init): Don't register deleted functions with
5146         gdbarch.
5147
5148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5149
5150         * rx-tdep.c (rx_unwind_pc): Delete.
5151         (rx_unwind_sp): Delete.
5152         (rx_dummy_id): Delete.
5153         (rx_gdbarch_init): Don't register deleted functions with
5154         gdbarch.  Update comment.
5155
5156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5157
5158         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5159         (rs6000_dummy_id): Delete.
5160         (rs6000_gdbarch_init): Don't register deleted functions with
5161         gdbarch.
5162
5163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5164
5165         * or1k-tdep.c (or1k_dummy_id): Delete.
5166         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5167
5168 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5169
5170         * nios2-tdep.c (nios2_dummy_id): Delete.
5171         (nios2_unwind_sp): Delete.
5172         (nios2_gdbarch_init): Don't register deleted functions with
5173         gdbarch.
5174
5175 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5176
5177         * nds32-tdep.c (nds32_dummy_id): Delete.
5178         (nds32_unwind_pc): Delete.
5179         (nds32_unwind_sp): Delete.
5180         (nds32_gdbarch_init): Don't register deleted functions with
5181         gdbarch.
5182
5183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5184
5185         * msp430-tdep.c (msp430_unwind_pc): Delete.
5186         (msp430_unwind_sp): Delete.
5187         (msp430_dummy_id): Delete.
5188         (msp430_gdbarch_init): Don't register deleted functions with
5189         gdbarch.
5190
5191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5192
5193         * moxie-tdep.c (moxie_unwind_sp): Delete.
5194         (moxie_unwind_pc): Delete.
5195         (moxie_dummy_id): Delete.
5196         (moxie_gdbarch_init): Don't register deleted functions with
5197         gdbarch.
5198
5199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5200
5201         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5202         (mn10300_unwind_pc): Delete.
5203         (mn10300_unwind_sp): Delete.
5204         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5205         mn10300_unwind_sp.
5206         (mn10300_frame_unwind_init): Don't register deleted functions with
5207         gdbarch.
5208
5209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5210
5211         * mep-tdep.c (mep_unwind_pc): Delete.
5212         (mep_unwind_sp): Delete.
5213         (mep_dummy_id): Delete.
5214         (mep_gdbarch_init): Don't register deleted functions with
5215         gdbarch.
5216
5217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5220         (m68hc11_unwind_sp): Delete.
5221         (m68hc11_gdbarch_init): Don't register deleted functions with
5222         gdbarch.
5223
5224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5225
5226         * m32r-tdep.c (m32r_unwind_sp): Delete.
5227         (m32r_unwind_pc): Delete.
5228         (m32r_dummy_id): Delete.
5229         (m32r_gdbarch_init): Don't register deleted functions with
5230         gdbarch.
5231
5232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5233
5234         * m32c-tdep.c (m32c_unwind_pc): Delete.
5235         (m32c_unwind_sp): Delete.
5236         (m32c_dummy_id): Delete.
5237         (m32c_gdbarch_init): Don't register deleted functions with
5238         gdbarch.
5239
5240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5241
5242         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5243         (lm32_unwind_pc): Delete.
5244         (lm32_dummy_id): Delete.
5245         (lm32_gdbarch_init): Don't register deleted functions with
5246         gdbarch.
5247
5248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5249
5250         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5251         (iq2000_unwind_pc): Delete.
5252         (iq2000_dummy_id): Delete.
5253         (iq2000_gdbarch_init): Don't register deleted functions with
5254         gdbarch.
5255
5256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5257
5258         * nds32-tdep.c (nds32_type_align): Delete.
5259         (nds32_push_dummy_call): Use type_align instead.
5260
5261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5262
5263         * arm-tdep.c (arm_type_align): Only handle vector override case.
5264         (arm_push_dummy_call): Use type_align.
5265         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5266
5267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5268
5269         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5270         case.
5271         (pass_on_stack): Use type_align.
5272         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5273         function.
5274
5275 2019-04-23  Tom Tromey  <tromey@adacore.com>
5276
5277         * dwarf2read.c (line_header::file_name_at): Remove unused
5278         overload.
5279
5280 2019-04-23  Tom de Vries  <tdevries@suse.de>
5281
5282         PR gdb/24438
5283         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5284         invocation.
5285
5286
5287 2019-03-27  Ali Tamur  <tamur@google.com>
5288
5289         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5290         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5291         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5292         (dwarf_expr_context::get_addr_index): Likewise
5293         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5294         (symbol_needs_eval_context::get_addr_index): Likewise
5295         (disassemble_dwarf_expression): Add DW_OP_addrx
5296         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5297         (read_cutu_die_from_dwo): Update comment
5298         (skip_one_die): Add DW_FORM_addrx
5299         (read_attribute_value): Likewise
5300         (var_decode_location): Add DW_OP_addrx
5301         (dwarf2_const_value_attr): Add DW_FORM_addrx
5302         (dump_die_shallow): Likewise
5303         (dwarf2_fetch_constant_bytes): Likewise
5304         (decode_locdesc): Add DW_OP_addrx
5305         (skip_form_bytes): Add DW_FORM_addrx
5306
5307 2019-04-22  Ali Tamur  <tamur@google.com>
5308
5309         * MAINTAINERS (Write After Approval): Add self.
5310
5311 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5312
5313         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5314         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5315         (open_symbol_file_object): Likewise.
5316         (svr4_default_sos): Add info parameter.
5317         (svr4_read_so_list): Likewise.
5318         (svr4_current_sos_direct): Adjust functions calls to pass down
5319         info.
5320         (svr4_current_sos_1): Add info parameter.
5321         (svr4_current_sos): Call get_svr4_info, pass info down to
5322         svr4_current_sos_1.
5323         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5324         get_svr4_info.
5325         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5326         get_svr4_info.
5327         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5328         to get_svr4_info.
5329         (probes_table_remove_objfile_probes): Likewise.
5330         (register_solib_event_probe): Add info parameter.
5331         (solist_update_incremental): Pass info parameter down to
5332         svr4_read_so_list.
5333         (disable_probes_interface): Add info parameter.
5334         (svr4_handle_solib_event): Pass current_program_space to
5335         get_svr4_info.  Adjust disable_probes_interface cleanup.
5336         (svr4_create_probe_breakpoints): Add info parameter, pass it
5337         down to register_solib_event_probe.
5338         (svr4_create_solib_event_breakpoints): Add info parameter,
5339         pass it down to svr4_create_probe_breakpoints.
5340         (enable_break): Pass info down to
5341         svr4_create_solib_event_breakpoints.
5342         (svr4_solib_create_inferior_hook): Pass current_program_space to
5343         get_svr4_info.
5344         (svr4_clear_solib): Likewise.
5345
5346 2019-04-22  Pedro Alves  <palves@redhat.com>
5347
5348         * solib-svr4.c (svr4_free_objfile_observer): New.
5349         (probe_and_action::objfile): New field.
5350         (probes_table_htab_remove_objfile_probes)
5351         (probes_table_remove_objfile_probes): New functions.
5352         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5353         in the new probe_and_action.  Don't store the probe in 'lookup'.
5354         (svr4_create_probe_breakpoints): Pass objfile to
5355         register_solib_event_probe.
5356         (_initialize_svr4_solib): Register a free_objfile observer.
5357
5358 2019-04-19  Tom Tromey  <tom@tromey.com>
5359
5360         * common/queue.h: Remove.
5361
5362 2019-04-19  Tom Tromey  <tom@tromey.com>
5363
5364         * event-loop.c: Don't include "common/queue.h".
5365
5366 2019-04-19  Tom Tromey  <tom@tromey.com>
5367
5368         * remote.c (remote_target): Use delete.
5369         * remote-notif.h: Include <list>, not "common/queue.h".
5370         (notif_client_p): Remove typedef.
5371         (remote_notif_state): Add constructor, destructor, initializer.
5372         <notif_queue>: Now a std::list.
5373         (remote_notif_state_xfree): Don't declare.
5374         * remote-notif.c (remote_notif_process, handle_notification)
5375         (remote_notif_state_allocate): Update.
5376         (~remote_notif_state): Rename from remote_notif_state_xfree.
5377
5378 2019-04-19  Tom Tromey  <tom@tromey.com>
5379
5380         * symfile.c (reread_symbols): Update.
5381         * objfiles.c (objfile_register_static_link)
5382         (objfile_lookup_static_link): Update
5383         (~objfile) Don't delete static_links.
5384         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5385
5386 2019-04-19  Tom Tromey  <tom@tromey.com>
5387
5388         * type-stack.h (struct type_stack) <insert>: Constify string.
5389         * type-stack.c (type_stack::insert): Constify string.
5390         * gdbtypes.h (lookup_template_type): Update.
5391         (address_space_name_to_int): Update.
5392         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5393         const.
5394         (lookup_template_type): Make name const.
5395         * c-exp.y: Update rules.
5396         (lex_one_token, classify_name, classify_inner_name)
5397         (c_print_token): Update.
5398         * p-exp.y: Update rules.
5399         (yylex): Update.
5400         * f-exp.y: Update rules.
5401         (yylex): Update.
5402         * d-exp.y: Update rules.
5403         (lex_one_token, classify_name, classify_inner_name): Update.
5404         * parse.c (write_dollar_variable, copy_name): Return std::string.
5405         * parser-defs.h (copy_name): Change return type.
5406         * m2-exp.y: Update rules.
5407         (yylex): Update.
5408         * go-exp.y (lex_one_token): Update.
5409         Update rules.
5410         (classify_unsafe_function, classify_packaged_name)
5411         (classify_name, yylex): Update.
5412
5413 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5414
5415         * configure.ac: add --enable-source-highlight switch.
5416         * configure: Regenerate.
5417         * top.c (print_gdb_version): plumb --enable-source-highlight
5418         status to "show configuration".
5419
5420 2019-04-19  Tom Tromey  <tromey@adacore.com>
5421
5422         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5423         Check ADA_TYPE_P.
5424         (empty_record, ada_template_to_fixed_record_type_1)
5425         (template_to_static_fixed_type)
5426         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5427         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5428         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5429         macros.
5430
5431 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5432
5433         PR symtab/24423:
5434         * source.c (print_source_lines_base): Advance "iter" when a
5435         control character is seen.
5436
5437 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5438
5439         * inferior.h (struct infcall_suspend_state_deleter):
5440         Catch exception in destructor to avoid crash.
5441
5442 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5443
5444         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5445         close to the add_com "shell".
5446
5447 2019-04-18  Tom Tromey  <tromey@adacore.com>
5448
5449         * process-stratum-target.h (class process_stratum_target)
5450         <stratum>: Add "final".
5451
5452 2019-04-17  Tom Tromey  <tromey@adacore.com>
5453
5454         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5455         against nullptr before use.
5456
5457 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5458
5459         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5460
5461 2019-04-17  Jim Wilson  <jimw@sifive.com>
5462             Andrew Burgess  <andrew.burgess@embecosm.com>
5463
5464         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5465         code read might fail, assume 4-byte breakpoint in that case.
5466
5467 2019-04-15  Leszek Swirski  <leszeks@google.com>
5468
5469         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5470         rather than a hand-rolled POD check when checking for forced MEMORY
5471         classification.
5472
5473 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5474
5475         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5476         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5477         function.
5478         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5479         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5480         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5481         declaration.
5482
5483 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5484
5485         * aarch64-linux-nat.c
5486         (aarch64_linux_nat_target::thread_architecture): Add override.
5487         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5488         each VQ.
5489
5490 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5491
5492         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5493
5494 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5495
5496         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5497         target types of size 96-bits, add some additional comments, and
5498         check that the builtin type we found was the correct size.
5499
5500 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5501
5502         * utils.c (prompt_for_continue): Don't restore the styling at the
5503         end, as applied_style has the wrong value.  This fixes styling in
5504         long lists of file names that are interrupted by the "Continue?"
5505         prompt.
5506
5507 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5508
5509         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5510         * c-lang.c (c_language_defn): Likewise.
5511         (cplus_language_defn): Likewise.
5512         (asm_language_defn): Likewise.
5513         (minimal_language_defn): Likewise.
5514         * d-lang.c (d_language_defn): Likewise.
5515         * f-lang.c (f_language_defn): Likewise.
5516         * go-lang.c (go_language_defn): Likewise.
5517         * language.c (unknown_language_defn): Likewise.
5518         (auto_language_defn): Likewise.
5519         * language.h (struct language_defn): Remove la_magic field.
5520         (LANG_MAGIC): Delete.
5521         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5522         * objc-lang.c (objc_language_defn): Likewise.
5523         * opencl-lang.c (opencl_language_defn): Likewise.
5524         * p-lang.c (pascal_language_defn): Likewise.
5525         * rust-lang.c (rust_language_defn): Likewise.
5526
5527 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5528
5529         * riscv-tdep.c (riscv_type_align): New function.
5530         (riscv_type_alignment): Delete.
5531         (riscv_arg_location): Use 'type_align'.
5532         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5533
5534 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5535
5536         * gdbtypes.c (type_align): A struct with no non-static fields also
5537         has alignment of 1.
5538
5539 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5540
5541         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5542         component to 0.
5543         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5544         member.
5545         (riscv_struct_info::analyse): New implementation using new
5546         analyse_inner member function.
5547         (riscv_struct_info::field_offset): New member function.
5548         (riscv_struct_info::m_offsets): New member variable.
5549         (riscv_struct_info::analyse_inner): New private member function,
5550         takes the old implementation of riscv_struct_info::analyse but
5551         extended to track field offsets.
5552         (riscv_call_arg_struct): Update the struct folding special cases
5553         to handle cases where empty C++ structs, which are non-zero
5554         length, are found.
5555         (riscv_arg_location): Initialise the length of each location, a
5556         non-zero length now indicates the location is in use.
5557         (riscv_push_dummy_call): Allow for the first location having a
5558         non-zero offset when setting up arguments.
5559         (riscv_return_value): Likewise, but for return values.
5560
5561 2019-04-11  Tom Tromey  <tromey@adacore.com>
5562
5563         * utils.c (internal_vproblem): Make "msg" const.
5564
5565 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5566
5567         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5568         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5569         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5570         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5571
5572 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5573
5574         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5575         function.
5576         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5577         of amd64_collect_native_gregset.
5578         (amd64_linux_nat_target::store_registers): Likewise.
5579
5580 2019-04-10  Tom Tromey  <tom@tromey.com>
5581
5582         * symtab.c (lookup_global_symbol_from_objfile)
5583         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5584         * objfiles.h (class separate_debug_iterator): New.
5585         (class separate_debug_range): New.
5586         (struct objfile) <separate_debug_objfiles>: New method.
5587         (objfile_separate_debug_iterate): Don't declare.
5588         * objfiles.c (separate_debug_iterator::operator++): Rename from
5589         objfile_separate_debug_iterate.
5590         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5591         iterator.
5592         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5593         iterator.
5594
5595 2019-04-10  Tom Tromey  <tom@tromey.com>
5596
5597         * symfile.c (reread_symbols): Remove old comment.
5598         * objfiles.c (free_all_objfiles): Fix a typo.
5599
5600 2019-04-10  Tom Tromey  <tom@tromey.com>
5601
5602         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5603         * minsyms.c (lookup_minimal_symbol): Use foreach.
5604         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5605         (lookup_minimal_symbol_solib_trampoline): Likewise.
5606         * symfile.c (reread_symbols): Use foreach.
5607
5608 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5609             Tom Tromey  <tromey@adacore.com>
5610
5611         PR rust/24414:
5612         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5613         (rust_lex_int_test): Change "value" to be LONGEST.
5614         (rust_lex_tests): Add test for long integer literal.
5615
5616 2019-04-09  Tom Tromey  <tromey@adacore.com>
5617
5618         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5619         to bool.
5620         (extended_remote_target::attach): Update.
5621         (remote_target::remote_notice_new_inferior): Update.
5622         (remote_target::add_current_inferior_and_thread): Update.
5623         * inferior.c (exit_inferior_1): Use "false".
5624         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5625
5626 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5627
5628         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5629         the "start" command.
5630
5631 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5632
5633         * python/py-inferior.c (infpy_thread_from_thread_handle):
5634         Adjust comments to reflect renaming of thread_from_thread_handle
5635         to thread_from_handle.  Adjust keywords.  Fix type error message.
5636         (inferior_object_methods): Add thread_from_handle.  Retain
5637         thread_from_thread_handle, but mark it as deprecated.
5638
5639 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5640
5641         * gdbthread.h (find_thread_by_handle): Revise declaration.
5642         * thread.c (find_thread_by_handle): Likewise.  Adjust
5643         implementation too.
5644         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5645         support for buffer objects as handles.
5646
5647 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5648
5649         * python/py-infthread.c (thpy_thread_handle): New function.
5650         (thread_object_methods): Register thpy_thread_handle.
5651
5652 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5653
5654         * gdbthread.h (thread_to_thread_handle): Declare.
5655         * thread.c (gdbtypes.h): Include.
5656         (thread_to_thread_handle): New function.
5657
5658         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5659         (target_thread_info_to_thread_handle): Declare.
5660         * target.c (target_thread_info_to_thread_handle): New function.
5661         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5662         * target-delegates.c: Regenerate.
5663
5664         * linux-thread-db.c (class thread_db_target): Add method
5665         thread_info_to_thread_handle.
5666         (thread_db_target::thread_info_to_thread_handle): Define.
5667         * remote.c (class remote_target): Add new method
5668         thread_info_to_thread_handle.
5669         (remote_target::thread_info_to_thread_handle): Define.
5670
5671 2019-04-08  Pedro Alves  <palves@redhat.com>
5672
5673         * common/common-exceptions.c (throw_exception): Don't create
5674         named object to throw; throw directly.
5675         (throw_it): Likewise.  Don't initialize gdb_exception::message
5676         here, with new; pass FMT and AP to the ctor instead.
5677         * common/common-exceptions.h: Include <string>.
5678         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5679         const char *, va_list)): New ctor.  Use std::make_shared.
5680         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5681         errors)): Delete.
5682         (gdb_exception_error::gdb_exception_error(enum errors, const char
5683         *, va_list)): New.
5684         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5685         Add assertion.
5686         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5687         errors)): Delete.
5688         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5689         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5690         Add assertion.
5691
5692 2019-04-08  Tom Tromey  <tom@tromey.com>
5693
5694         * valops.c (value_rtti_indirect_type): Replace throw_exception
5695         with throw.
5696         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5697         with throw.
5698         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5699         throw.
5700         * target.c (target_translate_tls_address): Replace throw_exception
5701         with throw.
5702         * stack.c (frame_apply_command_count): Replace throw_exception
5703         with throw.
5704         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5705         throw.
5706         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5707         with throw.
5708         * rs6000-tdep.c (rs6000_frame_cache)
5709         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5710         * remote.c: Replace throw_exception with throw.
5711         * record-full.c (record_full_message, record_full_wait_1)
5712         (record_full_restore): Replace throw_exception with throw.
5713         * record-btrace.c:
5714         (get_thread_current_frame_id, record_btrace_start_replaying)
5715         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5716         (cmd_record_btrace_start): Replace throw_exception with throw.
5717         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5718         throw.
5719         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5720         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5721         * linespec.c:
5722         (find_linespec_symbols): Replace throw_exception with throw.
5723         * infrun.c (displaced_step_prepare, resume): Replace
5724         throw_exception with throw.
5725         * infcmd.c (post_create_inferior): Replace throw_exception with
5726         throw.
5727         * inf-loop.c (inferior_event_handler): Replace throw_exception
5728         with throw.
5729         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5730         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5731         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5732         (get_prev_frame_always, get_frame_pc_if_available)
5733         (get_frame_address_in_block_if_available, get_frame_language):
5734         Replace throw_exception with throw.
5735         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5736         throw_exception with throw.
5737         * eval.c (fetch_subexp_value, evaluate_var_value)
5738         (evaluate_funcall, evaluate_subexp_standard): Replace
5739         throw_exception with throw.
5740         * dwarf2loc.c (call_site_find_chain)
5741         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5742         Replace throw_exception with throw.
5743         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5744         with throw.
5745         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5746         throw.
5747         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5748         * completer.c (complete_line_internal): Replace throw_exception
5749         with throw.
5750         * compile/compile-object-run.c (compile_object_run): Replace
5751         throw_exception with throw.
5752         * cli/cli-script.c (process_next_line): Replace throw_exception
5753         with throw.
5754         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5755         (btrace_enable, btrace_maint_update_pt_packets): Replace
5756         throw_exception with throw.
5757         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5758         throw_exception with throw.
5759         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5760         throw_exception with throw.
5761         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5762         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5763         * aarch64-tdep.c (aarch64_make_prologue_cache)
5764         (aarch64_make_stub_cache): Replace throw_exception with throw.
5765
5766 2019-04-08  Tom Tromey  <tom@tromey.com>
5767
5768         * common/common-exceptions.c (throw_exception): Rename from
5769         throw_exception_cxx.  Remove old copy.  Make argument const.
5770         (throw_it): Create and throw exception objects directly.
5771         * common/common-exceptions.h (throw_exception): Make argument
5772         const.
5773         (struct gdb_exception_error): Add constructor.
5774         (struct gdb_exception_quit): Add constructor.
5775
5776 2019-04-08  Tom Tromey  <tom@tromey.com>
5777
5778         * common/common-exceptions.h (exception_rethrow): Don't declare.
5779         (TRY_SJLJ): Update comment.
5780         (TRY, CATCH, END_CATCH): Remove.
5781         * common/common-exceptions.c (exception_rethrow): Remove.
5782
5783 2019-04-08  Tom Tromey  <tom@tromey.com>
5784
5785         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5786         Remove.
5787         (gdb_exception_error): Rename from
5788         gdb_exception_RETURN_MASK_ERROR.
5789         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5790         (gdb_quit_bad_alloc): Update.
5791         * aarch64-tdep.c: Update.
5792         * ada-lang.c: Update.
5793         * ada-typeprint.c: Update.
5794         * ada-valprint.c: Update.
5795         * amd64-tdep.c: Update.
5796         * arch-utils.c: Update.
5797         * break-catch-throw.c: Update.
5798         * breakpoint.c: Update.
5799         * btrace.c: Update.
5800         * c-varobj.c: Update.
5801         * cli/cli-cmds.c: Update.
5802         * cli/cli-interp.c: Update.
5803         * cli/cli-script.c: Update.
5804         * common/common-exceptions.c: Update.
5805         * common/new-op.c: Update.
5806         * common/selftest.c: Update.
5807         * compile/compile-c-symbols.c: Update.
5808         * compile/compile-cplus-symbols.c: Update.
5809         * compile/compile-object-load.c: Update.
5810         * compile/compile-object-run.c: Update.
5811         * completer.c: Update.
5812         * corelow.c: Update.
5813         * cp-abi.c: Update.
5814         * cp-support.c: Update.
5815         * cp-valprint.c: Update.
5816         * darwin-nat.c: Update.
5817         * disasm-selftests.c: Update.
5818         * dtrace-probe.c: Update.
5819         * dwarf-index-cache.c: Update.
5820         * dwarf-index-write.c: Update.
5821         * dwarf2-frame-tailcall.c: Update.
5822         * dwarf2-frame.c: Update.
5823         * dwarf2loc.c: Update.
5824         * dwarf2read.c: Update.
5825         * eval.c: Update.
5826         * event-loop.c: Update.
5827         * event-top.c: Update.
5828         * exec.c: Update.
5829         * f-valprint.c: Update.
5830         * fbsd-tdep.c: Update.
5831         * frame-unwind.c: Update.
5832         * frame.c: Update.
5833         * gdbtypes.c: Update.
5834         * gnu-v3-abi.c: Update.
5835         * guile/guile-internal.h: Update.
5836         * guile/scm-block.c: Update.
5837         * guile/scm-breakpoint.c: Update.
5838         * guile/scm-cmd.c: Update.
5839         * guile/scm-disasm.c: Update.
5840         * guile/scm-frame.c: Update.
5841         * guile/scm-lazy-string.c: Update.
5842         * guile/scm-math.c: Update.
5843         * guile/scm-param.c: Update.
5844         * guile/scm-ports.c: Update.
5845         * guile/scm-pretty-print.c: Update.
5846         * guile/scm-symbol.c: Update.
5847         * guile/scm-symtab.c: Update.
5848         * guile/scm-type.c: Update.
5849         * guile/scm-value.c: Update.
5850         * i386-linux-tdep.c: Update.
5851         * i386-tdep.c: Update.
5852         * inf-loop.c: Update.
5853         * infcall.c: Update.
5854         * infcmd.c: Update.
5855         * infrun.c: Update.
5856         * jit.c: Update.
5857         * language.c: Update.
5858         * linespec.c: Update.
5859         * linux-fork.c: Update.
5860         * linux-nat.c: Update.
5861         * linux-tdep.c: Update.
5862         * linux-thread-db.c: Update.
5863         * main.c: Update.
5864         * mi/mi-cmd-break.c: Update.
5865         * mi/mi-cmd-stack.c: Update.
5866         * mi/mi-interp.c: Update.
5867         * mi/mi-main.c: Update.
5868         * objc-lang.c: Update.
5869         * p-valprint.c: Update.
5870         * parse.c: Update.
5871         * ppc-linux-tdep.c: Update.
5872         * printcmd.c: Update.
5873         * python/py-arch.c: Update.
5874         * python/py-breakpoint.c: Update.
5875         * python/py-cmd.c: Update.
5876         * python/py-finishbreakpoint.c: Update.
5877         * python/py-frame.c: Update.
5878         * python/py-framefilter.c: Update.
5879         * python/py-gdb-readline.c: Update.
5880         * python/py-inferior.c: Update.
5881         * python/py-infthread.c: Update.
5882         * python/py-lazy-string.c: Update.
5883         * python/py-linetable.c: Update.
5884         * python/py-objfile.c: Update.
5885         * python/py-param.c: Update.
5886         * python/py-prettyprint.c: Update.
5887         * python/py-progspace.c: Update.
5888         * python/py-record-btrace.c: Update.
5889         * python/py-record.c: Update.
5890         * python/py-symbol.c: Update.
5891         * python/py-type.c: Update.
5892         * python/py-unwind.c: Update.
5893         * python/py-utils.c: Update.
5894         * python/py-value.c: Update.
5895         * python/python.c: Update.
5896         * record-btrace.c: Update.
5897         * record-full.c: Update.
5898         * remote-fileio.c: Update.
5899         * remote.c: Update.
5900         * riscv-tdep.c: Update.
5901         * rs6000-aix-tdep.c: Update.
5902         * rs6000-tdep.c: Update.
5903         * rust-exp.y: Update.
5904         * rust-lang.c: Update.
5905         * s390-tdep.c: Update.
5906         * selftest-arch.c: Update.
5907         * solib-dsbt.c: Update.
5908         * solib-frv.c: Update.
5909         * solib-spu.c: Update.
5910         * solib-svr4.c: Update.
5911         * solib.c: Update.
5912         * sparc64-linux-tdep.c: Update.
5913         * stack.c: Update.
5914         * symfile-mem.c: Update.
5915         * symmisc.c: Update.
5916         * target.c: Update.
5917         * thread.c: Update.
5918         * top.c: Update.
5919         * tracefile-tfile.c: Update.
5920         * tui/tui.c: Update.
5921         * typeprint.c: Update.
5922         * unittests/cli-utils-selftests.c: Update.
5923         * unittests/parse-connection-spec-selftests.c: Update.
5924         * valops.c: Update.
5925         * valprint.c: Update.
5926         * value.c: Update.
5927         * varobj.c: Update.
5928         * windows-nat.c: Update.
5929         * x86-linux-nat.c: Update.
5930         * xml-support.c: Update.
5931
5932 2019-04-08  Tom Tromey  <tom@tromey.com>
5933
5934         * xml-support.c: Use C++ exception handling.
5935         * x86-linux-nat.c: Use C++ exception handling.
5936         * windows-nat.c: Use C++ exception handling.
5937         * varobj.c: Use C++ exception handling.
5938         * value.c: Use C++ exception handling.
5939         * valprint.c: Use C++ exception handling.
5940         * valops.c: Use C++ exception handling.
5941         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5942         handling.
5943         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5944         * typeprint.c: Use C++ exception handling.
5945         * tui/tui.c: Use C++ exception handling.
5946         * tracefile-tfile.c: Use C++ exception handling.
5947         * top.c: Use C++ exception handling.
5948         * thread.c: Use C++ exception handling.
5949         * target.c: Use C++ exception handling.
5950         * symmisc.c: Use C++ exception handling.
5951         * symfile-mem.c: Use C++ exception handling.
5952         * stack.c: Use C++ exception handling.
5953         * sparc64-linux-tdep.c: Use C++ exception handling.
5954         * solib.c: Use C++ exception handling.
5955         * solib-svr4.c: Use C++ exception handling.
5956         * solib-spu.c: Use C++ exception handling.
5957         * solib-frv.c: Use C++ exception handling.
5958         * solib-dsbt.c: Use C++ exception handling.
5959         * selftest-arch.c: Use C++ exception handling.
5960         * s390-tdep.c: Use C++ exception handling.
5961         * rust-lang.c: Use C++ exception handling.
5962         * rust-exp.y: Use C++ exception handling.
5963         * rs6000-tdep.c: Use C++ exception handling.
5964         * rs6000-aix-tdep.c: Use C++ exception handling.
5965         * riscv-tdep.c: Use C++ exception handling.
5966         * remote.c: Use C++ exception handling.
5967         * remote-fileio.c: Use C++ exception handling.
5968         * record-full.c: Use C++ exception handling.
5969         * record-btrace.c: Use C++ exception handling.
5970         * python/python.c: Use C++ exception handling.
5971         * python/py-value.c: Use C++ exception handling.
5972         * python/py-utils.c: Use C++ exception handling.
5973         * python/py-unwind.c: Use C++ exception handling.
5974         * python/py-type.c: Use C++ exception handling.
5975         * python/py-symbol.c: Use C++ exception handling.
5976         * python/py-record.c: Use C++ exception handling.
5977         * python/py-record-btrace.c: Use C++ exception handling.
5978         * python/py-progspace.c: Use C++ exception handling.
5979         * python/py-prettyprint.c: Use C++ exception handling.
5980         * python/py-param.c: Use C++ exception handling.
5981         * python/py-objfile.c: Use C++ exception handling.
5982         * python/py-linetable.c: Use C++ exception handling.
5983         * python/py-lazy-string.c: Use C++ exception handling.
5984         * python/py-infthread.c: Use C++ exception handling.
5985         * python/py-inferior.c: Use C++ exception handling.
5986         * python/py-gdb-readline.c: Use C++ exception handling.
5987         * python/py-framefilter.c: Use C++ exception handling.
5988         * python/py-frame.c: Use C++ exception handling.
5989         * python/py-finishbreakpoint.c: Use C++ exception handling.
5990         * python/py-cmd.c: Use C++ exception handling.
5991         * python/py-breakpoint.c: Use C++ exception handling.
5992         * python/py-arch.c: Use C++ exception handling.
5993         * printcmd.c: Use C++ exception handling.
5994         * ppc-linux-tdep.c: Use C++ exception handling.
5995         * parse.c: Use C++ exception handling.
5996         * p-valprint.c: Use C++ exception handling.
5997         * objc-lang.c: Use C++ exception handling.
5998         * mi/mi-main.c: Use C++ exception handling.
5999         * mi/mi-interp.c: Use C++ exception handling.
6000         * mi/mi-cmd-stack.c: Use C++ exception handling.
6001         * mi/mi-cmd-break.c: Use C++ exception handling.
6002         * main.c: Use C++ exception handling.
6003         * linux-thread-db.c: Use C++ exception handling.
6004         * linux-tdep.c: Use C++ exception handling.
6005         * linux-nat.c: Use C++ exception handling.
6006         * linux-fork.c: Use C++ exception handling.
6007         * linespec.c: Use C++ exception handling.
6008         * language.c: Use C++ exception handling.
6009         * jit.c: Use C++ exception handling.
6010         * infrun.c: Use C++ exception handling.
6011         * infcmd.c: Use C++ exception handling.
6012         * infcall.c: Use C++ exception handling.
6013         * inf-loop.c: Use C++ exception handling.
6014         * i386-tdep.c: Use C++ exception handling.
6015         * i386-linux-tdep.c: Use C++ exception handling.
6016         * guile/scm-value.c: Use C++ exception handling.
6017         * guile/scm-type.c: Use C++ exception handling.
6018         * guile/scm-symtab.c: Use C++ exception handling.
6019         * guile/scm-symbol.c: Use C++ exception handling.
6020         * guile/scm-pretty-print.c: Use C++ exception handling.
6021         * guile/scm-ports.c: Use C++ exception handling.
6022         * guile/scm-param.c: Use C++ exception handling.
6023         * guile/scm-math.c: Use C++ exception handling.
6024         * guile/scm-lazy-string.c: Use C++ exception handling.
6025         * guile/scm-frame.c: Use C++ exception handling.
6026         * guile/scm-disasm.c: Use C++ exception handling.
6027         * guile/scm-cmd.c: Use C++ exception handling.
6028         * guile/scm-breakpoint.c: Use C++ exception handling.
6029         * guile/scm-block.c: Use C++ exception handling.
6030         * guile/guile-internal.h: Use C++ exception handling.
6031         * gnu-v3-abi.c: Use C++ exception handling.
6032         * gdbtypes.c: Use C++ exception handling.
6033         * frame.c: Use C++ exception handling.
6034         * frame-unwind.c: Use C++ exception handling.
6035         * fbsd-tdep.c: Use C++ exception handling.
6036         * f-valprint.c: Use C++ exception handling.
6037         * exec.c: Use C++ exception handling.
6038         * event-top.c: Use C++ exception handling.
6039         * event-loop.c: Use C++ exception handling.
6040         * eval.c: Use C++ exception handling.
6041         * dwarf2read.c: Use C++ exception handling.
6042         * dwarf2loc.c: Use C++ exception handling.
6043         * dwarf2-frame.c: Use C++ exception handling.
6044         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6045         * dwarf-index-write.c: Use C++ exception handling.
6046         * dwarf-index-cache.c: Use C++ exception handling.
6047         * dtrace-probe.c: Use C++ exception handling.
6048         * disasm-selftests.c: Use C++ exception handling.
6049         * darwin-nat.c: Use C++ exception handling.
6050         * cp-valprint.c: Use C++ exception handling.
6051         * cp-support.c: Use C++ exception handling.
6052         * cp-abi.c: Use C++ exception handling.
6053         * corelow.c: Use C++ exception handling.
6054         * completer.c: Use C++ exception handling.
6055         * compile/compile-object-run.c: Use C++ exception handling.
6056         * compile/compile-object-load.c: Use C++ exception handling.
6057         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6058         * compile/compile-c-symbols.c: Use C++ exception handling.
6059         * common/selftest.c: Use C++ exception handling.
6060         * common/new-op.c: Use C++ exception handling.
6061         * cli/cli-script.c: Use C++ exception handling.
6062         * cli/cli-interp.c: Use C++ exception handling.
6063         * cli/cli-cmds.c: Use C++ exception handling.
6064         * c-varobj.c: Use C++ exception handling.
6065         * btrace.c: Use C++ exception handling.
6066         * breakpoint.c: Use C++ exception handling.
6067         * break-catch-throw.c: Use C++ exception handling.
6068         * arch-utils.c: Use C++ exception handling.
6069         * amd64-tdep.c: Use C++ exception handling.
6070         * ada-valprint.c: Use C++ exception handling.
6071         * ada-typeprint.c: Use C++ exception handling.
6072         * ada-lang.c: Use C++ exception handling.
6073         * aarch64-tdep.c: Use C++ exception handling.
6074
6075 2019-04-08  Tom Tromey  <tom@tromey.com>
6076
6077         * xml-support.c (gdb_xml_parser::parse): Update.
6078         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6079         * value.c (show_convenience): Update.
6080         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6081         (test_parse_flags_qcs): Update.
6082         * thread.c (thr_try_catch_cmd): Update.
6083         * target.c (target_translate_tls_address): Update.
6084         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6085         (info_frame_command_core, frame_apply_command_count): Update.
6086         * rust-exp.y (rust_lex_exception_test): Update.
6087         * riscv-tdep.c (riscv_print_one_register_info): Update.
6088         * remote.c (remote_target::enable_btrace): Update.
6089         * record-btrace.c (record_btrace_enable_warn): Update.
6090         * python/py-utils.c (gdbpy_convert_exception): Update.
6091         * printcmd.c (do_one_display, print_variable_and_value): Update.
6092         * mi/mi-main.c (mi_print_exception): Update.
6093         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6094         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6095         * linux-nat.c (linux_nat_target::attach): Update.
6096         * linux-fork.c (class scoped_switch_fork_info): Update.
6097         * infrun.c (displaced_step_prepare): Update.
6098         * infcall.c (call_function_by_hand_dummy): Update.
6099         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6100         * gnu-v3-abi.c (print_one_vtable): Update.
6101         * frame.c (get_prev_frame_always): Update.
6102         * f-valprint.c (info_common_command_for_block): Update.
6103         * exec.c (try_open_exec_file): Update.
6104         * exceptions.c (print_exception, exception_print)
6105         (exception_fprintf, exception_print_same): Update.
6106         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6107         * dwarf-index-cache.c (index_cache::store)
6108         (index_cache::lookup_gdb_index): Update.
6109         * darwin-nat.c (maybe_cache_shell): Update.
6110         * cp-valprint.c (cp_print_value_fields): Update.
6111         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6112         (gcc_cplus_symbol_address): Update.
6113         * compile/compile-c-symbols.c (gcc_convert_symbol)
6114         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6115         * common/selftest.c: Update.
6116         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6117         a std::string.
6118         (exception_try_scope_entry, exception_try_scope_exit): Don't
6119         declare.
6120         (struct exception_try_scope): Remove.
6121         (TRY): Don't use exception_try_scope.
6122         (struct gdb_exception): Add constructor, operator=.
6123         <what>: New method.
6124         (struct gdb_exception_RETURN_MASK_ALL)
6125         (struct gdb_exception_RETURN_MASK_ERROR)
6126         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6127         (struct gdb_quit_bad_alloc): Update.
6128         * common/common-exceptions.c (exception_none): Change
6129         initializer.
6130         (struct catcher) <state, exception>: Initialize inline.
6131         <prev>: Remove member.
6132         (current_catcher): Remove.
6133         (catchers): New global.
6134         (exceptions_state_mc_init): Simplify.
6135         (catcher_pop): Remove.
6136         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6137         (try_scope_depth, exception_try_scope_entry)
6138         (exception_try_scope_exit): Remove.
6139         (throw_exception_sjlj): Update.
6140         (exception_messages, exception_messages_size): Remove.
6141         (throw_it): Simplify.
6142         (gdb_exception_sliced_copy): Remove.
6143         (throw_exception_cxx): Update.
6144         * cli/cli-script.c (script_from_file): Update.
6145         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6146         Update.
6147         * ada-valprint.c (ada_val_print): Update.
6148         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6149         (create_excep_cond_exprs): Update.
6150
6151 2019-04-08  Tom Tromey  <tom@tromey.com>
6152
6153         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6154         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6155         (TRY, CATCH, END_CATCH): Remove some definitions.
6156         * common/common-exceptions.c: Don't use GDB_XCPT.
6157         (catcher_list_size): Remove.
6158         (throw_exception, throw_it): Simplify.
6159
6160 2019-04-05  Tom Tromey  <tom@tromey.com>
6161
6162         Revert the header-sorting patch.
6163         * ft32-tdep.c: Revert.
6164         * frv-tdep.c: Revert.
6165         * frv-linux-tdep.c: Revert.
6166         * frame.c: Revert.
6167         * frame-unwind.c: Revert.
6168         * frame-base.c: Revert.
6169         * fork-child.c: Revert.
6170         * findvar.c: Revert.
6171         * findcmd.c: Revert.
6172         * filesystem.c: Revert.
6173         * filename-seen-cache.h: Revert.
6174         * filename-seen-cache.c: Revert.
6175         * fbsd-tdep.c: Revert.
6176         * fbsd-nat.h: Revert.
6177         * fbsd-nat.c: Revert.
6178         * f-valprint.c: Revert.
6179         * f-typeprint.c: Revert.
6180         * f-lang.c: Revert.
6181         * extension.h: Revert.
6182         * extension.c: Revert.
6183         * extension-priv.h: Revert.
6184         * expprint.c: Revert.
6185         * exec.h: Revert.
6186         * exec.c: Revert.
6187         * exceptions.c: Revert.
6188         * event-top.c: Revert.
6189         * event-loop.c: Revert.
6190         * eval.c: Revert.
6191         * elfread.c: Revert.
6192         * dwarf2read.h: Revert.
6193         * dwarf2read.c: Revert.
6194         * dwarf2loc.c: Revert.
6195         * dwarf2expr.h: Revert.
6196         * dwarf2expr.c: Revert.
6197         * dwarf2-frame.c: Revert.
6198         * dwarf2-frame-tailcall.c: Revert.
6199         * dwarf-index-write.h: Revert.
6200         * dwarf-index-write.c: Revert.
6201         * dwarf-index-common.c: Revert.
6202         * dwarf-index-cache.h: Revert.
6203         * dwarf-index-cache.c: Revert.
6204         * dummy-frame.c: Revert.
6205         * dtrace-probe.c: Revert.
6206         * disasm.h: Revert.
6207         * disasm.c: Revert.
6208         * disasm-selftests.c: Revert.
6209         * dictionary.c: Revert.
6210         * dicos-tdep.c: Revert.
6211         * demangle.c: Revert.
6212         * dcache.h: Revert.
6213         * dcache.c: Revert.
6214         * darwin-nat.h: Revert.
6215         * darwin-nat.c: Revert.
6216         * darwin-nat-info.c: Revert.
6217         * d-valprint.c: Revert.
6218         * d-namespace.c: Revert.
6219         * d-lang.c: Revert.
6220         * ctf.c: Revert.
6221         * csky-tdep.c: Revert.
6222         * csky-linux-tdep.c: Revert.
6223         * cris-tdep.c: Revert.
6224         * cris-linux-tdep.c: Revert.
6225         * cp-valprint.c: Revert.
6226         * cp-support.c: Revert.
6227         * cp-namespace.c: Revert.
6228         * cp-abi.c: Revert.
6229         * corelow.c: Revert.
6230         * corefile.c: Revert.
6231         * continuations.c: Revert.
6232         * completer.h: Revert.
6233         * completer.c: Revert.
6234         * complaints.c: Revert.
6235         * coffread.c: Revert.
6236         * coff-pe-read.c: Revert.
6237         * cli-out.h: Revert.
6238         * cli-out.c: Revert.
6239         * charset.c: Revert.
6240         * c-varobj.c: Revert.
6241         * c-valprint.c: Revert.
6242         * c-typeprint.c: Revert.
6243         * c-lang.c: Revert.
6244         * buildsym.c: Revert.
6245         * buildsym-legacy.c: Revert.
6246         * build-id.h: Revert.
6247         * build-id.c: Revert.
6248         * btrace.c: Revert.
6249         * bsd-uthread.c: Revert.
6250         * breakpoint.h: Revert.
6251         * breakpoint.c: Revert.
6252         * break-catch-throw.c: Revert.
6253         * break-catch-syscall.c: Revert.
6254         * break-catch-sig.c: Revert.
6255         * blockframe.c: Revert.
6256         * block.c: Revert.
6257         * bfin-tdep.c: Revert.
6258         * bfin-linux-tdep.c: Revert.
6259         * bfd-target.c: Revert.
6260         * bcache.c: Revert.
6261         * ax-general.c: Revert.
6262         * ax-gdb.h: Revert.
6263         * ax-gdb.c: Revert.
6264         * avr-tdep.c: Revert.
6265         * auxv.c: Revert.
6266         * auto-load.c: Revert.
6267         * arm-wince-tdep.c: Revert.
6268         * arm-tdep.c: Revert.
6269         * arm-symbian-tdep.c: Revert.
6270         * arm-pikeos-tdep.c: Revert.
6271         * arm-obsd-tdep.c: Revert.
6272         * arm-nbsd-tdep.c: Revert.
6273         * arm-nbsd-nat.c: Revert.
6274         * arm-linux-tdep.c: Revert.
6275         * arm-linux-nat.c: Revert.
6276         * arm-fbsd-tdep.c: Revert.
6277         * arm-fbsd-nat.c: Revert.
6278         * arm-bsd-tdep.c: Revert.
6279         * arch-utils.c: Revert.
6280         * arc-tdep.c: Revert.
6281         * arc-newlib-tdep.c: Revert.
6282         * annotate.h: Revert.
6283         * annotate.c: Revert.
6284         * amd64-windows-tdep.c: Revert.
6285         * amd64-windows-nat.c: Revert.
6286         * amd64-tdep.c: Revert.
6287         * amd64-sol2-tdep.c: Revert.
6288         * amd64-obsd-tdep.c: Revert.
6289         * amd64-obsd-nat.c: Revert.
6290         * amd64-nbsd-tdep.c: Revert.
6291         * amd64-nbsd-nat.c: Revert.
6292         * amd64-nat.c: Revert.
6293         * amd64-linux-tdep.c: Revert.
6294         * amd64-linux-nat.c: Revert.
6295         * amd64-fbsd-tdep.c: Revert.
6296         * amd64-fbsd-nat.c: Revert.
6297         * amd64-dicos-tdep.c: Revert.
6298         * amd64-darwin-tdep.c: Revert.
6299         * amd64-bsd-nat.c: Revert.
6300         * alpha-tdep.c: Revert.
6301         * alpha-obsd-tdep.c: Revert.
6302         * alpha-nbsd-tdep.c: Revert.
6303         * alpha-mdebug-tdep.c: Revert.
6304         * alpha-linux-tdep.c: Revert.
6305         * alpha-linux-nat.c: Revert.
6306         * alpha-bsd-tdep.c: Revert.
6307         * alpha-bsd-nat.c: Revert.
6308         * aix-thread.c: Revert.
6309         * agent.c: Revert.
6310         * addrmap.c: Revert.
6311         * ada-varobj.c: Revert.
6312         * ada-valprint.c: Revert.
6313         * ada-typeprint.c: Revert.
6314         * ada-tasks.c: Revert.
6315         * ada-lang.c: Revert.
6316         * aarch64-tdep.c: Revert.
6317         * aarch64-ravenscar-thread.c: Revert.
6318         * aarch64-newlib-tdep.c: Revert.
6319         * aarch64-linux-tdep.c: Revert.
6320         * aarch64-linux-nat.c: Revert.
6321         * aarch64-fbsd-tdep.c: Revert.
6322         * aarch64-fbsd-nat.c: Revert.
6323         * aarch32-linux-nat.c: Revert.
6324
6325 2019-04-05  Tom Tromey  <tom@tromey.com>
6326
6327         * ft32-tdep.c: Sort headers.
6328         * frv-tdep.c: Sort headers.
6329         * frv-linux-tdep.c: Sort headers.
6330         * frame.c: Sort headers.
6331         * frame-unwind.c: Sort headers.
6332         * frame-base.c: Sort headers.
6333         * fork-child.c: Sort headers.
6334         * findvar.c: Sort headers.
6335         * findcmd.c: Sort headers.
6336         * filesystem.c: Sort headers.
6337         * filename-seen-cache.h: Sort headers.
6338         * filename-seen-cache.c: Sort headers.
6339         * fbsd-tdep.c: Sort headers.
6340         * fbsd-nat.h: Sort headers.
6341         * fbsd-nat.c: Sort headers.
6342         * f-valprint.c: Sort headers.
6343         * f-typeprint.c: Sort headers.
6344         * f-lang.c: Sort headers.
6345         * extension.h: Sort headers.
6346         * extension.c: Sort headers.
6347         * extension-priv.h: Sort headers.
6348         * expprint.c: Sort headers.
6349         * exec.h: Sort headers.
6350         * exec.c: Sort headers.
6351         * exceptions.c: Sort headers.
6352         * event-top.c: Sort headers.
6353         * event-loop.c: Sort headers.
6354         * eval.c: Sort headers.
6355         * elfread.c: Sort headers.
6356         * dwarf2read.h: Sort headers.
6357         * dwarf2read.c: Sort headers.
6358         * dwarf2loc.c: Sort headers.
6359         * dwarf2expr.h: Sort headers.
6360         * dwarf2expr.c: Sort headers.
6361         * dwarf2-frame.c: Sort headers.
6362         * dwarf2-frame-tailcall.c: Sort headers.
6363         * dwarf-index-write.h: Sort headers.
6364         * dwarf-index-write.c: Sort headers.
6365         * dwarf-index-common.c: Sort headers.
6366         * dwarf-index-cache.h: Sort headers.
6367         * dwarf-index-cache.c: Sort headers.
6368         * dummy-frame.c: Sort headers.
6369         * dtrace-probe.c: Sort headers.
6370         * disasm.h: Sort headers.
6371         * disasm.c: Sort headers.
6372         * disasm-selftests.c: Sort headers.
6373         * dictionary.c: Sort headers.
6374         * dicos-tdep.c: Sort headers.
6375         * demangle.c: Sort headers.
6376         * dcache.h: Sort headers.
6377         * dcache.c: Sort headers.
6378         * darwin-nat.h: Sort headers.
6379         * darwin-nat.c: Sort headers.
6380         * darwin-nat-info.c: Sort headers.
6381         * d-valprint.c: Sort headers.
6382         * d-namespace.c: Sort headers.
6383         * d-lang.c: Sort headers.
6384         * ctf.c: Sort headers.
6385         * csky-tdep.c: Sort headers.
6386         * csky-linux-tdep.c: Sort headers.
6387         * cris-tdep.c: Sort headers.
6388         * cris-linux-tdep.c: Sort headers.
6389         * cp-valprint.c: Sort headers.
6390         * cp-support.c: Sort headers.
6391         * cp-namespace.c: Sort headers.
6392         * cp-abi.c: Sort headers.
6393         * corelow.c: Sort headers.
6394         * corefile.c: Sort headers.
6395         * continuations.c: Sort headers.
6396         * completer.h: Sort headers.
6397         * completer.c: Sort headers.
6398         * complaints.c: Sort headers.
6399         * coffread.c: Sort headers.
6400         * coff-pe-read.c: Sort headers.
6401         * cli-out.h: Sort headers.
6402         * cli-out.c: Sort headers.
6403         * charset.c: Sort headers.
6404         * c-varobj.c: Sort headers.
6405         * c-valprint.c: Sort headers.
6406         * c-typeprint.c: Sort headers.
6407         * c-lang.c: Sort headers.
6408         * buildsym.c: Sort headers.
6409         * buildsym-legacy.c: Sort headers.
6410         * build-id.h: Sort headers.
6411         * build-id.c: Sort headers.
6412         * btrace.c: Sort headers.
6413         * bsd-uthread.c: Sort headers.
6414         * breakpoint.h: Sort headers.
6415         * breakpoint.c: Sort headers.
6416         * break-catch-throw.c: Sort headers.
6417         * break-catch-syscall.c: Sort headers.
6418         * break-catch-sig.c: Sort headers.
6419         * blockframe.c: Sort headers.
6420         * block.c: Sort headers.
6421         * bfin-tdep.c: Sort headers.
6422         * bfin-linux-tdep.c: Sort headers.
6423         * bfd-target.c: Sort headers.
6424         * bcache.c: Sort headers.
6425         * ax-general.c: Sort headers.
6426         * ax-gdb.h: Sort headers.
6427         * ax-gdb.c: Sort headers.
6428         * avr-tdep.c: Sort headers.
6429         * auxv.c: Sort headers.
6430         * auto-load.c: Sort headers.
6431         * arm-wince-tdep.c: Sort headers.
6432         * arm-tdep.c: Sort headers.
6433         * arm-symbian-tdep.c: Sort headers.
6434         * arm-pikeos-tdep.c: Sort headers.
6435         * arm-obsd-tdep.c: Sort headers.
6436         * arm-nbsd-tdep.c: Sort headers.
6437         * arm-nbsd-nat.c: Sort headers.
6438         * arm-linux-tdep.c: Sort headers.
6439         * arm-linux-nat.c: Sort headers.
6440         * arm-fbsd-tdep.c: Sort headers.
6441         * arm-fbsd-nat.c: Sort headers.
6442         * arm-bsd-tdep.c: Sort headers.
6443         * arch-utils.c: Sort headers.
6444         * arc-tdep.c: Sort headers.
6445         * arc-newlib-tdep.c: Sort headers.
6446         * annotate.h: Sort headers.
6447         * annotate.c: Sort headers.
6448         * amd64-windows-tdep.c: Sort headers.
6449         * amd64-windows-nat.c: Sort headers.
6450         * amd64-tdep.c: Sort headers.
6451         * amd64-sol2-tdep.c: Sort headers.
6452         * amd64-obsd-tdep.c: Sort headers.
6453         * amd64-obsd-nat.c: Sort headers.
6454         * amd64-nbsd-tdep.c: Sort headers.
6455         * amd64-nbsd-nat.c: Sort headers.
6456         * amd64-nat.c: Sort headers.
6457         * amd64-linux-tdep.c: Sort headers.
6458         * amd64-linux-nat.c: Sort headers.
6459         * amd64-fbsd-tdep.c: Sort headers.
6460         * amd64-fbsd-nat.c: Sort headers.
6461         * amd64-dicos-tdep.c: Sort headers.
6462         * amd64-darwin-tdep.c: Sort headers.
6463         * amd64-bsd-nat.c: Sort headers.
6464         * alpha-tdep.c: Sort headers.
6465         * alpha-obsd-tdep.c: Sort headers.
6466         * alpha-nbsd-tdep.c: Sort headers.
6467         * alpha-mdebug-tdep.c: Sort headers.
6468         * alpha-linux-tdep.c: Sort headers.
6469         * alpha-linux-nat.c: Sort headers.
6470         * alpha-bsd-tdep.c: Sort headers.
6471         * alpha-bsd-nat.c: Sort headers.
6472         * aix-thread.c: Sort headers.
6473         * agent.c: Sort headers.
6474         * addrmap.c: Sort headers.
6475         * ada-varobj.c: Sort headers.
6476         * ada-valprint.c: Sort headers.
6477         * ada-typeprint.c: Sort headers.
6478         * ada-tasks.c: Sort headers.
6479         * ada-lang.c: Sort headers.
6480         * aarch64-tdep.c: Sort headers.
6481         * aarch64-ravenscar-thread.c: Sort headers.
6482         * aarch64-newlib-tdep.c: Sort headers.
6483         * aarch64-linux-tdep.c: Sort headers.
6484         * aarch64-linux-nat.c: Sort headers.
6485         * aarch64-fbsd-tdep.c: Sort headers.
6486         * aarch64-fbsd-nat.c: Sort headers.
6487         * aarch32-linux-nat.c: Sort headers.
6488
6489 2019-04-04  Tom Tromey  <tom@tromey.com>
6490
6491         * varobj.c (varobj_create): Update.
6492         * rust-exp.y (struct rust_parser) <update_innermost_block,
6493         lookup_symbol>: New methods.
6494         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6495         Rename.
6496         (rust_parser::rust_lookup_type)
6497         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6498         * printcmd.c (display_command, do_one_display): Update.
6499         * parser-defs.h (struct parser_state) <parser_state>: Add
6500         "tracker" parameter.
6501         (block_tracker): New member.
6502         (class innermost_block_tracker) <innermost_block_tracker>: Add
6503         "types" parameter.
6504         <reset>: Remove method.
6505         (innermost_block): Don't declare.
6506         (null_post_parser): Update.
6507         * parse.c (innermost_block): Remove global.
6508         (write_dollar_variable): Update.
6509         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6510         Remove "tracker_types" parameter.
6511         (parse_expression): Add "tracker" parameter.
6512         (parse_expression_for_completion): Update.
6513         (null_post_parser): Add "tracker" parameter.
6514         * p-exp.y: Update rules.
6515         * m2-exp.y: Update rules.
6516         * language.h (struct language_defn) <la_post_parser>: Add
6517         "tracker" parameter.
6518         * go-exp.y: Update rules.
6519         * f-exp.y: Update rules.
6520         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6521         parameter.
6522         * d-exp.y: Update rules.
6523         * c-exp.y: Update rules.
6524         * breakpoint.c (set_breakpoint_condition): Create an
6525         innermost_block_tracker.
6526         (watch_command_1): Likewise.
6527         * ada-lang.c (resolve): Add "tracker" parameter.
6528         (resolve_subexp): Likewise.
6529         * ada-exp.y (write_var_from_sym): Update.
6530
6531 2019-04-04  Tom Tromey  <tom@tromey.com>
6532
6533         * type-stack.h: New file.
6534         * type-stack.c: New file.
6535         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6536         type-stack.h.
6537         (insert_into_type_stack, insert_type, push_type, push_type_int)
6538         (insert_type_address_space, pop_type, pop_type_int)
6539         (pop_typelist, pop_type_stack, append_type_stack)
6540         (push_type_stack, get_type_stack, push_typelist)
6541         (follow_type_instance_flags, follow_types): Don't declare.
6542         * parse.c (type_stack): Remove global.
6543         (parse_exp_in_context): Update.
6544         (insert_into_type_stack, insert_type, push_type, push_type_int)
6545         (insert_type_address_space, pop_type, pop_type_int)
6546         (pop_typelist, pop_type_stack, append_type_stack)
6547         (push_type_stack, get_type_stack, push_typelist)
6548         (follow_type_instance_flags, follow_types): Remove (moved to
6549         type-stack.c).
6550         * f-exp.y (type_stack): New global.
6551         Update rules.
6552         (push_kind_type, f_parse): Update.
6553         * d-exp.y (type_stack): New global.
6554         Update rules.
6555         (d_parse): Update.
6556         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6557         Update rules.
6558         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6559         (HFILES_NO_SRCDIR): Add type-stack.h.
6560
6561 2019-04-04  Tom Tromey  <tom@tromey.com>
6562
6563         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6564         (rust_parser::convert_ast_to_expression, rust_parse)
6565         (rust_lex_test_completion, rust_lex_tests): Update.
6566         * parser-defs.h (struct expr_completion_state): New.
6567         (struct parser_state) <parser_state>: Add completion parameter.
6568         <mark_struct_expression, mark_completion_tag>: New methods.
6569         <parse_completion, m_completion_state>: New members.
6570         (prefixify_expression, null_post_parser): Update.
6571         (mark_struct_expression, mark_completion_tag): Don't declare.
6572         * parse.c (parse_completion, expout_last_struct)
6573         (expout_tag_completion_type, expout_completion_name): Remove
6574         globals.
6575         (parser_state::mark_struct_expression)
6576         (parser_state::mark_completion_tag): Now methods.
6577         (prefixify_expression): Add last_struct parameter.
6578         (prefixify_subexp): Likewise.
6579         (parse_exp_1): Update.
6580         (parse_exp_in_context): Add cstate parameter.  Update.
6581         (parse_expression_for_completion): Create an
6582         expr_completion_state.
6583         (null_post_parser): Add "completion" parameter.
6584         * p-exp.y: Update rules.
6585         (yylex): Update.
6586         * language.h (struct language_defn) <la_post_parser>: Add
6587         "completing" parameter.
6588         * go-exp.y: Update rules.
6589         (lex_one_token): Update.
6590         * expression.h (parse_completion): Don't declare.
6591         * d-exp.y: Update rules.
6592         (lex_one_token): Update rules.
6593         * c-exp.y: Update rules.
6594         (lex_one_token): Update.
6595         * ada-lang.c (resolve): Add "parse_completion" parameter.
6596         (resolve_subexp): Likewise.
6597         (ada_resolve_function): Likewise.
6598
6599 2019-04-04  Tom Tromey  <tom@tromey.com>
6600
6601         * parser-defs.h (struct parser_state) <start_arglist,
6602         end_arglist>: New methods.
6603         <arglist_len, m_funcall_chain>: New members.
6604         (arglist_len, start_arglist, end_arglist): Don't declare.
6605         * parse.c (arglist_len, funcall_chain): Remove global.
6606         (start_arglist, end_arglist): Remove functions.
6607         (parse_exp_in_context): Update.
6608         * p-exp.y: Update rules.
6609         * m2-exp.y: Update rules.
6610         * go-exp.y: Update rules.
6611         * f-exp.y: Update rules.
6612         * d-exp.y: Update rules.
6613         * c-exp.y: Update rules.
6614
6615 2019-04-04  Tom Tromey  <tom@tromey.com>
6616
6617         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6618         lex_operator, push_back>: New methods.
6619         Update all rules.
6620         (rust_parser::lex_hex, lex_escape): Rename and update.
6621         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6622         (rust_parser::lex_operator): Rename and update.
6623         (rust_parser::lex_number, rustyylex, rustyyerror)
6624         (rust_lex_test_init, rust_lex_test_sequence)
6625         (rust_lex_test_push_back, rust_lex_tests): Update.
6626         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6627         parameter.
6628         <lexptr, prev_lexptr>: New members.
6629         (lexptr, prev_lexptr): Don't declare.
6630         * parse.c (lexptr, prev_lexptr): Remove globals.
6631         (parse_exp_in_context): Update.
6632         * p-exp.y (yylex, yyerror): Update.
6633         * m2-exp.y (parse_number, yylex, yyerror): Update.
6634         * go-exp.y (lex_one_token, yyerror): Update.
6635         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6636         * d-exp.y (lex_one_token, yyerror): Update.
6637         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6638         (lex_one_token, yyerror): Update.
6639         * ada-lex.l (YY_INPUT): Update.
6640         (rewind_to_char): Update.
6641         * ada-exp.y (yyerror): Update.
6642
6643 2019-04-04  Tom Tromey  <tom@tromey.com>
6644
6645         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6646         * parser-defs.h (struct parser_state) <parser_state>: Add new
6647         parameter.
6648         <comma_terminates>: New member.
6649         (comma_terminates): Don't declare global.
6650         * parse.c (comma_terminates): Remove global.
6651         (parse_exp_in_context): Update.
6652         * p-exp.y (yylex): Update.
6653         * m2-exp.y (yylex): Update.
6654         * go-exp.y (lex_one_token): Update.
6655         * f-exp.y (yylex): Update.
6656         * d-exp.y (lex_one_token): Update.
6657         * c-exp.y (lex_one_token): Update.
6658         * ada-lex.l: Update.
6659
6660 2019-04-04  Tom Tromey  <tom@tromey.com>
6661
6662         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6663         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6664         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6665         * parser-defs.h (paren_depth): Don't declare.
6666         * parse.c (paren_depth): Remove global.
6667         (parse_exp_in_context): Update.
6668         * p-exp.y (paren_depth): New global.
6669         (pascal_parse): Initialize it.
6670         * m2-exp.y (paren_depth): New global.
6671         (m2_parse): Initialize it.
6672         * go-exp.y (paren_depth): New global.
6673         (go_parse): Initialize it.
6674         * f-exp.y (paren_depth): New global.
6675         (f_parse): Initialize it.
6676         * d-exp.y (paren_depth): New global.
6677         (d_parse): Initialize it.
6678         * c-exp.y (paren_depth): New global.
6679         (c_parse): Initialize it.
6680         * ada-lex.l (paren_depth): New global.
6681         (lexer_init): Initialize it.
6682
6683 2019-04-04  Tom Tromey  <tom@tromey.com>
6684
6685         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6686         (rust_parser::convert_ast_to_type)
6687         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6688         * parser-defs.h (struct parser_state) <parser_state>: Add
6689         parameters.  Initialize new members.
6690         <expression_context_block, expression_context_pc>: New members.
6691         * parse.c (expression_context_block, expression_context_pc):
6692         Remove globals.
6693         (parse_exp_in_context): Update.
6694         * p-exp.y: Update all rules.
6695         (yylex): Update.
6696         * m2-exp.y: Update all rules.
6697         (yylex): Update.
6698         * go-exp.y (yylex): Update.
6699         * f-exp.y (yylex): Update.
6700         * d-exp.y: Update all rules.
6701         (yylex): Update.
6702         * c-exp.y: Update all rules.
6703         (lex_one_token, classify_name, yylex, c_parse): Update.
6704         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6705
6706 2019-04-04  Tom Tromey  <tom@tromey.com>
6707
6708         * gdbarch.h, gdbarch.c: Rebuild.
6709         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6710         * stap-probe.h:
6711         (struct stap_parse_info): Replace "parser_state" with
6712         "expr_builder".
6713         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6714         (parser_state): New class.
6715         * parse.c (expr_builder): Rename.
6716         (expr_builder::release): Rename.
6717         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6718         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6719         (write_exp_elt_longcst, write_exp_elt_floatcst)
6720         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6721         (write_exp_string_vector, write_exp_bitstring)
6722         (write_exp_msymbol, mark_struct_expression)
6723         (write_dollar_variable)
6724         (insert_type_address_space, increase_expout_size): Replace
6725         "parser_state" with "expr_builder".
6726         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6727         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6728         "parser_state" with "expr_builder".
6729
6730 2019-04-04  Tom Tromey  <tom@tromey.com>
6731
6732         * rust-exp.y: Replace "parse_language" with method call.
6733         * p-exp.y:
6734         (yylex): Replace "parse_language" with method call.
6735         * m2-exp.y:
6736         (yylex): Replace "parse_language" with method call.
6737         * go-exp.y (classify_name): Replace "parse_language" with method
6738         call.
6739         * f-exp.y (yylex): Replace "parse_language" with method call.
6740         * d-exp.y (lex_one_token): Replace "parse_language" with method
6741         call.
6742         * c-exp.y:
6743         (lex_one_token, classify_name, yylex): Replace "parse_language"
6744         with method call.
6745         * ada-exp.y (find_primitive_type, type_char)
6746         (type_system_address): Replace "parse_language" with method call.
6747
6748 2019-04-04  Tom Tromey  <tom@tromey.com>
6749
6750         * rust-exp.y: Replace "parse_gdbarch" with method call.
6751         * parse.c (write_dollar_variable, insert_type_address_space):
6752         Replace "parse_gdbarch" with method call.
6753         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6754         call.
6755         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6756         call.
6757         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6758         "parse_gdbarch" with method call.
6759         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6760         with method call.
6761         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6762         "parse_gdbarch" with method call.
6763         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6764         "parse_gdbarch" with method call.
6765         * c-exp.y (parse_type, parse_number, classify_name): Replace
6766         "parse_gdbarch" with method call.
6767         * ada-lex.l: Replace "parse_gdbarch" with method call.
6768         * ada-exp.y (parse_type, find_primitive_type, type_char)
6769         (type_system_address): Replace "parse_gdbarch" with method call.
6770
6771 2019-04-04  Tom Tromey  <tom@tromey.com>
6772
6773         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6774         * stap-probe.c (stap_parse_argument): Update.
6775         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6776         initial_size parameter.
6777         * rust-exp.y (rust_lex_tests): Update.
6778         * parse.c (parser_state): Update.
6779         (parse_exp_in_context): Update.
6780         * parser-defs.h (struct parser_state) <parser_state>: Remove
6781         "initial_size" parameter.
6782
6783 2019-04-04  Tom Tromey  <tom@tromey.com>
6784
6785         * parser-defs.h (increase_expout_size): Don't declare.
6786         * parse.c (increase_expout_size): Now static.
6787
6788 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6789
6790         * gnu-nat.c (gnu_nat_target::wait): Fix
6791         target_waitstatus_to_string call.
6792
6793 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6794
6795         * eval.c (evaluate_subexp_standard): Handle internal functions
6796         during Fortran function call handling.
6797
6798 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6799
6800         * NEWS: Mention new internal functions.
6801         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6802         (read_base_type): Use dwarf2_init_complex_target_type.
6803         * value.c (creal_internal_fn): New function.
6804         (cimag_internal_fn): New function.
6805         (_initialize_values): Register new internal functions.
6806
6807 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6808
6809         * infrun.c (stop_all_threads): If debug_infrun, always
6810         trace the wait status after wait_one, using
6811         target_waitstatus_to_string and target_pid_to_str.
6812         (handle_inferior_event): Replace various trace of
6813         wait status kind by a single trace.
6814         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6815         wait status kind image by target_waitstatus_to_string.
6816         * target/waitstatus.c (target_waitstatus_to_string): Fix
6817         obsolete comment.
6818
6819 2019-04-01  Tom Tromey  <tromey@adacore.com>
6820
6821         PR symtab/23331:
6822         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6823
6824 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6825             Pedro Alves  <palves@redhat.com>
6826
6827         * top.c (quit_force): Call 'finalize_values'.
6828         * value.c (finalize_values): New function.
6829         * value.h (finalize_values): Declare.
6830
6831 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6832
6833         * NEWS: Announce $_gdb_major and $_gdb_minor.
6834
6835         * top.c (init_gdb_version_vars): New function.
6836         (gdb_init): Call init_gdb_version_vars.
6837
6838 2019-03-29  Tom Tromey  <tromey@adacore.com>
6839
6840         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6841         help text.  Remove dead code.
6842
6843 2019-03-29  Keith Seitz  <keiths@redhat.com>
6844
6845         From Siddhesh Poyarekar:
6846         * f-lang.h (f77_get_upperbound): Return LONGEST.
6847         (f77_get_lowerbound): Likewise.
6848         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6849         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6850         print them.
6851         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6852         plongest to format print it.
6853         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6854         (f77_get_upperbound): Likewise.
6855         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6856         LOWER_BOUND to LONGEST.
6857         (f77_create_arrayprint_offset_tbl): Likewise.
6858
6859 2019-03-29  Keith Seitz  <keiths@redhat.com>
6860
6861         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6862         %s/pulongest for TYPE_LENGTH instead of %d in format
6863         strings.
6864         * ada-typerint.c (ada_print_type): Likewise.
6865         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6866         * compile/compile-c-support.c (generate_register_struct): Likewise.
6867         * gdbtypes.c (recursive_dump_type): Likewise.
6868         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6869         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6870         instead of %d in format strings.
6871         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6872         to std::min to ULONGEST.
6873         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6874         instead of %d in format strings.
6875         * tracepoint.c (info_scope_command): Likewise.
6876         * typeprint.c (print_offset_data::update)
6877         (print_offset_data::finish): Likewise.
6878         * xtensa-tdep.c (xtensa_store_return_value)
6879         (xtensa_push_dummy_call): Likewise.
6880
6881 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6882
6883         * windows-nat.c (display_selector): Fixed format specifications
6884         for 64-bit Cygwin.
6885
6886 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6887
6888         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6889
6890 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6891
6892         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6893         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6894         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6895         (nios2_linux_init_abi): Install it.
6896
6897 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6898
6899         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6900
6901 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6902
6903         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6904
6905 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6906             Tom Tromey  <tromey@adacore.com>
6907
6908         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6909
6910 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6911
6912         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6913         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6914         method to compute the bounds of range types. Also print "[evaluated]"
6915         if the bounds' values come from a dynamic evaluation.
6916
6917 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6918
6919         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6920         whitespace when pretty printing is on.
6921
6922 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6923
6924         * ppc-linux-nat.c: Add include.
6925
6926 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6927
6928         * NEWS: Mention AArch64 Pointer Authentication.
6929
6930 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6931
6932         * arm-linux-nat.c: Add include.
6933
6934 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6935
6936         * source-cache.c (source_cache::get_source_lines): Re-read
6937         fullname after calling open_source_file.
6938
6939 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6940
6941         * NEWS: Mention TLS support for FreeBSD.
6942
6943 2019-03-25  Tom Tromey  <tromey@adacore.com>
6944
6945         * minsyms.c (BUNCH_SIZE): Update comment.
6946         (~minimal_symbol_reader): Remove old comment.
6947         (compact_minimal_symbols): Update comment.
6948         (minimal_symbol_reader::install): Remove old comment.  Update
6949         other comments.
6950
6951 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6952
6953         * s390-linux-nat.c: Add include.
6954
6955 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6956
6957         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6958         Call linux_get_hwcap.
6959         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6960         Likewise.
6961         (aarch64_linux_get_hwcap): Remove function.
6962         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6963         declaration.
6964         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6965         linux_get_hwcap.
6966         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6967         * linux-tdep.c (linux_get_hwcap): Add function.
6968         (linux_get_hwcap2): Likewise.
6969         * linux-tdep.h (linux_get_hwcap): Add declaration.
6970         (linux_get_hwcap2): Likewise.
6971         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6972         (ppc_linux_get_hwcap2): Likewise.
6973         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6974         linux_get_hwcap.
6975         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6976         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6977         (ppc_linux_nat_target::read_description): Likewise.
6978         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6979         * s390-linux-nat.c: Likewise.
6980         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6981
6982 2019-03-24  Tom Tromey  <tom@tromey.com>
6983
6984         * ada-lang.c (standard_lookup): Simplify initialization.
6985         (ada_lookup_symbol_nonlocal): Simplify return.
6986         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6987         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6988         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6989         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6990         initialization.
6991         * solib.c (solib_global_lookup): Simplify.
6992         * symtab.c (null_block_symbol): Remove.
6993         (symbol_cache_lookup): Simplify returns.
6994         (lookup_language_this): Simplify returns.
6995         (lookup_symbol_aux): Simplify return.
6996         (lookup_local_symbol): Simplify returns.
6997         (lookup_global_symbol_from_objfile): Simplify return.
6998         (lookup_symbol_in_objfile_symtabs)
6999         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7000         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7001         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7002         * cp-namespace.c (cp_lookup_bare_symbol)
7003         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7004         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7005         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7006         (cp_lookup_symbol_via_imports): Simplify initialization.
7007         (find_symbol_in_baseclass): Likewise.
7008         * symtab.h (null_block_symbol): Remove.
7009         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7010         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7011         (d_lookup_symbol_module): Likewise.
7012         (find_symbol_in_baseclass): Simplify initialization.
7013
7014 2019-03-24  Tom Tromey  <tom@tromey.com>
7015
7016         * expression.h: Don't include symtab.h.
7017         (struct block): Forward declare.
7018
7019 2019-03-24  Tom Tromey  <tom@tromey.com>
7020
7021         * c-exp.y (typebase): Remove casts.
7022         * gdbtypes.c (lookup_unsigned_typename, )
7023         (lookup_signed_typename): Remove cast.
7024         * eval.c (parse_to_comma_and_eval): Remove cast.
7025         * parse.c (write_dollar_variable): Remove cast.
7026         * block.h (struct block) <superblock>: Now const.
7027         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7028         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7029         (map_block): Make "block" const.
7030         * symfile.h (struct quick_symbol_functions)
7031         <map_matching_symbols>: Constify block argument to "callback".
7032         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7033         const.
7034         (find_pc_sect_compunit_symtab): Make "b" const.
7035         (find_symbol_at_address): Likewise.
7036         (search_symbols): Likewise.
7037         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7038         (dw2_debug_names_lookup_symbol): Likewise.
7039         (dw2_map_matching_symbols): Update.
7040         * p-valprint.c (pascal_val_print): Remove "block".
7041         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7042         (aux_add_nonlocal_symbols): Make "block" const.
7043         (resolve_subexp): Remove cast.
7044         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7045         const.
7046         (iterate_over_file_blocks): Likewise.
7047         * f-exp.y (%union) <bval>: Remove.
7048         * coffread.c (patch_opaque_types): Make "b" const.
7049         * spu-tdep.c (spu_catch_start): Make "block" const.
7050         * c-valprint.c (print_unpacked_pointer): Remove "block".
7051         * symmisc.c (dump_symtab_1): Make "b" const.
7052         (block_depth): Make "block" const.
7053         * d-exp.y (%union) <bval>: Remove.
7054         * cp-support.h (cp_lookup_rtti_type): Update.
7055         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7056         * psymtab.c (psym_lookup_symbol): Make "block" const.
7057         (maintenance_check_psymtabs): Make "b" const.
7058         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7059         (enumerate_locals, enumerate_args): Update.
7060         * python/py-symtab.c (stpy_global_block): Make "block" const.
7061         (stpy_static_block): Likewise.
7062         * inline-frame.c (block_starting_point_at): Make "new_block"
7063         const.
7064         * block.c (find_block_in_blockvector): Make return type const.
7065         (blockvector_for_pc_sect): Make "b" const.
7066         (find_block_in_blockvector): Make "b" const.
7067
7068 2019-03-23  Tom Tromey  <tom@tromey.com>
7069
7070         * varobj.c (varobj_create): Update.
7071         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7072         * printcmd.c (display_command, do_one_display): Don't reset
7073         innermost_block.
7074         * parser-defs.h (enum innermost_block_tracker_type): Move to
7075         expression.h.
7076         (innermost_block): Update comment.
7077         * parse.c (parse_exp_1): Add tracker_types parameter.
7078         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7079         tracker_types parameter.  Reset innermost_block.
7080         (parse_exp_in_context): Remove.
7081         (parse_expression_for_completion): Update.
7082         * objfiles.c (~objfile): Don't reset expression_context_block or
7083         innermost_block.
7084         * expression.h (enum innermost_block_tracker_type): Move from
7085         parser-defs.h.
7086         (parse_exp_1): Add tracker_types parameter.
7087         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7088         reset innermost_block.
7089
7090 2019-03-23  Tom Tromey  <tom@tromey.com>
7091
7092         * objfiles.h: Include bcache.h.
7093
7094 2019-03-23  Tom Tromey  <tom@tromey.com>
7095
7096         * linespec.c (get_current_search_block): Use
7097         scoped_restore_current_language.
7098         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7099
7100 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7101             Jiong Wang  <jiong.wang@arm.com>
7102
7103         * aarch64-linux-tdep.c
7104         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7105         section.
7106         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7107
7108 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7109             Jiong Wang  <jiong.wang@arm.com>
7110
7111         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7112         instructions.
7113         (aarch64_analyze_prologue_test): Add PACIASP test.
7114         (aarch64_prologue_prev_register): Unmask PC value.
7115
7116 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7117             Jiong Wang  <jiong.wang@arm.com>
7118
7119         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7120         (aarch64_dwarf2_prev_register): Unmask PC value.
7121         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7122         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7123         DW_CFA_AARCH64_negate_ra_state.
7124         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7125
7126 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7127             Jiong Wang  <jiong.wang@arm.com>
7128
7129         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7130         registers.
7131         (aarch64_pseudo_register_name): Likewise.
7132         (aarch64_pseudo_register_type): Likewise.
7133         (aarch64_pseudo_register_reggroup_p): Likewise.
7134         (aarch64_gdbarch_init): Add pauth registers.
7135         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7136         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7137         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7138         (struct gdbarch_tdep): Add regnum for ra_state.
7139
7140 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7141             Jiong Wang  <jiong.wang@arm.com>
7142
7143         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7144
7145 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7146             Jiong Wang  <jiong.wang@arm.com>
7147
7148         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7149         function.
7150         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7151         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7152         (aarch64_gdbarch_init): Add puth registers.
7153         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7154         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7155         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7156
7157 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7158             Jiong Wang  <jiong.wang@arm.com>
7159
7160         * aarch64-linux-nat.c
7161         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7162         * aarch64-linux-tdep.c
7163         (aarch64_linux_core_read_description): Likewise.
7164         (aarch64_linux_get_hwcap): New function.
7165         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7166         (aarch64_linux_get_hwcap): New declaration.
7167
7168 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7169             Jiong Wang  <jiong.wang@arm.com>
7170
7171         * aarch64-linux-nat.c
7172         (aarch64_linux_nat_target::read_description): Add pauth param.
7173         * aarch64-linux-tdep.c
7174         (aarch64_linux_core_read_description): Likewise.
7175         * aarch64-tdep.c (struct target_desc): Add in pauth.
7176         (aarch64_read_description): Add pauth param.
7177         (aarch64_gdbarch_init): Likewise.
7178         * aarch64-tdep.h (aarch64_read_description): Likewise.
7179         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7180         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7181         * features/Makefile: Add new files.
7182         * features/aarch64-pauth.c: New file.
7183         * features/aarch64-pauth.xml: New file.
7184
7185 2019-03-20  Tom Tromey  <tromey@adacore.com>
7186
7187         * infrun.c (handle_inferior_event): Rename from
7188         handle_inferior_event_1.  Create a scoped_value_mark.
7189         (handle_inferior_event): Remove.
7190
7191 2019-03-19  Tom Tromey  <tromey@adacore.com>
7192
7193         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7194         * infrun.h (print_stop_event): Add "displays" parameter.
7195         * infrun.c (print_stop_event): Add "displays" parameter.
7196
7197 2019-03-19  Pedro Alves  <palves@redhat.com>
7198
7199         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7200         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7201         to -1.  Fix TABs vs spaces.
7202         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7203         * tui/tui-out.h (tui_ui_out) Add intro comments.
7204         <m_line, m_start_of_line>: In-class initialize, and add describing
7205         comment.
7206
7207 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7208
7209         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7210         variable names.
7211         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7212
7213 2019-03-18  Pedro Alves  <palves@redhat.com>
7214             Eli Zaretskii <eliz@gnu.org>
7215
7216         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7217         m_line and m_start_of_line.
7218
7219 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7220
7221         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7222         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7223         it returns a newline.  This fixes a regression in TU mode, whereby
7224         the next line is output on the same screen line as the user input.
7225
7226 2019-03-18  Tom Tromey  <tromey@adacore.com>
7227
7228         * minsyms.c (minimal_symbol_reader::install): Remove call to
7229         obstack_blank.
7230
7231 2019-03-18  Pedro Alves  <palves@redhat.com>
7232
7233         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7234         New globals.
7235         (apply_style): New, factored out from ...
7236         (apply_ansi_escape): ... this.  Handle reverse video mode.
7237         (tui_set_reverse_mode): New function.
7238         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7239         * tui/tui-winsource.c (tui_show_source_line): Use
7240         tui_set_reverse_mode instead of setting A_STANDOUT.
7241         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7242         New setter methods.
7243
7244 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7245
7246         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7247         Handle tabs.
7248
7249 2019-03-18  Tom Tromey  <tromey@adacore.com>
7250
7251         * ada-lang.c (empty_array): Add "high" parameter.
7252         (ada_evaluate_subexp): Update.
7253
7254 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7255
7256         * unittests/string_view-selftests.c: Define
7257         _initialize_string_view_selftests unconditionally.
7258
7259 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7260
7261         PR gdb/24350
7262         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7263
7264 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7265
7266         PR gdb/24351
7267         * windows-nat.c (display_selector): Fix format specifiers.
7268
7269 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7270
7271         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7272         tui_refill_source_window instead of tui_refresh_win, to update the
7273         current execution line.  This fixes redisplay of the current line
7274         when stepping through the code with "next" or "step".
7275
7276 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7277
7278         * source-cache.c (source_cache::get_source_lines): Call
7279         find_source_lines to initialize s->nlines.  This fixes vertical
7280         scrolling of TUI source window when the DOWN arrow is pressed.
7281
7282 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7283
7284         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7285         linux-thread-db.c (_initialize_thread_db): Likewise.
7286
7287 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7288
7289         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7290         wclrtoeol in tui_show_source_line".  This reverts changes made in
7291         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7292
7293 2019-03-15  Tom Tromey  <tom@tromey.com>
7294
7295         * symtab.h (struct minimal_symbol): Derive from
7296         general_symbol_info.
7297         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7298         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7299         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7300         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7301         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7302         (MSYMBOL_SEARCH_NAME): Update.
7303         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7304         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7305         * minsyms.c (minimal_symbol_reader::record_full): Update.
7306
7307 2019-03-15  Tom Tromey  <tom@tromey.com>
7308
7309         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7310
7311 2019-03-15  Tom Tromey  <tom@tromey.com>
7312
7313         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7314         unique_xmalloc_ptr.
7315         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7316         Update.
7317         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7318         (build_minimal_symbol_hash_tables)
7319         (minimal_symbol_reader::install): Update.
7320
7321 2019-03-15  Tom Tromey  <tom@tromey.com>
7322
7323         * symtab.c (create_demangled_names_hash): Update.
7324         (symbol_set_names): Update.
7325         * objfiles.h (struct objfile_per_bfd_storage)
7326         <demangled_names_hash>: Now an htab_up.
7327         * objfiles.c (objfile_per_bfd_storage): Simplify.
7328
7329 2019-03-15  Tom Tromey  <tom@tromey.com>
7330
7331         * objfiles.h (struct objfile_per_bfd_storage): Declare
7332         destructor.
7333         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7334         New.
7335         (get_objfile_bfd_data): Use new.  Don't initialize
7336         language_of_main.
7337         (free_objfile_per_bfd_storage): Remove.
7338         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7339
7340 2019-03-15  Tom Tromey  <tom@tromey.com>
7341
7342         * symfile.c (reread_symbols): Update.
7343         * objfiles.c (objfile::objfile): Update.
7344         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7345         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7346         comment.
7347         (minimal_symbol_reader::install): Update.
7348         (terminate_minimal_symbol_table): Remove.
7349         * jit.c (jit_object_close_impl): Update.
7350
7351 2019-03-15  Tom Tromey  <tom@tromey.com>
7352
7353         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7354         initializations.
7355
7356 2019-03-15  Tom Tromey  <tom@tromey.com>
7357
7358         * objfiles.h (struct objfile_per_bfd_storage)
7359         <demangled_hash_languages>: Now a bitset.
7360         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7361         (lookup_minimal_symbol): Update.
7362
7363 2019-03-15  Tom Tromey  <tom@tromey.com>
7364
7365         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7366         Don't return the symbol.
7367         * coffread.c (record_minimal_symbol): Use record_full.
7368
7369 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7370
7371         The MS-Windows port of ncurses fails to switch to a color pair if
7372         one or both of the colors are the implicit default colors.  This
7373         change records the default colors when TUI is initialized, and
7374         then specifies them explicitly when a color pair uses the default
7375         colors.  This allows color styling in TUI mode on MS-Windows.
7376
7377         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7378         ncurses_norm_attr.
7379         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7380         colors in ncurses_norm_attr.
7381         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7382         "none", replace it with the default color recorded in
7383         ncurses_norm_attr.
7384
7385 2019-03-14  Tom Tromey  <tromey@adacore.com>
7386
7387         * source-cache.h (class source_cache) <get_source_lines>: Return
7388         std::string.
7389         * source-cache.c (source_cache::extract_lines): Handle case where
7390         first_pos==npos.  Return std::string.
7391         (source_cache::get_source_lines): Update.
7392
7393 2019-03-14  Tom Tromey  <tromey@adacore.com>
7394
7395         * NEWS: Add item for "style sources" commands.
7396         * source-cache.c (source_cache::get_source_lines): Check
7397         source_styling.
7398         * cli/cli-style.c (source_styling): New global.
7399         (_initialize_cli_style): Add "style sources" commands.
7400         (show_style_sources): New function.
7401         * cli/cli-style.h (source_styling): Declare.
7402
7403 2019-03-14  Pedro Alves  <palves@redhat.com>
7404             Tom Tromey  <tromey@adacore.com>
7405
7406         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7407         * tui/tui-winsource.c (tui_refill_source_window): New function,
7408         from...
7409         (tui_horizontal_source_scroll): ... here.  Move some logic.
7410         * cli/cli-style.c (set_style_enabled): Notify new observable.
7411         * tui/tui-hooks.c (tui_redisplay_source): New function.
7412         (tui_attach_detach_observers): Attach or detach
7413         tui_redisplay_source.
7414         * observable.h (source_styling_changed): New observable.
7415         * observable.c: Define source_styling_changed observable.
7416
7417 2019-03-13  Tom Tromey  <tromey@adacore.com>
7418
7419         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7420         (i386_gnu_nat_target::store_registers): Update.
7421         * target-debug.h (target_debug_print_std_string): New macro.
7422         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7423         * windows-tdep.c (display_one_tib): Update.
7424         * tui/tui-stack.c (tui_make_status_line): Update.
7425         * top.c (print_inferior_quit_action): Update.
7426         * thread.c (thr_try_catch_cmd): Update.
7427         (add_thread_with_info): Update.
7428         (thread_target_id_str): Update.
7429         (thr_try_catch_cmd): Update.
7430         (thread_command): Update.
7431         (thread_find_command): Update.
7432         * record-btrace.c (record_btrace_target::info_record)
7433         (record_btrace_resume_thread, record_btrace_target::resume)
7434         (record_btrace_cancel_resume, record_btrace_step_thread)
7435         (record_btrace_target::wait, record_btrace_target::wait)
7436         (record_btrace_target::wait, record_btrace_target::stop): Update.
7437         * progspace.c (print_program_space): Update.
7438         * process-stratum-target.c
7439         (process_stratum_target::thread_address_space): Update.
7440         * linux-fork.c (linux_fork_mourn_inferior)
7441         (detach_checkpoint_command, info_checkpoints_command)
7442         (linux_fork_context): Update.
7443         (linux_fork_detach): Update.
7444         (class scoped_switch_fork_info): Update.
7445         (delete_checkpoint_command): Update.
7446         * infrun.c (follow_fork_inferior): Update.
7447         (follow_fork_inferior): Update.
7448         (proceed_after_vfork_done): Update.
7449         (handle_vfork_child_exec_or_exit): Update.
7450         (follow_exec): Update.
7451         (displaced_step_prepare_throw): Update.
7452         (displaced_step_restore): Update.
7453         (start_step_over): Update.
7454         (resume_1): Update.
7455         (clear_proceed_status_thread): Update.
7456         (proceed): Update.
7457         (print_target_wait_results): Update.
7458         (do_target_wait): Update.
7459         (context_switch): Update.
7460         (stop_all_threads): Update.
7461         (restart_threads): Update.
7462         (finish_step_over): Update.
7463         (handle_signal_stop): Update.
7464         (switch_back_to_stepped_thread): Update.
7465         (keep_going_pass_signal): Update.
7466         (print_exited_reason): Update.
7467         (normal_stop): Update.
7468         * inferior.c (inferior_pid_to_str): Change return type.
7469         (print_selected_inferior): Update.
7470         (add_inferior): Update.
7471         (detach_inferior): Update.
7472         * dummy-frame.c (fprint_dummy_frames): Update.
7473         * dcache.c (dcache_info_1): Update.
7474         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7475         (btrace_fetch, btrace_clear): Update.
7476         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7477         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7478         type.
7479         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7480         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7481         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7482         * gdbarch.c, gdbarch.h: Rebuild.
7483         * gdbarch.sh (core_pid_to_str): Change return type.
7484         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7485         return type.
7486         (windows_nat_target::pid_to_str): Change return type.
7487         (windows_delete_thread): Update.
7488         (windows_nat_target::attach): Update.
7489         (windows_nat_target::files_info): Update.
7490         * target-delegates.c: Rebuild.
7491         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7492         return type.
7493         (sol_thread_target::pid_to_str): Change return type.
7494         * remote.c (class remote_target) <pid_to_str>: Change return
7495         type.
7496         (remote_target::pid_to_str): Change return type.
7497         (extended_remote_target::attach, remote_target::remote_stop_ns)
7498         (remote_target::remote_notif_remove_queued_reply)
7499         (remote_target::push_stop_reply, remote_target::disable_btrace):
7500         Update.
7501         (extended_remote_target::attach): Update.
7502         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7503         type.
7504         (gdbsim_target::pid_to_str): Change return type.
7505         * ravenscar-thread.c (struct ravenscar_thread_target)
7506         <pid_to_str>: Change return type.
7507         (ravenscar_thread_target::pid_to_str): Change return type.
7508         * procfs.c (class procfs_target) <pid_to_str>: Change return
7509         type.
7510         (procfs_target::pid_to_str): Change return type.
7511         (procfs_target::attach): Update.
7512         (procfs_target::detach): Update.
7513         (procfs_target::fetch_registers): Update.
7514         (procfs_target::store_registers): Update.
7515         (procfs_target::wait): Update.
7516         (procfs_target::files_info): Update.
7517         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7518         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7519         return type.
7520         (nto_procfs_target::pid_to_str): Change return type.
7521         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7522         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7523         return type.
7524         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7525         (exit_lwp): Update.
7526         (attach_proc_task_lwp_callback, get_detach_signal)
7527         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7528         (linux_nat_target::resume, wait_lwp, stop_callback)
7529         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7530         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7531         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7532         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7533         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7534         type.
7535         (inf_ptrace_target::attach): Update.
7536         (inf_ptrace_target::files_info): Update.
7537         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7538         type.
7539         (go32_nat_target::pid_to_str): Change return type.
7540         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7541         (gnu_nat_target::wait): Update.
7542         (gnu_nat_target::wait): Update.
7543         (gnu_nat_target::resume): Update.
7544         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7545         (fbsd_nat_target::wait): Update.
7546         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7547         type.
7548         (darwin_nat_target::attach): Update.
7549         * corelow.c (class core_target) <pid_to_str>: Change return type.
7550         (core_target::pid_to_str): Change return type.
7551         * target.c (normal_pid_to_str): Change return type.
7552         (default_pid_to_str): Likewise.
7553         (target_pid_to_str): Change return type.
7554         (target_translate_tls_address): Update.
7555         (target_announce_detach): Update.
7556         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7557         return type.
7558         (bsd_uthread_target::pid_to_str): Change return type.
7559         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7560         type.
7561         (bsd_kvm_target::pid_to_str): Change return type.
7562         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7563         return type.
7564         (aix_thread_target::pid_to_str): Change return type.
7565         * target.h (struct target_ops) <pid_to_str>: Change return type.
7566         (target_pid_to_str, normal_pid_to_str): Likewise.
7567         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7568         type.
7569         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7570         type.
7571         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7572         return type.
7573         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7574         type.
7575         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7576         type.
7577         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7578         return type.
7579
7580 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7581
7582         * NEWS: Mention that the new default MI version is 3.  Mention
7583         changes to the output of commands and events that deal with
7584         multi-location breakpoints.
7585         * breakpoint.c: Include "mi/mi-out.h".
7586         (print_one_breakpoint): Change output syntax if using MI version
7587         >= 3.
7588         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7589         New.
7590         (mi_multi_location_breakpoint_output_fixed): New.
7591         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7592         (mi_cmd_fix_multi_location_breakpoint_output): New.
7593         (mi_multi_location_breakpoint_output_fixed): New.
7594         * mi/mi-cmds.c (mi_cmds): Register command
7595         -fix-multi-location-breakpoint-output.
7596         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7597         interpreter "mi".
7598
7599 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7600
7601         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7602         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7603         instantiate mi_ui_out based on interpreter name.
7604         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7605         * mi/mi-main.c (mi_load_progress): Likewise.
7606
7607 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7608
7609         * NEWS: Combine separate "New targets" sections for 8.3.
7610
7611 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7612
7613         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7614         (ppcfbsd_init_abi): Install gdbarch
7615         "fetch_tls_load_module_address" and "get_thread_local_address"
7616         methods.
7617
7618 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7619
7620         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7621         (riscv_fbsd_init_abi): Install gdbarch
7622         "fetch_tls_load_module_address" and "get_thread_local_address"
7623         methods.
7624
7625 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7626
7627         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7628         (i386fbsd_init_abi): Install gdbarch
7629         "fetch_tls_load_module_address" and "get_thread_local_address"
7630         methods.
7631
7632 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7633
7634         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7635         (amd64fbsd_init_abi): Install gdbarch
7636         "fetch_tls_load_module_address" and "get_thread_local_address"
7637         methods.
7638
7639 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7640
7641         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7642         (struct fbsd_pspace_data): New type.
7643         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7644         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7645         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7646         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7647         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7648
7649 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7650
7651         * gdbtypes.c (lookup_struct_elt): New function.
7652         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7653         * gdbtypes.h (struct struct_elt): New type.
7654         (lookup_struct_elt): New prototype.
7655
7656 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7657
7658         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7659         remove disabled code block.
7660
7661 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7662
7663         * gdbarch.sh (get_thread_local_address): New method.
7664         * gdbarch.h, gdbarch.c: Regenerate.
7665         * target.c (target_translate_tls_address): Use
7666         gdbarch_get_thread_local_address if present instead of
7667         target::get_thread_local_address.
7668
7669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7670
7671         * target.h (target::get_thread_local_address): Update comment.
7672
7673 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7674
7675         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7676         objfile->separate_debug_objfile_backlink if not NULL.
7677
7678 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7679
7680         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7681         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7682         (amd64bsd_store_inferior_registers): Likewise.
7683         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7684         Enable segment base registers.
7685         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7686         PT_GETFSBASE and PT_GETGSBASE.
7687         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7688         PT_SETGSBASE.
7689         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7690         segment base registers.
7691         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7692
7693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7694
7695         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7696         Update calls to i386_target_description to add 'segments'
7697         parameter.
7698         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7699         add segment base registers.
7700         * arch/i386.c (i386_create_target_description): Add 'segments'
7701         parameter to enable segment base registers.
7702         * arch/i386.h (i386_create_target_description): Likewise.
7703         * features/i386/32bit-segments.xml: New file.
7704         * features/i386/32bit-segments.c: Generate.
7705         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7706         call to i386_target_description to add 'segments' parameter.
7707         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7708         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7709         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7710         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7711         if feature is present.
7712         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7713         Add 'segments' parameter to call to i386_target_description.
7714         (i386_target_description): Add 'segments' parameter to enable
7715         segment base registers.
7716         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7717         to call to i386_target_description.
7718         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7719         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7720         Define I386_NUM_REGS.
7721         (i386_target_description): Add 'segments' parameter to enable
7722         segment base registers.
7723
7724 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7725
7726         PR/24325
7727         * source-cache.c: #undef open and close, to avoid unresolved
7728         externals during linking.
7729
7730 2019-03-12  Tom Tromey  <tromey@adacore.com>
7731
7732         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7733         const.  Add initializers.
7734         (_initialize_remote): Don't initialize ptid globals.
7735
7736 2019-03-12  Pedro Alves  <palves@redhat.com>
7737
7738         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7739
7740 2019-03-12  Pedro Alves  <palves@redhat.com>
7741
7742         * cp-name-parser.y (main): Remove unused 'len' variable.
7743
7744 2019-03-12  Tom Tromey  <tromey@adacore.com>
7745
7746         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7747         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7748
7749 2019-03-12  Tom Tromey  <tromey@adacore.com>
7750
7751         * linux-nat.c (iterate_over_lwps): Update.
7752         (stop_callback): Remove parameter.
7753         (stop_wait_callback, detach_callback, resume_set_callback)
7754         (select_singlestep_lwp_callback, set_ignore_sigint)
7755         (status_callback, resumed_callback, resume_clear_callback)
7756         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7757         data parameter.
7758         (linux_nat_target::detach, linux_nat_target::resume)
7759         (linux_stop_and_wait_all_lwps, select_event_lwp)
7760         (linux_nat_filter_event, linux_nat_wait_1)
7761         (linux_nat_target::kill, linux_nat_target::stop)
7762         (linux_nat_target::stop): Update.
7763         (linux_nat_resume_callback): Change type.
7764         (resume_stopped_resumed_lwps, count_events_callback)
7765         (select_event_lwp_callback): Likewise.
7766         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7767         * arm-linux-nat.c (struct update_registers_data): Remove.
7768         (update_registers_callback): Change type.
7769         (arm_linux_insert_hw_breakpoint1): Update.
7770         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7771         parameter.
7772         (x86_linux_dr_set_addr): Update.
7773         (x86_linux_dr_set_control): Update.
7774         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7775         (iterate_over_lwps): Use gdb::function_view.
7776         * nat/aarch64-linux-hw-point.c (struct
7777         aarch64_dr_update_callback_param): Remove.
7778         (debug_reg_change_callback): Change type.
7779         (aarch64_notify_debug_reg_change): Update.
7780         * s390-linux-nat.c (s390_refresh_per_info): Update.
7781
7782 2019-03-11  Tom Tromey  <tromey@adacore.com>
7783
7784         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7785         redundant assignment to "this_cu".
7786
7787 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7788
7789         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7790
7791 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7792
7793         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7794         from...
7795         (rank_one_type): ... this.
7796
7797 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7798
7799         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7800         from...
7801         (rank_one_type): ... this.
7802
7803 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7804
7805         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7806         from...
7807         (rank_one_type): ... this.
7808
7809 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7810
7811         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7812         from...
7813         (rank_one_type): ... this.
7814
7815 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7816
7817         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7818         from...
7819         (rank_one_type): ... this.
7820
7821 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7822
7823         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7824         from...
7825         (rank_one_type): ... this.
7826
7827 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7828
7829         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7830         from...
7831         (rank_one_type): ... this.
7832
7833 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7834
7835         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7836         from...
7837         (rank_one_type): ... this.
7838
7839 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7840
7841         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7842         from...
7843         (rank_one_type): ... this.
7844
7845 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7846
7847         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7848         from...
7849         (rank_one_type): ... this.
7850
7851 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7852
7853         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7854         from...
7855         (rank_one_type): ... this.
7856
7857 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7858
7859         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7860         from...
7861         (rank_one_type): ... this.
7862
7863 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7864
7865         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7866         inferior-events' shows the example events.
7867
7868 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7869
7870         Support styling on native MS-Windows console
7871
7872         PR/24315
7873         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7874         on MS-Windows if $TERM is not defined.
7875
7876         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7877
7878         * posix-hdep.c (gdb_console_fputs):
7879         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7880         functions.
7881         * ui-file.h (gdb_console_fputs): Add prototype.
7882
7883         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7884         back to fputs only if the former returns zero.
7885
7886 2019-03-07  Tom Tromey  <tom@tromey.com>
7887
7888         * symmisc.c (print_symbol_bcache_statistics): Update.
7889         (print_objfile_statistics): Update.
7890         * symfile.c (allocate_symtab): Update.
7891         * stabsread.c: Don't include bcache.h.
7892         * psymtab.h (struct psymbol_bcache): Don't declare.
7893         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7894         (psymbol_bcache_init, psymbol_bcache_free)
7895         (psymbol_bcache_get_bcache): Don't declare.
7896         * psymtab.c (struct psymbol_bcache): Remove.
7897         (psymtab_storage::psymtab_storage): Update.
7898         (psymtab_storage::~psymtab_storage): Update.
7899         (psymbol_bcache_init, psymbol_bcache_free)
7900         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7901         (add_psymbol_to_bcache): Update.
7902         (allocate_psymtab): Update.
7903         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7904         macro_cache>: No longer pointers.
7905         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7906         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7907         * macrotab.c (macro_bcache): Update.
7908         * macroexp.c: Don't include bcache.h.
7909         * gdbtypes.c (check_types_worklist): Update.
7910         (types_deeply_equal): Remove TRY/CATCH.  Update.
7911         * elfread.c (elf_symtab_read): Update.
7912         * dwarf2read.c: Don't include bcache.h.
7913         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7914         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7915         (print_bcache_statistics, bcache_memory_used): Don't declare.
7916         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7917         methods.  Rename all data members.
7918         * bcache.c (struct bcache): Move to bcache.h.
7919         (bcache::expand_hash_table): Rename from expand_hash_table.
7920         (bcache): Remove.
7921         (bcache::insert): Rename from bcache_full.
7922         (bcache::compare): Rename from bcache_compare.
7923         (bcache_xmalloc): Remove.
7924         (bcache::~bcache): Rename from bcache_xfree.
7925         (bcache::print_statistics): Rename from print_bcache_statistics.
7926         (bcache::memory_used): Rename from bcache_memory_used.
7927
7928 2019-03-07  Pedro Alves  <palves@redhat.com>
7929
7930         * infrun.c (normal_stop): Also check for
7931         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7932
7933 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7934
7935         * f-lang.c (value_from_host_double): Moved to...
7936         * value.c (value_from_host_double): ...here.
7937         * value.h (value_from_host_double): Declare.
7938         * guile/scm-math.c (vlscm_convert_typed_number): Use
7939         value_from_host_double.
7940         (vlscm_convert_number): Likewise.
7941         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7942         * python/py-value.c (convert_value_from_python): Likewise.
7943
7944 2019-03-06  Tom Tromey  <tom@tromey.com>
7945
7946         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7947
7948 2019-03-06  Tom Tromey  <tom@tromey.com>
7949
7950         * utils.h (free_current_contents): Don't declare.
7951         * utils.c (free_current_contents): Remove.
7952
7953 2019-03-06  Tom Tromey  <tom@tromey.com>
7954
7955         * top.c (quit_force): Update.
7956         * main.c (captured_command_loop): Update.
7957         * common/new-op.c (operator new): Update.
7958         * common/common-exceptions.c (struct catcher)
7959         <save_cleanup_chain>: Remove member.
7960         (exceptions_state_mc_init): Update.
7961         (exception_try_scope_entry): Return nullptr.
7962         (exception_try_scope_exit, exception_rethrow)
7963         (throw_exception_sjlj, throw_exception_cxx): Update.
7964         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7965         (all_cleanups, do_cleanups, discard_cleanups)
7966         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7967         (restore_cleanups, restore_final_cleanups): Don't declare.
7968         (do_final_cleanups): Remove parameter.
7969         * common/cleanups.c (cleanup_chain, make_cleanup)
7970         (make_cleanup_dtor, all_cleanups, do_cleanups)
7971         (discard_my_cleanups, discard_cleanups)
7972         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7973         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7974         (null_cleanup): Remove.
7975         (do_final_cleanups): Remove parameter.
7976
7977 2019-03-06  Tom Tromey  <tom@tromey.com>
7978
7979         * remote.c (remote_target::remote_parse_stop_reply): Use
7980         unique_xmalloc_ptr.
7981
7982 2019-03-06  Tom Tromey  <tom@tromey.com>
7983
7984         * stabsread.c (struct stabs_field_info): Rename from field_info.
7985         <list, fnlist>: Add initializers.
7986         <obstack>: New member.
7987         (read_member_functions, read_struct_fields, read_baseclasses):
7988         Allocate on obstack.  Don't use cleanups.
7989         (read_one_struct_field, read_member_functions, read_struct_fields)
7990         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7991         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7992         (read_struct_type): Update.
7993
7994 2019-03-06  Tom Tromey  <tom@tromey.com>
7995
7996         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7997         * common/filestuff.h (make_cleanup_close): Don't declare.
7998         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7999         Remove.
8000
8001 2019-03-06  Tom Tromey  <tom@tromey.com>
8002
8003         * solib-aix.c: Use make_scope_exit.
8004
8005 2019-03-06  Tom Tromey  <tom@tromey.com>
8006
8007         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8008         Use make_scope_exit.
8009
8010 2019-03-06  Tom Tromey  <tom@tromey.com>
8011
8012         * solib-svr4.c (disable_probes_interface): Remove parameter.
8013         (svr4_handle_solib_event): Use make_scope_exit.
8014
8015 2019-03-06  Tom Tromey  <tom@tromey.com>
8016
8017         * remote.c (struct stop_reply_deleter): Remove.
8018         (stop_reply_up): Update.
8019         (struct stop_reply): Derive from notif_event.  Don't typedef.
8020         <regcache>: Now a std::vector.
8021         (stop_reply_xfree): Remove.
8022         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8023         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8024         (remote_target::discard_pending_stop_replies): Use delete.
8025         (remote_target::remote_parse_stop_reply): Update.
8026         (remote_target::process_stop_reply): Update.
8027         * remote-notif.h (struct notif_event): Add virtual destructor.
8028         Remove "dtr" member.
8029         (struct notif_client) <alloc_event>: Return a unique_ptr.
8030         (notif_event_xfree): Don't declare.
8031         (notif_event_up): New typedef.
8032         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8033         (notif_event_xfree, do_notif_event_xfree): Remove.
8034         (remote_notif_state_xfree): Update.
8035
8036 2019-03-06  Tom Tromey  <tom@tromey.com>
8037
8038         * infrun.c (displaced_step_clear_cleanup): Now a
8039         forward_scope_exit type.
8040         (displaced_step_prepare_throw): Update.
8041         (displaced_step_fixup): Update.
8042
8043 2019-03-06  Tom Tromey  <tom@tromey.com>
8044
8045         * inferior.h (class inferior): Update comment.
8046         * gdbthread.h (class thread_info): Update comment.
8047
8048 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8049             Tom Tromey  <tom@tromey.com>
8050
8051         * stabsread.h (struct stab_section_list): Remove.
8052         (coffstab_build_psymtabs): Update.
8053         * dbxread.c (symbuf_sections): Now a std::vector.
8054         (sect_idx): New global.
8055         (fill_symbuf): Update.
8056         (coffstab_build_psymtabs): Change type of stabsects parameter.
8057         Update.
8058         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8059         std::vector.
8060         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8061         (coff_locate_sections): Update.
8062         (coff_symfile_read): Remove cleanups.  Update.
8063         (init_stringtab): Add storage parameter.
8064         (free_stringtab, free_stringtab_cleanup): Remove.
8065         (init_lineno): Add storage parameter.
8066         (free_linetab, free_linetab_cleanup): Remove.
8067
8068 2019-03-06  Pedro Alves  <palves@redhat.com>
8069
8070         * linux-fork.c (fork_info::clobber_regs): Delete.
8071         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8072         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8073         comment.  Adjust.
8074         (scoped_switch_fork_info::scoped_switch_fork_info)
8075         (checkpoint_command, linux_fork_context): Adjust
8076         fork_save_infrun_state calls.
8077
8078 2019-03-06  Pedro Alves  <palves@redhat.com>
8079
8080         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8081         (inf_has_multiple_threads): Return 'bool' and rewrite using
8082         inferior_info::threads().
8083
8084 2019-03-06  Pedro Alves  <palves@redhat.com>
8085
8086         * linux-fork.c: Include <list>.
8087         (fork_list): Now a std::list instance.
8088         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8089         (forks_exist_p, find_last_fork): Adjust.
8090         (new_fork): Delete.
8091         (one_fork_p): New.
8092         (add_fork): Adjust.
8093         (free_fork): Delete, folded into fork_info::~fork_info().
8094         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8095         Adjust.
8096         (init_fork_list): Delete.
8097         (linux_fork_killall, linux_fork_mourn_inferior)
8098         (linux_fork_detach, info_checkpoints_command): Adjust.
8099         (_initialize_linux_fork): No longer call init_fork_list.
8100
8101 2019-03-06  Pedro Alves  <palves@redhat.com>
8102
8103         * linux-fork.c (new_fork): New, split out of ...
8104         (add_fork): ... this.  Return void.  Move "first fork" special
8105         case from here, to ...
8106         (checkpoint_command): ... here.
8107         * linux-linux.h (add_fork): Return void.
8108
8109 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8110
8111         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8112
8113 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8114             Chris January  <chris.january@arm.com>
8115             David Lecomber  <david.lecomber@arm.com>
8116
8117         * f-exp.y: New token, UNOP_INTRINSIC.
8118         (exp): New pattern using UNOP_INTRINSIC token.
8119         (f77_keywords): Add 'abs' keyword.
8120         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8121         (value_from_host_double): New function.
8122         (evaluate_subexp_f): Support UNOP_ABS.
8123
8124 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8125
8126         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8127         types.
8128
8129 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8130
8131         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8132         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8133         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8134
8135 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8136
8137         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8138
8139 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8140             Chris January  <chris.january@arm.com>
8141
8142         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8143         * f-exp.y: Define 'KIND' token.
8144         (exp): New pattern for KIND expressions.
8145         (ptype): Handle types with a kind extension.
8146         (direct_abs_decl): Extend to spot kind extensions.
8147         (f77_keywords): Add 'kind' to the list.
8148         (push_kind_type): New function.
8149         (convert_to_kind_type): New function.
8150         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8151         * parse.c (operator_length_standard): Likewise.
8152         * parser-defs.h (enum type_pieces): Add tp_kind.
8153         * std-operator.def: Add UNOP_KIND.
8154
8155 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8156
8157         * f-exp.y (f_parse): Set yydebug.
8158
8159 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8160
8161         * f-lang.c (evaluate_subexp_f): New function.
8162         (exp_descriptor_f): New global.
8163         (f_language_defn): Use exp_descriptor_f instead of
8164         exp_descriptor_standard.
8165
8166 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8167
8168         * f-exp.y (struct token): Add comments.
8169         (dot_ops): Remove uppercase versions and the end marker.
8170         (f77_keywords): Likewise.
8171         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8172         entries in the dot_ops array are case insensitive, and use
8173         strncasecmp to compare strings.  Also some whitespace cleanup in
8174         this area.  Similar for the f77_keywords array, except entries in
8175         this list might be case sensitive.
8176
8177 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8178
8179         * f-exp.y (struct f77_boolean_val): Add comments.
8180         (boolean_values): Remove uppercase versions, and end marker.
8181         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8182         and use strncasecmp to achieve case insensitivity.  Additionally,
8183         perform whitespace cleanup around this code.
8184
8185 2019-03-06  Tom Tromey  <tromey@adacore.com>
8186
8187         * remote-sim.c (gdbsim_target_open): Use result of
8188         gdb_argv::release.
8189
8190 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8191         Dirk Schubert  <dirk.schubert@arm.com>
8192         Chris January  <chris.january@arm.com>
8193
8194         * eval.c (evaluate_subexp_standard): Call Fortran argument
8195         wrapping logic.
8196         * f-lang.c (struct value): A value which can be passed into a
8197         Fortran function call.
8198         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8199         where appropriate.
8200         (struct type): Value ready for a Fortran function call.
8201         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8202         is needed.
8203         * f-lang.h (fortran_argument_convert): Declaration.
8204         (fortran_preserve_arg_pointer): Declaration.
8205         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8206
8207 2019-03-05  Tom Tromey  <tromey@adacore.com>
8208
8209         * python/py-prettyprint.c (print_string_repr): Remove #if.
8210         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8211
8212 2019-03-05  Tom Tromey  <tromey@adacore.com>
8213
8214         * target.c (the_dummy_target): Move later.  Change type to
8215         "dummy_target".
8216         (initialize_targets): Don't initialize the_dummy_target.
8217
8218 2019-03-05  Tom Tromey  <tromey@adacore.com>
8219
8220         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8221         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8222
8223 2019-03-05  Tom Tromey  <tromey@adacore.com>
8224
8225         * windows-nat.c (windows_nat_target::attach)
8226         (windows_nat_target::detach): Don't call gdb_flush.
8227         * valprint.c (generic_val_print, val_print, val_print_string):
8228         Don't call gdb_flush.
8229         * utils.c (defaulted_query): Don't call gdb_flush.
8230         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8231         * target.c (target_announce_detach): Don't call gdb_flush.
8232         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8233         * remote.c (extended_remote_target::attach): Don't call
8234         gdb_flush.
8235         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8236         * printcmd.c (do_examine): Don't call gdb_flush.
8237         (info_display_command): Don't call gdb_flush.
8238         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8239         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8240         * memattr.c (info_mem_command): Don't call gdb_flush.
8241         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8242         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8243         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8244         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8245         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8246         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8247         (gnu_nat_target::detach): Don't call gdb_flush.
8248         * f-valprint.c (f_val_print): Don't call gdb_flush.
8249         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8250         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8251         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8252         gdb_flush.
8253         * c-valprint.c (c_val_print): Don't call gdb_flush.
8254         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8255
8256 2019-03-05  Tom Tromey  <tromey@adacore.com>
8257
8258         * varobj.c (update_dynamic_varobj_children): Update.
8259         (install_default_visualizer): Use reset, not release.
8260         * value.c (set_internalvar): Update.
8261         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8262         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8263         ATTRIBUTE_UNUSED_RESULT.
8264
8265 2019-03-05  Tom Tromey  <tromey@adacore.com>
8266
8267         * remote.c (class scoped_remote_fd) <release>: Add
8268         ATTRIBUTE_UNUSED_RESULT.
8269
8270 2019-03-05  Tom Tromey  <tromey@adacore.com>
8271
8272         * macroexp.c (struct macro_buffer) <release>: Add
8273         ATTRIBUTE_UNUSED_RESULT.
8274
8275 2019-03-05  Tom Tromey  <tromey@adacore.com>
8276
8277         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8278         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8279         ATTRIBUTE_UNUSED_RESULT.
8280
8281 2019-03-05  Tom Tromey  <tromey@adacore.com>
8282
8283         * common/scoped_fd.h (class scoped_fd) <release>: Add
8284         ATTRIBUTE_UNUSED_RESULT.
8285
8286 2019-03-05  Tom Tromey  <tromey@adacore.com>
8287
8288         * parser-defs.h (struct parser_state) <release>: Add
8289         ATTRIBUTE_UNUSED_RESULT.
8290
8291 2019-03-05  Tom Tromey  <tromey@adacore.com>
8292
8293         * utils.h (class gdb_argv) <release>: Add
8294         ATTRIBUTE_UNUSED_RESULT.
8295         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8296
8297 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8298
8299         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8300         for-loop range, to avoid compiler warnings.
8301
8302         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8303         avoid compiler warnings about unused variables.
8304
8305         * NEWS: Mention end of support for native debugging on MS-Windows
8306         before XP.
8307
8308         PR gdb/24292
8309         * common/netstuff.c:
8310         * gdbserver/gdbreplay.c
8311         * gdbserver/remote-utils.c:
8312         * ser-tcp.c:
8313         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8314         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8315         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8316         'getaddrinfo' and 'freeaddrinfo' were not available before
8317         Windows XP, and mingw.org's MinGW headers by default define
8318         _WIN32_WINNT to 0x500.
8319
8320 2019-03-01  Gary Benson <gbenson@redhat.com>
8321
8322         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8323
8324 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8325             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8326
8327         PR gdb/8527
8328         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8329         set_sigint_trap, clear_sigint_trap.
8330
8331 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8332
8333         * target.c (target_detach): Clear the regcache and the
8334         frame cache.
8335
8336 2019-02-27  Pedro Alves  <palves@redhat.com>
8337
8338         * utils.c (set_screen_size): When we cap the height/width sizes,
8339         tweak the corresponding command variable to show "unlimited":
8340
8341 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8342             Pedro Alves  <palves@redhat.com>
8343
8344         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8345         before calling rl_set_screen_size.
8346
8347 2019-02-27  Tom Tromey  <tromey@adacore.com>
8348
8349         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8350         define.
8351         * python/py-value.c: Remove Python 2.4 workaround.
8352         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8353         workaround.
8354         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8355         Python 2.4 workaround.
8356         * python/python-internal.h: Remove Python 2.4 comment.
8357         (Py_ssize_t): Don't define.
8358         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8359         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8360         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8361         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8362         * python/python.c (do_start_initialization): Remove Python 2.4
8363         workaround.
8364         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8365         (print_children): Remove Python 2.4 workaround.
8366         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8367         workaround.
8368         (CHARBUFFERPROC_NAME): Remove.
8369         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8370         Python 2.4 workaround.
8371
8372 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8373
8374         * NEWS: Note minimum Python version.
8375
8376 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8377
8378         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8379         code from these functions.  Remove corresponding ifdefs.  Use
8380         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8381         Remove gotos and target of gotos.
8382         (infpy_search_memory): Likewise.
8383
8384 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8385
8386         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8387         (hppa_gdbarch_init): Don't register deleted functions with
8388         gdbarch.
8389
8390 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8391
8392         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8393         (h8300_unwind_sp): Delete.
8394         (h8300_dummy_id): Delete.
8395         (h8300_gdbarch_init): Don't register deleted functions with
8396         gdbarch.
8397
8398 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8399
8400         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8401         (ft32_unwind_pc): Delete.
8402         (ft32_unwind_sp): Delete.
8403         (ft32_gdbarch_init): Don't register deleted functions with
8404         gdbarch.
8405
8406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8407
8408         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8409         (frv_unwind_pc): Delete.
8410         (frv_unwind_sp): Delete.
8411         (frv_gdbarch_init): Don't register deleted functions with
8412         gdbarch.
8413
8414 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8415
8416         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8417         (riscv_unwind_pc): Delete.
8418         (riscv_unwind_sp): Delete.
8419         (riscv_gdbarch_init): Don't register deleted functions with
8420         gdbarch.
8421
8422 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8423
8424         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8425         (csky_unwind_pc): Delete.
8426         (csky_unwind_sp): Delete.
8427         (csky_gdbarch_init): Don't register deleted functions with
8428         gdbarch.
8429
8430 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8431
8432         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8433         (cris_unwind_pc): Delete.
8434         (cris_unwind_sp): Delete.
8435         (cris_gdbarch_init): Don't register deleted functions with
8436         gdbarch.
8437
8438 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8439
8440         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8441         (bfin_unwind_pc): Delete.
8442         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8443
8444 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8445
8446         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8447         (arm_unwind_pc): Delete.
8448         (arm_unwind_sp): Delete.
8449         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8450
8451 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8452
8453         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8454         (arc_unwind_pc): Delete.
8455         (arc_unwind_sp): Delete.
8456         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8457
8458 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8459
8460         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8461         (alpha_unwind_pc): Delete.
8462         (alpha_gdbarch_init): Don't register deleted functions with
8463         gdbarch.
8464
8465 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8466
8467         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8468         (aarch64_unwind_pc): Delete.
8469         (aarch64_unwind_sp): Delete.
8470         (aarch64_gdbarch_init): Don't register deleted functions with
8471         gdbarch.
8472
8473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8474
8475         * gdbtypes.c (type_align): Don't consider static members when
8476         computing structure alignment.
8477
8478 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8479
8480         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8481         return 0 for other types.
8482         * arch-utils.c (default_type_align): Always return 0.
8483         * gdbarch.h: Regenerate.
8484         * gdbarch.sh (type_align): Extend comment.
8485         * gdbtypes.c (type_align): Add additional comments, always call
8486         gdbarch_type_align before applying the default rules.
8487         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8488         generic code will then apply a suitable default.
8489         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8490         types, return 0 for other types.
8491
8492 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8493
8494         * NEWS: Create a new section for the next release branch.
8495         Rename the section of the current branch, now that it has
8496         been cut.
8497
8498 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8499
8500         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8501         * version.in: Bump version to 8.3.50.DATE-git.
8502
8503 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8504
8505         * aix-thread.c (ptid_cmp): Remove unused variable.
8506         (get_signaled_thread): Likewise.
8507         (store_regs_user_thread): Likewise.
8508         (store_regs_kernel_thread): Likewise.
8509         (fetch_regs_kernel_thread): Remove shadowed variable.
8510
8511 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8512
8513         * features/riscv/32bit-cpu.xml: Add register numbers.
8514         * features/riscv/32bit-fpu.c: Regenerate.
8515         * features/riscv/32bit-fpu.xml: Add register numbers.
8516         * features/riscv/64bit-cpu.xml: Add register numbers.
8517         * features/riscv/64bit-fpu.c: Regenerate.
8518         * features/riscv/64bit-fpu.xml: Add register numbers.
8519
8520 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8521
8522         * NEWS: Mention two argument form of gdb.Value constructor.
8523         * python/py-value.c (convert_buffer_and_type_to_value): New
8524         function.
8525         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8526         Add support for handling an optional second argument.  Call
8527         convert_buffer_and_type_to_value as appropriate.
8528         * python/python-internal.h (Py_buffer_deleter): New struct.
8529         (Py_buffer_up): New typedef.
8530
8531 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8532
8533         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8534         instead of releasing ownership.
8535
8536 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8537
8538         * dwarf2read.c (open_and_init_dwp_file): Call
8539         elf_numsections instead of bfd_count_sections to initialize
8540         dwp_file->num_sections.
8541
8542 2019-02-25  Tom Tromey  <tromey@adacore.com>
8543
8544         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8545
8546 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8547
8548         * gcore.in: Add '--readnever' option when invoking GDB.
8549
8550 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8551
8552         * MAINTAINERS: Update my email address.
8553
8554 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8555
8556         * build-id.c (build_id_to_debug_bfd_1): New function.
8557         (build_id_to_debug_bfd): Look for separate debug file in
8558         sysroot.
8559
8560 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8561
8562         * gdbarch.sh: Update the copyright year range that is placed into
8563         generated files.
8564
8565 2019-02-22  Keith Seitz  <keiths@redhat.com>
8566
8567         PR symtab/23853
8568         * linespec.c (create_sals_line_offset): Search for the default
8569         symtab's filename instead of its fullname.
8570
8571 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8572
8573         * NEWS: Update style defaults.
8574
8575 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8576
8577         * main.c (captured_main_1): Disable styling in batch mode.
8578
8579 2019-02-20  Tom Tromey  <tom@tromey.com>
8580
8581         * symtab.c (symtab_symbol_info): Fix typos.
8582
8583 2019-02-20  Tom Tromey  <tromey@adacore.com>
8584
8585         * findcmd.c (_initialize_mem_search): Use upper case for
8586         metasyntactic variables.
8587
8588 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8589
8590         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8591         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8592
8593 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8594
8595         * top.h (source_file_name): Change to std::string.
8596         * top.c (source_file_name): Likewise.
8597         (command_line_input): Adjust.
8598         * cli/cli-script.c (script_from_file): Adjust.
8599
8600 2019-02-19  Tom Tromey  <tromey@adacore.com>
8601
8602         * ravenscar-thread.c
8603         (ravenscar_thread_target::update_thread_list): Don't call
8604         ada_build_task_list.
8605         * ada-lang.h (ada_build_task_list): Don't declare.
8606         * ada-tasks.c (struct ada_tasks_inferior_data)
8607         <task_list_valid_p>: Now bool.
8608         (read_known_tasks, ada_task_list_changed)
8609         (ada_tasks_invalidate_inferior_data): Update.
8610         (read_known_tasks_array): Return bool.
8611         (read_known_tasks_list): Likewise.
8612         (read_known_tasks): Return void.
8613         (ada_build_task_list): Now static.
8614
8615 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8616
8617         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8618         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8619
8620 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8621
8622         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8623         variant for ada_tasks_pspace_data_handle and
8624         ada_tasks_inferior_data_handle.
8625         (ada_tasks_pspace_data_cleanup): New function.
8626         (ada_tasks_inferior_data_cleanup): New function.
8627
8628 2019-02-17  Tom Tromey  <tom@tromey.com>
8629
8630         * macrotab.h (macro_source_fullname): Return a std::string.
8631         * macrotab.c (macro_include, check_for_redefinition)
8632         (macro_undef, macro_lookup_definition, foreach_macro)
8633         (foreach_macro_in_scope): Update.
8634         (macro_source_fullname): Return a std::string.
8635         * macrocmd.c (show_pp_source_pos): Update.
8636
8637 2019-02-17  Tom Tromey  <tom@tromey.com>
8638
8639         * macrocmd.c (show_pp_source_pos): Style the file names.
8640
8641 2019-02-17  Tom Tromey  <tom@tromey.com>
8642
8643         PR tui/24197:
8644         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8645
8646 2019-02-17  Tom Tromey  <tom@tromey.com>
8647
8648         * ada-lang.c (user_select_syms): Use filtered printing.
8649         * utils.c (wrap_style): New global.
8650         (desired_style): Remove.
8651         (emit_style_escape): Add stream parameter.
8652         (set_output_style, reset_terminal_style, prompt_for_continue):
8653         Update.
8654         (flush_wrap_buffer): Only flush gdb_stdout.
8655         (wrap_here): Set wrap_style.
8656         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8657         treat escape sequences as a character.  Change when wrap buffer is
8658         flushed.
8659         (fputs_styled): Do not set the output style when the default is
8660         requested.
8661         * ui-style.h (struct ui_file_style) <is_default>: New method.
8662         * source.c (print_source_lines_base): Emit escape sequences in one
8663         piece.
8664
8665 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8666
8667         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8668         integers and enumeration types.
8669
8670 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8671
8672         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8673         instead of lookup_symbol_in_language
8674         (do_exact_match): New function.
8675         (ada_get_symbol_name_matcher): Return do_exact_match when
8676         doing a verbatim match.
8677
8678 2019-02-15  Tom Tromey  <tromey@adacore.com>
8679
8680         * ravenscar-thread.c (ravenscar_thread_target::resume)
8681         (ravenscar_thread_target::wait): Special case wildcard requests.
8682
8683 2019-02-15  Tom Tromey  <tromey@adacore.com>
8684
8685         * ravenscar-thread.c (base_ptid): Remove.
8686         (struct ravenscar_thread_target) <close>: New method.
8687         <m_base_ptid>: New member.
8688         <update_inferior_ptid, active_task, task_is_currently_active,
8689         runtime_initialized>: Declare methods.
8690         <ravenscar_thread_target>: Add constructor.
8691         (ravenscar_thread_target::task_is_currently_active)
8692         (ravenscar_thread_target::update_inferior_ptid)
8693         (ravenscar_runtime_initialized): Rename.  Now methods.
8694         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8695         (ravenscar_thread_target::update_thread_list): Update.
8696         (ravenscar_thread_target::active_task): Now method.
8697         (ravenscar_thread_target::store_registers)
8698         (ravenscar_thread_target::prepare_to_store)
8699         (ravenscar_thread_target::prepare_to_store)
8700         (ravenscar_thread_target::mourn_inferior): Update.
8701         (ravenscar_inferior_created): Use "new" to create target.
8702         (ravenscar_thread_target::get_ada_task_ptid): Update.
8703         (_initialize_ravenscar): Don't initialize base_ptid.
8704         (ravenscar_ops): Remove global.
8705
8706 2019-02-15  Tom Tromey  <tromey@adacore.com>
8707
8708         * target.h (push_target): Declare new overload.
8709         * target.c (push_target): New overload, taking an rvalue reference.
8710         * remote.c (remote_target::open_1): Use push_target overload.
8711         * corelow.c (core_target_open): Use push_target overload.
8712
8713 2019-02-15  Tom Tromey  <tromey@adacore.com>
8714
8715         * ravenscar-thread.c (is_ravenscar_task)
8716         (ravenscar_task_is_currently_active): Return bool.
8717         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8718         (_initialize_ravenscar): Remove "(void)".
8719         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8720         Return bool.
8721
8722 2019-02-15  Tom Tromey  <tromey@adacore.com>
8723
8724         * ravenscar-thread.c (ravenscar_runtime_initializer)
8725         (has_ravenscar_runtime, get_running_thread_id)
8726         (ravenscar_thread_target::resume): Fix indentation.
8727
8728 2019-02-15  Tom Tromey  <tromey@adacore.com>
8729
8730         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8731         from ravenscar_arch_ops.
8732         (sparc_ravenscar_ops::fetch_registers)
8733         (sparc_ravenscar_ops::store_registers): Now methods.
8734         (sparc_ravenscar_prepare_to_store): Remove.
8735         (sparc_ravenscar_ops): Redefine.
8736         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8737         methods and destructor.  Remove members.
8738         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8739         (ravenscar_thread_target::store_registers)
8740         (ravenscar_thread_target::prepare_to_store): Update.
8741         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8742         Remove.
8743         (struct ppc_ravenscar_powerpc_ops): Derive from
8744         ravenscar_arch_ops.
8745         (ppc_ravenscar_powerpc_ops::fetch_registers)
8746         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8747         (ppc_ravenscar_powerpc_ops): Redefine.
8748         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8749         (ppc_ravenscar_e500_ops::fetch_registers)
8750         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8751         (ppc_ravenscar_e500_ops): Redefine.
8752         * aarch64-ravenscar-thread.c
8753         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8754         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8755         (aarch64_ravenscar_fetch_registers)
8756         (aarch64_ravenscar_store_registers): Now methods.
8757         (aarch64_ravenscar_ops): Redefine.
8758
8759 2019-02-15  Tom Tromey  <tromey@adacore.com>
8760
8761         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8762         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8763         (ravenscar_thread_target::stopped_by_watchpoint)
8764         (ravenscar_thread_target::stopped_data_address)
8765         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8766
8767 2019-02-15  Tom Tromey  <tromey@adacore.com>
8768
8769         * ravenscar-thread.c: Fix some typos.
8770
8771 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8772             Tom Tromey  <tromey@adacore.com>
8773
8774         * ada-lang.c (ada_exception_sal): Change addr_string to a
8775         std::string.
8776         (create_ada_exception_catchpoint): Update.
8777
8778 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8779             Tom Tromey  <tromey@adacore.com>
8780
8781         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8782         (bp_location_ops): Remove.
8783         (base_breakpoint_allocate_location): Update.
8784         (free_bp_location): Update.
8785         * ada-lang.c (class ada_catchpoint_location)
8786         <ada_catchpoint_location>: Remove ops parameter.
8787         (ada_catchpoint_location_dtor): Remove.
8788         (ada_catchpoint_location_ops): Remove.
8789         (allocate_location_exception): Update.
8790         * breakpoint.h (struct bp_location_ops): Remove.
8791         (class bp_location) <bp_location>: Remove bp_location_ops
8792         parameter.
8793         <~bp_location>: Add destructor.
8794         <ops>: Remove.
8795
8796 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8797             Pedro Alves  <palves@redhat.com>
8798
8799         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8800         'PATH_MAX'.
8801
8802 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8803             Samuel Thibault  <samuel.thibault@gnu.org>
8804             Thomas Schwinge  <thomas@codesourcery.com>
8805
8806         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8807         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8808
8809 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8810
8811         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8812         (check_empty): Use "const char *".
8813
8814         * gnu-nat.c (gnu_nat_target::detach): Instead of
8815         'detach_inferior (pid)' call
8816         'detach_inferior (find_inferior_pid (pid))'.
8817
8818         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8819         'nat/fork-inferior.o'.
8820         * gnu-nat.c: #include "nat/fork-inferior.h".
8821
8822         * gnu-nat.c (gnu_nat_target::detach): Instead of
8823         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8824         * gnu-nat.h: #include "inf-child.h".
8825         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8826         'i386_gnu_nat_target::fetch_registers'.
8827         (gnu_store_registers): Rename/move to
8828         'i386_gnu_nat_target::store_registers'.
8829
8830         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8831         * gnu-nat.h (mach_thread_info): New function.
8832         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8833
8834         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8835
8836 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8837
8838         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8839
8840 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8841
8842         * windows-nat.c (windows_add_thread): Add new parameter
8843         "main_thread_p" with default value set to false.  Update
8844         function documentation as well as all callers.
8845         (windows_delete_thread): Likewise.
8846         (fake_create_process): Update call to windows_add_thread.
8847         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8848         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8849         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8850         call to windows_delete_thread.
8851
8852 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8853
8854         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8855
8856 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8857
8858         * symfile.c (find_separate_debug_file): Use canonical path of
8859         sysroot with child_path instead of gdb_sysroot if it is valid.
8860
8861 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8862
8863         * symfile.c (find_separate_debug_file): Use child_path to
8864         determine if an object file is under a sysroot.
8865
8866 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8867
8868         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8869         unittests/child-path-selftests.c.
8870         * common/pathstuff.c (child_path): New function.
8871         * common/pathstuff.h (child_path): New prototype.
8872         * unittests/child-path-selftests.c: New file.
8873
8874 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8875
8876         * symfile.c (find_separate_debug_file): Look for separate debug
8877         files in debug directories under the sysroot.
8878
8879 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8880
8881         * symtab.h (struct minimal_symbol data_p): New const method.
8882         (struct minimal_symbol text_p): Likewise.
8883         * symtab.c (output_source_filename): Use file name style
8884         to print file name.
8885         (print_symbol_info): Likewise.
8886         (print_msymbol_info): Use address style to print addresses.
8887         Use function name style to print executable text symbols.
8888         (expand_symtab_containing_pc): Use data_p.
8889         (find_pc_sect_compunit_symtab): Likewise.
8890
8891 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8892
8893         * breakpoint.c (describe_other_breakpoints): Use address style
8894         to print addresses.
8895         (say_where): Likewise.
8896
8897 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8898
8899         * ada-typeprint.c (print_func_type): Print function name
8900         style to print function name.
8901         * c-typeprint.c (c_print_type_1): Likewise.
8902
8903 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8904
8905         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8906         for execve.
8907
8908 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8909
8910         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8911         type_stack.
8912
8913 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8914
8915         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8916         TYPE_CODE_REF types.
8917
8918 2019-02-08  Jim Wilson  <jimw@sifive.com>
8919
8920         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8921         (riscv_linux_fregset): New.
8922         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8923
8924 2019-02-07  Tom Tromey  <tom@tromey.com>
8925
8926         * thread.c (thread_cancel_execution_command): Update.
8927         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8928         methods.
8929         (struct thread_fsm_ops): Remove.
8930         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8931         (thread_fsm_should_stop, thread_fsm_return_value)
8932         (thread_fsm_set_finished, thread_fsm_finished_p)
8933         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8934         Don't declare.
8935         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8936         * infrun.c (clear_proceed_status_thread)
8937         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8938         (print_stop_event): Update.
8939         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8940         Add constructor.
8941         (step_command_fsm_ops): Remove.
8942         (new_step_command_fsm): Remove.
8943         (step_1): Update.
8944         (step_command_fsm::should_stop): Rename from
8945         step_command_fsm_should_stop.
8946         (step_command_fsm::clean_up): Rename from
8947         step_command_fsm_clean_up.
8948         (step_command_fsm::do_async_reply_reason): Rename from
8949         step_command_fsm_async_reply_reason.
8950         (struct until_next_fsm): Inherit from thread_fsm.  Add
8951         constructor.
8952         (until_next_fsm_ops): Remove.
8953         (new_until_next_fsm): Remove.
8954         (until_next_fsm::should_stop): Rename from
8955         until_next_fsm_should_stop.
8956         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8957         (until_next_fsm::do_async_reply_reason): Rename from
8958         until_next_fsm_async_reply_reason.
8959         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8960         constructor.  Change type of breakpoint.
8961         (finish_command_fsm_ops): Remove.
8962         (new_finish_command_fsm): Remove.
8963         (finish_command_fsm::should_stop): Rename from
8964         finish_command_fsm_should_stop.
8965         (finish_command_fsm::clean_up): Rename from
8966         finish_command_fsm_clean_up.
8967         (finish_command_fsm::return_value): Rename from
8968         finish_command_fsm_return_value.
8969         (finish_command_fsm::do_async_reply_reason): Rename from
8970         finish_command_fsm_async_reply_reason.
8971         (finish_command): Update.
8972         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8973         Add constructor.
8974         (call_thread_fsm_ops): Remove.
8975         (call_thread_fsm::call_thread_fsm): Rename from
8976         new_call_thread_fsm.
8977         (call_thread_fsm::should_stop): Rename from
8978         call_thread_fsm_should_stop.
8979         (call_thread_fsm::should_notify_stop): Rename from
8980         call_thread_fsm_should_notify_stop.
8981         (run_inferior_call, call_function_by_hand_dummy): Update.
8982         * cli/cli-interp.c (should_print_stop_to_console): Update.
8983         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8984         Add constructor.  Change type of location_breakpoint,
8985         caller_breakpoint.
8986         (until_break_fsm_ops): Remove.
8987         (new_until_break_fsm): Remove.
8988         (until_break_fsm::should_stop): Rename from
8989         until_break_fsm_should_stop.
8990         (until_break_fsm::clean_up): Rename from
8991         until_break_fsm_clean_up.
8992         (until_break_fsm::do_async_reply_reason): Rename from
8993         until_break_fsm_async_reply_reason.
8994         (until_break_command): Update.
8995         * thread-fsm.c: Remove.
8996         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8997
8998 2019-02-07  Tom Tromey  <tom@tromey.com>
8999
9000         * yy-remap.h: Add include guard.
9001         * xtensa-tdep.h: Add include guard.
9002         * xcoffread.h: Rename include guard.
9003         * varobj-iter.h: Add include guard.
9004         * tui/tui.h: Rename include guard.
9005         * tui/tui-winsource.h: Rename include guard.
9006         * tui/tui-wingeneral.h: Rename include guard.
9007         * tui/tui-windata.h: Rename include guard.
9008         * tui/tui-win.h: Rename include guard.
9009         * tui/tui-stack.h: Rename include guard.
9010         * tui/tui-source.h: Rename include guard.
9011         * tui/tui-regs.h: Rename include guard.
9012         * tui/tui-out.h: Rename include guard.
9013         * tui/tui-layout.h: Rename include guard.
9014         * tui/tui-io.h: Rename include guard.
9015         * tui/tui-hooks.h: Rename include guard.
9016         * tui/tui-file.h: Rename include guard.
9017         * tui/tui-disasm.h: Rename include guard.
9018         * tui/tui-data.h: Rename include guard.
9019         * tui/tui-command.h: Rename include guard.
9020         * tic6x-tdep.h: Add include guard.
9021         * target/waitstatus.h: Rename include guard.
9022         * target/wait.h: Rename include guard.
9023         * target/target.h: Rename include guard.
9024         * target/resume.h: Rename include guard.
9025         * target-float.h: Rename include guard.
9026         * stabsread.h: Add include guard.
9027         * rs6000-tdep.h: Add include guard.
9028         * riscv-fbsd-tdep.h: Add include guard.
9029         * regformats/regdef.h: Rename include guard.
9030         * record.h: Rename include guard.
9031         * python/python.h: Rename include guard.
9032         * python/python-internal.h: Rename include guard.
9033         * python/py-stopevent.h: Rename include guard.
9034         * python/py-ref.h: Rename include guard.
9035         * python/py-record.h: Rename include guard.
9036         * python/py-record-full.h: Rename include guard.
9037         * python/py-record-btrace.h: Rename include guard.
9038         * python/py-instruction.h: Rename include guard.
9039         * python/py-events.h: Rename include guard.
9040         * python/py-event.h: Rename include guard.
9041         * procfs.h: Add include guard.
9042         * proc-utils.h: Add include guard.
9043         * p-lang.h: Add include guard.
9044         * or1k-tdep.h: Rename include guard.
9045         * observable.h: Rename include guard.
9046         * nto-tdep.h: Rename include guard.
9047         * nat/x86-linux.h: Rename include guard.
9048         * nat/x86-linux-dregs.h: Rename include guard.
9049         * nat/x86-gcc-cpuid.h: Add include guard.
9050         * nat/x86-dregs.h: Rename include guard.
9051         * nat/x86-cpuid.h: Rename include guard.
9052         * nat/ppc-linux.h: Rename include guard.
9053         * nat/mips-linux-watch.h: Rename include guard.
9054         * nat/linux-waitpid.h: Rename include guard.
9055         * nat/linux-ptrace.h: Rename include guard.
9056         * nat/linux-procfs.h: Rename include guard.
9057         * nat/linux-osdata.h: Rename include guard.
9058         * nat/linux-nat.h: Rename include guard.
9059         * nat/linux-namespaces.h: Rename include guard.
9060         * nat/linux-btrace.h: Rename include guard.
9061         * nat/glibc_thread_db.h: Rename include guard.
9062         * nat/gdb_thread_db.h: Rename include guard.
9063         * nat/gdb_ptrace.h: Rename include guard.
9064         * nat/fork-inferior.h: Rename include guard.
9065         * nat/amd64-linux-siginfo.h: Rename include guard.
9066         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9067         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9068         * nat/aarch64-linux.h: Rename include guard.
9069         * nat/aarch64-linux-hw-point.h: Rename include guard.
9070         * mn10300-tdep.h: Add include guard.
9071         * mips-linux-tdep.h: Add include guard.
9072         * mi/mi-parse.h: Rename include guard.
9073         * mi/mi-out.h: Rename include guard.
9074         * mi/mi-main.h: Rename include guard.
9075         * mi/mi-interp.h: Rename include guard.
9076         * mi/mi-getopt.h: Rename include guard.
9077         * mi/mi-console.h: Rename include guard.
9078         * mi/mi-common.h: Rename include guard.
9079         * mi/mi-cmds.h: Rename include guard.
9080         * mi/mi-cmd-break.h: Rename include guard.
9081         * m2-lang.h: Add include guard.
9082         * location.h: Rename include guard.
9083         * linux-record.h: Rename include guard.
9084         * linux-nat.h: Add include guard.
9085         * linux-fork.h: Add include guard.
9086         * i386-darwin-tdep.h: Rename include guard.
9087         * hppa-linux-offsets.h: Add include guard.
9088         * guile/guile.h: Rename include guard.
9089         * guile/guile-internal.h: Rename include guard.
9090         * gnu-nat.h: Rename include guard.
9091         * gdb-stabs.h: Rename include guard.
9092         * frv-tdep.h: Add include guard.
9093         * f-lang.h: Add include guard.
9094         * event-loop.h: Add include guard.
9095         * darwin-nat.h: Rename include guard.
9096         * cp-abi.h: Rename include guard.
9097         * config/sparc/nm-sol2.h: Rename include guard.
9098         * config/nm-nto.h: Rename include guard.
9099         * config/nm-linux.h: Add include guard.
9100         * config/i386/nm-i386gnu.h: Rename include guard.
9101         * config/djgpp/nl_types.h: Rename include guard.
9102         * config/djgpp/langinfo.h: Rename include guard.
9103         * compile/gcc-cp-plugin.h: Add include guard.
9104         * compile/gcc-c-plugin.h: Add include guard.
9105         * compile/compile.h: Rename include guard.
9106         * compile/compile-object-run.h: Rename include guard.
9107         * compile/compile-object-load.h: Rename include guard.
9108         * compile/compile-internal.h: Rename include guard.
9109         * compile/compile-cplus.h: Rename include guard.
9110         * compile/compile-c.h: Rename include guard.
9111         * common/xml-utils.h: Rename include guard.
9112         * common/x86-xstate.h: Rename include guard.
9113         * common/version.h: Rename include guard.
9114         * common/vec.h: Rename include guard.
9115         * common/tdesc.h: Rename include guard.
9116         * common/selftest.h: Rename include guard.
9117         * common/scoped_restore.h: Rename include guard.
9118         * common/scoped_mmap.h: Rename include guard.
9119         * common/scoped_fd.h: Rename include guard.
9120         * common/safe-iterator.h: Rename include guard.
9121         * common/run-time-clock.h: Rename include guard.
9122         * common/refcounted-object.h: Rename include guard.
9123         * common/queue.h: Rename include guard.
9124         * common/ptid.h: Rename include guard.
9125         * common/print-utils.h: Rename include guard.
9126         * common/preprocessor.h: Rename include guard.
9127         * common/pathstuff.h: Rename include guard.
9128         * common/observable.h: Rename include guard.
9129         * common/netstuff.h: Rename include guard.
9130         * common/job-control.h: Rename include guard.
9131         * common/host-defs.h: Rename include guard.
9132         * common/gdb_wait.h: Rename include guard.
9133         * common/gdb_vecs.h: Rename include guard.
9134         * common/gdb_unlinker.h: Rename include guard.
9135         * common/gdb_unique_ptr.h: Rename include guard.
9136         * common/gdb_tilde_expand.h: Rename include guard.
9137         * common/gdb_sys_time.h: Rename include guard.
9138         * common/gdb_string_view.h: Rename include guard.
9139         * common/gdb_splay_tree.h: Rename include guard.
9140         * common/gdb_setjmp.h: Rename include guard.
9141         * common/gdb_ref_ptr.h: Rename include guard.
9142         * common/gdb_optional.h: Rename include guard.
9143         * common/gdb_locale.h: Rename include guard.
9144         * common/gdb_assert.h: Rename include guard.
9145         * common/filtered-iterator.h: Rename include guard.
9146         * common/filestuff.h: Rename include guard.
9147         * common/fileio.h: Rename include guard.
9148         * common/environ.h: Rename include guard.
9149         * common/common-utils.h: Rename include guard.
9150         * common/common-types.h: Rename include guard.
9151         * common/common-regcache.h: Rename include guard.
9152         * common/common-inferior.h: Rename include guard.
9153         * common/common-gdbthread.h: Rename include guard.
9154         * common/common-exceptions.h: Rename include guard.
9155         * common/common-defs.h: Rename include guard.
9156         * common/common-debug.h: Rename include guard.
9157         * common/cleanups.h: Rename include guard.
9158         * common/buffer.h: Rename include guard.
9159         * common/btrace-common.h: Rename include guard.
9160         * common/break-common.h: Rename include guard.
9161         * cli/cli-utils.h: Rename include guard.
9162         * cli/cli-style.h: Rename include guard.
9163         * cli/cli-setshow.h: Rename include guard.
9164         * cli/cli-script.h: Rename include guard.
9165         * cli/cli-interp.h: Rename include guard.
9166         * cli/cli-decode.h: Rename include guard.
9167         * cli/cli-cmds.h: Rename include guard.
9168         * charset-list.h: Add include guard.
9169         * buildsym-legacy.h: Rename include guard.
9170         * bfin-tdep.h: Add include guard.
9171         * ax.h: Rename include guard.
9172         * arm-linux-tdep.h: Add include guard.
9173         * arm-fbsd-tdep.h: Add include guard.
9174         * arch/xtensa.h: Rename include guard.
9175         * arch/tic6x.h: Add include guard.
9176         * arch/i386.h: Add include guard.
9177         * arch/arm.h: Rename include guard.
9178         * arch/arm-linux.h: Rename include guard.
9179         * arch/arm-get-next-pcs.h: Rename include guard.
9180         * arch/amd64.h: Add include guard.
9181         * arch/aarch64-insn.h: Rename include guard.
9182         * arch-utils.h: Rename include guard.
9183         * annotate.h: Add include guard.
9184         * amd64-darwin-tdep.h: Rename include guard.
9185         * aarch64-linux-tdep.h: Add include guard.
9186         * aarch64-fbsd-tdep.h: Add include guard.
9187         * aarch32-linux-nat.h: Add include guard.
9188
9189 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9190
9191         * macrotab.c (macro_define_internal): New function that
9192         factorizes macro_define_object_internal and macro_define_function
9193         code.
9194         (macro_define_object_internal): Use macro_define_internal.
9195         (macro_define_function): Likewise.
9196
9197 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9198
9199         * macrocmd.c (extract_identifier): Return
9200         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9201         callers.
9202
9203 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9204
9205         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9206
9207 2019-02-05  Tom Tromey  <tom@tromey.com>
9208
9209         * target.c (target_stack::unpush): Move assertion earlier.
9210
9211 2019-01-30  Tom Tromey  <tom@tromey.com>
9212
9213         PR python/23615:
9214         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9215         (gdbpy_parse_and_eval): Likewise.
9216         * python/python-internal.h (gdbpy_allow_threads): New class.
9217
9218 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9219
9220         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9221         (aarch64_fbsd_fpregmap): Move earlier.
9222         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9223         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9224         instead of individual calls to trad_frame_set_reg_addr.
9225         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9226         earlier.
9227         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9228         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9229         instead of individual calls to trad_frame_set_reg_addr.
9230
9231 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9232
9233         * CONTRIBUTE: Replace contribution list with wiki link.
9234
9235 2019-01-25  Tom Tromey  <tom@tromey.com>
9236
9237         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9238
9239 2019-01-25  Tom Tromey  <tom@tromey.com>
9240
9241         * xtensa-linux-nat.c: Fix common/ includes.
9242         * xml-support.h: Fix common/ includes.
9243         * xml-support.c: Fix common/ includes.
9244         * x86-linux-nat.c: Fix common/ includes.
9245         * windows-nat.c: Fix common/ includes.
9246         * varobj.h: Fix common/ includes.
9247         * varobj.c: Fix common/ includes.
9248         * value.c: Fix common/ includes.
9249         * valops.c: Fix common/ includes.
9250         * utils.c: Fix common/ includes.
9251         * unittests/xml-utils-selftests.c: Fix common/ includes.
9252         * unittests/utils-selftests.c: Fix common/ includes.
9253         * unittests/unpack-selftests.c: Fix common/ includes.
9254         * unittests/tracepoint-selftests.c: Fix common/ includes.
9255         * unittests/style-selftests.c: Fix common/ includes.
9256         * unittests/string_view-selftests.c: Fix common/ includes.
9257         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9258         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9259         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9260         * unittests/rsp-low-selftests.c: Fix common/ includes.
9261         * unittests/parse-connection-spec-selftests.c: Fix common/
9262         includes.
9263         * unittests/optional-selftests.c: Fix common/ includes.
9264         * unittests/offset-type-selftests.c: Fix common/ includes.
9265         * unittests/observable-selftests.c: Fix common/ includes.
9266         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9267         * unittests/memrange-selftests.c: Fix common/ includes.
9268         * unittests/memory-map-selftests.c: Fix common/ includes.
9269         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9270         * unittests/function-view-selftests.c: Fix common/ includes.
9271         * unittests/environ-selftests.c: Fix common/ includes.
9272         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9273         * unittests/common-utils-selftests.c: Fix common/ includes.
9274         * unittests/cli-utils-selftests.c: Fix common/ includes.
9275         * unittests/array-view-selftests.c: Fix common/ includes.
9276         * ui-file.c: Fix common/ includes.
9277         * tui/tui-io.c: Fix common/ includes.
9278         * tracepoint.h: Fix common/ includes.
9279         * tracepoint.c: Fix common/ includes.
9280         * tracefile-tfile.c: Fix common/ includes.
9281         * top.h: Fix common/ includes.
9282         * top.c: Fix common/ includes.
9283         * thread.c: Fix common/ includes.
9284         * target/waitstatus.h: Fix common/ includes.
9285         * target/waitstatus.c: Fix common/ includes.
9286         * target.h: Fix common/ includes.
9287         * target.c: Fix common/ includes.
9288         * target-memory.c: Fix common/ includes.
9289         * target-descriptions.c: Fix common/ includes.
9290         * symtab.h: Fix common/ includes.
9291         * symfile.c: Fix common/ includes.
9292         * stap-probe.c: Fix common/ includes.
9293         * spu-linux-nat.c: Fix common/ includes.
9294         * sparc-nat.c: Fix common/ includes.
9295         * source.c: Fix common/ includes.
9296         * solib.c: Fix common/ includes.
9297         * solib-target.c: Fix common/ includes.
9298         * ser-unix.c: Fix common/ includes.
9299         * ser-tcp.c: Fix common/ includes.
9300         * ser-pipe.c: Fix common/ includes.
9301         * ser-base.c: Fix common/ includes.
9302         * selftest-arch.c: Fix common/ includes.
9303         * s12z-tdep.c: Fix common/ includes.
9304         * rust-exp.y: Fix common/ includes.
9305         * rs6000-aix-tdep.c: Fix common/ includes.
9306         * riscv-tdep.c: Fix common/ includes.
9307         * remote.c: Fix common/ includes.
9308         * remote-notif.h: Fix common/ includes.
9309         * remote-fileio.h: Fix common/ includes.
9310         * remote-fileio.c: Fix common/ includes.
9311         * regcache.h: Fix common/ includes.
9312         * regcache.c: Fix common/ includes.
9313         * record-btrace.c: Fix common/ includes.
9314         * python/python.c: Fix common/ includes.
9315         * python/py-type.c: Fix common/ includes.
9316         * python/py-inferior.c: Fix common/ includes.
9317         * progspace.h: Fix common/ includes.
9318         * producer.c: Fix common/ includes.
9319         * procfs.c: Fix common/ includes.
9320         * proc-api.c: Fix common/ includes.
9321         * printcmd.c: Fix common/ includes.
9322         * ppc-linux-nat.c: Fix common/ includes.
9323         * parser-defs.h: Fix common/ includes.
9324         * osdata.c: Fix common/ includes.
9325         * obsd-nat.c: Fix common/ includes.
9326         * nat/x86-linux.c: Fix common/ includes.
9327         * nat/x86-linux-dregs.c: Fix common/ includes.
9328         * nat/x86-dregs.h: Fix common/ includes.
9329         * nat/x86-dregs.c: Fix common/ includes.
9330         * nat/ppc-linux.c: Fix common/ includes.
9331         * nat/mips-linux-watch.h: Fix common/ includes.
9332         * nat/mips-linux-watch.c: Fix common/ includes.
9333         * nat/linux-waitpid.c: Fix common/ includes.
9334         * nat/linux-ptrace.h: Fix common/ includes.
9335         * nat/linux-ptrace.c: Fix common/ includes.
9336         * nat/linux-procfs.c: Fix common/ includes.
9337         * nat/linux-personality.c: Fix common/ includes.
9338         * nat/linux-osdata.c: Fix common/ includes.
9339         * nat/linux-namespaces.c: Fix common/ includes.
9340         * nat/linux-btrace.h: Fix common/ includes.
9341         * nat/linux-btrace.c: Fix common/ includes.
9342         * nat/fork-inferior.c: Fix common/ includes.
9343         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9344         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9345         * nat/aarch64-linux.c: Fix common/ includes.
9346         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9347         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9348         * namespace.h: Fix common/ includes.
9349         * mips-linux-tdep.c: Fix common/ includes.
9350         * minsyms.c: Fix common/ includes.
9351         * mi/mi-parse.h: Fix common/ includes.
9352         * mi/mi-main.c: Fix common/ includes.
9353         * mi/mi-cmd-env.c: Fix common/ includes.
9354         * memrange.h: Fix common/ includes.
9355         * memattr.c: Fix common/ includes.
9356         * maint.h: Fix common/ includes.
9357         * maint.c: Fix common/ includes.
9358         * main.c: Fix common/ includes.
9359         * machoread.c: Fix common/ includes.
9360         * location.c: Fix common/ includes.
9361         * linux-thread-db.c: Fix common/ includes.
9362         * linux-nat.c: Fix common/ includes.
9363         * linux-fork.c: Fix common/ includes.
9364         * inline-frame.c: Fix common/ includes.
9365         * infrun.c: Fix common/ includes.
9366         * inflow.c: Fix common/ includes.
9367         * inferior.h: Fix common/ includes.
9368         * inferior.c: Fix common/ includes.
9369         * infcmd.c: Fix common/ includes.
9370         * inf-ptrace.c: Fix common/ includes.
9371         * inf-child.c: Fix common/ includes.
9372         * ia64-linux-nat.c: Fix common/ includes.
9373         * i387-tdep.c: Fix common/ includes.
9374         * i386-tdep.c: Fix common/ includes.
9375         * i386-linux-tdep.c: Fix common/ includes.
9376         * i386-linux-nat.c: Fix common/ includes.
9377         * i386-go32-tdep.c: Fix common/ includes.
9378         * i386-fbsd-tdep.c: Fix common/ includes.
9379         * i386-fbsd-nat.c: Fix common/ includes.
9380         * guile/scm-type.c: Fix common/ includes.
9381         * guile/guile.c: Fix common/ includes.
9382         * go32-nat.c: Fix common/ includes.
9383         * gnu-nat.c: Fix common/ includes.
9384         * gdbthread.h: Fix common/ includes.
9385         * gdbarch-selftests.c: Fix common/ includes.
9386         * gdb_usleep.c: Fix common/ includes.
9387         * gdb_select.h: Fix common/ includes.
9388         * gdb_bfd.c: Fix common/ includes.
9389         * gcore.c: Fix common/ includes.
9390         * fork-child.c: Fix common/ includes.
9391         * findvar.c: Fix common/ includes.
9392         * fbsd-nat.c: Fix common/ includes.
9393         * event-top.c: Fix common/ includes.
9394         * event-loop.c: Fix common/ includes.
9395         * dwarf2read.c: Fix common/ includes.
9396         * dwarf2loc.c: Fix common/ includes.
9397         * dwarf2-frame.c: Fix common/ includes.
9398         * dwarf-index-cache.c: Fix common/ includes.
9399         * dtrace-probe.c: Fix common/ includes.
9400         * disasm-selftests.c: Fix common/ includes.
9401         * defs.h: Fix common/ includes.
9402         * csky-tdep.c: Fix common/ includes.
9403         * cp-valprint.c: Fix common/ includes.
9404         * cp-support.h: Fix common/ includes.
9405         * cp-support.c: Fix common/ includes.
9406         * corelow.c: Fix common/ includes.
9407         * completer.h: Fix common/ includes.
9408         * completer.c: Fix common/ includes.
9409         * compile/compile.c: Fix common/ includes.
9410         * compile/compile-loc2c.c: Fix common/ includes.
9411         * compile/compile-cplus-types.c: Fix common/ includes.
9412         * compile/compile-cplus-symbols.c: Fix common/ includes.
9413         * command.h: Fix common/ includes.
9414         * cli/cli-dump.c: Fix common/ includes.
9415         * cli/cli-cmds.c: Fix common/ includes.
9416         * charset.c: Fix common/ includes.
9417         * build-id.c: Fix common/ includes.
9418         * btrace.h: Fix common/ includes.
9419         * btrace.c: Fix common/ includes.
9420         * breakpoint.h: Fix common/ includes.
9421         * breakpoint.c: Fix common/ includes.
9422         * ax.h:
9423         (enum agent_op): Fix common/ includes.
9424         * ax-general.c (struct aop_map): Fix common/ includes.
9425         * ax-gdb.c: Fix common/ includes.
9426         * auxv.c: Fix common/ includes.
9427         * auto-load.c: Fix common/ includes.
9428         * arm-tdep.c: Fix common/ includes.
9429         * arch/riscv.c: Fix common/ includes.
9430         * arch/ppc-linux-common.c: Fix common/ includes.
9431         * arch/i386.c: Fix common/ includes.
9432         * arch/arm.c: Fix common/ includes.
9433         * arch/arm-linux.c: Fix common/ includes.
9434         * arch/arm-get-next-pcs.c: Fix common/ includes.
9435         * arch/amd64.c: Fix common/ includes.
9436         * arch/aarch64.c: Fix common/ includes.
9437         * arch/aarch64-insn.c: Fix common/ includes.
9438         * arch-utils.c: Fix common/ includes.
9439         * amd64-windows-tdep.c: Fix common/ includes.
9440         * amd64-tdep.c: Fix common/ includes.
9441         * amd64-sol2-tdep.c: Fix common/ includes.
9442         * amd64-obsd-tdep.c: Fix common/ includes.
9443         * amd64-nbsd-tdep.c: Fix common/ includes.
9444         * amd64-linux-tdep.c: Fix common/ includes.
9445         * amd64-linux-nat.c: Fix common/ includes.
9446         * amd64-fbsd-tdep.c: Fix common/ includes.
9447         * amd64-fbsd-nat.c: Fix common/ includes.
9448         * amd64-dicos-tdep.c: Fix common/ includes.
9449         * amd64-darwin-tdep.c: Fix common/ includes.
9450         * agent.c: Fix common/ includes.
9451         * ada-lang.h: Fix common/ includes.
9452         * ada-lang.c: Fix common/ includes.
9453         * aarch64-tdep.c: Fix common/ includes.
9454
9455 2019-01-25  Tom Tromey  <tom@tromey.com>
9456
9457         * common/create-version.sh: Use common/version.h.
9458
9459 2019-01-24  Pedro Alves  <palves@redhat.com>
9460
9461         * infrun.c (signal_stop, signal_print, signal_program)
9462         (signal_catch, signal_pass): Now arrays instead of pointers.
9463         (update_signals_program_target, do_target_resume)
9464         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9465         * linux-nat.c (linux_nat_target::pass_signals)
9466         (linux_nat_target::create_inferior, linux_nat_target::attach):
9467         Adjust.
9468         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9469         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9470         * procfs.c (procfs_target::pass_signals): Adjust.
9471         * record-full.c (record_full_target::resume): Adjust.
9472         * remote.c (remote_target::pass_signals)
9473         (remote_target::program_signals): Adjust.
9474         * target-debug.h (target_debug_print_signals): Now takes a
9475         gdb::array_view as parameter.  Adjust.
9476         * target.h (target_ops) <pass_signals, program_signals>: Replace
9477         pointer and length parameters with gdb::array_view.
9478         (target_pass_signals, target_program_signals): Likewise.
9479         * target-delegates.c: Regenerate.
9480
9481 2019-01-24  Pedro Alves  <palves@redhat.com>
9482
9483         * common/forward-scope-exit.h
9484         (forward_scope_exit::forward_scope_exit): Pass arguments to
9485         m_bind_function directly, instead of creating a std::bind and
9486         copying that.
9487
9488 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9489
9490         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9491         for static members.
9492         (pass_in_v_vfp_candidate): Likewise.
9493
9494 2019-01-23  Tom Tromey  <tom@tromey.com>
9495             Pedro Alves  <palves@redhat.com>
9496
9497         * regcache.c (class regcache_invalidator): Remove.
9498         (regcache::raw_write): Use make_scope_exit.
9499
9500 2019-01-23  Tom Tromey  <tom@tromey.com>
9501
9502         * ui-out.h (class ui_out_emit_type): Update comment.
9503
9504 2019-01-23  Tom Tromey  <tom@tromey.com>
9505
9506         * infrun.c (fetch_inferior_event): Update comment.
9507
9508 2019-01-23  Tom Tromey  <tom@tromey.com>
9509             Pedro Alves  <palves@redhat.com>
9510
9511         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9512         parameter.
9513         (fetch_inferior_event): Use SCOPE_EXIT.
9514
9515
9516 2019-01-23  Tom Tromey  <tom@tromey.com>
9517             Pedro Alves  <palves@redhat.com>
9518
9519         * infrun.c (disable_thread_events): Delete.
9520         (stop_all_threads): Use SCOPE_EXIT.
9521
9522 2019-01-23  Tom Tromey  <tom@tromey.com>
9523             Pedro Alves  <palves@redhat.com>
9524
9525         * symfile.c: Include forward-scope-exit.h.
9526         (clear_symtab_users_cleanup): Replace forward declaration with
9527         a FORWARD_SCOPE_EXIT.
9528         (syms_from_objfile_1): Use the forward_scope_exit and
9529         gdb::optional instead of cleanup_function.
9530         (reread_symbols): Use the forward_scope_exit instead of
9531         cleanup_function.
9532         (clear_symtab_users_cleanup): Remove function.
9533
9534 2019-01-23  Tom Tromey  <tom@tromey.com>
9535             Pedro Alves  <palves@redhat.com>
9536
9537         * linux-nat.c: Include scope-exit.h.
9538         (cleanup_target_stop): Remove.
9539         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9540         SCOPE_EXIT.
9541
9542 2019-01-23  Tom Tromey  <tom@tromey.com>
9543             Pedro Alves  <palves@redhat.com>
9544
9545         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9546         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9547
9548 2019-01-23  Tom Tromey  <tom@tromey.com>
9549             Andrew Burgess  <andrew.burgess@embecosm.com>
9550             Pedro Alves  <palves@redhat.com>
9551
9552         * infrun.c (fetch_inferior_event): Use scope_exit.
9553         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9554         * top.c (execute_command): Use scope_exit.
9555         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9556         * utils.c (do_bpstat_clear_actions_cleanup)
9557         (make_bpstat_clear_actions_cleanup): Remove.
9558
9559 2019-01-23  Tom Tromey  <tom@tromey.com>
9560             Pedro Alves  <palves@redhat.com>
9561
9562         * infrun.c: Include "common/scope-exit.h"
9563         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9564         (wait_for_inferior): Use SCOPE_EXIT.
9565         (fetch_inferior_event): Use scope_exit.
9566
9567 2019-01-23  Tom Tromey  <tom@tromey.com>
9568             Pedro Alves  <palves@redhat.com>
9569
9570         * breakpoint.c (create_breakpoint): Remove cleanup.
9571
9572 2019-01-23  Tom Tromey  <tom@tromey.com>
9573             Andrew Burgess  <andrew.burgess@embecosm.com>
9574             Pedro Alves  <palves@redhat.com>
9575
9576 2019-01-23  Pedro Alves  <palves@redhat.com>
9577
9578         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9579
9580 2019-01-23  Pedro Alves  <palves@redhat.com>
9581             Andrew Burgess  <andrew.burgess@embecosm.com>
9582
9583         * gdbthread.h: Include "common/forward-scope-exit.h".
9584         (scoped_finish_thread_state): Redefine custom class in terms of
9585         forward_scope_exit.
9586
9587 2019-01-23  Pedro Alves  <palves@redhat.com>
9588             Andrew Burgess  <andrew.burgess@embecosm.com>
9589
9590         * common/forward-scope-exit.h: New file.
9591
9592 2019-01-23  Pedro Alves  <palves@redhat.com>
9593             Andrew Burgess  <andrew.burgess@embecosm.com>
9594             Tom Tromey  <tom@tromey.com>
9595
9596         * common/scope-exit.h: New file.
9597
9598 2019-01-23  Pedro Alves  <palves@redhat.com>
9599
9600         * common/preprocessor.h (ESC): Rename to ...
9601         (ESC_PARENS): ... this.
9602         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9603         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9604
9605 2019-01-23  Tom Tromey  <tom@tromey.com>
9606
9607         * language.h (class scoped_switch_to_sym_language_if_auto):
9608         Initialize m_lang in both cases.
9609
9610 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9611
9612         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9613         with XCNEW.
9614
9615 2019-01-22  Tom Tromey  <tom@tromey.com>
9616
9617         * corelow.c: Do not include sys/file.h.
9618
9619 2019-01-22  Tom Tromey  <tom@tromey.com>
9620
9621         * tui/tui-wingeneral.h: Include gdb_curses.h.
9622
9623 2019-01-22  Tom Tromey  <tom@tromey.com>
9624
9625         * source-cache.h (class source_cache) <get_source_lines,
9626         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9627
9628 2019-01-22  Tom Tromey  <tom@tromey.com>
9629
9630         * remote-fileio.h (struct remote_target): Declare.
9631
9632 2019-01-22  Tom Tromey  <tom@tromey.com>
9633
9634         * python/py-arch.c: Do not include py-ref.h.
9635         * python/py-bpevent.c: Do not include py-ref.h.
9636         * python/py-cmd.c: Do not include py-ref.h.
9637         * python/py-continueevent.c: Do not include py-ref.h.
9638         * python/py-event.h: Do not include py-ref.h.
9639         * python/py-evtregistry.c: Do not include py-ref.h.
9640         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9641         * python/py-frame.c: Do not include py-ref.h.
9642         * python/py-framefilter.c: Do not include py-ref.h.
9643         * python/py-function.c: Do not include py-ref.h.
9644         * python/py-infevents.c: Do not include py-ref.h.
9645         * python/py-linetable.c: Do not include py-ref.h.
9646         * python/py-objfile.c: Do not include py-ref.h.
9647         * python/py-param.c: Do not include py-ref.h.
9648         * python/py-prettyprint.c: Do not include py-ref.h.
9649         * python/py-progspace.c: Do not include py-ref.h.
9650         * python/py-symbol.c: Do not include py-ref.h.
9651         * python/py-symtab.c: Do not include py-ref.h.
9652         * python/py-type.c: Do not include py-ref.h.
9653         * python/py-unwind.c: Do not include py-ref.h.
9654         * python/py-utils.c: Do not include py-ref.h.
9655         * python/py-value.c: Do not include py-ref.h.
9656         * python/py-varobj.c: Do not include py-ref.h.
9657         * python/py-xmethods.c: Do not include py-ref.h.
9658         * python/python.c: Do not include py-ref.h.
9659         * varobj.c: Do not include py-ref.h.
9660
9661 2019-01-22  Tom Tromey  <tom@tromey.com>
9662
9663         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9664         keyword for bcache.
9665
9666 2019-01-22  Tom Tromey  <tom@tromey.com>
9667
9668         * compile/compile-cplus-types.c: Remove a comment by #include.
9669
9670 2019-01-22  Tom Tromey  <tom@tromey.com>
9671
9672         * compile/gcc-c-plugin.h: Include compile-internal.h.
9673
9674 2019-01-22  Tom Tromey  <tom@tromey.com>
9675
9676         * stabsread.c (EXTERN): Do not define.
9677         (symnum, next_symbol_text_func, processing_gcc_compilation)
9678         (within_function, global_sym_chain, global_stabs)
9679         (previous_stab_code, this_object_header_files)
9680         (n_this_object_header_files)
9681         (n_allocated_this_object_header_files): Define.
9682         * stabsread.h (EXTERN): Never define.  Use "extern".
9683
9684 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9685
9686         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9687         history_value.
9688
9689 2019-01-21  Tom Tromey  <tom@tromey.com>
9690
9691         * ui-out.c: Fix includes.
9692         * tui/tui-source.c: Fix includes.
9693         * target.c: Fix includes.
9694         * remote.c: Fix includes.
9695         * regcache.c: Fix includes.
9696         * python/py-block.c: Fix includes.
9697         * printcmd.c: Fix includes.
9698         * or1k-tdep.c: Fix includes.
9699         * mi/mi-main.c: Fix includes.
9700         * m32r-tdep.c: Fix includes.
9701         * csky-tdep.c: Fix includes.
9702         * compile/compile-cplus-types.c: Fix includes.
9703         * cli/cli-interp.c: Fix includes.
9704
9705 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9706
9707         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9708         for padding.
9709
9710 2019-01-16  Tom Tromey  <tom@tromey.com>
9711
9712         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9713         earlier.
9714         (struct objfile) <msymbols_range>: Move from top level.
9715         <msymbols>: New method.
9716         (class objfile_msymbols): Remove.
9717         * symtab.c (default_collect_symbol_completion_matches_break_on):
9718         Update.
9719         * symmisc.c (dump_msymbols): Update.
9720         * stabsread.c (scan_file_globals): Update.
9721         * objc-lang.c (info_selectors_command, info_classes_command)
9722         (find_methods): Update.
9723         * minsyms.c (find_solib_trampoline_target): Update.
9724         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9725         * coffread.c (coff_symfile_read): Update.
9726         * ada-lang.c (ada_lookup_simple_minsym)
9727         (ada_collect_symbol_completion_matches): Update.
9728
9729 2019-01-16  Tom Tromey  <tom@tromey.com>
9730
9731         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9732         type.  Remove no-argument constructor.
9733         <iterator::operator++>: Simplify.
9734         <begin>: Update.
9735         <end>: Use minimal_symbol_count.
9736
9737 2019-01-16  Tom Tromey  <tom@tromey.com>
9738
9739         * objfiles.h (struct objfile) <psymtabs>: New method.
9740         (class objfile_psymtabs): Remove.
9741         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9742         typedef.
9743         <range>: New method.
9744         (require_partial_symbols): Change return type.
9745         * psymtab.c (require_partial_symbols)
9746         (psym_expand_symtabs_matching): Update.
9747         * mdebugread.c (parse_partial_symbols): Update.
9748         * dbxread.c (dbx_end_psymtab): Update.
9749
9750 2019-01-15  Tom Tromey  <tom@tromey.com>
9751
9752         * symtab.c (lookup_objfile_from_block)
9753         (lookup_symbol_in_objfile_symtabs)
9754         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9755         (find_line_symtab, info_sources_command)
9756         (default_collect_symbol_completion_matches_break_on)
9757         (make_source_files_completion_list): Update.
9758         * symmisc.c (print_objfile_statistics, dump_objfile)
9759         (maintenance_print_symbols, maintenance_info_symtabs)
9760         (maintenance_check_symtabs, maintenance_info_line_tables):
9761         Update.
9762         * source.c (select_source_symtab)
9763         (forget_cached_source_info_for_objfile): Update.
9764         * objfiles.h (class objfile_compunits): Remove.
9765         (struct objfile) <compunits_range>: New typedef.
9766         (compunits): New method.
9767         * objfiles.c (objfile_relocate1): Update.
9768         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9769         * maint.c (count_symtabs_and_blocks): Update.
9770         * linespec.c (iterate_over_all_matching_symtabs): Update.
9771         * cp-support.c (add_symbol_overload_list_qualified): Update.
9772         * coffread.c (coff_symtab_read): Update.
9773         * ada-lang.c (add_nonlocal_symbols)
9774         (ada_collect_symbol_completion_matches)
9775         (ada_add_global_exceptions): Update.
9776
9777 2019-01-15  Tom Tromey  <tom@tromey.com>
9778
9779         * progspace.h (program_space) <objfiles_safe_range>: New
9780         typedef.
9781         <objfiles_safe>: New method.
9782         * objfiles.h (class all_objfiles_safe): Remove.
9783         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9784         * jit.c (jit_inferior_exit_hook): Update.
9785
9786 2019-01-17  Tom Tromey  <tom@tromey.com>
9787
9788         * progspace.h (program_space) <objfiles_range>: New typedef.
9789         <objfiles>: New method.
9790         <objfiles_head>: Rename from objfiles.
9791         (object_files): Update.
9792         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9793         * guile/scm-pretty-print.c
9794         (ppscm_find_pretty_printer_from_objfiles): Update.
9795         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9796         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9797         Update.
9798         * python/py-progspace.c (pspy_get_objfiles): Update.
9799         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9800         Update.
9801         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9802         (objfpy_lookup_objfile_by_build_id): Update.
9803         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9804         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9805         Update.
9806         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9807         (expand_symtab_containing_pc, lookup_objfile_from_block)
9808         (lookup_static_symbol, basic_lookup_transparent_type)
9809         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9810         (find_line_symtab, info_sources_command)
9811         (default_collect_symbol_completion_matches_break_on)
9812         (make_source_files_completion_list, find_main_name): Update.
9813         * symmisc.c (print_symbol_bcache_statistics)
9814         (print_objfile_statistics, maintenance_print_symbols)
9815         (maintenance_print_msymbols, maintenance_print_objfiles)
9816         (maintenance_info_symtabs, maintenance_check_symtabs)
9817         (maintenance_expand_symtabs, maintenance_info_line_tables):
9818         Update.
9819         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9820         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9821         (map_overlay_command, unmap_overlay_command)
9822         (simple_overlay_update, expand_symtabs_matching)
9823         (map_symbol_filenames): Update.
9824         * symfile-debug.c (set_debug_symfile): Update.
9825         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9826         Update.
9827         * source.c (select_source_symtab, forget_cached_source_info):
9828         Update.
9829         * solib.c (solib_read_symbols): Update.
9830         * solib-spu.c (append_ocl_sos): Update.
9831         * psymtab.c (maintenance_print_psymbols)
9832         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9833         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9834         * printcmd.c (info_symbol_command): Update.
9835         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9836         Update.
9837         * objfiles.h (class all_objfiles): Remove.
9838         * objfiles.c (have_partial_symbols, have_full_symbols)
9839         (have_minimal_symbols, qsort_cmp, update_section_map)
9840         (shared_objfile_contains_address_p)
9841         (default_iterate_over_objfiles_in_search_order): Update.
9842         * objc-lang.c (info_selectors_command, info_classes_command)
9843         (find_methods): Update.
9844         * minsyms.c (find_solib_trampoline_target): Update.
9845         * maint.c (maintenance_info_sections)
9846         (maintenance_translate_address, count_symtabs_and_blocks):
9847         Update.
9848         * main.c (captured_main_1): Update.
9849         * linux-thread-db.c (try_thread_db_load_from_pdir)
9850         (has_libpthread): Update.
9851         * linespec.c (iterate_over_all_matching_symtabs)
9852         (search_minsyms_for_name): Update.
9853         * jit.c (jit_find_objf_with_entry_addr): Update.
9854         * hppa-tdep.c (find_unwind_entry)
9855         (hppa_lookup_stub_minimal_symbol): Update.
9856         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9857         Update.
9858         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9859         (elf_gnu_ifunc_resolve_by_got): Update.
9860         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9861         * dwarf-index-write.c (save_gdb_index_command): Update.
9862         * cp-support.c (add_symbol_overload_list_qualified): Update.
9863         * breakpoint.c (create_overlay_event_breakpoint)
9864         (create_longjmp_master_breakpoint)
9865         (create_std_terminate_master_breakpoint)
9866         (create_exception_master_breakpoint): Update.
9867         * blockframe.c (find_pc_partial_function): Update.
9868         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9869         (ada_collect_symbol_completion_matches)
9870         (ada_add_global_exceptions): Update.
9871
9872 2019-01-17  Tom Tromey  <tom@tromey.com>
9873
9874         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9875         declare VEC.
9876         (solib_target_parse_libraries): Change return type.
9877         (library_list_start_segment, library_list_start_section)
9878         (library_list_end_library, library_list_start_library); Update.
9879         (solib_target_free_library_list): Remove.
9880         (solib_target_parse_libraries): Remove cleanup.  Change return
9881         type.
9882         (solib_target_current_sos): Update.
9883
9884 2019-01-17  Tom Tromey  <tromey@bapiya>
9885
9886         * valprint.c: Replace "the the" with "the".
9887         * symtab.c: Replace "the the" with "the".
9888         * solib.c: Replace "the the" with "the".
9889         * solib-dsbt.c: Replace "the the" with "the".
9890         * linespec.c: Replace "the the" with "the".
9891         * dwarf2loc.h: Replace "the the" with "the".
9892         * amd64-windows-tdep.c: Replace "the the" with "the".
9893         * aarch64-tdep.c: Replace "the the" with "the".
9894
9895 2019-01-16  Keith Seitz  <keiths@redhat.com>
9896
9897         PR gdb/23773
9898         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9899         <builder>: Rename to ..
9900         <m_builder>: ... this and make private.
9901         (dwarf2_cu::get_builder): New method.  Change all users of
9902         `builder' to use this method.
9903         (dwarf2_start_symtab): Move to ...
9904         (dwarf2_cu::start_symtab): ... here.  Update all callers
9905         (setup_type_unit_groups): Move to ...
9906         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9907         callers.
9908         (dwarf2_cu::reset_builder): New method.
9909         (process_full_compunit, process_full_type_unit): Use
9910         dwarf2_cu::reset_builder.
9911         (follow_die_offset): Record the ancestor CU if it is different
9912         from the followed DIE's CU.
9913         (follow_die_sig_1): Likewise.
9914
9915 2019-01-15  Tom Tromey  <tom@tromey.com>
9916
9917         * remote.c (class remote_state) <buf>: Now a char_vector.
9918         <buf_size>: Remove.
9919         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9920         parameter.
9921         (remote_target::getpkt_or_notif_sane_1)
9922         (remote_target::getpkt_sane)
9923         (remote_target::getpkt_or_notif_sane): Likewise.
9924         (class remote_target) <putpkt>: New overload.
9925         (remote_target::read_frame): Change type of "buf_p".  Remove
9926         sizeof_p parameter.
9927         (packet_ok): New overload.
9928         (packet_check_result): New overload.
9929         Update all uses.
9930
9931 2019-01-14  Tom Tromey  <tom@tromey.com>
9932
9933         * remote-notif.c (handle_notification, remote_notif_ack)
9934         (remote_notif_parse): Make "buf" const.
9935         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9936         const.
9937         (remote_notif_parse, remote_notif_ack, handle_notification):
9938         Likewise.
9939         * remote.c (remote_notif_stop_parse): Make "buf" const.
9940         (remote_target::remote_parse_stop_reply): Make "buf" const.
9941         (remote_notif_stop_ack): Make "buf" const.
9942
9943 2019-01-14  Tom Tromey  <tom@tromey.com>
9944
9945         * remote.c (remote_console_output): Make parameter const.
9946
9947 2019-01-14  Tom Tromey  <tom@tromey.com>
9948
9949         * target-debug.h (target_debug_print_signals): Constify.
9950         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9951         * procfs.c (procfs_target::pass_signals): Update.
9952         * linux-nat.c (linux_nat_target::pass_signals): Update.
9953         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9954         * target-delegates.c: Rebuild.
9955         * remote.c (remote_target::program_signals): Update.
9956         (remote_target::pass_signals): Update.
9957         * target.c (target_pass_signals): Constify argument.
9958         (target_program_signals): Likewise.
9959         * target.h (struct target_ops) <pass_signals, program_signals>:
9960         Constify argument.
9961         (target_pass_signals, target_program_signals): Constify argument.
9962
9963 2019-01-14  Tom Tromey  <tom@tromey.com>
9964
9965         PR tui/28819:
9966         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9967
9968 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9969
9970         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9971         field.
9972         * rs6000-tdep.c: Include reggroups.h.
9973         (IS_V_ALIAS_PSEUDOREG): Define.
9974         (rs6000_register_name): Return names for the "vX" aliases.
9975         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9976         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9977         aliases.  Call default_register_reggroup_p for all other
9978         pseudo-registers.
9979         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9980         New functions.
9981         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9982         Handle "vX" aliases.
9983         (v_alias_pseudo_register_collect): New function.
9984         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9985         (rs6000_gdbarch_init): Initialize "vX" aliases as
9986         pseudo-registers.  Restore registration of
9987         rs6000_pseudo_register_reggroup_p with
9988         set_tdesc_pseudo_register_reggroup_p.
9989
9990 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9991
9992         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9993         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9994         set_gdbarch_num_pseudo_regs.
9995
9996 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9997
9998         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9999         Remove arg prefixname, add do_set and do_show.
10000         Add member functions set_list and show_list.
10001         * cli/cli-style.c (class cli_style_option): Update accordingly.
10002         (style_set_list): Move to file scope.
10003         (style_show_list): Likewise.
10004         (set_style): Call help_list.
10005         (show_style): Call cmd_show_list.
10006         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10007         Update to use the new macro.
10008
10009 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10010
10011         * ada-lang.c (_initialize_ada_language): Expand the help text
10012         for the "catch exception" command.
10013
10014 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10015
10016         * symtab.c (matching_obj_sections): Initialize obj,
10017         declare it closer to its usage.
10018
10019 2019-01-10  Tom Tromey  <tom@tromey.com>
10020
10021         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10022         (basic_inf_threads_range): Remove.
10023         (inf_threads_range, inf_non_exited_threads_range)
10024         (safe_inf_threads_range): Use next_adapter.
10025
10026 2019-01-10  Keith Seitz  <keiths@redhat.com>
10027
10028         PR gdb/23712
10029         PR symtab/23010
10030         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10031         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10032
10033 2019-01-10  Keith Seitz  <keiths@redhat.com>
10034
10035         PR gdb/23712
10036         PR symtab/23010
10037         * dictionary.c (pending_to_vector): Remove.
10038         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10039         Remove _1 suffix, replacing functions of the same name.  Update
10040         all callers.
10041         (dict_create_hashed, dict_create_hashed_expandable)
10042         (dict_create_linear, dict_create_linear_expandable, dict_free)
10043         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10044         Make functions static.
10045
10046 2019-01-10  Keith Seitz  <keiths@redhat.com>
10047
10048         PR gdb/23712
10049         PR symtab/23010
10050         * dictionary.h (struct dictionary): Replace declaration with
10051         multidictionary.
10052         (dict_create_hashed, dict_create_hashed_expandable)
10053         (dict_create_linear, dict_create_linear_expandable)
10054         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10055         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10056         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10057         taking multidictionary argument.
10058         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10059         * block.h (struct block) <dict>: Change to multidictionary
10060         and rename `multidict'.
10061         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10062         symmisc.c: Update all dictionary references to multidictionary.
10063
10064 2019-01-10  Keith Seitz  <keiths@redhat.com>
10065
10066         PR gdb/23712
10067         PR symtab/23010
10068         * dictionary.c: Include unordered_map.
10069         (pending_to_vector): New function.
10070         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10071         Rewrite the non-"_1" functions to take vector instead
10072         of linked list.
10073         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10074         "new" _1 versions of the same name.
10075         (multidictionary): Define.
10076         (std::hash<enum language): New definition.
10077         (collate_pending_symbols_by_language, mdict_create_hashed)
10078         (mdict_create_hashed_expandable, mdict_create_linear)
10079         (mdict_create_linear_expandable, mdict_free)
10080         (find_language_dictionary, create_new_language_dictionary)
10081         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10082         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10083         (mdict_size, mdict_empty): New functions.
10084         * dictionary.h (mdict_iterator): Define.
10085
10086 2019-01-10  Pedro Alves  <palves@redhat.com>
10087
10088         * breakpoint.c (read_uploaded_action)
10089         (create_tracepoint_from_upload): Adjust to use
10090         gdb::unique_xmalloc_ptr.
10091         * ctf.c (ctf_write_uploaded_tp):
10092         (SET_ARRAY_FIELD): Use emplace_back.
10093         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10094         * tracefile-tfile.c (tfile_write_uploaded_tp):
10095         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10096         gdb::unique_xmalloc_ptr.
10097         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10098         at_string, cond_string, cmd_strings>: Replace char pointers
10099         with gdb::unique_xmalloc_ptr.
10100
10101 2019-01-10  Pedro Alves  <palves@redhat.com>
10102
10103         * solib-target.c (library_list_start_library): Don't xstrdup name.
10104
10105 2019-01-10  Pedro Alves  <palves@redhat.com>
10106
10107         * mdebugread.c (parse_partial_symbols): Use
10108         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10109
10110 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10111
10112         * linux-fork.c (scoped_switch_fork_info)
10113         <~scoped_switch_fork_info>: Fix incorrect variable name.
10114
10115 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10116
10117         * linux-fork.c (scoped_switch_fork_info)
10118         <scoped_switch_fork_info>: Make explicit.
10119         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10120
10121 2019-01-10  Tom Tromey  <tom@tromey.com>
10122
10123         * objfiles.h (objfile::reset_psymtabs): Update.
10124         * objfiles.c (objfile::objfile): Update.
10125         * psymtab.h (psymtab_storage::obstack): Update.
10126         (psymtab_storage::m_obstack): Use gdb::optional.
10127         (class psymtab_storage): Update comment.  Remove objfile
10128         parameter.
10129         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10130
10131 2019-01-10  Tom Tromey  <tom@tromey.com>
10132
10133         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10134         <free_psymtabs>: Now private.
10135         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10136         (allocate_psymtab): Use new method.
10137
10138 2019-01-10  Tom Tromey  <tom@tromey.com>
10139
10140         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10141         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10142         * mdebugread.c (parse_partial_symbols): Use
10143         allocate_dependencies.
10144         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10145         allocate_dependencies.
10146         (process_psymtab_comp_unit_reader)
10147         (build_type_psymtab_dependencies): Likewise.
10148         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10149
10150 2019-01-10  Tom Tromey  <tom@tromey.com>
10151
10152         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10153         PSYMBOL_SET_LANGUAGE.
10154         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10155
10156 2019-01-10  Tom Tromey  <tom@tromey.com>
10157
10158         * psymtab.h (psymtab_storage::obstack): New method.
10159         <m_obstack>: Rename from obstack; now private.
10160         * psymtab.c (psymtab_storage): Update.
10161         * dwarf2read.c (create_addrmap_from_index)
10162         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10163         Update.
10164
10165 2019-01-10  Tom Tromey  <tom@tromey.com>
10166
10167         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10168         * objfiles.h (objfile::reset_psymtabs): New method.
10169
10170 2019-01-10  Tom Tromey  <tom@tromey.com>
10171
10172         * symmisc.c (print_symbol_bcache_statistics): Update.
10173         (print_objfile_statistics): Update.
10174         * symfile.c (reread_symbols): Update.
10175         * psymtab.h (class psymtab_storage): New.
10176         * psymtab.c (psymtab_storage): New constructor.
10177         (~psymtab_storage): New destructor.
10178         (require_partial_symbols): Update.
10179         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10180         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10181         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10182         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10183         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10184         (start_psymtab_common, end_psymtab_common)
10185         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10186         (allocate_psymtab): Update.
10187         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10188         Update.
10189         (dump_psymtab_addrmap, maintenance_print_psymbols)
10190         (maintenance_check_psymtabs): Update.
10191         (class objfile_psymtabs): Move to objfiles.h.
10192         * psympriv.h (discard_psymtab): Now inline.
10193         (psymtab_discarder::psymtab_discarder): Update.
10194         (psymtab_discarder::~psymtab_discarder): Update.
10195         (ALL_OBJFILE_PSYMTABS): Rewrite.
10196         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10197         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10198         Remove fields.
10199         <partial_symtabs>: New field.
10200         (class objfile_psymtabs): Move from psymtab.h.  Update.
10201         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10202         psymbol_cache.
10203         (objfile::~objfile): Don't destroy psymbol_cache.
10204         * mdebugread.c (parse_partial_symbols): Update.
10205         * dwarf2read.c (create_addrmap_from_index)
10206         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10207         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10208         (add_partial_subprogram, dwarf2_ranges_read): Update.
10209         * dwarf-index-write.c (write_address_map)
10210         (write_one_signatured_type, recursively_write_psymbols)
10211         (class debug_names, class debug_names, write_psymtabs_to_index):
10212         Update.
10213
10214 2019-01-10  Tom Tromey  <tom@tromey.com>
10215
10216         * symtab.h (SYMBOL_SET_NAMES): Update.
10217         (symbol_set_names): Update.
10218         (MSYMBOL_SET_NAMES): Update.
10219         * symtab.c (symbol_set_names): Change argument to be an
10220         objfile_per_bfd_storage.
10221         * psymtab.c (add_psymbol_to_bcache): Update.
10222         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10223
10224 2019-01-10  Tom Tromey  <tom@tromey.com>
10225
10226         * symtab.c (create_demangled_names_hash): Change argument to be an
10227         objfile_per_bfd_storage.
10228         (symbol_set_names): Update.
10229
10230 2019-01-10  Tom Tromey  <tom@tromey.com>
10231
10232         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10233         init_psymbol_list.
10234         * psymtab.c (init_psymbol_list): Do nothing if already called.
10235         * psympriv.h (init_psymbol_list): Add comment.
10236         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10237         init_psymbol_list.
10238         * dbxread.c (dbx_symfile_read): Unconditionally call
10239         init_psymbol_list.
10240
10241 2019-01-10  Tom Tromey  <tom@tromey.com>
10242
10243         * xcoffread.c (scan_xcoff_symtab): Update.
10244         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10245         "where".
10246         * mdebugread.c (parse_partial_symbols)
10247         (handle_psymbol_enumerators): Update.
10248         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10249         * dbxread.c (read_dbx_symtab): Update.
10250         * psympriv.h (psymbol_placement): New enum.
10251         (add_psymbol_to_list): Update.
10252
10253 2019-01-10  Tom Tromey  <tom@tromey.com>
10254
10255         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10256         static_psymbols parameters.
10257         (scan_xcoff_symtab): Update.
10258         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10259         static_psymbols parameters.
10260         * psympriv.h (start_psymtab_common): Update.
10261         * mdebugread.c (parse_partial_symbols): Update.
10262         * dwarf2read.c (create_partial_symtab): Update.
10263         * dbxread.c (read_dbx_symtab): Update.
10264         (start_psymtab): Remove global_psymbols and static_psymbols
10265         parameters.
10266
10267 2019-01-10  Tom Tromey  <tom@tromey.com>
10268
10269         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10270         * psymtab.c (allocate_psymtab): Add comment.
10271         * psympriv.h (allocate_psymtab): Add comment.
10272         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10273         initializations.
10274         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10275
10276 2019-01-10  Tom Tromey  <tom@tromey.com>
10277
10278         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10279         Don't declare.
10280         * mipsread.c: Include mdebugread.h.
10281         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10282         Declare.
10283         * elfread.c: Include mdebugread.h.
10284
10285 2019-01-09  Tom Tromey  <tom@tromey.com>
10286
10287         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10288         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10289         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10290         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10291         (psym_lookup_symbol, psym_find_last_source_symtab)
10292         (psym_forget_cached_source_info, psym_print_stats)
10293         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10294         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10295         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10296         (psym_find_compunit_symtab_by_address)
10297         (maintenance_print_psymbols, maintenance_info_psymtabs)
10298         (maintenance_check_psymtabs): Use ranged for.
10299         * psymtab.h (class objfile_psymtabs): New.
10300         (require_partial_symbols): Return objfile_psymtabs.
10301         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10302
10303 2019-01-09  Tom Tromey  <tom@tromey.com>
10304
10305         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10306         (find_pc_mapped_section, list_overlays_command)
10307         (map_overlay_command, unmap_overlay_command)
10308         (simple_overlay_update): Use all_objfiles.
10309         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10310         * printcmd.c (info_symbol_command): Use all_objfiles.
10311         * objfiles.h (ALL_OBJSECTIONS): Remove.
10312         * maint.c (maintenance_translate_address): Use all_objfiles.
10313         * gcore.c (gcore_create_callback): Use all_objfiles.
10314         (objfile_find_memory_regions): Likewise.
10315
10316 2019-01-09  Tom Tromey  <tom@tromey.com>
10317
10318         * symtab.c (find_line_symtab, info_sources_command)
10319         (make_source_files_completion_list): Use objfile_compunits.
10320         * source.c (select_source_symtab): Use objfile_compunits.
10321         * objfiles.h (struct objfile): Update comment.
10322         (ALL_OBJFILES): Remove.
10323         (ALL_FILETABS): Remove.
10324         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10325         objfile_compunits.
10326
10327 2019-01-09  Tom Tromey  <tom@tromey.com>
10328
10329         * symmisc.c (print_objfile_statistics, dump_objfile)
10330         (maintenance_print_symbols): Use compunit_filetabs.
10331         * source.c (forget_cached_source_info_for_objfile): Use
10332         compunit_filetabs.
10333         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10334         (ALL_FILETABS): Use compunit_filetabs.
10335         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10336         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10337
10338 2019-01-09  Tom Tromey  <tom@tromey.com>
10339
10340         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10341         (compunit_filetabs): New.
10342         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10343         compunit_filetabs.
10344         (info_sources_command, make_source_files_completion_list): Remove
10345         declaration.
10346         * symmisc.c (print_objfile_statistics, dump_objfile)
10347         (maintenance_print_symbols): Remove declaration.
10348         (maintenance_info_symtabs): Use compunit_filetabs.
10349         (maintenance_info_line_tables): Likewise.
10350         * source.c (select_source_symtab): Change local variable name.
10351         (forget_cached_source_info_for_objfile): Remove declaration.
10352         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10353         * objfiles.c (objfile_relocate1): Remove declaration.
10354         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10355         declaration.
10356         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10357         * coffread.c (coff_symtab_read): Remove declaration.
10358         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10359         compunit_filetabs.
10360
10361 2019-01-09  Tom Tromey  <tom@tromey.com>
10362
10363         * symtab.c (lookup_objfile_from_block)
10364         (find_pc_sect_compunit_symtab, search_symbols)
10365         (default_collect_symbol_completion_matches_break_on): Use
10366         objfile_compunits.
10367         * objfiles.h (ALL_COMPUNITS): Remove.
10368         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10369         * cp-support.c (add_symbol_overload_list_qualified): Use
10370         objfile_compunits.
10371         * ada-lang.c (ada_collect_symbol_completion_matches)
10372         (ada_add_global_exceptions): Use objfile_compunits.
10373
10374 2019-01-09  Tom Tromey  <tom@tromey.com>
10375
10376         * source.c (select_source_symtab)
10377         (forget_cached_source_info_for_objfile): Remove declaration.
10378         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10379         declaration.
10380         * maint.c (count_symtabs_and_blocks): Remove declaration.
10381         * cp-support.c (add_symbol_overload_list_qualified): Remove
10382         declaration.
10383         * coffread.c (coff_symtab_read): Remove declaration.
10384         * symtab.c (lookup_symbol_in_objfile_symtabs)
10385         (basic_lookup_transparent_type_1): Use objfile_compunits.
10386         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10387         (info_sources_command, search_symbols)
10388         (default_collect_symbol_completion_matches_break_on)
10389         (make_source_files_completion_list): Remove declaration.
10390         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10391         (ada_collect_symbol_completion_matches)
10392         (ada_add_global_exceptions): Remove declaration.
10393         * linespec.c (iterate_over_all_matching_symtabs): Use
10394         objfile_compunits.
10395         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10396         (class objfile_compunits): New.
10397         (ALL_COMPUNITS): Use objfile_compunits.
10398         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10399         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10400         objfile_compunits.
10401         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10402
10403 2019-01-09  Tom Tromey  <tom@tromey.com>
10404
10405         * symtab.c (search_symbols)
10406         (default_collect_symbol_completion_matches_break_on): Use
10407         objfile_msymbols.
10408         * ada-lang.c (ada_lookup_simple_minsym)
10409         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10410         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10411         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10412         objfile_msymbols.
10413         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10414         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10415         * objc-lang.c (find_methods): Use objfile_msymbols.
10416         (info_selectors_command, info_classes_command): Likewise.
10417         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10418         * objfiles.h (class objfile_msymbols): New.
10419         (ALL_OBJFILE_MSYMBOLS): Remove.
10420         (ALL_MSYMBOLS): Remove.
10421
10422 2019-01-09  Tom Tromey  <tom@tromey.com>
10423
10424         * common/next-iterator.h (next_adapter): Add Iterator template
10425         parameter.
10426         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10427         (class all_objfiles_safe): New.
10428         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10429         * objfiles.c (put_objfile_before): Update comment.
10430         (add_separate_debug_objfile): Likewise.
10431         (free_all_objfiles): Use all_objfiles_safe.
10432         (objfile_purge_solibs): Likewise.
10433
10434 2019-01-09  Tom Tromey  <tom@tromey.com>
10435
10436         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10437         (expand_symtab_containing_pc, lookup_static_symbol)
10438         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10439         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10440         all_objfiles.
10441         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10442         * breakpoint.c (create_overlay_event_breakpoint)
10443         (create_longjmp_master_breakpoint)
10444         (create_std_terminate_master_breakpoint)
10445         (create_exception_master_breakpoint): Use all_objfiles.
10446         * linux-thread-db.c (try_thread_db_load_from_pdir)
10447         (has_libpthread): Use all_objfiles.
10448         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10449         * linespec.c (iterate_over_all_matching_symtabs)
10450         (search_minsyms_for_name): Use all_objfiles.
10451         * maint.c (maintenance_info_sections): Use all_objfiles.
10452         * main.c (captured_main_1): Use all_objfiles.
10453         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10454         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10455         * guile/scm-pretty-print.c
10456         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10457         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10458         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10459         (maintenance_print_msymbols): Use all_objfiles.
10460         * source.c (select_source_symtab): Use all_objfiles.
10461         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10462         * symfile.c (remove_symbol_file_command)
10463         (expand_symtabs_matching, map_symbol_filenames): Use
10464         all_objfiles.
10465         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10466         all_objfiles.
10467         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10468         * objc-lang.c (find_methods): Use all_objfiles.
10469         * objfiles.c (have_partial_symbols, have_full_symbols)
10470         (have_minimal_symbols, qsort_cmp)
10471         (default_iterate_over_objfiles_in_search_order): Use
10472         all_objfiles.
10473         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10474         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10475         (maintenance_check_psymtabs): Use all_objfiles.
10476         (ALL_PSYMTABS): Remove.
10477         * compile/compile-object-run.c (do_module_cleanup): Use
10478         all_objfiles.
10479         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10480         * cp-support.c (add_symbol_overload_list_qualified): Use
10481         all_objfiles.
10482         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10483         Use all_objfiles.
10484         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10485         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10486         all_objfiles.
10487         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10488         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10489         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10490         Uses all_objfiles.
10491         * solib.c (solib_read_symbols): Use all_objfiles
10492
10493 2019-01-09  Tom Tromey  <tom@tromey.com>
10494
10495         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10496         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10497         all_objfiles.
10498         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10499         * symmisc.c (print_symbol_bcache_statistics)
10500         (print_objfile_statistics, maintenance_print_objfiles)
10501         (maintenance_info_symtabs, maintenance_check_symtabs)
10502         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10503         all_objfiles.
10504         * source.c (forget_cached_source_info): Use all_objfiles.
10505         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10506         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10507         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10508         * objfiles.c (update_section_map): Use all_objfiles.
10509         (shared_objfile_contains_address_p): Likewise.
10510         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10511         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10512
10513 2019-01-09  Tom Tromey  <tom@tromey.com>
10514
10515         * common/next-iterator.h: New file.
10516         * objfiles.h (class all_objfiles): New.
10517         (struct objfile_iterator): New.
10518
10519 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10520
10521         * NEWS: Move the description of the changed "frame", "select-frame",
10522          and "info frame" commands to the Changed commands section.
10523
10524 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10525
10526         * gdbtypes.c (check_stub_method_group): Remove handling of old
10527         mangling schemes.
10528         * linespec.c (find_methods): Likewise.
10529         * stabsread.c (read_member_functions): Likewise.
10530         * valops.c (search_struct_method): Likewise.
10531         (value_struct_elt_for_reference): Likewise.
10532         * NEWS: Mention this change.
10533
10534 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10535
10536         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10537         print_source_lines.
10538         * source.c (print_source_lines_base): Update line number check.
10539         (print_source_lines): New function.
10540         (source_lines_range::source_lines_range): New function.
10541         * source.h (class source_lines_range): New class.
10542         (print_source_lines): New declaration.
10543
10544 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10545
10546         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10547
10548 2019-01-08  Tom Tromey  <tom@tromey.com>
10549             Simon Marchi  <simon.marchi@ericsson.com>
10550
10551         PR gdb/24060
10552         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10553         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10554         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10555         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10556         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10557         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10558
10559 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10560
10561         * source.c (select_source_symtab): Move header comment to
10562         declaration in source.h.
10563         (forget_cached_source_info_for_objfile): Likewise.
10564         (forget_cached_source_info): Likewise.
10565         (identify_source_line): Likewise.
10566         * source.h (identify_source_line): Move declaration from symtab.h
10567         and add comment from source.c
10568         (print_source_lines): Likewise.
10569         (forget_cached_source_info_for_objfile): Likewise.
10570         (forget_cached_source_info): Likewise.
10571         (select_source_symtab): Likewise.
10572         (enum print_source_lines_flag): Move definition from symtab.h.
10573         * symtab.h (identify_source_line): Move declaration to source.h.
10574         (print_source_lines): Likewise.
10575         (forget_cached_source_info_for_objfile): Likewise.
10576         (forget_cached_source_info): Likewise.
10577         (select_source_symtab): Likewise.
10578         (enum print_source_lines_flag): Move definition to source.h.
10579         * tui/tui-hooks.c: Add 'source.h' include.
10580
10581 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10582
10583         * source.c (print_source_lines_base): Handle requests to print
10584         reverse line number sequences, and guard against empty lines
10585         string.
10586
10587 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10588
10589         * source.c (print_source_lines_base): Fix skip of '\r' if next
10590         character is '\n'.
10591
10592 2019-01-06  Tom Tromey  <tom@tromey.com>
10593
10594         * c-exp.y (struct c_parse_state) <macro_original_text,
10595         expansion_obstack>: New member.
10596         (macro_original_text, expansion_obstack): Remove globals.
10597         (scan_macro_expansion, scanning_macro_expansion)
10598         (finished_macro_expansion): Update.
10599         (scan_macro_cleanup): Remove.
10600         (yylex, c_parse): Update.
10601
10602 2019-01-06  Tom Tromey  <tom@tromey.com>
10603
10604         * c-exp.y (struct c_parse_state) <strings>: New member.
10605         (operator_stoken): Update.
10606
10607 2019-01-06  Tom Tromey  <tom@tromey.com>
10608
10609         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10610         (union type_stack_elt) <typelist_val>: Now a pointer to
10611         std::vector.
10612         (type_stack_cleanup): Don't declare.
10613         (push_typelist): Update.
10614         * parse.c (pop_typelist): Return a std::vector.
10615         (push_typelist): Take a std::vector.
10616         (follow_types): Update.  Do not free args.
10617         (type_stack_cleanup): Remove.
10618         * c-exp.y (struct c_parse_state): New.
10619         (cpstate): New global.
10620         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10621         (nonempty_typelist): Update.
10622         (func_mod): Create a new vector.
10623         (c_parse): Create a c_parse_state.
10624         (check_parameter_typelist): Do not delete params.
10625         (function_method): Update.  Do not delete type_list.
10626
10627 2019-01-06  Tom Tromey  <tom@tromey.com>
10628
10629         PR gdb/28155:
10630         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10631         check_typedef.
10632         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10633         (print_return_value): Likewise.
10634
10635 2019-01-05  Tom Tromey  <tom@tromey.com>
10636
10637         * contrib/cleanup_check.py: Remove.
10638         * contrib/gcc-with-excheck: Remove.
10639         * contrib/exsummary.py: Remove.
10640         * contrib/excheck.py: Remove.
10641
10642 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10643
10644         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10645         NULL. Initialize tpprev to NULL instead of assigning it
10646         to NULL on the next statement.
10647         * windows-nat.c (windows_delete_thread): Remove check for
10648         main_thread_id before printing thread exit notifications.
10649         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10650         Remove thread ID check against main_thread_id.
10651         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10652         windows_delete_thread.
10653         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10654
10655 2019-01-04  Tom Tromey  <tom@tromey.com>
10656
10657         * compile/compile.c (_initialize_compile): Use upper case for
10658         metasyntactic variables.
10659         * symmisc.c (_initialize_symmisc): Use upper case for
10660         metasyntactic variables.
10661         * psymtab.c (_initialize_psymtab): Use upper case for
10662         metasyntactic variables.
10663         * demangle.c (demangle_command): Use upper case for metasyntactic
10664         variables.
10665         (_initialize_demangler): Likewise.
10666         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10667         variables.
10668
10669 2019-01-03  Tom Tromey  <tom@tromey.com>
10670
10671         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10672
10673 2019-01-03  Tom Tromey  <tom@tromey.com>
10674
10675         * python/py-symtab.c (salpy_str): Update.
10676         (struct salpy_sal_object) <symtab>: Now a PyObject.
10677         (salpy_dealloc): Update.
10678         (del_objfile_sal): Use gdbpy_ref.
10679
10680 2019-01-03  Tom Tromey  <tom@tromey.com>
10681
10682         * python/py-type.c (convert_field): Use new_reference.  Return
10683         gdbpy_ref.
10684         (make_fielditem): Return gdbpy_ref.
10685         (typy_fields): Update.
10686         (typy_getitem): Update.
10687         (field_name): Return gdbpy_ref.  Use new_reference.
10688         (typy_iterator_iternext): Update.
10689
10690 2019-01-03  Tom Tromey  <tom@tromey.com>
10691
10692         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10693
10694 2019-01-03  Tom Tromey  <tom@tromey.com>
10695
10696         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10697         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10698         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10699         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10700         (pspy_set_type_printers): Likewise.
10701         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10702         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10703         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10704         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10705         (objfpy_set_type_printers): Likewise.
10706
10707 2019-01-03  Tom Tromey  <tom@tromey.com>
10708
10709         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10710         (gdbpy_print_stack): Use gdbpy_err_fetch.
10711         * python/python-internal.h (class gdbpy_err_fetch): New class.
10712         (class gdbpy_enter) <m_error_type, m_error_value,
10713         m_error_traceback>: Remove.
10714         <m_error>: New member.
10715         (gdbpy_exception_to_string): Don't declare.
10716         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10717         * python/py-value.c (convert_value_from_python): Use
10718         gdbpy_err_fetch.
10719         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10720         gdbpy_exception_to_string.
10721         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10722         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10723         gdbpy_err_fetch.
10724
10725 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10726
10727         * linux-nat.c (delete_lwp_cleanup): Delete.
10728         (struct lwp_deleter): New struct.
10729         (lwp_info_up): New typedef.
10730         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10731         lwp_info_up.
10732
10733 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10734
10735         * linux-fork.c (class scoped_switch_fork_info): New class.
10736         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10737
10738 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10739
10740         * valops.c (find_overload_match): Remove use of null_cleanup, and
10741         calls to do_cleanups.
10742
10743 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10744
10745         * compile/compile-cplus-types.c
10746         (compile_cplus_instance::decl_name): Handle changes to
10747         cp_func_name.
10748         * cp-support.c (cp_func_name): Update header comment, update
10749         return type.
10750         * cp-support.h (cp_func_name): Update return type in declaration.
10751         * valops.c (find_overload_match): Move temp_func local to top
10752         level of function and change its type.  Use temp_func to hold and
10753         delete temporary string obtained from cp_func_name.
10754
10755 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10756
10757         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10758         gdb::char_vector, remove cleanup, and update uses of `msg`.
10759
10760 2019-01-03  Jim Wilson  <jimw@sifive.com>
10761
10762         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10763
10764 2019-01-02  Tom Tromey  <tom@tromey.com>
10765
10766         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10767         (tdesc_parse_xml): Remove cleanups.
10768         * target-descriptions.h (make_cleanup_free_target_description):
10769         Don't declare.
10770         (target_desc_deleter): New struct.
10771         (target_desc_up): New typedef.
10772         * target-descriptions.c (target_desc_deleter::operator()): Rename
10773         from free_target_description.
10774         (make_cleanup_free_target_description): Remove.
10775
10776 2019-01-02  Tom Tromey  <tom@tromey.com>
10777
10778         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10779         constructor, destructor.
10780         (linespec_parser): Remove typedef.
10781         (~linespec_parser): Rename from linespec_parser_delete.
10782         (linespec_lex_to_end, linespec_complete_label)
10783         (linespec_complete): Update.
10784         (decode_line_full): Remove cleanups.
10785         (decode_line_1): Update.
10786
10787 2019-01-02  Tom Tromey  <tom@tromey.com>
10788
10789         * python/python-internal.h (inferior_to_inferior_object): Change
10790         return type.
10791         * python/py-exitedevent.c (create_exited_event_object): Update.
10792         * python/py-inferior.c (inferior_to_inferior_object): Return
10793         gdbpy_ref.
10794         (python_new_inferior, python_inferior_deleted)
10795         (thread_to_thread_object, delete_thread_object)
10796         (build_inferior_list, gdbpy_selected_inferior): Update.
10797         * python/py-infthread.c (create_thread_object): Update.  Also fail
10798         if inferior_to_inferior_object fails.
10799
10800 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10801
10802         * inferior.h (class inferior) <displaced_step_state>: New field.
10803         * infrun.h (struct displaced_step_state): Move here from
10804         infrun.c.  Initialize fields, add constructor.
10805         <inf>: Remove field.
10806         <reset>: New method.
10807         * infrun.c (struct displaced_step_inferior_state): Move to
10808         infrun.h.
10809         (displaced_step_inferior_states): Remove.
10810         (get_displaced_stepping_state): Adust.
10811         (displaced_step_in_progress_any_inferior): Adjust.
10812         (displaced_step_in_progress_thread): Adjust.
10813         (displaced_step_in_progress): Adjust.
10814         (add_displaced_stepping_state): Remove.
10815         (get_displaced_step_closure_by_addr): Adjust.
10816         (remove_displaced_stepping_state): Remove.
10817         (infrun_inferior_exit): Call displaced_step_state.reset.
10818         (use_displaced_stepping): Don't check for NULL.
10819         (displaced_step_prepare_throw): Call
10820         get_displaced_stepping_state.
10821         (displaced_step_fixup): Don't check for NULL.
10822         (prepare_for_detach): Don't check for NULL.
10823
10824 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10825
10826         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10827          in case of call that did not complete.
10828
10829 2019-01-02  Andrey Utkin  <autkin@undo.io>
10830
10831         * symfile.c (find_separate_debug_file): Fix search of debug files for
10832         remote debuggee.
10833
10834 2019-01-02  Tom Tromey  <tom@tromey.com>
10835
10836         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10837         indentation.
10838         * python/py-frame.c (frapy_older): Remove cast.
10839         (frapy_newer): Likewise.
10840         * python/py-breakpoint.c (local_setattro): Remove cast.
10841         * python/py-arch.c (archpy_name): Remove local variable.
10842         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10843
10844 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10845
10846         * unittests/basic_string_view/element_access/char/empty.cc:
10847         Fix year range in copyright header.
10848
10849 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10850
10851         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10852         Delete.
10853         <operator==>: Update with for removed field.
10854         <hash>: Likewise.
10855         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10856         <isa_features>: ...this.
10857         <abi_features>: New field.
10858         (riscv_isa_flen): Update comment.
10859         (riscv_abi_xlen): New declaration.
10860         (riscv_abi_flen): New declaration.
10861         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10862         isa_features.
10863         (riscv_abi_xlen): New function.
10864         (riscv_isa_flen): Update to get answer from isa_features.
10865         (riscv_abi_flen): New function.
10866         (riscv_has_fp_abi): Update to get answer from abi_features.
10867         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10868         xlen and flen.
10869         (riscv_call_info) <xlen, flen>: Update comment.
10870         (riscv_call_arg_struct): Remove invalid assertions
10871         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10872         is removed.
10873         (riscv_gdbarch_init): Gather isa features and abi features
10874         separately, ensure both match on the gdbarch when reusing an old
10875         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10876         a target with 64-bit float hardware.
10877
10878 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10879
10880         * source.c (search_command_helper): Stop reverse search
10881         when line 1 has been searched.
10882
10883 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10884
10885         * record-full.c (record_full_base_target::close): Rewrite
10886         record_full_core_buf_list free logic.
10887
10888 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10889
10890         * break-catch-syscall.c (print_one_catch_syscall): xfree
10891         the last text.
10892
10893 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10894
10895         * top.c (print_gdb_version): Update Copyright year in version
10896         message.
10897
10898 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10899
10900         Update copyright year range in all GDB files.
10901
10902 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10903
10904         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10905
10906 For older changes see ChangeLog-2018.
10907 \f
10908 Local Variables:
10909 mode: change-log
10910 left-margin: 8
10911 fill-column: 74
10912 version-control: never
10913 coding: utf-8
10914 End:
10915