gdb/ChangeLog

   1 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
   2
   3         The MS-Windows port of ncurses fails to switch to a color pair if
   4         one or both of the colors are the implicit default colors.  This
   5         change records the default colors when TUI is initialized, and
   6         then specifies them explicitly when a color pair uses the default
   7         colors.  This allows color styling in TUI mode on MS-Windows.
   8
   9         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  10         ncurses_norm_attr.
  11         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  12         colors in ncurses_norm_attr.
  13         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  14         "none", replace it with the default color recorded in
  15         ncurses_norm_attr.
  16
  17 2019-03-14  Tom Tromey  <tromey@adacore.com>
  18
  19         * source-cache.h (class source_cache) <get_source_lines>: Return
  20         std::string.
  21         * source-cache.c (source_cache::extract_lines): Handle case where
  22         first_pos==npos.  Return std::string.
  23         (source_cache::get_source_lines): Update.
  24
  25 2019-03-14  Tom Tromey  <tromey@adacore.com>
  26
  27         * NEWS: Add item for "style sources" commands.
  28         * source-cache.c (source_cache::get_source_lines): Check
  29         source_styling.
  30         * cli/cli-style.c (source_styling): New global.
  31         (_initialize_cli_style): Add "style sources" commands.
  32         (show_style_sources): New function.
  33         * cli/cli-style.h (source_styling): Declare.
  34
  35 2019-03-14  Pedro Alves  <palves@redhat.com>
  36             Tom Tromey  <tromey@adacore.com>
  37
  38         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  39         * tui/tui-winsource.c (tui_refill_source_window): New function,
  40         from...
  41         (tui_horizontal_source_scroll): ... here.  Move some logic.
  42         * cli/cli-style.c (set_style_enabled): Notify new observable.
  43         * tui/tui-hooks.c (tui_redisplay_source): New function.
  44         (tui_attach_detach_observers): Attach or detach
  45         tui_redisplay_source.
  46         * observable.h (source_styling_changed): New observable.
  47         * observable.c: Define source_styling_changed observable.
  48
  49 2019-03-13  Tom Tromey  <tromey@adacore.com>
  50
  51         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
  52         (i386_gnu_nat_target::store_registers): Update.
  53         * target-debug.h (target_debug_print_std_string): New macro.
  54         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
  55         * windows-tdep.c (display_one_tib): Update.
  56         * tui/tui-stack.c (tui_make_status_line): Update.
  57         * top.c (print_inferior_quit_action): Update.
  58         * thread.c (thr_try_catch_cmd): Update.
  59         (add_thread_with_info): Update.
  60         (thread_target_id_str): Update.
  61         (thr_try_catch_cmd): Update.
  62         (thread_command): Update.
  63         (thread_find_command): Update.
  64         * record-btrace.c (record_btrace_target::info_record)
  65         (record_btrace_resume_thread, record_btrace_target::resume)
  66         (record_btrace_cancel_resume, record_btrace_step_thread)
  67         (record_btrace_target::wait, record_btrace_target::wait)
  68         (record_btrace_target::wait, record_btrace_target::stop): Update.
  69         * progspace.c (print_program_space): Update.
  70         * process-stratum-target.c
  71         (process_stratum_target::thread_address_space): Update.
  72         * linux-fork.c (linux_fork_mourn_inferior)
  73         (detach_checkpoint_command, info_checkpoints_command)
  74         (linux_fork_context): Update.
  75         (linux_fork_detach): Update.
  76         (class scoped_switch_fork_info): Update.
  77         (delete_checkpoint_command): Update.
  78         * infrun.c (follow_fork_inferior): Update.
  79         (follow_fork_inferior): Update.
  80         (proceed_after_vfork_done): Update.
  81         (handle_vfork_child_exec_or_exit): Update.
  82         (follow_exec): Update.
  83         (displaced_step_prepare_throw): Update.
  84         (displaced_step_restore): Update.
  85         (start_step_over): Update.
  86         (resume_1): Update.
  87         (clear_proceed_status_thread): Update.
  88         (proceed): Update.
  89         (print_target_wait_results): Update.
  90         (do_target_wait): Update.
  91         (context_switch): Update.
  92         (stop_all_threads): Update.
  93         (restart_threads): Update.
  94         (finish_step_over): Update.
  95         (handle_signal_stop): Update.
  96         (switch_back_to_stepped_thread): Update.
  97         (keep_going_pass_signal): Update.
  98         (print_exited_reason): Update.
  99         (normal_stop): Update.
 100         * inferior.c (inferior_pid_to_str): Change return type.
 101         (print_selected_inferior): Update.
 102         (add_inferior): Update.
 103         (detach_inferior): Update.
 104         * dummy-frame.c (fprint_dummy_frames): Update.
 105         * dcache.c (dcache_info_1): Update.
 106         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 107         (btrace_fetch, btrace_clear): Update.
 108         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 109         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 110         type.
 111         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 112         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 113         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 114         * gdbarch.c, gdbarch.h: Rebuild.
 115         * gdbarch.sh (core_pid_to_str): Change return type.
 116         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 117         return type.
 118         (windows_nat_target::pid_to_str): Change return type.
 119         (windows_delete_thread): Update.
 120         (windows_nat_target::attach): Update.
 121         (windows_nat_target::files_info): Update.
 122         * target-delegates.c: Rebuild.
 123         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 124         return type.
 125         (sol_thread_target::pid_to_str): Change return type.
 126         * remote.c (class remote_target) <pid_to_str>: Change return
 127         type.
 128         (remote_target::pid_to_str): Change return type.
 129         (extended_remote_target::attach, remote_target::remote_stop_ns)
 130         (remote_target::remote_notif_remove_queued_reply)
 131         (remote_target::push_stop_reply, remote_target::disable_btrace):
 132         Update.
 133         (extended_remote_target::attach): Update.
 134         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 135         type.
 136         (gdbsim_target::pid_to_str): Change return type.
 137         * ravenscar-thread.c (struct ravenscar_thread_target)
 138         <pid_to_str>: Change return type.
 139         (ravenscar_thread_target::pid_to_str): Change return type.
 140         * procfs.c (class procfs_target) <pid_to_str>: Change return
 141         type.
 142         (procfs_target::pid_to_str): Change return type.
 143         (procfs_target::attach): Update.
 144         (procfs_target::detach): Update.
 145         (procfs_target::fetch_registers): Update.
 146         (procfs_target::store_registers): Update.
 147         (procfs_target::wait): Update.
 148         (procfs_target::files_info): Update.
 149         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 150         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 151         return type.
 152         (nto_procfs_target::pid_to_str): Change return type.
 153         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 154         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 155         return type.
 156         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 157         (exit_lwp): Update.
 158         (attach_proc_task_lwp_callback, get_detach_signal)
 159         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 160         (linux_nat_target::resume, wait_lwp, stop_callback)
 161         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 162         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 163         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 164         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 165         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 166         type.
 167         (inf_ptrace_target::attach): Update.
 168         (inf_ptrace_target::files_info): Update.
 169         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 170         type.
 171         (go32_nat_target::pid_to_str): Change return type.
 172         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 173         (gnu_nat_target::wait): Update.
 174         (gnu_nat_target::wait): Update.
 175         (gnu_nat_target::resume): Update.
 176         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 177         (fbsd_nat_target::wait): Update.
 178         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 179         type.
 180         (darwin_nat_target::attach): Update.
 181         * corelow.c (class core_target) <pid_to_str>: Change return type.
 182         (core_target::pid_to_str): Change return type.
 183         * target.c (normal_pid_to_str): Change return type.
 184         (default_pid_to_str): Likewise.
 185         (target_pid_to_str): Change return type.
 186         (target_translate_tls_address): Update.
 187         (target_announce_detach): Update.
 188         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 189         return type.
 190         (bsd_uthread_target::pid_to_str): Change return type.
 191         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 192         type.
 193         (bsd_kvm_target::pid_to_str): Change return type.
 194         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 195         return type.
 196         (aix_thread_target::pid_to_str): Change return type.
 197         * target.h (struct target_ops) <pid_to_str>: Change return type.
 198         (target_pid_to_str, normal_pid_to_str): Likewise.
 199         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 200         type.
 201         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 202         type.
 203         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 204         return type.
 205         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 206         type.
 207         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 208         type.
 209         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 210         return type.
 211
 212 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 213
 214         * NEWS: Mention that the new default MI version is 3.  Mention
 215         changes to the output of commands and events that deal with
 216         multi-location breakpoints.
 217         * breakpoint.c: Include "mi/mi-out.h".
 218         (print_one_breakpoint): Change output syntax if using MI version
 219         >= 3.
 220         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 221         New.
 222         (mi_multi_location_breakpoint_output_fixed): New.
 223         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 224         (mi_cmd_fix_multi_location_breakpoint_output): New.
 225         (mi_multi_location_breakpoint_output_fixed): New.
 226         * mi/mi-cmds.c (mi_cmds): Register command
 227         -fix-multi-location-breakpoint-output.
 228         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 229         interpreter "mi".
 230
 231 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 232
 233         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 234         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 235         instantiate mi_ui_out based on interpreter name.
 236         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 237         * mi/mi-main.c (mi_load_progress): Likewise.
 238
 239 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 240
 241         * NEWS: Combine separate "New targets" sections for 8.3.
 242
 243 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 244
 245         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 246         (ppcfbsd_init_abi): Install gdbarch
 247         "fetch_tls_load_module_address" and "get_thread_local_address"
 248         methods.
 249
 250 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 251
 252         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 253         (riscv_fbsd_init_abi): Install gdbarch
 254         "fetch_tls_load_module_address" and "get_thread_local_address"
 255         methods.
 256
 257 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 258
 259         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 260         (i386fbsd_init_abi): Install gdbarch
 261         "fetch_tls_load_module_address" and "get_thread_local_address"
 262         methods.
 263
 264 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 265
 266         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 267         (amd64fbsd_init_abi): Install gdbarch
 268         "fetch_tls_load_module_address" and "get_thread_local_address"
 269         methods.
 270
 271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 272
 273         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 274         (struct fbsd_pspace_data): New type.
 275         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 276         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 277         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 278         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 279         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 280
 281 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 282
 283         * gdbtypes.c (lookup_struct_elt): New function.
 284         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 285         * gdbtypes.h (struct struct_elt): New type.
 286         (lookup_struct_elt): New prototype.
 287
 288 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 289
 290         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 291         remove disabled code block.
 292
 293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 294
 295         * gdbarch.sh (get_thread_local_address): New method.
 296         * gdbarch.h, gdbarch.c: Regenerate.
 297         * target.c (target_translate_tls_address): Use
 298         gdbarch_get_thread_local_address if present instead of
 299         target::get_thread_local_address.
 300
 301 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 302
 303         * target.h (target::get_thread_local_address): Update comment.
 304
 305 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 306
 307         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 308         objfile->separate_debug_objfile_backlink if not NULL.
 309
 310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 311
 312         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 313         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 314         (amd64bsd_store_inferior_registers): Likewise.
 315         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 316         Enable segment base registers.
 317         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 318         PT_GETFSBASE and PT_GETGSBASE.
 319         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 320         PT_SETGSBASE.
 321         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 322         segment base registers.
 323         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 324
 325 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 326
 327         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 328         Update calls to i386_target_description to add 'segments'
 329         parameter.
 330         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 331         add segment base registers.
 332         * arch/i386.c (i386_create_target_description): Add 'segments'
 333         parameter to enable segment base registers.
 334         * arch/i386.h (i386_create_target_description): Likewise.
 335         * features/i386/32bit-segments.xml: New file.
 336         * features/i386/32bit-segments.c: Generate.
 337         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 338         call to i386_target_description to add 'segments' parameter.
 339         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 340         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 341         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 342         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 343         if feature is present.
 344         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 345         Add 'segments' parameter to call to i386_target_description.
 346         (i386_target_description): Add 'segments' parameter to enable
 347         segment base registers.
 348         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 349         to call to i386_target_description.
 350         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 351         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 352         Define I386_NUM_REGS.
 353         (i386_target_description): Add 'segments' parameter to enable
 354         segment base registers.
 355
 356 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 357
 358         PR/24325
 359         * source-cache.c: #undef open and close, to avoid unresolved
 360         externals during linking.
 361
 362 2019-03-12  Tom Tromey  <tromey@adacore.com>
 363
 364         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 365         const.  Add initializers.
 366         (_initialize_remote): Don't initialize ptid globals.
 367
 368 2019-03-12  Pedro Alves  <palves@redhat.com>
 369
 370         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 371
 372 2019-03-12  Pedro Alves  <palves@redhat.com>
 373
 374         * cp-name-parser.y (main): Remove unused 'len' variable.
 375
 376 2019-03-12  Tom Tromey  <tromey@adacore.com>
 377
 378         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 379         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 380
 381 2019-03-12  Tom Tromey  <tromey@adacore.com>
 382
 383         * linux-nat.c (iterate_over_lwps): Update.
 384         (stop_callback): Remove parameter.
 385         (stop_wait_callback, detach_callback, resume_set_callback)
 386         (select_singlestep_lwp_callback, set_ignore_sigint)
 387         (status_callback, resumed_callback, resume_clear_callback)
 388         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 389         data parameter.
 390         (linux_nat_target::detach, linux_nat_target::resume)
 391         (linux_stop_and_wait_all_lwps, select_event_lwp)
 392         (linux_nat_filter_event, linux_nat_wait_1)
 393         (linux_nat_target::kill, linux_nat_target::stop)
 394         (linux_nat_target::stop): Update.
 395         (linux_nat_resume_callback): Change type.
 396         (resume_stopped_resumed_lwps, count_events_callback)
 397         (select_event_lwp_callback): Likewise.
 398         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 399         * arm-linux-nat.c (struct update_registers_data): Remove.
 400         (update_registers_callback): Change type.
 401         (arm_linux_insert_hw_breakpoint1): Update.
 402         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 403         parameter.
 404         (x86_linux_dr_set_addr): Update.
 405         (x86_linux_dr_set_control): Update.
 406         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 407         (iterate_over_lwps): Use gdb::function_view.
 408         * nat/aarch64-linux-hw-point.c (struct
 409         aarch64_dr_update_callback_param): Remove.
 410         (debug_reg_change_callback): Change type.
 411         (aarch64_notify_debug_reg_change): Update.
 412         * s390-linux-nat.c (s390_refresh_per_info): Update.
 413
 414 2019-03-11  Tom Tromey  <tromey@adacore.com>
 415
 416         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 417         redundant assignment to "this_cu".
 418
 419 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 420
 421         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 422
 423 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 424
 425         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 426         from...
 427         (rank_one_type): ... this.
 428
 429 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 430
 431         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 432         from...
 433         (rank_one_type): ... this.
 434
 435 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 436
 437         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 438         from...
 439         (rank_one_type): ... this.
 440
 441 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 442
 443         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 444         from...
 445         (rank_one_type): ... this.
 446
 447 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 448
 449         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 450         from...
 451         (rank_one_type): ... this.
 452
 453 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 454
 455         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 456         from...
 457         (rank_one_type): ... this.
 458
 459 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 460
 461         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 462         from...
 463         (rank_one_type): ... this.
 464
 465 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 466
 467         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 468         from...
 469         (rank_one_type): ... this.
 470
 471 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 472
 473         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 474         from...
 475         (rank_one_type): ... this.
 476
 477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 478
 479         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 480         from...
 481         (rank_one_type): ... this.
 482
 483 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 484
 485         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 486         from...
 487         (rank_one_type): ... this.
 488
 489 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 490
 491         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 492         from...
 493         (rank_one_type): ... this.
 494
 495 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 496
 497         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 498         inferior-events' shows the example events.
 499
 500 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 501
 502         Support styling on native MS-Windows console
 503
 504         PR/24315
 505         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 506         on MS-Windows if $TERM is not defined.
 507
 508         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 509
 510         * posix-hdep.c (gdb_console_fputs):
 511         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 512         functions.
 513         * ui-file.h (gdb_console_fputs): Add prototype.
 514
 515         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 516         back to fputs only if the former returns zero.
 517
 518 2019-03-07  Tom Tromey  <tom@tromey.com>
 519
 520         * symmisc.c (print_symbol_bcache_statistics): Update.
 521         (print_objfile_statistics): Update.
 522         * symfile.c (allocate_symtab): Update.
 523         * stabsread.c: Don't include bcache.h.
 524         * psymtab.h (struct psymbol_bcache): Don't declare.
 525         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 526         (psymbol_bcache_init, psymbol_bcache_free)
 527         (psymbol_bcache_get_bcache): Don't declare.
 528         * psymtab.c (struct psymbol_bcache): Remove.
 529         (psymtab_storage::psymtab_storage): Update.
 530         (psymtab_storage::~psymtab_storage): Update.
 531         (psymbol_bcache_init, psymbol_bcache_free)
 532         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 533         (add_psymbol_to_bcache): Update.
 534         (allocate_psymtab): Update.
 535         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 536         macro_cache>: No longer pointers.
 537         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 538         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 539         * macrotab.c (macro_bcache): Update.
 540         * macroexp.c: Don't include bcache.h.
 541         * gdbtypes.c (check_types_worklist): Update.
 542         (types_deeply_equal): Remove TRY/CATCH.  Update.
 543         * elfread.c (elf_symtab_read): Update.
 544         * dwarf2read.c: Don't include bcache.h.
 545         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 546         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 547         (print_bcache_statistics, bcache_memory_used): Don't declare.
 548         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 549         methods.  Rename all data members.
 550         * bcache.c (struct bcache): Move to bcache.h.
 551         (bcache::expand_hash_table): Rename from expand_hash_table.
 552         (bcache): Remove.
 553         (bcache::insert): Rename from bcache_full.
 554         (bcache::compare): Rename from bcache_compare.
 555         (bcache_xmalloc): Remove.
 556         (bcache::~bcache): Rename from bcache_xfree.
 557         (bcache::print_statistics): Rename from print_bcache_statistics.
 558         (bcache::memory_used): Rename from bcache_memory_used.
 559
 560 2019-03-07  Pedro Alves  <palves@redhat.com>
 561
 562         * infrun.c (normal_stop): Also check for
 563         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 564
 565 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * f-lang.c (value_from_host_double): Moved to...
 568         * value.c (value_from_host_double): ...here.
 569         * value.h (value_from_host_double): Declare.
 570         * guile/scm-math.c (vlscm_convert_typed_number): Use
 571         value_from_host_double.
 572         (vlscm_convert_number): Likewise.
 573         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 574         * python/py-value.c (convert_value_from_python): Likewise.
 575
 576 2019-03-06  Tom Tromey  <tom@tromey.com>
 577
 578         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 579
 580 2019-03-06  Tom Tromey  <tom@tromey.com>
 581
 582         * utils.h (free_current_contents): Don't declare.
 583         * utils.c (free_current_contents): Remove.
 584
 585 2019-03-06  Tom Tromey  <tom@tromey.com>
 586
 587         * top.c (quit_force): Update.
 588         * main.c (captured_command_loop): Update.
 589         * common/new-op.c (operator new): Update.
 590         * common/common-exceptions.c (struct catcher)
 591         <save_cleanup_chain>: Remove member.
 592         (exceptions_state_mc_init): Update.
 593         (exception_try_scope_entry): Return nullptr.
 594         (exception_try_scope_exit, exception_rethrow)
 595         (throw_exception_sjlj, throw_exception_cxx): Update.
 596         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 597         (all_cleanups, do_cleanups, discard_cleanups)
 598         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 599         (restore_cleanups, restore_final_cleanups): Don't declare.
 600         (do_final_cleanups): Remove parameter.
 601         * common/cleanups.c (cleanup_chain, make_cleanup)
 602         (make_cleanup_dtor, all_cleanups, do_cleanups)
 603         (discard_my_cleanups, discard_cleanups)
 604         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 605         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 606         (null_cleanup): Remove.
 607         (do_final_cleanups): Remove parameter.
 608
 609 2019-03-06  Tom Tromey  <tom@tromey.com>
 610
 611         * remote.c (remote_target::remote_parse_stop_reply): Use
 612         unique_xmalloc_ptr.
 613
 614 2019-03-06  Tom Tromey  <tom@tromey.com>
 615
 616         * stabsread.c (struct stabs_field_info): Rename from field_info.
 617         <list, fnlist>: Add initializers.
 618         <obstack>: New member.
 619         (read_member_functions, read_struct_fields, read_baseclasses):
 620         Allocate on obstack.  Don't use cleanups.
 621         (read_one_struct_field, read_member_functions, read_struct_fields)
 622         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 623         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 624         (read_struct_type): Update.
 625
 626 2019-03-06  Tom Tromey  <tom@tromey.com>
 627
 628         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 629         * common/filestuff.h (make_cleanup_close): Don't declare.
 630         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 631         Remove.
 632
 633 2019-03-06  Tom Tromey  <tom@tromey.com>
 634
 635         * solib-aix.c: Use make_scope_exit.
 636
 637 2019-03-06  Tom Tromey  <tom@tromey.com>
 638
 639         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 640         Use make_scope_exit.
 641
 642 2019-03-06  Tom Tromey  <tom@tromey.com>
 643
 644         * solib-svr4.c (disable_probes_interface): Remove parameter.
 645         (svr4_handle_solib_event): Use make_scope_exit.
 646
 647 2019-03-06  Tom Tromey  <tom@tromey.com>
 648
 649         * remote.c (struct stop_reply_deleter): Remove.
 650         (stop_reply_up): Update.
 651         (struct stop_reply): Derive from notif_event.  Don't typedef.
 652         <regcache>: Now a std::vector.
 653         (stop_reply_xfree): Remove.
 654         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 655         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 656         (remote_target::discard_pending_stop_replies): Use delete.
 657         (remote_target::remote_parse_stop_reply): Update.
 658         (remote_target::process_stop_reply): Update.
 659         * remote-notif.h (struct notif_event): Add virtual destructor.
 660         Remove "dtr" member.
 661         (struct notif_client) <alloc_event>: Return a unique_ptr.
 662         (notif_event_xfree): Don't declare.
 663         (notif_event_up): New typedef.
 664         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 665         (notif_event_xfree, do_notif_event_xfree): Remove.
 666         (remote_notif_state_xfree): Update.
 667
 668 2019-03-06  Tom Tromey  <tom@tromey.com>
 669
 670         * infrun.c (displaced_step_clear_cleanup): Now a
 671         forward_scope_exit type.
 672         (displaced_step_prepare_throw): Update.
 673         (displaced_step_fixup): Update.
 674
 675 2019-03-06  Tom Tromey  <tom@tromey.com>
 676
 677         * inferior.h (class inferior): Update comment.
 678         * gdbthread.h (class thread_info): Update comment.
 679
 680 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 681             Tom Tromey  <tom@tromey.com>
 682
 683         * stabsread.h (struct stab_section_list): Remove.
 684         (coffstab_build_psymtabs): Update.
 685         * dbxread.c (symbuf_sections): Now a std::vector.
 686         (sect_idx): New global.
 687         (fill_symbuf): Update.
 688         (coffstab_build_psymtabs): Change type of stabsects parameter.
 689         Update.
 690         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 691         std::vector.
 692         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 693         (coff_locate_sections): Update.
 694         (coff_symfile_read): Remove cleanups.  Update.
 695         (init_stringtab): Add storage parameter.
 696         (free_stringtab, free_stringtab_cleanup): Remove.
 697         (init_lineno): Add storage parameter.
 698         (free_linetab, free_linetab_cleanup): Remove.
 699
 700 2019-03-06  Pedro Alves  <palves@redhat.com>
 701
 702         * linux-fork.c (fork_info::clobber_regs): Delete.
 703         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 704         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 705         comment.  Adjust.
 706         (scoped_switch_fork_info::scoped_switch_fork_info)
 707         (checkpoint_command, linux_fork_context): Adjust
 708         fork_save_infrun_state calls.
 709
 710 2019-03-06  Pedro Alves  <palves@redhat.com>
 711
 712         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 713         (inf_has_multiple_threads): Return 'bool' and rewrite using
 714         inferior_info::threads().
 715
 716 2019-03-06  Pedro Alves  <palves@redhat.com>
 717
 718         * linux-fork.c: Include <list>.
 719         (fork_list): Now a std::list instance.
 720         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 721         (forks_exist_p, find_last_fork): Adjust.
 722         (new_fork): Delete.
 723         (one_fork_p): New.
 724         (add_fork): Adjust.
 725         (free_fork): Delete, folded into fork_info::~fork_info().
 726         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 727         Adjust.
 728         (init_fork_list): Delete.
 729         (linux_fork_killall, linux_fork_mourn_inferior)
 730         (linux_fork_detach, info_checkpoints_command): Adjust.
 731         (_initialize_linux_fork): No longer call init_fork_list.
 732
 733 2019-03-06  Pedro Alves  <palves@redhat.com>
 734
 735         * linux-fork.c (new_fork): New, split out of ...
 736         (add_fork): ... this.  Return void.  Move "first fork" special
 737         case from here, to ...
 738         (checkpoint_command): ... here.
 739         * linux-linux.h (add_fork): Return void.
 740
 741 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 742
 743         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 744
 745 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 746             Chris January  <chris.january@arm.com>
 747             David Lecomber  <david.lecomber@arm.com>
 748
 749         * f-exp.y: New token, UNOP_INTRINSIC.
 750         (exp): New pattern using UNOP_INTRINSIC token.
 751         (f77_keywords): Add 'abs' keyword.
 752         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 753         (value_from_host_double): New function.
 754         (evaluate_subexp_f): Support UNOP_ABS.
 755
 756 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 757
 758         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 759         types.
 760
 761 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 762
 763         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 764         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 765         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 766
 767 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 768
 769         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 770
 771 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 772             Chris January  <chris.january@arm.com>
 773
 774         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 775         * f-exp.y: Define 'KIND' token.
 776         (exp): New pattern for KIND expressions.
 777         (ptype): Handle types with a kind extension.
 778         (direct_abs_decl): Extend to spot kind extensions.
 779         (f77_keywords): Add 'kind' to the list.
 780         (push_kind_type): New function.
 781         (convert_to_kind_type): New function.
 782         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 783         * parse.c (operator_length_standard): Likewise.
 784         * parser-defs.h (enum type_pieces): Add tp_kind.
 785         * std-operator.def: Add UNOP_KIND.
 786
 787 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 788
 789         * f-exp.y (f_parse): Set yydebug.
 790
 791 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 792
 793         * f-lang.c (evaluate_subexp_f): New function.
 794         (exp_descriptor_f): New global.
 795         (f_language_defn): Use exp_descriptor_f instead of
 796         exp_descriptor_standard.
 797
 798 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 799
 800         * f-exp.y (struct token): Add comments.
 801         (dot_ops): Remove uppercase versions and the end marker.
 802         (f77_keywords): Likewise.
 803         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 804         entries in the dot_ops array are case insensitive, and use
 805         strncasecmp to compare strings.  Also some whitespace cleanup in
 806         this area.  Similar for the f77_keywords array, except entries in
 807         this list might be case sensitive.
 808
 809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 810
 811         * f-exp.y (struct f77_boolean_val): Add comments.
 812         (boolean_values): Remove uppercase versions, and end marker.
 813         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 814         and use strncasecmp to achieve case insensitivity.  Additionally,
 815         perform whitespace cleanup around this code.
 816
 817 2019-03-06  Tom Tromey  <tromey@adacore.com>
 818
 819         * remote-sim.c (gdbsim_target_open): Use result of
 820         gdb_argv::release.
 821
 822 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 823         Dirk Schubert  <dirk.schubert@arm.com>
 824         Chris January  <chris.january@arm.com>
 825
 826         * eval.c (evaluate_subexp_standard): Call Fortran argument
 827         wrapping logic.
 828         * f-lang.c (struct value): A value which can be passed into a
 829         Fortran function call.
 830         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 831         where appropriate.
 832         (struct type): Value ready for a Fortran function call.
 833         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 834         is needed.
 835         * f-lang.h (fortran_argument_convert): Declaration.
 836         (fortran_preserve_arg_pointer): Declaration.
 837         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 838
 839 2019-03-05  Tom Tromey  <tromey@adacore.com>
 840
 841         * python/py-prettyprint.c (print_string_repr): Remove #if.
 842         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 843
 844 2019-03-05  Tom Tromey  <tromey@adacore.com>
 845
 846         * target.c (the_dummy_target): Move later.  Change type to
 847         "dummy_target".
 848         (initialize_targets): Don't initialize the_dummy_target.
 849
 850 2019-03-05  Tom Tromey  <tromey@adacore.com>
 851
 852         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 853         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 854
 855 2019-03-05  Tom Tromey  <tromey@adacore.com>
 856
 857         * windows-nat.c (windows_nat_target::attach)
 858         (windows_nat_target::detach): Don't call gdb_flush.
 859         * valprint.c (generic_val_print, val_print, val_print_string):
 860         Don't call gdb_flush.
 861         * utils.c (defaulted_query): Don't call gdb_flush.
 862         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 863         * target.c (target_announce_detach): Don't call gdb_flush.
 864         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 865         * remote.c (extended_remote_target::attach): Don't call
 866         gdb_flush.
 867         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 868         * printcmd.c (do_examine): Don't call gdb_flush.
 869         (info_display_command): Don't call gdb_flush.
 870         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 871         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 872         * memattr.c (info_mem_command): Don't call gdb_flush.
 873         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 874         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 875         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 876         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 877         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 878         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 879         (gnu_nat_target::detach): Don't call gdb_flush.
 880         * f-valprint.c (f_val_print): Don't call gdb_flush.
 881         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 882         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 883         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 884         gdb_flush.
 885         * c-valprint.c (c_val_print): Don't call gdb_flush.
 886         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 887
 888 2019-03-05  Tom Tromey  <tromey@adacore.com>
 889
 890         * varobj.c (update_dynamic_varobj_children): Update.
 891         (install_default_visualizer): Use reset, not release.
 892         * value.c (set_internalvar): Update.
 893         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 894         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 895         ATTRIBUTE_UNUSED_RESULT.
 896
 897 2019-03-05  Tom Tromey  <tromey@adacore.com>
 898
 899         * remote.c (class scoped_remote_fd) <release>: Add
 900         ATTRIBUTE_UNUSED_RESULT.
 901
 902 2019-03-05  Tom Tromey  <tromey@adacore.com>
 903
 904         * macroexp.c (struct macro_buffer) <release>: Add
 905         ATTRIBUTE_UNUSED_RESULT.
 906
 907 2019-03-05  Tom Tromey  <tromey@adacore.com>
 908
 909         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 910         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 911         ATTRIBUTE_UNUSED_RESULT.
 912
 913 2019-03-05  Tom Tromey  <tromey@adacore.com>
 914
 915         * common/scoped_fd.h (class scoped_fd) <release>: Add
 916         ATTRIBUTE_UNUSED_RESULT.
 917
 918 2019-03-05  Tom Tromey  <tromey@adacore.com>
 919
 920         * parser-defs.h (struct parser_state) <release>: Add
 921         ATTRIBUTE_UNUSED_RESULT.
 922
 923 2019-03-05  Tom Tromey  <tromey@adacore.com>
 924
 925         * utils.h (class gdb_argv) <release>: Add
 926         ATTRIBUTE_UNUSED_RESULT.
 927         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 928
 929 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 930
 931         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 932         for-loop range, to avoid compiler warnings.
 933
 934         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 935         avoid compiler warnings about unused variables.
 936
 937         * NEWS: Mention end of support for native debugging on MS-Windows
 938         before XP.
 939
 940         PR gdb/24292
 941         * common/netstuff.c:
 942         * gdbserver/gdbreplay.c
 943         * gdbserver/remote-utils.c:
 944         * ser-tcp.c:
 945         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 946         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 947         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 948         'getaddrinfo' and 'freeaddrinfo' were not available before
 949         Windows XP, and mingw.org's MinGW headers by default define
 950         _WIN32_WINNT to 0x500.
 951
 952 2019-03-01  Gary Benson <gbenson@redhat.com>
 953
 954         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 955
 956 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 957             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 958
 959         PR gdb/8527
 960         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 961         set_sigint_trap, clear_sigint_trap.
 962
 963 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 964
 965         * target.c (target_detach): Clear the regcache and the
 966         frame cache.
 967
 968 2019-02-27  Pedro Alves  <palves@redhat.com>
 969
 970         * utils.c (set_screen_size): When we cap the height/width sizes,
 971         tweak the corresponding command variable to show "unlimited":
 972
 973 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 974             Pedro Alves  <palves@redhat.com>
 975
 976         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 977         before calling rl_set_screen_size.
 978
 979 2019-02-27  Tom Tromey  <tromey@adacore.com>
 980
 981         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 982         define.
 983         * python/py-value.c: Remove Python 2.4 workaround.
 984         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 985         workaround.
 986         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 987         Python 2.4 workaround.
 988         * python/python-internal.h: Remove Python 2.4 comment.
 989         (Py_ssize_t): Don't define.
 990         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 991         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 992         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 993         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 994         * python/python.c (do_start_initialization): Remove Python 2.4
 995         workaround.
 996         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 997         (print_children): Remove Python 2.4 workaround.
 998         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 999         workaround.
1000         (CHARBUFFERPROC_NAME): Remove.
1001         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1002         Python 2.4 workaround.
1003
1004 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1005
1006         * NEWS: Note minimum Python version.
1007
1008 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1009
1010         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1011         code from these functions.  Remove corresponding ifdefs.  Use
1012         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1013         Remove gotos and target of gotos.
1014         (infpy_search_memory): Likewise.
1015
1016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1019         (hppa_gdbarch_init): Don't register deleted functions with
1020         gdbarch.
1021
1022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1025         (h8300_unwind_sp): Delete.
1026         (h8300_dummy_id): Delete.
1027         (h8300_gdbarch_init): Don't register deleted functions with
1028         gdbarch.
1029
1030 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1031
1032         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1033         (ft32_unwind_pc): Delete.
1034         (ft32_unwind_sp): Delete.
1035         (ft32_gdbarch_init): Don't register deleted functions with
1036         gdbarch.
1037
1038 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1039
1040         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1041         (frv_unwind_pc): Delete.
1042         (frv_unwind_sp): Delete.
1043         (frv_gdbarch_init): Don't register deleted functions with
1044         gdbarch.
1045
1046 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1049         (riscv_unwind_pc): Delete.
1050         (riscv_unwind_sp): Delete.
1051         (riscv_gdbarch_init): Don't register deleted functions with
1052         gdbarch.
1053
1054 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1055
1056         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1057         (csky_unwind_pc): Delete.
1058         (csky_unwind_sp): Delete.
1059         (csky_gdbarch_init): Don't register deleted functions with
1060         gdbarch.
1061
1062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1063
1064         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1065         (cris_unwind_pc): Delete.
1066         (cris_unwind_sp): Delete.
1067         (cris_gdbarch_init): Don't register deleted functions with
1068         gdbarch.
1069
1070 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1073         (bfin_unwind_pc): Delete.
1074         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1075
1076 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1077
1078         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1079         (arm_unwind_pc): Delete.
1080         (arm_unwind_sp): Delete.
1081         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1082
1083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1084
1085         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1086         (arc_unwind_pc): Delete.
1087         (arc_unwind_sp): Delete.
1088         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1089
1090 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1091
1092         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1093         (alpha_unwind_pc): Delete.
1094         (alpha_gdbarch_init): Don't register deleted functions with
1095         gdbarch.
1096
1097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1098
1099         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1100         (aarch64_unwind_pc): Delete.
1101         (aarch64_unwind_sp): Delete.
1102         (aarch64_gdbarch_init): Don't register deleted functions with
1103         gdbarch.
1104
1105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1106
1107         * gdbtypes.c (type_align): Don't consider static members when
1108         computing structure alignment.
1109
1110 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1113         return 0 for other types.
1114         * arch-utils.c (default_type_align): Always return 0.
1115         * gdbarch.h: Regenerate.
1116         * gdbarch.sh (type_align): Extend comment.
1117         * gdbtypes.c (type_align): Add additional comments, always call
1118         gdbarch_type_align before applying the default rules.
1119         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1120         generic code will then apply a suitable default.
1121         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1122         types, return 0 for other types.
1123
1124 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1125
1126         * NEWS: Create a new section for the next release branch.
1127         Rename the section of the current branch, now that it has
1128         been cut.
1129
1130 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1131
1132         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1133         * version.in: Bump version to 8.3.50.DATE-git.
1134
1135 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1136
1137         * aix-thread.c (ptid_cmp): Remove unused variable.
1138         (get_signaled_thread): Likewise.
1139         (store_regs_user_thread): Likewise.
1140         (store_regs_kernel_thread): Likewise.
1141         (fetch_regs_kernel_thread): Remove shadowed variable.
1142
1143 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1144
1145         * features/riscv/32bit-cpu.xml: Add register numbers.
1146         * features/riscv/32bit-fpu.c: Regenerate.
1147         * features/riscv/32bit-fpu.xml: Add register numbers.
1148         * features/riscv/64bit-cpu.xml: Add register numbers.
1149         * features/riscv/64bit-fpu.c: Regenerate.
1150         * features/riscv/64bit-fpu.xml: Add register numbers.
1151
1152 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1153
1154         * NEWS: Mention two argument form of gdb.Value constructor.
1155         * python/py-value.c (convert_buffer_and_type_to_value): New
1156         function.
1157         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1158         Add support for handling an optional second argument.  Call
1159         convert_buffer_and_type_to_value as appropriate.
1160         * python/python-internal.h (Py_buffer_deleter): New struct.
1161         (Py_buffer_up): New typedef.
1162
1163 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1164
1165         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1166         instead of releasing ownership.
1167
1168 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1169
1170         * dwarf2read.c (open_and_init_dwp_file): Call
1171         elf_numsections instead of bfd_count_sections to initialize
1172         dwp_file->num_sections.
1173
1174 2019-02-25  Tom Tromey  <tromey@adacore.com>
1175
1176         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1177
1178 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1179
1180         * gcore.in: Add '--readnever' option when invoking GDB.
1181
1182 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1183
1184         * MAINTAINERS: Update my email address.
1185
1186 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1187
1188         * build-id.c (build_id_to_debug_bfd_1): New function.
1189         (build_id_to_debug_bfd): Look for separate debug file in
1190         sysroot.
1191
1192 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1193
1194         * gdbarch.sh: Update the copyright year range that is placed into
1195         generated files.
1196
1197 2019-02-22  Keith Seitz  <keiths@redhat.com>
1198
1199         PR symtab/23853
1200         * linespec.c (create_sals_line_offset): Search for the default
1201         symtab's filename instead of its fullname.
1202
1203 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1204
1205         * NEWS: Update style defaults.
1206
1207 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1208
1209         * main.c (captured_main_1): Disable styling in batch mode.
1210
1211 2019-02-20  Tom Tromey  <tom@tromey.com>
1212
1213         * symtab.c (symtab_symbol_info): Fix typos.
1214
1215 2019-02-20  Tom Tromey  <tromey@adacore.com>
1216
1217         * findcmd.c (_initialize_mem_search): Use upper case for
1218         metasyntactic variables.
1219
1220 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1221
1222         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1223         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1224
1225 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1226
1227         * top.h (source_file_name): Change to std::string.
1228         * top.c (source_file_name): Likewise.
1229         (command_line_input): Adjust.
1230         * cli/cli-script.c (script_from_file): Adjust.
1231
1232 2019-02-19  Tom Tromey  <tromey@adacore.com>
1233
1234         * ravenscar-thread.c
1235         (ravenscar_thread_target::update_thread_list): Don't call
1236         ada_build_task_list.
1237         * ada-lang.h (ada_build_task_list): Don't declare.
1238         * ada-tasks.c (struct ada_tasks_inferior_data)
1239         <task_list_valid_p>: Now bool.
1240         (read_known_tasks, ada_task_list_changed)
1241         (ada_tasks_invalidate_inferior_data): Update.
1242         (read_known_tasks_array): Return bool.
1243         (read_known_tasks_list): Likewise.
1244         (read_known_tasks): Return void.
1245         (ada_build_task_list): Now static.
1246
1247 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1248
1249         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1250         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1251
1252 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1253
1254         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1255         variant for ada_tasks_pspace_data_handle and
1256         ada_tasks_inferior_data_handle.
1257         (ada_tasks_pspace_data_cleanup): New function.
1258         (ada_tasks_inferior_data_cleanup): New function.
1259
1260 2019-02-17  Tom Tromey  <tom@tromey.com>
1261
1262         * macrotab.h (macro_source_fullname): Return a std::string.
1263         * macrotab.c (macro_include, check_for_redefinition)
1264         (macro_undef, macro_lookup_definition, foreach_macro)
1265         (foreach_macro_in_scope): Update.
1266         (macro_source_fullname): Return a std::string.
1267         * macrocmd.c (show_pp_source_pos): Update.
1268
1269 2019-02-17  Tom Tromey  <tom@tromey.com>
1270
1271         * macrocmd.c (show_pp_source_pos): Style the file names.
1272
1273 2019-02-17  Tom Tromey  <tom@tromey.com>
1274
1275         PR tui/24197:
1276         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1277
1278 2019-02-17  Tom Tromey  <tom@tromey.com>
1279
1280         * ada-lang.c (user_select_syms): Use filtered printing.
1281         * utils.c (wrap_style): New global.
1282         (desired_style): Remove.
1283         (emit_style_escape): Add stream parameter.
1284         (set_output_style, reset_terminal_style, prompt_for_continue):
1285         Update.
1286         (flush_wrap_buffer): Only flush gdb_stdout.
1287         (wrap_here): Set wrap_style.
1288         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1289         treat escape sequences as a character.  Change when wrap buffer is
1290         flushed.
1291         (fputs_styled): Do not set the output style when the default is
1292         requested.
1293         * ui-style.h (struct ui_file_style) <is_default>: New method.
1294         * source.c (print_source_lines_base): Emit escape sequences in one
1295         piece.
1296
1297 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1298
1299         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1300         integers and enumeration types.
1301
1302 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1303
1304         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1305         instead of lookup_symbol_in_language
1306         (do_exact_match): New function.
1307         (ada_get_symbol_name_matcher): Return do_exact_match when
1308         doing a verbatim match.
1309
1310 2019-02-15  Tom Tromey  <tromey@adacore.com>
1311
1312         * ravenscar-thread.c (ravenscar_thread_target::resume)
1313         (ravenscar_thread_target::wait): Special case wildcard requests.
1314
1315 2019-02-15  Tom Tromey  <tromey@adacore.com>
1316
1317         * ravenscar-thread.c (base_ptid): Remove.
1318         (struct ravenscar_thread_target) <close>: New method.
1319         <m_base_ptid>: New member.
1320         <update_inferior_ptid, active_task, task_is_currently_active,
1321         runtime_initialized>: Declare methods.
1322         <ravenscar_thread_target>: Add constructor.
1323         (ravenscar_thread_target::task_is_currently_active)
1324         (ravenscar_thread_target::update_inferior_ptid)
1325         (ravenscar_runtime_initialized): Rename.  Now methods.
1326         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1327         (ravenscar_thread_target::update_thread_list): Update.
1328         (ravenscar_thread_target::active_task): Now method.
1329         (ravenscar_thread_target::store_registers)
1330         (ravenscar_thread_target::prepare_to_store)
1331         (ravenscar_thread_target::prepare_to_store)
1332         (ravenscar_thread_target::mourn_inferior): Update.
1333         (ravenscar_inferior_created): Use "new" to create target.
1334         (ravenscar_thread_target::get_ada_task_ptid): Update.
1335         (_initialize_ravenscar): Don't initialize base_ptid.
1336         (ravenscar_ops): Remove global.
1337
1338 2019-02-15  Tom Tromey  <tromey@adacore.com>
1339
1340         * target.h (push_target): Declare new overload.
1341         * target.c (push_target): New overload, taking an rvalue reference.
1342         * remote.c (remote_target::open_1): Use push_target overload.
1343         * corelow.c (core_target_open): Use push_target overload.
1344
1345 2019-02-15  Tom Tromey  <tromey@adacore.com>
1346
1347         * ravenscar-thread.c (is_ravenscar_task)
1348         (ravenscar_task_is_currently_active): Return bool.
1349         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1350         (_initialize_ravenscar): Remove "(void)".
1351         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1352         Return bool.
1353
1354 2019-02-15  Tom Tromey  <tromey@adacore.com>
1355
1356         * ravenscar-thread.c (ravenscar_runtime_initializer)
1357         (has_ravenscar_runtime, get_running_thread_id)
1358         (ravenscar_thread_target::resume): Fix indentation.
1359
1360 2019-02-15  Tom Tromey  <tromey@adacore.com>
1361
1362         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1363         from ravenscar_arch_ops.
1364         (sparc_ravenscar_ops::fetch_registers)
1365         (sparc_ravenscar_ops::store_registers): Now methods.
1366         (sparc_ravenscar_prepare_to_store): Remove.
1367         (sparc_ravenscar_ops): Redefine.
1368         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1369         methods and destructor.  Remove members.
1370         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1371         (ravenscar_thread_target::store_registers)
1372         (ravenscar_thread_target::prepare_to_store): Update.
1373         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1374         Remove.
1375         (struct ppc_ravenscar_powerpc_ops): Derive from
1376         ravenscar_arch_ops.
1377         (ppc_ravenscar_powerpc_ops::fetch_registers)
1378         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1379         (ppc_ravenscar_powerpc_ops): Redefine.
1380         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1381         (ppc_ravenscar_e500_ops::fetch_registers)
1382         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1383         (ppc_ravenscar_e500_ops): Redefine.
1384         * aarch64-ravenscar-thread.c
1385         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1386         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1387         (aarch64_ravenscar_fetch_registers)
1388         (aarch64_ravenscar_store_registers): Now methods.
1389         (aarch64_ravenscar_ops): Redefine.
1390
1391 2019-02-15  Tom Tromey  <tromey@adacore.com>
1392
1393         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1394         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1395         (ravenscar_thread_target::stopped_by_watchpoint)
1396         (ravenscar_thread_target::stopped_data_address)
1397         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1398
1399 2019-02-15  Tom Tromey  <tromey@adacore.com>
1400
1401         * ravenscar-thread.c: Fix some typos.
1402
1403 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1404             Tom Tromey  <tromey@adacore.com>
1405
1406         * ada-lang.c (ada_exception_sal): Change addr_string to a
1407         std::string.
1408         (create_ada_exception_catchpoint): Update.
1409
1410 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1411             Tom Tromey  <tromey@adacore.com>
1412
1413         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1414         (bp_location_ops): Remove.
1415         (base_breakpoint_allocate_location): Update.
1416         (free_bp_location): Update.
1417         * ada-lang.c (class ada_catchpoint_location)
1418         <ada_catchpoint_location>: Remove ops parameter.
1419         (ada_catchpoint_location_dtor): Remove.
1420         (ada_catchpoint_location_ops): Remove.
1421         (allocate_location_exception): Update.
1422         * breakpoint.h (struct bp_location_ops): Remove.
1423         (class bp_location) <bp_location>: Remove bp_location_ops
1424         parameter.
1425         <~bp_location>: Add destructor.
1426         <ops>: Remove.
1427
1428 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1429             Pedro Alves  <palves@redhat.com>
1430
1431         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1432         'PATH_MAX'.
1433
1434 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1435             Samuel Thibault  <samuel.thibault@gnu.org>
1436             Thomas Schwinge  <thomas@codesourcery.com>
1437
1438         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1439         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1440
1441 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1442
1443         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1444         (check_empty): Use "const char *".
1445
1446         * gnu-nat.c (gnu_nat_target::detach): Instead of
1447         'detach_inferior (pid)' call
1448         'detach_inferior (find_inferior_pid (pid))'.
1449
1450         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1451         'nat/fork-inferior.o'.
1452         * gnu-nat.c: #include "nat/fork-inferior.h".
1453
1454         * gnu-nat.c (gnu_nat_target::detach): Instead of
1455         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1456         * gnu-nat.h: #include "inf-child.h".
1457         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1458         'i386_gnu_nat_target::fetch_registers'.
1459         (gnu_store_registers): Rename/move to
1460         'i386_gnu_nat_target::store_registers'.
1461
1462         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1463         * gnu-nat.h (mach_thread_info): New function.
1464         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1465
1466         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1467
1468 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1469
1470         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1471
1472 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1473
1474         * windows-nat.c (windows_add_thread): Add new parameter
1475         "main_thread_p" with default value set to false.  Update
1476         function documentation as well as all callers.
1477         (windows_delete_thread): Likewise.
1478         (fake_create_process): Update call to windows_add_thread.
1479         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1480         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1481         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1482         call to windows_delete_thread.
1483
1484 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1485
1486         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1487
1488 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1489
1490         * symfile.c (find_separate_debug_file): Use canonical path of
1491         sysroot with child_path instead of gdb_sysroot if it is valid.
1492
1493 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1494
1495         * symfile.c (find_separate_debug_file): Use child_path to
1496         determine if an object file is under a sysroot.
1497
1498 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1499
1500         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1501         unittests/child-path-selftests.c.
1502         * common/pathstuff.c (child_path): New function.
1503         * common/pathstuff.h (child_path): New prototype.
1504         * unittests/child-path-selftests.c: New file.
1505
1506 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1507
1508         * symfile.c (find_separate_debug_file): Look for separate debug
1509         files in debug directories under the sysroot.
1510
1511 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1512
1513         * symtab.h (struct minimal_symbol data_p): New const method.
1514         (struct minimal_symbol text_p): Likewise.
1515         * symtab.c (output_source_filename): Use file name style
1516         to print file name.
1517         (print_symbol_info): Likewise.
1518         (print_msymbol_info): Use address style to print addresses.
1519         Use function name style to print executable text symbols.
1520         (expand_symtab_containing_pc): Use data_p.
1521         (find_pc_sect_compunit_symtab): Likewise.
1522
1523 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1524
1525         * breakpoint.c (describe_other_breakpoints): Use address style
1526         to print addresses.
1527         (say_where): Likewise.
1528
1529 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1530
1531         * ada-typeprint.c (print_func_type): Print function name
1532         style to print function name.
1533         * c-typeprint.c (c_print_type_1): Likewise.
1534
1535 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1536
1537         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1538         for execve.
1539
1540 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1541
1542         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1543         type_stack.
1544
1545 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1546
1547         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1548         TYPE_CODE_REF types.
1549
1550 2019-02-08  Jim Wilson  <jimw@sifive.com>
1551
1552         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1553         (riscv_linux_fregset): New.
1554         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1555
1556 2019-02-07  Tom Tromey  <tom@tromey.com>
1557
1558         * thread.c (thread_cancel_execution_command): Update.
1559         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1560         methods.
1561         (struct thread_fsm_ops): Remove.
1562         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1563         (thread_fsm_should_stop, thread_fsm_return_value)
1564         (thread_fsm_set_finished, thread_fsm_finished_p)
1565         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1566         Don't declare.
1567         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1568         * infrun.c (clear_proceed_status_thread)
1569         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1570         (print_stop_event): Update.
1571         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1572         Add constructor.
1573         (step_command_fsm_ops): Remove.
1574         (new_step_command_fsm): Remove.
1575         (step_1): Update.
1576         (step_command_fsm::should_stop): Rename from
1577         step_command_fsm_should_stop.
1578         (step_command_fsm::clean_up): Rename from
1579         step_command_fsm_clean_up.
1580         (step_command_fsm::do_async_reply_reason): Rename from
1581         step_command_fsm_async_reply_reason.
1582         (struct until_next_fsm): Inherit from thread_fsm.  Add
1583         constructor.
1584         (until_next_fsm_ops): Remove.
1585         (new_until_next_fsm): Remove.
1586         (until_next_fsm::should_stop): Rename from
1587         until_next_fsm_should_stop.
1588         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1589         (until_next_fsm::do_async_reply_reason): Rename from
1590         until_next_fsm_async_reply_reason.
1591         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1592         constructor.  Change type of breakpoint.
1593         (finish_command_fsm_ops): Remove.
1594         (new_finish_command_fsm): Remove.
1595         (finish_command_fsm::should_stop): Rename from
1596         finish_command_fsm_should_stop.
1597         (finish_command_fsm::clean_up): Rename from
1598         finish_command_fsm_clean_up.
1599         (finish_command_fsm::return_value): Rename from
1600         finish_command_fsm_return_value.
1601         (finish_command_fsm::do_async_reply_reason): Rename from
1602         finish_command_fsm_async_reply_reason.
1603         (finish_command): Update.
1604         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1605         Add constructor.
1606         (call_thread_fsm_ops): Remove.
1607         (call_thread_fsm::call_thread_fsm): Rename from
1608         new_call_thread_fsm.
1609         (call_thread_fsm::should_stop): Rename from
1610         call_thread_fsm_should_stop.
1611         (call_thread_fsm::should_notify_stop): Rename from
1612         call_thread_fsm_should_notify_stop.
1613         (run_inferior_call, call_function_by_hand_dummy): Update.
1614         * cli/cli-interp.c (should_print_stop_to_console): Update.
1615         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1616         Add constructor.  Change type of location_breakpoint,
1617         caller_breakpoint.
1618         (until_break_fsm_ops): Remove.
1619         (new_until_break_fsm): Remove.
1620         (until_break_fsm::should_stop): Rename from
1621         until_break_fsm_should_stop.
1622         (until_break_fsm::clean_up): Rename from
1623         until_break_fsm_clean_up.
1624         (until_break_fsm::do_async_reply_reason): Rename from
1625         until_break_fsm_async_reply_reason.
1626         (until_break_command): Update.
1627         * thread-fsm.c: Remove.
1628         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1629
1630 2019-02-07  Tom Tromey  <tom@tromey.com>
1631
1632         * yy-remap.h: Add include guard.
1633         * xtensa-tdep.h: Add include guard.
1634         * xcoffread.h: Rename include guard.
1635         * varobj-iter.h: Add include guard.
1636         * tui/tui.h: Rename include guard.
1637         * tui/tui-winsource.h: Rename include guard.
1638         * tui/tui-wingeneral.h: Rename include guard.
1639         * tui/tui-windata.h: Rename include guard.
1640         * tui/tui-win.h: Rename include guard.
1641         * tui/tui-stack.h: Rename include guard.
1642         * tui/tui-source.h: Rename include guard.
1643         * tui/tui-regs.h: Rename include guard.
1644         * tui/tui-out.h: Rename include guard.
1645         * tui/tui-layout.h: Rename include guard.
1646         * tui/tui-io.h: Rename include guard.
1647         * tui/tui-hooks.h: Rename include guard.
1648         * tui/tui-file.h: Rename include guard.
1649         * tui/tui-disasm.h: Rename include guard.
1650         * tui/tui-data.h: Rename include guard.
1651         * tui/tui-command.h: Rename include guard.
1652         * tic6x-tdep.h: Add include guard.
1653         * target/waitstatus.h: Rename include guard.
1654         * target/wait.h: Rename include guard.
1655         * target/target.h: Rename include guard.
1656         * target/resume.h: Rename include guard.
1657         * target-float.h: Rename include guard.
1658         * stabsread.h: Add include guard.
1659         * rs6000-tdep.h: Add include guard.
1660         * riscv-fbsd-tdep.h: Add include guard.
1661         * regformats/regdef.h: Rename include guard.
1662         * record.h: Rename include guard.
1663         * python/python.h: Rename include guard.
1664         * python/python-internal.h: Rename include guard.
1665         * python/py-stopevent.h: Rename include guard.
1666         * python/py-ref.h: Rename include guard.
1667         * python/py-record.h: Rename include guard.
1668         * python/py-record-full.h: Rename include guard.
1669         * python/py-record-btrace.h: Rename include guard.
1670         * python/py-instruction.h: Rename include guard.
1671         * python/py-events.h: Rename include guard.
1672         * python/py-event.h: Rename include guard.
1673         * procfs.h: Add include guard.
1674         * proc-utils.h: Add include guard.
1675         * p-lang.h: Add include guard.
1676         * or1k-tdep.h: Rename include guard.
1677         * observable.h: Rename include guard.
1678         * nto-tdep.h: Rename include guard.
1679         * nat/x86-linux.h: Rename include guard.
1680         * nat/x86-linux-dregs.h: Rename include guard.
1681         * nat/x86-gcc-cpuid.h: Add include guard.
1682         * nat/x86-dregs.h: Rename include guard.
1683         * nat/x86-cpuid.h: Rename include guard.
1684         * nat/ppc-linux.h: Rename include guard.
1685         * nat/mips-linux-watch.h: Rename include guard.
1686         * nat/linux-waitpid.h: Rename include guard.
1687         * nat/linux-ptrace.h: Rename include guard.
1688         * nat/linux-procfs.h: Rename include guard.
1689         * nat/linux-osdata.h: Rename include guard.
1690         * nat/linux-nat.h: Rename include guard.
1691         * nat/linux-namespaces.h: Rename include guard.
1692         * nat/linux-btrace.h: Rename include guard.
1693         * nat/glibc_thread_db.h: Rename include guard.
1694         * nat/gdb_thread_db.h: Rename include guard.
1695         * nat/gdb_ptrace.h: Rename include guard.
1696         * nat/fork-inferior.h: Rename include guard.
1697         * nat/amd64-linux-siginfo.h: Rename include guard.
1698         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1699         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1700         * nat/aarch64-linux.h: Rename include guard.
1701         * nat/aarch64-linux-hw-point.h: Rename include guard.
1702         * mn10300-tdep.h: Add include guard.
1703         * mips-linux-tdep.h: Add include guard.
1704         * mi/mi-parse.h: Rename include guard.
1705         * mi/mi-out.h: Rename include guard.
1706         * mi/mi-main.h: Rename include guard.
1707         * mi/mi-interp.h: Rename include guard.
1708         * mi/mi-getopt.h: Rename include guard.
1709         * mi/mi-console.h: Rename include guard.
1710         * mi/mi-common.h: Rename include guard.
1711         * mi/mi-cmds.h: Rename include guard.
1712         * mi/mi-cmd-break.h: Rename include guard.
1713         * m2-lang.h: Add include guard.
1714         * location.h: Rename include guard.
1715         * linux-record.h: Rename include guard.
1716         * linux-nat.h: Add include guard.
1717         * linux-fork.h: Add include guard.
1718         * i386-darwin-tdep.h: Rename include guard.
1719         * hppa-linux-offsets.h: Add include guard.
1720         * guile/guile.h: Rename include guard.
1721         * guile/guile-internal.h: Rename include guard.
1722         * gnu-nat.h: Rename include guard.
1723         * gdb-stabs.h: Rename include guard.
1724         * frv-tdep.h: Add include guard.
1725         * f-lang.h: Add include guard.
1726         * event-loop.h: Add include guard.
1727         * darwin-nat.h: Rename include guard.
1728         * cp-abi.h: Rename include guard.
1729         * config/sparc/nm-sol2.h: Rename include guard.
1730         * config/nm-nto.h: Rename include guard.
1731         * config/nm-linux.h: Add include guard.
1732         * config/i386/nm-i386gnu.h: Rename include guard.
1733         * config/djgpp/nl_types.h: Rename include guard.
1734         * config/djgpp/langinfo.h: Rename include guard.
1735         * compile/gcc-cp-plugin.h: Add include guard.
1736         * compile/gcc-c-plugin.h: Add include guard.
1737         * compile/compile.h: Rename include guard.
1738         * compile/compile-object-run.h: Rename include guard.
1739         * compile/compile-object-load.h: Rename include guard.
1740         * compile/compile-internal.h: Rename include guard.
1741         * compile/compile-cplus.h: Rename include guard.
1742         * compile/compile-c.h: Rename include guard.
1743         * common/xml-utils.h: Rename include guard.
1744         * common/x86-xstate.h: Rename include guard.
1745         * common/version.h: Rename include guard.
1746         * common/vec.h: Rename include guard.
1747         * common/tdesc.h: Rename include guard.
1748         * common/selftest.h: Rename include guard.
1749         * common/scoped_restore.h: Rename include guard.
1750         * common/scoped_mmap.h: Rename include guard.
1751         * common/scoped_fd.h: Rename include guard.
1752         * common/safe-iterator.h: Rename include guard.
1753         * common/run-time-clock.h: Rename include guard.
1754         * common/refcounted-object.h: Rename include guard.
1755         * common/queue.h: Rename include guard.
1756         * common/ptid.h: Rename include guard.
1757         * common/print-utils.h: Rename include guard.
1758         * common/preprocessor.h: Rename include guard.
1759         * common/pathstuff.h: Rename include guard.
1760         * common/observable.h: Rename include guard.
1761         * common/netstuff.h: Rename include guard.
1762         * common/job-control.h: Rename include guard.
1763         * common/host-defs.h: Rename include guard.
1764         * common/gdb_wait.h: Rename include guard.
1765         * common/gdb_vecs.h: Rename include guard.
1766         * common/gdb_unlinker.h: Rename include guard.
1767         * common/gdb_unique_ptr.h: Rename include guard.
1768         * common/gdb_tilde_expand.h: Rename include guard.
1769         * common/gdb_sys_time.h: Rename include guard.
1770         * common/gdb_string_view.h: Rename include guard.
1771         * common/gdb_splay_tree.h: Rename include guard.
1772         * common/gdb_setjmp.h: Rename include guard.
1773         * common/gdb_ref_ptr.h: Rename include guard.
1774         * common/gdb_optional.h: Rename include guard.
1775         * common/gdb_locale.h: Rename include guard.
1776         * common/gdb_assert.h: Rename include guard.
1777         * common/filtered-iterator.h: Rename include guard.
1778         * common/filestuff.h: Rename include guard.
1779         * common/fileio.h: Rename include guard.
1780         * common/environ.h: Rename include guard.
1781         * common/common-utils.h: Rename include guard.
1782         * common/common-types.h: Rename include guard.
1783         * common/common-regcache.h: Rename include guard.
1784         * common/common-inferior.h: Rename include guard.
1785         * common/common-gdbthread.h: Rename include guard.
1786         * common/common-exceptions.h: Rename include guard.
1787         * common/common-defs.h: Rename include guard.
1788         * common/common-debug.h: Rename include guard.
1789         * common/cleanups.h: Rename include guard.
1790         * common/buffer.h: Rename include guard.
1791         * common/btrace-common.h: Rename include guard.
1792         * common/break-common.h: Rename include guard.
1793         * cli/cli-utils.h: Rename include guard.
1794         * cli/cli-style.h: Rename include guard.
1795         * cli/cli-setshow.h: Rename include guard.
1796         * cli/cli-script.h: Rename include guard.
1797         * cli/cli-interp.h: Rename include guard.
1798         * cli/cli-decode.h: Rename include guard.
1799         * cli/cli-cmds.h: Rename include guard.
1800         * charset-list.h: Add include guard.
1801         * buildsym-legacy.h: Rename include guard.
1802         * bfin-tdep.h: Add include guard.
1803         * ax.h: Rename include guard.
1804         * arm-linux-tdep.h: Add include guard.
1805         * arm-fbsd-tdep.h: Add include guard.
1806         * arch/xtensa.h: Rename include guard.
1807         * arch/tic6x.h: Add include guard.
1808         * arch/i386.h: Add include guard.
1809         * arch/arm.h: Rename include guard.
1810         * arch/arm-linux.h: Rename include guard.
1811         * arch/arm-get-next-pcs.h: Rename include guard.
1812         * arch/amd64.h: Add include guard.
1813         * arch/aarch64-insn.h: Rename include guard.
1814         * arch-utils.h: Rename include guard.
1815         * annotate.h: Add include guard.
1816         * amd64-darwin-tdep.h: Rename include guard.
1817         * aarch64-linux-tdep.h: Add include guard.
1818         * aarch64-fbsd-tdep.h: Add include guard.
1819         * aarch32-linux-nat.h: Add include guard.
1820
1821 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1822
1823         * macrotab.c (macro_define_internal): New function that
1824         factorizes macro_define_object_internal and macro_define_function
1825         code.
1826         (macro_define_object_internal): Use macro_define_internal.
1827         (macro_define_function): Likewise.
1828
1829 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1830
1831         * macrocmd.c (extract_identifier): Return
1832         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1833         callers.
1834
1835 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1836
1837         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1838
1839 2019-02-05  Tom Tromey  <tom@tromey.com>
1840
1841         * target.c (target_stack::unpush): Move assertion earlier.
1842
1843 2019-01-30  Tom Tromey  <tom@tromey.com>
1844
1845         PR python/23615:
1846         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1847         (gdbpy_parse_and_eval): Likewise.
1848         * python/python-internal.h (gdbpy_allow_threads): New class.
1849
1850 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1851
1852         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1853         (aarch64_fbsd_fpregmap): Move earlier.
1854         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1855         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1856         instead of individual calls to trad_frame_set_reg_addr.
1857         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1858         earlier.
1859         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1860         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1861         instead of individual calls to trad_frame_set_reg_addr.
1862
1863 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1864
1865         * CONTRIBUTE: Replace contribution list with wiki link.
1866
1867 2019-01-25  Tom Tromey  <tom@tromey.com>
1868
1869         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1870
1871 2019-01-25  Tom Tromey  <tom@tromey.com>
1872
1873         * xtensa-linux-nat.c: Fix common/ includes.
1874         * xml-support.h: Fix common/ includes.
1875         * xml-support.c: Fix common/ includes.
1876         * x86-linux-nat.c: Fix common/ includes.
1877         * windows-nat.c: Fix common/ includes.
1878         * varobj.h: Fix common/ includes.
1879         * varobj.c: Fix common/ includes.
1880         * value.c: Fix common/ includes.
1881         * valops.c: Fix common/ includes.
1882         * utils.c: Fix common/ includes.
1883         * unittests/xml-utils-selftests.c: Fix common/ includes.
1884         * unittests/utils-selftests.c: Fix common/ includes.
1885         * unittests/unpack-selftests.c: Fix common/ includes.
1886         * unittests/tracepoint-selftests.c: Fix common/ includes.
1887         * unittests/style-selftests.c: Fix common/ includes.
1888         * unittests/string_view-selftests.c: Fix common/ includes.
1889         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1890         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1891         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1892         * unittests/rsp-low-selftests.c: Fix common/ includes.
1893         * unittests/parse-connection-spec-selftests.c: Fix common/
1894         includes.
1895         * unittests/optional-selftests.c: Fix common/ includes.
1896         * unittests/offset-type-selftests.c: Fix common/ includes.
1897         * unittests/observable-selftests.c: Fix common/ includes.
1898         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1899         * unittests/memrange-selftests.c: Fix common/ includes.
1900         * unittests/memory-map-selftests.c: Fix common/ includes.
1901         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1902         * unittests/function-view-selftests.c: Fix common/ includes.
1903         * unittests/environ-selftests.c: Fix common/ includes.
1904         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1905         * unittests/common-utils-selftests.c: Fix common/ includes.
1906         * unittests/cli-utils-selftests.c: Fix common/ includes.
1907         * unittests/array-view-selftests.c: Fix common/ includes.
1908         * ui-file.c: Fix common/ includes.
1909         * tui/tui-io.c: Fix common/ includes.
1910         * tracepoint.h: Fix common/ includes.
1911         * tracepoint.c: Fix common/ includes.
1912         * tracefile-tfile.c: Fix common/ includes.
1913         * top.h: Fix common/ includes.
1914         * top.c: Fix common/ includes.
1915         * thread.c: Fix common/ includes.
1916         * target/waitstatus.h: Fix common/ includes.
1917         * target/waitstatus.c: Fix common/ includes.
1918         * target.h: Fix common/ includes.
1919         * target.c: Fix common/ includes.
1920         * target-memory.c: Fix common/ includes.
1921         * target-descriptions.c: Fix common/ includes.
1922         * symtab.h: Fix common/ includes.
1923         * symfile.c: Fix common/ includes.
1924         * stap-probe.c: Fix common/ includes.
1925         * spu-linux-nat.c: Fix common/ includes.
1926         * sparc-nat.c: Fix common/ includes.
1927         * source.c: Fix common/ includes.
1928         * solib.c: Fix common/ includes.
1929         * solib-target.c: Fix common/ includes.
1930         * ser-unix.c: Fix common/ includes.
1931         * ser-tcp.c: Fix common/ includes.
1932         * ser-pipe.c: Fix common/ includes.
1933         * ser-base.c: Fix common/ includes.
1934         * selftest-arch.c: Fix common/ includes.
1935         * s12z-tdep.c: Fix common/ includes.
1936         * rust-exp.y: Fix common/ includes.
1937         * rs6000-aix-tdep.c: Fix common/ includes.
1938         * riscv-tdep.c: Fix common/ includes.
1939         * remote.c: Fix common/ includes.
1940         * remote-notif.h: Fix common/ includes.
1941         * remote-fileio.h: Fix common/ includes.
1942         * remote-fileio.c: Fix common/ includes.
1943         * regcache.h: Fix common/ includes.
1944         * regcache.c: Fix common/ includes.
1945         * record-btrace.c: Fix common/ includes.
1946         * python/python.c: Fix common/ includes.
1947         * python/py-type.c: Fix common/ includes.
1948         * python/py-inferior.c: Fix common/ includes.
1949         * progspace.h: Fix common/ includes.
1950         * producer.c: Fix common/ includes.
1951         * procfs.c: Fix common/ includes.
1952         * proc-api.c: Fix common/ includes.
1953         * printcmd.c: Fix common/ includes.
1954         * ppc-linux-nat.c: Fix common/ includes.
1955         * parser-defs.h: Fix common/ includes.
1956         * osdata.c: Fix common/ includes.
1957         * obsd-nat.c: Fix common/ includes.
1958         * nat/x86-linux.c: Fix common/ includes.
1959         * nat/x86-linux-dregs.c: Fix common/ includes.
1960         * nat/x86-dregs.h: Fix common/ includes.
1961         * nat/x86-dregs.c: Fix common/ includes.
1962         * nat/ppc-linux.c: Fix common/ includes.
1963         * nat/mips-linux-watch.h: Fix common/ includes.
1964         * nat/mips-linux-watch.c: Fix common/ includes.
1965         * nat/linux-waitpid.c: Fix common/ includes.
1966         * nat/linux-ptrace.h: Fix common/ includes.
1967         * nat/linux-ptrace.c: Fix common/ includes.
1968         * nat/linux-procfs.c: Fix common/ includes.
1969         * nat/linux-personality.c: Fix common/ includes.
1970         * nat/linux-osdata.c: Fix common/ includes.
1971         * nat/linux-namespaces.c: Fix common/ includes.
1972         * nat/linux-btrace.h: Fix common/ includes.
1973         * nat/linux-btrace.c: Fix common/ includes.
1974         * nat/fork-inferior.c: Fix common/ includes.
1975         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1976         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1977         * nat/aarch64-linux.c: Fix common/ includes.
1978         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1979         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1980         * namespace.h: Fix common/ includes.
1981         * mips-linux-tdep.c: Fix common/ includes.
1982         * minsyms.c: Fix common/ includes.
1983         * mi/mi-parse.h: Fix common/ includes.
1984         * mi/mi-main.c: Fix common/ includes.
1985         * mi/mi-cmd-env.c: Fix common/ includes.
1986         * memrange.h: Fix common/ includes.
1987         * memattr.c: Fix common/ includes.
1988         * maint.h: Fix common/ includes.
1989         * maint.c: Fix common/ includes.
1990         * main.c: Fix common/ includes.
1991         * machoread.c: Fix common/ includes.
1992         * location.c: Fix common/ includes.
1993         * linux-thread-db.c: Fix common/ includes.
1994         * linux-nat.c: Fix common/ includes.
1995         * linux-fork.c: Fix common/ includes.
1996         * inline-frame.c: Fix common/ includes.
1997         * infrun.c: Fix common/ includes.
1998         * inflow.c: Fix common/ includes.
1999         * inferior.h: Fix common/ includes.
2000         * inferior.c: Fix common/ includes.
2001         * infcmd.c: Fix common/ includes.
2002         * inf-ptrace.c: Fix common/ includes.
2003         * inf-child.c: Fix common/ includes.
2004         * ia64-linux-nat.c: Fix common/ includes.
2005         * i387-tdep.c: Fix common/ includes.
2006         * i386-tdep.c: Fix common/ includes.
2007         * i386-linux-tdep.c: Fix common/ includes.
2008         * i386-linux-nat.c: Fix common/ includes.
2009         * i386-go32-tdep.c: Fix common/ includes.
2010         * i386-fbsd-tdep.c: Fix common/ includes.
2011         * i386-fbsd-nat.c: Fix common/ includes.
2012         * guile/scm-type.c: Fix common/ includes.
2013         * guile/guile.c: Fix common/ includes.
2014         * go32-nat.c: Fix common/ includes.
2015         * gnu-nat.c: Fix common/ includes.
2016         * gdbthread.h: Fix common/ includes.
2017         * gdbarch-selftests.c: Fix common/ includes.
2018         * gdb_usleep.c: Fix common/ includes.
2019         * gdb_select.h: Fix common/ includes.
2020         * gdb_bfd.c: Fix common/ includes.
2021         * gcore.c: Fix common/ includes.
2022         * fork-child.c: Fix common/ includes.
2023         * findvar.c: Fix common/ includes.
2024         * fbsd-nat.c: Fix common/ includes.
2025         * event-top.c: Fix common/ includes.
2026         * event-loop.c: Fix common/ includes.
2027         * dwarf2read.c: Fix common/ includes.
2028         * dwarf2loc.c: Fix common/ includes.
2029         * dwarf2-frame.c: Fix common/ includes.
2030         * dwarf-index-cache.c: Fix common/ includes.
2031         * dtrace-probe.c: Fix common/ includes.
2032         * disasm-selftests.c: Fix common/ includes.
2033         * defs.h: Fix common/ includes.
2034         * csky-tdep.c: Fix common/ includes.
2035         * cp-valprint.c: Fix common/ includes.
2036         * cp-support.h: Fix common/ includes.
2037         * cp-support.c: Fix common/ includes.
2038         * corelow.c: Fix common/ includes.
2039         * completer.h: Fix common/ includes.
2040         * completer.c: Fix common/ includes.
2041         * compile/compile.c: Fix common/ includes.
2042         * compile/compile-loc2c.c: Fix common/ includes.
2043         * compile/compile-cplus-types.c: Fix common/ includes.
2044         * compile/compile-cplus-symbols.c: Fix common/ includes.
2045         * command.h: Fix common/ includes.
2046         * cli/cli-dump.c: Fix common/ includes.
2047         * cli/cli-cmds.c: Fix common/ includes.
2048         * charset.c: Fix common/ includes.
2049         * build-id.c: Fix common/ includes.
2050         * btrace.h: Fix common/ includes.
2051         * btrace.c: Fix common/ includes.
2052         * breakpoint.h: Fix common/ includes.
2053         * breakpoint.c: Fix common/ includes.
2054         * ax.h:
2055         (enum agent_op): Fix common/ includes.
2056         * ax-general.c (struct aop_map): Fix common/ includes.
2057         * ax-gdb.c: Fix common/ includes.
2058         * auxv.c: Fix common/ includes.
2059         * auto-load.c: Fix common/ includes.
2060         * arm-tdep.c: Fix common/ includes.
2061         * arch/riscv.c: Fix common/ includes.
2062         * arch/ppc-linux-common.c: Fix common/ includes.
2063         * arch/i386.c: Fix common/ includes.
2064         * arch/arm.c: Fix common/ includes.
2065         * arch/arm-linux.c: Fix common/ includes.
2066         * arch/arm-get-next-pcs.c: Fix common/ includes.
2067         * arch/amd64.c: Fix common/ includes.
2068         * arch/aarch64.c: Fix common/ includes.
2069         * arch/aarch64-insn.c: Fix common/ includes.
2070         * arch-utils.c: Fix common/ includes.
2071         * amd64-windows-tdep.c: Fix common/ includes.
2072         * amd64-tdep.c: Fix common/ includes.
2073         * amd64-sol2-tdep.c: Fix common/ includes.
2074         * amd64-obsd-tdep.c: Fix common/ includes.
2075         * amd64-nbsd-tdep.c: Fix common/ includes.
2076         * amd64-linux-tdep.c: Fix common/ includes.
2077         * amd64-linux-nat.c: Fix common/ includes.
2078         * amd64-fbsd-tdep.c: Fix common/ includes.
2079         * amd64-fbsd-nat.c: Fix common/ includes.
2080         * amd64-dicos-tdep.c: Fix common/ includes.
2081         * amd64-darwin-tdep.c: Fix common/ includes.
2082         * agent.c: Fix common/ includes.
2083         * ada-lang.h: Fix common/ includes.
2084         * ada-lang.c: Fix common/ includes.
2085         * aarch64-tdep.c: Fix common/ includes.
2086
2087 2019-01-25  Tom Tromey  <tom@tromey.com>
2088
2089         * common/create-version.sh: Use common/version.h.
2090
2091 2019-01-24  Pedro Alves  <palves@redhat.com>
2092
2093         * infrun.c (signal_stop, signal_print, signal_program)
2094         (signal_catch, signal_pass): Now arrays instead of pointers.
2095         (update_signals_program_target, do_target_resume)
2096         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2097         * linux-nat.c (linux_nat_target::pass_signals)
2098         (linux_nat_target::create_inferior, linux_nat_target::attach):
2099         Adjust.
2100         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2101         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2102         * procfs.c (procfs_target::pass_signals): Adjust.
2103         * record-full.c (record_full_target::resume): Adjust.
2104         * remote.c (remote_target::pass_signals)
2105         (remote_target::program_signals): Adjust.
2106         * target-debug.h (target_debug_print_signals): Now takes a
2107         gdb::array_view as parameter.  Adjust.
2108         * target.h (target_ops) <pass_signals, program_signals>: Replace
2109         pointer and length parameters with gdb::array_view.
2110         (target_pass_signals, target_program_signals): Likewise.
2111         * target-delegates.c: Regenerate.
2112
2113 2019-01-24  Pedro Alves  <palves@redhat.com>
2114
2115         * common/forward-scope-exit.h
2116         (forward_scope_exit::forward_scope_exit): Pass arguments to
2117         m_bind_function directly, instead of creating a std::bind and
2118         copying that.
2119
2120 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2121
2122         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2123         for static members.
2124         (pass_in_v_vfp_candidate): Likewise.
2125
2126 2019-01-23  Tom Tromey  <tom@tromey.com>
2127             Pedro Alves  <palves@redhat.com>
2128
2129         * regcache.c (class regcache_invalidator): Remove.
2130         (regcache::raw_write): Use make_scope_exit.
2131
2132 2019-01-23  Tom Tromey  <tom@tromey.com>
2133
2134         * ui-out.h (class ui_out_emit_type): Update comment.
2135
2136 2019-01-23  Tom Tromey  <tom@tromey.com>
2137
2138         * infrun.c (fetch_inferior_event): Update comment.
2139
2140 2019-01-23  Tom Tromey  <tom@tromey.com>
2141             Pedro Alves  <palves@redhat.com>
2142
2143         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2144         parameter.
2145         (fetch_inferior_event): Use SCOPE_EXIT.
2146
2147
2148 2019-01-23  Tom Tromey  <tom@tromey.com>
2149             Pedro Alves  <palves@redhat.com>
2150
2151         * infrun.c (disable_thread_events): Delete.
2152         (stop_all_threads): Use SCOPE_EXIT.
2153
2154 2019-01-23  Tom Tromey  <tom@tromey.com>
2155             Pedro Alves  <palves@redhat.com>
2156
2157         * symfile.c: Include forward-scope-exit.h.
2158         (clear_symtab_users_cleanup): Replace forward declaration with
2159         a FORWARD_SCOPE_EXIT.
2160         (syms_from_objfile_1): Use the forward_scope_exit and
2161         gdb::optional instead of cleanup_function.
2162         (reread_symbols): Use the forward_scope_exit instead of
2163         cleanup_function.
2164         (clear_symtab_users_cleanup): Remove function.
2165
2166 2019-01-23  Tom Tromey  <tom@tromey.com>
2167             Pedro Alves  <palves@redhat.com>
2168
2169         * linux-nat.c: Include scope-exit.h.
2170         (cleanup_target_stop): Remove.
2171         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2172         SCOPE_EXIT.
2173
2174 2019-01-23  Tom Tromey  <tom@tromey.com>
2175             Pedro Alves  <palves@redhat.com>
2176
2177         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2178         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2179
2180 2019-01-23  Tom Tromey  <tom@tromey.com>
2181             Andrew Burgess  <andrew.burgess@embecosm.com>
2182             Pedro Alves  <palves@redhat.com>
2183
2184         * infrun.c (fetch_inferior_event): Use scope_exit.
2185         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2186         * top.c (execute_command): Use scope_exit.
2187         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2188         * utils.c (do_bpstat_clear_actions_cleanup)
2189         (make_bpstat_clear_actions_cleanup): Remove.
2190
2191 2019-01-23  Tom Tromey  <tom@tromey.com>
2192             Pedro Alves  <palves@redhat.com>
2193
2194         * infrun.c: Include "common/scope-exit.h"
2195         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2196         (wait_for_inferior): Use SCOPE_EXIT.
2197         (fetch_inferior_event): Use scope_exit.
2198
2199 2019-01-23  Tom Tromey  <tom@tromey.com>
2200             Pedro Alves  <palves@redhat.com>
2201
2202         * breakpoint.c (create_breakpoint): Remove cleanup.
2203
2204 2019-01-23  Tom Tromey  <tom@tromey.com>
2205             Andrew Burgess  <andrew.burgess@embecosm.com>
2206             Pedro Alves  <palves@redhat.com>
2207
2208 2019-01-23  Pedro Alves  <palves@redhat.com>
2209
2210         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2211
2212 2019-01-23  Pedro Alves  <palves@redhat.com>
2213             Andrew Burgess  <andrew.burgess@embecosm.com>
2214
2215         * gdbthread.h: Include "common/forward-scope-exit.h".
2216         (scoped_finish_thread_state): Redefine custom class in terms of
2217         forward_scope_exit.
2218
2219 2019-01-23  Pedro Alves  <palves@redhat.com>
2220             Andrew Burgess  <andrew.burgess@embecosm.com>
2221
2222         * common/forward-scope-exit.h: New file.
2223
2224 2019-01-23  Pedro Alves  <palves@redhat.com>
2225             Andrew Burgess  <andrew.burgess@embecosm.com>
2226             Tom Tromey  <tom@tromey.com>
2227
2228         * common/scope-exit.h: New file.
2229
2230 2019-01-23  Pedro Alves  <palves@redhat.com>
2231
2232         * common/preprocessor.h (ESC): Rename to ...
2233         (ESC_PARENS): ... this.
2234         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2235         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2236
2237 2019-01-23  Tom Tromey  <tom@tromey.com>
2238
2239         * language.h (class scoped_switch_to_sym_language_if_auto):
2240         Initialize m_lang in both cases.
2241
2242 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2243
2244         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2245         with XCNEW.
2246
2247 2019-01-22  Tom Tromey  <tom@tromey.com>
2248
2249         * corelow.c: Do not include sys/file.h.
2250
2251 2019-01-22  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-wingeneral.h: Include gdb_curses.h.
2254
2255 2019-01-22  Tom Tromey  <tom@tromey.com>
2256
2257         * source-cache.h (class source_cache) <get_source_lines,
2258         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2259
2260 2019-01-22  Tom Tromey  <tom@tromey.com>
2261
2262         * remote-fileio.h (struct remote_target): Declare.
2263
2264 2019-01-22  Tom Tromey  <tom@tromey.com>
2265
2266         * python/py-arch.c: Do not include py-ref.h.
2267         * python/py-bpevent.c: Do not include py-ref.h.
2268         * python/py-cmd.c: Do not include py-ref.h.
2269         * python/py-continueevent.c: Do not include py-ref.h.
2270         * python/py-event.h: Do not include py-ref.h.
2271         * python/py-evtregistry.c: Do not include py-ref.h.
2272         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2273         * python/py-frame.c: Do not include py-ref.h.
2274         * python/py-framefilter.c: Do not include py-ref.h.
2275         * python/py-function.c: Do not include py-ref.h.
2276         * python/py-infevents.c: Do not include py-ref.h.
2277         * python/py-linetable.c: Do not include py-ref.h.
2278         * python/py-objfile.c: Do not include py-ref.h.
2279         * python/py-param.c: Do not include py-ref.h.
2280         * python/py-prettyprint.c: Do not include py-ref.h.
2281         * python/py-progspace.c: Do not include py-ref.h.
2282         * python/py-symbol.c: Do not include py-ref.h.
2283         * python/py-symtab.c: Do not include py-ref.h.
2284         * python/py-type.c: Do not include py-ref.h.
2285         * python/py-unwind.c: Do not include py-ref.h.
2286         * python/py-utils.c: Do not include py-ref.h.
2287         * python/py-value.c: Do not include py-ref.h.
2288         * python/py-varobj.c: Do not include py-ref.h.
2289         * python/py-xmethods.c: Do not include py-ref.h.
2290         * python/python.c: Do not include py-ref.h.
2291         * varobj.c: Do not include py-ref.h.
2292
2293 2019-01-22  Tom Tromey  <tom@tromey.com>
2294
2295         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2296         keyword for bcache.
2297
2298 2019-01-22  Tom Tromey  <tom@tromey.com>
2299
2300         * compile/compile-cplus-types.c: Remove a comment by #include.
2301
2302 2019-01-22  Tom Tromey  <tom@tromey.com>
2303
2304         * compile/gcc-c-plugin.h: Include compile-internal.h.
2305
2306 2019-01-22  Tom Tromey  <tom@tromey.com>
2307
2308         * stabsread.c (EXTERN): Do not define.
2309         (symnum, next_symbol_text_func, processing_gcc_compilation)
2310         (within_function, global_sym_chain, global_stabs)
2311         (previous_stab_code, this_object_header_files)
2312         (n_this_object_header_files)
2313         (n_allocated_this_object_header_files): Define.
2314         * stabsread.h (EXTERN): Never define.  Use "extern".
2315
2316 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2317
2318         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2319         history_value.
2320
2321 2019-01-21  Tom Tromey  <tom@tromey.com>
2322
2323         * ui-out.c: Fix includes.
2324         * tui/tui-source.c: Fix includes.
2325         * target.c: Fix includes.
2326         * remote.c: Fix includes.
2327         * regcache.c: Fix includes.
2328         * python/py-block.c: Fix includes.
2329         * printcmd.c: Fix includes.
2330         * or1k-tdep.c: Fix includes.
2331         * mi/mi-main.c: Fix includes.
2332         * m32r-tdep.c: Fix includes.
2333         * csky-tdep.c: Fix includes.
2334         * compile/compile-cplus-types.c: Fix includes.
2335         * cli/cli-interp.c: Fix includes.
2336
2337 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2338
2339         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2340         for padding.
2341
2342 2019-01-16  Tom Tromey  <tom@tromey.com>
2343
2344         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2345         earlier.
2346         (struct objfile) <msymbols_range>: Move from top level.
2347         <msymbols>: New method.
2348         (class objfile_msymbols): Remove.
2349         * symtab.c (default_collect_symbol_completion_matches_break_on):
2350         Update.
2351         * symmisc.c (dump_msymbols): Update.
2352         * stabsread.c (scan_file_globals): Update.
2353         * objc-lang.c (info_selectors_command, info_classes_command)
2354         (find_methods): Update.
2355         * minsyms.c (find_solib_trampoline_target): Update.
2356         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2357         * coffread.c (coff_symfile_read): Update.
2358         * ada-lang.c (ada_lookup_simple_minsym)
2359         (ada_collect_symbol_completion_matches): Update.
2360
2361 2019-01-16  Tom Tromey  <tom@tromey.com>
2362
2363         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2364         type.  Remove no-argument constructor.
2365         <iterator::operator++>: Simplify.
2366         <begin>: Update.
2367         <end>: Use minimal_symbol_count.
2368
2369 2019-01-16  Tom Tromey  <tom@tromey.com>
2370
2371         * objfiles.h (struct objfile) <psymtabs>: New method.
2372         (class objfile_psymtabs): Remove.
2373         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2374         typedef.
2375         <range>: New method.
2376         (require_partial_symbols): Change return type.
2377         * psymtab.c (require_partial_symbols)
2378         (psym_expand_symtabs_matching): Update.
2379         * mdebugread.c (parse_partial_symbols): Update.
2380         * dbxread.c (dbx_end_psymtab): Update.
2381
2382 2019-01-15  Tom Tromey  <tom@tromey.com>
2383
2384         * symtab.c (lookup_objfile_from_block)
2385         (lookup_symbol_in_objfile_symtabs)
2386         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2387         (find_line_symtab, info_sources_command)
2388         (default_collect_symbol_completion_matches_break_on)
2389         (make_source_files_completion_list): Update.
2390         * symmisc.c (print_objfile_statistics, dump_objfile)
2391         (maintenance_print_symbols, maintenance_info_symtabs)
2392         (maintenance_check_symtabs, maintenance_info_line_tables):
2393         Update.
2394         * source.c (select_source_symtab)
2395         (forget_cached_source_info_for_objfile): Update.
2396         * objfiles.h (class objfile_compunits): Remove.
2397         (struct objfile) <compunits_range>: New typedef.
2398         (compunits): New method.
2399         * objfiles.c (objfile_relocate1): Update.
2400         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2401         * maint.c (count_symtabs_and_blocks): Update.
2402         * linespec.c (iterate_over_all_matching_symtabs): Update.
2403         * cp-support.c (add_symbol_overload_list_qualified): Update.
2404         * coffread.c (coff_symtab_read): Update.
2405         * ada-lang.c (add_nonlocal_symbols)
2406         (ada_collect_symbol_completion_matches)
2407         (ada_add_global_exceptions): Update.
2408
2409 2019-01-15  Tom Tromey  <tom@tromey.com>
2410
2411         * progspace.h (program_space) <objfiles_safe_range>: New
2412         typedef.
2413         <objfiles_safe>: New method.
2414         * objfiles.h (class all_objfiles_safe): Remove.
2415         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2416         * jit.c (jit_inferior_exit_hook): Update.
2417
2418 2019-01-17  Tom Tromey  <tom@tromey.com>
2419
2420         * progspace.h (program_space) <objfiles_range>: New typedef.
2421         <objfiles>: New method.
2422         <objfiles_head>: Rename from objfiles.
2423         (object_files): Update.
2424         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2425         * guile/scm-pretty-print.c
2426         (ppscm_find_pretty_printer_from_objfiles): Update.
2427         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2428         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2429         Update.
2430         * python/py-progspace.c (pspy_get_objfiles): Update.
2431         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2432         Update.
2433         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2434         (objfpy_lookup_objfile_by_build_id): Update.
2435         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2436         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2437         Update.
2438         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2439         (expand_symtab_containing_pc, lookup_objfile_from_block)
2440         (lookup_static_symbol, basic_lookup_transparent_type)
2441         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2442         (find_line_symtab, info_sources_command)
2443         (default_collect_symbol_completion_matches_break_on)
2444         (make_source_files_completion_list, find_main_name): Update.
2445         * symmisc.c (print_symbol_bcache_statistics)
2446         (print_objfile_statistics, maintenance_print_symbols)
2447         (maintenance_print_msymbols, maintenance_print_objfiles)
2448         (maintenance_info_symtabs, maintenance_check_symtabs)
2449         (maintenance_expand_symtabs, maintenance_info_line_tables):
2450         Update.
2451         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2452         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2453         (map_overlay_command, unmap_overlay_command)
2454         (simple_overlay_update, expand_symtabs_matching)
2455         (map_symbol_filenames): Update.
2456         * symfile-debug.c (set_debug_symfile): Update.
2457         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2458         Update.
2459         * source.c (select_source_symtab, forget_cached_source_info):
2460         Update.
2461         * solib.c (solib_read_symbols): Update.
2462         * solib-spu.c (append_ocl_sos): Update.
2463         * psymtab.c (maintenance_print_psymbols)
2464         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2465         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2466         * printcmd.c (info_symbol_command): Update.
2467         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2468         Update.
2469         * objfiles.h (class all_objfiles): Remove.
2470         * objfiles.c (have_partial_symbols, have_full_symbols)
2471         (have_minimal_symbols, qsort_cmp, update_section_map)
2472         (shared_objfile_contains_address_p)
2473         (default_iterate_over_objfiles_in_search_order): Update.
2474         * objc-lang.c (info_selectors_command, info_classes_command)
2475         (find_methods): Update.
2476         * minsyms.c (find_solib_trampoline_target): Update.
2477         * maint.c (maintenance_info_sections)
2478         (maintenance_translate_address, count_symtabs_and_blocks):
2479         Update.
2480         * main.c (captured_main_1): Update.
2481         * linux-thread-db.c (try_thread_db_load_from_pdir)
2482         (has_libpthread): Update.
2483         * linespec.c (iterate_over_all_matching_symtabs)
2484         (search_minsyms_for_name): Update.
2485         * jit.c (jit_find_objf_with_entry_addr): Update.
2486         * hppa-tdep.c (find_unwind_entry)
2487         (hppa_lookup_stub_minimal_symbol): Update.
2488         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2489         Update.
2490         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2491         (elf_gnu_ifunc_resolve_by_got): Update.
2492         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2493         * dwarf-index-write.c (save_gdb_index_command): Update.
2494         * cp-support.c (add_symbol_overload_list_qualified): Update.
2495         * breakpoint.c (create_overlay_event_breakpoint)
2496         (create_longjmp_master_breakpoint)
2497         (create_std_terminate_master_breakpoint)
2498         (create_exception_master_breakpoint): Update.
2499         * blockframe.c (find_pc_partial_function): Update.
2500         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2501         (ada_collect_symbol_completion_matches)
2502         (ada_add_global_exceptions): Update.
2503
2504 2019-01-17  Tom Tromey  <tom@tromey.com>
2505
2506         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2507         declare VEC.
2508         (solib_target_parse_libraries): Change return type.
2509         (library_list_start_segment, library_list_start_section)
2510         (library_list_end_library, library_list_start_library); Update.
2511         (solib_target_free_library_list): Remove.
2512         (solib_target_parse_libraries): Remove cleanup.  Change return
2513         type.
2514         (solib_target_current_sos): Update.
2515
2516 2019-01-17  Tom Tromey  <tromey@bapiya>
2517
2518         * valprint.c: Replace "the the" with "the".
2519         * symtab.c: Replace "the the" with "the".
2520         * solib.c: Replace "the the" with "the".
2521         * solib-dsbt.c: Replace "the the" with "the".
2522         * linespec.c: Replace "the the" with "the".
2523         * dwarf2loc.h: Replace "the the" with "the".
2524         * amd64-windows-tdep.c: Replace "the the" with "the".
2525         * aarch64-tdep.c: Replace "the the" with "the".
2526
2527 2019-01-16  Keith Seitz  <keiths@redhat.com>
2528
2529         PR gdb/23773
2530         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2531         <builder>: Rename to ..
2532         <m_builder>: ... this and make private.
2533         (dwarf2_cu::get_builder): New method.  Change all users of
2534         `builder' to use this method.
2535         (dwarf2_start_symtab): Move to ...
2536         (dwarf2_cu::start_symtab): ... here.  Update all callers
2537         (setup_type_unit_groups): Move to ...
2538         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2539         callers.
2540         (dwarf2_cu::reset_builder): New method.
2541         (process_full_compunit, process_full_type_unit): Use
2542         dwarf2_cu::reset_builder.
2543         (follow_die_offset): Record the ancestor CU if it is different
2544         from the followed DIE's CU.
2545         (follow_die_sig_1): Likewise.
2546
2547 2019-01-15  Tom Tromey  <tom@tromey.com>
2548
2549         * remote.c (class remote_state) <buf>: Now a char_vector.
2550         <buf_size>: Remove.
2551         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2552         parameter.
2553         (remote_target::getpkt_or_notif_sane_1)
2554         (remote_target::getpkt_sane)
2555         (remote_target::getpkt_or_notif_sane): Likewise.
2556         (class remote_target) <putpkt>: New overload.
2557         (remote_target::read_frame): Change type of "buf_p".  Remove
2558         sizeof_p parameter.
2559         (packet_ok): New overload.
2560         (packet_check_result): New overload.
2561         Update all uses.
2562
2563 2019-01-14  Tom Tromey  <tom@tromey.com>
2564
2565         * remote-notif.c (handle_notification, remote_notif_ack)
2566         (remote_notif_parse): Make "buf" const.
2567         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2568         const.
2569         (remote_notif_parse, remote_notif_ack, handle_notification):
2570         Likewise.
2571         * remote.c (remote_notif_stop_parse): Make "buf" const.
2572         (remote_target::remote_parse_stop_reply): Make "buf" const.
2573         (remote_notif_stop_ack): Make "buf" const.
2574
2575 2019-01-14  Tom Tromey  <tom@tromey.com>
2576
2577         * remote.c (remote_console_output): Make parameter const.
2578
2579 2019-01-14  Tom Tromey  <tom@tromey.com>
2580
2581         * target-debug.h (target_debug_print_signals): Constify.
2582         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2583         * procfs.c (procfs_target::pass_signals): Update.
2584         * linux-nat.c (linux_nat_target::pass_signals): Update.
2585         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2586         * target-delegates.c: Rebuild.
2587         * remote.c (remote_target::program_signals): Update.
2588         (remote_target::pass_signals): Update.
2589         * target.c (target_pass_signals): Constify argument.
2590         (target_program_signals): Likewise.
2591         * target.h (struct target_ops) <pass_signals, program_signals>:
2592         Constify argument.
2593         (target_pass_signals, target_program_signals): Constify argument.
2594
2595 2019-01-14  Tom Tromey  <tom@tromey.com>
2596
2597         PR tui/28819:
2598         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2599
2600 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2601
2602         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2603         field.
2604         * rs6000-tdep.c: Include reggroups.h.
2605         (IS_V_ALIAS_PSEUDOREG): Define.
2606         (rs6000_register_name): Return names for the "vX" aliases.
2607         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2608         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2609         aliases.  Call default_register_reggroup_p for all other
2610         pseudo-registers.
2611         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2612         New functions.
2613         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2614         Handle "vX" aliases.
2615         (v_alias_pseudo_register_collect): New function.
2616         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2617         (rs6000_gdbarch_init): Initialize "vX" aliases as
2618         pseudo-registers.  Restore registration of
2619         rs6000_pseudo_register_reggroup_p with
2620         set_tdesc_pseudo_register_reggroup_p.
2621
2622 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2623
2624         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2625         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2626         set_gdbarch_num_pseudo_regs.
2627
2628 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2629
2630         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2631         Remove arg prefixname, add do_set and do_show.
2632         Add member functions set_list and show_list.
2633         * cli/cli-style.c (class cli_style_option): Update accordingly.
2634         (style_set_list): Move to file scope.
2635         (style_show_list): Likewise.
2636         (set_style): Call help_list.
2637         (show_style): Call cmd_show_list.
2638         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2639         Update to use the new macro.
2640
2641 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2642
2643         * ada-lang.c (_initialize_ada_language): Expand the help text
2644         for the "catch exception" command.
2645
2646 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2647
2648         * symtab.c (matching_obj_sections): Initialize obj,
2649         declare it closer to its usage.
2650
2651 2019-01-10  Tom Tromey  <tom@tromey.com>
2652
2653         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2654         (basic_inf_threads_range): Remove.
2655         (inf_threads_range, inf_non_exited_threads_range)
2656         (safe_inf_threads_range): Use next_adapter.
2657
2658 2019-01-10  Keith Seitz  <keiths@redhat.com>
2659
2660         PR gdb/23712
2661         PR symtab/23010
2662         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2663         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2664
2665 2019-01-10  Keith Seitz  <keiths@redhat.com>
2666
2667         PR gdb/23712
2668         PR symtab/23010
2669         * dictionary.c (pending_to_vector): Remove.
2670         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2671         Remove _1 suffix, replacing functions of the same name.  Update
2672         all callers.
2673         (dict_create_hashed, dict_create_hashed_expandable)
2674         (dict_create_linear, dict_create_linear_expandable, dict_free)
2675         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2676         Make functions static.
2677
2678 2019-01-10  Keith Seitz  <keiths@redhat.com>
2679
2680         PR gdb/23712
2681         PR symtab/23010
2682         * dictionary.h (struct dictionary): Replace declaration with
2683         multidictionary.
2684         (dict_create_hashed, dict_create_hashed_expandable)
2685         (dict_create_linear, dict_create_linear_expandable)
2686         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2687         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2688         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2689         taking multidictionary argument.
2690         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2691         * block.h (struct block) <dict>: Change to multidictionary
2692         and rename `multidict'.
2693         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2694         symmisc.c: Update all dictionary references to multidictionary.
2695
2696 2019-01-10  Keith Seitz  <keiths@redhat.com>
2697
2698         PR gdb/23712
2699         PR symtab/23010
2700         * dictionary.c: Include unordered_map.
2701         (pending_to_vector): New function.
2702         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2703         Rewrite the non-"_1" functions to take vector instead
2704         of linked list.
2705         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2706         "new" _1 versions of the same name.
2707         (multidictionary): Define.
2708         (std::hash<enum language): New definition.
2709         (collate_pending_symbols_by_language, mdict_create_hashed)
2710         (mdict_create_hashed_expandable, mdict_create_linear)
2711         (mdict_create_linear_expandable, mdict_free)
2712         (find_language_dictionary, create_new_language_dictionary)
2713         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2714         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2715         (mdict_size, mdict_empty): New functions.
2716         * dictionary.h (mdict_iterator): Define.
2717
2718 2019-01-10  Pedro Alves  <palves@redhat.com>
2719
2720         * breakpoint.c (read_uploaded_action)
2721         (create_tracepoint_from_upload): Adjust to use
2722         gdb::unique_xmalloc_ptr.
2723         * ctf.c (ctf_write_uploaded_tp):
2724         (SET_ARRAY_FIELD): Use emplace_back.
2725         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2726         * tracefile-tfile.c (tfile_write_uploaded_tp):
2727         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2728         gdb::unique_xmalloc_ptr.
2729         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2730         at_string, cond_string, cmd_strings>: Replace char pointers
2731         with gdb::unique_xmalloc_ptr.
2732
2733 2019-01-10  Pedro Alves  <palves@redhat.com>
2734
2735         * solib-target.c (library_list_start_library): Don't xstrdup name.
2736
2737 2019-01-10  Pedro Alves  <palves@redhat.com>
2738
2739         * mdebugread.c (parse_partial_symbols): Use
2740         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2741
2742 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2743
2744         * linux-fork.c (scoped_switch_fork_info)
2745         <~scoped_switch_fork_info>: Fix incorrect variable name.
2746
2747 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2748
2749         * linux-fork.c (scoped_switch_fork_info)
2750         <scoped_switch_fork_info>: Make explicit.
2751         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2752
2753 2019-01-10  Tom Tromey  <tom@tromey.com>
2754
2755         * objfiles.h (objfile::reset_psymtabs): Update.
2756         * objfiles.c (objfile::objfile): Update.
2757         * psymtab.h (psymtab_storage::obstack): Update.
2758         (psymtab_storage::m_obstack): Use gdb::optional.
2759         (class psymtab_storage): Update comment.  Remove objfile
2760         parameter.
2761         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2762
2763 2019-01-10  Tom Tromey  <tom@tromey.com>
2764
2765         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2766         <free_psymtabs>: Now private.
2767         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2768         (allocate_psymtab): Use new method.
2769
2770 2019-01-10  Tom Tromey  <tom@tromey.com>
2771
2772         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2773         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2774         * mdebugread.c (parse_partial_symbols): Use
2775         allocate_dependencies.
2776         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2777         allocate_dependencies.
2778         (process_psymtab_comp_unit_reader)
2779         (build_type_psymtab_dependencies): Likewise.
2780         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2781
2782 2019-01-10  Tom Tromey  <tom@tromey.com>
2783
2784         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2785         PSYMBOL_SET_LANGUAGE.
2786         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2787
2788 2019-01-10  Tom Tromey  <tom@tromey.com>
2789
2790         * psymtab.h (psymtab_storage::obstack): New method.
2791         <m_obstack>: Rename from obstack; now private.
2792         * psymtab.c (psymtab_storage): Update.
2793         * dwarf2read.c (create_addrmap_from_index)
2794         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2795         Update.
2796
2797 2019-01-10  Tom Tromey  <tom@tromey.com>
2798
2799         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2800         * objfiles.h (objfile::reset_psymtabs): New method.
2801
2802 2019-01-10  Tom Tromey  <tom@tromey.com>
2803
2804         * symmisc.c (print_symbol_bcache_statistics): Update.
2805         (print_objfile_statistics): Update.
2806         * symfile.c (reread_symbols): Update.
2807         * psymtab.h (class psymtab_storage): New.
2808         * psymtab.c (psymtab_storage): New constructor.
2809         (~psymtab_storage): New destructor.
2810         (require_partial_symbols): Update.
2811         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2812         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2813         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2814         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2815         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2816         (start_psymtab_common, end_psymtab_common)
2817         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2818         (allocate_psymtab): Update.
2819         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2820         Update.
2821         (dump_psymtab_addrmap, maintenance_print_psymbols)
2822         (maintenance_check_psymtabs): Update.
2823         (class objfile_psymtabs): Move to objfiles.h.
2824         * psympriv.h (discard_psymtab): Now inline.
2825         (psymtab_discarder::psymtab_discarder): Update.
2826         (psymtab_discarder::~psymtab_discarder): Update.
2827         (ALL_OBJFILE_PSYMTABS): Rewrite.
2828         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2829         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2830         Remove fields.
2831         <partial_symtabs>: New field.
2832         (class objfile_psymtabs): Move from psymtab.h.  Update.
2833         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2834         psymbol_cache.
2835         (objfile::~objfile): Don't destroy psymbol_cache.
2836         * mdebugread.c (parse_partial_symbols): Update.
2837         * dwarf2read.c (create_addrmap_from_index)
2838         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2839         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2840         (add_partial_subprogram, dwarf2_ranges_read): Update.
2841         * dwarf-index-write.c (write_address_map)
2842         (write_one_signatured_type, recursively_write_psymbols)
2843         (class debug_names, class debug_names, write_psymtabs_to_index):
2844         Update.
2845
2846 2019-01-10  Tom Tromey  <tom@tromey.com>
2847
2848         * symtab.h (SYMBOL_SET_NAMES): Update.
2849         (symbol_set_names): Update.
2850         (MSYMBOL_SET_NAMES): Update.
2851         * symtab.c (symbol_set_names): Change argument to be an
2852         objfile_per_bfd_storage.
2853         * psymtab.c (add_psymbol_to_bcache): Update.
2854         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2855
2856 2019-01-10  Tom Tromey  <tom@tromey.com>
2857
2858         * symtab.c (create_demangled_names_hash): Change argument to be an
2859         objfile_per_bfd_storage.
2860         (symbol_set_names): Update.
2861
2862 2019-01-10  Tom Tromey  <tom@tromey.com>
2863
2864         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2865         init_psymbol_list.
2866         * psymtab.c (init_psymbol_list): Do nothing if already called.
2867         * psympriv.h (init_psymbol_list): Add comment.
2868         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2869         init_psymbol_list.
2870         * dbxread.c (dbx_symfile_read): Unconditionally call
2871         init_psymbol_list.
2872
2873 2019-01-10  Tom Tromey  <tom@tromey.com>
2874
2875         * xcoffread.c (scan_xcoff_symtab): Update.
2876         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2877         "where".
2878         * mdebugread.c (parse_partial_symbols)
2879         (handle_psymbol_enumerators): Update.
2880         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2881         * dbxread.c (read_dbx_symtab): Update.
2882         * psympriv.h (psymbol_placement): New enum.
2883         (add_psymbol_to_list): Update.
2884
2885 2019-01-10  Tom Tromey  <tom@tromey.com>
2886
2887         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2888         static_psymbols parameters.
2889         (scan_xcoff_symtab): Update.
2890         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2891         static_psymbols parameters.
2892         * psympriv.h (start_psymtab_common): Update.
2893         * mdebugread.c (parse_partial_symbols): Update.
2894         * dwarf2read.c (create_partial_symtab): Update.
2895         * dbxread.c (read_dbx_symtab): Update.
2896         (start_psymtab): Remove global_psymbols and static_psymbols
2897         parameters.
2898
2899 2019-01-10  Tom Tromey  <tom@tromey.com>
2900
2901         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2902         * psymtab.c (allocate_psymtab): Add comment.
2903         * psympriv.h (allocate_psymtab): Add comment.
2904         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2905         initializations.
2906         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2907
2908 2019-01-10  Tom Tromey  <tom@tromey.com>
2909
2910         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2911         Don't declare.
2912         * mipsread.c: Include mdebugread.h.
2913         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2914         Declare.
2915         * elfread.c: Include mdebugread.h.
2916
2917 2019-01-09  Tom Tromey  <tom@tromey.com>
2918
2919         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2920         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2921         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2922         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2923         (psym_lookup_symbol, psym_find_last_source_symtab)
2924         (psym_forget_cached_source_info, psym_print_stats)
2925         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2926         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2927         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2928         (psym_find_compunit_symtab_by_address)
2929         (maintenance_print_psymbols, maintenance_info_psymtabs)
2930         (maintenance_check_psymtabs): Use ranged for.
2931         * psymtab.h (class objfile_psymtabs): New.
2932         (require_partial_symbols): Return objfile_psymtabs.
2933         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2934
2935 2019-01-09  Tom Tromey  <tom@tromey.com>
2936
2937         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2938         (find_pc_mapped_section, list_overlays_command)
2939         (map_overlay_command, unmap_overlay_command)
2940         (simple_overlay_update): Use all_objfiles.
2941         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2942         * printcmd.c (info_symbol_command): Use all_objfiles.
2943         * objfiles.h (ALL_OBJSECTIONS): Remove.
2944         * maint.c (maintenance_translate_address): Use all_objfiles.
2945         * gcore.c (gcore_create_callback): Use all_objfiles.
2946         (objfile_find_memory_regions): Likewise.
2947
2948 2019-01-09  Tom Tromey  <tom@tromey.com>
2949
2950         * symtab.c (find_line_symtab, info_sources_command)
2951         (make_source_files_completion_list): Use objfile_compunits.
2952         * source.c (select_source_symtab): Use objfile_compunits.
2953         * objfiles.h (struct objfile): Update comment.
2954         (ALL_OBJFILES): Remove.
2955         (ALL_FILETABS): Remove.
2956         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2957         objfile_compunits.
2958
2959 2019-01-09  Tom Tromey  <tom@tromey.com>
2960
2961         * symmisc.c (print_objfile_statistics, dump_objfile)
2962         (maintenance_print_symbols): Use compunit_filetabs.
2963         * source.c (forget_cached_source_info_for_objfile): Use
2964         compunit_filetabs.
2965         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2966         (ALL_FILETABS): Use compunit_filetabs.
2967         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2968         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2969
2970 2019-01-09  Tom Tromey  <tom@tromey.com>
2971
2972         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2973         (compunit_filetabs): New.
2974         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2975         compunit_filetabs.
2976         (info_sources_command, make_source_files_completion_list): Remove
2977         declaration.
2978         * symmisc.c (print_objfile_statistics, dump_objfile)
2979         (maintenance_print_symbols): Remove declaration.
2980         (maintenance_info_symtabs): Use compunit_filetabs.
2981         (maintenance_info_line_tables): Likewise.
2982         * source.c (select_source_symtab): Change local variable name.
2983         (forget_cached_source_info_for_objfile): Remove declaration.
2984         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2985         * objfiles.c (objfile_relocate1): Remove declaration.
2986         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2987         declaration.
2988         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2989         * coffread.c (coff_symtab_read): Remove declaration.
2990         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2991         compunit_filetabs.
2992
2993 2019-01-09  Tom Tromey  <tom@tromey.com>
2994
2995         * symtab.c (lookup_objfile_from_block)
2996         (find_pc_sect_compunit_symtab, search_symbols)
2997         (default_collect_symbol_completion_matches_break_on): Use
2998         objfile_compunits.
2999         * objfiles.h (ALL_COMPUNITS): Remove.
3000         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3001         * cp-support.c (add_symbol_overload_list_qualified): Use
3002         objfile_compunits.
3003         * ada-lang.c (ada_collect_symbol_completion_matches)
3004         (ada_add_global_exceptions): Use objfile_compunits.
3005
3006 2019-01-09  Tom Tromey  <tom@tromey.com>
3007
3008         * source.c (select_source_symtab)
3009         (forget_cached_source_info_for_objfile): Remove declaration.
3010         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3011         declaration.
3012         * maint.c (count_symtabs_and_blocks): Remove declaration.
3013         * cp-support.c (add_symbol_overload_list_qualified): Remove
3014         declaration.
3015         * coffread.c (coff_symtab_read): Remove declaration.
3016         * symtab.c (lookup_symbol_in_objfile_symtabs)
3017         (basic_lookup_transparent_type_1): Use objfile_compunits.
3018         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3019         (info_sources_command, search_symbols)
3020         (default_collect_symbol_completion_matches_break_on)
3021         (make_source_files_completion_list): Remove declaration.
3022         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3023         (ada_collect_symbol_completion_matches)
3024         (ada_add_global_exceptions): Remove declaration.
3025         * linespec.c (iterate_over_all_matching_symtabs): Use
3026         objfile_compunits.
3027         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3028         (class objfile_compunits): New.
3029         (ALL_COMPUNITS): Use objfile_compunits.
3030         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3031         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3032         objfile_compunits.
3033         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3034
3035 2019-01-09  Tom Tromey  <tom@tromey.com>
3036
3037         * symtab.c (search_symbols)
3038         (default_collect_symbol_completion_matches_break_on): Use
3039         objfile_msymbols.
3040         * ada-lang.c (ada_lookup_simple_minsym)
3041         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3042         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3043         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3044         objfile_msymbols.
3045         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3046         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3047         * objc-lang.c (find_methods): Use objfile_msymbols.
3048         (info_selectors_command, info_classes_command): Likewise.
3049         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3050         * objfiles.h (class objfile_msymbols): New.
3051         (ALL_OBJFILE_MSYMBOLS): Remove.
3052         (ALL_MSYMBOLS): Remove.
3053
3054 2019-01-09  Tom Tromey  <tom@tromey.com>
3055
3056         * common/next-iterator.h (next_adapter): Add Iterator template
3057         parameter.
3058         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3059         (class all_objfiles_safe): New.
3060         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3061         * objfiles.c (put_objfile_before): Update comment.
3062         (add_separate_debug_objfile): Likewise.
3063         (free_all_objfiles): Use all_objfiles_safe.
3064         (objfile_purge_solibs): Likewise.
3065
3066 2019-01-09  Tom Tromey  <tom@tromey.com>
3067
3068         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3069         (expand_symtab_containing_pc, lookup_static_symbol)
3070         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3071         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3072         all_objfiles.
3073         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3074         * breakpoint.c (create_overlay_event_breakpoint)
3075         (create_longjmp_master_breakpoint)
3076         (create_std_terminate_master_breakpoint)
3077         (create_exception_master_breakpoint): Use all_objfiles.
3078         * linux-thread-db.c (try_thread_db_load_from_pdir)
3079         (has_libpthread): Use all_objfiles.
3080         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3081         * linespec.c (iterate_over_all_matching_symtabs)
3082         (search_minsyms_for_name): Use all_objfiles.
3083         * maint.c (maintenance_info_sections): Use all_objfiles.
3084         * main.c (captured_main_1): Use all_objfiles.
3085         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3086         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3087         * guile/scm-pretty-print.c
3088         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3089         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3090         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3091         (maintenance_print_msymbols): Use all_objfiles.
3092         * source.c (select_source_symtab): Use all_objfiles.
3093         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3094         * symfile.c (remove_symbol_file_command)
3095         (expand_symtabs_matching, map_symbol_filenames): Use
3096         all_objfiles.
3097         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3098         all_objfiles.
3099         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3100         * objc-lang.c (find_methods): Use all_objfiles.
3101         * objfiles.c (have_partial_symbols, have_full_symbols)
3102         (have_minimal_symbols, qsort_cmp)
3103         (default_iterate_over_objfiles_in_search_order): Use
3104         all_objfiles.
3105         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3106         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3107         (maintenance_check_psymtabs): Use all_objfiles.
3108         (ALL_PSYMTABS): Remove.
3109         * compile/compile-object-run.c (do_module_cleanup): Use
3110         all_objfiles.
3111         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3112         * cp-support.c (add_symbol_overload_list_qualified): Use
3113         all_objfiles.
3114         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3115         Use all_objfiles.
3116         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3117         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3118         all_objfiles.
3119         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3120         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3121         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3122         Uses all_objfiles.
3123         * solib.c (solib_read_symbols): Use all_objfiles
3124
3125 2019-01-09  Tom Tromey  <tom@tromey.com>
3126
3127         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3128         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3129         all_objfiles.
3130         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3131         * symmisc.c (print_symbol_bcache_statistics)
3132         (print_objfile_statistics, maintenance_print_objfiles)
3133         (maintenance_info_symtabs, maintenance_check_symtabs)
3134         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3135         all_objfiles.
3136         * source.c (forget_cached_source_info): Use all_objfiles.
3137         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3138         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3139         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3140         * objfiles.c (update_section_map): Use all_objfiles.
3141         (shared_objfile_contains_address_p): Likewise.
3142         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3143         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3144
3145 2019-01-09  Tom Tromey  <tom@tromey.com>
3146
3147         * common/next-iterator.h: New file.
3148         * objfiles.h (class all_objfiles): New.
3149         (struct objfile_iterator): New.
3150
3151 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3152
3153         * NEWS: Move the description of the changed "frame", "select-frame",
3154          and "info frame" commands to the Changed commands section.
3155
3156 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3157
3158         * gdbtypes.c (check_stub_method_group): Remove handling of old
3159         mangling schemes.
3160         * linespec.c (find_methods): Likewise.
3161         * stabsread.c (read_member_functions): Likewise.
3162         * valops.c (search_struct_method): Likewise.
3163         (value_struct_elt_for_reference): Likewise.
3164         * NEWS: Mention this change.
3165
3166 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3167
3168         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3169         print_source_lines.
3170         * source.c (print_source_lines_base): Update line number check.
3171         (print_source_lines): New function.
3172         (source_lines_range::source_lines_range): New function.
3173         * source.h (class source_lines_range): New class.
3174         (print_source_lines): New declaration.
3175
3176 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3177
3178         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3179
3180 2019-01-08  Tom Tromey  <tom@tromey.com>
3181             Simon Marchi  <simon.marchi@ericsson.com>
3182
3183         PR gdb/24060
3184         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3185         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3186         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3187         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3188         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3189         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3190
3191 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3192
3193         * source.c (select_source_symtab): Move header comment to
3194         declaration in source.h.
3195         (forget_cached_source_info_for_objfile): Likewise.
3196         (forget_cached_source_info): Likewise.
3197         (identify_source_line): Likewise.
3198         * source.h (identify_source_line): Move declaration from symtab.h
3199         and add comment from source.c
3200         (print_source_lines): Likewise.
3201         (forget_cached_source_info_for_objfile): Likewise.
3202         (forget_cached_source_info): Likewise.
3203         (select_source_symtab): Likewise.
3204         (enum print_source_lines_flag): Move definition from symtab.h.
3205         * symtab.h (identify_source_line): Move declaration to source.h.
3206         (print_source_lines): Likewise.
3207         (forget_cached_source_info_for_objfile): Likewise.
3208         (forget_cached_source_info): Likewise.
3209         (select_source_symtab): Likewise.
3210         (enum print_source_lines_flag): Move definition to source.h.
3211         * tui/tui-hooks.c: Add 'source.h' include.
3212
3213 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3214
3215         * source.c (print_source_lines_base): Handle requests to print
3216         reverse line number sequences, and guard against empty lines
3217         string.
3218
3219 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3220
3221         * source.c (print_source_lines_base): Fix skip of '\r' if next
3222         character is '\n'.
3223
3224 2019-01-06  Tom Tromey  <tom@tromey.com>
3225
3226         * c-exp.y (struct c_parse_state) <macro_original_text,
3227         expansion_obstack>: New member.
3228         (macro_original_text, expansion_obstack): Remove globals.
3229         (scan_macro_expansion, scanning_macro_expansion)
3230         (finished_macro_expansion): Update.
3231         (scan_macro_cleanup): Remove.
3232         (yylex, c_parse): Update.
3233
3234 2019-01-06  Tom Tromey  <tom@tromey.com>
3235
3236         * c-exp.y (struct c_parse_state) <strings>: New member.
3237         (operator_stoken): Update.
3238
3239 2019-01-06  Tom Tromey  <tom@tromey.com>
3240
3241         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3242         (union type_stack_elt) <typelist_val>: Now a pointer to
3243         std::vector.
3244         (type_stack_cleanup): Don't declare.
3245         (push_typelist): Update.
3246         * parse.c (pop_typelist): Return a std::vector.
3247         (push_typelist): Take a std::vector.
3248         (follow_types): Update.  Do not free args.
3249         (type_stack_cleanup): Remove.
3250         * c-exp.y (struct c_parse_state): New.
3251         (cpstate): New global.
3252         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3253         (nonempty_typelist): Update.
3254         (func_mod): Create a new vector.
3255         (c_parse): Create a c_parse_state.
3256         (check_parameter_typelist): Do not delete params.
3257         (function_method): Update.  Do not delete type_list.
3258
3259 2019-01-06  Tom Tromey  <tom@tromey.com>
3260
3261         PR gdb/28155:
3262         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3263         check_typedef.
3264         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3265         (print_return_value): Likewise.
3266
3267 2019-01-05  Tom Tromey  <tom@tromey.com>
3268
3269         * contrib/cleanup_check.py: Remove.
3270         * contrib/gcc-with-excheck: Remove.
3271         * contrib/exsummary.py: Remove.
3272         * contrib/excheck.py: Remove.
3273
3274 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3275
3276         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3277         NULL. Initialize tpprev to NULL instead of assigning it
3278         to NULL on the next statement.
3279         * windows-nat.c (windows_delete_thread): Remove check for
3280         main_thread_id before printing thread exit notifications.
3281         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3282         Remove thread ID check against main_thread_id.
3283         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3284         windows_delete_thread.
3285         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3286
3287 2019-01-04  Tom Tromey  <tom@tromey.com>
3288
3289         * compile/compile.c (_initialize_compile): Use upper case for
3290         metasyntactic variables.
3291         * symmisc.c (_initialize_symmisc): Use upper case for
3292         metasyntactic variables.
3293         * psymtab.c (_initialize_psymtab): Use upper case for
3294         metasyntactic variables.
3295         * demangle.c (demangle_command): Use upper case for metasyntactic
3296         variables.
3297         (_initialize_demangler): Likewise.
3298         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3299         variables.
3300
3301 2019-01-03  Tom Tromey  <tom@tromey.com>
3302
3303         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3304
3305 2019-01-03  Tom Tromey  <tom@tromey.com>
3306
3307         * python/py-symtab.c (salpy_str): Update.
3308         (struct salpy_sal_object) <symtab>: Now a PyObject.
3309         (salpy_dealloc): Update.
3310         (del_objfile_sal): Use gdbpy_ref.
3311
3312 2019-01-03  Tom Tromey  <tom@tromey.com>
3313
3314         * python/py-type.c (convert_field): Use new_reference.  Return
3315         gdbpy_ref.
3316         (make_fielditem): Return gdbpy_ref.
3317         (typy_fields): Update.
3318         (typy_getitem): Update.
3319         (field_name): Return gdbpy_ref.  Use new_reference.
3320         (typy_iterator_iternext): Update.
3321
3322 2019-01-03  Tom Tromey  <tom@tromey.com>
3323
3324         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3325
3326 2019-01-03  Tom Tromey  <tom@tromey.com>
3327
3328         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3329         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3330         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3331         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3332         (pspy_set_type_printers): Likewise.
3333         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3334         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3335         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3336         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3337         (objfpy_set_type_printers): Likewise.
3338
3339 2019-01-03  Tom Tromey  <tom@tromey.com>
3340
3341         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3342         (gdbpy_print_stack): Use gdbpy_err_fetch.
3343         * python/python-internal.h (class gdbpy_err_fetch): New class.
3344         (class gdbpy_enter) <m_error_type, m_error_value,
3345         m_error_traceback>: Remove.
3346         <m_error>: New member.
3347         (gdbpy_exception_to_string): Don't declare.
3348         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3349         * python/py-value.c (convert_value_from_python): Use
3350         gdbpy_err_fetch.
3351         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3352         gdbpy_exception_to_string.
3353         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3354         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3355         gdbpy_err_fetch.
3356
3357 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3358
3359         * linux-nat.c (delete_lwp_cleanup): Delete.
3360         (struct lwp_deleter): New struct.
3361         (lwp_info_up): New typedef.
3362         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3363         lwp_info_up.
3364
3365 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3366
3367         * linux-fork.c (class scoped_switch_fork_info): New class.
3368         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3369
3370 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3371
3372         * valops.c (find_overload_match): Remove use of null_cleanup, and
3373         calls to do_cleanups.
3374
3375 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3376
3377         * compile/compile-cplus-types.c
3378         (compile_cplus_instance::decl_name): Handle changes to
3379         cp_func_name.
3380         * cp-support.c (cp_func_name): Update header comment, update
3381         return type.
3382         * cp-support.h (cp_func_name): Update return type in declaration.
3383         * valops.c (find_overload_match): Move temp_func local to top
3384         level of function and change its type.  Use temp_func to hold and
3385         delete temporary string obtained from cp_func_name.
3386
3387 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3388
3389         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3390         gdb::char_vector, remove cleanup, and update uses of `msg`.
3391
3392 2019-01-03  Jim Wilson  <jimw@sifive.com>
3393
3394         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3395
3396 2019-01-02  Tom Tromey  <tom@tromey.com>
3397
3398         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3399         (tdesc_parse_xml): Remove cleanups.
3400         * target-descriptions.h (make_cleanup_free_target_description):
3401         Don't declare.
3402         (target_desc_deleter): New struct.
3403         (target_desc_up): New typedef.
3404         * target-descriptions.c (target_desc_deleter::operator()): Rename
3405         from free_target_description.
3406         (make_cleanup_free_target_description): Remove.
3407
3408 2019-01-02  Tom Tromey  <tom@tromey.com>
3409
3410         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3411         constructor, destructor.
3412         (linespec_parser): Remove typedef.
3413         (~linespec_parser): Rename from linespec_parser_delete.
3414         (linespec_lex_to_end, linespec_complete_label)
3415         (linespec_complete): Update.
3416         (decode_line_full): Remove cleanups.
3417         (decode_line_1): Update.
3418
3419 2019-01-02  Tom Tromey  <tom@tromey.com>
3420
3421         * python/python-internal.h (inferior_to_inferior_object): Change
3422         return type.
3423         * python/py-exitedevent.c (create_exited_event_object): Update.
3424         * python/py-inferior.c (inferior_to_inferior_object): Return
3425         gdbpy_ref.
3426         (python_new_inferior, python_inferior_deleted)
3427         (thread_to_thread_object, delete_thread_object)
3428         (build_inferior_list, gdbpy_selected_inferior): Update.
3429         * python/py-infthread.c (create_thread_object): Update.  Also fail
3430         if inferior_to_inferior_object fails.
3431
3432 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3433
3434         * inferior.h (class inferior) <displaced_step_state>: New field.
3435         * infrun.h (struct displaced_step_state): Move here from
3436         infrun.c.  Initialize fields, add constructor.
3437         <inf>: Remove field.
3438         <reset>: New method.
3439         * infrun.c (struct displaced_step_inferior_state): Move to
3440         infrun.h.
3441         (displaced_step_inferior_states): Remove.
3442         (get_displaced_stepping_state): Adust.
3443         (displaced_step_in_progress_any_inferior): Adjust.
3444         (displaced_step_in_progress_thread): Adjust.
3445         (displaced_step_in_progress): Adjust.
3446         (add_displaced_stepping_state): Remove.
3447         (get_displaced_step_closure_by_addr): Adjust.
3448         (remove_displaced_stepping_state): Remove.
3449         (infrun_inferior_exit): Call displaced_step_state.reset.
3450         (use_displaced_stepping): Don't check for NULL.
3451         (displaced_step_prepare_throw): Call
3452         get_displaced_stepping_state.
3453         (displaced_step_fixup): Don't check for NULL.
3454         (prepare_for_detach): Don't check for NULL.
3455
3456 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3457
3458         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3459          in case of call that did not complete.
3460
3461 2019-01-02  Andrey Utkin  <autkin@undo.io>
3462
3463         * symfile.c (find_separate_debug_file): Fix search of debug files for
3464         remote debuggee.
3465
3466 2019-01-02  Tom Tromey  <tom@tromey.com>
3467
3468         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3469         indentation.
3470         * python/py-frame.c (frapy_older): Remove cast.
3471         (frapy_newer): Likewise.
3472         * python/py-breakpoint.c (local_setattro): Remove cast.
3473         * python/py-arch.c (archpy_name): Remove local variable.
3474         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3475
3476 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3477
3478         * unittests/basic_string_view/element_access/char/empty.cc:
3479         Fix year range in copyright header.
3480
3481 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3482
3483         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3484         Delete.
3485         <operator==>: Update with for removed field.
3486         <hash>: Likewise.
3487         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3488         <isa_features>: ...this.
3489         <abi_features>: New field.
3490         (riscv_isa_flen): Update comment.
3491         (riscv_abi_xlen): New declaration.
3492         (riscv_abi_flen): New declaration.
3493         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3494         isa_features.
3495         (riscv_abi_xlen): New function.
3496         (riscv_isa_flen): Update to get answer from isa_features.
3497         (riscv_abi_flen): New function.
3498         (riscv_has_fp_abi): Update to get answer from abi_features.
3499         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3500         xlen and flen.
3501         (riscv_call_info) <xlen, flen>: Update comment.
3502         (riscv_call_arg_struct): Remove invalid assertions
3503         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3504         is removed.
3505         (riscv_gdbarch_init): Gather isa features and abi features
3506         separately, ensure both match on the gdbarch when reusing an old
3507         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3508         a target with 64-bit float hardware.
3509
3510 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3511
3512         * source.c (search_command_helper): Stop reverse search
3513         when line 1 has been searched.
3514
3515 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3516
3517         * record-full.c (record_full_base_target::close): Rewrite
3518         record_full_core_buf_list free logic.
3519
3520 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3521
3522         * break-catch-syscall.c (print_one_catch_syscall): xfree
3523         the last text.
3524
3525 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3526
3527         * top.c (print_gdb_version): Update Copyright year in version
3528         message.
3529
3530 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3531
3532         Update copyright year range in all GDB files.
3533
3534 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3535
3536         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3537
3538 For older changes see ChangeLog-2018.
3539 \f
3540 Local Variables:
3541 mode: change-log
3542 left-margin: 8
3543 fill-column: 74
3544 version-control: never
3545 coding: utf-8
3546 End:
3547