gdb/ChangeLog

   1 2019-08-13  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.c (make_all_visible): Remove.
   4         (tui_make_all_invisible): Simplify.
   5         * tui/tui-layout.c (tui_make_all_invisible): Move from
   6         tui-wingeneral.c; simplify.
   7         (show_layout): Hoist call to tui_make_all_invisible.
   8         (show_data): Don't call tui_make_all_invisible.
   9
  10 2019-08-13  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
  13         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
  14
  15 2019-08-13  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
  18         tui-data.c.
  19         (show_source_disasm_command, show_data)
  20         (show_source_or_disasm_and_command): Don't use
  21         tui_set_current_layout_to.
  22         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
  23         * tui/tui-data.c (current_layout, tui_current_layout): Move to
  24         tui-layout.c.
  25         (tui_set_current_layout_to): Remove.
  26
  27 2019-08-13  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-layout.c (tui_set_layout): Update.
  30         * tui/tui-data.h (struct tui_layout_def): Remove.
  31         (tui_layout_def): Don't declare.
  32         * tui/tui-data.c (layout_def): Remove.
  33         (tui_layout_def): Remove.
  34
  35 2019-08-13  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-winsource.h (struct tui_source_window_base)
  38         <clear_detail>: No longer "override".
  39         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
  40         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
  41         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
  42         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
  43         Remove.
  44         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
  45
  46 2019-08-13  Tom Tromey  <tromey@adacore.com>
  47
  48         * tracepoint.c: Don't include readline.h or history.h.
  49
  50 2019-08-12  Tom Tromey  <tom@tromey.com>
  51
  52         * configure: Rebuild.
  53         * configure.ac: Check for readline 7.
  54         * NEWS: Mention readline 7 requirement.
  55         * README: Update.
  56
  57 2019-08-12  Tom Tromey  <tom@tromey.com>
  58
  59         * mingw-hdep.c (gdb_select): Remove readline hack.
  60
  61 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
  62
  63         * blockframe.c (find_pc_partial_function): Set *block to nullptr
  64         when the function fails.
  65
  66 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
  67
  68         * s390-tdep.c (s390_type_align): New function.
  69         (s390_gdbarch_init): Set it as type_align gdbarch method.
  70
  71 2019-08-09  Tom de Vries  <tdevries@suse.de>
  72
  73         PR gdb/24591
  74         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
  75         pc_low with relocation offset.
  76
  77 2019-08-07  Tom Tromey  <tromey@adacore.com>
  78
  79         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
  80         (print_frame_args): Update.
  81         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
  82         Update.
  83         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
  84         * frame.h (struct frame_arg): Add initializers.
  85         <error>: Now a unique_xmalloc_ptr.
  86
  87 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
  88
  89         * NEWS: Expand the Pointer Authentication entry.
  90         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
  91         (aarch64_frame_unmask_lr): ... to this.
  92         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
  93         Call aarch64_frame_unmask_lr.
  94         * frame.c (struct frame_info): Add "masked" variable.
  95         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
  96         (fprint_frame): Check for masked pc.
  97         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
  98         declarations.
  99         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 100         * stack.c (print_frame): Check for masked pc.
 101
 102 2019-08-06  Tom Tromey  <tom@tromey.com>
 103
 104         * stabsread.c (patch_block_stabs, read_one_struct_field)
 105         (read_enum_type): Use obstack_strndup.
 106         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 107         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 108         * dwarf2read.c (guess_full_die_structure_name)
 109         (anonymous_struct_prefix): Use obstack_strndup.
 110         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 111         * c-exp.y (yylex): Use obstack_strndup.
 112         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 113         (write_var_or_type): Use obstack_strndup.
 114
 115 2019-08-06  Tom Tromey  <tom@tromey.com>
 116
 117         * symfile.c (reread_symbols): Use obstack_strdup.
 118         * stabsread.c (read_type): Use obstack_strdup.
 119         * gdb_obstack.h (obstack_strdup): New overload.
 120         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 121         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 122         (dwarf2_canonicalize_name): Use obstack_strdup.
 123         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 124         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 125         Use obstack_strdup.
 126
 127 2019-08-06  Tom Tromey  <tom@tromey.com>
 128
 129         * gdb_obstack.h (obstack_strdup): Define.
 130         * gdb_obstack.c (obstack_strdup): Don't define.
 131
 132 2019-08-06  Tom Tromey  <tom@tromey.com>
 133
 134         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 135         obstack_strdup.
 136         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 137         obstack_strdup.
 138         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 139         * stabsread.c (common_block_start): Use obstack_strdup.
 140         * objfiles.c (set_objfile_main_name, objfile): Use
 141         obstack_strdup.
 142         * namespace.c (add_using_directive): Use obstack_strdup.
 143         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 144         * jit.c (finalize_symtab): Use obstack_strdup.
 145         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 146         (guess_partial_die_structure_name, partial_die_info::fixup)
 147         (dwarf2_name): Use obstack_strdup.
 148         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 149         obstack_strdup.
 150         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 151         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 152         obstack_strdup.
 153         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 154
 155 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 156
 157         * unittests/help-doc-selftests.c: New file.
 158         * Makefile.in: Add the new file.
 159
 160 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 161
 162         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 163         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 164         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 165         the trailing '.' is not output, and the first character is uppercased.
 166         (print_help_for_command): Update call to print_doc_line.
 167         (print_doc_of_command): Likewise.
 168         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 169         * cli/cli-option.c (append_indented_doc): Do not append newline.
 170         (build_help_option): Append newline after first appended_indented_doc
 171         only if a second call is done.
 172         (build_help): Append 2 new lines before each option, except the first
 173         one.
 174         * compile/compile.c (_initialize_compile): Add new lines after
 175         %OPTIONS%, when not at the end of the help.
 176         Change help doc or code
 177         producing the help doc to respect the invariants.
 178         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 179         Also removed the new line after 'Options:', as all other commands
 180         do not put an empty line between 'Options:' and the first option.
 181         * printcmd.c (_initialize_printcmd): Likewise.
 182         * stack.c (_initialize_stack): Likewise.
 183         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 184         incorrectly telling COMMAND is optional.
 185         * ada-lang.c (_initialize_ada_language): Change help doc or code
 186         producing the help doc to respect the invariants.
 187         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 188         * breakpoint.c (_initialize_breakpoint): Likewise.
 189         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 190         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 191         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 192         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 193         _initialize_cli_style): Likewise.
 194         * corelow.c (core_target_info): Likewise.
 195         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 196         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 197         * filesystem.c (_initialize_filesystem): Likewise.
 198         * frame.c (_initialize_frame): Likewise.
 199         * gnu-nat.c (add_task_commands): Likewise.
 200         * infcall.c (_initialize_infcall): Likewise.
 201         * infcmd.c (_initialize_infcmd): Likewise.
 202         * interps.c (_initialize_interpreter): Likewise.
 203         * language.c (_initialize_language): Likewise.
 204         * linux-fork.c (_initialize_linux_fork): Likewise.
 205         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 206         * maint.c (_initialize_maint_cmds): Likewise.
 207         * memattr.c (_initialize_mem): Likewise.
 208         * printcmd.c (_initialize_printcmd): Likewise.
 209         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 210         _RegEx): Likewise.
 211         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 212         * record-btrace.c (_initialize_record_btrace): Likewise.
 213         * record-full.c (_initialize_record_full): Likewise.
 214         * record.c (_initialize_record): Likewise.
 215         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 216         * regcache.c (_initialize_regcache): Likewise.
 217         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 218         _initialize_remote): Likewise.
 219         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 220         * serial.c (_initialize_serial): Likewise.
 221         * skip.c (_initialize_step_skip): Likewise.
 222         * source.c (_initialize_source): Likewise.
 223         * stack.c (_initialize_stack): Likewise.
 224         * symfile.c (_initialize_symfile): Likewise.
 225         * symtab.c (_initialize_symtab): Likewise.
 226         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 227         * top.c (init_main): Likewise.
 228         * tracefile-tfile.c (tfile_target_info): Likewise.
 229         * tracepoint.c (_initialize_tracepoint): Likewise.
 230         * tui/tui-win.c (_initialize_tui_win): Likewise.
 231         * utils.c (add_internal_problem_command): Likewise.
 232         * valprint.c (value_print_option_defs): Likewise.
 233
 234 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 235
 236         PR build/24886
 237         * configure.ac: Drop enable-libmcheck support.
 238         * configure, config.in: Rebuild.
 239         * libmcheck.m4: Remove.
 240         * acinclude.m4: Don't include it.
 241         * Makefile.in: Don't distribute it.
 242         * top.c (print_gdb_configuration): Don't mention it.
 243
 244 2019-08-06  Tom Tromey  <tom@tromey.com>
 245
 246         * utils.c (set_output_style): Sometimes pass stream to
 247         emit_style_escape.
 248         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 249         * record-btrace.c (btrace_insn_history): Update.
 250         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 251         method.
 252         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 253         Update initializers.
 254         <m_uiout>: New field.
 255         <m_di>: Move lower.
 256         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 257         Remove "uiout" parameter.
 258         (dump_insns): Update.
 259         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 260         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 261
 262 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 263
 264         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 265         (error_in_psymtab_expansion): Likewise.
 266         (lookup_symbol_via_quick_fns): Likewise.
 267         (basic_lookup_transparent_type_quick): Likewise.
 268         (basic_lookup_transparent_type_1): Likewise.
 269
 270 2019-08-06  Tom Tromey  <tromey@adacore.com>
 271
 272         * source.c (last_source_error): Now bool.
 273         (print_source_lines_base): Make "noprint" bool.  Only open
 274         source file when last_source_visited changes.
 275
 276 2019-08-06  Tom Tromey  <tromey@adacore.com>
 277
 278         * annotate.c (annotate_source_line): Use g_source_cache.
 279         * source-cache.c (source_cache::get_plain_source_lines): Change
 280         parameters.  Populate m_offset_cache.
 281         (source_cache::ensure): New method.
 282         (source_cache::get_line_charpos): New method.
 283         (extract_lines): Move lower.  Change parameters.
 284         (source_cache::get_source_lines): Move lower.
 285         * source-cache.h (class source_cache): Update comment.
 286         <get_line_charpos>: New method.
 287         <get_source_lines>: Update comment.
 288         <clear>: Clear m_offset_cache.
 289         <get_plain_source_lines>: Change parameters.
 290         <ensure>: New method
 291         <m_offset_cache>: New member.
 292         * source.c (forget_cached_source_info_for_objfile): Update.
 293         (info_source_command): Use g_source_cache.
 294         (find_source_lines, open_source_file_with_line_charpos): Remove.
 295         (print_source_lines_base, search_command_helper): Use g_source_cache.
 296         * source.h (open_source_file_with_line_charpos): Don't declare.
 297         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 298         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 299         Use g_source_cache.
 300
 301 2019-08-06  Tom Tromey  <tromey@adacore.com>
 302
 303         * source-cache.c (source_cache::get_plain_source_lines):
 304         Remove "first_line" and "last_line" parameters.
 305         (source_cache::get_source_lines): Cache plain text.
 306         * source-cache.h (class source_cache)
 307         <get_plain_source_lines>: Update.
 308
 309 2019-08-06  Tom Tromey  <tromey@adacore.com>
 310
 311         * source-cache.c (extract_lines): No longer a method.
 312         Changed type of parameter.  Include final newline.
 313         (selftests::extract_lines_test): New function.
 314         (_initialize_source_cache): Likewise.
 315         * source-cache.h (class source_cache)
 316         <extract_lines>: Don't declare.
 317
 318 2019-08-06  Tom Tromey  <tromey@adacore.com>
 319
 320         * breakpoint.c (init_breakpoint_sal): Update.
 321         (breakpoint): Update.
 322         * breakpoint.h (struct breakpoint) <filter>: Now a
 323         unique_xmalloc_ptr.
 324
 325 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 326
 327         * NEWS: Mention dictionary access on blocks.
 328         * python/py-block.c (blpy_getitem): New function.
 329         (block_object_as_mapping): New struct.
 330         (block_object_type): Use new struct for tp_as_mapping field.
 331
 332 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 333
 334         * objfiles.h (objfile): Add a comment describing partial symbols.
 335
 336 2019-08-05  Tom Tromey  <tromey@adacore.com>
 337
 338         * compile/compile.c (_initialize_compile): Use _(), not N_().
 339         * thread.c (_initialize_thread): Use _(), not N_().
 340         * stack.c (_initialize_stack): Use _(), not N_().
 341         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 342
 343 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 344
 345         * dwarf2read.c (struct dw2_symtab_iterator):
 346         <want_specific_block>: Remove.
 347         <block_index>: Change type to gdb::optional.
 348         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 349         change type of BLOCK_INDEX parameter to gdb::optional.
 350         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 351         (dw2_lookup_symbol): Don't pass argument for
 352         WANT_SPECIFIC_BLOCK.
 353         (dw2_expand_symtabs_for_function): Don't pass argument for
 354         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 355         (class dw2_debug_names_iterator)
 356         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 357         parameter, change BLOCK_INDEX type to gdb::optional.
 358         <m_want_specific_block>: Remove.
 359         <m_block_index>: Change type to gdb::optional.
 360         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 361         gdb::optional.  Re-write in function of gdb::optional.
 362         (dw2_debug_names_lookup_symbol): Don't pass argument for
 363         WANT_SPECIFIC_BLOCK.
 364         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 365         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 366         BLOCK_INDEX.
 367
 368 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 369
 370         * NEWS: Mention changes to "info sources" command.
 371
 372 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 373
 374         * symtab.c (filename_partial_match_opts): New struct type.
 375         (struct output_source_filename_data): New members
 376         regexp, c_regexp, partial_match.
 377         (output_source_filename): Use new members to decide to print file.
 378         (info_sources_option_defs): New variable.
 379         (make_info_sources_options_def_group, print_info_sources_header,
 380         info_sources_command_completer):
 381         New functions.
 382         (info_sources_command): Read new optional arguments.
 383         (_initialize_symtab): Update info sources help.
 384
 385 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 386
 387         * ada-lang.c (exception_support_info_v0): Renamed from...
 388         (default_exception_support_info): ... this.  Create new
 389         definition for v1.
 390         (ada_has_this_exception_support): Look up catch_handlers_sym.
 391         (ada_exception_support_info_sniffer): Try v0 after default.
 392
 393 2019-08-01  Tom Tromey  <tromey@adacore.com>
 394
 395         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 396         gdbarch.h.
 397
 398 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 399
 400         * s12z-tdep.c: Fix include path for s12z-opc.h.
 401
 402 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 403
 404         * NEWS: Require GNU make 3.82.
 405
 406 2019-07-16  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 409         declare.
 410
 411 2019-07-30  Tom Tromey  <tromey@adacore.com>
 412
 413         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 414
 415 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 416
 417         * printcmd.c (print_address_symbolic): Print negative offsets.
 418         (build_address_symbolic): Force signed arithmetic when computing
 419         offset.
 420
 421 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 422
 423         PR/24474: Add a function to lookup static variables.
 424         * NEWS: Mention this new function.
 425         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 426         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 427         * python/python.c (python_GdbMethods): Add new function.
 428
 429 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 430
 431         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 432         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 433         (objfpy_lookup_static_symbol): New function.
 434         (objfile_object_methods): Add new functions.
 435
 436 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 437
 438         * NEWS: Mention 'set|show print frame-info'.  Mention new
 439         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 440         backtrace argument.  Mention that python frame filtering code
 441         is now consistent with what 'backtrace' command prints.
 442
 443 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 444
 445         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 446         comments.
 447         (print_frame_info_auto, print_frame_info_source_line,
 448         print_frame_info_location, print_frame_info_source_and_location,
 449         print_frame_info_location_and_address, print_frame_info_short_location):
 450         New declarations.
 451         (struct frame_print_options): New member print_frame_info.
 452         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 453         * stack.h (get_user_print_what_frame_info): New declaration.
 454         (frame_show_address): New declaration.
 455         * stack.c (print_frame_arguments_choices): New value 'presence'.
 456         (print_frame_info_auto, print_frame_info_source_line,
 457         print_frame_info_location, print_frame_info_source_and_location,
 458         print_frame_info_location_and_address, print_frame_info_short_location,
 459         print_frame_info_choices, print_frame_info_print_what): New definitions.
 460         (print_frame_args): Only print dots for args if print frame-arguments
 461         is 'presence'.
 462         (frame_print_option_defs): New element for "frame-info".
 463         (get_user_print_what_frame_info): New function.
 464         (frame_show_address): Make non static.  Move comment to stack.h.
 465         (print_frame_info_to_print_what): New function.
 466         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 467         to decide what to print.
 468         (backtrace_command_1): Handle the new print_frame_arguments_presence
 469         value.
 470         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 471         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 472         (py_print_frame): In non-mi mode, use LOCATION as default for
 473         print_what, similarly to frame information printed directly by
 474         backtrace command. Handle frame-info user option in non MI mode.
 475
 476 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 477
 478         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 479         Add case for debugging 32-bit target on 64-bit host.  Revise
 480         comment.
 481
 482 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 483
 484         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 485         instead of find_function_entry_range_from_pc.
 486
 487 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 488
 489         * stack.c (find_frame_funname): Remove code which preferred
 490         minsym over symtab sym in "certain pathological cases".
 491
 492         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 493         parameter.  Change type of "do_demangle" to bool.
 494         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 495         Pass suitable "prefer_sym_over_minsym" flag to
 496         build_address_symbolic().  Don't output "+" for negative offsets.
 497         * printcmd.c (print_address_symbolic): Update invocation of
 498         build_address_symbolic to include a "prefer_sym_over_minsym"
 499         flag.
 500         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 501         Restrict cases in which use of minimal symbol is preferred to that
 502         of a found symbol.  Update comments.
 503
 504         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 505         for entry pc when entry pc is out of range for that FDE.
 506
 507 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 508
 509         PR gdb/24839:
 510         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 511         type.
 512
 513 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 514
 515         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 516         this function's Python signature.
 517
 518
 519 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 520
 521         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 522         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 523         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 524         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 525         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 526
 527
 528 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 529
 530         * h8300-tdep.c (h8300_register_name_common): New.
 531         h8300_register_name): Use h8300_register_name_common.
 532         (h8300s_register_name): Likewise.
 533         (h8300sx_register_name): Likewise.
 534         (h8300h_register_nam): New.
 535         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 536
 537
 538 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 539
 540         * arm-tdep.c (arm_skip_cmse_entry): New function.
 541         (arm_is_sgstubs_section): New function.
 542         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 543
 544 2019-07-22  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 547         Don't self-assign.
 548
 549 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 550
 551         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 552         type_print.
 553
 554 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 555
 556         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 557         so that GDB doesn't match any msymbols when searching in the
 558         TYPES_DOMAIN.
 559         (print_symbol_info): Print using typedef_print or type_print based
 560         on the type of the symbol.  Add updated FIXME comment moved from...
 561         (_initialize_symtab): ... move and update FIXME comment to above.
 562
 563 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 564
 565         * NEWS: Mention adding -q option to "info types".
 566         * symtab.c (struct info_types_options): New struct.
 567         (info_types_options_defs): New variable.
 568         (make_info_types_options_def_group): New function.
 569         (info_types_command): Use gdb::option framework to parse options.
 570         (info_types_command_completer): New function.
 571         (_initialize_symtab): Extend the help text on "info types" and
 572         register command completer.
 573
 574 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 575
 576         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 577         (lookup_symbol_in_objfile): Change int to block_enum and add a
 578         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 579
 580 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 581
 582         * MAINTAINERS (Write After Approval): Add self.
 583
 584 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 585
 586         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 587         instruction to the dummy code region.
 588
 589 2019-07-19  Tom Tromey  <tromey@adacore.com>
 590
 591         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 592         (ARGSUSED, PARAMS, __func__): Remove rules.
 593
 594 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 595
 596         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 597         * features/arm/arm-with-iwmmxt.c: Remove.
 598         * features/arm/arm-with-iwmmxt.xml: Remove.
 599         * features/arm/arm-with-m-fpa-layout.c: Remove.
 600         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 601         * features/arm/arm-with-m-vfp-d16.c: Remove.
 602         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 603         * features/arm/arm-with-m.c: Remove.
 604         * features/arm/arm-with-m.xml: Remove.
 605         * features/arm/arm-with-neon.c: Remove.
 606         * features/arm/arm-with-neon.xml: Remove.
 607         * features/arm/arm-with-vfpv2.c: Remove.
 608         * features/arm/arm-with-vfpv2.xml: Remove.
 609         * features/arm/arm-with-vfpv3.c: Remove.
 610         * features/arm/arm-with-vfpv3.xml: Remove.
 611
 612 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 613
 614         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 615
 616 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 617
 618         * arch/aarch32.c (aarch32_create_target_description): Create
 619         target descriptions using features.
 620         * arch/arm.c (arm_create_target_description)
 621         (arm_create_mprofile_target_description): Likewise.
 622         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 623
 624 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 625
 626         * Makefile.in: Add new files.
 627         * aarch32-tdep.c: New file.
 628         * aarch32-tdep.h: New file.
 629         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 630         Call aarch32_read_description.
 631         * arch/aarch32.c: New file.
 632         * arch/aarch32.h: New file.
 633         * arch/arm.c (arm_create_target_description)
 634         (arm_create_mprofile_target_description): New function.
 635         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 636         (arm_create_target_description)
 637         (arm_create_mprofile_target_description): New declaration.
 638         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 639         read_description functions.
 640         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 641         Likewise.
 642         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 643         * arm-tdep.c (tdesc_arm_list): New variable.
 644         (arm_register_g_packet_guesses): Call create description functions.
 645         (arm_read_description) (arm_read_mprofile_description): New
 646         function.
 647         * arm-tdep.h (arm_read_description)
 648         (arm_read_mprofile_description): Add declaration.
 649         * configure.tgt: Add new files.
 650
 651 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 652
 653         * top.c (new_ui_command): Open specified terminal just once.
 654
 655 2019-07-18  Tom Tromey  <tromey@adacore.com>
 656
 657         * symtab.c (main_name): Constify return type.
 658         * symfile.c (set_initial_language): Update.
 659         * symtab.h (main_name): Constify return type.
 660
 661 2019-07-17  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-winsource.c (tui_update_source_window)
 664         (tui_update_source_window_as_is)
 665         (tui_update_source_windows_with_line): Remove return.
 666         * tui/tui-disasm.c (tui_show_disassem)
 667         (tui_show_disassem_and_update_source): Remove return.
 668         * tui/tui.c (tui_reset): Remove return.
 669         * tui/tui-wingeneral.c
 670         (tui_check_and_display_highlight_if_needed): Remove return.
 671
 672 2019-07-17  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 675
 676 2019-07-17  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-winsource.h (struct tui_exec_info_window)
 679         (struct tui_source_window_base): Move from tui-data.h.
 680         * tui/tui-winsource.c: Move many method definitions from
 681         elsewhere.  Remove "structuring" comments.
 682         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 683         (tui_source_window_base::refresh_window): Move to
 684         tui-winsource.c.
 685         * tui/tui-win.c (tui_source_window_base::refresh_all)
 686         (tui_source_window_base::update_tab_width)
 687         (tui_source_window_base::set_new_height)
 688         (tui_source_window_base::do_make_visible_with_new_height): Move to
 689         tui-winsource.c.
 690         * tui/tui-source.h: Update.
 691         * tui/tui-source.c (tui_source_window_base::reset): Move to
 692         tui-winsource.c.
 693         * tui/tui-disasm.h: Update.
 694         * tui/tui-data.h (struct tui_exec_info_window): Move to
 695         tui-winsource.h.
 696         (struct tui_source_window_base): Likewise.
 697         * tui/tui-data.c (tui_source_window_base::clear_detail)
 698         (tui_source_window_base, ~tui_source_window_base): Move to
 699         tui-winsource.c.
 700
 701 2019-07-17  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui-win.c (tui_resize_all)
 704         (tui_source_window_base::update_tab_width)
 705         (tui_adjust_win_heights): Update.
 706         (tui_win_info::make_invisible_and_set_new_height): Rename from
 707         make_invisible_and_set_new_height.
 708         * tui/tui-data.h (struct tui_win_info)
 709         <make_invisible_and_set_new_height>: New method.
 710
 711 2019-07-17  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui.c: Update.
 714         * tui/tui-source.h (struct tui_source_window): Move from
 715         tui-data.h.
 716         * tui/tui-layout.c: Update.
 717         * tui/tui-disasm.c: Update.
 718         * tui/tui-data.h (struct tui_source_window): Move to
 719         tui-source.h.
 720
 721 2019-07-17  Tom Tromey  <tom@tromey.com>
 722
 723         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 724         tui-data.h.
 725         * tui/tui-data.h (struct tui_disasm_window): Move to
 726         tui-disasm.h.
 727
 728 2019-07-17  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-regs.h (struct tui_data_item_window): Move from
 731         tui-data.h.
 732         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 733         * tui/tui-data.h (struct tui_data_item_window): Move to
 734         tui-regs.h.
 735         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 736
 737 2019-07-17  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui.c: Update.
 740         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 741         (tui_cmd_window::max_height): Move to tui-command.c.
 742         * tui/tui-layout.c: Update.
 743         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 744         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 745         tui-command.c.
 746         * tui/tui-command.h (struct tui_cmd_window): Move from
 747         tui-data.h.
 748         * tui/tui-command.c: Remove "structuring" comments.
 749         (tui_cmd_window::clear_detail)
 750         (tui_cmd_window::do_make_visible_with_new_height)
 751         (tui_cmd_window::max_height): Move from elsewhere.
 752
 753 2019-07-17  Tom Tromey  <tom@tromey.com>
 754
 755         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 756         Now static.
 757         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 758         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 759
 760 2019-07-17  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui.c: Update.
 763         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 764         tui-regs.c.
 765         * tui/tui-windata.h: Remove file.
 766         * tui/tui-windata.c: Remove file.
 767         * tui/tui-win.c (tui_data_window::set_new_height)
 768         (tui_data_window::do_make_visible_with_new_height): Move to
 769         tui-regs.c.
 770         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 771         * tui/tui-regs.c: Remove "structuring" comments.
 772         (tui_data_window::first_data_item_displayed)
 773         (tui_data_window::delete_data_content_windows)
 774         (tui_data_window::erase_data_content)
 775         (tui_data_window::display_all_data)
 776         (tui_data_window::refresh_all)
 777         (tui_data_window::do_scroll_vertical)
 778         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 779         (tui_data_window::do_make_visible_with_new_height)
 780         (tui_data_window::refresh_window): Move from elsewhere.
 781         (_initialize_tui_regs): Move to end of file.
 782         * tui/tui-layout.c: Update.
 783         * tui/tui-hooks.c: Update.
 784         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 785         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 786         tui-regs.c.
 787         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 788
 789 2019-07-17  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 792         seen.
 793
 794 2019-07-17  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-win.c (tui_source_window_base::set_new_height)
 797         (tui_source_window_base::do_make_visible_with_new_height): Use
 798         m_has_locator field directly.
 799         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 800         method.
 801         (struct tui_source_window_base) <has_locator>: Likewise.
 802
 803 2019-07-17  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 806         Don't declare.
 807         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 808         Remove.
 809         * tui/tui-win.c (tui_source_window_base::set_new_height)
 810         (tui_source_window_base::set_new_height)
 811         (make_invisible_and_set_new_height)
 812         (tui_source_window_base::do_make_visible_with_new_height)
 813         (tui_source_window_base::do_make_visible_with_new_height):
 814         Update.
 815         * tui/tui-layout.c (show_source_disasm_command, show_data)
 816         (show_source_or_disasm_and_command): Update.
 817         * tui/tui-layout.c (show_layout): Update.
 818
 819 2019-07-17  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-layout.c (make_data_window): Remove.
 822         (show_data): Unify creation and re-initialization cases.
 823
 824 2019-07-17  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-layout.c (make_source_window, make_disasm_window):
 827         Remove.
 828         (show_data): Unify creation and re-initialization cases.
 829
 830 2019-07-17  Tom Tromey  <tom@tromey.com>
 831
 832         * tui/tui-layout.c (make_command_window): Remove.
 833         (show_source_disasm_command, show_source_or_disasm_and_command):
 834         Unify creation and re-initialization cases.
 835
 836 2019-07-17  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 839         creation and re-initialization cases.
 840
 841 2019-07-17  Tom Tromey  <tom@tromey.com>
 842
 843         * tui/tui-regs.c (tui_get_register): Return void.
 844
 845 2019-07-17  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 848         Simplify.
 849
 850 2019-07-17  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 853         resetting.
 854
 855 2019-07-17  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 858         * tui/tui-regs.c (tui_reg_layout): New function.
 859         (tui_show_registers, tui_reg_command): Use it.
 860         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 861         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 862         parameters.
 863         (tui_layout_command): Remove.
 864
 865 2019-07-17  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-layout.h (tui/tui-layout): Return void.
 868         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 869
 870 2019-07-17  Tom Tromey  <tom@tromey.com>
 871
 872         * tui/tui-layout.c (show_source_disasm_command, show_data):
 873         Update.
 874         (reset_locator): Remove.
 875         (show_source_or_disasm_and_command): Update.
 876
 877 2019-07-17  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-source.c (tui_source_window_base::reset): Remove
 880         win_type parameter.
 881         * tui/tui-layout.c (make_command_window, make_source_window)
 882         (make_disasm_window, make_data_window)
 883         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 884         (reset_locator, show_source_or_disasm_and_command): Update.
 885         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 886         win_type parameter.
 887         (struct tui_source_window_base) <reset>: Likewise.
 888
 889 2019-07-17  Tom Tromey  <tom@tromey.com>
 890
 891         * tui/tui-layout.c (show_source_disasm_command): Use
 892         reset_locator.
 893         (reset_locator): New function.
 894         (init_and_make_win): Remove.
 895         (show_source_or_disasm_and_command): Use reset_locator.
 896
 897 2019-07-17  Tom Tromey  <tom@tromey.com>
 898
 899         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 900         condition.
 901         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 902         Remove condition.
 903         * tui/tui-source.c (tui_source_window_base::reset): New method.
 904         * tui/tui-layout.c (make_command_window): Don't call
 905         init_and_make_win.
 906         (make_source_window, make_disasm_window): Don't call
 907         make_source_or_disasm_window.
 908         (make_data_window): Don't call init_and_make_win.  Change calling
 909         convention.
 910         (show_source_disasm_command, show_data): Simplify.
 911         (make_source_or_disasm_window): Remove.
 912         (show_source_or_disasm_and_command): Simplify.
 913         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 914         (struct tui_source_window_base) <reset>: Likewise.
 915         <execution_info>: Remove initializer.
 916         * tui/tui-data.c (tui_source_window_base): Initialize
 917         execution_info.
 918
 919 2019-07-17  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 922         variable.
 923
 924 2019-07-17  Tom Tromey  <tom@tromey.com>
 925
 926         * tui/tui.c (tui_rl_other_window): Update.
 927         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 928         superclass method first.  Always iterate over regs_content.
 929         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 930         method.
 931         * tui/tui-win.c (tui_set_focus_command): Update.
 932
 933 2019-07-17  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-win.c (tui_set_focus_command): Rename from
 936         tui_set_focus.  Call tui_enable.
 937         (tui_set_focus_command): Remove.
 938
 939 2019-07-17  Tom Tromey  <tom@tromey.com>
 940
 941         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 942         refresh_window.
 943         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 944         touchwin.
 945         (tui_data_window::refresh_window): Call refresh_window on data
 946         items.  Always call superclass refresh_window.
 947         (tui_win_info::refresh): Remove.
 948         (tui_source_window_base::refresh_window): Update.
 949         (tui_refresh_all): Update.
 950         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 951         refresh_window.
 952         (show_source_or_disasm_and_command): Likewise.
 953         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 954         (struct tui_source_window_base) <refresh>: Likewise.
 955
 956 2019-07-17  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-winsource.c (tui_clear_source_content)
 959         (tui_show_source_content): Update.
 960         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 961         whether content is empty.
 962         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 963         Remove.
 964
 965 2019-07-17  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 968         window's contents.
 969         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 970         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 971
 972 2019-07-17  Tom Tromey  <tom@tromey.com>
 973
 974         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 975         (struct tui_data_item_window): Update.
 976
 977 2019-07-17  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 980         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 981         defines.
 982
 983 2019-07-17  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-winsource.h (tui_erase_source_content)
 986         (tui_clear_source_content): Remove "display_prompt" parameter.
 987         * tui/tui-winsource.c (tui_update_source_window_as_is)
 988         (tui_update_source_windows_with_addr): Update.
 989         (tui_clear_source_content): Remove "display_prompt" parameter.
 990         (tui_erase_source_content): Likewise.  Simplify.
 991         (tui_show_source_content): Update.
 992         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 993         * tui/tui-stack.c (tui_show_frame_info): Update.
 994         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 995         Remove defines.
 996
 997 2019-07-17  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1000         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1001         parameter.
1002         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1003         parameter.
1004
1005 2019-07-17  Tom Tromey  <tom@tromey.com>
1006
1007         * tui/tui-winsource.c (tui_clear_source_content)
1008         (tui_show_source_content, tui_show_exec_info_content)
1009         (tui_clear_exec_info_content): Update.
1010         * tui/tui-stack.c (tui_show_locator_content): Update.
1011         (tui_show_frame_info): Update.
1012         * tui/tui-source.h (tui_source_window): Don't declare.
1013         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1014         from tui_source_is_displayed.
1015         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1016         Remove field.
1017         (struct tui_source_window_base) <content_in_use>: New field.  Now
1018         bool.
1019         (struct tui_source_window) <showing_source_p>: New method.
1020         (TUI_SRC_WIN): Change cast.
1021         * tui/tui-data.c (tui_initialize_static_data): Update.
1022
1023 2019-07-17  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1026         location_matches_p.
1027         * tui/tui-source.c (tui_source_window::location_matches_p): New
1028         method.
1029         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1030         method.
1031         * tui/tui-data.h (struct tui_source_window_base)
1032         <location_matches_p>: New method.
1033         (struct tui_source_window, struct tui_disasm_window)
1034         <location_matches_p>: Likewise.
1035
1036 2019-07-17  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-win.c (tui_set_win_height_command): Rename from
1039         tui_set_win_height.
1040         (tui_set_win_height_command): Remove.
1041
1042 2019-07-17  Tom Tromey  <tom@tromey.com>
1043
1044         * tui/tui-source.c (tui_source_window): New constructor.  Add
1045         observer.
1046         (~tui_source_window): New destructor.
1047         (tui_source_window::style_changed): New method.
1048         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1049         (tui_attach_detach_observers): Update.
1050         * tui/tui-data.h (struct tui_source_window): Make constructor not
1051         inline.  Add destructor.
1052         (struct tui_source_window) <style_changed>: New method.
1053         <m_observable>: New member.
1054
1055 2019-07-17  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1058         * tui/tui-win.c (tui_resize_all): Fix typo.
1059
1060 2019-07-17  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1063         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1064         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1065         * tui/tui-win.c (window_name_completer): Use foreach.
1066         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1067         (update_tab_width): Likewise.
1068         * tui/tui-layout.c (show_layout): Update.
1069         * tui/tui-data.h (class tui_window_iterator): New.
1070         (struct all_tui_windows): New.
1071         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1072
1073 2019-07-17  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1076         parameter.  Don't reference globals.
1077         (tui_reg_command): Update.
1078
1079 2019-07-17  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-regs.c (tui_show_registers): Simplify.
1082
1083 2019-07-17  Tom Tromey  <tom@tromey.com>
1084
1085         * tui/tui-regs.c (tui_show_registers): Update.
1086         (tui_show_register_group): Add win_info parameter.
1087
1088 2019-07-17  Tom Tromey  <tom@tromey.com>
1089
1090         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1091         Rename from tui_display_reg_element_at_line.
1092         (tui_data_window::display_registers_from_line): Update.
1093         * tui/tui-data.h (struct tui_data_window)
1094         <display_reg_element_at_line>: New method.
1095
1096 2019-07-17  Tom Tromey  <tom@tromey.com>
1097
1098         * tui/tui-regs.h (tui_display_registers_from)
1099         (tui_display_registers_from_line): Don't declare.
1100         * tui/tui-windata.c (tui_data_window::display_all_data)
1101         (tui_data_window::refresh_all)
1102         (tui_data_window::do_scroll_vertical): Update.
1103         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1104         from tui_display_registers_from.
1105         (tui_display_reg_element_at_line): Update.
1106         (tui_data_window::display_registers_from_line): Rename from
1107         tui_display_registers_from_line.
1108         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1109         display_registers_from_line>: New methods.
1110
1111 2019-07-17  Tom Tromey  <tom@tromey.com>
1112
1113         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1114         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1115         from tui_erase_data_content.
1116         (tui_data_window::display_all_data)
1117         (tui_data_window::refresh_all)
1118         (tui_data_window::do_scroll_vertical): Update.
1119         * tui/tui-regs.c (tui_show_registers): Update.
1120         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1121         New method.
1122
1123 2019-07-17  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1126         declare.
1127         * tui/tui-windata.c
1128         (tui_data_window::delete_data_content_windows): Rename from
1129         tui_delete_data_content_windows.
1130         (tui_data_window::display_all_data)
1131         (tui_data_window::do_scroll_vertical): Update.
1132         * tui/tui-data.h (struct tui_data_window)
1133         <delete_data_content_windows>: New method.
1134
1135 2019-07-17  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1138         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1139
1140 2019-07-17  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1143         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1144         from tui_display_all_data.
1145         * tui/tui-win.c
1146         (tui_data_window::do_make_visible_with_new_height): Update.
1147         * tui/tui-regs.c (tui_show_registers): Update.
1148         * tui/tui-layout.c (tui_set_layout): Update.
1149         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1150         method.
1151
1152 2019-07-17  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1155         * tui/tui-windata.c (tui_display_data_from): Remove.
1156         (tui_data_window::refresh_all): Update.
1157
1158 2019-07-17  Tom Tromey  <tom@tromey.com>
1159
1160         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1161         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1162         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1163         tui_display_registers_from_line.
1164         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1165         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1166         "force_display" parameter.
1167
1168 2019-07-17  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1171         declare.
1172         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1173         Rename from tui_first_reg_element_no_inline.
1174         (tui_display_reg_element_at_line)
1175         (tui_display_registers_from_line): Update.
1176         * tui/tui-data.h (struct tui_data_window)
1177         <first_reg_element_no_inline>: New method.
1178
1179 2019-07-17  Tom Tromey  <tom@tromey.com>
1180
1181         * tui/tui-windata.c (tui_display_data_from)
1182         (tui_data_window::do_scroll_vertical): Update.
1183         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1184         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1185         Rename from tui_line_from_reg_element_no.
1186         (tui_display_registers_from_line): Update.
1187         * tui/tui-data.h (struct tui_data_window)
1188         <line_from_reg_element_no>: New method.
1189
1190 2019-07-17  Tom Tromey  <tom@tromey.com>
1191
1192         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1193         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1194         tui_last_regs_line_no.
1195         (tui_display_reg_element_at_line)
1196         (tui_display_registers_from_line): Update.
1197         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1198         method.
1199
1200 2019-07-17  Tom Tromey  <tom@tromey.com>
1201
1202         PR tui/24722:
1203         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1204         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1205         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1206         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1207         (tui_update_breakpoint_info): Likewise.
1208         * tui/tui-hooks.c (tui_event_create_breakpoint)
1209         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1210         Update.
1211
1212 2019-07-17  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1215
1216 2019-07-17  Tom Tromey  <tom@tromey.com>
1217
1218         * tui/tui-winsource.c (tui_update_source_window_as_is)
1219         (tui_update_source_windows_with_addr): Update.
1220         * tui/tui-source.h (tui_set_source_content)
1221         (tui_show_symtab_source): Add "win_info" parameter.
1222         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1223         parameter.
1224         (tui_show_symtab_source): Likewise.
1225
1226 2019-07-17  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-wingeneral.c
1229         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1230
1231 2019-07-17  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1234         (struct tui_cmd_window) <can_scroll>: New method.
1235         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1236         method.
1237
1238 2019-07-17  Tom Tromey  <tromey@adacore.com>
1239
1240         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1241         do_field_signed>: Rename.  Change type of "value".
1242         * ui-out.c (ui_out::field_signed): Rename from field_int.
1243         Change type of "value".
1244         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1245         type of "value".
1246         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1247         do_field_int.  Change type of "value".
1248         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1249         do_field_int.  Change type of "value".
1250         * tracepoint.c (trace_status_mi, tfind_1)
1251         (print_one_static_tracepoint_marker): Update.
1252         * thread.c (print_thread_info_1, print_selected_thread_frame):
1253         Update.
1254         * stack.c (print_frame, print_frame_info): Update.
1255         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1256         Update.
1257         * source.c (print_source_lines_base): Update.
1258         * skip.c (info_skip_command): Update.
1259         * record-btrace.c (btrace_ui_out_decode_error)
1260         (btrace_call_history_src_line): Update.
1261         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1262         Update.
1263         * progspace.c (print_program_space): Update.
1264         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1265         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1266         do_field_int.  Change type of "value".
1267         * mi/mi-out.c (mi_ui_out::do_table_begin)
1268         (mi_ui_out::do_table_header): Update.
1269         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1270         type of "value".
1271         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1272         (mi_cmd_data_list_changed_registers, output_register)
1273         (mi_cmd_data_read_memory, mi_load_progress)
1274         (mi_cmd_trace_frame_collected): Update.
1275         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1276         Update.
1277         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1278         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1279         (mi_cmd_var_list_children, varobj_update_one): Update.
1280         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1281         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1282         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1283         * inferior.c (print_inferior): Update.
1284         * gdb_bfd.c (print_one_bfd): Update.
1285         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1286         Update.
1287         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1288         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1289         do_field_int.  Change type of "value".
1290         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1291         do_field_int.  Change type of "value".
1292         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1293         (print_one_breakpoint_location, print_it_catch_fork)
1294         (print_one_catch_fork, print_it_catch_vfork)
1295         (print_one_catch_vfork, print_it_catch_solib)
1296         (print_it_catch_exec, print_it_ranged_breakpoint)
1297         (print_mention_watchpoint, print_mention_masked_watchpoint)
1298         (bkpt_print_it, update_static_tracepoint): Update.
1299         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1300         * break-catch-syscall.c (print_it_catch_syscall): Update.
1301         * ada-tasks.c (print_ada_task_info): Update.
1302         * ada-lang.c (print_it_exception, print_mention_exception):
1303         Update.
1304
1305 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         PR breakpoints/24541
1308         * gdbarch.c: Regenerate.
1309         * gdbarch.h: Regenerate.
1310         * gdbarch.sh: Adjust return type and parameter types for
1311         'stap_adjust_register'.
1312         (i386_stap_adjust_register): Adjust signature and return new
1313         register name.
1314         * stap-probe.c (stap_parse_register_operand): Adjust use of
1315         'gdbarch_stap_adjust_register'.
1316
1317 2019-07-17  Tom Tromey  <tromey@adacore.com>
1318
1319         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1320         declare VEC.
1321         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1322         std::vector.
1323         (struct s390_process_info): Add initializers.
1324         (s390_add_process): Use new.
1325         (s390_linux_nat_target::low_forget_process): Use delete.
1326         (s390_linux_nat_target::low_new_fork)
1327         (s390_linux_nat_target::stopped_by_watchpoint)
1328         (s390_linux_nat_target::low_prepare_to_resume)
1329         (s390_linux_nat_target::insert_watchpoint)
1330         (s390_linux_nat_target::insert_hw_breakpoint)
1331         (s390_linux_nat_target::remove_watchpoint)
1332         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1333
1334 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1335
1336         * aarch64-fbsd-nat.c: Include regcache.h.
1337         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1338         argument.
1339         (aarch64_fbsd_nat_target::fetch_registers)
1340         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1341         variable.
1342         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1343
1344 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1345
1346         * fbsd-nat.c: Include gdbarch.h.
1347
1348 2019-07-15  Tom Tromey  <tromey@adacore.com>
1349
1350         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1351
1352 2019-07-15  Tom Tromey  <tromey@adacore.com>
1353
1354         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1355         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1356         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1357         * cli-out.c (cli_ui_out::do_field_int): New method.
1358         * ui-out.c (ui_out::field_unsigned): New method.
1359         * symfile.c (generic_load): Use field_unsigned.
1360         (print_transfer_performance): Likewise.
1361         * record-btrace.c (ui_out_field_uint): Remove.
1362         (btrace_call_history_insn_range, btrace_call_history): Use
1363         field_unsigned.
1364         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1365         field_unsigned.
1366         * ui-out.h (class ui_out) <field_unsigned>: New method.
1367         <do_field_unsigned>: Likewise.
1368
1369 2019-07-15  Tom Tromey  <tromey@adacore.com>
1370
1371         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1372         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1373         * target.c (flash_erase_command): Use field_string.
1374         * infrun.c (print_signal_received_reason): Use field_string.
1375         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1376         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1377         field_string.
1378         * ada-tasks.c (print_ada_task_info): Use field_string.
1379
1380 2019-07-15  Tom Tromey  <tromey@adacore.com>
1381
1382         * target.c (flash_erase_command): Use field_core_addr.
1383         * symfile.c (generic_load): Use field_core_addr.
1384         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1385         Use field_core_addr.
1386         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1387         field_core_addr.
1388
1389 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1390
1391         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1392         value if its desired type is smaller than a CORE_ADDR and signed.
1393
1394 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1395
1396         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1397         of changes to field names, and use new is_reference field to
1398         decide if a property is a reference or not.
1399         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1400         field.
1401         (struct dwarf2_property_baton): Update header comment, rename
1402         'referenced_type' to 'property_type' and update comments.
1403         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1404         default property type, store in property baton, update to take
1405         accound of renamed field.
1406         (read_func_scope): Update call to attr_to_dynamic_prop.
1407         (read_array_type): Likewise.
1408         (dwarf2_per_cu_addr_sized_int_type): New function.
1409         (read_subrange_index_type): Move type finding code to
1410         dwarf2_per_cu_addr_sized_int_type.
1411         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1412         (dwarf2_per_cu_addr_type): New function.
1413         (set_die_type): Update calls to attr_to_dynamic_prop.
1414
1415 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1416
1417         * dwarf2read.c (read_subrange_index_type): New function.
1418         (read_subrange_type): Move code into new function and call it.
1419         * gdbtypes.c (create_range_type): Add some asserts.
1420
1421 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1422
1423         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1424         update return statements.
1425         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1426         declaration, and update comment to match.
1427         * gdbtypes.c (resolve_dynamic_array): Update call to
1428         dwarf2_evaluate_property to match new return type.
1429
1430 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * valarith.c (value_subscripted_rvalue): Change lowerbound
1433         parameter type from int to LONGEST.
1434         * value.h (value_subscripted_rvalue): Likewise in declaration.
1435
1436 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1437
1438         * cli/cli-utils.c (info_print_command_completer): New function.
1439         * cli/cli-utils.h: Add 'completer.h' include, and forward
1440         declaration for 'struct cmd_list_element'.
1441         (info_print_command_completer): Declare.
1442         * stack.c (_initialize_stack): Add completer for 'info locals' and
1443         'info args'.
1444         * symtab.c (_initialize_symtab): Add completer for 'info
1445         variables' and 'info functions'.
1446         * NEWS: Mention completion for additional info commands.
1447
1448 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1449
1450         * cli/cli-utils.c (extract_info_print_args): Delete.
1451         (extract_arg_maybe_quoted): Delete.
1452         (info_print_options_defs): New variable.
1453         (make_info_print_options_def_group): New function.
1454         (extract_info_print_options): Define new function.
1455         * cli/cli-utils.h (extract_info_print_args): Delete.
1456         (struct info_print_options): New structure.
1457         (extract_info_print_options): Declare new function.
1458         * stack.c (info_locals_command): Update to use new
1459         extract_info_print_options, also add a header comment.
1460         (info_args_command): Likewise.
1461         * symtab.c (info_variables_command): Likewise.
1462         (info_functions_command): Likewise.
1463
1464 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1465
1466         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1467         to extract string arguments.
1468         * common/common-utils.c (extract_string_maybe_quoted): New function.
1469         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1470
1471 2019-07-11  Tom Tromey  <tromey@adacore.com>
1472
1473         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1474         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1475         * top.h (gdbinit): Don't declare.
1476         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1477         into...
1478         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1479         * top.c (gdb_init): Don't call init_cli_cmds.
1480         (gdbinit): Remove.
1481         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1482
1483 2019-07-11  Tom Tromey  <tromey@adacore.com>
1484
1485         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1486         after it has been moved.
1487
1488 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1489
1490         * valops.c (value_must_coerce_to_target): Change return type to
1491         bool.
1492         * value.h (value_must_coerce_to_target): Likewise.
1493
1494 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1495
1496         * breakpoint.c (is_hardware_watchpoint): Remove
1497         forward-declaration.
1498         (is_masked_watchpoint): Change return type to bool.
1499         (is_tracepoint): Likewise.
1500         (is_breakpoint): Likewise.
1501         (is_hardware_watchpoint): Likewise.
1502         (is_watchpoint): Likewise.
1503         (is_no_memory_software_watchpoint): Likewise.
1504         (is_catchpoint): Likewise.
1505         (breakpoint_1): Make FILTER parameter's return type bool.
1506         is_masked_watchpoint): Change return type to bool.
1507         (save_breakpoints): Make FILTER parameter's return type bool.
1508         * breakpoint.h (is_breakpoint): Change return type to bool.
1509         (is_watchpoint): Likewise.
1510         (is_catchpoint): Likewise.
1511         (is_tracepoint): Likewise.
1512
1513 2019-07-10  Tom Tromey  <tom@tromey.com>
1514
1515         * defs.h: Don't include gdbarch.h.
1516         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1517         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1518         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1519         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1520         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1521         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1522         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1523         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1524         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1525         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1526         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1527         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1528         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1529         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1530         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1531         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1532         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1533         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1534         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1535         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1536         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1537         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1538         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1539         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1540         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1541         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1542         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1543
1544 2019-07-10  Tom Tromey  <tromey@adacore.com>
1545
1546         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1547         * breakpoint.c (init_ada_exception_breakpoint): Register as
1548         bp_catchpoint.
1549         (print_one_breakpoint_location, print_one_breakpoint): Use
1550         is_ada_exception_catchpoint.
1551         * ada-lang.c (class ada_catchpoint_location): Pass
1552         bp_loc_software_breakpoint to bp_location constructor.
1553         (is_ada_exception_catchpoint): New function.
1554
1555 2019-07-10  Tom Tromey  <tromey@adacore.com>
1556
1557         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1558         VEC.
1559         (struct arm_exidx_entry): New method operator<.
1560         (struct arm_exidx_data) <section_maps>: Change type.
1561         (arm_exidx_data_free): Remove.
1562         (arm_exidx_data_key): Change type.  Move lower.
1563         (arm_exidx_new_objfile): Update.
1564         (arm_compare_exidx_entries): Remove.
1565         (arm_find_exidx_entry, _initialize_arm_tdep)
1566
1567 2019-07-10  Tom Tromey  <tromey@adacore.com>
1568
1569         * solib-spu.c (ocl_program_data_key): Change type.
1570         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1571         Update.
1572
1573 2019-07-10  Tom Tromey  <tromey@adacore.com>
1574
1575         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1576         (struct solib_aix_inferior_data) <library_list>: Change type.
1577         (solib_aix_inferior_data_handle): Change type.
1578         (get_solib_aix_inferior_data): Update.
1579         (solib_aix_free_library_list): Remove.
1580         (library_list_start_library): Update.
1581         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1582         return type.
1583         (solib_aix_get_library_list)
1584         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1585         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1586
1587 2019-07-10  Tom Tromey  <tromey@adacore.com>
1588
1589         * solib-dsbt.c (struct dsbt_info): Add initializers.
1590         (solib_dsbt_pspace_data): Change type.
1591         (dsbt_pspace_data_cleanup): Remove.
1592         (get_dsbt_info, _initialize_dsbt_solib): Update.
1593
1594 2019-07-10  Tom Tromey  <tromey@adacore.com>
1595
1596         * spu-tdep.c (spu_overlay_data): Change type.
1597         (spu_get_overlay_table, spu_overlay_new_objfile)
1598         (_initialize_spu_tdep): Update.
1599
1600 2019-07-10  Tom Tromey  <tromey@adacore.com>
1601
1602         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1603         destructor.
1604         (dbx_objfile_data_key): Change type and declare later.
1605         (DBX_SYMFILE_INFO): Rewrite.
1606         * dbxread.c (dbx_objfile_data_key): Change type.
1607         (dbx_symfile_init): Update.
1608         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1609         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1610         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1611
1612 2019-07-10  Tom Tromey  <tromey@adacore.com>
1613
1614         * jit.c (jit_program_space_key): Change type.  Move lower.
1615         (get_jit_program_space_data): Update.
1616         (jit_program_space_data_cleanup): Remove.
1617         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1618         Update.
1619         (struct jit_program_space_data): Add initializers.
1620
1621 2019-07-10  Tom Tromey  <tromey@adacore.com>
1622
1623         * solib-darwin.c (struct darwin_info): Add initializers.
1624         (solib_darwin_pspace_data): Change type.
1625         (darwin_pspace_data_cleanup): Remove.
1626         (get_darwin_info, _initialize_darwin_solib): Update.
1627
1628 2019-07-10  Tom Tromey  <tromey@adacore.com>
1629
1630         * remote-sim.c (struct sim_inferior_data): Add initializers,
1631         constructor, and destructor.
1632         (sim_inferior_data_key): Change type.  Move lower.
1633         (check_for_duplicate_sim_descriptor): Update.
1634         (get_sim_inferior_data): Use new.  Update.
1635         (~sim_inferior_data_cleanup): Rename from
1636         sim_inferior_data_cleanup.  Simplify.
1637         (gdbsim_close_inferior, simulator_command)
1638         (sim_command_completer, _initialize_remote_sim): Update.
1639         (next_pid, INITIAL_PID): Move earlier.
1640
1641 2019-07-10  Tom Tromey  <tromey@adacore.com>
1642
1643         * python/python-internal.h (create_thread_object): Return
1644         gdbpy_ref.
1645         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1646         * python/py-inferior.c (struct threadlist_entry): Add
1647         constructor.
1648         <thread_obj>: Now a gdbpy_ref.
1649         (thread_to_thread_object): Update.
1650         (add_thread_object): Use new.
1651         (delete_thread_object): Use delete.
1652         (infpy_threads): Update.
1653         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1654         GIL.
1655
1656 2019-07-10  Tom Tromey  <tromey@adacore.com>
1657
1658         * valops.c (value_cast): Specialize error message for Ada.
1659
1660 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1661
1662         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1663
1664 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1665
1666         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1667         bpstat_should_step): Return bool, adjust comments.
1668         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1669         bpstat_should_step): Likewise.
1670
1671 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1672
1673         * features/Makefile: Use feature target descriptions for Arm.
1674         * features/arm/arm-core.c: Generate new file.
1675         * features/arm/arm-fpa.c: Likewise.
1676         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1677         * features/arm/arm-m-profile.c: Likewise.
1678         * features/arm/arm-vfpv2.c: Likewise.
1679         * features/arm/arm-vfpv3.c: Likewise.
1680         * features/arm/xscale-iwmmxt.c: Likewise.
1681         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1682
1683 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1684
1685         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1686         ptrace earlier.
1687
1688 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1689
1690         * features/aarch64-pauth.c: Regenerate.
1691
1692 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1693
1694         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1695         bool.
1696         (bpstat_what): Use false instead of 0.
1697
1698 2019-07-09  Pedro Alves  <palves@redhat.com>
1699
1700         * break-catch-throw.c (is_exception_catchpoint): New.
1701         * breakpoint.c (print_one_breakpoint_location): New parameter
1702         'raw_loc'.  Handle it.  Use
1703         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1704         looking at the breakpoint's type.
1705         (print_one_breakpoint): If handling "maint info breakpoints", also
1706         print locations of exception catchpoints.
1707         * breakpoint.h (is_exception_catchpoint): Declare.
1708
1709 2019-07-09  Pedro Alves  <palves@redhat.com>
1710
1711         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1712         "addr" field.
1713         (allocate_location_exception_catchpoint): New.
1714         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1715         (initialize_throw_catchpoint_ops): Install
1716         allocate_location_exception_catchpoint as allocate_location
1717         method.
1718         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1719         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1720         bp_loc_other.
1721         (breakpoint_address_is_meaningful): Delete.
1722         (bl_address_is_meaningful): New.
1723         (breakpoint_locations_match): Adjust comment.
1724         (bp_location_from_bp_type): New, factored out of...
1725         (bp_location::bp_location(breakpoint *)): ... this.
1726         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1727         factored out of...
1728         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1729         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1730         breakpoint_address_is_meaningful.
1731         (bp_locations_compare): Adjust comment.
1732         (update_global_location_list): Use bl_address_is_meaningful
1733         instead of breakpoint_address_is_meaningful.
1734         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1735         explicit.
1736         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1737         * python/py-breakpoint.c (bppy_get_location): No longer check
1738         whether location is null.
1739
1740 2019-07-09  Pedro Alves  <palves@redhat.com>
1741
1742         PR c++/15468
1743         * breakpoint.c (print_one_breakpoint_location): Remove
1744         single-location assert.
1745
1746 2019-07-09  Tom Tromey  <tom@tromey.com>
1747
1748         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1749         * configure: Rebuild.
1750         * configure.ac: Change common to gdbsupport.
1751         * gdbsupport: Rename from common.
1752         * acinclude.m4: Change common to gdbsupport.
1753         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1754         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1755         gdbsupport.
1756         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1757         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1758         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1759         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1760         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1761         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1762         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1763         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1764         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1765         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1766         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1767         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1768         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1769         coff-pe-read.c, command.h, compile/compile-c-support.c,
1770         compile/compile-c.h, compile/compile-cplus-symbols.c,
1771         compile/compile-cplus-types.c, compile/compile-cplus.h,
1772         compile/compile-loc2c.c, compile/compile.c, completer.c,
1773         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1774         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1775         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1776         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1777         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1778         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1779         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1780         features/aarch64-core.c, features/aarch64-fpu.c,
1781         features/aarch64-pauth.c, features/aarch64-sve.c,
1782         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1783         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1784         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1785         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1786         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1787         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1788         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1789         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1790         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1791         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1792         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1793         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1794         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1795         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1796         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1797         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1798         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1799         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1800         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1801         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1802         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1803         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1804         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1805         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1806         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1807         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1808         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1809         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1810         minsyms.c, mips-linux-tdep.c, namespace.h,
1811         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1812         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1813         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1814         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1815         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1816         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1817         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1818         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1819         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1820         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1821         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1822         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1823         procfs.c, producer.c, progspace.h, psymtab.h,
1824         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1825         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1826         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1827         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1828         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1829         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1830         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1831         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1832         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1833         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1834         target-memory.c, target.c, target.h, target/waitstatus.c,
1835         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1836         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1837         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1838         unittests/array-view-selftests.c,
1839         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1840         unittests/common-utils-selftests.c,
1841         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1842         unittests/format_pieces-selftests.c,
1843         unittests/function-view-selftests.c,
1844         unittests/lookup_name_info-selftests.c,
1845         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1846         unittests/mkdir-recursive-selftests.c,
1847         unittests/observable-selftests.c,
1848         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1849         unittests/parse-connection-spec-selftests.c,
1850         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1851         unittests/scoped_fd-selftests.c,
1852         unittests/scoped_mmap-selftests.c,
1853         unittests/scoped_restore-selftests.c,
1854         unittests/string_view-selftests.c, unittests/style-selftests.c,
1855         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1856         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1857         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1858         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1859         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1860         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1861
1862 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1863
1864         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1865         bool value.
1866         (decode_digits_ordinary): Set explicit_line field in sal.
1867         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1868         symtab_and_line that was set on an explicit line number in
1869         assembler code.  Do always update the recorded symtab and line if
1870         we do skip the prologue.
1871
1872 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1873
1874         * breakpoint.c (set_breakpoint_location_function): Remove
1875         explicit_loc parameter.
1876         (momentary_breakpoint_from_master): Update call to
1877         set_breakpoint_location_function.
1878         (add_location_to_breakpoint): Likewise.
1879
1880 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1881
1882         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1883         required features based on default bfd type when no specific bfd
1884         is present.
1885
1886 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1887
1888         * NEWS: Mention that GDB printf and eval commands can now print
1889         C-style and Ada-style convenience var strings without
1890         calling the inferior.
1891         * printcmd.c (printf_c_string): Locally print GDB internal var
1892         instead of transiting via the inferior.
1893         (printf_wide_c_string): Likewise.
1894
1895 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1896
1897         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1898
1899 2019-07-04  Tom Tromey  <tom@tromey.com>
1900
1901         PR tui/24724:
1902         * tui/tui-winsource.c (tui_clear_source_content): Update.
1903         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1904         (tui_update_breakpoint_info): Update.
1905         (tui_set_exec_info_content): Update.
1906         * tui/tui-source.c (tui_set_source_content_nil): Update.
1907         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1908         has_break.
1909         * tui/tui-data.h (enum tui_bp_flag): New.
1910         (tui_bp_flags): New enum flags type.
1911         (struct tui_source_element) <break_mode>: Change type.  Rename
1912         from has_break.
1913         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1914         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1915         constants.
1916         * tui/tui-winsource.h: Fix comment.
1917
1918 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1919
1920         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1921         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1922         (store_fpregs_to_thread)
1923         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1924         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1925         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1926         (IWMMXT_REGS_SIZE): Add define.
1927         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1928         (fetch_vfp_regs, store_vfp_regs)
1929         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1930         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1931
1932 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1933
1934         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1935         defines.
1936         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1937         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1938         (ARM_INT_REGISTER_SIZE): ...to this.
1939         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1940         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1941         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1942         (arm_linux_collect_gregset, supply_nwfpe_register)
1943         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1944         defines.
1945         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1946         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1947         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1948         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1949         (arm_return_in_memory, arm_store_return_value)
1950         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1951         (arm_record_ld_st_multiple): Likewise.
1952         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1953         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1954
1955 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1956
1957         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1958         AARCH64_DISPLACED_MODIFIED_INSNS.
1959         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1960         (aarch64_displaced_step_copy_insn): Likewise.
1961         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1962         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1963         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1964         ARM_DISPLACED_MODIFIED_INSNS.
1965         * arm-tdep.c (arm_gdbarch_init): Likewise.
1966         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1967         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1968         (struct arm_displaced_step_closure): Use
1969         ARM_DISPLACED_MODIFIED_INSNS.
1970
1971 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1972
1973         * features/Makefile: Remove unused xml files.
1974         * features/aarch64.xml: Remove.
1975         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1976         * features/i386/amd64-avx-avx512.xml: Remove.
1977         * features/i386/amd64-avx-linux.xml: Remove.
1978         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1979         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1980         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1981         * features/i386/amd64-avx-mpx.xml: Remove.
1982         * features/i386/amd64-avx.xml: Remove.
1983         * features/i386/amd64-linux.xml: Remove.
1984         * features/i386/amd64-mpx-linux.xml: Remove.
1985         * features/i386/amd64-mpx.xml: Remove.
1986         * features/i386/amd64.xml: Remove.
1987         * features/i386/i386-avx-avx512-linux.xml: Remove.
1988         * features/i386/i386-avx-avx512.xml: Remove.
1989         * features/i386/i386-avx-linux.xml: Remove.
1990         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1991         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1992         * features/i386/i386-avx-mpx-linux.xml: Remove.
1993         * features/i386/i386-avx-mpx.xml: Remove.
1994         * features/i386/i386-avx.xml: Remove.
1995         * features/i386/i386-linux.xml: Remove.
1996         * features/i386/i386-mmx-linux.xml: Remove.
1997         * features/i386/i386-mmx.xml: Remove.
1998         * features/i386/i386-mpx-linux.xml: Remove.
1999         * features/i386/i386-mpx.xml: Remove.
2000         * features/i386/i386.xml: Remove.
2001         * features/i386/x32-avx-avx512-linux.xml: Remove.
2002         * features/i386/x32-avx-linux.xml: Remove.
2003         * features/i386/x32-linux.xml: Remove.
2004
2005 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2006
2007         * regformats/aarch64.dat: Remove.
2008         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2009         * regformats/i386/amd64-avx-linux.dat: Remove.
2010         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2011         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2012         * regformats/i386/amd64-linux.dat: Remove.
2013         * regformats/i386/amd64-mpx-linux.dat: Remove.
2014         * regformats/i386/amd64.dat: Remove.
2015         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2016         * regformats/i386/i386-avx-linux.dat: Remove.
2017         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2018         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2019         * regformats/i386/i386-linux.dat: Remove.
2020         * regformats/i386/i386-mmx-linux.dat: Remove.
2021         * regformats/i386/i386-mpx-linux.dat: Remove.
2022         * regformats/i386/i386.dat: Remove.
2023         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2024         * regformats/i386/x32-avx-linux.dat: Remove.
2025         * regformats/i386/x32-linux.dat: Remove.
2026
2027 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2028
2029         * aarch64-tdep.c: Remove xml self tests.
2030         * amd64-linux-tdep.c: Likewise.
2031         * amd64-tdep.c: Likewise.
2032         * i386-linux-tdep.c: Likewise.
2033         * i386-tdep.c: Likewise.
2034
2035 2019-07-03  Pedro Alves  <palves@redhat.com>
2036
2037         PR cli/24732
2038         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2039         (pipe_cmd_option_defs): New.
2040         (make_pipe_cmd_options_def_group): New.
2041         (pipe_command): Use gdb::option::process_options.
2042         (pipe_command_completer): New function.
2043         (_initialize_cli_cmds): Install completer for "pipe" command.
2044
2045 2019-07-03  Pedro Alves  <palves@redhat.com>
2046
2047         * cli/cli-option.c (union option_value) <string>: New field.
2048         (struct option_def_and_value): Add ctor, move ctor, dtor and
2049         use DISABLE_COPY_AND_ASSIGN.
2050         (option_def_and_value::clear_value): New.
2051         (parse_option, save_option_value_in_ctx, get_val_type_str)
2052         (add_setshow_cmds_for_options): Handle var_string.
2053         * cli-option.h (union option_def::var_address) <string>: New
2054         field.
2055         (struct string_option_def): New.
2056         * maint-test-options.c (struct test_options_opts): Add default
2057         ctor and use DISABLE_COPY_AND_ASSIGN.
2058         <string_opt>: New field.
2059         (test_options_opts::~test_options_opts): New.
2060         (test_options_opts::dump): Also dump "-string".
2061         (test_options_option_defs): Install "string.
2062
2063 2019-07-03  Pedro Alves  <palves@redhat.com>
2064
2065         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2066         option_value with a null enumeration.
2067         (complete_options): Save the option values in the context.
2068         (save_option_value_in_ctx): New, factored out from ...
2069         (process_options): ... here.
2070         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2071         of the function.
2072         * maint-test-options.c (test_options_opts::dump): New, factored
2073         out from ...
2074         (maintenance_test_options_command_mode): ... here.
2075         (maintenance_test_options_command_completion_result): Delete.
2076         (maintenance_test_options_command_completion_text): Update
2077         comment.
2078         (maintenance_show_test_options_completion_result): Change
2079         prototype.  Just print
2080         maintenance_test_options_command_completion_text.
2081         (save_completion_result): New.
2082         (maintenance_test_options_completer_mode): Pass options context to
2083         complete_options, and then save a dump.
2084         (_initialize_maint_test_options): Use add_cmd to install "maint
2085         show test-options-completion-result".
2086
2087 2019-07-03  Pedro Alves  <palves@redhat.com>
2088
2089         * NEWS (New commands): Mention "with" and "maint with".
2090         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2091         (with_command, with_command_completer): New.
2092         (pipe_command): Adjust to new repeat_previous
2093         interface.
2094         (_initialize_cli_cmds): Install the "with" command and its "w"
2095         alias.
2096         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2097         declarations.
2098         * cli/cli-setshow.c (parse_cli_var_uinteger)
2099         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2100         argument strings for all var_types.
2101         (get_setshow_command_value_string): New, factored out from ...
2102         (do_show_command): ... this.
2103         * cli/cli-setshow.h: Include <string>.
2104         (get_setshow_command_value_string): Declare.
2105         * command.h (repeat_previous): Now returns const char *.  Adjust
2106         comment.
2107         * maint.c: Include "cli/cli-cmds.h".
2108         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2109         (_initialize_maint_cmds): Register the "maintenance with" command.
2110         * top.c (repeat_previous): Move bits from pipe_command here:
2111         Return the saved command line, if any; error out if there's no
2112         command to relaunch.
2113
2114 2019-07-03  Pedro Alves  <palves@redhat.com>
2115
2116         * NEWS (New commands): Mention "maint set/show test-settings"
2117         instead of "maint test-settings".
2118         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2119         (maintenance_test_settings_set_list): Rename to ...
2120         (maintenance_set_test_settings_list): ... this.
2121         (maintenance_test_settings_show_list): Rename to  ...
2122         (maintenance_show_test_settings_list): ... this.
2123         (maintenance_test_settings_cmd): Delete.
2124         (maintenance_test_settings_set_cmd): ...
2125         (maintenance_set_test_settings_cmd): ... this.
2126         (maintenance_test_settings_show_cmd): ...
2127         (maintenance_show_test_settings_cmd): ... this.
2128         (maintenance_test_settings_show_value_cmd):
2129         (maintenance_show_test_settings_value_cmd): ... this.
2130         (_initialize_maint_test_settings): No longer install the "maint
2131         test-settings" prefix command.  Rename "maint test-settings set"
2132         to "maint set test-settings", and "maint test-settings show" to
2133         "maint show test-settings".  Adjust all subcommands.
2134
2135 2019-07-03  Pedro Alves  <palves@redhat.com>
2136
2137         * maint-test-settings.c: Fix file's intro comment.  Replace all
2138         references to "test-options" with references to "test-settings",
2139         in comments.
2140
2141 2019-07-03  Pedro Alves  <palves@redhat.com>
2142
2143         * maint-test-settings.c (maintenance_test_settings_xxx)
2144         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2145         New.
2146         (maintenance_test_settings_enums): Use them.
2147         (maintenance_test_settings_enum): Default to
2148         maintenance_test_settings_xxx.
2149         (_initialize_maint_test_settings): Initialize
2150         MAINTENANCE_TEST_SETTINGS_FILENAME.
2151
2152 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2153
2154         * breakpoint.h (remove_breakpoints_inf): Change return type to
2155         void, move function documentation here.
2156         * breakpoint.c (remove_breakpoints_inf): Change return type to
2157         void, move function documentation to header.
2158
2159 2019-07-02  Pedro Alves  <palves@redhat.com>
2160
2161         * NEWS (Completion improvements): Mention "info threads".
2162         * thread.c (struct info_threads_opts, info_threads_option_defs)
2163         (make_info_threads_options_def_group): New.
2164         (info_threads_command): Use gdb::option::process_options.
2165         (info_threads_command_completer): New.
2166         (_initialize_thread): Use gdb::option::build_help to build the
2167         help text for "info threads".
2168
2169 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2170
2171         * defs.h (generic_load): Move from here...
2172         * symfile.h (generic_load): ... to here.  Rename name parameter
2173         to args.
2174         * symfile.c (generic_load): Add comment.
2175
2176 2019-07-01  Tom Tromey  <tromey@adacore.com>
2177
2178         * dwarf2read.c
2179         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2180         declaration of without_params.  Fix formatting.
2181
2182 2019-07-01  Tom Tromey  <tromey@adacore.com>
2183
2184         * ada-exp.y (find_primitive_type): Update.
2185         * ada-lang.h (ada_lookup_symbol): Update.
2186         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2187         parameter.
2188         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2189
2190 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2191
2192         PR breakpoints/24541
2193         * gdbarch.c: Regenerate.
2194         * gdbarch.h: Regenerate.
2195         * gdbarch.sh: Add 'stap_adjust_register'.
2196         * i386-tdep.c: Include '<unordered_set>'.
2197         (i386_stap_adjust_register): New function.
2198         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2199         * stap-probe.c (stap_parse_register_operand): Call
2200         'gdbarch_stap_adjust_register'.
2201
2202 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2203
2204         PR python/24742
2205         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2206         * python/python.c (do_start_initialization): Use 'xmalloc'
2207         instead of 'PyMem_Malloc'.
2208
2209 2019-06-28  Tom Tromey  <tromey@adacore.com>
2210
2211         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2212         for Ada.
2213
2214 2019-06-27  Tom Tromey  <tromey@adacore.com>
2215
2216         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2217         objfile_key.
2218         (arm_find_mapping_symbol, arm_record_special_symbol)
2219         (_initialize_arm_tdep): Update.
2220         (arm_objfile_data_free): Remove.
2221
2222 2019-06-27  Tom Tromey  <tromey@adacore.com>
2223
2224         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2225         to cp_print_static_field.
2226
2227 2019-06-26  Tom Tromey  <tromey@adacore.com>
2228
2229         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2230         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2231         declare.
2232
2233 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2234
2235         * features/aarch64-core.c (create_feature_aarch64_core):
2236         Regenerate.
2237         * features/aarch64-core.xml: Add cpsr flags.
2238
2239 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2240
2241         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2242         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2243
2244 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2245
2246         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2247         field.
2248         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2249         use.
2250         (arm_record_special_symbol): Don't insert new symbol in sorted
2251         position, push it at the end.
2252
2253 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2254
2255         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2256         (arm_mapping_symbol_s): Remove.
2257         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2258         (arm_mapping_symbol_vec): New typedef.
2259         (struct arm_per_objfile): Add constructor.
2260         <section_maps>: Change type to
2261         std::unique_ptr<arm_mapping_symbol_vec[]>.
2262         (arm_compare_mapping_symbols): Remove.
2263         (arm_find_mapping_symbol): Adjust to section_maps type change.
2264         (arm_objfile_data_free): Call delete on arm_per_objfile.
2265         (arm_record_special_symbol): Adjust to section_maps type change.
2266         Allocate arm_per_objfile with new.
2267
2268 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2269
2270         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2271         with the command prefix.
2272
2273 2019-06-25  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2276         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2277
2278 2019-06-25  Tom Tromey  <tom@tromey.com>
2279
2280         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2281         type.
2282         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2283         protected.
2284
2285 2019-06-25  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-winsource.c
2288         (tui_source_window_base::set_is_exec_point_at): Add check against
2289         LOA_ADDRESS.
2290
2291 2019-06-25  Tom Tromey  <tom@tromey.com>
2292
2293         * tui/tui-source.c (tui_set_source_content): Don't check before
2294         xfree.
2295         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2296
2297 2019-06-25  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-winsource.h (tui_update_source_window_as_is)
2300         (tui_alloc_source_buffer, tui_line_is_displayed)
2301         (tui_addr_is_displayed): Change type of win_info.
2302         * tui/tui-winsource.c (tui_update_source_window_as_is)
2303         (tui_clear_source_content, tui_show_source_line)
2304         (tui_show_source_content, tui_source_window_base::refill)
2305         (tui_source_window_base::set_is_exec_point_at)
2306         (tui_source_window_base::set_is_exec_point_at)
2307         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2308         (tui_alloc_source_buffer, tui_line_is_displayed)
2309         (tui_addr_is_displayed): Change type of win_info.  Update.
2310         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2311         (tui_source_window_base::do_make_visible_with_new_height):
2312         Update.
2313         * tui/tui-source.c (tui_set_source_content)
2314         (tui_set_source_content_nil)
2315         (tui_source_window::do_scroll_vertical): Update.
2316         * tui/tui-layout.c (show_layout): Update.
2317         * tui/tui-disasm.c (tui_set_disassem_content)
2318         (tui_disasm_window::do_scroll_vertical): Update.
2319         * tui/tui-data.h (tui_win_content): Remove.
2320         (struct tui_gen_win_info) <content, content_size>: Remove.
2321         (struct tui_source_element): Add initializers and destructor.
2322         (union tui_which_element, struct tui_win_element): Remove.
2323         (struct tui_source_window_base) <content>: New field.
2324         (struct tui_data_window): Remove destructor.
2325         (tui_alloc_content, tui_free_win_content)
2326         (tui_free_all_source_wins_content): Don't declare.
2327         * tui/tui-data.c (tui_initialize_static_data): Update.
2328         (init_content_element, tui_alloc_content): Remove.
2329         (~tui_gen_win_info): Update.
2330         (~tui_data_window, tui_free_all_source_wins_content)
2331         (tui_free_win_content, free_content, free_content_elements):
2332         Remove.
2333
2334 2019-06-25  Tom Tromey  <tom@tromey.com>
2335
2336         * tui/tui-winsource.h (tui_clear_source_content)
2337         (tui_erase_source_content, tui_show_source_content): Change type
2338         of win_info.
2339         * tui/tui-winsource.c (tui_clear_source_content)
2340         (tui_erase_source_content, tui_show_source_content): Change type
2341         of win_info.
2342         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2343         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2344         win_info.
2345         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2346         win_info.
2347         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2348
2349 2019-06-25  Tom Tromey  <tom@tromey.com>
2350
2351         * tui/tui-winsource.c (tui_clear_source_content)
2352         (tui_source_window_base::set_is_exec_point_at): Update.
2353         * tui/tui-source.c (tui_set_source_content_nil): Update.
2354         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2355         a bool.
2356         * tui/tui-data.c (init_content_element): Update.
2357
2358 2019-06-25  Tom Tromey  <tom@tromey.com>
2359
2360         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2361         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2362         * tui/tui-layout.c (init_and_make_win): Update.
2363         * tui/tui.h (enum tui_win_type): Update.
2364         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2365         tui_win_is_auxillary.
2366         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2367         tui_win_is_auxillary.
2368
2369 2019-06-25  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2372         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2373         (tui_delete_data_content_windows, tui_display_all_data)
2374         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2375         Update.
2376         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2377         * tui/tui-regs.c (tui_last_regs_line_no)
2378         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2379         (tui_show_registers): Update.
2380         (tui_show_register_group): Return void.  Update.
2381         (tui_display_registers_from, tui_display_reg_element_at_line)
2382         (tui_display_registers_from_line, tui_check_register_values):
2383         Update.
2384         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2385         member.
2386         (struct tui_data_window) <regs_content>: Now a std::vector.
2387         <regs_content_count>: Remove.
2388         (tui_add_content_elements, tui_free_data_content): Don't declare.
2389         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2390         (init_content_element): Remove DATA_WIN case.  Add assert.
2391         (tui_add_content_elements): Remove.
2392         (tui_data_window): Update.
2393         (tui_free_data_content): Remove.
2394         (free_content_elements): Remove DATA_WIN case.
2395
2396 2019-06-25  Tom Tromey  <tom@tromey.com>
2397
2398         * tui/tui-data.c (tui_data_item_window): Update.
2399         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2400         * tui/tui-windata.c (tui_display_all_data)
2401         (tui_display_data_from_line): Update.
2402         (tui_check_data_values): Remove.
2403         * tui/tui-regs.c (tui_show_register_group)
2404         (tui_display_reg_element_at_line): Update.
2405         * tui/tui-hooks.c (tui_register_changed)
2406         (tui_refresh_frame_and_register_information): Call
2407         tui_check_register_values.
2408         * tui/tui-data.h (struct tui_data_window) <data_content,
2409         data_content_count, data_type>: Remove.
2410         (enum tui_data_type): Remove.
2411
2412         * tui/tui-data.c (tui_data_window::clear_detail)
2413         (~tui_data_window): Update.
2414
2415 2019-06-25  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2418         declare.
2419         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2420         Rename from tui_first_data_item_displayed.  Update.
2421         (tui_data_window::refresh_all)
2422         (tui_data_window::do_scroll_vertical): Update.
2423         * tui/tui-data.h (struct tui_data_window)
2424         <first_data_item_displayed>: Declare new method.
2425
2426 2019-06-25  Tom Tromey  <tom@tromey.com>
2427
2428         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2429         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2430         contents...
2431         (tui_initialize_static_data): ...here.
2432
2433 2019-06-25  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2436         (tui_display_registers_from, tui_check_register_values): Update.
2437         (tui_display_register): Remove win_info parameter; update.
2438         (tui_get_register): Change type of parameters.
2439         * tui/tui-data.h (struct tui_data_element): Remove.
2440         (union tui_which_element) <data>: Remove.
2441         <data_window>: Change type.
2442         (struct tui_data_item_window): New.
2443         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2444         case.  Add assert.
2445         (~tui_data_item_window): New destructor.
2446         (free_content_elements): Remove DATA_ITEM_WIN case.
2447
2448 2019-06-25  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2451         Remove.
2452
2453 2019-06-25  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui-data.h (struct tui_command_element): Remove.
2456         (union tui_which_element) <command>: Remove.
2457         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2458         assert.
2459         (free_content_elements): Remove CMD_WIN case.
2460
2461 2019-06-25  Tom Tromey  <tom@tromey.com>
2462
2463         * tui/tui-layout.c (tui_set_layout): Update.
2464         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2465         * tui/tui-data.c (layout_def): Update.
2466
2467 2019-06-25  Tom Tromey  <tom@tromey.com>
2468
2469         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2470         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2471         (tui_source_window_base::set_new_height): Update.
2472         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2473         Update.
2474         (tui_set_locator_fullname, tui_set_locator_info)
2475         (tui_show_frame_info): Update.
2476         * tui/tui-source.c (tui_set_source_content)
2477         (tui_source_is_displayed): Update.
2478         * tui/tui-layout.c (show_source_disasm_command, show_data)
2479         (show_source_or_disasm_and_command): Update.
2480         * tui/tui-disasm.c (tui_set_disassem_content)
2481         (tui_get_begin_asm_address): Update.
2482         * tui/tui-data.h (struct tui_locator_element): Remove.
2483         (union tui_which_element) <locator>: Remove.
2484         (struct tui_locator_window): New.
2485         (tui_locator_win_info_ptr): Change return type.
2486         * tui/tui-data.c (_locator): Change type.
2487         (tui_locator_win_info_ptr): Change return type.
2488         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2489         (tui_alloc_content): Add assert.
2490
2491 2019-06-25  Tom Tromey  <tom@tromey.com>
2492
2493         * tui/tui-winsource.c
2494         (tui_exec_info_window::maybe_allocate_content): New method.
2495         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2496         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2497         (make_source_or_disasm_window): Add cast.
2498         * tui/tui-data.h (union tui_which_element) <simple_string>:
2499         Remove.
2500         (struct tui_source_info): New.
2501         (struct tui_source_window_base) <execution_info>: Change type.
2502         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2503         case, and add assert.
2504         (tui_alloc_content): Add assert.
2505
2506 2019-06-25  Tom Tromey  <tom@tromey.com>
2507
2508         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2509         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2510         * tui/tui-data.c (tui_alloc_win_info): Remove.
2511
2512 2019-06-25  Tom Tromey  <tom@tromey.com>
2513
2514         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2515         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2516         can_highlight.
2517
2518 2019-06-25  Tom Tromey  <tom@tromey.com>
2519
2520         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2521         make_visible_with_new_height method.
2522         (tui_win_info::make_visible_with_new_height): New method.
2523         (tui_source_window_base::do_make_visible_with_new_height)
2524         (tui_data_window::do_make_visible_with_new_height)
2525         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2526         (make_visible_with_new_height): Remove.
2527         (tui_resize_all, tui_adjust_win_heights): Use
2528         make_visible_with_new_height method.
2529         * tui/tui-data.h (struct tui_win_info)
2530         <do_make_visible_with_new_height, make_visible_with_new_height>:
2531         New methods.
2532         (struct tui_source_window_base, struct tui_data_window)
2533         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2534         methods.
2535
2536 2019-06-25  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2539         method.
2540         (update_tab_width): Call update_tab_width method.
2541         * tui/tui-data.h (struct tui_win_info)
2542         (struct tui_source_window_base) <update_tab_width>: New methods.
2543
2544 2019-06-25  Tom Tromey  <tom@tromey.com>
2545
2546         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2547         parameter.
2548         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2549         parameter.
2550         (tui_gen_win_info::make_visible): Update.
2551         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2552         parameter.
2553         * tui/tui-data.h (enum tui_box): New enum.
2554         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2555
2556 2019-06-25  Tom Tromey  <tom@tromey.com>
2557
2558         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2559         init_and_make_win for EXEC_INFO_WIN.
2560         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2561         longer inline.
2562         (struct tui_win_info) <~tui_win_info>: Inline.
2563         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2564         Don't declare.
2565         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2566         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2567         Remove.
2568         (tui_initialize_static_data): Update.
2569         (~tui_gen_win_info): Handle more cleanup here.
2570         (~tui_source_window_base): Delete "execution_info".
2571         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2572
2573 2019-06-25  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-layout.c (make_command_window): Don't set
2576         can_highlight.
2577         (show_source_disasm_command): Call the reset method.
2578         (show_data): Don't set can_highlight.  Call the reset method.
2579         (tui_gen_win_info::reset): Rename from init_gen_win_info
2580         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2581         (show_source_or_disasm_and_command): Call the reset method.
2582         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2583         (struct tui_cmd_window): Set can_highlight.
2584
2585 2019-06-25  Tom Tromey  <tom@tromey.com>
2586
2587         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2588         from make_visible.
2589         (tui_make_visible, tui_make_invisible): Rewrite.
2590         (tui_win_info::make_visible): Remove.
2591         (tui_source_window_base::make_visible): Update.
2592         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2593         method.  Moved from...
2594         (struct tui_win_info) <make_visible>: ...here.
2595
2596 2019-06-25  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-winsource.c
2599         (tui_source_window_base::do_scroll_horizontal): Remove direction
2600         parameter.
2601         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2602         direction parameter.
2603         * tui/tui-win.c (tui_win_info::forward_scroll)
2604         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2605         (tui_win_info::right_scroll): Update.
2606         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2607         direction parameter.
2608         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2609         direction parameter.
2610         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2611         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2612         Remove direction parameter.
2613         (struct tui_source_window_base, struct tui_source_window)
2614         (struct tui_disasm_window, struct tui_data_window)
2615         (struct tui_cmd_window): Update.
2616
2617 2019-06-25  Tom Tromey  <tom@tromey.com>
2618
2619         * tui/tui-winsource.h (tui_set_exec_info_content)
2620         (tui_show_exec_info_content, tui_erase_exec_info_content)
2621         (tui_clear_exec_info_content, tui_update_exec_info): Change
2622         argument to tui_source_window_base.
2623         * tui/tui-winsource.c (tui_set_exec_info_content)
2624         (tui_show_exec_info_content, tui_erase_exec_info_content)
2625         (tui_clear_exec_info_content, tui_update_exec_info): Change
2626         argument to tui_source_window_base.
2627
2628 2019-06-25  Tom Tromey  <tom@tromey.com>
2629
2630         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2631         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2632
2633 2019-06-25  Tom Tromey  <tom@tromey.com>
2634
2635         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2636         check.
2637
2638 2019-06-25  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2641         type to void.
2642         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2643         type to void.
2644         * tui/tui-source.c (tui_set_source_content): Update.
2645         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2646
2647 2019-06-25  Tom Tromey  <tom@tromey.com>
2648
2649         * tui/tui-win.c (window_name_completer, tui_set_focus)
2650         (tui_all_windows_info): Use name method.
2651         * tui/tui-data.h (struct tui_gen_win_info)
2652         (struct tui_source_window, struct tui_disasm_window)
2653         (struct tui_data_window, struct tui_cmd_window) <name>: New
2654         method.
2655         (tui_win_name): Don't declare.
2656         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2657         (tui_win_name): Remove.
2658
2659 2019-06-25  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-winsource.h (tui_update_source_window)
2662         (tui_update_source_window_as_is): Change parameter type.
2663         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2664         to be a tui_source_window_base.
2665         (tui_update_source_window_as_is): Likewise.
2666         * tui/tui-win.c (make_visible_with_new_height): Update.
2667
2668 2019-06-25  Tom Tromey  <tom@tromey.com>
2669
2670         * tui/tui-winsource.c (tui_erase_source_content)
2671         (tui_show_source_content, tui_show_exec_info_content)
2672         (tui_erase_exec_info_content): Use refresh_window method.
2673         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2674         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2675         from tui_refresh_win.
2676         (tui_data_window::refresh_window): New method.
2677         (tui_win_info::refresh, tui_source_window_base::refresh)
2678         (tui_refresh_all): Use refresh_window method.
2679         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2680         method.
2681         * tui/tui-regs.c (tui_display_register): Call refresh_window
2682         method.
2683         * tui/tui-layout.c (show_source_disasm_command)
2684         (show_source_or_disasm_and_command): Call refresh_window method.
2685         * tui/tui-data.h (struct tui_gen_win_info)
2686         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2687         New method.
2688
2689 2019-06-25  Tom Tromey  <tom@tromey.com>
2690
2691         * tui/tui.c (tui_rl_other_window, tui_enable)
2692         (tui_is_window_visible, tui_get_command_dimension): Update.
2693         * tui/tui-winsource.c (tui_update_source_window_as_is)
2694         (tui_clear_source_content, tui_erase_source_content)
2695         (tui_show_source_line, tui_source_window_base::refill)
2696         (tui_source_window_base::do_scroll_horizontal)
2697         (tui_source_window_base::set_is_exec_point_at)
2698         (tui_update_breakpoint_info, tui_set_exec_info_content)
2699         (tui_alloc_source_buffer, tui_line_is_displayed)
2700         (tui_addr_is_displayed): Update.
2701         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2702         (tui_check_and_display_highlight_if_needed)
2703         (tui_win_info::make_visible, tui_win_info::refresh)
2704         (tui_refresh_all): Update.
2705         * tui/tui-windata.c (tui_first_data_item_displayed)
2706         (tui_delete_data_content_windows, tui_erase_data_content)
2707         (tui_display_all_data, tui_data_window::refresh_all)
2708         (tui_check_data_values): Update.
2709         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2710         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2711         (tui_win_info::backward_scroll, tui_refresh_all_win)
2712         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2713         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2714         (tui_source_window_base::set_new_height)
2715         (tui_data_window::set_new_height)
2716         (make_invisible_and_set_new_height)
2717         (make_visible_with_new_height, new_height_ok)
2718         (parse_scrolling_args): Update.
2719         * tui/tui-stack.c (tui_show_frame_info): Update.
2720         * tui/tui-source.c (tui_set_source_content)
2721         (tui_set_source_content_nil, tui_source_is_displayed)
2722         (tui_source_window::do_scroll_vertical): Update.
2723         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2724         (tui_display_registers_from, tui_display_reg_element_at_line)
2725         (tui_check_register_values, tui_reg_command): Update.
2726         * tui/tui-layout.c (tui_default_win_height)
2727         (show_source_disasm_command, show_data, init_and_make_win)
2728         (show_source_or_disasm_and_command): Update.
2729         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2730         (tui_redisplay_readline, tui_mld_flush)
2731         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2732         (tui_getc): Update.
2733         * tui/tui-disasm.c (tui_set_disassem_content)
2734         (tui_disasm_window::do_scroll_vertical): Update.
2735         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2736         Now virtual.
2737         (struct tui_win_info): Derive from tui_gen_win_info.
2738         <~tui_win_info>: Mark as override.
2739         <generic>: Remove member.
2740         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2741         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2742         (~tui_data_window, ~tui_win_info)
2743         (tui_free_all_source_wins_content): Update.
2744         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2745
2746 2019-06-25  Tom Tromey  <tom@tromey.com>
2747
2748         * tui/tui-layout.c (init_and_make_win): Use new.
2749         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2750         destructor, initializers.
2751         (tui_alloc_generic_win_info): Don't declare.
2752         * tui/tui-data.c (_locator): Add argument to constructor.
2753         (source_win, disasm_win): New globals.
2754         (exec_info): Remove.
2755         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2756         Update.
2757         (tui_alloc_generic_win_info): Remove.
2758         (init_content_element): Use new.
2759         (tui_win_info::tui_win_info): Update.
2760         (free_content_elements) <case DATA_WIN>: Use delete.
2761
2762 2019-06-25  Tom Tromey  <tom@tromey.com>
2763
2764         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2765         * tui/tui-windata.c (tui_first_data_item_displayed)
2766         (tui_delete_data_content_windows): Update.
2767         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2768         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2769         (tui_display_registers_from, tui_check_register_values): Update.
2770         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2771         pointer.
2772         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2773         window.
2774         (tui_free_data_content): Update.
2775         (free_content_elements) <case DATA_WIN>: Free the window.
2776
2777 2019-06-25  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2780         Update.
2781         * tui/tui-layout.c (make_command_window)
2782         (show_source_disasm_command, show_data, init_and_make_win)
2783         (show_source_or_disasm_and_command): Update.
2784         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2785         method.
2786         <can_highight, is_highlighted>: Now bool.
2787         (tui_set_win_highlight): Don't declare.
2788         * tui/tui-data.c (tui_set_win_highlight): Remove.
2789
2790 2019-06-25  Tom Tromey  <tom@tromey.com>
2791
2792         * tui/tui-wingeneral.c (make_visible): Remove check of window
2793         type.
2794
2795 2019-06-25  Tom Tromey  <tom@tromey.com>
2796
2797         * tui/tui-win.c (tui_win_info::max_height)
2798         (tui_cmd_window::max_height): New methods.
2799         (new_height_ok): Call max_height.
2800         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2801         <max_height>: New method.
2802
2803 2019-06-25  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui-win.c (tui_source_window_base::set_new_height)
2806         (tui_data_window::set_new_height): New methods.
2807         (make_invisible_and_set_new_height): Call set_new_height method.
2808         * tui/tui-data.h (struct tui_win_info)
2809         (struct tui_source_window_base, struct tui_data_window)
2810         <set_new_height>: New method.
2811
2812 2019-06-25  Tom Tromey  <tom@tromey.com>
2813
2814         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2815         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2816         tui_refresh_data_win.
2817         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2818         method.
2819         (tui_refresh_all_win): Call the refresh_all method.
2820         (tui_set_focus): Likewise.
2821         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2822         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2823         Likewise.
2824
2825 2019-06-25  Tom Tromey  <tom@tromey.com>
2826
2827         * tui/tui-winsource.h (tui_refill_source_window)
2828         (tui_set_is_exec_point_at): Don't declare.
2829         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2830         (tui_source_window_base::refill): Rename from
2831         tui_refill_source_window.
2832         (tui_source_window_base::do_scroll_horizontal): Update.
2833         (tui_source_window_base::set_is_exec_point_at): Rename from
2834         tui_set_is_exec_point_at.
2835         (tui_update_all_breakpoint_info): Update.
2836         * tui/tui-stack.c (tui_show_frame_info): Update.
2837         * tui/tui-layout.c (show_data): Add cast.
2838         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2839         * tui/tui-data.h (struct tui_source_window_base) <refill,
2840         set_is_exec_point_at>: New methods.
2841         (tui_source_windows, tui_add_to_source_windows): Update types.
2842         (tui_add_to_source_windows): Remove redundant declaration.
2843         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2844         (tui_source_windows): Change return type.
2845         (tui_clear_source_windows_detail): Update.
2846         (tui_add_to_source_windows): Change type of parameter.
2847         (tui_free_all_source_wins_content): Update.
2848
2849 2019-06-25  Tom Tromey  <tom@tromey.com>
2850
2851         * tui/tui-wingeneral.c (tui_win_info::refresh)
2852         (tui_source_window_base::refresh): New methods.
2853         (tui_refresh_all): Call the refresh method.
2854         * tui/tui-data.h (struct tui_win_info)
2855         (struct tui_source_window_base) <refresh>: New method.
2856
2857 2019-06-25  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui.h (tui_is_window_visible): Return bool.
2860         * tui/tui.c (tui_is_window_visible): Return bool.
2861         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2862         (tui_make_visible, tui_make_invisible)
2863         (tui_win_info::make_visible)
2864         (tui_source_window_base::make_visible, make_all_visible)
2865         (tui_make_all_visible, tui_make_all_invisible): Update.
2866         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2867         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2868         bool.
2869         (struct tui_win_info, struct tui_source_window_base)
2870         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2871         * tui/tui-data.c (tui_init_generic_part): Update.
2872
2873 2019-06-25  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2876         (tui_source_window_base::make_visible): New methods.
2877         (make_all_visible): Make method call.
2878         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2879         (struct tui_source_window_base, struct tui_cmd_window): Override
2880         make_visible.
2881         (tui_win_is_source_type): Don't declare.
2882         * tui/tui-data.c (tui_win_is_source_type): Remove.
2883
2884 2019-06-25  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2887         NULL check.
2888
2889 2019-06-25  Tom Tromey  <tom@tromey.com>
2890
2891         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2892         Inline constructor.  Add initializers for members.
2893         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2894         constructors; now inline in class.
2895
2896 2019-06-25  Tom Tromey  <tom@tromey.com>
2897
2898         * tui/tui-regs.c (tui_show_registers): Update.
2899         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2900         bool.
2901         * tui/tui-data.c (tui_data_window::clear_detail)
2902         (tui_data_window): Update.
2903
2904 2019-06-25  Tom Tromey  <tom@tromey.com>
2905
2906         * tui/tui-windata.c (tui_display_all_data)
2907         (tui_display_data_from_line, tui_display_data_from)
2908         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2909         Update.
2910         * tui/tui-regs.c (tui_last_regs_line_no)
2911         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2912         (tui_show_registers, tui_show_register_group)
2913         (tui_display_registers_from, tui_display_reg_element_at_line)
2914         (tui_display_registers_from_line, tui_check_register_values)
2915         (tui_reg_next, tui_reg_prev): Update.
2916         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2917         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2918         tui_data_window.
2919         (struct tui_win_info) <detail>: Remove.  Add new fields from
2920         tui_data_info.
2921         (TUI_DATA_WIN): Add cast.
2922         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2923         (~tui_data_window): Simplify.
2924
2925 2019-06-25  Tom Tromey  <tom@tromey.com>
2926
2927         * tui/tui-layout.c (show_source_disasm_command)
2928         (show_source_or_disasm_and_command): Update.
2929         * tui/tui-io.c (update_cmdwin_start_line)
2930         (tui_redisplay_readline): Update.
2931         * tui/tui-data.h (struct tui_command_info): Remove.
2932         (struct tui_win_info) <detail>: Remove command_info member.
2933         (struct tui_data_window) <start_line>: New member, from
2934         tui_command_info.
2935         (TUI_CMD_WIN): Add casts.
2936
2937 2019-06-25  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-winsource.c (tui_update_source_window)
2940         (tui_refill_source_window)
2941         (tui_source_window_base::do_scroll_horizontal)
2942         (tui_update_breakpoint_info, tui_set_exec_info_content)
2943         (tui_show_exec_info_content, tui_erase_exec_info_content)
2944         (tui_clear_exec_info_content): Update.
2945         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2946         Update.
2947         * tui/tui-win.c (make_invisible_and_set_new_height)
2948         (make_visible_with_new_height): Update.
2949         * tui/tui-source.c (tui_set_source_content)
2950         (tui_show_symtab_source): Update.
2951         * tui/tui-layout.c (extract_display_start_addr)
2952         (show_source_disasm_command, show_data)
2953         (make_source_or_disasm_window)
2954         (show_source_or_disasm_and_command): Update.
2955         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2956         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2957         "gdbarch".
2958         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2959         to tui_source_window_base.
2960         (struct tui_win_info) <detail>: Remove source_info member.
2961         (struct tui_source_window_base) <has_locator>: Inline.
2962         Move contents from tui_source_info; rename has_locator member to
2963         m_has_locator.
2964         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2965         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2966         header file.
2967         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2968         Simplify.
2969         (tui_free_all_source_wins_content): Cast to
2970         tui_source_window_base.
2971
2972 2019-06-25  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-win.c (make_invisible_and_set_new_height)
2975         (make_visible_with_new_height): Call has_locator method.
2976         * tui/tui-layout.c (show_source_disasm_command, show_data)
2977         (show_source_or_disasm_and_command): Update for bool change.
2978         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2979         (tui_win_info) <has_locator>: New method.
2980         (struct tui_source_window_base) <has_locator>: New method.
2981         (tui_win_has_locator): Don't declare.
2982         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2983         from tui_win_has_locator.
2984         (tui_source_window_base): Use false, not FALSE.
2985
2986 2019-06-25  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2989         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2990         clear_detail method directly.
2991         (tui_clear_win_detail): Remove.
2992
2993 2019-06-25  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2996         "this", not TUI_DISASM_WIN.
2997
2998 2019-06-25  Tom Tromey  <tom@tromey.com>
2999
3000         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3001         declare.
3002         * tui/tui-winsource.c
3003         (tui_source_window_base::do_scroll_horizontal): Rename from
3004         tui_horizontal_source_scroll.
3005         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3006         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3007         from tui_vertical_data_scroll.
3008         * tui/tui-win.h (tui_scroll): Don't declare.
3009         * tui/tui-win.c (tui_win_info::forward_scroll)
3010         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3011         (tui_win_info::right_scroll): Rename and update.
3012         (tui_scroll_forward_command, tui_scroll_backward_command)
3013         (tui_scroll_left_command, tui_scroll_right_command): Update.
3014         (tui_scroll): Remove.
3015         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3016         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3017         from tui_vertical_source_scroll.
3018         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3019         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3020         from tui_vertical_disassem_scroll.
3021         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3022         do_scroll_horizontal>: New methods.
3023         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3024         Likewise.
3025         (struct tui_source_window_base): Add do_scroll_horizontal.
3026         (struct tui_source_window, struct tui_disasm_window): Add
3027         do_scroll_vertical.
3028         (struct tui_data_window, struct tui_cmd_window): Add
3029         do_scroll_horizontal and do_scroll_vertical.
3030         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3031
3032 2019-06-25  Tom Tromey  <tom@tromey.com>
3033
3034         * tui/tui-data.h (struct tui_source_window_base): New struct.
3035         (struct tui_source_window): Derive from tui_source_window_base.
3036         (struct tui_disasm_window): New struct.
3037         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3038         from tui_source_window::clear_detail.
3039         (tui_source_window_base): Rename from tui_source_window.
3040         (~tui_source_window_base): Rename from ~tui_source_window.
3041         (tui_alloc_win_info): Create a tui_disasm_window.
3042
3043 2019-06-25  Tom Tromey  <tom@tromey.com>
3044
3045         * tui/tui-data.h (struct tui_source_window)
3046         (struct tui_data_window): Declare destructors.
3047         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3048         destructors.
3049         (tui_win_info): Simplify.
3050
3051 2019-06-25  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-winsource.c (tui_display_main)
3054         (tui_update_source_windows_with_addr)
3055         (tui_update_all_breakpoint_info): Update.
3056         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3057         (new_height_ok, parse_scrolling_args): Update.
3058         * tui/tui-stack.c (tui_show_frame_info): Update.
3059         * tui/tui-data.h (struct tui_list): Remove.
3060         (tui_source_windows): Return a reference to a std::vector.
3061         * tui/tui-data.c (source_windows): Now a std::vector.
3062         (tui_source_windows): Change return type.
3063         (tui_clear_source_windows): Rewrite.
3064         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3065         (tui_free_all_source_wins_content): Rewrite.
3066
3067 2019-06-25  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3070         (struct tui_data_window, struct tui_cmd_window): Declare
3071         clear_detail method.
3072         * tui/tui-data.c (tui_source_window::clear_detail)
3073         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3074         methods.
3075         (tui_clear_win_detail): Simplify.
3076
3077 2019-06-25  Tom Tromey  <tom@tromey.com>
3078
3079         * tui/tui-layout.c (make_source_window, make_disasm_window)
3080         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3081         Return the new window.
3082         (show_source_disasm_command, show_data)
3083         (show_source_or_disasm_and_command): Update.
3084
3085 2019-06-25  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3088         parameter.  Return the new window.
3089         (show_source_disasm_command): Update and remove NULL check.
3090         (show_source_or_disasm_and_command): Update.
3091
3092 2019-06-25  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3095
3096 2019-06-25  Tom Tromey  <tom@tromey.com>
3097
3098         * tui/tui-data.h (struct tui_win_info): Make constructor
3099         protected.  Make destructor virtual.  Add initializers.
3100         (tui_source_window, tui_data_window, tui_cmd_window): New
3101         classes.
3102         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3103         constructor.  Add "type" parameter.
3104         (tui_source_window, tui_data_window, tui_cmd_window): New
3105         constructors.
3106         (tui_alloc_win_info): Instantiate the appropriate subclass.
3107
3108 2019-06-25  Tom Tromey  <tom@tromey.com>
3109
3110         * tui/tui-win.c (tui_resize_all): Use delete.
3111         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3112         destructor.
3113         (tui_free_window): Don't declare.
3114         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3115         Update.
3116
3117 2019-06-25  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-data.h (struct tui_win_info): Add constructor.
3120         * tui/tui-data.c (tui_alloc_win_info): Use new.
3121         (tui_free_window): Use delete.
3122
3123 2019-06-22  Tom Tromey  <tom@tromey.com>
3124
3125         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3126         declare.
3127         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3128
3129 2019-06-22  Tom Tromey  <tom@tromey.com>
3130
3131         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3132         declare.
3133         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3134
3135 2019-06-22  Tom de Vries  <tdevries@suse.de>
3136
3137         * dwarf2read.c (create_addrmap_from_aranges)
3138         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3139         instead of '%zu'.
3140
3141 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3142
3143         * dwarf2read.h (dwarf2_section_info_def): Remove.
3144         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3145         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3146         std::vector<dwarf2_section_info>.
3147         (struct dwo_file) <~dwo_file>: Remove.
3148         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3149         types field.
3150         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3151         (dwarf2_read_debug_names): Likewise.
3152         (create_debug_types_hash_table): Change parameter type to
3153         array_view, adjust code accordingly.
3154         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3155         (partial_die_info::fixup): Likewise.
3156         (determine_prefix): Likewise.
3157         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3158
3159 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3160
3161         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3162         gdb_bfd_ref_ptr.
3163         <~dwo_file>: Remove call to gdb_bfd_unref.
3164         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3165         gdb_bfd_ref_ptr::get.
3166
3167 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3168
3169         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3170         type to htab_up.
3171         * dwarf2read.c (struct dwo_file): Initialize fields.
3172         <~dwo_file>: New.
3173         (free_dwo_file): Remove, move content to ~dwo_file.
3174         (struct dwo_file_deleter): Remove.
3175         (dwo_file_up>: Remove custom deleter.
3176         (free_dwo_files): Remove.
3177         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3178         dwo_files.
3179         (process_skeletonless_type_units): Call unique_ptr::get.
3180         (allocate_dwo_file_hash_table): Add deleter to created hash
3181         table.  Change return type to htab_up.
3182         (lookup_dwo_file_slot): Don't memset dwo_file, call
3183         unique_ptr::get.
3184         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3185         (create_dwo_unit_in_dwp_v2): Likewise.
3186         (open_and_init_dwo_file): Likewise.
3187         (free_dwo_file_from_slot): Remove.
3188
3189 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3190
3191         * dwarf2read.h (struct dwarf2_section_info) <readin,
3192         is_virtual>: Change type to bool.
3193         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3194         true instead of 1.
3195
3196 2019-06-19  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-data.h (tui_init_content_element): Don't declare.
3199
3200 2019-06-19  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui-data.h (tui_init_win_info): Don't declare.
3203
3204 2019-06-19  Tom de Vries  <tdevries@suse.de>
3205
3206         * dwarf2read.h (abstract_to_concrete): Change type to
3207         std::unordered_map<sect_offset, std::vector<sect_offset>,
3208         gdb::hash_enum<sect_offset>>.
3209
3210 2019-06-19  Tom Tromey  <tromey@adacore.com>
3211
3212         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3213         EVAL_AVOID_SIDE_EFFECTS specially.
3214
3215 2019-06-19  Tom Tromey  <tromey@adacore.com>
3216
3217         * source-cache.c (highlighter): New global.
3218         (source_cache::get_source_lines): Create a highlighter on demand.
3219
3220 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3221
3222         * defs.h (deprecated_interactive_hook): Delete declaration.
3223         * interps.c (clear_interpreter_hooks): Remove use of
3224         deprecated_interactive_hook.
3225         * top.c (deprecated_interactive_hook): Delete definition.
3226         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3227
3228 2019-06-18  Tom de Vries  <tdevries@suse.de>
3229
3230         PR gdb/24515
3231         * dwarf2read.h (abstract_to_concrete): Change type from
3232         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3233         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3234         * dwarf2read.c (read_variable): Update.
3235         (dwarf2_fetch_die_loc_sect_off): Update.
3236
3237 2019-06-17  Tom de Vries  <tdevries@suse.de>
3238
3239         PR gdb/24617
3240         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3241         accessing parent[parent_len - 1].
3242
3243 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3244
3245         PR gdb/24364
3246         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3247         call dtrace_process_dof with NULL dof.
3248
3249 2019-06-16  Tom de Vries  <tdevries@suse.de>
3250
3251         PR gdb/24445
3252         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3253
3254 2019-06-16  Tom Tromey  <tom@tromey.com>
3255
3256         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3257         (make_all_visible): Use address of member.
3258
3259 2019-06-16  Tom Tromey  <tom@tromey.com>
3260
3261         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3262         (tui_free_window, free_content, free_content_elements): Remove
3263         unnecessary cast.
3264         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3265         cast.
3266         * tui/tui-regs.c (tui_show_register_group)
3267         (tui_display_registers_from, tui_display_reg_element_at_line):
3268         Remove unnecessary cast.
3269
3270 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3271
3272         * linux-nat.c (normal_mask): Delete.
3273         (_initialize_linux_nat): Don't initialise normal_mask.
3274
3275 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3276
3277         PR gdb/24445
3278         * dwarf-index-write.h (write_psymtabs_to_index): Add
3279         dwz_basename parameter.
3280         * dwarf-index-write.c (write_gdbindex): Move file writing to
3281         write_gdbindex_1.  Change return type void.
3282         (assert_file_size): Move up, remove filename parameter.
3283         (write_gdbindex_1): New function.
3284         (write_debug_names): Change return type to void, call
3285         assert_file_size.
3286         (struct index_wip_file): New struct.
3287         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3288         file logic to index_wip_file.  Write index for dwz file if
3289         needed.
3290         (save_gdb_index_command): Pass basename of dwz file, if present.
3291         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3292         build-id of dwz file, if present.
3293         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3294         (dwarf2_get_dwz_file): Likewise.
3295         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3296         (dwarf2_get_dwz_file): Likewise.
3297
3298 2019-06-16  Tom Tromey  <tom@tromey.com>
3299
3300         * coffread.c (process_coff_symbol): Use xstrdup.
3301         * value.c (create_internalvar): Use xstrdup.
3302
3303 2019-06-16  Tom Tromey  <tom@tromey.com>
3304
3305         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3306         * breakpoint.c (stopin_command, stopat_command)
3307         (until_break_command, decode_location_default): Remove unnecessary
3308         cast.
3309         * utils.c (subset_compare): Remove unnecessary cast.
3310         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3311         cast.
3312         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3313         cast.
3314         * infcmd.c (path_command): Remove unnecessary cast.
3315         * coffread.c (decode_type): Remove unnecessary cast.
3316         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3317         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3318         * tui/tui-stack.c (tui_show_locator_content)
3319         (tui_show_frame_info): Remove unnecessary cast.
3320         * tui/tui-win.c (tui_scroll_forward_command)
3321         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3322         (parse_scrolling_args): Remove unnecessary cast.
3323         * tui/tui-data.c (init_win_info, tui_del_window)
3324         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3325         (free_content_elements): Remove unnecessary cast.
3326         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3327         unnecessary cast.
3328         * tui/tui-source.c (tui_set_source_content)
3329         (tui_vertical_source_scroll): Remove unnecessary cast.
3330         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3331         cast.
3332         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3333         * tui/tui-regs.c (tui_display_registers_from)
3334         (tui_display_register): Remove unnecessary cast.
3335         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3336         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3337         (make_visible): Remove unnecessary cast.
3338         * tui/tui-winsource.c (tui_erase_source_content)
3339         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3340         unnecessary cast.
3341         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3342         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3343         * stabsread.c (read_type, read_array_type, read_range_type):
3344         Remove unnecessary cast.
3345         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3346         (parse_symbol, parse_type, upgrade_type, parse_external)
3347         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3348         unnecessary cast.
3349         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3350
3351 2019-06-16  Tom Tromey  <tom@tromey.com>
3352
3353         * tui/tui-data.c (tui_alloc_generic_win_info)
3354         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3355         checks.
3356
3357 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3358             Andrew Burgess  <andrew.burgess@embecosm.com>
3359
3360         * f-typeprint.c (f_print_type): Don't return early for not
3361         associated or not allocated types.
3362         (f_type_print_varspec_suffix): Add print_rank parameter and print
3363         ranks of array types in case they dangling.
3364         (f_type_print_base): Add print_rank parameter.
3365
3366 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3367
3368         * NEWS: Mention new MI commands.
3369         * break-catch-throw.c (enum exception_event_kind): Move to
3370         breakpoint.h.
3371         (print_mention_exception_catchpoint): Output text as a single
3372         message.
3373         (catch_exception_command_1): Rename to...
3374         (catch_exception_event): ...this, make non-static, update header
3375         command, and change some parameter types.
3376         (catch_catch_command): Update for changes to
3377         catch_exception_command_1.
3378         (catch_throw_command): Likewise.
3379         (catch_rethrow_command): Likewise.
3380         * breakpoint.c (enum exception_event_kind): Delete.
3381         * breakpoint.h (enum exception_event_kind): Moved here from
3382         break-catch-throw.c.
3383         (catch_exception_event): Declare.
3384         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3385         (mi_cmd_catch_throw): New function.
3386         (mi_cmd_catch_rethrow): New function.
3387         (mi_cmd_catch_catch): New function.
3388         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3389         'catch-catch' entries.
3390         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3391         (mi_cmd_catch_rethrow): Declare.
3392         (mi_cmd_catch_catch): Declare.
3393
3394 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3395
3396         * annotate.c (annotate_source_line): Change return type to void,
3397         update implementation to match.
3398         * annotate.h (annotate_source_line): Change return type to void,
3399         update header comment.
3400         * stack.c (print_frame_info): Don't change what frame information
3401         is printed based on whether annotations are on or not.
3402
3403 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3404
3405         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3406         (annotate_source): Make static.
3407         (annotate_source_line): Moved from source.c and renamed from
3408         identify_source_line.  Update the return type.
3409         * annotate.h (annotate_source): Delete declaration.
3410         (annotate_source_line): Declaration moved from source.h, and
3411         renamed from identify_source_line.  Return type updated.
3412         * source.c (identify_source_line): Moved to annotate.c and renamed
3413         to annotate_source_line.
3414         (info_line_command): Remove check of annotation_level.
3415         * source.h (identify_source_line): Move declaration to annotate.h
3416         and rename to annotate_source_line.
3417         * stack.c: Add 'annotate.h' include.
3418         (print_frame_info): Remove check of annotation_level before
3419         calling annotate_source_line.
3420
3421 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3422
3423         * source-cache.c (source_cache::get_plain_source_lines): Use
3424         open_source_file_with_line_charpos instead of just
3425         open_source_file, remove call to find_source_lines.
3426         (source_cache::get_source_lines): Likewise.
3427         * source.c (find_source_lines): Make static.
3428         (get_filename_and_charpos): Renamed into...
3429         (open_source_file_with_line_charpos): ..this along with changes to
3430         return a scoped_fd, and some other minor clean ups.
3431         (identify_source_line): Use open_source_file_with_line_charpos.
3432         (search_command_helper): Use open_source_file_with_line_charpos
3433         instead of just open_source_file, remove call to
3434         find_source_lines.
3435         * source.h (open_source_file_with_line_charpos): Declare new
3436         function.
3437         (find_source_lines): Delete declaration.
3438
3439 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3440
3441         * source.c (get_filename_and_charpos): Remove fullname
3442         parameter.
3443         (identify_source_line): Update call to get_filename_and_charpos.
3444
3445 2019-06-14  Tom Tromey  <tromey@adacore.com>
3446
3447         PR gdb/24502:
3448         * ui-style.h (skip_ansi_escape): Update comment.
3449         * ui-file.h (class no_terminal_escape_file): New class.
3450         * ui-file.c (no_terminal_escape_file::write)
3451         (no_terminal_escape_file::puts): New methods.
3452         * cli/cli-logging.c (handle_redirections): Use
3453         no_terminal_escape_file.
3454
3455 2019-06-14  Tom Tromey  <tromey@adacore.com>
3456
3457         * NEWS: Move convenience variable news above Python news.
3458
3459 2019-06-14  Tom Tromey  <tom@tromey.com>
3460
3461         * gnulib: Move directory to top-level.
3462         * configure.ac: Don't configure gnulib.
3463         * configure: Rebuild.
3464         * common/common-defs.h: Use new path to gnulib.
3465         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3466         (GNULIB_H): Remove.
3467         (INCGNU): Look in new gnulib location.
3468         (HFILES_NO_SRCDIR): Remove gnulib files.
3469         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3470         (generated_files): Remove GNULIB_H.
3471         ($(LIBGNU), all-lib): Remove targets.
3472         (distclean): Don't mention GNULIB_BUILDDIR.
3473         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3474
3475 2019-06-14  Tom Tromey  <tromey@adacore.com>
3476
3477         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3478         Warn if symbol file does not provide any symbols.
3479
3480 2019-06-14  Tom Tromey  <tromey@adacore.com>
3481
3482         * source.c (find_and_open_source): Respect basenames_may_differ.
3483
3484 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3485
3486         * annotate.c (annotate_breakpoints_invalid): Make use of
3487         scoped_restore_terminal_state.
3488         (annotate_frames_invalid): Likewise.
3489
3490 2019-06-14  Tom Tromey  <tromey@adacore.com>
3491
3492         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3493         allow assignment to an internalvar.
3494
3495 2019-06-14  Tom Tromey  <tromey@adacore.com>
3496
3497         * ada-lex.l: Allow "_" in attribute names.
3498
3499 2019-06-14  Tom Tromey  <tromey@adacore.com>
3500
3501         PR gdb/24653:
3502         * regcache.c (registers_changed): Don't call alloca.
3503         * top.c (execute_command): Don't call alloca.
3504
3505 2019-06-13  Pedro Alves  <palves@redhat.com>
3506
3507         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3508         'expression'.  When parsing an expression, error out if there's
3509         junk after "unlimited".
3510         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3511         (do_set_command): Adjust calls to is_unlimited_literal.
3512
3513 2019-06-13  Pedro Alves  <palves@redhat.com>
3514
3515         * compile/compile.c (make_compile_options_def_group): Add braces
3516         around array_view initializer.
3517         * thread.c (make_thread_apply_all_options_def_group)
3518         (make_thread_apply_all_options_def_group): Likewise.
3519
3520 2019-06-13  Pedro Alves  <palves@redhat.com>
3521
3522         * NEWS (New commands): Mention "maint test-options
3523         require-delimiter", "maint test-options unknown-is-error", "maint
3524         test-options unknown-is-operand" and "maint show
3525         test-options-completion-result".
3526         (New command options, command completion): New section.
3527         (Completion improvements): New section.
3528         Mention that you can abbreviate "unlimited".
3529
3530 2019-06-13  Pedro Alves  <palves@redhat.com>
3531
3532         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3533         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3534         * unittests/cli-utils-selftests.c (test_parse_flags)
3535         (test_parse_flags_qcs): Delete.
3536         (test_cli_utils): Don't call deleted functions.
3537
3538 2019-06-13  Pedro Alves  <palves@redhat.com>
3539
3540         * thread.c: Include "cli/cli-option.h".
3541         (tp_array_compar_ascending): Global.
3542         (tp_array_compar): Delete function.
3543         (tp_array_compar_ascending, tp_array_compar_descending): New
3544         functions.
3545         (ascending_option_def, qcs_flag_option_def)
3546         (thr_qcs_flags_option_defs)
3547         (make_thread_apply_all_options_def_group)
3548         (make_thread_apply_options_def_group): New.
3549         (thread_apply_all_command): Use gdb::option::process_options.
3550         (thread_apply_command_completer)
3551         (thread_apply_all_command_completer): New.
3552         (thread_apply_command): Use gdb::option::process_options.
3553         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3554         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3555         to generate help text of "thread apply".  Adjust "taas"'s help.
3556         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3557         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3558
3559 2019-06-13  Pedro Alves  <palves@redhat.com>
3560
3561         * thread.c (thread_apply_command): Check for invalid TID with
3562         isdigit instead of !isalpha.
3563
3564 2019-06-13  Pedro Alves  <palves@redhat.com>
3565
3566         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3567         (validate_flags_qcs): New.
3568         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3569         (validate_flags_qcs): Declare.
3570         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3571         (make_frame_apply_options_def_group): New.
3572         (frame_apply_command_count): Process options with
3573         gdb::option::process_options.
3574         (frame_apply_completer): New.
3575         (frame_apply_level_completer, frame_apply_all_completer)
3576         (frame_apply_completer): New.
3577         (_initialize_stack): Update help of "frame apply", "frame apply
3578         level", "frame apply all" and "faas" to mention supported options
3579         and install command completers.
3580         * stack.h (frame_apply_all_completer): Declare.
3581         * thread.c: Include "stack.h".
3582         (tfaas_command): Add "--".
3583         (_initialize_thread): Update help "tfaas" to mention supported
3584         options and install command completer.
3585
3586 2019-06-13  Pedro Alves  <palves@redhat.com>
3587
3588         * completer.c (complete_nested_command_line): New.
3589         (gdb_completion_word_break_characters_throw): Add assertion.
3590         * completer.h (complete_nested_command_line): Declare.
3591
3592 2019-06-13  Pedro Alves  <palves@redhat.com>
3593
3594         * stack.c (parse_backtrace_qualifiers): New.
3595         (backtrace_command): Use it.
3596         (backtrace_command_completer): Complete on qualifiers.
3597
3598 2019-06-13  Pedro Alves  <palves@redhat.com>
3599
3600         * frame.c: Include "cli/cli-option.h.
3601         (user_set_backtrace_options): New.
3602         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3603         Delete.
3604         (get_prev_frame): Adjust.
3605         (boolean_option_def, uinteger_option_def)
3606         (set_backtrace_option_defs): New.
3607         (_initialize_frame): Adjust and use
3608         gdb::option::add_setshow_cmds_for_options to install "set
3609         backtrace past-main" and "set backtrace past-entry".
3610         * frame.h: Include "cli/cli-option.h".
3611         (struct frame_print_options): Forward declare.
3612         (print_frame_arguments_all, print_frame_arguments_scalars)
3613         (print_frame_arguments_none): Declare.
3614         (print_entry_values): Delete declaration.
3615         (struct frame_print_options, user_frame_print_options): New.
3616         (struct set_backtrace_options): New.
3617         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3618         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3619         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3620         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3621         (list_args_or_locals): Add frame_print_options parameter.
3622         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3623         * python/py-framefilter.c (enumerate_args): Pass down
3624         USER_FRAME_PRINT_OPTIONS.
3625         * stack.c: Include "cli/cli-option.h".
3626         (print_frame_arguments_all, print_frame_arguments_scalars)
3627         (print_frame_arguments_none): Declare.
3628         (print_raw_frame_arguments, print_entry_values): Delete.
3629         (user_frame_print_options): New.
3630         (boolean_option_def, enum_option_def, frame_print_option_defs):
3631         New.
3632         (struct backtrace_cmd_options): New.
3633         (bt_flag_option_def): New.
3634         (backtrace_command_option_defs): New.
3635         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3636         (print_frame_arg, read_frame_arg, print_frame_args)
3637         (print_frame_info, print_frame): Add frame_print_options parameter
3638         and use it.
3639         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3640         (backtrace_command_1): Add frame_print_options and
3641         backtrace_cmd_options parameters and use them.
3642         (make_backtrace_options_def_group): New.
3643         (backtrace_command): Process command options with
3644         gdb::option::process_options.
3645         (backtrace_command_completer): New.
3646         (_initialize_stack): Extend "backtrace"'s help to mention
3647         supported options.  Install completer for "backtrace".
3648         Install some settings commands with add_setshow_cmds_for_options.
3649
3650 2019-06-13  Pedro Alves  <palves@redhat.com>
3651
3652         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3653         and that "set/show print raw frame-arguments" are now deprecated.
3654
3655         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3656         command.
3657         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3658         * stack.c (_initialize_stack): Install "set/show print
3659         raw-frame-arguments", and deprecate "set/show print raw
3660         frame-arguments".
3661         * valprint.c (_initialize_valprint): Deprecate "set/show print
3662         raw".
3663
3664 2019-06-13  Pedro Alves  <palves@redhat.com>
3665
3666         * compile/compile.c (struct compile_options): New.
3667         (compile_flag_option_def, compile_command_option_defs)
3668         (make_compile_options_def_group): New.
3669         (compile_file_command): Handle options with
3670         gdb::option::process_options.
3671         (compile_file_command_completer): New function.
3672         (compile_code_command): Handle options with
3673         gdb::option::process_options.
3674         (compile_code_command_completer): New function.
3675         (_initialize_compiler): Install completers for "compile code" and
3676         "compile file".  Mention available options in "compile code" and
3677         "compile code"'s help.
3678         * completer.c (advance_to_completion_word): New, factored out from
3679         ...
3680         (advance_to_expression_complete_word_point): ... this.
3681         (advance_to_filename_complete_word_point): New.
3682         * completer.h (advance_to_filename_complete_word_point): New
3683         declaration.
3684
3685 2019-06-13  Pedro Alves  <palves@redhat.com>
3686
3687         * compile/compile.c: Include "cli/cli-option.h".
3688         (compile_print_value): Scope data pointer is now a
3689         value_print_options pointer; adjust.
3690         (compile_print_command): Process options.  Scope data pointer is
3691         now a value_print_options pointer; adjust.
3692         (_initialize_compile): Update "compile print"'s help to include
3693         supported options.  Install a completer for "compile print".
3694         * cp-valprint.c (show_vtblprint, show_objectprint)
3695         (show_static_field_print): Delete.
3696         (_initialize_cp_valprint): Don't install "set print
3697         static-members", "set print vtbl", "set print object" here.
3698         * printcmd.c: Include "cli/cli-option.h" and
3699         "common/gdb_optional.h".
3700         (print_command_parse_format): Rework to fill in a
3701         value_print_options instead of a format_data.
3702         (print_value): Change parameter type from format_data pointer to
3703         value_print_options reference.  Adjust.
3704         (print_command_1): Process options.  Adjust to pass down a
3705         value_print_options.
3706         (print_command_completer): New.
3707         (_initialize_printcmd): Install print_command_completer as
3708         handle_brkchars completer for the "print" command.  Update
3709         "print"'s help to include supported options.
3710         * valprint.c: Include "cli/cli-option.h".
3711         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3712         here from cp-valprint.c.
3713         (boolean_option_def, uinteger_option_def)
3714         (value_print_option_defs, make_value_print_options_def_group):
3715         New.  Use gdb::option::add_setshow_cmds_for_options to install
3716         "set print elements", "set print null-stop", "set print repeats",
3717         "set print pretty", "set print union", "set print array", "set
3718         print address", "set print symbol", "set print array-indexes".
3719         * valprint.h: Include <string> and "cli/cli-option.h".
3720         (make_value_print_options_def_group): Declare.
3721         (print_value): Change parameter type from format_data pointer to
3722         value_print_options reference.
3723         (print_command_completer): Declare.
3724
3725 2019-06-13  Pedro Alves  <palves@redhat.com>
3726
3727         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3728         (COMMON_SFILES): Add maint-test-settings.c.
3729         * cli/cli-decode.c (boolean_enums): New global, factored out from
3730         ...
3731         (add_setshow_boolean_cmd): ... here.
3732         * cli/cli-decode.h (boolean_enums): Declare.
3733         * cli/cli-option.c: New file.
3734         * cli/cli-option.h: New file.
3735         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3736         factored out from ...
3737         (parse_cli_boolean_value(const char *)): ... this.
3738         (is_unlimited_literal): Change parameter type to pointer to
3739         pointer.  Adjust and advance ARG pointer.
3740         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3741         (parse_cli_var_enum): New, factored out from ...
3742         (do_set_command): ... this.  Adjust.
3743         * cli/cli-setshow.h (parse_cli_boolean_value)
3744         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3745         (parse_cli_var_enum): Declare.
3746         * cli/cli-utils.c: Include "cli/cli-option.h".
3747         (get_ulongest): New.
3748         * cli/cli-utils.h (get_ulongest): Declare.
3749         (check_for_argument): New overloads.
3750         * maint-test-options.c: New file.
3751
3752 2019-06-13  Pedro Alves  <palves@redhat.com>
3753
3754         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3755         parse a range if "-" is at the end of the string.
3756
3757 2019-06-13  Pedro Alves  <palves@redhat.com>
3758
3759         * cli/cli-setshow.c (parse_auto_binary_operation)
3760         (parse_cli_boolean_value): Don't allow "o".
3761
3762 2019-06-13  Pedro Alves  <palves@redhat.com>
3763
3764         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3765         * NEWS: Mention maint test-settings KIND.
3766         * maint-test-settings.c: New file.
3767
3768 2019-06-13  Pedro Alves  <palves@redhat.com>
3769
3770         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3771         completer.
3772         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3773         "set" completers.
3774
3775 2019-06-13  Pedro Alves  <palves@redhat.com>
3776
3777         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3778         after item.
3779
3780 2019-06-13  Pedro Alves  <palves@redhat.com>
3781
3782         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3783
3784 2019-06-13  Pedro Alves <palves@redhat.com>
3785
3786         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3787         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3788         call.
3789         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3790         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3791         calls.
3792         (check_for_argument): Skip spaces after argument.
3793
3794 2019-06-13  Pedro Alves  <palves@redhat.com>
3795
3796         * thread.c (thread_apply_command): Adjust TID parsing.
3797         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3798         detected before end of string.
3799         (tid_is_in_list): Error out if LIST is invalid.
3800
3801 2019-06-13  Pedro Alves  <palves@redhat.com>
3802
3803         * completer.c (complete_line_internal_1): Rewind completion word
3804         point.
3805         (completion_tracker::advance_custom_word_point_by): Change
3806         parameter type to int.
3807         * completer.h (completion_tracker::advance_custom_word_point_by):
3808         Likewise.
3809
3810 2019-06-13  Pedro Alves  <palves@redhat.com>
3811
3812         * completer.c (advance_to_completion_word): Handle delimiters.
3813
3814 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3815
3816         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3817
3818 2019-06-11  Tom Tromey  <tom@tromey.com>
3819
3820         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3821         (xmalloc_failed): Move to alloc.c.
3822         * alloc.c: New file.
3823         * Makefile.in (COMMON_SFILES): Add alloc.c.
3824
3825 2019-06-11  Tom Tromey  <tom@tromey.com>
3826
3827         * nat/linux-waitpid.c: Don't include server.h.
3828         (linux_debug): Remove.
3829         (my_waitpid): Update.
3830
3831 2019-06-11  Tom Tromey  <tromey@adacore.com>
3832
3833         * infcall.c (_initialize_infcall): Remove trailing newline from
3834         help.
3835         * user-regs.c (_initialize_user_regs): Remove trailing newline
3836         from help.
3837         * typeprint.c (_initialize_typeprint): Remove trailing newline
3838         from help.
3839         * reverse.c (_initialize_reverse): Remove trailing newlines from
3840         help.
3841         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3842         from help.
3843         * language.c (add_set_language_command): Remove trailing newline
3844         from help.
3845         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3846         help.
3847         * disasm.c (_initialize_disasm): Remove trailing newline from
3848         help.
3849         * top.c (init_main): Remove trailing newline from help.
3850         * interps.c (_initialize_interpreter): Remove trailing newline
3851         from help.
3852         * btrace.c (_initialize_btrace): Remove trailing newlines from
3853         help.
3854         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3855         from help.
3856         * python/python.c (_initialize_python): Remove trailing newline
3857         from help.
3858         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3859         help.
3860         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3861         from help.  Reformat some text.
3862         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3863         from help.
3864         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3865         newline from help.
3866
3867 2019-06-11  Tom Tromey  <tromey@adacore.com>
3868
3869         * darwin-nat.c (darwin_decode_exception_message)
3870         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3871
3872 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3873
3874         * valops.c (value_slice): Check for not allocated or not
3875         associated values.
3876
3877 2019-06-10  Tom de Vries  <tdevries@suse.de>
3878
3879         PR gdb/24618
3880         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3881         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3882         invalid.
3883
3884 2019-06-10  Tom de Vries  <tdevries@suse.de>
3885
3886         PR gdb/24611
3887         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3888         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3889
3890 2019-06-10  Tom de Vries  <tdevries@suse.de>
3891
3892         PR symtab/24545
3893         * symtab.c (struct demangled_name_entry): Add language field.
3894         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3895         static minimal symbol".  Set and use language field.
3896
3897 2019-06-10  Tom Tromey  <tromey@adacore.com>
3898
3899         * ada-lang.c (_initialize_ada_language): Update help text.
3900
3901 2019-06-10  Tom Tromey  <tromey@adacore.com>
3902
3903         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3904         with a newline.
3905         * guile/guile.c (handle_boot_error): Don't end warning with a
3906         newline.
3907         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3908         warning with a newline.
3909         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3910         newline.
3911         (s12z_frame_cache): Likewise.
3912         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3913         a newline.
3914         * solib-svr4.c (disable_probes_interface): Don't end warning with
3915         a newline.
3916         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3917         newline.
3918         * python/python.c (do_finish_initialization): Don't end warning
3919         with a newline.
3920
3921 2019-06-10  Tom Tromey  <tom@tromey.com>
3922
3923         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3924         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3925         gdbpy_enter.
3926
3927 2019-06-10  Tom Tromey  <tromey@adacore.com>
3928
3929         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3930         data.
3931         (elf_new_init): Don't call stabsread_new_init.
3932         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3933         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3934         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3935
3936 2019-06-10  Tom de Vries  <tdevries@suse.de>
3937
3938         PR symtab/16264
3939         PR symtab/24517
3940         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3941
3942 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3943
3944         * source.c (find_and_open_source): Also rewrite relative file
3945         names.
3946
3947 2019-04-26  Amos Bird  <amosbird@gmail.com>
3948
3949         * annotate.c (annotate_thread_exited): Add "thread-exited"
3950         annotation.
3951
3952 2019-06-06  Tom Tromey  <tromey@adacore.com>
3953
3954         * maint.h (class scoped_command_stats): Use
3955         DISABLE_COPY_AND_ASSIGN.
3956         <print_time>: New method.
3957         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3958         print_time.
3959         (scoped_command_stats::print_time): New method.
3960
3961 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3962
3963         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3964         instructions of lengths 6 or 8 bytes.
3965
3966 2019-06-04  Pedro Alves  <palves@redhat.com>
3967
3968         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3969
3970         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3971         * breakpoint.c (condition_completer): Likewise.
3972         * cli/cli-dump.c (scan_expression): Likewise.
3973         * common/filestuff.c (mkdir_recursive): Likewise.
3974         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3975         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3976         (gdb_abspath): Likewise.
3977         * compile/compile-cplus-types.c
3978         (compile_cplus_instance::decl_name): Likewise.
3979         * completer.c (complete_explicit_location):
3980         (signal_completer, reg_or_group_completer_1): Likewise.
3981         * cp-support.c (cp_remove_params_if_any): Likewise.
3982         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3983         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3984         * infcmd.c (strip_bg_char): Likewise.
3985         * linespec.c (copy_token_string): Likewise.
3986         * mi/mi-main.c (output_cores): Likewise.
3987         * psymtab.c (psymtab_search_name):
3988         * symfile.c (test_set_ext_lang_command): Likewise.
3989         * target.c (target_fileio_read_stralloc): Likewise.
3990         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3991         * value.c (complete_internalvar): Likewise.
3992
3993 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3994
3995         Add objfile property to gdb.Type.
3996         * NEWS: Mention Python API addition.
3997         * python/py-type.c (typy_get_objfile): New method.
3998
3999 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4000
4001         * NEWS: Mention the new set|show style [title|highlight].
4002         Mention changes to "show style", "help" and "apropos".
4003
4004 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4005
4006         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4007         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4008         instead of print_help_for_command.
4009         (print_doc_of_command): New function.
4010         (help_list): Add 'apropos -v word' suggestion.
4011         (print_help_for_command): Style the command name using title style.
4012         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4013         (_initialize_cli_cmds): Describe -v in apropos_command help.
4014
4015 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4016
4017         * cli/cli-style.h (cli_style_option): Add name in constructor,
4018         add m_name class member, add constructor with intensity,
4019         add name class function.
4020         (cli_style_option::add_setshow_commands): Remove name argument.
4021         (highlight_style, title_style): New styles.
4022         * cli/cli-style.c (do_show): New function that shows a style
4023         characteristic styling the style name with itself.
4024         (set_style_name): New function.
4025         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4026         Update all callers according to the changes in cli/cli-style.h.
4027         * utils.h (fputs_highlighted): New function.
4028         * utils.c (fputs_highlighted): Likewise.
4029
4030 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4031
4032         * NEWS: Mention new pipe command and new convenience variables.
4033
4034 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4035
4036         * cli/cli-cmds.c (pipe_command): New function.
4037         (_initialize_cli_cmds): Call add_com for pipe_command.
4038         Define | as an alias for pipe.
4039         (exit_status_set_internal_vars): New function.
4040         (shell_escape): Call exit_status_set_internal_vars.
4041         cli/cli-decode.c (find_command_name_length): Recognize | as
4042         a single character command.
4043
4044 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4045
4046         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4047         top.c (execute_command_to_ui_file): New function, mostly a copy
4048         of execute_command_to_string.
4049         (execute_command_to_string): Implement by calling
4050         execute_command_to_ui_file.
4051
4052 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4053
4054         * top.h (saved_command_line): Remove declaration.
4055         * top.c (previous_saved_command_line, previous_repeat_arguments):
4056         New variables.
4057         (saved_command_line): Make static, define together with other
4058         'repeat variables'.
4059         (dont_repeat): Clear repeat_arguments.
4060         (repeat_previous, get_saved_command_line, save_command_line):
4061         New functions.
4062         (gdb_init): Initialize saved_command_line
4063         and previous_saved_command_line.
4064         * main.c (captured_main_1): Remove saved_command_line initialization.
4065         * event-top.c (handle_line_of_input): Update to use
4066         the new 'repeat' related functions instead of direct access to
4067         saved_command_line.
4068         * command.h (repeat_previous, get_saved_command_line,
4069         save_command_line): New declarations.
4070         (dont_repeat): Add comment.
4071
4072 2019-05-30  Tom Tromey  <tromey@adacore.com>
4073
4074         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4075         Fix comment.
4076         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4077
4078 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4079
4080         PR cli/24587
4081         * completer.c (complete): Initialize variable word.
4082
4083 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4084
4085         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4086         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4087         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4088         'body' is NULL to the outter 'if', protecting the '!is_define'
4089         situation as well.
4090
4091 2019-05-29  Tom Tromey  <tromey@adacore.com>
4092
4093         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4094         (dwarf_unknown): New function.
4095         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4096         (dwarf_type_encoding_name): Use dwarf_unknown.
4097
4098 2019-05-29  Tom Tromey  <tromey@adacore.com>
4099
4100         PR c++/20020:
4101         * cp-valprint.c (cp_print_value_fields): Call
4102         cp_print_static_field inside "try".
4103
4104 2019-05-29  Tom Tromey  <tromey@adacore.com>
4105
4106         * inflow.c (struct terminal_info): Add default operator=.
4107         * configure: Rebuild.
4108         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4109         -Wdeprecated-copy-dtor, -Wredundant-move.
4110
4111 2019-05-29  Tom Tromey  <tromey@adacore.com>
4112
4113         * NEWS: Add entry.
4114         * infcmd.c (print_return_value_1): Handle finish_print
4115         option.
4116         (show_print_finish): New function.
4117         (_initialize_infcmd): Add "set/show print finish" commands.
4118         * valprint.c (user_print_options): Initialize new member.
4119         * valprint.h (struct value_print_options) <finish_print>: New
4120         member.
4121
4122 2019-05-28  Tom Tromey  <tromey@adacore.com>
4123
4124         * ada-lang.c (ada_remove_Xbn_suffix)
4125         (find_old_style_renaming_symbol)
4126         (parse_old_style_renaming): Remove.
4127         (ada_find_renaming_symbol): Don't call
4128         find_old_style_renaming_symbol.
4129         (ada_is_renaming_symbol): Rename from
4130         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4131         bool.  Now static.
4132         (ada_read_var_value): Update and simplify.
4133         * ada-exp.y (write_var_or_type): Remove old code.
4134
4135 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4136
4137         * event-top.c: Remove include comment.
4138         * inflow.c (class scoped_ignore_sigttou): Move from here...
4139         * inflow.h (class scoped_ignore_sigttou): ...to here.
4140         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4141         * top.c:  Remove include comment.
4142
4143 2019-05-27  Tom Tromey  <tom@tromey.com>
4144
4145         * NEWS: Fix typo.
4146
4147 2019-05-22  Tom Tromey  <tromey@adacore.com>
4148
4149         * target.c (target_follow_exec): Constify parameter.
4150         * target-delegates.c: Rebuild.
4151         * remote.c (remote_target::follow_exec): Constify parameter.
4152         * infrun.c (follow_exec): Constify parameter.
4153         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4154         (target_follow_exec): Likewise.
4155
4156 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4157
4158         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4159         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4160
4161 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4162
4163         * NEWS: Add debugredirect and testsuite sections.
4164
4165 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4166
4167         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4168         target descriptions using exclusively floating point register name
4169         aliases.
4170
4171 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4172
4173         PR gdb/18644:
4174         * f-lang.c (build_fortran_types): Handle the case where
4175         gdbarch_floatformat_for_type returns a nullptr.
4176
4177 2019-05-21  Tom de Vries  <tdevries@suse.de>
4178
4179         PR cli/24587
4180         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4181
4182 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4183
4184         PR gdb/18644:
4185         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4186         16-byte floats.
4187         * i386-tdep.c (i386_floatformat_for_type): Use
4188         floatformats_ia64_quad for the 16-byte floating point component
4189         within a fortran 32-byte complex number.
4190
4191 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4192
4193         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4194         delete default constructor.
4195         (find_partial_die): Update to return const struct.
4196         (partial_die_parent_scope): Move variable declaration into scope
4197         of its use and change its type to auto.
4198         (guess_partial_die_structure_name): Likewise.
4199         (partial_die_info::fixup): Likewise.
4200
4201 2019-05-17  Tom Tromey  <tromey@adacore.com>
4202
4203         * source.c (find_and_open_source): Remove cast.
4204
4205 2019-05-17  Tom Tromey  <tromey@adacore.com>
4206
4207         * annotate.c (annotate_source): Make "filename" const.
4208         * annotate.h (annotate_source): Use const.
4209
4210 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4211
4212         * disasm.c (set_disassembler_options): Send errors to stderr.
4213
4214 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4215
4216         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4217         (cli_interp_base::set_logging): Check debug_redirect.
4218         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4219         * cli/cli-logging.c (debug_redirect): Add static variable.
4220         (pop_output_files): Add default param.
4221         (handle_redirections): Print debug setting.
4222         (show_logging_command): Likewise.
4223         (_initialize_cli_logging): Add debugredirect command.
4224         * interps.c (current_interp_set_logging): Add debug_redirect
4225         parameter.
4226         * interps.h (set_logging): Add debug_redirect parameter.
4227         (current_interp_set_logging): Likewise.
4228         * mi/mi-common.h: Likewise.
4229         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4230
4231 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4232             Tom Tromey  <tromey@adacore.com>
4233
4234         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4235         directly.
4236         * cli/cli-interp.h (make_logging_output): Remove declaration.
4237         * cli/cli-logging.c (make_logging_output): Remove function.
4238         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4239         directly.
4240         * ui-file.c (tee_file::tee_file): Remove bools.
4241         (tee_file::~tee_file): Remove deletes.
4242         * ui-file.h (tee_file): Remove bools.
4243
4244 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4245
4246         * mi/mi-cmds.h (mi_cmd_complete): New function.
4247         * mi/mi-main.c (mi_cmd_complete): Likewise.
4248         * mi/mi-cmds.c: Define new MI command -complete.
4249         * NEWS: Mention new -complete command.
4250
4251 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4252
4253         * completer.h (complete): New function.
4254         * completer.c (complete): Likewise.
4255         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4256         function defined in completer.h.
4257
4258 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4259
4260         * MAINTAINERS (Write After Approval): Add myself.
4261
4262 2019-05-17  Tom de Vries  <tdevries@suse.de>
4263
4264         PR gdb/24094
4265         * dwarf2read.c (struct cu_partial_die_info): New struct.
4266         (find_partial_die): Return cu_partial_die_info.
4267         (partial_die_parent_scope, guess_partial_die_structure_name)
4268         (partial_die_info::fixup): Handle new return type of find_partial_die.
4269
4270 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4271
4272         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4273         "std::string", simplifying the algorithm.
4274
4275 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4276
4277         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4278         (stap_static_probe_ops::get_probes): Likewise.
4279
4280 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4281
4282         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4283         '-')" and "else if".
4284         (stap_parse_single_operand): Join checks for
4285         "gdbarch_stap_parse_special_token_p" and
4286         "gdbarch_stap_parse_special_token" in the same "if" statement.
4287         Invert check when verifying for operation on register
4288         displacement.
4289
4290 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4291
4292         * stap-probe.c (stap_get_opcode): Update comment.
4293         (stap_get_expected_argument_type): Likewise.
4294         (handle_stap_probe): Likewise.
4295
4296 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4297
4298         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4299         return type to 'bool'.  Adjust comment.  Use 'bool' when
4300         appropriate.
4301         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4302         * stap-probe.c (stap_parse_argument_1): Likewise.
4303         (stap_is_operator): Likewise.
4304         (stap_is_generic_prefix): Likewise.
4305         (stap_is_register_prefix): Likewise.
4306         (stap_is_register_indirection_prefix): Likewise.
4307         (stap_is_integer_prefix): Likewise.
4308         (stap_generic_check_suffix): Likewise.
4309         (stap_check_integer_suffix): Likewise.
4310         (stap_check_register_suffix): Likewise.
4311         (stap_check_register_indirection_suffix): Likewise.
4312         (stap_parse_register_operand): Likewise.
4313         (stap_parse_single_operand): Likewise.
4314         (stap_parse_argument_1): Likewise.
4315         (stap_probe::get_argument_count): Likewise.
4316         (stap_is_operator): Likewise.
4317
4318 2019-05-16  Tom Tromey  <tromey@adacore.com>
4319
4320         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4321         keyword to foreach.
4322
4323 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4324
4325         * linux-thread-db.c (try_thread_db_load_1): Change return type
4326         to bool.
4327         (try_thread_db_load): Likewise.
4328         (try_thread_db_load_from_pdir_1): Likewise.
4329         (try_thread_db_load_from_pdir): Likewise.
4330         (try_thread_db_load_from_sdir): Likewise.
4331         (try_thread_db_load_from_dir): Likewise.
4332         (thread_db_load_search): Likewise.
4333         (has_libpthread): Likewise.
4334         (thread_db_load): Likewise.
4335
4336 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4337
4338         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4339         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4340         NULL, and complain/return if that's the case.
4341
4342 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4343
4344         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4345         (advance, posn, abstract_read_memory): New functions.
4346         [struct mem_read_abstraction]: New struct.
4347         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4348
4349 2019-05-14  Tom Tromey  <tromey@adacore.com>
4350
4351         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4352         value is not lval_memory.
4353
4354 2019-05-14  Tom Tromey  <tromey@adacore.com>
4355
4356         * solib.c (info_sharedlibrary_command): Style the file name.
4357
4358 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4359
4360         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4361         (aarch64_vnv_type): Likewise.
4362         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4363         * common/tdesc.c: Likewise.
4364         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4365         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4366         * features/aarch64-fpu.xml: Add ieee half view.
4367         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4368         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4369         * gdbtypes.h (struct builtin_type): Likewise.
4370         (struct objfile_type): Likewise.
4371
4372 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4373
4374         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4375         typo.
4376         * location.h (string_to_event_location): Likewise.
4377
4378 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4379
4380         GDB 8.3 released.
4381
4382 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4383
4384         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4385         New variable declaration.
4386         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4387         New variable.
4388         (print_one_breakpoint): Use ui_out::test_flags and new global
4389         variable to compute use_fixed_output.
4390         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4391         Remove.
4392         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4393         (mi_multi_location_breakpoint_output_fixed): Remove.
4394         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4395         new variable.
4396         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4397         fix_multi_location_breakpoint_output flag if version >= 3.
4398         * ui-out.h (enum ui_out_flag)
4399         <fix_multi_location_breakpoint_output>: New enumerator.
4400
4401 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4402
4403         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4404
4405 2019-05-10  Tom Tromey  <tromey@adacore.com>
4406
4407         * ada-lang.c (catch_ada_completer): New function.
4408         (_initialize_ada_language): Use it.
4409
4410 2019-05-10  Tom Tromey  <tromey@adacore.com>
4411
4412         * thread.c (print_thread_info): Make "requested_threads" const.
4413         * gdbthread.h (print_thread_info): Make "requested_threads"
4414         const.
4415         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4416         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4417
4418 2019-05-08  Tom Tromey  <tom@tromey.com>
4419
4420         * gdbtypes.c (objfile_type_data): Change type.
4421         (objfile_type, _initialize_gdbtypes): Update.
4422
4423 2019-05-08  Tom Tromey  <tom@tromey.com>
4424
4425         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4426         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4427         (_initialize_dwarf2_frame): Update.
4428
4429 2019-05-08  Tom Tromey  <tom@tromey.com>
4430
4431         * objc-lang.c (objc_objfile_data): Change type.
4432         (find_methods): Update.
4433         (_initialize_objc_lang): Remove.
4434
4435 2019-05-08  Tom Tromey  <tom@tromey.com>
4436
4437         * stabsread.c (rs6000_builtin_type_data): Change type.
4438         (rs6000_builtin_type, _initialize_stabsread): Update.
4439
4440 2019-05-08  Tom Tromey  <tom@tromey.com>
4441
4442         * mips-tdep.c (mips_pdr_data): Remove.
4443         (_initialize_mips_tdep): Update.
4444
4445 2019-05-08  Tom Tromey  <tom@tromey.com>
4446
4447         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4448         (hppa_init_objfile_priv_data, read_unwind_info)
4449         (find_unwind_entry, _initialize_hppa_tdep): Update.
4450
4451 2019-05-08  Tom Tromey  <tom@tromey.com>
4452
4453         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4454         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4455         on obstack.
4456         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4457
4458 2019-05-08  Tom Tromey  <tom@tromey.com>
4459
4460         * mdebugread.c (basic_type_data): Change type.
4461         (basic_type, _initialize_mdebugread): Update.
4462
4463 2019-05-08  Tom Tromey  <tom@tromey.com>
4464
4465         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4466
4467 2019-05-08  Tom Tromey  <tom@tromey.com>
4468
4469         * nto-tdep.c (nto_inferior_data_reg): Change type.
4470         (nto_inferior_data): Update.
4471         (nto_inferior_data_cleanup, nto_new_inferior_data)
4472         (_initialize_nto_tdep): Remove.
4473         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4474
4475 2019-05-08  Tom Tromey  <tom@tromey.com>
4476
4477         * ada-lang.c (struct ada_inferior_data): Add initializers.
4478         (ada_inferior_data): Change type.
4479         (ada_inferior_data_cleanup): Remove.
4480         (get_ada_inferior_data, ada_inferior_exit)
4481         (struct ada_pspace_data): Add initializers, destructor.
4482         (ada_pspace_data_handle): Change type.
4483         (get_ada_pspace_data): Update.
4484         (ada_pspace_data_cleanup): Remove.
4485
4486 2019-05-08  Tom Tromey  <tom@tromey.com>
4487
4488         * coffread.c (struct coff_symfile_info): Add initializers.
4489         (coff_objfile_data_key): Move lower.  Change type.
4490         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4491         Update.
4492         (coff_free_info): Remove.
4493
4494 2019-05-08  Tom Tromey  <tom@tromey.com>
4495
4496         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4497         (fbsd_pspace_data_handle): Move lower.  Change type.
4498         (get_fbsd_pspace_data): Update.
4499         (fbsd_pspace_data_cleanup): Remove.
4500         (_initialize_fbsd_tdep): Update.
4501
4502 2019-05-08  Tom Tromey  <tom@tromey.com>
4503
4504         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4505         (get_ada_tasks_pspace_data): Update.
4506         (ada_tasks_pspace_data_cleanup): Remove.
4507         (_initialize_tasks): Update.
4508         (ada_tasks_inferior_data_handle): Change type.
4509         (get_ada_tasks_inferior_data): Update.
4510         (ada_tasks_inferior_data_cleanup): Remove.
4511         (struct ada_tasks_pspace_data): Add initializers.
4512
4513 2019-05-08  Tom Tromey  <tom@tromey.com>
4514
4515         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4516         * symfile-debug.c (debug_sym_get_probes): Change type.
4517         * stap-probe.c (handle_stap_probe):
4518         (stap_static_probe_ops::get_probes): Change type.
4519         * probe.h (class static_probe_ops) <get_probes>: Change type.
4520         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4521         (parse_probes_in_pspace): Update.
4522         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4523         Update.
4524         (any_static_probe_ops::get_probes): Change type.
4525         * elfread.c (elfread_data): New typedef.
4526         (probe_key): Change type.
4527         (elf_get_probes): Likewise.  Update.
4528         (probe_key_free): Remove.
4529         (_initialize_elfread): Update.
4530         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4531         Change type.
4532         (dtrace_process_dof_probe, dtrace_process_dof)
4533         (dtrace_static_probe_ops::get_probe): Change type.
4534
4535 2019-05-08  Tom Tromey  <tom@tromey.com>
4536
4537         * xcoffread.c (struct xcoff_symfile_info): Rename from
4538         coff_symfile_info.  Add initializers.
4539         (xcoff_objfile_data_key): Move lower.  Change type.
4540         (XCOFF_DATA): Rewrite.
4541         (xcoff_free_info): Remove.
4542         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4543         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4544         (xcoff_initial_scan): Update.
4545
4546 2019-05-08  Tom Tromey  <tom@tromey.com>
4547
4548         * solib-svr4.c (struct svr4_info): Add initializers and
4549         destructor.
4550         <probes_table>: Now an htab_up.
4551         (solib_svr4_pspace_data): Change type.
4552         (free_probes_table): Simplify.
4553         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4554         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4555         (probes_table_remove_objfile_probes, register_solib_event_probe)
4556         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4557         (_initialize_svr4_solib): Update.
4558
4559 2019-05-08  Tom Tromey  <tom@tromey.com>
4560
4561         * remote.c (remote_pspace_data): Change type.
4562         (remote_pspace_data_cleanup): Remove.
4563         (get_remote_exec_file, set_pspace_remote_exec_file)
4564         (_initialize_remote): Update.
4565
4566 2019-05-08  Tom Tromey  <tom@tromey.com>
4567
4568         * breakpoint.c (breakpoint_objfile_key): Change type.
4569         (get_breakpoint_objfile_data): Update.
4570         (free_breakpoint_objfile_data): Remove.
4571         (_initialize_breakpoint): Update.
4572
4573 2019-05-08  Tom Tromey  <tom@tromey.com>
4574
4575         * linux-tdep.c (struct linux_info): Add initializers.
4576         (linux_inferior_data): Move.  Change type.
4577         (invalidate_linux_cache_inf): Update.
4578         (linux_inferior_data_cleanup): Remove.
4579         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4580
4581 2019-05-08  Tom Tromey  <tom@tromey.com>
4582
4583         * auxv.c (auxv_inferior_data): Move.  Change type.
4584         (auxv_inferior_data_cleanup): Remove.
4585         (invalidate_auxv_cache_inf): Rewrite.
4586         (get_auxv_inferior_data, _initialize_auxv): Update.
4587
4588 2019-05-08  Tom Tromey  <tom@tromey.com>
4589
4590         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4591         (symfile_debug_objfile_data_key): Change type.
4592         (symfile_debug_installed, debug_qf_has_symbols)
4593         (debug_qf_find_last_source_symtab)
4594         (debug_qf_forget_cached_source_info)
4595         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4596         (debug_qf_print_stats, debug_qf_dump)
4597         (debug_qf_expand_symtabs_for_function)
4598         (debug_qf_expand_all_symtabs)
4599         (debug_qf_expand_symtabs_with_fullname)
4600         (debug_qf_map_matching_symbols)
4601         (debug_qf_expand_symtabs_matching)
4602         (debug_qf_find_pc_sect_compunit_symtab)
4603         (debug_qf_map_symbol_filenames)
4604         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4605         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4606         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4607         (debug_sym_read_linetable, debug_sym_relocate): Update.
4608         (symfile_debug_free_objfile): Remove.
4609         (install_symfile_debug_logging, _initialize_symfile_debug):
4610         Update.
4611
4612 2019-05-08  Tom Tromey  <tom@tromey.com>
4613
4614         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4615         allocate_on_obstack.
4616         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4617         (get_dwarf2_per_objfile): Update.
4618         (set_dwarf2_per_objfile): Remove.
4619         (dwarf2_has_info, dwarf2_get_section_info): Update.
4620         (dwarf2_free_objfile): Remove.
4621         (_initialize_dwarf2_read): Update.
4622
4623 2019-05-08  Tom Tromey  <tom@tromey.com>
4624
4625         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4626         initializers.
4627         <unsupported_script_warning_printed,
4628         script_not_found_warning_printed>: Now bool.
4629         (auto_load_pspace_data): Change type.
4630         (~auto_load_pspace_info): Rename from
4631         auto_load_pspace_data_cleanup.
4632         (get_auto_load_pspace_data, init_loaded_scripts_info)
4633         (clear_section_scripts, maybe_print_unsupported_script_warning)
4634         (maybe_print_script_not_found_warning, _initialize_auto_load):
4635         Update.
4636
4637 2019-05-08  Tom Tromey  <tom@tromey.com>
4638
4639         * objfiles.c (objfile_pspace_info): Add destructor and
4640         initializers.
4641         (objfiles_pspace_data): Change type.
4642         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4643         (get_objfile_pspace_data): Update.
4644         (objfiles_bfd_data): Change type.
4645         (get_objfile_bfd_data): Update.
4646         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4647
4648 2019-05-08  Tom Tromey  <tom@tromey.com>
4649
4650         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4651         Change type.
4652         (get_catch_syscall_inferior_data): Update.
4653         (catch_syscall_inferior_data_cleanup): Remove.
4654         (_initialize_break_catch_syscall): Update.
4655
4656 2019-05-08  Tom Tromey  <tom@tromey.com>
4657
4658         * inflow.c (struct terminal_info): Add destructor and
4659         initializers.
4660         (inflow_inferior_data): Change type.
4661         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4662         (get_inflow_inferior_data, inflow_inferior_exit)
4663         (swap_terminal_info, _initialize_inflow): Update.
4664
4665 2019-05-08  Tom Tromey  <tom@tromey.com>
4666
4667         * target-dcache.c (target_dcache_cleanup): Remove.
4668         (target_dcache_aspace_key): Change type.
4669         (target_dcache_init_p, target_dcache_invalidate)
4670         (target_dcache_get, target_dcache_get_or_init)
4671         (_initialize_target_dcache): Update.
4672         * dcache.h (struct dcache_deleter): New.
4673
4674 2019-05-08  Tom Tromey  <tom@tromey.com>
4675
4676         * symtab.c (struct symbol_cache): Add destructor and
4677         initializers.
4678         (symbol_cache_key): Move.  Change type.
4679         (make_symbol_cache, free_symbol_cache): Remove.
4680         (get_symbol_cache): Update.
4681         (symbol_cache_cleanup): Remove.
4682         (ALL_PSPACES, symbol_cache_flush)
4683         (maintenance_print_symbol_cache)
4684         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4685         Update.
4686
4687 2019-05-08  Tom Tromey  <tom@tromey.com>
4688
4689         * symtab.c (struct main_info): Add destructor and initializers.
4690         (main_progspace_key): Move.  Change type.
4691         (get_main_info): Update.
4692         (main_info_cleanup): Remove.
4693         (_initialize_symtab): Update.
4694
4695 2019-05-08  Tom Tromey  <tom@tromey.com>
4696
4697         * registry.h (DECLARE_REGISTRY): Define the _key class.
4698
4699 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4700
4701         * NEWS: Merge two 'New commands' sections.
4702
4703 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4704
4705         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4706         parameter and use Ada language definition instead.
4707         (ada_val_print_ptr): Remove unused language parameter.
4708         (ada_val_print_num): Remove language parameter and use Ada language
4709         definition instead.
4710         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4711         parameter.
4712         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4713         parameter and use Ada language definition instead.
4714         (ada_val_print_1): Update all ada_val_print_xxx calls.
4715         Remove language parameter.
4716         (ada_val_print): Update ada_val_print_1 call.
4717
4718 2019-05-08  Tom Tromey  <tromey@adacore.com>
4719
4720         * remote.c (remote_hw_watchpoint_limit)
4721         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4722         Now static.
4723
4724 2019-05-08  Tom Tromey  <tromey@adacore.com>
4725
4726         * maint.c (_initialize_maint_cmds): Move initialization code to
4727         remote.c.
4728         (watchdog, show_watchdog): Move to remote.c.
4729         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4730         "watchdog" static.
4731         (_initialize_remote): Move initialization code from maint.c.
4732         * defs.h (watchdog): Don't declare.
4733
4734 2019-05-08  Tom Tromey  <tromey@adacore.com>
4735
4736         * tui/tui-interp.c: Include main.h.
4737         * interps.c: Include main.h.
4738         * main.h (interpreter_p): Declare.
4739         * defs.h (interpreter_p): Don't declare.
4740
4741 2019-05-08  Tom Tromey  <tromey@adacore.com>
4742
4743         * dwarf2loc.c: Include dwarf2read.h.
4744         * defs.h (read_unsigned_leb128): Don't declare.
4745         * dwarf2read.h (read_unsigned_leb128): Declare.
4746
4747 2019-05-08  Tom Tromey  <tromey@adacore.com>
4748
4749         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4750         method.
4751
4752 2019-05-08  Tom Tromey  <tromey@adacore.com>
4753
4754         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4755         when no wrap column is set.
4756
4757 2019-05-08  Tom Tromey  <tromey@adacore.com>
4758
4759         * c-lang.c (c_get_string): Handle non-C-style arrays.
4760
4761 2019-05-08  Tom Tromey  <tromey@adacore.com>
4762
4763         * typeprint.c (print_offset_data::update): Print the bit offset,
4764         not the number of bits remaining.
4765
4766 2019-05-08  Tom Tromey  <tromey@adacore.com>
4767
4768         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4769         padding at end of comment.
4770
4771 2019-05-08  Tom Tromey  <tromey@adacore.com>
4772
4773         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4774         Compare main types.
4775
4776 2019-05-06  Tom Tromey  <tom@tromey.com>
4777
4778         * common/scoped_mmap.c: Include common-defs.h.
4779         * common/scoped_mmap.h: Don't include config.h.
4780
4781 2019-05-04  Tom Tromey  <tom@tromey.com>
4782
4783         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4784         (struct aarch64_call_info): Add initializers.
4785         <si>: Now a std::vector.
4786         (pass_on_stack, aarch64_push_dummy_call): Update.
4787
4788 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4789             Tom Tromey  <tom@tromey.com>
4790
4791         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4792         (ppc_threads): Now a std::vector.  Now static.
4793         (hwdebug_find_thread_points_by_tid)
4794         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4795         Update.
4796
4797 2019-05-04  Tom Tromey  <tom@tromey.com>
4798
4799         * arc-tdep.c (arc_tdesc_init): Return bool.
4800
4801 2019-05-04  Tom Tromey  <tom@tromey.com>
4802
4803         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4804         Use gdb_assert_not_reached.
4805
4806 2019-05-04  Tom Tromey  <tom@tromey.com>
4807
4808         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4809         "false".
4810
4811 2019-05-04  Tom Tromey  <tom@tromey.com>
4812
4813         * arc-tdep.c (arc_tdesc_init): Use bool.
4814
4815 2019-05-04  Tom Tromey  <tom@tromey.com>
4816
4817         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4818
4819 2019-05-04  Tom Tromey  <tom@tromey.com>
4820
4821         * cli/cli-cmds.c (valid_command_p): Return bool.
4822
4823 2019-05-04  Tom Tromey  <tom@tromey.com>
4824
4825         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4826         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4827
4828 2019-05-04  Raul Tambre  <raul@tambre.ee>
4829
4830         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4831         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4832         operator for comparison.
4833
4834 2019-05-04  Tom Tromey  <tom@tromey.com>
4835
4836         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4837         (lookup_partial_symbol, print_partial_symbols)
4838         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4839         (psymbol_compare): Update.
4840         (add_psymbol_to_bcache): Clear the entire psymbol.
4841         (maintenance_check_psymtabs): Update.
4842         * psympriv.h (struct partial_symbol): Don't derive from
4843         general_symbol_info.
4844         <obj_section, unrelocated_address, address,
4845         set_unrelocated_address>: Update.
4846         <ginfo>: New member.
4847         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4848         (debug_names::write_psymbols): Update.
4849
4850 2019-05-04  Tom de Vries  <tdevries@suse.de>
4851
4852         * contrib/cc-with-tweaks.sh: Support -n arg.
4853
4854 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4855
4856         * corelow.c (core_target::detach): Ensure frame cache and
4857         register caches are cleared.
4858         inferior.c (exit_inferior_1): Likewise.
4859
4860 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4861             Tom Tromey  <tom@tromey.com>
4862
4863         * dictionary.c (collate_pending_symbols_by_language): Remove
4864         "struct" from foreach.
4865         * symtab.c (lookup_global_symbol_from_objfile)
4866         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4867         foreach.
4868         * ser-tcp.c (net_open): Remove "struct" from foreach.
4869         * objfiles.c (objfile_relocate, objfile_rebase)
4870         (objfile_has_symbols): Remove "struct" from foreach.
4871         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4872         from foreach.
4873         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4874         foreach.
4875         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4876         "struct" from foreach.
4877         * ada-lang.c (create_excep_cond_exprs)
4878         (ada_exception_catchpoint_cond_string): Remove "struct" from
4879         foreach.
4880
4881 2019-05-03  Tom Tromey  <tromey@adacore.com>
4882
4883         * ada-exp.y (convert_char_literal): Check suffix of each
4884         enumerator.
4885
4886 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4887
4888         PR ada/21406:
4889         * ada-exp.y (yywrap): Don't define.
4890         * ada-lex.l (%option): Add noyywrap
4891         (yywrap): Remove.
4892
4893 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4894
4895         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4896         _WIN32_WINNT to the XP level, unless already defined to a higher
4897         level.
4898
4899         * unittests/parse-connection-spec-selftests.c:
4900         * ser-tcp.c:
4901         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4902         override.
4903
4904         * symfile.c (find_separate_debug_file): Remove colon from the
4905         drive spec of DOS/Windows file names of the target, so that the
4906         file name produced from DEBUGDIR and the target's directory will
4907         be valid on DOS/Windows systems.
4908
4909 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4910
4911         * rust-lang.c (val_print_struct): Handle printing structures
4912         containing strings.
4913
4914 2019-05-02  Tom Tromey  <tromey@adacore.com>
4915
4916         * valarith.c (_initialize_valarith): Remove.
4917
4918 2019-05-01  Tom Tromey  <tromey@adacore.com>
4919
4920         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4921         bitfields.
4922
4923 2019-05-01  Tom Tromey  <tromey@adacore.com>
4924
4925         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4926         for big-endian copies.
4927
4928 2019-04-30  Ali Tamur  <tamur@google.com>
4929         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4930         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4931         (read_3_bytes): New function.
4932
4933 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4934
4935         * windows-nat.c (main_thread_id): Delete.
4936         (handle_output_debug_string): Replace main_thread_id by
4937         current_event.dwThreadId.
4938         (fake_create_process): Likewise.
4939         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4940         Do not set main_thread_id.
4941         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4942         current_event.dwThreadId.
4943         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4944
4945 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4946
4947         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4948         Use current_event.dwThreadId instead of main_thread_id.
4949
4950 2019-04-30  Tom Tromey  <tromey@adacore.com>
4951
4952         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4953         (create_excep_cond_exprs): Iterate over program spaces.
4954         (ada_exception_catchpoint_cond_string): Examine all minimal
4955         symbols for exception types.
4956
4957 2019-04-30  Tom Tromey  <tromey@adacore.com>
4958
4959         PR c++/24470:
4960         * dwarf2read.c (process_structure_scope): Handle case where type
4961         has template parameters but no symbol was created.
4962
4963 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4964             Chris January  <chris.january@arm.com>
4965
4966         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4967         qualifier.
4968         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4969
4970 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4971
4972         * f-typeprint.c (f_print_type): Update rules for printing
4973         whitespace.
4974         (f_type_print_varspec_suffix): Likewise.
4975
4976 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4977             Chris January  <chris.january@arm.com>
4978
4979         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4980         function arguments.
4981
4982 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4983
4984         * f-lang.c (build_fortran_types): Change name of void type to
4985         lower case.
4986         * f-typeprint.c (f_type_print_base): Print the name of the void
4987         type, rather than a fixed string.
4988         * f-valprint.c (f_decorations): Use lower case void string.
4989
4990 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4991             Chris January  <chris.january@arm.com>
4992
4993         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4994         types for Fortran.
4995
4996 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4997             Chris January  <chris.january@arm.com>
4998             David Lecomber  <david.lecomber@arm.com>
4999
5000         * f-exp.y (BINOP_INTRINSIC): New token.
5001         (exp): New parser rule handling BINOP_INTRINSIC.
5002         (f77_keywords): Add new builtin procedures.
5003         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5004         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5005         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5006         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5007         (print_unop_subexp_f): New function.
5008         (print_binop_subexp_f): New function.
5009         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5010         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5011         (dump_subexp_body_f): Likewise.
5012         (operator_check_f): Likewise.
5013         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5014         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5015
5016 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5017
5018         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5019         UNOP_KIND.
5020         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5021         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5022         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5023         (operator_length_f): New fuction.
5024         (print_subexp_f): New function.
5025         (op_name_f): New function.
5026         (dump_subexp_body_f): New function.
5027         (operator_check_f): New function.
5028         (exp_descriptor_f): Replace standard expression handling functions
5029         with new functions.
5030         * gdb/fortran-operator.def: New file.
5031         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5032         * gdb/std-operator.def: Remove UNOP_KIND.
5033
5034 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5035
5036         * std-operator.def: Remove unbalanced, stray double quote
5037         character.
5038
5039 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5040             Chris January  <chris.january@arm.com>
5041             Daniel Everett  <daniel.everett@arm.com>
5042             Nick Forrington  <nick.forrington@arm.com>
5043             Richard Bunt  <richard.bunt@arm.com>
5044
5045         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5046         of depth when printing anonymous structs or unions.
5047         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5048         Don't print either the top-level value, or the children if the
5049         max-depth is exceeded.
5050         (ppscm_print_children): When printing the key of a map, allow one
5051         extra level of depth.
5052         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5053         print either the top-level value, or the children if the max-depth
5054         is exceeded.
5055         (print_children): When printing the key of a map, allow one extra
5056         level of depth.
5057         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5058         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5059         (user_print_options): Initialise max_depth field.
5060         (val_print_scalar_or_string_type_p): New function.
5061         (val_print): Check to see if the max depth has been reached.
5062         (val_print_check_max_depth): Define new function.
5063         (show_print_max_depth): New function.
5064         (_initialize_valprint): Add 'print max-depth' option.
5065         * valprint.h (struct value_print_options) <max_depth>: New field.
5066         (val_print_check_max_depth): Declare new function.
5067         * NEWS: Document new feature.
5068
5069 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5070
5071         * ada-lang.c (ada_language_defn): Initialise new field.
5072         * c-lang.c (c_is_string_type_p): New function.
5073         (c_language_defn): Initialise new field.
5074         (cplus_language_defn): Initialise new field.
5075         (asm_language_defn): Initialise new field.
5076         (minimal_language_defn): Initialise new field.
5077         * c-lang.h (c_is_string_type_p): Declare new function.
5078         * d-lang.c (d_language_defn): Initialise new field.
5079         * f-lang.c (f_is_string_type_p): New function.
5080         (f_language_defn): Initialise new field.
5081         * go-lang.c (go_is_string_type_p): New function.
5082         (go_language_defn): Initialise new field.
5083         * language.c (default_is_string_type_p): New function.
5084         (unknown_language_defn): Initialise new field.
5085         (auto_language_defn): Initialise new field.
5086         * language.h (struct language_defn) <la_is_string_type_p>: New
5087         member variable.
5088         (default_is_string_type_p): Declare new function.
5089         * m2-lang.c (m2_language_defn): Initialise new field.
5090         * objc-lang.c (objc_language_defn): Initialise new field.
5091         * opencl-lang.c (opencl_language_defn): Initialise new field.
5092         * p-lang.c (pascal_is_string_type_p): New function.
5093         (pascal_language_defn): Initialise new field.
5094         * rust-lang.c (rust_is_string_type_p): New function.
5095         (rust_language_defn): Initialise new field.
5096
5097 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5098
5099         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5100         New field.
5101         * ada-lang.c (ada_language_defn): Initialise new field.
5102         * c-lang.c (c_language_defn): Likewise.
5103         (cplus_language_defn): Likewise.
5104         (asm_language_defn): Likewise.
5105         (minimal_language_defn): Likewise.
5106         * d-lang.c (d_language_defn): Likewise.
5107         * f-lang.c (f_language_defn): Likewise.
5108         * go-lang.c (go_language_defn): Likewise.
5109         * language.c (unknown_language_defn): Likewise.
5110         (auto_language_defn): Likewise.
5111         * m2-lang.c (m2_language_defn): Likewise.
5112         * objc-lang.c (objc_language_defn): Likewise.
5113         * opencl-lang.c (opencl_language_defn): Likewise.
5114         * p-lang.c (pascal_language_defn): Likewise.
5115         * rust-lang.c (rust_language_defn): Likewise.
5116
5117 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5118
5119         * ada-lang.c (ada_is_character_type): Change return type to bool.
5120         (ada_is_string_type): Likewise.
5121         * ada-lang.h (ada_is_character_type): Update declaration
5122         (ada_is_string_type): Likewise.
5123
5124 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5125
5126         Support style in 'frame|thread apply'
5127
5128         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5129         * record.c (record_start, record_stop): Update callers of
5130         execute_command_to_string with false.
5131         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5132         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5133         methods.
5134         (class string_file): New constructor with term_out parameter.
5135         Override methods term_out and can_emit_style_escape.  New member
5136         term_out.
5137         (class stdio_file): Override can_emit_style_escape.
5138         (class tee_file): Override term_out and can_emit_style_escape.
5139         * utils.h (can_emit_style_escape): Remove.
5140         * utils.c (can_emit_style_escape): Likewise.
5141         Update all callers of can_emit_style_escape (SOMESTREAM) to
5142         SOMESTREAM->can_emit_style_escape.
5143         * source-cache.c (source_cache::get_source_lines): Likewise.
5144         * stack.c (frame_apply_command_count): Call execute_command_to_string
5145         passing the term_out characteristic of the current gdb_stdout.
5146         * thread.c (thr_try_catch_cmd): Likewise.
5147         * top.c (execute_command_to_string): pass term_out parameter
5148         to construct the string_file for the command output.
5149         * ui-file.c (term_cli_styling): New function (most code moved
5150         from utils.c can_emit_style_escape).
5151         (string_file::string_file, string_file::can_emit_style_escape,
5152         stdio_file::can_emit_style_escape, tee_file::term_out,
5153         tee_file::can_emit_style_escape): New functions.
5154
5155 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5156
5157         * NEWS: Mention the new set|show may-call-functions.
5158         * infcall.c (may_call_functions_p): New variable.
5159         (show_may_call_functions_p): New function.
5160         (call_function_by_hand_dummy): Throws an error if not
5161         may-call-functions.
5162         (_initialize_infcall): Call add_setshow_boolean_cmd for
5163         may-call-functions.
5164
5165 2019-04-25  Keith Seitz  <keiths@redhat.com>
5166
5167         PR c++/24367
5168         * cp-support.c (inspect_type): Don't attempt substitutions
5169         of symbol with the same name.
5170
5171 2019-04-25  Tom Tromey  <tromey@adacore.com>
5172
5173         PR gdb/24475:
5174         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5175         static.
5176
5177 2019-04-25  Tom Tromey  <tromey@adacore.com>
5178
5179         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5180         rvalue reference.
5181         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5182         (gdb_xml_parser::parse): Use std::move.
5183         * python/python-internal.h (gdbpy_convert_exception): Take a const
5184         reference.
5185         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5186         std::move.
5187         * python/py-utils.c (gdbpy_convert_exception): Take a const
5188         reference.
5189         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5190         Use std::move.
5191         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5192         Use std::move.
5193         * mi/mi-main.c (mi_print_exception): Take a const reference.
5194         * main.c (handle_command_errors): Take a const reference.
5195         * linespec.c (parse_linespec): Use std::move.
5196         * infcall.c (run_inferior_call): Use std::move.
5197         (call_function_by_hand_dummy): Use std::move.
5198         * exec.c (try_open_exec_file): Use std::move.
5199         * exceptions.h (exception_print, exception_fprintf)
5200         (exception_print_same): Update.
5201         * exceptions.c (print_exception, exception_print)
5202         (exception_fprintf, exception_print_same): Change parameters to
5203         const reference.
5204         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5205         * common/new-op.c: Use std::move.
5206         * common/common-exceptions.h (struct gdb_exception): Add move
5207         constructor.
5208         (struct gdb_exception_error, struct gdb_exception_quit, struct
5209         gdb_quit_bad_alloc): Change constructor to move constructor.
5210         (throw_exception): Change parameter to rvalue reference.
5211         * common/common-exceptions.c (throw_exception): Take rvalue
5212         reference.
5213         * cli/cli-interp.c (safe_execute_command): Use std::move.
5214         * breakpoint.c (insert_bp_location, location_to_sals): Use
5215         std::move.
5216
5217 2019-04-25  Tom Tromey  <tromey@adacore.com>
5218
5219         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5220         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5221         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5222         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5223         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5224         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5225         guile/scm-value.c: Use unpack.
5226         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5227         gdbscm_gdb_exception.
5228         (gdbscm_throw_gdb_exception): Likewise.
5229         (struct gdbscm_gdb_exception): New.
5230         (unpack): New function.
5231         (gdbscm_wrap): Use unpack.
5232
5233 2019-04-25  Tom Tromey  <tromey@adacore.com>
5234
5235         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5236         (gdb_rl_callback_handler): Use std::move.
5237         * common/common-exceptions.h (struct gdb_exception): Add move
5238         assignment operator.
5239         (throw_exception_sjlj): Change "exception" to const reference.
5240         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5241         (throw_exception_sjlj): Change "exception" to const reference.
5242
5243 2019-04-25  Tom Tromey  <tromey@adacore.com>
5244
5245         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5246         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5247         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5248         Update.
5249         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5250         Update.
5251         * mi/mi-interp.c (mi_interp::exec): Update.
5252         * linespec.c (parse_linespec): Update.
5253         * infcall.c (run_inferior_call): Update.
5254         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5255         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5256         (gdbscm_lookup_global_symbol): Update.
5257         * guile/scm-param.c (gdbscm_parameter_value): Update.
5258         * guile/scm-frame.c (gdbscm_frame_read_register)
5259         (gdbscm_frame_read_var): Update.
5260         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5261         * exec.c (try_open_exec_file): Update.
5262         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5263         (gdb_rl_callback_handler): Update.
5264         * common/common-exceptions.h (exception_none): Don't declare.
5265         * common/common-exceptions.c (exception_none): Don't define.
5266         (struct catcher) <exception>: Update.
5267         * cli/cli-interp.c (safe_execute_command): Update.
5268         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5269
5270 2019-04-25  Ali Tamur  <tamur@google.com>
5271
5272         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5273         (read_attribute_value): Likewise.
5274         (dwarf2_read_addr_index): Update comment.
5275         (read_str_index): Add DW_FORM_strx.
5276         (dwarf2_string_attr): Likewise.
5277         (dwarf2_const_value_attr): Likewise.
5278         (dump_die_shallow): Likewise.
5279         (dwarf2_fetch_constant_bytes): Likewise.
5280         (skip_form_bytes): Likewise.
5281         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5282
5283 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5284
5285         PR corefiles/11608
5286         PR corefiles/18187
5287         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5288         OFFSET.  Verify if current mapping contains an ELF header.
5289         (linux_find_memory_regions_full): Adjust call to
5290         dump_mapping_p.
5291
5292 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5293             Kang Li <kanglictf@gmail.com>
5294
5295         PR gdb/21600
5296
5297         * dwarf2-frame.c (read_initial_length): Be consistent about using
5298         unsigned representation of length.
5299         (decode_frame_entry_1): Likewise.  Check for wraparound of
5300         end pointer as well as buffer overflow.
5301
5302 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5303
5304         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5305         "vq".
5306
5307 2019-04-24  Tom Tromey  <tromey@adacore.com>
5308
5309         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5310
5311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5312
5313         * s12z-tdep.c (s12z_unwind_pc): Delete.
5314         (s12z_unwind_sp): Delete.
5315         (s12z_gdbarch_init): Don't register deleted functions with
5316         gdbarch.
5317
5318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5319
5320         * rl78-tdep.c (rl78_unwind_sp): Delete.
5321         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5322
5323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5324
5325         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5326         (xstormy16_unwind_pc): Delete.
5327         (xstormy16_dummy_id): Delete.
5328         (xstormy16_gdbarch_init): Don't register deleted functions with
5329         gdbarch.
5330
5331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5332
5333         * vax-tdep.c (vax_unwind_pc): Delete.
5334         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5335
5336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * v850-tdep.c (v850_unwind_sp): Delete.
5339         (v850_unwind_pc): Delete.
5340         (v850_dummy_id): Delete.
5341         (v850_gdbarch_init): Don't register deleted functions with
5342         gdbarch.
5343
5344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5345
5346         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5347         (tilegx_unwind_pc): Delete.
5348         (tilegx_unwind_dummy_id): Delete.
5349         (tilegx_gdbarch_init): Don't register deleted functions with
5350         gdbarch.
5351
5352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5353
5354         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5355         (tic6x_dummy_id): Delete.
5356         (tic6x_gdbarch_init): Don't register deleted functions with
5357         gdbarch.
5358
5359 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5360
5361         * sparc-tdep.c (sparc_unwind_pc): Delete.
5362         (sparc32_gdbarch_init): Don't register deleted function with
5363         gdbarch.
5364
5365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5366
5367         * sh-tdep.c (sh_unwind_sp): Delete.
5368         (sh_unwind_pc): Delete.
5369         (sh_dummy_id): Delete.
5370         (sh_gdbarch_init): Don't register deleted functions with
5371         gdbarch.
5372
5373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5374
5375         * score-tdep.c (score_unwind_sp): Delete.
5376         (score_unwind_pc): Delete.
5377         (score_dummy_id): Delete.
5378         (score_gdbarch_init): Don't register deleted functions with
5379         gdbarch.
5380
5381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5382
5383         * rx-tdep.c (rx_unwind_pc): Delete.
5384         (rx_unwind_sp): Delete.
5385         (rx_dummy_id): Delete.
5386         (rx_gdbarch_init): Don't register deleted functions with
5387         gdbarch.  Update comment.
5388
5389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5390
5391         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5392         (rs6000_dummy_id): Delete.
5393         (rs6000_gdbarch_init): Don't register deleted functions with
5394         gdbarch.
5395
5396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5397
5398         * or1k-tdep.c (or1k_dummy_id): Delete.
5399         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5400
5401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5402
5403         * nios2-tdep.c (nios2_dummy_id): Delete.
5404         (nios2_unwind_sp): Delete.
5405         (nios2_gdbarch_init): Don't register deleted functions with
5406         gdbarch.
5407
5408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5409
5410         * nds32-tdep.c (nds32_dummy_id): Delete.
5411         (nds32_unwind_pc): Delete.
5412         (nds32_unwind_sp): Delete.
5413         (nds32_gdbarch_init): Don't register deleted functions with
5414         gdbarch.
5415
5416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5417
5418         * msp430-tdep.c (msp430_unwind_pc): Delete.
5419         (msp430_unwind_sp): Delete.
5420         (msp430_dummy_id): Delete.
5421         (msp430_gdbarch_init): Don't register deleted functions with
5422         gdbarch.
5423
5424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5425
5426         * moxie-tdep.c (moxie_unwind_sp): Delete.
5427         (moxie_unwind_pc): Delete.
5428         (moxie_dummy_id): Delete.
5429         (moxie_gdbarch_init): Don't register deleted functions with
5430         gdbarch.
5431
5432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5433
5434         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5435         (mn10300_unwind_pc): Delete.
5436         (mn10300_unwind_sp): Delete.
5437         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5438         mn10300_unwind_sp.
5439         (mn10300_frame_unwind_init): Don't register deleted functions with
5440         gdbarch.
5441
5442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5443
5444         * mep-tdep.c (mep_unwind_pc): Delete.
5445         (mep_unwind_sp): Delete.
5446         (mep_dummy_id): Delete.
5447         (mep_gdbarch_init): Don't register deleted functions with
5448         gdbarch.
5449
5450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5451
5452         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5453         (m68hc11_unwind_sp): Delete.
5454         (m68hc11_gdbarch_init): Don't register deleted functions with
5455         gdbarch.
5456
5457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5458
5459         * m32r-tdep.c (m32r_unwind_sp): Delete.
5460         (m32r_unwind_pc): Delete.
5461         (m32r_dummy_id): Delete.
5462         (m32r_gdbarch_init): Don't register deleted functions with
5463         gdbarch.
5464
5465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5466
5467         * m32c-tdep.c (m32c_unwind_pc): Delete.
5468         (m32c_unwind_sp): Delete.
5469         (m32c_dummy_id): Delete.
5470         (m32c_gdbarch_init): Don't register deleted functions with
5471         gdbarch.
5472
5473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5474
5475         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5476         (lm32_unwind_pc): Delete.
5477         (lm32_dummy_id): Delete.
5478         (lm32_gdbarch_init): Don't register deleted functions with
5479         gdbarch.
5480
5481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5482
5483         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5484         (iq2000_unwind_pc): Delete.
5485         (iq2000_dummy_id): Delete.
5486         (iq2000_gdbarch_init): Don't register deleted functions with
5487         gdbarch.
5488
5489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5490
5491         * nds32-tdep.c (nds32_type_align): Delete.
5492         (nds32_push_dummy_call): Use type_align instead.
5493
5494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5495
5496         * arm-tdep.c (arm_type_align): Only handle vector override case.
5497         (arm_push_dummy_call): Use type_align.
5498         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5499
5500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5501
5502         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5503         case.
5504         (pass_on_stack): Use type_align.
5505         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5506         function.
5507
5508 2019-04-23  Tom Tromey  <tromey@adacore.com>
5509
5510         * dwarf2read.c (line_header::file_name_at): Remove unused
5511         overload.
5512
5513 2019-04-23  Tom de Vries  <tdevries@suse.de>
5514
5515         PR gdb/24438
5516         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5517         invocation.
5518
5519
5520 2019-03-27  Ali Tamur  <tamur@google.com>
5521
5522         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5523         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5524         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5525         (dwarf_expr_context::get_addr_index): Likewise
5526         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5527         (symbol_needs_eval_context::get_addr_index): Likewise
5528         (disassemble_dwarf_expression): Add DW_OP_addrx
5529         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5530         (read_cutu_die_from_dwo): Update comment
5531         (skip_one_die): Add DW_FORM_addrx
5532         (read_attribute_value): Likewise
5533         (var_decode_location): Add DW_OP_addrx
5534         (dwarf2_const_value_attr): Add DW_FORM_addrx
5535         (dump_die_shallow): Likewise
5536         (dwarf2_fetch_constant_bytes): Likewise
5537         (decode_locdesc): Add DW_OP_addrx
5538         (skip_form_bytes): Add DW_FORM_addrx
5539
5540 2019-04-22  Ali Tamur  <tamur@google.com>
5541
5542         * MAINTAINERS (Write After Approval): Add self.
5543
5544 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5545
5546         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5547         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5548         (open_symbol_file_object): Likewise.
5549         (svr4_default_sos): Add info parameter.
5550         (svr4_read_so_list): Likewise.
5551         (svr4_current_sos_direct): Adjust functions calls to pass down
5552         info.
5553         (svr4_current_sos_1): Add info parameter.
5554         (svr4_current_sos): Call get_svr4_info, pass info down to
5555         svr4_current_sos_1.
5556         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5557         get_svr4_info.
5558         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5559         get_svr4_info.
5560         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5561         to get_svr4_info.
5562         (probes_table_remove_objfile_probes): Likewise.
5563         (register_solib_event_probe): Add info parameter.
5564         (solist_update_incremental): Pass info parameter down to
5565         svr4_read_so_list.
5566         (disable_probes_interface): Add info parameter.
5567         (svr4_handle_solib_event): Pass current_program_space to
5568         get_svr4_info.  Adjust disable_probes_interface cleanup.
5569         (svr4_create_probe_breakpoints): Add info parameter, pass it
5570         down to register_solib_event_probe.
5571         (svr4_create_solib_event_breakpoints): Add info parameter,
5572         pass it down to svr4_create_probe_breakpoints.
5573         (enable_break): Pass info down to
5574         svr4_create_solib_event_breakpoints.
5575         (svr4_solib_create_inferior_hook): Pass current_program_space to
5576         get_svr4_info.
5577         (svr4_clear_solib): Likewise.
5578
5579 2019-04-22  Pedro Alves  <palves@redhat.com>
5580
5581         * solib-svr4.c (svr4_free_objfile_observer): New.
5582         (probe_and_action::objfile): New field.
5583         (probes_table_htab_remove_objfile_probes)
5584         (probes_table_remove_objfile_probes): New functions.
5585         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5586         in the new probe_and_action.  Don't store the probe in 'lookup'.
5587         (svr4_create_probe_breakpoints): Pass objfile to
5588         register_solib_event_probe.
5589         (_initialize_svr4_solib): Register a free_objfile observer.
5590
5591 2019-04-19  Tom Tromey  <tom@tromey.com>
5592
5593         * common/queue.h: Remove.
5594
5595 2019-04-19  Tom Tromey  <tom@tromey.com>
5596
5597         * event-loop.c: Don't include "common/queue.h".
5598
5599 2019-04-19  Tom Tromey  <tom@tromey.com>
5600
5601         * remote.c (remote_target): Use delete.
5602         * remote-notif.h: Include <list>, not "common/queue.h".
5603         (notif_client_p): Remove typedef.
5604         (remote_notif_state): Add constructor, destructor, initializer.
5605         <notif_queue>: Now a std::list.
5606         (remote_notif_state_xfree): Don't declare.
5607         * remote-notif.c (remote_notif_process, handle_notification)
5608         (remote_notif_state_allocate): Update.
5609         (~remote_notif_state): Rename from remote_notif_state_xfree.
5610
5611 2019-04-19  Tom Tromey  <tom@tromey.com>
5612
5613         * symfile.c (reread_symbols): Update.
5614         * objfiles.c (objfile_register_static_link)
5615         (objfile_lookup_static_link): Update
5616         (~objfile) Don't delete static_links.
5617         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5618
5619 2019-04-19  Tom Tromey  <tom@tromey.com>
5620
5621         * type-stack.h (struct type_stack) <insert>: Constify string.
5622         * type-stack.c (type_stack::insert): Constify string.
5623         * gdbtypes.h (lookup_template_type): Update.
5624         (address_space_name_to_int): Update.
5625         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5626         const.
5627         (lookup_template_type): Make name const.
5628         * c-exp.y: Update rules.
5629         (lex_one_token, classify_name, classify_inner_name)
5630         (c_print_token): Update.
5631         * p-exp.y: Update rules.
5632         (yylex): Update.
5633         * f-exp.y: Update rules.
5634         (yylex): Update.
5635         * d-exp.y: Update rules.
5636         (lex_one_token, classify_name, classify_inner_name): Update.
5637         * parse.c (write_dollar_variable, copy_name): Return std::string.
5638         * parser-defs.h (copy_name): Change return type.
5639         * m2-exp.y: Update rules.
5640         (yylex): Update.
5641         * go-exp.y (lex_one_token): Update.
5642         Update rules.
5643         (classify_unsafe_function, classify_packaged_name)
5644         (classify_name, yylex): Update.
5645
5646 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5647
5648         * configure.ac: add --enable-source-highlight switch.
5649         * configure: Regenerate.
5650         * top.c (print_gdb_version): plumb --enable-source-highlight
5651         status to "show configuration".
5652
5653 2019-04-19  Tom Tromey  <tromey@adacore.com>
5654
5655         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5656         Check ADA_TYPE_P.
5657         (empty_record, ada_template_to_fixed_record_type_1)
5658         (template_to_static_fixed_type)
5659         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5660         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5661         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5662         macros.
5663
5664 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5665
5666         PR symtab/24423:
5667         * source.c (print_source_lines_base): Advance "iter" when a
5668         control character is seen.
5669
5670 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5671
5672         * inferior.h (struct infcall_suspend_state_deleter):
5673         Catch exception in destructor to avoid crash.
5674
5675 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5676
5677         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5678         close to the add_com "shell".
5679
5680 2019-04-18  Tom Tromey  <tromey@adacore.com>
5681
5682         * process-stratum-target.h (class process_stratum_target)
5683         <stratum>: Add "final".
5684
5685 2019-04-17  Tom Tromey  <tromey@adacore.com>
5686
5687         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5688         against nullptr before use.
5689
5690 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5691
5692         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5693
5694 2019-04-17  Jim Wilson  <jimw@sifive.com>
5695             Andrew Burgess  <andrew.burgess@embecosm.com>
5696
5697         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5698         code read might fail, assume 4-byte breakpoint in that case.
5699
5700 2019-04-15  Leszek Swirski  <leszeks@google.com>
5701
5702         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5703         rather than a hand-rolled POD check when checking for forced MEMORY
5704         classification.
5705
5706 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5707
5708         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5709         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5710         function.
5711         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5712         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5713         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5714         declaration.
5715
5716 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5717
5718         * aarch64-linux-nat.c
5719         (aarch64_linux_nat_target::thread_architecture): Add override.
5720         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5721         each VQ.
5722
5723 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5724
5725         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5726
5727 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5728
5729         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5730         target types of size 96-bits, add some additional comments, and
5731         check that the builtin type we found was the correct size.
5732
5733 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5734
5735         * utils.c (prompt_for_continue): Don't restore the styling at the
5736         end, as applied_style has the wrong value.  This fixes styling in
5737         long lists of file names that are interrupted by the "Continue?"
5738         prompt.
5739
5740 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5741
5742         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5743         * c-lang.c (c_language_defn): Likewise.
5744         (cplus_language_defn): Likewise.
5745         (asm_language_defn): Likewise.
5746         (minimal_language_defn): Likewise.
5747         * d-lang.c (d_language_defn): Likewise.
5748         * f-lang.c (f_language_defn): Likewise.
5749         * go-lang.c (go_language_defn): Likewise.
5750         * language.c (unknown_language_defn): Likewise.
5751         (auto_language_defn): Likewise.
5752         * language.h (struct language_defn): Remove la_magic field.
5753         (LANG_MAGIC): Delete.
5754         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5755         * objc-lang.c (objc_language_defn): Likewise.
5756         * opencl-lang.c (opencl_language_defn): Likewise.
5757         * p-lang.c (pascal_language_defn): Likewise.
5758         * rust-lang.c (rust_language_defn): Likewise.
5759
5760 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5761
5762         * riscv-tdep.c (riscv_type_align): New function.
5763         (riscv_type_alignment): Delete.
5764         (riscv_arg_location): Use 'type_align'.
5765         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5766
5767 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5768
5769         * gdbtypes.c (type_align): A struct with no non-static fields also
5770         has alignment of 1.
5771
5772 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5773
5774         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5775         component to 0.
5776         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5777         member.
5778         (riscv_struct_info::analyse): New implementation using new
5779         analyse_inner member function.
5780         (riscv_struct_info::field_offset): New member function.
5781         (riscv_struct_info::m_offsets): New member variable.
5782         (riscv_struct_info::analyse_inner): New private member function,
5783         takes the old implementation of riscv_struct_info::analyse but
5784         extended to track field offsets.
5785         (riscv_call_arg_struct): Update the struct folding special cases
5786         to handle cases where empty C++ structs, which are non-zero
5787         length, are found.
5788         (riscv_arg_location): Initialise the length of each location, a
5789         non-zero length now indicates the location is in use.
5790         (riscv_push_dummy_call): Allow for the first location having a
5791         non-zero offset when setting up arguments.
5792         (riscv_return_value): Likewise, but for return values.
5793
5794 2019-04-11  Tom Tromey  <tromey@adacore.com>
5795
5796         * utils.c (internal_vproblem): Make "msg" const.
5797
5798 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5799
5800         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5801         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5802         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5803         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5804
5805 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5806
5807         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5808         function.
5809         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5810         of amd64_collect_native_gregset.
5811         (amd64_linux_nat_target::store_registers): Likewise.
5812
5813 2019-04-10  Tom Tromey  <tom@tromey.com>
5814
5815         * symtab.c (lookup_global_symbol_from_objfile)
5816         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5817         * objfiles.h (class separate_debug_iterator): New.
5818         (class separate_debug_range): New.
5819         (struct objfile) <separate_debug_objfiles>: New method.
5820         (objfile_separate_debug_iterate): Don't declare.
5821         * objfiles.c (separate_debug_iterator::operator++): Rename from
5822         objfile_separate_debug_iterate.
5823         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5824         iterator.
5825         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5826         iterator.
5827
5828 2019-04-10  Tom Tromey  <tom@tromey.com>
5829
5830         * symfile.c (reread_symbols): Remove old comment.
5831         * objfiles.c (free_all_objfiles): Fix a typo.
5832
5833 2019-04-10  Tom Tromey  <tom@tromey.com>
5834
5835         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5836         * minsyms.c (lookup_minimal_symbol): Use foreach.
5837         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5838         (lookup_minimal_symbol_solib_trampoline): Likewise.
5839         * symfile.c (reread_symbols): Use foreach.
5840
5841 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5842             Tom Tromey  <tromey@adacore.com>
5843
5844         PR rust/24414:
5845         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5846         (rust_lex_int_test): Change "value" to be LONGEST.
5847         (rust_lex_tests): Add test for long integer literal.
5848
5849 2019-04-09  Tom Tromey  <tromey@adacore.com>
5850
5851         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5852         to bool.
5853         (extended_remote_target::attach): Update.
5854         (remote_target::remote_notice_new_inferior): Update.
5855         (remote_target::add_current_inferior_and_thread): Update.
5856         * inferior.c (exit_inferior_1): Use "false".
5857         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5858
5859 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5860
5861         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5862         the "start" command.
5863
5864 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5865
5866         * python/py-inferior.c (infpy_thread_from_thread_handle):
5867         Adjust comments to reflect renaming of thread_from_thread_handle
5868         to thread_from_handle.  Adjust keywords.  Fix type error message.
5869         (inferior_object_methods): Add thread_from_handle.  Retain
5870         thread_from_thread_handle, but mark it as deprecated.
5871
5872 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5873
5874         * gdbthread.h (find_thread_by_handle): Revise declaration.
5875         * thread.c (find_thread_by_handle): Likewise.  Adjust
5876         implementation too.
5877         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5878         support for buffer objects as handles.
5879
5880 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5881
5882         * python/py-infthread.c (thpy_thread_handle): New function.
5883         (thread_object_methods): Register thpy_thread_handle.
5884
5885 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5886
5887         * gdbthread.h (thread_to_thread_handle): Declare.
5888         * thread.c (gdbtypes.h): Include.
5889         (thread_to_thread_handle): New function.
5890
5891         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5892         (target_thread_info_to_thread_handle): Declare.
5893         * target.c (target_thread_info_to_thread_handle): New function.
5894         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5895         * target-delegates.c: Regenerate.
5896
5897         * linux-thread-db.c (class thread_db_target): Add method
5898         thread_info_to_thread_handle.
5899         (thread_db_target::thread_info_to_thread_handle): Define.
5900         * remote.c (class remote_target): Add new method
5901         thread_info_to_thread_handle.
5902         (remote_target::thread_info_to_thread_handle): Define.
5903
5904 2019-04-08  Pedro Alves  <palves@redhat.com>
5905
5906         * common/common-exceptions.c (throw_exception): Don't create
5907         named object to throw; throw directly.
5908         (throw_it): Likewise.  Don't initialize gdb_exception::message
5909         here, with new; pass FMT and AP to the ctor instead.
5910         * common/common-exceptions.h: Include <string>.
5911         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5912         const char *, va_list)): New ctor.  Use std::make_shared.
5913         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5914         errors)): Delete.
5915         (gdb_exception_error::gdb_exception_error(enum errors, const char
5916         *, va_list)): New.
5917         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5918         Add assertion.
5919         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5920         errors)): Delete.
5921         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5922         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5923         Add assertion.
5924
5925 2019-04-08  Tom Tromey  <tom@tromey.com>
5926
5927         * valops.c (value_rtti_indirect_type): Replace throw_exception
5928         with throw.
5929         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5930         with throw.
5931         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5932         throw.
5933         * target.c (target_translate_tls_address): Replace throw_exception
5934         with throw.
5935         * stack.c (frame_apply_command_count): Replace throw_exception
5936         with throw.
5937         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5938         throw.
5939         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5940         with throw.
5941         * rs6000-tdep.c (rs6000_frame_cache)
5942         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5943         * remote.c: Replace throw_exception with throw.
5944         * record-full.c (record_full_message, record_full_wait_1)
5945         (record_full_restore): Replace throw_exception with throw.
5946         * record-btrace.c:
5947         (get_thread_current_frame_id, record_btrace_start_replaying)
5948         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5949         (cmd_record_btrace_start): Replace throw_exception with throw.
5950         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5951         throw.
5952         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5953         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5954         * linespec.c:
5955         (find_linespec_symbols): Replace throw_exception with throw.
5956         * infrun.c (displaced_step_prepare, resume): Replace
5957         throw_exception with throw.
5958         * infcmd.c (post_create_inferior): Replace throw_exception with
5959         throw.
5960         * inf-loop.c (inferior_event_handler): Replace throw_exception
5961         with throw.
5962         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5963         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5964         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5965         (get_prev_frame_always, get_frame_pc_if_available)
5966         (get_frame_address_in_block_if_available, get_frame_language):
5967         Replace throw_exception with throw.
5968         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5969         throw_exception with throw.
5970         * eval.c (fetch_subexp_value, evaluate_var_value)
5971         (evaluate_funcall, evaluate_subexp_standard): Replace
5972         throw_exception with throw.
5973         * dwarf2loc.c (call_site_find_chain)
5974         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5975         Replace throw_exception with throw.
5976         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5977         with throw.
5978         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5979         throw.
5980         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5981         * completer.c (complete_line_internal): Replace throw_exception
5982         with throw.
5983         * compile/compile-object-run.c (compile_object_run): Replace
5984         throw_exception with throw.
5985         * cli/cli-script.c (process_next_line): Replace throw_exception
5986         with throw.
5987         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5988         (btrace_enable, btrace_maint_update_pt_packets): Replace
5989         throw_exception with throw.
5990         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5991         throw_exception with throw.
5992         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5993         throw_exception with throw.
5994         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5995         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5996         * aarch64-tdep.c (aarch64_make_prologue_cache)
5997         (aarch64_make_stub_cache): Replace throw_exception with throw.
5998
5999 2019-04-08  Tom Tromey  <tom@tromey.com>
6000
6001         * common/common-exceptions.c (throw_exception): Rename from
6002         throw_exception_cxx.  Remove old copy.  Make argument const.
6003         (throw_it): Create and throw exception objects directly.
6004         * common/common-exceptions.h (throw_exception): Make argument
6005         const.
6006         (struct gdb_exception_error): Add constructor.
6007         (struct gdb_exception_quit): Add constructor.
6008
6009 2019-04-08  Tom Tromey  <tom@tromey.com>
6010
6011         * common/common-exceptions.h (exception_rethrow): Don't declare.
6012         (TRY_SJLJ): Update comment.
6013         (TRY, CATCH, END_CATCH): Remove.
6014         * common/common-exceptions.c (exception_rethrow): Remove.
6015
6016 2019-04-08  Tom Tromey  <tom@tromey.com>
6017
6018         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6019         Remove.
6020         (gdb_exception_error): Rename from
6021         gdb_exception_RETURN_MASK_ERROR.
6022         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6023         (gdb_quit_bad_alloc): Update.
6024         * aarch64-tdep.c: Update.
6025         * ada-lang.c: Update.
6026         * ada-typeprint.c: Update.
6027         * ada-valprint.c: Update.
6028         * amd64-tdep.c: Update.
6029         * arch-utils.c: Update.
6030         * break-catch-throw.c: Update.
6031         * breakpoint.c: Update.
6032         * btrace.c: Update.
6033         * c-varobj.c: Update.
6034         * cli/cli-cmds.c: Update.
6035         * cli/cli-interp.c: Update.
6036         * cli/cli-script.c: Update.
6037         * common/common-exceptions.c: Update.
6038         * common/new-op.c: Update.
6039         * common/selftest.c: Update.
6040         * compile/compile-c-symbols.c: Update.
6041         * compile/compile-cplus-symbols.c: Update.
6042         * compile/compile-object-load.c: Update.
6043         * compile/compile-object-run.c: Update.
6044         * completer.c: Update.
6045         * corelow.c: Update.
6046         * cp-abi.c: Update.
6047         * cp-support.c: Update.
6048         * cp-valprint.c: Update.
6049         * darwin-nat.c: Update.
6050         * disasm-selftests.c: Update.
6051         * dtrace-probe.c: Update.
6052         * dwarf-index-cache.c: Update.
6053         * dwarf-index-write.c: Update.
6054         * dwarf2-frame-tailcall.c: Update.
6055         * dwarf2-frame.c: Update.
6056         * dwarf2loc.c: Update.
6057         * dwarf2read.c: Update.
6058         * eval.c: Update.
6059         * event-loop.c: Update.
6060         * event-top.c: Update.
6061         * exec.c: Update.
6062         * f-valprint.c: Update.
6063         * fbsd-tdep.c: Update.
6064         * frame-unwind.c: Update.
6065         * frame.c: Update.
6066         * gdbtypes.c: Update.
6067         * gnu-v3-abi.c: Update.
6068         * guile/guile-internal.h: Update.
6069         * guile/scm-block.c: Update.
6070         * guile/scm-breakpoint.c: Update.
6071         * guile/scm-cmd.c: Update.
6072         * guile/scm-disasm.c: Update.
6073         * guile/scm-frame.c: Update.
6074         * guile/scm-lazy-string.c: Update.
6075         * guile/scm-math.c: Update.
6076         * guile/scm-param.c: Update.
6077         * guile/scm-ports.c: Update.
6078         * guile/scm-pretty-print.c: Update.
6079         * guile/scm-symbol.c: Update.
6080         * guile/scm-symtab.c: Update.
6081         * guile/scm-type.c: Update.
6082         * guile/scm-value.c: Update.
6083         * i386-linux-tdep.c: Update.
6084         * i386-tdep.c: Update.
6085         * inf-loop.c: Update.
6086         * infcall.c: Update.
6087         * infcmd.c: Update.
6088         * infrun.c: Update.
6089         * jit.c: Update.
6090         * language.c: Update.
6091         * linespec.c: Update.
6092         * linux-fork.c: Update.
6093         * linux-nat.c: Update.
6094         * linux-tdep.c: Update.
6095         * linux-thread-db.c: Update.
6096         * main.c: Update.
6097         * mi/mi-cmd-break.c: Update.
6098         * mi/mi-cmd-stack.c: Update.
6099         * mi/mi-interp.c: Update.
6100         * mi/mi-main.c: Update.
6101         * objc-lang.c: Update.
6102         * p-valprint.c: Update.
6103         * parse.c: Update.
6104         * ppc-linux-tdep.c: Update.
6105         * printcmd.c: Update.
6106         * python/py-arch.c: Update.
6107         * python/py-breakpoint.c: Update.
6108         * python/py-cmd.c: Update.
6109         * python/py-finishbreakpoint.c: Update.
6110         * python/py-frame.c: Update.
6111         * python/py-framefilter.c: Update.
6112         * python/py-gdb-readline.c: Update.
6113         * python/py-inferior.c: Update.
6114         * python/py-infthread.c: Update.
6115         * python/py-lazy-string.c: Update.
6116         * python/py-linetable.c: Update.
6117         * python/py-objfile.c: Update.
6118         * python/py-param.c: Update.
6119         * python/py-prettyprint.c: Update.
6120         * python/py-progspace.c: Update.
6121         * python/py-record-btrace.c: Update.
6122         * python/py-record.c: Update.
6123         * python/py-symbol.c: Update.
6124         * python/py-type.c: Update.
6125         * python/py-unwind.c: Update.
6126         * python/py-utils.c: Update.
6127         * python/py-value.c: Update.
6128         * python/python.c: Update.
6129         * record-btrace.c: Update.
6130         * record-full.c: Update.
6131         * remote-fileio.c: Update.
6132         * remote.c: Update.
6133         * riscv-tdep.c: Update.
6134         * rs6000-aix-tdep.c: Update.
6135         * rs6000-tdep.c: Update.
6136         * rust-exp.y: Update.
6137         * rust-lang.c: Update.
6138         * s390-tdep.c: Update.
6139         * selftest-arch.c: Update.
6140         * solib-dsbt.c: Update.
6141         * solib-frv.c: Update.
6142         * solib-spu.c: Update.
6143         * solib-svr4.c: Update.
6144         * solib.c: Update.
6145         * sparc64-linux-tdep.c: Update.
6146         * stack.c: Update.
6147         * symfile-mem.c: Update.
6148         * symmisc.c: Update.
6149         * target.c: Update.
6150         * thread.c: Update.
6151         * top.c: Update.
6152         * tracefile-tfile.c: Update.
6153         * tui/tui.c: Update.
6154         * typeprint.c: Update.
6155         * unittests/cli-utils-selftests.c: Update.
6156         * unittests/parse-connection-spec-selftests.c: Update.
6157         * valops.c: Update.
6158         * valprint.c: Update.
6159         * value.c: Update.
6160         * varobj.c: Update.
6161         * windows-nat.c: Update.
6162         * x86-linux-nat.c: Update.
6163         * xml-support.c: Update.
6164
6165 2019-04-08  Tom Tromey  <tom@tromey.com>
6166
6167         * xml-support.c: Use C++ exception handling.
6168         * x86-linux-nat.c: Use C++ exception handling.
6169         * windows-nat.c: Use C++ exception handling.
6170         * varobj.c: Use C++ exception handling.
6171         * value.c: Use C++ exception handling.
6172         * valprint.c: Use C++ exception handling.
6173         * valops.c: Use C++ exception handling.
6174         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6175         handling.
6176         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6177         * typeprint.c: Use C++ exception handling.
6178         * tui/tui.c: Use C++ exception handling.
6179         * tracefile-tfile.c: Use C++ exception handling.
6180         * top.c: Use C++ exception handling.
6181         * thread.c: Use C++ exception handling.
6182         * target.c: Use C++ exception handling.
6183         * symmisc.c: Use C++ exception handling.
6184         * symfile-mem.c: Use C++ exception handling.
6185         * stack.c: Use C++ exception handling.
6186         * sparc64-linux-tdep.c: Use C++ exception handling.
6187         * solib.c: Use C++ exception handling.
6188         * solib-svr4.c: Use C++ exception handling.
6189         * solib-spu.c: Use C++ exception handling.
6190         * solib-frv.c: Use C++ exception handling.
6191         * solib-dsbt.c: Use C++ exception handling.
6192         * selftest-arch.c: Use C++ exception handling.
6193         * s390-tdep.c: Use C++ exception handling.
6194         * rust-lang.c: Use C++ exception handling.
6195         * rust-exp.y: Use C++ exception handling.
6196         * rs6000-tdep.c: Use C++ exception handling.
6197         * rs6000-aix-tdep.c: Use C++ exception handling.
6198         * riscv-tdep.c: Use C++ exception handling.
6199         * remote.c: Use C++ exception handling.
6200         * remote-fileio.c: Use C++ exception handling.
6201         * record-full.c: Use C++ exception handling.
6202         * record-btrace.c: Use C++ exception handling.
6203         * python/python.c: Use C++ exception handling.
6204         * python/py-value.c: Use C++ exception handling.
6205         * python/py-utils.c: Use C++ exception handling.
6206         * python/py-unwind.c: Use C++ exception handling.
6207         * python/py-type.c: Use C++ exception handling.
6208         * python/py-symbol.c: Use C++ exception handling.
6209         * python/py-record.c: Use C++ exception handling.
6210         * python/py-record-btrace.c: Use C++ exception handling.
6211         * python/py-progspace.c: Use C++ exception handling.
6212         * python/py-prettyprint.c: Use C++ exception handling.
6213         * python/py-param.c: Use C++ exception handling.
6214         * python/py-objfile.c: Use C++ exception handling.
6215         * python/py-linetable.c: Use C++ exception handling.
6216         * python/py-lazy-string.c: Use C++ exception handling.
6217         * python/py-infthread.c: Use C++ exception handling.
6218         * python/py-inferior.c: Use C++ exception handling.
6219         * python/py-gdb-readline.c: Use C++ exception handling.
6220         * python/py-framefilter.c: Use C++ exception handling.
6221         * python/py-frame.c: Use C++ exception handling.
6222         * python/py-finishbreakpoint.c: Use C++ exception handling.
6223         * python/py-cmd.c: Use C++ exception handling.
6224         * python/py-breakpoint.c: Use C++ exception handling.
6225         * python/py-arch.c: Use C++ exception handling.
6226         * printcmd.c: Use C++ exception handling.
6227         * ppc-linux-tdep.c: Use C++ exception handling.
6228         * parse.c: Use C++ exception handling.
6229         * p-valprint.c: Use C++ exception handling.
6230         * objc-lang.c: Use C++ exception handling.
6231         * mi/mi-main.c: Use C++ exception handling.
6232         * mi/mi-interp.c: Use C++ exception handling.
6233         * mi/mi-cmd-stack.c: Use C++ exception handling.
6234         * mi/mi-cmd-break.c: Use C++ exception handling.
6235         * main.c: Use C++ exception handling.
6236         * linux-thread-db.c: Use C++ exception handling.
6237         * linux-tdep.c: Use C++ exception handling.
6238         * linux-nat.c: Use C++ exception handling.
6239         * linux-fork.c: Use C++ exception handling.
6240         * linespec.c: Use C++ exception handling.
6241         * language.c: Use C++ exception handling.
6242         * jit.c: Use C++ exception handling.
6243         * infrun.c: Use C++ exception handling.
6244         * infcmd.c: Use C++ exception handling.
6245         * infcall.c: Use C++ exception handling.
6246         * inf-loop.c: Use C++ exception handling.
6247         * i386-tdep.c: Use C++ exception handling.
6248         * i386-linux-tdep.c: Use C++ exception handling.
6249         * guile/scm-value.c: Use C++ exception handling.
6250         * guile/scm-type.c: Use C++ exception handling.
6251         * guile/scm-symtab.c: Use C++ exception handling.
6252         * guile/scm-symbol.c: Use C++ exception handling.
6253         * guile/scm-pretty-print.c: Use C++ exception handling.
6254         * guile/scm-ports.c: Use C++ exception handling.
6255         * guile/scm-param.c: Use C++ exception handling.
6256         * guile/scm-math.c: Use C++ exception handling.
6257         * guile/scm-lazy-string.c: Use C++ exception handling.
6258         * guile/scm-frame.c: Use C++ exception handling.
6259         * guile/scm-disasm.c: Use C++ exception handling.
6260         * guile/scm-cmd.c: Use C++ exception handling.
6261         * guile/scm-breakpoint.c: Use C++ exception handling.
6262         * guile/scm-block.c: Use C++ exception handling.
6263         * guile/guile-internal.h: Use C++ exception handling.
6264         * gnu-v3-abi.c: Use C++ exception handling.
6265         * gdbtypes.c: Use C++ exception handling.
6266         * frame.c: Use C++ exception handling.
6267         * frame-unwind.c: Use C++ exception handling.
6268         * fbsd-tdep.c: Use C++ exception handling.
6269         * f-valprint.c: Use C++ exception handling.
6270         * exec.c: Use C++ exception handling.
6271         * event-top.c: Use C++ exception handling.
6272         * event-loop.c: Use C++ exception handling.
6273         * eval.c: Use C++ exception handling.
6274         * dwarf2read.c: Use C++ exception handling.
6275         * dwarf2loc.c: Use C++ exception handling.
6276         * dwarf2-frame.c: Use C++ exception handling.
6277         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6278         * dwarf-index-write.c: Use C++ exception handling.
6279         * dwarf-index-cache.c: Use C++ exception handling.
6280         * dtrace-probe.c: Use C++ exception handling.
6281         * disasm-selftests.c: Use C++ exception handling.
6282         * darwin-nat.c: Use C++ exception handling.
6283         * cp-valprint.c: Use C++ exception handling.
6284         * cp-support.c: Use C++ exception handling.
6285         * cp-abi.c: Use C++ exception handling.
6286         * corelow.c: Use C++ exception handling.
6287         * completer.c: Use C++ exception handling.
6288         * compile/compile-object-run.c: Use C++ exception handling.
6289         * compile/compile-object-load.c: Use C++ exception handling.
6290         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6291         * compile/compile-c-symbols.c: Use C++ exception handling.
6292         * common/selftest.c: Use C++ exception handling.
6293         * common/new-op.c: Use C++ exception handling.
6294         * cli/cli-script.c: Use C++ exception handling.
6295         * cli/cli-interp.c: Use C++ exception handling.
6296         * cli/cli-cmds.c: Use C++ exception handling.
6297         * c-varobj.c: Use C++ exception handling.
6298         * btrace.c: Use C++ exception handling.
6299         * breakpoint.c: Use C++ exception handling.
6300         * break-catch-throw.c: Use C++ exception handling.
6301         * arch-utils.c: Use C++ exception handling.
6302         * amd64-tdep.c: Use C++ exception handling.
6303         * ada-valprint.c: Use C++ exception handling.
6304         * ada-typeprint.c: Use C++ exception handling.
6305         * ada-lang.c: Use C++ exception handling.
6306         * aarch64-tdep.c: Use C++ exception handling.
6307
6308 2019-04-08  Tom Tromey  <tom@tromey.com>
6309
6310         * xml-support.c (gdb_xml_parser::parse): Update.
6311         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6312         * value.c (show_convenience): Update.
6313         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6314         (test_parse_flags_qcs): Update.
6315         * thread.c (thr_try_catch_cmd): Update.
6316         * target.c (target_translate_tls_address): Update.
6317         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6318         (info_frame_command_core, frame_apply_command_count): Update.
6319         * rust-exp.y (rust_lex_exception_test): Update.
6320         * riscv-tdep.c (riscv_print_one_register_info): Update.
6321         * remote.c (remote_target::enable_btrace): Update.
6322         * record-btrace.c (record_btrace_enable_warn): Update.
6323         * python/py-utils.c (gdbpy_convert_exception): Update.
6324         * printcmd.c (do_one_display, print_variable_and_value): Update.
6325         * mi/mi-main.c (mi_print_exception): Update.
6326         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6327         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6328         * linux-nat.c (linux_nat_target::attach): Update.
6329         * linux-fork.c (class scoped_switch_fork_info): Update.
6330         * infrun.c (displaced_step_prepare): Update.
6331         * infcall.c (call_function_by_hand_dummy): Update.
6332         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6333         * gnu-v3-abi.c (print_one_vtable): Update.
6334         * frame.c (get_prev_frame_always): Update.
6335         * f-valprint.c (info_common_command_for_block): Update.
6336         * exec.c (try_open_exec_file): Update.
6337         * exceptions.c (print_exception, exception_print)
6338         (exception_fprintf, exception_print_same): Update.
6339         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6340         * dwarf-index-cache.c (index_cache::store)
6341         (index_cache::lookup_gdb_index): Update.
6342         * darwin-nat.c (maybe_cache_shell): Update.
6343         * cp-valprint.c (cp_print_value_fields): Update.
6344         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6345         (gcc_cplus_symbol_address): Update.
6346         * compile/compile-c-symbols.c (gcc_convert_symbol)
6347         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6348         * common/selftest.c: Update.
6349         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6350         a std::string.
6351         (exception_try_scope_entry, exception_try_scope_exit): Don't
6352         declare.
6353         (struct exception_try_scope): Remove.
6354         (TRY): Don't use exception_try_scope.
6355         (struct gdb_exception): Add constructor, operator=.
6356         <what>: New method.
6357         (struct gdb_exception_RETURN_MASK_ALL)
6358         (struct gdb_exception_RETURN_MASK_ERROR)
6359         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6360         (struct gdb_quit_bad_alloc): Update.
6361         * common/common-exceptions.c (exception_none): Change
6362         initializer.
6363         (struct catcher) <state, exception>: Initialize inline.
6364         <prev>: Remove member.
6365         (current_catcher): Remove.
6366         (catchers): New global.
6367         (exceptions_state_mc_init): Simplify.
6368         (catcher_pop): Remove.
6369         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6370         (try_scope_depth, exception_try_scope_entry)
6371         (exception_try_scope_exit): Remove.
6372         (throw_exception_sjlj): Update.
6373         (exception_messages, exception_messages_size): Remove.
6374         (throw_it): Simplify.
6375         (gdb_exception_sliced_copy): Remove.
6376         (throw_exception_cxx): Update.
6377         * cli/cli-script.c (script_from_file): Update.
6378         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6379         Update.
6380         * ada-valprint.c (ada_val_print): Update.
6381         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6382         (create_excep_cond_exprs): Update.
6383
6384 2019-04-08  Tom Tromey  <tom@tromey.com>
6385
6386         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6387         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6388         (TRY, CATCH, END_CATCH): Remove some definitions.
6389         * common/common-exceptions.c: Don't use GDB_XCPT.
6390         (catcher_list_size): Remove.
6391         (throw_exception, throw_it): Simplify.
6392
6393 2019-04-05  Tom Tromey  <tom@tromey.com>
6394
6395         Revert the header-sorting patch.
6396         * ft32-tdep.c: Revert.
6397         * frv-tdep.c: Revert.
6398         * frv-linux-tdep.c: Revert.
6399         * frame.c: Revert.
6400         * frame-unwind.c: Revert.
6401         * frame-base.c: Revert.
6402         * fork-child.c: Revert.
6403         * findvar.c: Revert.
6404         * findcmd.c: Revert.
6405         * filesystem.c: Revert.
6406         * filename-seen-cache.h: Revert.
6407         * filename-seen-cache.c: Revert.
6408         * fbsd-tdep.c: Revert.
6409         * fbsd-nat.h: Revert.
6410         * fbsd-nat.c: Revert.
6411         * f-valprint.c: Revert.
6412         * f-typeprint.c: Revert.
6413         * f-lang.c: Revert.
6414         * extension.h: Revert.
6415         * extension.c: Revert.
6416         * extension-priv.h: Revert.
6417         * expprint.c: Revert.
6418         * exec.h: Revert.
6419         * exec.c: Revert.
6420         * exceptions.c: Revert.
6421         * event-top.c: Revert.
6422         * event-loop.c: Revert.
6423         * eval.c: Revert.
6424         * elfread.c: Revert.
6425         * dwarf2read.h: Revert.
6426         * dwarf2read.c: Revert.
6427         * dwarf2loc.c: Revert.
6428         * dwarf2expr.h: Revert.
6429         * dwarf2expr.c: Revert.
6430         * dwarf2-frame.c: Revert.
6431         * dwarf2-frame-tailcall.c: Revert.
6432         * dwarf-index-write.h: Revert.
6433         * dwarf-index-write.c: Revert.
6434         * dwarf-index-common.c: Revert.
6435         * dwarf-index-cache.h: Revert.
6436         * dwarf-index-cache.c: Revert.
6437         * dummy-frame.c: Revert.
6438         * dtrace-probe.c: Revert.
6439         * disasm.h: Revert.
6440         * disasm.c: Revert.
6441         * disasm-selftests.c: Revert.
6442         * dictionary.c: Revert.
6443         * dicos-tdep.c: Revert.
6444         * demangle.c: Revert.
6445         * dcache.h: Revert.
6446         * dcache.c: Revert.
6447         * darwin-nat.h: Revert.
6448         * darwin-nat.c: Revert.
6449         * darwin-nat-info.c: Revert.
6450         * d-valprint.c: Revert.
6451         * d-namespace.c: Revert.
6452         * d-lang.c: Revert.
6453         * ctf.c: Revert.
6454         * csky-tdep.c: Revert.
6455         * csky-linux-tdep.c: Revert.
6456         * cris-tdep.c: Revert.
6457         * cris-linux-tdep.c: Revert.
6458         * cp-valprint.c: Revert.
6459         * cp-support.c: Revert.
6460         * cp-namespace.c: Revert.
6461         * cp-abi.c: Revert.
6462         * corelow.c: Revert.
6463         * corefile.c: Revert.
6464         * continuations.c: Revert.
6465         * completer.h: Revert.
6466         * completer.c: Revert.
6467         * complaints.c: Revert.
6468         * coffread.c: Revert.
6469         * coff-pe-read.c: Revert.
6470         * cli-out.h: Revert.
6471         * cli-out.c: Revert.
6472         * charset.c: Revert.
6473         * c-varobj.c: Revert.
6474         * c-valprint.c: Revert.
6475         * c-typeprint.c: Revert.
6476         * c-lang.c: Revert.
6477         * buildsym.c: Revert.
6478         * buildsym-legacy.c: Revert.
6479         * build-id.h: Revert.
6480         * build-id.c: Revert.
6481         * btrace.c: Revert.
6482         * bsd-uthread.c: Revert.
6483         * breakpoint.h: Revert.
6484         * breakpoint.c: Revert.
6485         * break-catch-throw.c: Revert.
6486         * break-catch-syscall.c: Revert.
6487         * break-catch-sig.c: Revert.
6488         * blockframe.c: Revert.
6489         * block.c: Revert.
6490         * bfin-tdep.c: Revert.
6491         * bfin-linux-tdep.c: Revert.
6492         * bfd-target.c: Revert.
6493         * bcache.c: Revert.
6494         * ax-general.c: Revert.
6495         * ax-gdb.h: Revert.
6496         * ax-gdb.c: Revert.
6497         * avr-tdep.c: Revert.
6498         * auxv.c: Revert.
6499         * auto-load.c: Revert.
6500         * arm-wince-tdep.c: Revert.
6501         * arm-tdep.c: Revert.
6502         * arm-symbian-tdep.c: Revert.
6503         * arm-pikeos-tdep.c: Revert.
6504         * arm-obsd-tdep.c: Revert.
6505         * arm-nbsd-tdep.c: Revert.
6506         * arm-nbsd-nat.c: Revert.
6507         * arm-linux-tdep.c: Revert.
6508         * arm-linux-nat.c: Revert.
6509         * arm-fbsd-tdep.c: Revert.
6510         * arm-fbsd-nat.c: Revert.
6511         * arm-bsd-tdep.c: Revert.
6512         * arch-utils.c: Revert.
6513         * arc-tdep.c: Revert.
6514         * arc-newlib-tdep.c: Revert.
6515         * annotate.h: Revert.
6516         * annotate.c: Revert.
6517         * amd64-windows-tdep.c: Revert.
6518         * amd64-windows-nat.c: Revert.
6519         * amd64-tdep.c: Revert.
6520         * amd64-sol2-tdep.c: Revert.
6521         * amd64-obsd-tdep.c: Revert.
6522         * amd64-obsd-nat.c: Revert.
6523         * amd64-nbsd-tdep.c: Revert.
6524         * amd64-nbsd-nat.c: Revert.
6525         * amd64-nat.c: Revert.
6526         * amd64-linux-tdep.c: Revert.
6527         * amd64-linux-nat.c: Revert.
6528         * amd64-fbsd-tdep.c: Revert.
6529         * amd64-fbsd-nat.c: Revert.
6530         * amd64-dicos-tdep.c: Revert.
6531         * amd64-darwin-tdep.c: Revert.
6532         * amd64-bsd-nat.c: Revert.
6533         * alpha-tdep.c: Revert.
6534         * alpha-obsd-tdep.c: Revert.
6535         * alpha-nbsd-tdep.c: Revert.
6536         * alpha-mdebug-tdep.c: Revert.
6537         * alpha-linux-tdep.c: Revert.
6538         * alpha-linux-nat.c: Revert.
6539         * alpha-bsd-tdep.c: Revert.
6540         * alpha-bsd-nat.c: Revert.
6541         * aix-thread.c: Revert.
6542         * agent.c: Revert.
6543         * addrmap.c: Revert.
6544         * ada-varobj.c: Revert.
6545         * ada-valprint.c: Revert.
6546         * ada-typeprint.c: Revert.
6547         * ada-tasks.c: Revert.
6548         * ada-lang.c: Revert.
6549         * aarch64-tdep.c: Revert.
6550         * aarch64-ravenscar-thread.c: Revert.
6551         * aarch64-newlib-tdep.c: Revert.
6552         * aarch64-linux-tdep.c: Revert.
6553         * aarch64-linux-nat.c: Revert.
6554         * aarch64-fbsd-tdep.c: Revert.
6555         * aarch64-fbsd-nat.c: Revert.
6556         * aarch32-linux-nat.c: Revert.
6557
6558 2019-04-05  Tom Tromey  <tom@tromey.com>
6559
6560         * ft32-tdep.c: Sort headers.
6561         * frv-tdep.c: Sort headers.
6562         * frv-linux-tdep.c: Sort headers.
6563         * frame.c: Sort headers.
6564         * frame-unwind.c: Sort headers.
6565         * frame-base.c: Sort headers.
6566         * fork-child.c: Sort headers.
6567         * findvar.c: Sort headers.
6568         * findcmd.c: Sort headers.
6569         * filesystem.c: Sort headers.
6570         * filename-seen-cache.h: Sort headers.
6571         * filename-seen-cache.c: Sort headers.
6572         * fbsd-tdep.c: Sort headers.
6573         * fbsd-nat.h: Sort headers.
6574         * fbsd-nat.c: Sort headers.
6575         * f-valprint.c: Sort headers.
6576         * f-typeprint.c: Sort headers.
6577         * f-lang.c: Sort headers.
6578         * extension.h: Sort headers.
6579         * extension.c: Sort headers.
6580         * extension-priv.h: Sort headers.
6581         * expprint.c: Sort headers.
6582         * exec.h: Sort headers.
6583         * exec.c: Sort headers.
6584         * exceptions.c: Sort headers.
6585         * event-top.c: Sort headers.
6586         * event-loop.c: Sort headers.
6587         * eval.c: Sort headers.
6588         * elfread.c: Sort headers.
6589         * dwarf2read.h: Sort headers.
6590         * dwarf2read.c: Sort headers.
6591         * dwarf2loc.c: Sort headers.
6592         * dwarf2expr.h: Sort headers.
6593         * dwarf2expr.c: Sort headers.
6594         * dwarf2-frame.c: Sort headers.
6595         * dwarf2-frame-tailcall.c: Sort headers.
6596         * dwarf-index-write.h: Sort headers.
6597         * dwarf-index-write.c: Sort headers.
6598         * dwarf-index-common.c: Sort headers.
6599         * dwarf-index-cache.h: Sort headers.
6600         * dwarf-index-cache.c: Sort headers.
6601         * dummy-frame.c: Sort headers.
6602         * dtrace-probe.c: Sort headers.
6603         * disasm.h: Sort headers.
6604         * disasm.c: Sort headers.
6605         * disasm-selftests.c: Sort headers.
6606         * dictionary.c: Sort headers.
6607         * dicos-tdep.c: Sort headers.
6608         * demangle.c: Sort headers.
6609         * dcache.h: Sort headers.
6610         * dcache.c: Sort headers.
6611         * darwin-nat.h: Sort headers.
6612         * darwin-nat.c: Sort headers.
6613         * darwin-nat-info.c: Sort headers.
6614         * d-valprint.c: Sort headers.
6615         * d-namespace.c: Sort headers.
6616         * d-lang.c: Sort headers.
6617         * ctf.c: Sort headers.
6618         * csky-tdep.c: Sort headers.
6619         * csky-linux-tdep.c: Sort headers.
6620         * cris-tdep.c: Sort headers.
6621         * cris-linux-tdep.c: Sort headers.
6622         * cp-valprint.c: Sort headers.
6623         * cp-support.c: Sort headers.
6624         * cp-namespace.c: Sort headers.
6625         * cp-abi.c: Sort headers.
6626         * corelow.c: Sort headers.
6627         * corefile.c: Sort headers.
6628         * continuations.c: Sort headers.
6629         * completer.h: Sort headers.
6630         * completer.c: Sort headers.
6631         * complaints.c: Sort headers.
6632         * coffread.c: Sort headers.
6633         * coff-pe-read.c: Sort headers.
6634         * cli-out.h: Sort headers.
6635         * cli-out.c: Sort headers.
6636         * charset.c: Sort headers.
6637         * c-varobj.c: Sort headers.
6638         * c-valprint.c: Sort headers.
6639         * c-typeprint.c: Sort headers.
6640         * c-lang.c: Sort headers.
6641         * buildsym.c: Sort headers.
6642         * buildsym-legacy.c: Sort headers.
6643         * build-id.h: Sort headers.
6644         * build-id.c: Sort headers.
6645         * btrace.c: Sort headers.
6646         * bsd-uthread.c: Sort headers.
6647         * breakpoint.h: Sort headers.
6648         * breakpoint.c: Sort headers.
6649         * break-catch-throw.c: Sort headers.
6650         * break-catch-syscall.c: Sort headers.
6651         * break-catch-sig.c: Sort headers.
6652         * blockframe.c: Sort headers.
6653         * block.c: Sort headers.
6654         * bfin-tdep.c: Sort headers.
6655         * bfin-linux-tdep.c: Sort headers.
6656         * bfd-target.c: Sort headers.
6657         * bcache.c: Sort headers.
6658         * ax-general.c: Sort headers.
6659         * ax-gdb.h: Sort headers.
6660         * ax-gdb.c: Sort headers.
6661         * avr-tdep.c: Sort headers.
6662         * auxv.c: Sort headers.
6663         * auto-load.c: Sort headers.
6664         * arm-wince-tdep.c: Sort headers.
6665         * arm-tdep.c: Sort headers.
6666         * arm-symbian-tdep.c: Sort headers.
6667         * arm-pikeos-tdep.c: Sort headers.
6668         * arm-obsd-tdep.c: Sort headers.
6669         * arm-nbsd-tdep.c: Sort headers.
6670         * arm-nbsd-nat.c: Sort headers.
6671         * arm-linux-tdep.c: Sort headers.
6672         * arm-linux-nat.c: Sort headers.
6673         * arm-fbsd-tdep.c: Sort headers.
6674         * arm-fbsd-nat.c: Sort headers.
6675         * arm-bsd-tdep.c: Sort headers.
6676         * arch-utils.c: Sort headers.
6677         * arc-tdep.c: Sort headers.
6678         * arc-newlib-tdep.c: Sort headers.
6679         * annotate.h: Sort headers.
6680         * annotate.c: Sort headers.
6681         * amd64-windows-tdep.c: Sort headers.
6682         * amd64-windows-nat.c: Sort headers.
6683         * amd64-tdep.c: Sort headers.
6684         * amd64-sol2-tdep.c: Sort headers.
6685         * amd64-obsd-tdep.c: Sort headers.
6686         * amd64-obsd-nat.c: Sort headers.
6687         * amd64-nbsd-tdep.c: Sort headers.
6688         * amd64-nbsd-nat.c: Sort headers.
6689         * amd64-nat.c: Sort headers.
6690         * amd64-linux-tdep.c: Sort headers.
6691         * amd64-linux-nat.c: Sort headers.
6692         * amd64-fbsd-tdep.c: Sort headers.
6693         * amd64-fbsd-nat.c: Sort headers.
6694         * amd64-dicos-tdep.c: Sort headers.
6695         * amd64-darwin-tdep.c: Sort headers.
6696         * amd64-bsd-nat.c: Sort headers.
6697         * alpha-tdep.c: Sort headers.
6698         * alpha-obsd-tdep.c: Sort headers.
6699         * alpha-nbsd-tdep.c: Sort headers.
6700         * alpha-mdebug-tdep.c: Sort headers.
6701         * alpha-linux-tdep.c: Sort headers.
6702         * alpha-linux-nat.c: Sort headers.
6703         * alpha-bsd-tdep.c: Sort headers.
6704         * alpha-bsd-nat.c: Sort headers.
6705         * aix-thread.c: Sort headers.
6706         * agent.c: Sort headers.
6707         * addrmap.c: Sort headers.
6708         * ada-varobj.c: Sort headers.
6709         * ada-valprint.c: Sort headers.
6710         * ada-typeprint.c: Sort headers.
6711         * ada-tasks.c: Sort headers.
6712         * ada-lang.c: Sort headers.
6713         * aarch64-tdep.c: Sort headers.
6714         * aarch64-ravenscar-thread.c: Sort headers.
6715         * aarch64-newlib-tdep.c: Sort headers.
6716         * aarch64-linux-tdep.c: Sort headers.
6717         * aarch64-linux-nat.c: Sort headers.
6718         * aarch64-fbsd-tdep.c: Sort headers.
6719         * aarch64-fbsd-nat.c: Sort headers.
6720         * aarch32-linux-nat.c: Sort headers.
6721
6722 2019-04-04  Tom Tromey  <tom@tromey.com>
6723
6724         * varobj.c (varobj_create): Update.
6725         * rust-exp.y (struct rust_parser) <update_innermost_block,
6726         lookup_symbol>: New methods.
6727         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6728         Rename.
6729         (rust_parser::rust_lookup_type)
6730         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6731         * printcmd.c (display_command, do_one_display): Update.
6732         * parser-defs.h (struct parser_state) <parser_state>: Add
6733         "tracker" parameter.
6734         (block_tracker): New member.
6735         (class innermost_block_tracker) <innermost_block_tracker>: Add
6736         "types" parameter.
6737         <reset>: Remove method.
6738         (innermost_block): Don't declare.
6739         (null_post_parser): Update.
6740         * parse.c (innermost_block): Remove global.
6741         (write_dollar_variable): Update.
6742         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6743         Remove "tracker_types" parameter.
6744         (parse_expression): Add "tracker" parameter.
6745         (parse_expression_for_completion): Update.
6746         (null_post_parser): Add "tracker" parameter.
6747         * p-exp.y: Update rules.
6748         * m2-exp.y: Update rules.
6749         * language.h (struct language_defn) <la_post_parser>: Add
6750         "tracker" parameter.
6751         * go-exp.y: Update rules.
6752         * f-exp.y: Update rules.
6753         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6754         parameter.
6755         * d-exp.y: Update rules.
6756         * c-exp.y: Update rules.
6757         * breakpoint.c (set_breakpoint_condition): Create an
6758         innermost_block_tracker.
6759         (watch_command_1): Likewise.
6760         * ada-lang.c (resolve): Add "tracker" parameter.
6761         (resolve_subexp): Likewise.
6762         * ada-exp.y (write_var_from_sym): Update.
6763
6764 2019-04-04  Tom Tromey  <tom@tromey.com>
6765
6766         * type-stack.h: New file.
6767         * type-stack.c: New file.
6768         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6769         type-stack.h.
6770         (insert_into_type_stack, insert_type, push_type, push_type_int)
6771         (insert_type_address_space, pop_type, pop_type_int)
6772         (pop_typelist, pop_type_stack, append_type_stack)
6773         (push_type_stack, get_type_stack, push_typelist)
6774         (follow_type_instance_flags, follow_types): Don't declare.
6775         * parse.c (type_stack): Remove global.
6776         (parse_exp_in_context): Update.
6777         (insert_into_type_stack, insert_type, push_type, push_type_int)
6778         (insert_type_address_space, pop_type, pop_type_int)
6779         (pop_typelist, pop_type_stack, append_type_stack)
6780         (push_type_stack, get_type_stack, push_typelist)
6781         (follow_type_instance_flags, follow_types): Remove (moved to
6782         type-stack.c).
6783         * f-exp.y (type_stack): New global.
6784         Update rules.
6785         (push_kind_type, f_parse): Update.
6786         * d-exp.y (type_stack): New global.
6787         Update rules.
6788         (d_parse): Update.
6789         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6790         Update rules.
6791         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6792         (HFILES_NO_SRCDIR): Add type-stack.h.
6793
6794 2019-04-04  Tom Tromey  <tom@tromey.com>
6795
6796         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6797         (rust_parser::convert_ast_to_expression, rust_parse)
6798         (rust_lex_test_completion, rust_lex_tests): Update.
6799         * parser-defs.h (struct expr_completion_state): New.
6800         (struct parser_state) <parser_state>: Add completion parameter.
6801         <mark_struct_expression, mark_completion_tag>: New methods.
6802         <parse_completion, m_completion_state>: New members.
6803         (prefixify_expression, null_post_parser): Update.
6804         (mark_struct_expression, mark_completion_tag): Don't declare.
6805         * parse.c (parse_completion, expout_last_struct)
6806         (expout_tag_completion_type, expout_completion_name): Remove
6807         globals.
6808         (parser_state::mark_struct_expression)
6809         (parser_state::mark_completion_tag): Now methods.
6810         (prefixify_expression): Add last_struct parameter.
6811         (prefixify_subexp): Likewise.
6812         (parse_exp_1): Update.
6813         (parse_exp_in_context): Add cstate parameter.  Update.
6814         (parse_expression_for_completion): Create an
6815         expr_completion_state.
6816         (null_post_parser): Add "completion" parameter.
6817         * p-exp.y: Update rules.
6818         (yylex): Update.
6819         * language.h (struct language_defn) <la_post_parser>: Add
6820         "completing" parameter.
6821         * go-exp.y: Update rules.
6822         (lex_one_token): Update.
6823         * expression.h (parse_completion): Don't declare.
6824         * d-exp.y: Update rules.
6825         (lex_one_token): Update rules.
6826         * c-exp.y: Update rules.
6827         (lex_one_token): Update.
6828         * ada-lang.c (resolve): Add "parse_completion" parameter.
6829         (resolve_subexp): Likewise.
6830         (ada_resolve_function): Likewise.
6831
6832 2019-04-04  Tom Tromey  <tom@tromey.com>
6833
6834         * parser-defs.h (struct parser_state) <start_arglist,
6835         end_arglist>: New methods.
6836         <arglist_len, m_funcall_chain>: New members.
6837         (arglist_len, start_arglist, end_arglist): Don't declare.
6838         * parse.c (arglist_len, funcall_chain): Remove global.
6839         (start_arglist, end_arglist): Remove functions.
6840         (parse_exp_in_context): Update.
6841         * p-exp.y: Update rules.
6842         * m2-exp.y: Update rules.
6843         * go-exp.y: Update rules.
6844         * f-exp.y: Update rules.
6845         * d-exp.y: Update rules.
6846         * c-exp.y: Update rules.
6847
6848 2019-04-04  Tom Tromey  <tom@tromey.com>
6849
6850         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6851         lex_operator, push_back>: New methods.
6852         Update all rules.
6853         (rust_parser::lex_hex, lex_escape): Rename and update.
6854         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6855         (rust_parser::lex_operator): Rename and update.
6856         (rust_parser::lex_number, rustyylex, rustyyerror)
6857         (rust_lex_test_init, rust_lex_test_sequence)
6858         (rust_lex_test_push_back, rust_lex_tests): Update.
6859         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6860         parameter.
6861         <lexptr, prev_lexptr>: New members.
6862         (lexptr, prev_lexptr): Don't declare.
6863         * parse.c (lexptr, prev_lexptr): Remove globals.
6864         (parse_exp_in_context): Update.
6865         * p-exp.y (yylex, yyerror): Update.
6866         * m2-exp.y (parse_number, yylex, yyerror): Update.
6867         * go-exp.y (lex_one_token, yyerror): Update.
6868         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6869         * d-exp.y (lex_one_token, yyerror): Update.
6870         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6871         (lex_one_token, yyerror): Update.
6872         * ada-lex.l (YY_INPUT): Update.
6873         (rewind_to_char): Update.
6874         * ada-exp.y (yyerror): Update.
6875
6876 2019-04-04  Tom Tromey  <tom@tromey.com>
6877
6878         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6879         * parser-defs.h (struct parser_state) <parser_state>: Add new
6880         parameter.
6881         <comma_terminates>: New member.
6882         (comma_terminates): Don't declare global.
6883         * parse.c (comma_terminates): Remove global.
6884         (parse_exp_in_context): Update.
6885         * p-exp.y (yylex): Update.
6886         * m2-exp.y (yylex): Update.
6887         * go-exp.y (lex_one_token): Update.
6888         * f-exp.y (yylex): Update.
6889         * d-exp.y (lex_one_token): Update.
6890         * c-exp.y (lex_one_token): Update.
6891         * ada-lex.l: Update.
6892
6893 2019-04-04  Tom Tromey  <tom@tromey.com>
6894
6895         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6896         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6897         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6898         * parser-defs.h (paren_depth): Don't declare.
6899         * parse.c (paren_depth): Remove global.
6900         (parse_exp_in_context): Update.
6901         * p-exp.y (paren_depth): New global.
6902         (pascal_parse): Initialize it.
6903         * m2-exp.y (paren_depth): New global.
6904         (m2_parse): Initialize it.
6905         * go-exp.y (paren_depth): New global.
6906         (go_parse): Initialize it.
6907         * f-exp.y (paren_depth): New global.
6908         (f_parse): Initialize it.
6909         * d-exp.y (paren_depth): New global.
6910         (d_parse): Initialize it.
6911         * c-exp.y (paren_depth): New global.
6912         (c_parse): Initialize it.
6913         * ada-lex.l (paren_depth): New global.
6914         (lexer_init): Initialize it.
6915
6916 2019-04-04  Tom Tromey  <tom@tromey.com>
6917
6918         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6919         (rust_parser::convert_ast_to_type)
6920         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6921         * parser-defs.h (struct parser_state) <parser_state>: Add
6922         parameters.  Initialize new members.
6923         <expression_context_block, expression_context_pc>: New members.
6924         * parse.c (expression_context_block, expression_context_pc):
6925         Remove globals.
6926         (parse_exp_in_context): Update.
6927         * p-exp.y: Update all rules.
6928         (yylex): Update.
6929         * m2-exp.y: Update all rules.
6930         (yylex): Update.
6931         * go-exp.y (yylex): Update.
6932         * f-exp.y (yylex): Update.
6933         * d-exp.y: Update all rules.
6934         (yylex): Update.
6935         * c-exp.y: Update all rules.
6936         (lex_one_token, classify_name, yylex, c_parse): Update.
6937         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6938
6939 2019-04-04  Tom Tromey  <tom@tromey.com>
6940
6941         * gdbarch.h, gdbarch.c: Rebuild.
6942         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6943         * stap-probe.h:
6944         (struct stap_parse_info): Replace "parser_state" with
6945         "expr_builder".
6946         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6947         (parser_state): New class.
6948         * parse.c (expr_builder): Rename.
6949         (expr_builder::release): Rename.
6950         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6951         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6952         (write_exp_elt_longcst, write_exp_elt_floatcst)
6953         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6954         (write_exp_string_vector, write_exp_bitstring)
6955         (write_exp_msymbol, mark_struct_expression)
6956         (write_dollar_variable)
6957         (insert_type_address_space, increase_expout_size): Replace
6958         "parser_state" with "expr_builder".
6959         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6960         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6961         "parser_state" with "expr_builder".
6962
6963 2019-04-04  Tom Tromey  <tom@tromey.com>
6964
6965         * rust-exp.y: Replace "parse_language" with method call.
6966         * p-exp.y:
6967         (yylex): Replace "parse_language" with method call.
6968         * m2-exp.y:
6969         (yylex): Replace "parse_language" with method call.
6970         * go-exp.y (classify_name): Replace "parse_language" with method
6971         call.
6972         * f-exp.y (yylex): Replace "parse_language" with method call.
6973         * d-exp.y (lex_one_token): Replace "parse_language" with method
6974         call.
6975         * c-exp.y:
6976         (lex_one_token, classify_name, yylex): Replace "parse_language"
6977         with method call.
6978         * ada-exp.y (find_primitive_type, type_char)
6979         (type_system_address): Replace "parse_language" with method call.
6980
6981 2019-04-04  Tom Tromey  <tom@tromey.com>
6982
6983         * rust-exp.y: Replace "parse_gdbarch" with method call.
6984         * parse.c (write_dollar_variable, insert_type_address_space):
6985         Replace "parse_gdbarch" with method call.
6986         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6987         call.
6988         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6989         call.
6990         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6991         "parse_gdbarch" with method call.
6992         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6993         with method call.
6994         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6995         "parse_gdbarch" with method call.
6996         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6997         "parse_gdbarch" with method call.
6998         * c-exp.y (parse_type, parse_number, classify_name): Replace
6999         "parse_gdbarch" with method call.
7000         * ada-lex.l: Replace "parse_gdbarch" with method call.
7001         * ada-exp.y (parse_type, find_primitive_type, type_char)
7002         (type_system_address): Replace "parse_gdbarch" with method call.
7003
7004 2019-04-04  Tom Tromey  <tom@tromey.com>
7005
7006         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7007         * stap-probe.c (stap_parse_argument): Update.
7008         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7009         initial_size parameter.
7010         * rust-exp.y (rust_lex_tests): Update.
7011         * parse.c (parser_state): Update.
7012         (parse_exp_in_context): Update.
7013         * parser-defs.h (struct parser_state) <parser_state>: Remove
7014         "initial_size" parameter.
7015
7016 2019-04-04  Tom Tromey  <tom@tromey.com>
7017
7018         * parser-defs.h (increase_expout_size): Don't declare.
7019         * parse.c (increase_expout_size): Now static.
7020
7021 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7022
7023         * gnu-nat.c (gnu_nat_target::wait): Fix
7024         target_waitstatus_to_string call.
7025
7026 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7027
7028         * eval.c (evaluate_subexp_standard): Handle internal functions
7029         during Fortran function call handling.
7030
7031 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7032
7033         * NEWS: Mention new internal functions.
7034         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7035         (read_base_type): Use dwarf2_init_complex_target_type.
7036         * value.c (creal_internal_fn): New function.
7037         (cimag_internal_fn): New function.
7038         (_initialize_values): Register new internal functions.
7039
7040 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7041
7042         * infrun.c (stop_all_threads): If debug_infrun, always
7043         trace the wait status after wait_one, using
7044         target_waitstatus_to_string and target_pid_to_str.
7045         (handle_inferior_event): Replace various trace of
7046         wait status kind by a single trace.
7047         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7048         wait status kind image by target_waitstatus_to_string.
7049         * target/waitstatus.c (target_waitstatus_to_string): Fix
7050         obsolete comment.
7051
7052 2019-04-01  Tom Tromey  <tromey@adacore.com>
7053
7054         PR symtab/23331:
7055         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7056
7057 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7058             Pedro Alves  <palves@redhat.com>
7059
7060         * top.c (quit_force): Call 'finalize_values'.
7061         * value.c (finalize_values): New function.
7062         * value.h (finalize_values): Declare.
7063
7064 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7065
7066         * NEWS: Announce $_gdb_major and $_gdb_minor.
7067
7068         * top.c (init_gdb_version_vars): New function.
7069         (gdb_init): Call init_gdb_version_vars.
7070
7071 2019-03-29  Tom Tromey  <tromey@adacore.com>
7072
7073         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7074         help text.  Remove dead code.
7075
7076 2019-03-29  Keith Seitz  <keiths@redhat.com>
7077
7078         From Siddhesh Poyarekar:
7079         * f-lang.h (f77_get_upperbound): Return LONGEST.
7080         (f77_get_lowerbound): Likewise.
7081         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7082         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7083         print them.
7084         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7085         plongest to format print it.
7086         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7087         (f77_get_upperbound): Likewise.
7088         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7089         LOWER_BOUND to LONGEST.
7090         (f77_create_arrayprint_offset_tbl): Likewise.
7091
7092 2019-03-29  Keith Seitz  <keiths@redhat.com>
7093
7094         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7095         %s/pulongest for TYPE_LENGTH instead of %d in format
7096         strings.
7097         * ada-typerint.c (ada_print_type): Likewise.
7098         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7099         * compile/compile-c-support.c (generate_register_struct): Likewise.
7100         * gdbtypes.c (recursive_dump_type): Likewise.
7101         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7102         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7103         instead of %d in format strings.
7104         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7105         to std::min to ULONGEST.
7106         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7107         instead of %d in format strings.
7108         * tracepoint.c (info_scope_command): Likewise.
7109         * typeprint.c (print_offset_data::update)
7110         (print_offset_data::finish): Likewise.
7111         * xtensa-tdep.c (xtensa_store_return_value)
7112         (xtensa_push_dummy_call): Likewise.
7113
7114 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7115
7116         * windows-nat.c (display_selector): Fixed format specifications
7117         for 64-bit Cygwin.
7118
7119 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7120
7121         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7122
7123 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7124
7125         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7126         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7127         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7128         (nios2_linux_init_abi): Install it.
7129
7130 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7131
7132         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7133
7134 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7135
7136         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7137
7138 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7139             Tom Tromey  <tromey@adacore.com>
7140
7141         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7142
7143 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7144
7145         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7146         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7147         method to compute the bounds of range types. Also print "[evaluated]"
7148         if the bounds' values come from a dynamic evaluation.
7149
7150 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7151
7152         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7153         whitespace when pretty printing is on.
7154
7155 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7156
7157         * ppc-linux-nat.c: Add include.
7158
7159 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7160
7161         * NEWS: Mention AArch64 Pointer Authentication.
7162
7163 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7164
7165         * arm-linux-nat.c: Add include.
7166
7167 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7168
7169         * source-cache.c (source_cache::get_source_lines): Re-read
7170         fullname after calling open_source_file.
7171
7172 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7173
7174         * NEWS: Mention TLS support for FreeBSD.
7175
7176 2019-03-25  Tom Tromey  <tromey@adacore.com>
7177
7178         * minsyms.c (BUNCH_SIZE): Update comment.
7179         (~minimal_symbol_reader): Remove old comment.
7180         (compact_minimal_symbols): Update comment.
7181         (minimal_symbol_reader::install): Remove old comment.  Update
7182         other comments.
7183
7184 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7185
7186         * s390-linux-nat.c: Add include.
7187
7188 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7189
7190         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7191         Call linux_get_hwcap.
7192         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7193         Likewise.
7194         (aarch64_linux_get_hwcap): Remove function.
7195         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7196         declaration.
7197         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7198         linux_get_hwcap.
7199         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7200         * linux-tdep.c (linux_get_hwcap): Add function.
7201         (linux_get_hwcap2): Likewise.
7202         * linux-tdep.h (linux_get_hwcap): Add declaration.
7203         (linux_get_hwcap2): Likewise.
7204         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7205         (ppc_linux_get_hwcap2): Likewise.
7206         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7207         linux_get_hwcap.
7208         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7209         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7210         (ppc_linux_nat_target::read_description): Likewise.
7211         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7212         * s390-linux-nat.c: Likewise.
7213         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7214
7215 2019-03-24  Tom Tromey  <tom@tromey.com>
7216
7217         * ada-lang.c (standard_lookup): Simplify initialization.
7218         (ada_lookup_symbol_nonlocal): Simplify return.
7219         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7220         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7221         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7222         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7223         initialization.
7224         * solib.c (solib_global_lookup): Simplify.
7225         * symtab.c (null_block_symbol): Remove.
7226         (symbol_cache_lookup): Simplify returns.
7227         (lookup_language_this): Simplify returns.
7228         (lookup_symbol_aux): Simplify return.
7229         (lookup_local_symbol): Simplify returns.
7230         (lookup_global_symbol_from_objfile): Simplify return.
7231         (lookup_symbol_in_objfile_symtabs)
7232         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7233         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7234         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7235         * cp-namespace.c (cp_lookup_bare_symbol)
7236         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7237         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7238         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7239         (cp_lookup_symbol_via_imports): Simplify initialization.
7240         (find_symbol_in_baseclass): Likewise.
7241         * symtab.h (null_block_symbol): Remove.
7242         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7243         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7244         (d_lookup_symbol_module): Likewise.
7245         (find_symbol_in_baseclass): Simplify initialization.
7246
7247 2019-03-24  Tom Tromey  <tom@tromey.com>
7248
7249         * expression.h: Don't include symtab.h.
7250         (struct block): Forward declare.
7251
7252 2019-03-24  Tom Tromey  <tom@tromey.com>
7253
7254         * c-exp.y (typebase): Remove casts.
7255         * gdbtypes.c (lookup_unsigned_typename, )
7256         (lookup_signed_typename): Remove cast.
7257         * eval.c (parse_to_comma_and_eval): Remove cast.
7258         * parse.c (write_dollar_variable): Remove cast.
7259         * block.h (struct block) <superblock>: Now const.
7260         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7261         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7262         (map_block): Make "block" const.
7263         * symfile.h (struct quick_symbol_functions)
7264         <map_matching_symbols>: Constify block argument to "callback".
7265         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7266         const.
7267         (find_pc_sect_compunit_symtab): Make "b" const.
7268         (find_symbol_at_address): Likewise.
7269         (search_symbols): Likewise.
7270         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7271         (dw2_debug_names_lookup_symbol): Likewise.
7272         (dw2_map_matching_symbols): Update.
7273         * p-valprint.c (pascal_val_print): Remove "block".
7274         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7275         (aux_add_nonlocal_symbols): Make "block" const.
7276         (resolve_subexp): Remove cast.
7277         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7278         const.
7279         (iterate_over_file_blocks): Likewise.
7280         * f-exp.y (%union) <bval>: Remove.
7281         * coffread.c (patch_opaque_types): Make "b" const.
7282         * spu-tdep.c (spu_catch_start): Make "block" const.
7283         * c-valprint.c (print_unpacked_pointer): Remove "block".
7284         * symmisc.c (dump_symtab_1): Make "b" const.
7285         (block_depth): Make "block" const.
7286         * d-exp.y (%union) <bval>: Remove.
7287         * cp-support.h (cp_lookup_rtti_type): Update.
7288         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7289         * psymtab.c (psym_lookup_symbol): Make "block" const.
7290         (maintenance_check_psymtabs): Make "b" const.
7291         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7292         (enumerate_locals, enumerate_args): Update.
7293         * python/py-symtab.c (stpy_global_block): Make "block" const.
7294         (stpy_static_block): Likewise.
7295         * inline-frame.c (block_starting_point_at): Make "new_block"
7296         const.
7297         * block.c (find_block_in_blockvector): Make return type const.
7298         (blockvector_for_pc_sect): Make "b" const.
7299         (find_block_in_blockvector): Make "b" const.
7300
7301 2019-03-23  Tom Tromey  <tom@tromey.com>
7302
7303         * varobj.c (varobj_create): Update.
7304         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7305         * printcmd.c (display_command, do_one_display): Don't reset
7306         innermost_block.
7307         * parser-defs.h (enum innermost_block_tracker_type): Move to
7308         expression.h.
7309         (innermost_block): Update comment.
7310         * parse.c (parse_exp_1): Add tracker_types parameter.
7311         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7312         tracker_types parameter.  Reset innermost_block.
7313         (parse_exp_in_context): Remove.
7314         (parse_expression_for_completion): Update.
7315         * objfiles.c (~objfile): Don't reset expression_context_block or
7316         innermost_block.
7317         * expression.h (enum innermost_block_tracker_type): Move from
7318         parser-defs.h.
7319         (parse_exp_1): Add tracker_types parameter.
7320         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7321         reset innermost_block.
7322
7323 2019-03-23  Tom Tromey  <tom@tromey.com>
7324
7325         * objfiles.h: Include bcache.h.
7326
7327 2019-03-23  Tom Tromey  <tom@tromey.com>
7328
7329         * linespec.c (get_current_search_block): Use
7330         scoped_restore_current_language.
7331         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7332
7333 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7334             Jiong Wang  <jiong.wang@arm.com>
7335
7336         * aarch64-linux-tdep.c
7337         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7338         section.
7339         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7340
7341 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7342             Jiong Wang  <jiong.wang@arm.com>
7343
7344         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7345         instructions.
7346         (aarch64_analyze_prologue_test): Add PACIASP test.
7347         (aarch64_prologue_prev_register): Unmask PC value.
7348
7349 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7350             Jiong Wang  <jiong.wang@arm.com>
7351
7352         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7353         (aarch64_dwarf2_prev_register): Unmask PC value.
7354         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7355         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7356         DW_CFA_AARCH64_negate_ra_state.
7357         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7358
7359 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7360             Jiong Wang  <jiong.wang@arm.com>
7361
7362         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7363         registers.
7364         (aarch64_pseudo_register_name): Likewise.
7365         (aarch64_pseudo_register_type): Likewise.
7366         (aarch64_pseudo_register_reggroup_p): Likewise.
7367         (aarch64_gdbarch_init): Add pauth registers.
7368         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7369         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7370         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7371         (struct gdbarch_tdep): Add regnum for ra_state.
7372
7373 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7374             Jiong Wang  <jiong.wang@arm.com>
7375
7376         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7377
7378 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7379             Jiong Wang  <jiong.wang@arm.com>
7380
7381         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7382         function.
7383         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7384         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7385         (aarch64_gdbarch_init): Add puth registers.
7386         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7387         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7388         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7389
7390 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7391             Jiong Wang  <jiong.wang@arm.com>
7392
7393         * aarch64-linux-nat.c
7394         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7395         * aarch64-linux-tdep.c
7396         (aarch64_linux_core_read_description): Likewise.
7397         (aarch64_linux_get_hwcap): New function.
7398         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7399         (aarch64_linux_get_hwcap): New declaration.
7400
7401 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7402             Jiong Wang  <jiong.wang@arm.com>
7403
7404         * aarch64-linux-nat.c
7405         (aarch64_linux_nat_target::read_description): Add pauth param.
7406         * aarch64-linux-tdep.c
7407         (aarch64_linux_core_read_description): Likewise.
7408         * aarch64-tdep.c (struct target_desc): Add in pauth.
7409         (aarch64_read_description): Add pauth param.
7410         (aarch64_gdbarch_init): Likewise.
7411         * aarch64-tdep.h (aarch64_read_description): Likewise.
7412         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7413         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7414         * features/Makefile: Add new files.
7415         * features/aarch64-pauth.c: New file.
7416         * features/aarch64-pauth.xml: New file.
7417
7418 2019-03-20  Tom Tromey  <tromey@adacore.com>
7419
7420         * infrun.c (handle_inferior_event): Rename from
7421         handle_inferior_event_1.  Create a scoped_value_mark.
7422         (handle_inferior_event): Remove.
7423
7424 2019-03-19  Tom Tromey  <tromey@adacore.com>
7425
7426         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7427         * infrun.h (print_stop_event): Add "displays" parameter.
7428         * infrun.c (print_stop_event): Add "displays" parameter.
7429
7430 2019-03-19  Pedro Alves  <palves@redhat.com>
7431
7432         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7433         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7434         to -1.  Fix TABs vs spaces.
7435         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7436         * tui/tui-out.h (tui_ui_out) Add intro comments.
7437         <m_line, m_start_of_line>: In-class initialize, and add describing
7438         comment.
7439
7440 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7441
7442         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7443         variable names.
7444         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7445
7446 2019-03-18  Pedro Alves  <palves@redhat.com>
7447             Eli Zaretskii <eliz@gnu.org>
7448
7449         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7450         m_line and m_start_of_line.
7451
7452 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7453
7454         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7455         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7456         it returns a newline.  This fixes a regression in TU mode, whereby
7457         the next line is output on the same screen line as the user input.
7458
7459 2019-03-18  Tom Tromey  <tromey@adacore.com>
7460
7461         * minsyms.c (minimal_symbol_reader::install): Remove call to
7462         obstack_blank.
7463
7464 2019-03-18  Pedro Alves  <palves@redhat.com>
7465
7466         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7467         New globals.
7468         (apply_style): New, factored out from ...
7469         (apply_ansi_escape): ... this.  Handle reverse video mode.
7470         (tui_set_reverse_mode): New function.
7471         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7472         * tui/tui-winsource.c (tui_show_source_line): Use
7473         tui_set_reverse_mode instead of setting A_STANDOUT.
7474         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7475         New setter methods.
7476
7477 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7478
7479         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7480         Handle tabs.
7481
7482 2019-03-18  Tom Tromey  <tromey@adacore.com>
7483
7484         * ada-lang.c (empty_array): Add "high" parameter.
7485         (ada_evaluate_subexp): Update.
7486
7487 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7488
7489         * unittests/string_view-selftests.c: Define
7490         _initialize_string_view_selftests unconditionally.
7491
7492 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7493
7494         PR gdb/24350
7495         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7496
7497 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7498
7499         PR gdb/24351
7500         * windows-nat.c (display_selector): Fix format specifiers.
7501
7502 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7503
7504         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7505         tui_refill_source_window instead of tui_refresh_win, to update the
7506         current execution line.  This fixes redisplay of the current line
7507         when stepping through the code with "next" or "step".
7508
7509 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7510
7511         * source-cache.c (source_cache::get_source_lines): Call
7512         find_source_lines to initialize s->nlines.  This fixes vertical
7513         scrolling of TUI source window when the DOWN arrow is pressed.
7514
7515 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7516
7517         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7518         linux-thread-db.c (_initialize_thread_db): Likewise.
7519
7520 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7521
7522         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7523         wclrtoeol in tui_show_source_line".  This reverts changes made in
7524         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7525
7526 2019-03-15  Tom Tromey  <tom@tromey.com>
7527
7528         * symtab.h (struct minimal_symbol): Derive from
7529         general_symbol_info.
7530         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7531         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7532         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7533         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7534         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7535         (MSYMBOL_SEARCH_NAME): Update.
7536         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7537         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7538         * minsyms.c (minimal_symbol_reader::record_full): Update.
7539
7540 2019-03-15  Tom Tromey  <tom@tromey.com>
7541
7542         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7543
7544 2019-03-15  Tom Tromey  <tom@tromey.com>
7545
7546         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7547         unique_xmalloc_ptr.
7548         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7549         Update.
7550         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7551         (build_minimal_symbol_hash_tables)
7552         (minimal_symbol_reader::install): Update.
7553
7554 2019-03-15  Tom Tromey  <tom@tromey.com>
7555
7556         * symtab.c (create_demangled_names_hash): Update.
7557         (symbol_set_names): Update.
7558         * objfiles.h (struct objfile_per_bfd_storage)
7559         <demangled_names_hash>: Now an htab_up.
7560         * objfiles.c (objfile_per_bfd_storage): Simplify.
7561
7562 2019-03-15  Tom Tromey  <tom@tromey.com>
7563
7564         * objfiles.h (struct objfile_per_bfd_storage): Declare
7565         destructor.
7566         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7567         New.
7568         (get_objfile_bfd_data): Use new.  Don't initialize
7569         language_of_main.
7570         (free_objfile_per_bfd_storage): Remove.
7571         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7572
7573 2019-03-15  Tom Tromey  <tom@tromey.com>
7574
7575         * symfile.c (reread_symbols): Update.
7576         * objfiles.c (objfile::objfile): Update.
7577         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7578         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7579         comment.
7580         (minimal_symbol_reader::install): Update.
7581         (terminate_minimal_symbol_table): Remove.
7582         * jit.c (jit_object_close_impl): Update.
7583
7584 2019-03-15  Tom Tromey  <tom@tromey.com>
7585
7586         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7587         initializations.
7588
7589 2019-03-15  Tom Tromey  <tom@tromey.com>
7590
7591         * objfiles.h (struct objfile_per_bfd_storage)
7592         <demangled_hash_languages>: Now a bitset.
7593         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7594         (lookup_minimal_symbol): Update.
7595
7596 2019-03-15  Tom Tromey  <tom@tromey.com>
7597
7598         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7599         Don't return the symbol.
7600         * coffread.c (record_minimal_symbol): Use record_full.
7601
7602 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7603
7604         The MS-Windows port of ncurses fails to switch to a color pair if
7605         one or both of the colors are the implicit default colors.  This
7606         change records the default colors when TUI is initialized, and
7607         then specifies them explicitly when a color pair uses the default
7608         colors.  This allows color styling in TUI mode on MS-Windows.
7609
7610         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7611         ncurses_norm_attr.
7612         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7613         colors in ncurses_norm_attr.
7614         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7615         "none", replace it with the default color recorded in
7616         ncurses_norm_attr.
7617
7618 2019-03-14  Tom Tromey  <tromey@adacore.com>
7619
7620         * source-cache.h (class source_cache) <get_source_lines>: Return
7621         std::string.
7622         * source-cache.c (source_cache::extract_lines): Handle case where
7623         first_pos==npos.  Return std::string.
7624         (source_cache::get_source_lines): Update.
7625
7626 2019-03-14  Tom Tromey  <tromey@adacore.com>
7627
7628         * NEWS: Add item for "style sources" commands.
7629         * source-cache.c (source_cache::get_source_lines): Check
7630         source_styling.
7631         * cli/cli-style.c (source_styling): New global.
7632         (_initialize_cli_style): Add "style sources" commands.
7633         (show_style_sources): New function.
7634         * cli/cli-style.h (source_styling): Declare.
7635
7636 2019-03-14  Pedro Alves  <palves@redhat.com>
7637             Tom Tromey  <tromey@adacore.com>
7638
7639         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7640         * tui/tui-winsource.c (tui_refill_source_window): New function,
7641         from...
7642         (tui_horizontal_source_scroll): ... here.  Move some logic.
7643         * cli/cli-style.c (set_style_enabled): Notify new observable.
7644         * tui/tui-hooks.c (tui_redisplay_source): New function.
7645         (tui_attach_detach_observers): Attach or detach
7646         tui_redisplay_source.
7647         * observable.h (source_styling_changed): New observable.
7648         * observable.c: Define source_styling_changed observable.
7649
7650 2019-03-13  Tom Tromey  <tromey@adacore.com>
7651
7652         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7653         (i386_gnu_nat_target::store_registers): Update.
7654         * target-debug.h (target_debug_print_std_string): New macro.
7655         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7656         * windows-tdep.c (display_one_tib): Update.
7657         * tui/tui-stack.c (tui_make_status_line): Update.
7658         * top.c (print_inferior_quit_action): Update.
7659         * thread.c (thr_try_catch_cmd): Update.
7660         (add_thread_with_info): Update.
7661         (thread_target_id_str): Update.
7662         (thr_try_catch_cmd): Update.
7663         (thread_command): Update.
7664         (thread_find_command): Update.
7665         * record-btrace.c (record_btrace_target::info_record)
7666         (record_btrace_resume_thread, record_btrace_target::resume)
7667         (record_btrace_cancel_resume, record_btrace_step_thread)
7668         (record_btrace_target::wait, record_btrace_target::wait)
7669         (record_btrace_target::wait, record_btrace_target::stop): Update.
7670         * progspace.c (print_program_space): Update.
7671         * process-stratum-target.c
7672         (process_stratum_target::thread_address_space): Update.
7673         * linux-fork.c (linux_fork_mourn_inferior)
7674         (detach_checkpoint_command, info_checkpoints_command)
7675         (linux_fork_context): Update.
7676         (linux_fork_detach): Update.
7677         (class scoped_switch_fork_info): Update.
7678         (delete_checkpoint_command): Update.
7679         * infrun.c (follow_fork_inferior): Update.
7680         (follow_fork_inferior): Update.
7681         (proceed_after_vfork_done): Update.
7682         (handle_vfork_child_exec_or_exit): Update.
7683         (follow_exec): Update.
7684         (displaced_step_prepare_throw): Update.
7685         (displaced_step_restore): Update.
7686         (start_step_over): Update.
7687         (resume_1): Update.
7688         (clear_proceed_status_thread): Update.
7689         (proceed): Update.
7690         (print_target_wait_results): Update.
7691         (do_target_wait): Update.
7692         (context_switch): Update.
7693         (stop_all_threads): Update.
7694         (restart_threads): Update.
7695         (finish_step_over): Update.
7696         (handle_signal_stop): Update.
7697         (switch_back_to_stepped_thread): Update.
7698         (keep_going_pass_signal): Update.
7699         (print_exited_reason): Update.
7700         (normal_stop): Update.
7701         * inferior.c (inferior_pid_to_str): Change return type.
7702         (print_selected_inferior): Update.
7703         (add_inferior): Update.
7704         (detach_inferior): Update.
7705         * dummy-frame.c (fprint_dummy_frames): Update.
7706         * dcache.c (dcache_info_1): Update.
7707         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7708         (btrace_fetch, btrace_clear): Update.
7709         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7710         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7711         type.
7712         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7713         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7714         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7715         * gdbarch.c, gdbarch.h: Rebuild.
7716         * gdbarch.sh (core_pid_to_str): Change return type.
7717         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7718         return type.
7719         (windows_nat_target::pid_to_str): Change return type.
7720         (windows_delete_thread): Update.
7721         (windows_nat_target::attach): Update.
7722         (windows_nat_target::files_info): Update.
7723         * target-delegates.c: Rebuild.
7724         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7725         return type.
7726         (sol_thread_target::pid_to_str): Change return type.
7727         * remote.c (class remote_target) <pid_to_str>: Change return
7728         type.
7729         (remote_target::pid_to_str): Change return type.
7730         (extended_remote_target::attach, remote_target::remote_stop_ns)
7731         (remote_target::remote_notif_remove_queued_reply)
7732         (remote_target::push_stop_reply, remote_target::disable_btrace):
7733         Update.
7734         (extended_remote_target::attach): Update.
7735         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7736         type.
7737         (gdbsim_target::pid_to_str): Change return type.
7738         * ravenscar-thread.c (struct ravenscar_thread_target)
7739         <pid_to_str>: Change return type.
7740         (ravenscar_thread_target::pid_to_str): Change return type.
7741         * procfs.c (class procfs_target) <pid_to_str>: Change return
7742         type.
7743         (procfs_target::pid_to_str): Change return type.
7744         (procfs_target::attach): Update.
7745         (procfs_target::detach): Update.
7746         (procfs_target::fetch_registers): Update.
7747         (procfs_target::store_registers): Update.
7748         (procfs_target::wait): Update.
7749         (procfs_target::files_info): Update.
7750         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7751         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7752         return type.
7753         (nto_procfs_target::pid_to_str): Change return type.
7754         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7755         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7756         return type.
7757         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7758         (exit_lwp): Update.
7759         (attach_proc_task_lwp_callback, get_detach_signal)
7760         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7761         (linux_nat_target::resume, wait_lwp, stop_callback)
7762         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7763         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7764         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7765         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7766         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7767         type.
7768         (inf_ptrace_target::attach): Update.
7769         (inf_ptrace_target::files_info): Update.
7770         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7771         type.
7772         (go32_nat_target::pid_to_str): Change return type.
7773         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7774         (gnu_nat_target::wait): Update.
7775         (gnu_nat_target::wait): Update.
7776         (gnu_nat_target::resume): Update.
7777         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7778         (fbsd_nat_target::wait): Update.
7779         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7780         type.
7781         (darwin_nat_target::attach): Update.
7782         * corelow.c (class core_target) <pid_to_str>: Change return type.
7783         (core_target::pid_to_str): Change return type.
7784         * target.c (normal_pid_to_str): Change return type.
7785         (default_pid_to_str): Likewise.
7786         (target_pid_to_str): Change return type.
7787         (target_translate_tls_address): Update.
7788         (target_announce_detach): Update.
7789         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7790         return type.
7791         (bsd_uthread_target::pid_to_str): Change return type.
7792         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7793         type.
7794         (bsd_kvm_target::pid_to_str): Change return type.
7795         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7796         return type.
7797         (aix_thread_target::pid_to_str): Change return type.
7798         * target.h (struct target_ops) <pid_to_str>: Change return type.
7799         (target_pid_to_str, normal_pid_to_str): Likewise.
7800         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7801         type.
7802         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7803         type.
7804         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7805         return type.
7806         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7807         type.
7808         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7809         type.
7810         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7811         return type.
7812
7813 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7814
7815         * NEWS: Mention that the new default MI version is 3.  Mention
7816         changes to the output of commands and events that deal with
7817         multi-location breakpoints.
7818         * breakpoint.c: Include "mi/mi-out.h".
7819         (print_one_breakpoint): Change output syntax if using MI version
7820         >= 3.
7821         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7822         New.
7823         (mi_multi_location_breakpoint_output_fixed): New.
7824         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7825         (mi_cmd_fix_multi_location_breakpoint_output): New.
7826         (mi_multi_location_breakpoint_output_fixed): New.
7827         * mi/mi-cmds.c (mi_cmds): Register command
7828         -fix-multi-location-breakpoint-output.
7829         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7830         interpreter "mi".
7831
7832 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7833
7834         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7835         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7836         instantiate mi_ui_out based on interpreter name.
7837         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7838         * mi/mi-main.c (mi_load_progress): Likewise.
7839
7840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7841
7842         * NEWS: Combine separate "New targets" sections for 8.3.
7843
7844 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7845
7846         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7847         (ppcfbsd_init_abi): Install gdbarch
7848         "fetch_tls_load_module_address" and "get_thread_local_address"
7849         methods.
7850
7851 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7852
7853         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7854         (riscv_fbsd_init_abi): Install gdbarch
7855         "fetch_tls_load_module_address" and "get_thread_local_address"
7856         methods.
7857
7858 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7859
7860         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7861         (i386fbsd_init_abi): Install gdbarch
7862         "fetch_tls_load_module_address" and "get_thread_local_address"
7863         methods.
7864
7865 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7866
7867         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7868         (amd64fbsd_init_abi): Install gdbarch
7869         "fetch_tls_load_module_address" and "get_thread_local_address"
7870         methods.
7871
7872 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7873
7874         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7875         (struct fbsd_pspace_data): New type.
7876         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7877         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7878         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7879         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7880         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7881
7882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7883
7884         * gdbtypes.c (lookup_struct_elt): New function.
7885         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7886         * gdbtypes.h (struct struct_elt): New type.
7887         (lookup_struct_elt): New prototype.
7888
7889 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7890
7891         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7892         remove disabled code block.
7893
7894 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7895
7896         * gdbarch.sh (get_thread_local_address): New method.
7897         * gdbarch.h, gdbarch.c: Regenerate.
7898         * target.c (target_translate_tls_address): Use
7899         gdbarch_get_thread_local_address if present instead of
7900         target::get_thread_local_address.
7901
7902 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7903
7904         * target.h (target::get_thread_local_address): Update comment.
7905
7906 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7907
7908         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7909         objfile->separate_debug_objfile_backlink if not NULL.
7910
7911 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7912
7913         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7914         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7915         (amd64bsd_store_inferior_registers): Likewise.
7916         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7917         Enable segment base registers.
7918         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7919         PT_GETFSBASE and PT_GETGSBASE.
7920         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7921         PT_SETGSBASE.
7922         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7923         segment base registers.
7924         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7925
7926 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7927
7928         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7929         Update calls to i386_target_description to add 'segments'
7930         parameter.
7931         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7932         add segment base registers.
7933         * arch/i386.c (i386_create_target_description): Add 'segments'
7934         parameter to enable segment base registers.
7935         * arch/i386.h (i386_create_target_description): Likewise.
7936         * features/i386/32bit-segments.xml: New file.
7937         * features/i386/32bit-segments.c: Generate.
7938         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7939         call to i386_target_description to add 'segments' parameter.
7940         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7941         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7942         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7943         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7944         if feature is present.
7945         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7946         Add 'segments' parameter to call to i386_target_description.
7947         (i386_target_description): Add 'segments' parameter to enable
7948         segment base registers.
7949         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7950         to call to i386_target_description.
7951         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7952         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7953         Define I386_NUM_REGS.
7954         (i386_target_description): Add 'segments' parameter to enable
7955         segment base registers.
7956
7957 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7958
7959         PR/24325
7960         * source-cache.c: #undef open and close, to avoid unresolved
7961         externals during linking.
7962
7963 2019-03-12  Tom Tromey  <tromey@adacore.com>
7964
7965         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7966         const.  Add initializers.
7967         (_initialize_remote): Don't initialize ptid globals.
7968
7969 2019-03-12  Pedro Alves  <palves@redhat.com>
7970
7971         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7972
7973 2019-03-12  Pedro Alves  <palves@redhat.com>
7974
7975         * cp-name-parser.y (main): Remove unused 'len' variable.
7976
7977 2019-03-12  Tom Tromey  <tromey@adacore.com>
7978
7979         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7980         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7981
7982 2019-03-12  Tom Tromey  <tromey@adacore.com>
7983
7984         * linux-nat.c (iterate_over_lwps): Update.
7985         (stop_callback): Remove parameter.
7986         (stop_wait_callback, detach_callback, resume_set_callback)
7987         (select_singlestep_lwp_callback, set_ignore_sigint)
7988         (status_callback, resumed_callback, resume_clear_callback)
7989         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7990         data parameter.
7991         (linux_nat_target::detach, linux_nat_target::resume)
7992         (linux_stop_and_wait_all_lwps, select_event_lwp)
7993         (linux_nat_filter_event, linux_nat_wait_1)
7994         (linux_nat_target::kill, linux_nat_target::stop)
7995         (linux_nat_target::stop): Update.
7996         (linux_nat_resume_callback): Change type.
7997         (resume_stopped_resumed_lwps, count_events_callback)
7998         (select_event_lwp_callback): Likewise.
7999         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8000         * arm-linux-nat.c (struct update_registers_data): Remove.
8001         (update_registers_callback): Change type.
8002         (arm_linux_insert_hw_breakpoint1): Update.
8003         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8004         parameter.
8005         (x86_linux_dr_set_addr): Update.
8006         (x86_linux_dr_set_control): Update.
8007         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8008         (iterate_over_lwps): Use gdb::function_view.
8009         * nat/aarch64-linux-hw-point.c (struct
8010         aarch64_dr_update_callback_param): Remove.
8011         (debug_reg_change_callback): Change type.
8012         (aarch64_notify_debug_reg_change): Update.
8013         * s390-linux-nat.c (s390_refresh_per_info): Update.
8014
8015 2019-03-11  Tom Tromey  <tromey@adacore.com>
8016
8017         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8018         redundant assignment to "this_cu".
8019
8020 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8021
8022         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8023
8024 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8025
8026         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8027         from...
8028         (rank_one_type): ... this.
8029
8030 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8031
8032         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8033         from...
8034         (rank_one_type): ... this.
8035
8036 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8037
8038         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8039         from...
8040         (rank_one_type): ... this.
8041
8042 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8043
8044         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8045         from...
8046         (rank_one_type): ... this.
8047
8048 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8049
8050         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8051         from...
8052         (rank_one_type): ... this.
8053
8054 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8055
8056         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8057         from...
8058         (rank_one_type): ... this.
8059
8060 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8061
8062         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8063         from...
8064         (rank_one_type): ... this.
8065
8066 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8067
8068         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8069         from...
8070         (rank_one_type): ... this.
8071
8072 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8073
8074         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8075         from...
8076         (rank_one_type): ... this.
8077
8078 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8079
8080         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8081         from...
8082         (rank_one_type): ... this.
8083
8084 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8085
8086         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8087         from...
8088         (rank_one_type): ... this.
8089
8090 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8091
8092         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8093         from...
8094         (rank_one_type): ... this.
8095
8096 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8097
8098         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8099         inferior-events' shows the example events.
8100
8101 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8102
8103         Support styling on native MS-Windows console
8104
8105         PR/24315
8106         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8107         on MS-Windows if $TERM is not defined.
8108
8109         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8110
8111         * posix-hdep.c (gdb_console_fputs):
8112         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8113         functions.
8114         * ui-file.h (gdb_console_fputs): Add prototype.
8115
8116         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8117         back to fputs only if the former returns zero.
8118
8119 2019-03-07  Tom Tromey  <tom@tromey.com>
8120
8121         * symmisc.c (print_symbol_bcache_statistics): Update.
8122         (print_objfile_statistics): Update.
8123         * symfile.c (allocate_symtab): Update.
8124         * stabsread.c: Don't include bcache.h.
8125         * psymtab.h (struct psymbol_bcache): Don't declare.
8126         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8127         (psymbol_bcache_init, psymbol_bcache_free)
8128         (psymbol_bcache_get_bcache): Don't declare.
8129         * psymtab.c (struct psymbol_bcache): Remove.
8130         (psymtab_storage::psymtab_storage): Update.
8131         (psymtab_storage::~psymtab_storage): Update.
8132         (psymbol_bcache_init, psymbol_bcache_free)
8133         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8134         (add_psymbol_to_bcache): Update.
8135         (allocate_psymtab): Update.
8136         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8137         macro_cache>: No longer pointers.
8138         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8139         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8140         * macrotab.c (macro_bcache): Update.
8141         * macroexp.c: Don't include bcache.h.
8142         * gdbtypes.c (check_types_worklist): Update.
8143         (types_deeply_equal): Remove TRY/CATCH.  Update.
8144         * elfread.c (elf_symtab_read): Update.
8145         * dwarf2read.c: Don't include bcache.h.
8146         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8147         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8148         (print_bcache_statistics, bcache_memory_used): Don't declare.
8149         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8150         methods.  Rename all data members.
8151         * bcache.c (struct bcache): Move to bcache.h.
8152         (bcache::expand_hash_table): Rename from expand_hash_table.
8153         (bcache): Remove.
8154         (bcache::insert): Rename from bcache_full.
8155         (bcache::compare): Rename from bcache_compare.
8156         (bcache_xmalloc): Remove.
8157         (bcache::~bcache): Rename from bcache_xfree.
8158         (bcache::print_statistics): Rename from print_bcache_statistics.
8159         (bcache::memory_used): Rename from bcache_memory_used.
8160
8161 2019-03-07  Pedro Alves  <palves@redhat.com>
8162
8163         * infrun.c (normal_stop): Also check for
8164         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8165
8166 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8167
8168         * f-lang.c (value_from_host_double): Moved to...
8169         * value.c (value_from_host_double): ...here.
8170         * value.h (value_from_host_double): Declare.
8171         * guile/scm-math.c (vlscm_convert_typed_number): Use
8172         value_from_host_double.
8173         (vlscm_convert_number): Likewise.
8174         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8175         * python/py-value.c (convert_value_from_python): Likewise.
8176
8177 2019-03-06  Tom Tromey  <tom@tromey.com>
8178
8179         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8180
8181 2019-03-06  Tom Tromey  <tom@tromey.com>
8182
8183         * utils.h (free_current_contents): Don't declare.
8184         * utils.c (free_current_contents): Remove.
8185
8186 2019-03-06  Tom Tromey  <tom@tromey.com>
8187
8188         * top.c (quit_force): Update.
8189         * main.c (captured_command_loop): Update.
8190         * common/new-op.c (operator new): Update.
8191         * common/common-exceptions.c (struct catcher)
8192         <save_cleanup_chain>: Remove member.
8193         (exceptions_state_mc_init): Update.
8194         (exception_try_scope_entry): Return nullptr.
8195         (exception_try_scope_exit, exception_rethrow)
8196         (throw_exception_sjlj, throw_exception_cxx): Update.
8197         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8198         (all_cleanups, do_cleanups, discard_cleanups)
8199         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8200         (restore_cleanups, restore_final_cleanups): Don't declare.
8201         (do_final_cleanups): Remove parameter.
8202         * common/cleanups.c (cleanup_chain, make_cleanup)
8203         (make_cleanup_dtor, all_cleanups, do_cleanups)
8204         (discard_my_cleanups, discard_cleanups)
8205         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8206         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8207         (null_cleanup): Remove.
8208         (do_final_cleanups): Remove parameter.
8209
8210 2019-03-06  Tom Tromey  <tom@tromey.com>
8211
8212         * remote.c (remote_target::remote_parse_stop_reply): Use
8213         unique_xmalloc_ptr.
8214
8215 2019-03-06  Tom Tromey  <tom@tromey.com>
8216
8217         * stabsread.c (struct stabs_field_info): Rename from field_info.
8218         <list, fnlist>: Add initializers.
8219         <obstack>: New member.
8220         (read_member_functions, read_struct_fields, read_baseclasses):
8221         Allocate on obstack.  Don't use cleanups.
8222         (read_one_struct_field, read_member_functions, read_struct_fields)
8223         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8224         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8225         (read_struct_type): Update.
8226
8227 2019-03-06  Tom Tromey  <tom@tromey.com>
8228
8229         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8230         * common/filestuff.h (make_cleanup_close): Don't declare.
8231         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8232         Remove.
8233
8234 2019-03-06  Tom Tromey  <tom@tromey.com>
8235
8236         * solib-aix.c: Use make_scope_exit.
8237
8238 2019-03-06  Tom Tromey  <tom@tromey.com>
8239
8240         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8241         Use make_scope_exit.
8242
8243 2019-03-06  Tom Tromey  <tom@tromey.com>
8244
8245         * solib-svr4.c (disable_probes_interface): Remove parameter.
8246         (svr4_handle_solib_event): Use make_scope_exit.
8247
8248 2019-03-06  Tom Tromey  <tom@tromey.com>
8249
8250         * remote.c (struct stop_reply_deleter): Remove.
8251         (stop_reply_up): Update.
8252         (struct stop_reply): Derive from notif_event.  Don't typedef.
8253         <regcache>: Now a std::vector.
8254         (stop_reply_xfree): Remove.
8255         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8256         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8257         (remote_target::discard_pending_stop_replies): Use delete.
8258         (remote_target::remote_parse_stop_reply): Update.
8259         (remote_target::process_stop_reply): Update.
8260         * remote-notif.h (struct notif_event): Add virtual destructor.
8261         Remove "dtr" member.
8262         (struct notif_client) <alloc_event>: Return a unique_ptr.
8263         (notif_event_xfree): Don't declare.
8264         (notif_event_up): New typedef.
8265         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8266         (notif_event_xfree, do_notif_event_xfree): Remove.
8267         (remote_notif_state_xfree): Update.
8268
8269 2019-03-06  Tom Tromey  <tom@tromey.com>
8270
8271         * infrun.c (displaced_step_clear_cleanup): Now a
8272         forward_scope_exit type.
8273         (displaced_step_prepare_throw): Update.
8274         (displaced_step_fixup): Update.
8275
8276 2019-03-06  Tom Tromey  <tom@tromey.com>
8277
8278         * inferior.h (class inferior): Update comment.
8279         * gdbthread.h (class thread_info): Update comment.
8280
8281 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8282             Tom Tromey  <tom@tromey.com>
8283
8284         * stabsread.h (struct stab_section_list): Remove.
8285         (coffstab_build_psymtabs): Update.
8286         * dbxread.c (symbuf_sections): Now a std::vector.
8287         (sect_idx): New global.
8288         (fill_symbuf): Update.
8289         (coffstab_build_psymtabs): Change type of stabsects parameter.
8290         Update.
8291         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8292         std::vector.
8293         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8294         (coff_locate_sections): Update.
8295         (coff_symfile_read): Remove cleanups.  Update.
8296         (init_stringtab): Add storage parameter.
8297         (free_stringtab, free_stringtab_cleanup): Remove.
8298         (init_lineno): Add storage parameter.
8299         (free_linetab, free_linetab_cleanup): Remove.
8300
8301 2019-03-06  Pedro Alves  <palves@redhat.com>
8302
8303         * linux-fork.c (fork_info::clobber_regs): Delete.
8304         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8305         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8306         comment.  Adjust.
8307         (scoped_switch_fork_info::scoped_switch_fork_info)
8308         (checkpoint_command, linux_fork_context): Adjust
8309         fork_save_infrun_state calls.
8310
8311 2019-03-06  Pedro Alves  <palves@redhat.com>
8312
8313         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8314         (inf_has_multiple_threads): Return 'bool' and rewrite using
8315         inferior_info::threads().
8316
8317 2019-03-06  Pedro Alves  <palves@redhat.com>
8318
8319         * linux-fork.c: Include <list>.
8320         (fork_list): Now a std::list instance.
8321         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8322         (forks_exist_p, find_last_fork): Adjust.
8323         (new_fork): Delete.
8324         (one_fork_p): New.
8325         (add_fork): Adjust.
8326         (free_fork): Delete, folded into fork_info::~fork_info().
8327         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8328         Adjust.
8329         (init_fork_list): Delete.
8330         (linux_fork_killall, linux_fork_mourn_inferior)
8331         (linux_fork_detach, info_checkpoints_command): Adjust.
8332         (_initialize_linux_fork): No longer call init_fork_list.
8333
8334 2019-03-06  Pedro Alves  <palves@redhat.com>
8335
8336         * linux-fork.c (new_fork): New, split out of ...
8337         (add_fork): ... this.  Return void.  Move "first fork" special
8338         case from here, to ...
8339         (checkpoint_command): ... here.
8340         * linux-linux.h (add_fork): Return void.
8341
8342 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8343
8344         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8345
8346 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8347             Chris January  <chris.january@arm.com>
8348             David Lecomber  <david.lecomber@arm.com>
8349
8350         * f-exp.y: New token, UNOP_INTRINSIC.
8351         (exp): New pattern using UNOP_INTRINSIC token.
8352         (f77_keywords): Add 'abs' keyword.
8353         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8354         (value_from_host_double): New function.
8355         (evaluate_subexp_f): Support UNOP_ABS.
8356
8357 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8358
8359         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8360         types.
8361
8362 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8363
8364         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8365         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8366         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8367
8368 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8369
8370         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8371
8372 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8373             Chris January  <chris.january@arm.com>
8374
8375         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8376         * f-exp.y: Define 'KIND' token.
8377         (exp): New pattern for KIND expressions.
8378         (ptype): Handle types with a kind extension.
8379         (direct_abs_decl): Extend to spot kind extensions.
8380         (f77_keywords): Add 'kind' to the list.
8381         (push_kind_type): New function.
8382         (convert_to_kind_type): New function.
8383         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8384         * parse.c (operator_length_standard): Likewise.
8385         * parser-defs.h (enum type_pieces): Add tp_kind.
8386         * std-operator.def: Add UNOP_KIND.
8387
8388 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8389
8390         * f-exp.y (f_parse): Set yydebug.
8391
8392 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8393
8394         * f-lang.c (evaluate_subexp_f): New function.
8395         (exp_descriptor_f): New global.
8396         (f_language_defn): Use exp_descriptor_f instead of
8397         exp_descriptor_standard.
8398
8399 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8400
8401         * f-exp.y (struct token): Add comments.
8402         (dot_ops): Remove uppercase versions and the end marker.
8403         (f77_keywords): Likewise.
8404         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8405         entries in the dot_ops array are case insensitive, and use
8406         strncasecmp to compare strings.  Also some whitespace cleanup in
8407         this area.  Similar for the f77_keywords array, except entries in
8408         this list might be case sensitive.
8409
8410 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8411
8412         * f-exp.y (struct f77_boolean_val): Add comments.
8413         (boolean_values): Remove uppercase versions, and end marker.
8414         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8415         and use strncasecmp to achieve case insensitivity.  Additionally,
8416         perform whitespace cleanup around this code.
8417
8418 2019-03-06  Tom Tromey  <tromey@adacore.com>
8419
8420         * remote-sim.c (gdbsim_target_open): Use result of
8421         gdb_argv::release.
8422
8423 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8424         Dirk Schubert  <dirk.schubert@arm.com>
8425         Chris January  <chris.january@arm.com>
8426
8427         * eval.c (evaluate_subexp_standard): Call Fortran argument
8428         wrapping logic.
8429         * f-lang.c (struct value): A value which can be passed into a
8430         Fortran function call.
8431         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8432         where appropriate.
8433         (struct type): Value ready for a Fortran function call.
8434         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8435         is needed.
8436         * f-lang.h (fortran_argument_convert): Declaration.
8437         (fortran_preserve_arg_pointer): Declaration.
8438         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8439
8440 2019-03-05  Tom Tromey  <tromey@adacore.com>
8441
8442         * python/py-prettyprint.c (print_string_repr): Remove #if.
8443         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8444
8445 2019-03-05  Tom Tromey  <tromey@adacore.com>
8446
8447         * target.c (the_dummy_target): Move later.  Change type to
8448         "dummy_target".
8449         (initialize_targets): Don't initialize the_dummy_target.
8450
8451 2019-03-05  Tom Tromey  <tromey@adacore.com>
8452
8453         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8454         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8455
8456 2019-03-05  Tom Tromey  <tromey@adacore.com>
8457
8458         * windows-nat.c (windows_nat_target::attach)
8459         (windows_nat_target::detach): Don't call gdb_flush.
8460         * valprint.c (generic_val_print, val_print, val_print_string):
8461         Don't call gdb_flush.
8462         * utils.c (defaulted_query): Don't call gdb_flush.
8463         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8464         * target.c (target_announce_detach): Don't call gdb_flush.
8465         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8466         * remote.c (extended_remote_target::attach): Don't call
8467         gdb_flush.
8468         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8469         * printcmd.c (do_examine): Don't call gdb_flush.
8470         (info_display_command): Don't call gdb_flush.
8471         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8472         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8473         * memattr.c (info_mem_command): Don't call gdb_flush.
8474         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8475         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8476         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8477         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8478         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8479         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8480         (gnu_nat_target::detach): Don't call gdb_flush.
8481         * f-valprint.c (f_val_print): Don't call gdb_flush.
8482         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8483         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8484         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8485         gdb_flush.
8486         * c-valprint.c (c_val_print): Don't call gdb_flush.
8487         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8488
8489 2019-03-05  Tom Tromey  <tromey@adacore.com>
8490
8491         * varobj.c (update_dynamic_varobj_children): Update.
8492         (install_default_visualizer): Use reset, not release.
8493         * value.c (set_internalvar): Update.
8494         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8495         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8496         ATTRIBUTE_UNUSED_RESULT.
8497
8498 2019-03-05  Tom Tromey  <tromey@adacore.com>
8499
8500         * remote.c (class scoped_remote_fd) <release>: Add
8501         ATTRIBUTE_UNUSED_RESULT.
8502
8503 2019-03-05  Tom Tromey  <tromey@adacore.com>
8504
8505         * macroexp.c (struct macro_buffer) <release>: Add
8506         ATTRIBUTE_UNUSED_RESULT.
8507
8508 2019-03-05  Tom Tromey  <tromey@adacore.com>
8509
8510         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8511         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8512         ATTRIBUTE_UNUSED_RESULT.
8513
8514 2019-03-05  Tom Tromey  <tromey@adacore.com>
8515
8516         * common/scoped_fd.h (class scoped_fd) <release>: Add
8517         ATTRIBUTE_UNUSED_RESULT.
8518
8519 2019-03-05  Tom Tromey  <tromey@adacore.com>
8520
8521         * parser-defs.h (struct parser_state) <release>: Add
8522         ATTRIBUTE_UNUSED_RESULT.
8523
8524 2019-03-05  Tom Tromey  <tromey@adacore.com>
8525
8526         * utils.h (class gdb_argv) <release>: Add
8527         ATTRIBUTE_UNUSED_RESULT.
8528         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8529
8530 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8531
8532         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8533         for-loop range, to avoid compiler warnings.
8534
8535         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8536         avoid compiler warnings about unused variables.
8537
8538         * NEWS: Mention end of support for native debugging on MS-Windows
8539         before XP.
8540
8541         PR gdb/24292
8542         * common/netstuff.c:
8543         * gdbserver/gdbreplay.c
8544         * gdbserver/remote-utils.c:
8545         * ser-tcp.c:
8546         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8547         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8548         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8549         'getaddrinfo' and 'freeaddrinfo' were not available before
8550         Windows XP, and mingw.org's MinGW headers by default define
8551         _WIN32_WINNT to 0x500.
8552
8553 2019-03-01  Gary Benson <gbenson@redhat.com>
8554
8555         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8556
8557 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8558             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8559
8560         PR gdb/8527
8561         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8562         set_sigint_trap, clear_sigint_trap.
8563
8564 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8565
8566         * target.c (target_detach): Clear the regcache and the
8567         frame cache.
8568
8569 2019-02-27  Pedro Alves  <palves@redhat.com>
8570
8571         * utils.c (set_screen_size): When we cap the height/width sizes,
8572         tweak the corresponding command variable to show "unlimited":
8573
8574 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8575             Pedro Alves  <palves@redhat.com>
8576
8577         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8578         before calling rl_set_screen_size.
8579
8580 2019-02-27  Tom Tromey  <tromey@adacore.com>
8581
8582         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8583         define.
8584         * python/py-value.c: Remove Python 2.4 workaround.
8585         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8586         workaround.
8587         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8588         Python 2.4 workaround.
8589         * python/python-internal.h: Remove Python 2.4 comment.
8590         (Py_ssize_t): Don't define.
8591         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8592         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8593         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8594         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8595         * python/python.c (do_start_initialization): Remove Python 2.4
8596         workaround.
8597         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8598         (print_children): Remove Python 2.4 workaround.
8599         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8600         workaround.
8601         (CHARBUFFERPROC_NAME): Remove.
8602         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8603         Python 2.4 workaround.
8604
8605 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8606
8607         * NEWS: Note minimum Python version.
8608
8609 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8610
8611         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8612         code from these functions.  Remove corresponding ifdefs.  Use
8613         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8614         Remove gotos and target of gotos.
8615         (infpy_search_memory): Likewise.
8616
8617 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8618
8619         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8620         (hppa_gdbarch_init): Don't register deleted functions with
8621         gdbarch.
8622
8623 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8624
8625         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8626         (h8300_unwind_sp): Delete.
8627         (h8300_dummy_id): Delete.
8628         (h8300_gdbarch_init): Don't register deleted functions with
8629         gdbarch.
8630
8631 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8632
8633         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8634         (ft32_unwind_pc): Delete.
8635         (ft32_unwind_sp): Delete.
8636         (ft32_gdbarch_init): Don't register deleted functions with
8637         gdbarch.
8638
8639 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8640
8641         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8642         (frv_unwind_pc): Delete.
8643         (frv_unwind_sp): Delete.
8644         (frv_gdbarch_init): Don't register deleted functions with
8645         gdbarch.
8646
8647 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8648
8649         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8650         (riscv_unwind_pc): Delete.
8651         (riscv_unwind_sp): Delete.
8652         (riscv_gdbarch_init): Don't register deleted functions with
8653         gdbarch.
8654
8655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8656
8657         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8658         (csky_unwind_pc): Delete.
8659         (csky_unwind_sp): Delete.
8660         (csky_gdbarch_init): Don't register deleted functions with
8661         gdbarch.
8662
8663 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8664
8665         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8666         (cris_unwind_pc): Delete.
8667         (cris_unwind_sp): Delete.
8668         (cris_gdbarch_init): Don't register deleted functions with
8669         gdbarch.
8670
8671 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8672
8673         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8674         (bfin_unwind_pc): Delete.
8675         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8676
8677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8678
8679         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8680         (arm_unwind_pc): Delete.
8681         (arm_unwind_sp): Delete.
8682         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8683
8684 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8685
8686         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8687         (arc_unwind_pc): Delete.
8688         (arc_unwind_sp): Delete.
8689         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8690
8691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8692
8693         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8694         (alpha_unwind_pc): Delete.
8695         (alpha_gdbarch_init): Don't register deleted functions with
8696         gdbarch.
8697
8698 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8699
8700         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8701         (aarch64_unwind_pc): Delete.
8702         (aarch64_unwind_sp): Delete.
8703         (aarch64_gdbarch_init): Don't register deleted functions with
8704         gdbarch.
8705
8706 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8707
8708         * gdbtypes.c (type_align): Don't consider static members when
8709         computing structure alignment.
8710
8711 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8712
8713         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8714         return 0 for other types.
8715         * arch-utils.c (default_type_align): Always return 0.
8716         * gdbarch.h: Regenerate.
8717         * gdbarch.sh (type_align): Extend comment.
8718         * gdbtypes.c (type_align): Add additional comments, always call
8719         gdbarch_type_align before applying the default rules.
8720         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8721         generic code will then apply a suitable default.
8722         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8723         types, return 0 for other types.
8724
8725 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8726
8727         * NEWS: Create a new section for the next release branch.
8728         Rename the section of the current branch, now that it has
8729         been cut.
8730
8731 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8732
8733         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8734         * version.in: Bump version to 8.3.50.DATE-git.
8735
8736 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8737
8738         * aix-thread.c (ptid_cmp): Remove unused variable.
8739         (get_signaled_thread): Likewise.
8740         (store_regs_user_thread): Likewise.
8741         (store_regs_kernel_thread): Likewise.
8742         (fetch_regs_kernel_thread): Remove shadowed variable.
8743
8744 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8745
8746         * features/riscv/32bit-cpu.xml: Add register numbers.
8747         * features/riscv/32bit-fpu.c: Regenerate.
8748         * features/riscv/32bit-fpu.xml: Add register numbers.
8749         * features/riscv/64bit-cpu.xml: Add register numbers.
8750         * features/riscv/64bit-fpu.c: Regenerate.
8751         * features/riscv/64bit-fpu.xml: Add register numbers.
8752
8753 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8754
8755         * NEWS: Mention two argument form of gdb.Value constructor.
8756         * python/py-value.c (convert_buffer_and_type_to_value): New
8757         function.
8758         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8759         Add support for handling an optional second argument.  Call
8760         convert_buffer_and_type_to_value as appropriate.
8761         * python/python-internal.h (Py_buffer_deleter): New struct.
8762         (Py_buffer_up): New typedef.
8763
8764 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8765
8766         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8767         instead of releasing ownership.
8768
8769 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8770
8771         * dwarf2read.c (open_and_init_dwp_file): Call
8772         elf_numsections instead of bfd_count_sections to initialize
8773         dwp_file->num_sections.
8774
8775 2019-02-25  Tom Tromey  <tromey@adacore.com>
8776
8777         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8778
8779 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8780
8781         * gcore.in: Add '--readnever' option when invoking GDB.
8782
8783 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8784
8785         * MAINTAINERS: Update my email address.
8786
8787 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8788
8789         * build-id.c (build_id_to_debug_bfd_1): New function.
8790         (build_id_to_debug_bfd): Look for separate debug file in
8791         sysroot.
8792
8793 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8794
8795         * gdbarch.sh: Update the copyright year range that is placed into
8796         generated files.
8797
8798 2019-02-22  Keith Seitz  <keiths@redhat.com>
8799
8800         PR symtab/23853
8801         * linespec.c (create_sals_line_offset): Search for the default
8802         symtab's filename instead of its fullname.
8803
8804 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8805
8806         * NEWS: Update style defaults.
8807
8808 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8809
8810         * main.c (captured_main_1): Disable styling in batch mode.
8811
8812 2019-02-20  Tom Tromey  <tom@tromey.com>
8813
8814         * symtab.c (symtab_symbol_info): Fix typos.
8815
8816 2019-02-20  Tom Tromey  <tromey@adacore.com>
8817
8818         * findcmd.c (_initialize_mem_search): Use upper case for
8819         metasyntactic variables.
8820
8821 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8822
8823         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8824         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8825
8826 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8827
8828         * top.h (source_file_name): Change to std::string.
8829         * top.c (source_file_name): Likewise.
8830         (command_line_input): Adjust.
8831         * cli/cli-script.c (script_from_file): Adjust.
8832
8833 2019-02-19  Tom Tromey  <tromey@adacore.com>
8834
8835         * ravenscar-thread.c
8836         (ravenscar_thread_target::update_thread_list): Don't call
8837         ada_build_task_list.
8838         * ada-lang.h (ada_build_task_list): Don't declare.
8839         * ada-tasks.c (struct ada_tasks_inferior_data)
8840         <task_list_valid_p>: Now bool.
8841         (read_known_tasks, ada_task_list_changed)
8842         (ada_tasks_invalidate_inferior_data): Update.
8843         (read_known_tasks_array): Return bool.
8844         (read_known_tasks_list): Likewise.
8845         (read_known_tasks): Return void.
8846         (ada_build_task_list): Now static.
8847
8848 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8849
8850         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8851         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8852
8853 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8854
8855         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8856         variant for ada_tasks_pspace_data_handle and
8857         ada_tasks_inferior_data_handle.
8858         (ada_tasks_pspace_data_cleanup): New function.
8859         (ada_tasks_inferior_data_cleanup): New function.
8860
8861 2019-02-17  Tom Tromey  <tom@tromey.com>
8862
8863         * macrotab.h (macro_source_fullname): Return a std::string.
8864         * macrotab.c (macro_include, check_for_redefinition)
8865         (macro_undef, macro_lookup_definition, foreach_macro)
8866         (foreach_macro_in_scope): Update.
8867         (macro_source_fullname): Return a std::string.
8868         * macrocmd.c (show_pp_source_pos): Update.
8869
8870 2019-02-17  Tom Tromey  <tom@tromey.com>
8871
8872         * macrocmd.c (show_pp_source_pos): Style the file names.
8873
8874 2019-02-17  Tom Tromey  <tom@tromey.com>
8875
8876         PR tui/24197:
8877         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8878
8879 2019-02-17  Tom Tromey  <tom@tromey.com>
8880
8881         * ada-lang.c (user_select_syms): Use filtered printing.
8882         * utils.c (wrap_style): New global.
8883         (desired_style): Remove.
8884         (emit_style_escape): Add stream parameter.
8885         (set_output_style, reset_terminal_style, prompt_for_continue):
8886         Update.
8887         (flush_wrap_buffer): Only flush gdb_stdout.
8888         (wrap_here): Set wrap_style.
8889         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8890         treat escape sequences as a character.  Change when wrap buffer is
8891         flushed.
8892         (fputs_styled): Do not set the output style when the default is
8893         requested.
8894         * ui-style.h (struct ui_file_style) <is_default>: New method.
8895         * source.c (print_source_lines_base): Emit escape sequences in one
8896         piece.
8897
8898 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8899
8900         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8901         integers and enumeration types.
8902
8903 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8904
8905         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8906         instead of lookup_symbol_in_language
8907         (do_exact_match): New function.
8908         (ada_get_symbol_name_matcher): Return do_exact_match when
8909         doing a verbatim match.
8910
8911 2019-02-15  Tom Tromey  <tromey@adacore.com>
8912
8913         * ravenscar-thread.c (ravenscar_thread_target::resume)
8914         (ravenscar_thread_target::wait): Special case wildcard requests.
8915
8916 2019-02-15  Tom Tromey  <tromey@adacore.com>
8917
8918         * ravenscar-thread.c (base_ptid): Remove.
8919         (struct ravenscar_thread_target) <close>: New method.
8920         <m_base_ptid>: New member.
8921         <update_inferior_ptid, active_task, task_is_currently_active,
8922         runtime_initialized>: Declare methods.
8923         <ravenscar_thread_target>: Add constructor.
8924         (ravenscar_thread_target::task_is_currently_active)
8925         (ravenscar_thread_target::update_inferior_ptid)
8926         (ravenscar_runtime_initialized): Rename.  Now methods.
8927         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8928         (ravenscar_thread_target::update_thread_list): Update.
8929         (ravenscar_thread_target::active_task): Now method.
8930         (ravenscar_thread_target::store_registers)
8931         (ravenscar_thread_target::prepare_to_store)
8932         (ravenscar_thread_target::prepare_to_store)
8933         (ravenscar_thread_target::mourn_inferior): Update.
8934         (ravenscar_inferior_created): Use "new" to create target.
8935         (ravenscar_thread_target::get_ada_task_ptid): Update.
8936         (_initialize_ravenscar): Don't initialize base_ptid.
8937         (ravenscar_ops): Remove global.
8938
8939 2019-02-15  Tom Tromey  <tromey@adacore.com>
8940
8941         * target.h (push_target): Declare new overload.
8942         * target.c (push_target): New overload, taking an rvalue reference.
8943         * remote.c (remote_target::open_1): Use push_target overload.
8944         * corelow.c (core_target_open): Use push_target overload.
8945
8946 2019-02-15  Tom Tromey  <tromey@adacore.com>
8947
8948         * ravenscar-thread.c (is_ravenscar_task)
8949         (ravenscar_task_is_currently_active): Return bool.
8950         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8951         (_initialize_ravenscar): Remove "(void)".
8952         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8953         Return bool.
8954
8955 2019-02-15  Tom Tromey  <tromey@adacore.com>
8956
8957         * ravenscar-thread.c (ravenscar_runtime_initializer)
8958         (has_ravenscar_runtime, get_running_thread_id)
8959         (ravenscar_thread_target::resume): Fix indentation.
8960
8961 2019-02-15  Tom Tromey  <tromey@adacore.com>
8962
8963         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8964         from ravenscar_arch_ops.
8965         (sparc_ravenscar_ops::fetch_registers)
8966         (sparc_ravenscar_ops::store_registers): Now methods.
8967         (sparc_ravenscar_prepare_to_store): Remove.
8968         (sparc_ravenscar_ops): Redefine.
8969         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8970         methods and destructor.  Remove members.
8971         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8972         (ravenscar_thread_target::store_registers)
8973         (ravenscar_thread_target::prepare_to_store): Update.
8974         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8975         Remove.
8976         (struct ppc_ravenscar_powerpc_ops): Derive from
8977         ravenscar_arch_ops.
8978         (ppc_ravenscar_powerpc_ops::fetch_registers)
8979         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8980         (ppc_ravenscar_powerpc_ops): Redefine.
8981         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8982         (ppc_ravenscar_e500_ops::fetch_registers)
8983         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8984         (ppc_ravenscar_e500_ops): Redefine.
8985         * aarch64-ravenscar-thread.c
8986         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8987         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8988         (aarch64_ravenscar_fetch_registers)
8989         (aarch64_ravenscar_store_registers): Now methods.
8990         (aarch64_ravenscar_ops): Redefine.
8991
8992 2019-02-15  Tom Tromey  <tromey@adacore.com>
8993
8994         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8995         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8996         (ravenscar_thread_target::stopped_by_watchpoint)
8997         (ravenscar_thread_target::stopped_data_address)
8998         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8999
9000 2019-02-15  Tom Tromey  <tromey@adacore.com>
9001
9002         * ravenscar-thread.c: Fix some typos.
9003
9004 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9005             Tom Tromey  <tromey@adacore.com>
9006
9007         * ada-lang.c (ada_exception_sal): Change addr_string to a
9008         std::string.
9009         (create_ada_exception_catchpoint): Update.
9010
9011 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9012             Tom Tromey  <tromey@adacore.com>
9013
9014         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9015         (bp_location_ops): Remove.
9016         (base_breakpoint_allocate_location): Update.
9017         (free_bp_location): Update.
9018         * ada-lang.c (class ada_catchpoint_location)
9019         <ada_catchpoint_location>: Remove ops parameter.
9020         (ada_catchpoint_location_dtor): Remove.
9021         (ada_catchpoint_location_ops): Remove.
9022         (allocate_location_exception): Update.
9023         * breakpoint.h (struct bp_location_ops): Remove.
9024         (class bp_location) <bp_location>: Remove bp_location_ops
9025         parameter.
9026         <~bp_location>: Add destructor.
9027         <ops>: Remove.
9028
9029 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9030             Pedro Alves  <palves@redhat.com>
9031
9032         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9033         'PATH_MAX'.
9034
9035 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9036             Samuel Thibault  <samuel.thibault@gnu.org>
9037             Thomas Schwinge  <thomas@codesourcery.com>
9038
9039         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9040         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9041
9042 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9043
9044         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9045         (check_empty): Use "const char *".
9046
9047         * gnu-nat.c (gnu_nat_target::detach): Instead of
9048         'detach_inferior (pid)' call
9049         'detach_inferior (find_inferior_pid (pid))'.
9050
9051         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9052         'nat/fork-inferior.o'.
9053         * gnu-nat.c: #include "nat/fork-inferior.h".
9054
9055         * gnu-nat.c (gnu_nat_target::detach): Instead of
9056         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9057         * gnu-nat.h: #include "inf-child.h".
9058         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9059         'i386_gnu_nat_target::fetch_registers'.
9060         (gnu_store_registers): Rename/move to
9061         'i386_gnu_nat_target::store_registers'.
9062
9063         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9064         * gnu-nat.h (mach_thread_info): New function.
9065         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9066
9067         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9068
9069 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9070
9071         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9072
9073 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9074
9075         * windows-nat.c (windows_add_thread): Add new parameter
9076         "main_thread_p" with default value set to false.  Update
9077         function documentation as well as all callers.
9078         (windows_delete_thread): Likewise.
9079         (fake_create_process): Update call to windows_add_thread.
9080         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9081         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9082         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9083         call to windows_delete_thread.
9084
9085 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9086
9087         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9088
9089 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9090
9091         * symfile.c (find_separate_debug_file): Use canonical path of
9092         sysroot with child_path instead of gdb_sysroot if it is valid.
9093
9094 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9095
9096         * symfile.c (find_separate_debug_file): Use child_path to
9097         determine if an object file is under a sysroot.
9098
9099 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9100
9101         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9102         unittests/child-path-selftests.c.
9103         * common/pathstuff.c (child_path): New function.
9104         * common/pathstuff.h (child_path): New prototype.
9105         * unittests/child-path-selftests.c: New file.
9106
9107 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9108
9109         * symfile.c (find_separate_debug_file): Look for separate debug
9110         files in debug directories under the sysroot.
9111
9112 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9113
9114         * symtab.h (struct minimal_symbol data_p): New const method.
9115         (struct minimal_symbol text_p): Likewise.
9116         * symtab.c (output_source_filename): Use file name style
9117         to print file name.
9118         (print_symbol_info): Likewise.
9119         (print_msymbol_info): Use address style to print addresses.
9120         Use function name style to print executable text symbols.
9121         (expand_symtab_containing_pc): Use data_p.
9122         (find_pc_sect_compunit_symtab): Likewise.
9123
9124 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9125
9126         * breakpoint.c (describe_other_breakpoints): Use address style
9127         to print addresses.
9128         (say_where): Likewise.
9129
9130 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9131
9132         * ada-typeprint.c (print_func_type): Print function name
9133         style to print function name.
9134         * c-typeprint.c (c_print_type_1): Likewise.
9135
9136 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9137
9138         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9139         for execve.
9140
9141 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9142
9143         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9144         type_stack.
9145
9146 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9147
9148         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9149         TYPE_CODE_REF types.
9150
9151 2019-02-08  Jim Wilson  <jimw@sifive.com>
9152
9153         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9154         (riscv_linux_fregset): New.
9155         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9156
9157 2019-02-07  Tom Tromey  <tom@tromey.com>
9158
9159         * thread.c (thread_cancel_execution_command): Update.
9160         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9161         methods.
9162         (struct thread_fsm_ops): Remove.
9163         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9164         (thread_fsm_should_stop, thread_fsm_return_value)
9165         (thread_fsm_set_finished, thread_fsm_finished_p)
9166         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9167         Don't declare.
9168         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9169         * infrun.c (clear_proceed_status_thread)
9170         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9171         (print_stop_event): Update.
9172         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9173         Add constructor.
9174         (step_command_fsm_ops): Remove.
9175         (new_step_command_fsm): Remove.
9176         (step_1): Update.
9177         (step_command_fsm::should_stop): Rename from
9178         step_command_fsm_should_stop.
9179         (step_command_fsm::clean_up): Rename from
9180         step_command_fsm_clean_up.
9181         (step_command_fsm::do_async_reply_reason): Rename from
9182         step_command_fsm_async_reply_reason.
9183         (struct until_next_fsm): Inherit from thread_fsm.  Add
9184         constructor.
9185         (until_next_fsm_ops): Remove.
9186         (new_until_next_fsm): Remove.
9187         (until_next_fsm::should_stop): Rename from
9188         until_next_fsm_should_stop.
9189         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9190         (until_next_fsm::do_async_reply_reason): Rename from
9191         until_next_fsm_async_reply_reason.
9192         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9193         constructor.  Change type of breakpoint.
9194         (finish_command_fsm_ops): Remove.
9195         (new_finish_command_fsm): Remove.
9196         (finish_command_fsm::should_stop): Rename from
9197         finish_command_fsm_should_stop.
9198         (finish_command_fsm::clean_up): Rename from
9199         finish_command_fsm_clean_up.
9200         (finish_command_fsm::return_value): Rename from
9201         finish_command_fsm_return_value.
9202         (finish_command_fsm::do_async_reply_reason): Rename from
9203         finish_command_fsm_async_reply_reason.
9204         (finish_command): Update.
9205         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9206         Add constructor.
9207         (call_thread_fsm_ops): Remove.
9208         (call_thread_fsm::call_thread_fsm): Rename from
9209         new_call_thread_fsm.
9210         (call_thread_fsm::should_stop): Rename from
9211         call_thread_fsm_should_stop.
9212         (call_thread_fsm::should_notify_stop): Rename from
9213         call_thread_fsm_should_notify_stop.
9214         (run_inferior_call, call_function_by_hand_dummy): Update.
9215         * cli/cli-interp.c (should_print_stop_to_console): Update.
9216         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9217         Add constructor.  Change type of location_breakpoint,
9218         caller_breakpoint.
9219         (until_break_fsm_ops): Remove.
9220         (new_until_break_fsm): Remove.
9221         (until_break_fsm::should_stop): Rename from
9222         until_break_fsm_should_stop.
9223         (until_break_fsm::clean_up): Rename from
9224         until_break_fsm_clean_up.
9225         (until_break_fsm::do_async_reply_reason): Rename from
9226         until_break_fsm_async_reply_reason.
9227         (until_break_command): Update.
9228         * thread-fsm.c: Remove.
9229         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9230
9231 2019-02-07  Tom Tromey  <tom@tromey.com>
9232
9233         * yy-remap.h: Add include guard.
9234         * xtensa-tdep.h: Add include guard.
9235         * xcoffread.h: Rename include guard.
9236         * varobj-iter.h: Add include guard.
9237         * tui/tui.h: Rename include guard.
9238         * tui/tui-winsource.h: Rename include guard.
9239         * tui/tui-wingeneral.h: Rename include guard.
9240         * tui/tui-windata.h: Rename include guard.
9241         * tui/tui-win.h: Rename include guard.
9242         * tui/tui-stack.h: Rename include guard.
9243         * tui/tui-source.h: Rename include guard.
9244         * tui/tui-regs.h: Rename include guard.
9245         * tui/tui-out.h: Rename include guard.
9246         * tui/tui-layout.h: Rename include guard.
9247         * tui/tui-io.h: Rename include guard.
9248         * tui/tui-hooks.h: Rename include guard.
9249         * tui/tui-file.h: Rename include guard.
9250         * tui/tui-disasm.h: Rename include guard.
9251         * tui/tui-data.h: Rename include guard.
9252         * tui/tui-command.h: Rename include guard.
9253         * tic6x-tdep.h: Add include guard.
9254         * target/waitstatus.h: Rename include guard.
9255         * target/wait.h: Rename include guard.
9256         * target/target.h: Rename include guard.
9257         * target/resume.h: Rename include guard.
9258         * target-float.h: Rename include guard.
9259         * stabsread.h: Add include guard.
9260         * rs6000-tdep.h: Add include guard.
9261         * riscv-fbsd-tdep.h: Add include guard.
9262         * regformats/regdef.h: Rename include guard.
9263         * record.h: Rename include guard.
9264         * python/python.h: Rename include guard.
9265         * python/python-internal.h: Rename include guard.
9266         * python/py-stopevent.h: Rename include guard.
9267         * python/py-ref.h: Rename include guard.
9268         * python/py-record.h: Rename include guard.
9269         * python/py-record-full.h: Rename include guard.
9270         * python/py-record-btrace.h: Rename include guard.
9271         * python/py-instruction.h: Rename include guard.
9272         * python/py-events.h: Rename include guard.
9273         * python/py-event.h: Rename include guard.
9274         * procfs.h: Add include guard.
9275         * proc-utils.h: Add include guard.
9276         * p-lang.h: Add include guard.
9277         * or1k-tdep.h: Rename include guard.
9278         * observable.h: Rename include guard.
9279         * nto-tdep.h: Rename include guard.
9280         * nat/x86-linux.h: Rename include guard.
9281         * nat/x86-linux-dregs.h: Rename include guard.
9282         * nat/x86-gcc-cpuid.h: Add include guard.
9283         * nat/x86-dregs.h: Rename include guard.
9284         * nat/x86-cpuid.h: Rename include guard.
9285         * nat/ppc-linux.h: Rename include guard.
9286         * nat/mips-linux-watch.h: Rename include guard.
9287         * nat/linux-waitpid.h: Rename include guard.
9288         * nat/linux-ptrace.h: Rename include guard.
9289         * nat/linux-procfs.h: Rename include guard.
9290         * nat/linux-osdata.h: Rename include guard.
9291         * nat/linux-nat.h: Rename include guard.
9292         * nat/linux-namespaces.h: Rename include guard.
9293         * nat/linux-btrace.h: Rename include guard.
9294         * nat/glibc_thread_db.h: Rename include guard.
9295         * nat/gdb_thread_db.h: Rename include guard.
9296         * nat/gdb_ptrace.h: Rename include guard.
9297         * nat/fork-inferior.h: Rename include guard.
9298         * nat/amd64-linux-siginfo.h: Rename include guard.
9299         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9300         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9301         * nat/aarch64-linux.h: Rename include guard.
9302         * nat/aarch64-linux-hw-point.h: Rename include guard.
9303         * mn10300-tdep.h: Add include guard.
9304         * mips-linux-tdep.h: Add include guard.
9305         * mi/mi-parse.h: Rename include guard.
9306         * mi/mi-out.h: Rename include guard.
9307         * mi/mi-main.h: Rename include guard.
9308         * mi/mi-interp.h: Rename include guard.
9309         * mi/mi-getopt.h: Rename include guard.
9310         * mi/mi-console.h: Rename include guard.
9311         * mi/mi-common.h: Rename include guard.
9312         * mi/mi-cmds.h: Rename include guard.
9313         * mi/mi-cmd-break.h: Rename include guard.
9314         * m2-lang.h: Add include guard.
9315         * location.h: Rename include guard.
9316         * linux-record.h: Rename include guard.
9317         * linux-nat.h: Add include guard.
9318         * linux-fork.h: Add include guard.
9319         * i386-darwin-tdep.h: Rename include guard.
9320         * hppa-linux-offsets.h: Add include guard.
9321         * guile/guile.h: Rename include guard.
9322         * guile/guile-internal.h: Rename include guard.
9323         * gnu-nat.h: Rename include guard.
9324         * gdb-stabs.h: Rename include guard.
9325         * frv-tdep.h: Add include guard.
9326         * f-lang.h: Add include guard.
9327         * event-loop.h: Add include guard.
9328         * darwin-nat.h: Rename include guard.
9329         * cp-abi.h: Rename include guard.
9330         * config/sparc/nm-sol2.h: Rename include guard.
9331         * config/nm-nto.h: Rename include guard.
9332         * config/nm-linux.h: Add include guard.
9333         * config/i386/nm-i386gnu.h: Rename include guard.
9334         * config/djgpp/nl_types.h: Rename include guard.
9335         * config/djgpp/langinfo.h: Rename include guard.
9336         * compile/gcc-cp-plugin.h: Add include guard.
9337         * compile/gcc-c-plugin.h: Add include guard.
9338         * compile/compile.h: Rename include guard.
9339         * compile/compile-object-run.h: Rename include guard.
9340         * compile/compile-object-load.h: Rename include guard.
9341         * compile/compile-internal.h: Rename include guard.
9342         * compile/compile-cplus.h: Rename include guard.
9343         * compile/compile-c.h: Rename include guard.
9344         * common/xml-utils.h: Rename include guard.
9345         * common/x86-xstate.h: Rename include guard.
9346         * common/version.h: Rename include guard.
9347         * common/vec.h: Rename include guard.
9348         * common/tdesc.h: Rename include guard.
9349         * common/selftest.h: Rename include guard.
9350         * common/scoped_restore.h: Rename include guard.
9351         * common/scoped_mmap.h: Rename include guard.
9352         * common/scoped_fd.h: Rename include guard.
9353         * common/safe-iterator.h: Rename include guard.
9354         * common/run-time-clock.h: Rename include guard.
9355         * common/refcounted-object.h: Rename include guard.
9356         * common/queue.h: Rename include guard.
9357         * common/ptid.h: Rename include guard.
9358         * common/print-utils.h: Rename include guard.
9359         * common/preprocessor.h: Rename include guard.
9360         * common/pathstuff.h: Rename include guard.
9361         * common/observable.h: Rename include guard.
9362         * common/netstuff.h: Rename include guard.
9363         * common/job-control.h: Rename include guard.
9364         * common/host-defs.h: Rename include guard.
9365         * common/gdb_wait.h: Rename include guard.
9366         * common/gdb_vecs.h: Rename include guard.
9367         * common/gdb_unlinker.h: Rename include guard.
9368         * common/gdb_unique_ptr.h: Rename include guard.
9369         * common/gdb_tilde_expand.h: Rename include guard.
9370         * common/gdb_sys_time.h: Rename include guard.
9371         * common/gdb_string_view.h: Rename include guard.
9372         * common/gdb_splay_tree.h: Rename include guard.
9373         * common/gdb_setjmp.h: Rename include guard.
9374         * common/gdb_ref_ptr.h: Rename include guard.
9375         * common/gdb_optional.h: Rename include guard.
9376         * common/gdb_locale.h: Rename include guard.
9377         * common/gdb_assert.h: Rename include guard.
9378         * common/filtered-iterator.h: Rename include guard.
9379         * common/filestuff.h: Rename include guard.
9380         * common/fileio.h: Rename include guard.
9381         * common/environ.h: Rename include guard.
9382         * common/common-utils.h: Rename include guard.
9383         * common/common-types.h: Rename include guard.
9384         * common/common-regcache.h: Rename include guard.
9385         * common/common-inferior.h: Rename include guard.
9386         * common/common-gdbthread.h: Rename include guard.
9387         * common/common-exceptions.h: Rename include guard.
9388         * common/common-defs.h: Rename include guard.
9389         * common/common-debug.h: Rename include guard.
9390         * common/cleanups.h: Rename include guard.
9391         * common/buffer.h: Rename include guard.
9392         * common/btrace-common.h: Rename include guard.
9393         * common/break-common.h: Rename include guard.
9394         * cli/cli-utils.h: Rename include guard.
9395         * cli/cli-style.h: Rename include guard.
9396         * cli/cli-setshow.h: Rename include guard.
9397         * cli/cli-script.h: Rename include guard.
9398         * cli/cli-interp.h: Rename include guard.
9399         * cli/cli-decode.h: Rename include guard.
9400         * cli/cli-cmds.h: Rename include guard.
9401         * charset-list.h: Add include guard.
9402         * buildsym-legacy.h: Rename include guard.
9403         * bfin-tdep.h: Add include guard.
9404         * ax.h: Rename include guard.
9405         * arm-linux-tdep.h: Add include guard.
9406         * arm-fbsd-tdep.h: Add include guard.
9407         * arch/xtensa.h: Rename include guard.
9408         * arch/tic6x.h: Add include guard.
9409         * arch/i386.h: Add include guard.
9410         * arch/arm.h: Rename include guard.
9411         * arch/arm-linux.h: Rename include guard.
9412         * arch/arm-get-next-pcs.h: Rename include guard.
9413         * arch/amd64.h: Add include guard.
9414         * arch/aarch64-insn.h: Rename include guard.
9415         * arch-utils.h: Rename include guard.
9416         * annotate.h: Add include guard.
9417         * amd64-darwin-tdep.h: Rename include guard.
9418         * aarch64-linux-tdep.h: Add include guard.
9419         * aarch64-fbsd-tdep.h: Add include guard.
9420         * aarch32-linux-nat.h: Add include guard.
9421
9422 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9423
9424         * macrotab.c (macro_define_internal): New function that
9425         factorizes macro_define_object_internal and macro_define_function
9426         code.
9427         (macro_define_object_internal): Use macro_define_internal.
9428         (macro_define_function): Likewise.
9429
9430 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9431
9432         * macrocmd.c (extract_identifier): Return
9433         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9434         callers.
9435
9436 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9437
9438         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9439
9440 2019-02-05  Tom Tromey  <tom@tromey.com>
9441
9442         * target.c (target_stack::unpush): Move assertion earlier.
9443
9444 2019-01-30  Tom Tromey  <tom@tromey.com>
9445
9446         PR python/23615:
9447         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9448         (gdbpy_parse_and_eval): Likewise.
9449         * python/python-internal.h (gdbpy_allow_threads): New class.
9450
9451 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9452
9453         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9454         (aarch64_fbsd_fpregmap): Move earlier.
9455         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9456         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9457         instead of individual calls to trad_frame_set_reg_addr.
9458         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9459         earlier.
9460         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9461         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9462         instead of individual calls to trad_frame_set_reg_addr.
9463
9464 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9465
9466         * CONTRIBUTE: Replace contribution list with wiki link.
9467
9468 2019-01-25  Tom Tromey  <tom@tromey.com>
9469
9470         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9471
9472 2019-01-25  Tom Tromey  <tom@tromey.com>
9473
9474         * xtensa-linux-nat.c: Fix common/ includes.
9475         * xml-support.h: Fix common/ includes.
9476         * xml-support.c: Fix common/ includes.
9477         * x86-linux-nat.c: Fix common/ includes.
9478         * windows-nat.c: Fix common/ includes.
9479         * varobj.h: Fix common/ includes.
9480         * varobj.c: Fix common/ includes.
9481         * value.c: Fix common/ includes.
9482         * valops.c: Fix common/ includes.
9483         * utils.c: Fix common/ includes.
9484         * unittests/xml-utils-selftests.c: Fix common/ includes.
9485         * unittests/utils-selftests.c: Fix common/ includes.
9486         * unittests/unpack-selftests.c: Fix common/ includes.
9487         * unittests/tracepoint-selftests.c: Fix common/ includes.
9488         * unittests/style-selftests.c: Fix common/ includes.
9489         * unittests/string_view-selftests.c: Fix common/ includes.
9490         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9491         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9492         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9493         * unittests/rsp-low-selftests.c: Fix common/ includes.
9494         * unittests/parse-connection-spec-selftests.c: Fix common/
9495         includes.
9496         * unittests/optional-selftests.c: Fix common/ includes.
9497         * unittests/offset-type-selftests.c: Fix common/ includes.
9498         * unittests/observable-selftests.c: Fix common/ includes.
9499         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9500         * unittests/memrange-selftests.c: Fix common/ includes.
9501         * unittests/memory-map-selftests.c: Fix common/ includes.
9502         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9503         * unittests/function-view-selftests.c: Fix common/ includes.
9504         * unittests/environ-selftests.c: Fix common/ includes.
9505         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9506         * unittests/common-utils-selftests.c: Fix common/ includes.
9507         * unittests/cli-utils-selftests.c: Fix common/ includes.
9508         * unittests/array-view-selftests.c: Fix common/ includes.
9509         * ui-file.c: Fix common/ includes.
9510         * tui/tui-io.c: Fix common/ includes.
9511         * tracepoint.h: Fix common/ includes.
9512         * tracepoint.c: Fix common/ includes.
9513         * tracefile-tfile.c: Fix common/ includes.
9514         * top.h: Fix common/ includes.
9515         * top.c: Fix common/ includes.
9516         * thread.c: Fix common/ includes.
9517         * target/waitstatus.h: Fix common/ includes.
9518         * target/waitstatus.c: Fix common/ includes.
9519         * target.h: Fix common/ includes.
9520         * target.c: Fix common/ includes.
9521         * target-memory.c: Fix common/ includes.
9522         * target-descriptions.c: Fix common/ includes.
9523         * symtab.h: Fix common/ includes.
9524         * symfile.c: Fix common/ includes.
9525         * stap-probe.c: Fix common/ includes.
9526         * spu-linux-nat.c: Fix common/ includes.
9527         * sparc-nat.c: Fix common/ includes.
9528         * source.c: Fix common/ includes.
9529         * solib.c: Fix common/ includes.
9530         * solib-target.c: Fix common/ includes.
9531         * ser-unix.c: Fix common/ includes.
9532         * ser-tcp.c: Fix common/ includes.
9533         * ser-pipe.c: Fix common/ includes.
9534         * ser-base.c: Fix common/ includes.
9535         * selftest-arch.c: Fix common/ includes.
9536         * s12z-tdep.c: Fix common/ includes.
9537         * rust-exp.y: Fix common/ includes.
9538         * rs6000-aix-tdep.c: Fix common/ includes.
9539         * riscv-tdep.c: Fix common/ includes.
9540         * remote.c: Fix common/ includes.
9541         * remote-notif.h: Fix common/ includes.
9542         * remote-fileio.h: Fix common/ includes.
9543         * remote-fileio.c: Fix common/ includes.
9544         * regcache.h: Fix common/ includes.
9545         * regcache.c: Fix common/ includes.
9546         * record-btrace.c: Fix common/ includes.
9547         * python/python.c: Fix common/ includes.
9548         * python/py-type.c: Fix common/ includes.
9549         * python/py-inferior.c: Fix common/ includes.
9550         * progspace.h: Fix common/ includes.
9551         * producer.c: Fix common/ includes.
9552         * procfs.c: Fix common/ includes.
9553         * proc-api.c: Fix common/ includes.
9554         * printcmd.c: Fix common/ includes.
9555         * ppc-linux-nat.c: Fix common/ includes.
9556         * parser-defs.h: Fix common/ includes.
9557         * osdata.c: Fix common/ includes.
9558         * obsd-nat.c: Fix common/ includes.
9559         * nat/x86-linux.c: Fix common/ includes.
9560         * nat/x86-linux-dregs.c: Fix common/ includes.
9561         * nat/x86-dregs.h: Fix common/ includes.
9562         * nat/x86-dregs.c: Fix common/ includes.
9563         * nat/ppc-linux.c: Fix common/ includes.
9564         * nat/mips-linux-watch.h: Fix common/ includes.
9565         * nat/mips-linux-watch.c: Fix common/ includes.
9566         * nat/linux-waitpid.c: Fix common/ includes.
9567         * nat/linux-ptrace.h: Fix common/ includes.
9568         * nat/linux-ptrace.c: Fix common/ includes.
9569         * nat/linux-procfs.c: Fix common/ includes.
9570         * nat/linux-personality.c: Fix common/ includes.
9571         * nat/linux-osdata.c: Fix common/ includes.
9572         * nat/linux-namespaces.c: Fix common/ includes.
9573         * nat/linux-btrace.h: Fix common/ includes.
9574         * nat/linux-btrace.c: Fix common/ includes.
9575         * nat/fork-inferior.c: Fix common/ includes.
9576         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9577         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9578         * nat/aarch64-linux.c: Fix common/ includes.
9579         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9580         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9581         * namespace.h: Fix common/ includes.
9582         * mips-linux-tdep.c: Fix common/ includes.
9583         * minsyms.c: Fix common/ includes.
9584         * mi/mi-parse.h: Fix common/ includes.
9585         * mi/mi-main.c: Fix common/ includes.
9586         * mi/mi-cmd-env.c: Fix common/ includes.
9587         * memrange.h: Fix common/ includes.
9588         * memattr.c: Fix common/ includes.
9589         * maint.h: Fix common/ includes.
9590         * maint.c: Fix common/ includes.
9591         * main.c: Fix common/ includes.
9592         * machoread.c: Fix common/ includes.
9593         * location.c: Fix common/ includes.
9594         * linux-thread-db.c: Fix common/ includes.
9595         * linux-nat.c: Fix common/ includes.
9596         * linux-fork.c: Fix common/ includes.
9597         * inline-frame.c: Fix common/ includes.
9598         * infrun.c: Fix common/ includes.
9599         * inflow.c: Fix common/ includes.
9600         * inferior.h: Fix common/ includes.
9601         * inferior.c: Fix common/ includes.
9602         * infcmd.c: Fix common/ includes.
9603         * inf-ptrace.c: Fix common/ includes.
9604         * inf-child.c: Fix common/ includes.
9605         * ia64-linux-nat.c: Fix common/ includes.
9606         * i387-tdep.c: Fix common/ includes.
9607         * i386-tdep.c: Fix common/ includes.
9608         * i386-linux-tdep.c: Fix common/ includes.
9609         * i386-linux-nat.c: Fix common/ includes.
9610         * i386-go32-tdep.c: Fix common/ includes.
9611         * i386-fbsd-tdep.c: Fix common/ includes.
9612         * i386-fbsd-nat.c: Fix common/ includes.
9613         * guile/scm-type.c: Fix common/ includes.
9614         * guile/guile.c: Fix common/ includes.
9615         * go32-nat.c: Fix common/ includes.
9616         * gnu-nat.c: Fix common/ includes.
9617         * gdbthread.h: Fix common/ includes.
9618         * gdbarch-selftests.c: Fix common/ includes.
9619         * gdb_usleep.c: Fix common/ includes.
9620         * gdb_select.h: Fix common/ includes.
9621         * gdb_bfd.c: Fix common/ includes.
9622         * gcore.c: Fix common/ includes.
9623         * fork-child.c: Fix common/ includes.
9624         * findvar.c: Fix common/ includes.
9625         * fbsd-nat.c: Fix common/ includes.
9626         * event-top.c: Fix common/ includes.
9627         * event-loop.c: Fix common/ includes.
9628         * dwarf2read.c: Fix common/ includes.
9629         * dwarf2loc.c: Fix common/ includes.
9630         * dwarf2-frame.c: Fix common/ includes.
9631         * dwarf-index-cache.c: Fix common/ includes.
9632         * dtrace-probe.c: Fix common/ includes.
9633         * disasm-selftests.c: Fix common/ includes.
9634         * defs.h: Fix common/ includes.
9635         * csky-tdep.c: Fix common/ includes.
9636         * cp-valprint.c: Fix common/ includes.
9637         * cp-support.h: Fix common/ includes.
9638         * cp-support.c: Fix common/ includes.
9639         * corelow.c: Fix common/ includes.
9640         * completer.h: Fix common/ includes.
9641         * completer.c: Fix common/ includes.
9642         * compile/compile.c: Fix common/ includes.
9643         * compile/compile-loc2c.c: Fix common/ includes.
9644         * compile/compile-cplus-types.c: Fix common/ includes.
9645         * compile/compile-cplus-symbols.c: Fix common/ includes.
9646         * command.h: Fix common/ includes.
9647         * cli/cli-dump.c: Fix common/ includes.
9648         * cli/cli-cmds.c: Fix common/ includes.
9649         * charset.c: Fix common/ includes.
9650         * build-id.c: Fix common/ includes.
9651         * btrace.h: Fix common/ includes.
9652         * btrace.c: Fix common/ includes.
9653         * breakpoint.h: Fix common/ includes.
9654         * breakpoint.c: Fix common/ includes.
9655         * ax.h:
9656         (enum agent_op): Fix common/ includes.
9657         * ax-general.c (struct aop_map): Fix common/ includes.
9658         * ax-gdb.c: Fix common/ includes.
9659         * auxv.c: Fix common/ includes.
9660         * auto-load.c: Fix common/ includes.
9661         * arm-tdep.c: Fix common/ includes.
9662         * arch/riscv.c: Fix common/ includes.
9663         * arch/ppc-linux-common.c: Fix common/ includes.
9664         * arch/i386.c: Fix common/ includes.
9665         * arch/arm.c: Fix common/ includes.
9666         * arch/arm-linux.c: Fix common/ includes.
9667         * arch/arm-get-next-pcs.c: Fix common/ includes.
9668         * arch/amd64.c: Fix common/ includes.
9669         * arch/aarch64.c: Fix common/ includes.
9670         * arch/aarch64-insn.c: Fix common/ includes.
9671         * arch-utils.c: Fix common/ includes.
9672         * amd64-windows-tdep.c: Fix common/ includes.
9673         * amd64-tdep.c: Fix common/ includes.
9674         * amd64-sol2-tdep.c: Fix common/ includes.
9675         * amd64-obsd-tdep.c: Fix common/ includes.
9676         * amd64-nbsd-tdep.c: Fix common/ includes.
9677         * amd64-linux-tdep.c: Fix common/ includes.
9678         * amd64-linux-nat.c: Fix common/ includes.
9679         * amd64-fbsd-tdep.c: Fix common/ includes.
9680         * amd64-fbsd-nat.c: Fix common/ includes.
9681         * amd64-dicos-tdep.c: Fix common/ includes.
9682         * amd64-darwin-tdep.c: Fix common/ includes.
9683         * agent.c: Fix common/ includes.
9684         * ada-lang.h: Fix common/ includes.
9685         * ada-lang.c: Fix common/ includes.
9686         * aarch64-tdep.c: Fix common/ includes.
9687
9688 2019-01-25  Tom Tromey  <tom@tromey.com>
9689
9690         * common/create-version.sh: Use common/version.h.
9691
9692 2019-01-24  Pedro Alves  <palves@redhat.com>
9693
9694         * infrun.c (signal_stop, signal_print, signal_program)
9695         (signal_catch, signal_pass): Now arrays instead of pointers.
9696         (update_signals_program_target, do_target_resume)
9697         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9698         * linux-nat.c (linux_nat_target::pass_signals)
9699         (linux_nat_target::create_inferior, linux_nat_target::attach):
9700         Adjust.
9701         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9702         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9703         * procfs.c (procfs_target::pass_signals): Adjust.
9704         * record-full.c (record_full_target::resume): Adjust.
9705         * remote.c (remote_target::pass_signals)
9706         (remote_target::program_signals): Adjust.
9707         * target-debug.h (target_debug_print_signals): Now takes a
9708         gdb::array_view as parameter.  Adjust.
9709         * target.h (target_ops) <pass_signals, program_signals>: Replace
9710         pointer and length parameters with gdb::array_view.
9711         (target_pass_signals, target_program_signals): Likewise.
9712         * target-delegates.c: Regenerate.
9713
9714 2019-01-24  Pedro Alves  <palves@redhat.com>
9715
9716         * common/forward-scope-exit.h
9717         (forward_scope_exit::forward_scope_exit): Pass arguments to
9718         m_bind_function directly, instead of creating a std::bind and
9719         copying that.
9720
9721 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9722
9723         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9724         for static members.
9725         (pass_in_v_vfp_candidate): Likewise.
9726
9727 2019-01-23  Tom Tromey  <tom@tromey.com>
9728             Pedro Alves  <palves@redhat.com>
9729
9730         * regcache.c (class regcache_invalidator): Remove.
9731         (regcache::raw_write): Use make_scope_exit.
9732
9733 2019-01-23  Tom Tromey  <tom@tromey.com>
9734
9735         * ui-out.h (class ui_out_emit_type): Update comment.
9736
9737 2019-01-23  Tom Tromey  <tom@tromey.com>
9738
9739         * infrun.c (fetch_inferior_event): Update comment.
9740
9741 2019-01-23  Tom Tromey  <tom@tromey.com>
9742             Pedro Alves  <palves@redhat.com>
9743
9744         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9745         parameter.
9746         (fetch_inferior_event): Use SCOPE_EXIT.
9747
9748
9749 2019-01-23  Tom Tromey  <tom@tromey.com>
9750             Pedro Alves  <palves@redhat.com>
9751
9752         * infrun.c (disable_thread_events): Delete.
9753         (stop_all_threads): Use SCOPE_EXIT.
9754
9755 2019-01-23  Tom Tromey  <tom@tromey.com>
9756             Pedro Alves  <palves@redhat.com>
9757
9758         * symfile.c: Include forward-scope-exit.h.
9759         (clear_symtab_users_cleanup): Replace forward declaration with
9760         a FORWARD_SCOPE_EXIT.
9761         (syms_from_objfile_1): Use the forward_scope_exit and
9762         gdb::optional instead of cleanup_function.
9763         (reread_symbols): Use the forward_scope_exit instead of
9764         cleanup_function.
9765         (clear_symtab_users_cleanup): Remove function.
9766
9767 2019-01-23  Tom Tromey  <tom@tromey.com>
9768             Pedro Alves  <palves@redhat.com>
9769
9770         * linux-nat.c: Include scope-exit.h.
9771         (cleanup_target_stop): Remove.
9772         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9773         SCOPE_EXIT.
9774
9775 2019-01-23  Tom Tromey  <tom@tromey.com>
9776             Pedro Alves  <palves@redhat.com>
9777
9778         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9779         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9780
9781 2019-01-23  Tom Tromey  <tom@tromey.com>
9782             Andrew Burgess  <andrew.burgess@embecosm.com>
9783             Pedro Alves  <palves@redhat.com>
9784
9785         * infrun.c (fetch_inferior_event): Use scope_exit.
9786         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9787         * top.c (execute_command): Use scope_exit.
9788         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9789         * utils.c (do_bpstat_clear_actions_cleanup)
9790         (make_bpstat_clear_actions_cleanup): Remove.
9791
9792 2019-01-23  Tom Tromey  <tom@tromey.com>
9793             Pedro Alves  <palves@redhat.com>
9794
9795         * infrun.c: Include "common/scope-exit.h"
9796         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9797         (wait_for_inferior): Use SCOPE_EXIT.
9798         (fetch_inferior_event): Use scope_exit.
9799
9800 2019-01-23  Tom Tromey  <tom@tromey.com>
9801             Pedro Alves  <palves@redhat.com>
9802
9803         * breakpoint.c (create_breakpoint): Remove cleanup.
9804
9805 2019-01-23  Tom Tromey  <tom@tromey.com>
9806             Andrew Burgess  <andrew.burgess@embecosm.com>
9807             Pedro Alves  <palves@redhat.com>
9808
9809 2019-01-23  Pedro Alves  <palves@redhat.com>
9810
9811         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9812
9813 2019-01-23  Pedro Alves  <palves@redhat.com>
9814             Andrew Burgess  <andrew.burgess@embecosm.com>
9815
9816         * gdbthread.h: Include "common/forward-scope-exit.h".
9817         (scoped_finish_thread_state): Redefine custom class in terms of
9818         forward_scope_exit.
9819
9820 2019-01-23  Pedro Alves  <palves@redhat.com>
9821             Andrew Burgess  <andrew.burgess@embecosm.com>
9822
9823         * common/forward-scope-exit.h: New file.
9824
9825 2019-01-23  Pedro Alves  <palves@redhat.com>
9826             Andrew Burgess  <andrew.burgess@embecosm.com>
9827             Tom Tromey  <tom@tromey.com>
9828
9829         * common/scope-exit.h: New file.
9830
9831 2019-01-23  Pedro Alves  <palves@redhat.com>
9832
9833         * common/preprocessor.h (ESC): Rename to ...
9834         (ESC_PARENS): ... this.
9835         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9836         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9837
9838 2019-01-23  Tom Tromey  <tom@tromey.com>
9839
9840         * language.h (class scoped_switch_to_sym_language_if_auto):
9841         Initialize m_lang in both cases.
9842
9843 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9844
9845         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9846         with XCNEW.
9847
9848 2019-01-22  Tom Tromey  <tom@tromey.com>
9849
9850         * corelow.c: Do not include sys/file.h.
9851
9852 2019-01-22  Tom Tromey  <tom@tromey.com>
9853
9854         * tui/tui-wingeneral.h: Include gdb_curses.h.
9855
9856 2019-01-22  Tom Tromey  <tom@tromey.com>
9857
9858         * source-cache.h (class source_cache) <get_source_lines,
9859         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9860
9861 2019-01-22  Tom Tromey  <tom@tromey.com>
9862
9863         * remote-fileio.h (struct remote_target): Declare.
9864
9865 2019-01-22  Tom Tromey  <tom@tromey.com>
9866
9867         * python/py-arch.c: Do not include py-ref.h.
9868         * python/py-bpevent.c: Do not include py-ref.h.
9869         * python/py-cmd.c: Do not include py-ref.h.
9870         * python/py-continueevent.c: Do not include py-ref.h.
9871         * python/py-event.h: Do not include py-ref.h.
9872         * python/py-evtregistry.c: Do not include py-ref.h.
9873         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9874         * python/py-frame.c: Do not include py-ref.h.
9875         * python/py-framefilter.c: Do not include py-ref.h.
9876         * python/py-function.c: Do not include py-ref.h.
9877         * python/py-infevents.c: Do not include py-ref.h.
9878         * python/py-linetable.c: Do not include py-ref.h.
9879         * python/py-objfile.c: Do not include py-ref.h.
9880         * python/py-param.c: Do not include py-ref.h.
9881         * python/py-prettyprint.c: Do not include py-ref.h.
9882         * python/py-progspace.c: Do not include py-ref.h.
9883         * python/py-symbol.c: Do not include py-ref.h.
9884         * python/py-symtab.c: Do not include py-ref.h.
9885         * python/py-type.c: Do not include py-ref.h.
9886         * python/py-unwind.c: Do not include py-ref.h.
9887         * python/py-utils.c: Do not include py-ref.h.
9888         * python/py-value.c: Do not include py-ref.h.
9889         * python/py-varobj.c: Do not include py-ref.h.
9890         * python/py-xmethods.c: Do not include py-ref.h.
9891         * python/python.c: Do not include py-ref.h.
9892         * varobj.c: Do not include py-ref.h.
9893
9894 2019-01-22  Tom Tromey  <tom@tromey.com>
9895
9896         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9897         keyword for bcache.
9898
9899 2019-01-22  Tom Tromey  <tom@tromey.com>
9900
9901         * compile/compile-cplus-types.c: Remove a comment by #include.
9902
9903 2019-01-22  Tom Tromey  <tom@tromey.com>
9904
9905         * compile/gcc-c-plugin.h: Include compile-internal.h.
9906
9907 2019-01-22  Tom Tromey  <tom@tromey.com>
9908
9909         * stabsread.c (EXTERN): Do not define.
9910         (symnum, next_symbol_text_func, processing_gcc_compilation)
9911         (within_function, global_sym_chain, global_stabs)
9912         (previous_stab_code, this_object_header_files)
9913         (n_this_object_header_files)
9914         (n_allocated_this_object_header_files): Define.
9915         * stabsread.h (EXTERN): Never define.  Use "extern".
9916
9917 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9918
9919         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9920         history_value.
9921
9922 2019-01-21  Tom Tromey  <tom@tromey.com>
9923
9924         * ui-out.c: Fix includes.
9925         * tui/tui-source.c: Fix includes.
9926         * target.c: Fix includes.
9927         * remote.c: Fix includes.
9928         * regcache.c: Fix includes.
9929         * python/py-block.c: Fix includes.
9930         * printcmd.c: Fix includes.
9931         * or1k-tdep.c: Fix includes.
9932         * mi/mi-main.c: Fix includes.
9933         * m32r-tdep.c: Fix includes.
9934         * csky-tdep.c: Fix includes.
9935         * compile/compile-cplus-types.c: Fix includes.
9936         * cli/cli-interp.c: Fix includes.
9937
9938 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9939
9940         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9941         for padding.
9942
9943 2019-01-16  Tom Tromey  <tom@tromey.com>
9944
9945         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9946         earlier.
9947         (struct objfile) <msymbols_range>: Move from top level.
9948         <msymbols>: New method.
9949         (class objfile_msymbols): Remove.
9950         * symtab.c (default_collect_symbol_completion_matches_break_on):
9951         Update.
9952         * symmisc.c (dump_msymbols): Update.
9953         * stabsread.c (scan_file_globals): Update.
9954         * objc-lang.c (info_selectors_command, info_classes_command)
9955         (find_methods): Update.
9956         * minsyms.c (find_solib_trampoline_target): Update.
9957         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9958         * coffread.c (coff_symfile_read): Update.
9959         * ada-lang.c (ada_lookup_simple_minsym)
9960         (ada_collect_symbol_completion_matches): Update.
9961
9962 2019-01-16  Tom Tromey  <tom@tromey.com>
9963
9964         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9965         type.  Remove no-argument constructor.
9966         <iterator::operator++>: Simplify.
9967         <begin>: Update.
9968         <end>: Use minimal_symbol_count.
9969
9970 2019-01-16  Tom Tromey  <tom@tromey.com>
9971
9972         * objfiles.h (struct objfile) <psymtabs>: New method.
9973         (class objfile_psymtabs): Remove.
9974         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9975         typedef.
9976         <range>: New method.
9977         (require_partial_symbols): Change return type.
9978         * psymtab.c (require_partial_symbols)
9979         (psym_expand_symtabs_matching): Update.
9980         * mdebugread.c (parse_partial_symbols): Update.
9981         * dbxread.c (dbx_end_psymtab): Update.
9982
9983 2019-01-15  Tom Tromey  <tom@tromey.com>
9984
9985         * symtab.c (lookup_objfile_from_block)
9986         (lookup_symbol_in_objfile_symtabs)
9987         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9988         (find_line_symtab, info_sources_command)
9989         (default_collect_symbol_completion_matches_break_on)
9990         (make_source_files_completion_list): Update.
9991         * symmisc.c (print_objfile_statistics, dump_objfile)
9992         (maintenance_print_symbols, maintenance_info_symtabs)
9993         (maintenance_check_symtabs, maintenance_info_line_tables):
9994         Update.
9995         * source.c (select_source_symtab)
9996         (forget_cached_source_info_for_objfile): Update.
9997         * objfiles.h (class objfile_compunits): Remove.
9998         (struct objfile) <compunits_range>: New typedef.
9999         (compunits): New method.
10000         * objfiles.c (objfile_relocate1): Update.
10001         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10002         * maint.c (count_symtabs_and_blocks): Update.
10003         * linespec.c (iterate_over_all_matching_symtabs): Update.
10004         * cp-support.c (add_symbol_overload_list_qualified): Update.
10005         * coffread.c (coff_symtab_read): Update.
10006         * ada-lang.c (add_nonlocal_symbols)
10007         (ada_collect_symbol_completion_matches)
10008         (ada_add_global_exceptions): Update.
10009
10010 2019-01-15  Tom Tromey  <tom@tromey.com>
10011
10012         * progspace.h (program_space) <objfiles_safe_range>: New
10013         typedef.
10014         <objfiles_safe>: New method.
10015         * objfiles.h (class all_objfiles_safe): Remove.
10016         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10017         * jit.c (jit_inferior_exit_hook): Update.
10018
10019 2019-01-17  Tom Tromey  <tom@tromey.com>
10020
10021         * progspace.h (program_space) <objfiles_range>: New typedef.
10022         <objfiles>: New method.
10023         <objfiles_head>: Rename from objfiles.
10024         (object_files): Update.
10025         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10026         * guile/scm-pretty-print.c
10027         (ppscm_find_pretty_printer_from_objfiles): Update.
10028         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10029         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10030         Update.
10031         * python/py-progspace.c (pspy_get_objfiles): Update.
10032         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10033         Update.
10034         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10035         (objfpy_lookup_objfile_by_build_id): Update.
10036         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10037         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10038         Update.
10039         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10040         (expand_symtab_containing_pc, lookup_objfile_from_block)
10041         (lookup_static_symbol, basic_lookup_transparent_type)
10042         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10043         (find_line_symtab, info_sources_command)
10044         (default_collect_symbol_completion_matches_break_on)
10045         (make_source_files_completion_list, find_main_name): Update.
10046         * symmisc.c (print_symbol_bcache_statistics)
10047         (print_objfile_statistics, maintenance_print_symbols)
10048         (maintenance_print_msymbols, maintenance_print_objfiles)
10049         (maintenance_info_symtabs, maintenance_check_symtabs)
10050         (maintenance_expand_symtabs, maintenance_info_line_tables):
10051         Update.
10052         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10053         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10054         (map_overlay_command, unmap_overlay_command)
10055         (simple_overlay_update, expand_symtabs_matching)
10056         (map_symbol_filenames): Update.
10057         * symfile-debug.c (set_debug_symfile): Update.
10058         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10059         Update.
10060         * source.c (select_source_symtab, forget_cached_source_info):
10061         Update.
10062         * solib.c (solib_read_symbols): Update.
10063         * solib-spu.c (append_ocl_sos): Update.
10064         * psymtab.c (maintenance_print_psymbols)
10065         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10066         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10067         * printcmd.c (info_symbol_command): Update.
10068         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10069         Update.
10070         * objfiles.h (class all_objfiles): Remove.
10071         * objfiles.c (have_partial_symbols, have_full_symbols)
10072         (have_minimal_symbols, qsort_cmp, update_section_map)
10073         (shared_objfile_contains_address_p)
10074         (default_iterate_over_objfiles_in_search_order): Update.
10075         * objc-lang.c (info_selectors_command, info_classes_command)
10076         (find_methods): Update.
10077         * minsyms.c (find_solib_trampoline_target): Update.
10078         * maint.c (maintenance_info_sections)
10079         (maintenance_translate_address, count_symtabs_and_blocks):
10080         Update.
10081         * main.c (captured_main_1): Update.
10082         * linux-thread-db.c (try_thread_db_load_from_pdir)
10083         (has_libpthread): Update.
10084         * linespec.c (iterate_over_all_matching_symtabs)
10085         (search_minsyms_for_name): Update.
10086         * jit.c (jit_find_objf_with_entry_addr): Update.
10087         * hppa-tdep.c (find_unwind_entry)
10088         (hppa_lookup_stub_minimal_symbol): Update.
10089         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10090         Update.
10091         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10092         (elf_gnu_ifunc_resolve_by_got): Update.
10093         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10094         * dwarf-index-write.c (save_gdb_index_command): Update.
10095         * cp-support.c (add_symbol_overload_list_qualified): Update.
10096         * breakpoint.c (create_overlay_event_breakpoint)
10097         (create_longjmp_master_breakpoint)
10098         (create_std_terminate_master_breakpoint)
10099         (create_exception_master_breakpoint): Update.
10100         * blockframe.c (find_pc_partial_function): Update.
10101         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10102         (ada_collect_symbol_completion_matches)
10103         (ada_add_global_exceptions): Update.
10104
10105 2019-01-17  Tom Tromey  <tom@tromey.com>
10106
10107         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10108         declare VEC.
10109         (solib_target_parse_libraries): Change return type.
10110         (library_list_start_segment, library_list_start_section)
10111         (library_list_end_library, library_list_start_library); Update.
10112         (solib_target_free_library_list): Remove.
10113         (solib_target_parse_libraries): Remove cleanup.  Change return
10114         type.
10115         (solib_target_current_sos): Update.
10116
10117 2019-01-17  Tom Tromey  <tromey@bapiya>
10118
10119         * valprint.c: Replace "the the" with "the".
10120         * symtab.c: Replace "the the" with "the".
10121         * solib.c: Replace "the the" with "the".
10122         * solib-dsbt.c: Replace "the the" with "the".
10123         * linespec.c: Replace "the the" with "the".
10124         * dwarf2loc.h: Replace "the the" with "the".
10125         * amd64-windows-tdep.c: Replace "the the" with "the".
10126         * aarch64-tdep.c: Replace "the the" with "the".
10127
10128 2019-01-16  Keith Seitz  <keiths@redhat.com>
10129
10130         PR gdb/23773
10131         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10132         <builder>: Rename to ..
10133         <m_builder>: ... this and make private.
10134         (dwarf2_cu::get_builder): New method.  Change all users of
10135         `builder' to use this method.
10136         (dwarf2_start_symtab): Move to ...
10137         (dwarf2_cu::start_symtab): ... here.  Update all callers
10138         (setup_type_unit_groups): Move to ...
10139         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10140         callers.
10141         (dwarf2_cu::reset_builder): New method.
10142         (process_full_compunit, process_full_type_unit): Use
10143         dwarf2_cu::reset_builder.
10144         (follow_die_offset): Record the ancestor CU if it is different
10145         from the followed DIE's CU.
10146         (follow_die_sig_1): Likewise.
10147
10148 2019-01-15  Tom Tromey  <tom@tromey.com>
10149
10150         * remote.c (class remote_state) <buf>: Now a char_vector.
10151         <buf_size>: Remove.
10152         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10153         parameter.
10154         (remote_target::getpkt_or_notif_sane_1)
10155         (remote_target::getpkt_sane)
10156         (remote_target::getpkt_or_notif_sane): Likewise.
10157         (class remote_target) <putpkt>: New overload.
10158         (remote_target::read_frame): Change type of "buf_p".  Remove
10159         sizeof_p parameter.
10160         (packet_ok): New overload.
10161         (packet_check_result): New overload.
10162         Update all uses.
10163
10164 2019-01-14  Tom Tromey  <tom@tromey.com>
10165
10166         * remote-notif.c (handle_notification, remote_notif_ack)
10167         (remote_notif_parse): Make "buf" const.
10168         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10169         const.
10170         (remote_notif_parse, remote_notif_ack, handle_notification):
10171         Likewise.
10172         * remote.c (remote_notif_stop_parse): Make "buf" const.
10173         (remote_target::remote_parse_stop_reply): Make "buf" const.
10174         (remote_notif_stop_ack): Make "buf" const.
10175
10176 2019-01-14  Tom Tromey  <tom@tromey.com>
10177
10178         * remote.c (remote_console_output): Make parameter const.
10179
10180 2019-01-14  Tom Tromey  <tom@tromey.com>
10181
10182         * target-debug.h (target_debug_print_signals): Constify.
10183         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10184         * procfs.c (procfs_target::pass_signals): Update.
10185         * linux-nat.c (linux_nat_target::pass_signals): Update.
10186         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10187         * target-delegates.c: Rebuild.
10188         * remote.c (remote_target::program_signals): Update.
10189         (remote_target::pass_signals): Update.
10190         * target.c (target_pass_signals): Constify argument.
10191         (target_program_signals): Likewise.
10192         * target.h (struct target_ops) <pass_signals, program_signals>:
10193         Constify argument.
10194         (target_pass_signals, target_program_signals): Constify argument.
10195
10196 2019-01-14  Tom Tromey  <tom@tromey.com>
10197
10198         PR tui/28819:
10199         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10200
10201 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10202
10203         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10204         field.
10205         * rs6000-tdep.c: Include reggroups.h.
10206         (IS_V_ALIAS_PSEUDOREG): Define.
10207         (rs6000_register_name): Return names for the "vX" aliases.
10208         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10209         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10210         aliases.  Call default_register_reggroup_p for all other
10211         pseudo-registers.
10212         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10213         New functions.
10214         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10215         Handle "vX" aliases.
10216         (v_alias_pseudo_register_collect): New function.
10217         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10218         (rs6000_gdbarch_init): Initialize "vX" aliases as
10219         pseudo-registers.  Restore registration of
10220         rs6000_pseudo_register_reggroup_p with
10221         set_tdesc_pseudo_register_reggroup_p.
10222
10223 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10224
10225         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10226         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10227         set_gdbarch_num_pseudo_regs.
10228
10229 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10230
10231         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10232         Remove arg prefixname, add do_set and do_show.
10233         Add member functions set_list and show_list.
10234         * cli/cli-style.c (class cli_style_option): Update accordingly.
10235         (style_set_list): Move to file scope.
10236         (style_show_list): Likewise.
10237         (set_style): Call help_list.
10238         (show_style): Call cmd_show_list.
10239         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10240         Update to use the new macro.
10241
10242 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10243
10244         * ada-lang.c (_initialize_ada_language): Expand the help text
10245         for the "catch exception" command.
10246
10247 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10248
10249         * symtab.c (matching_obj_sections): Initialize obj,
10250         declare it closer to its usage.
10251
10252 2019-01-10  Tom Tromey  <tom@tromey.com>
10253
10254         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10255         (basic_inf_threads_range): Remove.
10256         (inf_threads_range, inf_non_exited_threads_range)
10257         (safe_inf_threads_range): Use next_adapter.
10258
10259 2019-01-10  Keith Seitz  <keiths@redhat.com>
10260
10261         PR gdb/23712
10262         PR symtab/23010
10263         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10264         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10265
10266 2019-01-10  Keith Seitz  <keiths@redhat.com>
10267
10268         PR gdb/23712
10269         PR symtab/23010
10270         * dictionary.c (pending_to_vector): Remove.
10271         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10272         Remove _1 suffix, replacing functions of the same name.  Update
10273         all callers.
10274         (dict_create_hashed, dict_create_hashed_expandable)
10275         (dict_create_linear, dict_create_linear_expandable, dict_free)
10276         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10277         Make functions static.
10278
10279 2019-01-10  Keith Seitz  <keiths@redhat.com>
10280
10281         PR gdb/23712
10282         PR symtab/23010
10283         * dictionary.h (struct dictionary): Replace declaration with
10284         multidictionary.
10285         (dict_create_hashed, dict_create_hashed_expandable)
10286         (dict_create_linear, dict_create_linear_expandable)
10287         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10288         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10289         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10290         taking multidictionary argument.
10291         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10292         * block.h (struct block) <dict>: Change to multidictionary
10293         and rename `multidict'.
10294         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10295         symmisc.c: Update all dictionary references to multidictionary.
10296
10297 2019-01-10  Keith Seitz  <keiths@redhat.com>
10298
10299         PR gdb/23712
10300         PR symtab/23010
10301         * dictionary.c: Include unordered_map.
10302         (pending_to_vector): New function.
10303         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10304         Rewrite the non-"_1" functions to take vector instead
10305         of linked list.
10306         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10307         "new" _1 versions of the same name.
10308         (multidictionary): Define.
10309         (std::hash<enum language): New definition.
10310         (collate_pending_symbols_by_language, mdict_create_hashed)
10311         (mdict_create_hashed_expandable, mdict_create_linear)
10312         (mdict_create_linear_expandable, mdict_free)
10313         (find_language_dictionary, create_new_language_dictionary)
10314         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10315         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10316         (mdict_size, mdict_empty): New functions.
10317         * dictionary.h (mdict_iterator): Define.
10318
10319 2019-01-10  Pedro Alves  <palves@redhat.com>
10320
10321         * breakpoint.c (read_uploaded_action)
10322         (create_tracepoint_from_upload): Adjust to use
10323         gdb::unique_xmalloc_ptr.
10324         * ctf.c (ctf_write_uploaded_tp):
10325         (SET_ARRAY_FIELD): Use emplace_back.
10326         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10327         * tracefile-tfile.c (tfile_write_uploaded_tp):
10328         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10329         gdb::unique_xmalloc_ptr.
10330         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10331         at_string, cond_string, cmd_strings>: Replace char pointers
10332         with gdb::unique_xmalloc_ptr.
10333
10334 2019-01-10  Pedro Alves  <palves@redhat.com>
10335
10336         * solib-target.c (library_list_start_library): Don't xstrdup name.
10337
10338 2019-01-10  Pedro Alves  <palves@redhat.com>
10339
10340         * mdebugread.c (parse_partial_symbols): Use
10341         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10342
10343 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10344
10345         * linux-fork.c (scoped_switch_fork_info)
10346         <~scoped_switch_fork_info>: Fix incorrect variable name.
10347
10348 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10349
10350         * linux-fork.c (scoped_switch_fork_info)
10351         <scoped_switch_fork_info>: Make explicit.
10352         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10353
10354 2019-01-10  Tom Tromey  <tom@tromey.com>
10355
10356         * objfiles.h (objfile::reset_psymtabs): Update.
10357         * objfiles.c (objfile::objfile): Update.
10358         * psymtab.h (psymtab_storage::obstack): Update.
10359         (psymtab_storage::m_obstack): Use gdb::optional.
10360         (class psymtab_storage): Update comment.  Remove objfile
10361         parameter.
10362         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10363
10364 2019-01-10  Tom Tromey  <tom@tromey.com>
10365
10366         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10367         <free_psymtabs>: Now private.
10368         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10369         (allocate_psymtab): Use new method.
10370
10371 2019-01-10  Tom Tromey  <tom@tromey.com>
10372
10373         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10374         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10375         * mdebugread.c (parse_partial_symbols): Use
10376         allocate_dependencies.
10377         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10378         allocate_dependencies.
10379         (process_psymtab_comp_unit_reader)
10380         (build_type_psymtab_dependencies): Likewise.
10381         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10382
10383 2019-01-10  Tom Tromey  <tom@tromey.com>
10384
10385         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10386         PSYMBOL_SET_LANGUAGE.
10387         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10388
10389 2019-01-10  Tom Tromey  <tom@tromey.com>
10390
10391         * psymtab.h (psymtab_storage::obstack): New method.
10392         <m_obstack>: Rename from obstack; now private.
10393         * psymtab.c (psymtab_storage): Update.
10394         * dwarf2read.c (create_addrmap_from_index)
10395         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10396         Update.
10397
10398 2019-01-10  Tom Tromey  <tom@tromey.com>
10399
10400         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10401         * objfiles.h (objfile::reset_psymtabs): New method.
10402
10403 2019-01-10  Tom Tromey  <tom@tromey.com>
10404
10405         * symmisc.c (print_symbol_bcache_statistics): Update.
10406         (print_objfile_statistics): Update.
10407         * symfile.c (reread_symbols): Update.
10408         * psymtab.h (class psymtab_storage): New.
10409         * psymtab.c (psymtab_storage): New constructor.
10410         (~psymtab_storage): New destructor.
10411         (require_partial_symbols): Update.
10412         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10413         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10414         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10415         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10416         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10417         (start_psymtab_common, end_psymtab_common)
10418         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10419         (allocate_psymtab): Update.
10420         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10421         Update.
10422         (dump_psymtab_addrmap, maintenance_print_psymbols)
10423         (maintenance_check_psymtabs): Update.
10424         (class objfile_psymtabs): Move to objfiles.h.
10425         * psympriv.h (discard_psymtab): Now inline.
10426         (psymtab_discarder::psymtab_discarder): Update.
10427         (psymtab_discarder::~psymtab_discarder): Update.
10428         (ALL_OBJFILE_PSYMTABS): Rewrite.
10429         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10430         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10431         Remove fields.
10432         <partial_symtabs>: New field.
10433         (class objfile_psymtabs): Move from psymtab.h.  Update.
10434         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10435         psymbol_cache.
10436         (objfile::~objfile): Don't destroy psymbol_cache.
10437         * mdebugread.c (parse_partial_symbols): Update.
10438         * dwarf2read.c (create_addrmap_from_index)
10439         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10440         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10441         (add_partial_subprogram, dwarf2_ranges_read): Update.
10442         * dwarf-index-write.c (write_address_map)
10443         (write_one_signatured_type, recursively_write_psymbols)
10444         (class debug_names, class debug_names, write_psymtabs_to_index):
10445         Update.
10446
10447 2019-01-10  Tom Tromey  <tom@tromey.com>
10448
10449         * symtab.h (SYMBOL_SET_NAMES): Update.
10450         (symbol_set_names): Update.
10451         (MSYMBOL_SET_NAMES): Update.
10452         * symtab.c (symbol_set_names): Change argument to be an
10453         objfile_per_bfd_storage.
10454         * psymtab.c (add_psymbol_to_bcache): Update.
10455         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10456
10457 2019-01-10  Tom Tromey  <tom@tromey.com>
10458
10459         * symtab.c (create_demangled_names_hash): Change argument to be an
10460         objfile_per_bfd_storage.
10461         (symbol_set_names): Update.
10462
10463 2019-01-10  Tom Tromey  <tom@tromey.com>
10464
10465         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10466         init_psymbol_list.
10467         * psymtab.c (init_psymbol_list): Do nothing if already called.
10468         * psympriv.h (init_psymbol_list): Add comment.
10469         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10470         init_psymbol_list.
10471         * dbxread.c (dbx_symfile_read): Unconditionally call
10472         init_psymbol_list.
10473
10474 2019-01-10  Tom Tromey  <tom@tromey.com>
10475
10476         * xcoffread.c (scan_xcoff_symtab): Update.
10477         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10478         "where".
10479         * mdebugread.c (parse_partial_symbols)
10480         (handle_psymbol_enumerators): Update.
10481         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10482         * dbxread.c (read_dbx_symtab): Update.
10483         * psympriv.h (psymbol_placement): New enum.
10484         (add_psymbol_to_list): Update.
10485
10486 2019-01-10  Tom Tromey  <tom@tromey.com>
10487
10488         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10489         static_psymbols parameters.
10490         (scan_xcoff_symtab): Update.
10491         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10492         static_psymbols parameters.
10493         * psympriv.h (start_psymtab_common): Update.
10494         * mdebugread.c (parse_partial_symbols): Update.
10495         * dwarf2read.c (create_partial_symtab): Update.
10496         * dbxread.c (read_dbx_symtab): Update.
10497         (start_psymtab): Remove global_psymbols and static_psymbols
10498         parameters.
10499
10500 2019-01-10  Tom Tromey  <tom@tromey.com>
10501
10502         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10503         * psymtab.c (allocate_psymtab): Add comment.
10504         * psympriv.h (allocate_psymtab): Add comment.
10505         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10506         initializations.
10507         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10508
10509 2019-01-10  Tom Tromey  <tom@tromey.com>
10510
10511         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10512         Don't declare.
10513         * mipsread.c: Include mdebugread.h.
10514         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10515         Declare.
10516         * elfread.c: Include mdebugread.h.
10517
10518 2019-01-09  Tom Tromey  <tom@tromey.com>
10519
10520         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10521         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10522         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10523         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10524         (psym_lookup_symbol, psym_find_last_source_symtab)
10525         (psym_forget_cached_source_info, psym_print_stats)
10526         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10527         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10528         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10529         (psym_find_compunit_symtab_by_address)
10530         (maintenance_print_psymbols, maintenance_info_psymtabs)
10531         (maintenance_check_psymtabs): Use ranged for.
10532         * psymtab.h (class objfile_psymtabs): New.
10533         (require_partial_symbols): Return objfile_psymtabs.
10534         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10535
10536 2019-01-09  Tom Tromey  <tom@tromey.com>
10537
10538         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10539         (find_pc_mapped_section, list_overlays_command)
10540         (map_overlay_command, unmap_overlay_command)
10541         (simple_overlay_update): Use all_objfiles.
10542         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10543         * printcmd.c (info_symbol_command): Use all_objfiles.
10544         * objfiles.h (ALL_OBJSECTIONS): Remove.
10545         * maint.c (maintenance_translate_address): Use all_objfiles.
10546         * gcore.c (gcore_create_callback): Use all_objfiles.
10547         (objfile_find_memory_regions): Likewise.
10548
10549 2019-01-09  Tom Tromey  <tom@tromey.com>
10550
10551         * symtab.c (find_line_symtab, info_sources_command)
10552         (make_source_files_completion_list): Use objfile_compunits.
10553         * source.c (select_source_symtab): Use objfile_compunits.
10554         * objfiles.h (struct objfile): Update comment.
10555         (ALL_OBJFILES): Remove.
10556         (ALL_FILETABS): Remove.
10557         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10558         objfile_compunits.
10559
10560 2019-01-09  Tom Tromey  <tom@tromey.com>
10561
10562         * symmisc.c (print_objfile_statistics, dump_objfile)
10563         (maintenance_print_symbols): Use compunit_filetabs.
10564         * source.c (forget_cached_source_info_for_objfile): Use
10565         compunit_filetabs.
10566         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10567         (ALL_FILETABS): Use compunit_filetabs.
10568         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10569         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10570
10571 2019-01-09  Tom Tromey  <tom@tromey.com>
10572
10573         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10574         (compunit_filetabs): New.
10575         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10576         compunit_filetabs.
10577         (info_sources_command, make_source_files_completion_list): Remove
10578         declaration.
10579         * symmisc.c (print_objfile_statistics, dump_objfile)
10580         (maintenance_print_symbols): Remove declaration.
10581         (maintenance_info_symtabs): Use compunit_filetabs.
10582         (maintenance_info_line_tables): Likewise.
10583         * source.c (select_source_symtab): Change local variable name.
10584         (forget_cached_source_info_for_objfile): Remove declaration.
10585         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10586         * objfiles.c (objfile_relocate1): Remove declaration.
10587         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10588         declaration.
10589         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10590         * coffread.c (coff_symtab_read): Remove declaration.
10591         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10592         compunit_filetabs.
10593
10594 2019-01-09  Tom Tromey  <tom@tromey.com>
10595
10596         * symtab.c (lookup_objfile_from_block)
10597         (find_pc_sect_compunit_symtab, search_symbols)
10598         (default_collect_symbol_completion_matches_break_on): Use
10599         objfile_compunits.
10600         * objfiles.h (ALL_COMPUNITS): Remove.
10601         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10602         * cp-support.c (add_symbol_overload_list_qualified): Use
10603         objfile_compunits.
10604         * ada-lang.c (ada_collect_symbol_completion_matches)
10605         (ada_add_global_exceptions): Use objfile_compunits.
10606
10607 2019-01-09  Tom Tromey  <tom@tromey.com>
10608
10609         * source.c (select_source_symtab)
10610         (forget_cached_source_info_for_objfile): Remove declaration.
10611         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10612         declaration.
10613         * maint.c (count_symtabs_and_blocks): Remove declaration.
10614         * cp-support.c (add_symbol_overload_list_qualified): Remove
10615         declaration.
10616         * coffread.c (coff_symtab_read): Remove declaration.
10617         * symtab.c (lookup_symbol_in_objfile_symtabs)
10618         (basic_lookup_transparent_type_1): Use objfile_compunits.
10619         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10620         (info_sources_command, search_symbols)
10621         (default_collect_symbol_completion_matches_break_on)
10622         (make_source_files_completion_list): Remove declaration.
10623         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10624         (ada_collect_symbol_completion_matches)
10625         (ada_add_global_exceptions): Remove declaration.
10626         * linespec.c (iterate_over_all_matching_symtabs): Use
10627         objfile_compunits.
10628         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10629         (class objfile_compunits): New.
10630         (ALL_COMPUNITS): Use objfile_compunits.
10631         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10632         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10633         objfile_compunits.
10634         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10635
10636 2019-01-09  Tom Tromey  <tom@tromey.com>
10637
10638         * symtab.c (search_symbols)
10639         (default_collect_symbol_completion_matches_break_on): Use
10640         objfile_msymbols.
10641         * ada-lang.c (ada_lookup_simple_minsym)
10642         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10643         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10644         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10645         objfile_msymbols.
10646         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10647         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10648         * objc-lang.c (find_methods): Use objfile_msymbols.
10649         (info_selectors_command, info_classes_command): Likewise.
10650         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10651         * objfiles.h (class objfile_msymbols): New.
10652         (ALL_OBJFILE_MSYMBOLS): Remove.
10653         (ALL_MSYMBOLS): Remove.
10654
10655 2019-01-09  Tom Tromey  <tom@tromey.com>
10656
10657         * common/next-iterator.h (next_adapter): Add Iterator template
10658         parameter.
10659         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10660         (class all_objfiles_safe): New.
10661         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10662         * objfiles.c (put_objfile_before): Update comment.
10663         (add_separate_debug_objfile): Likewise.
10664         (free_all_objfiles): Use all_objfiles_safe.
10665         (objfile_purge_solibs): Likewise.
10666
10667 2019-01-09  Tom Tromey  <tom@tromey.com>
10668
10669         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10670         (expand_symtab_containing_pc, lookup_static_symbol)
10671         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10672         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10673         all_objfiles.
10674         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10675         * breakpoint.c (create_overlay_event_breakpoint)
10676         (create_longjmp_master_breakpoint)
10677         (create_std_terminate_master_breakpoint)
10678         (create_exception_master_breakpoint): Use all_objfiles.
10679         * linux-thread-db.c (try_thread_db_load_from_pdir)
10680         (has_libpthread): Use all_objfiles.
10681         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10682         * linespec.c (iterate_over_all_matching_symtabs)
10683         (search_minsyms_for_name): Use all_objfiles.
10684         * maint.c (maintenance_info_sections): Use all_objfiles.
10685         * main.c (captured_main_1): Use all_objfiles.
10686         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10687         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10688         * guile/scm-pretty-print.c
10689         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10690         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10691         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10692         (maintenance_print_msymbols): Use all_objfiles.
10693         * source.c (select_source_symtab): Use all_objfiles.
10694         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10695         * symfile.c (remove_symbol_file_command)
10696         (expand_symtabs_matching, map_symbol_filenames): Use
10697         all_objfiles.
10698         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10699         all_objfiles.
10700         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10701         * objc-lang.c (find_methods): Use all_objfiles.
10702         * objfiles.c (have_partial_symbols, have_full_symbols)
10703         (have_minimal_symbols, qsort_cmp)
10704         (default_iterate_over_objfiles_in_search_order): Use
10705         all_objfiles.
10706         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10707         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10708         (maintenance_check_psymtabs): Use all_objfiles.
10709         (ALL_PSYMTABS): Remove.
10710         * compile/compile-object-run.c (do_module_cleanup): Use
10711         all_objfiles.
10712         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10713         * cp-support.c (add_symbol_overload_list_qualified): Use
10714         all_objfiles.
10715         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10716         Use all_objfiles.
10717         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10718         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10719         all_objfiles.
10720         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10721         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10722         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10723         Uses all_objfiles.
10724         * solib.c (solib_read_symbols): Use all_objfiles
10725
10726 2019-01-09  Tom Tromey  <tom@tromey.com>
10727
10728         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10729         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10730         all_objfiles.
10731         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10732         * symmisc.c (print_symbol_bcache_statistics)
10733         (print_objfile_statistics, maintenance_print_objfiles)
10734         (maintenance_info_symtabs, maintenance_check_symtabs)
10735         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10736         all_objfiles.
10737         * source.c (forget_cached_source_info): Use all_objfiles.
10738         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10739         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10740         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10741         * objfiles.c (update_section_map): Use all_objfiles.
10742         (shared_objfile_contains_address_p): Likewise.
10743         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10744         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10745
10746 2019-01-09  Tom Tromey  <tom@tromey.com>
10747
10748         * common/next-iterator.h: New file.
10749         * objfiles.h (class all_objfiles): New.
10750         (struct objfile_iterator): New.
10751
10752 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10753
10754         * NEWS: Move the description of the changed "frame", "select-frame",
10755          and "info frame" commands to the Changed commands section.
10756
10757 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10758
10759         * gdbtypes.c (check_stub_method_group): Remove handling of old
10760         mangling schemes.
10761         * linespec.c (find_methods): Likewise.
10762         * stabsread.c (read_member_functions): Likewise.
10763         * valops.c (search_struct_method): Likewise.
10764         (value_struct_elt_for_reference): Likewise.
10765         * NEWS: Mention this change.
10766
10767 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10768
10769         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10770         print_source_lines.
10771         * source.c (print_source_lines_base): Update line number check.
10772         (print_source_lines): New function.
10773         (source_lines_range::source_lines_range): New function.
10774         * source.h (class source_lines_range): New class.
10775         (print_source_lines): New declaration.
10776
10777 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10778
10779         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10780
10781 2019-01-08  Tom Tromey  <tom@tromey.com>
10782             Simon Marchi  <simon.marchi@ericsson.com>
10783
10784         PR gdb/24060
10785         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10786         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10787         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10788         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10789         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10790         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10791
10792 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10793
10794         * source.c (select_source_symtab): Move header comment to
10795         declaration in source.h.
10796         (forget_cached_source_info_for_objfile): Likewise.
10797         (forget_cached_source_info): Likewise.
10798         (identify_source_line): Likewise.
10799         * source.h (identify_source_line): Move declaration from symtab.h
10800         and add comment from source.c
10801         (print_source_lines): Likewise.
10802         (forget_cached_source_info_for_objfile): Likewise.
10803         (forget_cached_source_info): Likewise.
10804         (select_source_symtab): Likewise.
10805         (enum print_source_lines_flag): Move definition from symtab.h.
10806         * symtab.h (identify_source_line): Move declaration to source.h.
10807         (print_source_lines): Likewise.
10808         (forget_cached_source_info_for_objfile): Likewise.
10809         (forget_cached_source_info): Likewise.
10810         (select_source_symtab): Likewise.
10811         (enum print_source_lines_flag): Move definition to source.h.
10812         * tui/tui-hooks.c: Add 'source.h' include.
10813
10814 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10815
10816         * source.c (print_source_lines_base): Handle requests to print
10817         reverse line number sequences, and guard against empty lines
10818         string.
10819
10820 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10821
10822         * source.c (print_source_lines_base): Fix skip of '\r' if next
10823         character is '\n'.
10824
10825 2019-01-06  Tom Tromey  <tom@tromey.com>
10826
10827         * c-exp.y (struct c_parse_state) <macro_original_text,
10828         expansion_obstack>: New member.
10829         (macro_original_text, expansion_obstack): Remove globals.
10830         (scan_macro_expansion, scanning_macro_expansion)
10831         (finished_macro_expansion): Update.
10832         (scan_macro_cleanup): Remove.
10833         (yylex, c_parse): Update.
10834
10835 2019-01-06  Tom Tromey  <tom@tromey.com>
10836
10837         * c-exp.y (struct c_parse_state) <strings>: New member.
10838         (operator_stoken): Update.
10839
10840 2019-01-06  Tom Tromey  <tom@tromey.com>
10841
10842         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10843         (union type_stack_elt) <typelist_val>: Now a pointer to
10844         std::vector.
10845         (type_stack_cleanup): Don't declare.
10846         (push_typelist): Update.
10847         * parse.c (pop_typelist): Return a std::vector.
10848         (push_typelist): Take a std::vector.
10849         (follow_types): Update.  Do not free args.
10850         (type_stack_cleanup): Remove.
10851         * c-exp.y (struct c_parse_state): New.
10852         (cpstate): New global.
10853         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10854         (nonempty_typelist): Update.
10855         (func_mod): Create a new vector.
10856         (c_parse): Create a c_parse_state.
10857         (check_parameter_typelist): Do not delete params.
10858         (function_method): Update.  Do not delete type_list.
10859
10860 2019-01-06  Tom Tromey  <tom@tromey.com>
10861
10862         PR gdb/28155:
10863         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10864         check_typedef.
10865         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10866         (print_return_value): Likewise.
10867
10868 2019-01-05  Tom Tromey  <tom@tromey.com>
10869
10870         * contrib/cleanup_check.py: Remove.
10871         * contrib/gcc-with-excheck: Remove.
10872         * contrib/exsummary.py: Remove.
10873         * contrib/excheck.py: Remove.
10874
10875 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10876
10877         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10878         NULL. Initialize tpprev to NULL instead of assigning it
10879         to NULL on the next statement.
10880         * windows-nat.c (windows_delete_thread): Remove check for
10881         main_thread_id before printing thread exit notifications.
10882         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10883         Remove thread ID check against main_thread_id.
10884         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10885         windows_delete_thread.
10886         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10887
10888 2019-01-04  Tom Tromey  <tom@tromey.com>
10889
10890         * compile/compile.c (_initialize_compile): Use upper case for
10891         metasyntactic variables.
10892         * symmisc.c (_initialize_symmisc): Use upper case for
10893         metasyntactic variables.
10894         * psymtab.c (_initialize_psymtab): Use upper case for
10895         metasyntactic variables.
10896         * demangle.c (demangle_command): Use upper case for metasyntactic
10897         variables.
10898         (_initialize_demangler): Likewise.
10899         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10900         variables.
10901
10902 2019-01-03  Tom Tromey  <tom@tromey.com>
10903
10904         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10905
10906 2019-01-03  Tom Tromey  <tom@tromey.com>
10907
10908         * python/py-symtab.c (salpy_str): Update.
10909         (struct salpy_sal_object) <symtab>: Now a PyObject.
10910         (salpy_dealloc): Update.
10911         (del_objfile_sal): Use gdbpy_ref.
10912
10913 2019-01-03  Tom Tromey  <tom@tromey.com>
10914
10915         * python/py-type.c (convert_field): Use new_reference.  Return
10916         gdbpy_ref.
10917         (make_fielditem): Return gdbpy_ref.
10918         (typy_fields): Update.
10919         (typy_getitem): Update.
10920         (field_name): Return gdbpy_ref.  Use new_reference.
10921         (typy_iterator_iternext): Update.
10922
10923 2019-01-03  Tom Tromey  <tom@tromey.com>
10924
10925         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10926
10927 2019-01-03  Tom Tromey  <tom@tromey.com>
10928
10929         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10930         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10931         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10932         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10933         (pspy_set_type_printers): Likewise.
10934         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10935         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10936         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10937         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10938         (objfpy_set_type_printers): Likewise.
10939
10940 2019-01-03  Tom Tromey  <tom@tromey.com>
10941
10942         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10943         (gdbpy_print_stack): Use gdbpy_err_fetch.
10944         * python/python-internal.h (class gdbpy_err_fetch): New class.
10945         (class gdbpy_enter) <m_error_type, m_error_value,
10946         m_error_traceback>: Remove.
10947         <m_error>: New member.
10948         (gdbpy_exception_to_string): Don't declare.
10949         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10950         * python/py-value.c (convert_value_from_python): Use
10951         gdbpy_err_fetch.
10952         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10953         gdbpy_exception_to_string.
10954         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10955         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10956         gdbpy_err_fetch.
10957
10958 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10959
10960         * linux-nat.c (delete_lwp_cleanup): Delete.
10961         (struct lwp_deleter): New struct.
10962         (lwp_info_up): New typedef.
10963         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10964         lwp_info_up.
10965
10966 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10967
10968         * linux-fork.c (class scoped_switch_fork_info): New class.
10969         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10970
10971 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10972
10973         * valops.c (find_overload_match): Remove use of null_cleanup, and
10974         calls to do_cleanups.
10975
10976 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10977
10978         * compile/compile-cplus-types.c
10979         (compile_cplus_instance::decl_name): Handle changes to
10980         cp_func_name.
10981         * cp-support.c (cp_func_name): Update header comment, update
10982         return type.
10983         * cp-support.h (cp_func_name): Update return type in declaration.
10984         * valops.c (find_overload_match): Move temp_func local to top
10985         level of function and change its type.  Use temp_func to hold and
10986         delete temporary string obtained from cp_func_name.
10987
10988 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10989
10990         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10991         gdb::char_vector, remove cleanup, and update uses of `msg`.
10992
10993 2019-01-03  Jim Wilson  <jimw@sifive.com>
10994
10995         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10996
10997 2019-01-02  Tom Tromey  <tom@tromey.com>
10998
10999         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11000         (tdesc_parse_xml): Remove cleanups.
11001         * target-descriptions.h (make_cleanup_free_target_description):
11002         Don't declare.
11003         (target_desc_deleter): New struct.
11004         (target_desc_up): New typedef.
11005         * target-descriptions.c (target_desc_deleter::operator()): Rename
11006         from free_target_description.
11007         (make_cleanup_free_target_description): Remove.
11008
11009 2019-01-02  Tom Tromey  <tom@tromey.com>
11010
11011         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11012         constructor, destructor.
11013         (linespec_parser): Remove typedef.
11014         (~linespec_parser): Rename from linespec_parser_delete.
11015         (linespec_lex_to_end, linespec_complete_label)
11016         (linespec_complete): Update.
11017         (decode_line_full): Remove cleanups.
11018         (decode_line_1): Update.
11019
11020 2019-01-02  Tom Tromey  <tom@tromey.com>
11021
11022         * python/python-internal.h (inferior_to_inferior_object): Change
11023         return type.
11024         * python/py-exitedevent.c (create_exited_event_object): Update.
11025         * python/py-inferior.c (inferior_to_inferior_object): Return
11026         gdbpy_ref.
11027         (python_new_inferior, python_inferior_deleted)
11028         (thread_to_thread_object, delete_thread_object)
11029         (build_inferior_list, gdbpy_selected_inferior): Update.
11030         * python/py-infthread.c (create_thread_object): Update.  Also fail
11031         if inferior_to_inferior_object fails.
11032
11033 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11034
11035         * inferior.h (class inferior) <displaced_step_state>: New field.
11036         * infrun.h (struct displaced_step_state): Move here from
11037         infrun.c.  Initialize fields, add constructor.
11038         <inf>: Remove field.
11039         <reset>: New method.
11040         * infrun.c (struct displaced_step_inferior_state): Move to
11041         infrun.h.
11042         (displaced_step_inferior_states): Remove.
11043         (get_displaced_stepping_state): Adust.
11044         (displaced_step_in_progress_any_inferior): Adjust.
11045         (displaced_step_in_progress_thread): Adjust.
11046         (displaced_step_in_progress): Adjust.
11047         (add_displaced_stepping_state): Remove.
11048         (get_displaced_step_closure_by_addr): Adjust.
11049         (remove_displaced_stepping_state): Remove.
11050         (infrun_inferior_exit): Call displaced_step_state.reset.
11051         (use_displaced_stepping): Don't check for NULL.
11052         (displaced_step_prepare_throw): Call
11053         get_displaced_stepping_state.
11054         (displaced_step_fixup): Don't check for NULL.
11055         (prepare_for_detach): Don't check for NULL.
11056
11057 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11058
11059         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11060          in case of call that did not complete.
11061
11062 2019-01-02  Andrey Utkin  <autkin@undo.io>
11063
11064         * symfile.c (find_separate_debug_file): Fix search of debug files for
11065         remote debuggee.
11066
11067 2019-01-02  Tom Tromey  <tom@tromey.com>
11068
11069         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11070         indentation.
11071         * python/py-frame.c (frapy_older): Remove cast.
11072         (frapy_newer): Likewise.
11073         * python/py-breakpoint.c (local_setattro): Remove cast.
11074         * python/py-arch.c (archpy_name): Remove local variable.
11075         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11076
11077 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11078
11079         * unittests/basic_string_view/element_access/char/empty.cc:
11080         Fix year range in copyright header.
11081
11082 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11083
11084         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11085         Delete.
11086         <operator==>: Update with for removed field.
11087         <hash>: Likewise.
11088         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11089         <isa_features>: ...this.
11090         <abi_features>: New field.
11091         (riscv_isa_flen): Update comment.
11092         (riscv_abi_xlen): New declaration.
11093         (riscv_abi_flen): New declaration.
11094         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11095         isa_features.
11096         (riscv_abi_xlen): New function.
11097         (riscv_isa_flen): Update to get answer from isa_features.
11098         (riscv_abi_flen): New function.
11099         (riscv_has_fp_abi): Update to get answer from abi_features.
11100         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11101         xlen and flen.
11102         (riscv_call_info) <xlen, flen>: Update comment.
11103         (riscv_call_arg_struct): Remove invalid assertions
11104         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11105         is removed.
11106         (riscv_gdbarch_init): Gather isa features and abi features
11107         separately, ensure both match on the gdbarch when reusing an old
11108         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11109         a target with 64-bit float hardware.
11110
11111 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11112
11113         * source.c (search_command_helper): Stop reverse search
11114         when line 1 has been searched.
11115
11116 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11117
11118         * record-full.c (record_full_base_target::close): Rewrite
11119         record_full_core_buf_list free logic.
11120
11121 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11122
11123         * break-catch-syscall.c (print_one_catch_syscall): xfree
11124         the last text.
11125
11126 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11127
11128         * top.c (print_gdb_version): Update Copyright year in version
11129         message.
11130
11131 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11132
11133         Update copyright year range in all GDB files.
11134
11135 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11136
11137         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11138
11139 For older changes see ChangeLog-2018.
11140 \f
11141 Local Variables:
11142 mode: change-log
11143 left-margin: 8
11144 fill-column: 74
11145 version-control: never
11146 coding: utf-8
11147 End:
11148