gdb/ChangeLog

   1 2019-03-15  Tom Tromey  <tom@tromey.com>
   2
   3         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
   4         Don't return the symbol.
   5         * coffread.c (record_minimal_symbol): Use record_full.
   6
   7 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
   8
   9         The MS-Windows port of ncurses fails to switch to a color pair if
  10         one or both of the colors are the implicit default colors.  This
  11         change records the default colors when TUI is initialized, and
  12         then specifies them explicitly when a color pair uses the default
  13         colors.  This allows color styling in TUI mode on MS-Windows.
  14
  15         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  16         ncurses_norm_attr.
  17         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  18         colors in ncurses_norm_attr.
  19         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  20         "none", replace it with the default color recorded in
  21         ncurses_norm_attr.
  22
  23 2019-03-14  Tom Tromey  <tromey@adacore.com>
  24
  25         * source-cache.h (class source_cache) <get_source_lines>: Return
  26         std::string.
  27         * source-cache.c (source_cache::extract_lines): Handle case where
  28         first_pos==npos.  Return std::string.
  29         (source_cache::get_source_lines): Update.
  30
  31 2019-03-14  Tom Tromey  <tromey@adacore.com>
  32
  33         * NEWS: Add item for "style sources" commands.
  34         * source-cache.c (source_cache::get_source_lines): Check
  35         source_styling.
  36         * cli/cli-style.c (source_styling): New global.
  37         (_initialize_cli_style): Add "style sources" commands.
  38         (show_style_sources): New function.
  39         * cli/cli-style.h (source_styling): Declare.
  40
  41 2019-03-14  Pedro Alves  <palves@redhat.com>
  42             Tom Tromey  <tromey@adacore.com>
  43
  44         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  45         * tui/tui-winsource.c (tui_refill_source_window): New function,
  46         from...
  47         (tui_horizontal_source_scroll): ... here.  Move some logic.
  48         * cli/cli-style.c (set_style_enabled): Notify new observable.
  49         * tui/tui-hooks.c (tui_redisplay_source): New function.
  50         (tui_attach_detach_observers): Attach or detach
  51         tui_redisplay_source.
  52         * observable.h (source_styling_changed): New observable.
  53         * observable.c: Define source_styling_changed observable.
  54
  55 2019-03-13  Tom Tromey  <tromey@adacore.com>
  56
  57         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
  58         (i386_gnu_nat_target::store_registers): Update.
  59         * target-debug.h (target_debug_print_std_string): New macro.
  60         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
  61         * windows-tdep.c (display_one_tib): Update.
  62         * tui/tui-stack.c (tui_make_status_line): Update.
  63         * top.c (print_inferior_quit_action): Update.
  64         * thread.c (thr_try_catch_cmd): Update.
  65         (add_thread_with_info): Update.
  66         (thread_target_id_str): Update.
  67         (thr_try_catch_cmd): Update.
  68         (thread_command): Update.
  69         (thread_find_command): Update.
  70         * record-btrace.c (record_btrace_target::info_record)
  71         (record_btrace_resume_thread, record_btrace_target::resume)
  72         (record_btrace_cancel_resume, record_btrace_step_thread)
  73         (record_btrace_target::wait, record_btrace_target::wait)
  74         (record_btrace_target::wait, record_btrace_target::stop): Update.
  75         * progspace.c (print_program_space): Update.
  76         * process-stratum-target.c
  77         (process_stratum_target::thread_address_space): Update.
  78         * linux-fork.c (linux_fork_mourn_inferior)
  79         (detach_checkpoint_command, info_checkpoints_command)
  80         (linux_fork_context): Update.
  81         (linux_fork_detach): Update.
  82         (class scoped_switch_fork_info): Update.
  83         (delete_checkpoint_command): Update.
  84         * infrun.c (follow_fork_inferior): Update.
  85         (follow_fork_inferior): Update.
  86         (proceed_after_vfork_done): Update.
  87         (handle_vfork_child_exec_or_exit): Update.
  88         (follow_exec): Update.
  89         (displaced_step_prepare_throw): Update.
  90         (displaced_step_restore): Update.
  91         (start_step_over): Update.
  92         (resume_1): Update.
  93         (clear_proceed_status_thread): Update.
  94         (proceed): Update.
  95         (print_target_wait_results): Update.
  96         (do_target_wait): Update.
  97         (context_switch): Update.
  98         (stop_all_threads): Update.
  99         (restart_threads): Update.
 100         (finish_step_over): Update.
 101         (handle_signal_stop): Update.
 102         (switch_back_to_stepped_thread): Update.
 103         (keep_going_pass_signal): Update.
 104         (print_exited_reason): Update.
 105         (normal_stop): Update.
 106         * inferior.c (inferior_pid_to_str): Change return type.
 107         (print_selected_inferior): Update.
 108         (add_inferior): Update.
 109         (detach_inferior): Update.
 110         * dummy-frame.c (fprint_dummy_frames): Update.
 111         * dcache.c (dcache_info_1): Update.
 112         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 113         (btrace_fetch, btrace_clear): Update.
 114         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 115         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 116         type.
 117         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 118         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 119         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 120         * gdbarch.c, gdbarch.h: Rebuild.
 121         * gdbarch.sh (core_pid_to_str): Change return type.
 122         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 123         return type.
 124         (windows_nat_target::pid_to_str): Change return type.
 125         (windows_delete_thread): Update.
 126         (windows_nat_target::attach): Update.
 127         (windows_nat_target::files_info): Update.
 128         * target-delegates.c: Rebuild.
 129         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 130         return type.
 131         (sol_thread_target::pid_to_str): Change return type.
 132         * remote.c (class remote_target) <pid_to_str>: Change return
 133         type.
 134         (remote_target::pid_to_str): Change return type.
 135         (extended_remote_target::attach, remote_target::remote_stop_ns)
 136         (remote_target::remote_notif_remove_queued_reply)
 137         (remote_target::push_stop_reply, remote_target::disable_btrace):
 138         Update.
 139         (extended_remote_target::attach): Update.
 140         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 141         type.
 142         (gdbsim_target::pid_to_str): Change return type.
 143         * ravenscar-thread.c (struct ravenscar_thread_target)
 144         <pid_to_str>: Change return type.
 145         (ravenscar_thread_target::pid_to_str): Change return type.
 146         * procfs.c (class procfs_target) <pid_to_str>: Change return
 147         type.
 148         (procfs_target::pid_to_str): Change return type.
 149         (procfs_target::attach): Update.
 150         (procfs_target::detach): Update.
 151         (procfs_target::fetch_registers): Update.
 152         (procfs_target::store_registers): Update.
 153         (procfs_target::wait): Update.
 154         (procfs_target::files_info): Update.
 155         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 156         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 157         return type.
 158         (nto_procfs_target::pid_to_str): Change return type.
 159         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 160         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 161         return type.
 162         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 163         (exit_lwp): Update.
 164         (attach_proc_task_lwp_callback, get_detach_signal)
 165         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 166         (linux_nat_target::resume, wait_lwp, stop_callback)
 167         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 168         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 169         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 170         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 171         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 172         type.
 173         (inf_ptrace_target::attach): Update.
 174         (inf_ptrace_target::files_info): Update.
 175         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 176         type.
 177         (go32_nat_target::pid_to_str): Change return type.
 178         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 179         (gnu_nat_target::wait): Update.
 180         (gnu_nat_target::wait): Update.
 181         (gnu_nat_target::resume): Update.
 182         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 183         (fbsd_nat_target::wait): Update.
 184         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 185         type.
 186         (darwin_nat_target::attach): Update.
 187         * corelow.c (class core_target) <pid_to_str>: Change return type.
 188         (core_target::pid_to_str): Change return type.
 189         * target.c (normal_pid_to_str): Change return type.
 190         (default_pid_to_str): Likewise.
 191         (target_pid_to_str): Change return type.
 192         (target_translate_tls_address): Update.
 193         (target_announce_detach): Update.
 194         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 195         return type.
 196         (bsd_uthread_target::pid_to_str): Change return type.
 197         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 198         type.
 199         (bsd_kvm_target::pid_to_str): Change return type.
 200         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 201         return type.
 202         (aix_thread_target::pid_to_str): Change return type.
 203         * target.h (struct target_ops) <pid_to_str>: Change return type.
 204         (target_pid_to_str, normal_pid_to_str): Likewise.
 205         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 206         type.
 207         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 208         type.
 209         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 210         return type.
 211         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 212         type.
 213         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 214         type.
 215         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 216         return type.
 217
 218 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 219
 220         * NEWS: Mention that the new default MI version is 3.  Mention
 221         changes to the output of commands and events that deal with
 222         multi-location breakpoints.
 223         * breakpoint.c: Include "mi/mi-out.h".
 224         (print_one_breakpoint): Change output syntax if using MI version
 225         >= 3.
 226         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 227         New.
 228         (mi_multi_location_breakpoint_output_fixed): New.
 229         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 230         (mi_cmd_fix_multi_location_breakpoint_output): New.
 231         (mi_multi_location_breakpoint_output_fixed): New.
 232         * mi/mi-cmds.c (mi_cmds): Register command
 233         -fix-multi-location-breakpoint-output.
 234         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 235         interpreter "mi".
 236
 237 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 238
 239         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 240         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 241         instantiate mi_ui_out based on interpreter name.
 242         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 243         * mi/mi-main.c (mi_load_progress): Likewise.
 244
 245 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 246
 247         * NEWS: Combine separate "New targets" sections for 8.3.
 248
 249 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 250
 251         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 252         (ppcfbsd_init_abi): Install gdbarch
 253         "fetch_tls_load_module_address" and "get_thread_local_address"
 254         methods.
 255
 256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 257
 258         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 259         (riscv_fbsd_init_abi): Install gdbarch
 260         "fetch_tls_load_module_address" and "get_thread_local_address"
 261         methods.
 262
 263 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 264
 265         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 266         (i386fbsd_init_abi): Install gdbarch
 267         "fetch_tls_load_module_address" and "get_thread_local_address"
 268         methods.
 269
 270 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 271
 272         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 273         (amd64fbsd_init_abi): Install gdbarch
 274         "fetch_tls_load_module_address" and "get_thread_local_address"
 275         methods.
 276
 277 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 278
 279         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 280         (struct fbsd_pspace_data): New type.
 281         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 282         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 283         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 284         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 285         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 286
 287 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 288
 289         * gdbtypes.c (lookup_struct_elt): New function.
 290         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 291         * gdbtypes.h (struct struct_elt): New type.
 292         (lookup_struct_elt): New prototype.
 293
 294 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 295
 296         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 297         remove disabled code block.
 298
 299 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 300
 301         * gdbarch.sh (get_thread_local_address): New method.
 302         * gdbarch.h, gdbarch.c: Regenerate.
 303         * target.c (target_translate_tls_address): Use
 304         gdbarch_get_thread_local_address if present instead of
 305         target::get_thread_local_address.
 306
 307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 308
 309         * target.h (target::get_thread_local_address): Update comment.
 310
 311 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 312
 313         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 314         objfile->separate_debug_objfile_backlink if not NULL.
 315
 316 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 317
 318         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 319         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 320         (amd64bsd_store_inferior_registers): Likewise.
 321         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 322         Enable segment base registers.
 323         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 324         PT_GETFSBASE and PT_GETGSBASE.
 325         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 326         PT_SETGSBASE.
 327         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 328         segment base registers.
 329         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 330
 331 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 332
 333         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 334         Update calls to i386_target_description to add 'segments'
 335         parameter.
 336         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 337         add segment base registers.
 338         * arch/i386.c (i386_create_target_description): Add 'segments'
 339         parameter to enable segment base registers.
 340         * arch/i386.h (i386_create_target_description): Likewise.
 341         * features/i386/32bit-segments.xml: New file.
 342         * features/i386/32bit-segments.c: Generate.
 343         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 344         call to i386_target_description to add 'segments' parameter.
 345         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 346         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 347         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 348         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 349         if feature is present.
 350         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 351         Add 'segments' parameter to call to i386_target_description.
 352         (i386_target_description): Add 'segments' parameter to enable
 353         segment base registers.
 354         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 355         to call to i386_target_description.
 356         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 357         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 358         Define I386_NUM_REGS.
 359         (i386_target_description): Add 'segments' parameter to enable
 360         segment base registers.
 361
 362 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 363
 364         PR/24325
 365         * source-cache.c: #undef open and close, to avoid unresolved
 366         externals during linking.
 367
 368 2019-03-12  Tom Tromey  <tromey@adacore.com>
 369
 370         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 371         const.  Add initializers.
 372         (_initialize_remote): Don't initialize ptid globals.
 373
 374 2019-03-12  Pedro Alves  <palves@redhat.com>
 375
 376         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 377
 378 2019-03-12  Pedro Alves  <palves@redhat.com>
 379
 380         * cp-name-parser.y (main): Remove unused 'len' variable.
 381
 382 2019-03-12  Tom Tromey  <tromey@adacore.com>
 383
 384         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 385         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 386
 387 2019-03-12  Tom Tromey  <tromey@adacore.com>
 388
 389         * linux-nat.c (iterate_over_lwps): Update.
 390         (stop_callback): Remove parameter.
 391         (stop_wait_callback, detach_callback, resume_set_callback)
 392         (select_singlestep_lwp_callback, set_ignore_sigint)
 393         (status_callback, resumed_callback, resume_clear_callback)
 394         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 395         data parameter.
 396         (linux_nat_target::detach, linux_nat_target::resume)
 397         (linux_stop_and_wait_all_lwps, select_event_lwp)
 398         (linux_nat_filter_event, linux_nat_wait_1)
 399         (linux_nat_target::kill, linux_nat_target::stop)
 400         (linux_nat_target::stop): Update.
 401         (linux_nat_resume_callback): Change type.
 402         (resume_stopped_resumed_lwps, count_events_callback)
 403         (select_event_lwp_callback): Likewise.
 404         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 405         * arm-linux-nat.c (struct update_registers_data): Remove.
 406         (update_registers_callback): Change type.
 407         (arm_linux_insert_hw_breakpoint1): Update.
 408         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 409         parameter.
 410         (x86_linux_dr_set_addr): Update.
 411         (x86_linux_dr_set_control): Update.
 412         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 413         (iterate_over_lwps): Use gdb::function_view.
 414         * nat/aarch64-linux-hw-point.c (struct
 415         aarch64_dr_update_callback_param): Remove.
 416         (debug_reg_change_callback): Change type.
 417         (aarch64_notify_debug_reg_change): Update.
 418         * s390-linux-nat.c (s390_refresh_per_info): Update.
 419
 420 2019-03-11  Tom Tromey  <tromey@adacore.com>
 421
 422         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 423         redundant assignment to "this_cu".
 424
 425 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 426
 427         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 428
 429 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 430
 431         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 432         from...
 433         (rank_one_type): ... this.
 434
 435 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 436
 437         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 438         from...
 439         (rank_one_type): ... this.
 440
 441 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 442
 443         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 444         from...
 445         (rank_one_type): ... this.
 446
 447 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 448
 449         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 450         from...
 451         (rank_one_type): ... this.
 452
 453 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 454
 455         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 456         from...
 457         (rank_one_type): ... this.
 458
 459 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 460
 461         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 462         from...
 463         (rank_one_type): ... this.
 464
 465 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 466
 467         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 468         from...
 469         (rank_one_type): ... this.
 470
 471 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 472
 473         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 474         from...
 475         (rank_one_type): ... this.
 476
 477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 478
 479         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 480         from...
 481         (rank_one_type): ... this.
 482
 483 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 484
 485         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 486         from...
 487         (rank_one_type): ... this.
 488
 489 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 490
 491         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 492         from...
 493         (rank_one_type): ... this.
 494
 495 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 496
 497         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 498         from...
 499         (rank_one_type): ... this.
 500
 501 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 502
 503         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 504         inferior-events' shows the example events.
 505
 506 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 507
 508         Support styling on native MS-Windows console
 509
 510         PR/24315
 511         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 512         on MS-Windows if $TERM is not defined.
 513
 514         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 515
 516         * posix-hdep.c (gdb_console_fputs):
 517         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 518         functions.
 519         * ui-file.h (gdb_console_fputs): Add prototype.
 520
 521         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 522         back to fputs only if the former returns zero.
 523
 524 2019-03-07  Tom Tromey  <tom@tromey.com>
 525
 526         * symmisc.c (print_symbol_bcache_statistics): Update.
 527         (print_objfile_statistics): Update.
 528         * symfile.c (allocate_symtab): Update.
 529         * stabsread.c: Don't include bcache.h.
 530         * psymtab.h (struct psymbol_bcache): Don't declare.
 531         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 532         (psymbol_bcache_init, psymbol_bcache_free)
 533         (psymbol_bcache_get_bcache): Don't declare.
 534         * psymtab.c (struct psymbol_bcache): Remove.
 535         (psymtab_storage::psymtab_storage): Update.
 536         (psymtab_storage::~psymtab_storage): Update.
 537         (psymbol_bcache_init, psymbol_bcache_free)
 538         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 539         (add_psymbol_to_bcache): Update.
 540         (allocate_psymtab): Update.
 541         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 542         macro_cache>: No longer pointers.
 543         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 544         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 545         * macrotab.c (macro_bcache): Update.
 546         * macroexp.c: Don't include bcache.h.
 547         * gdbtypes.c (check_types_worklist): Update.
 548         (types_deeply_equal): Remove TRY/CATCH.  Update.
 549         * elfread.c (elf_symtab_read): Update.
 550         * dwarf2read.c: Don't include bcache.h.
 551         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 552         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 553         (print_bcache_statistics, bcache_memory_used): Don't declare.
 554         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 555         methods.  Rename all data members.
 556         * bcache.c (struct bcache): Move to bcache.h.
 557         (bcache::expand_hash_table): Rename from expand_hash_table.
 558         (bcache): Remove.
 559         (bcache::insert): Rename from bcache_full.
 560         (bcache::compare): Rename from bcache_compare.
 561         (bcache_xmalloc): Remove.
 562         (bcache::~bcache): Rename from bcache_xfree.
 563         (bcache::print_statistics): Rename from print_bcache_statistics.
 564         (bcache::memory_used): Rename from bcache_memory_used.
 565
 566 2019-03-07  Pedro Alves  <palves@redhat.com>
 567
 568         * infrun.c (normal_stop): Also check for
 569         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 570
 571 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 572
 573         * f-lang.c (value_from_host_double): Moved to...
 574         * value.c (value_from_host_double): ...here.
 575         * value.h (value_from_host_double): Declare.
 576         * guile/scm-math.c (vlscm_convert_typed_number): Use
 577         value_from_host_double.
 578         (vlscm_convert_number): Likewise.
 579         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 580         * python/py-value.c (convert_value_from_python): Likewise.
 581
 582 2019-03-06  Tom Tromey  <tom@tromey.com>
 583
 584         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 585
 586 2019-03-06  Tom Tromey  <tom@tromey.com>
 587
 588         * utils.h (free_current_contents): Don't declare.
 589         * utils.c (free_current_contents): Remove.
 590
 591 2019-03-06  Tom Tromey  <tom@tromey.com>
 592
 593         * top.c (quit_force): Update.
 594         * main.c (captured_command_loop): Update.
 595         * common/new-op.c (operator new): Update.
 596         * common/common-exceptions.c (struct catcher)
 597         <save_cleanup_chain>: Remove member.
 598         (exceptions_state_mc_init): Update.
 599         (exception_try_scope_entry): Return nullptr.
 600         (exception_try_scope_exit, exception_rethrow)
 601         (throw_exception_sjlj, throw_exception_cxx): Update.
 602         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 603         (all_cleanups, do_cleanups, discard_cleanups)
 604         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 605         (restore_cleanups, restore_final_cleanups): Don't declare.
 606         (do_final_cleanups): Remove parameter.
 607         * common/cleanups.c (cleanup_chain, make_cleanup)
 608         (make_cleanup_dtor, all_cleanups, do_cleanups)
 609         (discard_my_cleanups, discard_cleanups)
 610         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 611         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 612         (null_cleanup): Remove.
 613         (do_final_cleanups): Remove parameter.
 614
 615 2019-03-06  Tom Tromey  <tom@tromey.com>
 616
 617         * remote.c (remote_target::remote_parse_stop_reply): Use
 618         unique_xmalloc_ptr.
 619
 620 2019-03-06  Tom Tromey  <tom@tromey.com>
 621
 622         * stabsread.c (struct stabs_field_info): Rename from field_info.
 623         <list, fnlist>: Add initializers.
 624         <obstack>: New member.
 625         (read_member_functions, read_struct_fields, read_baseclasses):
 626         Allocate on obstack.  Don't use cleanups.
 627         (read_one_struct_field, read_member_functions, read_struct_fields)
 628         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 629         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 630         (read_struct_type): Update.
 631
 632 2019-03-06  Tom Tromey  <tom@tromey.com>
 633
 634         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 635         * common/filestuff.h (make_cleanup_close): Don't declare.
 636         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 637         Remove.
 638
 639 2019-03-06  Tom Tromey  <tom@tromey.com>
 640
 641         * solib-aix.c: Use make_scope_exit.
 642
 643 2019-03-06  Tom Tromey  <tom@tromey.com>
 644
 645         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 646         Use make_scope_exit.
 647
 648 2019-03-06  Tom Tromey  <tom@tromey.com>
 649
 650         * solib-svr4.c (disable_probes_interface): Remove parameter.
 651         (svr4_handle_solib_event): Use make_scope_exit.
 652
 653 2019-03-06  Tom Tromey  <tom@tromey.com>
 654
 655         * remote.c (struct stop_reply_deleter): Remove.
 656         (stop_reply_up): Update.
 657         (struct stop_reply): Derive from notif_event.  Don't typedef.
 658         <regcache>: Now a std::vector.
 659         (stop_reply_xfree): Remove.
 660         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 661         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 662         (remote_target::discard_pending_stop_replies): Use delete.
 663         (remote_target::remote_parse_stop_reply): Update.
 664         (remote_target::process_stop_reply): Update.
 665         * remote-notif.h (struct notif_event): Add virtual destructor.
 666         Remove "dtr" member.
 667         (struct notif_client) <alloc_event>: Return a unique_ptr.
 668         (notif_event_xfree): Don't declare.
 669         (notif_event_up): New typedef.
 670         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 671         (notif_event_xfree, do_notif_event_xfree): Remove.
 672         (remote_notif_state_xfree): Update.
 673
 674 2019-03-06  Tom Tromey  <tom@tromey.com>
 675
 676         * infrun.c (displaced_step_clear_cleanup): Now a
 677         forward_scope_exit type.
 678         (displaced_step_prepare_throw): Update.
 679         (displaced_step_fixup): Update.
 680
 681 2019-03-06  Tom Tromey  <tom@tromey.com>
 682
 683         * inferior.h (class inferior): Update comment.
 684         * gdbthread.h (class thread_info): Update comment.
 685
 686 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 687             Tom Tromey  <tom@tromey.com>
 688
 689         * stabsread.h (struct stab_section_list): Remove.
 690         (coffstab_build_psymtabs): Update.
 691         * dbxread.c (symbuf_sections): Now a std::vector.
 692         (sect_idx): New global.
 693         (fill_symbuf): Update.
 694         (coffstab_build_psymtabs): Change type of stabsects parameter.
 695         Update.
 696         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 697         std::vector.
 698         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 699         (coff_locate_sections): Update.
 700         (coff_symfile_read): Remove cleanups.  Update.
 701         (init_stringtab): Add storage parameter.
 702         (free_stringtab, free_stringtab_cleanup): Remove.
 703         (init_lineno): Add storage parameter.
 704         (free_linetab, free_linetab_cleanup): Remove.
 705
 706 2019-03-06  Pedro Alves  <palves@redhat.com>
 707
 708         * linux-fork.c (fork_info::clobber_regs): Delete.
 709         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 710         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 711         comment.  Adjust.
 712         (scoped_switch_fork_info::scoped_switch_fork_info)
 713         (checkpoint_command, linux_fork_context): Adjust
 714         fork_save_infrun_state calls.
 715
 716 2019-03-06  Pedro Alves  <palves@redhat.com>
 717
 718         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 719         (inf_has_multiple_threads): Return 'bool' and rewrite using
 720         inferior_info::threads().
 721
 722 2019-03-06  Pedro Alves  <palves@redhat.com>
 723
 724         * linux-fork.c: Include <list>.
 725         (fork_list): Now a std::list instance.
 726         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 727         (forks_exist_p, find_last_fork): Adjust.
 728         (new_fork): Delete.
 729         (one_fork_p): New.
 730         (add_fork): Adjust.
 731         (free_fork): Delete, folded into fork_info::~fork_info().
 732         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 733         Adjust.
 734         (init_fork_list): Delete.
 735         (linux_fork_killall, linux_fork_mourn_inferior)
 736         (linux_fork_detach, info_checkpoints_command): Adjust.
 737         (_initialize_linux_fork): No longer call init_fork_list.
 738
 739 2019-03-06  Pedro Alves  <palves@redhat.com>
 740
 741         * linux-fork.c (new_fork): New, split out of ...
 742         (add_fork): ... this.  Return void.  Move "first fork" special
 743         case from here, to ...
 744         (checkpoint_command): ... here.
 745         * linux-linux.h (add_fork): Return void.
 746
 747 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 748
 749         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 750
 751 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 752             Chris January  <chris.january@arm.com>
 753             David Lecomber  <david.lecomber@arm.com>
 754
 755         * f-exp.y: New token, UNOP_INTRINSIC.
 756         (exp): New pattern using UNOP_INTRINSIC token.
 757         (f77_keywords): Add 'abs' keyword.
 758         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 759         (value_from_host_double): New function.
 760         (evaluate_subexp_f): Support UNOP_ABS.
 761
 762 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 763
 764         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 765         types.
 766
 767 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 768
 769         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 770         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 771         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 772
 773 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 774
 775         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 776
 777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 778             Chris January  <chris.january@arm.com>
 779
 780         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 781         * f-exp.y: Define 'KIND' token.
 782         (exp): New pattern for KIND expressions.
 783         (ptype): Handle types with a kind extension.
 784         (direct_abs_decl): Extend to spot kind extensions.
 785         (f77_keywords): Add 'kind' to the list.
 786         (push_kind_type): New function.
 787         (convert_to_kind_type): New function.
 788         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 789         * parse.c (operator_length_standard): Likewise.
 790         * parser-defs.h (enum type_pieces): Add tp_kind.
 791         * std-operator.def: Add UNOP_KIND.
 792
 793 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 794
 795         * f-exp.y (f_parse): Set yydebug.
 796
 797 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 798
 799         * f-lang.c (evaluate_subexp_f): New function.
 800         (exp_descriptor_f): New global.
 801         (f_language_defn): Use exp_descriptor_f instead of
 802         exp_descriptor_standard.
 803
 804 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 805
 806         * f-exp.y (struct token): Add comments.
 807         (dot_ops): Remove uppercase versions and the end marker.
 808         (f77_keywords): Likewise.
 809         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 810         entries in the dot_ops array are case insensitive, and use
 811         strncasecmp to compare strings.  Also some whitespace cleanup in
 812         this area.  Similar for the f77_keywords array, except entries in
 813         this list might be case sensitive.
 814
 815 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 816
 817         * f-exp.y (struct f77_boolean_val): Add comments.
 818         (boolean_values): Remove uppercase versions, and end marker.
 819         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 820         and use strncasecmp to achieve case insensitivity.  Additionally,
 821         perform whitespace cleanup around this code.
 822
 823 2019-03-06  Tom Tromey  <tromey@adacore.com>
 824
 825         * remote-sim.c (gdbsim_target_open): Use result of
 826         gdb_argv::release.
 827
 828 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 829         Dirk Schubert  <dirk.schubert@arm.com>
 830         Chris January  <chris.january@arm.com>
 831
 832         * eval.c (evaluate_subexp_standard): Call Fortran argument
 833         wrapping logic.
 834         * f-lang.c (struct value): A value which can be passed into a
 835         Fortran function call.
 836         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 837         where appropriate.
 838         (struct type): Value ready for a Fortran function call.
 839         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 840         is needed.
 841         * f-lang.h (fortran_argument_convert): Declaration.
 842         (fortran_preserve_arg_pointer): Declaration.
 843         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 844
 845 2019-03-05  Tom Tromey  <tromey@adacore.com>
 846
 847         * python/py-prettyprint.c (print_string_repr): Remove #if.
 848         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 849
 850 2019-03-05  Tom Tromey  <tromey@adacore.com>
 851
 852         * target.c (the_dummy_target): Move later.  Change type to
 853         "dummy_target".
 854         (initialize_targets): Don't initialize the_dummy_target.
 855
 856 2019-03-05  Tom Tromey  <tromey@adacore.com>
 857
 858         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 859         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 860
 861 2019-03-05  Tom Tromey  <tromey@adacore.com>
 862
 863         * windows-nat.c (windows_nat_target::attach)
 864         (windows_nat_target::detach): Don't call gdb_flush.
 865         * valprint.c (generic_val_print, val_print, val_print_string):
 866         Don't call gdb_flush.
 867         * utils.c (defaulted_query): Don't call gdb_flush.
 868         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 869         * target.c (target_announce_detach): Don't call gdb_flush.
 870         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 871         * remote.c (extended_remote_target::attach): Don't call
 872         gdb_flush.
 873         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 874         * printcmd.c (do_examine): Don't call gdb_flush.
 875         (info_display_command): Don't call gdb_flush.
 876         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 877         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 878         * memattr.c (info_mem_command): Don't call gdb_flush.
 879         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 880         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 881         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 882         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 883         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 884         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 885         (gnu_nat_target::detach): Don't call gdb_flush.
 886         * f-valprint.c (f_val_print): Don't call gdb_flush.
 887         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 888         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 889         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 890         gdb_flush.
 891         * c-valprint.c (c_val_print): Don't call gdb_flush.
 892         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 893
 894 2019-03-05  Tom Tromey  <tromey@adacore.com>
 895
 896         * varobj.c (update_dynamic_varobj_children): Update.
 897         (install_default_visualizer): Use reset, not release.
 898         * value.c (set_internalvar): Update.
 899         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 900         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 901         ATTRIBUTE_UNUSED_RESULT.
 902
 903 2019-03-05  Tom Tromey  <tromey@adacore.com>
 904
 905         * remote.c (class scoped_remote_fd) <release>: Add
 906         ATTRIBUTE_UNUSED_RESULT.
 907
 908 2019-03-05  Tom Tromey  <tromey@adacore.com>
 909
 910         * macroexp.c (struct macro_buffer) <release>: Add
 911         ATTRIBUTE_UNUSED_RESULT.
 912
 913 2019-03-05  Tom Tromey  <tromey@adacore.com>
 914
 915         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 916         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 917         ATTRIBUTE_UNUSED_RESULT.
 918
 919 2019-03-05  Tom Tromey  <tromey@adacore.com>
 920
 921         * common/scoped_fd.h (class scoped_fd) <release>: Add
 922         ATTRIBUTE_UNUSED_RESULT.
 923
 924 2019-03-05  Tom Tromey  <tromey@adacore.com>
 925
 926         * parser-defs.h (struct parser_state) <release>: Add
 927         ATTRIBUTE_UNUSED_RESULT.
 928
 929 2019-03-05  Tom Tromey  <tromey@adacore.com>
 930
 931         * utils.h (class gdb_argv) <release>: Add
 932         ATTRIBUTE_UNUSED_RESULT.
 933         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 934
 935 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 936
 937         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 938         for-loop range, to avoid compiler warnings.
 939
 940         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 941         avoid compiler warnings about unused variables.
 942
 943         * NEWS: Mention end of support for native debugging on MS-Windows
 944         before XP.
 945
 946         PR gdb/24292
 947         * common/netstuff.c:
 948         * gdbserver/gdbreplay.c
 949         * gdbserver/remote-utils.c:
 950         * ser-tcp.c:
 951         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 952         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 953         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 954         'getaddrinfo' and 'freeaddrinfo' were not available before
 955         Windows XP, and mingw.org's MinGW headers by default define
 956         _WIN32_WINNT to 0x500.
 957
 958 2019-03-01  Gary Benson <gbenson@redhat.com>
 959
 960         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 961
 962 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 963             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 964
 965         PR gdb/8527
 966         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 967         set_sigint_trap, clear_sigint_trap.
 968
 969 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 970
 971         * target.c (target_detach): Clear the regcache and the
 972         frame cache.
 973
 974 2019-02-27  Pedro Alves  <palves@redhat.com>
 975
 976         * utils.c (set_screen_size): When we cap the height/width sizes,
 977         tweak the corresponding command variable to show "unlimited":
 978
 979 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 980             Pedro Alves  <palves@redhat.com>
 981
 982         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 983         before calling rl_set_screen_size.
 984
 985 2019-02-27  Tom Tromey  <tromey@adacore.com>
 986
 987         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 988         define.
 989         * python/py-value.c: Remove Python 2.4 workaround.
 990         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 991         workaround.
 992         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 993         Python 2.4 workaround.
 994         * python/python-internal.h: Remove Python 2.4 comment.
 995         (Py_ssize_t): Don't define.
 996         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 997         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 998         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 999         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1000         * python/python.c (do_start_initialization): Remove Python 2.4
1001         workaround.
1002         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1003         (print_children): Remove Python 2.4 workaround.
1004         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1005         workaround.
1006         (CHARBUFFERPROC_NAME): Remove.
1007         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1008         Python 2.4 workaround.
1009
1010 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1011
1012         * NEWS: Note minimum Python version.
1013
1014 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1015
1016         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1017         code from these functions.  Remove corresponding ifdefs.  Use
1018         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1019         Remove gotos and target of gotos.
1020         (infpy_search_memory): Likewise.
1021
1022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1025         (hppa_gdbarch_init): Don't register deleted functions with
1026         gdbarch.
1027
1028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1029
1030         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1031         (h8300_unwind_sp): Delete.
1032         (h8300_dummy_id): Delete.
1033         (h8300_gdbarch_init): Don't register deleted functions with
1034         gdbarch.
1035
1036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1037
1038         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1039         (ft32_unwind_pc): Delete.
1040         (ft32_unwind_sp): Delete.
1041         (ft32_gdbarch_init): Don't register deleted functions with
1042         gdbarch.
1043
1044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1047         (frv_unwind_pc): Delete.
1048         (frv_unwind_sp): Delete.
1049         (frv_gdbarch_init): Don't register deleted functions with
1050         gdbarch.
1051
1052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1053
1054         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1055         (riscv_unwind_pc): Delete.
1056         (riscv_unwind_sp): Delete.
1057         (riscv_gdbarch_init): Don't register deleted functions with
1058         gdbarch.
1059
1060 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1061
1062         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1063         (csky_unwind_pc): Delete.
1064         (csky_unwind_sp): Delete.
1065         (csky_gdbarch_init): Don't register deleted functions with
1066         gdbarch.
1067
1068 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1069
1070         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1071         (cris_unwind_pc): Delete.
1072         (cris_unwind_sp): Delete.
1073         (cris_gdbarch_init): Don't register deleted functions with
1074         gdbarch.
1075
1076 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1077
1078         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1079         (bfin_unwind_pc): Delete.
1080         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1081
1082 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1083
1084         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1085         (arm_unwind_pc): Delete.
1086         (arm_unwind_sp): Delete.
1087         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1088
1089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1090
1091         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1092         (arc_unwind_pc): Delete.
1093         (arc_unwind_sp): Delete.
1094         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1095
1096 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1097
1098         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1099         (alpha_unwind_pc): Delete.
1100         (alpha_gdbarch_init): Don't register deleted functions with
1101         gdbarch.
1102
1103 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1104
1105         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1106         (aarch64_unwind_pc): Delete.
1107         (aarch64_unwind_sp): Delete.
1108         (aarch64_gdbarch_init): Don't register deleted functions with
1109         gdbarch.
1110
1111 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1112
1113         * gdbtypes.c (type_align): Don't consider static members when
1114         computing structure alignment.
1115
1116 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1119         return 0 for other types.
1120         * arch-utils.c (default_type_align): Always return 0.
1121         * gdbarch.h: Regenerate.
1122         * gdbarch.sh (type_align): Extend comment.
1123         * gdbtypes.c (type_align): Add additional comments, always call
1124         gdbarch_type_align before applying the default rules.
1125         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1126         generic code will then apply a suitable default.
1127         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1128         types, return 0 for other types.
1129
1130 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1131
1132         * NEWS: Create a new section for the next release branch.
1133         Rename the section of the current branch, now that it has
1134         been cut.
1135
1136 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1137
1138         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1139         * version.in: Bump version to 8.3.50.DATE-git.
1140
1141 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1142
1143         * aix-thread.c (ptid_cmp): Remove unused variable.
1144         (get_signaled_thread): Likewise.
1145         (store_regs_user_thread): Likewise.
1146         (store_regs_kernel_thread): Likewise.
1147         (fetch_regs_kernel_thread): Remove shadowed variable.
1148
1149 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1150
1151         * features/riscv/32bit-cpu.xml: Add register numbers.
1152         * features/riscv/32bit-fpu.c: Regenerate.
1153         * features/riscv/32bit-fpu.xml: Add register numbers.
1154         * features/riscv/64bit-cpu.xml: Add register numbers.
1155         * features/riscv/64bit-fpu.c: Regenerate.
1156         * features/riscv/64bit-fpu.xml: Add register numbers.
1157
1158 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1159
1160         * NEWS: Mention two argument form of gdb.Value constructor.
1161         * python/py-value.c (convert_buffer_and_type_to_value): New
1162         function.
1163         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1164         Add support for handling an optional second argument.  Call
1165         convert_buffer_and_type_to_value as appropriate.
1166         * python/python-internal.h (Py_buffer_deleter): New struct.
1167         (Py_buffer_up): New typedef.
1168
1169 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1170
1171         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1172         instead of releasing ownership.
1173
1174 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1175
1176         * dwarf2read.c (open_and_init_dwp_file): Call
1177         elf_numsections instead of bfd_count_sections to initialize
1178         dwp_file->num_sections.
1179
1180 2019-02-25  Tom Tromey  <tromey@adacore.com>
1181
1182         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1183
1184 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1185
1186         * gcore.in: Add '--readnever' option when invoking GDB.
1187
1188 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1189
1190         * MAINTAINERS: Update my email address.
1191
1192 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1193
1194         * build-id.c (build_id_to_debug_bfd_1): New function.
1195         (build_id_to_debug_bfd): Look for separate debug file in
1196         sysroot.
1197
1198 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1199
1200         * gdbarch.sh: Update the copyright year range that is placed into
1201         generated files.
1202
1203 2019-02-22  Keith Seitz  <keiths@redhat.com>
1204
1205         PR symtab/23853
1206         * linespec.c (create_sals_line_offset): Search for the default
1207         symtab's filename instead of its fullname.
1208
1209 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1210
1211         * NEWS: Update style defaults.
1212
1213 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1214
1215         * main.c (captured_main_1): Disable styling in batch mode.
1216
1217 2019-02-20  Tom Tromey  <tom@tromey.com>
1218
1219         * symtab.c (symtab_symbol_info): Fix typos.
1220
1221 2019-02-20  Tom Tromey  <tromey@adacore.com>
1222
1223         * findcmd.c (_initialize_mem_search): Use upper case for
1224         metasyntactic variables.
1225
1226 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1227
1228         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1229         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1230
1231 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1232
1233         * top.h (source_file_name): Change to std::string.
1234         * top.c (source_file_name): Likewise.
1235         (command_line_input): Adjust.
1236         * cli/cli-script.c (script_from_file): Adjust.
1237
1238 2019-02-19  Tom Tromey  <tromey@adacore.com>
1239
1240         * ravenscar-thread.c
1241         (ravenscar_thread_target::update_thread_list): Don't call
1242         ada_build_task_list.
1243         * ada-lang.h (ada_build_task_list): Don't declare.
1244         * ada-tasks.c (struct ada_tasks_inferior_data)
1245         <task_list_valid_p>: Now bool.
1246         (read_known_tasks, ada_task_list_changed)
1247         (ada_tasks_invalidate_inferior_data): Update.
1248         (read_known_tasks_array): Return bool.
1249         (read_known_tasks_list): Likewise.
1250         (read_known_tasks): Return void.
1251         (ada_build_task_list): Now static.
1252
1253 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1254
1255         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1256         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1257
1258 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1259
1260         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1261         variant for ada_tasks_pspace_data_handle and
1262         ada_tasks_inferior_data_handle.
1263         (ada_tasks_pspace_data_cleanup): New function.
1264         (ada_tasks_inferior_data_cleanup): New function.
1265
1266 2019-02-17  Tom Tromey  <tom@tromey.com>
1267
1268         * macrotab.h (macro_source_fullname): Return a std::string.
1269         * macrotab.c (macro_include, check_for_redefinition)
1270         (macro_undef, macro_lookup_definition, foreach_macro)
1271         (foreach_macro_in_scope): Update.
1272         (macro_source_fullname): Return a std::string.
1273         * macrocmd.c (show_pp_source_pos): Update.
1274
1275 2019-02-17  Tom Tromey  <tom@tromey.com>
1276
1277         * macrocmd.c (show_pp_source_pos): Style the file names.
1278
1279 2019-02-17  Tom Tromey  <tom@tromey.com>
1280
1281         PR tui/24197:
1282         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1283
1284 2019-02-17  Tom Tromey  <tom@tromey.com>
1285
1286         * ada-lang.c (user_select_syms): Use filtered printing.
1287         * utils.c (wrap_style): New global.
1288         (desired_style): Remove.
1289         (emit_style_escape): Add stream parameter.
1290         (set_output_style, reset_terminal_style, prompt_for_continue):
1291         Update.
1292         (flush_wrap_buffer): Only flush gdb_stdout.
1293         (wrap_here): Set wrap_style.
1294         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1295         treat escape sequences as a character.  Change when wrap buffer is
1296         flushed.
1297         (fputs_styled): Do not set the output style when the default is
1298         requested.
1299         * ui-style.h (struct ui_file_style) <is_default>: New method.
1300         * source.c (print_source_lines_base): Emit escape sequences in one
1301         piece.
1302
1303 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1304
1305         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1306         integers and enumeration types.
1307
1308 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1309
1310         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1311         instead of lookup_symbol_in_language
1312         (do_exact_match): New function.
1313         (ada_get_symbol_name_matcher): Return do_exact_match when
1314         doing a verbatim match.
1315
1316 2019-02-15  Tom Tromey  <tromey@adacore.com>
1317
1318         * ravenscar-thread.c (ravenscar_thread_target::resume)
1319         (ravenscar_thread_target::wait): Special case wildcard requests.
1320
1321 2019-02-15  Tom Tromey  <tromey@adacore.com>
1322
1323         * ravenscar-thread.c (base_ptid): Remove.
1324         (struct ravenscar_thread_target) <close>: New method.
1325         <m_base_ptid>: New member.
1326         <update_inferior_ptid, active_task, task_is_currently_active,
1327         runtime_initialized>: Declare methods.
1328         <ravenscar_thread_target>: Add constructor.
1329         (ravenscar_thread_target::task_is_currently_active)
1330         (ravenscar_thread_target::update_inferior_ptid)
1331         (ravenscar_runtime_initialized): Rename.  Now methods.
1332         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1333         (ravenscar_thread_target::update_thread_list): Update.
1334         (ravenscar_thread_target::active_task): Now method.
1335         (ravenscar_thread_target::store_registers)
1336         (ravenscar_thread_target::prepare_to_store)
1337         (ravenscar_thread_target::prepare_to_store)
1338         (ravenscar_thread_target::mourn_inferior): Update.
1339         (ravenscar_inferior_created): Use "new" to create target.
1340         (ravenscar_thread_target::get_ada_task_ptid): Update.
1341         (_initialize_ravenscar): Don't initialize base_ptid.
1342         (ravenscar_ops): Remove global.
1343
1344 2019-02-15  Tom Tromey  <tromey@adacore.com>
1345
1346         * target.h (push_target): Declare new overload.
1347         * target.c (push_target): New overload, taking an rvalue reference.
1348         * remote.c (remote_target::open_1): Use push_target overload.
1349         * corelow.c (core_target_open): Use push_target overload.
1350
1351 2019-02-15  Tom Tromey  <tromey@adacore.com>
1352
1353         * ravenscar-thread.c (is_ravenscar_task)
1354         (ravenscar_task_is_currently_active): Return bool.
1355         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1356         (_initialize_ravenscar): Remove "(void)".
1357         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1358         Return bool.
1359
1360 2019-02-15  Tom Tromey  <tromey@adacore.com>
1361
1362         * ravenscar-thread.c (ravenscar_runtime_initializer)
1363         (has_ravenscar_runtime, get_running_thread_id)
1364         (ravenscar_thread_target::resume): Fix indentation.
1365
1366 2019-02-15  Tom Tromey  <tromey@adacore.com>
1367
1368         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1369         from ravenscar_arch_ops.
1370         (sparc_ravenscar_ops::fetch_registers)
1371         (sparc_ravenscar_ops::store_registers): Now methods.
1372         (sparc_ravenscar_prepare_to_store): Remove.
1373         (sparc_ravenscar_ops): Redefine.
1374         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1375         methods and destructor.  Remove members.
1376         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1377         (ravenscar_thread_target::store_registers)
1378         (ravenscar_thread_target::prepare_to_store): Update.
1379         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1380         Remove.
1381         (struct ppc_ravenscar_powerpc_ops): Derive from
1382         ravenscar_arch_ops.
1383         (ppc_ravenscar_powerpc_ops::fetch_registers)
1384         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1385         (ppc_ravenscar_powerpc_ops): Redefine.
1386         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1387         (ppc_ravenscar_e500_ops::fetch_registers)
1388         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1389         (ppc_ravenscar_e500_ops): Redefine.
1390         * aarch64-ravenscar-thread.c
1391         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1392         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1393         (aarch64_ravenscar_fetch_registers)
1394         (aarch64_ravenscar_store_registers): Now methods.
1395         (aarch64_ravenscar_ops): Redefine.
1396
1397 2019-02-15  Tom Tromey  <tromey@adacore.com>
1398
1399         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1400         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1401         (ravenscar_thread_target::stopped_by_watchpoint)
1402         (ravenscar_thread_target::stopped_data_address)
1403         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1404
1405 2019-02-15  Tom Tromey  <tromey@adacore.com>
1406
1407         * ravenscar-thread.c: Fix some typos.
1408
1409 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1410             Tom Tromey  <tromey@adacore.com>
1411
1412         * ada-lang.c (ada_exception_sal): Change addr_string to a
1413         std::string.
1414         (create_ada_exception_catchpoint): Update.
1415
1416 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1417             Tom Tromey  <tromey@adacore.com>
1418
1419         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1420         (bp_location_ops): Remove.
1421         (base_breakpoint_allocate_location): Update.
1422         (free_bp_location): Update.
1423         * ada-lang.c (class ada_catchpoint_location)
1424         <ada_catchpoint_location>: Remove ops parameter.
1425         (ada_catchpoint_location_dtor): Remove.
1426         (ada_catchpoint_location_ops): Remove.
1427         (allocate_location_exception): Update.
1428         * breakpoint.h (struct bp_location_ops): Remove.
1429         (class bp_location) <bp_location>: Remove bp_location_ops
1430         parameter.
1431         <~bp_location>: Add destructor.
1432         <ops>: Remove.
1433
1434 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1435             Pedro Alves  <palves@redhat.com>
1436
1437         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1438         'PATH_MAX'.
1439
1440 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1441             Samuel Thibault  <samuel.thibault@gnu.org>
1442             Thomas Schwinge  <thomas@codesourcery.com>
1443
1444         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1445         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1446
1447 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1448
1449         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1450         (check_empty): Use "const char *".
1451
1452         * gnu-nat.c (gnu_nat_target::detach): Instead of
1453         'detach_inferior (pid)' call
1454         'detach_inferior (find_inferior_pid (pid))'.
1455
1456         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1457         'nat/fork-inferior.o'.
1458         * gnu-nat.c: #include "nat/fork-inferior.h".
1459
1460         * gnu-nat.c (gnu_nat_target::detach): Instead of
1461         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1462         * gnu-nat.h: #include "inf-child.h".
1463         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1464         'i386_gnu_nat_target::fetch_registers'.
1465         (gnu_store_registers): Rename/move to
1466         'i386_gnu_nat_target::store_registers'.
1467
1468         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1469         * gnu-nat.h (mach_thread_info): New function.
1470         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1471
1472         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1473
1474 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1475
1476         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1477
1478 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1479
1480         * windows-nat.c (windows_add_thread): Add new parameter
1481         "main_thread_p" with default value set to false.  Update
1482         function documentation as well as all callers.
1483         (windows_delete_thread): Likewise.
1484         (fake_create_process): Update call to windows_add_thread.
1485         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1486         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1487         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1488         call to windows_delete_thread.
1489
1490 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1491
1492         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1493
1494 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1495
1496         * symfile.c (find_separate_debug_file): Use canonical path of
1497         sysroot with child_path instead of gdb_sysroot if it is valid.
1498
1499 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1500
1501         * symfile.c (find_separate_debug_file): Use child_path to
1502         determine if an object file is under a sysroot.
1503
1504 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1505
1506         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1507         unittests/child-path-selftests.c.
1508         * common/pathstuff.c (child_path): New function.
1509         * common/pathstuff.h (child_path): New prototype.
1510         * unittests/child-path-selftests.c: New file.
1511
1512 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1513
1514         * symfile.c (find_separate_debug_file): Look for separate debug
1515         files in debug directories under the sysroot.
1516
1517 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1518
1519         * symtab.h (struct minimal_symbol data_p): New const method.
1520         (struct minimal_symbol text_p): Likewise.
1521         * symtab.c (output_source_filename): Use file name style
1522         to print file name.
1523         (print_symbol_info): Likewise.
1524         (print_msymbol_info): Use address style to print addresses.
1525         Use function name style to print executable text symbols.
1526         (expand_symtab_containing_pc): Use data_p.
1527         (find_pc_sect_compunit_symtab): Likewise.
1528
1529 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1530
1531         * breakpoint.c (describe_other_breakpoints): Use address style
1532         to print addresses.
1533         (say_where): Likewise.
1534
1535 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1536
1537         * ada-typeprint.c (print_func_type): Print function name
1538         style to print function name.
1539         * c-typeprint.c (c_print_type_1): Likewise.
1540
1541 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1542
1543         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1544         for execve.
1545
1546 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1547
1548         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1549         type_stack.
1550
1551 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1552
1553         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1554         TYPE_CODE_REF types.
1555
1556 2019-02-08  Jim Wilson  <jimw@sifive.com>
1557
1558         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1559         (riscv_linux_fregset): New.
1560         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1561
1562 2019-02-07  Tom Tromey  <tom@tromey.com>
1563
1564         * thread.c (thread_cancel_execution_command): Update.
1565         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1566         methods.
1567         (struct thread_fsm_ops): Remove.
1568         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1569         (thread_fsm_should_stop, thread_fsm_return_value)
1570         (thread_fsm_set_finished, thread_fsm_finished_p)
1571         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1572         Don't declare.
1573         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1574         * infrun.c (clear_proceed_status_thread)
1575         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1576         (print_stop_event): Update.
1577         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1578         Add constructor.
1579         (step_command_fsm_ops): Remove.
1580         (new_step_command_fsm): Remove.
1581         (step_1): Update.
1582         (step_command_fsm::should_stop): Rename from
1583         step_command_fsm_should_stop.
1584         (step_command_fsm::clean_up): Rename from
1585         step_command_fsm_clean_up.
1586         (step_command_fsm::do_async_reply_reason): Rename from
1587         step_command_fsm_async_reply_reason.
1588         (struct until_next_fsm): Inherit from thread_fsm.  Add
1589         constructor.
1590         (until_next_fsm_ops): Remove.
1591         (new_until_next_fsm): Remove.
1592         (until_next_fsm::should_stop): Rename from
1593         until_next_fsm_should_stop.
1594         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1595         (until_next_fsm::do_async_reply_reason): Rename from
1596         until_next_fsm_async_reply_reason.
1597         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1598         constructor.  Change type of breakpoint.
1599         (finish_command_fsm_ops): Remove.
1600         (new_finish_command_fsm): Remove.
1601         (finish_command_fsm::should_stop): Rename from
1602         finish_command_fsm_should_stop.
1603         (finish_command_fsm::clean_up): Rename from
1604         finish_command_fsm_clean_up.
1605         (finish_command_fsm::return_value): Rename from
1606         finish_command_fsm_return_value.
1607         (finish_command_fsm::do_async_reply_reason): Rename from
1608         finish_command_fsm_async_reply_reason.
1609         (finish_command): Update.
1610         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1611         Add constructor.
1612         (call_thread_fsm_ops): Remove.
1613         (call_thread_fsm::call_thread_fsm): Rename from
1614         new_call_thread_fsm.
1615         (call_thread_fsm::should_stop): Rename from
1616         call_thread_fsm_should_stop.
1617         (call_thread_fsm::should_notify_stop): Rename from
1618         call_thread_fsm_should_notify_stop.
1619         (run_inferior_call, call_function_by_hand_dummy): Update.
1620         * cli/cli-interp.c (should_print_stop_to_console): Update.
1621         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1622         Add constructor.  Change type of location_breakpoint,
1623         caller_breakpoint.
1624         (until_break_fsm_ops): Remove.
1625         (new_until_break_fsm): Remove.
1626         (until_break_fsm::should_stop): Rename from
1627         until_break_fsm_should_stop.
1628         (until_break_fsm::clean_up): Rename from
1629         until_break_fsm_clean_up.
1630         (until_break_fsm::do_async_reply_reason): Rename from
1631         until_break_fsm_async_reply_reason.
1632         (until_break_command): Update.
1633         * thread-fsm.c: Remove.
1634         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1635
1636 2019-02-07  Tom Tromey  <tom@tromey.com>
1637
1638         * yy-remap.h: Add include guard.
1639         * xtensa-tdep.h: Add include guard.
1640         * xcoffread.h: Rename include guard.
1641         * varobj-iter.h: Add include guard.
1642         * tui/tui.h: Rename include guard.
1643         * tui/tui-winsource.h: Rename include guard.
1644         * tui/tui-wingeneral.h: Rename include guard.
1645         * tui/tui-windata.h: Rename include guard.
1646         * tui/tui-win.h: Rename include guard.
1647         * tui/tui-stack.h: Rename include guard.
1648         * tui/tui-source.h: Rename include guard.
1649         * tui/tui-regs.h: Rename include guard.
1650         * tui/tui-out.h: Rename include guard.
1651         * tui/tui-layout.h: Rename include guard.
1652         * tui/tui-io.h: Rename include guard.
1653         * tui/tui-hooks.h: Rename include guard.
1654         * tui/tui-file.h: Rename include guard.
1655         * tui/tui-disasm.h: Rename include guard.
1656         * tui/tui-data.h: Rename include guard.
1657         * tui/tui-command.h: Rename include guard.
1658         * tic6x-tdep.h: Add include guard.
1659         * target/waitstatus.h: Rename include guard.
1660         * target/wait.h: Rename include guard.
1661         * target/target.h: Rename include guard.
1662         * target/resume.h: Rename include guard.
1663         * target-float.h: Rename include guard.
1664         * stabsread.h: Add include guard.
1665         * rs6000-tdep.h: Add include guard.
1666         * riscv-fbsd-tdep.h: Add include guard.
1667         * regformats/regdef.h: Rename include guard.
1668         * record.h: Rename include guard.
1669         * python/python.h: Rename include guard.
1670         * python/python-internal.h: Rename include guard.
1671         * python/py-stopevent.h: Rename include guard.
1672         * python/py-ref.h: Rename include guard.
1673         * python/py-record.h: Rename include guard.
1674         * python/py-record-full.h: Rename include guard.
1675         * python/py-record-btrace.h: Rename include guard.
1676         * python/py-instruction.h: Rename include guard.
1677         * python/py-events.h: Rename include guard.
1678         * python/py-event.h: Rename include guard.
1679         * procfs.h: Add include guard.
1680         * proc-utils.h: Add include guard.
1681         * p-lang.h: Add include guard.
1682         * or1k-tdep.h: Rename include guard.
1683         * observable.h: Rename include guard.
1684         * nto-tdep.h: Rename include guard.
1685         * nat/x86-linux.h: Rename include guard.
1686         * nat/x86-linux-dregs.h: Rename include guard.
1687         * nat/x86-gcc-cpuid.h: Add include guard.
1688         * nat/x86-dregs.h: Rename include guard.
1689         * nat/x86-cpuid.h: Rename include guard.
1690         * nat/ppc-linux.h: Rename include guard.
1691         * nat/mips-linux-watch.h: Rename include guard.
1692         * nat/linux-waitpid.h: Rename include guard.
1693         * nat/linux-ptrace.h: Rename include guard.
1694         * nat/linux-procfs.h: Rename include guard.
1695         * nat/linux-osdata.h: Rename include guard.
1696         * nat/linux-nat.h: Rename include guard.
1697         * nat/linux-namespaces.h: Rename include guard.
1698         * nat/linux-btrace.h: Rename include guard.
1699         * nat/glibc_thread_db.h: Rename include guard.
1700         * nat/gdb_thread_db.h: Rename include guard.
1701         * nat/gdb_ptrace.h: Rename include guard.
1702         * nat/fork-inferior.h: Rename include guard.
1703         * nat/amd64-linux-siginfo.h: Rename include guard.
1704         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1705         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1706         * nat/aarch64-linux.h: Rename include guard.
1707         * nat/aarch64-linux-hw-point.h: Rename include guard.
1708         * mn10300-tdep.h: Add include guard.
1709         * mips-linux-tdep.h: Add include guard.
1710         * mi/mi-parse.h: Rename include guard.
1711         * mi/mi-out.h: Rename include guard.
1712         * mi/mi-main.h: Rename include guard.
1713         * mi/mi-interp.h: Rename include guard.
1714         * mi/mi-getopt.h: Rename include guard.
1715         * mi/mi-console.h: Rename include guard.
1716         * mi/mi-common.h: Rename include guard.
1717         * mi/mi-cmds.h: Rename include guard.
1718         * mi/mi-cmd-break.h: Rename include guard.
1719         * m2-lang.h: Add include guard.
1720         * location.h: Rename include guard.
1721         * linux-record.h: Rename include guard.
1722         * linux-nat.h: Add include guard.
1723         * linux-fork.h: Add include guard.
1724         * i386-darwin-tdep.h: Rename include guard.
1725         * hppa-linux-offsets.h: Add include guard.
1726         * guile/guile.h: Rename include guard.
1727         * guile/guile-internal.h: Rename include guard.
1728         * gnu-nat.h: Rename include guard.
1729         * gdb-stabs.h: Rename include guard.
1730         * frv-tdep.h: Add include guard.
1731         * f-lang.h: Add include guard.
1732         * event-loop.h: Add include guard.
1733         * darwin-nat.h: Rename include guard.
1734         * cp-abi.h: Rename include guard.
1735         * config/sparc/nm-sol2.h: Rename include guard.
1736         * config/nm-nto.h: Rename include guard.
1737         * config/nm-linux.h: Add include guard.
1738         * config/i386/nm-i386gnu.h: Rename include guard.
1739         * config/djgpp/nl_types.h: Rename include guard.
1740         * config/djgpp/langinfo.h: Rename include guard.
1741         * compile/gcc-cp-plugin.h: Add include guard.
1742         * compile/gcc-c-plugin.h: Add include guard.
1743         * compile/compile.h: Rename include guard.
1744         * compile/compile-object-run.h: Rename include guard.
1745         * compile/compile-object-load.h: Rename include guard.
1746         * compile/compile-internal.h: Rename include guard.
1747         * compile/compile-cplus.h: Rename include guard.
1748         * compile/compile-c.h: Rename include guard.
1749         * common/xml-utils.h: Rename include guard.
1750         * common/x86-xstate.h: Rename include guard.
1751         * common/version.h: Rename include guard.
1752         * common/vec.h: Rename include guard.
1753         * common/tdesc.h: Rename include guard.
1754         * common/selftest.h: Rename include guard.
1755         * common/scoped_restore.h: Rename include guard.
1756         * common/scoped_mmap.h: Rename include guard.
1757         * common/scoped_fd.h: Rename include guard.
1758         * common/safe-iterator.h: Rename include guard.
1759         * common/run-time-clock.h: Rename include guard.
1760         * common/refcounted-object.h: Rename include guard.
1761         * common/queue.h: Rename include guard.
1762         * common/ptid.h: Rename include guard.
1763         * common/print-utils.h: Rename include guard.
1764         * common/preprocessor.h: Rename include guard.
1765         * common/pathstuff.h: Rename include guard.
1766         * common/observable.h: Rename include guard.
1767         * common/netstuff.h: Rename include guard.
1768         * common/job-control.h: Rename include guard.
1769         * common/host-defs.h: Rename include guard.
1770         * common/gdb_wait.h: Rename include guard.
1771         * common/gdb_vecs.h: Rename include guard.
1772         * common/gdb_unlinker.h: Rename include guard.
1773         * common/gdb_unique_ptr.h: Rename include guard.
1774         * common/gdb_tilde_expand.h: Rename include guard.
1775         * common/gdb_sys_time.h: Rename include guard.
1776         * common/gdb_string_view.h: Rename include guard.
1777         * common/gdb_splay_tree.h: Rename include guard.
1778         * common/gdb_setjmp.h: Rename include guard.
1779         * common/gdb_ref_ptr.h: Rename include guard.
1780         * common/gdb_optional.h: Rename include guard.
1781         * common/gdb_locale.h: Rename include guard.
1782         * common/gdb_assert.h: Rename include guard.
1783         * common/filtered-iterator.h: Rename include guard.
1784         * common/filestuff.h: Rename include guard.
1785         * common/fileio.h: Rename include guard.
1786         * common/environ.h: Rename include guard.
1787         * common/common-utils.h: Rename include guard.
1788         * common/common-types.h: Rename include guard.
1789         * common/common-regcache.h: Rename include guard.
1790         * common/common-inferior.h: Rename include guard.
1791         * common/common-gdbthread.h: Rename include guard.
1792         * common/common-exceptions.h: Rename include guard.
1793         * common/common-defs.h: Rename include guard.
1794         * common/common-debug.h: Rename include guard.
1795         * common/cleanups.h: Rename include guard.
1796         * common/buffer.h: Rename include guard.
1797         * common/btrace-common.h: Rename include guard.
1798         * common/break-common.h: Rename include guard.
1799         * cli/cli-utils.h: Rename include guard.
1800         * cli/cli-style.h: Rename include guard.
1801         * cli/cli-setshow.h: Rename include guard.
1802         * cli/cli-script.h: Rename include guard.
1803         * cli/cli-interp.h: Rename include guard.
1804         * cli/cli-decode.h: Rename include guard.
1805         * cli/cli-cmds.h: Rename include guard.
1806         * charset-list.h: Add include guard.
1807         * buildsym-legacy.h: Rename include guard.
1808         * bfin-tdep.h: Add include guard.
1809         * ax.h: Rename include guard.
1810         * arm-linux-tdep.h: Add include guard.
1811         * arm-fbsd-tdep.h: Add include guard.
1812         * arch/xtensa.h: Rename include guard.
1813         * arch/tic6x.h: Add include guard.
1814         * arch/i386.h: Add include guard.
1815         * arch/arm.h: Rename include guard.
1816         * arch/arm-linux.h: Rename include guard.
1817         * arch/arm-get-next-pcs.h: Rename include guard.
1818         * arch/amd64.h: Add include guard.
1819         * arch/aarch64-insn.h: Rename include guard.
1820         * arch-utils.h: Rename include guard.
1821         * annotate.h: Add include guard.
1822         * amd64-darwin-tdep.h: Rename include guard.
1823         * aarch64-linux-tdep.h: Add include guard.
1824         * aarch64-fbsd-tdep.h: Add include guard.
1825         * aarch32-linux-nat.h: Add include guard.
1826
1827 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1828
1829         * macrotab.c (macro_define_internal): New function that
1830         factorizes macro_define_object_internal and macro_define_function
1831         code.
1832         (macro_define_object_internal): Use macro_define_internal.
1833         (macro_define_function): Likewise.
1834
1835 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1836
1837         * macrocmd.c (extract_identifier): Return
1838         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1839         callers.
1840
1841 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1842
1843         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1844
1845 2019-02-05  Tom Tromey  <tom@tromey.com>
1846
1847         * target.c (target_stack::unpush): Move assertion earlier.
1848
1849 2019-01-30  Tom Tromey  <tom@tromey.com>
1850
1851         PR python/23615:
1852         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1853         (gdbpy_parse_and_eval): Likewise.
1854         * python/python-internal.h (gdbpy_allow_threads): New class.
1855
1856 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1857
1858         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1859         (aarch64_fbsd_fpregmap): Move earlier.
1860         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1861         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1862         instead of individual calls to trad_frame_set_reg_addr.
1863         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1864         earlier.
1865         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1866         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1867         instead of individual calls to trad_frame_set_reg_addr.
1868
1869 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1870
1871         * CONTRIBUTE: Replace contribution list with wiki link.
1872
1873 2019-01-25  Tom Tromey  <tom@tromey.com>
1874
1875         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1876
1877 2019-01-25  Tom Tromey  <tom@tromey.com>
1878
1879         * xtensa-linux-nat.c: Fix common/ includes.
1880         * xml-support.h: Fix common/ includes.
1881         * xml-support.c: Fix common/ includes.
1882         * x86-linux-nat.c: Fix common/ includes.
1883         * windows-nat.c: Fix common/ includes.
1884         * varobj.h: Fix common/ includes.
1885         * varobj.c: Fix common/ includes.
1886         * value.c: Fix common/ includes.
1887         * valops.c: Fix common/ includes.
1888         * utils.c: Fix common/ includes.
1889         * unittests/xml-utils-selftests.c: Fix common/ includes.
1890         * unittests/utils-selftests.c: Fix common/ includes.
1891         * unittests/unpack-selftests.c: Fix common/ includes.
1892         * unittests/tracepoint-selftests.c: Fix common/ includes.
1893         * unittests/style-selftests.c: Fix common/ includes.
1894         * unittests/string_view-selftests.c: Fix common/ includes.
1895         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1896         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1897         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1898         * unittests/rsp-low-selftests.c: Fix common/ includes.
1899         * unittests/parse-connection-spec-selftests.c: Fix common/
1900         includes.
1901         * unittests/optional-selftests.c: Fix common/ includes.
1902         * unittests/offset-type-selftests.c: Fix common/ includes.
1903         * unittests/observable-selftests.c: Fix common/ includes.
1904         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1905         * unittests/memrange-selftests.c: Fix common/ includes.
1906         * unittests/memory-map-selftests.c: Fix common/ includes.
1907         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1908         * unittests/function-view-selftests.c: Fix common/ includes.
1909         * unittests/environ-selftests.c: Fix common/ includes.
1910         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1911         * unittests/common-utils-selftests.c: Fix common/ includes.
1912         * unittests/cli-utils-selftests.c: Fix common/ includes.
1913         * unittests/array-view-selftests.c: Fix common/ includes.
1914         * ui-file.c: Fix common/ includes.
1915         * tui/tui-io.c: Fix common/ includes.
1916         * tracepoint.h: Fix common/ includes.
1917         * tracepoint.c: Fix common/ includes.
1918         * tracefile-tfile.c: Fix common/ includes.
1919         * top.h: Fix common/ includes.
1920         * top.c: Fix common/ includes.
1921         * thread.c: Fix common/ includes.
1922         * target/waitstatus.h: Fix common/ includes.
1923         * target/waitstatus.c: Fix common/ includes.
1924         * target.h: Fix common/ includes.
1925         * target.c: Fix common/ includes.
1926         * target-memory.c: Fix common/ includes.
1927         * target-descriptions.c: Fix common/ includes.
1928         * symtab.h: Fix common/ includes.
1929         * symfile.c: Fix common/ includes.
1930         * stap-probe.c: Fix common/ includes.
1931         * spu-linux-nat.c: Fix common/ includes.
1932         * sparc-nat.c: Fix common/ includes.
1933         * source.c: Fix common/ includes.
1934         * solib.c: Fix common/ includes.
1935         * solib-target.c: Fix common/ includes.
1936         * ser-unix.c: Fix common/ includes.
1937         * ser-tcp.c: Fix common/ includes.
1938         * ser-pipe.c: Fix common/ includes.
1939         * ser-base.c: Fix common/ includes.
1940         * selftest-arch.c: Fix common/ includes.
1941         * s12z-tdep.c: Fix common/ includes.
1942         * rust-exp.y: Fix common/ includes.
1943         * rs6000-aix-tdep.c: Fix common/ includes.
1944         * riscv-tdep.c: Fix common/ includes.
1945         * remote.c: Fix common/ includes.
1946         * remote-notif.h: Fix common/ includes.
1947         * remote-fileio.h: Fix common/ includes.
1948         * remote-fileio.c: Fix common/ includes.
1949         * regcache.h: Fix common/ includes.
1950         * regcache.c: Fix common/ includes.
1951         * record-btrace.c: Fix common/ includes.
1952         * python/python.c: Fix common/ includes.
1953         * python/py-type.c: Fix common/ includes.
1954         * python/py-inferior.c: Fix common/ includes.
1955         * progspace.h: Fix common/ includes.
1956         * producer.c: Fix common/ includes.
1957         * procfs.c: Fix common/ includes.
1958         * proc-api.c: Fix common/ includes.
1959         * printcmd.c: Fix common/ includes.
1960         * ppc-linux-nat.c: Fix common/ includes.
1961         * parser-defs.h: Fix common/ includes.
1962         * osdata.c: Fix common/ includes.
1963         * obsd-nat.c: Fix common/ includes.
1964         * nat/x86-linux.c: Fix common/ includes.
1965         * nat/x86-linux-dregs.c: Fix common/ includes.
1966         * nat/x86-dregs.h: Fix common/ includes.
1967         * nat/x86-dregs.c: Fix common/ includes.
1968         * nat/ppc-linux.c: Fix common/ includes.
1969         * nat/mips-linux-watch.h: Fix common/ includes.
1970         * nat/mips-linux-watch.c: Fix common/ includes.
1971         * nat/linux-waitpid.c: Fix common/ includes.
1972         * nat/linux-ptrace.h: Fix common/ includes.
1973         * nat/linux-ptrace.c: Fix common/ includes.
1974         * nat/linux-procfs.c: Fix common/ includes.
1975         * nat/linux-personality.c: Fix common/ includes.
1976         * nat/linux-osdata.c: Fix common/ includes.
1977         * nat/linux-namespaces.c: Fix common/ includes.
1978         * nat/linux-btrace.h: Fix common/ includes.
1979         * nat/linux-btrace.c: Fix common/ includes.
1980         * nat/fork-inferior.c: Fix common/ includes.
1981         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1982         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1983         * nat/aarch64-linux.c: Fix common/ includes.
1984         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1985         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1986         * namespace.h: Fix common/ includes.
1987         * mips-linux-tdep.c: Fix common/ includes.
1988         * minsyms.c: Fix common/ includes.
1989         * mi/mi-parse.h: Fix common/ includes.
1990         * mi/mi-main.c: Fix common/ includes.
1991         * mi/mi-cmd-env.c: Fix common/ includes.
1992         * memrange.h: Fix common/ includes.
1993         * memattr.c: Fix common/ includes.
1994         * maint.h: Fix common/ includes.
1995         * maint.c: Fix common/ includes.
1996         * main.c: Fix common/ includes.
1997         * machoread.c: Fix common/ includes.
1998         * location.c: Fix common/ includes.
1999         * linux-thread-db.c: Fix common/ includes.
2000         * linux-nat.c: Fix common/ includes.
2001         * linux-fork.c: Fix common/ includes.
2002         * inline-frame.c: Fix common/ includes.
2003         * infrun.c: Fix common/ includes.
2004         * inflow.c: Fix common/ includes.
2005         * inferior.h: Fix common/ includes.
2006         * inferior.c: Fix common/ includes.
2007         * infcmd.c: Fix common/ includes.
2008         * inf-ptrace.c: Fix common/ includes.
2009         * inf-child.c: Fix common/ includes.
2010         * ia64-linux-nat.c: Fix common/ includes.
2011         * i387-tdep.c: Fix common/ includes.
2012         * i386-tdep.c: Fix common/ includes.
2013         * i386-linux-tdep.c: Fix common/ includes.
2014         * i386-linux-nat.c: Fix common/ includes.
2015         * i386-go32-tdep.c: Fix common/ includes.
2016         * i386-fbsd-tdep.c: Fix common/ includes.
2017         * i386-fbsd-nat.c: Fix common/ includes.
2018         * guile/scm-type.c: Fix common/ includes.
2019         * guile/guile.c: Fix common/ includes.
2020         * go32-nat.c: Fix common/ includes.
2021         * gnu-nat.c: Fix common/ includes.
2022         * gdbthread.h: Fix common/ includes.
2023         * gdbarch-selftests.c: Fix common/ includes.
2024         * gdb_usleep.c: Fix common/ includes.
2025         * gdb_select.h: Fix common/ includes.
2026         * gdb_bfd.c: Fix common/ includes.
2027         * gcore.c: Fix common/ includes.
2028         * fork-child.c: Fix common/ includes.
2029         * findvar.c: Fix common/ includes.
2030         * fbsd-nat.c: Fix common/ includes.
2031         * event-top.c: Fix common/ includes.
2032         * event-loop.c: Fix common/ includes.
2033         * dwarf2read.c: Fix common/ includes.
2034         * dwarf2loc.c: Fix common/ includes.
2035         * dwarf2-frame.c: Fix common/ includes.
2036         * dwarf-index-cache.c: Fix common/ includes.
2037         * dtrace-probe.c: Fix common/ includes.
2038         * disasm-selftests.c: Fix common/ includes.
2039         * defs.h: Fix common/ includes.
2040         * csky-tdep.c: Fix common/ includes.
2041         * cp-valprint.c: Fix common/ includes.
2042         * cp-support.h: Fix common/ includes.
2043         * cp-support.c: Fix common/ includes.
2044         * corelow.c: Fix common/ includes.
2045         * completer.h: Fix common/ includes.
2046         * completer.c: Fix common/ includes.
2047         * compile/compile.c: Fix common/ includes.
2048         * compile/compile-loc2c.c: Fix common/ includes.
2049         * compile/compile-cplus-types.c: Fix common/ includes.
2050         * compile/compile-cplus-symbols.c: Fix common/ includes.
2051         * command.h: Fix common/ includes.
2052         * cli/cli-dump.c: Fix common/ includes.
2053         * cli/cli-cmds.c: Fix common/ includes.
2054         * charset.c: Fix common/ includes.
2055         * build-id.c: Fix common/ includes.
2056         * btrace.h: Fix common/ includes.
2057         * btrace.c: Fix common/ includes.
2058         * breakpoint.h: Fix common/ includes.
2059         * breakpoint.c: Fix common/ includes.
2060         * ax.h:
2061         (enum agent_op): Fix common/ includes.
2062         * ax-general.c (struct aop_map): Fix common/ includes.
2063         * ax-gdb.c: Fix common/ includes.
2064         * auxv.c: Fix common/ includes.
2065         * auto-load.c: Fix common/ includes.
2066         * arm-tdep.c: Fix common/ includes.
2067         * arch/riscv.c: Fix common/ includes.
2068         * arch/ppc-linux-common.c: Fix common/ includes.
2069         * arch/i386.c: Fix common/ includes.
2070         * arch/arm.c: Fix common/ includes.
2071         * arch/arm-linux.c: Fix common/ includes.
2072         * arch/arm-get-next-pcs.c: Fix common/ includes.
2073         * arch/amd64.c: Fix common/ includes.
2074         * arch/aarch64.c: Fix common/ includes.
2075         * arch/aarch64-insn.c: Fix common/ includes.
2076         * arch-utils.c: Fix common/ includes.
2077         * amd64-windows-tdep.c: Fix common/ includes.
2078         * amd64-tdep.c: Fix common/ includes.
2079         * amd64-sol2-tdep.c: Fix common/ includes.
2080         * amd64-obsd-tdep.c: Fix common/ includes.
2081         * amd64-nbsd-tdep.c: Fix common/ includes.
2082         * amd64-linux-tdep.c: Fix common/ includes.
2083         * amd64-linux-nat.c: Fix common/ includes.
2084         * amd64-fbsd-tdep.c: Fix common/ includes.
2085         * amd64-fbsd-nat.c: Fix common/ includes.
2086         * amd64-dicos-tdep.c: Fix common/ includes.
2087         * amd64-darwin-tdep.c: Fix common/ includes.
2088         * agent.c: Fix common/ includes.
2089         * ada-lang.h: Fix common/ includes.
2090         * ada-lang.c: Fix common/ includes.
2091         * aarch64-tdep.c: Fix common/ includes.
2092
2093 2019-01-25  Tom Tromey  <tom@tromey.com>
2094
2095         * common/create-version.sh: Use common/version.h.
2096
2097 2019-01-24  Pedro Alves  <palves@redhat.com>
2098
2099         * infrun.c (signal_stop, signal_print, signal_program)
2100         (signal_catch, signal_pass): Now arrays instead of pointers.
2101         (update_signals_program_target, do_target_resume)
2102         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2103         * linux-nat.c (linux_nat_target::pass_signals)
2104         (linux_nat_target::create_inferior, linux_nat_target::attach):
2105         Adjust.
2106         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2107         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2108         * procfs.c (procfs_target::pass_signals): Adjust.
2109         * record-full.c (record_full_target::resume): Adjust.
2110         * remote.c (remote_target::pass_signals)
2111         (remote_target::program_signals): Adjust.
2112         * target-debug.h (target_debug_print_signals): Now takes a
2113         gdb::array_view as parameter.  Adjust.
2114         * target.h (target_ops) <pass_signals, program_signals>: Replace
2115         pointer and length parameters with gdb::array_view.
2116         (target_pass_signals, target_program_signals): Likewise.
2117         * target-delegates.c: Regenerate.
2118
2119 2019-01-24  Pedro Alves  <palves@redhat.com>
2120
2121         * common/forward-scope-exit.h
2122         (forward_scope_exit::forward_scope_exit): Pass arguments to
2123         m_bind_function directly, instead of creating a std::bind and
2124         copying that.
2125
2126 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2127
2128         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2129         for static members.
2130         (pass_in_v_vfp_candidate): Likewise.
2131
2132 2019-01-23  Tom Tromey  <tom@tromey.com>
2133             Pedro Alves  <palves@redhat.com>
2134
2135         * regcache.c (class regcache_invalidator): Remove.
2136         (regcache::raw_write): Use make_scope_exit.
2137
2138 2019-01-23  Tom Tromey  <tom@tromey.com>
2139
2140         * ui-out.h (class ui_out_emit_type): Update comment.
2141
2142 2019-01-23  Tom Tromey  <tom@tromey.com>
2143
2144         * infrun.c (fetch_inferior_event): Update comment.
2145
2146 2019-01-23  Tom Tromey  <tom@tromey.com>
2147             Pedro Alves  <palves@redhat.com>
2148
2149         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2150         parameter.
2151         (fetch_inferior_event): Use SCOPE_EXIT.
2152
2153
2154 2019-01-23  Tom Tromey  <tom@tromey.com>
2155             Pedro Alves  <palves@redhat.com>
2156
2157         * infrun.c (disable_thread_events): Delete.
2158         (stop_all_threads): Use SCOPE_EXIT.
2159
2160 2019-01-23  Tom Tromey  <tom@tromey.com>
2161             Pedro Alves  <palves@redhat.com>
2162
2163         * symfile.c: Include forward-scope-exit.h.
2164         (clear_symtab_users_cleanup): Replace forward declaration with
2165         a FORWARD_SCOPE_EXIT.
2166         (syms_from_objfile_1): Use the forward_scope_exit and
2167         gdb::optional instead of cleanup_function.
2168         (reread_symbols): Use the forward_scope_exit instead of
2169         cleanup_function.
2170         (clear_symtab_users_cleanup): Remove function.
2171
2172 2019-01-23  Tom Tromey  <tom@tromey.com>
2173             Pedro Alves  <palves@redhat.com>
2174
2175         * linux-nat.c: Include scope-exit.h.
2176         (cleanup_target_stop): Remove.
2177         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2178         SCOPE_EXIT.
2179
2180 2019-01-23  Tom Tromey  <tom@tromey.com>
2181             Pedro Alves  <palves@redhat.com>
2182
2183         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2184         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2185
2186 2019-01-23  Tom Tromey  <tom@tromey.com>
2187             Andrew Burgess  <andrew.burgess@embecosm.com>
2188             Pedro Alves  <palves@redhat.com>
2189
2190         * infrun.c (fetch_inferior_event): Use scope_exit.
2191         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2192         * top.c (execute_command): Use scope_exit.
2193         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2194         * utils.c (do_bpstat_clear_actions_cleanup)
2195         (make_bpstat_clear_actions_cleanup): Remove.
2196
2197 2019-01-23  Tom Tromey  <tom@tromey.com>
2198             Pedro Alves  <palves@redhat.com>
2199
2200         * infrun.c: Include "common/scope-exit.h"
2201         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2202         (wait_for_inferior): Use SCOPE_EXIT.
2203         (fetch_inferior_event): Use scope_exit.
2204
2205 2019-01-23  Tom Tromey  <tom@tromey.com>
2206             Pedro Alves  <palves@redhat.com>
2207
2208         * breakpoint.c (create_breakpoint): Remove cleanup.
2209
2210 2019-01-23  Tom Tromey  <tom@tromey.com>
2211             Andrew Burgess  <andrew.burgess@embecosm.com>
2212             Pedro Alves  <palves@redhat.com>
2213
2214 2019-01-23  Pedro Alves  <palves@redhat.com>
2215
2216         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2217
2218 2019-01-23  Pedro Alves  <palves@redhat.com>
2219             Andrew Burgess  <andrew.burgess@embecosm.com>
2220
2221         * gdbthread.h: Include "common/forward-scope-exit.h".
2222         (scoped_finish_thread_state): Redefine custom class in terms of
2223         forward_scope_exit.
2224
2225 2019-01-23  Pedro Alves  <palves@redhat.com>
2226             Andrew Burgess  <andrew.burgess@embecosm.com>
2227
2228         * common/forward-scope-exit.h: New file.
2229
2230 2019-01-23  Pedro Alves  <palves@redhat.com>
2231             Andrew Burgess  <andrew.burgess@embecosm.com>
2232             Tom Tromey  <tom@tromey.com>
2233
2234         * common/scope-exit.h: New file.
2235
2236 2019-01-23  Pedro Alves  <palves@redhat.com>
2237
2238         * common/preprocessor.h (ESC): Rename to ...
2239         (ESC_PARENS): ... this.
2240         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2241         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2242
2243 2019-01-23  Tom Tromey  <tom@tromey.com>
2244
2245         * language.h (class scoped_switch_to_sym_language_if_auto):
2246         Initialize m_lang in both cases.
2247
2248 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2249
2250         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2251         with XCNEW.
2252
2253 2019-01-22  Tom Tromey  <tom@tromey.com>
2254
2255         * corelow.c: Do not include sys/file.h.
2256
2257 2019-01-22  Tom Tromey  <tom@tromey.com>
2258
2259         * tui/tui-wingeneral.h: Include gdb_curses.h.
2260
2261 2019-01-22  Tom Tromey  <tom@tromey.com>
2262
2263         * source-cache.h (class source_cache) <get_source_lines,
2264         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2265
2266 2019-01-22  Tom Tromey  <tom@tromey.com>
2267
2268         * remote-fileio.h (struct remote_target): Declare.
2269
2270 2019-01-22  Tom Tromey  <tom@tromey.com>
2271
2272         * python/py-arch.c: Do not include py-ref.h.
2273         * python/py-bpevent.c: Do not include py-ref.h.
2274         * python/py-cmd.c: Do not include py-ref.h.
2275         * python/py-continueevent.c: Do not include py-ref.h.
2276         * python/py-event.h: Do not include py-ref.h.
2277         * python/py-evtregistry.c: Do not include py-ref.h.
2278         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2279         * python/py-frame.c: Do not include py-ref.h.
2280         * python/py-framefilter.c: Do not include py-ref.h.
2281         * python/py-function.c: Do not include py-ref.h.
2282         * python/py-infevents.c: Do not include py-ref.h.
2283         * python/py-linetable.c: Do not include py-ref.h.
2284         * python/py-objfile.c: Do not include py-ref.h.
2285         * python/py-param.c: Do not include py-ref.h.
2286         * python/py-prettyprint.c: Do not include py-ref.h.
2287         * python/py-progspace.c: Do not include py-ref.h.
2288         * python/py-symbol.c: Do not include py-ref.h.
2289         * python/py-symtab.c: Do not include py-ref.h.
2290         * python/py-type.c: Do not include py-ref.h.
2291         * python/py-unwind.c: Do not include py-ref.h.
2292         * python/py-utils.c: Do not include py-ref.h.
2293         * python/py-value.c: Do not include py-ref.h.
2294         * python/py-varobj.c: Do not include py-ref.h.
2295         * python/py-xmethods.c: Do not include py-ref.h.
2296         * python/python.c: Do not include py-ref.h.
2297         * varobj.c: Do not include py-ref.h.
2298
2299 2019-01-22  Tom Tromey  <tom@tromey.com>
2300
2301         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2302         keyword for bcache.
2303
2304 2019-01-22  Tom Tromey  <tom@tromey.com>
2305
2306         * compile/compile-cplus-types.c: Remove a comment by #include.
2307
2308 2019-01-22  Tom Tromey  <tom@tromey.com>
2309
2310         * compile/gcc-c-plugin.h: Include compile-internal.h.
2311
2312 2019-01-22  Tom Tromey  <tom@tromey.com>
2313
2314         * stabsread.c (EXTERN): Do not define.
2315         (symnum, next_symbol_text_func, processing_gcc_compilation)
2316         (within_function, global_sym_chain, global_stabs)
2317         (previous_stab_code, this_object_header_files)
2318         (n_this_object_header_files)
2319         (n_allocated_this_object_header_files): Define.
2320         * stabsread.h (EXTERN): Never define.  Use "extern".
2321
2322 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2323
2324         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2325         history_value.
2326
2327 2019-01-21  Tom Tromey  <tom@tromey.com>
2328
2329         * ui-out.c: Fix includes.
2330         * tui/tui-source.c: Fix includes.
2331         * target.c: Fix includes.
2332         * remote.c: Fix includes.
2333         * regcache.c: Fix includes.
2334         * python/py-block.c: Fix includes.
2335         * printcmd.c: Fix includes.
2336         * or1k-tdep.c: Fix includes.
2337         * mi/mi-main.c: Fix includes.
2338         * m32r-tdep.c: Fix includes.
2339         * csky-tdep.c: Fix includes.
2340         * compile/compile-cplus-types.c: Fix includes.
2341         * cli/cli-interp.c: Fix includes.
2342
2343 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2344
2345         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2346         for padding.
2347
2348 2019-01-16  Tom Tromey  <tom@tromey.com>
2349
2350         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2351         earlier.
2352         (struct objfile) <msymbols_range>: Move from top level.
2353         <msymbols>: New method.
2354         (class objfile_msymbols): Remove.
2355         * symtab.c (default_collect_symbol_completion_matches_break_on):
2356         Update.
2357         * symmisc.c (dump_msymbols): Update.
2358         * stabsread.c (scan_file_globals): Update.
2359         * objc-lang.c (info_selectors_command, info_classes_command)
2360         (find_methods): Update.
2361         * minsyms.c (find_solib_trampoline_target): Update.
2362         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2363         * coffread.c (coff_symfile_read): Update.
2364         * ada-lang.c (ada_lookup_simple_minsym)
2365         (ada_collect_symbol_completion_matches): Update.
2366
2367 2019-01-16  Tom Tromey  <tom@tromey.com>
2368
2369         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2370         type.  Remove no-argument constructor.
2371         <iterator::operator++>: Simplify.
2372         <begin>: Update.
2373         <end>: Use minimal_symbol_count.
2374
2375 2019-01-16  Tom Tromey  <tom@tromey.com>
2376
2377         * objfiles.h (struct objfile) <psymtabs>: New method.
2378         (class objfile_psymtabs): Remove.
2379         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2380         typedef.
2381         <range>: New method.
2382         (require_partial_symbols): Change return type.
2383         * psymtab.c (require_partial_symbols)
2384         (psym_expand_symtabs_matching): Update.
2385         * mdebugread.c (parse_partial_symbols): Update.
2386         * dbxread.c (dbx_end_psymtab): Update.
2387
2388 2019-01-15  Tom Tromey  <tom@tromey.com>
2389
2390         * symtab.c (lookup_objfile_from_block)
2391         (lookup_symbol_in_objfile_symtabs)
2392         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2393         (find_line_symtab, info_sources_command)
2394         (default_collect_symbol_completion_matches_break_on)
2395         (make_source_files_completion_list): Update.
2396         * symmisc.c (print_objfile_statistics, dump_objfile)
2397         (maintenance_print_symbols, maintenance_info_symtabs)
2398         (maintenance_check_symtabs, maintenance_info_line_tables):
2399         Update.
2400         * source.c (select_source_symtab)
2401         (forget_cached_source_info_for_objfile): Update.
2402         * objfiles.h (class objfile_compunits): Remove.
2403         (struct objfile) <compunits_range>: New typedef.
2404         (compunits): New method.
2405         * objfiles.c (objfile_relocate1): Update.
2406         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2407         * maint.c (count_symtabs_and_blocks): Update.
2408         * linespec.c (iterate_over_all_matching_symtabs): Update.
2409         * cp-support.c (add_symbol_overload_list_qualified): Update.
2410         * coffread.c (coff_symtab_read): Update.
2411         * ada-lang.c (add_nonlocal_symbols)
2412         (ada_collect_symbol_completion_matches)
2413         (ada_add_global_exceptions): Update.
2414
2415 2019-01-15  Tom Tromey  <tom@tromey.com>
2416
2417         * progspace.h (program_space) <objfiles_safe_range>: New
2418         typedef.
2419         <objfiles_safe>: New method.
2420         * objfiles.h (class all_objfiles_safe): Remove.
2421         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2422         * jit.c (jit_inferior_exit_hook): Update.
2423
2424 2019-01-17  Tom Tromey  <tom@tromey.com>
2425
2426         * progspace.h (program_space) <objfiles_range>: New typedef.
2427         <objfiles>: New method.
2428         <objfiles_head>: Rename from objfiles.
2429         (object_files): Update.
2430         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2431         * guile/scm-pretty-print.c
2432         (ppscm_find_pretty_printer_from_objfiles): Update.
2433         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2434         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2435         Update.
2436         * python/py-progspace.c (pspy_get_objfiles): Update.
2437         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2438         Update.
2439         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2440         (objfpy_lookup_objfile_by_build_id): Update.
2441         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2442         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2443         Update.
2444         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2445         (expand_symtab_containing_pc, lookup_objfile_from_block)
2446         (lookup_static_symbol, basic_lookup_transparent_type)
2447         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2448         (find_line_symtab, info_sources_command)
2449         (default_collect_symbol_completion_matches_break_on)
2450         (make_source_files_completion_list, find_main_name): Update.
2451         * symmisc.c (print_symbol_bcache_statistics)
2452         (print_objfile_statistics, maintenance_print_symbols)
2453         (maintenance_print_msymbols, maintenance_print_objfiles)
2454         (maintenance_info_symtabs, maintenance_check_symtabs)
2455         (maintenance_expand_symtabs, maintenance_info_line_tables):
2456         Update.
2457         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2458         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2459         (map_overlay_command, unmap_overlay_command)
2460         (simple_overlay_update, expand_symtabs_matching)
2461         (map_symbol_filenames): Update.
2462         * symfile-debug.c (set_debug_symfile): Update.
2463         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2464         Update.
2465         * source.c (select_source_symtab, forget_cached_source_info):
2466         Update.
2467         * solib.c (solib_read_symbols): Update.
2468         * solib-spu.c (append_ocl_sos): Update.
2469         * psymtab.c (maintenance_print_psymbols)
2470         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2471         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2472         * printcmd.c (info_symbol_command): Update.
2473         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2474         Update.
2475         * objfiles.h (class all_objfiles): Remove.
2476         * objfiles.c (have_partial_symbols, have_full_symbols)
2477         (have_minimal_symbols, qsort_cmp, update_section_map)
2478         (shared_objfile_contains_address_p)
2479         (default_iterate_over_objfiles_in_search_order): Update.
2480         * objc-lang.c (info_selectors_command, info_classes_command)
2481         (find_methods): Update.
2482         * minsyms.c (find_solib_trampoline_target): Update.
2483         * maint.c (maintenance_info_sections)
2484         (maintenance_translate_address, count_symtabs_and_blocks):
2485         Update.
2486         * main.c (captured_main_1): Update.
2487         * linux-thread-db.c (try_thread_db_load_from_pdir)
2488         (has_libpthread): Update.
2489         * linespec.c (iterate_over_all_matching_symtabs)
2490         (search_minsyms_for_name): Update.
2491         * jit.c (jit_find_objf_with_entry_addr): Update.
2492         * hppa-tdep.c (find_unwind_entry)
2493         (hppa_lookup_stub_minimal_symbol): Update.
2494         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2495         Update.
2496         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2497         (elf_gnu_ifunc_resolve_by_got): Update.
2498         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2499         * dwarf-index-write.c (save_gdb_index_command): Update.
2500         * cp-support.c (add_symbol_overload_list_qualified): Update.
2501         * breakpoint.c (create_overlay_event_breakpoint)
2502         (create_longjmp_master_breakpoint)
2503         (create_std_terminate_master_breakpoint)
2504         (create_exception_master_breakpoint): Update.
2505         * blockframe.c (find_pc_partial_function): Update.
2506         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2507         (ada_collect_symbol_completion_matches)
2508         (ada_add_global_exceptions): Update.
2509
2510 2019-01-17  Tom Tromey  <tom@tromey.com>
2511
2512         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2513         declare VEC.
2514         (solib_target_parse_libraries): Change return type.
2515         (library_list_start_segment, library_list_start_section)
2516         (library_list_end_library, library_list_start_library); Update.
2517         (solib_target_free_library_list): Remove.
2518         (solib_target_parse_libraries): Remove cleanup.  Change return
2519         type.
2520         (solib_target_current_sos): Update.
2521
2522 2019-01-17  Tom Tromey  <tromey@bapiya>
2523
2524         * valprint.c: Replace "the the" with "the".
2525         * symtab.c: Replace "the the" with "the".
2526         * solib.c: Replace "the the" with "the".
2527         * solib-dsbt.c: Replace "the the" with "the".
2528         * linespec.c: Replace "the the" with "the".
2529         * dwarf2loc.h: Replace "the the" with "the".
2530         * amd64-windows-tdep.c: Replace "the the" with "the".
2531         * aarch64-tdep.c: Replace "the the" with "the".
2532
2533 2019-01-16  Keith Seitz  <keiths@redhat.com>
2534
2535         PR gdb/23773
2536         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2537         <builder>: Rename to ..
2538         <m_builder>: ... this and make private.
2539         (dwarf2_cu::get_builder): New method.  Change all users of
2540         `builder' to use this method.
2541         (dwarf2_start_symtab): Move to ...
2542         (dwarf2_cu::start_symtab): ... here.  Update all callers
2543         (setup_type_unit_groups): Move to ...
2544         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2545         callers.
2546         (dwarf2_cu::reset_builder): New method.
2547         (process_full_compunit, process_full_type_unit): Use
2548         dwarf2_cu::reset_builder.
2549         (follow_die_offset): Record the ancestor CU if it is different
2550         from the followed DIE's CU.
2551         (follow_die_sig_1): Likewise.
2552
2553 2019-01-15  Tom Tromey  <tom@tromey.com>
2554
2555         * remote.c (class remote_state) <buf>: Now a char_vector.
2556         <buf_size>: Remove.
2557         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2558         parameter.
2559         (remote_target::getpkt_or_notif_sane_1)
2560         (remote_target::getpkt_sane)
2561         (remote_target::getpkt_or_notif_sane): Likewise.
2562         (class remote_target) <putpkt>: New overload.
2563         (remote_target::read_frame): Change type of "buf_p".  Remove
2564         sizeof_p parameter.
2565         (packet_ok): New overload.
2566         (packet_check_result): New overload.
2567         Update all uses.
2568
2569 2019-01-14  Tom Tromey  <tom@tromey.com>
2570
2571         * remote-notif.c (handle_notification, remote_notif_ack)
2572         (remote_notif_parse): Make "buf" const.
2573         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2574         const.
2575         (remote_notif_parse, remote_notif_ack, handle_notification):
2576         Likewise.
2577         * remote.c (remote_notif_stop_parse): Make "buf" const.
2578         (remote_target::remote_parse_stop_reply): Make "buf" const.
2579         (remote_notif_stop_ack): Make "buf" const.
2580
2581 2019-01-14  Tom Tromey  <tom@tromey.com>
2582
2583         * remote.c (remote_console_output): Make parameter const.
2584
2585 2019-01-14  Tom Tromey  <tom@tromey.com>
2586
2587         * target-debug.h (target_debug_print_signals): Constify.
2588         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2589         * procfs.c (procfs_target::pass_signals): Update.
2590         * linux-nat.c (linux_nat_target::pass_signals): Update.
2591         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2592         * target-delegates.c: Rebuild.
2593         * remote.c (remote_target::program_signals): Update.
2594         (remote_target::pass_signals): Update.
2595         * target.c (target_pass_signals): Constify argument.
2596         (target_program_signals): Likewise.
2597         * target.h (struct target_ops) <pass_signals, program_signals>:
2598         Constify argument.
2599         (target_pass_signals, target_program_signals): Constify argument.
2600
2601 2019-01-14  Tom Tromey  <tom@tromey.com>
2602
2603         PR tui/28819:
2604         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2605
2606 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2607
2608         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2609         field.
2610         * rs6000-tdep.c: Include reggroups.h.
2611         (IS_V_ALIAS_PSEUDOREG): Define.
2612         (rs6000_register_name): Return names for the "vX" aliases.
2613         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2614         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2615         aliases.  Call default_register_reggroup_p for all other
2616         pseudo-registers.
2617         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2618         New functions.
2619         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2620         Handle "vX" aliases.
2621         (v_alias_pseudo_register_collect): New function.
2622         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2623         (rs6000_gdbarch_init): Initialize "vX" aliases as
2624         pseudo-registers.  Restore registration of
2625         rs6000_pseudo_register_reggroup_p with
2626         set_tdesc_pseudo_register_reggroup_p.
2627
2628 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2629
2630         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2631         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2632         set_gdbarch_num_pseudo_regs.
2633
2634 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2635
2636         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2637         Remove arg prefixname, add do_set and do_show.
2638         Add member functions set_list and show_list.
2639         * cli/cli-style.c (class cli_style_option): Update accordingly.
2640         (style_set_list): Move to file scope.
2641         (style_show_list): Likewise.
2642         (set_style): Call help_list.
2643         (show_style): Call cmd_show_list.
2644         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2645         Update to use the new macro.
2646
2647 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2648
2649         * ada-lang.c (_initialize_ada_language): Expand the help text
2650         for the "catch exception" command.
2651
2652 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2653
2654         * symtab.c (matching_obj_sections): Initialize obj,
2655         declare it closer to its usage.
2656
2657 2019-01-10  Tom Tromey  <tom@tromey.com>
2658
2659         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2660         (basic_inf_threads_range): Remove.
2661         (inf_threads_range, inf_non_exited_threads_range)
2662         (safe_inf_threads_range): Use next_adapter.
2663
2664 2019-01-10  Keith Seitz  <keiths@redhat.com>
2665
2666         PR gdb/23712
2667         PR symtab/23010
2668         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2669         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2670
2671 2019-01-10  Keith Seitz  <keiths@redhat.com>
2672
2673         PR gdb/23712
2674         PR symtab/23010
2675         * dictionary.c (pending_to_vector): Remove.
2676         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2677         Remove _1 suffix, replacing functions of the same name.  Update
2678         all callers.
2679         (dict_create_hashed, dict_create_hashed_expandable)
2680         (dict_create_linear, dict_create_linear_expandable, dict_free)
2681         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2682         Make functions static.
2683
2684 2019-01-10  Keith Seitz  <keiths@redhat.com>
2685
2686         PR gdb/23712
2687         PR symtab/23010
2688         * dictionary.h (struct dictionary): Replace declaration with
2689         multidictionary.
2690         (dict_create_hashed, dict_create_hashed_expandable)
2691         (dict_create_linear, dict_create_linear_expandable)
2692         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2693         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2694         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2695         taking multidictionary argument.
2696         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2697         * block.h (struct block) <dict>: Change to multidictionary
2698         and rename `multidict'.
2699         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2700         symmisc.c: Update all dictionary references to multidictionary.
2701
2702 2019-01-10  Keith Seitz  <keiths@redhat.com>
2703
2704         PR gdb/23712
2705         PR symtab/23010
2706         * dictionary.c: Include unordered_map.
2707         (pending_to_vector): New function.
2708         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2709         Rewrite the non-"_1" functions to take vector instead
2710         of linked list.
2711         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2712         "new" _1 versions of the same name.
2713         (multidictionary): Define.
2714         (std::hash<enum language): New definition.
2715         (collate_pending_symbols_by_language, mdict_create_hashed)
2716         (mdict_create_hashed_expandable, mdict_create_linear)
2717         (mdict_create_linear_expandable, mdict_free)
2718         (find_language_dictionary, create_new_language_dictionary)
2719         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2720         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2721         (mdict_size, mdict_empty): New functions.
2722         * dictionary.h (mdict_iterator): Define.
2723
2724 2019-01-10  Pedro Alves  <palves@redhat.com>
2725
2726         * breakpoint.c (read_uploaded_action)
2727         (create_tracepoint_from_upload): Adjust to use
2728         gdb::unique_xmalloc_ptr.
2729         * ctf.c (ctf_write_uploaded_tp):
2730         (SET_ARRAY_FIELD): Use emplace_back.
2731         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2732         * tracefile-tfile.c (tfile_write_uploaded_tp):
2733         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2734         gdb::unique_xmalloc_ptr.
2735         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2736         at_string, cond_string, cmd_strings>: Replace char pointers
2737         with gdb::unique_xmalloc_ptr.
2738
2739 2019-01-10  Pedro Alves  <palves@redhat.com>
2740
2741         * solib-target.c (library_list_start_library): Don't xstrdup name.
2742
2743 2019-01-10  Pedro Alves  <palves@redhat.com>
2744
2745         * mdebugread.c (parse_partial_symbols): Use
2746         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2747
2748 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2749
2750         * linux-fork.c (scoped_switch_fork_info)
2751         <~scoped_switch_fork_info>: Fix incorrect variable name.
2752
2753 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2754
2755         * linux-fork.c (scoped_switch_fork_info)
2756         <scoped_switch_fork_info>: Make explicit.
2757         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2758
2759 2019-01-10  Tom Tromey  <tom@tromey.com>
2760
2761         * objfiles.h (objfile::reset_psymtabs): Update.
2762         * objfiles.c (objfile::objfile): Update.
2763         * psymtab.h (psymtab_storage::obstack): Update.
2764         (psymtab_storage::m_obstack): Use gdb::optional.
2765         (class psymtab_storage): Update comment.  Remove objfile
2766         parameter.
2767         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2768
2769 2019-01-10  Tom Tromey  <tom@tromey.com>
2770
2771         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2772         <free_psymtabs>: Now private.
2773         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2774         (allocate_psymtab): Use new method.
2775
2776 2019-01-10  Tom Tromey  <tom@tromey.com>
2777
2778         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2779         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2780         * mdebugread.c (parse_partial_symbols): Use
2781         allocate_dependencies.
2782         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2783         allocate_dependencies.
2784         (process_psymtab_comp_unit_reader)
2785         (build_type_psymtab_dependencies): Likewise.
2786         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2787
2788 2019-01-10  Tom Tromey  <tom@tromey.com>
2789
2790         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2791         PSYMBOL_SET_LANGUAGE.
2792         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2793
2794 2019-01-10  Tom Tromey  <tom@tromey.com>
2795
2796         * psymtab.h (psymtab_storage::obstack): New method.
2797         <m_obstack>: Rename from obstack; now private.
2798         * psymtab.c (psymtab_storage): Update.
2799         * dwarf2read.c (create_addrmap_from_index)
2800         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2801         Update.
2802
2803 2019-01-10  Tom Tromey  <tom@tromey.com>
2804
2805         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2806         * objfiles.h (objfile::reset_psymtabs): New method.
2807
2808 2019-01-10  Tom Tromey  <tom@tromey.com>
2809
2810         * symmisc.c (print_symbol_bcache_statistics): Update.
2811         (print_objfile_statistics): Update.
2812         * symfile.c (reread_symbols): Update.
2813         * psymtab.h (class psymtab_storage): New.
2814         * psymtab.c (psymtab_storage): New constructor.
2815         (~psymtab_storage): New destructor.
2816         (require_partial_symbols): Update.
2817         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2818         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2819         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2820         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2821         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2822         (start_psymtab_common, end_psymtab_common)
2823         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2824         (allocate_psymtab): Update.
2825         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2826         Update.
2827         (dump_psymtab_addrmap, maintenance_print_psymbols)
2828         (maintenance_check_psymtabs): Update.
2829         (class objfile_psymtabs): Move to objfiles.h.
2830         * psympriv.h (discard_psymtab): Now inline.
2831         (psymtab_discarder::psymtab_discarder): Update.
2832         (psymtab_discarder::~psymtab_discarder): Update.
2833         (ALL_OBJFILE_PSYMTABS): Rewrite.
2834         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2835         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2836         Remove fields.
2837         <partial_symtabs>: New field.
2838         (class objfile_psymtabs): Move from psymtab.h.  Update.
2839         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2840         psymbol_cache.
2841         (objfile::~objfile): Don't destroy psymbol_cache.
2842         * mdebugread.c (parse_partial_symbols): Update.
2843         * dwarf2read.c (create_addrmap_from_index)
2844         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2845         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2846         (add_partial_subprogram, dwarf2_ranges_read): Update.
2847         * dwarf-index-write.c (write_address_map)
2848         (write_one_signatured_type, recursively_write_psymbols)
2849         (class debug_names, class debug_names, write_psymtabs_to_index):
2850         Update.
2851
2852 2019-01-10  Tom Tromey  <tom@tromey.com>
2853
2854         * symtab.h (SYMBOL_SET_NAMES): Update.
2855         (symbol_set_names): Update.
2856         (MSYMBOL_SET_NAMES): Update.
2857         * symtab.c (symbol_set_names): Change argument to be an
2858         objfile_per_bfd_storage.
2859         * psymtab.c (add_psymbol_to_bcache): Update.
2860         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2861
2862 2019-01-10  Tom Tromey  <tom@tromey.com>
2863
2864         * symtab.c (create_demangled_names_hash): Change argument to be an
2865         objfile_per_bfd_storage.
2866         (symbol_set_names): Update.
2867
2868 2019-01-10  Tom Tromey  <tom@tromey.com>
2869
2870         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2871         init_psymbol_list.
2872         * psymtab.c (init_psymbol_list): Do nothing if already called.
2873         * psympriv.h (init_psymbol_list): Add comment.
2874         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2875         init_psymbol_list.
2876         * dbxread.c (dbx_symfile_read): Unconditionally call
2877         init_psymbol_list.
2878
2879 2019-01-10  Tom Tromey  <tom@tromey.com>
2880
2881         * xcoffread.c (scan_xcoff_symtab): Update.
2882         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2883         "where".
2884         * mdebugread.c (parse_partial_symbols)
2885         (handle_psymbol_enumerators): Update.
2886         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2887         * dbxread.c (read_dbx_symtab): Update.
2888         * psympriv.h (psymbol_placement): New enum.
2889         (add_psymbol_to_list): Update.
2890
2891 2019-01-10  Tom Tromey  <tom@tromey.com>
2892
2893         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2894         static_psymbols parameters.
2895         (scan_xcoff_symtab): Update.
2896         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2897         static_psymbols parameters.
2898         * psympriv.h (start_psymtab_common): Update.
2899         * mdebugread.c (parse_partial_symbols): Update.
2900         * dwarf2read.c (create_partial_symtab): Update.
2901         * dbxread.c (read_dbx_symtab): Update.
2902         (start_psymtab): Remove global_psymbols and static_psymbols
2903         parameters.
2904
2905 2019-01-10  Tom Tromey  <tom@tromey.com>
2906
2907         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2908         * psymtab.c (allocate_psymtab): Add comment.
2909         * psympriv.h (allocate_psymtab): Add comment.
2910         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2911         initializations.
2912         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2913
2914 2019-01-10  Tom Tromey  <tom@tromey.com>
2915
2916         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2917         Don't declare.
2918         * mipsread.c: Include mdebugread.h.
2919         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2920         Declare.
2921         * elfread.c: Include mdebugread.h.
2922
2923 2019-01-09  Tom Tromey  <tom@tromey.com>
2924
2925         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2926         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2927         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2928         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2929         (psym_lookup_symbol, psym_find_last_source_symtab)
2930         (psym_forget_cached_source_info, psym_print_stats)
2931         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2932         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2933         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2934         (psym_find_compunit_symtab_by_address)
2935         (maintenance_print_psymbols, maintenance_info_psymtabs)
2936         (maintenance_check_psymtabs): Use ranged for.
2937         * psymtab.h (class objfile_psymtabs): New.
2938         (require_partial_symbols): Return objfile_psymtabs.
2939         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2940
2941 2019-01-09  Tom Tromey  <tom@tromey.com>
2942
2943         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2944         (find_pc_mapped_section, list_overlays_command)
2945         (map_overlay_command, unmap_overlay_command)
2946         (simple_overlay_update): Use all_objfiles.
2947         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2948         * printcmd.c (info_symbol_command): Use all_objfiles.
2949         * objfiles.h (ALL_OBJSECTIONS): Remove.
2950         * maint.c (maintenance_translate_address): Use all_objfiles.
2951         * gcore.c (gcore_create_callback): Use all_objfiles.
2952         (objfile_find_memory_regions): Likewise.
2953
2954 2019-01-09  Tom Tromey  <tom@tromey.com>
2955
2956         * symtab.c (find_line_symtab, info_sources_command)
2957         (make_source_files_completion_list): Use objfile_compunits.
2958         * source.c (select_source_symtab): Use objfile_compunits.
2959         * objfiles.h (struct objfile): Update comment.
2960         (ALL_OBJFILES): Remove.
2961         (ALL_FILETABS): Remove.
2962         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2963         objfile_compunits.
2964
2965 2019-01-09  Tom Tromey  <tom@tromey.com>
2966
2967         * symmisc.c (print_objfile_statistics, dump_objfile)
2968         (maintenance_print_symbols): Use compunit_filetabs.
2969         * source.c (forget_cached_source_info_for_objfile): Use
2970         compunit_filetabs.
2971         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2972         (ALL_FILETABS): Use compunit_filetabs.
2973         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2974         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2975
2976 2019-01-09  Tom Tromey  <tom@tromey.com>
2977
2978         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2979         (compunit_filetabs): New.
2980         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2981         compunit_filetabs.
2982         (info_sources_command, make_source_files_completion_list): Remove
2983         declaration.
2984         * symmisc.c (print_objfile_statistics, dump_objfile)
2985         (maintenance_print_symbols): Remove declaration.
2986         (maintenance_info_symtabs): Use compunit_filetabs.
2987         (maintenance_info_line_tables): Likewise.
2988         * source.c (select_source_symtab): Change local variable name.
2989         (forget_cached_source_info_for_objfile): Remove declaration.
2990         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2991         * objfiles.c (objfile_relocate1): Remove declaration.
2992         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2993         declaration.
2994         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2995         * coffread.c (coff_symtab_read): Remove declaration.
2996         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2997         compunit_filetabs.
2998
2999 2019-01-09  Tom Tromey  <tom@tromey.com>
3000
3001         * symtab.c (lookup_objfile_from_block)
3002         (find_pc_sect_compunit_symtab, search_symbols)
3003         (default_collect_symbol_completion_matches_break_on): Use
3004         objfile_compunits.
3005         * objfiles.h (ALL_COMPUNITS): Remove.
3006         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3007         * cp-support.c (add_symbol_overload_list_qualified): Use
3008         objfile_compunits.
3009         * ada-lang.c (ada_collect_symbol_completion_matches)
3010         (ada_add_global_exceptions): Use objfile_compunits.
3011
3012 2019-01-09  Tom Tromey  <tom@tromey.com>
3013
3014         * source.c (select_source_symtab)
3015         (forget_cached_source_info_for_objfile): Remove declaration.
3016         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3017         declaration.
3018         * maint.c (count_symtabs_and_blocks): Remove declaration.
3019         * cp-support.c (add_symbol_overload_list_qualified): Remove
3020         declaration.
3021         * coffread.c (coff_symtab_read): Remove declaration.
3022         * symtab.c (lookup_symbol_in_objfile_symtabs)
3023         (basic_lookup_transparent_type_1): Use objfile_compunits.
3024         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3025         (info_sources_command, search_symbols)
3026         (default_collect_symbol_completion_matches_break_on)
3027         (make_source_files_completion_list): Remove declaration.
3028         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3029         (ada_collect_symbol_completion_matches)
3030         (ada_add_global_exceptions): Remove declaration.
3031         * linespec.c (iterate_over_all_matching_symtabs): Use
3032         objfile_compunits.
3033         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3034         (class objfile_compunits): New.
3035         (ALL_COMPUNITS): Use objfile_compunits.
3036         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3037         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3038         objfile_compunits.
3039         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3040
3041 2019-01-09  Tom Tromey  <tom@tromey.com>
3042
3043         * symtab.c (search_symbols)
3044         (default_collect_symbol_completion_matches_break_on): Use
3045         objfile_msymbols.
3046         * ada-lang.c (ada_lookup_simple_minsym)
3047         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3048         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3049         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3050         objfile_msymbols.
3051         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3052         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3053         * objc-lang.c (find_methods): Use objfile_msymbols.
3054         (info_selectors_command, info_classes_command): Likewise.
3055         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3056         * objfiles.h (class objfile_msymbols): New.
3057         (ALL_OBJFILE_MSYMBOLS): Remove.
3058         (ALL_MSYMBOLS): Remove.
3059
3060 2019-01-09  Tom Tromey  <tom@tromey.com>
3061
3062         * common/next-iterator.h (next_adapter): Add Iterator template
3063         parameter.
3064         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3065         (class all_objfiles_safe): New.
3066         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3067         * objfiles.c (put_objfile_before): Update comment.
3068         (add_separate_debug_objfile): Likewise.
3069         (free_all_objfiles): Use all_objfiles_safe.
3070         (objfile_purge_solibs): Likewise.
3071
3072 2019-01-09  Tom Tromey  <tom@tromey.com>
3073
3074         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3075         (expand_symtab_containing_pc, lookup_static_symbol)
3076         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3077         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3078         all_objfiles.
3079         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3080         * breakpoint.c (create_overlay_event_breakpoint)
3081         (create_longjmp_master_breakpoint)
3082         (create_std_terminate_master_breakpoint)
3083         (create_exception_master_breakpoint): Use all_objfiles.
3084         * linux-thread-db.c (try_thread_db_load_from_pdir)
3085         (has_libpthread): Use all_objfiles.
3086         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3087         * linespec.c (iterate_over_all_matching_symtabs)
3088         (search_minsyms_for_name): Use all_objfiles.
3089         * maint.c (maintenance_info_sections): Use all_objfiles.
3090         * main.c (captured_main_1): Use all_objfiles.
3091         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3092         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3093         * guile/scm-pretty-print.c
3094         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3095         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3096         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3097         (maintenance_print_msymbols): Use all_objfiles.
3098         * source.c (select_source_symtab): Use all_objfiles.
3099         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3100         * symfile.c (remove_symbol_file_command)
3101         (expand_symtabs_matching, map_symbol_filenames): Use
3102         all_objfiles.
3103         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3104         all_objfiles.
3105         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3106         * objc-lang.c (find_methods): Use all_objfiles.
3107         * objfiles.c (have_partial_symbols, have_full_symbols)
3108         (have_minimal_symbols, qsort_cmp)
3109         (default_iterate_over_objfiles_in_search_order): Use
3110         all_objfiles.
3111         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3112         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3113         (maintenance_check_psymtabs): Use all_objfiles.
3114         (ALL_PSYMTABS): Remove.
3115         * compile/compile-object-run.c (do_module_cleanup): Use
3116         all_objfiles.
3117         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3118         * cp-support.c (add_symbol_overload_list_qualified): Use
3119         all_objfiles.
3120         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3121         Use all_objfiles.
3122         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3123         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3124         all_objfiles.
3125         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3126         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3127         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3128         Uses all_objfiles.
3129         * solib.c (solib_read_symbols): Use all_objfiles
3130
3131 2019-01-09  Tom Tromey  <tom@tromey.com>
3132
3133         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3134         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3135         all_objfiles.
3136         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3137         * symmisc.c (print_symbol_bcache_statistics)
3138         (print_objfile_statistics, maintenance_print_objfiles)
3139         (maintenance_info_symtabs, maintenance_check_symtabs)
3140         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3141         all_objfiles.
3142         * source.c (forget_cached_source_info): Use all_objfiles.
3143         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3144         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3145         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3146         * objfiles.c (update_section_map): Use all_objfiles.
3147         (shared_objfile_contains_address_p): Likewise.
3148         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3149         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3150
3151 2019-01-09  Tom Tromey  <tom@tromey.com>
3152
3153         * common/next-iterator.h: New file.
3154         * objfiles.h (class all_objfiles): New.
3155         (struct objfile_iterator): New.
3156
3157 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3158
3159         * NEWS: Move the description of the changed "frame", "select-frame",
3160          and "info frame" commands to the Changed commands section.
3161
3162 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3163
3164         * gdbtypes.c (check_stub_method_group): Remove handling of old
3165         mangling schemes.
3166         * linespec.c (find_methods): Likewise.
3167         * stabsread.c (read_member_functions): Likewise.
3168         * valops.c (search_struct_method): Likewise.
3169         (value_struct_elt_for_reference): Likewise.
3170         * NEWS: Mention this change.
3171
3172 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3173
3174         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3175         print_source_lines.
3176         * source.c (print_source_lines_base): Update line number check.
3177         (print_source_lines): New function.
3178         (source_lines_range::source_lines_range): New function.
3179         * source.h (class source_lines_range): New class.
3180         (print_source_lines): New declaration.
3181
3182 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3183
3184         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3185
3186 2019-01-08  Tom Tromey  <tom@tromey.com>
3187             Simon Marchi  <simon.marchi@ericsson.com>
3188
3189         PR gdb/24060
3190         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3191         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3192         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3193         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3194         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3195         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3196
3197 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3198
3199         * source.c (select_source_symtab): Move header comment to
3200         declaration in source.h.
3201         (forget_cached_source_info_for_objfile): Likewise.
3202         (forget_cached_source_info): Likewise.
3203         (identify_source_line): Likewise.
3204         * source.h (identify_source_line): Move declaration from symtab.h
3205         and add comment from source.c
3206         (print_source_lines): Likewise.
3207         (forget_cached_source_info_for_objfile): Likewise.
3208         (forget_cached_source_info): Likewise.
3209         (select_source_symtab): Likewise.
3210         (enum print_source_lines_flag): Move definition from symtab.h.
3211         * symtab.h (identify_source_line): Move declaration to source.h.
3212         (print_source_lines): Likewise.
3213         (forget_cached_source_info_for_objfile): Likewise.
3214         (forget_cached_source_info): Likewise.
3215         (select_source_symtab): Likewise.
3216         (enum print_source_lines_flag): Move definition to source.h.
3217         * tui/tui-hooks.c: Add 'source.h' include.
3218
3219 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3220
3221         * source.c (print_source_lines_base): Handle requests to print
3222         reverse line number sequences, and guard against empty lines
3223         string.
3224
3225 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3226
3227         * source.c (print_source_lines_base): Fix skip of '\r' if next
3228         character is '\n'.
3229
3230 2019-01-06  Tom Tromey  <tom@tromey.com>
3231
3232         * c-exp.y (struct c_parse_state) <macro_original_text,
3233         expansion_obstack>: New member.
3234         (macro_original_text, expansion_obstack): Remove globals.
3235         (scan_macro_expansion, scanning_macro_expansion)
3236         (finished_macro_expansion): Update.
3237         (scan_macro_cleanup): Remove.
3238         (yylex, c_parse): Update.
3239
3240 2019-01-06  Tom Tromey  <tom@tromey.com>
3241
3242         * c-exp.y (struct c_parse_state) <strings>: New member.
3243         (operator_stoken): Update.
3244
3245 2019-01-06  Tom Tromey  <tom@tromey.com>
3246
3247         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3248         (union type_stack_elt) <typelist_val>: Now a pointer to
3249         std::vector.
3250         (type_stack_cleanup): Don't declare.
3251         (push_typelist): Update.
3252         * parse.c (pop_typelist): Return a std::vector.
3253         (push_typelist): Take a std::vector.
3254         (follow_types): Update.  Do not free args.
3255         (type_stack_cleanup): Remove.
3256         * c-exp.y (struct c_parse_state): New.
3257         (cpstate): New global.
3258         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3259         (nonempty_typelist): Update.
3260         (func_mod): Create a new vector.
3261         (c_parse): Create a c_parse_state.
3262         (check_parameter_typelist): Do not delete params.
3263         (function_method): Update.  Do not delete type_list.
3264
3265 2019-01-06  Tom Tromey  <tom@tromey.com>
3266
3267         PR gdb/28155:
3268         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3269         check_typedef.
3270         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3271         (print_return_value): Likewise.
3272
3273 2019-01-05  Tom Tromey  <tom@tromey.com>
3274
3275         * contrib/cleanup_check.py: Remove.
3276         * contrib/gcc-with-excheck: Remove.
3277         * contrib/exsummary.py: Remove.
3278         * contrib/excheck.py: Remove.
3279
3280 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3281
3282         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3283         NULL. Initialize tpprev to NULL instead of assigning it
3284         to NULL on the next statement.
3285         * windows-nat.c (windows_delete_thread): Remove check for
3286         main_thread_id before printing thread exit notifications.
3287         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3288         Remove thread ID check against main_thread_id.
3289         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3290         windows_delete_thread.
3291         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3292
3293 2019-01-04  Tom Tromey  <tom@tromey.com>
3294
3295         * compile/compile.c (_initialize_compile): Use upper case for
3296         metasyntactic variables.
3297         * symmisc.c (_initialize_symmisc): Use upper case for
3298         metasyntactic variables.
3299         * psymtab.c (_initialize_psymtab): Use upper case for
3300         metasyntactic variables.
3301         * demangle.c (demangle_command): Use upper case for metasyntactic
3302         variables.
3303         (_initialize_demangler): Likewise.
3304         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3305         variables.
3306
3307 2019-01-03  Tom Tromey  <tom@tromey.com>
3308
3309         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3310
3311 2019-01-03  Tom Tromey  <tom@tromey.com>
3312
3313         * python/py-symtab.c (salpy_str): Update.
3314         (struct salpy_sal_object) <symtab>: Now a PyObject.
3315         (salpy_dealloc): Update.
3316         (del_objfile_sal): Use gdbpy_ref.
3317
3318 2019-01-03  Tom Tromey  <tom@tromey.com>
3319
3320         * python/py-type.c (convert_field): Use new_reference.  Return
3321         gdbpy_ref.
3322         (make_fielditem): Return gdbpy_ref.
3323         (typy_fields): Update.
3324         (typy_getitem): Update.
3325         (field_name): Return gdbpy_ref.  Use new_reference.
3326         (typy_iterator_iternext): Update.
3327
3328 2019-01-03  Tom Tromey  <tom@tromey.com>
3329
3330         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3331
3332 2019-01-03  Tom Tromey  <tom@tromey.com>
3333
3334         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3335         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3336         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3337         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3338         (pspy_set_type_printers): Likewise.
3339         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3340         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3341         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3342         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3343         (objfpy_set_type_printers): Likewise.
3344
3345 2019-01-03  Tom Tromey  <tom@tromey.com>
3346
3347         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3348         (gdbpy_print_stack): Use gdbpy_err_fetch.
3349         * python/python-internal.h (class gdbpy_err_fetch): New class.
3350         (class gdbpy_enter) <m_error_type, m_error_value,
3351         m_error_traceback>: Remove.
3352         <m_error>: New member.
3353         (gdbpy_exception_to_string): Don't declare.
3354         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3355         * python/py-value.c (convert_value_from_python): Use
3356         gdbpy_err_fetch.
3357         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3358         gdbpy_exception_to_string.
3359         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3360         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3361         gdbpy_err_fetch.
3362
3363 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3364
3365         * linux-nat.c (delete_lwp_cleanup): Delete.
3366         (struct lwp_deleter): New struct.
3367         (lwp_info_up): New typedef.
3368         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3369         lwp_info_up.
3370
3371 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3372
3373         * linux-fork.c (class scoped_switch_fork_info): New class.
3374         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3375
3376 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3377
3378         * valops.c (find_overload_match): Remove use of null_cleanup, and
3379         calls to do_cleanups.
3380
3381 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3382
3383         * compile/compile-cplus-types.c
3384         (compile_cplus_instance::decl_name): Handle changes to
3385         cp_func_name.
3386         * cp-support.c (cp_func_name): Update header comment, update
3387         return type.
3388         * cp-support.h (cp_func_name): Update return type in declaration.
3389         * valops.c (find_overload_match): Move temp_func local to top
3390         level of function and change its type.  Use temp_func to hold and
3391         delete temporary string obtained from cp_func_name.
3392
3393 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3394
3395         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3396         gdb::char_vector, remove cleanup, and update uses of `msg`.
3397
3398 2019-01-03  Jim Wilson  <jimw@sifive.com>
3399
3400         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3401
3402 2019-01-02  Tom Tromey  <tom@tromey.com>
3403
3404         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3405         (tdesc_parse_xml): Remove cleanups.
3406         * target-descriptions.h (make_cleanup_free_target_description):
3407         Don't declare.
3408         (target_desc_deleter): New struct.
3409         (target_desc_up): New typedef.
3410         * target-descriptions.c (target_desc_deleter::operator()): Rename
3411         from free_target_description.
3412         (make_cleanup_free_target_description): Remove.
3413
3414 2019-01-02  Tom Tromey  <tom@tromey.com>
3415
3416         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3417         constructor, destructor.
3418         (linespec_parser): Remove typedef.
3419         (~linespec_parser): Rename from linespec_parser_delete.
3420         (linespec_lex_to_end, linespec_complete_label)
3421         (linespec_complete): Update.
3422         (decode_line_full): Remove cleanups.
3423         (decode_line_1): Update.
3424
3425 2019-01-02  Tom Tromey  <tom@tromey.com>
3426
3427         * python/python-internal.h (inferior_to_inferior_object): Change
3428         return type.
3429         * python/py-exitedevent.c (create_exited_event_object): Update.
3430         * python/py-inferior.c (inferior_to_inferior_object): Return
3431         gdbpy_ref.
3432         (python_new_inferior, python_inferior_deleted)
3433         (thread_to_thread_object, delete_thread_object)
3434         (build_inferior_list, gdbpy_selected_inferior): Update.
3435         * python/py-infthread.c (create_thread_object): Update.  Also fail
3436         if inferior_to_inferior_object fails.
3437
3438 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3439
3440         * inferior.h (class inferior) <displaced_step_state>: New field.
3441         * infrun.h (struct displaced_step_state): Move here from
3442         infrun.c.  Initialize fields, add constructor.
3443         <inf>: Remove field.
3444         <reset>: New method.
3445         * infrun.c (struct displaced_step_inferior_state): Move to
3446         infrun.h.
3447         (displaced_step_inferior_states): Remove.
3448         (get_displaced_stepping_state): Adust.
3449         (displaced_step_in_progress_any_inferior): Adjust.
3450         (displaced_step_in_progress_thread): Adjust.
3451         (displaced_step_in_progress): Adjust.
3452         (add_displaced_stepping_state): Remove.
3453         (get_displaced_step_closure_by_addr): Adjust.
3454         (remove_displaced_stepping_state): Remove.
3455         (infrun_inferior_exit): Call displaced_step_state.reset.
3456         (use_displaced_stepping): Don't check for NULL.
3457         (displaced_step_prepare_throw): Call
3458         get_displaced_stepping_state.
3459         (displaced_step_fixup): Don't check for NULL.
3460         (prepare_for_detach): Don't check for NULL.
3461
3462 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3463
3464         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3465          in case of call that did not complete.
3466
3467 2019-01-02  Andrey Utkin  <autkin@undo.io>
3468
3469         * symfile.c (find_separate_debug_file): Fix search of debug files for
3470         remote debuggee.
3471
3472 2019-01-02  Tom Tromey  <tom@tromey.com>
3473
3474         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3475         indentation.
3476         * python/py-frame.c (frapy_older): Remove cast.
3477         (frapy_newer): Likewise.
3478         * python/py-breakpoint.c (local_setattro): Remove cast.
3479         * python/py-arch.c (archpy_name): Remove local variable.
3480         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3481
3482 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3483
3484         * unittests/basic_string_view/element_access/char/empty.cc:
3485         Fix year range in copyright header.
3486
3487 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3488
3489         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3490         Delete.
3491         <operator==>: Update with for removed field.
3492         <hash>: Likewise.
3493         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3494         <isa_features>: ...this.
3495         <abi_features>: New field.
3496         (riscv_isa_flen): Update comment.
3497         (riscv_abi_xlen): New declaration.
3498         (riscv_abi_flen): New declaration.
3499         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3500         isa_features.
3501         (riscv_abi_xlen): New function.
3502         (riscv_isa_flen): Update to get answer from isa_features.
3503         (riscv_abi_flen): New function.
3504         (riscv_has_fp_abi): Update to get answer from abi_features.
3505         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3506         xlen and flen.
3507         (riscv_call_info) <xlen, flen>: Update comment.
3508         (riscv_call_arg_struct): Remove invalid assertions
3509         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3510         is removed.
3511         (riscv_gdbarch_init): Gather isa features and abi features
3512         separately, ensure both match on the gdbarch when reusing an old
3513         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3514         a target with 64-bit float hardware.
3515
3516 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3517
3518         * source.c (search_command_helper): Stop reverse search
3519         when line 1 has been searched.
3520
3521 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3522
3523         * record-full.c (record_full_base_target::close): Rewrite
3524         record_full_core_buf_list free logic.
3525
3526 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3527
3528         * break-catch-syscall.c (print_one_catch_syscall): xfree
3529         the last text.
3530
3531 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3532
3533         * top.c (print_gdb_version): Update Copyright year in version
3534         message.
3535
3536 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3537
3538         Update copyright year range in all GDB files.
3539
3540 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3541
3542         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3543
3544 For older changes see ChangeLog-2018.
3545 \f
3546 Local Variables:
3547 mode: change-log
3548 left-margin: 8
3549 fill-column: 74
3550 version-control: never
3551 coding: utf-8
3552 End:
3553