Introduce target_ops method thread_info_to_thread_handle
[external/binutils.git] / gdb / ChangeLog
1 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2
3         * gdbthread.h (thread_to_thread_handle): Declare.
4         * thread.c (gdbtypes.h): Include.
5         (thread_to_thread_handle): New function.
6
7         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8         (target_thread_info_to_thread_handle): Declare.
9         * target.c (target_thread_info_to_thread_handle): New function.
10         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11         * target-delegates.c: Regenerate.
12
13         * linux-thread-db.c (class thread_db_target): Add method
14         thread_info_to_thread_handle.
15         (thread_db_target::thread_info_to_thread_handle): Define.
16         * remote.c (class remote_target): Add new method
17         thread_info_to_thread_handle.
18         (remote_target::thread_info_to_thread_handle): Define.
19
20 2019-04-08  Pedro Alves  <palves@redhat.com>
21
22         * common/common-exceptions.c (throw_exception): Don't create
23         named object to throw; throw directly.
24         (throw_it): Likewise.  Don't initialize gdb_exception::message
25         here, with new; pass FMT and AP to the ctor instead.
26         * common/common-exceptions.h: Include <string>.
27         (gdb_exception::gdb_exception(enum return_reason, enum errors,
28         const char *, va_list)): New ctor.  Use std::make_shared.
29         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
30         errors)): Delete.
31         (gdb_exception_error::gdb_exception_error(enum errors, const char
32         *, va_list)): New.
33         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
34         Add assertion.
35         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
36         errors)): Delete.
37         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
38         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
39         Add assertion.
40
41 2019-04-08  Tom Tromey  <tom@tromey.com>
42
43         * valops.c (value_rtti_indirect_type): Replace throw_exception
44         with throw.
45         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
46         with throw.
47         * thread.c (thr_try_catch_cmd): Replace throw_exception with
48         throw.
49         * target.c (target_translate_tls_address): Replace throw_exception
50         with throw.
51         * stack.c (frame_apply_command_count): Replace throw_exception
52         with throw.
53         * solib-spu.c (append_ocl_sos): Replace throw_exception with
54         throw.
55         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
56         with throw.
57         * rs6000-tdep.c (rs6000_frame_cache)
58         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
59         * remote.c: Replace throw_exception with throw.
60         * record-full.c (record_full_message, record_full_wait_1)
61         (record_full_restore): Replace throw_exception with throw.
62         * record-btrace.c:
63         (get_thread_current_frame_id, record_btrace_start_replaying)
64         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
65         (cmd_record_btrace_start): Replace throw_exception with throw.
66         * parse.c (parse_exp_in_context_1): Replace throw_exception with
67         throw.
68         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
69         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
70         * linespec.c:
71         (find_linespec_symbols): Replace throw_exception with throw.
72         * infrun.c (displaced_step_prepare, resume): Replace
73         throw_exception with throw.
74         * infcmd.c (post_create_inferior): Replace throw_exception with
75         throw.
76         * inf-loop.c (inferior_event_handler): Replace throw_exception
77         with throw.
78         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
79         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
80         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
81         (get_prev_frame_always, get_frame_pc_if_available)
82         (get_frame_address_in_block_if_available, get_frame_language):
83         Replace throw_exception with throw.
84         * frame-unwind.c (frame_unwind_try_unwinder): Replace
85         throw_exception with throw.
86         * eval.c (fetch_subexp_value, evaluate_var_value)
87         (evaluate_funcall, evaluate_subexp_standard): Replace
88         throw_exception with throw.
89         * dwarf2loc.c (call_site_find_chain)
90         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
91         Replace throw_exception with throw.
92         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
93         with throw.
94         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
95         throw.
96         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
97         * completer.c (complete_line_internal): Replace throw_exception
98         with throw.
99         * compile/compile-object-run.c (compile_object_run): Replace
100         throw_exception with throw.
101         * cli/cli-script.c (process_next_line): Replace throw_exception
102         with throw.
103         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
104         (btrace_enable, btrace_maint_update_pt_packets): Replace
105         throw_exception with throw.
106         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
107         throw_exception with throw.
108         * break-catch-throw.c (re_set_exception_catchpoint): Replace
109         throw_exception with throw.
110         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
111         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
112         * aarch64-tdep.c (aarch64_make_prologue_cache)
113         (aarch64_make_stub_cache): Replace throw_exception with throw.
114
115 2019-04-08  Tom Tromey  <tom@tromey.com>
116
117         * common/common-exceptions.c (throw_exception): Rename from
118         throw_exception_cxx.  Remove old copy.  Make argument const.
119         (throw_it): Create and throw exception objects directly.
120         * common/common-exceptions.h (throw_exception): Make argument
121         const.
122         (struct gdb_exception_error): Add constructor.
123         (struct gdb_exception_quit): Add constructor.
124
125 2019-04-08  Tom Tromey  <tom@tromey.com>
126
127         * common/common-exceptions.h (exception_rethrow): Don't declare.
128         (TRY_SJLJ): Update comment.
129         (TRY, CATCH, END_CATCH): Remove.
130         * common/common-exceptions.c (exception_rethrow): Remove.
131
132 2019-04-08  Tom Tromey  <tom@tromey.com>
133
134         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
135         Remove.
136         (gdb_exception_error): Rename from
137         gdb_exception_RETURN_MASK_ERROR.
138         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
139         (gdb_quit_bad_alloc): Update.
140         * aarch64-tdep.c: Update.
141         * ada-lang.c: Update.
142         * ada-typeprint.c: Update.
143         * ada-valprint.c: Update.
144         * amd64-tdep.c: Update.
145         * arch-utils.c: Update.
146         * break-catch-throw.c: Update.
147         * breakpoint.c: Update.
148         * btrace.c: Update.
149         * c-varobj.c: Update.
150         * cli/cli-cmds.c: Update.
151         * cli/cli-interp.c: Update.
152         * cli/cli-script.c: Update.
153         * common/common-exceptions.c: Update.
154         * common/new-op.c: Update.
155         * common/selftest.c: Update.
156         * compile/compile-c-symbols.c: Update.
157         * compile/compile-cplus-symbols.c: Update.
158         * compile/compile-object-load.c: Update.
159         * compile/compile-object-run.c: Update.
160         * completer.c: Update.
161         * corelow.c: Update.
162         * cp-abi.c: Update.
163         * cp-support.c: Update.
164         * cp-valprint.c: Update.
165         * darwin-nat.c: Update.
166         * disasm-selftests.c: Update.
167         * dtrace-probe.c: Update.
168         * dwarf-index-cache.c: Update.
169         * dwarf-index-write.c: Update.
170         * dwarf2-frame-tailcall.c: Update.
171         * dwarf2-frame.c: Update.
172         * dwarf2loc.c: Update.
173         * dwarf2read.c: Update.
174         * eval.c: Update.
175         * event-loop.c: Update.
176         * event-top.c: Update.
177         * exec.c: Update.
178         * f-valprint.c: Update.
179         * fbsd-tdep.c: Update.
180         * frame-unwind.c: Update.
181         * frame.c: Update.
182         * gdbtypes.c: Update.
183         * gnu-v3-abi.c: Update.
184         * guile/guile-internal.h: Update.
185         * guile/scm-block.c: Update.
186         * guile/scm-breakpoint.c: Update.
187         * guile/scm-cmd.c: Update.
188         * guile/scm-disasm.c: Update.
189         * guile/scm-frame.c: Update.
190         * guile/scm-lazy-string.c: Update.
191         * guile/scm-math.c: Update.
192         * guile/scm-param.c: Update.
193         * guile/scm-ports.c: Update.
194         * guile/scm-pretty-print.c: Update.
195         * guile/scm-symbol.c: Update.
196         * guile/scm-symtab.c: Update.
197         * guile/scm-type.c: Update.
198         * guile/scm-value.c: Update.
199         * i386-linux-tdep.c: Update.
200         * i386-tdep.c: Update.
201         * inf-loop.c: Update.
202         * infcall.c: Update.
203         * infcmd.c: Update.
204         * infrun.c: Update.
205         * jit.c: Update.
206         * language.c: Update.
207         * linespec.c: Update.
208         * linux-fork.c: Update.
209         * linux-nat.c: Update.
210         * linux-tdep.c: Update.
211         * linux-thread-db.c: Update.
212         * main.c: Update.
213         * mi/mi-cmd-break.c: Update.
214         * mi/mi-cmd-stack.c: Update.
215         * mi/mi-interp.c: Update.
216         * mi/mi-main.c: Update.
217         * objc-lang.c: Update.
218         * p-valprint.c: Update.
219         * parse.c: Update.
220         * ppc-linux-tdep.c: Update.
221         * printcmd.c: Update.
222         * python/py-arch.c: Update.
223         * python/py-breakpoint.c: Update.
224         * python/py-cmd.c: Update.
225         * python/py-finishbreakpoint.c: Update.
226         * python/py-frame.c: Update.
227         * python/py-framefilter.c: Update.
228         * python/py-gdb-readline.c: Update.
229         * python/py-inferior.c: Update.
230         * python/py-infthread.c: Update.
231         * python/py-lazy-string.c: Update.
232         * python/py-linetable.c: Update.
233         * python/py-objfile.c: Update.
234         * python/py-param.c: Update.
235         * python/py-prettyprint.c: Update.
236         * python/py-progspace.c: Update.
237         * python/py-record-btrace.c: Update.
238         * python/py-record.c: Update.
239         * python/py-symbol.c: Update.
240         * python/py-type.c: Update.
241         * python/py-unwind.c: Update.
242         * python/py-utils.c: Update.
243         * python/py-value.c: Update.
244         * python/python.c: Update.
245         * record-btrace.c: Update.
246         * record-full.c: Update.
247         * remote-fileio.c: Update.
248         * remote.c: Update.
249         * riscv-tdep.c: Update.
250         * rs6000-aix-tdep.c: Update.
251         * rs6000-tdep.c: Update.
252         * rust-exp.y: Update.
253         * rust-lang.c: Update.
254         * s390-tdep.c: Update.
255         * selftest-arch.c: Update.
256         * solib-dsbt.c: Update.
257         * solib-frv.c: Update.
258         * solib-spu.c: Update.
259         * solib-svr4.c: Update.
260         * solib.c: Update.
261         * sparc64-linux-tdep.c: Update.
262         * stack.c: Update.
263         * symfile-mem.c: Update.
264         * symmisc.c: Update.
265         * target.c: Update.
266         * thread.c: Update.
267         * top.c: Update.
268         * tracefile-tfile.c: Update.
269         * tui/tui.c: Update.
270         * typeprint.c: Update.
271         * unittests/cli-utils-selftests.c: Update.
272         * unittests/parse-connection-spec-selftests.c: Update.
273         * valops.c: Update.
274         * valprint.c: Update.
275         * value.c: Update.
276         * varobj.c: Update.
277         * windows-nat.c: Update.
278         * x86-linux-nat.c: Update.
279         * xml-support.c: Update.
280
281 2019-04-08  Tom Tromey  <tom@tromey.com>
282
283         * xml-support.c: Use C++ exception handling.
284         * x86-linux-nat.c: Use C++ exception handling.
285         * windows-nat.c: Use C++ exception handling.
286         * varobj.c: Use C++ exception handling.
287         * value.c: Use C++ exception handling.
288         * valprint.c: Use C++ exception handling.
289         * valops.c: Use C++ exception handling.
290         * unittests/parse-connection-spec-selftests.c: Use C++ exception
291         handling.
292         * unittests/cli-utils-selftests.c: Use C++ exception handling.
293         * typeprint.c: Use C++ exception handling.
294         * tui/tui.c: Use C++ exception handling.
295         * tracefile-tfile.c: Use C++ exception handling.
296         * top.c: Use C++ exception handling.
297         * thread.c: Use C++ exception handling.
298         * target.c: Use C++ exception handling.
299         * symmisc.c: Use C++ exception handling.
300         * symfile-mem.c: Use C++ exception handling.
301         * stack.c: Use C++ exception handling.
302         * sparc64-linux-tdep.c: Use C++ exception handling.
303         * solib.c: Use C++ exception handling.
304         * solib-svr4.c: Use C++ exception handling.
305         * solib-spu.c: Use C++ exception handling.
306         * solib-frv.c: Use C++ exception handling.
307         * solib-dsbt.c: Use C++ exception handling.
308         * selftest-arch.c: Use C++ exception handling.
309         * s390-tdep.c: Use C++ exception handling.
310         * rust-lang.c: Use C++ exception handling.
311         * rust-exp.y: Use C++ exception handling.
312         * rs6000-tdep.c: Use C++ exception handling.
313         * rs6000-aix-tdep.c: Use C++ exception handling.
314         * riscv-tdep.c: Use C++ exception handling.
315         * remote.c: Use C++ exception handling.
316         * remote-fileio.c: Use C++ exception handling.
317         * record-full.c: Use C++ exception handling.
318         * record-btrace.c: Use C++ exception handling.
319         * python/python.c: Use C++ exception handling.
320         * python/py-value.c: Use C++ exception handling.
321         * python/py-utils.c: Use C++ exception handling.
322         * python/py-unwind.c: Use C++ exception handling.
323         * python/py-type.c: Use C++ exception handling.
324         * python/py-symbol.c: Use C++ exception handling.
325         * python/py-record.c: Use C++ exception handling.
326         * python/py-record-btrace.c: Use C++ exception handling.
327         * python/py-progspace.c: Use C++ exception handling.
328         * python/py-prettyprint.c: Use C++ exception handling.
329         * python/py-param.c: Use C++ exception handling.
330         * python/py-objfile.c: Use C++ exception handling.
331         * python/py-linetable.c: Use C++ exception handling.
332         * python/py-lazy-string.c: Use C++ exception handling.
333         * python/py-infthread.c: Use C++ exception handling.
334         * python/py-inferior.c: Use C++ exception handling.
335         * python/py-gdb-readline.c: Use C++ exception handling.
336         * python/py-framefilter.c: Use C++ exception handling.
337         * python/py-frame.c: Use C++ exception handling.
338         * python/py-finishbreakpoint.c: Use C++ exception handling.
339         * python/py-cmd.c: Use C++ exception handling.
340         * python/py-breakpoint.c: Use C++ exception handling.
341         * python/py-arch.c: Use C++ exception handling.
342         * printcmd.c: Use C++ exception handling.
343         * ppc-linux-tdep.c: Use C++ exception handling.
344         * parse.c: Use C++ exception handling.
345         * p-valprint.c: Use C++ exception handling.
346         * objc-lang.c: Use C++ exception handling.
347         * mi/mi-main.c: Use C++ exception handling.
348         * mi/mi-interp.c: Use C++ exception handling.
349         * mi/mi-cmd-stack.c: Use C++ exception handling.
350         * mi/mi-cmd-break.c: Use C++ exception handling.
351         * main.c: Use C++ exception handling.
352         * linux-thread-db.c: Use C++ exception handling.
353         * linux-tdep.c: Use C++ exception handling.
354         * linux-nat.c: Use C++ exception handling.
355         * linux-fork.c: Use C++ exception handling.
356         * linespec.c: Use C++ exception handling.
357         * language.c: Use C++ exception handling.
358         * jit.c: Use C++ exception handling.
359         * infrun.c: Use C++ exception handling.
360         * infcmd.c: Use C++ exception handling.
361         * infcall.c: Use C++ exception handling.
362         * inf-loop.c: Use C++ exception handling.
363         * i386-tdep.c: Use C++ exception handling.
364         * i386-linux-tdep.c: Use C++ exception handling.
365         * guile/scm-value.c: Use C++ exception handling.
366         * guile/scm-type.c: Use C++ exception handling.
367         * guile/scm-symtab.c: Use C++ exception handling.
368         * guile/scm-symbol.c: Use C++ exception handling.
369         * guile/scm-pretty-print.c: Use C++ exception handling.
370         * guile/scm-ports.c: Use C++ exception handling.
371         * guile/scm-param.c: Use C++ exception handling.
372         * guile/scm-math.c: Use C++ exception handling.
373         * guile/scm-lazy-string.c: Use C++ exception handling.
374         * guile/scm-frame.c: Use C++ exception handling.
375         * guile/scm-disasm.c: Use C++ exception handling.
376         * guile/scm-cmd.c: Use C++ exception handling.
377         * guile/scm-breakpoint.c: Use C++ exception handling.
378         * guile/scm-block.c: Use C++ exception handling.
379         * guile/guile-internal.h: Use C++ exception handling.
380         * gnu-v3-abi.c: Use C++ exception handling.
381         * gdbtypes.c: Use C++ exception handling.
382         * frame.c: Use C++ exception handling.
383         * frame-unwind.c: Use C++ exception handling.
384         * fbsd-tdep.c: Use C++ exception handling.
385         * f-valprint.c: Use C++ exception handling.
386         * exec.c: Use C++ exception handling.
387         * event-top.c: Use C++ exception handling.
388         * event-loop.c: Use C++ exception handling.
389         * eval.c: Use C++ exception handling.
390         * dwarf2read.c: Use C++ exception handling.
391         * dwarf2loc.c: Use C++ exception handling.
392         * dwarf2-frame.c: Use C++ exception handling.
393         * dwarf2-frame-tailcall.c: Use C++ exception handling.
394         * dwarf-index-write.c: Use C++ exception handling.
395         * dwarf-index-cache.c: Use C++ exception handling.
396         * dtrace-probe.c: Use C++ exception handling.
397         * disasm-selftests.c: Use C++ exception handling.
398         * darwin-nat.c: Use C++ exception handling.
399         * cp-valprint.c: Use C++ exception handling.
400         * cp-support.c: Use C++ exception handling.
401         * cp-abi.c: Use C++ exception handling.
402         * corelow.c: Use C++ exception handling.
403         * completer.c: Use C++ exception handling.
404         * compile/compile-object-run.c: Use C++ exception handling.
405         * compile/compile-object-load.c: Use C++ exception handling.
406         * compile/compile-cplus-symbols.c: Use C++ exception handling.
407         * compile/compile-c-symbols.c: Use C++ exception handling.
408         * common/selftest.c: Use C++ exception handling.
409         * common/new-op.c: Use C++ exception handling.
410         * cli/cli-script.c: Use C++ exception handling.
411         * cli/cli-interp.c: Use C++ exception handling.
412         * cli/cli-cmds.c: Use C++ exception handling.
413         * c-varobj.c: Use C++ exception handling.
414         * btrace.c: Use C++ exception handling.
415         * breakpoint.c: Use C++ exception handling.
416         * break-catch-throw.c: Use C++ exception handling.
417         * arch-utils.c: Use C++ exception handling.
418         * amd64-tdep.c: Use C++ exception handling.
419         * ada-valprint.c: Use C++ exception handling.
420         * ada-typeprint.c: Use C++ exception handling.
421         * ada-lang.c: Use C++ exception handling.
422         * aarch64-tdep.c: Use C++ exception handling.
423
424 2019-04-08  Tom Tromey  <tom@tromey.com>
425
426         * xml-support.c (gdb_xml_parser::parse): Update.
427         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
428         * value.c (show_convenience): Update.
429         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
430         (test_parse_flags_qcs): Update.
431         * thread.c (thr_try_catch_cmd): Update.
432         * target.c (target_translate_tls_address): Update.
433         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
434         (info_frame_command_core, frame_apply_command_count): Update.
435         * rust-exp.y (rust_lex_exception_test): Update.
436         * riscv-tdep.c (riscv_print_one_register_info): Update.
437         * remote.c (remote_target::enable_btrace): Update.
438         * record-btrace.c (record_btrace_enable_warn): Update.
439         * python/py-utils.c (gdbpy_convert_exception): Update.
440         * printcmd.c (do_one_display, print_variable_and_value): Update.
441         * mi/mi-main.c (mi_print_exception): Update.
442         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
443         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
444         * linux-nat.c (linux_nat_target::attach): Update.
445         * linux-fork.c (class scoped_switch_fork_info): Update.
446         * infrun.c (displaced_step_prepare): Update.
447         * infcall.c (call_function_by_hand_dummy): Update.
448         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
449         * gnu-v3-abi.c (print_one_vtable): Update.
450         * frame.c (get_prev_frame_always): Update.
451         * f-valprint.c (info_common_command_for_block): Update.
452         * exec.c (try_open_exec_file): Update.
453         * exceptions.c (print_exception, exception_print)
454         (exception_fprintf, exception_print_same): Update.
455         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
456         * dwarf-index-cache.c (index_cache::store)
457         (index_cache::lookup_gdb_index): Update.
458         * darwin-nat.c (maybe_cache_shell): Update.
459         * cp-valprint.c (cp_print_value_fields): Update.
460         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
461         (gcc_cplus_symbol_address): Update.
462         * compile/compile-c-symbols.c (gcc_convert_symbol)
463         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
464         * common/selftest.c: Update.
465         * common/common-exceptions.h (struct gdb_exception) <message>: Now
466         a std::string.
467         (exception_try_scope_entry, exception_try_scope_exit): Don't
468         declare.
469         (struct exception_try_scope): Remove.
470         (TRY): Don't use exception_try_scope.
471         (struct gdb_exception): Add constructor, operator=.
472         <what>: New method.
473         (struct gdb_exception_RETURN_MASK_ALL)
474         (struct gdb_exception_RETURN_MASK_ERROR)
475         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
476         (struct gdb_quit_bad_alloc): Update.
477         * common/common-exceptions.c (exception_none): Change
478         initializer.
479         (struct catcher) <state, exception>: Initialize inline.
480         <prev>: Remove member.
481         (current_catcher): Remove.
482         (catchers): New global.
483         (exceptions_state_mc_init): Simplify.
484         (catcher_pop): Remove.
485         (exceptions_state_mc, exceptions_state_mc_catch): Update.
486         (try_scope_depth, exception_try_scope_entry)
487         (exception_try_scope_exit): Remove.
488         (throw_exception_sjlj): Update.
489         (exception_messages, exception_messages_size): Remove.
490         (throw_it): Simplify.
491         (gdb_exception_sliced_copy): Remove.
492         (throw_exception_cxx): Update.
493         * cli/cli-script.c (script_from_file): Update.
494         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
495         Update.
496         * ada-valprint.c (ada_val_print): Update.
497         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
498         (create_excep_cond_exprs): Update.
499
500 2019-04-08  Tom Tromey  <tom@tromey.com>
501
502         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
503         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
504         (TRY, CATCH, END_CATCH): Remove some definitions.
505         * common/common-exceptions.c: Don't use GDB_XCPT.
506         (catcher_list_size): Remove.
507         (throw_exception, throw_it): Simplify.
508
509 2019-04-05  Tom Tromey  <tom@tromey.com>
510
511         Revert the header-sorting patch.
512         * ft32-tdep.c: Revert.
513         * frv-tdep.c: Revert.
514         * frv-linux-tdep.c: Revert.
515         * frame.c: Revert.
516         * frame-unwind.c: Revert.
517         * frame-base.c: Revert.
518         * fork-child.c: Revert.
519         * findvar.c: Revert.
520         * findcmd.c: Revert.
521         * filesystem.c: Revert.
522         * filename-seen-cache.h: Revert.
523         * filename-seen-cache.c: Revert.
524         * fbsd-tdep.c: Revert.
525         * fbsd-nat.h: Revert.
526         * fbsd-nat.c: Revert.
527         * f-valprint.c: Revert.
528         * f-typeprint.c: Revert.
529         * f-lang.c: Revert.
530         * extension.h: Revert.
531         * extension.c: Revert.
532         * extension-priv.h: Revert.
533         * expprint.c: Revert.
534         * exec.h: Revert.
535         * exec.c: Revert.
536         * exceptions.c: Revert.
537         * event-top.c: Revert.
538         * event-loop.c: Revert.
539         * eval.c: Revert.
540         * elfread.c: Revert.
541         * dwarf2read.h: Revert.
542         * dwarf2read.c: Revert.
543         * dwarf2loc.c: Revert.
544         * dwarf2expr.h: Revert.
545         * dwarf2expr.c: Revert.
546         * dwarf2-frame.c: Revert.
547         * dwarf2-frame-tailcall.c: Revert.
548         * dwarf-index-write.h: Revert.
549         * dwarf-index-write.c: Revert.
550         * dwarf-index-common.c: Revert.
551         * dwarf-index-cache.h: Revert.
552         * dwarf-index-cache.c: Revert.
553         * dummy-frame.c: Revert.
554         * dtrace-probe.c: Revert.
555         * disasm.h: Revert.
556         * disasm.c: Revert.
557         * disasm-selftests.c: Revert.
558         * dictionary.c: Revert.
559         * dicos-tdep.c: Revert.
560         * demangle.c: Revert.
561         * dcache.h: Revert.
562         * dcache.c: Revert.
563         * darwin-nat.h: Revert.
564         * darwin-nat.c: Revert.
565         * darwin-nat-info.c: Revert.
566         * d-valprint.c: Revert.
567         * d-namespace.c: Revert.
568         * d-lang.c: Revert.
569         * ctf.c: Revert.
570         * csky-tdep.c: Revert.
571         * csky-linux-tdep.c: Revert.
572         * cris-tdep.c: Revert.
573         * cris-linux-tdep.c: Revert.
574         * cp-valprint.c: Revert.
575         * cp-support.c: Revert.
576         * cp-namespace.c: Revert.
577         * cp-abi.c: Revert.
578         * corelow.c: Revert.
579         * corefile.c: Revert.
580         * continuations.c: Revert.
581         * completer.h: Revert.
582         * completer.c: Revert.
583         * complaints.c: Revert.
584         * coffread.c: Revert.
585         * coff-pe-read.c: Revert.
586         * cli-out.h: Revert.
587         * cli-out.c: Revert.
588         * charset.c: Revert.
589         * c-varobj.c: Revert.
590         * c-valprint.c: Revert.
591         * c-typeprint.c: Revert.
592         * c-lang.c: Revert.
593         * buildsym.c: Revert.
594         * buildsym-legacy.c: Revert.
595         * build-id.h: Revert.
596         * build-id.c: Revert.
597         * btrace.c: Revert.
598         * bsd-uthread.c: Revert.
599         * breakpoint.h: Revert.
600         * breakpoint.c: Revert.
601         * break-catch-throw.c: Revert.
602         * break-catch-syscall.c: Revert.
603         * break-catch-sig.c: Revert.
604         * blockframe.c: Revert.
605         * block.c: Revert.
606         * bfin-tdep.c: Revert.
607         * bfin-linux-tdep.c: Revert.
608         * bfd-target.c: Revert.
609         * bcache.c: Revert.
610         * ax-general.c: Revert.
611         * ax-gdb.h: Revert.
612         * ax-gdb.c: Revert.
613         * avr-tdep.c: Revert.
614         * auxv.c: Revert.
615         * auto-load.c: Revert.
616         * arm-wince-tdep.c: Revert.
617         * arm-tdep.c: Revert.
618         * arm-symbian-tdep.c: Revert.
619         * arm-pikeos-tdep.c: Revert.
620         * arm-obsd-tdep.c: Revert.
621         * arm-nbsd-tdep.c: Revert.
622         * arm-nbsd-nat.c: Revert.
623         * arm-linux-tdep.c: Revert.
624         * arm-linux-nat.c: Revert.
625         * arm-fbsd-tdep.c: Revert.
626         * arm-fbsd-nat.c: Revert.
627         * arm-bsd-tdep.c: Revert.
628         * arch-utils.c: Revert.
629         * arc-tdep.c: Revert.
630         * arc-newlib-tdep.c: Revert.
631         * annotate.h: Revert.
632         * annotate.c: Revert.
633         * amd64-windows-tdep.c: Revert.
634         * amd64-windows-nat.c: Revert.
635         * amd64-tdep.c: Revert.
636         * amd64-sol2-tdep.c: Revert.
637         * amd64-obsd-tdep.c: Revert.
638         * amd64-obsd-nat.c: Revert.
639         * amd64-nbsd-tdep.c: Revert.
640         * amd64-nbsd-nat.c: Revert.
641         * amd64-nat.c: Revert.
642         * amd64-linux-tdep.c: Revert.
643         * amd64-linux-nat.c: Revert.
644         * amd64-fbsd-tdep.c: Revert.
645         * amd64-fbsd-nat.c: Revert.
646         * amd64-dicos-tdep.c: Revert.
647         * amd64-darwin-tdep.c: Revert.
648         * amd64-bsd-nat.c: Revert.
649         * alpha-tdep.c: Revert.
650         * alpha-obsd-tdep.c: Revert.
651         * alpha-nbsd-tdep.c: Revert.
652         * alpha-mdebug-tdep.c: Revert.
653         * alpha-linux-tdep.c: Revert.
654         * alpha-linux-nat.c: Revert.
655         * alpha-bsd-tdep.c: Revert.
656         * alpha-bsd-nat.c: Revert.
657         * aix-thread.c: Revert.
658         * agent.c: Revert.
659         * addrmap.c: Revert.
660         * ada-varobj.c: Revert.
661         * ada-valprint.c: Revert.
662         * ada-typeprint.c: Revert.
663         * ada-tasks.c: Revert.
664         * ada-lang.c: Revert.
665         * aarch64-tdep.c: Revert.
666         * aarch64-ravenscar-thread.c: Revert.
667         * aarch64-newlib-tdep.c: Revert.
668         * aarch64-linux-tdep.c: Revert.
669         * aarch64-linux-nat.c: Revert.
670         * aarch64-fbsd-tdep.c: Revert.
671         * aarch64-fbsd-nat.c: Revert.
672         * aarch32-linux-nat.c: Revert.
673
674 2019-04-05  Tom Tromey  <tom@tromey.com>
675
676         * ft32-tdep.c: Sort headers.
677         * frv-tdep.c: Sort headers.
678         * frv-linux-tdep.c: Sort headers.
679         * frame.c: Sort headers.
680         * frame-unwind.c: Sort headers.
681         * frame-base.c: Sort headers.
682         * fork-child.c: Sort headers.
683         * findvar.c: Sort headers.
684         * findcmd.c: Sort headers.
685         * filesystem.c: Sort headers.
686         * filename-seen-cache.h: Sort headers.
687         * filename-seen-cache.c: Sort headers.
688         * fbsd-tdep.c: Sort headers.
689         * fbsd-nat.h: Sort headers.
690         * fbsd-nat.c: Sort headers.
691         * f-valprint.c: Sort headers.
692         * f-typeprint.c: Sort headers.
693         * f-lang.c: Sort headers.
694         * extension.h: Sort headers.
695         * extension.c: Sort headers.
696         * extension-priv.h: Sort headers.
697         * expprint.c: Sort headers.
698         * exec.h: Sort headers.
699         * exec.c: Sort headers.
700         * exceptions.c: Sort headers.
701         * event-top.c: Sort headers.
702         * event-loop.c: Sort headers.
703         * eval.c: Sort headers.
704         * elfread.c: Sort headers.
705         * dwarf2read.h: Sort headers.
706         * dwarf2read.c: Sort headers.
707         * dwarf2loc.c: Sort headers.
708         * dwarf2expr.h: Sort headers.
709         * dwarf2expr.c: Sort headers.
710         * dwarf2-frame.c: Sort headers.
711         * dwarf2-frame-tailcall.c: Sort headers.
712         * dwarf-index-write.h: Sort headers.
713         * dwarf-index-write.c: Sort headers.
714         * dwarf-index-common.c: Sort headers.
715         * dwarf-index-cache.h: Sort headers.
716         * dwarf-index-cache.c: Sort headers.
717         * dummy-frame.c: Sort headers.
718         * dtrace-probe.c: Sort headers.
719         * disasm.h: Sort headers.
720         * disasm.c: Sort headers.
721         * disasm-selftests.c: Sort headers.
722         * dictionary.c: Sort headers.
723         * dicos-tdep.c: Sort headers.
724         * demangle.c: Sort headers.
725         * dcache.h: Sort headers.
726         * dcache.c: Sort headers.
727         * darwin-nat.h: Sort headers.
728         * darwin-nat.c: Sort headers.
729         * darwin-nat-info.c: Sort headers.
730         * d-valprint.c: Sort headers.
731         * d-namespace.c: Sort headers.
732         * d-lang.c: Sort headers.
733         * ctf.c: Sort headers.
734         * csky-tdep.c: Sort headers.
735         * csky-linux-tdep.c: Sort headers.
736         * cris-tdep.c: Sort headers.
737         * cris-linux-tdep.c: Sort headers.
738         * cp-valprint.c: Sort headers.
739         * cp-support.c: Sort headers.
740         * cp-namespace.c: Sort headers.
741         * cp-abi.c: Sort headers.
742         * corelow.c: Sort headers.
743         * corefile.c: Sort headers.
744         * continuations.c: Sort headers.
745         * completer.h: Sort headers.
746         * completer.c: Sort headers.
747         * complaints.c: Sort headers.
748         * coffread.c: Sort headers.
749         * coff-pe-read.c: Sort headers.
750         * cli-out.h: Sort headers.
751         * cli-out.c: Sort headers.
752         * charset.c: Sort headers.
753         * c-varobj.c: Sort headers.
754         * c-valprint.c: Sort headers.
755         * c-typeprint.c: Sort headers.
756         * c-lang.c: Sort headers.
757         * buildsym.c: Sort headers.
758         * buildsym-legacy.c: Sort headers.
759         * build-id.h: Sort headers.
760         * build-id.c: Sort headers.
761         * btrace.c: Sort headers.
762         * bsd-uthread.c: Sort headers.
763         * breakpoint.h: Sort headers.
764         * breakpoint.c: Sort headers.
765         * break-catch-throw.c: Sort headers.
766         * break-catch-syscall.c: Sort headers.
767         * break-catch-sig.c: Sort headers.
768         * blockframe.c: Sort headers.
769         * block.c: Sort headers.
770         * bfin-tdep.c: Sort headers.
771         * bfin-linux-tdep.c: Sort headers.
772         * bfd-target.c: Sort headers.
773         * bcache.c: Sort headers.
774         * ax-general.c: Sort headers.
775         * ax-gdb.h: Sort headers.
776         * ax-gdb.c: Sort headers.
777         * avr-tdep.c: Sort headers.
778         * auxv.c: Sort headers.
779         * auto-load.c: Sort headers.
780         * arm-wince-tdep.c: Sort headers.
781         * arm-tdep.c: Sort headers.
782         * arm-symbian-tdep.c: Sort headers.
783         * arm-pikeos-tdep.c: Sort headers.
784         * arm-obsd-tdep.c: Sort headers.
785         * arm-nbsd-tdep.c: Sort headers.
786         * arm-nbsd-nat.c: Sort headers.
787         * arm-linux-tdep.c: Sort headers.
788         * arm-linux-nat.c: Sort headers.
789         * arm-fbsd-tdep.c: Sort headers.
790         * arm-fbsd-nat.c: Sort headers.
791         * arm-bsd-tdep.c: Sort headers.
792         * arch-utils.c: Sort headers.
793         * arc-tdep.c: Sort headers.
794         * arc-newlib-tdep.c: Sort headers.
795         * annotate.h: Sort headers.
796         * annotate.c: Sort headers.
797         * amd64-windows-tdep.c: Sort headers.
798         * amd64-windows-nat.c: Sort headers.
799         * amd64-tdep.c: Sort headers.
800         * amd64-sol2-tdep.c: Sort headers.
801         * amd64-obsd-tdep.c: Sort headers.
802         * amd64-obsd-nat.c: Sort headers.
803         * amd64-nbsd-tdep.c: Sort headers.
804         * amd64-nbsd-nat.c: Sort headers.
805         * amd64-nat.c: Sort headers.
806         * amd64-linux-tdep.c: Sort headers.
807         * amd64-linux-nat.c: Sort headers.
808         * amd64-fbsd-tdep.c: Sort headers.
809         * amd64-fbsd-nat.c: Sort headers.
810         * amd64-dicos-tdep.c: Sort headers.
811         * amd64-darwin-tdep.c: Sort headers.
812         * amd64-bsd-nat.c: Sort headers.
813         * alpha-tdep.c: Sort headers.
814         * alpha-obsd-tdep.c: Sort headers.
815         * alpha-nbsd-tdep.c: Sort headers.
816         * alpha-mdebug-tdep.c: Sort headers.
817         * alpha-linux-tdep.c: Sort headers.
818         * alpha-linux-nat.c: Sort headers.
819         * alpha-bsd-tdep.c: Sort headers.
820         * alpha-bsd-nat.c: Sort headers.
821         * aix-thread.c: Sort headers.
822         * agent.c: Sort headers.
823         * addrmap.c: Sort headers.
824         * ada-varobj.c: Sort headers.
825         * ada-valprint.c: Sort headers.
826         * ada-typeprint.c: Sort headers.
827         * ada-tasks.c: Sort headers.
828         * ada-lang.c: Sort headers.
829         * aarch64-tdep.c: Sort headers.
830         * aarch64-ravenscar-thread.c: Sort headers.
831         * aarch64-newlib-tdep.c: Sort headers.
832         * aarch64-linux-tdep.c: Sort headers.
833         * aarch64-linux-nat.c: Sort headers.
834         * aarch64-fbsd-tdep.c: Sort headers.
835         * aarch64-fbsd-nat.c: Sort headers.
836         * aarch32-linux-nat.c: Sort headers.
837
838 2019-04-04  Tom Tromey  <tom@tromey.com>
839
840         * varobj.c (varobj_create): Update.
841         * rust-exp.y (struct rust_parser) <update_innermost_block,
842         lookup_symbol>: New methods.
843         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
844         Rename.
845         (rust_parser::rust_lookup_type)
846         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
847         * printcmd.c (display_command, do_one_display): Update.
848         * parser-defs.h (struct parser_state) <parser_state>: Add
849         "tracker" parameter.
850         (block_tracker): New member.
851         (class innermost_block_tracker) <innermost_block_tracker>: Add
852         "types" parameter.
853         <reset>: Remove method.
854         (innermost_block): Don't declare.
855         (null_post_parser): Update.
856         * parse.c (innermost_block): Remove global.
857         (write_dollar_variable): Update.
858         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
859         Remove "tracker_types" parameter.
860         (parse_expression): Add "tracker" parameter.
861         (parse_expression_for_completion): Update.
862         (null_post_parser): Add "tracker" parameter.
863         * p-exp.y: Update rules.
864         * m2-exp.y: Update rules.
865         * language.h (struct language_defn) <la_post_parser>: Add
866         "tracker" parameter.
867         * go-exp.y: Update rules.
868         * f-exp.y: Update rules.
869         * expression.h (parse_expression, parse_exp_1): Add "tracker"
870         parameter.
871         * d-exp.y: Update rules.
872         * c-exp.y: Update rules.
873         * breakpoint.c (set_breakpoint_condition): Create an
874         innermost_block_tracker.
875         (watch_command_1): Likewise.
876         * ada-lang.c (resolve): Add "tracker" parameter.
877         (resolve_subexp): Likewise.
878         * ada-exp.y (write_var_from_sym): Update.
879
880 2019-04-04  Tom Tromey  <tom@tromey.com>
881
882         * type-stack.h: New file.
883         * type-stack.c: New file.
884         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
885         type-stack.h.
886         (insert_into_type_stack, insert_type, push_type, push_type_int)
887         (insert_type_address_space, pop_type, pop_type_int)
888         (pop_typelist, pop_type_stack, append_type_stack)
889         (push_type_stack, get_type_stack, push_typelist)
890         (follow_type_instance_flags, follow_types): Don't declare.
891         * parse.c (type_stack): Remove global.
892         (parse_exp_in_context): Update.
893         (insert_into_type_stack, insert_type, push_type, push_type_int)
894         (insert_type_address_space, pop_type, pop_type_int)
895         (pop_typelist, pop_type_stack, append_type_stack)
896         (push_type_stack, get_type_stack, push_typelist)
897         (follow_type_instance_flags, follow_types): Remove (moved to
898         type-stack.c).
899         * f-exp.y (type_stack): New global.
900         Update rules.
901         (push_kind_type, f_parse): Update.
902         * d-exp.y (type_stack): New global.
903         Update rules.
904         (d_parse): Update.
905         * c-exp.y (struct c_parse_state) <type_stack>: New member.
906         Update rules.
907         * Makefile.in (COMMON_SFILES): Add type-stack.c.
908         (HFILES_NO_SRCDIR): Add type-stack.h.
909
910 2019-04-04  Tom Tromey  <tom@tromey.com>
911
912         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
913         (rust_parser::convert_ast_to_expression, rust_parse)
914         (rust_lex_test_completion, rust_lex_tests): Update.
915         * parser-defs.h (struct expr_completion_state): New.
916         (struct parser_state) <parser_state>: Add completion parameter.
917         <mark_struct_expression, mark_completion_tag>: New methods.
918         <parse_completion, m_completion_state>: New members.
919         (prefixify_expression, null_post_parser): Update.
920         (mark_struct_expression, mark_completion_tag): Don't declare.
921         * parse.c (parse_completion, expout_last_struct)
922         (expout_tag_completion_type, expout_completion_name): Remove
923         globals.
924         (parser_state::mark_struct_expression)
925         (parser_state::mark_completion_tag): Now methods.
926         (prefixify_expression): Add last_struct parameter.
927         (prefixify_subexp): Likewise.
928         (parse_exp_1): Update.
929         (parse_exp_in_context): Add cstate parameter.  Update.
930         (parse_expression_for_completion): Create an
931         expr_completion_state.
932         (null_post_parser): Add "completion" parameter.
933         * p-exp.y: Update rules.
934         (yylex): Update.
935         * language.h (struct language_defn) <la_post_parser>: Add
936         "completing" parameter.
937         * go-exp.y: Update rules.
938         (lex_one_token): Update.
939         * expression.h (parse_completion): Don't declare.
940         * d-exp.y: Update rules.
941         (lex_one_token): Update rules.
942         * c-exp.y: Update rules.
943         (lex_one_token): Update.
944         * ada-lang.c (resolve): Add "parse_completion" parameter.
945         (resolve_subexp): Likewise.
946         (ada_resolve_function): Likewise.
947
948 2019-04-04  Tom Tromey  <tom@tromey.com>
949
950         * parser-defs.h (struct parser_state) <start_arglist,
951         end_arglist>: New methods.
952         <arglist_len, m_funcall_chain>: New members.
953         (arglist_len, start_arglist, end_arglist): Don't declare.
954         * parse.c (arglist_len, funcall_chain): Remove global.
955         (start_arglist, end_arglist): Remove functions.
956         (parse_exp_in_context): Update.
957         * p-exp.y: Update rules.
958         * m2-exp.y: Update rules.
959         * go-exp.y: Update rules.
960         * f-exp.y: Update rules.
961         * d-exp.y: Update rules.
962         * c-exp.y: Update rules.
963
964 2019-04-04  Tom Tromey  <tom@tromey.com>
965
966         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
967         lex_operator, push_back>: New methods.
968         Update all rules.
969         (rust_parser::lex_hex, lex_escape): Rename and update.
970         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
971         (rust_parser::lex_operator): Rename and update.
972         (rust_parser::lex_number, rustyylex, rustyyerror)
973         (rust_lex_test_init, rust_lex_test_sequence)
974         (rust_lex_test_push_back, rust_lex_tests): Update.
975         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
976         parameter.
977         <lexptr, prev_lexptr>: New members.
978         (lexptr, prev_lexptr): Don't declare.
979         * parse.c (lexptr, prev_lexptr): Remove globals.
980         (parse_exp_in_context): Update.
981         * p-exp.y (yylex, yyerror): Update.
982         * m2-exp.y (parse_number, yylex, yyerror): Update.
983         * go-exp.y (lex_one_token, yyerror): Update.
984         * f-exp.y (match_string_literal, yylex, yyerror): Update.
985         * d-exp.y (lex_one_token, yyerror): Update.
986         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
987         (lex_one_token, yyerror): Update.
988         * ada-lex.l (YY_INPUT): Update.
989         (rewind_to_char): Update.
990         * ada-exp.y (yyerror): Update.
991
992 2019-04-04  Tom Tromey  <tom@tromey.com>
993
994         * rust-exp.y (rustyylex, rust_lex_tests): Update.
995         * parser-defs.h (struct parser_state) <parser_state>: Add new
996         parameter.
997         <comma_terminates>: New member.
998         (comma_terminates): Don't declare global.
999         * parse.c (comma_terminates): Remove global.
1000         (parse_exp_in_context): Update.
1001         * p-exp.y (yylex): Update.
1002         * m2-exp.y (yylex): Update.
1003         * go-exp.y (lex_one_token): Update.
1004         * f-exp.y (yylex): Update.
1005         * d-exp.y (lex_one_token): Update.
1006         * c-exp.y (lex_one_token): Update.
1007         * ada-lex.l: Update.
1008
1009 2019-04-04  Tom Tromey  <tom@tromey.com>
1010
1011         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1012         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1013         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1014         * parser-defs.h (paren_depth): Don't declare.
1015         * parse.c (paren_depth): Remove global.
1016         (parse_exp_in_context): Update.
1017         * p-exp.y (paren_depth): New global.
1018         (pascal_parse): Initialize it.
1019         * m2-exp.y (paren_depth): New global.
1020         (m2_parse): Initialize it.
1021         * go-exp.y (paren_depth): New global.
1022         (go_parse): Initialize it.
1023         * f-exp.y (paren_depth): New global.
1024         (f_parse): Initialize it.
1025         * d-exp.y (paren_depth): New global.
1026         (d_parse): Initialize it.
1027         * c-exp.y (paren_depth): New global.
1028         (c_parse): Initialize it.
1029         * ada-lex.l (paren_depth): New global.
1030         (lexer_init): Initialize it.
1031
1032 2019-04-04  Tom Tromey  <tom@tromey.com>
1033
1034         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1035         (rust_parser::convert_ast_to_type)
1036         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1037         * parser-defs.h (struct parser_state) <parser_state>: Add
1038         parameters.  Initialize new members.
1039         <expression_context_block, expression_context_pc>: New members.
1040         * parse.c (expression_context_block, expression_context_pc):
1041         Remove globals.
1042         (parse_exp_in_context): Update.
1043         * p-exp.y: Update all rules.
1044         (yylex): Update.
1045         * m2-exp.y: Update all rules.
1046         (yylex): Update.
1047         * go-exp.y (yylex): Update.
1048         * f-exp.y (yylex): Update.
1049         * d-exp.y: Update all rules.
1050         (yylex): Update.
1051         * c-exp.y: Update all rules.
1052         (lex_one_token, classify_name, yylex, c_parse): Update.
1053         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1054
1055 2019-04-04  Tom Tromey  <tom@tromey.com>
1056
1057         * gdbarch.h, gdbarch.c: Rebuild.
1058         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1059         * stap-probe.h: 
1060         (struct stap_parse_info): Replace "parser_state" with
1061         "expr_builder".
1062         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1063         (parser_state): New class.
1064         * parse.c (expr_builder): Rename.
1065         (expr_builder::release): Rename.
1066         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1067         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1068         (write_exp_elt_longcst, write_exp_elt_floatcst)
1069         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1070         (write_exp_string_vector, write_exp_bitstring)
1071         (write_exp_msymbol, mark_struct_expression)
1072         (write_dollar_variable)
1073         (insert_type_address_space, increase_expout_size): Replace
1074         "parser_state" with "expr_builder".
1075         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1076         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1077         "parser_state" with "expr_builder".
1078
1079 2019-04-04  Tom Tromey  <tom@tromey.com>
1080
1081         * rust-exp.y: Replace "parse_language" with method call.
1082         * p-exp.y: 
1083         (yylex): Replace "parse_language" with method call.
1084         * m2-exp.y: 
1085         (yylex): Replace "parse_language" with method call.
1086         * go-exp.y (classify_name): Replace "parse_language" with method
1087         call.
1088         * f-exp.y (yylex): Replace "parse_language" with method call.
1089         * d-exp.y (lex_one_token): Replace "parse_language" with method
1090         call.
1091         * c-exp.y: 
1092         (lex_one_token, classify_name, yylex): Replace "parse_language"
1093         with method call.
1094         * ada-exp.y (find_primitive_type, type_char)
1095         (type_system_address): Replace "parse_language" with method call.
1096
1097 2019-04-04  Tom Tromey  <tom@tromey.com>
1098
1099         * rust-exp.y: Replace "parse_gdbarch" with method call.
1100         * parse.c (write_dollar_variable, insert_type_address_space):
1101         Replace "parse_gdbarch" with method call.
1102         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1103         call.
1104         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1105         call.
1106         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1107         "parse_gdbarch" with method call.
1108         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1109         with method call.
1110         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1111         "parse_gdbarch" with method call.
1112         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1113         "parse_gdbarch" with method call.
1114         * c-exp.y (parse_type, parse_number, classify_name): Replace
1115         "parse_gdbarch" with method call.
1116         * ada-lex.l: Replace "parse_gdbarch" with method call.
1117         * ada-exp.y (parse_type, find_primitive_type, type_char)
1118         (type_system_address): Replace "parse_gdbarch" with method call.
1119
1120 2019-04-04  Tom Tromey  <tom@tromey.com>
1121
1122         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1123         * stap-probe.c (stap_parse_argument): Update.
1124         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1125         initial_size parameter.
1126         * rust-exp.y (rust_lex_tests): Update.
1127         * parse.c (parser_state): Update.
1128         (parse_exp_in_context): Update.
1129         * parser-defs.h (struct parser_state) <parser_state>: Remove
1130         "initial_size" parameter.
1131
1132 2019-04-04  Tom Tromey  <tom@tromey.com>
1133
1134         * parser-defs.h (increase_expout_size): Don't declare.
1135         * parse.c (increase_expout_size): Now static.
1136
1137 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1138
1139         * gnu-nat.c (gnu_nat_target::wait): Fix
1140         target_waitstatus_to_string call.
1141
1142 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1143
1144         * eval.c (evaluate_subexp_standard): Handle internal functions
1145         during Fortran function call handling.
1146
1147 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1148
1149         * NEWS: Mention new internal functions.
1150         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1151         (read_base_type): Use dwarf2_init_complex_target_type.
1152         * value.c (creal_internal_fn): New function.
1153         (cimag_internal_fn): New function.
1154         (_initialize_values): Register new internal functions.
1155
1156 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1157
1158         * infrun.c (stop_all_threads): If debug_infrun, always
1159         trace the wait status after wait_one, using
1160         target_waitstatus_to_string and target_pid_to_str.
1161         (handle_inferior_event): Replace various trace of
1162         wait status kind by a single trace.
1163         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1164         wait status kind image by target_waitstatus_to_string.
1165         * target/waitstatus.c (target_waitstatus_to_string): Fix
1166         obsolete comment.
1167
1168 2019-04-01  Tom Tromey  <tromey@adacore.com>
1169
1170         PR symtab/23331:
1171         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1172
1173 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1174             Pedro Alves  <palves@redhat.com>
1175
1176         * top.c (quit_force): Call 'finalize_values'.
1177         * value.c (finalize_values): New function.
1178         * value.h (finalize_values): Declare.
1179
1180 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1181
1182         * NEWS: Announce $_gdb_major and $_gdb_minor.
1183
1184         * top.c (init_gdb_version_vars): New function.
1185         (gdb_init): Call init_gdb_version_vars.
1186
1187 2019-03-29  Tom Tromey  <tromey@adacore.com>
1188
1189         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1190         help text.  Remove dead code.
1191
1192 2019-03-29  Keith Seitz  <keiths@redhat.com>
1193
1194         From Siddhesh Poyarekar:
1195         * f-lang.h (f77_get_upperbound): Return LONGEST.
1196         (f77_get_lowerbound): Likewise.
1197         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1198         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1199         print them.
1200         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1201         plongest to format print it.
1202         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1203         (f77_get_upperbound): Likewise.
1204         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1205         LOWER_BOUND to LONGEST.
1206         (f77_create_arrayprint_offset_tbl): Likewise.
1207
1208 2019-03-29  Keith Seitz  <keiths@redhat.com>
1209
1210         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1211         %s/pulongest for TYPE_LENGTH instead of %d in format
1212         strings.
1213         * ada-typerint.c (ada_print_type): Likewise.
1214         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1215         * compile/compile-c-support.c (generate_register_struct): Likewise.
1216         * gdbtypes.c (recursive_dump_type): Likewise.
1217         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1218         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1219         instead of %d in format strings.
1220         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1221         to std::min to ULONGEST.
1222         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1223         instead of %d in format strings.
1224         * tracepoint.c (info_scope_command): Likewise.
1225         * typeprint.c (print_offset_data::update)
1226         (print_offset_data::finish): Likewise.
1227         * xtensa-tdep.c (xtensa_store_return_value)
1228         (xtensa_push_dummy_call): Likewise.
1229
1230 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1231
1232         * windows-nat.c (display_selector): Fixed format specifications
1233         for 64-bit Cygwin.
1234
1235 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1236
1237         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1238
1239 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1240
1241         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1242         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1243         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1244         (nios2_linux_init_abi): Install it.
1245
1246 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1247
1248         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1249
1250 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1251
1252         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1253
1254 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1255             Tom Tromey  <tromey@adacore.com>
1256
1257         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1258
1259 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1260
1261         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1262         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1263         method to compute the bounds of range types. Also print "[evaluated]"
1264         if the bounds' values come from a dynamic evaluation.
1265
1266 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1267
1268         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1269         whitespace when pretty printing is on.
1270
1271 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1272
1273         * ppc-linux-nat.c: Add include.
1274
1275 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1276
1277         * NEWS: Mention AArch64 Pointer Authentication.
1278
1279 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1280
1281         * arm-linux-nat.c: Add include.
1282
1283 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1284
1285         * source-cache.c (source_cache::get_source_lines): Re-read
1286         fullname after calling open_source_file.
1287
1288 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1289
1290         * NEWS: Mention TLS support for FreeBSD.
1291
1292 2019-03-25  Tom Tromey  <tromey@adacore.com>
1293
1294         * minsyms.c (BUNCH_SIZE): Update comment.
1295         (~minimal_symbol_reader): Remove old comment.
1296         (compact_minimal_symbols): Update comment.
1297         (minimal_symbol_reader::install): Remove old comment.  Update
1298         other comments.
1299
1300 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1301
1302         * s390-linux-nat.c: Add include.
1303
1304 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1305
1306         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1307         Call linux_get_hwcap.
1308         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1309         Likewise.
1310         (aarch64_linux_get_hwcap): Remove function.
1311         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1312         declaration.
1313         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1314         linux_get_hwcap.
1315         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1316         * linux-tdep.c (linux_get_hwcap): Add function.
1317         (linux_get_hwcap2): Likewise.
1318         * linux-tdep.h (linux_get_hwcap): Add declaration.
1319         (linux_get_hwcap2): Likewise.
1320         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1321         (ppc_linux_get_hwcap2): Likewise.
1322         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1323         linux_get_hwcap.
1324         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1325         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1326         (ppc_linux_nat_target::read_description): Likewise.
1327         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1328         * s390-linux-nat.c: Likewise.
1329         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1330
1331 2019-03-24  Tom Tromey  <tom@tromey.com>
1332
1333         * ada-lang.c (standard_lookup): Simplify initialization.
1334         (ada_lookup_symbol_nonlocal): Simplify return.
1335         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1336         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1337         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1338         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1339         initialization.
1340         * solib.c (solib_global_lookup): Simplify.
1341         * symtab.c (null_block_symbol): Remove.
1342         (symbol_cache_lookup): Simplify returns.
1343         (lookup_language_this): Simplify returns.
1344         (lookup_symbol_aux): Simplify return.
1345         (lookup_local_symbol): Simplify returns.
1346         (lookup_global_symbol_from_objfile): Simplify return.
1347         (lookup_symbol_in_objfile_symtabs)
1348         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1349         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1350         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1351         * cp-namespace.c (cp_lookup_bare_symbol)
1352         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1353         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1354         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1355         (cp_lookup_symbol_via_imports): Simplify initialization.
1356         (find_symbol_in_baseclass): Likewise.
1357         * symtab.h (null_block_symbol): Remove.
1358         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1359         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1360         (d_lookup_symbol_module): Likewise.
1361         (find_symbol_in_baseclass): Simplify initialization.
1362
1363 2019-03-24  Tom Tromey  <tom@tromey.com>
1364
1365         * expression.h: Don't include symtab.h.
1366         (struct block): Forward declare.
1367
1368 2019-03-24  Tom Tromey  <tom@tromey.com>
1369
1370         * c-exp.y (typebase): Remove casts.
1371         * gdbtypes.c (lookup_unsigned_typename, )
1372         (lookup_signed_typename): Remove cast.
1373         * eval.c (parse_to_comma_and_eval): Remove cast.
1374         * parse.c (write_dollar_variable): Remove cast.
1375         * block.h (struct block) <superblock>: Now const.
1376         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1377         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1378         (map_block): Make "block" const.
1379         * symfile.h (struct quick_symbol_functions)
1380         <map_matching_symbols>: Constify block argument to "callback".
1381         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1382         const.
1383         (find_pc_sect_compunit_symtab): Make "b" const.
1384         (find_symbol_at_address): Likewise.
1385         (search_symbols): Likewise.
1386         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1387         (dw2_debug_names_lookup_symbol): Likewise.
1388         (dw2_map_matching_symbols): Update.
1389         * p-valprint.c (pascal_val_print): Remove "block".
1390         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1391         (aux_add_nonlocal_symbols): Make "block" const.
1392         (resolve_subexp): Remove cast.
1393         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1394         const.
1395         (iterate_over_file_blocks): Likewise.
1396         * f-exp.y (%union) <bval>: Remove.
1397         * coffread.c (patch_opaque_types): Make "b" const.
1398         * spu-tdep.c (spu_catch_start): Make "block" const.
1399         * c-valprint.c (print_unpacked_pointer): Remove "block".
1400         * symmisc.c (dump_symtab_1): Make "b" const.
1401         (block_depth): Make "block" const.
1402         * d-exp.y (%union) <bval>: Remove.
1403         * cp-support.h (cp_lookup_rtti_type): Update.
1404         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1405         * psymtab.c (psym_lookup_symbol): Make "block" const.
1406         (maintenance_check_psymtabs): Make "b" const.
1407         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1408         (enumerate_locals, enumerate_args): Update.
1409         * python/py-symtab.c (stpy_global_block): Make "block" const.
1410         (stpy_static_block): Likewise.
1411         * inline-frame.c (block_starting_point_at): Make "new_block"
1412         const.
1413         * block.c (find_block_in_blockvector): Make return type const.
1414         (blockvector_for_pc_sect): Make "b" const.
1415         (find_block_in_blockvector): Make "b" const.
1416
1417 2019-03-23  Tom Tromey  <tom@tromey.com>
1418
1419         * varobj.c (varobj_create): Update.
1420         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1421         * printcmd.c (display_command, do_one_display): Don't reset
1422         innermost_block.
1423         * parser-defs.h (enum innermost_block_tracker_type): Move to
1424         expression.h.
1425         (innermost_block): Update comment.
1426         * parse.c (parse_exp_1): Add tracker_types parameter.
1427         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1428         tracker_types parameter.  Reset innermost_block.
1429         (parse_exp_in_context): Remove.
1430         (parse_expression_for_completion): Update.
1431         * objfiles.c (~objfile): Don't reset expression_context_block or
1432         innermost_block.
1433         * expression.h (enum innermost_block_tracker_type): Move from
1434         parser-defs.h.
1435         (parse_exp_1): Add tracker_types parameter.
1436         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1437         reset innermost_block.
1438
1439 2019-03-23  Tom Tromey  <tom@tromey.com>
1440
1441         * objfiles.h: Include bcache.h.
1442
1443 2019-03-23  Tom Tromey  <tom@tromey.com>
1444
1445         * linespec.c (get_current_search_block): Use
1446         scoped_restore_current_language.
1447         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1448
1449 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1450             Jiong Wang  <jiong.wang@arm.com>
1451
1452         * aarch64-linux-tdep.c
1453         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1454         section.
1455         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1456
1457 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1458             Jiong Wang  <jiong.wang@arm.com>
1459
1460         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1461         instructions.
1462         (aarch64_analyze_prologue_test): Add PACIASP test.
1463         (aarch64_prologue_prev_register): Unmask PC value.
1464
1465 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1466             Jiong Wang  <jiong.wang@arm.com>
1467
1468         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1469         (aarch64_dwarf2_prev_register): Unmask PC value.
1470         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1471         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1472         DW_CFA_AARCH64_negate_ra_state.
1473         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1474
1475 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1476             Jiong Wang  <jiong.wang@arm.com>
1477
1478         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1479         registers.
1480         (aarch64_pseudo_register_name): Likewise.
1481         (aarch64_pseudo_register_type): Likewise.
1482         (aarch64_pseudo_register_reggroup_p): Likewise.
1483         (aarch64_gdbarch_init): Add pauth registers.
1484         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1485         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1486         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1487         (struct gdbarch_tdep): Add regnum for ra_state.
1488
1489 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1490             Jiong Wang  <jiong.wang@arm.com>
1491
1492         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1493
1494 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1495             Jiong Wang  <jiong.wang@arm.com>
1496
1497         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1498         function.
1499         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1500         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1501         (aarch64_gdbarch_init): Add puth registers.
1502         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1503         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1504         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1505
1506 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1507             Jiong Wang  <jiong.wang@arm.com>
1508
1509         * aarch64-linux-nat.c
1510         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1511         * aarch64-linux-tdep.c
1512         (aarch64_linux_core_read_description): Likewise.
1513         (aarch64_linux_get_hwcap): New function.
1514         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1515         (aarch64_linux_get_hwcap): New declaration.
1516
1517 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1518             Jiong Wang  <jiong.wang@arm.com>
1519
1520         * aarch64-linux-nat.c
1521         (aarch64_linux_nat_target::read_description): Add pauth param.
1522         * aarch64-linux-tdep.c
1523         (aarch64_linux_core_read_description): Likewise.
1524         * aarch64-tdep.c (struct target_desc): Add in pauth.
1525         (aarch64_read_description): Add pauth param.
1526         (aarch64_gdbarch_init): Likewise.
1527         * aarch64-tdep.h (aarch64_read_description): Likewise.
1528         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1529         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1530         * features/Makefile: Add new files.
1531         * features/aarch64-pauth.c: New file.
1532         * features/aarch64-pauth.xml: New file.
1533
1534 2019-03-20  Tom Tromey  <tromey@adacore.com>
1535
1536         * infrun.c (handle_inferior_event): Rename from
1537         handle_inferior_event_1.  Create a scoped_value_mark.
1538         (handle_inferior_event): Remove.
1539
1540 2019-03-19  Tom Tromey  <tromey@adacore.com>
1541
1542         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1543         * infrun.h (print_stop_event): Add "displays" parameter.
1544         * infrun.c (print_stop_event): Add "displays" parameter.
1545
1546 2019-03-19  Pedro Alves  <palves@redhat.com>
1547
1548         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1549         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1550         to -1.  Fix TABs vs spaces.
1551         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1552         * tui/tui-out.h (tui_ui_out) Add intro comments.
1553         <m_line, m_start_of_line>: In-class initialize, and add describing
1554         comment.
1555
1556 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1557
1558         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1559         variable names.
1560         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1561
1562 2019-03-18  Pedro Alves  <palves@redhat.com>
1563             Eli Zaretskii <eliz@gnu.org>
1564
1565         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1566         m_line and m_start_of_line.
1567
1568 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1569
1570         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1571         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1572         it returns a newline.  This fixes a regression in TU mode, whereby
1573         the next line is output on the same screen line as the user input.
1574
1575 2019-03-18  Tom Tromey  <tromey@adacore.com>
1576
1577         * minsyms.c (minimal_symbol_reader::install): Remove call to
1578         obstack_blank.
1579
1580 2019-03-18  Pedro Alves  <palves@redhat.com>
1581
1582         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1583         New globals.
1584         (apply_style): New, factored out from ...
1585         (apply_ansi_escape): ... this.  Handle reverse video mode.
1586         (tui_set_reverse_mode): New function.
1587         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1588         * tui/tui-winsource.c (tui_show_source_line): Use
1589         tui_set_reverse_mode instead of setting A_STANDOUT.
1590         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1591         New setter methods.
1592
1593 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1594
1595         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1596         Handle tabs.
1597
1598 2019-03-18  Tom Tromey  <tromey@adacore.com>
1599
1600         * ada-lang.c (empty_array): Add "high" parameter.
1601         (ada_evaluate_subexp): Update.
1602
1603 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1604
1605         * unittests/string_view-selftests.c: Define
1606         _initialize_string_view_selftests unconditionally.
1607
1608 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1609
1610         PR gdb/24350
1611         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1612
1613 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1614
1615         PR gdb/24351
1616         * windows-nat.c (display_selector): Fix format specifiers.
1617
1618 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1619
1620         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1621         tui_refill_source_window instead of tui_refresh_win, to update the
1622         current execution line.  This fixes redisplay of the current line
1623         when stepping through the code with "next" or "step".
1624
1625 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1626
1627         * source-cache.c (source_cache::get_source_lines): Call
1628         find_source_lines to initialize s->nlines.  This fixes vertical
1629         scrolling of TUI source window when the DOWN arrow is pressed.
1630
1631 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1632
1633         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1634         linux-thread-db.c (_initialize_thread_db): Likewise.
1635
1636 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1637
1638         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1639         wclrtoeol in tui_show_source_line".  This reverts changes made in
1640         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1641
1642 2019-03-15  Tom Tromey  <tom@tromey.com>
1643
1644         * symtab.h (struct minimal_symbol): Derive from
1645         general_symbol_info.
1646         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1647         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1648         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1649         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1650         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1651         (MSYMBOL_SEARCH_NAME): Update.
1652         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1653         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1654         * minsyms.c (minimal_symbol_reader::record_full): Update.
1655
1656 2019-03-15  Tom Tromey  <tom@tromey.com>
1657
1658         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1659
1660 2019-03-15  Tom Tromey  <tom@tromey.com>
1661
1662         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1663         unique_xmalloc_ptr.
1664         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1665         Update.
1666         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1667         (build_minimal_symbol_hash_tables)
1668         (minimal_symbol_reader::install): Update.
1669
1670 2019-03-15  Tom Tromey  <tom@tromey.com>
1671
1672         * symtab.c (create_demangled_names_hash): Update.
1673         (symbol_set_names): Update.
1674         * objfiles.h (struct objfile_per_bfd_storage)
1675         <demangled_names_hash>: Now an htab_up.
1676         * objfiles.c (objfile_per_bfd_storage): Simplify.
1677
1678 2019-03-15  Tom Tromey  <tom@tromey.com>
1679
1680         * objfiles.h (struct objfile_per_bfd_storage): Declare
1681         destructor.
1682         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1683         New.
1684         (get_objfile_bfd_data): Use new.  Don't initialize
1685         language_of_main.
1686         (free_objfile_per_bfd_storage): Remove.
1687         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1688
1689 2019-03-15  Tom Tromey  <tom@tromey.com>
1690
1691         * symfile.c (reread_symbols): Update.
1692         * objfiles.c (objfile::objfile): Update.
1693         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1694         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1695         comment.
1696         (minimal_symbol_reader::install): Update.
1697         (terminate_minimal_symbol_table): Remove.
1698         * jit.c (jit_object_close_impl): Update.
1699
1700 2019-03-15  Tom Tromey  <tom@tromey.com>
1701
1702         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1703         initializations.
1704
1705 2019-03-15  Tom Tromey  <tom@tromey.com>
1706
1707         * objfiles.h (struct objfile_per_bfd_storage)
1708         <demangled_hash_languages>: Now a bitset.
1709         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1710         (lookup_minimal_symbol): Update.
1711
1712 2019-03-15  Tom Tromey  <tom@tromey.com>
1713
1714         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1715         Don't return the symbol.
1716         * coffread.c (record_minimal_symbol): Use record_full.
1717
1718 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1719
1720         The MS-Windows port of ncurses fails to switch to a color pair if
1721         one or both of the colors are the implicit default colors.  This
1722         change records the default colors when TUI is initialized, and
1723         then specifies them explicitly when a color pair uses the default
1724         colors.  This allows color styling in TUI mode on MS-Windows.
1725
1726         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1727         ncurses_norm_attr.
1728         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1729         colors in ncurses_norm_attr.
1730         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1731         "none", replace it with the default color recorded in
1732         ncurses_norm_attr.
1733
1734 2019-03-14  Tom Tromey  <tromey@adacore.com>
1735
1736         * source-cache.h (class source_cache) <get_source_lines>: Return
1737         std::string.
1738         * source-cache.c (source_cache::extract_lines): Handle case where
1739         first_pos==npos.  Return std::string.
1740         (source_cache::get_source_lines): Update.
1741
1742 2019-03-14  Tom Tromey  <tromey@adacore.com>
1743
1744         * NEWS: Add item for "style sources" commands.
1745         * source-cache.c (source_cache::get_source_lines): Check
1746         source_styling.
1747         * cli/cli-style.c (source_styling): New global.
1748         (_initialize_cli_style): Add "style sources" commands.
1749         (show_style_sources): New function.
1750         * cli/cli-style.h (source_styling): Declare.
1751
1752 2019-03-14  Pedro Alves  <palves@redhat.com>
1753             Tom Tromey  <tromey@adacore.com>
1754
1755         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1756         * tui/tui-winsource.c (tui_refill_source_window): New function,
1757         from...
1758         (tui_horizontal_source_scroll): ... here.  Move some logic.
1759         * cli/cli-style.c (set_style_enabled): Notify new observable.
1760         * tui/tui-hooks.c (tui_redisplay_source): New function.
1761         (tui_attach_detach_observers): Attach or detach
1762         tui_redisplay_source.
1763         * observable.h (source_styling_changed): New observable.
1764         * observable.c: Define source_styling_changed observable.
1765
1766 2019-03-13  Tom Tromey  <tromey@adacore.com>
1767
1768         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1769         (i386_gnu_nat_target::store_registers): Update.
1770         * target-debug.h (target_debug_print_std_string): New macro.
1771         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1772         * windows-tdep.c (display_one_tib): Update.
1773         * tui/tui-stack.c (tui_make_status_line): Update.
1774         * top.c (print_inferior_quit_action): Update.
1775         * thread.c (thr_try_catch_cmd): Update.
1776         (add_thread_with_info): Update.
1777         (thread_target_id_str): Update.
1778         (thr_try_catch_cmd): Update.
1779         (thread_command): Update.
1780         (thread_find_command): Update.
1781         * record-btrace.c (record_btrace_target::info_record)
1782         (record_btrace_resume_thread, record_btrace_target::resume)
1783         (record_btrace_cancel_resume, record_btrace_step_thread)
1784         (record_btrace_target::wait, record_btrace_target::wait)
1785         (record_btrace_target::wait, record_btrace_target::stop): Update.
1786         * progspace.c (print_program_space): Update.
1787         * process-stratum-target.c
1788         (process_stratum_target::thread_address_space): Update.
1789         * linux-fork.c (linux_fork_mourn_inferior)
1790         (detach_checkpoint_command, info_checkpoints_command)
1791         (linux_fork_context): Update.
1792         (linux_fork_detach): Update.
1793         (class scoped_switch_fork_info): Update.
1794         (delete_checkpoint_command): Update.
1795         * infrun.c (follow_fork_inferior): Update.
1796         (follow_fork_inferior): Update.
1797         (proceed_after_vfork_done): Update.
1798         (handle_vfork_child_exec_or_exit): Update.
1799         (follow_exec): Update.
1800         (displaced_step_prepare_throw): Update.
1801         (displaced_step_restore): Update.
1802         (start_step_over): Update.
1803         (resume_1): Update.
1804         (clear_proceed_status_thread): Update.
1805         (proceed): Update.
1806         (print_target_wait_results): Update.
1807         (do_target_wait): Update.
1808         (context_switch): Update.
1809         (stop_all_threads): Update.
1810         (restart_threads): Update.
1811         (finish_step_over): Update.
1812         (handle_signal_stop): Update.
1813         (switch_back_to_stepped_thread): Update.
1814         (keep_going_pass_signal): Update.
1815         (print_exited_reason): Update.
1816         (normal_stop): Update.
1817         * inferior.c (inferior_pid_to_str): Change return type.
1818         (print_selected_inferior): Update.
1819         (add_inferior): Update.
1820         (detach_inferior): Update.
1821         * dummy-frame.c (fprint_dummy_frames): Update.
1822         * dcache.c (dcache_info_1): Update.
1823         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1824         (btrace_fetch, btrace_clear): Update.
1825         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1826         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1827         type.
1828         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1829         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1830         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1831         * gdbarch.c, gdbarch.h: Rebuild.
1832         * gdbarch.sh (core_pid_to_str): Change return type.
1833         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1834         return type.
1835         (windows_nat_target::pid_to_str): Change return type.
1836         (windows_delete_thread): Update.
1837         (windows_nat_target::attach): Update.
1838         (windows_nat_target::files_info): Update.
1839         * target-delegates.c: Rebuild.
1840         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1841         return type.
1842         (sol_thread_target::pid_to_str): Change return type.
1843         * remote.c (class remote_target) <pid_to_str>: Change return
1844         type.
1845         (remote_target::pid_to_str): Change return type.
1846         (extended_remote_target::attach, remote_target::remote_stop_ns)
1847         (remote_target::remote_notif_remove_queued_reply)
1848         (remote_target::push_stop_reply, remote_target::disable_btrace):
1849         Update.
1850         (extended_remote_target::attach): Update.
1851         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1852         type.
1853         (gdbsim_target::pid_to_str): Change return type.
1854         * ravenscar-thread.c (struct ravenscar_thread_target)
1855         <pid_to_str>: Change return type.
1856         (ravenscar_thread_target::pid_to_str): Change return type.
1857         * procfs.c (class procfs_target) <pid_to_str>: Change return
1858         type.
1859         (procfs_target::pid_to_str): Change return type.
1860         (procfs_target::attach): Update.
1861         (procfs_target::detach): Update.
1862         (procfs_target::fetch_registers): Update.
1863         (procfs_target::store_registers): Update.
1864         (procfs_target::wait): Update.
1865         (procfs_target::files_info): Update.
1866         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1867         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1868         return type.
1869         (nto_procfs_target::pid_to_str): Change return type.
1870         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1871         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1872         return type.
1873         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1874         (exit_lwp): Update.
1875         (attach_proc_task_lwp_callback, get_detach_signal)
1876         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1877         (linux_nat_target::resume, wait_lwp, stop_callback)
1878         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1879         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1880         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1881         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1882         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1883         type.
1884         (inf_ptrace_target::attach): Update.
1885         (inf_ptrace_target::files_info): Update.
1886         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1887         type.
1888         (go32_nat_target::pid_to_str): Change return type.
1889         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1890         (gnu_nat_target::wait): Update.
1891         (gnu_nat_target::wait): Update.
1892         (gnu_nat_target::resume): Update.
1893         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1894         (fbsd_nat_target::wait): Update.
1895         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1896         type.
1897         (darwin_nat_target::attach): Update.
1898         * corelow.c (class core_target) <pid_to_str>: Change return type.
1899         (core_target::pid_to_str): Change return type.
1900         * target.c (normal_pid_to_str): Change return type.
1901         (default_pid_to_str): Likewise.
1902         (target_pid_to_str): Change return type.
1903         (target_translate_tls_address): Update.
1904         (target_announce_detach): Update.
1905         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1906         return type.
1907         (bsd_uthread_target::pid_to_str): Change return type.
1908         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1909         type.
1910         (bsd_kvm_target::pid_to_str): Change return type.
1911         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1912         return type.
1913         (aix_thread_target::pid_to_str): Change return type.
1914         * target.h (struct target_ops) <pid_to_str>: Change return type.
1915         (target_pid_to_str, normal_pid_to_str): Likewise.
1916         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1917         type.
1918         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1919         type.
1920         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1921         return type.
1922         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1923         type.
1924         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1925         type.
1926         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1927         return type.
1928
1929 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1930
1931         * NEWS: Mention that the new default MI version is 3.  Mention
1932         changes to the output of commands and events that deal with
1933         multi-location breakpoints.
1934         * breakpoint.c: Include "mi/mi-out.h".
1935         (print_one_breakpoint): Change output syntax if using MI version
1936         >= 3.
1937         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1938         New.
1939         (mi_multi_location_breakpoint_output_fixed): New.
1940         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1941         (mi_cmd_fix_multi_location_breakpoint_output): New.
1942         (mi_multi_location_breakpoint_output_fixed): New.
1943         * mi/mi-cmds.c (mi_cmds): Register command
1944         -fix-multi-location-breakpoint-output.
1945         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1946         interpreter "mi".
1947
1948 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1949
1950         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1951         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1952         instantiate mi_ui_out based on interpreter name.
1953         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1954         * mi/mi-main.c (mi_load_progress): Likewise.
1955
1956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1957
1958         * NEWS: Combine separate "New targets" sections for 8.3.
1959
1960 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1961
1962         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1963         (ppcfbsd_init_abi): Install gdbarch
1964         "fetch_tls_load_module_address" and "get_thread_local_address"
1965         methods.
1966
1967 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1968
1969         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1970         (riscv_fbsd_init_abi): Install gdbarch
1971         "fetch_tls_load_module_address" and "get_thread_local_address"
1972         methods.
1973
1974 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1975
1976         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1977         (i386fbsd_init_abi): Install gdbarch
1978         "fetch_tls_load_module_address" and "get_thread_local_address"
1979         methods.
1980
1981 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1982
1983         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1984         (amd64fbsd_init_abi): Install gdbarch
1985         "fetch_tls_load_module_address" and "get_thread_local_address"
1986         methods.
1987
1988 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1989
1990         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1991         (struct fbsd_pspace_data): New type.
1992         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1993         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1994         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1995         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1996         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1997
1998 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1999
2000         * gdbtypes.c (lookup_struct_elt): New function.
2001         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2002         * gdbtypes.h (struct struct_elt): New type.
2003         (lookup_struct_elt): New prototype.
2004
2005 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2006
2007         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2008         remove disabled code block.
2009
2010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2011
2012         * gdbarch.sh (get_thread_local_address): New method.
2013         * gdbarch.h, gdbarch.c: Regenerate.
2014         * target.c (target_translate_tls_address): Use
2015         gdbarch_get_thread_local_address if present instead of
2016         target::get_thread_local_address.
2017
2018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2019
2020         * target.h (target::get_thread_local_address): Update comment.
2021
2022 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2023
2024         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2025         objfile->separate_debug_objfile_backlink if not NULL.
2026
2027 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2028
2029         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2030         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2031         (amd64bsd_store_inferior_registers): Likewise.
2032         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2033         Enable segment base registers.
2034         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2035         PT_GETFSBASE and PT_GETGSBASE.
2036         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2037         PT_SETGSBASE.
2038         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2039         segment base registers.
2040         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2041
2042 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2043
2044         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2045         Update calls to i386_target_description to add 'segments'
2046         parameter.
2047         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2048         add segment base registers.
2049         * arch/i386.c (i386_create_target_description): Add 'segments'
2050         parameter to enable segment base registers.
2051         * arch/i386.h (i386_create_target_description): Likewise.
2052         * features/i386/32bit-segments.xml: New file.
2053         * features/i386/32bit-segments.c: Generate.
2054         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2055         call to i386_target_description to add 'segments' parameter.
2056         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2057         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2058         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2059         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2060         if feature is present.
2061         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2062         Add 'segments' parameter to call to i386_target_description.
2063         (i386_target_description): Add 'segments' parameter to enable
2064         segment base registers.
2065         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2066         to call to i386_target_description.
2067         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2068         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2069         Define I386_NUM_REGS.
2070         (i386_target_description): Add 'segments' parameter to enable
2071         segment base registers.
2072
2073 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2074
2075         PR/24325
2076         * source-cache.c: #undef open and close, to avoid unresolved
2077         externals during linking.
2078
2079 2019-03-12  Tom Tromey  <tromey@adacore.com>
2080
2081         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2082         const.  Add initializers.
2083         (_initialize_remote): Don't initialize ptid globals.
2084
2085 2019-03-12  Pedro Alves  <palves@redhat.com>
2086
2087         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2088
2089 2019-03-12  Pedro Alves  <palves@redhat.com>
2090
2091         * cp-name-parser.y (main): Remove unused 'len' variable.
2092
2093 2019-03-12  Tom Tromey  <tromey@adacore.com>
2094
2095         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2096         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2097
2098 2019-03-12  Tom Tromey  <tromey@adacore.com>
2099
2100         * linux-nat.c (iterate_over_lwps): Update.
2101         (stop_callback): Remove parameter.
2102         (stop_wait_callback, detach_callback, resume_set_callback)
2103         (select_singlestep_lwp_callback, set_ignore_sigint)
2104         (status_callback, resumed_callback, resume_clear_callback)
2105         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2106         data parameter.
2107         (linux_nat_target::detach, linux_nat_target::resume)
2108         (linux_stop_and_wait_all_lwps, select_event_lwp)
2109         (linux_nat_filter_event, linux_nat_wait_1)
2110         (linux_nat_target::kill, linux_nat_target::stop)
2111         (linux_nat_target::stop): Update.
2112         (linux_nat_resume_callback): Change type.
2113         (resume_stopped_resumed_lwps, count_events_callback)
2114         (select_event_lwp_callback): Likewise.
2115         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2116         * arm-linux-nat.c (struct update_registers_data): Remove.
2117         (update_registers_callback): Change type.
2118         (arm_linux_insert_hw_breakpoint1): Update.
2119         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2120         parameter.
2121         (x86_linux_dr_set_addr): Update.
2122         (x86_linux_dr_set_control): Update.
2123         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2124         (iterate_over_lwps): Use gdb::function_view.
2125         * nat/aarch64-linux-hw-point.c (struct
2126         aarch64_dr_update_callback_param): Remove.
2127         (debug_reg_change_callback): Change type.
2128         (aarch64_notify_debug_reg_change): Update.
2129         * s390-linux-nat.c (s390_refresh_per_info): Update.
2130
2131 2019-03-11  Tom Tromey  <tromey@adacore.com>
2132
2133         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2134         redundant assignment to "this_cu".
2135
2136 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2137
2138         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2139
2140 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2141
2142         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2143         from...
2144         (rank_one_type): ... this.
2145
2146 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2147
2148         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2149         from...
2150         (rank_one_type): ... this.
2151
2152 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2153
2154         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2155         from...
2156         (rank_one_type): ... this.
2157
2158 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2159
2160         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2161         from...
2162         (rank_one_type): ... this.
2163
2164 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2165
2166         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2167         from...
2168         (rank_one_type): ... this.
2169
2170 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2171
2172         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2173         from...
2174         (rank_one_type): ... this.
2175
2176 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2177
2178         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2179         from...
2180         (rank_one_type): ... this.
2181
2182 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2183
2184         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2185         from...
2186         (rank_one_type): ... this.
2187
2188 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2189
2190         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2191         from...
2192         (rank_one_type): ... this.
2193
2194 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2195
2196         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2197         from...
2198         (rank_one_type): ... this.
2199
2200 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2201
2202         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2203         from...
2204         (rank_one_type): ... this.
2205
2206 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2207
2208         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2209         from...
2210         (rank_one_type): ... this.
2211
2212 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2213
2214         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2215         inferior-events' shows the example events.
2216
2217 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2218
2219         Support styling on native MS-Windows console
2220
2221         PR/24315
2222         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2223         on MS-Windows if $TERM is not defined.
2224
2225         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2226
2227         * posix-hdep.c (gdb_console_fputs):
2228         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2229         functions.
2230         * ui-file.h (gdb_console_fputs): Add prototype.
2231
2232         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2233         back to fputs only if the former returns zero.
2234
2235 2019-03-07  Tom Tromey  <tom@tromey.com>
2236
2237         * symmisc.c (print_symbol_bcache_statistics): Update.
2238         (print_objfile_statistics): Update.
2239         * symfile.c (allocate_symtab): Update.
2240         * stabsread.c: Don't include bcache.h.
2241         * psymtab.h (struct psymbol_bcache): Don't declare.
2242         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2243         (psymbol_bcache_init, psymbol_bcache_free)
2244         (psymbol_bcache_get_bcache): Don't declare.
2245         * psymtab.c (struct psymbol_bcache): Remove.
2246         (psymtab_storage::psymtab_storage): Update.
2247         (psymtab_storage::~psymtab_storage): Update.
2248         (psymbol_bcache_init, psymbol_bcache_free)
2249         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2250         (add_psymbol_to_bcache): Update.
2251         (allocate_psymtab): Update.
2252         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2253         macro_cache>: No longer pointers.
2254         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2255         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2256         * macrotab.c (macro_bcache): Update.
2257         * macroexp.c: Don't include bcache.h.
2258         * gdbtypes.c (check_types_worklist): Update.
2259         (types_deeply_equal): Remove TRY/CATCH.  Update.
2260         * elfread.c (elf_symtab_read): Update.
2261         * dwarf2read.c: Don't include bcache.h.
2262         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2263         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2264         (print_bcache_statistics, bcache_memory_used): Don't declare.
2265         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2266         methods.  Rename all data members.
2267         * bcache.c (struct bcache): Move to bcache.h.
2268         (bcache::expand_hash_table): Rename from expand_hash_table.
2269         (bcache): Remove.
2270         (bcache::insert): Rename from bcache_full.
2271         (bcache::compare): Rename from bcache_compare.
2272         (bcache_xmalloc): Remove.
2273         (bcache::~bcache): Rename from bcache_xfree.
2274         (bcache::print_statistics): Rename from print_bcache_statistics.
2275         (bcache::memory_used): Rename from bcache_memory_used.
2276
2277 2019-03-07  Pedro Alves  <palves@redhat.com>
2278
2279         * infrun.c (normal_stop): Also check for
2280         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2281
2282 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * f-lang.c (value_from_host_double): Moved to...
2285         * value.c (value_from_host_double): ...here.
2286         * value.h (value_from_host_double): Declare.
2287         * guile/scm-math.c (vlscm_convert_typed_number): Use
2288         value_from_host_double.
2289         (vlscm_convert_number): Likewise.
2290         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2291         * python/py-value.c (convert_value_from_python): Likewise.
2292
2293 2019-03-06  Tom Tromey  <tom@tromey.com>
2294
2295         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2296
2297 2019-03-06  Tom Tromey  <tom@tromey.com>
2298
2299         * utils.h (free_current_contents): Don't declare.
2300         * utils.c (free_current_contents): Remove.
2301
2302 2019-03-06  Tom Tromey  <tom@tromey.com>
2303
2304         * top.c (quit_force): Update.
2305         * main.c (captured_command_loop): Update.
2306         * common/new-op.c (operator new): Update.
2307         * common/common-exceptions.c (struct catcher)
2308         <save_cleanup_chain>: Remove member.
2309         (exceptions_state_mc_init): Update.
2310         (exception_try_scope_entry): Return nullptr.
2311         (exception_try_scope_exit, exception_rethrow)
2312         (throw_exception_sjlj, throw_exception_cxx): Update.
2313         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2314         (all_cleanups, do_cleanups, discard_cleanups)
2315         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2316         (restore_cleanups, restore_final_cleanups): Don't declare.
2317         (do_final_cleanups): Remove parameter.
2318         * common/cleanups.c (cleanup_chain, make_cleanup)
2319         (make_cleanup_dtor, all_cleanups, do_cleanups)
2320         (discard_my_cleanups, discard_cleanups)
2321         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2322         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2323         (null_cleanup): Remove.
2324         (do_final_cleanups): Remove parameter.
2325
2326 2019-03-06  Tom Tromey  <tom@tromey.com>
2327
2328         * remote.c (remote_target::remote_parse_stop_reply): Use
2329         unique_xmalloc_ptr.
2330
2331 2019-03-06  Tom Tromey  <tom@tromey.com>
2332
2333         * stabsread.c (struct stabs_field_info): Rename from field_info.
2334         <list, fnlist>: Add initializers.
2335         <obstack>: New member.
2336         (read_member_functions, read_struct_fields, read_baseclasses):
2337         Allocate on obstack.  Don't use cleanups.
2338         (read_one_struct_field, read_member_functions, read_struct_fields)
2339         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2340         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2341         (read_struct_type): Update.
2342
2343 2019-03-06  Tom Tromey  <tom@tromey.com>
2344
2345         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2346         * common/filestuff.h (make_cleanup_close): Don't declare.
2347         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2348         Remove.
2349
2350 2019-03-06  Tom Tromey  <tom@tromey.com>
2351
2352         * solib-aix.c: Use make_scope_exit.
2353
2354 2019-03-06  Tom Tromey  <tom@tromey.com>
2355
2356         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2357         Use make_scope_exit.
2358
2359 2019-03-06  Tom Tromey  <tom@tromey.com>
2360
2361         * solib-svr4.c (disable_probes_interface): Remove parameter.
2362         (svr4_handle_solib_event): Use make_scope_exit.
2363
2364 2019-03-06  Tom Tromey  <tom@tromey.com>
2365
2366         * remote.c (struct stop_reply_deleter): Remove.
2367         (stop_reply_up): Update.
2368         (struct stop_reply): Derive from notif_event.  Don't typedef.
2369         <regcache>: Now a std::vector.
2370         (stop_reply_xfree): Remove.
2371         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2372         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2373         (remote_target::discard_pending_stop_replies): Use delete.
2374         (remote_target::remote_parse_stop_reply): Update.
2375         (remote_target::process_stop_reply): Update.
2376         * remote-notif.h (struct notif_event): Add virtual destructor.
2377         Remove "dtr" member.
2378         (struct notif_client) <alloc_event>: Return a unique_ptr.
2379         (notif_event_xfree): Don't declare.
2380         (notif_event_up): New typedef.
2381         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2382         (notif_event_xfree, do_notif_event_xfree): Remove.
2383         (remote_notif_state_xfree): Update.
2384
2385 2019-03-06  Tom Tromey  <tom@tromey.com>
2386
2387         * infrun.c (displaced_step_clear_cleanup): Now a
2388         forward_scope_exit type.
2389         (displaced_step_prepare_throw): Update.
2390         (displaced_step_fixup): Update.
2391
2392 2019-03-06  Tom Tromey  <tom@tromey.com>
2393
2394         * inferior.h (class inferior): Update comment.
2395         * gdbthread.h (class thread_info): Update comment.
2396
2397 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2398             Tom Tromey  <tom@tromey.com>
2399
2400         * stabsread.h (struct stab_section_list): Remove.
2401         (coffstab_build_psymtabs): Update.
2402         * dbxread.c (symbuf_sections): Now a std::vector.
2403         (sect_idx): New global.
2404         (fill_symbuf): Update.
2405         (coffstab_build_psymtabs): Change type of stabsects parameter.
2406         Update.
2407         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2408         std::vector.
2409         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2410         (coff_locate_sections): Update.
2411         (coff_symfile_read): Remove cleanups.  Update.
2412         (init_stringtab): Add storage parameter.
2413         (free_stringtab, free_stringtab_cleanup): Remove.
2414         (init_lineno): Add storage parameter.
2415         (free_linetab, free_linetab_cleanup): Remove.
2416
2417 2019-03-06  Pedro Alves  <palves@redhat.com>
2418
2419         * linux-fork.c (fork_info::clobber_regs): Delete.
2420         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2421         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2422         comment.  Adjust.
2423         (scoped_switch_fork_info::scoped_switch_fork_info)
2424         (checkpoint_command, linux_fork_context): Adjust
2425         fork_save_infrun_state calls.
2426
2427 2019-03-06  Pedro Alves  <palves@redhat.com>
2428
2429         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2430         (inf_has_multiple_threads): Return 'bool' and rewrite using
2431         inferior_info::threads().
2432
2433 2019-03-06  Pedro Alves  <palves@redhat.com>
2434
2435         * linux-fork.c: Include <list>.
2436         (fork_list): Now a std::list instance.
2437         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2438         (forks_exist_p, find_last_fork): Adjust.
2439         (new_fork): Delete.
2440         (one_fork_p): New.
2441         (add_fork): Adjust.
2442         (free_fork): Delete, folded into fork_info::~fork_info().
2443         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2444         Adjust.
2445         (init_fork_list): Delete.
2446         (linux_fork_killall, linux_fork_mourn_inferior)
2447         (linux_fork_detach, info_checkpoints_command): Adjust.
2448         (_initialize_linux_fork): No longer call init_fork_list.
2449
2450 2019-03-06  Pedro Alves  <palves@redhat.com>
2451
2452         * linux-fork.c (new_fork): New, split out of ...
2453         (add_fork): ... this.  Return void.  Move "first fork" special
2454         case from here, to ...
2455         (checkpoint_command): ... here.
2456         * linux-linux.h (add_fork): Return void.
2457
2458 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2459
2460         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2461
2462 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2463             Chris January  <chris.january@arm.com>
2464             David Lecomber  <david.lecomber@arm.com>
2465
2466         * f-exp.y: New token, UNOP_INTRINSIC.
2467         (exp): New pattern using UNOP_INTRINSIC token.
2468         (f77_keywords): Add 'abs' keyword.
2469         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2470         (value_from_host_double): New function.
2471         (evaluate_subexp_f): Support UNOP_ABS.
2472
2473 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2474
2475         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2476         types.
2477
2478 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2479
2480         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2481         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2482         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2483
2484 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2485
2486         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2487
2488 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2489             Chris January  <chris.january@arm.com>
2490
2491         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2492         * f-exp.y: Define 'KIND' token.
2493         (exp): New pattern for KIND expressions.
2494         (ptype): Handle types with a kind extension.
2495         (direct_abs_decl): Extend to spot kind extensions.
2496         (f77_keywords): Add 'kind' to the list.
2497         (push_kind_type): New function.
2498         (convert_to_kind_type): New function.
2499         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2500         * parse.c (operator_length_standard): Likewise.
2501         * parser-defs.h (enum type_pieces): Add tp_kind.
2502         * std-operator.def: Add UNOP_KIND.
2503
2504 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2505
2506         * f-exp.y (f_parse): Set yydebug.
2507
2508 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2509
2510         * f-lang.c (evaluate_subexp_f): New function.
2511         (exp_descriptor_f): New global.
2512         (f_language_defn): Use exp_descriptor_f instead of
2513         exp_descriptor_standard.
2514
2515 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2516
2517         * f-exp.y (struct token): Add comments.
2518         (dot_ops): Remove uppercase versions and the end marker.
2519         (f77_keywords): Likewise.
2520         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2521         entries in the dot_ops array are case insensitive, and use
2522         strncasecmp to compare strings.  Also some whitespace cleanup in
2523         this area.  Similar for the f77_keywords array, except entries in
2524         this list might be case sensitive.
2525
2526 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2527
2528         * f-exp.y (struct f77_boolean_val): Add comments.
2529         (boolean_values): Remove uppercase versions, and end marker.
2530         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2531         and use strncasecmp to achieve case insensitivity.  Additionally,
2532         perform whitespace cleanup around this code.
2533
2534 2019-03-06  Tom Tromey  <tromey@adacore.com>
2535
2536         * remote-sim.c (gdbsim_target_open): Use result of
2537         gdb_argv::release.
2538
2539 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2540         Dirk Schubert  <dirk.schubert@arm.com>
2541         Chris January  <chris.january@arm.com>
2542
2543         * eval.c (evaluate_subexp_standard): Call Fortran argument
2544         wrapping logic.
2545         * f-lang.c (struct value): A value which can be passed into a
2546         Fortran function call.
2547         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2548         where appropriate.
2549         (struct type): Value ready for a Fortran function call.
2550         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2551         is needed.
2552         * f-lang.h (fortran_argument_convert): Declaration.
2553         (fortran_preserve_arg_pointer): Declaration.
2554         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2555
2556 2019-03-05  Tom Tromey  <tromey@adacore.com>
2557
2558         * python/py-prettyprint.c (print_string_repr): Remove #if.
2559         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2560
2561 2019-03-05  Tom Tromey  <tromey@adacore.com>
2562
2563         * target.c (the_dummy_target): Move later.  Change type to
2564         "dummy_target".
2565         (initialize_targets): Don't initialize the_dummy_target.
2566
2567 2019-03-05  Tom Tromey  <tromey@adacore.com>
2568
2569         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2570         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2571
2572 2019-03-05  Tom Tromey  <tromey@adacore.com>
2573
2574         * windows-nat.c (windows_nat_target::attach)
2575         (windows_nat_target::detach): Don't call gdb_flush.
2576         * valprint.c (generic_val_print, val_print, val_print_string):
2577         Don't call gdb_flush.
2578         * utils.c (defaulted_query): Don't call gdb_flush.
2579         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2580         * target.c (target_announce_detach): Don't call gdb_flush.
2581         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2582         * remote.c (extended_remote_target::attach): Don't call
2583         gdb_flush.
2584         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2585         * printcmd.c (do_examine): Don't call gdb_flush.
2586         (info_display_command): Don't call gdb_flush.
2587         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2588         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2589         * memattr.c (info_mem_command): Don't call gdb_flush.
2590         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2591         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2592         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2593         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2594         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2595         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2596         (gnu_nat_target::detach): Don't call gdb_flush.
2597         * f-valprint.c (f_val_print): Don't call gdb_flush.
2598         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2599         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2600         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2601         gdb_flush.
2602         * c-valprint.c (c_val_print): Don't call gdb_flush.
2603         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2604
2605 2019-03-05  Tom Tromey  <tromey@adacore.com>
2606
2607         * varobj.c (update_dynamic_varobj_children): Update.
2608         (install_default_visualizer): Use reset, not release.
2609         * value.c (set_internalvar): Update.
2610         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2611         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2612         ATTRIBUTE_UNUSED_RESULT.
2613
2614 2019-03-05  Tom Tromey  <tromey@adacore.com>
2615
2616         * remote.c (class scoped_remote_fd) <release>: Add
2617         ATTRIBUTE_UNUSED_RESULT.
2618
2619 2019-03-05  Tom Tromey  <tromey@adacore.com>
2620
2621         * macroexp.c (struct macro_buffer) <release>: Add
2622         ATTRIBUTE_UNUSED_RESULT.
2623
2624 2019-03-05  Tom Tromey  <tromey@adacore.com>
2625
2626         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2627         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2628         ATTRIBUTE_UNUSED_RESULT.
2629
2630 2019-03-05  Tom Tromey  <tromey@adacore.com>
2631
2632         * common/scoped_fd.h (class scoped_fd) <release>: Add
2633         ATTRIBUTE_UNUSED_RESULT.
2634
2635 2019-03-05  Tom Tromey  <tromey@adacore.com>
2636
2637         * parser-defs.h (struct parser_state) <release>: Add
2638         ATTRIBUTE_UNUSED_RESULT.
2639
2640 2019-03-05  Tom Tromey  <tromey@adacore.com>
2641
2642         * utils.h (class gdb_argv) <release>: Add
2643         ATTRIBUTE_UNUSED_RESULT.
2644         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2645
2646 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2647
2648         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2649         for-loop range, to avoid compiler warnings.
2650
2651         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2652         avoid compiler warnings about unused variables.
2653
2654         * NEWS: Mention end of support for native debugging on MS-Windows
2655         before XP.
2656
2657         PR gdb/24292
2658         * common/netstuff.c:
2659         * gdbserver/gdbreplay.c
2660         * gdbserver/remote-utils.c:
2661         * ser-tcp.c:
2662         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2663         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2664         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2665         'getaddrinfo' and 'freeaddrinfo' were not available before
2666         Windows XP, and mingw.org's MinGW headers by default define
2667         _WIN32_WINNT to 0x500.
2668
2669 2019-03-01  Gary Benson <gbenson@redhat.com>
2670
2671         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2672
2673 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2674             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2675
2676         PR gdb/8527
2677         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2678         set_sigint_trap, clear_sigint_trap.
2679
2680 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2681
2682         * target.c (target_detach): Clear the regcache and the
2683         frame cache.
2684
2685 2019-02-27  Pedro Alves  <palves@redhat.com>
2686
2687         * utils.c (set_screen_size): When we cap the height/width sizes,
2688         tweak the corresponding command variable to show "unlimited":
2689
2690 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2691             Pedro Alves  <palves@redhat.com>
2692
2693         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2694         before calling rl_set_screen_size.
2695
2696 2019-02-27  Tom Tromey  <tromey@adacore.com>
2697
2698         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2699         define.
2700         * python/py-value.c: Remove Python 2.4 workaround.
2701         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2702         workaround.
2703         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2704         Python 2.4 workaround.
2705         * python/python-internal.h: Remove Python 2.4 comment.
2706         (Py_ssize_t): Don't define.
2707         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2708         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2709         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2710         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2711         * python/python.c (do_start_initialization): Remove Python 2.4
2712         workaround.
2713         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2714         (print_children): Remove Python 2.4 workaround.
2715         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2716         workaround.
2717         (CHARBUFFERPROC_NAME): Remove.
2718         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2719         Python 2.4 workaround.
2720
2721 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2722
2723         * NEWS: Note minimum Python version.
2724
2725 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2726
2727         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2728         code from these functions.  Remove corresponding ifdefs.  Use
2729         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2730         Remove gotos and target of gotos.
2731         (infpy_search_memory): Likewise.
2732
2733 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2734
2735         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2736         (hppa_gdbarch_init): Don't register deleted functions with
2737         gdbarch.
2738
2739 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2740
2741         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2742         (h8300_unwind_sp): Delete.
2743         (h8300_dummy_id): Delete.
2744         (h8300_gdbarch_init): Don't register deleted functions with
2745         gdbarch.
2746
2747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2748
2749         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2750         (ft32_unwind_pc): Delete.
2751         (ft32_unwind_sp): Delete.
2752         (ft32_gdbarch_init): Don't register deleted functions with
2753         gdbarch.
2754
2755 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2756
2757         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2758         (frv_unwind_pc): Delete.
2759         (frv_unwind_sp): Delete.
2760         (frv_gdbarch_init): Don't register deleted functions with
2761         gdbarch.
2762
2763 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2764
2765         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2766         (riscv_unwind_pc): Delete.
2767         (riscv_unwind_sp): Delete.
2768         (riscv_gdbarch_init): Don't register deleted functions with
2769         gdbarch.
2770
2771 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2772
2773         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2774         (csky_unwind_pc): Delete.
2775         (csky_unwind_sp): Delete.
2776         (csky_gdbarch_init): Don't register deleted functions with
2777         gdbarch.
2778
2779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2780
2781         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2782         (cris_unwind_pc): Delete.
2783         (cris_unwind_sp): Delete.
2784         (cris_gdbarch_init): Don't register deleted functions with
2785         gdbarch.
2786
2787 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2788
2789         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2790         (bfin_unwind_pc): Delete.
2791         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2792
2793 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2794
2795         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2796         (arm_unwind_pc): Delete.
2797         (arm_unwind_sp): Delete.
2798         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2799
2800 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2801
2802         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2803         (arc_unwind_pc): Delete.
2804         (arc_unwind_sp): Delete.
2805         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2806
2807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2808
2809         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2810         (alpha_unwind_pc): Delete.
2811         (alpha_gdbarch_init): Don't register deleted functions with
2812         gdbarch.
2813
2814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2815
2816         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2817         (aarch64_unwind_pc): Delete.
2818         (aarch64_unwind_sp): Delete.
2819         (aarch64_gdbarch_init): Don't register deleted functions with
2820         gdbarch.
2821
2822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2823
2824         * gdbtypes.c (type_align): Don't consider static members when
2825         computing structure alignment.
2826
2827 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2828
2829         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2830         return 0 for other types.
2831         * arch-utils.c (default_type_align): Always return 0.
2832         * gdbarch.h: Regenerate.
2833         * gdbarch.sh (type_align): Extend comment.
2834         * gdbtypes.c (type_align): Add additional comments, always call
2835         gdbarch_type_align before applying the default rules.
2836         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2837         generic code will then apply a suitable default.
2838         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2839         types, return 0 for other types.
2840
2841 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2842
2843         * NEWS: Create a new section for the next release branch.
2844         Rename the section of the current branch, now that it has
2845         been cut.
2846
2847 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2848
2849         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2850         * version.in: Bump version to 8.3.50.DATE-git.
2851
2852 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2853
2854         * aix-thread.c (ptid_cmp): Remove unused variable.
2855         (get_signaled_thread): Likewise.
2856         (store_regs_user_thread): Likewise.
2857         (store_regs_kernel_thread): Likewise.
2858         (fetch_regs_kernel_thread): Remove shadowed variable.
2859
2860 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2861
2862         * features/riscv/32bit-cpu.xml: Add register numbers.
2863         * features/riscv/32bit-fpu.c: Regenerate.
2864         * features/riscv/32bit-fpu.xml: Add register numbers.
2865         * features/riscv/64bit-cpu.xml: Add register numbers.
2866         * features/riscv/64bit-fpu.c: Regenerate.
2867         * features/riscv/64bit-fpu.xml: Add register numbers.
2868
2869 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2870
2871         * NEWS: Mention two argument form of gdb.Value constructor.
2872         * python/py-value.c (convert_buffer_and_type_to_value): New
2873         function.
2874         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2875         Add support for handling an optional second argument.  Call
2876         convert_buffer_and_type_to_value as appropriate.
2877         * python/python-internal.h (Py_buffer_deleter): New struct.
2878         (Py_buffer_up): New typedef.
2879
2880 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2881
2882         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2883         instead of releasing ownership.
2884
2885 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2886
2887         * dwarf2read.c (open_and_init_dwp_file): Call
2888         elf_numsections instead of bfd_count_sections to initialize
2889         dwp_file->num_sections.
2890
2891 2019-02-25  Tom Tromey  <tromey@adacore.com>
2892
2893         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2894
2895 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2896
2897         * gcore.in: Add '--readnever' option when invoking GDB.
2898
2899 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2900
2901         * MAINTAINERS: Update my email address.
2902
2903 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2904
2905         * build-id.c (build_id_to_debug_bfd_1): New function.
2906         (build_id_to_debug_bfd): Look for separate debug file in
2907         sysroot.
2908
2909 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2910
2911         * gdbarch.sh: Update the copyright year range that is placed into
2912         generated files.
2913
2914 2019-02-22  Keith Seitz  <keiths@redhat.com>
2915
2916         PR symtab/23853
2917         * linespec.c (create_sals_line_offset): Search for the default
2918         symtab's filename instead of its fullname.
2919
2920 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2921
2922         * NEWS: Update style defaults.
2923
2924 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2925
2926         * main.c (captured_main_1): Disable styling in batch mode.
2927
2928 2019-02-20  Tom Tromey  <tom@tromey.com>
2929
2930         * symtab.c (symtab_symbol_info): Fix typos.
2931
2932 2019-02-20  Tom Tromey  <tromey@adacore.com>
2933
2934         * findcmd.c (_initialize_mem_search): Use upper case for
2935         metasyntactic variables.
2936
2937 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2938
2939         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2940         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2941
2942 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2943
2944         * top.h (source_file_name): Change to std::string.
2945         * top.c (source_file_name): Likewise.
2946         (command_line_input): Adjust.
2947         * cli/cli-script.c (script_from_file): Adjust.
2948
2949 2019-02-19  Tom Tromey  <tromey@adacore.com>
2950
2951         * ravenscar-thread.c
2952         (ravenscar_thread_target::update_thread_list): Don't call
2953         ada_build_task_list.
2954         * ada-lang.h (ada_build_task_list): Don't declare.
2955         * ada-tasks.c (struct ada_tasks_inferior_data)
2956         <task_list_valid_p>: Now bool.
2957         (read_known_tasks, ada_task_list_changed)
2958         (ada_tasks_invalidate_inferior_data): Update.
2959         (read_known_tasks_array): Return bool.
2960         (read_known_tasks_list): Likewise.
2961         (read_known_tasks): Return void.
2962         (ada_build_task_list): Now static.
2963
2964 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2965
2966         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2967         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2968
2969 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2970
2971         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2972         variant for ada_tasks_pspace_data_handle and
2973         ada_tasks_inferior_data_handle.
2974         (ada_tasks_pspace_data_cleanup): New function.
2975         (ada_tasks_inferior_data_cleanup): New function.
2976
2977 2019-02-17  Tom Tromey  <tom@tromey.com>
2978
2979         * macrotab.h (macro_source_fullname): Return a std::string.
2980         * macrotab.c (macro_include, check_for_redefinition)
2981         (macro_undef, macro_lookup_definition, foreach_macro)
2982         (foreach_macro_in_scope): Update.
2983         (macro_source_fullname): Return a std::string.
2984         * macrocmd.c (show_pp_source_pos): Update.
2985
2986 2019-02-17  Tom Tromey  <tom@tromey.com>
2987
2988         * macrocmd.c (show_pp_source_pos): Style the file names.
2989
2990 2019-02-17  Tom Tromey  <tom@tromey.com>
2991
2992         PR tui/24197:
2993         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2994
2995 2019-02-17  Tom Tromey  <tom@tromey.com>
2996
2997         * ada-lang.c (user_select_syms): Use filtered printing.
2998         * utils.c (wrap_style): New global.
2999         (desired_style): Remove.
3000         (emit_style_escape): Add stream parameter.
3001         (set_output_style, reset_terminal_style, prompt_for_continue):
3002         Update.
3003         (flush_wrap_buffer): Only flush gdb_stdout.
3004         (wrap_here): Set wrap_style.
3005         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3006         treat escape sequences as a character.  Change when wrap buffer is
3007         flushed.
3008         (fputs_styled): Do not set the output style when the default is
3009         requested.
3010         * ui-style.h (struct ui_file_style) <is_default>: New method.
3011         * source.c (print_source_lines_base): Emit escape sequences in one
3012         piece.
3013
3014 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3015
3016         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3017         integers and enumeration types.
3018
3019 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3020
3021         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3022         instead of lookup_symbol_in_language
3023         (do_exact_match): New function.
3024         (ada_get_symbol_name_matcher): Return do_exact_match when
3025         doing a verbatim match.
3026
3027 2019-02-15  Tom Tromey  <tromey@adacore.com>
3028
3029         * ravenscar-thread.c (ravenscar_thread_target::resume)
3030         (ravenscar_thread_target::wait): Special case wildcard requests.
3031
3032 2019-02-15  Tom Tromey  <tromey@adacore.com>
3033
3034         * ravenscar-thread.c (base_ptid): Remove.
3035         (struct ravenscar_thread_target) <close>: New method.
3036         <m_base_ptid>: New member.
3037         <update_inferior_ptid, active_task, task_is_currently_active,
3038         runtime_initialized>: Declare methods.
3039         <ravenscar_thread_target>: Add constructor.
3040         (ravenscar_thread_target::task_is_currently_active)
3041         (ravenscar_thread_target::update_inferior_ptid)
3042         (ravenscar_runtime_initialized): Rename.  Now methods.
3043         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3044         (ravenscar_thread_target::update_thread_list): Update.
3045         (ravenscar_thread_target::active_task): Now method.
3046         (ravenscar_thread_target::store_registers)
3047         (ravenscar_thread_target::prepare_to_store)
3048         (ravenscar_thread_target::prepare_to_store)
3049         (ravenscar_thread_target::mourn_inferior): Update.
3050         (ravenscar_inferior_created): Use "new" to create target.
3051         (ravenscar_thread_target::get_ada_task_ptid): Update.
3052         (_initialize_ravenscar): Don't initialize base_ptid.
3053         (ravenscar_ops): Remove global.
3054
3055 2019-02-15  Tom Tromey  <tromey@adacore.com>
3056
3057         * target.h (push_target): Declare new overload.
3058         * target.c (push_target): New overload, taking an rvalue reference.
3059         * remote.c (remote_target::open_1): Use push_target overload.
3060         * corelow.c (core_target_open): Use push_target overload.
3061
3062 2019-02-15  Tom Tromey  <tromey@adacore.com>
3063
3064         * ravenscar-thread.c (is_ravenscar_task)
3065         (ravenscar_task_is_currently_active): Return bool.
3066         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3067         (_initialize_ravenscar): Remove "(void)".
3068         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3069         Return bool.
3070
3071 2019-02-15  Tom Tromey  <tromey@adacore.com>
3072
3073         * ravenscar-thread.c (ravenscar_runtime_initializer)
3074         (has_ravenscar_runtime, get_running_thread_id)
3075         (ravenscar_thread_target::resume): Fix indentation.
3076
3077 2019-02-15  Tom Tromey  <tromey@adacore.com>
3078
3079         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3080         from ravenscar_arch_ops.
3081         (sparc_ravenscar_ops::fetch_registers)
3082         (sparc_ravenscar_ops::store_registers): Now methods.
3083         (sparc_ravenscar_prepare_to_store): Remove.
3084         (sparc_ravenscar_ops): Redefine.
3085         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3086         methods and destructor.  Remove members.
3087         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3088         (ravenscar_thread_target::store_registers)
3089         (ravenscar_thread_target::prepare_to_store): Update.
3090         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3091         Remove.
3092         (struct ppc_ravenscar_powerpc_ops): Derive from
3093         ravenscar_arch_ops.
3094         (ppc_ravenscar_powerpc_ops::fetch_registers)
3095         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3096         (ppc_ravenscar_powerpc_ops): Redefine.
3097         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3098         (ppc_ravenscar_e500_ops::fetch_registers)
3099         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3100         (ppc_ravenscar_e500_ops): Redefine.
3101         * aarch64-ravenscar-thread.c
3102         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3103         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3104         (aarch64_ravenscar_fetch_registers)
3105         (aarch64_ravenscar_store_registers): Now methods.
3106         (aarch64_ravenscar_ops): Redefine.
3107
3108 2019-02-15  Tom Tromey  <tromey@adacore.com>
3109
3110         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3111         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3112         (ravenscar_thread_target::stopped_by_watchpoint)
3113         (ravenscar_thread_target::stopped_data_address)
3114         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3115
3116 2019-02-15  Tom Tromey  <tromey@adacore.com>
3117
3118         * ravenscar-thread.c: Fix some typos.
3119
3120 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3121             Tom Tromey  <tromey@adacore.com>
3122
3123         * ada-lang.c (ada_exception_sal): Change addr_string to a
3124         std::string.
3125         (create_ada_exception_catchpoint): Update.
3126
3127 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3128             Tom Tromey  <tromey@adacore.com>
3129
3130         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3131         (bp_location_ops): Remove.
3132         (base_breakpoint_allocate_location): Update.
3133         (free_bp_location): Update.
3134         * ada-lang.c (class ada_catchpoint_location)
3135         <ada_catchpoint_location>: Remove ops parameter.
3136         (ada_catchpoint_location_dtor): Remove.
3137         (ada_catchpoint_location_ops): Remove.
3138         (allocate_location_exception): Update.
3139         * breakpoint.h (struct bp_location_ops): Remove.
3140         (class bp_location) <bp_location>: Remove bp_location_ops
3141         parameter.
3142         <~bp_location>: Add destructor.
3143         <ops>: Remove.
3144
3145 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3146             Pedro Alves  <palves@redhat.com>
3147
3148         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3149         'PATH_MAX'.
3150
3151 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3152             Samuel Thibault  <samuel.thibault@gnu.org>
3153             Thomas Schwinge  <thomas@codesourcery.com>
3154
3155         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3156         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3157
3158 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3159
3160         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3161         (check_empty): Use "const char *".
3162
3163         * gnu-nat.c (gnu_nat_target::detach): Instead of
3164         'detach_inferior (pid)' call
3165         'detach_inferior (find_inferior_pid (pid))'.
3166
3167         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3168         'nat/fork-inferior.o'.
3169         * gnu-nat.c: #include "nat/fork-inferior.h".
3170
3171         * gnu-nat.c (gnu_nat_target::detach): Instead of
3172         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3173         * gnu-nat.h: #include "inf-child.h".
3174         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3175         'i386_gnu_nat_target::fetch_registers'.
3176         (gnu_store_registers): Rename/move to
3177         'i386_gnu_nat_target::store_registers'.
3178
3179         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3180         * gnu-nat.h (mach_thread_info): New function.
3181         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3182
3183         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3184
3185 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3186
3187         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3188
3189 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3190
3191         * windows-nat.c (windows_add_thread): Add new parameter
3192         "main_thread_p" with default value set to false.  Update
3193         function documentation as well as all callers.
3194         (windows_delete_thread): Likewise.
3195         (fake_create_process): Update call to windows_add_thread.
3196         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3197         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3198         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3199         call to windows_delete_thread.
3200
3201 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3202
3203         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3204
3205 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3206
3207         * symfile.c (find_separate_debug_file): Use canonical path of
3208         sysroot with child_path instead of gdb_sysroot if it is valid.
3209
3210 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3211
3212         * symfile.c (find_separate_debug_file): Use child_path to
3213         determine if an object file is under a sysroot.
3214
3215 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3216
3217         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3218         unittests/child-path-selftests.c.
3219         * common/pathstuff.c (child_path): New function.
3220         * common/pathstuff.h (child_path): New prototype.
3221         * unittests/child-path-selftests.c: New file.
3222
3223 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3224
3225         * symfile.c (find_separate_debug_file): Look for separate debug
3226         files in debug directories under the sysroot.
3227
3228 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3229
3230         * symtab.h (struct minimal_symbol data_p): New const method.
3231         (struct minimal_symbol text_p): Likewise.
3232         * symtab.c (output_source_filename): Use file name style
3233         to print file name.
3234         (print_symbol_info): Likewise.
3235         (print_msymbol_info): Use address style to print addresses.
3236         Use function name style to print executable text symbols.
3237         (expand_symtab_containing_pc): Use data_p.
3238         (find_pc_sect_compunit_symtab): Likewise.
3239
3240 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3241
3242         * breakpoint.c (describe_other_breakpoints): Use address style
3243         to print addresses.
3244         (say_where): Likewise.
3245
3246 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3247
3248         * ada-typeprint.c (print_func_type): Print function name
3249         style to print function name.
3250         * c-typeprint.c (c_print_type_1): Likewise.
3251
3252 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3253
3254         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3255         for execve.
3256
3257 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3258
3259         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3260         type_stack.
3261
3262 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3263
3264         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3265         TYPE_CODE_REF types.
3266
3267 2019-02-08  Jim Wilson  <jimw@sifive.com>
3268
3269         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3270         (riscv_linux_fregset): New.
3271         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3272
3273 2019-02-07  Tom Tromey  <tom@tromey.com>
3274
3275         * thread.c (thread_cancel_execution_command): Update.
3276         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3277         methods.
3278         (struct thread_fsm_ops): Remove.
3279         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3280         (thread_fsm_should_stop, thread_fsm_return_value)
3281         (thread_fsm_set_finished, thread_fsm_finished_p)
3282         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3283         Don't declare.
3284         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3285         * infrun.c (clear_proceed_status_thread)
3286         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3287         (print_stop_event): Update.
3288         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3289         Add constructor.
3290         (step_command_fsm_ops): Remove.
3291         (new_step_command_fsm): Remove.
3292         (step_1): Update.
3293         (step_command_fsm::should_stop): Rename from
3294         step_command_fsm_should_stop.
3295         (step_command_fsm::clean_up): Rename from
3296         step_command_fsm_clean_up.
3297         (step_command_fsm::do_async_reply_reason): Rename from
3298         step_command_fsm_async_reply_reason.
3299         (struct until_next_fsm): Inherit from thread_fsm.  Add
3300         constructor.
3301         (until_next_fsm_ops): Remove.
3302         (new_until_next_fsm): Remove.
3303         (until_next_fsm::should_stop): Rename from
3304         until_next_fsm_should_stop.
3305         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3306         (until_next_fsm::do_async_reply_reason): Rename from
3307         until_next_fsm_async_reply_reason.
3308         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3309         constructor.  Change type of breakpoint.
3310         (finish_command_fsm_ops): Remove.
3311         (new_finish_command_fsm): Remove.
3312         (finish_command_fsm::should_stop): Rename from
3313         finish_command_fsm_should_stop.
3314         (finish_command_fsm::clean_up): Rename from
3315         finish_command_fsm_clean_up.
3316         (finish_command_fsm::return_value): Rename from
3317         finish_command_fsm_return_value.
3318         (finish_command_fsm::do_async_reply_reason): Rename from
3319         finish_command_fsm_async_reply_reason.
3320         (finish_command): Update.
3321         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3322         Add constructor.
3323         (call_thread_fsm_ops): Remove.
3324         (call_thread_fsm::call_thread_fsm): Rename from
3325         new_call_thread_fsm.
3326         (call_thread_fsm::should_stop): Rename from
3327         call_thread_fsm_should_stop.
3328         (call_thread_fsm::should_notify_stop): Rename from
3329         call_thread_fsm_should_notify_stop.
3330         (run_inferior_call, call_function_by_hand_dummy): Update.
3331         * cli/cli-interp.c (should_print_stop_to_console): Update.
3332         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3333         Add constructor.  Change type of location_breakpoint,
3334         caller_breakpoint.
3335         (until_break_fsm_ops): Remove.
3336         (new_until_break_fsm): Remove.
3337         (until_break_fsm::should_stop): Rename from
3338         until_break_fsm_should_stop.
3339         (until_break_fsm::clean_up): Rename from
3340         until_break_fsm_clean_up.
3341         (until_break_fsm::do_async_reply_reason): Rename from
3342         until_break_fsm_async_reply_reason.
3343         (until_break_command): Update.
3344         * thread-fsm.c: Remove.
3345         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3346
3347 2019-02-07  Tom Tromey  <tom@tromey.com>
3348
3349         * yy-remap.h: Add include guard.
3350         * xtensa-tdep.h: Add include guard.
3351         * xcoffread.h: Rename include guard.
3352         * varobj-iter.h: Add include guard.
3353         * tui/tui.h: Rename include guard.
3354         * tui/tui-winsource.h: Rename include guard.
3355         * tui/tui-wingeneral.h: Rename include guard.
3356         * tui/tui-windata.h: Rename include guard.
3357         * tui/tui-win.h: Rename include guard.
3358         * tui/tui-stack.h: Rename include guard.
3359         * tui/tui-source.h: Rename include guard.
3360         * tui/tui-regs.h: Rename include guard.
3361         * tui/tui-out.h: Rename include guard.
3362         * tui/tui-layout.h: Rename include guard.
3363         * tui/tui-io.h: Rename include guard.
3364         * tui/tui-hooks.h: Rename include guard.
3365         * tui/tui-file.h: Rename include guard.
3366         * tui/tui-disasm.h: Rename include guard.
3367         * tui/tui-data.h: Rename include guard.
3368         * tui/tui-command.h: Rename include guard.
3369         * tic6x-tdep.h: Add include guard.
3370         * target/waitstatus.h: Rename include guard.
3371         * target/wait.h: Rename include guard.
3372         * target/target.h: Rename include guard.
3373         * target/resume.h: Rename include guard.
3374         * target-float.h: Rename include guard.
3375         * stabsread.h: Add include guard.
3376         * rs6000-tdep.h: Add include guard.
3377         * riscv-fbsd-tdep.h: Add include guard.
3378         * regformats/regdef.h: Rename include guard.
3379         * record.h: Rename include guard.
3380         * python/python.h: Rename include guard.
3381         * python/python-internal.h: Rename include guard.
3382         * python/py-stopevent.h: Rename include guard.
3383         * python/py-ref.h: Rename include guard.
3384         * python/py-record.h: Rename include guard.
3385         * python/py-record-full.h: Rename include guard.
3386         * python/py-record-btrace.h: Rename include guard.
3387         * python/py-instruction.h: Rename include guard.
3388         * python/py-events.h: Rename include guard.
3389         * python/py-event.h: Rename include guard.
3390         * procfs.h: Add include guard.
3391         * proc-utils.h: Add include guard.
3392         * p-lang.h: Add include guard.
3393         * or1k-tdep.h: Rename include guard.
3394         * observable.h: Rename include guard.
3395         * nto-tdep.h: Rename include guard.
3396         * nat/x86-linux.h: Rename include guard.
3397         * nat/x86-linux-dregs.h: Rename include guard.
3398         * nat/x86-gcc-cpuid.h: Add include guard.
3399         * nat/x86-dregs.h: Rename include guard.
3400         * nat/x86-cpuid.h: Rename include guard.
3401         * nat/ppc-linux.h: Rename include guard.
3402         * nat/mips-linux-watch.h: Rename include guard.
3403         * nat/linux-waitpid.h: Rename include guard.
3404         * nat/linux-ptrace.h: Rename include guard.
3405         * nat/linux-procfs.h: Rename include guard.
3406         * nat/linux-osdata.h: Rename include guard.
3407         * nat/linux-nat.h: Rename include guard.
3408         * nat/linux-namespaces.h: Rename include guard.
3409         * nat/linux-btrace.h: Rename include guard.
3410         * nat/glibc_thread_db.h: Rename include guard.
3411         * nat/gdb_thread_db.h: Rename include guard.
3412         * nat/gdb_ptrace.h: Rename include guard.
3413         * nat/fork-inferior.h: Rename include guard.
3414         * nat/amd64-linux-siginfo.h: Rename include guard.
3415         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3416         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3417         * nat/aarch64-linux.h: Rename include guard.
3418         * nat/aarch64-linux-hw-point.h: Rename include guard.
3419         * mn10300-tdep.h: Add include guard.
3420         * mips-linux-tdep.h: Add include guard.
3421         * mi/mi-parse.h: Rename include guard.
3422         * mi/mi-out.h: Rename include guard.
3423         * mi/mi-main.h: Rename include guard.
3424         * mi/mi-interp.h: Rename include guard.
3425         * mi/mi-getopt.h: Rename include guard.
3426         * mi/mi-console.h: Rename include guard.
3427         * mi/mi-common.h: Rename include guard.
3428         * mi/mi-cmds.h: Rename include guard.
3429         * mi/mi-cmd-break.h: Rename include guard.
3430         * m2-lang.h: Add include guard.
3431         * location.h: Rename include guard.
3432         * linux-record.h: Rename include guard.
3433         * linux-nat.h: Add include guard.
3434         * linux-fork.h: Add include guard.
3435         * i386-darwin-tdep.h: Rename include guard.
3436         * hppa-linux-offsets.h: Add include guard.
3437         * guile/guile.h: Rename include guard.
3438         * guile/guile-internal.h: Rename include guard.
3439         * gnu-nat.h: Rename include guard.
3440         * gdb-stabs.h: Rename include guard.
3441         * frv-tdep.h: Add include guard.
3442         * f-lang.h: Add include guard.
3443         * event-loop.h: Add include guard.
3444         * darwin-nat.h: Rename include guard.
3445         * cp-abi.h: Rename include guard.
3446         * config/sparc/nm-sol2.h: Rename include guard.
3447         * config/nm-nto.h: Rename include guard.
3448         * config/nm-linux.h: Add include guard.
3449         * config/i386/nm-i386gnu.h: Rename include guard.
3450         * config/djgpp/nl_types.h: Rename include guard.
3451         * config/djgpp/langinfo.h: Rename include guard.
3452         * compile/gcc-cp-plugin.h: Add include guard.
3453         * compile/gcc-c-plugin.h: Add include guard.
3454         * compile/compile.h: Rename include guard.
3455         * compile/compile-object-run.h: Rename include guard.
3456         * compile/compile-object-load.h: Rename include guard.
3457         * compile/compile-internal.h: Rename include guard.
3458         * compile/compile-cplus.h: Rename include guard.
3459         * compile/compile-c.h: Rename include guard.
3460         * common/xml-utils.h: Rename include guard.
3461         * common/x86-xstate.h: Rename include guard.
3462         * common/version.h: Rename include guard.
3463         * common/vec.h: Rename include guard.
3464         * common/tdesc.h: Rename include guard.
3465         * common/selftest.h: Rename include guard.
3466         * common/scoped_restore.h: Rename include guard.
3467         * common/scoped_mmap.h: Rename include guard.
3468         * common/scoped_fd.h: Rename include guard.
3469         * common/safe-iterator.h: Rename include guard.
3470         * common/run-time-clock.h: Rename include guard.
3471         * common/refcounted-object.h: Rename include guard.
3472         * common/queue.h: Rename include guard.
3473         * common/ptid.h: Rename include guard.
3474         * common/print-utils.h: Rename include guard.
3475         * common/preprocessor.h: Rename include guard.
3476         * common/pathstuff.h: Rename include guard.
3477         * common/observable.h: Rename include guard.
3478         * common/netstuff.h: Rename include guard.
3479         * common/job-control.h: Rename include guard.
3480         * common/host-defs.h: Rename include guard.
3481         * common/gdb_wait.h: Rename include guard.
3482         * common/gdb_vecs.h: Rename include guard.
3483         * common/gdb_unlinker.h: Rename include guard.
3484         * common/gdb_unique_ptr.h: Rename include guard.
3485         * common/gdb_tilde_expand.h: Rename include guard.
3486         * common/gdb_sys_time.h: Rename include guard.
3487         * common/gdb_string_view.h: Rename include guard.
3488         * common/gdb_splay_tree.h: Rename include guard.
3489         * common/gdb_setjmp.h: Rename include guard.
3490         * common/gdb_ref_ptr.h: Rename include guard.
3491         * common/gdb_optional.h: Rename include guard.
3492         * common/gdb_locale.h: Rename include guard.
3493         * common/gdb_assert.h: Rename include guard.
3494         * common/filtered-iterator.h: Rename include guard.
3495         * common/filestuff.h: Rename include guard.
3496         * common/fileio.h: Rename include guard.
3497         * common/environ.h: Rename include guard.
3498         * common/common-utils.h: Rename include guard.
3499         * common/common-types.h: Rename include guard.
3500         * common/common-regcache.h: Rename include guard.
3501         * common/common-inferior.h: Rename include guard.
3502         * common/common-gdbthread.h: Rename include guard.
3503         * common/common-exceptions.h: Rename include guard.
3504         * common/common-defs.h: Rename include guard.
3505         * common/common-debug.h: Rename include guard.
3506         * common/cleanups.h: Rename include guard.
3507         * common/buffer.h: Rename include guard.
3508         * common/btrace-common.h: Rename include guard.
3509         * common/break-common.h: Rename include guard.
3510         * cli/cli-utils.h: Rename include guard.
3511         * cli/cli-style.h: Rename include guard.
3512         * cli/cli-setshow.h: Rename include guard.
3513         * cli/cli-script.h: Rename include guard.
3514         * cli/cli-interp.h: Rename include guard.
3515         * cli/cli-decode.h: Rename include guard.
3516         * cli/cli-cmds.h: Rename include guard.
3517         * charset-list.h: Add include guard.
3518         * buildsym-legacy.h: Rename include guard.
3519         * bfin-tdep.h: Add include guard.
3520         * ax.h: Rename include guard.
3521         * arm-linux-tdep.h: Add include guard.
3522         * arm-fbsd-tdep.h: Add include guard.
3523         * arch/xtensa.h: Rename include guard.
3524         * arch/tic6x.h: Add include guard.
3525         * arch/i386.h: Add include guard.
3526         * arch/arm.h: Rename include guard.
3527         * arch/arm-linux.h: Rename include guard.
3528         * arch/arm-get-next-pcs.h: Rename include guard.
3529         * arch/amd64.h: Add include guard.
3530         * arch/aarch64-insn.h: Rename include guard.
3531         * arch-utils.h: Rename include guard.
3532         * annotate.h: Add include guard.
3533         * amd64-darwin-tdep.h: Rename include guard.
3534         * aarch64-linux-tdep.h: Add include guard.
3535         * aarch64-fbsd-tdep.h: Add include guard.
3536         * aarch32-linux-nat.h: Add include guard.
3537
3538 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3539
3540         * macrotab.c (macro_define_internal): New function that
3541         factorizes macro_define_object_internal and macro_define_function
3542         code.
3543         (macro_define_object_internal): Use macro_define_internal.
3544         (macro_define_function): Likewise.
3545
3546 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3547
3548         * macrocmd.c (extract_identifier): Return
3549         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3550         callers.
3551
3552 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3553
3554         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3555
3556 2019-02-05  Tom Tromey  <tom@tromey.com>
3557
3558         * target.c (target_stack::unpush): Move assertion earlier.
3559
3560 2019-01-30  Tom Tromey  <tom@tromey.com>
3561
3562         PR python/23615:
3563         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3564         (gdbpy_parse_and_eval): Likewise.
3565         * python/python-internal.h (gdbpy_allow_threads): New class.
3566
3567 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3568
3569         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3570         (aarch64_fbsd_fpregmap): Move earlier.
3571         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3572         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3573         instead of individual calls to trad_frame_set_reg_addr.
3574         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3575         earlier.
3576         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3577         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3578         instead of individual calls to trad_frame_set_reg_addr.
3579
3580 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3581
3582         * CONTRIBUTE: Replace contribution list with wiki link.
3583
3584 2019-01-25  Tom Tromey  <tom@tromey.com>
3585
3586         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3587
3588 2019-01-25  Tom Tromey  <tom@tromey.com>
3589
3590         * xtensa-linux-nat.c: Fix common/ includes.
3591         * xml-support.h: Fix common/ includes.
3592         * xml-support.c: Fix common/ includes.
3593         * x86-linux-nat.c: Fix common/ includes.
3594         * windows-nat.c: Fix common/ includes.
3595         * varobj.h: Fix common/ includes.
3596         * varobj.c: Fix common/ includes.
3597         * value.c: Fix common/ includes.
3598         * valops.c: Fix common/ includes.
3599         * utils.c: Fix common/ includes.
3600         * unittests/xml-utils-selftests.c: Fix common/ includes.
3601         * unittests/utils-selftests.c: Fix common/ includes.
3602         * unittests/unpack-selftests.c: Fix common/ includes.
3603         * unittests/tracepoint-selftests.c: Fix common/ includes.
3604         * unittests/style-selftests.c: Fix common/ includes.
3605         * unittests/string_view-selftests.c: Fix common/ includes.
3606         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3607         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3608         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3609         * unittests/rsp-low-selftests.c: Fix common/ includes.
3610         * unittests/parse-connection-spec-selftests.c: Fix common/
3611         includes.
3612         * unittests/optional-selftests.c: Fix common/ includes.
3613         * unittests/offset-type-selftests.c: Fix common/ includes.
3614         * unittests/observable-selftests.c: Fix common/ includes.
3615         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3616         * unittests/memrange-selftests.c: Fix common/ includes.
3617         * unittests/memory-map-selftests.c: Fix common/ includes.
3618         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3619         * unittests/function-view-selftests.c: Fix common/ includes.
3620         * unittests/environ-selftests.c: Fix common/ includes.
3621         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3622         * unittests/common-utils-selftests.c: Fix common/ includes.
3623         * unittests/cli-utils-selftests.c: Fix common/ includes.
3624         * unittests/array-view-selftests.c: Fix common/ includes.
3625         * ui-file.c: Fix common/ includes.
3626         * tui/tui-io.c: Fix common/ includes.
3627         * tracepoint.h: Fix common/ includes.
3628         * tracepoint.c: Fix common/ includes.
3629         * tracefile-tfile.c: Fix common/ includes.
3630         * top.h: Fix common/ includes.
3631         * top.c: Fix common/ includes.
3632         * thread.c: Fix common/ includes.
3633         * target/waitstatus.h: Fix common/ includes.
3634         * target/waitstatus.c: Fix common/ includes.
3635         * target.h: Fix common/ includes.
3636         * target.c: Fix common/ includes.
3637         * target-memory.c: Fix common/ includes.
3638         * target-descriptions.c: Fix common/ includes.
3639         * symtab.h: Fix common/ includes.
3640         * symfile.c: Fix common/ includes.
3641         * stap-probe.c: Fix common/ includes.
3642         * spu-linux-nat.c: Fix common/ includes.
3643         * sparc-nat.c: Fix common/ includes.
3644         * source.c: Fix common/ includes.
3645         * solib.c: Fix common/ includes.
3646         * solib-target.c: Fix common/ includes.
3647         * ser-unix.c: Fix common/ includes.
3648         * ser-tcp.c: Fix common/ includes.
3649         * ser-pipe.c: Fix common/ includes.
3650         * ser-base.c: Fix common/ includes.
3651         * selftest-arch.c: Fix common/ includes.
3652         * s12z-tdep.c: Fix common/ includes.
3653         * rust-exp.y: Fix common/ includes.
3654         * rs6000-aix-tdep.c: Fix common/ includes.
3655         * riscv-tdep.c: Fix common/ includes.
3656         * remote.c: Fix common/ includes.
3657         * remote-notif.h: Fix common/ includes.
3658         * remote-fileio.h: Fix common/ includes.
3659         * remote-fileio.c: Fix common/ includes.
3660         * regcache.h: Fix common/ includes.
3661         * regcache.c: Fix common/ includes.
3662         * record-btrace.c: Fix common/ includes.
3663         * python/python.c: Fix common/ includes.
3664         * python/py-type.c: Fix common/ includes.
3665         * python/py-inferior.c: Fix common/ includes.
3666         * progspace.h: Fix common/ includes.
3667         * producer.c: Fix common/ includes.
3668         * procfs.c: Fix common/ includes.
3669         * proc-api.c: Fix common/ includes.
3670         * printcmd.c: Fix common/ includes.
3671         * ppc-linux-nat.c: Fix common/ includes.
3672         * parser-defs.h: Fix common/ includes.
3673         * osdata.c: Fix common/ includes.
3674         * obsd-nat.c: Fix common/ includes.
3675         * nat/x86-linux.c: Fix common/ includes.
3676         * nat/x86-linux-dregs.c: Fix common/ includes.
3677         * nat/x86-dregs.h: Fix common/ includes.
3678         * nat/x86-dregs.c: Fix common/ includes.
3679         * nat/ppc-linux.c: Fix common/ includes.
3680         * nat/mips-linux-watch.h: Fix common/ includes.
3681         * nat/mips-linux-watch.c: Fix common/ includes.
3682         * nat/linux-waitpid.c: Fix common/ includes.
3683         * nat/linux-ptrace.h: Fix common/ includes.
3684         * nat/linux-ptrace.c: Fix common/ includes.
3685         * nat/linux-procfs.c: Fix common/ includes.
3686         * nat/linux-personality.c: Fix common/ includes.
3687         * nat/linux-osdata.c: Fix common/ includes.
3688         * nat/linux-namespaces.c: Fix common/ includes.
3689         * nat/linux-btrace.h: Fix common/ includes.
3690         * nat/linux-btrace.c: Fix common/ includes.
3691         * nat/fork-inferior.c: Fix common/ includes.
3692         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3693         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3694         * nat/aarch64-linux.c: Fix common/ includes.
3695         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3696         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3697         * namespace.h: Fix common/ includes.
3698         * mips-linux-tdep.c: Fix common/ includes.
3699         * minsyms.c: Fix common/ includes.
3700         * mi/mi-parse.h: Fix common/ includes.
3701         * mi/mi-main.c: Fix common/ includes.
3702         * mi/mi-cmd-env.c: Fix common/ includes.
3703         * memrange.h: Fix common/ includes.
3704         * memattr.c: Fix common/ includes.
3705         * maint.h: Fix common/ includes.
3706         * maint.c: Fix common/ includes.
3707         * main.c: Fix common/ includes.
3708         * machoread.c: Fix common/ includes.
3709         * location.c: Fix common/ includes.
3710         * linux-thread-db.c: Fix common/ includes.
3711         * linux-nat.c: Fix common/ includes.
3712         * linux-fork.c: Fix common/ includes.
3713         * inline-frame.c: Fix common/ includes.
3714         * infrun.c: Fix common/ includes.
3715         * inflow.c: Fix common/ includes.
3716         * inferior.h: Fix common/ includes.
3717         * inferior.c: Fix common/ includes.
3718         * infcmd.c: Fix common/ includes.
3719         * inf-ptrace.c: Fix common/ includes.
3720         * inf-child.c: Fix common/ includes.
3721         * ia64-linux-nat.c: Fix common/ includes.
3722         * i387-tdep.c: Fix common/ includes.
3723         * i386-tdep.c: Fix common/ includes.
3724         * i386-linux-tdep.c: Fix common/ includes.
3725         * i386-linux-nat.c: Fix common/ includes.
3726         * i386-go32-tdep.c: Fix common/ includes.
3727         * i386-fbsd-tdep.c: Fix common/ includes.
3728         * i386-fbsd-nat.c: Fix common/ includes.
3729         * guile/scm-type.c: Fix common/ includes.
3730         * guile/guile.c: Fix common/ includes.
3731         * go32-nat.c: Fix common/ includes.
3732         * gnu-nat.c: Fix common/ includes.
3733         * gdbthread.h: Fix common/ includes.
3734         * gdbarch-selftests.c: Fix common/ includes.
3735         * gdb_usleep.c: Fix common/ includes.
3736         * gdb_select.h: Fix common/ includes.
3737         * gdb_bfd.c: Fix common/ includes.
3738         * gcore.c: Fix common/ includes.
3739         * fork-child.c: Fix common/ includes.
3740         * findvar.c: Fix common/ includes.
3741         * fbsd-nat.c: Fix common/ includes.
3742         * event-top.c: Fix common/ includes.
3743         * event-loop.c: Fix common/ includes.
3744         * dwarf2read.c: Fix common/ includes.
3745         * dwarf2loc.c: Fix common/ includes.
3746         * dwarf2-frame.c: Fix common/ includes.
3747         * dwarf-index-cache.c: Fix common/ includes.
3748         * dtrace-probe.c: Fix common/ includes.
3749         * disasm-selftests.c: Fix common/ includes.
3750         * defs.h: Fix common/ includes.
3751         * csky-tdep.c: Fix common/ includes.
3752         * cp-valprint.c: Fix common/ includes.
3753         * cp-support.h: Fix common/ includes.
3754         * cp-support.c: Fix common/ includes.
3755         * corelow.c: Fix common/ includes.
3756         * completer.h: Fix common/ includes.
3757         * completer.c: Fix common/ includes.
3758         * compile/compile.c: Fix common/ includes.
3759         * compile/compile-loc2c.c: Fix common/ includes.
3760         * compile/compile-cplus-types.c: Fix common/ includes.
3761         * compile/compile-cplus-symbols.c: Fix common/ includes.
3762         * command.h: Fix common/ includes.
3763         * cli/cli-dump.c: Fix common/ includes.
3764         * cli/cli-cmds.c: Fix common/ includes.
3765         * charset.c: Fix common/ includes.
3766         * build-id.c: Fix common/ includes.
3767         * btrace.h: Fix common/ includes.
3768         * btrace.c: Fix common/ includes.
3769         * breakpoint.h: Fix common/ includes.
3770         * breakpoint.c: Fix common/ includes.
3771         * ax.h: 
3772         (enum agent_op): Fix common/ includes.
3773         * ax-general.c (struct aop_map): Fix common/ includes.
3774         * ax-gdb.c: Fix common/ includes.
3775         * auxv.c: Fix common/ includes.
3776         * auto-load.c: Fix common/ includes.
3777         * arm-tdep.c: Fix common/ includes.
3778         * arch/riscv.c: Fix common/ includes.
3779         * arch/ppc-linux-common.c: Fix common/ includes.
3780         * arch/i386.c: Fix common/ includes.
3781         * arch/arm.c: Fix common/ includes.
3782         * arch/arm-linux.c: Fix common/ includes.
3783         * arch/arm-get-next-pcs.c: Fix common/ includes.
3784         * arch/amd64.c: Fix common/ includes.
3785         * arch/aarch64.c: Fix common/ includes.
3786         * arch/aarch64-insn.c: Fix common/ includes.
3787         * arch-utils.c: Fix common/ includes.
3788         * amd64-windows-tdep.c: Fix common/ includes.
3789         * amd64-tdep.c: Fix common/ includes.
3790         * amd64-sol2-tdep.c: Fix common/ includes.
3791         * amd64-obsd-tdep.c: Fix common/ includes.
3792         * amd64-nbsd-tdep.c: Fix common/ includes.
3793         * amd64-linux-tdep.c: Fix common/ includes.
3794         * amd64-linux-nat.c: Fix common/ includes.
3795         * amd64-fbsd-tdep.c: Fix common/ includes.
3796         * amd64-fbsd-nat.c: Fix common/ includes.
3797         * amd64-dicos-tdep.c: Fix common/ includes.
3798         * amd64-darwin-tdep.c: Fix common/ includes.
3799         * agent.c: Fix common/ includes.
3800         * ada-lang.h: Fix common/ includes.
3801         * ada-lang.c: Fix common/ includes.
3802         * aarch64-tdep.c: Fix common/ includes.
3803
3804 2019-01-25  Tom Tromey  <tom@tromey.com>
3805
3806         * common/create-version.sh: Use common/version.h.
3807
3808 2019-01-24  Pedro Alves  <palves@redhat.com>
3809
3810         * infrun.c (signal_stop, signal_print, signal_program)
3811         (signal_catch, signal_pass): Now arrays instead of pointers.
3812         (update_signals_program_target, do_target_resume)
3813         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3814         * linux-nat.c (linux_nat_target::pass_signals)
3815         (linux_nat_target::create_inferior, linux_nat_target::attach):
3816         Adjust.
3817         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3818         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3819         * procfs.c (procfs_target::pass_signals): Adjust.
3820         * record-full.c (record_full_target::resume): Adjust.
3821         * remote.c (remote_target::pass_signals)
3822         (remote_target::program_signals): Adjust.
3823         * target-debug.h (target_debug_print_signals): Now takes a
3824         gdb::array_view as parameter.  Adjust.
3825         * target.h (target_ops) <pass_signals, program_signals>: Replace
3826         pointer and length parameters with gdb::array_view.
3827         (target_pass_signals, target_program_signals): Likewise.
3828         * target-delegates.c: Regenerate.
3829
3830 2019-01-24  Pedro Alves  <palves@redhat.com>
3831
3832         * common/forward-scope-exit.h
3833         (forward_scope_exit::forward_scope_exit): Pass arguments to
3834         m_bind_function directly, instead of creating a std::bind and
3835         copying that.
3836
3837 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3838
3839         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3840         for static members.
3841         (pass_in_v_vfp_candidate): Likewise.
3842
3843 2019-01-23  Tom Tromey  <tom@tromey.com>
3844             Pedro Alves  <palves@redhat.com>
3845
3846         * regcache.c (class regcache_invalidator): Remove.
3847         (regcache::raw_write): Use make_scope_exit.
3848
3849 2019-01-23  Tom Tromey  <tom@tromey.com>
3850
3851         * ui-out.h (class ui_out_emit_type): Update comment.
3852
3853 2019-01-23  Tom Tromey  <tom@tromey.com>
3854
3855         * infrun.c (fetch_inferior_event): Update comment.
3856
3857 2019-01-23  Tom Tromey  <tom@tromey.com>
3858             Pedro Alves  <palves@redhat.com>
3859
3860         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3861         parameter.
3862         (fetch_inferior_event): Use SCOPE_EXIT.
3863
3864
3865 2019-01-23  Tom Tromey  <tom@tromey.com>
3866             Pedro Alves  <palves@redhat.com>
3867
3868         * infrun.c (disable_thread_events): Delete.
3869         (stop_all_threads): Use SCOPE_EXIT.
3870
3871 2019-01-23  Tom Tromey  <tom@tromey.com>
3872             Pedro Alves  <palves@redhat.com>
3873
3874         * symfile.c: Include forward-scope-exit.h.
3875         (clear_symtab_users_cleanup): Replace forward declaration with
3876         a FORWARD_SCOPE_EXIT.
3877         (syms_from_objfile_1): Use the forward_scope_exit and
3878         gdb::optional instead of cleanup_function.
3879         (reread_symbols): Use the forward_scope_exit instead of
3880         cleanup_function.
3881         (clear_symtab_users_cleanup): Remove function.
3882
3883 2019-01-23  Tom Tromey  <tom@tromey.com>
3884             Pedro Alves  <palves@redhat.com>
3885
3886         * linux-nat.c: Include scope-exit.h.
3887         (cleanup_target_stop): Remove.
3888         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3889         SCOPE_EXIT.
3890
3891 2019-01-23  Tom Tromey  <tom@tromey.com>
3892             Pedro Alves  <palves@redhat.com>
3893
3894         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3895         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3896
3897 2019-01-23  Tom Tromey  <tom@tromey.com>
3898             Andrew Burgess  <andrew.burgess@embecosm.com>
3899             Pedro Alves  <palves@redhat.com>
3900
3901         * infrun.c (fetch_inferior_event): Use scope_exit.
3902         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3903         * top.c (execute_command): Use scope_exit.
3904         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3905         * utils.c (do_bpstat_clear_actions_cleanup)
3906         (make_bpstat_clear_actions_cleanup): Remove.
3907
3908 2019-01-23  Tom Tromey  <tom@tromey.com>
3909             Pedro Alves  <palves@redhat.com>
3910
3911         * infrun.c: Include "common/scope-exit.h"
3912         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3913         (wait_for_inferior): Use SCOPE_EXIT.
3914         (fetch_inferior_event): Use scope_exit.
3915
3916 2019-01-23  Tom Tromey  <tom@tromey.com>
3917             Pedro Alves  <palves@redhat.com>
3918
3919         * breakpoint.c (create_breakpoint): Remove cleanup.
3920
3921 2019-01-23  Tom Tromey  <tom@tromey.com>
3922             Andrew Burgess  <andrew.burgess@embecosm.com>
3923             Pedro Alves  <palves@redhat.com>
3924
3925 2019-01-23  Pedro Alves  <palves@redhat.com>
3926
3927         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3928
3929 2019-01-23  Pedro Alves  <palves@redhat.com>
3930             Andrew Burgess  <andrew.burgess@embecosm.com>
3931
3932         * gdbthread.h: Include "common/forward-scope-exit.h".
3933         (scoped_finish_thread_state): Redefine custom class in terms of
3934         forward_scope_exit.
3935
3936 2019-01-23  Pedro Alves  <palves@redhat.com>
3937             Andrew Burgess  <andrew.burgess@embecosm.com>
3938
3939         * common/forward-scope-exit.h: New file.
3940
3941 2019-01-23  Pedro Alves  <palves@redhat.com>
3942             Andrew Burgess  <andrew.burgess@embecosm.com>
3943             Tom Tromey  <tom@tromey.com>
3944
3945         * common/scope-exit.h: New file.
3946
3947 2019-01-23  Pedro Alves  <palves@redhat.com>
3948
3949         * common/preprocessor.h (ESC): Rename to ...
3950         (ESC_PARENS): ... this.
3951         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3952         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3953
3954 2019-01-23  Tom Tromey  <tom@tromey.com>
3955
3956         * language.h (class scoped_switch_to_sym_language_if_auto):
3957         Initialize m_lang in both cases.
3958
3959 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3960
3961         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3962         with XCNEW.
3963
3964 2019-01-22  Tom Tromey  <tom@tromey.com>
3965
3966         * corelow.c: Do not include sys/file.h.
3967
3968 2019-01-22  Tom Tromey  <tom@tromey.com>
3969
3970         * tui/tui-wingeneral.h: Include gdb_curses.h.
3971
3972 2019-01-22  Tom Tromey  <tom@tromey.com>
3973
3974         * source-cache.h (class source_cache) <get_source_lines,
3975         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3976
3977 2019-01-22  Tom Tromey  <tom@tromey.com>
3978
3979         * remote-fileio.h (struct remote_target): Declare.
3980
3981 2019-01-22  Tom Tromey  <tom@tromey.com>
3982
3983         * python/py-arch.c: Do not include py-ref.h.
3984         * python/py-bpevent.c: Do not include py-ref.h.
3985         * python/py-cmd.c: Do not include py-ref.h.
3986         * python/py-continueevent.c: Do not include py-ref.h.
3987         * python/py-event.h: Do not include py-ref.h.
3988         * python/py-evtregistry.c: Do not include py-ref.h.
3989         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3990         * python/py-frame.c: Do not include py-ref.h.
3991         * python/py-framefilter.c: Do not include py-ref.h.
3992         * python/py-function.c: Do not include py-ref.h.
3993         * python/py-infevents.c: Do not include py-ref.h.
3994         * python/py-linetable.c: Do not include py-ref.h.
3995         * python/py-objfile.c: Do not include py-ref.h.
3996         * python/py-param.c: Do not include py-ref.h.
3997         * python/py-prettyprint.c: Do not include py-ref.h.
3998         * python/py-progspace.c: Do not include py-ref.h.
3999         * python/py-symbol.c: Do not include py-ref.h.
4000         * python/py-symtab.c: Do not include py-ref.h.
4001         * python/py-type.c: Do not include py-ref.h.
4002         * python/py-unwind.c: Do not include py-ref.h.
4003         * python/py-utils.c: Do not include py-ref.h.
4004         * python/py-value.c: Do not include py-ref.h.
4005         * python/py-varobj.c: Do not include py-ref.h.
4006         * python/py-xmethods.c: Do not include py-ref.h.
4007         * python/python.c: Do not include py-ref.h.
4008         * varobj.c: Do not include py-ref.h.
4009
4010 2019-01-22  Tom Tromey  <tom@tromey.com>
4011
4012         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4013         keyword for bcache.
4014
4015 2019-01-22  Tom Tromey  <tom@tromey.com>
4016
4017         * compile/compile-cplus-types.c: Remove a comment by #include.
4018
4019 2019-01-22  Tom Tromey  <tom@tromey.com>
4020
4021         * compile/gcc-c-plugin.h: Include compile-internal.h.
4022
4023 2019-01-22  Tom Tromey  <tom@tromey.com>
4024
4025         * stabsread.c (EXTERN): Do not define.
4026         (symnum, next_symbol_text_func, processing_gcc_compilation)
4027         (within_function, global_sym_chain, global_stabs)
4028         (previous_stab_code, this_object_header_files)
4029         (n_this_object_header_files)
4030         (n_allocated_this_object_header_files): Define.
4031         * stabsread.h (EXTERN): Never define.  Use "extern".
4032
4033 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4034
4035         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4036         history_value.
4037
4038 2019-01-21  Tom Tromey  <tom@tromey.com>
4039
4040         * ui-out.c: Fix includes.
4041         * tui/tui-source.c: Fix includes.
4042         * target.c: Fix includes.
4043         * remote.c: Fix includes.
4044         * regcache.c: Fix includes.
4045         * python/py-block.c: Fix includes.
4046         * printcmd.c: Fix includes.
4047         * or1k-tdep.c: Fix includes.
4048         * mi/mi-main.c: Fix includes.
4049         * m32r-tdep.c: Fix includes.
4050         * csky-tdep.c: Fix includes.
4051         * compile/compile-cplus-types.c: Fix includes.
4052         * cli/cli-interp.c: Fix includes.
4053
4054 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4055
4056         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4057         for padding.
4058
4059 2019-01-16  Tom Tromey  <tom@tromey.com>
4060
4061         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4062         earlier.
4063         (struct objfile) <msymbols_range>: Move from top level.
4064         <msymbols>: New method.
4065         (class objfile_msymbols): Remove.
4066         * symtab.c (default_collect_symbol_completion_matches_break_on):
4067         Update.
4068         * symmisc.c (dump_msymbols): Update.
4069         * stabsread.c (scan_file_globals): Update.
4070         * objc-lang.c (info_selectors_command, info_classes_command)
4071         (find_methods): Update.
4072         * minsyms.c (find_solib_trampoline_target): Update.
4073         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4074         * coffread.c (coff_symfile_read): Update.
4075         * ada-lang.c (ada_lookup_simple_minsym)
4076         (ada_collect_symbol_completion_matches): Update.
4077
4078 2019-01-16  Tom Tromey  <tom@tromey.com>
4079
4080         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4081         type.  Remove no-argument constructor.
4082         <iterator::operator++>: Simplify.
4083         <begin>: Update.
4084         <end>: Use minimal_symbol_count.
4085
4086 2019-01-16  Tom Tromey  <tom@tromey.com>
4087
4088         * objfiles.h (struct objfile) <psymtabs>: New method.
4089         (class objfile_psymtabs): Remove.
4090         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4091         typedef.
4092         <range>: New method.
4093         (require_partial_symbols): Change return type.
4094         * psymtab.c (require_partial_symbols)
4095         (psym_expand_symtabs_matching): Update.
4096         * mdebugread.c (parse_partial_symbols): Update.
4097         * dbxread.c (dbx_end_psymtab): Update.
4098
4099 2019-01-15  Tom Tromey  <tom@tromey.com>
4100
4101         * symtab.c (lookup_objfile_from_block)
4102         (lookup_symbol_in_objfile_symtabs)
4103         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4104         (find_line_symtab, info_sources_command)
4105         (default_collect_symbol_completion_matches_break_on)
4106         (make_source_files_completion_list): Update.
4107         * symmisc.c (print_objfile_statistics, dump_objfile)
4108         (maintenance_print_symbols, maintenance_info_symtabs)
4109         (maintenance_check_symtabs, maintenance_info_line_tables):
4110         Update.
4111         * source.c (select_source_symtab)
4112         (forget_cached_source_info_for_objfile): Update.
4113         * objfiles.h (class objfile_compunits): Remove.
4114         (struct objfile) <compunits_range>: New typedef.
4115         (compunits): New method.
4116         * objfiles.c (objfile_relocate1): Update.
4117         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4118         * maint.c (count_symtabs_and_blocks): Update.
4119         * linespec.c (iterate_over_all_matching_symtabs): Update.
4120         * cp-support.c (add_symbol_overload_list_qualified): Update.
4121         * coffread.c (coff_symtab_read): Update.
4122         * ada-lang.c (add_nonlocal_symbols)
4123         (ada_collect_symbol_completion_matches)
4124         (ada_add_global_exceptions): Update.
4125
4126 2019-01-15  Tom Tromey  <tom@tromey.com>
4127
4128         * progspace.h (program_space) <objfiles_safe_range>: New
4129         typedef.
4130         <objfiles_safe>: New method.
4131         * objfiles.h (class all_objfiles_safe): Remove.
4132         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4133         * jit.c (jit_inferior_exit_hook): Update.
4134
4135 2019-01-17  Tom Tromey  <tom@tromey.com>
4136
4137         * progspace.h (program_space) <objfiles_range>: New typedef.
4138         <objfiles>: New method.
4139         <objfiles_head>: Rename from objfiles.
4140         (object_files): Update.
4141         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4142         * guile/scm-pretty-print.c
4143         (ppscm_find_pretty_printer_from_objfiles): Update.
4144         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4145         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4146         Update.
4147         * python/py-progspace.c (pspy_get_objfiles): Update.
4148         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4149         Update.
4150         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4151         (objfpy_lookup_objfile_by_build_id): Update.
4152         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4153         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4154         Update.
4155         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4156         (expand_symtab_containing_pc, lookup_objfile_from_block)
4157         (lookup_static_symbol, basic_lookup_transparent_type)
4158         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4159         (find_line_symtab, info_sources_command)
4160         (default_collect_symbol_completion_matches_break_on)
4161         (make_source_files_completion_list, find_main_name): Update.
4162         * symmisc.c (print_symbol_bcache_statistics)
4163         (print_objfile_statistics, maintenance_print_symbols)
4164         (maintenance_print_msymbols, maintenance_print_objfiles)
4165         (maintenance_info_symtabs, maintenance_check_symtabs)
4166         (maintenance_expand_symtabs, maintenance_info_line_tables):
4167         Update.
4168         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4169         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4170         (map_overlay_command, unmap_overlay_command)
4171         (simple_overlay_update, expand_symtabs_matching)
4172         (map_symbol_filenames): Update.
4173         * symfile-debug.c (set_debug_symfile): Update.
4174         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4175         Update.
4176         * source.c (select_source_symtab, forget_cached_source_info):
4177         Update.
4178         * solib.c (solib_read_symbols): Update.
4179         * solib-spu.c (append_ocl_sos): Update.
4180         * psymtab.c (maintenance_print_psymbols)
4181         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4182         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4183         * printcmd.c (info_symbol_command): Update.
4184         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4185         Update.
4186         * objfiles.h (class all_objfiles): Remove.
4187         * objfiles.c (have_partial_symbols, have_full_symbols)
4188         (have_minimal_symbols, qsort_cmp, update_section_map)
4189         (shared_objfile_contains_address_p)
4190         (default_iterate_over_objfiles_in_search_order): Update.
4191         * objc-lang.c (info_selectors_command, info_classes_command)
4192         (find_methods): Update.
4193         * minsyms.c (find_solib_trampoline_target): Update.
4194         * maint.c (maintenance_info_sections)
4195         (maintenance_translate_address, count_symtabs_and_blocks):
4196         Update.
4197         * main.c (captured_main_1): Update.
4198         * linux-thread-db.c (try_thread_db_load_from_pdir)
4199         (has_libpthread): Update.
4200         * linespec.c (iterate_over_all_matching_symtabs)
4201         (search_minsyms_for_name): Update.
4202         * jit.c (jit_find_objf_with_entry_addr): Update.
4203         * hppa-tdep.c (find_unwind_entry)
4204         (hppa_lookup_stub_minimal_symbol): Update.
4205         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4206         Update.
4207         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4208         (elf_gnu_ifunc_resolve_by_got): Update.
4209         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4210         * dwarf-index-write.c (save_gdb_index_command): Update.
4211         * cp-support.c (add_symbol_overload_list_qualified): Update.
4212         * breakpoint.c (create_overlay_event_breakpoint)
4213         (create_longjmp_master_breakpoint)
4214         (create_std_terminate_master_breakpoint)
4215         (create_exception_master_breakpoint): Update.
4216         * blockframe.c (find_pc_partial_function): Update.
4217         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4218         (ada_collect_symbol_completion_matches)
4219         (ada_add_global_exceptions): Update.
4220
4221 2019-01-17  Tom Tromey  <tom@tromey.com>
4222
4223         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4224         declare VEC.
4225         (solib_target_parse_libraries): Change return type.
4226         (library_list_start_segment, library_list_start_section)
4227         (library_list_end_library, library_list_start_library); Update.
4228         (solib_target_free_library_list): Remove.
4229         (solib_target_parse_libraries): Remove cleanup.  Change return
4230         type.
4231         (solib_target_current_sos): Update.
4232
4233 2019-01-17  Tom Tromey  <tromey@bapiya>
4234
4235         * valprint.c: Replace "the the" with "the".
4236         * symtab.c: Replace "the the" with "the".
4237         * solib.c: Replace "the the" with "the".
4238         * solib-dsbt.c: Replace "the the" with "the".
4239         * linespec.c: Replace "the the" with "the".
4240         * dwarf2loc.h: Replace "the the" with "the".
4241         * amd64-windows-tdep.c: Replace "the the" with "the".
4242         * aarch64-tdep.c: Replace "the the" with "the".
4243
4244 2019-01-16  Keith Seitz  <keiths@redhat.com>
4245
4246         PR gdb/23773
4247         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4248         <builder>: Rename to ..
4249         <m_builder>: ... this and make private.
4250         (dwarf2_cu::get_builder): New method.  Change all users of
4251         `builder' to use this method.
4252         (dwarf2_start_symtab): Move to ...
4253         (dwarf2_cu::start_symtab): ... here.  Update all callers
4254         (setup_type_unit_groups): Move to ...
4255         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4256         callers.
4257         (dwarf2_cu::reset_builder): New method.
4258         (process_full_compunit, process_full_type_unit): Use
4259         dwarf2_cu::reset_builder.
4260         (follow_die_offset): Record the ancestor CU if it is different
4261         from the followed DIE's CU.
4262         (follow_die_sig_1): Likewise.
4263
4264 2019-01-15  Tom Tromey  <tom@tromey.com>
4265
4266         * remote.c (class remote_state) <buf>: Now a char_vector.
4267         <buf_size>: Remove.
4268         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4269         parameter.
4270         (remote_target::getpkt_or_notif_sane_1)
4271         (remote_target::getpkt_sane)
4272         (remote_target::getpkt_or_notif_sane): Likewise.
4273         (class remote_target) <putpkt>: New overload.
4274         (remote_target::read_frame): Change type of "buf_p".  Remove
4275         sizeof_p parameter.
4276         (packet_ok): New overload.
4277         (packet_check_result): New overload.
4278         Update all uses.
4279
4280 2019-01-14  Tom Tromey  <tom@tromey.com>
4281
4282         * remote-notif.c (handle_notification, remote_notif_ack)
4283         (remote_notif_parse): Make "buf" const.
4284         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4285         const.
4286         (remote_notif_parse, remote_notif_ack, handle_notification):
4287         Likewise.
4288         * remote.c (remote_notif_stop_parse): Make "buf" const.
4289         (remote_target::remote_parse_stop_reply): Make "buf" const.
4290         (remote_notif_stop_ack): Make "buf" const.
4291
4292 2019-01-14  Tom Tromey  <tom@tromey.com>
4293
4294         * remote.c (remote_console_output): Make parameter const.
4295
4296 2019-01-14  Tom Tromey  <tom@tromey.com>
4297
4298         * target-debug.h (target_debug_print_signals): Constify.
4299         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4300         * procfs.c (procfs_target::pass_signals): Update.
4301         * linux-nat.c (linux_nat_target::pass_signals): Update.
4302         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4303         * target-delegates.c: Rebuild.
4304         * remote.c (remote_target::program_signals): Update.
4305         (remote_target::pass_signals): Update.
4306         * target.c (target_pass_signals): Constify argument.
4307         (target_program_signals): Likewise.
4308         * target.h (struct target_ops) <pass_signals, program_signals>:
4309         Constify argument.
4310         (target_pass_signals, target_program_signals): Constify argument.
4311
4312 2019-01-14  Tom Tromey  <tom@tromey.com>
4313
4314         PR tui/28819:
4315         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4316
4317 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4318
4319         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4320         field.
4321         * rs6000-tdep.c: Include reggroups.h.
4322         (IS_V_ALIAS_PSEUDOREG): Define.
4323         (rs6000_register_name): Return names for the "vX" aliases.
4324         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4325         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4326         aliases.  Call default_register_reggroup_p for all other
4327         pseudo-registers.
4328         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4329         New functions.
4330         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4331         Handle "vX" aliases.
4332         (v_alias_pseudo_register_collect): New function.
4333         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4334         (rs6000_gdbarch_init): Initialize "vX" aliases as
4335         pseudo-registers.  Restore registration of
4336         rs6000_pseudo_register_reggroup_p with
4337         set_tdesc_pseudo_register_reggroup_p.
4338
4339 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4340
4341         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4342         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4343         set_gdbarch_num_pseudo_regs.
4344
4345 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4346
4347         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4348         Remove arg prefixname, add do_set and do_show.
4349         Add member functions set_list and show_list.
4350         * cli/cli-style.c (class cli_style_option): Update accordingly.
4351         (style_set_list): Move to file scope.
4352         (style_show_list): Likewise.
4353         (set_style): Call help_list.
4354         (show_style): Call cmd_show_list.
4355         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4356         Update to use the new macro.
4357
4358 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4359
4360         * ada-lang.c (_initialize_ada_language): Expand the help text
4361         for the "catch exception" command.
4362
4363 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4364
4365         * symtab.c (matching_obj_sections): Initialize obj,
4366         declare it closer to its usage.
4367
4368 2019-01-10  Tom Tromey  <tom@tromey.com>
4369
4370         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4371         (basic_inf_threads_range): Remove.
4372         (inf_threads_range, inf_non_exited_threads_range)
4373         (safe_inf_threads_range): Use next_adapter.
4374
4375 2019-01-10  Keith Seitz  <keiths@redhat.com>
4376
4377         PR gdb/23712
4378         PR symtab/23010
4379         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4380         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4381
4382 2019-01-10  Keith Seitz  <keiths@redhat.com>
4383
4384         PR gdb/23712
4385         PR symtab/23010
4386         * dictionary.c (pending_to_vector): Remove.
4387         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4388         Remove _1 suffix, replacing functions of the same name.  Update
4389         all callers.
4390         (dict_create_hashed, dict_create_hashed_expandable)
4391         (dict_create_linear, dict_create_linear_expandable, dict_free)
4392         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4393         Make functions static.
4394
4395 2019-01-10  Keith Seitz  <keiths@redhat.com>
4396
4397         PR gdb/23712
4398         PR symtab/23010
4399         * dictionary.h (struct dictionary): Replace declaration with
4400         multidictionary.
4401         (dict_create_hashed, dict_create_hashed_expandable)
4402         (dict_create_linear, dict_create_linear_expandable)
4403         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4404         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4405         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4406         taking multidictionary argument.
4407         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4408         * block.h (struct block) <dict>: Change to multidictionary
4409         and rename `multidict'.
4410         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4411         symmisc.c: Update all dictionary references to multidictionary.
4412
4413 2019-01-10  Keith Seitz  <keiths@redhat.com>
4414
4415         PR gdb/23712
4416         PR symtab/23010
4417         * dictionary.c: Include unordered_map.
4418         (pending_to_vector): New function.
4419         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4420         Rewrite the non-"_1" functions to take vector instead
4421         of linked list.
4422         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4423         "new" _1 versions of the same name.
4424         (multidictionary): Define.
4425         (std::hash<enum language): New definition.
4426         (collate_pending_symbols_by_language, mdict_create_hashed)
4427         (mdict_create_hashed_expandable, mdict_create_linear)
4428         (mdict_create_linear_expandable, mdict_free)
4429         (find_language_dictionary, create_new_language_dictionary)
4430         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4431         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4432         (mdict_size, mdict_empty): New functions.
4433         * dictionary.h (mdict_iterator): Define.
4434
4435 2019-01-10  Pedro Alves  <palves@redhat.com>
4436
4437         * breakpoint.c (read_uploaded_action)
4438         (create_tracepoint_from_upload): Adjust to use
4439         gdb::unique_xmalloc_ptr.
4440         * ctf.c (ctf_write_uploaded_tp):
4441         (SET_ARRAY_FIELD): Use emplace_back.
4442         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4443         * tracefile-tfile.c (tfile_write_uploaded_tp):
4444         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4445         gdb::unique_xmalloc_ptr.
4446         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4447         at_string, cond_string, cmd_strings>: Replace char pointers
4448         with gdb::unique_xmalloc_ptr.
4449
4450 2019-01-10  Pedro Alves  <palves@redhat.com>
4451
4452         * solib-target.c (library_list_start_library): Don't xstrdup name.
4453
4454 2019-01-10  Pedro Alves  <palves@redhat.com>
4455
4456         * mdebugread.c (parse_partial_symbols): Use
4457         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4458
4459 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * linux-fork.c (scoped_switch_fork_info)
4462         <~scoped_switch_fork_info>: Fix incorrect variable name.
4463
4464 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4465
4466         * linux-fork.c (scoped_switch_fork_info)
4467         <scoped_switch_fork_info>: Make explicit.
4468         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4469
4470 2019-01-10  Tom Tromey  <tom@tromey.com>
4471
4472         * objfiles.h (objfile::reset_psymtabs): Update.
4473         * objfiles.c (objfile::objfile): Update.
4474         * psymtab.h (psymtab_storage::obstack): Update.
4475         (psymtab_storage::m_obstack): Use gdb::optional.
4476         (class psymtab_storage): Update comment.  Remove objfile
4477         parameter.
4478         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4479
4480 2019-01-10  Tom Tromey  <tom@tromey.com>
4481
4482         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4483         <free_psymtabs>: Now private.
4484         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4485         (allocate_psymtab): Use new method.
4486
4487 2019-01-10  Tom Tromey  <tom@tromey.com>
4488
4489         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4490         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4491         * mdebugread.c (parse_partial_symbols): Use
4492         allocate_dependencies.
4493         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4494         allocate_dependencies.
4495         (process_psymtab_comp_unit_reader)
4496         (build_type_psymtab_dependencies): Likewise.
4497         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4498
4499 2019-01-10  Tom Tromey  <tom@tromey.com>
4500
4501         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4502         PSYMBOL_SET_LANGUAGE.
4503         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4504
4505 2019-01-10  Tom Tromey  <tom@tromey.com>
4506
4507         * psymtab.h (psymtab_storage::obstack): New method.
4508         <m_obstack>: Rename from obstack; now private.
4509         * psymtab.c (psymtab_storage): Update.
4510         * dwarf2read.c (create_addrmap_from_index)
4511         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4512         Update.
4513
4514 2019-01-10  Tom Tromey  <tom@tromey.com>
4515
4516         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4517         * objfiles.h (objfile::reset_psymtabs): New method.
4518
4519 2019-01-10  Tom Tromey  <tom@tromey.com>
4520
4521         * symmisc.c (print_symbol_bcache_statistics): Update.
4522         (print_objfile_statistics): Update.
4523         * symfile.c (reread_symbols): Update.
4524         * psymtab.h (class psymtab_storage): New.
4525         * psymtab.c (psymtab_storage): New constructor.
4526         (~psymtab_storage): New destructor.
4527         (require_partial_symbols): Update.
4528         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4529         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4530         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4531         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4532         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4533         (start_psymtab_common, end_psymtab_common)
4534         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4535         (allocate_psymtab): Update.
4536         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4537         Update.
4538         (dump_psymtab_addrmap, maintenance_print_psymbols)
4539         (maintenance_check_psymtabs): Update.
4540         (class objfile_psymtabs): Move to objfiles.h.
4541         * psympriv.h (discard_psymtab): Now inline.
4542         (psymtab_discarder::psymtab_discarder): Update.
4543         (psymtab_discarder::~psymtab_discarder): Update.
4544         (ALL_OBJFILE_PSYMTABS): Rewrite.
4545         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4546         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4547         Remove fields.
4548         <partial_symtabs>: New field.
4549         (class objfile_psymtabs): Move from psymtab.h.  Update.
4550         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4551         psymbol_cache.
4552         (objfile::~objfile): Don't destroy psymbol_cache.
4553         * mdebugread.c (parse_partial_symbols): Update.
4554         * dwarf2read.c (create_addrmap_from_index)
4555         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4556         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4557         (add_partial_subprogram, dwarf2_ranges_read): Update.
4558         * dwarf-index-write.c (write_address_map)
4559         (write_one_signatured_type, recursively_write_psymbols)
4560         (class debug_names, class debug_names, write_psymtabs_to_index):
4561         Update.
4562
4563 2019-01-10  Tom Tromey  <tom@tromey.com>
4564
4565         * symtab.h (SYMBOL_SET_NAMES): Update.
4566         (symbol_set_names): Update.
4567         (MSYMBOL_SET_NAMES): Update.
4568         * symtab.c (symbol_set_names): Change argument to be an
4569         objfile_per_bfd_storage.
4570         * psymtab.c (add_psymbol_to_bcache): Update.
4571         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4572
4573 2019-01-10  Tom Tromey  <tom@tromey.com>
4574
4575         * symtab.c (create_demangled_names_hash): Change argument to be an
4576         objfile_per_bfd_storage.
4577         (symbol_set_names): Update.
4578
4579 2019-01-10  Tom Tromey  <tom@tromey.com>
4580
4581         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4582         init_psymbol_list.
4583         * psymtab.c (init_psymbol_list): Do nothing if already called.
4584         * psympriv.h (init_psymbol_list): Add comment.
4585         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4586         init_psymbol_list.
4587         * dbxread.c (dbx_symfile_read): Unconditionally call
4588         init_psymbol_list.
4589
4590 2019-01-10  Tom Tromey  <tom@tromey.com>
4591
4592         * xcoffread.c (scan_xcoff_symtab): Update.
4593         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4594         "where".
4595         * mdebugread.c (parse_partial_symbols)
4596         (handle_psymbol_enumerators): Update.
4597         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4598         * dbxread.c (read_dbx_symtab): Update.
4599         * psympriv.h (psymbol_placement): New enum.
4600         (add_psymbol_to_list): Update.
4601
4602 2019-01-10  Tom Tromey  <tom@tromey.com>
4603
4604         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4605         static_psymbols parameters.
4606         (scan_xcoff_symtab): Update.
4607         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4608         static_psymbols parameters.
4609         * psympriv.h (start_psymtab_common): Update.
4610         * mdebugread.c (parse_partial_symbols): Update.
4611         * dwarf2read.c (create_partial_symtab): Update.
4612         * dbxread.c (read_dbx_symtab): Update.
4613         (start_psymtab): Remove global_psymbols and static_psymbols
4614         parameters.
4615
4616 2019-01-10  Tom Tromey  <tom@tromey.com>
4617
4618         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4619         * psymtab.c (allocate_psymtab): Add comment.
4620         * psympriv.h (allocate_psymtab): Add comment.
4621         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4622         initializations.
4623         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4624
4625 2019-01-10  Tom Tromey  <tom@tromey.com>
4626
4627         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4628         Don't declare.
4629         * mipsread.c: Include mdebugread.h.
4630         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4631         Declare.
4632         * elfread.c: Include mdebugread.h.
4633
4634 2019-01-09  Tom Tromey  <tom@tromey.com>
4635
4636         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4637         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4638         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4639         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4640         (psym_lookup_symbol, psym_find_last_source_symtab)
4641         (psym_forget_cached_source_info, psym_print_stats)
4642         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4643         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4644         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4645         (psym_find_compunit_symtab_by_address)
4646         (maintenance_print_psymbols, maintenance_info_psymtabs)
4647         (maintenance_check_psymtabs): Use ranged for.
4648         * psymtab.h (class objfile_psymtabs): New.
4649         (require_partial_symbols): Return objfile_psymtabs.
4650         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4651
4652 2019-01-09  Tom Tromey  <tom@tromey.com>
4653
4654         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4655         (find_pc_mapped_section, list_overlays_command)
4656         (map_overlay_command, unmap_overlay_command)
4657         (simple_overlay_update): Use all_objfiles.
4658         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4659         * printcmd.c (info_symbol_command): Use all_objfiles.
4660         * objfiles.h (ALL_OBJSECTIONS): Remove.
4661         * maint.c (maintenance_translate_address): Use all_objfiles.
4662         * gcore.c (gcore_create_callback): Use all_objfiles.
4663         (objfile_find_memory_regions): Likewise.
4664
4665 2019-01-09  Tom Tromey  <tom@tromey.com>
4666
4667         * symtab.c (find_line_symtab, info_sources_command)
4668         (make_source_files_completion_list): Use objfile_compunits.
4669         * source.c (select_source_symtab): Use objfile_compunits.
4670         * objfiles.h (struct objfile): Update comment.
4671         (ALL_OBJFILES): Remove.
4672         (ALL_FILETABS): Remove.
4673         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4674         objfile_compunits.
4675
4676 2019-01-09  Tom Tromey  <tom@tromey.com>
4677
4678         * symmisc.c (print_objfile_statistics, dump_objfile)
4679         (maintenance_print_symbols): Use compunit_filetabs.
4680         * source.c (forget_cached_source_info_for_objfile): Use
4681         compunit_filetabs.
4682         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4683         (ALL_FILETABS): Use compunit_filetabs.
4684         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4685         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4686
4687 2019-01-09  Tom Tromey  <tom@tromey.com>
4688
4689         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4690         (compunit_filetabs): New.
4691         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4692         compunit_filetabs.
4693         (info_sources_command, make_source_files_completion_list): Remove
4694         declaration.
4695         * symmisc.c (print_objfile_statistics, dump_objfile)
4696         (maintenance_print_symbols): Remove declaration.
4697         (maintenance_info_symtabs): Use compunit_filetabs.
4698         (maintenance_info_line_tables): Likewise.
4699         * source.c (select_source_symtab): Change local variable name.
4700         (forget_cached_source_info_for_objfile): Remove declaration.
4701         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4702         * objfiles.c (objfile_relocate1): Remove declaration.
4703         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4704         declaration.
4705         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4706         * coffread.c (coff_symtab_read): Remove declaration.
4707         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4708         compunit_filetabs.
4709
4710 2019-01-09  Tom Tromey  <tom@tromey.com>
4711
4712         * symtab.c (lookup_objfile_from_block)
4713         (find_pc_sect_compunit_symtab, search_symbols)
4714         (default_collect_symbol_completion_matches_break_on): Use
4715         objfile_compunits.
4716         * objfiles.h (ALL_COMPUNITS): Remove.
4717         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4718         * cp-support.c (add_symbol_overload_list_qualified): Use
4719         objfile_compunits.
4720         * ada-lang.c (ada_collect_symbol_completion_matches)
4721         (ada_add_global_exceptions): Use objfile_compunits.
4722
4723 2019-01-09  Tom Tromey  <tom@tromey.com>
4724
4725         * source.c (select_source_symtab)
4726         (forget_cached_source_info_for_objfile): Remove declaration.
4727         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4728         declaration.
4729         * maint.c (count_symtabs_and_blocks): Remove declaration.
4730         * cp-support.c (add_symbol_overload_list_qualified): Remove
4731         declaration.
4732         * coffread.c (coff_symtab_read): Remove declaration.
4733         * symtab.c (lookup_symbol_in_objfile_symtabs)
4734         (basic_lookup_transparent_type_1): Use objfile_compunits.
4735         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4736         (info_sources_command, search_symbols)
4737         (default_collect_symbol_completion_matches_break_on)
4738         (make_source_files_completion_list): Remove declaration.
4739         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4740         (ada_collect_symbol_completion_matches)
4741         (ada_add_global_exceptions): Remove declaration.
4742         * linespec.c (iterate_over_all_matching_symtabs): Use
4743         objfile_compunits.
4744         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4745         (class objfile_compunits): New.
4746         (ALL_COMPUNITS): Use objfile_compunits.
4747         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4748         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4749         objfile_compunits.
4750         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4751
4752 2019-01-09  Tom Tromey  <tom@tromey.com>
4753
4754         * symtab.c (search_symbols)
4755         (default_collect_symbol_completion_matches_break_on): Use
4756         objfile_msymbols.
4757         * ada-lang.c (ada_lookup_simple_minsym)
4758         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4759         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4760         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4761         objfile_msymbols.
4762         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4763         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4764         * objc-lang.c (find_methods): Use objfile_msymbols.
4765         (info_selectors_command, info_classes_command): Likewise.
4766         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4767         * objfiles.h (class objfile_msymbols): New.
4768         (ALL_OBJFILE_MSYMBOLS): Remove.
4769         (ALL_MSYMBOLS): Remove.
4770
4771 2019-01-09  Tom Tromey  <tom@tromey.com>
4772
4773         * common/next-iterator.h (next_adapter): Add Iterator template
4774         parameter.
4775         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4776         (class all_objfiles_safe): New.
4777         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4778         * objfiles.c (put_objfile_before): Update comment.
4779         (add_separate_debug_objfile): Likewise.
4780         (free_all_objfiles): Use all_objfiles_safe.
4781         (objfile_purge_solibs): Likewise.
4782
4783 2019-01-09  Tom Tromey  <tom@tromey.com>
4784
4785         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4786         (expand_symtab_containing_pc, lookup_static_symbol)
4787         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4788         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4789         all_objfiles.
4790         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4791         * breakpoint.c (create_overlay_event_breakpoint)
4792         (create_longjmp_master_breakpoint)
4793         (create_std_terminate_master_breakpoint)
4794         (create_exception_master_breakpoint): Use all_objfiles.
4795         * linux-thread-db.c (try_thread_db_load_from_pdir)
4796         (has_libpthread): Use all_objfiles.
4797         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4798         * linespec.c (iterate_over_all_matching_symtabs)
4799         (search_minsyms_for_name): Use all_objfiles.
4800         * maint.c (maintenance_info_sections): Use all_objfiles.
4801         * main.c (captured_main_1): Use all_objfiles.
4802         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4803         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4804         * guile/scm-pretty-print.c
4805         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4806         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4807         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4808         (maintenance_print_msymbols): Use all_objfiles.
4809         * source.c (select_source_symtab): Use all_objfiles.
4810         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4811         * symfile.c (remove_symbol_file_command)
4812         (expand_symtabs_matching, map_symbol_filenames): Use
4813         all_objfiles.
4814         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4815         all_objfiles.
4816         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4817         * objc-lang.c (find_methods): Use all_objfiles.
4818         * objfiles.c (have_partial_symbols, have_full_symbols)
4819         (have_minimal_symbols, qsort_cmp)
4820         (default_iterate_over_objfiles_in_search_order): Use
4821         all_objfiles.
4822         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4823         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4824         (maintenance_check_psymtabs): Use all_objfiles.
4825         (ALL_PSYMTABS): Remove.
4826         * compile/compile-object-run.c (do_module_cleanup): Use
4827         all_objfiles.
4828         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4829         * cp-support.c (add_symbol_overload_list_qualified): Use
4830         all_objfiles.
4831         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4832         Use all_objfiles.
4833         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4834         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4835         all_objfiles.
4836         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4837         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4838         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4839         Uses all_objfiles.
4840         * solib.c (solib_read_symbols): Use all_objfiles
4841
4842 2019-01-09  Tom Tromey  <tom@tromey.com>
4843
4844         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4845         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4846         all_objfiles.
4847         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4848         * symmisc.c (print_symbol_bcache_statistics)
4849         (print_objfile_statistics, maintenance_print_objfiles)
4850         (maintenance_info_symtabs, maintenance_check_symtabs)
4851         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4852         all_objfiles.
4853         * source.c (forget_cached_source_info): Use all_objfiles.
4854         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4855         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4856         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4857         * objfiles.c (update_section_map): Use all_objfiles.
4858         (shared_objfile_contains_address_p): Likewise.
4859         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4860         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4861
4862 2019-01-09  Tom Tromey  <tom@tromey.com>
4863
4864         * common/next-iterator.h: New file.
4865         * objfiles.h (class all_objfiles): New.
4866         (struct objfile_iterator): New.
4867
4868 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4869
4870         * NEWS: Move the description of the changed "frame", "select-frame",
4871          and "info frame" commands to the Changed commands section.
4872
4873 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4874
4875         * gdbtypes.c (check_stub_method_group): Remove handling of old
4876         mangling schemes.
4877         * linespec.c (find_methods): Likewise.
4878         * stabsread.c (read_member_functions): Likewise.
4879         * valops.c (search_struct_method): Likewise.
4880         (value_struct_elt_for_reference): Likewise.
4881         * NEWS: Mention this change.
4882
4883 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4884
4885         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4886         print_source_lines.
4887         * source.c (print_source_lines_base): Update line number check.
4888         (print_source_lines): New function.
4889         (source_lines_range::source_lines_range): New function.
4890         * source.h (class source_lines_range): New class.
4891         (print_source_lines): New declaration.
4892
4893 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4894
4895         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4896
4897 2019-01-08  Tom Tromey  <tom@tromey.com>
4898             Simon Marchi  <simon.marchi@ericsson.com>
4899
4900         PR gdb/24060
4901         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4902         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4903         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4904         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4905         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4906         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4907
4908 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4909
4910         * source.c (select_source_symtab): Move header comment to
4911         declaration in source.h.
4912         (forget_cached_source_info_for_objfile): Likewise.
4913         (forget_cached_source_info): Likewise.
4914         (identify_source_line): Likewise.
4915         * source.h (identify_source_line): Move declaration from symtab.h
4916         and add comment from source.c
4917         (print_source_lines): Likewise.
4918         (forget_cached_source_info_for_objfile): Likewise.
4919         (forget_cached_source_info): Likewise.
4920         (select_source_symtab): Likewise.
4921         (enum print_source_lines_flag): Move definition from symtab.h.
4922         * symtab.h (identify_source_line): Move declaration to source.h.
4923         (print_source_lines): Likewise.
4924         (forget_cached_source_info_for_objfile): Likewise.
4925         (forget_cached_source_info): Likewise.
4926         (select_source_symtab): Likewise.
4927         (enum print_source_lines_flag): Move definition to source.h.
4928         * tui/tui-hooks.c: Add 'source.h' include.
4929
4930 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4931
4932         * source.c (print_source_lines_base): Handle requests to print
4933         reverse line number sequences, and guard against empty lines
4934         string.
4935
4936 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4937
4938         * source.c (print_source_lines_base): Fix skip of '\r' if next
4939         character is '\n'.
4940
4941 2019-01-06  Tom Tromey  <tom@tromey.com>
4942
4943         * c-exp.y (struct c_parse_state) <macro_original_text,
4944         expansion_obstack>: New member.
4945         (macro_original_text, expansion_obstack): Remove globals.
4946         (scan_macro_expansion, scanning_macro_expansion)
4947         (finished_macro_expansion): Update.
4948         (scan_macro_cleanup): Remove.
4949         (yylex, c_parse): Update.
4950
4951 2019-01-06  Tom Tromey  <tom@tromey.com>
4952
4953         * c-exp.y (struct c_parse_state) <strings>: New member.
4954         (operator_stoken): Update.
4955
4956 2019-01-06  Tom Tromey  <tom@tromey.com>
4957
4958         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4959         (union type_stack_elt) <typelist_val>: Now a pointer to
4960         std::vector.
4961         (type_stack_cleanup): Don't declare.
4962         (push_typelist): Update.
4963         * parse.c (pop_typelist): Return a std::vector.
4964         (push_typelist): Take a std::vector.
4965         (follow_types): Update.  Do not free args.
4966         (type_stack_cleanup): Remove.
4967         * c-exp.y (struct c_parse_state): New.
4968         (cpstate): New global.
4969         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4970         (nonempty_typelist): Update.
4971         (func_mod): Create a new vector.
4972         (c_parse): Create a c_parse_state.
4973         (check_parameter_typelist): Do not delete params.
4974         (function_method): Update.  Do not delete type_list.
4975
4976 2019-01-06  Tom Tromey  <tom@tromey.com>
4977
4978         PR gdb/28155:
4979         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4980         check_typedef.
4981         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4982         (print_return_value): Likewise.
4983
4984 2019-01-05  Tom Tromey  <tom@tromey.com>
4985
4986         * contrib/cleanup_check.py: Remove.
4987         * contrib/gcc-with-excheck: Remove.
4988         * contrib/exsummary.py: Remove.
4989         * contrib/excheck.py: Remove.
4990
4991 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4992
4993         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4994         NULL. Initialize tpprev to NULL instead of assigning it
4995         to NULL on the next statement.
4996         * windows-nat.c (windows_delete_thread): Remove check for
4997         main_thread_id before printing thread exit notifications.
4998         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4999         Remove thread ID check against main_thread_id.
5000         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5001         windows_delete_thread.
5002         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5003
5004 2019-01-04  Tom Tromey  <tom@tromey.com>
5005
5006         * compile/compile.c (_initialize_compile): Use upper case for
5007         metasyntactic variables.
5008         * symmisc.c (_initialize_symmisc): Use upper case for
5009         metasyntactic variables.
5010         * psymtab.c (_initialize_psymtab): Use upper case for
5011         metasyntactic variables.
5012         * demangle.c (demangle_command): Use upper case for metasyntactic
5013         variables.
5014         (_initialize_demangler): Likewise.
5015         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5016         variables.
5017
5018 2019-01-03  Tom Tromey  <tom@tromey.com>
5019
5020         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5021
5022 2019-01-03  Tom Tromey  <tom@tromey.com>
5023
5024         * python/py-symtab.c (salpy_str): Update.
5025         (struct salpy_sal_object) <symtab>: Now a PyObject.
5026         (salpy_dealloc): Update.
5027         (del_objfile_sal): Use gdbpy_ref.
5028
5029 2019-01-03  Tom Tromey  <tom@tromey.com>
5030
5031         * python/py-type.c (convert_field): Use new_reference.  Return
5032         gdbpy_ref.
5033         (make_fielditem): Return gdbpy_ref.
5034         (typy_fields): Update.
5035         (typy_getitem): Update.
5036         (field_name): Return gdbpy_ref.  Use new_reference.
5037         (typy_iterator_iternext): Update.
5038
5039 2019-01-03  Tom Tromey  <tom@tromey.com>
5040
5041         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5042
5043 2019-01-03  Tom Tromey  <tom@tromey.com>
5044
5045         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5046         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5047         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5048         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5049         (pspy_set_type_printers): Likewise.
5050         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5051         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5052         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5053         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5054         (objfpy_set_type_printers): Likewise.
5055
5056 2019-01-03  Tom Tromey  <tom@tromey.com>
5057
5058         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5059         (gdbpy_print_stack): Use gdbpy_err_fetch.
5060         * python/python-internal.h (class gdbpy_err_fetch): New class.
5061         (class gdbpy_enter) <m_error_type, m_error_value,
5062         m_error_traceback>: Remove.
5063         <m_error>: New member.
5064         (gdbpy_exception_to_string): Don't declare.
5065         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5066         * python/py-value.c (convert_value_from_python): Use
5067         gdbpy_err_fetch.
5068         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5069         gdbpy_exception_to_string.
5070         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5071         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5072         gdbpy_err_fetch.
5073
5074 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5075
5076         * linux-nat.c (delete_lwp_cleanup): Delete.
5077         (struct lwp_deleter): New struct.
5078         (lwp_info_up): New typedef.
5079         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5080         lwp_info_up.
5081
5082 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5083
5084         * linux-fork.c (class scoped_switch_fork_info): New class.
5085         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5086
5087 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5088
5089         * valops.c (find_overload_match): Remove use of null_cleanup, and
5090         calls to do_cleanups.
5091
5092 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5093
5094         * compile/compile-cplus-types.c
5095         (compile_cplus_instance::decl_name): Handle changes to
5096         cp_func_name.
5097         * cp-support.c (cp_func_name): Update header comment, update
5098         return type.
5099         * cp-support.h (cp_func_name): Update return type in declaration.
5100         * valops.c (find_overload_match): Move temp_func local to top
5101         level of function and change its type.  Use temp_func to hold and
5102         delete temporary string obtained from cp_func_name.
5103
5104 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5105
5106         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5107         gdb::char_vector, remove cleanup, and update uses of `msg`.
5108
5109 2019-01-03  Jim Wilson  <jimw@sifive.com>
5110
5111         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5112
5113 2019-01-02  Tom Tromey  <tom@tromey.com>
5114
5115         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5116         (tdesc_parse_xml): Remove cleanups.
5117         * target-descriptions.h (make_cleanup_free_target_description):
5118         Don't declare.
5119         (target_desc_deleter): New struct.
5120         (target_desc_up): New typedef.
5121         * target-descriptions.c (target_desc_deleter::operator()): Rename
5122         from free_target_description.
5123         (make_cleanup_free_target_description): Remove.
5124
5125 2019-01-02  Tom Tromey  <tom@tromey.com>
5126
5127         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5128         constructor, destructor.
5129         (linespec_parser): Remove typedef.
5130         (~linespec_parser): Rename from linespec_parser_delete.
5131         (linespec_lex_to_end, linespec_complete_label)
5132         (linespec_complete): Update.
5133         (decode_line_full): Remove cleanups.
5134         (decode_line_1): Update.
5135
5136 2019-01-02  Tom Tromey  <tom@tromey.com>
5137
5138         * python/python-internal.h (inferior_to_inferior_object): Change
5139         return type.
5140         * python/py-exitedevent.c (create_exited_event_object): Update.
5141         * python/py-inferior.c (inferior_to_inferior_object): Return
5142         gdbpy_ref.
5143         (python_new_inferior, python_inferior_deleted)
5144         (thread_to_thread_object, delete_thread_object)
5145         (build_inferior_list, gdbpy_selected_inferior): Update.
5146         * python/py-infthread.c (create_thread_object): Update.  Also fail
5147         if inferior_to_inferior_object fails.
5148
5149 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5150
5151         * inferior.h (class inferior) <displaced_step_state>: New field.
5152         * infrun.h (struct displaced_step_state): Move here from
5153         infrun.c.  Initialize fields, add constructor.
5154         <inf>: Remove field.
5155         <reset>: New method.
5156         * infrun.c (struct displaced_step_inferior_state): Move to
5157         infrun.h.
5158         (displaced_step_inferior_states): Remove.
5159         (get_displaced_stepping_state): Adust.
5160         (displaced_step_in_progress_any_inferior): Adjust.
5161         (displaced_step_in_progress_thread): Adjust.
5162         (displaced_step_in_progress): Adjust.
5163         (add_displaced_stepping_state): Remove.
5164         (get_displaced_step_closure_by_addr): Adjust.
5165         (remove_displaced_stepping_state): Remove.
5166         (infrun_inferior_exit): Call displaced_step_state.reset.
5167         (use_displaced_stepping): Don't check for NULL.
5168         (displaced_step_prepare_throw): Call
5169         get_displaced_stepping_state.
5170         (displaced_step_fixup): Don't check for NULL.
5171         (prepare_for_detach): Don't check for NULL.
5172
5173 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5174
5175         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5176          in case of call that did not complete.
5177
5178 2019-01-02  Andrey Utkin  <autkin@undo.io>
5179
5180         * symfile.c (find_separate_debug_file): Fix search of debug files for
5181         remote debuggee.
5182
5183 2019-01-02  Tom Tromey  <tom@tromey.com>
5184
5185         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5186         indentation.
5187         * python/py-frame.c (frapy_older): Remove cast.
5188         (frapy_newer): Likewise.
5189         * python/py-breakpoint.c (local_setattro): Remove cast.
5190         * python/py-arch.c (archpy_name): Remove local variable.
5191         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5192
5193 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5194
5195         * unittests/basic_string_view/element_access/char/empty.cc:
5196         Fix year range in copyright header.
5197
5198 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5199
5200         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5201         Delete.
5202         <operator==>: Update with for removed field.
5203         <hash>: Likewise.
5204         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5205         <isa_features>: ...this.
5206         <abi_features>: New field.
5207         (riscv_isa_flen): Update comment.
5208         (riscv_abi_xlen): New declaration.
5209         (riscv_abi_flen): New declaration.
5210         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5211         isa_features.
5212         (riscv_abi_xlen): New function.
5213         (riscv_isa_flen): Update to get answer from isa_features.
5214         (riscv_abi_flen): New function.
5215         (riscv_has_fp_abi): Update to get answer from abi_features.
5216         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5217         xlen and flen.
5218         (riscv_call_info) <xlen, flen>: Update comment.
5219         (riscv_call_arg_struct): Remove invalid assertions
5220         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5221         is removed.
5222         (riscv_gdbarch_init): Gather isa features and abi features
5223         separately, ensure both match on the gdbarch when reusing an old
5224         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5225         a target with 64-bit float hardware.
5226
5227 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5228
5229         * source.c (search_command_helper): Stop reverse search
5230         when line 1 has been searched.
5231
5232 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5233
5234         * record-full.c (record_full_base_target::close): Rewrite
5235         record_full_core_buf_list free logic.
5236
5237 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5238
5239         * break-catch-syscall.c (print_one_catch_syscall): xfree
5240         the last text.
5241
5242 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5243
5244         * top.c (print_gdb_version): Update Copyright year in version
5245         message.
5246
5247 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5248
5249         Update copyright year range in all GDB files.
5250
5251 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5252
5253         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5254
5255 For older changes see ChangeLog-2018.
5256 \f
5257 Local Variables:
5258 mode: change-log
5259 left-margin: 8
5260 fill-column: 74
5261 version-control: never
5262 coding: utf-8
5263 End:
5264