gdb/ChangeLog

   1 2019-01-22  Tom Tromey  <tom@tromey.com>
   2
   3         * source-cache.h (class source_cache) <get_source_lines,
   4         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
   5
   6 2019-01-22  Tom Tromey  <tom@tromey.com>
   7
   8         * remote-fileio.h (struct remote_target): Declare.
   9
  10 2019-01-22  Tom Tromey  <tom@tromey.com>
  11
  12         * python/py-arch.c: Do not include py-ref.h.
  13         * python/py-bpevent.c: Do not include py-ref.h.
  14         * python/py-cmd.c: Do not include py-ref.h.
  15         * python/py-continueevent.c: Do not include py-ref.h.
  16         * python/py-event.h: Do not include py-ref.h.
  17         * python/py-evtregistry.c: Do not include py-ref.h.
  18         * python/py-finishbreakpoint.c: Do not include py-ref.h.
  19         * python/py-frame.c: Do not include py-ref.h.
  20         * python/py-framefilter.c: Do not include py-ref.h.
  21         * python/py-function.c: Do not include py-ref.h.
  22         * python/py-infevents.c: Do not include py-ref.h.
  23         * python/py-linetable.c: Do not include py-ref.h.
  24         * python/py-objfile.c: Do not include py-ref.h.
  25         * python/py-param.c: Do not include py-ref.h.
  26         * python/py-prettyprint.c: Do not include py-ref.h.
  27         * python/py-progspace.c: Do not include py-ref.h.
  28         * python/py-symbol.c: Do not include py-ref.h.
  29         * python/py-symtab.c: Do not include py-ref.h.
  30         * python/py-type.c: Do not include py-ref.h.
  31         * python/py-unwind.c: Do not include py-ref.h.
  32         * python/py-utils.c: Do not include py-ref.h.
  33         * python/py-value.c: Do not include py-ref.h.
  34         * python/py-varobj.c: Do not include py-ref.h.
  35         * python/py-xmethods.c: Do not include py-ref.h.
  36         * python/python.c: Do not include py-ref.h.
  37         * varobj.c: Do not include py-ref.h.
  38
  39 2019-01-22  Tom Tromey  <tom@tromey.com>
  40
  41         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
  42         keyword for bcache.
  43
  44 2019-01-22  Tom Tromey  <tom@tromey.com>
  45
  46         * compile/compile-cplus-types.c: Remove a comment by #include.
  47
  48 2019-01-22  Tom Tromey  <tom@tromey.com>
  49
  50         * compile/gcc-c-plugin.h: Include compile-internal.h.
  51
  52 2019-01-22  Tom Tromey  <tom@tromey.com>
  53
  54         * stabsread.c (EXTERN): Do not define.
  55         (symnum, next_symbol_text_func, processing_gcc_compilation)
  56         (within_function, global_sym_chain, global_stabs)
  57         (previous_stab_code, this_object_header_files)
  58         (n_this_object_header_files)
  59         (n_allocated_this_object_header_files): Define.
  60         * stabsread.h (EXTERN): Never define.  Use "extern".
  61
  62 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  63
  64         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  65         history_value.
  66
  67 2019-01-21  Tom Tromey  <tom@tromey.com>
  68
  69         * ui-out.c: Fix includes.
  70         * tui/tui-source.c: Fix includes.
  71         * target.c: Fix includes.
  72         * remote.c: Fix includes.
  73         * regcache.c: Fix includes.
  74         * python/py-block.c: Fix includes.
  75         * printcmd.c: Fix includes.
  76         * or1k-tdep.c: Fix includes.
  77         * mi/mi-main.c: Fix includes.
  78         * m32r-tdep.c: Fix includes.
  79         * csky-tdep.c: Fix includes.
  80         * compile/compile-cplus-types.c: Fix includes.
  81         * cli/cli-interp.c: Fix includes.
  82
  83 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
  84
  85         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  86         for padding.
  87
  88 2019-01-16  Tom Tromey  <tom@tromey.com>
  89
  90         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
  91         earlier.
  92         (struct objfile) <msymbols_range>: Move from top level.
  93         <msymbols>: New method.
  94         (class objfile_msymbols): Remove.
  95         * symtab.c (default_collect_symbol_completion_matches_break_on):
  96         Update.
  97         * symmisc.c (dump_msymbols): Update.
  98         * stabsread.c (scan_file_globals): Update.
  99         * objc-lang.c (info_selectors_command, info_classes_command)
 100         (find_methods): Update.
 101         * minsyms.c (find_solib_trampoline_target): Update.
 102         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 103         * coffread.c (coff_symfile_read): Update.
 104         * ada-lang.c (ada_lookup_simple_minsym)
 105         (ada_collect_symbol_completion_matches): Update.
 106
 107 2019-01-16  Tom Tromey  <tom@tromey.com>
 108
 109         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 110         type.  Remove no-argument constructor.
 111         <iterator::operator++>: Simplify.
 112         <begin>: Update.
 113         <end>: Use minimal_symbol_count.
 114
 115 2019-01-16  Tom Tromey  <tom@tromey.com>
 116
 117         * objfiles.h (struct objfile) <psymtabs>: New method.
 118         (class objfile_psymtabs): Remove.
 119         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 120         typedef.
 121         <range>: New method.
 122         (require_partial_symbols): Change return type.
 123         * psymtab.c (require_partial_symbols)
 124         (psym_expand_symtabs_matching): Update.
 125         * mdebugread.c (parse_partial_symbols): Update.
 126         * dbxread.c (dbx_end_psymtab): Update.
 127
 128 2019-01-15  Tom Tromey  <tom@tromey.com>
 129
 130         * symtab.c (lookup_objfile_from_block)
 131         (lookup_symbol_in_objfile_symtabs)
 132         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 133         (find_line_symtab, info_sources_command)
 134         (default_collect_symbol_completion_matches_break_on)
 135         (make_source_files_completion_list): Update.
 136         * symmisc.c (print_objfile_statistics, dump_objfile)
 137         (maintenance_print_symbols, maintenance_info_symtabs)
 138         (maintenance_check_symtabs, maintenance_info_line_tables):
 139         Update.
 140         * source.c (select_source_symtab)
 141         (forget_cached_source_info_for_objfile): Update.
 142         * objfiles.h (class objfile_compunits): Remove.
 143         (struct objfile) <compunits_range>: New typedef.
 144         (compunits): New method.
 145         * objfiles.c (objfile_relocate1): Update.
 146         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 147         * maint.c (count_symtabs_and_blocks): Update.
 148         * linespec.c (iterate_over_all_matching_symtabs): Update.
 149         * cp-support.c (add_symbol_overload_list_qualified): Update.
 150         * coffread.c (coff_symtab_read): Update.
 151         * ada-lang.c (add_nonlocal_symbols)
 152         (ada_collect_symbol_completion_matches)
 153         (ada_add_global_exceptions): Update.
 154
 155 2019-01-15  Tom Tromey  <tom@tromey.com>
 156
 157         * progspace.h (program_space) <objfiles_safe_range>: New
 158         typedef.
 159         <objfiles_safe>: New method.
 160         * objfiles.h (class all_objfiles_safe): Remove.
 161         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 162         * jit.c (jit_inferior_exit_hook): Update.
 163
 164 2019-01-17  Tom Tromey  <tom@tromey.com>
 165
 166         * progspace.h (program_space) <objfiles_range>: New typedef.
 167         <objfiles>: New method.
 168         <objfiles_head>: Rename from objfiles.
 169         (object_files): Update.
 170         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 171         * guile/scm-pretty-print.c
 172         (ppscm_find_pretty_printer_from_objfiles): Update.
 173         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 174         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 175         Update.
 176         * python/py-progspace.c (pspy_get_objfiles): Update.
 177         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 178         Update.
 179         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 180         (objfpy_lookup_objfile_by_build_id): Update.
 181         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 182         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 183         Update.
 184         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 185         (expand_symtab_containing_pc, lookup_objfile_from_block)
 186         (lookup_static_symbol, basic_lookup_transparent_type)
 187         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 188         (find_line_symtab, info_sources_command)
 189         (default_collect_symbol_completion_matches_break_on)
 190         (make_source_files_completion_list, find_main_name): Update.
 191         * symmisc.c (print_symbol_bcache_statistics)
 192         (print_objfile_statistics, maintenance_print_symbols)
 193         (maintenance_print_msymbols, maintenance_print_objfiles)
 194         (maintenance_info_symtabs, maintenance_check_symtabs)
 195         (maintenance_expand_symtabs, maintenance_info_line_tables):
 196         Update.
 197         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 198         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 199         (map_overlay_command, unmap_overlay_command)
 200         (simple_overlay_update, expand_symtabs_matching)
 201         (map_symbol_filenames): Update.
 202         * symfile-debug.c (set_debug_symfile): Update.
 203         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 204         Update.
 205         * source.c (select_source_symtab, forget_cached_source_info):
 206         Update.
 207         * solib.c (solib_read_symbols): Update.
 208         * solib-spu.c (append_ocl_sos): Update.
 209         * psymtab.c (maintenance_print_psymbols)
 210         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 211         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 212         * printcmd.c (info_symbol_command): Update.
 213         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 214         Update.
 215         * objfiles.h (class all_objfiles): Remove.
 216         * objfiles.c (have_partial_symbols, have_full_symbols)
 217         (have_minimal_symbols, qsort_cmp, update_section_map)
 218         (shared_objfile_contains_address_p)
 219         (default_iterate_over_objfiles_in_search_order): Update.
 220         * objc-lang.c (info_selectors_command, info_classes_command)
 221         (find_methods): Update.
 222         * minsyms.c (find_solib_trampoline_target): Update.
 223         * maint.c (maintenance_info_sections)
 224         (maintenance_translate_address, count_symtabs_and_blocks):
 225         Update.
 226         * main.c (captured_main_1): Update.
 227         * linux-thread-db.c (try_thread_db_load_from_pdir)
 228         (has_libpthread): Update.
 229         * linespec.c (iterate_over_all_matching_symtabs)
 230         (search_minsyms_for_name): Update.
 231         * jit.c (jit_find_objf_with_entry_addr): Update.
 232         * hppa-tdep.c (find_unwind_entry)
 233         (hppa_lookup_stub_minimal_symbol): Update.
 234         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 235         Update.
 236         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 237         (elf_gnu_ifunc_resolve_by_got): Update.
 238         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 239         * dwarf-index-write.c (save_gdb_index_command): Update.
 240         * cp-support.c (add_symbol_overload_list_qualified): Update.
 241         * breakpoint.c (create_overlay_event_breakpoint)
 242         (create_longjmp_master_breakpoint)
 243         (create_std_terminate_master_breakpoint)
 244         (create_exception_master_breakpoint): Update.
 245         * blockframe.c (find_pc_partial_function): Update.
 246         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 247         (ada_collect_symbol_completion_matches)
 248         (ada_add_global_exceptions): Update.
 249
 250 2019-01-17  Tom Tromey  <tom@tromey.com>
 251
 252         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 253         declare VEC.
 254         (solib_target_parse_libraries): Change return type.
 255         (library_list_start_segment, library_list_start_section)
 256         (library_list_end_library, library_list_start_library); Update.
 257         (solib_target_free_library_list): Remove.
 258         (solib_target_parse_libraries): Remove cleanup.  Change return
 259         type.
 260         (solib_target_current_sos): Update.
 261
 262 2019-01-17  Tom Tromey  <tromey@bapiya>
 263
 264         * valprint.c: Replace "the the" with "the".
 265         * symtab.c: Replace "the the" with "the".
 266         * solib.c: Replace "the the" with "the".
 267         * solib-dsbt.c: Replace "the the" with "the".
 268         * linespec.c: Replace "the the" with "the".
 269         * dwarf2loc.h: Replace "the the" with "the".
 270         * amd64-windows-tdep.c: Replace "the the" with "the".
 271         * aarch64-tdep.c: Replace "the the" with "the".
 272
 273 2019-01-16  Keith Seitz  <keiths@redhat.com>
 274
 275         PR gdb/23773
 276         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 277         <builder>: Rename to ..
 278         <m_builder>: ... this and make private.
 279         (dwarf2_cu::get_builder): New method.  Change all users of
 280         `builder' to use this method.
 281         (dwarf2_start_symtab): Move to ...
 282         (dwarf2_cu::start_symtab): ... here.  Update all callers
 283         (setup_type_unit_groups): Move to ...
 284         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 285         callers.
 286         (dwarf2_cu::reset_builder): New method.
 287         (process_full_compunit, process_full_type_unit): Use
 288         dwarf2_cu::reset_builder.
 289         (follow_die_offset): Record the ancestor CU if it is different
 290         from the followed DIE's CU.
 291         (follow_die_sig_1): Likewise.
 292
 293 2019-01-15  Tom Tromey  <tom@tromey.com>
 294
 295         * remote.c (class remote_state) <buf>: Now a char_vector.
 296         <buf_size>: Remove.
 297         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 298         parameter.
 299         (remote_target::getpkt_or_notif_sane_1)
 300         (remote_target::getpkt_sane)
 301         (remote_target::getpkt_or_notif_sane): Likewise.
 302         (class remote_target) <putpkt>: New overload.
 303         (remote_target::read_frame): Change type of "buf_p".  Remove
 304         sizeof_p parameter.
 305         (packet_ok): New overload.
 306         (packet_check_result): New overload.
 307         Update all uses.
 308
 309 2019-01-14  Tom Tromey  <tom@tromey.com>
 310
 311         * remote-notif.c (handle_notification, remote_notif_ack)
 312         (remote_notif_parse): Make "buf" const.
 313         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 314         const.
 315         (remote_notif_parse, remote_notif_ack, handle_notification):
 316         Likewise.
 317         * remote.c (remote_notif_stop_parse): Make "buf" const.
 318         (remote_target::remote_parse_stop_reply): Make "buf" const.
 319         (remote_notif_stop_ack): Make "buf" const.
 320
 321 2019-01-14  Tom Tromey  <tom@tromey.com>
 322
 323         * remote.c (remote_console_output): Make parameter const.
 324
 325 2019-01-14  Tom Tromey  <tom@tromey.com>
 326
 327         * target-debug.h (target_debug_print_signals): Constify.
 328         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 329         * procfs.c (procfs_target::pass_signals): Update.
 330         * linux-nat.c (linux_nat_target::pass_signals): Update.
 331         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 332         * target-delegates.c: Rebuild.
 333         * remote.c (remote_target::program_signals): Update.
 334         (remote_target::pass_signals): Update.
 335         * target.c (target_pass_signals): Constify argument.
 336         (target_program_signals): Likewise.
 337         * target.h (struct target_ops) <pass_signals, program_signals>:
 338         Constify argument.
 339         (target_pass_signals, target_program_signals): Constify argument.
 340
 341 2019-01-14  Tom Tromey  <tom@tromey.com>
 342
 343         PR tui/28819:
 344         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 345
 346 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 347
 348         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 349         field.
 350         * rs6000-tdep.c: Include reggroups.h.
 351         (IS_V_ALIAS_PSEUDOREG): Define.
 352         (rs6000_register_name): Return names for the "vX" aliases.
 353         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 354         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 355         aliases.  Call default_register_reggroup_p for all other
 356         pseudo-registers.
 357         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 358         New functions.
 359         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 360         Handle "vX" aliases.
 361         (v_alias_pseudo_register_collect): New function.
 362         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 363         (rs6000_gdbarch_init): Initialize "vX" aliases as
 364         pseudo-registers.  Restore registration of
 365         rs6000_pseudo_register_reggroup_p with
 366         set_tdesc_pseudo_register_reggroup_p.
 367
 368 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 369
 370         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 371         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 372         set_gdbarch_num_pseudo_regs.
 373
 374 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 375
 376         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 377         Remove arg prefixname, add do_set and do_show.
 378         Add member functions set_list and show_list.
 379         * cli/cli-style.c (class cli_style_option): Update accordingly.
 380         (style_set_list): Move to file scope.
 381         (style_show_list): Likewise.
 382         (set_style): Call help_list.
 383         (show_style): Call cmd_show_list.
 384         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 385         Update to use the new macro.
 386
 387 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 388
 389         * ada-lang.c (_initialize_ada_language): Expand the help text
 390         for the "catch exception" command.
 391
 392 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 393
 394         * symtab.c (matching_obj_sections): Initialize obj,
 395         declare it closer to its usage.
 396
 397 2019-01-10  Tom Tromey  <tom@tromey.com>
 398
 399         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 400         (basic_inf_threads_range): Remove.
 401         (inf_threads_range, inf_non_exited_threads_range)
 402         (safe_inf_threads_range): Use next_adapter.
 403
 404 2019-01-10  Keith Seitz  <keiths@redhat.com>
 405
 406         PR gdb/23712
 407         PR symtab/23010
 408         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 409         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 410
 411 2019-01-10  Keith Seitz  <keiths@redhat.com>
 412
 413         PR gdb/23712
 414         PR symtab/23010
 415         * dictionary.c (pending_to_vector): Remove.
 416         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 417         Remove _1 suffix, replacing functions of the same name.  Update
 418         all callers.
 419         (dict_create_hashed, dict_create_hashed_expandable)
 420         (dict_create_linear, dict_create_linear_expandable, dict_free)
 421         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 422         Make functions static.
 423
 424 2019-01-10  Keith Seitz  <keiths@redhat.com>
 425
 426         PR gdb/23712
 427         PR symtab/23010
 428         * dictionary.h (struct dictionary): Replace declaration with
 429         multidictionary.
 430         (dict_create_hashed, dict_create_hashed_expandable)
 431         (dict_create_linear, dict_create_linear_expandable)
 432         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 433         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 434         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 435         taking multidictionary argument.
 436         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 437         * block.h (struct block) <dict>: Change to multidictionary
 438         and rename `multidict'.
 439         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 440         symmisc.c: Update all dictionary references to multidictionary.
 441
 442 2019-01-10  Keith Seitz  <keiths@redhat.com>
 443
 444         PR gdb/23712
 445         PR symtab/23010
 446         * dictionary.c: Include unordered_map.
 447         (pending_to_vector): New function.
 448         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 449         Rewrite the non-"_1" functions to take vector instead
 450         of linked list.
 451         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 452         "new" _1 versions of the same name.
 453         (multidictionary): Define.
 454         (std::hash<enum language): New definition.
 455         (collate_pending_symbols_by_language, mdict_create_hashed)
 456         (mdict_create_hashed_expandable, mdict_create_linear)
 457         (mdict_create_linear_expandable, mdict_free)
 458         (find_language_dictionary, create_new_language_dictionary)
 459         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 460         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 461         (mdict_size, mdict_empty): New functions.
 462         * dictionary.h (mdict_iterator): Define.
 463
 464 2019-01-10  Pedro Alves  <palves@redhat.com>
 465
 466         * breakpoint.c (read_uploaded_action)
 467         (create_tracepoint_from_upload): Adjust to use
 468         gdb::unique_xmalloc_ptr.
 469         * ctf.c (ctf_write_uploaded_tp):
 470         (SET_ARRAY_FIELD): Use emplace_back.
 471         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 472         * tracefile-tfile.c (tfile_write_uploaded_tp):
 473         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 474         gdb::unique_xmalloc_ptr.
 475         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 476         at_string, cond_string, cmd_strings>: Replace char pointers
 477         with gdb::unique_xmalloc_ptr.
 478
 479 2019-01-10  Pedro Alves  <palves@redhat.com>
 480
 481         * solib-target.c (library_list_start_library): Don't xstrdup name.
 482
 483 2019-01-10  Pedro Alves  <palves@redhat.com>
 484
 485         * mdebugread.c (parse_partial_symbols): Use
 486         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 487
 488 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 489
 490         * linux-fork.c (scoped_switch_fork_info)
 491         <~scoped_switch_fork_info>: Fix incorrect variable name.
 492
 493 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 494
 495         * linux-fork.c (scoped_switch_fork_info)
 496         <scoped_switch_fork_info>: Make explicit.
 497         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 498
 499 2019-01-10  Tom Tromey  <tom@tromey.com>
 500
 501         * objfiles.h (objfile::reset_psymtabs): Update.
 502         * objfiles.c (objfile::objfile): Update.
 503         * psymtab.h (psymtab_storage::obstack): Update.
 504         (psymtab_storage::m_obstack): Use gdb::optional.
 505         (class psymtab_storage): Update comment.  Remove objfile
 506         parameter.
 507         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 508
 509 2019-01-10  Tom Tromey  <tom@tromey.com>
 510
 511         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 512         <free_psymtabs>: Now private.
 513         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 514         (allocate_psymtab): Use new method.
 515
 516 2019-01-10  Tom Tromey  <tom@tromey.com>
 517
 518         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 519         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 520         * mdebugread.c (parse_partial_symbols): Use
 521         allocate_dependencies.
 522         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 523         allocate_dependencies.
 524         (process_psymtab_comp_unit_reader)
 525         (build_type_psymtab_dependencies): Likewise.
 526         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 527
 528 2019-01-10  Tom Tromey  <tom@tromey.com>
 529
 530         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 531         PSYMBOL_SET_LANGUAGE.
 532         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 533
 534 2019-01-10  Tom Tromey  <tom@tromey.com>
 535
 536         * psymtab.h (psymtab_storage::obstack): New method.
 537         <m_obstack>: Rename from obstack; now private.
 538         * psymtab.c (psymtab_storage): Update.
 539         * dwarf2read.c (create_addrmap_from_index)
 540         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 541         Update.
 542
 543 2019-01-10  Tom Tromey  <tom@tromey.com>
 544
 545         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 546         * objfiles.h (objfile::reset_psymtabs): New method.
 547
 548 2019-01-10  Tom Tromey  <tom@tromey.com>
 549
 550         * symmisc.c (print_symbol_bcache_statistics): Update.
 551         (print_objfile_statistics): Update.
 552         * symfile.c (reread_symbols): Update.
 553         * psymtab.h (class psymtab_storage): New.
 554         * psymtab.c (psymtab_storage): New constructor.
 555         (~psymtab_storage): New destructor.
 556         (require_partial_symbols): Update.
 557         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 558         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 559         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 560         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 561         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 562         (start_psymtab_common, end_psymtab_common)
 563         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 564         (allocate_psymtab): Update.
 565         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 566         Update.
 567         (dump_psymtab_addrmap, maintenance_print_psymbols)
 568         (maintenance_check_psymtabs): Update.
 569         (class objfile_psymtabs): Move to objfiles.h.
 570         * psympriv.h (discard_psymtab): Now inline.
 571         (psymtab_discarder::psymtab_discarder): Update.
 572         (psymtab_discarder::~psymtab_discarder): Update.
 573         (ALL_OBJFILE_PSYMTABS): Rewrite.
 574         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 575         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 576         Remove fields.
 577         <partial_symtabs>: New field.
 578         (class objfile_psymtabs): Move from psymtab.h.  Update.
 579         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 580         psymbol_cache.
 581         (objfile::~objfile): Don't destroy psymbol_cache.
 582         * mdebugread.c (parse_partial_symbols): Update.
 583         * dwarf2read.c (create_addrmap_from_index)
 584         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 585         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 586         (add_partial_subprogram, dwarf2_ranges_read): Update.
 587         * dwarf-index-write.c (write_address_map)
 588         (write_one_signatured_type, recursively_write_psymbols)
 589         (class debug_names, class debug_names, write_psymtabs_to_index):
 590         Update.
 591
 592 2019-01-10  Tom Tromey  <tom@tromey.com>
 593
 594         * symtab.h (SYMBOL_SET_NAMES): Update.
 595         (symbol_set_names): Update.
 596         (MSYMBOL_SET_NAMES): Update.
 597         * symtab.c (symbol_set_names): Change argument to be an
 598         objfile_per_bfd_storage.
 599         * psymtab.c (add_psymbol_to_bcache): Update.
 600         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 601
 602 2019-01-10  Tom Tromey  <tom@tromey.com>
 603
 604         * symtab.c (create_demangled_names_hash): Change argument to be an
 605         objfile_per_bfd_storage.
 606         (symbol_set_names): Update.
 607
 608 2019-01-10  Tom Tromey  <tom@tromey.com>
 609
 610         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 611         init_psymbol_list.
 612         * psymtab.c (init_psymbol_list): Do nothing if already called.
 613         * psympriv.h (init_psymbol_list): Add comment.
 614         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 615         init_psymbol_list.
 616         * dbxread.c (dbx_symfile_read): Unconditionally call
 617         init_psymbol_list.
 618
 619 2019-01-10  Tom Tromey  <tom@tromey.com>
 620
 621         * xcoffread.c (scan_xcoff_symtab): Update.
 622         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 623         "where".
 624         * mdebugread.c (parse_partial_symbols)
 625         (handle_psymbol_enumerators): Update.
 626         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 627         * dbxread.c (read_dbx_symtab): Update.
 628         * psympriv.h (psymbol_placement): New enum.
 629         (add_psymbol_to_list): Update.
 630
 631 2019-01-10  Tom Tromey  <tom@tromey.com>
 632
 633         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 634         static_psymbols parameters.
 635         (scan_xcoff_symtab): Update.
 636         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 637         static_psymbols parameters.
 638         * psympriv.h (start_psymtab_common): Update.
 639         * mdebugread.c (parse_partial_symbols): Update.
 640         * dwarf2read.c (create_partial_symtab): Update.
 641         * dbxread.c (read_dbx_symtab): Update.
 642         (start_psymtab): Remove global_psymbols and static_psymbols
 643         parameters.
 644
 645 2019-01-10  Tom Tromey  <tom@tromey.com>
 646
 647         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 648         * psymtab.c (allocate_psymtab): Add comment.
 649         * psympriv.h (allocate_psymtab): Add comment.
 650         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 651         initializations.
 652         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 653
 654 2019-01-10  Tom Tromey  <tom@tromey.com>
 655
 656         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 657         Don't declare.
 658         * mipsread.c: Include mdebugread.h.
 659         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 660         Declare.
 661         * elfread.c: Include mdebugread.h.
 662
 663 2019-01-09  Tom Tromey  <tom@tromey.com>
 664
 665         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 666         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 667         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 668         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 669         (psym_lookup_symbol, psym_find_last_source_symtab)
 670         (psym_forget_cached_source_info, psym_print_stats)
 671         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 672         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 673         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 674         (psym_find_compunit_symtab_by_address)
 675         (maintenance_print_psymbols, maintenance_info_psymtabs)
 676         (maintenance_check_psymtabs): Use ranged for.
 677         * psymtab.h (class objfile_psymtabs): New.
 678         (require_partial_symbols): Return objfile_psymtabs.
 679         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 680
 681 2019-01-09  Tom Tromey  <tom@tromey.com>
 682
 683         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 684         (find_pc_mapped_section, list_overlays_command)
 685         (map_overlay_command, unmap_overlay_command)
 686         (simple_overlay_update): Use all_objfiles.
 687         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 688         * printcmd.c (info_symbol_command): Use all_objfiles.
 689         * objfiles.h (ALL_OBJSECTIONS): Remove.
 690         * maint.c (maintenance_translate_address): Use all_objfiles.
 691         * gcore.c (gcore_create_callback): Use all_objfiles.
 692         (objfile_find_memory_regions): Likewise.
 693
 694 2019-01-09  Tom Tromey  <tom@tromey.com>
 695
 696         * symtab.c (find_line_symtab, info_sources_command)
 697         (make_source_files_completion_list): Use objfile_compunits.
 698         * source.c (select_source_symtab): Use objfile_compunits.
 699         * objfiles.h (struct objfile): Update comment.
 700         (ALL_OBJFILES): Remove.
 701         (ALL_FILETABS): Remove.
 702         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 703         objfile_compunits.
 704
 705 2019-01-09  Tom Tromey  <tom@tromey.com>
 706
 707         * symmisc.c (print_objfile_statistics, dump_objfile)
 708         (maintenance_print_symbols): Use compunit_filetabs.
 709         * source.c (forget_cached_source_info_for_objfile): Use
 710         compunit_filetabs.
 711         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 712         (ALL_FILETABS): Use compunit_filetabs.
 713         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 714         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 715
 716 2019-01-09  Tom Tromey  <tom@tromey.com>
 717
 718         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 719         (compunit_filetabs): New.
 720         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 721         compunit_filetabs.
 722         (info_sources_command, make_source_files_completion_list): Remove
 723         declaration.
 724         * symmisc.c (print_objfile_statistics, dump_objfile)
 725         (maintenance_print_symbols): Remove declaration.
 726         (maintenance_info_symtabs): Use compunit_filetabs.
 727         (maintenance_info_line_tables): Likewise.
 728         * source.c (select_source_symtab): Change local variable name.
 729         (forget_cached_source_info_for_objfile): Remove declaration.
 730         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 731         * objfiles.c (objfile_relocate1): Remove declaration.
 732         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 733         declaration.
 734         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 735         * coffread.c (coff_symtab_read): Remove declaration.
 736         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 737         compunit_filetabs.
 738
 739 2019-01-09  Tom Tromey  <tom@tromey.com>
 740
 741         * symtab.c (lookup_objfile_from_block)
 742         (find_pc_sect_compunit_symtab, search_symbols)
 743         (default_collect_symbol_completion_matches_break_on): Use
 744         objfile_compunits.
 745         * objfiles.h (ALL_COMPUNITS): Remove.
 746         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 747         * cp-support.c (add_symbol_overload_list_qualified): Use
 748         objfile_compunits.
 749         * ada-lang.c (ada_collect_symbol_completion_matches)
 750         (ada_add_global_exceptions): Use objfile_compunits.
 751
 752 2019-01-09  Tom Tromey  <tom@tromey.com>
 753
 754         * source.c (select_source_symtab)
 755         (forget_cached_source_info_for_objfile): Remove declaration.
 756         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 757         declaration.
 758         * maint.c (count_symtabs_and_blocks): Remove declaration.
 759         * cp-support.c (add_symbol_overload_list_qualified): Remove
 760         declaration.
 761         * coffread.c (coff_symtab_read): Remove declaration.
 762         * symtab.c (lookup_symbol_in_objfile_symtabs)
 763         (basic_lookup_transparent_type_1): Use objfile_compunits.
 764         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 765         (info_sources_command, search_symbols)
 766         (default_collect_symbol_completion_matches_break_on)
 767         (make_source_files_completion_list): Remove declaration.
 768         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 769         (ada_collect_symbol_completion_matches)
 770         (ada_add_global_exceptions): Remove declaration.
 771         * linespec.c (iterate_over_all_matching_symtabs): Use
 772         objfile_compunits.
 773         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 774         (class objfile_compunits): New.
 775         (ALL_COMPUNITS): Use objfile_compunits.
 776         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 777         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 778         objfile_compunits.
 779         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 780
 781 2019-01-09  Tom Tromey  <tom@tromey.com>
 782
 783         * symtab.c (search_symbols)
 784         (default_collect_symbol_completion_matches_break_on): Use
 785         objfile_msymbols.
 786         * ada-lang.c (ada_lookup_simple_minsym)
 787         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 788         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 789         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 790         objfile_msymbols.
 791         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 792         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 793         * objc-lang.c (find_methods): Use objfile_msymbols.
 794         (info_selectors_command, info_classes_command): Likewise.
 795         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 796         * objfiles.h (class objfile_msymbols): New.
 797         (ALL_OBJFILE_MSYMBOLS): Remove.
 798         (ALL_MSYMBOLS): Remove.
 799
 800 2019-01-09  Tom Tromey  <tom@tromey.com>
 801
 802         * common/next-iterator.h (next_adapter): Add Iterator template
 803         parameter.
 804         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 805         (class all_objfiles_safe): New.
 806         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 807         * objfiles.c (put_objfile_before): Update comment.
 808         (add_separate_debug_objfile): Likewise.
 809         (free_all_objfiles): Use all_objfiles_safe.
 810         (objfile_purge_solibs): Likewise.
 811
 812 2019-01-09  Tom Tromey  <tom@tromey.com>
 813
 814         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 815         (expand_symtab_containing_pc, lookup_static_symbol)
 816         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 817         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 818         all_objfiles.
 819         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 820         * breakpoint.c (create_overlay_event_breakpoint)
 821         (create_longjmp_master_breakpoint)
 822         (create_std_terminate_master_breakpoint)
 823         (create_exception_master_breakpoint): Use all_objfiles.
 824         * linux-thread-db.c (try_thread_db_load_from_pdir)
 825         (has_libpthread): Use all_objfiles.
 826         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 827         * linespec.c (iterate_over_all_matching_symtabs)
 828         (search_minsyms_for_name): Use all_objfiles.
 829         * maint.c (maintenance_info_sections): Use all_objfiles.
 830         * main.c (captured_main_1): Use all_objfiles.
 831         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 832         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 833         * guile/scm-pretty-print.c
 834         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 835         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 836         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 837         (maintenance_print_msymbols): Use all_objfiles.
 838         * source.c (select_source_symtab): Use all_objfiles.
 839         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 840         * symfile.c (remove_symbol_file_command)
 841         (expand_symtabs_matching, map_symbol_filenames): Use
 842         all_objfiles.
 843         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 844         all_objfiles.
 845         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 846         * objc-lang.c (find_methods): Use all_objfiles.
 847         * objfiles.c (have_partial_symbols, have_full_symbols)
 848         (have_minimal_symbols, qsort_cmp)
 849         (default_iterate_over_objfiles_in_search_order): Use
 850         all_objfiles.
 851         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 852         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 853         (maintenance_check_psymtabs): Use all_objfiles.
 854         (ALL_PSYMTABS): Remove.
 855         * compile/compile-object-run.c (do_module_cleanup): Use
 856         all_objfiles.
 857         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 858         * cp-support.c (add_symbol_overload_list_qualified): Use
 859         all_objfiles.
 860         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 861         Use all_objfiles.
 862         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 863         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 864         all_objfiles.
 865         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 866         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 867         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 868         Uses all_objfiles.
 869         * solib.c (solib_read_symbols): Use all_objfiles
 870
 871 2019-01-09  Tom Tromey  <tom@tromey.com>
 872
 873         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 874         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 875         all_objfiles.
 876         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 877         * symmisc.c (print_symbol_bcache_statistics)
 878         (print_objfile_statistics, maintenance_print_objfiles)
 879         (maintenance_info_symtabs, maintenance_check_symtabs)
 880         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 881         all_objfiles.
 882         * source.c (forget_cached_source_info): Use all_objfiles.
 883         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 884         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 885         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 886         * objfiles.c (update_section_map): Use all_objfiles.
 887         (shared_objfile_contains_address_p): Likewise.
 888         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 889         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 890
 891 2019-01-09  Tom Tromey  <tom@tromey.com>
 892
 893         * common/next-iterator.h: New file.
 894         * objfiles.h (class all_objfiles): New.
 895         (struct objfile_iterator): New.
 896
 897 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 898
 899         * NEWS: Move the description of the changed "frame", "select-frame",
 900          and "info frame" commands to the Changed commands section.
 901
 902 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 903
 904         * gdbtypes.c (check_stub_method_group): Remove handling of old
 905         mangling schemes.
 906         * linespec.c (find_methods): Likewise.
 907         * stabsread.c (read_member_functions): Likewise.
 908         * valops.c (search_struct_method): Likewise.
 909         (value_struct_elt_for_reference): Likewise.
 910         * NEWS: Mention this change.
 911
 912 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 913
 914         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 915         print_source_lines.
 916         * source.c (print_source_lines_base): Update line number check.
 917         (print_source_lines): New function.
 918         (source_lines_range::source_lines_range): New function.
 919         * source.h (class source_lines_range): New class.
 920         (print_source_lines): New declaration.
 921
 922 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 923
 924         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 925
 926 2019-01-08  Tom Tromey  <tom@tromey.com>
 927             Simon Marchi  <simon.marchi@ericsson.com>
 928
 929         PR gdb/24060
 930         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 931         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 932         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 933         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 934         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 935         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 936
 937 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 938
 939         * source.c (select_source_symtab): Move header comment to
 940         declaration in source.h.
 941         (forget_cached_source_info_for_objfile): Likewise.
 942         (forget_cached_source_info): Likewise.
 943         (identify_source_line): Likewise.
 944         * source.h (identify_source_line): Move declaration from symtab.h
 945         and add comment from source.c
 946         (print_source_lines): Likewise.
 947         (forget_cached_source_info_for_objfile): Likewise.
 948         (forget_cached_source_info): Likewise.
 949         (select_source_symtab): Likewise.
 950         (enum print_source_lines_flag): Move definition from symtab.h.
 951         * symtab.h (identify_source_line): Move declaration to source.h.
 952         (print_source_lines): Likewise.
 953         (forget_cached_source_info_for_objfile): Likewise.
 954         (forget_cached_source_info): Likewise.
 955         (select_source_symtab): Likewise.
 956         (enum print_source_lines_flag): Move definition to source.h.
 957         * tui/tui-hooks.c: Add 'source.h' include.
 958
 959 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 960
 961         * source.c (print_source_lines_base): Handle requests to print
 962         reverse line number sequences, and guard against empty lines
 963         string.
 964
 965 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 966
 967         * source.c (print_source_lines_base): Fix skip of '\r' if next
 968         character is '\n'.
 969
 970 2019-01-06  Tom Tromey  <tom@tromey.com>
 971
 972         * c-exp.y (struct c_parse_state) <macro_original_text,
 973         expansion_obstack>: New member.
 974         (macro_original_text, expansion_obstack): Remove globals.
 975         (scan_macro_expansion, scanning_macro_expansion)
 976         (finished_macro_expansion): Update.
 977         (scan_macro_cleanup): Remove.
 978         (yylex, c_parse): Update.
 979
 980 2019-01-06  Tom Tromey  <tom@tromey.com>
 981
 982         * c-exp.y (struct c_parse_state) <strings>: New member.
 983         (operator_stoken): Update.
 984
 985 2019-01-06  Tom Tromey  <tom@tromey.com>
 986
 987         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 988         (union type_stack_elt) <typelist_val>: Now a pointer to
 989         std::vector.
 990         (type_stack_cleanup): Don't declare.
 991         (push_typelist): Update.
 992         * parse.c (pop_typelist): Return a std::vector.
 993         (push_typelist): Take a std::vector.
 994         (follow_types): Update.  Do not free args.
 995         (type_stack_cleanup): Remove.
 996         * c-exp.y (struct c_parse_state): New.
 997         (cpstate): New global.
 998         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 999         (nonempty_typelist): Update.
1000         (func_mod): Create a new vector.
1001         (c_parse): Create a c_parse_state.
1002         (check_parameter_typelist): Do not delete params.
1003         (function_method): Update.  Do not delete type_list.
1004
1005 2019-01-06  Tom Tromey  <tom@tromey.com>
1006
1007         PR gdb/28155:
1008         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1009         check_typedef.
1010         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1011         (print_return_value): Likewise.
1012
1013 2019-01-05  Tom Tromey  <tom@tromey.com>
1014
1015         * contrib/cleanup_check.py: Remove.
1016         * contrib/gcc-with-excheck: Remove.
1017         * contrib/exsummary.py: Remove.
1018         * contrib/excheck.py: Remove.
1019
1020 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1021
1022         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1023         NULL. Initialize tpprev to NULL instead of assigning it
1024         to NULL on the next statement.
1025         * windows-nat.c (windows_delete_thread): Remove check for
1026         main_thread_id before printing thread exit notifications.
1027         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1028         Remove thread ID check against main_thread_id.
1029         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1030         windows_delete_thread.
1031         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1032
1033 2019-01-04  Tom Tromey  <tom@tromey.com>
1034
1035         * compile/compile.c (_initialize_compile): Use upper case for
1036         metasyntactic variables.
1037         * symmisc.c (_initialize_symmisc): Use upper case for
1038         metasyntactic variables.
1039         * psymtab.c (_initialize_psymtab): Use upper case for
1040         metasyntactic variables.
1041         * demangle.c (demangle_command): Use upper case for metasyntactic
1042         variables.
1043         (_initialize_demangler): Likewise.
1044         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1045         variables.
1046
1047 2019-01-03  Tom Tromey  <tom@tromey.com>
1048
1049         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1050
1051 2019-01-03  Tom Tromey  <tom@tromey.com>
1052
1053         * python/py-symtab.c (salpy_str): Update.
1054         (struct salpy_sal_object) <symtab>: Now a PyObject.
1055         (salpy_dealloc): Update.
1056         (del_objfile_sal): Use gdbpy_ref.
1057
1058 2019-01-03  Tom Tromey  <tom@tromey.com>
1059
1060         * python/py-type.c (convert_field): Use new_reference.  Return
1061         gdbpy_ref.
1062         (make_fielditem): Return gdbpy_ref.
1063         (typy_fields): Update.
1064         (typy_getitem): Update.
1065         (field_name): Return gdbpy_ref.  Use new_reference.
1066         (typy_iterator_iternext): Update.
1067
1068 2019-01-03  Tom Tromey  <tom@tromey.com>
1069
1070         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1071
1072 2019-01-03  Tom Tromey  <tom@tromey.com>
1073
1074         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1075         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1076         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1077         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1078         (pspy_set_type_printers): Likewise.
1079         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1080         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1081         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1082         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1083         (objfpy_set_type_printers): Likewise.
1084
1085 2019-01-03  Tom Tromey  <tom@tromey.com>
1086
1087         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1088         (gdbpy_print_stack): Use gdbpy_err_fetch.
1089         * python/python-internal.h (class gdbpy_err_fetch): New class.
1090         (class gdbpy_enter) <m_error_type, m_error_value,
1091         m_error_traceback>: Remove.
1092         <m_error>: New member.
1093         (gdbpy_exception_to_string): Don't declare.
1094         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1095         * python/py-value.c (convert_value_from_python): Use
1096         gdbpy_err_fetch.
1097         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1098         gdbpy_exception_to_string.
1099         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1100         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1101         gdbpy_err_fetch.
1102
1103 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1104
1105         * linux-nat.c (delete_lwp_cleanup): Delete.
1106         (struct lwp_deleter): New struct.
1107         (lwp_info_up): New typedef.
1108         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1109         lwp_info_up.
1110
1111 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1112
1113         * linux-fork.c (class scoped_switch_fork_info): New class.
1114         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1115
1116 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * valops.c (find_overload_match): Remove use of null_cleanup, and
1119         calls to do_cleanups.
1120
1121 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1122
1123         * compile/compile-cplus-types.c
1124         (compile_cplus_instance::decl_name): Handle changes to
1125         cp_func_name.
1126         * cp-support.c (cp_func_name): Update header comment, update
1127         return type.
1128         * cp-support.h (cp_func_name): Update return type in declaration.
1129         * valops.c (find_overload_match): Move temp_func local to top
1130         level of function and change its type.  Use temp_func to hold and
1131         delete temporary string obtained from cp_func_name.
1132
1133 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1134
1135         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1136         gdb::char_vector, remove cleanup, and update uses of `msg`.
1137
1138 2019-01-03  Jim Wilson  <jimw@sifive.com>
1139
1140         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1141
1142 2019-01-02  Tom Tromey  <tom@tromey.com>
1143
1144         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1145         (tdesc_parse_xml): Remove cleanups.
1146         * target-descriptions.h (make_cleanup_free_target_description):
1147         Don't declare.
1148         (target_desc_deleter): New struct.
1149         (target_desc_up): New typedef.
1150         * target-descriptions.c (target_desc_deleter::operator()): Rename
1151         from free_target_description.
1152         (make_cleanup_free_target_description): Remove.
1153
1154 2019-01-02  Tom Tromey  <tom@tromey.com>
1155
1156         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1157         constructor, destructor.
1158         (linespec_parser): Remove typedef.
1159         (~linespec_parser): Rename from linespec_parser_delete.
1160         (linespec_lex_to_end, linespec_complete_label)
1161         (linespec_complete): Update.
1162         (decode_line_full): Remove cleanups.
1163         (decode_line_1): Update.
1164
1165 2019-01-02  Tom Tromey  <tom@tromey.com>
1166
1167         * python/python-internal.h (inferior_to_inferior_object): Change
1168         return type.
1169         * python/py-exitedevent.c (create_exited_event_object): Update.
1170         * python/py-inferior.c (inferior_to_inferior_object): Return
1171         gdbpy_ref.
1172         (python_new_inferior, python_inferior_deleted)
1173         (thread_to_thread_object, delete_thread_object)
1174         (build_inferior_list, gdbpy_selected_inferior): Update.
1175         * python/py-infthread.c (create_thread_object): Update.  Also fail
1176         if inferior_to_inferior_object fails.
1177
1178 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1179
1180         * inferior.h (class inferior) <displaced_step_state>: New field.
1181         * infrun.h (struct displaced_step_state): Move here from
1182         infrun.c.  Initialize fields, add constructor.
1183         <inf>: Remove field.
1184         <reset>: New method.
1185         * infrun.c (struct displaced_step_inferior_state): Move to
1186         infrun.h.
1187         (displaced_step_inferior_states): Remove.
1188         (get_displaced_stepping_state): Adust.
1189         (displaced_step_in_progress_any_inferior): Adjust.
1190         (displaced_step_in_progress_thread): Adjust.
1191         (displaced_step_in_progress): Adjust.
1192         (add_displaced_stepping_state): Remove.
1193         (get_displaced_step_closure_by_addr): Adjust.
1194         (remove_displaced_stepping_state): Remove.
1195         (infrun_inferior_exit): Call displaced_step_state.reset.
1196         (use_displaced_stepping): Don't check for NULL.
1197         (displaced_step_prepare_throw): Call
1198         get_displaced_stepping_state.
1199         (displaced_step_fixup): Don't check for NULL.
1200         (prepare_for_detach): Don't check for NULL.
1201
1202 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1203
1204         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1205          in case of call that did not complete.
1206
1207 2019-01-02  Andrey Utkin  <autkin@undo.io>
1208
1209         * symfile.c (find_separate_debug_file): Fix search of debug files for
1210         remote debuggee.
1211
1212 2019-01-02  Tom Tromey  <tom@tromey.com>
1213
1214         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1215         indentation.
1216         * python/py-frame.c (frapy_older): Remove cast.
1217         (frapy_newer): Likewise.
1218         * python/py-breakpoint.c (local_setattro): Remove cast.
1219         * python/py-arch.c (archpy_name): Remove local variable.
1220         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1221
1222 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1223
1224         * unittests/basic_string_view/element_access/char/empty.cc:
1225         Fix year range in copyright header.
1226
1227 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1228
1229         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1230         Delete.
1231         <operator==>: Update with for removed field.
1232         <hash>: Likewise.
1233         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1234         <isa_features>: ...this.
1235         <abi_features>: New field.
1236         (riscv_isa_flen): Update comment.
1237         (riscv_abi_xlen): New declaration.
1238         (riscv_abi_flen): New declaration.
1239         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1240         isa_features.
1241         (riscv_abi_xlen): New function.
1242         (riscv_isa_flen): Update to get answer from isa_features.
1243         (riscv_abi_flen): New function.
1244         (riscv_has_fp_abi): Update to get answer from abi_features.
1245         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1246         xlen and flen.
1247         (riscv_call_info) <xlen, flen>: Update comment.
1248         (riscv_call_arg_struct): Remove invalid assertions
1249         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1250         is removed.
1251         (riscv_gdbarch_init): Gather isa features and abi features
1252         separately, ensure both match on the gdbarch when reusing an old
1253         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1254         a target with 64-bit float hardware.
1255
1256 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1257
1258         * source.c (search_command_helper): Stop reverse search
1259         when line 1 has been searched.
1260
1261 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1262
1263         * record-full.c (record_full_base_target::close): Rewrite
1264         record_full_core_buf_list free logic.
1265
1266 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1267
1268         * break-catch-syscall.c (print_one_catch_syscall): xfree
1269         the last text.
1270
1271 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1272
1273         * top.c (print_gdb_version): Update Copyright year in version
1274         message.
1275
1276 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1277
1278         Update copyright year range in all GDB files.
1279
1280 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1281
1282         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1283
1284 For older changes see ChangeLog-2018.
1285 \f
1286 Local Variables:
1287 mode: change-log
1288 left-margin: 8
1289 fill-column: 74
1290 version-control: never
1291 coding: utf-8
1292 End:
1293