gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * gdbarch.h, gdbarch.c: Rebuild.
   4         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
   5         * stap-probe.h:
   6         (struct stap_parse_info): Replace "parser_state" with
   7         "expr_builder".
   8         * parser-defs.h (struct expr_builder): Rename from "parser_state".
   9         (parser_state): New class.
  10         * parse.c (expr_builder): Rename.
  11         (expr_builder::release): Rename.
  12         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
  13         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
  14         (write_exp_elt_longcst, write_exp_elt_floatcst)
  15         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
  16         (write_exp_string_vector, write_exp_bitstring)
  17         (write_exp_msymbol, mark_struct_expression)
  18         (write_dollar_variable)
  19         (insert_type_address_space, increase_expout_size): Replace
  20         "parser_state" with "expr_builder".
  21         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
  22         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
  23         "parser_state" with "expr_builder".
  24
  25 2019-04-04  Tom Tromey  <tom@tromey.com>
  26
  27         * rust-exp.y: Replace "parse_language" with method call.
  28         * p-exp.y:
  29         (yylex): Replace "parse_language" with method call.
  30         * m2-exp.y:
  31         (yylex): Replace "parse_language" with method call.
  32         * go-exp.y (classify_name): Replace "parse_language" with method
  33         call.
  34         * f-exp.y (yylex): Replace "parse_language" with method call.
  35         * d-exp.y (lex_one_token): Replace "parse_language" with method
  36         call.
  37         * c-exp.y:
  38         (lex_one_token, classify_name, yylex): Replace "parse_language"
  39         with method call.
  40         * ada-exp.y (find_primitive_type, type_char)
  41         (type_system_address): Replace "parse_language" with method call.
  42
  43 2019-04-04  Tom Tromey  <tom@tromey.com>
  44
  45         * rust-exp.y: Replace "parse_gdbarch" with method call.
  46         * parse.c (write_dollar_variable, insert_type_address_space):
  47         Replace "parse_gdbarch" with method call.
  48         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
  49         call.
  50         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
  51         call.
  52         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
  53         "parse_gdbarch" with method call.
  54         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
  55         with method call.
  56         * f-exp.y (parse_type, parse_f_type, yylex): Replace
  57         "parse_gdbarch" with method call.
  58         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
  59         "parse_gdbarch" with method call.
  60         * c-exp.y (parse_type, parse_number, classify_name): Replace
  61         "parse_gdbarch" with method call.
  62         * ada-lex.l: Replace "parse_gdbarch" with method call.
  63         * ada-exp.y (parse_type, find_primitive_type, type_char)
  64         (type_system_address): Replace "parse_gdbarch" with method call.
  65
  66 2019-04-04  Tom Tromey  <tom@tromey.com>
  67
  68         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
  69         * stap-probe.c (stap_parse_argument): Update.
  70         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
  71         initial_size parameter.
  72         * rust-exp.y (rust_lex_tests): Update.
  73         * parse.c (parser_state): Update.
  74         (parse_exp_in_context): Update.
  75         * parser-defs.h (struct parser_state) <parser_state>: Remove
  76         "initial_size" parameter.
  77
  78 2019-04-04  Tom Tromey  <tom@tromey.com>
  79
  80         * parser-defs.h (increase_expout_size): Don't declare.
  81         * parse.c (increase_expout_size): Now static.
  82
  83 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
  84
  85         * gnu-nat.c (gnu_nat_target::wait): Fix
  86         target_waitstatus_to_string call.
  87
  88 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
  89
  90         * eval.c (evaluate_subexp_standard): Handle internal functions
  91         during Fortran function call handling.
  92
  93 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
  94
  95         * NEWS: Mention new internal functions.
  96         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
  97         (read_base_type): Use dwarf2_init_complex_target_type.
  98         * value.c (creal_internal_fn): New function.
  99         (cimag_internal_fn): New function.
 100         (_initialize_values): Register new internal functions.
 101
 102 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 103
 104         * infrun.c (stop_all_threads): If debug_infrun, always
 105         trace the wait status after wait_one, using
 106         target_waitstatus_to_string and target_pid_to_str.
 107         (handle_inferior_event): Replace various trace of
 108         wait status kind by a single trace.
 109         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
 110         wait status kind image by target_waitstatus_to_string.
 111         * target/waitstatus.c (target_waitstatus_to_string): Fix
 112         obsolete comment.
 113
 114 2019-04-01  Tom Tromey  <tromey@adacore.com>
 115
 116         PR symtab/23331:
 117         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
 118
 119 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 120             Pedro Alves  <palves@redhat.com>
 121
 122         * top.c (quit_force): Call 'finalize_values'.
 123         * value.c (finalize_values): New function.
 124         * value.h (finalize_values): Declare.
 125
 126 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
 127
 128         * NEWS: Announce $_gdb_major and $_gdb_minor.
 129
 130         * top.c (init_gdb_version_vars): New function.
 131         (gdb_init): Call init_gdb_version_vars.
 132
 133 2019-03-29  Tom Tromey  <tromey@adacore.com>
 134
 135         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
 136         help text.  Remove dead code.
 137
 138 2019-03-29  Keith Seitz  <keiths@redhat.com>
 139
 140         From Siddhesh Poyarekar:
 141         * f-lang.h (f77_get_upperbound): Return LONGEST.
 142         (f77_get_lowerbound): Likewise.
 143         * f-typeprint.c (f_type_print_varspec_suffix): Expand
 144         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
 145         print them.
 146         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
 147         plongest to format print it.
 148         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
 149         (f77_get_upperbound): Likewise.
 150         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
 151         LOWER_BOUND to LONGEST.
 152         (f77_create_arrayprint_offset_tbl): Likewise.
 153
 154 2019-03-29  Keith Seitz  <keiths@redhat.com>
 155
 156         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
 157         %s/pulongest for TYPE_LENGTH instead of %d in format
 158         strings.
 159         * ada-typerint.c (ada_print_type): Likewise.
 160         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
 161         * compile/compile-c-support.c (generate_register_struct): Likewise.
 162         * gdbtypes.c (recursive_dump_type): Likewise.
 163         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
 164         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 165         instead of %d in format strings.
 166         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 167         to std::min to ULONGEST.
 168         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 169         instead of %d in format strings.
 170         * tracepoint.c (info_scope_command): Likewise.
 171         * typeprint.c (print_offset_data::update)
 172         (print_offset_data::finish): Likewise.
 173         * xtensa-tdep.c (xtensa_store_return_value)
 174         (xtensa_push_dummy_call): Likewise.
 175
 176 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 177
 178         * windows-nat.c (display_selector): Fixed format specifications
 179         for 64-bit Cygwin.
 180
 181 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 182
 183         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 184
 185 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 186
 187         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 188         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 189         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 190         (nios2_linux_init_abi): Install it.
 191
 192 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 193
 194         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 195
 196 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 197
 198         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 199
 200 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 201             Tom Tromey  <tromey@adacore.com>
 202
 203         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 204
 205 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 206
 207         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 208         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 209         method to compute the bounds of range types. Also print "[evaluated]"
 210         if the bounds' values come from a dynamic evaluation.
 211
 212 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 213
 214         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 215         whitespace when pretty printing is on.
 216
 217 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 218
 219         * ppc-linux-nat.c: Add include.
 220
 221 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 222
 223         * NEWS: Mention AArch64 Pointer Authentication.
 224
 225 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 226
 227         * arm-linux-nat.c: Add include.
 228
 229 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 230
 231         * source-cache.c (source_cache::get_source_lines): Re-read
 232         fullname after calling open_source_file.
 233
 234 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 235
 236         * NEWS: Mention TLS support for FreeBSD.
 237
 238 2019-03-25  Tom Tromey  <tromey@adacore.com>
 239
 240         * minsyms.c (BUNCH_SIZE): Update comment.
 241         (~minimal_symbol_reader): Remove old comment.
 242         (compact_minimal_symbols): Update comment.
 243         (minimal_symbol_reader::install): Remove old comment.  Update
 244         other comments.
 245
 246 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 247
 248         * s390-linux-nat.c: Add include.
 249
 250 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 251
 252         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 253         Call linux_get_hwcap.
 254         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 255         Likewise.
 256         (aarch64_linux_get_hwcap): Remove function.
 257         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 258         declaration.
 259         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 260         linux_get_hwcap.
 261         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 262         * linux-tdep.c (linux_get_hwcap): Add function.
 263         (linux_get_hwcap2): Likewise.
 264         * linux-tdep.h (linux_get_hwcap): Add declaration.
 265         (linux_get_hwcap2): Likewise.
 266         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 267         (ppc_linux_get_hwcap2): Likewise.
 268         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 269         linux_get_hwcap.
 270         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 271         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 272         (ppc_linux_nat_target::read_description): Likewise.
 273         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 274         * s390-linux-nat.c: Likewise.
 275         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 276
 277 2019-03-24  Tom Tromey  <tom@tromey.com>
 278
 279         * ada-lang.c (standard_lookup): Simplify initialization.
 280         (ada_lookup_symbol_nonlocal): Simplify return.
 281         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 282         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 283         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 284         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 285         initialization.
 286         * solib.c (solib_global_lookup): Simplify.
 287         * symtab.c (null_block_symbol): Remove.
 288         (symbol_cache_lookup): Simplify returns.
 289         (lookup_language_this): Simplify returns.
 290         (lookup_symbol_aux): Simplify return.
 291         (lookup_local_symbol): Simplify returns.
 292         (lookup_global_symbol_from_objfile): Simplify return.
 293         (lookup_symbol_in_objfile_symtabs)
 294         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 295         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 296         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 297         * cp-namespace.c (cp_lookup_bare_symbol)
 298         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 299         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 300         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 301         (cp_lookup_symbol_via_imports): Simplify initialization.
 302         (find_symbol_in_baseclass): Likewise.
 303         * symtab.h (null_block_symbol): Remove.
 304         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 305         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 306         (d_lookup_symbol_module): Likewise.
 307         (find_symbol_in_baseclass): Simplify initialization.
 308
 309 2019-03-24  Tom Tromey  <tom@tromey.com>
 310
 311         * expression.h: Don't include symtab.h.
 312         (struct block): Forward declare.
 313
 314 2019-03-24  Tom Tromey  <tom@tromey.com>
 315
 316         * c-exp.y (typebase): Remove casts.
 317         * gdbtypes.c (lookup_unsigned_typename, )
 318         (lookup_signed_typename): Remove cast.
 319         * eval.c (parse_to_comma_and_eval): Remove cast.
 320         * parse.c (write_dollar_variable): Remove cast.
 321         * block.h (struct block) <superblock>: Now const.
 322         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 323         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 324         (map_block): Make "block" const.
 325         * symfile.h (struct quick_symbol_functions)
 326         <map_matching_symbols>: Constify block argument to "callback".
 327         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 328         const.
 329         (find_pc_sect_compunit_symtab): Make "b" const.
 330         (find_symbol_at_address): Likewise.
 331         (search_symbols): Likewise.
 332         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 333         (dw2_debug_names_lookup_symbol): Likewise.
 334         (dw2_map_matching_symbols): Update.
 335         * p-valprint.c (pascal_val_print): Remove "block".
 336         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 337         (aux_add_nonlocal_symbols): Make "block" const.
 338         (resolve_subexp): Remove cast.
 339         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 340         const.
 341         (iterate_over_file_blocks): Likewise.
 342         * f-exp.y (%union) <bval>: Remove.
 343         * coffread.c (patch_opaque_types): Make "b" const.
 344         * spu-tdep.c (spu_catch_start): Make "block" const.
 345         * c-valprint.c (print_unpacked_pointer): Remove "block".
 346         * symmisc.c (dump_symtab_1): Make "b" const.
 347         (block_depth): Make "block" const.
 348         * d-exp.y (%union) <bval>: Remove.
 349         * cp-support.h (cp_lookup_rtti_type): Update.
 350         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 351         * psymtab.c (psym_lookup_symbol): Make "block" const.
 352         (maintenance_check_psymtabs): Make "b" const.
 353         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 354         (enumerate_locals, enumerate_args): Update.
 355         * python/py-symtab.c (stpy_global_block): Make "block" const.
 356         (stpy_static_block): Likewise.
 357         * inline-frame.c (block_starting_point_at): Make "new_block"
 358         const.
 359         * block.c (find_block_in_blockvector): Make return type const.
 360         (blockvector_for_pc_sect): Make "b" const.
 361         (find_block_in_blockvector): Make "b" const.
 362
 363 2019-03-23  Tom Tromey  <tom@tromey.com>
 364
 365         * varobj.c (varobj_create): Update.
 366         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 367         * printcmd.c (display_command, do_one_display): Don't reset
 368         innermost_block.
 369         * parser-defs.h (enum innermost_block_tracker_type): Move to
 370         expression.h.
 371         (innermost_block): Update comment.
 372         * parse.c (parse_exp_1): Add tracker_types parameter.
 373         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 374         tracker_types parameter.  Reset innermost_block.
 375         (parse_exp_in_context): Remove.
 376         (parse_expression_for_completion): Update.
 377         * objfiles.c (~objfile): Don't reset expression_context_block or
 378         innermost_block.
 379         * expression.h (enum innermost_block_tracker_type): Move from
 380         parser-defs.h.
 381         (parse_exp_1): Add tracker_types parameter.
 382         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 383         reset innermost_block.
 384
 385 2019-03-23  Tom Tromey  <tom@tromey.com>
 386
 387         * objfiles.h: Include bcache.h.
 388
 389 2019-03-23  Tom Tromey  <tom@tromey.com>
 390
 391         * linespec.c (get_current_search_block): Use
 392         scoped_restore_current_language.
 393         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 394
 395 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 396             Jiong Wang  <jiong.wang@arm.com>
 397
 398         * aarch64-linux-tdep.c
 399         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 400         section.
 401         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 402
 403 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 404             Jiong Wang  <jiong.wang@arm.com>
 405
 406         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 407         instructions.
 408         (aarch64_analyze_prologue_test): Add PACIASP test.
 409         (aarch64_prologue_prev_register): Unmask PC value.
 410
 411 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 412             Jiong Wang  <jiong.wang@arm.com>
 413
 414         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 415         (aarch64_dwarf2_prev_register): Unmask PC value.
 416         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 417         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 418         DW_CFA_AARCH64_negate_ra_state.
 419         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 420
 421 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 422             Jiong Wang  <jiong.wang@arm.com>
 423
 424         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 425         registers.
 426         (aarch64_pseudo_register_name): Likewise.
 427         (aarch64_pseudo_register_type): Likewise.
 428         (aarch64_pseudo_register_reggroup_p): Likewise.
 429         (aarch64_gdbarch_init): Add pauth registers.
 430         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 431         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 432         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 433         (struct gdbarch_tdep): Add regnum for ra_state.
 434
 435 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 436             Jiong Wang  <jiong.wang@arm.com>
 437
 438         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 439
 440 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 441             Jiong Wang  <jiong.wang@arm.com>
 442
 443         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 444         function.
 445         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 446         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 447         (aarch64_gdbarch_init): Add puth registers.
 448         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 449         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 450         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 451
 452 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 453             Jiong Wang  <jiong.wang@arm.com>
 454
 455         * aarch64-linux-nat.c
 456         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 457         * aarch64-linux-tdep.c
 458         (aarch64_linux_core_read_description): Likewise.
 459         (aarch64_linux_get_hwcap): New function.
 460         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 461         (aarch64_linux_get_hwcap): New declaration.
 462
 463 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 464             Jiong Wang  <jiong.wang@arm.com>
 465
 466         * aarch64-linux-nat.c
 467         (aarch64_linux_nat_target::read_description): Add pauth param.
 468         * aarch64-linux-tdep.c
 469         (aarch64_linux_core_read_description): Likewise.
 470         * aarch64-tdep.c (struct target_desc): Add in pauth.
 471         (aarch64_read_description): Add pauth param.
 472         (aarch64_gdbarch_init): Likewise.
 473         * aarch64-tdep.h (aarch64_read_description): Likewise.
 474         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 475         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 476         * features/Makefile: Add new files.
 477         * features/aarch64-pauth.c: New file.
 478         * features/aarch64-pauth.xml: New file.
 479
 480 2019-03-20  Tom Tromey  <tromey@adacore.com>
 481
 482         * infrun.c (handle_inferior_event): Rename from
 483         handle_inferior_event_1.  Create a scoped_value_mark.
 484         (handle_inferior_event): Remove.
 485
 486 2019-03-19  Tom Tromey  <tromey@adacore.com>
 487
 488         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 489         * infrun.h (print_stop_event): Add "displays" parameter.
 490         * infrun.c (print_stop_event): Add "displays" parameter.
 491
 492 2019-03-19  Pedro Alves  <palves@redhat.com>
 493
 494         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 495         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 496         to -1.  Fix TABs vs spaces.
 497         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 498         * tui/tui-out.h (tui_ui_out) Add intro comments.
 499         <m_line, m_start_of_line>: In-class initialize, and add describing
 500         comment.
 501
 502 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 503
 504         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 505         variable names.
 506         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 507
 508 2019-03-18  Pedro Alves  <palves@redhat.com>
 509             Eli Zaretskii <eliz@gnu.org>
 510
 511         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 512         m_line and m_start_of_line.
 513
 514 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 515
 516         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 517         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 518         it returns a newline.  This fixes a regression in TU mode, whereby
 519         the next line is output on the same screen line as the user input.
 520
 521 2019-03-18  Tom Tromey  <tromey@adacore.com>
 522
 523         * minsyms.c (minimal_symbol_reader::install): Remove call to
 524         obstack_blank.
 525
 526 2019-03-18  Pedro Alves  <palves@redhat.com>
 527
 528         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 529         New globals.
 530         (apply_style): New, factored out from ...
 531         (apply_ansi_escape): ... this.  Handle reverse video mode.
 532         (tui_set_reverse_mode): New function.
 533         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 534         * tui/tui-winsource.c (tui_show_source_line): Use
 535         tui_set_reverse_mode instead of setting A_STANDOUT.
 536         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 537         New setter methods.
 538
 539 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 540
 541         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 542         Handle tabs.
 543
 544 2019-03-18  Tom Tromey  <tromey@adacore.com>
 545
 546         * ada-lang.c (empty_array): Add "high" parameter.
 547         (ada_evaluate_subexp): Update.
 548
 549 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 550
 551         * unittests/string_view-selftests.c: Define
 552         _initialize_string_view_selftests unconditionally.
 553
 554 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 555
 556         PR gdb/24350
 557         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 558
 559 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 560
 561         PR gdb/24351
 562         * windows-nat.c (display_selector): Fix format specifiers.
 563
 564 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 565
 566         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 567         tui_refill_source_window instead of tui_refresh_win, to update the
 568         current execution line.  This fixes redisplay of the current line
 569         when stepping through the code with "next" or "step".
 570
 571 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 572
 573         * source-cache.c (source_cache::get_source_lines): Call
 574         find_source_lines to initialize s->nlines.  This fixes vertical
 575         scrolling of TUI source window when the DOWN arrow is pressed.
 576
 577 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 578
 579         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 580         linux-thread-db.c (_initialize_thread_db): Likewise.
 581
 582 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 583
 584         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 585         wclrtoeol in tui_show_source_line".  This reverts changes made in
 586         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 587
 588 2019-03-15  Tom Tromey  <tom@tromey.com>
 589
 590         * symtab.h (struct minimal_symbol): Derive from
 591         general_symbol_info.
 592         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 593         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 594         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 595         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 596         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 597         (MSYMBOL_SEARCH_NAME): Update.
 598         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 599         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 600         * minsyms.c (minimal_symbol_reader::record_full): Update.
 601
 602 2019-03-15  Tom Tromey  <tom@tromey.com>
 603
 604         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 605
 606 2019-03-15  Tom Tromey  <tom@tromey.com>
 607
 608         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 609         unique_xmalloc_ptr.
 610         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 611         Update.
 612         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 613         (build_minimal_symbol_hash_tables)
 614         (minimal_symbol_reader::install): Update.
 615
 616 2019-03-15  Tom Tromey  <tom@tromey.com>
 617
 618         * symtab.c (create_demangled_names_hash): Update.
 619         (symbol_set_names): Update.
 620         * objfiles.h (struct objfile_per_bfd_storage)
 621         <demangled_names_hash>: Now an htab_up.
 622         * objfiles.c (objfile_per_bfd_storage): Simplify.
 623
 624 2019-03-15  Tom Tromey  <tom@tromey.com>
 625
 626         * objfiles.h (struct objfile_per_bfd_storage): Declare
 627         destructor.
 628         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 629         New.
 630         (get_objfile_bfd_data): Use new.  Don't initialize
 631         language_of_main.
 632         (free_objfile_per_bfd_storage): Remove.
 633         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 634
 635 2019-03-15  Tom Tromey  <tom@tromey.com>
 636
 637         * symfile.c (reread_symbols): Update.
 638         * objfiles.c (objfile::objfile): Update.
 639         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 640         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 641         comment.
 642         (minimal_symbol_reader::install): Update.
 643         (terminate_minimal_symbol_table): Remove.
 644         * jit.c (jit_object_close_impl): Update.
 645
 646 2019-03-15  Tom Tromey  <tom@tromey.com>
 647
 648         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 649         initializations.
 650
 651 2019-03-15  Tom Tromey  <tom@tromey.com>
 652
 653         * objfiles.h (struct objfile_per_bfd_storage)
 654         <demangled_hash_languages>: Now a bitset.
 655         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 656         (lookup_minimal_symbol): Update.
 657
 658 2019-03-15  Tom Tromey  <tom@tromey.com>
 659
 660         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 661         Don't return the symbol.
 662         * coffread.c (record_minimal_symbol): Use record_full.
 663
 664 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 665
 666         The MS-Windows port of ncurses fails to switch to a color pair if
 667         one or both of the colors are the implicit default colors.  This
 668         change records the default colors when TUI is initialized, and
 669         then specifies them explicitly when a color pair uses the default
 670         colors.  This allows color styling in TUI mode on MS-Windows.
 671
 672         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 673         ncurses_norm_attr.
 674         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 675         colors in ncurses_norm_attr.
 676         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 677         "none", replace it with the default color recorded in
 678         ncurses_norm_attr.
 679
 680 2019-03-14  Tom Tromey  <tromey@adacore.com>
 681
 682         * source-cache.h (class source_cache) <get_source_lines>: Return
 683         std::string.
 684         * source-cache.c (source_cache::extract_lines): Handle case where
 685         first_pos==npos.  Return std::string.
 686         (source_cache::get_source_lines): Update.
 687
 688 2019-03-14  Tom Tromey  <tromey@adacore.com>
 689
 690         * NEWS: Add item for "style sources" commands.
 691         * source-cache.c (source_cache::get_source_lines): Check
 692         source_styling.
 693         * cli/cli-style.c (source_styling): New global.
 694         (_initialize_cli_style): Add "style sources" commands.
 695         (show_style_sources): New function.
 696         * cli/cli-style.h (source_styling): Declare.
 697
 698 2019-03-14  Pedro Alves  <palves@redhat.com>
 699             Tom Tromey  <tromey@adacore.com>
 700
 701         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 702         * tui/tui-winsource.c (tui_refill_source_window): New function,
 703         from...
 704         (tui_horizontal_source_scroll): ... here.  Move some logic.
 705         * cli/cli-style.c (set_style_enabled): Notify new observable.
 706         * tui/tui-hooks.c (tui_redisplay_source): New function.
 707         (tui_attach_detach_observers): Attach or detach
 708         tui_redisplay_source.
 709         * observable.h (source_styling_changed): New observable.
 710         * observable.c: Define source_styling_changed observable.
 711
 712 2019-03-13  Tom Tromey  <tromey@adacore.com>
 713
 714         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 715         (i386_gnu_nat_target::store_registers): Update.
 716         * target-debug.h (target_debug_print_std_string): New macro.
 717         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 718         * windows-tdep.c (display_one_tib): Update.
 719         * tui/tui-stack.c (tui_make_status_line): Update.
 720         * top.c (print_inferior_quit_action): Update.
 721         * thread.c (thr_try_catch_cmd): Update.
 722         (add_thread_with_info): Update.
 723         (thread_target_id_str): Update.
 724         (thr_try_catch_cmd): Update.
 725         (thread_command): Update.
 726         (thread_find_command): Update.
 727         * record-btrace.c (record_btrace_target::info_record)
 728         (record_btrace_resume_thread, record_btrace_target::resume)
 729         (record_btrace_cancel_resume, record_btrace_step_thread)
 730         (record_btrace_target::wait, record_btrace_target::wait)
 731         (record_btrace_target::wait, record_btrace_target::stop): Update.
 732         * progspace.c (print_program_space): Update.
 733         * process-stratum-target.c
 734         (process_stratum_target::thread_address_space): Update.
 735         * linux-fork.c (linux_fork_mourn_inferior)
 736         (detach_checkpoint_command, info_checkpoints_command)
 737         (linux_fork_context): Update.
 738         (linux_fork_detach): Update.
 739         (class scoped_switch_fork_info): Update.
 740         (delete_checkpoint_command): Update.
 741         * infrun.c (follow_fork_inferior): Update.
 742         (follow_fork_inferior): Update.
 743         (proceed_after_vfork_done): Update.
 744         (handle_vfork_child_exec_or_exit): Update.
 745         (follow_exec): Update.
 746         (displaced_step_prepare_throw): Update.
 747         (displaced_step_restore): Update.
 748         (start_step_over): Update.
 749         (resume_1): Update.
 750         (clear_proceed_status_thread): Update.
 751         (proceed): Update.
 752         (print_target_wait_results): Update.
 753         (do_target_wait): Update.
 754         (context_switch): Update.
 755         (stop_all_threads): Update.
 756         (restart_threads): Update.
 757         (finish_step_over): Update.
 758         (handle_signal_stop): Update.
 759         (switch_back_to_stepped_thread): Update.
 760         (keep_going_pass_signal): Update.
 761         (print_exited_reason): Update.
 762         (normal_stop): Update.
 763         * inferior.c (inferior_pid_to_str): Change return type.
 764         (print_selected_inferior): Update.
 765         (add_inferior): Update.
 766         (detach_inferior): Update.
 767         * dummy-frame.c (fprint_dummy_frames): Update.
 768         * dcache.c (dcache_info_1): Update.
 769         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 770         (btrace_fetch, btrace_clear): Update.
 771         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 772         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 773         type.
 774         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 775         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 776         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 777         * gdbarch.c, gdbarch.h: Rebuild.
 778         * gdbarch.sh (core_pid_to_str): Change return type.
 779         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 780         return type.
 781         (windows_nat_target::pid_to_str): Change return type.
 782         (windows_delete_thread): Update.
 783         (windows_nat_target::attach): Update.
 784         (windows_nat_target::files_info): Update.
 785         * target-delegates.c: Rebuild.
 786         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 787         return type.
 788         (sol_thread_target::pid_to_str): Change return type.
 789         * remote.c (class remote_target) <pid_to_str>: Change return
 790         type.
 791         (remote_target::pid_to_str): Change return type.
 792         (extended_remote_target::attach, remote_target::remote_stop_ns)
 793         (remote_target::remote_notif_remove_queued_reply)
 794         (remote_target::push_stop_reply, remote_target::disable_btrace):
 795         Update.
 796         (extended_remote_target::attach): Update.
 797         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 798         type.
 799         (gdbsim_target::pid_to_str): Change return type.
 800         * ravenscar-thread.c (struct ravenscar_thread_target)
 801         <pid_to_str>: Change return type.
 802         (ravenscar_thread_target::pid_to_str): Change return type.
 803         * procfs.c (class procfs_target) <pid_to_str>: Change return
 804         type.
 805         (procfs_target::pid_to_str): Change return type.
 806         (procfs_target::attach): Update.
 807         (procfs_target::detach): Update.
 808         (procfs_target::fetch_registers): Update.
 809         (procfs_target::store_registers): Update.
 810         (procfs_target::wait): Update.
 811         (procfs_target::files_info): Update.
 812         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 813         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 814         return type.
 815         (nto_procfs_target::pid_to_str): Change return type.
 816         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 817         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 818         return type.
 819         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 820         (exit_lwp): Update.
 821         (attach_proc_task_lwp_callback, get_detach_signal)
 822         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 823         (linux_nat_target::resume, wait_lwp, stop_callback)
 824         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 825         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 826         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 827         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 828         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 829         type.
 830         (inf_ptrace_target::attach): Update.
 831         (inf_ptrace_target::files_info): Update.
 832         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 833         type.
 834         (go32_nat_target::pid_to_str): Change return type.
 835         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 836         (gnu_nat_target::wait): Update.
 837         (gnu_nat_target::wait): Update.
 838         (gnu_nat_target::resume): Update.
 839         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 840         (fbsd_nat_target::wait): Update.
 841         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 842         type.
 843         (darwin_nat_target::attach): Update.
 844         * corelow.c (class core_target) <pid_to_str>: Change return type.
 845         (core_target::pid_to_str): Change return type.
 846         * target.c (normal_pid_to_str): Change return type.
 847         (default_pid_to_str): Likewise.
 848         (target_pid_to_str): Change return type.
 849         (target_translate_tls_address): Update.
 850         (target_announce_detach): Update.
 851         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 852         return type.
 853         (bsd_uthread_target::pid_to_str): Change return type.
 854         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 855         type.
 856         (bsd_kvm_target::pid_to_str): Change return type.
 857         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 858         return type.
 859         (aix_thread_target::pid_to_str): Change return type.
 860         * target.h (struct target_ops) <pid_to_str>: Change return type.
 861         (target_pid_to_str, normal_pid_to_str): Likewise.
 862         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 863         type.
 864         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 865         type.
 866         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 867         return type.
 868         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 869         type.
 870         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 871         type.
 872         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 873         return type.
 874
 875 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 876
 877         * NEWS: Mention that the new default MI version is 3.  Mention
 878         changes to the output of commands and events that deal with
 879         multi-location breakpoints.
 880         * breakpoint.c: Include "mi/mi-out.h".
 881         (print_one_breakpoint): Change output syntax if using MI version
 882         >= 3.
 883         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 884         New.
 885         (mi_multi_location_breakpoint_output_fixed): New.
 886         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 887         (mi_cmd_fix_multi_location_breakpoint_output): New.
 888         (mi_multi_location_breakpoint_output_fixed): New.
 889         * mi/mi-cmds.c (mi_cmds): Register command
 890         -fix-multi-location-breakpoint-output.
 891         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 892         interpreter "mi".
 893
 894 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 895
 896         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 897         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 898         instantiate mi_ui_out based on interpreter name.
 899         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 900         * mi/mi-main.c (mi_load_progress): Likewise.
 901
 902 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 903
 904         * NEWS: Combine separate "New targets" sections for 8.3.
 905
 906 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 907
 908         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 909         (ppcfbsd_init_abi): Install gdbarch
 910         "fetch_tls_load_module_address" and "get_thread_local_address"
 911         methods.
 912
 913 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 914
 915         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 916         (riscv_fbsd_init_abi): Install gdbarch
 917         "fetch_tls_load_module_address" and "get_thread_local_address"
 918         methods.
 919
 920 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 921
 922         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 923         (i386fbsd_init_abi): Install gdbarch
 924         "fetch_tls_load_module_address" and "get_thread_local_address"
 925         methods.
 926
 927 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 928
 929         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 930         (amd64fbsd_init_abi): Install gdbarch
 931         "fetch_tls_load_module_address" and "get_thread_local_address"
 932         methods.
 933
 934 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 935
 936         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 937         (struct fbsd_pspace_data): New type.
 938         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 939         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 940         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 941         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 942         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 943
 944 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 945
 946         * gdbtypes.c (lookup_struct_elt): New function.
 947         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 948         * gdbtypes.h (struct struct_elt): New type.
 949         (lookup_struct_elt): New prototype.
 950
 951 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 952
 953         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 954         remove disabled code block.
 955
 956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 957
 958         * gdbarch.sh (get_thread_local_address): New method.
 959         * gdbarch.h, gdbarch.c: Regenerate.
 960         * target.c (target_translate_tls_address): Use
 961         gdbarch_get_thread_local_address if present instead of
 962         target::get_thread_local_address.
 963
 964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 965
 966         * target.h (target::get_thread_local_address): Update comment.
 967
 968 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 969
 970         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 971         objfile->separate_debug_objfile_backlink if not NULL.
 972
 973 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 974
 975         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 976         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 977         (amd64bsd_store_inferior_registers): Likewise.
 978         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 979         Enable segment base registers.
 980         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 981         PT_GETFSBASE and PT_GETGSBASE.
 982         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 983         PT_SETGSBASE.
 984         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 985         segment base registers.
 986         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 987
 988 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 989
 990         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 991         Update calls to i386_target_description to add 'segments'
 992         parameter.
 993         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 994         add segment base registers.
 995         * arch/i386.c (i386_create_target_description): Add 'segments'
 996         parameter to enable segment base registers.
 997         * arch/i386.h (i386_create_target_description): Likewise.
 998         * features/i386/32bit-segments.xml: New file.
 999         * features/i386/32bit-segments.c: Generate.
1000         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1001         call to i386_target_description to add 'segments' parameter.
1002         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1003         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1004         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1005         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1006         if feature is present.
1007         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1008         Add 'segments' parameter to call to i386_target_description.
1009         (i386_target_description): Add 'segments' parameter to enable
1010         segment base registers.
1011         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1012         to call to i386_target_description.
1013         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1014         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1015         Define I386_NUM_REGS.
1016         (i386_target_description): Add 'segments' parameter to enable
1017         segment base registers.
1018
1019 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1020
1021         PR/24325
1022         * source-cache.c: #undef open and close, to avoid unresolved
1023         externals during linking.
1024
1025 2019-03-12  Tom Tromey  <tromey@adacore.com>
1026
1027         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1028         const.  Add initializers.
1029         (_initialize_remote): Don't initialize ptid globals.
1030
1031 2019-03-12  Pedro Alves  <palves@redhat.com>
1032
1033         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1034
1035 2019-03-12  Pedro Alves  <palves@redhat.com>
1036
1037         * cp-name-parser.y (main): Remove unused 'len' variable.
1038
1039 2019-03-12  Tom Tromey  <tromey@adacore.com>
1040
1041         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1042         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1043
1044 2019-03-12  Tom Tromey  <tromey@adacore.com>
1045
1046         * linux-nat.c (iterate_over_lwps): Update.
1047         (stop_callback): Remove parameter.
1048         (stop_wait_callback, detach_callback, resume_set_callback)
1049         (select_singlestep_lwp_callback, set_ignore_sigint)
1050         (status_callback, resumed_callback, resume_clear_callback)
1051         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1052         data parameter.
1053         (linux_nat_target::detach, linux_nat_target::resume)
1054         (linux_stop_and_wait_all_lwps, select_event_lwp)
1055         (linux_nat_filter_event, linux_nat_wait_1)
1056         (linux_nat_target::kill, linux_nat_target::stop)
1057         (linux_nat_target::stop): Update.
1058         (linux_nat_resume_callback): Change type.
1059         (resume_stopped_resumed_lwps, count_events_callback)
1060         (select_event_lwp_callback): Likewise.
1061         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1062         * arm-linux-nat.c (struct update_registers_data): Remove.
1063         (update_registers_callback): Change type.
1064         (arm_linux_insert_hw_breakpoint1): Update.
1065         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1066         parameter.
1067         (x86_linux_dr_set_addr): Update.
1068         (x86_linux_dr_set_control): Update.
1069         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1070         (iterate_over_lwps): Use gdb::function_view.
1071         * nat/aarch64-linux-hw-point.c (struct
1072         aarch64_dr_update_callback_param): Remove.
1073         (debug_reg_change_callback): Change type.
1074         (aarch64_notify_debug_reg_change): Update.
1075         * s390-linux-nat.c (s390_refresh_per_info): Update.
1076
1077 2019-03-11  Tom Tromey  <tromey@adacore.com>
1078
1079         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1080         redundant assignment to "this_cu".
1081
1082 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1083
1084         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1085
1086 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1087
1088         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1089         from...
1090         (rank_one_type): ... this.
1091
1092 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1093
1094         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1095         from...
1096         (rank_one_type): ... this.
1097
1098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1099
1100         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1101         from...
1102         (rank_one_type): ... this.
1103
1104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1105
1106         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1107         from...
1108         (rank_one_type): ... this.
1109
1110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1111
1112         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1113         from...
1114         (rank_one_type): ... this.
1115
1116 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1117
1118         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1119         from...
1120         (rank_one_type): ... this.
1121
1122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1123
1124         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1125         from...
1126         (rank_one_type): ... this.
1127
1128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1129
1130         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1131         from...
1132         (rank_one_type): ... this.
1133
1134 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1135
1136         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1137         from...
1138         (rank_one_type): ... this.
1139
1140 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1141
1142         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1143         from...
1144         (rank_one_type): ... this.
1145
1146 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1147
1148         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1149         from...
1150         (rank_one_type): ... this.
1151
1152 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1153
1154         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1155         from...
1156         (rank_one_type): ... this.
1157
1158 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1159
1160         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1161         inferior-events' shows the example events.
1162
1163 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1164
1165         Support styling on native MS-Windows console
1166
1167         PR/24315
1168         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1169         on MS-Windows if $TERM is not defined.
1170
1171         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1172
1173         * posix-hdep.c (gdb_console_fputs):
1174         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1175         functions.
1176         * ui-file.h (gdb_console_fputs): Add prototype.
1177
1178         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1179         back to fputs only if the former returns zero.
1180
1181 2019-03-07  Tom Tromey  <tom@tromey.com>
1182
1183         * symmisc.c (print_symbol_bcache_statistics): Update.
1184         (print_objfile_statistics): Update.
1185         * symfile.c (allocate_symtab): Update.
1186         * stabsread.c: Don't include bcache.h.
1187         * psymtab.h (struct psymbol_bcache): Don't declare.
1188         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1189         (psymbol_bcache_init, psymbol_bcache_free)
1190         (psymbol_bcache_get_bcache): Don't declare.
1191         * psymtab.c (struct psymbol_bcache): Remove.
1192         (psymtab_storage::psymtab_storage): Update.
1193         (psymtab_storage::~psymtab_storage): Update.
1194         (psymbol_bcache_init, psymbol_bcache_free)
1195         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1196         (add_psymbol_to_bcache): Update.
1197         (allocate_psymtab): Update.
1198         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1199         macro_cache>: No longer pointers.
1200         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1201         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1202         * macrotab.c (macro_bcache): Update.
1203         * macroexp.c: Don't include bcache.h.
1204         * gdbtypes.c (check_types_worklist): Update.
1205         (types_deeply_equal): Remove TRY/CATCH.  Update.
1206         * elfread.c (elf_symtab_read): Update.
1207         * dwarf2read.c: Don't include bcache.h.
1208         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1209         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1210         (print_bcache_statistics, bcache_memory_used): Don't declare.
1211         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1212         methods.  Rename all data members.
1213         * bcache.c (struct bcache): Move to bcache.h.
1214         (bcache::expand_hash_table): Rename from expand_hash_table.
1215         (bcache): Remove.
1216         (bcache::insert): Rename from bcache_full.
1217         (bcache::compare): Rename from bcache_compare.
1218         (bcache_xmalloc): Remove.
1219         (bcache::~bcache): Rename from bcache_xfree.
1220         (bcache::print_statistics): Rename from print_bcache_statistics.
1221         (bcache::memory_used): Rename from bcache_memory_used.
1222
1223 2019-03-07  Pedro Alves  <palves@redhat.com>
1224
1225         * infrun.c (normal_stop): Also check for
1226         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1227
1228 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1229
1230         * f-lang.c (value_from_host_double): Moved to...
1231         * value.c (value_from_host_double): ...here.
1232         * value.h (value_from_host_double): Declare.
1233         * guile/scm-math.c (vlscm_convert_typed_number): Use
1234         value_from_host_double.
1235         (vlscm_convert_number): Likewise.
1236         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1237         * python/py-value.c (convert_value_from_python): Likewise.
1238
1239 2019-03-06  Tom Tromey  <tom@tromey.com>
1240
1241         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1242
1243 2019-03-06  Tom Tromey  <tom@tromey.com>
1244
1245         * utils.h (free_current_contents): Don't declare.
1246         * utils.c (free_current_contents): Remove.
1247
1248 2019-03-06  Tom Tromey  <tom@tromey.com>
1249
1250         * top.c (quit_force): Update.
1251         * main.c (captured_command_loop): Update.
1252         * common/new-op.c (operator new): Update.
1253         * common/common-exceptions.c (struct catcher)
1254         <save_cleanup_chain>: Remove member.
1255         (exceptions_state_mc_init): Update.
1256         (exception_try_scope_entry): Return nullptr.
1257         (exception_try_scope_exit, exception_rethrow)
1258         (throw_exception_sjlj, throw_exception_cxx): Update.
1259         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1260         (all_cleanups, do_cleanups, discard_cleanups)
1261         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1262         (restore_cleanups, restore_final_cleanups): Don't declare.
1263         (do_final_cleanups): Remove parameter.
1264         * common/cleanups.c (cleanup_chain, make_cleanup)
1265         (make_cleanup_dtor, all_cleanups, do_cleanups)
1266         (discard_my_cleanups, discard_cleanups)
1267         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1268         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1269         (null_cleanup): Remove.
1270         (do_final_cleanups): Remove parameter.
1271
1272 2019-03-06  Tom Tromey  <tom@tromey.com>
1273
1274         * remote.c (remote_target::remote_parse_stop_reply): Use
1275         unique_xmalloc_ptr.
1276
1277 2019-03-06  Tom Tromey  <tom@tromey.com>
1278
1279         * stabsread.c (struct stabs_field_info): Rename from field_info.
1280         <list, fnlist>: Add initializers.
1281         <obstack>: New member.
1282         (read_member_functions, read_struct_fields, read_baseclasses):
1283         Allocate on obstack.  Don't use cleanups.
1284         (read_one_struct_field, read_member_functions, read_struct_fields)
1285         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1286         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1287         (read_struct_type): Update.
1288
1289 2019-03-06  Tom Tromey  <tom@tromey.com>
1290
1291         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1292         * common/filestuff.h (make_cleanup_close): Don't declare.
1293         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1294         Remove.
1295
1296 2019-03-06  Tom Tromey  <tom@tromey.com>
1297
1298         * solib-aix.c: Use make_scope_exit.
1299
1300 2019-03-06  Tom Tromey  <tom@tromey.com>
1301
1302         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1303         Use make_scope_exit.
1304
1305 2019-03-06  Tom Tromey  <tom@tromey.com>
1306
1307         * solib-svr4.c (disable_probes_interface): Remove parameter.
1308         (svr4_handle_solib_event): Use make_scope_exit.
1309
1310 2019-03-06  Tom Tromey  <tom@tromey.com>
1311
1312         * remote.c (struct stop_reply_deleter): Remove.
1313         (stop_reply_up): Update.
1314         (struct stop_reply): Derive from notif_event.  Don't typedef.
1315         <regcache>: Now a std::vector.
1316         (stop_reply_xfree): Remove.
1317         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1318         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1319         (remote_target::discard_pending_stop_replies): Use delete.
1320         (remote_target::remote_parse_stop_reply): Update.
1321         (remote_target::process_stop_reply): Update.
1322         * remote-notif.h (struct notif_event): Add virtual destructor.
1323         Remove "dtr" member.
1324         (struct notif_client) <alloc_event>: Return a unique_ptr.
1325         (notif_event_xfree): Don't declare.
1326         (notif_event_up): New typedef.
1327         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1328         (notif_event_xfree, do_notif_event_xfree): Remove.
1329         (remote_notif_state_xfree): Update.
1330
1331 2019-03-06  Tom Tromey  <tom@tromey.com>
1332
1333         * infrun.c (displaced_step_clear_cleanup): Now a
1334         forward_scope_exit type.
1335         (displaced_step_prepare_throw): Update.
1336         (displaced_step_fixup): Update.
1337
1338 2019-03-06  Tom Tromey  <tom@tromey.com>
1339
1340         * inferior.h (class inferior): Update comment.
1341         * gdbthread.h (class thread_info): Update comment.
1342
1343 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1344             Tom Tromey  <tom@tromey.com>
1345
1346         * stabsread.h (struct stab_section_list): Remove.
1347         (coffstab_build_psymtabs): Update.
1348         * dbxread.c (symbuf_sections): Now a std::vector.
1349         (sect_idx): New global.
1350         (fill_symbuf): Update.
1351         (coffstab_build_psymtabs): Change type of stabsects parameter.
1352         Update.
1353         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1354         std::vector.
1355         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1356         (coff_locate_sections): Update.
1357         (coff_symfile_read): Remove cleanups.  Update.
1358         (init_stringtab): Add storage parameter.
1359         (free_stringtab, free_stringtab_cleanup): Remove.
1360         (init_lineno): Add storage parameter.
1361         (free_linetab, free_linetab_cleanup): Remove.
1362
1363 2019-03-06  Pedro Alves  <palves@redhat.com>
1364
1365         * linux-fork.c (fork_info::clobber_regs): Delete.
1366         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1367         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1368         comment.  Adjust.
1369         (scoped_switch_fork_info::scoped_switch_fork_info)
1370         (checkpoint_command, linux_fork_context): Adjust
1371         fork_save_infrun_state calls.
1372
1373 2019-03-06  Pedro Alves  <palves@redhat.com>
1374
1375         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1376         (inf_has_multiple_threads): Return 'bool' and rewrite using
1377         inferior_info::threads().
1378
1379 2019-03-06  Pedro Alves  <palves@redhat.com>
1380
1381         * linux-fork.c: Include <list>.
1382         (fork_list): Now a std::list instance.
1383         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1384         (forks_exist_p, find_last_fork): Adjust.
1385         (new_fork): Delete.
1386         (one_fork_p): New.
1387         (add_fork): Adjust.
1388         (free_fork): Delete, folded into fork_info::~fork_info().
1389         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1390         Adjust.
1391         (init_fork_list): Delete.
1392         (linux_fork_killall, linux_fork_mourn_inferior)
1393         (linux_fork_detach, info_checkpoints_command): Adjust.
1394         (_initialize_linux_fork): No longer call init_fork_list.
1395
1396 2019-03-06  Pedro Alves  <palves@redhat.com>
1397
1398         * linux-fork.c (new_fork): New, split out of ...
1399         (add_fork): ... this.  Return void.  Move "first fork" special
1400         case from here, to ...
1401         (checkpoint_command): ... here.
1402         * linux-linux.h (add_fork): Return void.
1403
1404 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1405
1406         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1407
1408 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1409             Chris January  <chris.january@arm.com>
1410             David Lecomber  <david.lecomber@arm.com>
1411
1412         * f-exp.y: New token, UNOP_INTRINSIC.
1413         (exp): New pattern using UNOP_INTRINSIC token.
1414         (f77_keywords): Add 'abs' keyword.
1415         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1416         (value_from_host_double): New function.
1417         (evaluate_subexp_f): Support UNOP_ABS.
1418
1419 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1420
1421         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1422         types.
1423
1424 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1425
1426         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1427         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1428         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1429
1430 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1433
1434 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1435             Chris January  <chris.january@arm.com>
1436
1437         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1438         * f-exp.y: Define 'KIND' token.
1439         (exp): New pattern for KIND expressions.
1440         (ptype): Handle types with a kind extension.
1441         (direct_abs_decl): Extend to spot kind extensions.
1442         (f77_keywords): Add 'kind' to the list.
1443         (push_kind_type): New function.
1444         (convert_to_kind_type): New function.
1445         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1446         * parse.c (operator_length_standard): Likewise.
1447         * parser-defs.h (enum type_pieces): Add tp_kind.
1448         * std-operator.def: Add UNOP_KIND.
1449
1450 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1451
1452         * f-exp.y (f_parse): Set yydebug.
1453
1454 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1455
1456         * f-lang.c (evaluate_subexp_f): New function.
1457         (exp_descriptor_f): New global.
1458         (f_language_defn): Use exp_descriptor_f instead of
1459         exp_descriptor_standard.
1460
1461 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1462
1463         * f-exp.y (struct token): Add comments.
1464         (dot_ops): Remove uppercase versions and the end marker.
1465         (f77_keywords): Likewise.
1466         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1467         entries in the dot_ops array are case insensitive, and use
1468         strncasecmp to compare strings.  Also some whitespace cleanup in
1469         this area.  Similar for the f77_keywords array, except entries in
1470         this list might be case sensitive.
1471
1472 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1473
1474         * f-exp.y (struct f77_boolean_val): Add comments.
1475         (boolean_values): Remove uppercase versions, and end marker.
1476         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1477         and use strncasecmp to achieve case insensitivity.  Additionally,
1478         perform whitespace cleanup around this code.
1479
1480 2019-03-06  Tom Tromey  <tromey@adacore.com>
1481
1482         * remote-sim.c (gdbsim_target_open): Use result of
1483         gdb_argv::release.
1484
1485 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1486         Dirk Schubert  <dirk.schubert@arm.com>
1487         Chris January  <chris.january@arm.com>
1488
1489         * eval.c (evaluate_subexp_standard): Call Fortran argument
1490         wrapping logic.
1491         * f-lang.c (struct value): A value which can be passed into a
1492         Fortran function call.
1493         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1494         where appropriate.
1495         (struct type): Value ready for a Fortran function call.
1496         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1497         is needed.
1498         * f-lang.h (fortran_argument_convert): Declaration.
1499         (fortran_preserve_arg_pointer): Declaration.
1500         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1501
1502 2019-03-05  Tom Tromey  <tromey@adacore.com>
1503
1504         * python/py-prettyprint.c (print_string_repr): Remove #if.
1505         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1506
1507 2019-03-05  Tom Tromey  <tromey@adacore.com>
1508
1509         * target.c (the_dummy_target): Move later.  Change type to
1510         "dummy_target".
1511         (initialize_targets): Don't initialize the_dummy_target.
1512
1513 2019-03-05  Tom Tromey  <tromey@adacore.com>
1514
1515         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1516         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1517
1518 2019-03-05  Tom Tromey  <tromey@adacore.com>
1519
1520         * windows-nat.c (windows_nat_target::attach)
1521         (windows_nat_target::detach): Don't call gdb_flush.
1522         * valprint.c (generic_val_print, val_print, val_print_string):
1523         Don't call gdb_flush.
1524         * utils.c (defaulted_query): Don't call gdb_flush.
1525         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1526         * target.c (target_announce_detach): Don't call gdb_flush.
1527         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1528         * remote.c (extended_remote_target::attach): Don't call
1529         gdb_flush.
1530         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1531         * printcmd.c (do_examine): Don't call gdb_flush.
1532         (info_display_command): Don't call gdb_flush.
1533         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1534         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1535         * memattr.c (info_mem_command): Don't call gdb_flush.
1536         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1537         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1538         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1539         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1540         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1541         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1542         (gnu_nat_target::detach): Don't call gdb_flush.
1543         * f-valprint.c (f_val_print): Don't call gdb_flush.
1544         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1545         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1546         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1547         gdb_flush.
1548         * c-valprint.c (c_val_print): Don't call gdb_flush.
1549         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1550
1551 2019-03-05  Tom Tromey  <tromey@adacore.com>
1552
1553         * varobj.c (update_dynamic_varobj_children): Update.
1554         (install_default_visualizer): Use reset, not release.
1555         * value.c (set_internalvar): Update.
1556         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1557         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1558         ATTRIBUTE_UNUSED_RESULT.
1559
1560 2019-03-05  Tom Tromey  <tromey@adacore.com>
1561
1562         * remote.c (class scoped_remote_fd) <release>: Add
1563         ATTRIBUTE_UNUSED_RESULT.
1564
1565 2019-03-05  Tom Tromey  <tromey@adacore.com>
1566
1567         * macroexp.c (struct macro_buffer) <release>: Add
1568         ATTRIBUTE_UNUSED_RESULT.
1569
1570 2019-03-05  Tom Tromey  <tromey@adacore.com>
1571
1572         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1573         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1574         ATTRIBUTE_UNUSED_RESULT.
1575
1576 2019-03-05  Tom Tromey  <tromey@adacore.com>
1577
1578         * common/scoped_fd.h (class scoped_fd) <release>: Add
1579         ATTRIBUTE_UNUSED_RESULT.
1580
1581 2019-03-05  Tom Tromey  <tromey@adacore.com>
1582
1583         * parser-defs.h (struct parser_state) <release>: Add
1584         ATTRIBUTE_UNUSED_RESULT.
1585
1586 2019-03-05  Tom Tromey  <tromey@adacore.com>
1587
1588         * utils.h (class gdb_argv) <release>: Add
1589         ATTRIBUTE_UNUSED_RESULT.
1590         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1591
1592 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1593
1594         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1595         for-loop range, to avoid compiler warnings.
1596
1597         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1598         avoid compiler warnings about unused variables.
1599
1600         * NEWS: Mention end of support for native debugging on MS-Windows
1601         before XP.
1602
1603         PR gdb/24292
1604         * common/netstuff.c:
1605         * gdbserver/gdbreplay.c
1606         * gdbserver/remote-utils.c:
1607         * ser-tcp.c:
1608         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1609         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1610         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1611         'getaddrinfo' and 'freeaddrinfo' were not available before
1612         Windows XP, and mingw.org's MinGW headers by default define
1613         _WIN32_WINNT to 0x500.
1614
1615 2019-03-01  Gary Benson <gbenson@redhat.com>
1616
1617         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1618
1619 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1620             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1621
1622         PR gdb/8527
1623         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1624         set_sigint_trap, clear_sigint_trap.
1625
1626 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1627
1628         * target.c (target_detach): Clear the regcache and the
1629         frame cache.
1630
1631 2019-02-27  Pedro Alves  <palves@redhat.com>
1632
1633         * utils.c (set_screen_size): When we cap the height/width sizes,
1634         tweak the corresponding command variable to show "unlimited":
1635
1636 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1637             Pedro Alves  <palves@redhat.com>
1638
1639         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1640         before calling rl_set_screen_size.
1641
1642 2019-02-27  Tom Tromey  <tromey@adacore.com>
1643
1644         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1645         define.
1646         * python/py-value.c: Remove Python 2.4 workaround.
1647         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1648         workaround.
1649         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1650         Python 2.4 workaround.
1651         * python/python-internal.h: Remove Python 2.4 comment.
1652         (Py_ssize_t): Don't define.
1653         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1654         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1655         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1656         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1657         * python/python.c (do_start_initialization): Remove Python 2.4
1658         workaround.
1659         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1660         (print_children): Remove Python 2.4 workaround.
1661         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1662         workaround.
1663         (CHARBUFFERPROC_NAME): Remove.
1664         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1665         Python 2.4 workaround.
1666
1667 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1668
1669         * NEWS: Note minimum Python version.
1670
1671 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1672
1673         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1674         code from these functions.  Remove corresponding ifdefs.  Use
1675         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1676         Remove gotos and target of gotos.
1677         (infpy_search_memory): Likewise.
1678
1679 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1680
1681         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1682         (hppa_gdbarch_init): Don't register deleted functions with
1683         gdbarch.
1684
1685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1686
1687         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1688         (h8300_unwind_sp): Delete.
1689         (h8300_dummy_id): Delete.
1690         (h8300_gdbarch_init): Don't register deleted functions with
1691         gdbarch.
1692
1693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1694
1695         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1696         (ft32_unwind_pc): Delete.
1697         (ft32_unwind_sp): Delete.
1698         (ft32_gdbarch_init): Don't register deleted functions with
1699         gdbarch.
1700
1701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1702
1703         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1704         (frv_unwind_pc): Delete.
1705         (frv_unwind_sp): Delete.
1706         (frv_gdbarch_init): Don't register deleted functions with
1707         gdbarch.
1708
1709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1710
1711         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1712         (riscv_unwind_pc): Delete.
1713         (riscv_unwind_sp): Delete.
1714         (riscv_gdbarch_init): Don't register deleted functions with
1715         gdbarch.
1716
1717 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1718
1719         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1720         (csky_unwind_pc): Delete.
1721         (csky_unwind_sp): Delete.
1722         (csky_gdbarch_init): Don't register deleted functions with
1723         gdbarch.
1724
1725 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1726
1727         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1728         (cris_unwind_pc): Delete.
1729         (cris_unwind_sp): Delete.
1730         (cris_gdbarch_init): Don't register deleted functions with
1731         gdbarch.
1732
1733 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1734
1735         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1736         (bfin_unwind_pc): Delete.
1737         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1738
1739 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1740
1741         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1742         (arm_unwind_pc): Delete.
1743         (arm_unwind_sp): Delete.
1744         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1745
1746 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1747
1748         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1749         (arc_unwind_pc): Delete.
1750         (arc_unwind_sp): Delete.
1751         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1752
1753 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1754
1755         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1756         (alpha_unwind_pc): Delete.
1757         (alpha_gdbarch_init): Don't register deleted functions with
1758         gdbarch.
1759
1760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1761
1762         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1763         (aarch64_unwind_pc): Delete.
1764         (aarch64_unwind_sp): Delete.
1765         (aarch64_gdbarch_init): Don't register deleted functions with
1766         gdbarch.
1767
1768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         * gdbtypes.c (type_align): Don't consider static members when
1771         computing structure alignment.
1772
1773 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1774
1775         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1776         return 0 for other types.
1777         * arch-utils.c (default_type_align): Always return 0.
1778         * gdbarch.h: Regenerate.
1779         * gdbarch.sh (type_align): Extend comment.
1780         * gdbtypes.c (type_align): Add additional comments, always call
1781         gdbarch_type_align before applying the default rules.
1782         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1783         generic code will then apply a suitable default.
1784         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1785         types, return 0 for other types.
1786
1787 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1788
1789         * NEWS: Create a new section for the next release branch.
1790         Rename the section of the current branch, now that it has
1791         been cut.
1792
1793 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1794
1795         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1796         * version.in: Bump version to 8.3.50.DATE-git.
1797
1798 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1799
1800         * aix-thread.c (ptid_cmp): Remove unused variable.
1801         (get_signaled_thread): Likewise.
1802         (store_regs_user_thread): Likewise.
1803         (store_regs_kernel_thread): Likewise.
1804         (fetch_regs_kernel_thread): Remove shadowed variable.
1805
1806 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1807
1808         * features/riscv/32bit-cpu.xml: Add register numbers.
1809         * features/riscv/32bit-fpu.c: Regenerate.
1810         * features/riscv/32bit-fpu.xml: Add register numbers.
1811         * features/riscv/64bit-cpu.xml: Add register numbers.
1812         * features/riscv/64bit-fpu.c: Regenerate.
1813         * features/riscv/64bit-fpu.xml: Add register numbers.
1814
1815 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1816
1817         * NEWS: Mention two argument form of gdb.Value constructor.
1818         * python/py-value.c (convert_buffer_and_type_to_value): New
1819         function.
1820         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1821         Add support for handling an optional second argument.  Call
1822         convert_buffer_and_type_to_value as appropriate.
1823         * python/python-internal.h (Py_buffer_deleter): New struct.
1824         (Py_buffer_up): New typedef.
1825
1826 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1827
1828         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1829         instead of releasing ownership.
1830
1831 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1832
1833         * dwarf2read.c (open_and_init_dwp_file): Call
1834         elf_numsections instead of bfd_count_sections to initialize
1835         dwp_file->num_sections.
1836
1837 2019-02-25  Tom Tromey  <tromey@adacore.com>
1838
1839         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1840
1841 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1842
1843         * gcore.in: Add '--readnever' option when invoking GDB.
1844
1845 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1846
1847         * MAINTAINERS: Update my email address.
1848
1849 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1850
1851         * build-id.c (build_id_to_debug_bfd_1): New function.
1852         (build_id_to_debug_bfd): Look for separate debug file in
1853         sysroot.
1854
1855 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1856
1857         * gdbarch.sh: Update the copyright year range that is placed into
1858         generated files.
1859
1860 2019-02-22  Keith Seitz  <keiths@redhat.com>
1861
1862         PR symtab/23853
1863         * linespec.c (create_sals_line_offset): Search for the default
1864         symtab's filename instead of its fullname.
1865
1866 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1867
1868         * NEWS: Update style defaults.
1869
1870 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1871
1872         * main.c (captured_main_1): Disable styling in batch mode.
1873
1874 2019-02-20  Tom Tromey  <tom@tromey.com>
1875
1876         * symtab.c (symtab_symbol_info): Fix typos.
1877
1878 2019-02-20  Tom Tromey  <tromey@adacore.com>
1879
1880         * findcmd.c (_initialize_mem_search): Use upper case for
1881         metasyntactic variables.
1882
1883 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1884
1885         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1886         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1887
1888 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1889
1890         * top.h (source_file_name): Change to std::string.
1891         * top.c (source_file_name): Likewise.
1892         (command_line_input): Adjust.
1893         * cli/cli-script.c (script_from_file): Adjust.
1894
1895 2019-02-19  Tom Tromey  <tromey@adacore.com>
1896
1897         * ravenscar-thread.c
1898         (ravenscar_thread_target::update_thread_list): Don't call
1899         ada_build_task_list.
1900         * ada-lang.h (ada_build_task_list): Don't declare.
1901         * ada-tasks.c (struct ada_tasks_inferior_data)
1902         <task_list_valid_p>: Now bool.
1903         (read_known_tasks, ada_task_list_changed)
1904         (ada_tasks_invalidate_inferior_data): Update.
1905         (read_known_tasks_array): Return bool.
1906         (read_known_tasks_list): Likewise.
1907         (read_known_tasks): Return void.
1908         (ada_build_task_list): Now static.
1909
1910 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1911
1912         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1913         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1914
1915 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1916
1917         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1918         variant for ada_tasks_pspace_data_handle and
1919         ada_tasks_inferior_data_handle.
1920         (ada_tasks_pspace_data_cleanup): New function.
1921         (ada_tasks_inferior_data_cleanup): New function.
1922
1923 2019-02-17  Tom Tromey  <tom@tromey.com>
1924
1925         * macrotab.h (macro_source_fullname): Return a std::string.
1926         * macrotab.c (macro_include, check_for_redefinition)
1927         (macro_undef, macro_lookup_definition, foreach_macro)
1928         (foreach_macro_in_scope): Update.
1929         (macro_source_fullname): Return a std::string.
1930         * macrocmd.c (show_pp_source_pos): Update.
1931
1932 2019-02-17  Tom Tromey  <tom@tromey.com>
1933
1934         * macrocmd.c (show_pp_source_pos): Style the file names.
1935
1936 2019-02-17  Tom Tromey  <tom@tromey.com>
1937
1938         PR tui/24197:
1939         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1940
1941 2019-02-17  Tom Tromey  <tom@tromey.com>
1942
1943         * ada-lang.c (user_select_syms): Use filtered printing.
1944         * utils.c (wrap_style): New global.
1945         (desired_style): Remove.
1946         (emit_style_escape): Add stream parameter.
1947         (set_output_style, reset_terminal_style, prompt_for_continue):
1948         Update.
1949         (flush_wrap_buffer): Only flush gdb_stdout.
1950         (wrap_here): Set wrap_style.
1951         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1952         treat escape sequences as a character.  Change when wrap buffer is
1953         flushed.
1954         (fputs_styled): Do not set the output style when the default is
1955         requested.
1956         * ui-style.h (struct ui_file_style) <is_default>: New method.
1957         * source.c (print_source_lines_base): Emit escape sequences in one
1958         piece.
1959
1960 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1961
1962         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1963         integers and enumeration types.
1964
1965 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1966
1967         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1968         instead of lookup_symbol_in_language
1969         (do_exact_match): New function.
1970         (ada_get_symbol_name_matcher): Return do_exact_match when
1971         doing a verbatim match.
1972
1973 2019-02-15  Tom Tromey  <tromey@adacore.com>
1974
1975         * ravenscar-thread.c (ravenscar_thread_target::resume)
1976         (ravenscar_thread_target::wait): Special case wildcard requests.
1977
1978 2019-02-15  Tom Tromey  <tromey@adacore.com>
1979
1980         * ravenscar-thread.c (base_ptid): Remove.
1981         (struct ravenscar_thread_target) <close>: New method.
1982         <m_base_ptid>: New member.
1983         <update_inferior_ptid, active_task, task_is_currently_active,
1984         runtime_initialized>: Declare methods.
1985         <ravenscar_thread_target>: Add constructor.
1986         (ravenscar_thread_target::task_is_currently_active)
1987         (ravenscar_thread_target::update_inferior_ptid)
1988         (ravenscar_runtime_initialized): Rename.  Now methods.
1989         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1990         (ravenscar_thread_target::update_thread_list): Update.
1991         (ravenscar_thread_target::active_task): Now method.
1992         (ravenscar_thread_target::store_registers)
1993         (ravenscar_thread_target::prepare_to_store)
1994         (ravenscar_thread_target::prepare_to_store)
1995         (ravenscar_thread_target::mourn_inferior): Update.
1996         (ravenscar_inferior_created): Use "new" to create target.
1997         (ravenscar_thread_target::get_ada_task_ptid): Update.
1998         (_initialize_ravenscar): Don't initialize base_ptid.
1999         (ravenscar_ops): Remove global.
2000
2001 2019-02-15  Tom Tromey  <tromey@adacore.com>
2002
2003         * target.h (push_target): Declare new overload.
2004         * target.c (push_target): New overload, taking an rvalue reference.
2005         * remote.c (remote_target::open_1): Use push_target overload.
2006         * corelow.c (core_target_open): Use push_target overload.
2007
2008 2019-02-15  Tom Tromey  <tromey@adacore.com>
2009
2010         * ravenscar-thread.c (is_ravenscar_task)
2011         (ravenscar_task_is_currently_active): Return bool.
2012         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2013         (_initialize_ravenscar): Remove "(void)".
2014         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2015         Return bool.
2016
2017 2019-02-15  Tom Tromey  <tromey@adacore.com>
2018
2019         * ravenscar-thread.c (ravenscar_runtime_initializer)
2020         (has_ravenscar_runtime, get_running_thread_id)
2021         (ravenscar_thread_target::resume): Fix indentation.
2022
2023 2019-02-15  Tom Tromey  <tromey@adacore.com>
2024
2025         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2026         from ravenscar_arch_ops.
2027         (sparc_ravenscar_ops::fetch_registers)
2028         (sparc_ravenscar_ops::store_registers): Now methods.
2029         (sparc_ravenscar_prepare_to_store): Remove.
2030         (sparc_ravenscar_ops): Redefine.
2031         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2032         methods and destructor.  Remove members.
2033         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2034         (ravenscar_thread_target::store_registers)
2035         (ravenscar_thread_target::prepare_to_store): Update.
2036         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2037         Remove.
2038         (struct ppc_ravenscar_powerpc_ops): Derive from
2039         ravenscar_arch_ops.
2040         (ppc_ravenscar_powerpc_ops::fetch_registers)
2041         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2042         (ppc_ravenscar_powerpc_ops): Redefine.
2043         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2044         (ppc_ravenscar_e500_ops::fetch_registers)
2045         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2046         (ppc_ravenscar_e500_ops): Redefine.
2047         * aarch64-ravenscar-thread.c
2048         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2049         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2050         (aarch64_ravenscar_fetch_registers)
2051         (aarch64_ravenscar_store_registers): Now methods.
2052         (aarch64_ravenscar_ops): Redefine.
2053
2054 2019-02-15  Tom Tromey  <tromey@adacore.com>
2055
2056         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2057         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2058         (ravenscar_thread_target::stopped_by_watchpoint)
2059         (ravenscar_thread_target::stopped_data_address)
2060         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2061
2062 2019-02-15  Tom Tromey  <tromey@adacore.com>
2063
2064         * ravenscar-thread.c: Fix some typos.
2065
2066 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2067             Tom Tromey  <tromey@adacore.com>
2068
2069         * ada-lang.c (ada_exception_sal): Change addr_string to a
2070         std::string.
2071         (create_ada_exception_catchpoint): Update.
2072
2073 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2074             Tom Tromey  <tromey@adacore.com>
2075
2076         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2077         (bp_location_ops): Remove.
2078         (base_breakpoint_allocate_location): Update.
2079         (free_bp_location): Update.
2080         * ada-lang.c (class ada_catchpoint_location)
2081         <ada_catchpoint_location>: Remove ops parameter.
2082         (ada_catchpoint_location_dtor): Remove.
2083         (ada_catchpoint_location_ops): Remove.
2084         (allocate_location_exception): Update.
2085         * breakpoint.h (struct bp_location_ops): Remove.
2086         (class bp_location) <bp_location>: Remove bp_location_ops
2087         parameter.
2088         <~bp_location>: Add destructor.
2089         <ops>: Remove.
2090
2091 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2092             Pedro Alves  <palves@redhat.com>
2093
2094         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2095         'PATH_MAX'.
2096
2097 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2098             Samuel Thibault  <samuel.thibault@gnu.org>
2099             Thomas Schwinge  <thomas@codesourcery.com>
2100
2101         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2102         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2103
2104 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2105
2106         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2107         (check_empty): Use "const char *".
2108
2109         * gnu-nat.c (gnu_nat_target::detach): Instead of
2110         'detach_inferior (pid)' call
2111         'detach_inferior (find_inferior_pid (pid))'.
2112
2113         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2114         'nat/fork-inferior.o'.
2115         * gnu-nat.c: #include "nat/fork-inferior.h".
2116
2117         * gnu-nat.c (gnu_nat_target::detach): Instead of
2118         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2119         * gnu-nat.h: #include "inf-child.h".
2120         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2121         'i386_gnu_nat_target::fetch_registers'.
2122         (gnu_store_registers): Rename/move to
2123         'i386_gnu_nat_target::store_registers'.
2124
2125         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2126         * gnu-nat.h (mach_thread_info): New function.
2127         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2128
2129         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2130
2131 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2132
2133         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2134
2135 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2136
2137         * windows-nat.c (windows_add_thread): Add new parameter
2138         "main_thread_p" with default value set to false.  Update
2139         function documentation as well as all callers.
2140         (windows_delete_thread): Likewise.
2141         (fake_create_process): Update call to windows_add_thread.
2142         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2143         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2144         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2145         call to windows_delete_thread.
2146
2147 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2148
2149         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2150
2151 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2152
2153         * symfile.c (find_separate_debug_file): Use canonical path of
2154         sysroot with child_path instead of gdb_sysroot if it is valid.
2155
2156 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2157
2158         * symfile.c (find_separate_debug_file): Use child_path to
2159         determine if an object file is under a sysroot.
2160
2161 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2162
2163         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2164         unittests/child-path-selftests.c.
2165         * common/pathstuff.c (child_path): New function.
2166         * common/pathstuff.h (child_path): New prototype.
2167         * unittests/child-path-selftests.c: New file.
2168
2169 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2170
2171         * symfile.c (find_separate_debug_file): Look for separate debug
2172         files in debug directories under the sysroot.
2173
2174 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2175
2176         * symtab.h (struct minimal_symbol data_p): New const method.
2177         (struct minimal_symbol text_p): Likewise.
2178         * symtab.c (output_source_filename): Use file name style
2179         to print file name.
2180         (print_symbol_info): Likewise.
2181         (print_msymbol_info): Use address style to print addresses.
2182         Use function name style to print executable text symbols.
2183         (expand_symtab_containing_pc): Use data_p.
2184         (find_pc_sect_compunit_symtab): Likewise.
2185
2186 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2187
2188         * breakpoint.c (describe_other_breakpoints): Use address style
2189         to print addresses.
2190         (say_where): Likewise.
2191
2192 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2193
2194         * ada-typeprint.c (print_func_type): Print function name
2195         style to print function name.
2196         * c-typeprint.c (c_print_type_1): Likewise.
2197
2198 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2199
2200         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2201         for execve.
2202
2203 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2204
2205         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2206         type_stack.
2207
2208 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2209
2210         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2211         TYPE_CODE_REF types.
2212
2213 2019-02-08  Jim Wilson  <jimw@sifive.com>
2214
2215         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2216         (riscv_linux_fregset): New.
2217         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2218
2219 2019-02-07  Tom Tromey  <tom@tromey.com>
2220
2221         * thread.c (thread_cancel_execution_command): Update.
2222         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2223         methods.
2224         (struct thread_fsm_ops): Remove.
2225         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2226         (thread_fsm_should_stop, thread_fsm_return_value)
2227         (thread_fsm_set_finished, thread_fsm_finished_p)
2228         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2229         Don't declare.
2230         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2231         * infrun.c (clear_proceed_status_thread)
2232         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2233         (print_stop_event): Update.
2234         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2235         Add constructor.
2236         (step_command_fsm_ops): Remove.
2237         (new_step_command_fsm): Remove.
2238         (step_1): Update.
2239         (step_command_fsm::should_stop): Rename from
2240         step_command_fsm_should_stop.
2241         (step_command_fsm::clean_up): Rename from
2242         step_command_fsm_clean_up.
2243         (step_command_fsm::do_async_reply_reason): Rename from
2244         step_command_fsm_async_reply_reason.
2245         (struct until_next_fsm): Inherit from thread_fsm.  Add
2246         constructor.
2247         (until_next_fsm_ops): Remove.
2248         (new_until_next_fsm): Remove.
2249         (until_next_fsm::should_stop): Rename from
2250         until_next_fsm_should_stop.
2251         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2252         (until_next_fsm::do_async_reply_reason): Rename from
2253         until_next_fsm_async_reply_reason.
2254         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2255         constructor.  Change type of breakpoint.
2256         (finish_command_fsm_ops): Remove.
2257         (new_finish_command_fsm): Remove.
2258         (finish_command_fsm::should_stop): Rename from
2259         finish_command_fsm_should_stop.
2260         (finish_command_fsm::clean_up): Rename from
2261         finish_command_fsm_clean_up.
2262         (finish_command_fsm::return_value): Rename from
2263         finish_command_fsm_return_value.
2264         (finish_command_fsm::do_async_reply_reason): Rename from
2265         finish_command_fsm_async_reply_reason.
2266         (finish_command): Update.
2267         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2268         Add constructor.
2269         (call_thread_fsm_ops): Remove.
2270         (call_thread_fsm::call_thread_fsm): Rename from
2271         new_call_thread_fsm.
2272         (call_thread_fsm::should_stop): Rename from
2273         call_thread_fsm_should_stop.
2274         (call_thread_fsm::should_notify_stop): Rename from
2275         call_thread_fsm_should_notify_stop.
2276         (run_inferior_call, call_function_by_hand_dummy): Update.
2277         * cli/cli-interp.c (should_print_stop_to_console): Update.
2278         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2279         Add constructor.  Change type of location_breakpoint,
2280         caller_breakpoint.
2281         (until_break_fsm_ops): Remove.
2282         (new_until_break_fsm): Remove.
2283         (until_break_fsm::should_stop): Rename from
2284         until_break_fsm_should_stop.
2285         (until_break_fsm::clean_up): Rename from
2286         until_break_fsm_clean_up.
2287         (until_break_fsm::do_async_reply_reason): Rename from
2288         until_break_fsm_async_reply_reason.
2289         (until_break_command): Update.
2290         * thread-fsm.c: Remove.
2291         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2292
2293 2019-02-07  Tom Tromey  <tom@tromey.com>
2294
2295         * yy-remap.h: Add include guard.
2296         * xtensa-tdep.h: Add include guard.
2297         * xcoffread.h: Rename include guard.
2298         * varobj-iter.h: Add include guard.
2299         * tui/tui.h: Rename include guard.
2300         * tui/tui-winsource.h: Rename include guard.
2301         * tui/tui-wingeneral.h: Rename include guard.
2302         * tui/tui-windata.h: Rename include guard.
2303         * tui/tui-win.h: Rename include guard.
2304         * tui/tui-stack.h: Rename include guard.
2305         * tui/tui-source.h: Rename include guard.
2306         * tui/tui-regs.h: Rename include guard.
2307         * tui/tui-out.h: Rename include guard.
2308         * tui/tui-layout.h: Rename include guard.
2309         * tui/tui-io.h: Rename include guard.
2310         * tui/tui-hooks.h: Rename include guard.
2311         * tui/tui-file.h: Rename include guard.
2312         * tui/tui-disasm.h: Rename include guard.
2313         * tui/tui-data.h: Rename include guard.
2314         * tui/tui-command.h: Rename include guard.
2315         * tic6x-tdep.h: Add include guard.
2316         * target/waitstatus.h: Rename include guard.
2317         * target/wait.h: Rename include guard.
2318         * target/target.h: Rename include guard.
2319         * target/resume.h: Rename include guard.
2320         * target-float.h: Rename include guard.
2321         * stabsread.h: Add include guard.
2322         * rs6000-tdep.h: Add include guard.
2323         * riscv-fbsd-tdep.h: Add include guard.
2324         * regformats/regdef.h: Rename include guard.
2325         * record.h: Rename include guard.
2326         * python/python.h: Rename include guard.
2327         * python/python-internal.h: Rename include guard.
2328         * python/py-stopevent.h: Rename include guard.
2329         * python/py-ref.h: Rename include guard.
2330         * python/py-record.h: Rename include guard.
2331         * python/py-record-full.h: Rename include guard.
2332         * python/py-record-btrace.h: Rename include guard.
2333         * python/py-instruction.h: Rename include guard.
2334         * python/py-events.h: Rename include guard.
2335         * python/py-event.h: Rename include guard.
2336         * procfs.h: Add include guard.
2337         * proc-utils.h: Add include guard.
2338         * p-lang.h: Add include guard.
2339         * or1k-tdep.h: Rename include guard.
2340         * observable.h: Rename include guard.
2341         * nto-tdep.h: Rename include guard.
2342         * nat/x86-linux.h: Rename include guard.
2343         * nat/x86-linux-dregs.h: Rename include guard.
2344         * nat/x86-gcc-cpuid.h: Add include guard.
2345         * nat/x86-dregs.h: Rename include guard.
2346         * nat/x86-cpuid.h: Rename include guard.
2347         * nat/ppc-linux.h: Rename include guard.
2348         * nat/mips-linux-watch.h: Rename include guard.
2349         * nat/linux-waitpid.h: Rename include guard.
2350         * nat/linux-ptrace.h: Rename include guard.
2351         * nat/linux-procfs.h: Rename include guard.
2352         * nat/linux-osdata.h: Rename include guard.
2353         * nat/linux-nat.h: Rename include guard.
2354         * nat/linux-namespaces.h: Rename include guard.
2355         * nat/linux-btrace.h: Rename include guard.
2356         * nat/glibc_thread_db.h: Rename include guard.
2357         * nat/gdb_thread_db.h: Rename include guard.
2358         * nat/gdb_ptrace.h: Rename include guard.
2359         * nat/fork-inferior.h: Rename include guard.
2360         * nat/amd64-linux-siginfo.h: Rename include guard.
2361         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2362         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2363         * nat/aarch64-linux.h: Rename include guard.
2364         * nat/aarch64-linux-hw-point.h: Rename include guard.
2365         * mn10300-tdep.h: Add include guard.
2366         * mips-linux-tdep.h: Add include guard.
2367         * mi/mi-parse.h: Rename include guard.
2368         * mi/mi-out.h: Rename include guard.
2369         * mi/mi-main.h: Rename include guard.
2370         * mi/mi-interp.h: Rename include guard.
2371         * mi/mi-getopt.h: Rename include guard.
2372         * mi/mi-console.h: Rename include guard.
2373         * mi/mi-common.h: Rename include guard.
2374         * mi/mi-cmds.h: Rename include guard.
2375         * mi/mi-cmd-break.h: Rename include guard.
2376         * m2-lang.h: Add include guard.
2377         * location.h: Rename include guard.
2378         * linux-record.h: Rename include guard.
2379         * linux-nat.h: Add include guard.
2380         * linux-fork.h: Add include guard.
2381         * i386-darwin-tdep.h: Rename include guard.
2382         * hppa-linux-offsets.h: Add include guard.
2383         * guile/guile.h: Rename include guard.
2384         * guile/guile-internal.h: Rename include guard.
2385         * gnu-nat.h: Rename include guard.
2386         * gdb-stabs.h: Rename include guard.
2387         * frv-tdep.h: Add include guard.
2388         * f-lang.h: Add include guard.
2389         * event-loop.h: Add include guard.
2390         * darwin-nat.h: Rename include guard.
2391         * cp-abi.h: Rename include guard.
2392         * config/sparc/nm-sol2.h: Rename include guard.
2393         * config/nm-nto.h: Rename include guard.
2394         * config/nm-linux.h: Add include guard.
2395         * config/i386/nm-i386gnu.h: Rename include guard.
2396         * config/djgpp/nl_types.h: Rename include guard.
2397         * config/djgpp/langinfo.h: Rename include guard.
2398         * compile/gcc-cp-plugin.h: Add include guard.
2399         * compile/gcc-c-plugin.h: Add include guard.
2400         * compile/compile.h: Rename include guard.
2401         * compile/compile-object-run.h: Rename include guard.
2402         * compile/compile-object-load.h: Rename include guard.
2403         * compile/compile-internal.h: Rename include guard.
2404         * compile/compile-cplus.h: Rename include guard.
2405         * compile/compile-c.h: Rename include guard.
2406         * common/xml-utils.h: Rename include guard.
2407         * common/x86-xstate.h: Rename include guard.
2408         * common/version.h: Rename include guard.
2409         * common/vec.h: Rename include guard.
2410         * common/tdesc.h: Rename include guard.
2411         * common/selftest.h: Rename include guard.
2412         * common/scoped_restore.h: Rename include guard.
2413         * common/scoped_mmap.h: Rename include guard.
2414         * common/scoped_fd.h: Rename include guard.
2415         * common/safe-iterator.h: Rename include guard.
2416         * common/run-time-clock.h: Rename include guard.
2417         * common/refcounted-object.h: Rename include guard.
2418         * common/queue.h: Rename include guard.
2419         * common/ptid.h: Rename include guard.
2420         * common/print-utils.h: Rename include guard.
2421         * common/preprocessor.h: Rename include guard.
2422         * common/pathstuff.h: Rename include guard.
2423         * common/observable.h: Rename include guard.
2424         * common/netstuff.h: Rename include guard.
2425         * common/job-control.h: Rename include guard.
2426         * common/host-defs.h: Rename include guard.
2427         * common/gdb_wait.h: Rename include guard.
2428         * common/gdb_vecs.h: Rename include guard.
2429         * common/gdb_unlinker.h: Rename include guard.
2430         * common/gdb_unique_ptr.h: Rename include guard.
2431         * common/gdb_tilde_expand.h: Rename include guard.
2432         * common/gdb_sys_time.h: Rename include guard.
2433         * common/gdb_string_view.h: Rename include guard.
2434         * common/gdb_splay_tree.h: Rename include guard.
2435         * common/gdb_setjmp.h: Rename include guard.
2436         * common/gdb_ref_ptr.h: Rename include guard.
2437         * common/gdb_optional.h: Rename include guard.
2438         * common/gdb_locale.h: Rename include guard.
2439         * common/gdb_assert.h: Rename include guard.
2440         * common/filtered-iterator.h: Rename include guard.
2441         * common/filestuff.h: Rename include guard.
2442         * common/fileio.h: Rename include guard.
2443         * common/environ.h: Rename include guard.
2444         * common/common-utils.h: Rename include guard.
2445         * common/common-types.h: Rename include guard.
2446         * common/common-regcache.h: Rename include guard.
2447         * common/common-inferior.h: Rename include guard.
2448         * common/common-gdbthread.h: Rename include guard.
2449         * common/common-exceptions.h: Rename include guard.
2450         * common/common-defs.h: Rename include guard.
2451         * common/common-debug.h: Rename include guard.
2452         * common/cleanups.h: Rename include guard.
2453         * common/buffer.h: Rename include guard.
2454         * common/btrace-common.h: Rename include guard.
2455         * common/break-common.h: Rename include guard.
2456         * cli/cli-utils.h: Rename include guard.
2457         * cli/cli-style.h: Rename include guard.
2458         * cli/cli-setshow.h: Rename include guard.
2459         * cli/cli-script.h: Rename include guard.
2460         * cli/cli-interp.h: Rename include guard.
2461         * cli/cli-decode.h: Rename include guard.
2462         * cli/cli-cmds.h: Rename include guard.
2463         * charset-list.h: Add include guard.
2464         * buildsym-legacy.h: Rename include guard.
2465         * bfin-tdep.h: Add include guard.
2466         * ax.h: Rename include guard.
2467         * arm-linux-tdep.h: Add include guard.
2468         * arm-fbsd-tdep.h: Add include guard.
2469         * arch/xtensa.h: Rename include guard.
2470         * arch/tic6x.h: Add include guard.
2471         * arch/i386.h: Add include guard.
2472         * arch/arm.h: Rename include guard.
2473         * arch/arm-linux.h: Rename include guard.
2474         * arch/arm-get-next-pcs.h: Rename include guard.
2475         * arch/amd64.h: Add include guard.
2476         * arch/aarch64-insn.h: Rename include guard.
2477         * arch-utils.h: Rename include guard.
2478         * annotate.h: Add include guard.
2479         * amd64-darwin-tdep.h: Rename include guard.
2480         * aarch64-linux-tdep.h: Add include guard.
2481         * aarch64-fbsd-tdep.h: Add include guard.
2482         * aarch32-linux-nat.h: Add include guard.
2483
2484 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2485
2486         * macrotab.c (macro_define_internal): New function that
2487         factorizes macro_define_object_internal and macro_define_function
2488         code.
2489         (macro_define_object_internal): Use macro_define_internal.
2490         (macro_define_function): Likewise.
2491
2492 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2493
2494         * macrocmd.c (extract_identifier): Return
2495         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2496         callers.
2497
2498 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2499
2500         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2501
2502 2019-02-05  Tom Tromey  <tom@tromey.com>
2503
2504         * target.c (target_stack::unpush): Move assertion earlier.
2505
2506 2019-01-30  Tom Tromey  <tom@tromey.com>
2507
2508         PR python/23615:
2509         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2510         (gdbpy_parse_and_eval): Likewise.
2511         * python/python-internal.h (gdbpy_allow_threads): New class.
2512
2513 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2514
2515         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2516         (aarch64_fbsd_fpregmap): Move earlier.
2517         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2518         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2519         instead of individual calls to trad_frame_set_reg_addr.
2520         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2521         earlier.
2522         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2523         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2524         instead of individual calls to trad_frame_set_reg_addr.
2525
2526 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2527
2528         * CONTRIBUTE: Replace contribution list with wiki link.
2529
2530 2019-01-25  Tom Tromey  <tom@tromey.com>
2531
2532         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2533
2534 2019-01-25  Tom Tromey  <tom@tromey.com>
2535
2536         * xtensa-linux-nat.c: Fix common/ includes.
2537         * xml-support.h: Fix common/ includes.
2538         * xml-support.c: Fix common/ includes.
2539         * x86-linux-nat.c: Fix common/ includes.
2540         * windows-nat.c: Fix common/ includes.
2541         * varobj.h: Fix common/ includes.
2542         * varobj.c: Fix common/ includes.
2543         * value.c: Fix common/ includes.
2544         * valops.c: Fix common/ includes.
2545         * utils.c: Fix common/ includes.
2546         * unittests/xml-utils-selftests.c: Fix common/ includes.
2547         * unittests/utils-selftests.c: Fix common/ includes.
2548         * unittests/unpack-selftests.c: Fix common/ includes.
2549         * unittests/tracepoint-selftests.c: Fix common/ includes.
2550         * unittests/style-selftests.c: Fix common/ includes.
2551         * unittests/string_view-selftests.c: Fix common/ includes.
2552         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2553         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2554         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2555         * unittests/rsp-low-selftests.c: Fix common/ includes.
2556         * unittests/parse-connection-spec-selftests.c: Fix common/
2557         includes.
2558         * unittests/optional-selftests.c: Fix common/ includes.
2559         * unittests/offset-type-selftests.c: Fix common/ includes.
2560         * unittests/observable-selftests.c: Fix common/ includes.
2561         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2562         * unittests/memrange-selftests.c: Fix common/ includes.
2563         * unittests/memory-map-selftests.c: Fix common/ includes.
2564         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2565         * unittests/function-view-selftests.c: Fix common/ includes.
2566         * unittests/environ-selftests.c: Fix common/ includes.
2567         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2568         * unittests/common-utils-selftests.c: Fix common/ includes.
2569         * unittests/cli-utils-selftests.c: Fix common/ includes.
2570         * unittests/array-view-selftests.c: Fix common/ includes.
2571         * ui-file.c: Fix common/ includes.
2572         * tui/tui-io.c: Fix common/ includes.
2573         * tracepoint.h: Fix common/ includes.
2574         * tracepoint.c: Fix common/ includes.
2575         * tracefile-tfile.c: Fix common/ includes.
2576         * top.h: Fix common/ includes.
2577         * top.c: Fix common/ includes.
2578         * thread.c: Fix common/ includes.
2579         * target/waitstatus.h: Fix common/ includes.
2580         * target/waitstatus.c: Fix common/ includes.
2581         * target.h: Fix common/ includes.
2582         * target.c: Fix common/ includes.
2583         * target-memory.c: Fix common/ includes.
2584         * target-descriptions.c: Fix common/ includes.
2585         * symtab.h: Fix common/ includes.
2586         * symfile.c: Fix common/ includes.
2587         * stap-probe.c: Fix common/ includes.
2588         * spu-linux-nat.c: Fix common/ includes.
2589         * sparc-nat.c: Fix common/ includes.
2590         * source.c: Fix common/ includes.
2591         * solib.c: Fix common/ includes.
2592         * solib-target.c: Fix common/ includes.
2593         * ser-unix.c: Fix common/ includes.
2594         * ser-tcp.c: Fix common/ includes.
2595         * ser-pipe.c: Fix common/ includes.
2596         * ser-base.c: Fix common/ includes.
2597         * selftest-arch.c: Fix common/ includes.
2598         * s12z-tdep.c: Fix common/ includes.
2599         * rust-exp.y: Fix common/ includes.
2600         * rs6000-aix-tdep.c: Fix common/ includes.
2601         * riscv-tdep.c: Fix common/ includes.
2602         * remote.c: Fix common/ includes.
2603         * remote-notif.h: Fix common/ includes.
2604         * remote-fileio.h: Fix common/ includes.
2605         * remote-fileio.c: Fix common/ includes.
2606         * regcache.h: Fix common/ includes.
2607         * regcache.c: Fix common/ includes.
2608         * record-btrace.c: Fix common/ includes.
2609         * python/python.c: Fix common/ includes.
2610         * python/py-type.c: Fix common/ includes.
2611         * python/py-inferior.c: Fix common/ includes.
2612         * progspace.h: Fix common/ includes.
2613         * producer.c: Fix common/ includes.
2614         * procfs.c: Fix common/ includes.
2615         * proc-api.c: Fix common/ includes.
2616         * printcmd.c: Fix common/ includes.
2617         * ppc-linux-nat.c: Fix common/ includes.
2618         * parser-defs.h: Fix common/ includes.
2619         * osdata.c: Fix common/ includes.
2620         * obsd-nat.c: Fix common/ includes.
2621         * nat/x86-linux.c: Fix common/ includes.
2622         * nat/x86-linux-dregs.c: Fix common/ includes.
2623         * nat/x86-dregs.h: Fix common/ includes.
2624         * nat/x86-dregs.c: Fix common/ includes.
2625         * nat/ppc-linux.c: Fix common/ includes.
2626         * nat/mips-linux-watch.h: Fix common/ includes.
2627         * nat/mips-linux-watch.c: Fix common/ includes.
2628         * nat/linux-waitpid.c: Fix common/ includes.
2629         * nat/linux-ptrace.h: Fix common/ includes.
2630         * nat/linux-ptrace.c: Fix common/ includes.
2631         * nat/linux-procfs.c: Fix common/ includes.
2632         * nat/linux-personality.c: Fix common/ includes.
2633         * nat/linux-osdata.c: Fix common/ includes.
2634         * nat/linux-namespaces.c: Fix common/ includes.
2635         * nat/linux-btrace.h: Fix common/ includes.
2636         * nat/linux-btrace.c: Fix common/ includes.
2637         * nat/fork-inferior.c: Fix common/ includes.
2638         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2639         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2640         * nat/aarch64-linux.c: Fix common/ includes.
2641         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2642         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2643         * namespace.h: Fix common/ includes.
2644         * mips-linux-tdep.c: Fix common/ includes.
2645         * minsyms.c: Fix common/ includes.
2646         * mi/mi-parse.h: Fix common/ includes.
2647         * mi/mi-main.c: Fix common/ includes.
2648         * mi/mi-cmd-env.c: Fix common/ includes.
2649         * memrange.h: Fix common/ includes.
2650         * memattr.c: Fix common/ includes.
2651         * maint.h: Fix common/ includes.
2652         * maint.c: Fix common/ includes.
2653         * main.c: Fix common/ includes.
2654         * machoread.c: Fix common/ includes.
2655         * location.c: Fix common/ includes.
2656         * linux-thread-db.c: Fix common/ includes.
2657         * linux-nat.c: Fix common/ includes.
2658         * linux-fork.c: Fix common/ includes.
2659         * inline-frame.c: Fix common/ includes.
2660         * infrun.c: Fix common/ includes.
2661         * inflow.c: Fix common/ includes.
2662         * inferior.h: Fix common/ includes.
2663         * inferior.c: Fix common/ includes.
2664         * infcmd.c: Fix common/ includes.
2665         * inf-ptrace.c: Fix common/ includes.
2666         * inf-child.c: Fix common/ includes.
2667         * ia64-linux-nat.c: Fix common/ includes.
2668         * i387-tdep.c: Fix common/ includes.
2669         * i386-tdep.c: Fix common/ includes.
2670         * i386-linux-tdep.c: Fix common/ includes.
2671         * i386-linux-nat.c: Fix common/ includes.
2672         * i386-go32-tdep.c: Fix common/ includes.
2673         * i386-fbsd-tdep.c: Fix common/ includes.
2674         * i386-fbsd-nat.c: Fix common/ includes.
2675         * guile/scm-type.c: Fix common/ includes.
2676         * guile/guile.c: Fix common/ includes.
2677         * go32-nat.c: Fix common/ includes.
2678         * gnu-nat.c: Fix common/ includes.
2679         * gdbthread.h: Fix common/ includes.
2680         * gdbarch-selftests.c: Fix common/ includes.
2681         * gdb_usleep.c: Fix common/ includes.
2682         * gdb_select.h: Fix common/ includes.
2683         * gdb_bfd.c: Fix common/ includes.
2684         * gcore.c: Fix common/ includes.
2685         * fork-child.c: Fix common/ includes.
2686         * findvar.c: Fix common/ includes.
2687         * fbsd-nat.c: Fix common/ includes.
2688         * event-top.c: Fix common/ includes.
2689         * event-loop.c: Fix common/ includes.
2690         * dwarf2read.c: Fix common/ includes.
2691         * dwarf2loc.c: Fix common/ includes.
2692         * dwarf2-frame.c: Fix common/ includes.
2693         * dwarf-index-cache.c: Fix common/ includes.
2694         * dtrace-probe.c: Fix common/ includes.
2695         * disasm-selftests.c: Fix common/ includes.
2696         * defs.h: Fix common/ includes.
2697         * csky-tdep.c: Fix common/ includes.
2698         * cp-valprint.c: Fix common/ includes.
2699         * cp-support.h: Fix common/ includes.
2700         * cp-support.c: Fix common/ includes.
2701         * corelow.c: Fix common/ includes.
2702         * completer.h: Fix common/ includes.
2703         * completer.c: Fix common/ includes.
2704         * compile/compile.c: Fix common/ includes.
2705         * compile/compile-loc2c.c: Fix common/ includes.
2706         * compile/compile-cplus-types.c: Fix common/ includes.
2707         * compile/compile-cplus-symbols.c: Fix common/ includes.
2708         * command.h: Fix common/ includes.
2709         * cli/cli-dump.c: Fix common/ includes.
2710         * cli/cli-cmds.c: Fix common/ includes.
2711         * charset.c: Fix common/ includes.
2712         * build-id.c: Fix common/ includes.
2713         * btrace.h: Fix common/ includes.
2714         * btrace.c: Fix common/ includes.
2715         * breakpoint.h: Fix common/ includes.
2716         * breakpoint.c: Fix common/ includes.
2717         * ax.h:
2718         (enum agent_op): Fix common/ includes.
2719         * ax-general.c (struct aop_map): Fix common/ includes.
2720         * ax-gdb.c: Fix common/ includes.
2721         * auxv.c: Fix common/ includes.
2722         * auto-load.c: Fix common/ includes.
2723         * arm-tdep.c: Fix common/ includes.
2724         * arch/riscv.c: Fix common/ includes.
2725         * arch/ppc-linux-common.c: Fix common/ includes.
2726         * arch/i386.c: Fix common/ includes.
2727         * arch/arm.c: Fix common/ includes.
2728         * arch/arm-linux.c: Fix common/ includes.
2729         * arch/arm-get-next-pcs.c: Fix common/ includes.
2730         * arch/amd64.c: Fix common/ includes.
2731         * arch/aarch64.c: Fix common/ includes.
2732         * arch/aarch64-insn.c: Fix common/ includes.
2733         * arch-utils.c: Fix common/ includes.
2734         * amd64-windows-tdep.c: Fix common/ includes.
2735         * amd64-tdep.c: Fix common/ includes.
2736         * amd64-sol2-tdep.c: Fix common/ includes.
2737         * amd64-obsd-tdep.c: Fix common/ includes.
2738         * amd64-nbsd-tdep.c: Fix common/ includes.
2739         * amd64-linux-tdep.c: Fix common/ includes.
2740         * amd64-linux-nat.c: Fix common/ includes.
2741         * amd64-fbsd-tdep.c: Fix common/ includes.
2742         * amd64-fbsd-nat.c: Fix common/ includes.
2743         * amd64-dicos-tdep.c: Fix common/ includes.
2744         * amd64-darwin-tdep.c: Fix common/ includes.
2745         * agent.c: Fix common/ includes.
2746         * ada-lang.h: Fix common/ includes.
2747         * ada-lang.c: Fix common/ includes.
2748         * aarch64-tdep.c: Fix common/ includes.
2749
2750 2019-01-25  Tom Tromey  <tom@tromey.com>
2751
2752         * common/create-version.sh: Use common/version.h.
2753
2754 2019-01-24  Pedro Alves  <palves@redhat.com>
2755
2756         * infrun.c (signal_stop, signal_print, signal_program)
2757         (signal_catch, signal_pass): Now arrays instead of pointers.
2758         (update_signals_program_target, do_target_resume)
2759         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2760         * linux-nat.c (linux_nat_target::pass_signals)
2761         (linux_nat_target::create_inferior, linux_nat_target::attach):
2762         Adjust.
2763         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2764         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2765         * procfs.c (procfs_target::pass_signals): Adjust.
2766         * record-full.c (record_full_target::resume): Adjust.
2767         * remote.c (remote_target::pass_signals)
2768         (remote_target::program_signals): Adjust.
2769         * target-debug.h (target_debug_print_signals): Now takes a
2770         gdb::array_view as parameter.  Adjust.
2771         * target.h (target_ops) <pass_signals, program_signals>: Replace
2772         pointer and length parameters with gdb::array_view.
2773         (target_pass_signals, target_program_signals): Likewise.
2774         * target-delegates.c: Regenerate.
2775
2776 2019-01-24  Pedro Alves  <palves@redhat.com>
2777
2778         * common/forward-scope-exit.h
2779         (forward_scope_exit::forward_scope_exit): Pass arguments to
2780         m_bind_function directly, instead of creating a std::bind and
2781         copying that.
2782
2783 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2784
2785         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2786         for static members.
2787         (pass_in_v_vfp_candidate): Likewise.
2788
2789 2019-01-23  Tom Tromey  <tom@tromey.com>
2790             Pedro Alves  <palves@redhat.com>
2791
2792         * regcache.c (class regcache_invalidator): Remove.
2793         (regcache::raw_write): Use make_scope_exit.
2794
2795 2019-01-23  Tom Tromey  <tom@tromey.com>
2796
2797         * ui-out.h (class ui_out_emit_type): Update comment.
2798
2799 2019-01-23  Tom Tromey  <tom@tromey.com>
2800
2801         * infrun.c (fetch_inferior_event): Update comment.
2802
2803 2019-01-23  Tom Tromey  <tom@tromey.com>
2804             Pedro Alves  <palves@redhat.com>
2805
2806         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2807         parameter.
2808         (fetch_inferior_event): Use SCOPE_EXIT.
2809
2810
2811 2019-01-23  Tom Tromey  <tom@tromey.com>
2812             Pedro Alves  <palves@redhat.com>
2813
2814         * infrun.c (disable_thread_events): Delete.
2815         (stop_all_threads): Use SCOPE_EXIT.
2816
2817 2019-01-23  Tom Tromey  <tom@tromey.com>
2818             Pedro Alves  <palves@redhat.com>
2819
2820         * symfile.c: Include forward-scope-exit.h.
2821         (clear_symtab_users_cleanup): Replace forward declaration with
2822         a FORWARD_SCOPE_EXIT.
2823         (syms_from_objfile_1): Use the forward_scope_exit and
2824         gdb::optional instead of cleanup_function.
2825         (reread_symbols): Use the forward_scope_exit instead of
2826         cleanup_function.
2827         (clear_symtab_users_cleanup): Remove function.
2828
2829 2019-01-23  Tom Tromey  <tom@tromey.com>
2830             Pedro Alves  <palves@redhat.com>
2831
2832         * linux-nat.c: Include scope-exit.h.
2833         (cleanup_target_stop): Remove.
2834         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2835         SCOPE_EXIT.
2836
2837 2019-01-23  Tom Tromey  <tom@tromey.com>
2838             Pedro Alves  <palves@redhat.com>
2839
2840         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2841         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2842
2843 2019-01-23  Tom Tromey  <tom@tromey.com>
2844             Andrew Burgess  <andrew.burgess@embecosm.com>
2845             Pedro Alves  <palves@redhat.com>
2846
2847         * infrun.c (fetch_inferior_event): Use scope_exit.
2848         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2849         * top.c (execute_command): Use scope_exit.
2850         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2851         * utils.c (do_bpstat_clear_actions_cleanup)
2852         (make_bpstat_clear_actions_cleanup): Remove.
2853
2854 2019-01-23  Tom Tromey  <tom@tromey.com>
2855             Pedro Alves  <palves@redhat.com>
2856
2857         * infrun.c: Include "common/scope-exit.h"
2858         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2859         (wait_for_inferior): Use SCOPE_EXIT.
2860         (fetch_inferior_event): Use scope_exit.
2861
2862 2019-01-23  Tom Tromey  <tom@tromey.com>
2863             Pedro Alves  <palves@redhat.com>
2864
2865         * breakpoint.c (create_breakpoint): Remove cleanup.
2866
2867 2019-01-23  Tom Tromey  <tom@tromey.com>
2868             Andrew Burgess  <andrew.burgess@embecosm.com>
2869             Pedro Alves  <palves@redhat.com>
2870
2871 2019-01-23  Pedro Alves  <palves@redhat.com>
2872
2873         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2874
2875 2019-01-23  Pedro Alves  <palves@redhat.com>
2876             Andrew Burgess  <andrew.burgess@embecosm.com>
2877
2878         * gdbthread.h: Include "common/forward-scope-exit.h".
2879         (scoped_finish_thread_state): Redefine custom class in terms of
2880         forward_scope_exit.
2881
2882 2019-01-23  Pedro Alves  <palves@redhat.com>
2883             Andrew Burgess  <andrew.burgess@embecosm.com>
2884
2885         * common/forward-scope-exit.h: New file.
2886
2887 2019-01-23  Pedro Alves  <palves@redhat.com>
2888             Andrew Burgess  <andrew.burgess@embecosm.com>
2889             Tom Tromey  <tom@tromey.com>
2890
2891         * common/scope-exit.h: New file.
2892
2893 2019-01-23  Pedro Alves  <palves@redhat.com>
2894
2895         * common/preprocessor.h (ESC): Rename to ...
2896         (ESC_PARENS): ... this.
2897         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2898         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2899
2900 2019-01-23  Tom Tromey  <tom@tromey.com>
2901
2902         * language.h (class scoped_switch_to_sym_language_if_auto):
2903         Initialize m_lang in both cases.
2904
2905 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2906
2907         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2908         with XCNEW.
2909
2910 2019-01-22  Tom Tromey  <tom@tromey.com>
2911
2912         * corelow.c: Do not include sys/file.h.
2913
2914 2019-01-22  Tom Tromey  <tom@tromey.com>
2915
2916         * tui/tui-wingeneral.h: Include gdb_curses.h.
2917
2918 2019-01-22  Tom Tromey  <tom@tromey.com>
2919
2920         * source-cache.h (class source_cache) <get_source_lines,
2921         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2922
2923 2019-01-22  Tom Tromey  <tom@tromey.com>
2924
2925         * remote-fileio.h (struct remote_target): Declare.
2926
2927 2019-01-22  Tom Tromey  <tom@tromey.com>
2928
2929         * python/py-arch.c: Do not include py-ref.h.
2930         * python/py-bpevent.c: Do not include py-ref.h.
2931         * python/py-cmd.c: Do not include py-ref.h.
2932         * python/py-continueevent.c: Do not include py-ref.h.
2933         * python/py-event.h: Do not include py-ref.h.
2934         * python/py-evtregistry.c: Do not include py-ref.h.
2935         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2936         * python/py-frame.c: Do not include py-ref.h.
2937         * python/py-framefilter.c: Do not include py-ref.h.
2938         * python/py-function.c: Do not include py-ref.h.
2939         * python/py-infevents.c: Do not include py-ref.h.
2940         * python/py-linetable.c: Do not include py-ref.h.
2941         * python/py-objfile.c: Do not include py-ref.h.
2942         * python/py-param.c: Do not include py-ref.h.
2943         * python/py-prettyprint.c: Do not include py-ref.h.
2944         * python/py-progspace.c: Do not include py-ref.h.
2945         * python/py-symbol.c: Do not include py-ref.h.
2946         * python/py-symtab.c: Do not include py-ref.h.
2947         * python/py-type.c: Do not include py-ref.h.
2948         * python/py-unwind.c: Do not include py-ref.h.
2949         * python/py-utils.c: Do not include py-ref.h.
2950         * python/py-value.c: Do not include py-ref.h.
2951         * python/py-varobj.c: Do not include py-ref.h.
2952         * python/py-xmethods.c: Do not include py-ref.h.
2953         * python/python.c: Do not include py-ref.h.
2954         * varobj.c: Do not include py-ref.h.
2955
2956 2019-01-22  Tom Tromey  <tom@tromey.com>
2957
2958         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2959         keyword for bcache.
2960
2961 2019-01-22  Tom Tromey  <tom@tromey.com>
2962
2963         * compile/compile-cplus-types.c: Remove a comment by #include.
2964
2965 2019-01-22  Tom Tromey  <tom@tromey.com>
2966
2967         * compile/gcc-c-plugin.h: Include compile-internal.h.
2968
2969 2019-01-22  Tom Tromey  <tom@tromey.com>
2970
2971         * stabsread.c (EXTERN): Do not define.
2972         (symnum, next_symbol_text_func, processing_gcc_compilation)
2973         (within_function, global_sym_chain, global_stabs)
2974         (previous_stab_code, this_object_header_files)
2975         (n_this_object_header_files)
2976         (n_allocated_this_object_header_files): Define.
2977         * stabsread.h (EXTERN): Never define.  Use "extern".
2978
2979 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2980
2981         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2982         history_value.
2983
2984 2019-01-21  Tom Tromey  <tom@tromey.com>
2985
2986         * ui-out.c: Fix includes.
2987         * tui/tui-source.c: Fix includes.
2988         * target.c: Fix includes.
2989         * remote.c: Fix includes.
2990         * regcache.c: Fix includes.
2991         * python/py-block.c: Fix includes.
2992         * printcmd.c: Fix includes.
2993         * or1k-tdep.c: Fix includes.
2994         * mi/mi-main.c: Fix includes.
2995         * m32r-tdep.c: Fix includes.
2996         * csky-tdep.c: Fix includes.
2997         * compile/compile-cplus-types.c: Fix includes.
2998         * cli/cli-interp.c: Fix includes.
2999
3000 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3001
3002         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3003         for padding.
3004
3005 2019-01-16  Tom Tromey  <tom@tromey.com>
3006
3007         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3008         earlier.
3009         (struct objfile) <msymbols_range>: Move from top level.
3010         <msymbols>: New method.
3011         (class objfile_msymbols): Remove.
3012         * symtab.c (default_collect_symbol_completion_matches_break_on):
3013         Update.
3014         * symmisc.c (dump_msymbols): Update.
3015         * stabsread.c (scan_file_globals): Update.
3016         * objc-lang.c (info_selectors_command, info_classes_command)
3017         (find_methods): Update.
3018         * minsyms.c (find_solib_trampoline_target): Update.
3019         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3020         * coffread.c (coff_symfile_read): Update.
3021         * ada-lang.c (ada_lookup_simple_minsym)
3022         (ada_collect_symbol_completion_matches): Update.
3023
3024 2019-01-16  Tom Tromey  <tom@tromey.com>
3025
3026         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3027         type.  Remove no-argument constructor.
3028         <iterator::operator++>: Simplify.
3029         <begin>: Update.
3030         <end>: Use minimal_symbol_count.
3031
3032 2019-01-16  Tom Tromey  <tom@tromey.com>
3033
3034         * objfiles.h (struct objfile) <psymtabs>: New method.
3035         (class objfile_psymtabs): Remove.
3036         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3037         typedef.
3038         <range>: New method.
3039         (require_partial_symbols): Change return type.
3040         * psymtab.c (require_partial_symbols)
3041         (psym_expand_symtabs_matching): Update.
3042         * mdebugread.c (parse_partial_symbols): Update.
3043         * dbxread.c (dbx_end_psymtab): Update.
3044
3045 2019-01-15  Tom Tromey  <tom@tromey.com>
3046
3047         * symtab.c (lookup_objfile_from_block)
3048         (lookup_symbol_in_objfile_symtabs)
3049         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3050         (find_line_symtab, info_sources_command)
3051         (default_collect_symbol_completion_matches_break_on)
3052         (make_source_files_completion_list): Update.
3053         * symmisc.c (print_objfile_statistics, dump_objfile)
3054         (maintenance_print_symbols, maintenance_info_symtabs)
3055         (maintenance_check_symtabs, maintenance_info_line_tables):
3056         Update.
3057         * source.c (select_source_symtab)
3058         (forget_cached_source_info_for_objfile): Update.
3059         * objfiles.h (class objfile_compunits): Remove.
3060         (struct objfile) <compunits_range>: New typedef.
3061         (compunits): New method.
3062         * objfiles.c (objfile_relocate1): Update.
3063         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3064         * maint.c (count_symtabs_and_blocks): Update.
3065         * linespec.c (iterate_over_all_matching_symtabs): Update.
3066         * cp-support.c (add_symbol_overload_list_qualified): Update.
3067         * coffread.c (coff_symtab_read): Update.
3068         * ada-lang.c (add_nonlocal_symbols)
3069         (ada_collect_symbol_completion_matches)
3070         (ada_add_global_exceptions): Update.
3071
3072 2019-01-15  Tom Tromey  <tom@tromey.com>
3073
3074         * progspace.h (program_space) <objfiles_safe_range>: New
3075         typedef.
3076         <objfiles_safe>: New method.
3077         * objfiles.h (class all_objfiles_safe): Remove.
3078         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3079         * jit.c (jit_inferior_exit_hook): Update.
3080
3081 2019-01-17  Tom Tromey  <tom@tromey.com>
3082
3083         * progspace.h (program_space) <objfiles_range>: New typedef.
3084         <objfiles>: New method.
3085         <objfiles_head>: Rename from objfiles.
3086         (object_files): Update.
3087         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3088         * guile/scm-pretty-print.c
3089         (ppscm_find_pretty_printer_from_objfiles): Update.
3090         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3091         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3092         Update.
3093         * python/py-progspace.c (pspy_get_objfiles): Update.
3094         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3095         Update.
3096         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3097         (objfpy_lookup_objfile_by_build_id): Update.
3098         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3099         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3100         Update.
3101         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3102         (expand_symtab_containing_pc, lookup_objfile_from_block)
3103         (lookup_static_symbol, basic_lookup_transparent_type)
3104         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3105         (find_line_symtab, info_sources_command)
3106         (default_collect_symbol_completion_matches_break_on)
3107         (make_source_files_completion_list, find_main_name): Update.
3108         * symmisc.c (print_symbol_bcache_statistics)
3109         (print_objfile_statistics, maintenance_print_symbols)
3110         (maintenance_print_msymbols, maintenance_print_objfiles)
3111         (maintenance_info_symtabs, maintenance_check_symtabs)
3112         (maintenance_expand_symtabs, maintenance_info_line_tables):
3113         Update.
3114         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3115         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3116         (map_overlay_command, unmap_overlay_command)
3117         (simple_overlay_update, expand_symtabs_matching)
3118         (map_symbol_filenames): Update.
3119         * symfile-debug.c (set_debug_symfile): Update.
3120         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3121         Update.
3122         * source.c (select_source_symtab, forget_cached_source_info):
3123         Update.
3124         * solib.c (solib_read_symbols): Update.
3125         * solib-spu.c (append_ocl_sos): Update.
3126         * psymtab.c (maintenance_print_psymbols)
3127         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3128         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3129         * printcmd.c (info_symbol_command): Update.
3130         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3131         Update.
3132         * objfiles.h (class all_objfiles): Remove.
3133         * objfiles.c (have_partial_symbols, have_full_symbols)
3134         (have_minimal_symbols, qsort_cmp, update_section_map)
3135         (shared_objfile_contains_address_p)
3136         (default_iterate_over_objfiles_in_search_order): Update.
3137         * objc-lang.c (info_selectors_command, info_classes_command)
3138         (find_methods): Update.
3139         * minsyms.c (find_solib_trampoline_target): Update.
3140         * maint.c (maintenance_info_sections)
3141         (maintenance_translate_address, count_symtabs_and_blocks):
3142         Update.
3143         * main.c (captured_main_1): Update.
3144         * linux-thread-db.c (try_thread_db_load_from_pdir)
3145         (has_libpthread): Update.
3146         * linespec.c (iterate_over_all_matching_symtabs)
3147         (search_minsyms_for_name): Update.
3148         * jit.c (jit_find_objf_with_entry_addr): Update.
3149         * hppa-tdep.c (find_unwind_entry)
3150         (hppa_lookup_stub_minimal_symbol): Update.
3151         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3152         Update.
3153         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3154         (elf_gnu_ifunc_resolve_by_got): Update.
3155         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3156         * dwarf-index-write.c (save_gdb_index_command): Update.
3157         * cp-support.c (add_symbol_overload_list_qualified): Update.
3158         * breakpoint.c (create_overlay_event_breakpoint)
3159         (create_longjmp_master_breakpoint)
3160         (create_std_terminate_master_breakpoint)
3161         (create_exception_master_breakpoint): Update.
3162         * blockframe.c (find_pc_partial_function): Update.
3163         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3164         (ada_collect_symbol_completion_matches)
3165         (ada_add_global_exceptions): Update.
3166
3167 2019-01-17  Tom Tromey  <tom@tromey.com>
3168
3169         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3170         declare VEC.
3171         (solib_target_parse_libraries): Change return type.
3172         (library_list_start_segment, library_list_start_section)
3173         (library_list_end_library, library_list_start_library); Update.
3174         (solib_target_free_library_list): Remove.
3175         (solib_target_parse_libraries): Remove cleanup.  Change return
3176         type.
3177         (solib_target_current_sos): Update.
3178
3179 2019-01-17  Tom Tromey  <tromey@bapiya>
3180
3181         * valprint.c: Replace "the the" with "the".
3182         * symtab.c: Replace "the the" with "the".
3183         * solib.c: Replace "the the" with "the".
3184         * solib-dsbt.c: Replace "the the" with "the".
3185         * linespec.c: Replace "the the" with "the".
3186         * dwarf2loc.h: Replace "the the" with "the".
3187         * amd64-windows-tdep.c: Replace "the the" with "the".
3188         * aarch64-tdep.c: Replace "the the" with "the".
3189
3190 2019-01-16  Keith Seitz  <keiths@redhat.com>
3191
3192         PR gdb/23773
3193         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3194         <builder>: Rename to ..
3195         <m_builder>: ... this and make private.
3196         (dwarf2_cu::get_builder): New method.  Change all users of
3197         `builder' to use this method.
3198         (dwarf2_start_symtab): Move to ...
3199         (dwarf2_cu::start_symtab): ... here.  Update all callers
3200         (setup_type_unit_groups): Move to ...
3201         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3202         callers.
3203         (dwarf2_cu::reset_builder): New method.
3204         (process_full_compunit, process_full_type_unit): Use
3205         dwarf2_cu::reset_builder.
3206         (follow_die_offset): Record the ancestor CU if it is different
3207         from the followed DIE's CU.
3208         (follow_die_sig_1): Likewise.
3209
3210 2019-01-15  Tom Tromey  <tom@tromey.com>
3211
3212         * remote.c (class remote_state) <buf>: Now a char_vector.
3213         <buf_size>: Remove.
3214         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3215         parameter.
3216         (remote_target::getpkt_or_notif_sane_1)
3217         (remote_target::getpkt_sane)
3218         (remote_target::getpkt_or_notif_sane): Likewise.
3219         (class remote_target) <putpkt>: New overload.
3220         (remote_target::read_frame): Change type of "buf_p".  Remove
3221         sizeof_p parameter.
3222         (packet_ok): New overload.
3223         (packet_check_result): New overload.
3224         Update all uses.
3225
3226 2019-01-14  Tom Tromey  <tom@tromey.com>
3227
3228         * remote-notif.c (handle_notification, remote_notif_ack)
3229         (remote_notif_parse): Make "buf" const.
3230         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3231         const.
3232         (remote_notif_parse, remote_notif_ack, handle_notification):
3233         Likewise.
3234         * remote.c (remote_notif_stop_parse): Make "buf" const.
3235         (remote_target::remote_parse_stop_reply): Make "buf" const.
3236         (remote_notif_stop_ack): Make "buf" const.
3237
3238 2019-01-14  Tom Tromey  <tom@tromey.com>
3239
3240         * remote.c (remote_console_output): Make parameter const.
3241
3242 2019-01-14  Tom Tromey  <tom@tromey.com>
3243
3244         * target-debug.h (target_debug_print_signals): Constify.
3245         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3246         * procfs.c (procfs_target::pass_signals): Update.
3247         * linux-nat.c (linux_nat_target::pass_signals): Update.
3248         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3249         * target-delegates.c: Rebuild.
3250         * remote.c (remote_target::program_signals): Update.
3251         (remote_target::pass_signals): Update.
3252         * target.c (target_pass_signals): Constify argument.
3253         (target_program_signals): Likewise.
3254         * target.h (struct target_ops) <pass_signals, program_signals>:
3255         Constify argument.
3256         (target_pass_signals, target_program_signals): Constify argument.
3257
3258 2019-01-14  Tom Tromey  <tom@tromey.com>
3259
3260         PR tui/28819:
3261         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3262
3263 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3264
3265         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3266         field.
3267         * rs6000-tdep.c: Include reggroups.h.
3268         (IS_V_ALIAS_PSEUDOREG): Define.
3269         (rs6000_register_name): Return names for the "vX" aliases.
3270         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3271         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3272         aliases.  Call default_register_reggroup_p for all other
3273         pseudo-registers.
3274         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3275         New functions.
3276         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3277         Handle "vX" aliases.
3278         (v_alias_pseudo_register_collect): New function.
3279         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3280         (rs6000_gdbarch_init): Initialize "vX" aliases as
3281         pseudo-registers.  Restore registration of
3282         rs6000_pseudo_register_reggroup_p with
3283         set_tdesc_pseudo_register_reggroup_p.
3284
3285 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3286
3287         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3288         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3289         set_gdbarch_num_pseudo_regs.
3290
3291 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3292
3293         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3294         Remove arg prefixname, add do_set and do_show.
3295         Add member functions set_list and show_list.
3296         * cli/cli-style.c (class cli_style_option): Update accordingly.
3297         (style_set_list): Move to file scope.
3298         (style_show_list): Likewise.
3299         (set_style): Call help_list.
3300         (show_style): Call cmd_show_list.
3301         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3302         Update to use the new macro.
3303
3304 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3305
3306         * ada-lang.c (_initialize_ada_language): Expand the help text
3307         for the "catch exception" command.
3308
3309 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3310
3311         * symtab.c (matching_obj_sections): Initialize obj,
3312         declare it closer to its usage.
3313
3314 2019-01-10  Tom Tromey  <tom@tromey.com>
3315
3316         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3317         (basic_inf_threads_range): Remove.
3318         (inf_threads_range, inf_non_exited_threads_range)
3319         (safe_inf_threads_range): Use next_adapter.
3320
3321 2019-01-10  Keith Seitz  <keiths@redhat.com>
3322
3323         PR gdb/23712
3324         PR symtab/23010
3325         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3326         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3327
3328 2019-01-10  Keith Seitz  <keiths@redhat.com>
3329
3330         PR gdb/23712
3331         PR symtab/23010
3332         * dictionary.c (pending_to_vector): Remove.
3333         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3334         Remove _1 suffix, replacing functions of the same name.  Update
3335         all callers.
3336         (dict_create_hashed, dict_create_hashed_expandable)
3337         (dict_create_linear, dict_create_linear_expandable, dict_free)
3338         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3339         Make functions static.
3340
3341 2019-01-10  Keith Seitz  <keiths@redhat.com>
3342
3343         PR gdb/23712
3344         PR symtab/23010
3345         * dictionary.h (struct dictionary): Replace declaration with
3346         multidictionary.
3347         (dict_create_hashed, dict_create_hashed_expandable)
3348         (dict_create_linear, dict_create_linear_expandable)
3349         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3350         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3351         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3352         taking multidictionary argument.
3353         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3354         * block.h (struct block) <dict>: Change to multidictionary
3355         and rename `multidict'.
3356         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3357         symmisc.c: Update all dictionary references to multidictionary.
3358
3359 2019-01-10  Keith Seitz  <keiths@redhat.com>
3360
3361         PR gdb/23712
3362         PR symtab/23010
3363         * dictionary.c: Include unordered_map.
3364         (pending_to_vector): New function.
3365         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3366         Rewrite the non-"_1" functions to take vector instead
3367         of linked list.
3368         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3369         "new" _1 versions of the same name.
3370         (multidictionary): Define.
3371         (std::hash<enum language): New definition.
3372         (collate_pending_symbols_by_language, mdict_create_hashed)
3373         (mdict_create_hashed_expandable, mdict_create_linear)
3374         (mdict_create_linear_expandable, mdict_free)
3375         (find_language_dictionary, create_new_language_dictionary)
3376         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3377         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3378         (mdict_size, mdict_empty): New functions.
3379         * dictionary.h (mdict_iterator): Define.
3380
3381 2019-01-10  Pedro Alves  <palves@redhat.com>
3382
3383         * breakpoint.c (read_uploaded_action)
3384         (create_tracepoint_from_upload): Adjust to use
3385         gdb::unique_xmalloc_ptr.
3386         * ctf.c (ctf_write_uploaded_tp):
3387         (SET_ARRAY_FIELD): Use emplace_back.
3388         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3389         * tracefile-tfile.c (tfile_write_uploaded_tp):
3390         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3391         gdb::unique_xmalloc_ptr.
3392         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3393         at_string, cond_string, cmd_strings>: Replace char pointers
3394         with gdb::unique_xmalloc_ptr.
3395
3396 2019-01-10  Pedro Alves  <palves@redhat.com>
3397
3398         * solib-target.c (library_list_start_library): Don't xstrdup name.
3399
3400 2019-01-10  Pedro Alves  <palves@redhat.com>
3401
3402         * mdebugread.c (parse_partial_symbols): Use
3403         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3404
3405 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3406
3407         * linux-fork.c (scoped_switch_fork_info)
3408         <~scoped_switch_fork_info>: Fix incorrect variable name.
3409
3410 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3411
3412         * linux-fork.c (scoped_switch_fork_info)
3413         <scoped_switch_fork_info>: Make explicit.
3414         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3415
3416 2019-01-10  Tom Tromey  <tom@tromey.com>
3417
3418         * objfiles.h (objfile::reset_psymtabs): Update.
3419         * objfiles.c (objfile::objfile): Update.
3420         * psymtab.h (psymtab_storage::obstack): Update.
3421         (psymtab_storage::m_obstack): Use gdb::optional.
3422         (class psymtab_storage): Update comment.  Remove objfile
3423         parameter.
3424         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3425
3426 2019-01-10  Tom Tromey  <tom@tromey.com>
3427
3428         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3429         <free_psymtabs>: Now private.
3430         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3431         (allocate_psymtab): Use new method.
3432
3433 2019-01-10  Tom Tromey  <tom@tromey.com>
3434
3435         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3436         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3437         * mdebugread.c (parse_partial_symbols): Use
3438         allocate_dependencies.
3439         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3440         allocate_dependencies.
3441         (process_psymtab_comp_unit_reader)
3442         (build_type_psymtab_dependencies): Likewise.
3443         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3444
3445 2019-01-10  Tom Tromey  <tom@tromey.com>
3446
3447         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3448         PSYMBOL_SET_LANGUAGE.
3449         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3450
3451 2019-01-10  Tom Tromey  <tom@tromey.com>
3452
3453         * psymtab.h (psymtab_storage::obstack): New method.
3454         <m_obstack>: Rename from obstack; now private.
3455         * psymtab.c (psymtab_storage): Update.
3456         * dwarf2read.c (create_addrmap_from_index)
3457         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3458         Update.
3459
3460 2019-01-10  Tom Tromey  <tom@tromey.com>
3461
3462         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3463         * objfiles.h (objfile::reset_psymtabs): New method.
3464
3465 2019-01-10  Tom Tromey  <tom@tromey.com>
3466
3467         * symmisc.c (print_symbol_bcache_statistics): Update.
3468         (print_objfile_statistics): Update.
3469         * symfile.c (reread_symbols): Update.
3470         * psymtab.h (class psymtab_storage): New.
3471         * psymtab.c (psymtab_storage): New constructor.
3472         (~psymtab_storage): New destructor.
3473         (require_partial_symbols): Update.
3474         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3475         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3476         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3477         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3478         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3479         (start_psymtab_common, end_psymtab_common)
3480         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3481         (allocate_psymtab): Update.
3482         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3483         Update.
3484         (dump_psymtab_addrmap, maintenance_print_psymbols)
3485         (maintenance_check_psymtabs): Update.
3486         (class objfile_psymtabs): Move to objfiles.h.
3487         * psympriv.h (discard_psymtab): Now inline.
3488         (psymtab_discarder::psymtab_discarder): Update.
3489         (psymtab_discarder::~psymtab_discarder): Update.
3490         (ALL_OBJFILE_PSYMTABS): Rewrite.
3491         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3492         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3493         Remove fields.
3494         <partial_symtabs>: New field.
3495         (class objfile_psymtabs): Move from psymtab.h.  Update.
3496         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3497         psymbol_cache.
3498         (objfile::~objfile): Don't destroy psymbol_cache.
3499         * mdebugread.c (parse_partial_symbols): Update.
3500         * dwarf2read.c (create_addrmap_from_index)
3501         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3502         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3503         (add_partial_subprogram, dwarf2_ranges_read): Update.
3504         * dwarf-index-write.c (write_address_map)
3505         (write_one_signatured_type, recursively_write_psymbols)
3506         (class debug_names, class debug_names, write_psymtabs_to_index):
3507         Update.
3508
3509 2019-01-10  Tom Tromey  <tom@tromey.com>
3510
3511         * symtab.h (SYMBOL_SET_NAMES): Update.
3512         (symbol_set_names): Update.
3513         (MSYMBOL_SET_NAMES): Update.
3514         * symtab.c (symbol_set_names): Change argument to be an
3515         objfile_per_bfd_storage.
3516         * psymtab.c (add_psymbol_to_bcache): Update.
3517         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3518
3519 2019-01-10  Tom Tromey  <tom@tromey.com>
3520
3521         * symtab.c (create_demangled_names_hash): Change argument to be an
3522         objfile_per_bfd_storage.
3523         (symbol_set_names): Update.
3524
3525 2019-01-10  Tom Tromey  <tom@tromey.com>
3526
3527         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3528         init_psymbol_list.
3529         * psymtab.c (init_psymbol_list): Do nothing if already called.
3530         * psympriv.h (init_psymbol_list): Add comment.
3531         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3532         init_psymbol_list.
3533         * dbxread.c (dbx_symfile_read): Unconditionally call
3534         init_psymbol_list.
3535
3536 2019-01-10  Tom Tromey  <tom@tromey.com>
3537
3538         * xcoffread.c (scan_xcoff_symtab): Update.
3539         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3540         "where".
3541         * mdebugread.c (parse_partial_symbols)
3542         (handle_psymbol_enumerators): Update.
3543         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3544         * dbxread.c (read_dbx_symtab): Update.
3545         * psympriv.h (psymbol_placement): New enum.
3546         (add_psymbol_to_list): Update.
3547
3548 2019-01-10  Tom Tromey  <tom@tromey.com>
3549
3550         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3551         static_psymbols parameters.
3552         (scan_xcoff_symtab): Update.
3553         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3554         static_psymbols parameters.
3555         * psympriv.h (start_psymtab_common): Update.
3556         * mdebugread.c (parse_partial_symbols): Update.
3557         * dwarf2read.c (create_partial_symtab): Update.
3558         * dbxread.c (read_dbx_symtab): Update.
3559         (start_psymtab): Remove global_psymbols and static_psymbols
3560         parameters.
3561
3562 2019-01-10  Tom Tromey  <tom@tromey.com>
3563
3564         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3565         * psymtab.c (allocate_psymtab): Add comment.
3566         * psympriv.h (allocate_psymtab): Add comment.
3567         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3568         initializations.
3569         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3570
3571 2019-01-10  Tom Tromey  <tom@tromey.com>
3572
3573         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3574         Don't declare.
3575         * mipsread.c: Include mdebugread.h.
3576         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3577         Declare.
3578         * elfread.c: Include mdebugread.h.
3579
3580 2019-01-09  Tom Tromey  <tom@tromey.com>
3581
3582         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3583         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3584         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3585         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3586         (psym_lookup_symbol, psym_find_last_source_symtab)
3587         (psym_forget_cached_source_info, psym_print_stats)
3588         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3589         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3590         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3591         (psym_find_compunit_symtab_by_address)
3592         (maintenance_print_psymbols, maintenance_info_psymtabs)
3593         (maintenance_check_psymtabs): Use ranged for.
3594         * psymtab.h (class objfile_psymtabs): New.
3595         (require_partial_symbols): Return objfile_psymtabs.
3596         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3597
3598 2019-01-09  Tom Tromey  <tom@tromey.com>
3599
3600         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3601         (find_pc_mapped_section, list_overlays_command)
3602         (map_overlay_command, unmap_overlay_command)
3603         (simple_overlay_update): Use all_objfiles.
3604         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3605         * printcmd.c (info_symbol_command): Use all_objfiles.
3606         * objfiles.h (ALL_OBJSECTIONS): Remove.
3607         * maint.c (maintenance_translate_address): Use all_objfiles.
3608         * gcore.c (gcore_create_callback): Use all_objfiles.
3609         (objfile_find_memory_regions): Likewise.
3610
3611 2019-01-09  Tom Tromey  <tom@tromey.com>
3612
3613         * symtab.c (find_line_symtab, info_sources_command)
3614         (make_source_files_completion_list): Use objfile_compunits.
3615         * source.c (select_source_symtab): Use objfile_compunits.
3616         * objfiles.h (struct objfile): Update comment.
3617         (ALL_OBJFILES): Remove.
3618         (ALL_FILETABS): Remove.
3619         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3620         objfile_compunits.
3621
3622 2019-01-09  Tom Tromey  <tom@tromey.com>
3623
3624         * symmisc.c (print_objfile_statistics, dump_objfile)
3625         (maintenance_print_symbols): Use compunit_filetabs.
3626         * source.c (forget_cached_source_info_for_objfile): Use
3627         compunit_filetabs.
3628         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3629         (ALL_FILETABS): Use compunit_filetabs.
3630         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3631         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3632
3633 2019-01-09  Tom Tromey  <tom@tromey.com>
3634
3635         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3636         (compunit_filetabs): New.
3637         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3638         compunit_filetabs.
3639         (info_sources_command, make_source_files_completion_list): Remove
3640         declaration.
3641         * symmisc.c (print_objfile_statistics, dump_objfile)
3642         (maintenance_print_symbols): Remove declaration.
3643         (maintenance_info_symtabs): Use compunit_filetabs.
3644         (maintenance_info_line_tables): Likewise.
3645         * source.c (select_source_symtab): Change local variable name.
3646         (forget_cached_source_info_for_objfile): Remove declaration.
3647         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3648         * objfiles.c (objfile_relocate1): Remove declaration.
3649         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3650         declaration.
3651         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3652         * coffread.c (coff_symtab_read): Remove declaration.
3653         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3654         compunit_filetabs.
3655
3656 2019-01-09  Tom Tromey  <tom@tromey.com>
3657
3658         * symtab.c (lookup_objfile_from_block)
3659         (find_pc_sect_compunit_symtab, search_symbols)
3660         (default_collect_symbol_completion_matches_break_on): Use
3661         objfile_compunits.
3662         * objfiles.h (ALL_COMPUNITS): Remove.
3663         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3664         * cp-support.c (add_symbol_overload_list_qualified): Use
3665         objfile_compunits.
3666         * ada-lang.c (ada_collect_symbol_completion_matches)
3667         (ada_add_global_exceptions): Use objfile_compunits.
3668
3669 2019-01-09  Tom Tromey  <tom@tromey.com>
3670
3671         * source.c (select_source_symtab)
3672         (forget_cached_source_info_for_objfile): Remove declaration.
3673         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3674         declaration.
3675         * maint.c (count_symtabs_and_blocks): Remove declaration.
3676         * cp-support.c (add_symbol_overload_list_qualified): Remove
3677         declaration.
3678         * coffread.c (coff_symtab_read): Remove declaration.
3679         * symtab.c (lookup_symbol_in_objfile_symtabs)
3680         (basic_lookup_transparent_type_1): Use objfile_compunits.
3681         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3682         (info_sources_command, search_symbols)
3683         (default_collect_symbol_completion_matches_break_on)
3684         (make_source_files_completion_list): Remove declaration.
3685         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3686         (ada_collect_symbol_completion_matches)
3687         (ada_add_global_exceptions): Remove declaration.
3688         * linespec.c (iterate_over_all_matching_symtabs): Use
3689         objfile_compunits.
3690         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3691         (class objfile_compunits): New.
3692         (ALL_COMPUNITS): Use objfile_compunits.
3693         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3694         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3695         objfile_compunits.
3696         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3697
3698 2019-01-09  Tom Tromey  <tom@tromey.com>
3699
3700         * symtab.c (search_symbols)
3701         (default_collect_symbol_completion_matches_break_on): Use
3702         objfile_msymbols.
3703         * ada-lang.c (ada_lookup_simple_minsym)
3704         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3705         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3706         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3707         objfile_msymbols.
3708         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3709         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3710         * objc-lang.c (find_methods): Use objfile_msymbols.
3711         (info_selectors_command, info_classes_command): Likewise.
3712         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3713         * objfiles.h (class objfile_msymbols): New.
3714         (ALL_OBJFILE_MSYMBOLS): Remove.
3715         (ALL_MSYMBOLS): Remove.
3716
3717 2019-01-09  Tom Tromey  <tom@tromey.com>
3718
3719         * common/next-iterator.h (next_adapter): Add Iterator template
3720         parameter.
3721         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3722         (class all_objfiles_safe): New.
3723         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3724         * objfiles.c (put_objfile_before): Update comment.
3725         (add_separate_debug_objfile): Likewise.
3726         (free_all_objfiles): Use all_objfiles_safe.
3727         (objfile_purge_solibs): Likewise.
3728
3729 2019-01-09  Tom Tromey  <tom@tromey.com>
3730
3731         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3732         (expand_symtab_containing_pc, lookup_static_symbol)
3733         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3734         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3735         all_objfiles.
3736         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3737         * breakpoint.c (create_overlay_event_breakpoint)
3738         (create_longjmp_master_breakpoint)
3739         (create_std_terminate_master_breakpoint)
3740         (create_exception_master_breakpoint): Use all_objfiles.
3741         * linux-thread-db.c (try_thread_db_load_from_pdir)
3742         (has_libpthread): Use all_objfiles.
3743         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3744         * linespec.c (iterate_over_all_matching_symtabs)
3745         (search_minsyms_for_name): Use all_objfiles.
3746         * maint.c (maintenance_info_sections): Use all_objfiles.
3747         * main.c (captured_main_1): Use all_objfiles.
3748         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3749         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3750         * guile/scm-pretty-print.c
3751         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3752         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3753         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3754         (maintenance_print_msymbols): Use all_objfiles.
3755         * source.c (select_source_symtab): Use all_objfiles.
3756         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3757         * symfile.c (remove_symbol_file_command)
3758         (expand_symtabs_matching, map_symbol_filenames): Use
3759         all_objfiles.
3760         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3761         all_objfiles.
3762         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3763         * objc-lang.c (find_methods): Use all_objfiles.
3764         * objfiles.c (have_partial_symbols, have_full_symbols)
3765         (have_minimal_symbols, qsort_cmp)
3766         (default_iterate_over_objfiles_in_search_order): Use
3767         all_objfiles.
3768         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3769         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3770         (maintenance_check_psymtabs): Use all_objfiles.
3771         (ALL_PSYMTABS): Remove.
3772         * compile/compile-object-run.c (do_module_cleanup): Use
3773         all_objfiles.
3774         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3775         * cp-support.c (add_symbol_overload_list_qualified): Use
3776         all_objfiles.
3777         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3778         Use all_objfiles.
3779         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3780         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3781         all_objfiles.
3782         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3783         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3784         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3785         Uses all_objfiles.
3786         * solib.c (solib_read_symbols): Use all_objfiles
3787
3788 2019-01-09  Tom Tromey  <tom@tromey.com>
3789
3790         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3791         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3792         all_objfiles.
3793         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3794         * symmisc.c (print_symbol_bcache_statistics)
3795         (print_objfile_statistics, maintenance_print_objfiles)
3796         (maintenance_info_symtabs, maintenance_check_symtabs)
3797         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3798         all_objfiles.
3799         * source.c (forget_cached_source_info): Use all_objfiles.
3800         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3801         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3802         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3803         * objfiles.c (update_section_map): Use all_objfiles.
3804         (shared_objfile_contains_address_p): Likewise.
3805         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3806         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3807
3808 2019-01-09  Tom Tromey  <tom@tromey.com>
3809
3810         * common/next-iterator.h: New file.
3811         * objfiles.h (class all_objfiles): New.
3812         (struct objfile_iterator): New.
3813
3814 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3815
3816         * NEWS: Move the description of the changed "frame", "select-frame",
3817          and "info frame" commands to the Changed commands section.
3818
3819 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3820
3821         * gdbtypes.c (check_stub_method_group): Remove handling of old
3822         mangling schemes.
3823         * linespec.c (find_methods): Likewise.
3824         * stabsread.c (read_member_functions): Likewise.
3825         * valops.c (search_struct_method): Likewise.
3826         (value_struct_elt_for_reference): Likewise.
3827         * NEWS: Mention this change.
3828
3829 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3830
3831         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3832         print_source_lines.
3833         * source.c (print_source_lines_base): Update line number check.
3834         (print_source_lines): New function.
3835         (source_lines_range::source_lines_range): New function.
3836         * source.h (class source_lines_range): New class.
3837         (print_source_lines): New declaration.
3838
3839 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3840
3841         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3842
3843 2019-01-08  Tom Tromey  <tom@tromey.com>
3844             Simon Marchi  <simon.marchi@ericsson.com>
3845
3846         PR gdb/24060
3847         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3848         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3849         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3850         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3851         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3852         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3853
3854 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3855
3856         * source.c (select_source_symtab): Move header comment to
3857         declaration in source.h.
3858         (forget_cached_source_info_for_objfile): Likewise.
3859         (forget_cached_source_info): Likewise.
3860         (identify_source_line): Likewise.
3861         * source.h (identify_source_line): Move declaration from symtab.h
3862         and add comment from source.c
3863         (print_source_lines): Likewise.
3864         (forget_cached_source_info_for_objfile): Likewise.
3865         (forget_cached_source_info): Likewise.
3866         (select_source_symtab): Likewise.
3867         (enum print_source_lines_flag): Move definition from symtab.h.
3868         * symtab.h (identify_source_line): Move declaration to source.h.
3869         (print_source_lines): Likewise.
3870         (forget_cached_source_info_for_objfile): Likewise.
3871         (forget_cached_source_info): Likewise.
3872         (select_source_symtab): Likewise.
3873         (enum print_source_lines_flag): Move definition to source.h.
3874         * tui/tui-hooks.c: Add 'source.h' include.
3875
3876 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * source.c (print_source_lines_base): Handle requests to print
3879         reverse line number sequences, and guard against empty lines
3880         string.
3881
3882 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3883
3884         * source.c (print_source_lines_base): Fix skip of '\r' if next
3885         character is '\n'.
3886
3887 2019-01-06  Tom Tromey  <tom@tromey.com>
3888
3889         * c-exp.y (struct c_parse_state) <macro_original_text,
3890         expansion_obstack>: New member.
3891         (macro_original_text, expansion_obstack): Remove globals.
3892         (scan_macro_expansion, scanning_macro_expansion)
3893         (finished_macro_expansion): Update.
3894         (scan_macro_cleanup): Remove.
3895         (yylex, c_parse): Update.
3896
3897 2019-01-06  Tom Tromey  <tom@tromey.com>
3898
3899         * c-exp.y (struct c_parse_state) <strings>: New member.
3900         (operator_stoken): Update.
3901
3902 2019-01-06  Tom Tromey  <tom@tromey.com>
3903
3904         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3905         (union type_stack_elt) <typelist_val>: Now a pointer to
3906         std::vector.
3907         (type_stack_cleanup): Don't declare.
3908         (push_typelist): Update.
3909         * parse.c (pop_typelist): Return a std::vector.
3910         (push_typelist): Take a std::vector.
3911         (follow_types): Update.  Do not free args.
3912         (type_stack_cleanup): Remove.
3913         * c-exp.y (struct c_parse_state): New.
3914         (cpstate): New global.
3915         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3916         (nonempty_typelist): Update.
3917         (func_mod): Create a new vector.
3918         (c_parse): Create a c_parse_state.
3919         (check_parameter_typelist): Do not delete params.
3920         (function_method): Update.  Do not delete type_list.
3921
3922 2019-01-06  Tom Tromey  <tom@tromey.com>
3923
3924         PR gdb/28155:
3925         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3926         check_typedef.
3927         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3928         (print_return_value): Likewise.
3929
3930 2019-01-05  Tom Tromey  <tom@tromey.com>
3931
3932         * contrib/cleanup_check.py: Remove.
3933         * contrib/gcc-with-excheck: Remove.
3934         * contrib/exsummary.py: Remove.
3935         * contrib/excheck.py: Remove.
3936
3937 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3938
3939         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3940         NULL. Initialize tpprev to NULL instead of assigning it
3941         to NULL on the next statement.
3942         * windows-nat.c (windows_delete_thread): Remove check for
3943         main_thread_id before printing thread exit notifications.
3944         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3945         Remove thread ID check against main_thread_id.
3946         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3947         windows_delete_thread.
3948         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3949
3950 2019-01-04  Tom Tromey  <tom@tromey.com>
3951
3952         * compile/compile.c (_initialize_compile): Use upper case for
3953         metasyntactic variables.
3954         * symmisc.c (_initialize_symmisc): Use upper case for
3955         metasyntactic variables.
3956         * psymtab.c (_initialize_psymtab): Use upper case for
3957         metasyntactic variables.
3958         * demangle.c (demangle_command): Use upper case for metasyntactic
3959         variables.
3960         (_initialize_demangler): Likewise.
3961         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3962         variables.
3963
3964 2019-01-03  Tom Tromey  <tom@tromey.com>
3965
3966         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3967
3968 2019-01-03  Tom Tromey  <tom@tromey.com>
3969
3970         * python/py-symtab.c (salpy_str): Update.
3971         (struct salpy_sal_object) <symtab>: Now a PyObject.
3972         (salpy_dealloc): Update.
3973         (del_objfile_sal): Use gdbpy_ref.
3974
3975 2019-01-03  Tom Tromey  <tom@tromey.com>
3976
3977         * python/py-type.c (convert_field): Use new_reference.  Return
3978         gdbpy_ref.
3979         (make_fielditem): Return gdbpy_ref.
3980         (typy_fields): Update.
3981         (typy_getitem): Update.
3982         (field_name): Return gdbpy_ref.  Use new_reference.
3983         (typy_iterator_iternext): Update.
3984
3985 2019-01-03  Tom Tromey  <tom@tromey.com>
3986
3987         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3988
3989 2019-01-03  Tom Tromey  <tom@tromey.com>
3990
3991         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3992         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3993         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3994         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3995         (pspy_set_type_printers): Likewise.
3996         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3997         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3998         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3999         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4000         (objfpy_set_type_printers): Likewise.
4001
4002 2019-01-03  Tom Tromey  <tom@tromey.com>
4003
4004         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4005         (gdbpy_print_stack): Use gdbpy_err_fetch.
4006         * python/python-internal.h (class gdbpy_err_fetch): New class.
4007         (class gdbpy_enter) <m_error_type, m_error_value,
4008         m_error_traceback>: Remove.
4009         <m_error>: New member.
4010         (gdbpy_exception_to_string): Don't declare.
4011         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4012         * python/py-value.c (convert_value_from_python): Use
4013         gdbpy_err_fetch.
4014         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4015         gdbpy_exception_to_string.
4016         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4017         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4018         gdbpy_err_fetch.
4019
4020 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4021
4022         * linux-nat.c (delete_lwp_cleanup): Delete.
4023         (struct lwp_deleter): New struct.
4024         (lwp_info_up): New typedef.
4025         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4026         lwp_info_up.
4027
4028 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4029
4030         * linux-fork.c (class scoped_switch_fork_info): New class.
4031         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4032
4033 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4034
4035         * valops.c (find_overload_match): Remove use of null_cleanup, and
4036         calls to do_cleanups.
4037
4038 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4039
4040         * compile/compile-cplus-types.c
4041         (compile_cplus_instance::decl_name): Handle changes to
4042         cp_func_name.
4043         * cp-support.c (cp_func_name): Update header comment, update
4044         return type.
4045         * cp-support.h (cp_func_name): Update return type in declaration.
4046         * valops.c (find_overload_match): Move temp_func local to top
4047         level of function and change its type.  Use temp_func to hold and
4048         delete temporary string obtained from cp_func_name.
4049
4050 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4051
4052         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4053         gdb::char_vector, remove cleanup, and update uses of `msg`.
4054
4055 2019-01-03  Jim Wilson  <jimw@sifive.com>
4056
4057         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4058
4059 2019-01-02  Tom Tromey  <tom@tromey.com>
4060
4061         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4062         (tdesc_parse_xml): Remove cleanups.
4063         * target-descriptions.h (make_cleanup_free_target_description):
4064         Don't declare.
4065         (target_desc_deleter): New struct.
4066         (target_desc_up): New typedef.
4067         * target-descriptions.c (target_desc_deleter::operator()): Rename
4068         from free_target_description.
4069         (make_cleanup_free_target_description): Remove.
4070
4071 2019-01-02  Tom Tromey  <tom@tromey.com>
4072
4073         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4074         constructor, destructor.
4075         (linespec_parser): Remove typedef.
4076         (~linespec_parser): Rename from linespec_parser_delete.
4077         (linespec_lex_to_end, linespec_complete_label)
4078         (linespec_complete): Update.
4079         (decode_line_full): Remove cleanups.
4080         (decode_line_1): Update.
4081
4082 2019-01-02  Tom Tromey  <tom@tromey.com>
4083
4084         * python/python-internal.h (inferior_to_inferior_object): Change
4085         return type.
4086         * python/py-exitedevent.c (create_exited_event_object): Update.
4087         * python/py-inferior.c (inferior_to_inferior_object): Return
4088         gdbpy_ref.
4089         (python_new_inferior, python_inferior_deleted)
4090         (thread_to_thread_object, delete_thread_object)
4091         (build_inferior_list, gdbpy_selected_inferior): Update.
4092         * python/py-infthread.c (create_thread_object): Update.  Also fail
4093         if inferior_to_inferior_object fails.
4094
4095 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4096
4097         * inferior.h (class inferior) <displaced_step_state>: New field.
4098         * infrun.h (struct displaced_step_state): Move here from
4099         infrun.c.  Initialize fields, add constructor.
4100         <inf>: Remove field.
4101         <reset>: New method.
4102         * infrun.c (struct displaced_step_inferior_state): Move to
4103         infrun.h.
4104         (displaced_step_inferior_states): Remove.
4105         (get_displaced_stepping_state): Adust.
4106         (displaced_step_in_progress_any_inferior): Adjust.
4107         (displaced_step_in_progress_thread): Adjust.
4108         (displaced_step_in_progress): Adjust.
4109         (add_displaced_stepping_state): Remove.
4110         (get_displaced_step_closure_by_addr): Adjust.
4111         (remove_displaced_stepping_state): Remove.
4112         (infrun_inferior_exit): Call displaced_step_state.reset.
4113         (use_displaced_stepping): Don't check for NULL.
4114         (displaced_step_prepare_throw): Call
4115         get_displaced_stepping_state.
4116         (displaced_step_fixup): Don't check for NULL.
4117         (prepare_for_detach): Don't check for NULL.
4118
4119 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4120
4121         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4122          in case of call that did not complete.
4123
4124 2019-01-02  Andrey Utkin  <autkin@undo.io>
4125
4126         * symfile.c (find_separate_debug_file): Fix search of debug files for
4127         remote debuggee.
4128
4129 2019-01-02  Tom Tromey  <tom@tromey.com>
4130
4131         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4132         indentation.
4133         * python/py-frame.c (frapy_older): Remove cast.
4134         (frapy_newer): Likewise.
4135         * python/py-breakpoint.c (local_setattro): Remove cast.
4136         * python/py-arch.c (archpy_name): Remove local variable.
4137         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4138
4139 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4140
4141         * unittests/basic_string_view/element_access/char/empty.cc:
4142         Fix year range in copyright header.
4143
4144 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4145
4146         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4147         Delete.
4148         <operator==>: Update with for removed field.
4149         <hash>: Likewise.
4150         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4151         <isa_features>: ...this.
4152         <abi_features>: New field.
4153         (riscv_isa_flen): Update comment.
4154         (riscv_abi_xlen): New declaration.
4155         (riscv_abi_flen): New declaration.
4156         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4157         isa_features.
4158         (riscv_abi_xlen): New function.
4159         (riscv_isa_flen): Update to get answer from isa_features.
4160         (riscv_abi_flen): New function.
4161         (riscv_has_fp_abi): Update to get answer from abi_features.
4162         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4163         xlen and flen.
4164         (riscv_call_info) <xlen, flen>: Update comment.
4165         (riscv_call_arg_struct): Remove invalid assertions
4166         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4167         is removed.
4168         (riscv_gdbarch_init): Gather isa features and abi features
4169         separately, ensure both match on the gdbarch when reusing an old
4170         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4171         a target with 64-bit float hardware.
4172
4173 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4174
4175         * source.c (search_command_helper): Stop reverse search
4176         when line 1 has been searched.
4177
4178 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4179
4180         * record-full.c (record_full_base_target::close): Rewrite
4181         record_full_core_buf_list free logic.
4182
4183 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4184
4185         * break-catch-syscall.c (print_one_catch_syscall): xfree
4186         the last text.
4187
4188 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4189
4190         * top.c (print_gdb_version): Update Copyright year in version
4191         message.
4192
4193 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4194
4195         Update copyright year range in all GDB files.
4196
4197 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4198
4199         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4200
4201 For older changes see ChangeLog-2018.
4202 \f
4203 Local Variables:
4204 mode: change-log
4205 left-margin: 8
4206 fill-column: 74
4207 version-control: never
4208 coding: utf-8
4209 End:
4210