gdb/ChangeLog

   1 2019-01-22  Tom Tromey  <tom@tromey.com>
   2
   3         * remote-fileio.h (struct remote_target): Declare.
   4
   5 2019-01-22  Tom Tromey  <tom@tromey.com>
   6
   7         * python/py-arch.c: Do not include py-ref.h.
   8         * python/py-bpevent.c: Do not include py-ref.h.
   9         * python/py-cmd.c: Do not include py-ref.h.
  10         * python/py-continueevent.c: Do not include py-ref.h.
  11         * python/py-event.h: Do not include py-ref.h.
  12         * python/py-evtregistry.c: Do not include py-ref.h.
  13         * python/py-finishbreakpoint.c: Do not include py-ref.h.
  14         * python/py-frame.c: Do not include py-ref.h.
  15         * python/py-framefilter.c: Do not include py-ref.h.
  16         * python/py-function.c: Do not include py-ref.h.
  17         * python/py-infevents.c: Do not include py-ref.h.
  18         * python/py-linetable.c: Do not include py-ref.h.
  19         * python/py-objfile.c: Do not include py-ref.h.
  20         * python/py-param.c: Do not include py-ref.h.
  21         * python/py-prettyprint.c: Do not include py-ref.h.
  22         * python/py-progspace.c: Do not include py-ref.h.
  23         * python/py-symbol.c: Do not include py-ref.h.
  24         * python/py-symtab.c: Do not include py-ref.h.
  25         * python/py-type.c: Do not include py-ref.h.
  26         * python/py-unwind.c: Do not include py-ref.h.
  27         * python/py-utils.c: Do not include py-ref.h.
  28         * python/py-value.c: Do not include py-ref.h.
  29         * python/py-varobj.c: Do not include py-ref.h.
  30         * python/py-xmethods.c: Do not include py-ref.h.
  31         * python/python.c: Do not include py-ref.h.
  32         * varobj.c: Do not include py-ref.h.
  33
  34 2019-01-22  Tom Tromey  <tom@tromey.com>
  35
  36         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
  37         keyword for bcache.
  38
  39 2019-01-22  Tom Tromey  <tom@tromey.com>
  40
  41         * compile/compile-cplus-types.c: Remove a comment by #include.
  42
  43 2019-01-22  Tom Tromey  <tom@tromey.com>
  44
  45         * compile/gcc-c-plugin.h: Include compile-internal.h.
  46
  47 2019-01-22  Tom Tromey  <tom@tromey.com>
  48
  49         * stabsread.c (EXTERN): Do not define.
  50         (symnum, next_symbol_text_func, processing_gcc_compilation)
  51         (within_function, global_sym_chain, global_stabs)
  52         (previous_stab_code, this_object_header_files)
  53         (n_this_object_header_files)
  54         (n_allocated_this_object_header_files): Define.
  55         * stabsread.h (EXTERN): Never define.  Use "extern".
  56
  57 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  58
  59         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  60         history_value.
  61
  62 2019-01-21  Tom Tromey  <tom@tromey.com>
  63
  64         * ui-out.c: Fix includes.
  65         * tui/tui-source.c: Fix includes.
  66         * target.c: Fix includes.
  67         * remote.c: Fix includes.
  68         * regcache.c: Fix includes.
  69         * python/py-block.c: Fix includes.
  70         * printcmd.c: Fix includes.
  71         * or1k-tdep.c: Fix includes.
  72         * mi/mi-main.c: Fix includes.
  73         * m32r-tdep.c: Fix includes.
  74         * csky-tdep.c: Fix includes.
  75         * compile/compile-cplus-types.c: Fix includes.
  76         * cli/cli-interp.c: Fix includes.
  77
  78 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
  79
  80         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  81         for padding.
  82
  83 2019-01-16  Tom Tromey  <tom@tromey.com>
  84
  85         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
  86         earlier.
  87         (struct objfile) <msymbols_range>: Move from top level.
  88         <msymbols>: New method.
  89         (class objfile_msymbols): Remove.
  90         * symtab.c (default_collect_symbol_completion_matches_break_on):
  91         Update.
  92         * symmisc.c (dump_msymbols): Update.
  93         * stabsread.c (scan_file_globals): Update.
  94         * objc-lang.c (info_selectors_command, info_classes_command)
  95         (find_methods): Update.
  96         * minsyms.c (find_solib_trampoline_target): Update.
  97         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
  98         * coffread.c (coff_symfile_read): Update.
  99         * ada-lang.c (ada_lookup_simple_minsym)
 100         (ada_collect_symbol_completion_matches): Update.
 101
 102 2019-01-16  Tom Tromey  <tom@tromey.com>
 103
 104         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 105         type.  Remove no-argument constructor.
 106         <iterator::operator++>: Simplify.
 107         <begin>: Update.
 108         <end>: Use minimal_symbol_count.
 109
 110 2019-01-16  Tom Tromey  <tom@tromey.com>
 111
 112         * objfiles.h (struct objfile) <psymtabs>: New method.
 113         (class objfile_psymtabs): Remove.
 114         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 115         typedef.
 116         <range>: New method.
 117         (require_partial_symbols): Change return type.
 118         * psymtab.c (require_partial_symbols)
 119         (psym_expand_symtabs_matching): Update.
 120         * mdebugread.c (parse_partial_symbols): Update.
 121         * dbxread.c (dbx_end_psymtab): Update.
 122
 123 2019-01-15  Tom Tromey  <tom@tromey.com>
 124
 125         * symtab.c (lookup_objfile_from_block)
 126         (lookup_symbol_in_objfile_symtabs)
 127         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 128         (find_line_symtab, info_sources_command)
 129         (default_collect_symbol_completion_matches_break_on)
 130         (make_source_files_completion_list): Update.
 131         * symmisc.c (print_objfile_statistics, dump_objfile)
 132         (maintenance_print_symbols, maintenance_info_symtabs)
 133         (maintenance_check_symtabs, maintenance_info_line_tables):
 134         Update.
 135         * source.c (select_source_symtab)
 136         (forget_cached_source_info_for_objfile): Update.
 137         * objfiles.h (class objfile_compunits): Remove.
 138         (struct objfile) <compunits_range>: New typedef.
 139         (compunits): New method.
 140         * objfiles.c (objfile_relocate1): Update.
 141         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 142         * maint.c (count_symtabs_and_blocks): Update.
 143         * linespec.c (iterate_over_all_matching_symtabs): Update.
 144         * cp-support.c (add_symbol_overload_list_qualified): Update.
 145         * coffread.c (coff_symtab_read): Update.
 146         * ada-lang.c (add_nonlocal_symbols)
 147         (ada_collect_symbol_completion_matches)
 148         (ada_add_global_exceptions): Update.
 149
 150 2019-01-15  Tom Tromey  <tom@tromey.com>
 151
 152         * progspace.h (program_space) <objfiles_safe_range>: New
 153         typedef.
 154         <objfiles_safe>: New method.
 155         * objfiles.h (class all_objfiles_safe): Remove.
 156         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 157         * jit.c (jit_inferior_exit_hook): Update.
 158
 159 2019-01-17  Tom Tromey  <tom@tromey.com>
 160
 161         * progspace.h (program_space) <objfiles_range>: New typedef.
 162         <objfiles>: New method.
 163         <objfiles_head>: Rename from objfiles.
 164         (object_files): Update.
 165         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 166         * guile/scm-pretty-print.c
 167         (ppscm_find_pretty_printer_from_objfiles): Update.
 168         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 169         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 170         Update.
 171         * python/py-progspace.c (pspy_get_objfiles): Update.
 172         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 173         Update.
 174         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 175         (objfpy_lookup_objfile_by_build_id): Update.
 176         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 177         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 178         Update.
 179         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 180         (expand_symtab_containing_pc, lookup_objfile_from_block)
 181         (lookup_static_symbol, basic_lookup_transparent_type)
 182         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 183         (find_line_symtab, info_sources_command)
 184         (default_collect_symbol_completion_matches_break_on)
 185         (make_source_files_completion_list, find_main_name): Update.
 186         * symmisc.c (print_symbol_bcache_statistics)
 187         (print_objfile_statistics, maintenance_print_symbols)
 188         (maintenance_print_msymbols, maintenance_print_objfiles)
 189         (maintenance_info_symtabs, maintenance_check_symtabs)
 190         (maintenance_expand_symtabs, maintenance_info_line_tables):
 191         Update.
 192         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 193         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 194         (map_overlay_command, unmap_overlay_command)
 195         (simple_overlay_update, expand_symtabs_matching)
 196         (map_symbol_filenames): Update.
 197         * symfile-debug.c (set_debug_symfile): Update.
 198         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 199         Update.
 200         * source.c (select_source_symtab, forget_cached_source_info):
 201         Update.
 202         * solib.c (solib_read_symbols): Update.
 203         * solib-spu.c (append_ocl_sos): Update.
 204         * psymtab.c (maintenance_print_psymbols)
 205         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 206         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 207         * printcmd.c (info_symbol_command): Update.
 208         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 209         Update.
 210         * objfiles.h (class all_objfiles): Remove.
 211         * objfiles.c (have_partial_symbols, have_full_symbols)
 212         (have_minimal_symbols, qsort_cmp, update_section_map)
 213         (shared_objfile_contains_address_p)
 214         (default_iterate_over_objfiles_in_search_order): Update.
 215         * objc-lang.c (info_selectors_command, info_classes_command)
 216         (find_methods): Update.
 217         * minsyms.c (find_solib_trampoline_target): Update.
 218         * maint.c (maintenance_info_sections)
 219         (maintenance_translate_address, count_symtabs_and_blocks):
 220         Update.
 221         * main.c (captured_main_1): Update.
 222         * linux-thread-db.c (try_thread_db_load_from_pdir)
 223         (has_libpthread): Update.
 224         * linespec.c (iterate_over_all_matching_symtabs)
 225         (search_minsyms_for_name): Update.
 226         * jit.c (jit_find_objf_with_entry_addr): Update.
 227         * hppa-tdep.c (find_unwind_entry)
 228         (hppa_lookup_stub_minimal_symbol): Update.
 229         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 230         Update.
 231         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 232         (elf_gnu_ifunc_resolve_by_got): Update.
 233         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 234         * dwarf-index-write.c (save_gdb_index_command): Update.
 235         * cp-support.c (add_symbol_overload_list_qualified): Update.
 236         * breakpoint.c (create_overlay_event_breakpoint)
 237         (create_longjmp_master_breakpoint)
 238         (create_std_terminate_master_breakpoint)
 239         (create_exception_master_breakpoint): Update.
 240         * blockframe.c (find_pc_partial_function): Update.
 241         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 242         (ada_collect_symbol_completion_matches)
 243         (ada_add_global_exceptions): Update.
 244
 245 2019-01-17  Tom Tromey  <tom@tromey.com>
 246
 247         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 248         declare VEC.
 249         (solib_target_parse_libraries): Change return type.
 250         (library_list_start_segment, library_list_start_section)
 251         (library_list_end_library, library_list_start_library); Update.
 252         (solib_target_free_library_list): Remove.
 253         (solib_target_parse_libraries): Remove cleanup.  Change return
 254         type.
 255         (solib_target_current_sos): Update.
 256
 257 2019-01-17  Tom Tromey  <tromey@bapiya>
 258
 259         * valprint.c: Replace "the the" with "the".
 260         * symtab.c: Replace "the the" with "the".
 261         * solib.c: Replace "the the" with "the".
 262         * solib-dsbt.c: Replace "the the" with "the".
 263         * linespec.c: Replace "the the" with "the".
 264         * dwarf2loc.h: Replace "the the" with "the".
 265         * amd64-windows-tdep.c: Replace "the the" with "the".
 266         * aarch64-tdep.c: Replace "the the" with "the".
 267
 268 2019-01-16  Keith Seitz  <keiths@redhat.com>
 269
 270         PR gdb/23773
 271         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 272         <builder>: Rename to ..
 273         <m_builder>: ... this and make private.
 274         (dwarf2_cu::get_builder): New method.  Change all users of
 275         `builder' to use this method.
 276         (dwarf2_start_symtab): Move to ...
 277         (dwarf2_cu::start_symtab): ... here.  Update all callers
 278         (setup_type_unit_groups): Move to ...
 279         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 280         callers.
 281         (dwarf2_cu::reset_builder): New method.
 282         (process_full_compunit, process_full_type_unit): Use
 283         dwarf2_cu::reset_builder.
 284         (follow_die_offset): Record the ancestor CU if it is different
 285         from the followed DIE's CU.
 286         (follow_die_sig_1): Likewise.
 287
 288 2019-01-15  Tom Tromey  <tom@tromey.com>
 289
 290         * remote.c (class remote_state) <buf>: Now a char_vector.
 291         <buf_size>: Remove.
 292         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 293         parameter.
 294         (remote_target::getpkt_or_notif_sane_1)
 295         (remote_target::getpkt_sane)
 296         (remote_target::getpkt_or_notif_sane): Likewise.
 297         (class remote_target) <putpkt>: New overload.
 298         (remote_target::read_frame): Change type of "buf_p".  Remove
 299         sizeof_p parameter.
 300         (packet_ok): New overload.
 301         (packet_check_result): New overload.
 302         Update all uses.
 303
 304 2019-01-14  Tom Tromey  <tom@tromey.com>
 305
 306         * remote-notif.c (handle_notification, remote_notif_ack)
 307         (remote_notif_parse): Make "buf" const.
 308         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 309         const.
 310         (remote_notif_parse, remote_notif_ack, handle_notification):
 311         Likewise.
 312         * remote.c (remote_notif_stop_parse): Make "buf" const.
 313         (remote_target::remote_parse_stop_reply): Make "buf" const.
 314         (remote_notif_stop_ack): Make "buf" const.
 315
 316 2019-01-14  Tom Tromey  <tom@tromey.com>
 317
 318         * remote.c (remote_console_output): Make parameter const.
 319
 320 2019-01-14  Tom Tromey  <tom@tromey.com>
 321
 322         * target-debug.h (target_debug_print_signals): Constify.
 323         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 324         * procfs.c (procfs_target::pass_signals): Update.
 325         * linux-nat.c (linux_nat_target::pass_signals): Update.
 326         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 327         * target-delegates.c: Rebuild.
 328         * remote.c (remote_target::program_signals): Update.
 329         (remote_target::pass_signals): Update.
 330         * target.c (target_pass_signals): Constify argument.
 331         (target_program_signals): Likewise.
 332         * target.h (struct target_ops) <pass_signals, program_signals>:
 333         Constify argument.
 334         (target_pass_signals, target_program_signals): Constify argument.
 335
 336 2019-01-14  Tom Tromey  <tom@tromey.com>
 337
 338         PR tui/28819:
 339         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 340
 341 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 342
 343         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 344         field.
 345         * rs6000-tdep.c: Include reggroups.h.
 346         (IS_V_ALIAS_PSEUDOREG): Define.
 347         (rs6000_register_name): Return names for the "vX" aliases.
 348         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 349         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 350         aliases.  Call default_register_reggroup_p for all other
 351         pseudo-registers.
 352         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 353         New functions.
 354         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 355         Handle "vX" aliases.
 356         (v_alias_pseudo_register_collect): New function.
 357         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 358         (rs6000_gdbarch_init): Initialize "vX" aliases as
 359         pseudo-registers.  Restore registration of
 360         rs6000_pseudo_register_reggroup_p with
 361         set_tdesc_pseudo_register_reggroup_p.
 362
 363 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 364
 365         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 366         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 367         set_gdbarch_num_pseudo_regs.
 368
 369 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 370
 371         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 372         Remove arg prefixname, add do_set and do_show.
 373         Add member functions set_list and show_list.
 374         * cli/cli-style.c (class cli_style_option): Update accordingly.
 375         (style_set_list): Move to file scope.
 376         (style_show_list): Likewise.
 377         (set_style): Call help_list.
 378         (show_style): Call cmd_show_list.
 379         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 380         Update to use the new macro.
 381
 382 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 383
 384         * ada-lang.c (_initialize_ada_language): Expand the help text
 385         for the "catch exception" command.
 386
 387 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 388
 389         * symtab.c (matching_obj_sections): Initialize obj,
 390         declare it closer to its usage.
 391
 392 2019-01-10  Tom Tromey  <tom@tromey.com>
 393
 394         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 395         (basic_inf_threads_range): Remove.
 396         (inf_threads_range, inf_non_exited_threads_range)
 397         (safe_inf_threads_range): Use next_adapter.
 398
 399 2019-01-10  Keith Seitz  <keiths@redhat.com>
 400
 401         PR gdb/23712
 402         PR symtab/23010
 403         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 404         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 405
 406 2019-01-10  Keith Seitz  <keiths@redhat.com>
 407
 408         PR gdb/23712
 409         PR symtab/23010
 410         * dictionary.c (pending_to_vector): Remove.
 411         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 412         Remove _1 suffix, replacing functions of the same name.  Update
 413         all callers.
 414         (dict_create_hashed, dict_create_hashed_expandable)
 415         (dict_create_linear, dict_create_linear_expandable, dict_free)
 416         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 417         Make functions static.
 418
 419 2019-01-10  Keith Seitz  <keiths@redhat.com>
 420
 421         PR gdb/23712
 422         PR symtab/23010
 423         * dictionary.h (struct dictionary): Replace declaration with
 424         multidictionary.
 425         (dict_create_hashed, dict_create_hashed_expandable)
 426         (dict_create_linear, dict_create_linear_expandable)
 427         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 428         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 429         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 430         taking multidictionary argument.
 431         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 432         * block.h (struct block) <dict>: Change to multidictionary
 433         and rename `multidict'.
 434         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 435         symmisc.c: Update all dictionary references to multidictionary.
 436
 437 2019-01-10  Keith Seitz  <keiths@redhat.com>
 438
 439         PR gdb/23712
 440         PR symtab/23010
 441         * dictionary.c: Include unordered_map.
 442         (pending_to_vector): New function.
 443         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 444         Rewrite the non-"_1" functions to take vector instead
 445         of linked list.
 446         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 447         "new" _1 versions of the same name.
 448         (multidictionary): Define.
 449         (std::hash<enum language): New definition.
 450         (collate_pending_symbols_by_language, mdict_create_hashed)
 451         (mdict_create_hashed_expandable, mdict_create_linear)
 452         (mdict_create_linear_expandable, mdict_free)
 453         (find_language_dictionary, create_new_language_dictionary)
 454         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 455         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 456         (mdict_size, mdict_empty): New functions.
 457         * dictionary.h (mdict_iterator): Define.
 458
 459 2019-01-10  Pedro Alves  <palves@redhat.com>
 460
 461         * breakpoint.c (read_uploaded_action)
 462         (create_tracepoint_from_upload): Adjust to use
 463         gdb::unique_xmalloc_ptr.
 464         * ctf.c (ctf_write_uploaded_tp):
 465         (SET_ARRAY_FIELD): Use emplace_back.
 466         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 467         * tracefile-tfile.c (tfile_write_uploaded_tp):
 468         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 469         gdb::unique_xmalloc_ptr.
 470         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 471         at_string, cond_string, cmd_strings>: Replace char pointers
 472         with gdb::unique_xmalloc_ptr.
 473
 474 2019-01-10  Pedro Alves  <palves@redhat.com>
 475
 476         * solib-target.c (library_list_start_library): Don't xstrdup name.
 477
 478 2019-01-10  Pedro Alves  <palves@redhat.com>
 479
 480         * mdebugread.c (parse_partial_symbols): Use
 481         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 482
 483 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 484
 485         * linux-fork.c (scoped_switch_fork_info)
 486         <~scoped_switch_fork_info>: Fix incorrect variable name.
 487
 488 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 489
 490         * linux-fork.c (scoped_switch_fork_info)
 491         <scoped_switch_fork_info>: Make explicit.
 492         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 493
 494 2019-01-10  Tom Tromey  <tom@tromey.com>
 495
 496         * objfiles.h (objfile::reset_psymtabs): Update.
 497         * objfiles.c (objfile::objfile): Update.
 498         * psymtab.h (psymtab_storage::obstack): Update.
 499         (psymtab_storage::m_obstack): Use gdb::optional.
 500         (class psymtab_storage): Update comment.  Remove objfile
 501         parameter.
 502         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 503
 504 2019-01-10  Tom Tromey  <tom@tromey.com>
 505
 506         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 507         <free_psymtabs>: Now private.
 508         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 509         (allocate_psymtab): Use new method.
 510
 511 2019-01-10  Tom Tromey  <tom@tromey.com>
 512
 513         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 514         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 515         * mdebugread.c (parse_partial_symbols): Use
 516         allocate_dependencies.
 517         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 518         allocate_dependencies.
 519         (process_psymtab_comp_unit_reader)
 520         (build_type_psymtab_dependencies): Likewise.
 521         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 522
 523 2019-01-10  Tom Tromey  <tom@tromey.com>
 524
 525         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 526         PSYMBOL_SET_LANGUAGE.
 527         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 528
 529 2019-01-10  Tom Tromey  <tom@tromey.com>
 530
 531         * psymtab.h (psymtab_storage::obstack): New method.
 532         <m_obstack>: Rename from obstack; now private.
 533         * psymtab.c (psymtab_storage): Update.
 534         * dwarf2read.c (create_addrmap_from_index)
 535         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 536         Update.
 537
 538 2019-01-10  Tom Tromey  <tom@tromey.com>
 539
 540         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 541         * objfiles.h (objfile::reset_psymtabs): New method.
 542
 543 2019-01-10  Tom Tromey  <tom@tromey.com>
 544
 545         * symmisc.c (print_symbol_bcache_statistics): Update.
 546         (print_objfile_statistics): Update.
 547         * symfile.c (reread_symbols): Update.
 548         * psymtab.h (class psymtab_storage): New.
 549         * psymtab.c (psymtab_storage): New constructor.
 550         (~psymtab_storage): New destructor.
 551         (require_partial_symbols): Update.
 552         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 553         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 554         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 555         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 556         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 557         (start_psymtab_common, end_psymtab_common)
 558         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 559         (allocate_psymtab): Update.
 560         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 561         Update.
 562         (dump_psymtab_addrmap, maintenance_print_psymbols)
 563         (maintenance_check_psymtabs): Update.
 564         (class objfile_psymtabs): Move to objfiles.h.
 565         * psympriv.h (discard_psymtab): Now inline.
 566         (psymtab_discarder::psymtab_discarder): Update.
 567         (psymtab_discarder::~psymtab_discarder): Update.
 568         (ALL_OBJFILE_PSYMTABS): Rewrite.
 569         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 570         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 571         Remove fields.
 572         <partial_symtabs>: New field.
 573         (class objfile_psymtabs): Move from psymtab.h.  Update.
 574         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 575         psymbol_cache.
 576         (objfile::~objfile): Don't destroy psymbol_cache.
 577         * mdebugread.c (parse_partial_symbols): Update.
 578         * dwarf2read.c (create_addrmap_from_index)
 579         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 580         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 581         (add_partial_subprogram, dwarf2_ranges_read): Update.
 582         * dwarf-index-write.c (write_address_map)
 583         (write_one_signatured_type, recursively_write_psymbols)
 584         (class debug_names, class debug_names, write_psymtabs_to_index):
 585         Update.
 586
 587 2019-01-10  Tom Tromey  <tom@tromey.com>
 588
 589         * symtab.h (SYMBOL_SET_NAMES): Update.
 590         (symbol_set_names): Update.
 591         (MSYMBOL_SET_NAMES): Update.
 592         * symtab.c (symbol_set_names): Change argument to be an
 593         objfile_per_bfd_storage.
 594         * psymtab.c (add_psymbol_to_bcache): Update.
 595         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 596
 597 2019-01-10  Tom Tromey  <tom@tromey.com>
 598
 599         * symtab.c (create_demangled_names_hash): Change argument to be an
 600         objfile_per_bfd_storage.
 601         (symbol_set_names): Update.
 602
 603 2019-01-10  Tom Tromey  <tom@tromey.com>
 604
 605         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 606         init_psymbol_list.
 607         * psymtab.c (init_psymbol_list): Do nothing if already called.
 608         * psympriv.h (init_psymbol_list): Add comment.
 609         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 610         init_psymbol_list.
 611         * dbxread.c (dbx_symfile_read): Unconditionally call
 612         init_psymbol_list.
 613
 614 2019-01-10  Tom Tromey  <tom@tromey.com>
 615
 616         * xcoffread.c (scan_xcoff_symtab): Update.
 617         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 618         "where".
 619         * mdebugread.c (parse_partial_symbols)
 620         (handle_psymbol_enumerators): Update.
 621         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 622         * dbxread.c (read_dbx_symtab): Update.
 623         * psympriv.h (psymbol_placement): New enum.
 624         (add_psymbol_to_list): Update.
 625
 626 2019-01-10  Tom Tromey  <tom@tromey.com>
 627
 628         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 629         static_psymbols parameters.
 630         (scan_xcoff_symtab): Update.
 631         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 632         static_psymbols parameters.
 633         * psympriv.h (start_psymtab_common): Update.
 634         * mdebugread.c (parse_partial_symbols): Update.
 635         * dwarf2read.c (create_partial_symtab): Update.
 636         * dbxread.c (read_dbx_symtab): Update.
 637         (start_psymtab): Remove global_psymbols and static_psymbols
 638         parameters.
 639
 640 2019-01-10  Tom Tromey  <tom@tromey.com>
 641
 642         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 643         * psymtab.c (allocate_psymtab): Add comment.
 644         * psympriv.h (allocate_psymtab): Add comment.
 645         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 646         initializations.
 647         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 648
 649 2019-01-10  Tom Tromey  <tom@tromey.com>
 650
 651         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 652         Don't declare.
 653         * mipsread.c: Include mdebugread.h.
 654         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 655         Declare.
 656         * elfread.c: Include mdebugread.h.
 657
 658 2019-01-09  Tom Tromey  <tom@tromey.com>
 659
 660         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 661         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 662         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 663         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 664         (psym_lookup_symbol, psym_find_last_source_symtab)
 665         (psym_forget_cached_source_info, psym_print_stats)
 666         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 667         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 668         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 669         (psym_find_compunit_symtab_by_address)
 670         (maintenance_print_psymbols, maintenance_info_psymtabs)
 671         (maintenance_check_psymtabs): Use ranged for.
 672         * psymtab.h (class objfile_psymtabs): New.
 673         (require_partial_symbols): Return objfile_psymtabs.
 674         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 675
 676 2019-01-09  Tom Tromey  <tom@tromey.com>
 677
 678         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 679         (find_pc_mapped_section, list_overlays_command)
 680         (map_overlay_command, unmap_overlay_command)
 681         (simple_overlay_update): Use all_objfiles.
 682         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 683         * printcmd.c (info_symbol_command): Use all_objfiles.
 684         * objfiles.h (ALL_OBJSECTIONS): Remove.
 685         * maint.c (maintenance_translate_address): Use all_objfiles.
 686         * gcore.c (gcore_create_callback): Use all_objfiles.
 687         (objfile_find_memory_regions): Likewise.
 688
 689 2019-01-09  Tom Tromey  <tom@tromey.com>
 690
 691         * symtab.c (find_line_symtab, info_sources_command)
 692         (make_source_files_completion_list): Use objfile_compunits.
 693         * source.c (select_source_symtab): Use objfile_compunits.
 694         * objfiles.h (struct objfile): Update comment.
 695         (ALL_OBJFILES): Remove.
 696         (ALL_FILETABS): Remove.
 697         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 698         objfile_compunits.
 699
 700 2019-01-09  Tom Tromey  <tom@tromey.com>
 701
 702         * symmisc.c (print_objfile_statistics, dump_objfile)
 703         (maintenance_print_symbols): Use compunit_filetabs.
 704         * source.c (forget_cached_source_info_for_objfile): Use
 705         compunit_filetabs.
 706         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 707         (ALL_FILETABS): Use compunit_filetabs.
 708         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 709         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 710
 711 2019-01-09  Tom Tromey  <tom@tromey.com>
 712
 713         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 714         (compunit_filetabs): New.
 715         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 716         compunit_filetabs.
 717         (info_sources_command, make_source_files_completion_list): Remove
 718         declaration.
 719         * symmisc.c (print_objfile_statistics, dump_objfile)
 720         (maintenance_print_symbols): Remove declaration.
 721         (maintenance_info_symtabs): Use compunit_filetabs.
 722         (maintenance_info_line_tables): Likewise.
 723         * source.c (select_source_symtab): Change local variable name.
 724         (forget_cached_source_info_for_objfile): Remove declaration.
 725         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 726         * objfiles.c (objfile_relocate1): Remove declaration.
 727         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 728         declaration.
 729         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 730         * coffread.c (coff_symtab_read): Remove declaration.
 731         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 732         compunit_filetabs.
 733
 734 2019-01-09  Tom Tromey  <tom@tromey.com>
 735
 736         * symtab.c (lookup_objfile_from_block)
 737         (find_pc_sect_compunit_symtab, search_symbols)
 738         (default_collect_symbol_completion_matches_break_on): Use
 739         objfile_compunits.
 740         * objfiles.h (ALL_COMPUNITS): Remove.
 741         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 742         * cp-support.c (add_symbol_overload_list_qualified): Use
 743         objfile_compunits.
 744         * ada-lang.c (ada_collect_symbol_completion_matches)
 745         (ada_add_global_exceptions): Use objfile_compunits.
 746
 747 2019-01-09  Tom Tromey  <tom@tromey.com>
 748
 749         * source.c (select_source_symtab)
 750         (forget_cached_source_info_for_objfile): Remove declaration.
 751         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 752         declaration.
 753         * maint.c (count_symtabs_and_blocks): Remove declaration.
 754         * cp-support.c (add_symbol_overload_list_qualified): Remove
 755         declaration.
 756         * coffread.c (coff_symtab_read): Remove declaration.
 757         * symtab.c (lookup_symbol_in_objfile_symtabs)
 758         (basic_lookup_transparent_type_1): Use objfile_compunits.
 759         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 760         (info_sources_command, search_symbols)
 761         (default_collect_symbol_completion_matches_break_on)
 762         (make_source_files_completion_list): Remove declaration.
 763         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 764         (ada_collect_symbol_completion_matches)
 765         (ada_add_global_exceptions): Remove declaration.
 766         * linespec.c (iterate_over_all_matching_symtabs): Use
 767         objfile_compunits.
 768         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 769         (class objfile_compunits): New.
 770         (ALL_COMPUNITS): Use objfile_compunits.
 771         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 772         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 773         objfile_compunits.
 774         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 775
 776 2019-01-09  Tom Tromey  <tom@tromey.com>
 777
 778         * symtab.c (search_symbols)
 779         (default_collect_symbol_completion_matches_break_on): Use
 780         objfile_msymbols.
 781         * ada-lang.c (ada_lookup_simple_minsym)
 782         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 783         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 784         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 785         objfile_msymbols.
 786         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 787         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 788         * objc-lang.c (find_methods): Use objfile_msymbols.
 789         (info_selectors_command, info_classes_command): Likewise.
 790         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 791         * objfiles.h (class objfile_msymbols): New.
 792         (ALL_OBJFILE_MSYMBOLS): Remove.
 793         (ALL_MSYMBOLS): Remove.
 794
 795 2019-01-09  Tom Tromey  <tom@tromey.com>
 796
 797         * common/next-iterator.h (next_adapter): Add Iterator template
 798         parameter.
 799         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 800         (class all_objfiles_safe): New.
 801         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 802         * objfiles.c (put_objfile_before): Update comment.
 803         (add_separate_debug_objfile): Likewise.
 804         (free_all_objfiles): Use all_objfiles_safe.
 805         (objfile_purge_solibs): Likewise.
 806
 807 2019-01-09  Tom Tromey  <tom@tromey.com>
 808
 809         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 810         (expand_symtab_containing_pc, lookup_static_symbol)
 811         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 812         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 813         all_objfiles.
 814         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 815         * breakpoint.c (create_overlay_event_breakpoint)
 816         (create_longjmp_master_breakpoint)
 817         (create_std_terminate_master_breakpoint)
 818         (create_exception_master_breakpoint): Use all_objfiles.
 819         * linux-thread-db.c (try_thread_db_load_from_pdir)
 820         (has_libpthread): Use all_objfiles.
 821         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 822         * linespec.c (iterate_over_all_matching_symtabs)
 823         (search_minsyms_for_name): Use all_objfiles.
 824         * maint.c (maintenance_info_sections): Use all_objfiles.
 825         * main.c (captured_main_1): Use all_objfiles.
 826         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 827         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 828         * guile/scm-pretty-print.c
 829         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 830         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 831         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 832         (maintenance_print_msymbols): Use all_objfiles.
 833         * source.c (select_source_symtab): Use all_objfiles.
 834         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 835         * symfile.c (remove_symbol_file_command)
 836         (expand_symtabs_matching, map_symbol_filenames): Use
 837         all_objfiles.
 838         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 839         all_objfiles.
 840         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 841         * objc-lang.c (find_methods): Use all_objfiles.
 842         * objfiles.c (have_partial_symbols, have_full_symbols)
 843         (have_minimal_symbols, qsort_cmp)
 844         (default_iterate_over_objfiles_in_search_order): Use
 845         all_objfiles.
 846         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 847         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 848         (maintenance_check_psymtabs): Use all_objfiles.
 849         (ALL_PSYMTABS): Remove.
 850         * compile/compile-object-run.c (do_module_cleanup): Use
 851         all_objfiles.
 852         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 853         * cp-support.c (add_symbol_overload_list_qualified): Use
 854         all_objfiles.
 855         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 856         Use all_objfiles.
 857         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 858         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 859         all_objfiles.
 860         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 861         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 862         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 863         Uses all_objfiles.
 864         * solib.c (solib_read_symbols): Use all_objfiles
 865
 866 2019-01-09  Tom Tromey  <tom@tromey.com>
 867
 868         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 869         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 870         all_objfiles.
 871         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 872         * symmisc.c (print_symbol_bcache_statistics)
 873         (print_objfile_statistics, maintenance_print_objfiles)
 874         (maintenance_info_symtabs, maintenance_check_symtabs)
 875         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 876         all_objfiles.
 877         * source.c (forget_cached_source_info): Use all_objfiles.
 878         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 879         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 880         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 881         * objfiles.c (update_section_map): Use all_objfiles.
 882         (shared_objfile_contains_address_p): Likewise.
 883         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 884         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 885
 886 2019-01-09  Tom Tromey  <tom@tromey.com>
 887
 888         * common/next-iterator.h: New file.
 889         * objfiles.h (class all_objfiles): New.
 890         (struct objfile_iterator): New.
 891
 892 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 893
 894         * NEWS: Move the description of the changed "frame", "select-frame",
 895          and "info frame" commands to the Changed commands section.
 896
 897 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 898
 899         * gdbtypes.c (check_stub_method_group): Remove handling of old
 900         mangling schemes.
 901         * linespec.c (find_methods): Likewise.
 902         * stabsread.c (read_member_functions): Likewise.
 903         * valops.c (search_struct_method): Likewise.
 904         (value_struct_elt_for_reference): Likewise.
 905         * NEWS: Mention this change.
 906
 907 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 908
 909         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 910         print_source_lines.
 911         * source.c (print_source_lines_base): Update line number check.
 912         (print_source_lines): New function.
 913         (source_lines_range::source_lines_range): New function.
 914         * source.h (class source_lines_range): New class.
 915         (print_source_lines): New declaration.
 916
 917 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 918
 919         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 920
 921 2019-01-08  Tom Tromey  <tom@tromey.com>
 922             Simon Marchi  <simon.marchi@ericsson.com>
 923
 924         PR gdb/24060
 925         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 926         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 927         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 928         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 929         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 930         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 931
 932 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 933
 934         * source.c (select_source_symtab): Move header comment to
 935         declaration in source.h.
 936         (forget_cached_source_info_for_objfile): Likewise.
 937         (forget_cached_source_info): Likewise.
 938         (identify_source_line): Likewise.
 939         * source.h (identify_source_line): Move declaration from symtab.h
 940         and add comment from source.c
 941         (print_source_lines): Likewise.
 942         (forget_cached_source_info_for_objfile): Likewise.
 943         (forget_cached_source_info): Likewise.
 944         (select_source_symtab): Likewise.
 945         (enum print_source_lines_flag): Move definition from symtab.h.
 946         * symtab.h (identify_source_line): Move declaration to source.h.
 947         (print_source_lines): Likewise.
 948         (forget_cached_source_info_for_objfile): Likewise.
 949         (forget_cached_source_info): Likewise.
 950         (select_source_symtab): Likewise.
 951         (enum print_source_lines_flag): Move definition to source.h.
 952         * tui/tui-hooks.c: Add 'source.h' include.
 953
 954 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 955
 956         * source.c (print_source_lines_base): Handle requests to print
 957         reverse line number sequences, and guard against empty lines
 958         string.
 959
 960 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 961
 962         * source.c (print_source_lines_base): Fix skip of '\r' if next
 963         character is '\n'.
 964
 965 2019-01-06  Tom Tromey  <tom@tromey.com>
 966
 967         * c-exp.y (struct c_parse_state) <macro_original_text,
 968         expansion_obstack>: New member.
 969         (macro_original_text, expansion_obstack): Remove globals.
 970         (scan_macro_expansion, scanning_macro_expansion)
 971         (finished_macro_expansion): Update.
 972         (scan_macro_cleanup): Remove.
 973         (yylex, c_parse): Update.
 974
 975 2019-01-06  Tom Tromey  <tom@tromey.com>
 976
 977         * c-exp.y (struct c_parse_state) <strings>: New member.
 978         (operator_stoken): Update.
 979
 980 2019-01-06  Tom Tromey  <tom@tromey.com>
 981
 982         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 983         (union type_stack_elt) <typelist_val>: Now a pointer to
 984         std::vector.
 985         (type_stack_cleanup): Don't declare.
 986         (push_typelist): Update.
 987         * parse.c (pop_typelist): Return a std::vector.
 988         (push_typelist): Take a std::vector.
 989         (follow_types): Update.  Do not free args.
 990         (type_stack_cleanup): Remove.
 991         * c-exp.y (struct c_parse_state): New.
 992         (cpstate): New global.
 993         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 994         (nonempty_typelist): Update.
 995         (func_mod): Create a new vector.
 996         (c_parse): Create a c_parse_state.
 997         (check_parameter_typelist): Do not delete params.
 998         (function_method): Update.  Do not delete type_list.
 999
1000 2019-01-06  Tom Tromey  <tom@tromey.com>
1001
1002         PR gdb/28155:
1003         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1004         check_typedef.
1005         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1006         (print_return_value): Likewise.
1007
1008 2019-01-05  Tom Tromey  <tom@tromey.com>
1009
1010         * contrib/cleanup_check.py: Remove.
1011         * contrib/gcc-with-excheck: Remove.
1012         * contrib/exsummary.py: Remove.
1013         * contrib/excheck.py: Remove.
1014
1015 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1016
1017         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1018         NULL. Initialize tpprev to NULL instead of assigning it
1019         to NULL on the next statement.
1020         * windows-nat.c (windows_delete_thread): Remove check for
1021         main_thread_id before printing thread exit notifications.
1022         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1023         Remove thread ID check against main_thread_id.
1024         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1025         windows_delete_thread.
1026         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1027
1028 2019-01-04  Tom Tromey  <tom@tromey.com>
1029
1030         * compile/compile.c (_initialize_compile): Use upper case for
1031         metasyntactic variables.
1032         * symmisc.c (_initialize_symmisc): Use upper case for
1033         metasyntactic variables.
1034         * psymtab.c (_initialize_psymtab): Use upper case for
1035         metasyntactic variables.
1036         * demangle.c (demangle_command): Use upper case for metasyntactic
1037         variables.
1038         (_initialize_demangler): Likewise.
1039         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1040         variables.
1041
1042 2019-01-03  Tom Tromey  <tom@tromey.com>
1043
1044         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1045
1046 2019-01-03  Tom Tromey  <tom@tromey.com>
1047
1048         * python/py-symtab.c (salpy_str): Update.
1049         (struct salpy_sal_object) <symtab>: Now a PyObject.
1050         (salpy_dealloc): Update.
1051         (del_objfile_sal): Use gdbpy_ref.
1052
1053 2019-01-03  Tom Tromey  <tom@tromey.com>
1054
1055         * python/py-type.c (convert_field): Use new_reference.  Return
1056         gdbpy_ref.
1057         (make_fielditem): Return gdbpy_ref.
1058         (typy_fields): Update.
1059         (typy_getitem): Update.
1060         (field_name): Return gdbpy_ref.  Use new_reference.
1061         (typy_iterator_iternext): Update.
1062
1063 2019-01-03  Tom Tromey  <tom@tromey.com>
1064
1065         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1066
1067 2019-01-03  Tom Tromey  <tom@tromey.com>
1068
1069         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1070         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1071         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1072         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1073         (pspy_set_type_printers): Likewise.
1074         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1075         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1076         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1077         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1078         (objfpy_set_type_printers): Likewise.
1079
1080 2019-01-03  Tom Tromey  <tom@tromey.com>
1081
1082         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1083         (gdbpy_print_stack): Use gdbpy_err_fetch.
1084         * python/python-internal.h (class gdbpy_err_fetch): New class.
1085         (class gdbpy_enter) <m_error_type, m_error_value,
1086         m_error_traceback>: Remove.
1087         <m_error>: New member.
1088         (gdbpy_exception_to_string): Don't declare.
1089         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1090         * python/py-value.c (convert_value_from_python): Use
1091         gdbpy_err_fetch.
1092         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1093         gdbpy_exception_to_string.
1094         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1095         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1096         gdbpy_err_fetch.
1097
1098 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1099
1100         * linux-nat.c (delete_lwp_cleanup): Delete.
1101         (struct lwp_deleter): New struct.
1102         (lwp_info_up): New typedef.
1103         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1104         lwp_info_up.
1105
1106 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1107
1108         * linux-fork.c (class scoped_switch_fork_info): New class.
1109         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1110
1111 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1112
1113         * valops.c (find_overload_match): Remove use of null_cleanup, and
1114         calls to do_cleanups.
1115
1116 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * compile/compile-cplus-types.c
1119         (compile_cplus_instance::decl_name): Handle changes to
1120         cp_func_name.
1121         * cp-support.c (cp_func_name): Update header comment, update
1122         return type.
1123         * cp-support.h (cp_func_name): Update return type in declaration.
1124         * valops.c (find_overload_match): Move temp_func local to top
1125         level of function and change its type.  Use temp_func to hold and
1126         delete temporary string obtained from cp_func_name.
1127
1128 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1129
1130         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1131         gdb::char_vector, remove cleanup, and update uses of `msg`.
1132
1133 2019-01-03  Jim Wilson  <jimw@sifive.com>
1134
1135         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1136
1137 2019-01-02  Tom Tromey  <tom@tromey.com>
1138
1139         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1140         (tdesc_parse_xml): Remove cleanups.
1141         * target-descriptions.h (make_cleanup_free_target_description):
1142         Don't declare.
1143         (target_desc_deleter): New struct.
1144         (target_desc_up): New typedef.
1145         * target-descriptions.c (target_desc_deleter::operator()): Rename
1146         from free_target_description.
1147         (make_cleanup_free_target_description): Remove.
1148
1149 2019-01-02  Tom Tromey  <tom@tromey.com>
1150
1151         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1152         constructor, destructor.
1153         (linespec_parser): Remove typedef.
1154         (~linespec_parser): Rename from linespec_parser_delete.
1155         (linespec_lex_to_end, linespec_complete_label)
1156         (linespec_complete): Update.
1157         (decode_line_full): Remove cleanups.
1158         (decode_line_1): Update.
1159
1160 2019-01-02  Tom Tromey  <tom@tromey.com>
1161
1162         * python/python-internal.h (inferior_to_inferior_object): Change
1163         return type.
1164         * python/py-exitedevent.c (create_exited_event_object): Update.
1165         * python/py-inferior.c (inferior_to_inferior_object): Return
1166         gdbpy_ref.
1167         (python_new_inferior, python_inferior_deleted)
1168         (thread_to_thread_object, delete_thread_object)
1169         (build_inferior_list, gdbpy_selected_inferior): Update.
1170         * python/py-infthread.c (create_thread_object): Update.  Also fail
1171         if inferior_to_inferior_object fails.
1172
1173 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1174
1175         * inferior.h (class inferior) <displaced_step_state>: New field.
1176         * infrun.h (struct displaced_step_state): Move here from
1177         infrun.c.  Initialize fields, add constructor.
1178         <inf>: Remove field.
1179         <reset>: New method.
1180         * infrun.c (struct displaced_step_inferior_state): Move to
1181         infrun.h.
1182         (displaced_step_inferior_states): Remove.
1183         (get_displaced_stepping_state): Adust.
1184         (displaced_step_in_progress_any_inferior): Adjust.
1185         (displaced_step_in_progress_thread): Adjust.
1186         (displaced_step_in_progress): Adjust.
1187         (add_displaced_stepping_state): Remove.
1188         (get_displaced_step_closure_by_addr): Adjust.
1189         (remove_displaced_stepping_state): Remove.
1190         (infrun_inferior_exit): Call displaced_step_state.reset.
1191         (use_displaced_stepping): Don't check for NULL.
1192         (displaced_step_prepare_throw): Call
1193         get_displaced_stepping_state.
1194         (displaced_step_fixup): Don't check for NULL.
1195         (prepare_for_detach): Don't check for NULL.
1196
1197 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1198
1199         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1200          in case of call that did not complete.
1201
1202 2019-01-02  Andrey Utkin  <autkin@undo.io>
1203
1204         * symfile.c (find_separate_debug_file): Fix search of debug files for
1205         remote debuggee.
1206
1207 2019-01-02  Tom Tromey  <tom@tromey.com>
1208
1209         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1210         indentation.
1211         * python/py-frame.c (frapy_older): Remove cast.
1212         (frapy_newer): Likewise.
1213         * python/py-breakpoint.c (local_setattro): Remove cast.
1214         * python/py-arch.c (archpy_name): Remove local variable.
1215         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1216
1217 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1218
1219         * unittests/basic_string_view/element_access/char/empty.cc:
1220         Fix year range in copyright header.
1221
1222 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1223
1224         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1225         Delete.
1226         <operator==>: Update with for removed field.
1227         <hash>: Likewise.
1228         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1229         <isa_features>: ...this.
1230         <abi_features>: New field.
1231         (riscv_isa_flen): Update comment.
1232         (riscv_abi_xlen): New declaration.
1233         (riscv_abi_flen): New declaration.
1234         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1235         isa_features.
1236         (riscv_abi_xlen): New function.
1237         (riscv_isa_flen): Update to get answer from isa_features.
1238         (riscv_abi_flen): New function.
1239         (riscv_has_fp_abi): Update to get answer from abi_features.
1240         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1241         xlen and flen.
1242         (riscv_call_info) <xlen, flen>: Update comment.
1243         (riscv_call_arg_struct): Remove invalid assertions
1244         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1245         is removed.
1246         (riscv_gdbarch_init): Gather isa features and abi features
1247         separately, ensure both match on the gdbarch when reusing an old
1248         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1249         a target with 64-bit float hardware.
1250
1251 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1252
1253         * source.c (search_command_helper): Stop reverse search
1254         when line 1 has been searched.
1255
1256 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1257
1258         * record-full.c (record_full_base_target::close): Rewrite
1259         record_full_core_buf_list free logic.
1260
1261 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1262
1263         * break-catch-syscall.c (print_one_catch_syscall): xfree
1264         the last text.
1265
1266 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1267
1268         * top.c (print_gdb_version): Update Copyright year in version
1269         message.
1270
1271 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1272
1273         Update copyright year range in all GDB files.
1274
1275 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1276
1277         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1278
1279 For older changes see ChangeLog-2018.
1280 \f
1281 Local Variables:
1282 mode: change-log
1283 left-margin: 8
1284 fill-column: 74
1285 version-control: never
1286 coding: utf-8
1287 End:
1288