Change tui_set_exec_info_content to be a method
[platform/upstream/binutils.git] / gdb / ChangeLog
1 2019-08-13  Tom Tromey  <tom@tromey.com>
2
3         * tui/tui-winsource.h (struct tui_source_window_base)
4         <set_exec_info_content>: Declare.
5         (tui_set_exec_info_content): Don't declare.
6         * tui/tui-winsource.c
7         (tui_source_window_base::set_exec_info_content): Rename from
8         tui_set_exec_info_content.
9         (tui_update_exec_info): Update.
10
11 2019-08-13  Tom Tromey  <tom@tromey.com>
12
13         * tui/tui-winsource.h (struct tui_source_window_base)
14         <show_source_content>: Declare.
15         (tui_show_source_content): Don't declare.
16         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
17         (tui_source_window_base::show_source_content): Rename from
18         tui_show_source_content.
19         (tui_source_window_base::refresh_all): Update.
20         * tui/tui-layout.c (show_source_disasm_command)
21         (show_source_or_disasm_and_command): Update.
22
23 2019-08-13  Tom Tromey  <tom@tromey.com>
24
25         * tui/tui-winsource.c (tui_erase_source_content)
26         (tui_show_source_content, tui_source_window_base::refresh_all):
27         Update.
28         * tui/tui-wingeneral.h
29         (tui_check_and_display_highlight_if_needed): Don't declare.
30         * tui/tui-wingeneral.c
31         (tui_win_info::check_and_display_highlight_if_needed): Rename from
32         check_and_display_highlight_if_needed.
33         * tui/tui-win.c (tui_rehighlight_all)
34         (tui_win_info::make_visible_with_new_height): Update.
35         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
36         (tui_data_window::erase_data_content)
37         (tui_data_window::display_all_data): Update.
38         * tui/tui-data.h (struct tui_win_info)
39         <check_and_display_highlight_if_needed>: Declare.
40
41 2019-08-13  Tom Tromey  <tom@tromey.com>
42
43         * tui/tui-win.c (tui_resize_all): Call
44         tui_delete_invisible_windows.
45         * tui/tui-layout.c (show_layout): Call
46         tui_delete_invisible_windows.
47         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
48         * tui/tui-data.c (tui_delete_invisible_windows): New function.
49
50 2019-08-13  Tom Tromey  <tom@tromey.com>
51
52         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
53         tui_add_win_to_layout.
54
55 2019-08-13  Tom Tromey  <tom@tromey.com>
56
57         * tui/tui-layout.h (tui_default_win_height): Don't declare.
58         * tui/tui-layout.c (tui_default_win_height): Now static.
59
60 2019-08-13  Tom Tromey  <tom@tromey.com>
61
62         * tui/tui-layout.c (show_layout): Unify all layout cases into a
63         single switch.
64         (show_source_disasm_command, show_source_or_disasm_and_command):
65         Don't check current layout.
66
67 2019-08-13  Tom Tromey  <tom@tromey.com>
68
69         * tui/tui-wingeneral.c (make_all_visible): Remove.
70         (tui_make_all_invisible): Simplify.
71         * tui/tui-layout.c (tui_make_all_invisible): Move from
72         tui-wingeneral.c; simplify.
73         (show_layout): Hoist call to tui_make_all_invisible.
74         (show_data): Don't call tui_make_all_invisible.
75
76 2019-08-13  Tom Tromey  <tom@tromey.com>
77
78         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
79         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
80
81 2019-08-13  Tom Tromey  <tom@tromey.com>
82
83         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
84         tui-data.c.
85         (show_source_disasm_command, show_data)
86         (show_source_or_disasm_and_command): Don't use
87         tui_set_current_layout_to.
88         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
89         * tui/tui-data.c (current_layout, tui_current_layout): Move to
90         tui-layout.c.
91         (tui_set_current_layout_to): Remove.
92
93 2019-08-13  Tom Tromey  <tom@tromey.com>
94
95         * tui/tui-layout.c (tui_set_layout): Update.
96         * tui/tui-data.h (struct tui_layout_def): Remove.
97         (tui_layout_def): Don't declare.
98         * tui/tui-data.c (layout_def): Remove.
99         (tui_layout_def): Remove.
100
101 2019-08-13  Tom Tromey  <tom@tromey.com>
102
103         * tui/tui-winsource.h (struct tui_source_window_base)
104         <clear_detail>: No longer "override".
105         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
106         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
107         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
108         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
109         Remove.
110         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
111
112 2019-08-13  Tom Tromey  <tromey@adacore.com>
113
114         * tracepoint.c: Don't include readline.h or history.h.
115
116 2019-08-12  Tom Tromey  <tom@tromey.com>
117
118         * configure: Rebuild.
119         * configure.ac: Check for readline 7.
120         * NEWS: Mention readline 7 requirement.
121         * README: Update.
122
123 2019-08-12  Tom Tromey  <tom@tromey.com>
124
125         * mingw-hdep.c (gdb_select): Remove readline hack.
126
127 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
128
129         * blockframe.c (find_pc_partial_function): Set *block to nullptr
130         when the function fails.
131
132 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
133
134         * s390-tdep.c (s390_type_align): New function.
135         (s390_gdbarch_init): Set it as type_align gdbarch method.
136
137 2019-08-09  Tom de Vries  <tdevries@suse.de>
138
139         PR gdb/24591
140         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
141         pc_low with relocation offset.
142
143 2019-08-07  Tom Tromey  <tromey@adacore.com>
144
145         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
146         (print_frame_args): Update.
147         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
148         Update.
149         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
150         * frame.h (struct frame_arg): Add initializers.
151         <error>: Now a unique_xmalloc_ptr.
152
153 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
154
155         * NEWS: Expand the Pointer Authentication entry.
156         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
157         (aarch64_frame_unmask_lr): ... to this.
158         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
159         Call aarch64_frame_unmask_lr.
160         * frame.c (struct frame_info): Add "masked" variable.
161         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
162         (fprint_frame): Check for masked pc.
163         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
164         declarations.
165         * python/py-framefilter.c (py_print_frame): Check for masked pc.
166         * stack.c (print_frame): Check for masked pc.
167
168 2019-08-06  Tom Tromey  <tom@tromey.com>
169
170         * stabsread.c (patch_block_stabs, read_one_struct_field)
171         (read_enum_type): Use obstack_strndup.
172         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
173         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
174         * dwarf2read.c (guess_full_die_structure_name)
175         (anonymous_struct_prefix): Use obstack_strndup.
176         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
177         * c-exp.y (yylex): Use obstack_strndup.
178         * ada-exp.y (write_object_renaming, write_ambiguous_var)
179         (write_var_or_type): Use obstack_strndup.
180
181 2019-08-06  Tom Tromey  <tom@tromey.com>
182
183         * symfile.c (reread_symbols): Use obstack_strdup.
184         * stabsread.c (read_type): Use obstack_strdup.
185         * gdb_obstack.h (obstack_strdup): New overload.
186         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
187         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
188         (dwarf2_canonicalize_name): Use obstack_strdup.
189         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
190         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
191         Use obstack_strdup.
192
193 2019-08-06  Tom Tromey  <tom@tromey.com>
194
195         * gdb_obstack.h (obstack_strdup): Define.
196         * gdb_obstack.c (obstack_strdup): Don't define.
197
198 2019-08-06  Tom Tromey  <tom@tromey.com>
199
200         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
201         obstack_strdup.
202         * typeprint.c (typedef_hash_table::find_global_typedef): Use
203         obstack_strdup.
204         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
205         * stabsread.c (common_block_start): Use obstack_strdup.
206         * objfiles.c (set_objfile_main_name, objfile): Use
207         obstack_strdup.
208         * namespace.c (add_using_directive): Use obstack_strdup.
209         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
210         * jit.c (finalize_symtab): Use obstack_strdup.
211         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
212         (guess_partial_die_structure_name, partial_die_info::fixup)
213         (dwarf2_name): Use obstack_strdup.
214         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
215         obstack_strdup.
216         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
217         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
218         obstack_strdup.
219         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
220
221 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
222
223         * unittests/help-doc-selftests.c: New file.
224         * Makefile.in: Add the new file.
225
226 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
227
228         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
229         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
230         the full first line, except when FOR_VALUE_PREFIX.  In this case,
231         the trailing '.' is not output, and the first character is uppercased.
232         (print_help_for_command): Update call to print_doc_line.
233         (print_doc_of_command): Likewise.
234         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
235         * cli/cli-option.c (append_indented_doc): Do not append newline.
236         (build_help_option): Append newline after first appended_indented_doc
237         only if a second call is done.
238         (build_help): Append 2 new lines before each option, except the first
239         one.
240         * compile/compile.c (_initialize_compile): Add new lines after
241         %OPTIONS%, when not at the end of the help.
242         Change help doc or code
243         producing the help doc to respect the invariants.
244         * maint-test-options.c (_initialize_maint_test_options): Likewise.
245         Also removed the new line after 'Options:', as all other commands
246         do not put an empty line between 'Options:' and the first option.
247         * printcmd.c (_initialize_printcmd): Likewise.
248         * stack.c (_initialize_stack): Likewise.
249         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
250         incorrectly telling COMMAND is optional.
251         * ada-lang.c (_initialize_ada_language): Change help doc or code
252         producing the help doc to respect the invariants.
253         * ada-tasks.c (_initialize_ada_tasks): Likewise.
254         * breakpoint.c (_initialize_breakpoint): Likewise.
255         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
256         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
257         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
258         * cli/cli-style.c (cli_style_option::add_setshow_commands,
259         _initialize_cli_style): Likewise.
260         * corelow.c (core_target_info): Likewise.
261         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
262         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
263         * filesystem.c (_initialize_filesystem): Likewise.
264         * frame.c (_initialize_frame): Likewise.
265         * gnu-nat.c (add_task_commands): Likewise.
266         * infcall.c (_initialize_infcall): Likewise.
267         * infcmd.c (_initialize_infcmd): Likewise.
268         * interps.c (_initialize_interpreter): Likewise.
269         * language.c (_initialize_language): Likewise.
270         * linux-fork.c (_initialize_linux_fork): Likewise.
271         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
272         * maint.c (_initialize_maint_cmds): Likewise.
273         * memattr.c (_initialize_mem): Likewise.
274         * printcmd.c (_initialize_printcmd): Likewise.
275         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
276         _RegEx): Likewise.
277         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
278         * record-btrace.c (_initialize_record_btrace): Likewise.
279         * record-full.c (_initialize_record_full): Likewise.
280         * record.c (_initialize_record): Likewise.
281         * regcache-dump.c (_initialize_regcache_dump): Likewise.
282         * regcache.c (_initialize_regcache): Likewise.
283         * remote.c (add_packet_config_cmd, init_remote_threadtests,
284         _initialize_remote): Likewise.
285         * ser-tcp.c (_initialize_ser_tcp): Likewise.
286         * serial.c (_initialize_serial): Likewise.
287         * skip.c (_initialize_step_skip): Likewise.
288         * source.c (_initialize_source): Likewise.
289         * stack.c (_initialize_stack): Likewise.
290         * symfile.c (_initialize_symfile): Likewise.
291         * symtab.c (_initialize_symtab): Likewise.
292         * target-descriptions.c (_initialize_target_descriptions): Likewise.
293         * top.c (init_main): Likewise.
294         * tracefile-tfile.c (tfile_target_info): Likewise.
295         * tracepoint.c (_initialize_tracepoint): Likewise.
296         * tui/tui-win.c (_initialize_tui_win): Likewise.
297         * utils.c (add_internal_problem_command): Likewise.
298         * valprint.c (value_print_option_defs): Likewise.
299
300 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
301
302         PR build/24886
303         * configure.ac: Drop enable-libmcheck support.
304         * configure, config.in: Rebuild.
305         * libmcheck.m4: Remove.
306         * acinclude.m4: Don't include it.
307         * Makefile.in: Don't distribute it.
308         * top.c (print_gdb_configuration): Don't mention it.
309
310 2019-08-06  Tom Tromey  <tom@tromey.com>
311
312         * utils.c (set_output_style): Sometimes pass stream to
313         emit_style_escape.
314         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
315         * record-btrace.c (btrace_insn_history): Update.
316         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
317         method.
318         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
319         Update initializers.
320         <m_uiout>: New field.
321         <m_di>: Move lower.
322         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
323         Remove "uiout" parameter.
324         (dump_insns): Update.
325         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
326         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
327
328 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
329
330         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
331         (error_in_psymtab_expansion): Likewise.
332         (lookup_symbol_via_quick_fns): Likewise.
333         (basic_lookup_transparent_type_quick): Likewise.
334         (basic_lookup_transparent_type_1): Likewise.
335
336 2019-08-06  Tom Tromey  <tromey@adacore.com>
337
338         * source.c (last_source_error): Now bool.
339         (print_source_lines_base): Make "noprint" bool.  Only open
340         source file when last_source_visited changes.
341
342 2019-08-06  Tom Tromey  <tromey@adacore.com>
343
344         * annotate.c (annotate_source_line): Use g_source_cache.
345         * source-cache.c (source_cache::get_plain_source_lines): Change
346         parameters.  Populate m_offset_cache.
347         (source_cache::ensure): New method.
348         (source_cache::get_line_charpos): New method.
349         (extract_lines): Move lower.  Change parameters.
350         (source_cache::get_source_lines): Move lower.
351         * source-cache.h (class source_cache): Update comment.
352         <get_line_charpos>: New method.
353         <get_source_lines>: Update comment.
354         <clear>: Clear m_offset_cache.
355         <get_plain_source_lines>: Change parameters.
356         <ensure>: New method
357         <m_offset_cache>: New member.
358         * source.c (forget_cached_source_info_for_objfile): Update.
359         (info_source_command): Use g_source_cache.
360         (find_source_lines, open_source_file_with_line_charpos): Remove.
361         (print_source_lines_base, search_command_helper): Use g_source_cache.
362         * source.h (open_source_file_with_line_charpos): Don't declare.
363         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
364         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
365         Use g_source_cache.
366
367 2019-08-06  Tom Tromey  <tromey@adacore.com>
368
369         * source-cache.c (source_cache::get_plain_source_lines):
370         Remove "first_line" and "last_line" parameters.
371         (source_cache::get_source_lines): Cache plain text.
372         * source-cache.h (class source_cache)
373         <get_plain_source_lines>: Update.
374
375 2019-08-06  Tom Tromey  <tromey@adacore.com>
376
377         * source-cache.c (extract_lines): No longer a method.
378         Changed type of parameter.  Include final newline.
379         (selftests::extract_lines_test): New function.
380         (_initialize_source_cache): Likewise.
381         * source-cache.h (class source_cache)
382         <extract_lines>: Don't declare.
383
384 2019-08-06  Tom Tromey  <tromey@adacore.com>
385
386         * breakpoint.c (init_breakpoint_sal): Update.
387         (breakpoint): Update.
388         * breakpoint.h (struct breakpoint) <filter>: Now a
389         unique_xmalloc_ptr.
390
391 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
392
393         * NEWS: Mention dictionary access on blocks.
394         * python/py-block.c (blpy_getitem): New function.
395         (block_object_as_mapping): New struct.
396         (block_object_type): Use new struct for tp_as_mapping field.
397
398 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
399
400         * objfiles.h (objfile): Add a comment describing partial symbols.
401
402 2019-08-05  Tom Tromey  <tromey@adacore.com>
403
404         * compile/compile.c (_initialize_compile): Use _(), not N_().
405         * thread.c (_initialize_thread): Use _(), not N_().
406         * stack.c (_initialize_stack): Use _(), not N_().
407         * printcmd.c (_initialize_printcmd): Use _(), not N_().
408
409 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
410
411         * dwarf2read.c (struct dw2_symtab_iterator):
412         <want_specific_block>: Remove.
413         <block_index>: Change type to gdb::optional.
414         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
415         change type of BLOCK_INDEX parameter to gdb::optional.
416         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
417         (dw2_lookup_symbol): Don't pass argument for
418         WANT_SPECIFIC_BLOCK.
419         (dw2_expand_symtabs_for_function): Don't pass argument for
420         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
421         (class dw2_debug_names_iterator)
422         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
423         parameter, change BLOCK_INDEX type to gdb::optional.
424         <m_want_specific_block>: Remove.
425         <m_block_index>: Change type to gdb::optional.
426         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
427         gdb::optional.  Re-write in function of gdb::optional.
428         (dw2_debug_names_lookup_symbol): Don't pass argument for
429         WANT_SPECIFIC_BLOCK.
430         (dw2_debug_names_expand_symtabs_for_function): Don't pass
431         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
432         BLOCK_INDEX.
433
434 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
435
436         * NEWS: Mention changes to "info sources" command.
437
438 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
439
440         * symtab.c (filename_partial_match_opts): New struct type.
441         (struct output_source_filename_data): New members
442         regexp, c_regexp, partial_match.
443         (output_source_filename): Use new members to decide to print file.
444         (info_sources_option_defs): New variable.
445         (make_info_sources_options_def_group, print_info_sources_header,
446         info_sources_command_completer):
447         New functions.
448         (info_sources_command): Read new optional arguments.
449         (_initialize_symtab): Update info sources help.
450
451 2019-08-02  Alexandre Oliva <oliva@adacore.com>
452
453         * ada-lang.c (exception_support_info_v0): Renamed from...
454         (default_exception_support_info): ... this.  Create new
455         definition for v1.
456         (ada_has_this_exception_support): Look up catch_handlers_sym.
457         (ada_exception_support_info_sniffer): Try v0 after default.
458
459 2019-08-01  Tom Tromey  <tromey@adacore.com>
460
461         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
462         gdbarch.h.
463
464 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
465
466         * s12z-tdep.c: Fix include path for s12z-opc.h.
467
468 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
469
470         * NEWS: Require GNU make 3.82.
471
472 2019-07-16  Tom Tromey  <tom@tromey.com>
473
474         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
475         declare.
476
477 2019-07-30  Tom Tromey  <tromey@adacore.com>
478
479         * block.c (contained_in): Remove BLOCK_FUNCTION check.
480
481 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
482
483         * printcmd.c (print_address_symbolic): Print negative offsets.
484         (build_address_symbolic): Force signed arithmetic when computing
485         offset.
486
487 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
488
489         PR/24474: Add a function to lookup static variables.
490         * NEWS: Mention this new function.
491         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
492         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
493         * python/python.c (python_GdbMethods): Add new function.
494
495 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
496
497         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
498         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
499         (objfpy_lookup_static_symbol): New function.
500         (objfile_object_methods): Add new functions.
501
502 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
503
504         * NEWS: Mention 'set|show print frame-info'.  Mention new
505         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
506         backtrace argument.  Mention that python frame filtering code
507         is now consistent with what 'backtrace' command prints.
508
509 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
510
511         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
512         comments.
513         (print_frame_info_auto, print_frame_info_source_line,
514         print_frame_info_location, print_frame_info_source_and_location,
515         print_frame_info_location_and_address, print_frame_info_short_location):
516         New declarations.
517         (struct frame_print_options): New member print_frame_info.
518         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
519         * stack.h (get_user_print_what_frame_info): New declaration.
520         (frame_show_address): New declaration.
521         * stack.c (print_frame_arguments_choices): New value 'presence'.
522         (print_frame_info_auto, print_frame_info_source_line,
523         print_frame_info_location, print_frame_info_source_and_location,
524         print_frame_info_location_and_address, print_frame_info_short_location,
525         print_frame_info_choices, print_frame_info_print_what): New definitions.
526         (print_frame_args): Only print dots for args if print frame-arguments
527         is 'presence'.
528         (frame_print_option_defs): New element for "frame-info".
529         (get_user_print_what_frame_info): New function.
530         (frame_show_address): Make non static.  Move comment to stack.h.
531         (print_frame_info_to_print_what): New function.
532         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
533         to decide what to print.
534         (backtrace_command_1): Handle the new print_frame_arguments_presence
535         value.
536         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
537         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
538         (py_print_frame): In non-mi mode, use LOCATION as default for
539         print_what, similarly to frame information printed directly by
540         backtrace command. Handle frame-info user option in non MI mode.
541
542 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
543
544         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
545         Add case for debugging 32-bit target on 64-bit host.  Revise
546         comment.
547
548 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
549
550         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
551         instead of find_function_entry_range_from_pc.
552
553 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
554
555         * stack.c (find_frame_funname): Remove code which preferred
556         minsym over symtab sym in "certain pathological cases".
557
558         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
559         parameter.  Change type of "do_demangle" to bool.
560         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
561         Pass suitable "prefer_sym_over_minsym" flag to
562         build_address_symbolic().  Don't output "+" for negative offsets.
563         * printcmd.c (print_address_symbolic): Update invocation of
564         build_address_symbolic to include a "prefer_sym_over_minsym"
565         flag.
566         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
567         Restrict cases in which use of minimal symbol is preferred to that
568         of a found symbol.  Update comments.
569
570         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
571         for entry pc when entry pc is out of range for that FDE.
572
573 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
574
575         PR gdb/24839:
576         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
577         type.
578
579 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
580
581         * python/py-objfile.c (add_separate_debug_file): Fix comment about
582         this function's Python signature.
583
584
585 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
586
587         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
588         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
589         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
590         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
591         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
592
593
594 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
595
596         * h8300-tdep.c (h8300_register_name_common): New.
597         h8300_register_name): Use h8300_register_name_common.
598         (h8300s_register_name): Likewise.
599         (h8300sx_register_name): Likewise.
600         (h8300h_register_nam): New.
601         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
602
603
604 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
605
606         * arm-tdep.c (arm_skip_cmse_entry): New function.
607         (arm_is_sgstubs_section): New function.
608         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
609
610 2019-07-22  Tom Tromey  <tom@tromey.com>
611
612         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
613         Don't self-assign.
614
615 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
616
617         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
618         type_print.
619
620 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
621
622         * symtab.c (search_symbols): Adjust msymbol matching type arrays
623         so that GDB doesn't match any msymbols when searching in the
624         TYPES_DOMAIN.
625         (print_symbol_info): Print using typedef_print or type_print based
626         on the type of the symbol.  Add updated FIXME comment moved from...
627         (_initialize_symtab): ... move and update FIXME comment to above.
628
629 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
630
631         * NEWS: Mention adding -q option to "info types".
632         * symtab.c (struct info_types_options): New struct.
633         (info_types_options_defs): New variable.
634         (make_info_types_options_def_group): New function.
635         (info_types_command): Use gdb::option framework to parse options.
636         (info_types_command_completer): New function.
637         (_initialize_symtab): Extend the help text on "info types" and
638         register command completer.
639
640 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
641
642         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
643         (lookup_symbol_in_objfile): Change int to block_enum and add a
644         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
645
646 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
647
648         * MAINTAINERS (Write After Approval): Add self.
649
650 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
651
652         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
653         instruction to the dummy code region.
654
655 2019-07-19  Tom Tromey  <tromey@adacore.com>
656
657         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
658         (ARGSUSED, PARAMS, __func__): Remove rules.
659
660 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
661
662         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
663         * features/arm/arm-with-iwmmxt.c: Remove.
664         * features/arm/arm-with-iwmmxt.xml: Remove.
665         * features/arm/arm-with-m-fpa-layout.c: Remove.
666         * features/arm/arm-with-m-fpa-layout.xml: Remove.
667         * features/arm/arm-with-m-vfp-d16.c: Remove.
668         * features/arm/arm-with-m-vfp-d16.xml: Remove.
669         * features/arm/arm-with-m.c: Remove.
670         * features/arm/arm-with-m.xml: Remove.
671         * features/arm/arm-with-neon.c: Remove.
672         * features/arm/arm-with-neon.xml: Remove.
673         * features/arm/arm-with-vfpv2.c: Remove.
674         * features/arm/arm-with-vfpv2.xml: Remove.
675         * features/arm/arm-with-vfpv3.c: Remove.
676         * features/arm/arm-with-vfpv3.xml: Remove.
677
678 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
679
680         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
681
682 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
683
684         * arch/aarch32.c (aarch32_create_target_description): Create
685         target descriptions using features.
686         * arch/arm.c (arm_create_target_description)
687         (arm_create_mprofile_target_description): Likewise.
688         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
689
690 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
691
692         * Makefile.in: Add new files.
693         * aarch32-tdep.c: New file.
694         * aarch32-tdep.h: New file.
695         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
696         Call aarch32_read_description.
697         * arch/aarch32.c: New file.
698         * arch/aarch32.h: New file.
699         * arch/arm.c (arm_create_target_description)
700         (arm_create_mprofile_target_description): New function.
701         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
702         (arm_create_target_description)
703         (arm_create_mprofile_target_description): New declaration.
704         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
705         read_description functions.
706         * arm-linux-nat.c (arm_linux_nat_target::read_description):
707         Likewise.
708         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
709         * arm-tdep.c (tdesc_arm_list): New variable.
710         (arm_register_g_packet_guesses): Call create description functions.
711         (arm_read_description) (arm_read_mprofile_description): New
712         function.
713         * arm-tdep.h (arm_read_description)
714         (arm_read_mprofile_description): Add declaration.
715         * configure.tgt: Add new files.
716
717 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
718
719         * top.c (new_ui_command): Open specified terminal just once.
720
721 2019-07-18  Tom Tromey  <tromey@adacore.com>
722
723         * symtab.c (main_name): Constify return type.
724         * symfile.c (set_initial_language): Update.
725         * symtab.h (main_name): Constify return type.
726
727 2019-07-17  Tom Tromey  <tom@tromey.com>
728
729         * tui/tui-winsource.c (tui_update_source_window)
730         (tui_update_source_window_as_is)
731         (tui_update_source_windows_with_line): Remove return.
732         * tui/tui-disasm.c (tui_show_disassem)
733         (tui_show_disassem_and_update_source): Remove return.
734         * tui/tui.c (tui_reset): Remove return.
735         * tui/tui-wingeneral.c
736         (tui_check_and_display_highlight_if_needed): Remove return.
737
738 2019-07-17  Tom Tromey  <tom@tromey.com>
739
740         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
741
742 2019-07-17  Tom Tromey  <tom@tromey.com>
743
744         * tui/tui-winsource.h (struct tui_exec_info_window)
745         (struct tui_source_window_base): Move from tui-data.h.
746         * tui/tui-winsource.c: Move many method definitions from
747         elsewhere.  Remove "structuring" comments.
748         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
749         (tui_source_window_base::refresh_window): Move to
750         tui-winsource.c.
751         * tui/tui-win.c (tui_source_window_base::refresh_all)
752         (tui_source_window_base::update_tab_width)
753         (tui_source_window_base::set_new_height)
754         (tui_source_window_base::do_make_visible_with_new_height): Move to
755         tui-winsource.c.
756         * tui/tui-source.h: Update.
757         * tui/tui-source.c (tui_source_window_base::reset): Move to
758         tui-winsource.c.
759         * tui/tui-disasm.h: Update.
760         * tui/tui-data.h (struct tui_exec_info_window): Move to
761         tui-winsource.h.
762         (struct tui_source_window_base): Likewise.
763         * tui/tui-data.c (tui_source_window_base::clear_detail)
764         (tui_source_window_base, ~tui_source_window_base): Move to
765         tui-winsource.c.
766
767 2019-07-17  Tom Tromey  <tom@tromey.com>
768
769         * tui/tui-win.c (tui_resize_all)
770         (tui_source_window_base::update_tab_width)
771         (tui_adjust_win_heights): Update.
772         (tui_win_info::make_invisible_and_set_new_height): Rename from
773         make_invisible_and_set_new_height.
774         * tui/tui-data.h (struct tui_win_info)
775         <make_invisible_and_set_new_height>: New method.
776
777 2019-07-17  Tom Tromey  <tom@tromey.com>
778
779         * tui/tui.c: Update.
780         * tui/tui-source.h (struct tui_source_window): Move from
781         tui-data.h.
782         * tui/tui-layout.c: Update.
783         * tui/tui-disasm.c: Update.
784         * tui/tui-data.h (struct tui_source_window): Move to
785         tui-source.h.
786
787 2019-07-17  Tom Tromey  <tom@tromey.com>
788
789         * tui/tui-disasm.h (struct tui_disasm_window): Move from
790         tui-data.h.
791         * tui/tui-data.h (struct tui_disasm_window): Move to
792         tui-disasm.h.
793
794 2019-07-17  Tom Tromey  <tom@tromey.com>
795
796         * tui/tui-regs.h (struct tui_data_item_window): Move from
797         tui-data.h.
798         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
799         * tui/tui-data.h (struct tui_data_item_window): Move to
800         tui-regs.h.
801         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
802
803 2019-07-17  Tom Tromey  <tom@tromey.com>
804
805         * tui/tui.c: Update.
806         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
807         (tui_cmd_window::max_height): Move to tui-command.c.
808         * tui/tui-layout.c: Update.
809         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
810         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
811         tui-command.c.
812         * tui/tui-command.h (struct tui_cmd_window): Move from
813         tui-data.h.
814         * tui/tui-command.c: Remove "structuring" comments.
815         (tui_cmd_window::clear_detail)
816         (tui_cmd_window::do_make_visible_with_new_height)
817         (tui_cmd_window::max_height): Move from elsewhere.
818
819 2019-07-17  Tom Tromey  <tom@tromey.com>
820
821         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
822         Now static.
823         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
824         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
825
826 2019-07-17  Tom Tromey  <tom@tromey.com>
827
828         * tui/tui.c: Update.
829         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
830         tui-regs.c.
831         * tui/tui-windata.h: Remove file.
832         * tui/tui-windata.c: Remove file.
833         * tui/tui-win.c (tui_data_window::set_new_height)
834         (tui_data_window::do_make_visible_with_new_height): Move to
835         tui-regs.c.
836         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
837         * tui/tui-regs.c: Remove "structuring" comments.
838         (tui_data_window::first_data_item_displayed)
839         (tui_data_window::delete_data_content_windows)
840         (tui_data_window::erase_data_content)
841         (tui_data_window::display_all_data)
842         (tui_data_window::refresh_all)
843         (tui_data_window::do_scroll_vertical)
844         (tui_data_window::clear_detail, tui_data_window::set_new_height)
845         (tui_data_window::do_make_visible_with_new_height)
846         (tui_data_window::refresh_window): Move from elsewhere.
847         (_initialize_tui_regs): Move to end of file.
848         * tui/tui-layout.c: Update.
849         * tui/tui-hooks.c: Update.
850         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
851         * tui/tui-data.c (tui_data_window::clear_detail): Move to
852         tui-regs.c.
853         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
854
855 2019-07-17  Tom Tromey  <tom@tromey.com>
856
857         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
858         seen.
859
860 2019-07-17  Tom Tromey  <tom@tromey.com>
861
862         * tui/tui-win.c (tui_source_window_base::set_new_height)
863         (tui_source_window_base::do_make_visible_with_new_height): Use
864         m_has_locator field directly.
865         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
866         method.
867         (struct tui_source_window_base) <has_locator>: Likewise.
868
869 2019-07-17  Tom Tromey  <tom@tromey.com>
870
871         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
872         Don't declare.
873         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
874         Remove.
875         * tui/tui-win.c (tui_source_window_base::set_new_height)
876         (tui_source_window_base::set_new_height)
877         (make_invisible_and_set_new_height)
878         (tui_source_window_base::do_make_visible_with_new_height)
879         (tui_source_window_base::do_make_visible_with_new_height):
880         Update.
881         * tui/tui-layout.c (show_source_disasm_command, show_data)
882         (show_source_or_disasm_and_command): Update.
883         * tui/tui-layout.c (show_layout): Update.
884
885 2019-07-17  Tom Tromey  <tom@tromey.com>
886
887         * tui/tui-layout.c (make_data_window): Remove.
888         (show_data): Unify creation and re-initialization cases.
889
890 2019-07-17  Tom Tromey  <tom@tromey.com>
891
892         * tui/tui-layout.c (make_source_window, make_disasm_window):
893         Remove.
894         (show_data): Unify creation and re-initialization cases.
895
896 2019-07-17  Tom Tromey  <tom@tromey.com>
897
898         * tui/tui-layout.c (make_command_window): Remove.
899         (show_source_disasm_command, show_source_or_disasm_and_command):
900         Unify creation and re-initialization cases.
901
902 2019-07-17  Tom Tromey  <tom@tromey.com>
903
904         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
905         creation and re-initialization cases.
906
907 2019-07-17  Tom Tromey  <tom@tromey.com>
908
909         * tui/tui-regs.c (tui_get_register): Return void.
910
911 2019-07-17  Tom Tromey  <tom@tromey.com>
912
913         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
914         Simplify.
915
916 2019-07-17  Tom Tromey  <tom@tromey.com>
917
918         * tui/tui-layout.c (show_source_disasm_command): Simplify window
919         resetting.
920
921 2019-07-17  Tom Tromey  <tom@tromey.com>
922
923         * tui/tui.h (tui_set_layout_by_name): Don't declare.
924         * tui/tui-regs.c (tui_reg_layout): New function.
925         (tui_show_registers, tui_reg_command): Use it.
926         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
927         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
928         parameters.
929         (tui_layout_command): Remove.
930
931 2019-07-17  Tom Tromey  <tom@tromey.com>
932
933         * tui/tui-layout.h (tui/tui-layout): Return void.
934         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
935
936 2019-07-17  Tom Tromey  <tom@tromey.com>
937
938         * tui/tui-layout.c (show_source_disasm_command, show_data):
939         Update.
940         (reset_locator): Remove.
941         (show_source_or_disasm_and_command): Update.
942
943 2019-07-17  Tom Tromey  <tom@tromey.com>
944
945         * tui/tui-source.c (tui_source_window_base::reset): Remove
946         win_type parameter.
947         * tui/tui-layout.c (make_command_window, make_source_window)
948         (make_disasm_window, make_data_window)
949         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
950         (reset_locator, show_source_or_disasm_and_command): Update.
951         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
952         win_type parameter.
953         (struct tui_source_window_base) <reset>: Likewise.
954
955 2019-07-17  Tom Tromey  <tom@tromey.com>
956
957         * tui/tui-layout.c (show_source_disasm_command): Use
958         reset_locator.
959         (reset_locator): New function.
960         (init_and_make_win): Remove.
961         (show_source_or_disasm_and_command): Use reset_locator.
962
963 2019-07-17  Tom Tromey  <tom@tromey.com>
964
965         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
966         condition.
967         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
968         Remove condition.
969         * tui/tui-source.c (tui_source_window_base::reset): New method.
970         * tui/tui-layout.c (make_command_window): Don't call
971         init_and_make_win.
972         (make_source_window, make_disasm_window): Don't call
973         make_source_or_disasm_window.
974         (make_data_window): Don't call init_and_make_win.  Change calling
975         convention.
976         (show_source_disasm_command, show_data): Simplify.
977         (make_source_or_disasm_window): Remove.
978         (show_source_or_disasm_and_command): Simplify.
979         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
980         (struct tui_source_window_base) <reset>: Likewise.
981         <execution_info>: Remove initializer.
982         * tui/tui-data.c (tui_source_window_base): Initialize
983         execution_info.
984
985 2019-07-17  Tom Tromey  <tom@tromey.com>
986
987         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
988         variable.
989
990 2019-07-17  Tom Tromey  <tom@tromey.com>
991
992         * tui/tui.c (tui_rl_other_window): Update.
993         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
994         superclass method first.  Always iterate over regs_content.
995         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
996         method.
997         * tui/tui-win.c (tui_set_focus_command): Update.
998
999 2019-07-17  Tom Tromey  <tom@tromey.com>
1000
1001         * tui/tui-win.c (tui_set_focus_command): Rename from
1002         tui_set_focus.  Call tui_enable.
1003         (tui_set_focus_command): Remove.
1004
1005 2019-07-17  Tom Tromey  <tom@tromey.com>
1006
1007         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1008         refresh_window.
1009         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1010         touchwin.
1011         (tui_data_window::refresh_window): Call refresh_window on data
1012         items.  Always call superclass refresh_window.
1013         (tui_win_info::refresh): Remove.
1014         (tui_source_window_base::refresh_window): Update.
1015         (tui_refresh_all): Update.
1016         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1017         refresh_window.
1018         (show_source_or_disasm_and_command): Likewise.
1019         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1020         (struct tui_source_window_base) <refresh>: Likewise.
1021
1022 2019-07-17  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui-winsource.c (tui_clear_source_content)
1025         (tui_show_source_content): Update.
1026         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1027         whether content is empty.
1028         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1029         Remove.
1030
1031 2019-07-17  Tom Tromey  <tom@tromey.com>
1032
1033         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1034         window's contents.
1035         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1036         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1037
1038 2019-07-17  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1041         (struct tui_data_item_window): Update.
1042
1043 2019-07-17  Tom Tromey  <tom@tromey.com>
1044
1045         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1046         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1047         defines.
1048
1049 2019-07-17  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-winsource.h (tui_erase_source_content)
1052         (tui_clear_source_content): Remove "display_prompt" parameter.
1053         * tui/tui-winsource.c (tui_update_source_window_as_is)
1054         (tui_update_source_windows_with_addr): Update.
1055         (tui_clear_source_content): Remove "display_prompt" parameter.
1056         (tui_erase_source_content): Likewise.  Simplify.
1057         (tui_show_source_content): Update.
1058         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1059         * tui/tui-stack.c (tui_show_frame_info): Update.
1060         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1061         Remove defines.
1062
1063 2019-07-17  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1066         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1067         parameter.
1068         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1069         parameter.
1070
1071 2019-07-17  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui-winsource.c (tui_clear_source_content)
1074         (tui_show_source_content, tui_show_exec_info_content)
1075         (tui_clear_exec_info_content): Update.
1076         * tui/tui-stack.c (tui_show_locator_content): Update.
1077         (tui_show_frame_info): Update.
1078         * tui/tui-source.h (tui_source_window): Don't declare.
1079         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1080         from tui_source_is_displayed.
1081         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1082         Remove field.
1083         (struct tui_source_window_base) <content_in_use>: New field.  Now
1084         bool.
1085         (struct tui_source_window) <showing_source_p>: New method.
1086         (TUI_SRC_WIN): Change cast.
1087         * tui/tui-data.c (tui_initialize_static_data): Update.
1088
1089 2019-07-17  Tom Tromey  <tom@tromey.com>
1090
1091         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1092         location_matches_p.
1093         * tui/tui-source.c (tui_source_window::location_matches_p): New
1094         method.
1095         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1096         method.
1097         * tui/tui-data.h (struct tui_source_window_base)
1098         <location_matches_p>: New method.
1099         (struct tui_source_window, struct tui_disasm_window)
1100         <location_matches_p>: Likewise.
1101
1102 2019-07-17  Tom Tromey  <tom@tromey.com>
1103
1104         * tui/tui-win.c (tui_set_win_height_command): Rename from
1105         tui_set_win_height.
1106         (tui_set_win_height_command): Remove.
1107
1108 2019-07-17  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-source.c (tui_source_window): New constructor.  Add
1111         observer.
1112         (~tui_source_window): New destructor.
1113         (tui_source_window::style_changed): New method.
1114         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1115         (tui_attach_detach_observers): Update.
1116         * tui/tui-data.h (struct tui_source_window): Make constructor not
1117         inline.  Add destructor.
1118         (struct tui_source_window) <style_changed>: New method.
1119         <m_observable>: New member.
1120
1121 2019-07-17  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1124         * tui/tui-win.c (tui_resize_all): Fix typo.
1125
1126 2019-07-17  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1129         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1130         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1131         * tui/tui-win.c (window_name_completer): Use foreach.
1132         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1133         (update_tab_width): Likewise.
1134         * tui/tui-layout.c (show_layout): Update.
1135         * tui/tui-data.h (class tui_window_iterator): New.
1136         (struct all_tui_windows): New.
1137         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1138
1139 2019-07-17  Tom Tromey  <tom@tromey.com>
1140
1141         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1142         parameter.  Don't reference globals.
1143         (tui_reg_command): Update.
1144
1145 2019-07-17  Tom Tromey  <tom@tromey.com>
1146
1147         * tui/tui-regs.c (tui_show_registers): Simplify.
1148
1149 2019-07-17  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui-regs.c (tui_show_registers): Update.
1152         (tui_show_register_group): Add win_info parameter.
1153
1154 2019-07-17  Tom Tromey  <tom@tromey.com>
1155
1156         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1157         Rename from tui_display_reg_element_at_line.
1158         (tui_data_window::display_registers_from_line): Update.
1159         * tui/tui-data.h (struct tui_data_window)
1160         <display_reg_element_at_line>: New method.
1161
1162 2019-07-17  Tom Tromey  <tom@tromey.com>
1163
1164         * tui/tui-regs.h (tui_display_registers_from)
1165         (tui_display_registers_from_line): Don't declare.
1166         * tui/tui-windata.c (tui_data_window::display_all_data)
1167         (tui_data_window::refresh_all)
1168         (tui_data_window::do_scroll_vertical): Update.
1169         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1170         from tui_display_registers_from.
1171         (tui_display_reg_element_at_line): Update.
1172         (tui_data_window::display_registers_from_line): Rename from
1173         tui_display_registers_from_line.
1174         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1175         display_registers_from_line>: New methods.
1176
1177 2019-07-17  Tom Tromey  <tom@tromey.com>
1178
1179         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1180         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1181         from tui_erase_data_content.
1182         (tui_data_window::display_all_data)
1183         (tui_data_window::refresh_all)
1184         (tui_data_window::do_scroll_vertical): Update.
1185         * tui/tui-regs.c (tui_show_registers): Update.
1186         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1187         New method.
1188
1189 2019-07-17  Tom Tromey  <tom@tromey.com>
1190
1191         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1192         declare.
1193         * tui/tui-windata.c
1194         (tui_data_window::delete_data_content_windows): Rename from
1195         tui_delete_data_content_windows.
1196         (tui_data_window::display_all_data)
1197         (tui_data_window::do_scroll_vertical): Update.
1198         * tui/tui-data.h (struct tui_data_window)
1199         <delete_data_content_windows>: New method.
1200
1201 2019-07-17  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1204         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1205
1206 2019-07-17  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1209         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1210         from tui_display_all_data.
1211         * tui/tui-win.c
1212         (tui_data_window::do_make_visible_with_new_height): Update.
1213         * tui/tui-regs.c (tui_show_registers): Update.
1214         * tui/tui-layout.c (tui_set_layout): Update.
1215         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1216         method.
1217
1218 2019-07-17  Tom Tromey  <tom@tromey.com>
1219
1220         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1221         * tui/tui-windata.c (tui_display_data_from): Remove.
1222         (tui_data_window::refresh_all): Update.
1223
1224 2019-07-17  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1227         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1228         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1229         tui_display_registers_from_line.
1230         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1231         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1232         "force_display" parameter.
1233
1234 2019-07-17  Tom Tromey  <tom@tromey.com>
1235
1236         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1237         declare.
1238         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1239         Rename from tui_first_reg_element_no_inline.
1240         (tui_display_reg_element_at_line)
1241         (tui_display_registers_from_line): Update.
1242         * tui/tui-data.h (struct tui_data_window)
1243         <first_reg_element_no_inline>: New method.
1244
1245 2019-07-17  Tom Tromey  <tom@tromey.com>
1246
1247         * tui/tui-windata.c (tui_display_data_from)
1248         (tui_data_window::do_scroll_vertical): Update.
1249         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1250         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1251         Rename from tui_line_from_reg_element_no.
1252         (tui_display_registers_from_line): Update.
1253         * tui/tui-data.h (struct tui_data_window)
1254         <line_from_reg_element_no>: New method.
1255
1256 2019-07-17  Tom Tromey  <tom@tromey.com>
1257
1258         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1259         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1260         tui_last_regs_line_no.
1261         (tui_display_reg_element_at_line)
1262         (tui_display_registers_from_line): Update.
1263         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1264         method.
1265
1266 2019-07-17  Tom Tromey  <tom@tromey.com>
1267
1268         PR tui/24722:
1269         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1270         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1271         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1272         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1273         (tui_update_breakpoint_info): Likewise.
1274         * tui/tui-hooks.c (tui_event_create_breakpoint)
1275         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1276         Update.
1277
1278 2019-07-17  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1281
1282 2019-07-17  Tom Tromey  <tom@tromey.com>
1283
1284         * tui/tui-winsource.c (tui_update_source_window_as_is)
1285         (tui_update_source_windows_with_addr): Update.
1286         * tui/tui-source.h (tui_set_source_content)
1287         (tui_show_symtab_source): Add "win_info" parameter.
1288         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1289         parameter.
1290         (tui_show_symtab_source): Likewise.
1291
1292 2019-07-17  Tom Tromey  <tom@tromey.com>
1293
1294         * tui/tui-wingeneral.c
1295         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1296
1297 2019-07-17  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1300         (struct tui_cmd_window) <can_scroll>: New method.
1301         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1302         method.
1303
1304 2019-07-17  Tom Tromey  <tromey@adacore.com>
1305
1306         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1307         do_field_signed>: Rename.  Change type of "value".
1308         * ui-out.c (ui_out::field_signed): Rename from field_int.
1309         Change type of "value".
1310         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1311         type of "value".
1312         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1313         do_field_int.  Change type of "value".
1314         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1315         do_field_int.  Change type of "value".
1316         * tracepoint.c (trace_status_mi, tfind_1)
1317         (print_one_static_tracepoint_marker): Update.
1318         * thread.c (print_thread_info_1, print_selected_thread_frame):
1319         Update.
1320         * stack.c (print_frame, print_frame_info): Update.
1321         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1322         Update.
1323         * source.c (print_source_lines_base): Update.
1324         * skip.c (info_skip_command): Update.
1325         * record-btrace.c (btrace_ui_out_decode_error)
1326         (btrace_call_history_src_line): Update.
1327         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1328         Update.
1329         * progspace.c (print_program_space): Update.
1330         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1331         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1332         do_field_int.  Change type of "value".
1333         * mi/mi-out.c (mi_ui_out::do_table_begin)
1334         (mi_ui_out::do_table_header): Update.
1335         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1336         type of "value".
1337         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1338         (mi_cmd_data_list_changed_registers, output_register)
1339         (mi_cmd_data_read_memory, mi_load_progress)
1340         (mi_cmd_trace_frame_collected): Update.
1341         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1342         Update.
1343         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1344         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1345         (mi_cmd_var_list_children, varobj_update_one): Update.
1346         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1347         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1348         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1349         * inferior.c (print_inferior): Update.
1350         * gdb_bfd.c (print_one_bfd): Update.
1351         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1352         Update.
1353         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1354         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1355         do_field_int.  Change type of "value".
1356         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1357         do_field_int.  Change type of "value".
1358         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1359         (print_one_breakpoint_location, print_it_catch_fork)
1360         (print_one_catch_fork, print_it_catch_vfork)
1361         (print_one_catch_vfork, print_it_catch_solib)
1362         (print_it_catch_exec, print_it_ranged_breakpoint)
1363         (print_mention_watchpoint, print_mention_masked_watchpoint)
1364         (bkpt_print_it, update_static_tracepoint): Update.
1365         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1366         * break-catch-syscall.c (print_it_catch_syscall): Update.
1367         * ada-tasks.c (print_ada_task_info): Update.
1368         * ada-lang.c (print_it_exception, print_mention_exception):
1369         Update.
1370
1371 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         PR breakpoints/24541
1374         * gdbarch.c: Regenerate.
1375         * gdbarch.h: Regenerate.
1376         * gdbarch.sh: Adjust return type and parameter types for
1377         'stap_adjust_register'.
1378         (i386_stap_adjust_register): Adjust signature and return new
1379         register name.
1380         * stap-probe.c (stap_parse_register_operand): Adjust use of
1381         'gdbarch_stap_adjust_register'.
1382
1383 2019-07-17  Tom Tromey  <tromey@adacore.com>
1384
1385         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1386         declare VEC.
1387         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1388         std::vector.
1389         (struct s390_process_info): Add initializers.
1390         (s390_add_process): Use new.
1391         (s390_linux_nat_target::low_forget_process): Use delete.
1392         (s390_linux_nat_target::low_new_fork)
1393         (s390_linux_nat_target::stopped_by_watchpoint)
1394         (s390_linux_nat_target::low_prepare_to_resume)
1395         (s390_linux_nat_target::insert_watchpoint)
1396         (s390_linux_nat_target::insert_hw_breakpoint)
1397         (s390_linux_nat_target::remove_watchpoint)
1398         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1399
1400 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1401
1402         * aarch64-fbsd-nat.c: Include regcache.h.
1403         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1404         argument.
1405         (aarch64_fbsd_nat_target::fetch_registers)
1406         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1407         variable.
1408         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1409
1410 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1411
1412         * fbsd-nat.c: Include gdbarch.h.
1413
1414 2019-07-15  Tom Tromey  <tromey@adacore.com>
1415
1416         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1417
1418 2019-07-15  Tom Tromey  <tromey@adacore.com>
1419
1420         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1421         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1422         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1423         * cli-out.c (cli_ui_out::do_field_int): New method.
1424         * ui-out.c (ui_out::field_unsigned): New method.
1425         * symfile.c (generic_load): Use field_unsigned.
1426         (print_transfer_performance): Likewise.
1427         * record-btrace.c (ui_out_field_uint): Remove.
1428         (btrace_call_history_insn_range, btrace_call_history): Use
1429         field_unsigned.
1430         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1431         field_unsigned.
1432         * ui-out.h (class ui_out) <field_unsigned>: New method.
1433         <do_field_unsigned>: Likewise.
1434
1435 2019-07-15  Tom Tromey  <tromey@adacore.com>
1436
1437         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1438         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1439         * target.c (flash_erase_command): Use field_string.
1440         * infrun.c (print_signal_received_reason): Use field_string.
1441         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1442         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1443         field_string.
1444         * ada-tasks.c (print_ada_task_info): Use field_string.
1445
1446 2019-07-15  Tom Tromey  <tromey@adacore.com>
1447
1448         * target.c (flash_erase_command): Use field_core_addr.
1449         * symfile.c (generic_load): Use field_core_addr.
1450         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1451         Use field_core_addr.
1452         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1453         field_core_addr.
1454
1455 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1456
1457         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1458         value if its desired type is smaller than a CORE_ADDR and signed.
1459
1460 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1461
1462         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1463         of changes to field names, and use new is_reference field to
1464         decide if a property is a reference or not.
1465         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1466         field.
1467         (struct dwarf2_property_baton): Update header comment, rename
1468         'referenced_type' to 'property_type' and update comments.
1469         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1470         default property type, store in property baton, update to take
1471         accound of renamed field.
1472         (read_func_scope): Update call to attr_to_dynamic_prop.
1473         (read_array_type): Likewise.
1474         (dwarf2_per_cu_addr_sized_int_type): New function.
1475         (read_subrange_index_type): Move type finding code to
1476         dwarf2_per_cu_addr_sized_int_type.
1477         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1478         (dwarf2_per_cu_addr_type): New function.
1479         (set_die_type): Update calls to attr_to_dynamic_prop.
1480
1481 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1482
1483         * dwarf2read.c (read_subrange_index_type): New function.
1484         (read_subrange_type): Move code into new function and call it.
1485         * gdbtypes.c (create_range_type): Add some asserts.
1486
1487 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1488
1489         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1490         update return statements.
1491         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1492         declaration, and update comment to match.
1493         * gdbtypes.c (resolve_dynamic_array): Update call to
1494         dwarf2_evaluate_property to match new return type.
1495
1496 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1497
1498         * valarith.c (value_subscripted_rvalue): Change lowerbound
1499         parameter type from int to LONGEST.
1500         * value.h (value_subscripted_rvalue): Likewise in declaration.
1501
1502 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1503
1504         * cli/cli-utils.c (info_print_command_completer): New function.
1505         * cli/cli-utils.h: Add 'completer.h' include, and forward
1506         declaration for 'struct cmd_list_element'.
1507         (info_print_command_completer): Declare.
1508         * stack.c (_initialize_stack): Add completer for 'info locals' and
1509         'info args'.
1510         * symtab.c (_initialize_symtab): Add completer for 'info
1511         variables' and 'info functions'.
1512         * NEWS: Mention completion for additional info commands.
1513
1514 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1515
1516         * cli/cli-utils.c (extract_info_print_args): Delete.
1517         (extract_arg_maybe_quoted): Delete.
1518         (info_print_options_defs): New variable.
1519         (make_info_print_options_def_group): New function.
1520         (extract_info_print_options): Define new function.
1521         * cli/cli-utils.h (extract_info_print_args): Delete.
1522         (struct info_print_options): New structure.
1523         (extract_info_print_options): Declare new function.
1524         * stack.c (info_locals_command): Update to use new
1525         extract_info_print_options, also add a header comment.
1526         (info_args_command): Likewise.
1527         * symtab.c (info_variables_command): Likewise.
1528         (info_functions_command): Likewise.
1529
1530 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1531
1532         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1533         to extract string arguments.
1534         * common/common-utils.c (extract_string_maybe_quoted): New function.
1535         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1536
1537 2019-07-11  Tom Tromey  <tromey@adacore.com>
1538
1539         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1540         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1541         * top.h (gdbinit): Don't declare.
1542         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1543         into...
1544         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1545         * top.c (gdb_init): Don't call init_cli_cmds.
1546         (gdbinit): Remove.
1547         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1548
1549 2019-07-11  Tom Tromey  <tromey@adacore.com>
1550
1551         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1552         after it has been moved.
1553
1554 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1555
1556         * valops.c (value_must_coerce_to_target): Change return type to
1557         bool.
1558         * value.h (value_must_coerce_to_target): Likewise.
1559
1560 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1561
1562         * breakpoint.c (is_hardware_watchpoint): Remove
1563         forward-declaration.
1564         (is_masked_watchpoint): Change return type to bool.
1565         (is_tracepoint): Likewise.
1566         (is_breakpoint): Likewise.
1567         (is_hardware_watchpoint): Likewise.
1568         (is_watchpoint): Likewise.
1569         (is_no_memory_software_watchpoint): Likewise.
1570         (is_catchpoint): Likewise.
1571         (breakpoint_1): Make FILTER parameter's return type bool.
1572         is_masked_watchpoint): Change return type to bool.
1573         (save_breakpoints): Make FILTER parameter's return type bool.
1574         * breakpoint.h (is_breakpoint): Change return type to bool.
1575         (is_watchpoint): Likewise.
1576         (is_catchpoint): Likewise.
1577         (is_tracepoint): Likewise.
1578
1579 2019-07-10  Tom Tromey  <tom@tromey.com>
1580
1581         * defs.h: Don't include gdbarch.h.
1582         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1583         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1584         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1585         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1586         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1587         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1588         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1589         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1590         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1591         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1592         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1593         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1594         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1595         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1596         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1597         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1598         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1599         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1600         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1601         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1602         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1603         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1604         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1605         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1606         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1607         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1608         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1609
1610 2019-07-10  Tom Tromey  <tromey@adacore.com>
1611
1612         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1613         * breakpoint.c (init_ada_exception_breakpoint): Register as
1614         bp_catchpoint.
1615         (print_one_breakpoint_location, print_one_breakpoint): Use
1616         is_ada_exception_catchpoint.
1617         * ada-lang.c (class ada_catchpoint_location): Pass
1618         bp_loc_software_breakpoint to bp_location constructor.
1619         (is_ada_exception_catchpoint): New function.
1620
1621 2019-07-10  Tom Tromey  <tromey@adacore.com>
1622
1623         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1624         VEC.
1625         (struct arm_exidx_entry): New method operator<.
1626         (struct arm_exidx_data) <section_maps>: Change type.
1627         (arm_exidx_data_free): Remove.
1628         (arm_exidx_data_key): Change type.  Move lower.
1629         (arm_exidx_new_objfile): Update.
1630         (arm_compare_exidx_entries): Remove.
1631         (arm_find_exidx_entry, _initialize_arm_tdep)
1632
1633 2019-07-10  Tom Tromey  <tromey@adacore.com>
1634
1635         * solib-spu.c (ocl_program_data_key): Change type.
1636         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1637         Update.
1638
1639 2019-07-10  Tom Tromey  <tromey@adacore.com>
1640
1641         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1642         (struct solib_aix_inferior_data) <library_list>: Change type.
1643         (solib_aix_inferior_data_handle): Change type.
1644         (get_solib_aix_inferior_data): Update.
1645         (solib_aix_free_library_list): Remove.
1646         (library_list_start_library): Update.
1647         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1648         return type.
1649         (solib_aix_get_library_list)
1650         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1651         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1652
1653 2019-07-10  Tom Tromey  <tromey@adacore.com>
1654
1655         * solib-dsbt.c (struct dsbt_info): Add initializers.
1656         (solib_dsbt_pspace_data): Change type.
1657         (dsbt_pspace_data_cleanup): Remove.
1658         (get_dsbt_info, _initialize_dsbt_solib): Update.
1659
1660 2019-07-10  Tom Tromey  <tromey@adacore.com>
1661
1662         * spu-tdep.c (spu_overlay_data): Change type.
1663         (spu_get_overlay_table, spu_overlay_new_objfile)
1664         (_initialize_spu_tdep): Update.
1665
1666 2019-07-10  Tom Tromey  <tromey@adacore.com>
1667
1668         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1669         destructor.
1670         (dbx_objfile_data_key): Change type and declare later.
1671         (DBX_SYMFILE_INFO): Rewrite.
1672         * dbxread.c (dbx_objfile_data_key): Change type.
1673         (dbx_symfile_init): Update.
1674         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1675         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1676         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1677
1678 2019-07-10  Tom Tromey  <tromey@adacore.com>
1679
1680         * jit.c (jit_program_space_key): Change type.  Move lower.
1681         (get_jit_program_space_data): Update.
1682         (jit_program_space_data_cleanup): Remove.
1683         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1684         Update.
1685         (struct jit_program_space_data): Add initializers.
1686
1687 2019-07-10  Tom Tromey  <tromey@adacore.com>
1688
1689         * solib-darwin.c (struct darwin_info): Add initializers.
1690         (solib_darwin_pspace_data): Change type.
1691         (darwin_pspace_data_cleanup): Remove.
1692         (get_darwin_info, _initialize_darwin_solib): Update.
1693
1694 2019-07-10  Tom Tromey  <tromey@adacore.com>
1695
1696         * remote-sim.c (struct sim_inferior_data): Add initializers,
1697         constructor, and destructor.
1698         (sim_inferior_data_key): Change type.  Move lower.
1699         (check_for_duplicate_sim_descriptor): Update.
1700         (get_sim_inferior_data): Use new.  Update.
1701         (~sim_inferior_data_cleanup): Rename from
1702         sim_inferior_data_cleanup.  Simplify.
1703         (gdbsim_close_inferior, simulator_command)
1704         (sim_command_completer, _initialize_remote_sim): Update.
1705         (next_pid, INITIAL_PID): Move earlier.
1706
1707 2019-07-10  Tom Tromey  <tromey@adacore.com>
1708
1709         * python/python-internal.h (create_thread_object): Return
1710         gdbpy_ref.
1711         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1712         * python/py-inferior.c (struct threadlist_entry): Add
1713         constructor.
1714         <thread_obj>: Now a gdbpy_ref.
1715         (thread_to_thread_object): Update.
1716         (add_thread_object): Use new.
1717         (delete_thread_object): Use delete.
1718         (infpy_threads): Update.
1719         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1720         GIL.
1721
1722 2019-07-10  Tom Tromey  <tromey@adacore.com>
1723
1724         * valops.c (value_cast): Specialize error message for Ada.
1725
1726 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1727
1728         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1729
1730 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1731
1732         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1733         bpstat_should_step): Return bool, adjust comments.
1734         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1735         bpstat_should_step): Likewise.
1736
1737 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1738
1739         * features/Makefile: Use feature target descriptions for Arm.
1740         * features/arm/arm-core.c: Generate new file.
1741         * features/arm/arm-fpa.c: Likewise.
1742         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1743         * features/arm/arm-m-profile.c: Likewise.
1744         * features/arm/arm-vfpv2.c: Likewise.
1745         * features/arm/arm-vfpv3.c: Likewise.
1746         * features/arm/xscale-iwmmxt.c: Likewise.
1747         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1748
1749 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1750
1751         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1752         ptrace earlier.
1753
1754 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1755
1756         * features/aarch64-pauth.c: Regenerate.
1757
1758 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1759
1760         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1761         bool.
1762         (bpstat_what): Use false instead of 0.
1763
1764 2019-07-09  Pedro Alves  <palves@redhat.com>
1765
1766         * break-catch-throw.c (is_exception_catchpoint): New.
1767         * breakpoint.c (print_one_breakpoint_location): New parameter
1768         'raw_loc'.  Handle it.  Use
1769         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1770         looking at the breakpoint's type.
1771         (print_one_breakpoint): If handling "maint info breakpoints", also
1772         print locations of exception catchpoints.
1773         * breakpoint.h (is_exception_catchpoint): Declare.
1774
1775 2019-07-09  Pedro Alves  <palves@redhat.com>
1776
1777         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1778         "addr" field.
1779         (allocate_location_exception_catchpoint): New.
1780         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1781         (initialize_throw_catchpoint_ops): Install
1782         allocate_location_exception_catchpoint as allocate_location
1783         method.
1784         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1785         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1786         bp_loc_other.
1787         (breakpoint_address_is_meaningful): Delete.
1788         (bl_address_is_meaningful): New.
1789         (breakpoint_locations_match): Adjust comment.
1790         (bp_location_from_bp_type): New, factored out of...
1791         (bp_location::bp_location(breakpoint *)): ... this.
1792         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1793         factored out of...
1794         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1795         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1796         breakpoint_address_is_meaningful.
1797         (bp_locations_compare): Adjust comment.
1798         (update_global_location_list): Use bl_address_is_meaningful
1799         instead of breakpoint_address_is_meaningful.
1800         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1801         explicit.
1802         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1803         * python/py-breakpoint.c (bppy_get_location): No longer check
1804         whether location is null.
1805
1806 2019-07-09  Pedro Alves  <palves@redhat.com>
1807
1808         PR c++/15468
1809         * breakpoint.c (print_one_breakpoint_location): Remove
1810         single-location assert.
1811
1812 2019-07-09  Tom Tromey  <tom@tromey.com>
1813
1814         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1815         * configure: Rebuild.
1816         * configure.ac: Change common to gdbsupport.
1817         * gdbsupport: Rename from common.
1818         * acinclude.m4: Change common to gdbsupport.
1819         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1820         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1821         gdbsupport.
1822         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1823         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1824         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1825         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1826         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1827         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1828         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1829         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1830         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1831         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1832         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1833         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1834         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1835         coff-pe-read.c, command.h, compile/compile-c-support.c,
1836         compile/compile-c.h, compile/compile-cplus-symbols.c,
1837         compile/compile-cplus-types.c, compile/compile-cplus.h,
1838         compile/compile-loc2c.c, compile/compile.c, completer.c,
1839         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1840         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1841         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1842         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1843         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1844         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1845         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1846         features/aarch64-core.c, features/aarch64-fpu.c,
1847         features/aarch64-pauth.c, features/aarch64-sve.c,
1848         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1849         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1850         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1851         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1852         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1853         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1854         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1855         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1856         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1857         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1858         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1859         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1860         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1861         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1862         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1863         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1864         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1865         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1866         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1867         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1868         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1869         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1870         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1871         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1872         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1873         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1874         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1875         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1876         minsyms.c, mips-linux-tdep.c, namespace.h,
1877         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1878         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1879         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1880         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1881         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1882         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1883         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1884         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1885         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1886         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1887         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1888         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1889         procfs.c, producer.c, progspace.h, psymtab.h,
1890         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1891         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1892         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1893         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1894         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1895         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1896         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1897         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1898         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1899         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1900         target-memory.c, target.c, target.h, target/waitstatus.c,
1901         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1902         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1903         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1904         unittests/array-view-selftests.c,
1905         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1906         unittests/common-utils-selftests.c,
1907         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1908         unittests/format_pieces-selftests.c,
1909         unittests/function-view-selftests.c,
1910         unittests/lookup_name_info-selftests.c,
1911         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1912         unittests/mkdir-recursive-selftests.c,
1913         unittests/observable-selftests.c,
1914         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1915         unittests/parse-connection-spec-selftests.c,
1916         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1917         unittests/scoped_fd-selftests.c,
1918         unittests/scoped_mmap-selftests.c,
1919         unittests/scoped_restore-selftests.c,
1920         unittests/string_view-selftests.c, unittests/style-selftests.c,
1921         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1922         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1923         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1924         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1925         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1926         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1927
1928 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1931         bool value.
1932         (decode_digits_ordinary): Set explicit_line field in sal.
1933         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1934         symtab_and_line that was set on an explicit line number in
1935         assembler code.  Do always update the recorded symtab and line if
1936         we do skip the prologue.
1937
1938 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1939
1940         * breakpoint.c (set_breakpoint_location_function): Remove
1941         explicit_loc parameter.
1942         (momentary_breakpoint_from_master): Update call to
1943         set_breakpoint_location_function.
1944         (add_location_to_breakpoint): Likewise.
1945
1946 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1947
1948         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1949         required features based on default bfd type when no specific bfd
1950         is present.
1951
1952 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1953
1954         * NEWS: Mention that GDB printf and eval commands can now print
1955         C-style and Ada-style convenience var strings without
1956         calling the inferior.
1957         * printcmd.c (printf_c_string): Locally print GDB internal var
1958         instead of transiting via the inferior.
1959         (printf_wide_c_string): Likewise.
1960
1961 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1962
1963         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1964
1965 2019-07-04  Tom Tromey  <tom@tromey.com>
1966
1967         PR tui/24724:
1968         * tui/tui-winsource.c (tui_clear_source_content): Update.
1969         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1970         (tui_update_breakpoint_info): Update.
1971         (tui_set_exec_info_content): Update.
1972         * tui/tui-source.c (tui_set_source_content_nil): Update.
1973         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1974         has_break.
1975         * tui/tui-data.h (enum tui_bp_flag): New.
1976         (tui_bp_flags): New enum flags type.
1977         (struct tui_source_element) <break_mode>: Change type.  Rename
1978         from has_break.
1979         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1980         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1981         constants.
1982         * tui/tui-winsource.h: Fix comment.
1983
1984 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1985
1986         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1987         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1988         (store_fpregs_to_thread)
1989         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1990         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1991         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1992         (IWMMXT_REGS_SIZE): Add define.
1993         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1994         (fetch_vfp_regs, store_vfp_regs)
1995         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1996         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1997
1998 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1999
2000         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2001         defines.
2002         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2003         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2004         (ARM_INT_REGISTER_SIZE): ...to this.
2005         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2006         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2007         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2008         (arm_linux_collect_gregset, supply_nwfpe_register)
2009         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2010         defines.
2011         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2012         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2013         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2014         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2015         (arm_return_in_memory, arm_store_return_value)
2016         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2017         (arm_record_ld_st_multiple): Likewise.
2018         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2019         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2020
2021 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2022
2023         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2024         AARCH64_DISPLACED_MODIFIED_INSNS.
2025         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2026         (aarch64_displaced_step_copy_insn): Likewise.
2027         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2028         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2029         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2030         ARM_DISPLACED_MODIFIED_INSNS.
2031         * arm-tdep.c (arm_gdbarch_init): Likewise.
2032         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2033         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2034         (struct arm_displaced_step_closure): Use
2035         ARM_DISPLACED_MODIFIED_INSNS.
2036
2037 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2038
2039         * features/Makefile: Remove unused xml files.
2040         * features/aarch64.xml: Remove.
2041         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2042         * features/i386/amd64-avx-avx512.xml: Remove.
2043         * features/i386/amd64-avx-linux.xml: Remove.
2044         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2045         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2046         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2047         * features/i386/amd64-avx-mpx.xml: Remove.
2048         * features/i386/amd64-avx.xml: Remove.
2049         * features/i386/amd64-linux.xml: Remove.
2050         * features/i386/amd64-mpx-linux.xml: Remove.
2051         * features/i386/amd64-mpx.xml: Remove.
2052         * features/i386/amd64.xml: Remove.
2053         * features/i386/i386-avx-avx512-linux.xml: Remove.
2054         * features/i386/i386-avx-avx512.xml: Remove.
2055         * features/i386/i386-avx-linux.xml: Remove.
2056         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2057         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2058         * features/i386/i386-avx-mpx-linux.xml: Remove.
2059         * features/i386/i386-avx-mpx.xml: Remove.
2060         * features/i386/i386-avx.xml: Remove.
2061         * features/i386/i386-linux.xml: Remove.
2062         * features/i386/i386-mmx-linux.xml: Remove.
2063         * features/i386/i386-mmx.xml: Remove.
2064         * features/i386/i386-mpx-linux.xml: Remove.
2065         * features/i386/i386-mpx.xml: Remove.
2066         * features/i386/i386.xml: Remove.
2067         * features/i386/x32-avx-avx512-linux.xml: Remove.
2068         * features/i386/x32-avx-linux.xml: Remove.
2069         * features/i386/x32-linux.xml: Remove.
2070
2071 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2072
2073         * regformats/aarch64.dat: Remove.
2074         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2075         * regformats/i386/amd64-avx-linux.dat: Remove.
2076         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2077         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2078         * regformats/i386/amd64-linux.dat: Remove.
2079         * regformats/i386/amd64-mpx-linux.dat: Remove.
2080         * regformats/i386/amd64.dat: Remove.
2081         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2082         * regformats/i386/i386-avx-linux.dat: Remove.
2083         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2084         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2085         * regformats/i386/i386-linux.dat: Remove.
2086         * regformats/i386/i386-mmx-linux.dat: Remove.
2087         * regformats/i386/i386-mpx-linux.dat: Remove.
2088         * regformats/i386/i386.dat: Remove.
2089         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2090         * regformats/i386/x32-avx-linux.dat: Remove.
2091         * regformats/i386/x32-linux.dat: Remove.
2092
2093 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2094
2095         * aarch64-tdep.c: Remove xml self tests.
2096         * amd64-linux-tdep.c: Likewise.
2097         * amd64-tdep.c: Likewise.
2098         * i386-linux-tdep.c: Likewise.
2099         * i386-tdep.c: Likewise.
2100
2101 2019-07-03  Pedro Alves  <palves@redhat.com>
2102
2103         PR cli/24732
2104         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2105         (pipe_cmd_option_defs): New.
2106         (make_pipe_cmd_options_def_group): New.
2107         (pipe_command): Use gdb::option::process_options.
2108         (pipe_command_completer): New function.
2109         (_initialize_cli_cmds): Install completer for "pipe" command.
2110
2111 2019-07-03  Pedro Alves  <palves@redhat.com>
2112
2113         * cli/cli-option.c (union option_value) <string>: New field.
2114         (struct option_def_and_value): Add ctor, move ctor, dtor and
2115         use DISABLE_COPY_AND_ASSIGN.
2116         (option_def_and_value::clear_value): New.
2117         (parse_option, save_option_value_in_ctx, get_val_type_str)
2118         (add_setshow_cmds_for_options): Handle var_string.
2119         * cli-option.h (union option_def::var_address) <string>: New
2120         field.
2121         (struct string_option_def): New.
2122         * maint-test-options.c (struct test_options_opts): Add default
2123         ctor and use DISABLE_COPY_AND_ASSIGN.
2124         <string_opt>: New field.
2125         (test_options_opts::~test_options_opts): New.
2126         (test_options_opts::dump): Also dump "-string".
2127         (test_options_option_defs): Install "string.
2128
2129 2019-07-03  Pedro Alves  <palves@redhat.com>
2130
2131         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2132         option_value with a null enumeration.
2133         (complete_options): Save the option values in the context.
2134         (save_option_value_in_ctx): New, factored out from ...
2135         (process_options): ... here.
2136         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2137         of the function.
2138         * maint-test-options.c (test_options_opts::dump): New, factored
2139         out from ...
2140         (maintenance_test_options_command_mode): ... here.
2141         (maintenance_test_options_command_completion_result): Delete.
2142         (maintenance_test_options_command_completion_text): Update
2143         comment.
2144         (maintenance_show_test_options_completion_result): Change
2145         prototype.  Just print
2146         maintenance_test_options_command_completion_text.
2147         (save_completion_result): New.
2148         (maintenance_test_options_completer_mode): Pass options context to
2149         complete_options, and then save a dump.
2150         (_initialize_maint_test_options): Use add_cmd to install "maint
2151         show test-options-completion-result".
2152
2153 2019-07-03  Pedro Alves  <palves@redhat.com>
2154
2155         * NEWS (New commands): Mention "with" and "maint with".
2156         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2157         (with_command, with_command_completer): New.
2158         (pipe_command): Adjust to new repeat_previous
2159         interface.
2160         (_initialize_cli_cmds): Install the "with" command and its "w"
2161         alias.
2162         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2163         declarations.
2164         * cli/cli-setshow.c (parse_cli_var_uinteger)
2165         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2166         argument strings for all var_types.
2167         (get_setshow_command_value_string): New, factored out from ...
2168         (do_show_command): ... this.
2169         * cli/cli-setshow.h: Include <string>.
2170         (get_setshow_command_value_string): Declare.
2171         * command.h (repeat_previous): Now returns const char *.  Adjust
2172         comment.
2173         * maint.c: Include "cli/cli-cmds.h".
2174         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2175         (_initialize_maint_cmds): Register the "maintenance with" command.
2176         * top.c (repeat_previous): Move bits from pipe_command here:
2177         Return the saved command line, if any; error out if there's no
2178         command to relaunch.
2179
2180 2019-07-03  Pedro Alves  <palves@redhat.com>
2181
2182         * NEWS (New commands): Mention "maint set/show test-settings"
2183         instead of "maint test-settings".
2184         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2185         (maintenance_test_settings_set_list): Rename to ...
2186         (maintenance_set_test_settings_list): ... this.
2187         (maintenance_test_settings_show_list): Rename to  ...
2188         (maintenance_show_test_settings_list): ... this.
2189         (maintenance_test_settings_cmd): Delete.
2190         (maintenance_test_settings_set_cmd): ...
2191         (maintenance_set_test_settings_cmd): ... this.
2192         (maintenance_test_settings_show_cmd): ...
2193         (maintenance_show_test_settings_cmd): ... this.
2194         (maintenance_test_settings_show_value_cmd):
2195         (maintenance_show_test_settings_value_cmd): ... this.
2196         (_initialize_maint_test_settings): No longer install the "maint
2197         test-settings" prefix command.  Rename "maint test-settings set"
2198         to "maint set test-settings", and "maint test-settings show" to
2199         "maint show test-settings".  Adjust all subcommands.
2200
2201 2019-07-03  Pedro Alves  <palves@redhat.com>
2202
2203         * maint-test-settings.c: Fix file's intro comment.  Replace all
2204         references to "test-options" with references to "test-settings",
2205         in comments.
2206
2207 2019-07-03  Pedro Alves  <palves@redhat.com>
2208
2209         * maint-test-settings.c (maintenance_test_settings_xxx)
2210         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2211         New.
2212         (maintenance_test_settings_enums): Use them.
2213         (maintenance_test_settings_enum): Default to
2214         maintenance_test_settings_xxx.
2215         (_initialize_maint_test_settings): Initialize
2216         MAINTENANCE_TEST_SETTINGS_FILENAME.
2217
2218 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2219
2220         * breakpoint.h (remove_breakpoints_inf): Change return type to
2221         void, move function documentation here.
2222         * breakpoint.c (remove_breakpoints_inf): Change return type to
2223         void, move function documentation to header.
2224
2225 2019-07-02  Pedro Alves  <palves@redhat.com>
2226
2227         * NEWS (Completion improvements): Mention "info threads".
2228         * thread.c (struct info_threads_opts, info_threads_option_defs)
2229         (make_info_threads_options_def_group): New.
2230         (info_threads_command): Use gdb::option::process_options.
2231         (info_threads_command_completer): New.
2232         (_initialize_thread): Use gdb::option::build_help to build the
2233         help text for "info threads".
2234
2235 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2236
2237         * defs.h (generic_load): Move from here...
2238         * symfile.h (generic_load): ... to here.  Rename name parameter
2239         to args.
2240         * symfile.c (generic_load): Add comment.
2241
2242 2019-07-01  Tom Tromey  <tromey@adacore.com>
2243
2244         * dwarf2read.c
2245         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2246         declaration of without_params.  Fix formatting.
2247
2248 2019-07-01  Tom Tromey  <tromey@adacore.com>
2249
2250         * ada-exp.y (find_primitive_type): Update.
2251         * ada-lang.h (ada_lookup_symbol): Update.
2252         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2253         parameter.
2254         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2255
2256 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2257
2258         PR breakpoints/24541
2259         * gdbarch.c: Regenerate.
2260         * gdbarch.h: Regenerate.
2261         * gdbarch.sh: Add 'stap_adjust_register'.
2262         * i386-tdep.c: Include '<unordered_set>'.
2263         (i386_stap_adjust_register): New function.
2264         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2265         * stap-probe.c (stap_parse_register_operand): Call
2266         'gdbarch_stap_adjust_register'.
2267
2268 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2269
2270         PR python/24742
2271         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2272         * python/python.c (do_start_initialization): Use 'xmalloc'
2273         instead of 'PyMem_Malloc'.
2274
2275 2019-06-28  Tom Tromey  <tromey@adacore.com>
2276
2277         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2278         for Ada.
2279
2280 2019-06-27  Tom Tromey  <tromey@adacore.com>
2281
2282         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2283         objfile_key.
2284         (arm_find_mapping_symbol, arm_record_special_symbol)
2285         (_initialize_arm_tdep): Update.
2286         (arm_objfile_data_free): Remove.
2287
2288 2019-06-27  Tom Tromey  <tromey@adacore.com>
2289
2290         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2291         to cp_print_static_field.
2292
2293 2019-06-26  Tom Tromey  <tromey@adacore.com>
2294
2295         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2296         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2297         declare.
2298
2299 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2300
2301         * features/aarch64-core.c (create_feature_aarch64_core):
2302         Regenerate.
2303         * features/aarch64-core.xml: Add cpsr flags.
2304
2305 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2306
2307         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2308         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2309
2310 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2311
2312         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2313         field.
2314         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2315         use.
2316         (arm_record_special_symbol): Don't insert new symbol in sorted
2317         position, push it at the end.
2318
2319 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2320
2321         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2322         (arm_mapping_symbol_s): Remove.
2323         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2324         (arm_mapping_symbol_vec): New typedef.
2325         (struct arm_per_objfile): Add constructor.
2326         <section_maps>: Change type to
2327         std::unique_ptr<arm_mapping_symbol_vec[]>.
2328         (arm_compare_mapping_symbols): Remove.
2329         (arm_find_mapping_symbol): Adjust to section_maps type change.
2330         (arm_objfile_data_free): Call delete on arm_per_objfile.
2331         (arm_record_special_symbol): Adjust to section_maps type change.
2332         Allocate arm_per_objfile with new.
2333
2334 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2335
2336         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2337         with the command prefix.
2338
2339 2019-06-25  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2342         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2343
2344 2019-06-25  Tom Tromey  <tom@tromey.com>
2345
2346         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2347         type.
2348         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2349         protected.
2350
2351 2019-06-25  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-winsource.c
2354         (tui_source_window_base::set_is_exec_point_at): Add check against
2355         LOA_ADDRESS.
2356
2357 2019-06-25  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-source.c (tui_set_source_content): Don't check before
2360         xfree.
2361         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2362
2363 2019-06-25  Tom Tromey  <tom@tromey.com>
2364
2365         * tui/tui-winsource.h (tui_update_source_window_as_is)
2366         (tui_alloc_source_buffer, tui_line_is_displayed)
2367         (tui_addr_is_displayed): Change type of win_info.
2368         * tui/tui-winsource.c (tui_update_source_window_as_is)
2369         (tui_clear_source_content, tui_show_source_line)
2370         (tui_show_source_content, tui_source_window_base::refill)
2371         (tui_source_window_base::set_is_exec_point_at)
2372         (tui_source_window_base::set_is_exec_point_at)
2373         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2374         (tui_alloc_source_buffer, tui_line_is_displayed)
2375         (tui_addr_is_displayed): Change type of win_info.  Update.
2376         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2377         (tui_source_window_base::do_make_visible_with_new_height):
2378         Update.
2379         * tui/tui-source.c (tui_set_source_content)
2380         (tui_set_source_content_nil)
2381         (tui_source_window::do_scroll_vertical): Update.
2382         * tui/tui-layout.c (show_layout): Update.
2383         * tui/tui-disasm.c (tui_set_disassem_content)
2384         (tui_disasm_window::do_scroll_vertical): Update.
2385         * tui/tui-data.h (tui_win_content): Remove.
2386         (struct tui_gen_win_info) <content, content_size>: Remove.
2387         (struct tui_source_element): Add initializers and destructor.
2388         (union tui_which_element, struct tui_win_element): Remove.
2389         (struct tui_source_window_base) <content>: New field.
2390         (struct tui_data_window): Remove destructor.
2391         (tui_alloc_content, tui_free_win_content)
2392         (tui_free_all_source_wins_content): Don't declare.
2393         * tui/tui-data.c (tui_initialize_static_data): Update.
2394         (init_content_element, tui_alloc_content): Remove.
2395         (~tui_gen_win_info): Update.
2396         (~tui_data_window, tui_free_all_source_wins_content)
2397         (tui_free_win_content, free_content, free_content_elements):
2398         Remove.
2399
2400 2019-06-25  Tom Tromey  <tom@tromey.com>
2401
2402         * tui/tui-winsource.h (tui_clear_source_content)
2403         (tui_erase_source_content, tui_show_source_content): Change type
2404         of win_info.
2405         * tui/tui-winsource.c (tui_clear_source_content)
2406         (tui_erase_source_content, tui_show_source_content): Change type
2407         of win_info.
2408         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2409         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2410         win_info.
2411         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2412         win_info.
2413         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2414
2415 2019-06-25  Tom Tromey  <tom@tromey.com>
2416
2417         * tui/tui-winsource.c (tui_clear_source_content)
2418         (tui_source_window_base::set_is_exec_point_at): Update.
2419         * tui/tui-source.c (tui_set_source_content_nil): Update.
2420         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2421         a bool.
2422         * tui/tui-data.c (init_content_element): Update.
2423
2424 2019-06-25  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2427         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2428         * tui/tui-layout.c (init_and_make_win): Update.
2429         * tui/tui.h (enum tui_win_type): Update.
2430         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2431         tui_win_is_auxillary.
2432         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2433         tui_win_is_auxillary.
2434
2435 2019-06-25  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2438         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2439         (tui_delete_data_content_windows, tui_display_all_data)
2440         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2441         Update.
2442         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2443         * tui/tui-regs.c (tui_last_regs_line_no)
2444         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2445         (tui_show_registers): Update.
2446         (tui_show_register_group): Return void.  Update.
2447         (tui_display_registers_from, tui_display_reg_element_at_line)
2448         (tui_display_registers_from_line, tui_check_register_values):
2449         Update.
2450         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2451         member.
2452         (struct tui_data_window) <regs_content>: Now a std::vector.
2453         <regs_content_count>: Remove.
2454         (tui_add_content_elements, tui_free_data_content): Don't declare.
2455         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2456         (init_content_element): Remove DATA_WIN case.  Add assert.
2457         (tui_add_content_elements): Remove.
2458         (tui_data_window): Update.
2459         (tui_free_data_content): Remove.
2460         (free_content_elements): Remove DATA_WIN case.
2461
2462 2019-06-25  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-data.c (tui_data_item_window): Update.
2465         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2466         * tui/tui-windata.c (tui_display_all_data)
2467         (tui_display_data_from_line): Update.
2468         (tui_check_data_values): Remove.
2469         * tui/tui-regs.c (tui_show_register_group)
2470         (tui_display_reg_element_at_line): Update.
2471         * tui/tui-hooks.c (tui_register_changed)
2472         (tui_refresh_frame_and_register_information): Call
2473         tui_check_register_values.
2474         * tui/tui-data.h (struct tui_data_window) <data_content,
2475         data_content_count, data_type>: Remove.
2476         (enum tui_data_type): Remove.
2477
2478         * tui/tui-data.c (tui_data_window::clear_detail)
2479         (~tui_data_window): Update.
2480
2481 2019-06-25  Tom Tromey  <tom@tromey.com>
2482
2483         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2484         declare.
2485         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2486         Rename from tui_first_data_item_displayed.  Update.
2487         (tui_data_window::refresh_all)
2488         (tui_data_window::do_scroll_vertical): Update.
2489         * tui/tui-data.h (struct tui_data_window)
2490         <first_data_item_displayed>: Declare new method.
2491
2492 2019-06-25  Tom Tromey  <tom@tromey.com>
2493
2494         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2495         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2496         contents...
2497         (tui_initialize_static_data): ...here.
2498
2499 2019-06-25  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2502         (tui_display_registers_from, tui_check_register_values): Update.
2503         (tui_display_register): Remove win_info parameter; update.
2504         (tui_get_register): Change type of parameters.
2505         * tui/tui-data.h (struct tui_data_element): Remove.
2506         (union tui_which_element) <data>: Remove.
2507         <data_window>: Change type.
2508         (struct tui_data_item_window): New.
2509         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2510         case.  Add assert.
2511         (~tui_data_item_window): New destructor.
2512         (free_content_elements): Remove DATA_ITEM_WIN case.
2513
2514 2019-06-25  Tom Tromey  <tom@tromey.com>
2515
2516         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2517         Remove.
2518
2519 2019-06-25  Tom Tromey  <tom@tromey.com>
2520
2521         * tui/tui-data.h (struct tui_command_element): Remove.
2522         (union tui_which_element) <command>: Remove.
2523         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2524         assert.
2525         (free_content_elements): Remove CMD_WIN case.
2526
2527 2019-06-25  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-layout.c (tui_set_layout): Update.
2530         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2531         * tui/tui-data.c (layout_def): Update.
2532
2533 2019-06-25  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2536         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2537         (tui_source_window_base::set_new_height): Update.
2538         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2539         Update.
2540         (tui_set_locator_fullname, tui_set_locator_info)
2541         (tui_show_frame_info): Update.
2542         * tui/tui-source.c (tui_set_source_content)
2543         (tui_source_is_displayed): Update.
2544         * tui/tui-layout.c (show_source_disasm_command, show_data)
2545         (show_source_or_disasm_and_command): Update.
2546         * tui/tui-disasm.c (tui_set_disassem_content)
2547         (tui_get_begin_asm_address): Update.
2548         * tui/tui-data.h (struct tui_locator_element): Remove.
2549         (union tui_which_element) <locator>: Remove.
2550         (struct tui_locator_window): New.
2551         (tui_locator_win_info_ptr): Change return type.
2552         * tui/tui-data.c (_locator): Change type.
2553         (tui_locator_win_info_ptr): Change return type.
2554         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2555         (tui_alloc_content): Add assert.
2556
2557 2019-06-25  Tom Tromey  <tom@tromey.com>
2558
2559         * tui/tui-winsource.c
2560         (tui_exec_info_window::maybe_allocate_content): New method.
2561         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2562         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2563         (make_source_or_disasm_window): Add cast.
2564         * tui/tui-data.h (union tui_which_element) <simple_string>:
2565         Remove.
2566         (struct tui_source_info): New.
2567         (struct tui_source_window_base) <execution_info>: Change type.
2568         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2569         case, and add assert.
2570         (tui_alloc_content): Add assert.
2571
2572 2019-06-25  Tom Tromey  <tom@tromey.com>
2573
2574         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2575         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2576         * tui/tui-data.c (tui_alloc_win_info): Remove.
2577
2578 2019-06-25  Tom Tromey  <tom@tromey.com>
2579
2580         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2581         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2582         can_highlight.
2583
2584 2019-06-25  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2587         make_visible_with_new_height method.
2588         (tui_win_info::make_visible_with_new_height): New method.
2589         (tui_source_window_base::do_make_visible_with_new_height)
2590         (tui_data_window::do_make_visible_with_new_height)
2591         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2592         (make_visible_with_new_height): Remove.
2593         (tui_resize_all, tui_adjust_win_heights): Use
2594         make_visible_with_new_height method.
2595         * tui/tui-data.h (struct tui_win_info)
2596         <do_make_visible_with_new_height, make_visible_with_new_height>:
2597         New methods.
2598         (struct tui_source_window_base, struct tui_data_window)
2599         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2600         methods.
2601
2602 2019-06-25  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2605         method.
2606         (update_tab_width): Call update_tab_width method.
2607         * tui/tui-data.h (struct tui_win_info)
2608         (struct tui_source_window_base) <update_tab_width>: New methods.
2609
2610 2019-06-25  Tom Tromey  <tom@tromey.com>
2611
2612         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2613         parameter.
2614         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2615         parameter.
2616         (tui_gen_win_info::make_visible): Update.
2617         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2618         parameter.
2619         * tui/tui-data.h (enum tui_box): New enum.
2620         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2621
2622 2019-06-25  Tom Tromey  <tom@tromey.com>
2623
2624         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2625         init_and_make_win for EXEC_INFO_WIN.
2626         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2627         longer inline.
2628         (struct tui_win_info) <~tui_win_info>: Inline.
2629         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2630         Don't declare.
2631         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2632         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2633         Remove.
2634         (tui_initialize_static_data): Update.
2635         (~tui_gen_win_info): Handle more cleanup here.
2636         (~tui_source_window_base): Delete "execution_info".
2637         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2638
2639 2019-06-25  Tom Tromey  <tom@tromey.com>
2640
2641         * tui/tui-layout.c (make_command_window): Don't set
2642         can_highlight.
2643         (show_source_disasm_command): Call the reset method.
2644         (show_data): Don't set can_highlight.  Call the reset method.
2645         (tui_gen_win_info::reset): Rename from init_gen_win_info
2646         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2647         (show_source_or_disasm_and_command): Call the reset method.
2648         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2649         (struct tui_cmd_window): Set can_highlight.
2650
2651 2019-06-25  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2654         from make_visible.
2655         (tui_make_visible, tui_make_invisible): Rewrite.
2656         (tui_win_info::make_visible): Remove.
2657         (tui_source_window_base::make_visible): Update.
2658         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2659         method.  Moved from...
2660         (struct tui_win_info) <make_visible>: ...here.
2661
2662 2019-06-25  Tom Tromey  <tom@tromey.com>
2663
2664         * tui/tui-winsource.c
2665         (tui_source_window_base::do_scroll_horizontal): Remove direction
2666         parameter.
2667         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2668         direction parameter.
2669         * tui/tui-win.c (tui_win_info::forward_scroll)
2670         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2671         (tui_win_info::right_scroll): Update.
2672         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2673         direction parameter.
2674         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2675         direction parameter.
2676         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2677         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2678         Remove direction parameter.
2679         (struct tui_source_window_base, struct tui_source_window)
2680         (struct tui_disasm_window, struct tui_data_window)
2681         (struct tui_cmd_window): Update.
2682
2683 2019-06-25  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui-winsource.h (tui_set_exec_info_content)
2686         (tui_show_exec_info_content, tui_erase_exec_info_content)
2687         (tui_clear_exec_info_content, tui_update_exec_info): Change
2688         argument to tui_source_window_base.
2689         * tui/tui-winsource.c (tui_set_exec_info_content)
2690         (tui_show_exec_info_content, tui_erase_exec_info_content)
2691         (tui_clear_exec_info_content, tui_update_exec_info): Change
2692         argument to tui_source_window_base.
2693
2694 2019-06-25  Tom Tromey  <tom@tromey.com>
2695
2696         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2697         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2698
2699 2019-06-25  Tom Tromey  <tom@tromey.com>
2700
2701         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2702         check.
2703
2704 2019-06-25  Tom Tromey  <tom@tromey.com>
2705
2706         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2707         type to void.
2708         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2709         type to void.
2710         * tui/tui-source.c (tui_set_source_content): Update.
2711         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2712
2713 2019-06-25  Tom Tromey  <tom@tromey.com>
2714
2715         * tui/tui-win.c (window_name_completer, tui_set_focus)
2716         (tui_all_windows_info): Use name method.
2717         * tui/tui-data.h (struct tui_gen_win_info)
2718         (struct tui_source_window, struct tui_disasm_window)
2719         (struct tui_data_window, struct tui_cmd_window) <name>: New
2720         method.
2721         (tui_win_name): Don't declare.
2722         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2723         (tui_win_name): Remove.
2724
2725 2019-06-25  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-winsource.h (tui_update_source_window)
2728         (tui_update_source_window_as_is): Change parameter type.
2729         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2730         to be a tui_source_window_base.
2731         (tui_update_source_window_as_is): Likewise.
2732         * tui/tui-win.c (make_visible_with_new_height): Update.
2733
2734 2019-06-25  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-winsource.c (tui_erase_source_content)
2737         (tui_show_source_content, tui_show_exec_info_content)
2738         (tui_erase_exec_info_content): Use refresh_window method.
2739         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2740         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2741         from tui_refresh_win.
2742         (tui_data_window::refresh_window): New method.
2743         (tui_win_info::refresh, tui_source_window_base::refresh)
2744         (tui_refresh_all): Use refresh_window method.
2745         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2746         method.
2747         * tui/tui-regs.c (tui_display_register): Call refresh_window
2748         method.
2749         * tui/tui-layout.c (show_source_disasm_command)
2750         (show_source_or_disasm_and_command): Call refresh_window method.
2751         * tui/tui-data.h (struct tui_gen_win_info)
2752         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2753         New method.
2754
2755 2019-06-25  Tom Tromey  <tom@tromey.com>
2756
2757         * tui/tui.c (tui_rl_other_window, tui_enable)
2758         (tui_is_window_visible, tui_get_command_dimension): Update.
2759         * tui/tui-winsource.c (tui_update_source_window_as_is)
2760         (tui_clear_source_content, tui_erase_source_content)
2761         (tui_show_source_line, tui_source_window_base::refill)
2762         (tui_source_window_base::do_scroll_horizontal)
2763         (tui_source_window_base::set_is_exec_point_at)
2764         (tui_update_breakpoint_info, tui_set_exec_info_content)
2765         (tui_alloc_source_buffer, tui_line_is_displayed)
2766         (tui_addr_is_displayed): Update.
2767         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2768         (tui_check_and_display_highlight_if_needed)
2769         (tui_win_info::make_visible, tui_win_info::refresh)
2770         (tui_refresh_all): Update.
2771         * tui/tui-windata.c (tui_first_data_item_displayed)
2772         (tui_delete_data_content_windows, tui_erase_data_content)
2773         (tui_display_all_data, tui_data_window::refresh_all)
2774         (tui_check_data_values): Update.
2775         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2776         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2777         (tui_win_info::backward_scroll, tui_refresh_all_win)
2778         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2779         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2780         (tui_source_window_base::set_new_height)
2781         (tui_data_window::set_new_height)
2782         (make_invisible_and_set_new_height)
2783         (make_visible_with_new_height, new_height_ok)
2784         (parse_scrolling_args): Update.
2785         * tui/tui-stack.c (tui_show_frame_info): Update.
2786         * tui/tui-source.c (tui_set_source_content)
2787         (tui_set_source_content_nil, tui_source_is_displayed)
2788         (tui_source_window::do_scroll_vertical): Update.
2789         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2790         (tui_display_registers_from, tui_display_reg_element_at_line)
2791         (tui_check_register_values, tui_reg_command): Update.
2792         * tui/tui-layout.c (tui_default_win_height)
2793         (show_source_disasm_command, show_data, init_and_make_win)
2794         (show_source_or_disasm_and_command): Update.
2795         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2796         (tui_redisplay_readline, tui_mld_flush)
2797         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2798         (tui_getc): Update.
2799         * tui/tui-disasm.c (tui_set_disassem_content)
2800         (tui_disasm_window::do_scroll_vertical): Update.
2801         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2802         Now virtual.
2803         (struct tui_win_info): Derive from tui_gen_win_info.
2804         <~tui_win_info>: Mark as override.
2805         <generic>: Remove member.
2806         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2807         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2808         (~tui_data_window, ~tui_win_info)
2809         (tui_free_all_source_wins_content): Update.
2810         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2811
2812 2019-06-25  Tom Tromey  <tom@tromey.com>
2813
2814         * tui/tui-layout.c (init_and_make_win): Use new.
2815         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2816         destructor, initializers.
2817         (tui_alloc_generic_win_info): Don't declare.
2818         * tui/tui-data.c (_locator): Add argument to constructor.
2819         (source_win, disasm_win): New globals.
2820         (exec_info): Remove.
2821         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2822         Update.
2823         (tui_alloc_generic_win_info): Remove.
2824         (init_content_element): Use new.
2825         (tui_win_info::tui_win_info): Update.
2826         (free_content_elements) <case DATA_WIN>: Use delete.
2827
2828 2019-06-25  Tom Tromey  <tom@tromey.com>
2829
2830         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2831         * tui/tui-windata.c (tui_first_data_item_displayed)
2832         (tui_delete_data_content_windows): Update.
2833         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2834         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2835         (tui_display_registers_from, tui_check_register_values): Update.
2836         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2837         pointer.
2838         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2839         window.
2840         (tui_free_data_content): Update.
2841         (free_content_elements) <case DATA_WIN>: Free the window.
2842
2843 2019-06-25  Tom Tromey  <tom@tromey.com>
2844
2845         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2846         Update.
2847         * tui/tui-layout.c (make_command_window)
2848         (show_source_disasm_command, show_data, init_and_make_win)
2849         (show_source_or_disasm_and_command): Update.
2850         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2851         method.
2852         <can_highight, is_highlighted>: Now bool.
2853         (tui_set_win_highlight): Don't declare.
2854         * tui/tui-data.c (tui_set_win_highlight): Remove.
2855
2856 2019-06-25  Tom Tromey  <tom@tromey.com>
2857
2858         * tui/tui-wingeneral.c (make_visible): Remove check of window
2859         type.
2860
2861 2019-06-25  Tom Tromey  <tom@tromey.com>
2862
2863         * tui/tui-win.c (tui_win_info::max_height)
2864         (tui_cmd_window::max_height): New methods.
2865         (new_height_ok): Call max_height.
2866         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2867         <max_height>: New method.
2868
2869 2019-06-25  Tom Tromey  <tom@tromey.com>
2870
2871         * tui/tui-win.c (tui_source_window_base::set_new_height)
2872         (tui_data_window::set_new_height): New methods.
2873         (make_invisible_and_set_new_height): Call set_new_height method.
2874         * tui/tui-data.h (struct tui_win_info)
2875         (struct tui_source_window_base, struct tui_data_window)
2876         <set_new_height>: New method.
2877
2878 2019-06-25  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2881         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2882         tui_refresh_data_win.
2883         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2884         method.
2885         (tui_refresh_all_win): Call the refresh_all method.
2886         (tui_set_focus): Likewise.
2887         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2888         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2889         Likewise.
2890
2891 2019-06-25  Tom Tromey  <tom@tromey.com>
2892
2893         * tui/tui-winsource.h (tui_refill_source_window)
2894         (tui_set_is_exec_point_at): Don't declare.
2895         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2896         (tui_source_window_base::refill): Rename from
2897         tui_refill_source_window.
2898         (tui_source_window_base::do_scroll_horizontal): Update.
2899         (tui_source_window_base::set_is_exec_point_at): Rename from
2900         tui_set_is_exec_point_at.
2901         (tui_update_all_breakpoint_info): Update.
2902         * tui/tui-stack.c (tui_show_frame_info): Update.
2903         * tui/tui-layout.c (show_data): Add cast.
2904         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2905         * tui/tui-data.h (struct tui_source_window_base) <refill,
2906         set_is_exec_point_at>: New methods.
2907         (tui_source_windows, tui_add_to_source_windows): Update types.
2908         (tui_add_to_source_windows): Remove redundant declaration.
2909         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2910         (tui_source_windows): Change return type.
2911         (tui_clear_source_windows_detail): Update.
2912         (tui_add_to_source_windows): Change type of parameter.
2913         (tui_free_all_source_wins_content): Update.
2914
2915 2019-06-25  Tom Tromey  <tom@tromey.com>
2916
2917         * tui/tui-wingeneral.c (tui_win_info::refresh)
2918         (tui_source_window_base::refresh): New methods.
2919         (tui_refresh_all): Call the refresh method.
2920         * tui/tui-data.h (struct tui_win_info)
2921         (struct tui_source_window_base) <refresh>: New method.
2922
2923 2019-06-25  Tom Tromey  <tom@tromey.com>
2924
2925         * tui/tui.h (tui_is_window_visible): Return bool.
2926         * tui/tui.c (tui_is_window_visible): Return bool.
2927         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2928         (tui_make_visible, tui_make_invisible)
2929         (tui_win_info::make_visible)
2930         (tui_source_window_base::make_visible, make_all_visible)
2931         (tui_make_all_visible, tui_make_all_invisible): Update.
2932         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2933         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2934         bool.
2935         (struct tui_win_info, struct tui_source_window_base)
2936         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2937         * tui/tui-data.c (tui_init_generic_part): Update.
2938
2939 2019-06-25  Tom Tromey  <tom@tromey.com>
2940
2941         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2942         (tui_source_window_base::make_visible): New methods.
2943         (make_all_visible): Make method call.
2944         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2945         (struct tui_source_window_base, struct tui_cmd_window): Override
2946         make_visible.
2947         (tui_win_is_source_type): Don't declare.
2948         * tui/tui-data.c (tui_win_is_source_type): Remove.
2949
2950 2019-06-25  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2953         NULL check.
2954
2955 2019-06-25  Tom Tromey  <tom@tromey.com>
2956
2957         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2958         Inline constructor.  Add initializers for members.
2959         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2960         constructors; now inline in class.
2961
2962 2019-06-25  Tom Tromey  <tom@tromey.com>
2963
2964         * tui/tui-regs.c (tui_show_registers): Update.
2965         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2966         bool.
2967         * tui/tui-data.c (tui_data_window::clear_detail)
2968         (tui_data_window): Update.
2969
2970 2019-06-25  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-windata.c (tui_display_all_data)
2973         (tui_display_data_from_line, tui_display_data_from)
2974         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2975         Update.
2976         * tui/tui-regs.c (tui_last_regs_line_no)
2977         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2978         (tui_show_registers, tui_show_register_group)
2979         (tui_display_registers_from, tui_display_reg_element_at_line)
2980         (tui_display_registers_from_line, tui_check_register_values)
2981         (tui_reg_next, tui_reg_prev): Update.
2982         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2983         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2984         tui_data_window.
2985         (struct tui_win_info) <detail>: Remove.  Add new fields from
2986         tui_data_info.
2987         (TUI_DATA_WIN): Add cast.
2988         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2989         (~tui_data_window): Simplify.
2990
2991 2019-06-25  Tom Tromey  <tom@tromey.com>
2992
2993         * tui/tui-layout.c (show_source_disasm_command)
2994         (show_source_or_disasm_and_command): Update.
2995         * tui/tui-io.c (update_cmdwin_start_line)
2996         (tui_redisplay_readline): Update.
2997         * tui/tui-data.h (struct tui_command_info): Remove.
2998         (struct tui_win_info) <detail>: Remove command_info member.
2999         (struct tui_data_window) <start_line>: New member, from
3000         tui_command_info.
3001         (TUI_CMD_WIN): Add casts.
3002
3003 2019-06-25  Tom Tromey  <tom@tromey.com>
3004
3005         * tui/tui-winsource.c (tui_update_source_window)
3006         (tui_refill_source_window)
3007         (tui_source_window_base::do_scroll_horizontal)
3008         (tui_update_breakpoint_info, tui_set_exec_info_content)
3009         (tui_show_exec_info_content, tui_erase_exec_info_content)
3010         (tui_clear_exec_info_content): Update.
3011         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3012         Update.
3013         * tui/tui-win.c (make_invisible_and_set_new_height)
3014         (make_visible_with_new_height): Update.
3015         * tui/tui-source.c (tui_set_source_content)
3016         (tui_show_symtab_source): Update.
3017         * tui/tui-layout.c (extract_display_start_addr)
3018         (show_source_disasm_command, show_data)
3019         (make_source_or_disasm_window)
3020         (show_source_or_disasm_and_command): Update.
3021         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3022         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3023         "gdbarch".
3024         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3025         to tui_source_window_base.
3026         (struct tui_win_info) <detail>: Remove source_info member.
3027         (struct tui_source_window_base) <has_locator>: Inline.
3028         Move contents from tui_source_info; rename has_locator member to
3029         m_has_locator.
3030         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3031         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3032         header file.
3033         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3034         Simplify.
3035         (tui_free_all_source_wins_content): Cast to
3036         tui_source_window_base.
3037
3038 2019-06-25  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-win.c (make_invisible_and_set_new_height)
3041         (make_visible_with_new_height): Call has_locator method.
3042         * tui/tui-layout.c (show_source_disasm_command, show_data)
3043         (show_source_or_disasm_and_command): Update for bool change.
3044         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3045         (tui_win_info) <has_locator>: New method.
3046         (struct tui_source_window_base) <has_locator>: New method.
3047         (tui_win_has_locator): Don't declare.
3048         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3049         from tui_win_has_locator.
3050         (tui_source_window_base): Use false, not FALSE.
3051
3052 2019-06-25  Tom Tromey  <tom@tromey.com>
3053
3054         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3055         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3056         clear_detail method directly.
3057         (tui_clear_win_detail): Remove.
3058
3059 2019-06-25  Tom Tromey  <tom@tromey.com>
3060
3061         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3062         "this", not TUI_DISASM_WIN.
3063
3064 2019-06-25  Tom Tromey  <tom@tromey.com>
3065
3066         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3067         declare.
3068         * tui/tui-winsource.c
3069         (tui_source_window_base::do_scroll_horizontal): Rename from
3070         tui_horizontal_source_scroll.
3071         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3072         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3073         from tui_vertical_data_scroll.
3074         * tui/tui-win.h (tui_scroll): Don't declare.
3075         * tui/tui-win.c (tui_win_info::forward_scroll)
3076         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3077         (tui_win_info::right_scroll): Rename and update.
3078         (tui_scroll_forward_command, tui_scroll_backward_command)
3079         (tui_scroll_left_command, tui_scroll_right_command): Update.
3080         (tui_scroll): Remove.
3081         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3082         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3083         from tui_vertical_source_scroll.
3084         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3085         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3086         from tui_vertical_disassem_scroll.
3087         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3088         do_scroll_horizontal>: New methods.
3089         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3090         Likewise.
3091         (struct tui_source_window_base): Add do_scroll_horizontal.
3092         (struct tui_source_window, struct tui_disasm_window): Add
3093         do_scroll_vertical.
3094         (struct tui_data_window, struct tui_cmd_window): Add
3095         do_scroll_horizontal and do_scroll_vertical.
3096         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3097
3098 2019-06-25  Tom Tromey  <tom@tromey.com>
3099
3100         * tui/tui-data.h (struct tui_source_window_base): New struct.
3101         (struct tui_source_window): Derive from tui_source_window_base.
3102         (struct tui_disasm_window): New struct.
3103         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3104         from tui_source_window::clear_detail.
3105         (tui_source_window_base): Rename from tui_source_window.
3106         (~tui_source_window_base): Rename from ~tui_source_window.
3107         (tui_alloc_win_info): Create a tui_disasm_window.
3108
3109 2019-06-25  Tom Tromey  <tom@tromey.com>
3110
3111         * tui/tui-data.h (struct tui_source_window)
3112         (struct tui_data_window): Declare destructors.
3113         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3114         destructors.
3115         (tui_win_info): Simplify.
3116
3117 2019-06-25  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-winsource.c (tui_display_main)
3120         (tui_update_source_windows_with_addr)
3121         (tui_update_all_breakpoint_info): Update.
3122         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3123         (new_height_ok, parse_scrolling_args): Update.
3124         * tui/tui-stack.c (tui_show_frame_info): Update.
3125         * tui/tui-data.h (struct tui_list): Remove.
3126         (tui_source_windows): Return a reference to a std::vector.
3127         * tui/tui-data.c (source_windows): Now a std::vector.
3128         (tui_source_windows): Change return type.
3129         (tui_clear_source_windows): Rewrite.
3130         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3131         (tui_free_all_source_wins_content): Rewrite.
3132
3133 2019-06-25  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3136         (struct tui_data_window, struct tui_cmd_window): Declare
3137         clear_detail method.
3138         * tui/tui-data.c (tui_source_window::clear_detail)
3139         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3140         methods.
3141         (tui_clear_win_detail): Simplify.
3142
3143 2019-06-25  Tom Tromey  <tom@tromey.com>
3144
3145         * tui/tui-layout.c (make_source_window, make_disasm_window)
3146         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3147         Return the new window.
3148         (show_source_disasm_command, show_data)
3149         (show_source_or_disasm_and_command): Update.
3150
3151 2019-06-25  Tom Tromey  <tom@tromey.com>
3152
3153         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3154         parameter.  Return the new window.
3155         (show_source_disasm_command): Update and remove NULL check.
3156         (show_source_or_disasm_and_command): Update.
3157
3158 2019-06-25  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3161
3162 2019-06-25  Tom Tromey  <tom@tromey.com>
3163
3164         * tui/tui-data.h (struct tui_win_info): Make constructor
3165         protected.  Make destructor virtual.  Add initializers.
3166         (tui_source_window, tui_data_window, tui_cmd_window): New
3167         classes.
3168         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3169         constructor.  Add "type" parameter.
3170         (tui_source_window, tui_data_window, tui_cmd_window): New
3171         constructors.
3172         (tui_alloc_win_info): Instantiate the appropriate subclass.
3173
3174 2019-06-25  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-win.c (tui_resize_all): Use delete.
3177         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3178         destructor.
3179         (tui_free_window): Don't declare.
3180         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3181         Update.
3182
3183 2019-06-25  Tom Tromey  <tom@tromey.com>
3184
3185         * tui/tui-data.h (struct tui_win_info): Add constructor.
3186         * tui/tui-data.c (tui_alloc_win_info): Use new.
3187         (tui_free_window): Use delete.
3188
3189 2019-06-22  Tom Tromey  <tom@tromey.com>
3190
3191         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3192         declare.
3193         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3194
3195 2019-06-22  Tom Tromey  <tom@tromey.com>
3196
3197         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3198         declare.
3199         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3200
3201 2019-06-22  Tom de Vries  <tdevries@suse.de>
3202
3203         * dwarf2read.c (create_addrmap_from_aranges)
3204         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3205         instead of '%zu'.
3206
3207 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3208
3209         * dwarf2read.h (dwarf2_section_info_def): Remove.
3210         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3211         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3212         std::vector<dwarf2_section_info>.
3213         (struct dwo_file) <~dwo_file>: Remove.
3214         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3215         types field.
3216         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3217         (dwarf2_read_debug_names): Likewise.
3218         (create_debug_types_hash_table): Change parameter type to
3219         array_view, adjust code accordingly.
3220         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3221         (partial_die_info::fixup): Likewise.
3222         (determine_prefix): Likewise.
3223         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3224
3225 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3226
3227         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3228         gdb_bfd_ref_ptr.
3229         <~dwo_file>: Remove call to gdb_bfd_unref.
3230         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3231         gdb_bfd_ref_ptr::get.
3232
3233 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3234
3235         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3236         type to htab_up.
3237         * dwarf2read.c (struct dwo_file): Initialize fields.
3238         <~dwo_file>: New.
3239         (free_dwo_file): Remove, move content to ~dwo_file.
3240         (struct dwo_file_deleter): Remove.
3241         (dwo_file_up>: Remove custom deleter.
3242         (free_dwo_files): Remove.
3243         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3244         dwo_files.
3245         (process_skeletonless_type_units): Call unique_ptr::get.
3246         (allocate_dwo_file_hash_table): Add deleter to created hash
3247         table.  Change return type to htab_up.
3248         (lookup_dwo_file_slot): Don't memset dwo_file, call
3249         unique_ptr::get.
3250         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3251         (create_dwo_unit_in_dwp_v2): Likewise.
3252         (open_and_init_dwo_file): Likewise.
3253         (free_dwo_file_from_slot): Remove.
3254
3255 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3256
3257         * dwarf2read.h (struct dwarf2_section_info) <readin,
3258         is_virtual>: Change type to bool.
3259         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3260         true instead of 1.
3261
3262 2019-06-19  Tom Tromey  <tom@tromey.com>
3263
3264         * tui/tui-data.h (tui_init_content_element): Don't declare.
3265
3266 2019-06-19  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-data.h (tui_init_win_info): Don't declare.
3269
3270 2019-06-19  Tom de Vries  <tdevries@suse.de>
3271
3272         * dwarf2read.h (abstract_to_concrete): Change type to
3273         std::unordered_map<sect_offset, std::vector<sect_offset>,
3274         gdb::hash_enum<sect_offset>>.
3275
3276 2019-06-19  Tom Tromey  <tromey@adacore.com>
3277
3278         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3279         EVAL_AVOID_SIDE_EFFECTS specially.
3280
3281 2019-06-19  Tom Tromey  <tromey@adacore.com>
3282
3283         * source-cache.c (highlighter): New global.
3284         (source_cache::get_source_lines): Create a highlighter on demand.
3285
3286 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3287
3288         * defs.h (deprecated_interactive_hook): Delete declaration.
3289         * interps.c (clear_interpreter_hooks): Remove use of
3290         deprecated_interactive_hook.
3291         * top.c (deprecated_interactive_hook): Delete definition.
3292         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3293
3294 2019-06-18  Tom de Vries  <tdevries@suse.de>
3295
3296         PR gdb/24515
3297         * dwarf2read.h (abstract_to_concrete): Change type from
3298         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3299         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3300         * dwarf2read.c (read_variable): Update.
3301         (dwarf2_fetch_die_loc_sect_off): Update.
3302
3303 2019-06-17  Tom de Vries  <tdevries@suse.de>
3304
3305         PR gdb/24617
3306         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3307         accessing parent[parent_len - 1].
3308
3309 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3310
3311         PR gdb/24364
3312         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3313         call dtrace_process_dof with NULL dof.
3314
3315 2019-06-16  Tom de Vries  <tdevries@suse.de>
3316
3317         PR gdb/24445
3318         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3319
3320 2019-06-16  Tom Tromey  <tom@tromey.com>
3321
3322         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3323         (make_all_visible): Use address of member.
3324
3325 2019-06-16  Tom Tromey  <tom@tromey.com>
3326
3327         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3328         (tui_free_window, free_content, free_content_elements): Remove
3329         unnecessary cast.
3330         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3331         cast.
3332         * tui/tui-regs.c (tui_show_register_group)
3333         (tui_display_registers_from, tui_display_reg_element_at_line):
3334         Remove unnecessary cast.
3335
3336 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3337
3338         * linux-nat.c (normal_mask): Delete.
3339         (_initialize_linux_nat): Don't initialise normal_mask.
3340
3341 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3342
3343         PR gdb/24445
3344         * dwarf-index-write.h (write_psymtabs_to_index): Add
3345         dwz_basename parameter.
3346         * dwarf-index-write.c (write_gdbindex): Move file writing to
3347         write_gdbindex_1.  Change return type void.
3348         (assert_file_size): Move up, remove filename parameter.
3349         (write_gdbindex_1): New function.
3350         (write_debug_names): Change return type to void, call
3351         assert_file_size.
3352         (struct index_wip_file): New struct.
3353         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3354         file logic to index_wip_file.  Write index for dwz file if
3355         needed.
3356         (save_gdb_index_command): Pass basename of dwz file, if present.
3357         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3358         build-id of dwz file, if present.
3359         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3360         (dwarf2_get_dwz_file): Likewise.
3361         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3362         (dwarf2_get_dwz_file): Likewise.
3363
3364 2019-06-16  Tom Tromey  <tom@tromey.com>
3365
3366         * coffread.c (process_coff_symbol): Use xstrdup.
3367         * value.c (create_internalvar): Use xstrdup.
3368
3369 2019-06-16  Tom Tromey  <tom@tromey.com>
3370
3371         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3372         * breakpoint.c (stopin_command, stopat_command)
3373         (until_break_command, decode_location_default): Remove unnecessary
3374         cast.
3375         * utils.c (subset_compare): Remove unnecessary cast.
3376         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3377         cast.
3378         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3379         cast.
3380         * infcmd.c (path_command): Remove unnecessary cast.
3381         * coffread.c (decode_type): Remove unnecessary cast.
3382         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3383         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3384         * tui/tui-stack.c (tui_show_locator_content)
3385         (tui_show_frame_info): Remove unnecessary cast.
3386         * tui/tui-win.c (tui_scroll_forward_command)
3387         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3388         (parse_scrolling_args): Remove unnecessary cast.
3389         * tui/tui-data.c (init_win_info, tui_del_window)
3390         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3391         (free_content_elements): Remove unnecessary cast.
3392         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3393         unnecessary cast.
3394         * tui/tui-source.c (tui_set_source_content)
3395         (tui_vertical_source_scroll): Remove unnecessary cast.
3396         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3397         cast.
3398         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3399         * tui/tui-regs.c (tui_display_registers_from)
3400         (tui_display_register): Remove unnecessary cast.
3401         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3402         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3403         (make_visible): Remove unnecessary cast.
3404         * tui/tui-winsource.c (tui_erase_source_content)
3405         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3406         unnecessary cast.
3407         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3408         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3409         * stabsread.c (read_type, read_array_type, read_range_type):
3410         Remove unnecessary cast.
3411         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3412         (parse_symbol, parse_type, upgrade_type, parse_external)
3413         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3414         unnecessary cast.
3415         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3416
3417 2019-06-16  Tom Tromey  <tom@tromey.com>
3418
3419         * tui/tui-data.c (tui_alloc_generic_win_info)
3420         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3421         checks.
3422
3423 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3424             Andrew Burgess  <andrew.burgess@embecosm.com>
3425
3426         * f-typeprint.c (f_print_type): Don't return early for not
3427         associated or not allocated types.
3428         (f_type_print_varspec_suffix): Add print_rank parameter and print
3429         ranks of array types in case they dangling.
3430         (f_type_print_base): Add print_rank parameter.
3431
3432 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3433
3434         * NEWS: Mention new MI commands.
3435         * break-catch-throw.c (enum exception_event_kind): Move to
3436         breakpoint.h.
3437         (print_mention_exception_catchpoint): Output text as a single
3438         message.
3439         (catch_exception_command_1): Rename to...
3440         (catch_exception_event): ...this, make non-static, update header
3441         command, and change some parameter types.
3442         (catch_catch_command): Update for changes to
3443         catch_exception_command_1.
3444         (catch_throw_command): Likewise.
3445         (catch_rethrow_command): Likewise.
3446         * breakpoint.c (enum exception_event_kind): Delete.
3447         * breakpoint.h (enum exception_event_kind): Moved here from
3448         break-catch-throw.c.
3449         (catch_exception_event): Declare.
3450         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3451         (mi_cmd_catch_throw): New function.
3452         (mi_cmd_catch_rethrow): New function.
3453         (mi_cmd_catch_catch): New function.
3454         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3455         'catch-catch' entries.
3456         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3457         (mi_cmd_catch_rethrow): Declare.
3458         (mi_cmd_catch_catch): Declare.
3459
3460 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3461
3462         * annotate.c (annotate_source_line): Change return type to void,
3463         update implementation to match.
3464         * annotate.h (annotate_source_line): Change return type to void,
3465         update header comment.
3466         * stack.c (print_frame_info): Don't change what frame information
3467         is printed based on whether annotations are on or not.
3468
3469 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3470
3471         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3472         (annotate_source): Make static.
3473         (annotate_source_line): Moved from source.c and renamed from
3474         identify_source_line.  Update the return type.
3475         * annotate.h (annotate_source): Delete declaration.
3476         (annotate_source_line): Declaration moved from source.h, and
3477         renamed from identify_source_line.  Return type updated.
3478         * source.c (identify_source_line): Moved to annotate.c and renamed
3479         to annotate_source_line.
3480         (info_line_command): Remove check of annotation_level.
3481         * source.h (identify_source_line): Move declaration to annotate.h
3482         and rename to annotate_source_line.
3483         * stack.c: Add 'annotate.h' include.
3484         (print_frame_info): Remove check of annotation_level before
3485         calling annotate_source_line.
3486
3487 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3488
3489         * source-cache.c (source_cache::get_plain_source_lines): Use
3490         open_source_file_with_line_charpos instead of just
3491         open_source_file, remove call to find_source_lines.
3492         (source_cache::get_source_lines): Likewise.
3493         * source.c (find_source_lines): Make static.
3494         (get_filename_and_charpos): Renamed into...
3495         (open_source_file_with_line_charpos): ..this along with changes to
3496         return a scoped_fd, and some other minor clean ups.
3497         (identify_source_line): Use open_source_file_with_line_charpos.
3498         (search_command_helper): Use open_source_file_with_line_charpos
3499         instead of just open_source_file, remove call to
3500         find_source_lines.
3501         * source.h (open_source_file_with_line_charpos): Declare new
3502         function.
3503         (find_source_lines): Delete declaration.
3504
3505 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3506
3507         * source.c (get_filename_and_charpos): Remove fullname
3508         parameter.
3509         (identify_source_line): Update call to get_filename_and_charpos.
3510
3511 2019-06-14  Tom Tromey  <tromey@adacore.com>
3512
3513         PR gdb/24502:
3514         * ui-style.h (skip_ansi_escape): Update comment.
3515         * ui-file.h (class no_terminal_escape_file): New class.
3516         * ui-file.c (no_terminal_escape_file::write)
3517         (no_terminal_escape_file::puts): New methods.
3518         * cli/cli-logging.c (handle_redirections): Use
3519         no_terminal_escape_file.
3520
3521 2019-06-14  Tom Tromey  <tromey@adacore.com>
3522
3523         * NEWS: Move convenience variable news above Python news.
3524
3525 2019-06-14  Tom Tromey  <tom@tromey.com>
3526
3527         * gnulib: Move directory to top-level.
3528         * configure.ac: Don't configure gnulib.
3529         * configure: Rebuild.
3530         * common/common-defs.h: Use new path to gnulib.
3531         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3532         (GNULIB_H): Remove.
3533         (INCGNU): Look in new gnulib location.
3534         (HFILES_NO_SRCDIR): Remove gnulib files.
3535         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3536         (generated_files): Remove GNULIB_H.
3537         ($(LIBGNU), all-lib): Remove targets.
3538         (distclean): Don't mention GNULIB_BUILDDIR.
3539         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3540
3541 2019-06-14  Tom Tromey  <tromey@adacore.com>
3542
3543         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3544         Warn if symbol file does not provide any symbols.
3545
3546 2019-06-14  Tom Tromey  <tromey@adacore.com>
3547
3548         * source.c (find_and_open_source): Respect basenames_may_differ.
3549
3550 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3551
3552         * annotate.c (annotate_breakpoints_invalid): Make use of
3553         scoped_restore_terminal_state.
3554         (annotate_frames_invalid): Likewise.
3555
3556 2019-06-14  Tom Tromey  <tromey@adacore.com>
3557
3558         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3559         allow assignment to an internalvar.
3560
3561 2019-06-14  Tom Tromey  <tromey@adacore.com>
3562
3563         * ada-lex.l: Allow "_" in attribute names.
3564
3565 2019-06-14  Tom Tromey  <tromey@adacore.com>
3566
3567         PR gdb/24653:
3568         * regcache.c (registers_changed): Don't call alloca.
3569         * top.c (execute_command): Don't call alloca.
3570
3571 2019-06-13  Pedro Alves  <palves@redhat.com>
3572
3573         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3574         'expression'.  When parsing an expression, error out if there's
3575         junk after "unlimited".
3576         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3577         (do_set_command): Adjust calls to is_unlimited_literal.
3578
3579 2019-06-13  Pedro Alves  <palves@redhat.com>
3580
3581         * compile/compile.c (make_compile_options_def_group): Add braces
3582         around array_view initializer.
3583         * thread.c (make_thread_apply_all_options_def_group)
3584         (make_thread_apply_all_options_def_group): Likewise.
3585
3586 2019-06-13  Pedro Alves  <palves@redhat.com>
3587
3588         * NEWS (New commands): Mention "maint test-options
3589         require-delimiter", "maint test-options unknown-is-error", "maint
3590         test-options unknown-is-operand" and "maint show
3591         test-options-completion-result".
3592         (New command options, command completion): New section.
3593         (Completion improvements): New section.
3594         Mention that you can abbreviate "unlimited".
3595
3596 2019-06-13  Pedro Alves  <palves@redhat.com>
3597
3598         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3599         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3600         * unittests/cli-utils-selftests.c (test_parse_flags)
3601         (test_parse_flags_qcs): Delete.
3602         (test_cli_utils): Don't call deleted functions.
3603
3604 2019-06-13  Pedro Alves  <palves@redhat.com>
3605
3606         * thread.c: Include "cli/cli-option.h".
3607         (tp_array_compar_ascending): Global.
3608         (tp_array_compar): Delete function.
3609         (tp_array_compar_ascending, tp_array_compar_descending): New
3610         functions.
3611         (ascending_option_def, qcs_flag_option_def)
3612         (thr_qcs_flags_option_defs)
3613         (make_thread_apply_all_options_def_group)
3614         (make_thread_apply_options_def_group): New.
3615         (thread_apply_all_command): Use gdb::option::process_options.
3616         (thread_apply_command_completer)
3617         (thread_apply_all_command_completer): New.
3618         (thread_apply_command): Use gdb::option::process_options.
3619         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3620         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3621         to generate help text of "thread apply".  Adjust "taas"'s help.
3622         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3623         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3624
3625 2019-06-13  Pedro Alves  <palves@redhat.com>
3626
3627         * thread.c (thread_apply_command): Check for invalid TID with
3628         isdigit instead of !isalpha.
3629
3630 2019-06-13  Pedro Alves  <palves@redhat.com>
3631
3632         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3633         (validate_flags_qcs): New.
3634         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3635         (validate_flags_qcs): Declare.
3636         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3637         (make_frame_apply_options_def_group): New.
3638         (frame_apply_command_count): Process options with
3639         gdb::option::process_options.
3640         (frame_apply_completer): New.
3641         (frame_apply_level_completer, frame_apply_all_completer)
3642         (frame_apply_completer): New.
3643         (_initialize_stack): Update help of "frame apply", "frame apply
3644         level", "frame apply all" and "faas" to mention supported options
3645         and install command completers.
3646         * stack.h (frame_apply_all_completer): Declare.
3647         * thread.c: Include "stack.h".
3648         (tfaas_command): Add "--".
3649         (_initialize_thread): Update help "tfaas" to mention supported
3650         options and install command completer.
3651
3652 2019-06-13  Pedro Alves  <palves@redhat.com>
3653
3654         * completer.c (complete_nested_command_line): New.
3655         (gdb_completion_word_break_characters_throw): Add assertion.
3656         * completer.h (complete_nested_command_line): Declare.
3657
3658 2019-06-13  Pedro Alves  <palves@redhat.com>
3659
3660         * stack.c (parse_backtrace_qualifiers): New.
3661         (backtrace_command): Use it.
3662         (backtrace_command_completer): Complete on qualifiers.
3663
3664 2019-06-13  Pedro Alves  <palves@redhat.com>
3665
3666         * frame.c: Include "cli/cli-option.h.
3667         (user_set_backtrace_options): New.
3668         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3669         Delete.
3670         (get_prev_frame): Adjust.
3671         (boolean_option_def, uinteger_option_def)
3672         (set_backtrace_option_defs): New.
3673         (_initialize_frame): Adjust and use
3674         gdb::option::add_setshow_cmds_for_options to install "set
3675         backtrace past-main" and "set backtrace past-entry".
3676         * frame.h: Include "cli/cli-option.h".
3677         (struct frame_print_options): Forward declare.
3678         (print_frame_arguments_all, print_frame_arguments_scalars)
3679         (print_frame_arguments_none): Declare.
3680         (print_entry_values): Delete declaration.
3681         (struct frame_print_options, user_frame_print_options): New.
3682         (struct set_backtrace_options): New.
3683         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3684         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3685         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3686         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3687         (list_args_or_locals): Add frame_print_options parameter.
3688         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3689         * python/py-framefilter.c (enumerate_args): Pass down
3690         USER_FRAME_PRINT_OPTIONS.
3691         * stack.c: Include "cli/cli-option.h".
3692         (print_frame_arguments_all, print_frame_arguments_scalars)
3693         (print_frame_arguments_none): Declare.
3694         (print_raw_frame_arguments, print_entry_values): Delete.
3695         (user_frame_print_options): New.
3696         (boolean_option_def, enum_option_def, frame_print_option_defs):
3697         New.
3698         (struct backtrace_cmd_options): New.
3699         (bt_flag_option_def): New.
3700         (backtrace_command_option_defs): New.
3701         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3702         (print_frame_arg, read_frame_arg, print_frame_args)
3703         (print_frame_info, print_frame): Add frame_print_options parameter
3704         and use it.
3705         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3706         (backtrace_command_1): Add frame_print_options and
3707         backtrace_cmd_options parameters and use them.
3708         (make_backtrace_options_def_group): New.
3709         (backtrace_command): Process command options with
3710         gdb::option::process_options.
3711         (backtrace_command_completer): New.
3712         (_initialize_stack): Extend "backtrace"'s help to mention
3713         supported options.  Install completer for "backtrace".
3714         Install some settings commands with add_setshow_cmds_for_options.
3715
3716 2019-06-13  Pedro Alves  <palves@redhat.com>
3717
3718         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3719         and that "set/show print raw frame-arguments" are now deprecated.
3720
3721         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3722         command.
3723         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3724         * stack.c (_initialize_stack): Install "set/show print
3725         raw-frame-arguments", and deprecate "set/show print raw
3726         frame-arguments".
3727         * valprint.c (_initialize_valprint): Deprecate "set/show print
3728         raw".
3729
3730 2019-06-13  Pedro Alves  <palves@redhat.com>
3731
3732         * compile/compile.c (struct compile_options): New.
3733         (compile_flag_option_def, compile_command_option_defs)
3734         (make_compile_options_def_group): New.
3735         (compile_file_command): Handle options with
3736         gdb::option::process_options.
3737         (compile_file_command_completer): New function.
3738         (compile_code_command): Handle options with
3739         gdb::option::process_options.
3740         (compile_code_command_completer): New function.
3741         (_initialize_compiler): Install completers for "compile code" and
3742         "compile file".  Mention available options in "compile code" and
3743         "compile code"'s help.
3744         * completer.c (advance_to_completion_word): New, factored out from
3745         ...
3746         (advance_to_expression_complete_word_point): ... this.
3747         (advance_to_filename_complete_word_point): New.
3748         * completer.h (advance_to_filename_complete_word_point): New
3749         declaration.
3750
3751 2019-06-13  Pedro Alves  <palves@redhat.com>
3752
3753         * compile/compile.c: Include "cli/cli-option.h".
3754         (compile_print_value): Scope data pointer is now a
3755         value_print_options pointer; adjust.
3756         (compile_print_command): Process options.  Scope data pointer is
3757         now a value_print_options pointer; adjust.
3758         (_initialize_compile): Update "compile print"'s help to include
3759         supported options.  Install a completer for "compile print".
3760         * cp-valprint.c (show_vtblprint, show_objectprint)
3761         (show_static_field_print): Delete.
3762         (_initialize_cp_valprint): Don't install "set print
3763         static-members", "set print vtbl", "set print object" here.
3764         * printcmd.c: Include "cli/cli-option.h" and
3765         "common/gdb_optional.h".
3766         (print_command_parse_format): Rework to fill in a
3767         value_print_options instead of a format_data.
3768         (print_value): Change parameter type from format_data pointer to
3769         value_print_options reference.  Adjust.
3770         (print_command_1): Process options.  Adjust to pass down a
3771         value_print_options.
3772         (print_command_completer): New.
3773         (_initialize_printcmd): Install print_command_completer as
3774         handle_brkchars completer for the "print" command.  Update
3775         "print"'s help to include supported options.
3776         * valprint.c: Include "cli/cli-option.h".
3777         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3778         here from cp-valprint.c.
3779         (boolean_option_def, uinteger_option_def)
3780         (value_print_option_defs, make_value_print_options_def_group):
3781         New.  Use gdb::option::add_setshow_cmds_for_options to install
3782         "set print elements", "set print null-stop", "set print repeats",
3783         "set print pretty", "set print union", "set print array", "set
3784         print address", "set print symbol", "set print array-indexes".
3785         * valprint.h: Include <string> and "cli/cli-option.h".
3786         (make_value_print_options_def_group): Declare.
3787         (print_value): Change parameter type from format_data pointer to
3788         value_print_options reference.
3789         (print_command_completer): Declare.
3790
3791 2019-06-13  Pedro Alves  <palves@redhat.com>
3792
3793         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3794         (COMMON_SFILES): Add maint-test-settings.c.
3795         * cli/cli-decode.c (boolean_enums): New global, factored out from
3796         ...
3797         (add_setshow_boolean_cmd): ... here.
3798         * cli/cli-decode.h (boolean_enums): Declare.
3799         * cli/cli-option.c: New file.
3800         * cli/cli-option.h: New file.
3801         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3802         factored out from ...
3803         (parse_cli_boolean_value(const char *)): ... this.
3804         (is_unlimited_literal): Change parameter type to pointer to
3805         pointer.  Adjust and advance ARG pointer.
3806         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3807         (parse_cli_var_enum): New, factored out from ...
3808         (do_set_command): ... this.  Adjust.
3809         * cli/cli-setshow.h (parse_cli_boolean_value)
3810         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3811         (parse_cli_var_enum): Declare.
3812         * cli/cli-utils.c: Include "cli/cli-option.h".
3813         (get_ulongest): New.
3814         * cli/cli-utils.h (get_ulongest): Declare.
3815         (check_for_argument): New overloads.
3816         * maint-test-options.c: New file.
3817
3818 2019-06-13  Pedro Alves  <palves@redhat.com>
3819
3820         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3821         parse a range if "-" is at the end of the string.
3822
3823 2019-06-13  Pedro Alves  <palves@redhat.com>
3824
3825         * cli/cli-setshow.c (parse_auto_binary_operation)
3826         (parse_cli_boolean_value): Don't allow "o".
3827
3828 2019-06-13  Pedro Alves  <palves@redhat.com>
3829
3830         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3831         * NEWS: Mention maint test-settings KIND.
3832         * maint-test-settings.c: New file.
3833
3834 2019-06-13  Pedro Alves  <palves@redhat.com>
3835
3836         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3837         completer.
3838         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3839         "set" completers.
3840
3841 2019-06-13  Pedro Alves  <palves@redhat.com>
3842
3843         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3844         after item.
3845
3846 2019-06-13  Pedro Alves  <palves@redhat.com>
3847
3848         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3849
3850 2019-06-13  Pedro Alves <palves@redhat.com>
3851
3852         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3853         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3854         call.
3855         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3856         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3857         calls.
3858         (check_for_argument): Skip spaces after argument.
3859
3860 2019-06-13  Pedro Alves  <palves@redhat.com>
3861
3862         * thread.c (thread_apply_command): Adjust TID parsing.
3863         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3864         detected before end of string.
3865         (tid_is_in_list): Error out if LIST is invalid.
3866
3867 2019-06-13  Pedro Alves  <palves@redhat.com>
3868
3869         * completer.c (complete_line_internal_1): Rewind completion word
3870         point.
3871         (completion_tracker::advance_custom_word_point_by): Change
3872         parameter type to int.
3873         * completer.h (completion_tracker::advance_custom_word_point_by):
3874         Likewise.
3875
3876 2019-06-13  Pedro Alves  <palves@redhat.com>
3877
3878         * completer.c (advance_to_completion_word): Handle delimiters.
3879
3880 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3881
3882         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3883
3884 2019-06-11  Tom Tromey  <tom@tromey.com>
3885
3886         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3887         (xmalloc_failed): Move to alloc.c.
3888         * alloc.c: New file.
3889         * Makefile.in (COMMON_SFILES): Add alloc.c.
3890
3891 2019-06-11  Tom Tromey  <tom@tromey.com>
3892
3893         * nat/linux-waitpid.c: Don't include server.h.
3894         (linux_debug): Remove.
3895         (my_waitpid): Update.
3896
3897 2019-06-11  Tom Tromey  <tromey@adacore.com>
3898
3899         * infcall.c (_initialize_infcall): Remove trailing newline from
3900         help.
3901         * user-regs.c (_initialize_user_regs): Remove trailing newline
3902         from help.
3903         * typeprint.c (_initialize_typeprint): Remove trailing newline
3904         from help.
3905         * reverse.c (_initialize_reverse): Remove trailing newlines from
3906         help.
3907         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3908         from help.
3909         * language.c (add_set_language_command): Remove trailing newline
3910         from help.
3911         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3912         help.
3913         * disasm.c (_initialize_disasm): Remove trailing newline from
3914         help.
3915         * top.c (init_main): Remove trailing newline from help.
3916         * interps.c (_initialize_interpreter): Remove trailing newline
3917         from help.
3918         * btrace.c (_initialize_btrace): Remove trailing newlines from
3919         help.
3920         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3921         from help.
3922         * python/python.c (_initialize_python): Remove trailing newline
3923         from help.
3924         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3925         help.
3926         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3927         from help.  Reformat some text.
3928         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3929         from help.
3930         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3931         newline from help.
3932
3933 2019-06-11  Tom Tromey  <tromey@adacore.com>
3934
3935         * darwin-nat.c (darwin_decode_exception_message)
3936         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3937
3938 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * valops.c (value_slice): Check for not allocated or not
3941         associated values.
3942
3943 2019-06-10  Tom de Vries  <tdevries@suse.de>
3944
3945         PR gdb/24618
3946         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3947         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3948         invalid.
3949
3950 2019-06-10  Tom de Vries  <tdevries@suse.de>
3951
3952         PR gdb/24611
3953         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3954         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3955
3956 2019-06-10  Tom de Vries  <tdevries@suse.de>
3957
3958         PR symtab/24545
3959         * symtab.c (struct demangled_name_entry): Add language field.
3960         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3961         static minimal symbol".  Set and use language field.
3962
3963 2019-06-10  Tom Tromey  <tromey@adacore.com>
3964
3965         * ada-lang.c (_initialize_ada_language): Update help text.
3966
3967 2019-06-10  Tom Tromey  <tromey@adacore.com>
3968
3969         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3970         with a newline.
3971         * guile/guile.c (handle_boot_error): Don't end warning with a
3972         newline.
3973         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3974         warning with a newline.
3975         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3976         newline.
3977         (s12z_frame_cache): Likewise.
3978         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3979         a newline.
3980         * solib-svr4.c (disable_probes_interface): Don't end warning with
3981         a newline.
3982         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3983         newline.
3984         * python/python.c (do_finish_initialization): Don't end warning
3985         with a newline.
3986
3987 2019-06-10  Tom Tromey  <tom@tromey.com>
3988
3989         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3990         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3991         gdbpy_enter.
3992
3993 2019-06-10  Tom Tromey  <tromey@adacore.com>
3994
3995         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3996         data.
3997         (elf_new_init): Don't call stabsread_new_init.
3998         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3999         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4000         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4001
4002 2019-06-10  Tom de Vries  <tdevries@suse.de>
4003
4004         PR symtab/16264
4005         PR symtab/24517
4006         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4007
4008 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4009
4010         * source.c (find_and_open_source): Also rewrite relative file
4011         names.
4012
4013 2019-04-26  Amos Bird  <amosbird@gmail.com>
4014
4015         * annotate.c (annotate_thread_exited): Add "thread-exited"
4016         annotation.
4017
4018 2019-06-06  Tom Tromey  <tromey@adacore.com>
4019
4020         * maint.h (class scoped_command_stats): Use
4021         DISABLE_COPY_AND_ASSIGN.
4022         <print_time>: New method.
4023         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4024         print_time.
4025         (scoped_command_stats::print_time): New method.
4026
4027 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4028
4029         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4030         instructions of lengths 6 or 8 bytes.
4031
4032 2019-06-04  Pedro Alves  <palves@redhat.com>
4033
4034         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4035
4036         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4037         * breakpoint.c (condition_completer): Likewise.
4038         * cli/cli-dump.c (scan_expression): Likewise.
4039         * common/filestuff.c (mkdir_recursive): Likewise.
4040         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4041         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4042         (gdb_abspath): Likewise.
4043         * compile/compile-cplus-types.c
4044         (compile_cplus_instance::decl_name): Likewise.
4045         * completer.c (complete_explicit_location):
4046         (signal_completer, reg_or_group_completer_1): Likewise.
4047         * cp-support.c (cp_remove_params_if_any): Likewise.
4048         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4049         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4050         * infcmd.c (strip_bg_char): Likewise.
4051         * linespec.c (copy_token_string): Likewise.
4052         * mi/mi-main.c (output_cores): Likewise.
4053         * psymtab.c (psymtab_search_name):
4054         * symfile.c (test_set_ext_lang_command): Likewise.
4055         * target.c (target_fileio_read_stralloc): Likewise.
4056         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4057         * value.c (complete_internalvar): Likewise.
4058
4059 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4060
4061         Add objfile property to gdb.Type.
4062         * NEWS: Mention Python API addition.
4063         * python/py-type.c (typy_get_objfile): New method.
4064
4065 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4066
4067         * NEWS: Mention the new set|show style [title|highlight].
4068         Mention changes to "show style", "help" and "apropos".
4069
4070 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4071
4072         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4073         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4074         instead of print_help_for_command.
4075         (print_doc_of_command): New function.
4076         (help_list): Add 'apropos -v word' suggestion.
4077         (print_help_for_command): Style the command name using title style.
4078         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4079         (_initialize_cli_cmds): Describe -v in apropos_command help.
4080
4081 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4082
4083         * cli/cli-style.h (cli_style_option): Add name in constructor,
4084         add m_name class member, add constructor with intensity,
4085         add name class function.
4086         (cli_style_option::add_setshow_commands): Remove name argument.
4087         (highlight_style, title_style): New styles.
4088         * cli/cli-style.c (do_show): New function that shows a style
4089         characteristic styling the style name with itself.
4090         (set_style_name): New function.
4091         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4092         Update all callers according to the changes in cli/cli-style.h.
4093         * utils.h (fputs_highlighted): New function.
4094         * utils.c (fputs_highlighted): Likewise.
4095
4096 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4097
4098         * NEWS: Mention new pipe command and new convenience variables.
4099
4100 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4101
4102         * cli/cli-cmds.c (pipe_command): New function.
4103         (_initialize_cli_cmds): Call add_com for pipe_command.
4104         Define | as an alias for pipe.
4105         (exit_status_set_internal_vars): New function.
4106         (shell_escape): Call exit_status_set_internal_vars.
4107         cli/cli-decode.c (find_command_name_length): Recognize | as
4108         a single character command.
4109
4110 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4111
4112         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4113         top.c (execute_command_to_ui_file): New function, mostly a copy
4114         of execute_command_to_string.
4115         (execute_command_to_string): Implement by calling
4116         execute_command_to_ui_file.
4117
4118 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4119
4120         * top.h (saved_command_line): Remove declaration.
4121         * top.c (previous_saved_command_line, previous_repeat_arguments):
4122         New variables.
4123         (saved_command_line): Make static, define together with other
4124         'repeat variables'.
4125         (dont_repeat): Clear repeat_arguments.
4126         (repeat_previous, get_saved_command_line, save_command_line):
4127         New functions.
4128         (gdb_init): Initialize saved_command_line
4129         and previous_saved_command_line.
4130         * main.c (captured_main_1): Remove saved_command_line initialization.
4131         * event-top.c (handle_line_of_input): Update to use
4132         the new 'repeat' related functions instead of direct access to
4133         saved_command_line.
4134         * command.h (repeat_previous, get_saved_command_line,
4135         save_command_line): New declarations.
4136         (dont_repeat): Add comment.
4137
4138 2019-05-30  Tom Tromey  <tromey@adacore.com>
4139
4140         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4141         Fix comment.
4142         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4143
4144 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4145
4146         PR cli/24587
4147         * completer.c (complete): Initialize variable word.
4148
4149 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4150
4151         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4152         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4153         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4154         'body' is NULL to the outter 'if', protecting the '!is_define'
4155         situation as well.
4156
4157 2019-05-29  Tom Tromey  <tromey@adacore.com>
4158
4159         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4160         (dwarf_unknown): New function.
4161         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4162         (dwarf_type_encoding_name): Use dwarf_unknown.
4163
4164 2019-05-29  Tom Tromey  <tromey@adacore.com>
4165
4166         PR c++/20020:
4167         * cp-valprint.c (cp_print_value_fields): Call
4168         cp_print_static_field inside "try".
4169
4170 2019-05-29  Tom Tromey  <tromey@adacore.com>
4171
4172         * inflow.c (struct terminal_info): Add default operator=.
4173         * configure: Rebuild.
4174         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4175         -Wdeprecated-copy-dtor, -Wredundant-move.
4176
4177 2019-05-29  Tom Tromey  <tromey@adacore.com>
4178
4179         * NEWS: Add entry.
4180         * infcmd.c (print_return_value_1): Handle finish_print
4181         option.
4182         (show_print_finish): New function.
4183         (_initialize_infcmd): Add "set/show print finish" commands.
4184         * valprint.c (user_print_options): Initialize new member.
4185         * valprint.h (struct value_print_options) <finish_print>: New
4186         member.
4187
4188 2019-05-28  Tom Tromey  <tromey@adacore.com>
4189
4190         * ada-lang.c (ada_remove_Xbn_suffix)
4191         (find_old_style_renaming_symbol)
4192         (parse_old_style_renaming): Remove.
4193         (ada_find_renaming_symbol): Don't call
4194         find_old_style_renaming_symbol.
4195         (ada_is_renaming_symbol): Rename from
4196         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4197         bool.  Now static.
4198         (ada_read_var_value): Update and simplify.
4199         * ada-exp.y (write_var_or_type): Remove old code.
4200
4201 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4202
4203         * event-top.c: Remove include comment.
4204         * inflow.c (class scoped_ignore_sigttou): Move from here...
4205         * inflow.h (class scoped_ignore_sigttou): ...to here.
4206         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4207         * top.c:  Remove include comment.
4208
4209 2019-05-27  Tom Tromey  <tom@tromey.com>
4210
4211         * NEWS: Fix typo.
4212
4213 2019-05-22  Tom Tromey  <tromey@adacore.com>
4214
4215         * target.c (target_follow_exec): Constify parameter.
4216         * target-delegates.c: Rebuild.
4217         * remote.c (remote_target::follow_exec): Constify parameter.
4218         * infrun.c (follow_exec): Constify parameter.
4219         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4220         (target_follow_exec): Likewise.
4221
4222 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4223
4224         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4225         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4226
4227 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4228
4229         * NEWS: Add debugredirect and testsuite sections.
4230
4231 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4232
4233         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4234         target descriptions using exclusively floating point register name
4235         aliases.
4236
4237 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4238
4239         PR gdb/18644:
4240         * f-lang.c (build_fortran_types): Handle the case where
4241         gdbarch_floatformat_for_type returns a nullptr.
4242
4243 2019-05-21  Tom de Vries  <tdevries@suse.de>
4244
4245         PR cli/24587
4246         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4247
4248 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4249
4250         PR gdb/18644:
4251         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4252         16-byte floats.
4253         * i386-tdep.c (i386_floatformat_for_type): Use
4254         floatformats_ia64_quad for the 16-byte floating point component
4255         within a fortran 32-byte complex number.
4256
4257 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4260         delete default constructor.
4261         (find_partial_die): Update to return const struct.
4262         (partial_die_parent_scope): Move variable declaration into scope
4263         of its use and change its type to auto.
4264         (guess_partial_die_structure_name): Likewise.
4265         (partial_die_info::fixup): Likewise.
4266
4267 2019-05-17  Tom Tromey  <tromey@adacore.com>
4268
4269         * source.c (find_and_open_source): Remove cast.
4270
4271 2019-05-17  Tom Tromey  <tromey@adacore.com>
4272
4273         * annotate.c (annotate_source): Make "filename" const.
4274         * annotate.h (annotate_source): Use const.
4275
4276 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4277
4278         * disasm.c (set_disassembler_options): Send errors to stderr.
4279
4280 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4281
4282         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4283         (cli_interp_base::set_logging): Check debug_redirect.
4284         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4285         * cli/cli-logging.c (debug_redirect): Add static variable.
4286         (pop_output_files): Add default param.
4287         (handle_redirections): Print debug setting.
4288         (show_logging_command): Likewise.
4289         (_initialize_cli_logging): Add debugredirect command.
4290         * interps.c (current_interp_set_logging): Add debug_redirect
4291         parameter.
4292         * interps.h (set_logging): Add debug_redirect parameter.
4293         (current_interp_set_logging): Likewise.
4294         * mi/mi-common.h: Likewise.
4295         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4296
4297 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4298             Tom Tromey  <tromey@adacore.com>
4299
4300         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4301         directly.
4302         * cli/cli-interp.h (make_logging_output): Remove declaration.
4303         * cli/cli-logging.c (make_logging_output): Remove function.
4304         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4305         directly.
4306         * ui-file.c (tee_file::tee_file): Remove bools.
4307         (tee_file::~tee_file): Remove deletes.
4308         * ui-file.h (tee_file): Remove bools.
4309
4310 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4311
4312         * mi/mi-cmds.h (mi_cmd_complete): New function.
4313         * mi/mi-main.c (mi_cmd_complete): Likewise.
4314         * mi/mi-cmds.c: Define new MI command -complete.
4315         * NEWS: Mention new -complete command.
4316
4317 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4318
4319         * completer.h (complete): New function.
4320         * completer.c (complete): Likewise.
4321         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4322         function defined in completer.h.
4323
4324 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4325
4326         * MAINTAINERS (Write After Approval): Add myself.
4327
4328 2019-05-17  Tom de Vries  <tdevries@suse.de>
4329
4330         PR gdb/24094
4331         * dwarf2read.c (struct cu_partial_die_info): New struct.
4332         (find_partial_die): Return cu_partial_die_info.
4333         (partial_die_parent_scope, guess_partial_die_structure_name)
4334         (partial_die_info::fixup): Handle new return type of find_partial_die.
4335
4336 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4337
4338         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4339         "std::string", simplifying the algorithm.
4340
4341 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4342
4343         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4344         (stap_static_probe_ops::get_probes): Likewise.
4345
4346 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4347
4348         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4349         '-')" and "else if".
4350         (stap_parse_single_operand): Join checks for
4351         "gdbarch_stap_parse_special_token_p" and
4352         "gdbarch_stap_parse_special_token" in the same "if" statement.
4353         Invert check when verifying for operation on register
4354         displacement.
4355
4356 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4357
4358         * stap-probe.c (stap_get_opcode): Update comment.
4359         (stap_get_expected_argument_type): Likewise.
4360         (handle_stap_probe): Likewise.
4361
4362 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4363
4364         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4365         return type to 'bool'.  Adjust comment.  Use 'bool' when
4366         appropriate.
4367         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4368         * stap-probe.c (stap_parse_argument_1): Likewise.
4369         (stap_is_operator): Likewise.
4370         (stap_is_generic_prefix): Likewise.
4371         (stap_is_register_prefix): Likewise.
4372         (stap_is_register_indirection_prefix): Likewise.
4373         (stap_is_integer_prefix): Likewise.
4374         (stap_generic_check_suffix): Likewise.
4375         (stap_check_integer_suffix): Likewise.
4376         (stap_check_register_suffix): Likewise.
4377         (stap_check_register_indirection_suffix): Likewise.
4378         (stap_parse_register_operand): Likewise.
4379         (stap_parse_single_operand): Likewise.
4380         (stap_parse_argument_1): Likewise.
4381         (stap_probe::get_argument_count): Likewise.
4382         (stap_is_operator): Likewise.
4383
4384 2019-05-16  Tom Tromey  <tromey@adacore.com>
4385
4386         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4387         keyword to foreach.
4388
4389 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4390
4391         * linux-thread-db.c (try_thread_db_load_1): Change return type
4392         to bool.
4393         (try_thread_db_load): Likewise.
4394         (try_thread_db_load_from_pdir_1): Likewise.
4395         (try_thread_db_load_from_pdir): Likewise.
4396         (try_thread_db_load_from_sdir): Likewise.
4397         (try_thread_db_load_from_dir): Likewise.
4398         (thread_db_load_search): Likewise.
4399         (has_libpthread): Likewise.
4400         (thread_db_load): Likewise.
4401
4402 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4403
4404         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4405         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4406         NULL, and complain/return if that's the case.
4407
4408 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4409
4410         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4411         (advance, posn, abstract_read_memory): New functions.
4412         [struct mem_read_abstraction]: New struct.
4413         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4414
4415 2019-05-14  Tom Tromey  <tromey@adacore.com>
4416
4417         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4418         value is not lval_memory.
4419
4420 2019-05-14  Tom Tromey  <tromey@adacore.com>
4421
4422         * solib.c (info_sharedlibrary_command): Style the file name.
4423
4424 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4425
4426         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4427         (aarch64_vnv_type): Likewise.
4428         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4429         * common/tdesc.c: Likewise.
4430         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4431         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4432         * features/aarch64-fpu.xml: Add ieee half view.
4433         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4434         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4435         * gdbtypes.h (struct builtin_type): Likewise.
4436         (struct objfile_type): Likewise.
4437
4438 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4439
4440         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4441         typo.
4442         * location.h (string_to_event_location): Likewise.
4443
4444 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4445
4446         GDB 8.3 released.
4447
4448 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4449
4450         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4451         New variable declaration.
4452         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4453         New variable.
4454         (print_one_breakpoint): Use ui_out::test_flags and new global
4455         variable to compute use_fixed_output.
4456         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4457         Remove.
4458         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4459         (mi_multi_location_breakpoint_output_fixed): Remove.
4460         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4461         new variable.
4462         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4463         fix_multi_location_breakpoint_output flag if version >= 3.
4464         * ui-out.h (enum ui_out_flag)
4465         <fix_multi_location_breakpoint_output>: New enumerator.
4466
4467 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4468
4469         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4470
4471 2019-05-10  Tom Tromey  <tromey@adacore.com>
4472
4473         * ada-lang.c (catch_ada_completer): New function.
4474         (_initialize_ada_language): Use it.
4475
4476 2019-05-10  Tom Tromey  <tromey@adacore.com>
4477
4478         * thread.c (print_thread_info): Make "requested_threads" const.
4479         * gdbthread.h (print_thread_info): Make "requested_threads"
4480         const.
4481         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4482         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4483
4484 2019-05-08  Tom Tromey  <tom@tromey.com>
4485
4486         * gdbtypes.c (objfile_type_data): Change type.
4487         (objfile_type, _initialize_gdbtypes): Update.
4488
4489 2019-05-08  Tom Tromey  <tom@tromey.com>
4490
4491         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4492         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4493         (_initialize_dwarf2_frame): Update.
4494
4495 2019-05-08  Tom Tromey  <tom@tromey.com>
4496
4497         * objc-lang.c (objc_objfile_data): Change type.
4498         (find_methods): Update.
4499         (_initialize_objc_lang): Remove.
4500
4501 2019-05-08  Tom Tromey  <tom@tromey.com>
4502
4503         * stabsread.c (rs6000_builtin_type_data): Change type.
4504         (rs6000_builtin_type, _initialize_stabsread): Update.
4505
4506 2019-05-08  Tom Tromey  <tom@tromey.com>
4507
4508         * mips-tdep.c (mips_pdr_data): Remove.
4509         (_initialize_mips_tdep): Update.
4510
4511 2019-05-08  Tom Tromey  <tom@tromey.com>
4512
4513         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4514         (hppa_init_objfile_priv_data, read_unwind_info)
4515         (find_unwind_entry, _initialize_hppa_tdep): Update.
4516
4517 2019-05-08  Tom Tromey  <tom@tromey.com>
4518
4519         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4520         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4521         on obstack.
4522         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4523
4524 2019-05-08  Tom Tromey  <tom@tromey.com>
4525
4526         * mdebugread.c (basic_type_data): Change type.
4527         (basic_type, _initialize_mdebugread): Update.
4528
4529 2019-05-08  Tom Tromey  <tom@tromey.com>
4530
4531         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4532
4533 2019-05-08  Tom Tromey  <tom@tromey.com>
4534
4535         * nto-tdep.c (nto_inferior_data_reg): Change type.
4536         (nto_inferior_data): Update.
4537         (nto_inferior_data_cleanup, nto_new_inferior_data)
4538         (_initialize_nto_tdep): Remove.
4539         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4540
4541 2019-05-08  Tom Tromey  <tom@tromey.com>
4542
4543         * ada-lang.c (struct ada_inferior_data): Add initializers.
4544         (ada_inferior_data): Change type.
4545         (ada_inferior_data_cleanup): Remove.
4546         (get_ada_inferior_data, ada_inferior_exit)
4547         (struct ada_pspace_data): Add initializers, destructor.
4548         (ada_pspace_data_handle): Change type.
4549         (get_ada_pspace_data): Update.
4550         (ada_pspace_data_cleanup): Remove.
4551
4552 2019-05-08  Tom Tromey  <tom@tromey.com>
4553
4554         * coffread.c (struct coff_symfile_info): Add initializers.
4555         (coff_objfile_data_key): Move lower.  Change type.
4556         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4557         Update.
4558         (coff_free_info): Remove.
4559
4560 2019-05-08  Tom Tromey  <tom@tromey.com>
4561
4562         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4563         (fbsd_pspace_data_handle): Move lower.  Change type.
4564         (get_fbsd_pspace_data): Update.
4565         (fbsd_pspace_data_cleanup): Remove.
4566         (_initialize_fbsd_tdep): Update.
4567
4568 2019-05-08  Tom Tromey  <tom@tromey.com>
4569
4570         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4571         (get_ada_tasks_pspace_data): Update.
4572         (ada_tasks_pspace_data_cleanup): Remove.
4573         (_initialize_tasks): Update.
4574         (ada_tasks_inferior_data_handle): Change type.
4575         (get_ada_tasks_inferior_data): Update.
4576         (ada_tasks_inferior_data_cleanup): Remove.
4577         (struct ada_tasks_pspace_data): Add initializers.
4578
4579 2019-05-08  Tom Tromey  <tom@tromey.com>
4580
4581         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4582         * symfile-debug.c (debug_sym_get_probes): Change type.
4583         * stap-probe.c (handle_stap_probe):
4584         (stap_static_probe_ops::get_probes): Change type.
4585         * probe.h (class static_probe_ops) <get_probes>: Change type.
4586         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4587         (parse_probes_in_pspace): Update.
4588         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4589         Update.
4590         (any_static_probe_ops::get_probes): Change type.
4591         * elfread.c (elfread_data): New typedef.
4592         (probe_key): Change type.
4593         (elf_get_probes): Likewise.  Update.
4594         (probe_key_free): Remove.
4595         (_initialize_elfread): Update.
4596         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4597         Change type.
4598         (dtrace_process_dof_probe, dtrace_process_dof)
4599         (dtrace_static_probe_ops::get_probe): Change type.
4600
4601 2019-05-08  Tom Tromey  <tom@tromey.com>
4602
4603         * xcoffread.c (struct xcoff_symfile_info): Rename from
4604         coff_symfile_info.  Add initializers.
4605         (xcoff_objfile_data_key): Move lower.  Change type.
4606         (XCOFF_DATA): Rewrite.
4607         (xcoff_free_info): Remove.
4608         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4609         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4610         (xcoff_initial_scan): Update.
4611
4612 2019-05-08  Tom Tromey  <tom@tromey.com>
4613
4614         * solib-svr4.c (struct svr4_info): Add initializers and
4615         destructor.
4616         <probes_table>: Now an htab_up.
4617         (solib_svr4_pspace_data): Change type.
4618         (free_probes_table): Simplify.
4619         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4620         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4621         (probes_table_remove_objfile_probes, register_solib_event_probe)
4622         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4623         (_initialize_svr4_solib): Update.
4624
4625 2019-05-08  Tom Tromey  <tom@tromey.com>
4626
4627         * remote.c (remote_pspace_data): Change type.
4628         (remote_pspace_data_cleanup): Remove.
4629         (get_remote_exec_file, set_pspace_remote_exec_file)
4630         (_initialize_remote): Update.
4631
4632 2019-05-08  Tom Tromey  <tom@tromey.com>
4633
4634         * breakpoint.c (breakpoint_objfile_key): Change type.
4635         (get_breakpoint_objfile_data): Update.
4636         (free_breakpoint_objfile_data): Remove.
4637         (_initialize_breakpoint): Update.
4638
4639 2019-05-08  Tom Tromey  <tom@tromey.com>
4640
4641         * linux-tdep.c (struct linux_info): Add initializers.
4642         (linux_inferior_data): Move.  Change type.
4643         (invalidate_linux_cache_inf): Update.
4644         (linux_inferior_data_cleanup): Remove.
4645         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4646
4647 2019-05-08  Tom Tromey  <tom@tromey.com>
4648
4649         * auxv.c (auxv_inferior_data): Move.  Change type.
4650         (auxv_inferior_data_cleanup): Remove.
4651         (invalidate_auxv_cache_inf): Rewrite.
4652         (get_auxv_inferior_data, _initialize_auxv): Update.
4653
4654 2019-05-08  Tom Tromey  <tom@tromey.com>
4655
4656         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4657         (symfile_debug_objfile_data_key): Change type.
4658         (symfile_debug_installed, debug_qf_has_symbols)
4659         (debug_qf_find_last_source_symtab)
4660         (debug_qf_forget_cached_source_info)
4661         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4662         (debug_qf_print_stats, debug_qf_dump)
4663         (debug_qf_expand_symtabs_for_function)
4664         (debug_qf_expand_all_symtabs)
4665         (debug_qf_expand_symtabs_with_fullname)
4666         (debug_qf_map_matching_symbols)
4667         (debug_qf_expand_symtabs_matching)
4668         (debug_qf_find_pc_sect_compunit_symtab)
4669         (debug_qf_map_symbol_filenames)
4670         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4671         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4672         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4673         (debug_sym_read_linetable, debug_sym_relocate): Update.
4674         (symfile_debug_free_objfile): Remove.
4675         (install_symfile_debug_logging, _initialize_symfile_debug):
4676         Update.
4677
4678 2019-05-08  Tom Tromey  <tom@tromey.com>
4679
4680         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4681         allocate_on_obstack.
4682         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4683         (get_dwarf2_per_objfile): Update.
4684         (set_dwarf2_per_objfile): Remove.
4685         (dwarf2_has_info, dwarf2_get_section_info): Update.
4686         (dwarf2_free_objfile): Remove.
4687         (_initialize_dwarf2_read): Update.
4688
4689 2019-05-08  Tom Tromey  <tom@tromey.com>
4690
4691         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4692         initializers.
4693         <unsupported_script_warning_printed,
4694         script_not_found_warning_printed>: Now bool.
4695         (auto_load_pspace_data): Change type.
4696         (~auto_load_pspace_info): Rename from
4697         auto_load_pspace_data_cleanup.
4698         (get_auto_load_pspace_data, init_loaded_scripts_info)
4699         (clear_section_scripts, maybe_print_unsupported_script_warning)
4700         (maybe_print_script_not_found_warning, _initialize_auto_load):
4701         Update.
4702
4703 2019-05-08  Tom Tromey  <tom@tromey.com>
4704
4705         * objfiles.c (objfile_pspace_info): Add destructor and
4706         initializers.
4707         (objfiles_pspace_data): Change type.
4708         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4709         (get_objfile_pspace_data): Update.
4710         (objfiles_bfd_data): Change type.
4711         (get_objfile_bfd_data): Update.
4712         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4713
4714 2019-05-08  Tom Tromey  <tom@tromey.com>
4715
4716         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4717         Change type.
4718         (get_catch_syscall_inferior_data): Update.
4719         (catch_syscall_inferior_data_cleanup): Remove.
4720         (_initialize_break_catch_syscall): Update.
4721
4722 2019-05-08  Tom Tromey  <tom@tromey.com>
4723
4724         * inflow.c (struct terminal_info): Add destructor and
4725         initializers.
4726         (inflow_inferior_data): Change type.
4727         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4728         (get_inflow_inferior_data, inflow_inferior_exit)
4729         (swap_terminal_info, _initialize_inflow): Update.
4730
4731 2019-05-08  Tom Tromey  <tom@tromey.com>
4732
4733         * target-dcache.c (target_dcache_cleanup): Remove.
4734         (target_dcache_aspace_key): Change type.
4735         (target_dcache_init_p, target_dcache_invalidate)
4736         (target_dcache_get, target_dcache_get_or_init)
4737         (_initialize_target_dcache): Update.
4738         * dcache.h (struct dcache_deleter): New.
4739
4740 2019-05-08  Tom Tromey  <tom@tromey.com>
4741
4742         * symtab.c (struct symbol_cache): Add destructor and
4743         initializers.
4744         (symbol_cache_key): Move.  Change type.
4745         (make_symbol_cache, free_symbol_cache): Remove.
4746         (get_symbol_cache): Update.
4747         (symbol_cache_cleanup): Remove.
4748         (ALL_PSPACES, symbol_cache_flush)
4749         (maintenance_print_symbol_cache)
4750         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4751         Update.
4752
4753 2019-05-08  Tom Tromey  <tom@tromey.com>
4754
4755         * symtab.c (struct main_info): Add destructor and initializers.
4756         (main_progspace_key): Move.  Change type.
4757         (get_main_info): Update.
4758         (main_info_cleanup): Remove.
4759         (_initialize_symtab): Update.
4760
4761 2019-05-08  Tom Tromey  <tom@tromey.com>
4762
4763         * registry.h (DECLARE_REGISTRY): Define the _key class.
4764
4765 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4766
4767         * NEWS: Merge two 'New commands' sections.
4768
4769 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4770
4771         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4772         parameter and use Ada language definition instead.
4773         (ada_val_print_ptr): Remove unused language parameter.
4774         (ada_val_print_num): Remove language parameter and use Ada language
4775         definition instead.
4776         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4777         parameter.
4778         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4779         parameter and use Ada language definition instead.
4780         (ada_val_print_1): Update all ada_val_print_xxx calls.
4781         Remove language parameter.
4782         (ada_val_print): Update ada_val_print_1 call.
4783
4784 2019-05-08  Tom Tromey  <tromey@adacore.com>
4785
4786         * remote.c (remote_hw_watchpoint_limit)
4787         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4788         Now static.
4789
4790 2019-05-08  Tom Tromey  <tromey@adacore.com>
4791
4792         * maint.c (_initialize_maint_cmds): Move initialization code to
4793         remote.c.
4794         (watchdog, show_watchdog): Move to remote.c.
4795         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4796         "watchdog" static.
4797         (_initialize_remote): Move initialization code from maint.c.
4798         * defs.h (watchdog): Don't declare.
4799
4800 2019-05-08  Tom Tromey  <tromey@adacore.com>
4801
4802         * tui/tui-interp.c: Include main.h.
4803         * interps.c: Include main.h.
4804         * main.h (interpreter_p): Declare.
4805         * defs.h (interpreter_p): Don't declare.
4806
4807 2019-05-08  Tom Tromey  <tromey@adacore.com>
4808
4809         * dwarf2loc.c: Include dwarf2read.h.
4810         * defs.h (read_unsigned_leb128): Don't declare.
4811         * dwarf2read.h (read_unsigned_leb128): Declare.
4812
4813 2019-05-08  Tom Tromey  <tromey@adacore.com>
4814
4815         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4816         method.
4817
4818 2019-05-08  Tom Tromey  <tromey@adacore.com>
4819
4820         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4821         when no wrap column is set.
4822
4823 2019-05-08  Tom Tromey  <tromey@adacore.com>
4824
4825         * c-lang.c (c_get_string): Handle non-C-style arrays.
4826
4827 2019-05-08  Tom Tromey  <tromey@adacore.com>
4828
4829         * typeprint.c (print_offset_data::update): Print the bit offset,
4830         not the number of bits remaining.
4831
4832 2019-05-08  Tom Tromey  <tromey@adacore.com>
4833
4834         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4835         padding at end of comment.
4836
4837 2019-05-08  Tom Tromey  <tromey@adacore.com>
4838
4839         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4840         Compare main types.
4841
4842 2019-05-06  Tom Tromey  <tom@tromey.com>
4843
4844         * common/scoped_mmap.c: Include common-defs.h.
4845         * common/scoped_mmap.h: Don't include config.h.
4846
4847 2019-05-04  Tom Tromey  <tom@tromey.com>
4848
4849         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4850         (struct aarch64_call_info): Add initializers.
4851         <si>: Now a std::vector.
4852         (pass_on_stack, aarch64_push_dummy_call): Update.
4853
4854 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4855             Tom Tromey  <tom@tromey.com>
4856
4857         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4858         (ppc_threads): Now a std::vector.  Now static.
4859         (hwdebug_find_thread_points_by_tid)
4860         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4861         Update.
4862
4863 2019-05-04  Tom Tromey  <tom@tromey.com>
4864
4865         * arc-tdep.c (arc_tdesc_init): Return bool.
4866
4867 2019-05-04  Tom Tromey  <tom@tromey.com>
4868
4869         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4870         Use gdb_assert_not_reached.
4871
4872 2019-05-04  Tom Tromey  <tom@tromey.com>
4873
4874         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4875         "false".
4876
4877 2019-05-04  Tom Tromey  <tom@tromey.com>
4878
4879         * arc-tdep.c (arc_tdesc_init): Use bool.
4880
4881 2019-05-04  Tom Tromey  <tom@tromey.com>
4882
4883         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4884
4885 2019-05-04  Tom Tromey  <tom@tromey.com>
4886
4887         * cli/cli-cmds.c (valid_command_p): Return bool.
4888
4889 2019-05-04  Tom Tromey  <tom@tromey.com>
4890
4891         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4892         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4893
4894 2019-05-04  Raul Tambre  <raul@tambre.ee>
4895
4896         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4897         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4898         operator for comparison.
4899
4900 2019-05-04  Tom Tromey  <tom@tromey.com>
4901
4902         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4903         (lookup_partial_symbol, print_partial_symbols)
4904         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4905         (psymbol_compare): Update.
4906         (add_psymbol_to_bcache): Clear the entire psymbol.
4907         (maintenance_check_psymtabs): Update.
4908         * psympriv.h (struct partial_symbol): Don't derive from
4909         general_symbol_info.
4910         <obj_section, unrelocated_address, address,
4911         set_unrelocated_address>: Update.
4912         <ginfo>: New member.
4913         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4914         (debug_names::write_psymbols): Update.
4915
4916 2019-05-04  Tom de Vries  <tdevries@suse.de>
4917
4918         * contrib/cc-with-tweaks.sh: Support -n arg.
4919
4920 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4921
4922         * corelow.c (core_target::detach): Ensure frame cache and
4923         register caches are cleared.
4924         inferior.c (exit_inferior_1): Likewise.
4925
4926 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4927             Tom Tromey  <tom@tromey.com>
4928
4929         * dictionary.c (collate_pending_symbols_by_language): Remove
4930         "struct" from foreach.
4931         * symtab.c (lookup_global_symbol_from_objfile)
4932         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4933         foreach.
4934         * ser-tcp.c (net_open): Remove "struct" from foreach.
4935         * objfiles.c (objfile_relocate, objfile_rebase)
4936         (objfile_has_symbols): Remove "struct" from foreach.
4937         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4938         from foreach.
4939         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4940         foreach.
4941         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4942         "struct" from foreach.
4943         * ada-lang.c (create_excep_cond_exprs)
4944         (ada_exception_catchpoint_cond_string): Remove "struct" from
4945         foreach.
4946
4947 2019-05-03  Tom Tromey  <tromey@adacore.com>
4948
4949         * ada-exp.y (convert_char_literal): Check suffix of each
4950         enumerator.
4951
4952 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4953
4954         PR ada/21406:
4955         * ada-exp.y (yywrap): Don't define.
4956         * ada-lex.l (%option): Add noyywrap
4957         (yywrap): Remove.
4958
4959 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4960
4961         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4962         _WIN32_WINNT to the XP level, unless already defined to a higher
4963         level.
4964
4965         * unittests/parse-connection-spec-selftests.c:
4966         * ser-tcp.c:
4967         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4968         override.
4969
4970         * symfile.c (find_separate_debug_file): Remove colon from the
4971         drive spec of DOS/Windows file names of the target, so that the
4972         file name produced from DEBUGDIR and the target's directory will
4973         be valid on DOS/Windows systems.
4974
4975 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4976
4977         * rust-lang.c (val_print_struct): Handle printing structures
4978         containing strings.
4979
4980 2019-05-02  Tom Tromey  <tromey@adacore.com>
4981
4982         * valarith.c (_initialize_valarith): Remove.
4983
4984 2019-05-01  Tom Tromey  <tromey@adacore.com>
4985
4986         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4987         bitfields.
4988
4989 2019-05-01  Tom Tromey  <tromey@adacore.com>
4990
4991         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4992         for big-endian copies.
4993
4994 2019-04-30  Ali Tamur  <tamur@google.com>
4995         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4996         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4997         (read_3_bytes): New function.
4998
4999 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5000
5001         * windows-nat.c (main_thread_id): Delete.
5002         (handle_output_debug_string): Replace main_thread_id by
5003         current_event.dwThreadId.
5004         (fake_create_process): Likewise.
5005         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5006         Do not set main_thread_id.
5007         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5008         current_event.dwThreadId.
5009         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5010
5011 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5012
5013         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5014         Use current_event.dwThreadId instead of main_thread_id.
5015
5016 2019-04-30  Tom Tromey  <tromey@adacore.com>
5017
5018         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5019         (create_excep_cond_exprs): Iterate over program spaces.
5020         (ada_exception_catchpoint_cond_string): Examine all minimal
5021         symbols for exception types.
5022
5023 2019-04-30  Tom Tromey  <tromey@adacore.com>
5024
5025         PR c++/24470:
5026         * dwarf2read.c (process_structure_scope): Handle case where type
5027         has template parameters but no symbol was created.
5028
5029 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5030             Chris January  <chris.january@arm.com>
5031
5032         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5033         qualifier.
5034         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5035
5036 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5037
5038         * f-typeprint.c (f_print_type): Update rules for printing
5039         whitespace.
5040         (f_type_print_varspec_suffix): Likewise.
5041
5042 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5043             Chris January  <chris.january@arm.com>
5044
5045         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5046         function arguments.
5047
5048 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5049
5050         * f-lang.c (build_fortran_types): Change name of void type to
5051         lower case.
5052         * f-typeprint.c (f_type_print_base): Print the name of the void
5053         type, rather than a fixed string.
5054         * f-valprint.c (f_decorations): Use lower case void string.
5055
5056 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5057             Chris January  <chris.january@arm.com>
5058
5059         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5060         types for Fortran.
5061
5062 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5063             Chris January  <chris.january@arm.com>
5064             David Lecomber  <david.lecomber@arm.com>
5065
5066         * f-exp.y (BINOP_INTRINSIC): New token.
5067         (exp): New parser rule handling BINOP_INTRINSIC.
5068         (f77_keywords): Add new builtin procedures.
5069         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5070         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5071         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5072         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5073         (print_unop_subexp_f): New function.
5074         (print_binop_subexp_f): New function.
5075         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5076         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5077         (dump_subexp_body_f): Likewise.
5078         (operator_check_f): Likewise.
5079         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5080         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5081
5082 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5083
5084         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5085         UNOP_KIND.
5086         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5087         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5088         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5089         (operator_length_f): New fuction.
5090         (print_subexp_f): New function.
5091         (op_name_f): New function.
5092         (dump_subexp_body_f): New function.
5093         (operator_check_f): New function.
5094         (exp_descriptor_f): Replace standard expression handling functions
5095         with new functions.
5096         * gdb/fortran-operator.def: New file.
5097         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5098         * gdb/std-operator.def: Remove UNOP_KIND.
5099
5100 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * std-operator.def: Remove unbalanced, stray double quote
5103         character.
5104
5105 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5106             Chris January  <chris.january@arm.com>
5107             Daniel Everett  <daniel.everett@arm.com>
5108             Nick Forrington  <nick.forrington@arm.com>
5109             Richard Bunt  <richard.bunt@arm.com>
5110
5111         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5112         of depth when printing anonymous structs or unions.
5113         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5114         Don't print either the top-level value, or the children if the
5115         max-depth is exceeded.
5116         (ppscm_print_children): When printing the key of a map, allow one
5117         extra level of depth.
5118         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5119         print either the top-level value, or the children if the max-depth
5120         is exceeded.
5121         (print_children): When printing the key of a map, allow one extra
5122         level of depth.
5123         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5124         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5125         (user_print_options): Initialise max_depth field.
5126         (val_print_scalar_or_string_type_p): New function.
5127         (val_print): Check to see if the max depth has been reached.
5128         (val_print_check_max_depth): Define new function.
5129         (show_print_max_depth): New function.
5130         (_initialize_valprint): Add 'print max-depth' option.
5131         * valprint.h (struct value_print_options) <max_depth>: New field.
5132         (val_print_check_max_depth): Declare new function.
5133         * NEWS: Document new feature.
5134
5135 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5136
5137         * ada-lang.c (ada_language_defn): Initialise new field.
5138         * c-lang.c (c_is_string_type_p): New function.
5139         (c_language_defn): Initialise new field.
5140         (cplus_language_defn): Initialise new field.
5141         (asm_language_defn): Initialise new field.
5142         (minimal_language_defn): Initialise new field.
5143         * c-lang.h (c_is_string_type_p): Declare new function.
5144         * d-lang.c (d_language_defn): Initialise new field.
5145         * f-lang.c (f_is_string_type_p): New function.
5146         (f_language_defn): Initialise new field.
5147         * go-lang.c (go_is_string_type_p): New function.
5148         (go_language_defn): Initialise new field.
5149         * language.c (default_is_string_type_p): New function.
5150         (unknown_language_defn): Initialise new field.
5151         (auto_language_defn): Initialise new field.
5152         * language.h (struct language_defn) <la_is_string_type_p>: New
5153         member variable.
5154         (default_is_string_type_p): Declare new function.
5155         * m2-lang.c (m2_language_defn): Initialise new field.
5156         * objc-lang.c (objc_language_defn): Initialise new field.
5157         * opencl-lang.c (opencl_language_defn): Initialise new field.
5158         * p-lang.c (pascal_is_string_type_p): New function.
5159         (pascal_language_defn): Initialise new field.
5160         * rust-lang.c (rust_is_string_type_p): New function.
5161         (rust_language_defn): Initialise new field.
5162
5163 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5164
5165         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5166         New field.
5167         * ada-lang.c (ada_language_defn): Initialise new field.
5168         * c-lang.c (c_language_defn): Likewise.
5169         (cplus_language_defn): Likewise.
5170         (asm_language_defn): Likewise.
5171         (minimal_language_defn): Likewise.
5172         * d-lang.c (d_language_defn): Likewise.
5173         * f-lang.c (f_language_defn): Likewise.
5174         * go-lang.c (go_language_defn): Likewise.
5175         * language.c (unknown_language_defn): Likewise.
5176         (auto_language_defn): Likewise.
5177         * m2-lang.c (m2_language_defn): Likewise.
5178         * objc-lang.c (objc_language_defn): Likewise.
5179         * opencl-lang.c (opencl_language_defn): Likewise.
5180         * p-lang.c (pascal_language_defn): Likewise.
5181         * rust-lang.c (rust_language_defn): Likewise.
5182
5183 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5184
5185         * ada-lang.c (ada_is_character_type): Change return type to bool.
5186         (ada_is_string_type): Likewise.
5187         * ada-lang.h (ada_is_character_type): Update declaration
5188         (ada_is_string_type): Likewise.
5189
5190 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5191
5192         Support style in 'frame|thread apply'
5193
5194         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5195         * record.c (record_start, record_stop): Update callers of
5196         execute_command_to_string with false.
5197         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5198         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5199         methods.
5200         (class string_file): New constructor with term_out parameter.
5201         Override methods term_out and can_emit_style_escape.  New member
5202         term_out.
5203         (class stdio_file): Override can_emit_style_escape.
5204         (class tee_file): Override term_out and can_emit_style_escape.
5205         * utils.h (can_emit_style_escape): Remove.
5206         * utils.c (can_emit_style_escape): Likewise.
5207         Update all callers of can_emit_style_escape (SOMESTREAM) to
5208         SOMESTREAM->can_emit_style_escape.
5209         * source-cache.c (source_cache::get_source_lines): Likewise.
5210         * stack.c (frame_apply_command_count): Call execute_command_to_string
5211         passing the term_out characteristic of the current gdb_stdout.
5212         * thread.c (thr_try_catch_cmd): Likewise.
5213         * top.c (execute_command_to_string): pass term_out parameter
5214         to construct the string_file for the command output.
5215         * ui-file.c (term_cli_styling): New function (most code moved
5216         from utils.c can_emit_style_escape).
5217         (string_file::string_file, string_file::can_emit_style_escape,
5218         stdio_file::can_emit_style_escape, tee_file::term_out,
5219         tee_file::can_emit_style_escape): New functions.
5220
5221 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5222
5223         * NEWS: Mention the new set|show may-call-functions.
5224         * infcall.c (may_call_functions_p): New variable.
5225         (show_may_call_functions_p): New function.
5226         (call_function_by_hand_dummy): Throws an error if not
5227         may-call-functions.
5228         (_initialize_infcall): Call add_setshow_boolean_cmd for
5229         may-call-functions.
5230
5231 2019-04-25  Keith Seitz  <keiths@redhat.com>
5232
5233         PR c++/24367
5234         * cp-support.c (inspect_type): Don't attempt substitutions
5235         of symbol with the same name.
5236
5237 2019-04-25  Tom Tromey  <tromey@adacore.com>
5238
5239         PR gdb/24475:
5240         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5241         static.
5242
5243 2019-04-25  Tom Tromey  <tromey@adacore.com>
5244
5245         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5246         rvalue reference.
5247         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5248         (gdb_xml_parser::parse): Use std::move.
5249         * python/python-internal.h (gdbpy_convert_exception): Take a const
5250         reference.
5251         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5252         std::move.
5253         * python/py-utils.c (gdbpy_convert_exception): Take a const
5254         reference.
5255         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5256         Use std::move.
5257         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5258         Use std::move.
5259         * mi/mi-main.c (mi_print_exception): Take a const reference.
5260         * main.c (handle_command_errors): Take a const reference.
5261         * linespec.c (parse_linespec): Use std::move.
5262         * infcall.c (run_inferior_call): Use std::move.
5263         (call_function_by_hand_dummy): Use std::move.
5264         * exec.c (try_open_exec_file): Use std::move.
5265         * exceptions.h (exception_print, exception_fprintf)
5266         (exception_print_same): Update.
5267         * exceptions.c (print_exception, exception_print)
5268         (exception_fprintf, exception_print_same): Change parameters to
5269         const reference.
5270         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5271         * common/new-op.c: Use std::move.
5272         * common/common-exceptions.h (struct gdb_exception): Add move
5273         constructor.
5274         (struct gdb_exception_error, struct gdb_exception_quit, struct
5275         gdb_quit_bad_alloc): Change constructor to move constructor.
5276         (throw_exception): Change parameter to rvalue reference.
5277         * common/common-exceptions.c (throw_exception): Take rvalue
5278         reference.
5279         * cli/cli-interp.c (safe_execute_command): Use std::move.
5280         * breakpoint.c (insert_bp_location, location_to_sals): Use
5281         std::move.
5282
5283 2019-04-25  Tom Tromey  <tromey@adacore.com>
5284
5285         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5286         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5287         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5288         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5289         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5290         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5291         guile/scm-value.c: Use unpack.
5292         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5293         gdbscm_gdb_exception.
5294         (gdbscm_throw_gdb_exception): Likewise.
5295         (struct gdbscm_gdb_exception): New.
5296         (unpack): New function.
5297         (gdbscm_wrap): Use unpack.
5298
5299 2019-04-25  Tom Tromey  <tromey@adacore.com>
5300
5301         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5302         (gdb_rl_callback_handler): Use std::move.
5303         * common/common-exceptions.h (struct gdb_exception): Add move
5304         assignment operator.
5305         (throw_exception_sjlj): Change "exception" to const reference.
5306         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5307         (throw_exception_sjlj): Change "exception" to const reference.
5308
5309 2019-04-25  Tom Tromey  <tromey@adacore.com>
5310
5311         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5312         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5313         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5314         Update.
5315         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5316         Update.
5317         * mi/mi-interp.c (mi_interp::exec): Update.
5318         * linespec.c (parse_linespec): Update.
5319         * infcall.c (run_inferior_call): Update.
5320         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5321         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5322         (gdbscm_lookup_global_symbol): Update.
5323         * guile/scm-param.c (gdbscm_parameter_value): Update.
5324         * guile/scm-frame.c (gdbscm_frame_read_register)
5325         (gdbscm_frame_read_var): Update.
5326         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5327         * exec.c (try_open_exec_file): Update.
5328         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5329         (gdb_rl_callback_handler): Update.
5330         * common/common-exceptions.h (exception_none): Don't declare.
5331         * common/common-exceptions.c (exception_none): Don't define.
5332         (struct catcher) <exception>: Update.
5333         * cli/cli-interp.c (safe_execute_command): Update.
5334         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5335
5336 2019-04-25  Ali Tamur  <tamur@google.com>
5337
5338         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5339         (read_attribute_value): Likewise.
5340         (dwarf2_read_addr_index): Update comment.
5341         (read_str_index): Add DW_FORM_strx.
5342         (dwarf2_string_attr): Likewise.
5343         (dwarf2_const_value_attr): Likewise.
5344         (dump_die_shallow): Likewise.
5345         (dwarf2_fetch_constant_bytes): Likewise.
5346         (skip_form_bytes): Likewise.
5347         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5348
5349 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5350
5351         PR corefiles/11608
5352         PR corefiles/18187
5353         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5354         OFFSET.  Verify if current mapping contains an ELF header.
5355         (linux_find_memory_regions_full): Adjust call to
5356         dump_mapping_p.
5357
5358 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5359             Kang Li <kanglictf@gmail.com>
5360
5361         PR gdb/21600
5362
5363         * dwarf2-frame.c (read_initial_length): Be consistent about using
5364         unsigned representation of length.
5365         (decode_frame_entry_1): Likewise.  Check for wraparound of
5366         end pointer as well as buffer overflow.
5367
5368 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5369
5370         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5371         "vq".
5372
5373 2019-04-24  Tom Tromey  <tromey@adacore.com>
5374
5375         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5376
5377 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5378
5379         * s12z-tdep.c (s12z_unwind_pc): Delete.
5380         (s12z_unwind_sp): Delete.
5381         (s12z_gdbarch_init): Don't register deleted functions with
5382         gdbarch.
5383
5384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5385
5386         * rl78-tdep.c (rl78_unwind_sp): Delete.
5387         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5388
5389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5390
5391         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5392         (xstormy16_unwind_pc): Delete.
5393         (xstormy16_dummy_id): Delete.
5394         (xstormy16_gdbarch_init): Don't register deleted functions with
5395         gdbarch.
5396
5397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5398
5399         * vax-tdep.c (vax_unwind_pc): Delete.
5400         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5401
5402 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5403
5404         * v850-tdep.c (v850_unwind_sp): Delete.
5405         (v850_unwind_pc): Delete.
5406         (v850_dummy_id): Delete.
5407         (v850_gdbarch_init): Don't register deleted functions with
5408         gdbarch.
5409
5410 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5411
5412         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5413         (tilegx_unwind_pc): Delete.
5414         (tilegx_unwind_dummy_id): Delete.
5415         (tilegx_gdbarch_init): Don't register deleted functions with
5416         gdbarch.
5417
5418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5419
5420         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5421         (tic6x_dummy_id): Delete.
5422         (tic6x_gdbarch_init): Don't register deleted functions with
5423         gdbarch.
5424
5425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5426
5427         * sparc-tdep.c (sparc_unwind_pc): Delete.
5428         (sparc32_gdbarch_init): Don't register deleted function with
5429         gdbarch.
5430
5431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5432
5433         * sh-tdep.c (sh_unwind_sp): Delete.
5434         (sh_unwind_pc): Delete.
5435         (sh_dummy_id): Delete.
5436         (sh_gdbarch_init): Don't register deleted functions with
5437         gdbarch.
5438
5439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5440
5441         * score-tdep.c (score_unwind_sp): Delete.
5442         (score_unwind_pc): Delete.
5443         (score_dummy_id): Delete.
5444         (score_gdbarch_init): Don't register deleted functions with
5445         gdbarch.
5446
5447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5448
5449         * rx-tdep.c (rx_unwind_pc): Delete.
5450         (rx_unwind_sp): Delete.
5451         (rx_dummy_id): Delete.
5452         (rx_gdbarch_init): Don't register deleted functions with
5453         gdbarch.  Update comment.
5454
5455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5456
5457         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5458         (rs6000_dummy_id): Delete.
5459         (rs6000_gdbarch_init): Don't register deleted functions with
5460         gdbarch.
5461
5462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5463
5464         * or1k-tdep.c (or1k_dummy_id): Delete.
5465         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5466
5467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5468
5469         * nios2-tdep.c (nios2_dummy_id): Delete.
5470         (nios2_unwind_sp): Delete.
5471         (nios2_gdbarch_init): Don't register deleted functions with
5472         gdbarch.
5473
5474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5475
5476         * nds32-tdep.c (nds32_dummy_id): Delete.
5477         (nds32_unwind_pc): Delete.
5478         (nds32_unwind_sp): Delete.
5479         (nds32_gdbarch_init): Don't register deleted functions with
5480         gdbarch.
5481
5482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5483
5484         * msp430-tdep.c (msp430_unwind_pc): Delete.
5485         (msp430_unwind_sp): Delete.
5486         (msp430_dummy_id): Delete.
5487         (msp430_gdbarch_init): Don't register deleted functions with
5488         gdbarch.
5489
5490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5491
5492         * moxie-tdep.c (moxie_unwind_sp): Delete.
5493         (moxie_unwind_pc): Delete.
5494         (moxie_dummy_id): Delete.
5495         (moxie_gdbarch_init): Don't register deleted functions with
5496         gdbarch.
5497
5498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5499
5500         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5501         (mn10300_unwind_pc): Delete.
5502         (mn10300_unwind_sp): Delete.
5503         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5504         mn10300_unwind_sp.
5505         (mn10300_frame_unwind_init): Don't register deleted functions with
5506         gdbarch.
5507
5508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5509
5510         * mep-tdep.c (mep_unwind_pc): Delete.
5511         (mep_unwind_sp): Delete.
5512         (mep_dummy_id): Delete.
5513         (mep_gdbarch_init): Don't register deleted functions with
5514         gdbarch.
5515
5516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5517
5518         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5519         (m68hc11_unwind_sp): Delete.
5520         (m68hc11_gdbarch_init): Don't register deleted functions with
5521         gdbarch.
5522
5523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5524
5525         * m32r-tdep.c (m32r_unwind_sp): Delete.
5526         (m32r_unwind_pc): Delete.
5527         (m32r_dummy_id): Delete.
5528         (m32r_gdbarch_init): Don't register deleted functions with
5529         gdbarch.
5530
5531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5532
5533         * m32c-tdep.c (m32c_unwind_pc): Delete.
5534         (m32c_unwind_sp): Delete.
5535         (m32c_dummy_id): Delete.
5536         (m32c_gdbarch_init): Don't register deleted functions with
5537         gdbarch.
5538
5539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5540
5541         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5542         (lm32_unwind_pc): Delete.
5543         (lm32_dummy_id): Delete.
5544         (lm32_gdbarch_init): Don't register deleted functions with
5545         gdbarch.
5546
5547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5548
5549         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5550         (iq2000_unwind_pc): Delete.
5551         (iq2000_dummy_id): Delete.
5552         (iq2000_gdbarch_init): Don't register deleted functions with
5553         gdbarch.
5554
5555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5556
5557         * nds32-tdep.c (nds32_type_align): Delete.
5558         (nds32_push_dummy_call): Use type_align instead.
5559
5560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5561
5562         * arm-tdep.c (arm_type_align): Only handle vector override case.
5563         (arm_push_dummy_call): Use type_align.
5564         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5565
5566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5567
5568         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5569         case.
5570         (pass_on_stack): Use type_align.
5571         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5572         function.
5573
5574 2019-04-23  Tom Tromey  <tromey@adacore.com>
5575
5576         * dwarf2read.c (line_header::file_name_at): Remove unused
5577         overload.
5578
5579 2019-04-23  Tom de Vries  <tdevries@suse.de>
5580
5581         PR gdb/24438
5582         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5583         invocation.
5584
5585
5586 2019-03-27  Ali Tamur  <tamur@google.com>
5587
5588         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5589         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5590         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5591         (dwarf_expr_context::get_addr_index): Likewise
5592         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5593         (symbol_needs_eval_context::get_addr_index): Likewise
5594         (disassemble_dwarf_expression): Add DW_OP_addrx
5595         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5596         (read_cutu_die_from_dwo): Update comment
5597         (skip_one_die): Add DW_FORM_addrx
5598         (read_attribute_value): Likewise
5599         (var_decode_location): Add DW_OP_addrx
5600         (dwarf2_const_value_attr): Add DW_FORM_addrx
5601         (dump_die_shallow): Likewise
5602         (dwarf2_fetch_constant_bytes): Likewise
5603         (decode_locdesc): Add DW_OP_addrx
5604         (skip_form_bytes): Add DW_FORM_addrx
5605
5606 2019-04-22  Ali Tamur  <tamur@google.com>
5607
5608         * MAINTAINERS (Write After Approval): Add self.
5609
5610 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5611
5612         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5613         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5614         (open_symbol_file_object): Likewise.
5615         (svr4_default_sos): Add info parameter.
5616         (svr4_read_so_list): Likewise.
5617         (svr4_current_sos_direct): Adjust functions calls to pass down
5618         info.
5619         (svr4_current_sos_1): Add info parameter.
5620         (svr4_current_sos): Call get_svr4_info, pass info down to
5621         svr4_current_sos_1.
5622         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5623         get_svr4_info.
5624         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5625         get_svr4_info.
5626         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5627         to get_svr4_info.
5628         (probes_table_remove_objfile_probes): Likewise.
5629         (register_solib_event_probe): Add info parameter.
5630         (solist_update_incremental): Pass info parameter down to
5631         svr4_read_so_list.
5632         (disable_probes_interface): Add info parameter.
5633         (svr4_handle_solib_event): Pass current_program_space to
5634         get_svr4_info.  Adjust disable_probes_interface cleanup.
5635         (svr4_create_probe_breakpoints): Add info parameter, pass it
5636         down to register_solib_event_probe.
5637         (svr4_create_solib_event_breakpoints): Add info parameter,
5638         pass it down to svr4_create_probe_breakpoints.
5639         (enable_break): Pass info down to
5640         svr4_create_solib_event_breakpoints.
5641         (svr4_solib_create_inferior_hook): Pass current_program_space to
5642         get_svr4_info.
5643         (svr4_clear_solib): Likewise.
5644
5645 2019-04-22  Pedro Alves  <palves@redhat.com>
5646
5647         * solib-svr4.c (svr4_free_objfile_observer): New.
5648         (probe_and_action::objfile): New field.
5649         (probes_table_htab_remove_objfile_probes)
5650         (probes_table_remove_objfile_probes): New functions.
5651         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5652         in the new probe_and_action.  Don't store the probe in 'lookup'.
5653         (svr4_create_probe_breakpoints): Pass objfile to
5654         register_solib_event_probe.
5655         (_initialize_svr4_solib): Register a free_objfile observer.
5656
5657 2019-04-19  Tom Tromey  <tom@tromey.com>
5658
5659         * common/queue.h: Remove.
5660
5661 2019-04-19  Tom Tromey  <tom@tromey.com>
5662
5663         * event-loop.c: Don't include "common/queue.h".
5664
5665 2019-04-19  Tom Tromey  <tom@tromey.com>
5666
5667         * remote.c (remote_target): Use delete.
5668         * remote-notif.h: Include <list>, not "common/queue.h".
5669         (notif_client_p): Remove typedef.
5670         (remote_notif_state): Add constructor, destructor, initializer.
5671         <notif_queue>: Now a std::list.
5672         (remote_notif_state_xfree): Don't declare.
5673         * remote-notif.c (remote_notif_process, handle_notification)
5674         (remote_notif_state_allocate): Update.
5675         (~remote_notif_state): Rename from remote_notif_state_xfree.
5676
5677 2019-04-19  Tom Tromey  <tom@tromey.com>
5678
5679         * symfile.c (reread_symbols): Update.
5680         * objfiles.c (objfile_register_static_link)
5681         (objfile_lookup_static_link): Update
5682         (~objfile) Don't delete static_links.
5683         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5684
5685 2019-04-19  Tom Tromey  <tom@tromey.com>
5686
5687         * type-stack.h (struct type_stack) <insert>: Constify string.
5688         * type-stack.c (type_stack::insert): Constify string.
5689         * gdbtypes.h (lookup_template_type): Update.
5690         (address_space_name_to_int): Update.
5691         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5692         const.
5693         (lookup_template_type): Make name const.
5694         * c-exp.y: Update rules.
5695         (lex_one_token, classify_name, classify_inner_name)
5696         (c_print_token): Update.
5697         * p-exp.y: Update rules.
5698         (yylex): Update.
5699         * f-exp.y: Update rules.
5700         (yylex): Update.
5701         * d-exp.y: Update rules.
5702         (lex_one_token, classify_name, classify_inner_name): Update.
5703         * parse.c (write_dollar_variable, copy_name): Return std::string.
5704         * parser-defs.h (copy_name): Change return type.
5705         * m2-exp.y: Update rules.
5706         (yylex): Update.
5707         * go-exp.y (lex_one_token): Update.
5708         Update rules.
5709         (classify_unsafe_function, classify_packaged_name)
5710         (classify_name, yylex): Update.
5711
5712 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5713
5714         * configure.ac: add --enable-source-highlight switch.
5715         * configure: Regenerate.
5716         * top.c (print_gdb_version): plumb --enable-source-highlight
5717         status to "show configuration".
5718
5719 2019-04-19  Tom Tromey  <tromey@adacore.com>
5720
5721         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5722         Check ADA_TYPE_P.
5723         (empty_record, ada_template_to_fixed_record_type_1)
5724         (template_to_static_fixed_type)
5725         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5726         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5727         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5728         macros.
5729
5730 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5731
5732         PR symtab/24423:
5733         * source.c (print_source_lines_base): Advance "iter" when a
5734         control character is seen.
5735
5736 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5737
5738         * inferior.h (struct infcall_suspend_state_deleter):
5739         Catch exception in destructor to avoid crash.
5740
5741 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5742
5743         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5744         close to the add_com "shell".
5745
5746 2019-04-18  Tom Tromey  <tromey@adacore.com>
5747
5748         * process-stratum-target.h (class process_stratum_target)
5749         <stratum>: Add "final".
5750
5751 2019-04-17  Tom Tromey  <tromey@adacore.com>
5752
5753         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5754         against nullptr before use.
5755
5756 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5757
5758         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5759
5760 2019-04-17  Jim Wilson  <jimw@sifive.com>
5761             Andrew Burgess  <andrew.burgess@embecosm.com>
5762
5763         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5764         code read might fail, assume 4-byte breakpoint in that case.
5765
5766 2019-04-15  Leszek Swirski  <leszeks@google.com>
5767
5768         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5769         rather than a hand-rolled POD check when checking for forced MEMORY
5770         classification.
5771
5772 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5773
5774         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5775         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5776         function.
5777         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5778         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5779         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5780         declaration.
5781
5782 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5783
5784         * aarch64-linux-nat.c
5785         (aarch64_linux_nat_target::thread_architecture): Add override.
5786         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5787         each VQ.
5788
5789 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5790
5791         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5792
5793 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5794
5795         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5796         target types of size 96-bits, add some additional comments, and
5797         check that the builtin type we found was the correct size.
5798
5799 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5800
5801         * utils.c (prompt_for_continue): Don't restore the styling at the
5802         end, as applied_style has the wrong value.  This fixes styling in
5803         long lists of file names that are interrupted by the "Continue?"
5804         prompt.
5805
5806 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5807
5808         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5809         * c-lang.c (c_language_defn): Likewise.
5810         (cplus_language_defn): Likewise.
5811         (asm_language_defn): Likewise.
5812         (minimal_language_defn): Likewise.
5813         * d-lang.c (d_language_defn): Likewise.
5814         * f-lang.c (f_language_defn): Likewise.
5815         * go-lang.c (go_language_defn): Likewise.
5816         * language.c (unknown_language_defn): Likewise.
5817         (auto_language_defn): Likewise.
5818         * language.h (struct language_defn): Remove la_magic field.
5819         (LANG_MAGIC): Delete.
5820         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5821         * objc-lang.c (objc_language_defn): Likewise.
5822         * opencl-lang.c (opencl_language_defn): Likewise.
5823         * p-lang.c (pascal_language_defn): Likewise.
5824         * rust-lang.c (rust_language_defn): Likewise.
5825
5826 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5827
5828         * riscv-tdep.c (riscv_type_align): New function.
5829         (riscv_type_alignment): Delete.
5830         (riscv_arg_location): Use 'type_align'.
5831         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5832
5833 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5834
5835         * gdbtypes.c (type_align): A struct with no non-static fields also
5836         has alignment of 1.
5837
5838 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5839
5840         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5841         component to 0.
5842         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5843         member.
5844         (riscv_struct_info::analyse): New implementation using new
5845         analyse_inner member function.
5846         (riscv_struct_info::field_offset): New member function.
5847         (riscv_struct_info::m_offsets): New member variable.
5848         (riscv_struct_info::analyse_inner): New private member function,
5849         takes the old implementation of riscv_struct_info::analyse but
5850         extended to track field offsets.
5851         (riscv_call_arg_struct): Update the struct folding special cases
5852         to handle cases where empty C++ structs, which are non-zero
5853         length, are found.
5854         (riscv_arg_location): Initialise the length of each location, a
5855         non-zero length now indicates the location is in use.
5856         (riscv_push_dummy_call): Allow for the first location having a
5857         non-zero offset when setting up arguments.
5858         (riscv_return_value): Likewise, but for return values.
5859
5860 2019-04-11  Tom Tromey  <tromey@adacore.com>
5861
5862         * utils.c (internal_vproblem): Make "msg" const.
5863
5864 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5865
5866         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5867         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5868         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5869         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5870
5871 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5872
5873         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5874         function.
5875         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5876         of amd64_collect_native_gregset.
5877         (amd64_linux_nat_target::store_registers): Likewise.
5878
5879 2019-04-10  Tom Tromey  <tom@tromey.com>
5880
5881         * symtab.c (lookup_global_symbol_from_objfile)
5882         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5883         * objfiles.h (class separate_debug_iterator): New.
5884         (class separate_debug_range): New.
5885         (struct objfile) <separate_debug_objfiles>: New method.
5886         (objfile_separate_debug_iterate): Don't declare.
5887         * objfiles.c (separate_debug_iterator::operator++): Rename from
5888         objfile_separate_debug_iterate.
5889         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5890         iterator.
5891         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5892         iterator.
5893
5894 2019-04-10  Tom Tromey  <tom@tromey.com>
5895
5896         * symfile.c (reread_symbols): Remove old comment.
5897         * objfiles.c (free_all_objfiles): Fix a typo.
5898
5899 2019-04-10  Tom Tromey  <tom@tromey.com>
5900
5901         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5902         * minsyms.c (lookup_minimal_symbol): Use foreach.
5903         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5904         (lookup_minimal_symbol_solib_trampoline): Likewise.
5905         * symfile.c (reread_symbols): Use foreach.
5906
5907 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5908             Tom Tromey  <tromey@adacore.com>
5909
5910         PR rust/24414:
5911         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5912         (rust_lex_int_test): Change "value" to be LONGEST.
5913         (rust_lex_tests): Add test for long integer literal.
5914
5915 2019-04-09  Tom Tromey  <tromey@adacore.com>
5916
5917         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5918         to bool.
5919         (extended_remote_target::attach): Update.
5920         (remote_target::remote_notice_new_inferior): Update.
5921         (remote_target::add_current_inferior_and_thread): Update.
5922         * inferior.c (exit_inferior_1): Use "false".
5923         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5924
5925 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5926
5927         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5928         the "start" command.
5929
5930 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5931
5932         * python/py-inferior.c (infpy_thread_from_thread_handle):
5933         Adjust comments to reflect renaming of thread_from_thread_handle
5934         to thread_from_handle.  Adjust keywords.  Fix type error message.
5935         (inferior_object_methods): Add thread_from_handle.  Retain
5936         thread_from_thread_handle, but mark it as deprecated.
5937
5938 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5939
5940         * gdbthread.h (find_thread_by_handle): Revise declaration.
5941         * thread.c (find_thread_by_handle): Likewise.  Adjust
5942         implementation too.
5943         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5944         support for buffer objects as handles.
5945
5946 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5947
5948         * python/py-infthread.c (thpy_thread_handle): New function.
5949         (thread_object_methods): Register thpy_thread_handle.
5950
5951 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5952
5953         * gdbthread.h (thread_to_thread_handle): Declare.
5954         * thread.c (gdbtypes.h): Include.
5955         (thread_to_thread_handle): New function.
5956
5957         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5958         (target_thread_info_to_thread_handle): Declare.
5959         * target.c (target_thread_info_to_thread_handle): New function.
5960         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5961         * target-delegates.c: Regenerate.
5962
5963         * linux-thread-db.c (class thread_db_target): Add method
5964         thread_info_to_thread_handle.
5965         (thread_db_target::thread_info_to_thread_handle): Define.
5966         * remote.c (class remote_target): Add new method
5967         thread_info_to_thread_handle.
5968         (remote_target::thread_info_to_thread_handle): Define.
5969
5970 2019-04-08  Pedro Alves  <palves@redhat.com>
5971
5972         * common/common-exceptions.c (throw_exception): Don't create
5973         named object to throw; throw directly.
5974         (throw_it): Likewise.  Don't initialize gdb_exception::message
5975         here, with new; pass FMT and AP to the ctor instead.
5976         * common/common-exceptions.h: Include <string>.
5977         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5978         const char *, va_list)): New ctor.  Use std::make_shared.
5979         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5980         errors)): Delete.
5981         (gdb_exception_error::gdb_exception_error(enum errors, const char
5982         *, va_list)): New.
5983         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5984         Add assertion.
5985         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5986         errors)): Delete.
5987         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5988         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5989         Add assertion.
5990
5991 2019-04-08  Tom Tromey  <tom@tromey.com>
5992
5993         * valops.c (value_rtti_indirect_type): Replace throw_exception
5994         with throw.
5995         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5996         with throw.
5997         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5998         throw.
5999         * target.c (target_translate_tls_address): Replace throw_exception
6000         with throw.
6001         * stack.c (frame_apply_command_count): Replace throw_exception
6002         with throw.
6003         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6004         throw.
6005         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6006         with throw.
6007         * rs6000-tdep.c (rs6000_frame_cache)
6008         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6009         * remote.c: Replace throw_exception with throw.
6010         * record-full.c (record_full_message, record_full_wait_1)
6011         (record_full_restore): Replace throw_exception with throw.
6012         * record-btrace.c:
6013         (get_thread_current_frame_id, record_btrace_start_replaying)
6014         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6015         (cmd_record_btrace_start): Replace throw_exception with throw.
6016         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6017         throw.
6018         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6019         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6020         * linespec.c:
6021         (find_linespec_symbols): Replace throw_exception with throw.
6022         * infrun.c (displaced_step_prepare, resume): Replace
6023         throw_exception with throw.
6024         * infcmd.c (post_create_inferior): Replace throw_exception with
6025         throw.
6026         * inf-loop.c (inferior_event_handler): Replace throw_exception
6027         with throw.
6028         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6029         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6030         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6031         (get_prev_frame_always, get_frame_pc_if_available)
6032         (get_frame_address_in_block_if_available, get_frame_language):
6033         Replace throw_exception with throw.
6034         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6035         throw_exception with throw.
6036         * eval.c (fetch_subexp_value, evaluate_var_value)
6037         (evaluate_funcall, evaluate_subexp_standard): Replace
6038         throw_exception with throw.
6039         * dwarf2loc.c (call_site_find_chain)
6040         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6041         Replace throw_exception with throw.
6042         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6043         with throw.
6044         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6045         throw.
6046         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6047         * completer.c (complete_line_internal): Replace throw_exception
6048         with throw.
6049         * compile/compile-object-run.c (compile_object_run): Replace
6050         throw_exception with throw.
6051         * cli/cli-script.c (process_next_line): Replace throw_exception
6052         with throw.
6053         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6054         (btrace_enable, btrace_maint_update_pt_packets): Replace
6055         throw_exception with throw.
6056         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6057         throw_exception with throw.
6058         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6059         throw_exception with throw.
6060         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6061         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6062         * aarch64-tdep.c (aarch64_make_prologue_cache)
6063         (aarch64_make_stub_cache): Replace throw_exception with throw.
6064
6065 2019-04-08  Tom Tromey  <tom@tromey.com>
6066
6067         * common/common-exceptions.c (throw_exception): Rename from
6068         throw_exception_cxx.  Remove old copy.  Make argument const.
6069         (throw_it): Create and throw exception objects directly.
6070         * common/common-exceptions.h (throw_exception): Make argument
6071         const.
6072         (struct gdb_exception_error): Add constructor.
6073         (struct gdb_exception_quit): Add constructor.
6074
6075 2019-04-08  Tom Tromey  <tom@tromey.com>
6076
6077         * common/common-exceptions.h (exception_rethrow): Don't declare.
6078         (TRY_SJLJ): Update comment.
6079         (TRY, CATCH, END_CATCH): Remove.
6080         * common/common-exceptions.c (exception_rethrow): Remove.
6081
6082 2019-04-08  Tom Tromey  <tom@tromey.com>
6083
6084         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6085         Remove.
6086         (gdb_exception_error): Rename from
6087         gdb_exception_RETURN_MASK_ERROR.
6088         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6089         (gdb_quit_bad_alloc): Update.
6090         * aarch64-tdep.c: Update.
6091         * ada-lang.c: Update.
6092         * ada-typeprint.c: Update.
6093         * ada-valprint.c: Update.
6094         * amd64-tdep.c: Update.
6095         * arch-utils.c: Update.
6096         * break-catch-throw.c: Update.
6097         * breakpoint.c: Update.
6098         * btrace.c: Update.
6099         * c-varobj.c: Update.
6100         * cli/cli-cmds.c: Update.
6101         * cli/cli-interp.c: Update.
6102         * cli/cli-script.c: Update.
6103         * common/common-exceptions.c: Update.
6104         * common/new-op.c: Update.
6105         * common/selftest.c: Update.
6106         * compile/compile-c-symbols.c: Update.
6107         * compile/compile-cplus-symbols.c: Update.
6108         * compile/compile-object-load.c: Update.
6109         * compile/compile-object-run.c: Update.
6110         * completer.c: Update.
6111         * corelow.c: Update.
6112         * cp-abi.c: Update.
6113         * cp-support.c: Update.
6114         * cp-valprint.c: Update.
6115         * darwin-nat.c: Update.
6116         * disasm-selftests.c: Update.
6117         * dtrace-probe.c: Update.
6118         * dwarf-index-cache.c: Update.
6119         * dwarf-index-write.c: Update.
6120         * dwarf2-frame-tailcall.c: Update.
6121         * dwarf2-frame.c: Update.
6122         * dwarf2loc.c: Update.
6123         * dwarf2read.c: Update.
6124         * eval.c: Update.
6125         * event-loop.c: Update.
6126         * event-top.c: Update.
6127         * exec.c: Update.
6128         * f-valprint.c: Update.
6129         * fbsd-tdep.c: Update.
6130         * frame-unwind.c: Update.
6131         * frame.c: Update.
6132         * gdbtypes.c: Update.
6133         * gnu-v3-abi.c: Update.
6134         * guile/guile-internal.h: Update.
6135         * guile/scm-block.c: Update.
6136         * guile/scm-breakpoint.c: Update.
6137         * guile/scm-cmd.c: Update.
6138         * guile/scm-disasm.c: Update.
6139         * guile/scm-frame.c: Update.
6140         * guile/scm-lazy-string.c: Update.
6141         * guile/scm-math.c: Update.
6142         * guile/scm-param.c: Update.
6143         * guile/scm-ports.c: Update.
6144         * guile/scm-pretty-print.c: Update.
6145         * guile/scm-symbol.c: Update.
6146         * guile/scm-symtab.c: Update.
6147         * guile/scm-type.c: Update.
6148         * guile/scm-value.c: Update.
6149         * i386-linux-tdep.c: Update.
6150         * i386-tdep.c: Update.
6151         * inf-loop.c: Update.
6152         * infcall.c: Update.
6153         * infcmd.c: Update.
6154         * infrun.c: Update.
6155         * jit.c: Update.
6156         * language.c: Update.
6157         * linespec.c: Update.
6158         * linux-fork.c: Update.
6159         * linux-nat.c: Update.
6160         * linux-tdep.c: Update.
6161         * linux-thread-db.c: Update.
6162         * main.c: Update.
6163         * mi/mi-cmd-break.c: Update.
6164         * mi/mi-cmd-stack.c: Update.
6165         * mi/mi-interp.c: Update.
6166         * mi/mi-main.c: Update.
6167         * objc-lang.c: Update.
6168         * p-valprint.c: Update.
6169         * parse.c: Update.
6170         * ppc-linux-tdep.c: Update.
6171         * printcmd.c: Update.
6172         * python/py-arch.c: Update.
6173         * python/py-breakpoint.c: Update.
6174         * python/py-cmd.c: Update.
6175         * python/py-finishbreakpoint.c: Update.
6176         * python/py-frame.c: Update.
6177         * python/py-framefilter.c: Update.
6178         * python/py-gdb-readline.c: Update.
6179         * python/py-inferior.c: Update.
6180         * python/py-infthread.c: Update.
6181         * python/py-lazy-string.c: Update.
6182         * python/py-linetable.c: Update.
6183         * python/py-objfile.c: Update.
6184         * python/py-param.c: Update.
6185         * python/py-prettyprint.c: Update.
6186         * python/py-progspace.c: Update.
6187         * python/py-record-btrace.c: Update.
6188         * python/py-record.c: Update.
6189         * python/py-symbol.c: Update.
6190         * python/py-type.c: Update.
6191         * python/py-unwind.c: Update.
6192         * python/py-utils.c: Update.
6193         * python/py-value.c: Update.
6194         * python/python.c: Update.
6195         * record-btrace.c: Update.
6196         * record-full.c: Update.
6197         * remote-fileio.c: Update.
6198         * remote.c: Update.
6199         * riscv-tdep.c: Update.
6200         * rs6000-aix-tdep.c: Update.
6201         * rs6000-tdep.c: Update.
6202         * rust-exp.y: Update.
6203         * rust-lang.c: Update.
6204         * s390-tdep.c: Update.
6205         * selftest-arch.c: Update.
6206         * solib-dsbt.c: Update.
6207         * solib-frv.c: Update.
6208         * solib-spu.c: Update.
6209         * solib-svr4.c: Update.
6210         * solib.c: Update.
6211         * sparc64-linux-tdep.c: Update.
6212         * stack.c: Update.
6213         * symfile-mem.c: Update.
6214         * symmisc.c: Update.
6215         * target.c: Update.
6216         * thread.c: Update.
6217         * top.c: Update.
6218         * tracefile-tfile.c: Update.
6219         * tui/tui.c: Update.
6220         * typeprint.c: Update.
6221         * unittests/cli-utils-selftests.c: Update.
6222         * unittests/parse-connection-spec-selftests.c: Update.
6223         * valops.c: Update.
6224         * valprint.c: Update.
6225         * value.c: Update.
6226         * varobj.c: Update.
6227         * windows-nat.c: Update.
6228         * x86-linux-nat.c: Update.
6229         * xml-support.c: Update.
6230
6231 2019-04-08  Tom Tromey  <tom@tromey.com>
6232
6233         * xml-support.c: Use C++ exception handling.
6234         * x86-linux-nat.c: Use C++ exception handling.
6235         * windows-nat.c: Use C++ exception handling.
6236         * varobj.c: Use C++ exception handling.
6237         * value.c: Use C++ exception handling.
6238         * valprint.c: Use C++ exception handling.
6239         * valops.c: Use C++ exception handling.
6240         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6241         handling.
6242         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6243         * typeprint.c: Use C++ exception handling.
6244         * tui/tui.c: Use C++ exception handling.
6245         * tracefile-tfile.c: Use C++ exception handling.
6246         * top.c: Use C++ exception handling.
6247         * thread.c: Use C++ exception handling.
6248         * target.c: Use C++ exception handling.
6249         * symmisc.c: Use C++ exception handling.
6250         * symfile-mem.c: Use C++ exception handling.
6251         * stack.c: Use C++ exception handling.
6252         * sparc64-linux-tdep.c: Use C++ exception handling.
6253         * solib.c: Use C++ exception handling.
6254         * solib-svr4.c: Use C++ exception handling.
6255         * solib-spu.c: Use C++ exception handling.
6256         * solib-frv.c: Use C++ exception handling.
6257         * solib-dsbt.c: Use C++ exception handling.
6258         * selftest-arch.c: Use C++ exception handling.
6259         * s390-tdep.c: Use C++ exception handling.
6260         * rust-lang.c: Use C++ exception handling.
6261         * rust-exp.y: Use C++ exception handling.
6262         * rs6000-tdep.c: Use C++ exception handling.
6263         * rs6000-aix-tdep.c: Use C++ exception handling.
6264         * riscv-tdep.c: Use C++ exception handling.
6265         * remote.c: Use C++ exception handling.
6266         * remote-fileio.c: Use C++ exception handling.
6267         * record-full.c: Use C++ exception handling.
6268         * record-btrace.c: Use C++ exception handling.
6269         * python/python.c: Use C++ exception handling.
6270         * python/py-value.c: Use C++ exception handling.
6271         * python/py-utils.c: Use C++ exception handling.
6272         * python/py-unwind.c: Use C++ exception handling.
6273         * python/py-type.c: Use C++ exception handling.
6274         * python/py-symbol.c: Use C++ exception handling.
6275         * python/py-record.c: Use C++ exception handling.
6276         * python/py-record-btrace.c: Use C++ exception handling.
6277         * python/py-progspace.c: Use C++ exception handling.
6278         * python/py-prettyprint.c: Use C++ exception handling.
6279         * python/py-param.c: Use C++ exception handling.
6280         * python/py-objfile.c: Use C++ exception handling.
6281         * python/py-linetable.c: Use C++ exception handling.
6282         * python/py-lazy-string.c: Use C++ exception handling.
6283         * python/py-infthread.c: Use C++ exception handling.
6284         * python/py-inferior.c: Use C++ exception handling.
6285         * python/py-gdb-readline.c: Use C++ exception handling.
6286         * python/py-framefilter.c: Use C++ exception handling.
6287         * python/py-frame.c: Use C++ exception handling.
6288         * python/py-finishbreakpoint.c: Use C++ exception handling.
6289         * python/py-cmd.c: Use C++ exception handling.
6290         * python/py-breakpoint.c: Use C++ exception handling.
6291         * python/py-arch.c: Use C++ exception handling.
6292         * printcmd.c: Use C++ exception handling.
6293         * ppc-linux-tdep.c: Use C++ exception handling.
6294         * parse.c: Use C++ exception handling.
6295         * p-valprint.c: Use C++ exception handling.
6296         * objc-lang.c: Use C++ exception handling.
6297         * mi/mi-main.c: Use C++ exception handling.
6298         * mi/mi-interp.c: Use C++ exception handling.
6299         * mi/mi-cmd-stack.c: Use C++ exception handling.
6300         * mi/mi-cmd-break.c: Use C++ exception handling.
6301         * main.c: Use C++ exception handling.
6302         * linux-thread-db.c: Use C++ exception handling.
6303         * linux-tdep.c: Use C++ exception handling.
6304         * linux-nat.c: Use C++ exception handling.
6305         * linux-fork.c: Use C++ exception handling.
6306         * linespec.c: Use C++ exception handling.
6307         * language.c: Use C++ exception handling.
6308         * jit.c: Use C++ exception handling.
6309         * infrun.c: Use C++ exception handling.
6310         * infcmd.c: Use C++ exception handling.
6311         * infcall.c: Use C++ exception handling.
6312         * inf-loop.c: Use C++ exception handling.
6313         * i386-tdep.c: Use C++ exception handling.
6314         * i386-linux-tdep.c: Use C++ exception handling.
6315         * guile/scm-value.c: Use C++ exception handling.
6316         * guile/scm-type.c: Use C++ exception handling.
6317         * guile/scm-symtab.c: Use C++ exception handling.
6318         * guile/scm-symbol.c: Use C++ exception handling.
6319         * guile/scm-pretty-print.c: Use C++ exception handling.
6320         * guile/scm-ports.c: Use C++ exception handling.
6321         * guile/scm-param.c: Use C++ exception handling.
6322         * guile/scm-math.c: Use C++ exception handling.
6323         * guile/scm-lazy-string.c: Use C++ exception handling.
6324         * guile/scm-frame.c: Use C++ exception handling.
6325         * guile/scm-disasm.c: Use C++ exception handling.
6326         * guile/scm-cmd.c: Use C++ exception handling.
6327         * guile/scm-breakpoint.c: Use C++ exception handling.
6328         * guile/scm-block.c: Use C++ exception handling.
6329         * guile/guile-internal.h: Use C++ exception handling.
6330         * gnu-v3-abi.c: Use C++ exception handling.
6331         * gdbtypes.c: Use C++ exception handling.
6332         * frame.c: Use C++ exception handling.
6333         * frame-unwind.c: Use C++ exception handling.
6334         * fbsd-tdep.c: Use C++ exception handling.
6335         * f-valprint.c: Use C++ exception handling.
6336         * exec.c: Use C++ exception handling.
6337         * event-top.c: Use C++ exception handling.
6338         * event-loop.c: Use C++ exception handling.
6339         * eval.c: Use C++ exception handling.
6340         * dwarf2read.c: Use C++ exception handling.
6341         * dwarf2loc.c: Use C++ exception handling.
6342         * dwarf2-frame.c: Use C++ exception handling.
6343         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6344         * dwarf-index-write.c: Use C++ exception handling.
6345         * dwarf-index-cache.c: Use C++ exception handling.
6346         * dtrace-probe.c: Use C++ exception handling.
6347         * disasm-selftests.c: Use C++ exception handling.
6348         * darwin-nat.c: Use C++ exception handling.
6349         * cp-valprint.c: Use C++ exception handling.
6350         * cp-support.c: Use C++ exception handling.
6351         * cp-abi.c: Use C++ exception handling.
6352         * corelow.c: Use C++ exception handling.
6353         * completer.c: Use C++ exception handling.
6354         * compile/compile-object-run.c: Use C++ exception handling.
6355         * compile/compile-object-load.c: Use C++ exception handling.
6356         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6357         * compile/compile-c-symbols.c: Use C++ exception handling.
6358         * common/selftest.c: Use C++ exception handling.
6359         * common/new-op.c: Use C++ exception handling.
6360         * cli/cli-script.c: Use C++ exception handling.
6361         * cli/cli-interp.c: Use C++ exception handling.
6362         * cli/cli-cmds.c: Use C++ exception handling.
6363         * c-varobj.c: Use C++ exception handling.
6364         * btrace.c: Use C++ exception handling.
6365         * breakpoint.c: Use C++ exception handling.
6366         * break-catch-throw.c: Use C++ exception handling.
6367         * arch-utils.c: Use C++ exception handling.
6368         * amd64-tdep.c: Use C++ exception handling.
6369         * ada-valprint.c: Use C++ exception handling.
6370         * ada-typeprint.c: Use C++ exception handling.
6371         * ada-lang.c: Use C++ exception handling.
6372         * aarch64-tdep.c: Use C++ exception handling.
6373
6374 2019-04-08  Tom Tromey  <tom@tromey.com>
6375
6376         * xml-support.c (gdb_xml_parser::parse): Update.
6377         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6378         * value.c (show_convenience): Update.
6379         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6380         (test_parse_flags_qcs): Update.
6381         * thread.c (thr_try_catch_cmd): Update.
6382         * target.c (target_translate_tls_address): Update.
6383         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6384         (info_frame_command_core, frame_apply_command_count): Update.
6385         * rust-exp.y (rust_lex_exception_test): Update.
6386         * riscv-tdep.c (riscv_print_one_register_info): Update.
6387         * remote.c (remote_target::enable_btrace): Update.
6388         * record-btrace.c (record_btrace_enable_warn): Update.
6389         * python/py-utils.c (gdbpy_convert_exception): Update.
6390         * printcmd.c (do_one_display, print_variable_and_value): Update.
6391         * mi/mi-main.c (mi_print_exception): Update.
6392         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6393         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6394         * linux-nat.c (linux_nat_target::attach): Update.
6395         * linux-fork.c (class scoped_switch_fork_info): Update.
6396         * infrun.c (displaced_step_prepare): Update.
6397         * infcall.c (call_function_by_hand_dummy): Update.
6398         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6399         * gnu-v3-abi.c (print_one_vtable): Update.
6400         * frame.c (get_prev_frame_always): Update.
6401         * f-valprint.c (info_common_command_for_block): Update.
6402         * exec.c (try_open_exec_file): Update.
6403         * exceptions.c (print_exception, exception_print)
6404         (exception_fprintf, exception_print_same): Update.
6405         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6406         * dwarf-index-cache.c (index_cache::store)
6407         (index_cache::lookup_gdb_index): Update.
6408         * darwin-nat.c (maybe_cache_shell): Update.
6409         * cp-valprint.c (cp_print_value_fields): Update.
6410         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6411         (gcc_cplus_symbol_address): Update.
6412         * compile/compile-c-symbols.c (gcc_convert_symbol)
6413         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6414         * common/selftest.c: Update.
6415         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6416         a std::string.
6417         (exception_try_scope_entry, exception_try_scope_exit): Don't
6418         declare.
6419         (struct exception_try_scope): Remove.
6420         (TRY): Don't use exception_try_scope.
6421         (struct gdb_exception): Add constructor, operator=.
6422         <what>: New method.
6423         (struct gdb_exception_RETURN_MASK_ALL)
6424         (struct gdb_exception_RETURN_MASK_ERROR)
6425         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6426         (struct gdb_quit_bad_alloc): Update.
6427         * common/common-exceptions.c (exception_none): Change
6428         initializer.
6429         (struct catcher) <state, exception>: Initialize inline.
6430         <prev>: Remove member.
6431         (current_catcher): Remove.
6432         (catchers): New global.
6433         (exceptions_state_mc_init): Simplify.
6434         (catcher_pop): Remove.
6435         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6436         (try_scope_depth, exception_try_scope_entry)
6437         (exception_try_scope_exit): Remove.
6438         (throw_exception_sjlj): Update.
6439         (exception_messages, exception_messages_size): Remove.
6440         (throw_it): Simplify.
6441         (gdb_exception_sliced_copy): Remove.
6442         (throw_exception_cxx): Update.
6443         * cli/cli-script.c (script_from_file): Update.
6444         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6445         Update.
6446         * ada-valprint.c (ada_val_print): Update.
6447         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6448         (create_excep_cond_exprs): Update.
6449
6450 2019-04-08  Tom Tromey  <tom@tromey.com>
6451
6452         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6453         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6454         (TRY, CATCH, END_CATCH): Remove some definitions.
6455         * common/common-exceptions.c: Don't use GDB_XCPT.
6456         (catcher_list_size): Remove.
6457         (throw_exception, throw_it): Simplify.
6458
6459 2019-04-05  Tom Tromey  <tom@tromey.com>
6460
6461         Revert the header-sorting patch.
6462         * ft32-tdep.c: Revert.
6463         * frv-tdep.c: Revert.
6464         * frv-linux-tdep.c: Revert.
6465         * frame.c: Revert.
6466         * frame-unwind.c: Revert.
6467         * frame-base.c: Revert.
6468         * fork-child.c: Revert.
6469         * findvar.c: Revert.
6470         * findcmd.c: Revert.
6471         * filesystem.c: Revert.
6472         * filename-seen-cache.h: Revert.
6473         * filename-seen-cache.c: Revert.
6474         * fbsd-tdep.c: Revert.
6475         * fbsd-nat.h: Revert.
6476         * fbsd-nat.c: Revert.
6477         * f-valprint.c: Revert.
6478         * f-typeprint.c: Revert.
6479         * f-lang.c: Revert.
6480         * extension.h: Revert.
6481         * extension.c: Revert.
6482         * extension-priv.h: Revert.
6483         * expprint.c: Revert.
6484         * exec.h: Revert.
6485         * exec.c: Revert.
6486         * exceptions.c: Revert.
6487         * event-top.c: Revert.
6488         * event-loop.c: Revert.
6489         * eval.c: Revert.
6490         * elfread.c: Revert.
6491         * dwarf2read.h: Revert.
6492         * dwarf2read.c: Revert.
6493         * dwarf2loc.c: Revert.
6494         * dwarf2expr.h: Revert.
6495         * dwarf2expr.c: Revert.
6496         * dwarf2-frame.c: Revert.
6497         * dwarf2-frame-tailcall.c: Revert.
6498         * dwarf-index-write.h: Revert.
6499         * dwarf-index-write.c: Revert.
6500         * dwarf-index-common.c: Revert.
6501         * dwarf-index-cache.h: Revert.
6502         * dwarf-index-cache.c: Revert.
6503         * dummy-frame.c: Revert.
6504         * dtrace-probe.c: Revert.
6505         * disasm.h: Revert.
6506         * disasm.c: Revert.
6507         * disasm-selftests.c: Revert.
6508         * dictionary.c: Revert.
6509         * dicos-tdep.c: Revert.
6510         * demangle.c: Revert.
6511         * dcache.h: Revert.
6512         * dcache.c: Revert.
6513         * darwin-nat.h: Revert.
6514         * darwin-nat.c: Revert.
6515         * darwin-nat-info.c: Revert.
6516         * d-valprint.c: Revert.
6517         * d-namespace.c: Revert.
6518         * d-lang.c: Revert.
6519         * ctf.c: Revert.
6520         * csky-tdep.c: Revert.
6521         * csky-linux-tdep.c: Revert.
6522         * cris-tdep.c: Revert.
6523         * cris-linux-tdep.c: Revert.
6524         * cp-valprint.c: Revert.
6525         * cp-support.c: Revert.
6526         * cp-namespace.c: Revert.
6527         * cp-abi.c: Revert.
6528         * corelow.c: Revert.
6529         * corefile.c: Revert.
6530         * continuations.c: Revert.
6531         * completer.h: Revert.
6532         * completer.c: Revert.
6533         * complaints.c: Revert.
6534         * coffread.c: Revert.
6535         * coff-pe-read.c: Revert.
6536         * cli-out.h: Revert.
6537         * cli-out.c: Revert.
6538         * charset.c: Revert.
6539         * c-varobj.c: Revert.
6540         * c-valprint.c: Revert.
6541         * c-typeprint.c: Revert.
6542         * c-lang.c: Revert.
6543         * buildsym.c: Revert.
6544         * buildsym-legacy.c: Revert.
6545         * build-id.h: Revert.
6546         * build-id.c: Revert.
6547         * btrace.c: Revert.
6548         * bsd-uthread.c: Revert.
6549         * breakpoint.h: Revert.
6550         * breakpoint.c: Revert.
6551         * break-catch-throw.c: Revert.
6552         * break-catch-syscall.c: Revert.
6553         * break-catch-sig.c: Revert.
6554         * blockframe.c: Revert.
6555         * block.c: Revert.
6556         * bfin-tdep.c: Revert.
6557         * bfin-linux-tdep.c: Revert.
6558         * bfd-target.c: Revert.
6559         * bcache.c: Revert.
6560         * ax-general.c: Revert.
6561         * ax-gdb.h: Revert.
6562         * ax-gdb.c: Revert.
6563         * avr-tdep.c: Revert.
6564         * auxv.c: Revert.
6565         * auto-load.c: Revert.
6566         * arm-wince-tdep.c: Revert.
6567         * arm-tdep.c: Revert.
6568         * arm-symbian-tdep.c: Revert.
6569         * arm-pikeos-tdep.c: Revert.
6570         * arm-obsd-tdep.c: Revert.
6571         * arm-nbsd-tdep.c: Revert.
6572         * arm-nbsd-nat.c: Revert.
6573         * arm-linux-tdep.c: Revert.
6574         * arm-linux-nat.c: Revert.
6575         * arm-fbsd-tdep.c: Revert.
6576         * arm-fbsd-nat.c: Revert.
6577         * arm-bsd-tdep.c: Revert.
6578         * arch-utils.c: Revert.
6579         * arc-tdep.c: Revert.
6580         * arc-newlib-tdep.c: Revert.
6581         * annotate.h: Revert.
6582         * annotate.c: Revert.
6583         * amd64-windows-tdep.c: Revert.
6584         * amd64-windows-nat.c: Revert.
6585         * amd64-tdep.c: Revert.
6586         * amd64-sol2-tdep.c: Revert.
6587         * amd64-obsd-tdep.c: Revert.
6588         * amd64-obsd-nat.c: Revert.
6589         * amd64-nbsd-tdep.c: Revert.
6590         * amd64-nbsd-nat.c: Revert.
6591         * amd64-nat.c: Revert.
6592         * amd64-linux-tdep.c: Revert.
6593         * amd64-linux-nat.c: Revert.
6594         * amd64-fbsd-tdep.c: Revert.
6595         * amd64-fbsd-nat.c: Revert.
6596         * amd64-dicos-tdep.c: Revert.
6597         * amd64-darwin-tdep.c: Revert.
6598         * amd64-bsd-nat.c: Revert.
6599         * alpha-tdep.c: Revert.
6600         * alpha-obsd-tdep.c: Revert.
6601         * alpha-nbsd-tdep.c: Revert.
6602         * alpha-mdebug-tdep.c: Revert.
6603         * alpha-linux-tdep.c: Revert.
6604         * alpha-linux-nat.c: Revert.
6605         * alpha-bsd-tdep.c: Revert.
6606         * alpha-bsd-nat.c: Revert.
6607         * aix-thread.c: Revert.
6608         * agent.c: Revert.
6609         * addrmap.c: Revert.
6610         * ada-varobj.c: Revert.
6611         * ada-valprint.c: Revert.
6612         * ada-typeprint.c: Revert.
6613         * ada-tasks.c: Revert.
6614         * ada-lang.c: Revert.
6615         * aarch64-tdep.c: Revert.
6616         * aarch64-ravenscar-thread.c: Revert.
6617         * aarch64-newlib-tdep.c: Revert.
6618         * aarch64-linux-tdep.c: Revert.
6619         * aarch64-linux-nat.c: Revert.
6620         * aarch64-fbsd-tdep.c: Revert.
6621         * aarch64-fbsd-nat.c: Revert.
6622         * aarch32-linux-nat.c: Revert.
6623
6624 2019-04-05  Tom Tromey  <tom@tromey.com>
6625
6626         * ft32-tdep.c: Sort headers.
6627         * frv-tdep.c: Sort headers.
6628         * frv-linux-tdep.c: Sort headers.
6629         * frame.c: Sort headers.
6630         * frame-unwind.c: Sort headers.
6631         * frame-base.c: Sort headers.
6632         * fork-child.c: Sort headers.
6633         * findvar.c: Sort headers.
6634         * findcmd.c: Sort headers.
6635         * filesystem.c: Sort headers.
6636         * filename-seen-cache.h: Sort headers.
6637         * filename-seen-cache.c: Sort headers.
6638         * fbsd-tdep.c: Sort headers.
6639         * fbsd-nat.h: Sort headers.
6640         * fbsd-nat.c: Sort headers.
6641         * f-valprint.c: Sort headers.
6642         * f-typeprint.c: Sort headers.
6643         * f-lang.c: Sort headers.
6644         * extension.h: Sort headers.
6645         * extension.c: Sort headers.
6646         * extension-priv.h: Sort headers.
6647         * expprint.c: Sort headers.
6648         * exec.h: Sort headers.
6649         * exec.c: Sort headers.
6650         * exceptions.c: Sort headers.
6651         * event-top.c: Sort headers.
6652         * event-loop.c: Sort headers.
6653         * eval.c: Sort headers.
6654         * elfread.c: Sort headers.
6655         * dwarf2read.h: Sort headers.
6656         * dwarf2read.c: Sort headers.
6657         * dwarf2loc.c: Sort headers.
6658         * dwarf2expr.h: Sort headers.
6659         * dwarf2expr.c: Sort headers.
6660         * dwarf2-frame.c: Sort headers.
6661         * dwarf2-frame-tailcall.c: Sort headers.
6662         * dwarf-index-write.h: Sort headers.
6663         * dwarf-index-write.c: Sort headers.
6664         * dwarf-index-common.c: Sort headers.
6665         * dwarf-index-cache.h: Sort headers.
6666         * dwarf-index-cache.c: Sort headers.
6667         * dummy-frame.c: Sort headers.
6668         * dtrace-probe.c: Sort headers.
6669         * disasm.h: Sort headers.
6670         * disasm.c: Sort headers.
6671         * disasm-selftests.c: Sort headers.
6672         * dictionary.c: Sort headers.
6673         * dicos-tdep.c: Sort headers.
6674         * demangle.c: Sort headers.
6675         * dcache.h: Sort headers.
6676         * dcache.c: Sort headers.
6677         * darwin-nat.h: Sort headers.
6678         * darwin-nat.c: Sort headers.
6679         * darwin-nat-info.c: Sort headers.
6680         * d-valprint.c: Sort headers.
6681         * d-namespace.c: Sort headers.
6682         * d-lang.c: Sort headers.
6683         * ctf.c: Sort headers.
6684         * csky-tdep.c: Sort headers.
6685         * csky-linux-tdep.c: Sort headers.
6686         * cris-tdep.c: Sort headers.
6687         * cris-linux-tdep.c: Sort headers.
6688         * cp-valprint.c: Sort headers.
6689         * cp-support.c: Sort headers.
6690         * cp-namespace.c: Sort headers.
6691         * cp-abi.c: Sort headers.
6692         * corelow.c: Sort headers.
6693         * corefile.c: Sort headers.
6694         * continuations.c: Sort headers.
6695         * completer.h: Sort headers.
6696         * completer.c: Sort headers.
6697         * complaints.c: Sort headers.
6698         * coffread.c: Sort headers.
6699         * coff-pe-read.c: Sort headers.
6700         * cli-out.h: Sort headers.
6701         * cli-out.c: Sort headers.
6702         * charset.c: Sort headers.
6703         * c-varobj.c: Sort headers.
6704         * c-valprint.c: Sort headers.
6705         * c-typeprint.c: Sort headers.
6706         * c-lang.c: Sort headers.
6707         * buildsym.c: Sort headers.
6708         * buildsym-legacy.c: Sort headers.
6709         * build-id.h: Sort headers.
6710         * build-id.c: Sort headers.
6711         * btrace.c: Sort headers.
6712         * bsd-uthread.c: Sort headers.
6713         * breakpoint.h: Sort headers.
6714         * breakpoint.c: Sort headers.
6715         * break-catch-throw.c: Sort headers.
6716         * break-catch-syscall.c: Sort headers.
6717         * break-catch-sig.c: Sort headers.
6718         * blockframe.c: Sort headers.
6719         * block.c: Sort headers.
6720         * bfin-tdep.c: Sort headers.
6721         * bfin-linux-tdep.c: Sort headers.
6722         * bfd-target.c: Sort headers.
6723         * bcache.c: Sort headers.
6724         * ax-general.c: Sort headers.
6725         * ax-gdb.h: Sort headers.
6726         * ax-gdb.c: Sort headers.
6727         * avr-tdep.c: Sort headers.
6728         * auxv.c: Sort headers.
6729         * auto-load.c: Sort headers.
6730         * arm-wince-tdep.c: Sort headers.
6731         * arm-tdep.c: Sort headers.
6732         * arm-symbian-tdep.c: Sort headers.
6733         * arm-pikeos-tdep.c: Sort headers.
6734         * arm-obsd-tdep.c: Sort headers.
6735         * arm-nbsd-tdep.c: Sort headers.
6736         * arm-nbsd-nat.c: Sort headers.
6737         * arm-linux-tdep.c: Sort headers.
6738         * arm-linux-nat.c: Sort headers.
6739         * arm-fbsd-tdep.c: Sort headers.
6740         * arm-fbsd-nat.c: Sort headers.
6741         * arm-bsd-tdep.c: Sort headers.
6742         * arch-utils.c: Sort headers.
6743         * arc-tdep.c: Sort headers.
6744         * arc-newlib-tdep.c: Sort headers.
6745         * annotate.h: Sort headers.
6746         * annotate.c: Sort headers.
6747         * amd64-windows-tdep.c: Sort headers.
6748         * amd64-windows-nat.c: Sort headers.
6749         * amd64-tdep.c: Sort headers.
6750         * amd64-sol2-tdep.c: Sort headers.
6751         * amd64-obsd-tdep.c: Sort headers.
6752         * amd64-obsd-nat.c: Sort headers.
6753         * amd64-nbsd-tdep.c: Sort headers.
6754         * amd64-nbsd-nat.c: Sort headers.
6755         * amd64-nat.c: Sort headers.
6756         * amd64-linux-tdep.c: Sort headers.
6757         * amd64-linux-nat.c: Sort headers.
6758         * amd64-fbsd-tdep.c: Sort headers.
6759         * amd64-fbsd-nat.c: Sort headers.
6760         * amd64-dicos-tdep.c: Sort headers.
6761         * amd64-darwin-tdep.c: Sort headers.
6762         * amd64-bsd-nat.c: Sort headers.
6763         * alpha-tdep.c: Sort headers.
6764         * alpha-obsd-tdep.c: Sort headers.
6765         * alpha-nbsd-tdep.c: Sort headers.
6766         * alpha-mdebug-tdep.c: Sort headers.
6767         * alpha-linux-tdep.c: Sort headers.
6768         * alpha-linux-nat.c: Sort headers.
6769         * alpha-bsd-tdep.c: Sort headers.
6770         * alpha-bsd-nat.c: Sort headers.
6771         * aix-thread.c: Sort headers.
6772         * agent.c: Sort headers.
6773         * addrmap.c: Sort headers.
6774         * ada-varobj.c: Sort headers.
6775         * ada-valprint.c: Sort headers.
6776         * ada-typeprint.c: Sort headers.
6777         * ada-tasks.c: Sort headers.
6778         * ada-lang.c: Sort headers.
6779         * aarch64-tdep.c: Sort headers.
6780         * aarch64-ravenscar-thread.c: Sort headers.
6781         * aarch64-newlib-tdep.c: Sort headers.
6782         * aarch64-linux-tdep.c: Sort headers.
6783         * aarch64-linux-nat.c: Sort headers.
6784         * aarch64-fbsd-tdep.c: Sort headers.
6785         * aarch64-fbsd-nat.c: Sort headers.
6786         * aarch32-linux-nat.c: Sort headers.
6787
6788 2019-04-04  Tom Tromey  <tom@tromey.com>
6789
6790         * varobj.c (varobj_create): Update.
6791         * rust-exp.y (struct rust_parser) <update_innermost_block,
6792         lookup_symbol>: New methods.
6793         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6794         Rename.
6795         (rust_parser::rust_lookup_type)
6796         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6797         * printcmd.c (display_command, do_one_display): Update.
6798         * parser-defs.h (struct parser_state) <parser_state>: Add
6799         "tracker" parameter.
6800         (block_tracker): New member.
6801         (class innermost_block_tracker) <innermost_block_tracker>: Add
6802         "types" parameter.
6803         <reset>: Remove method.
6804         (innermost_block): Don't declare.
6805         (null_post_parser): Update.
6806         * parse.c (innermost_block): Remove global.
6807         (write_dollar_variable): Update.
6808         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6809         Remove "tracker_types" parameter.
6810         (parse_expression): Add "tracker" parameter.
6811         (parse_expression_for_completion): Update.
6812         (null_post_parser): Add "tracker" parameter.
6813         * p-exp.y: Update rules.
6814         * m2-exp.y: Update rules.
6815         * language.h (struct language_defn) <la_post_parser>: Add
6816         "tracker" parameter.
6817         * go-exp.y: Update rules.
6818         * f-exp.y: Update rules.
6819         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6820         parameter.
6821         * d-exp.y: Update rules.
6822         * c-exp.y: Update rules.
6823         * breakpoint.c (set_breakpoint_condition): Create an
6824         innermost_block_tracker.
6825         (watch_command_1): Likewise.
6826         * ada-lang.c (resolve): Add "tracker" parameter.
6827         (resolve_subexp): Likewise.
6828         * ada-exp.y (write_var_from_sym): Update.
6829
6830 2019-04-04  Tom Tromey  <tom@tromey.com>
6831
6832         * type-stack.h: New file.
6833         * type-stack.c: New file.
6834         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6835         type-stack.h.
6836         (insert_into_type_stack, insert_type, push_type, push_type_int)
6837         (insert_type_address_space, pop_type, pop_type_int)
6838         (pop_typelist, pop_type_stack, append_type_stack)
6839         (push_type_stack, get_type_stack, push_typelist)
6840         (follow_type_instance_flags, follow_types): Don't declare.
6841         * parse.c (type_stack): Remove global.
6842         (parse_exp_in_context): Update.
6843         (insert_into_type_stack, insert_type, push_type, push_type_int)
6844         (insert_type_address_space, pop_type, pop_type_int)
6845         (pop_typelist, pop_type_stack, append_type_stack)
6846         (push_type_stack, get_type_stack, push_typelist)
6847         (follow_type_instance_flags, follow_types): Remove (moved to
6848         type-stack.c).
6849         * f-exp.y (type_stack): New global.
6850         Update rules.
6851         (push_kind_type, f_parse): Update.
6852         * d-exp.y (type_stack): New global.
6853         Update rules.
6854         (d_parse): Update.
6855         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6856         Update rules.
6857         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6858         (HFILES_NO_SRCDIR): Add type-stack.h.
6859
6860 2019-04-04  Tom Tromey  <tom@tromey.com>
6861
6862         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6863         (rust_parser::convert_ast_to_expression, rust_parse)
6864         (rust_lex_test_completion, rust_lex_tests): Update.
6865         * parser-defs.h (struct expr_completion_state): New.
6866         (struct parser_state) <parser_state>: Add completion parameter.
6867         <mark_struct_expression, mark_completion_tag>: New methods.
6868         <parse_completion, m_completion_state>: New members.
6869         (prefixify_expression, null_post_parser): Update.
6870         (mark_struct_expression, mark_completion_tag): Don't declare.
6871         * parse.c (parse_completion, expout_last_struct)
6872         (expout_tag_completion_type, expout_completion_name): Remove
6873         globals.
6874         (parser_state::mark_struct_expression)
6875         (parser_state::mark_completion_tag): Now methods.
6876         (prefixify_expression): Add last_struct parameter.
6877         (prefixify_subexp): Likewise.
6878         (parse_exp_1): Update.
6879         (parse_exp_in_context): Add cstate parameter.  Update.
6880         (parse_expression_for_completion): Create an
6881         expr_completion_state.
6882         (null_post_parser): Add "completion" parameter.
6883         * p-exp.y: Update rules.
6884         (yylex): Update.
6885         * language.h (struct language_defn) <la_post_parser>: Add
6886         "completing" parameter.
6887         * go-exp.y: Update rules.
6888         (lex_one_token): Update.
6889         * expression.h (parse_completion): Don't declare.
6890         * d-exp.y: Update rules.
6891         (lex_one_token): Update rules.
6892         * c-exp.y: Update rules.
6893         (lex_one_token): Update.
6894         * ada-lang.c (resolve): Add "parse_completion" parameter.
6895         (resolve_subexp): Likewise.
6896         (ada_resolve_function): Likewise.
6897
6898 2019-04-04  Tom Tromey  <tom@tromey.com>
6899
6900         * parser-defs.h (struct parser_state) <start_arglist,
6901         end_arglist>: New methods.
6902         <arglist_len, m_funcall_chain>: New members.
6903         (arglist_len, start_arglist, end_arglist): Don't declare.
6904         * parse.c (arglist_len, funcall_chain): Remove global.
6905         (start_arglist, end_arglist): Remove functions.
6906         (parse_exp_in_context): Update.
6907         * p-exp.y: Update rules.
6908         * m2-exp.y: Update rules.
6909         * go-exp.y: Update rules.
6910         * f-exp.y: Update rules.
6911         * d-exp.y: Update rules.
6912         * c-exp.y: Update rules.
6913
6914 2019-04-04  Tom Tromey  <tom@tromey.com>
6915
6916         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6917         lex_operator, push_back>: New methods.
6918         Update all rules.
6919         (rust_parser::lex_hex, lex_escape): Rename and update.
6920         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6921         (rust_parser::lex_operator): Rename and update.
6922         (rust_parser::lex_number, rustyylex, rustyyerror)
6923         (rust_lex_test_init, rust_lex_test_sequence)
6924         (rust_lex_test_push_back, rust_lex_tests): Update.
6925         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6926         parameter.
6927         <lexptr, prev_lexptr>: New members.
6928         (lexptr, prev_lexptr): Don't declare.
6929         * parse.c (lexptr, prev_lexptr): Remove globals.
6930         (parse_exp_in_context): Update.
6931         * p-exp.y (yylex, yyerror): Update.
6932         * m2-exp.y (parse_number, yylex, yyerror): Update.
6933         * go-exp.y (lex_one_token, yyerror): Update.
6934         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6935         * d-exp.y (lex_one_token, yyerror): Update.
6936         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6937         (lex_one_token, yyerror): Update.
6938         * ada-lex.l (YY_INPUT): Update.
6939         (rewind_to_char): Update.
6940         * ada-exp.y (yyerror): Update.
6941
6942 2019-04-04  Tom Tromey  <tom@tromey.com>
6943
6944         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6945         * parser-defs.h (struct parser_state) <parser_state>: Add new
6946         parameter.
6947         <comma_terminates>: New member.
6948         (comma_terminates): Don't declare global.
6949         * parse.c (comma_terminates): Remove global.
6950         (parse_exp_in_context): Update.
6951         * p-exp.y (yylex): Update.
6952         * m2-exp.y (yylex): Update.
6953         * go-exp.y (lex_one_token): Update.
6954         * f-exp.y (yylex): Update.
6955         * d-exp.y (lex_one_token): Update.
6956         * c-exp.y (lex_one_token): Update.
6957         * ada-lex.l: Update.
6958
6959 2019-04-04  Tom Tromey  <tom@tromey.com>
6960
6961         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6962         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6963         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6964         * parser-defs.h (paren_depth): Don't declare.
6965         * parse.c (paren_depth): Remove global.
6966         (parse_exp_in_context): Update.
6967         * p-exp.y (paren_depth): New global.
6968         (pascal_parse): Initialize it.
6969         * m2-exp.y (paren_depth): New global.
6970         (m2_parse): Initialize it.
6971         * go-exp.y (paren_depth): New global.
6972         (go_parse): Initialize it.
6973         * f-exp.y (paren_depth): New global.
6974         (f_parse): Initialize it.
6975         * d-exp.y (paren_depth): New global.
6976         (d_parse): Initialize it.
6977         * c-exp.y (paren_depth): New global.
6978         (c_parse): Initialize it.
6979         * ada-lex.l (paren_depth): New global.
6980         (lexer_init): Initialize it.
6981
6982 2019-04-04  Tom Tromey  <tom@tromey.com>
6983
6984         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6985         (rust_parser::convert_ast_to_type)
6986         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6987         * parser-defs.h (struct parser_state) <parser_state>: Add
6988         parameters.  Initialize new members.
6989         <expression_context_block, expression_context_pc>: New members.
6990         * parse.c (expression_context_block, expression_context_pc):
6991         Remove globals.
6992         (parse_exp_in_context): Update.
6993         * p-exp.y: Update all rules.
6994         (yylex): Update.
6995         * m2-exp.y: Update all rules.
6996         (yylex): Update.
6997         * go-exp.y (yylex): Update.
6998         * f-exp.y (yylex): Update.
6999         * d-exp.y: Update all rules.
7000         (yylex): Update.
7001         * c-exp.y: Update all rules.
7002         (lex_one_token, classify_name, yylex, c_parse): Update.
7003         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7004
7005 2019-04-04  Tom Tromey  <tom@tromey.com>
7006
7007         * gdbarch.h, gdbarch.c: Rebuild.
7008         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7009         * stap-probe.h: 
7010         (struct stap_parse_info): Replace "parser_state" with
7011         "expr_builder".
7012         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7013         (parser_state): New class.
7014         * parse.c (expr_builder): Rename.
7015         (expr_builder::release): Rename.
7016         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7017         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7018         (write_exp_elt_longcst, write_exp_elt_floatcst)
7019         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7020         (write_exp_string_vector, write_exp_bitstring)
7021         (write_exp_msymbol, mark_struct_expression)
7022         (write_dollar_variable)
7023         (insert_type_address_space, increase_expout_size): Replace
7024         "parser_state" with "expr_builder".
7025         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7026         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7027         "parser_state" with "expr_builder".
7028
7029 2019-04-04  Tom Tromey  <tom@tromey.com>
7030
7031         * rust-exp.y: Replace "parse_language" with method call.
7032         * p-exp.y: 
7033         (yylex): Replace "parse_language" with method call.
7034         * m2-exp.y: 
7035         (yylex): Replace "parse_language" with method call.
7036         * go-exp.y (classify_name): Replace "parse_language" with method
7037         call.
7038         * f-exp.y (yylex): Replace "parse_language" with method call.
7039         * d-exp.y (lex_one_token): Replace "parse_language" with method
7040         call.
7041         * c-exp.y: 
7042         (lex_one_token, classify_name, yylex): Replace "parse_language"
7043         with method call.
7044         * ada-exp.y (find_primitive_type, type_char)
7045         (type_system_address): Replace "parse_language" with method call.
7046
7047 2019-04-04  Tom Tromey  <tom@tromey.com>
7048
7049         * rust-exp.y: Replace "parse_gdbarch" with method call.
7050         * parse.c (write_dollar_variable, insert_type_address_space):
7051         Replace "parse_gdbarch" with method call.
7052         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7053         call.
7054         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7055         call.
7056         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7057         "parse_gdbarch" with method call.
7058         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7059         with method call.
7060         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7061         "parse_gdbarch" with method call.
7062         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7063         "parse_gdbarch" with method call.
7064         * c-exp.y (parse_type, parse_number, classify_name): Replace
7065         "parse_gdbarch" with method call.
7066         * ada-lex.l: Replace "parse_gdbarch" with method call.
7067         * ada-exp.y (parse_type, find_primitive_type, type_char)
7068         (type_system_address): Replace "parse_gdbarch" with method call.
7069
7070 2019-04-04  Tom Tromey  <tom@tromey.com>
7071
7072         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7073         * stap-probe.c (stap_parse_argument): Update.
7074         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7075         initial_size parameter.
7076         * rust-exp.y (rust_lex_tests): Update.
7077         * parse.c (parser_state): Update.
7078         (parse_exp_in_context): Update.
7079         * parser-defs.h (struct parser_state) <parser_state>: Remove
7080         "initial_size" parameter.
7081
7082 2019-04-04  Tom Tromey  <tom@tromey.com>
7083
7084         * parser-defs.h (increase_expout_size): Don't declare.
7085         * parse.c (increase_expout_size): Now static.
7086
7087 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7088
7089         * gnu-nat.c (gnu_nat_target::wait): Fix
7090         target_waitstatus_to_string call.
7091
7092 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7093
7094         * eval.c (evaluate_subexp_standard): Handle internal functions
7095         during Fortran function call handling.
7096
7097 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7098
7099         * NEWS: Mention new internal functions.
7100         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7101         (read_base_type): Use dwarf2_init_complex_target_type.
7102         * value.c (creal_internal_fn): New function.
7103         (cimag_internal_fn): New function.
7104         (_initialize_values): Register new internal functions.
7105
7106 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7107
7108         * infrun.c (stop_all_threads): If debug_infrun, always
7109         trace the wait status after wait_one, using
7110         target_waitstatus_to_string and target_pid_to_str.
7111         (handle_inferior_event): Replace various trace of
7112         wait status kind by a single trace.
7113         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7114         wait status kind image by target_waitstatus_to_string.
7115         * target/waitstatus.c (target_waitstatus_to_string): Fix
7116         obsolete comment.
7117
7118 2019-04-01  Tom Tromey  <tromey@adacore.com>
7119
7120         PR symtab/23331:
7121         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7122
7123 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7124             Pedro Alves  <palves@redhat.com>
7125
7126         * top.c (quit_force): Call 'finalize_values'.
7127         * value.c (finalize_values): New function.
7128         * value.h (finalize_values): Declare.
7129
7130 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7131
7132         * NEWS: Announce $_gdb_major and $_gdb_minor.
7133
7134         * top.c (init_gdb_version_vars): New function.
7135         (gdb_init): Call init_gdb_version_vars.
7136
7137 2019-03-29  Tom Tromey  <tromey@adacore.com>
7138
7139         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7140         help text.  Remove dead code.
7141
7142 2019-03-29  Keith Seitz  <keiths@redhat.com>
7143
7144         From Siddhesh Poyarekar:
7145         * f-lang.h (f77_get_upperbound): Return LONGEST.
7146         (f77_get_lowerbound): Likewise.
7147         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7148         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7149         print them.
7150         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7151         plongest to format print it.
7152         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7153         (f77_get_upperbound): Likewise.
7154         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7155         LOWER_BOUND to LONGEST.
7156         (f77_create_arrayprint_offset_tbl): Likewise.
7157
7158 2019-03-29  Keith Seitz  <keiths@redhat.com>
7159
7160         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7161         %s/pulongest for TYPE_LENGTH instead of %d in format
7162         strings.
7163         * ada-typerint.c (ada_print_type): Likewise.
7164         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7165         * compile/compile-c-support.c (generate_register_struct): Likewise.
7166         * gdbtypes.c (recursive_dump_type): Likewise.
7167         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7168         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7169         instead of %d in format strings.
7170         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7171         to std::min to ULONGEST.
7172         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7173         instead of %d in format strings.
7174         * tracepoint.c (info_scope_command): Likewise.
7175         * typeprint.c (print_offset_data::update)
7176         (print_offset_data::finish): Likewise.
7177         * xtensa-tdep.c (xtensa_store_return_value)
7178         (xtensa_push_dummy_call): Likewise.
7179
7180 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7181
7182         * windows-nat.c (display_selector): Fixed format specifications
7183         for 64-bit Cygwin.
7184
7185 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7186
7187         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7188
7189 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7190
7191         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7192         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7193         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7194         (nios2_linux_init_abi): Install it.
7195
7196 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7197
7198         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7199
7200 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7201
7202         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7203
7204 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7205             Tom Tromey  <tromey@adacore.com>
7206
7207         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7208
7209 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7210
7211         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7212         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7213         method to compute the bounds of range types. Also print "[evaluated]"
7214         if the bounds' values come from a dynamic evaluation.
7215
7216 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7217
7218         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7219         whitespace when pretty printing is on.
7220
7221 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7222
7223         * ppc-linux-nat.c: Add include.
7224
7225 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7226
7227         * NEWS: Mention AArch64 Pointer Authentication.
7228
7229 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7230
7231         * arm-linux-nat.c: Add include.
7232
7233 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7234
7235         * source-cache.c (source_cache::get_source_lines): Re-read
7236         fullname after calling open_source_file.
7237
7238 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7239
7240         * NEWS: Mention TLS support for FreeBSD.
7241
7242 2019-03-25  Tom Tromey  <tromey@adacore.com>
7243
7244         * minsyms.c (BUNCH_SIZE): Update comment.
7245         (~minimal_symbol_reader): Remove old comment.
7246         (compact_minimal_symbols): Update comment.
7247         (minimal_symbol_reader::install): Remove old comment.  Update
7248         other comments.
7249
7250 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7251
7252         * s390-linux-nat.c: Add include.
7253
7254 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7255
7256         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7257         Call linux_get_hwcap.
7258         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7259         Likewise.
7260         (aarch64_linux_get_hwcap): Remove function.
7261         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7262         declaration.
7263         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7264         linux_get_hwcap.
7265         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7266         * linux-tdep.c (linux_get_hwcap): Add function.
7267         (linux_get_hwcap2): Likewise.
7268         * linux-tdep.h (linux_get_hwcap): Add declaration.
7269         (linux_get_hwcap2): Likewise.
7270         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7271         (ppc_linux_get_hwcap2): Likewise.
7272         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7273         linux_get_hwcap.
7274         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7275         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7276         (ppc_linux_nat_target::read_description): Likewise.
7277         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7278         * s390-linux-nat.c: Likewise.
7279         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7280
7281 2019-03-24  Tom Tromey  <tom@tromey.com>
7282
7283         * ada-lang.c (standard_lookup): Simplify initialization.
7284         (ada_lookup_symbol_nonlocal): Simplify return.
7285         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7286         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7287         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7288         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7289         initialization.
7290         * solib.c (solib_global_lookup): Simplify.
7291         * symtab.c (null_block_symbol): Remove.
7292         (symbol_cache_lookup): Simplify returns.
7293         (lookup_language_this): Simplify returns.
7294         (lookup_symbol_aux): Simplify return.
7295         (lookup_local_symbol): Simplify returns.
7296         (lookup_global_symbol_from_objfile): Simplify return.
7297         (lookup_symbol_in_objfile_symtabs)
7298         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7299         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7300         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7301         * cp-namespace.c (cp_lookup_bare_symbol)
7302         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7303         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7304         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7305         (cp_lookup_symbol_via_imports): Simplify initialization.
7306         (find_symbol_in_baseclass): Likewise.
7307         * symtab.h (null_block_symbol): Remove.
7308         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7309         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7310         (d_lookup_symbol_module): Likewise.
7311         (find_symbol_in_baseclass): Simplify initialization.
7312
7313 2019-03-24  Tom Tromey  <tom@tromey.com>
7314
7315         * expression.h: Don't include symtab.h.
7316         (struct block): Forward declare.
7317
7318 2019-03-24  Tom Tromey  <tom@tromey.com>
7319
7320         * c-exp.y (typebase): Remove casts.
7321         * gdbtypes.c (lookup_unsigned_typename, )
7322         (lookup_signed_typename): Remove cast.
7323         * eval.c (parse_to_comma_and_eval): Remove cast.
7324         * parse.c (write_dollar_variable): Remove cast.
7325         * block.h (struct block) <superblock>: Now const.
7326         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7327         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7328         (map_block): Make "block" const.
7329         * symfile.h (struct quick_symbol_functions)
7330         <map_matching_symbols>: Constify block argument to "callback".
7331         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7332         const.
7333         (find_pc_sect_compunit_symtab): Make "b" const.
7334         (find_symbol_at_address): Likewise.
7335         (search_symbols): Likewise.
7336         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7337         (dw2_debug_names_lookup_symbol): Likewise.
7338         (dw2_map_matching_symbols): Update.
7339         * p-valprint.c (pascal_val_print): Remove "block".
7340         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7341         (aux_add_nonlocal_symbols): Make "block" const.
7342         (resolve_subexp): Remove cast.
7343         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7344         const.
7345         (iterate_over_file_blocks): Likewise.
7346         * f-exp.y (%union) <bval>: Remove.
7347         * coffread.c (patch_opaque_types): Make "b" const.
7348         * spu-tdep.c (spu_catch_start): Make "block" const.
7349         * c-valprint.c (print_unpacked_pointer): Remove "block".
7350         * symmisc.c (dump_symtab_1): Make "b" const.
7351         (block_depth): Make "block" const.
7352         * d-exp.y (%union) <bval>: Remove.
7353         * cp-support.h (cp_lookup_rtti_type): Update.
7354         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7355         * psymtab.c (psym_lookup_symbol): Make "block" const.
7356         (maintenance_check_psymtabs): Make "b" const.
7357         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7358         (enumerate_locals, enumerate_args): Update.
7359         * python/py-symtab.c (stpy_global_block): Make "block" const.
7360         (stpy_static_block): Likewise.
7361         * inline-frame.c (block_starting_point_at): Make "new_block"
7362         const.
7363         * block.c (find_block_in_blockvector): Make return type const.
7364         (blockvector_for_pc_sect): Make "b" const.
7365         (find_block_in_blockvector): Make "b" const.
7366
7367 2019-03-23  Tom Tromey  <tom@tromey.com>
7368
7369         * varobj.c (varobj_create): Update.
7370         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7371         * printcmd.c (display_command, do_one_display): Don't reset
7372         innermost_block.
7373         * parser-defs.h (enum innermost_block_tracker_type): Move to
7374         expression.h.
7375         (innermost_block): Update comment.
7376         * parse.c (parse_exp_1): Add tracker_types parameter.
7377         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7378         tracker_types parameter.  Reset innermost_block.
7379         (parse_exp_in_context): Remove.
7380         (parse_expression_for_completion): Update.
7381         * objfiles.c (~objfile): Don't reset expression_context_block or
7382         innermost_block.
7383         * expression.h (enum innermost_block_tracker_type): Move from
7384         parser-defs.h.
7385         (parse_exp_1): Add tracker_types parameter.
7386         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7387         reset innermost_block.
7388
7389 2019-03-23  Tom Tromey  <tom@tromey.com>
7390
7391         * objfiles.h: Include bcache.h.
7392
7393 2019-03-23  Tom Tromey  <tom@tromey.com>
7394
7395         * linespec.c (get_current_search_block): Use
7396         scoped_restore_current_language.
7397         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7398
7399 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7400             Jiong Wang  <jiong.wang@arm.com>
7401
7402         * aarch64-linux-tdep.c
7403         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7404         section.
7405         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7406
7407 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7408             Jiong Wang  <jiong.wang@arm.com>
7409
7410         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7411         instructions.
7412         (aarch64_analyze_prologue_test): Add PACIASP test.
7413         (aarch64_prologue_prev_register): Unmask PC value.
7414
7415 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7416             Jiong Wang  <jiong.wang@arm.com>
7417
7418         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7419         (aarch64_dwarf2_prev_register): Unmask PC value.
7420         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7421         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7422         DW_CFA_AARCH64_negate_ra_state.
7423         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7424
7425 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7426             Jiong Wang  <jiong.wang@arm.com>
7427
7428         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7429         registers.
7430         (aarch64_pseudo_register_name): Likewise.
7431         (aarch64_pseudo_register_type): Likewise.
7432         (aarch64_pseudo_register_reggroup_p): Likewise.
7433         (aarch64_gdbarch_init): Add pauth registers.
7434         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7435         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7436         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7437         (struct gdbarch_tdep): Add regnum for ra_state.
7438
7439 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7440             Jiong Wang  <jiong.wang@arm.com>
7441
7442         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7443
7444 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7445             Jiong Wang  <jiong.wang@arm.com>
7446
7447         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7448         function.
7449         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7450         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7451         (aarch64_gdbarch_init): Add puth registers.
7452         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7453         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7454         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7455
7456 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7457             Jiong Wang  <jiong.wang@arm.com>
7458
7459         * aarch64-linux-nat.c
7460         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7461         * aarch64-linux-tdep.c
7462         (aarch64_linux_core_read_description): Likewise.
7463         (aarch64_linux_get_hwcap): New function.
7464         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7465         (aarch64_linux_get_hwcap): New declaration.
7466
7467 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7468             Jiong Wang  <jiong.wang@arm.com>
7469
7470         * aarch64-linux-nat.c
7471         (aarch64_linux_nat_target::read_description): Add pauth param.
7472         * aarch64-linux-tdep.c
7473         (aarch64_linux_core_read_description): Likewise.
7474         * aarch64-tdep.c (struct target_desc): Add in pauth.
7475         (aarch64_read_description): Add pauth param.
7476         (aarch64_gdbarch_init): Likewise.
7477         * aarch64-tdep.h (aarch64_read_description): Likewise.
7478         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7479         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7480         * features/Makefile: Add new files.
7481         * features/aarch64-pauth.c: New file.
7482         * features/aarch64-pauth.xml: New file.
7483
7484 2019-03-20  Tom Tromey  <tromey@adacore.com>
7485
7486         * infrun.c (handle_inferior_event): Rename from
7487         handle_inferior_event_1.  Create a scoped_value_mark.
7488         (handle_inferior_event): Remove.
7489
7490 2019-03-19  Tom Tromey  <tromey@adacore.com>
7491
7492         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7493         * infrun.h (print_stop_event): Add "displays" parameter.
7494         * infrun.c (print_stop_event): Add "displays" parameter.
7495
7496 2019-03-19  Pedro Alves  <palves@redhat.com>
7497
7498         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7499         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7500         to -1.  Fix TABs vs spaces.
7501         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7502         * tui/tui-out.h (tui_ui_out) Add intro comments.
7503         <m_line, m_start_of_line>: In-class initialize, and add describing
7504         comment.
7505
7506 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7507
7508         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7509         variable names.
7510         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7511
7512 2019-03-18  Pedro Alves  <palves@redhat.com>
7513             Eli Zaretskii <eliz@gnu.org>
7514
7515         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7516         m_line and m_start_of_line.
7517
7518 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7519
7520         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7521         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7522         it returns a newline.  This fixes a regression in TU mode, whereby
7523         the next line is output on the same screen line as the user input.
7524
7525 2019-03-18  Tom Tromey  <tromey@adacore.com>
7526
7527         * minsyms.c (minimal_symbol_reader::install): Remove call to
7528         obstack_blank.
7529
7530 2019-03-18  Pedro Alves  <palves@redhat.com>
7531
7532         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7533         New globals.
7534         (apply_style): New, factored out from ...
7535         (apply_ansi_escape): ... this.  Handle reverse video mode.
7536         (tui_set_reverse_mode): New function.
7537         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7538         * tui/tui-winsource.c (tui_show_source_line): Use
7539         tui_set_reverse_mode instead of setting A_STANDOUT.
7540         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7541         New setter methods.
7542
7543 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7544
7545         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7546         Handle tabs.
7547
7548 2019-03-18  Tom Tromey  <tromey@adacore.com>
7549
7550         * ada-lang.c (empty_array): Add "high" parameter.
7551         (ada_evaluate_subexp): Update.
7552
7553 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7554
7555         * unittests/string_view-selftests.c: Define
7556         _initialize_string_view_selftests unconditionally.
7557
7558 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7559
7560         PR gdb/24350
7561         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7562
7563 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7564
7565         PR gdb/24351
7566         * windows-nat.c (display_selector): Fix format specifiers.
7567
7568 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7569
7570         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7571         tui_refill_source_window instead of tui_refresh_win, to update the
7572         current execution line.  This fixes redisplay of the current line
7573         when stepping through the code with "next" or "step".
7574
7575 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7576
7577         * source-cache.c (source_cache::get_source_lines): Call
7578         find_source_lines to initialize s->nlines.  This fixes vertical
7579         scrolling of TUI source window when the DOWN arrow is pressed.
7580
7581 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7582
7583         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7584         linux-thread-db.c (_initialize_thread_db): Likewise.
7585
7586 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7587
7588         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7589         wclrtoeol in tui_show_source_line".  This reverts changes made in
7590         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7591
7592 2019-03-15  Tom Tromey  <tom@tromey.com>
7593
7594         * symtab.h (struct minimal_symbol): Derive from
7595         general_symbol_info.
7596         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7597         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7598         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7599         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7600         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7601         (MSYMBOL_SEARCH_NAME): Update.
7602         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7603         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7604         * minsyms.c (minimal_symbol_reader::record_full): Update.
7605
7606 2019-03-15  Tom Tromey  <tom@tromey.com>
7607
7608         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7609
7610 2019-03-15  Tom Tromey  <tom@tromey.com>
7611
7612         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7613         unique_xmalloc_ptr.
7614         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7615         Update.
7616         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7617         (build_minimal_symbol_hash_tables)
7618         (minimal_symbol_reader::install): Update.
7619
7620 2019-03-15  Tom Tromey  <tom@tromey.com>
7621
7622         * symtab.c (create_demangled_names_hash): Update.
7623         (symbol_set_names): Update.
7624         * objfiles.h (struct objfile_per_bfd_storage)
7625         <demangled_names_hash>: Now an htab_up.
7626         * objfiles.c (objfile_per_bfd_storage): Simplify.
7627
7628 2019-03-15  Tom Tromey  <tom@tromey.com>
7629
7630         * objfiles.h (struct objfile_per_bfd_storage): Declare
7631         destructor.
7632         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7633         New.
7634         (get_objfile_bfd_data): Use new.  Don't initialize
7635         language_of_main.
7636         (free_objfile_per_bfd_storage): Remove.
7637         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7638
7639 2019-03-15  Tom Tromey  <tom@tromey.com>
7640
7641         * symfile.c (reread_symbols): Update.
7642         * objfiles.c (objfile::objfile): Update.
7643         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7644         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7645         comment.
7646         (minimal_symbol_reader::install): Update.
7647         (terminate_minimal_symbol_table): Remove.
7648         * jit.c (jit_object_close_impl): Update.
7649
7650 2019-03-15  Tom Tromey  <tom@tromey.com>
7651
7652         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7653         initializations.
7654
7655 2019-03-15  Tom Tromey  <tom@tromey.com>
7656
7657         * objfiles.h (struct objfile_per_bfd_storage)
7658         <demangled_hash_languages>: Now a bitset.
7659         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7660         (lookup_minimal_symbol): Update.
7661
7662 2019-03-15  Tom Tromey  <tom@tromey.com>
7663
7664         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7665         Don't return the symbol.
7666         * coffread.c (record_minimal_symbol): Use record_full.
7667
7668 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7669
7670         The MS-Windows port of ncurses fails to switch to a color pair if
7671         one or both of the colors are the implicit default colors.  This
7672         change records the default colors when TUI is initialized, and
7673         then specifies them explicitly when a color pair uses the default
7674         colors.  This allows color styling in TUI mode on MS-Windows.
7675
7676         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7677         ncurses_norm_attr.
7678         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7679         colors in ncurses_norm_attr.
7680         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7681         "none", replace it with the default color recorded in
7682         ncurses_norm_attr.
7683
7684 2019-03-14  Tom Tromey  <tromey@adacore.com>
7685
7686         * source-cache.h (class source_cache) <get_source_lines>: Return
7687         std::string.
7688         * source-cache.c (source_cache::extract_lines): Handle case where
7689         first_pos==npos.  Return std::string.
7690         (source_cache::get_source_lines): Update.
7691
7692 2019-03-14  Tom Tromey  <tromey@adacore.com>
7693
7694         * NEWS: Add item for "style sources" commands.
7695         * source-cache.c (source_cache::get_source_lines): Check
7696         source_styling.
7697         * cli/cli-style.c (source_styling): New global.
7698         (_initialize_cli_style): Add "style sources" commands.
7699         (show_style_sources): New function.
7700         * cli/cli-style.h (source_styling): Declare.
7701
7702 2019-03-14  Pedro Alves  <palves@redhat.com>
7703             Tom Tromey  <tromey@adacore.com>
7704
7705         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7706         * tui/tui-winsource.c (tui_refill_source_window): New function,
7707         from...
7708         (tui_horizontal_source_scroll): ... here.  Move some logic.
7709         * cli/cli-style.c (set_style_enabled): Notify new observable.
7710         * tui/tui-hooks.c (tui_redisplay_source): New function.
7711         (tui_attach_detach_observers): Attach or detach
7712         tui_redisplay_source.
7713         * observable.h (source_styling_changed): New observable.
7714         * observable.c: Define source_styling_changed observable.
7715
7716 2019-03-13  Tom Tromey  <tromey@adacore.com>
7717
7718         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7719         (i386_gnu_nat_target::store_registers): Update.
7720         * target-debug.h (target_debug_print_std_string): New macro.
7721         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7722         * windows-tdep.c (display_one_tib): Update.
7723         * tui/tui-stack.c (tui_make_status_line): Update.
7724         * top.c (print_inferior_quit_action): Update.
7725         * thread.c (thr_try_catch_cmd): Update.
7726         (add_thread_with_info): Update.
7727         (thread_target_id_str): Update.
7728         (thr_try_catch_cmd): Update.
7729         (thread_command): Update.
7730         (thread_find_command): Update.
7731         * record-btrace.c (record_btrace_target::info_record)
7732         (record_btrace_resume_thread, record_btrace_target::resume)
7733         (record_btrace_cancel_resume, record_btrace_step_thread)
7734         (record_btrace_target::wait, record_btrace_target::wait)
7735         (record_btrace_target::wait, record_btrace_target::stop): Update.
7736         * progspace.c (print_program_space): Update.
7737         * process-stratum-target.c
7738         (process_stratum_target::thread_address_space): Update.
7739         * linux-fork.c (linux_fork_mourn_inferior)
7740         (detach_checkpoint_command, info_checkpoints_command)
7741         (linux_fork_context): Update.
7742         (linux_fork_detach): Update.
7743         (class scoped_switch_fork_info): Update.
7744         (delete_checkpoint_command): Update.
7745         * infrun.c (follow_fork_inferior): Update.
7746         (follow_fork_inferior): Update.
7747         (proceed_after_vfork_done): Update.
7748         (handle_vfork_child_exec_or_exit): Update.
7749         (follow_exec): Update.
7750         (displaced_step_prepare_throw): Update.
7751         (displaced_step_restore): Update.
7752         (start_step_over): Update.
7753         (resume_1): Update.
7754         (clear_proceed_status_thread): Update.
7755         (proceed): Update.
7756         (print_target_wait_results): Update.
7757         (do_target_wait): Update.
7758         (context_switch): Update.
7759         (stop_all_threads): Update.
7760         (restart_threads): Update.
7761         (finish_step_over): Update.
7762         (handle_signal_stop): Update.
7763         (switch_back_to_stepped_thread): Update.
7764         (keep_going_pass_signal): Update.
7765         (print_exited_reason): Update.
7766         (normal_stop): Update.
7767         * inferior.c (inferior_pid_to_str): Change return type.
7768         (print_selected_inferior): Update.
7769         (add_inferior): Update.
7770         (detach_inferior): Update.
7771         * dummy-frame.c (fprint_dummy_frames): Update.
7772         * dcache.c (dcache_info_1): Update.
7773         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7774         (btrace_fetch, btrace_clear): Update.
7775         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7776         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7777         type.
7778         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7779         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7780         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7781         * gdbarch.c, gdbarch.h: Rebuild.
7782         * gdbarch.sh (core_pid_to_str): Change return type.
7783         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7784         return type.
7785         (windows_nat_target::pid_to_str): Change return type.
7786         (windows_delete_thread): Update.
7787         (windows_nat_target::attach): Update.
7788         (windows_nat_target::files_info): Update.
7789         * target-delegates.c: Rebuild.
7790         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7791         return type.
7792         (sol_thread_target::pid_to_str): Change return type.
7793         * remote.c (class remote_target) <pid_to_str>: Change return
7794         type.
7795         (remote_target::pid_to_str): Change return type.
7796         (extended_remote_target::attach, remote_target::remote_stop_ns)
7797         (remote_target::remote_notif_remove_queued_reply)
7798         (remote_target::push_stop_reply, remote_target::disable_btrace):
7799         Update.
7800         (extended_remote_target::attach): Update.
7801         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7802         type.
7803         (gdbsim_target::pid_to_str): Change return type.
7804         * ravenscar-thread.c (struct ravenscar_thread_target)
7805         <pid_to_str>: Change return type.
7806         (ravenscar_thread_target::pid_to_str): Change return type.
7807         * procfs.c (class procfs_target) <pid_to_str>: Change return
7808         type.
7809         (procfs_target::pid_to_str): Change return type.
7810         (procfs_target::attach): Update.
7811         (procfs_target::detach): Update.
7812         (procfs_target::fetch_registers): Update.
7813         (procfs_target::store_registers): Update.
7814         (procfs_target::wait): Update.
7815         (procfs_target::files_info): Update.
7816         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7817         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7818         return type.
7819         (nto_procfs_target::pid_to_str): Change return type.
7820         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7821         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7822         return type.
7823         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7824         (exit_lwp): Update.
7825         (attach_proc_task_lwp_callback, get_detach_signal)
7826         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7827         (linux_nat_target::resume, wait_lwp, stop_callback)
7828         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7829         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7830         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7831         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7832         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7833         type.
7834         (inf_ptrace_target::attach): Update.
7835         (inf_ptrace_target::files_info): Update.
7836         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7837         type.
7838         (go32_nat_target::pid_to_str): Change return type.
7839         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7840         (gnu_nat_target::wait): Update.
7841         (gnu_nat_target::wait): Update.
7842         (gnu_nat_target::resume): Update.
7843         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7844         (fbsd_nat_target::wait): Update.
7845         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7846         type.
7847         (darwin_nat_target::attach): Update.
7848         * corelow.c (class core_target) <pid_to_str>: Change return type.
7849         (core_target::pid_to_str): Change return type.
7850         * target.c (normal_pid_to_str): Change return type.
7851         (default_pid_to_str): Likewise.
7852         (target_pid_to_str): Change return type.
7853         (target_translate_tls_address): Update.
7854         (target_announce_detach): Update.
7855         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7856         return type.
7857         (bsd_uthread_target::pid_to_str): Change return type.
7858         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7859         type.
7860         (bsd_kvm_target::pid_to_str): Change return type.
7861         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7862         return type.
7863         (aix_thread_target::pid_to_str): Change return type.
7864         * target.h (struct target_ops) <pid_to_str>: Change return type.
7865         (target_pid_to_str, normal_pid_to_str): Likewise.
7866         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7867         type.
7868         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7869         type.
7870         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7871         return type.
7872         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7873         type.
7874         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7875         type.
7876         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7877         return type.
7878
7879 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7880
7881         * NEWS: Mention that the new default MI version is 3.  Mention
7882         changes to the output of commands and events that deal with
7883         multi-location breakpoints.
7884         * breakpoint.c: Include "mi/mi-out.h".
7885         (print_one_breakpoint): Change output syntax if using MI version
7886         >= 3.
7887         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7888         New.
7889         (mi_multi_location_breakpoint_output_fixed): New.
7890         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7891         (mi_cmd_fix_multi_location_breakpoint_output): New.
7892         (mi_multi_location_breakpoint_output_fixed): New.
7893         * mi/mi-cmds.c (mi_cmds): Register command
7894         -fix-multi-location-breakpoint-output.
7895         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7896         interpreter "mi".
7897
7898 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7899
7900         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7901         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7902         instantiate mi_ui_out based on interpreter name.
7903         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7904         * mi/mi-main.c (mi_load_progress): Likewise.
7905
7906 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7907
7908         * NEWS: Combine separate "New targets" sections for 8.3.
7909
7910 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7911
7912         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7913         (ppcfbsd_init_abi): Install gdbarch
7914         "fetch_tls_load_module_address" and "get_thread_local_address"
7915         methods.
7916
7917 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7918
7919         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7920         (riscv_fbsd_init_abi): Install gdbarch
7921         "fetch_tls_load_module_address" and "get_thread_local_address"
7922         methods.
7923
7924 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7925
7926         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7927         (i386fbsd_init_abi): Install gdbarch
7928         "fetch_tls_load_module_address" and "get_thread_local_address"
7929         methods.
7930
7931 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7932
7933         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7934         (amd64fbsd_init_abi): Install gdbarch
7935         "fetch_tls_load_module_address" and "get_thread_local_address"
7936         methods.
7937
7938 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7939
7940         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7941         (struct fbsd_pspace_data): New type.
7942         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7943         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7944         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7945         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7946         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7947
7948 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7949
7950         * gdbtypes.c (lookup_struct_elt): New function.
7951         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7952         * gdbtypes.h (struct struct_elt): New type.
7953         (lookup_struct_elt): New prototype.
7954
7955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7956
7957         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7958         remove disabled code block.
7959
7960 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7961
7962         * gdbarch.sh (get_thread_local_address): New method.
7963         * gdbarch.h, gdbarch.c: Regenerate.
7964         * target.c (target_translate_tls_address): Use
7965         gdbarch_get_thread_local_address if present instead of
7966         target::get_thread_local_address.
7967
7968 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7969
7970         * target.h (target::get_thread_local_address): Update comment.
7971
7972 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7973
7974         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7975         objfile->separate_debug_objfile_backlink if not NULL.
7976
7977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7978
7979         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7980         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7981         (amd64bsd_store_inferior_registers): Likewise.
7982         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7983         Enable segment base registers.
7984         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7985         PT_GETFSBASE and PT_GETGSBASE.
7986         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7987         PT_SETGSBASE.
7988         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7989         segment base registers.
7990         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7991
7992 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7993
7994         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7995         Update calls to i386_target_description to add 'segments'
7996         parameter.
7997         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7998         add segment base registers.
7999         * arch/i386.c (i386_create_target_description): Add 'segments'
8000         parameter to enable segment base registers.
8001         * arch/i386.h (i386_create_target_description): Likewise.
8002         * features/i386/32bit-segments.xml: New file.
8003         * features/i386/32bit-segments.c: Generate.
8004         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8005         call to i386_target_description to add 'segments' parameter.
8006         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8007         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8008         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8009         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8010         if feature is present.
8011         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8012         Add 'segments' parameter to call to i386_target_description.
8013         (i386_target_description): Add 'segments' parameter to enable
8014         segment base registers.
8015         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8016         to call to i386_target_description.
8017         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8018         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8019         Define I386_NUM_REGS.
8020         (i386_target_description): Add 'segments' parameter to enable
8021         segment base registers.
8022
8023 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8024
8025         PR/24325
8026         * source-cache.c: #undef open and close, to avoid unresolved
8027         externals during linking.
8028
8029 2019-03-12  Tom Tromey  <tromey@adacore.com>
8030
8031         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8032         const.  Add initializers.
8033         (_initialize_remote): Don't initialize ptid globals.
8034
8035 2019-03-12  Pedro Alves  <palves@redhat.com>
8036
8037         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8038
8039 2019-03-12  Pedro Alves  <palves@redhat.com>
8040
8041         * cp-name-parser.y (main): Remove unused 'len' variable.
8042
8043 2019-03-12  Tom Tromey  <tromey@adacore.com>
8044
8045         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8046         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8047
8048 2019-03-12  Tom Tromey  <tromey@adacore.com>
8049
8050         * linux-nat.c (iterate_over_lwps): Update.
8051         (stop_callback): Remove parameter.
8052         (stop_wait_callback, detach_callback, resume_set_callback)
8053         (select_singlestep_lwp_callback, set_ignore_sigint)
8054         (status_callback, resumed_callback, resume_clear_callback)
8055         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8056         data parameter.
8057         (linux_nat_target::detach, linux_nat_target::resume)
8058         (linux_stop_and_wait_all_lwps, select_event_lwp)
8059         (linux_nat_filter_event, linux_nat_wait_1)
8060         (linux_nat_target::kill, linux_nat_target::stop)
8061         (linux_nat_target::stop): Update.
8062         (linux_nat_resume_callback): Change type.
8063         (resume_stopped_resumed_lwps, count_events_callback)
8064         (select_event_lwp_callback): Likewise.
8065         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8066         * arm-linux-nat.c (struct update_registers_data): Remove.
8067         (update_registers_callback): Change type.
8068         (arm_linux_insert_hw_breakpoint1): Update.
8069         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8070         parameter.
8071         (x86_linux_dr_set_addr): Update.
8072         (x86_linux_dr_set_control): Update.
8073         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8074         (iterate_over_lwps): Use gdb::function_view.
8075         * nat/aarch64-linux-hw-point.c (struct
8076         aarch64_dr_update_callback_param): Remove.
8077         (debug_reg_change_callback): Change type.
8078         (aarch64_notify_debug_reg_change): Update.
8079         * s390-linux-nat.c (s390_refresh_per_info): Update.
8080
8081 2019-03-11  Tom Tromey  <tromey@adacore.com>
8082
8083         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8084         redundant assignment to "this_cu".
8085
8086 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8087
8088         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8089
8090 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8091
8092         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8093         from...
8094         (rank_one_type): ... this.
8095
8096 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8097
8098         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8099         from...
8100         (rank_one_type): ... this.
8101
8102 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8103
8104         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8105         from...
8106         (rank_one_type): ... this.
8107
8108 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8109
8110         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8111         from...
8112         (rank_one_type): ... this.
8113
8114 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8115
8116         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8117         from...
8118         (rank_one_type): ... this.
8119
8120 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8121
8122         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8123         from...
8124         (rank_one_type): ... this.
8125
8126 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8127
8128         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8129         from...
8130         (rank_one_type): ... this.
8131
8132 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8133
8134         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8135         from...
8136         (rank_one_type): ... this.
8137
8138 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8139
8140         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8141         from...
8142         (rank_one_type): ... this.
8143
8144 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8145
8146         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8147         from...
8148         (rank_one_type): ... this.
8149
8150 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8151
8152         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8153         from...
8154         (rank_one_type): ... this.
8155
8156 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8157
8158         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8159         from...
8160         (rank_one_type): ... this.
8161
8162 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8163
8164         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8165         inferior-events' shows the example events.
8166
8167 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8168
8169         Support styling on native MS-Windows console
8170
8171         PR/24315
8172         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8173         on MS-Windows if $TERM is not defined.
8174
8175         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8176
8177         * posix-hdep.c (gdb_console_fputs):
8178         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8179         functions.
8180         * ui-file.h (gdb_console_fputs): Add prototype.
8181
8182         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8183         back to fputs only if the former returns zero.
8184
8185 2019-03-07  Tom Tromey  <tom@tromey.com>
8186
8187         * symmisc.c (print_symbol_bcache_statistics): Update.
8188         (print_objfile_statistics): Update.
8189         * symfile.c (allocate_symtab): Update.
8190         * stabsread.c: Don't include bcache.h.
8191         * psymtab.h (struct psymbol_bcache): Don't declare.
8192         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8193         (psymbol_bcache_init, psymbol_bcache_free)
8194         (psymbol_bcache_get_bcache): Don't declare.
8195         * psymtab.c (struct psymbol_bcache): Remove.
8196         (psymtab_storage::psymtab_storage): Update.
8197         (psymtab_storage::~psymtab_storage): Update.
8198         (psymbol_bcache_init, psymbol_bcache_free)
8199         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8200         (add_psymbol_to_bcache): Update.
8201         (allocate_psymtab): Update.
8202         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8203         macro_cache>: No longer pointers.
8204         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8205         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8206         * macrotab.c (macro_bcache): Update.
8207         * macroexp.c: Don't include bcache.h.
8208         * gdbtypes.c (check_types_worklist): Update.
8209         (types_deeply_equal): Remove TRY/CATCH.  Update.
8210         * elfread.c (elf_symtab_read): Update.
8211         * dwarf2read.c: Don't include bcache.h.
8212         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8213         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8214         (print_bcache_statistics, bcache_memory_used): Don't declare.
8215         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8216         methods.  Rename all data members.
8217         * bcache.c (struct bcache): Move to bcache.h.
8218         (bcache::expand_hash_table): Rename from expand_hash_table.
8219         (bcache): Remove.
8220         (bcache::insert): Rename from bcache_full.
8221         (bcache::compare): Rename from bcache_compare.
8222         (bcache_xmalloc): Remove.
8223         (bcache::~bcache): Rename from bcache_xfree.
8224         (bcache::print_statistics): Rename from print_bcache_statistics.
8225         (bcache::memory_used): Rename from bcache_memory_used.
8226
8227 2019-03-07  Pedro Alves  <palves@redhat.com>
8228
8229         * infrun.c (normal_stop): Also check for
8230         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8231
8232 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8233
8234         * f-lang.c (value_from_host_double): Moved to...
8235         * value.c (value_from_host_double): ...here.
8236         * value.h (value_from_host_double): Declare.
8237         * guile/scm-math.c (vlscm_convert_typed_number): Use
8238         value_from_host_double.
8239         (vlscm_convert_number): Likewise.
8240         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8241         * python/py-value.c (convert_value_from_python): Likewise.
8242
8243 2019-03-06  Tom Tromey  <tom@tromey.com>
8244
8245         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8246
8247 2019-03-06  Tom Tromey  <tom@tromey.com>
8248
8249         * utils.h (free_current_contents): Don't declare.
8250         * utils.c (free_current_contents): Remove.
8251
8252 2019-03-06  Tom Tromey  <tom@tromey.com>
8253
8254         * top.c (quit_force): Update.
8255         * main.c (captured_command_loop): Update.
8256         * common/new-op.c (operator new): Update.
8257         * common/common-exceptions.c (struct catcher)
8258         <save_cleanup_chain>: Remove member.
8259         (exceptions_state_mc_init): Update.
8260         (exception_try_scope_entry): Return nullptr.
8261         (exception_try_scope_exit, exception_rethrow)
8262         (throw_exception_sjlj, throw_exception_cxx): Update.
8263         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8264         (all_cleanups, do_cleanups, discard_cleanups)
8265         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8266         (restore_cleanups, restore_final_cleanups): Don't declare.
8267         (do_final_cleanups): Remove parameter.
8268         * common/cleanups.c (cleanup_chain, make_cleanup)
8269         (make_cleanup_dtor, all_cleanups, do_cleanups)
8270         (discard_my_cleanups, discard_cleanups)
8271         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8272         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8273         (null_cleanup): Remove.
8274         (do_final_cleanups): Remove parameter.
8275
8276 2019-03-06  Tom Tromey  <tom@tromey.com>
8277
8278         * remote.c (remote_target::remote_parse_stop_reply): Use
8279         unique_xmalloc_ptr.
8280
8281 2019-03-06  Tom Tromey  <tom@tromey.com>
8282
8283         * stabsread.c (struct stabs_field_info): Rename from field_info.
8284         <list, fnlist>: Add initializers.
8285         <obstack>: New member.
8286         (read_member_functions, read_struct_fields, read_baseclasses):
8287         Allocate on obstack.  Don't use cleanups.
8288         (read_one_struct_field, read_member_functions, read_struct_fields)
8289         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8290         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8291         (read_struct_type): Update.
8292
8293 2019-03-06  Tom Tromey  <tom@tromey.com>
8294
8295         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8296         * common/filestuff.h (make_cleanup_close): Don't declare.
8297         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8298         Remove.
8299
8300 2019-03-06  Tom Tromey  <tom@tromey.com>
8301
8302         * solib-aix.c: Use make_scope_exit.
8303
8304 2019-03-06  Tom Tromey  <tom@tromey.com>
8305
8306         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8307         Use make_scope_exit.
8308
8309 2019-03-06  Tom Tromey  <tom@tromey.com>
8310
8311         * solib-svr4.c (disable_probes_interface): Remove parameter.
8312         (svr4_handle_solib_event): Use make_scope_exit.
8313
8314 2019-03-06  Tom Tromey  <tom@tromey.com>
8315
8316         * remote.c (struct stop_reply_deleter): Remove.
8317         (stop_reply_up): Update.
8318         (struct stop_reply): Derive from notif_event.  Don't typedef.
8319         <regcache>: Now a std::vector.
8320         (stop_reply_xfree): Remove.
8321         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8322         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8323         (remote_target::discard_pending_stop_replies): Use delete.
8324         (remote_target::remote_parse_stop_reply): Update.
8325         (remote_target::process_stop_reply): Update.
8326         * remote-notif.h (struct notif_event): Add virtual destructor.
8327         Remove "dtr" member.
8328         (struct notif_client) <alloc_event>: Return a unique_ptr.
8329         (notif_event_xfree): Don't declare.
8330         (notif_event_up): New typedef.
8331         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8332         (notif_event_xfree, do_notif_event_xfree): Remove.
8333         (remote_notif_state_xfree): Update.
8334
8335 2019-03-06  Tom Tromey  <tom@tromey.com>
8336
8337         * infrun.c (displaced_step_clear_cleanup): Now a
8338         forward_scope_exit type.
8339         (displaced_step_prepare_throw): Update.
8340         (displaced_step_fixup): Update.
8341
8342 2019-03-06  Tom Tromey  <tom@tromey.com>
8343
8344         * inferior.h (class inferior): Update comment.
8345         * gdbthread.h (class thread_info): Update comment.
8346
8347 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8348             Tom Tromey  <tom@tromey.com>
8349
8350         * stabsread.h (struct stab_section_list): Remove.
8351         (coffstab_build_psymtabs): Update.
8352         * dbxread.c (symbuf_sections): Now a std::vector.
8353         (sect_idx): New global.
8354         (fill_symbuf): Update.
8355         (coffstab_build_psymtabs): Change type of stabsects parameter.
8356         Update.
8357         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8358         std::vector.
8359         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8360         (coff_locate_sections): Update.
8361         (coff_symfile_read): Remove cleanups.  Update.
8362         (init_stringtab): Add storage parameter.
8363         (free_stringtab, free_stringtab_cleanup): Remove.
8364         (init_lineno): Add storage parameter.
8365         (free_linetab, free_linetab_cleanup): Remove.
8366
8367 2019-03-06  Pedro Alves  <palves@redhat.com>
8368
8369         * linux-fork.c (fork_info::clobber_regs): Delete.
8370         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8371         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8372         comment.  Adjust.
8373         (scoped_switch_fork_info::scoped_switch_fork_info)
8374         (checkpoint_command, linux_fork_context): Adjust
8375         fork_save_infrun_state calls.
8376
8377 2019-03-06  Pedro Alves  <palves@redhat.com>
8378
8379         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8380         (inf_has_multiple_threads): Return 'bool' and rewrite using
8381         inferior_info::threads().
8382
8383 2019-03-06  Pedro Alves  <palves@redhat.com>
8384
8385         * linux-fork.c: Include <list>.
8386         (fork_list): Now a std::list instance.
8387         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8388         (forks_exist_p, find_last_fork): Adjust.
8389         (new_fork): Delete.
8390         (one_fork_p): New.
8391         (add_fork): Adjust.
8392         (free_fork): Delete, folded into fork_info::~fork_info().
8393         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8394         Adjust.
8395         (init_fork_list): Delete.
8396         (linux_fork_killall, linux_fork_mourn_inferior)
8397         (linux_fork_detach, info_checkpoints_command): Adjust.
8398         (_initialize_linux_fork): No longer call init_fork_list.
8399
8400 2019-03-06  Pedro Alves  <palves@redhat.com>
8401
8402         * linux-fork.c (new_fork): New, split out of ...
8403         (add_fork): ... this.  Return void.  Move "first fork" special
8404         case from here, to ...
8405         (checkpoint_command): ... here.
8406         * linux-linux.h (add_fork): Return void.
8407
8408 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8409
8410         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8411
8412 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8413             Chris January  <chris.january@arm.com>
8414             David Lecomber  <david.lecomber@arm.com>
8415
8416         * f-exp.y: New token, UNOP_INTRINSIC.
8417         (exp): New pattern using UNOP_INTRINSIC token.
8418         (f77_keywords): Add 'abs' keyword.
8419         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8420         (value_from_host_double): New function.
8421         (evaluate_subexp_f): Support UNOP_ABS.
8422
8423 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8424
8425         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8426         types.
8427
8428 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8429
8430         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8431         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8432         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8433
8434 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8435
8436         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8437
8438 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8439             Chris January  <chris.january@arm.com>
8440
8441         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8442         * f-exp.y: Define 'KIND' token.
8443         (exp): New pattern for KIND expressions.
8444         (ptype): Handle types with a kind extension.
8445         (direct_abs_decl): Extend to spot kind extensions.
8446         (f77_keywords): Add 'kind' to the list.
8447         (push_kind_type): New function.
8448         (convert_to_kind_type): New function.
8449         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8450         * parse.c (operator_length_standard): Likewise.
8451         * parser-defs.h (enum type_pieces): Add tp_kind.
8452         * std-operator.def: Add UNOP_KIND.
8453
8454 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8455
8456         * f-exp.y (f_parse): Set yydebug.
8457
8458 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8459
8460         * f-lang.c (evaluate_subexp_f): New function.
8461         (exp_descriptor_f): New global.
8462         (f_language_defn): Use exp_descriptor_f instead of
8463         exp_descriptor_standard.
8464
8465 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8466
8467         * f-exp.y (struct token): Add comments.
8468         (dot_ops): Remove uppercase versions and the end marker.
8469         (f77_keywords): Likewise.
8470         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8471         entries in the dot_ops array are case insensitive, and use
8472         strncasecmp to compare strings.  Also some whitespace cleanup in
8473         this area.  Similar for the f77_keywords array, except entries in
8474         this list might be case sensitive.
8475
8476 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8477
8478         * f-exp.y (struct f77_boolean_val): Add comments.
8479         (boolean_values): Remove uppercase versions, and end marker.
8480         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8481         and use strncasecmp to achieve case insensitivity.  Additionally,
8482         perform whitespace cleanup around this code.
8483
8484 2019-03-06  Tom Tromey  <tromey@adacore.com>
8485
8486         * remote-sim.c (gdbsim_target_open): Use result of
8487         gdb_argv::release.
8488
8489 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8490         Dirk Schubert  <dirk.schubert@arm.com>
8491         Chris January  <chris.january@arm.com>
8492
8493         * eval.c (evaluate_subexp_standard): Call Fortran argument
8494         wrapping logic.
8495         * f-lang.c (struct value): A value which can be passed into a
8496         Fortran function call.
8497         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8498         where appropriate.
8499         (struct type): Value ready for a Fortran function call.
8500         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8501         is needed.
8502         * f-lang.h (fortran_argument_convert): Declaration.
8503         (fortran_preserve_arg_pointer): Declaration.
8504         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8505
8506 2019-03-05  Tom Tromey  <tromey@adacore.com>
8507
8508         * python/py-prettyprint.c (print_string_repr): Remove #if.
8509         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8510
8511 2019-03-05  Tom Tromey  <tromey@adacore.com>
8512
8513         * target.c (the_dummy_target): Move later.  Change type to
8514         "dummy_target".
8515         (initialize_targets): Don't initialize the_dummy_target.
8516
8517 2019-03-05  Tom Tromey  <tromey@adacore.com>
8518
8519         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8520         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8521
8522 2019-03-05  Tom Tromey  <tromey@adacore.com>
8523
8524         * windows-nat.c (windows_nat_target::attach)
8525         (windows_nat_target::detach): Don't call gdb_flush.
8526         * valprint.c (generic_val_print, val_print, val_print_string):
8527         Don't call gdb_flush.
8528         * utils.c (defaulted_query): Don't call gdb_flush.
8529         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8530         * target.c (target_announce_detach): Don't call gdb_flush.
8531         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8532         * remote.c (extended_remote_target::attach): Don't call
8533         gdb_flush.
8534         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8535         * printcmd.c (do_examine): Don't call gdb_flush.
8536         (info_display_command): Don't call gdb_flush.
8537         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8538         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8539         * memattr.c (info_mem_command): Don't call gdb_flush.
8540         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8541         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8542         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8543         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8544         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8545         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8546         (gnu_nat_target::detach): Don't call gdb_flush.
8547         * f-valprint.c (f_val_print): Don't call gdb_flush.
8548         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8549         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8550         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8551         gdb_flush.
8552         * c-valprint.c (c_val_print): Don't call gdb_flush.
8553         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8554
8555 2019-03-05  Tom Tromey  <tromey@adacore.com>
8556
8557         * varobj.c (update_dynamic_varobj_children): Update.
8558         (install_default_visualizer): Use reset, not release.
8559         * value.c (set_internalvar): Update.
8560         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8561         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8562         ATTRIBUTE_UNUSED_RESULT.
8563
8564 2019-03-05  Tom Tromey  <tromey@adacore.com>
8565
8566         * remote.c (class scoped_remote_fd) <release>: Add
8567         ATTRIBUTE_UNUSED_RESULT.
8568
8569 2019-03-05  Tom Tromey  <tromey@adacore.com>
8570
8571         * macroexp.c (struct macro_buffer) <release>: Add
8572         ATTRIBUTE_UNUSED_RESULT.
8573
8574 2019-03-05  Tom Tromey  <tromey@adacore.com>
8575
8576         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8577         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8578         ATTRIBUTE_UNUSED_RESULT.
8579
8580 2019-03-05  Tom Tromey  <tromey@adacore.com>
8581
8582         * common/scoped_fd.h (class scoped_fd) <release>: Add
8583         ATTRIBUTE_UNUSED_RESULT.
8584
8585 2019-03-05  Tom Tromey  <tromey@adacore.com>
8586
8587         * parser-defs.h (struct parser_state) <release>: Add
8588         ATTRIBUTE_UNUSED_RESULT.
8589
8590 2019-03-05  Tom Tromey  <tromey@adacore.com>
8591
8592         * utils.h (class gdb_argv) <release>: Add
8593         ATTRIBUTE_UNUSED_RESULT.
8594         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8595
8596 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8597
8598         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8599         for-loop range, to avoid compiler warnings.
8600
8601         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8602         avoid compiler warnings about unused variables.
8603
8604         * NEWS: Mention end of support for native debugging on MS-Windows
8605         before XP.
8606
8607         PR gdb/24292
8608         * common/netstuff.c:
8609         * gdbserver/gdbreplay.c
8610         * gdbserver/remote-utils.c:
8611         * ser-tcp.c:
8612         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8613         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8614         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8615         'getaddrinfo' and 'freeaddrinfo' were not available before
8616         Windows XP, and mingw.org's MinGW headers by default define
8617         _WIN32_WINNT to 0x500.
8618
8619 2019-03-01  Gary Benson <gbenson@redhat.com>
8620
8621         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8622
8623 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8624             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8625
8626         PR gdb/8527
8627         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8628         set_sigint_trap, clear_sigint_trap.
8629
8630 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8631
8632         * target.c (target_detach): Clear the regcache and the
8633         frame cache.
8634
8635 2019-02-27  Pedro Alves  <palves@redhat.com>
8636
8637         * utils.c (set_screen_size): When we cap the height/width sizes,
8638         tweak the corresponding command variable to show "unlimited":
8639
8640 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8641             Pedro Alves  <palves@redhat.com>
8642
8643         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8644         before calling rl_set_screen_size.
8645
8646 2019-02-27  Tom Tromey  <tromey@adacore.com>
8647
8648         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8649         define.
8650         * python/py-value.c: Remove Python 2.4 workaround.
8651         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8652         workaround.
8653         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8654         Python 2.4 workaround.
8655         * python/python-internal.h: Remove Python 2.4 comment.
8656         (Py_ssize_t): Don't define.
8657         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8658         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8659         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8660         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8661         * python/python.c (do_start_initialization): Remove Python 2.4
8662         workaround.
8663         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8664         (print_children): Remove Python 2.4 workaround.
8665         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8666         workaround.
8667         (CHARBUFFERPROC_NAME): Remove.
8668         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8669         Python 2.4 workaround.
8670
8671 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8672
8673         * NEWS: Note minimum Python version.
8674
8675 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8676
8677         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8678         code from these functions.  Remove corresponding ifdefs.  Use
8679         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8680         Remove gotos and target of gotos.
8681         (infpy_search_memory): Likewise.
8682
8683 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8684
8685         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8686         (hppa_gdbarch_init): Don't register deleted functions with
8687         gdbarch.
8688
8689 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8690
8691         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8692         (h8300_unwind_sp): Delete.
8693         (h8300_dummy_id): Delete.
8694         (h8300_gdbarch_init): Don't register deleted functions with
8695         gdbarch.
8696
8697 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8698
8699         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8700         (ft32_unwind_pc): Delete.
8701         (ft32_unwind_sp): Delete.
8702         (ft32_gdbarch_init): Don't register deleted functions with
8703         gdbarch.
8704
8705 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8706
8707         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8708         (frv_unwind_pc): Delete.
8709         (frv_unwind_sp): Delete.
8710         (frv_gdbarch_init): Don't register deleted functions with
8711         gdbarch.
8712
8713 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8714
8715         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8716         (riscv_unwind_pc): Delete.
8717         (riscv_unwind_sp): Delete.
8718         (riscv_gdbarch_init): Don't register deleted functions with
8719         gdbarch.
8720
8721 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8722
8723         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8724         (csky_unwind_pc): Delete.
8725         (csky_unwind_sp): Delete.
8726         (csky_gdbarch_init): Don't register deleted functions with
8727         gdbarch.
8728
8729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8730
8731         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8732         (cris_unwind_pc): Delete.
8733         (cris_unwind_sp): Delete.
8734         (cris_gdbarch_init): Don't register deleted functions with
8735         gdbarch.
8736
8737 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8738
8739         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8740         (bfin_unwind_pc): Delete.
8741         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8742
8743 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8744
8745         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8746         (arm_unwind_pc): Delete.
8747         (arm_unwind_sp): Delete.
8748         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8749
8750 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8751
8752         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8753         (arc_unwind_pc): Delete.
8754         (arc_unwind_sp): Delete.
8755         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8756
8757 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8758
8759         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8760         (alpha_unwind_pc): Delete.
8761         (alpha_gdbarch_init): Don't register deleted functions with
8762         gdbarch.
8763
8764 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8765
8766         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8767         (aarch64_unwind_pc): Delete.
8768         (aarch64_unwind_sp): Delete.
8769         (aarch64_gdbarch_init): Don't register deleted functions with
8770         gdbarch.
8771
8772 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8773
8774         * gdbtypes.c (type_align): Don't consider static members when
8775         computing structure alignment.
8776
8777 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8778
8779         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8780         return 0 for other types.
8781         * arch-utils.c (default_type_align): Always return 0.
8782         * gdbarch.h: Regenerate.
8783         * gdbarch.sh (type_align): Extend comment.
8784         * gdbtypes.c (type_align): Add additional comments, always call
8785         gdbarch_type_align before applying the default rules.
8786         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8787         generic code will then apply a suitable default.
8788         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8789         types, return 0 for other types.
8790
8791 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8792
8793         * NEWS: Create a new section for the next release branch.
8794         Rename the section of the current branch, now that it has
8795         been cut.
8796
8797 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8798
8799         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8800         * version.in: Bump version to 8.3.50.DATE-git.
8801
8802 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8803
8804         * aix-thread.c (ptid_cmp): Remove unused variable.
8805         (get_signaled_thread): Likewise.
8806         (store_regs_user_thread): Likewise.
8807         (store_regs_kernel_thread): Likewise.
8808         (fetch_regs_kernel_thread): Remove shadowed variable.
8809
8810 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8811
8812         * features/riscv/32bit-cpu.xml: Add register numbers.
8813         * features/riscv/32bit-fpu.c: Regenerate.
8814         * features/riscv/32bit-fpu.xml: Add register numbers.
8815         * features/riscv/64bit-cpu.xml: Add register numbers.
8816         * features/riscv/64bit-fpu.c: Regenerate.
8817         * features/riscv/64bit-fpu.xml: Add register numbers.
8818
8819 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8820
8821         * NEWS: Mention two argument form of gdb.Value constructor.
8822         * python/py-value.c (convert_buffer_and_type_to_value): New
8823         function.
8824         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8825         Add support for handling an optional second argument.  Call
8826         convert_buffer_and_type_to_value as appropriate.
8827         * python/python-internal.h (Py_buffer_deleter): New struct.
8828         (Py_buffer_up): New typedef.
8829
8830 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8831
8832         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8833         instead of releasing ownership.
8834
8835 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8836
8837         * dwarf2read.c (open_and_init_dwp_file): Call
8838         elf_numsections instead of bfd_count_sections to initialize
8839         dwp_file->num_sections.
8840
8841 2019-02-25  Tom Tromey  <tromey@adacore.com>
8842
8843         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8844
8845 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8846
8847         * gcore.in: Add '--readnever' option when invoking GDB.
8848
8849 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8850
8851         * MAINTAINERS: Update my email address.
8852
8853 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8854
8855         * build-id.c (build_id_to_debug_bfd_1): New function.
8856         (build_id_to_debug_bfd): Look for separate debug file in
8857         sysroot.
8858
8859 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8860
8861         * gdbarch.sh: Update the copyright year range that is placed into
8862         generated files.
8863
8864 2019-02-22  Keith Seitz  <keiths@redhat.com>
8865
8866         PR symtab/23853
8867         * linespec.c (create_sals_line_offset): Search for the default
8868         symtab's filename instead of its fullname.
8869
8870 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8871
8872         * NEWS: Update style defaults.
8873
8874 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8875
8876         * main.c (captured_main_1): Disable styling in batch mode.
8877
8878 2019-02-20  Tom Tromey  <tom@tromey.com>
8879
8880         * symtab.c (symtab_symbol_info): Fix typos.
8881
8882 2019-02-20  Tom Tromey  <tromey@adacore.com>
8883
8884         * findcmd.c (_initialize_mem_search): Use upper case for
8885         metasyntactic variables.
8886
8887 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8888
8889         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8890         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8891
8892 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8893
8894         * top.h (source_file_name): Change to std::string.
8895         * top.c (source_file_name): Likewise.
8896         (command_line_input): Adjust.
8897         * cli/cli-script.c (script_from_file): Adjust.
8898
8899 2019-02-19  Tom Tromey  <tromey@adacore.com>
8900
8901         * ravenscar-thread.c
8902         (ravenscar_thread_target::update_thread_list): Don't call
8903         ada_build_task_list.
8904         * ada-lang.h (ada_build_task_list): Don't declare.
8905         * ada-tasks.c (struct ada_tasks_inferior_data)
8906         <task_list_valid_p>: Now bool.
8907         (read_known_tasks, ada_task_list_changed)
8908         (ada_tasks_invalidate_inferior_data): Update.
8909         (read_known_tasks_array): Return bool.
8910         (read_known_tasks_list): Likewise.
8911         (read_known_tasks): Return void.
8912         (ada_build_task_list): Now static.
8913
8914 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8915
8916         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8917         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8918
8919 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8920
8921         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8922         variant for ada_tasks_pspace_data_handle and
8923         ada_tasks_inferior_data_handle.
8924         (ada_tasks_pspace_data_cleanup): New function.
8925         (ada_tasks_inferior_data_cleanup): New function.
8926
8927 2019-02-17  Tom Tromey  <tom@tromey.com>
8928
8929         * macrotab.h (macro_source_fullname): Return a std::string.
8930         * macrotab.c (macro_include, check_for_redefinition)
8931         (macro_undef, macro_lookup_definition, foreach_macro)
8932         (foreach_macro_in_scope): Update.
8933         (macro_source_fullname): Return a std::string.
8934         * macrocmd.c (show_pp_source_pos): Update.
8935
8936 2019-02-17  Tom Tromey  <tom@tromey.com>
8937
8938         * macrocmd.c (show_pp_source_pos): Style the file names.
8939
8940 2019-02-17  Tom Tromey  <tom@tromey.com>
8941
8942         PR tui/24197:
8943         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8944
8945 2019-02-17  Tom Tromey  <tom@tromey.com>
8946
8947         * ada-lang.c (user_select_syms): Use filtered printing.
8948         * utils.c (wrap_style): New global.
8949         (desired_style): Remove.
8950         (emit_style_escape): Add stream parameter.
8951         (set_output_style, reset_terminal_style, prompt_for_continue):
8952         Update.
8953         (flush_wrap_buffer): Only flush gdb_stdout.
8954         (wrap_here): Set wrap_style.
8955         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8956         treat escape sequences as a character.  Change when wrap buffer is
8957         flushed.
8958         (fputs_styled): Do not set the output style when the default is
8959         requested.
8960         * ui-style.h (struct ui_file_style) <is_default>: New method.
8961         * source.c (print_source_lines_base): Emit escape sequences in one
8962         piece.
8963
8964 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8965
8966         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8967         integers and enumeration types.
8968
8969 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8970
8971         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8972         instead of lookup_symbol_in_language
8973         (do_exact_match): New function.
8974         (ada_get_symbol_name_matcher): Return do_exact_match when
8975         doing a verbatim match.
8976
8977 2019-02-15  Tom Tromey  <tromey@adacore.com>
8978
8979         * ravenscar-thread.c (ravenscar_thread_target::resume)
8980         (ravenscar_thread_target::wait): Special case wildcard requests.
8981
8982 2019-02-15  Tom Tromey  <tromey@adacore.com>
8983
8984         * ravenscar-thread.c (base_ptid): Remove.
8985         (struct ravenscar_thread_target) <close>: New method.
8986         <m_base_ptid>: New member.
8987         <update_inferior_ptid, active_task, task_is_currently_active,
8988         runtime_initialized>: Declare methods.
8989         <ravenscar_thread_target>: Add constructor.
8990         (ravenscar_thread_target::task_is_currently_active)
8991         (ravenscar_thread_target::update_inferior_ptid)
8992         (ravenscar_runtime_initialized): Rename.  Now methods.
8993         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8994         (ravenscar_thread_target::update_thread_list): Update.
8995         (ravenscar_thread_target::active_task): Now method.
8996         (ravenscar_thread_target::store_registers)
8997         (ravenscar_thread_target::prepare_to_store)
8998         (ravenscar_thread_target::prepare_to_store)
8999         (ravenscar_thread_target::mourn_inferior): Update.
9000         (ravenscar_inferior_created): Use "new" to create target.
9001         (ravenscar_thread_target::get_ada_task_ptid): Update.
9002         (_initialize_ravenscar): Don't initialize base_ptid.
9003         (ravenscar_ops): Remove global.
9004
9005 2019-02-15  Tom Tromey  <tromey@adacore.com>
9006
9007         * target.h (push_target): Declare new overload.
9008         * target.c (push_target): New overload, taking an rvalue reference.
9009         * remote.c (remote_target::open_1): Use push_target overload.
9010         * corelow.c (core_target_open): Use push_target overload.
9011
9012 2019-02-15  Tom Tromey  <tromey@adacore.com>
9013
9014         * ravenscar-thread.c (is_ravenscar_task)
9015         (ravenscar_task_is_currently_active): Return bool.
9016         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9017         (_initialize_ravenscar): Remove "(void)".
9018         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9019         Return bool.
9020
9021 2019-02-15  Tom Tromey  <tromey@adacore.com>
9022
9023         * ravenscar-thread.c (ravenscar_runtime_initializer)
9024         (has_ravenscar_runtime, get_running_thread_id)
9025         (ravenscar_thread_target::resume): Fix indentation.
9026
9027 2019-02-15  Tom Tromey  <tromey@adacore.com>
9028
9029         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9030         from ravenscar_arch_ops.
9031         (sparc_ravenscar_ops::fetch_registers)
9032         (sparc_ravenscar_ops::store_registers): Now methods.
9033         (sparc_ravenscar_prepare_to_store): Remove.
9034         (sparc_ravenscar_ops): Redefine.
9035         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9036         methods and destructor.  Remove members.
9037         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9038         (ravenscar_thread_target::store_registers)
9039         (ravenscar_thread_target::prepare_to_store): Update.
9040         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9041         Remove.
9042         (struct ppc_ravenscar_powerpc_ops): Derive from
9043         ravenscar_arch_ops.
9044         (ppc_ravenscar_powerpc_ops::fetch_registers)
9045         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9046         (ppc_ravenscar_powerpc_ops): Redefine.
9047         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9048         (ppc_ravenscar_e500_ops::fetch_registers)
9049         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9050         (ppc_ravenscar_e500_ops): Redefine.
9051         * aarch64-ravenscar-thread.c
9052         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9053         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9054         (aarch64_ravenscar_fetch_registers)
9055         (aarch64_ravenscar_store_registers): Now methods.
9056         (aarch64_ravenscar_ops): Redefine.
9057
9058 2019-02-15  Tom Tromey  <tromey@adacore.com>
9059
9060         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9061         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9062         (ravenscar_thread_target::stopped_by_watchpoint)
9063         (ravenscar_thread_target::stopped_data_address)
9064         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9065
9066 2019-02-15  Tom Tromey  <tromey@adacore.com>
9067
9068         * ravenscar-thread.c: Fix some typos.
9069
9070 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9071             Tom Tromey  <tromey@adacore.com>
9072
9073         * ada-lang.c (ada_exception_sal): Change addr_string to a
9074         std::string.
9075         (create_ada_exception_catchpoint): Update.
9076
9077 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9078             Tom Tromey  <tromey@adacore.com>
9079
9080         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9081         (bp_location_ops): Remove.
9082         (base_breakpoint_allocate_location): Update.
9083         (free_bp_location): Update.
9084         * ada-lang.c (class ada_catchpoint_location)
9085         <ada_catchpoint_location>: Remove ops parameter.
9086         (ada_catchpoint_location_dtor): Remove.
9087         (ada_catchpoint_location_ops): Remove.
9088         (allocate_location_exception): Update.
9089         * breakpoint.h (struct bp_location_ops): Remove.
9090         (class bp_location) <bp_location>: Remove bp_location_ops
9091         parameter.
9092         <~bp_location>: Add destructor.
9093         <ops>: Remove.
9094
9095 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9096             Pedro Alves  <palves@redhat.com>
9097
9098         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9099         'PATH_MAX'.
9100
9101 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9102             Samuel Thibault  <samuel.thibault@gnu.org>
9103             Thomas Schwinge  <thomas@codesourcery.com>
9104
9105         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9106         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9107
9108 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9109
9110         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9111         (check_empty): Use "const char *".
9112
9113         * gnu-nat.c (gnu_nat_target::detach): Instead of
9114         'detach_inferior (pid)' call
9115         'detach_inferior (find_inferior_pid (pid))'.
9116
9117         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9118         'nat/fork-inferior.o'.
9119         * gnu-nat.c: #include "nat/fork-inferior.h".
9120
9121         * gnu-nat.c (gnu_nat_target::detach): Instead of
9122         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9123         * gnu-nat.h: #include "inf-child.h".
9124         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9125         'i386_gnu_nat_target::fetch_registers'.
9126         (gnu_store_registers): Rename/move to
9127         'i386_gnu_nat_target::store_registers'.
9128
9129         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9130         * gnu-nat.h (mach_thread_info): New function.
9131         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9132
9133         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9134
9135 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9136
9137         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9138
9139 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9140
9141         * windows-nat.c (windows_add_thread): Add new parameter
9142         "main_thread_p" with default value set to false.  Update
9143         function documentation as well as all callers.
9144         (windows_delete_thread): Likewise.
9145         (fake_create_process): Update call to windows_add_thread.
9146         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9147         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9148         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9149         call to windows_delete_thread.
9150
9151 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9152
9153         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9154
9155 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9156
9157         * symfile.c (find_separate_debug_file): Use canonical path of
9158         sysroot with child_path instead of gdb_sysroot if it is valid.
9159
9160 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9161
9162         * symfile.c (find_separate_debug_file): Use child_path to
9163         determine if an object file is under a sysroot.
9164
9165 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9166
9167         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9168         unittests/child-path-selftests.c.
9169         * common/pathstuff.c (child_path): New function.
9170         * common/pathstuff.h (child_path): New prototype.
9171         * unittests/child-path-selftests.c: New file.
9172
9173 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9174
9175         * symfile.c (find_separate_debug_file): Look for separate debug
9176         files in debug directories under the sysroot.
9177
9178 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9179
9180         * symtab.h (struct minimal_symbol data_p): New const method.
9181         (struct minimal_symbol text_p): Likewise.
9182         * symtab.c (output_source_filename): Use file name style
9183         to print file name.
9184         (print_symbol_info): Likewise.
9185         (print_msymbol_info): Use address style to print addresses.
9186         Use function name style to print executable text symbols.
9187         (expand_symtab_containing_pc): Use data_p.
9188         (find_pc_sect_compunit_symtab): Likewise.
9189
9190 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9191
9192         * breakpoint.c (describe_other_breakpoints): Use address style
9193         to print addresses.
9194         (say_where): Likewise.
9195
9196 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9197
9198         * ada-typeprint.c (print_func_type): Print function name
9199         style to print function name.
9200         * c-typeprint.c (c_print_type_1): Likewise.
9201
9202 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9203
9204         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9205         for execve.
9206
9207 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9208
9209         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9210         type_stack.
9211
9212 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9213
9214         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9215         TYPE_CODE_REF types.
9216
9217 2019-02-08  Jim Wilson  <jimw@sifive.com>
9218
9219         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9220         (riscv_linux_fregset): New.
9221         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9222
9223 2019-02-07  Tom Tromey  <tom@tromey.com>
9224
9225         * thread.c (thread_cancel_execution_command): Update.
9226         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9227         methods.
9228         (struct thread_fsm_ops): Remove.
9229         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9230         (thread_fsm_should_stop, thread_fsm_return_value)
9231         (thread_fsm_set_finished, thread_fsm_finished_p)
9232         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9233         Don't declare.
9234         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9235         * infrun.c (clear_proceed_status_thread)
9236         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9237         (print_stop_event): Update.
9238         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9239         Add constructor.
9240         (step_command_fsm_ops): Remove.
9241         (new_step_command_fsm): Remove.
9242         (step_1): Update.
9243         (step_command_fsm::should_stop): Rename from
9244         step_command_fsm_should_stop.
9245         (step_command_fsm::clean_up): Rename from
9246         step_command_fsm_clean_up.
9247         (step_command_fsm::do_async_reply_reason): Rename from
9248         step_command_fsm_async_reply_reason.
9249         (struct until_next_fsm): Inherit from thread_fsm.  Add
9250         constructor.
9251         (until_next_fsm_ops): Remove.
9252         (new_until_next_fsm): Remove.
9253         (until_next_fsm::should_stop): Rename from
9254         until_next_fsm_should_stop.
9255         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9256         (until_next_fsm::do_async_reply_reason): Rename from
9257         until_next_fsm_async_reply_reason.
9258         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9259         constructor.  Change type of breakpoint.
9260         (finish_command_fsm_ops): Remove.
9261         (new_finish_command_fsm): Remove.
9262         (finish_command_fsm::should_stop): Rename from
9263         finish_command_fsm_should_stop.
9264         (finish_command_fsm::clean_up): Rename from
9265         finish_command_fsm_clean_up.
9266         (finish_command_fsm::return_value): Rename from
9267         finish_command_fsm_return_value.
9268         (finish_command_fsm::do_async_reply_reason): Rename from
9269         finish_command_fsm_async_reply_reason.
9270         (finish_command): Update.
9271         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9272         Add constructor.
9273         (call_thread_fsm_ops): Remove.
9274         (call_thread_fsm::call_thread_fsm): Rename from
9275         new_call_thread_fsm.
9276         (call_thread_fsm::should_stop): Rename from
9277         call_thread_fsm_should_stop.
9278         (call_thread_fsm::should_notify_stop): Rename from
9279         call_thread_fsm_should_notify_stop.
9280         (run_inferior_call, call_function_by_hand_dummy): Update.
9281         * cli/cli-interp.c (should_print_stop_to_console): Update.
9282         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9283         Add constructor.  Change type of location_breakpoint,
9284         caller_breakpoint.
9285         (until_break_fsm_ops): Remove.
9286         (new_until_break_fsm): Remove.
9287         (until_break_fsm::should_stop): Rename from
9288         until_break_fsm_should_stop.
9289         (until_break_fsm::clean_up): Rename from
9290         until_break_fsm_clean_up.
9291         (until_break_fsm::do_async_reply_reason): Rename from
9292         until_break_fsm_async_reply_reason.
9293         (until_break_command): Update.
9294         * thread-fsm.c: Remove.
9295         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9296
9297 2019-02-07  Tom Tromey  <tom@tromey.com>
9298
9299         * yy-remap.h: Add include guard.
9300         * xtensa-tdep.h: Add include guard.
9301         * xcoffread.h: Rename include guard.
9302         * varobj-iter.h: Add include guard.
9303         * tui/tui.h: Rename include guard.
9304         * tui/tui-winsource.h: Rename include guard.
9305         * tui/tui-wingeneral.h: Rename include guard.
9306         * tui/tui-windata.h: Rename include guard.
9307         * tui/tui-win.h: Rename include guard.
9308         * tui/tui-stack.h: Rename include guard.
9309         * tui/tui-source.h: Rename include guard.
9310         * tui/tui-regs.h: Rename include guard.
9311         * tui/tui-out.h: Rename include guard.
9312         * tui/tui-layout.h: Rename include guard.
9313         * tui/tui-io.h: Rename include guard.
9314         * tui/tui-hooks.h: Rename include guard.
9315         * tui/tui-file.h: Rename include guard.
9316         * tui/tui-disasm.h: Rename include guard.
9317         * tui/tui-data.h: Rename include guard.
9318         * tui/tui-command.h: Rename include guard.
9319         * tic6x-tdep.h: Add include guard.
9320         * target/waitstatus.h: Rename include guard.
9321         * target/wait.h: Rename include guard.
9322         * target/target.h: Rename include guard.
9323         * target/resume.h: Rename include guard.
9324         * target-float.h: Rename include guard.
9325         * stabsread.h: Add include guard.
9326         * rs6000-tdep.h: Add include guard.
9327         * riscv-fbsd-tdep.h: Add include guard.
9328         * regformats/regdef.h: Rename include guard.
9329         * record.h: Rename include guard.
9330         * python/python.h: Rename include guard.
9331         * python/python-internal.h: Rename include guard.
9332         * python/py-stopevent.h: Rename include guard.
9333         * python/py-ref.h: Rename include guard.
9334         * python/py-record.h: Rename include guard.
9335         * python/py-record-full.h: Rename include guard.
9336         * python/py-record-btrace.h: Rename include guard.
9337         * python/py-instruction.h: Rename include guard.
9338         * python/py-events.h: Rename include guard.
9339         * python/py-event.h: Rename include guard.
9340         * procfs.h: Add include guard.
9341         * proc-utils.h: Add include guard.
9342         * p-lang.h: Add include guard.
9343         * or1k-tdep.h: Rename include guard.
9344         * observable.h: Rename include guard.
9345         * nto-tdep.h: Rename include guard.
9346         * nat/x86-linux.h: Rename include guard.
9347         * nat/x86-linux-dregs.h: Rename include guard.
9348         * nat/x86-gcc-cpuid.h: Add include guard.
9349         * nat/x86-dregs.h: Rename include guard.
9350         * nat/x86-cpuid.h: Rename include guard.
9351         * nat/ppc-linux.h: Rename include guard.
9352         * nat/mips-linux-watch.h: Rename include guard.
9353         * nat/linux-waitpid.h: Rename include guard.
9354         * nat/linux-ptrace.h: Rename include guard.
9355         * nat/linux-procfs.h: Rename include guard.
9356         * nat/linux-osdata.h: Rename include guard.
9357         * nat/linux-nat.h: Rename include guard.
9358         * nat/linux-namespaces.h: Rename include guard.
9359         * nat/linux-btrace.h: Rename include guard.
9360         * nat/glibc_thread_db.h: Rename include guard.
9361         * nat/gdb_thread_db.h: Rename include guard.
9362         * nat/gdb_ptrace.h: Rename include guard.
9363         * nat/fork-inferior.h: Rename include guard.
9364         * nat/amd64-linux-siginfo.h: Rename include guard.
9365         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9366         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9367         * nat/aarch64-linux.h: Rename include guard.
9368         * nat/aarch64-linux-hw-point.h: Rename include guard.
9369         * mn10300-tdep.h: Add include guard.
9370         * mips-linux-tdep.h: Add include guard.
9371         * mi/mi-parse.h: Rename include guard.
9372         * mi/mi-out.h: Rename include guard.
9373         * mi/mi-main.h: Rename include guard.
9374         * mi/mi-interp.h: Rename include guard.
9375         * mi/mi-getopt.h: Rename include guard.
9376         * mi/mi-console.h: Rename include guard.
9377         * mi/mi-common.h: Rename include guard.
9378         * mi/mi-cmds.h: Rename include guard.
9379         * mi/mi-cmd-break.h: Rename include guard.
9380         * m2-lang.h: Add include guard.
9381         * location.h: Rename include guard.
9382         * linux-record.h: Rename include guard.
9383         * linux-nat.h: Add include guard.
9384         * linux-fork.h: Add include guard.
9385         * i386-darwin-tdep.h: Rename include guard.
9386         * hppa-linux-offsets.h: Add include guard.
9387         * guile/guile.h: Rename include guard.
9388         * guile/guile-internal.h: Rename include guard.
9389         * gnu-nat.h: Rename include guard.
9390         * gdb-stabs.h: Rename include guard.
9391         * frv-tdep.h: Add include guard.
9392         * f-lang.h: Add include guard.
9393         * event-loop.h: Add include guard.
9394         * darwin-nat.h: Rename include guard.
9395         * cp-abi.h: Rename include guard.
9396         * config/sparc/nm-sol2.h: Rename include guard.
9397         * config/nm-nto.h: Rename include guard.
9398         * config/nm-linux.h: Add include guard.
9399         * config/i386/nm-i386gnu.h: Rename include guard.
9400         * config/djgpp/nl_types.h: Rename include guard.
9401         * config/djgpp/langinfo.h: Rename include guard.
9402         * compile/gcc-cp-plugin.h: Add include guard.
9403         * compile/gcc-c-plugin.h: Add include guard.
9404         * compile/compile.h: Rename include guard.
9405         * compile/compile-object-run.h: Rename include guard.
9406         * compile/compile-object-load.h: Rename include guard.
9407         * compile/compile-internal.h: Rename include guard.
9408         * compile/compile-cplus.h: Rename include guard.
9409         * compile/compile-c.h: Rename include guard.
9410         * common/xml-utils.h: Rename include guard.
9411         * common/x86-xstate.h: Rename include guard.
9412         * common/version.h: Rename include guard.
9413         * common/vec.h: Rename include guard.
9414         * common/tdesc.h: Rename include guard.
9415         * common/selftest.h: Rename include guard.
9416         * common/scoped_restore.h: Rename include guard.
9417         * common/scoped_mmap.h: Rename include guard.
9418         * common/scoped_fd.h: Rename include guard.
9419         * common/safe-iterator.h: Rename include guard.
9420         * common/run-time-clock.h: Rename include guard.
9421         * common/refcounted-object.h: Rename include guard.
9422         * common/queue.h: Rename include guard.
9423         * common/ptid.h: Rename include guard.
9424         * common/print-utils.h: Rename include guard.
9425         * common/preprocessor.h: Rename include guard.
9426         * common/pathstuff.h: Rename include guard.
9427         * common/observable.h: Rename include guard.
9428         * common/netstuff.h: Rename include guard.
9429         * common/job-control.h: Rename include guard.
9430         * common/host-defs.h: Rename include guard.
9431         * common/gdb_wait.h: Rename include guard.
9432         * common/gdb_vecs.h: Rename include guard.
9433         * common/gdb_unlinker.h: Rename include guard.
9434         * common/gdb_unique_ptr.h: Rename include guard.
9435         * common/gdb_tilde_expand.h: Rename include guard.
9436         * common/gdb_sys_time.h: Rename include guard.
9437         * common/gdb_string_view.h: Rename include guard.
9438         * common/gdb_splay_tree.h: Rename include guard.
9439         * common/gdb_setjmp.h: Rename include guard.
9440         * common/gdb_ref_ptr.h: Rename include guard.
9441         * common/gdb_optional.h: Rename include guard.
9442         * common/gdb_locale.h: Rename include guard.
9443         * common/gdb_assert.h: Rename include guard.
9444         * common/filtered-iterator.h: Rename include guard.
9445         * common/filestuff.h: Rename include guard.
9446         * common/fileio.h: Rename include guard.
9447         * common/environ.h: Rename include guard.
9448         * common/common-utils.h: Rename include guard.
9449         * common/common-types.h: Rename include guard.
9450         * common/common-regcache.h: Rename include guard.
9451         * common/common-inferior.h: Rename include guard.
9452         * common/common-gdbthread.h: Rename include guard.
9453         * common/common-exceptions.h: Rename include guard.
9454         * common/common-defs.h: Rename include guard.
9455         * common/common-debug.h: Rename include guard.
9456         * common/cleanups.h: Rename include guard.
9457         * common/buffer.h: Rename include guard.
9458         * common/btrace-common.h: Rename include guard.
9459         * common/break-common.h: Rename include guard.
9460         * cli/cli-utils.h: Rename include guard.
9461         * cli/cli-style.h: Rename include guard.
9462         * cli/cli-setshow.h: Rename include guard.
9463         * cli/cli-script.h: Rename include guard.
9464         * cli/cli-interp.h: Rename include guard.
9465         * cli/cli-decode.h: Rename include guard.
9466         * cli/cli-cmds.h: Rename include guard.
9467         * charset-list.h: Add include guard.
9468         * buildsym-legacy.h: Rename include guard.
9469         * bfin-tdep.h: Add include guard.
9470         * ax.h: Rename include guard.
9471         * arm-linux-tdep.h: Add include guard.
9472         * arm-fbsd-tdep.h: Add include guard.
9473         * arch/xtensa.h: Rename include guard.
9474         * arch/tic6x.h: Add include guard.
9475         * arch/i386.h: Add include guard.
9476         * arch/arm.h: Rename include guard.
9477         * arch/arm-linux.h: Rename include guard.
9478         * arch/arm-get-next-pcs.h: Rename include guard.
9479         * arch/amd64.h: Add include guard.
9480         * arch/aarch64-insn.h: Rename include guard.
9481         * arch-utils.h: Rename include guard.
9482         * annotate.h: Add include guard.
9483         * amd64-darwin-tdep.h: Rename include guard.
9484         * aarch64-linux-tdep.h: Add include guard.
9485         * aarch64-fbsd-tdep.h: Add include guard.
9486         * aarch32-linux-nat.h: Add include guard.
9487
9488 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9489
9490         * macrotab.c (macro_define_internal): New function that
9491         factorizes macro_define_object_internal and macro_define_function
9492         code.
9493         (macro_define_object_internal): Use macro_define_internal.
9494         (macro_define_function): Likewise.
9495
9496 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9497
9498         * macrocmd.c (extract_identifier): Return
9499         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9500         callers.
9501
9502 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9503
9504         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9505
9506 2019-02-05  Tom Tromey  <tom@tromey.com>
9507
9508         * target.c (target_stack::unpush): Move assertion earlier.
9509
9510 2019-01-30  Tom Tromey  <tom@tromey.com>
9511
9512         PR python/23615:
9513         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9514         (gdbpy_parse_and_eval): Likewise.
9515         * python/python-internal.h (gdbpy_allow_threads): New class.
9516
9517 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9518
9519         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9520         (aarch64_fbsd_fpregmap): Move earlier.
9521         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9522         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9523         instead of individual calls to trad_frame_set_reg_addr.
9524         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9525         earlier.
9526         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9527         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9528         instead of individual calls to trad_frame_set_reg_addr.
9529
9530 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9531
9532         * CONTRIBUTE: Replace contribution list with wiki link.
9533
9534 2019-01-25  Tom Tromey  <tom@tromey.com>
9535
9536         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9537
9538 2019-01-25  Tom Tromey  <tom@tromey.com>
9539
9540         * xtensa-linux-nat.c: Fix common/ includes.
9541         * xml-support.h: Fix common/ includes.
9542         * xml-support.c: Fix common/ includes.
9543         * x86-linux-nat.c: Fix common/ includes.
9544         * windows-nat.c: Fix common/ includes.
9545         * varobj.h: Fix common/ includes.
9546         * varobj.c: Fix common/ includes.
9547         * value.c: Fix common/ includes.
9548         * valops.c: Fix common/ includes.
9549         * utils.c: Fix common/ includes.
9550         * unittests/xml-utils-selftests.c: Fix common/ includes.
9551         * unittests/utils-selftests.c: Fix common/ includes.
9552         * unittests/unpack-selftests.c: Fix common/ includes.
9553         * unittests/tracepoint-selftests.c: Fix common/ includes.
9554         * unittests/style-selftests.c: Fix common/ includes.
9555         * unittests/string_view-selftests.c: Fix common/ includes.
9556         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9557         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9558         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9559         * unittests/rsp-low-selftests.c: Fix common/ includes.
9560         * unittests/parse-connection-spec-selftests.c: Fix common/
9561         includes.
9562         * unittests/optional-selftests.c: Fix common/ includes.
9563         * unittests/offset-type-selftests.c: Fix common/ includes.
9564         * unittests/observable-selftests.c: Fix common/ includes.
9565         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9566         * unittests/memrange-selftests.c: Fix common/ includes.
9567         * unittests/memory-map-selftests.c: Fix common/ includes.
9568         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9569         * unittests/function-view-selftests.c: Fix common/ includes.
9570         * unittests/environ-selftests.c: Fix common/ includes.
9571         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9572         * unittests/common-utils-selftests.c: Fix common/ includes.
9573         * unittests/cli-utils-selftests.c: Fix common/ includes.
9574         * unittests/array-view-selftests.c: Fix common/ includes.
9575         * ui-file.c: Fix common/ includes.
9576         * tui/tui-io.c: Fix common/ includes.
9577         * tracepoint.h: Fix common/ includes.
9578         * tracepoint.c: Fix common/ includes.
9579         * tracefile-tfile.c: Fix common/ includes.
9580         * top.h: Fix common/ includes.
9581         * top.c: Fix common/ includes.
9582         * thread.c: Fix common/ includes.
9583         * target/waitstatus.h: Fix common/ includes.
9584         * target/waitstatus.c: Fix common/ includes.
9585         * target.h: Fix common/ includes.
9586         * target.c: Fix common/ includes.
9587         * target-memory.c: Fix common/ includes.
9588         * target-descriptions.c: Fix common/ includes.
9589         * symtab.h: Fix common/ includes.
9590         * symfile.c: Fix common/ includes.
9591         * stap-probe.c: Fix common/ includes.
9592         * spu-linux-nat.c: Fix common/ includes.
9593         * sparc-nat.c: Fix common/ includes.
9594         * source.c: Fix common/ includes.
9595         * solib.c: Fix common/ includes.
9596         * solib-target.c: Fix common/ includes.
9597         * ser-unix.c: Fix common/ includes.
9598         * ser-tcp.c: Fix common/ includes.
9599         * ser-pipe.c: Fix common/ includes.
9600         * ser-base.c: Fix common/ includes.
9601         * selftest-arch.c: Fix common/ includes.
9602         * s12z-tdep.c: Fix common/ includes.
9603         * rust-exp.y: Fix common/ includes.
9604         * rs6000-aix-tdep.c: Fix common/ includes.
9605         * riscv-tdep.c: Fix common/ includes.
9606         * remote.c: Fix common/ includes.
9607         * remote-notif.h: Fix common/ includes.
9608         * remote-fileio.h: Fix common/ includes.
9609         * remote-fileio.c: Fix common/ includes.
9610         * regcache.h: Fix common/ includes.
9611         * regcache.c: Fix common/ includes.
9612         * record-btrace.c: Fix common/ includes.
9613         * python/python.c: Fix common/ includes.
9614         * python/py-type.c: Fix common/ includes.
9615         * python/py-inferior.c: Fix common/ includes.
9616         * progspace.h: Fix common/ includes.
9617         * producer.c: Fix common/ includes.
9618         * procfs.c: Fix common/ includes.
9619         * proc-api.c: Fix common/ includes.
9620         * printcmd.c: Fix common/ includes.
9621         * ppc-linux-nat.c: Fix common/ includes.
9622         * parser-defs.h: Fix common/ includes.
9623         * osdata.c: Fix common/ includes.
9624         * obsd-nat.c: Fix common/ includes.
9625         * nat/x86-linux.c: Fix common/ includes.
9626         * nat/x86-linux-dregs.c: Fix common/ includes.
9627         * nat/x86-dregs.h: Fix common/ includes.
9628         * nat/x86-dregs.c: Fix common/ includes.
9629         * nat/ppc-linux.c: Fix common/ includes.
9630         * nat/mips-linux-watch.h: Fix common/ includes.
9631         * nat/mips-linux-watch.c: Fix common/ includes.
9632         * nat/linux-waitpid.c: Fix common/ includes.
9633         * nat/linux-ptrace.h: Fix common/ includes.
9634         * nat/linux-ptrace.c: Fix common/ includes.
9635         * nat/linux-procfs.c: Fix common/ includes.
9636         * nat/linux-personality.c: Fix common/ includes.
9637         * nat/linux-osdata.c: Fix common/ includes.
9638         * nat/linux-namespaces.c: Fix common/ includes.
9639         * nat/linux-btrace.h: Fix common/ includes.
9640         * nat/linux-btrace.c: Fix common/ includes.
9641         * nat/fork-inferior.c: Fix common/ includes.
9642         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9643         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9644         * nat/aarch64-linux.c: Fix common/ includes.
9645         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9646         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9647         * namespace.h: Fix common/ includes.
9648         * mips-linux-tdep.c: Fix common/ includes.
9649         * minsyms.c: Fix common/ includes.
9650         * mi/mi-parse.h: Fix common/ includes.
9651         * mi/mi-main.c: Fix common/ includes.
9652         * mi/mi-cmd-env.c: Fix common/ includes.
9653         * memrange.h: Fix common/ includes.
9654         * memattr.c: Fix common/ includes.
9655         * maint.h: Fix common/ includes.
9656         * maint.c: Fix common/ includes.
9657         * main.c: Fix common/ includes.
9658         * machoread.c: Fix common/ includes.
9659         * location.c: Fix common/ includes.
9660         * linux-thread-db.c: Fix common/ includes.
9661         * linux-nat.c: Fix common/ includes.
9662         * linux-fork.c: Fix common/ includes.
9663         * inline-frame.c: Fix common/ includes.
9664         * infrun.c: Fix common/ includes.
9665         * inflow.c: Fix common/ includes.
9666         * inferior.h: Fix common/ includes.
9667         * inferior.c: Fix common/ includes.
9668         * infcmd.c: Fix common/ includes.
9669         * inf-ptrace.c: Fix common/ includes.
9670         * inf-child.c: Fix common/ includes.
9671         * ia64-linux-nat.c: Fix common/ includes.
9672         * i387-tdep.c: Fix common/ includes.
9673         * i386-tdep.c: Fix common/ includes.
9674         * i386-linux-tdep.c: Fix common/ includes.
9675         * i386-linux-nat.c: Fix common/ includes.
9676         * i386-go32-tdep.c: Fix common/ includes.
9677         * i386-fbsd-tdep.c: Fix common/ includes.
9678         * i386-fbsd-nat.c: Fix common/ includes.
9679         * guile/scm-type.c: Fix common/ includes.
9680         * guile/guile.c: Fix common/ includes.
9681         * go32-nat.c: Fix common/ includes.
9682         * gnu-nat.c: Fix common/ includes.
9683         * gdbthread.h: Fix common/ includes.
9684         * gdbarch-selftests.c: Fix common/ includes.
9685         * gdb_usleep.c: Fix common/ includes.
9686         * gdb_select.h: Fix common/ includes.
9687         * gdb_bfd.c: Fix common/ includes.
9688         * gcore.c: Fix common/ includes.
9689         * fork-child.c: Fix common/ includes.
9690         * findvar.c: Fix common/ includes.
9691         * fbsd-nat.c: Fix common/ includes.
9692         * event-top.c: Fix common/ includes.
9693         * event-loop.c: Fix common/ includes.
9694         * dwarf2read.c: Fix common/ includes.
9695         * dwarf2loc.c: Fix common/ includes.
9696         * dwarf2-frame.c: Fix common/ includes.
9697         * dwarf-index-cache.c: Fix common/ includes.
9698         * dtrace-probe.c: Fix common/ includes.
9699         * disasm-selftests.c: Fix common/ includes.
9700         * defs.h: Fix common/ includes.
9701         * csky-tdep.c: Fix common/ includes.
9702         * cp-valprint.c: Fix common/ includes.
9703         * cp-support.h: Fix common/ includes.
9704         * cp-support.c: Fix common/ includes.
9705         * corelow.c: Fix common/ includes.
9706         * completer.h: Fix common/ includes.
9707         * completer.c: Fix common/ includes.
9708         * compile/compile.c: Fix common/ includes.
9709         * compile/compile-loc2c.c: Fix common/ includes.
9710         * compile/compile-cplus-types.c: Fix common/ includes.
9711         * compile/compile-cplus-symbols.c: Fix common/ includes.
9712         * command.h: Fix common/ includes.
9713         * cli/cli-dump.c: Fix common/ includes.
9714         * cli/cli-cmds.c: Fix common/ includes.
9715         * charset.c: Fix common/ includes.
9716         * build-id.c: Fix common/ includes.
9717         * btrace.h: Fix common/ includes.
9718         * btrace.c: Fix common/ includes.
9719         * breakpoint.h: Fix common/ includes.
9720         * breakpoint.c: Fix common/ includes.
9721         * ax.h: 
9722         (enum agent_op): Fix common/ includes.
9723         * ax-general.c (struct aop_map): Fix common/ includes.
9724         * ax-gdb.c: Fix common/ includes.
9725         * auxv.c: Fix common/ includes.
9726         * auto-load.c: Fix common/ includes.
9727         * arm-tdep.c: Fix common/ includes.
9728         * arch/riscv.c: Fix common/ includes.
9729         * arch/ppc-linux-common.c: Fix common/ includes.
9730         * arch/i386.c: Fix common/ includes.
9731         * arch/arm.c: Fix common/ includes.
9732         * arch/arm-linux.c: Fix common/ includes.
9733         * arch/arm-get-next-pcs.c: Fix common/ includes.
9734         * arch/amd64.c: Fix common/ includes.
9735         * arch/aarch64.c: Fix common/ includes.
9736         * arch/aarch64-insn.c: Fix common/ includes.
9737         * arch-utils.c: Fix common/ includes.
9738         * amd64-windows-tdep.c: Fix common/ includes.
9739         * amd64-tdep.c: Fix common/ includes.
9740         * amd64-sol2-tdep.c: Fix common/ includes.
9741         * amd64-obsd-tdep.c: Fix common/ includes.
9742         * amd64-nbsd-tdep.c: Fix common/ includes.
9743         * amd64-linux-tdep.c: Fix common/ includes.
9744         * amd64-linux-nat.c: Fix common/ includes.
9745         * amd64-fbsd-tdep.c: Fix common/ includes.
9746         * amd64-fbsd-nat.c: Fix common/ includes.
9747         * amd64-dicos-tdep.c: Fix common/ includes.
9748         * amd64-darwin-tdep.c: Fix common/ includes.
9749         * agent.c: Fix common/ includes.
9750         * ada-lang.h: Fix common/ includes.
9751         * ada-lang.c: Fix common/ includes.
9752         * aarch64-tdep.c: Fix common/ includes.
9753
9754 2019-01-25  Tom Tromey  <tom@tromey.com>
9755
9756         * common/create-version.sh: Use common/version.h.
9757
9758 2019-01-24  Pedro Alves  <palves@redhat.com>
9759
9760         * infrun.c (signal_stop, signal_print, signal_program)
9761         (signal_catch, signal_pass): Now arrays instead of pointers.
9762         (update_signals_program_target, do_target_resume)
9763         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9764         * linux-nat.c (linux_nat_target::pass_signals)
9765         (linux_nat_target::create_inferior, linux_nat_target::attach):
9766         Adjust.
9767         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9768         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9769         * procfs.c (procfs_target::pass_signals): Adjust.
9770         * record-full.c (record_full_target::resume): Adjust.
9771         * remote.c (remote_target::pass_signals)
9772         (remote_target::program_signals): Adjust.
9773         * target-debug.h (target_debug_print_signals): Now takes a
9774         gdb::array_view as parameter.  Adjust.
9775         * target.h (target_ops) <pass_signals, program_signals>: Replace
9776         pointer and length parameters with gdb::array_view.
9777         (target_pass_signals, target_program_signals): Likewise.
9778         * target-delegates.c: Regenerate.
9779
9780 2019-01-24  Pedro Alves  <palves@redhat.com>
9781
9782         * common/forward-scope-exit.h
9783         (forward_scope_exit::forward_scope_exit): Pass arguments to
9784         m_bind_function directly, instead of creating a std::bind and
9785         copying that.
9786
9787 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9788
9789         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9790         for static members.
9791         (pass_in_v_vfp_candidate): Likewise.
9792
9793 2019-01-23  Tom Tromey  <tom@tromey.com>
9794             Pedro Alves  <palves@redhat.com>
9795
9796         * regcache.c (class regcache_invalidator): Remove.
9797         (regcache::raw_write): Use make_scope_exit.
9798
9799 2019-01-23  Tom Tromey  <tom@tromey.com>
9800
9801         * ui-out.h (class ui_out_emit_type): Update comment.
9802
9803 2019-01-23  Tom Tromey  <tom@tromey.com>
9804
9805         * infrun.c (fetch_inferior_event): Update comment.
9806
9807 2019-01-23  Tom Tromey  <tom@tromey.com>
9808             Pedro Alves  <palves@redhat.com>
9809
9810         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9811         parameter.
9812         (fetch_inferior_event): Use SCOPE_EXIT.
9813
9814
9815 2019-01-23  Tom Tromey  <tom@tromey.com>
9816             Pedro Alves  <palves@redhat.com>
9817
9818         * infrun.c (disable_thread_events): Delete.
9819         (stop_all_threads): Use SCOPE_EXIT.
9820
9821 2019-01-23  Tom Tromey  <tom@tromey.com>
9822             Pedro Alves  <palves@redhat.com>
9823
9824         * symfile.c: Include forward-scope-exit.h.
9825         (clear_symtab_users_cleanup): Replace forward declaration with
9826         a FORWARD_SCOPE_EXIT.
9827         (syms_from_objfile_1): Use the forward_scope_exit and
9828         gdb::optional instead of cleanup_function.
9829         (reread_symbols): Use the forward_scope_exit instead of
9830         cleanup_function.
9831         (clear_symtab_users_cleanup): Remove function.
9832
9833 2019-01-23  Tom Tromey  <tom@tromey.com>
9834             Pedro Alves  <palves@redhat.com>
9835
9836         * linux-nat.c: Include scope-exit.h.
9837         (cleanup_target_stop): Remove.
9838         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9839         SCOPE_EXIT.
9840
9841 2019-01-23  Tom Tromey  <tom@tromey.com>
9842             Pedro Alves  <palves@redhat.com>
9843
9844         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9845         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9846
9847 2019-01-23  Tom Tromey  <tom@tromey.com>
9848             Andrew Burgess  <andrew.burgess@embecosm.com>
9849             Pedro Alves  <palves@redhat.com>
9850
9851         * infrun.c (fetch_inferior_event): Use scope_exit.
9852         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9853         * top.c (execute_command): Use scope_exit.
9854         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9855         * utils.c (do_bpstat_clear_actions_cleanup)
9856         (make_bpstat_clear_actions_cleanup): Remove.
9857
9858 2019-01-23  Tom Tromey  <tom@tromey.com>
9859             Pedro Alves  <palves@redhat.com>
9860
9861         * infrun.c: Include "common/scope-exit.h"
9862         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9863         (wait_for_inferior): Use SCOPE_EXIT.
9864         (fetch_inferior_event): Use scope_exit.
9865
9866 2019-01-23  Tom Tromey  <tom@tromey.com>
9867             Pedro Alves  <palves@redhat.com>
9868
9869         * breakpoint.c (create_breakpoint): Remove cleanup.
9870
9871 2019-01-23  Tom Tromey  <tom@tromey.com>
9872             Andrew Burgess  <andrew.burgess@embecosm.com>
9873             Pedro Alves  <palves@redhat.com>
9874
9875 2019-01-23  Pedro Alves  <palves@redhat.com>
9876
9877         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9878
9879 2019-01-23  Pedro Alves  <palves@redhat.com>
9880             Andrew Burgess  <andrew.burgess@embecosm.com>
9881
9882         * gdbthread.h: Include "common/forward-scope-exit.h".
9883         (scoped_finish_thread_state): Redefine custom class in terms of
9884         forward_scope_exit.
9885
9886 2019-01-23  Pedro Alves  <palves@redhat.com>
9887             Andrew Burgess  <andrew.burgess@embecosm.com>
9888
9889         * common/forward-scope-exit.h: New file.
9890
9891 2019-01-23  Pedro Alves  <palves@redhat.com>
9892             Andrew Burgess  <andrew.burgess@embecosm.com>
9893             Tom Tromey  <tom@tromey.com>
9894
9895         * common/scope-exit.h: New file.
9896
9897 2019-01-23  Pedro Alves  <palves@redhat.com>
9898
9899         * common/preprocessor.h (ESC): Rename to ...
9900         (ESC_PARENS): ... this.
9901         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9902         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9903
9904 2019-01-23  Tom Tromey  <tom@tromey.com>
9905
9906         * language.h (class scoped_switch_to_sym_language_if_auto):
9907         Initialize m_lang in both cases.
9908
9909 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9910
9911         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9912         with XCNEW.
9913
9914 2019-01-22  Tom Tromey  <tom@tromey.com>
9915
9916         * corelow.c: Do not include sys/file.h.
9917
9918 2019-01-22  Tom Tromey  <tom@tromey.com>
9919
9920         * tui/tui-wingeneral.h: Include gdb_curses.h.
9921
9922 2019-01-22  Tom Tromey  <tom@tromey.com>
9923
9924         * source-cache.h (class source_cache) <get_source_lines,
9925         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9926
9927 2019-01-22  Tom Tromey  <tom@tromey.com>
9928
9929         * remote-fileio.h (struct remote_target): Declare.
9930
9931 2019-01-22  Tom Tromey  <tom@tromey.com>
9932
9933         * python/py-arch.c: Do not include py-ref.h.
9934         * python/py-bpevent.c: Do not include py-ref.h.
9935         * python/py-cmd.c: Do not include py-ref.h.
9936         * python/py-continueevent.c: Do not include py-ref.h.
9937         * python/py-event.h: Do not include py-ref.h.
9938         * python/py-evtregistry.c: Do not include py-ref.h.
9939         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9940         * python/py-frame.c: Do not include py-ref.h.
9941         * python/py-framefilter.c: Do not include py-ref.h.
9942         * python/py-function.c: Do not include py-ref.h.
9943         * python/py-infevents.c: Do not include py-ref.h.
9944         * python/py-linetable.c: Do not include py-ref.h.
9945         * python/py-objfile.c: Do not include py-ref.h.
9946         * python/py-param.c: Do not include py-ref.h.
9947         * python/py-prettyprint.c: Do not include py-ref.h.
9948         * python/py-progspace.c: Do not include py-ref.h.
9949         * python/py-symbol.c: Do not include py-ref.h.
9950         * python/py-symtab.c: Do not include py-ref.h.
9951         * python/py-type.c: Do not include py-ref.h.
9952         * python/py-unwind.c: Do not include py-ref.h.
9953         * python/py-utils.c: Do not include py-ref.h.
9954         * python/py-value.c: Do not include py-ref.h.
9955         * python/py-varobj.c: Do not include py-ref.h.
9956         * python/py-xmethods.c: Do not include py-ref.h.
9957         * python/python.c: Do not include py-ref.h.
9958         * varobj.c: Do not include py-ref.h.
9959
9960 2019-01-22  Tom Tromey  <tom@tromey.com>
9961
9962         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9963         keyword for bcache.
9964
9965 2019-01-22  Tom Tromey  <tom@tromey.com>
9966
9967         * compile/compile-cplus-types.c: Remove a comment by #include.
9968
9969 2019-01-22  Tom Tromey  <tom@tromey.com>
9970
9971         * compile/gcc-c-plugin.h: Include compile-internal.h.
9972
9973 2019-01-22  Tom Tromey  <tom@tromey.com>
9974
9975         * stabsread.c (EXTERN): Do not define.
9976         (symnum, next_symbol_text_func, processing_gcc_compilation)
9977         (within_function, global_sym_chain, global_stabs)
9978         (previous_stab_code, this_object_header_files)
9979         (n_this_object_header_files)
9980         (n_allocated_this_object_header_files): Define.
9981         * stabsread.h (EXTERN): Never define.  Use "extern".
9982
9983 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9984
9985         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9986         history_value.
9987
9988 2019-01-21  Tom Tromey  <tom@tromey.com>
9989
9990         * ui-out.c: Fix includes.
9991         * tui/tui-source.c: Fix includes.
9992         * target.c: Fix includes.
9993         * remote.c: Fix includes.
9994         * regcache.c: Fix includes.
9995         * python/py-block.c: Fix includes.
9996         * printcmd.c: Fix includes.
9997         * or1k-tdep.c: Fix includes.
9998         * mi/mi-main.c: Fix includes.
9999         * m32r-tdep.c: Fix includes.
10000         * csky-tdep.c: Fix includes.
10001         * compile/compile-cplus-types.c: Fix includes.
10002         * cli/cli-interp.c: Fix includes.
10003
10004 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10005
10006         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10007         for padding.
10008
10009 2019-01-16  Tom Tromey  <tom@tromey.com>
10010
10011         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10012         earlier.
10013         (struct objfile) <msymbols_range>: Move from top level.
10014         <msymbols>: New method.
10015         (class objfile_msymbols): Remove.
10016         * symtab.c (default_collect_symbol_completion_matches_break_on):
10017         Update.
10018         * symmisc.c (dump_msymbols): Update.
10019         * stabsread.c (scan_file_globals): Update.
10020         * objc-lang.c (info_selectors_command, info_classes_command)
10021         (find_methods): Update.
10022         * minsyms.c (find_solib_trampoline_target): Update.
10023         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10024         * coffread.c (coff_symfile_read): Update.
10025         * ada-lang.c (ada_lookup_simple_minsym)
10026         (ada_collect_symbol_completion_matches): Update.
10027
10028 2019-01-16  Tom Tromey  <tom@tromey.com>
10029
10030         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10031         type.  Remove no-argument constructor.
10032         <iterator::operator++>: Simplify.
10033         <begin>: Update.
10034         <end>: Use minimal_symbol_count.
10035
10036 2019-01-16  Tom Tromey  <tom@tromey.com>
10037
10038         * objfiles.h (struct objfile) <psymtabs>: New method.
10039         (class objfile_psymtabs): Remove.
10040         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10041         typedef.
10042         <range>: New method.
10043         (require_partial_symbols): Change return type.
10044         * psymtab.c (require_partial_symbols)
10045         (psym_expand_symtabs_matching): Update.
10046         * mdebugread.c (parse_partial_symbols): Update.
10047         * dbxread.c (dbx_end_psymtab): Update.
10048
10049 2019-01-15  Tom Tromey  <tom@tromey.com>
10050
10051         * symtab.c (lookup_objfile_from_block)
10052         (lookup_symbol_in_objfile_symtabs)
10053         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10054         (find_line_symtab, info_sources_command)
10055         (default_collect_symbol_completion_matches_break_on)
10056         (make_source_files_completion_list): Update.
10057         * symmisc.c (print_objfile_statistics, dump_objfile)
10058         (maintenance_print_symbols, maintenance_info_symtabs)
10059         (maintenance_check_symtabs, maintenance_info_line_tables):
10060         Update.
10061         * source.c (select_source_symtab)
10062         (forget_cached_source_info_for_objfile): Update.
10063         * objfiles.h (class objfile_compunits): Remove.
10064         (struct objfile) <compunits_range>: New typedef.
10065         (compunits): New method.
10066         * objfiles.c (objfile_relocate1): Update.
10067         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10068         * maint.c (count_symtabs_and_blocks): Update.
10069         * linespec.c (iterate_over_all_matching_symtabs): Update.
10070         * cp-support.c (add_symbol_overload_list_qualified): Update.
10071         * coffread.c (coff_symtab_read): Update.
10072         * ada-lang.c (add_nonlocal_symbols)
10073         (ada_collect_symbol_completion_matches)
10074         (ada_add_global_exceptions): Update.
10075
10076 2019-01-15  Tom Tromey  <tom@tromey.com>
10077
10078         * progspace.h (program_space) <objfiles_safe_range>: New
10079         typedef.
10080         <objfiles_safe>: New method.
10081         * objfiles.h (class all_objfiles_safe): Remove.
10082         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10083         * jit.c (jit_inferior_exit_hook): Update.
10084
10085 2019-01-17  Tom Tromey  <tom@tromey.com>
10086
10087         * progspace.h (program_space) <objfiles_range>: New typedef.
10088         <objfiles>: New method.
10089         <objfiles_head>: Rename from objfiles.
10090         (object_files): Update.
10091         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10092         * guile/scm-pretty-print.c
10093         (ppscm_find_pretty_printer_from_objfiles): Update.
10094         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10095         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10096         Update.
10097         * python/py-progspace.c (pspy_get_objfiles): Update.
10098         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10099         Update.
10100         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10101         (objfpy_lookup_objfile_by_build_id): Update.
10102         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10103         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10104         Update.
10105         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10106         (expand_symtab_containing_pc, lookup_objfile_from_block)
10107         (lookup_static_symbol, basic_lookup_transparent_type)
10108         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10109         (find_line_symtab, info_sources_command)
10110         (default_collect_symbol_completion_matches_break_on)
10111         (make_source_files_completion_list, find_main_name): Update.
10112         * symmisc.c (print_symbol_bcache_statistics)
10113         (print_objfile_statistics, maintenance_print_symbols)
10114         (maintenance_print_msymbols, maintenance_print_objfiles)
10115         (maintenance_info_symtabs, maintenance_check_symtabs)
10116         (maintenance_expand_symtabs, maintenance_info_line_tables):
10117         Update.
10118         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10119         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10120         (map_overlay_command, unmap_overlay_command)
10121         (simple_overlay_update, expand_symtabs_matching)
10122         (map_symbol_filenames): Update.
10123         * symfile-debug.c (set_debug_symfile): Update.
10124         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10125         Update.
10126         * source.c (select_source_symtab, forget_cached_source_info):
10127         Update.
10128         * solib.c (solib_read_symbols): Update.
10129         * solib-spu.c (append_ocl_sos): Update.
10130         * psymtab.c (maintenance_print_psymbols)
10131         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10132         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10133         * printcmd.c (info_symbol_command): Update.
10134         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10135         Update.
10136         * objfiles.h (class all_objfiles): Remove.
10137         * objfiles.c (have_partial_symbols, have_full_symbols)
10138         (have_minimal_symbols, qsort_cmp, update_section_map)
10139         (shared_objfile_contains_address_p)
10140         (default_iterate_over_objfiles_in_search_order): Update.
10141         * objc-lang.c (info_selectors_command, info_classes_command)
10142         (find_methods): Update.
10143         * minsyms.c (find_solib_trampoline_target): Update.
10144         * maint.c (maintenance_info_sections)
10145         (maintenance_translate_address, count_symtabs_and_blocks):
10146         Update.
10147         * main.c (captured_main_1): Update.
10148         * linux-thread-db.c (try_thread_db_load_from_pdir)
10149         (has_libpthread): Update.
10150         * linespec.c (iterate_over_all_matching_symtabs)
10151         (search_minsyms_for_name): Update.
10152         * jit.c (jit_find_objf_with_entry_addr): Update.
10153         * hppa-tdep.c (find_unwind_entry)
10154         (hppa_lookup_stub_minimal_symbol): Update.
10155         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10156         Update.
10157         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10158         (elf_gnu_ifunc_resolve_by_got): Update.
10159         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10160         * dwarf-index-write.c (save_gdb_index_command): Update.
10161         * cp-support.c (add_symbol_overload_list_qualified): Update.
10162         * breakpoint.c (create_overlay_event_breakpoint)
10163         (create_longjmp_master_breakpoint)
10164         (create_std_terminate_master_breakpoint)
10165         (create_exception_master_breakpoint): Update.
10166         * blockframe.c (find_pc_partial_function): Update.
10167         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10168         (ada_collect_symbol_completion_matches)
10169         (ada_add_global_exceptions): Update.
10170
10171 2019-01-17  Tom Tromey  <tom@tromey.com>
10172
10173         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10174         declare VEC.
10175         (solib_target_parse_libraries): Change return type.
10176         (library_list_start_segment, library_list_start_section)
10177         (library_list_end_library, library_list_start_library); Update.
10178         (solib_target_free_library_list): Remove.
10179         (solib_target_parse_libraries): Remove cleanup.  Change return
10180         type.
10181         (solib_target_current_sos): Update.
10182
10183 2019-01-17  Tom Tromey  <tromey@bapiya>
10184
10185         * valprint.c: Replace "the the" with "the".
10186         * symtab.c: Replace "the the" with "the".
10187         * solib.c: Replace "the the" with "the".
10188         * solib-dsbt.c: Replace "the the" with "the".
10189         * linespec.c: Replace "the the" with "the".
10190         * dwarf2loc.h: Replace "the the" with "the".
10191         * amd64-windows-tdep.c: Replace "the the" with "the".
10192         * aarch64-tdep.c: Replace "the the" with "the".
10193
10194 2019-01-16  Keith Seitz  <keiths@redhat.com>
10195
10196         PR gdb/23773
10197         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10198         <builder>: Rename to ..
10199         <m_builder>: ... this and make private.
10200         (dwarf2_cu::get_builder): New method.  Change all users of
10201         `builder' to use this method.
10202         (dwarf2_start_symtab): Move to ...
10203         (dwarf2_cu::start_symtab): ... here.  Update all callers
10204         (setup_type_unit_groups): Move to ...
10205         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10206         callers.
10207         (dwarf2_cu::reset_builder): New method.
10208         (process_full_compunit, process_full_type_unit): Use
10209         dwarf2_cu::reset_builder.
10210         (follow_die_offset): Record the ancestor CU if it is different
10211         from the followed DIE's CU.
10212         (follow_die_sig_1): Likewise.
10213
10214 2019-01-15  Tom Tromey  <tom@tromey.com>
10215
10216         * remote.c (class remote_state) <buf>: Now a char_vector.
10217         <buf_size>: Remove.
10218         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10219         parameter.
10220         (remote_target::getpkt_or_notif_sane_1)
10221         (remote_target::getpkt_sane)
10222         (remote_target::getpkt_or_notif_sane): Likewise.
10223         (class remote_target) <putpkt>: New overload.
10224         (remote_target::read_frame): Change type of "buf_p".  Remove
10225         sizeof_p parameter.
10226         (packet_ok): New overload.
10227         (packet_check_result): New overload.
10228         Update all uses.
10229
10230 2019-01-14  Tom Tromey  <tom@tromey.com>
10231
10232         * remote-notif.c (handle_notification, remote_notif_ack)
10233         (remote_notif_parse): Make "buf" const.
10234         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10235         const.
10236         (remote_notif_parse, remote_notif_ack, handle_notification):
10237         Likewise.
10238         * remote.c (remote_notif_stop_parse): Make "buf" const.
10239         (remote_target::remote_parse_stop_reply): Make "buf" const.
10240         (remote_notif_stop_ack): Make "buf" const.
10241
10242 2019-01-14  Tom Tromey  <tom@tromey.com>
10243
10244         * remote.c (remote_console_output): Make parameter const.
10245
10246 2019-01-14  Tom Tromey  <tom@tromey.com>
10247
10248         * target-debug.h (target_debug_print_signals): Constify.
10249         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10250         * procfs.c (procfs_target::pass_signals): Update.
10251         * linux-nat.c (linux_nat_target::pass_signals): Update.
10252         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10253         * target-delegates.c: Rebuild.
10254         * remote.c (remote_target::program_signals): Update.
10255         (remote_target::pass_signals): Update.
10256         * target.c (target_pass_signals): Constify argument.
10257         (target_program_signals): Likewise.
10258         * target.h (struct target_ops) <pass_signals, program_signals>:
10259         Constify argument.
10260         (target_pass_signals, target_program_signals): Constify argument.
10261
10262 2019-01-14  Tom Tromey  <tom@tromey.com>
10263
10264         PR tui/28819:
10265         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10266
10267 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10268
10269         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10270         field.
10271         * rs6000-tdep.c: Include reggroups.h.
10272         (IS_V_ALIAS_PSEUDOREG): Define.
10273         (rs6000_register_name): Return names for the "vX" aliases.
10274         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10275         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10276         aliases.  Call default_register_reggroup_p for all other
10277         pseudo-registers.
10278         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10279         New functions.
10280         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10281         Handle "vX" aliases.
10282         (v_alias_pseudo_register_collect): New function.
10283         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10284         (rs6000_gdbarch_init): Initialize "vX" aliases as
10285         pseudo-registers.  Restore registration of
10286         rs6000_pseudo_register_reggroup_p with
10287         set_tdesc_pseudo_register_reggroup_p.
10288
10289 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10290
10291         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10292         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10293         set_gdbarch_num_pseudo_regs.
10294
10295 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10296
10297         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10298         Remove arg prefixname, add do_set and do_show.
10299         Add member functions set_list and show_list.
10300         * cli/cli-style.c (class cli_style_option): Update accordingly.
10301         (style_set_list): Move to file scope.
10302         (style_show_list): Likewise.
10303         (set_style): Call help_list.
10304         (show_style): Call cmd_show_list.
10305         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10306         Update to use the new macro.
10307
10308 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10309
10310         * ada-lang.c (_initialize_ada_language): Expand the help text
10311         for the "catch exception" command.
10312
10313 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10314
10315         * symtab.c (matching_obj_sections): Initialize obj,
10316         declare it closer to its usage.
10317
10318 2019-01-10  Tom Tromey  <tom@tromey.com>
10319
10320         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10321         (basic_inf_threads_range): Remove.
10322         (inf_threads_range, inf_non_exited_threads_range)
10323         (safe_inf_threads_range): Use next_adapter.
10324
10325 2019-01-10  Keith Seitz  <keiths@redhat.com>
10326
10327         PR gdb/23712
10328         PR symtab/23010
10329         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10330         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10331
10332 2019-01-10  Keith Seitz  <keiths@redhat.com>
10333
10334         PR gdb/23712
10335         PR symtab/23010
10336         * dictionary.c (pending_to_vector): Remove.
10337         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10338         Remove _1 suffix, replacing functions of the same name.  Update
10339         all callers.
10340         (dict_create_hashed, dict_create_hashed_expandable)
10341         (dict_create_linear, dict_create_linear_expandable, dict_free)
10342         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10343         Make functions static.
10344
10345 2019-01-10  Keith Seitz  <keiths@redhat.com>
10346
10347         PR gdb/23712
10348         PR symtab/23010
10349         * dictionary.h (struct dictionary): Replace declaration with
10350         multidictionary.
10351         (dict_create_hashed, dict_create_hashed_expandable)
10352         (dict_create_linear, dict_create_linear_expandable)
10353         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10354         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10355         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10356         taking multidictionary argument.
10357         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10358         * block.h (struct block) <dict>: Change to multidictionary
10359         and rename `multidict'.
10360         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10361         symmisc.c: Update all dictionary references to multidictionary.
10362
10363 2019-01-10  Keith Seitz  <keiths@redhat.com>
10364
10365         PR gdb/23712
10366         PR symtab/23010
10367         * dictionary.c: Include unordered_map.
10368         (pending_to_vector): New function.
10369         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10370         Rewrite the non-"_1" functions to take vector instead
10371         of linked list.
10372         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10373         "new" _1 versions of the same name.
10374         (multidictionary): Define.
10375         (std::hash<enum language): New definition.
10376         (collate_pending_symbols_by_language, mdict_create_hashed)
10377         (mdict_create_hashed_expandable, mdict_create_linear)
10378         (mdict_create_linear_expandable, mdict_free)
10379         (find_language_dictionary, create_new_language_dictionary)
10380         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10381         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10382         (mdict_size, mdict_empty): New functions.
10383         * dictionary.h (mdict_iterator): Define.
10384
10385 2019-01-10  Pedro Alves  <palves@redhat.com>
10386
10387         * breakpoint.c (read_uploaded_action)
10388         (create_tracepoint_from_upload): Adjust to use
10389         gdb::unique_xmalloc_ptr.
10390         * ctf.c (ctf_write_uploaded_tp):
10391         (SET_ARRAY_FIELD): Use emplace_back.
10392         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10393         * tracefile-tfile.c (tfile_write_uploaded_tp):
10394         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10395         gdb::unique_xmalloc_ptr.
10396         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10397         at_string, cond_string, cmd_strings>: Replace char pointers
10398         with gdb::unique_xmalloc_ptr.
10399
10400 2019-01-10  Pedro Alves  <palves@redhat.com>
10401
10402         * solib-target.c (library_list_start_library): Don't xstrdup name.
10403
10404 2019-01-10  Pedro Alves  <palves@redhat.com>
10405
10406         * mdebugread.c (parse_partial_symbols): Use
10407         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10408
10409 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10410
10411         * linux-fork.c (scoped_switch_fork_info)
10412         <~scoped_switch_fork_info>: Fix incorrect variable name.
10413
10414 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10415
10416         * linux-fork.c (scoped_switch_fork_info)
10417         <scoped_switch_fork_info>: Make explicit.
10418         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10419
10420 2019-01-10  Tom Tromey  <tom@tromey.com>
10421
10422         * objfiles.h (objfile::reset_psymtabs): Update.
10423         * objfiles.c (objfile::objfile): Update.
10424         * psymtab.h (psymtab_storage::obstack): Update.
10425         (psymtab_storage::m_obstack): Use gdb::optional.
10426         (class psymtab_storage): Update comment.  Remove objfile
10427         parameter.
10428         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10429
10430 2019-01-10  Tom Tromey  <tom@tromey.com>
10431
10432         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10433         <free_psymtabs>: Now private.
10434         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10435         (allocate_psymtab): Use new method.
10436
10437 2019-01-10  Tom Tromey  <tom@tromey.com>
10438
10439         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10440         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10441         * mdebugread.c (parse_partial_symbols): Use
10442         allocate_dependencies.
10443         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10444         allocate_dependencies.
10445         (process_psymtab_comp_unit_reader)
10446         (build_type_psymtab_dependencies): Likewise.
10447         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10448
10449 2019-01-10  Tom Tromey  <tom@tromey.com>
10450
10451         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10452         PSYMBOL_SET_LANGUAGE.
10453         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10454
10455 2019-01-10  Tom Tromey  <tom@tromey.com>
10456
10457         * psymtab.h (psymtab_storage::obstack): New method.
10458         <m_obstack>: Rename from obstack; now private.
10459         * psymtab.c (psymtab_storage): Update.
10460         * dwarf2read.c (create_addrmap_from_index)
10461         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10462         Update.
10463
10464 2019-01-10  Tom Tromey  <tom@tromey.com>
10465
10466         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10467         * objfiles.h (objfile::reset_psymtabs): New method.
10468
10469 2019-01-10  Tom Tromey  <tom@tromey.com>
10470
10471         * symmisc.c (print_symbol_bcache_statistics): Update.
10472         (print_objfile_statistics): Update.
10473         * symfile.c (reread_symbols): Update.
10474         * psymtab.h (class psymtab_storage): New.
10475         * psymtab.c (psymtab_storage): New constructor.
10476         (~psymtab_storage): New destructor.
10477         (require_partial_symbols): Update.
10478         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10479         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10480         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10481         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10482         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10483         (start_psymtab_common, end_psymtab_common)
10484         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10485         (allocate_psymtab): Update.
10486         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10487         Update.
10488         (dump_psymtab_addrmap, maintenance_print_psymbols)
10489         (maintenance_check_psymtabs): Update.
10490         (class objfile_psymtabs): Move to objfiles.h.
10491         * psympriv.h (discard_psymtab): Now inline.
10492         (psymtab_discarder::psymtab_discarder): Update.
10493         (psymtab_discarder::~psymtab_discarder): Update.
10494         (ALL_OBJFILE_PSYMTABS): Rewrite.
10495         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10496         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10497         Remove fields.
10498         <partial_symtabs>: New field.
10499         (class objfile_psymtabs): Move from psymtab.h.  Update.
10500         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10501         psymbol_cache.
10502         (objfile::~objfile): Don't destroy psymbol_cache.
10503         * mdebugread.c (parse_partial_symbols): Update.
10504         * dwarf2read.c (create_addrmap_from_index)
10505         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10506         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10507         (add_partial_subprogram, dwarf2_ranges_read): Update.
10508         * dwarf-index-write.c (write_address_map)
10509         (write_one_signatured_type, recursively_write_psymbols)
10510         (class debug_names, class debug_names, write_psymtabs_to_index):
10511         Update.
10512
10513 2019-01-10  Tom Tromey  <tom@tromey.com>
10514
10515         * symtab.h (SYMBOL_SET_NAMES): Update.
10516         (symbol_set_names): Update.
10517         (MSYMBOL_SET_NAMES): Update.
10518         * symtab.c (symbol_set_names): Change argument to be an
10519         objfile_per_bfd_storage.
10520         * psymtab.c (add_psymbol_to_bcache): Update.
10521         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10522
10523 2019-01-10  Tom Tromey  <tom@tromey.com>
10524
10525         * symtab.c (create_demangled_names_hash): Change argument to be an
10526         objfile_per_bfd_storage.
10527         (symbol_set_names): Update.
10528
10529 2019-01-10  Tom Tromey  <tom@tromey.com>
10530
10531         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10532         init_psymbol_list.
10533         * psymtab.c (init_psymbol_list): Do nothing if already called.
10534         * psympriv.h (init_psymbol_list): Add comment.
10535         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10536         init_psymbol_list.
10537         * dbxread.c (dbx_symfile_read): Unconditionally call
10538         init_psymbol_list.
10539
10540 2019-01-10  Tom Tromey  <tom@tromey.com>
10541
10542         * xcoffread.c (scan_xcoff_symtab): Update.
10543         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10544         "where".
10545         * mdebugread.c (parse_partial_symbols)
10546         (handle_psymbol_enumerators): Update.
10547         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10548         * dbxread.c (read_dbx_symtab): Update.
10549         * psympriv.h (psymbol_placement): New enum.
10550         (add_psymbol_to_list): Update.
10551
10552 2019-01-10  Tom Tromey  <tom@tromey.com>
10553
10554         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10555         static_psymbols parameters.
10556         (scan_xcoff_symtab): Update.
10557         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10558         static_psymbols parameters.
10559         * psympriv.h (start_psymtab_common): Update.
10560         * mdebugread.c (parse_partial_symbols): Update.
10561         * dwarf2read.c (create_partial_symtab): Update.
10562         * dbxread.c (read_dbx_symtab): Update.
10563         (start_psymtab): Remove global_psymbols and static_psymbols
10564         parameters.
10565
10566 2019-01-10  Tom Tromey  <tom@tromey.com>
10567
10568         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10569         * psymtab.c (allocate_psymtab): Add comment.
10570         * psympriv.h (allocate_psymtab): Add comment.
10571         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10572         initializations.
10573         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10574
10575 2019-01-10  Tom Tromey  <tom@tromey.com>
10576
10577         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10578         Don't declare.
10579         * mipsread.c: Include mdebugread.h.
10580         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10581         Declare.
10582         * elfread.c: Include mdebugread.h.
10583
10584 2019-01-09  Tom Tromey  <tom@tromey.com>
10585
10586         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10587         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10588         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10589         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10590         (psym_lookup_symbol, psym_find_last_source_symtab)
10591         (psym_forget_cached_source_info, psym_print_stats)
10592         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10593         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10594         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10595         (psym_find_compunit_symtab_by_address)
10596         (maintenance_print_psymbols, maintenance_info_psymtabs)
10597         (maintenance_check_psymtabs): Use ranged for.
10598         * psymtab.h (class objfile_psymtabs): New.
10599         (require_partial_symbols): Return objfile_psymtabs.
10600         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10601
10602 2019-01-09  Tom Tromey  <tom@tromey.com>
10603
10604         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10605         (find_pc_mapped_section, list_overlays_command)
10606         (map_overlay_command, unmap_overlay_command)
10607         (simple_overlay_update): Use all_objfiles.
10608         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10609         * printcmd.c (info_symbol_command): Use all_objfiles.
10610         * objfiles.h (ALL_OBJSECTIONS): Remove.
10611         * maint.c (maintenance_translate_address): Use all_objfiles.
10612         * gcore.c (gcore_create_callback): Use all_objfiles.
10613         (objfile_find_memory_regions): Likewise.
10614
10615 2019-01-09  Tom Tromey  <tom@tromey.com>
10616
10617         * symtab.c (find_line_symtab, info_sources_command)
10618         (make_source_files_completion_list): Use objfile_compunits.
10619         * source.c (select_source_symtab): Use objfile_compunits.
10620         * objfiles.h (struct objfile): Update comment.
10621         (ALL_OBJFILES): Remove.
10622         (ALL_FILETABS): Remove.
10623         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10624         objfile_compunits.
10625
10626 2019-01-09  Tom Tromey  <tom@tromey.com>
10627
10628         * symmisc.c (print_objfile_statistics, dump_objfile)
10629         (maintenance_print_symbols): Use compunit_filetabs.
10630         * source.c (forget_cached_source_info_for_objfile): Use
10631         compunit_filetabs.
10632         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10633         (ALL_FILETABS): Use compunit_filetabs.
10634         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10635         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10636
10637 2019-01-09  Tom Tromey  <tom@tromey.com>
10638
10639         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10640         (compunit_filetabs): New.
10641         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10642         compunit_filetabs.
10643         (info_sources_command, make_source_files_completion_list): Remove
10644         declaration.
10645         * symmisc.c (print_objfile_statistics, dump_objfile)
10646         (maintenance_print_symbols): Remove declaration.
10647         (maintenance_info_symtabs): Use compunit_filetabs.
10648         (maintenance_info_line_tables): Likewise.
10649         * source.c (select_source_symtab): Change local variable name.
10650         (forget_cached_source_info_for_objfile): Remove declaration.
10651         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10652         * objfiles.c (objfile_relocate1): Remove declaration.
10653         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10654         declaration.
10655         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10656         * coffread.c (coff_symtab_read): Remove declaration.
10657         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10658         compunit_filetabs.
10659
10660 2019-01-09  Tom Tromey  <tom@tromey.com>
10661
10662         * symtab.c (lookup_objfile_from_block)
10663         (find_pc_sect_compunit_symtab, search_symbols)
10664         (default_collect_symbol_completion_matches_break_on): Use
10665         objfile_compunits.
10666         * objfiles.h (ALL_COMPUNITS): Remove.
10667         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10668         * cp-support.c (add_symbol_overload_list_qualified): Use
10669         objfile_compunits.
10670         * ada-lang.c (ada_collect_symbol_completion_matches)
10671         (ada_add_global_exceptions): Use objfile_compunits.
10672
10673 2019-01-09  Tom Tromey  <tom@tromey.com>
10674
10675         * source.c (select_source_symtab)
10676         (forget_cached_source_info_for_objfile): Remove declaration.
10677         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10678         declaration.
10679         * maint.c (count_symtabs_and_blocks): Remove declaration.
10680         * cp-support.c (add_symbol_overload_list_qualified): Remove
10681         declaration.
10682         * coffread.c (coff_symtab_read): Remove declaration.
10683         * symtab.c (lookup_symbol_in_objfile_symtabs)
10684         (basic_lookup_transparent_type_1): Use objfile_compunits.
10685         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10686         (info_sources_command, search_symbols)
10687         (default_collect_symbol_completion_matches_break_on)
10688         (make_source_files_completion_list): Remove declaration.
10689         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10690         (ada_collect_symbol_completion_matches)
10691         (ada_add_global_exceptions): Remove declaration.
10692         * linespec.c (iterate_over_all_matching_symtabs): Use
10693         objfile_compunits.
10694         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10695         (class objfile_compunits): New.
10696         (ALL_COMPUNITS): Use objfile_compunits.
10697         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10698         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10699         objfile_compunits.
10700         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10701
10702 2019-01-09  Tom Tromey  <tom@tromey.com>
10703
10704         * symtab.c (search_symbols)
10705         (default_collect_symbol_completion_matches_break_on): Use
10706         objfile_msymbols.
10707         * ada-lang.c (ada_lookup_simple_minsym)
10708         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10709         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10710         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10711         objfile_msymbols.
10712         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10713         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10714         * objc-lang.c (find_methods): Use objfile_msymbols.
10715         (info_selectors_command, info_classes_command): Likewise.
10716         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10717         * objfiles.h (class objfile_msymbols): New.
10718         (ALL_OBJFILE_MSYMBOLS): Remove.
10719         (ALL_MSYMBOLS): Remove.
10720
10721 2019-01-09  Tom Tromey  <tom@tromey.com>
10722
10723         * common/next-iterator.h (next_adapter): Add Iterator template
10724         parameter.
10725         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10726         (class all_objfiles_safe): New.
10727         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10728         * objfiles.c (put_objfile_before): Update comment.
10729         (add_separate_debug_objfile): Likewise.
10730         (free_all_objfiles): Use all_objfiles_safe.
10731         (objfile_purge_solibs): Likewise.
10732
10733 2019-01-09  Tom Tromey  <tom@tromey.com>
10734
10735         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10736         (expand_symtab_containing_pc, lookup_static_symbol)
10737         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10738         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10739         all_objfiles.
10740         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10741         * breakpoint.c (create_overlay_event_breakpoint)
10742         (create_longjmp_master_breakpoint)
10743         (create_std_terminate_master_breakpoint)
10744         (create_exception_master_breakpoint): Use all_objfiles.
10745         * linux-thread-db.c (try_thread_db_load_from_pdir)
10746         (has_libpthread): Use all_objfiles.
10747         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10748         * linespec.c (iterate_over_all_matching_symtabs)
10749         (search_minsyms_for_name): Use all_objfiles.
10750         * maint.c (maintenance_info_sections): Use all_objfiles.
10751         * main.c (captured_main_1): Use all_objfiles.
10752         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10753         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10754         * guile/scm-pretty-print.c
10755         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10756         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10757         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10758         (maintenance_print_msymbols): Use all_objfiles.
10759         * source.c (select_source_symtab): Use all_objfiles.
10760         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10761         * symfile.c (remove_symbol_file_command)
10762         (expand_symtabs_matching, map_symbol_filenames): Use
10763         all_objfiles.
10764         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10765         all_objfiles.
10766         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10767         * objc-lang.c (find_methods): Use all_objfiles.
10768         * objfiles.c (have_partial_symbols, have_full_symbols)
10769         (have_minimal_symbols, qsort_cmp)
10770         (default_iterate_over_objfiles_in_search_order): Use
10771         all_objfiles.
10772         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10773         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10774         (maintenance_check_psymtabs): Use all_objfiles.
10775         (ALL_PSYMTABS): Remove.
10776         * compile/compile-object-run.c (do_module_cleanup): Use
10777         all_objfiles.
10778         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10779         * cp-support.c (add_symbol_overload_list_qualified): Use
10780         all_objfiles.
10781         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10782         Use all_objfiles.
10783         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10784         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10785         all_objfiles.
10786         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10787         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10788         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10789         Uses all_objfiles.
10790         * solib.c (solib_read_symbols): Use all_objfiles
10791
10792 2019-01-09  Tom Tromey  <tom@tromey.com>
10793
10794         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10795         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10796         all_objfiles.
10797         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10798         * symmisc.c (print_symbol_bcache_statistics)
10799         (print_objfile_statistics, maintenance_print_objfiles)
10800         (maintenance_info_symtabs, maintenance_check_symtabs)
10801         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10802         all_objfiles.
10803         * source.c (forget_cached_source_info): Use all_objfiles.
10804         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10805         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10806         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10807         * objfiles.c (update_section_map): Use all_objfiles.
10808         (shared_objfile_contains_address_p): Likewise.
10809         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10810         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10811
10812 2019-01-09  Tom Tromey  <tom@tromey.com>
10813
10814         * common/next-iterator.h: New file.
10815         * objfiles.h (class all_objfiles): New.
10816         (struct objfile_iterator): New.
10817
10818 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10819
10820         * NEWS: Move the description of the changed "frame", "select-frame",
10821          and "info frame" commands to the Changed commands section.
10822
10823 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10824
10825         * gdbtypes.c (check_stub_method_group): Remove handling of old
10826         mangling schemes.
10827         * linespec.c (find_methods): Likewise.
10828         * stabsread.c (read_member_functions): Likewise.
10829         * valops.c (search_struct_method): Likewise.
10830         (value_struct_elt_for_reference): Likewise.
10831         * NEWS: Mention this change.
10832
10833 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10834
10835         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10836         print_source_lines.
10837         * source.c (print_source_lines_base): Update line number check.
10838         (print_source_lines): New function.
10839         (source_lines_range::source_lines_range): New function.
10840         * source.h (class source_lines_range): New class.
10841         (print_source_lines): New declaration.
10842
10843 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10844
10845         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10846
10847 2019-01-08  Tom Tromey  <tom@tromey.com>
10848             Simon Marchi  <simon.marchi@ericsson.com>
10849
10850         PR gdb/24060
10851         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10852         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10853         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10854         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10855         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10856         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10857
10858 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10859
10860         * source.c (select_source_symtab): Move header comment to
10861         declaration in source.h.
10862         (forget_cached_source_info_for_objfile): Likewise.
10863         (forget_cached_source_info): Likewise.
10864         (identify_source_line): Likewise.
10865         * source.h (identify_source_line): Move declaration from symtab.h
10866         and add comment from source.c
10867         (print_source_lines): Likewise.
10868         (forget_cached_source_info_for_objfile): Likewise.
10869         (forget_cached_source_info): Likewise.
10870         (select_source_symtab): Likewise.
10871         (enum print_source_lines_flag): Move definition from symtab.h.
10872         * symtab.h (identify_source_line): Move declaration to source.h.
10873         (print_source_lines): Likewise.
10874         (forget_cached_source_info_for_objfile): Likewise.
10875         (forget_cached_source_info): Likewise.
10876         (select_source_symtab): Likewise.
10877         (enum print_source_lines_flag): Move definition to source.h.
10878         * tui/tui-hooks.c: Add 'source.h' include.
10879
10880 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10881
10882         * source.c (print_source_lines_base): Handle requests to print
10883         reverse line number sequences, and guard against empty lines
10884         string.
10885
10886 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10887
10888         * source.c (print_source_lines_base): Fix skip of '\r' if next
10889         character is '\n'.
10890
10891 2019-01-06  Tom Tromey  <tom@tromey.com>
10892
10893         * c-exp.y (struct c_parse_state) <macro_original_text,
10894         expansion_obstack>: New member.
10895         (macro_original_text, expansion_obstack): Remove globals.
10896         (scan_macro_expansion, scanning_macro_expansion)
10897         (finished_macro_expansion): Update.
10898         (scan_macro_cleanup): Remove.
10899         (yylex, c_parse): Update.
10900
10901 2019-01-06  Tom Tromey  <tom@tromey.com>
10902
10903         * c-exp.y (struct c_parse_state) <strings>: New member.
10904         (operator_stoken): Update.
10905
10906 2019-01-06  Tom Tromey  <tom@tromey.com>
10907
10908         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10909         (union type_stack_elt) <typelist_val>: Now a pointer to
10910         std::vector.
10911         (type_stack_cleanup): Don't declare.
10912         (push_typelist): Update.
10913         * parse.c (pop_typelist): Return a std::vector.
10914         (push_typelist): Take a std::vector.
10915         (follow_types): Update.  Do not free args.
10916         (type_stack_cleanup): Remove.
10917         * c-exp.y (struct c_parse_state): New.
10918         (cpstate): New global.
10919         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10920         (nonempty_typelist): Update.
10921         (func_mod): Create a new vector.
10922         (c_parse): Create a c_parse_state.
10923         (check_parameter_typelist): Do not delete params.
10924         (function_method): Update.  Do not delete type_list.
10925
10926 2019-01-06  Tom Tromey  <tom@tromey.com>
10927
10928         PR gdb/28155:
10929         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10930         check_typedef.
10931         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10932         (print_return_value): Likewise.
10933
10934 2019-01-05  Tom Tromey  <tom@tromey.com>
10935
10936         * contrib/cleanup_check.py: Remove.
10937         * contrib/gcc-with-excheck: Remove.
10938         * contrib/exsummary.py: Remove.
10939         * contrib/excheck.py: Remove.
10940
10941 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10942
10943         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10944         NULL. Initialize tpprev to NULL instead of assigning it
10945         to NULL on the next statement.
10946         * windows-nat.c (windows_delete_thread): Remove check for
10947         main_thread_id before printing thread exit notifications.
10948         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10949         Remove thread ID check against main_thread_id.
10950         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10951         windows_delete_thread.
10952         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10953
10954 2019-01-04  Tom Tromey  <tom@tromey.com>
10955
10956         * compile/compile.c (_initialize_compile): Use upper case for
10957         metasyntactic variables.
10958         * symmisc.c (_initialize_symmisc): Use upper case for
10959         metasyntactic variables.
10960         * psymtab.c (_initialize_psymtab): Use upper case for
10961         metasyntactic variables.
10962         * demangle.c (demangle_command): Use upper case for metasyntactic
10963         variables.
10964         (_initialize_demangler): Likewise.
10965         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10966         variables.
10967
10968 2019-01-03  Tom Tromey  <tom@tromey.com>
10969
10970         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10971
10972 2019-01-03  Tom Tromey  <tom@tromey.com>
10973
10974         * python/py-symtab.c (salpy_str): Update.
10975         (struct salpy_sal_object) <symtab>: Now a PyObject.
10976         (salpy_dealloc): Update.
10977         (del_objfile_sal): Use gdbpy_ref.
10978
10979 2019-01-03  Tom Tromey  <tom@tromey.com>
10980
10981         * python/py-type.c (convert_field): Use new_reference.  Return
10982         gdbpy_ref.
10983         (make_fielditem): Return gdbpy_ref.
10984         (typy_fields): Update.
10985         (typy_getitem): Update.
10986         (field_name): Return gdbpy_ref.  Use new_reference.
10987         (typy_iterator_iternext): Update.
10988
10989 2019-01-03  Tom Tromey  <tom@tromey.com>
10990
10991         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10992
10993 2019-01-03  Tom Tromey  <tom@tromey.com>
10994
10995         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10996         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10997         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10998         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10999         (pspy_set_type_printers): Likewise.
11000         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11001         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11002         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11003         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11004         (objfpy_set_type_printers): Likewise.
11005
11006 2019-01-03  Tom Tromey  <tom@tromey.com>
11007
11008         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11009         (gdbpy_print_stack): Use gdbpy_err_fetch.
11010         * python/python-internal.h (class gdbpy_err_fetch): New class.
11011         (class gdbpy_enter) <m_error_type, m_error_value,
11012         m_error_traceback>: Remove.
11013         <m_error>: New member.
11014         (gdbpy_exception_to_string): Don't declare.
11015         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11016         * python/py-value.c (convert_value_from_python): Use
11017         gdbpy_err_fetch.
11018         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11019         gdbpy_exception_to_string.
11020         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11021         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11022         gdbpy_err_fetch.
11023
11024 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11025
11026         * linux-nat.c (delete_lwp_cleanup): Delete.
11027         (struct lwp_deleter): New struct.
11028         (lwp_info_up): New typedef.
11029         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11030         lwp_info_up.
11031
11032 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11033
11034         * linux-fork.c (class scoped_switch_fork_info): New class.
11035         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11036
11037 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11038
11039         * valops.c (find_overload_match): Remove use of null_cleanup, and
11040         calls to do_cleanups.
11041
11042 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11043
11044         * compile/compile-cplus-types.c
11045         (compile_cplus_instance::decl_name): Handle changes to
11046         cp_func_name.
11047         * cp-support.c (cp_func_name): Update header comment, update
11048         return type.
11049         * cp-support.h (cp_func_name): Update return type in declaration.
11050         * valops.c (find_overload_match): Move temp_func local to top
11051         level of function and change its type.  Use temp_func to hold and
11052         delete temporary string obtained from cp_func_name.
11053
11054 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11055
11056         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11057         gdb::char_vector, remove cleanup, and update uses of `msg`.
11058
11059 2019-01-03  Jim Wilson  <jimw@sifive.com>
11060
11061         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11062
11063 2019-01-02  Tom Tromey  <tom@tromey.com>
11064
11065         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11066         (tdesc_parse_xml): Remove cleanups.
11067         * target-descriptions.h (make_cleanup_free_target_description):
11068         Don't declare.
11069         (target_desc_deleter): New struct.
11070         (target_desc_up): New typedef.
11071         * target-descriptions.c (target_desc_deleter::operator()): Rename
11072         from free_target_description.
11073         (make_cleanup_free_target_description): Remove.
11074
11075 2019-01-02  Tom Tromey  <tom@tromey.com>
11076
11077         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11078         constructor, destructor.
11079         (linespec_parser): Remove typedef.
11080         (~linespec_parser): Rename from linespec_parser_delete.
11081         (linespec_lex_to_end, linespec_complete_label)
11082         (linespec_complete): Update.
11083         (decode_line_full): Remove cleanups.
11084         (decode_line_1): Update.
11085
11086 2019-01-02  Tom Tromey  <tom@tromey.com>
11087
11088         * python/python-internal.h (inferior_to_inferior_object): Change
11089         return type.
11090         * python/py-exitedevent.c (create_exited_event_object): Update.
11091         * python/py-inferior.c (inferior_to_inferior_object): Return
11092         gdbpy_ref.
11093         (python_new_inferior, python_inferior_deleted)
11094         (thread_to_thread_object, delete_thread_object)
11095         (build_inferior_list, gdbpy_selected_inferior): Update.
11096         * python/py-infthread.c (create_thread_object): Update.  Also fail
11097         if inferior_to_inferior_object fails.
11098
11099 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11100
11101         * inferior.h (class inferior) <displaced_step_state>: New field.
11102         * infrun.h (struct displaced_step_state): Move here from
11103         infrun.c.  Initialize fields, add constructor.
11104         <inf>: Remove field.
11105         <reset>: New method.
11106         * infrun.c (struct displaced_step_inferior_state): Move to
11107         infrun.h.
11108         (displaced_step_inferior_states): Remove.
11109         (get_displaced_stepping_state): Adust.
11110         (displaced_step_in_progress_any_inferior): Adjust.
11111         (displaced_step_in_progress_thread): Adjust.
11112         (displaced_step_in_progress): Adjust.
11113         (add_displaced_stepping_state): Remove.
11114         (get_displaced_step_closure_by_addr): Adjust.
11115         (remove_displaced_stepping_state): Remove.
11116         (infrun_inferior_exit): Call displaced_step_state.reset.
11117         (use_displaced_stepping): Don't check for NULL.
11118         (displaced_step_prepare_throw): Call
11119         get_displaced_stepping_state.
11120         (displaced_step_fixup): Don't check for NULL.
11121         (prepare_for_detach): Don't check for NULL.
11122
11123 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11124
11125         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11126          in case of call that did not complete.
11127
11128 2019-01-02  Andrey Utkin  <autkin@undo.io>
11129
11130         * symfile.c (find_separate_debug_file): Fix search of debug files for
11131         remote debuggee.
11132
11133 2019-01-02  Tom Tromey  <tom@tromey.com>
11134
11135         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11136         indentation.
11137         * python/py-frame.c (frapy_older): Remove cast.
11138         (frapy_newer): Likewise.
11139         * python/py-breakpoint.c (local_setattro): Remove cast.
11140         * python/py-arch.c (archpy_name): Remove local variable.
11141         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11142
11143 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11144
11145         * unittests/basic_string_view/element_access/char/empty.cc:
11146         Fix year range in copyright header.
11147
11148 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11149
11150         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11151         Delete.
11152         <operator==>: Update with for removed field.
11153         <hash>: Likewise.
11154         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11155         <isa_features>: ...this.
11156         <abi_features>: New field.
11157         (riscv_isa_flen): Update comment.
11158         (riscv_abi_xlen): New declaration.
11159         (riscv_abi_flen): New declaration.
11160         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11161         isa_features.
11162         (riscv_abi_xlen): New function.
11163         (riscv_isa_flen): Update to get answer from isa_features.
11164         (riscv_abi_flen): New function.
11165         (riscv_has_fp_abi): Update to get answer from abi_features.
11166         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11167         xlen and flen.
11168         (riscv_call_info) <xlen, flen>: Update comment.
11169         (riscv_call_arg_struct): Remove invalid assertions
11170         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11171         is removed.
11172         (riscv_gdbarch_init): Gather isa features and abi features
11173         separately, ensure both match on the gdbarch when reusing an old
11174         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11175         a target with 64-bit float hardware.
11176
11177 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11178
11179         * source.c (search_command_helper): Stop reverse search
11180         when line 1 has been searched.
11181
11182 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11183
11184         * record-full.c (record_full_base_target::close): Rewrite
11185         record_full_core_buf_list free logic.
11186
11187 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11188
11189         * break-catch-syscall.c (print_one_catch_syscall): xfree
11190         the last text.
11191
11192 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11193
11194         * top.c (print_gdb_version): Update Copyright year in version
11195         message.
11196
11197 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11198
11199         Update copyright year range in all GDB files.
11200
11201 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11202
11203         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11204
11205 For older changes see ChangeLog-2018.
11206 \f
11207 Local Variables:
11208 mode: change-log
11209 left-margin: 8
11210 fill-column: 74
11211 version-control: never
11212 coding: utf-8
11213 End:
11214