gdb/ChangeLog

   1 2019-03-14  Pedro Alves  <palves@redhat.com>
   2             Tom Tromey  <tromey@adacore.com>
   3
   4         * tui/tui-winsource.h (tui_refill_source_window): Declare.
   5         * tui/tui-winsource.c (tui_refill_source_window): New function,
   6         from...
   7         (tui_horizontal_source_scroll): ... here.  Move some logic.
   8         * cli/cli-style.c (set_style_enabled): Notify new observable.
   9         * tui/tui-hooks.c (tui_redisplay_source): New function.
  10         (tui_attach_detach_observers): Attach or detach
  11         tui_redisplay_source.
  12         * observable.h (source_styling_changed): New observable.
  13         * observable.c: Define source_styling_changed observable.
  14
  15 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  16
  17         PR/24325
  18         * source-cache.c: #undef open and close, to avoid unresolved
  19         externals during linking.
  20
  21 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
  22
  23         Support styling on native MS-Windows console
  24
  25         PR/24315
  26         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
  27         on MS-Windows if $TERM is not defined.
  28
  29         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
  30
  31         * posix-hdep.c (gdb_console_fputs):
  32         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
  33         functions.
  34         * ui-file.h (gdb_console_fputs): Add prototype.
  35
  36         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
  37         back to fputs only if the former returns zero.
  38
  39 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
  40             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  41
  42         PR gdb/8527
  43         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
  44         set_sigint_trap, clear_sigint_trap.
  45
  46 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  47
  48         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
  49         for-loop range, to avoid compiler warnings.
  50
  51         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
  52         avoid compiler warnings about unused variables.
  53
  54 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  55
  56         * NEWS: Mention end of support for native debugging on MS-Windows
  57         before XP.
  58
  59 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  60
  61         PR gdb/24292
  62         * common/netstuff.c:
  63         * gdbserver/gdbreplay.c
  64         * gdbserver/remote-utils.c:
  65         * ser-tcp.c:
  66         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
  67         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
  68         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
  69         'getaddrinfo' and 'freeaddrinfo' were not available before
  70         Windows XP, and mingw.org's MinGW headers by default define
  71         _WIN32_WINNT to 0x500.
  72
  73 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
  74
  75         * NEWS: Note minimum Python version.
  76
  77 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  78
  79         * version.in: Set GDB version number to 8.2.90.DATE-git.
  80
  81 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  82
  83         GDB 8.2.90 released.
  84
  85 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  86
  87         * version.in: Set GDB version number to 8.2.90.
  88
  89 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  90
  91         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
  92
  93 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  94
  95         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
  96         * version.in: Bump version to 8.2.90.DATE-git.
  97
  98 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
  99
 100         * aix-thread.c (ptid_cmp): Remove unused variable.
 101         (get_signaled_thread): Likewise.
 102         (store_regs_user_thread): Likewise.
 103         (store_regs_kernel_thread): Likewise.
 104         (fetch_regs_kernel_thread): Remove shadowed variable.
 105
 106 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 107
 108         * features/riscv/32bit-cpu.xml: Add register numbers.
 109         * features/riscv/32bit-fpu.c: Regenerate.
 110         * features/riscv/32bit-fpu.xml: Add register numbers.
 111         * features/riscv/64bit-cpu.xml: Add register numbers.
 112         * features/riscv/64bit-fpu.c: Regenerate.
 113         * features/riscv/64bit-fpu.xml: Add register numbers.
 114
 115 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 116
 117         * NEWS: Mention two argument form of gdb.Value constructor.
 118         * python/py-value.c (convert_buffer_and_type_to_value): New
 119         function.
 120         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 121         Add support for handling an optional second argument.  Call
 122         convert_buffer_and_type_to_value as appropriate.
 123         * python/python-internal.h (Py_buffer_deleter): New struct.
 124         (Py_buffer_up): New typedef.
 125
 126 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 127
 128         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 129         instead of releasing ownership.
 130
 131 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 132
 133         * dwarf2read.c (open_and_init_dwp_file): Call
 134         elf_numsections instead of bfd_count_sections to initialize
 135         dwp_file->num_sections.
 136
 137 2019-02-25  Tom Tromey  <tromey@adacore.com>
 138
 139         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 140
 141 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 142
 143         * gcore.in: Add '--readnever' option when invoking GDB.
 144
 145 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 146
 147         * MAINTAINERS: Update my email address.
 148
 149 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 150
 151         * build-id.c (build_id_to_debug_bfd_1): New function.
 152         (build_id_to_debug_bfd): Look for separate debug file in
 153         sysroot.
 154
 155 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 156
 157         * gdbarch.sh: Update the copyright year range that is placed into
 158         generated files.
 159
 160 2019-02-22  Keith Seitz  <keiths@redhat.com>
 161
 162         PR symtab/23853
 163         * linespec.c (create_sals_line_offset): Search for the default
 164         symtab's filename instead of its fullname.
 165
 166 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 167
 168         * NEWS: Update style defaults.
 169
 170 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 171
 172         * main.c (captured_main_1): Disable styling in batch mode.
 173
 174 2019-02-20  Tom Tromey  <tom@tromey.com>
 175
 176         * symtab.c (symtab_symbol_info): Fix typos.
 177
 178 2019-02-20  Tom Tromey  <tromey@adacore.com>
 179
 180         * findcmd.c (_initialize_mem_search): Use upper case for
 181         metasyntactic variables.
 182
 183 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 184
 185         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 186         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 187
 188 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 189
 190         * top.h (source_file_name): Change to std::string.
 191         * top.c (source_file_name): Likewise.
 192         (command_line_input): Adjust.
 193         * cli/cli-script.c (script_from_file): Adjust.
 194
 195 2019-02-19  Tom Tromey  <tromey@adacore.com>
 196
 197         * ravenscar-thread.c
 198         (ravenscar_thread_target::update_thread_list): Don't call
 199         ada_build_task_list.
 200         * ada-lang.h (ada_build_task_list): Don't declare.
 201         * ada-tasks.c (struct ada_tasks_inferior_data)
 202         <task_list_valid_p>: Now bool.
 203         (read_known_tasks, ada_task_list_changed)
 204         (ada_tasks_invalidate_inferior_data): Update.
 205         (read_known_tasks_array): Return bool.
 206         (read_known_tasks_list): Likewise.
 207         (read_known_tasks): Return void.
 208         (ada_build_task_list): Now static.
 209
 210 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 211
 212         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 213         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 214
 215 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 216
 217         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 218         variant for ada_tasks_pspace_data_handle and
 219         ada_tasks_inferior_data_handle.
 220         (ada_tasks_pspace_data_cleanup): New function.
 221         (ada_tasks_inferior_data_cleanup): New function.
 222
 223 2019-02-17  Tom Tromey  <tom@tromey.com>
 224
 225         * macrotab.h (macro_source_fullname): Return a std::string.
 226         * macrotab.c (macro_include, check_for_redefinition)
 227         (macro_undef, macro_lookup_definition, foreach_macro)
 228         (foreach_macro_in_scope): Update.
 229         (macro_source_fullname): Return a std::string.
 230         * macrocmd.c (show_pp_source_pos): Update.
 231
 232 2019-02-17  Tom Tromey  <tom@tromey.com>
 233
 234         * macrocmd.c (show_pp_source_pos): Style the file names.
 235
 236 2019-02-17  Tom Tromey  <tom@tromey.com>
 237
 238         PR tui/24197:
 239         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 240
 241 2019-02-17  Tom Tromey  <tom@tromey.com>
 242
 243         * ada-lang.c (user_select_syms): Use filtered printing.
 244         * utils.c (wrap_style): New global.
 245         (desired_style): Remove.
 246         (emit_style_escape): Add stream parameter.
 247         (set_output_style, reset_terminal_style, prompt_for_continue):
 248         Update.
 249         (flush_wrap_buffer): Only flush gdb_stdout.
 250         (wrap_here): Set wrap_style.
 251         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 252         treat escape sequences as a character.  Change when wrap buffer is
 253         flushed.
 254         (fputs_styled): Do not set the output style when the default is
 255         requested.
 256         * ui-style.h (struct ui_file_style) <is_default>: New method.
 257         * source.c (print_source_lines_base): Emit escape sequences in one
 258         piece.
 259
 260 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 261
 262         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 263         integers and enumeration types.
 264
 265 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 266
 267         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 268         instead of lookup_symbol_in_language
 269         (do_exact_match): New function.
 270         (ada_get_symbol_name_matcher): Return do_exact_match when
 271         doing a verbatim match.
 272
 273 2019-02-15  Tom Tromey  <tromey@adacore.com>
 274
 275         * ravenscar-thread.c (ravenscar_thread_target::resume)
 276         (ravenscar_thread_target::wait): Special case wildcard requests.
 277
 278 2019-02-15  Tom Tromey  <tromey@adacore.com>
 279
 280         * ravenscar-thread.c (base_ptid): Remove.
 281         (struct ravenscar_thread_target) <close>: New method.
 282         <m_base_ptid>: New member.
 283         <update_inferior_ptid, active_task, task_is_currently_active,
 284         runtime_initialized>: Declare methods.
 285         <ravenscar_thread_target>: Add constructor.
 286         (ravenscar_thread_target::task_is_currently_active)
 287         (ravenscar_thread_target::update_inferior_ptid)
 288         (ravenscar_runtime_initialized): Rename.  Now methods.
 289         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 290         (ravenscar_thread_target::update_thread_list): Update.
 291         (ravenscar_thread_target::active_task): Now method.
 292         (ravenscar_thread_target::store_registers)
 293         (ravenscar_thread_target::prepare_to_store)
 294         (ravenscar_thread_target::prepare_to_store)
 295         (ravenscar_thread_target::mourn_inferior): Update.
 296         (ravenscar_inferior_created): Use "new" to create target.
 297         (ravenscar_thread_target::get_ada_task_ptid): Update.
 298         (_initialize_ravenscar): Don't initialize base_ptid.
 299         (ravenscar_ops): Remove global.
 300
 301 2019-02-15  Tom Tromey  <tromey@adacore.com>
 302
 303         * target.h (push_target): Declare new overload.
 304         * target.c (push_target): New overload, taking an rvalue reference.
 305         * remote.c (remote_target::open_1): Use push_target overload.
 306         * corelow.c (core_target_open): Use push_target overload.
 307
 308 2019-02-15  Tom Tromey  <tromey@adacore.com>
 309
 310         * ravenscar-thread.c (is_ravenscar_task)
 311         (ravenscar_task_is_currently_active): Return bool.
 312         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 313         (_initialize_ravenscar): Remove "(void)".
 314         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 315         Return bool.
 316
 317 2019-02-15  Tom Tromey  <tromey@adacore.com>
 318
 319         * ravenscar-thread.c (ravenscar_runtime_initializer)
 320         (has_ravenscar_runtime, get_running_thread_id)
 321         (ravenscar_thread_target::resume): Fix indentation.
 322
 323 2019-02-15  Tom Tromey  <tromey@adacore.com>
 324
 325         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 326         from ravenscar_arch_ops.
 327         (sparc_ravenscar_ops::fetch_registers)
 328         (sparc_ravenscar_ops::store_registers): Now methods.
 329         (sparc_ravenscar_prepare_to_store): Remove.
 330         (sparc_ravenscar_ops): Redefine.
 331         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 332         methods and destructor.  Remove members.
 333         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 334         (ravenscar_thread_target::store_registers)
 335         (ravenscar_thread_target::prepare_to_store): Update.
 336         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 337         Remove.
 338         (struct ppc_ravenscar_powerpc_ops): Derive from
 339         ravenscar_arch_ops.
 340         (ppc_ravenscar_powerpc_ops::fetch_registers)
 341         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 342         (ppc_ravenscar_powerpc_ops): Redefine.
 343         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 344         (ppc_ravenscar_e500_ops::fetch_registers)
 345         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 346         (ppc_ravenscar_e500_ops): Redefine.
 347         * aarch64-ravenscar-thread.c
 348         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 349         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 350         (aarch64_ravenscar_fetch_registers)
 351         (aarch64_ravenscar_store_registers): Now methods.
 352         (aarch64_ravenscar_ops): Redefine.
 353
 354 2019-02-15  Tom Tromey  <tromey@adacore.com>
 355
 356         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 357         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 358         (ravenscar_thread_target::stopped_by_watchpoint)
 359         (ravenscar_thread_target::stopped_data_address)
 360         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 361
 362 2019-02-15  Tom Tromey  <tromey@adacore.com>
 363
 364         * ravenscar-thread.c: Fix some typos.
 365
 366 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 367             Tom Tromey  <tromey@adacore.com>
 368
 369         * ada-lang.c (ada_exception_sal): Change addr_string to a
 370         std::string.
 371         (create_ada_exception_catchpoint): Update.
 372
 373 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 374             Tom Tromey  <tromey@adacore.com>
 375
 376         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 377         (bp_location_ops): Remove.
 378         (base_breakpoint_allocate_location): Update.
 379         (free_bp_location): Update.
 380         * ada-lang.c (class ada_catchpoint_location)
 381         <ada_catchpoint_location>: Remove ops parameter.
 382         (ada_catchpoint_location_dtor): Remove.
 383         (ada_catchpoint_location_ops): Remove.
 384         (allocate_location_exception): Update.
 385         * breakpoint.h (struct bp_location_ops): Remove.
 386         (class bp_location) <bp_location>: Remove bp_location_ops
 387         parameter.
 388         <~bp_location>: Add destructor.
 389         <ops>: Remove.
 390
 391 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 392             Pedro Alves  <palves@redhat.com>
 393
 394         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 395         'PATH_MAX'.
 396
 397 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 398             Samuel Thibault  <samuel.thibault@gnu.org>
 399             Thomas Schwinge  <thomas@codesourcery.com>
 400
 401         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 402         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 403
 404 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 405
 406         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 407         (check_empty): Use "const char *".
 408
 409         * gnu-nat.c (gnu_nat_target::detach): Instead of
 410         'detach_inferior (pid)' call
 411         'detach_inferior (find_inferior_pid (pid))'.
 412
 413         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 414         'nat/fork-inferior.o'.
 415         * gnu-nat.c: #include "nat/fork-inferior.h".
 416
 417         * gnu-nat.c (gnu_nat_target::detach): Instead of
 418         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 419         * gnu-nat.h: #include "inf-child.h".
 420         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 421         'i386_gnu_nat_target::fetch_registers'.
 422         (gnu_store_registers): Rename/move to
 423         'i386_gnu_nat_target::store_registers'.
 424
 425         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 426         * gnu-nat.h (mach_thread_info): New function.
 427         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 428
 429         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 430
 431 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 432
 433         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 434
 435 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 436
 437         * windows-nat.c (windows_add_thread): Add new parameter
 438         "main_thread_p" with default value set to false.  Update
 439         function documentation as well as all callers.
 440         (windows_delete_thread): Likewise.
 441         (fake_create_process): Update call to windows_add_thread.
 442         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 443         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 444         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 445         call to windows_delete_thread.
 446
 447 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 448
 449         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 450
 451 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 452
 453         * symfile.c (find_separate_debug_file): Use canonical path of
 454         sysroot with child_path instead of gdb_sysroot if it is valid.
 455
 456 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 457
 458         * symfile.c (find_separate_debug_file): Use child_path to
 459         determine if an object file is under a sysroot.
 460
 461 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 462
 463         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 464         unittests/child-path-selftests.c.
 465         * common/pathstuff.c (child_path): New function.
 466         * common/pathstuff.h (child_path): New prototype.
 467         * unittests/child-path-selftests.c: New file.
 468
 469 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 470
 471         * symfile.c (find_separate_debug_file): Look for separate debug
 472         files in debug directories under the sysroot.
 473
 474 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 475
 476         * symtab.h (struct minimal_symbol data_p): New const method.
 477         (struct minimal_symbol text_p): Likewise.
 478         * symtab.c (output_source_filename): Use file name style
 479         to print file name.
 480         (print_symbol_info): Likewise.
 481         (print_msymbol_info): Use address style to print addresses.
 482         Use function name style to print executable text symbols.
 483         (expand_symtab_containing_pc): Use data_p.
 484         (find_pc_sect_compunit_symtab): Likewise.
 485
 486 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 487
 488         * breakpoint.c (describe_other_breakpoints): Use address style
 489         to print addresses.
 490         (say_where): Likewise.
 491
 492 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 493
 494         * ada-typeprint.c (print_func_type): Print function name
 495         style to print function name.
 496         * c-typeprint.c (c_print_type_1): Likewise.
 497
 498 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 499
 500         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 501         for execve.
 502
 503 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 504
 505         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 506         type_stack.
 507
 508 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 509
 510         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 511         TYPE_CODE_REF types.
 512
 513 2019-02-08  Jim Wilson  <jimw@sifive.com>
 514
 515         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 516         (riscv_linux_fregset): New.
 517         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 518
 519 2019-02-07  Tom Tromey  <tom@tromey.com>
 520
 521         * thread.c (thread_cancel_execution_command): Update.
 522         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 523         methods.
 524         (struct thread_fsm_ops): Remove.
 525         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 526         (thread_fsm_should_stop, thread_fsm_return_value)
 527         (thread_fsm_set_finished, thread_fsm_finished_p)
 528         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 529         Don't declare.
 530         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 531         * infrun.c (clear_proceed_status_thread)
 532         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 533         (print_stop_event): Update.
 534         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 535         Add constructor.
 536         (step_command_fsm_ops): Remove.
 537         (new_step_command_fsm): Remove.
 538         (step_1): Update.
 539         (step_command_fsm::should_stop): Rename from
 540         step_command_fsm_should_stop.
 541         (step_command_fsm::clean_up): Rename from
 542         step_command_fsm_clean_up.
 543         (step_command_fsm::do_async_reply_reason): Rename from
 544         step_command_fsm_async_reply_reason.
 545         (struct until_next_fsm): Inherit from thread_fsm.  Add
 546         constructor.
 547         (until_next_fsm_ops): Remove.
 548         (new_until_next_fsm): Remove.
 549         (until_next_fsm::should_stop): Rename from
 550         until_next_fsm_should_stop.
 551         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 552         (until_next_fsm::do_async_reply_reason): Rename from
 553         until_next_fsm_async_reply_reason.
 554         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 555         constructor.  Change type of breakpoint.
 556         (finish_command_fsm_ops): Remove.
 557         (new_finish_command_fsm): Remove.
 558         (finish_command_fsm::should_stop): Rename from
 559         finish_command_fsm_should_stop.
 560         (finish_command_fsm::clean_up): Rename from
 561         finish_command_fsm_clean_up.
 562         (finish_command_fsm::return_value): Rename from
 563         finish_command_fsm_return_value.
 564         (finish_command_fsm::do_async_reply_reason): Rename from
 565         finish_command_fsm_async_reply_reason.
 566         (finish_command): Update.
 567         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 568         Add constructor.
 569         (call_thread_fsm_ops): Remove.
 570         (call_thread_fsm::call_thread_fsm): Rename from
 571         new_call_thread_fsm.
 572         (call_thread_fsm::should_stop): Rename from
 573         call_thread_fsm_should_stop.
 574         (call_thread_fsm::should_notify_stop): Rename from
 575         call_thread_fsm_should_notify_stop.
 576         (run_inferior_call, call_function_by_hand_dummy): Update.
 577         * cli/cli-interp.c (should_print_stop_to_console): Update.
 578         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 579         Add constructor.  Change type of location_breakpoint,
 580         caller_breakpoint.
 581         (until_break_fsm_ops): Remove.
 582         (new_until_break_fsm): Remove.
 583         (until_break_fsm::should_stop): Rename from
 584         until_break_fsm_should_stop.
 585         (until_break_fsm::clean_up): Rename from
 586         until_break_fsm_clean_up.
 587         (until_break_fsm::do_async_reply_reason): Rename from
 588         until_break_fsm_async_reply_reason.
 589         (until_break_command): Update.
 590         * thread-fsm.c: Remove.
 591         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 592
 593 2019-02-07  Tom Tromey  <tom@tromey.com>
 594
 595         * yy-remap.h: Add include guard.
 596         * xtensa-tdep.h: Add include guard.
 597         * xcoffread.h: Rename include guard.
 598         * varobj-iter.h: Add include guard.
 599         * tui/tui.h: Rename include guard.
 600         * tui/tui-winsource.h: Rename include guard.
 601         * tui/tui-wingeneral.h: Rename include guard.
 602         * tui/tui-windata.h: Rename include guard.
 603         * tui/tui-win.h: Rename include guard.
 604         * tui/tui-stack.h: Rename include guard.
 605         * tui/tui-source.h: Rename include guard.
 606         * tui/tui-regs.h: Rename include guard.
 607         * tui/tui-out.h: Rename include guard.
 608         * tui/tui-layout.h: Rename include guard.
 609         * tui/tui-io.h: Rename include guard.
 610         * tui/tui-hooks.h: Rename include guard.
 611         * tui/tui-file.h: Rename include guard.
 612         * tui/tui-disasm.h: Rename include guard.
 613         * tui/tui-data.h: Rename include guard.
 614         * tui/tui-command.h: Rename include guard.
 615         * tic6x-tdep.h: Add include guard.
 616         * target/waitstatus.h: Rename include guard.
 617         * target/wait.h: Rename include guard.
 618         * target/target.h: Rename include guard.
 619         * target/resume.h: Rename include guard.
 620         * target-float.h: Rename include guard.
 621         * stabsread.h: Add include guard.
 622         * rs6000-tdep.h: Add include guard.
 623         * riscv-fbsd-tdep.h: Add include guard.
 624         * regformats/regdef.h: Rename include guard.
 625         * record.h: Rename include guard.
 626         * python/python.h: Rename include guard.
 627         * python/python-internal.h: Rename include guard.
 628         * python/py-stopevent.h: Rename include guard.
 629         * python/py-ref.h: Rename include guard.
 630         * python/py-record.h: Rename include guard.
 631         * python/py-record-full.h: Rename include guard.
 632         * python/py-record-btrace.h: Rename include guard.
 633         * python/py-instruction.h: Rename include guard.
 634         * python/py-events.h: Rename include guard.
 635         * python/py-event.h: Rename include guard.
 636         * procfs.h: Add include guard.
 637         * proc-utils.h: Add include guard.
 638         * p-lang.h: Add include guard.
 639         * or1k-tdep.h: Rename include guard.
 640         * observable.h: Rename include guard.
 641         * nto-tdep.h: Rename include guard.
 642         * nat/x86-linux.h: Rename include guard.
 643         * nat/x86-linux-dregs.h: Rename include guard.
 644         * nat/x86-gcc-cpuid.h: Add include guard.
 645         * nat/x86-dregs.h: Rename include guard.
 646         * nat/x86-cpuid.h: Rename include guard.
 647         * nat/ppc-linux.h: Rename include guard.
 648         * nat/mips-linux-watch.h: Rename include guard.
 649         * nat/linux-waitpid.h: Rename include guard.
 650         * nat/linux-ptrace.h: Rename include guard.
 651         * nat/linux-procfs.h: Rename include guard.
 652         * nat/linux-osdata.h: Rename include guard.
 653         * nat/linux-nat.h: Rename include guard.
 654         * nat/linux-namespaces.h: Rename include guard.
 655         * nat/linux-btrace.h: Rename include guard.
 656         * nat/glibc_thread_db.h: Rename include guard.
 657         * nat/gdb_thread_db.h: Rename include guard.
 658         * nat/gdb_ptrace.h: Rename include guard.
 659         * nat/fork-inferior.h: Rename include guard.
 660         * nat/amd64-linux-siginfo.h: Rename include guard.
 661         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 662         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 663         * nat/aarch64-linux.h: Rename include guard.
 664         * nat/aarch64-linux-hw-point.h: Rename include guard.
 665         * mn10300-tdep.h: Add include guard.
 666         * mips-linux-tdep.h: Add include guard.
 667         * mi/mi-parse.h: Rename include guard.
 668         * mi/mi-out.h: Rename include guard.
 669         * mi/mi-main.h: Rename include guard.
 670         * mi/mi-interp.h: Rename include guard.
 671         * mi/mi-getopt.h: Rename include guard.
 672         * mi/mi-console.h: Rename include guard.
 673         * mi/mi-common.h: Rename include guard.
 674         * mi/mi-cmds.h: Rename include guard.
 675         * mi/mi-cmd-break.h: Rename include guard.
 676         * m2-lang.h: Add include guard.
 677         * location.h: Rename include guard.
 678         * linux-record.h: Rename include guard.
 679         * linux-nat.h: Add include guard.
 680         * linux-fork.h: Add include guard.
 681         * i386-darwin-tdep.h: Rename include guard.
 682         * hppa-linux-offsets.h: Add include guard.
 683         * guile/guile.h: Rename include guard.
 684         * guile/guile-internal.h: Rename include guard.
 685         * gnu-nat.h: Rename include guard.
 686         * gdb-stabs.h: Rename include guard.
 687         * frv-tdep.h: Add include guard.
 688         * f-lang.h: Add include guard.
 689         * event-loop.h: Add include guard.
 690         * darwin-nat.h: Rename include guard.
 691         * cp-abi.h: Rename include guard.
 692         * config/sparc/nm-sol2.h: Rename include guard.
 693         * config/nm-nto.h: Rename include guard.
 694         * config/nm-linux.h: Add include guard.
 695         * config/i386/nm-i386gnu.h: Rename include guard.
 696         * config/djgpp/nl_types.h: Rename include guard.
 697         * config/djgpp/langinfo.h: Rename include guard.
 698         * compile/gcc-cp-plugin.h: Add include guard.
 699         * compile/gcc-c-plugin.h: Add include guard.
 700         * compile/compile.h: Rename include guard.
 701         * compile/compile-object-run.h: Rename include guard.
 702         * compile/compile-object-load.h: Rename include guard.
 703         * compile/compile-internal.h: Rename include guard.
 704         * compile/compile-cplus.h: Rename include guard.
 705         * compile/compile-c.h: Rename include guard.
 706         * common/xml-utils.h: Rename include guard.
 707         * common/x86-xstate.h: Rename include guard.
 708         * common/version.h: Rename include guard.
 709         * common/vec.h: Rename include guard.
 710         * common/tdesc.h: Rename include guard.
 711         * common/selftest.h: Rename include guard.
 712         * common/scoped_restore.h: Rename include guard.
 713         * common/scoped_mmap.h: Rename include guard.
 714         * common/scoped_fd.h: Rename include guard.
 715         * common/safe-iterator.h: Rename include guard.
 716         * common/run-time-clock.h: Rename include guard.
 717         * common/refcounted-object.h: Rename include guard.
 718         * common/queue.h: Rename include guard.
 719         * common/ptid.h: Rename include guard.
 720         * common/print-utils.h: Rename include guard.
 721         * common/preprocessor.h: Rename include guard.
 722         * common/pathstuff.h: Rename include guard.
 723         * common/observable.h: Rename include guard.
 724         * common/netstuff.h: Rename include guard.
 725         * common/job-control.h: Rename include guard.
 726         * common/host-defs.h: Rename include guard.
 727         * common/gdb_wait.h: Rename include guard.
 728         * common/gdb_vecs.h: Rename include guard.
 729         * common/gdb_unlinker.h: Rename include guard.
 730         * common/gdb_unique_ptr.h: Rename include guard.
 731         * common/gdb_tilde_expand.h: Rename include guard.
 732         * common/gdb_sys_time.h: Rename include guard.
 733         * common/gdb_string_view.h: Rename include guard.
 734         * common/gdb_splay_tree.h: Rename include guard.
 735         * common/gdb_setjmp.h: Rename include guard.
 736         * common/gdb_ref_ptr.h: Rename include guard.
 737         * common/gdb_optional.h: Rename include guard.
 738         * common/gdb_locale.h: Rename include guard.
 739         * common/gdb_assert.h: Rename include guard.
 740         * common/filtered-iterator.h: Rename include guard.
 741         * common/filestuff.h: Rename include guard.
 742         * common/fileio.h: Rename include guard.
 743         * common/environ.h: Rename include guard.
 744         * common/common-utils.h: Rename include guard.
 745         * common/common-types.h: Rename include guard.
 746         * common/common-regcache.h: Rename include guard.
 747         * common/common-inferior.h: Rename include guard.
 748         * common/common-gdbthread.h: Rename include guard.
 749         * common/common-exceptions.h: Rename include guard.
 750         * common/common-defs.h: Rename include guard.
 751         * common/common-debug.h: Rename include guard.
 752         * common/cleanups.h: Rename include guard.
 753         * common/buffer.h: Rename include guard.
 754         * common/btrace-common.h: Rename include guard.
 755         * common/break-common.h: Rename include guard.
 756         * cli/cli-utils.h: Rename include guard.
 757         * cli/cli-style.h: Rename include guard.
 758         * cli/cli-setshow.h: Rename include guard.
 759         * cli/cli-script.h: Rename include guard.
 760         * cli/cli-interp.h: Rename include guard.
 761         * cli/cli-decode.h: Rename include guard.
 762         * cli/cli-cmds.h: Rename include guard.
 763         * charset-list.h: Add include guard.
 764         * buildsym-legacy.h: Rename include guard.
 765         * bfin-tdep.h: Add include guard.
 766         * ax.h: Rename include guard.
 767         * arm-linux-tdep.h: Add include guard.
 768         * arm-fbsd-tdep.h: Add include guard.
 769         * arch/xtensa.h: Rename include guard.
 770         * arch/tic6x.h: Add include guard.
 771         * arch/i386.h: Add include guard.
 772         * arch/arm.h: Rename include guard.
 773         * arch/arm-linux.h: Rename include guard.
 774         * arch/arm-get-next-pcs.h: Rename include guard.
 775         * arch/amd64.h: Add include guard.
 776         * arch/aarch64-insn.h: Rename include guard.
 777         * arch-utils.h: Rename include guard.
 778         * annotate.h: Add include guard.
 779         * amd64-darwin-tdep.h: Rename include guard.
 780         * aarch64-linux-tdep.h: Add include guard.
 781         * aarch64-fbsd-tdep.h: Add include guard.
 782         * aarch32-linux-nat.h: Add include guard.
 783
 784 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 785
 786         * macrotab.c (macro_define_internal): New function that
 787         factorizes macro_define_object_internal and macro_define_function
 788         code.
 789         (macro_define_object_internal): Use macro_define_internal.
 790         (macro_define_function): Likewise.
 791
 792 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 793
 794         * macrocmd.c (extract_identifier): Return
 795         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 796         callers.
 797
 798 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 799
 800         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 801
 802 2019-02-05  Tom Tromey  <tom@tromey.com>
 803
 804         * target.c (target_stack::unpush): Move assertion earlier.
 805
 806 2019-01-30  Tom Tromey  <tom@tromey.com>
 807
 808         PR python/23615:
 809         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 810         (gdbpy_parse_and_eval): Likewise.
 811         * python/python-internal.h (gdbpy_allow_threads): New class.
 812
 813 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 814
 815         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 816         (aarch64_fbsd_fpregmap): Move earlier.
 817         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 818         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 819         instead of individual calls to trad_frame_set_reg_addr.
 820         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 821         earlier.
 822         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 823         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 824         instead of individual calls to trad_frame_set_reg_addr.
 825
 826 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 827
 828         * CONTRIBUTE: Replace contribution list with wiki link.
 829
 830 2019-01-25  Tom Tromey  <tom@tromey.com>
 831
 832         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 833
 834 2019-01-25  Tom Tromey  <tom@tromey.com>
 835
 836         * xtensa-linux-nat.c: Fix common/ includes.
 837         * xml-support.h: Fix common/ includes.
 838         * xml-support.c: Fix common/ includes.
 839         * x86-linux-nat.c: Fix common/ includes.
 840         * windows-nat.c: Fix common/ includes.
 841         * varobj.h: Fix common/ includes.
 842         * varobj.c: Fix common/ includes.
 843         * value.c: Fix common/ includes.
 844         * valops.c: Fix common/ includes.
 845         * utils.c: Fix common/ includes.
 846         * unittests/xml-utils-selftests.c: Fix common/ includes.
 847         * unittests/utils-selftests.c: Fix common/ includes.
 848         * unittests/unpack-selftests.c: Fix common/ includes.
 849         * unittests/tracepoint-selftests.c: Fix common/ includes.
 850         * unittests/style-selftests.c: Fix common/ includes.
 851         * unittests/string_view-selftests.c: Fix common/ includes.
 852         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 853         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 854         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 855         * unittests/rsp-low-selftests.c: Fix common/ includes.
 856         * unittests/parse-connection-spec-selftests.c: Fix common/
 857         includes.
 858         * unittests/optional-selftests.c: Fix common/ includes.
 859         * unittests/offset-type-selftests.c: Fix common/ includes.
 860         * unittests/observable-selftests.c: Fix common/ includes.
 861         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 862         * unittests/memrange-selftests.c: Fix common/ includes.
 863         * unittests/memory-map-selftests.c: Fix common/ includes.
 864         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 865         * unittests/function-view-selftests.c: Fix common/ includes.
 866         * unittests/environ-selftests.c: Fix common/ includes.
 867         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 868         * unittests/common-utils-selftests.c: Fix common/ includes.
 869         * unittests/cli-utils-selftests.c: Fix common/ includes.
 870         * unittests/array-view-selftests.c: Fix common/ includes.
 871         * ui-file.c: Fix common/ includes.
 872         * tui/tui-io.c: Fix common/ includes.
 873         * tracepoint.h: Fix common/ includes.
 874         * tracepoint.c: Fix common/ includes.
 875         * tracefile-tfile.c: Fix common/ includes.
 876         * top.h: Fix common/ includes.
 877         * top.c: Fix common/ includes.
 878         * thread.c: Fix common/ includes.
 879         * target/waitstatus.h: Fix common/ includes.
 880         * target/waitstatus.c: Fix common/ includes.
 881         * target.h: Fix common/ includes.
 882         * target.c: Fix common/ includes.
 883         * target-memory.c: Fix common/ includes.
 884         * target-descriptions.c: Fix common/ includes.
 885         * symtab.h: Fix common/ includes.
 886         * symfile.c: Fix common/ includes.
 887         * stap-probe.c: Fix common/ includes.
 888         * spu-linux-nat.c: Fix common/ includes.
 889         * sparc-nat.c: Fix common/ includes.
 890         * source.c: Fix common/ includes.
 891         * solib.c: Fix common/ includes.
 892         * solib-target.c: Fix common/ includes.
 893         * ser-unix.c: Fix common/ includes.
 894         * ser-tcp.c: Fix common/ includes.
 895         * ser-pipe.c: Fix common/ includes.
 896         * ser-base.c: Fix common/ includes.
 897         * selftest-arch.c: Fix common/ includes.
 898         * s12z-tdep.c: Fix common/ includes.
 899         * rust-exp.y: Fix common/ includes.
 900         * rs6000-aix-tdep.c: Fix common/ includes.
 901         * riscv-tdep.c: Fix common/ includes.
 902         * remote.c: Fix common/ includes.
 903         * remote-notif.h: Fix common/ includes.
 904         * remote-fileio.h: Fix common/ includes.
 905         * remote-fileio.c: Fix common/ includes.
 906         * regcache.h: Fix common/ includes.
 907         * regcache.c: Fix common/ includes.
 908         * record-btrace.c: Fix common/ includes.
 909         * python/python.c: Fix common/ includes.
 910         * python/py-type.c: Fix common/ includes.
 911         * python/py-inferior.c: Fix common/ includes.
 912         * progspace.h: Fix common/ includes.
 913         * producer.c: Fix common/ includes.
 914         * procfs.c: Fix common/ includes.
 915         * proc-api.c: Fix common/ includes.
 916         * printcmd.c: Fix common/ includes.
 917         * ppc-linux-nat.c: Fix common/ includes.
 918         * parser-defs.h: Fix common/ includes.
 919         * osdata.c: Fix common/ includes.
 920         * obsd-nat.c: Fix common/ includes.
 921         * nat/x86-linux.c: Fix common/ includes.
 922         * nat/x86-linux-dregs.c: Fix common/ includes.
 923         * nat/x86-dregs.h: Fix common/ includes.
 924         * nat/x86-dregs.c: Fix common/ includes.
 925         * nat/ppc-linux.c: Fix common/ includes.
 926         * nat/mips-linux-watch.h: Fix common/ includes.
 927         * nat/mips-linux-watch.c: Fix common/ includes.
 928         * nat/linux-waitpid.c: Fix common/ includes.
 929         * nat/linux-ptrace.h: Fix common/ includes.
 930         * nat/linux-ptrace.c: Fix common/ includes.
 931         * nat/linux-procfs.c: Fix common/ includes.
 932         * nat/linux-personality.c: Fix common/ includes.
 933         * nat/linux-osdata.c: Fix common/ includes.
 934         * nat/linux-namespaces.c: Fix common/ includes.
 935         * nat/linux-btrace.h: Fix common/ includes.
 936         * nat/linux-btrace.c: Fix common/ includes.
 937         * nat/fork-inferior.c: Fix common/ includes.
 938         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 939         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 940         * nat/aarch64-linux.c: Fix common/ includes.
 941         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 942         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 943         * namespace.h: Fix common/ includes.
 944         * mips-linux-tdep.c: Fix common/ includes.
 945         * minsyms.c: Fix common/ includes.
 946         * mi/mi-parse.h: Fix common/ includes.
 947         * mi/mi-main.c: Fix common/ includes.
 948         * mi/mi-cmd-env.c: Fix common/ includes.
 949         * memrange.h: Fix common/ includes.
 950         * memattr.c: Fix common/ includes.
 951         * maint.h: Fix common/ includes.
 952         * maint.c: Fix common/ includes.
 953         * main.c: Fix common/ includes.
 954         * machoread.c: Fix common/ includes.
 955         * location.c: Fix common/ includes.
 956         * linux-thread-db.c: Fix common/ includes.
 957         * linux-nat.c: Fix common/ includes.
 958         * linux-fork.c: Fix common/ includes.
 959         * inline-frame.c: Fix common/ includes.
 960         * infrun.c: Fix common/ includes.
 961         * inflow.c: Fix common/ includes.
 962         * inferior.h: Fix common/ includes.
 963         * inferior.c: Fix common/ includes.
 964         * infcmd.c: Fix common/ includes.
 965         * inf-ptrace.c: Fix common/ includes.
 966         * inf-child.c: Fix common/ includes.
 967         * ia64-linux-nat.c: Fix common/ includes.
 968         * i387-tdep.c: Fix common/ includes.
 969         * i386-tdep.c: Fix common/ includes.
 970         * i386-linux-tdep.c: Fix common/ includes.
 971         * i386-linux-nat.c: Fix common/ includes.
 972         * i386-go32-tdep.c: Fix common/ includes.
 973         * i386-fbsd-tdep.c: Fix common/ includes.
 974         * i386-fbsd-nat.c: Fix common/ includes.
 975         * guile/scm-type.c: Fix common/ includes.
 976         * guile/guile.c: Fix common/ includes.
 977         * go32-nat.c: Fix common/ includes.
 978         * gnu-nat.c: Fix common/ includes.
 979         * gdbthread.h: Fix common/ includes.
 980         * gdbarch-selftests.c: Fix common/ includes.
 981         * gdb_usleep.c: Fix common/ includes.
 982         * gdb_select.h: Fix common/ includes.
 983         * gdb_bfd.c: Fix common/ includes.
 984         * gcore.c: Fix common/ includes.
 985         * fork-child.c: Fix common/ includes.
 986         * findvar.c: Fix common/ includes.
 987         * fbsd-nat.c: Fix common/ includes.
 988         * event-top.c: Fix common/ includes.
 989         * event-loop.c: Fix common/ includes.
 990         * dwarf2read.c: Fix common/ includes.
 991         * dwarf2loc.c: Fix common/ includes.
 992         * dwarf2-frame.c: Fix common/ includes.
 993         * dwarf-index-cache.c: Fix common/ includes.
 994         * dtrace-probe.c: Fix common/ includes.
 995         * disasm-selftests.c: Fix common/ includes.
 996         * defs.h: Fix common/ includes.
 997         * csky-tdep.c: Fix common/ includes.
 998         * cp-valprint.c: Fix common/ includes.
 999         * cp-support.h: Fix common/ includes.
1000         * cp-support.c: Fix common/ includes.
1001         * corelow.c: Fix common/ includes.
1002         * completer.h: Fix common/ includes.
1003         * completer.c: Fix common/ includes.
1004         * compile/compile.c: Fix common/ includes.
1005         * compile/compile-loc2c.c: Fix common/ includes.
1006         * compile/compile-cplus-types.c: Fix common/ includes.
1007         * compile/compile-cplus-symbols.c: Fix common/ includes.
1008         * command.h: Fix common/ includes.
1009         * cli/cli-dump.c: Fix common/ includes.
1010         * cli/cli-cmds.c: Fix common/ includes.
1011         * charset.c: Fix common/ includes.
1012         * build-id.c: Fix common/ includes.
1013         * btrace.h: Fix common/ includes.
1014         * btrace.c: Fix common/ includes.
1015         * breakpoint.h: Fix common/ includes.
1016         * breakpoint.c: Fix common/ includes.
1017         * ax.h:
1018         (enum agent_op): Fix common/ includes.
1019         * ax-general.c (struct aop_map): Fix common/ includes.
1020         * ax-gdb.c: Fix common/ includes.
1021         * auxv.c: Fix common/ includes.
1022         * auto-load.c: Fix common/ includes.
1023         * arm-tdep.c: Fix common/ includes.
1024         * arch/riscv.c: Fix common/ includes.
1025         * arch/ppc-linux-common.c: Fix common/ includes.
1026         * arch/i386.c: Fix common/ includes.
1027         * arch/arm.c: Fix common/ includes.
1028         * arch/arm-linux.c: Fix common/ includes.
1029         * arch/arm-get-next-pcs.c: Fix common/ includes.
1030         * arch/amd64.c: Fix common/ includes.
1031         * arch/aarch64.c: Fix common/ includes.
1032         * arch/aarch64-insn.c: Fix common/ includes.
1033         * arch-utils.c: Fix common/ includes.
1034         * amd64-windows-tdep.c: Fix common/ includes.
1035         * amd64-tdep.c: Fix common/ includes.
1036         * amd64-sol2-tdep.c: Fix common/ includes.
1037         * amd64-obsd-tdep.c: Fix common/ includes.
1038         * amd64-nbsd-tdep.c: Fix common/ includes.
1039         * amd64-linux-tdep.c: Fix common/ includes.
1040         * amd64-linux-nat.c: Fix common/ includes.
1041         * amd64-fbsd-tdep.c: Fix common/ includes.
1042         * amd64-fbsd-nat.c: Fix common/ includes.
1043         * amd64-dicos-tdep.c: Fix common/ includes.
1044         * amd64-darwin-tdep.c: Fix common/ includes.
1045         * agent.c: Fix common/ includes.
1046         * ada-lang.h: Fix common/ includes.
1047         * ada-lang.c: Fix common/ includes.
1048         * aarch64-tdep.c: Fix common/ includes.
1049
1050 2019-01-25  Tom Tromey  <tom@tromey.com>
1051
1052         * common/create-version.sh: Use common/version.h.
1053
1054 2019-01-24  Pedro Alves  <palves@redhat.com>
1055
1056         * infrun.c (signal_stop, signal_print, signal_program)
1057         (signal_catch, signal_pass): Now arrays instead of pointers.
1058         (update_signals_program_target, do_target_resume)
1059         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1060         * linux-nat.c (linux_nat_target::pass_signals)
1061         (linux_nat_target::create_inferior, linux_nat_target::attach):
1062         Adjust.
1063         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1064         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1065         * procfs.c (procfs_target::pass_signals): Adjust.
1066         * record-full.c (record_full_target::resume): Adjust.
1067         * remote.c (remote_target::pass_signals)
1068         (remote_target::program_signals): Adjust.
1069         * target-debug.h (target_debug_print_signals): Now takes a
1070         gdb::array_view as parameter.  Adjust.
1071         * target.h (target_ops) <pass_signals, program_signals>: Replace
1072         pointer and length parameters with gdb::array_view.
1073         (target_pass_signals, target_program_signals): Likewise.
1074         * target-delegates.c: Regenerate.
1075
1076 2019-01-24  Pedro Alves  <palves@redhat.com>
1077
1078         * common/forward-scope-exit.h
1079         (forward_scope_exit::forward_scope_exit): Pass arguments to
1080         m_bind_function directly, instead of creating a std::bind and
1081         copying that.
1082
1083 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1084
1085         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1086         for static members.
1087         (pass_in_v_vfp_candidate): Likewise.
1088
1089 2019-01-23  Tom Tromey  <tom@tromey.com>
1090             Pedro Alves  <palves@redhat.com>
1091
1092         * regcache.c (class regcache_invalidator): Remove.
1093         (regcache::raw_write): Use make_scope_exit.
1094
1095 2019-01-23  Tom Tromey  <tom@tromey.com>
1096
1097         * ui-out.h (class ui_out_emit_type): Update comment.
1098
1099 2019-01-23  Tom Tromey  <tom@tromey.com>
1100
1101         * infrun.c (fetch_inferior_event): Update comment.
1102
1103 2019-01-23  Tom Tromey  <tom@tromey.com>
1104             Pedro Alves  <palves@redhat.com>
1105
1106         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1107         parameter.
1108         (fetch_inferior_event): Use SCOPE_EXIT.
1109
1110
1111 2019-01-23  Tom Tromey  <tom@tromey.com>
1112             Pedro Alves  <palves@redhat.com>
1113
1114         * infrun.c (disable_thread_events): Delete.
1115         (stop_all_threads): Use SCOPE_EXIT.
1116
1117 2019-01-23  Tom Tromey  <tom@tromey.com>
1118             Pedro Alves  <palves@redhat.com>
1119
1120         * symfile.c: Include forward-scope-exit.h.
1121         (clear_symtab_users_cleanup): Replace forward declaration with
1122         a FORWARD_SCOPE_EXIT.
1123         (syms_from_objfile_1): Use the forward_scope_exit and
1124         gdb::optional instead of cleanup_function.
1125         (reread_symbols): Use the forward_scope_exit instead of
1126         cleanup_function.
1127         (clear_symtab_users_cleanup): Remove function.
1128
1129 2019-01-23  Tom Tromey  <tom@tromey.com>
1130             Pedro Alves  <palves@redhat.com>
1131
1132         * linux-nat.c: Include scope-exit.h.
1133         (cleanup_target_stop): Remove.
1134         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1135         SCOPE_EXIT.
1136
1137 2019-01-23  Tom Tromey  <tom@tromey.com>
1138             Pedro Alves  <palves@redhat.com>
1139
1140         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1141         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1142
1143 2019-01-23  Tom Tromey  <tom@tromey.com>
1144             Andrew Burgess  <andrew.burgess@embecosm.com>
1145             Pedro Alves  <palves@redhat.com>
1146
1147         * infrun.c (fetch_inferior_event): Use scope_exit.
1148         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1149         * top.c (execute_command): Use scope_exit.
1150         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1151         * utils.c (do_bpstat_clear_actions_cleanup)
1152         (make_bpstat_clear_actions_cleanup): Remove.
1153
1154 2019-01-23  Tom Tromey  <tom@tromey.com>
1155             Pedro Alves  <palves@redhat.com>
1156
1157         * infrun.c: Include "common/scope-exit.h"
1158         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1159         (wait_for_inferior): Use SCOPE_EXIT.
1160         (fetch_inferior_event): Use scope_exit.
1161
1162 2019-01-23  Tom Tromey  <tom@tromey.com>
1163             Pedro Alves  <palves@redhat.com>
1164
1165         * breakpoint.c (create_breakpoint): Remove cleanup.
1166
1167 2019-01-23  Tom Tromey  <tom@tromey.com>
1168             Andrew Burgess  <andrew.burgess@embecosm.com>
1169             Pedro Alves  <palves@redhat.com>
1170
1171 2019-01-23  Pedro Alves  <palves@redhat.com>
1172
1173         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1174
1175 2019-01-23  Pedro Alves  <palves@redhat.com>
1176             Andrew Burgess  <andrew.burgess@embecosm.com>
1177
1178         * gdbthread.h: Include "common/forward-scope-exit.h".
1179         (scoped_finish_thread_state): Redefine custom class in terms of
1180         forward_scope_exit.
1181
1182 2019-01-23  Pedro Alves  <palves@redhat.com>
1183             Andrew Burgess  <andrew.burgess@embecosm.com>
1184
1185         * common/forward-scope-exit.h: New file.
1186
1187 2019-01-23  Pedro Alves  <palves@redhat.com>
1188             Andrew Burgess  <andrew.burgess@embecosm.com>
1189             Tom Tromey  <tom@tromey.com>
1190
1191         * common/scope-exit.h: New file.
1192
1193 2019-01-23  Pedro Alves  <palves@redhat.com>
1194
1195         * common/preprocessor.h (ESC): Rename to ...
1196         (ESC_PARENS): ... this.
1197         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1198         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1199
1200 2019-01-23  Tom Tromey  <tom@tromey.com>
1201
1202         * language.h (class scoped_switch_to_sym_language_if_auto):
1203         Initialize m_lang in both cases.
1204
1205 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1206
1207         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1208         with XCNEW.
1209
1210 2019-01-22  Tom Tromey  <tom@tromey.com>
1211
1212         * corelow.c: Do not include sys/file.h.
1213
1214 2019-01-22  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-wingeneral.h: Include gdb_curses.h.
1217
1218 2019-01-22  Tom Tromey  <tom@tromey.com>
1219
1220         * source-cache.h (class source_cache) <get_source_lines,
1221         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1222
1223 2019-01-22  Tom Tromey  <tom@tromey.com>
1224
1225         * remote-fileio.h (struct remote_target): Declare.
1226
1227 2019-01-22  Tom Tromey  <tom@tromey.com>
1228
1229         * python/py-arch.c: Do not include py-ref.h.
1230         * python/py-bpevent.c: Do not include py-ref.h.
1231         * python/py-cmd.c: Do not include py-ref.h.
1232         * python/py-continueevent.c: Do not include py-ref.h.
1233         * python/py-event.h: Do not include py-ref.h.
1234         * python/py-evtregistry.c: Do not include py-ref.h.
1235         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1236         * python/py-frame.c: Do not include py-ref.h.
1237         * python/py-framefilter.c: Do not include py-ref.h.
1238         * python/py-function.c: Do not include py-ref.h.
1239         * python/py-infevents.c: Do not include py-ref.h.
1240         * python/py-linetable.c: Do not include py-ref.h.
1241         * python/py-objfile.c: Do not include py-ref.h.
1242         * python/py-param.c: Do not include py-ref.h.
1243         * python/py-prettyprint.c: Do not include py-ref.h.
1244         * python/py-progspace.c: Do not include py-ref.h.
1245         * python/py-symbol.c: Do not include py-ref.h.
1246         * python/py-symtab.c: Do not include py-ref.h.
1247         * python/py-type.c: Do not include py-ref.h.
1248         * python/py-unwind.c: Do not include py-ref.h.
1249         * python/py-utils.c: Do not include py-ref.h.
1250         * python/py-value.c: Do not include py-ref.h.
1251         * python/py-varobj.c: Do not include py-ref.h.
1252         * python/py-xmethods.c: Do not include py-ref.h.
1253         * python/python.c: Do not include py-ref.h.
1254         * varobj.c: Do not include py-ref.h.
1255
1256 2019-01-22  Tom Tromey  <tom@tromey.com>
1257
1258         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1259         keyword for bcache.
1260
1261 2019-01-22  Tom Tromey  <tom@tromey.com>
1262
1263         * compile/compile-cplus-types.c: Remove a comment by #include.
1264
1265 2019-01-22  Tom Tromey  <tom@tromey.com>
1266
1267         * compile/gcc-c-plugin.h: Include compile-internal.h.
1268
1269 2019-01-22  Tom Tromey  <tom@tromey.com>
1270
1271         * stabsread.c (EXTERN): Do not define.
1272         (symnum, next_symbol_text_func, processing_gcc_compilation)
1273         (within_function, global_sym_chain, global_stabs)
1274         (previous_stab_code, this_object_header_files)
1275         (n_this_object_header_files)
1276         (n_allocated_this_object_header_files): Define.
1277         * stabsread.h (EXTERN): Never define.  Use "extern".
1278
1279 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1280
1281         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1282         history_value.
1283
1284 2019-01-21  Tom Tromey  <tom@tromey.com>
1285
1286         * ui-out.c: Fix includes.
1287         * tui/tui-source.c: Fix includes.
1288         * target.c: Fix includes.
1289         * remote.c: Fix includes.
1290         * regcache.c: Fix includes.
1291         * python/py-block.c: Fix includes.
1292         * printcmd.c: Fix includes.
1293         * or1k-tdep.c: Fix includes.
1294         * mi/mi-main.c: Fix includes.
1295         * m32r-tdep.c: Fix includes.
1296         * csky-tdep.c: Fix includes.
1297         * compile/compile-cplus-types.c: Fix includes.
1298         * cli/cli-interp.c: Fix includes.
1299
1300 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1301
1302         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1303         for padding.
1304
1305 2019-01-16  Tom Tromey  <tom@tromey.com>
1306
1307         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1308         earlier.
1309         (struct objfile) <msymbols_range>: Move from top level.
1310         <msymbols>: New method.
1311         (class objfile_msymbols): Remove.
1312         * symtab.c (default_collect_symbol_completion_matches_break_on):
1313         Update.
1314         * symmisc.c (dump_msymbols): Update.
1315         * stabsread.c (scan_file_globals): Update.
1316         * objc-lang.c (info_selectors_command, info_classes_command)
1317         (find_methods): Update.
1318         * minsyms.c (find_solib_trampoline_target): Update.
1319         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1320         * coffread.c (coff_symfile_read): Update.
1321         * ada-lang.c (ada_lookup_simple_minsym)
1322         (ada_collect_symbol_completion_matches): Update.
1323
1324 2019-01-16  Tom Tromey  <tom@tromey.com>
1325
1326         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1327         type.  Remove no-argument constructor.
1328         <iterator::operator++>: Simplify.
1329         <begin>: Update.
1330         <end>: Use minimal_symbol_count.
1331
1332 2019-01-16  Tom Tromey  <tom@tromey.com>
1333
1334         * objfiles.h (struct objfile) <psymtabs>: New method.
1335         (class objfile_psymtabs): Remove.
1336         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1337         typedef.
1338         <range>: New method.
1339         (require_partial_symbols): Change return type.
1340         * psymtab.c (require_partial_symbols)
1341         (psym_expand_symtabs_matching): Update.
1342         * mdebugread.c (parse_partial_symbols): Update.
1343         * dbxread.c (dbx_end_psymtab): Update.
1344
1345 2019-01-15  Tom Tromey  <tom@tromey.com>
1346
1347         * symtab.c (lookup_objfile_from_block)
1348         (lookup_symbol_in_objfile_symtabs)
1349         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1350         (find_line_symtab, info_sources_command)
1351         (default_collect_symbol_completion_matches_break_on)
1352         (make_source_files_completion_list): Update.
1353         * symmisc.c (print_objfile_statistics, dump_objfile)
1354         (maintenance_print_symbols, maintenance_info_symtabs)
1355         (maintenance_check_symtabs, maintenance_info_line_tables):
1356         Update.
1357         * source.c (select_source_symtab)
1358         (forget_cached_source_info_for_objfile): Update.
1359         * objfiles.h (class objfile_compunits): Remove.
1360         (struct objfile) <compunits_range>: New typedef.
1361         (compunits): New method.
1362         * objfiles.c (objfile_relocate1): Update.
1363         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1364         * maint.c (count_symtabs_and_blocks): Update.
1365         * linespec.c (iterate_over_all_matching_symtabs): Update.
1366         * cp-support.c (add_symbol_overload_list_qualified): Update.
1367         * coffread.c (coff_symtab_read): Update.
1368         * ada-lang.c (add_nonlocal_symbols)
1369         (ada_collect_symbol_completion_matches)
1370         (ada_add_global_exceptions): Update.
1371
1372 2019-01-15  Tom Tromey  <tom@tromey.com>
1373
1374         * progspace.h (program_space) <objfiles_safe_range>: New
1375         typedef.
1376         <objfiles_safe>: New method.
1377         * objfiles.h (class all_objfiles_safe): Remove.
1378         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1379         * jit.c (jit_inferior_exit_hook): Update.
1380
1381 2019-01-17  Tom Tromey  <tom@tromey.com>
1382
1383         * progspace.h (program_space) <objfiles_range>: New typedef.
1384         <objfiles>: New method.
1385         <objfiles_head>: Rename from objfiles.
1386         (object_files): Update.
1387         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1388         * guile/scm-pretty-print.c
1389         (ppscm_find_pretty_printer_from_objfiles): Update.
1390         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1391         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1392         Update.
1393         * python/py-progspace.c (pspy_get_objfiles): Update.
1394         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1395         Update.
1396         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1397         (objfpy_lookup_objfile_by_build_id): Update.
1398         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1399         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1400         Update.
1401         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1402         (expand_symtab_containing_pc, lookup_objfile_from_block)
1403         (lookup_static_symbol, basic_lookup_transparent_type)
1404         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1405         (find_line_symtab, info_sources_command)
1406         (default_collect_symbol_completion_matches_break_on)
1407         (make_source_files_completion_list, find_main_name): Update.
1408         * symmisc.c (print_symbol_bcache_statistics)
1409         (print_objfile_statistics, maintenance_print_symbols)
1410         (maintenance_print_msymbols, maintenance_print_objfiles)
1411         (maintenance_info_symtabs, maintenance_check_symtabs)
1412         (maintenance_expand_symtabs, maintenance_info_line_tables):
1413         Update.
1414         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1415         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1416         (map_overlay_command, unmap_overlay_command)
1417         (simple_overlay_update, expand_symtabs_matching)
1418         (map_symbol_filenames): Update.
1419         * symfile-debug.c (set_debug_symfile): Update.
1420         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1421         Update.
1422         * source.c (select_source_symtab, forget_cached_source_info):
1423         Update.
1424         * solib.c (solib_read_symbols): Update.
1425         * solib-spu.c (append_ocl_sos): Update.
1426         * psymtab.c (maintenance_print_psymbols)
1427         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1428         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1429         * printcmd.c (info_symbol_command): Update.
1430         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1431         Update.
1432         * objfiles.h (class all_objfiles): Remove.
1433         * objfiles.c (have_partial_symbols, have_full_symbols)
1434         (have_minimal_symbols, qsort_cmp, update_section_map)
1435         (shared_objfile_contains_address_p)
1436         (default_iterate_over_objfiles_in_search_order): Update.
1437         * objc-lang.c (info_selectors_command, info_classes_command)
1438         (find_methods): Update.
1439         * minsyms.c (find_solib_trampoline_target): Update.
1440         * maint.c (maintenance_info_sections)
1441         (maintenance_translate_address, count_symtabs_and_blocks):
1442         Update.
1443         * main.c (captured_main_1): Update.
1444         * linux-thread-db.c (try_thread_db_load_from_pdir)
1445         (has_libpthread): Update.
1446         * linespec.c (iterate_over_all_matching_symtabs)
1447         (search_minsyms_for_name): Update.
1448         * jit.c (jit_find_objf_with_entry_addr): Update.
1449         * hppa-tdep.c (find_unwind_entry)
1450         (hppa_lookup_stub_minimal_symbol): Update.
1451         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1452         Update.
1453         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1454         (elf_gnu_ifunc_resolve_by_got): Update.
1455         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1456         * dwarf-index-write.c (save_gdb_index_command): Update.
1457         * cp-support.c (add_symbol_overload_list_qualified): Update.
1458         * breakpoint.c (create_overlay_event_breakpoint)
1459         (create_longjmp_master_breakpoint)
1460         (create_std_terminate_master_breakpoint)
1461         (create_exception_master_breakpoint): Update.
1462         * blockframe.c (find_pc_partial_function): Update.
1463         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1464         (ada_collect_symbol_completion_matches)
1465         (ada_add_global_exceptions): Update.
1466
1467 2019-01-17  Tom Tromey  <tom@tromey.com>
1468
1469         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1470         declare VEC.
1471         (solib_target_parse_libraries): Change return type.
1472         (library_list_start_segment, library_list_start_section)
1473         (library_list_end_library, library_list_start_library); Update.
1474         (solib_target_free_library_list): Remove.
1475         (solib_target_parse_libraries): Remove cleanup.  Change return
1476         type.
1477         (solib_target_current_sos): Update.
1478
1479 2019-01-17  Tom Tromey  <tromey@bapiya>
1480
1481         * valprint.c: Replace "the the" with "the".
1482         * symtab.c: Replace "the the" with "the".
1483         * solib.c: Replace "the the" with "the".
1484         * solib-dsbt.c: Replace "the the" with "the".
1485         * linespec.c: Replace "the the" with "the".
1486         * dwarf2loc.h: Replace "the the" with "the".
1487         * amd64-windows-tdep.c: Replace "the the" with "the".
1488         * aarch64-tdep.c: Replace "the the" with "the".
1489
1490 2019-01-16  Keith Seitz  <keiths@redhat.com>
1491
1492         PR gdb/23773
1493         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1494         <builder>: Rename to ..
1495         <m_builder>: ... this and make private.
1496         (dwarf2_cu::get_builder): New method.  Change all users of
1497         `builder' to use this method.
1498         (dwarf2_start_symtab): Move to ...
1499         (dwarf2_cu::start_symtab): ... here.  Update all callers
1500         (setup_type_unit_groups): Move to ...
1501         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1502         callers.
1503         (dwarf2_cu::reset_builder): New method.
1504         (process_full_compunit, process_full_type_unit): Use
1505         dwarf2_cu::reset_builder.
1506         (follow_die_offset): Record the ancestor CU if it is different
1507         from the followed DIE's CU.
1508         (follow_die_sig_1): Likewise.
1509
1510 2019-01-15  Tom Tromey  <tom@tromey.com>
1511
1512         * remote.c (class remote_state) <buf>: Now a char_vector.
1513         <buf_size>: Remove.
1514         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1515         parameter.
1516         (remote_target::getpkt_or_notif_sane_1)
1517         (remote_target::getpkt_sane)
1518         (remote_target::getpkt_or_notif_sane): Likewise.
1519         (class remote_target) <putpkt>: New overload.
1520         (remote_target::read_frame): Change type of "buf_p".  Remove
1521         sizeof_p parameter.
1522         (packet_ok): New overload.
1523         (packet_check_result): New overload.
1524         Update all uses.
1525
1526 2019-01-14  Tom Tromey  <tom@tromey.com>
1527
1528         * remote-notif.c (handle_notification, remote_notif_ack)
1529         (remote_notif_parse): Make "buf" const.
1530         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1531         const.
1532         (remote_notif_parse, remote_notif_ack, handle_notification):
1533         Likewise.
1534         * remote.c (remote_notif_stop_parse): Make "buf" const.
1535         (remote_target::remote_parse_stop_reply): Make "buf" const.
1536         (remote_notif_stop_ack): Make "buf" const.
1537
1538 2019-01-14  Tom Tromey  <tom@tromey.com>
1539
1540         * remote.c (remote_console_output): Make parameter const.
1541
1542 2019-01-14  Tom Tromey  <tom@tromey.com>
1543
1544         * target-debug.h (target_debug_print_signals): Constify.
1545         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1546         * procfs.c (procfs_target::pass_signals): Update.
1547         * linux-nat.c (linux_nat_target::pass_signals): Update.
1548         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1549         * target-delegates.c: Rebuild.
1550         * remote.c (remote_target::program_signals): Update.
1551         (remote_target::pass_signals): Update.
1552         * target.c (target_pass_signals): Constify argument.
1553         (target_program_signals): Likewise.
1554         * target.h (struct target_ops) <pass_signals, program_signals>:
1555         Constify argument.
1556         (target_pass_signals, target_program_signals): Constify argument.
1557
1558 2019-01-14  Tom Tromey  <tom@tromey.com>
1559
1560         PR tui/28819:
1561         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1562
1563 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1564
1565         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1566         field.
1567         * rs6000-tdep.c: Include reggroups.h.
1568         (IS_V_ALIAS_PSEUDOREG): Define.
1569         (rs6000_register_name): Return names for the "vX" aliases.
1570         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1571         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1572         aliases.  Call default_register_reggroup_p for all other
1573         pseudo-registers.
1574         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1575         New functions.
1576         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1577         Handle "vX" aliases.
1578         (v_alias_pseudo_register_collect): New function.
1579         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1580         (rs6000_gdbarch_init): Initialize "vX" aliases as
1581         pseudo-registers.  Restore registration of
1582         rs6000_pseudo_register_reggroup_p with
1583         set_tdesc_pseudo_register_reggroup_p.
1584
1585 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1586
1587         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1588         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1589         set_gdbarch_num_pseudo_regs.
1590
1591 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1592
1593         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1594         Remove arg prefixname, add do_set and do_show.
1595         Add member functions set_list and show_list.
1596         * cli/cli-style.c (class cli_style_option): Update accordingly.
1597         (style_set_list): Move to file scope.
1598         (style_show_list): Likewise.
1599         (set_style): Call help_list.
1600         (show_style): Call cmd_show_list.
1601         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1602         Update to use the new macro.
1603
1604 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1605
1606         * ada-lang.c (_initialize_ada_language): Expand the help text
1607         for the "catch exception" command.
1608
1609 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1610
1611         * symtab.c (matching_obj_sections): Initialize obj,
1612         declare it closer to its usage.
1613
1614 2019-01-10  Tom Tromey  <tom@tromey.com>
1615
1616         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1617         (basic_inf_threads_range): Remove.
1618         (inf_threads_range, inf_non_exited_threads_range)
1619         (safe_inf_threads_range): Use next_adapter.
1620
1621 2019-01-10  Keith Seitz  <keiths@redhat.com>
1622
1623         PR gdb/23712
1624         PR symtab/23010
1625         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1626         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1627
1628 2019-01-10  Keith Seitz  <keiths@redhat.com>
1629
1630         PR gdb/23712
1631         PR symtab/23010
1632         * dictionary.c (pending_to_vector): Remove.
1633         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1634         Remove _1 suffix, replacing functions of the same name.  Update
1635         all callers.
1636         (dict_create_hashed, dict_create_hashed_expandable)
1637         (dict_create_linear, dict_create_linear_expandable, dict_free)
1638         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1639         Make functions static.
1640
1641 2019-01-10  Keith Seitz  <keiths@redhat.com>
1642
1643         PR gdb/23712
1644         PR symtab/23010
1645         * dictionary.h (struct dictionary): Replace declaration with
1646         multidictionary.
1647         (dict_create_hashed, dict_create_hashed_expandable)
1648         (dict_create_linear, dict_create_linear_expandable)
1649         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1650         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1651         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1652         taking multidictionary argument.
1653         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1654         * block.h (struct block) <dict>: Change to multidictionary
1655         and rename `multidict'.
1656         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1657         symmisc.c: Update all dictionary references to multidictionary.
1658
1659 2019-01-10  Keith Seitz  <keiths@redhat.com>
1660
1661         PR gdb/23712
1662         PR symtab/23010
1663         * dictionary.c: Include unordered_map.
1664         (pending_to_vector): New function.
1665         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1666         Rewrite the non-"_1" functions to take vector instead
1667         of linked list.
1668         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1669         "new" _1 versions of the same name.
1670         (multidictionary): Define.
1671         (std::hash<enum language): New definition.
1672         (collate_pending_symbols_by_language, mdict_create_hashed)
1673         (mdict_create_hashed_expandable, mdict_create_linear)
1674         (mdict_create_linear_expandable, mdict_free)
1675         (find_language_dictionary, create_new_language_dictionary)
1676         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1677         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1678         (mdict_size, mdict_empty): New functions.
1679         * dictionary.h (mdict_iterator): Define.
1680
1681 2019-01-10  Pedro Alves  <palves@redhat.com>
1682
1683         * breakpoint.c (read_uploaded_action)
1684         (create_tracepoint_from_upload): Adjust to use
1685         gdb::unique_xmalloc_ptr.
1686         * ctf.c (ctf_write_uploaded_tp):
1687         (SET_ARRAY_FIELD): Use emplace_back.
1688         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1689         * tracefile-tfile.c (tfile_write_uploaded_tp):
1690         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1691         gdb::unique_xmalloc_ptr.
1692         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1693         at_string, cond_string, cmd_strings>: Replace char pointers
1694         with gdb::unique_xmalloc_ptr.
1695
1696 2019-01-10  Pedro Alves  <palves@redhat.com>
1697
1698         * solib-target.c (library_list_start_library): Don't xstrdup name.
1699
1700 2019-01-10  Pedro Alves  <palves@redhat.com>
1701
1702         * mdebugread.c (parse_partial_symbols): Use
1703         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1704
1705 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1706
1707         * linux-fork.c (scoped_switch_fork_info)
1708         <~scoped_switch_fork_info>: Fix incorrect variable name.
1709
1710 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1711
1712         * linux-fork.c (scoped_switch_fork_info)
1713         <scoped_switch_fork_info>: Make explicit.
1714         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1715
1716 2019-01-10  Tom Tromey  <tom@tromey.com>
1717
1718         * objfiles.h (objfile::reset_psymtabs): Update.
1719         * objfiles.c (objfile::objfile): Update.
1720         * psymtab.h (psymtab_storage::obstack): Update.
1721         (psymtab_storage::m_obstack): Use gdb::optional.
1722         (class psymtab_storage): Update comment.  Remove objfile
1723         parameter.
1724         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1725
1726 2019-01-10  Tom Tromey  <tom@tromey.com>
1727
1728         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1729         <free_psymtabs>: Now private.
1730         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1731         (allocate_psymtab): Use new method.
1732
1733 2019-01-10  Tom Tromey  <tom@tromey.com>
1734
1735         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1736         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1737         * mdebugread.c (parse_partial_symbols): Use
1738         allocate_dependencies.
1739         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1740         allocate_dependencies.
1741         (process_psymtab_comp_unit_reader)
1742         (build_type_psymtab_dependencies): Likewise.
1743         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1744
1745 2019-01-10  Tom Tromey  <tom@tromey.com>
1746
1747         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1748         PSYMBOL_SET_LANGUAGE.
1749         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1750
1751 2019-01-10  Tom Tromey  <tom@tromey.com>
1752
1753         * psymtab.h (psymtab_storage::obstack): New method.
1754         <m_obstack>: Rename from obstack; now private.
1755         * psymtab.c (psymtab_storage): Update.
1756         * dwarf2read.c (create_addrmap_from_index)
1757         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1758         Update.
1759
1760 2019-01-10  Tom Tromey  <tom@tromey.com>
1761
1762         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1763         * objfiles.h (objfile::reset_psymtabs): New method.
1764
1765 2019-01-10  Tom Tromey  <tom@tromey.com>
1766
1767         * symmisc.c (print_symbol_bcache_statistics): Update.
1768         (print_objfile_statistics): Update.
1769         * symfile.c (reread_symbols): Update.
1770         * psymtab.h (class psymtab_storage): New.
1771         * psymtab.c (psymtab_storage): New constructor.
1772         (~psymtab_storage): New destructor.
1773         (require_partial_symbols): Update.
1774         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1775         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1776         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1777         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1778         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1779         (start_psymtab_common, end_psymtab_common)
1780         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1781         (allocate_psymtab): Update.
1782         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1783         Update.
1784         (dump_psymtab_addrmap, maintenance_print_psymbols)
1785         (maintenance_check_psymtabs): Update.
1786         (class objfile_psymtabs): Move to objfiles.h.
1787         * psympriv.h (discard_psymtab): Now inline.
1788         (psymtab_discarder::psymtab_discarder): Update.
1789         (psymtab_discarder::~psymtab_discarder): Update.
1790         (ALL_OBJFILE_PSYMTABS): Rewrite.
1791         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1792         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1793         Remove fields.
1794         <partial_symtabs>: New field.
1795         (class objfile_psymtabs): Move from psymtab.h.  Update.
1796         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1797         psymbol_cache.
1798         (objfile::~objfile): Don't destroy psymbol_cache.
1799         * mdebugread.c (parse_partial_symbols): Update.
1800         * dwarf2read.c (create_addrmap_from_index)
1801         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1802         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1803         (add_partial_subprogram, dwarf2_ranges_read): Update.
1804         * dwarf-index-write.c (write_address_map)
1805         (write_one_signatured_type, recursively_write_psymbols)
1806         (class debug_names, class debug_names, write_psymtabs_to_index):
1807         Update.
1808
1809 2019-01-10  Tom Tromey  <tom@tromey.com>
1810
1811         * symtab.h (SYMBOL_SET_NAMES): Update.
1812         (symbol_set_names): Update.
1813         (MSYMBOL_SET_NAMES): Update.
1814         * symtab.c (symbol_set_names): Change argument to be an
1815         objfile_per_bfd_storage.
1816         * psymtab.c (add_psymbol_to_bcache): Update.
1817         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1818
1819 2019-01-10  Tom Tromey  <tom@tromey.com>
1820
1821         * symtab.c (create_demangled_names_hash): Change argument to be an
1822         objfile_per_bfd_storage.
1823         (symbol_set_names): Update.
1824
1825 2019-01-10  Tom Tromey  <tom@tromey.com>
1826
1827         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1828         init_psymbol_list.
1829         * psymtab.c (init_psymbol_list): Do nothing if already called.
1830         * psympriv.h (init_psymbol_list): Add comment.
1831         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1832         init_psymbol_list.
1833         * dbxread.c (dbx_symfile_read): Unconditionally call
1834         init_psymbol_list.
1835
1836 2019-01-10  Tom Tromey  <tom@tromey.com>
1837
1838         * xcoffread.c (scan_xcoff_symtab): Update.
1839         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1840         "where".
1841         * mdebugread.c (parse_partial_symbols)
1842         (handle_psymbol_enumerators): Update.
1843         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1844         * dbxread.c (read_dbx_symtab): Update.
1845         * psympriv.h (psymbol_placement): New enum.
1846         (add_psymbol_to_list): Update.
1847
1848 2019-01-10  Tom Tromey  <tom@tromey.com>
1849
1850         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1851         static_psymbols parameters.
1852         (scan_xcoff_symtab): Update.
1853         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1854         static_psymbols parameters.
1855         * psympriv.h (start_psymtab_common): Update.
1856         * mdebugread.c (parse_partial_symbols): Update.
1857         * dwarf2read.c (create_partial_symtab): Update.
1858         * dbxread.c (read_dbx_symtab): Update.
1859         (start_psymtab): Remove global_psymbols and static_psymbols
1860         parameters.
1861
1862 2019-01-10  Tom Tromey  <tom@tromey.com>
1863
1864         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1865         * psymtab.c (allocate_psymtab): Add comment.
1866         * psympriv.h (allocate_psymtab): Add comment.
1867         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1868         initializations.
1869         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1870
1871 2019-01-10  Tom Tromey  <tom@tromey.com>
1872
1873         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1874         Don't declare.
1875         * mipsread.c: Include mdebugread.h.
1876         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1877         Declare.
1878         * elfread.c: Include mdebugread.h.
1879
1880 2019-01-09  Tom Tromey  <tom@tromey.com>
1881
1882         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1883         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1884         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1885         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1886         (psym_lookup_symbol, psym_find_last_source_symtab)
1887         (psym_forget_cached_source_info, psym_print_stats)
1888         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1889         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1890         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1891         (psym_find_compunit_symtab_by_address)
1892         (maintenance_print_psymbols, maintenance_info_psymtabs)
1893         (maintenance_check_psymtabs): Use ranged for.
1894         * psymtab.h (class objfile_psymtabs): New.
1895         (require_partial_symbols): Return objfile_psymtabs.
1896         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1897
1898 2019-01-09  Tom Tromey  <tom@tromey.com>
1899
1900         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1901         (find_pc_mapped_section, list_overlays_command)
1902         (map_overlay_command, unmap_overlay_command)
1903         (simple_overlay_update): Use all_objfiles.
1904         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1905         * printcmd.c (info_symbol_command): Use all_objfiles.
1906         * objfiles.h (ALL_OBJSECTIONS): Remove.
1907         * maint.c (maintenance_translate_address): Use all_objfiles.
1908         * gcore.c (gcore_create_callback): Use all_objfiles.
1909         (objfile_find_memory_regions): Likewise.
1910
1911 2019-01-09  Tom Tromey  <tom@tromey.com>
1912
1913         * symtab.c (find_line_symtab, info_sources_command)
1914         (make_source_files_completion_list): Use objfile_compunits.
1915         * source.c (select_source_symtab): Use objfile_compunits.
1916         * objfiles.h (struct objfile): Update comment.
1917         (ALL_OBJFILES): Remove.
1918         (ALL_FILETABS): Remove.
1919         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1920         objfile_compunits.
1921
1922 2019-01-09  Tom Tromey  <tom@tromey.com>
1923
1924         * symmisc.c (print_objfile_statistics, dump_objfile)
1925         (maintenance_print_symbols): Use compunit_filetabs.
1926         * source.c (forget_cached_source_info_for_objfile): Use
1927         compunit_filetabs.
1928         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1929         (ALL_FILETABS): Use compunit_filetabs.
1930         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1931         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1932
1933 2019-01-09  Tom Tromey  <tom@tromey.com>
1934
1935         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1936         (compunit_filetabs): New.
1937         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1938         compunit_filetabs.
1939         (info_sources_command, make_source_files_completion_list): Remove
1940         declaration.
1941         * symmisc.c (print_objfile_statistics, dump_objfile)
1942         (maintenance_print_symbols): Remove declaration.
1943         (maintenance_info_symtabs): Use compunit_filetabs.
1944         (maintenance_info_line_tables): Likewise.
1945         * source.c (select_source_symtab): Change local variable name.
1946         (forget_cached_source_info_for_objfile): Remove declaration.
1947         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1948         * objfiles.c (objfile_relocate1): Remove declaration.
1949         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1950         declaration.
1951         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1952         * coffread.c (coff_symtab_read): Remove declaration.
1953         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1954         compunit_filetabs.
1955
1956 2019-01-09  Tom Tromey  <tom@tromey.com>
1957
1958         * symtab.c (lookup_objfile_from_block)
1959         (find_pc_sect_compunit_symtab, search_symbols)
1960         (default_collect_symbol_completion_matches_break_on): Use
1961         objfile_compunits.
1962         * objfiles.h (ALL_COMPUNITS): Remove.
1963         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1964         * cp-support.c (add_symbol_overload_list_qualified): Use
1965         objfile_compunits.
1966         * ada-lang.c (ada_collect_symbol_completion_matches)
1967         (ada_add_global_exceptions): Use objfile_compunits.
1968
1969 2019-01-09  Tom Tromey  <tom@tromey.com>
1970
1971         * source.c (select_source_symtab)
1972         (forget_cached_source_info_for_objfile): Remove declaration.
1973         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1974         declaration.
1975         * maint.c (count_symtabs_and_blocks): Remove declaration.
1976         * cp-support.c (add_symbol_overload_list_qualified): Remove
1977         declaration.
1978         * coffread.c (coff_symtab_read): Remove declaration.
1979         * symtab.c (lookup_symbol_in_objfile_symtabs)
1980         (basic_lookup_transparent_type_1): Use objfile_compunits.
1981         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1982         (info_sources_command, search_symbols)
1983         (default_collect_symbol_completion_matches_break_on)
1984         (make_source_files_completion_list): Remove declaration.
1985         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1986         (ada_collect_symbol_completion_matches)
1987         (ada_add_global_exceptions): Remove declaration.
1988         * linespec.c (iterate_over_all_matching_symtabs): Use
1989         objfile_compunits.
1990         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1991         (class objfile_compunits): New.
1992         (ALL_COMPUNITS): Use objfile_compunits.
1993         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1994         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1995         objfile_compunits.
1996         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1997
1998 2019-01-09  Tom Tromey  <tom@tromey.com>
1999
2000         * symtab.c (search_symbols)
2001         (default_collect_symbol_completion_matches_break_on): Use
2002         objfile_msymbols.
2003         * ada-lang.c (ada_lookup_simple_minsym)
2004         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2005         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2006         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2007         objfile_msymbols.
2008         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2009         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2010         * objc-lang.c (find_methods): Use objfile_msymbols.
2011         (info_selectors_command, info_classes_command): Likewise.
2012         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2013         * objfiles.h (class objfile_msymbols): New.
2014         (ALL_OBJFILE_MSYMBOLS): Remove.
2015         (ALL_MSYMBOLS): Remove.
2016
2017 2019-01-09  Tom Tromey  <tom@tromey.com>
2018
2019         * common/next-iterator.h (next_adapter): Add Iterator template
2020         parameter.
2021         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2022         (class all_objfiles_safe): New.
2023         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2024         * objfiles.c (put_objfile_before): Update comment.
2025         (add_separate_debug_objfile): Likewise.
2026         (free_all_objfiles): Use all_objfiles_safe.
2027         (objfile_purge_solibs): Likewise.
2028
2029 2019-01-09  Tom Tromey  <tom@tromey.com>
2030
2031         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2032         (expand_symtab_containing_pc, lookup_static_symbol)
2033         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2034         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2035         all_objfiles.
2036         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2037         * breakpoint.c (create_overlay_event_breakpoint)
2038         (create_longjmp_master_breakpoint)
2039         (create_std_terminate_master_breakpoint)
2040         (create_exception_master_breakpoint): Use all_objfiles.
2041         * linux-thread-db.c (try_thread_db_load_from_pdir)
2042         (has_libpthread): Use all_objfiles.
2043         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2044         * linespec.c (iterate_over_all_matching_symtabs)
2045         (search_minsyms_for_name): Use all_objfiles.
2046         * maint.c (maintenance_info_sections): Use all_objfiles.
2047         * main.c (captured_main_1): Use all_objfiles.
2048         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2049         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2050         * guile/scm-pretty-print.c
2051         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2052         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2053         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2054         (maintenance_print_msymbols): Use all_objfiles.
2055         * source.c (select_source_symtab): Use all_objfiles.
2056         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2057         * symfile.c (remove_symbol_file_command)
2058         (expand_symtabs_matching, map_symbol_filenames): Use
2059         all_objfiles.
2060         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2061         all_objfiles.
2062         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2063         * objc-lang.c (find_methods): Use all_objfiles.
2064         * objfiles.c (have_partial_symbols, have_full_symbols)
2065         (have_minimal_symbols, qsort_cmp)
2066         (default_iterate_over_objfiles_in_search_order): Use
2067         all_objfiles.
2068         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2069         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2070         (maintenance_check_psymtabs): Use all_objfiles.
2071         (ALL_PSYMTABS): Remove.
2072         * compile/compile-object-run.c (do_module_cleanup): Use
2073         all_objfiles.
2074         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2075         * cp-support.c (add_symbol_overload_list_qualified): Use
2076         all_objfiles.
2077         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2078         Use all_objfiles.
2079         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2080         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2081         all_objfiles.
2082         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2083         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2084         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2085         Uses all_objfiles.
2086         * solib.c (solib_read_symbols): Use all_objfiles
2087
2088 2019-01-09  Tom Tromey  <tom@tromey.com>
2089
2090         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2091         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2092         all_objfiles.
2093         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2094         * symmisc.c (print_symbol_bcache_statistics)
2095         (print_objfile_statistics, maintenance_print_objfiles)
2096         (maintenance_info_symtabs, maintenance_check_symtabs)
2097         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2098         all_objfiles.
2099         * source.c (forget_cached_source_info): Use all_objfiles.
2100         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2101         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2102         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2103         * objfiles.c (update_section_map): Use all_objfiles.
2104         (shared_objfile_contains_address_p): Likewise.
2105         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2106         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2107
2108 2019-01-09  Tom Tromey  <tom@tromey.com>
2109
2110         * common/next-iterator.h: New file.
2111         * objfiles.h (class all_objfiles): New.
2112         (struct objfile_iterator): New.
2113
2114 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2115
2116         * NEWS: Move the description of the changed "frame", "select-frame",
2117          and "info frame" commands to the Changed commands section.
2118
2119 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2120
2121         * gdbtypes.c (check_stub_method_group): Remove handling of old
2122         mangling schemes.
2123         * linespec.c (find_methods): Likewise.
2124         * stabsread.c (read_member_functions): Likewise.
2125         * valops.c (search_struct_method): Likewise.
2126         (value_struct_elt_for_reference): Likewise.
2127         * NEWS: Mention this change.
2128
2129 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2130
2131         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2132         print_source_lines.
2133         * source.c (print_source_lines_base): Update line number check.
2134         (print_source_lines): New function.
2135         (source_lines_range::source_lines_range): New function.
2136         * source.h (class source_lines_range): New class.
2137         (print_source_lines): New declaration.
2138
2139 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2140
2141         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2142
2143 2019-01-08  Tom Tromey  <tom@tromey.com>
2144             Simon Marchi  <simon.marchi@ericsson.com>
2145
2146         PR gdb/24060
2147         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2148         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2149         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2150         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2151         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2152         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2153
2154 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2155
2156         * source.c (select_source_symtab): Move header comment to
2157         declaration in source.h.
2158         (forget_cached_source_info_for_objfile): Likewise.
2159         (forget_cached_source_info): Likewise.
2160         (identify_source_line): Likewise.
2161         * source.h (identify_source_line): Move declaration from symtab.h
2162         and add comment from source.c
2163         (print_source_lines): Likewise.
2164         (forget_cached_source_info_for_objfile): Likewise.
2165         (forget_cached_source_info): Likewise.
2166         (select_source_symtab): Likewise.
2167         (enum print_source_lines_flag): Move definition from symtab.h.
2168         * symtab.h (identify_source_line): Move declaration to source.h.
2169         (print_source_lines): Likewise.
2170         (forget_cached_source_info_for_objfile): Likewise.
2171         (forget_cached_source_info): Likewise.
2172         (select_source_symtab): Likewise.
2173         (enum print_source_lines_flag): Move definition to source.h.
2174         * tui/tui-hooks.c: Add 'source.h' include.
2175
2176 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2177
2178         * source.c (print_source_lines_base): Handle requests to print
2179         reverse line number sequences, and guard against empty lines
2180         string.
2181
2182 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2183
2184         * source.c (print_source_lines_base): Fix skip of '\r' if next
2185         character is '\n'.
2186
2187 2019-01-06  Tom Tromey  <tom@tromey.com>
2188
2189         * c-exp.y (struct c_parse_state) <macro_original_text,
2190         expansion_obstack>: New member.
2191         (macro_original_text, expansion_obstack): Remove globals.
2192         (scan_macro_expansion, scanning_macro_expansion)
2193         (finished_macro_expansion): Update.
2194         (scan_macro_cleanup): Remove.
2195         (yylex, c_parse): Update.
2196
2197 2019-01-06  Tom Tromey  <tom@tromey.com>
2198
2199         * c-exp.y (struct c_parse_state) <strings>: New member.
2200         (operator_stoken): Update.
2201
2202 2019-01-06  Tom Tromey  <tom@tromey.com>
2203
2204         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2205         (union type_stack_elt) <typelist_val>: Now a pointer to
2206         std::vector.
2207         (type_stack_cleanup): Don't declare.
2208         (push_typelist): Update.
2209         * parse.c (pop_typelist): Return a std::vector.
2210         (push_typelist): Take a std::vector.
2211         (follow_types): Update.  Do not free args.
2212         (type_stack_cleanup): Remove.
2213         * c-exp.y (struct c_parse_state): New.
2214         (cpstate): New global.
2215         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2216         (nonempty_typelist): Update.
2217         (func_mod): Create a new vector.
2218         (c_parse): Create a c_parse_state.
2219         (check_parameter_typelist): Do not delete params.
2220         (function_method): Update.  Do not delete type_list.
2221
2222 2019-01-06  Tom Tromey  <tom@tromey.com>
2223
2224         PR gdb/28155:
2225         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2226         check_typedef.
2227         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2228         (print_return_value): Likewise.
2229
2230 2019-01-05  Tom Tromey  <tom@tromey.com>
2231
2232         * contrib/cleanup_check.py: Remove.
2233         * contrib/gcc-with-excheck: Remove.
2234         * contrib/exsummary.py: Remove.
2235         * contrib/excheck.py: Remove.
2236
2237 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2238
2239         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2240         NULL. Initialize tpprev to NULL instead of assigning it
2241         to NULL on the next statement.
2242         * windows-nat.c (windows_delete_thread): Remove check for
2243         main_thread_id before printing thread exit notifications.
2244         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2245         Remove thread ID check against main_thread_id.
2246         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2247         windows_delete_thread.
2248         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2249
2250 2019-01-04  Tom Tromey  <tom@tromey.com>
2251
2252         * compile/compile.c (_initialize_compile): Use upper case for
2253         metasyntactic variables.
2254         * symmisc.c (_initialize_symmisc): Use upper case for
2255         metasyntactic variables.
2256         * psymtab.c (_initialize_psymtab): Use upper case for
2257         metasyntactic variables.
2258         * demangle.c (demangle_command): Use upper case for metasyntactic
2259         variables.
2260         (_initialize_demangler): Likewise.
2261         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2262         variables.
2263
2264 2019-01-03  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2267
2268 2019-01-03  Tom Tromey  <tom@tromey.com>
2269
2270         * python/py-symtab.c (salpy_str): Update.
2271         (struct salpy_sal_object) <symtab>: Now a PyObject.
2272         (salpy_dealloc): Update.
2273         (del_objfile_sal): Use gdbpy_ref.
2274
2275 2019-01-03  Tom Tromey  <tom@tromey.com>
2276
2277         * python/py-type.c (convert_field): Use new_reference.  Return
2278         gdbpy_ref.
2279         (make_fielditem): Return gdbpy_ref.
2280         (typy_fields): Update.
2281         (typy_getitem): Update.
2282         (field_name): Return gdbpy_ref.  Use new_reference.
2283         (typy_iterator_iternext): Update.
2284
2285 2019-01-03  Tom Tromey  <tom@tromey.com>
2286
2287         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2288
2289 2019-01-03  Tom Tromey  <tom@tromey.com>
2290
2291         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2292         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2293         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2294         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2295         (pspy_set_type_printers): Likewise.
2296         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2297         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2298         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2299         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2300         (objfpy_set_type_printers): Likewise.
2301
2302 2019-01-03  Tom Tromey  <tom@tromey.com>
2303
2304         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2305         (gdbpy_print_stack): Use gdbpy_err_fetch.
2306         * python/python-internal.h (class gdbpy_err_fetch): New class.
2307         (class gdbpy_enter) <m_error_type, m_error_value,
2308         m_error_traceback>: Remove.
2309         <m_error>: New member.
2310         (gdbpy_exception_to_string): Don't declare.
2311         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2312         * python/py-value.c (convert_value_from_python): Use
2313         gdbpy_err_fetch.
2314         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2315         gdbpy_exception_to_string.
2316         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2317         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2318         gdbpy_err_fetch.
2319
2320 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2321
2322         * linux-nat.c (delete_lwp_cleanup): Delete.
2323         (struct lwp_deleter): New struct.
2324         (lwp_info_up): New typedef.
2325         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2326         lwp_info_up.
2327
2328 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2329
2330         * linux-fork.c (class scoped_switch_fork_info): New class.
2331         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2332
2333 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2334
2335         * valops.c (find_overload_match): Remove use of null_cleanup, and
2336         calls to do_cleanups.
2337
2338 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2339
2340         * compile/compile-cplus-types.c
2341         (compile_cplus_instance::decl_name): Handle changes to
2342         cp_func_name.
2343         * cp-support.c (cp_func_name): Update header comment, update
2344         return type.
2345         * cp-support.h (cp_func_name): Update return type in declaration.
2346         * valops.c (find_overload_match): Move temp_func local to top
2347         level of function and change its type.  Use temp_func to hold and
2348         delete temporary string obtained from cp_func_name.
2349
2350 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2351
2352         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2353         gdb::char_vector, remove cleanup, and update uses of `msg`.
2354
2355 2019-01-03  Jim Wilson  <jimw@sifive.com>
2356
2357         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2358
2359 2019-01-02  Tom Tromey  <tom@tromey.com>
2360
2361         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2362         (tdesc_parse_xml): Remove cleanups.
2363         * target-descriptions.h (make_cleanup_free_target_description):
2364         Don't declare.
2365         (target_desc_deleter): New struct.
2366         (target_desc_up): New typedef.
2367         * target-descriptions.c (target_desc_deleter::operator()): Rename
2368         from free_target_description.
2369         (make_cleanup_free_target_description): Remove.
2370
2371 2019-01-02  Tom Tromey  <tom@tromey.com>
2372
2373         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2374         constructor, destructor.
2375         (linespec_parser): Remove typedef.
2376         (~linespec_parser): Rename from linespec_parser_delete.
2377         (linespec_lex_to_end, linespec_complete_label)
2378         (linespec_complete): Update.
2379         (decode_line_full): Remove cleanups.
2380         (decode_line_1): Update.
2381
2382 2019-01-02  Tom Tromey  <tom@tromey.com>
2383
2384         * python/python-internal.h (inferior_to_inferior_object): Change
2385         return type.
2386         * python/py-exitedevent.c (create_exited_event_object): Update.
2387         * python/py-inferior.c (inferior_to_inferior_object): Return
2388         gdbpy_ref.
2389         (python_new_inferior, python_inferior_deleted)
2390         (thread_to_thread_object, delete_thread_object)
2391         (build_inferior_list, gdbpy_selected_inferior): Update.
2392         * python/py-infthread.c (create_thread_object): Update.  Also fail
2393         if inferior_to_inferior_object fails.
2394
2395 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2396
2397         * inferior.h (class inferior) <displaced_step_state>: New field.
2398         * infrun.h (struct displaced_step_state): Move here from
2399         infrun.c.  Initialize fields, add constructor.
2400         <inf>: Remove field.
2401         <reset>: New method.
2402         * infrun.c (struct displaced_step_inferior_state): Move to
2403         infrun.h.
2404         (displaced_step_inferior_states): Remove.
2405         (get_displaced_stepping_state): Adust.
2406         (displaced_step_in_progress_any_inferior): Adjust.
2407         (displaced_step_in_progress_thread): Adjust.
2408         (displaced_step_in_progress): Adjust.
2409         (add_displaced_stepping_state): Remove.
2410         (get_displaced_step_closure_by_addr): Adjust.
2411         (remove_displaced_stepping_state): Remove.
2412         (infrun_inferior_exit): Call displaced_step_state.reset.
2413         (use_displaced_stepping): Don't check for NULL.
2414         (displaced_step_prepare_throw): Call
2415         get_displaced_stepping_state.
2416         (displaced_step_fixup): Don't check for NULL.
2417         (prepare_for_detach): Don't check for NULL.
2418
2419 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2420
2421         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2422          in case of call that did not complete.
2423
2424 2019-01-02  Andrey Utkin  <autkin@undo.io>
2425
2426         * symfile.c (find_separate_debug_file): Fix search of debug files for
2427         remote debuggee.
2428
2429 2019-01-02  Tom Tromey  <tom@tromey.com>
2430
2431         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2432         indentation.
2433         * python/py-frame.c (frapy_older): Remove cast.
2434         (frapy_newer): Likewise.
2435         * python/py-breakpoint.c (local_setattro): Remove cast.
2436         * python/py-arch.c (archpy_name): Remove local variable.
2437         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2438
2439 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2440
2441         * unittests/basic_string_view/element_access/char/empty.cc:
2442         Fix year range in copyright header.
2443
2444 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2445
2446         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2447         Delete.
2448         <operator==>: Update with for removed field.
2449         <hash>: Likewise.
2450         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2451         <isa_features>: ...this.
2452         <abi_features>: New field.
2453         (riscv_isa_flen): Update comment.
2454         (riscv_abi_xlen): New declaration.
2455         (riscv_abi_flen): New declaration.
2456         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2457         isa_features.
2458         (riscv_abi_xlen): New function.
2459         (riscv_isa_flen): Update to get answer from isa_features.
2460         (riscv_abi_flen): New function.
2461         (riscv_has_fp_abi): Update to get answer from abi_features.
2462         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2463         xlen and flen.
2464         (riscv_call_info) <xlen, flen>: Update comment.
2465         (riscv_call_arg_struct): Remove invalid assertions
2466         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2467         is removed.
2468         (riscv_gdbarch_init): Gather isa features and abi features
2469         separately, ensure both match on the gdbarch when reusing an old
2470         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2471         a target with 64-bit float hardware.
2472
2473 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2474
2475         * source.c (search_command_helper): Stop reverse search
2476         when line 1 has been searched.
2477
2478 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2479
2480         * record-full.c (record_full_base_target::close): Rewrite
2481         record_full_core_buf_list free logic.
2482
2483 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2484
2485         * break-catch-syscall.c (print_one_catch_syscall): xfree
2486         the last text.
2487
2488 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2489
2490         * top.c (print_gdb_version): Update Copyright year in version
2491         message.
2492
2493 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2494
2495         Update copyright year range in all GDB files.
2496
2497 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2498
2499         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2500
2501 For older changes see ChangeLog-2018.
2502 \f
2503 Local Variables:
2504 mode: change-log
2505 left-margin: 8
2506 fill-column: 74
2507 version-control: never
2508 coding: utf-8
2509 End:
2510