gdb/ChangeLog

   1 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
   2
   3         * gdbtypes.c (lookup_struct_elt_type): Update comment and
   4         remove disabled code block.
   5
   6 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
   7
   8         * gdbarch.sh (get_thread_local_address): New method.
   9         * gdbarch.h, gdbarch.c: Regenerate.
  10         * target.c (target_translate_tls_address): Use
  11         gdbarch_get_thread_local_address if present instead of
  12         target::get_thread_local_address.
  13
  14 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  15
  16         * target.h (target::get_thread_local_address): Update comment.
  17
  18 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  19
  20         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
  21         objfile->separate_debug_objfile_backlink if not NULL.
  22
  23 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  24
  25         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
  26         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
  27         (amd64bsd_store_inferior_registers): Likewise.
  28         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  29         Enable segment base registers.
  30         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
  31         PT_GETFSBASE and PT_GETGSBASE.
  32         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
  33         PT_SETGSBASE.
  34         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
  35         segment base registers.
  36         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
  37
  38 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  39
  40         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  41         Update calls to i386_target_description to add 'segments'
  42         parameter.
  43         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
  44         add segment base registers.
  45         * arch/i386.c (i386_create_target_description): Add 'segments'
  46         parameter to enable segment base registers.
  47         * arch/i386.h (i386_create_target_description): Likewise.
  48         * features/i386/32bit-segments.xml: New file.
  49         * features/i386/32bit-segments.c: Generate.
  50         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
  51         call to i386_target_description to add 'segments' parameter.
  52         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
  53         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
  54         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
  55         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
  56         if feature is present.
  57         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
  58         Add 'segments' parameter to call to i386_target_description.
  59         (i386_target_description): Add 'segments' parameter to enable
  60         segment base registers.
  61         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
  62         to call to i386_target_description.
  63         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
  64         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
  65         Define I386_NUM_REGS.
  66         (i386_target_description): Add 'segments' parameter to enable
  67         segment base registers.
  68
  69 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  70
  71         PR/24325
  72         * source-cache.c: #undef open and close, to avoid unresolved
  73         externals during linking.
  74
  75 2019-03-12  Tom Tromey  <tromey@adacore.com>
  76
  77         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
  78         const.  Add initializers.
  79         (_initialize_remote): Don't initialize ptid globals.
  80
  81 2019-03-12  Pedro Alves  <palves@redhat.com>
  82
  83         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
  84
  85 2019-03-12  Pedro Alves  <palves@redhat.com>
  86
  87         * cp-name-parser.y (main): Remove unused 'len' variable.
  88
  89 2019-03-12  Tom Tromey  <tromey@adacore.com>
  90
  91         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
  92         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
  93
  94 2019-03-12  Tom Tromey  <tromey@adacore.com>
  95
  96         * linux-nat.c (iterate_over_lwps): Update.
  97         (stop_callback): Remove parameter.
  98         (stop_wait_callback, detach_callback, resume_set_callback)
  99         (select_singlestep_lwp_callback, set_ignore_sigint)
 100         (status_callback, resumed_callback, resume_clear_callback)
 101         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 102         data parameter.
 103         (linux_nat_target::detach, linux_nat_target::resume)
 104         (linux_stop_and_wait_all_lwps, select_event_lwp)
 105         (linux_nat_filter_event, linux_nat_wait_1)
 106         (linux_nat_target::kill, linux_nat_target::stop)
 107         (linux_nat_target::stop): Update.
 108         (linux_nat_resume_callback): Change type.
 109         (resume_stopped_resumed_lwps, count_events_callback)
 110         (select_event_lwp_callback): Likewise.
 111         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 112         * arm-linux-nat.c (struct update_registers_data): Remove.
 113         (update_registers_callback): Change type.
 114         (arm_linux_insert_hw_breakpoint1): Update.
 115         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 116         parameter.
 117         (x86_linux_dr_set_addr): Update.
 118         (x86_linux_dr_set_control): Update.
 119         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 120         (iterate_over_lwps): Use gdb::function_view.
 121         * nat/aarch64-linux-hw-point.c (struct
 122         aarch64_dr_update_callback_param): Remove.
 123         (debug_reg_change_callback): Change type.
 124         (aarch64_notify_debug_reg_change): Update.
 125         * s390-linux-nat.c (s390_refresh_per_info): Update.
 126
 127 2019-03-11  Tom Tromey  <tromey@adacore.com>
 128
 129         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 130         redundant assignment to "this_cu".
 131
 132 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 133
 134         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 135
 136 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 137
 138         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 139         from...
 140         (rank_one_type): ... this.
 141
 142 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 143
 144         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 145         from...
 146         (rank_one_type): ... this.
 147
 148 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 149
 150         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 151         from...
 152         (rank_one_type): ... this.
 153
 154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 155
 156         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 157         from...
 158         (rank_one_type): ... this.
 159
 160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 161
 162         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 163         from...
 164         (rank_one_type): ... this.
 165
 166 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 167
 168         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 169         from...
 170         (rank_one_type): ... this.
 171
 172 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 173
 174         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 175         from...
 176         (rank_one_type): ... this.
 177
 178 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 179
 180         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 181         from...
 182         (rank_one_type): ... this.
 183
 184 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 185
 186         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 187         from...
 188         (rank_one_type): ... this.
 189
 190 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 191
 192         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 193         from...
 194         (rank_one_type): ... this.
 195
 196 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 197
 198         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 199         from...
 200         (rank_one_type): ... this.
 201
 202 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 203
 204         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 205         from...
 206         (rank_one_type): ... this.
 207
 208 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 209
 210         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 211         inferior-events' shows the example events.
 212
 213 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 214
 215         Support styling on native MS-Windows console
 216
 217         PR/24315
 218         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 219         on MS-Windows if $TERM is not defined.
 220
 221         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 222
 223         * posix-hdep.c (gdb_console_fputs):
 224         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 225         functions.
 226         * ui-file.h (gdb_console_fputs): Add prototype.
 227
 228         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 229         back to fputs only if the former returns zero.
 230
 231 2019-03-07  Tom Tromey  <tom@tromey.com>
 232
 233         * symmisc.c (print_symbol_bcache_statistics): Update.
 234         (print_objfile_statistics): Update.
 235         * symfile.c (allocate_symtab): Update.
 236         * stabsread.c: Don't include bcache.h.
 237         * psymtab.h (struct psymbol_bcache): Don't declare.
 238         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 239         (psymbol_bcache_init, psymbol_bcache_free)
 240         (psymbol_bcache_get_bcache): Don't declare.
 241         * psymtab.c (struct psymbol_bcache): Remove.
 242         (psymtab_storage::psymtab_storage): Update.
 243         (psymtab_storage::~psymtab_storage): Update.
 244         (psymbol_bcache_init, psymbol_bcache_free)
 245         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 246         (add_psymbol_to_bcache): Update.
 247         (allocate_psymtab): Update.
 248         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 249         macro_cache>: No longer pointers.
 250         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 251         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 252         * macrotab.c (macro_bcache): Update.
 253         * macroexp.c: Don't include bcache.h.
 254         * gdbtypes.c (check_types_worklist): Update.
 255         (types_deeply_equal): Remove TRY/CATCH.  Update.
 256         * elfread.c (elf_symtab_read): Update.
 257         * dwarf2read.c: Don't include bcache.h.
 258         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 259         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 260         (print_bcache_statistics, bcache_memory_used): Don't declare.
 261         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 262         methods.  Rename all data members.
 263         * bcache.c (struct bcache): Move to bcache.h.
 264         (bcache::expand_hash_table): Rename from expand_hash_table.
 265         (bcache): Remove.
 266         (bcache::insert): Rename from bcache_full.
 267         (bcache::compare): Rename from bcache_compare.
 268         (bcache_xmalloc): Remove.
 269         (bcache::~bcache): Rename from bcache_xfree.
 270         (bcache::print_statistics): Rename from print_bcache_statistics.
 271         (bcache::memory_used): Rename from bcache_memory_used.
 272
 273 2019-03-07  Pedro Alves  <palves@redhat.com>
 274
 275         * infrun.c (normal_stop): Also check for
 276         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 277
 278 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 279
 280         * f-lang.c (value_from_host_double): Moved to...
 281         * value.c (value_from_host_double): ...here.
 282         * value.h (value_from_host_double): Declare.
 283         * guile/scm-math.c (vlscm_convert_typed_number): Use
 284         value_from_host_double.
 285         (vlscm_convert_number): Likewise.
 286         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 287         * python/py-value.c (convert_value_from_python): Likewise.
 288
 289 2019-03-06  Tom Tromey  <tom@tromey.com>
 290
 291         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 292
 293 2019-03-06  Tom Tromey  <tom@tromey.com>
 294
 295         * utils.h (free_current_contents): Don't declare.
 296         * utils.c (free_current_contents): Remove.
 297
 298 2019-03-06  Tom Tromey  <tom@tromey.com>
 299
 300         * top.c (quit_force): Update.
 301         * main.c (captured_command_loop): Update.
 302         * common/new-op.c (operator new): Update.
 303         * common/common-exceptions.c (struct catcher)
 304         <save_cleanup_chain>: Remove member.
 305         (exceptions_state_mc_init): Update.
 306         (exception_try_scope_entry): Return nullptr.
 307         (exception_try_scope_exit, exception_rethrow)
 308         (throw_exception_sjlj, throw_exception_cxx): Update.
 309         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 310         (all_cleanups, do_cleanups, discard_cleanups)
 311         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 312         (restore_cleanups, restore_final_cleanups): Don't declare.
 313         (do_final_cleanups): Remove parameter.
 314         * common/cleanups.c (cleanup_chain, make_cleanup)
 315         (make_cleanup_dtor, all_cleanups, do_cleanups)
 316         (discard_my_cleanups, discard_cleanups)
 317         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 318         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 319         (null_cleanup): Remove.
 320         (do_final_cleanups): Remove parameter.
 321
 322 2019-03-06  Tom Tromey  <tom@tromey.com>
 323
 324         * remote.c (remote_target::remote_parse_stop_reply): Use
 325         unique_xmalloc_ptr.
 326
 327 2019-03-06  Tom Tromey  <tom@tromey.com>
 328
 329         * stabsread.c (struct stabs_field_info): Rename from field_info.
 330         <list, fnlist>: Add initializers.
 331         <obstack>: New member.
 332         (read_member_functions, read_struct_fields, read_baseclasses):
 333         Allocate on obstack.  Don't use cleanups.
 334         (read_one_struct_field, read_member_functions, read_struct_fields)
 335         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 336         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 337         (read_struct_type): Update.
 338
 339 2019-03-06  Tom Tromey  <tom@tromey.com>
 340
 341         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 342         * common/filestuff.h (make_cleanup_close): Don't declare.
 343         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 344         Remove.
 345
 346 2019-03-06  Tom Tromey  <tom@tromey.com>
 347
 348         * solib-aix.c: Use make_scope_exit.
 349
 350 2019-03-06  Tom Tromey  <tom@tromey.com>
 351
 352         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 353         Use make_scope_exit.
 354
 355 2019-03-06  Tom Tromey  <tom@tromey.com>
 356
 357         * solib-svr4.c (disable_probes_interface): Remove parameter.
 358         (svr4_handle_solib_event): Use make_scope_exit.
 359
 360 2019-03-06  Tom Tromey  <tom@tromey.com>
 361
 362         * remote.c (struct stop_reply_deleter): Remove.
 363         (stop_reply_up): Update.
 364         (struct stop_reply): Derive from notif_event.  Don't typedef.
 365         <regcache>: Now a std::vector.
 366         (stop_reply_xfree): Remove.
 367         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 368         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 369         (remote_target::discard_pending_stop_replies): Use delete.
 370         (remote_target::remote_parse_stop_reply): Update.
 371         (remote_target::process_stop_reply): Update.
 372         * remote-notif.h (struct notif_event): Add virtual destructor.
 373         Remove "dtr" member.
 374         (struct notif_client) <alloc_event>: Return a unique_ptr.
 375         (notif_event_xfree): Don't declare.
 376         (notif_event_up): New typedef.
 377         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 378         (notif_event_xfree, do_notif_event_xfree): Remove.
 379         (remote_notif_state_xfree): Update.
 380
 381 2019-03-06  Tom Tromey  <tom@tromey.com>
 382
 383         * infrun.c (displaced_step_clear_cleanup): Now a
 384         forward_scope_exit type.
 385         (displaced_step_prepare_throw): Update.
 386         (displaced_step_fixup): Update.
 387
 388 2019-03-06  Tom Tromey  <tom@tromey.com>
 389
 390         * inferior.h (class inferior): Update comment.
 391         * gdbthread.h (class thread_info): Update comment.
 392
 393 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 394             Tom Tromey  <tom@tromey.com>
 395
 396         * stabsread.h (struct stab_section_list): Remove.
 397         (coffstab_build_psymtabs): Update.
 398         * dbxread.c (symbuf_sections): Now a std::vector.
 399         (sect_idx): New global.
 400         (fill_symbuf): Update.
 401         (coffstab_build_psymtabs): Change type of stabsects parameter.
 402         Update.
 403         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 404         std::vector.
 405         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 406         (coff_locate_sections): Update.
 407         (coff_symfile_read): Remove cleanups.  Update.
 408         (init_stringtab): Add storage parameter.
 409         (free_stringtab, free_stringtab_cleanup): Remove.
 410         (init_lineno): Add storage parameter.
 411         (free_linetab, free_linetab_cleanup): Remove.
 412
 413 2019-03-06  Pedro Alves  <palves@redhat.com>
 414
 415         * linux-fork.c (fork_info::clobber_regs): Delete.
 416         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 417         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 418         comment.  Adjust.
 419         (scoped_switch_fork_info::scoped_switch_fork_info)
 420         (checkpoint_command, linux_fork_context): Adjust
 421         fork_save_infrun_state calls.
 422
 423 2019-03-06  Pedro Alves  <palves@redhat.com>
 424
 425         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 426         (inf_has_multiple_threads): Return 'bool' and rewrite using
 427         inferior_info::threads().
 428
 429 2019-03-06  Pedro Alves  <palves@redhat.com>
 430
 431         * linux-fork.c: Include <list>.
 432         (fork_list): Now a std::list instance.
 433         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 434         (forks_exist_p, find_last_fork): Adjust.
 435         (new_fork): Delete.
 436         (one_fork_p): New.
 437         (add_fork): Adjust.
 438         (free_fork): Delete, folded into fork_info::~fork_info().
 439         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 440         Adjust.
 441         (init_fork_list): Delete.
 442         (linux_fork_killall, linux_fork_mourn_inferior)
 443         (linux_fork_detach, info_checkpoints_command): Adjust.
 444         (_initialize_linux_fork): No longer call init_fork_list.
 445
 446 2019-03-06  Pedro Alves  <palves@redhat.com>
 447
 448         * linux-fork.c (new_fork): New, split out of ...
 449         (add_fork): ... this.  Return void.  Move "first fork" special
 450         case from here, to ...
 451         (checkpoint_command): ... here.
 452         * linux-linux.h (add_fork): Return void.
 453
 454 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 455
 456         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 457
 458 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 459             Chris January  <chris.january@arm.com>
 460             David Lecomber  <david.lecomber@arm.com>
 461
 462         * f-exp.y: New token, UNOP_INTRINSIC.
 463         (exp): New pattern using UNOP_INTRINSIC token.
 464         (f77_keywords): Add 'abs' keyword.
 465         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 466         (value_from_host_double): New function.
 467         (evaluate_subexp_f): Support UNOP_ABS.
 468
 469 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 470
 471         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 472         types.
 473
 474 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 475
 476         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 477         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 478         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 479
 480 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 481
 482         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 483
 484 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 485             Chris January  <chris.january@arm.com>
 486
 487         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 488         * f-exp.y: Define 'KIND' token.
 489         (exp): New pattern for KIND expressions.
 490         (ptype): Handle types with a kind extension.
 491         (direct_abs_decl): Extend to spot kind extensions.
 492         (f77_keywords): Add 'kind' to the list.
 493         (push_kind_type): New function.
 494         (convert_to_kind_type): New function.
 495         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 496         * parse.c (operator_length_standard): Likewise.
 497         * parser-defs.h (enum type_pieces): Add tp_kind.
 498         * std-operator.def: Add UNOP_KIND.
 499
 500 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * f-exp.y (f_parse): Set yydebug.
 503
 504 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 505
 506         * f-lang.c (evaluate_subexp_f): New function.
 507         (exp_descriptor_f): New global.
 508         (f_language_defn): Use exp_descriptor_f instead of
 509         exp_descriptor_standard.
 510
 511 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * f-exp.y (struct token): Add comments.
 514         (dot_ops): Remove uppercase versions and the end marker.
 515         (f77_keywords): Likewise.
 516         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 517         entries in the dot_ops array are case insensitive, and use
 518         strncasecmp to compare strings.  Also some whitespace cleanup in
 519         this area.  Similar for the f77_keywords array, except entries in
 520         this list might be case sensitive.
 521
 522 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 523
 524         * f-exp.y (struct f77_boolean_val): Add comments.
 525         (boolean_values): Remove uppercase versions, and end marker.
 526         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 527         and use strncasecmp to achieve case insensitivity.  Additionally,
 528         perform whitespace cleanup around this code.
 529
 530 2019-03-06  Tom Tromey  <tromey@adacore.com>
 531
 532         * remote-sim.c (gdbsim_target_open): Use result of
 533         gdb_argv::release.
 534
 535 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 536         Dirk Schubert  <dirk.schubert@arm.com>
 537         Chris January  <chris.january@arm.com>
 538
 539         * eval.c (evaluate_subexp_standard): Call Fortran argument
 540         wrapping logic.
 541         * f-lang.c (struct value): A value which can be passed into a
 542         Fortran function call.
 543         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 544         where appropriate.
 545         (struct type): Value ready for a Fortran function call.
 546         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 547         is needed.
 548         * f-lang.h (fortran_argument_convert): Declaration.
 549         (fortran_preserve_arg_pointer): Declaration.
 550         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 551
 552 2019-03-05  Tom Tromey  <tromey@adacore.com>
 553
 554         * python/py-prettyprint.c (print_string_repr): Remove #if.
 555         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 556
 557 2019-03-05  Tom Tromey  <tromey@adacore.com>
 558
 559         * target.c (the_dummy_target): Move later.  Change type to
 560         "dummy_target".
 561         (initialize_targets): Don't initialize the_dummy_target.
 562
 563 2019-03-05  Tom Tromey  <tromey@adacore.com>
 564
 565         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 566         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 567
 568 2019-03-05  Tom Tromey  <tromey@adacore.com>
 569
 570         * windows-nat.c (windows_nat_target::attach)
 571         (windows_nat_target::detach): Don't call gdb_flush.
 572         * valprint.c (generic_val_print, val_print, val_print_string):
 573         Don't call gdb_flush.
 574         * utils.c (defaulted_query): Don't call gdb_flush.
 575         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 576         * target.c (target_announce_detach): Don't call gdb_flush.
 577         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 578         * remote.c (extended_remote_target::attach): Don't call
 579         gdb_flush.
 580         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 581         * printcmd.c (do_examine): Don't call gdb_flush.
 582         (info_display_command): Don't call gdb_flush.
 583         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 584         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 585         * memattr.c (info_mem_command): Don't call gdb_flush.
 586         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 587         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 588         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 589         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 590         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 591         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 592         (gnu_nat_target::detach): Don't call gdb_flush.
 593         * f-valprint.c (f_val_print): Don't call gdb_flush.
 594         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 595         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 596         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 597         gdb_flush.
 598         * c-valprint.c (c_val_print): Don't call gdb_flush.
 599         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 600
 601 2019-03-05  Tom Tromey  <tromey@adacore.com>
 602
 603         * varobj.c (update_dynamic_varobj_children): Update.
 604         (install_default_visualizer): Use reset, not release.
 605         * value.c (set_internalvar): Update.
 606         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 607         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 608         ATTRIBUTE_UNUSED_RESULT.
 609
 610 2019-03-05  Tom Tromey  <tromey@adacore.com>
 611
 612         * remote.c (class scoped_remote_fd) <release>: Add
 613         ATTRIBUTE_UNUSED_RESULT.
 614
 615 2019-03-05  Tom Tromey  <tromey@adacore.com>
 616
 617         * macroexp.c (struct macro_buffer) <release>: Add
 618         ATTRIBUTE_UNUSED_RESULT.
 619
 620 2019-03-05  Tom Tromey  <tromey@adacore.com>
 621
 622         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 623         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 624         ATTRIBUTE_UNUSED_RESULT.
 625
 626 2019-03-05  Tom Tromey  <tromey@adacore.com>
 627
 628         * common/scoped_fd.h (class scoped_fd) <release>: Add
 629         ATTRIBUTE_UNUSED_RESULT.
 630
 631 2019-03-05  Tom Tromey  <tromey@adacore.com>
 632
 633         * parser-defs.h (struct parser_state) <release>: Add
 634         ATTRIBUTE_UNUSED_RESULT.
 635
 636 2019-03-05  Tom Tromey  <tromey@adacore.com>
 637
 638         * utils.h (class gdb_argv) <release>: Add
 639         ATTRIBUTE_UNUSED_RESULT.
 640         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 641
 642 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 643
 644         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 645         for-loop range, to avoid compiler warnings.
 646
 647         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 648         avoid compiler warnings about unused variables.
 649
 650         * NEWS: Mention end of support for native debugging on MS-Windows
 651         before XP.
 652
 653         PR gdb/24292
 654         * common/netstuff.c:
 655         * gdbserver/gdbreplay.c
 656         * gdbserver/remote-utils.c:
 657         * ser-tcp.c:
 658         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 659         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 660         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 661         'getaddrinfo' and 'freeaddrinfo' were not available before
 662         Windows XP, and mingw.org's MinGW headers by default define
 663         _WIN32_WINNT to 0x500.
 664
 665 2019-03-01  Gary Benson <gbenson@redhat.com>
 666
 667         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 668
 669 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 670             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 671
 672         PR gdb/8527
 673         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 674         set_sigint_trap, clear_sigint_trap.
 675
 676 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 677
 678         * target.c (target_detach): Clear the regcache and the
 679         frame cache.
 680
 681 2019-02-27  Pedro Alves  <palves@redhat.com>
 682
 683         * utils.c (set_screen_size): When we cap the height/width sizes,
 684         tweak the corresponding command variable to show "unlimited":
 685
 686 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 687             Pedro Alves  <palves@redhat.com>
 688
 689         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 690         before calling rl_set_screen_size.
 691
 692 2019-02-27  Tom Tromey  <tromey@adacore.com>
 693
 694         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 695         define.
 696         * python/py-value.c: Remove Python 2.4 workaround.
 697         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 698         workaround.
 699         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 700         Python 2.4 workaround.
 701         * python/python-internal.h: Remove Python 2.4 comment.
 702         (Py_ssize_t): Don't define.
 703         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 704         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 705         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 706         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 707         * python/python.c (do_start_initialization): Remove Python 2.4
 708         workaround.
 709         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 710         (print_children): Remove Python 2.4 workaround.
 711         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 712         workaround.
 713         (CHARBUFFERPROC_NAME): Remove.
 714         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 715         Python 2.4 workaround.
 716
 717 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 718
 719         * NEWS: Note minimum Python version.
 720
 721 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 722
 723         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 724         code from these functions.  Remove corresponding ifdefs.  Use
 725         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 726         Remove gotos and target of gotos.
 727         (infpy_search_memory): Likewise.
 728
 729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 730
 731         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 732         (hppa_gdbarch_init): Don't register deleted functions with
 733         gdbarch.
 734
 735 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 736
 737         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 738         (h8300_unwind_sp): Delete.
 739         (h8300_dummy_id): Delete.
 740         (h8300_gdbarch_init): Don't register deleted functions with
 741         gdbarch.
 742
 743 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 744
 745         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 746         (ft32_unwind_pc): Delete.
 747         (ft32_unwind_sp): Delete.
 748         (ft32_gdbarch_init): Don't register deleted functions with
 749         gdbarch.
 750
 751 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 752
 753         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 754         (frv_unwind_pc): Delete.
 755         (frv_unwind_sp): Delete.
 756         (frv_gdbarch_init): Don't register deleted functions with
 757         gdbarch.
 758
 759 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 760
 761         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
 762         (riscv_unwind_pc): Delete.
 763         (riscv_unwind_sp): Delete.
 764         (riscv_gdbarch_init): Don't register deleted functions with
 765         gdbarch.
 766
 767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 768
 769         * gdb/csky-tdep.c (csky_dummy_id): Delete.
 770         (csky_unwind_pc): Delete.
 771         (csky_unwind_sp): Delete.
 772         (csky_gdbarch_init): Don't register deleted functions with
 773         gdbarch.
 774
 775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 776
 777         * gdb/cris-tdep.c (cris_dummy_id): Delete.
 778         (cris_unwind_pc): Delete.
 779         (cris_unwind_sp): Delete.
 780         (cris_gdbarch_init): Don't register deleted functions with
 781         gdbarch.
 782
 783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 784
 785         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 786         (bfin_unwind_pc): Delete.
 787         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 788
 789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 790
 791         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 792         (arm_unwind_pc): Delete.
 793         (arm_unwind_sp): Delete.
 794         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 795
 796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 797
 798         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 799         (arc_unwind_pc): Delete.
 800         (arc_unwind_sp): Delete.
 801         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 802
 803 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 804
 805         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 806         (alpha_unwind_pc): Delete.
 807         (alpha_gdbarch_init): Don't register deleted functions with
 808         gdbarch.
 809
 810 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 813         (aarch64_unwind_pc): Delete.
 814         (aarch64_unwind_sp): Delete.
 815         (aarch64_gdbarch_init): Don't register deleted functions with
 816         gdbarch.
 817
 818 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * gdbtypes.c (type_align): Don't consider static members when
 821         computing structure alignment.
 822
 823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 826         return 0 for other types.
 827         * arch-utils.c (default_type_align): Always return 0.
 828         * gdbarch.h: Regenerate.
 829         * gdbarch.sh (type_align): Extend comment.
 830         * gdbtypes.c (type_align): Add additional comments, always call
 831         gdbarch_type_align before applying the default rules.
 832         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 833         generic code will then apply a suitable default.
 834         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 835         types, return 0 for other types.
 836
 837 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 838
 839         * NEWS: Create a new section for the next release branch.
 840         Rename the section of the current branch, now that it has
 841         been cut.
 842
 843 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 844
 845         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 846         * version.in: Bump version to 8.3.50.DATE-git.
 847
 848 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 849
 850         * aix-thread.c (ptid_cmp): Remove unused variable.
 851         (get_signaled_thread): Likewise.
 852         (store_regs_user_thread): Likewise.
 853         (store_regs_kernel_thread): Likewise.
 854         (fetch_regs_kernel_thread): Remove shadowed variable.
 855
 856 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 857
 858         * features/riscv/32bit-cpu.xml: Add register numbers.
 859         * features/riscv/32bit-fpu.c: Regenerate.
 860         * features/riscv/32bit-fpu.xml: Add register numbers.
 861         * features/riscv/64bit-cpu.xml: Add register numbers.
 862         * features/riscv/64bit-fpu.c: Regenerate.
 863         * features/riscv/64bit-fpu.xml: Add register numbers.
 864
 865 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 866
 867         * NEWS: Mention two argument form of gdb.Value constructor.
 868         * python/py-value.c (convert_buffer_and_type_to_value): New
 869         function.
 870         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 871         Add support for handling an optional second argument.  Call
 872         convert_buffer_and_type_to_value as appropriate.
 873         * python/python-internal.h (Py_buffer_deleter): New struct.
 874         (Py_buffer_up): New typedef.
 875
 876 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 877
 878         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 879         instead of releasing ownership.
 880
 881 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 882
 883         * dwarf2read.c (open_and_init_dwp_file): Call
 884         elf_numsections instead of bfd_count_sections to initialize
 885         dwp_file->num_sections.
 886
 887 2019-02-25  Tom Tromey  <tromey@adacore.com>
 888
 889         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 890
 891 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 892
 893         * gcore.in: Add '--readnever' option when invoking GDB.
 894
 895 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 896
 897         * MAINTAINERS: Update my email address.
 898
 899 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 900
 901         * build-id.c (build_id_to_debug_bfd_1): New function.
 902         (build_id_to_debug_bfd): Look for separate debug file in
 903         sysroot.
 904
 905 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 906
 907         * gdbarch.sh: Update the copyright year range that is placed into
 908         generated files.
 909
 910 2019-02-22  Keith Seitz  <keiths@redhat.com>
 911
 912         PR symtab/23853
 913         * linespec.c (create_sals_line_offset): Search for the default
 914         symtab's filename instead of its fullname.
 915
 916 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 917
 918         * NEWS: Update style defaults.
 919
 920 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 921
 922         * main.c (captured_main_1): Disable styling in batch mode.
 923
 924 2019-02-20  Tom Tromey  <tom@tromey.com>
 925
 926         * symtab.c (symtab_symbol_info): Fix typos.
 927
 928 2019-02-20  Tom Tromey  <tromey@adacore.com>
 929
 930         * findcmd.c (_initialize_mem_search): Use upper case for
 931         metasyntactic variables.
 932
 933 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 934
 935         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 936         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 937
 938 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 939
 940         * top.h (source_file_name): Change to std::string.
 941         * top.c (source_file_name): Likewise.
 942         (command_line_input): Adjust.
 943         * cli/cli-script.c (script_from_file): Adjust.
 944
 945 2019-02-19  Tom Tromey  <tromey@adacore.com>
 946
 947         * ravenscar-thread.c
 948         (ravenscar_thread_target::update_thread_list): Don't call
 949         ada_build_task_list.
 950         * ada-lang.h (ada_build_task_list): Don't declare.
 951         * ada-tasks.c (struct ada_tasks_inferior_data)
 952         <task_list_valid_p>: Now bool.
 953         (read_known_tasks, ada_task_list_changed)
 954         (ada_tasks_invalidate_inferior_data): Update.
 955         (read_known_tasks_array): Return bool.
 956         (read_known_tasks_list): Likewise.
 957         (read_known_tasks): Return void.
 958         (ada_build_task_list): Now static.
 959
 960 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 961
 962         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 963         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 964
 965 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 966
 967         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 968         variant for ada_tasks_pspace_data_handle and
 969         ada_tasks_inferior_data_handle.
 970         (ada_tasks_pspace_data_cleanup): New function.
 971         (ada_tasks_inferior_data_cleanup): New function.
 972
 973 2019-02-17  Tom Tromey  <tom@tromey.com>
 974
 975         * macrotab.h (macro_source_fullname): Return a std::string.
 976         * macrotab.c (macro_include, check_for_redefinition)
 977         (macro_undef, macro_lookup_definition, foreach_macro)
 978         (foreach_macro_in_scope): Update.
 979         (macro_source_fullname): Return a std::string.
 980         * macrocmd.c (show_pp_source_pos): Update.
 981
 982 2019-02-17  Tom Tromey  <tom@tromey.com>
 983
 984         * macrocmd.c (show_pp_source_pos): Style the file names.
 985
 986 2019-02-17  Tom Tromey  <tom@tromey.com>
 987
 988         PR tui/24197:
 989         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 990
 991 2019-02-17  Tom Tromey  <tom@tromey.com>
 992
 993         * ada-lang.c (user_select_syms): Use filtered printing.
 994         * utils.c (wrap_style): New global.
 995         (desired_style): Remove.
 996         (emit_style_escape): Add stream parameter.
 997         (set_output_style, reset_terminal_style, prompt_for_continue):
 998         Update.
 999         (flush_wrap_buffer): Only flush gdb_stdout.
1000         (wrap_here): Set wrap_style.
1001         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1002         treat escape sequences as a character.  Change when wrap buffer is
1003         flushed.
1004         (fputs_styled): Do not set the output style when the default is
1005         requested.
1006         * ui-style.h (struct ui_file_style) <is_default>: New method.
1007         * source.c (print_source_lines_base): Emit escape sequences in one
1008         piece.
1009
1010 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1011
1012         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1013         integers and enumeration types.
1014
1015 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1016
1017         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1018         instead of lookup_symbol_in_language
1019         (do_exact_match): New function.
1020         (ada_get_symbol_name_matcher): Return do_exact_match when
1021         doing a verbatim match.
1022
1023 2019-02-15  Tom Tromey  <tromey@adacore.com>
1024
1025         * ravenscar-thread.c (ravenscar_thread_target::resume)
1026         (ravenscar_thread_target::wait): Special case wildcard requests.
1027
1028 2019-02-15  Tom Tromey  <tromey@adacore.com>
1029
1030         * ravenscar-thread.c (base_ptid): Remove.
1031         (struct ravenscar_thread_target) <close>: New method.
1032         <m_base_ptid>: New member.
1033         <update_inferior_ptid, active_task, task_is_currently_active,
1034         runtime_initialized>: Declare methods.
1035         <ravenscar_thread_target>: Add constructor.
1036         (ravenscar_thread_target::task_is_currently_active)
1037         (ravenscar_thread_target::update_inferior_ptid)
1038         (ravenscar_runtime_initialized): Rename.  Now methods.
1039         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1040         (ravenscar_thread_target::update_thread_list): Update.
1041         (ravenscar_thread_target::active_task): Now method.
1042         (ravenscar_thread_target::store_registers)
1043         (ravenscar_thread_target::prepare_to_store)
1044         (ravenscar_thread_target::prepare_to_store)
1045         (ravenscar_thread_target::mourn_inferior): Update.
1046         (ravenscar_inferior_created): Use "new" to create target.
1047         (ravenscar_thread_target::get_ada_task_ptid): Update.
1048         (_initialize_ravenscar): Don't initialize base_ptid.
1049         (ravenscar_ops): Remove global.
1050
1051 2019-02-15  Tom Tromey  <tromey@adacore.com>
1052
1053         * target.h (push_target): Declare new overload.
1054         * target.c (push_target): New overload, taking an rvalue reference.
1055         * remote.c (remote_target::open_1): Use push_target overload.
1056         * corelow.c (core_target_open): Use push_target overload.
1057
1058 2019-02-15  Tom Tromey  <tromey@adacore.com>
1059
1060         * ravenscar-thread.c (is_ravenscar_task)
1061         (ravenscar_task_is_currently_active): Return bool.
1062         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1063         (_initialize_ravenscar): Remove "(void)".
1064         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1065         Return bool.
1066
1067 2019-02-15  Tom Tromey  <tromey@adacore.com>
1068
1069         * ravenscar-thread.c (ravenscar_runtime_initializer)
1070         (has_ravenscar_runtime, get_running_thread_id)
1071         (ravenscar_thread_target::resume): Fix indentation.
1072
1073 2019-02-15  Tom Tromey  <tromey@adacore.com>
1074
1075         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1076         from ravenscar_arch_ops.
1077         (sparc_ravenscar_ops::fetch_registers)
1078         (sparc_ravenscar_ops::store_registers): Now methods.
1079         (sparc_ravenscar_prepare_to_store): Remove.
1080         (sparc_ravenscar_ops): Redefine.
1081         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1082         methods and destructor.  Remove members.
1083         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1084         (ravenscar_thread_target::store_registers)
1085         (ravenscar_thread_target::prepare_to_store): Update.
1086         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1087         Remove.
1088         (struct ppc_ravenscar_powerpc_ops): Derive from
1089         ravenscar_arch_ops.
1090         (ppc_ravenscar_powerpc_ops::fetch_registers)
1091         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1092         (ppc_ravenscar_powerpc_ops): Redefine.
1093         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1094         (ppc_ravenscar_e500_ops::fetch_registers)
1095         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1096         (ppc_ravenscar_e500_ops): Redefine.
1097         * aarch64-ravenscar-thread.c
1098         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1099         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1100         (aarch64_ravenscar_fetch_registers)
1101         (aarch64_ravenscar_store_registers): Now methods.
1102         (aarch64_ravenscar_ops): Redefine.
1103
1104 2019-02-15  Tom Tromey  <tromey@adacore.com>
1105
1106         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1107         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1108         (ravenscar_thread_target::stopped_by_watchpoint)
1109         (ravenscar_thread_target::stopped_data_address)
1110         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1111
1112 2019-02-15  Tom Tromey  <tromey@adacore.com>
1113
1114         * ravenscar-thread.c: Fix some typos.
1115
1116 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1117             Tom Tromey  <tromey@adacore.com>
1118
1119         * ada-lang.c (ada_exception_sal): Change addr_string to a
1120         std::string.
1121         (create_ada_exception_catchpoint): Update.
1122
1123 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1124             Tom Tromey  <tromey@adacore.com>
1125
1126         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1127         (bp_location_ops): Remove.
1128         (base_breakpoint_allocate_location): Update.
1129         (free_bp_location): Update.
1130         * ada-lang.c (class ada_catchpoint_location)
1131         <ada_catchpoint_location>: Remove ops parameter.
1132         (ada_catchpoint_location_dtor): Remove.
1133         (ada_catchpoint_location_ops): Remove.
1134         (allocate_location_exception): Update.
1135         * breakpoint.h (struct bp_location_ops): Remove.
1136         (class bp_location) <bp_location>: Remove bp_location_ops
1137         parameter.
1138         <~bp_location>: Add destructor.
1139         <ops>: Remove.
1140
1141 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1142             Pedro Alves  <palves@redhat.com>
1143
1144         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1145         'PATH_MAX'.
1146
1147 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1148             Samuel Thibault  <samuel.thibault@gnu.org>
1149             Thomas Schwinge  <thomas@codesourcery.com>
1150
1151         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1152         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1153
1154 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1155
1156         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1157         (check_empty): Use "const char *".
1158
1159         * gnu-nat.c (gnu_nat_target::detach): Instead of
1160         'detach_inferior (pid)' call
1161         'detach_inferior (find_inferior_pid (pid))'.
1162
1163         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1164         'nat/fork-inferior.o'.
1165         * gnu-nat.c: #include "nat/fork-inferior.h".
1166
1167         * gnu-nat.c (gnu_nat_target::detach): Instead of
1168         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1169         * gnu-nat.h: #include "inf-child.h".
1170         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1171         'i386_gnu_nat_target::fetch_registers'.
1172         (gnu_store_registers): Rename/move to
1173         'i386_gnu_nat_target::store_registers'.
1174
1175         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1176         * gnu-nat.h (mach_thread_info): New function.
1177         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1178
1179         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1180
1181 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1182
1183         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1184
1185 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1186
1187         * windows-nat.c (windows_add_thread): Add new parameter
1188         "main_thread_p" with default value set to false.  Update
1189         function documentation as well as all callers.
1190         (windows_delete_thread): Likewise.
1191         (fake_create_process): Update call to windows_add_thread.
1192         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1193         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1194         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1195         call to windows_delete_thread.
1196
1197 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1198
1199         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1200
1201 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1202
1203         * symfile.c (find_separate_debug_file): Use canonical path of
1204         sysroot with child_path instead of gdb_sysroot if it is valid.
1205
1206 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1207
1208         * symfile.c (find_separate_debug_file): Use child_path to
1209         determine if an object file is under a sysroot.
1210
1211 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1212
1213         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1214         unittests/child-path-selftests.c.
1215         * common/pathstuff.c (child_path): New function.
1216         * common/pathstuff.h (child_path): New prototype.
1217         * unittests/child-path-selftests.c: New file.
1218
1219 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1220
1221         * symfile.c (find_separate_debug_file): Look for separate debug
1222         files in debug directories under the sysroot.
1223
1224 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1225
1226         * symtab.h (struct minimal_symbol data_p): New const method.
1227         (struct minimal_symbol text_p): Likewise.
1228         * symtab.c (output_source_filename): Use file name style
1229         to print file name.
1230         (print_symbol_info): Likewise.
1231         (print_msymbol_info): Use address style to print addresses.
1232         Use function name style to print executable text symbols.
1233         (expand_symtab_containing_pc): Use data_p.
1234         (find_pc_sect_compunit_symtab): Likewise.
1235
1236 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1237
1238         * breakpoint.c (describe_other_breakpoints): Use address style
1239         to print addresses.
1240         (say_where): Likewise.
1241
1242 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1243
1244         * ada-typeprint.c (print_func_type): Print function name
1245         style to print function name.
1246         * c-typeprint.c (c_print_type_1): Likewise.
1247
1248 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1249
1250         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1251         for execve.
1252
1253 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1254
1255         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1256         type_stack.
1257
1258 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1259
1260         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1261         TYPE_CODE_REF types.
1262
1263 2019-02-08  Jim Wilson  <jimw@sifive.com>
1264
1265         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1266         (riscv_linux_fregset): New.
1267         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1268
1269 2019-02-07  Tom Tromey  <tom@tromey.com>
1270
1271         * thread.c (thread_cancel_execution_command): Update.
1272         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1273         methods.
1274         (struct thread_fsm_ops): Remove.
1275         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1276         (thread_fsm_should_stop, thread_fsm_return_value)
1277         (thread_fsm_set_finished, thread_fsm_finished_p)
1278         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1279         Don't declare.
1280         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1281         * infrun.c (clear_proceed_status_thread)
1282         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1283         (print_stop_event): Update.
1284         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1285         Add constructor.
1286         (step_command_fsm_ops): Remove.
1287         (new_step_command_fsm): Remove.
1288         (step_1): Update.
1289         (step_command_fsm::should_stop): Rename from
1290         step_command_fsm_should_stop.
1291         (step_command_fsm::clean_up): Rename from
1292         step_command_fsm_clean_up.
1293         (step_command_fsm::do_async_reply_reason): Rename from
1294         step_command_fsm_async_reply_reason.
1295         (struct until_next_fsm): Inherit from thread_fsm.  Add
1296         constructor.
1297         (until_next_fsm_ops): Remove.
1298         (new_until_next_fsm): Remove.
1299         (until_next_fsm::should_stop): Rename from
1300         until_next_fsm_should_stop.
1301         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1302         (until_next_fsm::do_async_reply_reason): Rename from
1303         until_next_fsm_async_reply_reason.
1304         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1305         constructor.  Change type of breakpoint.
1306         (finish_command_fsm_ops): Remove.
1307         (new_finish_command_fsm): Remove.
1308         (finish_command_fsm::should_stop): Rename from
1309         finish_command_fsm_should_stop.
1310         (finish_command_fsm::clean_up): Rename from
1311         finish_command_fsm_clean_up.
1312         (finish_command_fsm::return_value): Rename from
1313         finish_command_fsm_return_value.
1314         (finish_command_fsm::do_async_reply_reason): Rename from
1315         finish_command_fsm_async_reply_reason.
1316         (finish_command): Update.
1317         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1318         Add constructor.
1319         (call_thread_fsm_ops): Remove.
1320         (call_thread_fsm::call_thread_fsm): Rename from
1321         new_call_thread_fsm.
1322         (call_thread_fsm::should_stop): Rename from
1323         call_thread_fsm_should_stop.
1324         (call_thread_fsm::should_notify_stop): Rename from
1325         call_thread_fsm_should_notify_stop.
1326         (run_inferior_call, call_function_by_hand_dummy): Update.
1327         * cli/cli-interp.c (should_print_stop_to_console): Update.
1328         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1329         Add constructor.  Change type of location_breakpoint,
1330         caller_breakpoint.
1331         (until_break_fsm_ops): Remove.
1332         (new_until_break_fsm): Remove.
1333         (until_break_fsm::should_stop): Rename from
1334         until_break_fsm_should_stop.
1335         (until_break_fsm::clean_up): Rename from
1336         until_break_fsm_clean_up.
1337         (until_break_fsm::do_async_reply_reason): Rename from
1338         until_break_fsm_async_reply_reason.
1339         (until_break_command): Update.
1340         * thread-fsm.c: Remove.
1341         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1342
1343 2019-02-07  Tom Tromey  <tom@tromey.com>
1344
1345         * yy-remap.h: Add include guard.
1346         * xtensa-tdep.h: Add include guard.
1347         * xcoffread.h: Rename include guard.
1348         * varobj-iter.h: Add include guard.
1349         * tui/tui.h: Rename include guard.
1350         * tui/tui-winsource.h: Rename include guard.
1351         * tui/tui-wingeneral.h: Rename include guard.
1352         * tui/tui-windata.h: Rename include guard.
1353         * tui/tui-win.h: Rename include guard.
1354         * tui/tui-stack.h: Rename include guard.
1355         * tui/tui-source.h: Rename include guard.
1356         * tui/tui-regs.h: Rename include guard.
1357         * tui/tui-out.h: Rename include guard.
1358         * tui/tui-layout.h: Rename include guard.
1359         * tui/tui-io.h: Rename include guard.
1360         * tui/tui-hooks.h: Rename include guard.
1361         * tui/tui-file.h: Rename include guard.
1362         * tui/tui-disasm.h: Rename include guard.
1363         * tui/tui-data.h: Rename include guard.
1364         * tui/tui-command.h: Rename include guard.
1365         * tic6x-tdep.h: Add include guard.
1366         * target/waitstatus.h: Rename include guard.
1367         * target/wait.h: Rename include guard.
1368         * target/target.h: Rename include guard.
1369         * target/resume.h: Rename include guard.
1370         * target-float.h: Rename include guard.
1371         * stabsread.h: Add include guard.
1372         * rs6000-tdep.h: Add include guard.
1373         * riscv-fbsd-tdep.h: Add include guard.
1374         * regformats/regdef.h: Rename include guard.
1375         * record.h: Rename include guard.
1376         * python/python.h: Rename include guard.
1377         * python/python-internal.h: Rename include guard.
1378         * python/py-stopevent.h: Rename include guard.
1379         * python/py-ref.h: Rename include guard.
1380         * python/py-record.h: Rename include guard.
1381         * python/py-record-full.h: Rename include guard.
1382         * python/py-record-btrace.h: Rename include guard.
1383         * python/py-instruction.h: Rename include guard.
1384         * python/py-events.h: Rename include guard.
1385         * python/py-event.h: Rename include guard.
1386         * procfs.h: Add include guard.
1387         * proc-utils.h: Add include guard.
1388         * p-lang.h: Add include guard.
1389         * or1k-tdep.h: Rename include guard.
1390         * observable.h: Rename include guard.
1391         * nto-tdep.h: Rename include guard.
1392         * nat/x86-linux.h: Rename include guard.
1393         * nat/x86-linux-dregs.h: Rename include guard.
1394         * nat/x86-gcc-cpuid.h: Add include guard.
1395         * nat/x86-dregs.h: Rename include guard.
1396         * nat/x86-cpuid.h: Rename include guard.
1397         * nat/ppc-linux.h: Rename include guard.
1398         * nat/mips-linux-watch.h: Rename include guard.
1399         * nat/linux-waitpid.h: Rename include guard.
1400         * nat/linux-ptrace.h: Rename include guard.
1401         * nat/linux-procfs.h: Rename include guard.
1402         * nat/linux-osdata.h: Rename include guard.
1403         * nat/linux-nat.h: Rename include guard.
1404         * nat/linux-namespaces.h: Rename include guard.
1405         * nat/linux-btrace.h: Rename include guard.
1406         * nat/glibc_thread_db.h: Rename include guard.
1407         * nat/gdb_thread_db.h: Rename include guard.
1408         * nat/gdb_ptrace.h: Rename include guard.
1409         * nat/fork-inferior.h: Rename include guard.
1410         * nat/amd64-linux-siginfo.h: Rename include guard.
1411         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1412         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1413         * nat/aarch64-linux.h: Rename include guard.
1414         * nat/aarch64-linux-hw-point.h: Rename include guard.
1415         * mn10300-tdep.h: Add include guard.
1416         * mips-linux-tdep.h: Add include guard.
1417         * mi/mi-parse.h: Rename include guard.
1418         * mi/mi-out.h: Rename include guard.
1419         * mi/mi-main.h: Rename include guard.
1420         * mi/mi-interp.h: Rename include guard.
1421         * mi/mi-getopt.h: Rename include guard.
1422         * mi/mi-console.h: Rename include guard.
1423         * mi/mi-common.h: Rename include guard.
1424         * mi/mi-cmds.h: Rename include guard.
1425         * mi/mi-cmd-break.h: Rename include guard.
1426         * m2-lang.h: Add include guard.
1427         * location.h: Rename include guard.
1428         * linux-record.h: Rename include guard.
1429         * linux-nat.h: Add include guard.
1430         * linux-fork.h: Add include guard.
1431         * i386-darwin-tdep.h: Rename include guard.
1432         * hppa-linux-offsets.h: Add include guard.
1433         * guile/guile.h: Rename include guard.
1434         * guile/guile-internal.h: Rename include guard.
1435         * gnu-nat.h: Rename include guard.
1436         * gdb-stabs.h: Rename include guard.
1437         * frv-tdep.h: Add include guard.
1438         * f-lang.h: Add include guard.
1439         * event-loop.h: Add include guard.
1440         * darwin-nat.h: Rename include guard.
1441         * cp-abi.h: Rename include guard.
1442         * config/sparc/nm-sol2.h: Rename include guard.
1443         * config/nm-nto.h: Rename include guard.
1444         * config/nm-linux.h: Add include guard.
1445         * config/i386/nm-i386gnu.h: Rename include guard.
1446         * config/djgpp/nl_types.h: Rename include guard.
1447         * config/djgpp/langinfo.h: Rename include guard.
1448         * compile/gcc-cp-plugin.h: Add include guard.
1449         * compile/gcc-c-plugin.h: Add include guard.
1450         * compile/compile.h: Rename include guard.
1451         * compile/compile-object-run.h: Rename include guard.
1452         * compile/compile-object-load.h: Rename include guard.
1453         * compile/compile-internal.h: Rename include guard.
1454         * compile/compile-cplus.h: Rename include guard.
1455         * compile/compile-c.h: Rename include guard.
1456         * common/xml-utils.h: Rename include guard.
1457         * common/x86-xstate.h: Rename include guard.
1458         * common/version.h: Rename include guard.
1459         * common/vec.h: Rename include guard.
1460         * common/tdesc.h: Rename include guard.
1461         * common/selftest.h: Rename include guard.
1462         * common/scoped_restore.h: Rename include guard.
1463         * common/scoped_mmap.h: Rename include guard.
1464         * common/scoped_fd.h: Rename include guard.
1465         * common/safe-iterator.h: Rename include guard.
1466         * common/run-time-clock.h: Rename include guard.
1467         * common/refcounted-object.h: Rename include guard.
1468         * common/queue.h: Rename include guard.
1469         * common/ptid.h: Rename include guard.
1470         * common/print-utils.h: Rename include guard.
1471         * common/preprocessor.h: Rename include guard.
1472         * common/pathstuff.h: Rename include guard.
1473         * common/observable.h: Rename include guard.
1474         * common/netstuff.h: Rename include guard.
1475         * common/job-control.h: Rename include guard.
1476         * common/host-defs.h: Rename include guard.
1477         * common/gdb_wait.h: Rename include guard.
1478         * common/gdb_vecs.h: Rename include guard.
1479         * common/gdb_unlinker.h: Rename include guard.
1480         * common/gdb_unique_ptr.h: Rename include guard.
1481         * common/gdb_tilde_expand.h: Rename include guard.
1482         * common/gdb_sys_time.h: Rename include guard.
1483         * common/gdb_string_view.h: Rename include guard.
1484         * common/gdb_splay_tree.h: Rename include guard.
1485         * common/gdb_setjmp.h: Rename include guard.
1486         * common/gdb_ref_ptr.h: Rename include guard.
1487         * common/gdb_optional.h: Rename include guard.
1488         * common/gdb_locale.h: Rename include guard.
1489         * common/gdb_assert.h: Rename include guard.
1490         * common/filtered-iterator.h: Rename include guard.
1491         * common/filestuff.h: Rename include guard.
1492         * common/fileio.h: Rename include guard.
1493         * common/environ.h: Rename include guard.
1494         * common/common-utils.h: Rename include guard.
1495         * common/common-types.h: Rename include guard.
1496         * common/common-regcache.h: Rename include guard.
1497         * common/common-inferior.h: Rename include guard.
1498         * common/common-gdbthread.h: Rename include guard.
1499         * common/common-exceptions.h: Rename include guard.
1500         * common/common-defs.h: Rename include guard.
1501         * common/common-debug.h: Rename include guard.
1502         * common/cleanups.h: Rename include guard.
1503         * common/buffer.h: Rename include guard.
1504         * common/btrace-common.h: Rename include guard.
1505         * common/break-common.h: Rename include guard.
1506         * cli/cli-utils.h: Rename include guard.
1507         * cli/cli-style.h: Rename include guard.
1508         * cli/cli-setshow.h: Rename include guard.
1509         * cli/cli-script.h: Rename include guard.
1510         * cli/cli-interp.h: Rename include guard.
1511         * cli/cli-decode.h: Rename include guard.
1512         * cli/cli-cmds.h: Rename include guard.
1513         * charset-list.h: Add include guard.
1514         * buildsym-legacy.h: Rename include guard.
1515         * bfin-tdep.h: Add include guard.
1516         * ax.h: Rename include guard.
1517         * arm-linux-tdep.h: Add include guard.
1518         * arm-fbsd-tdep.h: Add include guard.
1519         * arch/xtensa.h: Rename include guard.
1520         * arch/tic6x.h: Add include guard.
1521         * arch/i386.h: Add include guard.
1522         * arch/arm.h: Rename include guard.
1523         * arch/arm-linux.h: Rename include guard.
1524         * arch/arm-get-next-pcs.h: Rename include guard.
1525         * arch/amd64.h: Add include guard.
1526         * arch/aarch64-insn.h: Rename include guard.
1527         * arch-utils.h: Rename include guard.
1528         * annotate.h: Add include guard.
1529         * amd64-darwin-tdep.h: Rename include guard.
1530         * aarch64-linux-tdep.h: Add include guard.
1531         * aarch64-fbsd-tdep.h: Add include guard.
1532         * aarch32-linux-nat.h: Add include guard.
1533
1534 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1535
1536         * macrotab.c (macro_define_internal): New function that
1537         factorizes macro_define_object_internal and macro_define_function
1538         code.
1539         (macro_define_object_internal): Use macro_define_internal.
1540         (macro_define_function): Likewise.
1541
1542 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1543
1544         * macrocmd.c (extract_identifier): Return
1545         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1546         callers.
1547
1548 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1549
1550         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1551
1552 2019-02-05  Tom Tromey  <tom@tromey.com>
1553
1554         * target.c (target_stack::unpush): Move assertion earlier.
1555
1556 2019-01-30  Tom Tromey  <tom@tromey.com>
1557
1558         PR python/23615:
1559         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1560         (gdbpy_parse_and_eval): Likewise.
1561         * python/python-internal.h (gdbpy_allow_threads): New class.
1562
1563 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1564
1565         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1566         (aarch64_fbsd_fpregmap): Move earlier.
1567         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1568         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1569         instead of individual calls to trad_frame_set_reg_addr.
1570         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1571         earlier.
1572         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1573         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1574         instead of individual calls to trad_frame_set_reg_addr.
1575
1576 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1577
1578         * CONTRIBUTE: Replace contribution list with wiki link.
1579
1580 2019-01-25  Tom Tromey  <tom@tromey.com>
1581
1582         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1583
1584 2019-01-25  Tom Tromey  <tom@tromey.com>
1585
1586         * xtensa-linux-nat.c: Fix common/ includes.
1587         * xml-support.h: Fix common/ includes.
1588         * xml-support.c: Fix common/ includes.
1589         * x86-linux-nat.c: Fix common/ includes.
1590         * windows-nat.c: Fix common/ includes.
1591         * varobj.h: Fix common/ includes.
1592         * varobj.c: Fix common/ includes.
1593         * value.c: Fix common/ includes.
1594         * valops.c: Fix common/ includes.
1595         * utils.c: Fix common/ includes.
1596         * unittests/xml-utils-selftests.c: Fix common/ includes.
1597         * unittests/utils-selftests.c: Fix common/ includes.
1598         * unittests/unpack-selftests.c: Fix common/ includes.
1599         * unittests/tracepoint-selftests.c: Fix common/ includes.
1600         * unittests/style-selftests.c: Fix common/ includes.
1601         * unittests/string_view-selftests.c: Fix common/ includes.
1602         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1603         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1604         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1605         * unittests/rsp-low-selftests.c: Fix common/ includes.
1606         * unittests/parse-connection-spec-selftests.c: Fix common/
1607         includes.
1608         * unittests/optional-selftests.c: Fix common/ includes.
1609         * unittests/offset-type-selftests.c: Fix common/ includes.
1610         * unittests/observable-selftests.c: Fix common/ includes.
1611         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1612         * unittests/memrange-selftests.c: Fix common/ includes.
1613         * unittests/memory-map-selftests.c: Fix common/ includes.
1614         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1615         * unittests/function-view-selftests.c: Fix common/ includes.
1616         * unittests/environ-selftests.c: Fix common/ includes.
1617         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1618         * unittests/common-utils-selftests.c: Fix common/ includes.
1619         * unittests/cli-utils-selftests.c: Fix common/ includes.
1620         * unittests/array-view-selftests.c: Fix common/ includes.
1621         * ui-file.c: Fix common/ includes.
1622         * tui/tui-io.c: Fix common/ includes.
1623         * tracepoint.h: Fix common/ includes.
1624         * tracepoint.c: Fix common/ includes.
1625         * tracefile-tfile.c: Fix common/ includes.
1626         * top.h: Fix common/ includes.
1627         * top.c: Fix common/ includes.
1628         * thread.c: Fix common/ includes.
1629         * target/waitstatus.h: Fix common/ includes.
1630         * target/waitstatus.c: Fix common/ includes.
1631         * target.h: Fix common/ includes.
1632         * target.c: Fix common/ includes.
1633         * target-memory.c: Fix common/ includes.
1634         * target-descriptions.c: Fix common/ includes.
1635         * symtab.h: Fix common/ includes.
1636         * symfile.c: Fix common/ includes.
1637         * stap-probe.c: Fix common/ includes.
1638         * spu-linux-nat.c: Fix common/ includes.
1639         * sparc-nat.c: Fix common/ includes.
1640         * source.c: Fix common/ includes.
1641         * solib.c: Fix common/ includes.
1642         * solib-target.c: Fix common/ includes.
1643         * ser-unix.c: Fix common/ includes.
1644         * ser-tcp.c: Fix common/ includes.
1645         * ser-pipe.c: Fix common/ includes.
1646         * ser-base.c: Fix common/ includes.
1647         * selftest-arch.c: Fix common/ includes.
1648         * s12z-tdep.c: Fix common/ includes.
1649         * rust-exp.y: Fix common/ includes.
1650         * rs6000-aix-tdep.c: Fix common/ includes.
1651         * riscv-tdep.c: Fix common/ includes.
1652         * remote.c: Fix common/ includes.
1653         * remote-notif.h: Fix common/ includes.
1654         * remote-fileio.h: Fix common/ includes.
1655         * remote-fileio.c: Fix common/ includes.
1656         * regcache.h: Fix common/ includes.
1657         * regcache.c: Fix common/ includes.
1658         * record-btrace.c: Fix common/ includes.
1659         * python/python.c: Fix common/ includes.
1660         * python/py-type.c: Fix common/ includes.
1661         * python/py-inferior.c: Fix common/ includes.
1662         * progspace.h: Fix common/ includes.
1663         * producer.c: Fix common/ includes.
1664         * procfs.c: Fix common/ includes.
1665         * proc-api.c: Fix common/ includes.
1666         * printcmd.c: Fix common/ includes.
1667         * ppc-linux-nat.c: Fix common/ includes.
1668         * parser-defs.h: Fix common/ includes.
1669         * osdata.c: Fix common/ includes.
1670         * obsd-nat.c: Fix common/ includes.
1671         * nat/x86-linux.c: Fix common/ includes.
1672         * nat/x86-linux-dregs.c: Fix common/ includes.
1673         * nat/x86-dregs.h: Fix common/ includes.
1674         * nat/x86-dregs.c: Fix common/ includes.
1675         * nat/ppc-linux.c: Fix common/ includes.
1676         * nat/mips-linux-watch.h: Fix common/ includes.
1677         * nat/mips-linux-watch.c: Fix common/ includes.
1678         * nat/linux-waitpid.c: Fix common/ includes.
1679         * nat/linux-ptrace.h: Fix common/ includes.
1680         * nat/linux-ptrace.c: Fix common/ includes.
1681         * nat/linux-procfs.c: Fix common/ includes.
1682         * nat/linux-personality.c: Fix common/ includes.
1683         * nat/linux-osdata.c: Fix common/ includes.
1684         * nat/linux-namespaces.c: Fix common/ includes.
1685         * nat/linux-btrace.h: Fix common/ includes.
1686         * nat/linux-btrace.c: Fix common/ includes.
1687         * nat/fork-inferior.c: Fix common/ includes.
1688         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1689         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1690         * nat/aarch64-linux.c: Fix common/ includes.
1691         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1692         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1693         * namespace.h: Fix common/ includes.
1694         * mips-linux-tdep.c: Fix common/ includes.
1695         * minsyms.c: Fix common/ includes.
1696         * mi/mi-parse.h: Fix common/ includes.
1697         * mi/mi-main.c: Fix common/ includes.
1698         * mi/mi-cmd-env.c: Fix common/ includes.
1699         * memrange.h: Fix common/ includes.
1700         * memattr.c: Fix common/ includes.
1701         * maint.h: Fix common/ includes.
1702         * maint.c: Fix common/ includes.
1703         * main.c: Fix common/ includes.
1704         * machoread.c: Fix common/ includes.
1705         * location.c: Fix common/ includes.
1706         * linux-thread-db.c: Fix common/ includes.
1707         * linux-nat.c: Fix common/ includes.
1708         * linux-fork.c: Fix common/ includes.
1709         * inline-frame.c: Fix common/ includes.
1710         * infrun.c: Fix common/ includes.
1711         * inflow.c: Fix common/ includes.
1712         * inferior.h: Fix common/ includes.
1713         * inferior.c: Fix common/ includes.
1714         * infcmd.c: Fix common/ includes.
1715         * inf-ptrace.c: Fix common/ includes.
1716         * inf-child.c: Fix common/ includes.
1717         * ia64-linux-nat.c: Fix common/ includes.
1718         * i387-tdep.c: Fix common/ includes.
1719         * i386-tdep.c: Fix common/ includes.
1720         * i386-linux-tdep.c: Fix common/ includes.
1721         * i386-linux-nat.c: Fix common/ includes.
1722         * i386-go32-tdep.c: Fix common/ includes.
1723         * i386-fbsd-tdep.c: Fix common/ includes.
1724         * i386-fbsd-nat.c: Fix common/ includes.
1725         * guile/scm-type.c: Fix common/ includes.
1726         * guile/guile.c: Fix common/ includes.
1727         * go32-nat.c: Fix common/ includes.
1728         * gnu-nat.c: Fix common/ includes.
1729         * gdbthread.h: Fix common/ includes.
1730         * gdbarch-selftests.c: Fix common/ includes.
1731         * gdb_usleep.c: Fix common/ includes.
1732         * gdb_select.h: Fix common/ includes.
1733         * gdb_bfd.c: Fix common/ includes.
1734         * gcore.c: Fix common/ includes.
1735         * fork-child.c: Fix common/ includes.
1736         * findvar.c: Fix common/ includes.
1737         * fbsd-nat.c: Fix common/ includes.
1738         * event-top.c: Fix common/ includes.
1739         * event-loop.c: Fix common/ includes.
1740         * dwarf2read.c: Fix common/ includes.
1741         * dwarf2loc.c: Fix common/ includes.
1742         * dwarf2-frame.c: Fix common/ includes.
1743         * dwarf-index-cache.c: Fix common/ includes.
1744         * dtrace-probe.c: Fix common/ includes.
1745         * disasm-selftests.c: Fix common/ includes.
1746         * defs.h: Fix common/ includes.
1747         * csky-tdep.c: Fix common/ includes.
1748         * cp-valprint.c: Fix common/ includes.
1749         * cp-support.h: Fix common/ includes.
1750         * cp-support.c: Fix common/ includes.
1751         * corelow.c: Fix common/ includes.
1752         * completer.h: Fix common/ includes.
1753         * completer.c: Fix common/ includes.
1754         * compile/compile.c: Fix common/ includes.
1755         * compile/compile-loc2c.c: Fix common/ includes.
1756         * compile/compile-cplus-types.c: Fix common/ includes.
1757         * compile/compile-cplus-symbols.c: Fix common/ includes.
1758         * command.h: Fix common/ includes.
1759         * cli/cli-dump.c: Fix common/ includes.
1760         * cli/cli-cmds.c: Fix common/ includes.
1761         * charset.c: Fix common/ includes.
1762         * build-id.c: Fix common/ includes.
1763         * btrace.h: Fix common/ includes.
1764         * btrace.c: Fix common/ includes.
1765         * breakpoint.h: Fix common/ includes.
1766         * breakpoint.c: Fix common/ includes.
1767         * ax.h:
1768         (enum agent_op): Fix common/ includes.
1769         * ax-general.c (struct aop_map): Fix common/ includes.
1770         * ax-gdb.c: Fix common/ includes.
1771         * auxv.c: Fix common/ includes.
1772         * auto-load.c: Fix common/ includes.
1773         * arm-tdep.c: Fix common/ includes.
1774         * arch/riscv.c: Fix common/ includes.
1775         * arch/ppc-linux-common.c: Fix common/ includes.
1776         * arch/i386.c: Fix common/ includes.
1777         * arch/arm.c: Fix common/ includes.
1778         * arch/arm-linux.c: Fix common/ includes.
1779         * arch/arm-get-next-pcs.c: Fix common/ includes.
1780         * arch/amd64.c: Fix common/ includes.
1781         * arch/aarch64.c: Fix common/ includes.
1782         * arch/aarch64-insn.c: Fix common/ includes.
1783         * arch-utils.c: Fix common/ includes.
1784         * amd64-windows-tdep.c: Fix common/ includes.
1785         * amd64-tdep.c: Fix common/ includes.
1786         * amd64-sol2-tdep.c: Fix common/ includes.
1787         * amd64-obsd-tdep.c: Fix common/ includes.
1788         * amd64-nbsd-tdep.c: Fix common/ includes.
1789         * amd64-linux-tdep.c: Fix common/ includes.
1790         * amd64-linux-nat.c: Fix common/ includes.
1791         * amd64-fbsd-tdep.c: Fix common/ includes.
1792         * amd64-fbsd-nat.c: Fix common/ includes.
1793         * amd64-dicos-tdep.c: Fix common/ includes.
1794         * amd64-darwin-tdep.c: Fix common/ includes.
1795         * agent.c: Fix common/ includes.
1796         * ada-lang.h: Fix common/ includes.
1797         * ada-lang.c: Fix common/ includes.
1798         * aarch64-tdep.c: Fix common/ includes.
1799
1800 2019-01-25  Tom Tromey  <tom@tromey.com>
1801
1802         * common/create-version.sh: Use common/version.h.
1803
1804 2019-01-24  Pedro Alves  <palves@redhat.com>
1805
1806         * infrun.c (signal_stop, signal_print, signal_program)
1807         (signal_catch, signal_pass): Now arrays instead of pointers.
1808         (update_signals_program_target, do_target_resume)
1809         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1810         * linux-nat.c (linux_nat_target::pass_signals)
1811         (linux_nat_target::create_inferior, linux_nat_target::attach):
1812         Adjust.
1813         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1814         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1815         * procfs.c (procfs_target::pass_signals): Adjust.
1816         * record-full.c (record_full_target::resume): Adjust.
1817         * remote.c (remote_target::pass_signals)
1818         (remote_target::program_signals): Adjust.
1819         * target-debug.h (target_debug_print_signals): Now takes a
1820         gdb::array_view as parameter.  Adjust.
1821         * target.h (target_ops) <pass_signals, program_signals>: Replace
1822         pointer and length parameters with gdb::array_view.
1823         (target_pass_signals, target_program_signals): Likewise.
1824         * target-delegates.c: Regenerate.
1825
1826 2019-01-24  Pedro Alves  <palves@redhat.com>
1827
1828         * common/forward-scope-exit.h
1829         (forward_scope_exit::forward_scope_exit): Pass arguments to
1830         m_bind_function directly, instead of creating a std::bind and
1831         copying that.
1832
1833 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1834
1835         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1836         for static members.
1837         (pass_in_v_vfp_candidate): Likewise.
1838
1839 2019-01-23  Tom Tromey  <tom@tromey.com>
1840             Pedro Alves  <palves@redhat.com>
1841
1842         * regcache.c (class regcache_invalidator): Remove.
1843         (regcache::raw_write): Use make_scope_exit.
1844
1845 2019-01-23  Tom Tromey  <tom@tromey.com>
1846
1847         * ui-out.h (class ui_out_emit_type): Update comment.
1848
1849 2019-01-23  Tom Tromey  <tom@tromey.com>
1850
1851         * infrun.c (fetch_inferior_event): Update comment.
1852
1853 2019-01-23  Tom Tromey  <tom@tromey.com>
1854             Pedro Alves  <palves@redhat.com>
1855
1856         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1857         parameter.
1858         (fetch_inferior_event): Use SCOPE_EXIT.
1859
1860
1861 2019-01-23  Tom Tromey  <tom@tromey.com>
1862             Pedro Alves  <palves@redhat.com>
1863
1864         * infrun.c (disable_thread_events): Delete.
1865         (stop_all_threads): Use SCOPE_EXIT.
1866
1867 2019-01-23  Tom Tromey  <tom@tromey.com>
1868             Pedro Alves  <palves@redhat.com>
1869
1870         * symfile.c: Include forward-scope-exit.h.
1871         (clear_symtab_users_cleanup): Replace forward declaration with
1872         a FORWARD_SCOPE_EXIT.
1873         (syms_from_objfile_1): Use the forward_scope_exit and
1874         gdb::optional instead of cleanup_function.
1875         (reread_symbols): Use the forward_scope_exit instead of
1876         cleanup_function.
1877         (clear_symtab_users_cleanup): Remove function.
1878
1879 2019-01-23  Tom Tromey  <tom@tromey.com>
1880             Pedro Alves  <palves@redhat.com>
1881
1882         * linux-nat.c: Include scope-exit.h.
1883         (cleanup_target_stop): Remove.
1884         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1885         SCOPE_EXIT.
1886
1887 2019-01-23  Tom Tromey  <tom@tromey.com>
1888             Pedro Alves  <palves@redhat.com>
1889
1890         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1891         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1892
1893 2019-01-23  Tom Tromey  <tom@tromey.com>
1894             Andrew Burgess  <andrew.burgess@embecosm.com>
1895             Pedro Alves  <palves@redhat.com>
1896
1897         * infrun.c (fetch_inferior_event): Use scope_exit.
1898         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1899         * top.c (execute_command): Use scope_exit.
1900         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1901         * utils.c (do_bpstat_clear_actions_cleanup)
1902         (make_bpstat_clear_actions_cleanup): Remove.
1903
1904 2019-01-23  Tom Tromey  <tom@tromey.com>
1905             Pedro Alves  <palves@redhat.com>
1906
1907         * infrun.c: Include "common/scope-exit.h"
1908         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1909         (wait_for_inferior): Use SCOPE_EXIT.
1910         (fetch_inferior_event): Use scope_exit.
1911
1912 2019-01-23  Tom Tromey  <tom@tromey.com>
1913             Pedro Alves  <palves@redhat.com>
1914
1915         * breakpoint.c (create_breakpoint): Remove cleanup.
1916
1917 2019-01-23  Tom Tromey  <tom@tromey.com>
1918             Andrew Burgess  <andrew.burgess@embecosm.com>
1919             Pedro Alves  <palves@redhat.com>
1920
1921 2019-01-23  Pedro Alves  <palves@redhat.com>
1922
1923         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1924
1925 2019-01-23  Pedro Alves  <palves@redhat.com>
1926             Andrew Burgess  <andrew.burgess@embecosm.com>
1927
1928         * gdbthread.h: Include "common/forward-scope-exit.h".
1929         (scoped_finish_thread_state): Redefine custom class in terms of
1930         forward_scope_exit.
1931
1932 2019-01-23  Pedro Alves  <palves@redhat.com>
1933             Andrew Burgess  <andrew.burgess@embecosm.com>
1934
1935         * common/forward-scope-exit.h: New file.
1936
1937 2019-01-23  Pedro Alves  <palves@redhat.com>
1938             Andrew Burgess  <andrew.burgess@embecosm.com>
1939             Tom Tromey  <tom@tromey.com>
1940
1941         * common/scope-exit.h: New file.
1942
1943 2019-01-23  Pedro Alves  <palves@redhat.com>
1944
1945         * common/preprocessor.h (ESC): Rename to ...
1946         (ESC_PARENS): ... this.
1947         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1948         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1949
1950 2019-01-23  Tom Tromey  <tom@tromey.com>
1951
1952         * language.h (class scoped_switch_to_sym_language_if_auto):
1953         Initialize m_lang in both cases.
1954
1955 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1956
1957         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1958         with XCNEW.
1959
1960 2019-01-22  Tom Tromey  <tom@tromey.com>
1961
1962         * corelow.c: Do not include sys/file.h.
1963
1964 2019-01-22  Tom Tromey  <tom@tromey.com>
1965
1966         * tui/tui-wingeneral.h: Include gdb_curses.h.
1967
1968 2019-01-22  Tom Tromey  <tom@tromey.com>
1969
1970         * source-cache.h (class source_cache) <get_source_lines,
1971         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1972
1973 2019-01-22  Tom Tromey  <tom@tromey.com>
1974
1975         * remote-fileio.h (struct remote_target): Declare.
1976
1977 2019-01-22  Tom Tromey  <tom@tromey.com>
1978
1979         * python/py-arch.c: Do not include py-ref.h.
1980         * python/py-bpevent.c: Do not include py-ref.h.
1981         * python/py-cmd.c: Do not include py-ref.h.
1982         * python/py-continueevent.c: Do not include py-ref.h.
1983         * python/py-event.h: Do not include py-ref.h.
1984         * python/py-evtregistry.c: Do not include py-ref.h.
1985         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1986         * python/py-frame.c: Do not include py-ref.h.
1987         * python/py-framefilter.c: Do not include py-ref.h.
1988         * python/py-function.c: Do not include py-ref.h.
1989         * python/py-infevents.c: Do not include py-ref.h.
1990         * python/py-linetable.c: Do not include py-ref.h.
1991         * python/py-objfile.c: Do not include py-ref.h.
1992         * python/py-param.c: Do not include py-ref.h.
1993         * python/py-prettyprint.c: Do not include py-ref.h.
1994         * python/py-progspace.c: Do not include py-ref.h.
1995         * python/py-symbol.c: Do not include py-ref.h.
1996         * python/py-symtab.c: Do not include py-ref.h.
1997         * python/py-type.c: Do not include py-ref.h.
1998         * python/py-unwind.c: Do not include py-ref.h.
1999         * python/py-utils.c: Do not include py-ref.h.
2000         * python/py-value.c: Do not include py-ref.h.
2001         * python/py-varobj.c: Do not include py-ref.h.
2002         * python/py-xmethods.c: Do not include py-ref.h.
2003         * python/python.c: Do not include py-ref.h.
2004         * varobj.c: Do not include py-ref.h.
2005
2006 2019-01-22  Tom Tromey  <tom@tromey.com>
2007
2008         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2009         keyword for bcache.
2010
2011 2019-01-22  Tom Tromey  <tom@tromey.com>
2012
2013         * compile/compile-cplus-types.c: Remove a comment by #include.
2014
2015 2019-01-22  Tom Tromey  <tom@tromey.com>
2016
2017         * compile/gcc-c-plugin.h: Include compile-internal.h.
2018
2019 2019-01-22  Tom Tromey  <tom@tromey.com>
2020
2021         * stabsread.c (EXTERN): Do not define.
2022         (symnum, next_symbol_text_func, processing_gcc_compilation)
2023         (within_function, global_sym_chain, global_stabs)
2024         (previous_stab_code, this_object_header_files)
2025         (n_this_object_header_files)
2026         (n_allocated_this_object_header_files): Define.
2027         * stabsread.h (EXTERN): Never define.  Use "extern".
2028
2029 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2030
2031         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2032         history_value.
2033
2034 2019-01-21  Tom Tromey  <tom@tromey.com>
2035
2036         * ui-out.c: Fix includes.
2037         * tui/tui-source.c: Fix includes.
2038         * target.c: Fix includes.
2039         * remote.c: Fix includes.
2040         * regcache.c: Fix includes.
2041         * python/py-block.c: Fix includes.
2042         * printcmd.c: Fix includes.
2043         * or1k-tdep.c: Fix includes.
2044         * mi/mi-main.c: Fix includes.
2045         * m32r-tdep.c: Fix includes.
2046         * csky-tdep.c: Fix includes.
2047         * compile/compile-cplus-types.c: Fix includes.
2048         * cli/cli-interp.c: Fix includes.
2049
2050 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2051
2052         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2053         for padding.
2054
2055 2019-01-16  Tom Tromey  <tom@tromey.com>
2056
2057         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2058         earlier.
2059         (struct objfile) <msymbols_range>: Move from top level.
2060         <msymbols>: New method.
2061         (class objfile_msymbols): Remove.
2062         * symtab.c (default_collect_symbol_completion_matches_break_on):
2063         Update.
2064         * symmisc.c (dump_msymbols): Update.
2065         * stabsread.c (scan_file_globals): Update.
2066         * objc-lang.c (info_selectors_command, info_classes_command)
2067         (find_methods): Update.
2068         * minsyms.c (find_solib_trampoline_target): Update.
2069         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2070         * coffread.c (coff_symfile_read): Update.
2071         * ada-lang.c (ada_lookup_simple_minsym)
2072         (ada_collect_symbol_completion_matches): Update.
2073
2074 2019-01-16  Tom Tromey  <tom@tromey.com>
2075
2076         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2077         type.  Remove no-argument constructor.
2078         <iterator::operator++>: Simplify.
2079         <begin>: Update.
2080         <end>: Use minimal_symbol_count.
2081
2082 2019-01-16  Tom Tromey  <tom@tromey.com>
2083
2084         * objfiles.h (struct objfile) <psymtabs>: New method.
2085         (class objfile_psymtabs): Remove.
2086         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2087         typedef.
2088         <range>: New method.
2089         (require_partial_symbols): Change return type.
2090         * psymtab.c (require_partial_symbols)
2091         (psym_expand_symtabs_matching): Update.
2092         * mdebugread.c (parse_partial_symbols): Update.
2093         * dbxread.c (dbx_end_psymtab): Update.
2094
2095 2019-01-15  Tom Tromey  <tom@tromey.com>
2096
2097         * symtab.c (lookup_objfile_from_block)
2098         (lookup_symbol_in_objfile_symtabs)
2099         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2100         (find_line_symtab, info_sources_command)
2101         (default_collect_symbol_completion_matches_break_on)
2102         (make_source_files_completion_list): Update.
2103         * symmisc.c (print_objfile_statistics, dump_objfile)
2104         (maintenance_print_symbols, maintenance_info_symtabs)
2105         (maintenance_check_symtabs, maintenance_info_line_tables):
2106         Update.
2107         * source.c (select_source_symtab)
2108         (forget_cached_source_info_for_objfile): Update.
2109         * objfiles.h (class objfile_compunits): Remove.
2110         (struct objfile) <compunits_range>: New typedef.
2111         (compunits): New method.
2112         * objfiles.c (objfile_relocate1): Update.
2113         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2114         * maint.c (count_symtabs_and_blocks): Update.
2115         * linespec.c (iterate_over_all_matching_symtabs): Update.
2116         * cp-support.c (add_symbol_overload_list_qualified): Update.
2117         * coffread.c (coff_symtab_read): Update.
2118         * ada-lang.c (add_nonlocal_symbols)
2119         (ada_collect_symbol_completion_matches)
2120         (ada_add_global_exceptions): Update.
2121
2122 2019-01-15  Tom Tromey  <tom@tromey.com>
2123
2124         * progspace.h (program_space) <objfiles_safe_range>: New
2125         typedef.
2126         <objfiles_safe>: New method.
2127         * objfiles.h (class all_objfiles_safe): Remove.
2128         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2129         * jit.c (jit_inferior_exit_hook): Update.
2130
2131 2019-01-17  Tom Tromey  <tom@tromey.com>
2132
2133         * progspace.h (program_space) <objfiles_range>: New typedef.
2134         <objfiles>: New method.
2135         <objfiles_head>: Rename from objfiles.
2136         (object_files): Update.
2137         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2138         * guile/scm-pretty-print.c
2139         (ppscm_find_pretty_printer_from_objfiles): Update.
2140         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2141         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2142         Update.
2143         * python/py-progspace.c (pspy_get_objfiles): Update.
2144         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2145         Update.
2146         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2147         (objfpy_lookup_objfile_by_build_id): Update.
2148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2149         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2150         Update.
2151         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2152         (expand_symtab_containing_pc, lookup_objfile_from_block)
2153         (lookup_static_symbol, basic_lookup_transparent_type)
2154         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2155         (find_line_symtab, info_sources_command)
2156         (default_collect_symbol_completion_matches_break_on)
2157         (make_source_files_completion_list, find_main_name): Update.
2158         * symmisc.c (print_symbol_bcache_statistics)
2159         (print_objfile_statistics, maintenance_print_symbols)
2160         (maintenance_print_msymbols, maintenance_print_objfiles)
2161         (maintenance_info_symtabs, maintenance_check_symtabs)
2162         (maintenance_expand_symtabs, maintenance_info_line_tables):
2163         Update.
2164         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2165         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2166         (map_overlay_command, unmap_overlay_command)
2167         (simple_overlay_update, expand_symtabs_matching)
2168         (map_symbol_filenames): Update.
2169         * symfile-debug.c (set_debug_symfile): Update.
2170         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2171         Update.
2172         * source.c (select_source_symtab, forget_cached_source_info):
2173         Update.
2174         * solib.c (solib_read_symbols): Update.
2175         * solib-spu.c (append_ocl_sos): Update.
2176         * psymtab.c (maintenance_print_psymbols)
2177         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2178         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2179         * printcmd.c (info_symbol_command): Update.
2180         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2181         Update.
2182         * objfiles.h (class all_objfiles): Remove.
2183         * objfiles.c (have_partial_symbols, have_full_symbols)
2184         (have_minimal_symbols, qsort_cmp, update_section_map)
2185         (shared_objfile_contains_address_p)
2186         (default_iterate_over_objfiles_in_search_order): Update.
2187         * objc-lang.c (info_selectors_command, info_classes_command)
2188         (find_methods): Update.
2189         * minsyms.c (find_solib_trampoline_target): Update.
2190         * maint.c (maintenance_info_sections)
2191         (maintenance_translate_address, count_symtabs_and_blocks):
2192         Update.
2193         * main.c (captured_main_1): Update.
2194         * linux-thread-db.c (try_thread_db_load_from_pdir)
2195         (has_libpthread): Update.
2196         * linespec.c (iterate_over_all_matching_symtabs)
2197         (search_minsyms_for_name): Update.
2198         * jit.c (jit_find_objf_with_entry_addr): Update.
2199         * hppa-tdep.c (find_unwind_entry)
2200         (hppa_lookup_stub_minimal_symbol): Update.
2201         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2202         Update.
2203         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2204         (elf_gnu_ifunc_resolve_by_got): Update.
2205         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2206         * dwarf-index-write.c (save_gdb_index_command): Update.
2207         * cp-support.c (add_symbol_overload_list_qualified): Update.
2208         * breakpoint.c (create_overlay_event_breakpoint)
2209         (create_longjmp_master_breakpoint)
2210         (create_std_terminate_master_breakpoint)
2211         (create_exception_master_breakpoint): Update.
2212         * blockframe.c (find_pc_partial_function): Update.
2213         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2214         (ada_collect_symbol_completion_matches)
2215         (ada_add_global_exceptions): Update.
2216
2217 2019-01-17  Tom Tromey  <tom@tromey.com>
2218
2219         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2220         declare VEC.
2221         (solib_target_parse_libraries): Change return type.
2222         (library_list_start_segment, library_list_start_section)
2223         (library_list_end_library, library_list_start_library); Update.
2224         (solib_target_free_library_list): Remove.
2225         (solib_target_parse_libraries): Remove cleanup.  Change return
2226         type.
2227         (solib_target_current_sos): Update.
2228
2229 2019-01-17  Tom Tromey  <tromey@bapiya>
2230
2231         * valprint.c: Replace "the the" with "the".
2232         * symtab.c: Replace "the the" with "the".
2233         * solib.c: Replace "the the" with "the".
2234         * solib-dsbt.c: Replace "the the" with "the".
2235         * linespec.c: Replace "the the" with "the".
2236         * dwarf2loc.h: Replace "the the" with "the".
2237         * amd64-windows-tdep.c: Replace "the the" with "the".
2238         * aarch64-tdep.c: Replace "the the" with "the".
2239
2240 2019-01-16  Keith Seitz  <keiths@redhat.com>
2241
2242         PR gdb/23773
2243         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2244         <builder>: Rename to ..
2245         <m_builder>: ... this and make private.
2246         (dwarf2_cu::get_builder): New method.  Change all users of
2247         `builder' to use this method.
2248         (dwarf2_start_symtab): Move to ...
2249         (dwarf2_cu::start_symtab): ... here.  Update all callers
2250         (setup_type_unit_groups): Move to ...
2251         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2252         callers.
2253         (dwarf2_cu::reset_builder): New method.
2254         (process_full_compunit, process_full_type_unit): Use
2255         dwarf2_cu::reset_builder.
2256         (follow_die_offset): Record the ancestor CU if it is different
2257         from the followed DIE's CU.
2258         (follow_die_sig_1): Likewise.
2259
2260 2019-01-15  Tom Tromey  <tom@tromey.com>
2261
2262         * remote.c (class remote_state) <buf>: Now a char_vector.
2263         <buf_size>: Remove.
2264         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2265         parameter.
2266         (remote_target::getpkt_or_notif_sane_1)
2267         (remote_target::getpkt_sane)
2268         (remote_target::getpkt_or_notif_sane): Likewise.
2269         (class remote_target) <putpkt>: New overload.
2270         (remote_target::read_frame): Change type of "buf_p".  Remove
2271         sizeof_p parameter.
2272         (packet_ok): New overload.
2273         (packet_check_result): New overload.
2274         Update all uses.
2275
2276 2019-01-14  Tom Tromey  <tom@tromey.com>
2277
2278         * remote-notif.c (handle_notification, remote_notif_ack)
2279         (remote_notif_parse): Make "buf" const.
2280         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2281         const.
2282         (remote_notif_parse, remote_notif_ack, handle_notification):
2283         Likewise.
2284         * remote.c (remote_notif_stop_parse): Make "buf" const.
2285         (remote_target::remote_parse_stop_reply): Make "buf" const.
2286         (remote_notif_stop_ack): Make "buf" const.
2287
2288 2019-01-14  Tom Tromey  <tom@tromey.com>
2289
2290         * remote.c (remote_console_output): Make parameter const.
2291
2292 2019-01-14  Tom Tromey  <tom@tromey.com>
2293
2294         * target-debug.h (target_debug_print_signals): Constify.
2295         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2296         * procfs.c (procfs_target::pass_signals): Update.
2297         * linux-nat.c (linux_nat_target::pass_signals): Update.
2298         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2299         * target-delegates.c: Rebuild.
2300         * remote.c (remote_target::program_signals): Update.
2301         (remote_target::pass_signals): Update.
2302         * target.c (target_pass_signals): Constify argument.
2303         (target_program_signals): Likewise.
2304         * target.h (struct target_ops) <pass_signals, program_signals>:
2305         Constify argument.
2306         (target_pass_signals, target_program_signals): Constify argument.
2307
2308 2019-01-14  Tom Tromey  <tom@tromey.com>
2309
2310         PR tui/28819:
2311         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2312
2313 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2314
2315         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2316         field.
2317         * rs6000-tdep.c: Include reggroups.h.
2318         (IS_V_ALIAS_PSEUDOREG): Define.
2319         (rs6000_register_name): Return names for the "vX" aliases.
2320         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2321         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2322         aliases.  Call default_register_reggroup_p for all other
2323         pseudo-registers.
2324         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2325         New functions.
2326         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2327         Handle "vX" aliases.
2328         (v_alias_pseudo_register_collect): New function.
2329         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2330         (rs6000_gdbarch_init): Initialize "vX" aliases as
2331         pseudo-registers.  Restore registration of
2332         rs6000_pseudo_register_reggroup_p with
2333         set_tdesc_pseudo_register_reggroup_p.
2334
2335 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2336
2337         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2338         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2339         set_gdbarch_num_pseudo_regs.
2340
2341 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2342
2343         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2344         Remove arg prefixname, add do_set and do_show.
2345         Add member functions set_list and show_list.
2346         * cli/cli-style.c (class cli_style_option): Update accordingly.
2347         (style_set_list): Move to file scope.
2348         (style_show_list): Likewise.
2349         (set_style): Call help_list.
2350         (show_style): Call cmd_show_list.
2351         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2352         Update to use the new macro.
2353
2354 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2355
2356         * ada-lang.c (_initialize_ada_language): Expand the help text
2357         for the "catch exception" command.
2358
2359 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2360
2361         * symtab.c (matching_obj_sections): Initialize obj,
2362         declare it closer to its usage.
2363
2364 2019-01-10  Tom Tromey  <tom@tromey.com>
2365
2366         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2367         (basic_inf_threads_range): Remove.
2368         (inf_threads_range, inf_non_exited_threads_range)
2369         (safe_inf_threads_range): Use next_adapter.
2370
2371 2019-01-10  Keith Seitz  <keiths@redhat.com>
2372
2373         PR gdb/23712
2374         PR symtab/23010
2375         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2376         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2377
2378 2019-01-10  Keith Seitz  <keiths@redhat.com>
2379
2380         PR gdb/23712
2381         PR symtab/23010
2382         * dictionary.c (pending_to_vector): Remove.
2383         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2384         Remove _1 suffix, replacing functions of the same name.  Update
2385         all callers.
2386         (dict_create_hashed, dict_create_hashed_expandable)
2387         (dict_create_linear, dict_create_linear_expandable, dict_free)
2388         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2389         Make functions static.
2390
2391 2019-01-10  Keith Seitz  <keiths@redhat.com>
2392
2393         PR gdb/23712
2394         PR symtab/23010
2395         * dictionary.h (struct dictionary): Replace declaration with
2396         multidictionary.
2397         (dict_create_hashed, dict_create_hashed_expandable)
2398         (dict_create_linear, dict_create_linear_expandable)
2399         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2400         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2401         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2402         taking multidictionary argument.
2403         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2404         * block.h (struct block) <dict>: Change to multidictionary
2405         and rename `multidict'.
2406         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2407         symmisc.c: Update all dictionary references to multidictionary.
2408
2409 2019-01-10  Keith Seitz  <keiths@redhat.com>
2410
2411         PR gdb/23712
2412         PR symtab/23010
2413         * dictionary.c: Include unordered_map.
2414         (pending_to_vector): New function.
2415         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2416         Rewrite the non-"_1" functions to take vector instead
2417         of linked list.
2418         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2419         "new" _1 versions of the same name.
2420         (multidictionary): Define.
2421         (std::hash<enum language): New definition.
2422         (collate_pending_symbols_by_language, mdict_create_hashed)
2423         (mdict_create_hashed_expandable, mdict_create_linear)
2424         (mdict_create_linear_expandable, mdict_free)
2425         (find_language_dictionary, create_new_language_dictionary)
2426         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2427         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2428         (mdict_size, mdict_empty): New functions.
2429         * dictionary.h (mdict_iterator): Define.
2430
2431 2019-01-10  Pedro Alves  <palves@redhat.com>
2432
2433         * breakpoint.c (read_uploaded_action)
2434         (create_tracepoint_from_upload): Adjust to use
2435         gdb::unique_xmalloc_ptr.
2436         * ctf.c (ctf_write_uploaded_tp):
2437         (SET_ARRAY_FIELD): Use emplace_back.
2438         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2439         * tracefile-tfile.c (tfile_write_uploaded_tp):
2440         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2441         gdb::unique_xmalloc_ptr.
2442         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2443         at_string, cond_string, cmd_strings>: Replace char pointers
2444         with gdb::unique_xmalloc_ptr.
2445
2446 2019-01-10  Pedro Alves  <palves@redhat.com>
2447
2448         * solib-target.c (library_list_start_library): Don't xstrdup name.
2449
2450 2019-01-10  Pedro Alves  <palves@redhat.com>
2451
2452         * mdebugread.c (parse_partial_symbols): Use
2453         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2454
2455 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2456
2457         * linux-fork.c (scoped_switch_fork_info)
2458         <~scoped_switch_fork_info>: Fix incorrect variable name.
2459
2460 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2461
2462         * linux-fork.c (scoped_switch_fork_info)
2463         <scoped_switch_fork_info>: Make explicit.
2464         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2465
2466 2019-01-10  Tom Tromey  <tom@tromey.com>
2467
2468         * objfiles.h (objfile::reset_psymtabs): Update.
2469         * objfiles.c (objfile::objfile): Update.
2470         * psymtab.h (psymtab_storage::obstack): Update.
2471         (psymtab_storage::m_obstack): Use gdb::optional.
2472         (class psymtab_storage): Update comment.  Remove objfile
2473         parameter.
2474         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2475
2476 2019-01-10  Tom Tromey  <tom@tromey.com>
2477
2478         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2479         <free_psymtabs>: Now private.
2480         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2481         (allocate_psymtab): Use new method.
2482
2483 2019-01-10  Tom Tromey  <tom@tromey.com>
2484
2485         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2486         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2487         * mdebugread.c (parse_partial_symbols): Use
2488         allocate_dependencies.
2489         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2490         allocate_dependencies.
2491         (process_psymtab_comp_unit_reader)
2492         (build_type_psymtab_dependencies): Likewise.
2493         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2494
2495 2019-01-10  Tom Tromey  <tom@tromey.com>
2496
2497         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2498         PSYMBOL_SET_LANGUAGE.
2499         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2500
2501 2019-01-10  Tom Tromey  <tom@tromey.com>
2502
2503         * psymtab.h (psymtab_storage::obstack): New method.
2504         <m_obstack>: Rename from obstack; now private.
2505         * psymtab.c (psymtab_storage): Update.
2506         * dwarf2read.c (create_addrmap_from_index)
2507         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2508         Update.
2509
2510 2019-01-10  Tom Tromey  <tom@tromey.com>
2511
2512         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2513         * objfiles.h (objfile::reset_psymtabs): New method.
2514
2515 2019-01-10  Tom Tromey  <tom@tromey.com>
2516
2517         * symmisc.c (print_symbol_bcache_statistics): Update.
2518         (print_objfile_statistics): Update.
2519         * symfile.c (reread_symbols): Update.
2520         * psymtab.h (class psymtab_storage): New.
2521         * psymtab.c (psymtab_storage): New constructor.
2522         (~psymtab_storage): New destructor.
2523         (require_partial_symbols): Update.
2524         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2525         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2526         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2527         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2528         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2529         (start_psymtab_common, end_psymtab_common)
2530         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2531         (allocate_psymtab): Update.
2532         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2533         Update.
2534         (dump_psymtab_addrmap, maintenance_print_psymbols)
2535         (maintenance_check_psymtabs): Update.
2536         (class objfile_psymtabs): Move to objfiles.h.
2537         * psympriv.h (discard_psymtab): Now inline.
2538         (psymtab_discarder::psymtab_discarder): Update.
2539         (psymtab_discarder::~psymtab_discarder): Update.
2540         (ALL_OBJFILE_PSYMTABS): Rewrite.
2541         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2542         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2543         Remove fields.
2544         <partial_symtabs>: New field.
2545         (class objfile_psymtabs): Move from psymtab.h.  Update.
2546         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2547         psymbol_cache.
2548         (objfile::~objfile): Don't destroy psymbol_cache.
2549         * mdebugread.c (parse_partial_symbols): Update.
2550         * dwarf2read.c (create_addrmap_from_index)
2551         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2552         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2553         (add_partial_subprogram, dwarf2_ranges_read): Update.
2554         * dwarf-index-write.c (write_address_map)
2555         (write_one_signatured_type, recursively_write_psymbols)
2556         (class debug_names, class debug_names, write_psymtabs_to_index):
2557         Update.
2558
2559 2019-01-10  Tom Tromey  <tom@tromey.com>
2560
2561         * symtab.h (SYMBOL_SET_NAMES): Update.
2562         (symbol_set_names): Update.
2563         (MSYMBOL_SET_NAMES): Update.
2564         * symtab.c (symbol_set_names): Change argument to be an
2565         objfile_per_bfd_storage.
2566         * psymtab.c (add_psymbol_to_bcache): Update.
2567         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2568
2569 2019-01-10  Tom Tromey  <tom@tromey.com>
2570
2571         * symtab.c (create_demangled_names_hash): Change argument to be an
2572         objfile_per_bfd_storage.
2573         (symbol_set_names): Update.
2574
2575 2019-01-10  Tom Tromey  <tom@tromey.com>
2576
2577         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2578         init_psymbol_list.
2579         * psymtab.c (init_psymbol_list): Do nothing if already called.
2580         * psympriv.h (init_psymbol_list): Add comment.
2581         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2582         init_psymbol_list.
2583         * dbxread.c (dbx_symfile_read): Unconditionally call
2584         init_psymbol_list.
2585
2586 2019-01-10  Tom Tromey  <tom@tromey.com>
2587
2588         * xcoffread.c (scan_xcoff_symtab): Update.
2589         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2590         "where".
2591         * mdebugread.c (parse_partial_symbols)
2592         (handle_psymbol_enumerators): Update.
2593         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2594         * dbxread.c (read_dbx_symtab): Update.
2595         * psympriv.h (psymbol_placement): New enum.
2596         (add_psymbol_to_list): Update.
2597
2598 2019-01-10  Tom Tromey  <tom@tromey.com>
2599
2600         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2601         static_psymbols parameters.
2602         (scan_xcoff_symtab): Update.
2603         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2604         static_psymbols parameters.
2605         * psympriv.h (start_psymtab_common): Update.
2606         * mdebugread.c (parse_partial_symbols): Update.
2607         * dwarf2read.c (create_partial_symtab): Update.
2608         * dbxread.c (read_dbx_symtab): Update.
2609         (start_psymtab): Remove global_psymbols and static_psymbols
2610         parameters.
2611
2612 2019-01-10  Tom Tromey  <tom@tromey.com>
2613
2614         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2615         * psymtab.c (allocate_psymtab): Add comment.
2616         * psympriv.h (allocate_psymtab): Add comment.
2617         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2618         initializations.
2619         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2620
2621 2019-01-10  Tom Tromey  <tom@tromey.com>
2622
2623         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2624         Don't declare.
2625         * mipsread.c: Include mdebugread.h.
2626         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2627         Declare.
2628         * elfread.c: Include mdebugread.h.
2629
2630 2019-01-09  Tom Tromey  <tom@tromey.com>
2631
2632         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2633         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2634         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2635         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2636         (psym_lookup_symbol, psym_find_last_source_symtab)
2637         (psym_forget_cached_source_info, psym_print_stats)
2638         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2639         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2640         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2641         (psym_find_compunit_symtab_by_address)
2642         (maintenance_print_psymbols, maintenance_info_psymtabs)
2643         (maintenance_check_psymtabs): Use ranged for.
2644         * psymtab.h (class objfile_psymtabs): New.
2645         (require_partial_symbols): Return objfile_psymtabs.
2646         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2647
2648 2019-01-09  Tom Tromey  <tom@tromey.com>
2649
2650         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2651         (find_pc_mapped_section, list_overlays_command)
2652         (map_overlay_command, unmap_overlay_command)
2653         (simple_overlay_update): Use all_objfiles.
2654         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2655         * printcmd.c (info_symbol_command): Use all_objfiles.
2656         * objfiles.h (ALL_OBJSECTIONS): Remove.
2657         * maint.c (maintenance_translate_address): Use all_objfiles.
2658         * gcore.c (gcore_create_callback): Use all_objfiles.
2659         (objfile_find_memory_regions): Likewise.
2660
2661 2019-01-09  Tom Tromey  <tom@tromey.com>
2662
2663         * symtab.c (find_line_symtab, info_sources_command)
2664         (make_source_files_completion_list): Use objfile_compunits.
2665         * source.c (select_source_symtab): Use objfile_compunits.
2666         * objfiles.h (struct objfile): Update comment.
2667         (ALL_OBJFILES): Remove.
2668         (ALL_FILETABS): Remove.
2669         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2670         objfile_compunits.
2671
2672 2019-01-09  Tom Tromey  <tom@tromey.com>
2673
2674         * symmisc.c (print_objfile_statistics, dump_objfile)
2675         (maintenance_print_symbols): Use compunit_filetabs.
2676         * source.c (forget_cached_source_info_for_objfile): Use
2677         compunit_filetabs.
2678         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2679         (ALL_FILETABS): Use compunit_filetabs.
2680         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2681         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2682
2683 2019-01-09  Tom Tromey  <tom@tromey.com>
2684
2685         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2686         (compunit_filetabs): New.
2687         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2688         compunit_filetabs.
2689         (info_sources_command, make_source_files_completion_list): Remove
2690         declaration.
2691         * symmisc.c (print_objfile_statistics, dump_objfile)
2692         (maintenance_print_symbols): Remove declaration.
2693         (maintenance_info_symtabs): Use compunit_filetabs.
2694         (maintenance_info_line_tables): Likewise.
2695         * source.c (select_source_symtab): Change local variable name.
2696         (forget_cached_source_info_for_objfile): Remove declaration.
2697         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2698         * objfiles.c (objfile_relocate1): Remove declaration.
2699         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2700         declaration.
2701         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2702         * coffread.c (coff_symtab_read): Remove declaration.
2703         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2704         compunit_filetabs.
2705
2706 2019-01-09  Tom Tromey  <tom@tromey.com>
2707
2708         * symtab.c (lookup_objfile_from_block)
2709         (find_pc_sect_compunit_symtab, search_symbols)
2710         (default_collect_symbol_completion_matches_break_on): Use
2711         objfile_compunits.
2712         * objfiles.h (ALL_COMPUNITS): Remove.
2713         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2714         * cp-support.c (add_symbol_overload_list_qualified): Use
2715         objfile_compunits.
2716         * ada-lang.c (ada_collect_symbol_completion_matches)
2717         (ada_add_global_exceptions): Use objfile_compunits.
2718
2719 2019-01-09  Tom Tromey  <tom@tromey.com>
2720
2721         * source.c (select_source_symtab)
2722         (forget_cached_source_info_for_objfile): Remove declaration.
2723         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2724         declaration.
2725         * maint.c (count_symtabs_and_blocks): Remove declaration.
2726         * cp-support.c (add_symbol_overload_list_qualified): Remove
2727         declaration.
2728         * coffread.c (coff_symtab_read): Remove declaration.
2729         * symtab.c (lookup_symbol_in_objfile_symtabs)
2730         (basic_lookup_transparent_type_1): Use objfile_compunits.
2731         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2732         (info_sources_command, search_symbols)
2733         (default_collect_symbol_completion_matches_break_on)
2734         (make_source_files_completion_list): Remove declaration.
2735         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2736         (ada_collect_symbol_completion_matches)
2737         (ada_add_global_exceptions): Remove declaration.
2738         * linespec.c (iterate_over_all_matching_symtabs): Use
2739         objfile_compunits.
2740         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2741         (class objfile_compunits): New.
2742         (ALL_COMPUNITS): Use objfile_compunits.
2743         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2744         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2745         objfile_compunits.
2746         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2747
2748 2019-01-09  Tom Tromey  <tom@tromey.com>
2749
2750         * symtab.c (search_symbols)
2751         (default_collect_symbol_completion_matches_break_on): Use
2752         objfile_msymbols.
2753         * ada-lang.c (ada_lookup_simple_minsym)
2754         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2755         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2756         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2757         objfile_msymbols.
2758         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2759         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2760         * objc-lang.c (find_methods): Use objfile_msymbols.
2761         (info_selectors_command, info_classes_command): Likewise.
2762         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2763         * objfiles.h (class objfile_msymbols): New.
2764         (ALL_OBJFILE_MSYMBOLS): Remove.
2765         (ALL_MSYMBOLS): Remove.
2766
2767 2019-01-09  Tom Tromey  <tom@tromey.com>
2768
2769         * common/next-iterator.h (next_adapter): Add Iterator template
2770         parameter.
2771         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2772         (class all_objfiles_safe): New.
2773         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2774         * objfiles.c (put_objfile_before): Update comment.
2775         (add_separate_debug_objfile): Likewise.
2776         (free_all_objfiles): Use all_objfiles_safe.
2777         (objfile_purge_solibs): Likewise.
2778
2779 2019-01-09  Tom Tromey  <tom@tromey.com>
2780
2781         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2782         (expand_symtab_containing_pc, lookup_static_symbol)
2783         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2784         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2785         all_objfiles.
2786         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2787         * breakpoint.c (create_overlay_event_breakpoint)
2788         (create_longjmp_master_breakpoint)
2789         (create_std_terminate_master_breakpoint)
2790         (create_exception_master_breakpoint): Use all_objfiles.
2791         * linux-thread-db.c (try_thread_db_load_from_pdir)
2792         (has_libpthread): Use all_objfiles.
2793         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2794         * linespec.c (iterate_over_all_matching_symtabs)
2795         (search_minsyms_for_name): Use all_objfiles.
2796         * maint.c (maintenance_info_sections): Use all_objfiles.
2797         * main.c (captured_main_1): Use all_objfiles.
2798         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2799         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2800         * guile/scm-pretty-print.c
2801         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2802         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2803         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2804         (maintenance_print_msymbols): Use all_objfiles.
2805         * source.c (select_source_symtab): Use all_objfiles.
2806         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2807         * symfile.c (remove_symbol_file_command)
2808         (expand_symtabs_matching, map_symbol_filenames): Use
2809         all_objfiles.
2810         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2811         all_objfiles.
2812         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2813         * objc-lang.c (find_methods): Use all_objfiles.
2814         * objfiles.c (have_partial_symbols, have_full_symbols)
2815         (have_minimal_symbols, qsort_cmp)
2816         (default_iterate_over_objfiles_in_search_order): Use
2817         all_objfiles.
2818         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2819         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2820         (maintenance_check_psymtabs): Use all_objfiles.
2821         (ALL_PSYMTABS): Remove.
2822         * compile/compile-object-run.c (do_module_cleanup): Use
2823         all_objfiles.
2824         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2825         * cp-support.c (add_symbol_overload_list_qualified): Use
2826         all_objfiles.
2827         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2828         Use all_objfiles.
2829         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2830         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2831         all_objfiles.
2832         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2833         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2834         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2835         Uses all_objfiles.
2836         * solib.c (solib_read_symbols): Use all_objfiles
2837
2838 2019-01-09  Tom Tromey  <tom@tromey.com>
2839
2840         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2841         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2842         all_objfiles.
2843         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2844         * symmisc.c (print_symbol_bcache_statistics)
2845         (print_objfile_statistics, maintenance_print_objfiles)
2846         (maintenance_info_symtabs, maintenance_check_symtabs)
2847         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2848         all_objfiles.
2849         * source.c (forget_cached_source_info): Use all_objfiles.
2850         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2851         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2852         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2853         * objfiles.c (update_section_map): Use all_objfiles.
2854         (shared_objfile_contains_address_p): Likewise.
2855         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2856         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2857
2858 2019-01-09  Tom Tromey  <tom@tromey.com>
2859
2860         * common/next-iterator.h: New file.
2861         * objfiles.h (class all_objfiles): New.
2862         (struct objfile_iterator): New.
2863
2864 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2865
2866         * NEWS: Move the description of the changed "frame", "select-frame",
2867          and "info frame" commands to the Changed commands section.
2868
2869 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2870
2871         * gdbtypes.c (check_stub_method_group): Remove handling of old
2872         mangling schemes.
2873         * linespec.c (find_methods): Likewise.
2874         * stabsread.c (read_member_functions): Likewise.
2875         * valops.c (search_struct_method): Likewise.
2876         (value_struct_elt_for_reference): Likewise.
2877         * NEWS: Mention this change.
2878
2879 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2880
2881         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2882         print_source_lines.
2883         * source.c (print_source_lines_base): Update line number check.
2884         (print_source_lines): New function.
2885         (source_lines_range::source_lines_range): New function.
2886         * source.h (class source_lines_range): New class.
2887         (print_source_lines): New declaration.
2888
2889 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2890
2891         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2892
2893 2019-01-08  Tom Tromey  <tom@tromey.com>
2894             Simon Marchi  <simon.marchi@ericsson.com>
2895
2896         PR gdb/24060
2897         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2898         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2899         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2900         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2901         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2902         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2903
2904 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2905
2906         * source.c (select_source_symtab): Move header comment to
2907         declaration in source.h.
2908         (forget_cached_source_info_for_objfile): Likewise.
2909         (forget_cached_source_info): Likewise.
2910         (identify_source_line): Likewise.
2911         * source.h (identify_source_line): Move declaration from symtab.h
2912         and add comment from source.c
2913         (print_source_lines): Likewise.
2914         (forget_cached_source_info_for_objfile): Likewise.
2915         (forget_cached_source_info): Likewise.
2916         (select_source_symtab): Likewise.
2917         (enum print_source_lines_flag): Move definition from symtab.h.
2918         * symtab.h (identify_source_line): Move declaration to source.h.
2919         (print_source_lines): Likewise.
2920         (forget_cached_source_info_for_objfile): Likewise.
2921         (forget_cached_source_info): Likewise.
2922         (select_source_symtab): Likewise.
2923         (enum print_source_lines_flag): Move definition to source.h.
2924         * tui/tui-hooks.c: Add 'source.h' include.
2925
2926 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2927
2928         * source.c (print_source_lines_base): Handle requests to print
2929         reverse line number sequences, and guard against empty lines
2930         string.
2931
2932 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2933
2934         * source.c (print_source_lines_base): Fix skip of '\r' if next
2935         character is '\n'.
2936
2937 2019-01-06  Tom Tromey  <tom@tromey.com>
2938
2939         * c-exp.y (struct c_parse_state) <macro_original_text,
2940         expansion_obstack>: New member.
2941         (macro_original_text, expansion_obstack): Remove globals.
2942         (scan_macro_expansion, scanning_macro_expansion)
2943         (finished_macro_expansion): Update.
2944         (scan_macro_cleanup): Remove.
2945         (yylex, c_parse): Update.
2946
2947 2019-01-06  Tom Tromey  <tom@tromey.com>
2948
2949         * c-exp.y (struct c_parse_state) <strings>: New member.
2950         (operator_stoken): Update.
2951
2952 2019-01-06  Tom Tromey  <tom@tromey.com>
2953
2954         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2955         (union type_stack_elt) <typelist_val>: Now a pointer to
2956         std::vector.
2957         (type_stack_cleanup): Don't declare.
2958         (push_typelist): Update.
2959         * parse.c (pop_typelist): Return a std::vector.
2960         (push_typelist): Take a std::vector.
2961         (follow_types): Update.  Do not free args.
2962         (type_stack_cleanup): Remove.
2963         * c-exp.y (struct c_parse_state): New.
2964         (cpstate): New global.
2965         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2966         (nonempty_typelist): Update.
2967         (func_mod): Create a new vector.
2968         (c_parse): Create a c_parse_state.
2969         (check_parameter_typelist): Do not delete params.
2970         (function_method): Update.  Do not delete type_list.
2971
2972 2019-01-06  Tom Tromey  <tom@tromey.com>
2973
2974         PR gdb/28155:
2975         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2976         check_typedef.
2977         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2978         (print_return_value): Likewise.
2979
2980 2019-01-05  Tom Tromey  <tom@tromey.com>
2981
2982         * contrib/cleanup_check.py: Remove.
2983         * contrib/gcc-with-excheck: Remove.
2984         * contrib/exsummary.py: Remove.
2985         * contrib/excheck.py: Remove.
2986
2987 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2988
2989         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2990         NULL. Initialize tpprev to NULL instead of assigning it
2991         to NULL on the next statement.
2992         * windows-nat.c (windows_delete_thread): Remove check for
2993         main_thread_id before printing thread exit notifications.
2994         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2995         Remove thread ID check against main_thread_id.
2996         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2997         windows_delete_thread.
2998         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2999
3000 2019-01-04  Tom Tromey  <tom@tromey.com>
3001
3002         * compile/compile.c (_initialize_compile): Use upper case for
3003         metasyntactic variables.
3004         * symmisc.c (_initialize_symmisc): Use upper case for
3005         metasyntactic variables.
3006         * psymtab.c (_initialize_psymtab): Use upper case for
3007         metasyntactic variables.
3008         * demangle.c (demangle_command): Use upper case for metasyntactic
3009         variables.
3010         (_initialize_demangler): Likewise.
3011         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3012         variables.
3013
3014 2019-01-03  Tom Tromey  <tom@tromey.com>
3015
3016         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3017
3018 2019-01-03  Tom Tromey  <tom@tromey.com>
3019
3020         * python/py-symtab.c (salpy_str): Update.
3021         (struct salpy_sal_object) <symtab>: Now a PyObject.
3022         (salpy_dealloc): Update.
3023         (del_objfile_sal): Use gdbpy_ref.
3024
3025 2019-01-03  Tom Tromey  <tom@tromey.com>
3026
3027         * python/py-type.c (convert_field): Use new_reference.  Return
3028         gdbpy_ref.
3029         (make_fielditem): Return gdbpy_ref.
3030         (typy_fields): Update.
3031         (typy_getitem): Update.
3032         (field_name): Return gdbpy_ref.  Use new_reference.
3033         (typy_iterator_iternext): Update.
3034
3035 2019-01-03  Tom Tromey  <tom@tromey.com>
3036
3037         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3038
3039 2019-01-03  Tom Tromey  <tom@tromey.com>
3040
3041         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3042         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3043         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3044         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3045         (pspy_set_type_printers): Likewise.
3046         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3047         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3048         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3049         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3050         (objfpy_set_type_printers): Likewise.
3051
3052 2019-01-03  Tom Tromey  <tom@tromey.com>
3053
3054         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3055         (gdbpy_print_stack): Use gdbpy_err_fetch.
3056         * python/python-internal.h (class gdbpy_err_fetch): New class.
3057         (class gdbpy_enter) <m_error_type, m_error_value,
3058         m_error_traceback>: Remove.
3059         <m_error>: New member.
3060         (gdbpy_exception_to_string): Don't declare.
3061         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3062         * python/py-value.c (convert_value_from_python): Use
3063         gdbpy_err_fetch.
3064         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3065         gdbpy_exception_to_string.
3066         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3067         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3068         gdbpy_err_fetch.
3069
3070 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3071
3072         * linux-nat.c (delete_lwp_cleanup): Delete.
3073         (struct lwp_deleter): New struct.
3074         (lwp_info_up): New typedef.
3075         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3076         lwp_info_up.
3077
3078 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3079
3080         * linux-fork.c (class scoped_switch_fork_info): New class.
3081         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3082
3083 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3084
3085         * valops.c (find_overload_match): Remove use of null_cleanup, and
3086         calls to do_cleanups.
3087
3088 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3089
3090         * compile/compile-cplus-types.c
3091         (compile_cplus_instance::decl_name): Handle changes to
3092         cp_func_name.
3093         * cp-support.c (cp_func_name): Update header comment, update
3094         return type.
3095         * cp-support.h (cp_func_name): Update return type in declaration.
3096         * valops.c (find_overload_match): Move temp_func local to top
3097         level of function and change its type.  Use temp_func to hold and
3098         delete temporary string obtained from cp_func_name.
3099
3100 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3103         gdb::char_vector, remove cleanup, and update uses of `msg`.
3104
3105 2019-01-03  Jim Wilson  <jimw@sifive.com>
3106
3107         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3108
3109 2019-01-02  Tom Tromey  <tom@tromey.com>
3110
3111         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3112         (tdesc_parse_xml): Remove cleanups.
3113         * target-descriptions.h (make_cleanup_free_target_description):
3114         Don't declare.
3115         (target_desc_deleter): New struct.
3116         (target_desc_up): New typedef.
3117         * target-descriptions.c (target_desc_deleter::operator()): Rename
3118         from free_target_description.
3119         (make_cleanup_free_target_description): Remove.
3120
3121 2019-01-02  Tom Tromey  <tom@tromey.com>
3122
3123         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3124         constructor, destructor.
3125         (linespec_parser): Remove typedef.
3126         (~linespec_parser): Rename from linespec_parser_delete.
3127         (linespec_lex_to_end, linespec_complete_label)
3128         (linespec_complete): Update.
3129         (decode_line_full): Remove cleanups.
3130         (decode_line_1): Update.
3131
3132 2019-01-02  Tom Tromey  <tom@tromey.com>
3133
3134         * python/python-internal.h (inferior_to_inferior_object): Change
3135         return type.
3136         * python/py-exitedevent.c (create_exited_event_object): Update.
3137         * python/py-inferior.c (inferior_to_inferior_object): Return
3138         gdbpy_ref.
3139         (python_new_inferior, python_inferior_deleted)
3140         (thread_to_thread_object, delete_thread_object)
3141         (build_inferior_list, gdbpy_selected_inferior): Update.
3142         * python/py-infthread.c (create_thread_object): Update.  Also fail
3143         if inferior_to_inferior_object fails.
3144
3145 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3146
3147         * inferior.h (class inferior) <displaced_step_state>: New field.
3148         * infrun.h (struct displaced_step_state): Move here from
3149         infrun.c.  Initialize fields, add constructor.
3150         <inf>: Remove field.
3151         <reset>: New method.
3152         * infrun.c (struct displaced_step_inferior_state): Move to
3153         infrun.h.
3154         (displaced_step_inferior_states): Remove.
3155         (get_displaced_stepping_state): Adust.
3156         (displaced_step_in_progress_any_inferior): Adjust.
3157         (displaced_step_in_progress_thread): Adjust.
3158         (displaced_step_in_progress): Adjust.
3159         (add_displaced_stepping_state): Remove.
3160         (get_displaced_step_closure_by_addr): Adjust.
3161         (remove_displaced_stepping_state): Remove.
3162         (infrun_inferior_exit): Call displaced_step_state.reset.
3163         (use_displaced_stepping): Don't check for NULL.
3164         (displaced_step_prepare_throw): Call
3165         get_displaced_stepping_state.
3166         (displaced_step_fixup): Don't check for NULL.
3167         (prepare_for_detach): Don't check for NULL.
3168
3169 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3170
3171         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3172          in case of call that did not complete.
3173
3174 2019-01-02  Andrey Utkin  <autkin@undo.io>
3175
3176         * symfile.c (find_separate_debug_file): Fix search of debug files for
3177         remote debuggee.
3178
3179 2019-01-02  Tom Tromey  <tom@tromey.com>
3180
3181         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3182         indentation.
3183         * python/py-frame.c (frapy_older): Remove cast.
3184         (frapy_newer): Likewise.
3185         * python/py-breakpoint.c (local_setattro): Remove cast.
3186         * python/py-arch.c (archpy_name): Remove local variable.
3187         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3188
3189 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3190
3191         * unittests/basic_string_view/element_access/char/empty.cc:
3192         Fix year range in copyright header.
3193
3194 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3195
3196         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3197         Delete.
3198         <operator==>: Update with for removed field.
3199         <hash>: Likewise.
3200         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3201         <isa_features>: ...this.
3202         <abi_features>: New field.
3203         (riscv_isa_flen): Update comment.
3204         (riscv_abi_xlen): New declaration.
3205         (riscv_abi_flen): New declaration.
3206         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3207         isa_features.
3208         (riscv_abi_xlen): New function.
3209         (riscv_isa_flen): Update to get answer from isa_features.
3210         (riscv_abi_flen): New function.
3211         (riscv_has_fp_abi): Update to get answer from abi_features.
3212         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3213         xlen and flen.
3214         (riscv_call_info) <xlen, flen>: Update comment.
3215         (riscv_call_arg_struct): Remove invalid assertions
3216         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3217         is removed.
3218         (riscv_gdbarch_init): Gather isa features and abi features
3219         separately, ensure both match on the gdbarch when reusing an old
3220         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3221         a target with 64-bit float hardware.
3222
3223 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3224
3225         * source.c (search_command_helper): Stop reverse search
3226         when line 1 has been searched.
3227
3228 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3229
3230         * record-full.c (record_full_base_target::close): Rewrite
3231         record_full_core_buf_list free logic.
3232
3233 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3234
3235         * break-catch-syscall.c (print_one_catch_syscall): xfree
3236         the last text.
3237
3238 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3239
3240         * top.c (print_gdb_version): Update Copyright year in version
3241         message.
3242
3243 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3244
3245         Update copyright year range in all GDB files.
3246
3247 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3248
3249         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3250
3251 For older changes see ChangeLog-2018.
3252 \f
3253 Local Variables:
3254 mode: change-log
3255 left-margin: 8
3256 fill-column: 74
3257 version-control: never
3258 coding: utf-8
3259 End:
3260