gdb/ChangeLog

   1 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * CONTRIBUTE: Replace contribution list with wiki link.
   4
   5 2019-01-25  Tom Tromey  <tom@tromey.com>
   6
   7         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
   8
   9 2019-01-25  Tom Tromey  <tom@tromey.com>
  10
  11         * xtensa-linux-nat.c: Fix common/ includes.
  12         * xml-support.h: Fix common/ includes.
  13         * xml-support.c: Fix common/ includes.
  14         * x86-linux-nat.c: Fix common/ includes.
  15         * windows-nat.c: Fix common/ includes.
  16         * varobj.h: Fix common/ includes.
  17         * varobj.c: Fix common/ includes.
  18         * value.c: Fix common/ includes.
  19         * valops.c: Fix common/ includes.
  20         * utils.c: Fix common/ includes.
  21         * unittests/xml-utils-selftests.c: Fix common/ includes.
  22         * unittests/utils-selftests.c: Fix common/ includes.
  23         * unittests/unpack-selftests.c: Fix common/ includes.
  24         * unittests/tracepoint-selftests.c: Fix common/ includes.
  25         * unittests/style-selftests.c: Fix common/ includes.
  26         * unittests/string_view-selftests.c: Fix common/ includes.
  27         * unittests/scoped_restore-selftests.c: Fix common/ includes.
  28         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
  29         * unittests/scoped_fd-selftests.c: Fix common/ includes.
  30         * unittests/rsp-low-selftests.c: Fix common/ includes.
  31         * unittests/parse-connection-spec-selftests.c: Fix common/
  32         includes.
  33         * unittests/optional-selftests.c: Fix common/ includes.
  34         * unittests/offset-type-selftests.c: Fix common/ includes.
  35         * unittests/observable-selftests.c: Fix common/ includes.
  36         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
  37         * unittests/memrange-selftests.c: Fix common/ includes.
  38         * unittests/memory-map-selftests.c: Fix common/ includes.
  39         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
  40         * unittests/function-view-selftests.c: Fix common/ includes.
  41         * unittests/environ-selftests.c: Fix common/ includes.
  42         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
  43         * unittests/common-utils-selftests.c: Fix common/ includes.
  44         * unittests/cli-utils-selftests.c: Fix common/ includes.
  45         * unittests/array-view-selftests.c: Fix common/ includes.
  46         * ui-file.c: Fix common/ includes.
  47         * tui/tui-io.c: Fix common/ includes.
  48         * tracepoint.h: Fix common/ includes.
  49         * tracepoint.c: Fix common/ includes.
  50         * tracefile-tfile.c: Fix common/ includes.
  51         * top.h: Fix common/ includes.
  52         * top.c: Fix common/ includes.
  53         * thread.c: Fix common/ includes.
  54         * target/waitstatus.h: Fix common/ includes.
  55         * target/waitstatus.c: Fix common/ includes.
  56         * target.h: Fix common/ includes.
  57         * target.c: Fix common/ includes.
  58         * target-memory.c: Fix common/ includes.
  59         * target-descriptions.c: Fix common/ includes.
  60         * symtab.h: Fix common/ includes.
  61         * symfile.c: Fix common/ includes.
  62         * stap-probe.c: Fix common/ includes.
  63         * spu-linux-nat.c: Fix common/ includes.
  64         * sparc-nat.c: Fix common/ includes.
  65         * source.c: Fix common/ includes.
  66         * solib.c: Fix common/ includes.
  67         * solib-target.c: Fix common/ includes.
  68         * ser-unix.c: Fix common/ includes.
  69         * ser-tcp.c: Fix common/ includes.
  70         * ser-pipe.c: Fix common/ includes.
  71         * ser-base.c: Fix common/ includes.
  72         * selftest-arch.c: Fix common/ includes.
  73         * s12z-tdep.c: Fix common/ includes.
  74         * rust-exp.y: Fix common/ includes.
  75         * rs6000-aix-tdep.c: Fix common/ includes.
  76         * riscv-tdep.c: Fix common/ includes.
  77         * remote.c: Fix common/ includes.
  78         * remote-notif.h: Fix common/ includes.
  79         * remote-fileio.h: Fix common/ includes.
  80         * remote-fileio.c: Fix common/ includes.
  81         * regcache.h: Fix common/ includes.
  82         * regcache.c: Fix common/ includes.
  83         * record-btrace.c: Fix common/ includes.
  84         * python/python.c: Fix common/ includes.
  85         * python/py-type.c: Fix common/ includes.
  86         * python/py-inferior.c: Fix common/ includes.
  87         * progspace.h: Fix common/ includes.
  88         * producer.c: Fix common/ includes.
  89         * procfs.c: Fix common/ includes.
  90         * proc-api.c: Fix common/ includes.
  91         * printcmd.c: Fix common/ includes.
  92         * ppc-linux-nat.c: Fix common/ includes.
  93         * parser-defs.h: Fix common/ includes.
  94         * osdata.c: Fix common/ includes.
  95         * obsd-nat.c: Fix common/ includes.
  96         * nat/x86-linux.c: Fix common/ includes.
  97         * nat/x86-linux-dregs.c: Fix common/ includes.
  98         * nat/x86-dregs.h: Fix common/ includes.
  99         * nat/x86-dregs.c: Fix common/ includes.
 100         * nat/ppc-linux.c: Fix common/ includes.
 101         * nat/mips-linux-watch.h: Fix common/ includes.
 102         * nat/mips-linux-watch.c: Fix common/ includes.
 103         * nat/linux-waitpid.c: Fix common/ includes.
 104         * nat/linux-ptrace.h: Fix common/ includes.
 105         * nat/linux-ptrace.c: Fix common/ includes.
 106         * nat/linux-procfs.c: Fix common/ includes.
 107         * nat/linux-personality.c: Fix common/ includes.
 108         * nat/linux-osdata.c: Fix common/ includes.
 109         * nat/linux-namespaces.c: Fix common/ includes.
 110         * nat/linux-btrace.h: Fix common/ includes.
 111         * nat/linux-btrace.c: Fix common/ includes.
 112         * nat/fork-inferior.c: Fix common/ includes.
 113         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 114         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 115         * nat/aarch64-linux.c: Fix common/ includes.
 116         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 117         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 118         * namespace.h: Fix common/ includes.
 119         * mips-linux-tdep.c: Fix common/ includes.
 120         * minsyms.c: Fix common/ includes.
 121         * mi/mi-parse.h: Fix common/ includes.
 122         * mi/mi-main.c: Fix common/ includes.
 123         * mi/mi-cmd-env.c: Fix common/ includes.
 124         * memrange.h: Fix common/ includes.
 125         * memattr.c: Fix common/ includes.
 126         * maint.h: Fix common/ includes.
 127         * maint.c: Fix common/ includes.
 128         * main.c: Fix common/ includes.
 129         * machoread.c: Fix common/ includes.
 130         * location.c: Fix common/ includes.
 131         * linux-thread-db.c: Fix common/ includes.
 132         * linux-nat.c: Fix common/ includes.
 133         * linux-fork.c: Fix common/ includes.
 134         * inline-frame.c: Fix common/ includes.
 135         * infrun.c: Fix common/ includes.
 136         * inflow.c: Fix common/ includes.
 137         * inferior.h: Fix common/ includes.
 138         * inferior.c: Fix common/ includes.
 139         * infcmd.c: Fix common/ includes.
 140         * inf-ptrace.c: Fix common/ includes.
 141         * inf-child.c: Fix common/ includes.
 142         * ia64-linux-nat.c: Fix common/ includes.
 143         * i387-tdep.c: Fix common/ includes.
 144         * i386-tdep.c: Fix common/ includes.
 145         * i386-linux-tdep.c: Fix common/ includes.
 146         * i386-linux-nat.c: Fix common/ includes.
 147         * i386-go32-tdep.c: Fix common/ includes.
 148         * i386-fbsd-tdep.c: Fix common/ includes.
 149         * i386-fbsd-nat.c: Fix common/ includes.
 150         * guile/scm-type.c: Fix common/ includes.
 151         * guile/guile.c: Fix common/ includes.
 152         * go32-nat.c: Fix common/ includes.
 153         * gnu-nat.c: Fix common/ includes.
 154         * gdbthread.h: Fix common/ includes.
 155         * gdbarch-selftests.c: Fix common/ includes.
 156         * gdb_usleep.c: Fix common/ includes.
 157         * gdb_select.h: Fix common/ includes.
 158         * gdb_bfd.c: Fix common/ includes.
 159         * gcore.c: Fix common/ includes.
 160         * fork-child.c: Fix common/ includes.
 161         * findvar.c: Fix common/ includes.
 162         * fbsd-nat.c: Fix common/ includes.
 163         * event-top.c: Fix common/ includes.
 164         * event-loop.c: Fix common/ includes.
 165         * dwarf2read.c: Fix common/ includes.
 166         * dwarf2loc.c: Fix common/ includes.
 167         * dwarf2-frame.c: Fix common/ includes.
 168         * dwarf-index-cache.c: Fix common/ includes.
 169         * dtrace-probe.c: Fix common/ includes.
 170         * disasm-selftests.c: Fix common/ includes.
 171         * defs.h: Fix common/ includes.
 172         * csky-tdep.c: Fix common/ includes.
 173         * cp-valprint.c: Fix common/ includes.
 174         * cp-support.h: Fix common/ includes.
 175         * cp-support.c: Fix common/ includes.
 176         * corelow.c: Fix common/ includes.
 177         * completer.h: Fix common/ includes.
 178         * completer.c: Fix common/ includes.
 179         * compile/compile.c: Fix common/ includes.
 180         * compile/compile-loc2c.c: Fix common/ includes.
 181         * compile/compile-cplus-types.c: Fix common/ includes.
 182         * compile/compile-cplus-symbols.c: Fix common/ includes.
 183         * command.h: Fix common/ includes.
 184         * cli/cli-dump.c: Fix common/ includes.
 185         * cli/cli-cmds.c: Fix common/ includes.
 186         * charset.c: Fix common/ includes.
 187         * build-id.c: Fix common/ includes.
 188         * btrace.h: Fix common/ includes.
 189         * btrace.c: Fix common/ includes.
 190         * breakpoint.h: Fix common/ includes.
 191         * breakpoint.c: Fix common/ includes.
 192         * ax.h:
 193         (enum agent_op): Fix common/ includes.
 194         * ax-general.c (struct aop_map): Fix common/ includes.
 195         * ax-gdb.c: Fix common/ includes.
 196         * auxv.c: Fix common/ includes.
 197         * auto-load.c: Fix common/ includes.
 198         * arm-tdep.c: Fix common/ includes.
 199         * arch/riscv.c: Fix common/ includes.
 200         * arch/ppc-linux-common.c: Fix common/ includes.
 201         * arch/i386.c: Fix common/ includes.
 202         * arch/arm.c: Fix common/ includes.
 203         * arch/arm-linux.c: Fix common/ includes.
 204         * arch/arm-get-next-pcs.c: Fix common/ includes.
 205         * arch/amd64.c: Fix common/ includes.
 206         * arch/aarch64.c: Fix common/ includes.
 207         * arch/aarch64-insn.c: Fix common/ includes.
 208         * arch-utils.c: Fix common/ includes.
 209         * amd64-windows-tdep.c: Fix common/ includes.
 210         * amd64-tdep.c: Fix common/ includes.
 211         * amd64-sol2-tdep.c: Fix common/ includes.
 212         * amd64-obsd-tdep.c: Fix common/ includes.
 213         * amd64-nbsd-tdep.c: Fix common/ includes.
 214         * amd64-linux-tdep.c: Fix common/ includes.
 215         * amd64-linux-nat.c: Fix common/ includes.
 216         * amd64-fbsd-tdep.c: Fix common/ includes.
 217         * amd64-fbsd-nat.c: Fix common/ includes.
 218         * amd64-dicos-tdep.c: Fix common/ includes.
 219         * amd64-darwin-tdep.c: Fix common/ includes.
 220         * agent.c: Fix common/ includes.
 221         * ada-lang.h: Fix common/ includes.
 222         * ada-lang.c: Fix common/ includes.
 223         * aarch64-tdep.c: Fix common/ includes.
 224
 225 2019-01-25  Tom Tromey  <tom@tromey.com>
 226
 227         * common/create-version.sh: Use common/version.h.
 228
 229 2019-01-24  Pedro Alves  <palves@redhat.com>
 230
 231         * infrun.c (signal_stop, signal_print, signal_program)
 232         (signal_catch, signal_pass): Now arrays instead of pointers.
 233         (update_signals_program_target, do_target_resume)
 234         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 235         * linux-nat.c (linux_nat_target::pass_signals)
 236         (linux_nat_target::create_inferior, linux_nat_target::attach):
 237         Adjust.
 238         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 239         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 240         * procfs.c (procfs_target::pass_signals): Adjust.
 241         * record-full.c (record_full_target::resume): Adjust.
 242         * remote.c (remote_target::pass_signals)
 243         (remote_target::program_signals): Adjust.
 244         * target-debug.h (target_debug_print_signals): Now takes a
 245         gdb::array_view as parameter.  Adjust.
 246         * target.h (target_ops) <pass_signals, program_signals>: Replace
 247         pointer and length parameters with gdb::array_view.
 248         (target_pass_signals, target_program_signals): Likewise.
 249         * target-delegates.c: Regenerate.
 250
 251 2019-01-24  Pedro Alves  <palves@redhat.com>
 252
 253         * common/forward-scope-exit.h
 254         (forward_scope_exit::forward_scope_exit): Pass arguments to
 255         m_bind_function directly, instead of creating a std::bind and
 256         copying that.
 257
 258 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 259
 260         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 261         for static members.
 262         (pass_in_v_vfp_candidate): Likewise.
 263
 264 2019-01-23  Tom Tromey  <tom@tromey.com>
 265             Pedro Alves  <palves@redhat.com>
 266
 267         * regcache.c (class regcache_invalidator): Remove.
 268         (regcache::raw_write): Use make_scope_exit.
 269
 270 2019-01-23  Tom Tromey  <tom@tromey.com>
 271
 272         * ui-out.h (class ui_out_emit_type): Update comment.
 273
 274 2019-01-23  Tom Tromey  <tom@tromey.com>
 275
 276         * infrun.c (fetch_inferior_event): Update comment.
 277
 278 2019-01-23  Tom Tromey  <tom@tromey.com>
 279             Pedro Alves  <palves@redhat.com>
 280
 281         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 282         parameter.
 283         (fetch_inferior_event): Use SCOPE_EXIT.
 284
 285
 286 2019-01-23  Tom Tromey  <tom@tromey.com>
 287             Pedro Alves  <palves@redhat.com>
 288
 289         * infrun.c (disable_thread_events): Delete.
 290         (stop_all_threads): Use SCOPE_EXIT.
 291
 292 2019-01-23  Tom Tromey  <tom@tromey.com>
 293             Pedro Alves  <palves@redhat.com>
 294
 295         * symfile.c: Include forward-scope-exit.h.
 296         (clear_symtab_users_cleanup): Replace forward declaration with
 297         a FORWARD_SCOPE_EXIT.
 298         (syms_from_objfile_1): Use the forward_scope_exit and
 299         gdb::optional instead of cleanup_function.
 300         (reread_symbols): Use the forward_scope_exit instead of
 301         cleanup_function.
 302         (clear_symtab_users_cleanup): Remove function.
 303
 304 2019-01-23  Tom Tromey  <tom@tromey.com>
 305             Pedro Alves  <palves@redhat.com>
 306
 307         * linux-nat.c: Include scope-exit.h.
 308         (cleanup_target_stop): Remove.
 309         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 310         SCOPE_EXIT.
 311
 312 2019-01-23  Tom Tromey  <tom@tromey.com>
 313             Pedro Alves  <palves@redhat.com>
 314
 315         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 316         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 317
 318 2019-01-23  Tom Tromey  <tom@tromey.com>
 319             Andrew Burgess  <andrew.burgess@embecosm.com>
 320             Pedro Alves  <palves@redhat.com>
 321
 322         * infrun.c (fetch_inferior_event): Use scope_exit.
 323         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 324         * top.c (execute_command): Use scope_exit.
 325         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 326         * utils.c (do_bpstat_clear_actions_cleanup)
 327         (make_bpstat_clear_actions_cleanup): Remove.
 328
 329 2019-01-23  Tom Tromey  <tom@tromey.com>
 330             Pedro Alves  <palves@redhat.com>
 331
 332         * infrun.c: Include "common/scope-exit.h"
 333         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 334         (wait_for_inferior): Use SCOPE_EXIT.
 335         (fetch_inferior_event): Use scope_exit.
 336
 337 2019-01-23  Tom Tromey  <tom@tromey.com>
 338             Pedro Alves  <palves@redhat.com>
 339
 340         * breakpoint.c (create_breakpoint): Remove cleanup.
 341
 342 2019-01-23  Tom Tromey  <tom@tromey.com>
 343             Andrew Burgess  <andrew.burgess@embecosm.com>
 344             Pedro Alves  <palves@redhat.com>
 345
 346 2019-01-23  Pedro Alves  <palves@redhat.com>
 347
 348         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 349
 350 2019-01-23  Pedro Alves  <palves@redhat.com>
 351             Andrew Burgess  <andrew.burgess@embecosm.com>
 352
 353         * gdbthread.h: Include "common/forward-scope-exit.h".
 354         (scoped_finish_thread_state): Redefine custom class in terms of
 355         forward_scope_exit.
 356
 357 2019-01-23  Pedro Alves  <palves@redhat.com>
 358             Andrew Burgess  <andrew.burgess@embecosm.com>
 359
 360         * common/forward-scope-exit.h: New file.
 361
 362 2019-01-23  Pedro Alves  <palves@redhat.com>
 363             Andrew Burgess  <andrew.burgess@embecosm.com>
 364             Tom Tromey  <tom@tromey.com>
 365
 366         * common/scope-exit.h: New file.
 367
 368 2019-01-23  Pedro Alves  <palves@redhat.com>
 369
 370         * common/preprocessor.h (ESC): Rename to ...
 371         (ESC_PARENS): ... this.
 372         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 373         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 374
 375 2019-01-23  Tom Tromey  <tom@tromey.com>
 376
 377         * language.h (class scoped_switch_to_sym_language_if_auto):
 378         Initialize m_lang in both cases.
 379
 380 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 381
 382         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 383         with XCNEW.
 384
 385 2019-01-22  Tom Tromey  <tom@tromey.com>
 386
 387         * corelow.c: Do not include sys/file.h.
 388
 389 2019-01-22  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-wingeneral.h: Include gdb_curses.h.
 392
 393 2019-01-22  Tom Tromey  <tom@tromey.com>
 394
 395         * source-cache.h (class source_cache) <get_source_lines,
 396         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 397
 398 2019-01-22  Tom Tromey  <tom@tromey.com>
 399
 400         * remote-fileio.h (struct remote_target): Declare.
 401
 402 2019-01-22  Tom Tromey  <tom@tromey.com>
 403
 404         * python/py-arch.c: Do not include py-ref.h.
 405         * python/py-bpevent.c: Do not include py-ref.h.
 406         * python/py-cmd.c: Do not include py-ref.h.
 407         * python/py-continueevent.c: Do not include py-ref.h.
 408         * python/py-event.h: Do not include py-ref.h.
 409         * python/py-evtregistry.c: Do not include py-ref.h.
 410         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 411         * python/py-frame.c: Do not include py-ref.h.
 412         * python/py-framefilter.c: Do not include py-ref.h.
 413         * python/py-function.c: Do not include py-ref.h.
 414         * python/py-infevents.c: Do not include py-ref.h.
 415         * python/py-linetable.c: Do not include py-ref.h.
 416         * python/py-objfile.c: Do not include py-ref.h.
 417         * python/py-param.c: Do not include py-ref.h.
 418         * python/py-prettyprint.c: Do not include py-ref.h.
 419         * python/py-progspace.c: Do not include py-ref.h.
 420         * python/py-symbol.c: Do not include py-ref.h.
 421         * python/py-symtab.c: Do not include py-ref.h.
 422         * python/py-type.c: Do not include py-ref.h.
 423         * python/py-unwind.c: Do not include py-ref.h.
 424         * python/py-utils.c: Do not include py-ref.h.
 425         * python/py-value.c: Do not include py-ref.h.
 426         * python/py-varobj.c: Do not include py-ref.h.
 427         * python/py-xmethods.c: Do not include py-ref.h.
 428         * python/python.c: Do not include py-ref.h.
 429         * varobj.c: Do not include py-ref.h.
 430
 431 2019-01-22  Tom Tromey  <tom@tromey.com>
 432
 433         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 434         keyword for bcache.
 435
 436 2019-01-22  Tom Tromey  <tom@tromey.com>
 437
 438         * compile/compile-cplus-types.c: Remove a comment by #include.
 439
 440 2019-01-22  Tom Tromey  <tom@tromey.com>
 441
 442         * compile/gcc-c-plugin.h: Include compile-internal.h.
 443
 444 2019-01-22  Tom Tromey  <tom@tromey.com>
 445
 446         * stabsread.c (EXTERN): Do not define.
 447         (symnum, next_symbol_text_func, processing_gcc_compilation)
 448         (within_function, global_sym_chain, global_stabs)
 449         (previous_stab_code, this_object_header_files)
 450         (n_this_object_header_files)
 451         (n_allocated_this_object_header_files): Define.
 452         * stabsread.h (EXTERN): Never define.  Use "extern".
 453
 454 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 455
 456         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 457         history_value.
 458
 459 2019-01-21  Tom Tromey  <tom@tromey.com>
 460
 461         * ui-out.c: Fix includes.
 462         * tui/tui-source.c: Fix includes.
 463         * target.c: Fix includes.
 464         * remote.c: Fix includes.
 465         * regcache.c: Fix includes.
 466         * python/py-block.c: Fix includes.
 467         * printcmd.c: Fix includes.
 468         * or1k-tdep.c: Fix includes.
 469         * mi/mi-main.c: Fix includes.
 470         * m32r-tdep.c: Fix includes.
 471         * csky-tdep.c: Fix includes.
 472         * compile/compile-cplus-types.c: Fix includes.
 473         * cli/cli-interp.c: Fix includes.
 474
 475 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 476
 477         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 478         for padding.
 479
 480 2019-01-16  Tom Tromey  <tom@tromey.com>
 481
 482         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 483         earlier.
 484         (struct objfile) <msymbols_range>: Move from top level.
 485         <msymbols>: New method.
 486         (class objfile_msymbols): Remove.
 487         * symtab.c (default_collect_symbol_completion_matches_break_on):
 488         Update.
 489         * symmisc.c (dump_msymbols): Update.
 490         * stabsread.c (scan_file_globals): Update.
 491         * objc-lang.c (info_selectors_command, info_classes_command)
 492         (find_methods): Update.
 493         * minsyms.c (find_solib_trampoline_target): Update.
 494         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 495         * coffread.c (coff_symfile_read): Update.
 496         * ada-lang.c (ada_lookup_simple_minsym)
 497         (ada_collect_symbol_completion_matches): Update.
 498
 499 2019-01-16  Tom Tromey  <tom@tromey.com>
 500
 501         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 502         type.  Remove no-argument constructor.
 503         <iterator::operator++>: Simplify.
 504         <begin>: Update.
 505         <end>: Use minimal_symbol_count.
 506
 507 2019-01-16  Tom Tromey  <tom@tromey.com>
 508
 509         * objfiles.h (struct objfile) <psymtabs>: New method.
 510         (class objfile_psymtabs): Remove.
 511         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 512         typedef.
 513         <range>: New method.
 514         (require_partial_symbols): Change return type.
 515         * psymtab.c (require_partial_symbols)
 516         (psym_expand_symtabs_matching): Update.
 517         * mdebugread.c (parse_partial_symbols): Update.
 518         * dbxread.c (dbx_end_psymtab): Update.
 519
 520 2019-01-15  Tom Tromey  <tom@tromey.com>
 521
 522         * symtab.c (lookup_objfile_from_block)
 523         (lookup_symbol_in_objfile_symtabs)
 524         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 525         (find_line_symtab, info_sources_command)
 526         (default_collect_symbol_completion_matches_break_on)
 527         (make_source_files_completion_list): Update.
 528         * symmisc.c (print_objfile_statistics, dump_objfile)
 529         (maintenance_print_symbols, maintenance_info_symtabs)
 530         (maintenance_check_symtabs, maintenance_info_line_tables):
 531         Update.
 532         * source.c (select_source_symtab)
 533         (forget_cached_source_info_for_objfile): Update.
 534         * objfiles.h (class objfile_compunits): Remove.
 535         (struct objfile) <compunits_range>: New typedef.
 536         (compunits): New method.
 537         * objfiles.c (objfile_relocate1): Update.
 538         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 539         * maint.c (count_symtabs_and_blocks): Update.
 540         * linespec.c (iterate_over_all_matching_symtabs): Update.
 541         * cp-support.c (add_symbol_overload_list_qualified): Update.
 542         * coffread.c (coff_symtab_read): Update.
 543         * ada-lang.c (add_nonlocal_symbols)
 544         (ada_collect_symbol_completion_matches)
 545         (ada_add_global_exceptions): Update.
 546
 547 2019-01-15  Tom Tromey  <tom@tromey.com>
 548
 549         * progspace.h (program_space) <objfiles_safe_range>: New
 550         typedef.
 551         <objfiles_safe>: New method.
 552         * objfiles.h (class all_objfiles_safe): Remove.
 553         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 554         * jit.c (jit_inferior_exit_hook): Update.
 555
 556 2019-01-17  Tom Tromey  <tom@tromey.com>
 557
 558         * progspace.h (program_space) <objfiles_range>: New typedef.
 559         <objfiles>: New method.
 560         <objfiles_head>: Rename from objfiles.
 561         (object_files): Update.
 562         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 563         * guile/scm-pretty-print.c
 564         (ppscm_find_pretty_printer_from_objfiles): Update.
 565         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 566         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 567         Update.
 568         * python/py-progspace.c (pspy_get_objfiles): Update.
 569         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 570         Update.
 571         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 572         (objfpy_lookup_objfile_by_build_id): Update.
 573         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 574         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 575         Update.
 576         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 577         (expand_symtab_containing_pc, lookup_objfile_from_block)
 578         (lookup_static_symbol, basic_lookup_transparent_type)
 579         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 580         (find_line_symtab, info_sources_command)
 581         (default_collect_symbol_completion_matches_break_on)
 582         (make_source_files_completion_list, find_main_name): Update.
 583         * symmisc.c (print_symbol_bcache_statistics)
 584         (print_objfile_statistics, maintenance_print_symbols)
 585         (maintenance_print_msymbols, maintenance_print_objfiles)
 586         (maintenance_info_symtabs, maintenance_check_symtabs)
 587         (maintenance_expand_symtabs, maintenance_info_line_tables):
 588         Update.
 589         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 590         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 591         (map_overlay_command, unmap_overlay_command)
 592         (simple_overlay_update, expand_symtabs_matching)
 593         (map_symbol_filenames): Update.
 594         * symfile-debug.c (set_debug_symfile): Update.
 595         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 596         Update.
 597         * source.c (select_source_symtab, forget_cached_source_info):
 598         Update.
 599         * solib.c (solib_read_symbols): Update.
 600         * solib-spu.c (append_ocl_sos): Update.
 601         * psymtab.c (maintenance_print_psymbols)
 602         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 603         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 604         * printcmd.c (info_symbol_command): Update.
 605         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 606         Update.
 607         * objfiles.h (class all_objfiles): Remove.
 608         * objfiles.c (have_partial_symbols, have_full_symbols)
 609         (have_minimal_symbols, qsort_cmp, update_section_map)
 610         (shared_objfile_contains_address_p)
 611         (default_iterate_over_objfiles_in_search_order): Update.
 612         * objc-lang.c (info_selectors_command, info_classes_command)
 613         (find_methods): Update.
 614         * minsyms.c (find_solib_trampoline_target): Update.
 615         * maint.c (maintenance_info_sections)
 616         (maintenance_translate_address, count_symtabs_and_blocks):
 617         Update.
 618         * main.c (captured_main_1): Update.
 619         * linux-thread-db.c (try_thread_db_load_from_pdir)
 620         (has_libpthread): Update.
 621         * linespec.c (iterate_over_all_matching_symtabs)
 622         (search_minsyms_for_name): Update.
 623         * jit.c (jit_find_objf_with_entry_addr): Update.
 624         * hppa-tdep.c (find_unwind_entry)
 625         (hppa_lookup_stub_minimal_symbol): Update.
 626         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 627         Update.
 628         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 629         (elf_gnu_ifunc_resolve_by_got): Update.
 630         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 631         * dwarf-index-write.c (save_gdb_index_command): Update.
 632         * cp-support.c (add_symbol_overload_list_qualified): Update.
 633         * breakpoint.c (create_overlay_event_breakpoint)
 634         (create_longjmp_master_breakpoint)
 635         (create_std_terminate_master_breakpoint)
 636         (create_exception_master_breakpoint): Update.
 637         * blockframe.c (find_pc_partial_function): Update.
 638         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 639         (ada_collect_symbol_completion_matches)
 640         (ada_add_global_exceptions): Update.
 641
 642 2019-01-17  Tom Tromey  <tom@tromey.com>
 643
 644         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 645         declare VEC.
 646         (solib_target_parse_libraries): Change return type.
 647         (library_list_start_segment, library_list_start_section)
 648         (library_list_end_library, library_list_start_library); Update.
 649         (solib_target_free_library_list): Remove.
 650         (solib_target_parse_libraries): Remove cleanup.  Change return
 651         type.
 652         (solib_target_current_sos): Update.
 653
 654 2019-01-17  Tom Tromey  <tromey@bapiya>
 655
 656         * valprint.c: Replace "the the" with "the".
 657         * symtab.c: Replace "the the" with "the".
 658         * solib.c: Replace "the the" with "the".
 659         * solib-dsbt.c: Replace "the the" with "the".
 660         * linespec.c: Replace "the the" with "the".
 661         * dwarf2loc.h: Replace "the the" with "the".
 662         * amd64-windows-tdep.c: Replace "the the" with "the".
 663         * aarch64-tdep.c: Replace "the the" with "the".
 664
 665 2019-01-16  Keith Seitz  <keiths@redhat.com>
 666
 667         PR gdb/23773
 668         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 669         <builder>: Rename to ..
 670         <m_builder>: ... this and make private.
 671         (dwarf2_cu::get_builder): New method.  Change all users of
 672         `builder' to use this method.
 673         (dwarf2_start_symtab): Move to ...
 674         (dwarf2_cu::start_symtab): ... here.  Update all callers
 675         (setup_type_unit_groups): Move to ...
 676         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 677         callers.
 678         (dwarf2_cu::reset_builder): New method.
 679         (process_full_compunit, process_full_type_unit): Use
 680         dwarf2_cu::reset_builder.
 681         (follow_die_offset): Record the ancestor CU if it is different
 682         from the followed DIE's CU.
 683         (follow_die_sig_1): Likewise.
 684
 685 2019-01-15  Tom Tromey  <tom@tromey.com>
 686
 687         * remote.c (class remote_state) <buf>: Now a char_vector.
 688         <buf_size>: Remove.
 689         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 690         parameter.
 691         (remote_target::getpkt_or_notif_sane_1)
 692         (remote_target::getpkt_sane)
 693         (remote_target::getpkt_or_notif_sane): Likewise.
 694         (class remote_target) <putpkt>: New overload.
 695         (remote_target::read_frame): Change type of "buf_p".  Remove
 696         sizeof_p parameter.
 697         (packet_ok): New overload.
 698         (packet_check_result): New overload.
 699         Update all uses.
 700
 701 2019-01-14  Tom Tromey  <tom@tromey.com>
 702
 703         * remote-notif.c (handle_notification, remote_notif_ack)
 704         (remote_notif_parse): Make "buf" const.
 705         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 706         const.
 707         (remote_notif_parse, remote_notif_ack, handle_notification):
 708         Likewise.
 709         * remote.c (remote_notif_stop_parse): Make "buf" const.
 710         (remote_target::remote_parse_stop_reply): Make "buf" const.
 711         (remote_notif_stop_ack): Make "buf" const.
 712
 713 2019-01-14  Tom Tromey  <tom@tromey.com>
 714
 715         * remote.c (remote_console_output): Make parameter const.
 716
 717 2019-01-14  Tom Tromey  <tom@tromey.com>
 718
 719         * target-debug.h (target_debug_print_signals): Constify.
 720         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 721         * procfs.c (procfs_target::pass_signals): Update.
 722         * linux-nat.c (linux_nat_target::pass_signals): Update.
 723         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 724         * target-delegates.c: Rebuild.
 725         * remote.c (remote_target::program_signals): Update.
 726         (remote_target::pass_signals): Update.
 727         * target.c (target_pass_signals): Constify argument.
 728         (target_program_signals): Likewise.
 729         * target.h (struct target_ops) <pass_signals, program_signals>:
 730         Constify argument.
 731         (target_pass_signals, target_program_signals): Constify argument.
 732
 733 2019-01-14  Tom Tromey  <tom@tromey.com>
 734
 735         PR tui/28819:
 736         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 737
 738 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 739
 740         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 741         field.
 742         * rs6000-tdep.c: Include reggroups.h.
 743         (IS_V_ALIAS_PSEUDOREG): Define.
 744         (rs6000_register_name): Return names for the "vX" aliases.
 745         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 746         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 747         aliases.  Call default_register_reggroup_p for all other
 748         pseudo-registers.
 749         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 750         New functions.
 751         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 752         Handle "vX" aliases.
 753         (v_alias_pseudo_register_collect): New function.
 754         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 755         (rs6000_gdbarch_init): Initialize "vX" aliases as
 756         pseudo-registers.  Restore registration of
 757         rs6000_pseudo_register_reggroup_p with
 758         set_tdesc_pseudo_register_reggroup_p.
 759
 760 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 761
 762         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 763         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 764         set_gdbarch_num_pseudo_regs.
 765
 766 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 767
 768         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 769         Remove arg prefixname, add do_set and do_show.
 770         Add member functions set_list and show_list.
 771         * cli/cli-style.c (class cli_style_option): Update accordingly.
 772         (style_set_list): Move to file scope.
 773         (style_show_list): Likewise.
 774         (set_style): Call help_list.
 775         (show_style): Call cmd_show_list.
 776         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 777         Update to use the new macro.
 778
 779 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 780
 781         * ada-lang.c (_initialize_ada_language): Expand the help text
 782         for the "catch exception" command.
 783
 784 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 785
 786         * symtab.c (matching_obj_sections): Initialize obj,
 787         declare it closer to its usage.
 788
 789 2019-01-10  Tom Tromey  <tom@tromey.com>
 790
 791         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 792         (basic_inf_threads_range): Remove.
 793         (inf_threads_range, inf_non_exited_threads_range)
 794         (safe_inf_threads_range): Use next_adapter.
 795
 796 2019-01-10  Keith Seitz  <keiths@redhat.com>
 797
 798         PR gdb/23712
 799         PR symtab/23010
 800         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 801         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 802
 803 2019-01-10  Keith Seitz  <keiths@redhat.com>
 804
 805         PR gdb/23712
 806         PR symtab/23010
 807         * dictionary.c (pending_to_vector): Remove.
 808         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 809         Remove _1 suffix, replacing functions of the same name.  Update
 810         all callers.
 811         (dict_create_hashed, dict_create_hashed_expandable)
 812         (dict_create_linear, dict_create_linear_expandable, dict_free)
 813         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 814         Make functions static.
 815
 816 2019-01-10  Keith Seitz  <keiths@redhat.com>
 817
 818         PR gdb/23712
 819         PR symtab/23010
 820         * dictionary.h (struct dictionary): Replace declaration with
 821         multidictionary.
 822         (dict_create_hashed, dict_create_hashed_expandable)
 823         (dict_create_linear, dict_create_linear_expandable)
 824         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 825         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 826         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 827         taking multidictionary argument.
 828         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 829         * block.h (struct block) <dict>: Change to multidictionary
 830         and rename `multidict'.
 831         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 832         symmisc.c: Update all dictionary references to multidictionary.
 833
 834 2019-01-10  Keith Seitz  <keiths@redhat.com>
 835
 836         PR gdb/23712
 837         PR symtab/23010
 838         * dictionary.c: Include unordered_map.
 839         (pending_to_vector): New function.
 840         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 841         Rewrite the non-"_1" functions to take vector instead
 842         of linked list.
 843         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 844         "new" _1 versions of the same name.
 845         (multidictionary): Define.
 846         (std::hash<enum language): New definition.
 847         (collate_pending_symbols_by_language, mdict_create_hashed)
 848         (mdict_create_hashed_expandable, mdict_create_linear)
 849         (mdict_create_linear_expandable, mdict_free)
 850         (find_language_dictionary, create_new_language_dictionary)
 851         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 852         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 853         (mdict_size, mdict_empty): New functions.
 854         * dictionary.h (mdict_iterator): Define.
 855
 856 2019-01-10  Pedro Alves  <palves@redhat.com>
 857
 858         * breakpoint.c (read_uploaded_action)
 859         (create_tracepoint_from_upload): Adjust to use
 860         gdb::unique_xmalloc_ptr.
 861         * ctf.c (ctf_write_uploaded_tp):
 862         (SET_ARRAY_FIELD): Use emplace_back.
 863         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 864         * tracefile-tfile.c (tfile_write_uploaded_tp):
 865         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 866         gdb::unique_xmalloc_ptr.
 867         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 868         at_string, cond_string, cmd_strings>: Replace char pointers
 869         with gdb::unique_xmalloc_ptr.
 870
 871 2019-01-10  Pedro Alves  <palves@redhat.com>
 872
 873         * solib-target.c (library_list_start_library): Don't xstrdup name.
 874
 875 2019-01-10  Pedro Alves  <palves@redhat.com>
 876
 877         * mdebugread.c (parse_partial_symbols): Use
 878         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 879
 880 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 881
 882         * linux-fork.c (scoped_switch_fork_info)
 883         <~scoped_switch_fork_info>: Fix incorrect variable name.
 884
 885 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * linux-fork.c (scoped_switch_fork_info)
 888         <scoped_switch_fork_info>: Make explicit.
 889         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 890
 891 2019-01-10  Tom Tromey  <tom@tromey.com>
 892
 893         * objfiles.h (objfile::reset_psymtabs): Update.
 894         * objfiles.c (objfile::objfile): Update.
 895         * psymtab.h (psymtab_storage::obstack): Update.
 896         (psymtab_storage::m_obstack): Use gdb::optional.
 897         (class psymtab_storage): Update comment.  Remove objfile
 898         parameter.
 899         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 900
 901 2019-01-10  Tom Tromey  <tom@tromey.com>
 902
 903         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 904         <free_psymtabs>: Now private.
 905         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 906         (allocate_psymtab): Use new method.
 907
 908 2019-01-10  Tom Tromey  <tom@tromey.com>
 909
 910         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 911         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 912         * mdebugread.c (parse_partial_symbols): Use
 913         allocate_dependencies.
 914         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 915         allocate_dependencies.
 916         (process_psymtab_comp_unit_reader)
 917         (build_type_psymtab_dependencies): Likewise.
 918         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 919
 920 2019-01-10  Tom Tromey  <tom@tromey.com>
 921
 922         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 923         PSYMBOL_SET_LANGUAGE.
 924         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 925
 926 2019-01-10  Tom Tromey  <tom@tromey.com>
 927
 928         * psymtab.h (psymtab_storage::obstack): New method.
 929         <m_obstack>: Rename from obstack; now private.
 930         * psymtab.c (psymtab_storage): Update.
 931         * dwarf2read.c (create_addrmap_from_index)
 932         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 933         Update.
 934
 935 2019-01-10  Tom Tromey  <tom@tromey.com>
 936
 937         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 938         * objfiles.h (objfile::reset_psymtabs): New method.
 939
 940 2019-01-10  Tom Tromey  <tom@tromey.com>
 941
 942         * symmisc.c (print_symbol_bcache_statistics): Update.
 943         (print_objfile_statistics): Update.
 944         * symfile.c (reread_symbols): Update.
 945         * psymtab.h (class psymtab_storage): New.
 946         * psymtab.c (psymtab_storage): New constructor.
 947         (~psymtab_storage): New destructor.
 948         (require_partial_symbols): Update.
 949         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 950         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 951         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 952         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 953         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 954         (start_psymtab_common, end_psymtab_common)
 955         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 956         (allocate_psymtab): Update.
 957         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 958         Update.
 959         (dump_psymtab_addrmap, maintenance_print_psymbols)
 960         (maintenance_check_psymtabs): Update.
 961         (class objfile_psymtabs): Move to objfiles.h.
 962         * psympriv.h (discard_psymtab): Now inline.
 963         (psymtab_discarder::psymtab_discarder): Update.
 964         (psymtab_discarder::~psymtab_discarder): Update.
 965         (ALL_OBJFILE_PSYMTABS): Rewrite.
 966         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 967         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 968         Remove fields.
 969         <partial_symtabs>: New field.
 970         (class objfile_psymtabs): Move from psymtab.h.  Update.
 971         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 972         psymbol_cache.
 973         (objfile::~objfile): Don't destroy psymbol_cache.
 974         * mdebugread.c (parse_partial_symbols): Update.
 975         * dwarf2read.c (create_addrmap_from_index)
 976         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 977         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 978         (add_partial_subprogram, dwarf2_ranges_read): Update.
 979         * dwarf-index-write.c (write_address_map)
 980         (write_one_signatured_type, recursively_write_psymbols)
 981         (class debug_names, class debug_names, write_psymtabs_to_index):
 982         Update.
 983
 984 2019-01-10  Tom Tromey  <tom@tromey.com>
 985
 986         * symtab.h (SYMBOL_SET_NAMES): Update.
 987         (symbol_set_names): Update.
 988         (MSYMBOL_SET_NAMES): Update.
 989         * symtab.c (symbol_set_names): Change argument to be an
 990         objfile_per_bfd_storage.
 991         * psymtab.c (add_psymbol_to_bcache): Update.
 992         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 993
 994 2019-01-10  Tom Tromey  <tom@tromey.com>
 995
 996         * symtab.c (create_demangled_names_hash): Change argument to be an
 997         objfile_per_bfd_storage.
 998         (symbol_set_names): Update.
 999
1000 2019-01-10  Tom Tromey  <tom@tromey.com>
1001
1002         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1003         init_psymbol_list.
1004         * psymtab.c (init_psymbol_list): Do nothing if already called.
1005         * psympriv.h (init_psymbol_list): Add comment.
1006         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1007         init_psymbol_list.
1008         * dbxread.c (dbx_symfile_read): Unconditionally call
1009         init_psymbol_list.
1010
1011 2019-01-10  Tom Tromey  <tom@tromey.com>
1012
1013         * xcoffread.c (scan_xcoff_symtab): Update.
1014         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1015         "where".
1016         * mdebugread.c (parse_partial_symbols)
1017         (handle_psymbol_enumerators): Update.
1018         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1019         * dbxread.c (read_dbx_symtab): Update.
1020         * psympriv.h (psymbol_placement): New enum.
1021         (add_psymbol_to_list): Update.
1022
1023 2019-01-10  Tom Tromey  <tom@tromey.com>
1024
1025         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1026         static_psymbols parameters.
1027         (scan_xcoff_symtab): Update.
1028         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1029         static_psymbols parameters.
1030         * psympriv.h (start_psymtab_common): Update.
1031         * mdebugread.c (parse_partial_symbols): Update.
1032         * dwarf2read.c (create_partial_symtab): Update.
1033         * dbxread.c (read_dbx_symtab): Update.
1034         (start_psymtab): Remove global_psymbols and static_psymbols
1035         parameters.
1036
1037 2019-01-10  Tom Tromey  <tom@tromey.com>
1038
1039         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1040         * psymtab.c (allocate_psymtab): Add comment.
1041         * psympriv.h (allocate_psymtab): Add comment.
1042         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1043         initializations.
1044         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1045
1046 2019-01-10  Tom Tromey  <tom@tromey.com>
1047
1048         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1049         Don't declare.
1050         * mipsread.c: Include mdebugread.h.
1051         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1052         Declare.
1053         * elfread.c: Include mdebugread.h.
1054
1055 2019-01-09  Tom Tromey  <tom@tromey.com>
1056
1057         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1058         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1059         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1060         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1061         (psym_lookup_symbol, psym_find_last_source_symtab)
1062         (psym_forget_cached_source_info, psym_print_stats)
1063         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1064         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1065         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1066         (psym_find_compunit_symtab_by_address)
1067         (maintenance_print_psymbols, maintenance_info_psymtabs)
1068         (maintenance_check_psymtabs): Use ranged for.
1069         * psymtab.h (class objfile_psymtabs): New.
1070         (require_partial_symbols): Return objfile_psymtabs.
1071         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1072
1073 2019-01-09  Tom Tromey  <tom@tromey.com>
1074
1075         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1076         (find_pc_mapped_section, list_overlays_command)
1077         (map_overlay_command, unmap_overlay_command)
1078         (simple_overlay_update): Use all_objfiles.
1079         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1080         * printcmd.c (info_symbol_command): Use all_objfiles.
1081         * objfiles.h (ALL_OBJSECTIONS): Remove.
1082         * maint.c (maintenance_translate_address): Use all_objfiles.
1083         * gcore.c (gcore_create_callback): Use all_objfiles.
1084         (objfile_find_memory_regions): Likewise.
1085
1086 2019-01-09  Tom Tromey  <tom@tromey.com>
1087
1088         * symtab.c (find_line_symtab, info_sources_command)
1089         (make_source_files_completion_list): Use objfile_compunits.
1090         * source.c (select_source_symtab): Use objfile_compunits.
1091         * objfiles.h (struct objfile): Update comment.
1092         (ALL_OBJFILES): Remove.
1093         (ALL_FILETABS): Remove.
1094         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1095         objfile_compunits.
1096
1097 2019-01-09  Tom Tromey  <tom@tromey.com>
1098
1099         * symmisc.c (print_objfile_statistics, dump_objfile)
1100         (maintenance_print_symbols): Use compunit_filetabs.
1101         * source.c (forget_cached_source_info_for_objfile): Use
1102         compunit_filetabs.
1103         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1104         (ALL_FILETABS): Use compunit_filetabs.
1105         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1106         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1107
1108 2019-01-09  Tom Tromey  <tom@tromey.com>
1109
1110         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1111         (compunit_filetabs): New.
1112         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1113         compunit_filetabs.
1114         (info_sources_command, make_source_files_completion_list): Remove
1115         declaration.
1116         * symmisc.c (print_objfile_statistics, dump_objfile)
1117         (maintenance_print_symbols): Remove declaration.
1118         (maintenance_info_symtabs): Use compunit_filetabs.
1119         (maintenance_info_line_tables): Likewise.
1120         * source.c (select_source_symtab): Change local variable name.
1121         (forget_cached_source_info_for_objfile): Remove declaration.
1122         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1123         * objfiles.c (objfile_relocate1): Remove declaration.
1124         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1125         declaration.
1126         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1127         * coffread.c (coff_symtab_read): Remove declaration.
1128         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1129         compunit_filetabs.
1130
1131 2019-01-09  Tom Tromey  <tom@tromey.com>
1132
1133         * symtab.c (lookup_objfile_from_block)
1134         (find_pc_sect_compunit_symtab, search_symbols)
1135         (default_collect_symbol_completion_matches_break_on): Use
1136         objfile_compunits.
1137         * objfiles.h (ALL_COMPUNITS): Remove.
1138         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1139         * cp-support.c (add_symbol_overload_list_qualified): Use
1140         objfile_compunits.
1141         * ada-lang.c (ada_collect_symbol_completion_matches)
1142         (ada_add_global_exceptions): Use objfile_compunits.
1143
1144 2019-01-09  Tom Tromey  <tom@tromey.com>
1145
1146         * source.c (select_source_symtab)
1147         (forget_cached_source_info_for_objfile): Remove declaration.
1148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1149         declaration.
1150         * maint.c (count_symtabs_and_blocks): Remove declaration.
1151         * cp-support.c (add_symbol_overload_list_qualified): Remove
1152         declaration.
1153         * coffread.c (coff_symtab_read): Remove declaration.
1154         * symtab.c (lookup_symbol_in_objfile_symtabs)
1155         (basic_lookup_transparent_type_1): Use objfile_compunits.
1156         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1157         (info_sources_command, search_symbols)
1158         (default_collect_symbol_completion_matches_break_on)
1159         (make_source_files_completion_list): Remove declaration.
1160         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1161         (ada_collect_symbol_completion_matches)
1162         (ada_add_global_exceptions): Remove declaration.
1163         * linespec.c (iterate_over_all_matching_symtabs): Use
1164         objfile_compunits.
1165         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1166         (class objfile_compunits): New.
1167         (ALL_COMPUNITS): Use objfile_compunits.
1168         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1169         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1170         objfile_compunits.
1171         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1172
1173 2019-01-09  Tom Tromey  <tom@tromey.com>
1174
1175         * symtab.c (search_symbols)
1176         (default_collect_symbol_completion_matches_break_on): Use
1177         objfile_msymbols.
1178         * ada-lang.c (ada_lookup_simple_minsym)
1179         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1180         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1181         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1182         objfile_msymbols.
1183         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1184         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1185         * objc-lang.c (find_methods): Use objfile_msymbols.
1186         (info_selectors_command, info_classes_command): Likewise.
1187         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1188         * objfiles.h (class objfile_msymbols): New.
1189         (ALL_OBJFILE_MSYMBOLS): Remove.
1190         (ALL_MSYMBOLS): Remove.
1191
1192 2019-01-09  Tom Tromey  <tom@tromey.com>
1193
1194         * common/next-iterator.h (next_adapter): Add Iterator template
1195         parameter.
1196         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1197         (class all_objfiles_safe): New.
1198         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1199         * objfiles.c (put_objfile_before): Update comment.
1200         (add_separate_debug_objfile): Likewise.
1201         (free_all_objfiles): Use all_objfiles_safe.
1202         (objfile_purge_solibs): Likewise.
1203
1204 2019-01-09  Tom Tromey  <tom@tromey.com>
1205
1206         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1207         (expand_symtab_containing_pc, lookup_static_symbol)
1208         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1209         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1210         all_objfiles.
1211         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1212         * breakpoint.c (create_overlay_event_breakpoint)
1213         (create_longjmp_master_breakpoint)
1214         (create_std_terminate_master_breakpoint)
1215         (create_exception_master_breakpoint): Use all_objfiles.
1216         * linux-thread-db.c (try_thread_db_load_from_pdir)
1217         (has_libpthread): Use all_objfiles.
1218         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1219         * linespec.c (iterate_over_all_matching_symtabs)
1220         (search_minsyms_for_name): Use all_objfiles.
1221         * maint.c (maintenance_info_sections): Use all_objfiles.
1222         * main.c (captured_main_1): Use all_objfiles.
1223         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1224         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1225         * guile/scm-pretty-print.c
1226         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1227         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1228         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1229         (maintenance_print_msymbols): Use all_objfiles.
1230         * source.c (select_source_symtab): Use all_objfiles.
1231         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1232         * symfile.c (remove_symbol_file_command)
1233         (expand_symtabs_matching, map_symbol_filenames): Use
1234         all_objfiles.
1235         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1236         all_objfiles.
1237         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1238         * objc-lang.c (find_methods): Use all_objfiles.
1239         * objfiles.c (have_partial_symbols, have_full_symbols)
1240         (have_minimal_symbols, qsort_cmp)
1241         (default_iterate_over_objfiles_in_search_order): Use
1242         all_objfiles.
1243         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1244         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1245         (maintenance_check_psymtabs): Use all_objfiles.
1246         (ALL_PSYMTABS): Remove.
1247         * compile/compile-object-run.c (do_module_cleanup): Use
1248         all_objfiles.
1249         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1250         * cp-support.c (add_symbol_overload_list_qualified): Use
1251         all_objfiles.
1252         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1253         Use all_objfiles.
1254         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1255         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1256         all_objfiles.
1257         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1258         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1259         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1260         Uses all_objfiles.
1261         * solib.c (solib_read_symbols): Use all_objfiles
1262
1263 2019-01-09  Tom Tromey  <tom@tromey.com>
1264
1265         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1266         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1267         all_objfiles.
1268         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1269         * symmisc.c (print_symbol_bcache_statistics)
1270         (print_objfile_statistics, maintenance_print_objfiles)
1271         (maintenance_info_symtabs, maintenance_check_symtabs)
1272         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1273         all_objfiles.
1274         * source.c (forget_cached_source_info): Use all_objfiles.
1275         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1276         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1277         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1278         * objfiles.c (update_section_map): Use all_objfiles.
1279         (shared_objfile_contains_address_p): Likewise.
1280         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1281         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1282
1283 2019-01-09  Tom Tromey  <tom@tromey.com>
1284
1285         * common/next-iterator.h: New file.
1286         * objfiles.h (class all_objfiles): New.
1287         (struct objfile_iterator): New.
1288
1289 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1290
1291         * NEWS: Move the description of the changed "frame", "select-frame",
1292          and "info frame" commands to the Changed commands section.
1293
1294 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1295
1296         * gdbtypes.c (check_stub_method_group): Remove handling of old
1297         mangling schemes.
1298         * linespec.c (find_methods): Likewise.
1299         * stabsread.c (read_member_functions): Likewise.
1300         * valops.c (search_struct_method): Likewise.
1301         (value_struct_elt_for_reference): Likewise.
1302         * NEWS: Mention this change.
1303
1304 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1305
1306         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1307         print_source_lines.
1308         * source.c (print_source_lines_base): Update line number check.
1309         (print_source_lines): New function.
1310         (source_lines_range::source_lines_range): New function.
1311         * source.h (class source_lines_range): New class.
1312         (print_source_lines): New declaration.
1313
1314 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1315
1316         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1317
1318 2019-01-08  Tom Tromey  <tom@tromey.com>
1319             Simon Marchi  <simon.marchi@ericsson.com>
1320
1321         PR gdb/24060
1322         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1323         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1324         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1325         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1326         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1327         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1328
1329 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * source.c (select_source_symtab): Move header comment to
1332         declaration in source.h.
1333         (forget_cached_source_info_for_objfile): Likewise.
1334         (forget_cached_source_info): Likewise.
1335         (identify_source_line): Likewise.
1336         * source.h (identify_source_line): Move declaration from symtab.h
1337         and add comment from source.c
1338         (print_source_lines): Likewise.
1339         (forget_cached_source_info_for_objfile): Likewise.
1340         (forget_cached_source_info): Likewise.
1341         (select_source_symtab): Likewise.
1342         (enum print_source_lines_flag): Move definition from symtab.h.
1343         * symtab.h (identify_source_line): Move declaration to source.h.
1344         (print_source_lines): Likewise.
1345         (forget_cached_source_info_for_objfile): Likewise.
1346         (forget_cached_source_info): Likewise.
1347         (select_source_symtab): Likewise.
1348         (enum print_source_lines_flag): Move definition to source.h.
1349         * tui/tui-hooks.c: Add 'source.h' include.
1350
1351 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1352
1353         * source.c (print_source_lines_base): Handle requests to print
1354         reverse line number sequences, and guard against empty lines
1355         string.
1356
1357 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1358
1359         * source.c (print_source_lines_base): Fix skip of '\r' if next
1360         character is '\n'.
1361
1362 2019-01-06  Tom Tromey  <tom@tromey.com>
1363
1364         * c-exp.y (struct c_parse_state) <macro_original_text,
1365         expansion_obstack>: New member.
1366         (macro_original_text, expansion_obstack): Remove globals.
1367         (scan_macro_expansion, scanning_macro_expansion)
1368         (finished_macro_expansion): Update.
1369         (scan_macro_cleanup): Remove.
1370         (yylex, c_parse): Update.
1371
1372 2019-01-06  Tom Tromey  <tom@tromey.com>
1373
1374         * c-exp.y (struct c_parse_state) <strings>: New member.
1375         (operator_stoken): Update.
1376
1377 2019-01-06  Tom Tromey  <tom@tromey.com>
1378
1379         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1380         (union type_stack_elt) <typelist_val>: Now a pointer to
1381         std::vector.
1382         (type_stack_cleanup): Don't declare.
1383         (push_typelist): Update.
1384         * parse.c (pop_typelist): Return a std::vector.
1385         (push_typelist): Take a std::vector.
1386         (follow_types): Update.  Do not free args.
1387         (type_stack_cleanup): Remove.
1388         * c-exp.y (struct c_parse_state): New.
1389         (cpstate): New global.
1390         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1391         (nonempty_typelist): Update.
1392         (func_mod): Create a new vector.
1393         (c_parse): Create a c_parse_state.
1394         (check_parameter_typelist): Do not delete params.
1395         (function_method): Update.  Do not delete type_list.
1396
1397 2019-01-06  Tom Tromey  <tom@tromey.com>
1398
1399         PR gdb/28155:
1400         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1401         check_typedef.
1402         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1403         (print_return_value): Likewise.
1404
1405 2019-01-05  Tom Tromey  <tom@tromey.com>
1406
1407         * contrib/cleanup_check.py: Remove.
1408         * contrib/gcc-with-excheck: Remove.
1409         * contrib/exsummary.py: Remove.
1410         * contrib/excheck.py: Remove.
1411
1412 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1413
1414         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1415         NULL. Initialize tpprev to NULL instead of assigning it
1416         to NULL on the next statement.
1417         * windows-nat.c (windows_delete_thread): Remove check for
1418         main_thread_id before printing thread exit notifications.
1419         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1420         Remove thread ID check against main_thread_id.
1421         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1422         windows_delete_thread.
1423         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1424
1425 2019-01-04  Tom Tromey  <tom@tromey.com>
1426
1427         * compile/compile.c (_initialize_compile): Use upper case for
1428         metasyntactic variables.
1429         * symmisc.c (_initialize_symmisc): Use upper case for
1430         metasyntactic variables.
1431         * psymtab.c (_initialize_psymtab): Use upper case for
1432         metasyntactic variables.
1433         * demangle.c (demangle_command): Use upper case for metasyntactic
1434         variables.
1435         (_initialize_demangler): Likewise.
1436         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1437         variables.
1438
1439 2019-01-03  Tom Tromey  <tom@tromey.com>
1440
1441         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1442
1443 2019-01-03  Tom Tromey  <tom@tromey.com>
1444
1445         * python/py-symtab.c (salpy_str): Update.
1446         (struct salpy_sal_object) <symtab>: Now a PyObject.
1447         (salpy_dealloc): Update.
1448         (del_objfile_sal): Use gdbpy_ref.
1449
1450 2019-01-03  Tom Tromey  <tom@tromey.com>
1451
1452         * python/py-type.c (convert_field): Use new_reference.  Return
1453         gdbpy_ref.
1454         (make_fielditem): Return gdbpy_ref.
1455         (typy_fields): Update.
1456         (typy_getitem): Update.
1457         (field_name): Return gdbpy_ref.  Use new_reference.
1458         (typy_iterator_iternext): Update.
1459
1460 2019-01-03  Tom Tromey  <tom@tromey.com>
1461
1462         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1463
1464 2019-01-03  Tom Tromey  <tom@tromey.com>
1465
1466         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1467         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1468         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1469         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1470         (pspy_set_type_printers): Likewise.
1471         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1472         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1473         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1474         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1475         (objfpy_set_type_printers): Likewise.
1476
1477 2019-01-03  Tom Tromey  <tom@tromey.com>
1478
1479         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1480         (gdbpy_print_stack): Use gdbpy_err_fetch.
1481         * python/python-internal.h (class gdbpy_err_fetch): New class.
1482         (class gdbpy_enter) <m_error_type, m_error_value,
1483         m_error_traceback>: Remove.
1484         <m_error>: New member.
1485         (gdbpy_exception_to_string): Don't declare.
1486         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1487         * python/py-value.c (convert_value_from_python): Use
1488         gdbpy_err_fetch.
1489         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1490         gdbpy_exception_to_string.
1491         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1492         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1493         gdbpy_err_fetch.
1494
1495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1496
1497         * linux-nat.c (delete_lwp_cleanup): Delete.
1498         (struct lwp_deleter): New struct.
1499         (lwp_info_up): New typedef.
1500         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1501         lwp_info_up.
1502
1503 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1504
1505         * linux-fork.c (class scoped_switch_fork_info): New class.
1506         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1507
1508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1509
1510         * valops.c (find_overload_match): Remove use of null_cleanup, and
1511         calls to do_cleanups.
1512
1513 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1514
1515         * compile/compile-cplus-types.c
1516         (compile_cplus_instance::decl_name): Handle changes to
1517         cp_func_name.
1518         * cp-support.c (cp_func_name): Update header comment, update
1519         return type.
1520         * cp-support.h (cp_func_name): Update return type in declaration.
1521         * valops.c (find_overload_match): Move temp_func local to top
1522         level of function and change its type.  Use temp_func to hold and
1523         delete temporary string obtained from cp_func_name.
1524
1525 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1526
1527         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1528         gdb::char_vector, remove cleanup, and update uses of `msg`.
1529
1530 2019-01-03  Jim Wilson  <jimw@sifive.com>
1531
1532         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1533
1534 2019-01-02  Tom Tromey  <tom@tromey.com>
1535
1536         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1537         (tdesc_parse_xml): Remove cleanups.
1538         * target-descriptions.h (make_cleanup_free_target_description):
1539         Don't declare.
1540         (target_desc_deleter): New struct.
1541         (target_desc_up): New typedef.
1542         * target-descriptions.c (target_desc_deleter::operator()): Rename
1543         from free_target_description.
1544         (make_cleanup_free_target_description): Remove.
1545
1546 2019-01-02  Tom Tromey  <tom@tromey.com>
1547
1548         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1549         constructor, destructor.
1550         (linespec_parser): Remove typedef.
1551         (~linespec_parser): Rename from linespec_parser_delete.
1552         (linespec_lex_to_end, linespec_complete_label)
1553         (linespec_complete): Update.
1554         (decode_line_full): Remove cleanups.
1555         (decode_line_1): Update.
1556
1557 2019-01-02  Tom Tromey  <tom@tromey.com>
1558
1559         * python/python-internal.h (inferior_to_inferior_object): Change
1560         return type.
1561         * python/py-exitedevent.c (create_exited_event_object): Update.
1562         * python/py-inferior.c (inferior_to_inferior_object): Return
1563         gdbpy_ref.
1564         (python_new_inferior, python_inferior_deleted)
1565         (thread_to_thread_object, delete_thread_object)
1566         (build_inferior_list, gdbpy_selected_inferior): Update.
1567         * python/py-infthread.c (create_thread_object): Update.  Also fail
1568         if inferior_to_inferior_object fails.
1569
1570 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1571
1572         * inferior.h (class inferior) <displaced_step_state>: New field.
1573         * infrun.h (struct displaced_step_state): Move here from
1574         infrun.c.  Initialize fields, add constructor.
1575         <inf>: Remove field.
1576         <reset>: New method.
1577         * infrun.c (struct displaced_step_inferior_state): Move to
1578         infrun.h.
1579         (displaced_step_inferior_states): Remove.
1580         (get_displaced_stepping_state): Adust.
1581         (displaced_step_in_progress_any_inferior): Adjust.
1582         (displaced_step_in_progress_thread): Adjust.
1583         (displaced_step_in_progress): Adjust.
1584         (add_displaced_stepping_state): Remove.
1585         (get_displaced_step_closure_by_addr): Adjust.
1586         (remove_displaced_stepping_state): Remove.
1587         (infrun_inferior_exit): Call displaced_step_state.reset.
1588         (use_displaced_stepping): Don't check for NULL.
1589         (displaced_step_prepare_throw): Call
1590         get_displaced_stepping_state.
1591         (displaced_step_fixup): Don't check for NULL.
1592         (prepare_for_detach): Don't check for NULL.
1593
1594 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1595
1596         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1597          in case of call that did not complete.
1598
1599 2019-01-02  Andrey Utkin  <autkin@undo.io>
1600
1601         * symfile.c (find_separate_debug_file): Fix search of debug files for
1602         remote debuggee.
1603
1604 2019-01-02  Tom Tromey  <tom@tromey.com>
1605
1606         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1607         indentation.
1608         * python/py-frame.c (frapy_older): Remove cast.
1609         (frapy_newer): Likewise.
1610         * python/py-breakpoint.c (local_setattro): Remove cast.
1611         * python/py-arch.c (archpy_name): Remove local variable.
1612         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1613
1614 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1615
1616         * unittests/basic_string_view/element_access/char/empty.cc:
1617         Fix year range in copyright header.
1618
1619 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1620
1621         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1622         Delete.
1623         <operator==>: Update with for removed field.
1624         <hash>: Likewise.
1625         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1626         <isa_features>: ...this.
1627         <abi_features>: New field.
1628         (riscv_isa_flen): Update comment.
1629         (riscv_abi_xlen): New declaration.
1630         (riscv_abi_flen): New declaration.
1631         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1632         isa_features.
1633         (riscv_abi_xlen): New function.
1634         (riscv_isa_flen): Update to get answer from isa_features.
1635         (riscv_abi_flen): New function.
1636         (riscv_has_fp_abi): Update to get answer from abi_features.
1637         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1638         xlen and flen.
1639         (riscv_call_info) <xlen, flen>: Update comment.
1640         (riscv_call_arg_struct): Remove invalid assertions
1641         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1642         is removed.
1643         (riscv_gdbarch_init): Gather isa features and abi features
1644         separately, ensure both match on the gdbarch when reusing an old
1645         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1646         a target with 64-bit float hardware.
1647
1648 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1649
1650         * source.c (search_command_helper): Stop reverse search
1651         when line 1 has been searched.
1652
1653 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1654
1655         * record-full.c (record_full_base_target::close): Rewrite
1656         record_full_core_buf_list free logic.
1657
1658 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1659
1660         * break-catch-syscall.c (print_one_catch_syscall): xfree
1661         the last text.
1662
1663 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1664
1665         * top.c (print_gdb_version): Update Copyright year in version
1666         message.
1667
1668 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1669
1670         Update copyright year range in all GDB files.
1671
1672 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1673
1674         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1675
1676 For older changes see ChangeLog-2018.
1677 \f
1678 Local Variables:
1679 mode: change-log
1680 left-margin: 8
1681 fill-column: 74
1682 version-control: never
1683 coding: utf-8
1684 End:
1685