gdb/ChangeLog

   1 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
   2
   3         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
   4
   5 2018-05-22  Pedro Alves  <palves@redhat.com>
   6
   7         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
   8         (remote_fileio_badfd, remote_fileio_return_errno)
   9         (remote_fileio_return_success, remote_fileio_func_open)
  10         (remote_fileio_func_open, remote_fileio_func_close)
  11         (remote_fileio_func_read, remote_fileio_func_write)
  12         (remote_fileio_func_lseek, remote_fileio_func_rename)
  13         (remote_fileio_func_unlink, remote_fileio_func_stat)
  14         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
  15         (remote_fileio_func_isatty, remote_fileio_func_system): Add
  16         remote_target parameter.
  17         (remote_fio_func_map) <func>: Add remote_target parameter.
  18         (do_remote_fileio_request, remote_fileio_request):
  19         * remote-fileio.h (remote_fileio_request):
  20         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
  21         remote_target parameter.
  22         (remote_notif_process, handle_notification): Adjust to pass down
  23         the remote.
  24         (remote_notif_state_allocate): Add remote_target parameter.  Save
  25         it.
  26         * remote-notif.h (struct remote_target): Forward declare.
  27         (struct notif_client) <parse, ack, can_get_pending_events>: Add
  28         remote_target parameter.
  29         (struct remote_notif_state) <remote>: New field.
  30         (remote_notif_ack, remote_notif_parse): Add remote_target
  31         parameter.
  32         (remote_notif_state_allocate, remote_notif_state_allocate): Add
  33         remote_target parameter.
  34         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
  35         (threads_listing_context, rmt_thread_action, protocol_feature)
  36         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
  37         (packet_result, struct threads_listing_context, remote_state):
  38         Move definitions and declarations higher up.
  39         (remote_target) <~remote_target>: Declare.
  40         (remote_download_command_source, remote_file_put, remote_file_get)
  41         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
  42         (remote_hostio_pread_vFile, remote_hostio_send_command)
  43         (remote_hostio_set_filesystem, remote_hostio_open)
  44         (remote_hostio_close, remote_hostio_unlink, remote_state)
  45         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
  46         (get_memory_write_packet_size, get_memory_read_packet_size)
  47         (append_pending_thread_resumptions, remote_detach_1)
  48         (append_resumption, remote_resume_with_vcont)
  49         (add_current_inferior_and_thread, wait_ns, wait_as)
  50         (process_stop_reply, remote_notice_new_inferior)
  51         (process_initial_stop_replies, remote_add_thread)
  52         (btrace_sync_conf, remote_btrace_maybe_reopen)
  53         (remove_new_fork_children, kill_new_fork_children)
  54         (discard_pending_stop_replies, stop_reply_queue_length)
  55         (check_pending_events_prevent_wildcard_vcont)
  56         (discard_pending_stop_replies_in_queue, stop_reply)
  57         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
  58         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
  59         (remote_interrupt_as, remote_interrupt_ns)
  60         (remote_get_noisy_reply, remote_query_attached)
  61         (remote_add_inferior, remote_current_thread, get_current_thread)
  62         (set_thread, set_general_thread, set_continue_thread)
  63         (set_general_process, write_ptid)
  64         (remote_unpack_thread_info_response, remote_get_threadinfo)
  65         (parse_threadlist_response, remote_get_threadlist)
  66         (remote_threadlist_iterator, remote_get_threads_with_ql)
  67         (remote_get_threads_with_qxfer)
  68         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
  69         (get_offsets, remote_check_symbols, remote_supported_packet)
  70         (remote_query_supported, remote_packet_size)
  71         (remote_serial_quit_handler, remote_detach_pid)
  72         (remote_vcont_probe, remote_resume_with_hc)
  73         (send_interrupt_sequence, interrupt_query)
  74         (remote_notif_get_pending_events, fetch_register_using_p)
  75         (send_g_packet, process_g_packet, fetch_registers_using_g)
  76         (store_register_using_P, store_registers_using_G)
  77         (set_remote_traceframe, check_binary_download)
  78         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
  79         (remote_xfer_live_readonly_partial, remote_read_bytes)
  80         (remote_send_printf, remote_flash_write, readchar)
  81         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
  82         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
  83         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
  84         (extended_remote_disable_randomization, extended_remote_run)
  85         (send_environment_packet, extended_remote_environment_support)
  86         (extended_remote_set_inferior_cwd, remote_write_qxfer)
  87         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
  88         (packet_command): Now methods of ...
  89         (remote_target): ... this class.
  90         (m_remote_state) <remote_target>: New field.
  91         (struct remote_state) <stop_reply_queue,
  92         remote_async_inferior_event_token, wait_forever_enabled_p>: New
  93         fields.
  94         (remote_state::remote_state): Allocate stop_reply_queue.
  95         (remote_state): Delete global.
  96         (get_remote_state_raw): Delete.
  97         (remote_target::get_remote_state): Allocate m_remote_state on
  98         demand.
  99         (get_current_remote_target): New.
 100         (remote_ops, extended_remote_ops): Delete.
 101         (wait_forever_enabled_p, remote_async_inferior_event_token):
 102         Delete, moved to struct remote_state.
 103         (remote_target::close): Delete self.  Destruction bits split to
 104         ...
 105         (remote_target::~remote_target): ... this.
 106         (show_memory_packet_size): Adjust to use
 107         get_current_remote_target.
 108         (struct protocol_feature) <func>: Add remote_target parameter.
 109         All callers adjusted.
 110         (curr_quit_handler_target): New.
 111         (remote_serial_quit_handler): Reimplement.
 112         (remote_target::open_1): Adjust to use get_current_remote_target.
 113         Heap-allocate remote_target/extended_remote_target instances.
 114         (vcont_builder::vcont_builder): Add remote_target parameter, and
 115         save it in m_remote.  All callers adjusted.
 116         (vcont_builder::m_remote): New field.
 117         (vcont_builder::restart, vcont_builder::flush)
 118         (vcont_builder::push_action): Use it.
 119         (remote_target::commit_resume): Use it.
 120         (struct queue_iter_param) <remote>: New field.
 121         (remote_target::remove_new_fork_children): Fill in 'remote' field.
 122         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
 123         (check_pending_event_prevents_wildcard_vcont_callback)
 124         (remote_target::check_pending_events_prevent_wildcard_vcont)
 125         (remote_target::discard_pending_stop_replies)
 126         (remote_target::discard_pending_stop_replies_in_queue)
 127         (remote_target::remote_notif_remove_queued_reply): Fill in
 128         'remote' field.
 129         (remote_notif_get_pending_events): New.
 130         (remote_target::readchar, remote_target::remote_serial_write):
 131         Save/restore curr_quit_handler_target.
 132         (putpkt): New.
 133         (kill_new_fork_children): Fill in 'remote' field.
 134         (packet_command): Use get_current_remote_target, defer to
 135         remote_target method of same name.
 136         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
 137         parameter, and save it in m_remote.  All callers adjusted.
 138         (scoped_remote_fd::release): Use m_remote.
 139         (scoped_remote_fd::m_remote): New field.
 140         (remote_file_put, remote_file_get, remote_file_delete): Use
 141         get_current_remote_target, defer to remote_target method of same
 142         name.
 143         (remote_btrace_reset): Add remote_state paremeter.  Update all
 144         callers.
 145         (remote_async_inferior_event_handler). Pass down 'data'.
 146         (remote_new_objfile): Use get_current_remote_target.
 147         (remote_target::vcont_r_supported): New.
 148         (set_range_stepping): Use get_current_remote_target and
 149         remote_target::vcont_r_supported.
 150         (_initialize_remote): Don't allocate 'remote_state' and
 151         'stop_reply_queue' globals.
 152         * remote.h (struct remote_target): Forward declare.
 153         (getpkt, putpkt, remote_notif_get_pending_events): Add
 154         'remote_target' parameter.
 155
 156 2018-05-22  Pedro Alves  <palves@redhat.com>
 157
 158         * remote.c (vcont_builder): Now a class.  Make all data members
 159         private.
 160         (vcont_builder) <vcont_builder, restart, flush, push_action>:
 161         Declare methods.
 162         (vcont_builder_restart): Rename to ...
 163         (vcont_builder::restart): ... this.
 164         (vcont_builder_flush): Rename to ...
 165         (vcont_builder::flush): ... this.
 166         (vcont_builder_push_action): Rename to ...
 167         (vcont_builder::push_action): ... this.
 168         (remote_target::commit_resume): Adjust.
 169
 170 2018-05-22  Pedro Alves  <palves@redhat.com>
 171
 172         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
 173         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
 174         (get_fixed_memory_packet_size): New.
 175         (get_memory_packet_size): Use it.
 176         (set_memory_packet_size): Don't override the config size with
 177         DEFAULT_MAX_MEMORY_PACKET_SIZE.
 178         (show_memory_packet_size): Use get_fixed_memory_packet_size.
 179         Don't refer to get_memory_packet_size if not connected to a remote
 180         target.  Show "(default)" if configured size is 0.
 181
 182 2018-05-22  Pedro Alves  <palves@redhat.com>
 183
 184         * remote.c (remote_target::mourn_inferior): Move
 185         discard_pending_stop_replies call here from ...
 186         (_initialize_remote): ... here.
 187
 188 2018-05-22  Pedro Alves  <palves@redhat.com>
 189
 190         * remote.c (compare_section_command): Remove set_general_process
 191         call.
 192
 193 2018-05-22  Pedro Alves  <palves@redhat.com>
 194
 195         * remote.c (struct packet_reg, struct remote_arch_state):
 196         Move higher up in the file.
 197         (remote_state) <m_arch_states>: Store remote_arch_state values
 198         instead of remote_arch_state pointers.
 199         (remote_state::get_remote_arch_state): Adjust.
 200
 201 2018-05-22  Pedro Alves  <palves@redhat.com>
 202
 203         * remote.c: Include <unordered_map>.
 204         (remote_state): Now a class.
 205         (remote_state) <get_remote_arch_state>: Declare method.
 206         <get_remote_arch_state>: New field.
 207         (remote_arch_state) <remote_arch_state>: Declare ctor.
 208         <regs>: Now a unique_ptr.
 209         (remote_gdbarch_data_handle): Delete.
 210         (get_remote_arch_state): Delete.
 211         (remote_state::get_remote_arch_state): New.
 212         (get_remote_state): Adjust to call remote_state's
 213         get_remote_arch_state method.
 214         (init_remote_state): Delete, bits factored out to ...
 215         (remote_arch_state::remote_arch_state): ... this new method.
 216         (get_remote_packet_size, get_memory_packet_size)
 217         (process_g_packet, remote_target::fetch_registers)
 218         (remote_target::prepare_to_store, store_registers_using_G)
 219         (remote_target::store_registers, remote_target::get_trace_status):
 220         Adjust to call remote_state's method.
 221         (_initialize_remote): Remove reference to
 222         remote_gdbarch_data_handle.
 223
 224 2018-05-22  Pedro Alves  <palves@redhat.com>
 225
 226         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
 227         pread>: New method declarations.
 228         (remote_target::open_1): Adjust.
 229         (readahead_cache_invalidate): Rename to ...
 230         (readahead_cache::invalidate): ... this, and adjust to be a class
 231         method.
 232         (readahead_cache_invalidate_fd): Rename to ...
 233         (readahead_cache::invalidate_fd): ... this, and adjust to be a
 234         class method.
 235         (remote_hostio_pwrite): Adjust.
 236         (remote_hostio_pread_from_cache): Rename to ...
 237         (readahead_cache::pread): ... this, and adjust to be a class
 238         method.
 239         (remote_hostio_close): Adjust.
 240
 241 2018-05-22  Pedro Alves  <palves@redhat.com>
 242
 243         * remote.c (remote_hostio_close_cleanup): Delete.
 244         (class scoped_remote_fd): New.
 245         (remote_file_put, remote_file_get): Use it.
 246
 247 2018-05-22  Pedro Alves  <palves@redhat.com>
 248
 249         (struct vCont_action_support): Use bool and initialize all fields.
 250         (struct readahead_cache): Initialize all fields.
 251         (remote_state): Use bool and initialize all fields.
 252         (remote_state::remote_state, remote_state::~remote_state): New.
 253         (new_remote_state): Delete.
 254         (_initialize_remote): Use new to allocate remote_state.
 255
 256 2018-05-22  Pedro Alves  <palves@redhat.com>
 257             張俊芝  <zjz@zjz.name>
 258
 259         PR gdb/22973
 260         * c-exp.y: Include "c-support.h".
 261         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
 262         of tolower.  Use c_ident_is_alpha to scan names.
 263         * c-lang.c: Include "c-support.h".
 264         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
 265         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
 266         * c-support.h: New file, with bits factored out from ...
 267         * cp-name-parser.y: ... this file.
 268         Include "c-support.h".
 269         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
 270         c-support.h and renamed.
 271         (symbol_end, yylex): Adjust.
 272
 273 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 274
 275         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
 276         parameter type to CORE_ADDR.
 277         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
 278         parameter type in declaration to CORE_ADDR.
 279         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
 280         target_auxv_search to get AT_HWCAP and use the result to get the
 281         target description.
 282         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
 283         to CORE_ADDR. Remove the cast of the return value to unsigned
 284         long. Fix error predicate of target_auxv_search.
 285         (ppc_linux_nat_target::read_description): Change the type of the
 286         hwcap variable to CORE_ADDR.
 287
 288 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 289
 290         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
 291         if the size of fpscr is larger than 32 bits.
 292
 293 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 294
 295         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
 296         (ppc32_linux_vsxregmap): New global.
 297         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
 298         regcache_supply_regset, and regcache_collect_regset.
 299         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
 300         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
 301         (fetch_vsx_register, store_vsx_register): Remove.
 302         (fetch_vsx_registers): Add regno parameter. Get regset using
 303         ppc_linux_vsxregset. Use regset to supply registers.
 304         (store_vsx_registers): Add regno parameter. Get regset using
 305         ppc_linux_vsxregset. Use regset to collect registers.
 306         (fetch_register): Call fetch_vsx_registers instead of
 307         fetch_vsx_register.
 308         (store_register): Call store_vsx_registers instead of
 309         store_vsx_register.
 310         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
 311         new regno parameter.
 312         (store_ppc_registers): Call store_vsx_registers with -1 for the
 313         new regno parameter.
 314         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
 315         (ppc_collect_vsxregset): Remove.
 316
 317 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 318
 319         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
 320         offset fields.
 321         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
 322         for vector register offset fields.
 323         (ppc64_fbsd_reg_offsets): Likewise.
 324         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
 325         to vector register offset fields.
 326         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
 327         to vector register offset fields.
 328         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
 329         vector register offset fields.
 330         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
 331         initializers for vector register offset fields.
 332         (rs6000_aix64_reg_offsets): Likewise.
 333         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
 334         (ppc_supply_vrregset): Remove.
 335         (ppc_collect_vrregset): Remove.
 336         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
 337         (ppc_linux_vrregset) : New function.
 338         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
 339         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
 340         (ppc32_linux_vrregset): Remove.
 341         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
 342         and use result instead of ppc32_linux_vrregset.
 343         (ppc32_linux_reg_offsets): Remove initializers for vector register
 344         offset fields.
 345         (ppc64_linux_reg_offsets): Likewise.
 346         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
 347         * ppc-linux-nat.c: Include regset.h.
 348         (gdb_vrregset_t): Adjust comment to account for little-endian
 349         mode.
 350         (supply_vrregset, fill_vrregset): Remove.
 351         (fetch_altivec_register, store_altivec_register): Remove.
 352         (fetch_altivec_registers): Add regno parameter. Get regset using
 353         ppc_linux_vrregset. Use regset to supply registers.
 354         (store_altivec_registers): Add regno parameter. Get regset using
 355         ppc_linux_vrregset. Use regset to collect registers.
 356         (fetch_register): Call fetch_altivec_registers instead of
 357         fetch_altivec_register.
 358         (store_register): Call store_altivec_registers instead of
 359         store_altivec_register.
 360         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
 361         the new regno parameter.
 362         (store_ppc_registers): Call store_altivec_registers with -1 for
 363         the new regno parameter.
 364
 365 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 366
 367         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
 368         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
 369         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
 370         (gdb_vrregset_t): Change array type size to
 371         PPC_LINUX_SIZEOF_VRREGSET.
 372         (gdb_vsxregset_t): Change array type size to
 373         PPC_LINUX_SIZEOF_VSXREGSET.
 374         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
 375         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
 376         PPC_LINUX_SIZEOF_VSXREGSET.
 377
 378 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 379
 380         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
 381         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
 382         nat/ppc-linux.c.
 383         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
 384         ppc_linux_target_wordsize with tid.
 385         (ppc_linux_nat_target::read_description): Call ppc_linux_target
 386         wordsize with tid.
 387         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
 388         (ppc64_64bit_inferior_p): Add static and inline specifiers.
 389         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
 390         tid parameter. Remove static specifier.
 391         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
 392         (ppc_linux_target_wordsize): New declaration.
 393
 394 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 395
 396         * arch/ppc-linux-common.c: New file.
 397         * arch/ppc-linux-common.h: New file.
 398         * arch/ppc-linux-tdesc.h: New file.
 399         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
 400         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
 401         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
 402         arch/ppc-linux-tdesc.h.
 403         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
 404         arch/ppc-linux-tdesc.h.
 405         (ppc_linux_nat_target::read_description): Remove target
 406         description matching code. Fill a ppc_linux_features struct and
 407         call ppc_linux_match_description with it. Move comment about ISA
 408         2.05 to ppc-linux-common.c.
 409         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
 410         arch/ppc-linux-tdesc.h.
 411         (ppc_linux_core_read_description): Remove target description
 412         matching code. Fill a ppc_linux_features struct and call
 413         ppc_linux_match_description with it.
 414         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
 415         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
 416         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
 417         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
 418         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
 419         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
 420         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
 421         (tdesc_powerpc_e500l): Remove.
 422
 423 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
 424
 425         * ada-lang.c (catch_assert_command): Pass empty string instead
 426         of NULL for excep_string argument.
 427
 428 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
 429
 430         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
 431         the width of the requested register exceeds the width of the
 432         `ptrace' data type.
 433
 434 2018-05-21  Tom Tromey  <tom@tromey.com>
 435
 436         * printcmd.c (output_command): Remove.
 437         (output_command_const): Rename to output_command.
 438         * valprint.h (output_command): Rename from output_command_const.
 439         * tracepoint.c (trace_dump_actions): Call output_command.
 440
 441 2018-05-21  Tom Tromey  <tom@tromey.com>
 442
 443         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
 444         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
 445         * ada-lang.h (create_ada_exception_catchpoint): Update.
 446         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
 447         std::string.
 448         (create_excep_cond_exprs, ~ada_catchpoint)
 449         (should_stop_exception, print_one_exception)
 450         (print_mention_exception, print_recreate_exception): Update.
 451         (ada_get_next_arg): Remove.
 452         (catch_ada_exception_command_split): Use std::string.  Change type
 453         of "excep_string", "cond_string".
 454         (catch_ada_exception_command): Update.
 455         (create_ada_exception_catchpoint): Change type of excep_string.
 456         (ada_exception_sal): Remove excep_string parameter.
 457         (~ada_catchpoint): Remove.
 458
 459 2018-05-21  Tom Tromey  <tom@tromey.com>
 460
 461         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
 462         cleanup.
 463
 464 2018-05-21  Tom Tromey  <tom@tromey.com>
 465
 466         * ada-lang.c (ada_exception_message_1, ada_exception_message):
 467         Return unique_xmalloc_ptr.
 468         (print_it_exception): Update.
 469
 470 2018-05-21  Tom Tromey  <tom@tromey.com>
 471
 472         * tracepoint.c (trace_dump_actions): Use std::string.
 473
 474 2018-05-21  Tom Tromey  <tom@tromey.com>
 475
 476         * symfile.c (reread_symbols): Use std::string for original_name.
 477
 478 2018-05-21  Tom Tromey  <tom@tromey.com>
 479
 480         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
 481         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
 482         constructor.
 483
 484 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
 485
 486         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
 487         instance to...
 488         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
 489         * objfiles.c (get_objfile_bfd_data): Allocate
 490         objfile_per_bfd_storage with obstack_new when allocating on
 491         obstack.
 492
 493 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
 494
 495         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
 496         OBSTACK_ZALLOC.
 497         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
 498         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
 499         * mdebugread.c (mdebug_build_psymtabs): Likewise.
 500         (add_pending): Likewise.
 501         (parse_symbol): Likewise.
 502         (parse_partial_symbols): Likewise.
 503         (psymtab_to_symtab_1): Likewise.
 504         (new_psymtab): Likewise.
 505         (elfmdebug_build_psymtabs): Likewise.
 506         * minsyms.c (terminate_minimal_symbol_table): Likewise.
 507         * objfiles.c (get_objfile_bfd_data): Likewise.
 508         (objfile_register_static_link): Likewise.
 509         * psymtab.c (allocate_psymtab): Likewise.
 510         * stabsread.c (read_member_functions): Likewise.
 511         * xcoffread.c (xcoff_end_psymtab): Likewise.
 512
 513 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
 514
 515         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
 516         compiler supports std::is_trivially_constructible.
 517         * common/poison.h: Include obstack.h.
 518         (IsMallocable): Define to is_trivially_constructible if the
 519         compiler supports it, define to true_type otherwise.
 520         (xobnew): New.
 521         (XOBNEW): Redefine.
 522         (xobnewvec): New.
 523         (XOBNEWVEC): Redefine.
 524         * gdb_obstack.h (obstack_zalloc): New.
 525         (OBSTACK_ZALLOC): Redefine.
 526         (obstack_calloc): New.
 527         (OBSTACK_CALLOC): Redefine.
 528         (obstack_new): New.
 529         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
 530         (gdbarch_obstack): New declaration in gdbarch.h, definition in
 531         gdbarch.c.
 532         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
 533         obstack_calloc/obstack_zalloc.
 534         (gdbarch_obstack_zalloc): Remove.
 535         * target-descriptions.c (tdesc_data_init): Use obstack_new.
 536
 537 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 538
 539         * stack.c (backtrace_command_1): Remove useless variable int i.
 540
 541 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 542
 543         * stack.c (print_frame_info): Fix comment.
 544
 545 2018-05-18  Tom Tromey  <tom@tromey.com>
 546
 547         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
 548         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
 549         (~dwarf2_per_objfile): Update
 550         (dwarf2_get_dwz_file): Use new.
 551         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
 552         unique_ptr.
 553
 554 2018-05-18  Tom Tromey  <tom@tromey.com>
 555
 556         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
 557         unique_ptr.
 558         * dwarf2read.c (struct dwp_file): Add constructor and
 559         initializers.
 560         (open_and_init_dwp_file): Return a unique_ptr.
 561         (dwarf2_per_objfile, create_dwp_hash_table)
 562         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
 563         (lookup_dwo_unit_in_dwp): Update.
 564         (open_and_init_dwp_file, get_dwp_file): Update.
 565
 566 2018-05-18  Tom Tromey  <tom@tromey.com>
 567
 568         * dwarf2read.c (dwarf2_per_objfile): Update.
 569         (struct mapped_index): Add initializers.
 570         (dwarf2_read_index): Use new.
 571         (dw2_symtab_iter_init): Update.
 572         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
 573         unique_ptr.
 574
 575 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
 576
 577         * dwarf2read.c (mapped_index) <total_size>: Remove.
 578
 579 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
 580
 581         * unittests/format_pieces-selftests.c (test_format_specifier):
 582         Add ARI comments.
 583
 584 2018-05-18  Tom Tromey  <tom@tromey.com>
 585
 586         * c-typeprint.c (maybe_print_hole): New function.
 587         (c_print_type_struct_field_offset): Update.
 588         (c_type_print_base_struct_union): Call maybe_print_hole.
 589
 590 2018-05-17  Keith Seitz  <keiths@redhat.com>
 591
 592         * breakpoint.c (build_bpstat_chain): New function, moved from
 593         bpstat_stop_status.
 594         (bpstat_stop_status): Add optional parameter, `stop_chain'.
 595         If no stop chain is passed, call build_bpstat_chain to build it.
 596         * breakpoint.h (build_bpstat_chain): Declare.
 597         (bpstat_stop_status): Move documentation here from breakpoint.c.
 598         * infrun.c (handle_signal_stop): Before eliding inlined frames,
 599         build the stop chain and pass it to skip_inline_frames.
 600         Pass this stop chain to bpstat_stop_status.
 601         * inline-frame.c: Include breakpoint.h.
 602         (stopped_by_user_bp_inline_frame): New function.
 603         (skip_inline_frames): Add parameter `stop_chain'.
 604         Move documention to inline-frame.h.
 605         If non-NULL, use stopped_by_user_bp_inline_frame to determine
 606         whether the frame should be elided.
 607         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
 608         Add moved documentation and update for new parameter.
 609
 610 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
 611
 612         PR cli/14975
 613         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 614         unittests/format_pieces-selftests.c.
 615         * common/format.h (format_piece) <operator==>: New.
 616         (format_pieces) <operator[]>: Remove.
 617         * common/format.c (format_pieces::format_pieces): Handle \e.
 618         * unittests/format_pieces-selftests.c: New.
 619
 620 2018-05-17  Tom Tromey  <tom@tromey.com>
 621
 622         PR symtab/23010:
 623         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
 624         (dw2_instantiate_symtab): Add skip_partial parameter.
 625         (dw2_find_last_source_symtab, dw2_map_expand_apply)
 626         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
 627         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
 628         (dw2_expand_symtabs_matching_one)
 629         (dw2_find_pc_sect_compunit_symtab)
 630         (dw2_debug_names_lookup_symbol)
 631         (dw2_debug_names_expand_symtabs_for_function): Update.
 632         (init_cutu_and_read_dies): Add skip_partial parameter.
 633         (process_psymtab_comp_unit, build_type_psymtabs_1)
 634         (process_skeletonless_type_unit, load_partial_comp_unit)
 635         (psymtab_to_symtab_1): Update.
 636         (load_full_comp_unit): Add skip_partial parameter.
 637         (process_imported_unit_die, dwarf2_read_addr_index)
 638         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
 639         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
 640         (read_signatured_type): Update.
 641
 642 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
 643
 644         * value.c (release_value): Remove unused variable.
 645         (record_latest_value): Likewise.
 646         (access_value_history): Likewise.
 647         (preserve_values): Likewise.
 648
 649 2018-05-17  Tom Tromey  <tom@tromey.com>
 650
 651         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
 652         Initialize.
 653
 654 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
 655
 656         PR gdb/22286
 657         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
 658         Also handle registers whose width is not a multiple of
 659         PTRACE_TYPE_RET.
 660         (linux_nat_trad_target::store_register): Likewise.
 661
 662 2018-05-16  Tom Tromey  <tom@tromey.com>
 663
 664         * gdbcore.h (core_bfd): Redefine.
 665         * corelow.c (core_target::close): Update.
 666         (core_target_open): Update.
 667         * progspace.h (struct program_space) <cbfd>: Now a
 668         gdb_bfd_ref_ptr.
 669
 670 2018-05-16  Tom Tromey  <tom@tromey.com>
 671
 672         PR cli/19551:
 673         * symfile-add-flags.h (enum symfile_add_flags)
 674         <SYMFILE_NOT_FILENAME>: New constant.
 675         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
 676         objfile name from BFD.
 677         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
 678         * minidebug.c (find_separate_debug_file_in_section): Put
 679         ".gnu_debugdata" into BFD's file name.
 680
 681 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
 682
 683         * regcache.c (regcache_read_ftype, regcache_write_ftype):
 684         Remove.
 685
 686 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
 687
 688         PR binutils/21446
 689         * aarch64-tdep.c (aarch64_analyze_prologue,
 690         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
 691         Indicate not interested in errors.
 692
 693 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
 694
 695         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
 696         Supply the MIPS_ZERO_REGNUM register.
 697
 698 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
 699
 700         * mips-tdep.c (mask_address_var): Make variable static.
 701
 702 2018-05-14  Tom Tromey  <tom@tromey.com>
 703
 704         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
 705
 706 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 707
 708         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
 709         FXSAVE_ADDR for the mxcsr register.
 710
 711 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
 712
 713         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
 714
 715 2018-05-11  Pedro Alves  <palves@redhat.com>
 716
 717         * corelow.c (core_target) <core_target>: No longer inline.
 718         Initialize m_core_gdbarch, m_core_vec and build the section table
 719         here.
 720         <~core_target>: New.
 721         <core_gdbarch, get_core_register_section>: New methods.
 722         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
 723         factored out from ...
 724         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
 725         (core_ops): Delete.
 726         (sniff_core_bfd): Add gdbarch parameter.
 727         (core_close): Delete, merged into ...
 728         (core_target::close): ... here.  Delete self.
 729         (core_close_cleanup): Delete.
 730         (core_target_open): Allocate a core_target on the heap.  Use a
 731         unique_ptr instead of a cleanup.  Bits moved into the core_target
 732         ctor.  Adjust to use core_target methods instead of globals.
 733         (get_core_register_section): Rename to ...
 734         (core_target::get_core_register_section): ... this and adjust.
 735         (struct get_core_registers_cb_data): New.
 736         (get_core_registers_cb): Use it.  Use bool.
 737         (core_target::fetch_registers, core_target::files_info)
 738         (core_target::xfer_partial, core_target::read_description)
 739         (core_target::pid_to, core_target::thread_name): Adjust to
 740         reference class fields instead of globals.
 741         * target.h (struct target_ops_deleter, target_ops_up): New.
 742
 743 2018-05-11  Pedro Alves  <palves@redhat.com>
 744
 745         * corefile.c (core_file_command): Move to corelow.c.
 746         * corelow.c (the_core_target): Delete.
 747         (core_file_command): Moved from corefile.c.  Check exec_bfd
 748         instead of the_core_target.  Use target_detach instead of calling
 749         into the_core_target directly.
 750         (maybe_say_no_core_file_now): New.
 751         (core_target::detach): Use it.
 752         (_initialize_corelow): Remove references to the_core_target.
 753         * gdbcore.h (the_core_target): Delete.
 754
 755 2018-05-11  Tom Tromey  <tromey@redhat.com>
 756             Pedro Alves  <palves@redhat.com>
 757
 758         * corefile.c (core_bfd): Remove.
 759         * gdbcore.h (core_bfd): Now a macro.
 760         * progspace.h (struct program_space) <cbfd>: New field.
 761
 762 2018-05-11  Tom Tromey  <tom@tromey.com>
 763
 764         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
 765         gdb::def_vector.
 766
 767 2018-05-10  Tom Tromey  <tom@tromey.com>
 768
 769         * configure: Rebuild.
 770         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
 771
 772 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
 773
 774         PR server/23158:
 775         * regformats/regdat.sh: Adjust script, following the addition
 776         of the new expedite_regs parameter to init_target_desc.
 777
 778 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
 779
 780         PR gdb/23127
 781         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
 782         set_gdbarch_significant_addr_bit.
 783         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
 784         set_gdbarch_significant_addr_bit.
 785         * utils.c (address_significant): Update to sign extend addr.
 786
 787 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
 788
 789         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
 790         (xtensa_linux_init_abi): Limit tdep->num_regs by
 791         tdep->num_nopriv_regs.
 792         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
 793         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
 794         not initialized.
 795
 796 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
 797
 798         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
 799
 800 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 801
 802         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
 803         (I387_MXCSR_INIT_VAL): New constant.
 804         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
 805         buffer if it was supplied by the inferior.
 806         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
 807         (i387_xsave_get_clear_bv): New function.
 808         (i387_supply_xsave): Only read x87 control registers from the
 809         xsave buffer if the feature is enabled, and the state will have
 810         been written, otherwise, provide a suitable default.
 811         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
 812         including x87 control registers.  Update control registers if they
 813         have changed from the default value, and mark features as enabled
 814         as required.
 815         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
 816
 817 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
 818
 819         * spu-tdep.c (info_spu_event_command): Fix output formatting.
 820
 821 2018-05-07  Tom Tromey  <tom@tromey.com>
 822
 823         * configure: Rebuild.
 824         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
 825
 826 2018-05-07  Tom Tromey  <tom@tromey.com>
 827
 828         PR tdep/20362:
 829         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
 830         bit.  Use correct value for VDIV.
 831
 832 2018-05-04  Tom Tromey  <tom@tromey.com>
 833
 834         * configure: Rebuild.
 835         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
 836
 837 2018-05-04  Tom Tromey  <tom@tromey.com>
 838
 839         * linux-record.c (record_linux_system_call) <case
 840         RECORD_SYS_RECVFROM>: Add "break".
 841
 842 2018-05-04  Tom Tromey  <tom@tromey.com>
 843
 844         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
 845         Add missing "break".
 846         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
 847         Add missing "break".
 848
 849 2018-05-04  Tom Tromey  <tom@tromey.com>
 850
 851         * rs6000-tdep.c (ppc_process_record_op4)
 852         (ppc_process_record_op63): Add fall-through comment.
 853
 854 2018-05-04  Tom Tromey  <tom@tromey.com>
 855
 856         * i386-tdep.c (i386_process_record): Add fall-through comment.
 857
 858 2018-05-04  Tom Tromey  <tom@tromey.com>
 859
 860         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
 861         comment.
 862
 863 2018-05-04  Tom Tromey  <tom@tromey.com>
 864
 865         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
 866         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
 867         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
 868         comment.
 869         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
 870         comment.
 871         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
 872         comment.
 873
 874 2018-05-04  Tom Tromey  <tom@tromey.com>
 875
 876         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
 877
 878 2018-05-04  Tom Tromey  <tom@tromey.com>
 879
 880         * s390-tdep.c (s390_process_record): Fix fall-through comments.
 881         * xcoffread.c (scan_xcoff_symtab): Move comment later.
 882         * symfile.c (section_is_mapped): Fix fall-through comment.
 883         * stabsread.c (define_symbol, read_member_functions): Fix
 884         fall-through comment.
 885         * s390-linux-tdep.c (s390_process_record): Fix fall-through
 886         comment.
 887         * remote.c (remote_wait_as): Fix fall-through comment.
 888         * p-exp.y (yylex): Fix fall-through comment.
 889         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
 890         comment.
 891         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
 892         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
 893         * jv-exp.y (yylex): Fix fall-through comment.
 894         * go-exp.y (lex_one_token): Fix fall-through comment.
 895         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
 896         fall-through comment.
 897         * f-exp.y (yylex): Fix fall-through comment.
 898         * dwarf2read.c (process_die): Fix fall-through comments.
 899         * dbxread.c (process_one_symbol): Fix fall-through comment.
 900         * d-exp.y (lex_one_token): Fix fall-through comment.
 901         * cp-name-parser.y (yylex): Fix fall-through comment.
 902         * coffread.c (coff_symtab_read): Fix fall-through comment.
 903         * c-exp.y (lex_one_token): Fix fall-through comment.
 904         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
 905         comment.
 906         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
 907         comment.
 908
 909 2018-05-04  Tom Tromey  <tom@tromey.com>
 910
 911         PR python/22730:
 912         * NEWS: Mention gdb.execute change.
 913         * gdbcmd.h (execute_control_command): Don't declare.
 914         * python/python.c (execute_gdb_command): Use read_command_lines_1,
 915         execute_control_commands, execute_control_commands_to_string.
 916         * cli/cli-script.h (execute_control_commands)
 917         (execute_control_commands_to_string): Declare.
 918         (execute_control_command): Add from_tty parameter.
 919         * cli/cli-script.c (execute_control_commands)
 920         (execute_control_commands_to_string): New functions.
 921         (execute_user_command): Use execute_control_commands.
 922         (execute_control_command_1): Add "from_tty" parameter.  Update.
 923         (execute_control_command): Likewise.
 924
 925 2018-05-04  Tom Tromey  <tom@tromey.com>
 926
 927         PR python/22731:
 928         * NEWS: Mention that breakpoint commands are writable.
 929         * python/py-breakpoint.c (bppy_set_commands): New function.
 930         (breakpoint_object_getset) <"commands">: Use it.
 931
 932 2018-05-04  Tom Tromey  <tom@tromey.com>
 933
 934         * tracepoint.c (actions_command): Update.
 935         * mi/mi-cmd-break.c (mi_command_line_array)
 936         (mi_command_line_array_cnt, mi_command_line_array_ptr)
 937         (mi_read_next_line): Remove.
 938         (mi_cmd_break_commands): Update.
 939         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
 940         function_view.
 941         * cli/cli-script.c (get_command_line): Update.
 942         (process_next_line): Use function_view.  Constify.
 943         (recurse_read_control_structure, read_command_lines)
 944         (read_command_lines_1): Change argument types to function_view.
 945         (do_define_command, document_command): Update.
 946         * breakpoint.h (check_tracepoint_command): Don't declare.
 947         * breakpoint.c (check_tracepoint_command): Remove.
 948         (commands_command_1, create_tracepoint_from_upload): Update.
 949
 950 2018-05-04  Tom Tromey  <tom@tromey.com>
 951
 952         PR gdb/11750:
 953         * cli/cli-script.h (enum command_control_type) <define_control>:
 954         New constant.
 955         * cli/cli-script.c (multi_line_command_p): Handle define_control.
 956         (build_command_line, execute_control_command_1)
 957         (process_next_line): Likewise.
 958         (do_define_command): New function, extracted from define_command.
 959         (define_command): Use it.
 960
 961 2018-05-04  Tom Tromey  <tom@tromey.com>
 962
 963         * tracepoint.c (actions_command): Update.
 964         * cli/cli-script.h (read_command_lines): Update.
 965         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
 966         (MAX_TMPBUF): Remove define.
 967         (define_command): Use string_printf.
 968         (document_command): Likewise.
 969         * breakpoint.c (commands_command_1): Update.
 970
 971 2018-05-04  Tom Tromey  <tom@tromey.com>
 972
 973         * top.c (execute_command): Update.
 974         * cli/cli-script.h (print_command_lines): Now varargs.
 975         * cli/cli-script.c (print_command_lines): Now varargs.
 976         (execute_control_command_1) <case while_control, case if_control>:
 977         Update.
 978
 979 2018-05-04  Tom Tromey  <tom@tromey.com>
 980
 981         * tracepoint.c (all_tracepoint_actions): Rename from
 982         all_tracepoint_actions_and_cleanup.  Change return type.
 983         (actions_command, encode_actions_1, encode_actions)
 984         (trace_dump_actions, tdump_command): Update.
 985         * remote.c (remote_download_command_source): Update.
 986         * python/python.c (gdbpy_eval_from_control_command)
 987         (python_command, python_interactive_command): Update.
 988         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
 989         * guile/guile.c (guile_command)
 990         (gdbscm_eval_from_control_command, guile_command): Update.
 991         * compile/compile.c (compile_code_command)
 992         (compile_print_command, compile_to_object): Update.
 993         * cli/cli-script.h (struct command_lines_deleter): New.
 994         (counted_command_line): New typedef.
 995         (struct command_line): Add constructor, destructor.
 996         <body_list>: Remove.
 997         <body_list_0, body_list_1>: New members.
 998         (command_line_up): Remove typedef.
 999         (read_command_lines, read_command_lines_1, get_command_line):
1000         Update.
1001         (copy_command_lines): Don't declare.
1002         * cli/cli-script.c (build_command_line): Use "new".
1003         (get_command_line): Return counted_command_line.
1004         (print_command_lines, execute_user_command)
1005         (execute_control_command_1, while_command, if_command): Update.
1006         (realloc_body_list): Remove.
1007         (process_next_line, recurse_read_control_structure): Update.
1008         (read_command_lines, read_command_lines_1): Return counted_command_line.
1009         (free_command_lines): Use "delete".
1010         (copy_command_lines): Remove.
1011         (define_command, document_command, show_user_1): Update.
1012         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
1013         a counted_command_line.
1014         * breakpoint.h (counted_command_line): Remove typedef.
1015         (breakpoint_set_commands): Update.
1016         * breakpoint.c (check_no_tracepoint_commands)
1017         (validate_commands_for_breakpoint): Update.
1018         (breakpoint_set_commands): Change commands to be a
1019         counted_command_line.
1020         (commands_command_1, update_dprintf_command_list)
1021         (create_tracepoint_from_upload): Update.
1022
1023 2018-05-04  Tom Tromey  <tom@tromey.com>
1024
1025         * cli/cli-decode.h (cmd_list_element): New constructor.
1026         (~cmd_list_element): New destructor.
1027         (struct cmd_list_element): Add initializers.
1028         * cli/cli-decode.c (do_add_cmd): Use "new".
1029         (delete_cmd): Use "delete".
1030
1031 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
1032             Pedro Alves <palves@redhat.com>
1033
1034         PR breakpoints/19806 and support for PR external/20207.
1035         * NEWS: Mention Aarch64 watchpoint improvements.
1036         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
1037         watchpoints and PR external/20207 watchpoints.
1038         * nat/aarch64-linux-hw-point.c
1039         (kernel_supports_any_contiguous_range): New.
1040         (aarch64_watchpoint_offset): New.
1041         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
1042         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
1043         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
1044         (aarch64_align_watchpoint): New parameters aligned_offset_p and
1045         next_addr_orig_p.  Support PR external/20207 watchpoints.
1046         (aarch64_downgrade_regs): New.
1047         (aarch64_dr_state_insert_one_point): New parameters offset and
1048         addr_orig.
1049         (aarch64_dr_state_remove_one_point): Likewise.
1050         (aarch64_handle_breakpoint): Update caller.
1051         (aarch64_handle_aligned_watchpoint): Likewise.
1052         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
1053         aligned_offset.
1054         (aarch64_linux_set_debug_regs): Remove const from state.  Call
1055         aarch64_downgrade_regs.
1056         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
1057         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
1058         (DR_CONTROL_MASK): ... this.
1059         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
1060         (unsigned int aarch64_watchpoint_offset): New prototype.
1061         (aarch64_linux_set_debug_regs): Remove const from state.
1062         * utils.c (align_up, align_down): Move to ...
1063         * common/common-utils.c (align_up, align_down): ... here.
1064         * utils.h (align_up, align_down): Move to ...
1065         * common/common-utils.h (align_up, align_down): ... here.
1066
1067 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
1068
1069         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
1070         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
1071         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
1072         Re-implement to match the ABI as summarized in GCC's
1073         gcc/config/sparc/sparc.c.  All callers updated.
1074         (sparc32_store_arguments): Remove assertion.
1075
1076 2018-05-04  Tom Tromey  <tom@tromey.com>
1077
1078         * printcmd.c: Don't include tui.h.
1079         (decode_format): Use skip_spaces.
1080
1081 2018-05-04  Tom Tromey  <tom@tromey.com>
1082
1083         PR gdb/22619:
1084         * printcmd.c (last_count): New global.
1085         (x_command): Use saved count when repeating.
1086
1087 2018-05-04  Tom Tromey  <tom@tromey.com>
1088
1089         * nto-procfs.c (do_closedir_cleanup): Remove.
1090         (procfs_pidlist): Use gdb_dir_up.
1091         * procfs.c (do_closedir_cleanup): Remove.
1092         (proc_update_threads): Use gdb_dir_up.
1093         * common/filestuff.h (struct gdb_dir_deleter): New.
1094         (gdb_dir_up): New typedef.
1095
1096 2018-05-04  Tom Tromey  <tom@tromey.com>
1097
1098         * ada-lang.c (print_mention_exception): Use std::string.
1099
1100 2018-05-04  Tom Tromey  <tom@tromey.com>
1101
1102         * ada-lang.c (create_excep_cond_exprs): Update.
1103         (ada_exception_catchpoint_cond_string): Use std::string.
1104
1105 2018-05-04  Tom Tromey  <tom@tromey.com>
1106
1107         * ada-lang.c (xget_renaming_scope): Return std::string.
1108         (old_renaming_is_invisible): Update.
1109
1110 2018-05-04  Tom Tromey  <tom@tromey.com>
1111
1112         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
1113         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
1114
1115 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
1116
1117         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
1118
1119 2018-05-04  Tom Tromey  <tom@tromey.com>
1120
1121         * remote.c (remote_query_supported_append): Change type.
1122         (remote_check_symbols): Update.
1123
1124 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
1125
1126         PR gdb/11420
1127         * configure.ac: Prepend libpython.
1128         * python/python-config.py: Likewise.
1129         * configure: Regenerate.
1130
1131 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
1132
1133         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
1134
1135 2018-05-03  Pedro Alves  <palves@redhat.com>
1136
1137         * s390-linux-nat.c
1138         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
1139         override.  Write 'true' instead of '1'.
1140         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
1141         declaration.
1142
1143 2018-05-02  Pedro Alves  <palves@redhat.com>
1144
1145         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
1146         add_inf_child_target.
1147         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
1148         add_inf_child_target.
1149         * aix-thread.c (aix_thread_target_info): New.
1150         (aix_thread_target) <shortname, longname, doc>: Delete.
1151         <info>: New.
1152         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
1153         add_inf_child_target.
1154         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
1155         add_inf_child_target.
1156         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
1157         add_inf_child_target.
1158         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
1159         add_inf_child_target.
1160         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
1161         add_inf_child_target.
1162         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
1163         add_inf_child_target.
1164         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
1165         add_inf_child_target.
1166         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
1167         add_inf_child_target.
1168         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
1169         add_inf_child_target.
1170         * bfd-target.c (target_bfd_target_info): New.
1171         (target_bfd) <shortname, longname, doc>: Delete.
1172         <info>: New.
1173         * bsd-kvm.c (bsd_kvm_target_info): New.
1174         (bsd_kvm_target) <shortname, longname, doc>: Delete.
1175         <info>: New.
1176         (bsd_kvm_target::open): Rename to ...
1177         (bsd_kvm_target_open): ... this.  Adjust.
1178         * bsd-uthread.c (bsd_uthread_target_info): New.
1179         (bsd_uthread_target) <shortname, longname, doc>: Delete.
1180         <info>: New.
1181         * corefile.c (core_file_command): Adjust.
1182         * corelow.c (core_target_info): New.
1183         (core_target) <shortname, longname, doc>: Delete.
1184         <info>: New.
1185         (core_target::open): Rename to ...
1186         (core_target_open): ... this.  Adjust.
1187         * ctf.c (ctf_target_info): New.
1188         (ctf_target) <shortname, longname, doc>: Delete.
1189         <info>: New.
1190         (ctf_target::open): Rename to ...
1191         (ctf_target_open): ... this.
1192         (_initialize_ctf): Adjust.
1193         * exec.c (exec_target_info): New.
1194         (exec_target) <shortname, longname, doc>: Delete.
1195         <info>: New.
1196         (exec_target::open): Rename to ...
1197         (exec_target_open): ... this.
1198         * gdbcore.h (core_target_open): Declare.
1199         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
1200         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
1201         add_inf_child_target.
1202         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
1203         add_inf_child_target.
1204         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
1205         add_inf_child_target.
1206         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
1207         add_inf_child_target.
1208         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
1209         add_inf_child_target.
1210         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
1211         add_inf_child_target.
1212         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
1213         add_inf_child_target.
1214         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
1215         add_inf_child_target.
1216         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
1217         add_inf_child_target.
1218         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
1219         add_inf_child_target.
1220         * inf-child.c (inf_child_target_info): New.
1221         (inf_child_target::info): New.
1222         (inf_child_open_target): Remove 'target' parameter.  Use
1223         get_native_target instead.
1224         (inf_child_target::open): Delete.
1225         (add_inf_child_target): New.
1226         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
1227         Delete.
1228         <info>: New.
1229         (add_inf_child_target): Declare.
1230         (inf_child_open_target): Declare.
1231         * linux-thread-db.c (thread_db_target_info): New.
1232         (thread_db_target) <shortname, longname, doc>: Delete.
1233         <info>: New.
1234         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
1235         add_inf_child_target.
1236         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
1237         add_inf_child_target.
1238         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
1239         add_inf_child_target.
1240         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
1241         add_inf_child_target.
1242         * make-target-delegates (print_class): Adjust.
1243         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
1244         add_inf_child_target.
1245         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
1246         add_inf_child_target.
1247         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
1248         add_inf_child_target.
1249         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
1250         add_inf_child_target.
1251         * nto-procfs.c (nto_native_target_info): New.
1252         (nto_procfs_target_native) <shortname, longname, doc>:
1253         Delete.
1254         <info>: New.
1255         (nto_procfs_target_info): New.
1256         (nto_procfs_target_procfs) <shortname, longname, doc>:
1257         Delete.
1258         <info>: New.
1259         (init_procfs_targets): Adjust.
1260         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
1261         add_inf_child_target.
1262         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
1263         add_inf_child_target.
1264         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
1265         add_inf_child_target.
1266         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
1267         add_inf_child_target.
1268         * ravenscar-thread.c (ravenscar_target_info): New.
1269         (ravenscar_thread_target) <shortname, longname, doc>:
1270         Delete.
1271         <info>: New.
1272         * record-btrace.c (record_btrace_target_info):
1273         (record_btrace_target) <shortname, longname, doc>: Delete.
1274         <info>: New.
1275         (record_btrace_target::open): Rename to ...
1276         (record_btrace_target_open): ... this.  Adjust.
1277         * record-full.c (record_longname, record_doc): New.
1278         (record_full_base_target) <shortname, longname, doc>: Delete.
1279         <info>: New.
1280         (record_full_target_info): New.
1281         (record_full_target): <shortname>: Delete.
1282         <info>: New.
1283         (record_full_core_open_1, record_full_open_1): Update comments.
1284         (record_full_base_target::open): Rename to ...
1285         (record_full_open): ... this.
1286         (cmd_record_full_restore): Update.
1287         (_initialize_record_full): Update.
1288         * remote-sim.c (remote_sim_target_info): New.
1289         (gdbsim_target) <shortname, longname, doc>: Delete.
1290         <info>: New.
1291         (gdbsim_target::open): Rename to ...
1292         (gdbsim_target_open): ... this.
1293         (_initialize_remote_sim): Adjust.
1294         * remote.c (remote_doc): New.
1295         (remote_target_info): New.
1296         (remote_target) <shortname, longname, doc>: Delete.
1297         <info>: New.
1298         (extended_remote_target_info): New.
1299         (extended_remote_target) <shortname, longname, doc>: Delete.
1300         <info>: New.
1301         (remote_target::open_1): Make static.  Adjust.
1302         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
1303         * s390-linux-nat.c (_initialize_s390_nat): Use
1304         add_inf_child_target.
1305         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
1306         add_inf_child_target.
1307         * sol-thread.c (thread_db_target_info): New.
1308         (sol_thread_target) <shortname, longname, doc>: Delete.
1309         <info>: New.
1310         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
1311         add_inf_child_target.
1312         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
1313         add_inf_child_target.
1314         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
1315         add_inf_child_target.
1316         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
1317         add_inf_child_target.
1318         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
1319         add_inf_child_target.
1320         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
1321         add_inf_child_target.
1322         * spu-linux-nat.c (_initialize_spu_nat): Use
1323         add_inf_child_target.
1324         * spu-multiarch.c (spu_multiarch_target_info): New.
1325         (spu_multiarch_target) <shortname, longname, doc>: Delete.
1326         <info>: New.
1327         * target-delegates.c: Regenerate.
1328         * target.c: Include <unordered_map>.
1329         (target_ops_p): Delete.
1330         (DEF_VEC_P(target_ops_p)): Delete.
1331         (target_factories): New.
1332         (test_target_info): New.
1333         (test_target_ops::info): New.
1334         (open_target): Adjust to use target_factories.
1335         (add_target_with_completer): Rename to ...
1336         (add_target): ... this.  Change prototype.  Register target_info
1337         and open callback in target_factories.  Register target_info in
1338         command context instead of target_ops.
1339         (add_target): Delete old implementation.
1340         (add_deprecated_target_alias): Change prototype.  Adjust.
1341         (the_native_target): New.
1342         (set_native_target, get_native_target): New.
1343         (find_default_run_target): Use the_native_target.
1344         (find_attach_target, find_run_target): Simplify.
1345         (target_ops::open): Delete.
1346         (dummy_target_info): New.
1347         (dummy_target::shortname, dummy_target::longname)
1348         (dummy_target::doc): Delete.
1349         (dummy_target::info): New.
1350         (debug_target::shortname, debug_target::longname)
1351         (debug_target::doc): Delete.
1352         (debug_target::info): New.
1353         * target.h (struct target_info): New.
1354         (target_ops::~target_ops): Add comment.
1355         (target_ops::info): New.
1356         (target_ops::shortname, target_ops::longname, target_ops::doc): No
1357         longer virtual.  Implement in terms of target_info.
1358         (set_native_target, get_native_target): Declare.
1359         (target_open_ftype): New.
1360         (add_target, add_target_with_completer)
1361         (add_deprecated_target_alias): Change prototype.
1362         (test_target) <shortname, longname, doc>: Delete.
1363         <info>: New.
1364         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
1365         add_inf_child_target.
1366         * tracefile-tfile.c (tfile_target_info): New.
1367         (tfile_target) <shortname, longname, doc>: Delete.
1368         <info>: New.
1369         (tfile_target::open): Rename to ...
1370         (tfile_target_open): ... this.
1371         (_initialize_tracefile_tfile): Adjust.
1372         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
1373         add_inf_child_target.
1374         * windows-nat.c (_initialize_windows_nat): Use
1375         add_inf_child_target.
1376         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
1377         add_inf_child_target.
1378
1379 2018-05-02  Pedro Alves  <palves@redhat.com>
1380
1381         * linux-nat.h (linux_nat_target) <low_new_thread,
1382         low_delete_thread, low_new_fork, low_forget_process,
1383         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
1384         New virtual methods.
1385         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1386         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
1387         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
1388         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1389         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
1390         Delete.
1391         * linux-fork.c (delete_fork): Adjust to call low method.
1392         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
1393         (linux_nat_new_fork, linux_nat_forget_process_hook)
1394         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
1395         (linux_nat_status_is_event):
1396         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
1397         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
1398         to call low method.
1399         (sigtrap_is_event): Rename to ...
1400         (linux_nat_target::low_status_is_event): ... this.
1401         (linux_nat_set_status_is_event): Delete.
1402         (save_stop_reason, linux_nat_wait_1)
1403         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
1404         low methods.
1405         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1406         (linux_nat_set_new_fork, linux_nat_set_forget_process)
1407         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1408         (linux_nat_set_prepare_to_resume): Delete.
1409         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
1410         low virtual methods.
1411         * amd64-linux-nat.c: Likewise.
1412         * arm-linux-nat.c: Likewise.
1413         * i386-linux-nat.c: Likewise.
1414         * ia64-linux-nat.c: Likewise.
1415         * mips-linux-nat.c: Likewise.
1416         * ppc-linux-nat.c: Likewise.
1417         * s390-linux-nat.c: Likewise.
1418         * sparc64-linux-nat.c: Likewise.
1419         * x86-linux-nat.c: Likewise.
1420         * x86-linux-nat.h: Include "nat/x86-linux.h".
1421         (x86_linux_nat_target) <low_new_fork, low_forget_process,
1422         low_prepare_to_resume, low_new_thread, low_delete_thread>:
1423         Override methods.
1424
1425 2018-05-02  Pedro Alves  <palves@redhat.com>
1426
1427         * target.h (target_ops)
1428         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
1429         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
1430         stopped_by_watchpoint, have_continuable_watchpoint,
1431         stopped_data_address, watchpoint_addr_within_range,
1432         can_accel_watchpoint_condition, can_run, thread_alive,
1433         has_all_memory, has_memory, has_stack, has_registers,
1434         has_execution, can_async_p, is_async_p, supports_non_stop,
1435         always_non_stop_p, can_execute_reverse, supports_multi_process,
1436         supports_enable_disable_tracepoint,
1437         supports_disable_randomization, supports_string_tracing,
1438         supports_evaluation_of_breakpoint_conditions,
1439         can_run_breakpoint_commands, filesystem_is_local,
1440         can_download_tracepoint, get_trace_state_variable_value,
1441         set_trace_notes, get_tib_address, use_agent, can_use_agent,
1442         record_is_replaying, record_will_replay,
1443         augmented_libraries_svr4_read>: Adjust to return bool.
1444         * aarch64-linux-nat.c: All implementations adjusted.
1445         * aix-thread.c: All implementations adjusted.
1446         * arm-linux-nat.c: All implementations adjusted.
1447         * breakpoint.c: All implementations adjusted.
1448         * bsd-kvm.c: All implementations adjusted.
1449         * bsd-uthread.c: All implementations adjusted.
1450         * corelow.c: All implementations adjusted.
1451         * ctf.c: All implementations adjusted.
1452         * darwin-nat.c: All implementations adjusted.
1453         * darwin-nat.h: All implementations adjusted.
1454         * exec.c: All implementations adjusted.
1455         * fbsd-nat.c: All implementations adjusted.
1456         * fbsd-nat.h: All implementations adjusted.
1457         * gnu-nat.c: All implementations adjusted.
1458         * gnu-nat.h: All implementations adjusted.
1459         * go32-nat.c: All implementations adjusted.
1460         * ia64-linux-nat.c: All implementations adjusted.
1461         * inf-child.c: All implementations adjusted.
1462         * inf-child.h: All implementations adjusted.
1463         * inf-ptrace.c: All implementations adjusted.
1464         * inf-ptrace.h: All implementations adjusted.
1465         * linux-nat.c: All implementations adjusted.
1466         * linux-nat.h: All implementations adjusted.
1467         * mips-linux-nat.c: All implementations adjusted.
1468         * nto-procfs.c: All implementations adjusted.
1469         * ppc-linux-nat.c: All implementations adjusted.
1470         * procfs.c: All implementations adjusted.
1471         * ravenscar-thread.c: All implementations adjusted.
1472         * record-btrace.c: All implementations adjusted.
1473         * record-full.c: All implementations adjusted.
1474         * remote-sim.c: All implementations adjusted.
1475         * remote.c: All implementations adjusted.
1476         * s390-linux-nat.c: All implementations adjusted.
1477         * sol-thread.c: All implementations adjusted.
1478         * spu-multiarch.c: All implementations adjusted.
1479         * target-delegates.c: All implementations adjusted.
1480         * target.c: All implementations adjusted.
1481         * target.h: All implementations adjusted.
1482         * tracefile-tfile.c: All implementations adjusted.
1483         * tracefile.c: All implementations adjusted.
1484         * tracefile.h: All implementations adjusted.
1485         * windows-nat.c: All implementations adjusted.
1486         * x86-linux-nat.h: All implementations adjusted.
1487         * x86-nat.h: All implementations adjusted.
1488
1489 2018-05-02  Pedro Alves  <palves@redhat.com>
1490
1491         * make-target-delegates (scan_target_h): Don't trim lines here.
1492         Replace sequences of tabs and/or whitespace with a single
1493         whitespace.
1494         (top level, parsing methods): Trim each line before processing it
1495         here.
1496
1497 2018-05-02  Pedro Alves  <palves@redhat.com>
1498             John Baldwin  <jhb@freebsd.org>
1499
1500         * target.h (enum strata) <debug_stratum>: New.
1501         (struct target_ops) <all delegation methods>: Replace by C++
1502         virtual methods, and drop "to_" prefix.  All references updated
1503         throughout.
1504         <to_shortname, to_longname, to_doc, to_data,
1505         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
1506         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
1507         virtual methods.  All references updated throughout.
1508         <can_attach, supports_terminal_ours, can_create_inferior,
1509         get_thread_control_capabilities, attach_no_wait>: New
1510         virtual methods.
1511         <insert_breakpoint, remove_breakpoint>: Now
1512         TARGET_DEFAULT_NORETURN methods.
1513         <info_proc>: Now returns bool.
1514         <to_magic>: Delete.
1515         (OPS_MAGIC): Delete.
1516         (current_target): Delete.  All references replaced by references
1517         to ...
1518         (target_stack): ... this.  New.
1519         (target_shortname, target_longname): Adjust.
1520         (target_can_run): Now a function declaration.
1521         (default_child_has_all_memory, default_child_has_memory)
1522         (default_child_has_stack, default_child_has_registers)
1523         (default_child_has_execution): Remove target_ops parameter.
1524         (complete_target_initialization): Delete.
1525         (memory_breakpoint_target): New template class.
1526         (test_target_ops): Refactor as a C++ class with virtual methods.
1527         * make-target-delegates (NAME_PART): Tighten.
1528         (POINTER_PART, CP_SYMBOL): New.
1529         (SIMPLE_RETURN_PART): Reimplement.
1530         (VEC_RETURN_PART): Expect less.
1531         (RETURN_PART, VIRTUAL_PART): New.
1532         (METHOD): Adjust to C++ virtual methods.
1533         (scan_target_h): Remove reference to C99.
1534         (dname): Output "target_ops::" prefix.
1535         (write_function_header): Adjust to output a C++ class method.
1536         (write_declaration): New.
1537         (write_delegator): Adjust to output a C++ class method.
1538         (tdname): Output "dummy_target::" prefix.
1539         (write_tdefault, write_debugmethod): Adjust to output a C++ class
1540         method.
1541         (tdefault_names, debug_names): Delete.
1542         (return_types, tdefaults, styles, argtypes_array): New.
1543         (top level): All methods are delegators.
1544         (print_class): New.
1545         (top level): Print dummy_target and debug_target classes.
1546         * target-delegates.c: Regenerate.
1547         * target-debug.h (target_debug_print_enum_info_proc_what)
1548         (target_debug_print_thread_control_capabilities)
1549         (target_debug_print_thread_info_p): New.
1550         * target.c (dummy_target): Delete.
1551         (the_dummy_target, the_debug_target): New.
1552         (target_stack): Now extern.
1553         (set_targetdebug): Push/unpush debug target.
1554         (default_child_has_all_memory, default_child_has_memory)
1555         (default_child_has_stack, default_child_has_registers)
1556         (default_child_has_execution): Remove target_ops parameter.
1557         (complete_target_initialization): Delete.
1558         (add_target_with_completer): No longer call
1559         complete_target_initialization.
1560         (target_supports_terminal_ours): Use regular delegation.
1561         (update_current_target): Delete.
1562         (push_target): No longer check magic number.  Don't call
1563         update_current_target.
1564         (unpush_target): Don't call update_current_target.
1565         (target_is_pushed): No longer check magic number.
1566         (target_require_runnable): Skip for all stratums over
1567         process_stratum.
1568         (target_ops::info_proc): New.
1569         (target_info_proc): Use find_target_at and
1570         find_default_run_target.
1571         (target_supports_disable_randomization): Use regular delegation.
1572         (target_get_osdata): Use find_target_at.
1573         (target_ops::open, target_ops::close, target_ops::can_attach)
1574         (target_ops::attach, target_ops::can_create_inferior)
1575         (target_ops::create_inferior, target_ops::can_run)
1576         (target_can_run): New.
1577         (default_fileio_target): Use regular delegation.
1578         (target_ops::fileio_open, target_ops::fileio_pwrite)
1579         (target_ops::fileio_pread, target_ops::fileio_fstat)
1580         (target_ops::fileio_close, target_ops::fileio_unlink)
1581         (target_ops::fileio_readlink): New.
1582         (target_fileio_open_1, target_fileio_unlink)
1583         (target_fileio_readlink): Always call the target method.  Handle
1584         FILEIO_ENOSYS.
1585         (return_zero, return_zero_has_execution): Delete.
1586         (init_dummy_target): Delete.
1587         (dummy_target::dummy_target, dummy_target::shortname)
1588         (dummy_target::longname, dummy_target::doc)
1589         (debug_target::debug_target, debug_target::shortname)
1590         (debug_target::longname, debug_target::doc): New.
1591         (target_supports_delete_record): Use regular delegation.
1592         (setup_target_debug): Delete.
1593         (maintenance_print_target_stack): Skip debug_stratum.
1594         (initialize_targets): Instantiate the_dummy_target and
1595         the_debug_target.
1596         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
1597         use target_stack.
1598         (target_auxv_search, fprint_target_auxv): Adjust.
1599         (info_auxv_command): Adjust to use target_stack.
1600         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
1601         * exceptions.c (print_flush): Handle a NULL target_stack.
1602         * regcache.c (target_ops_no_register): Refactor as class with
1603         virtual methods.
1604
1605         * exec.c (exec_target): New class.
1606         (exec_ops): Now an exec_target.
1607         (exec_open, exec_close_1, exec_get_section_table)
1608         (exec_xfer_partial, exec_files_info, exec_has_memory)
1609         (exec_make_note_section): Refactor as exec_target methods.
1610         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
1611         Delete.
1612         (exec_target::find_memory_regions): New.
1613         (_initialize_exec): Don't call init_exec_ops.
1614         * gdbcore.h (exec_file_clear): Delete.
1615
1616         * corefile.c (core_target): Delete.
1617         (core_file_command): Adjust.
1618         * corelow.c (core_target): New class.
1619         (the_core_target): New.
1620         (core_close): Remove target_ops parameter.
1621         (core_close_cleanup): Adjust.
1622         (core_target::close): New.
1623         (core_open, core_detach, get_core_registers, core_files_info)
1624         (core_xfer_partial, core_thread_alive, core_read_description)
1625         (core_pid_to_str, core_thread_name, core_has_memory)
1626         (core_has_stack, core_has_registers, core_info_proc): Rework as
1627         core_target methods.
1628         (ignore, core_remove_breakpoint, init_core_ops): Delete.
1629         (_initialize_corelow): Initialize the_core_target.
1630         * gdbcore.h (core_target): Delete.
1631         (the_core_target): New.
1632
1633         * ctf.c: (ctf_target): New class.
1634         (ctf_ops): Now a ctf_target.
1635         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
1636         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
1637         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
1638         methods.
1639         (init_ctf_ops): Delete.
1640         (_initialize_ctf): Don't call it.
1641         * tracefile-tfile.c (tfile_target): New class.
1642         (tfile_ops): Now a tfile_target.
1643         (tfile_open, tfile_close, tfile_files_info)
1644         (tfile_get_tracepoint_status, tfile_trace_find)
1645         (tfile_fetch_registers, tfile_xfer_partial)
1646         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
1647         Refactor as tfile_target methods.
1648         (tfile_xfer_partial_features): Remove target_ops parameter.
1649         (init_tfile_ops): Delete.
1650         (_initialize_tracefile_tfile): Don't call it.
1651         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
1652         (tracefile_has_stack, tracefile_has_registers)
1653         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
1654         tracefile_target methods.
1655         (init_tracefile_ops): Delete.
1656         (tracefile_target::tracefile_target): New.
1657         * tracefile.h: Include "target.h".
1658         (tracefile_target): New class.
1659         (init_tracefile_ops): Delete.
1660
1661         * spu-multiarch.c (spu_multiarch_target): New class.
1662         (spu_ops): Now a spu_multiarch_target.
1663         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
1664         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
1665         (spu_search_memory, spu_mourn_inferior): Refactor as
1666         spu_multiarch_target methods.
1667         (init_spu_ops): Delete.
1668         (_initialize_spu_multiarch): Remove references to init_spu_ops,
1669         complete_target_initialization.
1670
1671         * ravenscar-thread.c (ravenscar_thread_target): New class.
1672         (ravenscar_ops): Now a ravenscar_thread_target.
1673         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
1674         (ravenscar_thread_alive, ravenscar_pid_to_str)
1675         (ravenscar_fetch_registers, ravenscar_store_registers)
1676         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
1677         (ravenscar_stopped_by_hw_breakpoint)
1678         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
1679         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
1680         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
1681         methods.
1682         (init_ravenscar_thread_ops): Delete.
1683         (_initialize_ravenscar): Remove references to
1684         init_ravenscar_thread_ops and complete_target_initialization.
1685
1686         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
1687         (bsd_uthread_target): New class.
1688         (bsd_uthread_ops): Now a bsd_uthread_target.
1689         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
1690         (bsd_uthread_close, bsd_uthread_mourn_inferior)
1691         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
1692         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
1693         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
1694         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
1695         (bsd_uthread_target): Delete function.
1696         (_initialize_bsd_uthread): Remove reference to
1697         complete_target_initialization.
1698
1699         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
1700         (target_bfd): ... this new class.
1701         (target_bfd_xfer_partial, target_bfd_get_section_table)
1702         (target_bfd_close): Refactor as target_bfd methods.
1703         (target_bfd::~target_bfd): New.
1704         (target_bfd_reopen): Adjust.
1705         (target_bfd::close): New.
1706
1707         * record-btrace.c (record_btrace_target): New class.
1708         (record_btrace_ops): Now a record_btrace_target.
1709         (record_btrace_open, record_btrace_stop_recording)
1710         (record_btrace_disconnect, record_btrace_close)
1711         (record_btrace_async, record_btrace_info)
1712         (record_btrace_insn_history, record_btrace_insn_history_range)
1713         (record_btrace_insn_history_from, record_btrace_call_history)
1714         (record_btrace_call_history_range)
1715         (record_btrace_call_history_from, record_btrace_record_method)
1716         (record_btrace_is_replaying, record_btrace_will_replay)
1717         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
1718         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
1719         (record_btrace_store_registers, record_btrace_prepare_to_store)
1720         (record_btrace_to_get_unwinder)
1721         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
1722         (record_btrace_commit_resume, record_btrace_wait)
1723         (record_btrace_stop, record_btrace_can_execute_reverse)
1724         (record_btrace_stopped_by_sw_breakpoint)
1725         (record_btrace_supports_stopped_by_sw_breakpoint)
1726         (record_btrace_stopped_by_hw_breakpoint)
1727         (record_btrace_supports_stopped_by_hw_breakpoint)
1728         (record_btrace_update_thread_list, record_btrace_thread_alive)
1729         (record_btrace_goto_begin, record_btrace_goto_end)
1730         (record_btrace_goto, record_btrace_stop_replaying_all)
1731         (record_btrace_execution_direction)
1732         (record_btrace_prepare_to_generate_core)
1733         (record_btrace_done_generating_core): Refactor as
1734         record_btrace_target methods.
1735         (init_record_btrace_ops): Delete.
1736         (_initialize_record_btrace): Remove reference to
1737         init_record_btrace_ops.
1738         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
1739         the execution_direction global.
1740         (record_full_base_target, record_full_target)
1741         (record_full_core_target): New classes.
1742         (record_full_ops): Now a record_full_target.
1743         (record_full_core_ops): Now a record_full_core_target.
1744         (record_full_target::detach, record_full_target::disconnect)
1745         (record_full_core_target::disconnect)
1746         (record_full_target::mourn_inferior, record_full_target::kill):
1747         New.
1748         (record_full_open, record_full_close, record_full_async): Refactor
1749         as methods of the record_full_base_target class.
1750         (record_full_resume, record_full_commit_resume): Refactor
1751         as methods of the record_full_target class.
1752         (record_full_wait, record_full_stopped_by_watchpoint)
1753         (record_full_stopped_data_address)
1754         (record_full_stopped_by_sw_breakpoint)
1755         (record_full_supports_stopped_by_sw_breakpoint)
1756         (record_full_stopped_by_hw_breakpoint)
1757         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
1758         methods of the record_full_base_target class.
1759         (record_full_store_registers, record_full_xfer_partial)
1760         (record_full_insert_breakpoint, record_full_remove_breakpoint):
1761         Refactor as methods of the record_full_target class.
1762         (record_full_can_execute_reverse, record_full_get_bookmark)
1763         (record_full_goto_bookmark, record_full_execution_direction)
1764         (record_full_record_method, record_full_info, record_full_delete)
1765         (record_full_is_replaying, record_full_will_replay)
1766         (record_full_goto_begin, record_full_goto_end, record_full_goto)
1767         (record_full_stop_replaying): Refactor as methods of the
1768         record_full_base_target class.
1769         (record_full_core_resume, record_full_core_kill)
1770         (record_full_core_fetch_registers)
1771         (record_full_core_prepare_to_store)
1772         (record_full_core_store_registers, record_full_core_xfer_partial)
1773         (record_full_core_insert_breakpoint)
1774         (record_full_core_remove_breakpoint)
1775         (record_full_core_has_execution): Refactor
1776         as methods of the record_full_core_target class.
1777         (record_full_base_target::supports_delete_record): New.
1778         (init_record_full_ops): Delete.
1779         (init_record_full_core_ops): Delete.
1780         (record_full_save): Refactor as method of the
1781         record_full_base_target class.
1782         (_initialize_record_full): Remove references to
1783         init_record_full_ops and init_record_full_core_ops.
1784
1785         * remote.c (remote_target, extended_remote_target): New classes.
1786         (remote_ops): Now a remote_target.
1787         (extended_remote_ops): Now an extended_remote_target.
1788         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
1789         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
1790         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
1791         (remote_pass_signals, remote_set_syscall_catchpoint)
1792         (remote_program_signals, )
1793         (remote_thread_always_alive): Remove target_ops parameter.
1794         (remote_thread_alive, remote_thread_name)
1795         (remote_update_thread_list, remote_threads_extra_info)
1796         (remote_static_tracepoint_marker_at)
1797         (remote_static_tracepoint_markers_by_strid)
1798         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
1799         (remote_open): Refactor as methods of remote_target.
1800         (extended_remote_open, extended_remote_detach)
1801         (extended_remote_attach, extended_remote_post_attach):
1802         (extended_remote_supports_disable_randomization)
1803         (extended_remote_create_inferior): : Refactor as method of
1804         extended_remote_target.
1805         (remote_set_permissions, remote_open_1, remote_detach)
1806         (remote_follow_fork, remote_follow_exec, remote_disconnect)
1807         (remote_resume, remote_commit_resume, remote_stop)
1808         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
1809         (remote_terminal_ours, remote_wait, remote_fetch_registers)
1810         (remote_prepare_to_store, remote_store_registers)
1811         (remote_flash_erase, remote_flash_done, remote_files_info)
1812         (remote_kill, remote_mourn, remote_insert_breakpoint)
1813         (remote_remove_breakpoint, remote_insert_watchpoint)
1814         (remote_watchpoint_addr_within_range)
1815         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
1816         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
1817         (remote_supports_stopped_by_sw_breakpoint)
1818         (remote_stopped_by_hw_breakpoint)
1819         (remote_supports_stopped_by_hw_breakpoint)
1820         (remote_stopped_by_watchpoint, remote_stopped_data_address)
1821         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
1822         (remote_verify_memory): Refactor as methods of remote_target.
1823         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
1824         parameter.
1825         (remote_xfer_partial, remote_get_memory_xfer_limit)
1826         (remote_search_memory, remote_rcmd, remote_memory_map)
1827         (remote_pid_to_str, remote_get_thread_local_address)
1828         (remote_get_tib_address, remote_read_description): Refactor as
1829         methods of remote_target.
1830         (remote_target::fileio_open, remote_target::fileio_pwrite)
1831         (remote_target::fileio_pread, remote_target::fileio_close): New.
1832         (remote_hostio_readlink, remote_hostio_fstat)
1833         (remote_filesystem_is_local, remote_can_execute_reverse)
1834         (remote_supports_non_stop, remote_supports_disable_randomization)
1835         (remote_supports_multi_process, remote_supports_cond_breakpoints)
1836         (remote_supports_enable_disable_tracepoint)
1837         (remote_supports_string_tracing)
1838         (remote_can_run_breakpoint_commands, remote_trace_init)
1839         (remote_download_tracepoint, remote_can_download_tracepoint)
1840         (remote_download_trace_state_variable, remote_enable_tracepoint)
1841         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
1842         (remote_trace_start, remote_get_trace_status)
1843         (remote_get_tracepoint_status, remote_trace_stop)
1844         (remote_trace_find, remote_get_trace_state_variable_value)
1845         (remote_save_trace_data, remote_get_raw_trace_data)
1846         (remote_set_disconnected_tracing, remote_core_of_thread)
1847         (remote_set_circular_trace_buffer, remote_traceframe_info)
1848         (remote_get_min_fast_tracepoint_insn_len)
1849         (remote_set_trace_buffer_size, remote_set_trace_notes)
1850         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
1851         (remote_disable_btrace, remote_teardown_btrace)
1852         (remote_read_btrace, remote_btrace_conf)
1853         (remote_augmented_libraries_svr4_read, remote_load)
1854         (remote_pid_to_exec_file, remote_can_do_single_step)
1855         (remote_execution_direction, remote_thread_handle_to_thread_info):
1856         Refactor as methods of remote_target.
1857         (init_remote_ops, init_extended_remote_ops): Delete.
1858         (remote_can_async_p, remote_is_async_p, remote_async)
1859         (remote_thread_events, remote_upload_tracepoints)
1860         (remote_upload_trace_state_variables): Refactor as methods of
1861         remote_target.
1862         (_initialize_remote): Remove references to init_remote_ops and
1863         init_extended_remote_ops.
1864
1865         * remote-sim.c (gdbsim_target): New class.
1866         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
1867         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
1868         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
1869         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
1870         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
1871         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
1872         Refactor as methods of gdbsim_target.
1873         (gdbsim_ops): Now a gdbsim_target.
1874         (init_gdbsim_ops): Delete.
1875         (gdbsim_cntrl_c): Adjust.
1876         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
1877
1878         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
1879         (the_amd64_linux_nat_target): New.
1880         (amd64_linux_fetch_inferior_registers)
1881         (amd64_linux_store_inferior_registers): Refactor as methods of
1882         amd64_linux_nat_target.
1883         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
1884         * i386-linux-nat.c: Don't include "linux-nat.h".
1885         (i386_linux_nat_target): New class.
1886         (the_i386_linux_nat_target): New.
1887         (i386_linux_fetch_inferior_registers)
1888         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
1889         as methods of i386_linux_nat_target.
1890         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
1891         * inf-child.c (inf_child_ops): Delete.
1892         (inf_child_fetch_inferior_registers)
1893         (inf_child_store_inferior_registers): Delete.
1894         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
1895         methods of inf_child_target.
1896         (inf_child_target::supports_terminal_ours)
1897         (inf_child_target::terminal_init)
1898         (inf_child_target::terminal_inferior)
1899         (inf_child_target::terminal_ours_for_output)
1900         (inf_child_target::terminal_ours, inf_child_target::interrupt)
1901         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
1902         New.
1903         (inf_child_open, inf_child_disconnect, inf_child_close)
1904         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
1905         (inf_child_post_startup_inferior, inf_child_can_run)
1906         (inf_child_pid_to_exec_file): Refactor as methods of
1907         inf_child_target.
1908         (inf_child_follow_fork): Delete.
1909         (inf_child_target::can_create_inferior)
1910         (inf_child_target::can_attach): New.
1911         (inf_child_target::has_all_memory, inf_child_target::has_memory)
1912         (inf_child_target::has_stack, inf_child_target::has_registers)
1913         (inf_child_target::has_execution): New.
1914         (inf_child_fileio_open, inf_child_fileio_pwrite)
1915         (inf_child_fileio_pread, inf_child_fileio_fstat)
1916         (inf_child_fileio_close, inf_child_fileio_unlink)
1917         (inf_child_fileio_readlink, inf_child_use_agent)
1918         (inf_child_can_use_agent): Refactor as methods of
1919         inf_child_target.
1920         (return_zero, inf_child_target): Delete.
1921         (inf_child_target::inf_child_target): New.
1922         * inf-child.h: Include "target.h".
1923         (inf_child_target): Delete function prototype.
1924         (inf_child_target): New class.
1925         (inf_child_open_target, inf_child_mourn_inferior)
1926         (inf_child_maybe_unpush_target): Delete.
1927         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
1928         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
1929         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
1930         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
1931         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
1932         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
1933         (inf_ptrace_wait, inf_ptrace_xfer_partial)
1934         (inf_ptrace_thread_alive, inf_ptrace_files_info)
1935         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
1936         methods of inf_ptrace_target.
1937         (inf_ptrace_target): Delete function.
1938         * inf-ptrace.h: Include "inf-child.h".
1939         (inf_ptrace_target): Delete function declaration.
1940         (inf_ptrace_target): New class.
1941         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
1942         * linux-nat.c (linux_target): New.
1943         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
1944         (linux_nat_target::~linux_nat_target): New.
1945         (linux_child_post_attach, linux_child_post_startup_inferior)
1946         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
1947         (linux_child_remove_fork_catchpoint)
1948         (linux_child_insert_vfork_catchpoint)
1949         (linux_child_remove_vfork_catchpoint)
1950         (linux_child_insert_exec_catchpoint)
1951         (linux_child_remove_exec_catchpoint)
1952         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
1953         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
1954         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
1955         (linux_nat_stopped_data_address)
1956         (linux_nat_stopped_by_sw_breakpoint)
1957         (linux_nat_supports_stopped_by_sw_breakpoint)
1958         (linux_nat_stopped_by_hw_breakpoint)
1959         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
1960         (linux_nat_kill, linux_nat_mourn_inferior)
1961         (linux_nat_xfer_partial, linux_nat_thread_alive)
1962         (linux_nat_update_thread_list, linux_nat_pid_to_str)
1963         (linux_nat_thread_name, linux_child_pid_to_exec_file)
1964         (linux_child_static_tracepoint_markers_by_strid)
1965         (linux_nat_is_async_p, linux_nat_can_async_p)
1966         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
1967         (linux_nat_supports_multi_process)
1968         (linux_nat_supports_disable_randomization, linux_nat_async)
1969         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
1970         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
1971         (linux_nat_fileio_open, linux_nat_fileio_readlink)
1972         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
1973         methods of linux_nat_target.
1974         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
1975         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
1976         parameter.
1977         (check_stopped_by_watchpoint): Adjust.
1978         (linux_xfer_partial): Delete.
1979         (linux_target_install_ops, linux_target, linux_nat_add_target):
1980         Delete.
1981         (linux_nat_target::linux_nat_target): New.
1982         * linux-nat.h: Include "inf-ptrace.h".
1983         (linux_nat_target): New.
1984         (linux_target, linux_target_install_ops, linux_nat_add_target):
1985         Delete function declarations.
1986         (linux_target): Declare global.
1987         * linux-thread-db.c (thread_db_target): New.
1988         (thread_db_target::thread_db_target): New.
1989         (thread_db_ops): Delete.
1990         (the_thread_db_target): New.
1991         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
1992         (thread_db_update_thread_list, thread_db_pid_to_str)
1993         (thread_db_extra_thread_info)
1994         (thread_db_thread_handle_to_thread_info)
1995         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
1996         (thread_db_resume): Refactor as methods of thread_db_target.
1997         (init_thread_db_ops): Delete.
1998         (_initialize_thread_db): Remove reference to init_thread_db_ops.
1999         * x86-linux-nat.c: Don't include "linux-nat.h".
2000         (super_post_startup_inferior): Delete.
2001         (x86_linux_nat_target::~x86_linux_nat_target): New.
2002         (x86_linux_child_post_startup_inferior)
2003         (x86_linux_read_description, x86_linux_enable_btrace)
2004         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
2005         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
2006         methods of x86_linux_nat_target.
2007         (x86_linux_create_target): Delete.  Bits folded ...
2008         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
2009         pointer.
2010         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
2011         (x86_linux_nat_target): New class.
2012         (x86_linux_create_target): Delete.
2013         (x86_linux_add_target): Now takes a linux_nat_target pointer.
2014         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
2015         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
2016         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
2017         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
2018         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
2019         make extern.
2020         (x86_use_watchpoints): Delete.
2021         * x86-nat.h: Include "breakpoint.h" and "target.h".
2022         (x86_use_watchpoints): Delete.
2023         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
2024         (x86_stopped_by_watchpoint, x86_stopped_data_address)
2025         (x86_insert_watchpoint, x86_remove_watchpoint)
2026         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
2027         (x86_stopped_by_hw_breakpoint): New declarations.
2028         (x86_nat_target): New template class.
2029
2030         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
2031         (the_ppc_linux_nat_target): New.
2032         (ppc_linux_fetch_inferior_registers)
2033         (ppc_linux_can_use_hw_breakpoint)
2034         (ppc_linux_region_ok_for_hw_watchpoint)
2035         (ppc_linux_ranged_break_num_registers)
2036         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
2037         (ppc_linux_insert_mask_watchpoint)
2038         (ppc_linux_remove_mask_watchpoint)
2039         (ppc_linux_can_accel_watchpoint_condition)
2040         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
2041         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
2042         (ppc_linux_watchpoint_addr_within_range)
2043         (ppc_linux_masked_watch_num_registers)
2044         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
2045         (ppc_linux_read_description): Refactor as methods of
2046         ppc_linux_nat_target.
2047         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
2048
2049         * procfs.c (procfs_xfer_partial): Delete forward declaration.
2050         (procfs_target): New class.
2051         (the_procfs_target): New.
2052         (procfs_target): Delete function.
2053         (procfs_auxv_parse, procfs_attach, procfs_detach)
2054         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
2055         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
2056         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
2057         (procfs_create_inferior, procfs_update_thread_list)
2058         (procfs_thread_alive, procfs_pid_to_str)
2059         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
2060         (procfs_stopped_data_address, procfs_insert_watchpoint)
2061         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
2062         (proc_find_memory_regions, procfs_info_proc)
2063         (procfs_make_note_section): Refactor as methods of procfs_target.
2064         (_initialize_procfs): Adjust.
2065         * sol-thread.c (sol_thread_target): New class.
2066         (sol_thread_ops): Now a sol_thread_target.
2067         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
2068         (sol_thread_fetch_registers, sol_thread_store_registers)
2069         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
2070         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
2071         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
2072         (init_sol_thread_ops): Delete.
2073         (_initialize_sol_thread): Adjust.  Remove references to
2074         init_sol_thread_ops and complete_target_initialization.
2075
2076         * windows-nat.c (windows_nat_target): New class.
2077         (windows_fetch_inferior_registers)
2078         (windows_store_inferior_registers, windows_resume, windows_wait)
2079         (windows_attach, windows_detach, windows_pid_to_exec_file)
2080         (windows_files_info, windows_create_inferior)
2081         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
2082         (windows_close, windows_pid_to_str, windows_xfer_partial)
2083         (windows_get_tib_address, windows_get_ada_task_ptid)
2084         (windows_thread_name, windows_thread_alive): Refactor as
2085         windows_nat_target methods.
2086         (do_initial_windows_stuff): Adjust.
2087         (windows_target): Delete function.
2088         (_initialize_windows_nat): Adjust.
2089
2090         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
2091         (darwin_mourn_inferior, darwin_kill_inferior)
2092         (darwin_create_inferior, darwin_attach, darwin_detach)
2093         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
2094         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
2095         (darwin_supports_multi_process): Refactor as darwin_nat_target
2096         methods.
2097         (darwin_resume_to, darwin_files_info): Delete.
2098         (_initialize_darwin_inferior): Rename to ...
2099         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
2100         * darwin-nat.h: Include "inf-child.h".
2101         (darwin_nat_target): New class.
2102         (darwin_complete_target): Delete.
2103         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
2104         (darwin_target): New.
2105         (i386_darwin_fetch_inferior_registers)
2106         (i386_darwin_store_inferior_registers): Refactor as methods of
2107         darwin_nat_target.
2108         (darwin_complete_target): Delete, with ...
2109         (_initialize_i386_darwin_nat): ... bits factored out here.
2110
2111         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
2112         (the_alpha_linux_nat_target): New.
2113         (alpha_linux_register_u_offset): Refactor as
2114         alpha_linux_nat_target method.
2115         (_initialize_alpha_linux_nat): Adjust.
2116         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
2117         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2118         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
2119         methods of linux_nat_trad_target.
2120         (linux_trad_target): Delete.
2121         * linux-nat-trad.h (linux_trad_target): Delete function.
2122         (linux_nat_trad_target): New class.
2123         * mips-linux-nat.c (mips_linux_nat_target): New class.
2124         (super_fetch_registers, super_store_registers, super_close):
2125         Delete.
2126         (the_mips_linux_nat_target): New.
2127         (mips64_linux_regsets_fetch_registers)
2128         (mips64_linux_regsets_store_registers)
2129         (mips64_linux_fetch_registers, mips64_linux_store_registers)
2130         (mips_linux_register_u_offset, mips_linux_read_description)
2131         (mips_linux_can_use_hw_breakpoint)
2132         (mips_linux_stopped_by_watchpoint)
2133         (mips_linux_stopped_data_address)
2134         (mips_linux_region_ok_for_hw_watchpoint)
2135         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
2136         (mips_linux_close): Refactor as methods of mips_linux_nat.
2137         (_initialize_mips_linux_nat): Adjust to C++ification.
2138
2139         * aix-thread.c (aix_thread_target): New class.
2140         (aix_thread_ops): Now an aix_thread_target.
2141         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
2142         (aix_thread_fetch_registers, aix_thread_store_registers)
2143         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
2144         (aix_thread_thread_alive, aix_thread_pid_to_str)
2145         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
2146         Refactor as methods of aix_thread_target.
2147         (init_aix_thread_ops): Delete.
2148         (_initialize_aix_thread): Remove references to init_aix_thread_ops
2149         and complete_target_initialization.
2150         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
2151         (rs6000_nat_target): New class.
2152         (the_rs6000_nat_target): New.
2153         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
2154         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
2155         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
2156         (super_create_inferior): Delete.
2157         (_initialize_rs6000_nat): Adjust to C++ification.
2158
2159         * arm-linux-nat.c (arm_linux_nat_target): New class.
2160         (the_arm_linux_nat_target): New.
2161         (arm_linux_fetch_inferior_registers)
2162         (arm_linux_store_inferior_registers, arm_linux_read_description)
2163         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
2164         (arm_linux_remove_hw_breakpoint)
2165         (arm_linux_region_ok_for_hw_watchpoint)
2166         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
2167         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
2168         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
2169         arm_linux_nat_target.
2170         (_initialize_arm_linux_nat): Adjust to C++ification.
2171
2172         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
2173         (the_aarch64_linux_nat_target): New.
2174         (aarch64_linux_fetch_inferior_registers)
2175         (aarch64_linux_store_inferior_registers)
2176         (aarch64_linux_child_post_startup_inferior)
2177         (aarch64_linux_read_description)
2178         (aarch64_linux_can_use_hw_breakpoint)
2179         (aarch64_linux_insert_hw_breakpoint)
2180         (aarch64_linux_remove_hw_breakpoint)
2181         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
2182         (aarch64_linux_region_ok_for_hw_watchpoint)
2183         (aarch64_linux_stopped_data_address)
2184         (aarch64_linux_stopped_by_watchpoint)
2185         (aarch64_linux_watchpoint_addr_within_range)
2186         (aarch64_linux_can_do_single_step): Refactor as methods of
2187         aarch64_linux_nat_target.
2188         (super_post_startup_inferior): Delete.
2189         (_initialize_aarch64_linux_nat): Adjust to C++ification.
2190
2191         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
2192         (the_hppa_linux_nat_target): New.
2193         (hppa_linux_fetch_inferior_registers)
2194         (hppa_linux_store_inferior_registers): Refactor as methods of
2195         hppa_linux_nat_target.
2196         (_initialize_hppa_linux_nat): Adjust to C++ification.
2197
2198         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
2199         (the_ia64_linux_nat_target): New.
2200         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
2201         (ia64_linux_stopped_data_address)
2202         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
2203         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
2204         ia64_linux_nat_target methods.
2205         (super_xfer_partial): Delete.
2206         (_initialize_ia64_linux_nat): Adjust to C++ification.
2207
2208         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
2209         (the_m32r_linux_nat_target): New.
2210         (m32r_linux_fetch_inferior_registers)
2211         (m32r_linux_store_inferior_registers): Refactor as
2212         m32r_linux_nat_target methods.
2213         (_initialize_m32r_linux_nat): Adjust to C++ification.
2214
2215         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
2216         (the_m68k_linux_nat_target): New.
2217         (m68k_linux_fetch_inferior_registers)
2218         (m68k_linux_store_inferior_registers): Refactor as
2219         m68k_linux_nat_target methods.
2220         (_initialize_m68k_linux_nat): Adjust to C++ification.
2221
2222         * s390-linux-nat.c (s390_linux_nat_target): New class.
2223         (the_s390_linux_nat_target): New.
2224         (s390_linux_fetch_inferior_registers)
2225         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
2226         (s390_insert_watchpoint, s390_remove_watchpoint)
2227         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
2228         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
2229         (s390_auxv_parse, s390_read_description): Refactor as methods of
2230         s390_linux_nat_target.
2231         (_initialize_s390_nat): Adjust to C++ification.
2232
2233         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
2234         (the_sparc_linux_nat_target): New.
2235         (_initialize_sparc_linux_nat): Adjust to C++ification.
2236         * sparc-nat.c (sparc_fetch_inferior_registers)
2237         (sparc_store_inferior_registers): Remove target_ops parameter.
2238         * sparc-nat.h (sparc_fetch_inferior_registers)
2239         (sparc_store_inferior_registers): Remove target_ops parameter.
2240         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
2241         (the_sparc64_linux_nat_target): New.
2242         (_initialize_sparc64_linux_nat): Adjust to C++ification.
2243
2244         * spu-linux-nat.c (spu_linux_nat_target): New class.
2245         (the_spu_linux_nat_target): New.
2246         (spu_child_post_startup_inferior, spu_child_post_attach)
2247         (spu_child_wait, spu_fetch_inferior_registers)
2248         (spu_store_inferior_registers, spu_xfer_partial)
2249         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
2250         methods.
2251         (_initialize_spu_nat): Adjust to C++ification.
2252
2253         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
2254         (the_tilegx_linux_nat_target): New.
2255         (fetch_inferior_registers, store_inferior_registers):
2256         Refactor as methods.
2257         (_initialize_tile_linux_nat): Adjust to C++ification.
2258
2259         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
2260         (the_xtensa_linux_nat_target): New.
2261         (xtensa_linux_fetch_inferior_registers)
2262         (xtensa_linux_store_inferior_registers): Refactor as
2263         xtensa_linux_nat_target methods.
2264         (_initialize_xtensa_linux_nat): Adjust to C++ification.
2265
2266         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
2267         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
2268         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
2269         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
2270         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
2271         (fbsd_stopped_by_sw_breakpoint)
2272         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
2273         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
2274         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
2275         (fbsd_post_startup_inferior, fbsd_post_attach)
2276         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
2277         (fbsd_set_syscall_catchpoint)
2278         (super_xfer_partial, super_resume, super_wait)
2279         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
2280         (fbsd_handle_debug_trap): Remove target_ops parameter.
2281         (fbsd_nat_add_target): Delete.
2282         * fbsd-nat.h: Include "inf-ptrace.h".
2283         (fbsd_nat_add_target): Delete.
2284         (USE_SIGTRAP_SIGINFO): Define.
2285         (fbsd_nat_target): New class.
2286
2287         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
2288         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
2289         (amd64bsd_target): Delete.
2290         * amd64-bsd-nat.h: New file.
2291         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
2292         "x86-bsd-nat.h".
2293         (amd64_fbsd_nat_target): New class.
2294         (the_amd64_fbsd_nat_target): New.
2295         (amd64fbsd_read_description): Refactor as method of
2296         amd64_fbsd_nat_target.
2297         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2298         (_initialize_amd64fbsd_nat): Adjust to C++ification.
2299         * amd64-nat.h (amd64bsd_target): Delete function declaration.
2300         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
2301         (i386bsd_store_inferior_registers): Remove target_ops parameter.
2302         (i386bsd_target): Delete.
2303         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
2304         (i386bsd_fetch_inferior_registers)
2305         (i386bsd_store_inferior_registers): Declare.
2306         (i386_bsd_nat_target): New class.
2307         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
2308         (the_i386_fbsd_nat_target): New.
2309         (i386fbsd_resume, i386fbsd_read_description): Refactor as
2310         i386_fbsd_nat_target methods.
2311         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2312         (_initialize_i386fbsd_nat): Adjust to C++ification.
2313         * x86-bsd-nat.c (super_mourn_inferior): Delete.
2314         (x86bsd_mourn_inferior, x86bsd_target): Delete.
2315         (_initialize_x86_bsd_nat): Adjust to C++ification.
2316         * x86-bsd-nat.h: Include "x86-nat.h".
2317         (x86bsd_target): Delete declaration.
2318         (x86bsd_nat_target): New class.
2319
2320         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
2321         (the_aarch64_fbsd_nat_target): New.
2322         (aarch64_fbsd_fetch_inferior_registers)
2323         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
2324         aarch64_fbsd_nat_target.
2325         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
2326         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
2327         (the_alpha_bsd_nat_target): New.
2328         (alphabsd_fetch_inferior_registers)
2329         (alphabsd_store_inferior_registers): Refactor as
2330         alpha_bsd_nat_target methods.
2331         (_initialize_alphabsd_nat): Refactor as methods of
2332         alpha_bsd_nat_target.
2333         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
2334         (the_amd64_nbsd_nat_target): New.
2335         (_initialize_amd64nbsd_nat): Adjust to C++ification.
2336         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
2337         (the_amd64_obsd_nat_target): New.
2338         (_initialize_amd64obsd_nat): Adjust to C++ification.
2339         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
2340         (the_arm_fbsd_nat_target): New.
2341         (arm_fbsd_fetch_inferior_registers)
2342         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
2343         (_initialize_arm_fbsd_nat): Refactor as methods of
2344         arm_fbsd_nat_target.
2345         (_initialize_arm_fbsd_nat): Adjust to C++ification.
2346         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
2347         (the_arm_netbsd_nat_target): New.
2348         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
2349         arm_netbsd_nat_target.
2350         (_initialize_arm_netbsd_nat): Adjust to C++ification.
2351         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
2352         (the_hppa_nbsd_nat_target): New.
2353         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
2354         hppa_nbsd_nat_target methods.
2355         (_initialize_hppanbsd_nat): Adjust to C++ification.
2356         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
2357         (the_hppa_obsd_nat_target): New.
2358         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
2359         methods of hppa_obsd_nat_target.
2360         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
2361         add_target.
2362         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
2363         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
2364         add_target.
2365         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
2366         (_initialize_i386obsd_nat): Use add_target.
2367         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
2368         (the_m68k_bsd_nat_target): New.
2369         (m68kbsd_fetch_inferior_registers)
2370         (m68kbsd_store_inferior_registers): Refactor as methods of
2371         m68k_bsd_nat_target.
2372         (_initialize_m68kbsd_nat): Adjust to C++ification.
2373         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
2374         (the_mips_fbsd_nat_target): New.
2375         (mips_fbsd_fetch_inferior_registers)
2376         (mips_fbsd_store_inferior_registers): Refactor as methods of
2377         mips_fbsd_nat_target.
2378         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
2379         add_target.
2380         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
2381         (the_mips_nbsd_nat_target): New.
2382         (mipsnbsd_fetch_inferior_registers)
2383         (mipsnbsd_store_inferior_registers): Refactor as methods of
2384         mips_nbsd_nat_target.
2385         (_initialize_mipsnbsd_nat): Adjust to C++ification.
2386         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
2387         (the_mips64_obsd_nat_target): New.
2388         (mips64obsd_fetch_inferior_registers)
2389         (mips64obsd_store_inferior_registers): Refactor as methods of
2390         mips64_obsd_nat_target.
2391         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
2392         add_target.
2393         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
2394         nbsd_nat_target.
2395         * nbsd-nat.h: Include "inf-ptrace.h".
2396         (nbsd_nat_target): New class.
2397         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
2398         (obsd_wait): Refactor as methods of obsd_nat_target.
2399         (obsd_add_target): Delete.
2400         * obsd-nat.h: Include "inf-ptrace.h".
2401         (obsd_nat_target): New class.
2402         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
2403         (the_ppc_fbsd_nat_target): New.
2404         (ppcfbsd_fetch_inferior_registers)
2405         (ppcfbsd_store_inferior_registers): Refactor as methods of
2406         ppc_fbsd_nat_target.
2407         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
2408         add_target.
2409         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
2410         (the_ppc_nbsd_nat_target): New.
2411         (ppcnbsd_fetch_inferior_registers)
2412         (ppcnbsd_store_inferior_registers): Refactor as methods of
2413         ppc_nbsd_nat_target.
2414         (_initialize_ppcnbsd_nat): Adjust to C++ification.
2415         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
2416         (the_ppc_obsd_nat_target): New.
2417         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
2418         methods of ppc_obsd_nat_target.
2419         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
2420         add_target.
2421         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
2422         (the_sh_nbsd_nat_target): New.
2423         (shnbsd_fetch_inferior_registers)
2424         (shnbsd_store_inferior_registers): Refactor as methods of
2425         sh_nbsd_nat_target.
2426         (_initialize_shnbsd_nat): Adjust to C++ification.
2427         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
2428         (inf_ptrace_xfer_partial): Delete.
2429         (sparc_xfer_partial, sparc_target): Delete.
2430         * sparc-nat.h (sparc_fetch_inferior_registers)
2431         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
2432         (sparc_target): Delete function declaration.
2433         (sparc_target): New template class.
2434         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
2435         (_initialize_sparcnbsd_nat): Adjust to C++ification.
2436         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
2437         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
2438         add_target.
2439         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
2440         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
2441         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
2442         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
2443         add_target.
2444         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
2445         (the_vax_bsd_nat_target): New.
2446         (vaxbsd_fetch_inferior_registers)
2447         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
2448         methods.
2449         (_initialize_vaxbsd_nat): Adjust to C++ification.
2450
2451         * bsd-kvm.c (bsd_kvm_target): New class.
2452         (bsd_kvm_ops): Now a bsd_kvm_target.
2453         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
2454         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
2455         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
2456         bsd_kvm_target.
2457         (bsd_kvm_return_one): Delete.
2458         (bsd_kvm_add_target): Adjust to C++ification.
2459
2460         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
2461         (nto_procfs_target_procfs): New classes.
2462         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
2463         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
2464         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
2465         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
2466         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
2467         (procfs_remove_hw_breakpoint, procfs_resume)
2468         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
2469         (procfs_kill_inferior, procfs_store_registers)
2470         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
2471         as methods of nto_procfs_target.
2472         (nto_procfs_ops): Now an nto_procfs_target_procfs.
2473         (nto_native_ops): Delete.
2474         (procfs_open, procfs_native_open): Delete.
2475         (nto_native_ops): Now an nto_procfs_target_native.
2476         (init_procfs_targets): Adjust to C++ification.
2477         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
2478         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
2479         Refactor as methods of nto_procfs_target.
2480
2481         * go32-nat.c (go32_nat_target): New class.
2482         (the_go32_nat_target): New.
2483         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
2484         (go32_store_registers, go32_xfer_partial, go32_files_info)
2485         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
2486         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
2487         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
2488         (go32_pid_to_str): Refactor as methods of go32_nat_target.
2489         (go32_target): Delete.
2490         (_initialize_go32_nat): Adjust to C++ification.
2491
2492         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
2493         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
2494         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
2495         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
2496         gnu_nat_target.
2497         (gnu_target): Delete.
2498         * gnu-nat.h (gnu_target): Delete.
2499         (gnu_nat_target): New class.
2500         * i386-gnu-nat.c (gnu_base_target): New.
2501         (i386_gnu_nat_target): New class.
2502         (the_i386_gnu_nat_target): New.
2503         (_initialize_i386gnu_nat): Adjust to C++ification.
2504
2505 2018-05-02  Pedro Alves  <palves@redhat.com>
2506
2507         * bfd-target.c (target_bfd_xclose): Rename to ...
2508         (target_bfd_close): ... this.
2509         (target_bfd_reopen): Adjust.
2510         * target.c (target_close): Remove references to to_xclose.
2511         * target.h (target_ops::to_xclose): Delete.
2512         (target_ops::to_close): Update comments.
2513
2514 2018-05-02  Pedro Alves  <palves@redhat.com>
2515
2516         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
2517         "linux-nat.h".
2518         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
2519         * inf-ptrace.c (inf_ptrace_register_u_offset)
2520         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2521         (inf_ptrace_store_register, inf_ptrace_store_registers)
2522         (inf_ptrace_trad_target): Move to ...
2523         * linux-nat-trad.c: ... this new file.
2524         * linux-nat-trad.h: New file.
2525         * linux-nat.c (linux_target_install_ops): Make extern.
2526         (linux_trad_target): Delete.
2527         * linux-nat.h (linux_trad_target): Delete declaration.
2528         (linux_target_install_ops): Declare.
2529         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
2530         "linux-nat.h".
2531
2532 2018-05-02  Pedro Alves  <palves@redhat.com>
2533
2534         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2535         procfs_target/add_target here.
2536         * procfs.c (procfs_target): Make static.
2537         (_initialize_procfs): Call add_target here.
2538         * procfs.h (struct target_ops): Remove forward declaration.
2539         (procfs_target): Remove declaration.
2540         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
2541
2542 2018-05-02  Pedro Alves  <palves@redhat.com>
2543
2544         * procfs.c (procfs_stopped_by_watchpoint)
2545         (procfs_insert_watchpoint, procfs_remove_watchpoint)
2546         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
2547         Forward declare.
2548         (procfs_use_watchpoints): Delete, move contents...
2549         (procfs_target): ... here.
2550         * procfs.h (procfs_use_watchpoints): Delete declaration.
2551         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2552         procfs_use_watchpoints.
2553         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
2554         procfs_use_watchpoints.
2555
2556 2018-05-02  Tom Tromey  <tom@tromey.com>
2557
2558         PR python/20084:
2559         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
2560         and var_zuinteger_unlimited.
2561         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
2562         and PARAM_ZUINTEGER_UNLIMITED.
2563         (set_parameter_value): Handle var_zuinteger and
2564         var_zuinteger_unlimited.
2565         (add_setshow_generic): Likewise.
2566         (parmpy_init): Likewise.
2567
2568 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
2569
2570         PR rust/23124
2571         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
2572         pointer is not null before dereferencing it.
2573
2574 2018-04-30  Tom Tromey  <tom@tromey.com>
2575
2576         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
2577         is_mi_like_p.
2578
2579 2018-04-30  Tom Tromey  <tom@tromey.com>
2580
2581         * breakpoint.c (mention): Remove use of is_mi_like_p.
2582         (print_mention_ranged_breakpoint): Likewise.
2583         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
2584         of is_mi_like_p.
2585
2586 2018-04-30  Tom Tromey  <tom@tromey.com>
2587
2588         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
2589
2590 2018-04-30  Tom Tromey  <tom@tromey.com>
2591
2592         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
2593         (info_spu_event_command): Remove some uses of is_mi_like_p.
2594
2595 2018-04-30  Tom Tromey  <tom@tromey.com>
2596
2597         * python/py-framefilter.c (py_print_single_arg)
2598         (enumerate_locals, py_print_args, py_print_frame): Remove some
2599         uses of is_mi_like_p.
2600
2601 2018-04-30  Tom Tromey  <tom@tromey.com>
2602
2603         * ui-out.c: Update.
2604         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
2605         * ui-out.h (ui_out::is_mi_like_p): Now const.
2606         (ui_out::do_is_mi_like_p): Now const.
2607         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
2608
2609 2018-04-30  Tom Tromey  <tom@tromey.com>
2610
2611         * varobj.c (varobj_set_visualizer): Use new_reference.
2612         * python/python.c (gdbpy_decode_line): Use new_reference.
2613         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
2614         new_reference.
2615
2616 2018-04-30  Tom Tromey  <tom@tromey.com>
2617
2618         * varobj.c (install_new_value): Use new_reference.
2619         * value.h (value_incref): Return void.  Swap intro comment with
2620         value_decref.
2621         * value.c (set_value_parent): Use new_reference.
2622         (value_incref): Return void.  Update intro comment.
2623         (release_value): Use new_reference.
2624         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
2625
2626 2018-04-30  Tom Tromey  <tom@tromey.com>
2627
2628         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
2629         * gdb_bfd.h (new_bfd_ref): Remove.
2630         (gdb_bfd_open): Update comment.
2631         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
2632         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
2633         (gdb_bfd_fdopenr): Use new_reference.
2634         * exec.c (exec_file_attach): Use new_reference.
2635
2636 2018-04-30  Tom Tromey  <tom@tromey.com>
2637
2638         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
2639         method.
2640
2641 2018-04-30  Tom Tromey  <tom@tromey.com>
2642
2643         * jit.c (jit_read_code_entry): Use type_align.
2644         * i386-tdep.c (i386_gdbarch_init): Don't call
2645         set_gdbarch_long_long_align_bit.
2646         * gdbarch.sh: Remove long_long_align_bit.
2647         * gdbarch.c, gdbarch.h: Rebuild.
2648         * arc-tdep.c (arc_type_align): New function.
2649         (arc_gdbarch_init): Use arc_type_align.  Don't call
2650         set_gdbarch_long_long_align_bit.
2651
2652 2018-04-30  Tom Tromey  <tom@tromey.com>
2653
2654         * rust-lang.c (rust_type_alignment): Remove.
2655         (rust_composite_type): Use type_align.
2656
2657 2018-04-30  Tom Tromey  <tom@tromey.com>
2658
2659         * NEWS: Mention Type.align.
2660         * python/py-type.c (typy_get_alignof): New function.
2661         (type_object_getset): Add "alignof".
2662
2663 2018-04-30  Tom Tromey  <tom@tromey.com>
2664
2665         PR exp/17095:
2666         * NEWS: Update.
2667         * std-operator.def (UNOP_ALIGNOF): New operator.
2668         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
2669         New.
2670         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
2671         * c-lang.c (c_op_print_tab): Add alignof.
2672         * c-exp.y (ALIGNOF): New token.
2673         (exp): Add "ALIGNOF" production.
2674         (ident_tokens): Add _Alignof and alignof.
2675
2676 2018-04-30  Tom Tromey  <tom@tromey.com>
2677
2678         * i386-tdep.c (i386_type_align): New function.
2679         (i386_gdbarch_init): Update.
2680         * gdbarch.sh (type_align): New method.
2681         * gdbarch.c, gdbarch.h: Rebuild.
2682         * arch-utils.h (default_type_align): Declare.
2683         * arch-utils.c (default_type_align): New function.
2684         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
2685         (struct type) <align_log2>: New field.
2686         <instance_flags>: Now a bitfield.
2687         (TYPE_RAW_ALIGN): New macro.
2688         (type_align, type_raw_align, set_type_align): Declare.
2689         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
2690         functions.
2691         * dwarf2read.c (quirk_rust_enum): Set type alignment.
2692         (get_alignment, maybe_set_alignment): New functions.
2693         (read_structure_type, read_enumeration_type, read_array_type)
2694         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
2695         (read_subrange_type, read_base_type): Set type alignment.
2696
2697 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
2698
2699         * dwarf2read.c (read_index_from_section): Use bool.
2700
2701 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
2702
2703         PR gdb/22950
2704         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
2705         with #ifdef.
2706
2707 2018-04-29  John Reiser  <jreiser@BitWagon.com>
2708
2709         PR build/22873
2710         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
2711         last step, and do it atomically.
2712
2713 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
2714
2715         * compile/compile-c-types.c (convert_int, convert_float):
2716         Update for C FE v1.
2717
2718 2018-04-27  Tom Tromey  <tom@tromey.com>
2719
2720         PR rust/22545:
2721         * rust-lang.c (rust_inclusive_range_type_p): New function.
2722         (rust_range): Handle inclusive ranges.
2723         (rust_compute_range): Likewise.
2724         * rust-exp.y (struct rust_op) <inclusive>: New field.
2725         (DOTDOTEQ): New constant.
2726         (range_expr): Add "..=" productions.
2727         (operator_tokens): Add "..=" token.
2728         (ast_range): Add "inclusive" parameter.
2729         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
2730         ranges.
2731         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
2732         bounds values.
2733         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
2734         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
2735         Update comments.
2736         * expprint.c (print_subexp_standard): Handle new bounds values.
2737         (dump_subexp_body_standard): Likewise.
2738
2739 2018-04-27  Tom Tromey  <tom@tromey.com>
2740
2741         * configure: Rebuild.
2742         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
2743         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
2744         "OVERRIDE".
2745         (class symbol_needs_eval_context): Likewise.
2746         * dwarf2read.c (mock_mapped_index::symbol_name_count)
2747         (mock_mapped_index::symbol_name_at): Use "override".  Remove
2748         "virtual".
2749         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
2750         "override".
2751         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
2752         * aarch64-tdep.c (instruction_reader::read): Use "override".
2753         (instruction_reader_test::read): Likewise.
2754         * arm-tdep.c (instruction_reader::read): Use "override".
2755         (instruction_reader_thumb::read): Likewise.
2756
2757 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
2758
2759         PR remote/9665
2760         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
2761         instead of remote_send.
2762         (remote_send): Remove.
2763
2764 2018-04-26  Pedro Alves  <palves@redhat.com>
2765
2766         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
2767         find_function_start_sal instead of find_pc_line.
2768
2769 2018-04-26  Pedro Alves  <palves@redhat.com>
2770
2771         * breakpoint.c (set_breakpoint_location_function): Handle
2772         mst_data_gnu_ifunc.
2773         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
2774         * elfread.c (elf_symtab_read): Give data symbols with
2775         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
2776         (elf_rel_plt_read): Update comment.
2777         * linespec.c (convert_linespec_to_sals): Handle
2778         mst_data_gnu_ifunc.
2779         (minsym_found): Handle mst_data_gnu_ifunc.
2780         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
2781         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
2782         * parse.c (find_minsym_type_and_address): Handle
2783         mst_data_gnu_ifunc.
2784         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
2785         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
2786         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
2787         comment.
2788         <mst_data_gnu_ifunc>: New enumerator.
2789
2790 2018-04-26  Pedro Alves  <palves@redhat.com>
2791
2792         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
2793         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
2794         'want_trampoline' parameter by a lookup_msym_prefer parameter.
2795         Handle it.
2796         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
2797         (lookup_minimal_symbol_by_pc): Adjust.
2798         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
2799         (lookup_solib_trampoline_symbol_by_pc): Adjust.
2800         * minsyms.h (lookup_msym_prefer): New enum.
2801         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
2802         parameter by a lookup_msym_prefer parameter.
2803
2804 2018-04-26  Pedro Alves  <palves@redhat.com>
2805
2806         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
2807         ends in "@plt" instead of looking at the symbol's section.
2808
2809 2018-04-26  Pedro Alves  <palves@redhat.com>
2810
2811         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
2812         all references.
2813         (find_pc_partial_function_gnu_ifunc): Rename to ...
2814         (find_pc_partial_function): ... this, and remove references to
2815         'is_gnu_ifunc_p'.
2816         (find_pc_partial_function): Delete old implementation.
2817         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
2818
2819 2018-04-26  Pedro Alves  <palves@redhat.com>
2820
2821         * linespec.c (struct bound_minimal_symbol_search_key): New.
2822         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
2823         skip first line if we found a GNU ifunc minimal symbol by name.
2824         (compare_msymbols): Change parameters to work with a destructured
2825         lhs minsym.
2826         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
2827         functions.
2828
2829 2018-04-26  Pedro Alves  <palves@redhat.com>
2830
2831         * breakpoint.c (set_breakpoint_location_function): Don't resolve
2832         ifunc targets here.  Instead, if we have an ifunc minsym, use its
2833         address/name.
2834         (add_location_to_breakpoint): Store the minsym and the objfile in
2835         the breakpoint location.
2836         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
2837         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
2838         Record the minsym in the sal.
2839         * symtab.h (symtab_and_line) <msymbol>: New field.
2840
2841 2018-04-26  Pedro Alves  <palves@redhat.com>
2842
2843         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
2844         unless we actually resolved the ifunc.
2845
2846 2018-04-26  Pedro Alves  <palves@redhat.com>
2847
2848         * c-exp.y (variable production): Prefer ifunc minsyms over
2849         regular function symbols.
2850         * symtab.c (find_gnu_ifunc): New function.
2851         * minsyms.h (lookup_msym_prefer): New enum.
2852         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
2853         parameter by a lookup_msym_prefer parameter.
2854         * symtab.h (find_gnu_ifunc): New declaration.
2855
2856 2018-04-26  Pedro Alves  <palves@redhat.com>
2857
2858         * blockframe.c (find_gnu_ifunc_target_type): New function.
2859         (find_function_type): New.
2860         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
2861         return a value with a memory address.
2862         (eval_call): For calls to GNU ifunc functions, try to find the
2863         type of the target function from the type that the resolver
2864         returns.
2865         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
2866         symbols.
2867         * infcall.c (find_function_return_type): Delete.
2868         (find_function_addr): Add 'function_type' parameter.  For calls to
2869         GNU ifunc functions, try to find the type of the target function
2870         from the type that the resolver returns, and return it via
2871         FUNCTION_TYPE.
2872         (call_function_by_hand_dummy): Adjust to use the function type
2873         returned by find_function_addr.
2874         (find_function_addr): Add 'function_type' parameter and move
2875         description here.
2876         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
2877         declarations.
2878
2879 2018-04-26  Pedro Alves  <palves@redhat.com>
2880
2881         * c-exp.y (variable production): Skip finding an alias for ifunc
2882         symbols.
2883
2884 2018-04-26  Pedro Alves  <palves@redhat.com>
2885
2886         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
2887
2888 2018-04-25  Pedro Alves  <palves@redhat.com>
2889
2890         * infcmd.c (kill_command): Print the pid as string, not the whole
2891         thread's ptid.  Add comment.  s/has been killed/killed/ in output
2892         message.
2893         * remote.c (remote_detach_1): Print the pid as string, not the
2894         whole thread's ptid.
2895
2896 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
2897             Sergio Durigan Junior  <sergiodj@redhat.com>
2898             Pedro Alves  <palves@redhat.com>
2899
2900         * infcmd.c (kill_command): Print message when inferior has
2901         been killed.
2902         * inferior.c (print_inferior_events): Remove 'static'.  Set as
2903         '1'.
2904         (add_inferior): Improve message printed when
2905         'print_inferior_events' is on.
2906         (exit_inferior): Remove message printed when
2907         'print_inferior_events' is on.
2908         (detach_inferior): Improve message printed when
2909         'print_inferior_events' is on.
2910         (initialize_inferiors): Use 'add_inferior_silent' to set
2911         'current_inferior_'.
2912         * inferior.h (print_inferior_events): Declare here as
2913         'extern'.
2914         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
2915         '[Detaching...]' messages when 'print_inferior_events' is on.
2916         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
2917         as prefix/suffix for messages.  Remove periods.  Fix erroneous
2918         'Detaching after fork from child...', replace it by '... from
2919         parent...'.
2920         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
2921         prefix/suffix when printing 'Detaching...' messages.  Print
2922         them when 'print_inferior_events' is on.
2923         * remote.c (remote_detach_1): Print message when detaching
2924         from inferior and '!is_fork_parent'.
2925
2926 2018-04-24  Tom Tromey  <tom@tromey.com>
2927
2928         * cli-out.h: Reindent.
2929
2930 2018-04-24  Tom Tromey  <tom@tromey.com>
2931
2932         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
2933         (cli_ui_out::do_field_string): Use fputs_filtered.
2934         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
2935
2936 2018-04-23  Tom Tromey  <tom@tromey.com>
2937
2938         * guile/scm-frame.c (gdbscm_frame_read_var): Use
2939         gdb::unique_xmalloc_ptr.
2940
2941 2018-04-23  Tom Tromey  <tom@tromey.com>
2942
2943         * configure: Rebuild.
2944
2945 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
2946
2947         PR gdb/23095
2948         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
2949         prepare_for_testing.  Set normal_bp to r_debug_state if target
2950         is bsd.
2951
2952 2018-04-21  Pedro Alves  <palves@redhat.com>
2953             Rajendra SY  <rajendra.sy@gmail.com>
2954
2955         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
2956         * remote.c (extended_remote_attach): In all-stop mode, mark the
2957         thread as executing.
2958
2959 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2960
2961         * thread.c (thread_apply_all_command): Fix comment.
2962         (thread_command): Fix comment.
2963
2964 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
2965
2966         * common/tdesc.h (tdesc_create_feature): Remove xml filename
2967         parameter.
2968         * features/aarch64-core.c (create_feature_aarch64_core):
2969         Regenerate.
2970         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
2971         Likewise.
2972         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
2973         Likewise.
2974         * features/i386/32bit-avx512.c
2975         (create_feature_i386_32bit_avx512): Likewise.
2976         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
2977         Likewise.
2978         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
2979         Likewise.
2980         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
2981         Likewise.
2982         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
2983         Likewise.
2984         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
2985         Likewise.
2986         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
2987         Likewise.
2988         * features/i386/64bit-avx512.c
2989         (create_feature_i386_64bit_avx512): Likewise.
2990         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
2991         Likewise.
2992         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
2993         Likewise.
2994         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
2995         Likewise.
2996         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
2997         Likewise.
2998         * features/i386/64bit-segments.c
2999         (create_feature_i386_64bit_segments): Likewise.
3000         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
3001         Likewise.
3002         * features/i386/x32-core.c
3003         (create_feature_i386_x32_core): Likewise.
3004         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
3005         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
3006         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
3007         * target-descriptions.c: In generated code, don't pass xml
3008         filename.
3009
3010 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3011
3012         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
3013         (print_xml_feature::visit_post): Likewise.
3014         (print_xml_feature::visit): Likewise.
3015         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
3016         (print_xml_feature): Add new class.
3017         * regformats/regdat.sh: Null xmltarget on feature targets.
3018         * target-descriptions.c (struct target_desc): Add xmltarget.
3019         (maintenance_check_tdesc_xml_convert): Add unittest function.
3020         (tdesc_get_features_xml): Add function to get xml.
3021         (maintenance_check_xml_descriptions): Test xml generation.
3022         * xml-tdesc.c (string_read_description_xml): Add function.
3023         * xml-tdesc.h (string_read_description_xml): Add declaration.
3024
3025 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3026
3027         * features/Makefile: Add feature marker to targets with new style
3028         target descriptions.
3029         * regformats/aarch64.dat: Regenerate.
3030         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
3031         * regformats/i386/amd64-avx-linux.dat: Likewise.
3032         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
3033         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
3034         * regformats/i386/amd64-linux.dat: Likewise.
3035         * regformats/i386/amd64-mpx-linux.dat: Likewise.
3036         * regformats/i386/amd64.dat: Likewise.
3037         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
3038         * regformats/i386/i386-avx-linux.dat: Likewise.
3039         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
3040         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
3041         * regformats/i386/i386-linux.dat: Likewise.
3042         * regformats/i386/i386-mmx-linux.dat: Likewise.
3043         * regformats/i386/i386-mpx-linux.dat: Likewise.
3044         * regformats/i386/i386.dat: Likewise.
3045         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
3046         * regformats/i386/x32-avx-linux.dat: Likewise.
3047         * regformats/i386/x32-linux.dat: Likewise.
3048         * regformats/tic6x-c62x-linux.dat: Likewise.
3049         * regformats/tic6x-c64x-linux.dat: Likewise.
3050         * regformats/tic6x-c64xp-linux.dat: Likewise.
3051         * regformats/regdat.sh: Parse feature marker.
3052
3053 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3054
3055         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
3056         (tdesc_osabi_name): Likewise.
3057         * target-descriptions.c (tdesc_architecture_name): Add new
3058         function.
3059         (tdesc_osabi_name): Likewise.
3060
3061 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3062
3063         * common/tdesc.c (tdesc_predefined_type): Move to here.
3064         (tdesc_named_type): Likewise.
3065         (tdesc_create_vector): Likewise.
3066         (tdesc_create_struct): Likewise.
3067         (tdesc_set_struct_size): Likewise.
3068         (tdesc_create_union): Likewise.
3069         (tdesc_create_flags): Likewise.
3070         (tdesc_create_enum): Likewise.
3071         (tdesc_add_field): Likewise.
3072         (tdesc_add_typed_bitfield): Likewise.
3073         (tdesc_add_bitfield): Likewise.
3074         (tdesc_add_flag): Likewise.
3075         (tdesc_add_enum_value): Likewise.
3076         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
3077         (struct tdesc_type_vector): Likewise.
3078         (struct tdesc_type_field): Likewise.
3079         (struct tdesc_type_with_fields): Likewise.
3080         (tdesc_create_enum): Add declaration.
3081         (tdesc_add_typed_bitfield): Likewise.
3082         (tdesc_add_enum_value): Likewise.
3083         * target-descriptions.c (tdesc_type_field): Move from here.
3084         (tdesc_type_builtin): Likewise.
3085         (tdesc_type_vector): Likewise.
3086         (tdesc_type_with_fields): Likewise.
3087         (tdesc_predefined_types): Likewise.
3088         (tdesc_named_type): Likewise.
3089         (tdesc_create_vector): Likewise.
3090         (tdesc_create_struct): Likewise.
3091         (tdesc_set_struct_size): Likewise.
3092         (tdesc_create_union): Likewise.
3093         (tdesc_create_flags): Likewise.
3094         (tdesc_create_enum): Likewise.
3095         (tdesc_add_field): Likewise.
3096         (tdesc_add_typed_bitfield): Likewise.
3097         (tdesc_add_bitfield): Likewise.
3098         (tdesc_add_flag): Likewise.
3099         (tdesc_add_enum_value): Likewise.
3100         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
3101         (tdesc_add_typed_bitfield): Likewise.
3102         (tdesc_add_enum_value): Likewise.
3103
3104 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3105
3106         * common/tdesc.c (tdesc_feature::accept): Move to here.
3107         (tdesc_feature::operator==): Likewise.
3108         (tdesc_create_reg): Likewise.
3109         * common/tdesc.h (tdesc_type_kind): Likewise.
3110         (struct tdesc_type): Likewise.
3111         (struct tdesc_feature): Likewise.
3112         * regformats/regdat.sh: Create a feature.
3113         * target-descriptions.c (tdesc_type_kind): Move from here.
3114         (tdesc_type): Likewise.
3115         (tdesc_type_up): Likewise.
3116         (tdesc_feature): Likewise.
3117         (tdesc_create_reg): Likewise.
3118
3119 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3120
3121         * Makefile.in: Add arch/tdesc.c
3122         * common/tdesc.c: New file.
3123         * common/tdesc.h (tdesc_element_visitor): Move to here.
3124         (tdesc_element): Likewise.
3125         (tdesc_reg): Likewise.
3126         (tdesc_reg_up): Likewise.
3127         * regformats/regdef.h (reg): Add offset to constructors.
3128         * target-descriptions.c (tdesc_element_visitor): Move from here.
3129         (tdesc_element): Likewise.
3130         (tdesc_reg): Likewise.
3131         (tdesc_reg_up): Likewise.
3132
3133 2018-04-17  Tom Tromey  <tom@tromey.com>
3134
3135         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
3136         discriminant field.
3137
3138 2018-04-17  Tom Tromey  <tom@tromey.com>
3139
3140         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
3141
3142 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3143
3144         * symtab.c (print_symbol_info): Skip printing filename and line
3145         number when `last' is NULL.
3146         (symtab_symbol_info): Use empty string instead of NULL for first
3147         invocation of print_symbol_info.
3148         (rbreak_command): Pass NULL to `last' parameter of
3149         print_symbol_info.
3150
3151 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
3152
3153         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
3154         instead of nullptr.
3155
3156 2018-04-16  Pedro Alves  <palves@redhat.com>
3157
3158         * MAINTAINERS (sh): Remove.
3159         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
3160         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
3161         (ALLDEPFILES): Remove sh64-tdep.c.
3162         * NEWS: Mentions that support for SH-5/SH64 is removed.
3163         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
3164         (sh*-*-openbsd*): Ditto.
3165         (sh64-*-elf*): Remove.
3166         (sh*): Remove.
3167         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
3168         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
3169         * sh-tdep.c: No longer include "sh64-tdep.h".
3170         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
3171         * sh64-tdep.c, sh64-tdep.h: Remove files.
3172
3173 2018-04-16  Pedro Alves  <palves@redhat.com>
3174
3175         * MAINTAINERS: Remove m88k.
3176         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
3177         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
3178         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
3179         * NEWS: Mention that support for m88k was removed.
3180         * configure.host (m88*-*-*): Remove support.
3181         * configure.nat (m88k-*-*): Remove support.
3182         * configure.tgt (m88*-*-openbsd*): Remove.
3183         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
3184
3185 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
3186
3187         * configure.tgt (x86_tobjs): New variable.
3188         (amd64_tobjs, i386_tobjs): Use it.
3189
3190 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3191
3192         * symtab.c (print_symbol_info): Precede the symbol definition by
3193         the line number when available.
3194         * NEWS: Advertise this enhancement.
3195
3196 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3197
3198         * NEWS (New options): announce set/show record btrace cpu.
3199         * btrace.c: Include record-btrace.h.
3200         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
3201         the vendor is unknown.
3202         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
3203         Maybe overwrite the btrace configuration's cpu.
3204         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
3205         (btrace_fetch): Add cpu parameter.  Update callers.
3206         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
3207         Maybe overwrite the btrace configuration's cpu.  Skip enabling
3208         errata workarounds if the vendor is unknown.
3209         * python/py-record-btrace.c: Include record-btrace.h.
3210         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
3211         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
3212         * record-btrace.c (record_btrace_cpu_state_kind): New.
3213         (record_btrace_cpu): New.
3214         (set_record_btrace_cpu_cmdlist): New.
3215         (record_btrace_get_cpu): New.
3216         (require_btrace_thread, record_btrace_info)
3217         (record_btrace_resume_thread): Call record_btrace_get_cpu.
3218         (cmd_set_record_btrace_cpu_none): New.
3219         (cmd_set_record_btrace_cpu_auto): New.
3220         (cmd_set_record_btrace_cpu): New.
3221         (cmd_show_record_btrace_cpu): New.
3222         (_initialize_record_btrace): Initialize set/show record btrace cpu
3223         commands.
3224         * record-btrace.h (record_btrace_get_cpu): New.
3225
3226 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3227
3228         * record.c (set_record_command): Fix typo in message.
3229
3230 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3231
3232         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
3233
3234 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3235
3236         * infrun.c (process_event_stop_test): Call
3237         gdbarch_in_indirect_branch_thunk.
3238         * gdbarch.sh (in_indirect_branch_thunk): New.
3239         * gdbarch.c: Regenerated.
3240         * gdbarch.h: Regenerated.
3241         * x86-tdep.h: New.
3242         * x86-tdep.c: New.
3243         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
3244         (HFILES_NO_SRCDIR): Add x86-tdep.h.
3245         (ALLDEPFILES): Add x86-tdep.c.
3246         * arch-utils.h (default_in_indirect_branch_thunk): New.
3247         * arch-utils.c (default_in_indirect_branch_thunk): New.
3248         * i386-tdep: Include x86-tdep.h.
3249         (i386_in_indirect_branch_thunk): New.
3250         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
3251         function.
3252         * amd64-tdep: Include x86-tdep.h.
3253         (amd64_in_indirect_branch_thunk): New.
3254         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
3255
3256 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
3257
3258         PR gdb/23053
3259         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
3260         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
3261         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
3262         regression.
3263
3264 2018-04-12  Tom Tromey  <tom@tromey.com>
3265
3266         * rust-lang.c (rust_print_struct_def): Remove univariant code.
3267         (rust_evaluate_subexp): Likewise.
3268
3269 2018-04-12  Pedro Alves  <palves@redhat.com>
3270
3271         * procfs.c (procfs_detach): Make forward declaration's prototype
3272         match definition's protototype.
3273         (proc_get_LDT_entry): Remove stale do_cleanups call.
3274
3275 2018-04-12  Pedro Alves  <palves@redhat.com>
3276
3277         * target.h (target_ops::to_has_exited): Delete.
3278         (target_has_exited): Delete.
3279         * target-delegates.c: Regenerate.
3280
3281 2018-04-11  Pedro Alves  <palves@redhat.com>
3282
3283         * target.c (fileio_fh_t::t): Add comment.
3284         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3285         (target_fileio_close): Handle a NULL target.
3286         (invalidate_fileio_fh): New.
3287         (target_close): Call it.
3288         * remote.c (remote_hostio_send_command): No longer check whether
3289         remote_desc is open.
3290
3291 2018-04-11  Pedro Alves  <palves@redhat.com>
3292
3293         * target.c (fileio_fh_t): Make it a named struct instead of a
3294         typedef.
3295         (fileio_fh_t::is_closed): New method.
3296         (DEF_VEC_O (fileio_fh_t)): Remove.
3297         (fileio_fhandles): Now a std::vector.
3298         (is_closed_fileio_fh): Delete.
3299         (acquire_fileio_fd): Adjust.  Rename parameters.
3300         (release_fileio_fd): Adjust.
3301         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
3302         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3303         (target_fileio_close): Adjust.
3304
3305 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
3306
3307         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
3308         index.
3309
3310 2018-04-10  Pedro Alves  <palves@redhat.com>
3311
3312         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
3313         (scoped_finish_thread_state): New class.
3314         * infcmd.c (run_command_1): Use it instead of finish_thread_state
3315         cleanup.
3316         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
3317         (fetch_inferior_event, normal_stop): Likewise.
3318         * thread.c (finish_thread_state_cleanup): Delete.
3319
3320 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3321             Pedro Alves  <palves@redhat.com>
3322
3323         * value.c: Include "selftest.h" and "common/array-view.h".
3324         (struct range) <operator ==>: New.
3325         (test_ranges_contain): New.
3326         (check_ranges_vector): New.
3327         (test_insert_into_bit_range_vector): New.
3328         (_initialize_values): Register selftests.
3329         * common/array-view.h (operator==, operator!=): New.
3330
3331 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3332
3333         * common/gdb_vecs.h (unordered_remove): Add overload that takes
3334         an iterator.
3335         * inline-frame.c: Include <algorithm>.
3336         (struct inline_state): Add constructor.
3337         (inline_state_s): Remove.
3338         (DEF_VEC_O(inline_state_s)): Remove.
3339         (inline_states): Change type to std::vector.
3340         (find_inline_frame_state): Adjust to std::vector.
3341         (allocate_inline_frame_state): Remove.
3342         (clear_inline_frame_state): Adjust to std::vector.
3343         (skip_inline_frames): Adjust to std::vector.
3344
3345 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3346
3347         * tracepoint.h (struct trace_state_variable): Add constructor.
3348         <name>: Change type to std::string.
3349         * tracepoint.c (tsv_s): Remove.
3350         (DEF_VEC_O(tsv_s)): Remove.
3351         (tvariables): Change to std::vector.
3352         (create_trace_state_variable): Adjust to std::vector.
3353         (find_trace_state_variable): Likewise.
3354         (find_trace_state_variable_by_number): Likewise.
3355         (delete_trace_state_variable): Likewise.
3356         (trace_variable_command): Adjust to std::string.
3357         (delete_trace_variable_command): Likewise.
3358         (tvariables_info_1): Adjust to std::vector.
3359         (save_trace_state_variables): Likewise.
3360         (start_tracing): Likewise.
3361         (merge_uploaded_trace_state_variables): Adjust to std::vector
3362         and std::string.
3363         * target.h (struct target_ops)
3364         <to_download_trace_state_variable>: Pass reference to
3365         trace_state_variable.
3366         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
3367         * target-delegates.c: Re-generate.
3368         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
3369         (mi_tsv_deleted): Likewise.
3370         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
3371         * remote.c (remote_download_trace_state_variable): Change
3372         pointer to reference and adjust.
3373         * make-target-delegates (parse_argtypes): Handle references.
3374         (write_function_header): Likewise.
3375         (munge_type): Likewise.
3376
3377 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3378
3379         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3380         string_view-selftests.c.
3381         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
3382         testsuite.
3383         * unittests/basic_string_view/cons/char/1.cc: Likewise.
3384         * unittests/basic_string_view/cons/char/2.cc: Likewise.
3385         * unittests/basic_string_view/cons/char/3.cc: Likewise.
3386         * unittests/basic_string_view/element_access/char/1.cc:
3387         Likewise.
3388         * unittests/basic_string_view/element_access/char/empty.cc:
3389         Likewise.
3390         * unittests/basic_string_view/element_access/char/front_back.cc:
3391         Likewise.
3392         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
3393         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
3394         Likewise.
3395         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
3396         Likewise.
3397         * unittests/basic_string_view/modifiers/swap/char/1.cc:
3398         Likewise.
3399         * unittests/basic_string_view/operations/compare/char/1.cc:
3400         Likewise.
3401         * unittests/basic_string_view/operations/compare/char/13650.cc:
3402         Likewise.
3403         * unittests/basic_string_view/operations/copy/char/1.cc:
3404         Likewise.
3405         * unittests/basic_string_view/operations/data/char/1.cc:
3406         Likewise.
3407         * unittests/basic_string_view/operations/find/char/1.cc:
3408         Likewise.
3409         * unittests/basic_string_view/operations/find/char/2.cc:
3410         Likewise.
3411         * unittests/basic_string_view/operations/find/char/3.cc:
3412         Likewise.
3413         * unittests/basic_string_view/operations/find/char/4.cc:
3414         Likewise.
3415         * unittests/basic_string_view/operations/rfind/char/1.cc:
3416         Likewise.
3417         * unittests/basic_string_view/operations/rfind/char/2.cc:
3418         Likewise.
3419         * unittests/basic_string_view/operations/rfind/char/3.cc:
3420         Likewise.
3421         * unittests/basic_string_view/operations/substr/char/1.cc:
3422         Likewise.
3423         * unittests/basic_string_view/operators/char/2.cc: Likewise.
3424         * unittests/string_view-selftests.c: New file.
3425
3426 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3427
3428         * unittests/basic_string_view/capacity/1.cc: New file.
3429         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
3430         * unittests/basic_string_view/cons/char/1.cc: New file.
3431         * unittests/basic_string_view/cons/char/2.cc: New file.
3432         * unittests/basic_string_view/cons/char/3.cc: New file.
3433         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
3434         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
3435         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
3436         * unittests/basic_string_view/element_access/char/1.cc: New file.
3437         * unittests/basic_string_view/element_access/char/2.cc: New file.
3438         * unittests/basic_string_view/element_access/char/empty.cc: New file.
3439         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
3440         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
3441         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
3442         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
3443         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
3444         * unittests/basic_string_view/include.cc: New file.
3445         * unittests/basic_string_view/inserters/char/1.cc: New file.
3446         * unittests/basic_string_view/inserters/char/2.cc: New file.
3447         * unittests/basic_string_view/inserters/char/3.cc: New file.
3448         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
3449         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
3450         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
3451         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
3452         * unittests/basic_string_view/literals/types.cc: New file.
3453         * unittests/basic_string_view/literals/values.cc: New file.
3454         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
3455         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
3456         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
3457         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
3458         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
3459         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
3460         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
3461         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
3462         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
3463         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
3464         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
3465         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
3466         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
3467         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
3468         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
3469         * unittests/basic_string_view/operations/data/char/1.cc: New file.
3470         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
3471         * unittests/basic_string_view/operations/find/char/1.cc: New file.
3472         * unittests/basic_string_view/operations/find/char/2.cc: New file.
3473         * unittests/basic_string_view/operations/find/char/3.cc: New file.
3474         * unittests/basic_string_view/operations/find/char/4.cc: New file.
3475         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
3476         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
3477         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
3478         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
3479         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
3480         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
3481         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
3482         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
3483         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
3484         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
3485         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
3486         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
3487         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
3488         * unittests/basic_string_view/operators/char/2.cc: New file.
3489         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
3490         * unittests/basic_string_view/range_access/char/1.cc: New file.
3491         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
3492         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
3493         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
3494         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
3495         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
3496         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
3497         * unittests/basic_string_view/requirements/typedefs.cc: New file.
3498         * unittests/basic_string_view/typedefs.cc: New file.
3499         * unittests/basic_string_view/types/1.cc: New file.
3500
3501 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3502
3503         * common/gdb_string_view.h: Remove libstdc++ implementation
3504         details, adjust to gdb reality.
3505         * common/gdb_string_view.tcc: Likewise.
3506         * cli/cli-script.c (struct string_view): Remove.
3507         (user_args) <m_args>: Change element type to gdb::string_view.
3508         (user_args::insert_args): Adjust.
3509
3510 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3511
3512         * common/gdb_string_view.h: New file.
3513         * common/gdb_string_view.tcc: New file.
3514
3515 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3516
3517         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
3518         * configure: Re-generate.
3519
3520 2018-04-09  Pedro Alves  <palves@redhat.com>
3521
3522         * gdbarch.sh: Include "observable.h" instead of "observer.h".
3523         (set_target_gdbarch): Call
3524         gdb::observers::architecture_changed.notify instead of
3525         observer_notify_architecture_changed.
3526
3527 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3528
3529         * tracepoint.c (struct current_traceframe_cleanup): Remove.
3530         (do_restore_current_traceframe_cleanup): Remove.
3531         (restore_current_traceframe_cleanup_dtor): Remove.
3532         (make_cleanup_restore_current_traceframe): Remove.
3533         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
3534         New.
3535         * tracepoint.h (struct scoped_restore_current_traceframe): New.
3536         * infrun.c (fetch_inferior_event): Use
3537         scoped_restore_current_traceframe.
3538
3539 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3540
3541         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
3542         Remove.
3543         <n_allocated_type_units>: Remove.
3544         <all_type_units>: Change to std::vector.
3545         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3546         to std::vector change.
3547         (dwarf2_per_objfile::get_cutu): Likewise.
3548         (dwarf2_per_objfile::get_tu): Likewise.
3549         (create_signatured_type_table_from_index): Likewise.
3550         (create_signatured_type_table_from_debug_names): Likewise.
3551         (dw2_symtab_iter_next): Likewise.
3552         (dw2_print_stats): Likewise.
3553         (dw2_expand_all_symtabs): Likewise.
3554         (dw2_expand_marked_cus): Likewise.
3555         (dw2_debug_names_iterator::next): Likewise.
3556         (dwarf2_initialize_objfile): Likewise.
3557         (add_signatured_type_cu_to_table): Likewise.
3558         (create_all_type_units): Likewise.
3559         (add_type_unit): Likewise.
3560         (struct tu_abbrev_offset): Add constructor.
3561         (build_type_psymtabs_1): Adjust to std::vector change.
3562         (print_tu_stats): Likewise.
3563         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3564         (write_debug_names): Likewise.
3565
3566 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3567
3568         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
3569         Make an std::vector.
3570         <n_comp_units>: Remove.
3571         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3572         to std::vector change.
3573         (dwarf2_per_objfile::get_cutu): Likewise.
3574         (dwarf2_per_objfile::get_cu): Likewise.
3575         (create_cus_from_index): Likewise.
3576         (create_addrmap_from_index): Likewise.
3577         (create_addrmap_from_aranges): Likewise.
3578         (dwarf2_read_index): Likewise.
3579         (dw2_find_last_source_symtab): Likewise.
3580         (dw2_map_symtabs_matching_filename): Likewise.
3581         (dw2_symtab_iter_next): Likewise.
3582         (dw2_print_stats): Likewise.
3583         (dw2_expand_all_symtabs): Likewise.
3584         (dw2_expand_symtabs_with_fullname): Likewise.
3585         (dw2_expand_marked_cus): Likewise.
3586         (dw2_map_symbol_filenames): Likewise.
3587         (create_cus_from_debug_names): Likewise.
3588         (dwarf2_read_debug_names): Likewise.
3589         (dw2_debug_names_iterator::next): Likewise.
3590         (dwarf2_initialize_objfile): Likewise.
3591         (set_partial_user): Likewise.
3592         (dwarf2_build_psymtabs_hard): Likewise.
3593         (read_comp_units_from_section): Remove arguments, adjust to
3594         std::vector change.
3595         (create_all_comp_units): Adjust to std::vector and
3596         read_comp_units_from_section changes.
3597         (dwarf2_find_containing_comp_unit): Adjust to std::vector
3598         change.
3599         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3600         (psyms_seen_size): Likewise.
3601         (write_gdbindex): Likewise.
3602         (write_debug_names): Likewise.
3603
3604 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3605
3606         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
3607         with dwarf2_per_objfile.
3608         (create_cus_from_index): Likewise.
3609         (create_signatured_type_table_from_index): Likewise.
3610         (dwarf2_read_index): Likewise.
3611         (dwarf2_initialize_objfile): Likewise.
3612         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
3613         per_cu rather than get_dwarf2_per_objfile.
3614
3615 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3616
3617         * dwarf2read.h (struct signatured_type): Forward declare.
3618         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
3619         New methods.
3620         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
3621         (dw2_get_cutu): ...this.
3622         (dwarf2_per_objfile::get_cu): Rename from...
3623         (dw2_get_cu): ...this.
3624         (dwarf2_per_objfile::get_tu): New.
3625         (create_addrmap_from_index): Adjust.
3626         (create_addrmap_from_aranges): Adjust.
3627         (dw2_find_last_source_symtab): Adjust.
3628         (dw2_map_symtabs_matching_filename): Adjust.
3629         (dw2_symtab_iter_next): Adjust.
3630         (dw2_print_stats): Adjust.
3631         (dw2_expand_all_symtabs): Adjust.
3632         (dw2_expand_symtabs_with_fullname): Adjust.
3633         (dw2_expand_marked_cus): Adjust.
3634         (dw_expand_symtabs_matching_file_matcher): Adjust.
3635         (dw2_map_symbol_filenames): Adjust.
3636         (dw2_debug_names_iterator::next): Adjust.
3637         (dwarf2_initialize_objfile): Adjust.
3638         (set_partial_user): Adjust.
3639         (dwarf2_build_psymtabs_hard): Adjust.
3640
3641 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3642
3643         * dwarf2read.c (create_signatured_type_table_from_debug_names):
3644         Remove unused variables.
3645         (dw2_map_symtabs_matching_filename): Likewise.
3646         (dwarf2_record_block_ranges): Likewise.
3647         (dwarf2_read_addr_index): Likewise.
3648         (follow_die_offset): Likewise.
3649
3650 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3651
3652         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
3653         to symbol_file_add_main.
3654
3655 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3656
3657         PR mi/22299
3658         * mi/mi-console.c (do_fputc_async_safe): New.
3659         (mi_console_file::write_async_safe): New.
3660         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
3661         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
3662         New.
3663         * ui-file.c (ui_file::putstrn): Adjust call to
3664         fputstrn_unfiltered.
3665         * utils.c (printchar): Replace do_fputs and do_fprintf
3666         parameters by do_fputc.
3667         (fputstr_filtered): Adjust call to printchar.
3668         (fputstr_unfiltered): Likewise.
3669         (fputstrn_filtered): Likewise.
3670         (fputstrn_unfiltered): Add do_fputc parameter, pass to
3671         printchar.
3672         * utils.h (do_fputc_ftype): New typedef.
3673         (fputstrn_unfiltered): Add do_fputc parameter.
3674
3675 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3676
3677         * regformats/i386/i386-avx.dat: Remove.
3678
3679 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3680
3681         PR gdb/22979
3682         * amd64-tdep.c (amd64_none_init_abi): New function.
3683         (amd64_x32_none_init_abi): New function.
3684         (_initialize_amd64_tdep): Register handlers for x86-64 and
3685         x64_32 with GDB_OSABI_NONE.
3686         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
3687         GDB_OSABI_NONE osabi.
3688
3689 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3690
3691         PR gdb/22980
3692         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
3693         GDB_OSABI_NONE.
3694         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
3695         * osabi.c (gdb_osabi_names): Add "unknown" entry.
3696
3697 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3698
3699         * common/byte-vector.h (char_vector): New type.
3700         * target.h (target_read_alloc): Return
3701         gdb::optional<byte_vector>.
3702         (target_read_stralloc): Return gdb::optional<char_vector>.
3703         (target_get_osdata): Return gdb::optional<char_vector>.
3704         * target.c (target_read_alloc_1): Templatize.  Replacement
3705         manual memory management with vector.
3706         (target_read_alloc): Change return type, adjust.
3707         (target_read_stralloc): Change return type, adjust.
3708         (target_get_osdata): Change return type, adjust.
3709         * auxv.c (struct auxv_info) <length>: Remove.
3710         <data>: Change type to gdb::optional<byte_vector>.
3711         (auxv_inferior_data_cleanup): Free auxv_info with delete.
3712         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
3713         (target_auxv_search): Adjust.
3714         (fprint_target_auxv): Adjust.
3715         * avr-tdep.c (avr_io_reg_read_command): Adjust.
3716         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
3717         (linux_make_corefile_notes): Adjust.
3718         * osdata.c (get_osdata): Adjust.
3719         * remote.c (remote_get_threads_with_qxfer): Adjust.
3720         (remote_memory_map): Adjust.
3721         (remote_traceframe_info): Adjust.
3722         (btrace_read_config): Adjust.
3723         (remote_read_btrace): Adjust.
3724         (remote_pid_to_exec_file): Adjust.
3725         * solib-aix.c (solib_aix_get_library_list): Adjust.
3726         * solib-dsbt.c (decode_loadmap): Don't free buf.
3727         (dsbt_get_initial_loadmaps): Adjust.
3728         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
3729         * solib-target.c (solib_target_current_sos): Adjust.
3730         * tracepoint.c (sdata_make_value): Adjust.
3731         * xml-support.c (xinclude_start_include): Adjust.
3732         (xml_fetch_content_from_file): Adjust.
3733         * xml-support.h (xml_fetch_another): Change return type.
3734         (xml_fetch_content_from_file): Change return type.
3735         * xml-syscall.c (xml_init_syscalls_info): Adjust.
3736         * xml-tdesc.c (file_read_description_xml): Adjust.
3737         (fetch_available_features_from_target): Change return type.
3738         (target_fetch_description_xml): Adjust.
3739         (target_read_description_xml): Adjust.
3740
3741 2018-04-06  Tom Tromey  <tom@tromey.com>
3742
3743         * value.c (~value): Update.
3744         (struct value) <contents>: Now unique_xmalloc_ptr.
3745         (value_contents_bits_eq, allocate_value_contents)
3746         (value_contents_raw, value_contents_all_raw)
3747         (value_contents_for_printing, value_contents_for_printing_const)
3748         (set_value_enclosing_type): Update.
3749
3750 2018-04-06  Tom Tromey  <tom@tromey.com>
3751
3752         * value.c (range_s): Remove typedef, VEC.
3753         (struct range): Add operator<.
3754         (range_lessthan): Remove.
3755         (ranges_contain): Change type.
3756         (~value): Update.
3757         (struct value) <unavailable, optimized_out>: Now std::vector.
3758         (value_entirely_available)
3759         (value_entirely_covered_by_range_vector)
3760         (value_entirely_unavailable, value_entirely_optimized_out):
3761         Update.
3762         (insert_into_bit_range_vector): Change argument type.
3763         (find_first_range_overlap): Likewise.
3764         (struct ranges_and_idx, value_contents_bits_eq)
3765         (require_not_optimized_out, require_available): Update.
3766         (ranges_copy_adjusted): Change argument types.
3767         (value_optimized_out, value_copy, value_fetch_lazy): Update.
3768
3769 2018-04-06  Tom Tromey  <tom@tromey.com>
3770
3771         * value.c (~value): Update.
3772         (struct value) <parent>: Now a value_ref_ptr.
3773         (value_parent, set_value_parent, value_address, value_copy):
3774         Update.
3775
3776 2018-04-06  Tom Tromey  <tom@tromey.com>
3777
3778         * value.c (struct value): Add constructor, destructor, and member
3779         initializers.
3780         (allocate_value_lazy, value_decref): Update.
3781
3782 2018-04-06  Tom Tromey  <tom@tromey.com>
3783
3784         * value.c (struct value) <released, next>: Remove.
3785         (all_values): Now a std::vector.
3786         (allocate_value_lazy): Update.
3787         (value_next): Remove.
3788         (value_mark, value_free_to_mark, release_value)
3789         (value_release_to_mark): Update.
3790
3791 2018-04-06  Tom Tromey  <tom@tromey.com>
3792
3793         * value.h (fetch_subexp_value, value_release_to_mark): Update.
3794         (free_value_chain): Remove.
3795         * value.c (free_value_chain): Remove.
3796         (value_release_to_mark): Return a std::vector.
3797         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
3798         std::vector.
3799         (check_condition): Update.
3800         * eval.c (fetch_subexp_value): Change "val_chain" to a
3801         std::vector.
3802         * breakpoint.c (update_watchpoint): Update.
3803         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
3804
3805 2018-04-06  Tom Tromey  <tom@tromey.com>
3806
3807         * value.h (free_all_values): Remove.
3808         * value.c (free_all_values): Remove.
3809
3810 2018-04-06  Tom Tromey  <tom@tromey.com>
3811
3812         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
3813         (value_history_chain, value_history_count): Remove.
3814         (value_history): New global.
3815         (record_latest_value, access_value_history, show_values)
3816         (preserve_values): Update.
3817
3818 2018-04-06  Tom Tromey  <tom@tromey.com>
3819
3820         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
3821         * varobj.c (varobj_set_display_format, varobj_set_value)
3822         (install_default_visualizer, construct_visualizer)
3823         (install_new_value, ~varobj, varobj_get_value_type)
3824         (my_value_of_variable, varobj_editable_p): Update.
3825         * c-varobj.c (c_describe_child, c_value_of_variable)
3826         (cplus_number_of_children, cplus_describe_child): Update.
3827         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
3828         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
3829         (ada_value_of_variable, ada_value_is_changeable_p): Update.
3830
3831 2018-04-06  Tom Tromey  <tom@tromey.com>
3832
3833         * printcmd.c (last_examine_address): Change type to
3834         value_ref_ptr.
3835         (do_examine, x_command): Update.
3836
3837 2018-04-06  Tom Tromey  <tom@tromey.com>
3838
3839         * value.c (release_value): Update.
3840         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
3841         (struct bpstats) <val>: Now a value_ref_ptr.
3842         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
3843         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
3844         (~watchpoint, print_it_watchpoint, watch_command_1)
3845         (invalidate_bp_value_on_memory_change): Update.
3846
3847 2018-04-06  Tom Tromey  <tom@tromey.com>
3848
3849         * varobj.c (varobj_clear_saved_item)
3850         (update_dynamic_varobj_children, install_new_value, ~varobj):
3851         Update.
3852         * value.h (value_incref): Move declaration earlier.
3853         (value_decref): Rename from value_free.
3854         (struct value_ref_policy): New.
3855         (value_ref_ptr): New typedef.
3856         (struct value_deleter): Remove.
3857         (gdb_value_up): Remove typedef.
3858         (release_value): Change return type.
3859         (release_value_or_incref): Remove.
3860         * value.c (set_value_parent): Update.
3861         (value_incref): Change return type.
3862         (value_decref): Rename from value_free.
3863         (value_free_to_mark, free_all_values, free_value_chain): Update.
3864         (release_value): Return value_ref_ptr.
3865         (release_value_or_incref): Remove.
3866         (record_latest_value, set_internalvar, clear_internalvar):
3867         Update.
3868         * stack.c (info_frame_command): Don't call value_free.
3869         * python/py-value.c (valpy_dealloc, valpy_new)
3870         (value_to_value_object): Update.
3871         * printcmd.c (do_examine): Update.
3872         * opencl-lang.c (lval_func_free_closure): Update.
3873         * mi/mi-main.c (register_changed_p): Don't call value_free.
3874         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
3875         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
3876         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
3877         value_free.
3878         * guile/scm-value.c (vlscm_free_value_smob)
3879         (vlscm_scm_from_value): Update.
3880         * frame.c (frame_register_unwind, frame_unwind_register_signed)
3881         (frame_unwind_register_unsigned, get_frame_register_bytes)
3882         (put_frame_register_bytes): Don't call value_free.
3883         * findvar.c (address_from_register): Don't call value_free.
3884         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
3885         * dwarf2loc.c (entry_data_value_free_closure)
3886         (value_of_dwarf_reg_entry, free_pieced_value_closure)
3887         (dwarf2_evaluate_loc_desc_full): Update.
3888         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
3889         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
3890         (~watchpoint, watch_command_1)
3891         (invalidate_bp_value_on_memory_change): Update.
3892         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
3893
3894 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
3895
3896         PR gdb/23022
3897         * warning.m4: Add -Wno-error=deprecated-register.
3898         * configure: Re-generate.
3899
3900 2018-04-05  Tom Tromey  <tom@tromey.com>
3901
3902         * linespec.h: Remove include of "vec.h".
3903
3904 2018-04-05  Tom Tromey  <tom@tromey.com>
3905
3906         * linespec.c (typep): Remove typedef.
3907         (find_methods, find_superclass_methods): Take a std::vector.
3908         (find_method): Use std::vector.
3909
3910 2018-04-05  Tom Tromey  <tom@tromey.com>
3911
3912         * utils.c (compare_strings): Remove.
3913         * utils.h (compare_strings): Remove.
3914         * objc-lang.h (find_imps): Update.
3915         * objc-lang.c (find_methods): Take a std::vector.
3916         (uniquify_strings, find_imps): Likewise.
3917         * linespec.c (find_methods): Take a std::vector.
3918         (decode_objc): Use std::vector.
3919         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
3920         a std::vector.
3921         (find_method, find_function_symbols): Use std::vector.
3922
3923 2018-04-05  Tom Tromey  <tom@tromey.com>
3924
3925         * completer.c (completion_tracker::completion_tracker): Remove
3926         cast.
3927         (completion_tracker::discard_completions): Likewise.
3928         * breakpoint.c (ambiguous_names_p): Remove cast.
3929         * ada-lang.c (_initialize_ada_language): Remove cast.
3930         * utils.h (streq): Update.
3931         (streq_hash): Add new declaration.
3932         * utils.c (streq): Return bool.
3933         (streq_hash): New function.
3934
3935 2018-04-05  Tom Tromey  <tom@tromey.com>
3936
3937         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
3938         Remove a string copy.
3939
3940 2018-04-05  Tom Tromey  <tom@tromey.com>
3941
3942         * linespec.c (filter_results): Use std::vector.
3943         (decode_line_2, decode_line_full): Update.
3944
3945 2018-04-05  Tom Tromey  <tom@tromey.com>
3946
3947         * linespec.c (canonical_to_fullform): Return std::string.
3948         (filter_results): Update.
3949         (struct decode_line_2_item): Add constructor.
3950         <fullform, displayform>: Now std::string.
3951         (decode_line_2_compare_items): Now a std::sort comparator.
3952         (decode_line_2): Update.
3953
3954 2018-04-05  Tom Tromey  <tom@tromey.com>
3955
3956         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
3957         (unexpected_linespec_error): Update.
3958         (linespec_parse_basic, parse_linespec): Update.
3959
3960 2018-04-05  Tom Tromey  <tom@tromey.com>
3961
3962         * linespec.c (linespec_parse_basic): Reindent.
3963
3964 2018-04-05  Tom Tromey  <tom@tromey.com>
3965
3966         * minsyms.h (iterate_over_minimal_symbols): Update.
3967         * minsyms.c (iterate_over_minimal_symbols): Take a
3968         gdb::function_view.
3969         * linespec.c (struct collect_minsyms): Remove.
3970         (compare_msyms): Now a std::sort comparator.
3971         (add_minsym): Add parameters.
3972         (search_minsyms_for_name): Update.  Use std::vector.
3973
3974 2018-04-03  Tom Tromey  <tom@tromey.com>
3975
3976         * mipsread.c (read_alphacoff_dynamic_symtab): Use
3977         gdb::byte_vector.
3978
3979 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
3980
3981         * MAINTAINERS (Write After Approval): Add Weimin Pan.
3982
3983 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
3984
3985         PR gdb/16959
3986         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
3987         printing static type.
3988
3989 2018-04-01  Tom Tromey  <tom@tromey.com>
3990
3991         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
3992         (rs6000_xfer_shared_libraries): Update.
3993
3994 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
3995
3996         * common/gdb_vecs.h (char_ptr): Remove.
3997         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
3998
3999 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4000
4001         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
4002         with std::vector.
4003         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
4004
4005 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4006
4007         * tracepoint.h (struct uploaded_tp): Initialize fields.
4008         <actions, step_actions, cmd_strings>: Change type to
4009         std::vector<char *>.
4010         * tracepoint.c (get_uploaded_tp): Allocate with new.
4011         (free_uploaded_tps): Free with delete.
4012         (parse_tracepoint_definition): Adjust to std::vector change.
4013         * breakpoint.c (read_uploaded_action): Likewise.
4014         (create_tracepoint_from_upload): Likewise.
4015         * ctf.c (ctf_write_uploaded_tp): Likewise.
4016         (SET_ARRAY_FIELD): Likewise.
4017         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
4018
4019 2018-03-30  Tom Tromey  <tom@tromey.com>
4020
4021         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
4022         std::unique_ptr.
4023         (svr4_keep_data_in_core): Update.
4024         (svr4_read_so_list): Update.
4025
4026 2018-03-30  Tom Tromey  <tom@tromey.com>
4027
4028         * windows-nat.c (handle_output_debug_string, handle_exception):
4029         Update.
4030         * target.h (target_read_string): Update.
4031         * target.c (target_read_string): Change "string" to
4032         unique_xmalloc_ptr.
4033         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
4034         Update.
4035         * solib-frv.c (frv_current_sos): Update.
4036         * solib-dsbt.c (dsbt_current_sos): Update.
4037         * solib-darwin.c (darwin_current_sos): Update.
4038         * linux-thread-db.c (inferior_has_bug): Update.
4039         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
4040         Update.  Remove alloca.
4041         * ada-lang.c (ada_main_name): Update.
4042
4043 2018-03-30  Tom Tromey  <tom@tromey.com>
4044
4045         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
4046         (struct dwo_file_deleter): New.
4047         (dwo_file_up): New typedef.
4048         (open_and_init_dwo_file): Use dwo_file_up.
4049         (free_dwo_file_cleanup): Remove.
4050
4051 2018-03-30  Tom Tromey  <tom@tromey.com>
4052
4053         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
4054         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
4055
4056 2018-03-30  Tom Tromey  <tom@tromey.com>
4057
4058         * dwarf2read.c (class free_cached_comp_units): New class.
4059         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
4060         (free_cached_comp_units): Remove function.
4061
4062 2018-03-30  Tom Tromey  <tom@tromey.com>
4063
4064         * utils.h (make_cleanup_unpush_target): Remove.
4065         * inf-ptrace.c (struct target_unpusher): New.
4066         (target_unpush_up) New typedef.
4067         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
4068         target_unpush_up.
4069         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
4070
4071 2018-03-27  Tom Tromey  <tom@tromey.com>
4072
4073         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
4074
4075 2018-03-27  Pedro Alves  <palves@redhat.com>
4076             Tom Tromey  <tom@tromey.com>
4077
4078         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
4079         destructor.  Now a class.
4080         (gdb_readline_wrapper_cleanup): Remove function.
4081         (gdb_readline_wrapper): Remove cleanups.
4082
4083 2018-03-27  Tom Tromey  <tom@tromey.com>
4084
4085         * typeprint.h (struct type_print_options) <local_typedefs,
4086         global_typedefs>: Remove "struct" keyword.
4087         (class typedef_hash_table): New class.
4088         (recursively_update_typedef_hash, add_template_parameters)
4089         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
4090         (find_typedef_in_hash): Don't declare.
4091         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
4092         (typedef_hash_table::recursively_update): Rename from
4093         recursively_update_typedef_hash.  Now a member.
4094         (typedef_hash_table::add_template_parameters): Rename from
4095         add_template_parameters.  Now a member.
4096         (typedef_hash_table::typedef_hash_table): Now a constructor;
4097         rename from create_typedef_hash.
4098         (typedef_hash_table::~typedef_hash_table): Now a destructor;
4099         rename from free_typedef_hash.
4100         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
4101         (do_free_global_table): Remove.
4102         (typedef_hash_table::typedef_hash_table): New constructor; renamed
4103         from copy_type_recursive.
4104         (create_global_typedef_table): Remove.
4105         (typedef_hash_table::find_global_typedef): Now a member of
4106         typedef_hash_table.
4107         (typedef_hash_table::find_typedef): Rename from
4108         find_typedef_in_hash; now a member.
4109         (whatis_exp): Update.
4110         * extension.h (struct ext_lang_type_printers): Add constructor and
4111         destructor.
4112         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
4113         declare.
4114         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
4115         Now a constructor; rename from start_ext_lang_type_printers.
4116         (ext_lang_type_printers): Now a destructor; rename from
4117         free_ext_lang_type_printers.
4118         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
4119         Update.
4120         (c_type_print_base_struct_union): Update.  Remove cleanups.
4121
4122 2018-03-27  Tom Tromey  <tom@tromey.com>
4123
4124         * dwarf-index-write.c: Include <cmath>.
4125
4126 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4127
4128         * NEWS: Add entry describing new "set|show varsize-limit" command.
4129         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
4130         command.
4131         * printcmd.c (_initialize_printcmd): Add "set var" alias of
4132         "set variable".
4133
4134 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
4135
4136         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
4137         dwarf-index-write.c
4138         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
4139         * dwarf-index-common.c: New file.
4140         * dwarf-index-common.h: New file.
4141         * dwarf-index-write.c: New file.
4142         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
4143         (struct dwarf2_section_info): Move from here.
4144         (dwarf2_section_info_def): Likewise.
4145         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
4146         (offset_type): Likewise.
4147         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
4148         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
4149         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
4150         (byte_swap): Likewise.
4151         (MAYBE_SWAP): Likewise.
4152         (dwarf2_per_cu_ptr): Likewise.
4153         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
4154         (struct tu_stats): Likewise.
4155         (struct dwarf2_per_objfile): Likewise.
4156         (struct dwarf2_per_cu_data): Likewise.
4157         (struct signatured_type): Likewise.
4158         (sig_type_ptr): Likewise.
4159         (DEF_VEC_P (sig_type_ptr)): Likewise.
4160         (INDEX4_SUFFIX): Likewise.
4161         (INDEX5_SUFFIX): Likewise.
4162         (DEBUG_STR_SUFFIX): Likewise.
4163         (dwarf2_read_section): Make non-static.
4164         (mapped_index_string_hash): Move from here.
4165         (dwarf5_djb_hash): Likewise.
4166         (file_write): Likewise.
4167         (class data_buf): Likewise.
4168         (struct symtab_index_entry): Likewise.
4169         (struct mapped_symtab): Likewise.
4170         (find_slot): Likewise.
4171         (hash_expand): Likewise.
4172         (add_index_entry): Likewise.
4173         (uniquify_cu_indices): Likewise.
4174         (class c_str_view): Likewise.
4175         (class c_str_view_hasher): Likewise.
4176         (class vector_hasher): Likewise.
4177         (write_hash_table): Likewise.
4178         (psym_index_map): Likewise.
4179         (struct addrmap_index_data): Likewise.
4180         (add_address_entry): Likewise.
4181         (add_address_entry_worker): Likewise.
4182         (write_address_map): Likewise.
4183         (symbol_kind): Likewise.
4184         (write_psymbols): Likewise.
4185         (struct signatured_type_index_data): Likewise.
4186         (write_one_signatured_type): Likewise.
4187         (recursively_count_psymbols): Likewise.
4188         (recursively_write_psymbols): Likewise.
4189         (class debug_names): Likewise.
4190         (check_dwarf64_offsets): Likewise.
4191         (psyms_seen_size): Likewise.
4192         (write_gdbindex): Likewise.
4193         (write_debug_names): Likewise.
4194         (assert_file_size): Likewise.
4195         (write_psymtabs_to_index): Likewise.
4196         (save_gdb_index_command): Likewise.
4197         (_initialize_dwarf2_read): Don't register the "save gdb-index"
4198         command.
4199         * dwarf2read.h: New file.
4200
4201 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4202
4203         PR gdb/22670
4204         * dwarf2read.c (dwarf2_physname): Do not return the demangled
4205         symbol name if the CU's language stores symbol names in linkage
4206         format.
4207         * language.h (struct language_defn)
4208         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
4209         all instances of this struct.
4210
4211 2018-03-26  Tom Tromey  <tom@tromey.com>
4212
4213         * stack.c (backtrace_command_1): Remove verbose code.
4214
4215 2018-03-26  Tom Tromey  <tom@tromey.com>
4216
4217         * python/py-framefilter.c (py_print_type): Don't catch
4218         exceptions.  Return void.
4219         (py_print_value): Likewise.
4220         (py_print_single_arg): Likewise.
4221         (enumerate_args): Don't catch exceptions.
4222         (py_print_args): Likewise.
4223         (py_print_frame): Likewise.
4224         (gdbpy_apply_frame_filter): Catch exceptions here.
4225
4226 2018-03-26  Tom Tromey  <tom@tromey.com>
4227
4228         * stack.c (_initialize_stack): Remove trailing newlines from help
4229         text.  Add "Usage" line to "backtrace" help.
4230
4231 2018-03-26  Tom Tromey  <tom@tromey.com>
4232
4233         PR python/16486:
4234         * python/py-framefilter.c (py_print_args): Call wrap_hint.
4235
4236 2018-03-26  Tom Tromey  <tom@tromey.com>
4237
4238         * python/py-framefilter.c (py_print_single_arg): Return
4239         EXT_LANG_BT_ERROR from catch.
4240
4241 2018-03-26  Tom Tromey  <tom@tromey.com>
4242
4243         PR backtrace/15584:
4244         * stack.c (backtrace_command_1): Move some code into no-filters
4245         "if".
4246
4247 2018-03-26  Tom Tromey  <tom@tromey.com>
4248
4249         * python/py-framefilter.c (throw_quit_or_print_exception): New
4250         function.
4251         (gdbpy_apply_frame_filter): Use it.
4252
4253 2018-03-26  Tom Tromey  <tom@tromey.com>
4254
4255         PR cli/17716:
4256         * python/py-framefilter.c (py_print_type, py_print_value)
4257         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
4258         RETURN_MASK_ERROR.
4259
4260 2018-03-26  Tom Tromey  <tom@tromey.com>
4261
4262         * python/py-framefilter.c (enumerate_args): Use
4263         gdb::unique_xmalloc_ptr.
4264
4265 2018-03-26  Tom Tromey  <tom@tromey.com>
4266
4267         * python/py-framefilter.c (py_print_frame): Return
4268         EXT_LANG_BT_OK.
4269         (gdbpy_apply_frame_filter): Update comment.
4270         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
4271         Remove.
4272         <EXT_LANG_BT_NO_FILTERS>: Change value.
4273
4274 2018-03-26  Tom Tromey  <tom@tromey.com>
4275
4276         PR backtrace/15582:
4277         * stack.c (backtrace_command): Parse "hide" argument.
4278         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
4279         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
4280         constant.
4281
4282 2018-03-26  Tom Tromey  <tom@tromey.com>
4283
4284         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
4285         add "flags".
4286         (backtrace_command): Remove "fulltrace", add "flags".
4287
4288 2018-03-26  Tom Tromey  <tom@tromey.com>
4289
4290         * stack.c (backtrace_command): Rewrite command line parsing.
4291
4292 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4293
4294         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
4295
4296 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4297
4298         * filename-seen-cache.h: Add include guard.
4299
4300 2018-03-26  Keith Seitz  <keiths@redhat.com>
4301
4302         * symfile.c (place_section): Remove "struct" from section_addr_info
4303         in comment.
4304         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
4305         "struct" keyword from section_addr_info.
4306
4307 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
4308
4309         * regformats/regdef.h (reg): Add constructors.
4310
4311 2018-03-25  Pedro Alves  <palves@redhat.com>
4312
4313         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
4314         if then/else bodies in var_func_name extraction.
4315
4316 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
4317
4318         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
4319         lookup_minimal_symbol() to find symbol entry.
4320         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
4321
4322 2018-03-23  Keith Seitz  <keiths@redhat.com>
4323
4324         PR c++/22968
4325         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
4326         nested type definitions for C++, too.
4327
4328 2018-03-23  Tom Tromey  <tom@tromey.com>
4329
4330         * machoread.c (struct oso_el): Add a constructor.  Don't define as
4331         a typedef.
4332         (macho_register_oso): Remove.
4333         (macho_symtab_read): Take a std::vector.
4334         (oso_el_compare_name): Now a std::sort comparator.
4335         (macho_symfile_read_all_oso): Take a std::vector.
4336         (macho_symfile_read): Use std::vector.  Remove cleanups.
4337
4338 2018-03-22  Tom Tromey  <tom@tromey.com>
4339
4340         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
4341         (record_full_goto_bookmark): Use std::string.
4342
4343 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4344
4345         PR tdep/18295
4346         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
4347         a single mask.
4348
4349 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4350
4351         * rs6000-tdep.c (store_insn_p): New function.
4352         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
4353         and cr_reg to their unshifted values. Use store_insn_p to
4354         match LR saves using either R1 or fdata->alloca_reg. Use
4355         store_insn_p to match CR saves. Set alloca_reg_offset
4356         when alloca_reg and framep are set. Remove lr_reg shift
4357         when assigning to fdata->lr_register.
4358
4359 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4360
4361         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
4362         command line args instead of emitting a warning.
4363
4364 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4365
4366         * tracepoint.h (struct static_tracepoint_marker): Initialize
4367         fields, define default constructor, move constructor and move
4368         assignment, disable the rest.
4369         <str_id, extra>: Make std::string.
4370         (release_static_tracepoint_marker): Remove.
4371         (free_current_marker): Remove.
4372         * tracepoint.c (free_current_marker): Remove.
4373         (parse_static_tracepoint_marker_definition): Adjust to
4374         std::string, use new hex2str overload.
4375         (release_static_tracepoint_marker): Remove.
4376         (print_one_static_tracepoint_marker): Get marker by reference
4377         and adjust to std::string.
4378         (info_static_tracepoint_markers_command): Adjust to std::vector
4379         changes
4380         * target.h (static_tracepoint_marker_p): Remove typedef.
4381         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
4382         (struct target_ops) <to_static_tracepoint_marker_at>: Return
4383         bool.
4384         <to_static_tracepoint_markers_by_strid>: Return std::vector.
4385         * target-debug.h
4386         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
4387         (target_debug_print_std_vector_static_tracepoint_marker): New.
4388         (target_debug_print_struct_static_tracepoint_marker_p): Rename
4389         to...
4390         (target_debug_print_static_tracepoint_marker_p): ... this.
4391         * target-delegates.c: Re-generate.
4392         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
4393         Make std::string.
4394         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
4395         (decode_static_tracepoint_spec): Adjust to std::vector.
4396         (tracepoint_print_one_detail): Adjust to std::string.
4397         (strace_marker_decode_location): Adjust to std::string.
4398         (update_static_tracepoint): Adjust to std::string, remove call
4399         to release_static_tracepoint_marker.
4400         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
4401         Adjust to std::vector.
4402         * remote.c (remote_static_tracepoint_marker_at): Return bool.
4403         (remote_static_tracepoint_markers_by_strid): Adjust to
4404         std::vector.
4405         * common/rsp-low.h (hex2str): New overload with explicit count
4406         of bytes.
4407         * common/rsp-low.c (hex2str): New overload with explicit count
4408         of bytes.
4409         * unittests/rsp-low-selftests.c (test_hex2str): New function.
4410         (_initialize_rsp_low_selftests): Add test_hex2str test.
4411         * unittests/tracepoint-selftests.c
4412         (test_parse_static_tracepoint_marker_definition): Adjust to
4413         std::string.
4414
4415 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4416
4417         * tracepoint.c (parse_static_tracepoint_marker_definition):
4418         Consider case where the definition is followed by more
4419         definitions.
4420         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4421         tracepoint-selftests.c.
4422         * unittests/tracepoint-selftests.c: New.
4423
4424 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4425
4426         * MAINTAINERS (Write After Approval): Add Pedro Franco de
4427         Carvalho.
4428
4429 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4430
4431         * symtab.c (find_pc_sect_line): fixed indentation.
4432
4433 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4434
4435         * symtab.c (find_pc_sect_line): now uses binary search.
4436
4437 2018-03-19  Tom Tromey  <tom@tromey.com>
4438
4439         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
4440         "IDENT" production.
4441
4442 2018-03-19  Pedro Alves  <palves@redhat.com>
4443             Tom Tromey  <tom@tromey.com>
4444
4445         * unittests/observable-selftests.c: New file.
4446         * common/observable.h: New file.
4447         * observable.h: New file.
4448         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
4449         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
4450         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
4451         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
4452         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
4453         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
4454         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
4455         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
4456         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
4457         python/py-breakpoint.c, python/py-finishbreakpoint.c,
4458         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
4459         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
4460         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
4461         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
4462         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
4463         tui/tui-interp.c, valops.c: Update all users.
4464         * tui/tui-hooks.c (tui_bp_created_observer)
4465         (tui_bp_deleted_observer, tui_bp_modified_observer)
4466         (tui_inferior_exit_observer, tui_before_prompt_observer)
4467         (tui_normal_stop_observer, tui_register_changed_observer):
4468         Remove.
4469         (tui_observers_token): New global.
4470         (attach_or_detach, tui_attach_detach_observers): New functions.
4471         (tui_install_hooks, tui_remove_hooks): Use
4472         tui_attach_detach_observers.
4473         * record-btrace.c (record_btrace_thread_observer): Remove.
4474         (record_btrace_thread_observer_token): New global.
4475         * observer.sh: Remove.
4476         * observer.c: Rename to observable.c.
4477         * observable.c (namespace gdb_observers): Define new objects.
4478         (observer_debug): Move into gdb_observers namespace.
4479         (struct observer, struct observer_list, xalloc_observer_list_node)
4480         (xfree_observer_list_node, generic_observer_attach)
4481         (generic_observer_detach, generic_observer_notify): Remove.
4482         (_initialize_observer): Update.
4483         Don't include observer.inc.
4484         * Makefile.in (generated_files): Remove observer.h, observer.inc.
4485         (clean mostlyclean): Likewise.
4486         (observer.h, observer.inc): Remove targets.
4487         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
4488         (COMMON_SFILES): Use observable.c, not observer.c.
4489         * .gitignore: Remove observer.h.
4490
4491 2018-03-18  Tom Tromey  <tom@tromey.com>
4492
4493         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
4494         gdb::def_vector.
4495         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
4496
4497 2018-03-17  Tom Tromey  <tom@tromey.com>
4498
4499         * auto-load.c (auto_load_objfile_script_1): Use std::string.
4500
4501 2018-03-17  Tom Tromey  <tom@tromey.com>
4502
4503         * target.c (class scoped_target_fd): New.
4504         (target_fileio_close_cleanup): Remove.
4505         (target_fileio_read_alloc_1): Use scoped_target_fd.
4506
4507 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
4508
4509         * silent-rules.mk: New.
4510         * Makefile.in: Include silent-rules.mk
4511         (srcdir, VPATH, top_srcdir): Move up.
4512         (COMPILE): Add ECHO_CXX.
4513         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
4514         (init.c): Add ECHO_INIT_C.
4515         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
4516         (version.c): Add ECHO_GEN.
4517         (printcmd.o): Add ECHO_CXX.
4518         (target-float.o): Add ECHO_CXX.
4519         (ada-exp.o): Add ECHO_CXX.
4520         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
4521         (insight$(EXEEXT)): Add ECHO_CXXLD.
4522         * gnulib/configure.ac: Add AM_SILENT_RULES.
4523         * gnulib/aclocal.m4: Re-generate.
4524         * gnulib/configure: Re-generate.
4525         * gnulib/import/Makefile.in: Re-generate.
4526
4527 2018-03-16  Tom Tromey  <tom@tromey.com>
4528
4529         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
4530         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
4531         * utils.c (do_free_section_addr_info)
4532         (make_cleanup_free_section_addr_info): Remove.
4533         * symfile.h (struct other_sections): Add constructor.
4534         (struct section_addr_info): Remove.
4535         (section_addr_info): New typedef.
4536         (struct sym_fns) <sym_offsets>: Change type of parameter.
4537         (build_section_addr_info_from_objfile)
4538         (relative_addr_info_to_section_offsets, addr_info_make_relative)
4539         (default_symfile_offsets, symbol_file_add)
4540         (symbol_file_add_from_bfd)
4541         (build_section_addr_info_from_section_table): Update.
4542         (alloc_section_addr_info, free_section_addr_info): Don't declare.
4543         * symfile.c (alloc_section_addr_info): Remove.
4544         (build_section_addr_info_from_section_table): Change return type.
4545         Update.
4546         (build_section_addr_info_from_bfd)
4547         (build_section_addr_info_from_objfile): Likewise.
4548         (free_section_addr_info): Remove.
4549         (relative_addr_info_to_section_offsets): Change type of "addrs".
4550         (addrs_section_compar): Now a std::sort comparator.
4551         (addrs_section_sort): Change return type.
4552         (addr_info_make_relative): Change type of "addrs".  Update.
4553         (default_symfile_offsets, syms_from_objfile_1)
4554         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
4555         (symbol_file_add_separate): Update.
4556         (symbol_file_add): Change type of "addrs".  Update.
4557         (add_symbol_file_command): Update.  Remove cleanups.
4558         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
4559         cleanups.
4560         * symfile-debug.c (debug_sym_offsets): Change type of "info".
4561         * solib.c (solib_read_symbols): Update.
4562         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
4563         * machoread.c (macho_symfile_offsets): Update.
4564         * jit.c (jit_bfd_try_read_symtab): Update.
4565
4566 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
4567
4568         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4569         unittests/utils-selftests.c.
4570         * unittests/utils-selftests.c: New file.
4571
4572 2018-03-14  Tom Tromey  <tom@tromey.com>
4573
4574         PR cli/14977:
4575         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
4576         for NULL.
4577
4578 2018-03-14  Tom Tromey  <tom@tromey.com>
4579
4580         PR cli/19918:
4581         * printcmd.c (printf_pointer): Allow "-" in format.
4582
4583 2018-03-14  Tom Tromey  <tom@tromey.com>
4584
4585         * printcmd.c (_initialize_printcmd): Add usage to printf.
4586
4587 2018-03-14  Yao Qi  <qiyao@sourceware.org>
4588
4589         * MAINTAINERS: Update my email address.
4590
4591 2018-03-13  Tom Tromey  <tom@tromey.com>
4592
4593         * machoread.c (macho_check_dsym): Change filenamep to a
4594         std::string*.
4595         (macho_symfile_read): Update.
4596         * symfile.c (load_command): Use std::string.
4597
4598 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
4601         to error message string.
4602         (riscv_register_name): Use xsnprintf instead of sprintf.
4603         (riscv_insn::fetch_instruction): Use gdb_assert instead of
4604         internal_error.
4605         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
4606         error.
4607         (riscv_push_dummy_call): Likewise.
4608
4609 2018-03-12  Tom Tromey  <tom@tromey.com>
4610
4611         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
4612         Use gdb::byte_vector.
4613         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
4614
4615 2018-03-12  Yao Qi  <yao.qi@linaro.org>
4616
4617         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
4618         parameter type to readable_regcache.
4619         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
4620         the declaration.
4621
4622 2018-03-11  Tom Tromey  <tom@tromey.com>
4623
4624         * dwarf2read.c (struct nextfield): Add initializers.
4625         (struct nextfnfield): Remove.
4626         (struct fnfieldlist): Add initializers.  Remove "length" and
4627         "head", use std::vector.
4628         (struct decl_field_list): Remove.
4629         (struct field_info): Add initializers.
4630         <fields, baseclasses>: Now std::vector.
4631         <nbaseclasses, nfnfields, typedef_field_list_count,
4632         nested_types_list_count>: Remove.
4633         (dwarf2_add_field, dwarf2_add_type_defn)
4634         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
4635         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
4636         (process_structure_scope): Update.
4637
4638 2018-03-11  Tom Tromey  <tom@tromey.com>
4639
4640         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
4641         for use by std::sort.
4642         (build_type_psymtabs_1): Use std::vector.
4643
4644 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
4645
4646         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
4647         and LIBMPFR in the printed configuration.
4648
4649 2018-03-08  Tom Tromey  <tom@tromey.com>
4650
4651         * source.c (get_filename_and_charpos): Use scoped_fd.
4652         * nto-procfs.c (procfs_open_1): Use scoped_fd.
4653         (procfs_pidlist): Likewise.
4654         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
4655         (iterate_over_mappings): Likewise.
4656
4657 2018-03-08  Tom Tromey  <tom@tromey.com>
4658
4659         * infcall.c (struct call_return_meta_info)
4660         <stack_temporaries_enabled>: Remove.
4661         (get_call_return_value, call_function_by_hand_dummy): Update.
4662         * thread.c (disable_thread_stack_temporaries): Remove.
4663         (enable_thread_stack_temporaries): Remove.
4664         (thread_stack_temporaries_enabled_p): Return bool.
4665         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
4666         (get_last_thread_stack_temporary): Update.
4667         * eval.c (evaluate_subexp): Update.
4668         * gdbthread.h (class enable_thread_stack_temporaries): Now a
4669         class, not a function.
4670         (value_ptr, value_vec): Remove typedefs.
4671         (class thread_info) <stack_temporaries_enabled>: Now bool.
4672         <stack_temporaries>: Now a std::vector.
4673         (thread_stack_temporaries_enabled_p)
4674         (value_in_thread_stack_temporaries): Return bool.
4675
4676 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
4677
4678         * remote.c (putpkt_binary): Fix omitted bytes reporting.
4679         (getpkt_or_notif_sane_1): Likewise.
4680
4681 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4682
4683         * build-id.c (build_id_to_debug_bfd): Use std::string.
4684
4685 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4686
4687         * build-id.c (find_separate_debug_file_by_buildid): Return
4688         std::string.
4689         * build-id.h (find_separate_debug_file_by_buildid): Return
4690         std::string.
4691         * coffread.c (coff_symfile_read): Adjust to std::string.
4692         * elfread.c (elf_symfile_read): Adjust to std::string.
4693         * symfile.c (separate_debug_file_exists): Change parameter to
4694         std::string.
4695         (find_separate_debug_file): Return std::string.
4696         (find_separate_debug_file_by_debuglink): Return std::string.
4697         * symfile.h (find_separate_debug_file_by_debuglink): Return
4698         std::string.
4699
4700 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4701
4702         * common/xml-utils.c (xml_escape_text): Move code to...
4703         (xml_escape_text_append): ... this new function.
4704         * common/xml-utils.h (xml_escape_text_append): New declaration.
4705         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
4706         New function.
4707         (_initialize_xml_utils): register test_xml_escape_text_append as
4708         a selftest.
4709
4710 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
4711
4712         * defs.h: Remove MAX_REGISTER_SIZE.
4713         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
4714         asserts.
4715         * python/py-unwind.c (pyuw_sniffer): Likewise.
4716
4717 2018-03-07  Tom Tromey  <tom@tromey.com>
4718
4719         * linux-tdep.c (linux_info_proc): Update.
4720         * target.h (struct target_ops) <to_fileio_readlink>: Return
4721         optional<string>.
4722         (target_fileio_readlink): Return optional<string>.
4723         * remote.c (remote_hostio_readlink): Return optional<string>.
4724         * inf-child.c (inf_child_fileio_readlink): Return
4725         optional<string>.
4726         * target.c (target_fileio_readlink): Return optional<string>.
4727
4728 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4729
4730         * regcache.c (cooked_read_test): Add riscv to the list of
4731         architectures that have a save_reggroup.
4732
4733 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4734
4735         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
4736         value is not a dynamic class object.
4737
4738 2018-03-06  Tom Tromey  <tom@tromey.com>
4739
4740         * rust-exp.y: Formatting fixes.
4741
4742 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4743
4744         * riscv-tdep.c (riscv_register_name): Remove target description
4745         support.
4746         (riscv_gdbarch_init): Remove target description check.
4747
4748 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4749
4750         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
4751         comment.
4752         * riscv-tdep.h: Likewise.
4753
4754 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4755
4756         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
4757         (riscv_pseudo_register_write): Delete.
4758         (riscv_gdbarch_init): Remove all use of pseudo registers.
4759
4760 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4761
4762         * record-btrace.c (btrace_print_lines): Replace cleanup
4763         parameter with RAII equivalents.
4764         (btrace_insn_history): Replace cleanup with RAII equivalents.
4765         * ui-out.h (make_cleanup_ui_out_list_begin_end,
4766         make_cleanup_ui_out_tuple_begin_end): Remove.
4767         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
4768         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
4769         make_cleanup_ui_out_list_begin_end): Remove.
4770
4771 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4772
4773         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
4774         parameter types to std::vector.  Use bool.
4775         (record_btrace_wait): Replace VEC(tp_t) with
4776         std::vector<thread_info *>.
4777         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
4778
4779 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4780
4781         * record-btrace.c (record_btrace_disable_callback): Remove.
4782         (struct scoped_btrace_disable): New.
4783         (record_btrace_open): Use scoped_btrace_disable.
4784
4785 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4786
4787         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
4788         reading values from registers.
4789
4790 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4791
4792         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
4793         where appropriate.
4794
4795 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4796
4797         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
4798         change parameter type.  Use GDB's print functions, and use
4799         core_addr_to_string where appropriate.
4800         (riscv_push_dummy_call): Use core_addr_to_string where
4801         appropriate, update call to riscv_print_arg_location, and reindent
4802         a few lines.
4803         (riscv_return_value): Update call to riscv_print_arg_location.
4804
4805 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4806             Tim Newsome <tim@sifive.com>
4807             Albert Ou <a0u@eecs.berkeley.edu>
4808             Darius Rad <darius@bluespec.com>
4809
4810         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
4811         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
4812         (ALLDEPFILES): Add riscv-tdep.c
4813         * configure.tgt: Add riscv support.
4814         * riscv-tdep.c: New file.
4815         * riscv-tdep.h: New file.
4816         * NEWS: Mention new target.
4817         * MAINTAINERS: Add entry for riscv.
4818
4819 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4820
4821         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
4822         fields within aggregates.
4823
4824 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
4825
4826         * record-btrace.c (btrace_print_lines): Change type of flags to
4827         gdb_disassembly_flags.
4828
4829 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4830
4831         * fbsd-nat.c: Include "inf-ptrace.h".
4832         (USE_SIGTRAP_SIGINFO): Conditionally define.
4833         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
4834         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
4835         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
4836         function.
4837         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
4838         Likewise.
4839         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
4840         Likewise.
4841         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
4842         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
4843         "supports_stopped_by_hw_breakpoint" target methods.
4844
4845 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4846
4847         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
4848         * fbsd-nat.c (debug_fbsd_nat): New variable.
4849         (show_fbsd_nat_debug): New function.
4850         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
4851         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
4852
4853 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4854
4855         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
4856         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
4857         prototype.
4858         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
4859         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
4860         method.
4861
4862 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4863
4864         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
4865         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
4866
4867 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4868
4869         * charset.c (struct charset_vector): New.
4870         (charsets): Change type to charset_vector.
4871         (find_charset_names): Adjust.
4872         (add_one): Adjust.
4873         (_initialize_charset): Adjust.
4874
4875 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4876
4877         * progspace.h (struct program_space) <deleted_solibs>: Change
4878         type to std::vector<std::string>.
4879         * progspace.c (clear_program_space_solib_cache): Adjust.
4880         * breakpoint.c (print_solib_event): Adjust.
4881         (check_status_catch_solib): Adjust.
4882         * solib.c (update_solib_list): Adjust.
4883         * ui-out.h (class ui_out) <field_string>: New overload.
4884         * ui-out.c (ui_out::field_string): New overload.
4885
4886 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4887
4888         * progspace.h (struct program_space): Add constructor and
4889         destructor, initialize fields.
4890         (add_program_space): Remove.
4891         * progspace.c (add_program_space): Rename to...
4892         (program_space::program_space): ... this.
4893         (release_program_space): Rename to...
4894         (program_space::~program_space): ... this.
4895         (delete_program_space): Use delete to delete program_space.
4896         (initialize_progspace): Use new to allocate program_space.
4897         * inferior.c (add_inferior_with_spaces): Likewise.
4898         (clone_inferior_command): Likewise.
4899         * infrun.c (follow_fork_inferior): Likewise.
4900         (handle_vfork_child_exec_or_exit): Likewise.
4901
4902 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4903
4904         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
4905         (delim_string_to_char_ptr_vec): Return std::vector of
4906         gdb::unique_xmalloc_ptr.
4907         (dirnames_to_char_ptr_vec_append): Take std::vector of
4908         gdb::unique_xmalloc_ptr.
4909         (dirnames_to_char_ptr_vec): Return std::vector of
4910         gdb::unique_xmalloc_ptr.
4911         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
4912         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
4913         (delim_string_to_char_ptr_vec): Return an std::vector of
4914         gdb::unique_xmalloc_ptr, adjust the code.
4915         (dirnames_to_char_ptr_vec_append): Take an std::vector of
4916         gdb::unique_xmalloc_ptr, adjust the code.
4917         (dirnames_to_char_ptr_vec): Return an std::vector of
4918         gdb::unique_xmalloc_ptr, adjust the code.
4919         * auto-load.c (auto_load_safe_path_vec): Change type to
4920         std::vector of gdb::unique_xmalloc_ptr.
4921         (auto_load_expand_dir_vars): Return an std::vector of
4922         gdb::unique_xmalloc_ptr, adjust the code.
4923         (auto_load_safe_path_vec_update): Adjust.
4924         (filename_is_in_auto_load_safe_path_vec): Adjust.
4925         (auto_load_objfile_script_1): Adjust.
4926         * build-id.c (build_id_to_debug_bfd): Adjust.
4927         * linux-thread-db.c (thread_db_load_search): Adjust.
4928         * source.c (add_path): Adjust.
4929         (openp): Adjust.
4930         * symfile.c (find_separate_debug_file): Adjust.
4931         * utils.c (do_free_char_ptr_vec): Remove.
4932         (make_cleanup_free_char_ptr_vec): Remove.
4933
4934 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4935
4936         PR gdb/22907
4937         * common/pathstuff.c: Conditionally include "<windows.h>".
4938
4939 2018-03-01  Georg Sauthoff  <mail@georg.so>
4940
4941         PR gdb/22888
4942         * gcore.in: Quote variables and switch interpreter to bash.
4943
4944 2018-03-01  Tom Tromey  <tom@tromey.com>
4945
4946         * dwarf2read.c (alloc_discriminant_info): Fix default_index
4947         assertion.  Add assertion for discriminant_index.
4948         (quirk_rust_enum): Use correct base type name in univariant case.
4949
4950 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
4951
4952         * record.c (get_call_history_modifiers): Return a
4953         record_print_flags.
4954         (cmd_record_call_history): Adjust.
4955         * record-btrace.c (record_btrace_call_history): Adjust.
4956         (record_btrace_call_history_range): Adjust.
4957         (record_btrace_call_history_from): Adjust.
4958         * target-debug.h (target_debug_print_record_print_flags): New.
4959         * target-delegates.c: Re-generate.
4960         * target.c (target_call_history): Change flags type.
4961         (target_call_history_from): Likewise.
4962         (target_call_history_range): Likewise.
4963         * target.h (struct target_ops) <target_call_history>: Likewise.
4964         (target_call_history_from): Likewise.
4965         (target_call_history_range): Likewise.
4966
4967 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4968             Simon Marchi  <simon.marchi@polymtl.ca>
4969
4970         * common/common-utils.c: Include "sys/stat.h".
4971         (is_regular_file): Move here from "source.c"; change return
4972         type to "bool".
4973         * common/common-utils.h (is_regular_file): New prototype.
4974         * common/pathstuff.c (contains_dir_separator): New function.
4975         * common/pathstuff.h (contains_dir_separator): New prototype.
4976         * source.c: Don't include "sys/stat.h".
4977         (is_regular_file): Move to "common/common-utils.c".
4978
4979 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4980
4981         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
4982         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
4983         * auto-load.c: Include "common/pathstuff.h".
4984         * common/common-def.h (current_directory): Move here.
4985         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
4986         function.
4987         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
4988         prototype.
4989         * common/pathstuff.c: New file.
4990         * common/pathstuff.h: New file.
4991         * compile/compile.c: Include "common/pathstuff.h".
4992         * defs.h (current_directory): Move to "common/common-defs.h".
4993         * dwarf2read.c: Include "common/pathstuff.h".
4994         * exec.c: Likewise.
4995         * guile/scm-safe-call.c: Likewise.
4996         * linux-thread-db.c: Likewise.
4997         * main.c: Likewise.
4998         * nto-tdep.c: Likewise.
4999         * objfiles.c: Likewise.
5000         * source.c: Likewise.
5001         * symtab.c: Likewise.
5002         * utils.c: Include "common/pathstuff.h".
5003         (gdb_realpath): Move to "common/pathstuff.c".
5004         (gdb_realpath_keepfile): Likewise.
5005         (gdb_abspath): Likewise.
5006         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
5007         (gdb_realpath_keepfile): Likewise.
5008         (gdb_abspath): Likewise.
5009
5010 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
5011
5012         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
5013         wildcard process pid for super_resume for kernels with a
5014         specific bug.
5015
5016 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
5017
5018         * compile/compile.c (get_args): Add additional comments
5019         explaining function.
5020
5021 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
5022             Tom Tromey  <tom@tromey.com>
5023
5024         * target.h (memory_write_request_s): Remove typedef.  Don't define
5025         VEC.
5026         (target_write_memory_blocks): Change argument to std::vector.
5027         (struct memory_write_request): Add constructor.
5028         * target-memory.c (compare_block_starting_address): Return bool.
5029         Change argument types.
5030         (claim_memory): Change arguments to use std::vector.
5031         (split_regular_and_flash_blocks, blocks_to_erase)
5032         (compute_garbled_blocks): Likewise.
5033         (cleanup_request_data, cleanup_write_requests_vector): Remove.
5034         (target_write_memory_blocks): Change argument to std::vector.
5035         * symfile.c (struct load_section_data): Add constructor and
5036         destructor.  Use std::vector for "requests".
5037         (struct load_progress_data): Add initializers.
5038         (load_section_callback): Update.  Use "new".
5039         (clear_memory_write_data): Remove.
5040         (generic_load): Update.
5041
5042 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
5043
5044         * arch/aarch64.h: Use common/tdesc.h.
5045
5046 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5047
5048         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
5049         architecture with a 64-bit ABI.
5050
5051 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5052
5053         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
5054         ahead of target description loading.
5055
5056 2018-02-26  Tom Tromey  <tom@tromey.com>
5057
5058         * stack.c (backtrace_command_1): Update.
5059         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
5060         of "flags".
5061         * python/py-framefilter.c (py_print_frame)
5062         (gdbpy_apply_frame_filter): Change type of "flags".
5063         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
5064         of "flags".
5065         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
5066         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
5067         * extension.h (enum frame_filter_flag): Rename from
5068         frame_filter_flags.
5069         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
5070         (apply_ext_lang_frame_filter): Change type of "flags".
5071         * extension.c (apply_ext_lang_frame_filter): Change type of
5072         "flags".
5073         * extension-priv.h (struct extension_language_ops)
5074         <apply_frame_filter>: Change type of "flags".
5075
5076 2018-02-26  Tom Tromey  <tom@tromey.com>
5077
5078         PR python/16497:
5079         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
5080         off-by-one in py_end computation.
5081         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
5082         PRINT_MORE_FRAMES.
5083         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
5084         constant.
5085
5086 2018-02-26  Tom Tromey  <tom@tromey.com>
5087
5088         * dwarf2read.c (struct variant_field): New.
5089         (struct nextfield) <variant>: New field.
5090         (dwarf2_add_field): Handle DW_TAG_variant_part.
5091         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
5092         discriminated union.
5093         (read_structure_type): Handle DW_TAG_variant_part.
5094         (handle_struct_member_die): New function, extracted from
5095         process_structure_scope.  Handle DW_TAG_variant.
5096         (process_structure_scope): Handle discriminated unions.  Call
5097         handle_struct_member_die.
5098
5099 2018-02-26  Tom Tromey  <tom@tromey.com>
5100
5101         * rust-lang.h (rust_last_path_segment): Declare.
5102         * rust-lang.c (rust_last_path_segment): Now public.  Change
5103         contract.
5104         (struct disr_info): Remove.
5105         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
5106         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
5107         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
5108         (rust_enum_p, rust_enum_variant): New function.
5109         (rust_underscore_fields): Remove "offset" parameter.
5110         (rust_print_enum): New function.
5111         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
5112         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
5113         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
5114         enums.
5115         (rust_internal_print_type): New function, from rust_print_type.
5116         Remove enum code.
5117         (rust_print_type): Call rust_internal_print_type.
5118         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
5119         Update enum handling.
5120         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
5121         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
5122         (rust_union_quirks): New functions.
5123         (process_full_comp_unit, process_full_type_unit): Call
5124         rust_union_quirks.
5125         (process_structure_scope): Update rust_unions if necessary.
5126
5127 2018-02-26  Tom Tromey  <tom@tromey.com>
5128
5129         * value.h (value_union_variant): Declare.
5130         * valops.c (value_union_variant): New function.
5131         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
5132         (struct discriminant_info): New.
5133         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
5134         enumerator.
5135         (struct main_type) <flag_discriminated_union>: New field.
5136
5137 2018-02-26  Tom Tromey  <tom@tromey.com>
5138
5139         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5140         unittests/unpack-selftests.c.
5141         * unittests/unpack-selftests.c: New file.
5142         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
5143
5144 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5145
5146         * dwarf2read.c (struct partial_die_info) <read>: New method.
5147         (read_partial_die): Remove the declaration.
5148         (load_partial_dies): Update.
5149         (partial_die_info::partial_die_info):
5150         (read_partial_die): Change it to partial_die_info::read.
5151
5152 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5153
5154         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
5155         (fixup_partial_die): Remove declaration.
5156         (scan_partial_symbols): Update.
5157         (partial_die_parent_scope): Likewise.
5158         (partial_die_full_name): Likewise.
5159         (fixup_partial_die): Change it to partial_die_info::fixup.
5160
5161 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5162
5163         * dwarf2read.c (read_partial_die): Update the declaration.
5164         (load_partial_dies): Caller update.
5165         (read_partial_die): Remove one argument abbrev_len.
5166
5167 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5168
5169         * dwarf2read.c (struct partial_die_info): Add ctor, delete
5170         assignment operator.
5171         (load_partial_dies): Use ctor and copy ctor.
5172         (read_partial_die): Update.
5173         (dwarf2_cu::find_partial_die): Use ctor.
5174
5175 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5176
5177         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
5178         (find_partial_die_in_comp_unit): Change it to
5179         dwarf2_cu::find_partial_die.
5180         (find_partial_die): Update.
5181
5182 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5183
5184         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
5185         is NULL.
5186
5187 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5188
5189         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
5190
5191 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
5192
5193         * arch/amd64.h: Use common/tdesc.h.
5194         * arch/i386.c: Likewise.
5195         * arch/i386.h: Likewise.
5196         * arch/tic6x.c: Likewise.
5197         * arch/tdesc.h: Move file from here...
5198         * common/tdesc.h: ...to here.
5199         * features/aarch64-core.c: Regenerate.
5200         * features/aarch64-fpu.c: Regenerate.
5201         * features/i386/32bit-avx.c: Regenerate.
5202         * features/i386/32bit-avx512.c: Regenerate.
5203         * features/i386/32bit-core.c: Regenerate.
5204         * features/i386/32bit-linux.c: Regenerate.
5205         * features/i386/32bit-mpx.c: Regenerate.
5206         * features/i386/32bit-pkeys.c: Regenerate.
5207         * features/i386/32bit-sse.c: Regenerate.
5208         * features/i386/64bit-avx.c: Regenerate.
5209         * features/i386/64bit-avx512.c: Regenerate.
5210         * features/i386/64bit-core.c: Regenerate.
5211         * features/i386/64bit-linux.c: Regenerate.
5212         * features/i386/64bit-mpx.c: Regenerate.
5213         * features/i386/64bit-pkeys.c: Regenerate.
5214         * features/i386/64bit-segments.c: Regenerate.
5215         * features/i386/64bit-sse.c: Regenerate.
5216         * features/i386/x32-core.c: Regenerate.
5217         * features/tic6x-c6xp.c: Regenerate.
5218         * features/tic6x-core.c: Regenerate.
5219         * features/tic6x-gp.c: Regenerate.
5220         * target-descriptions.c: Use common/tdesc.h.
5221         * target-descriptions.h: Likewise.
5222
5223 2018-02-24  Tom Tromey  <tom@tromey.com>
5224
5225         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
5226         (try_thread_db_load_from_dir, thread_db_load_search): Use
5227         std::string.
5228         (info_auto_load_libthread_db_compare): Return bool.  Change
5229         argument types.
5230         (info_auto_load_libthread_db): Use std::vector, std::string.
5231         Remove cleanups.
5232
5233 2018-02-24  Tom Tromey  <tom@tromey.com>
5234
5235         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
5236         std::string.
5237         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
5238         std::string*.
5239         * gdbarch.c: Rebuild.
5240         * gdbarch.h: Rebuild.
5241         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
5242         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
5243         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
5244         std::string*.
5245
5246 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
5247
5248         * gdbtypes.h (sect_offset): Change type to uint64_t.
5249         (sect_offset_str): New function.
5250         * dwarf2read.c (create_addrmap_from_aranges): Use
5251         sect_offset_str.
5252         (error_check_comp_unit_head): Likewise.
5253         (create_debug_type_hash_table): Likewise.
5254         (read_cutu_die_from_dwo): Likewise.
5255         (init_cutu_and_read_dies): Likewise.
5256         (init_cutu_and_read_dies_no_follow): Likewise.
5257         (process_psymtab_comp_unit_reader): Likewise.
5258         (partial_die_parent_scope): Likewise.
5259         (peek_die_abbrev): Likewise.
5260         (process_queue): Likewise.
5261         (dwarf2_physname): Likewise.
5262         (read_namespace_alias): Likewise.
5263         (read_import_statement): Likewise.
5264         (create_dwo_cu_reader): Likewise.
5265         (create_cus_hash_table): Likewise.
5266         (lookup_dwo_cutu): Likewise.
5267         (inherit_abstract_dies): Likewise.
5268         (read_func_scope): Likewise.
5269         (read_call_site_scope): Likewise.
5270         (dwarf2_add_member_fn): Likewise.
5271         (read_common_block): Likewise.
5272         (read_module_type): Likewise.
5273         (read_typedef): Likewise.
5274         (read_subrange_type): Likewise.
5275         (load_partial_dies): Likewise.
5276         (read_partial_die): Likewise.
5277         (find_partial_die): Likewise.
5278         (read_str_index): Likewise.
5279         (dwarf2_string_attr): Likewise.
5280         (build_error_marker_type): Likewise.
5281         (lookup_die_type): Likewise.
5282         (dump_die_shallow): Likewise.
5283         (follow_die_ref): Likewise.
5284         (dwarf2_fetch_die_loc_sect_off): Likewise.
5285         (dwarf2_fetch_constant_bytes): Likewise.
5286         (follow_die_sig): Likewise.
5287         (get_signatured_type): Likewise.
5288         (get_DW_AT_signature_type): Likewise.
5289         (dwarf2_find_containing_comp_unit): Likewise.
5290         (set_die_type): Likewise.
5291
5292 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
5293
5294         * arch/aarch64.c: Include "common-defs.h".
5295         * arch/amd64.c: Likewise.
5296         * arch/i386.c: Likewise.
5297
5298 2018-02-21  Tom Tromey  <tom@tromey.com>
5299
5300         * value.h: (extract_field_op): Update.
5301         * eval.c (extract_field_op): Return a const char *.
5302         * expression.h (parse_expression_for_completion): Update.
5303         * completer.c (complete_expression): Update.
5304         (add_struct_fields): Make fieldname const.
5305         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
5306         (mark_completion_tag, parse_exp_in_context_1): Update.
5307         (parse_expression_for_completion): Change "name" to
5308         unique_xmalloc_ptr*.
5309
5310 2018-02-21  Tom Tromey  <tom@tromey.com>
5311
5312         * infcall.c (call_function_by_hand_dummy): Use std::vector.
5313
5314 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5315
5316         * avr-tdep.c (avr_read_pc): Change parameter type to
5317         readable_regcache.
5318         * gdbarch.sh (read_pc): Likewise.
5319         * gdbarch.c: Re-generated.
5320         * gdbarch.h: Re-generated.
5321         * hppa-tdep.c (hppa_read_pc): Change parameter type to
5322         readable_regcache.
5323         * ia64-tdep.c (ia64_read_pc): Likewise.
5324         * mips-tdep.c (mips_read_pc): Likewise.
5325         * spu-tdep.c (spu_read_pc): Likewise.
5326
5327 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5328
5329         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
5330         * regcache-dump.c: New file.
5331         * regcache.c: Move register_dump to regcache-dump.c.
5332         (maintenance_print_registers): Likewise.
5333         (maintenance_print_raw_registers): Likewise.
5334         (maintenance_print_cooked_registers): Likewise.
5335         (maintenance_print_register_groups): Likewise.
5336         (maintenance_print_remote_registers): Likewise.
5337         (_initialize_regcache): Likewise.
5338         * regcache.h (register_dump): Moved from regcache.c.
5339
5340 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5341
5342         * regcache.c (regcache::regcache): Update.
5343         (regcache::invalidate): Move it to detached_regcache::invalidate.
5344         (get_thread_arch_aspace_regcache): Update.
5345         (regcache::raw_update): Update.
5346         (regcache::cooked_read): Remove some code.
5347         (regcache::cooked_read_value): Likewise.
5348         (regcache::raw_write): Remove assert on m_readonly_p.
5349         (regcache::raw_supply_integer): Move it to
5350         detached_regcache::raw_supply_integer.
5351         (regcache::raw_supply_zeroed): Likewise.
5352         * regcache.h (detached_regcache) <raw_supply_integer>: New
5353         declaration.
5354         <raw_supply_zeroed, invalidate>: Likewise.
5355         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
5356         <invalidate>: Likewise.
5357         <m_readonly_p>: Removed.
5358
5359 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5360
5361         * infcmd.c (get_return_value): Let stop_regs point to
5362         get_current_regcache.
5363         * regcache.c (regcache::regcache): Remove.
5364         (register_dump_reg_buffer): New class.
5365         (regcache_print): Adjust.
5366         * regcache.h (regcache): Remove constructors.
5367
5368 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5369
5370         * regcache.c (class register_dump): New class.
5371         (register_dump_regcache, register_dump_none): New class.
5372         (register_dump_remote, register_dump_groups): New class.
5373         (regcache_print): Update.
5374         * regcache.h (regcache_dump_what): Move it to regcache.c.
5375         (regcache) <dump>: Remove.
5376
5377 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5378
5379         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
5380          reg_buffer_rw *.
5381         (jit_unwind_reg_set_impl): Call raw_supply.
5382         (jit_frame_sniffer): Use reg_buffer_rw.
5383         * record-full.c (record_full_core_regbuf): Change its type.
5384         (record_full_core_open_1): Use reg_buffer_rw.
5385         (record_full_close): Likewise.
5386         (record_full_core_fetch_registers): Use regcache->raw_supply.
5387         (record_full_core_store_registers): Likewise.
5388         * regcache.c (regcache::get_register_status): Move it to
5389         reg_buffer.
5390         (regcache_raw_set_cached_value): Remove.
5391         (regcache::raw_set_cached_value): Remove.
5392         (regcache::raw_write): Call raw_supply.
5393         (regcache::raw_supply): Move it to reg_buffer_rw.
5394         * regcache.h (regcache_raw_set_cached_value): Remove.
5395         (reg_buffer_rw): New class.
5396
5397 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5398
5399         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
5400         readonly_detached_regcache.
5401         (dummy_frame_prev_register): Use regcache->cooked_read.
5402         * frame.c (frame_save_as_regcache): Change return type.
5403         (frame_pop): Update.
5404         * frame.h (frame_save_as_regcache): Update declaration.
5405         * inferior.h (get_infcall_suspend_state_regcache): Update
5406         declaration.
5407         * infrun.c (infcall_suspend_state) <registers>: use
5408         readonly_detached_regcache.
5409         (save_infcall_suspend_state): Don't use regcache_dup.
5410         (get_infcall_suspend_state_regcache): Change return type.
5411         * linux-fork.c (struct fork_info) <savedregs>: Change to
5412         readonly_detached_regcache.
5413         <pc>: New field.
5414         (fork_save_infrun_state): Don't use regcache_dup.
5415         (info_checkpoints_command): Adjust.
5416         * mi/mi-main.c (register_changed_p): Update declaration.
5417         (mi_cmd_data_list_changed_registers): Use
5418         readonly_detached_regcache.
5419         (register_changed_p): Change parameter type to
5420         readonly_detached_regcache.
5421         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
5422         readonly_detached_regcache.
5423         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
5424         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
5425         New.
5426         (regcache::save): Move it to reg_buffer.
5427         (regcache::restore): Change parameter type.
5428         (regcache_dup): Remove.
5429         * regcache.h (reg_buffer) <save>: New method.
5430         (readonly_detached_regcache): New class.
5431         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
5432         readonly_detached_regcache.
5433         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
5434
5435 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5436
5437         * frame.c (frame_save_as_regcache): Use regcache method save.
5438         (frame_pop): Use regcache method restore.
5439         * infrun.c (restore_infcall_suspend_state): Likewise.
5440         * linux-fork.c (fork_load_infrun_state): Likewise.
5441         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
5442         save.
5443         * regcache.c (regcache_save): Remove.
5444         (regcache::restore): More asserts.
5445         (regcache_cpy): Remove.
5446         * regcache.h (regcache_save): Remove the declaration.
5447         (regcache::restore): Move from private to public.
5448         Remove the friend declaration of regcache_cpy.
5449         (regcache_cpy): Remove declaration.
5450
5451 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5452
5453         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
5454         parameter type to 'readable_regcache *'.
5455         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5456         * arm-tdep.c (arm_neon_quad_read): Likewise.
5457         (arm_pseudo_read): Likewise.
5458         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5459         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5460         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5461         * gdbarch.c: Re-generated.
5462         * gdbarch.h: Re-generated.
5463         * gdbarch.sh (pseudo_register_read): Change parameter type to
5464         'readable_regcache *'.
5465         (pseudo_register_read_value): Likewise.
5466         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
5467         (h8300_pseudo_register_read): Likewise.
5468         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
5469         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5470         (i386_pseudo_register_read_into_value): Likewise.
5471         (i386_pseudo_register_read_value): Likewise.
5472         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
5473         declaration.
5474         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
5475         * m32c-tdep.c (m32c_raw_read): Likewise.
5476         (m32c_read_flg): Likewise.
5477         (m32c_banked_register): Likewise.
5478         (m32c_banked_read): Likewise.
5479         (m32c_sb_read): Likewise.
5480         (m32c_part_read): Likewise.
5481         (m32c_cat_read): Likewise.
5482         (m32c_r3r2r1r0_read): Likewise.
5483         (m32c_pseudo_register_read): Likewise.
5484         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5485         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5486         (mep_pseudo_cr64_read): Likewise.
5487         (mep_pseudo_register_read): Likewise.
5488         * mips-tdep.c (mips_pseudo_register_read): Likewise.
5489         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5490         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5491         * regcache.c (regcache::raw_read): Move it to readable_regcache.
5492         (regcache::cooked_read): Likewise.
5493         (regcache::cooked_read_value): Likewise.
5494         (regcache_cooked_read_signed):
5495         (regcache::cooked_read): Likewise.
5496         * regcache.h (readable_regcache): New class.
5497         (regcache): Inherit readable_regcache.  Move some methods to
5498         readable_regcache.
5499         * rl78-tdep.c (rl78_pseudo_register_read): Change
5500         parameter type to 'readable_regcache *'.
5501         * rs6000-tdep.c (do_regcache_raw_read): Remove.
5502         (e500_pseudo_register_read): Change parameter type to
5503         'readable_regcache *'.
5504         (dfp_pseudo_register_read): Likewise.
5505         (vsx_pseudo_register_read): Likewise.
5506         (efpr_pseudo_register_read): Likewise.
5507         * s390-tdep.c (s390_pseudo_register_read): Likewise.
5508         * sh-tdep.c (sh_pseudo_register_read): Likewise.
5509         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
5510         (sh64_pseudo_register_read): Likewise.
5511         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
5512         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5513         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
5514         (spu_pseudo_register_read): Likewise.
5515         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5516         (xtensa_pseudo_register_read): Likewise.
5517
5518 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5519
5520         * regcache.c (regcache::regcache): Call reg_buffer ctor.
5521         (regcache::arch): Move it to reg_buffer::arch.
5522         (regcache::register_buffer): Likewise.
5523         (regcache::assert_regnum): Likewise.
5524         (regcache::num_raw_registers): Likewise.
5525         * regcache.h (reg_buffer): New class.
5526         (regcache): Inherit reg_buffer.
5527
5528 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
5529
5530         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
5531         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
5532
5533 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
5534
5535         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
5536
5537 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
5538
5539         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
5540         (SFILES): Remove common/*.c files.
5541         (COMMON_OBS): Remove some *.o files built from common/*.c files.
5542         * common/common.host: Add common reference.
5543         * configure.ac: Likewise.
5544         * configure: Regenerate.
5545
5546 2018-02-16  Yao Qi  <yao.qi@linaro.org>
5547
5548         * block.c (block_namespace_info): Inherit allocate_on_obstack.
5549         (block_initialize_namespace): Use new.
5550         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
5551         (dwarf2_free_objfile): Use delete.
5552         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
5553         (copy_type_recursive): Use new.
5554         * gdb_obstack.h (allocate_on_obstack): New.
5555
5556 2018-02-15  Yao Qi  <yao.qi@linaro.org>
5557
5558         PR gdb/22849
5559         * inferior.c (exit_inferior_1): Reset inf->control.
5560
5561 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
5562
5563         * ada-lang.c (ada_to_fixed_value_create): Delete advance
5564         declaration.
5565
5566 2018-02-14  Pedro Alves  <palves@redhat.com>
5567
5568         * frame-unwind.c (frame_unwind_try_unwinder): Always call
5569         frame_cleanup_after_sniffer on exception.
5570
5571 2018-02-14  Tom Tromey  <tom@tromey.com>
5572
5573         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
5574         const.
5575         (solib_bfd_open): Make pathname const.
5576         * solib.c (solib_bfd_open): Make pathname const.
5577         * solib-spu.c (spu_bfd_fopen): Make name const.
5578         (spu_bfd_open): Make pathname const.
5579         * solib-darwin.c (darwin_bfd_open): Make pathname const.
5580         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
5581
5582 2018-02-14  Tom Tromey  <tom@tromey.com>
5583
5584         * symfile.c (symfile_bfd_open): Update.
5585         * source.h (openp, source_full_path_of, find_and_open_source):
5586         Change argument type to unique_xmalloc_ptr.
5587         * source.c (openp): Take a unique_xmalloc_ptr.
5588         (source_full_path_of, find_and_open_source): Likewise.
5589         (open_source_file, symtab_to_fullname): Update.
5590         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
5591         unique_xmalloc_ptr.
5592         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
5593         (exec_file_find): Update.
5594         * psymtab.c (psymtab_to_fullname): Update.
5595         * nto-tdep.h (nto_find_and_open_solib): Update.
5596         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
5597         unique_xmalloc_ptr.
5598         * exec.c (exec_file_attach): Update.
5599         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
5600         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
5601
5602 2018-02-14  Tom Tromey  <tom@tromey.com>
5603
5604         * solib.c: Include source.h.
5605         * nto-tdep.c: Include source.h.
5606         * mi/mi-cmd-env.c: Include source.h.
5607         * infcmd.c: Include source.h.
5608         * exec.c: Include source.h.
5609         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
5610         (add_path, directory_switch, source_path, init_source_path): Move
5611         declarations...
5612         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
5613         (add_path, directory_switch, source_path, init_source_path):
5614         ...here.
5615
5616 2018-02-14  Tom Tromey  <tom@tromey.com>
5617
5618         * solist.h (exec_file_find, solib_find): Return
5619         unique_xmalloc_ptr.
5620         (solib_bfd_fopen): Take a const char *.
5621         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
5622         (exec_file_find, solib_find): Likewise.
5623         (solib_bfd_fopen): Do not take ownership of "pathname".
5624         (solib_bfd_open): Use unique_xmalloc_ptr.
5625         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
5626         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
5627         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
5628         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
5629
5630 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
5631
5632         * ada-lang.c (name_match_type_from_name): Remove reference to
5633         ada_name_for_lookup in function's documentation.
5634         * ada-lang.h (ada_name_for_lookup): Delete declaration.
5635
5636 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5637
5638         * defs.h (enum openp_flags): New enum.
5639         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
5640         Move to enum openp_flags.
5641         (openp_flags): New enum flags.
5642         (openp): Change parameter type to openp_flags.
5643         * source.c (openp): Change parameter type to openp_flags.
5644         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
5645         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
5646
5647 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5648
5649         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
5650         per-command.
5651
5652 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5653
5654         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
5655         into...
5656         (class dwarf2_queue_guard): ...the destructor of this new class.
5657         (dw2_do_instantiate_symtab): Create instance of the new class
5658         dwarf2_queue_guard, remove cleanup.
5659
5660 2018-02-09  Tom Tromey  <tom@tromey.com>
5661
5662         * source.c (find_source_lines): Don't reference past the end of
5663         the vector.
5664
5665 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5666
5667         * remote.c (remote_btrace_maybe_reopen): Change error message.
5668         * btrace.c (btrace_enable): Likewise.
5669         (parse_xml_btrace): Likewise.
5670         (parse_xml_btrace_conf): Likewise.
5671
5672 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5673
5674         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
5675         (linux_enable_pt, linux_enable_bts): Call
5676         diagnose_perf_event_open_fail.
5677
5678 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5679
5680         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
5681         Remove parameter and change return type.  Update callers.  Move it.
5682         (linux_enable_bts, linux_enable_pt): Improve error message.
5683         (linux_enable_pt): Remove zero buffer size check.
5684         (linux_enable_btrace): Improve error messages.  Remove NULL return
5685         check.
5686
5687 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5688
5689         * btrace.c (btrace_enable): Remove target_supports_btrace call.
5690         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
5691         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
5692         (linux_supports_pt, linux_supports_btrace): Remove.
5693         (linux_enable_bts): Call cpu_supports_bts.
5694         * nat/linux-btrace.h (linux_supports_btrace): Remove.
5695         * remote.c (remote_supports_btrace): Remove.
5696         (init_remote_ops): Remove remote_supports_btrace.
5697         * target-delegates.c: Regenerated.
5698         * target.c (target_supports_btrace): Remove.
5699         * target.h (target_ops) <to_supports_btrace>: Remove
5700         (target_supports_btrace): Remove.
5701         * x86-linux-nat.c (x86_linux_create_target): Remove
5702         linux_supports_btrace.
5703
5704 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5705
5706         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
5707         btrace failed.
5708         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
5709         exception and use message in own exception.
5710
5711 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5712
5713         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
5714         (perf_event_pt_event_type): Use gdb_file_up.
5715         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
5716         scoped_fd, and scoped_mmap.
5717
5718 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5719
5720         * common/scoped_mmap.h: New.
5721         * unittests/scoped_mmap-selftest.c: New.
5722         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5723         unittests/scoped_mmap-selftest.c.
5724
5725 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5726
5727         * common/scoped_fd.h: New.
5728         * unittests/scoped_fd-selftest.c: New.
5729         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5730         unittests/scoped_fd-selftest.c.
5731
5732 2018-02-09  Tom Tromey  <tom@tromey.com>
5733
5734         * auto-load.c (auto_load_section_scripts): Use
5735         gdb::unique_xmalloc_ptr.
5736
5737 2018-02-09  Tom Tromey  <tom@tromey.com>
5738
5739         * auto-load.c (execute_script_contents): Use std::string.
5740
5741 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
5742
5743         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
5744         Python function, rather than a new command.
5745
5746 2018-02-08  Tom Tromey  <tom@tromey.com>
5747
5748         * solib.c (solib_find_1): Use std::string.
5749         (solib_bfd_fopen): Use unique_xmalloc_ptr.
5750
5751 2018-02-08  Tom Tromey  <tom@tromey.com>
5752
5753         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
5754
5755 2018-02-08  Tom Tromey  <tom@tromey.com>
5756
5757         * source.c (find_source_lines): Use gdb::def_vector.
5758
5759 2018-02-08  Tom Tromey  <tom@tromey.com>
5760
5761         * macrocmd.c (struct temporary_macro_definition): New.
5762         (macro_define_command): Use temporary_macro_definition.  Remove
5763         cleanups.
5764         (free_macro_definition_ptr): Remove.
5765
5766 2018-02-08  Tom Tromey  <tom@tromey.com>
5767
5768         * macroexp.c (maybe_expand): Use std::string.
5769
5770 2018-02-08  Tom Tromey  <tom@tromey.com>
5771
5772         * macroexp.c (struct macro_buffer): Add initializers for some
5773         members.
5774         (init_buffer, init_shared_buffer, free_buffer)
5775         (free_buffer_return_text): Remove.
5776         (macro_buffer): New constructors.
5777         (~macro_buffer): New destructor.
5778         (macro_buffer::set_shared): New method.
5779         (macro_buffer::resize_buffer, macro_buffer::appendc)
5780         (macro_buffer::appendmem): Now methods, not free functions.
5781         (set_token, append_tokens_without_splicing, stringify)
5782         (macro_stringify): Update.
5783         (gather_arguments): Change return type.  Remove argc_p argument,
5784         add args_ptr argument.  Use std::vector.
5785         (substitute_args): Remove argc argument.  Accept std::vector.
5786         (expand): Update.  Use std::vector.
5787         (scan, macro_expand, macro_expand_next): Update.
5788
5789 2018-02-08  Tom Tromey  <tom@tromey.com>
5790
5791         * symtab.c (default_collect_symbol_completion_matches_break_on):
5792         Use unique_xmalloc_ptr.
5793         * macroscope.h: (sal_macro_scope, user_macro_scope)
5794         (default_macro_scope): Return unique_xmalloc_ptr.
5795         * macroscope.c (sal_macro_scope, user_macro_scope)
5796         (default_macro_scope): Return unique_xmalloc_ptr.
5797         * macroexp.h (macro_expand, macro_expand_once): Return
5798         unique_xmalloc_ptr.
5799         * macroexp.c (macro_expand, macro_expand_once): Return
5800         unique_xmalloc_ptr.
5801         * macrocmd.c (macro_expand_command, macro_expand_once_command)
5802         (info_macro_command, info_macros_command): Use
5803         unique_xmalloc_ptr.
5804         * compile/compile-c-support.c (write_macro_definitions): Use
5805         unique_xmalloc_ptr.
5806         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
5807
5808 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
5809
5810         * value.c (value_static_field): Assign field type instead of
5811         containing type when returning an optimized out value.
5812
5813 2018-02-06  Yao Qi  <yao.qi@linaro.org>
5814
5815         * ft32-tdep.c (ft32_read_pc): Remove.
5816         (ft32_write_pc): Remove.
5817         (ft32_gdbarch_init): Update.
5818         * m32r-tdep.c (m32r_read_pc): Remove.
5819         (m32r_gdbarch_init): Update.
5820         * mep-tdep.c (mep_read_pc): Remove.
5821         (mep_gdbarch_init): Update.
5822         * microblaze-tdep.c (microblaze_write_pc): Remove.
5823         (microblaze_gdbarch_init): Update.
5824         * mn10300-tdep.c (mn10300_read_pc): Remove.
5825         (mn10300_write_pc): Remove.
5826         (mn10300_gdbarch_init): Update.
5827         * moxie-tdep.c (moxie_read_pc): Remove.
5828         (moxie_write_pc): Remove.
5829         (moxie_gdbarch_init): Update.
5830
5831 2018-02-06  Yao Qi  <yao.qi@linaro.org>
5832
5833         * expprint.c (print_subexp_standard): Handle
5834         OP_F77_UNDETERMINED_ARGLIST.
5835         (dump_subexp_body_standard): Likewise.
5836
5837 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
5838
5839         * target-descriptions.c (tdesc_element_visitor) Add empty
5840         implementations.
5841         (tdesc_type): Move make_gdb_type from here.
5842         (tdesc_type_builtin): Likewise.
5843         (tdesc_type_vector): Likewise.
5844         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
5845         (make_gdb_type_struct): Move from tdesc_type_with_fields.
5846         (make_gdb_type_union): Likewise.
5847         (make_gdb_type_flags): Likewise.
5848         (make_gdb_type_enum): Likewise.
5849         (make_gdb_type): New function.
5850         (tdesc_register_type): Use static make_gdb_type.
5851
5852 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
5853
5854         * infcmd.c (default_print_one_register_info): Align natural-format
5855         column values consistently one under another.
5856         (pad_to_column): New function.
5857
5858 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
5859
5860         * dwarf2read.c (dwarf2_physname): Move commment.
5861
5862 2018-02-01  Leszek Swirski  <leszeks@google.com>
5863
5864         * varobj.c (varobj_formatted_print_options): Allow recursive
5865         pretty printing if pretty printing is enabled.
5866
5867 2018-02-01  Leszek Swirski  <leszeks@google.com>
5868
5869         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
5870         names after a structop as a filename.
5871
5872 2018-02-01  Yao Qi  <yao.qi@linaro.org>
5873
5874         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
5875         (arm_record_coproc_data_proc): Likewise.
5876
5877 2018-02-01  Yao Qi  <yao.qi@linaro.org>
5878
5879         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
5880
5881 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
5882
5883         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
5884         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
5885
5886 2018-01-31  Pedro Alves  <palves@redhat.com>
5887
5888         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
5889         * inflow.c (child_terminal_save_inferior): Wrap reference to
5890         tcgetpgrp in HAVE_TERMIOS_H.
5891         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
5892         _WIN32.
5893         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
5894         always iterate over all inferiors.
5895         (gdbsim_cntrl_c): Adjust.
5896         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
5897
5898 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
5899
5900         * gdbtypes.c (lookup_array_range_type): Make sure the array's
5901         index type is objfile-owned if the element type is as well.
5902
5903 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
5904
5905         GDB 8.1 released.
5906
5907 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5908
5909         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
5910         "features/s390x-linux64.c".
5911         (_initialize_s390_linux_tdep): Remove initialization of tdescs
5912         s390_linux32 and s390x_linux64.
5913         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
5914         default tdesc.
5915         * s390-tdep.c: Include "features/s390-linux32.c" and
5916         "features/s390x-linux64.c".
5917         (s390_tdesc_valid): Add check for tdesc_has_registers.
5918         (s390_gdbarch_init): Make sure there is always a valid tdesc.
5919         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
5920         tdesc_s390x_linux64.
5921         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
5922         tdesc_s390x_linux64 to...
5923         * s390-tdep.h: ...here.
5924
5925 2018-01-30  Pedro Alves  <palves@redhat.com>
5926
5927         PR gdb/13211
5928         * config.in, configure: Regenerate.
5929         * configure.ac: Check for getpgid.
5930         * go32-nat.c (go32_pass_ctrlc): New.
5931         (go32_target): Install it.
5932         * inf-child.c (inf_child_target): Install
5933         child_terminal_save_inferior, child_pass_ctrlc and
5934         child_interrupt.
5935         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
5936         (inf_ptrace_target): No longer install it.
5937         * infcmd.c (interrupt_target_1): Adjust.
5938         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
5939         (child_interrupt): Declare.
5940         (inferior::terminal_state): New.
5941         * inflow.c (struct terminal_info): Update comments.
5942         (inferior_process_group): Delete.
5943         (terminal_is_ours): Delete.
5944         (gdb_tty_state): New.
5945         (child_terminal_init): Adjust.
5946         (is_gdb_terminal, sharing_input_terminal_1)
5947         (sharing_input_terminal): New functions.
5948         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
5949         Set the process's actual process group in the foreground if
5950         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
5951         mark terminal as the inferior's if not sharing GDB's terminal.
5952         Don't check attach_flag.
5953         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
5954         pass down a target_terminal_state.
5955         (child_terminal_save_inferior): New, factored out from ...
5956         (child_terminal_ours_1): ... this.  Handle
5957         target_terminal_state::is_ours_for_output.
5958         (child_interrupt, child_pass_ctrlc): New.
5959         (inflow_inferior_exit): Clear the inferior's terminal_state.
5960         (copy_terminal_info): Copy the inferior's terminal state.
5961         (_initialize_inflow): Remove reference to terminal_is_ours.
5962         * inflow.h (inferior_process_group): Delete.
5963         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
5964         * procfs.c (procfs_target): Don't install procfs_interrupt.
5965         (procfs_interrupt): Delete.
5966         * remote.c (remote_serial_quit_handler): Adjust.
5967         (remote_interrupt): Remove ptid parameter.  Adjust.
5968         * target-delegates.c: Regenerate.
5969         * target.c: Include "terminal.h".
5970         (target_terminal::terminal_state): Rename to ...
5971         (target_terminal::m_terminal_state): ... this.
5972         (target_terminal::init): Adjust.
5973         (target_terminal::inferior): Adjust to per-inferior
5974         terminal_state.
5975         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
5976         (target_terminal::ours, target_terminal::ours_for_output): Use
5977         target_terminal_is_ours_kind.
5978         (target_interrupt): Remove ptid parameter.  Adjust.
5979         (default_target_pass_ctrlc): Adjust.
5980         * target.h (target_ops::to_terminal_save_inferior): New field.
5981         (target_ops::to_interrupt): Remove ptid_t parameter.
5982         (target_interrupt): Remove ptid_t parameter.  Update comment.
5983         (target_pass_ctrlc): Update comment.
5984         * target/target.h (target_terminal_state): New scoped enum,
5985         factored out of ...
5986         (target_terminal::terminal_state): ... here.
5987         (target_terminal::inferior): Update comments.
5988         (target_terminal::restore_inferior): New.
5989         (target_terminal::is_inferior, target_terminal::is_ours)
5990         (target_terminal::is_ours_for_output): Adjust.
5991         (target_terminal::scoped_restore_terminal_state): Adjust to
5992         rename, and call restore_inferior() instead of inferior().
5993         (target_terminal::scoped_restore_terminal_state::m_state): Change
5994         type.
5995         (target_terminal::terminal_state): Rename to ...
5996         (target_terminal::m_terminal_state): ... this and change type.
5997
5998 2018-01-30  Pedro Alves  <palves@redhat.com>
5999
6000         * linux-nat.c (wait_for_signal): New function.
6001         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
6002         directly.
6003         (async_terminal_is_ours)
6004         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
6005         (linux_nat_add_target): Don't override
6006         to_terminal_inferior/to_terminal_ours.
6007
6008 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6009
6010         * remote.c (remote_follow_fork): Don't call "detach_inferior".
6011
6012 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
6013
6014         * dwarf2read.c (free_dwo_files): Add forward-declaration.
6015         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
6016         dwarf2_per_objfile_free here.
6017         (dwarf2_per_objfile_free): Remove.
6018         (_initialize_dwarf2_read): Don't register
6019         dwarf2_per_objfile_free as a registry cleanup.
6020
6021 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
6022
6023         Avoid compilation errors in MinGW native builds
6024
6025         The error is triggered by including python-internal.h, and the
6026         error message is:
6027
6028              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
6029                       from build-gnulib/import/math.h:27,
6030                       from d:/usr/Python26/include/pyport.h:235,
6031                       from d:/usr/Python26/include/Python.h:58,
6032                       from python/python-internal.h:94,
6033                       from python/py-arch.c:24:
6034              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
6035         using ::hypot;
6036                 ^~~~~
6037
6038         This happens because Python headers define 'hypot' to expand t
6039         '_hypot' in the Windows builds.
6040         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
6041         'hypoth'.  This avoids a compilation error.
6042
6043 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6044
6045         * MAINTAINERS (Write After Approval): Fix ordering.
6046
6047 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6048
6049         * MAINTAINERS (Write After Approval): Add Alan Hayward.
6050
6051 2018-01-26  Alan Modra  <amodra@gmail.com>
6052
6053         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
6054         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
6055         Remove nop.  Make const.  Comment.
6056         (powerpc32_plt_stub_so_2): New.
6057         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
6058         Correct count.  Update uses.
6059         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
6060         Move common code reading PLT entry word.  Correct
6061         powerpc32_plt_stub PLT address calculation.
6062         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
6063         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
6064         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
6065         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
6066         (ppc64_standard_linkage8): Likewise.
6067         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
6068         Correct insns description.
6069         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
6070
6071 2018-01-24  Pedro Alves  <palves@redhat.com>
6072
6073         GCC PR libstdc++/83906
6074         * gdbtypes.c (operator==(const dynamic_prop &,
6075         const dynamic_prop &)): New.
6076         (operator==(const range_bounds &, const range_bounds &)): New.
6077         (check_types_equal): Use them instead of memcmp.
6078         * gdbtypes.h (operator==(const dynamic_prop &,
6079         const dynamic_prop &)): Declare.
6080         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
6081         (operator==(const range_bounds &, const range_bounds &)): Declare.
6082         (operator!=(const range_bounds &, const range_bounds &)): Declare.
6083
6084 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6085
6086         * s390-linux-tdep.c (s390_record_address_mask)
6087         (s390_record_calc_disp_common, s390_record_calc_disp)
6088         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6089         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6090         (s390_process_record): Move to s390-tdep.c.
6091         (s390_linux_init_abi_any): Adjust.
6092         * s390-tdep.c (s390_record_address_mask)
6093         (s390_record_calc_disp_common, s390_record_calc_disp)
6094         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6095         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6096         (s390_process_record): Moved from s390-linux-tdep.c
6097         (s390_gdbarch_init): Adjust.
6098
6099 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6100
6101         * s390-linux-nat.c (s390-tdep.h): New include.
6102         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
6103         (HFILES_NO_SRCDIR): Add s390-tdep.h.
6104         (ALLDEPFILES): Add s390-tdep.c.
6105         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
6106         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
6107         * s390-tdep.h: ...this.  New file.
6108         * s390-linux-tdep.c (s390-tdep.h): New include.
6109         (_initialize_s390_tdep): Rename to...
6110         (_initialize_s390_linux_tdep): ...this and adjust.
6111         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
6112         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
6113         s390-tdep.h.
6114         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
6115         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
6116         (s390_is_partial_instruction, s390_software_single_step)
6117         (is_non_branch_ril, s390_displaced_step_copy_insn)
6118         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
6119         (s390_prologue_data, s390_addr, s390_store, s390_load)
6120         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
6121         (s390_register_call_saved, s390_guess_tracepoint_registers)
6122         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
6123         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
6124         (s390_pseudo_register_name, s390_pseudo_register_type)
6125         (s390_pseudo_register_read, s390_pseudo_register_write)
6126         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
6127         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
6128         (s390_addr_bits_remove, s390_address_class_type_flags)
6129         (s390_address_class_type_flags_to_name)
6130         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
6131         (s390_function_arg_float, s390_function_arg_vector)
6132         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
6133         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
6134         (s390_frame_align, s390_register_return_value, s390_return_value)
6135         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
6136         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
6137         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
6138         (s390_trad_frame_prev_register, s390_unwind_cache)
6139         (s390_prologue_frame_unwind_cache)
6140         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
6141         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
6142         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
6143         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
6144         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
6145         (s390_frame_base_address, s390_local_base_address)
6146         (s390_frame_base, s390_gcc_target_options)
6147         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
6148         (s390_validate_reg_range, s390_tdesc_valid)
6149         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
6150         * s390-tdep.c: ...this.  New file.
6151
6152 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6153
6154         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
6155         (s390_process_record, s390_gdbarch_tdep_alloc)
6156         (s390_linux_init_abi_any): Use/set new hook.
6157
6158 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6159
6160         * s390-linux-tdep.c (osabi.h): New include.
6161         (s390_linux_init_abi_31, s390_linux_init_abi_64)
6162         (s390_linux_init_abi_any): New functions.
6163         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
6164
6165 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6166
6167         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
6168         tdesc_has_registers check
6169
6170 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6171
6172         * s390-linux-tdep.c (s390_tdesc_valid): New function.
6173         (s390_validate_reg_range): New macro.
6174         (s390_gdbarch_init): Adjust.
6175
6176 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6177
6178         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
6179         (s390_gdbarch_tdep_alloc): Adjust.
6180         (s390_gdbarch_init): Adjust.
6181
6182 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6183
6184         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
6185         <have_tdb>: Change type to bool.
6186         (s390_gdbarch_tdep_alloc): Adjust.
6187         (s390_gdbarch_init): Adjust.
6188
6189 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6190
6191         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
6192         (gdbarch_tdep) <have_upper, have_vx>: New fields.
6193         (s390_gdbarch_tdep_alloc): New function.
6194         (s390_gdbarch_init): Allocate tdep at start and use its fields
6195         instead of separate variables.
6196
6197 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6198
6199         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
6200         when looking for cached gdbarch and add comment for remaining.
6201
6202 2018-01-22  Pedro Alves  <palves@redhat.com>
6203             Sergio Durigan Junior  <sergiodj@redhat.com>
6204
6205         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
6206         case.
6207
6208 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
6209
6210         * MAINTAINERS: Update my company e-mail address.
6211
6212 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6213
6214         * regcache.c (cooked_write_test): New function.
6215         (_initialize_regcache): Register the test.
6216
6217 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6218
6219         * ia64-tdep.c (ia64_pseudo_register_read): Call
6220         regcache->cooked_read instead of regcache_cooked_read_unsigned.
6221         * m32c-tdep.c (m32c_cat_read): Likewise.
6222         (m32c_r3r2r1r0_read): Likewise.
6223         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6224         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6225
6226 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6227
6228         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
6229         method raw_read instead of regcache_raw_read.
6230         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6231         * arm-tdep.c (arm_neon_quad_read): Likewise.
6232         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6233         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6234         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6235         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
6236         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6237         (i386_pseudo_register_read_into_value): Likewise.
6238         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6239         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6240         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6241         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
6242         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
6243         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
6244         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6245         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
6246         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
6247
6248 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6249
6250         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
6251         * configure.tgt: Remove target mt.
6252         * mt-tdep.c: Remove.
6253         * regcache.c (cooked_read_test): Remove the check for mt.
6254
6255 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6256
6257         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
6258         instead of gdbarch_pseudo_register_read_value.
6259
6260 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6261
6262         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
6263         language is Ada.
6264
6265 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6266
6267         * linespec.c (create_sals_line_offset): Remove code that preserved
6268         the symtab_and_line's line number.
6269
6270 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6271
6272         * varobj.c (varobj_create): Don't set valid_block when creating a
6273         floating varobj.
6274
6275 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6276
6277         * varobj.c (varobj_create): Remove out of date comment.
6278
6279 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6280
6281         PR mi/20395
6282         * ada-exp.y (write_var_from_sym): Pass extra parameter when
6283         updating innermost block.
6284         * parse.c (innermost_block_tracker::update): Take extra type
6285         parameter, and check types match before updating innermost block.
6286         (write_dollar_variable): Update innermost block for registers.
6287         * parser-defs.h (enum innermost_block_tracker_type): New enum.
6288         (innermost_block_tracker::innermost_block_tracker): Initialise
6289         m_types member.
6290         (innermost_block_tracker::reset): Take type parameter.
6291         (innermost_block_tracker::update): Take type parameter, and pass
6292         type through as needed.
6293         (innermost_block_tracker::m_types): New member.
6294         * varobj.c (varobj_create): Pass type when reseting innermost
6295         block.
6296
6297 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6298
6299         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
6300         * ada-lang.c (resolve_subexp): Likewise.
6301         * breakpoint.c (set_breakpoint_condition) Likewise.
6302         (watch_command_1) Likewise.
6303         * c-exp.y (variable): Likewise.
6304         * d-exp.y (PrimaryExpression): Likewise.
6305         * f-exp.y (variable): Likewise.
6306         * go-exp.y (variable): Likewise.
6307         * m2-exp.y (variable): Likewise.
6308         * objfiles.c (objfile::~objfile): Likewise.
6309         * p-exp.y (variable): Likewise.
6310         * parse.c (innermost_block): Change type.
6311         * parser-defs.h (class innermost_block_tracker): New.
6312         (innermost_block): Change to innermost_block_tracker.
6313         * printcmd.c (display_command): Switch to innermost_block API.
6314         (do_one_display): Likewise.
6315         * rust-exp.y (do_one_display): Likewise.
6316         * symfile.c (clear_symtab_users): Likewise.
6317         * varobj.c (varobj_create): Switch to innermost_block API, replace
6318         use of innermost_block with block stored on varobj object.
6319
6320 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6321
6322         * expression.h (innermost_block): Remove declaration.
6323         * varobj.c: Add 'parser-defs.h' include.
6324
6325 2018-01-19  Tom Tromey  <tom@tromey.com>
6326
6327         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
6328         symbols in the static and global blocks.
6329
6330 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
6331
6332         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
6333         gdb_ptrace.h, and move including gdb_wait.h ...
6334         * nat/linux-ptrace.h: ... to here.
6335
6336 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6337
6338         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
6339         inf_ptrace_detach_success.
6340         (inf_ptrace_detach_success): Add inferior parameter, use it
6341         instead of inferior_ptid, pass it to detach_inferior.
6342         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
6343         parameter.
6344         * inferior.c (detach_inferior): Add overload that takes an
6345         inferior object.
6346         * inferior.h (detach_inferior): Likewise.
6347         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
6348         use inferior_ptid, adjust call to inf_ptrace_detach_success.
6349         * linux-thread-db.c (thread_db_detach): Use inf parameter.
6350
6351 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6352
6353         * target.h (struct target_ops) <to_detach>: Add inferior
6354         parameter.
6355         (target_detach): Likewise.
6356         * target.c (dispose_inferior): Pass inferior down.
6357         (target_detach): Pass inferior down.  Assert that it is equal to
6358         the current inferior.
6359         * aix-thread.c (aix_thread_detach): Pass inferior down.
6360         * corefile.c (core_file_command): Pass current_inferior() down.
6361         * corelow.c (core_detach): Add inferior parameter.
6362         * darwin-nat.c (darwin_detach): Likewise.
6363         * gnu-nat.c (gnu_detach): Likewise.
6364         * inf-ptrace.c (inf_ptrace_detach): Likewise.
6365         * infcmd.c (detach_command): Pass current_inferior() down to
6366         target_detach.
6367         * infrun.c (follow_fork_inferior): Pass parent_inf to
6368         target_detach.
6369         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
6370         target_detach.
6371         * linux-nat.c (linux_nat_detach): Add inferior parameter.
6372         * linux-thread-db.c (thread_db_detach): Likewise.
6373         * nto-procfs.c (procfs_detach): Likewise.
6374         * procfs.c (procfs_detach): Likewise.
6375         * record.c (record_detach): Likewise.
6376         * record.h (struct inferior): Forward-declare.
6377         (record_detach): Add inferior parameter.
6378         * remote-sim.c (gdbsim_detach): Likewise.
6379         * remote.c (remote_detach_1): Likewise.
6380         (remote_detach): Likewise.
6381         (extended_remote_detach): Likewise.
6382         * sol-thread.c (sol_thread_detach): Likewise.
6383         * target-debug.h (target_debug_print_inferior_p): New macro.
6384         * target-delegates.c: Re-generate.
6385         * top.c (kill_or_detach): Pass inferior down to target_detach.
6386         * windows-nat.c (windows_detach): Add inferior parameter.
6387
6388 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6389
6390         * target.h (struct target_ops) <to_detach>: Remove args
6391         parameter.
6392         (target_detach): Likewise.
6393         * target.c (dispose_inferior): Adjust.
6394         (target_detach): Remove args parameter, adjust.
6395         * aix-thread.c (aix_thread_detach): Adjust.
6396         * corefile.c (core_file_command): Adjust.
6397         * corelow.c (core_detach): Adjust.
6398         * darwin-nat.c (darwin_detach): Adjust.
6399         * gnu-nat.c (gnu_detach): Adjust.
6400         * inf-ptrace.c (inf_ptrace_detach): Adjust.
6401         * infcmd.c (detach_command): Adjust
6402         * infrun.c (follow_fork_inferior): Adjust.
6403         (handle_vfork_child_exec_or_exit): Adjust.
6404         * linux-fork.c (linux_fork_detach): Remove args parameter.
6405         * linux-fork.h (linux_fork_detach): Likewise.
6406         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
6407         * linux-thread-db.c (thread_db_detach): Likewise.
6408         * nto-procfs.c (procfs_detach): Likewise.
6409         * procfs.c (procfs_detach): Likewise.
6410         (do_detach): Remove signo parameter.
6411         * record.c (record_detach): Remove args parameter.
6412         * record.h (record_detach): Likewise.
6413         * remote-sim.c (gdbsim_detach): Likewise.
6414         * remote.c (remote_detach_1): Likewise.
6415         (remote_detach): Likewise.
6416         (extended_remote_detach): Likewise.
6417         * sol-thread.c (sol_thread_detach): Likewise.
6418         * target-delegates.c: Re-generate.
6419         * top.c (struct qt_args) <args>: Remove field.
6420         (kill_or_detach): Don't pass args.
6421         (quit_force): Don't set args.
6422         * windows-nat.c (windows_detach): Remove args parameter.
6423
6424 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6425
6426         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
6427         (arm_linux_init_abi): Install it.
6428
6429 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6430
6431         * osabi.c (gdb_osabi_names): Extend the regexp for
6432         arm-linux-gnueabihf.
6433
6434 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6435
6436         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
6437         m_abbrevs.
6438         (abbrev_table::add_abbrev): Update.
6439         (abbrev_table::lookup_abbrev): Update.
6440
6441 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6442
6443         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
6444
6445 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
6446
6447         * compile/compile.c (compile_to_object): Convert "triplet_rx"
6448         to "std::string".
6449
6450 2018-01-17  Tom Tromey  <tom@tromey.com>
6451
6452         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
6453
6454 2018-01-17  Tom Tromey  <tom@tromey.com>
6455
6456         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
6457         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
6458         (create_array_type_with_stride): Update.
6459         * dwarf2read.c (set_die_type): Update.
6460
6461 2018-01-17  Tom Tromey  <tom@tromey.com>
6462
6463         * dwarf2read.c (delayed_method_info): Remove typedef.
6464         (dwarf2_cu::method_info): Now a std::vector.
6465         (add_to_method_list): Update.
6466         (free_delayed_list): Remove.
6467         (compute_delayed_physnames): Update.
6468         (process_full_comp_unit, process_full_type_unit): Clear the method
6469         list.  Remove cleanups.
6470         (psymtab_include_file_name): Add name_holder parameter.  Use
6471         unique_xmalloc_ptr.
6472         (dwarf_decode_lines): Update.
6473
6474 2018-01-17  Tom Tromey  <tom@tromey.com>
6475             Simon Marchi  <simon.marchi@ericsson.com>
6476
6477         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
6478         (dwarf2_per_objfile::free_cached_comp_units)
6479         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6480         (init_cutu_and_read_dies_no_follow): Update.
6481         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
6482         (dwarf2_cu::~dwarf2_cu): New.
6483         (free_heap_comp_unit, free_stack_comp_unit): Remove.
6484         (age_cached_comp_units, free_one_cached_comp_unit): Update.
6485
6486 2018-01-17  Tom Tromey  <tom@tromey.com>
6487             Simon Marchi  <simon.marchi@ericsson.com>
6488
6489         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
6490         (struct die_reader_specs) <abbrev_table>: New member.
6491         (struct abbrev_table): Add constructor.
6492         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
6493         <abbrev_obstack>: Now an auto_obstack.
6494         (abbrev_table_up): New typedef.
6495         (init_cu_die_reader): Add abbrev_table parameter.
6496         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
6497         Add result_dwo_abbrev_table.
6498         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6499         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
6500         Update.
6501         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
6502         parameter.
6503         (skip_children): Update.
6504         (abbrev_table::alloc_abbrev): Rename from
6505         abbrev_table_alloc_abbrev.
6506         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
6507         (abbrev_table::lookup_abbrev): Rename from
6508         abbrev_table_lookup_abbrev.
6509         (abbrev_table_read_table): Return abbrev_table_up.
6510         (abbrev_table_free, abbrev_table_free_cleanup)
6511         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
6512         (load_partial_dies): Update.
6513
6514 2018-01-17  Tom Tromey  <tom@tromey.com>
6515
6516         * dwarf2read.c (dwarf2_compute_name): Update comment.
6517         (read_func_scope, read_variable): Update.
6518         (new_symbol): Remove.
6519         (new_symbol_full): Rename to new_symbol.
6520
6521 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
6522
6523         PR gdb/16577
6524         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
6525         a warning instead of throwing an error, set section size to 0 and return
6526         NULL.
6527         * gdb_bfd.h (gdb_bfd_map_section): Update description.
6528
6529 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6530
6531         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
6532         std::string.
6533         (linux_ptrace_attach_fail_reason_string): Likewise.
6534         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
6535         Likewise.
6536         (linux_ptrace_attach_fail_reason_string): Likewise.
6537         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
6538
6539 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6540
6541         * linux-nat.c (linux_nat_attach): Remove xstrdup.
6542
6543 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
6544
6545         PR gdb/21559
6546         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
6547         checking for fs_base/gs_base fields in struct user_regs_struct.
6548         * configure: Regenerate.
6549
6550 2018-01-17  Yao Qi  <yao.qi@linaro.org>
6551
6552         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
6553         function.
6554         (aarch64_linux_init_abi): Install it to gdbarch hook
6555         gcc_target_options.
6556
6557 2018-01-15  Pedro Alves  <palves@redhat.com>
6558
6559         * common/signals-state-save-restore.c
6560         (save_original_signals_state): Fix typos.
6561
6562 2017-01-12  Tom Tromey  <tom@tromey.com>
6563             Sergio Durigan Junior  <sergiodj@redhat.com>
6564
6565         * Makefile.in (install-only): Install gdb-add-index.
6566
6567 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
6568
6569         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
6570
6571 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
6572
6573         * infrun.c (keep_going_pass_signal): Clear step-over info when
6574         insert_breakpoints fails.
6575
6576 2018-01-11  Pedro Alves  <palves@redhat.com>
6577
6578         PR gdb/22583
6579         * infrun.c (resume): Rename to ...
6580         (resume_1): ... this.
6581         (resume): Reimplement as wrapper around resume_1.
6582
6583 2018-01-11  Pedro Alves  <palves@redhat.com>
6584
6585         PR remote/22597
6586         * remote.c (remote_parse_stop_reply): Default to the last-set
6587         general thread instead of to 'magic_null_ptid'.
6588
6589 2018-01-10  Pedro Alves  <palves@redhat.com>
6590
6591         * language.h (language_get_symbol_name_matcher): Rename ...
6592         (get_symbol_name_matcher): ... this.
6593         * language.c (language_get_symbol_name_matcher): Ditto.
6594         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
6595         callers adjusted.
6596
6597 2018-01-10  Pedro Alves  <palves@redhat.com>
6598
6599         PR gdb/22670
6600         * dwarf2read.c
6601         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
6602         Adjust to use language_get_symbol_name_matcher instead of
6603         language_defn::la_get_symbol_name_matcher.
6604         * language.c (language_get_symbol_name_matcher): If in Ada mode
6605         and the lookup name is a verbatim match, return Ada's matcher.
6606         * language.h (language_get_symbol_name_matcher): Adjust comment.
6607         (ada_lookup_name_info::verbatim_p):: New method.
6608
6609 2018-01-10  Pedro Alves  <palves@redhat.com>
6610
6611         PR gdb/22670
6612         * ada-lang.c (ada_collect_symbol_completion_matches): If the
6613         minsym's language is language_auto or language_cplus, pass down
6614         language_ada instead.
6615         * symtab.c (compare_symbol_name): Don't frob symbol language here.
6616
6617 2018-01-10  Pedro Alves  <palves@redhat.com>
6618
6619         PR gdb/22670
6620         * minsyms.c (linkage_name_str): New function.
6621         (iterate_over_minimal_symbols): Use it.
6622
6623 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6624
6625         * NEWS: Document that 'info proc' now works on FreeBSD.
6626
6627 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6628
6629         * configure.ac: Check for kinfo_getfile in libutil.
6630         * configure: Regenerate.
6631         * config.in: Regenerate.
6632         * fbsd-nat.c: Include "fbsd-tdep.h".
6633         (fbsd_fetch_cmdline): New.
6634         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
6635         rather than calling error.
6636         (fbsd_info_proc): New.
6637         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
6638         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
6639         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
6640
6641 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6642
6643         * fbsd-nat.c (struct free_deleter): Remove.
6644         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
6645
6646 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6647
6648         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
6649         NULL for an empty pathname.
6650
6651 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6652
6653         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
6654         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
6655         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
6656         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
6657         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
6658         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
6659         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
6660         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
6661         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
6662         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
6663         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
6664         (fbsd_core_fetch_timeval, fbsd_print_sigset)
6665         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
6666         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
6667         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
6668
6669 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
6670
6671         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
6672         (gnu_xfer_auxv): New function.
6673         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
6674         TARGET_OBJECT_AUXV.
6675
6676 2018-01-08  Yao Qi  <yao.qi@linaro.org>
6677             Simon Marchi  <simon.marchi@ericsson.com>
6678
6679         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
6680         common/selftest.c.
6681         (COMMON_OBS): Remove selftest.o.
6682         * configure.ac: Append selftest-arch.c and common/selftest.c to
6683         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
6684         * configure: Re-generated.
6685         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
6686         GDB_SELF_TEST.
6687         (maintenance_info_selftests): Likewise.
6688
6689 2018-01-08  Xavier Roirand  <roirand@adacore.com>
6690
6691         * ada-valprint.c (val_print_packed_array_elements): Use
6692         proper number of elements when printing an array indexed
6693         by an enumeration type.
6694
6695 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6696
6697         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
6698         (dw2_get_file_names_reader): Adjust.
6699         (lookup_dwo_signatured_type): Adjust.
6700         (lookup_dwp_signatured_type): Adjust.
6701         (lookup_signatured_type): Adjust.
6702         (create_type_unit_group): Adjust.
6703         (get_type_unit_group): Adjust.
6704         (process_psymtab_comp_unit_reader): Adjust.
6705         (build_type_psymtabs_reader): Adjust.
6706         (scan_partial_symbols): Adjust.
6707         (add_partial_symbol): Adjust.
6708         (add_partial_subprogram): Adjust.
6709         (peek_die_abbrev): Adjust.
6710         (fixup_go_packaging): Adjust.
6711         (process_imported_unit_die): Adjust.
6712         (dwarf2_compute_name): Adjust.
6713         (dwarf2_physname): Adjust.
6714         (read_import_statement): Adjust.
6715         (handle_DW_AT_stmt_list): Adjust.
6716         (read_file_scope): Adjust.
6717         (read_func_scope): Adjust.
6718         (read_lexical_block_scope): Adjust.
6719         (read_call_site_scope): Adjust.
6720         (read_variable): Adjust.
6721         (dwarf2_rnglists_process): Adjust.
6722         (dwarf2_ranges_process): Adjust.
6723         (dwarf2_ranges_read): Adjust.
6724         (dwarf2_get_pc_bounds): Adjust.
6725         (dwarf2_record_block_ranges): Adjust.
6726         (dwarf2_add_field): Adjust.
6727         (dwarf2_add_member_fn): Adjust.
6728         (read_structure_type): Adjust.
6729         (process_structure_scope): Adjust.
6730         (read_enumeration_type): Adjust.
6731         (read_array_type): Adjust.
6732         (mark_common_block_symbol_computed): Adjust.
6733         (read_common_block): Adjust.
6734         (read_namespace_type): Adjust.
6735         (read_namespace): Adjust.
6736         (read_module_type): Adjust.
6737         (read_tag_pointer_type): Adjust.
6738         (read_tag_ptr_to_member_type): Adjust.
6739         (read_tag_string_type): Adjust.
6740         (read_subroutine_type): Adjust.
6741         (read_typedef): Adjust.
6742         (read_base_type): Adjust.
6743         (attr_to_dynamic_prop): Adjust.
6744         (read_subrange_type): Adjust.
6745         (read_unspecified_type): Adjust.
6746         (dwarf2_read_abbrevs): Adjust.
6747         (load_partial_dies): Adjust.
6748         (read_partial_die): Adjust.
6749         (find_partial_die): Adjust.
6750         (guess_partial_die_structure_name): Adjust.
6751         (fixup_partial_die): Adjust.
6752         (read_attribute_value): Adjust.
6753         (read_addr_index): Adjust.
6754         (read_addr_index_from_leb128): Adjust.
6755         (read_str_index): Adjust.
6756         (dwarf2_string_attr): Adjust.
6757         (get_debug_line_section): Adjust.
6758         (dwarf_decode_line_header): Adjust.
6759         (lnp_state_machine::check_line_address): Adjust.
6760         (dwarf_decode_lines_1): Adjust.
6761         (dwarf_decode_lines): Adjust.
6762         (dwarf2_start_symtab): Adjust.
6763         (var_decode_location): Adjust.
6764         (new_symbol_full): Adjust.
6765         (dwarf2_const_value_data): Adjust.
6766         (dwarf2_const_value_attr): Adjust.
6767         (dwarf2_const_value): Adjust.
6768         (die_type): Adjust.
6769         (die_containing_type): Adjust.
6770         (build_error_marker_type): Adjust.
6771         (lookup_die_type): Adjust.
6772         (guess_full_die_structure_name): Adjust.
6773         (anonymous_struct_prefix): Adjust.
6774         (determine_prefix): Adjust.
6775         (dwarf2_name): Adjust.
6776         (follow_die_ref_or_sig): Adjust.
6777         (follow_die_offset): Adjust.
6778         (follow_die_ref): Adjust.
6779         (follow_die_sig_1): Adjust.
6780         (follow_die_sig): Adjust.
6781         (get_signatured_type): Adjust.
6782         (get_DW_AT_signature_type): Adjust.
6783         (decode_locdesc): Adjust.
6784         (dwarf_decode_macros): Adjust.
6785         (cu_debug_loc_section): Adjust.
6786         (fill_in_loclist_baton): Adjust.
6787         (dwarf2_symbol_mark_computed): Adjust.
6788         (init_one_comp_unit): Don't assign
6789         dwarf2_cu::dwarf2_per_objfile.
6790         (set_die_type): Adjust.
6791
6792 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6793
6794         * dwarf2read.c (struct mapped_debug_names): Add constructor.
6795         <dwarf2_per_objfile>: New field.
6796         (dwarf2_per_objfile): Remove global.
6797         (get_dwarf2_per_objfile): New function.
6798         (set_dwarf2_per_objfile): New function.
6799         (dwarf2_build_psymtabs_hard): Change objfile parameter to
6800         dwarf2_per_objfile.
6801         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
6802         (read_abbrev_offset): Likewise.
6803         (read_indirect_string): Likewise.
6804         (read_indirect_line_string): Likewise.
6805         (read_indirect_string_at_offset): Likewise.
6806         (read_indirect_string_from_dwz): Likewise.
6807         (dwarf2_find_containing_comp_unit): Change objfile parameter to
6808         dwarf2_per_objfile.
6809         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
6810         (create_all_comp_units): Change objfile parameter to
6811         dwarf2_per_objfile.
6812         (create_all_type_units): Likewise.
6813         (process_queue): Add dwarf2_per_objfile parameter.
6814         (read_and_check_comp_unit_head): Likewise.
6815         (lookup_dwo_unit_in_dwp): Likewise.
6816         (get_dwp_file): Likewise.
6817         (process_cu_includes): Likewise.
6818         (struct free_dwo_file_cleanup_data): New struct.
6819         (dwarf2_has_info): Use get_dwarf2_per_objfile and
6820         set_dwarf2_per_objfile.
6821         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
6822         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
6823         context, adjust calls.
6824         (dw2_instantiate_symtab): Likewise.
6825         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
6826         (dw2_get_cu): Likewise.
6827         (create_cu_from_index_list): Change objfile parameter to
6828         dwarf2_per_objfile.
6829         (create_cus_from_index_list): Get dwarf2_per_objfile from
6830         context, adjust calls.
6831         (create_cus_from_index): Likewise.
6832         (create_signatured_type_table_from_index): Change objfile
6833         parameter to dwarf2_per_objfile.
6834         (create_signatured_type_table_from_debug_names): Change objfile
6835         parameter to dwarf2_per_objfile.
6836         (create_addrmap_from_index): Likewise.
6837         (create_addrmap_from_aranges): Likewise.
6838         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
6839         (dw2_setup): Remove.
6840         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
6841         context.
6842         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
6843         get_dwarf2_per_objfile.
6844         (dw2_forget_cached_source_info): Likewise.
6845         (dw2_map_symtabs_matching_filename): Likewise.
6846         (struct dw2_symtab_iterator) <index>: Remove.
6847         <dwarf2_per_objfile>: New field.
6848         (dw2_symtab_iter_init): Replace index parameter with
6849         dwarf2_per_objfile.
6850         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
6851         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
6852         (dw2_print_stats): Likewise.
6853         (dw2_dump): Likewise.
6854         (dw2_expand_symtabs_for_function): Likewise.
6855         (dw2_expand_all_symtabs): Likewise.
6856         (dw2_expand_symtabs_with_fullname): Likewise.
6857         (dw2_expand_marked_cus): Replace index and objfile parameters
6858         with dwarf2_per_objfile.
6859         (dw_expand_symtabs_matching_file_matcher): Add
6860         dwarf2_per_objfile parameter and adjust calls.
6861         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
6862         adjust calls.
6863         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
6864         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
6865         adjust calls.
6866         (create_cus_from_debug_names_list): Replace objfile parameter
6867         with dwarf2_per_objfile and adjust calls.
6868         (create_cus_from_debug_names): Likewise.
6869         (dwarf2_read_debug_names): Likewise.
6870         (mapped_debug_names::namei_to_name): Adjust call.
6871         (dw2_debug_names_iterator::next): Likewise.
6872         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
6873         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
6874         (dw2_debug_names_dump): Likewise.
6875         (dw2_debug_names_expand_symtabs_for_function): Likewise.
6876         (dw2_debug_names_expand_symtabs_matching): Likewise.
6877         (dwarf2_initialize_objfile): Likewise.
6878         (dwarf2_build_psymtabs): Likewise.
6879         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
6880         this_cu.
6881         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
6882         (read_and_check_comp_unit_head): Likewise.
6883         (read_abbrev_offset): Likewise.
6884         (create_debug_type_hash_table): Likewise.
6885         (create_debug_types_hash_table): Likewise.
6886         (create_all_type_units): Replace objfile parameter with
6887         dwarf2_per_objfile.
6888         (add_type_unit): Add dwarf2_per_objfile parameter.
6889         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
6890         with dwarf2_per_objfile.
6891         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
6892         (lookup_dwp_signatured_type): Likewise.
6893         (lookup_signatured_type): Likewise.
6894         (read_cutu_die_from_dwo): Likewise.
6895         (init_tu_and_read_dwo_dies): Likewise.
6896         (init_cutu_and_read_dies): Likewise.
6897         (init_cutu_and_read_dies_no_follow): Likewise.
6898         (allocate_type_unit_groups_table): Add objfile parameter.
6899         (create_type_unit_group): Use dwarf2_per_objfile from cu.
6900         (get_type_unit_group): Likewise.
6901         (process_psymtab_comp_unit): Update call.
6902         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
6903         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
6904         (print_tu_stats): Likewise.
6905         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
6906         in void* parameter.
6907         (build_type_psymtabs): Change objfile parameter to
6908         dwarf2_per_objfile.
6909         (process_skeletonless_type_unit): Use dwarf2_per_objfile
6910         passed in void* parameter.
6911         (process_skeletonless_type_units): Change objfile parameter to
6912         dwarf2_per_objfile.
6913         (set_partial_user): Likewise.
6914         (dwarf2_build_psymtabs_hard): Likewise.
6915         (read_comp_units_from_section): Likewise.
6916         (create_all_comp_units): Likewise.
6917         (scan_partial_symbols): Update calls.
6918         (add_partial_symbol): Likewise.
6919         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
6920         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
6921         (process_queue): Add dwarf2_per_objfile parameter.
6922         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
6923         (compute_compunit_symtab_includes): Likewise.
6924         (process_cu_includes): Add dwarf2_per_objfile parameter.
6925         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
6926         (process_full_type_unit): Likewise.
6927         (process_imported_unit_die): Update call.
6928         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
6929         (read_file_scope): Likewise.
6930         (allocate_dwo_file_hash_table): Add objfile parameter.
6931         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
6932         (create_cus_hash_table): Likewise.
6933         (create_dwp_hash_table): Likewise.
6934         (create_dwo_unit_in_dwp_v1): Likewise.
6935         (create_dwp_v2_section): Likewise.
6936         (create_dwo_unit_in_dwp_v2): Likewise.
6937         (lookup_dwo_unit_in_dwp): Likewise.
6938         (try_open_dwop_file): Likewise.
6939         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
6940         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
6941         cleanup to include a reference to dwarf2_per_objfile.
6942         (open_dwp_file): Add dwarf2_per_objfile parameter.
6943         (open_and_init_dwp_file): Likewise.
6944         (get_dwp_file): Likewise.
6945         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
6946         (queue_and_load_all_dwo_tus): Update call.
6947         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
6948         data.
6949         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
6950         (dwarf2_ranges_process): Likewise.
6951         (dwarf2_get_pc_bounds): Likewise.
6952         (mark_common_block_symbol_computed): Likewise.
6953         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
6954         (dwarf2_read_abbrevs): Update call.
6955         (read_partial_die): Use dwarf2_per_objfile from cu.
6956         (find_partial_die): Likewise.
6957         (fixup_partial_die): Likewise.
6958         (read_attribute_value): Likewise.
6959         (read_indirect_string_at_offset_from): Add objfile parameter.
6960         (read_indirect_string_at_offset): Add dwarf2_per_objfile
6961         parameter.
6962         (read_indirect_string_from_dwz): Add objfile parameter.
6963         (read_indirect_string): Add objfile parameter.
6964         (read_addr_index_1): Add dwarf2_per_objfile parameter.
6965         (read_addr_index): Use dwarf2_per_objfile from cu.
6966         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
6967         call dw2_setup.
6968         (read_str_index): Use dwarf2_per_objfile from cu.
6969         (get_debug_line_section): Likewise.
6970         (read_formatted_entries): Add dwarf2_per_objfile parameter.
6971         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
6972         (new_symbol_full): Use dwarf2_per_objfile from cu.
6973         (build_error_marker_type): Likewise.
6974         (lookup_die_type): Likewise.
6975         (determine_prefix): Likewise.
6976         (follow_die_offset): Likewise.
6977         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
6978         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
6979         (dwarf2_fetch_die_type_sect_off): Likewise.
6980         (dwarf2_get_die_type): Likewise.
6981         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
6982         (get_signatured_type): Likewise.
6983         (get_DW_AT_signature_type): Likewise.
6984         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
6985         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
6986         (cu_debug_loc_section): Likewise.
6987         (fill_in_loclist_baton): Likewise.
6988         (dwarf2_symbol_mark_computed): Likewise.
6989         (dwarf2_find_containing_comp_unit): Change objfile parameter to
6990         dwarf2_per_objfile.
6991         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
6992         parameter.
6993         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
6994         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
6995         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
6996         (set_die_type): Use dwarf2_free_objfile from cu.
6997         (get_die_type_at_offset): Likewise.
6998         (dwarf2_per_objfile_free): Don't assign global variable.
6999         (debug_names) <constructor>: Add dwarf2_per_objfile
7000         parameter, update m_debugstrlookup construction.
7001         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
7002         parameter.
7003         <m_dwarf2_per_objfile>: New field.
7004         <lookup>: Use m_dwarf2_per_objfile.
7005         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
7006         (psyms_seen_size): Likewise.
7007         (write_gdbindex): Replace objfile parameter with
7008         dwarf2_per_objfile.
7009         (write_debug_names): Likewise.
7010         (write_psymtabs_to_index): Likewise.
7011         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
7012         calls.
7013
7014 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7015
7016         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
7017         <dwarf2_per_objfile>: New field.
7018         (struct dwarf2_per_cu_data) <objfile>: Remove.
7019         <dwarf2_per_objfile>: New field.
7020         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
7021         of objfile.
7022         (create_signatured_type_table_from_index): Likewise.
7023         (create_debug_type_hash_table): Likewise.
7024         (fill_in_sig_entry_from_dwo_entry): Likewise.
7025         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
7026         (create_type_unit_group): Assign dwarf2_per_objfile instead of
7027         objfile.
7028         (create_partial_symtab): Access objfile through
7029         dwarf2_per_objfile.
7030         (process_psymtab_comp_unit_reader): Likewise.
7031         (read_comp_units_from_section): Likewise.
7032         (scan_partial_symbols): Likewise.
7033         (add_partial_symbol): Likewise.
7034         (add_partial_subprogram): Likewise.
7035         (peek_die_abbrev): Likewise.
7036         (fixup_go_packaging): Likewise.
7037         (process_full_comp_unit): Likewise.
7038         (process_full_type_unit): Likewise.
7039         (process_imported_unit_die): Likewise.
7040         (dwarf2_compute_name): Likewise.
7041         (dwarf2_physname): Likewise.
7042         (read_import_statement): Likewise.
7043         (create_cus_hash_table): Assign dwarf2_physname instead of
7044         objfile.
7045         (read_func_scope): Access objfile through dwarf2_per_objfile.
7046         (read_lexical_block_scope): Likewise.
7047         (read_call_site_scope): Likewise.
7048         (read_variable): Likewise.
7049         (dwarf2_rnglists_process): Likewise.
7050         (dwarf2_ranges_process): Likewise.
7051         (dwarf2_ranges_read): Likewise.
7052         (dwarf2_record_block_ranges): Likewise.
7053         (dwarf2_add_field): Likewise.
7054         (dwarf2_add_member_fn): Likewise.
7055         (read_structure_type): Likewise.
7056         (process_structure_scope): Likewise.
7057         (read_enumeration_type): Likewise.
7058         (read_array_type): Likewise.
7059         (read_common_block): Likewise.
7060         (read_namespace_type): Likewise.
7061         (read_namespace): Likewise.
7062         (read_module_type): Likewise.
7063         (read_tag_pointer_type): Likewise.
7064         (read_tag_ptr_to_member_type): Likewise.
7065         (read_tag_string_type): Likewise.
7066         (read_subroutine_type): Likewise.
7067         (read_typedef): Likewise.
7068         (read_base_type): Likewise.
7069         (attr_to_dynamic_prop): Likewise.
7070         (read_subrange_type): Likewise.
7071         (read_unspecified_type): Likewise.
7072         (load_partial_dies): Likewise.
7073         (read_partial_die): Likewise.
7074         (find_partial_die): Likewise.
7075         (guess_partial_die_structure_name): Likewise.
7076         (fixup_partial_die): Likewise.
7077         (read_attribute_value): Likewise.
7078         (read_addr_index_from_leb128): Likewise.
7079         (dwarf2_read_addr_index): Likewise.
7080         (dwarf2_string_attr): Likewise.
7081         (lnp_state_machine::check_line_address): Likewise.
7082         (dwarf_decode_lines_1): Likewise.
7083         (dwarf_decode_lines): Likewise.
7084         (dwarf2_start_symtab): Likewise.
7085         (var_decode_location): Likewise.
7086         (new_symbol_full): Likewise.
7087         (dwarf2_const_value_data): Likewise.
7088         (dwarf2_const_value_attr): Likewise.
7089         (dwarf2_const_value): Likewise.
7090         (die_type): Likewise.
7091         (die_containing_type): Likewise.
7092         (lookup_die_type): Likewise.
7093         (guess_full_die_structure_name): Likewise.
7094         (anonymous_struct_prefix): Likewise.
7095         (dwarf2_name): Likewise.
7096         (follow_die_ref_or_sig): Likewise.
7097         (follow_die_offset): Likewise.
7098         (follow_die_ref): Likewise.
7099         (dwarf2_fetch_die_loc_sect_off): Likewise.
7100         (dwarf2_fetch_constant_bytes): Likewise.
7101         (dwarf2_fetch_die_type_sect_off): Likewise.
7102         (dwarf2_get_die_type): Likewise.
7103         (follow_die_sig): Likewise.
7104         (decode_locdesc): Likewise.
7105         (dwarf2_per_cu_objfile): Likewise.
7106         (dwarf2_per_cu_text_offset): Likewise.
7107         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
7108         objfile.
7109         (set_die_type): Access objfile through
7110         dwarf2_per_objfile.
7111
7112 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7113
7114         * valprint.c (converted_character_d): Remove typedef.
7115         (DEF_VEC_O (converted_character_d)): Remove.
7116         (count_next_character): Use std::vector.
7117         (print_converted_chars_to_obstack): Likewise.
7118         (generic_printstr): Likewise.
7119
7120 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7121
7122         * xml-support.h (struct gdb_xml_value): Add constructor.
7123         <value>: Change type to unique_xmalloc_ptr.
7124         (gdb_xml_value_s): Remove typedef.
7125         (DEF_VEC_O (gdb_xml_value_s)): Remove.
7126         (gdb_xml_element_start_handler): Change parameter type to
7127         std::vector.
7128         (xml_find_attribute): Likewise.
7129         * xml-support.c (xml_find_attribute): Change parameter type to
7130         std::vector and adjust.
7131         (gdb_xml_values_cleanup): Remove.
7132         (gdb_xml_parser::start_element): Adjust to std::vector.
7133         (xinclude_start_include): Change paraeter type to std::vector
7134         and adjust.
7135         * btrace.c (check_xml_btrace_version): Likewise.
7136         (parse_xml_btrace_block): Likewise.
7137         (parse_xml_btrace_pt_config_cpu): Likewise.
7138         (parse_xml_btrace_pt): Likewise.
7139         (parse_xml_btrace_conf_bts): Likewise.
7140         (parse_xml_btrace_conf_pt): Likewise.
7141         * memory-map.c (memory_map_start_memory): Likewise.
7142         (memory_map_start_property): Likewise.
7143         * osdata.c (osdata_start_osdata): Likewise.
7144         (osdata_start_item): Likewise.
7145         (osdata_start_column): Likewise.
7146         * remote.c (start_thread): Likewise.
7147         * solib-aix.c (library_list_start_library): Likewise.
7148         (library_list_start_list): Likewise.
7149         * solib-svr4.c (library_list_start_library): Likewise.
7150         (svr4_library_list_start_list): Likewise.
7151         * solib-target.c (library_list_start_segment): Likewise.
7152         (library_list_start_section): Likewise.
7153         (library_list_start_library): Likewise.
7154         (library_list_start_list): Likewise.
7155         * tracepoint.c (traceframe_info_start_memory): Likewise.
7156         (traceframe_info_start_tvar): Likewise.
7157         * xml-syscall.c (syscall_start_syscall): Likewise.
7158         * xml-tdesc.c (tdesc_start_target): Likewise.
7159         (tdesc_start_feature): Likewise.
7160         (tdesc_start_reg): Likewise.
7161         (tdesc_start_union): Likewise.
7162         (tdesc_start_struct): Likewise.
7163         (tdesc_start_flags): Likewise.
7164         (tdesc_start_enum): Likewise.
7165         (tdesc_start_field): Likewise.
7166         (tdesc_start_enum_value): Likewise.
7167         (tdesc_start_vector): Likewise.
7168
7169 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7170
7171         * extension.h (struct xmethod_worker) <clone>: Remove.
7172         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
7173         Remove.
7174         (python_xmethod_worker::clone): Remove.
7175         * valops.c (find_overload_match): Use std::move instead of
7176         clone.
7177
7178 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7179
7180         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
7181         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
7182         <free_xmethod_worker_data>: Remove.
7183         <get_matching_xmethod_workers>: Chance VEC to std::vector.
7184         <get_xmethod_arg_types>: Remove.
7185         <get_xmethod_result_type>: Remove.
7186         <invoke_xmethod>: Remove.
7187         * extension.c (new_xmethod_worker): Remove.
7188         (clone_xmethod_worker): Remove.
7189         (get_matching_xmethod_workers): Return void, pass std::vector by
7190         pointer.
7191         (get_xmethod_arg_types): Rename to...
7192         (xmethod_worker::get_arg_types): ... this, and adjust.
7193         (get_xmethod_result_type): Rename to...
7194         (xmethod_worker::get_result_type): ... this, and adjust.
7195         (invoke_xmethod): Remove.
7196         (free_xmethod_worker): Remove.
7197         (free_xmethod_worker_vec): Remove.
7198         * extension.h (enum ext_lang_rc): Move here from
7199         extension-priv.h.
7200         (struct xmethod_worker): Add constructor and destructor.
7201         <data>: Remove.
7202         <value>: Remove.
7203         <invoke, clone, do_get_result_type, do_get_arg_types>: New
7204         virtual pure methods.
7205         <get_arg_types, get_result_type>: New methods.
7206         (xmethod_worker_ptr): Remove typedef.
7207         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
7208         (xmethod_worker_vec): Remove typedef.
7209         (xmethod_worker_up): New typedef.
7210         (invoke_xmethod): Remove.
7211         (clone_xmethod_worker): Remove.
7212         (free_xmethod_worker): Remove.
7213         (free_xmethod_worker_vec): Remove.
7214         (get_xmethod_arg_types): Remove.
7215         (get_xmethod_result_type): Remove.
7216         * valops.c (find_method_list): Use std::vector, don't use
7217         intermediate vector.
7218         (value_find_oload_method_list): Use std::vector.
7219         (find_overload_match): Use std::vector.
7220         (find_oload_champ): Use std::vector.
7221         * value.c (value_free): Use operator delete.
7222         (value_of_xmethod): Rename to...
7223         (value_from_xmethod): ... this.  Don't assign
7224         xmethod_worker::value, take rvalue-reference.
7225         (result_type_of_xmethod): Adjust.
7226         (call_xmethod): Adjust.
7227         * value.h: Include extension.h.
7228         (struct xmethod_worker): Don't forward-declare.
7229         (value_of_xmethod): Rename to...
7230         (value_from_xmethod): ... this, take rvalue-reference.
7231         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
7232         (struct python_xmethod_worker): ... this, add constructor and
7233         destructor.
7234         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
7235         (gdbpy_free_xmethod_worker_data): Rename to...
7236         (python_xmethod_worker::~python_xmethod_worker): ... this and
7237         adjust.
7238         (gdbpy_clone_xmethod_worker_data): Rename to...
7239         (python_xmethod_worker::clone): ... this and adjust.
7240         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
7241         temporary vector.
7242         (gdbpy_get_xmethod_arg_types): Rename to...
7243         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
7244         (gdbpy_get_xmethod_result_type): Rename to...
7245         (python_xmethod_worker::do_get_result_type): ... this and
7246         adjust.
7247         (gdbpy_invoke_xmethod): Rename to...
7248         (python_xmethod_worker::invoke): ... this and adjust.
7249         (new_python_xmethod_worker): Rename to...
7250         (python_xmethod_worker::python_xmethod_worker): ... this and
7251         adjust.
7252         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
7253         Remove.
7254         (gdbpy_free_xmethod_worker_data): Remove.
7255         (gdbpy_get_matching_xmethod_workers): Use std::vector.
7256         (gdbpy_get_xmethod_arg_types): Remove.
7257         (gdbpy_get_xmethod_result_type): Remove.
7258         (gdbpy_invoke_xmethod): Remove.
7259         * python/python.c (python_extension_ops): Remove obsolete
7260         callbacks.
7261
7262 2018-01-05  Pedro Alves  <palves@redhat.com>
7263
7264         PR gdb/18653
7265         * common/signals-state-save-restore.c
7266         (save_original_signals_state): New parameter 'quiet'.  Warn if we
7267         find a custom handler preinstalled, instead of internal erroring.
7268         But only warn if !quiet.
7269         * common/signals-state-save-restore.h
7270         (save_original_signals_state): New parameter 'quiet'.
7271         * main.c (captured_main_1): Move save_original_signals_state call
7272         after option handling, and pass QUIET.
7273
7274 2018-01-05  Pedro Alves  <palves@redhat.com>
7275
7276         * spu-tdep.c (spu_catch_start): Pass
7277         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
7278
7279 2018-01-05  Pedro Alves  <palves@redhat.com>
7280
7281         PR gdb/22670
7282         * ada-lang.c (literal_symbol_name_matcher): New function.
7283         (ada_get_symbol_name_matcher): Use it for
7284         symbol_name_match_type::SEARCH_NAME.
7285         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
7286         it down instead of assuming symbol_name_match_type::FULL.
7287         * block.h (block_lookup_symbol): New parameter 'match_type'.
7288         * c-valprint.c (print_unpacked_pointer): Use
7289         lookup_symbol_search_name instead of lookup_symbol.
7290         * compile/compile-object-load.c (get_out_value_type): Pass down
7291         symbol_name_match_type::SEARCH_NAME.
7292         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
7293         symbol_name_match_type::FULL.
7294         * cp-support.c (cp_get_symbol_name_matcher): Handle
7295         symbol_name_match_type::SEARCH_NAME.
7296         * infrun.c (insert_exception_resume_breakpoint): Use
7297         lookup_symbol_search_name.
7298         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
7299         * psymtab.c (maintenance_check_psymtabs): Use
7300         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
7301         * stack.c (print_frame_args): Use lookup_symbol_search_name and
7302         SYMBOL_SEARCH_NAME.
7303         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
7304         if symbol_name_match_type::SEARCH_NAME.
7305         (lookup_symbol_in_language): Pass down
7306         symbol_name_match_type::FULL.
7307         (lookup_symbol_search_name): New.
7308         (lookup_language_this): Pass down
7309         symbol_name_match_type::SEARCH_NAME.
7310         (lookup_symbol_aux, lookup_local_symbol): New parameter
7311         'match_type'.  Pass it down.
7312         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
7313         (lookup_symbol_search_name): New declaration.
7314         (lookup_symbol_in_block): New 'match_type' parameter.
7315
7316 2018-01-05  Pedro Alves  <palves@redhat.com>
7317
7318         PR gdb/22670
7319         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
7320         ada_lookup_symbol.
7321         (ada_lookup_symbol): Reimplement in terms of
7322         ada_lookup_symbol_list, bits factored out from
7323         ada_lookup_encoded_symbol.
7324
7325 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7326
7327         * ada-exp.y (write_object_renaming): When subscripting an array
7328         using a symbol as the index, pass the block in call to
7329         ada_lookup_encoded_symbol when looking that symbol up.
7330
7331 2018-01-05  Jerome Guitton  <guitton@adacore.com>
7332
7333         * ada-lang.c (ada_array_length): Use ada_index_type instead of
7334         TYPE_INDEX_TYPE.
7335
7336 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7337
7338         * ada-lang.c (ada_to_fixed_value_create): Add handling of
7339         the case where VALUE_LVAL (val0) is not lval_memory.
7340
7341 2018-01-05  Xavier Roirand  <roirand@adacore.com>
7342
7343         * ada-valprint.c (print_optional_low_bound): Handle
7344         character-indexed array printing like boolean-indexed array
7345         printing.
7346
7347 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7348
7349         * NEWS: Create a new section for the next release branch.
7350         Rename the section of the current branch, now that it has
7351         been cut.
7352
7353 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7354
7355         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
7356         * version.in: Bump version to 8.1.50.DATE-git.
7357
7358 2018-01-03  Xavier Roirand  <roirand@adacore.com>
7359
7360         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
7361         Add field.
7362         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
7363         Add field.
7364         (default_exception_support_info) <catch_handlers_sym>: Add field.
7365         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
7366         (ada_exception_name_addr_1): Add "catch handlers" handling.
7367         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
7368         Update all callers.
7369         (create_excep_cond_exprs) <ex>: Add parameter.
7370         (re_set_exception): Update create_excep_cond_exprs call.
7371         (print_it_exception, print_one_exception, print_mention_exception)
7372         (print_recreate_exception): Add "catch handler" handling.
7373         (allocate_location_catch_handlers, re_set_catch_handlers)
7374         (check_status_catch_handlers, print_it_catch_handlers)
7375         (print_one_catch_handlers, print_mention_catch_handlers)
7376         (print_recreate_catch_handlers): New function.
7377         (catch_handlers_breakpoint_ops): New variable.
7378         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
7379         Add parameter.  Add "catch handler" handling.
7380         (ada_exception_sym_name, ada_exception_breakpoint_ops):
7381         Add "catch handler" handling.
7382         (ada_exception_catchpoint_cond_string): Add "catch handler"
7383         handling.
7384         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
7385         call.
7386         (catch_ada_handlers_command): New function.
7387         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
7388         operations structure.
7389         (_initialize_ada_language): Add "catch handlers" command entry.
7390         * NEWS: Document "catch handlers" feature.
7391
7392 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7393
7394         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
7395         account when creating the array type of the slice.
7396         (ada_value_slice): Likewise.
7397
7398 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7399
7400         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
7401         New enum value.
7402         (create_array_type_with_stride): Add byte_stride_prop parameter.
7403         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
7404         New parameter.  Update all callers in this file.
7405         (array_type_has_dynamic_stride): New function.
7406         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
7407         of arrays with dynamic byte strides.
7408         * dwarf2read.c (read_array_type): Add support for dynamic
7409         DW_AT_byte_stride attributes.
7410
7411 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7412
7413         * dwarf2read.c (read_unspecified_type): Treat
7414         DW_TAG_enumeration_type DIEs from Ada units as stubs.
7415
7416 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7417
7418         Update copyright year range in all GDB files.
7419
7420 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7421
7422         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
7423         and gdb/testsuite/gdb.base/step-line.c.
7424
7425 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7426
7427         * copyright.py (main): Dump the contents of
7428         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
7429         even if BY_HAND is empty.
7430
7431 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7432
7433         * top.c (print_gdb_version): Update Copyright year in version
7434         message.
7435
7436 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7437
7438         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
7439
7440 For older changes see ChangeLog-2017.
7441 \f
7442 Local Variables:
7443 mode: change-log
7444 left-margin: 8
7445 fill-column: 74
7446 version-control: never
7447 coding: utf-8
7448 End: