Fix test-cp-name-parser build, unused variable
[external/binutils.git] / gdb / ChangeLog
1 2019-03-12  Pedro Alves  <palves@redhat.com>
2
3         * cp-name-parser.y (main): Remove unused 'len' variable.
4
5 2019-03-12  Tom Tromey  <tromey@adacore.com>
6
7         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9
10 2019-03-12  Tom Tromey  <tromey@adacore.com>
11
12         * linux-nat.c (iterate_over_lwps): Update.
13         (stop_callback): Remove parameter.
14         (stop_wait_callback, detach_callback, resume_set_callback)
15         (select_singlestep_lwp_callback, set_ignore_sigint)
16         (status_callback, resumed_callback, resume_clear_callback)
17         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
18         data parameter.
19         (linux_nat_target::detach, linux_nat_target::resume)
20         (linux_stop_and_wait_all_lwps, select_event_lwp)
21         (linux_nat_filter_event, linux_nat_wait_1)
22         (linux_nat_target::kill, linux_nat_target::stop)
23         (linux_nat_target::stop): Update.
24         (linux_nat_resume_callback): Change type.
25         (resume_stopped_resumed_lwps, count_events_callback)
26         (select_event_lwp_callback): Likewise.
27         (linux_stop_lwp, linux_nat_stop_lwp): Update.
28         * arm-linux-nat.c (struct update_registers_data): Remove.
29         (update_registers_callback): Change type.
30         (arm_linux_insert_hw_breakpoint1): Update.
31         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
32         parameter.
33         (x86_linux_dr_set_addr): Update.
34         (x86_linux_dr_set_control): Update.
35         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
36         (iterate_over_lwps): Use gdb::function_view.
37         * nat/aarch64-linux-hw-point.c (struct
38         aarch64_dr_update_callback_param): Remove.
39         (debug_reg_change_callback): Change type.
40         (aarch64_notify_debug_reg_change): Update.
41         * s390-linux-nat.c (s390_refresh_per_info): Update.
42
43 2019-03-11  Tom Tromey  <tromey@adacore.com>
44
45         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
46         redundant assignment to "this_cu".
47
48 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
49
50         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
51
52 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
53
54         * gdbtypes.c (rank_one_type_parm_set): New function extracted
55         from...
56         (rank_one_type): ... this.
57
58 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
59
60         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
61         from...
62         (rank_one_type): ... this.
63
64 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
65
66         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
67         from...
68         (rank_one_type): ... this.
69
70 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
71
72         * gdbtypes.c (rank_one_type_parm_float): New function extracted
73         from...
74         (rank_one_type): ... this.
75
76 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
77
78         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
79         from...
80         (rank_one_type): ... this.
81
82 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
83
84         * gdbtypes.c (rank_one_type_parm_range): New function extracted
85         from...
86         (rank_one_type): ... this.
87
88 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
89
90         * gdbtypes.c (rank_one_type_parm_char): New function extracted
91         from...
92         (rank_one_type): ... this.
93
94 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
95
96         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
97         from...
98         (rank_one_type): ... this.
99
100 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
101
102         * gdbtypes.c (rank_one_type_parm_int): New function extracted
103         from...
104         (rank_one_type): ... this.
105
106 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
107
108         * gdbtypes.c (rank_one_type_parm_func): New function extracted
109         from...
110         (rank_one_type): ... this.
111
112 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
113
114         * gdbtypes.c (rank_one_type_parm_array): New function extracted
115         from...
116         (rank_one_type): ... this.
117
118 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
119
120         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
121         from...
122         (rank_one_type): ... this.
123
124 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
125
126         * inferior.c (initialize_inferiors): Ensure 'help set/show print
127         inferior-events' shows the example events.
128
129 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
130
131         Support styling on native MS-Windows console
132
133         PR/24315
134         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
135         on MS-Windows if $TERM is not defined.
136
137         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
138
139         * posix-hdep.c (gdb_console_fputs):
140         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
141         functions.
142         * ui-file.h (gdb_console_fputs): Add prototype.
143
144         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
145         back to fputs only if the former returns zero.
146
147 2019-03-07  Tom Tromey  <tom@tromey.com>
148
149         * symmisc.c (print_symbol_bcache_statistics): Update.
150         (print_objfile_statistics): Update.
151         * symfile.c (allocate_symtab): Update.
152         * stabsread.c: Don't include bcache.h.
153         * psymtab.h (struct psymbol_bcache): Don't declare.
154         (class psymtab_storage) <psymbol_cache>: Now a bcache.
155         (psymbol_bcache_init, psymbol_bcache_free)
156         (psymbol_bcache_get_bcache): Don't declare.
157         * psymtab.c (struct psymbol_bcache): Remove.
158         (psymtab_storage::psymtab_storage): Update.
159         (psymtab_storage::~psymtab_storage): Update.
160         (psymbol_bcache_init, psymbol_bcache_free)
161         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
162         (add_psymbol_to_bcache): Update.
163         (allocate_psymtab): Update.
164         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
165         macro_cache>: No longer pointers.
166         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
167         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
168         * macrotab.c (macro_bcache): Update.
169         * macroexp.c: Don't include bcache.h.
170         * gdbtypes.c (check_types_worklist): Update.
171         (types_deeply_equal): Remove TRY/CATCH.  Update.
172         * elfread.c (elf_symtab_read): Update.
173         * dwarf2read.c: Don't include bcache.h.
174         * buildsym.c (buildsym_compunit::get_macro_table): Update.
175         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
176         (print_bcache_statistics, bcache_memory_used): Don't declare.
177         (struct bcache): Move from bcache.c.  Add constructor, destructor,
178         methods.  Rename all data members.
179         * bcache.c (struct bcache): Move to bcache.h.
180         (bcache::expand_hash_table): Rename from expand_hash_table.
181         (bcache): Remove.
182         (bcache::insert): Rename from bcache_full.
183         (bcache::compare): Rename from bcache_compare.
184         (bcache_xmalloc): Remove.
185         (bcache::~bcache): Rename from bcache_xfree.
186         (bcache::print_statistics): Rename from print_bcache_statistics.
187         (bcache::memory_used): Rename from bcache_memory_used.
188
189 2019-03-07  Pedro Alves  <palves@redhat.com>
190
191         * infrun.c (normal_stop): Also check for
192         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
193
194 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
195
196         * f-lang.c (value_from_host_double): Moved to...
197         * value.c (value_from_host_double): ...here.
198         * value.h (value_from_host_double): Declare.
199         * guile/scm-math.c (vlscm_convert_typed_number): Use
200         value_from_host_double.
201         (vlscm_convert_number): Likewise.
202         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
203         * python/py-value.c (convert_value_from_python): Likewise.
204
205 2019-03-06  Tom Tromey  <tom@tromey.com>
206
207         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
208
209 2019-03-06  Tom Tromey  <tom@tromey.com>
210
211         * utils.h (free_current_contents): Don't declare.
212         * utils.c (free_current_contents): Remove.
213
214 2019-03-06  Tom Tromey  <tom@tromey.com>
215
216         * top.c (quit_force): Update.
217         * main.c (captured_command_loop): Update.
218         * common/new-op.c (operator new): Update.
219         * common/common-exceptions.c (struct catcher)
220         <save_cleanup_chain>: Remove member.
221         (exceptions_state_mc_init): Update.
222         (exception_try_scope_entry): Return nullptr.
223         (exception_try_scope_exit, exception_rethrow)
224         (throw_exception_sjlj, throw_exception_cxx): Update.
225         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
226         (all_cleanups, do_cleanups, discard_cleanups)
227         (discard_final_cleanups, save_cleanups, save_final_cleanups)
228         (restore_cleanups, restore_final_cleanups): Don't declare.
229         (do_final_cleanups): Remove parameter.
230         * common/cleanups.c (cleanup_chain, make_cleanup)
231         (make_cleanup_dtor, all_cleanups, do_cleanups)
232         (discard_my_cleanups, discard_cleanups)
233         (discard_final_cleanups, save_my_cleanups, save_cleanups)
234         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
235         (null_cleanup): Remove.
236         (do_final_cleanups): Remove parameter.
237
238 2019-03-06  Tom Tromey  <tom@tromey.com>
239
240         * remote.c (remote_target::remote_parse_stop_reply): Use
241         unique_xmalloc_ptr.
242
243 2019-03-06  Tom Tromey  <tom@tromey.com>
244
245         * stabsread.c (struct stabs_field_info): Rename from field_info.
246         <list, fnlist>: Add initializers.
247         <obstack>: New member.
248         (read_member_functions, read_struct_fields, read_baseclasses):
249         Allocate on obstack.  Don't use cleanups.
250         (read_one_struct_field, read_member_functions, read_struct_fields)
251         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
252         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
253         (read_struct_type): Update.
254
255 2019-03-06  Tom Tromey  <tom@tromey.com>
256
257         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
258         * common/filestuff.h (make_cleanup_close): Don't declare.
259         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
260         Remove.
261
262 2019-03-06  Tom Tromey  <tom@tromey.com>
263
264         * solib-aix.c: Use make_scope_exit.
265
266 2019-03-06  Tom Tromey  <tom@tromey.com>
267
268         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
269         Use make_scope_exit.
270
271 2019-03-06  Tom Tromey  <tom@tromey.com>
272
273         * solib-svr4.c (disable_probes_interface): Remove parameter.
274         (svr4_handle_solib_event): Use make_scope_exit.
275
276 2019-03-06  Tom Tromey  <tom@tromey.com>
277
278         * remote.c (struct stop_reply_deleter): Remove.
279         (stop_reply_up): Update.
280         (struct stop_reply): Derive from notif_event.  Don't typedef.
281         <regcache>: Now a std::vector.
282         (stop_reply_xfree): Remove.
283         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
284         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
285         (remote_target::discard_pending_stop_replies): Use delete.
286         (remote_target::remote_parse_stop_reply): Update.
287         (remote_target::process_stop_reply): Update.
288         * remote-notif.h (struct notif_event): Add virtual destructor.
289         Remove "dtr" member.
290         (struct notif_client) <alloc_event>: Return a unique_ptr.
291         (notif_event_xfree): Don't declare.
292         (notif_event_up): New typedef.
293         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
294         (notif_event_xfree, do_notif_event_xfree): Remove.
295         (remote_notif_state_xfree): Update.
296
297 2019-03-06  Tom Tromey  <tom@tromey.com>
298
299         * infrun.c (displaced_step_clear_cleanup): Now a
300         forward_scope_exit type.
301         (displaced_step_prepare_throw): Update.
302         (displaced_step_fixup): Update.
303
304 2019-03-06  Tom Tromey  <tom@tromey.com>
305
306         * inferior.h (class inferior): Update comment.
307         * gdbthread.h (class thread_info): Update comment.
308
309 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
310             Tom Tromey  <tom@tromey.com>
311
312         * stabsread.h (struct stab_section_list): Remove.
313         (coffstab_build_psymtabs): Update.
314         * dbxread.c (symbuf_sections): Now a std::vector.
315         (sect_idx): New global.
316         (fill_symbuf): Update.
317         (coffstab_build_psymtabs): Change type of stabsects parameter.
318         Update.
319         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
320         std::vector.
321         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
322         (coff_locate_sections): Update.
323         (coff_symfile_read): Remove cleanups.  Update.
324         (init_stringtab): Add storage parameter.
325         (free_stringtab, free_stringtab_cleanup): Remove.
326         (init_lineno): Add storage parameter.
327         (free_linetab, free_linetab_cleanup): Remove.
328
329 2019-03-06  Pedro Alves  <palves@redhat.com>
330
331         * linux-fork.c (fork_info::clobber_regs): Delete.
332         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
333         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
334         comment.  Adjust.
335         (scoped_switch_fork_info::scoped_switch_fork_info)
336         (checkpoint_command, linux_fork_context): Adjust
337         fork_save_infrun_state calls.
338
339 2019-03-06  Pedro Alves  <palves@redhat.com>
340
341         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
342         (inf_has_multiple_threads): Return 'bool' and rewrite using
343         inferior_info::threads().
344
345 2019-03-06  Pedro Alves  <palves@redhat.com>
346
347         * linux-fork.c: Include <list>.
348         (fork_list): Now a std::list instance.
349         (fork_info): Add ctor, dtor, and in-class initialize all fields.
350         (forks_exist_p, find_last_fork): Adjust.
351         (new_fork): Delete.
352         (one_fork_p): New.
353         (add_fork): Adjust.
354         (free_fork): Delete, folded into fork_info::~fork_info().
355         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
356         Adjust.
357         (init_fork_list): Delete.
358         (linux_fork_killall, linux_fork_mourn_inferior)
359         (linux_fork_detach, info_checkpoints_command): Adjust.
360         (_initialize_linux_fork): No longer call init_fork_list.
361
362 2019-03-06  Pedro Alves  <palves@redhat.com>
363
364         * linux-fork.c (new_fork): New, split out of ...
365         (add_fork): ... this.  Return void.  Move "first fork" special
366         case from here, to ...
367         (checkpoint_command): ... here.
368         * linux-linux.h (add_fork): Return void.
369
370 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
371
372         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
373
374 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
375             Chris January  <chris.january@arm.com>
376             David Lecomber  <david.lecomber@arm.com>
377
378         * f-exp.y: New token, UNOP_INTRINSIC.
379         (exp): New pattern using UNOP_INTRINSIC token.
380         (f77_keywords): Add 'abs' keyword.
381         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
382         (value_from_host_double): New function.
383         (evaluate_subexp_f): Support UNOP_ABS.
384
385 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
386
387         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
388         types.
389
390 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
391
392         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
393         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
394         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
395
396 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
397
398         * f-exp.y (convert_to_kind_type): Handle more type kinds.
399
400 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
401             Chris January  <chris.january@arm.com>
402
403         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
404         * f-exp.y: Define 'KIND' token.
405         (exp): New pattern for KIND expressions.
406         (ptype): Handle types with a kind extension.
407         (direct_abs_decl): Extend to spot kind extensions.
408         (f77_keywords): Add 'kind' to the list.
409         (push_kind_type): New function.
410         (convert_to_kind_type): New function.
411         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
412         * parse.c (operator_length_standard): Likewise.
413         * parser-defs.h (enum type_pieces): Add tp_kind.
414         * std-operator.def: Add UNOP_KIND.
415
416 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
417
418         * f-exp.y (f_parse): Set yydebug.
419
420 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
421
422         * f-lang.c (evaluate_subexp_f): New function.
423         (exp_descriptor_f): New global.
424         (f_language_defn): Use exp_descriptor_f instead of
425         exp_descriptor_standard.
426
427 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
428
429         * f-exp.y (struct token): Add comments.
430         (dot_ops): Remove uppercase versions and the end marker.
431         (f77_keywords): Likewise.
432         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
433         entries in the dot_ops array are case insensitive, and use
434         strncasecmp to compare strings.  Also some whitespace cleanup in
435         this area.  Similar for the f77_keywords array, except entries in
436         this list might be case sensitive.
437
438 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
439
440         * f-exp.y (struct f77_boolean_val): Add comments.
441         (boolean_values): Remove uppercase versions, and end marker.
442         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
443         and use strncasecmp to achieve case insensitivity.  Additionally,
444         perform whitespace cleanup around this code.
445
446 2019-03-06  Tom Tromey  <tromey@adacore.com>
447
448         * remote-sim.c (gdbsim_target_open): Use result of
449         gdb_argv::release.
450
451 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
452         Dirk Schubert  <dirk.schubert@arm.com>
453         Chris January  <chris.january@arm.com>
454
455         * eval.c (evaluate_subexp_standard): Call Fortran argument
456         wrapping logic.
457         * f-lang.c (struct value): A value which can be passed into a
458         Fortran function call.
459         (fortran_argument_convert): Wrap Fortran arguments in a pointer
460         where appropriate.
461         (struct type): Value ready for a Fortran function call.
462         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
463         is needed.
464         * f-lang.h (fortran_argument_convert): Declaration.
465         (fortran_preserve_arg_pointer): Declaration.
466         * infcall.c (value_arg_coerce): Call Fortran argument logic.
467
468 2019-03-05  Tom Tromey  <tromey@adacore.com>
469
470         * python/py-prettyprint.c (print_string_repr): Remove #if.
471         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
472
473 2019-03-05  Tom Tromey  <tromey@adacore.com>
474
475         * target.c (the_dummy_target): Move later.  Change type to
476         "dummy_target".
477         (initialize_targets): Don't initialize the_dummy_target.
478
479 2019-03-05  Tom Tromey  <tromey@adacore.com>
480
481         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
482         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
483
484 2019-03-05  Tom Tromey  <tromey@adacore.com>
485
486         * windows-nat.c (windows_nat_target::attach)
487         (windows_nat_target::detach): Don't call gdb_flush.
488         * valprint.c (generic_val_print, val_print, val_print_string):
489         Don't call gdb_flush.
490         * utils.c (defaulted_query): Don't call gdb_flush.
491         * typeprint.c (print_type_scalar): Don't call gdb_flush.
492         * target.c (target_announce_detach): Don't call gdb_flush.
493         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
494         * remote.c (extended_remote_target::attach): Don't call
495         gdb_flush.
496         * procfs.c (procfs_target::detach): Don't call gdb_flush.
497         * printcmd.c (do_examine): Don't call gdb_flush.
498         (info_display_command): Don't call gdb_flush.
499         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
500         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
501         * memattr.c (info_mem_command): Don't call gdb_flush.
502         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
503         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
504         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
505         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
506         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
507         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
508         (gnu_nat_target::detach): Don't call gdb_flush.
509         * f-valprint.c (f_val_print): Don't call gdb_flush.
510         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
511         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
512         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
513         gdb_flush.
514         * c-valprint.c (c_val_print): Don't call gdb_flush.
515         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
516
517 2019-03-05  Tom Tromey  <tromey@adacore.com>
518
519         * varobj.c (update_dynamic_varobj_children): Update.
520         (install_default_visualizer): Use reset, not release.
521         * value.c (set_internalvar): Update.
522         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
523         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
524         ATTRIBUTE_UNUSED_RESULT.
525
526 2019-03-05  Tom Tromey  <tromey@adacore.com>
527
528         * remote.c (class scoped_remote_fd) <release>: Add
529         ATTRIBUTE_UNUSED_RESULT.
530
531 2019-03-05  Tom Tromey  <tromey@adacore.com>
532
533         * macroexp.c (struct macro_buffer) <release>: Add
534         ATTRIBUTE_UNUSED_RESULT.
535
536 2019-03-05  Tom Tromey  <tromey@adacore.com>
537
538         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
539         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
540         ATTRIBUTE_UNUSED_RESULT.
541
542 2019-03-05  Tom Tromey  <tromey@adacore.com>
543
544         * common/scoped_fd.h (class scoped_fd) <release>: Add
545         ATTRIBUTE_UNUSED_RESULT.
546
547 2019-03-05  Tom Tromey  <tromey@adacore.com>
548
549         * parser-defs.h (struct parser_state) <release>: Add
550         ATTRIBUTE_UNUSED_RESULT.
551
552 2019-03-05  Tom Tromey  <tromey@adacore.com>
553
554         * utils.h (class gdb_argv) <release>: Add
555         ATTRIBUTE_UNUSED_RESULT.
556         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
557
558 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
559
560         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
561         for-loop range, to avoid compiler warnings.
562
563         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
564         avoid compiler warnings about unused variables.
565
566         * NEWS: Mention end of support for native debugging on MS-Windows
567         before XP.
568
569         PR gdb/24292
570         * common/netstuff.c:
571         * gdbserver/gdbreplay.c
572         * gdbserver/remote-utils.c:
573         * ser-tcp.c:
574         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
575         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
576         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
577         'getaddrinfo' and 'freeaddrinfo' were not available before
578         Windows XP, and mingw.org's MinGW headers by default define
579         _WIN32_WINNT to 0x500.
580
581 2019-03-01  Gary Benson <gbenson@redhat.com>
582
583         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
584
585 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
586             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
587
588         PR gdb/8527
589         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
590         set_sigint_trap, clear_sigint_trap.
591
592 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
593
594         * target.c (target_detach): Clear the regcache and the
595         frame cache.
596
597 2019-02-27  Pedro Alves  <palves@redhat.com>
598
599         * utils.c (set_screen_size): When we cap the height/width sizes,
600         tweak the corresponding command variable to show "unlimited":
601
602 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
603             Pedro Alves  <palves@redhat.com>
604
605         * utils.c (set_screen_size): Reduce "infinite" rows and columns
606         before calling rl_set_screen_size.
607
608 2019-02-27  Tom Tromey  <tromey@adacore.com>
609
610         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
611         define.
612         * python/py-value.c: Remove Python 2.4 workaround.
613         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
614         workaround.
615         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
616         Python 2.4 workaround.
617         * python/python-internal.h: Remove Python 2.4 comment.
618         (Py_ssize_t): Don't define.
619         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
620         (gdb_Py_DECREF): Remove Python 2.4 workaround.
621         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
622         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
623         * python/python.c (do_start_initialization): Remove Python 2.4
624         workaround.
625         * python/py-prettyprint.c (class dummy_python_frame): Remove.
626         (print_children): Remove Python 2.4 workaround.
627         * python/py-inferior.c (buffer_procs): Remove Python 2.4
628         workaround.
629         (CHARBUFFERPROC_NAME): Remove.
630         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
631         Python 2.4 workaround.
632
633 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
634
635         * NEWS: Note minimum Python version.
636
637 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
638
639         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
640         code from these functions.  Remove corresponding ifdefs.  Use
641         Py_buffer_up instead of explicit calls to PyBuffer_Release.
642         Remove gotos and target of gotos.
643         (infpy_search_memory): Likewise.
644
645 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
646
647         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
648         (hppa_gdbarch_init): Don't register deleted functions with
649         gdbarch.
650
651 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
652
653         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
654         (h8300_unwind_sp): Delete.
655         (h8300_dummy_id): Delete.
656         (h8300_gdbarch_init): Don't register deleted functions with
657         gdbarch.
658
659 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
660
661         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
662         (ft32_unwind_pc): Delete.
663         (ft32_unwind_sp): Delete.
664         (ft32_gdbarch_init): Don't register deleted functions with
665         gdbarch.
666
667 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
668
669         * gdb/frv-tdep.c (frv_dummy_id): Delete.
670         (frv_unwind_pc): Delete.
671         (frv_unwind_sp): Delete.
672         (frv_gdbarch_init): Don't register deleted functions with
673         gdbarch.
674
675 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
676
677         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
678         (riscv_unwind_pc): Delete.
679         (riscv_unwind_sp): Delete.
680         (riscv_gdbarch_init): Don't register deleted functions with
681         gdbarch.
682
683 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
684
685         * gdb/csky-tdep.c (csky_dummy_id): Delete.
686         (csky_unwind_pc): Delete.
687         (csky_unwind_sp): Delete.
688         (csky_gdbarch_init): Don't register deleted functions with
689         gdbarch.
690
691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
692
693         * gdb/cris-tdep.c (cris_dummy_id): Delete.
694         (cris_unwind_pc): Delete.
695         (cris_unwind_sp): Delete.
696         (cris_gdbarch_init): Don't register deleted functions with
697         gdbarch.
698
699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
700
701         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
702         (bfin_unwind_pc): Delete.
703         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
704
705 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
706
707         * gdb/arm-tdep.c (arm_dummy_id): Delete.
708         (arm_unwind_pc): Delete.
709         (arm_unwind_sp): Delete.
710         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
711
712 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
713
714         * gdb/arc-tdep.c (arc_dummy_id): Delete.
715         (arc_unwind_pc): Delete.
716         (arc_unwind_sp): Delete.
717         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
718
719 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
720
721         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
722         (alpha_unwind_pc): Delete.
723         (alpha_gdbarch_init): Don't register deleted functions with
724         gdbarch.
725
726 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
727
728         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
729         (aarch64_unwind_pc): Delete.
730         (aarch64_unwind_sp): Delete.
731         (aarch64_gdbarch_init): Don't register deleted functions with
732         gdbarch.
733
734 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
735
736         * gdbtypes.c (type_align): Don't consider static members when
737         computing structure alignment.
738
739 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
740
741         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
742         return 0 for other types.
743         * arch-utils.c (default_type_align): Always return 0.
744         * gdbarch.h: Regenerate.
745         * gdbarch.sh (type_align): Extend comment.
746         * gdbtypes.c (type_align): Add additional comments, always call
747         gdbarch_type_align before applying the default rules.
748         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
749         generic code will then apply a suitable default.
750         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
751         types, return 0 for other types.
752
753 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
754
755         * NEWS: Create a new section for the next release branch.
756         Rename the section of the current branch, now that it has
757         been cut.
758
759 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
760
761         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
762         * version.in: Bump version to 8.3.50.DATE-git.
763
764 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
765
766         * aix-thread.c (ptid_cmp): Remove unused variable.
767         (get_signaled_thread): Likewise.
768         (store_regs_user_thread): Likewise.
769         (store_regs_kernel_thread): Likewise.
770         (fetch_regs_kernel_thread): Remove shadowed variable.
771
772 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
773
774         * features/riscv/32bit-cpu.xml: Add register numbers.
775         * features/riscv/32bit-fpu.c: Regenerate.
776         * features/riscv/32bit-fpu.xml: Add register numbers.
777         * features/riscv/64bit-cpu.xml: Add register numbers.
778         * features/riscv/64bit-fpu.c: Regenerate.
779         * features/riscv/64bit-fpu.xml: Add register numbers.
780
781 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
782
783         * NEWS: Mention two argument form of gdb.Value constructor.
784         * python/py-value.c (convert_buffer_and_type_to_value): New
785         function.
786         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
787         Add support for handling an optional second argument.  Call
788         convert_buffer_and_type_to_value as appropriate.
789         * python/python-internal.h (Py_buffer_deleter): New struct.
790         (Py_buffer_up): New typedef.
791
792 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
793
794         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
795         instead of releasing ownership.
796
797 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
798
799         * dwarf2read.c (open_and_init_dwp_file): Call
800         elf_numsections instead of bfd_count_sections to initialize
801         dwp_file->num_sections.
802
803 2019-02-25  Tom Tromey  <tromey@adacore.com>
804
805         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
806
807 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
808
809         * gcore.in: Add '--readnever' option when invoking GDB.
810
811 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
812
813         * MAINTAINERS: Update my email address.
814
815 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
816
817         * build-id.c (build_id_to_debug_bfd_1): New function.
818         (build_id_to_debug_bfd): Look for separate debug file in
819         sysroot.
820
821 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
822
823         * gdbarch.sh: Update the copyright year range that is placed into
824         generated files.
825
826 2019-02-22  Keith Seitz  <keiths@redhat.com>
827
828         PR symtab/23853
829         * linespec.c (create_sals_line_offset): Search for the default
830         symtab's filename instead of its fullname.
831
832 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
833
834         * NEWS: Update style defaults.
835
836 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
837
838         * main.c (captured_main_1): Disable styling in batch mode.
839
840 2019-02-20  Tom Tromey  <tom@tromey.com>
841
842         * symtab.c (symtab_symbol_info): Fix typos.
843
844 2019-02-20  Tom Tromey  <tromey@adacore.com>
845
846         * findcmd.c (_initialize_mem_search): Use upper case for
847         metasyntactic variables.
848
849 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
850
851         * aarch64-tdep.c (aarch64_add_reggroups): New function.
852         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
853
854 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
855
856         * top.h (source_file_name): Change to std::string.
857         * top.c (source_file_name): Likewise.
858         (command_line_input): Adjust.
859         * cli/cli-script.c (script_from_file): Adjust.
860
861 2019-02-19  Tom Tromey  <tromey@adacore.com>
862
863         * ravenscar-thread.c
864         (ravenscar_thread_target::update_thread_list): Don't call
865         ada_build_task_list.
866         * ada-lang.h (ada_build_task_list): Don't declare.
867         * ada-tasks.c (struct ada_tasks_inferior_data)
868         <task_list_valid_p>: Now bool.
869         (read_known_tasks, ada_task_list_changed)
870         (ada_tasks_invalidate_inferior_data): Update.
871         (read_known_tasks_array): Return bool.
872         (read_known_tasks_list): Likewise.
873         (read_known_tasks): Return void.
874         (ada_build_task_list): Now static.
875
876 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
877
878         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
879         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
880
881 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
882
883         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
884         variant for ada_tasks_pspace_data_handle and
885         ada_tasks_inferior_data_handle.
886         (ada_tasks_pspace_data_cleanup): New function.
887         (ada_tasks_inferior_data_cleanup): New function.
888
889 2019-02-17  Tom Tromey  <tom@tromey.com>
890
891         * macrotab.h (macro_source_fullname): Return a std::string.
892         * macrotab.c (macro_include, check_for_redefinition)
893         (macro_undef, macro_lookup_definition, foreach_macro)
894         (foreach_macro_in_scope): Update.
895         (macro_source_fullname): Return a std::string.
896         * macrocmd.c (show_pp_source_pos): Update.
897
898 2019-02-17  Tom Tromey  <tom@tromey.com>
899
900         * macrocmd.c (show_pp_source_pos): Style the file names.
901
902 2019-02-17  Tom Tromey  <tom@tromey.com>
903
904         PR tui/24197:
905         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
906
907 2019-02-17  Tom Tromey  <tom@tromey.com>
908
909         * ada-lang.c (user_select_syms): Use filtered printing.
910         * utils.c (wrap_style): New global.
911         (desired_style): Remove.
912         (emit_style_escape): Add stream parameter.
913         (set_output_style, reset_terminal_style, prompt_for_continue):
914         Update.
915         (flush_wrap_buffer): Only flush gdb_stdout.
916         (wrap_here): Set wrap_style.
917         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
918         treat escape sequences as a character.  Change when wrap buffer is
919         flushed.
920         (fputs_styled): Do not set the output style when the default is
921         requested.
922         * ui-style.h (struct ui_file_style) <is_default>: New method.
923         * source.c (print_source_lines_base): Emit escape sequences in one
924         piece.
925
926 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
927
928         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
929         integers and enumeration types.
930
931 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
932
933         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
934         instead of lookup_symbol_in_language
935         (do_exact_match): New function.
936         (ada_get_symbol_name_matcher): Return do_exact_match when
937         doing a verbatim match.
938
939 2019-02-15  Tom Tromey  <tromey@adacore.com>
940
941         * ravenscar-thread.c (ravenscar_thread_target::resume)
942         (ravenscar_thread_target::wait): Special case wildcard requests.
943
944 2019-02-15  Tom Tromey  <tromey@adacore.com>
945
946         * ravenscar-thread.c (base_ptid): Remove.
947         (struct ravenscar_thread_target) <close>: New method.
948         <m_base_ptid>: New member.
949         <update_inferior_ptid, active_task, task_is_currently_active,
950         runtime_initialized>: Declare methods.
951         <ravenscar_thread_target>: Add constructor.
952         (ravenscar_thread_target::task_is_currently_active)
953         (ravenscar_thread_target::update_inferior_ptid)
954         (ravenscar_runtime_initialized): Rename.  Now methods.
955         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
956         (ravenscar_thread_target::update_thread_list): Update.
957         (ravenscar_thread_target::active_task): Now method.
958         (ravenscar_thread_target::store_registers)
959         (ravenscar_thread_target::prepare_to_store)
960         (ravenscar_thread_target::prepare_to_store)
961         (ravenscar_thread_target::mourn_inferior): Update.
962         (ravenscar_inferior_created): Use "new" to create target.
963         (ravenscar_thread_target::get_ada_task_ptid): Update.
964         (_initialize_ravenscar): Don't initialize base_ptid.
965         (ravenscar_ops): Remove global.
966
967 2019-02-15  Tom Tromey  <tromey@adacore.com>
968
969         * target.h (push_target): Declare new overload.
970         * target.c (push_target): New overload, taking an rvalue reference.
971         * remote.c (remote_target::open_1): Use push_target overload.
972         * corelow.c (core_target_open): Use push_target overload.
973
974 2019-02-15  Tom Tromey  <tromey@adacore.com>
975
976         * ravenscar-thread.c (is_ravenscar_task)
977         (ravenscar_task_is_currently_active): Return bool.
978         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
979         (_initialize_ravenscar): Remove "(void)".
980         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
981         Return bool.
982
983 2019-02-15  Tom Tromey  <tromey@adacore.com>
984
985         * ravenscar-thread.c (ravenscar_runtime_initializer)
986         (has_ravenscar_runtime, get_running_thread_id)
987         (ravenscar_thread_target::resume): Fix indentation.
988
989 2019-02-15  Tom Tromey  <tromey@adacore.com>
990
991         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
992         from ravenscar_arch_ops.
993         (sparc_ravenscar_ops::fetch_registers)
994         (sparc_ravenscar_ops::store_registers): Now methods.
995         (sparc_ravenscar_prepare_to_store): Remove.
996         (sparc_ravenscar_ops): Redefine.
997         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
998         methods and destructor.  Remove members.
999         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1000         (ravenscar_thread_target::store_registers)
1001         (ravenscar_thread_target::prepare_to_store): Update.
1002         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1003         Remove.
1004         (struct ppc_ravenscar_powerpc_ops): Derive from
1005         ravenscar_arch_ops.
1006         (ppc_ravenscar_powerpc_ops::fetch_registers)
1007         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1008         (ppc_ravenscar_powerpc_ops): Redefine.
1009         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1010         (ppc_ravenscar_e500_ops::fetch_registers)
1011         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1012         (ppc_ravenscar_e500_ops): Redefine.
1013         * aarch64-ravenscar-thread.c
1014         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1015         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1016         (aarch64_ravenscar_fetch_registers)
1017         (aarch64_ravenscar_store_registers): Now methods.
1018         (aarch64_ravenscar_ops): Redefine.
1019
1020 2019-02-15  Tom Tromey  <tromey@adacore.com>
1021
1022         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1023         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1024         (ravenscar_thread_target::stopped_by_watchpoint)
1025         (ravenscar_thread_target::stopped_data_address)
1026         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1027
1028 2019-02-15  Tom Tromey  <tromey@adacore.com>
1029
1030         * ravenscar-thread.c: Fix some typos.
1031
1032 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1033             Tom Tromey  <tromey@adacore.com>
1034
1035         * ada-lang.c (ada_exception_sal): Change addr_string to a
1036         std::string.
1037         (create_ada_exception_catchpoint): Update.
1038
1039 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1040             Tom Tromey  <tromey@adacore.com>
1041
1042         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1043         (bp_location_ops): Remove.
1044         (base_breakpoint_allocate_location): Update.
1045         (free_bp_location): Update.
1046         * ada-lang.c (class ada_catchpoint_location)
1047         <ada_catchpoint_location>: Remove ops parameter.
1048         (ada_catchpoint_location_dtor): Remove.
1049         (ada_catchpoint_location_ops): Remove.
1050         (allocate_location_exception): Update.
1051         * breakpoint.h (struct bp_location_ops): Remove.
1052         (class bp_location) <bp_location>: Remove bp_location_ops
1053         parameter.
1054         <~bp_location>: Add destructor.
1055         <ops>: Remove.
1056
1057 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1058             Pedro Alves  <palves@redhat.com>
1059
1060         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1061         'PATH_MAX'.
1062
1063 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1064             Samuel Thibault  <samuel.thibault@gnu.org>
1065             Thomas Schwinge  <thomas@codesourcery.com>
1066
1067         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1068         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1069
1070 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1071
1072         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1073         (check_empty): Use "const char *".
1074
1075         * gnu-nat.c (gnu_nat_target::detach): Instead of
1076         'detach_inferior (pid)' call
1077         'detach_inferior (find_inferior_pid (pid))'.
1078
1079         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1080         'nat/fork-inferior.o'.
1081         * gnu-nat.c: #include "nat/fork-inferior.h".
1082
1083         * gnu-nat.c (gnu_nat_target::detach): Instead of
1084         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1085         * gnu-nat.h: #include "inf-child.h".
1086         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1087         'i386_gnu_nat_target::fetch_registers'.
1088         (gnu_store_registers): Rename/move to
1089         'i386_gnu_nat_target::store_registers'.
1090
1091         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1092         * gnu-nat.h (mach_thread_info): New function.
1093         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1094
1095         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1096
1097 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1098
1099         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1100
1101 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1102
1103         * windows-nat.c (windows_add_thread): Add new parameter
1104         "main_thread_p" with default value set to false.  Update
1105         function documentation as well as all callers.
1106         (windows_delete_thread): Likewise.
1107         (fake_create_process): Update call to windows_add_thread.
1108         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1109         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1110         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1111         call to windows_delete_thread.
1112
1113 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1114
1115         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1116
1117 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1118
1119         * symfile.c (find_separate_debug_file): Use canonical path of
1120         sysroot with child_path instead of gdb_sysroot if it is valid.
1121
1122 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1123
1124         * symfile.c (find_separate_debug_file): Use child_path to
1125         determine if an object file is under a sysroot.
1126
1127 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1128
1129         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1130         unittests/child-path-selftests.c.
1131         * common/pathstuff.c (child_path): New function.
1132         * common/pathstuff.h (child_path): New prototype.
1133         * unittests/child-path-selftests.c: New file.
1134
1135 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1136
1137         * symfile.c (find_separate_debug_file): Look for separate debug
1138         files in debug directories under the sysroot.
1139
1140 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1141
1142         * symtab.h (struct minimal_symbol data_p): New const method.
1143         (struct minimal_symbol text_p): Likewise.
1144         * symtab.c (output_source_filename): Use file name style
1145         to print file name.
1146         (print_symbol_info): Likewise.
1147         (print_msymbol_info): Use address style to print addresses.
1148         Use function name style to print executable text symbols.
1149         (expand_symtab_containing_pc): Use data_p.
1150         (find_pc_sect_compunit_symtab): Likewise.
1151
1152 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1153
1154         * breakpoint.c (describe_other_breakpoints): Use address style
1155         to print addresses.
1156         (say_where): Likewise.
1157
1158 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1159
1160         * ada-typeprint.c (print_func_type): Print function name
1161         style to print function name.
1162         * c-typeprint.c (c_print_type_1): Likewise.
1163
1164 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1165
1166         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1167         for execve.
1168
1169 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1170
1171         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1172         type_stack.
1173
1174 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1175
1176         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1177         TYPE_CODE_REF types.
1178
1179 2019-02-08  Jim Wilson  <jimw@sifive.com>
1180
1181         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1182         (riscv_linux_fregset): New.
1183         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1184
1185 2019-02-07  Tom Tromey  <tom@tromey.com>
1186
1187         * thread.c (thread_cancel_execution_command): Update.
1188         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1189         methods.
1190         (struct thread_fsm_ops): Remove.
1191         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1192         (thread_fsm_should_stop, thread_fsm_return_value)
1193         (thread_fsm_set_finished, thread_fsm_finished_p)
1194         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1195         Don't declare.
1196         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1197         * infrun.c (clear_proceed_status_thread)
1198         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1199         (print_stop_event): Update.
1200         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1201         Add constructor.
1202         (step_command_fsm_ops): Remove.
1203         (new_step_command_fsm): Remove.
1204         (step_1): Update.
1205         (step_command_fsm::should_stop): Rename from
1206         step_command_fsm_should_stop.
1207         (step_command_fsm::clean_up): Rename from
1208         step_command_fsm_clean_up.
1209         (step_command_fsm::do_async_reply_reason): Rename from
1210         step_command_fsm_async_reply_reason.
1211         (struct until_next_fsm): Inherit from thread_fsm.  Add
1212         constructor.
1213         (until_next_fsm_ops): Remove.
1214         (new_until_next_fsm): Remove.
1215         (until_next_fsm::should_stop): Rename from
1216         until_next_fsm_should_stop.
1217         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1218         (until_next_fsm::do_async_reply_reason): Rename from
1219         until_next_fsm_async_reply_reason.
1220         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1221         constructor.  Change type of breakpoint.
1222         (finish_command_fsm_ops): Remove.
1223         (new_finish_command_fsm): Remove.
1224         (finish_command_fsm::should_stop): Rename from
1225         finish_command_fsm_should_stop.
1226         (finish_command_fsm::clean_up): Rename from
1227         finish_command_fsm_clean_up.
1228         (finish_command_fsm::return_value): Rename from
1229         finish_command_fsm_return_value.
1230         (finish_command_fsm::do_async_reply_reason): Rename from
1231         finish_command_fsm_async_reply_reason.
1232         (finish_command): Update.
1233         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1234         Add constructor.
1235         (call_thread_fsm_ops): Remove.
1236         (call_thread_fsm::call_thread_fsm): Rename from
1237         new_call_thread_fsm.
1238         (call_thread_fsm::should_stop): Rename from
1239         call_thread_fsm_should_stop.
1240         (call_thread_fsm::should_notify_stop): Rename from
1241         call_thread_fsm_should_notify_stop.
1242         (run_inferior_call, call_function_by_hand_dummy): Update.
1243         * cli/cli-interp.c (should_print_stop_to_console): Update.
1244         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1245         Add constructor.  Change type of location_breakpoint,
1246         caller_breakpoint.
1247         (until_break_fsm_ops): Remove.
1248         (new_until_break_fsm): Remove.
1249         (until_break_fsm::should_stop): Rename from
1250         until_break_fsm_should_stop.
1251         (until_break_fsm::clean_up): Rename from
1252         until_break_fsm_clean_up.
1253         (until_break_fsm::do_async_reply_reason): Rename from
1254         until_break_fsm_async_reply_reason.
1255         (until_break_command): Update.
1256         * thread-fsm.c: Remove.
1257         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1258
1259 2019-02-07  Tom Tromey  <tom@tromey.com>
1260
1261         * yy-remap.h: Add include guard.
1262         * xtensa-tdep.h: Add include guard.
1263         * xcoffread.h: Rename include guard.
1264         * varobj-iter.h: Add include guard.
1265         * tui/tui.h: Rename include guard.
1266         * tui/tui-winsource.h: Rename include guard.
1267         * tui/tui-wingeneral.h: Rename include guard.
1268         * tui/tui-windata.h: Rename include guard.
1269         * tui/tui-win.h: Rename include guard.
1270         * tui/tui-stack.h: Rename include guard.
1271         * tui/tui-source.h: Rename include guard.
1272         * tui/tui-regs.h: Rename include guard.
1273         * tui/tui-out.h: Rename include guard.
1274         * tui/tui-layout.h: Rename include guard.
1275         * tui/tui-io.h: Rename include guard.
1276         * tui/tui-hooks.h: Rename include guard.
1277         * tui/tui-file.h: Rename include guard.
1278         * tui/tui-disasm.h: Rename include guard.
1279         * tui/tui-data.h: Rename include guard.
1280         * tui/tui-command.h: Rename include guard.
1281         * tic6x-tdep.h: Add include guard.
1282         * target/waitstatus.h: Rename include guard.
1283         * target/wait.h: Rename include guard.
1284         * target/target.h: Rename include guard.
1285         * target/resume.h: Rename include guard.
1286         * target-float.h: Rename include guard.
1287         * stabsread.h: Add include guard.
1288         * rs6000-tdep.h: Add include guard.
1289         * riscv-fbsd-tdep.h: Add include guard.
1290         * regformats/regdef.h: Rename include guard.
1291         * record.h: Rename include guard.
1292         * python/python.h: Rename include guard.
1293         * python/python-internal.h: Rename include guard.
1294         * python/py-stopevent.h: Rename include guard.
1295         * python/py-ref.h: Rename include guard.
1296         * python/py-record.h: Rename include guard.
1297         * python/py-record-full.h: Rename include guard.
1298         * python/py-record-btrace.h: Rename include guard.
1299         * python/py-instruction.h: Rename include guard.
1300         * python/py-events.h: Rename include guard.
1301         * python/py-event.h: Rename include guard.
1302         * procfs.h: Add include guard.
1303         * proc-utils.h: Add include guard.
1304         * p-lang.h: Add include guard.
1305         * or1k-tdep.h: Rename include guard.
1306         * observable.h: Rename include guard.
1307         * nto-tdep.h: Rename include guard.
1308         * nat/x86-linux.h: Rename include guard.
1309         * nat/x86-linux-dregs.h: Rename include guard.
1310         * nat/x86-gcc-cpuid.h: Add include guard.
1311         * nat/x86-dregs.h: Rename include guard.
1312         * nat/x86-cpuid.h: Rename include guard.
1313         * nat/ppc-linux.h: Rename include guard.
1314         * nat/mips-linux-watch.h: Rename include guard.
1315         * nat/linux-waitpid.h: Rename include guard.
1316         * nat/linux-ptrace.h: Rename include guard.
1317         * nat/linux-procfs.h: Rename include guard.
1318         * nat/linux-osdata.h: Rename include guard.
1319         * nat/linux-nat.h: Rename include guard.
1320         * nat/linux-namespaces.h: Rename include guard.
1321         * nat/linux-btrace.h: Rename include guard.
1322         * nat/glibc_thread_db.h: Rename include guard.
1323         * nat/gdb_thread_db.h: Rename include guard.
1324         * nat/gdb_ptrace.h: Rename include guard.
1325         * nat/fork-inferior.h: Rename include guard.
1326         * nat/amd64-linux-siginfo.h: Rename include guard.
1327         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1328         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1329         * nat/aarch64-linux.h: Rename include guard.
1330         * nat/aarch64-linux-hw-point.h: Rename include guard.
1331         * mn10300-tdep.h: Add include guard.
1332         * mips-linux-tdep.h: Add include guard.
1333         * mi/mi-parse.h: Rename include guard.
1334         * mi/mi-out.h: Rename include guard.
1335         * mi/mi-main.h: Rename include guard.
1336         * mi/mi-interp.h: Rename include guard.
1337         * mi/mi-getopt.h: Rename include guard.
1338         * mi/mi-console.h: Rename include guard.
1339         * mi/mi-common.h: Rename include guard.
1340         * mi/mi-cmds.h: Rename include guard.
1341         * mi/mi-cmd-break.h: Rename include guard.
1342         * m2-lang.h: Add include guard.
1343         * location.h: Rename include guard.
1344         * linux-record.h: Rename include guard.
1345         * linux-nat.h: Add include guard.
1346         * linux-fork.h: Add include guard.
1347         * i386-darwin-tdep.h: Rename include guard.
1348         * hppa-linux-offsets.h: Add include guard.
1349         * guile/guile.h: Rename include guard.
1350         * guile/guile-internal.h: Rename include guard.
1351         * gnu-nat.h: Rename include guard.
1352         * gdb-stabs.h: Rename include guard.
1353         * frv-tdep.h: Add include guard.
1354         * f-lang.h: Add include guard.
1355         * event-loop.h: Add include guard.
1356         * darwin-nat.h: Rename include guard.
1357         * cp-abi.h: Rename include guard.
1358         * config/sparc/nm-sol2.h: Rename include guard.
1359         * config/nm-nto.h: Rename include guard.
1360         * config/nm-linux.h: Add include guard.
1361         * config/i386/nm-i386gnu.h: Rename include guard.
1362         * config/djgpp/nl_types.h: Rename include guard.
1363         * config/djgpp/langinfo.h: Rename include guard.
1364         * compile/gcc-cp-plugin.h: Add include guard.
1365         * compile/gcc-c-plugin.h: Add include guard.
1366         * compile/compile.h: Rename include guard.
1367         * compile/compile-object-run.h: Rename include guard.
1368         * compile/compile-object-load.h: Rename include guard.
1369         * compile/compile-internal.h: Rename include guard.
1370         * compile/compile-cplus.h: Rename include guard.
1371         * compile/compile-c.h: Rename include guard.
1372         * common/xml-utils.h: Rename include guard.
1373         * common/x86-xstate.h: Rename include guard.
1374         * common/version.h: Rename include guard.
1375         * common/vec.h: Rename include guard.
1376         * common/tdesc.h: Rename include guard.
1377         * common/selftest.h: Rename include guard.
1378         * common/scoped_restore.h: Rename include guard.
1379         * common/scoped_mmap.h: Rename include guard.
1380         * common/scoped_fd.h: Rename include guard.
1381         * common/safe-iterator.h: Rename include guard.
1382         * common/run-time-clock.h: Rename include guard.
1383         * common/refcounted-object.h: Rename include guard.
1384         * common/queue.h: Rename include guard.
1385         * common/ptid.h: Rename include guard.
1386         * common/print-utils.h: Rename include guard.
1387         * common/preprocessor.h: Rename include guard.
1388         * common/pathstuff.h: Rename include guard.
1389         * common/observable.h: Rename include guard.
1390         * common/netstuff.h: Rename include guard.
1391         * common/job-control.h: Rename include guard.
1392         * common/host-defs.h: Rename include guard.
1393         * common/gdb_wait.h: Rename include guard.
1394         * common/gdb_vecs.h: Rename include guard.
1395         * common/gdb_unlinker.h: Rename include guard.
1396         * common/gdb_unique_ptr.h: Rename include guard.
1397         * common/gdb_tilde_expand.h: Rename include guard.
1398         * common/gdb_sys_time.h: Rename include guard.
1399         * common/gdb_string_view.h: Rename include guard.
1400         * common/gdb_splay_tree.h: Rename include guard.
1401         * common/gdb_setjmp.h: Rename include guard.
1402         * common/gdb_ref_ptr.h: Rename include guard.
1403         * common/gdb_optional.h: Rename include guard.
1404         * common/gdb_locale.h: Rename include guard.
1405         * common/gdb_assert.h: Rename include guard.
1406         * common/filtered-iterator.h: Rename include guard.
1407         * common/filestuff.h: Rename include guard.
1408         * common/fileio.h: Rename include guard.
1409         * common/environ.h: Rename include guard.
1410         * common/common-utils.h: Rename include guard.
1411         * common/common-types.h: Rename include guard.
1412         * common/common-regcache.h: Rename include guard.
1413         * common/common-inferior.h: Rename include guard.
1414         * common/common-gdbthread.h: Rename include guard.
1415         * common/common-exceptions.h: Rename include guard.
1416         * common/common-defs.h: Rename include guard.
1417         * common/common-debug.h: Rename include guard.
1418         * common/cleanups.h: Rename include guard.
1419         * common/buffer.h: Rename include guard.
1420         * common/btrace-common.h: Rename include guard.
1421         * common/break-common.h: Rename include guard.
1422         * cli/cli-utils.h: Rename include guard.
1423         * cli/cli-style.h: Rename include guard.
1424         * cli/cli-setshow.h: Rename include guard.
1425         * cli/cli-script.h: Rename include guard.
1426         * cli/cli-interp.h: Rename include guard.
1427         * cli/cli-decode.h: Rename include guard.
1428         * cli/cli-cmds.h: Rename include guard.
1429         * charset-list.h: Add include guard.
1430         * buildsym-legacy.h: Rename include guard.
1431         * bfin-tdep.h: Add include guard.
1432         * ax.h: Rename include guard.
1433         * arm-linux-tdep.h: Add include guard.
1434         * arm-fbsd-tdep.h: Add include guard.
1435         * arch/xtensa.h: Rename include guard.
1436         * arch/tic6x.h: Add include guard.
1437         * arch/i386.h: Add include guard.
1438         * arch/arm.h: Rename include guard.
1439         * arch/arm-linux.h: Rename include guard.
1440         * arch/arm-get-next-pcs.h: Rename include guard.
1441         * arch/amd64.h: Add include guard.
1442         * arch/aarch64-insn.h: Rename include guard.
1443         * arch-utils.h: Rename include guard.
1444         * annotate.h: Add include guard.
1445         * amd64-darwin-tdep.h: Rename include guard.
1446         * aarch64-linux-tdep.h: Add include guard.
1447         * aarch64-fbsd-tdep.h: Add include guard.
1448         * aarch32-linux-nat.h: Add include guard.
1449
1450 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1451
1452         * macrotab.c (macro_define_internal): New function that
1453         factorizes macro_define_object_internal and macro_define_function
1454         code.
1455         (macro_define_object_internal): Use macro_define_internal.
1456         (macro_define_function): Likewise.
1457
1458 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1459
1460         * macrocmd.c (extract_identifier): Return
1461         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1462         callers.
1463
1464 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1465
1466         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1467
1468 2019-02-05  Tom Tromey  <tom@tromey.com>
1469
1470         * target.c (target_stack::unpush): Move assertion earlier.
1471
1472 2019-01-30  Tom Tromey  <tom@tromey.com>
1473
1474         PR python/23615:
1475         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1476         (gdbpy_parse_and_eval): Likewise.
1477         * python/python-internal.h (gdbpy_allow_threads): New class.
1478
1479 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1480
1481         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1482         (aarch64_fbsd_fpregmap): Move earlier.
1483         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1484         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1485         instead of individual calls to trad_frame_set_reg_addr.
1486         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1487         earlier.
1488         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1489         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1490         instead of individual calls to trad_frame_set_reg_addr.
1491
1492 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1493
1494         * CONTRIBUTE: Replace contribution list with wiki link.
1495
1496 2019-01-25  Tom Tromey  <tom@tromey.com>
1497
1498         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1499
1500 2019-01-25  Tom Tromey  <tom@tromey.com>
1501
1502         * xtensa-linux-nat.c: Fix common/ includes.
1503         * xml-support.h: Fix common/ includes.
1504         * xml-support.c: Fix common/ includes.
1505         * x86-linux-nat.c: Fix common/ includes.
1506         * windows-nat.c: Fix common/ includes.
1507         * varobj.h: Fix common/ includes.
1508         * varobj.c: Fix common/ includes.
1509         * value.c: Fix common/ includes.
1510         * valops.c: Fix common/ includes.
1511         * utils.c: Fix common/ includes.
1512         * unittests/xml-utils-selftests.c: Fix common/ includes.
1513         * unittests/utils-selftests.c: Fix common/ includes.
1514         * unittests/unpack-selftests.c: Fix common/ includes.
1515         * unittests/tracepoint-selftests.c: Fix common/ includes.
1516         * unittests/style-selftests.c: Fix common/ includes.
1517         * unittests/string_view-selftests.c: Fix common/ includes.
1518         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1519         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1520         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1521         * unittests/rsp-low-selftests.c: Fix common/ includes.
1522         * unittests/parse-connection-spec-selftests.c: Fix common/
1523         includes.
1524         * unittests/optional-selftests.c: Fix common/ includes.
1525         * unittests/offset-type-selftests.c: Fix common/ includes.
1526         * unittests/observable-selftests.c: Fix common/ includes.
1527         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1528         * unittests/memrange-selftests.c: Fix common/ includes.
1529         * unittests/memory-map-selftests.c: Fix common/ includes.
1530         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1531         * unittests/function-view-selftests.c: Fix common/ includes.
1532         * unittests/environ-selftests.c: Fix common/ includes.
1533         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1534         * unittests/common-utils-selftests.c: Fix common/ includes.
1535         * unittests/cli-utils-selftests.c: Fix common/ includes.
1536         * unittests/array-view-selftests.c: Fix common/ includes.
1537         * ui-file.c: Fix common/ includes.
1538         * tui/tui-io.c: Fix common/ includes.
1539         * tracepoint.h: Fix common/ includes.
1540         * tracepoint.c: Fix common/ includes.
1541         * tracefile-tfile.c: Fix common/ includes.
1542         * top.h: Fix common/ includes.
1543         * top.c: Fix common/ includes.
1544         * thread.c: Fix common/ includes.
1545         * target/waitstatus.h: Fix common/ includes.
1546         * target/waitstatus.c: Fix common/ includes.
1547         * target.h: Fix common/ includes.
1548         * target.c: Fix common/ includes.
1549         * target-memory.c: Fix common/ includes.
1550         * target-descriptions.c: Fix common/ includes.
1551         * symtab.h: Fix common/ includes.
1552         * symfile.c: Fix common/ includes.
1553         * stap-probe.c: Fix common/ includes.
1554         * spu-linux-nat.c: Fix common/ includes.
1555         * sparc-nat.c: Fix common/ includes.
1556         * source.c: Fix common/ includes.
1557         * solib.c: Fix common/ includes.
1558         * solib-target.c: Fix common/ includes.
1559         * ser-unix.c: Fix common/ includes.
1560         * ser-tcp.c: Fix common/ includes.
1561         * ser-pipe.c: Fix common/ includes.
1562         * ser-base.c: Fix common/ includes.
1563         * selftest-arch.c: Fix common/ includes.
1564         * s12z-tdep.c: Fix common/ includes.
1565         * rust-exp.y: Fix common/ includes.
1566         * rs6000-aix-tdep.c: Fix common/ includes.
1567         * riscv-tdep.c: Fix common/ includes.
1568         * remote.c: Fix common/ includes.
1569         * remote-notif.h: Fix common/ includes.
1570         * remote-fileio.h: Fix common/ includes.
1571         * remote-fileio.c: Fix common/ includes.
1572         * regcache.h: Fix common/ includes.
1573         * regcache.c: Fix common/ includes.
1574         * record-btrace.c: Fix common/ includes.
1575         * python/python.c: Fix common/ includes.
1576         * python/py-type.c: Fix common/ includes.
1577         * python/py-inferior.c: Fix common/ includes.
1578         * progspace.h: Fix common/ includes.
1579         * producer.c: Fix common/ includes.
1580         * procfs.c: Fix common/ includes.
1581         * proc-api.c: Fix common/ includes.
1582         * printcmd.c: Fix common/ includes.
1583         * ppc-linux-nat.c: Fix common/ includes.
1584         * parser-defs.h: Fix common/ includes.
1585         * osdata.c: Fix common/ includes.
1586         * obsd-nat.c: Fix common/ includes.
1587         * nat/x86-linux.c: Fix common/ includes.
1588         * nat/x86-linux-dregs.c: Fix common/ includes.
1589         * nat/x86-dregs.h: Fix common/ includes.
1590         * nat/x86-dregs.c: Fix common/ includes.
1591         * nat/ppc-linux.c: Fix common/ includes.
1592         * nat/mips-linux-watch.h: Fix common/ includes.
1593         * nat/mips-linux-watch.c: Fix common/ includes.
1594         * nat/linux-waitpid.c: Fix common/ includes.
1595         * nat/linux-ptrace.h: Fix common/ includes.
1596         * nat/linux-ptrace.c: Fix common/ includes.
1597         * nat/linux-procfs.c: Fix common/ includes.
1598         * nat/linux-personality.c: Fix common/ includes.
1599         * nat/linux-osdata.c: Fix common/ includes.
1600         * nat/linux-namespaces.c: Fix common/ includes.
1601         * nat/linux-btrace.h: Fix common/ includes.
1602         * nat/linux-btrace.c: Fix common/ includes.
1603         * nat/fork-inferior.c: Fix common/ includes.
1604         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1605         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1606         * nat/aarch64-linux.c: Fix common/ includes.
1607         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1608         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1609         * namespace.h: Fix common/ includes.
1610         * mips-linux-tdep.c: Fix common/ includes.
1611         * minsyms.c: Fix common/ includes.
1612         * mi/mi-parse.h: Fix common/ includes.
1613         * mi/mi-main.c: Fix common/ includes.
1614         * mi/mi-cmd-env.c: Fix common/ includes.
1615         * memrange.h: Fix common/ includes.
1616         * memattr.c: Fix common/ includes.
1617         * maint.h: Fix common/ includes.
1618         * maint.c: Fix common/ includes.
1619         * main.c: Fix common/ includes.
1620         * machoread.c: Fix common/ includes.
1621         * location.c: Fix common/ includes.
1622         * linux-thread-db.c: Fix common/ includes.
1623         * linux-nat.c: Fix common/ includes.
1624         * linux-fork.c: Fix common/ includes.
1625         * inline-frame.c: Fix common/ includes.
1626         * infrun.c: Fix common/ includes.
1627         * inflow.c: Fix common/ includes.
1628         * inferior.h: Fix common/ includes.
1629         * inferior.c: Fix common/ includes.
1630         * infcmd.c: Fix common/ includes.
1631         * inf-ptrace.c: Fix common/ includes.
1632         * inf-child.c: Fix common/ includes.
1633         * ia64-linux-nat.c: Fix common/ includes.
1634         * i387-tdep.c: Fix common/ includes.
1635         * i386-tdep.c: Fix common/ includes.
1636         * i386-linux-tdep.c: Fix common/ includes.
1637         * i386-linux-nat.c: Fix common/ includes.
1638         * i386-go32-tdep.c: Fix common/ includes.
1639         * i386-fbsd-tdep.c: Fix common/ includes.
1640         * i386-fbsd-nat.c: Fix common/ includes.
1641         * guile/scm-type.c: Fix common/ includes.
1642         * guile/guile.c: Fix common/ includes.
1643         * go32-nat.c: Fix common/ includes.
1644         * gnu-nat.c: Fix common/ includes.
1645         * gdbthread.h: Fix common/ includes.
1646         * gdbarch-selftests.c: Fix common/ includes.
1647         * gdb_usleep.c: Fix common/ includes.
1648         * gdb_select.h: Fix common/ includes.
1649         * gdb_bfd.c: Fix common/ includes.
1650         * gcore.c: Fix common/ includes.
1651         * fork-child.c: Fix common/ includes.
1652         * findvar.c: Fix common/ includes.
1653         * fbsd-nat.c: Fix common/ includes.
1654         * event-top.c: Fix common/ includes.
1655         * event-loop.c: Fix common/ includes.
1656         * dwarf2read.c: Fix common/ includes.
1657         * dwarf2loc.c: Fix common/ includes.
1658         * dwarf2-frame.c: Fix common/ includes.
1659         * dwarf-index-cache.c: Fix common/ includes.
1660         * dtrace-probe.c: Fix common/ includes.
1661         * disasm-selftests.c: Fix common/ includes.
1662         * defs.h: Fix common/ includes.
1663         * csky-tdep.c: Fix common/ includes.
1664         * cp-valprint.c: Fix common/ includes.
1665         * cp-support.h: Fix common/ includes.
1666         * cp-support.c: Fix common/ includes.
1667         * corelow.c: Fix common/ includes.
1668         * completer.h: Fix common/ includes.
1669         * completer.c: Fix common/ includes.
1670         * compile/compile.c: Fix common/ includes.
1671         * compile/compile-loc2c.c: Fix common/ includes.
1672         * compile/compile-cplus-types.c: Fix common/ includes.
1673         * compile/compile-cplus-symbols.c: Fix common/ includes.
1674         * command.h: Fix common/ includes.
1675         * cli/cli-dump.c: Fix common/ includes.
1676         * cli/cli-cmds.c: Fix common/ includes.
1677         * charset.c: Fix common/ includes.
1678         * build-id.c: Fix common/ includes.
1679         * btrace.h: Fix common/ includes.
1680         * btrace.c: Fix common/ includes.
1681         * breakpoint.h: Fix common/ includes.
1682         * breakpoint.c: Fix common/ includes.
1683         * ax.h: 
1684         (enum agent_op): Fix common/ includes.
1685         * ax-general.c (struct aop_map): Fix common/ includes.
1686         * ax-gdb.c: Fix common/ includes.
1687         * auxv.c: Fix common/ includes.
1688         * auto-load.c: Fix common/ includes.
1689         * arm-tdep.c: Fix common/ includes.
1690         * arch/riscv.c: Fix common/ includes.
1691         * arch/ppc-linux-common.c: Fix common/ includes.
1692         * arch/i386.c: Fix common/ includes.
1693         * arch/arm.c: Fix common/ includes.
1694         * arch/arm-linux.c: Fix common/ includes.
1695         * arch/arm-get-next-pcs.c: Fix common/ includes.
1696         * arch/amd64.c: Fix common/ includes.
1697         * arch/aarch64.c: Fix common/ includes.
1698         * arch/aarch64-insn.c: Fix common/ includes.
1699         * arch-utils.c: Fix common/ includes.
1700         * amd64-windows-tdep.c: Fix common/ includes.
1701         * amd64-tdep.c: Fix common/ includes.
1702         * amd64-sol2-tdep.c: Fix common/ includes.
1703         * amd64-obsd-tdep.c: Fix common/ includes.
1704         * amd64-nbsd-tdep.c: Fix common/ includes.
1705         * amd64-linux-tdep.c: Fix common/ includes.
1706         * amd64-linux-nat.c: Fix common/ includes.
1707         * amd64-fbsd-tdep.c: Fix common/ includes.
1708         * amd64-fbsd-nat.c: Fix common/ includes.
1709         * amd64-dicos-tdep.c: Fix common/ includes.
1710         * amd64-darwin-tdep.c: Fix common/ includes.
1711         * agent.c: Fix common/ includes.
1712         * ada-lang.h: Fix common/ includes.
1713         * ada-lang.c: Fix common/ includes.
1714         * aarch64-tdep.c: Fix common/ includes.
1715
1716 2019-01-25  Tom Tromey  <tom@tromey.com>
1717
1718         * common/create-version.sh: Use common/version.h.
1719
1720 2019-01-24  Pedro Alves  <palves@redhat.com>
1721
1722         * infrun.c (signal_stop, signal_print, signal_program)
1723         (signal_catch, signal_pass): Now arrays instead of pointers.
1724         (update_signals_program_target, do_target_resume)
1725         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1726         * linux-nat.c (linux_nat_target::pass_signals)
1727         (linux_nat_target::create_inferior, linux_nat_target::attach):
1728         Adjust.
1729         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1730         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1731         * procfs.c (procfs_target::pass_signals): Adjust.
1732         * record-full.c (record_full_target::resume): Adjust.
1733         * remote.c (remote_target::pass_signals)
1734         (remote_target::program_signals): Adjust.
1735         * target-debug.h (target_debug_print_signals): Now takes a
1736         gdb::array_view as parameter.  Adjust.
1737         * target.h (target_ops) <pass_signals, program_signals>: Replace
1738         pointer and length parameters with gdb::array_view.
1739         (target_pass_signals, target_program_signals): Likewise.
1740         * target-delegates.c: Regenerate.
1741
1742 2019-01-24  Pedro Alves  <palves@redhat.com>
1743
1744         * common/forward-scope-exit.h
1745         (forward_scope_exit::forward_scope_exit): Pass arguments to
1746         m_bind_function directly, instead of creating a std::bind and
1747         copying that.
1748
1749 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1750
1751         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1752         for static members.
1753         (pass_in_v_vfp_candidate): Likewise.
1754
1755 2019-01-23  Tom Tromey  <tom@tromey.com>
1756             Pedro Alves  <palves@redhat.com>
1757
1758         * regcache.c (class regcache_invalidator): Remove.
1759         (regcache::raw_write): Use make_scope_exit.
1760
1761 2019-01-23  Tom Tromey  <tom@tromey.com>
1762
1763         * ui-out.h (class ui_out_emit_type): Update comment.
1764
1765 2019-01-23  Tom Tromey  <tom@tromey.com>
1766
1767         * infrun.c (fetch_inferior_event): Update comment.
1768
1769 2019-01-23  Tom Tromey  <tom@tromey.com>
1770             Pedro Alves  <palves@redhat.com>
1771
1772         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1773         parameter.
1774         (fetch_inferior_event): Use SCOPE_EXIT.
1775
1776
1777 2019-01-23  Tom Tromey  <tom@tromey.com>
1778             Pedro Alves  <palves@redhat.com>
1779
1780         * infrun.c (disable_thread_events): Delete.
1781         (stop_all_threads): Use SCOPE_EXIT.
1782
1783 2019-01-23  Tom Tromey  <tom@tromey.com>
1784             Pedro Alves  <palves@redhat.com>
1785
1786         * symfile.c: Include forward-scope-exit.h.
1787         (clear_symtab_users_cleanup): Replace forward declaration with
1788         a FORWARD_SCOPE_EXIT.
1789         (syms_from_objfile_1): Use the forward_scope_exit and
1790         gdb::optional instead of cleanup_function.
1791         (reread_symbols): Use the forward_scope_exit instead of
1792         cleanup_function.
1793         (clear_symtab_users_cleanup): Remove function.
1794
1795 2019-01-23  Tom Tromey  <tom@tromey.com>
1796             Pedro Alves  <palves@redhat.com>
1797
1798         * linux-nat.c: Include scope-exit.h.
1799         (cleanup_target_stop): Remove.
1800         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1801         SCOPE_EXIT.
1802
1803 2019-01-23  Tom Tromey  <tom@tromey.com>
1804             Pedro Alves  <palves@redhat.com>
1805
1806         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1807         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1808
1809 2019-01-23  Tom Tromey  <tom@tromey.com>
1810             Andrew Burgess  <andrew.burgess@embecosm.com>
1811             Pedro Alves  <palves@redhat.com>
1812
1813         * infrun.c (fetch_inferior_event): Use scope_exit.
1814         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1815         * top.c (execute_command): Use scope_exit.
1816         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1817         * utils.c (do_bpstat_clear_actions_cleanup)
1818         (make_bpstat_clear_actions_cleanup): Remove.
1819
1820 2019-01-23  Tom Tromey  <tom@tromey.com>
1821             Pedro Alves  <palves@redhat.com>
1822
1823         * infrun.c: Include "common/scope-exit.h"
1824         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1825         (wait_for_inferior): Use SCOPE_EXIT.
1826         (fetch_inferior_event): Use scope_exit.
1827
1828 2019-01-23  Tom Tromey  <tom@tromey.com>
1829             Pedro Alves  <palves@redhat.com>
1830
1831         * breakpoint.c (create_breakpoint): Remove cleanup.
1832
1833 2019-01-23  Tom Tromey  <tom@tromey.com>
1834             Andrew Burgess  <andrew.burgess@embecosm.com>
1835             Pedro Alves  <palves@redhat.com>
1836
1837 2019-01-23  Pedro Alves  <palves@redhat.com>
1838
1839         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1840
1841 2019-01-23  Pedro Alves  <palves@redhat.com>
1842             Andrew Burgess  <andrew.burgess@embecosm.com>
1843
1844         * gdbthread.h: Include "common/forward-scope-exit.h".
1845         (scoped_finish_thread_state): Redefine custom class in terms of
1846         forward_scope_exit.
1847
1848 2019-01-23  Pedro Alves  <palves@redhat.com>
1849             Andrew Burgess  <andrew.burgess@embecosm.com>
1850
1851         * common/forward-scope-exit.h: New file.
1852
1853 2019-01-23  Pedro Alves  <palves@redhat.com>
1854             Andrew Burgess  <andrew.burgess@embecosm.com>
1855             Tom Tromey  <tom@tromey.com>
1856
1857         * common/scope-exit.h: New file.
1858
1859 2019-01-23  Pedro Alves  <palves@redhat.com>
1860
1861         * common/preprocessor.h (ESC): Rename to ...
1862         (ESC_PARENS): ... this.
1863         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1864         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1865
1866 2019-01-23  Tom Tromey  <tom@tromey.com>
1867
1868         * language.h (class scoped_switch_to_sym_language_if_auto):
1869         Initialize m_lang in both cases.
1870
1871 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1872
1873         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1874         with XCNEW.
1875
1876 2019-01-22  Tom Tromey  <tom@tromey.com>
1877
1878         * corelow.c: Do not include sys/file.h.
1879
1880 2019-01-22  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-wingeneral.h: Include gdb_curses.h.
1883
1884 2019-01-22  Tom Tromey  <tom@tromey.com>
1885
1886         * source-cache.h (class source_cache) <get_source_lines,
1887         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1888
1889 2019-01-22  Tom Tromey  <tom@tromey.com>
1890
1891         * remote-fileio.h (struct remote_target): Declare.
1892
1893 2019-01-22  Tom Tromey  <tom@tromey.com>
1894
1895         * python/py-arch.c: Do not include py-ref.h.
1896         * python/py-bpevent.c: Do not include py-ref.h.
1897         * python/py-cmd.c: Do not include py-ref.h.
1898         * python/py-continueevent.c: Do not include py-ref.h.
1899         * python/py-event.h: Do not include py-ref.h.
1900         * python/py-evtregistry.c: Do not include py-ref.h.
1901         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1902         * python/py-frame.c: Do not include py-ref.h.
1903         * python/py-framefilter.c: Do not include py-ref.h.
1904         * python/py-function.c: Do not include py-ref.h.
1905         * python/py-infevents.c: Do not include py-ref.h.
1906         * python/py-linetable.c: Do not include py-ref.h.
1907         * python/py-objfile.c: Do not include py-ref.h.
1908         * python/py-param.c: Do not include py-ref.h.
1909         * python/py-prettyprint.c: Do not include py-ref.h.
1910         * python/py-progspace.c: Do not include py-ref.h.
1911         * python/py-symbol.c: Do not include py-ref.h.
1912         * python/py-symtab.c: Do not include py-ref.h.
1913         * python/py-type.c: Do not include py-ref.h.
1914         * python/py-unwind.c: Do not include py-ref.h.
1915         * python/py-utils.c: Do not include py-ref.h.
1916         * python/py-value.c: Do not include py-ref.h.
1917         * python/py-varobj.c: Do not include py-ref.h.
1918         * python/py-xmethods.c: Do not include py-ref.h.
1919         * python/python.c: Do not include py-ref.h.
1920         * varobj.c: Do not include py-ref.h.
1921
1922 2019-01-22  Tom Tromey  <tom@tromey.com>
1923
1924         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1925         keyword for bcache.
1926
1927 2019-01-22  Tom Tromey  <tom@tromey.com>
1928
1929         * compile/compile-cplus-types.c: Remove a comment by #include.
1930
1931 2019-01-22  Tom Tromey  <tom@tromey.com>
1932
1933         * compile/gcc-c-plugin.h: Include compile-internal.h.
1934
1935 2019-01-22  Tom Tromey  <tom@tromey.com>
1936
1937         * stabsread.c (EXTERN): Do not define.
1938         (symnum, next_symbol_text_func, processing_gcc_compilation)
1939         (within_function, global_sym_chain, global_stabs)
1940         (previous_stab_code, this_object_header_files)
1941         (n_this_object_header_files)
1942         (n_allocated_this_object_header_files): Define.
1943         * stabsread.h (EXTERN): Never define.  Use "extern".
1944
1945 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1946
1947         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1948         history_value.
1949
1950 2019-01-21  Tom Tromey  <tom@tromey.com>
1951
1952         * ui-out.c: Fix includes.
1953         * tui/tui-source.c: Fix includes.
1954         * target.c: Fix includes.
1955         * remote.c: Fix includes.
1956         * regcache.c: Fix includes.
1957         * python/py-block.c: Fix includes.
1958         * printcmd.c: Fix includes.
1959         * or1k-tdep.c: Fix includes.
1960         * mi/mi-main.c: Fix includes.
1961         * m32r-tdep.c: Fix includes.
1962         * csky-tdep.c: Fix includes.
1963         * compile/compile-cplus-types.c: Fix includes.
1964         * cli/cli-interp.c: Fix includes.
1965
1966 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1967
1968         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1969         for padding.
1970
1971 2019-01-16  Tom Tromey  <tom@tromey.com>
1972
1973         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1974         earlier.
1975         (struct objfile) <msymbols_range>: Move from top level.
1976         <msymbols>: New method.
1977         (class objfile_msymbols): Remove.
1978         * symtab.c (default_collect_symbol_completion_matches_break_on):
1979         Update.
1980         * symmisc.c (dump_msymbols): Update.
1981         * stabsread.c (scan_file_globals): Update.
1982         * objc-lang.c (info_selectors_command, info_classes_command)
1983         (find_methods): Update.
1984         * minsyms.c (find_solib_trampoline_target): Update.
1985         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1986         * coffread.c (coff_symfile_read): Update.
1987         * ada-lang.c (ada_lookup_simple_minsym)
1988         (ada_collect_symbol_completion_matches): Update.
1989
1990 2019-01-16  Tom Tromey  <tom@tromey.com>
1991
1992         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1993         type.  Remove no-argument constructor.
1994         <iterator::operator++>: Simplify.
1995         <begin>: Update.
1996         <end>: Use minimal_symbol_count.
1997
1998 2019-01-16  Tom Tromey  <tom@tromey.com>
1999
2000         * objfiles.h (struct objfile) <psymtabs>: New method.
2001         (class objfile_psymtabs): Remove.
2002         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2003         typedef.
2004         <range>: New method.
2005         (require_partial_symbols): Change return type.
2006         * psymtab.c (require_partial_symbols)
2007         (psym_expand_symtabs_matching): Update.
2008         * mdebugread.c (parse_partial_symbols): Update.
2009         * dbxread.c (dbx_end_psymtab): Update.
2010
2011 2019-01-15  Tom Tromey  <tom@tromey.com>
2012
2013         * symtab.c (lookup_objfile_from_block)
2014         (lookup_symbol_in_objfile_symtabs)
2015         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2016         (find_line_symtab, info_sources_command)
2017         (default_collect_symbol_completion_matches_break_on)
2018         (make_source_files_completion_list): Update.
2019         * symmisc.c (print_objfile_statistics, dump_objfile)
2020         (maintenance_print_symbols, maintenance_info_symtabs)
2021         (maintenance_check_symtabs, maintenance_info_line_tables):
2022         Update.
2023         * source.c (select_source_symtab)
2024         (forget_cached_source_info_for_objfile): Update.
2025         * objfiles.h (class objfile_compunits): Remove.
2026         (struct objfile) <compunits_range>: New typedef.
2027         (compunits): New method.
2028         * objfiles.c (objfile_relocate1): Update.
2029         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2030         * maint.c (count_symtabs_and_blocks): Update.
2031         * linespec.c (iterate_over_all_matching_symtabs): Update.
2032         * cp-support.c (add_symbol_overload_list_qualified): Update.
2033         * coffread.c (coff_symtab_read): Update.
2034         * ada-lang.c (add_nonlocal_symbols)
2035         (ada_collect_symbol_completion_matches)
2036         (ada_add_global_exceptions): Update.
2037
2038 2019-01-15  Tom Tromey  <tom@tromey.com>
2039
2040         * progspace.h (program_space) <objfiles_safe_range>: New
2041         typedef.
2042         <objfiles_safe>: New method.
2043         * objfiles.h (class all_objfiles_safe): Remove.
2044         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2045         * jit.c (jit_inferior_exit_hook): Update.
2046
2047 2019-01-17  Tom Tromey  <tom@tromey.com>
2048
2049         * progspace.h (program_space) <objfiles_range>: New typedef.
2050         <objfiles>: New method.
2051         <objfiles_head>: Rename from objfiles.
2052         (object_files): Update.
2053         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2054         * guile/scm-pretty-print.c
2055         (ppscm_find_pretty_printer_from_objfiles): Update.
2056         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2057         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2058         Update.
2059         * python/py-progspace.c (pspy_get_objfiles): Update.
2060         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2061         Update.
2062         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2063         (objfpy_lookup_objfile_by_build_id): Update.
2064         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2065         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2066         Update.
2067         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2068         (expand_symtab_containing_pc, lookup_objfile_from_block)
2069         (lookup_static_symbol, basic_lookup_transparent_type)
2070         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2071         (find_line_symtab, info_sources_command)
2072         (default_collect_symbol_completion_matches_break_on)
2073         (make_source_files_completion_list, find_main_name): Update.
2074         * symmisc.c (print_symbol_bcache_statistics)
2075         (print_objfile_statistics, maintenance_print_symbols)
2076         (maintenance_print_msymbols, maintenance_print_objfiles)
2077         (maintenance_info_symtabs, maintenance_check_symtabs)
2078         (maintenance_expand_symtabs, maintenance_info_line_tables):
2079         Update.
2080         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2081         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2082         (map_overlay_command, unmap_overlay_command)
2083         (simple_overlay_update, expand_symtabs_matching)
2084         (map_symbol_filenames): Update.
2085         * symfile-debug.c (set_debug_symfile): Update.
2086         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2087         Update.
2088         * source.c (select_source_symtab, forget_cached_source_info):
2089         Update.
2090         * solib.c (solib_read_symbols): Update.
2091         * solib-spu.c (append_ocl_sos): Update.
2092         * psymtab.c (maintenance_print_psymbols)
2093         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2094         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2095         * printcmd.c (info_symbol_command): Update.
2096         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2097         Update.
2098         * objfiles.h (class all_objfiles): Remove.
2099         * objfiles.c (have_partial_symbols, have_full_symbols)
2100         (have_minimal_symbols, qsort_cmp, update_section_map)
2101         (shared_objfile_contains_address_p)
2102         (default_iterate_over_objfiles_in_search_order): Update.
2103         * objc-lang.c (info_selectors_command, info_classes_command)
2104         (find_methods): Update.
2105         * minsyms.c (find_solib_trampoline_target): Update.
2106         * maint.c (maintenance_info_sections)
2107         (maintenance_translate_address, count_symtabs_and_blocks):
2108         Update.
2109         * main.c (captured_main_1): Update.
2110         * linux-thread-db.c (try_thread_db_load_from_pdir)
2111         (has_libpthread): Update.
2112         * linespec.c (iterate_over_all_matching_symtabs)
2113         (search_minsyms_for_name): Update.
2114         * jit.c (jit_find_objf_with_entry_addr): Update.
2115         * hppa-tdep.c (find_unwind_entry)
2116         (hppa_lookup_stub_minimal_symbol): Update.
2117         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2118         Update.
2119         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2120         (elf_gnu_ifunc_resolve_by_got): Update.
2121         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2122         * dwarf-index-write.c (save_gdb_index_command): Update.
2123         * cp-support.c (add_symbol_overload_list_qualified): Update.
2124         * breakpoint.c (create_overlay_event_breakpoint)
2125         (create_longjmp_master_breakpoint)
2126         (create_std_terminate_master_breakpoint)
2127         (create_exception_master_breakpoint): Update.
2128         * blockframe.c (find_pc_partial_function): Update.
2129         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2130         (ada_collect_symbol_completion_matches)
2131         (ada_add_global_exceptions): Update.
2132
2133 2019-01-17  Tom Tromey  <tom@tromey.com>
2134
2135         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2136         declare VEC.
2137         (solib_target_parse_libraries): Change return type.
2138         (library_list_start_segment, library_list_start_section)
2139         (library_list_end_library, library_list_start_library); Update.
2140         (solib_target_free_library_list): Remove.
2141         (solib_target_parse_libraries): Remove cleanup.  Change return
2142         type.
2143         (solib_target_current_sos): Update.
2144
2145 2019-01-17  Tom Tromey  <tromey@bapiya>
2146
2147         * valprint.c: Replace "the the" with "the".
2148         * symtab.c: Replace "the the" with "the".
2149         * solib.c: Replace "the the" with "the".
2150         * solib-dsbt.c: Replace "the the" with "the".
2151         * linespec.c: Replace "the the" with "the".
2152         * dwarf2loc.h: Replace "the the" with "the".
2153         * amd64-windows-tdep.c: Replace "the the" with "the".
2154         * aarch64-tdep.c: Replace "the the" with "the".
2155
2156 2019-01-16  Keith Seitz  <keiths@redhat.com>
2157
2158         PR gdb/23773
2159         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2160         <builder>: Rename to ..
2161         <m_builder>: ... this and make private.
2162         (dwarf2_cu::get_builder): New method.  Change all users of
2163         `builder' to use this method.
2164         (dwarf2_start_symtab): Move to ...
2165         (dwarf2_cu::start_symtab): ... here.  Update all callers
2166         (setup_type_unit_groups): Move to ...
2167         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2168         callers.
2169         (dwarf2_cu::reset_builder): New method.
2170         (process_full_compunit, process_full_type_unit): Use
2171         dwarf2_cu::reset_builder.
2172         (follow_die_offset): Record the ancestor CU if it is different
2173         from the followed DIE's CU.
2174         (follow_die_sig_1): Likewise.
2175
2176 2019-01-15  Tom Tromey  <tom@tromey.com>
2177
2178         * remote.c (class remote_state) <buf>: Now a char_vector.
2179         <buf_size>: Remove.
2180         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2181         parameter.
2182         (remote_target::getpkt_or_notif_sane_1)
2183         (remote_target::getpkt_sane)
2184         (remote_target::getpkt_or_notif_sane): Likewise.
2185         (class remote_target) <putpkt>: New overload.
2186         (remote_target::read_frame): Change type of "buf_p".  Remove
2187         sizeof_p parameter.
2188         (packet_ok): New overload.
2189         (packet_check_result): New overload.
2190         Update all uses.
2191
2192 2019-01-14  Tom Tromey  <tom@tromey.com>
2193
2194         * remote-notif.c (handle_notification, remote_notif_ack)
2195         (remote_notif_parse): Make "buf" const.
2196         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2197         const.
2198         (remote_notif_parse, remote_notif_ack, handle_notification):
2199         Likewise.
2200         * remote.c (remote_notif_stop_parse): Make "buf" const.
2201         (remote_target::remote_parse_stop_reply): Make "buf" const.
2202         (remote_notif_stop_ack): Make "buf" const.
2203
2204 2019-01-14  Tom Tromey  <tom@tromey.com>
2205
2206         * remote.c (remote_console_output): Make parameter const.
2207
2208 2019-01-14  Tom Tromey  <tom@tromey.com>
2209
2210         * target-debug.h (target_debug_print_signals): Constify.
2211         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2212         * procfs.c (procfs_target::pass_signals): Update.
2213         * linux-nat.c (linux_nat_target::pass_signals): Update.
2214         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2215         * target-delegates.c: Rebuild.
2216         * remote.c (remote_target::program_signals): Update.
2217         (remote_target::pass_signals): Update.
2218         * target.c (target_pass_signals): Constify argument.
2219         (target_program_signals): Likewise.
2220         * target.h (struct target_ops) <pass_signals, program_signals>:
2221         Constify argument.
2222         (target_pass_signals, target_program_signals): Constify argument.
2223
2224 2019-01-14  Tom Tromey  <tom@tromey.com>
2225
2226         PR tui/28819:
2227         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2228
2229 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2230
2231         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2232         field.
2233         * rs6000-tdep.c: Include reggroups.h.
2234         (IS_V_ALIAS_PSEUDOREG): Define.
2235         (rs6000_register_name): Return names for the "vX" aliases.
2236         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2237         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2238         aliases.  Call default_register_reggroup_p for all other
2239         pseudo-registers.
2240         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2241         New functions.
2242         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2243         Handle "vX" aliases.
2244         (v_alias_pseudo_register_collect): New function.
2245         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2246         (rs6000_gdbarch_init): Initialize "vX" aliases as
2247         pseudo-registers.  Restore registration of
2248         rs6000_pseudo_register_reggroup_p with
2249         set_tdesc_pseudo_register_reggroup_p.
2250
2251 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2252
2253         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2254         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2255         set_gdbarch_num_pseudo_regs.
2256
2257 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2258
2259         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2260         Remove arg prefixname, add do_set and do_show.
2261         Add member functions set_list and show_list.
2262         * cli/cli-style.c (class cli_style_option): Update accordingly.
2263         (style_set_list): Move to file scope.
2264         (style_show_list): Likewise.
2265         (set_style): Call help_list.
2266         (show_style): Call cmd_show_list.
2267         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2268         Update to use the new macro.
2269
2270 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2271
2272         * ada-lang.c (_initialize_ada_language): Expand the help text
2273         for the "catch exception" command.
2274
2275 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2276
2277         * symtab.c (matching_obj_sections): Initialize obj,
2278         declare it closer to its usage.
2279
2280 2019-01-10  Tom Tromey  <tom@tromey.com>
2281
2282         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2283         (basic_inf_threads_range): Remove.
2284         (inf_threads_range, inf_non_exited_threads_range)
2285         (safe_inf_threads_range): Use next_adapter.
2286
2287 2019-01-10  Keith Seitz  <keiths@redhat.com>
2288
2289         PR gdb/23712
2290         PR symtab/23010
2291         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2292         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2293
2294 2019-01-10  Keith Seitz  <keiths@redhat.com>
2295
2296         PR gdb/23712
2297         PR symtab/23010
2298         * dictionary.c (pending_to_vector): Remove.
2299         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2300         Remove _1 suffix, replacing functions of the same name.  Update
2301         all callers.
2302         (dict_create_hashed, dict_create_hashed_expandable)
2303         (dict_create_linear, dict_create_linear_expandable, dict_free)
2304         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2305         Make functions static.
2306
2307 2019-01-10  Keith Seitz  <keiths@redhat.com>
2308
2309         PR gdb/23712
2310         PR symtab/23010
2311         * dictionary.h (struct dictionary): Replace declaration with
2312         multidictionary.
2313         (dict_create_hashed, dict_create_hashed_expandable)
2314         (dict_create_linear, dict_create_linear_expandable)
2315         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2316         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2317         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2318         taking multidictionary argument.
2319         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2320         * block.h (struct block) <dict>: Change to multidictionary
2321         and rename `multidict'.
2322         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2323         symmisc.c: Update all dictionary references to multidictionary.
2324
2325 2019-01-10  Keith Seitz  <keiths@redhat.com>
2326
2327         PR gdb/23712
2328         PR symtab/23010
2329         * dictionary.c: Include unordered_map.
2330         (pending_to_vector): New function.
2331         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2332         Rewrite the non-"_1" functions to take vector instead
2333         of linked list.
2334         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2335         "new" _1 versions of the same name.
2336         (multidictionary): Define.
2337         (std::hash<enum language): New definition.
2338         (collate_pending_symbols_by_language, mdict_create_hashed)
2339         (mdict_create_hashed_expandable, mdict_create_linear)
2340         (mdict_create_linear_expandable, mdict_free)
2341         (find_language_dictionary, create_new_language_dictionary)
2342         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2343         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2344         (mdict_size, mdict_empty): New functions.
2345         * dictionary.h (mdict_iterator): Define.
2346
2347 2019-01-10  Pedro Alves  <palves@redhat.com>
2348
2349         * breakpoint.c (read_uploaded_action)
2350         (create_tracepoint_from_upload): Adjust to use
2351         gdb::unique_xmalloc_ptr.
2352         * ctf.c (ctf_write_uploaded_tp):
2353         (SET_ARRAY_FIELD): Use emplace_back.
2354         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2355         * tracefile-tfile.c (tfile_write_uploaded_tp):
2356         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2357         gdb::unique_xmalloc_ptr.
2358         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2359         at_string, cond_string, cmd_strings>: Replace char pointers
2360         with gdb::unique_xmalloc_ptr.
2361
2362 2019-01-10  Pedro Alves  <palves@redhat.com>
2363
2364         * solib-target.c (library_list_start_library): Don't xstrdup name.
2365
2366 2019-01-10  Pedro Alves  <palves@redhat.com>
2367
2368         * mdebugread.c (parse_partial_symbols): Use
2369         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2370
2371 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2372
2373         * linux-fork.c (scoped_switch_fork_info)
2374         <~scoped_switch_fork_info>: Fix incorrect variable name.
2375
2376 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2377
2378         * linux-fork.c (scoped_switch_fork_info)
2379         <scoped_switch_fork_info>: Make explicit.
2380         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2381
2382 2019-01-10  Tom Tromey  <tom@tromey.com>
2383
2384         * objfiles.h (objfile::reset_psymtabs): Update.
2385         * objfiles.c (objfile::objfile): Update.
2386         * psymtab.h (psymtab_storage::obstack): Update.
2387         (psymtab_storage::m_obstack): Use gdb::optional.
2388         (class psymtab_storage): Update comment.  Remove objfile
2389         parameter.
2390         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2391
2392 2019-01-10  Tom Tromey  <tom@tromey.com>
2393
2394         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2395         <free_psymtabs>: Now private.
2396         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2397         (allocate_psymtab): Use new method.
2398
2399 2019-01-10  Tom Tromey  <tom@tromey.com>
2400
2401         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2402         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2403         * mdebugread.c (parse_partial_symbols): Use
2404         allocate_dependencies.
2405         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2406         allocate_dependencies.
2407         (process_psymtab_comp_unit_reader)
2408         (build_type_psymtab_dependencies): Likewise.
2409         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2410
2411 2019-01-10  Tom Tromey  <tom@tromey.com>
2412
2413         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2414         PSYMBOL_SET_LANGUAGE.
2415         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2416
2417 2019-01-10  Tom Tromey  <tom@tromey.com>
2418
2419         * psymtab.h (psymtab_storage::obstack): New method.
2420         <m_obstack>: Rename from obstack; now private.
2421         * psymtab.c (psymtab_storage): Update.
2422         * dwarf2read.c (create_addrmap_from_index)
2423         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2424         Update.
2425
2426 2019-01-10  Tom Tromey  <tom@tromey.com>
2427
2428         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2429         * objfiles.h (objfile::reset_psymtabs): New method.
2430
2431 2019-01-10  Tom Tromey  <tom@tromey.com>
2432
2433         * symmisc.c (print_symbol_bcache_statistics): Update.
2434         (print_objfile_statistics): Update.
2435         * symfile.c (reread_symbols): Update.
2436         * psymtab.h (class psymtab_storage): New.
2437         * psymtab.c (psymtab_storage): New constructor.
2438         (~psymtab_storage): New destructor.
2439         (require_partial_symbols): Update.
2440         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2441         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2442         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2443         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2444         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2445         (start_psymtab_common, end_psymtab_common)
2446         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2447         (allocate_psymtab): Update.
2448         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2449         Update.
2450         (dump_psymtab_addrmap, maintenance_print_psymbols)
2451         (maintenance_check_psymtabs): Update.
2452         (class objfile_psymtabs): Move to objfiles.h.
2453         * psympriv.h (discard_psymtab): Now inline.
2454         (psymtab_discarder::psymtab_discarder): Update.
2455         (psymtab_discarder::~psymtab_discarder): Update.
2456         (ALL_OBJFILE_PSYMTABS): Rewrite.
2457         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2458         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2459         Remove fields.
2460         <partial_symtabs>: New field.
2461         (class objfile_psymtabs): Move from psymtab.h.  Update.
2462         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2463         psymbol_cache.
2464         (objfile::~objfile): Don't destroy psymbol_cache.
2465         * mdebugread.c (parse_partial_symbols): Update.
2466         * dwarf2read.c (create_addrmap_from_index)
2467         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2468         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2469         (add_partial_subprogram, dwarf2_ranges_read): Update.
2470         * dwarf-index-write.c (write_address_map)
2471         (write_one_signatured_type, recursively_write_psymbols)
2472         (class debug_names, class debug_names, write_psymtabs_to_index):
2473         Update.
2474
2475 2019-01-10  Tom Tromey  <tom@tromey.com>
2476
2477         * symtab.h (SYMBOL_SET_NAMES): Update.
2478         (symbol_set_names): Update.
2479         (MSYMBOL_SET_NAMES): Update.
2480         * symtab.c (symbol_set_names): Change argument to be an
2481         objfile_per_bfd_storage.
2482         * psymtab.c (add_psymbol_to_bcache): Update.
2483         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2484
2485 2019-01-10  Tom Tromey  <tom@tromey.com>
2486
2487         * symtab.c (create_demangled_names_hash): Change argument to be an
2488         objfile_per_bfd_storage.
2489         (symbol_set_names): Update.
2490
2491 2019-01-10  Tom Tromey  <tom@tromey.com>
2492
2493         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2494         init_psymbol_list.
2495         * psymtab.c (init_psymbol_list): Do nothing if already called.
2496         * psympriv.h (init_psymbol_list): Add comment.
2497         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2498         init_psymbol_list.
2499         * dbxread.c (dbx_symfile_read): Unconditionally call
2500         init_psymbol_list.
2501
2502 2019-01-10  Tom Tromey  <tom@tromey.com>
2503
2504         * xcoffread.c (scan_xcoff_symtab): Update.
2505         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2506         "where".
2507         * mdebugread.c (parse_partial_symbols)
2508         (handle_psymbol_enumerators): Update.
2509         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2510         * dbxread.c (read_dbx_symtab): Update.
2511         * psympriv.h (psymbol_placement): New enum.
2512         (add_psymbol_to_list): Update.
2513
2514 2019-01-10  Tom Tromey  <tom@tromey.com>
2515
2516         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2517         static_psymbols parameters.
2518         (scan_xcoff_symtab): Update.
2519         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2520         static_psymbols parameters.
2521         * psympriv.h (start_psymtab_common): Update.
2522         * mdebugread.c (parse_partial_symbols): Update.
2523         * dwarf2read.c (create_partial_symtab): Update.
2524         * dbxread.c (read_dbx_symtab): Update.
2525         (start_psymtab): Remove global_psymbols and static_psymbols
2526         parameters.
2527
2528 2019-01-10  Tom Tromey  <tom@tromey.com>
2529
2530         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2531         * psymtab.c (allocate_psymtab): Add comment.
2532         * psympriv.h (allocate_psymtab): Add comment.
2533         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2534         initializations.
2535         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2536
2537 2019-01-10  Tom Tromey  <tom@tromey.com>
2538
2539         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2540         Don't declare.
2541         * mipsread.c: Include mdebugread.h.
2542         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2543         Declare.
2544         * elfread.c: Include mdebugread.h.
2545
2546 2019-01-09  Tom Tromey  <tom@tromey.com>
2547
2548         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2549         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2550         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2551         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2552         (psym_lookup_symbol, psym_find_last_source_symtab)
2553         (psym_forget_cached_source_info, psym_print_stats)
2554         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2555         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2556         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2557         (psym_find_compunit_symtab_by_address)
2558         (maintenance_print_psymbols, maintenance_info_psymtabs)
2559         (maintenance_check_psymtabs): Use ranged for.
2560         * psymtab.h (class objfile_psymtabs): New.
2561         (require_partial_symbols): Return objfile_psymtabs.
2562         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2563
2564 2019-01-09  Tom Tromey  <tom@tromey.com>
2565
2566         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2567         (find_pc_mapped_section, list_overlays_command)
2568         (map_overlay_command, unmap_overlay_command)
2569         (simple_overlay_update): Use all_objfiles.
2570         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2571         * printcmd.c (info_symbol_command): Use all_objfiles.
2572         * objfiles.h (ALL_OBJSECTIONS): Remove.
2573         * maint.c (maintenance_translate_address): Use all_objfiles.
2574         * gcore.c (gcore_create_callback): Use all_objfiles.
2575         (objfile_find_memory_regions): Likewise.
2576
2577 2019-01-09  Tom Tromey  <tom@tromey.com>
2578
2579         * symtab.c (find_line_symtab, info_sources_command)
2580         (make_source_files_completion_list): Use objfile_compunits.
2581         * source.c (select_source_symtab): Use objfile_compunits.
2582         * objfiles.h (struct objfile): Update comment.
2583         (ALL_OBJFILES): Remove.
2584         (ALL_FILETABS): Remove.
2585         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2586         objfile_compunits.
2587
2588 2019-01-09  Tom Tromey  <tom@tromey.com>
2589
2590         * symmisc.c (print_objfile_statistics, dump_objfile)
2591         (maintenance_print_symbols): Use compunit_filetabs.
2592         * source.c (forget_cached_source_info_for_objfile): Use
2593         compunit_filetabs.
2594         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2595         (ALL_FILETABS): Use compunit_filetabs.
2596         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2597         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2598
2599 2019-01-09  Tom Tromey  <tom@tromey.com>
2600
2601         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2602         (compunit_filetabs): New.
2603         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2604         compunit_filetabs.
2605         (info_sources_command, make_source_files_completion_list): Remove
2606         declaration.
2607         * symmisc.c (print_objfile_statistics, dump_objfile)
2608         (maintenance_print_symbols): Remove declaration.
2609         (maintenance_info_symtabs): Use compunit_filetabs.
2610         (maintenance_info_line_tables): Likewise.
2611         * source.c (select_source_symtab): Change local variable name.
2612         (forget_cached_source_info_for_objfile): Remove declaration.
2613         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2614         * objfiles.c (objfile_relocate1): Remove declaration.
2615         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2616         declaration.
2617         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2618         * coffread.c (coff_symtab_read): Remove declaration.
2619         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2620         compunit_filetabs.
2621
2622 2019-01-09  Tom Tromey  <tom@tromey.com>
2623
2624         * symtab.c (lookup_objfile_from_block)
2625         (find_pc_sect_compunit_symtab, search_symbols)
2626         (default_collect_symbol_completion_matches_break_on): Use
2627         objfile_compunits.
2628         * objfiles.h (ALL_COMPUNITS): Remove.
2629         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2630         * cp-support.c (add_symbol_overload_list_qualified): Use
2631         objfile_compunits.
2632         * ada-lang.c (ada_collect_symbol_completion_matches)
2633         (ada_add_global_exceptions): Use objfile_compunits.
2634
2635 2019-01-09  Tom Tromey  <tom@tromey.com>
2636
2637         * source.c (select_source_symtab)
2638         (forget_cached_source_info_for_objfile): Remove declaration.
2639         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2640         declaration.
2641         * maint.c (count_symtabs_and_blocks): Remove declaration.
2642         * cp-support.c (add_symbol_overload_list_qualified): Remove
2643         declaration.
2644         * coffread.c (coff_symtab_read): Remove declaration.
2645         * symtab.c (lookup_symbol_in_objfile_symtabs)
2646         (basic_lookup_transparent_type_1): Use objfile_compunits.
2647         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2648         (info_sources_command, search_symbols)
2649         (default_collect_symbol_completion_matches_break_on)
2650         (make_source_files_completion_list): Remove declaration.
2651         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2652         (ada_collect_symbol_completion_matches)
2653         (ada_add_global_exceptions): Remove declaration.
2654         * linespec.c (iterate_over_all_matching_symtabs): Use
2655         objfile_compunits.
2656         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2657         (class objfile_compunits): New.
2658         (ALL_COMPUNITS): Use objfile_compunits.
2659         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2660         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2661         objfile_compunits.
2662         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2663
2664 2019-01-09  Tom Tromey  <tom@tromey.com>
2665
2666         * symtab.c (search_symbols)
2667         (default_collect_symbol_completion_matches_break_on): Use
2668         objfile_msymbols.
2669         * ada-lang.c (ada_lookup_simple_minsym)
2670         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2671         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2672         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2673         objfile_msymbols.
2674         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2675         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2676         * objc-lang.c (find_methods): Use objfile_msymbols.
2677         (info_selectors_command, info_classes_command): Likewise.
2678         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2679         * objfiles.h (class objfile_msymbols): New.
2680         (ALL_OBJFILE_MSYMBOLS): Remove.
2681         (ALL_MSYMBOLS): Remove.
2682
2683 2019-01-09  Tom Tromey  <tom@tromey.com>
2684
2685         * common/next-iterator.h (next_adapter): Add Iterator template
2686         parameter.
2687         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2688         (class all_objfiles_safe): New.
2689         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2690         * objfiles.c (put_objfile_before): Update comment.
2691         (add_separate_debug_objfile): Likewise.
2692         (free_all_objfiles): Use all_objfiles_safe.
2693         (objfile_purge_solibs): Likewise.
2694
2695 2019-01-09  Tom Tromey  <tom@tromey.com>
2696
2697         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2698         (expand_symtab_containing_pc, lookup_static_symbol)
2699         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2700         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2701         all_objfiles.
2702         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2703         * breakpoint.c (create_overlay_event_breakpoint)
2704         (create_longjmp_master_breakpoint)
2705         (create_std_terminate_master_breakpoint)
2706         (create_exception_master_breakpoint): Use all_objfiles.
2707         * linux-thread-db.c (try_thread_db_load_from_pdir)
2708         (has_libpthread): Use all_objfiles.
2709         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2710         * linespec.c (iterate_over_all_matching_symtabs)
2711         (search_minsyms_for_name): Use all_objfiles.
2712         * maint.c (maintenance_info_sections): Use all_objfiles.
2713         * main.c (captured_main_1): Use all_objfiles.
2714         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2715         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2716         * guile/scm-pretty-print.c
2717         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2718         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2719         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2720         (maintenance_print_msymbols): Use all_objfiles.
2721         * source.c (select_source_symtab): Use all_objfiles.
2722         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2723         * symfile.c (remove_symbol_file_command)
2724         (expand_symtabs_matching, map_symbol_filenames): Use
2725         all_objfiles.
2726         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2727         all_objfiles.
2728         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2729         * objc-lang.c (find_methods): Use all_objfiles.
2730         * objfiles.c (have_partial_symbols, have_full_symbols)
2731         (have_minimal_symbols, qsort_cmp)
2732         (default_iterate_over_objfiles_in_search_order): Use
2733         all_objfiles.
2734         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2735         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2736         (maintenance_check_psymtabs): Use all_objfiles.
2737         (ALL_PSYMTABS): Remove.
2738         * compile/compile-object-run.c (do_module_cleanup): Use
2739         all_objfiles.
2740         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2741         * cp-support.c (add_symbol_overload_list_qualified): Use
2742         all_objfiles.
2743         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2744         Use all_objfiles.
2745         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2746         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2747         all_objfiles.
2748         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2749         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2750         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2751         Uses all_objfiles.
2752         * solib.c (solib_read_symbols): Use all_objfiles
2753
2754 2019-01-09  Tom Tromey  <tom@tromey.com>
2755
2756         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2757         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2758         all_objfiles.
2759         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2760         * symmisc.c (print_symbol_bcache_statistics)
2761         (print_objfile_statistics, maintenance_print_objfiles)
2762         (maintenance_info_symtabs, maintenance_check_symtabs)
2763         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2764         all_objfiles.
2765         * source.c (forget_cached_source_info): Use all_objfiles.
2766         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2767         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2768         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2769         * objfiles.c (update_section_map): Use all_objfiles.
2770         (shared_objfile_contains_address_p): Likewise.
2771         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2772         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2773
2774 2019-01-09  Tom Tromey  <tom@tromey.com>
2775
2776         * common/next-iterator.h: New file.
2777         * objfiles.h (class all_objfiles): New.
2778         (struct objfile_iterator): New.
2779
2780 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2781
2782         * NEWS: Move the description of the changed "frame", "select-frame",
2783          and "info frame" commands to the Changed commands section.
2784
2785 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2786
2787         * gdbtypes.c (check_stub_method_group): Remove handling of old
2788         mangling schemes.
2789         * linespec.c (find_methods): Likewise.
2790         * stabsread.c (read_member_functions): Likewise.
2791         * valops.c (search_struct_method): Likewise.
2792         (value_struct_elt_for_reference): Likewise.
2793         * NEWS: Mention this change.
2794
2795 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2796
2797         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2798         print_source_lines.
2799         * source.c (print_source_lines_base): Update line number check.
2800         (print_source_lines): New function.
2801         (source_lines_range::source_lines_range): New function.
2802         * source.h (class source_lines_range): New class.
2803         (print_source_lines): New declaration.
2804
2805 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2806
2807         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2808
2809 2019-01-08  Tom Tromey  <tom@tromey.com>
2810             Simon Marchi  <simon.marchi@ericsson.com>
2811
2812         PR gdb/24060
2813         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2814         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2815         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2816         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2817         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2818         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2819
2820 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2821
2822         * source.c (select_source_symtab): Move header comment to
2823         declaration in source.h.
2824         (forget_cached_source_info_for_objfile): Likewise.
2825         (forget_cached_source_info): Likewise.
2826         (identify_source_line): Likewise.
2827         * source.h (identify_source_line): Move declaration from symtab.h
2828         and add comment from source.c
2829         (print_source_lines): Likewise.
2830         (forget_cached_source_info_for_objfile): Likewise.
2831         (forget_cached_source_info): Likewise.
2832         (select_source_symtab): Likewise.
2833         (enum print_source_lines_flag): Move definition from symtab.h.
2834         * symtab.h (identify_source_line): Move declaration to source.h.
2835         (print_source_lines): Likewise.
2836         (forget_cached_source_info_for_objfile): Likewise.
2837         (forget_cached_source_info): Likewise.
2838         (select_source_symtab): Likewise.
2839         (enum print_source_lines_flag): Move definition to source.h.
2840         * tui/tui-hooks.c: Add 'source.h' include.
2841
2842 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2843
2844         * source.c (print_source_lines_base): Handle requests to print
2845         reverse line number sequences, and guard against empty lines
2846         string.
2847
2848 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2849
2850         * source.c (print_source_lines_base): Fix skip of '\r' if next
2851         character is '\n'.
2852
2853 2019-01-06  Tom Tromey  <tom@tromey.com>
2854
2855         * c-exp.y (struct c_parse_state) <macro_original_text,
2856         expansion_obstack>: New member.
2857         (macro_original_text, expansion_obstack): Remove globals.
2858         (scan_macro_expansion, scanning_macro_expansion)
2859         (finished_macro_expansion): Update.
2860         (scan_macro_cleanup): Remove.
2861         (yylex, c_parse): Update.
2862
2863 2019-01-06  Tom Tromey  <tom@tromey.com>
2864
2865         * c-exp.y (struct c_parse_state) <strings>: New member.
2866         (operator_stoken): Update.
2867
2868 2019-01-06  Tom Tromey  <tom@tromey.com>
2869
2870         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2871         (union type_stack_elt) <typelist_val>: Now a pointer to
2872         std::vector.
2873         (type_stack_cleanup): Don't declare.
2874         (push_typelist): Update.
2875         * parse.c (pop_typelist): Return a std::vector.
2876         (push_typelist): Take a std::vector.
2877         (follow_types): Update.  Do not free args.
2878         (type_stack_cleanup): Remove.
2879         * c-exp.y (struct c_parse_state): New.
2880         (cpstate): New global.
2881         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2882         (nonempty_typelist): Update.
2883         (func_mod): Create a new vector.
2884         (c_parse): Create a c_parse_state.
2885         (check_parameter_typelist): Do not delete params.
2886         (function_method): Update.  Do not delete type_list.
2887
2888 2019-01-06  Tom Tromey  <tom@tromey.com>
2889
2890         PR gdb/28155:
2891         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2892         check_typedef.
2893         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2894         (print_return_value): Likewise.
2895
2896 2019-01-05  Tom Tromey  <tom@tromey.com>
2897
2898         * contrib/cleanup_check.py: Remove.
2899         * contrib/gcc-with-excheck: Remove.
2900         * contrib/exsummary.py: Remove.
2901         * contrib/excheck.py: Remove.
2902
2903 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2904
2905         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2906         NULL. Initialize tpprev to NULL instead of assigning it
2907         to NULL on the next statement.
2908         * windows-nat.c (windows_delete_thread): Remove check for
2909         main_thread_id before printing thread exit notifications.
2910         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2911         Remove thread ID check against main_thread_id.
2912         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2913         windows_delete_thread.
2914         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2915
2916 2019-01-04  Tom Tromey  <tom@tromey.com>
2917
2918         * compile/compile.c (_initialize_compile): Use upper case for
2919         metasyntactic variables.
2920         * symmisc.c (_initialize_symmisc): Use upper case for
2921         metasyntactic variables.
2922         * psymtab.c (_initialize_psymtab): Use upper case for
2923         metasyntactic variables.
2924         * demangle.c (demangle_command): Use upper case for metasyntactic
2925         variables.
2926         (_initialize_demangler): Likewise.
2927         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2928         variables.
2929
2930 2019-01-03  Tom Tromey  <tom@tromey.com>
2931
2932         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2933
2934 2019-01-03  Tom Tromey  <tom@tromey.com>
2935
2936         * python/py-symtab.c (salpy_str): Update.
2937         (struct salpy_sal_object) <symtab>: Now a PyObject.
2938         (salpy_dealloc): Update.
2939         (del_objfile_sal): Use gdbpy_ref.
2940
2941 2019-01-03  Tom Tromey  <tom@tromey.com>
2942
2943         * python/py-type.c (convert_field): Use new_reference.  Return
2944         gdbpy_ref.
2945         (make_fielditem): Return gdbpy_ref.
2946         (typy_fields): Update.
2947         (typy_getitem): Update.
2948         (field_name): Return gdbpy_ref.  Use new_reference.
2949         (typy_iterator_iternext): Update.
2950
2951 2019-01-03  Tom Tromey  <tom@tromey.com>
2952
2953         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2954
2955 2019-01-03  Tom Tromey  <tom@tromey.com>
2956
2957         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2958         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2959         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2960         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2961         (pspy_set_type_printers): Likewise.
2962         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2963         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2964         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2965         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2966         (objfpy_set_type_printers): Likewise.
2967
2968 2019-01-03  Tom Tromey  <tom@tromey.com>
2969
2970         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2971         (gdbpy_print_stack): Use gdbpy_err_fetch.
2972         * python/python-internal.h (class gdbpy_err_fetch): New class.
2973         (class gdbpy_enter) <m_error_type, m_error_value,
2974         m_error_traceback>: Remove.
2975         <m_error>: New member.
2976         (gdbpy_exception_to_string): Don't declare.
2977         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2978         * python/py-value.c (convert_value_from_python): Use
2979         gdbpy_err_fetch.
2980         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2981         gdbpy_exception_to_string.
2982         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2983         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2984         gdbpy_err_fetch.
2985
2986 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2987
2988         * linux-nat.c (delete_lwp_cleanup): Delete.
2989         (struct lwp_deleter): New struct.
2990         (lwp_info_up): New typedef.
2991         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2992         lwp_info_up.
2993
2994 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2995
2996         * linux-fork.c (class scoped_switch_fork_info): New class.
2997         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2998
2999 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3000
3001         * valops.c (find_overload_match): Remove use of null_cleanup, and
3002         calls to do_cleanups.
3003
3004 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3005
3006         * compile/compile-cplus-types.c
3007         (compile_cplus_instance::decl_name): Handle changes to
3008         cp_func_name.
3009         * cp-support.c (cp_func_name): Update header comment, update
3010         return type.
3011         * cp-support.h (cp_func_name): Update return type in declaration.
3012         * valops.c (find_overload_match): Move temp_func local to top
3013         level of function and change its type.  Use temp_func to hold and
3014         delete temporary string obtained from cp_func_name.
3015
3016 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3017
3018         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3019         gdb::char_vector, remove cleanup, and update uses of `msg`.
3020
3021 2019-01-03  Jim Wilson  <jimw@sifive.com>
3022
3023         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3024
3025 2019-01-02  Tom Tromey  <tom@tromey.com>
3026
3027         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3028         (tdesc_parse_xml): Remove cleanups.
3029         * target-descriptions.h (make_cleanup_free_target_description):
3030         Don't declare.
3031         (target_desc_deleter): New struct.
3032         (target_desc_up): New typedef.
3033         * target-descriptions.c (target_desc_deleter::operator()): Rename
3034         from free_target_description.
3035         (make_cleanup_free_target_description): Remove.
3036
3037 2019-01-02  Tom Tromey  <tom@tromey.com>
3038
3039         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3040         constructor, destructor.
3041         (linespec_parser): Remove typedef.
3042         (~linespec_parser): Rename from linespec_parser_delete.
3043         (linespec_lex_to_end, linespec_complete_label)
3044         (linespec_complete): Update.
3045         (decode_line_full): Remove cleanups.
3046         (decode_line_1): Update.
3047
3048 2019-01-02  Tom Tromey  <tom@tromey.com>
3049
3050         * python/python-internal.h (inferior_to_inferior_object): Change
3051         return type.
3052         * python/py-exitedevent.c (create_exited_event_object): Update.
3053         * python/py-inferior.c (inferior_to_inferior_object): Return
3054         gdbpy_ref.
3055         (python_new_inferior, python_inferior_deleted)
3056         (thread_to_thread_object, delete_thread_object)
3057         (build_inferior_list, gdbpy_selected_inferior): Update.
3058         * python/py-infthread.c (create_thread_object): Update.  Also fail
3059         if inferior_to_inferior_object fails.
3060
3061 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3062
3063         * inferior.h (class inferior) <displaced_step_state>: New field.
3064         * infrun.h (struct displaced_step_state): Move here from
3065         infrun.c.  Initialize fields, add constructor.
3066         <inf>: Remove field.
3067         <reset>: New method.
3068         * infrun.c (struct displaced_step_inferior_state): Move to
3069         infrun.h.
3070         (displaced_step_inferior_states): Remove.
3071         (get_displaced_stepping_state): Adust.
3072         (displaced_step_in_progress_any_inferior): Adjust.
3073         (displaced_step_in_progress_thread): Adjust.
3074         (displaced_step_in_progress): Adjust.
3075         (add_displaced_stepping_state): Remove.
3076         (get_displaced_step_closure_by_addr): Adjust.
3077         (remove_displaced_stepping_state): Remove.
3078         (infrun_inferior_exit): Call displaced_step_state.reset.
3079         (use_displaced_stepping): Don't check for NULL.
3080         (displaced_step_prepare_throw): Call
3081         get_displaced_stepping_state.
3082         (displaced_step_fixup): Don't check for NULL.
3083         (prepare_for_detach): Don't check for NULL.
3084
3085 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3086
3087         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3088          in case of call that did not complete.
3089
3090 2019-01-02  Andrey Utkin  <autkin@undo.io>
3091
3092         * symfile.c (find_separate_debug_file): Fix search of debug files for
3093         remote debuggee.
3094
3095 2019-01-02  Tom Tromey  <tom@tromey.com>
3096
3097         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3098         indentation.
3099         * python/py-frame.c (frapy_older): Remove cast.
3100         (frapy_newer): Likewise.
3101         * python/py-breakpoint.c (local_setattro): Remove cast.
3102         * python/py-arch.c (archpy_name): Remove local variable.
3103         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3104
3105 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3106
3107         * unittests/basic_string_view/element_access/char/empty.cc:
3108         Fix year range in copyright header.
3109
3110 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3111
3112         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3113         Delete.
3114         <operator==>: Update with for removed field.
3115         <hash>: Likewise.
3116         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3117         <isa_features>: ...this.
3118         <abi_features>: New field.
3119         (riscv_isa_flen): Update comment.
3120         (riscv_abi_xlen): New declaration.
3121         (riscv_abi_flen): New declaration.
3122         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3123         isa_features.
3124         (riscv_abi_xlen): New function.
3125         (riscv_isa_flen): Update to get answer from isa_features.
3126         (riscv_abi_flen): New function.
3127         (riscv_has_fp_abi): Update to get answer from abi_features.
3128         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3129         xlen and flen.
3130         (riscv_call_info) <xlen, flen>: Update comment.
3131         (riscv_call_arg_struct): Remove invalid assertions
3132         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3133         is removed.
3134         (riscv_gdbarch_init): Gather isa features and abi features
3135         separately, ensure both match on the gdbarch when reusing an old
3136         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3137         a target with 64-bit float hardware.
3138
3139 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3140
3141         * source.c (search_command_helper): Stop reverse search
3142         when line 1 has been searched.
3143
3144 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3145
3146         * record-full.c (record_full_base_target::close): Rewrite
3147         record_full_core_buf_list free logic.
3148
3149 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3150
3151         * break-catch-syscall.c (print_one_catch_syscall): xfree
3152         the last text.
3153
3154 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3155
3156         * top.c (print_gdb_version): Update Copyright year in version
3157         message.
3158
3159 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3160
3161         Update copyright year range in all GDB files.
3162
3163 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3164
3165         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3166
3167 For older changes see ChangeLog-2018.
3168 \f
3169 Local Variables:
3170 mode: change-log
3171 left-margin: 8
3172 fill-column: 74
3173 version-control: never
3174 coding: utf-8
3175 End:
3176