C++ify remote notification code
[external/binutils.git] / gdb / ChangeLog
1 2019-03-06  Tom Tromey  <tom@tromey.com>
2
3         * remote.c (struct stop_reply_deleter): Remove.
4         (stop_reply_up): Update.
5         (struct stop_reply): Derive from notif_event.  Don't typedef.
6         <regcache>: Now a std::vector.
7         (stop_reply_xfree): Remove.
8         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10         (remote_target::discard_pending_stop_replies): Use delete.
11         (remote_target::remote_parse_stop_reply): Update.
12         (remote_target::process_stop_reply): Update.
13         * remote-notif.h (struct notif_event): Add virtual destructor.
14         Remove "dtr" member.
15         (struct notif_client) <alloc_event>: Return a unique_ptr.
16         (notif_event_xfree): Don't declare.
17         (notif_event_up): New typedef.
18         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
19         (notif_event_xfree, do_notif_event_xfree): Remove.
20         (remote_notif_state_xfree): Update.
21
22 2019-03-06  Tom Tromey  <tom@tromey.com>
23
24         * infrun.c (displaced_step_clear_cleanup): Now a
25         forward_scope_exit type.
26         (displaced_step_prepare_throw): Update.
27         (displaced_step_fixup): Update.
28
29 2019-03-06  Tom Tromey  <tom@tromey.com>
30
31         * inferior.h (class inferior): Update comment.
32         * gdbthread.h (class thread_info): Update comment.
33
34 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
35             Tom Tromey  <tom@tromey.com>
36
37         * stabsread.h (struct stab_section_list): Remove.
38         (coffstab_build_psymtabs): Update.
39         * dbxread.c (symbuf_sections): Now a std::vector.
40         (sect_idx): New global.
41         (fill_symbuf): Update.
42         (coffstab_build_psymtabs): Change type of stabsects parameter.
43         Update.
44         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
45         std::vector.
46         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
47         (coff_locate_sections): Update.
48         (coff_symfile_read): Remove cleanups.  Update.
49         (init_stringtab): Add storage parameter.
50         (free_stringtab, free_stringtab_cleanup): Remove.
51         (init_lineno): Add storage parameter.
52         (free_linetab, free_linetab_cleanup): Remove.
53
54 2019-03-06  Pedro Alves  <palves@redhat.com>
55
56         * linux-fork.c (fork_info::clobber_regs): Delete.
57         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
58         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
59         comment.  Adjust.
60         (scoped_switch_fork_info::scoped_switch_fork_info)
61         (checkpoint_command, linux_fork_context): Adjust
62         fork_save_infrun_state calls.
63
64 2019-03-06  Pedro Alves  <palves@redhat.com>
65
66         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
67         (inf_has_multiple_threads): Return 'bool' and rewrite using
68         inferior_info::threads().
69
70 2019-03-06  Pedro Alves  <palves@redhat.com>
71
72         * linux-fork.c: Include <list>.
73         (fork_list): Now a std::list instance.
74         (fork_info): Add ctor, dtor, and in-class initialize all fields.
75         (forks_exist_p, find_last_fork): Adjust.
76         (new_fork): Delete.
77         (one_fork_p): New.
78         (add_fork): Adjust.
79         (free_fork): Delete, folded into fork_info::~fork_info().
80         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
81         Adjust.
82         (init_fork_list): Delete.
83         (linux_fork_killall, linux_fork_mourn_inferior)
84         (linux_fork_detach, info_checkpoints_command): Adjust.
85         (_initialize_linux_fork): No longer call init_fork_list.
86
87 2019-03-06  Pedro Alves  <palves@redhat.com>
88
89         * linux-fork.c (new_fork): New, split out of ...
90         (add_fork): ... this.  Return void.  Move "first fork" special
91         case from here, to ...
92         (checkpoint_command): ... here.
93         * linux-linux.h (add_fork): Return void.
94
95 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
96
97         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
98
99 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
100             Chris January  <chris.january@arm.com>
101             David Lecomber  <david.lecomber@arm.com>
102
103         * f-exp.y: New token, UNOP_INTRINSIC.
104         (exp): New pattern using UNOP_INTRINSIC token.
105         (f77_keywords): Add 'abs' keyword.
106         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
107         (value_from_host_double): New function.
108         (evaluate_subexp_f): Support UNOP_ABS.
109
110 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
111
112         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
113         types.
114
115 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
116
117         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
118         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
119         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
120
121 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
122
123         * f-exp.y (convert_to_kind_type): Handle more type kinds.
124
125 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
126             Chris January  <chris.january@arm.com>
127
128         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
129         * f-exp.y: Define 'KIND' token.
130         (exp): New pattern for KIND expressions.
131         (ptype): Handle types with a kind extension.
132         (direct_abs_decl): Extend to spot kind extensions.
133         (f77_keywords): Add 'kind' to the list.
134         (push_kind_type): New function.
135         (convert_to_kind_type): New function.
136         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
137         * parse.c (operator_length_standard): Likewise.
138         * parser-defs.h (enum type_pieces): Add tp_kind.
139         * std-operator.def: Add UNOP_KIND.
140
141 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
142
143         * f-exp.y (f_parse): Set yydebug.
144
145 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
146
147         * f-lang.c (evaluate_subexp_f): New function.
148         (exp_descriptor_f): New global.
149         (f_language_defn): Use exp_descriptor_f instead of
150         exp_descriptor_standard.
151
152 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
153
154         * f-exp.y (struct token): Add comments.
155         (dot_ops): Remove uppercase versions and the end marker.
156         (f77_keywords): Likewise.
157         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
158         entries in the dot_ops array are case insensitive, and use
159         strncasecmp to compare strings.  Also some whitespace cleanup in
160         this area.  Similar for the f77_keywords array, except entries in
161         this list might be case sensitive.
162
163 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
164
165         * f-exp.y (struct f77_boolean_val): Add comments.
166         (boolean_values): Remove uppercase versions, and end marker.
167         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
168         and use strncasecmp to achieve case insensitivity.  Additionally,
169         perform whitespace cleanup around this code.
170
171 2019-03-06  Tom Tromey  <tromey@adacore.com>
172
173         * remote-sim.c (gdbsim_target_open): Use result of
174         gdb_argv::release.
175
176 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
177         Dirk Schubert  <dirk.schubert@arm.com>
178         Chris January  <chris.january@arm.com>
179
180         * eval.c (evaluate_subexp_standard): Call Fortran argument
181         wrapping logic.
182         * f-lang.c (struct value): A value which can be passed into a
183         Fortran function call.
184         (fortran_argument_convert): Wrap Fortran arguments in a pointer
185         where appropriate.
186         (struct type): Value ready for a Fortran function call.
187         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
188         is needed.
189         * f-lang.h (fortran_argument_convert): Declaration.
190         (fortran_preserve_arg_pointer): Declaration.
191         * infcall.c (value_arg_coerce): Call Fortran argument logic.
192
193 2019-03-05  Tom Tromey  <tromey@adacore.com>
194
195         * python/py-prettyprint.c (print_string_repr): Remove #if.
196         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
197
198 2019-03-05  Tom Tromey  <tromey@adacore.com>
199
200         * target.c (the_dummy_target): Move later.  Change type to
201         "dummy_target".
202         (initialize_targets): Don't initialize the_dummy_target.
203
204 2019-03-05  Tom Tromey  <tromey@adacore.com>
205
206         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
207         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
208
209 2019-03-05  Tom Tromey  <tromey@adacore.com>
210
211         * windows-nat.c (windows_nat_target::attach)
212         (windows_nat_target::detach): Don't call gdb_flush.
213         * valprint.c (generic_val_print, val_print, val_print_string):
214         Don't call gdb_flush.
215         * utils.c (defaulted_query): Don't call gdb_flush.
216         * typeprint.c (print_type_scalar): Don't call gdb_flush.
217         * target.c (target_announce_detach): Don't call gdb_flush.
218         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
219         * remote.c (extended_remote_target::attach): Don't call
220         gdb_flush.
221         * procfs.c (procfs_target::detach): Don't call gdb_flush.
222         * printcmd.c (do_examine): Don't call gdb_flush.
223         (info_display_command): Don't call gdb_flush.
224         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
225         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
226         * memattr.c (info_mem_command): Don't call gdb_flush.
227         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
228         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
229         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
230         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
231         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
232         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
233         (gnu_nat_target::detach): Don't call gdb_flush.
234         * f-valprint.c (f_val_print): Don't call gdb_flush.
235         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
236         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
237         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
238         gdb_flush.
239         * c-valprint.c (c_val_print): Don't call gdb_flush.
240         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
241
242 2019-03-05  Tom Tromey  <tromey@adacore.com>
243
244         * varobj.c (update_dynamic_varobj_children): Update.
245         (install_default_visualizer): Use reset, not release.
246         * value.c (set_internalvar): Update.
247         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
248         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
249         ATTRIBUTE_UNUSED_RESULT.
250
251 2019-03-05  Tom Tromey  <tromey@adacore.com>
252
253         * remote.c (class scoped_remote_fd) <release>: Add
254         ATTRIBUTE_UNUSED_RESULT.
255
256 2019-03-05  Tom Tromey  <tromey@adacore.com>
257
258         * macroexp.c (struct macro_buffer) <release>: Add
259         ATTRIBUTE_UNUSED_RESULT.
260
261 2019-03-05  Tom Tromey  <tromey@adacore.com>
262
263         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
264         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
265         ATTRIBUTE_UNUSED_RESULT.
266
267 2019-03-05  Tom Tromey  <tromey@adacore.com>
268
269         * common/scoped_fd.h (class scoped_fd) <release>: Add
270         ATTRIBUTE_UNUSED_RESULT.
271
272 2019-03-05  Tom Tromey  <tromey@adacore.com>
273
274         * parser-defs.h (struct parser_state) <release>: Add
275         ATTRIBUTE_UNUSED_RESULT.
276
277 2019-03-05  Tom Tromey  <tromey@adacore.com>
278
279         * utils.h (class gdb_argv) <release>: Add
280         ATTRIBUTE_UNUSED_RESULT.
281         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
282
283 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
284
285         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
286         for-loop range, to avoid compiler warnings.
287
288         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
289         avoid compiler warnings about unused variables.
290
291         * NEWS: Mention end of support for native debugging on MS-Windows
292         before XP.
293
294         PR gdb/24292
295         * common/netstuff.c:
296         * gdbserver/gdbreplay.c
297         * gdbserver/remote-utils.c:
298         * ser-tcp.c:
299         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
300         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
301         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
302         'getaddrinfo' and 'freeaddrinfo' were not available before
303         Windows XP, and mingw.org's MinGW headers by default define
304         _WIN32_WINNT to 0x500.
305
306 2019-03-01  Gary Benson <gbenson@redhat.com>
307
308         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
309
310 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
311             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
312
313         PR gdb/8527
314         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
315         set_sigint_trap, clear_sigint_trap.
316
317 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
318
319         * target.c (target_detach): Clear the regcache and the
320         frame cache.
321
322 2019-02-27  Pedro Alves  <palves@redhat.com>
323
324         * utils.c (set_screen_size): When we cap the height/width sizes,
325         tweak the corresponding command variable to show "unlimited":
326
327 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
328             Pedro Alves  <palves@redhat.com>
329
330         * utils.c (set_screen_size): Reduce "infinite" rows and columns
331         before calling rl_set_screen_size.
332
333 2019-02-27  Tom Tromey  <tromey@adacore.com>
334
335         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
336         define.
337         * python/py-value.c: Remove Python 2.4 workaround.
338         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
339         workaround.
340         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
341         Python 2.4 workaround.
342         * python/python-internal.h: Remove Python 2.4 comment.
343         (Py_ssize_t): Don't define.
344         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
345         (gdb_Py_DECREF): Remove Python 2.4 workaround.
346         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
347         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
348         * python/python.c (do_start_initialization): Remove Python 2.4
349         workaround.
350         * python/py-prettyprint.c (class dummy_python_frame): Remove.
351         (print_children): Remove Python 2.4 workaround.
352         * python/py-inferior.c (buffer_procs): Remove Python 2.4
353         workaround.
354         (CHARBUFFERPROC_NAME): Remove.
355         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
356         Python 2.4 workaround.
357
358 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
359
360         * NEWS: Note minimum Python version.
361
362 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
363
364         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
365         code from these functions.  Remove corresponding ifdefs.  Use
366         Py_buffer_up instead of explicit calls to PyBuffer_Release.
367         Remove gotos and target of gotos.
368         (infpy_search_memory): Likewise.
369
370 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
371
372         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
373         (hppa_gdbarch_init): Don't register deleted functions with
374         gdbarch.
375
376 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
377
378         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
379         (h8300_unwind_sp): Delete.
380         (h8300_dummy_id): Delete.
381         (h8300_gdbarch_init): Don't register deleted functions with
382         gdbarch.
383
384 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
385
386         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
387         (ft32_unwind_pc): Delete.
388         (ft32_unwind_sp): Delete.
389         (ft32_gdbarch_init): Don't register deleted functions with
390         gdbarch.
391
392 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
393
394         * gdb/frv-tdep.c (frv_dummy_id): Delete.
395         (frv_unwind_pc): Delete.
396         (frv_unwind_sp): Delete.
397         (frv_gdbarch_init): Don't register deleted functions with
398         gdbarch.
399
400 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
401
402         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
403         (riscv_unwind_pc): Delete.
404         (riscv_unwind_sp): Delete.
405         (riscv_gdbarch_init): Don't register deleted functions with
406         gdbarch.
407
408 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
409
410         * gdb/csky-tdep.c (csky_dummy_id): Delete.
411         (csky_unwind_pc): Delete.
412         (csky_unwind_sp): Delete.
413         (csky_gdbarch_init): Don't register deleted functions with
414         gdbarch.
415
416 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
417
418         * gdb/cris-tdep.c (cris_dummy_id): Delete.
419         (cris_unwind_pc): Delete.
420         (cris_unwind_sp): Delete.
421         (cris_gdbarch_init): Don't register deleted functions with
422         gdbarch.
423
424 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
425
426         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
427         (bfin_unwind_pc): Delete.
428         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
429
430 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
431
432         * gdb/arm-tdep.c (arm_dummy_id): Delete.
433         (arm_unwind_pc): Delete.
434         (arm_unwind_sp): Delete.
435         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
436
437 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
438
439         * gdb/arc-tdep.c (arc_dummy_id): Delete.
440         (arc_unwind_pc): Delete.
441         (arc_unwind_sp): Delete.
442         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
443
444 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
445
446         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
447         (alpha_unwind_pc): Delete.
448         (alpha_gdbarch_init): Don't register deleted functions with
449         gdbarch.
450
451 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
452
453         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
454         (aarch64_unwind_pc): Delete.
455         (aarch64_unwind_sp): Delete.
456         (aarch64_gdbarch_init): Don't register deleted functions with
457         gdbarch.
458
459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
460
461         * gdbtypes.c (type_align): Don't consider static members when
462         computing structure alignment.
463
464 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
465
466         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
467         return 0 for other types.
468         * arch-utils.c (default_type_align): Always return 0.
469         * gdbarch.h: Regenerate.
470         * gdbarch.sh (type_align): Extend comment.
471         * gdbtypes.c (type_align): Add additional comments, always call
472         gdbarch_type_align before applying the default rules.
473         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
474         generic code will then apply a suitable default.
475         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
476         types, return 0 for other types.
477
478 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
479
480         * NEWS: Create a new section for the next release branch.
481         Rename the section of the current branch, now that it has
482         been cut.
483
484 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
485
486         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
487         * version.in: Bump version to 8.3.50.DATE-git.
488
489 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
490
491         * aix-thread.c (ptid_cmp): Remove unused variable.
492         (get_signaled_thread): Likewise.
493         (store_regs_user_thread): Likewise.
494         (store_regs_kernel_thread): Likewise.
495         (fetch_regs_kernel_thread): Remove shadowed variable.
496
497 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
498
499         * features/riscv/32bit-cpu.xml: Add register numbers.
500         * features/riscv/32bit-fpu.c: Regenerate.
501         * features/riscv/32bit-fpu.xml: Add register numbers.
502         * features/riscv/64bit-cpu.xml: Add register numbers.
503         * features/riscv/64bit-fpu.c: Regenerate.
504         * features/riscv/64bit-fpu.xml: Add register numbers.
505
506 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
507
508         * NEWS: Mention two argument form of gdb.Value constructor.
509         * python/py-value.c (convert_buffer_and_type_to_value): New
510         function.
511         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
512         Add support for handling an optional second argument.  Call
513         convert_buffer_and_type_to_value as appropriate.
514         * python/python-internal.h (Py_buffer_deleter): New struct.
515         (Py_buffer_up): New typedef.
516
517 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
518
519         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
520         instead of releasing ownership.
521
522 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
523
524         * dwarf2read.c (open_and_init_dwp_file): Call
525         elf_numsections instead of bfd_count_sections to initialize
526         dwp_file->num_sections.
527
528 2019-02-25  Tom Tromey  <tromey@adacore.com>
529
530         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
531
532 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
533
534         * gcore.in: Add '--readnever' option when invoking GDB.
535
536 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
537
538         * MAINTAINERS: Update my email address.
539
540 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
541
542         * build-id.c (build_id_to_debug_bfd_1): New function.
543         (build_id_to_debug_bfd): Look for separate debug file in
544         sysroot.
545
546 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
547
548         * gdbarch.sh: Update the copyright year range that is placed into
549         generated files.
550
551 2019-02-22  Keith Seitz  <keiths@redhat.com>
552
553         PR symtab/23853
554         * linespec.c (create_sals_line_offset): Search for the default
555         symtab's filename instead of its fullname.
556
557 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
558
559         * NEWS: Update style defaults.
560
561 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
562
563         * main.c (captured_main_1): Disable styling in batch mode.
564
565 2019-02-20  Tom Tromey  <tom@tromey.com>
566
567         * symtab.c (symtab_symbol_info): Fix typos.
568
569 2019-02-20  Tom Tromey  <tromey@adacore.com>
570
571         * findcmd.c (_initialize_mem_search): Use upper case for
572         metasyntactic variables.
573
574 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
575
576         * aarch64-tdep.c (aarch64_add_reggroups): New function.
577         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
578
579 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
580
581         * top.h (source_file_name): Change to std::string.
582         * top.c (source_file_name): Likewise.
583         (command_line_input): Adjust.
584         * cli/cli-script.c (script_from_file): Adjust.
585
586 2019-02-19  Tom Tromey  <tromey@adacore.com>
587
588         * ravenscar-thread.c
589         (ravenscar_thread_target::update_thread_list): Don't call
590         ada_build_task_list.
591         * ada-lang.h (ada_build_task_list): Don't declare.
592         * ada-tasks.c (struct ada_tasks_inferior_data)
593         <task_list_valid_p>: Now bool.
594         (read_known_tasks, ada_task_list_changed)
595         (ada_tasks_invalidate_inferior_data): Update.
596         (read_known_tasks_array): Return bool.
597         (read_known_tasks_list): Likewise.
598         (read_known_tasks): Return void.
599         (ada_build_task_list): Now static.
600
601 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
602
603         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
604         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
605
606 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
607
608         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
609         variant for ada_tasks_pspace_data_handle and
610         ada_tasks_inferior_data_handle.
611         (ada_tasks_pspace_data_cleanup): New function.
612         (ada_tasks_inferior_data_cleanup): New function.
613
614 2019-02-17  Tom Tromey  <tom@tromey.com>
615
616         * macrotab.h (macro_source_fullname): Return a std::string.
617         * macrotab.c (macro_include, check_for_redefinition)
618         (macro_undef, macro_lookup_definition, foreach_macro)
619         (foreach_macro_in_scope): Update.
620         (macro_source_fullname): Return a std::string.
621         * macrocmd.c (show_pp_source_pos): Update.
622
623 2019-02-17  Tom Tromey  <tom@tromey.com>
624
625         * macrocmd.c (show_pp_source_pos): Style the file names.
626
627 2019-02-17  Tom Tromey  <tom@tromey.com>
628
629         PR tui/24197:
630         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
631
632 2019-02-17  Tom Tromey  <tom@tromey.com>
633
634         * ada-lang.c (user_select_syms): Use filtered printing.
635         * utils.c (wrap_style): New global.
636         (desired_style): Remove.
637         (emit_style_escape): Add stream parameter.
638         (set_output_style, reset_terminal_style, prompt_for_continue):
639         Update.
640         (flush_wrap_buffer): Only flush gdb_stdout.
641         (wrap_here): Set wrap_style.
642         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
643         treat escape sequences as a character.  Change when wrap buffer is
644         flushed.
645         (fputs_styled): Do not set the output style when the default is
646         requested.
647         * ui-style.h (struct ui_file_style) <is_default>: New method.
648         * source.c (print_source_lines_base): Emit escape sequences in one
649         piece.
650
651 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
652
653         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
654         integers and enumeration types.
655
656 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
657
658         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
659         instead of lookup_symbol_in_language
660         (do_exact_match): New function.
661         (ada_get_symbol_name_matcher): Return do_exact_match when
662         doing a verbatim match.
663
664 2019-02-15  Tom Tromey  <tromey@adacore.com>
665
666         * ravenscar-thread.c (ravenscar_thread_target::resume)
667         (ravenscar_thread_target::wait): Special case wildcard requests.
668
669 2019-02-15  Tom Tromey  <tromey@adacore.com>
670
671         * ravenscar-thread.c (base_ptid): Remove.
672         (struct ravenscar_thread_target) <close>: New method.
673         <m_base_ptid>: New member.
674         <update_inferior_ptid, active_task, task_is_currently_active,
675         runtime_initialized>: Declare methods.
676         <ravenscar_thread_target>: Add constructor.
677         (ravenscar_thread_target::task_is_currently_active)
678         (ravenscar_thread_target::update_inferior_ptid)
679         (ravenscar_runtime_initialized): Rename.  Now methods.
680         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
681         (ravenscar_thread_target::update_thread_list): Update.
682         (ravenscar_thread_target::active_task): Now method.
683         (ravenscar_thread_target::store_registers)
684         (ravenscar_thread_target::prepare_to_store)
685         (ravenscar_thread_target::prepare_to_store)
686         (ravenscar_thread_target::mourn_inferior): Update.
687         (ravenscar_inferior_created): Use "new" to create target.
688         (ravenscar_thread_target::get_ada_task_ptid): Update.
689         (_initialize_ravenscar): Don't initialize base_ptid.
690         (ravenscar_ops): Remove global.
691
692 2019-02-15  Tom Tromey  <tromey@adacore.com>
693
694         * target.h (push_target): Declare new overload.
695         * target.c (push_target): New overload, taking an rvalue reference.
696         * remote.c (remote_target::open_1): Use push_target overload.
697         * corelow.c (core_target_open): Use push_target overload.
698
699 2019-02-15  Tom Tromey  <tromey@adacore.com>
700
701         * ravenscar-thread.c (is_ravenscar_task)
702         (ravenscar_task_is_currently_active): Return bool.
703         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
704         (_initialize_ravenscar): Remove "(void)".
705         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
706         Return bool.
707
708 2019-02-15  Tom Tromey  <tromey@adacore.com>
709
710         * ravenscar-thread.c (ravenscar_runtime_initializer)
711         (has_ravenscar_runtime, get_running_thread_id)
712         (ravenscar_thread_target::resume): Fix indentation.
713
714 2019-02-15  Tom Tromey  <tromey@adacore.com>
715
716         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
717         from ravenscar_arch_ops.
718         (sparc_ravenscar_ops::fetch_registers)
719         (sparc_ravenscar_ops::store_registers): Now methods.
720         (sparc_ravenscar_prepare_to_store): Remove.
721         (sparc_ravenscar_ops): Redefine.
722         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
723         methods and destructor.  Remove members.
724         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
725         (ravenscar_thread_target::store_registers)
726         (ravenscar_thread_target::prepare_to_store): Update.
727         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
728         Remove.
729         (struct ppc_ravenscar_powerpc_ops): Derive from
730         ravenscar_arch_ops.
731         (ppc_ravenscar_powerpc_ops::fetch_registers)
732         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
733         (ppc_ravenscar_powerpc_ops): Redefine.
734         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
735         (ppc_ravenscar_e500_ops::fetch_registers)
736         (ppc_ravenscar_e500_ops::store_registers): Now methods.
737         (ppc_ravenscar_e500_ops): Redefine.
738         * aarch64-ravenscar-thread.c
739         (aarch64_ravenscar_generic_prepare_to_store): Remove.
740         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
741         (aarch64_ravenscar_fetch_registers)
742         (aarch64_ravenscar_store_registers): Now methods.
743         (aarch64_ravenscar_ops): Redefine.
744
745 2019-02-15  Tom Tromey  <tromey@adacore.com>
746
747         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
748         (ravenscar_thread_target::stopped_by_hw_breakpoint)
749         (ravenscar_thread_target::stopped_by_watchpoint)
750         (ravenscar_thread_target::stopped_data_address)
751         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
752
753 2019-02-15  Tom Tromey  <tromey@adacore.com>
754
755         * ravenscar-thread.c: Fix some typos.
756
757 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
758             Tom Tromey  <tromey@adacore.com>
759
760         * ada-lang.c (ada_exception_sal): Change addr_string to a
761         std::string.
762         (create_ada_exception_catchpoint): Update.
763
764 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
765             Tom Tromey  <tromey@adacore.com>
766
767         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
768         (bp_location_ops): Remove.
769         (base_breakpoint_allocate_location): Update.
770         (free_bp_location): Update.
771         * ada-lang.c (class ada_catchpoint_location)
772         <ada_catchpoint_location>: Remove ops parameter.
773         (ada_catchpoint_location_dtor): Remove.
774         (ada_catchpoint_location_ops): Remove.
775         (allocate_location_exception): Update.
776         * breakpoint.h (struct bp_location_ops): Remove.
777         (class bp_location) <bp_location>: Remove bp_location_ops
778         parameter.
779         <~bp_location>: Add destructor.
780         <ops>: Remove.
781
782 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
783             Pedro Alves  <palves@redhat.com>
784
785         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
786         'PATH_MAX'.
787
788 2019-02-14  David Michael  <fedora.dm0@gmail.com>
789             Samuel Thibault  <samuel.thibault@gnu.org>
790             Thomas Schwinge  <thomas@codesourcery.com>
791
792         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
793         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
794
795 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
796
797         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
798         (check_empty): Use "const char *".
799
800         * gnu-nat.c (gnu_nat_target::detach): Instead of
801         'detach_inferior (pid)' call
802         'detach_inferior (find_inferior_pid (pid))'.
803
804         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
805         'nat/fork-inferior.o'.
806         * gnu-nat.c: #include "nat/fork-inferior.h".
807
808         * gnu-nat.c (gnu_nat_target::detach): Instead of
809         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
810         * gnu-nat.h: #include "inf-child.h".
811         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
812         'i386_gnu_nat_target::fetch_registers'.
813         (gnu_store_registers): Rename/move to
814         'i386_gnu_nat_target::store_registers'.
815
816         * config/i386/nm-i386gnu.h: Don't "#include" any files.
817         * gnu-nat.h (mach_thread_info): New function.
818         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
819
820         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
821
822 2019-02-14  Frederic Konrad  <konrad@adacore.com>
823
824         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
825
826 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
827
828         * windows-nat.c (windows_add_thread): Add new parameter
829         "main_thread_p" with default value set to false.  Update
830         function documentation as well as all callers.
831         (windows_delete_thread): Likewise.
832         (fake_create_process): Update call to windows_add_thread.
833         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
834         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
835         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
836         call to windows_delete_thread.
837
838 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
839
840         * MAINTAINERS: Add Andrew Burgess as global maintainer.
841
842 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
843
844         * symfile.c (find_separate_debug_file): Use canonical path of
845         sysroot with child_path instead of gdb_sysroot if it is valid.
846
847 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
848
849         * symfile.c (find_separate_debug_file): Use child_path to
850         determine if an object file is under a sysroot.
851
852 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
853
854         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
855         unittests/child-path-selftests.c.
856         * common/pathstuff.c (child_path): New function.
857         * common/pathstuff.h (child_path): New prototype.
858         * unittests/child-path-selftests.c: New file.
859
860 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
861
862         * symfile.c (find_separate_debug_file): Look for separate debug
863         files in debug directories under the sysroot.
864
865 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
866
867         * symtab.h (struct minimal_symbol data_p): New const method.
868         (struct minimal_symbol text_p): Likewise.
869         * symtab.c (output_source_filename): Use file name style
870         to print file name.
871         (print_symbol_info): Likewise.
872         (print_msymbol_info): Use address style to print addresses.
873         Use function name style to print executable text symbols.
874         (expand_symtab_containing_pc): Use data_p.
875         (find_pc_sect_compunit_symtab): Likewise.
876
877 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
878
879         * breakpoint.c (describe_other_breakpoints): Use address style
880         to print addresses.
881         (say_where): Likewise.
882
883 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
884
885         * ada-typeprint.c (print_func_type): Print function name
886         style to print function name.
887         * c-typeprint.c (c_print_type_1): Likewise.
888
889 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
890
891         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
892         for execve.
893
894 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
895
896         * c-exp.y (direct_abs_decl): Use emplace_back to record the
897         type_stack.
898
899 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
900
901         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
902         TYPE_CODE_REF types.
903
904 2019-02-08  Jim Wilson  <jimw@sifive.com>
905
906         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
907         (riscv_linux_fregset): New.
908         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
909
910 2019-02-07  Tom Tromey  <tom@tromey.com>
911
912         * thread.c (thread_cancel_execution_command): Update.
913         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
914         methods.
915         (struct thread_fsm_ops): Remove.
916         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
917         (thread_fsm_should_stop, thread_fsm_return_value)
918         (thread_fsm_set_finished, thread_fsm_finished_p)
919         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
920         Don't declare.
921         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
922         * infrun.c (clear_proceed_status_thread)
923         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
924         (print_stop_event): Update.
925         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
926         Add constructor.
927         (step_command_fsm_ops): Remove.
928         (new_step_command_fsm): Remove.
929         (step_1): Update.
930         (step_command_fsm::should_stop): Rename from
931         step_command_fsm_should_stop.
932         (step_command_fsm::clean_up): Rename from
933         step_command_fsm_clean_up.
934         (step_command_fsm::do_async_reply_reason): Rename from
935         step_command_fsm_async_reply_reason.
936         (struct until_next_fsm): Inherit from thread_fsm.  Add
937         constructor.
938         (until_next_fsm_ops): Remove.
939         (new_until_next_fsm): Remove.
940         (until_next_fsm::should_stop): Rename from
941         until_next_fsm_should_stop.
942         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
943         (until_next_fsm::do_async_reply_reason): Rename from
944         until_next_fsm_async_reply_reason.
945         (struct finish_command_fsm): Inherit from thread_fsm.  Add
946         constructor.  Change type of breakpoint.
947         (finish_command_fsm_ops): Remove.
948         (new_finish_command_fsm): Remove.
949         (finish_command_fsm::should_stop): Rename from
950         finish_command_fsm_should_stop.
951         (finish_command_fsm::clean_up): Rename from
952         finish_command_fsm_clean_up.
953         (finish_command_fsm::return_value): Rename from
954         finish_command_fsm_return_value.
955         (finish_command_fsm::do_async_reply_reason): Rename from
956         finish_command_fsm_async_reply_reason.
957         (finish_command): Update.
958         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
959         Add constructor.
960         (call_thread_fsm_ops): Remove.
961         (call_thread_fsm::call_thread_fsm): Rename from
962         new_call_thread_fsm.
963         (call_thread_fsm::should_stop): Rename from
964         call_thread_fsm_should_stop.
965         (call_thread_fsm::should_notify_stop): Rename from
966         call_thread_fsm_should_notify_stop.
967         (run_inferior_call, call_function_by_hand_dummy): Update.
968         * cli/cli-interp.c (should_print_stop_to_console): Update.
969         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
970         Add constructor.  Change type of location_breakpoint,
971         caller_breakpoint.
972         (until_break_fsm_ops): Remove.
973         (new_until_break_fsm): Remove.
974         (until_break_fsm::should_stop): Rename from
975         until_break_fsm_should_stop.
976         (until_break_fsm::clean_up): Rename from
977         until_break_fsm_clean_up.
978         (until_break_fsm::do_async_reply_reason): Rename from
979         until_break_fsm_async_reply_reason.
980         (until_break_command): Update.
981         * thread-fsm.c: Remove.
982         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
983
984 2019-02-07  Tom Tromey  <tom@tromey.com>
985
986         * yy-remap.h: Add include guard.
987         * xtensa-tdep.h: Add include guard.
988         * xcoffread.h: Rename include guard.
989         * varobj-iter.h: Add include guard.
990         * tui/tui.h: Rename include guard.
991         * tui/tui-winsource.h: Rename include guard.
992         * tui/tui-wingeneral.h: Rename include guard.
993         * tui/tui-windata.h: Rename include guard.
994         * tui/tui-win.h: Rename include guard.
995         * tui/tui-stack.h: Rename include guard.
996         * tui/tui-source.h: Rename include guard.
997         * tui/tui-regs.h: Rename include guard.
998         * tui/tui-out.h: Rename include guard.
999         * tui/tui-layout.h: Rename include guard.
1000         * tui/tui-io.h: Rename include guard.
1001         * tui/tui-hooks.h: Rename include guard.
1002         * tui/tui-file.h: Rename include guard.
1003         * tui/tui-disasm.h: Rename include guard.
1004         * tui/tui-data.h: Rename include guard.
1005         * tui/tui-command.h: Rename include guard.
1006         * tic6x-tdep.h: Add include guard.
1007         * target/waitstatus.h: Rename include guard.
1008         * target/wait.h: Rename include guard.
1009         * target/target.h: Rename include guard.
1010         * target/resume.h: Rename include guard.
1011         * target-float.h: Rename include guard.
1012         * stabsread.h: Add include guard.
1013         * rs6000-tdep.h: Add include guard.
1014         * riscv-fbsd-tdep.h: Add include guard.
1015         * regformats/regdef.h: Rename include guard.
1016         * record.h: Rename include guard.
1017         * python/python.h: Rename include guard.
1018         * python/python-internal.h: Rename include guard.
1019         * python/py-stopevent.h: Rename include guard.
1020         * python/py-ref.h: Rename include guard.
1021         * python/py-record.h: Rename include guard.
1022         * python/py-record-full.h: Rename include guard.
1023         * python/py-record-btrace.h: Rename include guard.
1024         * python/py-instruction.h: Rename include guard.
1025         * python/py-events.h: Rename include guard.
1026         * python/py-event.h: Rename include guard.
1027         * procfs.h: Add include guard.
1028         * proc-utils.h: Add include guard.
1029         * p-lang.h: Add include guard.
1030         * or1k-tdep.h: Rename include guard.
1031         * observable.h: Rename include guard.
1032         * nto-tdep.h: Rename include guard.
1033         * nat/x86-linux.h: Rename include guard.
1034         * nat/x86-linux-dregs.h: Rename include guard.
1035         * nat/x86-gcc-cpuid.h: Add include guard.
1036         * nat/x86-dregs.h: Rename include guard.
1037         * nat/x86-cpuid.h: Rename include guard.
1038         * nat/ppc-linux.h: Rename include guard.
1039         * nat/mips-linux-watch.h: Rename include guard.
1040         * nat/linux-waitpid.h: Rename include guard.
1041         * nat/linux-ptrace.h: Rename include guard.
1042         * nat/linux-procfs.h: Rename include guard.
1043         * nat/linux-osdata.h: Rename include guard.
1044         * nat/linux-nat.h: Rename include guard.
1045         * nat/linux-namespaces.h: Rename include guard.
1046         * nat/linux-btrace.h: Rename include guard.
1047         * nat/glibc_thread_db.h: Rename include guard.
1048         * nat/gdb_thread_db.h: Rename include guard.
1049         * nat/gdb_ptrace.h: Rename include guard.
1050         * nat/fork-inferior.h: Rename include guard.
1051         * nat/amd64-linux-siginfo.h: Rename include guard.
1052         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1053         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1054         * nat/aarch64-linux.h: Rename include guard.
1055         * nat/aarch64-linux-hw-point.h: Rename include guard.
1056         * mn10300-tdep.h: Add include guard.
1057         * mips-linux-tdep.h: Add include guard.
1058         * mi/mi-parse.h: Rename include guard.
1059         * mi/mi-out.h: Rename include guard.
1060         * mi/mi-main.h: Rename include guard.
1061         * mi/mi-interp.h: Rename include guard.
1062         * mi/mi-getopt.h: Rename include guard.
1063         * mi/mi-console.h: Rename include guard.
1064         * mi/mi-common.h: Rename include guard.
1065         * mi/mi-cmds.h: Rename include guard.
1066         * mi/mi-cmd-break.h: Rename include guard.
1067         * m2-lang.h: Add include guard.
1068         * location.h: Rename include guard.
1069         * linux-record.h: Rename include guard.
1070         * linux-nat.h: Add include guard.
1071         * linux-fork.h: Add include guard.
1072         * i386-darwin-tdep.h: Rename include guard.
1073         * hppa-linux-offsets.h: Add include guard.
1074         * guile/guile.h: Rename include guard.
1075         * guile/guile-internal.h: Rename include guard.
1076         * gnu-nat.h: Rename include guard.
1077         * gdb-stabs.h: Rename include guard.
1078         * frv-tdep.h: Add include guard.
1079         * f-lang.h: Add include guard.
1080         * event-loop.h: Add include guard.
1081         * darwin-nat.h: Rename include guard.
1082         * cp-abi.h: Rename include guard.
1083         * config/sparc/nm-sol2.h: Rename include guard.
1084         * config/nm-nto.h: Rename include guard.
1085         * config/nm-linux.h: Add include guard.
1086         * config/i386/nm-i386gnu.h: Rename include guard.
1087         * config/djgpp/nl_types.h: Rename include guard.
1088         * config/djgpp/langinfo.h: Rename include guard.
1089         * compile/gcc-cp-plugin.h: Add include guard.
1090         * compile/gcc-c-plugin.h: Add include guard.
1091         * compile/compile.h: Rename include guard.
1092         * compile/compile-object-run.h: Rename include guard.
1093         * compile/compile-object-load.h: Rename include guard.
1094         * compile/compile-internal.h: Rename include guard.
1095         * compile/compile-cplus.h: Rename include guard.
1096         * compile/compile-c.h: Rename include guard.
1097         * common/xml-utils.h: Rename include guard.
1098         * common/x86-xstate.h: Rename include guard.
1099         * common/version.h: Rename include guard.
1100         * common/vec.h: Rename include guard.
1101         * common/tdesc.h: Rename include guard.
1102         * common/selftest.h: Rename include guard.
1103         * common/scoped_restore.h: Rename include guard.
1104         * common/scoped_mmap.h: Rename include guard.
1105         * common/scoped_fd.h: Rename include guard.
1106         * common/safe-iterator.h: Rename include guard.
1107         * common/run-time-clock.h: Rename include guard.
1108         * common/refcounted-object.h: Rename include guard.
1109         * common/queue.h: Rename include guard.
1110         * common/ptid.h: Rename include guard.
1111         * common/print-utils.h: Rename include guard.
1112         * common/preprocessor.h: Rename include guard.
1113         * common/pathstuff.h: Rename include guard.
1114         * common/observable.h: Rename include guard.
1115         * common/netstuff.h: Rename include guard.
1116         * common/job-control.h: Rename include guard.
1117         * common/host-defs.h: Rename include guard.
1118         * common/gdb_wait.h: Rename include guard.
1119         * common/gdb_vecs.h: Rename include guard.
1120         * common/gdb_unlinker.h: Rename include guard.
1121         * common/gdb_unique_ptr.h: Rename include guard.
1122         * common/gdb_tilde_expand.h: Rename include guard.
1123         * common/gdb_sys_time.h: Rename include guard.
1124         * common/gdb_string_view.h: Rename include guard.
1125         * common/gdb_splay_tree.h: Rename include guard.
1126         * common/gdb_setjmp.h: Rename include guard.
1127         * common/gdb_ref_ptr.h: Rename include guard.
1128         * common/gdb_optional.h: Rename include guard.
1129         * common/gdb_locale.h: Rename include guard.
1130         * common/gdb_assert.h: Rename include guard.
1131         * common/filtered-iterator.h: Rename include guard.
1132         * common/filestuff.h: Rename include guard.
1133         * common/fileio.h: Rename include guard.
1134         * common/environ.h: Rename include guard.
1135         * common/common-utils.h: Rename include guard.
1136         * common/common-types.h: Rename include guard.
1137         * common/common-regcache.h: Rename include guard.
1138         * common/common-inferior.h: Rename include guard.
1139         * common/common-gdbthread.h: Rename include guard.
1140         * common/common-exceptions.h: Rename include guard.
1141         * common/common-defs.h: Rename include guard.
1142         * common/common-debug.h: Rename include guard.
1143         * common/cleanups.h: Rename include guard.
1144         * common/buffer.h: Rename include guard.
1145         * common/btrace-common.h: Rename include guard.
1146         * common/break-common.h: Rename include guard.
1147         * cli/cli-utils.h: Rename include guard.
1148         * cli/cli-style.h: Rename include guard.
1149         * cli/cli-setshow.h: Rename include guard.
1150         * cli/cli-script.h: Rename include guard.
1151         * cli/cli-interp.h: Rename include guard.
1152         * cli/cli-decode.h: Rename include guard.
1153         * cli/cli-cmds.h: Rename include guard.
1154         * charset-list.h: Add include guard.
1155         * buildsym-legacy.h: Rename include guard.
1156         * bfin-tdep.h: Add include guard.
1157         * ax.h: Rename include guard.
1158         * arm-linux-tdep.h: Add include guard.
1159         * arm-fbsd-tdep.h: Add include guard.
1160         * arch/xtensa.h: Rename include guard.
1161         * arch/tic6x.h: Add include guard.
1162         * arch/i386.h: Add include guard.
1163         * arch/arm.h: Rename include guard.
1164         * arch/arm-linux.h: Rename include guard.
1165         * arch/arm-get-next-pcs.h: Rename include guard.
1166         * arch/amd64.h: Add include guard.
1167         * arch/aarch64-insn.h: Rename include guard.
1168         * arch-utils.h: Rename include guard.
1169         * annotate.h: Add include guard.
1170         * amd64-darwin-tdep.h: Rename include guard.
1171         * aarch64-linux-tdep.h: Add include guard.
1172         * aarch64-fbsd-tdep.h: Add include guard.
1173         * aarch32-linux-nat.h: Add include guard.
1174
1175 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1176
1177         * macrotab.c (macro_define_internal): New function that
1178         factorizes macro_define_object_internal and macro_define_function
1179         code.
1180         (macro_define_object_internal): Use macro_define_internal.
1181         (macro_define_function): Likewise.
1182
1183 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1184
1185         * macrocmd.c (extract_identifier): Return
1186         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1187         callers.
1188
1189 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1190
1191         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1192
1193 2019-02-05  Tom Tromey  <tom@tromey.com>
1194
1195         * target.c (target_stack::unpush): Move assertion earlier.
1196
1197 2019-01-30  Tom Tromey  <tom@tromey.com>
1198
1199         PR python/23615:
1200         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1201         (gdbpy_parse_and_eval): Likewise.
1202         * python/python-internal.h (gdbpy_allow_threads): New class.
1203
1204 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1205
1206         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1207         (aarch64_fbsd_fpregmap): Move earlier.
1208         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1209         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1210         instead of individual calls to trad_frame_set_reg_addr.
1211         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1212         earlier.
1213         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1214         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1215         instead of individual calls to trad_frame_set_reg_addr.
1216
1217 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1218
1219         * CONTRIBUTE: Replace contribution list with wiki link.
1220
1221 2019-01-25  Tom Tromey  <tom@tromey.com>
1222
1223         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1224
1225 2019-01-25  Tom Tromey  <tom@tromey.com>
1226
1227         * xtensa-linux-nat.c: Fix common/ includes.
1228         * xml-support.h: Fix common/ includes.
1229         * xml-support.c: Fix common/ includes.
1230         * x86-linux-nat.c: Fix common/ includes.
1231         * windows-nat.c: Fix common/ includes.
1232         * varobj.h: Fix common/ includes.
1233         * varobj.c: Fix common/ includes.
1234         * value.c: Fix common/ includes.
1235         * valops.c: Fix common/ includes.
1236         * utils.c: Fix common/ includes.
1237         * unittests/xml-utils-selftests.c: Fix common/ includes.
1238         * unittests/utils-selftests.c: Fix common/ includes.
1239         * unittests/unpack-selftests.c: Fix common/ includes.
1240         * unittests/tracepoint-selftests.c: Fix common/ includes.
1241         * unittests/style-selftests.c: Fix common/ includes.
1242         * unittests/string_view-selftests.c: Fix common/ includes.
1243         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1244         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1245         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1246         * unittests/rsp-low-selftests.c: Fix common/ includes.
1247         * unittests/parse-connection-spec-selftests.c: Fix common/
1248         includes.
1249         * unittests/optional-selftests.c: Fix common/ includes.
1250         * unittests/offset-type-selftests.c: Fix common/ includes.
1251         * unittests/observable-selftests.c: Fix common/ includes.
1252         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1253         * unittests/memrange-selftests.c: Fix common/ includes.
1254         * unittests/memory-map-selftests.c: Fix common/ includes.
1255         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1256         * unittests/function-view-selftests.c: Fix common/ includes.
1257         * unittests/environ-selftests.c: Fix common/ includes.
1258         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1259         * unittests/common-utils-selftests.c: Fix common/ includes.
1260         * unittests/cli-utils-selftests.c: Fix common/ includes.
1261         * unittests/array-view-selftests.c: Fix common/ includes.
1262         * ui-file.c: Fix common/ includes.
1263         * tui/tui-io.c: Fix common/ includes.
1264         * tracepoint.h: Fix common/ includes.
1265         * tracepoint.c: Fix common/ includes.
1266         * tracefile-tfile.c: Fix common/ includes.
1267         * top.h: Fix common/ includes.
1268         * top.c: Fix common/ includes.
1269         * thread.c: Fix common/ includes.
1270         * target/waitstatus.h: Fix common/ includes.
1271         * target/waitstatus.c: Fix common/ includes.
1272         * target.h: Fix common/ includes.
1273         * target.c: Fix common/ includes.
1274         * target-memory.c: Fix common/ includes.
1275         * target-descriptions.c: Fix common/ includes.
1276         * symtab.h: Fix common/ includes.
1277         * symfile.c: Fix common/ includes.
1278         * stap-probe.c: Fix common/ includes.
1279         * spu-linux-nat.c: Fix common/ includes.
1280         * sparc-nat.c: Fix common/ includes.
1281         * source.c: Fix common/ includes.
1282         * solib.c: Fix common/ includes.
1283         * solib-target.c: Fix common/ includes.
1284         * ser-unix.c: Fix common/ includes.
1285         * ser-tcp.c: Fix common/ includes.
1286         * ser-pipe.c: Fix common/ includes.
1287         * ser-base.c: Fix common/ includes.
1288         * selftest-arch.c: Fix common/ includes.
1289         * s12z-tdep.c: Fix common/ includes.
1290         * rust-exp.y: Fix common/ includes.
1291         * rs6000-aix-tdep.c: Fix common/ includes.
1292         * riscv-tdep.c: Fix common/ includes.
1293         * remote.c: Fix common/ includes.
1294         * remote-notif.h: Fix common/ includes.
1295         * remote-fileio.h: Fix common/ includes.
1296         * remote-fileio.c: Fix common/ includes.
1297         * regcache.h: Fix common/ includes.
1298         * regcache.c: Fix common/ includes.
1299         * record-btrace.c: Fix common/ includes.
1300         * python/python.c: Fix common/ includes.
1301         * python/py-type.c: Fix common/ includes.
1302         * python/py-inferior.c: Fix common/ includes.
1303         * progspace.h: Fix common/ includes.
1304         * producer.c: Fix common/ includes.
1305         * procfs.c: Fix common/ includes.
1306         * proc-api.c: Fix common/ includes.
1307         * printcmd.c: Fix common/ includes.
1308         * ppc-linux-nat.c: Fix common/ includes.
1309         * parser-defs.h: Fix common/ includes.
1310         * osdata.c: Fix common/ includes.
1311         * obsd-nat.c: Fix common/ includes.
1312         * nat/x86-linux.c: Fix common/ includes.
1313         * nat/x86-linux-dregs.c: Fix common/ includes.
1314         * nat/x86-dregs.h: Fix common/ includes.
1315         * nat/x86-dregs.c: Fix common/ includes.
1316         * nat/ppc-linux.c: Fix common/ includes.
1317         * nat/mips-linux-watch.h: Fix common/ includes.
1318         * nat/mips-linux-watch.c: Fix common/ includes.
1319         * nat/linux-waitpid.c: Fix common/ includes.
1320         * nat/linux-ptrace.h: Fix common/ includes.
1321         * nat/linux-ptrace.c: Fix common/ includes.
1322         * nat/linux-procfs.c: Fix common/ includes.
1323         * nat/linux-personality.c: Fix common/ includes.
1324         * nat/linux-osdata.c: Fix common/ includes.
1325         * nat/linux-namespaces.c: Fix common/ includes.
1326         * nat/linux-btrace.h: Fix common/ includes.
1327         * nat/linux-btrace.c: Fix common/ includes.
1328         * nat/fork-inferior.c: Fix common/ includes.
1329         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1330         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1331         * nat/aarch64-linux.c: Fix common/ includes.
1332         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1333         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1334         * namespace.h: Fix common/ includes.
1335         * mips-linux-tdep.c: Fix common/ includes.
1336         * minsyms.c: Fix common/ includes.
1337         * mi/mi-parse.h: Fix common/ includes.
1338         * mi/mi-main.c: Fix common/ includes.
1339         * mi/mi-cmd-env.c: Fix common/ includes.
1340         * memrange.h: Fix common/ includes.
1341         * memattr.c: Fix common/ includes.
1342         * maint.h: Fix common/ includes.
1343         * maint.c: Fix common/ includes.
1344         * main.c: Fix common/ includes.
1345         * machoread.c: Fix common/ includes.
1346         * location.c: Fix common/ includes.
1347         * linux-thread-db.c: Fix common/ includes.
1348         * linux-nat.c: Fix common/ includes.
1349         * linux-fork.c: Fix common/ includes.
1350         * inline-frame.c: Fix common/ includes.
1351         * infrun.c: Fix common/ includes.
1352         * inflow.c: Fix common/ includes.
1353         * inferior.h: Fix common/ includes.
1354         * inferior.c: Fix common/ includes.
1355         * infcmd.c: Fix common/ includes.
1356         * inf-ptrace.c: Fix common/ includes.
1357         * inf-child.c: Fix common/ includes.
1358         * ia64-linux-nat.c: Fix common/ includes.
1359         * i387-tdep.c: Fix common/ includes.
1360         * i386-tdep.c: Fix common/ includes.
1361         * i386-linux-tdep.c: Fix common/ includes.
1362         * i386-linux-nat.c: Fix common/ includes.
1363         * i386-go32-tdep.c: Fix common/ includes.
1364         * i386-fbsd-tdep.c: Fix common/ includes.
1365         * i386-fbsd-nat.c: Fix common/ includes.
1366         * guile/scm-type.c: Fix common/ includes.
1367         * guile/guile.c: Fix common/ includes.
1368         * go32-nat.c: Fix common/ includes.
1369         * gnu-nat.c: Fix common/ includes.
1370         * gdbthread.h: Fix common/ includes.
1371         * gdbarch-selftests.c: Fix common/ includes.
1372         * gdb_usleep.c: Fix common/ includes.
1373         * gdb_select.h: Fix common/ includes.
1374         * gdb_bfd.c: Fix common/ includes.
1375         * gcore.c: Fix common/ includes.
1376         * fork-child.c: Fix common/ includes.
1377         * findvar.c: Fix common/ includes.
1378         * fbsd-nat.c: Fix common/ includes.
1379         * event-top.c: Fix common/ includes.
1380         * event-loop.c: Fix common/ includes.
1381         * dwarf2read.c: Fix common/ includes.
1382         * dwarf2loc.c: Fix common/ includes.
1383         * dwarf2-frame.c: Fix common/ includes.
1384         * dwarf-index-cache.c: Fix common/ includes.
1385         * dtrace-probe.c: Fix common/ includes.
1386         * disasm-selftests.c: Fix common/ includes.
1387         * defs.h: Fix common/ includes.
1388         * csky-tdep.c: Fix common/ includes.
1389         * cp-valprint.c: Fix common/ includes.
1390         * cp-support.h: Fix common/ includes.
1391         * cp-support.c: Fix common/ includes.
1392         * corelow.c: Fix common/ includes.
1393         * completer.h: Fix common/ includes.
1394         * completer.c: Fix common/ includes.
1395         * compile/compile.c: Fix common/ includes.
1396         * compile/compile-loc2c.c: Fix common/ includes.
1397         * compile/compile-cplus-types.c: Fix common/ includes.
1398         * compile/compile-cplus-symbols.c: Fix common/ includes.
1399         * command.h: Fix common/ includes.
1400         * cli/cli-dump.c: Fix common/ includes.
1401         * cli/cli-cmds.c: Fix common/ includes.
1402         * charset.c: Fix common/ includes.
1403         * build-id.c: Fix common/ includes.
1404         * btrace.h: Fix common/ includes.
1405         * btrace.c: Fix common/ includes.
1406         * breakpoint.h: Fix common/ includes.
1407         * breakpoint.c: Fix common/ includes.
1408         * ax.h: 
1409         (enum agent_op): Fix common/ includes.
1410         * ax-general.c (struct aop_map): Fix common/ includes.
1411         * ax-gdb.c: Fix common/ includes.
1412         * auxv.c: Fix common/ includes.
1413         * auto-load.c: Fix common/ includes.
1414         * arm-tdep.c: Fix common/ includes.
1415         * arch/riscv.c: Fix common/ includes.
1416         * arch/ppc-linux-common.c: Fix common/ includes.
1417         * arch/i386.c: Fix common/ includes.
1418         * arch/arm.c: Fix common/ includes.
1419         * arch/arm-linux.c: Fix common/ includes.
1420         * arch/arm-get-next-pcs.c: Fix common/ includes.
1421         * arch/amd64.c: Fix common/ includes.
1422         * arch/aarch64.c: Fix common/ includes.
1423         * arch/aarch64-insn.c: Fix common/ includes.
1424         * arch-utils.c: Fix common/ includes.
1425         * amd64-windows-tdep.c: Fix common/ includes.
1426         * amd64-tdep.c: Fix common/ includes.
1427         * amd64-sol2-tdep.c: Fix common/ includes.
1428         * amd64-obsd-tdep.c: Fix common/ includes.
1429         * amd64-nbsd-tdep.c: Fix common/ includes.
1430         * amd64-linux-tdep.c: Fix common/ includes.
1431         * amd64-linux-nat.c: Fix common/ includes.
1432         * amd64-fbsd-tdep.c: Fix common/ includes.
1433         * amd64-fbsd-nat.c: Fix common/ includes.
1434         * amd64-dicos-tdep.c: Fix common/ includes.
1435         * amd64-darwin-tdep.c: Fix common/ includes.
1436         * agent.c: Fix common/ includes.
1437         * ada-lang.h: Fix common/ includes.
1438         * ada-lang.c: Fix common/ includes.
1439         * aarch64-tdep.c: Fix common/ includes.
1440
1441 2019-01-25  Tom Tromey  <tom@tromey.com>
1442
1443         * common/create-version.sh: Use common/version.h.
1444
1445 2019-01-24  Pedro Alves  <palves@redhat.com>
1446
1447         * infrun.c (signal_stop, signal_print, signal_program)
1448         (signal_catch, signal_pass): Now arrays instead of pointers.
1449         (update_signals_program_target, do_target_resume)
1450         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1451         * linux-nat.c (linux_nat_target::pass_signals)
1452         (linux_nat_target::create_inferior, linux_nat_target::attach):
1453         Adjust.
1454         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1455         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1456         * procfs.c (procfs_target::pass_signals): Adjust.
1457         * record-full.c (record_full_target::resume): Adjust.
1458         * remote.c (remote_target::pass_signals)
1459         (remote_target::program_signals): Adjust.
1460         * target-debug.h (target_debug_print_signals): Now takes a
1461         gdb::array_view as parameter.  Adjust.
1462         * target.h (target_ops) <pass_signals, program_signals>: Replace
1463         pointer and length parameters with gdb::array_view.
1464         (target_pass_signals, target_program_signals): Likewise.
1465         * target-delegates.c: Regenerate.
1466
1467 2019-01-24  Pedro Alves  <palves@redhat.com>
1468
1469         * common/forward-scope-exit.h
1470         (forward_scope_exit::forward_scope_exit): Pass arguments to
1471         m_bind_function directly, instead of creating a std::bind and
1472         copying that.
1473
1474 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1475
1476         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1477         for static members.
1478         (pass_in_v_vfp_candidate): Likewise.
1479
1480 2019-01-23  Tom Tromey  <tom@tromey.com>
1481             Pedro Alves  <palves@redhat.com>
1482
1483         * regcache.c (class regcache_invalidator): Remove.
1484         (regcache::raw_write): Use make_scope_exit.
1485
1486 2019-01-23  Tom Tromey  <tom@tromey.com>
1487
1488         * ui-out.h (class ui_out_emit_type): Update comment.
1489
1490 2019-01-23  Tom Tromey  <tom@tromey.com>
1491
1492         * infrun.c (fetch_inferior_event): Update comment.
1493
1494 2019-01-23  Tom Tromey  <tom@tromey.com>
1495             Pedro Alves  <palves@redhat.com>
1496
1497         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1498         parameter.
1499         (fetch_inferior_event): Use SCOPE_EXIT.
1500
1501
1502 2019-01-23  Tom Tromey  <tom@tromey.com>
1503             Pedro Alves  <palves@redhat.com>
1504
1505         * infrun.c (disable_thread_events): Delete.
1506         (stop_all_threads): Use SCOPE_EXIT.
1507
1508 2019-01-23  Tom Tromey  <tom@tromey.com>
1509             Pedro Alves  <palves@redhat.com>
1510
1511         * symfile.c: Include forward-scope-exit.h.
1512         (clear_symtab_users_cleanup): Replace forward declaration with
1513         a FORWARD_SCOPE_EXIT.
1514         (syms_from_objfile_1): Use the forward_scope_exit and
1515         gdb::optional instead of cleanup_function.
1516         (reread_symbols): Use the forward_scope_exit instead of
1517         cleanup_function.
1518         (clear_symtab_users_cleanup): Remove function.
1519
1520 2019-01-23  Tom Tromey  <tom@tromey.com>
1521             Pedro Alves  <palves@redhat.com>
1522
1523         * linux-nat.c: Include scope-exit.h.
1524         (cleanup_target_stop): Remove.
1525         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1526         SCOPE_EXIT.
1527
1528 2019-01-23  Tom Tromey  <tom@tromey.com>
1529             Pedro Alves  <palves@redhat.com>
1530
1531         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1532         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1533
1534 2019-01-23  Tom Tromey  <tom@tromey.com>
1535             Andrew Burgess  <andrew.burgess@embecosm.com>
1536             Pedro Alves  <palves@redhat.com>
1537
1538         * infrun.c (fetch_inferior_event): Use scope_exit.
1539         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1540         * top.c (execute_command): Use scope_exit.
1541         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1542         * utils.c (do_bpstat_clear_actions_cleanup)
1543         (make_bpstat_clear_actions_cleanup): Remove.
1544
1545 2019-01-23  Tom Tromey  <tom@tromey.com>
1546             Pedro Alves  <palves@redhat.com>
1547
1548         * infrun.c: Include "common/scope-exit.h"
1549         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1550         (wait_for_inferior): Use SCOPE_EXIT.
1551         (fetch_inferior_event): Use scope_exit.
1552
1553 2019-01-23  Tom Tromey  <tom@tromey.com>
1554             Pedro Alves  <palves@redhat.com>
1555
1556         * breakpoint.c (create_breakpoint): Remove cleanup.
1557
1558 2019-01-23  Tom Tromey  <tom@tromey.com>
1559             Andrew Burgess  <andrew.burgess@embecosm.com>
1560             Pedro Alves  <palves@redhat.com>
1561
1562 2019-01-23  Pedro Alves  <palves@redhat.com>
1563
1564         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1565
1566 2019-01-23  Pedro Alves  <palves@redhat.com>
1567             Andrew Burgess  <andrew.burgess@embecosm.com>
1568
1569         * gdbthread.h: Include "common/forward-scope-exit.h".
1570         (scoped_finish_thread_state): Redefine custom class in terms of
1571         forward_scope_exit.
1572
1573 2019-01-23  Pedro Alves  <palves@redhat.com>
1574             Andrew Burgess  <andrew.burgess@embecosm.com>
1575
1576         * common/forward-scope-exit.h: New file.
1577
1578 2019-01-23  Pedro Alves  <palves@redhat.com>
1579             Andrew Burgess  <andrew.burgess@embecosm.com>
1580             Tom Tromey  <tom@tromey.com>
1581
1582         * common/scope-exit.h: New file.
1583
1584 2019-01-23  Pedro Alves  <palves@redhat.com>
1585
1586         * common/preprocessor.h (ESC): Rename to ...
1587         (ESC_PARENS): ... this.
1588         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1589         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1590
1591 2019-01-23  Tom Tromey  <tom@tromey.com>
1592
1593         * language.h (class scoped_switch_to_sym_language_if_auto):
1594         Initialize m_lang in both cases.
1595
1596 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1597
1598         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1599         with XCNEW.
1600
1601 2019-01-22  Tom Tromey  <tom@tromey.com>
1602
1603         * corelow.c: Do not include sys/file.h.
1604
1605 2019-01-22  Tom Tromey  <tom@tromey.com>
1606
1607         * tui/tui-wingeneral.h: Include gdb_curses.h.
1608
1609 2019-01-22  Tom Tromey  <tom@tromey.com>
1610
1611         * source-cache.h (class source_cache) <get_source_lines,
1612         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1613
1614 2019-01-22  Tom Tromey  <tom@tromey.com>
1615
1616         * remote-fileio.h (struct remote_target): Declare.
1617
1618 2019-01-22  Tom Tromey  <tom@tromey.com>
1619
1620         * python/py-arch.c: Do not include py-ref.h.
1621         * python/py-bpevent.c: Do not include py-ref.h.
1622         * python/py-cmd.c: Do not include py-ref.h.
1623         * python/py-continueevent.c: Do not include py-ref.h.
1624         * python/py-event.h: Do not include py-ref.h.
1625         * python/py-evtregistry.c: Do not include py-ref.h.
1626         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1627         * python/py-frame.c: Do not include py-ref.h.
1628         * python/py-framefilter.c: Do not include py-ref.h.
1629         * python/py-function.c: Do not include py-ref.h.
1630         * python/py-infevents.c: Do not include py-ref.h.
1631         * python/py-linetable.c: Do not include py-ref.h.
1632         * python/py-objfile.c: Do not include py-ref.h.
1633         * python/py-param.c: Do not include py-ref.h.
1634         * python/py-prettyprint.c: Do not include py-ref.h.
1635         * python/py-progspace.c: Do not include py-ref.h.
1636         * python/py-symbol.c: Do not include py-ref.h.
1637         * python/py-symtab.c: Do not include py-ref.h.
1638         * python/py-type.c: Do not include py-ref.h.
1639         * python/py-unwind.c: Do not include py-ref.h.
1640         * python/py-utils.c: Do not include py-ref.h.
1641         * python/py-value.c: Do not include py-ref.h.
1642         * python/py-varobj.c: Do not include py-ref.h.
1643         * python/py-xmethods.c: Do not include py-ref.h.
1644         * python/python.c: Do not include py-ref.h.
1645         * varobj.c: Do not include py-ref.h.
1646
1647 2019-01-22  Tom Tromey  <tom@tromey.com>
1648
1649         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1650         keyword for bcache.
1651
1652 2019-01-22  Tom Tromey  <tom@tromey.com>
1653
1654         * compile/compile-cplus-types.c: Remove a comment by #include.
1655
1656 2019-01-22  Tom Tromey  <tom@tromey.com>
1657
1658         * compile/gcc-c-plugin.h: Include compile-internal.h.
1659
1660 2019-01-22  Tom Tromey  <tom@tromey.com>
1661
1662         * stabsread.c (EXTERN): Do not define.
1663         (symnum, next_symbol_text_func, processing_gcc_compilation)
1664         (within_function, global_sym_chain, global_stabs)
1665         (previous_stab_code, this_object_header_files)
1666         (n_this_object_header_files)
1667         (n_allocated_this_object_header_files): Define.
1668         * stabsread.h (EXTERN): Never define.  Use "extern".
1669
1670 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1671
1672         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1673         history_value.
1674
1675 2019-01-21  Tom Tromey  <tom@tromey.com>
1676
1677         * ui-out.c: Fix includes.
1678         * tui/tui-source.c: Fix includes.
1679         * target.c: Fix includes.
1680         * remote.c: Fix includes.
1681         * regcache.c: Fix includes.
1682         * python/py-block.c: Fix includes.
1683         * printcmd.c: Fix includes.
1684         * or1k-tdep.c: Fix includes.
1685         * mi/mi-main.c: Fix includes.
1686         * m32r-tdep.c: Fix includes.
1687         * csky-tdep.c: Fix includes.
1688         * compile/compile-cplus-types.c: Fix includes.
1689         * cli/cli-interp.c: Fix includes.
1690
1691 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1692
1693         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1694         for padding.
1695
1696 2019-01-16  Tom Tromey  <tom@tromey.com>
1697
1698         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1699         earlier.
1700         (struct objfile) <msymbols_range>: Move from top level.
1701         <msymbols>: New method.
1702         (class objfile_msymbols): Remove.
1703         * symtab.c (default_collect_symbol_completion_matches_break_on):
1704         Update.
1705         * symmisc.c (dump_msymbols): Update.
1706         * stabsread.c (scan_file_globals): Update.
1707         * objc-lang.c (info_selectors_command, info_classes_command)
1708         (find_methods): Update.
1709         * minsyms.c (find_solib_trampoline_target): Update.
1710         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1711         * coffread.c (coff_symfile_read): Update.
1712         * ada-lang.c (ada_lookup_simple_minsym)
1713         (ada_collect_symbol_completion_matches): Update.
1714
1715 2019-01-16  Tom Tromey  <tom@tromey.com>
1716
1717         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1718         type.  Remove no-argument constructor.
1719         <iterator::operator++>: Simplify.
1720         <begin>: Update.
1721         <end>: Use minimal_symbol_count.
1722
1723 2019-01-16  Tom Tromey  <tom@tromey.com>
1724
1725         * objfiles.h (struct objfile) <psymtabs>: New method.
1726         (class objfile_psymtabs): Remove.
1727         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1728         typedef.
1729         <range>: New method.
1730         (require_partial_symbols): Change return type.
1731         * psymtab.c (require_partial_symbols)
1732         (psym_expand_symtabs_matching): Update.
1733         * mdebugread.c (parse_partial_symbols): Update.
1734         * dbxread.c (dbx_end_psymtab): Update.
1735
1736 2019-01-15  Tom Tromey  <tom@tromey.com>
1737
1738         * symtab.c (lookup_objfile_from_block)
1739         (lookup_symbol_in_objfile_symtabs)
1740         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1741         (find_line_symtab, info_sources_command)
1742         (default_collect_symbol_completion_matches_break_on)
1743         (make_source_files_completion_list): Update.
1744         * symmisc.c (print_objfile_statistics, dump_objfile)
1745         (maintenance_print_symbols, maintenance_info_symtabs)
1746         (maintenance_check_symtabs, maintenance_info_line_tables):
1747         Update.
1748         * source.c (select_source_symtab)
1749         (forget_cached_source_info_for_objfile): Update.
1750         * objfiles.h (class objfile_compunits): Remove.
1751         (struct objfile) <compunits_range>: New typedef.
1752         (compunits): New method.
1753         * objfiles.c (objfile_relocate1): Update.
1754         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1755         * maint.c (count_symtabs_and_blocks): Update.
1756         * linespec.c (iterate_over_all_matching_symtabs): Update.
1757         * cp-support.c (add_symbol_overload_list_qualified): Update.
1758         * coffread.c (coff_symtab_read): Update.
1759         * ada-lang.c (add_nonlocal_symbols)
1760         (ada_collect_symbol_completion_matches)
1761         (ada_add_global_exceptions): Update.
1762
1763 2019-01-15  Tom Tromey  <tom@tromey.com>
1764
1765         * progspace.h (program_space) <objfiles_safe_range>: New
1766         typedef.
1767         <objfiles_safe>: New method.
1768         * objfiles.h (class all_objfiles_safe): Remove.
1769         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1770         * jit.c (jit_inferior_exit_hook): Update.
1771
1772 2019-01-17  Tom Tromey  <tom@tromey.com>
1773
1774         * progspace.h (program_space) <objfiles_range>: New typedef.
1775         <objfiles>: New method.
1776         <objfiles_head>: Rename from objfiles.
1777         (object_files): Update.
1778         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1779         * guile/scm-pretty-print.c
1780         (ppscm_find_pretty_printer_from_objfiles): Update.
1781         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1782         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1783         Update.
1784         * python/py-progspace.c (pspy_get_objfiles): Update.
1785         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1786         Update.
1787         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1788         (objfpy_lookup_objfile_by_build_id): Update.
1789         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1790         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1791         Update.
1792         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1793         (expand_symtab_containing_pc, lookup_objfile_from_block)
1794         (lookup_static_symbol, basic_lookup_transparent_type)
1795         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1796         (find_line_symtab, info_sources_command)
1797         (default_collect_symbol_completion_matches_break_on)
1798         (make_source_files_completion_list, find_main_name): Update.
1799         * symmisc.c (print_symbol_bcache_statistics)
1800         (print_objfile_statistics, maintenance_print_symbols)
1801         (maintenance_print_msymbols, maintenance_print_objfiles)
1802         (maintenance_info_symtabs, maintenance_check_symtabs)
1803         (maintenance_expand_symtabs, maintenance_info_line_tables):
1804         Update.
1805         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1806         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1807         (map_overlay_command, unmap_overlay_command)
1808         (simple_overlay_update, expand_symtabs_matching)
1809         (map_symbol_filenames): Update.
1810         * symfile-debug.c (set_debug_symfile): Update.
1811         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1812         Update.
1813         * source.c (select_source_symtab, forget_cached_source_info):
1814         Update.
1815         * solib.c (solib_read_symbols): Update.
1816         * solib-spu.c (append_ocl_sos): Update.
1817         * psymtab.c (maintenance_print_psymbols)
1818         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1819         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1820         * printcmd.c (info_symbol_command): Update.
1821         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1822         Update.
1823         * objfiles.h (class all_objfiles): Remove.
1824         * objfiles.c (have_partial_symbols, have_full_symbols)
1825         (have_minimal_symbols, qsort_cmp, update_section_map)
1826         (shared_objfile_contains_address_p)
1827         (default_iterate_over_objfiles_in_search_order): Update.
1828         * objc-lang.c (info_selectors_command, info_classes_command)
1829         (find_methods): Update.
1830         * minsyms.c (find_solib_trampoline_target): Update.
1831         * maint.c (maintenance_info_sections)
1832         (maintenance_translate_address, count_symtabs_and_blocks):
1833         Update.
1834         * main.c (captured_main_1): Update.
1835         * linux-thread-db.c (try_thread_db_load_from_pdir)
1836         (has_libpthread): Update.
1837         * linespec.c (iterate_over_all_matching_symtabs)
1838         (search_minsyms_for_name): Update.
1839         * jit.c (jit_find_objf_with_entry_addr): Update.
1840         * hppa-tdep.c (find_unwind_entry)
1841         (hppa_lookup_stub_minimal_symbol): Update.
1842         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1843         Update.
1844         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1845         (elf_gnu_ifunc_resolve_by_got): Update.
1846         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1847         * dwarf-index-write.c (save_gdb_index_command): Update.
1848         * cp-support.c (add_symbol_overload_list_qualified): Update.
1849         * breakpoint.c (create_overlay_event_breakpoint)
1850         (create_longjmp_master_breakpoint)
1851         (create_std_terminate_master_breakpoint)
1852         (create_exception_master_breakpoint): Update.
1853         * blockframe.c (find_pc_partial_function): Update.
1854         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1855         (ada_collect_symbol_completion_matches)
1856         (ada_add_global_exceptions): Update.
1857
1858 2019-01-17  Tom Tromey  <tom@tromey.com>
1859
1860         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1861         declare VEC.
1862         (solib_target_parse_libraries): Change return type.
1863         (library_list_start_segment, library_list_start_section)
1864         (library_list_end_library, library_list_start_library); Update.
1865         (solib_target_free_library_list): Remove.
1866         (solib_target_parse_libraries): Remove cleanup.  Change return
1867         type.
1868         (solib_target_current_sos): Update.
1869
1870 2019-01-17  Tom Tromey  <tromey@bapiya>
1871
1872         * valprint.c: Replace "the the" with "the".
1873         * symtab.c: Replace "the the" with "the".
1874         * solib.c: Replace "the the" with "the".
1875         * solib-dsbt.c: Replace "the the" with "the".
1876         * linespec.c: Replace "the the" with "the".
1877         * dwarf2loc.h: Replace "the the" with "the".
1878         * amd64-windows-tdep.c: Replace "the the" with "the".
1879         * aarch64-tdep.c: Replace "the the" with "the".
1880
1881 2019-01-16  Keith Seitz  <keiths@redhat.com>
1882
1883         PR gdb/23773
1884         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1885         <builder>: Rename to ..
1886         <m_builder>: ... this and make private.
1887         (dwarf2_cu::get_builder): New method.  Change all users of
1888         `builder' to use this method.
1889         (dwarf2_start_symtab): Move to ...
1890         (dwarf2_cu::start_symtab): ... here.  Update all callers
1891         (setup_type_unit_groups): Move to ...
1892         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1893         callers.
1894         (dwarf2_cu::reset_builder): New method.
1895         (process_full_compunit, process_full_type_unit): Use
1896         dwarf2_cu::reset_builder.
1897         (follow_die_offset): Record the ancestor CU if it is different
1898         from the followed DIE's CU.
1899         (follow_die_sig_1): Likewise.
1900
1901 2019-01-15  Tom Tromey  <tom@tromey.com>
1902
1903         * remote.c (class remote_state) <buf>: Now a char_vector.
1904         <buf_size>: Remove.
1905         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1906         parameter.
1907         (remote_target::getpkt_or_notif_sane_1)
1908         (remote_target::getpkt_sane)
1909         (remote_target::getpkt_or_notif_sane): Likewise.
1910         (class remote_target) <putpkt>: New overload.
1911         (remote_target::read_frame): Change type of "buf_p".  Remove
1912         sizeof_p parameter.
1913         (packet_ok): New overload.
1914         (packet_check_result): New overload.
1915         Update all uses.
1916
1917 2019-01-14  Tom Tromey  <tom@tromey.com>
1918
1919         * remote-notif.c (handle_notification, remote_notif_ack)
1920         (remote_notif_parse): Make "buf" const.
1921         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1922         const.
1923         (remote_notif_parse, remote_notif_ack, handle_notification):
1924         Likewise.
1925         * remote.c (remote_notif_stop_parse): Make "buf" const.
1926         (remote_target::remote_parse_stop_reply): Make "buf" const.
1927         (remote_notif_stop_ack): Make "buf" const.
1928
1929 2019-01-14  Tom Tromey  <tom@tromey.com>
1930
1931         * remote.c (remote_console_output): Make parameter const.
1932
1933 2019-01-14  Tom Tromey  <tom@tromey.com>
1934
1935         * target-debug.h (target_debug_print_signals): Constify.
1936         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1937         * procfs.c (procfs_target::pass_signals): Update.
1938         * linux-nat.c (linux_nat_target::pass_signals): Update.
1939         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1940         * target-delegates.c: Rebuild.
1941         * remote.c (remote_target::program_signals): Update.
1942         (remote_target::pass_signals): Update.
1943         * target.c (target_pass_signals): Constify argument.
1944         (target_program_signals): Likewise.
1945         * target.h (struct target_ops) <pass_signals, program_signals>:
1946         Constify argument.
1947         (target_pass_signals, target_program_signals): Constify argument.
1948
1949 2019-01-14  Tom Tromey  <tom@tromey.com>
1950
1951         PR tui/28819:
1952         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1953
1954 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1955
1956         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1957         field.
1958         * rs6000-tdep.c: Include reggroups.h.
1959         (IS_V_ALIAS_PSEUDOREG): Define.
1960         (rs6000_register_name): Return names for the "vX" aliases.
1961         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1962         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1963         aliases.  Call default_register_reggroup_p for all other
1964         pseudo-registers.
1965         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1966         New functions.
1967         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1968         Handle "vX" aliases.
1969         (v_alias_pseudo_register_collect): New function.
1970         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1971         (rs6000_gdbarch_init): Initialize "vX" aliases as
1972         pseudo-registers.  Restore registration of
1973         rs6000_pseudo_register_reggroup_p with
1974         set_tdesc_pseudo_register_reggroup_p.
1975
1976 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1977
1978         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1979         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1980         set_gdbarch_num_pseudo_regs.
1981
1982 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1983
1984         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1985         Remove arg prefixname, add do_set and do_show.
1986         Add member functions set_list and show_list.
1987         * cli/cli-style.c (class cli_style_option): Update accordingly.
1988         (style_set_list): Move to file scope.
1989         (style_show_list): Likewise.
1990         (set_style): Call help_list.
1991         (show_style): Call cmd_show_list.
1992         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1993         Update to use the new macro.
1994
1995 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1996
1997         * ada-lang.c (_initialize_ada_language): Expand the help text
1998         for the "catch exception" command.
1999
2000 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2001
2002         * symtab.c (matching_obj_sections): Initialize obj,
2003         declare it closer to its usage.
2004
2005 2019-01-10  Tom Tromey  <tom@tromey.com>
2006
2007         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2008         (basic_inf_threads_range): Remove.
2009         (inf_threads_range, inf_non_exited_threads_range)
2010         (safe_inf_threads_range): Use next_adapter.
2011
2012 2019-01-10  Keith Seitz  <keiths@redhat.com>
2013
2014         PR gdb/23712
2015         PR symtab/23010
2016         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2017         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2018
2019 2019-01-10  Keith Seitz  <keiths@redhat.com>
2020
2021         PR gdb/23712
2022         PR symtab/23010
2023         * dictionary.c (pending_to_vector): Remove.
2024         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2025         Remove _1 suffix, replacing functions of the same name.  Update
2026         all callers.
2027         (dict_create_hashed, dict_create_hashed_expandable)
2028         (dict_create_linear, dict_create_linear_expandable, dict_free)
2029         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2030         Make functions static.
2031
2032 2019-01-10  Keith Seitz  <keiths@redhat.com>
2033
2034         PR gdb/23712
2035         PR symtab/23010
2036         * dictionary.h (struct dictionary): Replace declaration with
2037         multidictionary.
2038         (dict_create_hashed, dict_create_hashed_expandable)
2039         (dict_create_linear, dict_create_linear_expandable)
2040         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2041         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2042         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2043         taking multidictionary argument.
2044         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2045         * block.h (struct block) <dict>: Change to multidictionary
2046         and rename `multidict'.
2047         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2048         symmisc.c: Update all dictionary references to multidictionary.
2049
2050 2019-01-10  Keith Seitz  <keiths@redhat.com>
2051
2052         PR gdb/23712
2053         PR symtab/23010
2054         * dictionary.c: Include unordered_map.
2055         (pending_to_vector): New function.
2056         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2057         Rewrite the non-"_1" functions to take vector instead
2058         of linked list.
2059         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2060         "new" _1 versions of the same name.
2061         (multidictionary): Define.
2062         (std::hash<enum language): New definition.
2063         (collate_pending_symbols_by_language, mdict_create_hashed)
2064         (mdict_create_hashed_expandable, mdict_create_linear)
2065         (mdict_create_linear_expandable, mdict_free)
2066         (find_language_dictionary, create_new_language_dictionary)
2067         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2068         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2069         (mdict_size, mdict_empty): New functions.
2070         * dictionary.h (mdict_iterator): Define.
2071
2072 2019-01-10  Pedro Alves  <palves@redhat.com>
2073
2074         * breakpoint.c (read_uploaded_action)
2075         (create_tracepoint_from_upload): Adjust to use
2076         gdb::unique_xmalloc_ptr.
2077         * ctf.c (ctf_write_uploaded_tp):
2078         (SET_ARRAY_FIELD): Use emplace_back.
2079         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2080         * tracefile-tfile.c (tfile_write_uploaded_tp):
2081         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2082         gdb::unique_xmalloc_ptr.
2083         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2084         at_string, cond_string, cmd_strings>: Replace char pointers
2085         with gdb::unique_xmalloc_ptr.
2086
2087 2019-01-10  Pedro Alves  <palves@redhat.com>
2088
2089         * solib-target.c (library_list_start_library): Don't xstrdup name.
2090
2091 2019-01-10  Pedro Alves  <palves@redhat.com>
2092
2093         * mdebugread.c (parse_partial_symbols): Use
2094         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2095
2096 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2097
2098         * linux-fork.c (scoped_switch_fork_info)
2099         <~scoped_switch_fork_info>: Fix incorrect variable name.
2100
2101 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2102
2103         * linux-fork.c (scoped_switch_fork_info)
2104         <scoped_switch_fork_info>: Make explicit.
2105         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2106
2107 2019-01-10  Tom Tromey  <tom@tromey.com>
2108
2109         * objfiles.h (objfile::reset_psymtabs): Update.
2110         * objfiles.c (objfile::objfile): Update.
2111         * psymtab.h (psymtab_storage::obstack): Update.
2112         (psymtab_storage::m_obstack): Use gdb::optional.
2113         (class psymtab_storage): Update comment.  Remove objfile
2114         parameter.
2115         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2116
2117 2019-01-10  Tom Tromey  <tom@tromey.com>
2118
2119         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2120         <free_psymtabs>: Now private.
2121         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2122         (allocate_psymtab): Use new method.
2123
2124 2019-01-10  Tom Tromey  <tom@tromey.com>
2125
2126         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2127         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2128         * mdebugread.c (parse_partial_symbols): Use
2129         allocate_dependencies.
2130         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2131         allocate_dependencies.
2132         (process_psymtab_comp_unit_reader)
2133         (build_type_psymtab_dependencies): Likewise.
2134         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2135
2136 2019-01-10  Tom Tromey  <tom@tromey.com>
2137
2138         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2139         PSYMBOL_SET_LANGUAGE.
2140         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2141
2142 2019-01-10  Tom Tromey  <tom@tromey.com>
2143
2144         * psymtab.h (psymtab_storage::obstack): New method.
2145         <m_obstack>: Rename from obstack; now private.
2146         * psymtab.c (psymtab_storage): Update.
2147         * dwarf2read.c (create_addrmap_from_index)
2148         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2149         Update.
2150
2151 2019-01-10  Tom Tromey  <tom@tromey.com>
2152
2153         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2154         * objfiles.h (objfile::reset_psymtabs): New method.
2155
2156 2019-01-10  Tom Tromey  <tom@tromey.com>
2157
2158         * symmisc.c (print_symbol_bcache_statistics): Update.
2159         (print_objfile_statistics): Update.
2160         * symfile.c (reread_symbols): Update.
2161         * psymtab.h (class psymtab_storage): New.
2162         * psymtab.c (psymtab_storage): New constructor.
2163         (~psymtab_storage): New destructor.
2164         (require_partial_symbols): Update.
2165         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2166         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2167         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2168         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2169         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2170         (start_psymtab_common, end_psymtab_common)
2171         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2172         (allocate_psymtab): Update.
2173         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2174         Update.
2175         (dump_psymtab_addrmap, maintenance_print_psymbols)
2176         (maintenance_check_psymtabs): Update.
2177         (class objfile_psymtabs): Move to objfiles.h.
2178         * psympriv.h (discard_psymtab): Now inline.
2179         (psymtab_discarder::psymtab_discarder): Update.
2180         (psymtab_discarder::~psymtab_discarder): Update.
2181         (ALL_OBJFILE_PSYMTABS): Rewrite.
2182         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2183         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2184         Remove fields.
2185         <partial_symtabs>: New field.
2186         (class objfile_psymtabs): Move from psymtab.h.  Update.
2187         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2188         psymbol_cache.
2189         (objfile::~objfile): Don't destroy psymbol_cache.
2190         * mdebugread.c (parse_partial_symbols): Update.
2191         * dwarf2read.c (create_addrmap_from_index)
2192         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2193         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2194         (add_partial_subprogram, dwarf2_ranges_read): Update.
2195         * dwarf-index-write.c (write_address_map)
2196         (write_one_signatured_type, recursively_write_psymbols)
2197         (class debug_names, class debug_names, write_psymtabs_to_index):
2198         Update.
2199
2200 2019-01-10  Tom Tromey  <tom@tromey.com>
2201
2202         * symtab.h (SYMBOL_SET_NAMES): Update.
2203         (symbol_set_names): Update.
2204         (MSYMBOL_SET_NAMES): Update.
2205         * symtab.c (symbol_set_names): Change argument to be an
2206         objfile_per_bfd_storage.
2207         * psymtab.c (add_psymbol_to_bcache): Update.
2208         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2209
2210 2019-01-10  Tom Tromey  <tom@tromey.com>
2211
2212         * symtab.c (create_demangled_names_hash): Change argument to be an
2213         objfile_per_bfd_storage.
2214         (symbol_set_names): Update.
2215
2216 2019-01-10  Tom Tromey  <tom@tromey.com>
2217
2218         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2219         init_psymbol_list.
2220         * psymtab.c (init_psymbol_list): Do nothing if already called.
2221         * psympriv.h (init_psymbol_list): Add comment.
2222         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2223         init_psymbol_list.
2224         * dbxread.c (dbx_symfile_read): Unconditionally call
2225         init_psymbol_list.
2226
2227 2019-01-10  Tom Tromey  <tom@tromey.com>
2228
2229         * xcoffread.c (scan_xcoff_symtab): Update.
2230         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2231         "where".
2232         * mdebugread.c (parse_partial_symbols)
2233         (handle_psymbol_enumerators): Update.
2234         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2235         * dbxread.c (read_dbx_symtab): Update.
2236         * psympriv.h (psymbol_placement): New enum.
2237         (add_psymbol_to_list): Update.
2238
2239 2019-01-10  Tom Tromey  <tom@tromey.com>
2240
2241         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2242         static_psymbols parameters.
2243         (scan_xcoff_symtab): Update.
2244         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2245         static_psymbols parameters.
2246         * psympriv.h (start_psymtab_common): Update.
2247         * mdebugread.c (parse_partial_symbols): Update.
2248         * dwarf2read.c (create_partial_symtab): Update.
2249         * dbxread.c (read_dbx_symtab): Update.
2250         (start_psymtab): Remove global_psymbols and static_psymbols
2251         parameters.
2252
2253 2019-01-10  Tom Tromey  <tom@tromey.com>
2254
2255         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2256         * psymtab.c (allocate_psymtab): Add comment.
2257         * psympriv.h (allocate_psymtab): Add comment.
2258         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2259         initializations.
2260         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2261
2262 2019-01-10  Tom Tromey  <tom@tromey.com>
2263
2264         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2265         Don't declare.
2266         * mipsread.c: Include mdebugread.h.
2267         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2268         Declare.
2269         * elfread.c: Include mdebugread.h.
2270
2271 2019-01-09  Tom Tromey  <tom@tromey.com>
2272
2273         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2274         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2275         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2276         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2277         (psym_lookup_symbol, psym_find_last_source_symtab)
2278         (psym_forget_cached_source_info, psym_print_stats)
2279         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2280         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2281         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2282         (psym_find_compunit_symtab_by_address)
2283         (maintenance_print_psymbols, maintenance_info_psymtabs)
2284         (maintenance_check_psymtabs): Use ranged for.
2285         * psymtab.h (class objfile_psymtabs): New.
2286         (require_partial_symbols): Return objfile_psymtabs.
2287         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2288
2289 2019-01-09  Tom Tromey  <tom@tromey.com>
2290
2291         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2292         (find_pc_mapped_section, list_overlays_command)
2293         (map_overlay_command, unmap_overlay_command)
2294         (simple_overlay_update): Use all_objfiles.
2295         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2296         * printcmd.c (info_symbol_command): Use all_objfiles.
2297         * objfiles.h (ALL_OBJSECTIONS): Remove.
2298         * maint.c (maintenance_translate_address): Use all_objfiles.
2299         * gcore.c (gcore_create_callback): Use all_objfiles.
2300         (objfile_find_memory_regions): Likewise.
2301
2302 2019-01-09  Tom Tromey  <tom@tromey.com>
2303
2304         * symtab.c (find_line_symtab, info_sources_command)
2305         (make_source_files_completion_list): Use objfile_compunits.
2306         * source.c (select_source_symtab): Use objfile_compunits.
2307         * objfiles.h (struct objfile): Update comment.
2308         (ALL_OBJFILES): Remove.
2309         (ALL_FILETABS): Remove.
2310         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2311         objfile_compunits.
2312
2313 2019-01-09  Tom Tromey  <tom@tromey.com>
2314
2315         * symmisc.c (print_objfile_statistics, dump_objfile)
2316         (maintenance_print_symbols): Use compunit_filetabs.
2317         * source.c (forget_cached_source_info_for_objfile): Use
2318         compunit_filetabs.
2319         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2320         (ALL_FILETABS): Use compunit_filetabs.
2321         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2322         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2323
2324 2019-01-09  Tom Tromey  <tom@tromey.com>
2325
2326         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2327         (compunit_filetabs): New.
2328         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2329         compunit_filetabs.
2330         (info_sources_command, make_source_files_completion_list): Remove
2331         declaration.
2332         * symmisc.c (print_objfile_statistics, dump_objfile)
2333         (maintenance_print_symbols): Remove declaration.
2334         (maintenance_info_symtabs): Use compunit_filetabs.
2335         (maintenance_info_line_tables): Likewise.
2336         * source.c (select_source_symtab): Change local variable name.
2337         (forget_cached_source_info_for_objfile): Remove declaration.
2338         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2339         * objfiles.c (objfile_relocate1): Remove declaration.
2340         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2341         declaration.
2342         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2343         * coffread.c (coff_symtab_read): Remove declaration.
2344         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2345         compunit_filetabs.
2346
2347 2019-01-09  Tom Tromey  <tom@tromey.com>
2348
2349         * symtab.c (lookup_objfile_from_block)
2350         (find_pc_sect_compunit_symtab, search_symbols)
2351         (default_collect_symbol_completion_matches_break_on): Use
2352         objfile_compunits.
2353         * objfiles.h (ALL_COMPUNITS): Remove.
2354         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2355         * cp-support.c (add_symbol_overload_list_qualified): Use
2356         objfile_compunits.
2357         * ada-lang.c (ada_collect_symbol_completion_matches)
2358         (ada_add_global_exceptions): Use objfile_compunits.
2359
2360 2019-01-09  Tom Tromey  <tom@tromey.com>
2361
2362         * source.c (select_source_symtab)
2363         (forget_cached_source_info_for_objfile): Remove declaration.
2364         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2365         declaration.
2366         * maint.c (count_symtabs_and_blocks): Remove declaration.
2367         * cp-support.c (add_symbol_overload_list_qualified): Remove
2368         declaration.
2369         * coffread.c (coff_symtab_read): Remove declaration.
2370         * symtab.c (lookup_symbol_in_objfile_symtabs)
2371         (basic_lookup_transparent_type_1): Use objfile_compunits.
2372         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2373         (info_sources_command, search_symbols)
2374         (default_collect_symbol_completion_matches_break_on)
2375         (make_source_files_completion_list): Remove declaration.
2376         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2377         (ada_collect_symbol_completion_matches)
2378         (ada_add_global_exceptions): Remove declaration.
2379         * linespec.c (iterate_over_all_matching_symtabs): Use
2380         objfile_compunits.
2381         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2382         (class objfile_compunits): New.
2383         (ALL_COMPUNITS): Use objfile_compunits.
2384         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2385         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2386         objfile_compunits.
2387         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2388
2389 2019-01-09  Tom Tromey  <tom@tromey.com>
2390
2391         * symtab.c (search_symbols)
2392         (default_collect_symbol_completion_matches_break_on): Use
2393         objfile_msymbols.
2394         * ada-lang.c (ada_lookup_simple_minsym)
2395         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2396         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2397         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2398         objfile_msymbols.
2399         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2400         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2401         * objc-lang.c (find_methods): Use objfile_msymbols.
2402         (info_selectors_command, info_classes_command): Likewise.
2403         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2404         * objfiles.h (class objfile_msymbols): New.
2405         (ALL_OBJFILE_MSYMBOLS): Remove.
2406         (ALL_MSYMBOLS): Remove.
2407
2408 2019-01-09  Tom Tromey  <tom@tromey.com>
2409
2410         * common/next-iterator.h (next_adapter): Add Iterator template
2411         parameter.
2412         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2413         (class all_objfiles_safe): New.
2414         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2415         * objfiles.c (put_objfile_before): Update comment.
2416         (add_separate_debug_objfile): Likewise.
2417         (free_all_objfiles): Use all_objfiles_safe.
2418         (objfile_purge_solibs): Likewise.
2419
2420 2019-01-09  Tom Tromey  <tom@tromey.com>
2421
2422         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2423         (expand_symtab_containing_pc, lookup_static_symbol)
2424         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2425         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2426         all_objfiles.
2427         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2428         * breakpoint.c (create_overlay_event_breakpoint)
2429         (create_longjmp_master_breakpoint)
2430         (create_std_terminate_master_breakpoint)
2431         (create_exception_master_breakpoint): Use all_objfiles.
2432         * linux-thread-db.c (try_thread_db_load_from_pdir)
2433         (has_libpthread): Use all_objfiles.
2434         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2435         * linespec.c (iterate_over_all_matching_symtabs)
2436         (search_minsyms_for_name): Use all_objfiles.
2437         * maint.c (maintenance_info_sections): Use all_objfiles.
2438         * main.c (captured_main_1): Use all_objfiles.
2439         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2440         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2441         * guile/scm-pretty-print.c
2442         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2443         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2444         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2445         (maintenance_print_msymbols): Use all_objfiles.
2446         * source.c (select_source_symtab): Use all_objfiles.
2447         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2448         * symfile.c (remove_symbol_file_command)
2449         (expand_symtabs_matching, map_symbol_filenames): Use
2450         all_objfiles.
2451         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2452         all_objfiles.
2453         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2454         * objc-lang.c (find_methods): Use all_objfiles.
2455         * objfiles.c (have_partial_symbols, have_full_symbols)
2456         (have_minimal_symbols, qsort_cmp)
2457         (default_iterate_over_objfiles_in_search_order): Use
2458         all_objfiles.
2459         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2460         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2461         (maintenance_check_psymtabs): Use all_objfiles.
2462         (ALL_PSYMTABS): Remove.
2463         * compile/compile-object-run.c (do_module_cleanup): Use
2464         all_objfiles.
2465         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2466         * cp-support.c (add_symbol_overload_list_qualified): Use
2467         all_objfiles.
2468         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2469         Use all_objfiles.
2470         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2471         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2472         all_objfiles.
2473         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2474         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2475         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2476         Uses all_objfiles.
2477         * solib.c (solib_read_symbols): Use all_objfiles
2478
2479 2019-01-09  Tom Tromey  <tom@tromey.com>
2480
2481         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2482         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2483         all_objfiles.
2484         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2485         * symmisc.c (print_symbol_bcache_statistics)
2486         (print_objfile_statistics, maintenance_print_objfiles)
2487         (maintenance_info_symtabs, maintenance_check_symtabs)
2488         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2489         all_objfiles.
2490         * source.c (forget_cached_source_info): Use all_objfiles.
2491         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2492         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2493         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2494         * objfiles.c (update_section_map): Use all_objfiles.
2495         (shared_objfile_contains_address_p): Likewise.
2496         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2497         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2498
2499 2019-01-09  Tom Tromey  <tom@tromey.com>
2500
2501         * common/next-iterator.h: New file.
2502         * objfiles.h (class all_objfiles): New.
2503         (struct objfile_iterator): New.
2504
2505 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2506
2507         * NEWS: Move the description of the changed "frame", "select-frame",
2508          and "info frame" commands to the Changed commands section.
2509
2510 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2511
2512         * gdbtypes.c (check_stub_method_group): Remove handling of old
2513         mangling schemes.
2514         * linespec.c (find_methods): Likewise.
2515         * stabsread.c (read_member_functions): Likewise.
2516         * valops.c (search_struct_method): Likewise.
2517         (value_struct_elt_for_reference): Likewise.
2518         * NEWS: Mention this change.
2519
2520 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2521
2522         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2523         print_source_lines.
2524         * source.c (print_source_lines_base): Update line number check.
2525         (print_source_lines): New function.
2526         (source_lines_range::source_lines_range): New function.
2527         * source.h (class source_lines_range): New class.
2528         (print_source_lines): New declaration.
2529
2530 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2531
2532         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2533
2534 2019-01-08  Tom Tromey  <tom@tromey.com>
2535             Simon Marchi  <simon.marchi@ericsson.com>
2536
2537         PR gdb/24060
2538         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2539         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2540         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2541         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2542         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2543         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2544
2545 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * source.c (select_source_symtab): Move header comment to
2548         declaration in source.h.
2549         (forget_cached_source_info_for_objfile): Likewise.
2550         (forget_cached_source_info): Likewise.
2551         (identify_source_line): Likewise.
2552         * source.h (identify_source_line): Move declaration from symtab.h
2553         and add comment from source.c
2554         (print_source_lines): Likewise.
2555         (forget_cached_source_info_for_objfile): Likewise.
2556         (forget_cached_source_info): Likewise.
2557         (select_source_symtab): Likewise.
2558         (enum print_source_lines_flag): Move definition from symtab.h.
2559         * symtab.h (identify_source_line): Move declaration to source.h.
2560         (print_source_lines): Likewise.
2561         (forget_cached_source_info_for_objfile): Likewise.
2562         (forget_cached_source_info): Likewise.
2563         (select_source_symtab): Likewise.
2564         (enum print_source_lines_flag): Move definition to source.h.
2565         * tui/tui-hooks.c: Add 'source.h' include.
2566
2567 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2568
2569         * source.c (print_source_lines_base): Handle requests to print
2570         reverse line number sequences, and guard against empty lines
2571         string.
2572
2573 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2574
2575         * source.c (print_source_lines_base): Fix skip of '\r' if next
2576         character is '\n'.
2577
2578 2019-01-06  Tom Tromey  <tom@tromey.com>
2579
2580         * c-exp.y (struct c_parse_state) <macro_original_text,
2581         expansion_obstack>: New member.
2582         (macro_original_text, expansion_obstack): Remove globals.
2583         (scan_macro_expansion, scanning_macro_expansion)
2584         (finished_macro_expansion): Update.
2585         (scan_macro_cleanup): Remove.
2586         (yylex, c_parse): Update.
2587
2588 2019-01-06  Tom Tromey  <tom@tromey.com>
2589
2590         * c-exp.y (struct c_parse_state) <strings>: New member.
2591         (operator_stoken): Update.
2592
2593 2019-01-06  Tom Tromey  <tom@tromey.com>
2594
2595         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2596         (union type_stack_elt) <typelist_val>: Now a pointer to
2597         std::vector.
2598         (type_stack_cleanup): Don't declare.
2599         (push_typelist): Update.
2600         * parse.c (pop_typelist): Return a std::vector.
2601         (push_typelist): Take a std::vector.
2602         (follow_types): Update.  Do not free args.
2603         (type_stack_cleanup): Remove.
2604         * c-exp.y (struct c_parse_state): New.
2605         (cpstate): New global.
2606         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2607         (nonempty_typelist): Update.
2608         (func_mod): Create a new vector.
2609         (c_parse): Create a c_parse_state.
2610         (check_parameter_typelist): Do not delete params.
2611         (function_method): Update.  Do not delete type_list.
2612
2613 2019-01-06  Tom Tromey  <tom@tromey.com>
2614
2615         PR gdb/28155:
2616         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2617         check_typedef.
2618         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2619         (print_return_value): Likewise.
2620
2621 2019-01-05  Tom Tromey  <tom@tromey.com>
2622
2623         * contrib/cleanup_check.py: Remove.
2624         * contrib/gcc-with-excheck: Remove.
2625         * contrib/exsummary.py: Remove.
2626         * contrib/excheck.py: Remove.
2627
2628 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2629
2630         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2631         NULL. Initialize tpprev to NULL instead of assigning it
2632         to NULL on the next statement.
2633         * windows-nat.c (windows_delete_thread): Remove check for
2634         main_thread_id before printing thread exit notifications.
2635         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2636         Remove thread ID check against main_thread_id.
2637         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2638         windows_delete_thread.
2639         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2640
2641 2019-01-04  Tom Tromey  <tom@tromey.com>
2642
2643         * compile/compile.c (_initialize_compile): Use upper case for
2644         metasyntactic variables.
2645         * symmisc.c (_initialize_symmisc): Use upper case for
2646         metasyntactic variables.
2647         * psymtab.c (_initialize_psymtab): Use upper case for
2648         metasyntactic variables.
2649         * demangle.c (demangle_command): Use upper case for metasyntactic
2650         variables.
2651         (_initialize_demangler): Likewise.
2652         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2653         variables.
2654
2655 2019-01-03  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2658
2659 2019-01-03  Tom Tromey  <tom@tromey.com>
2660
2661         * python/py-symtab.c (salpy_str): Update.
2662         (struct salpy_sal_object) <symtab>: Now a PyObject.
2663         (salpy_dealloc): Update.
2664         (del_objfile_sal): Use gdbpy_ref.
2665
2666 2019-01-03  Tom Tromey  <tom@tromey.com>
2667
2668         * python/py-type.c (convert_field): Use new_reference.  Return
2669         gdbpy_ref.
2670         (make_fielditem): Return gdbpy_ref.
2671         (typy_fields): Update.
2672         (typy_getitem): Update.
2673         (field_name): Return gdbpy_ref.  Use new_reference.
2674         (typy_iterator_iternext): Update.
2675
2676 2019-01-03  Tom Tromey  <tom@tromey.com>
2677
2678         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2679
2680 2019-01-03  Tom Tromey  <tom@tromey.com>
2681
2682         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2683         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2684         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2685         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2686         (pspy_set_type_printers): Likewise.
2687         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2688         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2689         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2690         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2691         (objfpy_set_type_printers): Likewise.
2692
2693 2019-01-03  Tom Tromey  <tom@tromey.com>
2694
2695         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2696         (gdbpy_print_stack): Use gdbpy_err_fetch.
2697         * python/python-internal.h (class gdbpy_err_fetch): New class.
2698         (class gdbpy_enter) <m_error_type, m_error_value,
2699         m_error_traceback>: Remove.
2700         <m_error>: New member.
2701         (gdbpy_exception_to_string): Don't declare.
2702         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2703         * python/py-value.c (convert_value_from_python): Use
2704         gdbpy_err_fetch.
2705         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2706         gdbpy_exception_to_string.
2707         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2708         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2709         gdbpy_err_fetch.
2710
2711 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2712
2713         * linux-nat.c (delete_lwp_cleanup): Delete.
2714         (struct lwp_deleter): New struct.
2715         (lwp_info_up): New typedef.
2716         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2717         lwp_info_up.
2718
2719 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2720
2721         * linux-fork.c (class scoped_switch_fork_info): New class.
2722         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2723
2724 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2725
2726         * valops.c (find_overload_match): Remove use of null_cleanup, and
2727         calls to do_cleanups.
2728
2729 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2730
2731         * compile/compile-cplus-types.c
2732         (compile_cplus_instance::decl_name): Handle changes to
2733         cp_func_name.
2734         * cp-support.c (cp_func_name): Update header comment, update
2735         return type.
2736         * cp-support.h (cp_func_name): Update return type in declaration.
2737         * valops.c (find_overload_match): Move temp_func local to top
2738         level of function and change its type.  Use temp_func to hold and
2739         delete temporary string obtained from cp_func_name.
2740
2741 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2742
2743         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2744         gdb::char_vector, remove cleanup, and update uses of `msg`.
2745
2746 2019-01-03  Jim Wilson  <jimw@sifive.com>
2747
2748         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2749
2750 2019-01-02  Tom Tromey  <tom@tromey.com>
2751
2752         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2753         (tdesc_parse_xml): Remove cleanups.
2754         * target-descriptions.h (make_cleanup_free_target_description):
2755         Don't declare.
2756         (target_desc_deleter): New struct.
2757         (target_desc_up): New typedef.
2758         * target-descriptions.c (target_desc_deleter::operator()): Rename
2759         from free_target_description.
2760         (make_cleanup_free_target_description): Remove.
2761
2762 2019-01-02  Tom Tromey  <tom@tromey.com>
2763
2764         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2765         constructor, destructor.
2766         (linespec_parser): Remove typedef.
2767         (~linespec_parser): Rename from linespec_parser_delete.
2768         (linespec_lex_to_end, linespec_complete_label)
2769         (linespec_complete): Update.
2770         (decode_line_full): Remove cleanups.
2771         (decode_line_1): Update.
2772
2773 2019-01-02  Tom Tromey  <tom@tromey.com>
2774
2775         * python/python-internal.h (inferior_to_inferior_object): Change
2776         return type.
2777         * python/py-exitedevent.c (create_exited_event_object): Update.
2778         * python/py-inferior.c (inferior_to_inferior_object): Return
2779         gdbpy_ref.
2780         (python_new_inferior, python_inferior_deleted)
2781         (thread_to_thread_object, delete_thread_object)
2782         (build_inferior_list, gdbpy_selected_inferior): Update.
2783         * python/py-infthread.c (create_thread_object): Update.  Also fail
2784         if inferior_to_inferior_object fails.
2785
2786 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2787
2788         * inferior.h (class inferior) <displaced_step_state>: New field.
2789         * infrun.h (struct displaced_step_state): Move here from
2790         infrun.c.  Initialize fields, add constructor.
2791         <inf>: Remove field.
2792         <reset>: New method.
2793         * infrun.c (struct displaced_step_inferior_state): Move to
2794         infrun.h.
2795         (displaced_step_inferior_states): Remove.
2796         (get_displaced_stepping_state): Adust.
2797         (displaced_step_in_progress_any_inferior): Adjust.
2798         (displaced_step_in_progress_thread): Adjust.
2799         (displaced_step_in_progress): Adjust.
2800         (add_displaced_stepping_state): Remove.
2801         (get_displaced_step_closure_by_addr): Adjust.
2802         (remove_displaced_stepping_state): Remove.
2803         (infrun_inferior_exit): Call displaced_step_state.reset.
2804         (use_displaced_stepping): Don't check for NULL.
2805         (displaced_step_prepare_throw): Call
2806         get_displaced_stepping_state.
2807         (displaced_step_fixup): Don't check for NULL.
2808         (prepare_for_detach): Don't check for NULL.
2809
2810 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2811
2812         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2813          in case of call that did not complete.
2814
2815 2019-01-02  Andrey Utkin  <autkin@undo.io>
2816
2817         * symfile.c (find_separate_debug_file): Fix search of debug files for
2818         remote debuggee.
2819
2820 2019-01-02  Tom Tromey  <tom@tromey.com>
2821
2822         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2823         indentation.
2824         * python/py-frame.c (frapy_older): Remove cast.
2825         (frapy_newer): Likewise.
2826         * python/py-breakpoint.c (local_setattro): Remove cast.
2827         * python/py-arch.c (archpy_name): Remove local variable.
2828         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2829
2830 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2831
2832         * unittests/basic_string_view/element_access/char/empty.cc:
2833         Fix year range in copyright header.
2834
2835 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2836
2837         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2838         Delete.
2839         <operator==>: Update with for removed field.
2840         <hash>: Likewise.
2841         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2842         <isa_features>: ...this.
2843         <abi_features>: New field.
2844         (riscv_isa_flen): Update comment.
2845         (riscv_abi_xlen): New declaration.
2846         (riscv_abi_flen): New declaration.
2847         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2848         isa_features.
2849         (riscv_abi_xlen): New function.
2850         (riscv_isa_flen): Update to get answer from isa_features.
2851         (riscv_abi_flen): New function.
2852         (riscv_has_fp_abi): Update to get answer from abi_features.
2853         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2854         xlen and flen.
2855         (riscv_call_info) <xlen, flen>: Update comment.
2856         (riscv_call_arg_struct): Remove invalid assertions
2857         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2858         is removed.
2859         (riscv_gdbarch_init): Gather isa features and abi features
2860         separately, ensure both match on the gdbarch when reusing an old
2861         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2862         a target with 64-bit float hardware.
2863
2864 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2865
2866         * source.c (search_command_helper): Stop reverse search
2867         when line 1 has been searched.
2868
2869 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2870
2871         * record-full.c (record_full_base_target::close): Rewrite
2872         record_full_core_buf_list free logic.
2873
2874 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2875
2876         * break-catch-syscall.c (print_one_catch_syscall): xfree
2877         the last text.
2878
2879 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2880
2881         * top.c (print_gdb_version): Update Copyright year in version
2882         message.
2883
2884 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2885
2886         Update copyright year range in all GDB files.
2887
2888 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2889
2890         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2891
2892 For older changes see ChangeLog-2018.
2893 \f
2894 Local Variables:
2895 mode: change-log
2896 left-margin: 8
2897 fill-column: 74
2898 version-control: never
2899 coding: utf-8
2900 End:
2901