gdb/ChangeLog

   1 2019-07-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * valops.c (value_cast): Specialize error message for Ada.
   4
   5 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
   6
   7         * breakpoint.c (breakpoint_1): Update doc and parameter names.
   8
   9 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  10
  11         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
  12         bpstat_should_step): Return bool, adjust comments.
  13         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
  14         bpstat_should_step): Likewise.
  15
  16 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  17
  18         * features/Makefile: Use feature target descriptions for Arm.
  19         * features/arm/arm-core.c: Generate new file.
  20         * features/arm/arm-fpa.c: Likewise.
  21         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
  22         * features/arm/arm-m-profile.c: Likewise.
  23         * features/arm/arm-vfpv2.c: Likewise.
  24         * features/arm/arm-vfpv3.c: Likewise.
  25         * features/arm/xscale-iwmmxt.c: Likewise.
  26         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
  27
  28 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  29
  30         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
  31         ptrace earlier.
  32
  33 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  34
  35         * features/aarch64-pauth.c: Regenerate.
  36
  37 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
  38
  39         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
  40         bool.
  41         (bpstat_what): Use false instead of 0.
  42
  43 2019-07-09  Pedro Alves  <palves@redhat.com>
  44
  45         * break-catch-throw.c (is_exception_catchpoint): New.
  46         * breakpoint.c (print_one_breakpoint_location): New parameter
  47         'raw_loc'.  Handle it.  Use
  48         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
  49         looking at the breakpoint's type.
  50         (print_one_breakpoint): If handling "maint info breakpoints", also
  51         print locations of exception catchpoints.
  52         * breakpoint.h (is_exception_catchpoint): Declare.
  53
  54 2019-07-09  Pedro Alves  <palves@redhat.com>
  55
  56         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
  57         "addr" field.
  58         (allocate_location_exception_catchpoint): New.
  59         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
  60         (initialize_throw_catchpoint_ops): Install
  61         allocate_location_exception_catchpoint as allocate_location
  62         method.
  63         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
  64         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
  65         bp_loc_other.
  66         (breakpoint_address_is_meaningful): Delete.
  67         (bl_address_is_meaningful): New.
  68         (breakpoint_locations_match): Adjust comment.
  69         (bp_location_from_bp_type): New, factored out of...
  70         (bp_location::bp_location(breakpoint *)): ... this.
  71         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
  72         factored out of...
  73         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
  74         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
  75         breakpoint_address_is_meaningful.
  76         (bp_locations_compare): Adjust comment.
  77         (update_global_location_list): Use bl_address_is_meaningful
  78         instead of breakpoint_address_is_meaningful.
  79         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
  80         explicit.
  81         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
  82         * python/py-breakpoint.c (bppy_get_location): No longer check
  83         whether location is null.
  84
  85 2019-07-09  Pedro Alves  <palves@redhat.com>
  86
  87         PR c++/15468
  88         * breakpoint.c (print_one_breakpoint_location): Remove
  89         single-location assert.
  90
  91 2019-07-09  Tom Tromey  <tom@tromey.com>
  92
  93         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
  94         * configure: Rebuild.
  95         * configure.ac: Change common to gdbsupport.
  96         * gdbsupport: Rename from common.
  97         * acinclude.m4: Change common to gdbsupport.
  98         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
  99         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 100         gdbsupport.
 101         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 102         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 103         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 104         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 105         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 106         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 107         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 108         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 109         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 110         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 111         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 112         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 113         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 114         coff-pe-read.c, command.h, compile/compile-c-support.c,
 115         compile/compile-c.h, compile/compile-cplus-symbols.c,
 116         compile/compile-cplus-types.c, compile/compile-cplus.h,
 117         compile/compile-loc2c.c, compile/compile.c, completer.c,
 118         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 119         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 120         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 121         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 122         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 123         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 124         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 125         features/aarch64-core.c, features/aarch64-fpu.c,
 126         features/aarch64-pauth.c, features/aarch64-sve.c,
 127         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 128         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 129         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 130         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 131         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 132         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 133         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 134         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 135         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 136         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 137         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 138         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 139         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 140         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 141         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 142         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 143         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 144         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 145         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 146         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 147         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 148         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 149         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 150         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 151         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 152         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 153         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 154         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 155         minsyms.c, mips-linux-tdep.c, namespace.h,
 156         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 157         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 158         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 159         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 160         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 161         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 162         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 163         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 164         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 165         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 166         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 167         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 168         procfs.c, producer.c, progspace.h, psymtab.h,
 169         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 170         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 171         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 172         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 173         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 174         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 175         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 176         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 177         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 178         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 179         target-memory.c, target.c, target.h, target/waitstatus.c,
 180         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 181         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 182         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 183         unittests/array-view-selftests.c,
 184         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 185         unittests/common-utils-selftests.c,
 186         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 187         unittests/format_pieces-selftests.c,
 188         unittests/function-view-selftests.c,
 189         unittests/lookup_name_info-selftests.c,
 190         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 191         unittests/mkdir-recursive-selftests.c,
 192         unittests/observable-selftests.c,
 193         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 194         unittests/parse-connection-spec-selftests.c,
 195         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 196         unittests/scoped_fd-selftests.c,
 197         unittests/scoped_mmap-selftests.c,
 198         unittests/scoped_restore-selftests.c,
 199         unittests/string_view-selftests.c, unittests/style-selftests.c,
 200         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 201         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 202         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 203         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 204         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 205         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 206
 207 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 210         bool value.
 211         (decode_digits_ordinary): Set explicit_line field in sal.
 212         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 213         symtab_and_line that was set on an explicit line number in
 214         assembler code.  Do always update the recorded symtab and line if
 215         we do skip the prologue.
 216
 217 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 218
 219         * breakpoint.c (set_breakpoint_location_function): Remove
 220         explicit_loc parameter.
 221         (momentary_breakpoint_from_master): Update call to
 222         set_breakpoint_location_function.
 223         (add_location_to_breakpoint): Likewise.
 224
 225 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 226
 227         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 228         required features based on default bfd type when no specific bfd
 229         is present.
 230
 231 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 232
 233         * NEWS: Mention that GDB printf and eval commands can now print
 234         C-style and Ada-style convenience var strings without
 235         calling the inferior.
 236         * printcmd.c (printf_c_string): Locally print GDB internal var
 237         instead of transiting via the inferior.
 238         (printf_wide_c_string): Likewise.
 239
 240 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 241
 242         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 243
 244 2019-07-04  Tom Tromey  <tom@tromey.com>
 245
 246         PR tui/24724:
 247         * tui/tui-winsource.c (tui_clear_source_content): Update.
 248         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 249         (tui_update_breakpoint_info): Update.
 250         (tui_set_exec_info_content): Update.
 251         * tui/tui-source.c (tui_set_source_content_nil): Update.
 252         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 253         has_break.
 254         * tui/tui-data.h (enum tui_bp_flag): New.
 255         (tui_bp_flags): New enum flags type.
 256         (struct tui_source_element) <break_mode>: Change type.  Rename
 257         from has_break.
 258         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 259         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 260         constants.
 261         * tui/tui-winsource.h: Fix comment.
 262
 263 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 264
 265         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 266         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 267         (store_fpregs_to_thread)
 268         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 269         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 270         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 271         (IWMMXT_REGS_SIZE): Add define.
 272         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 273         (fetch_vfp_regs, store_vfp_regs)
 274         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 275         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 276
 277 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 278
 279         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 280         defines.
 281         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 282         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 283         (ARM_INT_REGISTER_SIZE): ...to this.
 284         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 285         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 286         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 287         (arm_linux_collect_gregset, supply_nwfpe_register)
 288         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 289         defines.
 290         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 291         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 292         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 293         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 294         (arm_return_in_memory, arm_store_return_value)
 295         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 296         (arm_record_ld_st_multiple): Likewise.
 297         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 298         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 299
 300 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 301
 302         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 303         AARCH64_DISPLACED_MODIFIED_INSNS.
 304         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 305         (aarch64_displaced_step_copy_insn): Likewise.
 306         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 307         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 308         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 309         ARM_DISPLACED_MODIFIED_INSNS.
 310         * arm-tdep.c (arm_gdbarch_init): Likewise.
 311         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 312         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 313         (struct arm_displaced_step_closure): Use
 314         ARM_DISPLACED_MODIFIED_INSNS.
 315
 316 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 317
 318         * features/Makefile: Remove unused xml files.
 319         * features/aarch64.xml: Remove.
 320         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 321         * features/i386/amd64-avx-avx512.xml: Remove.
 322         * features/i386/amd64-avx-linux.xml: Remove.
 323         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 324         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 325         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 326         * features/i386/amd64-avx-mpx.xml: Remove.
 327         * features/i386/amd64-avx.xml: Remove.
 328         * features/i386/amd64-linux.xml: Remove.
 329         * features/i386/amd64-mpx-linux.xml: Remove.
 330         * features/i386/amd64-mpx.xml: Remove.
 331         * features/i386/amd64.xml: Remove.
 332         * features/i386/i386-avx-avx512-linux.xml: Remove.
 333         * features/i386/i386-avx-avx512.xml: Remove.
 334         * features/i386/i386-avx-linux.xml: Remove.
 335         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 336         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 337         * features/i386/i386-avx-mpx-linux.xml: Remove.
 338         * features/i386/i386-avx-mpx.xml: Remove.
 339         * features/i386/i386-avx.xml: Remove.
 340         * features/i386/i386-linux.xml: Remove.
 341         * features/i386/i386-mmx-linux.xml: Remove.
 342         * features/i386/i386-mmx.xml: Remove.
 343         * features/i386/i386-mpx-linux.xml: Remove.
 344         * features/i386/i386-mpx.xml: Remove.
 345         * features/i386/i386.xml: Remove.
 346         * features/i386/x32-avx-avx512-linux.xml: Remove.
 347         * features/i386/x32-avx-linux.xml: Remove.
 348         * features/i386/x32-linux.xml: Remove.
 349
 350 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 351
 352         * regformats/aarch64.dat: Remove.
 353         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 354         * regformats/i386/amd64-avx-linux.dat: Remove.
 355         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 356         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 357         * regformats/i386/amd64-linux.dat: Remove.
 358         * regformats/i386/amd64-mpx-linux.dat: Remove.
 359         * regformats/i386/amd64.dat: Remove.
 360         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 361         * regformats/i386/i386-avx-linux.dat: Remove.
 362         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 363         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 364         * regformats/i386/i386-linux.dat: Remove.
 365         * regformats/i386/i386-mmx-linux.dat: Remove.
 366         * regformats/i386/i386-mpx-linux.dat: Remove.
 367         * regformats/i386/i386.dat: Remove.
 368         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 369         * regformats/i386/x32-avx-linux.dat: Remove.
 370         * regformats/i386/x32-linux.dat: Remove.
 371
 372 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 373
 374         * aarch64-tdep.c: Remove xml self tests.
 375         * amd64-linux-tdep.c: Likewise.
 376         * amd64-tdep.c: Likewise.
 377         * i386-linux-tdep.c: Likewise.
 378         * i386-tdep.c: Likewise.
 379
 380 2019-07-03  Pedro Alves  <palves@redhat.com>
 381
 382         PR cli/24732
 383         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 384         (pipe_cmd_option_defs): New.
 385         (make_pipe_cmd_options_def_group): New.
 386         (pipe_command): Use gdb::option::process_options.
 387         (pipe_command_completer): New function.
 388         (_initialize_cli_cmds): Install completer for "pipe" command.
 389
 390 2019-07-03  Pedro Alves  <palves@redhat.com>
 391
 392         * cli/cli-option.c (union option_value) <string>: New field.
 393         (struct option_def_and_value): Add ctor, move ctor, dtor and
 394         use DISABLE_COPY_AND_ASSIGN.
 395         (option_def_and_value::clear_value): New.
 396         (parse_option, save_option_value_in_ctx, get_val_type_str)
 397         (add_setshow_cmds_for_options): Handle var_string.
 398         * cli-option.h (union option_def::var_address) <string>: New
 399         field.
 400         (struct string_option_def): New.
 401         * maint-test-options.c (struct test_options_opts): Add default
 402         ctor and use DISABLE_COPY_AND_ASSIGN.
 403         <string_opt>: New field.
 404         (test_options_opts::~test_options_opts): New.
 405         (test_options_opts::dump): Also dump "-string".
 406         (test_options_option_defs): Install "string.
 407
 408 2019-07-03  Pedro Alves  <palves@redhat.com>
 409
 410         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 411         option_value with a null enumeration.
 412         (complete_options): Save the option values in the context.
 413         (save_option_value_in_ctx): New, factored out from ...
 414         (process_options): ... here.
 415         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 416         of the function.
 417         * maint-test-options.c (test_options_opts::dump): New, factored
 418         out from ...
 419         (maintenance_test_options_command_mode): ... here.
 420         (maintenance_test_options_command_completion_result): Delete.
 421         (maintenance_test_options_command_completion_text): Update
 422         comment.
 423         (maintenance_show_test_options_completion_result): Change
 424         prototype.  Just print
 425         maintenance_test_options_command_completion_text.
 426         (save_completion_result): New.
 427         (maintenance_test_options_completer_mode): Pass options context to
 428         complete_options, and then save a dump.
 429         (_initialize_maint_test_options): Use add_cmd to install "maint
 430         show test-options-completion-result".
 431
 432 2019-07-03  Pedro Alves  <palves@redhat.com>
 433
 434         * NEWS (New commands): Mention "with" and "maint with".
 435         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 436         (with_command, with_command_completer): New.
 437         (pipe_command): Adjust to new repeat_previous
 438         interface.
 439         (_initialize_cli_cmds): Install the "with" command and its "w"
 440         alias.
 441         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 442         declarations.
 443         * cli/cli-setshow.c (parse_cli_var_uinteger)
 444         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 445         argument strings for all var_types.
 446         (get_setshow_command_value_string): New, factored out from ...
 447         (do_show_command): ... this.
 448         * cli/cli-setshow.h: Include <string>.
 449         (get_setshow_command_value_string): Declare.
 450         * command.h (repeat_previous): Now returns const char *.  Adjust
 451         comment.
 452         * maint.c: Include "cli/cli-cmds.h".
 453         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 454         (_initialize_maint_cmds): Register the "maintenance with" command.
 455         * top.c (repeat_previous): Move bits from pipe_command here:
 456         Return the saved command line, if any; error out if there's no
 457         command to relaunch.
 458
 459 2019-07-03  Pedro Alves  <palves@redhat.com>
 460
 461         * NEWS (New commands): Mention "maint set/show test-settings"
 462         instead of "maint test-settings".
 463         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 464         (maintenance_test_settings_set_list): Rename to ...
 465         (maintenance_set_test_settings_list): ... this.
 466         (maintenance_test_settings_show_list): Rename to  ...
 467         (maintenance_show_test_settings_list): ... this.
 468         (maintenance_test_settings_cmd): Delete.
 469         (maintenance_test_settings_set_cmd): ...
 470         (maintenance_set_test_settings_cmd): ... this.
 471         (maintenance_test_settings_show_cmd): ...
 472         (maintenance_show_test_settings_cmd): ... this.
 473         (maintenance_test_settings_show_value_cmd):
 474         (maintenance_show_test_settings_value_cmd): ... this.
 475         (_initialize_maint_test_settings): No longer install the "maint
 476         test-settings" prefix command.  Rename "maint test-settings set"
 477         to "maint set test-settings", and "maint test-settings show" to
 478         "maint show test-settings".  Adjust all subcommands.
 479
 480 2019-07-03  Pedro Alves  <palves@redhat.com>
 481
 482         * maint-test-settings.c: Fix file's intro comment.  Replace all
 483         references to "test-options" with references to "test-settings",
 484         in comments.
 485
 486 2019-07-03  Pedro Alves  <palves@redhat.com>
 487
 488         * maint-test-settings.c (maintenance_test_settings_xxx)
 489         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 490         New.
 491         (maintenance_test_settings_enums): Use them.
 492         (maintenance_test_settings_enum): Default to
 493         maintenance_test_settings_xxx.
 494         (_initialize_maint_test_settings): Initialize
 495         MAINTENANCE_TEST_SETTINGS_FILENAME.
 496
 497 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 498
 499         * breakpoint.h (remove_breakpoints_inf): Change return type to
 500         void, move function documentation here.
 501         * breakpoint.c (remove_breakpoints_inf): Change return type to
 502         void, move function documentation to header.
 503
 504 2019-07-02  Pedro Alves  <palves@redhat.com>
 505
 506         * NEWS (Completion improvements): Mention "info threads".
 507         * thread.c (struct info_threads_opts, info_threads_option_defs)
 508         (make_info_threads_options_def_group): New.
 509         (info_threads_command): Use gdb::option::process_options.
 510         (info_threads_command_completer): New.
 511         (_initialize_thread): Use gdb::option::build_help to build the
 512         help text for "info threads".
 513
 514 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 515
 516         * defs.h (generic_load): Move from here...
 517         * symfile.h (generic_load): ... to here.  Rename name parameter
 518         to args.
 519         * symfile.c (generic_load): Add comment.
 520
 521 2019-07-01  Tom Tromey  <tromey@adacore.com>
 522
 523         * dwarf2read.c
 524         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 525         declaration of without_params.  Fix formatting.
 526
 527 2019-07-01  Tom Tromey  <tromey@adacore.com>
 528
 529         * ada-exp.y (find_primitive_type): Update.
 530         * ada-lang.h (ada_lookup_symbol): Update.
 531         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 532         parameter.
 533         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 534
 535 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 536
 537         PR breakpoints/24541
 538         * gdbarch.c: Regenerate.
 539         * gdbarch.h: Regenerate.
 540         * gdbarch.sh: Add 'stap_adjust_register'.
 541         * i386-tdep.c: Include '<unordered_set>'.
 542         (i386_stap_adjust_register): New function.
 543         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 544         * stap-probe.c (stap_parse_register_operand): Call
 545         'gdbarch_stap_adjust_register'.
 546
 547 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 548
 549         PR python/24742
 550         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 551         * python/python.c (do_start_initialization): Use 'xmalloc'
 552         instead of 'PyMem_Malloc'.
 553
 554 2019-06-28  Tom Tromey  <tromey@adacore.com>
 555
 556         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 557         for Ada.
 558
 559 2019-06-27  Tom Tromey  <tromey@adacore.com>
 560
 561         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 562         objfile_key.
 563         (arm_find_mapping_symbol, arm_record_special_symbol)
 564         (_initialize_arm_tdep): Update.
 565         (arm_objfile_data_free): Remove.
 566
 567 2019-06-27  Tom Tromey  <tromey@adacore.com>
 568
 569         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 570         to cp_print_static_field.
 571
 572 2019-06-26  Tom Tromey  <tromey@adacore.com>
 573
 574         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 575         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 576         declare.
 577
 578 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 579
 580         * features/aarch64-core.c (create_feature_aarch64_core):
 581         Regenerate.
 582         * features/aarch64-core.xml: Add cpsr flags.
 583
 584 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 585
 586         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 587         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 588
 589 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 590
 591         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 592         field.
 593         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 594         use.
 595         (arm_record_special_symbol): Don't insert new symbol in sorted
 596         position, push it at the end.
 597
 598 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 599
 600         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 601         (arm_mapping_symbol_s): Remove.
 602         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 603         (arm_mapping_symbol_vec): New typedef.
 604         (struct arm_per_objfile): Add constructor.
 605         <section_maps>: Change type to
 606         std::unique_ptr<arm_mapping_symbol_vec[]>.
 607         (arm_compare_mapping_symbols): Remove.
 608         (arm_find_mapping_symbol): Adjust to section_maps type change.
 609         (arm_objfile_data_free): Call delete on arm_per_objfile.
 610         (arm_record_special_symbol): Adjust to section_maps type change.
 611         Allocate arm_per_objfile with new.
 612
 613 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 614
 615         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 616         with the command prefix.
 617
 618 2019-06-25  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 621         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 622
 623 2019-06-25  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 626         type.
 627         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 628         protected.
 629
 630 2019-06-25  Tom Tromey  <tom@tromey.com>
 631
 632         * tui/tui-winsource.c
 633         (tui_source_window_base::set_is_exec_point_at): Add check against
 634         LOA_ADDRESS.
 635
 636 2019-06-25  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-source.c (tui_set_source_content): Don't check before
 639         xfree.
 640         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 641
 642 2019-06-25  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-winsource.h (tui_update_source_window_as_is)
 645         (tui_alloc_source_buffer, tui_line_is_displayed)
 646         (tui_addr_is_displayed): Change type of win_info.
 647         * tui/tui-winsource.c (tui_update_source_window_as_is)
 648         (tui_clear_source_content, tui_show_source_line)
 649         (tui_show_source_content, tui_source_window_base::refill)
 650         (tui_source_window_base::set_is_exec_point_at)
 651         (tui_source_window_base::set_is_exec_point_at)
 652         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 653         (tui_alloc_source_buffer, tui_line_is_displayed)
 654         (tui_addr_is_displayed): Change type of win_info.  Update.
 655         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 656         (tui_source_window_base::do_make_visible_with_new_height):
 657         Update.
 658         * tui/tui-source.c (tui_set_source_content)
 659         (tui_set_source_content_nil)
 660         (tui_source_window::do_scroll_vertical): Update.
 661         * tui/tui-layout.c (show_layout): Update.
 662         * tui/tui-disasm.c (tui_set_disassem_content)
 663         (tui_disasm_window::do_scroll_vertical): Update.
 664         * tui/tui-data.h (tui_win_content): Remove.
 665         (struct tui_gen_win_info) <content, content_size>: Remove.
 666         (struct tui_source_element): Add initializers and destructor.
 667         (union tui_which_element, struct tui_win_element): Remove.
 668         (struct tui_source_window_base) <content>: New field.
 669         (struct tui_data_window): Remove destructor.
 670         (tui_alloc_content, tui_free_win_content)
 671         (tui_free_all_source_wins_content): Don't declare.
 672         * tui/tui-data.c (tui_initialize_static_data): Update.
 673         (init_content_element, tui_alloc_content): Remove.
 674         (~tui_gen_win_info): Update.
 675         (~tui_data_window, tui_free_all_source_wins_content)
 676         (tui_free_win_content, free_content, free_content_elements):
 677         Remove.
 678
 679 2019-06-25  Tom Tromey  <tom@tromey.com>
 680
 681         * tui/tui-winsource.h (tui_clear_source_content)
 682         (tui_erase_source_content, tui_show_source_content): Change type
 683         of win_info.
 684         * tui/tui-winsource.c (tui_clear_source_content)
 685         (tui_erase_source_content, tui_show_source_content): Change type
 686         of win_info.
 687         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 688         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 689         win_info.
 690         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 691         win_info.
 692         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 693
 694 2019-06-25  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui-winsource.c (tui_clear_source_content)
 697         (tui_source_window_base::set_is_exec_point_at): Update.
 698         * tui/tui-source.c (tui_set_source_content_nil): Update.
 699         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 700         a bool.
 701         * tui/tui-data.c (init_content_element): Update.
 702
 703 2019-06-25  Tom Tromey  <tom@tromey.com>
 704
 705         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 706         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 707         * tui/tui-layout.c (init_and_make_win): Update.
 708         * tui/tui.h (enum tui_win_type): Update.
 709         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 710         tui_win_is_auxillary.
 711         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 712         tui_win_is_auxillary.
 713
 714 2019-06-25  Tom Tromey  <tom@tromey.com>
 715
 716         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 717         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 718         (tui_delete_data_content_windows, tui_display_all_data)
 719         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 720         Update.
 721         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 722         * tui/tui-regs.c (tui_last_regs_line_no)
 723         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 724         (tui_show_registers): Update.
 725         (tui_show_register_group): Return void.  Update.
 726         (tui_display_registers_from, tui_display_reg_element_at_line)
 727         (tui_display_registers_from_line, tui_check_register_values):
 728         Update.
 729         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 730         member.
 731         (struct tui_data_window) <regs_content>: Now a std::vector.
 732         <regs_content_count>: Remove.
 733         (tui_add_content_elements, tui_free_data_content): Don't declare.
 734         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 735         (init_content_element): Remove DATA_WIN case.  Add assert.
 736         (tui_add_content_elements): Remove.
 737         (tui_data_window): Update.
 738         (tui_free_data_content): Remove.
 739         (free_content_elements): Remove DATA_WIN case.
 740
 741 2019-06-25  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui-data.c (tui_data_item_window): Update.
 744         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 745         * tui/tui-windata.c (tui_display_all_data)
 746         (tui_display_data_from_line): Update.
 747         (tui_check_data_values): Remove.
 748         * tui/tui-regs.c (tui_show_register_group)
 749         (tui_display_reg_element_at_line): Update.
 750         * tui/tui-hooks.c (tui_register_changed)
 751         (tui_refresh_frame_and_register_information): Call
 752         tui_check_register_values.
 753         * tui/tui-data.h (struct tui_data_window) <data_content,
 754         data_content_count, data_type>: Remove.
 755         (enum tui_data_type): Remove.
 756
 757         * tui/tui-data.c (tui_data_window::clear_detail)
 758         (~tui_data_window): Update.
 759
 760 2019-06-25  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 763         declare.
 764         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 765         Rename from tui_first_data_item_displayed.  Update.
 766         (tui_data_window::refresh_all)
 767         (tui_data_window::do_scroll_vertical): Update.
 768         * tui/tui-data.h (struct tui_data_window)
 769         <first_data_item_displayed>: Declare new method.
 770
 771 2019-06-25  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 774         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 775         contents...
 776         (tui_initialize_static_data): ...here.
 777
 778 2019-06-25  Tom Tromey  <tom@tromey.com>
 779
 780         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 781         (tui_display_registers_from, tui_check_register_values): Update.
 782         (tui_display_register): Remove win_info parameter; update.
 783         (tui_get_register): Change type of parameters.
 784         * tui/tui-data.h (struct tui_data_element): Remove.
 785         (union tui_which_element) <data>: Remove.
 786         <data_window>: Change type.
 787         (struct tui_data_item_window): New.
 788         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 789         case.  Add assert.
 790         (~tui_data_item_window): New destructor.
 791         (free_content_elements): Remove DATA_ITEM_WIN case.
 792
 793 2019-06-25  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 796         Remove.
 797
 798 2019-06-25  Tom Tromey  <tom@tromey.com>
 799
 800         * tui/tui-data.h (struct tui_command_element): Remove.
 801         (union tui_which_element) <command>: Remove.
 802         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 803         assert.
 804         (free_content_elements): Remove CMD_WIN case.
 805
 806 2019-06-25  Tom Tromey  <tom@tromey.com>
 807
 808         * tui/tui-layout.c (tui_set_layout): Update.
 809         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 810         * tui/tui-data.c (layout_def): Update.
 811
 812 2019-06-25  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 815         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 816         (tui_source_window_base::set_new_height): Update.
 817         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 818         Update.
 819         (tui_set_locator_fullname, tui_set_locator_info)
 820         (tui_show_frame_info): Update.
 821         * tui/tui-source.c (tui_set_source_content)
 822         (tui_source_is_displayed): Update.
 823         * tui/tui-layout.c (show_source_disasm_command, show_data)
 824         (show_source_or_disasm_and_command): Update.
 825         * tui/tui-disasm.c (tui_set_disassem_content)
 826         (tui_get_begin_asm_address): Update.
 827         * tui/tui-data.h (struct tui_locator_element): Remove.
 828         (union tui_which_element) <locator>: Remove.
 829         (struct tui_locator_window): New.
 830         (tui_locator_win_info_ptr): Change return type.
 831         * tui/tui-data.c (_locator): Change type.
 832         (tui_locator_win_info_ptr): Change return type.
 833         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 834         (tui_alloc_content): Add assert.
 835
 836 2019-06-25  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-winsource.c
 839         (tui_exec_info_window::maybe_allocate_content): New method.
 840         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 841         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 842         (make_source_or_disasm_window): Add cast.
 843         * tui/tui-data.h (union tui_which_element) <simple_string>:
 844         Remove.
 845         (struct tui_source_info): New.
 846         (struct tui_source_window_base) <execution_info>: Change type.
 847         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 848         case, and add assert.
 849         (tui_alloc_content): Add assert.
 850
 851 2019-06-25  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 854         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 855         * tui/tui-data.c (tui_alloc_win_info): Remove.
 856
 857 2019-06-25  Tom Tromey  <tom@tromey.com>
 858
 859         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 860         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 861         can_highlight.
 862
 863 2019-06-25  Tom Tromey  <tom@tromey.com>
 864
 865         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 866         make_visible_with_new_height method.
 867         (tui_win_info::make_visible_with_new_height): New method.
 868         (tui_source_window_base::do_make_visible_with_new_height)
 869         (tui_data_window::do_make_visible_with_new_height)
 870         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 871         (make_visible_with_new_height): Remove.
 872         (tui_resize_all, tui_adjust_win_heights): Use
 873         make_visible_with_new_height method.
 874         * tui/tui-data.h (struct tui_win_info)
 875         <do_make_visible_with_new_height, make_visible_with_new_height>:
 876         New methods.
 877         (struct tui_source_window_base, struct tui_data_window)
 878         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 879         methods.
 880
 881 2019-06-25  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 884         method.
 885         (update_tab_width): Call update_tab_width method.
 886         * tui/tui-data.h (struct tui_win_info)
 887         (struct tui_source_window_base) <update_tab_width>: New methods.
 888
 889 2019-06-25  Tom Tromey  <tom@tromey.com>
 890
 891         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 892         parameter.
 893         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 894         parameter.
 895         (tui_gen_win_info::make_visible): Update.
 896         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 897         parameter.
 898         * tui/tui-data.h (enum tui_box): New enum.
 899         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 900
 901 2019-06-25  Tom Tromey  <tom@tromey.com>
 902
 903         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 904         init_and_make_win for EXEC_INFO_WIN.
 905         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 906         longer inline.
 907         (struct tui_win_info) <~tui_win_info>: Inline.
 908         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 909         Don't declare.
 910         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 911         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 912         Remove.
 913         (tui_initialize_static_data): Update.
 914         (~tui_gen_win_info): Handle more cleanup here.
 915         (~tui_source_window_base): Delete "execution_info".
 916         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 917
 918 2019-06-25  Tom Tromey  <tom@tromey.com>
 919
 920         * tui/tui-layout.c (make_command_window): Don't set
 921         can_highlight.
 922         (show_source_disasm_command): Call the reset method.
 923         (show_data): Don't set can_highlight.  Call the reset method.
 924         (tui_gen_win_info::reset): Rename from init_gen_win_info
 925         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 926         (show_source_or_disasm_and_command): Call the reset method.
 927         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 928         (struct tui_cmd_window): Set can_highlight.
 929
 930 2019-06-25  Tom Tromey  <tom@tromey.com>
 931
 932         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 933         from make_visible.
 934         (tui_make_visible, tui_make_invisible): Rewrite.
 935         (tui_win_info::make_visible): Remove.
 936         (tui_source_window_base::make_visible): Update.
 937         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 938         method.  Moved from...
 939         (struct tui_win_info) <make_visible>: ...here.
 940
 941 2019-06-25  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-winsource.c
 944         (tui_source_window_base::do_scroll_horizontal): Remove direction
 945         parameter.
 946         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 947         direction parameter.
 948         * tui/tui-win.c (tui_win_info::forward_scroll)
 949         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 950         (tui_win_info::right_scroll): Update.
 951         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 952         direction parameter.
 953         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 954         direction parameter.
 955         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 956         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 957         Remove direction parameter.
 958         (struct tui_source_window_base, struct tui_source_window)
 959         (struct tui_disasm_window, struct tui_data_window)
 960         (struct tui_cmd_window): Update.
 961
 962 2019-06-25  Tom Tromey  <tom@tromey.com>
 963
 964         * tui/tui-winsource.h (tui_set_exec_info_content)
 965         (tui_show_exec_info_content, tui_erase_exec_info_content)
 966         (tui_clear_exec_info_content, tui_update_exec_info): Change
 967         argument to tui_source_window_base.
 968         * tui/tui-winsource.c (tui_set_exec_info_content)
 969         (tui_show_exec_info_content, tui_erase_exec_info_content)
 970         (tui_clear_exec_info_content, tui_update_exec_info): Change
 971         argument to tui_source_window_base.
 972
 973 2019-06-25  Tom Tromey  <tom@tromey.com>
 974
 975         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 976         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 977
 978 2019-06-25  Tom Tromey  <tom@tromey.com>
 979
 980         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 981         check.
 982
 983 2019-06-25  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 986         type to void.
 987         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 988         type to void.
 989         * tui/tui-source.c (tui_set_source_content): Update.
 990         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 991
 992 2019-06-25  Tom Tromey  <tom@tromey.com>
 993
 994         * tui/tui-win.c (window_name_completer, tui_set_focus)
 995         (tui_all_windows_info): Use name method.
 996         * tui/tui-data.h (struct tui_gen_win_info)
 997         (struct tui_source_window, struct tui_disasm_window)
 998         (struct tui_data_window, struct tui_cmd_window) <name>: New
 999         method.
1000         (tui_win_name): Don't declare.
1001         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1002         (tui_win_name): Remove.
1003
1004 2019-06-25  Tom Tromey  <tom@tromey.com>
1005
1006         * tui/tui-winsource.h (tui_update_source_window)
1007         (tui_update_source_window_as_is): Change parameter type.
1008         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1009         to be a tui_source_window_base.
1010         (tui_update_source_window_as_is): Likewise.
1011         * tui/tui-win.c (make_visible_with_new_height): Update.
1012
1013 2019-06-25  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-winsource.c (tui_erase_source_content)
1016         (tui_show_source_content, tui_show_exec_info_content)
1017         (tui_erase_exec_info_content): Use refresh_window method.
1018         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1019         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1020         from tui_refresh_win.
1021         (tui_data_window::refresh_window): New method.
1022         (tui_win_info::refresh, tui_source_window_base::refresh)
1023         (tui_refresh_all): Use refresh_window method.
1024         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1025         method.
1026         * tui/tui-regs.c (tui_display_register): Call refresh_window
1027         method.
1028         * tui/tui-layout.c (show_source_disasm_command)
1029         (show_source_or_disasm_and_command): Call refresh_window method.
1030         * tui/tui-data.h (struct tui_gen_win_info)
1031         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1032         New method.
1033
1034 2019-06-25  Tom Tromey  <tom@tromey.com>
1035
1036         * tui/tui.c (tui_rl_other_window, tui_enable)
1037         (tui_is_window_visible, tui_get_command_dimension): Update.
1038         * tui/tui-winsource.c (tui_update_source_window_as_is)
1039         (tui_clear_source_content, tui_erase_source_content)
1040         (tui_show_source_line, tui_source_window_base::refill)
1041         (tui_source_window_base::do_scroll_horizontal)
1042         (tui_source_window_base::set_is_exec_point_at)
1043         (tui_update_breakpoint_info, tui_set_exec_info_content)
1044         (tui_alloc_source_buffer, tui_line_is_displayed)
1045         (tui_addr_is_displayed): Update.
1046         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1047         (tui_check_and_display_highlight_if_needed)
1048         (tui_win_info::make_visible, tui_win_info::refresh)
1049         (tui_refresh_all): Update.
1050         * tui/tui-windata.c (tui_first_data_item_displayed)
1051         (tui_delete_data_content_windows, tui_erase_data_content)
1052         (tui_display_all_data, tui_data_window::refresh_all)
1053         (tui_check_data_values): Update.
1054         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1055         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1056         (tui_win_info::backward_scroll, tui_refresh_all_win)
1057         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1058         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1059         (tui_source_window_base::set_new_height)
1060         (tui_data_window::set_new_height)
1061         (make_invisible_and_set_new_height)
1062         (make_visible_with_new_height, new_height_ok)
1063         (parse_scrolling_args): Update.
1064         * tui/tui-stack.c (tui_show_frame_info): Update.
1065         * tui/tui-source.c (tui_set_source_content)
1066         (tui_set_source_content_nil, tui_source_is_displayed)
1067         (tui_source_window::do_scroll_vertical): Update.
1068         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1069         (tui_display_registers_from, tui_display_reg_element_at_line)
1070         (tui_check_register_values, tui_reg_command): Update.
1071         * tui/tui-layout.c (tui_default_win_height)
1072         (show_source_disasm_command, show_data, init_and_make_win)
1073         (show_source_or_disasm_and_command): Update.
1074         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1075         (tui_redisplay_readline, tui_mld_flush)
1076         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1077         (tui_getc): Update.
1078         * tui/tui-disasm.c (tui_set_disassem_content)
1079         (tui_disasm_window::do_scroll_vertical): Update.
1080         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1081         Now virtual.
1082         (struct tui_win_info): Derive from tui_gen_win_info.
1083         <~tui_win_info>: Mark as override.
1084         <generic>: Remove member.
1085         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1086         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1087         (~tui_data_window, ~tui_win_info)
1088         (tui_free_all_source_wins_content): Update.
1089         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1090
1091 2019-06-25  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui-layout.c (init_and_make_win): Use new.
1094         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1095         destructor, initializers.
1096         (tui_alloc_generic_win_info): Don't declare.
1097         * tui/tui-data.c (_locator): Add argument to constructor.
1098         (source_win, disasm_win): New globals.
1099         (exec_info): Remove.
1100         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1101         Update.
1102         (tui_alloc_generic_win_info): Remove.
1103         (init_content_element): Use new.
1104         (tui_win_info::tui_win_info): Update.
1105         (free_content_elements) <case DATA_WIN>: Use delete.
1106
1107 2019-06-25  Tom Tromey  <tom@tromey.com>
1108
1109         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1110         * tui/tui-windata.c (tui_first_data_item_displayed)
1111         (tui_delete_data_content_windows): Update.
1112         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1113         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1114         (tui_display_registers_from, tui_check_register_values): Update.
1115         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1116         pointer.
1117         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1118         window.
1119         (tui_free_data_content): Update.
1120         (free_content_elements) <case DATA_WIN>: Free the window.
1121
1122 2019-06-25  Tom Tromey  <tom@tromey.com>
1123
1124         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1125         Update.
1126         * tui/tui-layout.c (make_command_window)
1127         (show_source_disasm_command, show_data, init_and_make_win)
1128         (show_source_or_disasm_and_command): Update.
1129         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1130         method.
1131         <can_highight, is_highlighted>: Now bool.
1132         (tui_set_win_highlight): Don't declare.
1133         * tui/tui-data.c (tui_set_win_highlight): Remove.
1134
1135 2019-06-25  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-wingeneral.c (make_visible): Remove check of window
1138         type.
1139
1140 2019-06-25  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-win.c (tui_win_info::max_height)
1143         (tui_cmd_window::max_height): New methods.
1144         (new_height_ok): Call max_height.
1145         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1146         <max_height>: New method.
1147
1148 2019-06-25  Tom Tromey  <tom@tromey.com>
1149
1150         * tui/tui-win.c (tui_source_window_base::set_new_height)
1151         (tui_data_window::set_new_height): New methods.
1152         (make_invisible_and_set_new_height): Call set_new_height method.
1153         * tui/tui-data.h (struct tui_win_info)
1154         (struct tui_source_window_base, struct tui_data_window)
1155         <set_new_height>: New method.
1156
1157 2019-06-25  Tom Tromey  <tom@tromey.com>
1158
1159         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1160         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1161         tui_refresh_data_win.
1162         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1163         method.
1164         (tui_refresh_all_win): Call the refresh_all method.
1165         (tui_set_focus): Likewise.
1166         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1167         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1168         Likewise.
1169
1170 2019-06-25  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-winsource.h (tui_refill_source_window)
1173         (tui_set_is_exec_point_at): Don't declare.
1174         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1175         (tui_source_window_base::refill): Rename from
1176         tui_refill_source_window.
1177         (tui_source_window_base::do_scroll_horizontal): Update.
1178         (tui_source_window_base::set_is_exec_point_at): Rename from
1179         tui_set_is_exec_point_at.
1180         (tui_update_all_breakpoint_info): Update.
1181         * tui/tui-stack.c (tui_show_frame_info): Update.
1182         * tui/tui-layout.c (show_data): Add cast.
1183         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1184         * tui/tui-data.h (struct tui_source_window_base) <refill,
1185         set_is_exec_point_at>: New methods.
1186         (tui_source_windows, tui_add_to_source_windows): Update types.
1187         (tui_add_to_source_windows): Remove redundant declaration.
1188         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1189         (tui_source_windows): Change return type.
1190         (tui_clear_source_windows_detail): Update.
1191         (tui_add_to_source_windows): Change type of parameter.
1192         (tui_free_all_source_wins_content): Update.
1193
1194 2019-06-25  Tom Tromey  <tom@tromey.com>
1195
1196         * tui/tui-wingeneral.c (tui_win_info::refresh)
1197         (tui_source_window_base::refresh): New methods.
1198         (tui_refresh_all): Call the refresh method.
1199         * tui/tui-data.h (struct tui_win_info)
1200         (struct tui_source_window_base) <refresh>: New method.
1201
1202 2019-06-25  Tom Tromey  <tom@tromey.com>
1203
1204         * tui/tui.h (tui_is_window_visible): Return bool.
1205         * tui/tui.c (tui_is_window_visible): Return bool.
1206         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1207         (tui_make_visible, tui_make_invisible)
1208         (tui_win_info::make_visible)
1209         (tui_source_window_base::make_visible, make_all_visible)
1210         (tui_make_all_visible, tui_make_all_invisible): Update.
1211         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1212         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1213         bool.
1214         (struct tui_win_info, struct tui_source_window_base)
1215         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1216         * tui/tui-data.c (tui_init_generic_part): Update.
1217
1218 2019-06-25  Tom Tromey  <tom@tromey.com>
1219
1220         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1221         (tui_source_window_base::make_visible): New methods.
1222         (make_all_visible): Make method call.
1223         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1224         (struct tui_source_window_base, struct tui_cmd_window): Override
1225         make_visible.
1226         (tui_win_is_source_type): Don't declare.
1227         * tui/tui-data.c (tui_win_is_source_type): Remove.
1228
1229 2019-06-25  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1232         NULL check.
1233
1234 2019-06-25  Tom Tromey  <tom@tromey.com>
1235
1236         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1237         Inline constructor.  Add initializers for members.
1238         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1239         constructors; now inline in class.
1240
1241 2019-06-25  Tom Tromey  <tom@tromey.com>
1242
1243         * tui/tui-regs.c (tui_show_registers): Update.
1244         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1245         bool.
1246         * tui/tui-data.c (tui_data_window::clear_detail)
1247         (tui_data_window): Update.
1248
1249 2019-06-25  Tom Tromey  <tom@tromey.com>
1250
1251         * tui/tui-windata.c (tui_display_all_data)
1252         (tui_display_data_from_line, tui_display_data_from)
1253         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1254         Update.
1255         * tui/tui-regs.c (tui_last_regs_line_no)
1256         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1257         (tui_show_registers, tui_show_register_group)
1258         (tui_display_registers_from, tui_display_reg_element_at_line)
1259         (tui_display_registers_from_line, tui_check_register_values)
1260         (tui_reg_next, tui_reg_prev): Update.
1261         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1262         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1263         tui_data_window.
1264         (struct tui_win_info) <detail>: Remove.  Add new fields from
1265         tui_data_info.
1266         (TUI_DATA_WIN): Add cast.
1267         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1268         (~tui_data_window): Simplify.
1269
1270 2019-06-25  Tom Tromey  <tom@tromey.com>
1271
1272         * tui/tui-layout.c (show_source_disasm_command)
1273         (show_source_or_disasm_and_command): Update.
1274         * tui/tui-io.c (update_cmdwin_start_line)
1275         (tui_redisplay_readline): Update.
1276         * tui/tui-data.h (struct tui_command_info): Remove.
1277         (struct tui_win_info) <detail>: Remove command_info member.
1278         (struct tui_data_window) <start_line>: New member, from
1279         tui_command_info.
1280         (TUI_CMD_WIN): Add casts.
1281
1282 2019-06-25  Tom Tromey  <tom@tromey.com>
1283
1284         * tui/tui-winsource.c (tui_update_source_window)
1285         (tui_refill_source_window)
1286         (tui_source_window_base::do_scroll_horizontal)
1287         (tui_update_breakpoint_info, tui_set_exec_info_content)
1288         (tui_show_exec_info_content, tui_erase_exec_info_content)
1289         (tui_clear_exec_info_content): Update.
1290         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1291         Update.
1292         * tui/tui-win.c (make_invisible_and_set_new_height)
1293         (make_visible_with_new_height): Update.
1294         * tui/tui-source.c (tui_set_source_content)
1295         (tui_show_symtab_source): Update.
1296         * tui/tui-layout.c (extract_display_start_addr)
1297         (show_source_disasm_command, show_data)
1298         (make_source_or_disasm_window)
1299         (show_source_or_disasm_and_command): Update.
1300         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1301         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1302         "gdbarch".
1303         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1304         to tui_source_window_base.
1305         (struct tui_win_info) <detail>: Remove source_info member.
1306         (struct tui_source_window_base) <has_locator>: Inline.
1307         Move contents from tui_source_info; rename has_locator member to
1308         m_has_locator.
1309         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1310         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1311         header file.
1312         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1313         Simplify.
1314         (tui_free_all_source_wins_content): Cast to
1315         tui_source_window_base.
1316
1317 2019-06-25  Tom Tromey  <tom@tromey.com>
1318
1319         * tui/tui-win.c (make_invisible_and_set_new_height)
1320         (make_visible_with_new_height): Call has_locator method.
1321         * tui/tui-layout.c (show_source_disasm_command, show_data)
1322         (show_source_or_disasm_and_command): Update for bool change.
1323         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1324         (tui_win_info) <has_locator>: New method.
1325         (struct tui_source_window_base) <has_locator>: New method.
1326         (tui_win_has_locator): Don't declare.
1327         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1328         from tui_win_has_locator.
1329         (tui_source_window_base): Use false, not FALSE.
1330
1331 2019-06-25  Tom Tromey  <tom@tromey.com>
1332
1333         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1334         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1335         clear_detail method directly.
1336         (tui_clear_win_detail): Remove.
1337
1338 2019-06-25  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1341         "this", not TUI_DISASM_WIN.
1342
1343 2019-06-25  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1346         declare.
1347         * tui/tui-winsource.c
1348         (tui_source_window_base::do_scroll_horizontal): Rename from
1349         tui_horizontal_source_scroll.
1350         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1351         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1352         from tui_vertical_data_scroll.
1353         * tui/tui-win.h (tui_scroll): Don't declare.
1354         * tui/tui-win.c (tui_win_info::forward_scroll)
1355         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1356         (tui_win_info::right_scroll): Rename and update.
1357         (tui_scroll_forward_command, tui_scroll_backward_command)
1358         (tui_scroll_left_command, tui_scroll_right_command): Update.
1359         (tui_scroll): Remove.
1360         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1361         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1362         from tui_vertical_source_scroll.
1363         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1364         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1365         from tui_vertical_disassem_scroll.
1366         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1367         do_scroll_horizontal>: New methods.
1368         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1369         Likewise.
1370         (struct tui_source_window_base): Add do_scroll_horizontal.
1371         (struct tui_source_window, struct tui_disasm_window): Add
1372         do_scroll_vertical.
1373         (struct tui_data_window, struct tui_cmd_window): Add
1374         do_scroll_horizontal and do_scroll_vertical.
1375         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1376
1377 2019-06-25  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui-data.h (struct tui_source_window_base): New struct.
1380         (struct tui_source_window): Derive from tui_source_window_base.
1381         (struct tui_disasm_window): New struct.
1382         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1383         from tui_source_window::clear_detail.
1384         (tui_source_window_base): Rename from tui_source_window.
1385         (~tui_source_window_base): Rename from ~tui_source_window.
1386         (tui_alloc_win_info): Create a tui_disasm_window.
1387
1388 2019-06-25  Tom Tromey  <tom@tromey.com>
1389
1390         * tui/tui-data.h (struct tui_source_window)
1391         (struct tui_data_window): Declare destructors.
1392         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1393         destructors.
1394         (tui_win_info): Simplify.
1395
1396 2019-06-25  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-winsource.c (tui_display_main)
1399         (tui_update_source_windows_with_addr)
1400         (tui_update_all_breakpoint_info): Update.
1401         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1402         (new_height_ok, parse_scrolling_args): Update.
1403         * tui/tui-stack.c (tui_show_frame_info): Update.
1404         * tui/tui-data.h (struct tui_list): Remove.
1405         (tui_source_windows): Return a reference to a std::vector.
1406         * tui/tui-data.c (source_windows): Now a std::vector.
1407         (tui_source_windows): Change return type.
1408         (tui_clear_source_windows): Rewrite.
1409         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1410         (tui_free_all_source_wins_content): Rewrite.
1411
1412 2019-06-25  Tom Tromey  <tom@tromey.com>
1413
1414         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1415         (struct tui_data_window, struct tui_cmd_window): Declare
1416         clear_detail method.
1417         * tui/tui-data.c (tui_source_window::clear_detail)
1418         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1419         methods.
1420         (tui_clear_win_detail): Simplify.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-layout.c (make_source_window, make_disasm_window)
1425         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1426         Return the new window.
1427         (show_source_disasm_command, show_data)
1428         (show_source_or_disasm_and_command): Update.
1429
1430 2019-06-25  Tom Tromey  <tom@tromey.com>
1431
1432         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1433         parameter.  Return the new window.
1434         (show_source_disasm_command): Update and remove NULL check.
1435         (show_source_or_disasm_and_command): Update.
1436
1437 2019-06-25  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1440
1441 2019-06-25  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-data.h (struct tui_win_info): Make constructor
1444         protected.  Make destructor virtual.  Add initializers.
1445         (tui_source_window, tui_data_window, tui_cmd_window): New
1446         classes.
1447         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1448         constructor.  Add "type" parameter.
1449         (tui_source_window, tui_data_window, tui_cmd_window): New
1450         constructors.
1451         (tui_alloc_win_info): Instantiate the appropriate subclass.
1452
1453 2019-06-25  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-win.c (tui_resize_all): Use delete.
1456         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1457         destructor.
1458         (tui_free_window): Don't declare.
1459         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1460         Update.
1461
1462 2019-06-25  Tom Tromey  <tom@tromey.com>
1463
1464         * tui/tui-data.h (struct tui_win_info): Add constructor.
1465         * tui/tui-data.c (tui_alloc_win_info): Use new.
1466         (tui_free_window): Use delete.
1467
1468 2019-06-22  Tom Tromey  <tom@tromey.com>
1469
1470         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1471         declare.
1472         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1473
1474 2019-06-22  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1477         declare.
1478         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1479
1480 2019-06-22  Tom de Vries  <tdevries@suse.de>
1481
1482         * dwarf2read.c (create_addrmap_from_aranges)
1483         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1484         instead of '%zu'.
1485
1486 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1487
1488         * dwarf2read.h (dwarf2_section_info_def): Remove.
1489         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1490         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1491         std::vector<dwarf2_section_info>.
1492         (struct dwo_file) <~dwo_file>: Remove.
1493         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1494         types field.
1495         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1496         (dwarf2_read_debug_names): Likewise.
1497         (create_debug_types_hash_table): Change parameter type to
1498         array_view, adjust code accordingly.
1499         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1500         (partial_die_info::fixup): Likewise.
1501         (determine_prefix): Likewise.
1502         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1503
1504 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1505
1506         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1507         gdb_bfd_ref_ptr.
1508         <~dwo_file>: Remove call to gdb_bfd_unref.
1509         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1510         gdb_bfd_ref_ptr::get.
1511
1512 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1513
1514         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1515         type to htab_up.
1516         * dwarf2read.c (struct dwo_file): Initialize fields.
1517         <~dwo_file>: New.
1518         (free_dwo_file): Remove, move content to ~dwo_file.
1519         (struct dwo_file_deleter): Remove.
1520         (dwo_file_up>: Remove custom deleter.
1521         (free_dwo_files): Remove.
1522         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1523         dwo_files.
1524         (process_skeletonless_type_units): Call unique_ptr::get.
1525         (allocate_dwo_file_hash_table): Add deleter to created hash
1526         table.  Change return type to htab_up.
1527         (lookup_dwo_file_slot): Don't memset dwo_file, call
1528         unique_ptr::get.
1529         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1530         (create_dwo_unit_in_dwp_v2): Likewise.
1531         (open_and_init_dwo_file): Likewise.
1532         (free_dwo_file_from_slot): Remove.
1533
1534 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1535
1536         * dwarf2read.h (struct dwarf2_section_info) <readin,
1537         is_virtual>: Change type to bool.
1538         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1539         true instead of 1.
1540
1541 2019-06-19  Tom Tromey  <tom@tromey.com>
1542
1543         * tui/tui-data.h (tui_init_content_element): Don't declare.
1544
1545 2019-06-19  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-data.h (tui_init_win_info): Don't declare.
1548
1549 2019-06-19  Tom de Vries  <tdevries@suse.de>
1550
1551         * dwarf2read.h (abstract_to_concrete): Change type to
1552         std::unordered_map<sect_offset, std::vector<sect_offset>,
1553         gdb::hash_enum<sect_offset>>.
1554
1555 2019-06-19  Tom Tromey  <tromey@adacore.com>
1556
1557         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1558         EVAL_AVOID_SIDE_EFFECTS specially.
1559
1560 2019-06-19  Tom Tromey  <tromey@adacore.com>
1561
1562         * source-cache.c (highlighter): New global.
1563         (source_cache::get_source_lines): Create a highlighter on demand.
1564
1565 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1566
1567         * defs.h (deprecated_interactive_hook): Delete declaration.
1568         * interps.c (clear_interpreter_hooks): Remove use of
1569         deprecated_interactive_hook.
1570         * top.c (deprecated_interactive_hook): Delete definition.
1571         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1572
1573 2019-06-18  Tom de Vries  <tdevries@suse.de>
1574
1575         PR gdb/24515
1576         * dwarf2read.h (abstract_to_concrete): Change type from
1577         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1578         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1579         * dwarf2read.c (read_variable): Update.
1580         (dwarf2_fetch_die_loc_sect_off): Update.
1581
1582 2019-06-17  Tom de Vries  <tdevries@suse.de>
1583
1584         PR gdb/24617
1585         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1586         accessing parent[parent_len - 1].
1587
1588 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1589
1590         PR gdb/24364
1591         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1592         call dtrace_process_dof with NULL dof.
1593
1594 2019-06-16  Tom de Vries  <tdevries@suse.de>
1595
1596         PR gdb/24445
1597         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1598
1599 2019-06-16  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1602         (make_all_visible): Use address of member.
1603
1604 2019-06-16  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1607         (tui_free_window, free_content, free_content_elements): Remove
1608         unnecessary cast.
1609         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1610         cast.
1611         * tui/tui-regs.c (tui_show_register_group)
1612         (tui_display_registers_from, tui_display_reg_element_at_line):
1613         Remove unnecessary cast.
1614
1615 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * linux-nat.c (normal_mask): Delete.
1618         (_initialize_linux_nat): Don't initialise normal_mask.
1619
1620 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1621
1622         PR gdb/24445
1623         * dwarf-index-write.h (write_psymtabs_to_index): Add
1624         dwz_basename parameter.
1625         * dwarf-index-write.c (write_gdbindex): Move file writing to
1626         write_gdbindex_1.  Change return type void.
1627         (assert_file_size): Move up, remove filename parameter.
1628         (write_gdbindex_1): New function.
1629         (write_debug_names): Change return type to void, call
1630         assert_file_size.
1631         (struct index_wip_file): New struct.
1632         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1633         file logic to index_wip_file.  Write index for dwz file if
1634         needed.
1635         (save_gdb_index_command): Pass basename of dwz file, if present.
1636         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1637         build-id of dwz file, if present.
1638         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1639         (dwarf2_get_dwz_file): Likewise.
1640         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1641         (dwarf2_get_dwz_file): Likewise.
1642
1643 2019-06-16  Tom Tromey  <tom@tromey.com>
1644
1645         * coffread.c (process_coff_symbol): Use xstrdup.
1646         * value.c (create_internalvar): Use xstrdup.
1647
1648 2019-06-16  Tom Tromey  <tom@tromey.com>
1649
1650         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1651         * breakpoint.c (stopin_command, stopat_command)
1652         (until_break_command, decode_location_default): Remove unnecessary
1653         cast.
1654         * utils.c (subset_compare): Remove unnecessary cast.
1655         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1656         cast.
1657         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1658         cast.
1659         * infcmd.c (path_command): Remove unnecessary cast.
1660         * coffread.c (decode_type): Remove unnecessary cast.
1661         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1662         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1663         * tui/tui-stack.c (tui_show_locator_content)
1664         (tui_show_frame_info): Remove unnecessary cast.
1665         * tui/tui-win.c (tui_scroll_forward_command)
1666         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1667         (parse_scrolling_args): Remove unnecessary cast.
1668         * tui/tui-data.c (init_win_info, tui_del_window)
1669         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1670         (free_content_elements): Remove unnecessary cast.
1671         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1672         unnecessary cast.
1673         * tui/tui-source.c (tui_set_source_content)
1674         (tui_vertical_source_scroll): Remove unnecessary cast.
1675         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1676         cast.
1677         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1678         * tui/tui-regs.c (tui_display_registers_from)
1679         (tui_display_register): Remove unnecessary cast.
1680         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1681         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1682         (make_visible): Remove unnecessary cast.
1683         * tui/tui-winsource.c (tui_erase_source_content)
1684         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1685         unnecessary cast.
1686         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1687         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1688         * stabsread.c (read_type, read_array_type, read_range_type):
1689         Remove unnecessary cast.
1690         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1691         (parse_symbol, parse_type, upgrade_type, parse_external)
1692         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1693         unnecessary cast.
1694         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1695
1696 2019-06-16  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-data.c (tui_alloc_generic_win_info)
1699         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1700         checks.
1701
1702 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1703             Andrew Burgess  <andrew.burgess@embecosm.com>
1704
1705         * f-typeprint.c (f_print_type): Don't return early for not
1706         associated or not allocated types.
1707         (f_type_print_varspec_suffix): Add print_rank parameter and print
1708         ranks of array types in case they dangling.
1709         (f_type_print_base): Add print_rank parameter.
1710
1711 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1712
1713         * NEWS: Mention new MI commands.
1714         * break-catch-throw.c (enum exception_event_kind): Move to
1715         breakpoint.h.
1716         (print_mention_exception_catchpoint): Output text as a single
1717         message.
1718         (catch_exception_command_1): Rename to...
1719         (catch_exception_event): ...this, make non-static, update header
1720         command, and change some parameter types.
1721         (catch_catch_command): Update for changes to
1722         catch_exception_command_1.
1723         (catch_throw_command): Likewise.
1724         (catch_rethrow_command): Likewise.
1725         * breakpoint.c (enum exception_event_kind): Delete.
1726         * breakpoint.h (enum exception_event_kind): Moved here from
1727         break-catch-throw.c.
1728         (catch_exception_event): Declare.
1729         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1730         (mi_cmd_catch_throw): New function.
1731         (mi_cmd_catch_rethrow): New function.
1732         (mi_cmd_catch_catch): New function.
1733         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1734         'catch-catch' entries.
1735         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1736         (mi_cmd_catch_rethrow): Declare.
1737         (mi_cmd_catch_catch): Declare.
1738
1739 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1740
1741         * annotate.c (annotate_source_line): Change return type to void,
1742         update implementation to match.
1743         * annotate.h (annotate_source_line): Change return type to void,
1744         update header comment.
1745         * stack.c (print_frame_info): Don't change what frame information
1746         is printed based on whether annotations are on or not.
1747
1748 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1749
1750         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1751         (annotate_source): Make static.
1752         (annotate_source_line): Moved from source.c and renamed from
1753         identify_source_line.  Update the return type.
1754         * annotate.h (annotate_source): Delete declaration.
1755         (annotate_source_line): Declaration moved from source.h, and
1756         renamed from identify_source_line.  Return type updated.
1757         * source.c (identify_source_line): Moved to annotate.c and renamed
1758         to annotate_source_line.
1759         (info_line_command): Remove check of annotation_level.
1760         * source.h (identify_source_line): Move declaration to annotate.h
1761         and rename to annotate_source_line.
1762         * stack.c: Add 'annotate.h' include.
1763         (print_frame_info): Remove check of annotation_level before
1764         calling annotate_source_line.
1765
1766 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1767
1768         * source-cache.c (source_cache::get_plain_source_lines): Use
1769         open_source_file_with_line_charpos instead of just
1770         open_source_file, remove call to find_source_lines.
1771         (source_cache::get_source_lines): Likewise.
1772         * source.c (find_source_lines): Make static.
1773         (get_filename_and_charpos): Renamed into...
1774         (open_source_file_with_line_charpos): ..this along with changes to
1775         return a scoped_fd, and some other minor clean ups.
1776         (identify_source_line): Use open_source_file_with_line_charpos.
1777         (search_command_helper): Use open_source_file_with_line_charpos
1778         instead of just open_source_file, remove call to
1779         find_source_lines.
1780         * source.h (open_source_file_with_line_charpos): Declare new
1781         function.
1782         (find_source_lines): Delete declaration.
1783
1784 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1785
1786         * source.c (get_filename_and_charpos): Remove fullname
1787         parameter.
1788         (identify_source_line): Update call to get_filename_and_charpos.
1789
1790 2019-06-14  Tom Tromey  <tromey@adacore.com>
1791
1792         PR gdb/24502:
1793         * ui-style.h (skip_ansi_escape): Update comment.
1794         * ui-file.h (class no_terminal_escape_file): New class.
1795         * ui-file.c (no_terminal_escape_file::write)
1796         (no_terminal_escape_file::puts): New methods.
1797         * cli/cli-logging.c (handle_redirections): Use
1798         no_terminal_escape_file.
1799
1800 2019-06-14  Tom Tromey  <tromey@adacore.com>
1801
1802         * NEWS: Move convenience variable news above Python news.
1803
1804 2019-06-14  Tom Tromey  <tom@tromey.com>
1805
1806         * gnulib: Move directory to top-level.
1807         * configure.ac: Don't configure gnulib.
1808         * configure: Rebuild.
1809         * common/common-defs.h: Use new path to gnulib.
1810         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1811         (GNULIB_H): Remove.
1812         (INCGNU): Look in new gnulib location.
1813         (HFILES_NO_SRCDIR): Remove gnulib files.
1814         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1815         (generated_files): Remove GNULIB_H.
1816         ($(LIBGNU), all-lib): Remove targets.
1817         (distclean): Don't mention GNULIB_BUILDDIR.
1818         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1819
1820 2019-06-14  Tom Tromey  <tromey@adacore.com>
1821
1822         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1823         Warn if symbol file does not provide any symbols.
1824
1825 2019-06-14  Tom Tromey  <tromey@adacore.com>
1826
1827         * source.c (find_and_open_source): Respect basenames_may_differ.
1828
1829 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1830
1831         * annotate.c (annotate_breakpoints_invalid): Make use of
1832         scoped_restore_terminal_state.
1833         (annotate_frames_invalid): Likewise.
1834
1835 2019-06-14  Tom Tromey  <tromey@adacore.com>
1836
1837         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1838         allow assignment to an internalvar.
1839
1840 2019-06-14  Tom Tromey  <tromey@adacore.com>
1841
1842         * ada-lex.l: Allow "_" in attribute names.
1843
1844 2019-06-14  Tom Tromey  <tromey@adacore.com>
1845
1846         PR gdb/24653:
1847         * regcache.c (registers_changed): Don't call alloca.
1848         * top.c (execute_command): Don't call alloca.
1849
1850 2019-06-13  Pedro Alves  <palves@redhat.com>
1851
1852         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1853         'expression'.  When parsing an expression, error out if there's
1854         junk after "unlimited".
1855         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1856         (do_set_command): Adjust calls to is_unlimited_literal.
1857
1858 2019-06-13  Pedro Alves  <palves@redhat.com>
1859
1860         * compile/compile.c (make_compile_options_def_group): Add braces
1861         around array_view initializer.
1862         * thread.c (make_thread_apply_all_options_def_group)
1863         (make_thread_apply_all_options_def_group): Likewise.
1864
1865 2019-06-13  Pedro Alves  <palves@redhat.com>
1866
1867         * NEWS (New commands): Mention "maint test-options
1868         require-delimiter", "maint test-options unknown-is-error", "maint
1869         test-options unknown-is-operand" and "maint show
1870         test-options-completion-result".
1871         (New command options, command completion): New section.
1872         (Completion improvements): New section.
1873         Mention that you can abbreviate "unlimited".
1874
1875 2019-06-13  Pedro Alves  <palves@redhat.com>
1876
1877         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1878         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1879         * unittests/cli-utils-selftests.c (test_parse_flags)
1880         (test_parse_flags_qcs): Delete.
1881         (test_cli_utils): Don't call deleted functions.
1882
1883 2019-06-13  Pedro Alves  <palves@redhat.com>
1884
1885         * thread.c: Include "cli/cli-option.h".
1886         (tp_array_compar_ascending): Global.
1887         (tp_array_compar): Delete function.
1888         (tp_array_compar_ascending, tp_array_compar_descending): New
1889         functions.
1890         (ascending_option_def, qcs_flag_option_def)
1891         (thr_qcs_flags_option_defs)
1892         (make_thread_apply_all_options_def_group)
1893         (make_thread_apply_options_def_group): New.
1894         (thread_apply_all_command): Use gdb::option::process_options.
1895         (thread_apply_command_completer)
1896         (thread_apply_all_command_completer): New.
1897         (thread_apply_command): Use gdb::option::process_options.
1898         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1899         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1900         to generate help text of "thread apply".  Adjust "taas"'s help.
1901         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1902         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1903
1904 2019-06-13  Pedro Alves  <palves@redhat.com>
1905
1906         * thread.c (thread_apply_command): Check for invalid TID with
1907         isdigit instead of !isalpha.
1908
1909 2019-06-13  Pedro Alves  <palves@redhat.com>
1910
1911         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1912         (validate_flags_qcs): New.
1913         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1914         (validate_flags_qcs): Declare.
1915         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1916         (make_frame_apply_options_def_group): New.
1917         (frame_apply_command_count): Process options with
1918         gdb::option::process_options.
1919         (frame_apply_completer): New.
1920         (frame_apply_level_completer, frame_apply_all_completer)
1921         (frame_apply_completer): New.
1922         (_initialize_stack): Update help of "frame apply", "frame apply
1923         level", "frame apply all" and "faas" to mention supported options
1924         and install command completers.
1925         * stack.h (frame_apply_all_completer): Declare.
1926         * thread.c: Include "stack.h".
1927         (tfaas_command): Add "--".
1928         (_initialize_thread): Update help "tfaas" to mention supported
1929         options and install command completer.
1930
1931 2019-06-13  Pedro Alves  <palves@redhat.com>
1932
1933         * completer.c (complete_nested_command_line): New.
1934         (gdb_completion_word_break_characters_throw): Add assertion.
1935         * completer.h (complete_nested_command_line): Declare.
1936
1937 2019-06-13  Pedro Alves  <palves@redhat.com>
1938
1939         * stack.c (parse_backtrace_qualifiers): New.
1940         (backtrace_command): Use it.
1941         (backtrace_command_completer): Complete on qualifiers.
1942
1943 2019-06-13  Pedro Alves  <palves@redhat.com>
1944
1945         * frame.c: Include "cli/cli-option.h.
1946         (user_set_backtrace_options): New.
1947         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1948         Delete.
1949         (get_prev_frame): Adjust.
1950         (boolean_option_def, uinteger_option_def)
1951         (set_backtrace_option_defs): New.
1952         (_initialize_frame): Adjust and use
1953         gdb::option::add_setshow_cmds_for_options to install "set
1954         backtrace past-main" and "set backtrace past-entry".
1955         * frame.h: Include "cli/cli-option.h".
1956         (struct frame_print_options): Forward declare.
1957         (print_frame_arguments_all, print_frame_arguments_scalars)
1958         (print_frame_arguments_none): Declare.
1959         (print_entry_values): Delete declaration.
1960         (struct frame_print_options, user_frame_print_options): New.
1961         (struct set_backtrace_options): New.
1962         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1963         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1964         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1965         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1966         (list_args_or_locals): Add frame_print_options parameter.
1967         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1968         * python/py-framefilter.c (enumerate_args): Pass down
1969         USER_FRAME_PRINT_OPTIONS.
1970         * stack.c: Include "cli/cli-option.h".
1971         (print_frame_arguments_all, print_frame_arguments_scalars)
1972         (print_frame_arguments_none): Declare.
1973         (print_raw_frame_arguments, print_entry_values): Delete.
1974         (user_frame_print_options): New.
1975         (boolean_option_def, enum_option_def, frame_print_option_defs):
1976         New.
1977         (struct backtrace_cmd_options): New.
1978         (bt_flag_option_def): New.
1979         (backtrace_command_option_defs): New.
1980         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1981         (print_frame_arg, read_frame_arg, print_frame_args)
1982         (print_frame_info, print_frame): Add frame_print_options parameter
1983         and use it.
1984         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1985         (backtrace_command_1): Add frame_print_options and
1986         backtrace_cmd_options parameters and use them.
1987         (make_backtrace_options_def_group): New.
1988         (backtrace_command): Process command options with
1989         gdb::option::process_options.
1990         (backtrace_command_completer): New.
1991         (_initialize_stack): Extend "backtrace"'s help to mention
1992         supported options.  Install completer for "backtrace".
1993         Install some settings commands with add_setshow_cmds_for_options.
1994
1995 2019-06-13  Pedro Alves  <palves@redhat.com>
1996
1997         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1998         and that "set/show print raw frame-arguments" are now deprecated.
1999
2000         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2001         command.
2002         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2003         * stack.c (_initialize_stack): Install "set/show print
2004         raw-frame-arguments", and deprecate "set/show print raw
2005         frame-arguments".
2006         * valprint.c (_initialize_valprint): Deprecate "set/show print
2007         raw".
2008
2009 2019-06-13  Pedro Alves  <palves@redhat.com>
2010
2011         * compile/compile.c (struct compile_options): New.
2012         (compile_flag_option_def, compile_command_option_defs)
2013         (make_compile_options_def_group): New.
2014         (compile_file_command): Handle options with
2015         gdb::option::process_options.
2016         (compile_file_command_completer): New function.
2017         (compile_code_command): Handle options with
2018         gdb::option::process_options.
2019         (compile_code_command_completer): New function.
2020         (_initialize_compiler): Install completers for "compile code" and
2021         "compile file".  Mention available options in "compile code" and
2022         "compile code"'s help.
2023         * completer.c (advance_to_completion_word): New, factored out from
2024         ...
2025         (advance_to_expression_complete_word_point): ... this.
2026         (advance_to_filename_complete_word_point): New.
2027         * completer.h (advance_to_filename_complete_word_point): New
2028         declaration.
2029
2030 2019-06-13  Pedro Alves  <palves@redhat.com>
2031
2032         * compile/compile.c: Include "cli/cli-option.h".
2033         (compile_print_value): Scope data pointer is now a
2034         value_print_options pointer; adjust.
2035         (compile_print_command): Process options.  Scope data pointer is
2036         now a value_print_options pointer; adjust.
2037         (_initialize_compile): Update "compile print"'s help to include
2038         supported options.  Install a completer for "compile print".
2039         * cp-valprint.c (show_vtblprint, show_objectprint)
2040         (show_static_field_print): Delete.
2041         (_initialize_cp_valprint): Don't install "set print
2042         static-members", "set print vtbl", "set print object" here.
2043         * printcmd.c: Include "cli/cli-option.h" and
2044         "common/gdb_optional.h".
2045         (print_command_parse_format): Rework to fill in a
2046         value_print_options instead of a format_data.
2047         (print_value): Change parameter type from format_data pointer to
2048         value_print_options reference.  Adjust.
2049         (print_command_1): Process options.  Adjust to pass down a
2050         value_print_options.
2051         (print_command_completer): New.
2052         (_initialize_printcmd): Install print_command_completer as
2053         handle_brkchars completer for the "print" command.  Update
2054         "print"'s help to include supported options.
2055         * valprint.c: Include "cli/cli-option.h".
2056         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2057         here from cp-valprint.c.
2058         (boolean_option_def, uinteger_option_def)
2059         (value_print_option_defs, make_value_print_options_def_group):
2060         New.  Use gdb::option::add_setshow_cmds_for_options to install
2061         "set print elements", "set print null-stop", "set print repeats",
2062         "set print pretty", "set print union", "set print array", "set
2063         print address", "set print symbol", "set print array-indexes".
2064         * valprint.h: Include <string> and "cli/cli-option.h".
2065         (make_value_print_options_def_group): Declare.
2066         (print_value): Change parameter type from format_data pointer to
2067         value_print_options reference.
2068         (print_command_completer): Declare.
2069
2070 2019-06-13  Pedro Alves  <palves@redhat.com>
2071
2072         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2073         (COMMON_SFILES): Add maint-test-settings.c.
2074         * cli/cli-decode.c (boolean_enums): New global, factored out from
2075         ...
2076         (add_setshow_boolean_cmd): ... here.
2077         * cli/cli-decode.h (boolean_enums): Declare.
2078         * cli/cli-option.c: New file.
2079         * cli/cli-option.h: New file.
2080         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2081         factored out from ...
2082         (parse_cli_boolean_value(const char *)): ... this.
2083         (is_unlimited_literal): Change parameter type to pointer to
2084         pointer.  Adjust and advance ARG pointer.
2085         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2086         (parse_cli_var_enum): New, factored out from ...
2087         (do_set_command): ... this.  Adjust.
2088         * cli/cli-setshow.h (parse_cli_boolean_value)
2089         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2090         (parse_cli_var_enum): Declare.
2091         * cli/cli-utils.c: Include "cli/cli-option.h".
2092         (get_ulongest): New.
2093         * cli/cli-utils.h (get_ulongest): Declare.
2094         (check_for_argument): New overloads.
2095         * maint-test-options.c: New file.
2096
2097 2019-06-13  Pedro Alves  <palves@redhat.com>
2098
2099         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2100         parse a range if "-" is at the end of the string.
2101
2102 2019-06-13  Pedro Alves  <palves@redhat.com>
2103
2104         * cli/cli-setshow.c (parse_auto_binary_operation)
2105         (parse_cli_boolean_value): Don't allow "o".
2106
2107 2019-06-13  Pedro Alves  <palves@redhat.com>
2108
2109         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2110         * NEWS: Mention maint test-settings KIND.
2111         * maint-test-settings.c: New file.
2112
2113 2019-06-13  Pedro Alves  <palves@redhat.com>
2114
2115         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2116         completer.
2117         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2118         "set" completers.
2119
2120 2019-06-13  Pedro Alves  <palves@redhat.com>
2121
2122         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2123         after item.
2124
2125 2019-06-13  Pedro Alves  <palves@redhat.com>
2126
2127         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2128
2129 2019-06-13  Pedro Alves <palves@redhat.com>
2130
2131         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2132         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2133         call.
2134         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2135         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2136         calls.
2137         (check_for_argument): Skip spaces after argument.
2138
2139 2019-06-13  Pedro Alves  <palves@redhat.com>
2140
2141         * thread.c (thread_apply_command): Adjust TID parsing.
2142         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2143         detected before end of string.
2144         (tid_is_in_list): Error out if LIST is invalid.
2145
2146 2019-06-13  Pedro Alves  <palves@redhat.com>
2147
2148         * completer.c (complete_line_internal_1): Rewind completion word
2149         point.
2150         (completion_tracker::advance_custom_word_point_by): Change
2151         parameter type to int.
2152         * completer.h (completion_tracker::advance_custom_word_point_by):
2153         Likewise.
2154
2155 2019-06-13  Pedro Alves  <palves@redhat.com>
2156
2157         * completer.c (advance_to_completion_word): Handle delimiters.
2158
2159 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2160
2161         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2162
2163 2019-06-11  Tom Tromey  <tom@tromey.com>
2164
2165         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2166         (xmalloc_failed): Move to alloc.c.
2167         * alloc.c: New file.
2168         * Makefile.in (COMMON_SFILES): Add alloc.c.
2169
2170 2019-06-11  Tom Tromey  <tom@tromey.com>
2171
2172         * nat/linux-waitpid.c: Don't include server.h.
2173         (linux_debug): Remove.
2174         (my_waitpid): Update.
2175
2176 2019-06-11  Tom Tromey  <tromey@adacore.com>
2177
2178         * infcall.c (_initialize_infcall): Remove trailing newline from
2179         help.
2180         * user-regs.c (_initialize_user_regs): Remove trailing newline
2181         from help.
2182         * typeprint.c (_initialize_typeprint): Remove trailing newline
2183         from help.
2184         * reverse.c (_initialize_reverse): Remove trailing newlines from
2185         help.
2186         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2187         from help.
2188         * language.c (add_set_language_command): Remove trailing newline
2189         from help.
2190         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2191         help.
2192         * disasm.c (_initialize_disasm): Remove trailing newline from
2193         help.
2194         * top.c (init_main): Remove trailing newline from help.
2195         * interps.c (_initialize_interpreter): Remove trailing newline
2196         from help.
2197         * btrace.c (_initialize_btrace): Remove trailing newlines from
2198         help.
2199         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2200         from help.
2201         * python/python.c (_initialize_python): Remove trailing newline
2202         from help.
2203         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2204         help.
2205         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2206         from help.  Reformat some text.
2207         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2208         from help.
2209         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2210         newline from help.
2211
2212 2019-06-11  Tom Tromey  <tromey@adacore.com>
2213
2214         * darwin-nat.c (darwin_decode_exception_message)
2215         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2216
2217 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2218
2219         * valops.c (value_slice): Check for not allocated or not
2220         associated values.
2221
2222 2019-06-10  Tom de Vries  <tdevries@suse.de>
2223
2224         PR gdb/24618
2225         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2226         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2227         invalid.
2228
2229 2019-06-10  Tom de Vries  <tdevries@suse.de>
2230
2231         PR gdb/24611
2232         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2233         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2234
2235 2019-06-10  Tom de Vries  <tdevries@suse.de>
2236
2237         PR symtab/24545
2238         * symtab.c (struct demangled_name_entry): Add language field.
2239         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2240         static minimal symbol".  Set and use language field.
2241
2242 2019-06-10  Tom Tromey  <tromey@adacore.com>
2243
2244         * ada-lang.c (_initialize_ada_language): Update help text.
2245
2246 2019-06-10  Tom Tromey  <tromey@adacore.com>
2247
2248         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2249         with a newline.
2250         * guile/guile.c (handle_boot_error): Don't end warning with a
2251         newline.
2252         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2253         warning with a newline.
2254         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2255         newline.
2256         (s12z_frame_cache): Likewise.
2257         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2258         a newline.
2259         * solib-svr4.c (disable_probes_interface): Don't end warning with
2260         a newline.
2261         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2262         newline.
2263         * python/python.c (do_finish_initialization): Don't end warning
2264         with a newline.
2265
2266 2019-06-10  Tom Tromey  <tom@tromey.com>
2267
2268         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2269         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2270         gdbpy_enter.
2271
2272 2019-06-10  Tom Tromey  <tromey@adacore.com>
2273
2274         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2275         data.
2276         (elf_new_init): Don't call stabsread_new_init.
2277         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2278         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2279         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2280
2281 2019-06-10  Tom de Vries  <tdevries@suse.de>
2282
2283         PR symtab/16264
2284         PR symtab/24517
2285         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2286
2287 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2288
2289         * source.c (find_and_open_source): Also rewrite relative file
2290         names.
2291
2292 2019-04-26  Amos Bird  <amosbird@gmail.com>
2293
2294         * annotate.c (annotate_thread_exited): Add "thread-exited"
2295         annotation.
2296
2297 2019-06-06  Tom Tromey  <tromey@adacore.com>
2298
2299         * maint.h (class scoped_command_stats): Use
2300         DISABLE_COPY_AND_ASSIGN.
2301         <print_time>: New method.
2302         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2303         print_time.
2304         (scoped_command_stats::print_time): New method.
2305
2306 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2309         instructions of lengths 6 or 8 bytes.
2310
2311 2019-06-04  Pedro Alves  <palves@redhat.com>
2312
2313         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2314
2315         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2316         * breakpoint.c (condition_completer): Likewise.
2317         * cli/cli-dump.c (scan_expression): Likewise.
2318         * common/filestuff.c (mkdir_recursive): Likewise.
2319         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2320         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2321         (gdb_abspath): Likewise.
2322         * compile/compile-cplus-types.c
2323         (compile_cplus_instance::decl_name): Likewise.
2324         * completer.c (complete_explicit_location):
2325         (signal_completer, reg_or_group_completer_1): Likewise.
2326         * cp-support.c (cp_remove_params_if_any): Likewise.
2327         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2328         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2329         * infcmd.c (strip_bg_char): Likewise.
2330         * linespec.c (copy_token_string): Likewise.
2331         * mi/mi-main.c (output_cores): Likewise.
2332         * psymtab.c (psymtab_search_name):
2333         * symfile.c (test_set_ext_lang_command): Likewise.
2334         * target.c (target_fileio_read_stralloc): Likewise.
2335         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2336         * value.c (complete_internalvar): Likewise.
2337
2338 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2339
2340         Add objfile property to gdb.Type.
2341         * NEWS: Mention Python API addition.
2342         * python/py-type.c (typy_get_objfile): New method.
2343
2344 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2345
2346         * NEWS: Mention the new set|show style [title|highlight].
2347         Mention changes to "show style", "help" and "apropos".
2348
2349 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2350
2351         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2352         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2353         instead of print_help_for_command.
2354         (print_doc_of_command): New function.
2355         (help_list): Add 'apropos -v word' suggestion.
2356         (print_help_for_command): Style the command name using title style.
2357         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2358         (_initialize_cli_cmds): Describe -v in apropos_command help.
2359
2360 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2361
2362         * cli/cli-style.h (cli_style_option): Add name in constructor,
2363         add m_name class member, add constructor with intensity,
2364         add name class function.
2365         (cli_style_option::add_setshow_commands): Remove name argument.
2366         (highlight_style, title_style): New styles.
2367         * cli/cli-style.c (do_show): New function that shows a style
2368         characteristic styling the style name with itself.
2369         (set_style_name): New function.
2370         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2371         Update all callers according to the changes in cli/cli-style.h.
2372         * utils.h (fputs_highlighted): New function.
2373         * utils.c (fputs_highlighted): Likewise.
2374
2375 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2376
2377         * NEWS: Mention new pipe command and new convenience variables.
2378
2379 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2380
2381         * cli/cli-cmds.c (pipe_command): New function.
2382         (_initialize_cli_cmds): Call add_com for pipe_command.
2383         Define | as an alias for pipe.
2384         (exit_status_set_internal_vars): New function.
2385         (shell_escape): Call exit_status_set_internal_vars.
2386         cli/cli-decode.c (find_command_name_length): Recognize | as
2387         a single character command.
2388
2389 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2390
2391         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2392         top.c (execute_command_to_ui_file): New function, mostly a copy
2393         of execute_command_to_string.
2394         (execute_command_to_string): Implement by calling
2395         execute_command_to_ui_file.
2396
2397 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2398
2399         * top.h (saved_command_line): Remove declaration.
2400         * top.c (previous_saved_command_line, previous_repeat_arguments):
2401         New variables.
2402         (saved_command_line): Make static, define together with other
2403         'repeat variables'.
2404         (dont_repeat): Clear repeat_arguments.
2405         (repeat_previous, get_saved_command_line, save_command_line):
2406         New functions.
2407         (gdb_init): Initialize saved_command_line
2408         and previous_saved_command_line.
2409         * main.c (captured_main_1): Remove saved_command_line initialization.
2410         * event-top.c (handle_line_of_input): Update to use
2411         the new 'repeat' related functions instead of direct access to
2412         saved_command_line.
2413         * command.h (repeat_previous, get_saved_command_line,
2414         save_command_line): New declarations.
2415         (dont_repeat): Add comment.
2416
2417 2019-05-30  Tom Tromey  <tromey@adacore.com>
2418
2419         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2420         Fix comment.
2421         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2422
2423 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2424
2425         PR cli/24587
2426         * completer.c (complete): Initialize variable word.
2427
2428 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2429
2430         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2431         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2432         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2433         'body' is NULL to the outter 'if', protecting the '!is_define'
2434         situation as well.
2435
2436 2019-05-29  Tom Tromey  <tromey@adacore.com>
2437
2438         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2439         (dwarf_unknown): New function.
2440         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2441         (dwarf_type_encoding_name): Use dwarf_unknown.
2442
2443 2019-05-29  Tom Tromey  <tromey@adacore.com>
2444
2445         PR c++/20020:
2446         * cp-valprint.c (cp_print_value_fields): Call
2447         cp_print_static_field inside "try".
2448
2449 2019-05-29  Tom Tromey  <tromey@adacore.com>
2450
2451         * inflow.c (struct terminal_info): Add default operator=.
2452         * configure: Rebuild.
2453         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2454         -Wdeprecated-copy-dtor, -Wredundant-move.
2455
2456 2019-05-29  Tom Tromey  <tromey@adacore.com>
2457
2458         * NEWS: Add entry.
2459         * infcmd.c (print_return_value_1): Handle finish_print
2460         option.
2461         (show_print_finish): New function.
2462         (_initialize_infcmd): Add "set/show print finish" commands.
2463         * valprint.c (user_print_options): Initialize new member.
2464         * valprint.h (struct value_print_options) <finish_print>: New
2465         member.
2466
2467 2019-05-28  Tom Tromey  <tromey@adacore.com>
2468
2469         * ada-lang.c (ada_remove_Xbn_suffix)
2470         (find_old_style_renaming_symbol)
2471         (parse_old_style_renaming): Remove.
2472         (ada_find_renaming_symbol): Don't call
2473         find_old_style_renaming_symbol.
2474         (ada_is_renaming_symbol): Rename from
2475         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2476         bool.  Now static.
2477         (ada_read_var_value): Update and simplify.
2478         * ada-exp.y (write_var_or_type): Remove old code.
2479
2480 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2481
2482         * event-top.c: Remove include comment.
2483         * inflow.c (class scoped_ignore_sigttou): Move from here...
2484         * inflow.h (class scoped_ignore_sigttou): ...to here.
2485         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2486         * top.c:  Remove include comment.
2487
2488 2019-05-27  Tom Tromey  <tom@tromey.com>
2489
2490         * NEWS: Fix typo.
2491
2492 2019-05-22  Tom Tromey  <tromey@adacore.com>
2493
2494         * target.c (target_follow_exec): Constify parameter.
2495         * target-delegates.c: Rebuild.
2496         * remote.c (remote_target::follow_exec): Constify parameter.
2497         * infrun.c (follow_exec): Constify parameter.
2498         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2499         (target_follow_exec): Likewise.
2500
2501 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2502
2503         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2504         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2505
2506 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2507
2508         * NEWS: Add debugredirect and testsuite sections.
2509
2510 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2511
2512         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2513         target descriptions using exclusively floating point register name
2514         aliases.
2515
2516 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2517
2518         PR gdb/18644:
2519         * f-lang.c (build_fortran_types): Handle the case where
2520         gdbarch_floatformat_for_type returns a nullptr.
2521
2522 2019-05-21  Tom de Vries  <tdevries@suse.de>
2523
2524         PR cli/24587
2525         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2526
2527 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2528
2529         PR gdb/18644:
2530         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2531         16-byte floats.
2532         * i386-tdep.c (i386_floatformat_for_type): Use
2533         floatformats_ia64_quad for the 16-byte floating point component
2534         within a fortran 32-byte complex number.
2535
2536 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2537
2538         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2539         delete default constructor.
2540         (find_partial_die): Update to return const struct.
2541         (partial_die_parent_scope): Move variable declaration into scope
2542         of its use and change its type to auto.
2543         (guess_partial_die_structure_name): Likewise.
2544         (partial_die_info::fixup): Likewise.
2545
2546 2019-05-17  Tom Tromey  <tromey@adacore.com>
2547
2548         * source.c (find_and_open_source): Remove cast.
2549
2550 2019-05-17  Tom Tromey  <tromey@adacore.com>
2551
2552         * annotate.c (annotate_source): Make "filename" const.
2553         * annotate.h (annotate_source): Use const.
2554
2555 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2556
2557         * disasm.c (set_disassembler_options): Send errors to stderr.
2558
2559 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2560
2561         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2562         (cli_interp_base::set_logging): Check debug_redirect.
2563         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2564         * cli/cli-logging.c (debug_redirect): Add static variable.
2565         (pop_output_files): Add default param.
2566         (handle_redirections): Print debug setting.
2567         (show_logging_command): Likewise.
2568         (_initialize_cli_logging): Add debugredirect command.
2569         * interps.c (current_interp_set_logging): Add debug_redirect
2570         parameter.
2571         * interps.h (set_logging): Add debug_redirect parameter.
2572         (current_interp_set_logging): Likewise.
2573         * mi/mi-common.h: Likewise.
2574         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2575
2576 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2577             Tom Tromey  <tromey@adacore.com>
2578
2579         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2580         directly.
2581         * cli/cli-interp.h (make_logging_output): Remove declaration.
2582         * cli/cli-logging.c (make_logging_output): Remove function.
2583         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2584         directly.
2585         * ui-file.c (tee_file::tee_file): Remove bools.
2586         (tee_file::~tee_file): Remove deletes.
2587         * ui-file.h (tee_file): Remove bools.
2588
2589 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2590
2591         * mi/mi-cmds.h (mi_cmd_complete): New function.
2592         * mi/mi-main.c (mi_cmd_complete): Likewise.
2593         * mi/mi-cmds.c: Define new MI command -complete.
2594         * NEWS: Mention new -complete command.
2595
2596 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2597
2598         * completer.h (complete): New function.
2599         * completer.c (complete): Likewise.
2600         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2601         function defined in completer.h.
2602
2603 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2604
2605         * MAINTAINERS (Write After Approval): Add myself.
2606
2607 2019-05-17  Tom de Vries  <tdevries@suse.de>
2608
2609         PR gdb/24094
2610         * dwarf2read.c (struct cu_partial_die_info): New struct.
2611         (find_partial_die): Return cu_partial_die_info.
2612         (partial_die_parent_scope, guess_partial_die_structure_name)
2613         (partial_die_info::fixup): Handle new return type of find_partial_die.
2614
2615 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2616
2617         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2618         "std::string", simplifying the algorithm.
2619
2620 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2621
2622         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2623         (stap_static_probe_ops::get_probes): Likewise.
2624
2625 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2626
2627         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2628         '-')" and "else if".
2629         (stap_parse_single_operand): Join checks for
2630         "gdbarch_stap_parse_special_token_p" and
2631         "gdbarch_stap_parse_special_token" in the same "if" statement.
2632         Invert check when verifying for operation on register
2633         displacement.
2634
2635 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2636
2637         * stap-probe.c (stap_get_opcode): Update comment.
2638         (stap_get_expected_argument_type): Likewise.
2639         (handle_stap_probe): Likewise.
2640
2641 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2642
2643         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2644         return type to 'bool'.  Adjust comment.  Use 'bool' when
2645         appropriate.
2646         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2647         * stap-probe.c (stap_parse_argument_1): Likewise.
2648         (stap_is_operator): Likewise.
2649         (stap_is_generic_prefix): Likewise.
2650         (stap_is_register_prefix): Likewise.
2651         (stap_is_register_indirection_prefix): Likewise.
2652         (stap_is_integer_prefix): Likewise.
2653         (stap_generic_check_suffix): Likewise.
2654         (stap_check_integer_suffix): Likewise.
2655         (stap_check_register_suffix): Likewise.
2656         (stap_check_register_indirection_suffix): Likewise.
2657         (stap_parse_register_operand): Likewise.
2658         (stap_parse_single_operand): Likewise.
2659         (stap_parse_argument_1): Likewise.
2660         (stap_probe::get_argument_count): Likewise.
2661         (stap_is_operator): Likewise.
2662
2663 2019-05-16  Tom Tromey  <tromey@adacore.com>
2664
2665         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2666         keyword to foreach.
2667
2668 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2669
2670         * linux-thread-db.c (try_thread_db_load_1): Change return type
2671         to bool.
2672         (try_thread_db_load): Likewise.
2673         (try_thread_db_load_from_pdir_1): Likewise.
2674         (try_thread_db_load_from_pdir): Likewise.
2675         (try_thread_db_load_from_sdir): Likewise.
2676         (try_thread_db_load_from_dir): Likewise.
2677         (thread_db_load_search): Likewise.
2678         (has_libpthread): Likewise.
2679         (thread_db_load): Likewise.
2680
2681 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2682
2683         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2684         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2685         NULL, and complain/return if that's the case.
2686
2687 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2688
2689         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2690         (advance, posn, abstract_read_memory): New functions.
2691         [struct mem_read_abstraction]: New struct.
2692         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2693
2694 2019-05-14  Tom Tromey  <tromey@adacore.com>
2695
2696         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2697         value is not lval_memory.
2698
2699 2019-05-14  Tom Tromey  <tromey@adacore.com>
2700
2701         * solib.c (info_sharedlibrary_command): Style the file name.
2702
2703 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2704
2705         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2706         (aarch64_vnv_type): Likewise.
2707         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2708         * common/tdesc.c: Likewise.
2709         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2710         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2711         * features/aarch64-fpu.xml: Add ieee half view.
2712         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2713         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2714         * gdbtypes.h (struct builtin_type): Likewise.
2715         (struct objfile_type): Likewise.
2716
2717 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2718
2719         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2720         typo.
2721         * location.h (string_to_event_location): Likewise.
2722
2723 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2724
2725         GDB 8.3 released.
2726
2727 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2728
2729         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2730         New variable declaration.
2731         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2732         New variable.
2733         (print_one_breakpoint): Use ui_out::test_flags and new global
2734         variable to compute use_fixed_output.
2735         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2736         Remove.
2737         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2738         (mi_multi_location_breakpoint_output_fixed): Remove.
2739         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2740         new variable.
2741         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2742         fix_multi_location_breakpoint_output flag if version >= 3.
2743         * ui-out.h (enum ui_out_flag)
2744         <fix_multi_location_breakpoint_output>: New enumerator.
2745
2746 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2747
2748         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2749
2750 2019-05-10  Tom Tromey  <tromey@adacore.com>
2751
2752         * ada-lang.c (catch_ada_completer): New function.
2753         (_initialize_ada_language): Use it.
2754
2755 2019-05-10  Tom Tromey  <tromey@adacore.com>
2756
2757         * thread.c (print_thread_info): Make "requested_threads" const.
2758         * gdbthread.h (print_thread_info): Make "requested_threads"
2759         const.
2760         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2761         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2762
2763 2019-05-08  Tom Tromey  <tom@tromey.com>
2764
2765         * gdbtypes.c (objfile_type_data): Change type.
2766         (objfile_type, _initialize_gdbtypes): Update.
2767
2768 2019-05-08  Tom Tromey  <tom@tromey.com>
2769
2770         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2771         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2772         (_initialize_dwarf2_frame): Update.
2773
2774 2019-05-08  Tom Tromey  <tom@tromey.com>
2775
2776         * objc-lang.c (objc_objfile_data): Change type.
2777         (find_methods): Update.
2778         (_initialize_objc_lang): Remove.
2779
2780 2019-05-08  Tom Tromey  <tom@tromey.com>
2781
2782         * stabsread.c (rs6000_builtin_type_data): Change type.
2783         (rs6000_builtin_type, _initialize_stabsread): Update.
2784
2785 2019-05-08  Tom Tromey  <tom@tromey.com>
2786
2787         * mips-tdep.c (mips_pdr_data): Remove.
2788         (_initialize_mips_tdep): Update.
2789
2790 2019-05-08  Tom Tromey  <tom@tromey.com>
2791
2792         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2793         (hppa_init_objfile_priv_data, read_unwind_info)
2794         (find_unwind_entry, _initialize_hppa_tdep): Update.
2795
2796 2019-05-08  Tom Tromey  <tom@tromey.com>
2797
2798         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2799         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2800         on obstack.
2801         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2802
2803 2019-05-08  Tom Tromey  <tom@tromey.com>
2804
2805         * mdebugread.c (basic_type_data): Change type.
2806         (basic_type, _initialize_mdebugread): Update.
2807
2808 2019-05-08  Tom Tromey  <tom@tromey.com>
2809
2810         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2811
2812 2019-05-08  Tom Tromey  <tom@tromey.com>
2813
2814         * nto-tdep.c (nto_inferior_data_reg): Change type.
2815         (nto_inferior_data): Update.
2816         (nto_inferior_data_cleanup, nto_new_inferior_data)
2817         (_initialize_nto_tdep): Remove.
2818         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2819
2820 2019-05-08  Tom Tromey  <tom@tromey.com>
2821
2822         * ada-lang.c (struct ada_inferior_data): Add initializers.
2823         (ada_inferior_data): Change type.
2824         (ada_inferior_data_cleanup): Remove.
2825         (get_ada_inferior_data, ada_inferior_exit)
2826         (struct ada_pspace_data): Add initializers, destructor.
2827         (ada_pspace_data_handle): Change type.
2828         (get_ada_pspace_data): Update.
2829         (ada_pspace_data_cleanup): Remove.
2830
2831 2019-05-08  Tom Tromey  <tom@tromey.com>
2832
2833         * coffread.c (struct coff_symfile_info): Add initializers.
2834         (coff_objfile_data_key): Move lower.  Change type.
2835         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2836         Update.
2837         (coff_free_info): Remove.
2838
2839 2019-05-08  Tom Tromey  <tom@tromey.com>
2840
2841         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2842         (fbsd_pspace_data_handle): Move lower.  Change type.
2843         (get_fbsd_pspace_data): Update.
2844         (fbsd_pspace_data_cleanup): Remove.
2845         (_initialize_fbsd_tdep): Update.
2846
2847 2019-05-08  Tom Tromey  <tom@tromey.com>
2848
2849         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2850         (get_ada_tasks_pspace_data): Update.
2851         (ada_tasks_pspace_data_cleanup): Remove.
2852         (_initialize_tasks): Update.
2853         (ada_tasks_inferior_data_handle): Change type.
2854         (get_ada_tasks_inferior_data): Update.
2855         (ada_tasks_inferior_data_cleanup): Remove.
2856         (struct ada_tasks_pspace_data): Add initializers.
2857
2858 2019-05-08  Tom Tromey  <tom@tromey.com>
2859
2860         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2861         * symfile-debug.c (debug_sym_get_probes): Change type.
2862         * stap-probe.c (handle_stap_probe):
2863         (stap_static_probe_ops::get_probes): Change type.
2864         * probe.h (class static_probe_ops) <get_probes>: Change type.
2865         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2866         (parse_probes_in_pspace): Update.
2867         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2868         Update.
2869         (any_static_probe_ops::get_probes): Change type.
2870         * elfread.c (elfread_data): New typedef.
2871         (probe_key): Change type.
2872         (elf_get_probes): Likewise.  Update.
2873         (probe_key_free): Remove.
2874         (_initialize_elfread): Update.
2875         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2876         Change type.
2877         (dtrace_process_dof_probe, dtrace_process_dof)
2878         (dtrace_static_probe_ops::get_probe): Change type.
2879
2880 2019-05-08  Tom Tromey  <tom@tromey.com>
2881
2882         * xcoffread.c (struct xcoff_symfile_info): Rename from
2883         coff_symfile_info.  Add initializers.
2884         (xcoff_objfile_data_key): Move lower.  Change type.
2885         (XCOFF_DATA): Rewrite.
2886         (xcoff_free_info): Remove.
2887         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2888         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2889         (xcoff_initial_scan): Update.
2890
2891 2019-05-08  Tom Tromey  <tom@tromey.com>
2892
2893         * solib-svr4.c (struct svr4_info): Add initializers and
2894         destructor.
2895         <probes_table>: Now an htab_up.
2896         (solib_svr4_pspace_data): Change type.
2897         (free_probes_table): Simplify.
2898         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2899         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2900         (probes_table_remove_objfile_probes, register_solib_event_probe)
2901         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2902         (_initialize_svr4_solib): Update.
2903
2904 2019-05-08  Tom Tromey  <tom@tromey.com>
2905
2906         * remote.c (remote_pspace_data): Change type.
2907         (remote_pspace_data_cleanup): Remove.
2908         (get_remote_exec_file, set_pspace_remote_exec_file)
2909         (_initialize_remote): Update.
2910
2911 2019-05-08  Tom Tromey  <tom@tromey.com>
2912
2913         * breakpoint.c (breakpoint_objfile_key): Change type.
2914         (get_breakpoint_objfile_data): Update.
2915         (free_breakpoint_objfile_data): Remove.
2916         (_initialize_breakpoint): Update.
2917
2918 2019-05-08  Tom Tromey  <tom@tromey.com>
2919
2920         * linux-tdep.c (struct linux_info): Add initializers.
2921         (linux_inferior_data): Move.  Change type.
2922         (invalidate_linux_cache_inf): Update.
2923         (linux_inferior_data_cleanup): Remove.
2924         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2925
2926 2019-05-08  Tom Tromey  <tom@tromey.com>
2927
2928         * auxv.c (auxv_inferior_data): Move.  Change type.
2929         (auxv_inferior_data_cleanup): Remove.
2930         (invalidate_auxv_cache_inf): Rewrite.
2931         (get_auxv_inferior_data, _initialize_auxv): Update.
2932
2933 2019-05-08  Tom Tromey  <tom@tromey.com>
2934
2935         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2936         (symfile_debug_objfile_data_key): Change type.
2937         (symfile_debug_installed, debug_qf_has_symbols)
2938         (debug_qf_find_last_source_symtab)
2939         (debug_qf_forget_cached_source_info)
2940         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2941         (debug_qf_print_stats, debug_qf_dump)
2942         (debug_qf_expand_symtabs_for_function)
2943         (debug_qf_expand_all_symtabs)
2944         (debug_qf_expand_symtabs_with_fullname)
2945         (debug_qf_map_matching_symbols)
2946         (debug_qf_expand_symtabs_matching)
2947         (debug_qf_find_pc_sect_compunit_symtab)
2948         (debug_qf_map_symbol_filenames)
2949         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2950         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2951         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2952         (debug_sym_read_linetable, debug_sym_relocate): Update.
2953         (symfile_debug_free_objfile): Remove.
2954         (install_symfile_debug_logging, _initialize_symfile_debug):
2955         Update.
2956
2957 2019-05-08  Tom Tromey  <tom@tromey.com>
2958
2959         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2960         allocate_on_obstack.
2961         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2962         (get_dwarf2_per_objfile): Update.
2963         (set_dwarf2_per_objfile): Remove.
2964         (dwarf2_has_info, dwarf2_get_section_info): Update.
2965         (dwarf2_free_objfile): Remove.
2966         (_initialize_dwarf2_read): Update.
2967
2968 2019-05-08  Tom Tromey  <tom@tromey.com>
2969
2970         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2971         initializers.
2972         <unsupported_script_warning_printed,
2973         script_not_found_warning_printed>: Now bool.
2974         (auto_load_pspace_data): Change type.
2975         (~auto_load_pspace_info): Rename from
2976         auto_load_pspace_data_cleanup.
2977         (get_auto_load_pspace_data, init_loaded_scripts_info)
2978         (clear_section_scripts, maybe_print_unsupported_script_warning)
2979         (maybe_print_script_not_found_warning, _initialize_auto_load):
2980         Update.
2981
2982 2019-05-08  Tom Tromey  <tom@tromey.com>
2983
2984         * objfiles.c (objfile_pspace_info): Add destructor and
2985         initializers.
2986         (objfiles_pspace_data): Change type.
2987         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2988         (get_objfile_pspace_data): Update.
2989         (objfiles_bfd_data): Change type.
2990         (get_objfile_bfd_data): Update.
2991         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2992
2993 2019-05-08  Tom Tromey  <tom@tromey.com>
2994
2995         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2996         Change type.
2997         (get_catch_syscall_inferior_data): Update.
2998         (catch_syscall_inferior_data_cleanup): Remove.
2999         (_initialize_break_catch_syscall): Update.
3000
3001 2019-05-08  Tom Tromey  <tom@tromey.com>
3002
3003         * inflow.c (struct terminal_info): Add destructor and
3004         initializers.
3005         (inflow_inferior_data): Change type.
3006         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3007         (get_inflow_inferior_data, inflow_inferior_exit)
3008         (swap_terminal_info, _initialize_inflow): Update.
3009
3010 2019-05-08  Tom Tromey  <tom@tromey.com>
3011
3012         * target-dcache.c (target_dcache_cleanup): Remove.
3013         (target_dcache_aspace_key): Change type.
3014         (target_dcache_init_p, target_dcache_invalidate)
3015         (target_dcache_get, target_dcache_get_or_init)
3016         (_initialize_target_dcache): Update.
3017         * dcache.h (struct dcache_deleter): New.
3018
3019 2019-05-08  Tom Tromey  <tom@tromey.com>
3020
3021         * symtab.c (struct symbol_cache): Add destructor and
3022         initializers.
3023         (symbol_cache_key): Move.  Change type.
3024         (make_symbol_cache, free_symbol_cache): Remove.
3025         (get_symbol_cache): Update.
3026         (symbol_cache_cleanup): Remove.
3027         (ALL_PSPACES, symbol_cache_flush)
3028         (maintenance_print_symbol_cache)
3029         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3030         Update.
3031
3032 2019-05-08  Tom Tromey  <tom@tromey.com>
3033
3034         * symtab.c (struct main_info): Add destructor and initializers.
3035         (main_progspace_key): Move.  Change type.
3036         (get_main_info): Update.
3037         (main_info_cleanup): Remove.
3038         (_initialize_symtab): Update.
3039
3040 2019-05-08  Tom Tromey  <tom@tromey.com>
3041
3042         * registry.h (DECLARE_REGISTRY): Define the _key class.
3043
3044 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3045
3046         * NEWS: Merge two 'New commands' sections.
3047
3048 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3049
3050         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3051         parameter and use Ada language definition instead.
3052         (ada_val_print_ptr): Remove unused language parameter.
3053         (ada_val_print_num): Remove language parameter and use Ada language
3054         definition instead.
3055         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3056         parameter.
3057         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3058         parameter and use Ada language definition instead.
3059         (ada_val_print_1): Update all ada_val_print_xxx calls.
3060         Remove language parameter.
3061         (ada_val_print): Update ada_val_print_1 call.
3062
3063 2019-05-08  Tom Tromey  <tromey@adacore.com>
3064
3065         * remote.c (remote_hw_watchpoint_limit)
3066         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3067         Now static.
3068
3069 2019-05-08  Tom Tromey  <tromey@adacore.com>
3070
3071         * maint.c (_initialize_maint_cmds): Move initialization code to
3072         remote.c.
3073         (watchdog, show_watchdog): Move to remote.c.
3074         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3075         "watchdog" static.
3076         (_initialize_remote): Move initialization code from maint.c.
3077         * defs.h (watchdog): Don't declare.
3078
3079 2019-05-08  Tom Tromey  <tromey@adacore.com>
3080
3081         * tui/tui-interp.c: Include main.h.
3082         * interps.c: Include main.h.
3083         * main.h (interpreter_p): Declare.
3084         * defs.h (interpreter_p): Don't declare.
3085
3086 2019-05-08  Tom Tromey  <tromey@adacore.com>
3087
3088         * dwarf2loc.c: Include dwarf2read.h.
3089         * defs.h (read_unsigned_leb128): Don't declare.
3090         * dwarf2read.h (read_unsigned_leb128): Declare.
3091
3092 2019-05-08  Tom Tromey  <tromey@adacore.com>
3093
3094         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3095         method.
3096
3097 2019-05-08  Tom Tromey  <tromey@adacore.com>
3098
3099         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3100         when no wrap column is set.
3101
3102 2019-05-08  Tom Tromey  <tromey@adacore.com>
3103
3104         * c-lang.c (c_get_string): Handle non-C-style arrays.
3105
3106 2019-05-08  Tom Tromey  <tromey@adacore.com>
3107
3108         * typeprint.c (print_offset_data::update): Print the bit offset,
3109         not the number of bits remaining.
3110
3111 2019-05-08  Tom Tromey  <tromey@adacore.com>
3112
3113         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3114         padding at end of comment.
3115
3116 2019-05-08  Tom Tromey  <tromey@adacore.com>
3117
3118         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3119         Compare main types.
3120
3121 2019-05-06  Tom Tromey  <tom@tromey.com>
3122
3123         * common/scoped_mmap.c: Include common-defs.h.
3124         * common/scoped_mmap.h: Don't include config.h.
3125
3126 2019-05-04  Tom Tromey  <tom@tromey.com>
3127
3128         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3129         (struct aarch64_call_info): Add initializers.
3130         <si>: Now a std::vector.
3131         (pass_on_stack, aarch64_push_dummy_call): Update.
3132
3133 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3134             Tom Tromey  <tom@tromey.com>
3135
3136         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3137         (ppc_threads): Now a std::vector.  Now static.
3138         (hwdebug_find_thread_points_by_tid)
3139         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3140         Update.
3141
3142 2019-05-04  Tom Tromey  <tom@tromey.com>
3143
3144         * arc-tdep.c (arc_tdesc_init): Return bool.
3145
3146 2019-05-04  Tom Tromey  <tom@tromey.com>
3147
3148         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3149         Use gdb_assert_not_reached.
3150
3151 2019-05-04  Tom Tromey  <tom@tromey.com>
3152
3153         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3154         "false".
3155
3156 2019-05-04  Tom Tromey  <tom@tromey.com>
3157
3158         * arc-tdep.c (arc_tdesc_init): Use bool.
3159
3160 2019-05-04  Tom Tromey  <tom@tromey.com>
3161
3162         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3163
3164 2019-05-04  Tom Tromey  <tom@tromey.com>
3165
3166         * cli/cli-cmds.c (valid_command_p): Return bool.
3167
3168 2019-05-04  Tom Tromey  <tom@tromey.com>
3169
3170         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3171         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3172
3173 2019-05-04  Raul Tambre  <raul@tambre.ee>
3174
3175         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3176         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3177         operator for comparison.
3178
3179 2019-05-04  Tom Tromey  <tom@tromey.com>
3180
3181         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3182         (lookup_partial_symbol, print_partial_symbols)
3183         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3184         (psymbol_compare): Update.
3185         (add_psymbol_to_bcache): Clear the entire psymbol.
3186         (maintenance_check_psymtabs): Update.
3187         * psympriv.h (struct partial_symbol): Don't derive from
3188         general_symbol_info.
3189         <obj_section, unrelocated_address, address,
3190         set_unrelocated_address>: Update.
3191         <ginfo>: New member.
3192         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3193         (debug_names::write_psymbols): Update.
3194
3195 2019-05-04  Tom de Vries  <tdevries@suse.de>
3196
3197         * contrib/cc-with-tweaks.sh: Support -n arg.
3198
3199 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3200
3201         * corelow.c (core_target::detach): Ensure frame cache and
3202         register caches are cleared.
3203         inferior.c (exit_inferior_1): Likewise.
3204
3205 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3206             Tom Tromey  <tom@tromey.com>
3207
3208         * dictionary.c (collate_pending_symbols_by_language): Remove
3209         "struct" from foreach.
3210         * symtab.c (lookup_global_symbol_from_objfile)
3211         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3212         foreach.
3213         * ser-tcp.c (net_open): Remove "struct" from foreach.
3214         * objfiles.c (objfile_relocate, objfile_rebase)
3215         (objfile_has_symbols): Remove "struct" from foreach.
3216         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3217         from foreach.
3218         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3219         foreach.
3220         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3221         "struct" from foreach.
3222         * ada-lang.c (create_excep_cond_exprs)
3223         (ada_exception_catchpoint_cond_string): Remove "struct" from
3224         foreach.
3225
3226 2019-05-03  Tom Tromey  <tromey@adacore.com>
3227
3228         * ada-exp.y (convert_char_literal): Check suffix of each
3229         enumerator.
3230
3231 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3232
3233         PR ada/21406:
3234         * ada-exp.y (yywrap): Don't define.
3235         * ada-lex.l (%option): Add noyywrap
3236         (yywrap): Remove.
3237
3238 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3239
3240         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3241         _WIN32_WINNT to the XP level, unless already defined to a higher
3242         level.
3243
3244         * unittests/parse-connection-spec-selftests.c:
3245         * ser-tcp.c:
3246         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3247         override.
3248
3249         * symfile.c (find_separate_debug_file): Remove colon from the
3250         drive spec of DOS/Windows file names of the target, so that the
3251         file name produced from DEBUGDIR and the target's directory will
3252         be valid on DOS/Windows systems.
3253
3254 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3255
3256         * rust-lang.c (val_print_struct): Handle printing structures
3257         containing strings.
3258
3259 2019-05-02  Tom Tromey  <tromey@adacore.com>
3260
3261         * valarith.c (_initialize_valarith): Remove.
3262
3263 2019-05-01  Tom Tromey  <tromey@adacore.com>
3264
3265         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3266         bitfields.
3267
3268 2019-05-01  Tom Tromey  <tromey@adacore.com>
3269
3270         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3271         for big-endian copies.
3272
3273 2019-04-30  Ali Tamur  <tamur@google.com>
3274         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3275         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3276         (read_3_bytes): New function.
3277
3278 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3279
3280         * windows-nat.c (main_thread_id): Delete.
3281         (handle_output_debug_string): Replace main_thread_id by
3282         current_event.dwThreadId.
3283         (fake_create_process): Likewise.
3284         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3285         Do not set main_thread_id.
3286         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3287         current_event.dwThreadId.
3288         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3289
3290 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3291
3292         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3293         Use current_event.dwThreadId instead of main_thread_id.
3294
3295 2019-04-30  Tom Tromey  <tromey@adacore.com>
3296
3297         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3298         (create_excep_cond_exprs): Iterate over program spaces.
3299         (ada_exception_catchpoint_cond_string): Examine all minimal
3300         symbols for exception types.
3301
3302 2019-04-30  Tom Tromey  <tromey@adacore.com>
3303
3304         PR c++/24470:
3305         * dwarf2read.c (process_structure_scope): Handle case where type
3306         has template parameters but no symbol was created.
3307
3308 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3309             Chris January  <chris.january@arm.com>
3310
3311         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3312         qualifier.
3313         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3314
3315 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3316
3317         * f-typeprint.c (f_print_type): Update rules for printing
3318         whitespace.
3319         (f_type_print_varspec_suffix): Likewise.
3320
3321 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3322             Chris January  <chris.january@arm.com>
3323
3324         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3325         function arguments.
3326
3327 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3328
3329         * f-lang.c (build_fortran_types): Change name of void type to
3330         lower case.
3331         * f-typeprint.c (f_type_print_base): Print the name of the void
3332         type, rather than a fixed string.
3333         * f-valprint.c (f_decorations): Use lower case void string.
3334
3335 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3336             Chris January  <chris.january@arm.com>
3337
3338         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3339         types for Fortran.
3340
3341 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3342             Chris January  <chris.january@arm.com>
3343             David Lecomber  <david.lecomber@arm.com>
3344
3345         * f-exp.y (BINOP_INTRINSIC): New token.
3346         (exp): New parser rule handling BINOP_INTRINSIC.
3347         (f77_keywords): Add new builtin procedures.
3348         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3349         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3350         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3351         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3352         (print_unop_subexp_f): New function.
3353         (print_binop_subexp_f): New function.
3354         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3355         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3356         (dump_subexp_body_f): Likewise.
3357         (operator_check_f): Likewise.
3358         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3359         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3360
3361 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3362
3363         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3364         UNOP_KIND.
3365         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3366         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3367         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3368         (operator_length_f): New fuction.
3369         (print_subexp_f): New function.
3370         (op_name_f): New function.
3371         (dump_subexp_body_f): New function.
3372         (operator_check_f): New function.
3373         (exp_descriptor_f): Replace standard expression handling functions
3374         with new functions.
3375         * gdb/fortran-operator.def: New file.
3376         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3377         * gdb/std-operator.def: Remove UNOP_KIND.
3378
3379 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3380
3381         * std-operator.def: Remove unbalanced, stray double quote
3382         character.
3383
3384 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3385             Chris January  <chris.january@arm.com>
3386             Daniel Everett  <daniel.everett@arm.com>
3387             Nick Forrington  <nick.forrington@arm.com>
3388             Richard Bunt  <richard.bunt@arm.com>
3389
3390         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3391         of depth when printing anonymous structs or unions.
3392         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3393         Don't print either the top-level value, or the children if the
3394         max-depth is exceeded.
3395         (ppscm_print_children): When printing the key of a map, allow one
3396         extra level of depth.
3397         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3398         print either the top-level value, or the children if the max-depth
3399         is exceeded.
3400         (print_children): When printing the key of a map, allow one extra
3401         level of depth.
3402         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3403         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3404         (user_print_options): Initialise max_depth field.
3405         (val_print_scalar_or_string_type_p): New function.
3406         (val_print): Check to see if the max depth has been reached.
3407         (val_print_check_max_depth): Define new function.
3408         (show_print_max_depth): New function.
3409         (_initialize_valprint): Add 'print max-depth' option.
3410         * valprint.h (struct value_print_options) <max_depth>: New field.
3411         (val_print_check_max_depth): Declare new function.
3412         * NEWS: Document new feature.
3413
3414 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3415
3416         * ada-lang.c (ada_language_defn): Initialise new field.
3417         * c-lang.c (c_is_string_type_p): New function.
3418         (c_language_defn): Initialise new field.
3419         (cplus_language_defn): Initialise new field.
3420         (asm_language_defn): Initialise new field.
3421         (minimal_language_defn): Initialise new field.
3422         * c-lang.h (c_is_string_type_p): Declare new function.
3423         * d-lang.c (d_language_defn): Initialise new field.
3424         * f-lang.c (f_is_string_type_p): New function.
3425         (f_language_defn): Initialise new field.
3426         * go-lang.c (go_is_string_type_p): New function.
3427         (go_language_defn): Initialise new field.
3428         * language.c (default_is_string_type_p): New function.
3429         (unknown_language_defn): Initialise new field.
3430         (auto_language_defn): Initialise new field.
3431         * language.h (struct language_defn) <la_is_string_type_p>: New
3432         member variable.
3433         (default_is_string_type_p): Declare new function.
3434         * m2-lang.c (m2_language_defn): Initialise new field.
3435         * objc-lang.c (objc_language_defn): Initialise new field.
3436         * opencl-lang.c (opencl_language_defn): Initialise new field.
3437         * p-lang.c (pascal_is_string_type_p): New function.
3438         (pascal_language_defn): Initialise new field.
3439         * rust-lang.c (rust_is_string_type_p): New function.
3440         (rust_language_defn): Initialise new field.
3441
3442 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3443
3444         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3445         New field.
3446         * ada-lang.c (ada_language_defn): Initialise new field.
3447         * c-lang.c (c_language_defn): Likewise.
3448         (cplus_language_defn): Likewise.
3449         (asm_language_defn): Likewise.
3450         (minimal_language_defn): Likewise.
3451         * d-lang.c (d_language_defn): Likewise.
3452         * f-lang.c (f_language_defn): Likewise.
3453         * go-lang.c (go_language_defn): Likewise.
3454         * language.c (unknown_language_defn): Likewise.
3455         (auto_language_defn): Likewise.
3456         * m2-lang.c (m2_language_defn): Likewise.
3457         * objc-lang.c (objc_language_defn): Likewise.
3458         * opencl-lang.c (opencl_language_defn): Likewise.
3459         * p-lang.c (pascal_language_defn): Likewise.
3460         * rust-lang.c (rust_language_defn): Likewise.
3461
3462 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         * ada-lang.c (ada_is_character_type): Change return type to bool.
3465         (ada_is_string_type): Likewise.
3466         * ada-lang.h (ada_is_character_type): Update declaration
3467         (ada_is_string_type): Likewise.
3468
3469 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3470
3471         Support style in 'frame|thread apply'
3472
3473         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3474         * record.c (record_start, record_stop): Update callers of
3475         execute_command_to_string with false.
3476         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3477         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3478         methods.
3479         (class string_file): New constructor with term_out parameter.
3480         Override methods term_out and can_emit_style_escape.  New member
3481         term_out.
3482         (class stdio_file): Override can_emit_style_escape.
3483         (class tee_file): Override term_out and can_emit_style_escape.
3484         * utils.h (can_emit_style_escape): Remove.
3485         * utils.c (can_emit_style_escape): Likewise.
3486         Update all callers of can_emit_style_escape (SOMESTREAM) to
3487         SOMESTREAM->can_emit_style_escape.
3488         * source-cache.c (source_cache::get_source_lines): Likewise.
3489         * stack.c (frame_apply_command_count): Call execute_command_to_string
3490         passing the term_out characteristic of the current gdb_stdout.
3491         * thread.c (thr_try_catch_cmd): Likewise.
3492         * top.c (execute_command_to_string): pass term_out parameter
3493         to construct the string_file for the command output.
3494         * ui-file.c (term_cli_styling): New function (most code moved
3495         from utils.c can_emit_style_escape).
3496         (string_file::string_file, string_file::can_emit_style_escape,
3497         stdio_file::can_emit_style_escape, tee_file::term_out,
3498         tee_file::can_emit_style_escape): New functions.
3499
3500 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3501
3502         * NEWS: Mention the new set|show may-call-functions.
3503         * infcall.c (may_call_functions_p): New variable.
3504         (show_may_call_functions_p): New function.
3505         (call_function_by_hand_dummy): Throws an error if not
3506         may-call-functions.
3507         (_initialize_infcall): Call add_setshow_boolean_cmd for
3508         may-call-functions.
3509
3510 2019-04-25  Keith Seitz  <keiths@redhat.com>
3511
3512         PR c++/24367
3513         * cp-support.c (inspect_type): Don't attempt substitutions
3514         of symbol with the same name.
3515
3516 2019-04-25  Tom Tromey  <tromey@adacore.com>
3517
3518         PR gdb/24475:
3519         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3520         static.
3521
3522 2019-04-25  Tom Tromey  <tromey@adacore.com>
3523
3524         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3525         rvalue reference.
3526         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3527         (gdb_xml_parser::parse): Use std::move.
3528         * python/python-internal.h (gdbpy_convert_exception): Take a const
3529         reference.
3530         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3531         std::move.
3532         * python/py-utils.c (gdbpy_convert_exception): Take a const
3533         reference.
3534         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3535         Use std::move.
3536         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3537         Use std::move.
3538         * mi/mi-main.c (mi_print_exception): Take a const reference.
3539         * main.c (handle_command_errors): Take a const reference.
3540         * linespec.c (parse_linespec): Use std::move.
3541         * infcall.c (run_inferior_call): Use std::move.
3542         (call_function_by_hand_dummy): Use std::move.
3543         * exec.c (try_open_exec_file): Use std::move.
3544         * exceptions.h (exception_print, exception_fprintf)
3545         (exception_print_same): Update.
3546         * exceptions.c (print_exception, exception_print)
3547         (exception_fprintf, exception_print_same): Change parameters to
3548         const reference.
3549         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3550         * common/new-op.c: Use std::move.
3551         * common/common-exceptions.h (struct gdb_exception): Add move
3552         constructor.
3553         (struct gdb_exception_error, struct gdb_exception_quit, struct
3554         gdb_quit_bad_alloc): Change constructor to move constructor.
3555         (throw_exception): Change parameter to rvalue reference.
3556         * common/common-exceptions.c (throw_exception): Take rvalue
3557         reference.
3558         * cli/cli-interp.c (safe_execute_command): Use std::move.
3559         * breakpoint.c (insert_bp_location, location_to_sals): Use
3560         std::move.
3561
3562 2019-04-25  Tom Tromey  <tromey@adacore.com>
3563
3564         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3565         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3566         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3567         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3568         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3569         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3570         guile/scm-value.c: Use unpack.
3571         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3572         gdbscm_gdb_exception.
3573         (gdbscm_throw_gdb_exception): Likewise.
3574         (struct gdbscm_gdb_exception): New.
3575         (unpack): New function.
3576         (gdbscm_wrap): Use unpack.
3577
3578 2019-04-25  Tom Tromey  <tromey@adacore.com>
3579
3580         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3581         (gdb_rl_callback_handler): Use std::move.
3582         * common/common-exceptions.h (struct gdb_exception): Add move
3583         assignment operator.
3584         (throw_exception_sjlj): Change "exception" to const reference.
3585         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3586         (throw_exception_sjlj): Change "exception" to const reference.
3587
3588 2019-04-25  Tom Tromey  <tromey@adacore.com>
3589
3590         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3591         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3592         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3593         Update.
3594         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3595         Update.
3596         * mi/mi-interp.c (mi_interp::exec): Update.
3597         * linespec.c (parse_linespec): Update.
3598         * infcall.c (run_inferior_call): Update.
3599         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3600         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3601         (gdbscm_lookup_global_symbol): Update.
3602         * guile/scm-param.c (gdbscm_parameter_value): Update.
3603         * guile/scm-frame.c (gdbscm_frame_read_register)
3604         (gdbscm_frame_read_var): Update.
3605         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3606         * exec.c (try_open_exec_file): Update.
3607         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3608         (gdb_rl_callback_handler): Update.
3609         * common/common-exceptions.h (exception_none): Don't declare.
3610         * common/common-exceptions.c (exception_none): Don't define.
3611         (struct catcher) <exception>: Update.
3612         * cli/cli-interp.c (safe_execute_command): Update.
3613         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3614
3615 2019-04-25  Ali Tamur  <tamur@google.com>
3616
3617         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3618         (read_attribute_value): Likewise.
3619         (dwarf2_read_addr_index): Update comment.
3620         (read_str_index): Add DW_FORM_strx.
3621         (dwarf2_string_attr): Likewise.
3622         (dwarf2_const_value_attr): Likewise.
3623         (dump_die_shallow): Likewise.
3624         (dwarf2_fetch_constant_bytes): Likewise.
3625         (skip_form_bytes): Likewise.
3626         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3627
3628 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3629
3630         PR corefiles/11608
3631         PR corefiles/18187
3632         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3633         OFFSET.  Verify if current mapping contains an ELF header.
3634         (linux_find_memory_regions_full): Adjust call to
3635         dump_mapping_p.
3636
3637 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3638             Kang Li <kanglictf@gmail.com>
3639
3640         PR gdb/21600
3641
3642         * dwarf2-frame.c (read_initial_length): Be consistent about using
3643         unsigned representation of length.
3644         (decode_frame_entry_1): Likewise.  Check for wraparound of
3645         end pointer as well as buffer overflow.
3646
3647 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3648
3649         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3650         "vq".
3651
3652 2019-04-24  Tom Tromey  <tromey@adacore.com>
3653
3654         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3655
3656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3657
3658         * s12z-tdep.c (s12z_unwind_pc): Delete.
3659         (s12z_unwind_sp): Delete.
3660         (s12z_gdbarch_init): Don't register deleted functions with
3661         gdbarch.
3662
3663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3664
3665         * rl78-tdep.c (rl78_unwind_sp): Delete.
3666         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3667
3668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3669
3670         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3671         (xstormy16_unwind_pc): Delete.
3672         (xstormy16_dummy_id): Delete.
3673         (xstormy16_gdbarch_init): Don't register deleted functions with
3674         gdbarch.
3675
3676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3677
3678         * vax-tdep.c (vax_unwind_pc): Delete.
3679         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3680
3681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3682
3683         * v850-tdep.c (v850_unwind_sp): Delete.
3684         (v850_unwind_pc): Delete.
3685         (v850_dummy_id): Delete.
3686         (v850_gdbarch_init): Don't register deleted functions with
3687         gdbarch.
3688
3689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3690
3691         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3692         (tilegx_unwind_pc): Delete.
3693         (tilegx_unwind_dummy_id): Delete.
3694         (tilegx_gdbarch_init): Don't register deleted functions with
3695         gdbarch.
3696
3697 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3698
3699         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3700         (tic6x_dummy_id): Delete.
3701         (tic6x_gdbarch_init): Don't register deleted functions with
3702         gdbarch.
3703
3704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3705
3706         * sparc-tdep.c (sparc_unwind_pc): Delete.
3707         (sparc32_gdbarch_init): Don't register deleted function with
3708         gdbarch.
3709
3710 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3711
3712         * sh-tdep.c (sh_unwind_sp): Delete.
3713         (sh_unwind_pc): Delete.
3714         (sh_dummy_id): Delete.
3715         (sh_gdbarch_init): Don't register deleted functions with
3716         gdbarch.
3717
3718 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3719
3720         * score-tdep.c (score_unwind_sp): Delete.
3721         (score_unwind_pc): Delete.
3722         (score_dummy_id): Delete.
3723         (score_gdbarch_init): Don't register deleted functions with
3724         gdbarch.
3725
3726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3727
3728         * rx-tdep.c (rx_unwind_pc): Delete.
3729         (rx_unwind_sp): Delete.
3730         (rx_dummy_id): Delete.
3731         (rx_gdbarch_init): Don't register deleted functions with
3732         gdbarch.  Update comment.
3733
3734 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3735
3736         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3737         (rs6000_dummy_id): Delete.
3738         (rs6000_gdbarch_init): Don't register deleted functions with
3739         gdbarch.
3740
3741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3742
3743         * or1k-tdep.c (or1k_dummy_id): Delete.
3744         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3745
3746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * nios2-tdep.c (nios2_dummy_id): Delete.
3749         (nios2_unwind_sp): Delete.
3750         (nios2_gdbarch_init): Don't register deleted functions with
3751         gdbarch.
3752
3753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3754
3755         * nds32-tdep.c (nds32_dummy_id): Delete.
3756         (nds32_unwind_pc): Delete.
3757         (nds32_unwind_sp): Delete.
3758         (nds32_gdbarch_init): Don't register deleted functions with
3759         gdbarch.
3760
3761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3762
3763         * msp430-tdep.c (msp430_unwind_pc): Delete.
3764         (msp430_unwind_sp): Delete.
3765         (msp430_dummy_id): Delete.
3766         (msp430_gdbarch_init): Don't register deleted functions with
3767         gdbarch.
3768
3769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3770
3771         * moxie-tdep.c (moxie_unwind_sp): Delete.
3772         (moxie_unwind_pc): Delete.
3773         (moxie_dummy_id): Delete.
3774         (moxie_gdbarch_init): Don't register deleted functions with
3775         gdbarch.
3776
3777 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3778
3779         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3780         (mn10300_unwind_pc): Delete.
3781         (mn10300_unwind_sp): Delete.
3782         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3783         mn10300_unwind_sp.
3784         (mn10300_frame_unwind_init): Don't register deleted functions with
3785         gdbarch.
3786
3787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3788
3789         * mep-tdep.c (mep_unwind_pc): Delete.
3790         (mep_unwind_sp): Delete.
3791         (mep_dummy_id): Delete.
3792         (mep_gdbarch_init): Don't register deleted functions with
3793         gdbarch.
3794
3795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3796
3797         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3798         (m68hc11_unwind_sp): Delete.
3799         (m68hc11_gdbarch_init): Don't register deleted functions with
3800         gdbarch.
3801
3802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3803
3804         * m32r-tdep.c (m32r_unwind_sp): Delete.
3805         (m32r_unwind_pc): Delete.
3806         (m32r_dummy_id): Delete.
3807         (m32r_gdbarch_init): Don't register deleted functions with
3808         gdbarch.
3809
3810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * m32c-tdep.c (m32c_unwind_pc): Delete.
3813         (m32c_unwind_sp): Delete.
3814         (m32c_dummy_id): Delete.
3815         (m32c_gdbarch_init): Don't register deleted functions with
3816         gdbarch.
3817
3818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3819
3820         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3821         (lm32_unwind_pc): Delete.
3822         (lm32_dummy_id): Delete.
3823         (lm32_gdbarch_init): Don't register deleted functions with
3824         gdbarch.
3825
3826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3827
3828         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3829         (iq2000_unwind_pc): Delete.
3830         (iq2000_dummy_id): Delete.
3831         (iq2000_gdbarch_init): Don't register deleted functions with
3832         gdbarch.
3833
3834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * nds32-tdep.c (nds32_type_align): Delete.
3837         (nds32_push_dummy_call): Use type_align instead.
3838
3839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3840
3841         * arm-tdep.c (arm_type_align): Only handle vector override case.
3842         (arm_push_dummy_call): Use type_align.
3843         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3844
3845 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3846
3847         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3848         case.
3849         (pass_on_stack): Use type_align.
3850         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3851         function.
3852
3853 2019-04-23  Tom Tromey  <tromey@adacore.com>
3854
3855         * dwarf2read.c (line_header::file_name_at): Remove unused
3856         overload.
3857
3858 2019-04-23  Tom de Vries  <tdevries@suse.de>
3859
3860         PR gdb/24438
3861         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3862         invocation.
3863
3864
3865 2019-03-27  Ali Tamur  <tamur@google.com>
3866
3867         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3868         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3869         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3870         (dwarf_expr_context::get_addr_index): Likewise
3871         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3872         (symbol_needs_eval_context::get_addr_index): Likewise
3873         (disassemble_dwarf_expression): Add DW_OP_addrx
3874         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3875         (read_cutu_die_from_dwo): Update comment
3876         (skip_one_die): Add DW_FORM_addrx
3877         (read_attribute_value): Likewise
3878         (var_decode_location): Add DW_OP_addrx
3879         (dwarf2_const_value_attr): Add DW_FORM_addrx
3880         (dump_die_shallow): Likewise
3881         (dwarf2_fetch_constant_bytes): Likewise
3882         (decode_locdesc): Add DW_OP_addrx
3883         (skip_form_bytes): Add DW_FORM_addrx
3884
3885 2019-04-22  Ali Tamur  <tamur@google.com>
3886
3887         * MAINTAINERS (Write After Approval): Add self.
3888
3889 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3890
3891         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3892         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3893         (open_symbol_file_object): Likewise.
3894         (svr4_default_sos): Add info parameter.
3895         (svr4_read_so_list): Likewise.
3896         (svr4_current_sos_direct): Adjust functions calls to pass down
3897         info.
3898         (svr4_current_sos_1): Add info parameter.
3899         (svr4_current_sos): Call get_svr4_info, pass info down to
3900         svr4_current_sos_1.
3901         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3902         get_svr4_info.
3903         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3904         get_svr4_info.
3905         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3906         to get_svr4_info.
3907         (probes_table_remove_objfile_probes): Likewise.
3908         (register_solib_event_probe): Add info parameter.
3909         (solist_update_incremental): Pass info parameter down to
3910         svr4_read_so_list.
3911         (disable_probes_interface): Add info parameter.
3912         (svr4_handle_solib_event): Pass current_program_space to
3913         get_svr4_info.  Adjust disable_probes_interface cleanup.
3914         (svr4_create_probe_breakpoints): Add info parameter, pass it
3915         down to register_solib_event_probe.
3916         (svr4_create_solib_event_breakpoints): Add info parameter,
3917         pass it down to svr4_create_probe_breakpoints.
3918         (enable_break): Pass info down to
3919         svr4_create_solib_event_breakpoints.
3920         (svr4_solib_create_inferior_hook): Pass current_program_space to
3921         get_svr4_info.
3922         (svr4_clear_solib): Likewise.
3923
3924 2019-04-22  Pedro Alves  <palves@redhat.com>
3925
3926         * solib-svr4.c (svr4_free_objfile_observer): New.
3927         (probe_and_action::objfile): New field.
3928         (probes_table_htab_remove_objfile_probes)
3929         (probes_table_remove_objfile_probes): New functions.
3930         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3931         in the new probe_and_action.  Don't store the probe in 'lookup'.
3932         (svr4_create_probe_breakpoints): Pass objfile to
3933         register_solib_event_probe.
3934         (_initialize_svr4_solib): Register a free_objfile observer.
3935
3936 2019-04-19  Tom Tromey  <tom@tromey.com>
3937
3938         * common/queue.h: Remove.
3939
3940 2019-04-19  Tom Tromey  <tom@tromey.com>
3941
3942         * event-loop.c: Don't include "common/queue.h".
3943
3944 2019-04-19  Tom Tromey  <tom@tromey.com>
3945
3946         * remote.c (remote_target): Use delete.
3947         * remote-notif.h: Include <list>, not "common/queue.h".
3948         (notif_client_p): Remove typedef.
3949         (remote_notif_state): Add constructor, destructor, initializer.
3950         <notif_queue>: Now a std::list.
3951         (remote_notif_state_xfree): Don't declare.
3952         * remote-notif.c (remote_notif_process, handle_notification)
3953         (remote_notif_state_allocate): Update.
3954         (~remote_notif_state): Rename from remote_notif_state_xfree.
3955
3956 2019-04-19  Tom Tromey  <tom@tromey.com>
3957
3958         * symfile.c (reread_symbols): Update.
3959         * objfiles.c (objfile_register_static_link)
3960         (objfile_lookup_static_link): Update
3961         (~objfile) Don't delete static_links.
3962         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3963
3964 2019-04-19  Tom Tromey  <tom@tromey.com>
3965
3966         * type-stack.h (struct type_stack) <insert>: Constify string.
3967         * type-stack.c (type_stack::insert): Constify string.
3968         * gdbtypes.h (lookup_template_type): Update.
3969         (address_space_name_to_int): Update.
3970         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3971         const.
3972         (lookup_template_type): Make name const.
3973         * c-exp.y: Update rules.
3974         (lex_one_token, classify_name, classify_inner_name)
3975         (c_print_token): Update.
3976         * p-exp.y: Update rules.
3977         (yylex): Update.
3978         * f-exp.y: Update rules.
3979         (yylex): Update.
3980         * d-exp.y: Update rules.
3981         (lex_one_token, classify_name, classify_inner_name): Update.
3982         * parse.c (write_dollar_variable, copy_name): Return std::string.
3983         * parser-defs.h (copy_name): Change return type.
3984         * m2-exp.y: Update rules.
3985         (yylex): Update.
3986         * go-exp.y (lex_one_token): Update.
3987         Update rules.
3988         (classify_unsafe_function, classify_packaged_name)
3989         (classify_name, yylex): Update.
3990
3991 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3992
3993         * configure.ac: add --enable-source-highlight switch.
3994         * configure: Regenerate.
3995         * top.c (print_gdb_version): plumb --enable-source-highlight
3996         status to "show configuration".
3997
3998 2019-04-19  Tom Tromey  <tromey@adacore.com>
3999
4000         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4001         Check ADA_TYPE_P.
4002         (empty_record, ada_template_to_fixed_record_type_1)
4003         (template_to_static_fixed_type)
4004         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4005         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4006         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4007         macros.
4008
4009 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4010
4011         PR symtab/24423:
4012         * source.c (print_source_lines_base): Advance "iter" when a
4013         control character is seen.
4014
4015 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4016
4017         * inferior.h (struct infcall_suspend_state_deleter):
4018         Catch exception in destructor to avoid crash.
4019
4020 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4021
4022         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4023         close to the add_com "shell".
4024
4025 2019-04-18  Tom Tromey  <tromey@adacore.com>
4026
4027         * process-stratum-target.h (class process_stratum_target)
4028         <stratum>: Add "final".
4029
4030 2019-04-17  Tom Tromey  <tromey@adacore.com>
4031
4032         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4033         against nullptr before use.
4034
4035 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4036
4037         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4038
4039 2019-04-17  Jim Wilson  <jimw@sifive.com>
4040             Andrew Burgess  <andrew.burgess@embecosm.com>
4041
4042         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4043         code read might fail, assume 4-byte breakpoint in that case.
4044
4045 2019-04-15  Leszek Swirski  <leszeks@google.com>
4046
4047         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4048         rather than a hand-rolled POD check when checking for forced MEMORY
4049         classification.
4050
4051 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4052
4053         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4054         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4055         function.
4056         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4057         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4058         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4059         declaration.
4060
4061 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4062
4063         * aarch64-linux-nat.c
4064         (aarch64_linux_nat_target::thread_architecture): Add override.
4065         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4066         each VQ.
4067
4068 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4069
4070         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4071
4072 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4073
4074         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4075         target types of size 96-bits, add some additional comments, and
4076         check that the builtin type we found was the correct size.
4077
4078 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4079
4080         * utils.c (prompt_for_continue): Don't restore the styling at the
4081         end, as applied_style has the wrong value.  This fixes styling in
4082         long lists of file names that are interrupted by the "Continue?"
4083         prompt.
4084
4085 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4086
4087         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4088         * c-lang.c (c_language_defn): Likewise.
4089         (cplus_language_defn): Likewise.
4090         (asm_language_defn): Likewise.
4091         (minimal_language_defn): Likewise.
4092         * d-lang.c (d_language_defn): Likewise.
4093         * f-lang.c (f_language_defn): Likewise.
4094         * go-lang.c (go_language_defn): Likewise.
4095         * language.c (unknown_language_defn): Likewise.
4096         (auto_language_defn): Likewise.
4097         * language.h (struct language_defn): Remove la_magic field.
4098         (LANG_MAGIC): Delete.
4099         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4100         * objc-lang.c (objc_language_defn): Likewise.
4101         * opencl-lang.c (opencl_language_defn): Likewise.
4102         * p-lang.c (pascal_language_defn): Likewise.
4103         * rust-lang.c (rust_language_defn): Likewise.
4104
4105 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4106
4107         * riscv-tdep.c (riscv_type_align): New function.
4108         (riscv_type_alignment): Delete.
4109         (riscv_arg_location): Use 'type_align'.
4110         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4111
4112 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4113
4114         * gdbtypes.c (type_align): A struct with no non-static fields also
4115         has alignment of 1.
4116
4117 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4118
4119         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4120         component to 0.
4121         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4122         member.
4123         (riscv_struct_info::analyse): New implementation using new
4124         analyse_inner member function.
4125         (riscv_struct_info::field_offset): New member function.
4126         (riscv_struct_info::m_offsets): New member variable.
4127         (riscv_struct_info::analyse_inner): New private member function,
4128         takes the old implementation of riscv_struct_info::analyse but
4129         extended to track field offsets.
4130         (riscv_call_arg_struct): Update the struct folding special cases
4131         to handle cases where empty C++ structs, which are non-zero
4132         length, are found.
4133         (riscv_arg_location): Initialise the length of each location, a
4134         non-zero length now indicates the location is in use.
4135         (riscv_push_dummy_call): Allow for the first location having a
4136         non-zero offset when setting up arguments.
4137         (riscv_return_value): Likewise, but for return values.
4138
4139 2019-04-11  Tom Tromey  <tromey@adacore.com>
4140
4141         * utils.c (internal_vproblem): Make "msg" const.
4142
4143 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4144
4145         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4146         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4147         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4148         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4149
4150 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4151
4152         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4153         function.
4154         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4155         of amd64_collect_native_gregset.
4156         (amd64_linux_nat_target::store_registers): Likewise.
4157
4158 2019-04-10  Tom Tromey  <tom@tromey.com>
4159
4160         * symtab.c (lookup_global_symbol_from_objfile)
4161         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4162         * objfiles.h (class separate_debug_iterator): New.
4163         (class separate_debug_range): New.
4164         (struct objfile) <separate_debug_objfiles>: New method.
4165         (objfile_separate_debug_iterate): Don't declare.
4166         * objfiles.c (separate_debug_iterator::operator++): Rename from
4167         objfile_separate_debug_iterate.
4168         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4169         iterator.
4170         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4171         iterator.
4172
4173 2019-04-10  Tom Tromey  <tom@tromey.com>
4174
4175         * symfile.c (reread_symbols): Remove old comment.
4176         * objfiles.c (free_all_objfiles): Fix a typo.
4177
4178 2019-04-10  Tom Tromey  <tom@tromey.com>
4179
4180         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4181         * minsyms.c (lookup_minimal_symbol): Use foreach.
4182         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4183         (lookup_minimal_symbol_solib_trampoline): Likewise.
4184         * symfile.c (reread_symbols): Use foreach.
4185
4186 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4187             Tom Tromey  <tromey@adacore.com>
4188
4189         PR rust/24414:
4190         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4191         (rust_lex_int_test): Change "value" to be LONGEST.
4192         (rust_lex_tests): Add test for long integer literal.
4193
4194 2019-04-09  Tom Tromey  <tromey@adacore.com>
4195
4196         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4197         to bool.
4198         (extended_remote_target::attach): Update.
4199         (remote_target::remote_notice_new_inferior): Update.
4200         (remote_target::add_current_inferior_and_thread): Update.
4201         * inferior.c (exit_inferior_1): Use "false".
4202         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4203
4204 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4205
4206         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4207         the "start" command.
4208
4209 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4210
4211         * python/py-inferior.c (infpy_thread_from_thread_handle):
4212         Adjust comments to reflect renaming of thread_from_thread_handle
4213         to thread_from_handle.  Adjust keywords.  Fix type error message.
4214         (inferior_object_methods): Add thread_from_handle.  Retain
4215         thread_from_thread_handle, but mark it as deprecated.
4216
4217 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4218
4219         * gdbthread.h (find_thread_by_handle): Revise declaration.
4220         * thread.c (find_thread_by_handle): Likewise.  Adjust
4221         implementation too.
4222         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4223         support for buffer objects as handles.
4224
4225 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4226
4227         * python/py-infthread.c (thpy_thread_handle): New function.
4228         (thread_object_methods): Register thpy_thread_handle.
4229
4230 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4231
4232         * gdbthread.h (thread_to_thread_handle): Declare.
4233         * thread.c (gdbtypes.h): Include.
4234         (thread_to_thread_handle): New function.
4235
4236         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4237         (target_thread_info_to_thread_handle): Declare.
4238         * target.c (target_thread_info_to_thread_handle): New function.
4239         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4240         * target-delegates.c: Regenerate.
4241
4242         * linux-thread-db.c (class thread_db_target): Add method
4243         thread_info_to_thread_handle.
4244         (thread_db_target::thread_info_to_thread_handle): Define.
4245         * remote.c (class remote_target): Add new method
4246         thread_info_to_thread_handle.
4247         (remote_target::thread_info_to_thread_handle): Define.
4248
4249 2019-04-08  Pedro Alves  <palves@redhat.com>
4250
4251         * common/common-exceptions.c (throw_exception): Don't create
4252         named object to throw; throw directly.
4253         (throw_it): Likewise.  Don't initialize gdb_exception::message
4254         here, with new; pass FMT and AP to the ctor instead.
4255         * common/common-exceptions.h: Include <string>.
4256         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4257         const char *, va_list)): New ctor.  Use std::make_shared.
4258         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4259         errors)): Delete.
4260         (gdb_exception_error::gdb_exception_error(enum errors, const char
4261         *, va_list)): New.
4262         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4263         Add assertion.
4264         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4265         errors)): Delete.
4266         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4267         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4268         Add assertion.
4269
4270 2019-04-08  Tom Tromey  <tom@tromey.com>
4271
4272         * valops.c (value_rtti_indirect_type): Replace throw_exception
4273         with throw.
4274         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4275         with throw.
4276         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4277         throw.
4278         * target.c (target_translate_tls_address): Replace throw_exception
4279         with throw.
4280         * stack.c (frame_apply_command_count): Replace throw_exception
4281         with throw.
4282         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4283         throw.
4284         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4285         with throw.
4286         * rs6000-tdep.c (rs6000_frame_cache)
4287         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4288         * remote.c: Replace throw_exception with throw.
4289         * record-full.c (record_full_message, record_full_wait_1)
4290         (record_full_restore): Replace throw_exception with throw.
4291         * record-btrace.c:
4292         (get_thread_current_frame_id, record_btrace_start_replaying)
4293         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4294         (cmd_record_btrace_start): Replace throw_exception with throw.
4295         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4296         throw.
4297         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4298         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4299         * linespec.c:
4300         (find_linespec_symbols): Replace throw_exception with throw.
4301         * infrun.c (displaced_step_prepare, resume): Replace
4302         throw_exception with throw.
4303         * infcmd.c (post_create_inferior): Replace throw_exception with
4304         throw.
4305         * inf-loop.c (inferior_event_handler): Replace throw_exception
4306         with throw.
4307         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4308         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4309         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4310         (get_prev_frame_always, get_frame_pc_if_available)
4311         (get_frame_address_in_block_if_available, get_frame_language):
4312         Replace throw_exception with throw.
4313         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4314         throw_exception with throw.
4315         * eval.c (fetch_subexp_value, evaluate_var_value)
4316         (evaluate_funcall, evaluate_subexp_standard): Replace
4317         throw_exception with throw.
4318         * dwarf2loc.c (call_site_find_chain)
4319         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4320         Replace throw_exception with throw.
4321         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4322         with throw.
4323         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4324         throw.
4325         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4326         * completer.c (complete_line_internal): Replace throw_exception
4327         with throw.
4328         * compile/compile-object-run.c (compile_object_run): Replace
4329         throw_exception with throw.
4330         * cli/cli-script.c (process_next_line): Replace throw_exception
4331         with throw.
4332         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4333         (btrace_enable, btrace_maint_update_pt_packets): Replace
4334         throw_exception with throw.
4335         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4336         throw_exception with throw.
4337         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4338         throw_exception with throw.
4339         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4340         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4341         * aarch64-tdep.c (aarch64_make_prologue_cache)
4342         (aarch64_make_stub_cache): Replace throw_exception with throw.
4343
4344 2019-04-08  Tom Tromey  <tom@tromey.com>
4345
4346         * common/common-exceptions.c (throw_exception): Rename from
4347         throw_exception_cxx.  Remove old copy.  Make argument const.
4348         (throw_it): Create and throw exception objects directly.
4349         * common/common-exceptions.h (throw_exception): Make argument
4350         const.
4351         (struct gdb_exception_error): Add constructor.
4352         (struct gdb_exception_quit): Add constructor.
4353
4354 2019-04-08  Tom Tromey  <tom@tromey.com>
4355
4356         * common/common-exceptions.h (exception_rethrow): Don't declare.
4357         (TRY_SJLJ): Update comment.
4358         (TRY, CATCH, END_CATCH): Remove.
4359         * common/common-exceptions.c (exception_rethrow): Remove.
4360
4361 2019-04-08  Tom Tromey  <tom@tromey.com>
4362
4363         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4364         Remove.
4365         (gdb_exception_error): Rename from
4366         gdb_exception_RETURN_MASK_ERROR.
4367         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4368         (gdb_quit_bad_alloc): Update.
4369         * aarch64-tdep.c: Update.
4370         * ada-lang.c: Update.
4371         * ada-typeprint.c: Update.
4372         * ada-valprint.c: Update.
4373         * amd64-tdep.c: Update.
4374         * arch-utils.c: Update.
4375         * break-catch-throw.c: Update.
4376         * breakpoint.c: Update.
4377         * btrace.c: Update.
4378         * c-varobj.c: Update.
4379         * cli/cli-cmds.c: Update.
4380         * cli/cli-interp.c: Update.
4381         * cli/cli-script.c: Update.
4382         * common/common-exceptions.c: Update.
4383         * common/new-op.c: Update.
4384         * common/selftest.c: Update.
4385         * compile/compile-c-symbols.c: Update.
4386         * compile/compile-cplus-symbols.c: Update.
4387         * compile/compile-object-load.c: Update.
4388         * compile/compile-object-run.c: Update.
4389         * completer.c: Update.
4390         * corelow.c: Update.
4391         * cp-abi.c: Update.
4392         * cp-support.c: Update.
4393         * cp-valprint.c: Update.
4394         * darwin-nat.c: Update.
4395         * disasm-selftests.c: Update.
4396         * dtrace-probe.c: Update.
4397         * dwarf-index-cache.c: Update.
4398         * dwarf-index-write.c: Update.
4399         * dwarf2-frame-tailcall.c: Update.
4400         * dwarf2-frame.c: Update.
4401         * dwarf2loc.c: Update.
4402         * dwarf2read.c: Update.
4403         * eval.c: Update.
4404         * event-loop.c: Update.
4405         * event-top.c: Update.
4406         * exec.c: Update.
4407         * f-valprint.c: Update.
4408         * fbsd-tdep.c: Update.
4409         * frame-unwind.c: Update.
4410         * frame.c: Update.
4411         * gdbtypes.c: Update.
4412         * gnu-v3-abi.c: Update.
4413         * guile/guile-internal.h: Update.
4414         * guile/scm-block.c: Update.
4415         * guile/scm-breakpoint.c: Update.
4416         * guile/scm-cmd.c: Update.
4417         * guile/scm-disasm.c: Update.
4418         * guile/scm-frame.c: Update.
4419         * guile/scm-lazy-string.c: Update.
4420         * guile/scm-math.c: Update.
4421         * guile/scm-param.c: Update.
4422         * guile/scm-ports.c: Update.
4423         * guile/scm-pretty-print.c: Update.
4424         * guile/scm-symbol.c: Update.
4425         * guile/scm-symtab.c: Update.
4426         * guile/scm-type.c: Update.
4427         * guile/scm-value.c: Update.
4428         * i386-linux-tdep.c: Update.
4429         * i386-tdep.c: Update.
4430         * inf-loop.c: Update.
4431         * infcall.c: Update.
4432         * infcmd.c: Update.
4433         * infrun.c: Update.
4434         * jit.c: Update.
4435         * language.c: Update.
4436         * linespec.c: Update.
4437         * linux-fork.c: Update.
4438         * linux-nat.c: Update.
4439         * linux-tdep.c: Update.
4440         * linux-thread-db.c: Update.
4441         * main.c: Update.
4442         * mi/mi-cmd-break.c: Update.
4443         * mi/mi-cmd-stack.c: Update.
4444         * mi/mi-interp.c: Update.
4445         * mi/mi-main.c: Update.
4446         * objc-lang.c: Update.
4447         * p-valprint.c: Update.
4448         * parse.c: Update.
4449         * ppc-linux-tdep.c: Update.
4450         * printcmd.c: Update.
4451         * python/py-arch.c: Update.
4452         * python/py-breakpoint.c: Update.
4453         * python/py-cmd.c: Update.
4454         * python/py-finishbreakpoint.c: Update.
4455         * python/py-frame.c: Update.
4456         * python/py-framefilter.c: Update.
4457         * python/py-gdb-readline.c: Update.
4458         * python/py-inferior.c: Update.
4459         * python/py-infthread.c: Update.
4460         * python/py-lazy-string.c: Update.
4461         * python/py-linetable.c: Update.
4462         * python/py-objfile.c: Update.
4463         * python/py-param.c: Update.
4464         * python/py-prettyprint.c: Update.
4465         * python/py-progspace.c: Update.
4466         * python/py-record-btrace.c: Update.
4467         * python/py-record.c: Update.
4468         * python/py-symbol.c: Update.
4469         * python/py-type.c: Update.
4470         * python/py-unwind.c: Update.
4471         * python/py-utils.c: Update.
4472         * python/py-value.c: Update.
4473         * python/python.c: Update.
4474         * record-btrace.c: Update.
4475         * record-full.c: Update.
4476         * remote-fileio.c: Update.
4477         * remote.c: Update.
4478         * riscv-tdep.c: Update.
4479         * rs6000-aix-tdep.c: Update.
4480         * rs6000-tdep.c: Update.
4481         * rust-exp.y: Update.
4482         * rust-lang.c: Update.
4483         * s390-tdep.c: Update.
4484         * selftest-arch.c: Update.
4485         * solib-dsbt.c: Update.
4486         * solib-frv.c: Update.
4487         * solib-spu.c: Update.
4488         * solib-svr4.c: Update.
4489         * solib.c: Update.
4490         * sparc64-linux-tdep.c: Update.
4491         * stack.c: Update.
4492         * symfile-mem.c: Update.
4493         * symmisc.c: Update.
4494         * target.c: Update.
4495         * thread.c: Update.
4496         * top.c: Update.
4497         * tracefile-tfile.c: Update.
4498         * tui/tui.c: Update.
4499         * typeprint.c: Update.
4500         * unittests/cli-utils-selftests.c: Update.
4501         * unittests/parse-connection-spec-selftests.c: Update.
4502         * valops.c: Update.
4503         * valprint.c: Update.
4504         * value.c: Update.
4505         * varobj.c: Update.
4506         * windows-nat.c: Update.
4507         * x86-linux-nat.c: Update.
4508         * xml-support.c: Update.
4509
4510 2019-04-08  Tom Tromey  <tom@tromey.com>
4511
4512         * xml-support.c: Use C++ exception handling.
4513         * x86-linux-nat.c: Use C++ exception handling.
4514         * windows-nat.c: Use C++ exception handling.
4515         * varobj.c: Use C++ exception handling.
4516         * value.c: Use C++ exception handling.
4517         * valprint.c: Use C++ exception handling.
4518         * valops.c: Use C++ exception handling.
4519         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4520         handling.
4521         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4522         * typeprint.c: Use C++ exception handling.
4523         * tui/tui.c: Use C++ exception handling.
4524         * tracefile-tfile.c: Use C++ exception handling.
4525         * top.c: Use C++ exception handling.
4526         * thread.c: Use C++ exception handling.
4527         * target.c: Use C++ exception handling.
4528         * symmisc.c: Use C++ exception handling.
4529         * symfile-mem.c: Use C++ exception handling.
4530         * stack.c: Use C++ exception handling.
4531         * sparc64-linux-tdep.c: Use C++ exception handling.
4532         * solib.c: Use C++ exception handling.
4533         * solib-svr4.c: Use C++ exception handling.
4534         * solib-spu.c: Use C++ exception handling.
4535         * solib-frv.c: Use C++ exception handling.
4536         * solib-dsbt.c: Use C++ exception handling.
4537         * selftest-arch.c: Use C++ exception handling.
4538         * s390-tdep.c: Use C++ exception handling.
4539         * rust-lang.c: Use C++ exception handling.
4540         * rust-exp.y: Use C++ exception handling.
4541         * rs6000-tdep.c: Use C++ exception handling.
4542         * rs6000-aix-tdep.c: Use C++ exception handling.
4543         * riscv-tdep.c: Use C++ exception handling.
4544         * remote.c: Use C++ exception handling.
4545         * remote-fileio.c: Use C++ exception handling.
4546         * record-full.c: Use C++ exception handling.
4547         * record-btrace.c: Use C++ exception handling.
4548         * python/python.c: Use C++ exception handling.
4549         * python/py-value.c: Use C++ exception handling.
4550         * python/py-utils.c: Use C++ exception handling.
4551         * python/py-unwind.c: Use C++ exception handling.
4552         * python/py-type.c: Use C++ exception handling.
4553         * python/py-symbol.c: Use C++ exception handling.
4554         * python/py-record.c: Use C++ exception handling.
4555         * python/py-record-btrace.c: Use C++ exception handling.
4556         * python/py-progspace.c: Use C++ exception handling.
4557         * python/py-prettyprint.c: Use C++ exception handling.
4558         * python/py-param.c: Use C++ exception handling.
4559         * python/py-objfile.c: Use C++ exception handling.
4560         * python/py-linetable.c: Use C++ exception handling.
4561         * python/py-lazy-string.c: Use C++ exception handling.
4562         * python/py-infthread.c: Use C++ exception handling.
4563         * python/py-inferior.c: Use C++ exception handling.
4564         * python/py-gdb-readline.c: Use C++ exception handling.
4565         * python/py-framefilter.c: Use C++ exception handling.
4566         * python/py-frame.c: Use C++ exception handling.
4567         * python/py-finishbreakpoint.c: Use C++ exception handling.
4568         * python/py-cmd.c: Use C++ exception handling.
4569         * python/py-breakpoint.c: Use C++ exception handling.
4570         * python/py-arch.c: Use C++ exception handling.
4571         * printcmd.c: Use C++ exception handling.
4572         * ppc-linux-tdep.c: Use C++ exception handling.
4573         * parse.c: Use C++ exception handling.
4574         * p-valprint.c: Use C++ exception handling.
4575         * objc-lang.c: Use C++ exception handling.
4576         * mi/mi-main.c: Use C++ exception handling.
4577         * mi/mi-interp.c: Use C++ exception handling.
4578         * mi/mi-cmd-stack.c: Use C++ exception handling.
4579         * mi/mi-cmd-break.c: Use C++ exception handling.
4580         * main.c: Use C++ exception handling.
4581         * linux-thread-db.c: Use C++ exception handling.
4582         * linux-tdep.c: Use C++ exception handling.
4583         * linux-nat.c: Use C++ exception handling.
4584         * linux-fork.c: Use C++ exception handling.
4585         * linespec.c: Use C++ exception handling.
4586         * language.c: Use C++ exception handling.
4587         * jit.c: Use C++ exception handling.
4588         * infrun.c: Use C++ exception handling.
4589         * infcmd.c: Use C++ exception handling.
4590         * infcall.c: Use C++ exception handling.
4591         * inf-loop.c: Use C++ exception handling.
4592         * i386-tdep.c: Use C++ exception handling.
4593         * i386-linux-tdep.c: Use C++ exception handling.
4594         * guile/scm-value.c: Use C++ exception handling.
4595         * guile/scm-type.c: Use C++ exception handling.
4596         * guile/scm-symtab.c: Use C++ exception handling.
4597         * guile/scm-symbol.c: Use C++ exception handling.
4598         * guile/scm-pretty-print.c: Use C++ exception handling.
4599         * guile/scm-ports.c: Use C++ exception handling.
4600         * guile/scm-param.c: Use C++ exception handling.
4601         * guile/scm-math.c: Use C++ exception handling.
4602         * guile/scm-lazy-string.c: Use C++ exception handling.
4603         * guile/scm-frame.c: Use C++ exception handling.
4604         * guile/scm-disasm.c: Use C++ exception handling.
4605         * guile/scm-cmd.c: Use C++ exception handling.
4606         * guile/scm-breakpoint.c: Use C++ exception handling.
4607         * guile/scm-block.c: Use C++ exception handling.
4608         * guile/guile-internal.h: Use C++ exception handling.
4609         * gnu-v3-abi.c: Use C++ exception handling.
4610         * gdbtypes.c: Use C++ exception handling.
4611         * frame.c: Use C++ exception handling.
4612         * frame-unwind.c: Use C++ exception handling.
4613         * fbsd-tdep.c: Use C++ exception handling.
4614         * f-valprint.c: Use C++ exception handling.
4615         * exec.c: Use C++ exception handling.
4616         * event-top.c: Use C++ exception handling.
4617         * event-loop.c: Use C++ exception handling.
4618         * eval.c: Use C++ exception handling.
4619         * dwarf2read.c: Use C++ exception handling.
4620         * dwarf2loc.c: Use C++ exception handling.
4621         * dwarf2-frame.c: Use C++ exception handling.
4622         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4623         * dwarf-index-write.c: Use C++ exception handling.
4624         * dwarf-index-cache.c: Use C++ exception handling.
4625         * dtrace-probe.c: Use C++ exception handling.
4626         * disasm-selftests.c: Use C++ exception handling.
4627         * darwin-nat.c: Use C++ exception handling.
4628         * cp-valprint.c: Use C++ exception handling.
4629         * cp-support.c: Use C++ exception handling.
4630         * cp-abi.c: Use C++ exception handling.
4631         * corelow.c: Use C++ exception handling.
4632         * completer.c: Use C++ exception handling.
4633         * compile/compile-object-run.c: Use C++ exception handling.
4634         * compile/compile-object-load.c: Use C++ exception handling.
4635         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4636         * compile/compile-c-symbols.c: Use C++ exception handling.
4637         * common/selftest.c: Use C++ exception handling.
4638         * common/new-op.c: Use C++ exception handling.
4639         * cli/cli-script.c: Use C++ exception handling.
4640         * cli/cli-interp.c: Use C++ exception handling.
4641         * cli/cli-cmds.c: Use C++ exception handling.
4642         * c-varobj.c: Use C++ exception handling.
4643         * btrace.c: Use C++ exception handling.
4644         * breakpoint.c: Use C++ exception handling.
4645         * break-catch-throw.c: Use C++ exception handling.
4646         * arch-utils.c: Use C++ exception handling.
4647         * amd64-tdep.c: Use C++ exception handling.
4648         * ada-valprint.c: Use C++ exception handling.
4649         * ada-typeprint.c: Use C++ exception handling.
4650         * ada-lang.c: Use C++ exception handling.
4651         * aarch64-tdep.c: Use C++ exception handling.
4652
4653 2019-04-08  Tom Tromey  <tom@tromey.com>
4654
4655         * xml-support.c (gdb_xml_parser::parse): Update.
4656         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4657         * value.c (show_convenience): Update.
4658         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4659         (test_parse_flags_qcs): Update.
4660         * thread.c (thr_try_catch_cmd): Update.
4661         * target.c (target_translate_tls_address): Update.
4662         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4663         (info_frame_command_core, frame_apply_command_count): Update.
4664         * rust-exp.y (rust_lex_exception_test): Update.
4665         * riscv-tdep.c (riscv_print_one_register_info): Update.
4666         * remote.c (remote_target::enable_btrace): Update.
4667         * record-btrace.c (record_btrace_enable_warn): Update.
4668         * python/py-utils.c (gdbpy_convert_exception): Update.
4669         * printcmd.c (do_one_display, print_variable_and_value): Update.
4670         * mi/mi-main.c (mi_print_exception): Update.
4671         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4672         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4673         * linux-nat.c (linux_nat_target::attach): Update.
4674         * linux-fork.c (class scoped_switch_fork_info): Update.
4675         * infrun.c (displaced_step_prepare): Update.
4676         * infcall.c (call_function_by_hand_dummy): Update.
4677         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4678         * gnu-v3-abi.c (print_one_vtable): Update.
4679         * frame.c (get_prev_frame_always): Update.
4680         * f-valprint.c (info_common_command_for_block): Update.
4681         * exec.c (try_open_exec_file): Update.
4682         * exceptions.c (print_exception, exception_print)
4683         (exception_fprintf, exception_print_same): Update.
4684         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4685         * dwarf-index-cache.c (index_cache::store)
4686         (index_cache::lookup_gdb_index): Update.
4687         * darwin-nat.c (maybe_cache_shell): Update.
4688         * cp-valprint.c (cp_print_value_fields): Update.
4689         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4690         (gcc_cplus_symbol_address): Update.
4691         * compile/compile-c-symbols.c (gcc_convert_symbol)
4692         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4693         * common/selftest.c: Update.
4694         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4695         a std::string.
4696         (exception_try_scope_entry, exception_try_scope_exit): Don't
4697         declare.
4698         (struct exception_try_scope): Remove.
4699         (TRY): Don't use exception_try_scope.
4700         (struct gdb_exception): Add constructor, operator=.
4701         <what>: New method.
4702         (struct gdb_exception_RETURN_MASK_ALL)
4703         (struct gdb_exception_RETURN_MASK_ERROR)
4704         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4705         (struct gdb_quit_bad_alloc): Update.
4706         * common/common-exceptions.c (exception_none): Change
4707         initializer.
4708         (struct catcher) <state, exception>: Initialize inline.
4709         <prev>: Remove member.
4710         (current_catcher): Remove.
4711         (catchers): New global.
4712         (exceptions_state_mc_init): Simplify.
4713         (catcher_pop): Remove.
4714         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4715         (try_scope_depth, exception_try_scope_entry)
4716         (exception_try_scope_exit): Remove.
4717         (throw_exception_sjlj): Update.
4718         (exception_messages, exception_messages_size): Remove.
4719         (throw_it): Simplify.
4720         (gdb_exception_sliced_copy): Remove.
4721         (throw_exception_cxx): Update.
4722         * cli/cli-script.c (script_from_file): Update.
4723         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4724         Update.
4725         * ada-valprint.c (ada_val_print): Update.
4726         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4727         (create_excep_cond_exprs): Update.
4728
4729 2019-04-08  Tom Tromey  <tom@tromey.com>
4730
4731         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4732         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4733         (TRY, CATCH, END_CATCH): Remove some definitions.
4734         * common/common-exceptions.c: Don't use GDB_XCPT.
4735         (catcher_list_size): Remove.
4736         (throw_exception, throw_it): Simplify.
4737
4738 2019-04-05  Tom Tromey  <tom@tromey.com>
4739
4740         Revert the header-sorting patch.
4741         * ft32-tdep.c: Revert.
4742         * frv-tdep.c: Revert.
4743         * frv-linux-tdep.c: Revert.
4744         * frame.c: Revert.
4745         * frame-unwind.c: Revert.
4746         * frame-base.c: Revert.
4747         * fork-child.c: Revert.
4748         * findvar.c: Revert.
4749         * findcmd.c: Revert.
4750         * filesystem.c: Revert.
4751         * filename-seen-cache.h: Revert.
4752         * filename-seen-cache.c: Revert.
4753         * fbsd-tdep.c: Revert.
4754         * fbsd-nat.h: Revert.
4755         * fbsd-nat.c: Revert.
4756         * f-valprint.c: Revert.
4757         * f-typeprint.c: Revert.
4758         * f-lang.c: Revert.
4759         * extension.h: Revert.
4760         * extension.c: Revert.
4761         * extension-priv.h: Revert.
4762         * expprint.c: Revert.
4763         * exec.h: Revert.
4764         * exec.c: Revert.
4765         * exceptions.c: Revert.
4766         * event-top.c: Revert.
4767         * event-loop.c: Revert.
4768         * eval.c: Revert.
4769         * elfread.c: Revert.
4770         * dwarf2read.h: Revert.
4771         * dwarf2read.c: Revert.
4772         * dwarf2loc.c: Revert.
4773         * dwarf2expr.h: Revert.
4774         * dwarf2expr.c: Revert.
4775         * dwarf2-frame.c: Revert.
4776         * dwarf2-frame-tailcall.c: Revert.
4777         * dwarf-index-write.h: Revert.
4778         * dwarf-index-write.c: Revert.
4779         * dwarf-index-common.c: Revert.
4780         * dwarf-index-cache.h: Revert.
4781         * dwarf-index-cache.c: Revert.
4782         * dummy-frame.c: Revert.
4783         * dtrace-probe.c: Revert.
4784         * disasm.h: Revert.
4785         * disasm.c: Revert.
4786         * disasm-selftests.c: Revert.
4787         * dictionary.c: Revert.
4788         * dicos-tdep.c: Revert.
4789         * demangle.c: Revert.
4790         * dcache.h: Revert.
4791         * dcache.c: Revert.
4792         * darwin-nat.h: Revert.
4793         * darwin-nat.c: Revert.
4794         * darwin-nat-info.c: Revert.
4795         * d-valprint.c: Revert.
4796         * d-namespace.c: Revert.
4797         * d-lang.c: Revert.
4798         * ctf.c: Revert.
4799         * csky-tdep.c: Revert.
4800         * csky-linux-tdep.c: Revert.
4801         * cris-tdep.c: Revert.
4802         * cris-linux-tdep.c: Revert.
4803         * cp-valprint.c: Revert.
4804         * cp-support.c: Revert.
4805         * cp-namespace.c: Revert.
4806         * cp-abi.c: Revert.
4807         * corelow.c: Revert.
4808         * corefile.c: Revert.
4809         * continuations.c: Revert.
4810         * completer.h: Revert.
4811         * completer.c: Revert.
4812         * complaints.c: Revert.
4813         * coffread.c: Revert.
4814         * coff-pe-read.c: Revert.
4815         * cli-out.h: Revert.
4816         * cli-out.c: Revert.
4817         * charset.c: Revert.
4818         * c-varobj.c: Revert.
4819         * c-valprint.c: Revert.
4820         * c-typeprint.c: Revert.
4821         * c-lang.c: Revert.
4822         * buildsym.c: Revert.
4823         * buildsym-legacy.c: Revert.
4824         * build-id.h: Revert.
4825         * build-id.c: Revert.
4826         * btrace.c: Revert.
4827         * bsd-uthread.c: Revert.
4828         * breakpoint.h: Revert.
4829         * breakpoint.c: Revert.
4830         * break-catch-throw.c: Revert.
4831         * break-catch-syscall.c: Revert.
4832         * break-catch-sig.c: Revert.
4833         * blockframe.c: Revert.
4834         * block.c: Revert.
4835         * bfin-tdep.c: Revert.
4836         * bfin-linux-tdep.c: Revert.
4837         * bfd-target.c: Revert.
4838         * bcache.c: Revert.
4839         * ax-general.c: Revert.
4840         * ax-gdb.h: Revert.
4841         * ax-gdb.c: Revert.
4842         * avr-tdep.c: Revert.
4843         * auxv.c: Revert.
4844         * auto-load.c: Revert.
4845         * arm-wince-tdep.c: Revert.
4846         * arm-tdep.c: Revert.
4847         * arm-symbian-tdep.c: Revert.
4848         * arm-pikeos-tdep.c: Revert.
4849         * arm-obsd-tdep.c: Revert.
4850         * arm-nbsd-tdep.c: Revert.
4851         * arm-nbsd-nat.c: Revert.
4852         * arm-linux-tdep.c: Revert.
4853         * arm-linux-nat.c: Revert.
4854         * arm-fbsd-tdep.c: Revert.
4855         * arm-fbsd-nat.c: Revert.
4856         * arm-bsd-tdep.c: Revert.
4857         * arch-utils.c: Revert.
4858         * arc-tdep.c: Revert.
4859         * arc-newlib-tdep.c: Revert.
4860         * annotate.h: Revert.
4861         * annotate.c: Revert.
4862         * amd64-windows-tdep.c: Revert.
4863         * amd64-windows-nat.c: Revert.
4864         * amd64-tdep.c: Revert.
4865         * amd64-sol2-tdep.c: Revert.
4866         * amd64-obsd-tdep.c: Revert.
4867         * amd64-obsd-nat.c: Revert.
4868         * amd64-nbsd-tdep.c: Revert.
4869         * amd64-nbsd-nat.c: Revert.
4870         * amd64-nat.c: Revert.
4871         * amd64-linux-tdep.c: Revert.
4872         * amd64-linux-nat.c: Revert.
4873         * amd64-fbsd-tdep.c: Revert.
4874         * amd64-fbsd-nat.c: Revert.
4875         * amd64-dicos-tdep.c: Revert.
4876         * amd64-darwin-tdep.c: Revert.
4877         * amd64-bsd-nat.c: Revert.
4878         * alpha-tdep.c: Revert.
4879         * alpha-obsd-tdep.c: Revert.
4880         * alpha-nbsd-tdep.c: Revert.
4881         * alpha-mdebug-tdep.c: Revert.
4882         * alpha-linux-tdep.c: Revert.
4883         * alpha-linux-nat.c: Revert.
4884         * alpha-bsd-tdep.c: Revert.
4885         * alpha-bsd-nat.c: Revert.
4886         * aix-thread.c: Revert.
4887         * agent.c: Revert.
4888         * addrmap.c: Revert.
4889         * ada-varobj.c: Revert.
4890         * ada-valprint.c: Revert.
4891         * ada-typeprint.c: Revert.
4892         * ada-tasks.c: Revert.
4893         * ada-lang.c: Revert.
4894         * aarch64-tdep.c: Revert.
4895         * aarch64-ravenscar-thread.c: Revert.
4896         * aarch64-newlib-tdep.c: Revert.
4897         * aarch64-linux-tdep.c: Revert.
4898         * aarch64-linux-nat.c: Revert.
4899         * aarch64-fbsd-tdep.c: Revert.
4900         * aarch64-fbsd-nat.c: Revert.
4901         * aarch32-linux-nat.c: Revert.
4902
4903 2019-04-05  Tom Tromey  <tom@tromey.com>
4904
4905         * ft32-tdep.c: Sort headers.
4906         * frv-tdep.c: Sort headers.
4907         * frv-linux-tdep.c: Sort headers.
4908         * frame.c: Sort headers.
4909         * frame-unwind.c: Sort headers.
4910         * frame-base.c: Sort headers.
4911         * fork-child.c: Sort headers.
4912         * findvar.c: Sort headers.
4913         * findcmd.c: Sort headers.
4914         * filesystem.c: Sort headers.
4915         * filename-seen-cache.h: Sort headers.
4916         * filename-seen-cache.c: Sort headers.
4917         * fbsd-tdep.c: Sort headers.
4918         * fbsd-nat.h: Sort headers.
4919         * fbsd-nat.c: Sort headers.
4920         * f-valprint.c: Sort headers.
4921         * f-typeprint.c: Sort headers.
4922         * f-lang.c: Sort headers.
4923         * extension.h: Sort headers.
4924         * extension.c: Sort headers.
4925         * extension-priv.h: Sort headers.
4926         * expprint.c: Sort headers.
4927         * exec.h: Sort headers.
4928         * exec.c: Sort headers.
4929         * exceptions.c: Sort headers.
4930         * event-top.c: Sort headers.
4931         * event-loop.c: Sort headers.
4932         * eval.c: Sort headers.
4933         * elfread.c: Sort headers.
4934         * dwarf2read.h: Sort headers.
4935         * dwarf2read.c: Sort headers.
4936         * dwarf2loc.c: Sort headers.
4937         * dwarf2expr.h: Sort headers.
4938         * dwarf2expr.c: Sort headers.
4939         * dwarf2-frame.c: Sort headers.
4940         * dwarf2-frame-tailcall.c: Sort headers.
4941         * dwarf-index-write.h: Sort headers.
4942         * dwarf-index-write.c: Sort headers.
4943         * dwarf-index-common.c: Sort headers.
4944         * dwarf-index-cache.h: Sort headers.
4945         * dwarf-index-cache.c: Sort headers.
4946         * dummy-frame.c: Sort headers.
4947         * dtrace-probe.c: Sort headers.
4948         * disasm.h: Sort headers.
4949         * disasm.c: Sort headers.
4950         * disasm-selftests.c: Sort headers.
4951         * dictionary.c: Sort headers.
4952         * dicos-tdep.c: Sort headers.
4953         * demangle.c: Sort headers.
4954         * dcache.h: Sort headers.
4955         * dcache.c: Sort headers.
4956         * darwin-nat.h: Sort headers.
4957         * darwin-nat.c: Sort headers.
4958         * darwin-nat-info.c: Sort headers.
4959         * d-valprint.c: Sort headers.
4960         * d-namespace.c: Sort headers.
4961         * d-lang.c: Sort headers.
4962         * ctf.c: Sort headers.
4963         * csky-tdep.c: Sort headers.
4964         * csky-linux-tdep.c: Sort headers.
4965         * cris-tdep.c: Sort headers.
4966         * cris-linux-tdep.c: Sort headers.
4967         * cp-valprint.c: Sort headers.
4968         * cp-support.c: Sort headers.
4969         * cp-namespace.c: Sort headers.
4970         * cp-abi.c: Sort headers.
4971         * corelow.c: Sort headers.
4972         * corefile.c: Sort headers.
4973         * continuations.c: Sort headers.
4974         * completer.h: Sort headers.
4975         * completer.c: Sort headers.
4976         * complaints.c: Sort headers.
4977         * coffread.c: Sort headers.
4978         * coff-pe-read.c: Sort headers.
4979         * cli-out.h: Sort headers.
4980         * cli-out.c: Sort headers.
4981         * charset.c: Sort headers.
4982         * c-varobj.c: Sort headers.
4983         * c-valprint.c: Sort headers.
4984         * c-typeprint.c: Sort headers.
4985         * c-lang.c: Sort headers.
4986         * buildsym.c: Sort headers.
4987         * buildsym-legacy.c: Sort headers.
4988         * build-id.h: Sort headers.
4989         * build-id.c: Sort headers.
4990         * btrace.c: Sort headers.
4991         * bsd-uthread.c: Sort headers.
4992         * breakpoint.h: Sort headers.
4993         * breakpoint.c: Sort headers.
4994         * break-catch-throw.c: Sort headers.
4995         * break-catch-syscall.c: Sort headers.
4996         * break-catch-sig.c: Sort headers.
4997         * blockframe.c: Sort headers.
4998         * block.c: Sort headers.
4999         * bfin-tdep.c: Sort headers.
5000         * bfin-linux-tdep.c: Sort headers.
5001         * bfd-target.c: Sort headers.
5002         * bcache.c: Sort headers.
5003         * ax-general.c: Sort headers.
5004         * ax-gdb.h: Sort headers.
5005         * ax-gdb.c: Sort headers.
5006         * avr-tdep.c: Sort headers.
5007         * auxv.c: Sort headers.
5008         * auto-load.c: Sort headers.
5009         * arm-wince-tdep.c: Sort headers.
5010         * arm-tdep.c: Sort headers.
5011         * arm-symbian-tdep.c: Sort headers.
5012         * arm-pikeos-tdep.c: Sort headers.
5013         * arm-obsd-tdep.c: Sort headers.
5014         * arm-nbsd-tdep.c: Sort headers.
5015         * arm-nbsd-nat.c: Sort headers.
5016         * arm-linux-tdep.c: Sort headers.
5017         * arm-linux-nat.c: Sort headers.
5018         * arm-fbsd-tdep.c: Sort headers.
5019         * arm-fbsd-nat.c: Sort headers.
5020         * arm-bsd-tdep.c: Sort headers.
5021         * arch-utils.c: Sort headers.
5022         * arc-tdep.c: Sort headers.
5023         * arc-newlib-tdep.c: Sort headers.
5024         * annotate.h: Sort headers.
5025         * annotate.c: Sort headers.
5026         * amd64-windows-tdep.c: Sort headers.
5027         * amd64-windows-nat.c: Sort headers.
5028         * amd64-tdep.c: Sort headers.
5029         * amd64-sol2-tdep.c: Sort headers.
5030         * amd64-obsd-tdep.c: Sort headers.
5031         * amd64-obsd-nat.c: Sort headers.
5032         * amd64-nbsd-tdep.c: Sort headers.
5033         * amd64-nbsd-nat.c: Sort headers.
5034         * amd64-nat.c: Sort headers.
5035         * amd64-linux-tdep.c: Sort headers.
5036         * amd64-linux-nat.c: Sort headers.
5037         * amd64-fbsd-tdep.c: Sort headers.
5038         * amd64-fbsd-nat.c: Sort headers.
5039         * amd64-dicos-tdep.c: Sort headers.
5040         * amd64-darwin-tdep.c: Sort headers.
5041         * amd64-bsd-nat.c: Sort headers.
5042         * alpha-tdep.c: Sort headers.
5043         * alpha-obsd-tdep.c: Sort headers.
5044         * alpha-nbsd-tdep.c: Sort headers.
5045         * alpha-mdebug-tdep.c: Sort headers.
5046         * alpha-linux-tdep.c: Sort headers.
5047         * alpha-linux-nat.c: Sort headers.
5048         * alpha-bsd-tdep.c: Sort headers.
5049         * alpha-bsd-nat.c: Sort headers.
5050         * aix-thread.c: Sort headers.
5051         * agent.c: Sort headers.
5052         * addrmap.c: Sort headers.
5053         * ada-varobj.c: Sort headers.
5054         * ada-valprint.c: Sort headers.
5055         * ada-typeprint.c: Sort headers.
5056         * ada-tasks.c: Sort headers.
5057         * ada-lang.c: Sort headers.
5058         * aarch64-tdep.c: Sort headers.
5059         * aarch64-ravenscar-thread.c: Sort headers.
5060         * aarch64-newlib-tdep.c: Sort headers.
5061         * aarch64-linux-tdep.c: Sort headers.
5062         * aarch64-linux-nat.c: Sort headers.
5063         * aarch64-fbsd-tdep.c: Sort headers.
5064         * aarch64-fbsd-nat.c: Sort headers.
5065         * aarch32-linux-nat.c: Sort headers.
5066
5067 2019-04-04  Tom Tromey  <tom@tromey.com>
5068
5069         * varobj.c (varobj_create): Update.
5070         * rust-exp.y (struct rust_parser) <update_innermost_block,
5071         lookup_symbol>: New methods.
5072         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5073         Rename.
5074         (rust_parser::rust_lookup_type)
5075         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5076         * printcmd.c (display_command, do_one_display): Update.
5077         * parser-defs.h (struct parser_state) <parser_state>: Add
5078         "tracker" parameter.
5079         (block_tracker): New member.
5080         (class innermost_block_tracker) <innermost_block_tracker>: Add
5081         "types" parameter.
5082         <reset>: Remove method.
5083         (innermost_block): Don't declare.
5084         (null_post_parser): Update.
5085         * parse.c (innermost_block): Remove global.
5086         (write_dollar_variable): Update.
5087         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5088         Remove "tracker_types" parameter.
5089         (parse_expression): Add "tracker" parameter.
5090         (parse_expression_for_completion): Update.
5091         (null_post_parser): Add "tracker" parameter.
5092         * p-exp.y: Update rules.
5093         * m2-exp.y: Update rules.
5094         * language.h (struct language_defn) <la_post_parser>: Add
5095         "tracker" parameter.
5096         * go-exp.y: Update rules.
5097         * f-exp.y: Update rules.
5098         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5099         parameter.
5100         * d-exp.y: Update rules.
5101         * c-exp.y: Update rules.
5102         * breakpoint.c (set_breakpoint_condition): Create an
5103         innermost_block_tracker.
5104         (watch_command_1): Likewise.
5105         * ada-lang.c (resolve): Add "tracker" parameter.
5106         (resolve_subexp): Likewise.
5107         * ada-exp.y (write_var_from_sym): Update.
5108
5109 2019-04-04  Tom Tromey  <tom@tromey.com>
5110
5111         * type-stack.h: New file.
5112         * type-stack.c: New file.
5113         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5114         type-stack.h.
5115         (insert_into_type_stack, insert_type, push_type, push_type_int)
5116         (insert_type_address_space, pop_type, pop_type_int)
5117         (pop_typelist, pop_type_stack, append_type_stack)
5118         (push_type_stack, get_type_stack, push_typelist)
5119         (follow_type_instance_flags, follow_types): Don't declare.
5120         * parse.c (type_stack): Remove global.
5121         (parse_exp_in_context): Update.
5122         (insert_into_type_stack, insert_type, push_type, push_type_int)
5123         (insert_type_address_space, pop_type, pop_type_int)
5124         (pop_typelist, pop_type_stack, append_type_stack)
5125         (push_type_stack, get_type_stack, push_typelist)
5126         (follow_type_instance_flags, follow_types): Remove (moved to
5127         type-stack.c).
5128         * f-exp.y (type_stack): New global.
5129         Update rules.
5130         (push_kind_type, f_parse): Update.
5131         * d-exp.y (type_stack): New global.
5132         Update rules.
5133         (d_parse): Update.
5134         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5135         Update rules.
5136         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5137         (HFILES_NO_SRCDIR): Add type-stack.h.
5138
5139 2019-04-04  Tom Tromey  <tom@tromey.com>
5140
5141         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5142         (rust_parser::convert_ast_to_expression, rust_parse)
5143         (rust_lex_test_completion, rust_lex_tests): Update.
5144         * parser-defs.h (struct expr_completion_state): New.
5145         (struct parser_state) <parser_state>: Add completion parameter.
5146         <mark_struct_expression, mark_completion_tag>: New methods.
5147         <parse_completion, m_completion_state>: New members.
5148         (prefixify_expression, null_post_parser): Update.
5149         (mark_struct_expression, mark_completion_tag): Don't declare.
5150         * parse.c (parse_completion, expout_last_struct)
5151         (expout_tag_completion_type, expout_completion_name): Remove
5152         globals.
5153         (parser_state::mark_struct_expression)
5154         (parser_state::mark_completion_tag): Now methods.
5155         (prefixify_expression): Add last_struct parameter.
5156         (prefixify_subexp): Likewise.
5157         (parse_exp_1): Update.
5158         (parse_exp_in_context): Add cstate parameter.  Update.
5159         (parse_expression_for_completion): Create an
5160         expr_completion_state.
5161         (null_post_parser): Add "completion" parameter.
5162         * p-exp.y: Update rules.
5163         (yylex): Update.
5164         * language.h (struct language_defn) <la_post_parser>: Add
5165         "completing" parameter.
5166         * go-exp.y: Update rules.
5167         (lex_one_token): Update.
5168         * expression.h (parse_completion): Don't declare.
5169         * d-exp.y: Update rules.
5170         (lex_one_token): Update rules.
5171         * c-exp.y: Update rules.
5172         (lex_one_token): Update.
5173         * ada-lang.c (resolve): Add "parse_completion" parameter.
5174         (resolve_subexp): Likewise.
5175         (ada_resolve_function): Likewise.
5176
5177 2019-04-04  Tom Tromey  <tom@tromey.com>
5178
5179         * parser-defs.h (struct parser_state) <start_arglist,
5180         end_arglist>: New methods.
5181         <arglist_len, m_funcall_chain>: New members.
5182         (arglist_len, start_arglist, end_arglist): Don't declare.
5183         * parse.c (arglist_len, funcall_chain): Remove global.
5184         (start_arglist, end_arglist): Remove functions.
5185         (parse_exp_in_context): Update.
5186         * p-exp.y: Update rules.
5187         * m2-exp.y: Update rules.
5188         * go-exp.y: Update rules.
5189         * f-exp.y: Update rules.
5190         * d-exp.y: Update rules.
5191         * c-exp.y: Update rules.
5192
5193 2019-04-04  Tom Tromey  <tom@tromey.com>
5194
5195         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5196         lex_operator, push_back>: New methods.
5197         Update all rules.
5198         (rust_parser::lex_hex, lex_escape): Rename and update.
5199         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5200         (rust_parser::lex_operator): Rename and update.
5201         (rust_parser::lex_number, rustyylex, rustyyerror)
5202         (rust_lex_test_init, rust_lex_test_sequence)
5203         (rust_lex_test_push_back, rust_lex_tests): Update.
5204         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5205         parameter.
5206         <lexptr, prev_lexptr>: New members.
5207         (lexptr, prev_lexptr): Don't declare.
5208         * parse.c (lexptr, prev_lexptr): Remove globals.
5209         (parse_exp_in_context): Update.
5210         * p-exp.y (yylex, yyerror): Update.
5211         * m2-exp.y (parse_number, yylex, yyerror): Update.
5212         * go-exp.y (lex_one_token, yyerror): Update.
5213         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5214         * d-exp.y (lex_one_token, yyerror): Update.
5215         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5216         (lex_one_token, yyerror): Update.
5217         * ada-lex.l (YY_INPUT): Update.
5218         (rewind_to_char): Update.
5219         * ada-exp.y (yyerror): Update.
5220
5221 2019-04-04  Tom Tromey  <tom@tromey.com>
5222
5223         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5224         * parser-defs.h (struct parser_state) <parser_state>: Add new
5225         parameter.
5226         <comma_terminates>: New member.
5227         (comma_terminates): Don't declare global.
5228         * parse.c (comma_terminates): Remove global.
5229         (parse_exp_in_context): Update.
5230         * p-exp.y (yylex): Update.
5231         * m2-exp.y (yylex): Update.
5232         * go-exp.y (lex_one_token): Update.
5233         * f-exp.y (yylex): Update.
5234         * d-exp.y (lex_one_token): Update.
5235         * c-exp.y (lex_one_token): Update.
5236         * ada-lex.l: Update.
5237
5238 2019-04-04  Tom Tromey  <tom@tromey.com>
5239
5240         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5241         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5242         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5243         * parser-defs.h (paren_depth): Don't declare.
5244         * parse.c (paren_depth): Remove global.
5245         (parse_exp_in_context): Update.
5246         * p-exp.y (paren_depth): New global.
5247         (pascal_parse): Initialize it.
5248         * m2-exp.y (paren_depth): New global.
5249         (m2_parse): Initialize it.
5250         * go-exp.y (paren_depth): New global.
5251         (go_parse): Initialize it.
5252         * f-exp.y (paren_depth): New global.
5253         (f_parse): Initialize it.
5254         * d-exp.y (paren_depth): New global.
5255         (d_parse): Initialize it.
5256         * c-exp.y (paren_depth): New global.
5257         (c_parse): Initialize it.
5258         * ada-lex.l (paren_depth): New global.
5259         (lexer_init): Initialize it.
5260
5261 2019-04-04  Tom Tromey  <tom@tromey.com>
5262
5263         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5264         (rust_parser::convert_ast_to_type)
5265         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5266         * parser-defs.h (struct parser_state) <parser_state>: Add
5267         parameters.  Initialize new members.
5268         <expression_context_block, expression_context_pc>: New members.
5269         * parse.c (expression_context_block, expression_context_pc):
5270         Remove globals.
5271         (parse_exp_in_context): Update.
5272         * p-exp.y: Update all rules.
5273         (yylex): Update.
5274         * m2-exp.y: Update all rules.
5275         (yylex): Update.
5276         * go-exp.y (yylex): Update.
5277         * f-exp.y (yylex): Update.
5278         * d-exp.y: Update all rules.
5279         (yylex): Update.
5280         * c-exp.y: Update all rules.
5281         (lex_one_token, classify_name, yylex, c_parse): Update.
5282         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5283
5284 2019-04-04  Tom Tromey  <tom@tromey.com>
5285
5286         * gdbarch.h, gdbarch.c: Rebuild.
5287         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5288         * stap-probe.h:
5289         (struct stap_parse_info): Replace "parser_state" with
5290         "expr_builder".
5291         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5292         (parser_state): New class.
5293         * parse.c (expr_builder): Rename.
5294         (expr_builder::release): Rename.
5295         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5296         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5297         (write_exp_elt_longcst, write_exp_elt_floatcst)
5298         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5299         (write_exp_string_vector, write_exp_bitstring)
5300         (write_exp_msymbol, mark_struct_expression)
5301         (write_dollar_variable)
5302         (insert_type_address_space, increase_expout_size): Replace
5303         "parser_state" with "expr_builder".
5304         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5305         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5306         "parser_state" with "expr_builder".
5307
5308 2019-04-04  Tom Tromey  <tom@tromey.com>
5309
5310         * rust-exp.y: Replace "parse_language" with method call.
5311         * p-exp.y:
5312         (yylex): Replace "parse_language" with method call.
5313         * m2-exp.y:
5314         (yylex): Replace "parse_language" with method call.
5315         * go-exp.y (classify_name): Replace "parse_language" with method
5316         call.
5317         * f-exp.y (yylex): Replace "parse_language" with method call.
5318         * d-exp.y (lex_one_token): Replace "parse_language" with method
5319         call.
5320         * c-exp.y:
5321         (lex_one_token, classify_name, yylex): Replace "parse_language"
5322         with method call.
5323         * ada-exp.y (find_primitive_type, type_char)
5324         (type_system_address): Replace "parse_language" with method call.
5325
5326 2019-04-04  Tom Tromey  <tom@tromey.com>
5327
5328         * rust-exp.y: Replace "parse_gdbarch" with method call.
5329         * parse.c (write_dollar_variable, insert_type_address_space):
5330         Replace "parse_gdbarch" with method call.
5331         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5332         call.
5333         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5334         call.
5335         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5336         "parse_gdbarch" with method call.
5337         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5338         with method call.
5339         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5340         "parse_gdbarch" with method call.
5341         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5342         "parse_gdbarch" with method call.
5343         * c-exp.y (parse_type, parse_number, classify_name): Replace
5344         "parse_gdbarch" with method call.
5345         * ada-lex.l: Replace "parse_gdbarch" with method call.
5346         * ada-exp.y (parse_type, find_primitive_type, type_char)
5347         (type_system_address): Replace "parse_gdbarch" with method call.
5348
5349 2019-04-04  Tom Tromey  <tom@tromey.com>
5350
5351         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5352         * stap-probe.c (stap_parse_argument): Update.
5353         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5354         initial_size parameter.
5355         * rust-exp.y (rust_lex_tests): Update.
5356         * parse.c (parser_state): Update.
5357         (parse_exp_in_context): Update.
5358         * parser-defs.h (struct parser_state) <parser_state>: Remove
5359         "initial_size" parameter.
5360
5361 2019-04-04  Tom Tromey  <tom@tromey.com>
5362
5363         * parser-defs.h (increase_expout_size): Don't declare.
5364         * parse.c (increase_expout_size): Now static.
5365
5366 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5367
5368         * gnu-nat.c (gnu_nat_target::wait): Fix
5369         target_waitstatus_to_string call.
5370
5371 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5372
5373         * eval.c (evaluate_subexp_standard): Handle internal functions
5374         during Fortran function call handling.
5375
5376 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5377
5378         * NEWS: Mention new internal functions.
5379         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5380         (read_base_type): Use dwarf2_init_complex_target_type.
5381         * value.c (creal_internal_fn): New function.
5382         (cimag_internal_fn): New function.
5383         (_initialize_values): Register new internal functions.
5384
5385 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5386
5387         * infrun.c (stop_all_threads): If debug_infrun, always
5388         trace the wait status after wait_one, using
5389         target_waitstatus_to_string and target_pid_to_str.
5390         (handle_inferior_event): Replace various trace of
5391         wait status kind by a single trace.
5392         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5393         wait status kind image by target_waitstatus_to_string.
5394         * target/waitstatus.c (target_waitstatus_to_string): Fix
5395         obsolete comment.
5396
5397 2019-04-01  Tom Tromey  <tromey@adacore.com>
5398
5399         PR symtab/23331:
5400         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5401
5402 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5403             Pedro Alves  <palves@redhat.com>
5404
5405         * top.c (quit_force): Call 'finalize_values'.
5406         * value.c (finalize_values): New function.
5407         * value.h (finalize_values): Declare.
5408
5409 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5410
5411         * NEWS: Announce $_gdb_major and $_gdb_minor.
5412
5413         * top.c (init_gdb_version_vars): New function.
5414         (gdb_init): Call init_gdb_version_vars.
5415
5416 2019-03-29  Tom Tromey  <tromey@adacore.com>
5417
5418         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5419         help text.  Remove dead code.
5420
5421 2019-03-29  Keith Seitz  <keiths@redhat.com>
5422
5423         From Siddhesh Poyarekar:
5424         * f-lang.h (f77_get_upperbound): Return LONGEST.
5425         (f77_get_lowerbound): Likewise.
5426         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5427         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5428         print them.
5429         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5430         plongest to format print it.
5431         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5432         (f77_get_upperbound): Likewise.
5433         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5434         LOWER_BOUND to LONGEST.
5435         (f77_create_arrayprint_offset_tbl): Likewise.
5436
5437 2019-03-29  Keith Seitz  <keiths@redhat.com>
5438
5439         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5440         %s/pulongest for TYPE_LENGTH instead of %d in format
5441         strings.
5442         * ada-typerint.c (ada_print_type): Likewise.
5443         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5444         * compile/compile-c-support.c (generate_register_struct): Likewise.
5445         * gdbtypes.c (recursive_dump_type): Likewise.
5446         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5447         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5448         instead of %d in format strings.
5449         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5450         to std::min to ULONGEST.
5451         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5452         instead of %d in format strings.
5453         * tracepoint.c (info_scope_command): Likewise.
5454         * typeprint.c (print_offset_data::update)
5455         (print_offset_data::finish): Likewise.
5456         * xtensa-tdep.c (xtensa_store_return_value)
5457         (xtensa_push_dummy_call): Likewise.
5458
5459 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5460
5461         * windows-nat.c (display_selector): Fixed format specifications
5462         for 64-bit Cygwin.
5463
5464 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5465
5466         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5467
5468 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5469
5470         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5471         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5472         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5473         (nios2_linux_init_abi): Install it.
5474
5475 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5476
5477         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5478
5479 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5480
5481         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5482
5483 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5484             Tom Tromey  <tromey@adacore.com>
5485
5486         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5487
5488 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5489
5490         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5491         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5492         method to compute the bounds of range types. Also print "[evaluated]"
5493         if the bounds' values come from a dynamic evaluation.
5494
5495 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5496
5497         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5498         whitespace when pretty printing is on.
5499
5500 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5501
5502         * ppc-linux-nat.c: Add include.
5503
5504 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5505
5506         * NEWS: Mention AArch64 Pointer Authentication.
5507
5508 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5509
5510         * arm-linux-nat.c: Add include.
5511
5512 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5513
5514         * source-cache.c (source_cache::get_source_lines): Re-read
5515         fullname after calling open_source_file.
5516
5517 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5518
5519         * NEWS: Mention TLS support for FreeBSD.
5520
5521 2019-03-25  Tom Tromey  <tromey@adacore.com>
5522
5523         * minsyms.c (BUNCH_SIZE): Update comment.
5524         (~minimal_symbol_reader): Remove old comment.
5525         (compact_minimal_symbols): Update comment.
5526         (minimal_symbol_reader::install): Remove old comment.  Update
5527         other comments.
5528
5529 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5530
5531         * s390-linux-nat.c: Add include.
5532
5533 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5534
5535         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5536         Call linux_get_hwcap.
5537         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5538         Likewise.
5539         (aarch64_linux_get_hwcap): Remove function.
5540         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5541         declaration.
5542         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5543         linux_get_hwcap.
5544         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5545         * linux-tdep.c (linux_get_hwcap): Add function.
5546         (linux_get_hwcap2): Likewise.
5547         * linux-tdep.h (linux_get_hwcap): Add declaration.
5548         (linux_get_hwcap2): Likewise.
5549         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5550         (ppc_linux_get_hwcap2): Likewise.
5551         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5552         linux_get_hwcap.
5553         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5554         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5555         (ppc_linux_nat_target::read_description): Likewise.
5556         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5557         * s390-linux-nat.c: Likewise.
5558         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5559
5560 2019-03-24  Tom Tromey  <tom@tromey.com>
5561
5562         * ada-lang.c (standard_lookup): Simplify initialization.
5563         (ada_lookup_symbol_nonlocal): Simplify return.
5564         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5565         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5566         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5567         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5568         initialization.
5569         * solib.c (solib_global_lookup): Simplify.
5570         * symtab.c (null_block_symbol): Remove.
5571         (symbol_cache_lookup): Simplify returns.
5572         (lookup_language_this): Simplify returns.
5573         (lookup_symbol_aux): Simplify return.
5574         (lookup_local_symbol): Simplify returns.
5575         (lookup_global_symbol_from_objfile): Simplify return.
5576         (lookup_symbol_in_objfile_symtabs)
5577         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5578         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5579         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5580         * cp-namespace.c (cp_lookup_bare_symbol)
5581         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5582         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5583         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5584         (cp_lookup_symbol_via_imports): Simplify initialization.
5585         (find_symbol_in_baseclass): Likewise.
5586         * symtab.h (null_block_symbol): Remove.
5587         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5588         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5589         (d_lookup_symbol_module): Likewise.
5590         (find_symbol_in_baseclass): Simplify initialization.
5591
5592 2019-03-24  Tom Tromey  <tom@tromey.com>
5593
5594         * expression.h: Don't include symtab.h.
5595         (struct block): Forward declare.
5596
5597 2019-03-24  Tom Tromey  <tom@tromey.com>
5598
5599         * c-exp.y (typebase): Remove casts.
5600         * gdbtypes.c (lookup_unsigned_typename, )
5601         (lookup_signed_typename): Remove cast.
5602         * eval.c (parse_to_comma_and_eval): Remove cast.
5603         * parse.c (write_dollar_variable): Remove cast.
5604         * block.h (struct block) <superblock>: Now const.
5605         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5606         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5607         (map_block): Make "block" const.
5608         * symfile.h (struct quick_symbol_functions)
5609         <map_matching_symbols>: Constify block argument to "callback".
5610         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5611         const.
5612         (find_pc_sect_compunit_symtab): Make "b" const.
5613         (find_symbol_at_address): Likewise.
5614         (search_symbols): Likewise.
5615         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5616         (dw2_debug_names_lookup_symbol): Likewise.
5617         (dw2_map_matching_symbols): Update.
5618         * p-valprint.c (pascal_val_print): Remove "block".
5619         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5620         (aux_add_nonlocal_symbols): Make "block" const.
5621         (resolve_subexp): Remove cast.
5622         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5623         const.
5624         (iterate_over_file_blocks): Likewise.
5625         * f-exp.y (%union) <bval>: Remove.
5626         * coffread.c (patch_opaque_types): Make "b" const.
5627         * spu-tdep.c (spu_catch_start): Make "block" const.
5628         * c-valprint.c (print_unpacked_pointer): Remove "block".
5629         * symmisc.c (dump_symtab_1): Make "b" const.
5630         (block_depth): Make "block" const.
5631         * d-exp.y (%union) <bval>: Remove.
5632         * cp-support.h (cp_lookup_rtti_type): Update.
5633         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5634         * psymtab.c (psym_lookup_symbol): Make "block" const.
5635         (maintenance_check_psymtabs): Make "b" const.
5636         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5637         (enumerate_locals, enumerate_args): Update.
5638         * python/py-symtab.c (stpy_global_block): Make "block" const.
5639         (stpy_static_block): Likewise.
5640         * inline-frame.c (block_starting_point_at): Make "new_block"
5641         const.
5642         * block.c (find_block_in_blockvector): Make return type const.
5643         (blockvector_for_pc_sect): Make "b" const.
5644         (find_block_in_blockvector): Make "b" const.
5645
5646 2019-03-23  Tom Tromey  <tom@tromey.com>
5647
5648         * varobj.c (varobj_create): Update.
5649         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5650         * printcmd.c (display_command, do_one_display): Don't reset
5651         innermost_block.
5652         * parser-defs.h (enum innermost_block_tracker_type): Move to
5653         expression.h.
5654         (innermost_block): Update comment.
5655         * parse.c (parse_exp_1): Add tracker_types parameter.
5656         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5657         tracker_types parameter.  Reset innermost_block.
5658         (parse_exp_in_context): Remove.
5659         (parse_expression_for_completion): Update.
5660         * objfiles.c (~objfile): Don't reset expression_context_block or
5661         innermost_block.
5662         * expression.h (enum innermost_block_tracker_type): Move from
5663         parser-defs.h.
5664         (parse_exp_1): Add tracker_types parameter.
5665         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5666         reset innermost_block.
5667
5668 2019-03-23  Tom Tromey  <tom@tromey.com>
5669
5670         * objfiles.h: Include bcache.h.
5671
5672 2019-03-23  Tom Tromey  <tom@tromey.com>
5673
5674         * linespec.c (get_current_search_block): Use
5675         scoped_restore_current_language.
5676         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5677
5678 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5679             Jiong Wang  <jiong.wang@arm.com>
5680
5681         * aarch64-linux-tdep.c
5682         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5683         section.
5684         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5685
5686 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5687             Jiong Wang  <jiong.wang@arm.com>
5688
5689         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5690         instructions.
5691         (aarch64_analyze_prologue_test): Add PACIASP test.
5692         (aarch64_prologue_prev_register): Unmask PC value.
5693
5694 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5695             Jiong Wang  <jiong.wang@arm.com>
5696
5697         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5698         (aarch64_dwarf2_prev_register): Unmask PC value.
5699         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5700         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5701         DW_CFA_AARCH64_negate_ra_state.
5702         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5703
5704 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5705             Jiong Wang  <jiong.wang@arm.com>
5706
5707         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5708         registers.
5709         (aarch64_pseudo_register_name): Likewise.
5710         (aarch64_pseudo_register_type): Likewise.
5711         (aarch64_pseudo_register_reggroup_p): Likewise.
5712         (aarch64_gdbarch_init): Add pauth registers.
5713         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5714         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5715         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5716         (struct gdbarch_tdep): Add regnum for ra_state.
5717
5718 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5719             Jiong Wang  <jiong.wang@arm.com>
5720
5721         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5722
5723 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5724             Jiong Wang  <jiong.wang@arm.com>
5725
5726         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5727         function.
5728         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5729         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5730         (aarch64_gdbarch_init): Add puth registers.
5731         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5732         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5733         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5734
5735 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5736             Jiong Wang  <jiong.wang@arm.com>
5737
5738         * aarch64-linux-nat.c
5739         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5740         * aarch64-linux-tdep.c
5741         (aarch64_linux_core_read_description): Likewise.
5742         (aarch64_linux_get_hwcap): New function.
5743         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5744         (aarch64_linux_get_hwcap): New declaration.
5745
5746 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5747             Jiong Wang  <jiong.wang@arm.com>
5748
5749         * aarch64-linux-nat.c
5750         (aarch64_linux_nat_target::read_description): Add pauth param.
5751         * aarch64-linux-tdep.c
5752         (aarch64_linux_core_read_description): Likewise.
5753         * aarch64-tdep.c (struct target_desc): Add in pauth.
5754         (aarch64_read_description): Add pauth param.
5755         (aarch64_gdbarch_init): Likewise.
5756         * aarch64-tdep.h (aarch64_read_description): Likewise.
5757         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5758         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5759         * features/Makefile: Add new files.
5760         * features/aarch64-pauth.c: New file.
5761         * features/aarch64-pauth.xml: New file.
5762
5763 2019-03-20  Tom Tromey  <tromey@adacore.com>
5764
5765         * infrun.c (handle_inferior_event): Rename from
5766         handle_inferior_event_1.  Create a scoped_value_mark.
5767         (handle_inferior_event): Remove.
5768
5769 2019-03-19  Tom Tromey  <tromey@adacore.com>
5770
5771         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5772         * infrun.h (print_stop_event): Add "displays" parameter.
5773         * infrun.c (print_stop_event): Add "displays" parameter.
5774
5775 2019-03-19  Pedro Alves  <palves@redhat.com>
5776
5777         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5778         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5779         to -1.  Fix TABs vs spaces.
5780         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5781         * tui/tui-out.h (tui_ui_out) Add intro comments.
5782         <m_line, m_start_of_line>: In-class initialize, and add describing
5783         comment.
5784
5785 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5786
5787         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5788         variable names.
5789         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5790
5791 2019-03-18  Pedro Alves  <palves@redhat.com>
5792             Eli Zaretskii <eliz@gnu.org>
5793
5794         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5795         m_line and m_start_of_line.
5796
5797 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5798
5799         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5800         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5801         it returns a newline.  This fixes a regression in TU mode, whereby
5802         the next line is output on the same screen line as the user input.
5803
5804 2019-03-18  Tom Tromey  <tromey@adacore.com>
5805
5806         * minsyms.c (minimal_symbol_reader::install): Remove call to
5807         obstack_blank.
5808
5809 2019-03-18  Pedro Alves  <palves@redhat.com>
5810
5811         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5812         New globals.
5813         (apply_style): New, factored out from ...
5814         (apply_ansi_escape): ... this.  Handle reverse video mode.
5815         (tui_set_reverse_mode): New function.
5816         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5817         * tui/tui-winsource.c (tui_show_source_line): Use
5818         tui_set_reverse_mode instead of setting A_STANDOUT.
5819         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5820         New setter methods.
5821
5822 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5823
5824         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5825         Handle tabs.
5826
5827 2019-03-18  Tom Tromey  <tromey@adacore.com>
5828
5829         * ada-lang.c (empty_array): Add "high" parameter.
5830         (ada_evaluate_subexp): Update.
5831
5832 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5833
5834         * unittests/string_view-selftests.c: Define
5835         _initialize_string_view_selftests unconditionally.
5836
5837 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5838
5839         PR gdb/24350
5840         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5841
5842 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5843
5844         PR gdb/24351
5845         * windows-nat.c (display_selector): Fix format specifiers.
5846
5847 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5848
5849         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5850         tui_refill_source_window instead of tui_refresh_win, to update the
5851         current execution line.  This fixes redisplay of the current line
5852         when stepping through the code with "next" or "step".
5853
5854 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5855
5856         * source-cache.c (source_cache::get_source_lines): Call
5857         find_source_lines to initialize s->nlines.  This fixes vertical
5858         scrolling of TUI source window when the DOWN arrow is pressed.
5859
5860 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5861
5862         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5863         linux-thread-db.c (_initialize_thread_db): Likewise.
5864
5865 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5866
5867         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5868         wclrtoeol in tui_show_source_line".  This reverts changes made in
5869         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5870
5871 2019-03-15  Tom Tromey  <tom@tromey.com>
5872
5873         * symtab.h (struct minimal_symbol): Derive from
5874         general_symbol_info.
5875         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5876         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5877         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5878         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5879         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5880         (MSYMBOL_SEARCH_NAME): Update.
5881         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5882         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5883         * minsyms.c (minimal_symbol_reader::record_full): Update.
5884
5885 2019-03-15  Tom Tromey  <tom@tromey.com>
5886
5887         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5888
5889 2019-03-15  Tom Tromey  <tom@tromey.com>
5890
5891         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5892         unique_xmalloc_ptr.
5893         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5894         Update.
5895         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5896         (build_minimal_symbol_hash_tables)
5897         (minimal_symbol_reader::install): Update.
5898
5899 2019-03-15  Tom Tromey  <tom@tromey.com>
5900
5901         * symtab.c (create_demangled_names_hash): Update.
5902         (symbol_set_names): Update.
5903         * objfiles.h (struct objfile_per_bfd_storage)
5904         <demangled_names_hash>: Now an htab_up.
5905         * objfiles.c (objfile_per_bfd_storage): Simplify.
5906
5907 2019-03-15  Tom Tromey  <tom@tromey.com>
5908
5909         * objfiles.h (struct objfile_per_bfd_storage): Declare
5910         destructor.
5911         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5912         New.
5913         (get_objfile_bfd_data): Use new.  Don't initialize
5914         language_of_main.
5915         (free_objfile_per_bfd_storage): Remove.
5916         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5917
5918 2019-03-15  Tom Tromey  <tom@tromey.com>
5919
5920         * symfile.c (reread_symbols): Update.
5921         * objfiles.c (objfile::objfile): Update.
5922         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5923         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5924         comment.
5925         (minimal_symbol_reader::install): Update.
5926         (terminate_minimal_symbol_table): Remove.
5927         * jit.c (jit_object_close_impl): Update.
5928
5929 2019-03-15  Tom Tromey  <tom@tromey.com>
5930
5931         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5932         initializations.
5933
5934 2019-03-15  Tom Tromey  <tom@tromey.com>
5935
5936         * objfiles.h (struct objfile_per_bfd_storage)
5937         <demangled_hash_languages>: Now a bitset.
5938         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5939         (lookup_minimal_symbol): Update.
5940
5941 2019-03-15  Tom Tromey  <tom@tromey.com>
5942
5943         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5944         Don't return the symbol.
5945         * coffread.c (record_minimal_symbol): Use record_full.
5946
5947 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5948
5949         The MS-Windows port of ncurses fails to switch to a color pair if
5950         one or both of the colors are the implicit default colors.  This
5951         change records the default colors when TUI is initialized, and
5952         then specifies them explicitly when a color pair uses the default
5953         colors.  This allows color styling in TUI mode on MS-Windows.
5954
5955         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5956         ncurses_norm_attr.
5957         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5958         colors in ncurses_norm_attr.
5959         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5960         "none", replace it with the default color recorded in
5961         ncurses_norm_attr.
5962
5963 2019-03-14  Tom Tromey  <tromey@adacore.com>
5964
5965         * source-cache.h (class source_cache) <get_source_lines>: Return
5966         std::string.
5967         * source-cache.c (source_cache::extract_lines): Handle case where
5968         first_pos==npos.  Return std::string.
5969         (source_cache::get_source_lines): Update.
5970
5971 2019-03-14  Tom Tromey  <tromey@adacore.com>
5972
5973         * NEWS: Add item for "style sources" commands.
5974         * source-cache.c (source_cache::get_source_lines): Check
5975         source_styling.
5976         * cli/cli-style.c (source_styling): New global.
5977         (_initialize_cli_style): Add "style sources" commands.
5978         (show_style_sources): New function.
5979         * cli/cli-style.h (source_styling): Declare.
5980
5981 2019-03-14  Pedro Alves  <palves@redhat.com>
5982             Tom Tromey  <tromey@adacore.com>
5983
5984         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5985         * tui/tui-winsource.c (tui_refill_source_window): New function,
5986         from...
5987         (tui_horizontal_source_scroll): ... here.  Move some logic.
5988         * cli/cli-style.c (set_style_enabled): Notify new observable.
5989         * tui/tui-hooks.c (tui_redisplay_source): New function.
5990         (tui_attach_detach_observers): Attach or detach
5991         tui_redisplay_source.
5992         * observable.h (source_styling_changed): New observable.
5993         * observable.c: Define source_styling_changed observable.
5994
5995 2019-03-13  Tom Tromey  <tromey@adacore.com>
5996
5997         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5998         (i386_gnu_nat_target::store_registers): Update.
5999         * target-debug.h (target_debug_print_std_string): New macro.
6000         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6001         * windows-tdep.c (display_one_tib): Update.
6002         * tui/tui-stack.c (tui_make_status_line): Update.
6003         * top.c (print_inferior_quit_action): Update.
6004         * thread.c (thr_try_catch_cmd): Update.
6005         (add_thread_with_info): Update.
6006         (thread_target_id_str): Update.
6007         (thr_try_catch_cmd): Update.
6008         (thread_command): Update.
6009         (thread_find_command): Update.
6010         * record-btrace.c (record_btrace_target::info_record)
6011         (record_btrace_resume_thread, record_btrace_target::resume)
6012         (record_btrace_cancel_resume, record_btrace_step_thread)
6013         (record_btrace_target::wait, record_btrace_target::wait)
6014         (record_btrace_target::wait, record_btrace_target::stop): Update.
6015         * progspace.c (print_program_space): Update.
6016         * process-stratum-target.c
6017         (process_stratum_target::thread_address_space): Update.
6018         * linux-fork.c (linux_fork_mourn_inferior)
6019         (detach_checkpoint_command, info_checkpoints_command)
6020         (linux_fork_context): Update.
6021         (linux_fork_detach): Update.
6022         (class scoped_switch_fork_info): Update.
6023         (delete_checkpoint_command): Update.
6024         * infrun.c (follow_fork_inferior): Update.
6025         (follow_fork_inferior): Update.
6026         (proceed_after_vfork_done): Update.
6027         (handle_vfork_child_exec_or_exit): Update.
6028         (follow_exec): Update.
6029         (displaced_step_prepare_throw): Update.
6030         (displaced_step_restore): Update.
6031         (start_step_over): Update.
6032         (resume_1): Update.
6033         (clear_proceed_status_thread): Update.
6034         (proceed): Update.
6035         (print_target_wait_results): Update.
6036         (do_target_wait): Update.
6037         (context_switch): Update.
6038         (stop_all_threads): Update.
6039         (restart_threads): Update.
6040         (finish_step_over): Update.
6041         (handle_signal_stop): Update.
6042         (switch_back_to_stepped_thread): Update.
6043         (keep_going_pass_signal): Update.
6044         (print_exited_reason): Update.
6045         (normal_stop): Update.
6046         * inferior.c (inferior_pid_to_str): Change return type.
6047         (print_selected_inferior): Update.
6048         (add_inferior): Update.
6049         (detach_inferior): Update.
6050         * dummy-frame.c (fprint_dummy_frames): Update.
6051         * dcache.c (dcache_info_1): Update.
6052         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6053         (btrace_fetch, btrace_clear): Update.
6054         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6055         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6056         type.
6057         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6058         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6059         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6060         * gdbarch.c, gdbarch.h: Rebuild.
6061         * gdbarch.sh (core_pid_to_str): Change return type.
6062         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6063         return type.
6064         (windows_nat_target::pid_to_str): Change return type.
6065         (windows_delete_thread): Update.
6066         (windows_nat_target::attach): Update.
6067         (windows_nat_target::files_info): Update.
6068         * target-delegates.c: Rebuild.
6069         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6070         return type.
6071         (sol_thread_target::pid_to_str): Change return type.
6072         * remote.c (class remote_target) <pid_to_str>: Change return
6073         type.
6074         (remote_target::pid_to_str): Change return type.
6075         (extended_remote_target::attach, remote_target::remote_stop_ns)
6076         (remote_target::remote_notif_remove_queued_reply)
6077         (remote_target::push_stop_reply, remote_target::disable_btrace):
6078         Update.
6079         (extended_remote_target::attach): Update.
6080         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6081         type.
6082         (gdbsim_target::pid_to_str): Change return type.
6083         * ravenscar-thread.c (struct ravenscar_thread_target)
6084         <pid_to_str>: Change return type.
6085         (ravenscar_thread_target::pid_to_str): Change return type.
6086         * procfs.c (class procfs_target) <pid_to_str>: Change return
6087         type.
6088         (procfs_target::pid_to_str): Change return type.
6089         (procfs_target::attach): Update.
6090         (procfs_target::detach): Update.
6091         (procfs_target::fetch_registers): Update.
6092         (procfs_target::store_registers): Update.
6093         (procfs_target::wait): Update.
6094         (procfs_target::files_info): Update.
6095         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6096         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6097         return type.
6098         (nto_procfs_target::pid_to_str): Change return type.
6099         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6100         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6101         return type.
6102         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6103         (exit_lwp): Update.
6104         (attach_proc_task_lwp_callback, get_detach_signal)
6105         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6106         (linux_nat_target::resume, wait_lwp, stop_callback)
6107         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6108         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6109         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6110         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6111         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6112         type.
6113         (inf_ptrace_target::attach): Update.
6114         (inf_ptrace_target::files_info): Update.
6115         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6116         type.
6117         (go32_nat_target::pid_to_str): Change return type.
6118         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6119         (gnu_nat_target::wait): Update.
6120         (gnu_nat_target::wait): Update.
6121         (gnu_nat_target::resume): Update.
6122         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6123         (fbsd_nat_target::wait): Update.
6124         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6125         type.
6126         (darwin_nat_target::attach): Update.
6127         * corelow.c (class core_target) <pid_to_str>: Change return type.
6128         (core_target::pid_to_str): Change return type.
6129         * target.c (normal_pid_to_str): Change return type.
6130         (default_pid_to_str): Likewise.
6131         (target_pid_to_str): Change return type.
6132         (target_translate_tls_address): Update.
6133         (target_announce_detach): Update.
6134         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6135         return type.
6136         (bsd_uthread_target::pid_to_str): Change return type.
6137         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6138         type.
6139         (bsd_kvm_target::pid_to_str): Change return type.
6140         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6141         return type.
6142         (aix_thread_target::pid_to_str): Change return type.
6143         * target.h (struct target_ops) <pid_to_str>: Change return type.
6144         (target_pid_to_str, normal_pid_to_str): Likewise.
6145         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6146         type.
6147         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6148         type.
6149         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6150         return type.
6151         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6152         type.
6153         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6154         type.
6155         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6156         return type.
6157
6158 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6159
6160         * NEWS: Mention that the new default MI version is 3.  Mention
6161         changes to the output of commands and events that deal with
6162         multi-location breakpoints.
6163         * breakpoint.c: Include "mi/mi-out.h".
6164         (print_one_breakpoint): Change output syntax if using MI version
6165         >= 3.
6166         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6167         New.
6168         (mi_multi_location_breakpoint_output_fixed): New.
6169         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6170         (mi_cmd_fix_multi_location_breakpoint_output): New.
6171         (mi_multi_location_breakpoint_output_fixed): New.
6172         * mi/mi-cmds.c (mi_cmds): Register command
6173         -fix-multi-location-breakpoint-output.
6174         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6175         interpreter "mi".
6176
6177 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6178
6179         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6180         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6181         instantiate mi_ui_out based on interpreter name.
6182         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6183         * mi/mi-main.c (mi_load_progress): Likewise.
6184
6185 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6186
6187         * NEWS: Combine separate "New targets" sections for 8.3.
6188
6189 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6190
6191         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6192         (ppcfbsd_init_abi): Install gdbarch
6193         "fetch_tls_load_module_address" and "get_thread_local_address"
6194         methods.
6195
6196 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6197
6198         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6199         (riscv_fbsd_init_abi): Install gdbarch
6200         "fetch_tls_load_module_address" and "get_thread_local_address"
6201         methods.
6202
6203 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6204
6205         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6206         (i386fbsd_init_abi): Install gdbarch
6207         "fetch_tls_load_module_address" and "get_thread_local_address"
6208         methods.
6209
6210 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6211
6212         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6213         (amd64fbsd_init_abi): Install gdbarch
6214         "fetch_tls_load_module_address" and "get_thread_local_address"
6215         methods.
6216
6217 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6218
6219         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6220         (struct fbsd_pspace_data): New type.
6221         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6222         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6223         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6224         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6225         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6226
6227 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6228
6229         * gdbtypes.c (lookup_struct_elt): New function.
6230         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6231         * gdbtypes.h (struct struct_elt): New type.
6232         (lookup_struct_elt): New prototype.
6233
6234 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6235
6236         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6237         remove disabled code block.
6238
6239 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6240
6241         * gdbarch.sh (get_thread_local_address): New method.
6242         * gdbarch.h, gdbarch.c: Regenerate.
6243         * target.c (target_translate_tls_address): Use
6244         gdbarch_get_thread_local_address if present instead of
6245         target::get_thread_local_address.
6246
6247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6248
6249         * target.h (target::get_thread_local_address): Update comment.
6250
6251 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6252
6253         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6254         objfile->separate_debug_objfile_backlink if not NULL.
6255
6256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6257
6258         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6259         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6260         (amd64bsd_store_inferior_registers): Likewise.
6261         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6262         Enable segment base registers.
6263         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6264         PT_GETFSBASE and PT_GETGSBASE.
6265         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6266         PT_SETGSBASE.
6267         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6268         segment base registers.
6269         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6270
6271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6272
6273         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6274         Update calls to i386_target_description to add 'segments'
6275         parameter.
6276         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6277         add segment base registers.
6278         * arch/i386.c (i386_create_target_description): Add 'segments'
6279         parameter to enable segment base registers.
6280         * arch/i386.h (i386_create_target_description): Likewise.
6281         * features/i386/32bit-segments.xml: New file.
6282         * features/i386/32bit-segments.c: Generate.
6283         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6284         call to i386_target_description to add 'segments' parameter.
6285         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6286         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6287         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6288         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6289         if feature is present.
6290         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6291         Add 'segments' parameter to call to i386_target_description.
6292         (i386_target_description): Add 'segments' parameter to enable
6293         segment base registers.
6294         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6295         to call to i386_target_description.
6296         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6297         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6298         Define I386_NUM_REGS.
6299         (i386_target_description): Add 'segments' parameter to enable
6300         segment base registers.
6301
6302 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6303
6304         PR/24325
6305         * source-cache.c: #undef open and close, to avoid unresolved
6306         externals during linking.
6307
6308 2019-03-12  Tom Tromey  <tromey@adacore.com>
6309
6310         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6311         const.  Add initializers.
6312         (_initialize_remote): Don't initialize ptid globals.
6313
6314 2019-03-12  Pedro Alves  <palves@redhat.com>
6315
6316         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6317
6318 2019-03-12  Pedro Alves  <palves@redhat.com>
6319
6320         * cp-name-parser.y (main): Remove unused 'len' variable.
6321
6322 2019-03-12  Tom Tromey  <tromey@adacore.com>
6323
6324         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6325         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6326
6327 2019-03-12  Tom Tromey  <tromey@adacore.com>
6328
6329         * linux-nat.c (iterate_over_lwps): Update.
6330         (stop_callback): Remove parameter.
6331         (stop_wait_callback, detach_callback, resume_set_callback)
6332         (select_singlestep_lwp_callback, set_ignore_sigint)
6333         (status_callback, resumed_callback, resume_clear_callback)
6334         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6335         data parameter.
6336         (linux_nat_target::detach, linux_nat_target::resume)
6337         (linux_stop_and_wait_all_lwps, select_event_lwp)
6338         (linux_nat_filter_event, linux_nat_wait_1)
6339         (linux_nat_target::kill, linux_nat_target::stop)
6340         (linux_nat_target::stop): Update.
6341         (linux_nat_resume_callback): Change type.
6342         (resume_stopped_resumed_lwps, count_events_callback)
6343         (select_event_lwp_callback): Likewise.
6344         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6345         * arm-linux-nat.c (struct update_registers_data): Remove.
6346         (update_registers_callback): Change type.
6347         (arm_linux_insert_hw_breakpoint1): Update.
6348         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6349         parameter.
6350         (x86_linux_dr_set_addr): Update.
6351         (x86_linux_dr_set_control): Update.
6352         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6353         (iterate_over_lwps): Use gdb::function_view.
6354         * nat/aarch64-linux-hw-point.c (struct
6355         aarch64_dr_update_callback_param): Remove.
6356         (debug_reg_change_callback): Change type.
6357         (aarch64_notify_debug_reg_change): Update.
6358         * s390-linux-nat.c (s390_refresh_per_info): Update.
6359
6360 2019-03-11  Tom Tromey  <tromey@adacore.com>
6361
6362         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6363         redundant assignment to "this_cu".
6364
6365 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6366
6367         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6368
6369 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6370
6371         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6372         from...
6373         (rank_one_type): ... this.
6374
6375 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6376
6377         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6378         from...
6379         (rank_one_type): ... this.
6380
6381 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6382
6383         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6384         from...
6385         (rank_one_type): ... this.
6386
6387 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6388
6389         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6390         from...
6391         (rank_one_type): ... this.
6392
6393 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6394
6395         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6396         from...
6397         (rank_one_type): ... this.
6398
6399 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6400
6401         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6402         from...
6403         (rank_one_type): ... this.
6404
6405 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6406
6407         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6408         from...
6409         (rank_one_type): ... this.
6410
6411 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6412
6413         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6414         from...
6415         (rank_one_type): ... this.
6416
6417 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6418
6419         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6420         from...
6421         (rank_one_type): ... this.
6422
6423 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6424
6425         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6426         from...
6427         (rank_one_type): ... this.
6428
6429 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6430
6431         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6432         from...
6433         (rank_one_type): ... this.
6434
6435 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6436
6437         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6438         from...
6439         (rank_one_type): ... this.
6440
6441 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6442
6443         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6444         inferior-events' shows the example events.
6445
6446 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6447
6448         Support styling on native MS-Windows console
6449
6450         PR/24315
6451         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6452         on MS-Windows if $TERM is not defined.
6453
6454         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6455
6456         * posix-hdep.c (gdb_console_fputs):
6457         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6458         functions.
6459         * ui-file.h (gdb_console_fputs): Add prototype.
6460
6461         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6462         back to fputs only if the former returns zero.
6463
6464 2019-03-07  Tom Tromey  <tom@tromey.com>
6465
6466         * symmisc.c (print_symbol_bcache_statistics): Update.
6467         (print_objfile_statistics): Update.
6468         * symfile.c (allocate_symtab): Update.
6469         * stabsread.c: Don't include bcache.h.
6470         * psymtab.h (struct psymbol_bcache): Don't declare.
6471         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6472         (psymbol_bcache_init, psymbol_bcache_free)
6473         (psymbol_bcache_get_bcache): Don't declare.
6474         * psymtab.c (struct psymbol_bcache): Remove.
6475         (psymtab_storage::psymtab_storage): Update.
6476         (psymtab_storage::~psymtab_storage): Update.
6477         (psymbol_bcache_init, psymbol_bcache_free)
6478         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6479         (add_psymbol_to_bcache): Update.
6480         (allocate_psymtab): Update.
6481         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6482         macro_cache>: No longer pointers.
6483         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6484         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6485         * macrotab.c (macro_bcache): Update.
6486         * macroexp.c: Don't include bcache.h.
6487         * gdbtypes.c (check_types_worklist): Update.
6488         (types_deeply_equal): Remove TRY/CATCH.  Update.
6489         * elfread.c (elf_symtab_read): Update.
6490         * dwarf2read.c: Don't include bcache.h.
6491         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6492         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6493         (print_bcache_statistics, bcache_memory_used): Don't declare.
6494         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6495         methods.  Rename all data members.
6496         * bcache.c (struct bcache): Move to bcache.h.
6497         (bcache::expand_hash_table): Rename from expand_hash_table.
6498         (bcache): Remove.
6499         (bcache::insert): Rename from bcache_full.
6500         (bcache::compare): Rename from bcache_compare.
6501         (bcache_xmalloc): Remove.
6502         (bcache::~bcache): Rename from bcache_xfree.
6503         (bcache::print_statistics): Rename from print_bcache_statistics.
6504         (bcache::memory_used): Rename from bcache_memory_used.
6505
6506 2019-03-07  Pedro Alves  <palves@redhat.com>
6507
6508         * infrun.c (normal_stop): Also check for
6509         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6510
6511 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6512
6513         * f-lang.c (value_from_host_double): Moved to...
6514         * value.c (value_from_host_double): ...here.
6515         * value.h (value_from_host_double): Declare.
6516         * guile/scm-math.c (vlscm_convert_typed_number): Use
6517         value_from_host_double.
6518         (vlscm_convert_number): Likewise.
6519         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6520         * python/py-value.c (convert_value_from_python): Likewise.
6521
6522 2019-03-06  Tom Tromey  <tom@tromey.com>
6523
6524         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6525
6526 2019-03-06  Tom Tromey  <tom@tromey.com>
6527
6528         * utils.h (free_current_contents): Don't declare.
6529         * utils.c (free_current_contents): Remove.
6530
6531 2019-03-06  Tom Tromey  <tom@tromey.com>
6532
6533         * top.c (quit_force): Update.
6534         * main.c (captured_command_loop): Update.
6535         * common/new-op.c (operator new): Update.
6536         * common/common-exceptions.c (struct catcher)
6537         <save_cleanup_chain>: Remove member.
6538         (exceptions_state_mc_init): Update.
6539         (exception_try_scope_entry): Return nullptr.
6540         (exception_try_scope_exit, exception_rethrow)
6541         (throw_exception_sjlj, throw_exception_cxx): Update.
6542         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6543         (all_cleanups, do_cleanups, discard_cleanups)
6544         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6545         (restore_cleanups, restore_final_cleanups): Don't declare.
6546         (do_final_cleanups): Remove parameter.
6547         * common/cleanups.c (cleanup_chain, make_cleanup)
6548         (make_cleanup_dtor, all_cleanups, do_cleanups)
6549         (discard_my_cleanups, discard_cleanups)
6550         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6551         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6552         (null_cleanup): Remove.
6553         (do_final_cleanups): Remove parameter.
6554
6555 2019-03-06  Tom Tromey  <tom@tromey.com>
6556
6557         * remote.c (remote_target::remote_parse_stop_reply): Use
6558         unique_xmalloc_ptr.
6559
6560 2019-03-06  Tom Tromey  <tom@tromey.com>
6561
6562         * stabsread.c (struct stabs_field_info): Rename from field_info.
6563         <list, fnlist>: Add initializers.
6564         <obstack>: New member.
6565         (read_member_functions, read_struct_fields, read_baseclasses):
6566         Allocate on obstack.  Don't use cleanups.
6567         (read_one_struct_field, read_member_functions, read_struct_fields)
6568         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6569         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6570         (read_struct_type): Update.
6571
6572 2019-03-06  Tom Tromey  <tom@tromey.com>
6573
6574         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6575         * common/filestuff.h (make_cleanup_close): Don't declare.
6576         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6577         Remove.
6578
6579 2019-03-06  Tom Tromey  <tom@tromey.com>
6580
6581         * solib-aix.c: Use make_scope_exit.
6582
6583 2019-03-06  Tom Tromey  <tom@tromey.com>
6584
6585         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6586         Use make_scope_exit.
6587
6588 2019-03-06  Tom Tromey  <tom@tromey.com>
6589
6590         * solib-svr4.c (disable_probes_interface): Remove parameter.
6591         (svr4_handle_solib_event): Use make_scope_exit.
6592
6593 2019-03-06  Tom Tromey  <tom@tromey.com>
6594
6595         * remote.c (struct stop_reply_deleter): Remove.
6596         (stop_reply_up): Update.
6597         (struct stop_reply): Derive from notif_event.  Don't typedef.
6598         <regcache>: Now a std::vector.
6599         (stop_reply_xfree): Remove.
6600         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6601         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6602         (remote_target::discard_pending_stop_replies): Use delete.
6603         (remote_target::remote_parse_stop_reply): Update.
6604         (remote_target::process_stop_reply): Update.
6605         * remote-notif.h (struct notif_event): Add virtual destructor.
6606         Remove "dtr" member.
6607         (struct notif_client) <alloc_event>: Return a unique_ptr.
6608         (notif_event_xfree): Don't declare.
6609         (notif_event_up): New typedef.
6610         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6611         (notif_event_xfree, do_notif_event_xfree): Remove.
6612         (remote_notif_state_xfree): Update.
6613
6614 2019-03-06  Tom Tromey  <tom@tromey.com>
6615
6616         * infrun.c (displaced_step_clear_cleanup): Now a
6617         forward_scope_exit type.
6618         (displaced_step_prepare_throw): Update.
6619         (displaced_step_fixup): Update.
6620
6621 2019-03-06  Tom Tromey  <tom@tromey.com>
6622
6623         * inferior.h (class inferior): Update comment.
6624         * gdbthread.h (class thread_info): Update comment.
6625
6626 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6627             Tom Tromey  <tom@tromey.com>
6628
6629         * stabsread.h (struct stab_section_list): Remove.
6630         (coffstab_build_psymtabs): Update.
6631         * dbxread.c (symbuf_sections): Now a std::vector.
6632         (sect_idx): New global.
6633         (fill_symbuf): Update.
6634         (coffstab_build_psymtabs): Change type of stabsects parameter.
6635         Update.
6636         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6637         std::vector.
6638         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6639         (coff_locate_sections): Update.
6640         (coff_symfile_read): Remove cleanups.  Update.
6641         (init_stringtab): Add storage parameter.
6642         (free_stringtab, free_stringtab_cleanup): Remove.
6643         (init_lineno): Add storage parameter.
6644         (free_linetab, free_linetab_cleanup): Remove.
6645
6646 2019-03-06  Pedro Alves  <palves@redhat.com>
6647
6648         * linux-fork.c (fork_info::clobber_regs): Delete.
6649         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6650         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6651         comment.  Adjust.
6652         (scoped_switch_fork_info::scoped_switch_fork_info)
6653         (checkpoint_command, linux_fork_context): Adjust
6654         fork_save_infrun_state calls.
6655
6656 2019-03-06  Pedro Alves  <palves@redhat.com>
6657
6658         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6659         (inf_has_multiple_threads): Return 'bool' and rewrite using
6660         inferior_info::threads().
6661
6662 2019-03-06  Pedro Alves  <palves@redhat.com>
6663
6664         * linux-fork.c: Include <list>.
6665         (fork_list): Now a std::list instance.
6666         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6667         (forks_exist_p, find_last_fork): Adjust.
6668         (new_fork): Delete.
6669         (one_fork_p): New.
6670         (add_fork): Adjust.
6671         (free_fork): Delete, folded into fork_info::~fork_info().
6672         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6673         Adjust.
6674         (init_fork_list): Delete.
6675         (linux_fork_killall, linux_fork_mourn_inferior)
6676         (linux_fork_detach, info_checkpoints_command): Adjust.
6677         (_initialize_linux_fork): No longer call init_fork_list.
6678
6679 2019-03-06  Pedro Alves  <palves@redhat.com>
6680
6681         * linux-fork.c (new_fork): New, split out of ...
6682         (add_fork): ... this.  Return void.  Move "first fork" special
6683         case from here, to ...
6684         (checkpoint_command): ... here.
6685         * linux-linux.h (add_fork): Return void.
6686
6687 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6688
6689         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6690
6691 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6692             Chris January  <chris.january@arm.com>
6693             David Lecomber  <david.lecomber@arm.com>
6694
6695         * f-exp.y: New token, UNOP_INTRINSIC.
6696         (exp): New pattern using UNOP_INTRINSIC token.
6697         (f77_keywords): Add 'abs' keyword.
6698         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6699         (value_from_host_double): New function.
6700         (evaluate_subexp_f): Support UNOP_ABS.
6701
6702 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6703
6704         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6705         types.
6706
6707 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6708
6709         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6710         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6711         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6712
6713 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6714
6715         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6716
6717 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6718             Chris January  <chris.january@arm.com>
6719
6720         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6721         * f-exp.y: Define 'KIND' token.
6722         (exp): New pattern for KIND expressions.
6723         (ptype): Handle types with a kind extension.
6724         (direct_abs_decl): Extend to spot kind extensions.
6725         (f77_keywords): Add 'kind' to the list.
6726         (push_kind_type): New function.
6727         (convert_to_kind_type): New function.
6728         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6729         * parse.c (operator_length_standard): Likewise.
6730         * parser-defs.h (enum type_pieces): Add tp_kind.
6731         * std-operator.def: Add UNOP_KIND.
6732
6733 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6734
6735         * f-exp.y (f_parse): Set yydebug.
6736
6737 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6738
6739         * f-lang.c (evaluate_subexp_f): New function.
6740         (exp_descriptor_f): New global.
6741         (f_language_defn): Use exp_descriptor_f instead of
6742         exp_descriptor_standard.
6743
6744 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6745
6746         * f-exp.y (struct token): Add comments.
6747         (dot_ops): Remove uppercase versions and the end marker.
6748         (f77_keywords): Likewise.
6749         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6750         entries in the dot_ops array are case insensitive, and use
6751         strncasecmp to compare strings.  Also some whitespace cleanup in
6752         this area.  Similar for the f77_keywords array, except entries in
6753         this list might be case sensitive.
6754
6755 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6756
6757         * f-exp.y (struct f77_boolean_val): Add comments.
6758         (boolean_values): Remove uppercase versions, and end marker.
6759         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6760         and use strncasecmp to achieve case insensitivity.  Additionally,
6761         perform whitespace cleanup around this code.
6762
6763 2019-03-06  Tom Tromey  <tromey@adacore.com>
6764
6765         * remote-sim.c (gdbsim_target_open): Use result of
6766         gdb_argv::release.
6767
6768 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6769         Dirk Schubert  <dirk.schubert@arm.com>
6770         Chris January  <chris.january@arm.com>
6771
6772         * eval.c (evaluate_subexp_standard): Call Fortran argument
6773         wrapping logic.
6774         * f-lang.c (struct value): A value which can be passed into a
6775         Fortran function call.
6776         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6777         where appropriate.
6778         (struct type): Value ready for a Fortran function call.
6779         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6780         is needed.
6781         * f-lang.h (fortran_argument_convert): Declaration.
6782         (fortran_preserve_arg_pointer): Declaration.
6783         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6784
6785 2019-03-05  Tom Tromey  <tromey@adacore.com>
6786
6787         * python/py-prettyprint.c (print_string_repr): Remove #if.
6788         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6789
6790 2019-03-05  Tom Tromey  <tromey@adacore.com>
6791
6792         * target.c (the_dummy_target): Move later.  Change type to
6793         "dummy_target".
6794         (initialize_targets): Don't initialize the_dummy_target.
6795
6796 2019-03-05  Tom Tromey  <tromey@adacore.com>
6797
6798         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6799         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6800
6801 2019-03-05  Tom Tromey  <tromey@adacore.com>
6802
6803         * windows-nat.c (windows_nat_target::attach)
6804         (windows_nat_target::detach): Don't call gdb_flush.
6805         * valprint.c (generic_val_print, val_print, val_print_string):
6806         Don't call gdb_flush.
6807         * utils.c (defaulted_query): Don't call gdb_flush.
6808         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6809         * target.c (target_announce_detach): Don't call gdb_flush.
6810         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6811         * remote.c (extended_remote_target::attach): Don't call
6812         gdb_flush.
6813         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6814         * printcmd.c (do_examine): Don't call gdb_flush.
6815         (info_display_command): Don't call gdb_flush.
6816         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6817         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6818         * memattr.c (info_mem_command): Don't call gdb_flush.
6819         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6820         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6821         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6822         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6823         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6824         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6825         (gnu_nat_target::detach): Don't call gdb_flush.
6826         * f-valprint.c (f_val_print): Don't call gdb_flush.
6827         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6828         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6829         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6830         gdb_flush.
6831         * c-valprint.c (c_val_print): Don't call gdb_flush.
6832         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6833
6834 2019-03-05  Tom Tromey  <tromey@adacore.com>
6835
6836         * varobj.c (update_dynamic_varobj_children): Update.
6837         (install_default_visualizer): Use reset, not release.
6838         * value.c (set_internalvar): Update.
6839         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6840         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6841         ATTRIBUTE_UNUSED_RESULT.
6842
6843 2019-03-05  Tom Tromey  <tromey@adacore.com>
6844
6845         * remote.c (class scoped_remote_fd) <release>: Add
6846         ATTRIBUTE_UNUSED_RESULT.
6847
6848 2019-03-05  Tom Tromey  <tromey@adacore.com>
6849
6850         * macroexp.c (struct macro_buffer) <release>: Add
6851         ATTRIBUTE_UNUSED_RESULT.
6852
6853 2019-03-05  Tom Tromey  <tromey@adacore.com>
6854
6855         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6856         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6857         ATTRIBUTE_UNUSED_RESULT.
6858
6859 2019-03-05  Tom Tromey  <tromey@adacore.com>
6860
6861         * common/scoped_fd.h (class scoped_fd) <release>: Add
6862         ATTRIBUTE_UNUSED_RESULT.
6863
6864 2019-03-05  Tom Tromey  <tromey@adacore.com>
6865
6866         * parser-defs.h (struct parser_state) <release>: Add
6867         ATTRIBUTE_UNUSED_RESULT.
6868
6869 2019-03-05  Tom Tromey  <tromey@adacore.com>
6870
6871         * utils.h (class gdb_argv) <release>: Add
6872         ATTRIBUTE_UNUSED_RESULT.
6873         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6874
6875 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6876
6877         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6878         for-loop range, to avoid compiler warnings.
6879
6880         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6881         avoid compiler warnings about unused variables.
6882
6883         * NEWS: Mention end of support for native debugging on MS-Windows
6884         before XP.
6885
6886         PR gdb/24292
6887         * common/netstuff.c:
6888         * gdbserver/gdbreplay.c
6889         * gdbserver/remote-utils.c:
6890         * ser-tcp.c:
6891         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6892         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6893         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6894         'getaddrinfo' and 'freeaddrinfo' were not available before
6895         Windows XP, and mingw.org's MinGW headers by default define
6896         _WIN32_WINNT to 0x500.
6897
6898 2019-03-01  Gary Benson <gbenson@redhat.com>
6899
6900         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6901
6902 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6903             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6904
6905         PR gdb/8527
6906         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6907         set_sigint_trap, clear_sigint_trap.
6908
6909 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6910
6911         * target.c (target_detach): Clear the regcache and the
6912         frame cache.
6913
6914 2019-02-27  Pedro Alves  <palves@redhat.com>
6915
6916         * utils.c (set_screen_size): When we cap the height/width sizes,
6917         tweak the corresponding command variable to show "unlimited":
6918
6919 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6920             Pedro Alves  <palves@redhat.com>
6921
6922         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6923         before calling rl_set_screen_size.
6924
6925 2019-02-27  Tom Tromey  <tromey@adacore.com>
6926
6927         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6928         define.
6929         * python/py-value.c: Remove Python 2.4 workaround.
6930         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6931         workaround.
6932         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6933         Python 2.4 workaround.
6934         * python/python-internal.h: Remove Python 2.4 comment.
6935         (Py_ssize_t): Don't define.
6936         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6937         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6938         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6939         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6940         * python/python.c (do_start_initialization): Remove Python 2.4
6941         workaround.
6942         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6943         (print_children): Remove Python 2.4 workaround.
6944         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6945         workaround.
6946         (CHARBUFFERPROC_NAME): Remove.
6947         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6948         Python 2.4 workaround.
6949
6950 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6951
6952         * NEWS: Note minimum Python version.
6953
6954 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6955
6956         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6957         code from these functions.  Remove corresponding ifdefs.  Use
6958         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6959         Remove gotos and target of gotos.
6960         (infpy_search_memory): Likewise.
6961
6962 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6963
6964         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6965         (hppa_gdbarch_init): Don't register deleted functions with
6966         gdbarch.
6967
6968 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6969
6970         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6971         (h8300_unwind_sp): Delete.
6972         (h8300_dummy_id): Delete.
6973         (h8300_gdbarch_init): Don't register deleted functions with
6974         gdbarch.
6975
6976 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6977
6978         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6979         (ft32_unwind_pc): Delete.
6980         (ft32_unwind_sp): Delete.
6981         (ft32_gdbarch_init): Don't register deleted functions with
6982         gdbarch.
6983
6984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6985
6986         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6987         (frv_unwind_pc): Delete.
6988         (frv_unwind_sp): Delete.
6989         (frv_gdbarch_init): Don't register deleted functions with
6990         gdbarch.
6991
6992 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6993
6994         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6995         (riscv_unwind_pc): Delete.
6996         (riscv_unwind_sp): Delete.
6997         (riscv_gdbarch_init): Don't register deleted functions with
6998         gdbarch.
6999
7000 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7001
7002         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7003         (csky_unwind_pc): Delete.
7004         (csky_unwind_sp): Delete.
7005         (csky_gdbarch_init): Don't register deleted functions with
7006         gdbarch.
7007
7008 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7009
7010         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7011         (cris_unwind_pc): Delete.
7012         (cris_unwind_sp): Delete.
7013         (cris_gdbarch_init): Don't register deleted functions with
7014         gdbarch.
7015
7016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7017
7018         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7019         (bfin_unwind_pc): Delete.
7020         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7021
7022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7023
7024         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7025         (arm_unwind_pc): Delete.
7026         (arm_unwind_sp): Delete.
7027         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7028
7029 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7030
7031         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7032         (arc_unwind_pc): Delete.
7033         (arc_unwind_sp): Delete.
7034         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7035
7036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7037
7038         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7039         (alpha_unwind_pc): Delete.
7040         (alpha_gdbarch_init): Don't register deleted functions with
7041         gdbarch.
7042
7043 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7044
7045         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7046         (aarch64_unwind_pc): Delete.
7047         (aarch64_unwind_sp): Delete.
7048         (aarch64_gdbarch_init): Don't register deleted functions with
7049         gdbarch.
7050
7051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7052
7053         * gdbtypes.c (type_align): Don't consider static members when
7054         computing structure alignment.
7055
7056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7057
7058         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7059         return 0 for other types.
7060         * arch-utils.c (default_type_align): Always return 0.
7061         * gdbarch.h: Regenerate.
7062         * gdbarch.sh (type_align): Extend comment.
7063         * gdbtypes.c (type_align): Add additional comments, always call
7064         gdbarch_type_align before applying the default rules.
7065         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7066         generic code will then apply a suitable default.
7067         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7068         types, return 0 for other types.
7069
7070 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7071
7072         * NEWS: Create a new section for the next release branch.
7073         Rename the section of the current branch, now that it has
7074         been cut.
7075
7076 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7077
7078         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7079         * version.in: Bump version to 8.3.50.DATE-git.
7080
7081 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7082
7083         * aix-thread.c (ptid_cmp): Remove unused variable.
7084         (get_signaled_thread): Likewise.
7085         (store_regs_user_thread): Likewise.
7086         (store_regs_kernel_thread): Likewise.
7087         (fetch_regs_kernel_thread): Remove shadowed variable.
7088
7089 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7090
7091         * features/riscv/32bit-cpu.xml: Add register numbers.
7092         * features/riscv/32bit-fpu.c: Regenerate.
7093         * features/riscv/32bit-fpu.xml: Add register numbers.
7094         * features/riscv/64bit-cpu.xml: Add register numbers.
7095         * features/riscv/64bit-fpu.c: Regenerate.
7096         * features/riscv/64bit-fpu.xml: Add register numbers.
7097
7098 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7099
7100         * NEWS: Mention two argument form of gdb.Value constructor.
7101         * python/py-value.c (convert_buffer_and_type_to_value): New
7102         function.
7103         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7104         Add support for handling an optional second argument.  Call
7105         convert_buffer_and_type_to_value as appropriate.
7106         * python/python-internal.h (Py_buffer_deleter): New struct.
7107         (Py_buffer_up): New typedef.
7108
7109 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7110
7111         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7112         instead of releasing ownership.
7113
7114 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7115
7116         * dwarf2read.c (open_and_init_dwp_file): Call
7117         elf_numsections instead of bfd_count_sections to initialize
7118         dwp_file->num_sections.
7119
7120 2019-02-25  Tom Tromey  <tromey@adacore.com>
7121
7122         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7123
7124 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7125
7126         * gcore.in: Add '--readnever' option when invoking GDB.
7127
7128 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7129
7130         * MAINTAINERS: Update my email address.
7131
7132 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7133
7134         * build-id.c (build_id_to_debug_bfd_1): New function.
7135         (build_id_to_debug_bfd): Look for separate debug file in
7136         sysroot.
7137
7138 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7139
7140         * gdbarch.sh: Update the copyright year range that is placed into
7141         generated files.
7142
7143 2019-02-22  Keith Seitz  <keiths@redhat.com>
7144
7145         PR symtab/23853
7146         * linespec.c (create_sals_line_offset): Search for the default
7147         symtab's filename instead of its fullname.
7148
7149 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7150
7151         * NEWS: Update style defaults.
7152
7153 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7154
7155         * main.c (captured_main_1): Disable styling in batch mode.
7156
7157 2019-02-20  Tom Tromey  <tom@tromey.com>
7158
7159         * symtab.c (symtab_symbol_info): Fix typos.
7160
7161 2019-02-20  Tom Tromey  <tromey@adacore.com>
7162
7163         * findcmd.c (_initialize_mem_search): Use upper case for
7164         metasyntactic variables.
7165
7166 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7167
7168         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7169         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7170
7171 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7172
7173         * top.h (source_file_name): Change to std::string.
7174         * top.c (source_file_name): Likewise.
7175         (command_line_input): Adjust.
7176         * cli/cli-script.c (script_from_file): Adjust.
7177
7178 2019-02-19  Tom Tromey  <tromey@adacore.com>
7179
7180         * ravenscar-thread.c
7181         (ravenscar_thread_target::update_thread_list): Don't call
7182         ada_build_task_list.
7183         * ada-lang.h (ada_build_task_list): Don't declare.
7184         * ada-tasks.c (struct ada_tasks_inferior_data)
7185         <task_list_valid_p>: Now bool.
7186         (read_known_tasks, ada_task_list_changed)
7187         (ada_tasks_invalidate_inferior_data): Update.
7188         (read_known_tasks_array): Return bool.
7189         (read_known_tasks_list): Likewise.
7190         (read_known_tasks): Return void.
7191         (ada_build_task_list): Now static.
7192
7193 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7194
7195         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7196         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7197
7198 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7199
7200         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7201         variant for ada_tasks_pspace_data_handle and
7202         ada_tasks_inferior_data_handle.
7203         (ada_tasks_pspace_data_cleanup): New function.
7204         (ada_tasks_inferior_data_cleanup): New function.
7205
7206 2019-02-17  Tom Tromey  <tom@tromey.com>
7207
7208         * macrotab.h (macro_source_fullname): Return a std::string.
7209         * macrotab.c (macro_include, check_for_redefinition)
7210         (macro_undef, macro_lookup_definition, foreach_macro)
7211         (foreach_macro_in_scope): Update.
7212         (macro_source_fullname): Return a std::string.
7213         * macrocmd.c (show_pp_source_pos): Update.
7214
7215 2019-02-17  Tom Tromey  <tom@tromey.com>
7216
7217         * macrocmd.c (show_pp_source_pos): Style the file names.
7218
7219 2019-02-17  Tom Tromey  <tom@tromey.com>
7220
7221         PR tui/24197:
7222         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7223
7224 2019-02-17  Tom Tromey  <tom@tromey.com>
7225
7226         * ada-lang.c (user_select_syms): Use filtered printing.
7227         * utils.c (wrap_style): New global.
7228         (desired_style): Remove.
7229         (emit_style_escape): Add stream parameter.
7230         (set_output_style, reset_terminal_style, prompt_for_continue):
7231         Update.
7232         (flush_wrap_buffer): Only flush gdb_stdout.
7233         (wrap_here): Set wrap_style.
7234         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7235         treat escape sequences as a character.  Change when wrap buffer is
7236         flushed.
7237         (fputs_styled): Do not set the output style when the default is
7238         requested.
7239         * ui-style.h (struct ui_file_style) <is_default>: New method.
7240         * source.c (print_source_lines_base): Emit escape sequences in one
7241         piece.
7242
7243 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7244
7245         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7246         integers and enumeration types.
7247
7248 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7249
7250         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7251         instead of lookup_symbol_in_language
7252         (do_exact_match): New function.
7253         (ada_get_symbol_name_matcher): Return do_exact_match when
7254         doing a verbatim match.
7255
7256 2019-02-15  Tom Tromey  <tromey@adacore.com>
7257
7258         * ravenscar-thread.c (ravenscar_thread_target::resume)
7259         (ravenscar_thread_target::wait): Special case wildcard requests.
7260
7261 2019-02-15  Tom Tromey  <tromey@adacore.com>
7262
7263         * ravenscar-thread.c (base_ptid): Remove.
7264         (struct ravenscar_thread_target) <close>: New method.
7265         <m_base_ptid>: New member.
7266         <update_inferior_ptid, active_task, task_is_currently_active,
7267         runtime_initialized>: Declare methods.
7268         <ravenscar_thread_target>: Add constructor.
7269         (ravenscar_thread_target::task_is_currently_active)
7270         (ravenscar_thread_target::update_inferior_ptid)
7271         (ravenscar_runtime_initialized): Rename.  Now methods.
7272         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7273         (ravenscar_thread_target::update_thread_list): Update.
7274         (ravenscar_thread_target::active_task): Now method.
7275         (ravenscar_thread_target::store_registers)
7276         (ravenscar_thread_target::prepare_to_store)
7277         (ravenscar_thread_target::prepare_to_store)
7278         (ravenscar_thread_target::mourn_inferior): Update.
7279         (ravenscar_inferior_created): Use "new" to create target.
7280         (ravenscar_thread_target::get_ada_task_ptid): Update.
7281         (_initialize_ravenscar): Don't initialize base_ptid.
7282         (ravenscar_ops): Remove global.
7283
7284 2019-02-15  Tom Tromey  <tromey@adacore.com>
7285
7286         * target.h (push_target): Declare new overload.
7287         * target.c (push_target): New overload, taking an rvalue reference.
7288         * remote.c (remote_target::open_1): Use push_target overload.
7289         * corelow.c (core_target_open): Use push_target overload.
7290
7291 2019-02-15  Tom Tromey  <tromey@adacore.com>
7292
7293         * ravenscar-thread.c (is_ravenscar_task)
7294         (ravenscar_task_is_currently_active): Return bool.
7295         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7296         (_initialize_ravenscar): Remove "(void)".
7297         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7298         Return bool.
7299
7300 2019-02-15  Tom Tromey  <tromey@adacore.com>
7301
7302         * ravenscar-thread.c (ravenscar_runtime_initializer)
7303         (has_ravenscar_runtime, get_running_thread_id)
7304         (ravenscar_thread_target::resume): Fix indentation.
7305
7306 2019-02-15  Tom Tromey  <tromey@adacore.com>
7307
7308         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7309         from ravenscar_arch_ops.
7310         (sparc_ravenscar_ops::fetch_registers)
7311         (sparc_ravenscar_ops::store_registers): Now methods.
7312         (sparc_ravenscar_prepare_to_store): Remove.
7313         (sparc_ravenscar_ops): Redefine.
7314         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7315         methods and destructor.  Remove members.
7316         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7317         (ravenscar_thread_target::store_registers)
7318         (ravenscar_thread_target::prepare_to_store): Update.
7319         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7320         Remove.
7321         (struct ppc_ravenscar_powerpc_ops): Derive from
7322         ravenscar_arch_ops.
7323         (ppc_ravenscar_powerpc_ops::fetch_registers)
7324         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7325         (ppc_ravenscar_powerpc_ops): Redefine.
7326         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7327         (ppc_ravenscar_e500_ops::fetch_registers)
7328         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7329         (ppc_ravenscar_e500_ops): Redefine.
7330         * aarch64-ravenscar-thread.c
7331         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7332         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7333         (aarch64_ravenscar_fetch_registers)
7334         (aarch64_ravenscar_store_registers): Now methods.
7335         (aarch64_ravenscar_ops): Redefine.
7336
7337 2019-02-15  Tom Tromey  <tromey@adacore.com>
7338
7339         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7340         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7341         (ravenscar_thread_target::stopped_by_watchpoint)
7342         (ravenscar_thread_target::stopped_data_address)
7343         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7344
7345 2019-02-15  Tom Tromey  <tromey@adacore.com>
7346
7347         * ravenscar-thread.c: Fix some typos.
7348
7349 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7350             Tom Tromey  <tromey@adacore.com>
7351
7352         * ada-lang.c (ada_exception_sal): Change addr_string to a
7353         std::string.
7354         (create_ada_exception_catchpoint): Update.
7355
7356 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7357             Tom Tromey  <tromey@adacore.com>
7358
7359         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7360         (bp_location_ops): Remove.
7361         (base_breakpoint_allocate_location): Update.
7362         (free_bp_location): Update.
7363         * ada-lang.c (class ada_catchpoint_location)
7364         <ada_catchpoint_location>: Remove ops parameter.
7365         (ada_catchpoint_location_dtor): Remove.
7366         (ada_catchpoint_location_ops): Remove.
7367         (allocate_location_exception): Update.
7368         * breakpoint.h (struct bp_location_ops): Remove.
7369         (class bp_location) <bp_location>: Remove bp_location_ops
7370         parameter.
7371         <~bp_location>: Add destructor.
7372         <ops>: Remove.
7373
7374 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7375             Pedro Alves  <palves@redhat.com>
7376
7377         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7378         'PATH_MAX'.
7379
7380 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7381             Samuel Thibault  <samuel.thibault@gnu.org>
7382             Thomas Schwinge  <thomas@codesourcery.com>
7383
7384         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7385         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7386
7387 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7388
7389         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7390         (check_empty): Use "const char *".
7391
7392         * gnu-nat.c (gnu_nat_target::detach): Instead of
7393         'detach_inferior (pid)' call
7394         'detach_inferior (find_inferior_pid (pid))'.
7395
7396         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7397         'nat/fork-inferior.o'.
7398         * gnu-nat.c: #include "nat/fork-inferior.h".
7399
7400         * gnu-nat.c (gnu_nat_target::detach): Instead of
7401         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7402         * gnu-nat.h: #include "inf-child.h".
7403         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7404         'i386_gnu_nat_target::fetch_registers'.
7405         (gnu_store_registers): Rename/move to
7406         'i386_gnu_nat_target::store_registers'.
7407
7408         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7409         * gnu-nat.h (mach_thread_info): New function.
7410         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7411
7412         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7413
7414 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7415
7416         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7417
7418 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7419
7420         * windows-nat.c (windows_add_thread): Add new parameter
7421         "main_thread_p" with default value set to false.  Update
7422         function documentation as well as all callers.
7423         (windows_delete_thread): Likewise.
7424         (fake_create_process): Update call to windows_add_thread.
7425         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7426         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7427         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7428         call to windows_delete_thread.
7429
7430 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7431
7432         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7433
7434 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7435
7436         * symfile.c (find_separate_debug_file): Use canonical path of
7437         sysroot with child_path instead of gdb_sysroot if it is valid.
7438
7439 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7440
7441         * symfile.c (find_separate_debug_file): Use child_path to
7442         determine if an object file is under a sysroot.
7443
7444 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7445
7446         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7447         unittests/child-path-selftests.c.
7448         * common/pathstuff.c (child_path): New function.
7449         * common/pathstuff.h (child_path): New prototype.
7450         * unittests/child-path-selftests.c: New file.
7451
7452 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7453
7454         * symfile.c (find_separate_debug_file): Look for separate debug
7455         files in debug directories under the sysroot.
7456
7457 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7458
7459         * symtab.h (struct minimal_symbol data_p): New const method.
7460         (struct minimal_symbol text_p): Likewise.
7461         * symtab.c (output_source_filename): Use file name style
7462         to print file name.
7463         (print_symbol_info): Likewise.
7464         (print_msymbol_info): Use address style to print addresses.
7465         Use function name style to print executable text symbols.
7466         (expand_symtab_containing_pc): Use data_p.
7467         (find_pc_sect_compunit_symtab): Likewise.
7468
7469 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7470
7471         * breakpoint.c (describe_other_breakpoints): Use address style
7472         to print addresses.
7473         (say_where): Likewise.
7474
7475 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7476
7477         * ada-typeprint.c (print_func_type): Print function name
7478         style to print function name.
7479         * c-typeprint.c (c_print_type_1): Likewise.
7480
7481 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7482
7483         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7484         for execve.
7485
7486 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7487
7488         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7489         type_stack.
7490
7491 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7492
7493         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7494         TYPE_CODE_REF types.
7495
7496 2019-02-08  Jim Wilson  <jimw@sifive.com>
7497
7498         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7499         (riscv_linux_fregset): New.
7500         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7501
7502 2019-02-07  Tom Tromey  <tom@tromey.com>
7503
7504         * thread.c (thread_cancel_execution_command): Update.
7505         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7506         methods.
7507         (struct thread_fsm_ops): Remove.
7508         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7509         (thread_fsm_should_stop, thread_fsm_return_value)
7510         (thread_fsm_set_finished, thread_fsm_finished_p)
7511         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7512         Don't declare.
7513         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7514         * infrun.c (clear_proceed_status_thread)
7515         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7516         (print_stop_event): Update.
7517         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7518         Add constructor.
7519         (step_command_fsm_ops): Remove.
7520         (new_step_command_fsm): Remove.
7521         (step_1): Update.
7522         (step_command_fsm::should_stop): Rename from
7523         step_command_fsm_should_stop.
7524         (step_command_fsm::clean_up): Rename from
7525         step_command_fsm_clean_up.
7526         (step_command_fsm::do_async_reply_reason): Rename from
7527         step_command_fsm_async_reply_reason.
7528         (struct until_next_fsm): Inherit from thread_fsm.  Add
7529         constructor.
7530         (until_next_fsm_ops): Remove.
7531         (new_until_next_fsm): Remove.
7532         (until_next_fsm::should_stop): Rename from
7533         until_next_fsm_should_stop.
7534         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7535         (until_next_fsm::do_async_reply_reason): Rename from
7536         until_next_fsm_async_reply_reason.
7537         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7538         constructor.  Change type of breakpoint.
7539         (finish_command_fsm_ops): Remove.
7540         (new_finish_command_fsm): Remove.
7541         (finish_command_fsm::should_stop): Rename from
7542         finish_command_fsm_should_stop.
7543         (finish_command_fsm::clean_up): Rename from
7544         finish_command_fsm_clean_up.
7545         (finish_command_fsm::return_value): Rename from
7546         finish_command_fsm_return_value.
7547         (finish_command_fsm::do_async_reply_reason): Rename from
7548         finish_command_fsm_async_reply_reason.
7549         (finish_command): Update.
7550         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7551         Add constructor.
7552         (call_thread_fsm_ops): Remove.
7553         (call_thread_fsm::call_thread_fsm): Rename from
7554         new_call_thread_fsm.
7555         (call_thread_fsm::should_stop): Rename from
7556         call_thread_fsm_should_stop.
7557         (call_thread_fsm::should_notify_stop): Rename from
7558         call_thread_fsm_should_notify_stop.
7559         (run_inferior_call, call_function_by_hand_dummy): Update.
7560         * cli/cli-interp.c (should_print_stop_to_console): Update.
7561         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7562         Add constructor.  Change type of location_breakpoint,
7563         caller_breakpoint.
7564         (until_break_fsm_ops): Remove.
7565         (new_until_break_fsm): Remove.
7566         (until_break_fsm::should_stop): Rename from
7567         until_break_fsm_should_stop.
7568         (until_break_fsm::clean_up): Rename from
7569         until_break_fsm_clean_up.
7570         (until_break_fsm::do_async_reply_reason): Rename from
7571         until_break_fsm_async_reply_reason.
7572         (until_break_command): Update.
7573         * thread-fsm.c: Remove.
7574         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7575
7576 2019-02-07  Tom Tromey  <tom@tromey.com>
7577
7578         * yy-remap.h: Add include guard.
7579         * xtensa-tdep.h: Add include guard.
7580         * xcoffread.h: Rename include guard.
7581         * varobj-iter.h: Add include guard.
7582         * tui/tui.h: Rename include guard.
7583         * tui/tui-winsource.h: Rename include guard.
7584         * tui/tui-wingeneral.h: Rename include guard.
7585         * tui/tui-windata.h: Rename include guard.
7586         * tui/tui-win.h: Rename include guard.
7587         * tui/tui-stack.h: Rename include guard.
7588         * tui/tui-source.h: Rename include guard.
7589         * tui/tui-regs.h: Rename include guard.
7590         * tui/tui-out.h: Rename include guard.
7591         * tui/tui-layout.h: Rename include guard.
7592         * tui/tui-io.h: Rename include guard.
7593         * tui/tui-hooks.h: Rename include guard.
7594         * tui/tui-file.h: Rename include guard.
7595         * tui/tui-disasm.h: Rename include guard.
7596         * tui/tui-data.h: Rename include guard.
7597         * tui/tui-command.h: Rename include guard.
7598         * tic6x-tdep.h: Add include guard.
7599         * target/waitstatus.h: Rename include guard.
7600         * target/wait.h: Rename include guard.
7601         * target/target.h: Rename include guard.
7602         * target/resume.h: Rename include guard.
7603         * target-float.h: Rename include guard.
7604         * stabsread.h: Add include guard.
7605         * rs6000-tdep.h: Add include guard.
7606         * riscv-fbsd-tdep.h: Add include guard.
7607         * regformats/regdef.h: Rename include guard.
7608         * record.h: Rename include guard.
7609         * python/python.h: Rename include guard.
7610         * python/python-internal.h: Rename include guard.
7611         * python/py-stopevent.h: Rename include guard.
7612         * python/py-ref.h: Rename include guard.
7613         * python/py-record.h: Rename include guard.
7614         * python/py-record-full.h: Rename include guard.
7615         * python/py-record-btrace.h: Rename include guard.
7616         * python/py-instruction.h: Rename include guard.
7617         * python/py-events.h: Rename include guard.
7618         * python/py-event.h: Rename include guard.
7619         * procfs.h: Add include guard.
7620         * proc-utils.h: Add include guard.
7621         * p-lang.h: Add include guard.
7622         * or1k-tdep.h: Rename include guard.
7623         * observable.h: Rename include guard.
7624         * nto-tdep.h: Rename include guard.
7625         * nat/x86-linux.h: Rename include guard.
7626         * nat/x86-linux-dregs.h: Rename include guard.
7627         * nat/x86-gcc-cpuid.h: Add include guard.
7628         * nat/x86-dregs.h: Rename include guard.
7629         * nat/x86-cpuid.h: Rename include guard.
7630         * nat/ppc-linux.h: Rename include guard.
7631         * nat/mips-linux-watch.h: Rename include guard.
7632         * nat/linux-waitpid.h: Rename include guard.
7633         * nat/linux-ptrace.h: Rename include guard.
7634         * nat/linux-procfs.h: Rename include guard.
7635         * nat/linux-osdata.h: Rename include guard.
7636         * nat/linux-nat.h: Rename include guard.
7637         * nat/linux-namespaces.h: Rename include guard.
7638         * nat/linux-btrace.h: Rename include guard.
7639         * nat/glibc_thread_db.h: Rename include guard.
7640         * nat/gdb_thread_db.h: Rename include guard.
7641         * nat/gdb_ptrace.h: Rename include guard.
7642         * nat/fork-inferior.h: Rename include guard.
7643         * nat/amd64-linux-siginfo.h: Rename include guard.
7644         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7645         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7646         * nat/aarch64-linux.h: Rename include guard.
7647         * nat/aarch64-linux-hw-point.h: Rename include guard.
7648         * mn10300-tdep.h: Add include guard.
7649         * mips-linux-tdep.h: Add include guard.
7650         * mi/mi-parse.h: Rename include guard.
7651         * mi/mi-out.h: Rename include guard.
7652         * mi/mi-main.h: Rename include guard.
7653         * mi/mi-interp.h: Rename include guard.
7654         * mi/mi-getopt.h: Rename include guard.
7655         * mi/mi-console.h: Rename include guard.
7656         * mi/mi-common.h: Rename include guard.
7657         * mi/mi-cmds.h: Rename include guard.
7658         * mi/mi-cmd-break.h: Rename include guard.
7659         * m2-lang.h: Add include guard.
7660         * location.h: Rename include guard.
7661         * linux-record.h: Rename include guard.
7662         * linux-nat.h: Add include guard.
7663         * linux-fork.h: Add include guard.
7664         * i386-darwin-tdep.h: Rename include guard.
7665         * hppa-linux-offsets.h: Add include guard.
7666         * guile/guile.h: Rename include guard.
7667         * guile/guile-internal.h: Rename include guard.
7668         * gnu-nat.h: Rename include guard.
7669         * gdb-stabs.h: Rename include guard.
7670         * frv-tdep.h: Add include guard.
7671         * f-lang.h: Add include guard.
7672         * event-loop.h: Add include guard.
7673         * darwin-nat.h: Rename include guard.
7674         * cp-abi.h: Rename include guard.
7675         * config/sparc/nm-sol2.h: Rename include guard.
7676         * config/nm-nto.h: Rename include guard.
7677         * config/nm-linux.h: Add include guard.
7678         * config/i386/nm-i386gnu.h: Rename include guard.
7679         * config/djgpp/nl_types.h: Rename include guard.
7680         * config/djgpp/langinfo.h: Rename include guard.
7681         * compile/gcc-cp-plugin.h: Add include guard.
7682         * compile/gcc-c-plugin.h: Add include guard.
7683         * compile/compile.h: Rename include guard.
7684         * compile/compile-object-run.h: Rename include guard.
7685         * compile/compile-object-load.h: Rename include guard.
7686         * compile/compile-internal.h: Rename include guard.
7687         * compile/compile-cplus.h: Rename include guard.
7688         * compile/compile-c.h: Rename include guard.
7689         * common/xml-utils.h: Rename include guard.
7690         * common/x86-xstate.h: Rename include guard.
7691         * common/version.h: Rename include guard.
7692         * common/vec.h: Rename include guard.
7693         * common/tdesc.h: Rename include guard.
7694         * common/selftest.h: Rename include guard.
7695         * common/scoped_restore.h: Rename include guard.
7696         * common/scoped_mmap.h: Rename include guard.
7697         * common/scoped_fd.h: Rename include guard.
7698         * common/safe-iterator.h: Rename include guard.
7699         * common/run-time-clock.h: Rename include guard.
7700         * common/refcounted-object.h: Rename include guard.
7701         * common/queue.h: Rename include guard.
7702         * common/ptid.h: Rename include guard.
7703         * common/print-utils.h: Rename include guard.
7704         * common/preprocessor.h: Rename include guard.
7705         * common/pathstuff.h: Rename include guard.
7706         * common/observable.h: Rename include guard.
7707         * common/netstuff.h: Rename include guard.
7708         * common/job-control.h: Rename include guard.
7709         * common/host-defs.h: Rename include guard.
7710         * common/gdb_wait.h: Rename include guard.
7711         * common/gdb_vecs.h: Rename include guard.
7712         * common/gdb_unlinker.h: Rename include guard.
7713         * common/gdb_unique_ptr.h: Rename include guard.
7714         * common/gdb_tilde_expand.h: Rename include guard.
7715         * common/gdb_sys_time.h: Rename include guard.
7716         * common/gdb_string_view.h: Rename include guard.
7717         * common/gdb_splay_tree.h: Rename include guard.
7718         * common/gdb_setjmp.h: Rename include guard.
7719         * common/gdb_ref_ptr.h: Rename include guard.
7720         * common/gdb_optional.h: Rename include guard.
7721         * common/gdb_locale.h: Rename include guard.
7722         * common/gdb_assert.h: Rename include guard.
7723         * common/filtered-iterator.h: Rename include guard.
7724         * common/filestuff.h: Rename include guard.
7725         * common/fileio.h: Rename include guard.
7726         * common/environ.h: Rename include guard.
7727         * common/common-utils.h: Rename include guard.
7728         * common/common-types.h: Rename include guard.
7729         * common/common-regcache.h: Rename include guard.
7730         * common/common-inferior.h: Rename include guard.
7731         * common/common-gdbthread.h: Rename include guard.
7732         * common/common-exceptions.h: Rename include guard.
7733         * common/common-defs.h: Rename include guard.
7734         * common/common-debug.h: Rename include guard.
7735         * common/cleanups.h: Rename include guard.
7736         * common/buffer.h: Rename include guard.
7737         * common/btrace-common.h: Rename include guard.
7738         * common/break-common.h: Rename include guard.
7739         * cli/cli-utils.h: Rename include guard.
7740         * cli/cli-style.h: Rename include guard.
7741         * cli/cli-setshow.h: Rename include guard.
7742         * cli/cli-script.h: Rename include guard.
7743         * cli/cli-interp.h: Rename include guard.
7744         * cli/cli-decode.h: Rename include guard.
7745         * cli/cli-cmds.h: Rename include guard.
7746         * charset-list.h: Add include guard.
7747         * buildsym-legacy.h: Rename include guard.
7748         * bfin-tdep.h: Add include guard.
7749         * ax.h: Rename include guard.
7750         * arm-linux-tdep.h: Add include guard.
7751         * arm-fbsd-tdep.h: Add include guard.
7752         * arch/xtensa.h: Rename include guard.
7753         * arch/tic6x.h: Add include guard.
7754         * arch/i386.h: Add include guard.
7755         * arch/arm.h: Rename include guard.
7756         * arch/arm-linux.h: Rename include guard.
7757         * arch/arm-get-next-pcs.h: Rename include guard.
7758         * arch/amd64.h: Add include guard.
7759         * arch/aarch64-insn.h: Rename include guard.
7760         * arch-utils.h: Rename include guard.
7761         * annotate.h: Add include guard.
7762         * amd64-darwin-tdep.h: Rename include guard.
7763         * aarch64-linux-tdep.h: Add include guard.
7764         * aarch64-fbsd-tdep.h: Add include guard.
7765         * aarch32-linux-nat.h: Add include guard.
7766
7767 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7768
7769         * macrotab.c (macro_define_internal): New function that
7770         factorizes macro_define_object_internal and macro_define_function
7771         code.
7772         (macro_define_object_internal): Use macro_define_internal.
7773         (macro_define_function): Likewise.
7774
7775 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7776
7777         * macrocmd.c (extract_identifier): Return
7778         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7779         callers.
7780
7781 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7782
7783         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7784
7785 2019-02-05  Tom Tromey  <tom@tromey.com>
7786
7787         * target.c (target_stack::unpush): Move assertion earlier.
7788
7789 2019-01-30  Tom Tromey  <tom@tromey.com>
7790
7791         PR python/23615:
7792         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7793         (gdbpy_parse_and_eval): Likewise.
7794         * python/python-internal.h (gdbpy_allow_threads): New class.
7795
7796 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7797
7798         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7799         (aarch64_fbsd_fpregmap): Move earlier.
7800         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7801         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7802         instead of individual calls to trad_frame_set_reg_addr.
7803         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7804         earlier.
7805         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7806         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7807         instead of individual calls to trad_frame_set_reg_addr.
7808
7809 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7810
7811         * CONTRIBUTE: Replace contribution list with wiki link.
7812
7813 2019-01-25  Tom Tromey  <tom@tromey.com>
7814
7815         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7816
7817 2019-01-25  Tom Tromey  <tom@tromey.com>
7818
7819         * xtensa-linux-nat.c: Fix common/ includes.
7820         * xml-support.h: Fix common/ includes.
7821         * xml-support.c: Fix common/ includes.
7822         * x86-linux-nat.c: Fix common/ includes.
7823         * windows-nat.c: Fix common/ includes.
7824         * varobj.h: Fix common/ includes.
7825         * varobj.c: Fix common/ includes.
7826         * value.c: Fix common/ includes.
7827         * valops.c: Fix common/ includes.
7828         * utils.c: Fix common/ includes.
7829         * unittests/xml-utils-selftests.c: Fix common/ includes.
7830         * unittests/utils-selftests.c: Fix common/ includes.
7831         * unittests/unpack-selftests.c: Fix common/ includes.
7832         * unittests/tracepoint-selftests.c: Fix common/ includes.
7833         * unittests/style-selftests.c: Fix common/ includes.
7834         * unittests/string_view-selftests.c: Fix common/ includes.
7835         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7836         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7837         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7838         * unittests/rsp-low-selftests.c: Fix common/ includes.
7839         * unittests/parse-connection-spec-selftests.c: Fix common/
7840         includes.
7841         * unittests/optional-selftests.c: Fix common/ includes.
7842         * unittests/offset-type-selftests.c: Fix common/ includes.
7843         * unittests/observable-selftests.c: Fix common/ includes.
7844         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7845         * unittests/memrange-selftests.c: Fix common/ includes.
7846         * unittests/memory-map-selftests.c: Fix common/ includes.
7847         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7848         * unittests/function-view-selftests.c: Fix common/ includes.
7849         * unittests/environ-selftests.c: Fix common/ includes.
7850         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7851         * unittests/common-utils-selftests.c: Fix common/ includes.
7852         * unittests/cli-utils-selftests.c: Fix common/ includes.
7853         * unittests/array-view-selftests.c: Fix common/ includes.
7854         * ui-file.c: Fix common/ includes.
7855         * tui/tui-io.c: Fix common/ includes.
7856         * tracepoint.h: Fix common/ includes.
7857         * tracepoint.c: Fix common/ includes.
7858         * tracefile-tfile.c: Fix common/ includes.
7859         * top.h: Fix common/ includes.
7860         * top.c: Fix common/ includes.
7861         * thread.c: Fix common/ includes.
7862         * target/waitstatus.h: Fix common/ includes.
7863         * target/waitstatus.c: Fix common/ includes.
7864         * target.h: Fix common/ includes.
7865         * target.c: Fix common/ includes.
7866         * target-memory.c: Fix common/ includes.
7867         * target-descriptions.c: Fix common/ includes.
7868         * symtab.h: Fix common/ includes.
7869         * symfile.c: Fix common/ includes.
7870         * stap-probe.c: Fix common/ includes.
7871         * spu-linux-nat.c: Fix common/ includes.
7872         * sparc-nat.c: Fix common/ includes.
7873         * source.c: Fix common/ includes.
7874         * solib.c: Fix common/ includes.
7875         * solib-target.c: Fix common/ includes.
7876         * ser-unix.c: Fix common/ includes.
7877         * ser-tcp.c: Fix common/ includes.
7878         * ser-pipe.c: Fix common/ includes.
7879         * ser-base.c: Fix common/ includes.
7880         * selftest-arch.c: Fix common/ includes.
7881         * s12z-tdep.c: Fix common/ includes.
7882         * rust-exp.y: Fix common/ includes.
7883         * rs6000-aix-tdep.c: Fix common/ includes.
7884         * riscv-tdep.c: Fix common/ includes.
7885         * remote.c: Fix common/ includes.
7886         * remote-notif.h: Fix common/ includes.
7887         * remote-fileio.h: Fix common/ includes.
7888         * remote-fileio.c: Fix common/ includes.
7889         * regcache.h: Fix common/ includes.
7890         * regcache.c: Fix common/ includes.
7891         * record-btrace.c: Fix common/ includes.
7892         * python/python.c: Fix common/ includes.
7893         * python/py-type.c: Fix common/ includes.
7894         * python/py-inferior.c: Fix common/ includes.
7895         * progspace.h: Fix common/ includes.
7896         * producer.c: Fix common/ includes.
7897         * procfs.c: Fix common/ includes.
7898         * proc-api.c: Fix common/ includes.
7899         * printcmd.c: Fix common/ includes.
7900         * ppc-linux-nat.c: Fix common/ includes.
7901         * parser-defs.h: Fix common/ includes.
7902         * osdata.c: Fix common/ includes.
7903         * obsd-nat.c: Fix common/ includes.
7904         * nat/x86-linux.c: Fix common/ includes.
7905         * nat/x86-linux-dregs.c: Fix common/ includes.
7906         * nat/x86-dregs.h: Fix common/ includes.
7907         * nat/x86-dregs.c: Fix common/ includes.
7908         * nat/ppc-linux.c: Fix common/ includes.
7909         * nat/mips-linux-watch.h: Fix common/ includes.
7910         * nat/mips-linux-watch.c: Fix common/ includes.
7911         * nat/linux-waitpid.c: Fix common/ includes.
7912         * nat/linux-ptrace.h: Fix common/ includes.
7913         * nat/linux-ptrace.c: Fix common/ includes.
7914         * nat/linux-procfs.c: Fix common/ includes.
7915         * nat/linux-personality.c: Fix common/ includes.
7916         * nat/linux-osdata.c: Fix common/ includes.
7917         * nat/linux-namespaces.c: Fix common/ includes.
7918         * nat/linux-btrace.h: Fix common/ includes.
7919         * nat/linux-btrace.c: Fix common/ includes.
7920         * nat/fork-inferior.c: Fix common/ includes.
7921         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7922         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7923         * nat/aarch64-linux.c: Fix common/ includes.
7924         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7925         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7926         * namespace.h: Fix common/ includes.
7927         * mips-linux-tdep.c: Fix common/ includes.
7928         * minsyms.c: Fix common/ includes.
7929         * mi/mi-parse.h: Fix common/ includes.
7930         * mi/mi-main.c: Fix common/ includes.
7931         * mi/mi-cmd-env.c: Fix common/ includes.
7932         * memrange.h: Fix common/ includes.
7933         * memattr.c: Fix common/ includes.
7934         * maint.h: Fix common/ includes.
7935         * maint.c: Fix common/ includes.
7936         * main.c: Fix common/ includes.
7937         * machoread.c: Fix common/ includes.
7938         * location.c: Fix common/ includes.
7939         * linux-thread-db.c: Fix common/ includes.
7940         * linux-nat.c: Fix common/ includes.
7941         * linux-fork.c: Fix common/ includes.
7942         * inline-frame.c: Fix common/ includes.
7943         * infrun.c: Fix common/ includes.
7944         * inflow.c: Fix common/ includes.
7945         * inferior.h: Fix common/ includes.
7946         * inferior.c: Fix common/ includes.
7947         * infcmd.c: Fix common/ includes.
7948         * inf-ptrace.c: Fix common/ includes.
7949         * inf-child.c: Fix common/ includes.
7950         * ia64-linux-nat.c: Fix common/ includes.
7951         * i387-tdep.c: Fix common/ includes.
7952         * i386-tdep.c: Fix common/ includes.
7953         * i386-linux-tdep.c: Fix common/ includes.
7954         * i386-linux-nat.c: Fix common/ includes.
7955         * i386-go32-tdep.c: Fix common/ includes.
7956         * i386-fbsd-tdep.c: Fix common/ includes.
7957         * i386-fbsd-nat.c: Fix common/ includes.
7958         * guile/scm-type.c: Fix common/ includes.
7959         * guile/guile.c: Fix common/ includes.
7960         * go32-nat.c: Fix common/ includes.
7961         * gnu-nat.c: Fix common/ includes.
7962         * gdbthread.h: Fix common/ includes.
7963         * gdbarch-selftests.c: Fix common/ includes.
7964         * gdb_usleep.c: Fix common/ includes.
7965         * gdb_select.h: Fix common/ includes.
7966         * gdb_bfd.c: Fix common/ includes.
7967         * gcore.c: Fix common/ includes.
7968         * fork-child.c: Fix common/ includes.
7969         * findvar.c: Fix common/ includes.
7970         * fbsd-nat.c: Fix common/ includes.
7971         * event-top.c: Fix common/ includes.
7972         * event-loop.c: Fix common/ includes.
7973         * dwarf2read.c: Fix common/ includes.
7974         * dwarf2loc.c: Fix common/ includes.
7975         * dwarf2-frame.c: Fix common/ includes.
7976         * dwarf-index-cache.c: Fix common/ includes.
7977         * dtrace-probe.c: Fix common/ includes.
7978         * disasm-selftests.c: Fix common/ includes.
7979         * defs.h: Fix common/ includes.
7980         * csky-tdep.c: Fix common/ includes.
7981         * cp-valprint.c: Fix common/ includes.
7982         * cp-support.h: Fix common/ includes.
7983         * cp-support.c: Fix common/ includes.
7984         * corelow.c: Fix common/ includes.
7985         * completer.h: Fix common/ includes.
7986         * completer.c: Fix common/ includes.
7987         * compile/compile.c: Fix common/ includes.
7988         * compile/compile-loc2c.c: Fix common/ includes.
7989         * compile/compile-cplus-types.c: Fix common/ includes.
7990         * compile/compile-cplus-symbols.c: Fix common/ includes.
7991         * command.h: Fix common/ includes.
7992         * cli/cli-dump.c: Fix common/ includes.
7993         * cli/cli-cmds.c: Fix common/ includes.
7994         * charset.c: Fix common/ includes.
7995         * build-id.c: Fix common/ includes.
7996         * btrace.h: Fix common/ includes.
7997         * btrace.c: Fix common/ includes.
7998         * breakpoint.h: Fix common/ includes.
7999         * breakpoint.c: Fix common/ includes.
8000         * ax.h:
8001         (enum agent_op): Fix common/ includes.
8002         * ax-general.c (struct aop_map): Fix common/ includes.
8003         * ax-gdb.c: Fix common/ includes.
8004         * auxv.c: Fix common/ includes.
8005         * auto-load.c: Fix common/ includes.
8006         * arm-tdep.c: Fix common/ includes.
8007         * arch/riscv.c: Fix common/ includes.
8008         * arch/ppc-linux-common.c: Fix common/ includes.
8009         * arch/i386.c: Fix common/ includes.
8010         * arch/arm.c: Fix common/ includes.
8011         * arch/arm-linux.c: Fix common/ includes.
8012         * arch/arm-get-next-pcs.c: Fix common/ includes.
8013         * arch/amd64.c: Fix common/ includes.
8014         * arch/aarch64.c: Fix common/ includes.
8015         * arch/aarch64-insn.c: Fix common/ includes.
8016         * arch-utils.c: Fix common/ includes.
8017         * amd64-windows-tdep.c: Fix common/ includes.
8018         * amd64-tdep.c: Fix common/ includes.
8019         * amd64-sol2-tdep.c: Fix common/ includes.
8020         * amd64-obsd-tdep.c: Fix common/ includes.
8021         * amd64-nbsd-tdep.c: Fix common/ includes.
8022         * amd64-linux-tdep.c: Fix common/ includes.
8023         * amd64-linux-nat.c: Fix common/ includes.
8024         * amd64-fbsd-tdep.c: Fix common/ includes.
8025         * amd64-fbsd-nat.c: Fix common/ includes.
8026         * amd64-dicos-tdep.c: Fix common/ includes.
8027         * amd64-darwin-tdep.c: Fix common/ includes.
8028         * agent.c: Fix common/ includes.
8029         * ada-lang.h: Fix common/ includes.
8030         * ada-lang.c: Fix common/ includes.
8031         * aarch64-tdep.c: Fix common/ includes.
8032
8033 2019-01-25  Tom Tromey  <tom@tromey.com>
8034
8035         * common/create-version.sh: Use common/version.h.
8036
8037 2019-01-24  Pedro Alves  <palves@redhat.com>
8038
8039         * infrun.c (signal_stop, signal_print, signal_program)
8040         (signal_catch, signal_pass): Now arrays instead of pointers.
8041         (update_signals_program_target, do_target_resume)
8042         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8043         * linux-nat.c (linux_nat_target::pass_signals)
8044         (linux_nat_target::create_inferior, linux_nat_target::attach):
8045         Adjust.
8046         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8047         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8048         * procfs.c (procfs_target::pass_signals): Adjust.
8049         * record-full.c (record_full_target::resume): Adjust.
8050         * remote.c (remote_target::pass_signals)
8051         (remote_target::program_signals): Adjust.
8052         * target-debug.h (target_debug_print_signals): Now takes a
8053         gdb::array_view as parameter.  Adjust.
8054         * target.h (target_ops) <pass_signals, program_signals>: Replace
8055         pointer and length parameters with gdb::array_view.
8056         (target_pass_signals, target_program_signals): Likewise.
8057         * target-delegates.c: Regenerate.
8058
8059 2019-01-24  Pedro Alves  <palves@redhat.com>
8060
8061         * common/forward-scope-exit.h
8062         (forward_scope_exit::forward_scope_exit): Pass arguments to
8063         m_bind_function directly, instead of creating a std::bind and
8064         copying that.
8065
8066 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8067
8068         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8069         for static members.
8070         (pass_in_v_vfp_candidate): Likewise.
8071
8072 2019-01-23  Tom Tromey  <tom@tromey.com>
8073             Pedro Alves  <palves@redhat.com>
8074
8075         * regcache.c (class regcache_invalidator): Remove.
8076         (regcache::raw_write): Use make_scope_exit.
8077
8078 2019-01-23  Tom Tromey  <tom@tromey.com>
8079
8080         * ui-out.h (class ui_out_emit_type): Update comment.
8081
8082 2019-01-23  Tom Tromey  <tom@tromey.com>
8083
8084         * infrun.c (fetch_inferior_event): Update comment.
8085
8086 2019-01-23  Tom Tromey  <tom@tromey.com>
8087             Pedro Alves  <palves@redhat.com>
8088
8089         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8090         parameter.
8091         (fetch_inferior_event): Use SCOPE_EXIT.
8092
8093
8094 2019-01-23  Tom Tromey  <tom@tromey.com>
8095             Pedro Alves  <palves@redhat.com>
8096
8097         * infrun.c (disable_thread_events): Delete.
8098         (stop_all_threads): Use SCOPE_EXIT.
8099
8100 2019-01-23  Tom Tromey  <tom@tromey.com>
8101             Pedro Alves  <palves@redhat.com>
8102
8103         * symfile.c: Include forward-scope-exit.h.
8104         (clear_symtab_users_cleanup): Replace forward declaration with
8105         a FORWARD_SCOPE_EXIT.
8106         (syms_from_objfile_1): Use the forward_scope_exit and
8107         gdb::optional instead of cleanup_function.
8108         (reread_symbols): Use the forward_scope_exit instead of
8109         cleanup_function.
8110         (clear_symtab_users_cleanup): Remove function.
8111
8112 2019-01-23  Tom Tromey  <tom@tromey.com>
8113             Pedro Alves  <palves@redhat.com>
8114
8115         * linux-nat.c: Include scope-exit.h.
8116         (cleanup_target_stop): Remove.
8117         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8118         SCOPE_EXIT.
8119
8120 2019-01-23  Tom Tromey  <tom@tromey.com>
8121             Pedro Alves  <palves@redhat.com>
8122
8123         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8124         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8125
8126 2019-01-23  Tom Tromey  <tom@tromey.com>
8127             Andrew Burgess  <andrew.burgess@embecosm.com>
8128             Pedro Alves  <palves@redhat.com>
8129
8130         * infrun.c (fetch_inferior_event): Use scope_exit.
8131         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8132         * top.c (execute_command): Use scope_exit.
8133         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8134         * utils.c (do_bpstat_clear_actions_cleanup)
8135         (make_bpstat_clear_actions_cleanup): Remove.
8136
8137 2019-01-23  Tom Tromey  <tom@tromey.com>
8138             Pedro Alves  <palves@redhat.com>
8139
8140         * infrun.c: Include "common/scope-exit.h"
8141         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8142         (wait_for_inferior): Use SCOPE_EXIT.
8143         (fetch_inferior_event): Use scope_exit.
8144
8145 2019-01-23  Tom Tromey  <tom@tromey.com>
8146             Pedro Alves  <palves@redhat.com>
8147
8148         * breakpoint.c (create_breakpoint): Remove cleanup.
8149
8150 2019-01-23  Tom Tromey  <tom@tromey.com>
8151             Andrew Burgess  <andrew.burgess@embecosm.com>
8152             Pedro Alves  <palves@redhat.com>
8153
8154 2019-01-23  Pedro Alves  <palves@redhat.com>
8155
8156         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8157
8158 2019-01-23  Pedro Alves  <palves@redhat.com>
8159             Andrew Burgess  <andrew.burgess@embecosm.com>
8160
8161         * gdbthread.h: Include "common/forward-scope-exit.h".
8162         (scoped_finish_thread_state): Redefine custom class in terms of
8163         forward_scope_exit.
8164
8165 2019-01-23  Pedro Alves  <palves@redhat.com>
8166             Andrew Burgess  <andrew.burgess@embecosm.com>
8167
8168         * common/forward-scope-exit.h: New file.
8169
8170 2019-01-23  Pedro Alves  <palves@redhat.com>
8171             Andrew Burgess  <andrew.burgess@embecosm.com>
8172             Tom Tromey  <tom@tromey.com>
8173
8174         * common/scope-exit.h: New file.
8175
8176 2019-01-23  Pedro Alves  <palves@redhat.com>
8177
8178         * common/preprocessor.h (ESC): Rename to ...
8179         (ESC_PARENS): ... this.
8180         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8181         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8182
8183 2019-01-23  Tom Tromey  <tom@tromey.com>
8184
8185         * language.h (class scoped_switch_to_sym_language_if_auto):
8186         Initialize m_lang in both cases.
8187
8188 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8189
8190         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8191         with XCNEW.
8192
8193 2019-01-22  Tom Tromey  <tom@tromey.com>
8194
8195         * corelow.c: Do not include sys/file.h.
8196
8197 2019-01-22  Tom Tromey  <tom@tromey.com>
8198
8199         * tui/tui-wingeneral.h: Include gdb_curses.h.
8200
8201 2019-01-22  Tom Tromey  <tom@tromey.com>
8202
8203         * source-cache.h (class source_cache) <get_source_lines,
8204         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8205
8206 2019-01-22  Tom Tromey  <tom@tromey.com>
8207
8208         * remote-fileio.h (struct remote_target): Declare.
8209
8210 2019-01-22  Tom Tromey  <tom@tromey.com>
8211
8212         * python/py-arch.c: Do not include py-ref.h.
8213         * python/py-bpevent.c: Do not include py-ref.h.
8214         * python/py-cmd.c: Do not include py-ref.h.
8215         * python/py-continueevent.c: Do not include py-ref.h.
8216         * python/py-event.h: Do not include py-ref.h.
8217         * python/py-evtregistry.c: Do not include py-ref.h.
8218         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8219         * python/py-frame.c: Do not include py-ref.h.
8220         * python/py-framefilter.c: Do not include py-ref.h.
8221         * python/py-function.c: Do not include py-ref.h.
8222         * python/py-infevents.c: Do not include py-ref.h.
8223         * python/py-linetable.c: Do not include py-ref.h.
8224         * python/py-objfile.c: Do not include py-ref.h.
8225         * python/py-param.c: Do not include py-ref.h.
8226         * python/py-prettyprint.c: Do not include py-ref.h.
8227         * python/py-progspace.c: Do not include py-ref.h.
8228         * python/py-symbol.c: Do not include py-ref.h.
8229         * python/py-symtab.c: Do not include py-ref.h.
8230         * python/py-type.c: Do not include py-ref.h.
8231         * python/py-unwind.c: Do not include py-ref.h.
8232         * python/py-utils.c: Do not include py-ref.h.
8233         * python/py-value.c: Do not include py-ref.h.
8234         * python/py-varobj.c: Do not include py-ref.h.
8235         * python/py-xmethods.c: Do not include py-ref.h.
8236         * python/python.c: Do not include py-ref.h.
8237         * varobj.c: Do not include py-ref.h.
8238
8239 2019-01-22  Tom Tromey  <tom@tromey.com>
8240
8241         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8242         keyword for bcache.
8243
8244 2019-01-22  Tom Tromey  <tom@tromey.com>
8245
8246         * compile/compile-cplus-types.c: Remove a comment by #include.
8247
8248 2019-01-22  Tom Tromey  <tom@tromey.com>
8249
8250         * compile/gcc-c-plugin.h: Include compile-internal.h.
8251
8252 2019-01-22  Tom Tromey  <tom@tromey.com>
8253
8254         * stabsread.c (EXTERN): Do not define.
8255         (symnum, next_symbol_text_func, processing_gcc_compilation)
8256         (within_function, global_sym_chain, global_stabs)
8257         (previous_stab_code, this_object_header_files)
8258         (n_this_object_header_files)
8259         (n_allocated_this_object_header_files): Define.
8260         * stabsread.h (EXTERN): Never define.  Use "extern".
8261
8262 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8263
8264         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8265         history_value.
8266
8267 2019-01-21  Tom Tromey  <tom@tromey.com>
8268
8269         * ui-out.c: Fix includes.
8270         * tui/tui-source.c: Fix includes.
8271         * target.c: Fix includes.
8272         * remote.c: Fix includes.
8273         * regcache.c: Fix includes.
8274         * python/py-block.c: Fix includes.
8275         * printcmd.c: Fix includes.
8276         * or1k-tdep.c: Fix includes.
8277         * mi/mi-main.c: Fix includes.
8278         * m32r-tdep.c: Fix includes.
8279         * csky-tdep.c: Fix includes.
8280         * compile/compile-cplus-types.c: Fix includes.
8281         * cli/cli-interp.c: Fix includes.
8282
8283 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8284
8285         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8286         for padding.
8287
8288 2019-01-16  Tom Tromey  <tom@tromey.com>
8289
8290         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8291         earlier.
8292         (struct objfile) <msymbols_range>: Move from top level.
8293         <msymbols>: New method.
8294         (class objfile_msymbols): Remove.
8295         * symtab.c (default_collect_symbol_completion_matches_break_on):
8296         Update.
8297         * symmisc.c (dump_msymbols): Update.
8298         * stabsread.c (scan_file_globals): Update.
8299         * objc-lang.c (info_selectors_command, info_classes_command)
8300         (find_methods): Update.
8301         * minsyms.c (find_solib_trampoline_target): Update.
8302         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8303         * coffread.c (coff_symfile_read): Update.
8304         * ada-lang.c (ada_lookup_simple_minsym)
8305         (ada_collect_symbol_completion_matches): Update.
8306
8307 2019-01-16  Tom Tromey  <tom@tromey.com>
8308
8309         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8310         type.  Remove no-argument constructor.
8311         <iterator::operator++>: Simplify.
8312         <begin>: Update.
8313         <end>: Use minimal_symbol_count.
8314
8315 2019-01-16  Tom Tromey  <tom@tromey.com>
8316
8317         * objfiles.h (struct objfile) <psymtabs>: New method.
8318         (class objfile_psymtabs): Remove.
8319         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8320         typedef.
8321         <range>: New method.
8322         (require_partial_symbols): Change return type.
8323         * psymtab.c (require_partial_symbols)
8324         (psym_expand_symtabs_matching): Update.
8325         * mdebugread.c (parse_partial_symbols): Update.
8326         * dbxread.c (dbx_end_psymtab): Update.
8327
8328 2019-01-15  Tom Tromey  <tom@tromey.com>
8329
8330         * symtab.c (lookup_objfile_from_block)
8331         (lookup_symbol_in_objfile_symtabs)
8332         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8333         (find_line_symtab, info_sources_command)
8334         (default_collect_symbol_completion_matches_break_on)
8335         (make_source_files_completion_list): Update.
8336         * symmisc.c (print_objfile_statistics, dump_objfile)
8337         (maintenance_print_symbols, maintenance_info_symtabs)
8338         (maintenance_check_symtabs, maintenance_info_line_tables):
8339         Update.
8340         * source.c (select_source_symtab)
8341         (forget_cached_source_info_for_objfile): Update.
8342         * objfiles.h (class objfile_compunits): Remove.
8343         (struct objfile) <compunits_range>: New typedef.
8344         (compunits): New method.
8345         * objfiles.c (objfile_relocate1): Update.
8346         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8347         * maint.c (count_symtabs_and_blocks): Update.
8348         * linespec.c (iterate_over_all_matching_symtabs): Update.
8349         * cp-support.c (add_symbol_overload_list_qualified): Update.
8350         * coffread.c (coff_symtab_read): Update.
8351         * ada-lang.c (add_nonlocal_symbols)
8352         (ada_collect_symbol_completion_matches)
8353         (ada_add_global_exceptions): Update.
8354
8355 2019-01-15  Tom Tromey  <tom@tromey.com>
8356
8357         * progspace.h (program_space) <objfiles_safe_range>: New
8358         typedef.
8359         <objfiles_safe>: New method.
8360         * objfiles.h (class all_objfiles_safe): Remove.
8361         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8362         * jit.c (jit_inferior_exit_hook): Update.
8363
8364 2019-01-17  Tom Tromey  <tom@tromey.com>
8365
8366         * progspace.h (program_space) <objfiles_range>: New typedef.
8367         <objfiles>: New method.
8368         <objfiles_head>: Rename from objfiles.
8369         (object_files): Update.
8370         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8371         * guile/scm-pretty-print.c
8372         (ppscm_find_pretty_printer_from_objfiles): Update.
8373         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8374         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8375         Update.
8376         * python/py-progspace.c (pspy_get_objfiles): Update.
8377         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8378         Update.
8379         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8380         (objfpy_lookup_objfile_by_build_id): Update.
8381         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8382         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8383         Update.
8384         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8385         (expand_symtab_containing_pc, lookup_objfile_from_block)
8386         (lookup_static_symbol, basic_lookup_transparent_type)
8387         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8388         (find_line_symtab, info_sources_command)
8389         (default_collect_symbol_completion_matches_break_on)
8390         (make_source_files_completion_list, find_main_name): Update.
8391         * symmisc.c (print_symbol_bcache_statistics)
8392         (print_objfile_statistics, maintenance_print_symbols)
8393         (maintenance_print_msymbols, maintenance_print_objfiles)
8394         (maintenance_info_symtabs, maintenance_check_symtabs)
8395         (maintenance_expand_symtabs, maintenance_info_line_tables):
8396         Update.
8397         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8398         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8399         (map_overlay_command, unmap_overlay_command)
8400         (simple_overlay_update, expand_symtabs_matching)
8401         (map_symbol_filenames): Update.
8402         * symfile-debug.c (set_debug_symfile): Update.
8403         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8404         Update.
8405         * source.c (select_source_symtab, forget_cached_source_info):
8406         Update.
8407         * solib.c (solib_read_symbols): Update.
8408         * solib-spu.c (append_ocl_sos): Update.
8409         * psymtab.c (maintenance_print_psymbols)
8410         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8411         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8412         * printcmd.c (info_symbol_command): Update.
8413         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8414         Update.
8415         * objfiles.h (class all_objfiles): Remove.
8416         * objfiles.c (have_partial_symbols, have_full_symbols)
8417         (have_minimal_symbols, qsort_cmp, update_section_map)
8418         (shared_objfile_contains_address_p)
8419         (default_iterate_over_objfiles_in_search_order): Update.
8420         * objc-lang.c (info_selectors_command, info_classes_command)
8421         (find_methods): Update.
8422         * minsyms.c (find_solib_trampoline_target): Update.
8423         * maint.c (maintenance_info_sections)
8424         (maintenance_translate_address, count_symtabs_and_blocks):
8425         Update.
8426         * main.c (captured_main_1): Update.
8427         * linux-thread-db.c (try_thread_db_load_from_pdir)
8428         (has_libpthread): Update.
8429         * linespec.c (iterate_over_all_matching_symtabs)
8430         (search_minsyms_for_name): Update.
8431         * jit.c (jit_find_objf_with_entry_addr): Update.
8432         * hppa-tdep.c (find_unwind_entry)
8433         (hppa_lookup_stub_minimal_symbol): Update.
8434         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8435         Update.
8436         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8437         (elf_gnu_ifunc_resolve_by_got): Update.
8438         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8439         * dwarf-index-write.c (save_gdb_index_command): Update.
8440         * cp-support.c (add_symbol_overload_list_qualified): Update.
8441         * breakpoint.c (create_overlay_event_breakpoint)
8442         (create_longjmp_master_breakpoint)
8443         (create_std_terminate_master_breakpoint)
8444         (create_exception_master_breakpoint): Update.
8445         * blockframe.c (find_pc_partial_function): Update.
8446         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8447         (ada_collect_symbol_completion_matches)
8448         (ada_add_global_exceptions): Update.
8449
8450 2019-01-17  Tom Tromey  <tom@tromey.com>
8451
8452         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8453         declare VEC.
8454         (solib_target_parse_libraries): Change return type.
8455         (library_list_start_segment, library_list_start_section)
8456         (library_list_end_library, library_list_start_library); Update.
8457         (solib_target_free_library_list): Remove.
8458         (solib_target_parse_libraries): Remove cleanup.  Change return
8459         type.
8460         (solib_target_current_sos): Update.
8461
8462 2019-01-17  Tom Tromey  <tromey@bapiya>
8463
8464         * valprint.c: Replace "the the" with "the".
8465         * symtab.c: Replace "the the" with "the".
8466         * solib.c: Replace "the the" with "the".
8467         * solib-dsbt.c: Replace "the the" with "the".
8468         * linespec.c: Replace "the the" with "the".
8469         * dwarf2loc.h: Replace "the the" with "the".
8470         * amd64-windows-tdep.c: Replace "the the" with "the".
8471         * aarch64-tdep.c: Replace "the the" with "the".
8472
8473 2019-01-16  Keith Seitz  <keiths@redhat.com>
8474
8475         PR gdb/23773
8476         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8477         <builder>: Rename to ..
8478         <m_builder>: ... this and make private.
8479         (dwarf2_cu::get_builder): New method.  Change all users of
8480         `builder' to use this method.
8481         (dwarf2_start_symtab): Move to ...
8482         (dwarf2_cu::start_symtab): ... here.  Update all callers
8483         (setup_type_unit_groups): Move to ...
8484         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8485         callers.
8486         (dwarf2_cu::reset_builder): New method.
8487         (process_full_compunit, process_full_type_unit): Use
8488         dwarf2_cu::reset_builder.
8489         (follow_die_offset): Record the ancestor CU if it is different
8490         from the followed DIE's CU.
8491         (follow_die_sig_1): Likewise.
8492
8493 2019-01-15  Tom Tromey  <tom@tromey.com>
8494
8495         * remote.c (class remote_state) <buf>: Now a char_vector.
8496         <buf_size>: Remove.
8497         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8498         parameter.
8499         (remote_target::getpkt_or_notif_sane_1)
8500         (remote_target::getpkt_sane)
8501         (remote_target::getpkt_or_notif_sane): Likewise.
8502         (class remote_target) <putpkt>: New overload.
8503         (remote_target::read_frame): Change type of "buf_p".  Remove
8504         sizeof_p parameter.
8505         (packet_ok): New overload.
8506         (packet_check_result): New overload.
8507         Update all uses.
8508
8509 2019-01-14  Tom Tromey  <tom@tromey.com>
8510
8511         * remote-notif.c (handle_notification, remote_notif_ack)
8512         (remote_notif_parse): Make "buf" const.
8513         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8514         const.
8515         (remote_notif_parse, remote_notif_ack, handle_notification):
8516         Likewise.
8517         * remote.c (remote_notif_stop_parse): Make "buf" const.
8518         (remote_target::remote_parse_stop_reply): Make "buf" const.
8519         (remote_notif_stop_ack): Make "buf" const.
8520
8521 2019-01-14  Tom Tromey  <tom@tromey.com>
8522
8523         * remote.c (remote_console_output): Make parameter const.
8524
8525 2019-01-14  Tom Tromey  <tom@tromey.com>
8526
8527         * target-debug.h (target_debug_print_signals): Constify.
8528         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8529         * procfs.c (procfs_target::pass_signals): Update.
8530         * linux-nat.c (linux_nat_target::pass_signals): Update.
8531         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8532         * target-delegates.c: Rebuild.
8533         * remote.c (remote_target::program_signals): Update.
8534         (remote_target::pass_signals): Update.
8535         * target.c (target_pass_signals): Constify argument.
8536         (target_program_signals): Likewise.
8537         * target.h (struct target_ops) <pass_signals, program_signals>:
8538         Constify argument.
8539         (target_pass_signals, target_program_signals): Constify argument.
8540
8541 2019-01-14  Tom Tromey  <tom@tromey.com>
8542
8543         PR tui/28819:
8544         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8545
8546 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8547
8548         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8549         field.
8550         * rs6000-tdep.c: Include reggroups.h.
8551         (IS_V_ALIAS_PSEUDOREG): Define.
8552         (rs6000_register_name): Return names for the "vX" aliases.
8553         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8554         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8555         aliases.  Call default_register_reggroup_p for all other
8556         pseudo-registers.
8557         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8558         New functions.
8559         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8560         Handle "vX" aliases.
8561         (v_alias_pseudo_register_collect): New function.
8562         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8563         (rs6000_gdbarch_init): Initialize "vX" aliases as
8564         pseudo-registers.  Restore registration of
8565         rs6000_pseudo_register_reggroup_p with
8566         set_tdesc_pseudo_register_reggroup_p.
8567
8568 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8569
8570         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8571         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8572         set_gdbarch_num_pseudo_regs.
8573
8574 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8575
8576         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8577         Remove arg prefixname, add do_set and do_show.
8578         Add member functions set_list and show_list.
8579         * cli/cli-style.c (class cli_style_option): Update accordingly.
8580         (style_set_list): Move to file scope.
8581         (style_show_list): Likewise.
8582         (set_style): Call help_list.
8583         (show_style): Call cmd_show_list.
8584         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8585         Update to use the new macro.
8586
8587 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8588
8589         * ada-lang.c (_initialize_ada_language): Expand the help text
8590         for the "catch exception" command.
8591
8592 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8593
8594         * symtab.c (matching_obj_sections): Initialize obj,
8595         declare it closer to its usage.
8596
8597 2019-01-10  Tom Tromey  <tom@tromey.com>
8598
8599         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8600         (basic_inf_threads_range): Remove.
8601         (inf_threads_range, inf_non_exited_threads_range)
8602         (safe_inf_threads_range): Use next_adapter.
8603
8604 2019-01-10  Keith Seitz  <keiths@redhat.com>
8605
8606         PR gdb/23712
8607         PR symtab/23010
8608         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8609         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8610
8611 2019-01-10  Keith Seitz  <keiths@redhat.com>
8612
8613         PR gdb/23712
8614         PR symtab/23010
8615         * dictionary.c (pending_to_vector): Remove.
8616         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8617         Remove _1 suffix, replacing functions of the same name.  Update
8618         all callers.
8619         (dict_create_hashed, dict_create_hashed_expandable)
8620         (dict_create_linear, dict_create_linear_expandable, dict_free)
8621         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8622         Make functions static.
8623
8624 2019-01-10  Keith Seitz  <keiths@redhat.com>
8625
8626         PR gdb/23712
8627         PR symtab/23010
8628         * dictionary.h (struct dictionary): Replace declaration with
8629         multidictionary.
8630         (dict_create_hashed, dict_create_hashed_expandable)
8631         (dict_create_linear, dict_create_linear_expandable)
8632         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8633         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8634         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8635         taking multidictionary argument.
8636         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8637         * block.h (struct block) <dict>: Change to multidictionary
8638         and rename `multidict'.
8639         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8640         symmisc.c: Update all dictionary references to multidictionary.
8641
8642 2019-01-10  Keith Seitz  <keiths@redhat.com>
8643
8644         PR gdb/23712
8645         PR symtab/23010
8646         * dictionary.c: Include unordered_map.
8647         (pending_to_vector): New function.
8648         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8649         Rewrite the non-"_1" functions to take vector instead
8650         of linked list.
8651         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8652         "new" _1 versions of the same name.
8653         (multidictionary): Define.
8654         (std::hash<enum language): New definition.
8655         (collate_pending_symbols_by_language, mdict_create_hashed)
8656         (mdict_create_hashed_expandable, mdict_create_linear)
8657         (mdict_create_linear_expandable, mdict_free)
8658         (find_language_dictionary, create_new_language_dictionary)
8659         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8660         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8661         (mdict_size, mdict_empty): New functions.
8662         * dictionary.h (mdict_iterator): Define.
8663
8664 2019-01-10  Pedro Alves  <palves@redhat.com>
8665
8666         * breakpoint.c (read_uploaded_action)
8667         (create_tracepoint_from_upload): Adjust to use
8668         gdb::unique_xmalloc_ptr.
8669         * ctf.c (ctf_write_uploaded_tp):
8670         (SET_ARRAY_FIELD): Use emplace_back.
8671         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8672         * tracefile-tfile.c (tfile_write_uploaded_tp):
8673         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8674         gdb::unique_xmalloc_ptr.
8675         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8676         at_string, cond_string, cmd_strings>: Replace char pointers
8677         with gdb::unique_xmalloc_ptr.
8678
8679 2019-01-10  Pedro Alves  <palves@redhat.com>
8680
8681         * solib-target.c (library_list_start_library): Don't xstrdup name.
8682
8683 2019-01-10  Pedro Alves  <palves@redhat.com>
8684
8685         * mdebugread.c (parse_partial_symbols): Use
8686         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8687
8688 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8689
8690         * linux-fork.c (scoped_switch_fork_info)
8691         <~scoped_switch_fork_info>: Fix incorrect variable name.
8692
8693 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8694
8695         * linux-fork.c (scoped_switch_fork_info)
8696         <scoped_switch_fork_info>: Make explicit.
8697         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8698
8699 2019-01-10  Tom Tromey  <tom@tromey.com>
8700
8701         * objfiles.h (objfile::reset_psymtabs): Update.
8702         * objfiles.c (objfile::objfile): Update.
8703         * psymtab.h (psymtab_storage::obstack): Update.
8704         (psymtab_storage::m_obstack): Use gdb::optional.
8705         (class psymtab_storage): Update comment.  Remove objfile
8706         parameter.
8707         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8708
8709 2019-01-10  Tom Tromey  <tom@tromey.com>
8710
8711         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8712         <free_psymtabs>: Now private.
8713         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8714         (allocate_psymtab): Use new method.
8715
8716 2019-01-10  Tom Tromey  <tom@tromey.com>
8717
8718         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8719         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8720         * mdebugread.c (parse_partial_symbols): Use
8721         allocate_dependencies.
8722         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8723         allocate_dependencies.
8724         (process_psymtab_comp_unit_reader)
8725         (build_type_psymtab_dependencies): Likewise.
8726         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8727
8728 2019-01-10  Tom Tromey  <tom@tromey.com>
8729
8730         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8731         PSYMBOL_SET_LANGUAGE.
8732         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8733
8734 2019-01-10  Tom Tromey  <tom@tromey.com>
8735
8736         * psymtab.h (psymtab_storage::obstack): New method.
8737         <m_obstack>: Rename from obstack; now private.
8738         * psymtab.c (psymtab_storage): Update.
8739         * dwarf2read.c (create_addrmap_from_index)
8740         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8741         Update.
8742
8743 2019-01-10  Tom Tromey  <tom@tromey.com>
8744
8745         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8746         * objfiles.h (objfile::reset_psymtabs): New method.
8747
8748 2019-01-10  Tom Tromey  <tom@tromey.com>
8749
8750         * symmisc.c (print_symbol_bcache_statistics): Update.
8751         (print_objfile_statistics): Update.
8752         * symfile.c (reread_symbols): Update.
8753         * psymtab.h (class psymtab_storage): New.
8754         * psymtab.c (psymtab_storage): New constructor.
8755         (~psymtab_storage): New destructor.
8756         (require_partial_symbols): Update.
8757         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8758         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8759         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8760         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8761         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8762         (start_psymtab_common, end_psymtab_common)
8763         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8764         (allocate_psymtab): Update.
8765         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8766         Update.
8767         (dump_psymtab_addrmap, maintenance_print_psymbols)
8768         (maintenance_check_psymtabs): Update.
8769         (class objfile_psymtabs): Move to objfiles.h.
8770         * psympriv.h (discard_psymtab): Now inline.
8771         (psymtab_discarder::psymtab_discarder): Update.
8772         (psymtab_discarder::~psymtab_discarder): Update.
8773         (ALL_OBJFILE_PSYMTABS): Rewrite.
8774         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8775         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8776         Remove fields.
8777         <partial_symtabs>: New field.
8778         (class objfile_psymtabs): Move from psymtab.h.  Update.
8779         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8780         psymbol_cache.
8781         (objfile::~objfile): Don't destroy psymbol_cache.
8782         * mdebugread.c (parse_partial_symbols): Update.
8783         * dwarf2read.c (create_addrmap_from_index)
8784         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8785         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8786         (add_partial_subprogram, dwarf2_ranges_read): Update.
8787         * dwarf-index-write.c (write_address_map)
8788         (write_one_signatured_type, recursively_write_psymbols)
8789         (class debug_names, class debug_names, write_psymtabs_to_index):
8790         Update.
8791
8792 2019-01-10  Tom Tromey  <tom@tromey.com>
8793
8794         * symtab.h (SYMBOL_SET_NAMES): Update.
8795         (symbol_set_names): Update.
8796         (MSYMBOL_SET_NAMES): Update.
8797         * symtab.c (symbol_set_names): Change argument to be an
8798         objfile_per_bfd_storage.
8799         * psymtab.c (add_psymbol_to_bcache): Update.
8800         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8801
8802 2019-01-10  Tom Tromey  <tom@tromey.com>
8803
8804         * symtab.c (create_demangled_names_hash): Change argument to be an
8805         objfile_per_bfd_storage.
8806         (symbol_set_names): Update.
8807
8808 2019-01-10  Tom Tromey  <tom@tromey.com>
8809
8810         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8811         init_psymbol_list.
8812         * psymtab.c (init_psymbol_list): Do nothing if already called.
8813         * psympriv.h (init_psymbol_list): Add comment.
8814         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8815         init_psymbol_list.
8816         * dbxread.c (dbx_symfile_read): Unconditionally call
8817         init_psymbol_list.
8818
8819 2019-01-10  Tom Tromey  <tom@tromey.com>
8820
8821         * xcoffread.c (scan_xcoff_symtab): Update.
8822         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8823         "where".
8824         * mdebugread.c (parse_partial_symbols)
8825         (handle_psymbol_enumerators): Update.
8826         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8827         * dbxread.c (read_dbx_symtab): Update.
8828         * psympriv.h (psymbol_placement): New enum.
8829         (add_psymbol_to_list): Update.
8830
8831 2019-01-10  Tom Tromey  <tom@tromey.com>
8832
8833         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8834         static_psymbols parameters.
8835         (scan_xcoff_symtab): Update.
8836         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8837         static_psymbols parameters.
8838         * psympriv.h (start_psymtab_common): Update.
8839         * mdebugread.c (parse_partial_symbols): Update.
8840         * dwarf2read.c (create_partial_symtab): Update.
8841         * dbxread.c (read_dbx_symtab): Update.
8842         (start_psymtab): Remove global_psymbols and static_psymbols
8843         parameters.
8844
8845 2019-01-10  Tom Tromey  <tom@tromey.com>
8846
8847         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8848         * psymtab.c (allocate_psymtab): Add comment.
8849         * psympriv.h (allocate_psymtab): Add comment.
8850         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8851         initializations.
8852         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8853
8854 2019-01-10  Tom Tromey  <tom@tromey.com>
8855
8856         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8857         Don't declare.
8858         * mipsread.c: Include mdebugread.h.
8859         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8860         Declare.
8861         * elfread.c: Include mdebugread.h.
8862
8863 2019-01-09  Tom Tromey  <tom@tromey.com>
8864
8865         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8866         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8867         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8868         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8869         (psym_lookup_symbol, psym_find_last_source_symtab)
8870         (psym_forget_cached_source_info, psym_print_stats)
8871         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8872         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8873         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8874         (psym_find_compunit_symtab_by_address)
8875         (maintenance_print_psymbols, maintenance_info_psymtabs)
8876         (maintenance_check_psymtabs): Use ranged for.
8877         * psymtab.h (class objfile_psymtabs): New.
8878         (require_partial_symbols): Return objfile_psymtabs.
8879         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8880
8881 2019-01-09  Tom Tromey  <tom@tromey.com>
8882
8883         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8884         (find_pc_mapped_section, list_overlays_command)
8885         (map_overlay_command, unmap_overlay_command)
8886         (simple_overlay_update): Use all_objfiles.
8887         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8888         * printcmd.c (info_symbol_command): Use all_objfiles.
8889         * objfiles.h (ALL_OBJSECTIONS): Remove.
8890         * maint.c (maintenance_translate_address): Use all_objfiles.
8891         * gcore.c (gcore_create_callback): Use all_objfiles.
8892         (objfile_find_memory_regions): Likewise.
8893
8894 2019-01-09  Tom Tromey  <tom@tromey.com>
8895
8896         * symtab.c (find_line_symtab, info_sources_command)
8897         (make_source_files_completion_list): Use objfile_compunits.
8898         * source.c (select_source_symtab): Use objfile_compunits.
8899         * objfiles.h (struct objfile): Update comment.
8900         (ALL_OBJFILES): Remove.
8901         (ALL_FILETABS): Remove.
8902         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8903         objfile_compunits.
8904
8905 2019-01-09  Tom Tromey  <tom@tromey.com>
8906
8907         * symmisc.c (print_objfile_statistics, dump_objfile)
8908         (maintenance_print_symbols): Use compunit_filetabs.
8909         * source.c (forget_cached_source_info_for_objfile): Use
8910         compunit_filetabs.
8911         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8912         (ALL_FILETABS): Use compunit_filetabs.
8913         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8914         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8915
8916 2019-01-09  Tom Tromey  <tom@tromey.com>
8917
8918         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8919         (compunit_filetabs): New.
8920         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8921         compunit_filetabs.
8922         (info_sources_command, make_source_files_completion_list): Remove
8923         declaration.
8924         * symmisc.c (print_objfile_statistics, dump_objfile)
8925         (maintenance_print_symbols): Remove declaration.
8926         (maintenance_info_symtabs): Use compunit_filetabs.
8927         (maintenance_info_line_tables): Likewise.
8928         * source.c (select_source_symtab): Change local variable name.
8929         (forget_cached_source_info_for_objfile): Remove declaration.
8930         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8931         * objfiles.c (objfile_relocate1): Remove declaration.
8932         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8933         declaration.
8934         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8935         * coffread.c (coff_symtab_read): Remove declaration.
8936         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8937         compunit_filetabs.
8938
8939 2019-01-09  Tom Tromey  <tom@tromey.com>
8940
8941         * symtab.c (lookup_objfile_from_block)
8942         (find_pc_sect_compunit_symtab, search_symbols)
8943         (default_collect_symbol_completion_matches_break_on): Use
8944         objfile_compunits.
8945         * objfiles.h (ALL_COMPUNITS): Remove.
8946         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8947         * cp-support.c (add_symbol_overload_list_qualified): Use
8948         objfile_compunits.
8949         * ada-lang.c (ada_collect_symbol_completion_matches)
8950         (ada_add_global_exceptions): Use objfile_compunits.
8951
8952 2019-01-09  Tom Tromey  <tom@tromey.com>
8953
8954         * source.c (select_source_symtab)
8955         (forget_cached_source_info_for_objfile): Remove declaration.
8956         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8957         declaration.
8958         * maint.c (count_symtabs_and_blocks): Remove declaration.
8959         * cp-support.c (add_symbol_overload_list_qualified): Remove
8960         declaration.
8961         * coffread.c (coff_symtab_read): Remove declaration.
8962         * symtab.c (lookup_symbol_in_objfile_symtabs)
8963         (basic_lookup_transparent_type_1): Use objfile_compunits.
8964         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8965         (info_sources_command, search_symbols)
8966         (default_collect_symbol_completion_matches_break_on)
8967         (make_source_files_completion_list): Remove declaration.
8968         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8969         (ada_collect_symbol_completion_matches)
8970         (ada_add_global_exceptions): Remove declaration.
8971         * linespec.c (iterate_over_all_matching_symtabs): Use
8972         objfile_compunits.
8973         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8974         (class objfile_compunits): New.
8975         (ALL_COMPUNITS): Use objfile_compunits.
8976         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8977         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8978         objfile_compunits.
8979         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8980
8981 2019-01-09  Tom Tromey  <tom@tromey.com>
8982
8983         * symtab.c (search_symbols)
8984         (default_collect_symbol_completion_matches_break_on): Use
8985         objfile_msymbols.
8986         * ada-lang.c (ada_lookup_simple_minsym)
8987         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8988         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8989         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8990         objfile_msymbols.
8991         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8992         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8993         * objc-lang.c (find_methods): Use objfile_msymbols.
8994         (info_selectors_command, info_classes_command): Likewise.
8995         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8996         * objfiles.h (class objfile_msymbols): New.
8997         (ALL_OBJFILE_MSYMBOLS): Remove.
8998         (ALL_MSYMBOLS): Remove.
8999
9000 2019-01-09  Tom Tromey  <tom@tromey.com>
9001
9002         * common/next-iterator.h (next_adapter): Add Iterator template
9003         parameter.
9004         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9005         (class all_objfiles_safe): New.
9006         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9007         * objfiles.c (put_objfile_before): Update comment.
9008         (add_separate_debug_objfile): Likewise.
9009         (free_all_objfiles): Use all_objfiles_safe.
9010         (objfile_purge_solibs): Likewise.
9011
9012 2019-01-09  Tom Tromey  <tom@tromey.com>
9013
9014         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9015         (expand_symtab_containing_pc, lookup_static_symbol)
9016         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9017         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9018         all_objfiles.
9019         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9020         * breakpoint.c (create_overlay_event_breakpoint)
9021         (create_longjmp_master_breakpoint)
9022         (create_std_terminate_master_breakpoint)
9023         (create_exception_master_breakpoint): Use all_objfiles.
9024         * linux-thread-db.c (try_thread_db_load_from_pdir)
9025         (has_libpthread): Use all_objfiles.
9026         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9027         * linespec.c (iterate_over_all_matching_symtabs)
9028         (search_minsyms_for_name): Use all_objfiles.
9029         * maint.c (maintenance_info_sections): Use all_objfiles.
9030         * main.c (captured_main_1): Use all_objfiles.
9031         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9032         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9033         * guile/scm-pretty-print.c
9034         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9035         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9036         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9037         (maintenance_print_msymbols): Use all_objfiles.
9038         * source.c (select_source_symtab): Use all_objfiles.
9039         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9040         * symfile.c (remove_symbol_file_command)
9041         (expand_symtabs_matching, map_symbol_filenames): Use
9042         all_objfiles.
9043         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9044         all_objfiles.
9045         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9046         * objc-lang.c (find_methods): Use all_objfiles.
9047         * objfiles.c (have_partial_symbols, have_full_symbols)
9048         (have_minimal_symbols, qsort_cmp)
9049         (default_iterate_over_objfiles_in_search_order): Use
9050         all_objfiles.
9051         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9052         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9053         (maintenance_check_psymtabs): Use all_objfiles.
9054         (ALL_PSYMTABS): Remove.
9055         * compile/compile-object-run.c (do_module_cleanup): Use
9056         all_objfiles.
9057         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9058         * cp-support.c (add_symbol_overload_list_qualified): Use
9059         all_objfiles.
9060         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9061         Use all_objfiles.
9062         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9063         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9064         all_objfiles.
9065         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9066         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9067         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9068         Uses all_objfiles.
9069         * solib.c (solib_read_symbols): Use all_objfiles
9070
9071 2019-01-09  Tom Tromey  <tom@tromey.com>
9072
9073         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9074         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9075         all_objfiles.
9076         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9077         * symmisc.c (print_symbol_bcache_statistics)
9078         (print_objfile_statistics, maintenance_print_objfiles)
9079         (maintenance_info_symtabs, maintenance_check_symtabs)
9080         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9081         all_objfiles.
9082         * source.c (forget_cached_source_info): Use all_objfiles.
9083         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9084         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9085         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9086         * objfiles.c (update_section_map): Use all_objfiles.
9087         (shared_objfile_contains_address_p): Likewise.
9088         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9089         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9090
9091 2019-01-09  Tom Tromey  <tom@tromey.com>
9092
9093         * common/next-iterator.h: New file.
9094         * objfiles.h (class all_objfiles): New.
9095         (struct objfile_iterator): New.
9096
9097 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9098
9099         * NEWS: Move the description of the changed "frame", "select-frame",
9100          and "info frame" commands to the Changed commands section.
9101
9102 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9103
9104         * gdbtypes.c (check_stub_method_group): Remove handling of old
9105         mangling schemes.
9106         * linespec.c (find_methods): Likewise.
9107         * stabsread.c (read_member_functions): Likewise.
9108         * valops.c (search_struct_method): Likewise.
9109         (value_struct_elt_for_reference): Likewise.
9110         * NEWS: Mention this change.
9111
9112 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9113
9114         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9115         print_source_lines.
9116         * source.c (print_source_lines_base): Update line number check.
9117         (print_source_lines): New function.
9118         (source_lines_range::source_lines_range): New function.
9119         * source.h (class source_lines_range): New class.
9120         (print_source_lines): New declaration.
9121
9122 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9123
9124         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9125
9126 2019-01-08  Tom Tromey  <tom@tromey.com>
9127             Simon Marchi  <simon.marchi@ericsson.com>
9128
9129         PR gdb/24060
9130         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9131         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9132         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9133         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9134         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9135         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9136
9137 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9138
9139         * source.c (select_source_symtab): Move header comment to
9140         declaration in source.h.
9141         (forget_cached_source_info_for_objfile): Likewise.
9142         (forget_cached_source_info): Likewise.
9143         (identify_source_line): Likewise.
9144         * source.h (identify_source_line): Move declaration from symtab.h
9145         and add comment from source.c
9146         (print_source_lines): Likewise.
9147         (forget_cached_source_info_for_objfile): Likewise.
9148         (forget_cached_source_info): Likewise.
9149         (select_source_symtab): Likewise.
9150         (enum print_source_lines_flag): Move definition from symtab.h.
9151         * symtab.h (identify_source_line): Move declaration to source.h.
9152         (print_source_lines): Likewise.
9153         (forget_cached_source_info_for_objfile): Likewise.
9154         (forget_cached_source_info): Likewise.
9155         (select_source_symtab): Likewise.
9156         (enum print_source_lines_flag): Move definition to source.h.
9157         * tui/tui-hooks.c: Add 'source.h' include.
9158
9159 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9160
9161         * source.c (print_source_lines_base): Handle requests to print
9162         reverse line number sequences, and guard against empty lines
9163         string.
9164
9165 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9166
9167         * source.c (print_source_lines_base): Fix skip of '\r' if next
9168         character is '\n'.
9169
9170 2019-01-06  Tom Tromey  <tom@tromey.com>
9171
9172         * c-exp.y (struct c_parse_state) <macro_original_text,
9173         expansion_obstack>: New member.
9174         (macro_original_text, expansion_obstack): Remove globals.
9175         (scan_macro_expansion, scanning_macro_expansion)
9176         (finished_macro_expansion): Update.
9177         (scan_macro_cleanup): Remove.
9178         (yylex, c_parse): Update.
9179
9180 2019-01-06  Tom Tromey  <tom@tromey.com>
9181
9182         * c-exp.y (struct c_parse_state) <strings>: New member.
9183         (operator_stoken): Update.
9184
9185 2019-01-06  Tom Tromey  <tom@tromey.com>
9186
9187         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9188         (union type_stack_elt) <typelist_val>: Now a pointer to
9189         std::vector.
9190         (type_stack_cleanup): Don't declare.
9191         (push_typelist): Update.
9192         * parse.c (pop_typelist): Return a std::vector.
9193         (push_typelist): Take a std::vector.
9194         (follow_types): Update.  Do not free args.
9195         (type_stack_cleanup): Remove.
9196         * c-exp.y (struct c_parse_state): New.
9197         (cpstate): New global.
9198         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9199         (nonempty_typelist): Update.
9200         (func_mod): Create a new vector.
9201         (c_parse): Create a c_parse_state.
9202         (check_parameter_typelist): Do not delete params.
9203         (function_method): Update.  Do not delete type_list.
9204
9205 2019-01-06  Tom Tromey  <tom@tromey.com>
9206
9207         PR gdb/28155:
9208         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9209         check_typedef.
9210         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9211         (print_return_value): Likewise.
9212
9213 2019-01-05  Tom Tromey  <tom@tromey.com>
9214
9215         * contrib/cleanup_check.py: Remove.
9216         * contrib/gcc-with-excheck: Remove.
9217         * contrib/exsummary.py: Remove.
9218         * contrib/excheck.py: Remove.
9219
9220 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9221
9222         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9223         NULL. Initialize tpprev to NULL instead of assigning it
9224         to NULL on the next statement.
9225         * windows-nat.c (windows_delete_thread): Remove check for
9226         main_thread_id before printing thread exit notifications.
9227         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9228         Remove thread ID check against main_thread_id.
9229         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9230         windows_delete_thread.
9231         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9232
9233 2019-01-04  Tom Tromey  <tom@tromey.com>
9234
9235         * compile/compile.c (_initialize_compile): Use upper case for
9236         metasyntactic variables.
9237         * symmisc.c (_initialize_symmisc): Use upper case for
9238         metasyntactic variables.
9239         * psymtab.c (_initialize_psymtab): Use upper case for
9240         metasyntactic variables.
9241         * demangle.c (demangle_command): Use upper case for metasyntactic
9242         variables.
9243         (_initialize_demangler): Likewise.
9244         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9245         variables.
9246
9247 2019-01-03  Tom Tromey  <tom@tromey.com>
9248
9249         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9250
9251 2019-01-03  Tom Tromey  <tom@tromey.com>
9252
9253         * python/py-symtab.c (salpy_str): Update.
9254         (struct salpy_sal_object) <symtab>: Now a PyObject.
9255         (salpy_dealloc): Update.
9256         (del_objfile_sal): Use gdbpy_ref.
9257
9258 2019-01-03  Tom Tromey  <tom@tromey.com>
9259
9260         * python/py-type.c (convert_field): Use new_reference.  Return
9261         gdbpy_ref.
9262         (make_fielditem): Return gdbpy_ref.
9263         (typy_fields): Update.
9264         (typy_getitem): Update.
9265         (field_name): Return gdbpy_ref.  Use new_reference.
9266         (typy_iterator_iternext): Update.
9267
9268 2019-01-03  Tom Tromey  <tom@tromey.com>
9269
9270         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9271
9272 2019-01-03  Tom Tromey  <tom@tromey.com>
9273
9274         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9275         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9276         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9277         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9278         (pspy_set_type_printers): Likewise.
9279         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9280         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9281         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9282         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9283         (objfpy_set_type_printers): Likewise.
9284
9285 2019-01-03  Tom Tromey  <tom@tromey.com>
9286
9287         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9288         (gdbpy_print_stack): Use gdbpy_err_fetch.
9289         * python/python-internal.h (class gdbpy_err_fetch): New class.
9290         (class gdbpy_enter) <m_error_type, m_error_value,
9291         m_error_traceback>: Remove.
9292         <m_error>: New member.
9293         (gdbpy_exception_to_string): Don't declare.
9294         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9295         * python/py-value.c (convert_value_from_python): Use
9296         gdbpy_err_fetch.
9297         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9298         gdbpy_exception_to_string.
9299         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9300         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9301         gdbpy_err_fetch.
9302
9303 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9304
9305         * linux-nat.c (delete_lwp_cleanup): Delete.
9306         (struct lwp_deleter): New struct.
9307         (lwp_info_up): New typedef.
9308         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9309         lwp_info_up.
9310
9311 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9312
9313         * linux-fork.c (class scoped_switch_fork_info): New class.
9314         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9315
9316 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9317
9318         * valops.c (find_overload_match): Remove use of null_cleanup, and
9319         calls to do_cleanups.
9320
9321 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * compile/compile-cplus-types.c
9324         (compile_cplus_instance::decl_name): Handle changes to
9325         cp_func_name.
9326         * cp-support.c (cp_func_name): Update header comment, update
9327         return type.
9328         * cp-support.h (cp_func_name): Update return type in declaration.
9329         * valops.c (find_overload_match): Move temp_func local to top
9330         level of function and change its type.  Use temp_func to hold and
9331         delete temporary string obtained from cp_func_name.
9332
9333 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9334
9335         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9336         gdb::char_vector, remove cleanup, and update uses of `msg`.
9337
9338 2019-01-03  Jim Wilson  <jimw@sifive.com>
9339
9340         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9341
9342 2019-01-02  Tom Tromey  <tom@tromey.com>
9343
9344         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9345         (tdesc_parse_xml): Remove cleanups.
9346         * target-descriptions.h (make_cleanup_free_target_description):
9347         Don't declare.
9348         (target_desc_deleter): New struct.
9349         (target_desc_up): New typedef.
9350         * target-descriptions.c (target_desc_deleter::operator()): Rename
9351         from free_target_description.
9352         (make_cleanup_free_target_description): Remove.
9353
9354 2019-01-02  Tom Tromey  <tom@tromey.com>
9355
9356         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9357         constructor, destructor.
9358         (linespec_parser): Remove typedef.
9359         (~linespec_parser): Rename from linespec_parser_delete.
9360         (linespec_lex_to_end, linespec_complete_label)
9361         (linespec_complete): Update.
9362         (decode_line_full): Remove cleanups.
9363         (decode_line_1): Update.
9364
9365 2019-01-02  Tom Tromey  <tom@tromey.com>
9366
9367         * python/python-internal.h (inferior_to_inferior_object): Change
9368         return type.
9369         * python/py-exitedevent.c (create_exited_event_object): Update.
9370         * python/py-inferior.c (inferior_to_inferior_object): Return
9371         gdbpy_ref.
9372         (python_new_inferior, python_inferior_deleted)
9373         (thread_to_thread_object, delete_thread_object)
9374         (build_inferior_list, gdbpy_selected_inferior): Update.
9375         * python/py-infthread.c (create_thread_object): Update.  Also fail
9376         if inferior_to_inferior_object fails.
9377
9378 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9379
9380         * inferior.h (class inferior) <displaced_step_state>: New field.
9381         * infrun.h (struct displaced_step_state): Move here from
9382         infrun.c.  Initialize fields, add constructor.
9383         <inf>: Remove field.
9384         <reset>: New method.
9385         * infrun.c (struct displaced_step_inferior_state): Move to
9386         infrun.h.
9387         (displaced_step_inferior_states): Remove.
9388         (get_displaced_stepping_state): Adust.
9389         (displaced_step_in_progress_any_inferior): Adjust.
9390         (displaced_step_in_progress_thread): Adjust.
9391         (displaced_step_in_progress): Adjust.
9392         (add_displaced_stepping_state): Remove.
9393         (get_displaced_step_closure_by_addr): Adjust.
9394         (remove_displaced_stepping_state): Remove.
9395         (infrun_inferior_exit): Call displaced_step_state.reset.
9396         (use_displaced_stepping): Don't check for NULL.
9397         (displaced_step_prepare_throw): Call
9398         get_displaced_stepping_state.
9399         (displaced_step_fixup): Don't check for NULL.
9400         (prepare_for_detach): Don't check for NULL.
9401
9402 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9403
9404         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9405          in case of call that did not complete.
9406
9407 2019-01-02  Andrey Utkin  <autkin@undo.io>
9408
9409         * symfile.c (find_separate_debug_file): Fix search of debug files for
9410         remote debuggee.
9411
9412 2019-01-02  Tom Tromey  <tom@tromey.com>
9413
9414         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9415         indentation.
9416         * python/py-frame.c (frapy_older): Remove cast.
9417         (frapy_newer): Likewise.
9418         * python/py-breakpoint.c (local_setattro): Remove cast.
9419         * python/py-arch.c (archpy_name): Remove local variable.
9420         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9421
9422 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9423
9424         * unittests/basic_string_view/element_access/char/empty.cc:
9425         Fix year range in copyright header.
9426
9427 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9428
9429         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9430         Delete.
9431         <operator==>: Update with for removed field.
9432         <hash>: Likewise.
9433         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9434         <isa_features>: ...this.
9435         <abi_features>: New field.
9436         (riscv_isa_flen): Update comment.
9437         (riscv_abi_xlen): New declaration.
9438         (riscv_abi_flen): New declaration.
9439         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9440         isa_features.
9441         (riscv_abi_xlen): New function.
9442         (riscv_isa_flen): Update to get answer from isa_features.
9443         (riscv_abi_flen): New function.
9444         (riscv_has_fp_abi): Update to get answer from abi_features.
9445         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9446         xlen and flen.
9447         (riscv_call_info) <xlen, flen>: Update comment.
9448         (riscv_call_arg_struct): Remove invalid assertions
9449         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9450         is removed.
9451         (riscv_gdbarch_init): Gather isa features and abi features
9452         separately, ensure both match on the gdbarch when reusing an old
9453         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9454         a target with 64-bit float hardware.
9455
9456 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9457
9458         * source.c (search_command_helper): Stop reverse search
9459         when line 1 has been searched.
9460
9461 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9462
9463         * record-full.c (record_full_base_target::close): Rewrite
9464         record_full_core_buf_list free logic.
9465
9466 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9467
9468         * break-catch-syscall.c (print_one_catch_syscall): xfree
9469         the last text.
9470
9471 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9472
9473         * top.c (print_gdb_version): Update Copyright year in version
9474         message.
9475
9476 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9477
9478         Update copyright year range in all GDB files.
9479
9480 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9481
9482         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9483
9484 For older changes see ChangeLog-2018.
9485 \f
9486 Local Variables:
9487 mode: change-log
9488 left-margin: 8
9489 fill-column: 74
9490 version-control: never
9491 coding: utf-8
9492 End:
9493