gdb/ChangeLog

   1 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * arm-linux-nat.c: Add include.
   4
   5 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
   6
   7         * source-cache.c (source_cache::get_source_lines): Re-read
   8         fullname after calling open_source_file.
   9
  10 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  11
  12         * NEWS: Mention TLS support for FreeBSD.
  13
  14 2019-03-25  Tom Tromey  <tromey@adacore.com>
  15
  16         * minsyms.c (BUNCH_SIZE): Update comment.
  17         (~minimal_symbol_reader): Remove old comment.
  18         (compact_minimal_symbols): Update comment.
  19         (minimal_symbol_reader::install): Remove old comment.  Update
  20         other comments.
  21
  22 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  23
  24         * s390-linux-nat.c: Add include.
  25
  26 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  27
  28         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  29         Call linux_get_hwcap.
  30         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  31         Likewise.
  32         (aarch64_linux_get_hwcap): Remove function.
  33         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  34         declaration.
  35         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  36         linux_get_hwcap.
  37         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  38         * linux-tdep.c (linux_get_hwcap): Add function.
  39         (linux_get_hwcap2): Likewise.
  40         * linux-tdep.h (linux_get_hwcap): Add declaration.
  41         (linux_get_hwcap2): Likewise.
  42         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  43         (ppc_linux_get_hwcap2): Likewise.
  44         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  45         linux_get_hwcap.
  46         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  47         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  48         (ppc_linux_nat_target::read_description): Likewise.
  49         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  50         * s390-linux-nat.c: Likewise.
  51         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  52
  53 2019-03-24  Tom Tromey  <tom@tromey.com>
  54
  55         * ada-lang.c (standard_lookup): Simplify initialization.
  56         (ada_lookup_symbol_nonlocal): Simplify return.
  57         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
  58         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
  59         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
  60         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
  61         initialization.
  62         * solib.c (solib_global_lookup): Simplify.
  63         * symtab.c (null_block_symbol): Remove.
  64         (symbol_cache_lookup): Simplify returns.
  65         (lookup_language_this): Simplify returns.
  66         (lookup_symbol_aux): Simplify return.
  67         (lookup_local_symbol): Simplify returns.
  68         (lookup_global_symbol_from_objfile): Simplify return.
  69         (lookup_symbol_in_objfile_symtabs)
  70         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
  71         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
  72         (lookup_static_symbol, lookup_global_symbol): Simplify return.
  73         * cp-namespace.c (cp_lookup_bare_symbol)
  74         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
  75         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
  76         (cp_lookup_nested_symbol): Don't use null_block_symbol.
  77         (cp_lookup_symbol_via_imports): Simplify initialization.
  78         (find_symbol_in_baseclass): Likewise.
  79         * symtab.h (null_block_symbol): Remove.
  80         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
  81         (d_lookup_nested_symbol, d_lookup_symbol_imports)
  82         (d_lookup_symbol_module): Likewise.
  83         (find_symbol_in_baseclass): Simplify initialization.
  84
  85 2019-03-24  Tom Tromey  <tom@tromey.com>
  86
  87         * expression.h: Don't include symtab.h.
  88         (struct block): Forward declare.
  89
  90 2019-03-24  Tom Tromey  <tom@tromey.com>
  91
  92         * c-exp.y (typebase): Remove casts.
  93         * gdbtypes.c (lookup_unsigned_typename, )
  94         (lookup_signed_typename): Remove cast.
  95         * eval.c (parse_to_comma_and_eval): Remove cast.
  96         * parse.c (write_dollar_variable): Remove cast.
  97         * block.h (struct block) <superblock>: Now const.
  98         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
  99         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 100         (map_block): Make "block" const.
 101         * symfile.h (struct quick_symbol_functions)
 102         <map_matching_symbols>: Constify block argument to "callback".
 103         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 104         const.
 105         (find_pc_sect_compunit_symtab): Make "b" const.
 106         (find_symbol_at_address): Likewise.
 107         (search_symbols): Likewise.
 108         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 109         (dw2_debug_names_lookup_symbol): Likewise.
 110         (dw2_map_matching_symbols): Update.
 111         * p-valprint.c (pascal_val_print): Remove "block".
 112         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 113         (aux_add_nonlocal_symbols): Make "block" const.
 114         (resolve_subexp): Remove cast.
 115         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 116         const.
 117         (iterate_over_file_blocks): Likewise.
 118         * f-exp.y (%union) <bval>: Remove.
 119         * coffread.c (patch_opaque_types): Make "b" const.
 120         * spu-tdep.c (spu_catch_start): Make "block" const.
 121         * c-valprint.c (print_unpacked_pointer): Remove "block".
 122         * symmisc.c (dump_symtab_1): Make "b" const.
 123         (block_depth): Make "block" const.
 124         * d-exp.y (%union) <bval>: Remove.
 125         * cp-support.h (cp_lookup_rtti_type): Update.
 126         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 127         * psymtab.c (psym_lookup_symbol): Make "block" const.
 128         (maintenance_check_psymtabs): Make "b" const.
 129         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 130         (enumerate_locals, enumerate_args): Update.
 131         * python/py-symtab.c (stpy_global_block): Make "block" const.
 132         (stpy_static_block): Likewise.
 133         * inline-frame.c (block_starting_point_at): Make "new_block"
 134         const.
 135         * block.c (find_block_in_blockvector): Make return type const.
 136         (blockvector_for_pc_sect): Make "b" const.
 137         (find_block_in_blockvector): Make "b" const.
 138
 139 2019-03-23  Tom Tromey  <tom@tromey.com>
 140
 141         * varobj.c (varobj_create): Update.
 142         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 143         * printcmd.c (display_command, do_one_display): Don't reset
 144         innermost_block.
 145         * parser-defs.h (enum innermost_block_tracker_type): Move to
 146         expression.h.
 147         (innermost_block): Update comment.
 148         * parse.c (parse_exp_1): Add tracker_types parameter.
 149         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 150         tracker_types parameter.  Reset innermost_block.
 151         (parse_exp_in_context): Remove.
 152         (parse_expression_for_completion): Update.
 153         * objfiles.c (~objfile): Don't reset expression_context_block or
 154         innermost_block.
 155         * expression.h (enum innermost_block_tracker_type): Move from
 156         parser-defs.h.
 157         (parse_exp_1): Add tracker_types parameter.
 158         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 159         reset innermost_block.
 160
 161 2019-03-23  Tom Tromey  <tom@tromey.com>
 162
 163         * objfiles.h: Include bcache.h.
 164
 165 2019-03-23  Tom Tromey  <tom@tromey.com>
 166
 167         * linespec.c (get_current_search_block): Use
 168         scoped_restore_current_language.
 169         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 170
 171 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 172             Jiong Wang  <jiong.wang@arm.com>
 173
 174         * aarch64-linux-tdep.c
 175         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 176         section.
 177         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 178
 179 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 180             Jiong Wang  <jiong.wang@arm.com>
 181
 182         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 183         instructions.
 184         (aarch64_analyze_prologue_test): Add PACIASP test.
 185         (aarch64_prologue_prev_register): Unmask PC value.
 186
 187 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 188             Jiong Wang  <jiong.wang@arm.com>
 189
 190         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 191         (aarch64_dwarf2_prev_register): Unmask PC value.
 192         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 193         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 194         DW_CFA_AARCH64_negate_ra_state.
 195         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 196
 197 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 198             Jiong Wang  <jiong.wang@arm.com>
 199
 200         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 201         registers.
 202         (aarch64_pseudo_register_name): Likewise.
 203         (aarch64_pseudo_register_type): Likewise.
 204         (aarch64_pseudo_register_reggroup_p): Likewise.
 205         (aarch64_gdbarch_init): Add pauth registers.
 206         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 207         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 208         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 209         (struct gdbarch_tdep): Add regnum for ra_state.
 210
 211 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 212             Jiong Wang  <jiong.wang@arm.com>
 213
 214         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 215
 216 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 217             Jiong Wang  <jiong.wang@arm.com>
 218
 219         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 220         function.
 221         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 222         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 223         (aarch64_gdbarch_init): Add puth registers.
 224         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 225         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 226         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 227
 228 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 229             Jiong Wang  <jiong.wang@arm.com>
 230
 231         * aarch64-linux-nat.c
 232         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 233         * aarch64-linux-tdep.c
 234         (aarch64_linux_core_read_description): Likewise.
 235         (aarch64_linux_get_hwcap): New function.
 236         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 237         (aarch64_linux_get_hwcap): New declaration.
 238
 239 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 240             Jiong Wang  <jiong.wang@arm.com>
 241
 242         * aarch64-linux-nat.c
 243         (aarch64_linux_nat_target::read_description): Add pauth param.
 244         * aarch64-linux-tdep.c
 245         (aarch64_linux_core_read_description): Likewise.
 246         * aarch64-tdep.c (struct target_desc): Add in pauth.
 247         (aarch64_read_description): Add pauth param.
 248         (aarch64_gdbarch_init): Likewise.
 249         * aarch64-tdep.h (aarch64_read_description): Likewise.
 250         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 251         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 252         * features/Makefile: Add new files.
 253         * features/aarch64-pauth.c: New file.
 254         * features/aarch64-pauth.xml: New file.
 255
 256 2019-03-20  Tom Tromey  <tromey@adacore.com>
 257
 258         * infrun.c (handle_inferior_event): Rename from
 259         handle_inferior_event_1.  Create a scoped_value_mark.
 260         (handle_inferior_event): Remove.
 261
 262 2019-03-19  Tom Tromey  <tromey@adacore.com>
 263
 264         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 265         * infrun.h (print_stop_event): Add "displays" parameter.
 266         * infrun.c (print_stop_event): Add "displays" parameter.
 267
 268 2019-03-19  Pedro Alves  <palves@redhat.com>
 269
 270         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 271         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 272         to -1.  Fix TABs vs spaces.
 273         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 274         * tui/tui-out.h (tui_ui_out) Add intro comments.
 275         <m_line, m_start_of_line>: In-class initialize, and add describing
 276         comment.
 277
 278 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 279
 280         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 281         variable names.
 282         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 283
 284 2019-03-18  Pedro Alves  <palves@redhat.com>
 285             Eli Zaretskii <eliz@gnu.org>
 286
 287         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 288         m_line and m_start_of_line.
 289
 290 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 291
 292         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 293         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 294         it returns a newline.  This fixes a regression in TU mode, whereby
 295         the next line is output on the same screen line as the user input.
 296
 297 2019-03-18  Tom Tromey  <tromey@adacore.com>
 298
 299         * minsyms.c (minimal_symbol_reader::install): Remove call to
 300         obstack_blank.
 301
 302 2019-03-18  Pedro Alves  <palves@redhat.com>
 303
 304         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 305         New globals.
 306         (apply_style): New, factored out from ...
 307         (apply_ansi_escape): ... this.  Handle reverse video mode.
 308         (tui_set_reverse_mode): New function.
 309         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 310         * tui/tui-winsource.c (tui_show_source_line): Use
 311         tui_set_reverse_mode instead of setting A_STANDOUT.
 312         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 313         New setter methods.
 314
 315 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 316
 317         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 318         Handle tabs.
 319
 320 2019-03-18  Tom Tromey  <tromey@adacore.com>
 321
 322         * ada-lang.c (empty_array): Add "high" parameter.
 323         (ada_evaluate_subexp): Update.
 324
 325 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 326
 327         * unittests/string_view-selftests.c: Define
 328         _initialize_string_view_selftests unconditionally.
 329
 330 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 331
 332         PR gdb/24350
 333         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 334
 335 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 336
 337         PR gdb/24351
 338         * windows-nat.c (display_selector): Fix format specifiers.
 339
 340 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 341
 342         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 343         tui_refill_source_window instead of tui_refresh_win, to update the
 344         current execution line.  This fixes redisplay of the current line
 345         when stepping through the code with "next" or "step".
 346
 347 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 348
 349         * source-cache.c (source_cache::get_source_lines): Call
 350         find_source_lines to initialize s->nlines.  This fixes vertical
 351         scrolling of TUI source window when the DOWN arrow is pressed.
 352
 353 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 354
 355         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 356         linux-thread-db.c (_initialize_thread_db): Likewise.
 357
 358 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 359
 360         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 361         wclrtoeol in tui_show_source_line".  This reverts changes made in
 362         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 363
 364 2019-03-15  Tom Tromey  <tom@tromey.com>
 365
 366         * symtab.h (struct minimal_symbol): Derive from
 367         general_symbol_info.
 368         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 369         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 370         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 371         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 372         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 373         (MSYMBOL_SEARCH_NAME): Update.
 374         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 375         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 376         * minsyms.c (minimal_symbol_reader::record_full): Update.
 377
 378 2019-03-15  Tom Tromey  <tom@tromey.com>
 379
 380         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 381
 382 2019-03-15  Tom Tromey  <tom@tromey.com>
 383
 384         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 385         unique_xmalloc_ptr.
 386         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 387         Update.
 388         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 389         (build_minimal_symbol_hash_tables)
 390         (minimal_symbol_reader::install): Update.
 391
 392 2019-03-15  Tom Tromey  <tom@tromey.com>
 393
 394         * symtab.c (create_demangled_names_hash): Update.
 395         (symbol_set_names): Update.
 396         * objfiles.h (struct objfile_per_bfd_storage)
 397         <demangled_names_hash>: Now an htab_up.
 398         * objfiles.c (objfile_per_bfd_storage): Simplify.
 399
 400 2019-03-15  Tom Tromey  <tom@tromey.com>
 401
 402         * objfiles.h (struct objfile_per_bfd_storage): Declare
 403         destructor.
 404         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 405         New.
 406         (get_objfile_bfd_data): Use new.  Don't initialize
 407         language_of_main.
 408         (free_objfile_per_bfd_storage): Remove.
 409         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 410
 411 2019-03-15  Tom Tromey  <tom@tromey.com>
 412
 413         * symfile.c (reread_symbols): Update.
 414         * objfiles.c (objfile::objfile): Update.
 415         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 416         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 417         comment.
 418         (minimal_symbol_reader::install): Update.
 419         (terminate_minimal_symbol_table): Remove.
 420         * jit.c (jit_object_close_impl): Update.
 421
 422 2019-03-15  Tom Tromey  <tom@tromey.com>
 423
 424         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 425         initializations.
 426
 427 2019-03-15  Tom Tromey  <tom@tromey.com>
 428
 429         * objfiles.h (struct objfile_per_bfd_storage)
 430         <demangled_hash_languages>: Now a bitset.
 431         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 432         (lookup_minimal_symbol): Update.
 433
 434 2019-03-15  Tom Tromey  <tom@tromey.com>
 435
 436         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 437         Don't return the symbol.
 438         * coffread.c (record_minimal_symbol): Use record_full.
 439
 440 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 441
 442         The MS-Windows port of ncurses fails to switch to a color pair if
 443         one or both of the colors are the implicit default colors.  This
 444         change records the default colors when TUI is initialized, and
 445         then specifies them explicitly when a color pair uses the default
 446         colors.  This allows color styling in TUI mode on MS-Windows.
 447
 448         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 449         ncurses_norm_attr.
 450         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 451         colors in ncurses_norm_attr.
 452         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 453         "none", replace it with the default color recorded in
 454         ncurses_norm_attr.
 455
 456 2019-03-14  Tom Tromey  <tromey@adacore.com>
 457
 458         * source-cache.h (class source_cache) <get_source_lines>: Return
 459         std::string.
 460         * source-cache.c (source_cache::extract_lines): Handle case where
 461         first_pos==npos.  Return std::string.
 462         (source_cache::get_source_lines): Update.
 463
 464 2019-03-14  Tom Tromey  <tromey@adacore.com>
 465
 466         * NEWS: Add item for "style sources" commands.
 467         * source-cache.c (source_cache::get_source_lines): Check
 468         source_styling.
 469         * cli/cli-style.c (source_styling): New global.
 470         (_initialize_cli_style): Add "style sources" commands.
 471         (show_style_sources): New function.
 472         * cli/cli-style.h (source_styling): Declare.
 473
 474 2019-03-14  Pedro Alves  <palves@redhat.com>
 475             Tom Tromey  <tromey@adacore.com>
 476
 477         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 478         * tui/tui-winsource.c (tui_refill_source_window): New function,
 479         from...
 480         (tui_horizontal_source_scroll): ... here.  Move some logic.
 481         * cli/cli-style.c (set_style_enabled): Notify new observable.
 482         * tui/tui-hooks.c (tui_redisplay_source): New function.
 483         (tui_attach_detach_observers): Attach or detach
 484         tui_redisplay_source.
 485         * observable.h (source_styling_changed): New observable.
 486         * observable.c: Define source_styling_changed observable.
 487
 488 2019-03-13  Tom Tromey  <tromey@adacore.com>
 489
 490         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 491         (i386_gnu_nat_target::store_registers): Update.
 492         * target-debug.h (target_debug_print_std_string): New macro.
 493         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 494         * windows-tdep.c (display_one_tib): Update.
 495         * tui/tui-stack.c (tui_make_status_line): Update.
 496         * top.c (print_inferior_quit_action): Update.
 497         * thread.c (thr_try_catch_cmd): Update.
 498         (add_thread_with_info): Update.
 499         (thread_target_id_str): Update.
 500         (thr_try_catch_cmd): Update.
 501         (thread_command): Update.
 502         (thread_find_command): Update.
 503         * record-btrace.c (record_btrace_target::info_record)
 504         (record_btrace_resume_thread, record_btrace_target::resume)
 505         (record_btrace_cancel_resume, record_btrace_step_thread)
 506         (record_btrace_target::wait, record_btrace_target::wait)
 507         (record_btrace_target::wait, record_btrace_target::stop): Update.
 508         * progspace.c (print_program_space): Update.
 509         * process-stratum-target.c
 510         (process_stratum_target::thread_address_space): Update.
 511         * linux-fork.c (linux_fork_mourn_inferior)
 512         (detach_checkpoint_command, info_checkpoints_command)
 513         (linux_fork_context): Update.
 514         (linux_fork_detach): Update.
 515         (class scoped_switch_fork_info): Update.
 516         (delete_checkpoint_command): Update.
 517         * infrun.c (follow_fork_inferior): Update.
 518         (follow_fork_inferior): Update.
 519         (proceed_after_vfork_done): Update.
 520         (handle_vfork_child_exec_or_exit): Update.
 521         (follow_exec): Update.
 522         (displaced_step_prepare_throw): Update.
 523         (displaced_step_restore): Update.
 524         (start_step_over): Update.
 525         (resume_1): Update.
 526         (clear_proceed_status_thread): Update.
 527         (proceed): Update.
 528         (print_target_wait_results): Update.
 529         (do_target_wait): Update.
 530         (context_switch): Update.
 531         (stop_all_threads): Update.
 532         (restart_threads): Update.
 533         (finish_step_over): Update.
 534         (handle_signal_stop): Update.
 535         (switch_back_to_stepped_thread): Update.
 536         (keep_going_pass_signal): Update.
 537         (print_exited_reason): Update.
 538         (normal_stop): Update.
 539         * inferior.c (inferior_pid_to_str): Change return type.
 540         (print_selected_inferior): Update.
 541         (add_inferior): Update.
 542         (detach_inferior): Update.
 543         * dummy-frame.c (fprint_dummy_frames): Update.
 544         * dcache.c (dcache_info_1): Update.
 545         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 546         (btrace_fetch, btrace_clear): Update.
 547         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 548         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 549         type.
 550         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 551         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 552         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 553         * gdbarch.c, gdbarch.h: Rebuild.
 554         * gdbarch.sh (core_pid_to_str): Change return type.
 555         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 556         return type.
 557         (windows_nat_target::pid_to_str): Change return type.
 558         (windows_delete_thread): Update.
 559         (windows_nat_target::attach): Update.
 560         (windows_nat_target::files_info): Update.
 561         * target-delegates.c: Rebuild.
 562         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 563         return type.
 564         (sol_thread_target::pid_to_str): Change return type.
 565         * remote.c (class remote_target) <pid_to_str>: Change return
 566         type.
 567         (remote_target::pid_to_str): Change return type.
 568         (extended_remote_target::attach, remote_target::remote_stop_ns)
 569         (remote_target::remote_notif_remove_queued_reply)
 570         (remote_target::push_stop_reply, remote_target::disable_btrace):
 571         Update.
 572         (extended_remote_target::attach): Update.
 573         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 574         type.
 575         (gdbsim_target::pid_to_str): Change return type.
 576         * ravenscar-thread.c (struct ravenscar_thread_target)
 577         <pid_to_str>: Change return type.
 578         (ravenscar_thread_target::pid_to_str): Change return type.
 579         * procfs.c (class procfs_target) <pid_to_str>: Change return
 580         type.
 581         (procfs_target::pid_to_str): Change return type.
 582         (procfs_target::attach): Update.
 583         (procfs_target::detach): Update.
 584         (procfs_target::fetch_registers): Update.
 585         (procfs_target::store_registers): Update.
 586         (procfs_target::wait): Update.
 587         (procfs_target::files_info): Update.
 588         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 589         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 590         return type.
 591         (nto_procfs_target::pid_to_str): Change return type.
 592         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 593         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 594         return type.
 595         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 596         (exit_lwp): Update.
 597         (attach_proc_task_lwp_callback, get_detach_signal)
 598         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 599         (linux_nat_target::resume, wait_lwp, stop_callback)
 600         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 601         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 602         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 603         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 604         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 605         type.
 606         (inf_ptrace_target::attach): Update.
 607         (inf_ptrace_target::files_info): Update.
 608         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 609         type.
 610         (go32_nat_target::pid_to_str): Change return type.
 611         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 612         (gnu_nat_target::wait): Update.
 613         (gnu_nat_target::wait): Update.
 614         (gnu_nat_target::resume): Update.
 615         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 616         (fbsd_nat_target::wait): Update.
 617         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 618         type.
 619         (darwin_nat_target::attach): Update.
 620         * corelow.c (class core_target) <pid_to_str>: Change return type.
 621         (core_target::pid_to_str): Change return type.
 622         * target.c (normal_pid_to_str): Change return type.
 623         (default_pid_to_str): Likewise.
 624         (target_pid_to_str): Change return type.
 625         (target_translate_tls_address): Update.
 626         (target_announce_detach): Update.
 627         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 628         return type.
 629         (bsd_uthread_target::pid_to_str): Change return type.
 630         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 631         type.
 632         (bsd_kvm_target::pid_to_str): Change return type.
 633         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 634         return type.
 635         (aix_thread_target::pid_to_str): Change return type.
 636         * target.h (struct target_ops) <pid_to_str>: Change return type.
 637         (target_pid_to_str, normal_pid_to_str): Likewise.
 638         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 639         type.
 640         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 641         type.
 642         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 643         return type.
 644         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 645         type.
 646         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 647         type.
 648         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 649         return type.
 650
 651 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 652
 653         * NEWS: Mention that the new default MI version is 3.  Mention
 654         changes to the output of commands and events that deal with
 655         multi-location breakpoints.
 656         * breakpoint.c: Include "mi/mi-out.h".
 657         (print_one_breakpoint): Change output syntax if using MI version
 658         >= 3.
 659         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 660         New.
 661         (mi_multi_location_breakpoint_output_fixed): New.
 662         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 663         (mi_cmd_fix_multi_location_breakpoint_output): New.
 664         (mi_multi_location_breakpoint_output_fixed): New.
 665         * mi/mi-cmds.c (mi_cmds): Register command
 666         -fix-multi-location-breakpoint-output.
 667         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 668         interpreter "mi".
 669
 670 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 671
 672         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 673         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 674         instantiate mi_ui_out based on interpreter name.
 675         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 676         * mi/mi-main.c (mi_load_progress): Likewise.
 677
 678 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 679
 680         * NEWS: Combine separate "New targets" sections for 8.3.
 681
 682 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 683
 684         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 685         (ppcfbsd_init_abi): Install gdbarch
 686         "fetch_tls_load_module_address" and "get_thread_local_address"
 687         methods.
 688
 689 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 690
 691         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 692         (riscv_fbsd_init_abi): Install gdbarch
 693         "fetch_tls_load_module_address" and "get_thread_local_address"
 694         methods.
 695
 696 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 697
 698         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 699         (i386fbsd_init_abi): Install gdbarch
 700         "fetch_tls_load_module_address" and "get_thread_local_address"
 701         methods.
 702
 703 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 704
 705         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 706         (amd64fbsd_init_abi): Install gdbarch
 707         "fetch_tls_load_module_address" and "get_thread_local_address"
 708         methods.
 709
 710 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 711
 712         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 713         (struct fbsd_pspace_data): New type.
 714         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 715         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 716         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 717         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 718         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 719
 720 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 721
 722         * gdbtypes.c (lookup_struct_elt): New function.
 723         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 724         * gdbtypes.h (struct struct_elt): New type.
 725         (lookup_struct_elt): New prototype.
 726
 727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 728
 729         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 730         remove disabled code block.
 731
 732 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 733
 734         * gdbarch.sh (get_thread_local_address): New method.
 735         * gdbarch.h, gdbarch.c: Regenerate.
 736         * target.c (target_translate_tls_address): Use
 737         gdbarch_get_thread_local_address if present instead of
 738         target::get_thread_local_address.
 739
 740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 741
 742         * target.h (target::get_thread_local_address): Update comment.
 743
 744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 745
 746         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 747         objfile->separate_debug_objfile_backlink if not NULL.
 748
 749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 750
 751         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 752         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 753         (amd64bsd_store_inferior_registers): Likewise.
 754         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 755         Enable segment base registers.
 756         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 757         PT_GETFSBASE and PT_GETGSBASE.
 758         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 759         PT_SETGSBASE.
 760         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 761         segment base registers.
 762         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 763
 764 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 765
 766         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 767         Update calls to i386_target_description to add 'segments'
 768         parameter.
 769         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 770         add segment base registers.
 771         * arch/i386.c (i386_create_target_description): Add 'segments'
 772         parameter to enable segment base registers.
 773         * arch/i386.h (i386_create_target_description): Likewise.
 774         * features/i386/32bit-segments.xml: New file.
 775         * features/i386/32bit-segments.c: Generate.
 776         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 777         call to i386_target_description to add 'segments' parameter.
 778         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 779         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 780         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 781         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 782         if feature is present.
 783         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 784         Add 'segments' parameter to call to i386_target_description.
 785         (i386_target_description): Add 'segments' parameter to enable
 786         segment base registers.
 787         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 788         to call to i386_target_description.
 789         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 790         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 791         Define I386_NUM_REGS.
 792         (i386_target_description): Add 'segments' parameter to enable
 793         segment base registers.
 794
 795 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 796
 797         PR/24325
 798         * source-cache.c: #undef open and close, to avoid unresolved
 799         externals during linking.
 800
 801 2019-03-12  Tom Tromey  <tromey@adacore.com>
 802
 803         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 804         const.  Add initializers.
 805         (_initialize_remote): Don't initialize ptid globals.
 806
 807 2019-03-12  Pedro Alves  <palves@redhat.com>
 808
 809         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 810
 811 2019-03-12  Pedro Alves  <palves@redhat.com>
 812
 813         * cp-name-parser.y (main): Remove unused 'len' variable.
 814
 815 2019-03-12  Tom Tromey  <tromey@adacore.com>
 816
 817         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 818         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 819
 820 2019-03-12  Tom Tromey  <tromey@adacore.com>
 821
 822         * linux-nat.c (iterate_over_lwps): Update.
 823         (stop_callback): Remove parameter.
 824         (stop_wait_callback, detach_callback, resume_set_callback)
 825         (select_singlestep_lwp_callback, set_ignore_sigint)
 826         (status_callback, resumed_callback, resume_clear_callback)
 827         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 828         data parameter.
 829         (linux_nat_target::detach, linux_nat_target::resume)
 830         (linux_stop_and_wait_all_lwps, select_event_lwp)
 831         (linux_nat_filter_event, linux_nat_wait_1)
 832         (linux_nat_target::kill, linux_nat_target::stop)
 833         (linux_nat_target::stop): Update.
 834         (linux_nat_resume_callback): Change type.
 835         (resume_stopped_resumed_lwps, count_events_callback)
 836         (select_event_lwp_callback): Likewise.
 837         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 838         * arm-linux-nat.c (struct update_registers_data): Remove.
 839         (update_registers_callback): Change type.
 840         (arm_linux_insert_hw_breakpoint1): Update.
 841         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 842         parameter.
 843         (x86_linux_dr_set_addr): Update.
 844         (x86_linux_dr_set_control): Update.
 845         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 846         (iterate_over_lwps): Use gdb::function_view.
 847         * nat/aarch64-linux-hw-point.c (struct
 848         aarch64_dr_update_callback_param): Remove.
 849         (debug_reg_change_callback): Change type.
 850         (aarch64_notify_debug_reg_change): Update.
 851         * s390-linux-nat.c (s390_refresh_per_info): Update.
 852
 853 2019-03-11  Tom Tromey  <tromey@adacore.com>
 854
 855         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 856         redundant assignment to "this_cu".
 857
 858 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 859
 860         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 861
 862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 863
 864         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 865         from...
 866         (rank_one_type): ... this.
 867
 868 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 869
 870         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 871         from...
 872         (rank_one_type): ... this.
 873
 874 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 875
 876         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 877         from...
 878         (rank_one_type): ... this.
 879
 880 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 881
 882         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 883         from...
 884         (rank_one_type): ... this.
 885
 886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 887
 888         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 889         from...
 890         (rank_one_type): ... this.
 891
 892 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 893
 894         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 895         from...
 896         (rank_one_type): ... this.
 897
 898 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 899
 900         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 901         from...
 902         (rank_one_type): ... this.
 903
 904 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 905
 906         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 907         from...
 908         (rank_one_type): ... this.
 909
 910 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 911
 912         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 913         from...
 914         (rank_one_type): ... this.
 915
 916 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 917
 918         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 919         from...
 920         (rank_one_type): ... this.
 921
 922 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 923
 924         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 925         from...
 926         (rank_one_type): ... this.
 927
 928 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 929
 930         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 931         from...
 932         (rank_one_type): ... this.
 933
 934 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 935
 936         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 937         inferior-events' shows the example events.
 938
 939 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 940
 941         Support styling on native MS-Windows console
 942
 943         PR/24315
 944         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 945         on MS-Windows if $TERM is not defined.
 946
 947         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 948
 949         * posix-hdep.c (gdb_console_fputs):
 950         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 951         functions.
 952         * ui-file.h (gdb_console_fputs): Add prototype.
 953
 954         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 955         back to fputs only if the former returns zero.
 956
 957 2019-03-07  Tom Tromey  <tom@tromey.com>
 958
 959         * symmisc.c (print_symbol_bcache_statistics): Update.
 960         (print_objfile_statistics): Update.
 961         * symfile.c (allocate_symtab): Update.
 962         * stabsread.c: Don't include bcache.h.
 963         * psymtab.h (struct psymbol_bcache): Don't declare.
 964         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 965         (psymbol_bcache_init, psymbol_bcache_free)
 966         (psymbol_bcache_get_bcache): Don't declare.
 967         * psymtab.c (struct psymbol_bcache): Remove.
 968         (psymtab_storage::psymtab_storage): Update.
 969         (psymtab_storage::~psymtab_storage): Update.
 970         (psymbol_bcache_init, psymbol_bcache_free)
 971         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 972         (add_psymbol_to_bcache): Update.
 973         (allocate_psymtab): Update.
 974         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 975         macro_cache>: No longer pointers.
 976         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 977         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 978         * macrotab.c (macro_bcache): Update.
 979         * macroexp.c: Don't include bcache.h.
 980         * gdbtypes.c (check_types_worklist): Update.
 981         (types_deeply_equal): Remove TRY/CATCH.  Update.
 982         * elfread.c (elf_symtab_read): Update.
 983         * dwarf2read.c: Don't include bcache.h.
 984         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 985         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 986         (print_bcache_statistics, bcache_memory_used): Don't declare.
 987         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 988         methods.  Rename all data members.
 989         * bcache.c (struct bcache): Move to bcache.h.
 990         (bcache::expand_hash_table): Rename from expand_hash_table.
 991         (bcache): Remove.
 992         (bcache::insert): Rename from bcache_full.
 993         (bcache::compare): Rename from bcache_compare.
 994         (bcache_xmalloc): Remove.
 995         (bcache::~bcache): Rename from bcache_xfree.
 996         (bcache::print_statistics): Rename from print_bcache_statistics.
 997         (bcache::memory_used): Rename from bcache_memory_used.
 998
 999 2019-03-07  Pedro Alves  <palves@redhat.com>
1000
1001         * infrun.c (normal_stop): Also check for
1002         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1003
1004 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1005
1006         * f-lang.c (value_from_host_double): Moved to...
1007         * value.c (value_from_host_double): ...here.
1008         * value.h (value_from_host_double): Declare.
1009         * guile/scm-math.c (vlscm_convert_typed_number): Use
1010         value_from_host_double.
1011         (vlscm_convert_number): Likewise.
1012         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1013         * python/py-value.c (convert_value_from_python): Likewise.
1014
1015 2019-03-06  Tom Tromey  <tom@tromey.com>
1016
1017         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1018
1019 2019-03-06  Tom Tromey  <tom@tromey.com>
1020
1021         * utils.h (free_current_contents): Don't declare.
1022         * utils.c (free_current_contents): Remove.
1023
1024 2019-03-06  Tom Tromey  <tom@tromey.com>
1025
1026         * top.c (quit_force): Update.
1027         * main.c (captured_command_loop): Update.
1028         * common/new-op.c (operator new): Update.
1029         * common/common-exceptions.c (struct catcher)
1030         <save_cleanup_chain>: Remove member.
1031         (exceptions_state_mc_init): Update.
1032         (exception_try_scope_entry): Return nullptr.
1033         (exception_try_scope_exit, exception_rethrow)
1034         (throw_exception_sjlj, throw_exception_cxx): Update.
1035         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1036         (all_cleanups, do_cleanups, discard_cleanups)
1037         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1038         (restore_cleanups, restore_final_cleanups): Don't declare.
1039         (do_final_cleanups): Remove parameter.
1040         * common/cleanups.c (cleanup_chain, make_cleanup)
1041         (make_cleanup_dtor, all_cleanups, do_cleanups)
1042         (discard_my_cleanups, discard_cleanups)
1043         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1044         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1045         (null_cleanup): Remove.
1046         (do_final_cleanups): Remove parameter.
1047
1048 2019-03-06  Tom Tromey  <tom@tromey.com>
1049
1050         * remote.c (remote_target::remote_parse_stop_reply): Use
1051         unique_xmalloc_ptr.
1052
1053 2019-03-06  Tom Tromey  <tom@tromey.com>
1054
1055         * stabsread.c (struct stabs_field_info): Rename from field_info.
1056         <list, fnlist>: Add initializers.
1057         <obstack>: New member.
1058         (read_member_functions, read_struct_fields, read_baseclasses):
1059         Allocate on obstack.  Don't use cleanups.
1060         (read_one_struct_field, read_member_functions, read_struct_fields)
1061         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1062         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1063         (read_struct_type): Update.
1064
1065 2019-03-06  Tom Tromey  <tom@tromey.com>
1066
1067         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1068         * common/filestuff.h (make_cleanup_close): Don't declare.
1069         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1070         Remove.
1071
1072 2019-03-06  Tom Tromey  <tom@tromey.com>
1073
1074         * solib-aix.c: Use make_scope_exit.
1075
1076 2019-03-06  Tom Tromey  <tom@tromey.com>
1077
1078         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1079         Use make_scope_exit.
1080
1081 2019-03-06  Tom Tromey  <tom@tromey.com>
1082
1083         * solib-svr4.c (disable_probes_interface): Remove parameter.
1084         (svr4_handle_solib_event): Use make_scope_exit.
1085
1086 2019-03-06  Tom Tromey  <tom@tromey.com>
1087
1088         * remote.c (struct stop_reply_deleter): Remove.
1089         (stop_reply_up): Update.
1090         (struct stop_reply): Derive from notif_event.  Don't typedef.
1091         <regcache>: Now a std::vector.
1092         (stop_reply_xfree): Remove.
1093         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1094         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1095         (remote_target::discard_pending_stop_replies): Use delete.
1096         (remote_target::remote_parse_stop_reply): Update.
1097         (remote_target::process_stop_reply): Update.
1098         * remote-notif.h (struct notif_event): Add virtual destructor.
1099         Remove "dtr" member.
1100         (struct notif_client) <alloc_event>: Return a unique_ptr.
1101         (notif_event_xfree): Don't declare.
1102         (notif_event_up): New typedef.
1103         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1104         (notif_event_xfree, do_notif_event_xfree): Remove.
1105         (remote_notif_state_xfree): Update.
1106
1107 2019-03-06  Tom Tromey  <tom@tromey.com>
1108
1109         * infrun.c (displaced_step_clear_cleanup): Now a
1110         forward_scope_exit type.
1111         (displaced_step_prepare_throw): Update.
1112         (displaced_step_fixup): Update.
1113
1114 2019-03-06  Tom Tromey  <tom@tromey.com>
1115
1116         * inferior.h (class inferior): Update comment.
1117         * gdbthread.h (class thread_info): Update comment.
1118
1119 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1120             Tom Tromey  <tom@tromey.com>
1121
1122         * stabsread.h (struct stab_section_list): Remove.
1123         (coffstab_build_psymtabs): Update.
1124         * dbxread.c (symbuf_sections): Now a std::vector.
1125         (sect_idx): New global.
1126         (fill_symbuf): Update.
1127         (coffstab_build_psymtabs): Change type of stabsects parameter.
1128         Update.
1129         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1130         std::vector.
1131         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1132         (coff_locate_sections): Update.
1133         (coff_symfile_read): Remove cleanups.  Update.
1134         (init_stringtab): Add storage parameter.
1135         (free_stringtab, free_stringtab_cleanup): Remove.
1136         (init_lineno): Add storage parameter.
1137         (free_linetab, free_linetab_cleanup): Remove.
1138
1139 2019-03-06  Pedro Alves  <palves@redhat.com>
1140
1141         * linux-fork.c (fork_info::clobber_regs): Delete.
1142         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1143         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1144         comment.  Adjust.
1145         (scoped_switch_fork_info::scoped_switch_fork_info)
1146         (checkpoint_command, linux_fork_context): Adjust
1147         fork_save_infrun_state calls.
1148
1149 2019-03-06  Pedro Alves  <palves@redhat.com>
1150
1151         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1152         (inf_has_multiple_threads): Return 'bool' and rewrite using
1153         inferior_info::threads().
1154
1155 2019-03-06  Pedro Alves  <palves@redhat.com>
1156
1157         * linux-fork.c: Include <list>.
1158         (fork_list): Now a std::list instance.
1159         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1160         (forks_exist_p, find_last_fork): Adjust.
1161         (new_fork): Delete.
1162         (one_fork_p): New.
1163         (add_fork): Adjust.
1164         (free_fork): Delete, folded into fork_info::~fork_info().
1165         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1166         Adjust.
1167         (init_fork_list): Delete.
1168         (linux_fork_killall, linux_fork_mourn_inferior)
1169         (linux_fork_detach, info_checkpoints_command): Adjust.
1170         (_initialize_linux_fork): No longer call init_fork_list.
1171
1172 2019-03-06  Pedro Alves  <palves@redhat.com>
1173
1174         * linux-fork.c (new_fork): New, split out of ...
1175         (add_fork): ... this.  Return void.  Move "first fork" special
1176         case from here, to ...
1177         (checkpoint_command): ... here.
1178         * linux-linux.h (add_fork): Return void.
1179
1180 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1181
1182         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1183
1184 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1185             Chris January  <chris.january@arm.com>
1186             David Lecomber  <david.lecomber@arm.com>
1187
1188         * f-exp.y: New token, UNOP_INTRINSIC.
1189         (exp): New pattern using UNOP_INTRINSIC token.
1190         (f77_keywords): Add 'abs' keyword.
1191         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1192         (value_from_host_double): New function.
1193         (evaluate_subexp_f): Support UNOP_ABS.
1194
1195 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1196
1197         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1198         types.
1199
1200 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1201
1202         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1203         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1204         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1205
1206 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1207
1208         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1209
1210 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1211             Chris January  <chris.january@arm.com>
1212
1213         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1214         * f-exp.y: Define 'KIND' token.
1215         (exp): New pattern for KIND expressions.
1216         (ptype): Handle types with a kind extension.
1217         (direct_abs_decl): Extend to spot kind extensions.
1218         (f77_keywords): Add 'kind' to the list.
1219         (push_kind_type): New function.
1220         (convert_to_kind_type): New function.
1221         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1222         * parse.c (operator_length_standard): Likewise.
1223         * parser-defs.h (enum type_pieces): Add tp_kind.
1224         * std-operator.def: Add UNOP_KIND.
1225
1226 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * f-exp.y (f_parse): Set yydebug.
1229
1230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1231
1232         * f-lang.c (evaluate_subexp_f): New function.
1233         (exp_descriptor_f): New global.
1234         (f_language_defn): Use exp_descriptor_f instead of
1235         exp_descriptor_standard.
1236
1237 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1238
1239         * f-exp.y (struct token): Add comments.
1240         (dot_ops): Remove uppercase versions and the end marker.
1241         (f77_keywords): Likewise.
1242         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1243         entries in the dot_ops array are case insensitive, and use
1244         strncasecmp to compare strings.  Also some whitespace cleanup in
1245         this area.  Similar for the f77_keywords array, except entries in
1246         this list might be case sensitive.
1247
1248 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1249
1250         * f-exp.y (struct f77_boolean_val): Add comments.
1251         (boolean_values): Remove uppercase versions, and end marker.
1252         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1253         and use strncasecmp to achieve case insensitivity.  Additionally,
1254         perform whitespace cleanup around this code.
1255
1256 2019-03-06  Tom Tromey  <tromey@adacore.com>
1257
1258         * remote-sim.c (gdbsim_target_open): Use result of
1259         gdb_argv::release.
1260
1261 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1262         Dirk Schubert  <dirk.schubert@arm.com>
1263         Chris January  <chris.january@arm.com>
1264
1265         * eval.c (evaluate_subexp_standard): Call Fortran argument
1266         wrapping logic.
1267         * f-lang.c (struct value): A value which can be passed into a
1268         Fortran function call.
1269         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1270         where appropriate.
1271         (struct type): Value ready for a Fortran function call.
1272         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1273         is needed.
1274         * f-lang.h (fortran_argument_convert): Declaration.
1275         (fortran_preserve_arg_pointer): Declaration.
1276         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1277
1278 2019-03-05  Tom Tromey  <tromey@adacore.com>
1279
1280         * python/py-prettyprint.c (print_string_repr): Remove #if.
1281         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1282
1283 2019-03-05  Tom Tromey  <tromey@adacore.com>
1284
1285         * target.c (the_dummy_target): Move later.  Change type to
1286         "dummy_target".
1287         (initialize_targets): Don't initialize the_dummy_target.
1288
1289 2019-03-05  Tom Tromey  <tromey@adacore.com>
1290
1291         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1292         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1293
1294 2019-03-05  Tom Tromey  <tromey@adacore.com>
1295
1296         * windows-nat.c (windows_nat_target::attach)
1297         (windows_nat_target::detach): Don't call gdb_flush.
1298         * valprint.c (generic_val_print, val_print, val_print_string):
1299         Don't call gdb_flush.
1300         * utils.c (defaulted_query): Don't call gdb_flush.
1301         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1302         * target.c (target_announce_detach): Don't call gdb_flush.
1303         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1304         * remote.c (extended_remote_target::attach): Don't call
1305         gdb_flush.
1306         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1307         * printcmd.c (do_examine): Don't call gdb_flush.
1308         (info_display_command): Don't call gdb_flush.
1309         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1310         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1311         * memattr.c (info_mem_command): Don't call gdb_flush.
1312         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1313         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1314         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1315         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1316         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1317         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1318         (gnu_nat_target::detach): Don't call gdb_flush.
1319         * f-valprint.c (f_val_print): Don't call gdb_flush.
1320         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1321         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1322         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1323         gdb_flush.
1324         * c-valprint.c (c_val_print): Don't call gdb_flush.
1325         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1326
1327 2019-03-05  Tom Tromey  <tromey@adacore.com>
1328
1329         * varobj.c (update_dynamic_varobj_children): Update.
1330         (install_default_visualizer): Use reset, not release.
1331         * value.c (set_internalvar): Update.
1332         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1333         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1334         ATTRIBUTE_UNUSED_RESULT.
1335
1336 2019-03-05  Tom Tromey  <tromey@adacore.com>
1337
1338         * remote.c (class scoped_remote_fd) <release>: Add
1339         ATTRIBUTE_UNUSED_RESULT.
1340
1341 2019-03-05  Tom Tromey  <tromey@adacore.com>
1342
1343         * macroexp.c (struct macro_buffer) <release>: Add
1344         ATTRIBUTE_UNUSED_RESULT.
1345
1346 2019-03-05  Tom Tromey  <tromey@adacore.com>
1347
1348         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1349         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1350         ATTRIBUTE_UNUSED_RESULT.
1351
1352 2019-03-05  Tom Tromey  <tromey@adacore.com>
1353
1354         * common/scoped_fd.h (class scoped_fd) <release>: Add
1355         ATTRIBUTE_UNUSED_RESULT.
1356
1357 2019-03-05  Tom Tromey  <tromey@adacore.com>
1358
1359         * parser-defs.h (struct parser_state) <release>: Add
1360         ATTRIBUTE_UNUSED_RESULT.
1361
1362 2019-03-05  Tom Tromey  <tromey@adacore.com>
1363
1364         * utils.h (class gdb_argv) <release>: Add
1365         ATTRIBUTE_UNUSED_RESULT.
1366         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1367
1368 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1369
1370         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1371         for-loop range, to avoid compiler warnings.
1372
1373         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1374         avoid compiler warnings about unused variables.
1375
1376         * NEWS: Mention end of support for native debugging on MS-Windows
1377         before XP.
1378
1379         PR gdb/24292
1380         * common/netstuff.c:
1381         * gdbserver/gdbreplay.c
1382         * gdbserver/remote-utils.c:
1383         * ser-tcp.c:
1384         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1385         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1386         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1387         'getaddrinfo' and 'freeaddrinfo' were not available before
1388         Windows XP, and mingw.org's MinGW headers by default define
1389         _WIN32_WINNT to 0x500.
1390
1391 2019-03-01  Gary Benson <gbenson@redhat.com>
1392
1393         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1394
1395 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1396             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1397
1398         PR gdb/8527
1399         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1400         set_sigint_trap, clear_sigint_trap.
1401
1402 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1403
1404         * target.c (target_detach): Clear the regcache and the
1405         frame cache.
1406
1407 2019-02-27  Pedro Alves  <palves@redhat.com>
1408
1409         * utils.c (set_screen_size): When we cap the height/width sizes,
1410         tweak the corresponding command variable to show "unlimited":
1411
1412 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1413             Pedro Alves  <palves@redhat.com>
1414
1415         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1416         before calling rl_set_screen_size.
1417
1418 2019-02-27  Tom Tromey  <tromey@adacore.com>
1419
1420         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1421         define.
1422         * python/py-value.c: Remove Python 2.4 workaround.
1423         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1424         workaround.
1425         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1426         Python 2.4 workaround.
1427         * python/python-internal.h: Remove Python 2.4 comment.
1428         (Py_ssize_t): Don't define.
1429         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1430         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1431         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1432         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1433         * python/python.c (do_start_initialization): Remove Python 2.4
1434         workaround.
1435         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1436         (print_children): Remove Python 2.4 workaround.
1437         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1438         workaround.
1439         (CHARBUFFERPROC_NAME): Remove.
1440         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1441         Python 2.4 workaround.
1442
1443 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1444
1445         * NEWS: Note minimum Python version.
1446
1447 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1448
1449         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1450         code from these functions.  Remove corresponding ifdefs.  Use
1451         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1452         Remove gotos and target of gotos.
1453         (infpy_search_memory): Likewise.
1454
1455 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1456
1457         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1458         (hppa_gdbarch_init): Don't register deleted functions with
1459         gdbarch.
1460
1461 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1462
1463         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1464         (h8300_unwind_sp): Delete.
1465         (h8300_dummy_id): Delete.
1466         (h8300_gdbarch_init): Don't register deleted functions with
1467         gdbarch.
1468
1469 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1470
1471         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1472         (ft32_unwind_pc): Delete.
1473         (ft32_unwind_sp): Delete.
1474         (ft32_gdbarch_init): Don't register deleted functions with
1475         gdbarch.
1476
1477 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1478
1479         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1480         (frv_unwind_pc): Delete.
1481         (frv_unwind_sp): Delete.
1482         (frv_gdbarch_init): Don't register deleted functions with
1483         gdbarch.
1484
1485 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1486
1487         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1488         (riscv_unwind_pc): Delete.
1489         (riscv_unwind_sp): Delete.
1490         (riscv_gdbarch_init): Don't register deleted functions with
1491         gdbarch.
1492
1493 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1494
1495         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1496         (csky_unwind_pc): Delete.
1497         (csky_unwind_sp): Delete.
1498         (csky_gdbarch_init): Don't register deleted functions with
1499         gdbarch.
1500
1501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1502
1503         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1504         (cris_unwind_pc): Delete.
1505         (cris_unwind_sp): Delete.
1506         (cris_gdbarch_init): Don't register deleted functions with
1507         gdbarch.
1508
1509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1510
1511         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1512         (bfin_unwind_pc): Delete.
1513         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1514
1515 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1516
1517         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1518         (arm_unwind_pc): Delete.
1519         (arm_unwind_sp): Delete.
1520         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1521
1522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1523
1524         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1525         (arc_unwind_pc): Delete.
1526         (arc_unwind_sp): Delete.
1527         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1528
1529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1530
1531         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1532         (alpha_unwind_pc): Delete.
1533         (alpha_gdbarch_init): Don't register deleted functions with
1534         gdbarch.
1535
1536 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1537
1538         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1539         (aarch64_unwind_pc): Delete.
1540         (aarch64_unwind_sp): Delete.
1541         (aarch64_gdbarch_init): Don't register deleted functions with
1542         gdbarch.
1543
1544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1545
1546         * gdbtypes.c (type_align): Don't consider static members when
1547         computing structure alignment.
1548
1549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1550
1551         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1552         return 0 for other types.
1553         * arch-utils.c (default_type_align): Always return 0.
1554         * gdbarch.h: Regenerate.
1555         * gdbarch.sh (type_align): Extend comment.
1556         * gdbtypes.c (type_align): Add additional comments, always call
1557         gdbarch_type_align before applying the default rules.
1558         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1559         generic code will then apply a suitable default.
1560         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1561         types, return 0 for other types.
1562
1563 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1564
1565         * NEWS: Create a new section for the next release branch.
1566         Rename the section of the current branch, now that it has
1567         been cut.
1568
1569 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1570
1571         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1572         * version.in: Bump version to 8.3.50.DATE-git.
1573
1574 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1575
1576         * aix-thread.c (ptid_cmp): Remove unused variable.
1577         (get_signaled_thread): Likewise.
1578         (store_regs_user_thread): Likewise.
1579         (store_regs_kernel_thread): Likewise.
1580         (fetch_regs_kernel_thread): Remove shadowed variable.
1581
1582 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1583
1584         * features/riscv/32bit-cpu.xml: Add register numbers.
1585         * features/riscv/32bit-fpu.c: Regenerate.
1586         * features/riscv/32bit-fpu.xml: Add register numbers.
1587         * features/riscv/64bit-cpu.xml: Add register numbers.
1588         * features/riscv/64bit-fpu.c: Regenerate.
1589         * features/riscv/64bit-fpu.xml: Add register numbers.
1590
1591 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1592
1593         * NEWS: Mention two argument form of gdb.Value constructor.
1594         * python/py-value.c (convert_buffer_and_type_to_value): New
1595         function.
1596         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1597         Add support for handling an optional second argument.  Call
1598         convert_buffer_and_type_to_value as appropriate.
1599         * python/python-internal.h (Py_buffer_deleter): New struct.
1600         (Py_buffer_up): New typedef.
1601
1602 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1603
1604         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1605         instead of releasing ownership.
1606
1607 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1608
1609         * dwarf2read.c (open_and_init_dwp_file): Call
1610         elf_numsections instead of bfd_count_sections to initialize
1611         dwp_file->num_sections.
1612
1613 2019-02-25  Tom Tromey  <tromey@adacore.com>
1614
1615         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1616
1617 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1618
1619         * gcore.in: Add '--readnever' option when invoking GDB.
1620
1621 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1622
1623         * MAINTAINERS: Update my email address.
1624
1625 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1626
1627         * build-id.c (build_id_to_debug_bfd_1): New function.
1628         (build_id_to_debug_bfd): Look for separate debug file in
1629         sysroot.
1630
1631 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1632
1633         * gdbarch.sh: Update the copyright year range that is placed into
1634         generated files.
1635
1636 2019-02-22  Keith Seitz  <keiths@redhat.com>
1637
1638         PR symtab/23853
1639         * linespec.c (create_sals_line_offset): Search for the default
1640         symtab's filename instead of its fullname.
1641
1642 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1643
1644         * NEWS: Update style defaults.
1645
1646 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1647
1648         * main.c (captured_main_1): Disable styling in batch mode.
1649
1650 2019-02-20  Tom Tromey  <tom@tromey.com>
1651
1652         * symtab.c (symtab_symbol_info): Fix typos.
1653
1654 2019-02-20  Tom Tromey  <tromey@adacore.com>
1655
1656         * findcmd.c (_initialize_mem_search): Use upper case for
1657         metasyntactic variables.
1658
1659 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1660
1661         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1662         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1663
1664 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1665
1666         * top.h (source_file_name): Change to std::string.
1667         * top.c (source_file_name): Likewise.
1668         (command_line_input): Adjust.
1669         * cli/cli-script.c (script_from_file): Adjust.
1670
1671 2019-02-19  Tom Tromey  <tromey@adacore.com>
1672
1673         * ravenscar-thread.c
1674         (ravenscar_thread_target::update_thread_list): Don't call
1675         ada_build_task_list.
1676         * ada-lang.h (ada_build_task_list): Don't declare.
1677         * ada-tasks.c (struct ada_tasks_inferior_data)
1678         <task_list_valid_p>: Now bool.
1679         (read_known_tasks, ada_task_list_changed)
1680         (ada_tasks_invalidate_inferior_data): Update.
1681         (read_known_tasks_array): Return bool.
1682         (read_known_tasks_list): Likewise.
1683         (read_known_tasks): Return void.
1684         (ada_build_task_list): Now static.
1685
1686 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1687
1688         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1689         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1690
1691 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1692
1693         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1694         variant for ada_tasks_pspace_data_handle and
1695         ada_tasks_inferior_data_handle.
1696         (ada_tasks_pspace_data_cleanup): New function.
1697         (ada_tasks_inferior_data_cleanup): New function.
1698
1699 2019-02-17  Tom Tromey  <tom@tromey.com>
1700
1701         * macrotab.h (macro_source_fullname): Return a std::string.
1702         * macrotab.c (macro_include, check_for_redefinition)
1703         (macro_undef, macro_lookup_definition, foreach_macro)
1704         (foreach_macro_in_scope): Update.
1705         (macro_source_fullname): Return a std::string.
1706         * macrocmd.c (show_pp_source_pos): Update.
1707
1708 2019-02-17  Tom Tromey  <tom@tromey.com>
1709
1710         * macrocmd.c (show_pp_source_pos): Style the file names.
1711
1712 2019-02-17  Tom Tromey  <tom@tromey.com>
1713
1714         PR tui/24197:
1715         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1716
1717 2019-02-17  Tom Tromey  <tom@tromey.com>
1718
1719         * ada-lang.c (user_select_syms): Use filtered printing.
1720         * utils.c (wrap_style): New global.
1721         (desired_style): Remove.
1722         (emit_style_escape): Add stream parameter.
1723         (set_output_style, reset_terminal_style, prompt_for_continue):
1724         Update.
1725         (flush_wrap_buffer): Only flush gdb_stdout.
1726         (wrap_here): Set wrap_style.
1727         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1728         treat escape sequences as a character.  Change when wrap buffer is
1729         flushed.
1730         (fputs_styled): Do not set the output style when the default is
1731         requested.
1732         * ui-style.h (struct ui_file_style) <is_default>: New method.
1733         * source.c (print_source_lines_base): Emit escape sequences in one
1734         piece.
1735
1736 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1737
1738         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1739         integers and enumeration types.
1740
1741 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1742
1743         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1744         instead of lookup_symbol_in_language
1745         (do_exact_match): New function.
1746         (ada_get_symbol_name_matcher): Return do_exact_match when
1747         doing a verbatim match.
1748
1749 2019-02-15  Tom Tromey  <tromey@adacore.com>
1750
1751         * ravenscar-thread.c (ravenscar_thread_target::resume)
1752         (ravenscar_thread_target::wait): Special case wildcard requests.
1753
1754 2019-02-15  Tom Tromey  <tromey@adacore.com>
1755
1756         * ravenscar-thread.c (base_ptid): Remove.
1757         (struct ravenscar_thread_target) <close>: New method.
1758         <m_base_ptid>: New member.
1759         <update_inferior_ptid, active_task, task_is_currently_active,
1760         runtime_initialized>: Declare methods.
1761         <ravenscar_thread_target>: Add constructor.
1762         (ravenscar_thread_target::task_is_currently_active)
1763         (ravenscar_thread_target::update_inferior_ptid)
1764         (ravenscar_runtime_initialized): Rename.  Now methods.
1765         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1766         (ravenscar_thread_target::update_thread_list): Update.
1767         (ravenscar_thread_target::active_task): Now method.
1768         (ravenscar_thread_target::store_registers)
1769         (ravenscar_thread_target::prepare_to_store)
1770         (ravenscar_thread_target::prepare_to_store)
1771         (ravenscar_thread_target::mourn_inferior): Update.
1772         (ravenscar_inferior_created): Use "new" to create target.
1773         (ravenscar_thread_target::get_ada_task_ptid): Update.
1774         (_initialize_ravenscar): Don't initialize base_ptid.
1775         (ravenscar_ops): Remove global.
1776
1777 2019-02-15  Tom Tromey  <tromey@adacore.com>
1778
1779         * target.h (push_target): Declare new overload.
1780         * target.c (push_target): New overload, taking an rvalue reference.
1781         * remote.c (remote_target::open_1): Use push_target overload.
1782         * corelow.c (core_target_open): Use push_target overload.
1783
1784 2019-02-15  Tom Tromey  <tromey@adacore.com>
1785
1786         * ravenscar-thread.c (is_ravenscar_task)
1787         (ravenscar_task_is_currently_active): Return bool.
1788         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1789         (_initialize_ravenscar): Remove "(void)".
1790         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1791         Return bool.
1792
1793 2019-02-15  Tom Tromey  <tromey@adacore.com>
1794
1795         * ravenscar-thread.c (ravenscar_runtime_initializer)
1796         (has_ravenscar_runtime, get_running_thread_id)
1797         (ravenscar_thread_target::resume): Fix indentation.
1798
1799 2019-02-15  Tom Tromey  <tromey@adacore.com>
1800
1801         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1802         from ravenscar_arch_ops.
1803         (sparc_ravenscar_ops::fetch_registers)
1804         (sparc_ravenscar_ops::store_registers): Now methods.
1805         (sparc_ravenscar_prepare_to_store): Remove.
1806         (sparc_ravenscar_ops): Redefine.
1807         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1808         methods and destructor.  Remove members.
1809         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1810         (ravenscar_thread_target::store_registers)
1811         (ravenscar_thread_target::prepare_to_store): Update.
1812         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1813         Remove.
1814         (struct ppc_ravenscar_powerpc_ops): Derive from
1815         ravenscar_arch_ops.
1816         (ppc_ravenscar_powerpc_ops::fetch_registers)
1817         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1818         (ppc_ravenscar_powerpc_ops): Redefine.
1819         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1820         (ppc_ravenscar_e500_ops::fetch_registers)
1821         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1822         (ppc_ravenscar_e500_ops): Redefine.
1823         * aarch64-ravenscar-thread.c
1824         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1825         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1826         (aarch64_ravenscar_fetch_registers)
1827         (aarch64_ravenscar_store_registers): Now methods.
1828         (aarch64_ravenscar_ops): Redefine.
1829
1830 2019-02-15  Tom Tromey  <tromey@adacore.com>
1831
1832         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1833         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1834         (ravenscar_thread_target::stopped_by_watchpoint)
1835         (ravenscar_thread_target::stopped_data_address)
1836         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1837
1838 2019-02-15  Tom Tromey  <tromey@adacore.com>
1839
1840         * ravenscar-thread.c: Fix some typos.
1841
1842 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1843             Tom Tromey  <tromey@adacore.com>
1844
1845         * ada-lang.c (ada_exception_sal): Change addr_string to a
1846         std::string.
1847         (create_ada_exception_catchpoint): Update.
1848
1849 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1850             Tom Tromey  <tromey@adacore.com>
1851
1852         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1853         (bp_location_ops): Remove.
1854         (base_breakpoint_allocate_location): Update.
1855         (free_bp_location): Update.
1856         * ada-lang.c (class ada_catchpoint_location)
1857         <ada_catchpoint_location>: Remove ops parameter.
1858         (ada_catchpoint_location_dtor): Remove.
1859         (ada_catchpoint_location_ops): Remove.
1860         (allocate_location_exception): Update.
1861         * breakpoint.h (struct bp_location_ops): Remove.
1862         (class bp_location) <bp_location>: Remove bp_location_ops
1863         parameter.
1864         <~bp_location>: Add destructor.
1865         <ops>: Remove.
1866
1867 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1868             Pedro Alves  <palves@redhat.com>
1869
1870         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1871         'PATH_MAX'.
1872
1873 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1874             Samuel Thibault  <samuel.thibault@gnu.org>
1875             Thomas Schwinge  <thomas@codesourcery.com>
1876
1877         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1878         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1879
1880 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1881
1882         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1883         (check_empty): Use "const char *".
1884
1885         * gnu-nat.c (gnu_nat_target::detach): Instead of
1886         'detach_inferior (pid)' call
1887         'detach_inferior (find_inferior_pid (pid))'.
1888
1889         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1890         'nat/fork-inferior.o'.
1891         * gnu-nat.c: #include "nat/fork-inferior.h".
1892
1893         * gnu-nat.c (gnu_nat_target::detach): Instead of
1894         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1895         * gnu-nat.h: #include "inf-child.h".
1896         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1897         'i386_gnu_nat_target::fetch_registers'.
1898         (gnu_store_registers): Rename/move to
1899         'i386_gnu_nat_target::store_registers'.
1900
1901         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1902         * gnu-nat.h (mach_thread_info): New function.
1903         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1904
1905         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1906
1907 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1908
1909         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1910
1911 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1912
1913         * windows-nat.c (windows_add_thread): Add new parameter
1914         "main_thread_p" with default value set to false.  Update
1915         function documentation as well as all callers.
1916         (windows_delete_thread): Likewise.
1917         (fake_create_process): Update call to windows_add_thread.
1918         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1919         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1920         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1921         call to windows_delete_thread.
1922
1923 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1924
1925         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1926
1927 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1928
1929         * symfile.c (find_separate_debug_file): Use canonical path of
1930         sysroot with child_path instead of gdb_sysroot if it is valid.
1931
1932 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1933
1934         * symfile.c (find_separate_debug_file): Use child_path to
1935         determine if an object file is under a sysroot.
1936
1937 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1938
1939         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1940         unittests/child-path-selftests.c.
1941         * common/pathstuff.c (child_path): New function.
1942         * common/pathstuff.h (child_path): New prototype.
1943         * unittests/child-path-selftests.c: New file.
1944
1945 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1946
1947         * symfile.c (find_separate_debug_file): Look for separate debug
1948         files in debug directories under the sysroot.
1949
1950 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1951
1952         * symtab.h (struct minimal_symbol data_p): New const method.
1953         (struct minimal_symbol text_p): Likewise.
1954         * symtab.c (output_source_filename): Use file name style
1955         to print file name.
1956         (print_symbol_info): Likewise.
1957         (print_msymbol_info): Use address style to print addresses.
1958         Use function name style to print executable text symbols.
1959         (expand_symtab_containing_pc): Use data_p.
1960         (find_pc_sect_compunit_symtab): Likewise.
1961
1962 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1963
1964         * breakpoint.c (describe_other_breakpoints): Use address style
1965         to print addresses.
1966         (say_where): Likewise.
1967
1968 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1969
1970         * ada-typeprint.c (print_func_type): Print function name
1971         style to print function name.
1972         * c-typeprint.c (c_print_type_1): Likewise.
1973
1974 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1975
1976         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1977         for execve.
1978
1979 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1980
1981         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1982         type_stack.
1983
1984 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1985
1986         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1987         TYPE_CODE_REF types.
1988
1989 2019-02-08  Jim Wilson  <jimw@sifive.com>
1990
1991         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1992         (riscv_linux_fregset): New.
1993         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1994
1995 2019-02-07  Tom Tromey  <tom@tromey.com>
1996
1997         * thread.c (thread_cancel_execution_command): Update.
1998         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1999         methods.
2000         (struct thread_fsm_ops): Remove.
2001         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2002         (thread_fsm_should_stop, thread_fsm_return_value)
2003         (thread_fsm_set_finished, thread_fsm_finished_p)
2004         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2005         Don't declare.
2006         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2007         * infrun.c (clear_proceed_status_thread)
2008         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2009         (print_stop_event): Update.
2010         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2011         Add constructor.
2012         (step_command_fsm_ops): Remove.
2013         (new_step_command_fsm): Remove.
2014         (step_1): Update.
2015         (step_command_fsm::should_stop): Rename from
2016         step_command_fsm_should_stop.
2017         (step_command_fsm::clean_up): Rename from
2018         step_command_fsm_clean_up.
2019         (step_command_fsm::do_async_reply_reason): Rename from
2020         step_command_fsm_async_reply_reason.
2021         (struct until_next_fsm): Inherit from thread_fsm.  Add
2022         constructor.
2023         (until_next_fsm_ops): Remove.
2024         (new_until_next_fsm): Remove.
2025         (until_next_fsm::should_stop): Rename from
2026         until_next_fsm_should_stop.
2027         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2028         (until_next_fsm::do_async_reply_reason): Rename from
2029         until_next_fsm_async_reply_reason.
2030         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2031         constructor.  Change type of breakpoint.
2032         (finish_command_fsm_ops): Remove.
2033         (new_finish_command_fsm): Remove.
2034         (finish_command_fsm::should_stop): Rename from
2035         finish_command_fsm_should_stop.
2036         (finish_command_fsm::clean_up): Rename from
2037         finish_command_fsm_clean_up.
2038         (finish_command_fsm::return_value): Rename from
2039         finish_command_fsm_return_value.
2040         (finish_command_fsm::do_async_reply_reason): Rename from
2041         finish_command_fsm_async_reply_reason.
2042         (finish_command): Update.
2043         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2044         Add constructor.
2045         (call_thread_fsm_ops): Remove.
2046         (call_thread_fsm::call_thread_fsm): Rename from
2047         new_call_thread_fsm.
2048         (call_thread_fsm::should_stop): Rename from
2049         call_thread_fsm_should_stop.
2050         (call_thread_fsm::should_notify_stop): Rename from
2051         call_thread_fsm_should_notify_stop.
2052         (run_inferior_call, call_function_by_hand_dummy): Update.
2053         * cli/cli-interp.c (should_print_stop_to_console): Update.
2054         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2055         Add constructor.  Change type of location_breakpoint,
2056         caller_breakpoint.
2057         (until_break_fsm_ops): Remove.
2058         (new_until_break_fsm): Remove.
2059         (until_break_fsm::should_stop): Rename from
2060         until_break_fsm_should_stop.
2061         (until_break_fsm::clean_up): Rename from
2062         until_break_fsm_clean_up.
2063         (until_break_fsm::do_async_reply_reason): Rename from
2064         until_break_fsm_async_reply_reason.
2065         (until_break_command): Update.
2066         * thread-fsm.c: Remove.
2067         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2068
2069 2019-02-07  Tom Tromey  <tom@tromey.com>
2070
2071         * yy-remap.h: Add include guard.
2072         * xtensa-tdep.h: Add include guard.
2073         * xcoffread.h: Rename include guard.
2074         * varobj-iter.h: Add include guard.
2075         * tui/tui.h: Rename include guard.
2076         * tui/tui-winsource.h: Rename include guard.
2077         * tui/tui-wingeneral.h: Rename include guard.
2078         * tui/tui-windata.h: Rename include guard.
2079         * tui/tui-win.h: Rename include guard.
2080         * tui/tui-stack.h: Rename include guard.
2081         * tui/tui-source.h: Rename include guard.
2082         * tui/tui-regs.h: Rename include guard.
2083         * tui/tui-out.h: Rename include guard.
2084         * tui/tui-layout.h: Rename include guard.
2085         * tui/tui-io.h: Rename include guard.
2086         * tui/tui-hooks.h: Rename include guard.
2087         * tui/tui-file.h: Rename include guard.
2088         * tui/tui-disasm.h: Rename include guard.
2089         * tui/tui-data.h: Rename include guard.
2090         * tui/tui-command.h: Rename include guard.
2091         * tic6x-tdep.h: Add include guard.
2092         * target/waitstatus.h: Rename include guard.
2093         * target/wait.h: Rename include guard.
2094         * target/target.h: Rename include guard.
2095         * target/resume.h: Rename include guard.
2096         * target-float.h: Rename include guard.
2097         * stabsread.h: Add include guard.
2098         * rs6000-tdep.h: Add include guard.
2099         * riscv-fbsd-tdep.h: Add include guard.
2100         * regformats/regdef.h: Rename include guard.
2101         * record.h: Rename include guard.
2102         * python/python.h: Rename include guard.
2103         * python/python-internal.h: Rename include guard.
2104         * python/py-stopevent.h: Rename include guard.
2105         * python/py-ref.h: Rename include guard.
2106         * python/py-record.h: Rename include guard.
2107         * python/py-record-full.h: Rename include guard.
2108         * python/py-record-btrace.h: Rename include guard.
2109         * python/py-instruction.h: Rename include guard.
2110         * python/py-events.h: Rename include guard.
2111         * python/py-event.h: Rename include guard.
2112         * procfs.h: Add include guard.
2113         * proc-utils.h: Add include guard.
2114         * p-lang.h: Add include guard.
2115         * or1k-tdep.h: Rename include guard.
2116         * observable.h: Rename include guard.
2117         * nto-tdep.h: Rename include guard.
2118         * nat/x86-linux.h: Rename include guard.
2119         * nat/x86-linux-dregs.h: Rename include guard.
2120         * nat/x86-gcc-cpuid.h: Add include guard.
2121         * nat/x86-dregs.h: Rename include guard.
2122         * nat/x86-cpuid.h: Rename include guard.
2123         * nat/ppc-linux.h: Rename include guard.
2124         * nat/mips-linux-watch.h: Rename include guard.
2125         * nat/linux-waitpid.h: Rename include guard.
2126         * nat/linux-ptrace.h: Rename include guard.
2127         * nat/linux-procfs.h: Rename include guard.
2128         * nat/linux-osdata.h: Rename include guard.
2129         * nat/linux-nat.h: Rename include guard.
2130         * nat/linux-namespaces.h: Rename include guard.
2131         * nat/linux-btrace.h: Rename include guard.
2132         * nat/glibc_thread_db.h: Rename include guard.
2133         * nat/gdb_thread_db.h: Rename include guard.
2134         * nat/gdb_ptrace.h: Rename include guard.
2135         * nat/fork-inferior.h: Rename include guard.
2136         * nat/amd64-linux-siginfo.h: Rename include guard.
2137         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2138         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2139         * nat/aarch64-linux.h: Rename include guard.
2140         * nat/aarch64-linux-hw-point.h: Rename include guard.
2141         * mn10300-tdep.h: Add include guard.
2142         * mips-linux-tdep.h: Add include guard.
2143         * mi/mi-parse.h: Rename include guard.
2144         * mi/mi-out.h: Rename include guard.
2145         * mi/mi-main.h: Rename include guard.
2146         * mi/mi-interp.h: Rename include guard.
2147         * mi/mi-getopt.h: Rename include guard.
2148         * mi/mi-console.h: Rename include guard.
2149         * mi/mi-common.h: Rename include guard.
2150         * mi/mi-cmds.h: Rename include guard.
2151         * mi/mi-cmd-break.h: Rename include guard.
2152         * m2-lang.h: Add include guard.
2153         * location.h: Rename include guard.
2154         * linux-record.h: Rename include guard.
2155         * linux-nat.h: Add include guard.
2156         * linux-fork.h: Add include guard.
2157         * i386-darwin-tdep.h: Rename include guard.
2158         * hppa-linux-offsets.h: Add include guard.
2159         * guile/guile.h: Rename include guard.
2160         * guile/guile-internal.h: Rename include guard.
2161         * gnu-nat.h: Rename include guard.
2162         * gdb-stabs.h: Rename include guard.
2163         * frv-tdep.h: Add include guard.
2164         * f-lang.h: Add include guard.
2165         * event-loop.h: Add include guard.
2166         * darwin-nat.h: Rename include guard.
2167         * cp-abi.h: Rename include guard.
2168         * config/sparc/nm-sol2.h: Rename include guard.
2169         * config/nm-nto.h: Rename include guard.
2170         * config/nm-linux.h: Add include guard.
2171         * config/i386/nm-i386gnu.h: Rename include guard.
2172         * config/djgpp/nl_types.h: Rename include guard.
2173         * config/djgpp/langinfo.h: Rename include guard.
2174         * compile/gcc-cp-plugin.h: Add include guard.
2175         * compile/gcc-c-plugin.h: Add include guard.
2176         * compile/compile.h: Rename include guard.
2177         * compile/compile-object-run.h: Rename include guard.
2178         * compile/compile-object-load.h: Rename include guard.
2179         * compile/compile-internal.h: Rename include guard.
2180         * compile/compile-cplus.h: Rename include guard.
2181         * compile/compile-c.h: Rename include guard.
2182         * common/xml-utils.h: Rename include guard.
2183         * common/x86-xstate.h: Rename include guard.
2184         * common/version.h: Rename include guard.
2185         * common/vec.h: Rename include guard.
2186         * common/tdesc.h: Rename include guard.
2187         * common/selftest.h: Rename include guard.
2188         * common/scoped_restore.h: Rename include guard.
2189         * common/scoped_mmap.h: Rename include guard.
2190         * common/scoped_fd.h: Rename include guard.
2191         * common/safe-iterator.h: Rename include guard.
2192         * common/run-time-clock.h: Rename include guard.
2193         * common/refcounted-object.h: Rename include guard.
2194         * common/queue.h: Rename include guard.
2195         * common/ptid.h: Rename include guard.
2196         * common/print-utils.h: Rename include guard.
2197         * common/preprocessor.h: Rename include guard.
2198         * common/pathstuff.h: Rename include guard.
2199         * common/observable.h: Rename include guard.
2200         * common/netstuff.h: Rename include guard.
2201         * common/job-control.h: Rename include guard.
2202         * common/host-defs.h: Rename include guard.
2203         * common/gdb_wait.h: Rename include guard.
2204         * common/gdb_vecs.h: Rename include guard.
2205         * common/gdb_unlinker.h: Rename include guard.
2206         * common/gdb_unique_ptr.h: Rename include guard.
2207         * common/gdb_tilde_expand.h: Rename include guard.
2208         * common/gdb_sys_time.h: Rename include guard.
2209         * common/gdb_string_view.h: Rename include guard.
2210         * common/gdb_splay_tree.h: Rename include guard.
2211         * common/gdb_setjmp.h: Rename include guard.
2212         * common/gdb_ref_ptr.h: Rename include guard.
2213         * common/gdb_optional.h: Rename include guard.
2214         * common/gdb_locale.h: Rename include guard.
2215         * common/gdb_assert.h: Rename include guard.
2216         * common/filtered-iterator.h: Rename include guard.
2217         * common/filestuff.h: Rename include guard.
2218         * common/fileio.h: Rename include guard.
2219         * common/environ.h: Rename include guard.
2220         * common/common-utils.h: Rename include guard.
2221         * common/common-types.h: Rename include guard.
2222         * common/common-regcache.h: Rename include guard.
2223         * common/common-inferior.h: Rename include guard.
2224         * common/common-gdbthread.h: Rename include guard.
2225         * common/common-exceptions.h: Rename include guard.
2226         * common/common-defs.h: Rename include guard.
2227         * common/common-debug.h: Rename include guard.
2228         * common/cleanups.h: Rename include guard.
2229         * common/buffer.h: Rename include guard.
2230         * common/btrace-common.h: Rename include guard.
2231         * common/break-common.h: Rename include guard.
2232         * cli/cli-utils.h: Rename include guard.
2233         * cli/cli-style.h: Rename include guard.
2234         * cli/cli-setshow.h: Rename include guard.
2235         * cli/cli-script.h: Rename include guard.
2236         * cli/cli-interp.h: Rename include guard.
2237         * cli/cli-decode.h: Rename include guard.
2238         * cli/cli-cmds.h: Rename include guard.
2239         * charset-list.h: Add include guard.
2240         * buildsym-legacy.h: Rename include guard.
2241         * bfin-tdep.h: Add include guard.
2242         * ax.h: Rename include guard.
2243         * arm-linux-tdep.h: Add include guard.
2244         * arm-fbsd-tdep.h: Add include guard.
2245         * arch/xtensa.h: Rename include guard.
2246         * arch/tic6x.h: Add include guard.
2247         * arch/i386.h: Add include guard.
2248         * arch/arm.h: Rename include guard.
2249         * arch/arm-linux.h: Rename include guard.
2250         * arch/arm-get-next-pcs.h: Rename include guard.
2251         * arch/amd64.h: Add include guard.
2252         * arch/aarch64-insn.h: Rename include guard.
2253         * arch-utils.h: Rename include guard.
2254         * annotate.h: Add include guard.
2255         * amd64-darwin-tdep.h: Rename include guard.
2256         * aarch64-linux-tdep.h: Add include guard.
2257         * aarch64-fbsd-tdep.h: Add include guard.
2258         * aarch32-linux-nat.h: Add include guard.
2259
2260 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2261
2262         * macrotab.c (macro_define_internal): New function that
2263         factorizes macro_define_object_internal and macro_define_function
2264         code.
2265         (macro_define_object_internal): Use macro_define_internal.
2266         (macro_define_function): Likewise.
2267
2268 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2269
2270         * macrocmd.c (extract_identifier): Return
2271         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2272         callers.
2273
2274 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2275
2276         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2277
2278 2019-02-05  Tom Tromey  <tom@tromey.com>
2279
2280         * target.c (target_stack::unpush): Move assertion earlier.
2281
2282 2019-01-30  Tom Tromey  <tom@tromey.com>
2283
2284         PR python/23615:
2285         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2286         (gdbpy_parse_and_eval): Likewise.
2287         * python/python-internal.h (gdbpy_allow_threads): New class.
2288
2289 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2290
2291         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2292         (aarch64_fbsd_fpregmap): Move earlier.
2293         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2294         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2295         instead of individual calls to trad_frame_set_reg_addr.
2296         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2297         earlier.
2298         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2299         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2300         instead of individual calls to trad_frame_set_reg_addr.
2301
2302 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2303
2304         * CONTRIBUTE: Replace contribution list with wiki link.
2305
2306 2019-01-25  Tom Tromey  <tom@tromey.com>
2307
2308         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2309
2310 2019-01-25  Tom Tromey  <tom@tromey.com>
2311
2312         * xtensa-linux-nat.c: Fix common/ includes.
2313         * xml-support.h: Fix common/ includes.
2314         * xml-support.c: Fix common/ includes.
2315         * x86-linux-nat.c: Fix common/ includes.
2316         * windows-nat.c: Fix common/ includes.
2317         * varobj.h: Fix common/ includes.
2318         * varobj.c: Fix common/ includes.
2319         * value.c: Fix common/ includes.
2320         * valops.c: Fix common/ includes.
2321         * utils.c: Fix common/ includes.
2322         * unittests/xml-utils-selftests.c: Fix common/ includes.
2323         * unittests/utils-selftests.c: Fix common/ includes.
2324         * unittests/unpack-selftests.c: Fix common/ includes.
2325         * unittests/tracepoint-selftests.c: Fix common/ includes.
2326         * unittests/style-selftests.c: Fix common/ includes.
2327         * unittests/string_view-selftests.c: Fix common/ includes.
2328         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2329         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2330         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2331         * unittests/rsp-low-selftests.c: Fix common/ includes.
2332         * unittests/parse-connection-spec-selftests.c: Fix common/
2333         includes.
2334         * unittests/optional-selftests.c: Fix common/ includes.
2335         * unittests/offset-type-selftests.c: Fix common/ includes.
2336         * unittests/observable-selftests.c: Fix common/ includes.
2337         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2338         * unittests/memrange-selftests.c: Fix common/ includes.
2339         * unittests/memory-map-selftests.c: Fix common/ includes.
2340         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2341         * unittests/function-view-selftests.c: Fix common/ includes.
2342         * unittests/environ-selftests.c: Fix common/ includes.
2343         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2344         * unittests/common-utils-selftests.c: Fix common/ includes.
2345         * unittests/cli-utils-selftests.c: Fix common/ includes.
2346         * unittests/array-view-selftests.c: Fix common/ includes.
2347         * ui-file.c: Fix common/ includes.
2348         * tui/tui-io.c: Fix common/ includes.
2349         * tracepoint.h: Fix common/ includes.
2350         * tracepoint.c: Fix common/ includes.
2351         * tracefile-tfile.c: Fix common/ includes.
2352         * top.h: Fix common/ includes.
2353         * top.c: Fix common/ includes.
2354         * thread.c: Fix common/ includes.
2355         * target/waitstatus.h: Fix common/ includes.
2356         * target/waitstatus.c: Fix common/ includes.
2357         * target.h: Fix common/ includes.
2358         * target.c: Fix common/ includes.
2359         * target-memory.c: Fix common/ includes.
2360         * target-descriptions.c: Fix common/ includes.
2361         * symtab.h: Fix common/ includes.
2362         * symfile.c: Fix common/ includes.
2363         * stap-probe.c: Fix common/ includes.
2364         * spu-linux-nat.c: Fix common/ includes.
2365         * sparc-nat.c: Fix common/ includes.
2366         * source.c: Fix common/ includes.
2367         * solib.c: Fix common/ includes.
2368         * solib-target.c: Fix common/ includes.
2369         * ser-unix.c: Fix common/ includes.
2370         * ser-tcp.c: Fix common/ includes.
2371         * ser-pipe.c: Fix common/ includes.
2372         * ser-base.c: Fix common/ includes.
2373         * selftest-arch.c: Fix common/ includes.
2374         * s12z-tdep.c: Fix common/ includes.
2375         * rust-exp.y: Fix common/ includes.
2376         * rs6000-aix-tdep.c: Fix common/ includes.
2377         * riscv-tdep.c: Fix common/ includes.
2378         * remote.c: Fix common/ includes.
2379         * remote-notif.h: Fix common/ includes.
2380         * remote-fileio.h: Fix common/ includes.
2381         * remote-fileio.c: Fix common/ includes.
2382         * regcache.h: Fix common/ includes.
2383         * regcache.c: Fix common/ includes.
2384         * record-btrace.c: Fix common/ includes.
2385         * python/python.c: Fix common/ includes.
2386         * python/py-type.c: Fix common/ includes.
2387         * python/py-inferior.c: Fix common/ includes.
2388         * progspace.h: Fix common/ includes.
2389         * producer.c: Fix common/ includes.
2390         * procfs.c: Fix common/ includes.
2391         * proc-api.c: Fix common/ includes.
2392         * printcmd.c: Fix common/ includes.
2393         * ppc-linux-nat.c: Fix common/ includes.
2394         * parser-defs.h: Fix common/ includes.
2395         * osdata.c: Fix common/ includes.
2396         * obsd-nat.c: Fix common/ includes.
2397         * nat/x86-linux.c: Fix common/ includes.
2398         * nat/x86-linux-dregs.c: Fix common/ includes.
2399         * nat/x86-dregs.h: Fix common/ includes.
2400         * nat/x86-dregs.c: Fix common/ includes.
2401         * nat/ppc-linux.c: Fix common/ includes.
2402         * nat/mips-linux-watch.h: Fix common/ includes.
2403         * nat/mips-linux-watch.c: Fix common/ includes.
2404         * nat/linux-waitpid.c: Fix common/ includes.
2405         * nat/linux-ptrace.h: Fix common/ includes.
2406         * nat/linux-ptrace.c: Fix common/ includes.
2407         * nat/linux-procfs.c: Fix common/ includes.
2408         * nat/linux-personality.c: Fix common/ includes.
2409         * nat/linux-osdata.c: Fix common/ includes.
2410         * nat/linux-namespaces.c: Fix common/ includes.
2411         * nat/linux-btrace.h: Fix common/ includes.
2412         * nat/linux-btrace.c: Fix common/ includes.
2413         * nat/fork-inferior.c: Fix common/ includes.
2414         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2415         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2416         * nat/aarch64-linux.c: Fix common/ includes.
2417         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2418         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2419         * namespace.h: Fix common/ includes.
2420         * mips-linux-tdep.c: Fix common/ includes.
2421         * minsyms.c: Fix common/ includes.
2422         * mi/mi-parse.h: Fix common/ includes.
2423         * mi/mi-main.c: Fix common/ includes.
2424         * mi/mi-cmd-env.c: Fix common/ includes.
2425         * memrange.h: Fix common/ includes.
2426         * memattr.c: Fix common/ includes.
2427         * maint.h: Fix common/ includes.
2428         * maint.c: Fix common/ includes.
2429         * main.c: Fix common/ includes.
2430         * machoread.c: Fix common/ includes.
2431         * location.c: Fix common/ includes.
2432         * linux-thread-db.c: Fix common/ includes.
2433         * linux-nat.c: Fix common/ includes.
2434         * linux-fork.c: Fix common/ includes.
2435         * inline-frame.c: Fix common/ includes.
2436         * infrun.c: Fix common/ includes.
2437         * inflow.c: Fix common/ includes.
2438         * inferior.h: Fix common/ includes.
2439         * inferior.c: Fix common/ includes.
2440         * infcmd.c: Fix common/ includes.
2441         * inf-ptrace.c: Fix common/ includes.
2442         * inf-child.c: Fix common/ includes.
2443         * ia64-linux-nat.c: Fix common/ includes.
2444         * i387-tdep.c: Fix common/ includes.
2445         * i386-tdep.c: Fix common/ includes.
2446         * i386-linux-tdep.c: Fix common/ includes.
2447         * i386-linux-nat.c: Fix common/ includes.
2448         * i386-go32-tdep.c: Fix common/ includes.
2449         * i386-fbsd-tdep.c: Fix common/ includes.
2450         * i386-fbsd-nat.c: Fix common/ includes.
2451         * guile/scm-type.c: Fix common/ includes.
2452         * guile/guile.c: Fix common/ includes.
2453         * go32-nat.c: Fix common/ includes.
2454         * gnu-nat.c: Fix common/ includes.
2455         * gdbthread.h: Fix common/ includes.
2456         * gdbarch-selftests.c: Fix common/ includes.
2457         * gdb_usleep.c: Fix common/ includes.
2458         * gdb_select.h: Fix common/ includes.
2459         * gdb_bfd.c: Fix common/ includes.
2460         * gcore.c: Fix common/ includes.
2461         * fork-child.c: Fix common/ includes.
2462         * findvar.c: Fix common/ includes.
2463         * fbsd-nat.c: Fix common/ includes.
2464         * event-top.c: Fix common/ includes.
2465         * event-loop.c: Fix common/ includes.
2466         * dwarf2read.c: Fix common/ includes.
2467         * dwarf2loc.c: Fix common/ includes.
2468         * dwarf2-frame.c: Fix common/ includes.
2469         * dwarf-index-cache.c: Fix common/ includes.
2470         * dtrace-probe.c: Fix common/ includes.
2471         * disasm-selftests.c: Fix common/ includes.
2472         * defs.h: Fix common/ includes.
2473         * csky-tdep.c: Fix common/ includes.
2474         * cp-valprint.c: Fix common/ includes.
2475         * cp-support.h: Fix common/ includes.
2476         * cp-support.c: Fix common/ includes.
2477         * corelow.c: Fix common/ includes.
2478         * completer.h: Fix common/ includes.
2479         * completer.c: Fix common/ includes.
2480         * compile/compile.c: Fix common/ includes.
2481         * compile/compile-loc2c.c: Fix common/ includes.
2482         * compile/compile-cplus-types.c: Fix common/ includes.
2483         * compile/compile-cplus-symbols.c: Fix common/ includes.
2484         * command.h: Fix common/ includes.
2485         * cli/cli-dump.c: Fix common/ includes.
2486         * cli/cli-cmds.c: Fix common/ includes.
2487         * charset.c: Fix common/ includes.
2488         * build-id.c: Fix common/ includes.
2489         * btrace.h: Fix common/ includes.
2490         * btrace.c: Fix common/ includes.
2491         * breakpoint.h: Fix common/ includes.
2492         * breakpoint.c: Fix common/ includes.
2493         * ax.h:
2494         (enum agent_op): Fix common/ includes.
2495         * ax-general.c (struct aop_map): Fix common/ includes.
2496         * ax-gdb.c: Fix common/ includes.
2497         * auxv.c: Fix common/ includes.
2498         * auto-load.c: Fix common/ includes.
2499         * arm-tdep.c: Fix common/ includes.
2500         * arch/riscv.c: Fix common/ includes.
2501         * arch/ppc-linux-common.c: Fix common/ includes.
2502         * arch/i386.c: Fix common/ includes.
2503         * arch/arm.c: Fix common/ includes.
2504         * arch/arm-linux.c: Fix common/ includes.
2505         * arch/arm-get-next-pcs.c: Fix common/ includes.
2506         * arch/amd64.c: Fix common/ includes.
2507         * arch/aarch64.c: Fix common/ includes.
2508         * arch/aarch64-insn.c: Fix common/ includes.
2509         * arch-utils.c: Fix common/ includes.
2510         * amd64-windows-tdep.c: Fix common/ includes.
2511         * amd64-tdep.c: Fix common/ includes.
2512         * amd64-sol2-tdep.c: Fix common/ includes.
2513         * amd64-obsd-tdep.c: Fix common/ includes.
2514         * amd64-nbsd-tdep.c: Fix common/ includes.
2515         * amd64-linux-tdep.c: Fix common/ includes.
2516         * amd64-linux-nat.c: Fix common/ includes.
2517         * amd64-fbsd-tdep.c: Fix common/ includes.
2518         * amd64-fbsd-nat.c: Fix common/ includes.
2519         * amd64-dicos-tdep.c: Fix common/ includes.
2520         * amd64-darwin-tdep.c: Fix common/ includes.
2521         * agent.c: Fix common/ includes.
2522         * ada-lang.h: Fix common/ includes.
2523         * ada-lang.c: Fix common/ includes.
2524         * aarch64-tdep.c: Fix common/ includes.
2525
2526 2019-01-25  Tom Tromey  <tom@tromey.com>
2527
2528         * common/create-version.sh: Use common/version.h.
2529
2530 2019-01-24  Pedro Alves  <palves@redhat.com>
2531
2532         * infrun.c (signal_stop, signal_print, signal_program)
2533         (signal_catch, signal_pass): Now arrays instead of pointers.
2534         (update_signals_program_target, do_target_resume)
2535         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2536         * linux-nat.c (linux_nat_target::pass_signals)
2537         (linux_nat_target::create_inferior, linux_nat_target::attach):
2538         Adjust.
2539         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2540         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2541         * procfs.c (procfs_target::pass_signals): Adjust.
2542         * record-full.c (record_full_target::resume): Adjust.
2543         * remote.c (remote_target::pass_signals)
2544         (remote_target::program_signals): Adjust.
2545         * target-debug.h (target_debug_print_signals): Now takes a
2546         gdb::array_view as parameter.  Adjust.
2547         * target.h (target_ops) <pass_signals, program_signals>: Replace
2548         pointer and length parameters with gdb::array_view.
2549         (target_pass_signals, target_program_signals): Likewise.
2550         * target-delegates.c: Regenerate.
2551
2552 2019-01-24  Pedro Alves  <palves@redhat.com>
2553
2554         * common/forward-scope-exit.h
2555         (forward_scope_exit::forward_scope_exit): Pass arguments to
2556         m_bind_function directly, instead of creating a std::bind and
2557         copying that.
2558
2559 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2560
2561         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2562         for static members.
2563         (pass_in_v_vfp_candidate): Likewise.
2564
2565 2019-01-23  Tom Tromey  <tom@tromey.com>
2566             Pedro Alves  <palves@redhat.com>
2567
2568         * regcache.c (class regcache_invalidator): Remove.
2569         (regcache::raw_write): Use make_scope_exit.
2570
2571 2019-01-23  Tom Tromey  <tom@tromey.com>
2572
2573         * ui-out.h (class ui_out_emit_type): Update comment.
2574
2575 2019-01-23  Tom Tromey  <tom@tromey.com>
2576
2577         * infrun.c (fetch_inferior_event): Update comment.
2578
2579 2019-01-23  Tom Tromey  <tom@tromey.com>
2580             Pedro Alves  <palves@redhat.com>
2581
2582         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2583         parameter.
2584         (fetch_inferior_event): Use SCOPE_EXIT.
2585
2586
2587 2019-01-23  Tom Tromey  <tom@tromey.com>
2588             Pedro Alves  <palves@redhat.com>
2589
2590         * infrun.c (disable_thread_events): Delete.
2591         (stop_all_threads): Use SCOPE_EXIT.
2592
2593 2019-01-23  Tom Tromey  <tom@tromey.com>
2594             Pedro Alves  <palves@redhat.com>
2595
2596         * symfile.c: Include forward-scope-exit.h.
2597         (clear_symtab_users_cleanup): Replace forward declaration with
2598         a FORWARD_SCOPE_EXIT.
2599         (syms_from_objfile_1): Use the forward_scope_exit and
2600         gdb::optional instead of cleanup_function.
2601         (reread_symbols): Use the forward_scope_exit instead of
2602         cleanup_function.
2603         (clear_symtab_users_cleanup): Remove function.
2604
2605 2019-01-23  Tom Tromey  <tom@tromey.com>
2606             Pedro Alves  <palves@redhat.com>
2607
2608         * linux-nat.c: Include scope-exit.h.
2609         (cleanup_target_stop): Remove.
2610         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2611         SCOPE_EXIT.
2612
2613 2019-01-23  Tom Tromey  <tom@tromey.com>
2614             Pedro Alves  <palves@redhat.com>
2615
2616         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2617         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2618
2619 2019-01-23  Tom Tromey  <tom@tromey.com>
2620             Andrew Burgess  <andrew.burgess@embecosm.com>
2621             Pedro Alves  <palves@redhat.com>
2622
2623         * infrun.c (fetch_inferior_event): Use scope_exit.
2624         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2625         * top.c (execute_command): Use scope_exit.
2626         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2627         * utils.c (do_bpstat_clear_actions_cleanup)
2628         (make_bpstat_clear_actions_cleanup): Remove.
2629
2630 2019-01-23  Tom Tromey  <tom@tromey.com>
2631             Pedro Alves  <palves@redhat.com>
2632
2633         * infrun.c: Include "common/scope-exit.h"
2634         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2635         (wait_for_inferior): Use SCOPE_EXIT.
2636         (fetch_inferior_event): Use scope_exit.
2637
2638 2019-01-23  Tom Tromey  <tom@tromey.com>
2639             Pedro Alves  <palves@redhat.com>
2640
2641         * breakpoint.c (create_breakpoint): Remove cleanup.
2642
2643 2019-01-23  Tom Tromey  <tom@tromey.com>
2644             Andrew Burgess  <andrew.burgess@embecosm.com>
2645             Pedro Alves  <palves@redhat.com>
2646
2647 2019-01-23  Pedro Alves  <palves@redhat.com>
2648
2649         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2650
2651 2019-01-23  Pedro Alves  <palves@redhat.com>
2652             Andrew Burgess  <andrew.burgess@embecosm.com>
2653
2654         * gdbthread.h: Include "common/forward-scope-exit.h".
2655         (scoped_finish_thread_state): Redefine custom class in terms of
2656         forward_scope_exit.
2657
2658 2019-01-23  Pedro Alves  <palves@redhat.com>
2659             Andrew Burgess  <andrew.burgess@embecosm.com>
2660
2661         * common/forward-scope-exit.h: New file.
2662
2663 2019-01-23  Pedro Alves  <palves@redhat.com>
2664             Andrew Burgess  <andrew.burgess@embecosm.com>
2665             Tom Tromey  <tom@tromey.com>
2666
2667         * common/scope-exit.h: New file.
2668
2669 2019-01-23  Pedro Alves  <palves@redhat.com>
2670
2671         * common/preprocessor.h (ESC): Rename to ...
2672         (ESC_PARENS): ... this.
2673         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2674         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2675
2676 2019-01-23  Tom Tromey  <tom@tromey.com>
2677
2678         * language.h (class scoped_switch_to_sym_language_if_auto):
2679         Initialize m_lang in both cases.
2680
2681 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2682
2683         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2684         with XCNEW.
2685
2686 2019-01-22  Tom Tromey  <tom@tromey.com>
2687
2688         * corelow.c: Do not include sys/file.h.
2689
2690 2019-01-22  Tom Tromey  <tom@tromey.com>
2691
2692         * tui/tui-wingeneral.h: Include gdb_curses.h.
2693
2694 2019-01-22  Tom Tromey  <tom@tromey.com>
2695
2696         * source-cache.h (class source_cache) <get_source_lines,
2697         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2698
2699 2019-01-22  Tom Tromey  <tom@tromey.com>
2700
2701         * remote-fileio.h (struct remote_target): Declare.
2702
2703 2019-01-22  Tom Tromey  <tom@tromey.com>
2704
2705         * python/py-arch.c: Do not include py-ref.h.
2706         * python/py-bpevent.c: Do not include py-ref.h.
2707         * python/py-cmd.c: Do not include py-ref.h.
2708         * python/py-continueevent.c: Do not include py-ref.h.
2709         * python/py-event.h: Do not include py-ref.h.
2710         * python/py-evtregistry.c: Do not include py-ref.h.
2711         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2712         * python/py-frame.c: Do not include py-ref.h.
2713         * python/py-framefilter.c: Do not include py-ref.h.
2714         * python/py-function.c: Do not include py-ref.h.
2715         * python/py-infevents.c: Do not include py-ref.h.
2716         * python/py-linetable.c: Do not include py-ref.h.
2717         * python/py-objfile.c: Do not include py-ref.h.
2718         * python/py-param.c: Do not include py-ref.h.
2719         * python/py-prettyprint.c: Do not include py-ref.h.
2720         * python/py-progspace.c: Do not include py-ref.h.
2721         * python/py-symbol.c: Do not include py-ref.h.
2722         * python/py-symtab.c: Do not include py-ref.h.
2723         * python/py-type.c: Do not include py-ref.h.
2724         * python/py-unwind.c: Do not include py-ref.h.
2725         * python/py-utils.c: Do not include py-ref.h.
2726         * python/py-value.c: Do not include py-ref.h.
2727         * python/py-varobj.c: Do not include py-ref.h.
2728         * python/py-xmethods.c: Do not include py-ref.h.
2729         * python/python.c: Do not include py-ref.h.
2730         * varobj.c: Do not include py-ref.h.
2731
2732 2019-01-22  Tom Tromey  <tom@tromey.com>
2733
2734         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2735         keyword for bcache.
2736
2737 2019-01-22  Tom Tromey  <tom@tromey.com>
2738
2739         * compile/compile-cplus-types.c: Remove a comment by #include.
2740
2741 2019-01-22  Tom Tromey  <tom@tromey.com>
2742
2743         * compile/gcc-c-plugin.h: Include compile-internal.h.
2744
2745 2019-01-22  Tom Tromey  <tom@tromey.com>
2746
2747         * stabsread.c (EXTERN): Do not define.
2748         (symnum, next_symbol_text_func, processing_gcc_compilation)
2749         (within_function, global_sym_chain, global_stabs)
2750         (previous_stab_code, this_object_header_files)
2751         (n_this_object_header_files)
2752         (n_allocated_this_object_header_files): Define.
2753         * stabsread.h (EXTERN): Never define.  Use "extern".
2754
2755 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2756
2757         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2758         history_value.
2759
2760 2019-01-21  Tom Tromey  <tom@tromey.com>
2761
2762         * ui-out.c: Fix includes.
2763         * tui/tui-source.c: Fix includes.
2764         * target.c: Fix includes.
2765         * remote.c: Fix includes.
2766         * regcache.c: Fix includes.
2767         * python/py-block.c: Fix includes.
2768         * printcmd.c: Fix includes.
2769         * or1k-tdep.c: Fix includes.
2770         * mi/mi-main.c: Fix includes.
2771         * m32r-tdep.c: Fix includes.
2772         * csky-tdep.c: Fix includes.
2773         * compile/compile-cplus-types.c: Fix includes.
2774         * cli/cli-interp.c: Fix includes.
2775
2776 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2777
2778         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2779         for padding.
2780
2781 2019-01-16  Tom Tromey  <tom@tromey.com>
2782
2783         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2784         earlier.
2785         (struct objfile) <msymbols_range>: Move from top level.
2786         <msymbols>: New method.
2787         (class objfile_msymbols): Remove.
2788         * symtab.c (default_collect_symbol_completion_matches_break_on):
2789         Update.
2790         * symmisc.c (dump_msymbols): Update.
2791         * stabsread.c (scan_file_globals): Update.
2792         * objc-lang.c (info_selectors_command, info_classes_command)
2793         (find_methods): Update.
2794         * minsyms.c (find_solib_trampoline_target): Update.
2795         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2796         * coffread.c (coff_symfile_read): Update.
2797         * ada-lang.c (ada_lookup_simple_minsym)
2798         (ada_collect_symbol_completion_matches): Update.
2799
2800 2019-01-16  Tom Tromey  <tom@tromey.com>
2801
2802         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2803         type.  Remove no-argument constructor.
2804         <iterator::operator++>: Simplify.
2805         <begin>: Update.
2806         <end>: Use minimal_symbol_count.
2807
2808 2019-01-16  Tom Tromey  <tom@tromey.com>
2809
2810         * objfiles.h (struct objfile) <psymtabs>: New method.
2811         (class objfile_psymtabs): Remove.
2812         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2813         typedef.
2814         <range>: New method.
2815         (require_partial_symbols): Change return type.
2816         * psymtab.c (require_partial_symbols)
2817         (psym_expand_symtabs_matching): Update.
2818         * mdebugread.c (parse_partial_symbols): Update.
2819         * dbxread.c (dbx_end_psymtab): Update.
2820
2821 2019-01-15  Tom Tromey  <tom@tromey.com>
2822
2823         * symtab.c (lookup_objfile_from_block)
2824         (lookup_symbol_in_objfile_symtabs)
2825         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2826         (find_line_symtab, info_sources_command)
2827         (default_collect_symbol_completion_matches_break_on)
2828         (make_source_files_completion_list): Update.
2829         * symmisc.c (print_objfile_statistics, dump_objfile)
2830         (maintenance_print_symbols, maintenance_info_symtabs)
2831         (maintenance_check_symtabs, maintenance_info_line_tables):
2832         Update.
2833         * source.c (select_source_symtab)
2834         (forget_cached_source_info_for_objfile): Update.
2835         * objfiles.h (class objfile_compunits): Remove.
2836         (struct objfile) <compunits_range>: New typedef.
2837         (compunits): New method.
2838         * objfiles.c (objfile_relocate1): Update.
2839         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2840         * maint.c (count_symtabs_and_blocks): Update.
2841         * linespec.c (iterate_over_all_matching_symtabs): Update.
2842         * cp-support.c (add_symbol_overload_list_qualified): Update.
2843         * coffread.c (coff_symtab_read): Update.
2844         * ada-lang.c (add_nonlocal_symbols)
2845         (ada_collect_symbol_completion_matches)
2846         (ada_add_global_exceptions): Update.
2847
2848 2019-01-15  Tom Tromey  <tom@tromey.com>
2849
2850         * progspace.h (program_space) <objfiles_safe_range>: New
2851         typedef.
2852         <objfiles_safe>: New method.
2853         * objfiles.h (class all_objfiles_safe): Remove.
2854         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2855         * jit.c (jit_inferior_exit_hook): Update.
2856
2857 2019-01-17  Tom Tromey  <tom@tromey.com>
2858
2859         * progspace.h (program_space) <objfiles_range>: New typedef.
2860         <objfiles>: New method.
2861         <objfiles_head>: Rename from objfiles.
2862         (object_files): Update.
2863         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2864         * guile/scm-pretty-print.c
2865         (ppscm_find_pretty_printer_from_objfiles): Update.
2866         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2867         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2868         Update.
2869         * python/py-progspace.c (pspy_get_objfiles): Update.
2870         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2871         Update.
2872         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2873         (objfpy_lookup_objfile_by_build_id): Update.
2874         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2875         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2876         Update.
2877         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2878         (expand_symtab_containing_pc, lookup_objfile_from_block)
2879         (lookup_static_symbol, basic_lookup_transparent_type)
2880         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2881         (find_line_symtab, info_sources_command)
2882         (default_collect_symbol_completion_matches_break_on)
2883         (make_source_files_completion_list, find_main_name): Update.
2884         * symmisc.c (print_symbol_bcache_statistics)
2885         (print_objfile_statistics, maintenance_print_symbols)
2886         (maintenance_print_msymbols, maintenance_print_objfiles)
2887         (maintenance_info_symtabs, maintenance_check_symtabs)
2888         (maintenance_expand_symtabs, maintenance_info_line_tables):
2889         Update.
2890         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2891         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2892         (map_overlay_command, unmap_overlay_command)
2893         (simple_overlay_update, expand_symtabs_matching)
2894         (map_symbol_filenames): Update.
2895         * symfile-debug.c (set_debug_symfile): Update.
2896         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2897         Update.
2898         * source.c (select_source_symtab, forget_cached_source_info):
2899         Update.
2900         * solib.c (solib_read_symbols): Update.
2901         * solib-spu.c (append_ocl_sos): Update.
2902         * psymtab.c (maintenance_print_psymbols)
2903         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2904         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2905         * printcmd.c (info_symbol_command): Update.
2906         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2907         Update.
2908         * objfiles.h (class all_objfiles): Remove.
2909         * objfiles.c (have_partial_symbols, have_full_symbols)
2910         (have_minimal_symbols, qsort_cmp, update_section_map)
2911         (shared_objfile_contains_address_p)
2912         (default_iterate_over_objfiles_in_search_order): Update.
2913         * objc-lang.c (info_selectors_command, info_classes_command)
2914         (find_methods): Update.
2915         * minsyms.c (find_solib_trampoline_target): Update.
2916         * maint.c (maintenance_info_sections)
2917         (maintenance_translate_address, count_symtabs_and_blocks):
2918         Update.
2919         * main.c (captured_main_1): Update.
2920         * linux-thread-db.c (try_thread_db_load_from_pdir)
2921         (has_libpthread): Update.
2922         * linespec.c (iterate_over_all_matching_symtabs)
2923         (search_minsyms_for_name): Update.
2924         * jit.c (jit_find_objf_with_entry_addr): Update.
2925         * hppa-tdep.c (find_unwind_entry)
2926         (hppa_lookup_stub_minimal_symbol): Update.
2927         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2928         Update.
2929         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2930         (elf_gnu_ifunc_resolve_by_got): Update.
2931         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2932         * dwarf-index-write.c (save_gdb_index_command): Update.
2933         * cp-support.c (add_symbol_overload_list_qualified): Update.
2934         * breakpoint.c (create_overlay_event_breakpoint)
2935         (create_longjmp_master_breakpoint)
2936         (create_std_terminate_master_breakpoint)
2937         (create_exception_master_breakpoint): Update.
2938         * blockframe.c (find_pc_partial_function): Update.
2939         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2940         (ada_collect_symbol_completion_matches)
2941         (ada_add_global_exceptions): Update.
2942
2943 2019-01-17  Tom Tromey  <tom@tromey.com>
2944
2945         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2946         declare VEC.
2947         (solib_target_parse_libraries): Change return type.
2948         (library_list_start_segment, library_list_start_section)
2949         (library_list_end_library, library_list_start_library); Update.
2950         (solib_target_free_library_list): Remove.
2951         (solib_target_parse_libraries): Remove cleanup.  Change return
2952         type.
2953         (solib_target_current_sos): Update.
2954
2955 2019-01-17  Tom Tromey  <tromey@bapiya>
2956
2957         * valprint.c: Replace "the the" with "the".
2958         * symtab.c: Replace "the the" with "the".
2959         * solib.c: Replace "the the" with "the".
2960         * solib-dsbt.c: Replace "the the" with "the".
2961         * linespec.c: Replace "the the" with "the".
2962         * dwarf2loc.h: Replace "the the" with "the".
2963         * amd64-windows-tdep.c: Replace "the the" with "the".
2964         * aarch64-tdep.c: Replace "the the" with "the".
2965
2966 2019-01-16  Keith Seitz  <keiths@redhat.com>
2967
2968         PR gdb/23773
2969         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2970         <builder>: Rename to ..
2971         <m_builder>: ... this and make private.
2972         (dwarf2_cu::get_builder): New method.  Change all users of
2973         `builder' to use this method.
2974         (dwarf2_start_symtab): Move to ...
2975         (dwarf2_cu::start_symtab): ... here.  Update all callers
2976         (setup_type_unit_groups): Move to ...
2977         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2978         callers.
2979         (dwarf2_cu::reset_builder): New method.
2980         (process_full_compunit, process_full_type_unit): Use
2981         dwarf2_cu::reset_builder.
2982         (follow_die_offset): Record the ancestor CU if it is different
2983         from the followed DIE's CU.
2984         (follow_die_sig_1): Likewise.
2985
2986 2019-01-15  Tom Tromey  <tom@tromey.com>
2987
2988         * remote.c (class remote_state) <buf>: Now a char_vector.
2989         <buf_size>: Remove.
2990         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2991         parameter.
2992         (remote_target::getpkt_or_notif_sane_1)
2993         (remote_target::getpkt_sane)
2994         (remote_target::getpkt_or_notif_sane): Likewise.
2995         (class remote_target) <putpkt>: New overload.
2996         (remote_target::read_frame): Change type of "buf_p".  Remove
2997         sizeof_p parameter.
2998         (packet_ok): New overload.
2999         (packet_check_result): New overload.
3000         Update all uses.
3001
3002 2019-01-14  Tom Tromey  <tom@tromey.com>
3003
3004         * remote-notif.c (handle_notification, remote_notif_ack)
3005         (remote_notif_parse): Make "buf" const.
3006         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3007         const.
3008         (remote_notif_parse, remote_notif_ack, handle_notification):
3009         Likewise.
3010         * remote.c (remote_notif_stop_parse): Make "buf" const.
3011         (remote_target::remote_parse_stop_reply): Make "buf" const.
3012         (remote_notif_stop_ack): Make "buf" const.
3013
3014 2019-01-14  Tom Tromey  <tom@tromey.com>
3015
3016         * remote.c (remote_console_output): Make parameter const.
3017
3018 2019-01-14  Tom Tromey  <tom@tromey.com>
3019
3020         * target-debug.h (target_debug_print_signals): Constify.
3021         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3022         * procfs.c (procfs_target::pass_signals): Update.
3023         * linux-nat.c (linux_nat_target::pass_signals): Update.
3024         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3025         * target-delegates.c: Rebuild.
3026         * remote.c (remote_target::program_signals): Update.
3027         (remote_target::pass_signals): Update.
3028         * target.c (target_pass_signals): Constify argument.
3029         (target_program_signals): Likewise.
3030         * target.h (struct target_ops) <pass_signals, program_signals>:
3031         Constify argument.
3032         (target_pass_signals, target_program_signals): Constify argument.
3033
3034 2019-01-14  Tom Tromey  <tom@tromey.com>
3035
3036         PR tui/28819:
3037         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3038
3039 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3040
3041         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3042         field.
3043         * rs6000-tdep.c: Include reggroups.h.
3044         (IS_V_ALIAS_PSEUDOREG): Define.
3045         (rs6000_register_name): Return names for the "vX" aliases.
3046         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3047         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3048         aliases.  Call default_register_reggroup_p for all other
3049         pseudo-registers.
3050         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3051         New functions.
3052         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3053         Handle "vX" aliases.
3054         (v_alias_pseudo_register_collect): New function.
3055         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3056         (rs6000_gdbarch_init): Initialize "vX" aliases as
3057         pseudo-registers.  Restore registration of
3058         rs6000_pseudo_register_reggroup_p with
3059         set_tdesc_pseudo_register_reggroup_p.
3060
3061 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3062
3063         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3064         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3065         set_gdbarch_num_pseudo_regs.
3066
3067 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3068
3069         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3070         Remove arg prefixname, add do_set and do_show.
3071         Add member functions set_list and show_list.
3072         * cli/cli-style.c (class cli_style_option): Update accordingly.
3073         (style_set_list): Move to file scope.
3074         (style_show_list): Likewise.
3075         (set_style): Call help_list.
3076         (show_style): Call cmd_show_list.
3077         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3078         Update to use the new macro.
3079
3080 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3081
3082         * ada-lang.c (_initialize_ada_language): Expand the help text
3083         for the "catch exception" command.
3084
3085 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3086
3087         * symtab.c (matching_obj_sections): Initialize obj,
3088         declare it closer to its usage.
3089
3090 2019-01-10  Tom Tromey  <tom@tromey.com>
3091
3092         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3093         (basic_inf_threads_range): Remove.
3094         (inf_threads_range, inf_non_exited_threads_range)
3095         (safe_inf_threads_range): Use next_adapter.
3096
3097 2019-01-10  Keith Seitz  <keiths@redhat.com>
3098
3099         PR gdb/23712
3100         PR symtab/23010
3101         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3102         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3103
3104 2019-01-10  Keith Seitz  <keiths@redhat.com>
3105
3106         PR gdb/23712
3107         PR symtab/23010
3108         * dictionary.c (pending_to_vector): Remove.
3109         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3110         Remove _1 suffix, replacing functions of the same name.  Update
3111         all callers.
3112         (dict_create_hashed, dict_create_hashed_expandable)
3113         (dict_create_linear, dict_create_linear_expandable, dict_free)
3114         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3115         Make functions static.
3116
3117 2019-01-10  Keith Seitz  <keiths@redhat.com>
3118
3119         PR gdb/23712
3120         PR symtab/23010
3121         * dictionary.h (struct dictionary): Replace declaration with
3122         multidictionary.
3123         (dict_create_hashed, dict_create_hashed_expandable)
3124         (dict_create_linear, dict_create_linear_expandable)
3125         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3126         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3127         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3128         taking multidictionary argument.
3129         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3130         * block.h (struct block) <dict>: Change to multidictionary
3131         and rename `multidict'.
3132         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3133         symmisc.c: Update all dictionary references to multidictionary.
3134
3135 2019-01-10  Keith Seitz  <keiths@redhat.com>
3136
3137         PR gdb/23712
3138         PR symtab/23010
3139         * dictionary.c: Include unordered_map.
3140         (pending_to_vector): New function.
3141         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3142         Rewrite the non-"_1" functions to take vector instead
3143         of linked list.
3144         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3145         "new" _1 versions of the same name.
3146         (multidictionary): Define.
3147         (std::hash<enum language): New definition.
3148         (collate_pending_symbols_by_language, mdict_create_hashed)
3149         (mdict_create_hashed_expandable, mdict_create_linear)
3150         (mdict_create_linear_expandable, mdict_free)
3151         (find_language_dictionary, create_new_language_dictionary)
3152         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3153         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3154         (mdict_size, mdict_empty): New functions.
3155         * dictionary.h (mdict_iterator): Define.
3156
3157 2019-01-10  Pedro Alves  <palves@redhat.com>
3158
3159         * breakpoint.c (read_uploaded_action)
3160         (create_tracepoint_from_upload): Adjust to use
3161         gdb::unique_xmalloc_ptr.
3162         * ctf.c (ctf_write_uploaded_tp):
3163         (SET_ARRAY_FIELD): Use emplace_back.
3164         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3165         * tracefile-tfile.c (tfile_write_uploaded_tp):
3166         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3167         gdb::unique_xmalloc_ptr.
3168         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3169         at_string, cond_string, cmd_strings>: Replace char pointers
3170         with gdb::unique_xmalloc_ptr.
3171
3172 2019-01-10  Pedro Alves  <palves@redhat.com>
3173
3174         * solib-target.c (library_list_start_library): Don't xstrdup name.
3175
3176 2019-01-10  Pedro Alves  <palves@redhat.com>
3177
3178         * mdebugread.c (parse_partial_symbols): Use
3179         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3180
3181 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3182
3183         * linux-fork.c (scoped_switch_fork_info)
3184         <~scoped_switch_fork_info>: Fix incorrect variable name.
3185
3186 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3187
3188         * linux-fork.c (scoped_switch_fork_info)
3189         <scoped_switch_fork_info>: Make explicit.
3190         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3191
3192 2019-01-10  Tom Tromey  <tom@tromey.com>
3193
3194         * objfiles.h (objfile::reset_psymtabs): Update.
3195         * objfiles.c (objfile::objfile): Update.
3196         * psymtab.h (psymtab_storage::obstack): Update.
3197         (psymtab_storage::m_obstack): Use gdb::optional.
3198         (class psymtab_storage): Update comment.  Remove objfile
3199         parameter.
3200         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3201
3202 2019-01-10  Tom Tromey  <tom@tromey.com>
3203
3204         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3205         <free_psymtabs>: Now private.
3206         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3207         (allocate_psymtab): Use new method.
3208
3209 2019-01-10  Tom Tromey  <tom@tromey.com>
3210
3211         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3212         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3213         * mdebugread.c (parse_partial_symbols): Use
3214         allocate_dependencies.
3215         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3216         allocate_dependencies.
3217         (process_psymtab_comp_unit_reader)
3218         (build_type_psymtab_dependencies): Likewise.
3219         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3220
3221 2019-01-10  Tom Tromey  <tom@tromey.com>
3222
3223         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3224         PSYMBOL_SET_LANGUAGE.
3225         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3226
3227 2019-01-10  Tom Tromey  <tom@tromey.com>
3228
3229         * psymtab.h (psymtab_storage::obstack): New method.
3230         <m_obstack>: Rename from obstack; now private.
3231         * psymtab.c (psymtab_storage): Update.
3232         * dwarf2read.c (create_addrmap_from_index)
3233         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3234         Update.
3235
3236 2019-01-10  Tom Tromey  <tom@tromey.com>
3237
3238         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3239         * objfiles.h (objfile::reset_psymtabs): New method.
3240
3241 2019-01-10  Tom Tromey  <tom@tromey.com>
3242
3243         * symmisc.c (print_symbol_bcache_statistics): Update.
3244         (print_objfile_statistics): Update.
3245         * symfile.c (reread_symbols): Update.
3246         * psymtab.h (class psymtab_storage): New.
3247         * psymtab.c (psymtab_storage): New constructor.
3248         (~psymtab_storage): New destructor.
3249         (require_partial_symbols): Update.
3250         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3251         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3252         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3253         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3254         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3255         (start_psymtab_common, end_psymtab_common)
3256         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3257         (allocate_psymtab): Update.
3258         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3259         Update.
3260         (dump_psymtab_addrmap, maintenance_print_psymbols)
3261         (maintenance_check_psymtabs): Update.
3262         (class objfile_psymtabs): Move to objfiles.h.
3263         * psympriv.h (discard_psymtab): Now inline.
3264         (psymtab_discarder::psymtab_discarder): Update.
3265         (psymtab_discarder::~psymtab_discarder): Update.
3266         (ALL_OBJFILE_PSYMTABS): Rewrite.
3267         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3268         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3269         Remove fields.
3270         <partial_symtabs>: New field.
3271         (class objfile_psymtabs): Move from psymtab.h.  Update.
3272         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3273         psymbol_cache.
3274         (objfile::~objfile): Don't destroy psymbol_cache.
3275         * mdebugread.c (parse_partial_symbols): Update.
3276         * dwarf2read.c (create_addrmap_from_index)
3277         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3278         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3279         (add_partial_subprogram, dwarf2_ranges_read): Update.
3280         * dwarf-index-write.c (write_address_map)
3281         (write_one_signatured_type, recursively_write_psymbols)
3282         (class debug_names, class debug_names, write_psymtabs_to_index):
3283         Update.
3284
3285 2019-01-10  Tom Tromey  <tom@tromey.com>
3286
3287         * symtab.h (SYMBOL_SET_NAMES): Update.
3288         (symbol_set_names): Update.
3289         (MSYMBOL_SET_NAMES): Update.
3290         * symtab.c (symbol_set_names): Change argument to be an
3291         objfile_per_bfd_storage.
3292         * psymtab.c (add_psymbol_to_bcache): Update.
3293         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3294
3295 2019-01-10  Tom Tromey  <tom@tromey.com>
3296
3297         * symtab.c (create_demangled_names_hash): Change argument to be an
3298         objfile_per_bfd_storage.
3299         (symbol_set_names): Update.
3300
3301 2019-01-10  Tom Tromey  <tom@tromey.com>
3302
3303         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3304         init_psymbol_list.
3305         * psymtab.c (init_psymbol_list): Do nothing if already called.
3306         * psympriv.h (init_psymbol_list): Add comment.
3307         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3308         init_psymbol_list.
3309         * dbxread.c (dbx_symfile_read): Unconditionally call
3310         init_psymbol_list.
3311
3312 2019-01-10  Tom Tromey  <tom@tromey.com>
3313
3314         * xcoffread.c (scan_xcoff_symtab): Update.
3315         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3316         "where".
3317         * mdebugread.c (parse_partial_symbols)
3318         (handle_psymbol_enumerators): Update.
3319         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3320         * dbxread.c (read_dbx_symtab): Update.
3321         * psympriv.h (psymbol_placement): New enum.
3322         (add_psymbol_to_list): Update.
3323
3324 2019-01-10  Tom Tromey  <tom@tromey.com>
3325
3326         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3327         static_psymbols parameters.
3328         (scan_xcoff_symtab): Update.
3329         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3330         static_psymbols parameters.
3331         * psympriv.h (start_psymtab_common): Update.
3332         * mdebugread.c (parse_partial_symbols): Update.
3333         * dwarf2read.c (create_partial_symtab): Update.
3334         * dbxread.c (read_dbx_symtab): Update.
3335         (start_psymtab): Remove global_psymbols and static_psymbols
3336         parameters.
3337
3338 2019-01-10  Tom Tromey  <tom@tromey.com>
3339
3340         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3341         * psymtab.c (allocate_psymtab): Add comment.
3342         * psympriv.h (allocate_psymtab): Add comment.
3343         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3344         initializations.
3345         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3346
3347 2019-01-10  Tom Tromey  <tom@tromey.com>
3348
3349         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3350         Don't declare.
3351         * mipsread.c: Include mdebugread.h.
3352         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3353         Declare.
3354         * elfread.c: Include mdebugread.h.
3355
3356 2019-01-09  Tom Tromey  <tom@tromey.com>
3357
3358         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3359         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3360         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3361         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3362         (psym_lookup_symbol, psym_find_last_source_symtab)
3363         (psym_forget_cached_source_info, psym_print_stats)
3364         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3365         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3366         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3367         (psym_find_compunit_symtab_by_address)
3368         (maintenance_print_psymbols, maintenance_info_psymtabs)
3369         (maintenance_check_psymtabs): Use ranged for.
3370         * psymtab.h (class objfile_psymtabs): New.
3371         (require_partial_symbols): Return objfile_psymtabs.
3372         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3373
3374 2019-01-09  Tom Tromey  <tom@tromey.com>
3375
3376         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3377         (find_pc_mapped_section, list_overlays_command)
3378         (map_overlay_command, unmap_overlay_command)
3379         (simple_overlay_update): Use all_objfiles.
3380         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3381         * printcmd.c (info_symbol_command): Use all_objfiles.
3382         * objfiles.h (ALL_OBJSECTIONS): Remove.
3383         * maint.c (maintenance_translate_address): Use all_objfiles.
3384         * gcore.c (gcore_create_callback): Use all_objfiles.
3385         (objfile_find_memory_regions): Likewise.
3386
3387 2019-01-09  Tom Tromey  <tom@tromey.com>
3388
3389         * symtab.c (find_line_symtab, info_sources_command)
3390         (make_source_files_completion_list): Use objfile_compunits.
3391         * source.c (select_source_symtab): Use objfile_compunits.
3392         * objfiles.h (struct objfile): Update comment.
3393         (ALL_OBJFILES): Remove.
3394         (ALL_FILETABS): Remove.
3395         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3396         objfile_compunits.
3397
3398 2019-01-09  Tom Tromey  <tom@tromey.com>
3399
3400         * symmisc.c (print_objfile_statistics, dump_objfile)
3401         (maintenance_print_symbols): Use compunit_filetabs.
3402         * source.c (forget_cached_source_info_for_objfile): Use
3403         compunit_filetabs.
3404         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3405         (ALL_FILETABS): Use compunit_filetabs.
3406         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3407         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3408
3409 2019-01-09  Tom Tromey  <tom@tromey.com>
3410
3411         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3412         (compunit_filetabs): New.
3413         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3414         compunit_filetabs.
3415         (info_sources_command, make_source_files_completion_list): Remove
3416         declaration.
3417         * symmisc.c (print_objfile_statistics, dump_objfile)
3418         (maintenance_print_symbols): Remove declaration.
3419         (maintenance_info_symtabs): Use compunit_filetabs.
3420         (maintenance_info_line_tables): Likewise.
3421         * source.c (select_source_symtab): Change local variable name.
3422         (forget_cached_source_info_for_objfile): Remove declaration.
3423         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3424         * objfiles.c (objfile_relocate1): Remove declaration.
3425         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3426         declaration.
3427         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3428         * coffread.c (coff_symtab_read): Remove declaration.
3429         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3430         compunit_filetabs.
3431
3432 2019-01-09  Tom Tromey  <tom@tromey.com>
3433
3434         * symtab.c (lookup_objfile_from_block)
3435         (find_pc_sect_compunit_symtab, search_symbols)
3436         (default_collect_symbol_completion_matches_break_on): Use
3437         objfile_compunits.
3438         * objfiles.h (ALL_COMPUNITS): Remove.
3439         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3440         * cp-support.c (add_symbol_overload_list_qualified): Use
3441         objfile_compunits.
3442         * ada-lang.c (ada_collect_symbol_completion_matches)
3443         (ada_add_global_exceptions): Use objfile_compunits.
3444
3445 2019-01-09  Tom Tromey  <tom@tromey.com>
3446
3447         * source.c (select_source_symtab)
3448         (forget_cached_source_info_for_objfile): Remove declaration.
3449         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3450         declaration.
3451         * maint.c (count_symtabs_and_blocks): Remove declaration.
3452         * cp-support.c (add_symbol_overload_list_qualified): Remove
3453         declaration.
3454         * coffread.c (coff_symtab_read): Remove declaration.
3455         * symtab.c (lookup_symbol_in_objfile_symtabs)
3456         (basic_lookup_transparent_type_1): Use objfile_compunits.
3457         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3458         (info_sources_command, search_symbols)
3459         (default_collect_symbol_completion_matches_break_on)
3460         (make_source_files_completion_list): Remove declaration.
3461         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3462         (ada_collect_symbol_completion_matches)
3463         (ada_add_global_exceptions): Remove declaration.
3464         * linespec.c (iterate_over_all_matching_symtabs): Use
3465         objfile_compunits.
3466         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3467         (class objfile_compunits): New.
3468         (ALL_COMPUNITS): Use objfile_compunits.
3469         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3470         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3471         objfile_compunits.
3472         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3473
3474 2019-01-09  Tom Tromey  <tom@tromey.com>
3475
3476         * symtab.c (search_symbols)
3477         (default_collect_symbol_completion_matches_break_on): Use
3478         objfile_msymbols.
3479         * ada-lang.c (ada_lookup_simple_minsym)
3480         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3481         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3482         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3483         objfile_msymbols.
3484         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3485         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3486         * objc-lang.c (find_methods): Use objfile_msymbols.
3487         (info_selectors_command, info_classes_command): Likewise.
3488         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3489         * objfiles.h (class objfile_msymbols): New.
3490         (ALL_OBJFILE_MSYMBOLS): Remove.
3491         (ALL_MSYMBOLS): Remove.
3492
3493 2019-01-09  Tom Tromey  <tom@tromey.com>
3494
3495         * common/next-iterator.h (next_adapter): Add Iterator template
3496         parameter.
3497         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3498         (class all_objfiles_safe): New.
3499         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3500         * objfiles.c (put_objfile_before): Update comment.
3501         (add_separate_debug_objfile): Likewise.
3502         (free_all_objfiles): Use all_objfiles_safe.
3503         (objfile_purge_solibs): Likewise.
3504
3505 2019-01-09  Tom Tromey  <tom@tromey.com>
3506
3507         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3508         (expand_symtab_containing_pc, lookup_static_symbol)
3509         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3510         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3511         all_objfiles.
3512         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3513         * breakpoint.c (create_overlay_event_breakpoint)
3514         (create_longjmp_master_breakpoint)
3515         (create_std_terminate_master_breakpoint)
3516         (create_exception_master_breakpoint): Use all_objfiles.
3517         * linux-thread-db.c (try_thread_db_load_from_pdir)
3518         (has_libpthread): Use all_objfiles.
3519         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3520         * linespec.c (iterate_over_all_matching_symtabs)
3521         (search_minsyms_for_name): Use all_objfiles.
3522         * maint.c (maintenance_info_sections): Use all_objfiles.
3523         * main.c (captured_main_1): Use all_objfiles.
3524         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3525         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3526         * guile/scm-pretty-print.c
3527         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3528         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3529         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3530         (maintenance_print_msymbols): Use all_objfiles.
3531         * source.c (select_source_symtab): Use all_objfiles.
3532         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3533         * symfile.c (remove_symbol_file_command)
3534         (expand_symtabs_matching, map_symbol_filenames): Use
3535         all_objfiles.
3536         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3537         all_objfiles.
3538         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3539         * objc-lang.c (find_methods): Use all_objfiles.
3540         * objfiles.c (have_partial_symbols, have_full_symbols)
3541         (have_minimal_symbols, qsort_cmp)
3542         (default_iterate_over_objfiles_in_search_order): Use
3543         all_objfiles.
3544         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3545         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3546         (maintenance_check_psymtabs): Use all_objfiles.
3547         (ALL_PSYMTABS): Remove.
3548         * compile/compile-object-run.c (do_module_cleanup): Use
3549         all_objfiles.
3550         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3551         * cp-support.c (add_symbol_overload_list_qualified): Use
3552         all_objfiles.
3553         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3554         Use all_objfiles.
3555         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3556         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3557         all_objfiles.
3558         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3559         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3560         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3561         Uses all_objfiles.
3562         * solib.c (solib_read_symbols): Use all_objfiles
3563
3564 2019-01-09  Tom Tromey  <tom@tromey.com>
3565
3566         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3567         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3568         all_objfiles.
3569         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3570         * symmisc.c (print_symbol_bcache_statistics)
3571         (print_objfile_statistics, maintenance_print_objfiles)
3572         (maintenance_info_symtabs, maintenance_check_symtabs)
3573         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3574         all_objfiles.
3575         * source.c (forget_cached_source_info): Use all_objfiles.
3576         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3577         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3578         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3579         * objfiles.c (update_section_map): Use all_objfiles.
3580         (shared_objfile_contains_address_p): Likewise.
3581         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3582         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3583
3584 2019-01-09  Tom Tromey  <tom@tromey.com>
3585
3586         * common/next-iterator.h: New file.
3587         * objfiles.h (class all_objfiles): New.
3588         (struct objfile_iterator): New.
3589
3590 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3591
3592         * NEWS: Move the description of the changed "frame", "select-frame",
3593          and "info frame" commands to the Changed commands section.
3594
3595 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3596
3597         * gdbtypes.c (check_stub_method_group): Remove handling of old
3598         mangling schemes.
3599         * linespec.c (find_methods): Likewise.
3600         * stabsread.c (read_member_functions): Likewise.
3601         * valops.c (search_struct_method): Likewise.
3602         (value_struct_elt_for_reference): Likewise.
3603         * NEWS: Mention this change.
3604
3605 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3606
3607         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3608         print_source_lines.
3609         * source.c (print_source_lines_base): Update line number check.
3610         (print_source_lines): New function.
3611         (source_lines_range::source_lines_range): New function.
3612         * source.h (class source_lines_range): New class.
3613         (print_source_lines): New declaration.
3614
3615 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3616
3617         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3618
3619 2019-01-08  Tom Tromey  <tom@tromey.com>
3620             Simon Marchi  <simon.marchi@ericsson.com>
3621
3622         PR gdb/24060
3623         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3624         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3625         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3626         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3627         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3628         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3629
3630 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3631
3632         * source.c (select_source_symtab): Move header comment to
3633         declaration in source.h.
3634         (forget_cached_source_info_for_objfile): Likewise.
3635         (forget_cached_source_info): Likewise.
3636         (identify_source_line): Likewise.
3637         * source.h (identify_source_line): Move declaration from symtab.h
3638         and add comment from source.c
3639         (print_source_lines): Likewise.
3640         (forget_cached_source_info_for_objfile): Likewise.
3641         (forget_cached_source_info): Likewise.
3642         (select_source_symtab): Likewise.
3643         (enum print_source_lines_flag): Move definition from symtab.h.
3644         * symtab.h (identify_source_line): Move declaration to source.h.
3645         (print_source_lines): Likewise.
3646         (forget_cached_source_info_for_objfile): Likewise.
3647         (forget_cached_source_info): Likewise.
3648         (select_source_symtab): Likewise.
3649         (enum print_source_lines_flag): Move definition to source.h.
3650         * tui/tui-hooks.c: Add 'source.h' include.
3651
3652 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3653
3654         * source.c (print_source_lines_base): Handle requests to print
3655         reverse line number sequences, and guard against empty lines
3656         string.
3657
3658 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3659
3660         * source.c (print_source_lines_base): Fix skip of '\r' if next
3661         character is '\n'.
3662
3663 2019-01-06  Tom Tromey  <tom@tromey.com>
3664
3665         * c-exp.y (struct c_parse_state) <macro_original_text,
3666         expansion_obstack>: New member.
3667         (macro_original_text, expansion_obstack): Remove globals.
3668         (scan_macro_expansion, scanning_macro_expansion)
3669         (finished_macro_expansion): Update.
3670         (scan_macro_cleanup): Remove.
3671         (yylex, c_parse): Update.
3672
3673 2019-01-06  Tom Tromey  <tom@tromey.com>
3674
3675         * c-exp.y (struct c_parse_state) <strings>: New member.
3676         (operator_stoken): Update.
3677
3678 2019-01-06  Tom Tromey  <tom@tromey.com>
3679
3680         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3681         (union type_stack_elt) <typelist_val>: Now a pointer to
3682         std::vector.
3683         (type_stack_cleanup): Don't declare.
3684         (push_typelist): Update.
3685         * parse.c (pop_typelist): Return a std::vector.
3686         (push_typelist): Take a std::vector.
3687         (follow_types): Update.  Do not free args.
3688         (type_stack_cleanup): Remove.
3689         * c-exp.y (struct c_parse_state): New.
3690         (cpstate): New global.
3691         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3692         (nonempty_typelist): Update.
3693         (func_mod): Create a new vector.
3694         (c_parse): Create a c_parse_state.
3695         (check_parameter_typelist): Do not delete params.
3696         (function_method): Update.  Do not delete type_list.
3697
3698 2019-01-06  Tom Tromey  <tom@tromey.com>
3699
3700         PR gdb/28155:
3701         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3702         check_typedef.
3703         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3704         (print_return_value): Likewise.
3705
3706 2019-01-05  Tom Tromey  <tom@tromey.com>
3707
3708         * contrib/cleanup_check.py: Remove.
3709         * contrib/gcc-with-excheck: Remove.
3710         * contrib/exsummary.py: Remove.
3711         * contrib/excheck.py: Remove.
3712
3713 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3714
3715         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3716         NULL. Initialize tpprev to NULL instead of assigning it
3717         to NULL on the next statement.
3718         * windows-nat.c (windows_delete_thread): Remove check for
3719         main_thread_id before printing thread exit notifications.
3720         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3721         Remove thread ID check against main_thread_id.
3722         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3723         windows_delete_thread.
3724         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3725
3726 2019-01-04  Tom Tromey  <tom@tromey.com>
3727
3728         * compile/compile.c (_initialize_compile): Use upper case for
3729         metasyntactic variables.
3730         * symmisc.c (_initialize_symmisc): Use upper case for
3731         metasyntactic variables.
3732         * psymtab.c (_initialize_psymtab): Use upper case for
3733         metasyntactic variables.
3734         * demangle.c (demangle_command): Use upper case for metasyntactic
3735         variables.
3736         (_initialize_demangler): Likewise.
3737         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3738         variables.
3739
3740 2019-01-03  Tom Tromey  <tom@tromey.com>
3741
3742         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3743
3744 2019-01-03  Tom Tromey  <tom@tromey.com>
3745
3746         * python/py-symtab.c (salpy_str): Update.
3747         (struct salpy_sal_object) <symtab>: Now a PyObject.
3748         (salpy_dealloc): Update.
3749         (del_objfile_sal): Use gdbpy_ref.
3750
3751 2019-01-03  Tom Tromey  <tom@tromey.com>
3752
3753         * python/py-type.c (convert_field): Use new_reference.  Return
3754         gdbpy_ref.
3755         (make_fielditem): Return gdbpy_ref.
3756         (typy_fields): Update.
3757         (typy_getitem): Update.
3758         (field_name): Return gdbpy_ref.  Use new_reference.
3759         (typy_iterator_iternext): Update.
3760
3761 2019-01-03  Tom Tromey  <tom@tromey.com>
3762
3763         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3764
3765 2019-01-03  Tom Tromey  <tom@tromey.com>
3766
3767         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3768         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3769         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3770         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3771         (pspy_set_type_printers): Likewise.
3772         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3773         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3774         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3775         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3776         (objfpy_set_type_printers): Likewise.
3777
3778 2019-01-03  Tom Tromey  <tom@tromey.com>
3779
3780         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3781         (gdbpy_print_stack): Use gdbpy_err_fetch.
3782         * python/python-internal.h (class gdbpy_err_fetch): New class.
3783         (class gdbpy_enter) <m_error_type, m_error_value,
3784         m_error_traceback>: Remove.
3785         <m_error>: New member.
3786         (gdbpy_exception_to_string): Don't declare.
3787         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3788         * python/py-value.c (convert_value_from_python): Use
3789         gdbpy_err_fetch.
3790         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3791         gdbpy_exception_to_string.
3792         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3793         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3794         gdbpy_err_fetch.
3795
3796 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3797
3798         * linux-nat.c (delete_lwp_cleanup): Delete.
3799         (struct lwp_deleter): New struct.
3800         (lwp_info_up): New typedef.
3801         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3802         lwp_info_up.
3803
3804 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3805
3806         * linux-fork.c (class scoped_switch_fork_info): New class.
3807         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3808
3809 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3810
3811         * valops.c (find_overload_match): Remove use of null_cleanup, and
3812         calls to do_cleanups.
3813
3814 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3815
3816         * compile/compile-cplus-types.c
3817         (compile_cplus_instance::decl_name): Handle changes to
3818         cp_func_name.
3819         * cp-support.c (cp_func_name): Update header comment, update
3820         return type.
3821         * cp-support.h (cp_func_name): Update return type in declaration.
3822         * valops.c (find_overload_match): Move temp_func local to top
3823         level of function and change its type.  Use temp_func to hold and
3824         delete temporary string obtained from cp_func_name.
3825
3826 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3827
3828         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3829         gdb::char_vector, remove cleanup, and update uses of `msg`.
3830
3831 2019-01-03  Jim Wilson  <jimw@sifive.com>
3832
3833         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3834
3835 2019-01-02  Tom Tromey  <tom@tromey.com>
3836
3837         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3838         (tdesc_parse_xml): Remove cleanups.
3839         * target-descriptions.h (make_cleanup_free_target_description):
3840         Don't declare.
3841         (target_desc_deleter): New struct.
3842         (target_desc_up): New typedef.
3843         * target-descriptions.c (target_desc_deleter::operator()): Rename
3844         from free_target_description.
3845         (make_cleanup_free_target_description): Remove.
3846
3847 2019-01-02  Tom Tromey  <tom@tromey.com>
3848
3849         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3850         constructor, destructor.
3851         (linespec_parser): Remove typedef.
3852         (~linespec_parser): Rename from linespec_parser_delete.
3853         (linespec_lex_to_end, linespec_complete_label)
3854         (linespec_complete): Update.
3855         (decode_line_full): Remove cleanups.
3856         (decode_line_1): Update.
3857
3858 2019-01-02  Tom Tromey  <tom@tromey.com>
3859
3860         * python/python-internal.h (inferior_to_inferior_object): Change
3861         return type.
3862         * python/py-exitedevent.c (create_exited_event_object): Update.
3863         * python/py-inferior.c (inferior_to_inferior_object): Return
3864         gdbpy_ref.
3865         (python_new_inferior, python_inferior_deleted)
3866         (thread_to_thread_object, delete_thread_object)
3867         (build_inferior_list, gdbpy_selected_inferior): Update.
3868         * python/py-infthread.c (create_thread_object): Update.  Also fail
3869         if inferior_to_inferior_object fails.
3870
3871 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3872
3873         * inferior.h (class inferior) <displaced_step_state>: New field.
3874         * infrun.h (struct displaced_step_state): Move here from
3875         infrun.c.  Initialize fields, add constructor.
3876         <inf>: Remove field.
3877         <reset>: New method.
3878         * infrun.c (struct displaced_step_inferior_state): Move to
3879         infrun.h.
3880         (displaced_step_inferior_states): Remove.
3881         (get_displaced_stepping_state): Adust.
3882         (displaced_step_in_progress_any_inferior): Adjust.
3883         (displaced_step_in_progress_thread): Adjust.
3884         (displaced_step_in_progress): Adjust.
3885         (add_displaced_stepping_state): Remove.
3886         (get_displaced_step_closure_by_addr): Adjust.
3887         (remove_displaced_stepping_state): Remove.
3888         (infrun_inferior_exit): Call displaced_step_state.reset.
3889         (use_displaced_stepping): Don't check for NULL.
3890         (displaced_step_prepare_throw): Call
3891         get_displaced_stepping_state.
3892         (displaced_step_fixup): Don't check for NULL.
3893         (prepare_for_detach): Don't check for NULL.
3894
3895 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3896
3897         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3898          in case of call that did not complete.
3899
3900 2019-01-02  Andrey Utkin  <autkin@undo.io>
3901
3902         * symfile.c (find_separate_debug_file): Fix search of debug files for
3903         remote debuggee.
3904
3905 2019-01-02  Tom Tromey  <tom@tromey.com>
3906
3907         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3908         indentation.
3909         * python/py-frame.c (frapy_older): Remove cast.
3910         (frapy_newer): Likewise.
3911         * python/py-breakpoint.c (local_setattro): Remove cast.
3912         * python/py-arch.c (archpy_name): Remove local variable.
3913         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3914
3915 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3916
3917         * unittests/basic_string_view/element_access/char/empty.cc:
3918         Fix year range in copyright header.
3919
3920 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3921
3922         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3923         Delete.
3924         <operator==>: Update with for removed field.
3925         <hash>: Likewise.
3926         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3927         <isa_features>: ...this.
3928         <abi_features>: New field.
3929         (riscv_isa_flen): Update comment.
3930         (riscv_abi_xlen): New declaration.
3931         (riscv_abi_flen): New declaration.
3932         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3933         isa_features.
3934         (riscv_abi_xlen): New function.
3935         (riscv_isa_flen): Update to get answer from isa_features.
3936         (riscv_abi_flen): New function.
3937         (riscv_has_fp_abi): Update to get answer from abi_features.
3938         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3939         xlen and flen.
3940         (riscv_call_info) <xlen, flen>: Update comment.
3941         (riscv_call_arg_struct): Remove invalid assertions
3942         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3943         is removed.
3944         (riscv_gdbarch_init): Gather isa features and abi features
3945         separately, ensure both match on the gdbarch when reusing an old
3946         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3947         a target with 64-bit float hardware.
3948
3949 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3950
3951         * source.c (search_command_helper): Stop reverse search
3952         when line 1 has been searched.
3953
3954 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3955
3956         * record-full.c (record_full_base_target::close): Rewrite
3957         record_full_core_buf_list free logic.
3958
3959 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3960
3961         * break-catch-syscall.c (print_one_catch_syscall): xfree
3962         the last text.
3963
3964 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3965
3966         * top.c (print_gdb_version): Update Copyright year in version
3967         message.
3968
3969 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3970
3971         Update copyright year range in all GDB files.
3972
3973 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3974
3975         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3976
3977 For older changes see ChangeLog-2018.
3978 \f
3979 Local Variables:
3980 mode: change-log
3981 left-margin: 8
3982 fill-column: 74
3983 version-control: never
3984 coding: utf-8
3985 End:
3986