gdb/ChangeLog

   1 2019-01-25  Tom Tromey  <tom@tromey.com>
   2
   3         * common/create-version.sh: Use common/version.h.
   4
   5 2019-01-24  Pedro Alves  <palves@redhat.com>
   6
   7         * infrun.c (signal_stop, signal_print, signal_program)
   8         (signal_catch, signal_pass): Now arrays instead of pointers.
   9         (update_signals_program_target, do_target_resume)
  10         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
  11         * linux-nat.c (linux_nat_target::pass_signals)
  12         (linux_nat_target::create_inferior, linux_nat_target::attach):
  13         Adjust.
  14         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
  15         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
  16         * procfs.c (procfs_target::pass_signals): Adjust.
  17         * record-full.c (record_full_target::resume): Adjust.
  18         * remote.c (remote_target::pass_signals)
  19         (remote_target::program_signals): Adjust.
  20         * target-debug.h (target_debug_print_signals): Now takes a
  21         gdb::array_view as parameter.  Adjust.
  22         * target.h (target_ops) <pass_signals, program_signals>: Replace
  23         pointer and length parameters with gdb::array_view.
  24         (target_pass_signals, target_program_signals): Likewise.
  25         * target-delegates.c: Regenerate.
  26
  27 2019-01-24  Pedro Alves  <palves@redhat.com>
  28
  29         * common/forward-scope-exit.h
  30         (forward_scope_exit::forward_scope_exit): Pass arguments to
  31         m_bind_function directly, instead of creating a std::bind and
  32         copying that.
  33
  34 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
  35
  36         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  37         for static members.
  38         (pass_in_v_vfp_candidate): Likewise.
  39
  40 2019-01-23  Tom Tromey  <tom@tromey.com>
  41             Pedro Alves  <palves@redhat.com>
  42
  43         * regcache.c (class regcache_invalidator): Remove.
  44         (regcache::raw_write): Use make_scope_exit.
  45
  46 2019-01-23  Tom Tromey  <tom@tromey.com>
  47
  48         * ui-out.h (class ui_out_emit_type): Update comment.
  49
  50 2019-01-23  Tom Tromey  <tom@tromey.com>
  51
  52         * infrun.c (fetch_inferior_event): Update comment.
  53
  54 2019-01-23  Tom Tromey  <tom@tromey.com>
  55             Pedro Alves  <palves@redhat.com>
  56
  57         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
  58         parameter.
  59         (fetch_inferior_event): Use SCOPE_EXIT.
  60
  61
  62 2019-01-23  Tom Tromey  <tom@tromey.com>
  63             Pedro Alves  <palves@redhat.com>
  64
  65         * infrun.c (disable_thread_events): Delete.
  66         (stop_all_threads): Use SCOPE_EXIT.
  67
  68 2019-01-23  Tom Tromey  <tom@tromey.com>
  69             Pedro Alves  <palves@redhat.com>
  70
  71         * symfile.c: Include forward-scope-exit.h.
  72         (clear_symtab_users_cleanup): Replace forward declaration with
  73         a FORWARD_SCOPE_EXIT.
  74         (syms_from_objfile_1): Use the forward_scope_exit and
  75         gdb::optional instead of cleanup_function.
  76         (reread_symbols): Use the forward_scope_exit instead of
  77         cleanup_function.
  78         (clear_symtab_users_cleanup): Remove function.
  79
  80 2019-01-23  Tom Tromey  <tom@tromey.com>
  81             Pedro Alves  <palves@redhat.com>
  82
  83         * linux-nat.c: Include scope-exit.h.
  84         (cleanup_target_stop): Remove.
  85         (linux_nat_target::static_tracepoint_markers_by_strid): Use
  86         SCOPE_EXIT.
  87
  88 2019-01-23  Tom Tromey  <tom@tromey.com>
  89             Pedro Alves  <palves@redhat.com>
  90
  91         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
  92         (call_function_by_hand_dummy): Use SCOPE_EXIT.
  93
  94 2019-01-23  Tom Tromey  <tom@tromey.com>
  95             Andrew Burgess  <andrew.burgess@embecosm.com>
  96             Pedro Alves  <palves@redhat.com>
  97
  98         * infrun.c (fetch_inferior_event): Use scope_exit.
  99         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 100         * top.c (execute_command): Use scope_exit.
 101         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 102         * utils.c (do_bpstat_clear_actions_cleanup)
 103         (make_bpstat_clear_actions_cleanup): Remove.
 104
 105 2019-01-23  Tom Tromey  <tom@tromey.com>
 106             Pedro Alves  <palves@redhat.com>
 107
 108         * infrun.c: Include "common/scope-exit.h"
 109         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 110         (wait_for_inferior): Use SCOPE_EXIT.
 111         (fetch_inferior_event): Use scope_exit.
 112
 113 2019-01-23  Tom Tromey  <tom@tromey.com>
 114             Pedro Alves  <palves@redhat.com>
 115
 116         * breakpoint.c (create_breakpoint): Remove cleanup.
 117
 118 2019-01-23  Tom Tromey  <tom@tromey.com>
 119             Andrew Burgess  <andrew.burgess@embecosm.com>
 120             Pedro Alves  <palves@redhat.com>
 121
 122 2019-01-23  Pedro Alves  <palves@redhat.com>
 123
 124         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 125
 126 2019-01-23  Pedro Alves  <palves@redhat.com>
 127             Andrew Burgess  <andrew.burgess@embecosm.com>
 128
 129         * gdbthread.h: Include "common/forward-scope-exit.h".
 130         (scoped_finish_thread_state): Redefine custom class in terms of
 131         forward_scope_exit.
 132
 133 2019-01-23  Pedro Alves  <palves@redhat.com>
 134             Andrew Burgess  <andrew.burgess@embecosm.com>
 135
 136         * common/forward-scope-exit.h: New file.
 137
 138 2019-01-23  Pedro Alves  <palves@redhat.com>
 139             Andrew Burgess  <andrew.burgess@embecosm.com>
 140             Tom Tromey  <tom@tromey.com>
 141
 142         * common/scope-exit.h: New file.
 143
 144 2019-01-23  Pedro Alves  <palves@redhat.com>
 145
 146         * common/preprocessor.h (ESC): Rename to ...
 147         (ESC_PARENS): ... this.
 148         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 149         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 150
 151 2019-01-23  Tom Tromey  <tom@tromey.com>
 152
 153         * language.h (class scoped_switch_to_sym_language_if_auto):
 154         Initialize m_lang in both cases.
 155
 156 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 157
 158         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 159         with XCNEW.
 160
 161 2019-01-22  Tom Tromey  <tom@tromey.com>
 162
 163         * corelow.c: Do not include sys/file.h.
 164
 165 2019-01-22  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-wingeneral.h: Include gdb_curses.h.
 168
 169 2019-01-22  Tom Tromey  <tom@tromey.com>
 170
 171         * source-cache.h (class source_cache) <get_source_lines,
 172         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 173
 174 2019-01-22  Tom Tromey  <tom@tromey.com>
 175
 176         * remote-fileio.h (struct remote_target): Declare.
 177
 178 2019-01-22  Tom Tromey  <tom@tromey.com>
 179
 180         * python/py-arch.c: Do not include py-ref.h.
 181         * python/py-bpevent.c: Do not include py-ref.h.
 182         * python/py-cmd.c: Do not include py-ref.h.
 183         * python/py-continueevent.c: Do not include py-ref.h.
 184         * python/py-event.h: Do not include py-ref.h.
 185         * python/py-evtregistry.c: Do not include py-ref.h.
 186         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 187         * python/py-frame.c: Do not include py-ref.h.
 188         * python/py-framefilter.c: Do not include py-ref.h.
 189         * python/py-function.c: Do not include py-ref.h.
 190         * python/py-infevents.c: Do not include py-ref.h.
 191         * python/py-linetable.c: Do not include py-ref.h.
 192         * python/py-objfile.c: Do not include py-ref.h.
 193         * python/py-param.c: Do not include py-ref.h.
 194         * python/py-prettyprint.c: Do not include py-ref.h.
 195         * python/py-progspace.c: Do not include py-ref.h.
 196         * python/py-symbol.c: Do not include py-ref.h.
 197         * python/py-symtab.c: Do not include py-ref.h.
 198         * python/py-type.c: Do not include py-ref.h.
 199         * python/py-unwind.c: Do not include py-ref.h.
 200         * python/py-utils.c: Do not include py-ref.h.
 201         * python/py-value.c: Do not include py-ref.h.
 202         * python/py-varobj.c: Do not include py-ref.h.
 203         * python/py-xmethods.c: Do not include py-ref.h.
 204         * python/python.c: Do not include py-ref.h.
 205         * varobj.c: Do not include py-ref.h.
 206
 207 2019-01-22  Tom Tromey  <tom@tromey.com>
 208
 209         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 210         keyword for bcache.
 211
 212 2019-01-22  Tom Tromey  <tom@tromey.com>
 213
 214         * compile/compile-cplus-types.c: Remove a comment by #include.
 215
 216 2019-01-22  Tom Tromey  <tom@tromey.com>
 217
 218         * compile/gcc-c-plugin.h: Include compile-internal.h.
 219
 220 2019-01-22  Tom Tromey  <tom@tromey.com>
 221
 222         * stabsread.c (EXTERN): Do not define.
 223         (symnum, next_symbol_text_func, processing_gcc_compilation)
 224         (within_function, global_sym_chain, global_stabs)
 225         (previous_stab_code, this_object_header_files)
 226         (n_this_object_header_files)
 227         (n_allocated_this_object_header_files): Define.
 228         * stabsread.h (EXTERN): Never define.  Use "extern".
 229
 230 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 231
 232         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 233         history_value.
 234
 235 2019-01-21  Tom Tromey  <tom@tromey.com>
 236
 237         * ui-out.c: Fix includes.
 238         * tui/tui-source.c: Fix includes.
 239         * target.c: Fix includes.
 240         * remote.c: Fix includes.
 241         * regcache.c: Fix includes.
 242         * python/py-block.c: Fix includes.
 243         * printcmd.c: Fix includes.
 244         * or1k-tdep.c: Fix includes.
 245         * mi/mi-main.c: Fix includes.
 246         * m32r-tdep.c: Fix includes.
 247         * csky-tdep.c: Fix includes.
 248         * compile/compile-cplus-types.c: Fix includes.
 249         * cli/cli-interp.c: Fix includes.
 250
 251 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 252
 253         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 254         for padding.
 255
 256 2019-01-16  Tom Tromey  <tom@tromey.com>
 257
 258         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 259         earlier.
 260         (struct objfile) <msymbols_range>: Move from top level.
 261         <msymbols>: New method.
 262         (class objfile_msymbols): Remove.
 263         * symtab.c (default_collect_symbol_completion_matches_break_on):
 264         Update.
 265         * symmisc.c (dump_msymbols): Update.
 266         * stabsread.c (scan_file_globals): Update.
 267         * objc-lang.c (info_selectors_command, info_classes_command)
 268         (find_methods): Update.
 269         * minsyms.c (find_solib_trampoline_target): Update.
 270         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 271         * coffread.c (coff_symfile_read): Update.
 272         * ada-lang.c (ada_lookup_simple_minsym)
 273         (ada_collect_symbol_completion_matches): Update.
 274
 275 2019-01-16  Tom Tromey  <tom@tromey.com>
 276
 277         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 278         type.  Remove no-argument constructor.
 279         <iterator::operator++>: Simplify.
 280         <begin>: Update.
 281         <end>: Use minimal_symbol_count.
 282
 283 2019-01-16  Tom Tromey  <tom@tromey.com>
 284
 285         * objfiles.h (struct objfile) <psymtabs>: New method.
 286         (class objfile_psymtabs): Remove.
 287         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 288         typedef.
 289         <range>: New method.
 290         (require_partial_symbols): Change return type.
 291         * psymtab.c (require_partial_symbols)
 292         (psym_expand_symtabs_matching): Update.
 293         * mdebugread.c (parse_partial_symbols): Update.
 294         * dbxread.c (dbx_end_psymtab): Update.
 295
 296 2019-01-15  Tom Tromey  <tom@tromey.com>
 297
 298         * symtab.c (lookup_objfile_from_block)
 299         (lookup_symbol_in_objfile_symtabs)
 300         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 301         (find_line_symtab, info_sources_command)
 302         (default_collect_symbol_completion_matches_break_on)
 303         (make_source_files_completion_list): Update.
 304         * symmisc.c (print_objfile_statistics, dump_objfile)
 305         (maintenance_print_symbols, maintenance_info_symtabs)
 306         (maintenance_check_symtabs, maintenance_info_line_tables):
 307         Update.
 308         * source.c (select_source_symtab)
 309         (forget_cached_source_info_for_objfile): Update.
 310         * objfiles.h (class objfile_compunits): Remove.
 311         (struct objfile) <compunits_range>: New typedef.
 312         (compunits): New method.
 313         * objfiles.c (objfile_relocate1): Update.
 314         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 315         * maint.c (count_symtabs_and_blocks): Update.
 316         * linespec.c (iterate_over_all_matching_symtabs): Update.
 317         * cp-support.c (add_symbol_overload_list_qualified): Update.
 318         * coffread.c (coff_symtab_read): Update.
 319         * ada-lang.c (add_nonlocal_symbols)
 320         (ada_collect_symbol_completion_matches)
 321         (ada_add_global_exceptions): Update.
 322
 323 2019-01-15  Tom Tromey  <tom@tromey.com>
 324
 325         * progspace.h (program_space) <objfiles_safe_range>: New
 326         typedef.
 327         <objfiles_safe>: New method.
 328         * objfiles.h (class all_objfiles_safe): Remove.
 329         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 330         * jit.c (jit_inferior_exit_hook): Update.
 331
 332 2019-01-17  Tom Tromey  <tom@tromey.com>
 333
 334         * progspace.h (program_space) <objfiles_range>: New typedef.
 335         <objfiles>: New method.
 336         <objfiles_head>: Rename from objfiles.
 337         (object_files): Update.
 338         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 339         * guile/scm-pretty-print.c
 340         (ppscm_find_pretty_printer_from_objfiles): Update.
 341         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 342         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 343         Update.
 344         * python/py-progspace.c (pspy_get_objfiles): Update.
 345         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 346         Update.
 347         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 348         (objfpy_lookup_objfile_by_build_id): Update.
 349         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 350         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 351         Update.
 352         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 353         (expand_symtab_containing_pc, lookup_objfile_from_block)
 354         (lookup_static_symbol, basic_lookup_transparent_type)
 355         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 356         (find_line_symtab, info_sources_command)
 357         (default_collect_symbol_completion_matches_break_on)
 358         (make_source_files_completion_list, find_main_name): Update.
 359         * symmisc.c (print_symbol_bcache_statistics)
 360         (print_objfile_statistics, maintenance_print_symbols)
 361         (maintenance_print_msymbols, maintenance_print_objfiles)
 362         (maintenance_info_symtabs, maintenance_check_symtabs)
 363         (maintenance_expand_symtabs, maintenance_info_line_tables):
 364         Update.
 365         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 366         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 367         (map_overlay_command, unmap_overlay_command)
 368         (simple_overlay_update, expand_symtabs_matching)
 369         (map_symbol_filenames): Update.
 370         * symfile-debug.c (set_debug_symfile): Update.
 371         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 372         Update.
 373         * source.c (select_source_symtab, forget_cached_source_info):
 374         Update.
 375         * solib.c (solib_read_symbols): Update.
 376         * solib-spu.c (append_ocl_sos): Update.
 377         * psymtab.c (maintenance_print_psymbols)
 378         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 379         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 380         * printcmd.c (info_symbol_command): Update.
 381         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 382         Update.
 383         * objfiles.h (class all_objfiles): Remove.
 384         * objfiles.c (have_partial_symbols, have_full_symbols)
 385         (have_minimal_symbols, qsort_cmp, update_section_map)
 386         (shared_objfile_contains_address_p)
 387         (default_iterate_over_objfiles_in_search_order): Update.
 388         * objc-lang.c (info_selectors_command, info_classes_command)
 389         (find_methods): Update.
 390         * minsyms.c (find_solib_trampoline_target): Update.
 391         * maint.c (maintenance_info_sections)
 392         (maintenance_translate_address, count_symtabs_and_blocks):
 393         Update.
 394         * main.c (captured_main_1): Update.
 395         * linux-thread-db.c (try_thread_db_load_from_pdir)
 396         (has_libpthread): Update.
 397         * linespec.c (iterate_over_all_matching_symtabs)
 398         (search_minsyms_for_name): Update.
 399         * jit.c (jit_find_objf_with_entry_addr): Update.
 400         * hppa-tdep.c (find_unwind_entry)
 401         (hppa_lookup_stub_minimal_symbol): Update.
 402         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 403         Update.
 404         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 405         (elf_gnu_ifunc_resolve_by_got): Update.
 406         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 407         * dwarf-index-write.c (save_gdb_index_command): Update.
 408         * cp-support.c (add_symbol_overload_list_qualified): Update.
 409         * breakpoint.c (create_overlay_event_breakpoint)
 410         (create_longjmp_master_breakpoint)
 411         (create_std_terminate_master_breakpoint)
 412         (create_exception_master_breakpoint): Update.
 413         * blockframe.c (find_pc_partial_function): Update.
 414         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 415         (ada_collect_symbol_completion_matches)
 416         (ada_add_global_exceptions): Update.
 417
 418 2019-01-17  Tom Tromey  <tom@tromey.com>
 419
 420         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 421         declare VEC.
 422         (solib_target_parse_libraries): Change return type.
 423         (library_list_start_segment, library_list_start_section)
 424         (library_list_end_library, library_list_start_library); Update.
 425         (solib_target_free_library_list): Remove.
 426         (solib_target_parse_libraries): Remove cleanup.  Change return
 427         type.
 428         (solib_target_current_sos): Update.
 429
 430 2019-01-17  Tom Tromey  <tromey@bapiya>
 431
 432         * valprint.c: Replace "the the" with "the".
 433         * symtab.c: Replace "the the" with "the".
 434         * solib.c: Replace "the the" with "the".
 435         * solib-dsbt.c: Replace "the the" with "the".
 436         * linespec.c: Replace "the the" with "the".
 437         * dwarf2loc.h: Replace "the the" with "the".
 438         * amd64-windows-tdep.c: Replace "the the" with "the".
 439         * aarch64-tdep.c: Replace "the the" with "the".
 440
 441 2019-01-16  Keith Seitz  <keiths@redhat.com>
 442
 443         PR gdb/23773
 444         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 445         <builder>: Rename to ..
 446         <m_builder>: ... this and make private.
 447         (dwarf2_cu::get_builder): New method.  Change all users of
 448         `builder' to use this method.
 449         (dwarf2_start_symtab): Move to ...
 450         (dwarf2_cu::start_symtab): ... here.  Update all callers
 451         (setup_type_unit_groups): Move to ...
 452         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 453         callers.
 454         (dwarf2_cu::reset_builder): New method.
 455         (process_full_compunit, process_full_type_unit): Use
 456         dwarf2_cu::reset_builder.
 457         (follow_die_offset): Record the ancestor CU if it is different
 458         from the followed DIE's CU.
 459         (follow_die_sig_1): Likewise.
 460
 461 2019-01-15  Tom Tromey  <tom@tromey.com>
 462
 463         * remote.c (class remote_state) <buf>: Now a char_vector.
 464         <buf_size>: Remove.
 465         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 466         parameter.
 467         (remote_target::getpkt_or_notif_sane_1)
 468         (remote_target::getpkt_sane)
 469         (remote_target::getpkt_or_notif_sane): Likewise.
 470         (class remote_target) <putpkt>: New overload.
 471         (remote_target::read_frame): Change type of "buf_p".  Remove
 472         sizeof_p parameter.
 473         (packet_ok): New overload.
 474         (packet_check_result): New overload.
 475         Update all uses.
 476
 477 2019-01-14  Tom Tromey  <tom@tromey.com>
 478
 479         * remote-notif.c (handle_notification, remote_notif_ack)
 480         (remote_notif_parse): Make "buf" const.
 481         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 482         const.
 483         (remote_notif_parse, remote_notif_ack, handle_notification):
 484         Likewise.
 485         * remote.c (remote_notif_stop_parse): Make "buf" const.
 486         (remote_target::remote_parse_stop_reply): Make "buf" const.
 487         (remote_notif_stop_ack): Make "buf" const.
 488
 489 2019-01-14  Tom Tromey  <tom@tromey.com>
 490
 491         * remote.c (remote_console_output): Make parameter const.
 492
 493 2019-01-14  Tom Tromey  <tom@tromey.com>
 494
 495         * target-debug.h (target_debug_print_signals): Constify.
 496         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 497         * procfs.c (procfs_target::pass_signals): Update.
 498         * linux-nat.c (linux_nat_target::pass_signals): Update.
 499         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 500         * target-delegates.c: Rebuild.
 501         * remote.c (remote_target::program_signals): Update.
 502         (remote_target::pass_signals): Update.
 503         * target.c (target_pass_signals): Constify argument.
 504         (target_program_signals): Likewise.
 505         * target.h (struct target_ops) <pass_signals, program_signals>:
 506         Constify argument.
 507         (target_pass_signals, target_program_signals): Constify argument.
 508
 509 2019-01-14  Tom Tromey  <tom@tromey.com>
 510
 511         PR tui/28819:
 512         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 513
 514 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 515
 516         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 517         field.
 518         * rs6000-tdep.c: Include reggroups.h.
 519         (IS_V_ALIAS_PSEUDOREG): Define.
 520         (rs6000_register_name): Return names for the "vX" aliases.
 521         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 522         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 523         aliases.  Call default_register_reggroup_p for all other
 524         pseudo-registers.
 525         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 526         New functions.
 527         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 528         Handle "vX" aliases.
 529         (v_alias_pseudo_register_collect): New function.
 530         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 531         (rs6000_gdbarch_init): Initialize "vX" aliases as
 532         pseudo-registers.  Restore registration of
 533         rs6000_pseudo_register_reggroup_p with
 534         set_tdesc_pseudo_register_reggroup_p.
 535
 536 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 537
 538         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 539         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 540         set_gdbarch_num_pseudo_regs.
 541
 542 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 543
 544         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 545         Remove arg prefixname, add do_set and do_show.
 546         Add member functions set_list and show_list.
 547         * cli/cli-style.c (class cli_style_option): Update accordingly.
 548         (style_set_list): Move to file scope.
 549         (style_show_list): Likewise.
 550         (set_style): Call help_list.
 551         (show_style): Call cmd_show_list.
 552         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 553         Update to use the new macro.
 554
 555 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 556
 557         * ada-lang.c (_initialize_ada_language): Expand the help text
 558         for the "catch exception" command.
 559
 560 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 561
 562         * symtab.c (matching_obj_sections): Initialize obj,
 563         declare it closer to its usage.
 564
 565 2019-01-10  Tom Tromey  <tom@tromey.com>
 566
 567         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 568         (basic_inf_threads_range): Remove.
 569         (inf_threads_range, inf_non_exited_threads_range)
 570         (safe_inf_threads_range): Use next_adapter.
 571
 572 2019-01-10  Keith Seitz  <keiths@redhat.com>
 573
 574         PR gdb/23712
 575         PR symtab/23010
 576         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 577         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 578
 579 2019-01-10  Keith Seitz  <keiths@redhat.com>
 580
 581         PR gdb/23712
 582         PR symtab/23010
 583         * dictionary.c (pending_to_vector): Remove.
 584         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 585         Remove _1 suffix, replacing functions of the same name.  Update
 586         all callers.
 587         (dict_create_hashed, dict_create_hashed_expandable)
 588         (dict_create_linear, dict_create_linear_expandable, dict_free)
 589         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 590         Make functions static.
 591
 592 2019-01-10  Keith Seitz  <keiths@redhat.com>
 593
 594         PR gdb/23712
 595         PR symtab/23010
 596         * dictionary.h (struct dictionary): Replace declaration with
 597         multidictionary.
 598         (dict_create_hashed, dict_create_hashed_expandable)
 599         (dict_create_linear, dict_create_linear_expandable)
 600         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 601         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 602         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 603         taking multidictionary argument.
 604         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 605         * block.h (struct block) <dict>: Change to multidictionary
 606         and rename `multidict'.
 607         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 608         symmisc.c: Update all dictionary references to multidictionary.
 609
 610 2019-01-10  Keith Seitz  <keiths@redhat.com>
 611
 612         PR gdb/23712
 613         PR symtab/23010
 614         * dictionary.c: Include unordered_map.
 615         (pending_to_vector): New function.
 616         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 617         Rewrite the non-"_1" functions to take vector instead
 618         of linked list.
 619         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 620         "new" _1 versions of the same name.
 621         (multidictionary): Define.
 622         (std::hash<enum language): New definition.
 623         (collate_pending_symbols_by_language, mdict_create_hashed)
 624         (mdict_create_hashed_expandable, mdict_create_linear)
 625         (mdict_create_linear_expandable, mdict_free)
 626         (find_language_dictionary, create_new_language_dictionary)
 627         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 628         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 629         (mdict_size, mdict_empty): New functions.
 630         * dictionary.h (mdict_iterator): Define.
 631
 632 2019-01-10  Pedro Alves  <palves@redhat.com>
 633
 634         * breakpoint.c (read_uploaded_action)
 635         (create_tracepoint_from_upload): Adjust to use
 636         gdb::unique_xmalloc_ptr.
 637         * ctf.c (ctf_write_uploaded_tp):
 638         (SET_ARRAY_FIELD): Use emplace_back.
 639         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 640         * tracefile-tfile.c (tfile_write_uploaded_tp):
 641         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 642         gdb::unique_xmalloc_ptr.
 643         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 644         at_string, cond_string, cmd_strings>: Replace char pointers
 645         with gdb::unique_xmalloc_ptr.
 646
 647 2019-01-10  Pedro Alves  <palves@redhat.com>
 648
 649         * solib-target.c (library_list_start_library): Don't xstrdup name.
 650
 651 2019-01-10  Pedro Alves  <palves@redhat.com>
 652
 653         * mdebugread.c (parse_partial_symbols): Use
 654         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 655
 656 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 657
 658         * linux-fork.c (scoped_switch_fork_info)
 659         <~scoped_switch_fork_info>: Fix incorrect variable name.
 660
 661 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 662
 663         * linux-fork.c (scoped_switch_fork_info)
 664         <scoped_switch_fork_info>: Make explicit.
 665         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 666
 667 2019-01-10  Tom Tromey  <tom@tromey.com>
 668
 669         * objfiles.h (objfile::reset_psymtabs): Update.
 670         * objfiles.c (objfile::objfile): Update.
 671         * psymtab.h (psymtab_storage::obstack): Update.
 672         (psymtab_storage::m_obstack): Use gdb::optional.
 673         (class psymtab_storage): Update comment.  Remove objfile
 674         parameter.
 675         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 676
 677 2019-01-10  Tom Tromey  <tom@tromey.com>
 678
 679         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 680         <free_psymtabs>: Now private.
 681         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 682         (allocate_psymtab): Use new method.
 683
 684 2019-01-10  Tom Tromey  <tom@tromey.com>
 685
 686         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 687         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 688         * mdebugread.c (parse_partial_symbols): Use
 689         allocate_dependencies.
 690         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 691         allocate_dependencies.
 692         (process_psymtab_comp_unit_reader)
 693         (build_type_psymtab_dependencies): Likewise.
 694         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 695
 696 2019-01-10  Tom Tromey  <tom@tromey.com>
 697
 698         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 699         PSYMBOL_SET_LANGUAGE.
 700         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 701
 702 2019-01-10  Tom Tromey  <tom@tromey.com>
 703
 704         * psymtab.h (psymtab_storage::obstack): New method.
 705         <m_obstack>: Rename from obstack; now private.
 706         * psymtab.c (psymtab_storage): Update.
 707         * dwarf2read.c (create_addrmap_from_index)
 708         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 709         Update.
 710
 711 2019-01-10  Tom Tromey  <tom@tromey.com>
 712
 713         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 714         * objfiles.h (objfile::reset_psymtabs): New method.
 715
 716 2019-01-10  Tom Tromey  <tom@tromey.com>
 717
 718         * symmisc.c (print_symbol_bcache_statistics): Update.
 719         (print_objfile_statistics): Update.
 720         * symfile.c (reread_symbols): Update.
 721         * psymtab.h (class psymtab_storage): New.
 722         * psymtab.c (psymtab_storage): New constructor.
 723         (~psymtab_storage): New destructor.
 724         (require_partial_symbols): Update.
 725         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 726         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 727         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 728         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 729         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 730         (start_psymtab_common, end_psymtab_common)
 731         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 732         (allocate_psymtab): Update.
 733         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 734         Update.
 735         (dump_psymtab_addrmap, maintenance_print_psymbols)
 736         (maintenance_check_psymtabs): Update.
 737         (class objfile_psymtabs): Move to objfiles.h.
 738         * psympriv.h (discard_psymtab): Now inline.
 739         (psymtab_discarder::psymtab_discarder): Update.
 740         (psymtab_discarder::~psymtab_discarder): Update.
 741         (ALL_OBJFILE_PSYMTABS): Rewrite.
 742         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 743         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 744         Remove fields.
 745         <partial_symtabs>: New field.
 746         (class objfile_psymtabs): Move from psymtab.h.  Update.
 747         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 748         psymbol_cache.
 749         (objfile::~objfile): Don't destroy psymbol_cache.
 750         * mdebugread.c (parse_partial_symbols): Update.
 751         * dwarf2read.c (create_addrmap_from_index)
 752         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 753         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 754         (add_partial_subprogram, dwarf2_ranges_read): Update.
 755         * dwarf-index-write.c (write_address_map)
 756         (write_one_signatured_type, recursively_write_psymbols)
 757         (class debug_names, class debug_names, write_psymtabs_to_index):
 758         Update.
 759
 760 2019-01-10  Tom Tromey  <tom@tromey.com>
 761
 762         * symtab.h (SYMBOL_SET_NAMES): Update.
 763         (symbol_set_names): Update.
 764         (MSYMBOL_SET_NAMES): Update.
 765         * symtab.c (symbol_set_names): Change argument to be an
 766         objfile_per_bfd_storage.
 767         * psymtab.c (add_psymbol_to_bcache): Update.
 768         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 769
 770 2019-01-10  Tom Tromey  <tom@tromey.com>
 771
 772         * symtab.c (create_demangled_names_hash): Change argument to be an
 773         objfile_per_bfd_storage.
 774         (symbol_set_names): Update.
 775
 776 2019-01-10  Tom Tromey  <tom@tromey.com>
 777
 778         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 779         init_psymbol_list.
 780         * psymtab.c (init_psymbol_list): Do nothing if already called.
 781         * psympriv.h (init_psymbol_list): Add comment.
 782         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 783         init_psymbol_list.
 784         * dbxread.c (dbx_symfile_read): Unconditionally call
 785         init_psymbol_list.
 786
 787 2019-01-10  Tom Tromey  <tom@tromey.com>
 788
 789         * xcoffread.c (scan_xcoff_symtab): Update.
 790         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 791         "where".
 792         * mdebugread.c (parse_partial_symbols)
 793         (handle_psymbol_enumerators): Update.
 794         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 795         * dbxread.c (read_dbx_symtab): Update.
 796         * psympriv.h (psymbol_placement): New enum.
 797         (add_psymbol_to_list): Update.
 798
 799 2019-01-10  Tom Tromey  <tom@tromey.com>
 800
 801         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 802         static_psymbols parameters.
 803         (scan_xcoff_symtab): Update.
 804         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 805         static_psymbols parameters.
 806         * psympriv.h (start_psymtab_common): Update.
 807         * mdebugread.c (parse_partial_symbols): Update.
 808         * dwarf2read.c (create_partial_symtab): Update.
 809         * dbxread.c (read_dbx_symtab): Update.
 810         (start_psymtab): Remove global_psymbols and static_psymbols
 811         parameters.
 812
 813 2019-01-10  Tom Tromey  <tom@tromey.com>
 814
 815         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 816         * psymtab.c (allocate_psymtab): Add comment.
 817         * psympriv.h (allocate_psymtab): Add comment.
 818         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 819         initializations.
 820         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 821
 822 2019-01-10  Tom Tromey  <tom@tromey.com>
 823
 824         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 825         Don't declare.
 826         * mipsread.c: Include mdebugread.h.
 827         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 828         Declare.
 829         * elfread.c: Include mdebugread.h.
 830
 831 2019-01-09  Tom Tromey  <tom@tromey.com>
 832
 833         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 834         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 835         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 836         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 837         (psym_lookup_symbol, psym_find_last_source_symtab)
 838         (psym_forget_cached_source_info, psym_print_stats)
 839         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 840         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 841         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 842         (psym_find_compunit_symtab_by_address)
 843         (maintenance_print_psymbols, maintenance_info_psymtabs)
 844         (maintenance_check_psymtabs): Use ranged for.
 845         * psymtab.h (class objfile_psymtabs): New.
 846         (require_partial_symbols): Return objfile_psymtabs.
 847         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 848
 849 2019-01-09  Tom Tromey  <tom@tromey.com>
 850
 851         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 852         (find_pc_mapped_section, list_overlays_command)
 853         (map_overlay_command, unmap_overlay_command)
 854         (simple_overlay_update): Use all_objfiles.
 855         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 856         * printcmd.c (info_symbol_command): Use all_objfiles.
 857         * objfiles.h (ALL_OBJSECTIONS): Remove.
 858         * maint.c (maintenance_translate_address): Use all_objfiles.
 859         * gcore.c (gcore_create_callback): Use all_objfiles.
 860         (objfile_find_memory_regions): Likewise.
 861
 862 2019-01-09  Tom Tromey  <tom@tromey.com>
 863
 864         * symtab.c (find_line_symtab, info_sources_command)
 865         (make_source_files_completion_list): Use objfile_compunits.
 866         * source.c (select_source_symtab): Use objfile_compunits.
 867         * objfiles.h (struct objfile): Update comment.
 868         (ALL_OBJFILES): Remove.
 869         (ALL_FILETABS): Remove.
 870         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 871         objfile_compunits.
 872
 873 2019-01-09  Tom Tromey  <tom@tromey.com>
 874
 875         * symmisc.c (print_objfile_statistics, dump_objfile)
 876         (maintenance_print_symbols): Use compunit_filetabs.
 877         * source.c (forget_cached_source_info_for_objfile): Use
 878         compunit_filetabs.
 879         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 880         (ALL_FILETABS): Use compunit_filetabs.
 881         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 882         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 883
 884 2019-01-09  Tom Tromey  <tom@tromey.com>
 885
 886         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 887         (compunit_filetabs): New.
 888         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 889         compunit_filetabs.
 890         (info_sources_command, make_source_files_completion_list): Remove
 891         declaration.
 892         * symmisc.c (print_objfile_statistics, dump_objfile)
 893         (maintenance_print_symbols): Remove declaration.
 894         (maintenance_info_symtabs): Use compunit_filetabs.
 895         (maintenance_info_line_tables): Likewise.
 896         * source.c (select_source_symtab): Change local variable name.
 897         (forget_cached_source_info_for_objfile): Remove declaration.
 898         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 899         * objfiles.c (objfile_relocate1): Remove declaration.
 900         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 901         declaration.
 902         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 903         * coffread.c (coff_symtab_read): Remove declaration.
 904         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 905         compunit_filetabs.
 906
 907 2019-01-09  Tom Tromey  <tom@tromey.com>
 908
 909         * symtab.c (lookup_objfile_from_block)
 910         (find_pc_sect_compunit_symtab, search_symbols)
 911         (default_collect_symbol_completion_matches_break_on): Use
 912         objfile_compunits.
 913         * objfiles.h (ALL_COMPUNITS): Remove.
 914         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 915         * cp-support.c (add_symbol_overload_list_qualified): Use
 916         objfile_compunits.
 917         * ada-lang.c (ada_collect_symbol_completion_matches)
 918         (ada_add_global_exceptions): Use objfile_compunits.
 919
 920 2019-01-09  Tom Tromey  <tom@tromey.com>
 921
 922         * source.c (select_source_symtab)
 923         (forget_cached_source_info_for_objfile): Remove declaration.
 924         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 925         declaration.
 926         * maint.c (count_symtabs_and_blocks): Remove declaration.
 927         * cp-support.c (add_symbol_overload_list_qualified): Remove
 928         declaration.
 929         * coffread.c (coff_symtab_read): Remove declaration.
 930         * symtab.c (lookup_symbol_in_objfile_symtabs)
 931         (basic_lookup_transparent_type_1): Use objfile_compunits.
 932         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 933         (info_sources_command, search_symbols)
 934         (default_collect_symbol_completion_matches_break_on)
 935         (make_source_files_completion_list): Remove declaration.
 936         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 937         (ada_collect_symbol_completion_matches)
 938         (ada_add_global_exceptions): Remove declaration.
 939         * linespec.c (iterate_over_all_matching_symtabs): Use
 940         objfile_compunits.
 941         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 942         (class objfile_compunits): New.
 943         (ALL_COMPUNITS): Use objfile_compunits.
 944         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 945         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 946         objfile_compunits.
 947         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 948
 949 2019-01-09  Tom Tromey  <tom@tromey.com>
 950
 951         * symtab.c (search_symbols)
 952         (default_collect_symbol_completion_matches_break_on): Use
 953         objfile_msymbols.
 954         * ada-lang.c (ada_lookup_simple_minsym)
 955         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 956         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 957         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 958         objfile_msymbols.
 959         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 960         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 961         * objc-lang.c (find_methods): Use objfile_msymbols.
 962         (info_selectors_command, info_classes_command): Likewise.
 963         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 964         * objfiles.h (class objfile_msymbols): New.
 965         (ALL_OBJFILE_MSYMBOLS): Remove.
 966         (ALL_MSYMBOLS): Remove.
 967
 968 2019-01-09  Tom Tromey  <tom@tromey.com>
 969
 970         * common/next-iterator.h (next_adapter): Add Iterator template
 971         parameter.
 972         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 973         (class all_objfiles_safe): New.
 974         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 975         * objfiles.c (put_objfile_before): Update comment.
 976         (add_separate_debug_objfile): Likewise.
 977         (free_all_objfiles): Use all_objfiles_safe.
 978         (objfile_purge_solibs): Likewise.
 979
 980 2019-01-09  Tom Tromey  <tom@tromey.com>
 981
 982         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 983         (expand_symtab_containing_pc, lookup_static_symbol)
 984         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 985         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 986         all_objfiles.
 987         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 988         * breakpoint.c (create_overlay_event_breakpoint)
 989         (create_longjmp_master_breakpoint)
 990         (create_std_terminate_master_breakpoint)
 991         (create_exception_master_breakpoint): Use all_objfiles.
 992         * linux-thread-db.c (try_thread_db_load_from_pdir)
 993         (has_libpthread): Use all_objfiles.
 994         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 995         * linespec.c (iterate_over_all_matching_symtabs)
 996         (search_minsyms_for_name): Use all_objfiles.
 997         * maint.c (maintenance_info_sections): Use all_objfiles.
 998         * main.c (captured_main_1): Use all_objfiles.
 999         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1000         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1001         * guile/scm-pretty-print.c
1002         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1003         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1004         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1005         (maintenance_print_msymbols): Use all_objfiles.
1006         * source.c (select_source_symtab): Use all_objfiles.
1007         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1008         * symfile.c (remove_symbol_file_command)
1009         (expand_symtabs_matching, map_symbol_filenames): Use
1010         all_objfiles.
1011         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1012         all_objfiles.
1013         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1014         * objc-lang.c (find_methods): Use all_objfiles.
1015         * objfiles.c (have_partial_symbols, have_full_symbols)
1016         (have_minimal_symbols, qsort_cmp)
1017         (default_iterate_over_objfiles_in_search_order): Use
1018         all_objfiles.
1019         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1020         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1021         (maintenance_check_psymtabs): Use all_objfiles.
1022         (ALL_PSYMTABS): Remove.
1023         * compile/compile-object-run.c (do_module_cleanup): Use
1024         all_objfiles.
1025         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1026         * cp-support.c (add_symbol_overload_list_qualified): Use
1027         all_objfiles.
1028         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1029         Use all_objfiles.
1030         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1031         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1032         all_objfiles.
1033         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1034         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1035         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1036         Uses all_objfiles.
1037         * solib.c (solib_read_symbols): Use all_objfiles
1038
1039 2019-01-09  Tom Tromey  <tom@tromey.com>
1040
1041         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1042         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1043         all_objfiles.
1044         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1045         * symmisc.c (print_symbol_bcache_statistics)
1046         (print_objfile_statistics, maintenance_print_objfiles)
1047         (maintenance_info_symtabs, maintenance_check_symtabs)
1048         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1049         all_objfiles.
1050         * source.c (forget_cached_source_info): Use all_objfiles.
1051         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1052         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1053         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1054         * objfiles.c (update_section_map): Use all_objfiles.
1055         (shared_objfile_contains_address_p): Likewise.
1056         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1057         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1058
1059 2019-01-09  Tom Tromey  <tom@tromey.com>
1060
1061         * common/next-iterator.h: New file.
1062         * objfiles.h (class all_objfiles): New.
1063         (struct objfile_iterator): New.
1064
1065 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1066
1067         * NEWS: Move the description of the changed "frame", "select-frame",
1068          and "info frame" commands to the Changed commands section.
1069
1070 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1071
1072         * gdbtypes.c (check_stub_method_group): Remove handling of old
1073         mangling schemes.
1074         * linespec.c (find_methods): Likewise.
1075         * stabsread.c (read_member_functions): Likewise.
1076         * valops.c (search_struct_method): Likewise.
1077         (value_struct_elt_for_reference): Likewise.
1078         * NEWS: Mention this change.
1079
1080 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1081
1082         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1083         print_source_lines.
1084         * source.c (print_source_lines_base): Update line number check.
1085         (print_source_lines): New function.
1086         (source_lines_range::source_lines_range): New function.
1087         * source.h (class source_lines_range): New class.
1088         (print_source_lines): New declaration.
1089
1090 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1091
1092         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1093
1094 2019-01-08  Tom Tromey  <tom@tromey.com>
1095             Simon Marchi  <simon.marchi@ericsson.com>
1096
1097         PR gdb/24060
1098         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1099         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1100         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1101         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1102         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1103         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1104
1105 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1106
1107         * source.c (select_source_symtab): Move header comment to
1108         declaration in source.h.
1109         (forget_cached_source_info_for_objfile): Likewise.
1110         (forget_cached_source_info): Likewise.
1111         (identify_source_line): Likewise.
1112         * source.h (identify_source_line): Move declaration from symtab.h
1113         and add comment from source.c
1114         (print_source_lines): Likewise.
1115         (forget_cached_source_info_for_objfile): Likewise.
1116         (forget_cached_source_info): Likewise.
1117         (select_source_symtab): Likewise.
1118         (enum print_source_lines_flag): Move definition from symtab.h.
1119         * symtab.h (identify_source_line): Move declaration to source.h.
1120         (print_source_lines): Likewise.
1121         (forget_cached_source_info_for_objfile): Likewise.
1122         (forget_cached_source_info): Likewise.
1123         (select_source_symtab): Likewise.
1124         (enum print_source_lines_flag): Move definition to source.h.
1125         * tui/tui-hooks.c: Add 'source.h' include.
1126
1127 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1128
1129         * source.c (print_source_lines_base): Handle requests to print
1130         reverse line number sequences, and guard against empty lines
1131         string.
1132
1133 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1134
1135         * source.c (print_source_lines_base): Fix skip of '\r' if next
1136         character is '\n'.
1137
1138 2019-01-06  Tom Tromey  <tom@tromey.com>
1139
1140         * c-exp.y (struct c_parse_state) <macro_original_text,
1141         expansion_obstack>: New member.
1142         (macro_original_text, expansion_obstack): Remove globals.
1143         (scan_macro_expansion, scanning_macro_expansion)
1144         (finished_macro_expansion): Update.
1145         (scan_macro_cleanup): Remove.
1146         (yylex, c_parse): Update.
1147
1148 2019-01-06  Tom Tromey  <tom@tromey.com>
1149
1150         * c-exp.y (struct c_parse_state) <strings>: New member.
1151         (operator_stoken): Update.
1152
1153 2019-01-06  Tom Tromey  <tom@tromey.com>
1154
1155         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1156         (union type_stack_elt) <typelist_val>: Now a pointer to
1157         std::vector.
1158         (type_stack_cleanup): Don't declare.
1159         (push_typelist): Update.
1160         * parse.c (pop_typelist): Return a std::vector.
1161         (push_typelist): Take a std::vector.
1162         (follow_types): Update.  Do not free args.
1163         (type_stack_cleanup): Remove.
1164         * c-exp.y (struct c_parse_state): New.
1165         (cpstate): New global.
1166         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1167         (nonempty_typelist): Update.
1168         (func_mod): Create a new vector.
1169         (c_parse): Create a c_parse_state.
1170         (check_parameter_typelist): Do not delete params.
1171         (function_method): Update.  Do not delete type_list.
1172
1173 2019-01-06  Tom Tromey  <tom@tromey.com>
1174
1175         PR gdb/28155:
1176         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1177         check_typedef.
1178         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1179         (print_return_value): Likewise.
1180
1181 2019-01-05  Tom Tromey  <tom@tromey.com>
1182
1183         * contrib/cleanup_check.py: Remove.
1184         * contrib/gcc-with-excheck: Remove.
1185         * contrib/exsummary.py: Remove.
1186         * contrib/excheck.py: Remove.
1187
1188 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1189
1190         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1191         NULL. Initialize tpprev to NULL instead of assigning it
1192         to NULL on the next statement.
1193         * windows-nat.c (windows_delete_thread): Remove check for
1194         main_thread_id before printing thread exit notifications.
1195         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1196         Remove thread ID check against main_thread_id.
1197         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1198         windows_delete_thread.
1199         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1200
1201 2019-01-04  Tom Tromey  <tom@tromey.com>
1202
1203         * compile/compile.c (_initialize_compile): Use upper case for
1204         metasyntactic variables.
1205         * symmisc.c (_initialize_symmisc): Use upper case for
1206         metasyntactic variables.
1207         * psymtab.c (_initialize_psymtab): Use upper case for
1208         metasyntactic variables.
1209         * demangle.c (demangle_command): Use upper case for metasyntactic
1210         variables.
1211         (_initialize_demangler): Likewise.
1212         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1213         variables.
1214
1215 2019-01-03  Tom Tromey  <tom@tromey.com>
1216
1217         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1218
1219 2019-01-03  Tom Tromey  <tom@tromey.com>
1220
1221         * python/py-symtab.c (salpy_str): Update.
1222         (struct salpy_sal_object) <symtab>: Now a PyObject.
1223         (salpy_dealloc): Update.
1224         (del_objfile_sal): Use gdbpy_ref.
1225
1226 2019-01-03  Tom Tromey  <tom@tromey.com>
1227
1228         * python/py-type.c (convert_field): Use new_reference.  Return
1229         gdbpy_ref.
1230         (make_fielditem): Return gdbpy_ref.
1231         (typy_fields): Update.
1232         (typy_getitem): Update.
1233         (field_name): Return gdbpy_ref.  Use new_reference.
1234         (typy_iterator_iternext): Update.
1235
1236 2019-01-03  Tom Tromey  <tom@tromey.com>
1237
1238         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1239
1240 2019-01-03  Tom Tromey  <tom@tromey.com>
1241
1242         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1243         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1244         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1245         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1246         (pspy_set_type_printers): Likewise.
1247         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1248         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1249         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1250         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1251         (objfpy_set_type_printers): Likewise.
1252
1253 2019-01-03  Tom Tromey  <tom@tromey.com>
1254
1255         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1256         (gdbpy_print_stack): Use gdbpy_err_fetch.
1257         * python/python-internal.h (class gdbpy_err_fetch): New class.
1258         (class gdbpy_enter) <m_error_type, m_error_value,
1259         m_error_traceback>: Remove.
1260         <m_error>: New member.
1261         (gdbpy_exception_to_string): Don't declare.
1262         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1263         * python/py-value.c (convert_value_from_python): Use
1264         gdbpy_err_fetch.
1265         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1266         gdbpy_exception_to_string.
1267         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1268         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1269         gdbpy_err_fetch.
1270
1271 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1272
1273         * linux-nat.c (delete_lwp_cleanup): Delete.
1274         (struct lwp_deleter): New struct.
1275         (lwp_info_up): New typedef.
1276         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1277         lwp_info_up.
1278
1279 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1280
1281         * linux-fork.c (class scoped_switch_fork_info): New class.
1282         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1283
1284 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1285
1286         * valops.c (find_overload_match): Remove use of null_cleanup, and
1287         calls to do_cleanups.
1288
1289 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1290
1291         * compile/compile-cplus-types.c
1292         (compile_cplus_instance::decl_name): Handle changes to
1293         cp_func_name.
1294         * cp-support.c (cp_func_name): Update header comment, update
1295         return type.
1296         * cp-support.h (cp_func_name): Update return type in declaration.
1297         * valops.c (find_overload_match): Move temp_func local to top
1298         level of function and change its type.  Use temp_func to hold and
1299         delete temporary string obtained from cp_func_name.
1300
1301 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1302
1303         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1304         gdb::char_vector, remove cleanup, and update uses of `msg`.
1305
1306 2019-01-03  Jim Wilson  <jimw@sifive.com>
1307
1308         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1309
1310 2019-01-02  Tom Tromey  <tom@tromey.com>
1311
1312         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1313         (tdesc_parse_xml): Remove cleanups.
1314         * target-descriptions.h (make_cleanup_free_target_description):
1315         Don't declare.
1316         (target_desc_deleter): New struct.
1317         (target_desc_up): New typedef.
1318         * target-descriptions.c (target_desc_deleter::operator()): Rename
1319         from free_target_description.
1320         (make_cleanup_free_target_description): Remove.
1321
1322 2019-01-02  Tom Tromey  <tom@tromey.com>
1323
1324         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1325         constructor, destructor.
1326         (linespec_parser): Remove typedef.
1327         (~linespec_parser): Rename from linespec_parser_delete.
1328         (linespec_lex_to_end, linespec_complete_label)
1329         (linespec_complete): Update.
1330         (decode_line_full): Remove cleanups.
1331         (decode_line_1): Update.
1332
1333 2019-01-02  Tom Tromey  <tom@tromey.com>
1334
1335         * python/python-internal.h (inferior_to_inferior_object): Change
1336         return type.
1337         * python/py-exitedevent.c (create_exited_event_object): Update.
1338         * python/py-inferior.c (inferior_to_inferior_object): Return
1339         gdbpy_ref.
1340         (python_new_inferior, python_inferior_deleted)
1341         (thread_to_thread_object, delete_thread_object)
1342         (build_inferior_list, gdbpy_selected_inferior): Update.
1343         * python/py-infthread.c (create_thread_object): Update.  Also fail
1344         if inferior_to_inferior_object fails.
1345
1346 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1347
1348         * inferior.h (class inferior) <displaced_step_state>: New field.
1349         * infrun.h (struct displaced_step_state): Move here from
1350         infrun.c.  Initialize fields, add constructor.
1351         <inf>: Remove field.
1352         <reset>: New method.
1353         * infrun.c (struct displaced_step_inferior_state): Move to
1354         infrun.h.
1355         (displaced_step_inferior_states): Remove.
1356         (get_displaced_stepping_state): Adust.
1357         (displaced_step_in_progress_any_inferior): Adjust.
1358         (displaced_step_in_progress_thread): Adjust.
1359         (displaced_step_in_progress): Adjust.
1360         (add_displaced_stepping_state): Remove.
1361         (get_displaced_step_closure_by_addr): Adjust.
1362         (remove_displaced_stepping_state): Remove.
1363         (infrun_inferior_exit): Call displaced_step_state.reset.
1364         (use_displaced_stepping): Don't check for NULL.
1365         (displaced_step_prepare_throw): Call
1366         get_displaced_stepping_state.
1367         (displaced_step_fixup): Don't check for NULL.
1368         (prepare_for_detach): Don't check for NULL.
1369
1370 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1371
1372         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1373          in case of call that did not complete.
1374
1375 2019-01-02  Andrey Utkin  <autkin@undo.io>
1376
1377         * symfile.c (find_separate_debug_file): Fix search of debug files for
1378         remote debuggee.
1379
1380 2019-01-02  Tom Tromey  <tom@tromey.com>
1381
1382         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1383         indentation.
1384         * python/py-frame.c (frapy_older): Remove cast.
1385         (frapy_newer): Likewise.
1386         * python/py-breakpoint.c (local_setattro): Remove cast.
1387         * python/py-arch.c (archpy_name): Remove local variable.
1388         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1389
1390 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1391
1392         * unittests/basic_string_view/element_access/char/empty.cc:
1393         Fix year range in copyright header.
1394
1395 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1396
1397         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1398         Delete.
1399         <operator==>: Update with for removed field.
1400         <hash>: Likewise.
1401         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1402         <isa_features>: ...this.
1403         <abi_features>: New field.
1404         (riscv_isa_flen): Update comment.
1405         (riscv_abi_xlen): New declaration.
1406         (riscv_abi_flen): New declaration.
1407         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1408         isa_features.
1409         (riscv_abi_xlen): New function.
1410         (riscv_isa_flen): Update to get answer from isa_features.
1411         (riscv_abi_flen): New function.
1412         (riscv_has_fp_abi): Update to get answer from abi_features.
1413         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1414         xlen and flen.
1415         (riscv_call_info) <xlen, flen>: Update comment.
1416         (riscv_call_arg_struct): Remove invalid assertions
1417         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1418         is removed.
1419         (riscv_gdbarch_init): Gather isa features and abi features
1420         separately, ensure both match on the gdbarch when reusing an old
1421         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1422         a target with 64-bit float hardware.
1423
1424 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1425
1426         * source.c (search_command_helper): Stop reverse search
1427         when line 1 has been searched.
1428
1429 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1430
1431         * record-full.c (record_full_base_target::close): Rewrite
1432         record_full_core_buf_list free logic.
1433
1434 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1435
1436         * break-catch-syscall.c (print_one_catch_syscall): xfree
1437         the last text.
1438
1439 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1440
1441         * top.c (print_gdb_version): Update Copyright year in version
1442         message.
1443
1444 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1445
1446         Update copyright year range in all GDB files.
1447
1448 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1449
1450         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1451
1452 For older changes see ChangeLog-2018.
1453 \f
1454 Local Variables:
1455 mode: change-log
1456 left-margin: 8
1457 fill-column: 74
1458 version-control: never
1459 coding: utf-8
1460 End:
1461