gdb/ChangeLog

   1 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
   2
   3         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
   4         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
   5         it returns a newline.  This fixes a regression in TU mode, whereby
   6         the next line is output on the same screen line as the user input.
   7
   8 2019-03-18  Pedro Alves  <palves@redhat.com>
   9
  10         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
  11         New globals.
  12         (apply_style): New, factored out from ...
  13         (apply_ansi_escape): ... this.  Handle reverse video mode.
  14         (tui_set_reverse_mode): New function.
  15         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
  16         * tui/tui-winsource.c (tui_show_source_line): Use
  17         tui_set_reverse_mode instead of setting A_STANDOUT.
  18         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  19         New setter methods.
  20
  21 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  22
  23         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
  24         Handle tabs.
  25
  26 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  27
  28         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  29         tui_refill_source_window instead of tui_refresh_win, to update the
  30         current execution line.  This fixes redisplay of the current line
  31         when stepping through the code with "next" or "step".
  32
  33 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  34
  35         * source-cache.c (source_cache::get_source_lines): Call
  36         find_source_lines to initialize s->nlines.  This fixes vertical
  37         scrolling of TUI source window when the DOWN arrow is pressed.
  38
  39 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  40
  41         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  42         wclrtoeol in tui_show_source_line".  This reverts changes made in
  43         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  44
  45 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  46
  47         * NEWS: Combine separate "New targets" sections for 8.3.
  48
  49 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  50
  51         The MS-Windows port of ncurses fails to switch to a color pair if
  52         one or both of the colors are the implicit default colors.  This
  53         change records the default colors when TUI is initialized, and
  54         then specifies them explicitly when a color pair uses the default
  55         colors.  This allows color styling in TUI mode on MS-Windows.
  56
  57         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  58         ncurses_norm_attr.
  59         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  60         colors in ncurses_norm_attr.
  61         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  62         "none", replace it with the default color recorded in
  63         ncurses_norm_attr.
  64
  65 2019-03-14  Tom Tromey  <tromey@adacore.com>
  66
  67         * source-cache.h (class source_cache) <get_source_lines>: Return
  68         std::string.
  69         * source-cache.c (source_cache::extract_lines): Handle case where
  70         first_pos==npos.  Return std::string.
  71         (source_cache::get_source_lines): Update.
  72
  73 2019-03-14  Tom Tromey  <tromey@adacore.com>
  74
  75         * NEWS: Add item for "style sources" commands.
  76         * source-cache.c (source_cache::get_source_lines): Check
  77         source_styling.
  78         * cli/cli-style.c (source_styling): New global.
  79         (_initialize_cli_style): Add "style sources" commands.
  80         (show_style_sources): New function.
  81         * cli/cli-style.h (source_styling): Declare.
  82
  83 2019-03-14  Pedro Alves  <palves@redhat.com>
  84             Tom Tromey  <tromey@adacore.com>
  85
  86         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  87         * tui/tui-winsource.c (tui_refill_source_window): New function,
  88         from...
  89         (tui_horizontal_source_scroll): ... here.  Move some logic.
  90         * cli/cli-style.c (set_style_enabled): Notify new observable.
  91         * tui/tui-hooks.c (tui_redisplay_source): New function.
  92         (tui_attach_detach_observers): Attach or detach
  93         tui_redisplay_source.
  94         * observable.h (source_styling_changed): New observable.
  95         * observable.c: Define source_styling_changed observable.
  96
  97 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  98
  99         PR/24325
 100         * source-cache.c: #undef open and close, to avoid unresolved
 101         externals during linking.
 102
 103 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 104
 105         Support styling on native MS-Windows console
 106
 107         PR/24315
 108         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 109         on MS-Windows if $TERM is not defined.
 110
 111         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 112
 113         * posix-hdep.c (gdb_console_fputs):
 114         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 115         functions.
 116         * ui-file.h (gdb_console_fputs): Add prototype.
 117
 118         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 119         back to fputs only if the former returns zero.
 120
 121 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 122             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 123
 124         PR gdb/8527
 125         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 126         set_sigint_trap, clear_sigint_trap.
 127
 128 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 129
 130         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 131         for-loop range, to avoid compiler warnings.
 132
 133         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 134         avoid compiler warnings about unused variables.
 135
 136 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 137
 138         * NEWS: Mention end of support for native debugging on MS-Windows
 139         before XP.
 140
 141 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 142
 143         PR gdb/24292
 144         * common/netstuff.c:
 145         * gdbserver/gdbreplay.c
 146         * gdbserver/remote-utils.c:
 147         * ser-tcp.c:
 148         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 149         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 150         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 151         'getaddrinfo' and 'freeaddrinfo' were not available before
 152         Windows XP, and mingw.org's MinGW headers by default define
 153         _WIN32_WINNT to 0x500.
 154
 155 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 156
 157         * NEWS: Note minimum Python version.
 158
 159 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 160
 161         * version.in: Set GDB version number to 8.2.90.DATE-git.
 162
 163 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 164
 165         GDB 8.2.90 released.
 166
 167 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 168
 169         * version.in: Set GDB version number to 8.2.90.
 170
 171 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 172
 173         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 174
 175 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 176
 177         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 178         * version.in: Bump version to 8.2.90.DATE-git.
 179
 180 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 181
 182         * aix-thread.c (ptid_cmp): Remove unused variable.
 183         (get_signaled_thread): Likewise.
 184         (store_regs_user_thread): Likewise.
 185         (store_regs_kernel_thread): Likewise.
 186         (fetch_regs_kernel_thread): Remove shadowed variable.
 187
 188 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 189
 190         * features/riscv/32bit-cpu.xml: Add register numbers.
 191         * features/riscv/32bit-fpu.c: Regenerate.
 192         * features/riscv/32bit-fpu.xml: Add register numbers.
 193         * features/riscv/64bit-cpu.xml: Add register numbers.
 194         * features/riscv/64bit-fpu.c: Regenerate.
 195         * features/riscv/64bit-fpu.xml: Add register numbers.
 196
 197 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 198
 199         * NEWS: Mention two argument form of gdb.Value constructor.
 200         * python/py-value.c (convert_buffer_and_type_to_value): New
 201         function.
 202         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 203         Add support for handling an optional second argument.  Call
 204         convert_buffer_and_type_to_value as appropriate.
 205         * python/python-internal.h (Py_buffer_deleter): New struct.
 206         (Py_buffer_up): New typedef.
 207
 208 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 209
 210         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 211         instead of releasing ownership.
 212
 213 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 214
 215         * dwarf2read.c (open_and_init_dwp_file): Call
 216         elf_numsections instead of bfd_count_sections to initialize
 217         dwp_file->num_sections.
 218
 219 2019-02-25  Tom Tromey  <tromey@adacore.com>
 220
 221         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 222
 223 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 224
 225         * gcore.in: Add '--readnever' option when invoking GDB.
 226
 227 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 228
 229         * MAINTAINERS: Update my email address.
 230
 231 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 232
 233         * build-id.c (build_id_to_debug_bfd_1): New function.
 234         (build_id_to_debug_bfd): Look for separate debug file in
 235         sysroot.
 236
 237 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 238
 239         * gdbarch.sh: Update the copyright year range that is placed into
 240         generated files.
 241
 242 2019-02-22  Keith Seitz  <keiths@redhat.com>
 243
 244         PR symtab/23853
 245         * linespec.c (create_sals_line_offset): Search for the default
 246         symtab's filename instead of its fullname.
 247
 248 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 249
 250         * NEWS: Update style defaults.
 251
 252 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 253
 254         * main.c (captured_main_1): Disable styling in batch mode.
 255
 256 2019-02-20  Tom Tromey  <tom@tromey.com>
 257
 258         * symtab.c (symtab_symbol_info): Fix typos.
 259
 260 2019-02-20  Tom Tromey  <tromey@adacore.com>
 261
 262         * findcmd.c (_initialize_mem_search): Use upper case for
 263         metasyntactic variables.
 264
 265 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 266
 267         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 268         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 269
 270 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 271
 272         * top.h (source_file_name): Change to std::string.
 273         * top.c (source_file_name): Likewise.
 274         (command_line_input): Adjust.
 275         * cli/cli-script.c (script_from_file): Adjust.
 276
 277 2019-02-19  Tom Tromey  <tromey@adacore.com>
 278
 279         * ravenscar-thread.c
 280         (ravenscar_thread_target::update_thread_list): Don't call
 281         ada_build_task_list.
 282         * ada-lang.h (ada_build_task_list): Don't declare.
 283         * ada-tasks.c (struct ada_tasks_inferior_data)
 284         <task_list_valid_p>: Now bool.
 285         (read_known_tasks, ada_task_list_changed)
 286         (ada_tasks_invalidate_inferior_data): Update.
 287         (read_known_tasks_array): Return bool.
 288         (read_known_tasks_list): Likewise.
 289         (read_known_tasks): Return void.
 290         (ada_build_task_list): Now static.
 291
 292 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 293
 294         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 295         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 296
 297 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 298
 299         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 300         variant for ada_tasks_pspace_data_handle and
 301         ada_tasks_inferior_data_handle.
 302         (ada_tasks_pspace_data_cleanup): New function.
 303         (ada_tasks_inferior_data_cleanup): New function.
 304
 305 2019-02-17  Tom Tromey  <tom@tromey.com>
 306
 307         * macrotab.h (macro_source_fullname): Return a std::string.
 308         * macrotab.c (macro_include, check_for_redefinition)
 309         (macro_undef, macro_lookup_definition, foreach_macro)
 310         (foreach_macro_in_scope): Update.
 311         (macro_source_fullname): Return a std::string.
 312         * macrocmd.c (show_pp_source_pos): Update.
 313
 314 2019-02-17  Tom Tromey  <tom@tromey.com>
 315
 316         * macrocmd.c (show_pp_source_pos): Style the file names.
 317
 318 2019-02-17  Tom Tromey  <tom@tromey.com>
 319
 320         PR tui/24197:
 321         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 322
 323 2019-02-17  Tom Tromey  <tom@tromey.com>
 324
 325         * ada-lang.c (user_select_syms): Use filtered printing.
 326         * utils.c (wrap_style): New global.
 327         (desired_style): Remove.
 328         (emit_style_escape): Add stream parameter.
 329         (set_output_style, reset_terminal_style, prompt_for_continue):
 330         Update.
 331         (flush_wrap_buffer): Only flush gdb_stdout.
 332         (wrap_here): Set wrap_style.
 333         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 334         treat escape sequences as a character.  Change when wrap buffer is
 335         flushed.
 336         (fputs_styled): Do not set the output style when the default is
 337         requested.
 338         * ui-style.h (struct ui_file_style) <is_default>: New method.
 339         * source.c (print_source_lines_base): Emit escape sequences in one
 340         piece.
 341
 342 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 343
 344         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 345         integers and enumeration types.
 346
 347 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 348
 349         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 350         instead of lookup_symbol_in_language
 351         (do_exact_match): New function.
 352         (ada_get_symbol_name_matcher): Return do_exact_match when
 353         doing a verbatim match.
 354
 355 2019-02-15  Tom Tromey  <tromey@adacore.com>
 356
 357         * ravenscar-thread.c (ravenscar_thread_target::resume)
 358         (ravenscar_thread_target::wait): Special case wildcard requests.
 359
 360 2019-02-15  Tom Tromey  <tromey@adacore.com>
 361
 362         * ravenscar-thread.c (base_ptid): Remove.
 363         (struct ravenscar_thread_target) <close>: New method.
 364         <m_base_ptid>: New member.
 365         <update_inferior_ptid, active_task, task_is_currently_active,
 366         runtime_initialized>: Declare methods.
 367         <ravenscar_thread_target>: Add constructor.
 368         (ravenscar_thread_target::task_is_currently_active)
 369         (ravenscar_thread_target::update_inferior_ptid)
 370         (ravenscar_runtime_initialized): Rename.  Now methods.
 371         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 372         (ravenscar_thread_target::update_thread_list): Update.
 373         (ravenscar_thread_target::active_task): Now method.
 374         (ravenscar_thread_target::store_registers)
 375         (ravenscar_thread_target::prepare_to_store)
 376         (ravenscar_thread_target::prepare_to_store)
 377         (ravenscar_thread_target::mourn_inferior): Update.
 378         (ravenscar_inferior_created): Use "new" to create target.
 379         (ravenscar_thread_target::get_ada_task_ptid): Update.
 380         (_initialize_ravenscar): Don't initialize base_ptid.
 381         (ravenscar_ops): Remove global.
 382
 383 2019-02-15  Tom Tromey  <tromey@adacore.com>
 384
 385         * target.h (push_target): Declare new overload.
 386         * target.c (push_target): New overload, taking an rvalue reference.
 387         * remote.c (remote_target::open_1): Use push_target overload.
 388         * corelow.c (core_target_open): Use push_target overload.
 389
 390 2019-02-15  Tom Tromey  <tromey@adacore.com>
 391
 392         * ravenscar-thread.c (is_ravenscar_task)
 393         (ravenscar_task_is_currently_active): Return bool.
 394         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 395         (_initialize_ravenscar): Remove "(void)".
 396         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 397         Return bool.
 398
 399 2019-02-15  Tom Tromey  <tromey@adacore.com>
 400
 401         * ravenscar-thread.c (ravenscar_runtime_initializer)
 402         (has_ravenscar_runtime, get_running_thread_id)
 403         (ravenscar_thread_target::resume): Fix indentation.
 404
 405 2019-02-15  Tom Tromey  <tromey@adacore.com>
 406
 407         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 408         from ravenscar_arch_ops.
 409         (sparc_ravenscar_ops::fetch_registers)
 410         (sparc_ravenscar_ops::store_registers): Now methods.
 411         (sparc_ravenscar_prepare_to_store): Remove.
 412         (sparc_ravenscar_ops): Redefine.
 413         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 414         methods and destructor.  Remove members.
 415         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 416         (ravenscar_thread_target::store_registers)
 417         (ravenscar_thread_target::prepare_to_store): Update.
 418         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 419         Remove.
 420         (struct ppc_ravenscar_powerpc_ops): Derive from
 421         ravenscar_arch_ops.
 422         (ppc_ravenscar_powerpc_ops::fetch_registers)
 423         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 424         (ppc_ravenscar_powerpc_ops): Redefine.
 425         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 426         (ppc_ravenscar_e500_ops::fetch_registers)
 427         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 428         (ppc_ravenscar_e500_ops): Redefine.
 429         * aarch64-ravenscar-thread.c
 430         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 431         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 432         (aarch64_ravenscar_fetch_registers)
 433         (aarch64_ravenscar_store_registers): Now methods.
 434         (aarch64_ravenscar_ops): Redefine.
 435
 436 2019-02-15  Tom Tromey  <tromey@adacore.com>
 437
 438         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 439         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 440         (ravenscar_thread_target::stopped_by_watchpoint)
 441         (ravenscar_thread_target::stopped_data_address)
 442         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 443
 444 2019-02-15  Tom Tromey  <tromey@adacore.com>
 445
 446         * ravenscar-thread.c: Fix some typos.
 447
 448 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 449             Tom Tromey  <tromey@adacore.com>
 450
 451         * ada-lang.c (ada_exception_sal): Change addr_string to a
 452         std::string.
 453         (create_ada_exception_catchpoint): Update.
 454
 455 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 456             Tom Tromey  <tromey@adacore.com>
 457
 458         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 459         (bp_location_ops): Remove.
 460         (base_breakpoint_allocate_location): Update.
 461         (free_bp_location): Update.
 462         * ada-lang.c (class ada_catchpoint_location)
 463         <ada_catchpoint_location>: Remove ops parameter.
 464         (ada_catchpoint_location_dtor): Remove.
 465         (ada_catchpoint_location_ops): Remove.
 466         (allocate_location_exception): Update.
 467         * breakpoint.h (struct bp_location_ops): Remove.
 468         (class bp_location) <bp_location>: Remove bp_location_ops
 469         parameter.
 470         <~bp_location>: Add destructor.
 471         <ops>: Remove.
 472
 473 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 474             Pedro Alves  <palves@redhat.com>
 475
 476         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 477         'PATH_MAX'.
 478
 479 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 480             Samuel Thibault  <samuel.thibault@gnu.org>
 481             Thomas Schwinge  <thomas@codesourcery.com>
 482
 483         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 484         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 485
 486 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 487
 488         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 489         (check_empty): Use "const char *".
 490
 491         * gnu-nat.c (gnu_nat_target::detach): Instead of
 492         'detach_inferior (pid)' call
 493         'detach_inferior (find_inferior_pid (pid))'.
 494
 495         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 496         'nat/fork-inferior.o'.
 497         * gnu-nat.c: #include "nat/fork-inferior.h".
 498
 499         * gnu-nat.c (gnu_nat_target::detach): Instead of
 500         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 501         * gnu-nat.h: #include "inf-child.h".
 502         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 503         'i386_gnu_nat_target::fetch_registers'.
 504         (gnu_store_registers): Rename/move to
 505         'i386_gnu_nat_target::store_registers'.
 506
 507         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 508         * gnu-nat.h (mach_thread_info): New function.
 509         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 510
 511         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 512
 513 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 514
 515         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 516
 517 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 518
 519         * windows-nat.c (windows_add_thread): Add new parameter
 520         "main_thread_p" with default value set to false.  Update
 521         function documentation as well as all callers.
 522         (windows_delete_thread): Likewise.
 523         (fake_create_process): Update call to windows_add_thread.
 524         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 525         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 526         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 527         call to windows_delete_thread.
 528
 529 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 530
 531         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 532
 533 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 534
 535         * symfile.c (find_separate_debug_file): Use canonical path of
 536         sysroot with child_path instead of gdb_sysroot if it is valid.
 537
 538 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 539
 540         * symfile.c (find_separate_debug_file): Use child_path to
 541         determine if an object file is under a sysroot.
 542
 543 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 544
 545         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 546         unittests/child-path-selftests.c.
 547         * common/pathstuff.c (child_path): New function.
 548         * common/pathstuff.h (child_path): New prototype.
 549         * unittests/child-path-selftests.c: New file.
 550
 551 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 552
 553         * symfile.c (find_separate_debug_file): Look for separate debug
 554         files in debug directories under the sysroot.
 555
 556 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 557
 558         * symtab.h (struct minimal_symbol data_p): New const method.
 559         (struct minimal_symbol text_p): Likewise.
 560         * symtab.c (output_source_filename): Use file name style
 561         to print file name.
 562         (print_symbol_info): Likewise.
 563         (print_msymbol_info): Use address style to print addresses.
 564         Use function name style to print executable text symbols.
 565         (expand_symtab_containing_pc): Use data_p.
 566         (find_pc_sect_compunit_symtab): Likewise.
 567
 568 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 569
 570         * breakpoint.c (describe_other_breakpoints): Use address style
 571         to print addresses.
 572         (say_where): Likewise.
 573
 574 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 575
 576         * ada-typeprint.c (print_func_type): Print function name
 577         style to print function name.
 578         * c-typeprint.c (c_print_type_1): Likewise.
 579
 580 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 581
 582         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 583         for execve.
 584
 585 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 586
 587         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 588         type_stack.
 589
 590 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 591
 592         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 593         TYPE_CODE_REF types.
 594
 595 2019-02-08  Jim Wilson  <jimw@sifive.com>
 596
 597         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 598         (riscv_linux_fregset): New.
 599         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 600
 601 2019-02-07  Tom Tromey  <tom@tromey.com>
 602
 603         * thread.c (thread_cancel_execution_command): Update.
 604         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 605         methods.
 606         (struct thread_fsm_ops): Remove.
 607         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 608         (thread_fsm_should_stop, thread_fsm_return_value)
 609         (thread_fsm_set_finished, thread_fsm_finished_p)
 610         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 611         Don't declare.
 612         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 613         * infrun.c (clear_proceed_status_thread)
 614         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 615         (print_stop_event): Update.
 616         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 617         Add constructor.
 618         (step_command_fsm_ops): Remove.
 619         (new_step_command_fsm): Remove.
 620         (step_1): Update.
 621         (step_command_fsm::should_stop): Rename from
 622         step_command_fsm_should_stop.
 623         (step_command_fsm::clean_up): Rename from
 624         step_command_fsm_clean_up.
 625         (step_command_fsm::do_async_reply_reason): Rename from
 626         step_command_fsm_async_reply_reason.
 627         (struct until_next_fsm): Inherit from thread_fsm.  Add
 628         constructor.
 629         (until_next_fsm_ops): Remove.
 630         (new_until_next_fsm): Remove.
 631         (until_next_fsm::should_stop): Rename from
 632         until_next_fsm_should_stop.
 633         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 634         (until_next_fsm::do_async_reply_reason): Rename from
 635         until_next_fsm_async_reply_reason.
 636         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 637         constructor.  Change type of breakpoint.
 638         (finish_command_fsm_ops): Remove.
 639         (new_finish_command_fsm): Remove.
 640         (finish_command_fsm::should_stop): Rename from
 641         finish_command_fsm_should_stop.
 642         (finish_command_fsm::clean_up): Rename from
 643         finish_command_fsm_clean_up.
 644         (finish_command_fsm::return_value): Rename from
 645         finish_command_fsm_return_value.
 646         (finish_command_fsm::do_async_reply_reason): Rename from
 647         finish_command_fsm_async_reply_reason.
 648         (finish_command): Update.
 649         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 650         Add constructor.
 651         (call_thread_fsm_ops): Remove.
 652         (call_thread_fsm::call_thread_fsm): Rename from
 653         new_call_thread_fsm.
 654         (call_thread_fsm::should_stop): Rename from
 655         call_thread_fsm_should_stop.
 656         (call_thread_fsm::should_notify_stop): Rename from
 657         call_thread_fsm_should_notify_stop.
 658         (run_inferior_call, call_function_by_hand_dummy): Update.
 659         * cli/cli-interp.c (should_print_stop_to_console): Update.
 660         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 661         Add constructor.  Change type of location_breakpoint,
 662         caller_breakpoint.
 663         (until_break_fsm_ops): Remove.
 664         (new_until_break_fsm): Remove.
 665         (until_break_fsm::should_stop): Rename from
 666         until_break_fsm_should_stop.
 667         (until_break_fsm::clean_up): Rename from
 668         until_break_fsm_clean_up.
 669         (until_break_fsm::do_async_reply_reason): Rename from
 670         until_break_fsm_async_reply_reason.
 671         (until_break_command): Update.
 672         * thread-fsm.c: Remove.
 673         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 674
 675 2019-02-07  Tom Tromey  <tom@tromey.com>
 676
 677         * yy-remap.h: Add include guard.
 678         * xtensa-tdep.h: Add include guard.
 679         * xcoffread.h: Rename include guard.
 680         * varobj-iter.h: Add include guard.
 681         * tui/tui.h: Rename include guard.
 682         * tui/tui-winsource.h: Rename include guard.
 683         * tui/tui-wingeneral.h: Rename include guard.
 684         * tui/tui-windata.h: Rename include guard.
 685         * tui/tui-win.h: Rename include guard.
 686         * tui/tui-stack.h: Rename include guard.
 687         * tui/tui-source.h: Rename include guard.
 688         * tui/tui-regs.h: Rename include guard.
 689         * tui/tui-out.h: Rename include guard.
 690         * tui/tui-layout.h: Rename include guard.
 691         * tui/tui-io.h: Rename include guard.
 692         * tui/tui-hooks.h: Rename include guard.
 693         * tui/tui-file.h: Rename include guard.
 694         * tui/tui-disasm.h: Rename include guard.
 695         * tui/tui-data.h: Rename include guard.
 696         * tui/tui-command.h: Rename include guard.
 697         * tic6x-tdep.h: Add include guard.
 698         * target/waitstatus.h: Rename include guard.
 699         * target/wait.h: Rename include guard.
 700         * target/target.h: Rename include guard.
 701         * target/resume.h: Rename include guard.
 702         * target-float.h: Rename include guard.
 703         * stabsread.h: Add include guard.
 704         * rs6000-tdep.h: Add include guard.
 705         * riscv-fbsd-tdep.h: Add include guard.
 706         * regformats/regdef.h: Rename include guard.
 707         * record.h: Rename include guard.
 708         * python/python.h: Rename include guard.
 709         * python/python-internal.h: Rename include guard.
 710         * python/py-stopevent.h: Rename include guard.
 711         * python/py-ref.h: Rename include guard.
 712         * python/py-record.h: Rename include guard.
 713         * python/py-record-full.h: Rename include guard.
 714         * python/py-record-btrace.h: Rename include guard.
 715         * python/py-instruction.h: Rename include guard.
 716         * python/py-events.h: Rename include guard.
 717         * python/py-event.h: Rename include guard.
 718         * procfs.h: Add include guard.
 719         * proc-utils.h: Add include guard.
 720         * p-lang.h: Add include guard.
 721         * or1k-tdep.h: Rename include guard.
 722         * observable.h: Rename include guard.
 723         * nto-tdep.h: Rename include guard.
 724         * nat/x86-linux.h: Rename include guard.
 725         * nat/x86-linux-dregs.h: Rename include guard.
 726         * nat/x86-gcc-cpuid.h: Add include guard.
 727         * nat/x86-dregs.h: Rename include guard.
 728         * nat/x86-cpuid.h: Rename include guard.
 729         * nat/ppc-linux.h: Rename include guard.
 730         * nat/mips-linux-watch.h: Rename include guard.
 731         * nat/linux-waitpid.h: Rename include guard.
 732         * nat/linux-ptrace.h: Rename include guard.
 733         * nat/linux-procfs.h: Rename include guard.
 734         * nat/linux-osdata.h: Rename include guard.
 735         * nat/linux-nat.h: Rename include guard.
 736         * nat/linux-namespaces.h: Rename include guard.
 737         * nat/linux-btrace.h: Rename include guard.
 738         * nat/glibc_thread_db.h: Rename include guard.
 739         * nat/gdb_thread_db.h: Rename include guard.
 740         * nat/gdb_ptrace.h: Rename include guard.
 741         * nat/fork-inferior.h: Rename include guard.
 742         * nat/amd64-linux-siginfo.h: Rename include guard.
 743         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 744         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 745         * nat/aarch64-linux.h: Rename include guard.
 746         * nat/aarch64-linux-hw-point.h: Rename include guard.
 747         * mn10300-tdep.h: Add include guard.
 748         * mips-linux-tdep.h: Add include guard.
 749         * mi/mi-parse.h: Rename include guard.
 750         * mi/mi-out.h: Rename include guard.
 751         * mi/mi-main.h: Rename include guard.
 752         * mi/mi-interp.h: Rename include guard.
 753         * mi/mi-getopt.h: Rename include guard.
 754         * mi/mi-console.h: Rename include guard.
 755         * mi/mi-common.h: Rename include guard.
 756         * mi/mi-cmds.h: Rename include guard.
 757         * mi/mi-cmd-break.h: Rename include guard.
 758         * m2-lang.h: Add include guard.
 759         * location.h: Rename include guard.
 760         * linux-record.h: Rename include guard.
 761         * linux-nat.h: Add include guard.
 762         * linux-fork.h: Add include guard.
 763         * i386-darwin-tdep.h: Rename include guard.
 764         * hppa-linux-offsets.h: Add include guard.
 765         * guile/guile.h: Rename include guard.
 766         * guile/guile-internal.h: Rename include guard.
 767         * gnu-nat.h: Rename include guard.
 768         * gdb-stabs.h: Rename include guard.
 769         * frv-tdep.h: Add include guard.
 770         * f-lang.h: Add include guard.
 771         * event-loop.h: Add include guard.
 772         * darwin-nat.h: Rename include guard.
 773         * cp-abi.h: Rename include guard.
 774         * config/sparc/nm-sol2.h: Rename include guard.
 775         * config/nm-nto.h: Rename include guard.
 776         * config/nm-linux.h: Add include guard.
 777         * config/i386/nm-i386gnu.h: Rename include guard.
 778         * config/djgpp/nl_types.h: Rename include guard.
 779         * config/djgpp/langinfo.h: Rename include guard.
 780         * compile/gcc-cp-plugin.h: Add include guard.
 781         * compile/gcc-c-plugin.h: Add include guard.
 782         * compile/compile.h: Rename include guard.
 783         * compile/compile-object-run.h: Rename include guard.
 784         * compile/compile-object-load.h: Rename include guard.
 785         * compile/compile-internal.h: Rename include guard.
 786         * compile/compile-cplus.h: Rename include guard.
 787         * compile/compile-c.h: Rename include guard.
 788         * common/xml-utils.h: Rename include guard.
 789         * common/x86-xstate.h: Rename include guard.
 790         * common/version.h: Rename include guard.
 791         * common/vec.h: Rename include guard.
 792         * common/tdesc.h: Rename include guard.
 793         * common/selftest.h: Rename include guard.
 794         * common/scoped_restore.h: Rename include guard.
 795         * common/scoped_mmap.h: Rename include guard.
 796         * common/scoped_fd.h: Rename include guard.
 797         * common/safe-iterator.h: Rename include guard.
 798         * common/run-time-clock.h: Rename include guard.
 799         * common/refcounted-object.h: Rename include guard.
 800         * common/queue.h: Rename include guard.
 801         * common/ptid.h: Rename include guard.
 802         * common/print-utils.h: Rename include guard.
 803         * common/preprocessor.h: Rename include guard.
 804         * common/pathstuff.h: Rename include guard.
 805         * common/observable.h: Rename include guard.
 806         * common/netstuff.h: Rename include guard.
 807         * common/job-control.h: Rename include guard.
 808         * common/host-defs.h: Rename include guard.
 809         * common/gdb_wait.h: Rename include guard.
 810         * common/gdb_vecs.h: Rename include guard.
 811         * common/gdb_unlinker.h: Rename include guard.
 812         * common/gdb_unique_ptr.h: Rename include guard.
 813         * common/gdb_tilde_expand.h: Rename include guard.
 814         * common/gdb_sys_time.h: Rename include guard.
 815         * common/gdb_string_view.h: Rename include guard.
 816         * common/gdb_splay_tree.h: Rename include guard.
 817         * common/gdb_setjmp.h: Rename include guard.
 818         * common/gdb_ref_ptr.h: Rename include guard.
 819         * common/gdb_optional.h: Rename include guard.
 820         * common/gdb_locale.h: Rename include guard.
 821         * common/gdb_assert.h: Rename include guard.
 822         * common/filtered-iterator.h: Rename include guard.
 823         * common/filestuff.h: Rename include guard.
 824         * common/fileio.h: Rename include guard.
 825         * common/environ.h: Rename include guard.
 826         * common/common-utils.h: Rename include guard.
 827         * common/common-types.h: Rename include guard.
 828         * common/common-regcache.h: Rename include guard.
 829         * common/common-inferior.h: Rename include guard.
 830         * common/common-gdbthread.h: Rename include guard.
 831         * common/common-exceptions.h: Rename include guard.
 832         * common/common-defs.h: Rename include guard.
 833         * common/common-debug.h: Rename include guard.
 834         * common/cleanups.h: Rename include guard.
 835         * common/buffer.h: Rename include guard.
 836         * common/btrace-common.h: Rename include guard.
 837         * common/break-common.h: Rename include guard.
 838         * cli/cli-utils.h: Rename include guard.
 839         * cli/cli-style.h: Rename include guard.
 840         * cli/cli-setshow.h: Rename include guard.
 841         * cli/cli-script.h: Rename include guard.
 842         * cli/cli-interp.h: Rename include guard.
 843         * cli/cli-decode.h: Rename include guard.
 844         * cli/cli-cmds.h: Rename include guard.
 845         * charset-list.h: Add include guard.
 846         * buildsym-legacy.h: Rename include guard.
 847         * bfin-tdep.h: Add include guard.
 848         * ax.h: Rename include guard.
 849         * arm-linux-tdep.h: Add include guard.
 850         * arm-fbsd-tdep.h: Add include guard.
 851         * arch/xtensa.h: Rename include guard.
 852         * arch/tic6x.h: Add include guard.
 853         * arch/i386.h: Add include guard.
 854         * arch/arm.h: Rename include guard.
 855         * arch/arm-linux.h: Rename include guard.
 856         * arch/arm-get-next-pcs.h: Rename include guard.
 857         * arch/amd64.h: Add include guard.
 858         * arch/aarch64-insn.h: Rename include guard.
 859         * arch-utils.h: Rename include guard.
 860         * annotate.h: Add include guard.
 861         * amd64-darwin-tdep.h: Rename include guard.
 862         * aarch64-linux-tdep.h: Add include guard.
 863         * aarch64-fbsd-tdep.h: Add include guard.
 864         * aarch32-linux-nat.h: Add include guard.
 865
 866 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 867
 868         * macrotab.c (macro_define_internal): New function that
 869         factorizes macro_define_object_internal and macro_define_function
 870         code.
 871         (macro_define_object_internal): Use macro_define_internal.
 872         (macro_define_function): Likewise.
 873
 874 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 875
 876         * macrocmd.c (extract_identifier): Return
 877         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 878         callers.
 879
 880 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 881
 882         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 883
 884 2019-02-05  Tom Tromey  <tom@tromey.com>
 885
 886         * target.c (target_stack::unpush): Move assertion earlier.
 887
 888 2019-01-30  Tom Tromey  <tom@tromey.com>
 889
 890         PR python/23615:
 891         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 892         (gdbpy_parse_and_eval): Likewise.
 893         * python/python-internal.h (gdbpy_allow_threads): New class.
 894
 895 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 896
 897         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 898         (aarch64_fbsd_fpregmap): Move earlier.
 899         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 900         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 901         instead of individual calls to trad_frame_set_reg_addr.
 902         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 903         earlier.
 904         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 905         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 906         instead of individual calls to trad_frame_set_reg_addr.
 907
 908 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 909
 910         * CONTRIBUTE: Replace contribution list with wiki link.
 911
 912 2019-01-25  Tom Tromey  <tom@tromey.com>
 913
 914         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 915
 916 2019-01-25  Tom Tromey  <tom@tromey.com>
 917
 918         * xtensa-linux-nat.c: Fix common/ includes.
 919         * xml-support.h: Fix common/ includes.
 920         * xml-support.c: Fix common/ includes.
 921         * x86-linux-nat.c: Fix common/ includes.
 922         * windows-nat.c: Fix common/ includes.
 923         * varobj.h: Fix common/ includes.
 924         * varobj.c: Fix common/ includes.
 925         * value.c: Fix common/ includes.
 926         * valops.c: Fix common/ includes.
 927         * utils.c: Fix common/ includes.
 928         * unittests/xml-utils-selftests.c: Fix common/ includes.
 929         * unittests/utils-selftests.c: Fix common/ includes.
 930         * unittests/unpack-selftests.c: Fix common/ includes.
 931         * unittests/tracepoint-selftests.c: Fix common/ includes.
 932         * unittests/style-selftests.c: Fix common/ includes.
 933         * unittests/string_view-selftests.c: Fix common/ includes.
 934         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 935         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 936         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 937         * unittests/rsp-low-selftests.c: Fix common/ includes.
 938         * unittests/parse-connection-spec-selftests.c: Fix common/
 939         includes.
 940         * unittests/optional-selftests.c: Fix common/ includes.
 941         * unittests/offset-type-selftests.c: Fix common/ includes.
 942         * unittests/observable-selftests.c: Fix common/ includes.
 943         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 944         * unittests/memrange-selftests.c: Fix common/ includes.
 945         * unittests/memory-map-selftests.c: Fix common/ includes.
 946         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 947         * unittests/function-view-selftests.c: Fix common/ includes.
 948         * unittests/environ-selftests.c: Fix common/ includes.
 949         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 950         * unittests/common-utils-selftests.c: Fix common/ includes.
 951         * unittests/cli-utils-selftests.c: Fix common/ includes.
 952         * unittests/array-view-selftests.c: Fix common/ includes.
 953         * ui-file.c: Fix common/ includes.
 954         * tui/tui-io.c: Fix common/ includes.
 955         * tracepoint.h: Fix common/ includes.
 956         * tracepoint.c: Fix common/ includes.
 957         * tracefile-tfile.c: Fix common/ includes.
 958         * top.h: Fix common/ includes.
 959         * top.c: Fix common/ includes.
 960         * thread.c: Fix common/ includes.
 961         * target/waitstatus.h: Fix common/ includes.
 962         * target/waitstatus.c: Fix common/ includes.
 963         * target.h: Fix common/ includes.
 964         * target.c: Fix common/ includes.
 965         * target-memory.c: Fix common/ includes.
 966         * target-descriptions.c: Fix common/ includes.
 967         * symtab.h: Fix common/ includes.
 968         * symfile.c: Fix common/ includes.
 969         * stap-probe.c: Fix common/ includes.
 970         * spu-linux-nat.c: Fix common/ includes.
 971         * sparc-nat.c: Fix common/ includes.
 972         * source.c: Fix common/ includes.
 973         * solib.c: Fix common/ includes.
 974         * solib-target.c: Fix common/ includes.
 975         * ser-unix.c: Fix common/ includes.
 976         * ser-tcp.c: Fix common/ includes.
 977         * ser-pipe.c: Fix common/ includes.
 978         * ser-base.c: Fix common/ includes.
 979         * selftest-arch.c: Fix common/ includes.
 980         * s12z-tdep.c: Fix common/ includes.
 981         * rust-exp.y: Fix common/ includes.
 982         * rs6000-aix-tdep.c: Fix common/ includes.
 983         * riscv-tdep.c: Fix common/ includes.
 984         * remote.c: Fix common/ includes.
 985         * remote-notif.h: Fix common/ includes.
 986         * remote-fileio.h: Fix common/ includes.
 987         * remote-fileio.c: Fix common/ includes.
 988         * regcache.h: Fix common/ includes.
 989         * regcache.c: Fix common/ includes.
 990         * record-btrace.c: Fix common/ includes.
 991         * python/python.c: Fix common/ includes.
 992         * python/py-type.c: Fix common/ includes.
 993         * python/py-inferior.c: Fix common/ includes.
 994         * progspace.h: Fix common/ includes.
 995         * producer.c: Fix common/ includes.
 996         * procfs.c: Fix common/ includes.
 997         * proc-api.c: Fix common/ includes.
 998         * printcmd.c: Fix common/ includes.
 999         * ppc-linux-nat.c: Fix common/ includes.
1000         * parser-defs.h: Fix common/ includes.
1001         * osdata.c: Fix common/ includes.
1002         * obsd-nat.c: Fix common/ includes.
1003         * nat/x86-linux.c: Fix common/ includes.
1004         * nat/x86-linux-dregs.c: Fix common/ includes.
1005         * nat/x86-dregs.h: Fix common/ includes.
1006         * nat/x86-dregs.c: Fix common/ includes.
1007         * nat/ppc-linux.c: Fix common/ includes.
1008         * nat/mips-linux-watch.h: Fix common/ includes.
1009         * nat/mips-linux-watch.c: Fix common/ includes.
1010         * nat/linux-waitpid.c: Fix common/ includes.
1011         * nat/linux-ptrace.h: Fix common/ includes.
1012         * nat/linux-ptrace.c: Fix common/ includes.
1013         * nat/linux-procfs.c: Fix common/ includes.
1014         * nat/linux-personality.c: Fix common/ includes.
1015         * nat/linux-osdata.c: Fix common/ includes.
1016         * nat/linux-namespaces.c: Fix common/ includes.
1017         * nat/linux-btrace.h: Fix common/ includes.
1018         * nat/linux-btrace.c: Fix common/ includes.
1019         * nat/fork-inferior.c: Fix common/ includes.
1020         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1021         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1022         * nat/aarch64-linux.c: Fix common/ includes.
1023         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1024         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1025         * namespace.h: Fix common/ includes.
1026         * mips-linux-tdep.c: Fix common/ includes.
1027         * minsyms.c: Fix common/ includes.
1028         * mi/mi-parse.h: Fix common/ includes.
1029         * mi/mi-main.c: Fix common/ includes.
1030         * mi/mi-cmd-env.c: Fix common/ includes.
1031         * memrange.h: Fix common/ includes.
1032         * memattr.c: Fix common/ includes.
1033         * maint.h: Fix common/ includes.
1034         * maint.c: Fix common/ includes.
1035         * main.c: Fix common/ includes.
1036         * machoread.c: Fix common/ includes.
1037         * location.c: Fix common/ includes.
1038         * linux-thread-db.c: Fix common/ includes.
1039         * linux-nat.c: Fix common/ includes.
1040         * linux-fork.c: Fix common/ includes.
1041         * inline-frame.c: Fix common/ includes.
1042         * infrun.c: Fix common/ includes.
1043         * inflow.c: Fix common/ includes.
1044         * inferior.h: Fix common/ includes.
1045         * inferior.c: Fix common/ includes.
1046         * infcmd.c: Fix common/ includes.
1047         * inf-ptrace.c: Fix common/ includes.
1048         * inf-child.c: Fix common/ includes.
1049         * ia64-linux-nat.c: Fix common/ includes.
1050         * i387-tdep.c: Fix common/ includes.
1051         * i386-tdep.c: Fix common/ includes.
1052         * i386-linux-tdep.c: Fix common/ includes.
1053         * i386-linux-nat.c: Fix common/ includes.
1054         * i386-go32-tdep.c: Fix common/ includes.
1055         * i386-fbsd-tdep.c: Fix common/ includes.
1056         * i386-fbsd-nat.c: Fix common/ includes.
1057         * guile/scm-type.c: Fix common/ includes.
1058         * guile/guile.c: Fix common/ includes.
1059         * go32-nat.c: Fix common/ includes.
1060         * gnu-nat.c: Fix common/ includes.
1061         * gdbthread.h: Fix common/ includes.
1062         * gdbarch-selftests.c: Fix common/ includes.
1063         * gdb_usleep.c: Fix common/ includes.
1064         * gdb_select.h: Fix common/ includes.
1065         * gdb_bfd.c: Fix common/ includes.
1066         * gcore.c: Fix common/ includes.
1067         * fork-child.c: Fix common/ includes.
1068         * findvar.c: Fix common/ includes.
1069         * fbsd-nat.c: Fix common/ includes.
1070         * event-top.c: Fix common/ includes.
1071         * event-loop.c: Fix common/ includes.
1072         * dwarf2read.c: Fix common/ includes.
1073         * dwarf2loc.c: Fix common/ includes.
1074         * dwarf2-frame.c: Fix common/ includes.
1075         * dwarf-index-cache.c: Fix common/ includes.
1076         * dtrace-probe.c: Fix common/ includes.
1077         * disasm-selftests.c: Fix common/ includes.
1078         * defs.h: Fix common/ includes.
1079         * csky-tdep.c: Fix common/ includes.
1080         * cp-valprint.c: Fix common/ includes.
1081         * cp-support.h: Fix common/ includes.
1082         * cp-support.c: Fix common/ includes.
1083         * corelow.c: Fix common/ includes.
1084         * completer.h: Fix common/ includes.
1085         * completer.c: Fix common/ includes.
1086         * compile/compile.c: Fix common/ includes.
1087         * compile/compile-loc2c.c: Fix common/ includes.
1088         * compile/compile-cplus-types.c: Fix common/ includes.
1089         * compile/compile-cplus-symbols.c: Fix common/ includes.
1090         * command.h: Fix common/ includes.
1091         * cli/cli-dump.c: Fix common/ includes.
1092         * cli/cli-cmds.c: Fix common/ includes.
1093         * charset.c: Fix common/ includes.
1094         * build-id.c: Fix common/ includes.
1095         * btrace.h: Fix common/ includes.
1096         * btrace.c: Fix common/ includes.
1097         * breakpoint.h: Fix common/ includes.
1098         * breakpoint.c: Fix common/ includes.
1099         * ax.h:
1100         (enum agent_op): Fix common/ includes.
1101         * ax-general.c (struct aop_map): Fix common/ includes.
1102         * ax-gdb.c: Fix common/ includes.
1103         * auxv.c: Fix common/ includes.
1104         * auto-load.c: Fix common/ includes.
1105         * arm-tdep.c: Fix common/ includes.
1106         * arch/riscv.c: Fix common/ includes.
1107         * arch/ppc-linux-common.c: Fix common/ includes.
1108         * arch/i386.c: Fix common/ includes.
1109         * arch/arm.c: Fix common/ includes.
1110         * arch/arm-linux.c: Fix common/ includes.
1111         * arch/arm-get-next-pcs.c: Fix common/ includes.
1112         * arch/amd64.c: Fix common/ includes.
1113         * arch/aarch64.c: Fix common/ includes.
1114         * arch/aarch64-insn.c: Fix common/ includes.
1115         * arch-utils.c: Fix common/ includes.
1116         * amd64-windows-tdep.c: Fix common/ includes.
1117         * amd64-tdep.c: Fix common/ includes.
1118         * amd64-sol2-tdep.c: Fix common/ includes.
1119         * amd64-obsd-tdep.c: Fix common/ includes.
1120         * amd64-nbsd-tdep.c: Fix common/ includes.
1121         * amd64-linux-tdep.c: Fix common/ includes.
1122         * amd64-linux-nat.c: Fix common/ includes.
1123         * amd64-fbsd-tdep.c: Fix common/ includes.
1124         * amd64-fbsd-nat.c: Fix common/ includes.
1125         * amd64-dicos-tdep.c: Fix common/ includes.
1126         * amd64-darwin-tdep.c: Fix common/ includes.
1127         * agent.c: Fix common/ includes.
1128         * ada-lang.h: Fix common/ includes.
1129         * ada-lang.c: Fix common/ includes.
1130         * aarch64-tdep.c: Fix common/ includes.
1131
1132 2019-01-25  Tom Tromey  <tom@tromey.com>
1133
1134         * common/create-version.sh: Use common/version.h.
1135
1136 2019-01-24  Pedro Alves  <palves@redhat.com>
1137
1138         * infrun.c (signal_stop, signal_print, signal_program)
1139         (signal_catch, signal_pass): Now arrays instead of pointers.
1140         (update_signals_program_target, do_target_resume)
1141         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1142         * linux-nat.c (linux_nat_target::pass_signals)
1143         (linux_nat_target::create_inferior, linux_nat_target::attach):
1144         Adjust.
1145         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1146         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1147         * procfs.c (procfs_target::pass_signals): Adjust.
1148         * record-full.c (record_full_target::resume): Adjust.
1149         * remote.c (remote_target::pass_signals)
1150         (remote_target::program_signals): Adjust.
1151         * target-debug.h (target_debug_print_signals): Now takes a
1152         gdb::array_view as parameter.  Adjust.
1153         * target.h (target_ops) <pass_signals, program_signals>: Replace
1154         pointer and length parameters with gdb::array_view.
1155         (target_pass_signals, target_program_signals): Likewise.
1156         * target-delegates.c: Regenerate.
1157
1158 2019-01-24  Pedro Alves  <palves@redhat.com>
1159
1160         * common/forward-scope-exit.h
1161         (forward_scope_exit::forward_scope_exit): Pass arguments to
1162         m_bind_function directly, instead of creating a std::bind and
1163         copying that.
1164
1165 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1166
1167         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1168         for static members.
1169         (pass_in_v_vfp_candidate): Likewise.
1170
1171 2019-01-23  Tom Tromey  <tom@tromey.com>
1172             Pedro Alves  <palves@redhat.com>
1173
1174         * regcache.c (class regcache_invalidator): Remove.
1175         (regcache::raw_write): Use make_scope_exit.
1176
1177 2019-01-23  Tom Tromey  <tom@tromey.com>
1178
1179         * ui-out.h (class ui_out_emit_type): Update comment.
1180
1181 2019-01-23  Tom Tromey  <tom@tromey.com>
1182
1183         * infrun.c (fetch_inferior_event): Update comment.
1184
1185 2019-01-23  Tom Tromey  <tom@tromey.com>
1186             Pedro Alves  <palves@redhat.com>
1187
1188         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1189         parameter.
1190         (fetch_inferior_event): Use SCOPE_EXIT.
1191
1192
1193 2019-01-23  Tom Tromey  <tom@tromey.com>
1194             Pedro Alves  <palves@redhat.com>
1195
1196         * infrun.c (disable_thread_events): Delete.
1197         (stop_all_threads): Use SCOPE_EXIT.
1198
1199 2019-01-23  Tom Tromey  <tom@tromey.com>
1200             Pedro Alves  <palves@redhat.com>
1201
1202         * symfile.c: Include forward-scope-exit.h.
1203         (clear_symtab_users_cleanup): Replace forward declaration with
1204         a FORWARD_SCOPE_EXIT.
1205         (syms_from_objfile_1): Use the forward_scope_exit and
1206         gdb::optional instead of cleanup_function.
1207         (reread_symbols): Use the forward_scope_exit instead of
1208         cleanup_function.
1209         (clear_symtab_users_cleanup): Remove function.
1210
1211 2019-01-23  Tom Tromey  <tom@tromey.com>
1212             Pedro Alves  <palves@redhat.com>
1213
1214         * linux-nat.c: Include scope-exit.h.
1215         (cleanup_target_stop): Remove.
1216         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1217         SCOPE_EXIT.
1218
1219 2019-01-23  Tom Tromey  <tom@tromey.com>
1220             Pedro Alves  <palves@redhat.com>
1221
1222         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1223         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1224
1225 2019-01-23  Tom Tromey  <tom@tromey.com>
1226             Andrew Burgess  <andrew.burgess@embecosm.com>
1227             Pedro Alves  <palves@redhat.com>
1228
1229         * infrun.c (fetch_inferior_event): Use scope_exit.
1230         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1231         * top.c (execute_command): Use scope_exit.
1232         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1233         * utils.c (do_bpstat_clear_actions_cleanup)
1234         (make_bpstat_clear_actions_cleanup): Remove.
1235
1236 2019-01-23  Tom Tromey  <tom@tromey.com>
1237             Pedro Alves  <palves@redhat.com>
1238
1239         * infrun.c: Include "common/scope-exit.h"
1240         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1241         (wait_for_inferior): Use SCOPE_EXIT.
1242         (fetch_inferior_event): Use scope_exit.
1243
1244 2019-01-23  Tom Tromey  <tom@tromey.com>
1245             Pedro Alves  <palves@redhat.com>
1246
1247         * breakpoint.c (create_breakpoint): Remove cleanup.
1248
1249 2019-01-23  Tom Tromey  <tom@tromey.com>
1250             Andrew Burgess  <andrew.burgess@embecosm.com>
1251             Pedro Alves  <palves@redhat.com>
1252
1253 2019-01-23  Pedro Alves  <palves@redhat.com>
1254
1255         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1256
1257 2019-01-23  Pedro Alves  <palves@redhat.com>
1258             Andrew Burgess  <andrew.burgess@embecosm.com>
1259
1260         * gdbthread.h: Include "common/forward-scope-exit.h".
1261         (scoped_finish_thread_state): Redefine custom class in terms of
1262         forward_scope_exit.
1263
1264 2019-01-23  Pedro Alves  <palves@redhat.com>
1265             Andrew Burgess  <andrew.burgess@embecosm.com>
1266
1267         * common/forward-scope-exit.h: New file.
1268
1269 2019-01-23  Pedro Alves  <palves@redhat.com>
1270             Andrew Burgess  <andrew.burgess@embecosm.com>
1271             Tom Tromey  <tom@tromey.com>
1272
1273         * common/scope-exit.h: New file.
1274
1275 2019-01-23  Pedro Alves  <palves@redhat.com>
1276
1277         * common/preprocessor.h (ESC): Rename to ...
1278         (ESC_PARENS): ... this.
1279         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1280         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1281
1282 2019-01-23  Tom Tromey  <tom@tromey.com>
1283
1284         * language.h (class scoped_switch_to_sym_language_if_auto):
1285         Initialize m_lang in both cases.
1286
1287 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1288
1289         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1290         with XCNEW.
1291
1292 2019-01-22  Tom Tromey  <tom@tromey.com>
1293
1294         * corelow.c: Do not include sys/file.h.
1295
1296 2019-01-22  Tom Tromey  <tom@tromey.com>
1297
1298         * tui/tui-wingeneral.h: Include gdb_curses.h.
1299
1300 2019-01-22  Tom Tromey  <tom@tromey.com>
1301
1302         * source-cache.h (class source_cache) <get_source_lines,
1303         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1304
1305 2019-01-22  Tom Tromey  <tom@tromey.com>
1306
1307         * remote-fileio.h (struct remote_target): Declare.
1308
1309 2019-01-22  Tom Tromey  <tom@tromey.com>
1310
1311         * python/py-arch.c: Do not include py-ref.h.
1312         * python/py-bpevent.c: Do not include py-ref.h.
1313         * python/py-cmd.c: Do not include py-ref.h.
1314         * python/py-continueevent.c: Do not include py-ref.h.
1315         * python/py-event.h: Do not include py-ref.h.
1316         * python/py-evtregistry.c: Do not include py-ref.h.
1317         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1318         * python/py-frame.c: Do not include py-ref.h.
1319         * python/py-framefilter.c: Do not include py-ref.h.
1320         * python/py-function.c: Do not include py-ref.h.
1321         * python/py-infevents.c: Do not include py-ref.h.
1322         * python/py-linetable.c: Do not include py-ref.h.
1323         * python/py-objfile.c: Do not include py-ref.h.
1324         * python/py-param.c: Do not include py-ref.h.
1325         * python/py-prettyprint.c: Do not include py-ref.h.
1326         * python/py-progspace.c: Do not include py-ref.h.
1327         * python/py-symbol.c: Do not include py-ref.h.
1328         * python/py-symtab.c: Do not include py-ref.h.
1329         * python/py-type.c: Do not include py-ref.h.
1330         * python/py-unwind.c: Do not include py-ref.h.
1331         * python/py-utils.c: Do not include py-ref.h.
1332         * python/py-value.c: Do not include py-ref.h.
1333         * python/py-varobj.c: Do not include py-ref.h.
1334         * python/py-xmethods.c: Do not include py-ref.h.
1335         * python/python.c: Do not include py-ref.h.
1336         * varobj.c: Do not include py-ref.h.
1337
1338 2019-01-22  Tom Tromey  <tom@tromey.com>
1339
1340         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1341         keyword for bcache.
1342
1343 2019-01-22  Tom Tromey  <tom@tromey.com>
1344
1345         * compile/compile-cplus-types.c: Remove a comment by #include.
1346
1347 2019-01-22  Tom Tromey  <tom@tromey.com>
1348
1349         * compile/gcc-c-plugin.h: Include compile-internal.h.
1350
1351 2019-01-22  Tom Tromey  <tom@tromey.com>
1352
1353         * stabsread.c (EXTERN): Do not define.
1354         (symnum, next_symbol_text_func, processing_gcc_compilation)
1355         (within_function, global_sym_chain, global_stabs)
1356         (previous_stab_code, this_object_header_files)
1357         (n_this_object_header_files)
1358         (n_allocated_this_object_header_files): Define.
1359         * stabsread.h (EXTERN): Never define.  Use "extern".
1360
1361 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1362
1363         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1364         history_value.
1365
1366 2019-01-21  Tom Tromey  <tom@tromey.com>
1367
1368         * ui-out.c: Fix includes.
1369         * tui/tui-source.c: Fix includes.
1370         * target.c: Fix includes.
1371         * remote.c: Fix includes.
1372         * regcache.c: Fix includes.
1373         * python/py-block.c: Fix includes.
1374         * printcmd.c: Fix includes.
1375         * or1k-tdep.c: Fix includes.
1376         * mi/mi-main.c: Fix includes.
1377         * m32r-tdep.c: Fix includes.
1378         * csky-tdep.c: Fix includes.
1379         * compile/compile-cplus-types.c: Fix includes.
1380         * cli/cli-interp.c: Fix includes.
1381
1382 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1383
1384         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1385         for padding.
1386
1387 2019-01-16  Tom Tromey  <tom@tromey.com>
1388
1389         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1390         earlier.
1391         (struct objfile) <msymbols_range>: Move from top level.
1392         <msymbols>: New method.
1393         (class objfile_msymbols): Remove.
1394         * symtab.c (default_collect_symbol_completion_matches_break_on):
1395         Update.
1396         * symmisc.c (dump_msymbols): Update.
1397         * stabsread.c (scan_file_globals): Update.
1398         * objc-lang.c (info_selectors_command, info_classes_command)
1399         (find_methods): Update.
1400         * minsyms.c (find_solib_trampoline_target): Update.
1401         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1402         * coffread.c (coff_symfile_read): Update.
1403         * ada-lang.c (ada_lookup_simple_minsym)
1404         (ada_collect_symbol_completion_matches): Update.
1405
1406 2019-01-16  Tom Tromey  <tom@tromey.com>
1407
1408         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1409         type.  Remove no-argument constructor.
1410         <iterator::operator++>: Simplify.
1411         <begin>: Update.
1412         <end>: Use minimal_symbol_count.
1413
1414 2019-01-16  Tom Tromey  <tom@tromey.com>
1415
1416         * objfiles.h (struct objfile) <psymtabs>: New method.
1417         (class objfile_psymtabs): Remove.
1418         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1419         typedef.
1420         <range>: New method.
1421         (require_partial_symbols): Change return type.
1422         * psymtab.c (require_partial_symbols)
1423         (psym_expand_symtabs_matching): Update.
1424         * mdebugread.c (parse_partial_symbols): Update.
1425         * dbxread.c (dbx_end_psymtab): Update.
1426
1427 2019-01-15  Tom Tromey  <tom@tromey.com>
1428
1429         * symtab.c (lookup_objfile_from_block)
1430         (lookup_symbol_in_objfile_symtabs)
1431         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1432         (find_line_symtab, info_sources_command)
1433         (default_collect_symbol_completion_matches_break_on)
1434         (make_source_files_completion_list): Update.
1435         * symmisc.c (print_objfile_statistics, dump_objfile)
1436         (maintenance_print_symbols, maintenance_info_symtabs)
1437         (maintenance_check_symtabs, maintenance_info_line_tables):
1438         Update.
1439         * source.c (select_source_symtab)
1440         (forget_cached_source_info_for_objfile): Update.
1441         * objfiles.h (class objfile_compunits): Remove.
1442         (struct objfile) <compunits_range>: New typedef.
1443         (compunits): New method.
1444         * objfiles.c (objfile_relocate1): Update.
1445         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1446         * maint.c (count_symtabs_and_blocks): Update.
1447         * linespec.c (iterate_over_all_matching_symtabs): Update.
1448         * cp-support.c (add_symbol_overload_list_qualified): Update.
1449         * coffread.c (coff_symtab_read): Update.
1450         * ada-lang.c (add_nonlocal_symbols)
1451         (ada_collect_symbol_completion_matches)
1452         (ada_add_global_exceptions): Update.
1453
1454 2019-01-15  Tom Tromey  <tom@tromey.com>
1455
1456         * progspace.h (program_space) <objfiles_safe_range>: New
1457         typedef.
1458         <objfiles_safe>: New method.
1459         * objfiles.h (class all_objfiles_safe): Remove.
1460         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1461         * jit.c (jit_inferior_exit_hook): Update.
1462
1463 2019-01-17  Tom Tromey  <tom@tromey.com>
1464
1465         * progspace.h (program_space) <objfiles_range>: New typedef.
1466         <objfiles>: New method.
1467         <objfiles_head>: Rename from objfiles.
1468         (object_files): Update.
1469         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1470         * guile/scm-pretty-print.c
1471         (ppscm_find_pretty_printer_from_objfiles): Update.
1472         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1473         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1474         Update.
1475         * python/py-progspace.c (pspy_get_objfiles): Update.
1476         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1477         Update.
1478         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1479         (objfpy_lookup_objfile_by_build_id): Update.
1480         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1481         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1482         Update.
1483         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1484         (expand_symtab_containing_pc, lookup_objfile_from_block)
1485         (lookup_static_symbol, basic_lookup_transparent_type)
1486         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1487         (find_line_symtab, info_sources_command)
1488         (default_collect_symbol_completion_matches_break_on)
1489         (make_source_files_completion_list, find_main_name): Update.
1490         * symmisc.c (print_symbol_bcache_statistics)
1491         (print_objfile_statistics, maintenance_print_symbols)
1492         (maintenance_print_msymbols, maintenance_print_objfiles)
1493         (maintenance_info_symtabs, maintenance_check_symtabs)
1494         (maintenance_expand_symtabs, maintenance_info_line_tables):
1495         Update.
1496         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1497         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1498         (map_overlay_command, unmap_overlay_command)
1499         (simple_overlay_update, expand_symtabs_matching)
1500         (map_symbol_filenames): Update.
1501         * symfile-debug.c (set_debug_symfile): Update.
1502         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1503         Update.
1504         * source.c (select_source_symtab, forget_cached_source_info):
1505         Update.
1506         * solib.c (solib_read_symbols): Update.
1507         * solib-spu.c (append_ocl_sos): Update.
1508         * psymtab.c (maintenance_print_psymbols)
1509         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1510         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1511         * printcmd.c (info_symbol_command): Update.
1512         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1513         Update.
1514         * objfiles.h (class all_objfiles): Remove.
1515         * objfiles.c (have_partial_symbols, have_full_symbols)
1516         (have_minimal_symbols, qsort_cmp, update_section_map)
1517         (shared_objfile_contains_address_p)
1518         (default_iterate_over_objfiles_in_search_order): Update.
1519         * objc-lang.c (info_selectors_command, info_classes_command)
1520         (find_methods): Update.
1521         * minsyms.c (find_solib_trampoline_target): Update.
1522         * maint.c (maintenance_info_sections)
1523         (maintenance_translate_address, count_symtabs_and_blocks):
1524         Update.
1525         * main.c (captured_main_1): Update.
1526         * linux-thread-db.c (try_thread_db_load_from_pdir)
1527         (has_libpthread): Update.
1528         * linespec.c (iterate_over_all_matching_symtabs)
1529         (search_minsyms_for_name): Update.
1530         * jit.c (jit_find_objf_with_entry_addr): Update.
1531         * hppa-tdep.c (find_unwind_entry)
1532         (hppa_lookup_stub_minimal_symbol): Update.
1533         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1534         Update.
1535         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1536         (elf_gnu_ifunc_resolve_by_got): Update.
1537         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1538         * dwarf-index-write.c (save_gdb_index_command): Update.
1539         * cp-support.c (add_symbol_overload_list_qualified): Update.
1540         * breakpoint.c (create_overlay_event_breakpoint)
1541         (create_longjmp_master_breakpoint)
1542         (create_std_terminate_master_breakpoint)
1543         (create_exception_master_breakpoint): Update.
1544         * blockframe.c (find_pc_partial_function): Update.
1545         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1546         (ada_collect_symbol_completion_matches)
1547         (ada_add_global_exceptions): Update.
1548
1549 2019-01-17  Tom Tromey  <tom@tromey.com>
1550
1551         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1552         declare VEC.
1553         (solib_target_parse_libraries): Change return type.
1554         (library_list_start_segment, library_list_start_section)
1555         (library_list_end_library, library_list_start_library); Update.
1556         (solib_target_free_library_list): Remove.
1557         (solib_target_parse_libraries): Remove cleanup.  Change return
1558         type.
1559         (solib_target_current_sos): Update.
1560
1561 2019-01-17  Tom Tromey  <tromey@bapiya>
1562
1563         * valprint.c: Replace "the the" with "the".
1564         * symtab.c: Replace "the the" with "the".
1565         * solib.c: Replace "the the" with "the".
1566         * solib-dsbt.c: Replace "the the" with "the".
1567         * linespec.c: Replace "the the" with "the".
1568         * dwarf2loc.h: Replace "the the" with "the".
1569         * amd64-windows-tdep.c: Replace "the the" with "the".
1570         * aarch64-tdep.c: Replace "the the" with "the".
1571
1572 2019-01-16  Keith Seitz  <keiths@redhat.com>
1573
1574         PR gdb/23773
1575         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1576         <builder>: Rename to ..
1577         <m_builder>: ... this and make private.
1578         (dwarf2_cu::get_builder): New method.  Change all users of
1579         `builder' to use this method.
1580         (dwarf2_start_symtab): Move to ...
1581         (dwarf2_cu::start_symtab): ... here.  Update all callers
1582         (setup_type_unit_groups): Move to ...
1583         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1584         callers.
1585         (dwarf2_cu::reset_builder): New method.
1586         (process_full_compunit, process_full_type_unit): Use
1587         dwarf2_cu::reset_builder.
1588         (follow_die_offset): Record the ancestor CU if it is different
1589         from the followed DIE's CU.
1590         (follow_die_sig_1): Likewise.
1591
1592 2019-01-15  Tom Tromey  <tom@tromey.com>
1593
1594         * remote.c (class remote_state) <buf>: Now a char_vector.
1595         <buf_size>: Remove.
1596         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1597         parameter.
1598         (remote_target::getpkt_or_notif_sane_1)
1599         (remote_target::getpkt_sane)
1600         (remote_target::getpkt_or_notif_sane): Likewise.
1601         (class remote_target) <putpkt>: New overload.
1602         (remote_target::read_frame): Change type of "buf_p".  Remove
1603         sizeof_p parameter.
1604         (packet_ok): New overload.
1605         (packet_check_result): New overload.
1606         Update all uses.
1607
1608 2019-01-14  Tom Tromey  <tom@tromey.com>
1609
1610         * remote-notif.c (handle_notification, remote_notif_ack)
1611         (remote_notif_parse): Make "buf" const.
1612         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1613         const.
1614         (remote_notif_parse, remote_notif_ack, handle_notification):
1615         Likewise.
1616         * remote.c (remote_notif_stop_parse): Make "buf" const.
1617         (remote_target::remote_parse_stop_reply): Make "buf" const.
1618         (remote_notif_stop_ack): Make "buf" const.
1619
1620 2019-01-14  Tom Tromey  <tom@tromey.com>
1621
1622         * remote.c (remote_console_output): Make parameter const.
1623
1624 2019-01-14  Tom Tromey  <tom@tromey.com>
1625
1626         * target-debug.h (target_debug_print_signals): Constify.
1627         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1628         * procfs.c (procfs_target::pass_signals): Update.
1629         * linux-nat.c (linux_nat_target::pass_signals): Update.
1630         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1631         * target-delegates.c: Rebuild.
1632         * remote.c (remote_target::program_signals): Update.
1633         (remote_target::pass_signals): Update.
1634         * target.c (target_pass_signals): Constify argument.
1635         (target_program_signals): Likewise.
1636         * target.h (struct target_ops) <pass_signals, program_signals>:
1637         Constify argument.
1638         (target_pass_signals, target_program_signals): Constify argument.
1639
1640 2019-01-14  Tom Tromey  <tom@tromey.com>
1641
1642         PR tui/28819:
1643         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1644
1645 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1646
1647         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1648         field.
1649         * rs6000-tdep.c: Include reggroups.h.
1650         (IS_V_ALIAS_PSEUDOREG): Define.
1651         (rs6000_register_name): Return names for the "vX" aliases.
1652         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1653         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1654         aliases.  Call default_register_reggroup_p for all other
1655         pseudo-registers.
1656         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1657         New functions.
1658         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1659         Handle "vX" aliases.
1660         (v_alias_pseudo_register_collect): New function.
1661         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1662         (rs6000_gdbarch_init): Initialize "vX" aliases as
1663         pseudo-registers.  Restore registration of
1664         rs6000_pseudo_register_reggroup_p with
1665         set_tdesc_pseudo_register_reggroup_p.
1666
1667 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1668
1669         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1670         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1671         set_gdbarch_num_pseudo_regs.
1672
1673 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1674
1675         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1676         Remove arg prefixname, add do_set and do_show.
1677         Add member functions set_list and show_list.
1678         * cli/cli-style.c (class cli_style_option): Update accordingly.
1679         (style_set_list): Move to file scope.
1680         (style_show_list): Likewise.
1681         (set_style): Call help_list.
1682         (show_style): Call cmd_show_list.
1683         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1684         Update to use the new macro.
1685
1686 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1687
1688         * ada-lang.c (_initialize_ada_language): Expand the help text
1689         for the "catch exception" command.
1690
1691 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1692
1693         * symtab.c (matching_obj_sections): Initialize obj,
1694         declare it closer to its usage.
1695
1696 2019-01-10  Tom Tromey  <tom@tromey.com>
1697
1698         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1699         (basic_inf_threads_range): Remove.
1700         (inf_threads_range, inf_non_exited_threads_range)
1701         (safe_inf_threads_range): Use next_adapter.
1702
1703 2019-01-10  Keith Seitz  <keiths@redhat.com>
1704
1705         PR gdb/23712
1706         PR symtab/23010
1707         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1708         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1709
1710 2019-01-10  Keith Seitz  <keiths@redhat.com>
1711
1712         PR gdb/23712
1713         PR symtab/23010
1714         * dictionary.c (pending_to_vector): Remove.
1715         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1716         Remove _1 suffix, replacing functions of the same name.  Update
1717         all callers.
1718         (dict_create_hashed, dict_create_hashed_expandable)
1719         (dict_create_linear, dict_create_linear_expandable, dict_free)
1720         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1721         Make functions static.
1722
1723 2019-01-10  Keith Seitz  <keiths@redhat.com>
1724
1725         PR gdb/23712
1726         PR symtab/23010
1727         * dictionary.h (struct dictionary): Replace declaration with
1728         multidictionary.
1729         (dict_create_hashed, dict_create_hashed_expandable)
1730         (dict_create_linear, dict_create_linear_expandable)
1731         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1732         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1733         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1734         taking multidictionary argument.
1735         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1736         * block.h (struct block) <dict>: Change to multidictionary
1737         and rename `multidict'.
1738         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1739         symmisc.c: Update all dictionary references to multidictionary.
1740
1741 2019-01-10  Keith Seitz  <keiths@redhat.com>
1742
1743         PR gdb/23712
1744         PR symtab/23010
1745         * dictionary.c: Include unordered_map.
1746         (pending_to_vector): New function.
1747         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1748         Rewrite the non-"_1" functions to take vector instead
1749         of linked list.
1750         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1751         "new" _1 versions of the same name.
1752         (multidictionary): Define.
1753         (std::hash<enum language): New definition.
1754         (collate_pending_symbols_by_language, mdict_create_hashed)
1755         (mdict_create_hashed_expandable, mdict_create_linear)
1756         (mdict_create_linear_expandable, mdict_free)
1757         (find_language_dictionary, create_new_language_dictionary)
1758         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1759         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1760         (mdict_size, mdict_empty): New functions.
1761         * dictionary.h (mdict_iterator): Define.
1762
1763 2019-01-10  Pedro Alves  <palves@redhat.com>
1764
1765         * breakpoint.c (read_uploaded_action)
1766         (create_tracepoint_from_upload): Adjust to use
1767         gdb::unique_xmalloc_ptr.
1768         * ctf.c (ctf_write_uploaded_tp):
1769         (SET_ARRAY_FIELD): Use emplace_back.
1770         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1771         * tracefile-tfile.c (tfile_write_uploaded_tp):
1772         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1773         gdb::unique_xmalloc_ptr.
1774         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1775         at_string, cond_string, cmd_strings>: Replace char pointers
1776         with gdb::unique_xmalloc_ptr.
1777
1778 2019-01-10  Pedro Alves  <palves@redhat.com>
1779
1780         * solib-target.c (library_list_start_library): Don't xstrdup name.
1781
1782 2019-01-10  Pedro Alves  <palves@redhat.com>
1783
1784         * mdebugread.c (parse_partial_symbols): Use
1785         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1786
1787 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1788
1789         * linux-fork.c (scoped_switch_fork_info)
1790         <~scoped_switch_fork_info>: Fix incorrect variable name.
1791
1792 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1793
1794         * linux-fork.c (scoped_switch_fork_info)
1795         <scoped_switch_fork_info>: Make explicit.
1796         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1797
1798 2019-01-10  Tom Tromey  <tom@tromey.com>
1799
1800         * objfiles.h (objfile::reset_psymtabs): Update.
1801         * objfiles.c (objfile::objfile): Update.
1802         * psymtab.h (psymtab_storage::obstack): Update.
1803         (psymtab_storage::m_obstack): Use gdb::optional.
1804         (class psymtab_storage): Update comment.  Remove objfile
1805         parameter.
1806         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1807
1808 2019-01-10  Tom Tromey  <tom@tromey.com>
1809
1810         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1811         <free_psymtabs>: Now private.
1812         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1813         (allocate_psymtab): Use new method.
1814
1815 2019-01-10  Tom Tromey  <tom@tromey.com>
1816
1817         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1818         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1819         * mdebugread.c (parse_partial_symbols): Use
1820         allocate_dependencies.
1821         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1822         allocate_dependencies.
1823         (process_psymtab_comp_unit_reader)
1824         (build_type_psymtab_dependencies): Likewise.
1825         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1826
1827 2019-01-10  Tom Tromey  <tom@tromey.com>
1828
1829         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1830         PSYMBOL_SET_LANGUAGE.
1831         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1832
1833 2019-01-10  Tom Tromey  <tom@tromey.com>
1834
1835         * psymtab.h (psymtab_storage::obstack): New method.
1836         <m_obstack>: Rename from obstack; now private.
1837         * psymtab.c (psymtab_storage): Update.
1838         * dwarf2read.c (create_addrmap_from_index)
1839         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1840         Update.
1841
1842 2019-01-10  Tom Tromey  <tom@tromey.com>
1843
1844         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1845         * objfiles.h (objfile::reset_psymtabs): New method.
1846
1847 2019-01-10  Tom Tromey  <tom@tromey.com>
1848
1849         * symmisc.c (print_symbol_bcache_statistics): Update.
1850         (print_objfile_statistics): Update.
1851         * symfile.c (reread_symbols): Update.
1852         * psymtab.h (class psymtab_storage): New.
1853         * psymtab.c (psymtab_storage): New constructor.
1854         (~psymtab_storage): New destructor.
1855         (require_partial_symbols): Update.
1856         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1857         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1858         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1859         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1860         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1861         (start_psymtab_common, end_psymtab_common)
1862         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1863         (allocate_psymtab): Update.
1864         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1865         Update.
1866         (dump_psymtab_addrmap, maintenance_print_psymbols)
1867         (maintenance_check_psymtabs): Update.
1868         (class objfile_psymtabs): Move to objfiles.h.
1869         * psympriv.h (discard_psymtab): Now inline.
1870         (psymtab_discarder::psymtab_discarder): Update.
1871         (psymtab_discarder::~psymtab_discarder): Update.
1872         (ALL_OBJFILE_PSYMTABS): Rewrite.
1873         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1874         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1875         Remove fields.
1876         <partial_symtabs>: New field.
1877         (class objfile_psymtabs): Move from psymtab.h.  Update.
1878         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1879         psymbol_cache.
1880         (objfile::~objfile): Don't destroy psymbol_cache.
1881         * mdebugread.c (parse_partial_symbols): Update.
1882         * dwarf2read.c (create_addrmap_from_index)
1883         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1884         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1885         (add_partial_subprogram, dwarf2_ranges_read): Update.
1886         * dwarf-index-write.c (write_address_map)
1887         (write_one_signatured_type, recursively_write_psymbols)
1888         (class debug_names, class debug_names, write_psymtabs_to_index):
1889         Update.
1890
1891 2019-01-10  Tom Tromey  <tom@tromey.com>
1892
1893         * symtab.h (SYMBOL_SET_NAMES): Update.
1894         (symbol_set_names): Update.
1895         (MSYMBOL_SET_NAMES): Update.
1896         * symtab.c (symbol_set_names): Change argument to be an
1897         objfile_per_bfd_storage.
1898         * psymtab.c (add_psymbol_to_bcache): Update.
1899         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1900
1901 2019-01-10  Tom Tromey  <tom@tromey.com>
1902
1903         * symtab.c (create_demangled_names_hash): Change argument to be an
1904         objfile_per_bfd_storage.
1905         (symbol_set_names): Update.
1906
1907 2019-01-10  Tom Tromey  <tom@tromey.com>
1908
1909         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1910         init_psymbol_list.
1911         * psymtab.c (init_psymbol_list): Do nothing if already called.
1912         * psympriv.h (init_psymbol_list): Add comment.
1913         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1914         init_psymbol_list.
1915         * dbxread.c (dbx_symfile_read): Unconditionally call
1916         init_psymbol_list.
1917
1918 2019-01-10  Tom Tromey  <tom@tromey.com>
1919
1920         * xcoffread.c (scan_xcoff_symtab): Update.
1921         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1922         "where".
1923         * mdebugread.c (parse_partial_symbols)
1924         (handle_psymbol_enumerators): Update.
1925         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1926         * dbxread.c (read_dbx_symtab): Update.
1927         * psympriv.h (psymbol_placement): New enum.
1928         (add_psymbol_to_list): Update.
1929
1930 2019-01-10  Tom Tromey  <tom@tromey.com>
1931
1932         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1933         static_psymbols parameters.
1934         (scan_xcoff_symtab): Update.
1935         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1936         static_psymbols parameters.
1937         * psympriv.h (start_psymtab_common): Update.
1938         * mdebugread.c (parse_partial_symbols): Update.
1939         * dwarf2read.c (create_partial_symtab): Update.
1940         * dbxread.c (read_dbx_symtab): Update.
1941         (start_psymtab): Remove global_psymbols and static_psymbols
1942         parameters.
1943
1944 2019-01-10  Tom Tromey  <tom@tromey.com>
1945
1946         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1947         * psymtab.c (allocate_psymtab): Add comment.
1948         * psympriv.h (allocate_psymtab): Add comment.
1949         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1950         initializations.
1951         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1952
1953 2019-01-10  Tom Tromey  <tom@tromey.com>
1954
1955         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1956         Don't declare.
1957         * mipsread.c: Include mdebugread.h.
1958         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1959         Declare.
1960         * elfread.c: Include mdebugread.h.
1961
1962 2019-01-09  Tom Tromey  <tom@tromey.com>
1963
1964         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1965         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1966         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1967         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1968         (psym_lookup_symbol, psym_find_last_source_symtab)
1969         (psym_forget_cached_source_info, psym_print_stats)
1970         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1971         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1972         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1973         (psym_find_compunit_symtab_by_address)
1974         (maintenance_print_psymbols, maintenance_info_psymtabs)
1975         (maintenance_check_psymtabs): Use ranged for.
1976         * psymtab.h (class objfile_psymtabs): New.
1977         (require_partial_symbols): Return objfile_psymtabs.
1978         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1979
1980 2019-01-09  Tom Tromey  <tom@tromey.com>
1981
1982         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1983         (find_pc_mapped_section, list_overlays_command)
1984         (map_overlay_command, unmap_overlay_command)
1985         (simple_overlay_update): Use all_objfiles.
1986         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1987         * printcmd.c (info_symbol_command): Use all_objfiles.
1988         * objfiles.h (ALL_OBJSECTIONS): Remove.
1989         * maint.c (maintenance_translate_address): Use all_objfiles.
1990         * gcore.c (gcore_create_callback): Use all_objfiles.
1991         (objfile_find_memory_regions): Likewise.
1992
1993 2019-01-09  Tom Tromey  <tom@tromey.com>
1994
1995         * symtab.c (find_line_symtab, info_sources_command)
1996         (make_source_files_completion_list): Use objfile_compunits.
1997         * source.c (select_source_symtab): Use objfile_compunits.
1998         * objfiles.h (struct objfile): Update comment.
1999         (ALL_OBJFILES): Remove.
2000         (ALL_FILETABS): Remove.
2001         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2002         objfile_compunits.
2003
2004 2019-01-09  Tom Tromey  <tom@tromey.com>
2005
2006         * symmisc.c (print_objfile_statistics, dump_objfile)
2007         (maintenance_print_symbols): Use compunit_filetabs.
2008         * source.c (forget_cached_source_info_for_objfile): Use
2009         compunit_filetabs.
2010         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2011         (ALL_FILETABS): Use compunit_filetabs.
2012         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2013         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2014
2015 2019-01-09  Tom Tromey  <tom@tromey.com>
2016
2017         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2018         (compunit_filetabs): New.
2019         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2020         compunit_filetabs.
2021         (info_sources_command, make_source_files_completion_list): Remove
2022         declaration.
2023         * symmisc.c (print_objfile_statistics, dump_objfile)
2024         (maintenance_print_symbols): Remove declaration.
2025         (maintenance_info_symtabs): Use compunit_filetabs.
2026         (maintenance_info_line_tables): Likewise.
2027         * source.c (select_source_symtab): Change local variable name.
2028         (forget_cached_source_info_for_objfile): Remove declaration.
2029         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2030         * objfiles.c (objfile_relocate1): Remove declaration.
2031         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2032         declaration.
2033         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2034         * coffread.c (coff_symtab_read): Remove declaration.
2035         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2036         compunit_filetabs.
2037
2038 2019-01-09  Tom Tromey  <tom@tromey.com>
2039
2040         * symtab.c (lookup_objfile_from_block)
2041         (find_pc_sect_compunit_symtab, search_symbols)
2042         (default_collect_symbol_completion_matches_break_on): Use
2043         objfile_compunits.
2044         * objfiles.h (ALL_COMPUNITS): Remove.
2045         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2046         * cp-support.c (add_symbol_overload_list_qualified): Use
2047         objfile_compunits.
2048         * ada-lang.c (ada_collect_symbol_completion_matches)
2049         (ada_add_global_exceptions): Use objfile_compunits.
2050
2051 2019-01-09  Tom Tromey  <tom@tromey.com>
2052
2053         * source.c (select_source_symtab)
2054         (forget_cached_source_info_for_objfile): Remove declaration.
2055         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2056         declaration.
2057         * maint.c (count_symtabs_and_blocks): Remove declaration.
2058         * cp-support.c (add_symbol_overload_list_qualified): Remove
2059         declaration.
2060         * coffread.c (coff_symtab_read): Remove declaration.
2061         * symtab.c (lookup_symbol_in_objfile_symtabs)
2062         (basic_lookup_transparent_type_1): Use objfile_compunits.
2063         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2064         (info_sources_command, search_symbols)
2065         (default_collect_symbol_completion_matches_break_on)
2066         (make_source_files_completion_list): Remove declaration.
2067         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2068         (ada_collect_symbol_completion_matches)
2069         (ada_add_global_exceptions): Remove declaration.
2070         * linespec.c (iterate_over_all_matching_symtabs): Use
2071         objfile_compunits.
2072         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2073         (class objfile_compunits): New.
2074         (ALL_COMPUNITS): Use objfile_compunits.
2075         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2076         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2077         objfile_compunits.
2078         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2079
2080 2019-01-09  Tom Tromey  <tom@tromey.com>
2081
2082         * symtab.c (search_symbols)
2083         (default_collect_symbol_completion_matches_break_on): Use
2084         objfile_msymbols.
2085         * ada-lang.c (ada_lookup_simple_minsym)
2086         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2087         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2088         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2089         objfile_msymbols.
2090         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2091         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2092         * objc-lang.c (find_methods): Use objfile_msymbols.
2093         (info_selectors_command, info_classes_command): Likewise.
2094         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2095         * objfiles.h (class objfile_msymbols): New.
2096         (ALL_OBJFILE_MSYMBOLS): Remove.
2097         (ALL_MSYMBOLS): Remove.
2098
2099 2019-01-09  Tom Tromey  <tom@tromey.com>
2100
2101         * common/next-iterator.h (next_adapter): Add Iterator template
2102         parameter.
2103         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2104         (class all_objfiles_safe): New.
2105         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2106         * objfiles.c (put_objfile_before): Update comment.
2107         (add_separate_debug_objfile): Likewise.
2108         (free_all_objfiles): Use all_objfiles_safe.
2109         (objfile_purge_solibs): Likewise.
2110
2111 2019-01-09  Tom Tromey  <tom@tromey.com>
2112
2113         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2114         (expand_symtab_containing_pc, lookup_static_symbol)
2115         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2116         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2117         all_objfiles.
2118         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2119         * breakpoint.c (create_overlay_event_breakpoint)
2120         (create_longjmp_master_breakpoint)
2121         (create_std_terminate_master_breakpoint)
2122         (create_exception_master_breakpoint): Use all_objfiles.
2123         * linux-thread-db.c (try_thread_db_load_from_pdir)
2124         (has_libpthread): Use all_objfiles.
2125         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2126         * linespec.c (iterate_over_all_matching_symtabs)
2127         (search_minsyms_for_name): Use all_objfiles.
2128         * maint.c (maintenance_info_sections): Use all_objfiles.
2129         * main.c (captured_main_1): Use all_objfiles.
2130         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2131         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2132         * guile/scm-pretty-print.c
2133         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2134         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2135         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2136         (maintenance_print_msymbols): Use all_objfiles.
2137         * source.c (select_source_symtab): Use all_objfiles.
2138         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2139         * symfile.c (remove_symbol_file_command)
2140         (expand_symtabs_matching, map_symbol_filenames): Use
2141         all_objfiles.
2142         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2143         all_objfiles.
2144         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2145         * objc-lang.c (find_methods): Use all_objfiles.
2146         * objfiles.c (have_partial_symbols, have_full_symbols)
2147         (have_minimal_symbols, qsort_cmp)
2148         (default_iterate_over_objfiles_in_search_order): Use
2149         all_objfiles.
2150         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2151         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2152         (maintenance_check_psymtabs): Use all_objfiles.
2153         (ALL_PSYMTABS): Remove.
2154         * compile/compile-object-run.c (do_module_cleanup): Use
2155         all_objfiles.
2156         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2157         * cp-support.c (add_symbol_overload_list_qualified): Use
2158         all_objfiles.
2159         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2160         Use all_objfiles.
2161         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2162         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2163         all_objfiles.
2164         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2165         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2166         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2167         Uses all_objfiles.
2168         * solib.c (solib_read_symbols): Use all_objfiles
2169
2170 2019-01-09  Tom Tromey  <tom@tromey.com>
2171
2172         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2173         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2174         all_objfiles.
2175         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2176         * symmisc.c (print_symbol_bcache_statistics)
2177         (print_objfile_statistics, maintenance_print_objfiles)
2178         (maintenance_info_symtabs, maintenance_check_symtabs)
2179         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2180         all_objfiles.
2181         * source.c (forget_cached_source_info): Use all_objfiles.
2182         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2183         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2184         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2185         * objfiles.c (update_section_map): Use all_objfiles.
2186         (shared_objfile_contains_address_p): Likewise.
2187         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2188         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2189
2190 2019-01-09  Tom Tromey  <tom@tromey.com>
2191
2192         * common/next-iterator.h: New file.
2193         * objfiles.h (class all_objfiles): New.
2194         (struct objfile_iterator): New.
2195
2196 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2197
2198         * NEWS: Move the description of the changed "frame", "select-frame",
2199          and "info frame" commands to the Changed commands section.
2200
2201 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2202
2203         * gdbtypes.c (check_stub_method_group): Remove handling of old
2204         mangling schemes.
2205         * linespec.c (find_methods): Likewise.
2206         * stabsread.c (read_member_functions): Likewise.
2207         * valops.c (search_struct_method): Likewise.
2208         (value_struct_elt_for_reference): Likewise.
2209         * NEWS: Mention this change.
2210
2211 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2212
2213         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2214         print_source_lines.
2215         * source.c (print_source_lines_base): Update line number check.
2216         (print_source_lines): New function.
2217         (source_lines_range::source_lines_range): New function.
2218         * source.h (class source_lines_range): New class.
2219         (print_source_lines): New declaration.
2220
2221 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2222
2223         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2224
2225 2019-01-08  Tom Tromey  <tom@tromey.com>
2226             Simon Marchi  <simon.marchi@ericsson.com>
2227
2228         PR gdb/24060
2229         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2230         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2231         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2232         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2233         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2234         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2235
2236 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * source.c (select_source_symtab): Move header comment to
2239         declaration in source.h.
2240         (forget_cached_source_info_for_objfile): Likewise.
2241         (forget_cached_source_info): Likewise.
2242         (identify_source_line): Likewise.
2243         * source.h (identify_source_line): Move declaration from symtab.h
2244         and add comment from source.c
2245         (print_source_lines): Likewise.
2246         (forget_cached_source_info_for_objfile): Likewise.
2247         (forget_cached_source_info): Likewise.
2248         (select_source_symtab): Likewise.
2249         (enum print_source_lines_flag): Move definition from symtab.h.
2250         * symtab.h (identify_source_line): Move declaration to source.h.
2251         (print_source_lines): Likewise.
2252         (forget_cached_source_info_for_objfile): Likewise.
2253         (forget_cached_source_info): Likewise.
2254         (select_source_symtab): Likewise.
2255         (enum print_source_lines_flag): Move definition to source.h.
2256         * tui/tui-hooks.c: Add 'source.h' include.
2257
2258 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2259
2260         * source.c (print_source_lines_base): Handle requests to print
2261         reverse line number sequences, and guard against empty lines
2262         string.
2263
2264 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2265
2266         * source.c (print_source_lines_base): Fix skip of '\r' if next
2267         character is '\n'.
2268
2269 2019-01-06  Tom Tromey  <tom@tromey.com>
2270
2271         * c-exp.y (struct c_parse_state) <macro_original_text,
2272         expansion_obstack>: New member.
2273         (macro_original_text, expansion_obstack): Remove globals.
2274         (scan_macro_expansion, scanning_macro_expansion)
2275         (finished_macro_expansion): Update.
2276         (scan_macro_cleanup): Remove.
2277         (yylex, c_parse): Update.
2278
2279 2019-01-06  Tom Tromey  <tom@tromey.com>
2280
2281         * c-exp.y (struct c_parse_state) <strings>: New member.
2282         (operator_stoken): Update.
2283
2284 2019-01-06  Tom Tromey  <tom@tromey.com>
2285
2286         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2287         (union type_stack_elt) <typelist_val>: Now a pointer to
2288         std::vector.
2289         (type_stack_cleanup): Don't declare.
2290         (push_typelist): Update.
2291         * parse.c (pop_typelist): Return a std::vector.
2292         (push_typelist): Take a std::vector.
2293         (follow_types): Update.  Do not free args.
2294         (type_stack_cleanup): Remove.
2295         * c-exp.y (struct c_parse_state): New.
2296         (cpstate): New global.
2297         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2298         (nonempty_typelist): Update.
2299         (func_mod): Create a new vector.
2300         (c_parse): Create a c_parse_state.
2301         (check_parameter_typelist): Do not delete params.
2302         (function_method): Update.  Do not delete type_list.
2303
2304 2019-01-06  Tom Tromey  <tom@tromey.com>
2305
2306         PR gdb/28155:
2307         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2308         check_typedef.
2309         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2310         (print_return_value): Likewise.
2311
2312 2019-01-05  Tom Tromey  <tom@tromey.com>
2313
2314         * contrib/cleanup_check.py: Remove.
2315         * contrib/gcc-with-excheck: Remove.
2316         * contrib/exsummary.py: Remove.
2317         * contrib/excheck.py: Remove.
2318
2319 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2320
2321         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2322         NULL. Initialize tpprev to NULL instead of assigning it
2323         to NULL on the next statement.
2324         * windows-nat.c (windows_delete_thread): Remove check for
2325         main_thread_id before printing thread exit notifications.
2326         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2327         Remove thread ID check against main_thread_id.
2328         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2329         windows_delete_thread.
2330         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2331
2332 2019-01-04  Tom Tromey  <tom@tromey.com>
2333
2334         * compile/compile.c (_initialize_compile): Use upper case for
2335         metasyntactic variables.
2336         * symmisc.c (_initialize_symmisc): Use upper case for
2337         metasyntactic variables.
2338         * psymtab.c (_initialize_psymtab): Use upper case for
2339         metasyntactic variables.
2340         * demangle.c (demangle_command): Use upper case for metasyntactic
2341         variables.
2342         (_initialize_demangler): Likewise.
2343         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2344         variables.
2345
2346 2019-01-03  Tom Tromey  <tom@tromey.com>
2347
2348         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2349
2350 2019-01-03  Tom Tromey  <tom@tromey.com>
2351
2352         * python/py-symtab.c (salpy_str): Update.
2353         (struct salpy_sal_object) <symtab>: Now a PyObject.
2354         (salpy_dealloc): Update.
2355         (del_objfile_sal): Use gdbpy_ref.
2356
2357 2019-01-03  Tom Tromey  <tom@tromey.com>
2358
2359         * python/py-type.c (convert_field): Use new_reference.  Return
2360         gdbpy_ref.
2361         (make_fielditem): Return gdbpy_ref.
2362         (typy_fields): Update.
2363         (typy_getitem): Update.
2364         (field_name): Return gdbpy_ref.  Use new_reference.
2365         (typy_iterator_iternext): Update.
2366
2367 2019-01-03  Tom Tromey  <tom@tromey.com>
2368
2369         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2370
2371 2019-01-03  Tom Tromey  <tom@tromey.com>
2372
2373         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2374         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2375         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2376         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2377         (pspy_set_type_printers): Likewise.
2378         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2379         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2380         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2381         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2382         (objfpy_set_type_printers): Likewise.
2383
2384 2019-01-03  Tom Tromey  <tom@tromey.com>
2385
2386         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2387         (gdbpy_print_stack): Use gdbpy_err_fetch.
2388         * python/python-internal.h (class gdbpy_err_fetch): New class.
2389         (class gdbpy_enter) <m_error_type, m_error_value,
2390         m_error_traceback>: Remove.
2391         <m_error>: New member.
2392         (gdbpy_exception_to_string): Don't declare.
2393         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2394         * python/py-value.c (convert_value_from_python): Use
2395         gdbpy_err_fetch.
2396         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2397         gdbpy_exception_to_string.
2398         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2399         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2400         gdbpy_err_fetch.
2401
2402 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2403
2404         * linux-nat.c (delete_lwp_cleanup): Delete.
2405         (struct lwp_deleter): New struct.
2406         (lwp_info_up): New typedef.
2407         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2408         lwp_info_up.
2409
2410 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2411
2412         * linux-fork.c (class scoped_switch_fork_info): New class.
2413         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2414
2415 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2416
2417         * valops.c (find_overload_match): Remove use of null_cleanup, and
2418         calls to do_cleanups.
2419
2420 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2421
2422         * compile/compile-cplus-types.c
2423         (compile_cplus_instance::decl_name): Handle changes to
2424         cp_func_name.
2425         * cp-support.c (cp_func_name): Update header comment, update
2426         return type.
2427         * cp-support.h (cp_func_name): Update return type in declaration.
2428         * valops.c (find_overload_match): Move temp_func local to top
2429         level of function and change its type.  Use temp_func to hold and
2430         delete temporary string obtained from cp_func_name.
2431
2432 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2433
2434         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2435         gdb::char_vector, remove cleanup, and update uses of `msg`.
2436
2437 2019-01-03  Jim Wilson  <jimw@sifive.com>
2438
2439         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2440
2441 2019-01-02  Tom Tromey  <tom@tromey.com>
2442
2443         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2444         (tdesc_parse_xml): Remove cleanups.
2445         * target-descriptions.h (make_cleanup_free_target_description):
2446         Don't declare.
2447         (target_desc_deleter): New struct.
2448         (target_desc_up): New typedef.
2449         * target-descriptions.c (target_desc_deleter::operator()): Rename
2450         from free_target_description.
2451         (make_cleanup_free_target_description): Remove.
2452
2453 2019-01-02  Tom Tromey  <tom@tromey.com>
2454
2455         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2456         constructor, destructor.
2457         (linespec_parser): Remove typedef.
2458         (~linespec_parser): Rename from linespec_parser_delete.
2459         (linespec_lex_to_end, linespec_complete_label)
2460         (linespec_complete): Update.
2461         (decode_line_full): Remove cleanups.
2462         (decode_line_1): Update.
2463
2464 2019-01-02  Tom Tromey  <tom@tromey.com>
2465
2466         * python/python-internal.h (inferior_to_inferior_object): Change
2467         return type.
2468         * python/py-exitedevent.c (create_exited_event_object): Update.
2469         * python/py-inferior.c (inferior_to_inferior_object): Return
2470         gdbpy_ref.
2471         (python_new_inferior, python_inferior_deleted)
2472         (thread_to_thread_object, delete_thread_object)
2473         (build_inferior_list, gdbpy_selected_inferior): Update.
2474         * python/py-infthread.c (create_thread_object): Update.  Also fail
2475         if inferior_to_inferior_object fails.
2476
2477 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2478
2479         * inferior.h (class inferior) <displaced_step_state>: New field.
2480         * infrun.h (struct displaced_step_state): Move here from
2481         infrun.c.  Initialize fields, add constructor.
2482         <inf>: Remove field.
2483         <reset>: New method.
2484         * infrun.c (struct displaced_step_inferior_state): Move to
2485         infrun.h.
2486         (displaced_step_inferior_states): Remove.
2487         (get_displaced_stepping_state): Adust.
2488         (displaced_step_in_progress_any_inferior): Adjust.
2489         (displaced_step_in_progress_thread): Adjust.
2490         (displaced_step_in_progress): Adjust.
2491         (add_displaced_stepping_state): Remove.
2492         (get_displaced_step_closure_by_addr): Adjust.
2493         (remove_displaced_stepping_state): Remove.
2494         (infrun_inferior_exit): Call displaced_step_state.reset.
2495         (use_displaced_stepping): Don't check for NULL.
2496         (displaced_step_prepare_throw): Call
2497         get_displaced_stepping_state.
2498         (displaced_step_fixup): Don't check for NULL.
2499         (prepare_for_detach): Don't check for NULL.
2500
2501 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2502
2503         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2504          in case of call that did not complete.
2505
2506 2019-01-02  Andrey Utkin  <autkin@undo.io>
2507
2508         * symfile.c (find_separate_debug_file): Fix search of debug files for
2509         remote debuggee.
2510
2511 2019-01-02  Tom Tromey  <tom@tromey.com>
2512
2513         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2514         indentation.
2515         * python/py-frame.c (frapy_older): Remove cast.
2516         (frapy_newer): Likewise.
2517         * python/py-breakpoint.c (local_setattro): Remove cast.
2518         * python/py-arch.c (archpy_name): Remove local variable.
2519         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2520
2521 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2522
2523         * unittests/basic_string_view/element_access/char/empty.cc:
2524         Fix year range in copyright header.
2525
2526 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2527
2528         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2529         Delete.
2530         <operator==>: Update with for removed field.
2531         <hash>: Likewise.
2532         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2533         <isa_features>: ...this.
2534         <abi_features>: New field.
2535         (riscv_isa_flen): Update comment.
2536         (riscv_abi_xlen): New declaration.
2537         (riscv_abi_flen): New declaration.
2538         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2539         isa_features.
2540         (riscv_abi_xlen): New function.
2541         (riscv_isa_flen): Update to get answer from isa_features.
2542         (riscv_abi_flen): New function.
2543         (riscv_has_fp_abi): Update to get answer from abi_features.
2544         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2545         xlen and flen.
2546         (riscv_call_info) <xlen, flen>: Update comment.
2547         (riscv_call_arg_struct): Remove invalid assertions
2548         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2549         is removed.
2550         (riscv_gdbarch_init): Gather isa features and abi features
2551         separately, ensure both match on the gdbarch when reusing an old
2552         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2553         a target with 64-bit float hardware.
2554
2555 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2556
2557         * source.c (search_command_helper): Stop reverse search
2558         when line 1 has been searched.
2559
2560 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2561
2562         * record-full.c (record_full_base_target::close): Rewrite
2563         record_full_core_buf_list free logic.
2564
2565 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2566
2567         * break-catch-syscall.c (print_one_catch_syscall): xfree
2568         the last text.
2569
2570 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2571
2572         * top.c (print_gdb_version): Update Copyright year in version
2573         message.
2574
2575 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2576
2577         Update copyright year range in all GDB files.
2578
2579 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2580
2581         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2582
2583 For older changes see ChangeLog-2018.
2584 \f
2585 Local Variables:
2586 mode: change-log
2587 left-margin: 8
2588 fill-column: 74
2589 version-control: never
2590 coding: utf-8
2591 End:
2592