[PowerPC] Consolidate wordsize getter between native and gdbserver
[external/binutils.git] / gdb / ChangeLog
1 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
2
3         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
4         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
5         nat/ppc-linux.c.
6         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
7         ppc_linux_target_wordsize with tid.
8         (ppc_linux_nat_target::read_description): Call ppc_linux_target
9         wordsize with tid.
10         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
11         (ppc64_64bit_inferior_p): Add static and inline specifiers.
12         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
13         tid parameter. Remove static specifier.
14         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
15         (ppc_linux_target_wordsize): New declaration.
16
17 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
18
19         * arch/ppc-linux-common.c: New file.
20         * arch/ppc-linux-common.h: New file.
21         * arch/ppc-linux-tdesc.h: New file.
22         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
23         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
24         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
25         arch/ppc-linux-tdesc.h.
26         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
27         arch/ppc-linux-tdesc.h.
28         (ppc_linux_nat_target::read_description): Remove target
29         description matching code. Fill a ppc_linux_features struct and
30         call ppc_linux_match_description with it. Move comment about ISA
31         2.05 to ppc-linux-common.c.
32         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
33         arch/ppc-linux-tdesc.h.
34         (ppc_linux_core_read_description): Remove target description
35         matching code. Fill a ppc_linux_features struct and call
36         ppc_linux_match_description with it.
37         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
38         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
39         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
40         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
41         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
42         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
43         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
44         (tdesc_powerpc_e500l): Remove.
45
46 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
47
48         * ada-lang.c (catch_assert_command): Pass empty string instead
49         of NULL for excep_string argument.
50
51 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
52
53         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
54         the width of the requested register exceeds the width of the
55         `ptrace' data type.
56
57 2018-05-21  Tom Tromey  <tom@tromey.com>
58
59         * printcmd.c (output_command): Remove.
60         (output_command_const): Rename to output_command.
61         * valprint.h (output_command): Rename from output_command_const.
62         * tracepoint.c (trace_dump_actions): Call output_command.
63
64 2018-05-21  Tom Tromey  <tom@tromey.com>
65
66         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
67         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
68         * ada-lang.h (create_ada_exception_catchpoint): Update.
69         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
70         std::string.
71         (create_excep_cond_exprs, ~ada_catchpoint)
72         (should_stop_exception, print_one_exception)
73         (print_mention_exception, print_recreate_exception): Update.
74         (ada_get_next_arg): Remove.
75         (catch_ada_exception_command_split): Use std::string.  Change type
76         of "excep_string", "cond_string".
77         (catch_ada_exception_command): Update.
78         (create_ada_exception_catchpoint): Change type of excep_string.
79         (ada_exception_sal): Remove excep_string parameter.
80         (~ada_catchpoint): Remove.
81
82 2018-05-21  Tom Tromey  <tom@tromey.com>
83
84         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
85         cleanup.
86
87 2018-05-21  Tom Tromey  <tom@tromey.com>
88
89         * ada-lang.c (ada_exception_message_1, ada_exception_message):
90         Return unique_xmalloc_ptr.
91         (print_it_exception): Update.
92
93 2018-05-21  Tom Tromey  <tom@tromey.com>
94
95         * tracepoint.c (trace_dump_actions): Use std::string.
96
97 2018-05-21  Tom Tromey  <tom@tromey.com>
98
99         * symfile.c (reread_symbols): Use std::string for original_name.
100
101 2018-05-21  Tom Tromey  <tom@tromey.com>
102
103         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
104         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
105         constructor.
106
107 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
108
109         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
110         instance to...
111         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
112         * objfiles.c (get_objfile_bfd_data): Allocate
113         objfile_per_bfd_storage with obstack_new when allocating on
114         obstack.
115
116 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
117
118         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
119         OBSTACK_ZALLOC.
120         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
121         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
122         * mdebugread.c (mdebug_build_psymtabs): Likewise.
123         (add_pending): Likewise.
124         (parse_symbol): Likewise.
125         (parse_partial_symbols): Likewise.
126         (psymtab_to_symtab_1): Likewise.
127         (new_psymtab): Likewise.
128         (elfmdebug_build_psymtabs): Likewise.
129         * minsyms.c (terminate_minimal_symbol_table): Likewise.
130         * objfiles.c (get_objfile_bfd_data): Likewise.
131         (objfile_register_static_link): Likewise.
132         * psymtab.c (allocate_psymtab): Likewise.
133         * stabsread.c (read_member_functions): Likewise.
134         * xcoffread.c (xcoff_end_psymtab): Likewise.
135
136 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
137
138         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
139         compiler supports std::is_trivially_constructible.
140         * common/poison.h: Include obstack.h.
141         (IsMallocable): Define to is_trivially_constructible if the
142         compiler supports it, define to true_type otherwise.
143         (xobnew): New.
144         (XOBNEW): Redefine.
145         (xobnewvec): New.
146         (XOBNEWVEC): Redefine.
147         * gdb_obstack.h (obstack_zalloc): New.
148         (OBSTACK_ZALLOC): Redefine.
149         (obstack_calloc): New.
150         (OBSTACK_CALLOC): Redefine.
151         (obstack_new): New.
152         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
153         (gdbarch_obstack): New declaration in gdbarch.h, definition in
154         gdbarch.c.
155         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
156         obstack_calloc/obstack_zalloc.
157         (gdbarch_obstack_zalloc): Remove.
158         * target-descriptions.c (tdesc_data_init): Use obstack_new.
159
160 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
161
162         * stack.c (backtrace_command_1): Remove useless variable int i.
163
164 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
165
166         * stack.c (print_frame_info): Fix comment.
167
168 2018-05-18  Tom Tromey  <tom@tromey.com>
169
170         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
171         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
172         (~dwarf2_per_objfile): Update
173         (dwarf2_get_dwz_file): Use new.
174         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
175         unique_ptr.
176
177 2018-05-18  Tom Tromey  <tom@tromey.com>
178
179         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
180         unique_ptr.
181         * dwarf2read.c (struct dwp_file): Add constructor and
182         initializers.
183         (open_and_init_dwp_file): Return a unique_ptr.
184         (dwarf2_per_objfile, create_dwp_hash_table)
185         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
186         (lookup_dwo_unit_in_dwp): Update.
187         (open_and_init_dwp_file, get_dwp_file): Update.
188
189 2018-05-18  Tom Tromey  <tom@tromey.com>
190
191         * dwarf2read.c (dwarf2_per_objfile): Update.
192         (struct mapped_index): Add initializers.
193         (dwarf2_read_index): Use new.
194         (dw2_symtab_iter_init): Update.
195         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
196         unique_ptr.
197
198 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
199
200         * dwarf2read.c (mapped_index) <total_size>: Remove.
201
202 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
203
204         * unittests/format_pieces-selftests.c (test_format_specifier):
205         Add ARI comments.
206
207 2018-05-18  Tom Tromey  <tom@tromey.com>
208
209         * c-typeprint.c (maybe_print_hole): New function.
210         (c_print_type_struct_field_offset): Update.
211         (c_type_print_base_struct_union): Call maybe_print_hole.
212
213 2018-05-17  Keith Seitz  <keiths@redhat.com>
214
215         * breakpoint.c (build_bpstat_chain): New function, moved from
216         bpstat_stop_status.
217         (bpstat_stop_status): Add optional parameter, `stop_chain'.
218         If no stop chain is passed, call build_bpstat_chain to build it.
219         * breakpoint.h (build_bpstat_chain): Declare.
220         (bpstat_stop_status): Move documentation here from breakpoint.c.
221         * infrun.c (handle_signal_stop): Before eliding inlined frames,
222         build the stop chain and pass it to skip_inline_frames.
223         Pass this stop chain to bpstat_stop_status.
224         * inline-frame.c: Include breakpoint.h.
225         (stopped_by_user_bp_inline_frame): New function.
226         (skip_inline_frames): Add parameter `stop_chain'.
227         Move documention to inline-frame.h.
228         If non-NULL, use stopped_by_user_bp_inline_frame to determine
229         whether the frame should be elided.
230         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
231         Add moved documentation and update for new parameter.
232
233 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
234
235         PR cli/14975
236         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
237         unittests/format_pieces-selftests.c.
238         * common/format.h (format_piece) <operator==>: New.
239         (format_pieces) <operator[]>: Remove.
240         * common/format.c (format_pieces::format_pieces): Handle \e.
241         * unittests/format_pieces-selftests.c: New.
242
243 2018-05-17  Tom Tromey  <tom@tromey.com>
244
245         PR symtab/23010:
246         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
247         (dw2_instantiate_symtab): Add skip_partial parameter.
248         (dw2_find_last_source_symtab, dw2_map_expand_apply)
249         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
250         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
251         (dw2_expand_symtabs_matching_one)
252         (dw2_find_pc_sect_compunit_symtab)
253         (dw2_debug_names_lookup_symbol)
254         (dw2_debug_names_expand_symtabs_for_function): Update.
255         (init_cutu_and_read_dies): Add skip_partial parameter.
256         (process_psymtab_comp_unit, build_type_psymtabs_1)
257         (process_skeletonless_type_unit, load_partial_comp_unit)
258         (psymtab_to_symtab_1): Update.
259         (load_full_comp_unit): Add skip_partial parameter.
260         (process_imported_unit_die, dwarf2_read_addr_index)
261         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
262         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
263         (read_signatured_type): Update.
264
265 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
266
267         * value.c (release_value): Remove unused variable.
268         (record_latest_value): Likewise.
269         (access_value_history): Likewise.
270         (preserve_values): Likewise.
271
272 2018-05-17  Tom Tromey  <tom@tromey.com>
273
274         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
275         Initialize.
276
277 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
278
279         PR gdb/22286
280         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
281         Also handle registers whose width is not a multiple of
282         PTRACE_TYPE_RET.
283         (linux_nat_trad_target::store_register): Likewise.
284
285 2018-05-16  Tom Tromey  <tom@tromey.com>
286
287         * gdbcore.h (core_bfd): Redefine.
288         * corelow.c (core_target::close): Update.
289         (core_target_open): Update.
290         * progspace.h (struct program_space) <cbfd>: Now a
291         gdb_bfd_ref_ptr.
292
293 2018-05-16  Tom Tromey  <tom@tromey.com>
294
295         PR cli/19551:
296         * symfile-add-flags.h (enum symfile_add_flags)
297         <SYMFILE_NOT_FILENAME>: New constant.
298         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
299         objfile name from BFD.
300         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
301         * minidebug.c (find_separate_debug_file_in_section): Put
302         ".gnu_debugdata" into BFD's file name.
303
304 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
305
306         * regcache.c (regcache_read_ftype, regcache_write_ftype):
307         Remove.
308
309 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
310
311         PR binutils/21446
312         * aarch64-tdep.c (aarch64_analyze_prologue,
313         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
314         Indicate not interested in errors.
315
316 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
317
318         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
319         Supply the MIPS_ZERO_REGNUM register.
320
321 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
322
323         * mips-tdep.c (mask_address_var): Make variable static.
324
325 2018-05-14  Tom Tromey  <tom@tromey.com>
326
327         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
328
329 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
330
331         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
332         FXSAVE_ADDR for the mxcsr register.
333
334 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
335
336         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
337
338 2018-05-11  Pedro Alves  <palves@redhat.com>
339
340         * corelow.c (core_target) <core_target>: No longer inline.
341         Initialize m_core_gdbarch, m_core_vec and build the section table
342         here.
343         <~core_target>: New.
344         <core_gdbarch, get_core_register_section>: New methods.
345         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
346         factored out from ...
347         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
348         (core_ops): Delete.
349         (sniff_core_bfd): Add gdbarch parameter.
350         (core_close): Delete, merged into ...
351         (core_target::close): ... here.  Delete self.
352         (core_close_cleanup): Delete.
353         (core_target_open): Allocate a core_target on the heap.  Use a
354         unique_ptr instead of a cleanup.  Bits moved into the core_target
355         ctor.  Adjust to use core_target methods instead of globals.
356         (get_core_register_section): Rename to ...
357         (core_target::get_core_register_section): ... this and adjust.
358         (struct get_core_registers_cb_data): New.
359         (get_core_registers_cb): Use it.  Use bool.
360         (core_target::fetch_registers, core_target::files_info)
361         (core_target::xfer_partial, core_target::read_description)
362         (core_target::pid_to, core_target::thread_name): Adjust to
363         reference class fields instead of globals.
364         * target.h (struct target_ops_deleter, target_ops_up): New.
365
366 2018-05-11  Pedro Alves  <palves@redhat.com>
367
368         * corefile.c (core_file_command): Move to corelow.c.
369         * corelow.c (the_core_target): Delete.
370         (core_file_command): Moved from corefile.c.  Check exec_bfd
371         instead of the_core_target.  Use target_detach instead of calling
372         into the_core_target directly.
373         (maybe_say_no_core_file_now): New.
374         (core_target::detach): Use it.
375         (_initialize_corelow): Remove references to the_core_target.
376         * gdbcore.h (the_core_target): Delete.
377
378 2018-05-11  Tom Tromey  <tromey@redhat.com>
379             Pedro Alves  <palves@redhat.com>
380
381         * corefile.c (core_bfd): Remove.
382         * gdbcore.h (core_bfd): Now a macro.
383         * progspace.h (struct program_space) <cbfd>: New field.
384
385 2018-05-11  Tom Tromey  <tom@tromey.com>
386
387         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
388         gdb::def_vector.
389
390 2018-05-10  Tom Tromey  <tom@tromey.com>
391
392         * configure: Rebuild.
393         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
394
395 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
396
397         PR server/23158:
398         * regformats/regdat.sh: Adjust script, following the addition
399         of the new expedite_regs parameter to init_target_desc.
400
401 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
402     
403         PR gdb/23127
404         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
405         set_gdbarch_significant_addr_bit.
406         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
407         set_gdbarch_significant_addr_bit.
408         * utils.c (address_significant): Update to sign extend addr.
409
410 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
411
412         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
413         (xtensa_linux_init_abi): Limit tdep->num_regs by
414         tdep->num_nopriv_regs.
415         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
416         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
417         not initialized.
418
419 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
420
421         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
422
423 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
424
425         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
426         (I387_MXCSR_INIT_VAL): New constant.
427         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
428         buffer if it was supplied by the inferior.
429         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
430         (i387_xsave_get_clear_bv): New function.
431         (i387_supply_xsave): Only read x87 control registers from the
432         xsave buffer if the feature is enabled, and the state will have
433         been written, otherwise, provide a suitable default.
434         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
435         including x87 control registers.  Update control registers if they
436         have changed from the default value, and mark features as enabled
437         as required.
438         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
439
440 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
441
442         * spu-tdep.c (info_spu_event_command): Fix output formatting.
443
444 2018-05-07  Tom Tromey  <tom@tromey.com>
445
446         * configure: Rebuild.
447         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
448
449 2018-05-07  Tom Tromey  <tom@tromey.com>
450
451         PR tdep/20362:
452         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
453         bit.  Use correct value for VDIV.
454
455 2018-05-04  Tom Tromey  <tom@tromey.com>
456
457         * configure: Rebuild.
458         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
459
460 2018-05-04  Tom Tromey  <tom@tromey.com>
461
462         * linux-record.c (record_linux_system_call) <case
463         RECORD_SYS_RECVFROM>: Add "break".
464
465 2018-05-04  Tom Tromey  <tom@tromey.com>
466
467         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
468         Add missing "break".
469         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
470         Add missing "break".
471
472 2018-05-04  Tom Tromey  <tom@tromey.com>
473
474         * rs6000-tdep.c (ppc_process_record_op4)
475         (ppc_process_record_op63): Add fall-through comment.
476
477 2018-05-04  Tom Tromey  <tom@tromey.com>
478
479         * i386-tdep.c (i386_process_record): Add fall-through comment.
480
481 2018-05-04  Tom Tromey  <tom@tromey.com>
482
483         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
484         comment.
485
486 2018-05-04  Tom Tromey  <tom@tromey.com>
487
488         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
489         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
490         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
491         comment.
492         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
493         comment.
494         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
495         comment.
496
497 2018-05-04  Tom Tromey  <tom@tromey.com>
498
499         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
500
501 2018-05-04  Tom Tromey  <tom@tromey.com>
502
503         * s390-tdep.c (s390_process_record): Fix fall-through comments.
504         * xcoffread.c (scan_xcoff_symtab): Move comment later.
505         * symfile.c (section_is_mapped): Fix fall-through comment.
506         * stabsread.c (define_symbol, read_member_functions): Fix
507         fall-through comment.
508         * s390-linux-tdep.c (s390_process_record): Fix fall-through
509         comment.
510         * remote.c (remote_wait_as): Fix fall-through comment.
511         * p-exp.y (yylex): Fix fall-through comment.
512         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
513         comment.
514         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
515         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
516         * jv-exp.y (yylex): Fix fall-through comment.
517         * go-exp.y (lex_one_token): Fix fall-through comment.
518         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
519         fall-through comment.
520         * f-exp.y (yylex): Fix fall-through comment.
521         * dwarf2read.c (process_die): Fix fall-through comments.
522         * dbxread.c (process_one_symbol): Fix fall-through comment.
523         * d-exp.y (lex_one_token): Fix fall-through comment.
524         * cp-name-parser.y (yylex): Fix fall-through comment.
525         * coffread.c (coff_symtab_read): Fix fall-through comment.
526         * c-exp.y (lex_one_token): Fix fall-through comment.
527         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
528         comment.
529         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
530         comment.
531
532 2018-05-04  Tom Tromey  <tom@tromey.com>
533
534         PR python/22730:
535         * NEWS: Mention gdb.execute change.
536         * gdbcmd.h (execute_control_command): Don't declare.
537         * python/python.c (execute_gdb_command): Use read_command_lines_1,
538         execute_control_commands, execute_control_commands_to_string.
539         * cli/cli-script.h (execute_control_commands)
540         (execute_control_commands_to_string): Declare.
541         (execute_control_command): Add from_tty parameter.
542         * cli/cli-script.c (execute_control_commands)
543         (execute_control_commands_to_string): New functions.
544         (execute_user_command): Use execute_control_commands.
545         (execute_control_command_1): Add "from_tty" parameter.  Update.
546         (execute_control_command): Likewise.
547
548 2018-05-04  Tom Tromey  <tom@tromey.com>
549
550         PR python/22731:
551         * NEWS: Mention that breakpoint commands are writable.
552         * python/py-breakpoint.c (bppy_set_commands): New function.
553         (breakpoint_object_getset) <"commands">: Use it.
554
555 2018-05-04  Tom Tromey  <tom@tromey.com>
556
557         * tracepoint.c (actions_command): Update.
558         * mi/mi-cmd-break.c (mi_command_line_array)
559         (mi_command_line_array_cnt, mi_command_line_array_ptr)
560         (mi_read_next_line): Remove.
561         (mi_cmd_break_commands): Update.
562         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
563         function_view.
564         * cli/cli-script.c (get_command_line): Update.
565         (process_next_line): Use function_view.  Constify.
566         (recurse_read_control_structure, read_command_lines)
567         (read_command_lines_1): Change argument types to function_view.
568         (do_define_command, document_command): Update.
569         * breakpoint.h (check_tracepoint_command): Don't declare.
570         * breakpoint.c (check_tracepoint_command): Remove.
571         (commands_command_1, create_tracepoint_from_upload): Update.
572
573 2018-05-04  Tom Tromey  <tom@tromey.com>
574
575         PR gdb/11750:
576         * cli/cli-script.h (enum command_control_type) <define_control>:
577         New constant.
578         * cli/cli-script.c (multi_line_command_p): Handle define_control.
579         (build_command_line, execute_control_command_1)
580         (process_next_line): Likewise.
581         (do_define_command): New function, extracted from define_command.
582         (define_command): Use it.
583
584 2018-05-04  Tom Tromey  <tom@tromey.com>
585
586         * tracepoint.c (actions_command): Update.
587         * cli/cli-script.h (read_command_lines): Update.
588         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
589         (MAX_TMPBUF): Remove define.
590         (define_command): Use string_printf.
591         (document_command): Likewise.
592         * breakpoint.c (commands_command_1): Update.
593
594 2018-05-04  Tom Tromey  <tom@tromey.com>
595
596         * top.c (execute_command): Update.
597         * cli/cli-script.h (print_command_lines): Now varargs.
598         * cli/cli-script.c (print_command_lines): Now varargs.
599         (execute_control_command_1) <case while_control, case if_control>:
600         Update.
601
602 2018-05-04  Tom Tromey  <tom@tromey.com>
603
604         * tracepoint.c (all_tracepoint_actions): Rename from
605         all_tracepoint_actions_and_cleanup.  Change return type.
606         (actions_command, encode_actions_1, encode_actions)
607         (trace_dump_actions, tdump_command): Update.
608         * remote.c (remote_download_command_source): Update.
609         * python/python.c (gdbpy_eval_from_control_command)
610         (python_command, python_interactive_command): Update.
611         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
612         * guile/guile.c (guile_command)
613         (gdbscm_eval_from_control_command, guile_command): Update.
614         * compile/compile.c (compile_code_command)
615         (compile_print_command, compile_to_object): Update.
616         * cli/cli-script.h (struct command_lines_deleter): New.
617         (counted_command_line): New typedef.
618         (struct command_line): Add constructor, destructor.
619         <body_list>: Remove.
620         <body_list_0, body_list_1>: New members.
621         (command_line_up): Remove typedef.
622         (read_command_lines, read_command_lines_1, get_command_line):
623         Update.
624         (copy_command_lines): Don't declare.
625         * cli/cli-script.c (build_command_line): Use "new".
626         (get_command_line): Return counted_command_line.
627         (print_command_lines, execute_user_command)
628         (execute_control_command_1, while_command, if_command): Update.
629         (realloc_body_list): Remove.
630         (process_next_line, recurse_read_control_structure): Update.
631         (read_command_lines, read_command_lines_1): Return counted_command_line.
632         (free_command_lines): Use "delete".
633         (copy_command_lines): Remove.
634         (define_command, document_command, show_user_1): Update.
635         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
636         a counted_command_line.
637         * breakpoint.h (counted_command_line): Remove typedef.
638         (breakpoint_set_commands): Update.
639         * breakpoint.c (check_no_tracepoint_commands)
640         (validate_commands_for_breakpoint): Update.
641         (breakpoint_set_commands): Change commands to be a
642         counted_command_line.
643         (commands_command_1, update_dprintf_command_list)
644         (create_tracepoint_from_upload): Update.
645
646 2018-05-04  Tom Tromey  <tom@tromey.com>
647
648         * cli/cli-decode.h (cmd_list_element): New constructor.
649         (~cmd_list_element): New destructor.
650         (struct cmd_list_element): Add initializers.
651         * cli/cli-decode.c (do_add_cmd): Use "new".
652         (delete_cmd): Use "delete".
653
654 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
655             Pedro Alves <palves@redhat.com>
656
657         PR breakpoints/19806 and support for PR external/20207.
658         * NEWS: Mention Aarch64 watchpoint improvements.
659         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
660         watchpoints and PR external/20207 watchpoints.
661         * nat/aarch64-linux-hw-point.c
662         (kernel_supports_any_contiguous_range): New.
663         (aarch64_watchpoint_offset): New.
664         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
665         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
666         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
667         (aarch64_align_watchpoint): New parameters aligned_offset_p and
668         next_addr_orig_p.  Support PR external/20207 watchpoints.
669         (aarch64_downgrade_regs): New.
670         (aarch64_dr_state_insert_one_point): New parameters offset and
671         addr_orig.
672         (aarch64_dr_state_remove_one_point): Likewise.
673         (aarch64_handle_breakpoint): Update caller.
674         (aarch64_handle_aligned_watchpoint): Likewise.
675         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
676         aligned_offset.
677         (aarch64_linux_set_debug_regs): Remove const from state.  Call
678         aarch64_downgrade_regs.
679         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
680         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
681         (DR_CONTROL_MASK): ... this.
682         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
683         (unsigned int aarch64_watchpoint_offset): New prototype.
684         (aarch64_linux_set_debug_regs): Remove const from state.
685         * utils.c (align_up, align_down): Move to ...
686         * common/common-utils.c (align_up, align_down): ... here.
687         * utils.h (align_up, align_down): Move to ...
688         * common/common-utils.h (align_up, align_down): ... here.
689
690 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
691
692         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
693         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
694         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
695         Re-implement to match the ABI as summarized in GCC's
696         gcc/config/sparc/sparc.c.  All callers updated.
697         (sparc32_store_arguments): Remove assertion.
698
699 2018-05-04  Tom Tromey  <tom@tromey.com>
700
701         * printcmd.c: Don't include tui.h.
702         (decode_format): Use skip_spaces.
703
704 2018-05-04  Tom Tromey  <tom@tromey.com>
705
706         PR gdb/22619:
707         * printcmd.c (last_count): New global.
708         (x_command): Use saved count when repeating.
709
710 2018-05-04  Tom Tromey  <tom@tromey.com>
711
712         * nto-procfs.c (do_closedir_cleanup): Remove.
713         (procfs_pidlist): Use gdb_dir_up.
714         * procfs.c (do_closedir_cleanup): Remove.
715         (proc_update_threads): Use gdb_dir_up.
716         * common/filestuff.h (struct gdb_dir_deleter): New.
717         (gdb_dir_up): New typedef.
718
719 2018-05-04  Tom Tromey  <tom@tromey.com>
720
721         * ada-lang.c (print_mention_exception): Use std::string.
722
723 2018-05-04  Tom Tromey  <tom@tromey.com>
724
725         * ada-lang.c (create_excep_cond_exprs): Update.
726         (ada_exception_catchpoint_cond_string): Use std::string.
727
728 2018-05-04  Tom Tromey  <tom@tromey.com>
729
730         * ada-lang.c (xget_renaming_scope): Return std::string.
731         (old_renaming_is_invisible): Update.
732
733 2018-05-04  Tom Tromey  <tom@tromey.com>
734
735         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
736         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
737
738 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
739
740         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
741
742 2018-05-04  Tom Tromey  <tom@tromey.com>
743
744         * remote.c (remote_query_supported_append): Change type.
745         (remote_check_symbols): Update.
746
747 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
748
749         PR gdb/11420
750         * configure.ac: Prepend libpython.
751         * python/python-config.py: Likewise.
752         * configure: Regenerate.
753
754 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
755
756         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
757
758 2018-05-03  Pedro Alves  <palves@redhat.com>
759
760         * s390-linux-nat.c
761         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
762         override.  Write 'true' instead of '1'.
763         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
764         declaration.
765
766 2018-05-02  Pedro Alves  <palves@redhat.com>
767
768         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
769         add_inf_child_target.
770         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
771         add_inf_child_target.
772         * aix-thread.c (aix_thread_target_info): New.
773         (aix_thread_target) <shortname, longname, doc>: Delete.
774         <info>: New.
775         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
776         add_inf_child_target.
777         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
778         add_inf_child_target.
779         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
780         add_inf_child_target.
781         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
782         add_inf_child_target.
783         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
784         add_inf_child_target.
785         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
786         add_inf_child_target.
787         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
788         add_inf_child_target.
789         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
790         add_inf_child_target.
791         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
792         add_inf_child_target.
793         * bfd-target.c (target_bfd_target_info): New.
794         (target_bfd) <shortname, longname, doc>: Delete.
795         <info>: New.
796         * bsd-kvm.c (bsd_kvm_target_info): New.
797         (bsd_kvm_target) <shortname, longname, doc>: Delete.
798         <info>: New.
799         (bsd_kvm_target::open): Rename to ...
800         (bsd_kvm_target_open): ... this.  Adjust.
801         * bsd-uthread.c (bsd_uthread_target_info): New.
802         (bsd_uthread_target) <shortname, longname, doc>: Delete.
803         <info>: New.
804         * corefile.c (core_file_command): Adjust.
805         * corelow.c (core_target_info): New.
806         (core_target) <shortname, longname, doc>: Delete.
807         <info>: New.
808         (core_target::open): Rename to ...
809         (core_target_open): ... this.  Adjust.
810         * ctf.c (ctf_target_info): New.
811         (ctf_target) <shortname, longname, doc>: Delete.
812         <info>: New.
813         (ctf_target::open): Rename to ...
814         (ctf_target_open): ... this.
815         (_initialize_ctf): Adjust.
816         * exec.c (exec_target_info): New.
817         (exec_target) <shortname, longname, doc>: Delete.
818         <info>: New.
819         (exec_target::open): Rename to ...
820         (exec_target_open): ... this.
821         * gdbcore.h (core_target_open): Declare.
822         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
823         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
824         add_inf_child_target.
825         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
826         add_inf_child_target.
827         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
828         add_inf_child_target.
829         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
830         add_inf_child_target.
831         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
832         add_inf_child_target.
833         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
834         add_inf_child_target.
835         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
836         add_inf_child_target.
837         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
838         add_inf_child_target.
839         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
840         add_inf_child_target.
841         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
842         add_inf_child_target.
843         * inf-child.c (inf_child_target_info): New.
844         (inf_child_target::info): New.
845         (inf_child_open_target): Remove 'target' parameter.  Use
846         get_native_target instead.
847         (inf_child_target::open): Delete.
848         (add_inf_child_target): New.
849         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
850         Delete.
851         <info>: New.
852         (add_inf_child_target): Declare.
853         (inf_child_open_target): Declare.
854         * linux-thread-db.c (thread_db_target_info): New.
855         (thread_db_target) <shortname, longname, doc>: Delete.
856         <info>: New.
857         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
858         add_inf_child_target.
859         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
860         add_inf_child_target.
861         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
862         add_inf_child_target.
863         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
864         add_inf_child_target.
865         * make-target-delegates (print_class): Adjust.
866         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
867         add_inf_child_target.
868         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
869         add_inf_child_target.
870         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
871         add_inf_child_target.
872         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
873         add_inf_child_target.
874         * nto-procfs.c (nto_native_target_info): New.
875         (nto_procfs_target_native) <shortname, longname, doc>:
876         Delete.
877         <info>: New.
878         (nto_procfs_target_info): New.
879         (nto_procfs_target_procfs) <shortname, longname, doc>:
880         Delete.
881         <info>: New.
882         (init_procfs_targets): Adjust.
883         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
884         add_inf_child_target.
885         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
886         add_inf_child_target.
887         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
888         add_inf_child_target.
889         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
890         add_inf_child_target.
891         * ravenscar-thread.c (ravenscar_target_info): New.
892         (ravenscar_thread_target) <shortname, longname, doc>:
893         Delete.
894         <info>: New.
895         * record-btrace.c (record_btrace_target_info):
896         (record_btrace_target) <shortname, longname, doc>: Delete.
897         <info>: New.
898         (record_btrace_target::open): Rename to ...
899         (record_btrace_target_open): ... this.  Adjust.
900         * record-full.c (record_longname, record_doc): New.
901         (record_full_base_target) <shortname, longname, doc>: Delete.
902         <info>: New.
903         (record_full_target_info): New.
904         (record_full_target): <shortname>: Delete.
905         <info>: New.
906         (record_full_core_open_1, record_full_open_1): Update comments.
907         (record_full_base_target::open): Rename to ...
908         (record_full_open): ... this.
909         (cmd_record_full_restore): Update.
910         (_initialize_record_full): Update.
911         * remote-sim.c (remote_sim_target_info): New.
912         (gdbsim_target) <shortname, longname, doc>: Delete.
913         <info>: New.
914         (gdbsim_target::open): Rename to ...
915         (gdbsim_target_open): ... this.
916         (_initialize_remote_sim): Adjust.
917         * remote.c (remote_doc): New.
918         (remote_target_info): New.
919         (remote_target) <shortname, longname, doc>: Delete.
920         <info>: New.
921         (extended_remote_target_info): New.
922         (extended_remote_target) <shortname, longname, doc>: Delete.
923         <info>: New.
924         (remote_target::open_1): Make static.  Adjust.
925         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
926         * s390-linux-nat.c (_initialize_s390_nat): Use
927         add_inf_child_target.
928         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
929         add_inf_child_target.
930         * sol-thread.c (thread_db_target_info): New.
931         (sol_thread_target) <shortname, longname, doc>: Delete.
932         <info>: New.
933         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
934         add_inf_child_target.
935         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
936         add_inf_child_target.
937         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
938         add_inf_child_target.
939         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
940         add_inf_child_target.
941         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
942         add_inf_child_target.
943         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
944         add_inf_child_target.
945         * spu-linux-nat.c (_initialize_spu_nat): Use
946         add_inf_child_target.
947         * spu-multiarch.c (spu_multiarch_target_info): New.
948         (spu_multiarch_target) <shortname, longname, doc>: Delete.
949         <info>: New.
950         * target-delegates.c: Regenerate.
951         * target.c: Include <unordered_map>.
952         (target_ops_p): Delete.
953         (DEF_VEC_P(target_ops_p)): Delete.
954         (target_factories): New.
955         (test_target_info): New.
956         (test_target_ops::info): New.
957         (open_target): Adjust to use target_factories.
958         (add_target_with_completer): Rename to ...
959         (add_target): ... this.  Change prototype.  Register target_info
960         and open callback in target_factories.  Register target_info in
961         command context instead of target_ops.
962         (add_target): Delete old implementation.
963         (add_deprecated_target_alias): Change prototype.  Adjust.
964         (the_native_target): New.
965         (set_native_target, get_native_target): New.
966         (find_default_run_target): Use the_native_target.
967         (find_attach_target, find_run_target): Simplify.
968         (target_ops::open): Delete.
969         (dummy_target_info): New.
970         (dummy_target::shortname, dummy_target::longname)
971         (dummy_target::doc): Delete.
972         (dummy_target::info): New.
973         (debug_target::shortname, debug_target::longname)
974         (debug_target::doc): Delete.
975         (debug_target::info): New.
976         * target.h (struct target_info): New.
977         (target_ops::~target_ops): Add comment.
978         (target_ops::info): New.
979         (target_ops::shortname, target_ops::longname, target_ops::doc): No
980         longer virtual.  Implement in terms of target_info.
981         (set_native_target, get_native_target): Declare.
982         (target_open_ftype): New.
983         (add_target, add_target_with_completer)
984         (add_deprecated_target_alias): Change prototype.
985         (test_target) <shortname, longname, doc>: Delete.
986         <info>: New.
987         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
988         add_inf_child_target.
989         * tracefile-tfile.c (tfile_target_info): New.
990         (tfile_target) <shortname, longname, doc>: Delete.
991         <info>: New.
992         (tfile_target::open): Rename to ...
993         (tfile_target_open): ... this.
994         (_initialize_tracefile_tfile): Adjust.
995         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
996         add_inf_child_target.
997         * windows-nat.c (_initialize_windows_nat): Use
998         add_inf_child_target.
999         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
1000         add_inf_child_target.
1001
1002 2018-05-02  Pedro Alves  <palves@redhat.com>
1003
1004         * linux-nat.h (linux_nat_target) <low_new_thread,
1005         low_delete_thread, low_new_fork, low_forget_process,
1006         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
1007         New virtual methods.
1008         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1009         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
1010         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
1011         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1012         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
1013         Delete.
1014         * linux-fork.c (delete_fork): Adjust to call low method.
1015         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
1016         (linux_nat_new_fork, linux_nat_forget_process_hook)
1017         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
1018         (linux_nat_status_is_event):
1019         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
1020         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
1021         to call low method.
1022         (sigtrap_is_event): Rename to ...
1023         (linux_nat_target::low_status_is_event): ... this.
1024         (linux_nat_set_status_is_event): Delete.
1025         (save_stop_reason, linux_nat_wait_1)
1026         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
1027         low methods.
1028         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1029         (linux_nat_set_new_fork, linux_nat_set_forget_process)
1030         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1031         (linux_nat_set_prepare_to_resume): Delete.
1032         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
1033         low virtual methods.
1034         * amd64-linux-nat.c: Likewise.
1035         * arm-linux-nat.c: Likewise.
1036         * i386-linux-nat.c: Likewise.
1037         * ia64-linux-nat.c: Likewise.
1038         * mips-linux-nat.c: Likewise.
1039         * ppc-linux-nat.c: Likewise.
1040         * s390-linux-nat.c: Likewise.
1041         * sparc64-linux-nat.c: Likewise.
1042         * x86-linux-nat.c: Likewise.
1043         * x86-linux-nat.h: Include "nat/x86-linux.h".
1044         (x86_linux_nat_target) <low_new_fork, low_forget_process,
1045         low_prepare_to_resume, low_new_thread, low_delete_thread>:
1046         Override methods.
1047
1048 2018-05-02  Pedro Alves  <palves@redhat.com>
1049
1050         * target.h (target_ops)
1051         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
1052         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
1053         stopped_by_watchpoint, have_continuable_watchpoint,
1054         stopped_data_address, watchpoint_addr_within_range,
1055         can_accel_watchpoint_condition, can_run, thread_alive,
1056         has_all_memory, has_memory, has_stack, has_registers,
1057         has_execution, can_async_p, is_async_p, supports_non_stop,
1058         always_non_stop_p, can_execute_reverse, supports_multi_process,
1059         supports_enable_disable_tracepoint,
1060         supports_disable_randomization, supports_string_tracing,
1061         supports_evaluation_of_breakpoint_conditions,
1062         can_run_breakpoint_commands, filesystem_is_local,
1063         can_download_tracepoint, get_trace_state_variable_value,
1064         set_trace_notes, get_tib_address, use_agent, can_use_agent,
1065         record_is_replaying, record_will_replay,
1066         augmented_libraries_svr4_read>: Adjust to return bool.
1067         * aarch64-linux-nat.c: All implementations adjusted.
1068         * aix-thread.c: All implementations adjusted.
1069         * arm-linux-nat.c: All implementations adjusted.
1070         * breakpoint.c: All implementations adjusted.
1071         * bsd-kvm.c: All implementations adjusted.
1072         * bsd-uthread.c: All implementations adjusted.
1073         * corelow.c: All implementations adjusted.
1074         * ctf.c: All implementations adjusted.
1075         * darwin-nat.c: All implementations adjusted.
1076         * darwin-nat.h: All implementations adjusted.
1077         * exec.c: All implementations adjusted.
1078         * fbsd-nat.c: All implementations adjusted.
1079         * fbsd-nat.h: All implementations adjusted.
1080         * gnu-nat.c: All implementations adjusted.
1081         * gnu-nat.h: All implementations adjusted.
1082         * go32-nat.c: All implementations adjusted.
1083         * ia64-linux-nat.c: All implementations adjusted.
1084         * inf-child.c: All implementations adjusted.
1085         * inf-child.h: All implementations adjusted.
1086         * inf-ptrace.c: All implementations adjusted.
1087         * inf-ptrace.h: All implementations adjusted.
1088         * linux-nat.c: All implementations adjusted.
1089         * linux-nat.h: All implementations adjusted.
1090         * mips-linux-nat.c: All implementations adjusted.
1091         * nto-procfs.c: All implementations adjusted.
1092         * ppc-linux-nat.c: All implementations adjusted.
1093         * procfs.c: All implementations adjusted.
1094         * ravenscar-thread.c: All implementations adjusted.
1095         * record-btrace.c: All implementations adjusted.
1096         * record-full.c: All implementations adjusted.
1097         * remote-sim.c: All implementations adjusted.
1098         * remote.c: All implementations adjusted.
1099         * s390-linux-nat.c: All implementations adjusted.
1100         * sol-thread.c: All implementations adjusted.
1101         * spu-multiarch.c: All implementations adjusted.
1102         * target-delegates.c: All implementations adjusted.
1103         * target.c: All implementations adjusted.
1104         * target.h: All implementations adjusted.
1105         * tracefile-tfile.c: All implementations adjusted.
1106         * tracefile.c: All implementations adjusted.
1107         * tracefile.h: All implementations adjusted.
1108         * windows-nat.c: All implementations adjusted.
1109         * x86-linux-nat.h: All implementations adjusted.
1110         * x86-nat.h: All implementations adjusted.
1111
1112 2018-05-02  Pedro Alves  <palves@redhat.com>
1113
1114         * make-target-delegates (scan_target_h): Don't trim lines here.
1115         Replace sequences of tabs and/or whitespace with a single
1116         whitespace.
1117         (top level, parsing methods): Trim each line before processing it
1118         here.
1119
1120 2018-05-02  Pedro Alves  <palves@redhat.com>
1121             John Baldwin  <jhb@freebsd.org>
1122
1123         * target.h (enum strata) <debug_stratum>: New.
1124         (struct target_ops) <all delegation methods>: Replace by C++
1125         virtual methods, and drop "to_" prefix.  All references updated
1126         throughout.
1127         <to_shortname, to_longname, to_doc, to_data,
1128         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
1129         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
1130         virtual methods.  All references updated throughout.
1131         <can_attach, supports_terminal_ours, can_create_inferior,
1132         get_thread_control_capabilities, attach_no_wait>: New
1133         virtual methods.
1134         <insert_breakpoint, remove_breakpoint>: Now
1135         TARGET_DEFAULT_NORETURN methods.
1136         <info_proc>: Now returns bool.
1137         <to_magic>: Delete.
1138         (OPS_MAGIC): Delete.
1139         (current_target): Delete.  All references replaced by references
1140         to ...
1141         (target_stack): ... this.  New.
1142         (target_shortname, target_longname): Adjust.
1143         (target_can_run): Now a function declaration.
1144         (default_child_has_all_memory, default_child_has_memory)
1145         (default_child_has_stack, default_child_has_registers)
1146         (default_child_has_execution): Remove target_ops parameter.
1147         (complete_target_initialization): Delete.
1148         (memory_breakpoint_target): New template class.
1149         (test_target_ops): Refactor as a C++ class with virtual methods.
1150         * make-target-delegates (NAME_PART): Tighten.
1151         (POINTER_PART, CP_SYMBOL): New.
1152         (SIMPLE_RETURN_PART): Reimplement.
1153         (VEC_RETURN_PART): Expect less.
1154         (RETURN_PART, VIRTUAL_PART): New.
1155         (METHOD): Adjust to C++ virtual methods.
1156         (scan_target_h): Remove reference to C99.
1157         (dname): Output "target_ops::" prefix.
1158         (write_function_header): Adjust to output a C++ class method.
1159         (write_declaration): New.
1160         (write_delegator): Adjust to output a C++ class method.
1161         (tdname): Output "dummy_target::" prefix.
1162         (write_tdefault, write_debugmethod): Adjust to output a C++ class
1163         method.
1164         (tdefault_names, debug_names): Delete.
1165         (return_types, tdefaults, styles, argtypes_array): New.
1166         (top level): All methods are delegators.
1167         (print_class): New.
1168         (top level): Print dummy_target and debug_target classes.
1169         * target-delegates.c: Regenerate.
1170         * target-debug.h (target_debug_print_enum_info_proc_what)
1171         (target_debug_print_thread_control_capabilities)
1172         (target_debug_print_thread_info_p): New.
1173         * target.c (dummy_target): Delete.
1174         (the_dummy_target, the_debug_target): New.
1175         (target_stack): Now extern.
1176         (set_targetdebug): Push/unpush debug target.
1177         (default_child_has_all_memory, default_child_has_memory)
1178         (default_child_has_stack, default_child_has_registers)
1179         (default_child_has_execution): Remove target_ops parameter.
1180         (complete_target_initialization): Delete.
1181         (add_target_with_completer): No longer call
1182         complete_target_initialization.
1183         (target_supports_terminal_ours): Use regular delegation.
1184         (update_current_target): Delete.
1185         (push_target): No longer check magic number.  Don't call
1186         update_current_target.
1187         (unpush_target): Don't call update_current_target.
1188         (target_is_pushed): No longer check magic number.
1189         (target_require_runnable): Skip for all stratums over
1190         process_stratum.
1191         (target_ops::info_proc): New.
1192         (target_info_proc): Use find_target_at and
1193         find_default_run_target.
1194         (target_supports_disable_randomization): Use regular delegation.
1195         (target_get_osdata): Use find_target_at.
1196         (target_ops::open, target_ops::close, target_ops::can_attach)
1197         (target_ops::attach, target_ops::can_create_inferior)
1198         (target_ops::create_inferior, target_ops::can_run)
1199         (target_can_run): New.
1200         (default_fileio_target): Use regular delegation.
1201         (target_ops::fileio_open, target_ops::fileio_pwrite)
1202         (target_ops::fileio_pread, target_ops::fileio_fstat)
1203         (target_ops::fileio_close, target_ops::fileio_unlink)
1204         (target_ops::fileio_readlink): New.
1205         (target_fileio_open_1, target_fileio_unlink)
1206         (target_fileio_readlink): Always call the target method.  Handle
1207         FILEIO_ENOSYS.
1208         (return_zero, return_zero_has_execution): Delete.
1209         (init_dummy_target): Delete.
1210         (dummy_target::dummy_target, dummy_target::shortname)
1211         (dummy_target::longname, dummy_target::doc)
1212         (debug_target::debug_target, debug_target::shortname)
1213         (debug_target::longname, debug_target::doc): New.
1214         (target_supports_delete_record): Use regular delegation.
1215         (setup_target_debug): Delete.
1216         (maintenance_print_target_stack): Skip debug_stratum.
1217         (initialize_targets): Instantiate the_dummy_target and
1218         the_debug_target.
1219         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
1220         use target_stack.
1221         (target_auxv_search, fprint_target_auxv): Adjust.
1222         (info_auxv_command): Adjust to use target_stack.
1223         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
1224         * exceptions.c (print_flush): Handle a NULL target_stack.
1225         * regcache.c (target_ops_no_register): Refactor as class with
1226         virtual methods.
1227
1228         * exec.c (exec_target): New class.
1229         (exec_ops): Now an exec_target.
1230         (exec_open, exec_close_1, exec_get_section_table)
1231         (exec_xfer_partial, exec_files_info, exec_has_memory)
1232         (exec_make_note_section): Refactor as exec_target methods.
1233         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
1234         Delete.
1235         (exec_target::find_memory_regions): New.
1236         (_initialize_exec): Don't call init_exec_ops.
1237         * gdbcore.h (exec_file_clear): Delete.
1238
1239         * corefile.c (core_target): Delete.
1240         (core_file_command): Adjust.
1241         * corelow.c (core_target): New class.
1242         (the_core_target): New.
1243         (core_close): Remove target_ops parameter.
1244         (core_close_cleanup): Adjust.
1245         (core_target::close): New.
1246         (core_open, core_detach, get_core_registers, core_files_info)
1247         (core_xfer_partial, core_thread_alive, core_read_description)
1248         (core_pid_to_str, core_thread_name, core_has_memory)
1249         (core_has_stack, core_has_registers, core_info_proc): Rework as
1250         core_target methods.
1251         (ignore, core_remove_breakpoint, init_core_ops): Delete.
1252         (_initialize_corelow): Initialize the_core_target.
1253         * gdbcore.h (core_target): Delete.
1254         (the_core_target): New.
1255
1256         * ctf.c: (ctf_target): New class.
1257         (ctf_ops): Now a ctf_target.
1258         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
1259         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
1260         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
1261         methods.
1262         (init_ctf_ops): Delete.
1263         (_initialize_ctf): Don't call it.
1264         * tracefile-tfile.c (tfile_target): New class.
1265         (tfile_ops): Now a tfile_target.
1266         (tfile_open, tfile_close, tfile_files_info)
1267         (tfile_get_tracepoint_status, tfile_trace_find)
1268         (tfile_fetch_registers, tfile_xfer_partial)
1269         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
1270         Refactor as tfile_target methods.
1271         (tfile_xfer_partial_features): Remove target_ops parameter.
1272         (init_tfile_ops): Delete.
1273         (_initialize_tracefile_tfile): Don't call it.
1274         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
1275         (tracefile_has_stack, tracefile_has_registers)
1276         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
1277         tracefile_target methods.
1278         (init_tracefile_ops): Delete.
1279         (tracefile_target::tracefile_target): New.
1280         * tracefile.h: Include "target.h".
1281         (tracefile_target): New class.
1282         (init_tracefile_ops): Delete.
1283
1284         * spu-multiarch.c (spu_multiarch_target): New class.
1285         (spu_ops): Now a spu_multiarch_target.
1286         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
1287         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
1288         (spu_search_memory, spu_mourn_inferior): Refactor as
1289         spu_multiarch_target methods.
1290         (init_spu_ops): Delete.
1291         (_initialize_spu_multiarch): Remove references to init_spu_ops,
1292         complete_target_initialization.
1293
1294         * ravenscar-thread.c (ravenscar_thread_target): New class.
1295         (ravenscar_ops): Now a ravenscar_thread_target.
1296         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
1297         (ravenscar_thread_alive, ravenscar_pid_to_str)
1298         (ravenscar_fetch_registers, ravenscar_store_registers)
1299         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
1300         (ravenscar_stopped_by_hw_breakpoint)
1301         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
1302         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
1303         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
1304         methods.
1305         (init_ravenscar_thread_ops): Delete.
1306         (_initialize_ravenscar): Remove references to
1307         init_ravenscar_thread_ops and complete_target_initialization.
1308
1309         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
1310         (bsd_uthread_target): New class.
1311         (bsd_uthread_ops): Now a bsd_uthread_target.
1312         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
1313         (bsd_uthread_close, bsd_uthread_mourn_inferior)
1314         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
1315         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
1316         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
1317         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
1318         (bsd_uthread_target): Delete function.
1319         (_initialize_bsd_uthread): Remove reference to
1320         complete_target_initialization.
1321
1322         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
1323         (target_bfd): ... this new class.
1324         (target_bfd_xfer_partial, target_bfd_get_section_table)
1325         (target_bfd_close): Refactor as target_bfd methods.
1326         (target_bfd::~target_bfd): New.
1327         (target_bfd_reopen): Adjust.
1328         (target_bfd::close): New.
1329
1330         * record-btrace.c (record_btrace_target): New class.
1331         (record_btrace_ops): Now a record_btrace_target.
1332         (record_btrace_open, record_btrace_stop_recording)
1333         (record_btrace_disconnect, record_btrace_close)
1334         (record_btrace_async, record_btrace_info)
1335         (record_btrace_insn_history, record_btrace_insn_history_range)
1336         (record_btrace_insn_history_from, record_btrace_call_history)
1337         (record_btrace_call_history_range)
1338         (record_btrace_call_history_from, record_btrace_record_method)
1339         (record_btrace_is_replaying, record_btrace_will_replay)
1340         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
1341         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
1342         (record_btrace_store_registers, record_btrace_prepare_to_store)
1343         (record_btrace_to_get_unwinder)
1344         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
1345         (record_btrace_commit_resume, record_btrace_wait)
1346         (record_btrace_stop, record_btrace_can_execute_reverse)
1347         (record_btrace_stopped_by_sw_breakpoint)
1348         (record_btrace_supports_stopped_by_sw_breakpoint)
1349         (record_btrace_stopped_by_hw_breakpoint)
1350         (record_btrace_supports_stopped_by_hw_breakpoint)
1351         (record_btrace_update_thread_list, record_btrace_thread_alive)
1352         (record_btrace_goto_begin, record_btrace_goto_end)
1353         (record_btrace_goto, record_btrace_stop_replaying_all)
1354         (record_btrace_execution_direction)
1355         (record_btrace_prepare_to_generate_core)
1356         (record_btrace_done_generating_core): Refactor as
1357         record_btrace_target methods.
1358         (init_record_btrace_ops): Delete.
1359         (_initialize_record_btrace): Remove reference to
1360         init_record_btrace_ops.
1361         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
1362         the execution_direction global.
1363         (record_full_base_target, record_full_target)
1364         (record_full_core_target): New classes.
1365         (record_full_ops): Now a record_full_target.
1366         (record_full_core_ops): Now a record_full_core_target.
1367         (record_full_target::detach, record_full_target::disconnect)
1368         (record_full_core_target::disconnect)
1369         (record_full_target::mourn_inferior, record_full_target::kill):
1370         New.
1371         (record_full_open, record_full_close, record_full_async): Refactor
1372         as methods of the record_full_base_target class.
1373         (record_full_resume, record_full_commit_resume): Refactor
1374         as methods of the record_full_target class.
1375         (record_full_wait, record_full_stopped_by_watchpoint)
1376         (record_full_stopped_data_address)
1377         (record_full_stopped_by_sw_breakpoint)
1378         (record_full_supports_stopped_by_sw_breakpoint)
1379         (record_full_stopped_by_hw_breakpoint)
1380         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
1381         methods of the record_full_base_target class.
1382         (record_full_store_registers, record_full_xfer_partial)
1383         (record_full_insert_breakpoint, record_full_remove_breakpoint):
1384         Refactor as methods of the record_full_target class.
1385         (record_full_can_execute_reverse, record_full_get_bookmark)
1386         (record_full_goto_bookmark, record_full_execution_direction)
1387         (record_full_record_method, record_full_info, record_full_delete)
1388         (record_full_is_replaying, record_full_will_replay)
1389         (record_full_goto_begin, record_full_goto_end, record_full_goto)
1390         (record_full_stop_replaying): Refactor as methods of the
1391         record_full_base_target class.
1392         (record_full_core_resume, record_full_core_kill)
1393         (record_full_core_fetch_registers)
1394         (record_full_core_prepare_to_store)
1395         (record_full_core_store_registers, record_full_core_xfer_partial)
1396         (record_full_core_insert_breakpoint)
1397         (record_full_core_remove_breakpoint)
1398         (record_full_core_has_execution): Refactor
1399         as methods of the record_full_core_target class.
1400         (record_full_base_target::supports_delete_record): New.
1401         (init_record_full_ops): Delete.
1402         (init_record_full_core_ops): Delete.
1403         (record_full_save): Refactor as method of the
1404         record_full_base_target class.
1405         (_initialize_record_full): Remove references to
1406         init_record_full_ops and init_record_full_core_ops.
1407
1408         * remote.c (remote_target, extended_remote_target): New classes.
1409         (remote_ops): Now a remote_target.
1410         (extended_remote_ops): Now an extended_remote_target.
1411         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
1412         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
1413         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
1414         (remote_pass_signals, remote_set_syscall_catchpoint)
1415         (remote_program_signals, )
1416         (remote_thread_always_alive): Remove target_ops parameter.
1417         (remote_thread_alive, remote_thread_name)
1418         (remote_update_thread_list, remote_threads_extra_info)
1419         (remote_static_tracepoint_marker_at)
1420         (remote_static_tracepoint_markers_by_strid)
1421         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
1422         (remote_open): Refactor as methods of remote_target.
1423         (extended_remote_open, extended_remote_detach)
1424         (extended_remote_attach, extended_remote_post_attach):
1425         (extended_remote_supports_disable_randomization)
1426         (extended_remote_create_inferior): : Refactor as method of
1427         extended_remote_target.
1428         (remote_set_permissions, remote_open_1, remote_detach)
1429         (remote_follow_fork, remote_follow_exec, remote_disconnect)
1430         (remote_resume, remote_commit_resume, remote_stop)
1431         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
1432         (remote_terminal_ours, remote_wait, remote_fetch_registers)
1433         (remote_prepare_to_store, remote_store_registers)
1434         (remote_flash_erase, remote_flash_done, remote_files_info)
1435         (remote_kill, remote_mourn, remote_insert_breakpoint)
1436         (remote_remove_breakpoint, remote_insert_watchpoint)
1437         (remote_watchpoint_addr_within_range)
1438         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
1439         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
1440         (remote_supports_stopped_by_sw_breakpoint)
1441         (remote_stopped_by_hw_breakpoint)
1442         (remote_supports_stopped_by_hw_breakpoint)
1443         (remote_stopped_by_watchpoint, remote_stopped_data_address)
1444         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
1445         (remote_verify_memory): Refactor as methods of remote_target.
1446         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
1447         parameter.
1448         (remote_xfer_partial, remote_get_memory_xfer_limit)
1449         (remote_search_memory, remote_rcmd, remote_memory_map)
1450         (remote_pid_to_str, remote_get_thread_local_address)
1451         (remote_get_tib_address, remote_read_description): Refactor as
1452         methods of remote_target.
1453         (remote_target::fileio_open, remote_target::fileio_pwrite)
1454         (remote_target::fileio_pread, remote_target::fileio_close): New.
1455         (remote_hostio_readlink, remote_hostio_fstat)
1456         (remote_filesystem_is_local, remote_can_execute_reverse)
1457         (remote_supports_non_stop, remote_supports_disable_randomization)
1458         (remote_supports_multi_process, remote_supports_cond_breakpoints)
1459         (remote_supports_enable_disable_tracepoint)
1460         (remote_supports_string_tracing)
1461         (remote_can_run_breakpoint_commands, remote_trace_init)
1462         (remote_download_tracepoint, remote_can_download_tracepoint)
1463         (remote_download_trace_state_variable, remote_enable_tracepoint)
1464         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
1465         (remote_trace_start, remote_get_trace_status)
1466         (remote_get_tracepoint_status, remote_trace_stop)
1467         (remote_trace_find, remote_get_trace_state_variable_value)
1468         (remote_save_trace_data, remote_get_raw_trace_data)
1469         (remote_set_disconnected_tracing, remote_core_of_thread)
1470         (remote_set_circular_trace_buffer, remote_traceframe_info)
1471         (remote_get_min_fast_tracepoint_insn_len)
1472         (remote_set_trace_buffer_size, remote_set_trace_notes)
1473         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
1474         (remote_disable_btrace, remote_teardown_btrace)
1475         (remote_read_btrace, remote_btrace_conf)
1476         (remote_augmented_libraries_svr4_read, remote_load)
1477         (remote_pid_to_exec_file, remote_can_do_single_step)
1478         (remote_execution_direction, remote_thread_handle_to_thread_info):
1479         Refactor as methods of remote_target.
1480         (init_remote_ops, init_extended_remote_ops): Delete.
1481         (remote_can_async_p, remote_is_async_p, remote_async)
1482         (remote_thread_events, remote_upload_tracepoints)
1483         (remote_upload_trace_state_variables): Refactor as methods of
1484         remote_target.
1485         (_initialize_remote): Remove references to init_remote_ops and
1486         init_extended_remote_ops.
1487
1488         * remote-sim.c (gdbsim_target): New class.
1489         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
1490         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
1491         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
1492         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
1493         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
1494         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
1495         Refactor as methods of gdbsim_target.
1496         (gdbsim_ops): Now a gdbsim_target.
1497         (init_gdbsim_ops): Delete.
1498         (gdbsim_cntrl_c): Adjust.
1499         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
1500
1501         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
1502         (the_amd64_linux_nat_target): New.
1503         (amd64_linux_fetch_inferior_registers)
1504         (amd64_linux_store_inferior_registers): Refactor as methods of
1505         amd64_linux_nat_target.
1506         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
1507         * i386-linux-nat.c: Don't include "linux-nat.h".
1508         (i386_linux_nat_target): New class.
1509         (the_i386_linux_nat_target): New.
1510         (i386_linux_fetch_inferior_registers)
1511         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
1512         as methods of i386_linux_nat_target.
1513         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
1514         * inf-child.c (inf_child_ops): Delete.
1515         (inf_child_fetch_inferior_registers)
1516         (inf_child_store_inferior_registers): Delete.
1517         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
1518         methods of inf_child_target.
1519         (inf_child_target::supports_terminal_ours)
1520         (inf_child_target::terminal_init)
1521         (inf_child_target::terminal_inferior)
1522         (inf_child_target::terminal_ours_for_output)
1523         (inf_child_target::terminal_ours, inf_child_target::interrupt)
1524         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
1525         New.
1526         (inf_child_open, inf_child_disconnect, inf_child_close)
1527         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
1528         (inf_child_post_startup_inferior, inf_child_can_run)
1529         (inf_child_pid_to_exec_file): Refactor as methods of
1530         inf_child_target.
1531         (inf_child_follow_fork): Delete.
1532         (inf_child_target::can_create_inferior)
1533         (inf_child_target::can_attach): New.
1534         (inf_child_target::has_all_memory, inf_child_target::has_memory)
1535         (inf_child_target::has_stack, inf_child_target::has_registers)
1536         (inf_child_target::has_execution): New.
1537         (inf_child_fileio_open, inf_child_fileio_pwrite)
1538         (inf_child_fileio_pread, inf_child_fileio_fstat)
1539         (inf_child_fileio_close, inf_child_fileio_unlink)
1540         (inf_child_fileio_readlink, inf_child_use_agent)
1541         (inf_child_can_use_agent): Refactor as methods of
1542         inf_child_target.
1543         (return_zero, inf_child_target): Delete.
1544         (inf_child_target::inf_child_target): New.
1545         * inf-child.h: Include "target.h".
1546         (inf_child_target): Delete function prototype.
1547         (inf_child_target): New class.
1548         (inf_child_open_target, inf_child_mourn_inferior)
1549         (inf_child_maybe_unpush_target): Delete.
1550         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
1551         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
1552         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
1553         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
1554         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
1555         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
1556         (inf_ptrace_wait, inf_ptrace_xfer_partial)
1557         (inf_ptrace_thread_alive, inf_ptrace_files_info)
1558         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
1559         methods of inf_ptrace_target.
1560         (inf_ptrace_target): Delete function.
1561         * inf-ptrace.h: Include "inf-child.h".
1562         (inf_ptrace_target): Delete function declaration.
1563         (inf_ptrace_target): New class.
1564         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
1565         * linux-nat.c (linux_target): New.
1566         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
1567         (linux_nat_target::~linux_nat_target): New.
1568         (linux_child_post_attach, linux_child_post_startup_inferior)
1569         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
1570         (linux_child_remove_fork_catchpoint)
1571         (linux_child_insert_vfork_catchpoint)
1572         (linux_child_remove_vfork_catchpoint)
1573         (linux_child_insert_exec_catchpoint)
1574         (linux_child_remove_exec_catchpoint)
1575         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
1576         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
1577         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
1578         (linux_nat_stopped_data_address)
1579         (linux_nat_stopped_by_sw_breakpoint)
1580         (linux_nat_supports_stopped_by_sw_breakpoint)
1581         (linux_nat_stopped_by_hw_breakpoint)
1582         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
1583         (linux_nat_kill, linux_nat_mourn_inferior)
1584         (linux_nat_xfer_partial, linux_nat_thread_alive)
1585         (linux_nat_update_thread_list, linux_nat_pid_to_str)
1586         (linux_nat_thread_name, linux_child_pid_to_exec_file)
1587         (linux_child_static_tracepoint_markers_by_strid)
1588         (linux_nat_is_async_p, linux_nat_can_async_p)
1589         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
1590         (linux_nat_supports_multi_process)
1591         (linux_nat_supports_disable_randomization, linux_nat_async)
1592         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
1593         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
1594         (linux_nat_fileio_open, linux_nat_fileio_readlink)
1595         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
1596         methods of linux_nat_target.
1597         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
1598         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
1599         parameter.
1600         (check_stopped_by_watchpoint): Adjust.
1601         (linux_xfer_partial): Delete.
1602         (linux_target_install_ops, linux_target, linux_nat_add_target):
1603         Delete.
1604         (linux_nat_target::linux_nat_target): New.
1605         * linux-nat.h: Include "inf-ptrace.h".
1606         (linux_nat_target): New.
1607         (linux_target, linux_target_install_ops, linux_nat_add_target):
1608         Delete function declarations.
1609         (linux_target): Declare global.
1610         * linux-thread-db.c (thread_db_target): New.
1611         (thread_db_target::thread_db_target): New.
1612         (thread_db_ops): Delete.
1613         (the_thread_db_target): New.
1614         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
1615         (thread_db_update_thread_list, thread_db_pid_to_str)
1616         (thread_db_extra_thread_info)
1617         (thread_db_thread_handle_to_thread_info)
1618         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
1619         (thread_db_resume): Refactor as methods of thread_db_target.
1620         (init_thread_db_ops): Delete.
1621         (_initialize_thread_db): Remove reference to init_thread_db_ops.
1622         * x86-linux-nat.c: Don't include "linux-nat.h".
1623         (super_post_startup_inferior): Delete.
1624         (x86_linux_nat_target::~x86_linux_nat_target): New.
1625         (x86_linux_child_post_startup_inferior)
1626         (x86_linux_read_description, x86_linux_enable_btrace)
1627         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
1628         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
1629         methods of x86_linux_nat_target.
1630         (x86_linux_create_target): Delete.  Bits folded ...
1631         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
1632         pointer.
1633         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
1634         (x86_linux_nat_target): New class.
1635         (x86_linux_create_target): Delete.
1636         (x86_linux_add_target): Now takes a linux_nat_target pointer.
1637         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
1638         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
1639         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
1640         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
1641         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
1642         make extern.
1643         (x86_use_watchpoints): Delete.
1644         * x86-nat.h: Include "breakpoint.h" and "target.h".
1645         (x86_use_watchpoints): Delete.
1646         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
1647         (x86_stopped_by_watchpoint, x86_stopped_data_address)
1648         (x86_insert_watchpoint, x86_remove_watchpoint)
1649         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
1650         (x86_stopped_by_hw_breakpoint): New declarations.
1651         (x86_nat_target): New template class.
1652
1653         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
1654         (the_ppc_linux_nat_target): New.
1655         (ppc_linux_fetch_inferior_registers)
1656         (ppc_linux_can_use_hw_breakpoint)
1657         (ppc_linux_region_ok_for_hw_watchpoint)
1658         (ppc_linux_ranged_break_num_registers)
1659         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
1660         (ppc_linux_insert_mask_watchpoint)
1661         (ppc_linux_remove_mask_watchpoint)
1662         (ppc_linux_can_accel_watchpoint_condition)
1663         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
1664         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
1665         (ppc_linux_watchpoint_addr_within_range)
1666         (ppc_linux_masked_watch_num_registers)
1667         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
1668         (ppc_linux_read_description): Refactor as methods of
1669         ppc_linux_nat_target.
1670         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
1671
1672         * procfs.c (procfs_xfer_partial): Delete forward declaration.
1673         (procfs_target): New class.
1674         (the_procfs_target): New.
1675         (procfs_target): Delete function.
1676         (procfs_auxv_parse, procfs_attach, procfs_detach)
1677         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
1678         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
1679         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
1680         (procfs_create_inferior, procfs_update_thread_list)
1681         (procfs_thread_alive, procfs_pid_to_str)
1682         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
1683         (procfs_stopped_data_address, procfs_insert_watchpoint)
1684         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
1685         (proc_find_memory_regions, procfs_info_proc)
1686         (procfs_make_note_section): Refactor as methods of procfs_target.
1687         (_initialize_procfs): Adjust.
1688         * sol-thread.c (sol_thread_target): New class.
1689         (sol_thread_ops): Now a sol_thread_target.
1690         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
1691         (sol_thread_fetch_registers, sol_thread_store_registers)
1692         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
1693         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
1694         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
1695         (init_sol_thread_ops): Delete.
1696         (_initialize_sol_thread): Adjust.  Remove references to
1697         init_sol_thread_ops and complete_target_initialization.
1698
1699         * windows-nat.c (windows_nat_target): New class.
1700         (windows_fetch_inferior_registers)
1701         (windows_store_inferior_registers, windows_resume, windows_wait)
1702         (windows_attach, windows_detach, windows_pid_to_exec_file)
1703         (windows_files_info, windows_create_inferior)
1704         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
1705         (windows_close, windows_pid_to_str, windows_xfer_partial)
1706         (windows_get_tib_address, windows_get_ada_task_ptid)
1707         (windows_thread_name, windows_thread_alive): Refactor as
1708         windows_nat_target methods.
1709         (do_initial_windows_stuff): Adjust.
1710         (windows_target): Delete function.
1711         (_initialize_windows_nat): Adjust.
1712
1713         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
1714         (darwin_mourn_inferior, darwin_kill_inferior)
1715         (darwin_create_inferior, darwin_attach, darwin_detach)
1716         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
1717         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
1718         (darwin_supports_multi_process): Refactor as darwin_nat_target
1719         methods.
1720         (darwin_resume_to, darwin_files_info): Delete.
1721         (_initialize_darwin_inferior): Rename to ...
1722         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
1723         * darwin-nat.h: Include "inf-child.h".
1724         (darwin_nat_target): New class.
1725         (darwin_complete_target): Delete.
1726         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
1727         (darwin_target): New.
1728         (i386_darwin_fetch_inferior_registers)
1729         (i386_darwin_store_inferior_registers): Refactor as methods of
1730         darwin_nat_target.
1731         (darwin_complete_target): Delete, with ...
1732         (_initialize_i386_darwin_nat): ... bits factored out here.
1733
1734         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
1735         (the_alpha_linux_nat_target): New.
1736         (alpha_linux_register_u_offset): Refactor as
1737         alpha_linux_nat_target method.
1738         (_initialize_alpha_linux_nat): Adjust.
1739         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
1740         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
1741         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
1742         methods of linux_nat_trad_target.
1743         (linux_trad_target): Delete.
1744         * linux-nat-trad.h (linux_trad_target): Delete function.
1745         (linux_nat_trad_target): New class.
1746         * mips-linux-nat.c (mips_linux_nat_target): New class.
1747         (super_fetch_registers, super_store_registers, super_close):
1748         Delete.
1749         (the_mips_linux_nat_target): New.
1750         (mips64_linux_regsets_fetch_registers)
1751         (mips64_linux_regsets_store_registers)
1752         (mips64_linux_fetch_registers, mips64_linux_store_registers)
1753         (mips_linux_register_u_offset, mips_linux_read_description)
1754         (mips_linux_can_use_hw_breakpoint)
1755         (mips_linux_stopped_by_watchpoint)
1756         (mips_linux_stopped_data_address)
1757         (mips_linux_region_ok_for_hw_watchpoint)
1758         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
1759         (mips_linux_close): Refactor as methods of mips_linux_nat.
1760         (_initialize_mips_linux_nat): Adjust to C++ification.
1761
1762         * aix-thread.c (aix_thread_target): New class.
1763         (aix_thread_ops): Now an aix_thread_target.
1764         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
1765         (aix_thread_fetch_registers, aix_thread_store_registers)
1766         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
1767         (aix_thread_thread_alive, aix_thread_pid_to_str)
1768         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
1769         Refactor as methods of aix_thread_target.
1770         (init_aix_thread_ops): Delete.
1771         (_initialize_aix_thread): Remove references to init_aix_thread_ops
1772         and complete_target_initialization.
1773         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
1774         (rs6000_nat_target): New class.
1775         (the_rs6000_nat_target): New.
1776         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
1777         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
1778         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
1779         (super_create_inferior): Delete.
1780         (_initialize_rs6000_nat): Adjust to C++ification.
1781
1782         * arm-linux-nat.c (arm_linux_nat_target): New class.
1783         (the_arm_linux_nat_target): New.
1784         (arm_linux_fetch_inferior_registers)
1785         (arm_linux_store_inferior_registers, arm_linux_read_description)
1786         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
1787         (arm_linux_remove_hw_breakpoint)
1788         (arm_linux_region_ok_for_hw_watchpoint)
1789         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
1790         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
1791         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
1792         arm_linux_nat_target.
1793         (_initialize_arm_linux_nat): Adjust to C++ification.
1794
1795         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
1796         (the_aarch64_linux_nat_target): New.
1797         (aarch64_linux_fetch_inferior_registers)
1798         (aarch64_linux_store_inferior_registers)
1799         (aarch64_linux_child_post_startup_inferior)
1800         (aarch64_linux_read_description)
1801         (aarch64_linux_can_use_hw_breakpoint)
1802         (aarch64_linux_insert_hw_breakpoint)
1803         (aarch64_linux_remove_hw_breakpoint)
1804         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
1805         (aarch64_linux_region_ok_for_hw_watchpoint)
1806         (aarch64_linux_stopped_data_address)
1807         (aarch64_linux_stopped_by_watchpoint)
1808         (aarch64_linux_watchpoint_addr_within_range)
1809         (aarch64_linux_can_do_single_step): Refactor as methods of
1810         aarch64_linux_nat_target.
1811         (super_post_startup_inferior): Delete.
1812         (_initialize_aarch64_linux_nat): Adjust to C++ification.
1813
1814         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
1815         (the_hppa_linux_nat_target): New.
1816         (hppa_linux_fetch_inferior_registers)
1817         (hppa_linux_store_inferior_registers): Refactor as methods of
1818         hppa_linux_nat_target.
1819         (_initialize_hppa_linux_nat): Adjust to C++ification.
1820
1821         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
1822         (the_ia64_linux_nat_target): New.
1823         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
1824         (ia64_linux_stopped_data_address)
1825         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
1826         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
1827         ia64_linux_nat_target methods.
1828         (super_xfer_partial): Delete.
1829         (_initialize_ia64_linux_nat): Adjust to C++ification.
1830
1831         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
1832         (the_m32r_linux_nat_target): New.
1833         (m32r_linux_fetch_inferior_registers)
1834         (m32r_linux_store_inferior_registers): Refactor as
1835         m32r_linux_nat_target methods.
1836         (_initialize_m32r_linux_nat): Adjust to C++ification.
1837
1838         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
1839         (the_m68k_linux_nat_target): New.
1840         (m68k_linux_fetch_inferior_registers)
1841         (m68k_linux_store_inferior_registers): Refactor as
1842         m68k_linux_nat_target methods.
1843         (_initialize_m68k_linux_nat): Adjust to C++ification.
1844
1845         * s390-linux-nat.c (s390_linux_nat_target): New class.
1846         (the_s390_linux_nat_target): New.
1847         (s390_linux_fetch_inferior_registers)
1848         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
1849         (s390_insert_watchpoint, s390_remove_watchpoint)
1850         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
1851         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
1852         (s390_auxv_parse, s390_read_description): Refactor as methods of
1853         s390_linux_nat_target.
1854         (_initialize_s390_nat): Adjust to C++ification.
1855
1856         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
1857         (the_sparc_linux_nat_target): New.
1858         (_initialize_sparc_linux_nat): Adjust to C++ification.
1859         * sparc-nat.c (sparc_fetch_inferior_registers)
1860         (sparc_store_inferior_registers): Remove target_ops parameter.
1861         * sparc-nat.h (sparc_fetch_inferior_registers)
1862         (sparc_store_inferior_registers): Remove target_ops parameter.
1863         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
1864         (the_sparc64_linux_nat_target): New.
1865         (_initialize_sparc64_linux_nat): Adjust to C++ification.
1866
1867         * spu-linux-nat.c (spu_linux_nat_target): New class.
1868         (the_spu_linux_nat_target): New.
1869         (spu_child_post_startup_inferior, spu_child_post_attach)
1870         (spu_child_wait, spu_fetch_inferior_registers)
1871         (spu_store_inferior_registers, spu_xfer_partial)
1872         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
1873         methods.
1874         (_initialize_spu_nat): Adjust to C++ification.
1875
1876         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
1877         (the_tilegx_linux_nat_target): New.
1878         (fetch_inferior_registers, store_inferior_registers):
1879         Refactor as methods.
1880         (_initialize_tile_linux_nat): Adjust to C++ification.
1881
1882         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
1883         (the_xtensa_linux_nat_target): New.
1884         (xtensa_linux_fetch_inferior_registers)
1885         (xtensa_linux_store_inferior_registers): Refactor as
1886         xtensa_linux_nat_target methods.
1887         (_initialize_xtensa_linux_nat): Adjust to C++ification.
1888
1889         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
1890         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
1891         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
1892         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
1893         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
1894         (fbsd_stopped_by_sw_breakpoint)
1895         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
1896         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
1897         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
1898         (fbsd_post_startup_inferior, fbsd_post_attach)
1899         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
1900         (fbsd_set_syscall_catchpoint)
1901         (super_xfer_partial, super_resume, super_wait)
1902         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
1903         (fbsd_handle_debug_trap): Remove target_ops parameter.
1904         (fbsd_nat_add_target): Delete.
1905         * fbsd-nat.h: Include "inf-ptrace.h".
1906         (fbsd_nat_add_target): Delete.
1907         (USE_SIGTRAP_SIGINFO): Define.
1908         (fbsd_nat_target): New class.
1909
1910         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
1911         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
1912         (amd64bsd_target): Delete.
1913         * amd64-bsd-nat.h: New file.
1914         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
1915         "x86-bsd-nat.h".
1916         (amd64_fbsd_nat_target): New class.
1917         (the_amd64_fbsd_nat_target): New.
1918         (amd64fbsd_read_description): Refactor as method of
1919         amd64_fbsd_nat_target.
1920         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
1921         (_initialize_amd64fbsd_nat): Adjust to C++ification.
1922         * amd64-nat.h (amd64bsd_target): Delete function declaration.
1923         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
1924         (i386bsd_store_inferior_registers): Remove target_ops parameter.
1925         (i386bsd_target): Delete.
1926         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
1927         (i386bsd_fetch_inferior_registers)
1928         (i386bsd_store_inferior_registers): Declare.
1929         (i386_bsd_nat_target): New class.
1930         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
1931         (the_i386_fbsd_nat_target): New.
1932         (i386fbsd_resume, i386fbsd_read_description): Refactor as
1933         i386_fbsd_nat_target methods.
1934         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
1935         (_initialize_i386fbsd_nat): Adjust to C++ification.
1936         * x86-bsd-nat.c (super_mourn_inferior): Delete.
1937         (x86bsd_mourn_inferior, x86bsd_target): Delete.
1938         (_initialize_x86_bsd_nat): Adjust to C++ification.
1939         * x86-bsd-nat.h: Include "x86-nat.h".
1940         (x86bsd_target): Delete declaration.
1941         (x86bsd_nat_target): New class.
1942
1943         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
1944         (the_aarch64_fbsd_nat_target): New.
1945         (aarch64_fbsd_fetch_inferior_registers)
1946         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
1947         aarch64_fbsd_nat_target.
1948         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
1949         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
1950         (the_alpha_bsd_nat_target): New.
1951         (alphabsd_fetch_inferior_registers)
1952         (alphabsd_store_inferior_registers): Refactor as
1953         alpha_bsd_nat_target methods.
1954         (_initialize_alphabsd_nat): Refactor as methods of
1955         alpha_bsd_nat_target.
1956         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
1957         (the_amd64_nbsd_nat_target): New.
1958         (_initialize_amd64nbsd_nat): Adjust to C++ification.
1959         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
1960         (the_amd64_obsd_nat_target): New.
1961         (_initialize_amd64obsd_nat): Adjust to C++ification.
1962         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
1963         (the_arm_fbsd_nat_target): New.
1964         (arm_fbsd_fetch_inferior_registers)
1965         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
1966         (_initialize_arm_fbsd_nat): Refactor as methods of
1967         arm_fbsd_nat_target.
1968         (_initialize_arm_fbsd_nat): Adjust to C++ification.
1969         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
1970         (the_arm_netbsd_nat_target): New.
1971         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
1972         arm_netbsd_nat_target.
1973         (_initialize_arm_netbsd_nat): Adjust to C++ification.
1974         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
1975         (the_hppa_nbsd_nat_target): New.
1976         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
1977         hppa_nbsd_nat_target methods.
1978         (_initialize_hppanbsd_nat): Adjust to C++ification.
1979         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
1980         (the_hppa_obsd_nat_target): New.
1981         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
1982         methods of hppa_obsd_nat_target.
1983         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
1984         add_target.
1985         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
1986         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
1987         add_target.
1988         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
1989         (_initialize_i386obsd_nat): Use add_target.
1990         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
1991         (the_m68k_bsd_nat_target): New.
1992         (m68kbsd_fetch_inferior_registers)
1993         (m68kbsd_store_inferior_registers): Refactor as methods of
1994         m68k_bsd_nat_target.
1995         (_initialize_m68kbsd_nat): Adjust to C++ification.
1996         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
1997         (the_mips_fbsd_nat_target): New.
1998         (mips_fbsd_fetch_inferior_registers)
1999         (mips_fbsd_store_inferior_registers): Refactor as methods of
2000         mips_fbsd_nat_target.
2001         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
2002         add_target.
2003         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
2004         (the_mips_nbsd_nat_target): New.
2005         (mipsnbsd_fetch_inferior_registers)
2006         (mipsnbsd_store_inferior_registers): Refactor as methods of
2007         mips_nbsd_nat_target.
2008         (_initialize_mipsnbsd_nat): Adjust to C++ification.
2009         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
2010         (the_mips64_obsd_nat_target): New.
2011         (mips64obsd_fetch_inferior_registers)
2012         (mips64obsd_store_inferior_registers): Refactor as methods of
2013         mips64_obsd_nat_target.
2014         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
2015         add_target.
2016         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
2017         nbsd_nat_target.
2018         * nbsd-nat.h: Include "inf-ptrace.h".
2019         (nbsd_nat_target): New class.
2020         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
2021         (obsd_wait): Refactor as methods of obsd_nat_target.
2022         (obsd_add_target): Delete.
2023         * obsd-nat.h: Include "inf-ptrace.h".
2024         (obsd_nat_target): New class.
2025         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
2026         (the_ppc_fbsd_nat_target): New.
2027         (ppcfbsd_fetch_inferior_registers)
2028         (ppcfbsd_store_inferior_registers): Refactor as methods of
2029         ppc_fbsd_nat_target.
2030         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
2031         add_target.
2032         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
2033         (the_ppc_nbsd_nat_target): New.
2034         (ppcnbsd_fetch_inferior_registers)
2035         (ppcnbsd_store_inferior_registers): Refactor as methods of
2036         ppc_nbsd_nat_target.
2037         (_initialize_ppcnbsd_nat): Adjust to C++ification.
2038         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
2039         (the_ppc_obsd_nat_target): New.
2040         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
2041         methods of ppc_obsd_nat_target.
2042         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
2043         add_target.
2044         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
2045         (the_sh_nbsd_nat_target): New.
2046         (shnbsd_fetch_inferior_registers)
2047         (shnbsd_store_inferior_registers): Refactor as methods of
2048         sh_nbsd_nat_target.
2049         (_initialize_shnbsd_nat): Adjust to C++ification.
2050         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
2051         (inf_ptrace_xfer_partial): Delete.
2052         (sparc_xfer_partial, sparc_target): Delete.
2053         * sparc-nat.h (sparc_fetch_inferior_registers)
2054         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
2055         (sparc_target): Delete function declaration.
2056         (sparc_target): New template class.
2057         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
2058         (_initialize_sparcnbsd_nat): Adjust to C++ification.
2059         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
2060         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
2061         add_target.
2062         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
2063         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
2064         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
2065         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
2066         add_target.
2067         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
2068         (the_vax_bsd_nat_target): New.
2069         (vaxbsd_fetch_inferior_registers)
2070         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
2071         methods.
2072         (_initialize_vaxbsd_nat): Adjust to C++ification.
2073
2074         * bsd-kvm.c (bsd_kvm_target): New class.
2075         (bsd_kvm_ops): Now a bsd_kvm_target.
2076         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
2077         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
2078         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
2079         bsd_kvm_target.
2080         (bsd_kvm_return_one): Delete.
2081         (bsd_kvm_add_target): Adjust to C++ification.
2082
2083         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
2084         (nto_procfs_target_procfs): New classes.
2085         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
2086         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
2087         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
2088         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
2089         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
2090         (procfs_remove_hw_breakpoint, procfs_resume)
2091         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
2092         (procfs_kill_inferior, procfs_store_registers)
2093         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
2094         as methods of nto_procfs_target.
2095         (nto_procfs_ops): Now an nto_procfs_target_procfs.
2096         (nto_native_ops): Delete.
2097         (procfs_open, procfs_native_open): Delete.
2098         (nto_native_ops): Now an nto_procfs_target_native.
2099         (init_procfs_targets): Adjust to C++ification.
2100         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
2101         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
2102         Refactor as methods of nto_procfs_target.
2103
2104         * go32-nat.c (go32_nat_target): New class.
2105         (the_go32_nat_target): New.
2106         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
2107         (go32_store_registers, go32_xfer_partial, go32_files_info)
2108         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
2109         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
2110         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
2111         (go32_pid_to_str): Refactor as methods of go32_nat_target.
2112         (go32_target): Delete.
2113         (_initialize_go32_nat): Adjust to C++ification.
2114
2115         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
2116         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
2117         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
2118         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
2119         gnu_nat_target.
2120         (gnu_target): Delete.
2121         * gnu-nat.h (gnu_target): Delete.
2122         (gnu_nat_target): New class.
2123         * i386-gnu-nat.c (gnu_base_target): New.
2124         (i386_gnu_nat_target): New class.
2125         (the_i386_gnu_nat_target): New.
2126         (_initialize_i386gnu_nat): Adjust to C++ification.
2127
2128 2018-05-02  Pedro Alves  <palves@redhat.com>
2129
2130         * bfd-target.c (target_bfd_xclose): Rename to ...
2131         (target_bfd_close): ... this.
2132         (target_bfd_reopen): Adjust.
2133         * target.c (target_close): Remove references to to_xclose.
2134         * target.h (target_ops::to_xclose): Delete.
2135         (target_ops::to_close): Update comments.
2136
2137 2018-05-02  Pedro Alves  <palves@redhat.com>
2138
2139         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
2140         "linux-nat.h".
2141         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
2142         * inf-ptrace.c (inf_ptrace_register_u_offset)
2143         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2144         (inf_ptrace_store_register, inf_ptrace_store_registers)
2145         (inf_ptrace_trad_target): Move to ...
2146         * linux-nat-trad.c: ... this new file.
2147         * linux-nat-trad.h: New file.
2148         * linux-nat.c (linux_target_install_ops): Make extern.
2149         (linux_trad_target): Delete.
2150         * linux-nat.h (linux_trad_target): Delete declaration.
2151         (linux_target_install_ops): Declare.
2152         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
2153         "linux-nat.h".
2154
2155 2018-05-02  Pedro Alves  <palves@redhat.com>
2156
2157         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2158         procfs_target/add_target here.
2159         * procfs.c (procfs_target): Make static.
2160         (_initialize_procfs): Call add_target here.
2161         * procfs.h (struct target_ops): Remove forward declaration.
2162         (procfs_target): Remove declaration.
2163         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
2164
2165 2018-05-02  Pedro Alves  <palves@redhat.com>
2166
2167         * procfs.c (procfs_stopped_by_watchpoint)
2168         (procfs_insert_watchpoint, procfs_remove_watchpoint)
2169         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
2170         Forward declare.
2171         (procfs_use_watchpoints): Delete, move contents...
2172         (procfs_target): ... here.
2173         * procfs.h (procfs_use_watchpoints): Delete declaration.
2174         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2175         procfs_use_watchpoints.
2176         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
2177         procfs_use_watchpoints.
2178
2179 2018-05-02  Tom Tromey  <tom@tromey.com>
2180
2181         PR python/20084:
2182         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
2183         and var_zuinteger_unlimited.
2184         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
2185         and PARAM_ZUINTEGER_UNLIMITED.
2186         (set_parameter_value): Handle var_zuinteger and
2187         var_zuinteger_unlimited.
2188         (add_setshow_generic): Likewise.
2189         (parmpy_init): Likewise.
2190
2191 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
2192
2193         PR rust/23124
2194         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
2195         pointer is not null before dereferencing it.
2196
2197 2018-04-30  Tom Tromey  <tom@tromey.com>
2198
2199         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
2200         is_mi_like_p.
2201
2202 2018-04-30  Tom Tromey  <tom@tromey.com>
2203
2204         * breakpoint.c (mention): Remove use of is_mi_like_p.
2205         (print_mention_ranged_breakpoint): Likewise.
2206         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
2207         of is_mi_like_p.
2208
2209 2018-04-30  Tom Tromey  <tom@tromey.com>
2210
2211         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
2212
2213 2018-04-30  Tom Tromey  <tom@tromey.com>
2214
2215         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
2216         (info_spu_event_command): Remove some uses of is_mi_like_p.
2217
2218 2018-04-30  Tom Tromey  <tom@tromey.com>
2219
2220         * python/py-framefilter.c (py_print_single_arg)
2221         (enumerate_locals, py_print_args, py_print_frame): Remove some
2222         uses of is_mi_like_p.
2223
2224 2018-04-30  Tom Tromey  <tom@tromey.com>
2225
2226         * ui-out.c: Update.
2227         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
2228         * ui-out.h (ui_out::is_mi_like_p): Now const.
2229         (ui_out::do_is_mi_like_p): Now const.
2230         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
2231
2232 2018-04-30  Tom Tromey  <tom@tromey.com>
2233
2234         * varobj.c (varobj_set_visualizer): Use new_reference.
2235         * python/python.c (gdbpy_decode_line): Use new_reference.
2236         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
2237         new_reference.
2238
2239 2018-04-30  Tom Tromey  <tom@tromey.com>
2240
2241         * varobj.c (install_new_value): Use new_reference.
2242         * value.h (value_incref): Return void.  Swap intro comment with
2243         value_decref.
2244         * value.c (set_value_parent): Use new_reference.
2245         (value_incref): Return void.  Update intro comment.
2246         (release_value): Use new_reference.
2247         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
2248
2249 2018-04-30  Tom Tromey  <tom@tromey.com>
2250
2251         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
2252         * gdb_bfd.h (new_bfd_ref): Remove.
2253         (gdb_bfd_open): Update comment.
2254         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
2255         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
2256         (gdb_bfd_fdopenr): Use new_reference.
2257         * exec.c (exec_file_attach): Use new_reference.
2258
2259 2018-04-30  Tom Tromey  <tom@tromey.com>
2260
2261         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
2262         method.
2263
2264 2018-04-30  Tom Tromey  <tom@tromey.com>
2265
2266         * jit.c (jit_read_code_entry): Use type_align.
2267         * i386-tdep.c (i386_gdbarch_init): Don't call
2268         set_gdbarch_long_long_align_bit.
2269         * gdbarch.sh: Remove long_long_align_bit.
2270         * gdbarch.c, gdbarch.h: Rebuild.
2271         * arc-tdep.c (arc_type_align): New function.
2272         (arc_gdbarch_init): Use arc_type_align.  Don't call
2273         set_gdbarch_long_long_align_bit.
2274
2275 2018-04-30  Tom Tromey  <tom@tromey.com>
2276
2277         * rust-lang.c (rust_type_alignment): Remove.
2278         (rust_composite_type): Use type_align.
2279
2280 2018-04-30  Tom Tromey  <tom@tromey.com>
2281
2282         * NEWS: Mention Type.align.
2283         * python/py-type.c (typy_get_alignof): New function.
2284         (type_object_getset): Add "alignof".
2285
2286 2018-04-30  Tom Tromey  <tom@tromey.com>
2287
2288         PR exp/17095:
2289         * NEWS: Update.
2290         * std-operator.def (UNOP_ALIGNOF): New operator.
2291         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
2292         New.
2293         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
2294         * c-lang.c (c_op_print_tab): Add alignof.
2295         * c-exp.y (ALIGNOF): New token.
2296         (exp): Add "ALIGNOF" production.
2297         (ident_tokens): Add _Alignof and alignof.
2298
2299 2018-04-30  Tom Tromey  <tom@tromey.com>
2300
2301         * i386-tdep.c (i386_type_align): New function.
2302         (i386_gdbarch_init): Update.
2303         * gdbarch.sh (type_align): New method.
2304         * gdbarch.c, gdbarch.h: Rebuild.
2305         * arch-utils.h (default_type_align): Declare.
2306         * arch-utils.c (default_type_align): New function.
2307         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
2308         (struct type) <align_log2>: New field.
2309         <instance_flags>: Now a bitfield.
2310         (TYPE_RAW_ALIGN): New macro.
2311         (type_align, type_raw_align, set_type_align): Declare.
2312         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
2313         functions.
2314         * dwarf2read.c (quirk_rust_enum): Set type alignment.
2315         (get_alignment, maybe_set_alignment): New functions.
2316         (read_structure_type, read_enumeration_type, read_array_type)
2317         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
2318         (read_subrange_type, read_base_type): Set type alignment.
2319
2320 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
2321
2322         * dwarf2read.c (read_index_from_section): Use bool.
2323
2324 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
2325
2326         PR gdb/22950
2327         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
2328         with #ifdef.
2329
2330 2018-04-29  John Reiser  <jreiser@BitWagon.com>
2331
2332         PR build/22873
2333         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
2334         last step, and do it atomically.
2335
2336 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
2337
2338         * compile/compile-c-types.c (convert_int, convert_float):
2339         Update for C FE v1.
2340
2341 2018-04-27  Tom Tromey  <tom@tromey.com>
2342
2343         PR rust/22545:
2344         * rust-lang.c (rust_inclusive_range_type_p): New function.
2345         (rust_range): Handle inclusive ranges.
2346         (rust_compute_range): Likewise.
2347         * rust-exp.y (struct rust_op) <inclusive>: New field.
2348         (DOTDOTEQ): New constant.
2349         (range_expr): Add "..=" productions.
2350         (operator_tokens): Add "..=" token.
2351         (ast_range): Add "inclusive" parameter.
2352         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
2353         ranges.
2354         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
2355         bounds values.
2356         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
2357         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
2358         Update comments.
2359         * expprint.c (print_subexp_standard): Handle new bounds values.
2360         (dump_subexp_body_standard): Likewise.
2361
2362 2018-04-27  Tom Tromey  <tom@tromey.com>
2363
2364         * configure: Rebuild.
2365         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
2366         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
2367         "OVERRIDE".
2368         (class symbol_needs_eval_context): Likewise.
2369         * dwarf2read.c (mock_mapped_index::symbol_name_count)
2370         (mock_mapped_index::symbol_name_at): Use "override".  Remove
2371         "virtual".
2372         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
2373         "override".
2374         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
2375         * aarch64-tdep.c (instruction_reader::read): Use "override".
2376         (instruction_reader_test::read): Likewise.
2377         * arm-tdep.c (instruction_reader::read): Use "override".
2378         (instruction_reader_thumb::read): Likewise.
2379
2380 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
2381
2382         PR remote/9665
2383         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
2384         instead of remote_send.
2385         (remote_send): Remove.
2386
2387 2018-04-26  Pedro Alves  <palves@redhat.com>
2388
2389         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
2390         find_function_start_sal instead of find_pc_line.
2391
2392 2018-04-26  Pedro Alves  <palves@redhat.com>
2393
2394         * breakpoint.c (set_breakpoint_location_function): Handle
2395         mst_data_gnu_ifunc.
2396         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
2397         * elfread.c (elf_symtab_read): Give data symbols with
2398         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
2399         (elf_rel_plt_read): Update comment.
2400         * linespec.c (convert_linespec_to_sals): Handle
2401         mst_data_gnu_ifunc.
2402         (minsym_found): Handle mst_data_gnu_ifunc.
2403         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
2404         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
2405         * parse.c (find_minsym_type_and_address): Handle
2406         mst_data_gnu_ifunc.
2407         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
2408         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
2409         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
2410         comment.
2411         <mst_data_gnu_ifunc>: New enumerator.
2412
2413 2018-04-26  Pedro Alves  <palves@redhat.com>
2414
2415         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
2416         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
2417         'want_trampoline' parameter by a lookup_msym_prefer parameter.
2418         Handle it.
2419         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
2420         (lookup_minimal_symbol_by_pc): Adjust.
2421         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
2422         (lookup_solib_trampoline_symbol_by_pc): Adjust.
2423         * minsyms.h (lookup_msym_prefer): New enum.
2424         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
2425         parameter by a lookup_msym_prefer parameter.
2426
2427 2018-04-26  Pedro Alves  <palves@redhat.com>
2428
2429         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
2430         ends in "@plt" instead of looking at the symbol's section.
2431
2432 2018-04-26  Pedro Alves  <palves@redhat.com>
2433
2434         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
2435         all references.
2436         (find_pc_partial_function_gnu_ifunc): Rename to ...
2437         (find_pc_partial_function): ... this, and remove references to
2438         'is_gnu_ifunc_p'.
2439         (find_pc_partial_function): Delete old implementation.
2440         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
2441
2442 2018-04-26  Pedro Alves  <palves@redhat.com>
2443
2444         * linespec.c (struct bound_minimal_symbol_search_key): New.
2445         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
2446         skip first line if we found a GNU ifunc minimal symbol by name.
2447         (compare_msymbols): Change parameters to work with a destructured
2448         lhs minsym.
2449         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
2450         functions.
2451
2452 2018-04-26  Pedro Alves  <palves@redhat.com>
2453
2454         * breakpoint.c (set_breakpoint_location_function): Don't resolve
2455         ifunc targets here.  Instead, if we have an ifunc minsym, use its
2456         address/name.
2457         (add_location_to_breakpoint): Store the minsym and the objfile in
2458         the breakpoint location.
2459         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
2460         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
2461         Record the minsym in the sal.
2462         * symtab.h (symtab_and_line) <msymbol>: New field.
2463
2464 2018-04-26  Pedro Alves  <palves@redhat.com>
2465
2466         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
2467         unless we actually resolved the ifunc.
2468
2469 2018-04-26  Pedro Alves  <palves@redhat.com>
2470
2471         * c-exp.y (variable production): Prefer ifunc minsyms over
2472         regular function symbols.
2473         * symtab.c (find_gnu_ifunc): New function.
2474         * minsyms.h (lookup_msym_prefer): New enum.
2475         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
2476         parameter by a lookup_msym_prefer parameter.
2477         * symtab.h (find_gnu_ifunc): New declaration.
2478
2479 2018-04-26  Pedro Alves  <palves@redhat.com>
2480
2481         * blockframe.c (find_gnu_ifunc_target_type): New function.
2482         (find_function_type): New.
2483         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
2484         return a value with a memory address.
2485         (eval_call): For calls to GNU ifunc functions, try to find the
2486         type of the target function from the type that the resolver
2487         returns.
2488         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
2489         symbols.
2490         * infcall.c (find_function_return_type): Delete.
2491         (find_function_addr): Add 'function_type' parameter.  For calls to
2492         GNU ifunc functions, try to find the type of the target function
2493         from the type that the resolver returns, and return it via
2494         FUNCTION_TYPE.
2495         (call_function_by_hand_dummy): Adjust to use the function type
2496         returned by find_function_addr.
2497         (find_function_addr): Add 'function_type' parameter and move
2498         description here.
2499         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
2500         declarations.
2501
2502 2018-04-26  Pedro Alves  <palves@redhat.com>
2503
2504         * c-exp.y (variable production): Skip finding an alias for ifunc
2505         symbols.
2506
2507 2018-04-26  Pedro Alves  <palves@redhat.com>
2508
2509         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
2510
2511 2018-04-25  Pedro Alves  <palves@redhat.com>
2512
2513         * infcmd.c (kill_command): Print the pid as string, not the whole
2514         thread's ptid.  Add comment.  s/has been killed/killed/ in output
2515         message.
2516         * remote.c (remote_detach_1): Print the pid as string, not the
2517         whole thread's ptid.
2518
2519 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
2520             Sergio Durigan Junior  <sergiodj@redhat.com>
2521             Pedro Alves  <palves@redhat.com>
2522
2523         * infcmd.c (kill_command): Print message when inferior has
2524         been killed.
2525         * inferior.c (print_inferior_events): Remove 'static'.  Set as
2526         '1'.
2527         (add_inferior): Improve message printed when
2528         'print_inferior_events' is on.
2529         (exit_inferior): Remove message printed when
2530         'print_inferior_events' is on.
2531         (detach_inferior): Improve message printed when
2532         'print_inferior_events' is on.
2533         (initialize_inferiors): Use 'add_inferior_silent' to set
2534         'current_inferior_'.
2535         * inferior.h (print_inferior_events): Declare here as
2536         'extern'.
2537         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
2538         '[Detaching...]' messages when 'print_inferior_events' is on.
2539         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
2540         as prefix/suffix for messages.  Remove periods.  Fix erroneous
2541         'Detaching after fork from child...', replace it by '... from
2542         parent...'.
2543         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
2544         prefix/suffix when printing 'Detaching...' messages.  Print
2545         them when 'print_inferior_events' is on.
2546         * remote.c (remote_detach_1): Print message when detaching
2547         from inferior and '!is_fork_parent'.
2548
2549 2018-04-24  Tom Tromey  <tom@tromey.com>
2550
2551         * cli-out.h: Reindent.
2552
2553 2018-04-24  Tom Tromey  <tom@tromey.com>
2554
2555         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
2556         (cli_ui_out::do_field_string): Use fputs_filtered.
2557         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
2558
2559 2018-04-23  Tom Tromey  <tom@tromey.com>
2560
2561         * guile/scm-frame.c (gdbscm_frame_read_var): Use
2562         gdb::unique_xmalloc_ptr.
2563
2564 2018-04-23  Tom Tromey  <tom@tromey.com>
2565
2566         * configure: Rebuild.
2567
2568 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
2569
2570         PR gdb/23095
2571         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
2572         prepare_for_testing.  Set normal_bp to r_debug_state if target
2573         is bsd.
2574
2575 2018-04-21  Pedro Alves  <palves@redhat.com>
2576             Rajendra SY  <rajendra.sy@gmail.com>
2577
2578         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
2579         * remote.c (extended_remote_attach): In all-stop mode, mark the
2580         thread as executing.
2581
2582 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2583
2584         * thread.c (thread_apply_all_command): Fix comment.
2585         (thread_command): Fix comment.
2586
2587 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
2588
2589         * common/tdesc.h (tdesc_create_feature): Remove xml filename
2590         parameter.
2591         * features/aarch64-core.c (create_feature_aarch64_core):
2592         Regenerate.
2593         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
2594         Likewise.
2595         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
2596         Likewise.
2597         * features/i386/32bit-avx512.c
2598         (create_feature_i386_32bit_avx512): Likewise.
2599         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
2600         Likewise.
2601         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
2602         Likewise.
2603         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
2604         Likewise.
2605         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
2606         Likewise.
2607         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
2608         Likewise.
2609         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
2610         Likewise.
2611         * features/i386/64bit-avx512.c
2612         (create_feature_i386_64bit_avx512): Likewise.
2613         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
2614         Likewise.
2615         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
2616         Likewise.
2617         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
2618         Likewise.
2619         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
2620         Likewise.
2621         * features/i386/64bit-segments.c
2622         (create_feature_i386_64bit_segments): Likewise.
2623         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
2624         Likewise.
2625         * features/i386/x32-core.c
2626         (create_feature_i386_x32_core): Likewise.
2627         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
2628         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
2629         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
2630         * target-descriptions.c: In generated code, don't pass xml
2631         filename.
2632
2633 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2634
2635         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
2636         (print_xml_feature::visit_post): Likewise.
2637         (print_xml_feature::visit): Likewise.
2638         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
2639         (print_xml_feature): Add new class.
2640         * regformats/regdat.sh: Null xmltarget on feature targets.
2641         * target-descriptions.c (struct target_desc): Add xmltarget.
2642         (maintenance_check_tdesc_xml_convert): Add unittest function.
2643         (tdesc_get_features_xml): Add function to get xml.
2644         (maintenance_check_xml_descriptions): Test xml generation.
2645         * xml-tdesc.c (string_read_description_xml): Add function.
2646         * xml-tdesc.h (string_read_description_xml): Add declaration.
2647
2648 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2649
2650         * features/Makefile: Add feature marker to targets with new style
2651         target descriptions.
2652         * regformats/aarch64.dat: Regenerate.
2653         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
2654         * regformats/i386/amd64-avx-linux.dat: Likewise.
2655         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
2656         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
2657         * regformats/i386/amd64-linux.dat: Likewise.
2658         * regformats/i386/amd64-mpx-linux.dat: Likewise.
2659         * regformats/i386/amd64.dat: Likewise.
2660         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
2661         * regformats/i386/i386-avx-linux.dat: Likewise.
2662         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
2663         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
2664         * regformats/i386/i386-linux.dat: Likewise.
2665         * regformats/i386/i386-mmx-linux.dat: Likewise.
2666         * regformats/i386/i386-mpx-linux.dat: Likewise.
2667         * regformats/i386/i386.dat: Likewise.
2668         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
2669         * regformats/i386/x32-avx-linux.dat: Likewise.
2670         * regformats/i386/x32-linux.dat: Likewise.
2671         * regformats/tic6x-c62x-linux.dat: Likewise.
2672         * regformats/tic6x-c64x-linux.dat: Likewise.
2673         * regformats/tic6x-c64xp-linux.dat: Likewise.
2674         * regformats/regdat.sh: Parse feature marker.
2675
2676 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2677
2678         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
2679         (tdesc_osabi_name): Likewise.
2680         * target-descriptions.c (tdesc_architecture_name): Add new
2681         function.
2682         (tdesc_osabi_name): Likewise.
2683
2684 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2685
2686         * common/tdesc.c (tdesc_predefined_type): Move to here.
2687         (tdesc_named_type): Likewise.
2688         (tdesc_create_vector): Likewise.
2689         (tdesc_create_struct): Likewise.
2690         (tdesc_set_struct_size): Likewise.
2691         (tdesc_create_union): Likewise.
2692         (tdesc_create_flags): Likewise.
2693         (tdesc_create_enum): Likewise.
2694         (tdesc_add_field): Likewise.
2695         (tdesc_add_typed_bitfield): Likewise.
2696         (tdesc_add_bitfield): Likewise.
2697         (tdesc_add_flag): Likewise.
2698         (tdesc_add_enum_value): Likewise.
2699         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
2700         (struct tdesc_type_vector): Likewise.
2701         (struct tdesc_type_field): Likewise.
2702         (struct tdesc_type_with_fields): Likewise.
2703         (tdesc_create_enum): Add declaration.
2704         (tdesc_add_typed_bitfield): Likewise.
2705         (tdesc_add_enum_value): Likewise.
2706         * target-descriptions.c (tdesc_type_field): Move from here.
2707         (tdesc_type_builtin): Likewise.
2708         (tdesc_type_vector): Likewise.
2709         (tdesc_type_with_fields): Likewise.
2710         (tdesc_predefined_types): Likewise.
2711         (tdesc_named_type): Likewise.
2712         (tdesc_create_vector): Likewise.
2713         (tdesc_create_struct): Likewise.
2714         (tdesc_set_struct_size): Likewise.
2715         (tdesc_create_union): Likewise.
2716         (tdesc_create_flags): Likewise.
2717         (tdesc_create_enum): Likewise.
2718         (tdesc_add_field): Likewise.
2719         (tdesc_add_typed_bitfield): Likewise.
2720         (tdesc_add_bitfield): Likewise.
2721         (tdesc_add_flag): Likewise.
2722         (tdesc_add_enum_value): Likewise.
2723         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
2724         (tdesc_add_typed_bitfield): Likewise.
2725         (tdesc_add_enum_value): Likewise.
2726
2727 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2728
2729         * common/tdesc.c (tdesc_feature::accept): Move to here.
2730         (tdesc_feature::operator==): Likewise.
2731         (tdesc_create_reg): Likewise.
2732         * common/tdesc.h (tdesc_type_kind): Likewise.
2733         (struct tdesc_type): Likewise.
2734         (struct tdesc_feature): Likewise.
2735         * regformats/regdat.sh: Create a feature.
2736         * target-descriptions.c (tdesc_type_kind): Move from here.
2737         (tdesc_type): Likewise.
2738         (tdesc_type_up): Likewise.
2739         (tdesc_feature): Likewise.
2740         (tdesc_create_reg): Likewise.
2741
2742 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
2743
2744         * Makefile.in: Add arch/tdesc.c
2745         * common/tdesc.c: New file.
2746         * common/tdesc.h (tdesc_element_visitor): Move to here.
2747         (tdesc_element): Likewise.
2748         (tdesc_reg): Likewise.
2749         (tdesc_reg_up): Likewise.
2750         * regformats/regdef.h (reg): Add offset to constructors.
2751         * target-descriptions.c (tdesc_element_visitor): Move from here.
2752         (tdesc_element): Likewise.
2753         (tdesc_reg): Likewise.
2754         (tdesc_reg_up): Likewise.
2755
2756 2018-04-17  Tom Tromey  <tom@tromey.com>
2757
2758         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
2759         discriminant field.
2760
2761 2018-04-17  Tom Tromey  <tom@tromey.com>
2762
2763         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
2764
2765 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
2766
2767         * symtab.c (print_symbol_info): Skip printing filename and line
2768         number when `last' is NULL.
2769         (symtab_symbol_info): Use empty string instead of NULL for first
2770         invocation of print_symbol_info.
2771         (rbreak_command): Pass NULL to `last' parameter of
2772         print_symbol_info.
2773
2774 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
2775
2776         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
2777         instead of nullptr.
2778
2779 2018-04-16  Pedro Alves  <palves@redhat.com>
2780
2781         * MAINTAINERS (sh): Remove.
2782         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
2783         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
2784         (ALLDEPFILES): Remove sh64-tdep.c.
2785         * NEWS: Mentions that support for SH-5/SH64 is removed.
2786         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
2787         (sh*-*-openbsd*): Ditto.
2788         (sh64-*-elf*): Remove.
2789         (sh*): Remove.
2790         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
2791         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
2792         * sh-tdep.c: No longer include "sh64-tdep.h".
2793         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
2794         * sh64-tdep.c, sh64-tdep.h: Remove files.
2795
2796 2018-04-16  Pedro Alves  <palves@redhat.com>
2797
2798         * MAINTAINERS: Remove m88k.
2799         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
2800         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
2801         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
2802         * NEWS: Mention that support for m88k was removed.
2803         * configure.host (m88*-*-*): Remove support.
2804         * configure.nat (m88k-*-*): Remove support.
2805         * configure.tgt (m88*-*-openbsd*): Remove.
2806         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
2807
2808 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
2809
2810         * configure.tgt (x86_tobjs): New variable.
2811         (amd64_tobjs, i386_tobjs): Use it.
2812
2813 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
2814
2815         * symtab.c (print_symbol_info): Precede the symbol definition by
2816         the line number when available.
2817         * NEWS: Advertise this enhancement.
2818
2819 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
2820
2821         * NEWS (New options): announce set/show record btrace cpu.
2822         * btrace.c: Include record-btrace.h.
2823         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
2824         the vendor is unknown.
2825         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
2826         Maybe overwrite the btrace configuration's cpu.
2827         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
2828         (btrace_fetch): Add cpu parameter.  Update callers.
2829         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
2830         Maybe overwrite the btrace configuration's cpu.  Skip enabling
2831         errata workarounds if the vendor is unknown.
2832         * python/py-record-btrace.c: Include record-btrace.h.
2833         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
2834         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
2835         * record-btrace.c (record_btrace_cpu_state_kind): New.
2836         (record_btrace_cpu): New.
2837         (set_record_btrace_cpu_cmdlist): New.
2838         (record_btrace_get_cpu): New.
2839         (require_btrace_thread, record_btrace_info)
2840         (record_btrace_resume_thread): Call record_btrace_get_cpu.
2841         (cmd_set_record_btrace_cpu_none): New.
2842         (cmd_set_record_btrace_cpu_auto): New.
2843         (cmd_set_record_btrace_cpu): New.
2844         (cmd_show_record_btrace_cpu): New.
2845         (_initialize_record_btrace): Initialize set/show record btrace cpu
2846         commands.
2847         * record-btrace.h (record_btrace_get_cpu): New.
2848
2849 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
2850
2851         * record.c (set_record_command): Fix typo in message.
2852
2853 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
2854
2855         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
2856
2857 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
2858
2859         * infrun.c (process_event_stop_test): Call
2860         gdbarch_in_indirect_branch_thunk.
2861         * gdbarch.sh (in_indirect_branch_thunk): New.
2862         * gdbarch.c: Regenerated.
2863         * gdbarch.h: Regenerated.
2864         * x86-tdep.h: New.
2865         * x86-tdep.c: New.
2866         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
2867         (HFILES_NO_SRCDIR): Add x86-tdep.h.
2868         (ALLDEPFILES): Add x86-tdep.c.
2869         * arch-utils.h (default_in_indirect_branch_thunk): New.
2870         * arch-utils.c (default_in_indirect_branch_thunk): New.
2871         * i386-tdep: Include x86-tdep.h.
2872         (i386_in_indirect_branch_thunk): New.
2873         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
2874         function.
2875         * amd64-tdep: Include x86-tdep.h.
2876         (amd64_in_indirect_branch_thunk): New.
2877         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
2878
2879 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
2880
2881         PR gdb/23053
2882         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
2883         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
2884         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
2885         regression.
2886
2887 2018-04-12  Tom Tromey  <tom@tromey.com>
2888
2889         * rust-lang.c (rust_print_struct_def): Remove univariant code.
2890         (rust_evaluate_subexp): Likewise.
2891
2892 2018-04-12  Pedro Alves  <palves@redhat.com>
2893
2894         * procfs.c (procfs_detach): Make forward declaration's prototype
2895         match definition's protototype.
2896         (proc_get_LDT_entry): Remove stale do_cleanups call.
2897
2898 2018-04-12  Pedro Alves  <palves@redhat.com>
2899
2900         * target.h (target_ops::to_has_exited): Delete.
2901         (target_has_exited): Delete.
2902         * target-delegates.c: Regenerate.
2903
2904 2018-04-11  Pedro Alves  <palves@redhat.com>
2905
2906         * target.c (fileio_fh_t::t): Add comment.
2907         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
2908         (target_fileio_close): Handle a NULL target.
2909         (invalidate_fileio_fh): New.
2910         (target_close): Call it.
2911         * remote.c (remote_hostio_send_command): No longer check whether
2912         remote_desc is open.
2913
2914 2018-04-11  Pedro Alves  <palves@redhat.com>
2915
2916         * target.c (fileio_fh_t): Make it a named struct instead of a
2917         typedef.
2918         (fileio_fh_t::is_closed): New method.
2919         (DEF_VEC_O (fileio_fh_t)): Remove.
2920         (fileio_fhandles): Now a std::vector.
2921         (is_closed_fileio_fh): Delete.
2922         (acquire_fileio_fd): Adjust.  Rename parameters.
2923         (release_fileio_fd): Adjust.
2924         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
2925         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
2926         (target_fileio_close): Adjust.
2927
2928 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
2929
2930         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
2931         index.
2932
2933 2018-04-10  Pedro Alves  <palves@redhat.com>
2934
2935         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
2936         (scoped_finish_thread_state): New class.
2937         * infcmd.c (run_command_1): Use it instead of finish_thread_state
2938         cleanup.
2939         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
2940         (fetch_inferior_event, normal_stop): Likewise.
2941         * thread.c (finish_thread_state_cleanup): Delete.
2942
2943 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2944             Pedro Alves  <palves@redhat.com>
2945
2946         * value.c: Include "selftest.h" and "common/array-view.h".
2947         (struct range) <operator ==>: New.
2948         (test_ranges_contain): New.
2949         (check_ranges_vector): New.
2950         (test_insert_into_bit_range_vector): New.
2951         (_initialize_values): Register selftests.
2952         * common/array-view.h (operator==, operator!=): New.
2953
2954 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2955
2956         * common/gdb_vecs.h (unordered_remove): Add overload that takes
2957         an iterator.
2958         * inline-frame.c: Include <algorithm>.
2959         (struct inline_state): Add constructor.
2960         (inline_state_s): Remove.
2961         (DEF_VEC_O(inline_state_s)): Remove.
2962         (inline_states): Change type to std::vector.
2963         (find_inline_frame_state): Adjust to std::vector.
2964         (allocate_inline_frame_state): Remove.
2965         (clear_inline_frame_state): Adjust to std::vector.
2966         (skip_inline_frames): Adjust to std::vector.
2967
2968 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
2969
2970         * tracepoint.h (struct trace_state_variable): Add constructor.
2971         <name>: Change type to std::string.
2972         * tracepoint.c (tsv_s): Remove.
2973         (DEF_VEC_O(tsv_s)): Remove.
2974         (tvariables): Change to std::vector.
2975         (create_trace_state_variable): Adjust to std::vector.
2976         (find_trace_state_variable): Likewise.
2977         (find_trace_state_variable_by_number): Likewise.
2978         (delete_trace_state_variable): Likewise.
2979         (trace_variable_command): Adjust to std::string.
2980         (delete_trace_variable_command): Likewise.
2981         (tvariables_info_1): Adjust to std::vector.
2982         (save_trace_state_variables): Likewise.
2983         (start_tracing): Likewise.
2984         (merge_uploaded_trace_state_variables): Adjust to std::vector
2985         and std::string.
2986         * target.h (struct target_ops)
2987         <to_download_trace_state_variable>: Pass reference to
2988         trace_state_variable.
2989         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
2990         * target-delegates.c: Re-generate.
2991         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
2992         (mi_tsv_deleted): Likewise.
2993         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
2994         * remote.c (remote_download_trace_state_variable): Change
2995         pointer to reference and adjust.
2996         * make-target-delegates (parse_argtypes): Handle references.
2997         (write_function_header): Likewise.
2998         (munge_type): Likewise.
2999
3000 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3001
3002         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3003         string_view-selftests.c.
3004         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
3005         testsuite.
3006         * unittests/basic_string_view/cons/char/1.cc: Likewise.
3007         * unittests/basic_string_view/cons/char/2.cc: Likewise.
3008         * unittests/basic_string_view/cons/char/3.cc: Likewise.
3009         * unittests/basic_string_view/element_access/char/1.cc:
3010         Likewise.
3011         * unittests/basic_string_view/element_access/char/empty.cc:
3012         Likewise.
3013         * unittests/basic_string_view/element_access/char/front_back.cc:
3014         Likewise.
3015         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
3016         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
3017         Likewise.
3018         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
3019         Likewise.
3020         * unittests/basic_string_view/modifiers/swap/char/1.cc:
3021         Likewise.
3022         * unittests/basic_string_view/operations/compare/char/1.cc:
3023         Likewise.
3024         * unittests/basic_string_view/operations/compare/char/13650.cc:
3025         Likewise.
3026         * unittests/basic_string_view/operations/copy/char/1.cc:
3027         Likewise.
3028         * unittests/basic_string_view/operations/data/char/1.cc:
3029         Likewise.
3030         * unittests/basic_string_view/operations/find/char/1.cc:
3031         Likewise.
3032         * unittests/basic_string_view/operations/find/char/2.cc:
3033         Likewise.
3034         * unittests/basic_string_view/operations/find/char/3.cc:
3035         Likewise.
3036         * unittests/basic_string_view/operations/find/char/4.cc:
3037         Likewise.
3038         * unittests/basic_string_view/operations/rfind/char/1.cc:
3039         Likewise.
3040         * unittests/basic_string_view/operations/rfind/char/2.cc:
3041         Likewise.
3042         * unittests/basic_string_view/operations/rfind/char/3.cc:
3043         Likewise.
3044         * unittests/basic_string_view/operations/substr/char/1.cc:
3045         Likewise.
3046         * unittests/basic_string_view/operators/char/2.cc: Likewise.
3047         * unittests/string_view-selftests.c: New file.
3048
3049 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3050
3051         * unittests/basic_string_view/capacity/1.cc: New file.
3052         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
3053         * unittests/basic_string_view/cons/char/1.cc: New file.
3054         * unittests/basic_string_view/cons/char/2.cc: New file.
3055         * unittests/basic_string_view/cons/char/3.cc: New file.
3056         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
3057         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
3058         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
3059         * unittests/basic_string_view/element_access/char/1.cc: New file.
3060         * unittests/basic_string_view/element_access/char/2.cc: New file.
3061         * unittests/basic_string_view/element_access/char/empty.cc: New file.
3062         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
3063         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
3064         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
3065         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
3066         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
3067         * unittests/basic_string_view/include.cc: New file.
3068         * unittests/basic_string_view/inserters/char/1.cc: New file.
3069         * unittests/basic_string_view/inserters/char/2.cc: New file.
3070         * unittests/basic_string_view/inserters/char/3.cc: New file.
3071         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
3072         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
3073         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
3074         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
3075         * unittests/basic_string_view/literals/types.cc: New file.
3076         * unittests/basic_string_view/literals/values.cc: New file.
3077         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
3078         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
3079         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
3080         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
3081         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
3082         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
3083         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
3084         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
3085         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
3086         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
3087         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
3088         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
3089         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
3090         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
3091         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
3092         * unittests/basic_string_view/operations/data/char/1.cc: New file.
3093         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
3094         * unittests/basic_string_view/operations/find/char/1.cc: New file.
3095         * unittests/basic_string_view/operations/find/char/2.cc: New file.
3096         * unittests/basic_string_view/operations/find/char/3.cc: New file.
3097         * unittests/basic_string_view/operations/find/char/4.cc: New file.
3098         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
3099         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
3100         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
3101         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
3102         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
3103         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
3104         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
3105         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
3106         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
3107         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
3108         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
3109         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
3110         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
3111         * unittests/basic_string_view/operators/char/2.cc: New file.
3112         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
3113         * unittests/basic_string_view/range_access/char/1.cc: New file.
3114         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
3115         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
3116         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
3117         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
3118         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
3119         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
3120         * unittests/basic_string_view/requirements/typedefs.cc: New file.
3121         * unittests/basic_string_view/typedefs.cc: New file.
3122         * unittests/basic_string_view/types/1.cc: New file.
3123
3124 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3125
3126         * common/gdb_string_view.h: Remove libstdc++ implementation
3127         details, adjust to gdb reality.
3128         * common/gdb_string_view.tcc: Likewise.
3129         * cli/cli-script.c (struct string_view): Remove.
3130         (user_args) <m_args>: Change element type to gdb::string_view.
3131         (user_args::insert_args): Adjust.
3132
3133 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3134
3135         * common/gdb_string_view.h: New file.
3136         * common/gdb_string_view.tcc: New file.
3137
3138 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3139
3140         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
3141         * configure: Re-generate.
3142
3143 2018-04-09  Pedro Alves  <palves@redhat.com>
3144
3145         * gdbarch.sh: Include "observable.h" instead of "observer.h".
3146         (set_target_gdbarch): Call
3147         gdb::observers::architecture_changed.notify instead of
3148         observer_notify_architecture_changed.
3149
3150 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3151
3152         * tracepoint.c (struct current_traceframe_cleanup): Remove.
3153         (do_restore_current_traceframe_cleanup): Remove.
3154         (restore_current_traceframe_cleanup_dtor): Remove.
3155         (make_cleanup_restore_current_traceframe): Remove.
3156         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
3157         New.
3158         * tracepoint.h (struct scoped_restore_current_traceframe): New.
3159         * infrun.c (fetch_inferior_event): Use
3160         scoped_restore_current_traceframe.
3161
3162 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3163
3164         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
3165         Remove.
3166         <n_allocated_type_units>: Remove.
3167         <all_type_units>: Change to std::vector.
3168         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3169         to std::vector change.
3170         (dwarf2_per_objfile::get_cutu): Likewise.
3171         (dwarf2_per_objfile::get_tu): Likewise.
3172         (create_signatured_type_table_from_index): Likewise.
3173         (create_signatured_type_table_from_debug_names): Likewise.
3174         (dw2_symtab_iter_next): Likewise.
3175         (dw2_print_stats): Likewise.
3176         (dw2_expand_all_symtabs): Likewise.
3177         (dw2_expand_marked_cus): Likewise.
3178         (dw2_debug_names_iterator::next): Likewise.
3179         (dwarf2_initialize_objfile): Likewise.
3180         (add_signatured_type_cu_to_table): Likewise.
3181         (create_all_type_units): Likewise.
3182         (add_type_unit): Likewise.
3183         (struct tu_abbrev_offset): Add constructor.
3184         (build_type_psymtabs_1): Adjust to std::vector change.
3185         (print_tu_stats): Likewise.
3186         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3187         (write_debug_names): Likewise.
3188
3189 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3190
3191         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
3192         Make an std::vector.
3193         <n_comp_units>: Remove.
3194         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3195         to std::vector change.
3196         (dwarf2_per_objfile::get_cutu): Likewise.
3197         (dwarf2_per_objfile::get_cu): Likewise.
3198         (create_cus_from_index): Likewise.
3199         (create_addrmap_from_index): Likewise.
3200         (create_addrmap_from_aranges): Likewise.
3201         (dwarf2_read_index): Likewise.
3202         (dw2_find_last_source_symtab): Likewise.
3203         (dw2_map_symtabs_matching_filename): Likewise.
3204         (dw2_symtab_iter_next): Likewise.
3205         (dw2_print_stats): Likewise.
3206         (dw2_expand_all_symtabs): Likewise.
3207         (dw2_expand_symtabs_with_fullname): Likewise.
3208         (dw2_expand_marked_cus): Likewise.
3209         (dw2_map_symbol_filenames): Likewise.
3210         (create_cus_from_debug_names): Likewise.
3211         (dwarf2_read_debug_names): Likewise.
3212         (dw2_debug_names_iterator::next): Likewise.
3213         (dwarf2_initialize_objfile): Likewise.
3214         (set_partial_user): Likewise.
3215         (dwarf2_build_psymtabs_hard): Likewise.
3216         (read_comp_units_from_section): Remove arguments, adjust to
3217         std::vector change.
3218         (create_all_comp_units): Adjust to std::vector and
3219         read_comp_units_from_section changes.
3220         (dwarf2_find_containing_comp_unit): Adjust to std::vector
3221         change.
3222         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3223         (psyms_seen_size): Likewise.
3224         (write_gdbindex): Likewise.
3225         (write_debug_names): Likewise.
3226
3227 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3228
3229         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
3230         with dwarf2_per_objfile.
3231         (create_cus_from_index): Likewise.
3232         (create_signatured_type_table_from_index): Likewise.
3233         (dwarf2_read_index): Likewise.
3234         (dwarf2_initialize_objfile): Likewise.
3235         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
3236         per_cu rather than get_dwarf2_per_objfile.
3237
3238 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3239
3240         * dwarf2read.h (struct signatured_type): Forward declare.
3241         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
3242         New methods.
3243         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
3244         (dw2_get_cutu): ...this.
3245         (dwarf2_per_objfile::get_cu): Rename from...
3246         (dw2_get_cu): ...this.
3247         (dwarf2_per_objfile::get_tu): New.
3248         (create_addrmap_from_index): Adjust.
3249         (create_addrmap_from_aranges): Adjust.
3250         (dw2_find_last_source_symtab): Adjust.
3251         (dw2_map_symtabs_matching_filename): Adjust.
3252         (dw2_symtab_iter_next): Adjust.
3253         (dw2_print_stats): Adjust.
3254         (dw2_expand_all_symtabs): Adjust.
3255         (dw2_expand_symtabs_with_fullname): Adjust.
3256         (dw2_expand_marked_cus): Adjust.
3257         (dw_expand_symtabs_matching_file_matcher): Adjust.
3258         (dw2_map_symbol_filenames): Adjust.
3259         (dw2_debug_names_iterator::next): Adjust.
3260         (dwarf2_initialize_objfile): Adjust.
3261         (set_partial_user): Adjust.
3262         (dwarf2_build_psymtabs_hard): Adjust.
3263
3264 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3265
3266         * dwarf2read.c (create_signatured_type_table_from_debug_names):
3267         Remove unused variables.
3268         (dw2_map_symtabs_matching_filename): Likewise.
3269         (dwarf2_record_block_ranges): Likewise.
3270         (dwarf2_read_addr_index): Likewise.
3271         (follow_die_offset): Likewise.
3272
3273 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3274
3275         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
3276         to symbol_file_add_main.
3277
3278 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3279
3280         PR mi/22299
3281         * mi/mi-console.c (do_fputc_async_safe): New.
3282         (mi_console_file::write_async_safe): New.
3283         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
3284         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
3285         New.
3286         * ui-file.c (ui_file::putstrn): Adjust call to
3287         fputstrn_unfiltered.
3288         * utils.c (printchar): Replace do_fputs and do_fprintf
3289         parameters by do_fputc.
3290         (fputstr_filtered): Adjust call to printchar.
3291         (fputstr_unfiltered): Likewise.
3292         (fputstrn_filtered): Likewise.
3293         (fputstrn_unfiltered): Add do_fputc parameter, pass to
3294         printchar.
3295         * utils.h (do_fputc_ftype): New typedef.
3296         (fputstrn_unfiltered): Add do_fputc parameter.
3297
3298 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3299
3300         * regformats/i386/i386-avx.dat: Remove.
3301
3302 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3303
3304         PR gdb/22979
3305         * amd64-tdep.c (amd64_none_init_abi): New function.
3306         (amd64_x32_none_init_abi): New function.
3307         (_initialize_amd64_tdep): Register handlers for x86-64 and
3308         x64_32 with GDB_OSABI_NONE.
3309         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
3310         GDB_OSABI_NONE osabi.
3311
3312 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3313
3314         PR gdb/22980
3315         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
3316         GDB_OSABI_NONE.
3317         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
3318         * osabi.c (gdb_osabi_names): Add "unknown" entry.
3319
3320 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3321
3322         * common/byte-vector.h (char_vector): New type.
3323         * target.h (target_read_alloc): Return
3324         gdb::optional<byte_vector>.
3325         (target_read_stralloc): Return gdb::optional<char_vector>.
3326         (target_get_osdata): Return gdb::optional<char_vector>.
3327         * target.c (target_read_alloc_1): Templatize.  Replacement
3328         manual memory management with vector.
3329         (target_read_alloc): Change return type, adjust.
3330         (target_read_stralloc): Change return type, adjust.
3331         (target_get_osdata): Change return type, adjust.
3332         * auxv.c (struct auxv_info) <length>: Remove.
3333         <data>: Change type to gdb::optional<byte_vector>.
3334         (auxv_inferior_data_cleanup): Free auxv_info with delete.
3335         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
3336         (target_auxv_search): Adjust.
3337         (fprint_target_auxv): Adjust.
3338         * avr-tdep.c (avr_io_reg_read_command): Adjust.
3339         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
3340         (linux_make_corefile_notes): Adjust.
3341         * osdata.c (get_osdata): Adjust.
3342         * remote.c (remote_get_threads_with_qxfer): Adjust.
3343         (remote_memory_map): Adjust.
3344         (remote_traceframe_info): Adjust.
3345         (btrace_read_config): Adjust.
3346         (remote_read_btrace): Adjust.
3347         (remote_pid_to_exec_file): Adjust.
3348         * solib-aix.c (solib_aix_get_library_list): Adjust.
3349         * solib-dsbt.c (decode_loadmap): Don't free buf.
3350         (dsbt_get_initial_loadmaps): Adjust.
3351         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
3352         * solib-target.c (solib_target_current_sos): Adjust.
3353         * tracepoint.c (sdata_make_value): Adjust.
3354         * xml-support.c (xinclude_start_include): Adjust.
3355         (xml_fetch_content_from_file): Adjust.
3356         * xml-support.h (xml_fetch_another): Change return type.
3357         (xml_fetch_content_from_file): Change return type.
3358         * xml-syscall.c (xml_init_syscalls_info): Adjust.
3359         * xml-tdesc.c (file_read_description_xml): Adjust.
3360         (fetch_available_features_from_target): Change return type.
3361         (target_fetch_description_xml): Adjust.
3362         (target_read_description_xml): Adjust.
3363
3364 2018-04-06  Tom Tromey  <tom@tromey.com>
3365
3366         * value.c (~value): Update.
3367         (struct value) <contents>: Now unique_xmalloc_ptr.
3368         (value_contents_bits_eq, allocate_value_contents)
3369         (value_contents_raw, value_contents_all_raw)
3370         (value_contents_for_printing, value_contents_for_printing_const)
3371         (set_value_enclosing_type): Update.
3372
3373 2018-04-06  Tom Tromey  <tom@tromey.com>
3374
3375         * value.c (range_s): Remove typedef, VEC.
3376         (struct range): Add operator<.
3377         (range_lessthan): Remove.
3378         (ranges_contain): Change type.
3379         (~value): Update.
3380         (struct value) <unavailable, optimized_out>: Now std::vector.
3381         (value_entirely_available)
3382         (value_entirely_covered_by_range_vector)
3383         (value_entirely_unavailable, value_entirely_optimized_out):
3384         Update.
3385         (insert_into_bit_range_vector): Change argument type.
3386         (find_first_range_overlap): Likewise.
3387         (struct ranges_and_idx, value_contents_bits_eq)
3388         (require_not_optimized_out, require_available): Update.
3389         (ranges_copy_adjusted): Change argument types.
3390         (value_optimized_out, value_copy, value_fetch_lazy): Update.
3391
3392 2018-04-06  Tom Tromey  <tom@tromey.com>
3393
3394         * value.c (~value): Update.
3395         (struct value) <parent>: Now a value_ref_ptr.
3396         (value_parent, set_value_parent, value_address, value_copy):
3397         Update.
3398
3399 2018-04-06  Tom Tromey  <tom@tromey.com>
3400
3401         * value.c (struct value): Add constructor, destructor, and member
3402         initializers.
3403         (allocate_value_lazy, value_decref): Update.
3404
3405 2018-04-06  Tom Tromey  <tom@tromey.com>
3406
3407         * value.c (struct value) <released, next>: Remove.
3408         (all_values): Now a std::vector.
3409         (allocate_value_lazy): Update.
3410         (value_next): Remove.
3411         (value_mark, value_free_to_mark, release_value)
3412         (value_release_to_mark): Update.
3413
3414 2018-04-06  Tom Tromey  <tom@tromey.com>
3415
3416         * value.h (fetch_subexp_value, value_release_to_mark): Update.
3417         (free_value_chain): Remove.
3418         * value.c (free_value_chain): Remove.
3419         (value_release_to_mark): Return a std::vector.
3420         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
3421         std::vector.
3422         (check_condition): Update.
3423         * eval.c (fetch_subexp_value): Change "val_chain" to a
3424         std::vector.
3425         * breakpoint.c (update_watchpoint): Update.
3426         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
3427
3428 2018-04-06  Tom Tromey  <tom@tromey.com>
3429
3430         * value.h (free_all_values): Remove.
3431         * value.c (free_all_values): Remove.
3432
3433 2018-04-06  Tom Tromey  <tom@tromey.com>
3434
3435         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
3436         (value_history_chain, value_history_count): Remove.
3437         (value_history): New global.
3438         (record_latest_value, access_value_history, show_values)
3439         (preserve_values): Update.
3440
3441 2018-04-06  Tom Tromey  <tom@tromey.com>
3442
3443         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
3444         * varobj.c (varobj_set_display_format, varobj_set_value)
3445         (install_default_visualizer, construct_visualizer)
3446         (install_new_value, ~varobj, varobj_get_value_type)
3447         (my_value_of_variable, varobj_editable_p): Update.
3448         * c-varobj.c (c_describe_child, c_value_of_variable)
3449         (cplus_number_of_children, cplus_describe_child): Update.
3450         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
3451         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
3452         (ada_value_of_variable, ada_value_is_changeable_p): Update.
3453
3454 2018-04-06  Tom Tromey  <tom@tromey.com>
3455
3456         * printcmd.c (last_examine_address): Change type to
3457         value_ref_ptr.
3458         (do_examine, x_command): Update.
3459
3460 2018-04-06  Tom Tromey  <tom@tromey.com>
3461
3462         * value.c (release_value): Update.
3463         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
3464         (struct bpstats) <val>: Now a value_ref_ptr.
3465         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
3466         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
3467         (~watchpoint, print_it_watchpoint, watch_command_1)
3468         (invalidate_bp_value_on_memory_change): Update.
3469
3470 2018-04-06  Tom Tromey  <tom@tromey.com>
3471
3472         * varobj.c (varobj_clear_saved_item)
3473         (update_dynamic_varobj_children, install_new_value, ~varobj):
3474         Update.
3475         * value.h (value_incref): Move declaration earlier.
3476         (value_decref): Rename from value_free.
3477         (struct value_ref_policy): New.
3478         (value_ref_ptr): New typedef.
3479         (struct value_deleter): Remove.
3480         (gdb_value_up): Remove typedef.
3481         (release_value): Change return type.
3482         (release_value_or_incref): Remove.
3483         * value.c (set_value_parent): Update.
3484         (value_incref): Change return type.
3485         (value_decref): Rename from value_free.
3486         (value_free_to_mark, free_all_values, free_value_chain): Update.
3487         (release_value): Return value_ref_ptr.
3488         (release_value_or_incref): Remove.
3489         (record_latest_value, set_internalvar, clear_internalvar):
3490         Update.
3491         * stack.c (info_frame_command): Don't call value_free.
3492         * python/py-value.c (valpy_dealloc, valpy_new)
3493         (value_to_value_object): Update.
3494         * printcmd.c (do_examine): Update.
3495         * opencl-lang.c (lval_func_free_closure): Update.
3496         * mi/mi-main.c (register_changed_p): Don't call value_free.
3497         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
3498         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
3499         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
3500         value_free.
3501         * guile/scm-value.c (vlscm_free_value_smob)
3502         (vlscm_scm_from_value): Update.
3503         * frame.c (frame_register_unwind, frame_unwind_register_signed)
3504         (frame_unwind_register_unsigned, get_frame_register_bytes)
3505         (put_frame_register_bytes): Don't call value_free.
3506         * findvar.c (address_from_register): Don't call value_free.
3507         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
3508         * dwarf2loc.c (entry_data_value_free_closure)
3509         (value_of_dwarf_reg_entry, free_pieced_value_closure)
3510         (dwarf2_evaluate_loc_desc_full): Update.
3511         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
3512         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
3513         (~watchpoint, watch_command_1)
3514         (invalidate_bp_value_on_memory_change): Update.
3515         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
3516
3517 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
3518
3519         PR gdb/23022
3520         * warning.m4: Add -Wno-error=deprecated-register.
3521         * configure: Re-generate.
3522
3523 2018-04-05  Tom Tromey  <tom@tromey.com>
3524
3525         * linespec.h: Remove include of "vec.h".
3526
3527 2018-04-05  Tom Tromey  <tom@tromey.com>
3528
3529         * linespec.c (typep): Remove typedef.
3530         (find_methods, find_superclass_methods): Take a std::vector.
3531         (find_method): Use std::vector.
3532
3533 2018-04-05  Tom Tromey  <tom@tromey.com>
3534
3535         * utils.c (compare_strings): Remove.
3536         * utils.h (compare_strings): Remove.
3537         * objc-lang.h (find_imps): Update.
3538         * objc-lang.c (find_methods): Take a std::vector.
3539         (uniquify_strings, find_imps): Likewise.
3540         * linespec.c (find_methods): Take a std::vector.
3541         (decode_objc): Use std::vector.
3542         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
3543         a std::vector.
3544         (find_method, find_function_symbols): Use std::vector.
3545
3546 2018-04-05  Tom Tromey  <tom@tromey.com>
3547
3548         * completer.c (completion_tracker::completion_tracker): Remove
3549         cast.
3550         (completion_tracker::discard_completions): Likewise.
3551         * breakpoint.c (ambiguous_names_p): Remove cast.
3552         * ada-lang.c (_initialize_ada_language): Remove cast.
3553         * utils.h (streq): Update.
3554         (streq_hash): Add new declaration.
3555         * utils.c (streq): Return bool.
3556         (streq_hash): New function.
3557
3558 2018-04-05  Tom Tromey  <tom@tromey.com>
3559
3560         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
3561         Remove a string copy.
3562
3563 2018-04-05  Tom Tromey  <tom@tromey.com>
3564
3565         * linespec.c (filter_results): Use std::vector.
3566         (decode_line_2, decode_line_full): Update.
3567
3568 2018-04-05  Tom Tromey  <tom@tromey.com>
3569
3570         * linespec.c (canonical_to_fullform): Return std::string.
3571         (filter_results): Update.
3572         (struct decode_line_2_item): Add constructor.
3573         <fullform, displayform>: Now std::string.
3574         (decode_line_2_compare_items): Now a std::sort comparator.
3575         (decode_line_2): Update.
3576
3577 2018-04-05  Tom Tromey  <tom@tromey.com>
3578
3579         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
3580         (unexpected_linespec_error): Update.
3581         (linespec_parse_basic, parse_linespec): Update.
3582
3583 2018-04-05  Tom Tromey  <tom@tromey.com>
3584
3585         * linespec.c (linespec_parse_basic): Reindent.
3586
3587 2018-04-05  Tom Tromey  <tom@tromey.com>
3588
3589         * minsyms.h (iterate_over_minimal_symbols): Update.
3590         * minsyms.c (iterate_over_minimal_symbols): Take a
3591         gdb::function_view.
3592         * linespec.c (struct collect_minsyms): Remove.
3593         (compare_msyms): Now a std::sort comparator.
3594         (add_minsym): Add parameters.
3595         (search_minsyms_for_name): Update.  Use std::vector.
3596
3597 2018-04-03  Tom Tromey  <tom@tromey.com>
3598
3599         * mipsread.c (read_alphacoff_dynamic_symtab): Use
3600         gdb::byte_vector.
3601
3602 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
3603
3604         * MAINTAINERS (Write After Approval): Add Weimin Pan.
3605
3606 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
3607
3608         PR gdb/16959
3609         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when 
3610         printing static type.
3611
3612 2018-04-01  Tom Tromey  <tom@tromey.com>
3613
3614         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
3615         (rs6000_xfer_shared_libraries): Update.
3616
3617 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
3618
3619         * common/gdb_vecs.h (char_ptr): Remove.
3620         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
3621
3622 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
3623
3624         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
3625         with std::vector.
3626         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
3627
3628 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
3629
3630         * tracepoint.h (struct uploaded_tp): Initialize fields.
3631         <actions, step_actions, cmd_strings>: Change type to
3632         std::vector<char *>.
3633         * tracepoint.c (get_uploaded_tp): Allocate with new.
3634         (free_uploaded_tps): Free with delete.
3635         (parse_tracepoint_definition): Adjust to std::vector change.
3636         * breakpoint.c (read_uploaded_action): Likewise.
3637         (create_tracepoint_from_upload): Likewise.
3638         * ctf.c (ctf_write_uploaded_tp): Likewise.
3639         (SET_ARRAY_FIELD): Likewise.
3640         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
3641
3642 2018-03-30  Tom Tromey  <tom@tromey.com>
3643
3644         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
3645         std::unique_ptr.
3646         (svr4_keep_data_in_core): Update.
3647         (svr4_read_so_list): Update.
3648
3649 2018-03-30  Tom Tromey  <tom@tromey.com>
3650
3651         * windows-nat.c (handle_output_debug_string, handle_exception):
3652         Update.
3653         * target.h (target_read_string): Update.
3654         * target.c (target_read_string): Change "string" to
3655         unique_xmalloc_ptr.
3656         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
3657         Update.
3658         * solib-frv.c (frv_current_sos): Update.
3659         * solib-dsbt.c (dsbt_current_sos): Update.
3660         * solib-darwin.c (darwin_current_sos): Update.
3661         * linux-thread-db.c (inferior_has_bug): Update.
3662         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
3663         Update.  Remove alloca.
3664         * ada-lang.c (ada_main_name): Update.
3665
3666 2018-03-30  Tom Tromey  <tom@tromey.com>
3667
3668         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
3669         (struct dwo_file_deleter): New.
3670         (dwo_file_up): New typedef.
3671         (open_and_init_dwo_file): Use dwo_file_up.
3672         (free_dwo_file_cleanup): Remove.
3673
3674 2018-03-30  Tom Tromey  <tom@tromey.com>
3675
3676         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
3677         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
3678
3679 2018-03-30  Tom Tromey  <tom@tromey.com>
3680
3681         * dwarf2read.c (class free_cached_comp_units): New class.
3682         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
3683         (free_cached_comp_units): Remove function.
3684
3685 2018-03-30  Tom Tromey  <tom@tromey.com>
3686
3687         * utils.h (make_cleanup_unpush_target): Remove.
3688         * inf-ptrace.c (struct target_unpusher): New.
3689         (target_unpush_up) New typedef.
3690         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
3691         target_unpush_up.
3692         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
3693
3694 2018-03-27  Tom Tromey  <tom@tromey.com>
3695
3696         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
3697
3698 2018-03-27  Pedro Alves  <palves@redhat.com>
3699             Tom Tromey  <tom@tromey.com>
3700
3701         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
3702         destructor.  Now a class.
3703         (gdb_readline_wrapper_cleanup): Remove function.
3704         (gdb_readline_wrapper): Remove cleanups.
3705
3706 2018-03-27  Tom Tromey  <tom@tromey.com>
3707
3708         * typeprint.h (struct type_print_options) <local_typedefs,
3709         global_typedefs>: Remove "struct" keyword.
3710         (class typedef_hash_table): New class.
3711         (recursively_update_typedef_hash, add_template_parameters)
3712         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
3713         (find_typedef_in_hash): Don't declare.
3714         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
3715         (typedef_hash_table::recursively_update): Rename from
3716         recursively_update_typedef_hash.  Now a member.
3717         (typedef_hash_table::add_template_parameters): Rename from
3718         add_template_parameters.  Now a member.
3719         (typedef_hash_table::typedef_hash_table): Now a constructor;
3720         rename from create_typedef_hash.
3721         (typedef_hash_table::~typedef_hash_table): Now a destructor;
3722         rename from free_typedef_hash.
3723         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
3724         (do_free_global_table): Remove.
3725         (typedef_hash_table::typedef_hash_table): New constructor; renamed
3726         from copy_type_recursive.
3727         (create_global_typedef_table): Remove.
3728         (typedef_hash_table::find_global_typedef): Now a member of
3729         typedef_hash_table.
3730         (typedef_hash_table::find_typedef): Rename from
3731         find_typedef_in_hash; now a member.
3732         (whatis_exp): Update.
3733         * extension.h (struct ext_lang_type_printers): Add constructor and
3734         destructor.
3735         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
3736         declare.
3737         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
3738         Now a constructor; rename from start_ext_lang_type_printers.
3739         (ext_lang_type_printers): Now a destructor; rename from
3740         free_ext_lang_type_printers.
3741         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
3742         Update.
3743         (c_type_print_base_struct_union): Update.  Remove cleanups.
3744
3745 2018-03-27  Tom Tromey  <tom@tromey.com>
3746
3747         * dwarf-index-write.c: Include <cmath>.
3748
3749 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
3750
3751         * NEWS: Add entry describing new "set|show varsize-limit" command.
3752         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
3753         command.
3754         * printcmd.c (_initialize_printcmd): Add "set var" alias of
3755         "set variable".
3756
3757 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
3758
3759         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
3760         dwarf-index-write.c
3761         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
3762         * dwarf-index-common.c: New file.
3763         * dwarf-index-common.h: New file.
3764         * dwarf-index-write.c: New file.
3765         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
3766         (struct dwarf2_section_info): Move from here.
3767         (dwarf2_section_info_def): Likewise.
3768         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
3769         (offset_type): Likewise.
3770         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
3771         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
3772         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
3773         (byte_swap): Likewise.
3774         (MAYBE_SWAP): Likewise.
3775         (dwarf2_per_cu_ptr): Likewise.
3776         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
3777         (struct tu_stats): Likewise.
3778         (struct dwarf2_per_objfile): Likewise.
3779         (struct dwarf2_per_cu_data): Likewise.
3780         (struct signatured_type): Likewise.
3781         (sig_type_ptr): Likewise.
3782         (DEF_VEC_P (sig_type_ptr)): Likewise.
3783         (INDEX4_SUFFIX): Likewise.
3784         (INDEX5_SUFFIX): Likewise.
3785         (DEBUG_STR_SUFFIX): Likewise.
3786         (dwarf2_read_section): Make non-static.
3787         (mapped_index_string_hash): Move from here.
3788         (dwarf5_djb_hash): Likewise.
3789         (file_write): Likewise.
3790         (class data_buf): Likewise.
3791         (struct symtab_index_entry): Likewise.
3792         (struct mapped_symtab): Likewise.
3793         (find_slot): Likewise.
3794         (hash_expand): Likewise.
3795         (add_index_entry): Likewise.
3796         (uniquify_cu_indices): Likewise.
3797         (class c_str_view): Likewise.
3798         (class c_str_view_hasher): Likewise.
3799         (class vector_hasher): Likewise.
3800         (write_hash_table): Likewise.
3801         (psym_index_map): Likewise.
3802         (struct addrmap_index_data): Likewise.
3803         (add_address_entry): Likewise.
3804         (add_address_entry_worker): Likewise.
3805         (write_address_map): Likewise.
3806         (symbol_kind): Likewise.
3807         (write_psymbols): Likewise.
3808         (struct signatured_type_index_data): Likewise.
3809         (write_one_signatured_type): Likewise.
3810         (recursively_count_psymbols): Likewise.
3811         (recursively_write_psymbols): Likewise.
3812         (class debug_names): Likewise.
3813         (check_dwarf64_offsets): Likewise.
3814         (psyms_seen_size): Likewise.
3815         (write_gdbindex): Likewise.
3816         (write_debug_names): Likewise.
3817         (assert_file_size): Likewise.
3818         (write_psymtabs_to_index): Likewise.
3819         (save_gdb_index_command): Likewise.
3820         (_initialize_dwarf2_read): Don't register the "save gdb-index"
3821         command.
3822         * dwarf2read.h: New file.
3823
3824 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
3825
3826         PR gdb/22670
3827         * dwarf2read.c (dwarf2_physname): Do not return the demangled
3828         symbol name if the CU's language stores symbol names in linkage
3829         format.
3830         * language.h (struct language_defn)
3831         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
3832         all instances of this struct.
3833
3834 2018-03-26  Tom Tromey  <tom@tromey.com>
3835
3836         * stack.c (backtrace_command_1): Remove verbose code.
3837
3838 2018-03-26  Tom Tromey  <tom@tromey.com>
3839
3840         * python/py-framefilter.c (py_print_type): Don't catch
3841         exceptions.  Return void.
3842         (py_print_value): Likewise.
3843         (py_print_single_arg): Likewise.
3844         (enumerate_args): Don't catch exceptions.
3845         (py_print_args): Likewise.
3846         (py_print_frame): Likewise.
3847         (gdbpy_apply_frame_filter): Catch exceptions here.
3848
3849 2018-03-26  Tom Tromey  <tom@tromey.com>
3850
3851         * stack.c (_initialize_stack): Remove trailing newlines from help
3852         text.  Add "Usage" line to "backtrace" help.
3853
3854 2018-03-26  Tom Tromey  <tom@tromey.com>
3855
3856         PR python/16486:
3857         * python/py-framefilter.c (py_print_args): Call wrap_hint.
3858
3859 2018-03-26  Tom Tromey  <tom@tromey.com>
3860
3861         * python/py-framefilter.c (py_print_single_arg): Return
3862         EXT_LANG_BT_ERROR from catch.
3863
3864 2018-03-26  Tom Tromey  <tom@tromey.com>
3865
3866         PR backtrace/15584:
3867         * stack.c (backtrace_command_1): Move some code into no-filters
3868         "if".
3869
3870 2018-03-26  Tom Tromey  <tom@tromey.com>
3871
3872         * python/py-framefilter.c (throw_quit_or_print_exception): New
3873         function.
3874         (gdbpy_apply_frame_filter): Use it.
3875
3876 2018-03-26  Tom Tromey  <tom@tromey.com>
3877
3878         PR cli/17716:
3879         * python/py-framefilter.c (py_print_type, py_print_value)
3880         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
3881         RETURN_MASK_ERROR.
3882
3883 2018-03-26  Tom Tromey  <tom@tromey.com>
3884
3885         * python/py-framefilter.c (enumerate_args): Use
3886         gdb::unique_xmalloc_ptr.
3887
3888 2018-03-26  Tom Tromey  <tom@tromey.com>
3889
3890         * python/py-framefilter.c (py_print_frame): Return
3891         EXT_LANG_BT_OK.
3892         (gdbpy_apply_frame_filter): Update comment.
3893         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
3894         Remove.
3895         <EXT_LANG_BT_NO_FILTERS>: Change value.
3896
3897 2018-03-26  Tom Tromey  <tom@tromey.com>
3898
3899         PR backtrace/15582:
3900         * stack.c (backtrace_command): Parse "hide" argument.
3901         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
3902         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
3903         constant.
3904
3905 2018-03-26  Tom Tromey  <tom@tromey.com>
3906
3907         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
3908         add "flags".
3909         (backtrace_command): Remove "fulltrace", add "flags".
3910
3911 2018-03-26  Tom Tromey  <tom@tromey.com>
3912
3913         * stack.c (backtrace_command): Rewrite command line parsing.
3914
3915 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
3916
3917         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
3918
3919 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
3920
3921         * filename-seen-cache.h: Add include guard.
3922
3923 2018-03-26  Keith Seitz  <keiths@redhat.com>
3924
3925         * symfile.c (place_section): Remove "struct" from section_addr_info
3926         in comment.
3927         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
3928         "struct" keyword from section_addr_info.
3929
3930 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
3931
3932         * regformats/regdef.h (reg): Add constructors.
3933
3934 2018-03-25  Pedro Alves  <palves@redhat.com>
3935
3936         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
3937         if then/else bodies in var_func_name extraction.
3938
3939 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
3940
3941         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
3942         lookup_minimal_symbol() to find symbol entry.
3943         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
3944
3945 2018-03-23  Keith Seitz  <keiths@redhat.com>
3946
3947         PR c++/22968
3948         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
3949         nested type definitions for C++, too.
3950
3951 2018-03-23  Tom Tromey  <tom@tromey.com>
3952
3953         * machoread.c (struct oso_el): Add a constructor.  Don't define as
3954         a typedef.
3955         (macho_register_oso): Remove.
3956         (macho_symtab_read): Take a std::vector.
3957         (oso_el_compare_name): Now a std::sort comparator.
3958         (macho_symfile_read_all_oso): Take a std::vector.
3959         (macho_symfile_read): Use std::vector.  Remove cleanups.
3960
3961 2018-03-22  Tom Tromey  <tom@tromey.com>
3962
3963         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
3964         (record_full_goto_bookmark): Use std::string.
3965
3966 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
3967
3968         PR tdep/18295
3969         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
3970         a single mask.
3971
3972 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
3973
3974         * rs6000-tdep.c (store_insn_p): New function.
3975         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
3976         and cr_reg to their unshifted values. Use store_insn_p to
3977         match LR saves using either R1 or fdata->alloca_reg. Use
3978         store_insn_p to match CR saves. Set alloca_reg_offset
3979         when alloca_reg and framep are set. Remove lr_reg shift
3980         when assigning to fdata->lr_register.
3981
3982 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3983
3984         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
3985         command line args instead of emitting a warning.
3986
3987 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
3988
3989         * tracepoint.h (struct static_tracepoint_marker): Initialize
3990         fields, define default constructor, move constructor and move
3991         assignment, disable the rest.
3992         <str_id, extra>: Make std::string.
3993         (release_static_tracepoint_marker): Remove.
3994         (free_current_marker): Remove.
3995         * tracepoint.c (free_current_marker): Remove.
3996         (parse_static_tracepoint_marker_definition): Adjust to
3997         std::string, use new hex2str overload.
3998         (release_static_tracepoint_marker): Remove.
3999         (print_one_static_tracepoint_marker): Get marker by reference
4000         and adjust to std::string.
4001         (info_static_tracepoint_markers_command): Adjust to std::vector
4002         changes
4003         * target.h (static_tracepoint_marker_p): Remove typedef.
4004         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
4005         (struct target_ops) <to_static_tracepoint_marker_at>: Return
4006         bool.
4007         <to_static_tracepoint_markers_by_strid>: Return std::vector.
4008         * target-debug.h
4009         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
4010         (target_debug_print_std_vector_static_tracepoint_marker): New.
4011         (target_debug_print_struct_static_tracepoint_marker_p): Rename
4012         to...
4013         (target_debug_print_static_tracepoint_marker_p): ... this.
4014         * target-delegates.c: Re-generate.
4015         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
4016         Make std::string.
4017         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
4018         (decode_static_tracepoint_spec): Adjust to std::vector.
4019         (tracepoint_print_one_detail): Adjust to std::string.
4020         (strace_marker_decode_location): Adjust to std::string.
4021         (update_static_tracepoint): Adjust to std::string, remove call
4022         to release_static_tracepoint_marker.
4023         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
4024         Adjust to std::vector.
4025         * remote.c (remote_static_tracepoint_marker_at): Return bool.
4026         (remote_static_tracepoint_markers_by_strid): Adjust to
4027         std::vector.
4028         * common/rsp-low.h (hex2str): New overload with explicit count
4029         of bytes.
4030         * common/rsp-low.c (hex2str): New overload with explicit count
4031         of bytes.
4032         * unittests/rsp-low-selftests.c (test_hex2str): New function.
4033         (_initialize_rsp_low_selftests): Add test_hex2str test.
4034         * unittests/tracepoint-selftests.c
4035         (test_parse_static_tracepoint_marker_definition): Adjust to
4036         std::string.
4037
4038 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4039
4040         * tracepoint.c (parse_static_tracepoint_marker_definition):
4041         Consider case where the definition is followed by more
4042         definitions.
4043         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4044         tracepoint-selftests.c.
4045         * unittests/tracepoint-selftests.c: New.
4046
4047 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4048
4049         * MAINTAINERS (Write After Approval): Add Pedro Franco de
4050         Carvalho.
4051
4052 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4053
4054         * symtab.c (find_pc_sect_line): fixed indentation.
4055
4056 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4057
4058         * symtab.c (find_pc_sect_line): now uses binary search.
4059
4060 2018-03-19  Tom Tromey  <tom@tromey.com>
4061
4062         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
4063         "IDENT" production.
4064
4065 2018-03-19  Pedro Alves  <palves@redhat.com>
4066             Tom Tromey  <tom@tromey.com>
4067
4068         * unittests/observable-selftests.c: New file.
4069         * common/observable.h: New file.
4070         * observable.h: New file.
4071         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
4072         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
4073         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
4074         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
4075         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
4076         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
4077         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
4078         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
4079         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
4080         python/py-breakpoint.c, python/py-finishbreakpoint.c,
4081         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
4082         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
4083         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
4084         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
4085         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
4086         tui/tui-interp.c, valops.c: Update all users.
4087         * tui/tui-hooks.c (tui_bp_created_observer)
4088         (tui_bp_deleted_observer, tui_bp_modified_observer)
4089         (tui_inferior_exit_observer, tui_before_prompt_observer)
4090         (tui_normal_stop_observer, tui_register_changed_observer):
4091         Remove.
4092         (tui_observers_token): New global.
4093         (attach_or_detach, tui_attach_detach_observers): New functions.
4094         (tui_install_hooks, tui_remove_hooks): Use
4095         tui_attach_detach_observers.
4096         * record-btrace.c (record_btrace_thread_observer): Remove.
4097         (record_btrace_thread_observer_token): New global.
4098         * observer.sh: Remove.
4099         * observer.c: Rename to observable.c.
4100         * observable.c (namespace gdb_observers): Define new objects.
4101         (observer_debug): Move into gdb_observers namespace.
4102         (struct observer, struct observer_list, xalloc_observer_list_node)
4103         (xfree_observer_list_node, generic_observer_attach)
4104         (generic_observer_detach, generic_observer_notify): Remove.
4105         (_initialize_observer): Update.
4106         Don't include observer.inc.
4107         * Makefile.in (generated_files): Remove observer.h, observer.inc.
4108         (clean mostlyclean): Likewise.
4109         (observer.h, observer.inc): Remove targets.
4110         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
4111         (COMMON_SFILES): Use observable.c, not observer.c.
4112         * .gitignore: Remove observer.h.
4113
4114 2018-03-18  Tom Tromey  <tom@tromey.com>
4115
4116         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
4117         gdb::def_vector.
4118         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
4119
4120 2018-03-17  Tom Tromey  <tom@tromey.com>
4121
4122         * auto-load.c (auto_load_objfile_script_1): Use std::string.
4123
4124 2018-03-17  Tom Tromey  <tom@tromey.com>
4125
4126         * target.c (class scoped_target_fd): New.
4127         (target_fileio_close_cleanup): Remove.
4128         (target_fileio_read_alloc_1): Use scoped_target_fd.
4129
4130 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
4131
4132         * silent-rules.mk: New.
4133         * Makefile.in: Include silent-rules.mk
4134         (srcdir, VPATH, top_srcdir): Move up.
4135         (COMPILE): Add ECHO_CXX.
4136         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
4137         (init.c): Add ECHO_INIT_C.
4138         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
4139         (version.c): Add ECHO_GEN.
4140         (printcmd.o): Add ECHO_CXX.
4141         (target-float.o): Add ECHO_CXX.
4142         (ada-exp.o): Add ECHO_CXX.
4143         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
4144         (insight$(EXEEXT)): Add ECHO_CXXLD.
4145         * gnulib/configure.ac: Add AM_SILENT_RULES.
4146         * gnulib/aclocal.m4: Re-generate.
4147         * gnulib/configure: Re-generate.
4148         * gnulib/import/Makefile.in: Re-generate.
4149
4150 2018-03-16  Tom Tromey  <tom@tromey.com>
4151
4152         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
4153         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
4154         * utils.c (do_free_section_addr_info)
4155         (make_cleanup_free_section_addr_info): Remove.
4156         * symfile.h (struct other_sections): Add constructor.
4157         (struct section_addr_info): Remove.
4158         (section_addr_info): New typedef.
4159         (struct sym_fns) <sym_offsets>: Change type of parameter.
4160         (build_section_addr_info_from_objfile)
4161         (relative_addr_info_to_section_offsets, addr_info_make_relative)
4162         (default_symfile_offsets, symbol_file_add)
4163         (symbol_file_add_from_bfd)
4164         (build_section_addr_info_from_section_table): Update.
4165         (alloc_section_addr_info, free_section_addr_info): Don't declare.
4166         * symfile.c (alloc_section_addr_info): Remove.
4167         (build_section_addr_info_from_section_table): Change return type.
4168         Update.
4169         (build_section_addr_info_from_bfd)
4170         (build_section_addr_info_from_objfile): Likewise.
4171         (free_section_addr_info): Remove.
4172         (relative_addr_info_to_section_offsets): Change type of "addrs".
4173         (addrs_section_compar): Now a std::sort comparator.
4174         (addrs_section_sort): Change return type.
4175         (addr_info_make_relative): Change type of "addrs".  Update.
4176         (default_symfile_offsets, syms_from_objfile_1)
4177         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
4178         (symbol_file_add_separate): Update.
4179         (symbol_file_add): Change type of "addrs".  Update.
4180         (add_symbol_file_command): Update.  Remove cleanups.
4181         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
4182         cleanups.
4183         * symfile-debug.c (debug_sym_offsets): Change type of "info".
4184         * solib.c (solib_read_symbols): Update.
4185         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
4186         * machoread.c (macho_symfile_offsets): Update.
4187         * jit.c (jit_bfd_try_read_symtab): Update.
4188
4189 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
4190
4191         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4192         unittests/utils-selftests.c.
4193         * unittests/utils-selftests.c: New file.
4194
4195 2018-03-14  Tom Tromey  <tom@tromey.com>
4196
4197         PR cli/14977:
4198         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
4199         for NULL.
4200
4201 2018-03-14  Tom Tromey  <tom@tromey.com>
4202
4203         PR cli/19918:
4204         * printcmd.c (printf_pointer): Allow "-" in format.
4205
4206 2018-03-14  Tom Tromey  <tom@tromey.com>
4207
4208         * printcmd.c (_initialize_printcmd): Add usage to printf.
4209
4210 2018-03-14  Yao Qi  <qiyao@sourceware.org>
4211
4212         * MAINTAINERS: Update my email address.
4213
4214 2018-03-13  Tom Tromey  <tom@tromey.com>
4215
4216         * machoread.c (macho_check_dsym): Change filenamep to a
4217         std::string*.
4218         (macho_symfile_read): Update.
4219         * symfile.c (load_command): Use std::string.
4220
4221 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4222
4223         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
4224         to error message string.
4225         (riscv_register_name): Use xsnprintf instead of sprintf.
4226         (riscv_insn::fetch_instruction): Use gdb_assert instead of
4227         internal_error.
4228         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
4229         error.
4230         (riscv_push_dummy_call): Likewise.
4231
4232 2018-03-12  Tom Tromey  <tom@tromey.com>
4233
4234         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
4235         Use gdb::byte_vector.
4236         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
4237
4238 2018-03-12  Yao Qi  <yao.qi@linaro.org>
4239
4240         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
4241         parameter type to readable_regcache.
4242         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
4243         the declaration.
4244
4245 2018-03-11  Tom Tromey  <tom@tromey.com>
4246
4247         * dwarf2read.c (struct nextfield): Add initializers.
4248         (struct nextfnfield): Remove.
4249         (struct fnfieldlist): Add initializers.  Remove "length" and
4250         "head", use std::vector.
4251         (struct decl_field_list): Remove.
4252         (struct field_info): Add initializers.
4253         <fields, baseclasses>: Now std::vector.
4254         <nbaseclasses, nfnfields, typedef_field_list_count,
4255         nested_types_list_count>: Remove.
4256         (dwarf2_add_field, dwarf2_add_type_defn)
4257         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
4258         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
4259         (process_structure_scope): Update.
4260
4261 2018-03-11  Tom Tromey  <tom@tromey.com>
4262
4263         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
4264         for use by std::sort.
4265         (build_type_psymtabs_1): Use std::vector.
4266
4267 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
4268
4269         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
4270         and LIBMPFR in the printed configuration.
4271
4272 2018-03-08  Tom Tromey  <tom@tromey.com>
4273
4274         * source.c (get_filename_and_charpos): Use scoped_fd.
4275         * nto-procfs.c (procfs_open_1): Use scoped_fd.
4276         (procfs_pidlist): Likewise.
4277         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
4278         (iterate_over_mappings): Likewise.
4279
4280 2018-03-08  Tom Tromey  <tom@tromey.com>
4281
4282         * infcall.c (struct call_return_meta_info)
4283         <stack_temporaries_enabled>: Remove.
4284         (get_call_return_value, call_function_by_hand_dummy): Update.
4285         * thread.c (disable_thread_stack_temporaries): Remove.
4286         (enable_thread_stack_temporaries): Remove.
4287         (thread_stack_temporaries_enabled_p): Return bool.
4288         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
4289         (get_last_thread_stack_temporary): Update.
4290         * eval.c (evaluate_subexp): Update.
4291         * gdbthread.h (class enable_thread_stack_temporaries): Now a
4292         class, not a function.
4293         (value_ptr, value_vec): Remove typedefs.
4294         (class thread_info) <stack_temporaries_enabled>: Now bool.
4295         <stack_temporaries>: Now a std::vector.
4296         (thread_stack_temporaries_enabled_p)
4297         (value_in_thread_stack_temporaries): Return bool.
4298
4299 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
4300
4301         * remote.c (putpkt_binary): Fix omitted bytes reporting.
4302         (getpkt_or_notif_sane_1): Likewise.
4303
4304 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4305
4306         * build-id.c (build_id_to_debug_bfd): Use std::string.
4307
4308 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4309
4310         * build-id.c (find_separate_debug_file_by_buildid): Return
4311         std::string.
4312         * build-id.h (find_separate_debug_file_by_buildid): Return
4313         std::string.
4314         * coffread.c (coff_symfile_read): Adjust to std::string.
4315         * elfread.c (elf_symfile_read): Adjust to std::string.
4316         * symfile.c (separate_debug_file_exists): Change parameter to
4317         std::string.
4318         (find_separate_debug_file): Return std::string.
4319         (find_separate_debug_file_by_debuglink): Return std::string.
4320         * symfile.h (find_separate_debug_file_by_debuglink): Return
4321         std::string.
4322
4323 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4324
4325         * common/xml-utils.c (xml_escape_text): Move code to...
4326         (xml_escape_text_append): ... this new function.
4327         * common/xml-utils.h (xml_escape_text_append): New declaration.
4328         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
4329         New function.
4330         (_initialize_xml_utils): register test_xml_escape_text_append as
4331         a selftest.
4332
4333 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
4334
4335         * defs.h: Remove MAX_REGISTER_SIZE.
4336         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
4337         asserts.
4338         * python/py-unwind.c (pyuw_sniffer): Likewise.
4339
4340 2018-03-07  Tom Tromey  <tom@tromey.com>
4341
4342         * linux-tdep.c (linux_info_proc): Update.
4343         * target.h (struct target_ops) <to_fileio_readlink>: Return
4344         optional<string>.
4345         (target_fileio_readlink): Return optional<string>.
4346         * remote.c (remote_hostio_readlink): Return optional<string>.
4347         * inf-child.c (inf_child_fileio_readlink): Return
4348         optional<string>.
4349         * target.c (target_fileio_readlink): Return optional<string>.
4350
4351 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4352
4353         * regcache.c (cooked_read_test): Add riscv to the list of
4354         architectures that have a save_reggroup.
4355
4356 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4357
4358         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
4359         value is not a dynamic class object.
4360
4361 2018-03-06  Tom Tromey  <tom@tromey.com>
4362
4363         * rust-exp.y: Formatting fixes.
4364
4365 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4366
4367         * riscv-tdep.c (riscv_register_name): Remove target description
4368         support.
4369         (riscv_gdbarch_init): Remove target description check.
4370
4371 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4372
4373         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
4374         comment.
4375         * riscv-tdep.h: Likewise.
4376
4377 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4378
4379         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
4380         (riscv_pseudo_register_write): Delete.
4381         (riscv_gdbarch_init): Remove all use of pseudo registers.
4382
4383 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4384
4385         * record-btrace.c (btrace_print_lines): Replace cleanup
4386         parameter with RAII equivalents.
4387         (btrace_insn_history): Replace cleanup with RAII equivalents.
4388         * ui-out.h (make_cleanup_ui_out_list_begin_end,
4389         make_cleanup_ui_out_tuple_begin_end): Remove.
4390         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
4391         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
4392         make_cleanup_ui_out_list_begin_end): Remove.
4393
4394 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4395
4396         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
4397         parameter types to std::vector.  Use bool.
4398         (record_btrace_wait): Replace VEC(tp_t) with
4399         std::vector<thread_info *>.
4400         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
4401
4402 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
4403
4404         * record-btrace.c (record_btrace_disable_callback): Remove.
4405         (struct scoped_btrace_disable): New.
4406         (record_btrace_open): Use scoped_btrace_disable.
4407
4408 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4409
4410         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
4411         reading values from registers.
4412
4413 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4414
4415         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
4416         where appropriate.
4417
4418 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4419
4420         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
4421         change parameter type.  Use GDB's print functions, and use
4422         core_addr_to_string where appropriate.
4423         (riscv_push_dummy_call): Use core_addr_to_string where
4424         appropriate, update call to riscv_print_arg_location, and reindent
4425         a few lines.
4426         (riscv_return_value): Update call to riscv_print_arg_location.
4427
4428 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4429             Tim Newsome <tim@sifive.com>
4430             Albert Ou <a0u@eecs.berkeley.edu>
4431             Darius Rad <darius@bluespec.com>
4432
4433         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
4434         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
4435         (ALLDEPFILES): Add riscv-tdep.c
4436         * configure.tgt: Add riscv support.
4437         * riscv-tdep.c: New file.
4438         * riscv-tdep.h: New file.
4439         * NEWS: Mention new target.
4440         * MAINTAINERS: Add entry for riscv.
4441
4442 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4443
4444         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
4445         fields within aggregates.
4446
4447 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
4448
4449         * record-btrace.c (btrace_print_lines): Change type of flags to
4450         gdb_disassembly_flags.
4451
4452 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4453
4454         * fbsd-nat.c: Include "inf-ptrace.h".
4455         (USE_SIGTRAP_SIGINFO): Conditionally define.
4456         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
4457         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
4458         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
4459         function.
4460         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
4461         Likewise.
4462         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
4463         Likewise.
4464         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
4465         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
4466         "supports_stopped_by_hw_breakpoint" target methods.
4467
4468 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4469
4470         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
4471         * fbsd-nat.c (debug_fbsd_nat): New variable.
4472         (show_fbsd_nat_debug): New function.
4473         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
4474         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
4475
4476 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
4477
4478         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
4479         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
4480         prototype.
4481         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
4482         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
4483         method.
4484
4485 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4486
4487         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
4488         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
4489
4490 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4491
4492         * charset.c (struct charset_vector): New.
4493         (charsets): Change type to charset_vector.
4494         (find_charset_names): Adjust.
4495         (add_one): Adjust.
4496         (_initialize_charset): Adjust.
4497
4498 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4499
4500         * progspace.h (struct program_space) <deleted_solibs>: Change
4501         type to std::vector<std::string>.
4502         * progspace.c (clear_program_space_solib_cache): Adjust.
4503         * breakpoint.c (print_solib_event): Adjust.
4504         (check_status_catch_solib): Adjust.
4505         * solib.c (update_solib_list): Adjust.
4506         * ui-out.h (class ui_out) <field_string>: New overload.
4507         * ui-out.c (ui_out::field_string): New overload.
4508
4509 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4510
4511         * progspace.h (struct program_space): Add constructor and
4512         destructor, initialize fields.
4513         (add_program_space): Remove.
4514         * progspace.c (add_program_space): Rename to...
4515         (program_space::program_space): ... this.
4516         (release_program_space): Rename to...
4517         (program_space::~program_space): ... this.
4518         (delete_program_space): Use delete to delete program_space.
4519         (initialize_progspace): Use new to allocate program_space.
4520         * inferior.c (add_inferior_with_spaces): Likewise.
4521         (clone_inferior_command): Likewise.
4522         * infrun.c (follow_fork_inferior): Likewise.
4523         (handle_vfork_child_exec_or_exit): Likewise.
4524
4525 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
4526
4527         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
4528         (delim_string_to_char_ptr_vec): Return std::vector of
4529         gdb::unique_xmalloc_ptr.
4530         (dirnames_to_char_ptr_vec_append): Take std::vector of
4531         gdb::unique_xmalloc_ptr.
4532         (dirnames_to_char_ptr_vec): Return std::vector of
4533         gdb::unique_xmalloc_ptr.
4534         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
4535         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
4536         (delim_string_to_char_ptr_vec): Return an std::vector of
4537         gdb::unique_xmalloc_ptr, adjust the code.
4538         (dirnames_to_char_ptr_vec_append): Take an std::vector of
4539         gdb::unique_xmalloc_ptr, adjust the code.
4540         (dirnames_to_char_ptr_vec): Return an std::vector of
4541         gdb::unique_xmalloc_ptr, adjust the code.
4542         * auto-load.c (auto_load_safe_path_vec): Change type to
4543         std::vector of gdb::unique_xmalloc_ptr.
4544         (auto_load_expand_dir_vars): Return an std::vector of
4545         gdb::unique_xmalloc_ptr, adjust the code.
4546         (auto_load_safe_path_vec_update): Adjust.
4547         (filename_is_in_auto_load_safe_path_vec): Adjust.
4548         (auto_load_objfile_script_1): Adjust.
4549         * build-id.c (build_id_to_debug_bfd): Adjust.
4550         * linux-thread-db.c (thread_db_load_search): Adjust.
4551         * source.c (add_path): Adjust.
4552         (openp): Adjust.
4553         * symfile.c (find_separate_debug_file): Adjust.
4554         * utils.c (do_free_char_ptr_vec): Remove.
4555         (make_cleanup_free_char_ptr_vec): Remove.
4556
4557 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4558
4559         PR gdb/22907
4560         * common/pathstuff.c: Conditionally include "<windows.h>".
4561
4562 2018-03-01  Georg Sauthoff  <mail@georg.so>
4563
4564         PR gdb/22888
4565         * gcore.in: Quote variables and switch interpreter to bash.
4566
4567 2018-03-01  Tom Tromey  <tom@tromey.com>
4568
4569         * dwarf2read.c (alloc_discriminant_info): Fix default_index
4570         assertion.  Add assertion for discriminant_index.
4571         (quirk_rust_enum): Use correct base type name in univariant case.
4572
4573 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
4574
4575         * record.c (get_call_history_modifiers): Return a
4576         record_print_flags.
4577         (cmd_record_call_history): Adjust.
4578         * record-btrace.c (record_btrace_call_history): Adjust.
4579         (record_btrace_call_history_range): Adjust.
4580         (record_btrace_call_history_from): Adjust.
4581         * target-debug.h (target_debug_print_record_print_flags): New.
4582         * target-delegates.c: Re-generate.
4583         * target.c (target_call_history): Change flags type.
4584         (target_call_history_from): Likewise.
4585         (target_call_history_range): Likewise.
4586         * target.h (struct target_ops) <target_call_history>: Likewise.
4587         (target_call_history_from): Likewise.
4588         (target_call_history_range): Likewise.
4589
4590 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4591             Simon Marchi  <simon.marchi@polymtl.ca>
4592
4593         * common/common-utils.c: Include "sys/stat.h".
4594         (is_regular_file): Move here from "source.c"; change return
4595         type to "bool".
4596         * common/common-utils.h (is_regular_file): New prototype.
4597         * common/pathstuff.c (contains_dir_separator): New function.
4598         * common/pathstuff.h (contains_dir_separator): New prototype.
4599         * source.c: Don't include "sys/stat.h".
4600         (is_regular_file): Move to "common/common-utils.c".
4601
4602 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4603
4604         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
4605         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
4606         * auto-load.c: Include "common/pathstuff.h".
4607         * common/common-def.h (current_directory): Move here.
4608         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
4609         function.
4610         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
4611         prototype.
4612         * common/pathstuff.c: New file.
4613         * common/pathstuff.h: New file.
4614         * compile/compile.c: Include "common/pathstuff.h".
4615         * defs.h (current_directory): Move to "common/common-defs.h".
4616         * dwarf2read.c: Include "common/pathstuff.h".
4617         * exec.c: Likewise.
4618         * guile/scm-safe-call.c: Likewise.
4619         * linux-thread-db.c: Likewise.
4620         * main.c: Likewise.
4621         * nto-tdep.c: Likewise.
4622         * objfiles.c: Likewise.
4623         * source.c: Likewise.
4624         * symtab.c: Likewise.
4625         * utils.c: Include "common/pathstuff.h".
4626         (gdb_realpath): Move to "common/pathstuff.c".
4627         (gdb_realpath_keepfile): Likewise.
4628         (gdb_abspath): Likewise.
4629         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
4630         (gdb_realpath_keepfile): Likewise.
4631         (gdb_abspath): Likewise.
4632
4633 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
4634
4635         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
4636         wildcard process pid for super_resume for kernels with a
4637         specific bug.
4638
4639 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
4640
4641         * compile/compile.c (get_args): Add additional comments
4642         explaining function.
4643
4644 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
4645             Tom Tromey  <tom@tromey.com>
4646
4647         * target.h (memory_write_request_s): Remove typedef.  Don't define
4648         VEC.
4649         (target_write_memory_blocks): Change argument to std::vector.
4650         (struct memory_write_request): Add constructor.
4651         * target-memory.c (compare_block_starting_address): Return bool.
4652         Change argument types.
4653         (claim_memory): Change arguments to use std::vector.
4654         (split_regular_and_flash_blocks, blocks_to_erase)
4655         (compute_garbled_blocks): Likewise.
4656         (cleanup_request_data, cleanup_write_requests_vector): Remove.
4657         (target_write_memory_blocks): Change argument to std::vector.
4658         * symfile.c (struct load_section_data): Add constructor and
4659         destructor.  Use std::vector for "requests".
4660         (struct load_progress_data): Add initializers.
4661         (load_section_callback): Update.  Use "new".
4662         (clear_memory_write_data): Remove.
4663         (generic_load): Update.
4664
4665 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
4666
4667         * arch/aarch64.h: Use common/tdesc.h.
4668
4669 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
4670
4671         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
4672         architecture with a 64-bit ABI.
4673
4674 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
4675
4676         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
4677         ahead of target description loading.
4678
4679 2018-02-26  Tom Tromey  <tom@tromey.com>
4680
4681         * stack.c (backtrace_command_1): Update.
4682         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
4683         of "flags".
4684         * python/py-framefilter.c (py_print_frame)
4685         (gdbpy_apply_frame_filter): Change type of "flags".
4686         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
4687         of "flags".
4688         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
4689         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
4690         * extension.h (enum frame_filter_flag): Rename from
4691         frame_filter_flags.
4692         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
4693         (apply_ext_lang_frame_filter): Change type of "flags".
4694         * extension.c (apply_ext_lang_frame_filter): Change type of
4695         "flags".
4696         * extension-priv.h (struct extension_language_ops)
4697         <apply_frame_filter>: Change type of "flags".
4698
4699 2018-02-26  Tom Tromey  <tom@tromey.com>
4700
4701         PR python/16497:
4702         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
4703         off-by-one in py_end computation.
4704         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
4705         PRINT_MORE_FRAMES.
4706         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
4707         constant.
4708
4709 2018-02-26  Tom Tromey  <tom@tromey.com>
4710
4711         * dwarf2read.c (struct variant_field): New.
4712         (struct nextfield) <variant>: New field.
4713         (dwarf2_add_field): Handle DW_TAG_variant_part.
4714         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
4715         discriminated union.
4716         (read_structure_type): Handle DW_TAG_variant_part.
4717         (handle_struct_member_die): New function, extracted from
4718         process_structure_scope.  Handle DW_TAG_variant.
4719         (process_structure_scope): Handle discriminated unions.  Call
4720         handle_struct_member_die.
4721
4722 2018-02-26  Tom Tromey  <tom@tromey.com>
4723
4724         * rust-lang.h (rust_last_path_segment): Declare.
4725         * rust-lang.c (rust_last_path_segment): Now public.  Change
4726         contract.
4727         (struct disr_info): Remove.
4728         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
4729         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
4730         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
4731         (rust_enum_p, rust_enum_variant): New function.
4732         (rust_underscore_fields): Remove "offset" parameter.
4733         (rust_print_enum): New function.
4734         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
4735         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
4736         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
4737         enums.
4738         (rust_internal_print_type): New function, from rust_print_type.
4739         Remove enum code.
4740         (rust_print_type): Call rust_internal_print_type.
4741         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
4742         Update enum handling.
4743         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
4744         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
4745         (rust_union_quirks): New functions.
4746         (process_full_comp_unit, process_full_type_unit): Call
4747         rust_union_quirks.
4748         (process_structure_scope): Update rust_unions if necessary.
4749
4750 2018-02-26  Tom Tromey  <tom@tromey.com>
4751
4752         * value.h (value_union_variant): Declare.
4753         * valops.c (value_union_variant): New function.
4754         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
4755         (struct discriminant_info): New.
4756         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
4757         enumerator.
4758         (struct main_type) <flag_discriminated_union>: New field.
4759
4760 2018-02-26  Tom Tromey  <tom@tromey.com>
4761
4762         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4763         unittests/unpack-selftests.c.
4764         * unittests/unpack-selftests.c: New file.
4765         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
4766
4767 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4768
4769         * dwarf2read.c (struct partial_die_info) <read>: New method.
4770         (read_partial_die): Remove the declaration.
4771         (load_partial_dies): Update.
4772         (partial_die_info::partial_die_info):
4773         (read_partial_die): Change it to partial_die_info::read.
4774
4775 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4776
4777         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
4778         (fixup_partial_die): Remove declaration.
4779         (scan_partial_symbols): Update.
4780         (partial_die_parent_scope): Likewise.
4781         (partial_die_full_name): Likewise.
4782         (fixup_partial_die): Change it to partial_die_info::fixup.
4783
4784 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4785
4786         * dwarf2read.c (read_partial_die): Update the declaration.
4787         (load_partial_dies): Caller update.
4788         (read_partial_die): Remove one argument abbrev_len.
4789
4790 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4791
4792         * dwarf2read.c (struct partial_die_info): Add ctor, delete
4793         assignment operator.
4794         (load_partial_dies): Use ctor and copy ctor.
4795         (read_partial_die): Update.
4796         (dwarf2_cu::find_partial_die): Use ctor.
4797
4798 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4799
4800         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
4801         (find_partial_die_in_comp_unit): Change it to
4802         dwarf2_cu::find_partial_die.
4803         (find_partial_die): Update.
4804
4805 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4806
4807         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
4808         is NULL.
4809
4810 2018-02-26  Yao Qi  <yao.qi@linaro.org>
4811
4812         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
4813
4814 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
4815
4816         * arch/amd64.h: Use common/tdesc.h.
4817         * arch/i386.c: Likewise.
4818         * arch/i386.h: Likewise.
4819         * arch/tic6x.c: Likewise.
4820         * arch/tdesc.h: Move file from here...
4821         * common/tdesc.h: ...to here.
4822         * features/aarch64-core.c: Regenerate.
4823         * features/aarch64-fpu.c: Regenerate.
4824         * features/i386/32bit-avx.c: Regenerate.
4825         * features/i386/32bit-avx512.c: Regenerate.
4826         * features/i386/32bit-core.c: Regenerate.
4827         * features/i386/32bit-linux.c: Regenerate.
4828         * features/i386/32bit-mpx.c: Regenerate.
4829         * features/i386/32bit-pkeys.c: Regenerate.
4830         * features/i386/32bit-sse.c: Regenerate.
4831         * features/i386/64bit-avx.c: Regenerate.
4832         * features/i386/64bit-avx512.c: Regenerate.
4833         * features/i386/64bit-core.c: Regenerate.
4834         * features/i386/64bit-linux.c: Regenerate.
4835         * features/i386/64bit-mpx.c: Regenerate.
4836         * features/i386/64bit-pkeys.c: Regenerate.
4837         * features/i386/64bit-segments.c: Regenerate.
4838         * features/i386/64bit-sse.c: Regenerate.
4839         * features/i386/x32-core.c: Regenerate.
4840         * features/tic6x-c6xp.c: Regenerate.
4841         * features/tic6x-core.c: Regenerate.
4842         * features/tic6x-gp.c: Regenerate.
4843         * target-descriptions.c: Use common/tdesc.h.
4844         * target-descriptions.h: Likewise.
4845
4846 2018-02-24  Tom Tromey  <tom@tromey.com>
4847
4848         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
4849         (try_thread_db_load_from_dir, thread_db_load_search): Use
4850         std::string.
4851         (info_auto_load_libthread_db_compare): Return bool.  Change
4852         argument types.
4853         (info_auto_load_libthread_db): Use std::vector, std::string.
4854         Remove cleanups.
4855
4856 2018-02-24  Tom Tromey  <tom@tromey.com>
4857
4858         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
4859         std::string.
4860         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
4861         std::string*.
4862         * gdbarch.c: Rebuild.
4863         * gdbarch.h: Rebuild.
4864         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
4865         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
4866         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
4867         std::string*.
4868
4869 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
4870
4871         * gdbtypes.h (sect_offset): Change type to uint64_t.
4872         (sect_offset_str): New function.
4873         * dwarf2read.c (create_addrmap_from_aranges): Use
4874         sect_offset_str.
4875         (error_check_comp_unit_head): Likewise.
4876         (create_debug_type_hash_table): Likewise.
4877         (read_cutu_die_from_dwo): Likewise.
4878         (init_cutu_and_read_dies): Likewise.
4879         (init_cutu_and_read_dies_no_follow): Likewise.
4880         (process_psymtab_comp_unit_reader): Likewise.
4881         (partial_die_parent_scope): Likewise.
4882         (peek_die_abbrev): Likewise.
4883         (process_queue): Likewise.
4884         (dwarf2_physname): Likewise.
4885         (read_namespace_alias): Likewise.
4886         (read_import_statement): Likewise.
4887         (create_dwo_cu_reader): Likewise.
4888         (create_cus_hash_table): Likewise.
4889         (lookup_dwo_cutu): Likewise.
4890         (inherit_abstract_dies): Likewise.
4891         (read_func_scope): Likewise.
4892         (read_call_site_scope): Likewise.
4893         (dwarf2_add_member_fn): Likewise.
4894         (read_common_block): Likewise.
4895         (read_module_type): Likewise.
4896         (read_typedef): Likewise.
4897         (read_subrange_type): Likewise.
4898         (load_partial_dies): Likewise.
4899         (read_partial_die): Likewise.
4900         (find_partial_die): Likewise.
4901         (read_str_index): Likewise.
4902         (dwarf2_string_attr): Likewise.
4903         (build_error_marker_type): Likewise.
4904         (lookup_die_type): Likewise.
4905         (dump_die_shallow): Likewise.
4906         (follow_die_ref): Likewise.
4907         (dwarf2_fetch_die_loc_sect_off): Likewise.
4908         (dwarf2_fetch_constant_bytes): Likewise.
4909         (follow_die_sig): Likewise.
4910         (get_signatured_type): Likewise.
4911         (get_DW_AT_signature_type): Likewise.
4912         (dwarf2_find_containing_comp_unit): Likewise.
4913         (set_die_type): Likewise.
4914
4915 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
4916
4917         * arch/aarch64.c: Include "common-defs.h".
4918         * arch/amd64.c: Likewise.
4919         * arch/i386.c: Likewise.
4920
4921 2018-02-21  Tom Tromey  <tom@tromey.com>
4922
4923         * value.h: (extract_field_op): Update.
4924         * eval.c (extract_field_op): Return a const char *.
4925         * expression.h (parse_expression_for_completion): Update.
4926         * completer.c (complete_expression): Update.
4927         (add_struct_fields): Make fieldname const.
4928         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
4929         (mark_completion_tag, parse_exp_in_context_1): Update.
4930         (parse_expression_for_completion): Change "name" to
4931         unique_xmalloc_ptr*.
4932
4933 2018-02-21  Tom Tromey  <tom@tromey.com>
4934
4935         * infcall.c (call_function_by_hand_dummy): Use std::vector.
4936
4937 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4938
4939         * avr-tdep.c (avr_read_pc): Change parameter type to
4940         readable_regcache.
4941         * gdbarch.sh (read_pc): Likewise.
4942         * gdbarch.c: Re-generated.
4943         * gdbarch.h: Re-generated.
4944         * hppa-tdep.c (hppa_read_pc): Change parameter type to
4945         readable_regcache.
4946         * ia64-tdep.c (ia64_read_pc): Likewise.
4947         * mips-tdep.c (mips_read_pc): Likewise.
4948         * spu-tdep.c (spu_read_pc): Likewise.
4949
4950 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4951
4952         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
4953         * regcache-dump.c: New file.
4954         * regcache.c: Move register_dump to regcache-dump.c.
4955         (maintenance_print_registers): Likewise.
4956         (maintenance_print_raw_registers): Likewise.
4957         (maintenance_print_cooked_registers): Likewise.
4958         (maintenance_print_register_groups): Likewise.
4959         (maintenance_print_remote_registers): Likewise.
4960         (_initialize_regcache): Likewise.
4961         * regcache.h (register_dump): Moved from regcache.c.
4962
4963 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4964
4965         * regcache.c (regcache::regcache): Update.
4966         (regcache::invalidate): Move it to detached_regcache::invalidate.
4967         (get_thread_arch_aspace_regcache): Update.
4968         (regcache::raw_update): Update.
4969         (regcache::cooked_read): Remove some code.
4970         (regcache::cooked_read_value): Likewise.
4971         (regcache::raw_write): Remove assert on m_readonly_p.
4972         (regcache::raw_supply_integer): Move it to
4973         detached_regcache::raw_supply_integer.
4974         (regcache::raw_supply_zeroed): Likewise.
4975         * regcache.h (detached_regcache) <raw_supply_integer>: New
4976         declaration.
4977         <raw_supply_zeroed, invalidate>: Likewise.
4978         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
4979         <invalidate>: Likewise.
4980         <m_readonly_p>: Removed.
4981
4982 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4983
4984         * infcmd.c (get_return_value): Let stop_regs point to
4985         get_current_regcache.
4986         * regcache.c (regcache::regcache): Remove.
4987         (register_dump_reg_buffer): New class.
4988         (regcache_print): Adjust.
4989         * regcache.h (regcache): Remove constructors.
4990
4991 2018-02-21  Yao Qi  <yao.qi@linaro.org>
4992
4993         * regcache.c (class register_dump): New class.
4994         (register_dump_regcache, register_dump_none): New class.
4995         (register_dump_remote, register_dump_groups): New class.
4996         (regcache_print): Update.
4997         * regcache.h (regcache_dump_what): Move it to regcache.c.
4998         (regcache) <dump>: Remove.
4999
5000 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5001
5002         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
5003          reg_buffer_rw *.
5004         (jit_unwind_reg_set_impl): Call raw_supply.
5005         (jit_frame_sniffer): Use reg_buffer_rw.
5006         * record-full.c (record_full_core_regbuf): Change its type.
5007         (record_full_core_open_1): Use reg_buffer_rw.
5008         (record_full_close): Likewise.
5009         (record_full_core_fetch_registers): Use regcache->raw_supply.
5010         (record_full_core_store_registers): Likewise.
5011         * regcache.c (regcache::get_register_status): Move it to
5012         reg_buffer.
5013         (regcache_raw_set_cached_value): Remove.
5014         (regcache::raw_set_cached_value): Remove.
5015         (regcache::raw_write): Call raw_supply.
5016         (regcache::raw_supply): Move it to reg_buffer_rw.
5017         * regcache.h (regcache_raw_set_cached_value): Remove.
5018         (reg_buffer_rw): New class.
5019
5020 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5021
5022         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
5023         readonly_detached_regcache.
5024         (dummy_frame_prev_register): Use regcache->cooked_read.
5025         * frame.c (frame_save_as_regcache): Change return type.
5026         (frame_pop): Update.
5027         * frame.h (frame_save_as_regcache): Update declaration.
5028         * inferior.h (get_infcall_suspend_state_regcache): Update
5029         declaration.
5030         * infrun.c (infcall_suspend_state) <registers>: use
5031         readonly_detached_regcache.
5032         (save_infcall_suspend_state): Don't use regcache_dup.
5033         (get_infcall_suspend_state_regcache): Change return type.
5034         * linux-fork.c (struct fork_info) <savedregs>: Change to
5035         readonly_detached_regcache.
5036         <pc>: New field.
5037         (fork_save_infrun_state): Don't use regcache_dup.
5038         (info_checkpoints_command): Adjust.
5039         * mi/mi-main.c (register_changed_p): Update declaration.
5040         (mi_cmd_data_list_changed_registers): Use
5041         readonly_detached_regcache.
5042         (register_changed_p): Change parameter type to
5043         readonly_detached_regcache.
5044         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
5045         readonly_detached_regcache.
5046         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
5047         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
5048         New.
5049         (regcache::save): Move it to reg_buffer.
5050         (regcache::restore): Change parameter type.
5051         (regcache_dup): Remove.
5052         * regcache.h (reg_buffer) <save>: New method.
5053         (readonly_detached_regcache): New class.
5054         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
5055         readonly_detached_regcache.
5056         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
5057
5058 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5059
5060         * frame.c (frame_save_as_regcache): Use regcache method save.
5061         (frame_pop): Use regcache method restore.
5062         * infrun.c (restore_infcall_suspend_state): Likewise.
5063         * linux-fork.c (fork_load_infrun_state): Likewise.
5064         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
5065         save.
5066         * regcache.c (regcache_save): Remove.
5067         (regcache::restore): More asserts.
5068         (regcache_cpy): Remove.
5069         * regcache.h (regcache_save): Remove the declaration.
5070         (regcache::restore): Move from private to public.
5071         Remove the friend declaration of regcache_cpy.
5072         (regcache_cpy): Remove declaration.
5073
5074 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5075
5076         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
5077         parameter type to 'readable_regcache *'.
5078         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5079         * arm-tdep.c (arm_neon_quad_read): Likewise.
5080         (arm_pseudo_read): Likewise.
5081         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5082         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5083         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5084         * gdbarch.c: Re-generated.
5085         * gdbarch.h: Re-generated.
5086         * gdbarch.sh (pseudo_register_read): Change parameter type to
5087         'readable_regcache *'.
5088         (pseudo_register_read_value): Likewise.
5089         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
5090         (h8300_pseudo_register_read): Likewise.
5091         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
5092         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5093         (i386_pseudo_register_read_into_value): Likewise.
5094         (i386_pseudo_register_read_value): Likewise.
5095         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
5096         declaration.
5097         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
5098         * m32c-tdep.c (m32c_raw_read): Likewise.
5099         (m32c_read_flg): Likewise.
5100         (m32c_banked_register): Likewise.
5101         (m32c_banked_read): Likewise.
5102         (m32c_sb_read): Likewise.
5103         (m32c_part_read): Likewise.
5104         (m32c_cat_read): Likewise.
5105         (m32c_r3r2r1r0_read): Likewise.
5106         (m32c_pseudo_register_read): Likewise.
5107         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5108         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5109         (mep_pseudo_cr64_read): Likewise.
5110         (mep_pseudo_register_read): Likewise.
5111         * mips-tdep.c (mips_pseudo_register_read): Likewise.
5112         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5113         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5114         * regcache.c (regcache::raw_read): Move it to readable_regcache.
5115         (regcache::cooked_read): Likewise.
5116         (regcache::cooked_read_value): Likewise.
5117         (regcache_cooked_read_signed):
5118         (regcache::cooked_read): Likewise.
5119         * regcache.h (readable_regcache): New class.
5120         (regcache): Inherit readable_regcache.  Move some methods to
5121         readable_regcache.
5122         * rl78-tdep.c (rl78_pseudo_register_read): Change
5123         parameter type to 'readable_regcache *'.
5124         * rs6000-tdep.c (do_regcache_raw_read): Remove.
5125         (e500_pseudo_register_read): Change parameter type to
5126         'readable_regcache *'.
5127         (dfp_pseudo_register_read): Likewise.
5128         (vsx_pseudo_register_read): Likewise.
5129         (efpr_pseudo_register_read): Likewise.
5130         * s390-tdep.c (s390_pseudo_register_read): Likewise.
5131         * sh-tdep.c (sh_pseudo_register_read): Likewise.
5132         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
5133         (sh64_pseudo_register_read): Likewise.
5134         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
5135         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5136         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
5137         (spu_pseudo_register_read): Likewise.
5138         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5139         (xtensa_pseudo_register_read): Likewise.
5140
5141 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5142
5143         * regcache.c (regcache::regcache): Call reg_buffer ctor.
5144         (regcache::arch): Move it to reg_buffer::arch.
5145         (regcache::register_buffer): Likewise.
5146         (regcache::assert_regnum): Likewise.
5147         (regcache::num_raw_registers): Likewise.
5148         * regcache.h (reg_buffer): New class.
5149         (regcache): Inherit reg_buffer.
5150
5151 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
5152
5153         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
5154         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
5155
5156 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
5157
5158         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
5159
5160 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
5161
5162         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
5163         (SFILES): Remove common/*.c files.
5164         (COMMON_OBS): Remove some *.o files built from common/*.c files.
5165         * common/common.host: Add common reference.
5166         * configure.ac: Likewise.
5167         * configure: Regenerate.
5168
5169 2018-02-16  Yao Qi  <yao.qi@linaro.org>
5170
5171         * block.c (block_namespace_info): Inherit allocate_on_obstack.
5172         (block_initialize_namespace): Use new.
5173         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
5174         (dwarf2_free_objfile): Use delete.
5175         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
5176         (copy_type_recursive): Use new.
5177         * gdb_obstack.h (allocate_on_obstack): New.
5178
5179 2018-02-15  Yao Qi  <yao.qi@linaro.org>
5180
5181         PR gdb/22849
5182         * inferior.c (exit_inferior_1): Reset inf->control.
5183
5184 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
5185
5186         * ada-lang.c (ada_to_fixed_value_create): Delete advance
5187         declaration.
5188
5189 2018-02-14  Pedro Alves  <palves@redhat.com>
5190
5191         * frame-unwind.c (frame_unwind_try_unwinder): Always call
5192         frame_cleanup_after_sniffer on exception.
5193
5194 2018-02-14  Tom Tromey  <tom@tromey.com>
5195
5196         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
5197         const.
5198         (solib_bfd_open): Make pathname const.
5199         * solib.c (solib_bfd_open): Make pathname const.
5200         * solib-spu.c (spu_bfd_fopen): Make name const.
5201         (spu_bfd_open): Make pathname const.
5202         * solib-darwin.c (darwin_bfd_open): Make pathname const.
5203         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
5204
5205 2018-02-14  Tom Tromey  <tom@tromey.com>
5206
5207         * symfile.c (symfile_bfd_open): Update.
5208         * source.h (openp, source_full_path_of, find_and_open_source):
5209         Change argument type to unique_xmalloc_ptr.
5210         * source.c (openp): Take a unique_xmalloc_ptr.
5211         (source_full_path_of, find_and_open_source): Likewise.
5212         (open_source_file, symtab_to_fullname): Update.
5213         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
5214         unique_xmalloc_ptr.
5215         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
5216         (exec_file_find): Update.
5217         * psymtab.c (psymtab_to_fullname): Update.
5218         * nto-tdep.h (nto_find_and_open_solib): Update.
5219         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
5220         unique_xmalloc_ptr.
5221         * exec.c (exec_file_attach): Update.
5222         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
5223         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
5224
5225 2018-02-14  Tom Tromey  <tom@tromey.com>
5226
5227         * solib.c: Include source.h.
5228         * nto-tdep.c: Include source.h.
5229         * mi/mi-cmd-env.c: Include source.h.
5230         * infcmd.c: Include source.h.
5231         * exec.c: Include source.h.
5232         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
5233         (add_path, directory_switch, source_path, init_source_path): Move
5234         declarations...
5235         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
5236         (add_path, directory_switch, source_path, init_source_path):
5237         ...here.
5238
5239 2018-02-14  Tom Tromey  <tom@tromey.com>
5240
5241         * solist.h (exec_file_find, solib_find): Return
5242         unique_xmalloc_ptr.
5243         (solib_bfd_fopen): Take a const char *.
5244         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
5245         (exec_file_find, solib_find): Likewise.
5246         (solib_bfd_fopen): Do not take ownership of "pathname".
5247         (solib_bfd_open): Use unique_xmalloc_ptr.
5248         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
5249         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
5250         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
5251         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
5252
5253 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
5254
5255         * ada-lang.c (name_match_type_from_name): Remove reference to
5256         ada_name_for_lookup in function's documentation.
5257         * ada-lang.h (ada_name_for_lookup): Delete declaration.
5258
5259 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5260
5261         * defs.h (enum openp_flags): New enum.
5262         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
5263         Move to enum openp_flags.
5264         (openp_flags): New enum flags.
5265         (openp): Change parameter type to openp_flags.
5266         * source.c (openp): Change parameter type to openp_flags.
5267         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
5268         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
5269
5270 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5271
5272         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
5273         per-command.
5274
5275 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5276
5277         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
5278         into...
5279         (class dwarf2_queue_guard): ...the destructor of this new class.
5280         (dw2_do_instantiate_symtab): Create instance of the new class
5281         dwarf2_queue_guard, remove cleanup.
5282
5283 2018-02-09  Tom Tromey  <tom@tromey.com>
5284
5285         * source.c (find_source_lines): Don't reference past the end of
5286         the vector.
5287
5288 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5289
5290         * remote.c (remote_btrace_maybe_reopen): Change error message.
5291         * btrace.c (btrace_enable): Likewise.
5292         (parse_xml_btrace): Likewise.
5293         (parse_xml_btrace_conf): Likewise.
5294
5295 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5296
5297         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
5298         (linux_enable_pt, linux_enable_bts): Call
5299         diagnose_perf_event_open_fail.
5300
5301 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5302
5303         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
5304         Remove parameter and change return type.  Update callers.  Move it.
5305         (linux_enable_bts, linux_enable_pt): Improve error message.
5306         (linux_enable_pt): Remove zero buffer size check.
5307         (linux_enable_btrace): Improve error messages.  Remove NULL return
5308         check.
5309
5310 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5311
5312         * btrace.c (btrace_enable): Remove target_supports_btrace call.
5313         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
5314         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
5315         (linux_supports_pt, linux_supports_btrace): Remove.
5316         (linux_enable_bts): Call cpu_supports_bts.
5317         * nat/linux-btrace.h (linux_supports_btrace): Remove.
5318         * remote.c (remote_supports_btrace): Remove.
5319         (init_remote_ops): Remove remote_supports_btrace.
5320         * target-delegates.c: Regenerated.
5321         * target.c (target_supports_btrace): Remove.
5322         * target.h (target_ops) <to_supports_btrace>: Remove
5323         (target_supports_btrace): Remove.
5324         * x86-linux-nat.c (x86_linux_create_target): Remove
5325         linux_supports_btrace.
5326
5327 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5328
5329         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
5330         btrace failed.
5331         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
5332         exception and use message in own exception.
5333
5334 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5335
5336         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
5337         (perf_event_pt_event_type): Use gdb_file_up.
5338         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
5339         scoped_fd, and scoped_mmap.
5340
5341 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5342
5343         * common/scoped_mmap.h: New.
5344         * unittests/scoped_mmap-selftest.c: New.
5345         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5346         unittests/scoped_mmap-selftest.c.
5347
5348 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5349
5350         * common/scoped_fd.h: New.
5351         * unittests/scoped_fd-selftest.c: New.
5352         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5353         unittests/scoped_fd-selftest.c.
5354
5355 2018-02-09  Tom Tromey  <tom@tromey.com>
5356
5357         * auto-load.c (auto_load_section_scripts): Use
5358         gdb::unique_xmalloc_ptr.
5359
5360 2018-02-09  Tom Tromey  <tom@tromey.com>
5361
5362         * auto-load.c (execute_script_contents): Use std::string.
5363
5364 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
5365
5366         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
5367         Python function, rather than a new command.
5368
5369 2018-02-08  Tom Tromey  <tom@tromey.com>
5370
5371         * solib.c (solib_find_1): Use std::string.
5372         (solib_bfd_fopen): Use unique_xmalloc_ptr.
5373
5374 2018-02-08  Tom Tromey  <tom@tromey.com>
5375
5376         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
5377
5378 2018-02-08  Tom Tromey  <tom@tromey.com>
5379
5380         * source.c (find_source_lines): Use gdb::def_vector.
5381
5382 2018-02-08  Tom Tromey  <tom@tromey.com>
5383
5384         * macrocmd.c (struct temporary_macro_definition): New.
5385         (macro_define_command): Use temporary_macro_definition.  Remove
5386         cleanups.
5387         (free_macro_definition_ptr): Remove.
5388
5389 2018-02-08  Tom Tromey  <tom@tromey.com>
5390
5391         * macroexp.c (maybe_expand): Use std::string.
5392
5393 2018-02-08  Tom Tromey  <tom@tromey.com>
5394
5395         * macroexp.c (struct macro_buffer): Add initializers for some
5396         members.
5397         (init_buffer, init_shared_buffer, free_buffer)
5398         (free_buffer_return_text): Remove.
5399         (macro_buffer): New constructors.
5400         (~macro_buffer): New destructor.
5401         (macro_buffer::set_shared): New method.
5402         (macro_buffer::resize_buffer, macro_buffer::appendc)
5403         (macro_buffer::appendmem): Now methods, not free functions.
5404         (set_token, append_tokens_without_splicing, stringify)
5405         (macro_stringify): Update.
5406         (gather_arguments): Change return type.  Remove argc_p argument,
5407         add args_ptr argument.  Use std::vector.
5408         (substitute_args): Remove argc argument.  Accept std::vector.
5409         (expand): Update.  Use std::vector.
5410         (scan, macro_expand, macro_expand_next): Update.
5411
5412 2018-02-08  Tom Tromey  <tom@tromey.com>
5413
5414         * symtab.c (default_collect_symbol_completion_matches_break_on):
5415         Use unique_xmalloc_ptr.
5416         * macroscope.h: (sal_macro_scope, user_macro_scope)
5417         (default_macro_scope): Return unique_xmalloc_ptr.
5418         * macroscope.c (sal_macro_scope, user_macro_scope)
5419         (default_macro_scope): Return unique_xmalloc_ptr.
5420         * macroexp.h (macro_expand, macro_expand_once): Return
5421         unique_xmalloc_ptr.
5422         * macroexp.c (macro_expand, macro_expand_once): Return
5423         unique_xmalloc_ptr.
5424         * macrocmd.c (macro_expand_command, macro_expand_once_command)
5425         (info_macro_command, info_macros_command): Use
5426         unique_xmalloc_ptr.
5427         * compile/compile-c-support.c (write_macro_definitions): Use
5428         unique_xmalloc_ptr.
5429         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
5430
5431 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
5432
5433         * value.c (value_static_field): Assign field type instead of
5434         containing type when returning an optimized out value.
5435
5436 2018-02-06  Yao Qi  <yao.qi@linaro.org>
5437
5438         * ft32-tdep.c (ft32_read_pc): Remove.
5439         (ft32_write_pc): Remove.
5440         (ft32_gdbarch_init): Update.
5441         * m32r-tdep.c (m32r_read_pc): Remove.
5442         (m32r_gdbarch_init): Update.
5443         * mep-tdep.c (mep_read_pc): Remove.
5444         (mep_gdbarch_init): Update.
5445         * microblaze-tdep.c (microblaze_write_pc): Remove.
5446         (microblaze_gdbarch_init): Update.
5447         * mn10300-tdep.c (mn10300_read_pc): Remove.
5448         (mn10300_write_pc): Remove.
5449         (mn10300_gdbarch_init): Update.
5450         * moxie-tdep.c (moxie_read_pc): Remove.
5451         (moxie_write_pc): Remove.
5452         (moxie_gdbarch_init): Update.
5453
5454 2018-02-06  Yao Qi  <yao.qi@linaro.org>
5455
5456         * expprint.c (print_subexp_standard): Handle
5457         OP_F77_UNDETERMINED_ARGLIST.
5458         (dump_subexp_body_standard): Likewise.
5459
5460 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
5461
5462         * target-descriptions.c (tdesc_element_visitor) Add empty
5463         implementations.
5464         (tdesc_type): Move make_gdb_type from here.
5465         (tdesc_type_builtin): Likewise.
5466         (tdesc_type_vector): Likewise.
5467         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
5468         (make_gdb_type_struct): Move from tdesc_type_with_fields.
5469         (make_gdb_type_union): Likewise.
5470         (make_gdb_type_flags): Likewise.
5471         (make_gdb_type_enum): Likewise.
5472         (make_gdb_type): New function.
5473         (tdesc_register_type): Use static make_gdb_type.
5474
5475 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
5476
5477         * infcmd.c (default_print_one_register_info): Align natural-format
5478         column values consistently one under another.
5479         (pad_to_column): New function.
5480
5481 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
5482
5483         * dwarf2read.c (dwarf2_physname): Move commment.
5484
5485 2018-02-01  Leszek Swirski  <leszeks@google.com>
5486
5487         * varobj.c (varobj_formatted_print_options): Allow recursive
5488         pretty printing if pretty printing is enabled.
5489
5490 2018-02-01  Leszek Swirski  <leszeks@google.com>
5491
5492         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
5493         names after a structop as a filename.
5494
5495 2018-02-01  Yao Qi  <yao.qi@linaro.org>
5496
5497         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
5498         (arm_record_coproc_data_proc): Likewise.
5499
5500 2018-02-01  Yao Qi  <yao.qi@linaro.org>
5501
5502         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
5503
5504 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
5505
5506         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
5507         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
5508
5509 2018-01-31  Pedro Alves  <palves@redhat.com>
5510
5511         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
5512         * inflow.c (child_terminal_save_inferior): Wrap reference to
5513         tcgetpgrp in HAVE_TERMIOS_H.
5514         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
5515         _WIN32.
5516         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
5517         always iterate over all inferiors.
5518         (gdbsim_cntrl_c): Adjust.
5519         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
5520
5521 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
5522
5523         * gdbtypes.c (lookup_array_range_type): Make sure the array's
5524         index type is objfile-owned if the element type is as well.
5525
5526 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
5527
5528         GDB 8.1 released.
5529
5530 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5531
5532         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
5533         "features/s390x-linux64.c".
5534         (_initialize_s390_linux_tdep): Remove initialization of tdescs
5535         s390_linux32 and s390x_linux64.
5536         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
5537         default tdesc.
5538         * s390-tdep.c: Include "features/s390-linux32.c" and
5539         "features/s390x-linux64.c".
5540         (s390_tdesc_valid): Add check for tdesc_has_registers.
5541         (s390_gdbarch_init): Make sure there is always a valid tdesc.
5542         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
5543         tdesc_s390x_linux64.
5544         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
5545         tdesc_s390x_linux64 to...
5546         * s390-tdep.h: ...here.
5547
5548 2018-01-30  Pedro Alves  <palves@redhat.com>
5549
5550         PR gdb/13211
5551         * config.in, configure: Regenerate.
5552         * configure.ac: Check for getpgid.
5553         * go32-nat.c (go32_pass_ctrlc): New.
5554         (go32_target): Install it.
5555         * inf-child.c (inf_child_target): Install
5556         child_terminal_save_inferior, child_pass_ctrlc and
5557         child_interrupt.
5558         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
5559         (inf_ptrace_target): No longer install it.
5560         * infcmd.c (interrupt_target_1): Adjust.
5561         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
5562         (child_interrupt): Declare.
5563         (inferior::terminal_state): New.
5564         * inflow.c (struct terminal_info): Update comments.
5565         (inferior_process_group): Delete.
5566         (terminal_is_ours): Delete.
5567         (gdb_tty_state): New.
5568         (child_terminal_init): Adjust.
5569         (is_gdb_terminal, sharing_input_terminal_1)
5570         (sharing_input_terminal): New functions.
5571         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
5572         Set the process's actual process group in the foreground if
5573         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
5574         mark terminal as the inferior's if not sharing GDB's terminal.
5575         Don't check attach_flag.
5576         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
5577         pass down a target_terminal_state.
5578         (child_terminal_save_inferior): New, factored out from ...
5579         (child_terminal_ours_1): ... this.  Handle
5580         target_terminal_state::is_ours_for_output.
5581         (child_interrupt, child_pass_ctrlc): New.
5582         (inflow_inferior_exit): Clear the inferior's terminal_state.
5583         (copy_terminal_info): Copy the inferior's terminal state.
5584         (_initialize_inflow): Remove reference to terminal_is_ours.
5585         * inflow.h (inferior_process_group): Delete.
5586         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
5587         * procfs.c (procfs_target): Don't install procfs_interrupt.
5588         (procfs_interrupt): Delete.
5589         * remote.c (remote_serial_quit_handler): Adjust.
5590         (remote_interrupt): Remove ptid parameter.  Adjust.
5591         * target-delegates.c: Regenerate.
5592         * target.c: Include "terminal.h".
5593         (target_terminal::terminal_state): Rename to ...
5594         (target_terminal::m_terminal_state): ... this.
5595         (target_terminal::init): Adjust.
5596         (target_terminal::inferior): Adjust to per-inferior
5597         terminal_state.
5598         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
5599         (target_terminal::ours, target_terminal::ours_for_output): Use
5600         target_terminal_is_ours_kind.
5601         (target_interrupt): Remove ptid parameter.  Adjust.
5602         (default_target_pass_ctrlc): Adjust.
5603         * target.h (target_ops::to_terminal_save_inferior): New field.
5604         (target_ops::to_interrupt): Remove ptid_t parameter.
5605         (target_interrupt): Remove ptid_t parameter.  Update comment.
5606         (target_pass_ctrlc): Update comment.
5607         * target/target.h (target_terminal_state): New scoped enum,
5608         factored out of ...
5609         (target_terminal::terminal_state): ... here.
5610         (target_terminal::inferior): Update comments.
5611         (target_terminal::restore_inferior): New.
5612         (target_terminal::is_inferior, target_terminal::is_ours)
5613         (target_terminal::is_ours_for_output): Adjust.
5614         (target_terminal::scoped_restore_terminal_state): Adjust to
5615         rename, and call restore_inferior() instead of inferior().
5616         (target_terminal::scoped_restore_terminal_state::m_state): Change
5617         type.
5618         (target_terminal::terminal_state): Rename to ...
5619         (target_terminal::m_terminal_state): ... this and change type.
5620
5621 2018-01-30  Pedro Alves  <palves@redhat.com>
5622
5623         * linux-nat.c (wait_for_signal): New function.
5624         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
5625         directly.
5626         (async_terminal_is_ours)
5627         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
5628         (linux_nat_add_target): Don't override
5629         to_terminal_inferior/to_terminal_ours.
5630
5631 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5632
5633         * remote.c (remote_follow_fork): Don't call "detach_inferior".
5634
5635 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
5636
5637         * dwarf2read.c (free_dwo_files): Add forward-declaration.
5638         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
5639         dwarf2_per_objfile_free here.
5640         (dwarf2_per_objfile_free): Remove.
5641         (_initialize_dwarf2_read): Don't register
5642         dwarf2_per_objfile_free as a registry cleanup.
5643
5644 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
5645
5646         Avoid compilation errors in MinGW native builds
5647
5648         The error is triggered by including python-internal.h, and the
5649         error message is:
5650
5651              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
5652                       from build-gnulib/import/math.h:27,
5653                       from d:/usr/Python26/include/pyport.h:235,
5654                       from d:/usr/Python26/include/Python.h:58,
5655                       from python/python-internal.h:94,
5656                       from python/py-arch.c:24:
5657              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
5658         using ::hypot;
5659                 ^~~~~
5660
5661         This happens because Python headers define 'hypot' to expand t
5662         '_hypot' in the Windows builds.
5663         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
5664         'hypoth'.  This avoids a compilation error.
5665
5666 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
5667
5668         * MAINTAINERS (Write After Approval): Fix ordering.
5669
5670 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
5671
5672         * MAINTAINERS (Write After Approval): Add Alan Hayward.
5673
5674 2018-01-26  Alan Modra  <amodra@gmail.com>
5675
5676         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
5677         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
5678         Remove nop.  Make const.  Comment.
5679         (powerpc32_plt_stub_so_2): New.
5680         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
5681         Correct count.  Update uses.
5682         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
5683         Move common code reading PLT entry word.  Correct
5684         powerpc32_plt_stub PLT address calculation.
5685         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
5686         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
5687         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
5688         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
5689         (ppc64_standard_linkage8): Likewise.
5690         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
5691         Correct insns description.
5692         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
5693
5694 2018-01-24  Pedro Alves  <palves@redhat.com>
5695
5696         GCC PR libstdc++/83906
5697         * gdbtypes.c (operator==(const dynamic_prop &,
5698         const dynamic_prop &)): New.
5699         (operator==(const range_bounds &, const range_bounds &)): New.
5700         (check_types_equal): Use them instead of memcmp.
5701         * gdbtypes.h (operator==(const dynamic_prop &,
5702         const dynamic_prop &)): Declare.
5703         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
5704         (operator==(const range_bounds &, const range_bounds &)): Declare.
5705         (operator!=(const range_bounds &, const range_bounds &)): Declare.
5706
5707 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5708
5709         * s390-linux-tdep.c (s390_record_address_mask)
5710         (s390_record_calc_disp_common, s390_record_calc_disp)
5711         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
5712         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
5713         (s390_process_record): Move to s390-tdep.c.
5714         (s390_linux_init_abi_any): Adjust.
5715         * s390-tdep.c (s390_record_address_mask)
5716         (s390_record_calc_disp_common, s390_record_calc_disp)
5717         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
5718         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
5719         (s390_process_record): Moved from s390-linux-tdep.c
5720         (s390_gdbarch_init): Adjust.
5721
5722 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5723
5724         * s390-linux-nat.c (s390-tdep.h): New include.
5725         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
5726         (HFILES_NO_SRCDIR): Add s390-tdep.h.
5727         (ALLDEPFILES): Add s390-tdep.c.
5728         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
5729         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
5730         * s390-tdep.h: ...this.  New file.
5731         * s390-linux-tdep.c (s390-tdep.h): New include.
5732         (_initialize_s390_tdep): Rename to...
5733         (_initialize_s390_linux_tdep): ...this and adjust.
5734         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
5735         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
5736         s390-tdep.h.
5737         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
5738         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
5739         (s390_is_partial_instruction, s390_software_single_step)
5740         (is_non_branch_ril, s390_displaced_step_copy_insn)
5741         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
5742         (s390_prologue_data, s390_addr, s390_store, s390_load)
5743         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
5744         (s390_register_call_saved, s390_guess_tracepoint_registers)
5745         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
5746         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
5747         (s390_pseudo_register_name, s390_pseudo_register_type)
5748         (s390_pseudo_register_read, s390_pseudo_register_write)
5749         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
5750         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
5751         (s390_addr_bits_remove, s390_address_class_type_flags)
5752         (s390_address_class_type_flags_to_name)
5753         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
5754         (s390_function_arg_float, s390_function_arg_vector)
5755         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
5756         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
5757         (s390_frame_align, s390_register_return_value, s390_return_value)
5758         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
5759         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
5760         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
5761         (s390_trad_frame_prev_register, s390_unwind_cache)
5762         (s390_prologue_frame_unwind_cache)
5763         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
5764         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
5765         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
5766         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
5767         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
5768         (s390_frame_base_address, s390_local_base_address)
5769         (s390_frame_base, s390_gcc_target_options)
5770         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
5771         (s390_validate_reg_range, s390_tdesc_valid)
5772         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
5773         * s390-tdep.c: ...this.  New file.
5774
5775 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5776
5777         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
5778         (s390_process_record, s390_gdbarch_tdep_alloc)
5779         (s390_linux_init_abi_any): Use/set new hook.
5780
5781 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5782
5783         * s390-linux-tdep.c (osabi.h): New include.
5784         (s390_linux_init_abi_31, s390_linux_init_abi_64)
5785         (s390_linux_init_abi_any): New functions.
5786         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
5787
5788 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5789
5790         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
5791         tdesc_has_registers check
5792
5793 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5794
5795         * s390-linux-tdep.c (s390_tdesc_valid): New function.
5796         (s390_validate_reg_range): New macro.
5797         (s390_gdbarch_init): Adjust.
5798
5799 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5800
5801         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
5802         (s390_gdbarch_tdep_alloc): Adjust.
5803         (s390_gdbarch_init): Adjust.
5804
5805 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5806
5807         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
5808         <have_tdb>: Change type to bool.
5809         (s390_gdbarch_tdep_alloc): Adjust.
5810         (s390_gdbarch_init): Adjust.
5811
5812 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5813
5814         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
5815         (gdbarch_tdep) <have_upper, have_vx>: New fields.
5816         (s390_gdbarch_tdep_alloc): New function.
5817         (s390_gdbarch_init): Allocate tdep at start and use its fields
5818         instead of separate variables.
5819
5820 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
5821
5822         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
5823         when looking for cached gdbarch and add comment for remaining.
5824
5825 2018-01-22  Pedro Alves  <palves@redhat.com>
5826             Sergio Durigan Junior  <sergiodj@redhat.com>
5827
5828         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
5829         case.
5830
5831 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
5832
5833         * MAINTAINERS: Update my company e-mail address.
5834
5835 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5836
5837         * regcache.c (cooked_write_test): New function.
5838         (_initialize_regcache): Register the test.
5839
5840 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5841
5842         * ia64-tdep.c (ia64_pseudo_register_read): Call
5843         regcache->cooked_read instead of regcache_cooked_read_unsigned.
5844         * m32c-tdep.c (m32c_cat_read): Likewise.
5845         (m32c_r3r2r1r0_read): Likewise.
5846         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5847         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5848
5849 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5850
5851         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
5852         method raw_read instead of regcache_raw_read.
5853         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5854         * arm-tdep.c (arm_neon_quad_read): Likewise.
5855         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5856         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5857         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5858         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
5859         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5860         (i386_pseudo_register_read_into_value): Likewise.
5861         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5862         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5863         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5864         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
5865         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
5866         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
5867         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5868         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
5869         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
5870
5871 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5872
5873         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
5874         * configure.tgt: Remove target mt.
5875         * mt-tdep.c: Remove.
5876         * regcache.c (cooked_read_test): Remove the check for mt.
5877
5878 2018-01-22  Yao Qi  <yao.qi@linaro.org>
5879
5880         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
5881         instead of gdbarch_pseudo_register_read_value.
5882
5883 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
5884
5885         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
5886         language is Ada.
5887
5888 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
5889
5890         * linespec.c (create_sals_line_offset): Remove code that preserved
5891         the symtab_and_line's line number.
5892
5893 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5894
5895         * varobj.c (varobj_create): Don't set valid_block when creating a
5896         floating varobj.
5897
5898 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5899
5900         * varobj.c (varobj_create): Remove out of date comment.
5901
5902 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5903
5904         PR mi/20395
5905         * ada-exp.y (write_var_from_sym): Pass extra parameter when
5906         updating innermost block.
5907         * parse.c (innermost_block_tracker::update): Take extra type
5908         parameter, and check types match before updating innermost block.
5909         (write_dollar_variable): Update innermost block for registers.
5910         * parser-defs.h (enum innermost_block_tracker_type): New enum.
5911         (innermost_block_tracker::innermost_block_tracker): Initialise
5912         m_types member.
5913         (innermost_block_tracker::reset): Take type parameter.
5914         (innermost_block_tracker::update): Take type parameter, and pass
5915         type through as needed.
5916         (innermost_block_tracker::m_types): New member.
5917         * varobj.c (varobj_create): Pass type when reseting innermost
5918         block.
5919
5920 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5921
5922         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
5923         * ada-lang.c (resolve_subexp): Likewise.
5924         * breakpoint.c (set_breakpoint_condition) Likewise.
5925         (watch_command_1) Likewise.
5926         * c-exp.y (variable): Likewise.
5927         * d-exp.y (PrimaryExpression): Likewise.
5928         * f-exp.y (variable): Likewise.
5929         * go-exp.y (variable): Likewise.
5930         * m2-exp.y (variable): Likewise.
5931         * objfiles.c (objfile::~objfile): Likewise.
5932         * p-exp.y (variable): Likewise.
5933         * parse.c (innermost_block): Change type.
5934         * parser-defs.h (class innermost_block_tracker): New.
5935         (innermost_block): Change to innermost_block_tracker.
5936         * printcmd.c (display_command): Switch to innermost_block API.
5937         (do_one_display): Likewise.
5938         * rust-exp.y (do_one_display): Likewise.
5939         * symfile.c (clear_symtab_users): Likewise.
5940         * varobj.c (varobj_create): Switch to innermost_block API, replace
5941         use of innermost_block with block stored on varobj object.
5942
5943 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5944
5945         * expression.h (innermost_block): Remove declaration.
5946         * varobj.c: Add 'parser-defs.h' include.
5947
5948 2018-01-19  Tom Tromey  <tom@tromey.com>
5949
5950         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
5951         symbols in the static and global blocks.
5952
5953 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
5954
5955         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
5956         gdb_ptrace.h, and move including gdb_wait.h ...
5957         * nat/linux-ptrace.h: ... to here.
5958
5959 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
5960
5961         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
5962         inf_ptrace_detach_success.
5963         (inf_ptrace_detach_success): Add inferior parameter, use it
5964         instead of inferior_ptid, pass it to detach_inferior.
5965         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
5966         parameter.
5967         * inferior.c (detach_inferior): Add overload that takes an
5968         inferior object.
5969         * inferior.h (detach_inferior): Likewise.
5970         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
5971         use inferior_ptid, adjust call to inf_ptrace_detach_success.
5972         * linux-thread-db.c (thread_db_detach): Use inf parameter.
5973
5974 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
5975
5976         * target.h (struct target_ops) <to_detach>: Add inferior
5977         parameter.
5978         (target_detach): Likewise.
5979         * target.c (dispose_inferior): Pass inferior down.
5980         (target_detach): Pass inferior down.  Assert that it is equal to
5981         the current inferior.
5982         * aix-thread.c (aix_thread_detach): Pass inferior down.
5983         * corefile.c (core_file_command): Pass current_inferior() down.
5984         * corelow.c (core_detach): Add inferior parameter.
5985         * darwin-nat.c (darwin_detach): Likewise.
5986         * gnu-nat.c (gnu_detach): Likewise.
5987         * inf-ptrace.c (inf_ptrace_detach): Likewise.
5988         * infcmd.c (detach_command): Pass current_inferior() down to
5989         target_detach.
5990         * infrun.c (follow_fork_inferior): Pass parent_inf to
5991         target_detach.
5992         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
5993         target_detach.
5994         * linux-nat.c (linux_nat_detach): Add inferior parameter.
5995         * linux-thread-db.c (thread_db_detach): Likewise.
5996         * nto-procfs.c (procfs_detach): Likewise.
5997         * procfs.c (procfs_detach): Likewise.
5998         * record.c (record_detach): Likewise.
5999         * record.h (struct inferior): Forward-declare.
6000         (record_detach): Add inferior parameter.
6001         * remote-sim.c (gdbsim_detach): Likewise.
6002         * remote.c (remote_detach_1): Likewise.
6003         (remote_detach): Likewise.
6004         (extended_remote_detach): Likewise.
6005         * sol-thread.c (sol_thread_detach): Likewise.
6006         * target-debug.h (target_debug_print_inferior_p): New macro.
6007         * target-delegates.c: Re-generate.
6008         * top.c (kill_or_detach): Pass inferior down to target_detach.
6009         * windows-nat.c (windows_detach): Add inferior parameter.
6010
6011 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6012
6013         * target.h (struct target_ops) <to_detach>: Remove args
6014         parameter.
6015         (target_detach): Likewise.
6016         * target.c (dispose_inferior): Adjust.
6017         (target_detach): Remove args parameter, adjust.
6018         * aix-thread.c (aix_thread_detach): Adjust.
6019         * corefile.c (core_file_command): Adjust.
6020         * corelow.c (core_detach): Adjust.
6021         * darwin-nat.c (darwin_detach): Adjust.
6022         * gnu-nat.c (gnu_detach): Adjust.
6023         * inf-ptrace.c (inf_ptrace_detach): Adjust.
6024         * infcmd.c (detach_command): Adjust
6025         * infrun.c (follow_fork_inferior): Adjust.
6026         (handle_vfork_child_exec_or_exit): Adjust.
6027         * linux-fork.c (linux_fork_detach): Remove args parameter.
6028         * linux-fork.h (linux_fork_detach): Likewise.
6029         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
6030         * linux-thread-db.c (thread_db_detach): Likewise.
6031         * nto-procfs.c (procfs_detach): Likewise.
6032         * procfs.c (procfs_detach): Likewise.
6033         (do_detach): Remove signo parameter.
6034         * record.c (record_detach): Remove args parameter.
6035         * record.h (record_detach): Likewise.
6036         * remote-sim.c (gdbsim_detach): Likewise.
6037         * remote.c (remote_detach_1): Likewise.
6038         (remote_detach): Likewise.
6039         (extended_remote_detach): Likewise.
6040         * sol-thread.c (sol_thread_detach): Likewise.
6041         * target-delegates.c: Re-generate.
6042         * top.c (struct qt_args) <args>: Remove field.
6043         (kill_or_detach): Don't pass args.
6044         (quit_force): Don't set args.
6045         * windows-nat.c (windows_detach): Remove args parameter.
6046
6047 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6048
6049         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
6050         (arm_linux_init_abi): Install it.
6051
6052 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6053
6054         * osabi.c (gdb_osabi_names): Extend the regexp for
6055         arm-linux-gnueabihf.
6056
6057 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6058
6059         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
6060         m_abbrevs.
6061         (abbrev_table::add_abbrev): Update.
6062         (abbrev_table::lookup_abbrev): Update.
6063
6064 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6065
6066         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
6067
6068 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
6069
6070         * compile/compile.c (compile_to_object): Convert "triplet_rx"
6071         to "std::string".
6072
6073 2018-01-17  Tom Tromey  <tom@tromey.com>
6074
6075         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
6076
6077 2018-01-17  Tom Tromey  <tom@tromey.com>
6078
6079         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
6080         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
6081         (create_array_type_with_stride): Update.
6082         * dwarf2read.c (set_die_type): Update.
6083
6084 2018-01-17  Tom Tromey  <tom@tromey.com>
6085
6086         * dwarf2read.c (delayed_method_info): Remove typedef.
6087         (dwarf2_cu::method_info): Now a std::vector.
6088         (add_to_method_list): Update.
6089         (free_delayed_list): Remove.
6090         (compute_delayed_physnames): Update.
6091         (process_full_comp_unit, process_full_type_unit): Clear the method
6092         list.  Remove cleanups.
6093         (psymtab_include_file_name): Add name_holder parameter.  Use
6094         unique_xmalloc_ptr.
6095         (dwarf_decode_lines): Update.
6096
6097 2018-01-17  Tom Tromey  <tom@tromey.com>
6098             Simon Marchi  <simon.marchi@ericsson.com>
6099
6100         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
6101         (dwarf2_per_objfile::free_cached_comp_units)
6102         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6103         (init_cutu_and_read_dies_no_follow): Update.
6104         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
6105         (dwarf2_cu::~dwarf2_cu): New.
6106         (free_heap_comp_unit, free_stack_comp_unit): Remove.
6107         (age_cached_comp_units, free_one_cached_comp_unit): Update.
6108
6109 2018-01-17  Tom Tromey  <tom@tromey.com>
6110             Simon Marchi  <simon.marchi@ericsson.com>
6111
6112         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
6113         (struct die_reader_specs) <abbrev_table>: New member.
6114         (struct abbrev_table): Add constructor.
6115         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
6116         <abbrev_obstack>: Now an auto_obstack.
6117         (abbrev_table_up): New typedef.
6118         (init_cu_die_reader): Add abbrev_table parameter.
6119         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
6120         Add result_dwo_abbrev_table.
6121         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6122         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
6123         Update.
6124         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
6125         parameter.
6126         (skip_children): Update.
6127         (abbrev_table::alloc_abbrev): Rename from
6128         abbrev_table_alloc_abbrev.
6129         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
6130         (abbrev_table::lookup_abbrev): Rename from
6131         abbrev_table_lookup_abbrev.
6132         (abbrev_table_read_table): Return abbrev_table_up.
6133         (abbrev_table_free, abbrev_table_free_cleanup)
6134         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
6135         (load_partial_dies): Update.
6136
6137 2018-01-17  Tom Tromey  <tom@tromey.com>
6138
6139         * dwarf2read.c (dwarf2_compute_name): Update comment.
6140         (read_func_scope, read_variable): Update.
6141         (new_symbol): Remove.
6142         (new_symbol_full): Rename to new_symbol.
6143
6144 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
6145
6146         PR gdb/16577
6147         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
6148         a warning instead of throwing an error, set section size to 0 and return
6149         NULL.
6150         * gdb_bfd.h (gdb_bfd_map_section): Update description.
6151
6152 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6153
6154         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
6155         std::string.
6156         (linux_ptrace_attach_fail_reason_string): Likewise.
6157         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
6158         Likewise.
6159         (linux_ptrace_attach_fail_reason_string): Likewise.
6160         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
6161
6162 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6163
6164         * linux-nat.c (linux_nat_attach): Remove xstrdup.
6165
6166 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
6167
6168         PR gdb/21559
6169         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
6170         checking for fs_base/gs_base fields in struct user_regs_struct.
6171         * configure: Regenerate.
6172
6173 2018-01-17  Yao Qi  <yao.qi@linaro.org>
6174
6175         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
6176         function.
6177         (aarch64_linux_init_abi): Install it to gdbarch hook
6178         gcc_target_options.
6179
6180 2018-01-15  Pedro Alves  <palves@redhat.com>
6181
6182         * common/signals-state-save-restore.c
6183         (save_original_signals_state): Fix typos.
6184
6185 2017-01-12  Tom Tromey  <tom@tromey.com>
6186             Sergio Durigan Junior  <sergiodj@redhat.com>
6187
6188         * Makefile.in (install-only): Install gdb-add-index.
6189
6190 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
6191
6192         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
6193
6194 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
6195
6196         * infrun.c (keep_going_pass_signal): Clear step-over info when
6197         insert_breakpoints fails.
6198
6199 2018-01-11  Pedro Alves  <palves@redhat.com>
6200
6201         PR gdb/22583
6202         * infrun.c (resume): Rename to ...
6203         (resume_1): ... this.
6204         (resume): Reimplement as wrapper around resume_1.
6205
6206 2018-01-11  Pedro Alves  <palves@redhat.com>
6207
6208         PR remote/22597
6209         * remote.c (remote_parse_stop_reply): Default to the last-set
6210         general thread instead of to 'magic_null_ptid'.
6211
6212 2018-01-10  Pedro Alves  <palves@redhat.com>
6213
6214         * language.h (language_get_symbol_name_matcher): Rename ...
6215         (get_symbol_name_matcher): ... this.
6216         * language.c (language_get_symbol_name_matcher): Ditto.
6217         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
6218         callers adjusted.
6219
6220 2018-01-10  Pedro Alves  <palves@redhat.com>
6221
6222         PR gdb/22670
6223         * dwarf2read.c
6224         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
6225         Adjust to use language_get_symbol_name_matcher instead of
6226         language_defn::la_get_symbol_name_matcher.
6227         * language.c (language_get_symbol_name_matcher): If in Ada mode
6228         and the lookup name is a verbatim match, return Ada's matcher.
6229         * language.h (language_get_symbol_name_matcher): Adjust comment.
6230         (ada_lookup_name_info::verbatim_p):: New method.
6231
6232 2018-01-10  Pedro Alves  <palves@redhat.com>
6233
6234         PR gdb/22670
6235         * ada-lang.c (ada_collect_symbol_completion_matches): If the
6236         minsym's language is language_auto or language_cplus, pass down
6237         language_ada instead.
6238         * symtab.c (compare_symbol_name): Don't frob symbol language here.
6239
6240 2018-01-10  Pedro Alves  <palves@redhat.com>
6241
6242         PR gdb/22670
6243         * minsyms.c (linkage_name_str): New function.
6244         (iterate_over_minimal_symbols): Use it.
6245
6246 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6247
6248         * NEWS: Document that 'info proc' now works on FreeBSD.
6249
6250 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6251
6252         * configure.ac: Check for kinfo_getfile in libutil.
6253         * configure: Regenerate.
6254         * config.in: Regenerate.
6255         * fbsd-nat.c: Include "fbsd-tdep.h".
6256         (fbsd_fetch_cmdline): New.
6257         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
6258         rather than calling error.
6259         (fbsd_info_proc): New.
6260         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
6261         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
6262         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
6263
6264 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6265
6266         * fbsd-nat.c (struct free_deleter): Remove.
6267         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
6268
6269 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6270
6271         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
6272         NULL for an empty pathname.
6273
6274 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6275
6276         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
6277         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
6278         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
6279         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
6280         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
6281         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
6282         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
6283         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
6284         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
6285         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
6286         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
6287         (fbsd_core_fetch_timeval, fbsd_print_sigset)
6288         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
6289         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
6290         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
6291
6292 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
6293
6294         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
6295         (gnu_xfer_auxv): New function.
6296         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
6297         TARGET_OBJECT_AUXV.
6298
6299 2018-01-08  Yao Qi  <yao.qi@linaro.org>
6300             Simon Marchi  <simon.marchi@ericsson.com>
6301
6302         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
6303         common/selftest.c.
6304         (COMMON_OBS): Remove selftest.o.
6305         * configure.ac: Append selftest-arch.c and common/selftest.c to
6306         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
6307         * configure: Re-generated.
6308         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
6309         GDB_SELF_TEST.
6310         (maintenance_info_selftests): Likewise.
6311
6312 2018-01-08  Xavier Roirand  <roirand@adacore.com>
6313
6314         * ada-valprint.c (val_print_packed_array_elements): Use
6315         proper number of elements when printing an array indexed
6316         by an enumeration type.
6317
6318 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6319
6320         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
6321         (dw2_get_file_names_reader): Adjust.
6322         (lookup_dwo_signatured_type): Adjust.
6323         (lookup_dwp_signatured_type): Adjust.
6324         (lookup_signatured_type): Adjust.
6325         (create_type_unit_group): Adjust.
6326         (get_type_unit_group): Adjust.
6327         (process_psymtab_comp_unit_reader): Adjust.
6328         (build_type_psymtabs_reader): Adjust.
6329         (scan_partial_symbols): Adjust.
6330         (add_partial_symbol): Adjust.
6331         (add_partial_subprogram): Adjust.
6332         (peek_die_abbrev): Adjust.
6333         (fixup_go_packaging): Adjust.
6334         (process_imported_unit_die): Adjust.
6335         (dwarf2_compute_name): Adjust.
6336         (dwarf2_physname): Adjust.
6337         (read_import_statement): Adjust.
6338         (handle_DW_AT_stmt_list): Adjust.
6339         (read_file_scope): Adjust.
6340         (read_func_scope): Adjust.
6341         (read_lexical_block_scope): Adjust.
6342         (read_call_site_scope): Adjust.
6343         (read_variable): Adjust.
6344         (dwarf2_rnglists_process): Adjust.
6345         (dwarf2_ranges_process): Adjust.
6346         (dwarf2_ranges_read): Adjust.
6347         (dwarf2_get_pc_bounds): Adjust.
6348         (dwarf2_record_block_ranges): Adjust.
6349         (dwarf2_add_field): Adjust.
6350         (dwarf2_add_member_fn): Adjust.
6351         (read_structure_type): Adjust.
6352         (process_structure_scope): Adjust.
6353         (read_enumeration_type): Adjust.
6354         (read_array_type): Adjust.
6355         (mark_common_block_symbol_computed): Adjust.
6356         (read_common_block): Adjust.
6357         (read_namespace_type): Adjust.
6358         (read_namespace): Adjust.
6359         (read_module_type): Adjust.
6360         (read_tag_pointer_type): Adjust.
6361         (read_tag_ptr_to_member_type): Adjust.
6362         (read_tag_string_type): Adjust.
6363         (read_subroutine_type): Adjust.
6364         (read_typedef): Adjust.
6365         (read_base_type): Adjust.
6366         (attr_to_dynamic_prop): Adjust.
6367         (read_subrange_type): Adjust.
6368         (read_unspecified_type): Adjust.
6369         (dwarf2_read_abbrevs): Adjust.
6370         (load_partial_dies): Adjust.
6371         (read_partial_die): Adjust.
6372         (find_partial_die): Adjust.
6373         (guess_partial_die_structure_name): Adjust.
6374         (fixup_partial_die): Adjust.
6375         (read_attribute_value): Adjust.
6376         (read_addr_index): Adjust.
6377         (read_addr_index_from_leb128): Adjust.
6378         (read_str_index): Adjust.
6379         (dwarf2_string_attr): Adjust.
6380         (get_debug_line_section): Adjust.
6381         (dwarf_decode_line_header): Adjust.
6382         (lnp_state_machine::check_line_address): Adjust.
6383         (dwarf_decode_lines_1): Adjust.
6384         (dwarf_decode_lines): Adjust.
6385         (dwarf2_start_symtab): Adjust.
6386         (var_decode_location): Adjust.
6387         (new_symbol_full): Adjust.
6388         (dwarf2_const_value_data): Adjust.
6389         (dwarf2_const_value_attr): Adjust.
6390         (dwarf2_const_value): Adjust.
6391         (die_type): Adjust.
6392         (die_containing_type): Adjust.
6393         (build_error_marker_type): Adjust.
6394         (lookup_die_type): Adjust.
6395         (guess_full_die_structure_name): Adjust.
6396         (anonymous_struct_prefix): Adjust.
6397         (determine_prefix): Adjust.
6398         (dwarf2_name): Adjust.
6399         (follow_die_ref_or_sig): Adjust.
6400         (follow_die_offset): Adjust.
6401         (follow_die_ref): Adjust.
6402         (follow_die_sig_1): Adjust.
6403         (follow_die_sig): Adjust.
6404         (get_signatured_type): Adjust.
6405         (get_DW_AT_signature_type): Adjust.
6406         (decode_locdesc): Adjust.
6407         (dwarf_decode_macros): Adjust.
6408         (cu_debug_loc_section): Adjust.
6409         (fill_in_loclist_baton): Adjust.
6410         (dwarf2_symbol_mark_computed): Adjust.
6411         (init_one_comp_unit): Don't assign
6412         dwarf2_cu::dwarf2_per_objfile.
6413         (set_die_type): Adjust.
6414
6415 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6416
6417         * dwarf2read.c (struct mapped_debug_names): Add constructor.
6418         <dwarf2_per_objfile>: New field.
6419         (dwarf2_per_objfile): Remove global.
6420         (get_dwarf2_per_objfile): New function.
6421         (set_dwarf2_per_objfile): New function.
6422         (dwarf2_build_psymtabs_hard): Change objfile parameter to
6423         dwarf2_per_objfile.
6424         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
6425         (read_abbrev_offset): Likewise.
6426         (read_indirect_string): Likewise.
6427         (read_indirect_line_string): Likewise.
6428         (read_indirect_string_at_offset): Likewise.
6429         (read_indirect_string_from_dwz): Likewise.
6430         (dwarf2_find_containing_comp_unit): Change objfile parameter to
6431         dwarf2_per_objfile.
6432         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
6433         (create_all_comp_units): Change objfile parameter to
6434         dwarf2_per_objfile.
6435         (create_all_type_units): Likewise.
6436         (process_queue): Add dwarf2_per_objfile parameter.
6437         (read_and_check_comp_unit_head): Likewise.
6438         (lookup_dwo_unit_in_dwp): Likewise.
6439         (get_dwp_file): Likewise.
6440         (process_cu_includes): Likewise.
6441         (struct free_dwo_file_cleanup_data): New struct.
6442         (dwarf2_has_info): Use get_dwarf2_per_objfile and
6443         set_dwarf2_per_objfile.
6444         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
6445         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
6446         context, adjust calls.
6447         (dw2_instantiate_symtab): Likewise.
6448         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
6449         (dw2_get_cu): Likewise.
6450         (create_cu_from_index_list): Change objfile parameter to
6451         dwarf2_per_objfile.
6452         (create_cus_from_index_list): Get dwarf2_per_objfile from
6453         context, adjust calls.
6454         (create_cus_from_index): Likewise.
6455         (create_signatured_type_table_from_index): Change objfile
6456         parameter to dwarf2_per_objfile.
6457         (create_signatured_type_table_from_debug_names): Change objfile
6458         parameter to dwarf2_per_objfile.
6459         (create_addrmap_from_index): Likewise.
6460         (create_addrmap_from_aranges): Likewise.
6461         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
6462         (dw2_setup): Remove.
6463         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
6464         context.
6465         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
6466         get_dwarf2_per_objfile.
6467         (dw2_forget_cached_source_info): Likewise.
6468         (dw2_map_symtabs_matching_filename): Likewise.
6469         (struct dw2_symtab_iterator) <index>: Remove.
6470         <dwarf2_per_objfile>: New field.
6471         (dw2_symtab_iter_init): Replace index parameter with
6472         dwarf2_per_objfile.
6473         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
6474         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
6475         (dw2_print_stats): Likewise.
6476         (dw2_dump): Likewise.
6477         (dw2_expand_symtabs_for_function): Likewise.
6478         (dw2_expand_all_symtabs): Likewise.
6479         (dw2_expand_symtabs_with_fullname): Likewise.
6480         (dw2_expand_marked_cus): Replace index and objfile parameters
6481         with dwarf2_per_objfile.
6482         (dw_expand_symtabs_matching_file_matcher): Add
6483         dwarf2_per_objfile parameter and adjust calls.
6484         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
6485         adjust calls.
6486         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
6487         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
6488         adjust calls.
6489         (create_cus_from_debug_names_list): Replace objfile parameter
6490         with dwarf2_per_objfile and adjust calls.
6491         (create_cus_from_debug_names): Likewise.
6492         (dwarf2_read_debug_names): Likewise.
6493         (mapped_debug_names::namei_to_name): Adjust call.
6494         (dw2_debug_names_iterator::next): Likewise.
6495         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
6496         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
6497         (dw2_debug_names_dump): Likewise.
6498         (dw2_debug_names_expand_symtabs_for_function): Likewise.
6499         (dw2_debug_names_expand_symtabs_matching): Likewise.
6500         (dwarf2_initialize_objfile): Likewise.
6501         (dwarf2_build_psymtabs): Likewise.
6502         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
6503         this_cu.
6504         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
6505         (read_and_check_comp_unit_head): Likewise.
6506         (read_abbrev_offset): Likewise.
6507         (create_debug_type_hash_table): Likewise.
6508         (create_debug_types_hash_table): Likewise.
6509         (create_all_type_units): Replace objfile parameter with
6510         dwarf2_per_objfile.
6511         (add_type_unit): Add dwarf2_per_objfile parameter.
6512         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
6513         with dwarf2_per_objfile.
6514         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
6515         (lookup_dwp_signatured_type): Likewise.
6516         (lookup_signatured_type): Likewise.
6517         (read_cutu_die_from_dwo): Likewise.
6518         (init_tu_and_read_dwo_dies): Likewise.
6519         (init_cutu_and_read_dies): Likewise.
6520         (init_cutu_and_read_dies_no_follow): Likewise.
6521         (allocate_type_unit_groups_table): Add objfile parameter.
6522         (create_type_unit_group): Use dwarf2_per_objfile from cu.
6523         (get_type_unit_group): Likewise.
6524         (process_psymtab_comp_unit): Update call.
6525         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
6526         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
6527         (print_tu_stats): Likewise.
6528         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
6529         in void* parameter.
6530         (build_type_psymtabs): Change objfile parameter to
6531         dwarf2_per_objfile.
6532         (process_skeletonless_type_unit): Use dwarf2_per_objfile
6533         passed in void* parameter.
6534         (process_skeletonless_type_units): Change objfile parameter to
6535         dwarf2_per_objfile.
6536         (set_partial_user): Likewise.
6537         (dwarf2_build_psymtabs_hard): Likewise.
6538         (read_comp_units_from_section): Likewise.
6539         (create_all_comp_units): Likewise.
6540         (scan_partial_symbols): Update calls.
6541         (add_partial_symbol): Likewise.
6542         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
6543         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
6544         (process_queue): Add dwarf2_per_objfile parameter.
6545         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
6546         (compute_compunit_symtab_includes): Likewise.
6547         (process_cu_includes): Add dwarf2_per_objfile parameter.
6548         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
6549         (process_full_type_unit): Likewise.
6550         (process_imported_unit_die): Update call.
6551         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
6552         (read_file_scope): Likewise.
6553         (allocate_dwo_file_hash_table): Add objfile parameter.
6554         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
6555         (create_cus_hash_table): Likewise.
6556         (create_dwp_hash_table): Likewise.
6557         (create_dwo_unit_in_dwp_v1): Likewise.
6558         (create_dwp_v2_section): Likewise.
6559         (create_dwo_unit_in_dwp_v2): Likewise.
6560         (lookup_dwo_unit_in_dwp): Likewise.
6561         (try_open_dwop_file): Likewise.
6562         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
6563         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
6564         cleanup to include a reference to dwarf2_per_objfile.
6565         (open_dwp_file): Add dwarf2_per_objfile parameter.
6566         (open_and_init_dwp_file): Likewise.
6567         (get_dwp_file): Likewise.
6568         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
6569         (queue_and_load_all_dwo_tus): Update call.
6570         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
6571         data.
6572         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
6573         (dwarf2_ranges_process): Likewise.
6574         (dwarf2_get_pc_bounds): Likewise.
6575         (mark_common_block_symbol_computed): Likewise.
6576         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
6577         (dwarf2_read_abbrevs): Update call.
6578         (read_partial_die): Use dwarf2_per_objfile from cu.
6579         (find_partial_die): Likewise.
6580         (fixup_partial_die): Likewise.
6581         (read_attribute_value): Likewise.
6582         (read_indirect_string_at_offset_from): Add objfile parameter.
6583         (read_indirect_string_at_offset): Add dwarf2_per_objfile
6584         parameter.
6585         (read_indirect_string_from_dwz): Add objfile parameter.
6586         (read_indirect_string): Add objfile parameter.
6587         (read_addr_index_1): Add dwarf2_per_objfile parameter.
6588         (read_addr_index): Use dwarf2_per_objfile from cu.
6589         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
6590         call dw2_setup.
6591         (read_str_index): Use dwarf2_per_objfile from cu.
6592         (get_debug_line_section): Likewise.
6593         (read_formatted_entries): Add dwarf2_per_objfile parameter.
6594         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
6595         (new_symbol_full): Use dwarf2_per_objfile from cu.
6596         (build_error_marker_type): Likewise.
6597         (lookup_die_type): Likewise.
6598         (determine_prefix): Likewise.
6599         (follow_die_offset): Likewise.
6600         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
6601         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
6602         (dwarf2_fetch_die_type_sect_off): Likewise.
6603         (dwarf2_get_die_type): Likewise.
6604         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
6605         (get_signatured_type): Likewise.
6606         (get_DW_AT_signature_type): Likewise.
6607         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
6608         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
6609         (cu_debug_loc_section): Likewise.
6610         (fill_in_loclist_baton): Likewise.
6611         (dwarf2_symbol_mark_computed): Likewise.
6612         (dwarf2_find_containing_comp_unit): Change objfile parameter to
6613         dwarf2_per_objfile.
6614         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
6615         parameter.
6616         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
6617         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
6618         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
6619         (set_die_type): Use dwarf2_free_objfile from cu.
6620         (get_die_type_at_offset): Likewise.
6621         (dwarf2_per_objfile_free): Don't assign global variable.
6622         (debug_names) <constructor>: Add dwarf2_per_objfile
6623         parameter, update m_debugstrlookup construction.
6624         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
6625         parameter.
6626         <m_dwarf2_per_objfile>: New field.
6627         <lookup>: Use m_dwarf2_per_objfile.
6628         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
6629         (psyms_seen_size): Likewise.
6630         (write_gdbindex): Replace objfile parameter with
6631         dwarf2_per_objfile.
6632         (write_debug_names): Likewise.
6633         (write_psymtabs_to_index): Likewise.
6634         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
6635         calls.
6636
6637 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6638
6639         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
6640         <dwarf2_per_objfile>: New field.
6641         (struct dwarf2_per_cu_data) <objfile>: Remove.
6642         <dwarf2_per_objfile>: New field.
6643         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
6644         of objfile.
6645         (create_signatured_type_table_from_index): Likewise.
6646         (create_debug_type_hash_table): Likewise.
6647         (fill_in_sig_entry_from_dwo_entry): Likewise.
6648         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
6649         (create_type_unit_group): Assign dwarf2_per_objfile instead of
6650         objfile.
6651         (create_partial_symtab): Access objfile through
6652         dwarf2_per_objfile.
6653         (process_psymtab_comp_unit_reader): Likewise.
6654         (read_comp_units_from_section): Likewise.
6655         (scan_partial_symbols): Likewise.
6656         (add_partial_symbol): Likewise.
6657         (add_partial_subprogram): Likewise.
6658         (peek_die_abbrev): Likewise.
6659         (fixup_go_packaging): Likewise.
6660         (process_full_comp_unit): Likewise.
6661         (process_full_type_unit): Likewise.
6662         (process_imported_unit_die): Likewise.
6663         (dwarf2_compute_name): Likewise.
6664         (dwarf2_physname): Likewise.
6665         (read_import_statement): Likewise.
6666         (create_cus_hash_table): Assign dwarf2_physname instead of
6667         objfile.
6668         (read_func_scope): Access objfile through dwarf2_per_objfile.
6669         (read_lexical_block_scope): Likewise.
6670         (read_call_site_scope): Likewise.
6671         (read_variable): Likewise.
6672         (dwarf2_rnglists_process): Likewise.
6673         (dwarf2_ranges_process): Likewise.
6674         (dwarf2_ranges_read): Likewise.
6675         (dwarf2_record_block_ranges): Likewise.
6676         (dwarf2_add_field): Likewise.
6677         (dwarf2_add_member_fn): Likewise.
6678         (read_structure_type): Likewise.
6679         (process_structure_scope): Likewise.
6680         (read_enumeration_type): Likewise.
6681         (read_array_type): Likewise.
6682         (read_common_block): Likewise.
6683         (read_namespace_type): Likewise.
6684         (read_namespace): Likewise.
6685         (read_module_type): Likewise.
6686         (read_tag_pointer_type): Likewise.
6687         (read_tag_ptr_to_member_type): Likewise.
6688         (read_tag_string_type): Likewise.
6689         (read_subroutine_type): Likewise.
6690         (read_typedef): Likewise.
6691         (read_base_type): Likewise.
6692         (attr_to_dynamic_prop): Likewise.
6693         (read_subrange_type): Likewise.
6694         (read_unspecified_type): Likewise.
6695         (load_partial_dies): Likewise.
6696         (read_partial_die): Likewise.
6697         (find_partial_die): Likewise.
6698         (guess_partial_die_structure_name): Likewise.
6699         (fixup_partial_die): Likewise.
6700         (read_attribute_value): Likewise.
6701         (read_addr_index_from_leb128): Likewise.
6702         (dwarf2_read_addr_index): Likewise.
6703         (dwarf2_string_attr): Likewise.
6704         (lnp_state_machine::check_line_address): Likewise.
6705         (dwarf_decode_lines_1): Likewise.
6706         (dwarf_decode_lines): Likewise.
6707         (dwarf2_start_symtab): Likewise.
6708         (var_decode_location): Likewise.
6709         (new_symbol_full): Likewise.
6710         (dwarf2_const_value_data): Likewise.
6711         (dwarf2_const_value_attr): Likewise.
6712         (dwarf2_const_value): Likewise.
6713         (die_type): Likewise.
6714         (die_containing_type): Likewise.
6715         (lookup_die_type): Likewise.
6716         (guess_full_die_structure_name): Likewise.
6717         (anonymous_struct_prefix): Likewise.
6718         (dwarf2_name): Likewise.
6719         (follow_die_ref_or_sig): Likewise.
6720         (follow_die_offset): Likewise.
6721         (follow_die_ref): Likewise.
6722         (dwarf2_fetch_die_loc_sect_off): Likewise.
6723         (dwarf2_fetch_constant_bytes): Likewise.
6724         (dwarf2_fetch_die_type_sect_off): Likewise.
6725         (dwarf2_get_die_type): Likewise.
6726         (follow_die_sig): Likewise.
6727         (decode_locdesc): Likewise.
6728         (dwarf2_per_cu_objfile): Likewise.
6729         (dwarf2_per_cu_text_offset): Likewise.
6730         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
6731         objfile.
6732         (set_die_type): Access objfile through
6733         dwarf2_per_objfile.
6734
6735 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
6736
6737         * valprint.c (converted_character_d): Remove typedef.
6738         (DEF_VEC_O (converted_character_d)): Remove.
6739         (count_next_character): Use std::vector.
6740         (print_converted_chars_to_obstack): Likewise.
6741         (generic_printstr): Likewise.
6742
6743 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6744
6745         * xml-support.h (struct gdb_xml_value): Add constructor.
6746         <value>: Change type to unique_xmalloc_ptr.
6747         (gdb_xml_value_s): Remove typedef.
6748         (DEF_VEC_O (gdb_xml_value_s)): Remove.
6749         (gdb_xml_element_start_handler): Change parameter type to
6750         std::vector.
6751         (xml_find_attribute): Likewise.
6752         * xml-support.c (xml_find_attribute): Change parameter type to
6753         std::vector and adjust.
6754         (gdb_xml_values_cleanup): Remove.
6755         (gdb_xml_parser::start_element): Adjust to std::vector.
6756         (xinclude_start_include): Change paraeter type to std::vector
6757         and adjust.
6758         * btrace.c (check_xml_btrace_version): Likewise.
6759         (parse_xml_btrace_block): Likewise.
6760         (parse_xml_btrace_pt_config_cpu): Likewise.
6761         (parse_xml_btrace_pt): Likewise.
6762         (parse_xml_btrace_conf_bts): Likewise.
6763         (parse_xml_btrace_conf_pt): Likewise.
6764         * memory-map.c (memory_map_start_memory): Likewise.
6765         (memory_map_start_property): Likewise.
6766         * osdata.c (osdata_start_osdata): Likewise.
6767         (osdata_start_item): Likewise.
6768         (osdata_start_column): Likewise.
6769         * remote.c (start_thread): Likewise.
6770         * solib-aix.c (library_list_start_library): Likewise.
6771         (library_list_start_list): Likewise.
6772         * solib-svr4.c (library_list_start_library): Likewise.
6773         (svr4_library_list_start_list): Likewise.
6774         * solib-target.c (library_list_start_segment): Likewise.
6775         (library_list_start_section): Likewise.
6776         (library_list_start_library): Likewise.
6777         (library_list_start_list): Likewise.
6778         * tracepoint.c (traceframe_info_start_memory): Likewise.
6779         (traceframe_info_start_tvar): Likewise.
6780         * xml-syscall.c (syscall_start_syscall): Likewise.
6781         * xml-tdesc.c (tdesc_start_target): Likewise.
6782         (tdesc_start_feature): Likewise.
6783         (tdesc_start_reg): Likewise.
6784         (tdesc_start_union): Likewise.
6785         (tdesc_start_struct): Likewise.
6786         (tdesc_start_flags): Likewise.
6787         (tdesc_start_enum): Likewise.
6788         (tdesc_start_field): Likewise.
6789         (tdesc_start_enum_value): Likewise.
6790         (tdesc_start_vector): Likewise.
6791
6792 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6793
6794         * extension.h (struct xmethod_worker) <clone>: Remove.
6795         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
6796         Remove.
6797         (python_xmethod_worker::clone): Remove.
6798         * valops.c (find_overload_match): Use std::move instead of
6799         clone.
6800
6801 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6802
6803         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
6804         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
6805         <free_xmethod_worker_data>: Remove.
6806         <get_matching_xmethod_workers>: Chance VEC to std::vector.
6807         <get_xmethod_arg_types>: Remove.
6808         <get_xmethod_result_type>: Remove.
6809         <invoke_xmethod>: Remove.
6810         * extension.c (new_xmethod_worker): Remove.
6811         (clone_xmethod_worker): Remove.
6812         (get_matching_xmethod_workers): Return void, pass std::vector by
6813         pointer.
6814         (get_xmethod_arg_types): Rename to...
6815         (xmethod_worker::get_arg_types): ... this, and adjust.
6816         (get_xmethod_result_type): Rename to...
6817         (xmethod_worker::get_result_type): ... this, and adjust.
6818         (invoke_xmethod): Remove.
6819         (free_xmethod_worker): Remove.
6820         (free_xmethod_worker_vec): Remove.
6821         * extension.h (enum ext_lang_rc): Move here from
6822         extension-priv.h.
6823         (struct xmethod_worker): Add constructor and destructor.
6824         <data>: Remove.
6825         <value>: Remove.
6826         <invoke, clone, do_get_result_type, do_get_arg_types>: New
6827         virtual pure methods.
6828         <get_arg_types, get_result_type>: New methods.
6829         (xmethod_worker_ptr): Remove typedef.
6830         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
6831         (xmethod_worker_vec): Remove typedef.
6832         (xmethod_worker_up): New typedef.
6833         (invoke_xmethod): Remove.
6834         (clone_xmethod_worker): Remove.
6835         (free_xmethod_worker): Remove.
6836         (free_xmethod_worker_vec): Remove.
6837         (get_xmethod_arg_types): Remove.
6838         (get_xmethod_result_type): Remove.
6839         * valops.c (find_method_list): Use std::vector, don't use
6840         intermediate vector.
6841         (value_find_oload_method_list): Use std::vector.
6842         (find_overload_match): Use std::vector.
6843         (find_oload_champ): Use std::vector.
6844         * value.c (value_free): Use operator delete.
6845         (value_of_xmethod): Rename to...
6846         (value_from_xmethod): ... this.  Don't assign
6847         xmethod_worker::value, take rvalue-reference.
6848         (result_type_of_xmethod): Adjust.
6849         (call_xmethod): Adjust.
6850         * value.h: Include extension.h.
6851         (struct xmethod_worker): Don't forward-declare.
6852         (value_of_xmethod): Rename to...
6853         (value_from_xmethod): ... this, take rvalue-reference.
6854         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
6855         (struct python_xmethod_worker): ... this, add constructor and
6856         destructor.
6857         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
6858         (gdbpy_free_xmethod_worker_data): Rename to...
6859         (python_xmethod_worker::~python_xmethod_worker): ... this and
6860         adjust.
6861         (gdbpy_clone_xmethod_worker_data): Rename to...
6862         (python_xmethod_worker::clone): ... this and adjust.
6863         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
6864         temporary vector.
6865         (gdbpy_get_xmethod_arg_types): Rename to...
6866         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
6867         (gdbpy_get_xmethod_result_type): Rename to...
6868         (python_xmethod_worker::do_get_result_type): ... this and
6869         adjust.
6870         (gdbpy_invoke_xmethod): Rename to...
6871         (python_xmethod_worker::invoke): ... this and adjust.
6872         (new_python_xmethod_worker): Rename to...
6873         (python_xmethod_worker::python_xmethod_worker): ... this and
6874         adjust.
6875         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
6876         Remove.
6877         (gdbpy_free_xmethod_worker_data): Remove.
6878         (gdbpy_get_matching_xmethod_workers): Use std::vector.
6879         (gdbpy_get_xmethod_arg_types): Remove.
6880         (gdbpy_get_xmethod_result_type): Remove.
6881         (gdbpy_invoke_xmethod): Remove.
6882         * python/python.c (python_extension_ops): Remove obsolete
6883         callbacks.
6884
6885 2018-01-05  Pedro Alves  <palves@redhat.com>
6886
6887         PR gdb/18653
6888         * common/signals-state-save-restore.c
6889         (save_original_signals_state): New parameter 'quiet'.  Warn if we
6890         find a custom handler preinstalled, instead of internal erroring.
6891         But only warn if !quiet.
6892         * common/signals-state-save-restore.h
6893         (save_original_signals_state): New parameter 'quiet'.
6894         * main.c (captured_main_1): Move save_original_signals_state call
6895         after option handling, and pass QUIET.
6896
6897 2018-01-05  Pedro Alves  <palves@redhat.com>
6898
6899         * spu-tdep.c (spu_catch_start): Pass
6900         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
6901
6902 2018-01-05  Pedro Alves  <palves@redhat.com>
6903
6904         PR gdb/22670
6905         * ada-lang.c (literal_symbol_name_matcher): New function.
6906         (ada_get_symbol_name_matcher): Use it for
6907         symbol_name_match_type::SEARCH_NAME.
6908         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
6909         it down instead of assuming symbol_name_match_type::FULL.
6910         * block.h (block_lookup_symbol): New parameter 'match_type'.
6911         * c-valprint.c (print_unpacked_pointer): Use
6912         lookup_symbol_search_name instead of lookup_symbol.
6913         * compile/compile-object-load.c (get_out_value_type): Pass down
6914         symbol_name_match_type::SEARCH_NAME.
6915         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
6916         symbol_name_match_type::FULL.
6917         * cp-support.c (cp_get_symbol_name_matcher): Handle
6918         symbol_name_match_type::SEARCH_NAME.
6919         * infrun.c (insert_exception_resume_breakpoint): Use
6920         lookup_symbol_search_name.
6921         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
6922         * psymtab.c (maintenance_check_psymtabs): Use
6923         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
6924         * stack.c (print_frame_args): Use lookup_symbol_search_name and
6925         SYMBOL_SEARCH_NAME.
6926         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
6927         if symbol_name_match_type::SEARCH_NAME.
6928         (lookup_symbol_in_language): Pass down
6929         symbol_name_match_type::FULL.
6930         (lookup_symbol_search_name): New.
6931         (lookup_language_this): Pass down
6932         symbol_name_match_type::SEARCH_NAME.
6933         (lookup_symbol_aux, lookup_local_symbol): New parameter
6934         'match_type'.  Pass it down.
6935         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
6936         (lookup_symbol_search_name): New declaration.
6937         (lookup_symbol_in_block): New 'match_type' parameter.
6938
6939 2018-01-05  Pedro Alves  <palves@redhat.com>
6940
6941         PR gdb/22670
6942         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
6943         ada_lookup_symbol.
6944         (ada_lookup_symbol): Reimplement in terms of
6945         ada_lookup_symbol_list, bits factored out from
6946         ada_lookup_encoded_symbol.
6947
6948 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
6949
6950         * ada-exp.y (write_object_renaming): When subscripting an array
6951         using a symbol as the index, pass the block in call to
6952         ada_lookup_encoded_symbol when looking that symbol up.
6953
6954 2018-01-05  Jerome Guitton  <guitton@adacore.com>
6955
6956         * ada-lang.c (ada_array_length): Use ada_index_type instead of
6957         TYPE_INDEX_TYPE.
6958
6959 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
6960
6961         * ada-lang.c (ada_to_fixed_value_create): Add handling of
6962         the case where VALUE_LVAL (val0) is not lval_memory.
6963
6964 2018-01-05  Xavier Roirand  <roirand@adacore.com>
6965
6966         * ada-valprint.c (print_optional_low_bound): Handle
6967         character-indexed array printing like boolean-indexed array
6968         printing.
6969
6970 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
6971
6972         * NEWS: Create a new section for the next release branch.
6973         Rename the section of the current branch, now that it has
6974         been cut.
6975
6976 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
6977
6978         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
6979         * version.in: Bump version to 8.1.50.DATE-git.
6980
6981 2018-01-03  Xavier Roirand  <roirand@adacore.com>
6982
6983         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
6984         Add field.
6985         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
6986         Add field.
6987         (default_exception_support_info) <catch_handlers_sym>: Add field.
6988         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
6989         (ada_exception_name_addr_1): Add "catch handlers" handling.
6990         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
6991         Update all callers.
6992         (create_excep_cond_exprs) <ex>: Add parameter.
6993         (re_set_exception): Update create_excep_cond_exprs call.
6994         (print_it_exception, print_one_exception, print_mention_exception)
6995         (print_recreate_exception): Add "catch handler" handling.
6996         (allocate_location_catch_handlers, re_set_catch_handlers)
6997         (check_status_catch_handlers, print_it_catch_handlers)
6998         (print_one_catch_handlers, print_mention_catch_handlers)
6999         (print_recreate_catch_handlers): New function.
7000         (catch_handlers_breakpoint_ops): New variable.
7001         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
7002         Add parameter.  Add "catch handler" handling.
7003         (ada_exception_sym_name, ada_exception_breakpoint_ops):
7004         Add "catch handler" handling.
7005         (ada_exception_catchpoint_cond_string): Add "catch handler"
7006         handling.
7007         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
7008         call.
7009         (catch_ada_handlers_command): New function.
7010         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
7011         operations structure.
7012         (_initialize_ada_language): Add "catch handlers" command entry.
7013         * NEWS: Document "catch handlers" feature.
7014
7015 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7016
7017         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
7018         account when creating the array type of the slice.
7019         (ada_value_slice): Likewise.
7020
7021 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7022
7023         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
7024         New enum value.
7025         (create_array_type_with_stride): Add byte_stride_prop parameter.
7026         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
7027         New parameter.  Update all callers in this file.
7028         (array_type_has_dynamic_stride): New function.
7029         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
7030         of arrays with dynamic byte strides.
7031         * dwarf2read.c (read_array_type): Add support for dynamic
7032         DW_AT_byte_stride attributes.
7033
7034 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7035
7036         * dwarf2read.c (read_unspecified_type): Treat
7037         DW_TAG_enumeration_type DIEs from Ada units as stubs.
7038
7039 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7040
7041         Update copyright year range in all GDB files.
7042
7043 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7044
7045         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
7046         and gdb/testsuite/gdb.base/step-line.c.
7047
7048 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7049
7050         * copyright.py (main): Dump the contents of
7051         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
7052         even if BY_HAND is empty.
7053
7054 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7055
7056         * top.c (print_gdb_version): Update Copyright year in version
7057         message.
7058
7059 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7060
7061         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
7062
7063 For older changes see ChangeLog-2017.
7064 \f
7065 Local Variables:
7066 mode: change-log
7067 left-margin: 8
7068 fill-column: 74
7069 version-control: never
7070 coding: utf-8
7071 End: