Document the GDB 8.2.91 release in gdb/ChangeLog
[external/binutils.git] / gdb / ChangeLog
1 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2
3         GDB 8.2.91 released.
4
5 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6
7         * version.in: Set GDB version number to 8.2.91.
8
9 2019-03-20  Tom Tromey  <tromey@adacore.com>
10
11         PR gdb/24391
12         * infrun.c (handle_inferior_event): Rename from
13         handle_inferior_event_1.  Create a scoped_value_mark.
14         (handle_inferior_event): Remove.
15
16 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
17
18         * source-cache.c (source_cache::get_source_lines): Re-read
19         fullname after calling open_source_file.
20
21 2019-03-18  Pedro Alves  <palves@redhat.com>
22             Eli Zaretskii <eliz@gnu.org>
23
24         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
25         m_line and m_start_of_line.
26
27 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
28
29         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
30         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
31         it returns a newline.  This fixes a regression in TU mode, whereby
32         the next line is output on the same screen line as the user input.
33
34 2019-03-18  Pedro Alves  <palves@redhat.com>
35
36         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
37         New globals.
38         (apply_style): New, factored out from ...
39         (apply_ansi_escape): ... this.  Handle reverse video mode.
40         (tui_set_reverse_mode): New function.
41         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
42         * tui/tui-winsource.c (tui_show_source_line): Use
43         tui_set_reverse_mode instead of setting A_STANDOUT.
44         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
45         New setter methods.
46
47 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
48
49         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
50         Handle tabs.
51
52 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
53
54         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
55         tui_refill_source_window instead of tui_refresh_win, to update the
56         current execution line.  This fixes redisplay of the current line
57         when stepping through the code with "next" or "step".
58
59 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
60
61         * source-cache.c (source_cache::get_source_lines): Call
62         find_source_lines to initialize s->nlines.  This fixes vertical
63         scrolling of TUI source window when the DOWN arrow is pressed.
64
65 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
66
67         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
68         wclrtoeol in tui_show_source_line".  This reverts changes made in
69         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
70
71 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
72
73         * NEWS: Combine separate "New targets" sections for 8.3.
74
75 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
76
77         The MS-Windows port of ncurses fails to switch to a color pair if
78         one or both of the colors are the implicit default colors.  This
79         change records the default colors when TUI is initialized, and
80         then specifies them explicitly when a color pair uses the default
81         colors.  This allows color styling in TUI mode on MS-Windows.
82
83         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
84         ncurses_norm_attr.
85         (tui_initialize_io) [__MINGW32__]: Record the default terminal
86         colors in ncurses_norm_attr.
87         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
88         "none", replace it with the default color recorded in
89         ncurses_norm_attr.
90
91 2019-03-14  Tom Tromey  <tromey@adacore.com>
92
93         * source-cache.h (class source_cache) <get_source_lines>: Return
94         std::string.
95         * source-cache.c (source_cache::extract_lines): Handle case where
96         first_pos==npos.  Return std::string.
97         (source_cache::get_source_lines): Update.
98
99 2019-03-14  Tom Tromey  <tromey@adacore.com>
100
101         * NEWS: Add item for "style sources" commands.
102         * source-cache.c (source_cache::get_source_lines): Check
103         source_styling.
104         * cli/cli-style.c (source_styling): New global.
105         (_initialize_cli_style): Add "style sources" commands.
106         (show_style_sources): New function.
107         * cli/cli-style.h (source_styling): Declare.
108
109 2019-03-14  Pedro Alves  <palves@redhat.com>
110             Tom Tromey  <tromey@adacore.com>
111
112         * tui/tui-winsource.h (tui_refill_source_window): Declare.
113         * tui/tui-winsource.c (tui_refill_source_window): New function,
114         from...
115         (tui_horizontal_source_scroll): ... here.  Move some logic.
116         * cli/cli-style.c (set_style_enabled): Notify new observable.
117         * tui/tui-hooks.c (tui_redisplay_source): New function.
118         (tui_attach_detach_observers): Attach or detach
119         tui_redisplay_source.
120         * observable.h (source_styling_changed): New observable.
121         * observable.c: Define source_styling_changed observable.
122
123 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
124
125         PR/24325
126         * source-cache.c: #undef open and close, to avoid unresolved
127         externals during linking.
128
129 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
130
131         Support styling on native MS-Windows console
132
133         PR/24315
134         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
135         on MS-Windows if $TERM is not defined.
136
137         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
138
139         * posix-hdep.c (gdb_console_fputs):
140         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
141         functions.
142         * ui-file.h (gdb_console_fputs): Add prototype.
143
144         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
145         back to fputs only if the former returns zero.
146
147 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
148             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
149
150         PR gdb/8527
151         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
152         set_sigint_trap, clear_sigint_trap.
153
154 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
155
156         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
157         for-loop range, to avoid compiler warnings.
158
159         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
160         avoid compiler warnings about unused variables.
161
162 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
163
164         * NEWS: Mention end of support for native debugging on MS-Windows
165         before XP.
166
167 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
168
169         PR gdb/24292
170         * common/netstuff.c:
171         * gdbserver/gdbreplay.c
172         * gdbserver/remote-utils.c:
173         * ser-tcp.c:
174         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
175         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
176         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
177         'getaddrinfo' and 'freeaddrinfo' were not available before
178         Windows XP, and mingw.org's MinGW headers by default define
179         _WIN32_WINNT to 0x500.
180
181 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
182     
183         * NEWS: Note minimum Python version.
184
185 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
186
187         * version.in: Set GDB version number to 8.2.90.DATE-git.
188
189 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
190
191         GDB 8.2.90 released.
192
193 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
194
195         * version.in: Set GDB version number to 8.2.90.
196
197 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
198
199         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
200
201 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
202
203         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
204         * version.in: Bump version to 8.2.90.DATE-git.
205
206 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
207
208         * aix-thread.c (ptid_cmp): Remove unused variable.
209         (get_signaled_thread): Likewise.
210         (store_regs_user_thread): Likewise.
211         (store_regs_kernel_thread): Likewise.
212         (fetch_regs_kernel_thread): Remove shadowed variable.
213
214 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
215
216         * features/riscv/32bit-cpu.xml: Add register numbers.
217         * features/riscv/32bit-fpu.c: Regenerate.
218         * features/riscv/32bit-fpu.xml: Add register numbers.
219         * features/riscv/64bit-cpu.xml: Add register numbers.
220         * features/riscv/64bit-fpu.c: Regenerate.
221         * features/riscv/64bit-fpu.xml: Add register numbers.
222
223 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
224
225         * NEWS: Mention two argument form of gdb.Value constructor.
226         * python/py-value.c (convert_buffer_and_type_to_value): New
227         function.
228         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
229         Add support for handling an optional second argument.  Call
230         convert_buffer_and_type_to_value as appropriate.
231         * python/python-internal.h (Py_buffer_deleter): New struct.
232         (Py_buffer_up): New typedef.
233
234 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
235
236         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
237         instead of releasing ownership.
238
239 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
240
241         * dwarf2read.c (open_and_init_dwp_file): Call
242         elf_numsections instead of bfd_count_sections to initialize
243         dwp_file->num_sections.
244
245 2019-02-25  Tom Tromey  <tromey@adacore.com>
246
247         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
248
249 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
250
251         * gcore.in: Add '--readnever' option when invoking GDB.
252
253 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
254
255         * MAINTAINERS: Update my email address.
256
257 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
258
259         * build-id.c (build_id_to_debug_bfd_1): New function.
260         (build_id_to_debug_bfd): Look for separate debug file in
261         sysroot.
262
263 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
264
265         * gdbarch.sh: Update the copyright year range that is placed into
266         generated files.
267
268 2019-02-22  Keith Seitz  <keiths@redhat.com>
269
270         PR symtab/23853
271         * linespec.c (create_sals_line_offset): Search for the default
272         symtab's filename instead of its fullname.
273
274 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
275
276         * NEWS: Update style defaults.
277
278 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
279
280         * main.c (captured_main_1): Disable styling in batch mode.
281
282 2019-02-20  Tom Tromey  <tom@tromey.com>
283
284         * symtab.c (symtab_symbol_info): Fix typos.
285
286 2019-02-20  Tom Tromey  <tromey@adacore.com>
287
288         * findcmd.c (_initialize_mem_search): Use upper case for
289         metasyntactic variables.
290
291 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
292
293         * aarch64-tdep.c (aarch64_add_reggroups): New function.
294         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
295
296 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
297
298         * top.h (source_file_name): Change to std::string.
299         * top.c (source_file_name): Likewise.
300         (command_line_input): Adjust.
301         * cli/cli-script.c (script_from_file): Adjust.
302
303 2019-02-19  Tom Tromey  <tromey@adacore.com>
304
305         * ravenscar-thread.c
306         (ravenscar_thread_target::update_thread_list): Don't call
307         ada_build_task_list.
308         * ada-lang.h (ada_build_task_list): Don't declare.
309         * ada-tasks.c (struct ada_tasks_inferior_data)
310         <task_list_valid_p>: Now bool.
311         (read_known_tasks, ada_task_list_changed)
312         (ada_tasks_invalidate_inferior_data): Update.
313         (read_known_tasks_array): Return bool.
314         (read_known_tasks_list): Likewise.
315         (read_known_tasks): Return void.
316         (ada_build_task_list): Now static.
317
318 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
319
320         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
321         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
322
323 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
324
325         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
326         variant for ada_tasks_pspace_data_handle and
327         ada_tasks_inferior_data_handle.
328         (ada_tasks_pspace_data_cleanup): New function.
329         (ada_tasks_inferior_data_cleanup): New function.
330
331 2019-02-17  Tom Tromey  <tom@tromey.com>
332
333         * macrotab.h (macro_source_fullname): Return a std::string.
334         * macrotab.c (macro_include, check_for_redefinition)
335         (macro_undef, macro_lookup_definition, foreach_macro)
336         (foreach_macro_in_scope): Update.
337         (macro_source_fullname): Return a std::string.
338         * macrocmd.c (show_pp_source_pos): Update.
339
340 2019-02-17  Tom Tromey  <tom@tromey.com>
341
342         * macrocmd.c (show_pp_source_pos): Style the file names.
343
344 2019-02-17  Tom Tromey  <tom@tromey.com>
345
346         PR tui/24197:
347         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
348
349 2019-02-17  Tom Tromey  <tom@tromey.com>
350
351         * ada-lang.c (user_select_syms): Use filtered printing.
352         * utils.c (wrap_style): New global.
353         (desired_style): Remove.
354         (emit_style_escape): Add stream parameter.
355         (set_output_style, reset_terminal_style, prompt_for_continue):
356         Update.
357         (flush_wrap_buffer): Only flush gdb_stdout.
358         (wrap_here): Set wrap_style.
359         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
360         treat escape sequences as a character.  Change when wrap buffer is
361         flushed.
362         (fputs_styled): Do not set the output style when the default is
363         requested.
364         * ui-style.h (struct ui_file_style) <is_default>: New method.
365         * source.c (print_source_lines_base): Emit escape sequences in one
366         piece.
367
368 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
369
370         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
371         integers and enumeration types.
372
373 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
374
375         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
376         instead of lookup_symbol_in_language
377         (do_exact_match): New function.
378         (ada_get_symbol_name_matcher): Return do_exact_match when
379         doing a verbatim match.
380
381 2019-02-15  Tom Tromey  <tromey@adacore.com>
382
383         * ravenscar-thread.c (ravenscar_thread_target::resume)
384         (ravenscar_thread_target::wait): Special case wildcard requests.
385
386 2019-02-15  Tom Tromey  <tromey@adacore.com>
387
388         * ravenscar-thread.c (base_ptid): Remove.
389         (struct ravenscar_thread_target) <close>: New method.
390         <m_base_ptid>: New member.
391         <update_inferior_ptid, active_task, task_is_currently_active,
392         runtime_initialized>: Declare methods.
393         <ravenscar_thread_target>: Add constructor.
394         (ravenscar_thread_target::task_is_currently_active)
395         (ravenscar_thread_target::update_inferior_ptid)
396         (ravenscar_runtime_initialized): Rename.  Now methods.
397         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
398         (ravenscar_thread_target::update_thread_list): Update.
399         (ravenscar_thread_target::active_task): Now method.
400         (ravenscar_thread_target::store_registers)
401         (ravenscar_thread_target::prepare_to_store)
402         (ravenscar_thread_target::prepare_to_store)
403         (ravenscar_thread_target::mourn_inferior): Update.
404         (ravenscar_inferior_created): Use "new" to create target.
405         (ravenscar_thread_target::get_ada_task_ptid): Update.
406         (_initialize_ravenscar): Don't initialize base_ptid.
407         (ravenscar_ops): Remove global.
408
409 2019-02-15  Tom Tromey  <tromey@adacore.com>
410
411         * target.h (push_target): Declare new overload.
412         * target.c (push_target): New overload, taking an rvalue reference.
413         * remote.c (remote_target::open_1): Use push_target overload.
414         * corelow.c (core_target_open): Use push_target overload.
415
416 2019-02-15  Tom Tromey  <tromey@adacore.com>
417
418         * ravenscar-thread.c (is_ravenscar_task)
419         (ravenscar_task_is_currently_active): Return bool.
420         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
421         (_initialize_ravenscar): Remove "(void)".
422         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
423         Return bool.
424
425 2019-02-15  Tom Tromey  <tromey@adacore.com>
426
427         * ravenscar-thread.c (ravenscar_runtime_initializer)
428         (has_ravenscar_runtime, get_running_thread_id)
429         (ravenscar_thread_target::resume): Fix indentation.
430
431 2019-02-15  Tom Tromey  <tromey@adacore.com>
432
433         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
434         from ravenscar_arch_ops.
435         (sparc_ravenscar_ops::fetch_registers)
436         (sparc_ravenscar_ops::store_registers): Now methods.
437         (sparc_ravenscar_prepare_to_store): Remove.
438         (sparc_ravenscar_ops): Redefine.
439         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
440         methods and destructor.  Remove members.
441         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
442         (ravenscar_thread_target::store_registers)
443         (ravenscar_thread_target::prepare_to_store): Update.
444         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
445         Remove.
446         (struct ppc_ravenscar_powerpc_ops): Derive from
447         ravenscar_arch_ops.
448         (ppc_ravenscar_powerpc_ops::fetch_registers)
449         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
450         (ppc_ravenscar_powerpc_ops): Redefine.
451         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
452         (ppc_ravenscar_e500_ops::fetch_registers)
453         (ppc_ravenscar_e500_ops::store_registers): Now methods.
454         (ppc_ravenscar_e500_ops): Redefine.
455         * aarch64-ravenscar-thread.c
456         (aarch64_ravenscar_generic_prepare_to_store): Remove.
457         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
458         (aarch64_ravenscar_fetch_registers)
459         (aarch64_ravenscar_store_registers): Now methods.
460         (aarch64_ravenscar_ops): Redefine.
461
462 2019-02-15  Tom Tromey  <tromey@adacore.com>
463
464         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
465         (ravenscar_thread_target::stopped_by_hw_breakpoint)
466         (ravenscar_thread_target::stopped_by_watchpoint)
467         (ravenscar_thread_target::stopped_data_address)
468         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
469
470 2019-02-15  Tom Tromey  <tromey@adacore.com>
471
472         * ravenscar-thread.c: Fix some typos.
473
474 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
475             Tom Tromey  <tromey@adacore.com>
476
477         * ada-lang.c (ada_exception_sal): Change addr_string to a
478         std::string.
479         (create_ada_exception_catchpoint): Update.
480
481 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
482             Tom Tromey  <tromey@adacore.com>
483
484         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
485         (bp_location_ops): Remove.
486         (base_breakpoint_allocate_location): Update.
487         (free_bp_location): Update.
488         * ada-lang.c (class ada_catchpoint_location)
489         <ada_catchpoint_location>: Remove ops parameter.
490         (ada_catchpoint_location_dtor): Remove.
491         (ada_catchpoint_location_ops): Remove.
492         (allocate_location_exception): Update.
493         * breakpoint.h (struct bp_location_ops): Remove.
494         (class bp_location) <bp_location>: Remove bp_location_ops
495         parameter.
496         <~bp_location>: Add destructor.
497         <ops>: Remove.
498
499 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
500             Pedro Alves  <palves@redhat.com>
501
502         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
503         'PATH_MAX'.
504
505 2019-02-14  David Michael  <fedora.dm0@gmail.com>
506             Samuel Thibault  <samuel.thibault@gnu.org>
507             Thomas Schwinge  <thomas@codesourcery.com>
508
509         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
510         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
511
512 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
513
514         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
515         (check_empty): Use "const char *".
516
517         * gnu-nat.c (gnu_nat_target::detach): Instead of
518         'detach_inferior (pid)' call
519         'detach_inferior (find_inferior_pid (pid))'.
520
521         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
522         'nat/fork-inferior.o'.
523         * gnu-nat.c: #include "nat/fork-inferior.h".
524
525         * gnu-nat.c (gnu_nat_target::detach): Instead of
526         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
527         * gnu-nat.h: #include "inf-child.h".
528         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
529         'i386_gnu_nat_target::fetch_registers'.
530         (gnu_store_registers): Rename/move to
531         'i386_gnu_nat_target::store_registers'.
532
533         * config/i386/nm-i386gnu.h: Don't "#include" any files.
534         * gnu-nat.h (mach_thread_info): New function.
535         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
536
537         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
538
539 2019-02-14  Frederic Konrad  <konrad@adacore.com>
540
541         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
542
543 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
544
545         * windows-nat.c (windows_add_thread): Add new parameter
546         "main_thread_p" with default value set to false.  Update
547         function documentation as well as all callers.
548         (windows_delete_thread): Likewise.
549         (fake_create_process): Update call to windows_add_thread.
550         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
551         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
552         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
553         call to windows_delete_thread.
554
555 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
556
557         * MAINTAINERS: Add Andrew Burgess as global maintainer.
558
559 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
560
561         * symfile.c (find_separate_debug_file): Use canonical path of
562         sysroot with child_path instead of gdb_sysroot if it is valid.
563
564 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
565
566         * symfile.c (find_separate_debug_file): Use child_path to
567         determine if an object file is under a sysroot.
568
569 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
570
571         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
572         unittests/child-path-selftests.c.
573         * common/pathstuff.c (child_path): New function.
574         * common/pathstuff.h (child_path): New prototype.
575         * unittests/child-path-selftests.c: New file.
576
577 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
578
579         * symfile.c (find_separate_debug_file): Look for separate debug
580         files in debug directories under the sysroot.
581
582 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
583
584         * symtab.h (struct minimal_symbol data_p): New const method.
585         (struct minimal_symbol text_p): Likewise.
586         * symtab.c (output_source_filename): Use file name style
587         to print file name.
588         (print_symbol_info): Likewise.
589         (print_msymbol_info): Use address style to print addresses.
590         Use function name style to print executable text symbols.
591         (expand_symtab_containing_pc): Use data_p.
592         (find_pc_sect_compunit_symtab): Likewise.
593
594 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
595
596         * breakpoint.c (describe_other_breakpoints): Use address style
597         to print addresses.
598         (say_where): Likewise.
599
600 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
601
602         * ada-typeprint.c (print_func_type): Print function name
603         style to print function name.
604         * c-typeprint.c (c_print_type_1): Likewise.
605
606 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
607
608         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
609         for execve.
610
611 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
612
613         * c-exp.y (direct_abs_decl): Use emplace_back to record the
614         type_stack.
615
616 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
617
618         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
619         TYPE_CODE_REF types.
620
621 2019-02-08  Jim Wilson  <jimw@sifive.com>
622
623         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
624         (riscv_linux_fregset): New.
625         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
626
627 2019-02-07  Tom Tromey  <tom@tromey.com>
628
629         * thread.c (thread_cancel_execution_command): Update.
630         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
631         methods.
632         (struct thread_fsm_ops): Remove.
633         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
634         (thread_fsm_should_stop, thread_fsm_return_value)
635         (thread_fsm_set_finished, thread_fsm_finished_p)
636         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
637         Don't declare.
638         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
639         * infrun.c (clear_proceed_status_thread)
640         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
641         (print_stop_event): Update.
642         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
643         Add constructor.
644         (step_command_fsm_ops): Remove.
645         (new_step_command_fsm): Remove.
646         (step_1): Update.
647         (step_command_fsm::should_stop): Rename from
648         step_command_fsm_should_stop.
649         (step_command_fsm::clean_up): Rename from
650         step_command_fsm_clean_up.
651         (step_command_fsm::do_async_reply_reason): Rename from
652         step_command_fsm_async_reply_reason.
653         (struct until_next_fsm): Inherit from thread_fsm.  Add
654         constructor.
655         (until_next_fsm_ops): Remove.
656         (new_until_next_fsm): Remove.
657         (until_next_fsm::should_stop): Rename from
658         until_next_fsm_should_stop.
659         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
660         (until_next_fsm::do_async_reply_reason): Rename from
661         until_next_fsm_async_reply_reason.
662         (struct finish_command_fsm): Inherit from thread_fsm.  Add
663         constructor.  Change type of breakpoint.
664         (finish_command_fsm_ops): Remove.
665         (new_finish_command_fsm): Remove.
666         (finish_command_fsm::should_stop): Rename from
667         finish_command_fsm_should_stop.
668         (finish_command_fsm::clean_up): Rename from
669         finish_command_fsm_clean_up.
670         (finish_command_fsm::return_value): Rename from
671         finish_command_fsm_return_value.
672         (finish_command_fsm::do_async_reply_reason): Rename from
673         finish_command_fsm_async_reply_reason.
674         (finish_command): Update.
675         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
676         Add constructor.
677         (call_thread_fsm_ops): Remove.
678         (call_thread_fsm::call_thread_fsm): Rename from
679         new_call_thread_fsm.
680         (call_thread_fsm::should_stop): Rename from
681         call_thread_fsm_should_stop.
682         (call_thread_fsm::should_notify_stop): Rename from
683         call_thread_fsm_should_notify_stop.
684         (run_inferior_call, call_function_by_hand_dummy): Update.
685         * cli/cli-interp.c (should_print_stop_to_console): Update.
686         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
687         Add constructor.  Change type of location_breakpoint,
688         caller_breakpoint.
689         (until_break_fsm_ops): Remove.
690         (new_until_break_fsm): Remove.
691         (until_break_fsm::should_stop): Rename from
692         until_break_fsm_should_stop.
693         (until_break_fsm::clean_up): Rename from
694         until_break_fsm_clean_up.
695         (until_break_fsm::do_async_reply_reason): Rename from
696         until_break_fsm_async_reply_reason.
697         (until_break_command): Update.
698         * thread-fsm.c: Remove.
699         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
700
701 2019-02-07  Tom Tromey  <tom@tromey.com>
702
703         * yy-remap.h: Add include guard.
704         * xtensa-tdep.h: Add include guard.
705         * xcoffread.h: Rename include guard.
706         * varobj-iter.h: Add include guard.
707         * tui/tui.h: Rename include guard.
708         * tui/tui-winsource.h: Rename include guard.
709         * tui/tui-wingeneral.h: Rename include guard.
710         * tui/tui-windata.h: Rename include guard.
711         * tui/tui-win.h: Rename include guard.
712         * tui/tui-stack.h: Rename include guard.
713         * tui/tui-source.h: Rename include guard.
714         * tui/tui-regs.h: Rename include guard.
715         * tui/tui-out.h: Rename include guard.
716         * tui/tui-layout.h: Rename include guard.
717         * tui/tui-io.h: Rename include guard.
718         * tui/tui-hooks.h: Rename include guard.
719         * tui/tui-file.h: Rename include guard.
720         * tui/tui-disasm.h: Rename include guard.
721         * tui/tui-data.h: Rename include guard.
722         * tui/tui-command.h: Rename include guard.
723         * tic6x-tdep.h: Add include guard.
724         * target/waitstatus.h: Rename include guard.
725         * target/wait.h: Rename include guard.
726         * target/target.h: Rename include guard.
727         * target/resume.h: Rename include guard.
728         * target-float.h: Rename include guard.
729         * stabsread.h: Add include guard.
730         * rs6000-tdep.h: Add include guard.
731         * riscv-fbsd-tdep.h: Add include guard.
732         * regformats/regdef.h: Rename include guard.
733         * record.h: Rename include guard.
734         * python/python.h: Rename include guard.
735         * python/python-internal.h: Rename include guard.
736         * python/py-stopevent.h: Rename include guard.
737         * python/py-ref.h: Rename include guard.
738         * python/py-record.h: Rename include guard.
739         * python/py-record-full.h: Rename include guard.
740         * python/py-record-btrace.h: Rename include guard.
741         * python/py-instruction.h: Rename include guard.
742         * python/py-events.h: Rename include guard.
743         * python/py-event.h: Rename include guard.
744         * procfs.h: Add include guard.
745         * proc-utils.h: Add include guard.
746         * p-lang.h: Add include guard.
747         * or1k-tdep.h: Rename include guard.
748         * observable.h: Rename include guard.
749         * nto-tdep.h: Rename include guard.
750         * nat/x86-linux.h: Rename include guard.
751         * nat/x86-linux-dregs.h: Rename include guard.
752         * nat/x86-gcc-cpuid.h: Add include guard.
753         * nat/x86-dregs.h: Rename include guard.
754         * nat/x86-cpuid.h: Rename include guard.
755         * nat/ppc-linux.h: Rename include guard.
756         * nat/mips-linux-watch.h: Rename include guard.
757         * nat/linux-waitpid.h: Rename include guard.
758         * nat/linux-ptrace.h: Rename include guard.
759         * nat/linux-procfs.h: Rename include guard.
760         * nat/linux-osdata.h: Rename include guard.
761         * nat/linux-nat.h: Rename include guard.
762         * nat/linux-namespaces.h: Rename include guard.
763         * nat/linux-btrace.h: Rename include guard.
764         * nat/glibc_thread_db.h: Rename include guard.
765         * nat/gdb_thread_db.h: Rename include guard.
766         * nat/gdb_ptrace.h: Rename include guard.
767         * nat/fork-inferior.h: Rename include guard.
768         * nat/amd64-linux-siginfo.h: Rename include guard.
769         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
770         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
771         * nat/aarch64-linux.h: Rename include guard.
772         * nat/aarch64-linux-hw-point.h: Rename include guard.
773         * mn10300-tdep.h: Add include guard.
774         * mips-linux-tdep.h: Add include guard.
775         * mi/mi-parse.h: Rename include guard.
776         * mi/mi-out.h: Rename include guard.
777         * mi/mi-main.h: Rename include guard.
778         * mi/mi-interp.h: Rename include guard.
779         * mi/mi-getopt.h: Rename include guard.
780         * mi/mi-console.h: Rename include guard.
781         * mi/mi-common.h: Rename include guard.
782         * mi/mi-cmds.h: Rename include guard.
783         * mi/mi-cmd-break.h: Rename include guard.
784         * m2-lang.h: Add include guard.
785         * location.h: Rename include guard.
786         * linux-record.h: Rename include guard.
787         * linux-nat.h: Add include guard.
788         * linux-fork.h: Add include guard.
789         * i386-darwin-tdep.h: Rename include guard.
790         * hppa-linux-offsets.h: Add include guard.
791         * guile/guile.h: Rename include guard.
792         * guile/guile-internal.h: Rename include guard.
793         * gnu-nat.h: Rename include guard.
794         * gdb-stabs.h: Rename include guard.
795         * frv-tdep.h: Add include guard.
796         * f-lang.h: Add include guard.
797         * event-loop.h: Add include guard.
798         * darwin-nat.h: Rename include guard.
799         * cp-abi.h: Rename include guard.
800         * config/sparc/nm-sol2.h: Rename include guard.
801         * config/nm-nto.h: Rename include guard.
802         * config/nm-linux.h: Add include guard.
803         * config/i386/nm-i386gnu.h: Rename include guard.
804         * config/djgpp/nl_types.h: Rename include guard.
805         * config/djgpp/langinfo.h: Rename include guard.
806         * compile/gcc-cp-plugin.h: Add include guard.
807         * compile/gcc-c-plugin.h: Add include guard.
808         * compile/compile.h: Rename include guard.
809         * compile/compile-object-run.h: Rename include guard.
810         * compile/compile-object-load.h: Rename include guard.
811         * compile/compile-internal.h: Rename include guard.
812         * compile/compile-cplus.h: Rename include guard.
813         * compile/compile-c.h: Rename include guard.
814         * common/xml-utils.h: Rename include guard.
815         * common/x86-xstate.h: Rename include guard.
816         * common/version.h: Rename include guard.
817         * common/vec.h: Rename include guard.
818         * common/tdesc.h: Rename include guard.
819         * common/selftest.h: Rename include guard.
820         * common/scoped_restore.h: Rename include guard.
821         * common/scoped_mmap.h: Rename include guard.
822         * common/scoped_fd.h: Rename include guard.
823         * common/safe-iterator.h: Rename include guard.
824         * common/run-time-clock.h: Rename include guard.
825         * common/refcounted-object.h: Rename include guard.
826         * common/queue.h: Rename include guard.
827         * common/ptid.h: Rename include guard.
828         * common/print-utils.h: Rename include guard.
829         * common/preprocessor.h: Rename include guard.
830         * common/pathstuff.h: Rename include guard.
831         * common/observable.h: Rename include guard.
832         * common/netstuff.h: Rename include guard.
833         * common/job-control.h: Rename include guard.
834         * common/host-defs.h: Rename include guard.
835         * common/gdb_wait.h: Rename include guard.
836         * common/gdb_vecs.h: Rename include guard.
837         * common/gdb_unlinker.h: Rename include guard.
838         * common/gdb_unique_ptr.h: Rename include guard.
839         * common/gdb_tilde_expand.h: Rename include guard.
840         * common/gdb_sys_time.h: Rename include guard.
841         * common/gdb_string_view.h: Rename include guard.
842         * common/gdb_splay_tree.h: Rename include guard.
843         * common/gdb_setjmp.h: Rename include guard.
844         * common/gdb_ref_ptr.h: Rename include guard.
845         * common/gdb_optional.h: Rename include guard.
846         * common/gdb_locale.h: Rename include guard.
847         * common/gdb_assert.h: Rename include guard.
848         * common/filtered-iterator.h: Rename include guard.
849         * common/filestuff.h: Rename include guard.
850         * common/fileio.h: Rename include guard.
851         * common/environ.h: Rename include guard.
852         * common/common-utils.h: Rename include guard.
853         * common/common-types.h: Rename include guard.
854         * common/common-regcache.h: Rename include guard.
855         * common/common-inferior.h: Rename include guard.
856         * common/common-gdbthread.h: Rename include guard.
857         * common/common-exceptions.h: Rename include guard.
858         * common/common-defs.h: Rename include guard.
859         * common/common-debug.h: Rename include guard.
860         * common/cleanups.h: Rename include guard.
861         * common/buffer.h: Rename include guard.
862         * common/btrace-common.h: Rename include guard.
863         * common/break-common.h: Rename include guard.
864         * cli/cli-utils.h: Rename include guard.
865         * cli/cli-style.h: Rename include guard.
866         * cli/cli-setshow.h: Rename include guard.
867         * cli/cli-script.h: Rename include guard.
868         * cli/cli-interp.h: Rename include guard.
869         * cli/cli-decode.h: Rename include guard.
870         * cli/cli-cmds.h: Rename include guard.
871         * charset-list.h: Add include guard.
872         * buildsym-legacy.h: Rename include guard.
873         * bfin-tdep.h: Add include guard.
874         * ax.h: Rename include guard.
875         * arm-linux-tdep.h: Add include guard.
876         * arm-fbsd-tdep.h: Add include guard.
877         * arch/xtensa.h: Rename include guard.
878         * arch/tic6x.h: Add include guard.
879         * arch/i386.h: Add include guard.
880         * arch/arm.h: Rename include guard.
881         * arch/arm-linux.h: Rename include guard.
882         * arch/arm-get-next-pcs.h: Rename include guard.
883         * arch/amd64.h: Add include guard.
884         * arch/aarch64-insn.h: Rename include guard.
885         * arch-utils.h: Rename include guard.
886         * annotate.h: Add include guard.
887         * amd64-darwin-tdep.h: Rename include guard.
888         * aarch64-linux-tdep.h: Add include guard.
889         * aarch64-fbsd-tdep.h: Add include guard.
890         * aarch32-linux-nat.h: Add include guard.
891
892 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
893
894         * macrotab.c (macro_define_internal): New function that
895         factorizes macro_define_object_internal and macro_define_function
896         code.
897         (macro_define_object_internal): Use macro_define_internal.
898         (macro_define_function): Likewise.
899
900 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
901
902         * macrocmd.c (extract_identifier): Return
903         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
904         callers.
905
906 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
907
908         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
909
910 2019-02-05  Tom Tromey  <tom@tromey.com>
911
912         * target.c (target_stack::unpush): Move assertion earlier.
913
914 2019-01-30  Tom Tromey  <tom@tromey.com>
915
916         PR python/23615:
917         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
918         (gdbpy_parse_and_eval): Likewise.
919         * python/python-internal.h (gdbpy_allow_threads): New class.
920
921 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
922
923         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
924         (aarch64_fbsd_fpregmap): Move earlier.
925         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
926         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
927         instead of individual calls to trad_frame_set_reg_addr.
928         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
929         earlier.
930         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
931         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
932         instead of individual calls to trad_frame_set_reg_addr.
933
934 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
935
936         * CONTRIBUTE: Replace contribution list with wiki link.
937
938 2019-01-25  Tom Tromey  <tom@tromey.com>
939
940         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
941
942 2019-01-25  Tom Tromey  <tom@tromey.com>
943
944         * xtensa-linux-nat.c: Fix common/ includes.
945         * xml-support.h: Fix common/ includes.
946         * xml-support.c: Fix common/ includes.
947         * x86-linux-nat.c: Fix common/ includes.
948         * windows-nat.c: Fix common/ includes.
949         * varobj.h: Fix common/ includes.
950         * varobj.c: Fix common/ includes.
951         * value.c: Fix common/ includes.
952         * valops.c: Fix common/ includes.
953         * utils.c: Fix common/ includes.
954         * unittests/xml-utils-selftests.c: Fix common/ includes.
955         * unittests/utils-selftests.c: Fix common/ includes.
956         * unittests/unpack-selftests.c: Fix common/ includes.
957         * unittests/tracepoint-selftests.c: Fix common/ includes.
958         * unittests/style-selftests.c: Fix common/ includes.
959         * unittests/string_view-selftests.c: Fix common/ includes.
960         * unittests/scoped_restore-selftests.c: Fix common/ includes.
961         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
962         * unittests/scoped_fd-selftests.c: Fix common/ includes.
963         * unittests/rsp-low-selftests.c: Fix common/ includes.
964         * unittests/parse-connection-spec-selftests.c: Fix common/
965         includes.
966         * unittests/optional-selftests.c: Fix common/ includes.
967         * unittests/offset-type-selftests.c: Fix common/ includes.
968         * unittests/observable-selftests.c: Fix common/ includes.
969         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
970         * unittests/memrange-selftests.c: Fix common/ includes.
971         * unittests/memory-map-selftests.c: Fix common/ includes.
972         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
973         * unittests/function-view-selftests.c: Fix common/ includes.
974         * unittests/environ-selftests.c: Fix common/ includes.
975         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
976         * unittests/common-utils-selftests.c: Fix common/ includes.
977         * unittests/cli-utils-selftests.c: Fix common/ includes.
978         * unittests/array-view-selftests.c: Fix common/ includes.
979         * ui-file.c: Fix common/ includes.
980         * tui/tui-io.c: Fix common/ includes.
981         * tracepoint.h: Fix common/ includes.
982         * tracepoint.c: Fix common/ includes.
983         * tracefile-tfile.c: Fix common/ includes.
984         * top.h: Fix common/ includes.
985         * top.c: Fix common/ includes.
986         * thread.c: Fix common/ includes.
987         * target/waitstatus.h: Fix common/ includes.
988         * target/waitstatus.c: Fix common/ includes.
989         * target.h: Fix common/ includes.
990         * target.c: Fix common/ includes.
991         * target-memory.c: Fix common/ includes.
992         * target-descriptions.c: Fix common/ includes.
993         * symtab.h: Fix common/ includes.
994         * symfile.c: Fix common/ includes.
995         * stap-probe.c: Fix common/ includes.
996         * spu-linux-nat.c: Fix common/ includes.
997         * sparc-nat.c: Fix common/ includes.
998         * source.c: Fix common/ includes.
999         * solib.c: Fix common/ includes.
1000         * solib-target.c: Fix common/ includes.
1001         * ser-unix.c: Fix common/ includes.
1002         * ser-tcp.c: Fix common/ includes.
1003         * ser-pipe.c: Fix common/ includes.
1004         * ser-base.c: Fix common/ includes.
1005         * selftest-arch.c: Fix common/ includes.
1006         * s12z-tdep.c: Fix common/ includes.
1007         * rust-exp.y: Fix common/ includes.
1008         * rs6000-aix-tdep.c: Fix common/ includes.
1009         * riscv-tdep.c: Fix common/ includes.
1010         * remote.c: Fix common/ includes.
1011         * remote-notif.h: Fix common/ includes.
1012         * remote-fileio.h: Fix common/ includes.
1013         * remote-fileio.c: Fix common/ includes.
1014         * regcache.h: Fix common/ includes.
1015         * regcache.c: Fix common/ includes.
1016         * record-btrace.c: Fix common/ includes.
1017         * python/python.c: Fix common/ includes.
1018         * python/py-type.c: Fix common/ includes.
1019         * python/py-inferior.c: Fix common/ includes.
1020         * progspace.h: Fix common/ includes.
1021         * producer.c: Fix common/ includes.
1022         * procfs.c: Fix common/ includes.
1023         * proc-api.c: Fix common/ includes.
1024         * printcmd.c: Fix common/ includes.
1025         * ppc-linux-nat.c: Fix common/ includes.
1026         * parser-defs.h: Fix common/ includes.
1027         * osdata.c: Fix common/ includes.
1028         * obsd-nat.c: Fix common/ includes.
1029         * nat/x86-linux.c: Fix common/ includes.
1030         * nat/x86-linux-dregs.c: Fix common/ includes.
1031         * nat/x86-dregs.h: Fix common/ includes.
1032         * nat/x86-dregs.c: Fix common/ includes.
1033         * nat/ppc-linux.c: Fix common/ includes.
1034         * nat/mips-linux-watch.h: Fix common/ includes.
1035         * nat/mips-linux-watch.c: Fix common/ includes.
1036         * nat/linux-waitpid.c: Fix common/ includes.
1037         * nat/linux-ptrace.h: Fix common/ includes.
1038         * nat/linux-ptrace.c: Fix common/ includes.
1039         * nat/linux-procfs.c: Fix common/ includes.
1040         * nat/linux-personality.c: Fix common/ includes.
1041         * nat/linux-osdata.c: Fix common/ includes.
1042         * nat/linux-namespaces.c: Fix common/ includes.
1043         * nat/linux-btrace.h: Fix common/ includes.
1044         * nat/linux-btrace.c: Fix common/ includes.
1045         * nat/fork-inferior.c: Fix common/ includes.
1046         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1047         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1048         * nat/aarch64-linux.c: Fix common/ includes.
1049         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1050         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1051         * namespace.h: Fix common/ includes.
1052         * mips-linux-tdep.c: Fix common/ includes.
1053         * minsyms.c: Fix common/ includes.
1054         * mi/mi-parse.h: Fix common/ includes.
1055         * mi/mi-main.c: Fix common/ includes.
1056         * mi/mi-cmd-env.c: Fix common/ includes.
1057         * memrange.h: Fix common/ includes.
1058         * memattr.c: Fix common/ includes.
1059         * maint.h: Fix common/ includes.
1060         * maint.c: Fix common/ includes.
1061         * main.c: Fix common/ includes.
1062         * machoread.c: Fix common/ includes.
1063         * location.c: Fix common/ includes.
1064         * linux-thread-db.c: Fix common/ includes.
1065         * linux-nat.c: Fix common/ includes.
1066         * linux-fork.c: Fix common/ includes.
1067         * inline-frame.c: Fix common/ includes.
1068         * infrun.c: Fix common/ includes.
1069         * inflow.c: Fix common/ includes.
1070         * inferior.h: Fix common/ includes.
1071         * inferior.c: Fix common/ includes.
1072         * infcmd.c: Fix common/ includes.
1073         * inf-ptrace.c: Fix common/ includes.
1074         * inf-child.c: Fix common/ includes.
1075         * ia64-linux-nat.c: Fix common/ includes.
1076         * i387-tdep.c: Fix common/ includes.
1077         * i386-tdep.c: Fix common/ includes.
1078         * i386-linux-tdep.c: Fix common/ includes.
1079         * i386-linux-nat.c: Fix common/ includes.
1080         * i386-go32-tdep.c: Fix common/ includes.
1081         * i386-fbsd-tdep.c: Fix common/ includes.
1082         * i386-fbsd-nat.c: Fix common/ includes.
1083         * guile/scm-type.c: Fix common/ includes.
1084         * guile/guile.c: Fix common/ includes.
1085         * go32-nat.c: Fix common/ includes.
1086         * gnu-nat.c: Fix common/ includes.
1087         * gdbthread.h: Fix common/ includes.
1088         * gdbarch-selftests.c: Fix common/ includes.
1089         * gdb_usleep.c: Fix common/ includes.
1090         * gdb_select.h: Fix common/ includes.
1091         * gdb_bfd.c: Fix common/ includes.
1092         * gcore.c: Fix common/ includes.
1093         * fork-child.c: Fix common/ includes.
1094         * findvar.c: Fix common/ includes.
1095         * fbsd-nat.c: Fix common/ includes.
1096         * event-top.c: Fix common/ includes.
1097         * event-loop.c: Fix common/ includes.
1098         * dwarf2read.c: Fix common/ includes.
1099         * dwarf2loc.c: Fix common/ includes.
1100         * dwarf2-frame.c: Fix common/ includes.
1101         * dwarf-index-cache.c: Fix common/ includes.
1102         * dtrace-probe.c: Fix common/ includes.
1103         * disasm-selftests.c: Fix common/ includes.
1104         * defs.h: Fix common/ includes.
1105         * csky-tdep.c: Fix common/ includes.
1106         * cp-valprint.c: Fix common/ includes.
1107         * cp-support.h: Fix common/ includes.
1108         * cp-support.c: Fix common/ includes.
1109         * corelow.c: Fix common/ includes.
1110         * completer.h: Fix common/ includes.
1111         * completer.c: Fix common/ includes.
1112         * compile/compile.c: Fix common/ includes.
1113         * compile/compile-loc2c.c: Fix common/ includes.
1114         * compile/compile-cplus-types.c: Fix common/ includes.
1115         * compile/compile-cplus-symbols.c: Fix common/ includes.
1116         * command.h: Fix common/ includes.
1117         * cli/cli-dump.c: Fix common/ includes.
1118         * cli/cli-cmds.c: Fix common/ includes.
1119         * charset.c: Fix common/ includes.
1120         * build-id.c: Fix common/ includes.
1121         * btrace.h: Fix common/ includes.
1122         * btrace.c: Fix common/ includes.
1123         * breakpoint.h: Fix common/ includes.
1124         * breakpoint.c: Fix common/ includes.
1125         * ax.h: 
1126         (enum agent_op): Fix common/ includes.
1127         * ax-general.c (struct aop_map): Fix common/ includes.
1128         * ax-gdb.c: Fix common/ includes.
1129         * auxv.c: Fix common/ includes.
1130         * auto-load.c: Fix common/ includes.
1131         * arm-tdep.c: Fix common/ includes.
1132         * arch/riscv.c: Fix common/ includes.
1133         * arch/ppc-linux-common.c: Fix common/ includes.
1134         * arch/i386.c: Fix common/ includes.
1135         * arch/arm.c: Fix common/ includes.
1136         * arch/arm-linux.c: Fix common/ includes.
1137         * arch/arm-get-next-pcs.c: Fix common/ includes.
1138         * arch/amd64.c: Fix common/ includes.
1139         * arch/aarch64.c: Fix common/ includes.
1140         * arch/aarch64-insn.c: Fix common/ includes.
1141         * arch-utils.c: Fix common/ includes.
1142         * amd64-windows-tdep.c: Fix common/ includes.
1143         * amd64-tdep.c: Fix common/ includes.
1144         * amd64-sol2-tdep.c: Fix common/ includes.
1145         * amd64-obsd-tdep.c: Fix common/ includes.
1146         * amd64-nbsd-tdep.c: Fix common/ includes.
1147         * amd64-linux-tdep.c: Fix common/ includes.
1148         * amd64-linux-nat.c: Fix common/ includes.
1149         * amd64-fbsd-tdep.c: Fix common/ includes.
1150         * amd64-fbsd-nat.c: Fix common/ includes.
1151         * amd64-dicos-tdep.c: Fix common/ includes.
1152         * amd64-darwin-tdep.c: Fix common/ includes.
1153         * agent.c: Fix common/ includes.
1154         * ada-lang.h: Fix common/ includes.
1155         * ada-lang.c: Fix common/ includes.
1156         * aarch64-tdep.c: Fix common/ includes.
1157
1158 2019-01-25  Tom Tromey  <tom@tromey.com>
1159
1160         * common/create-version.sh: Use common/version.h.
1161
1162 2019-01-24  Pedro Alves  <palves@redhat.com>
1163
1164         * infrun.c (signal_stop, signal_print, signal_program)
1165         (signal_catch, signal_pass): Now arrays instead of pointers.
1166         (update_signals_program_target, do_target_resume)
1167         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1168         * linux-nat.c (linux_nat_target::pass_signals)
1169         (linux_nat_target::create_inferior, linux_nat_target::attach):
1170         Adjust.
1171         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1172         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1173         * procfs.c (procfs_target::pass_signals): Adjust.
1174         * record-full.c (record_full_target::resume): Adjust.
1175         * remote.c (remote_target::pass_signals)
1176         (remote_target::program_signals): Adjust.
1177         * target-debug.h (target_debug_print_signals): Now takes a
1178         gdb::array_view as parameter.  Adjust.
1179         * target.h (target_ops) <pass_signals, program_signals>: Replace
1180         pointer and length parameters with gdb::array_view.
1181         (target_pass_signals, target_program_signals): Likewise.
1182         * target-delegates.c: Regenerate.
1183
1184 2019-01-24  Pedro Alves  <palves@redhat.com>
1185
1186         * common/forward-scope-exit.h
1187         (forward_scope_exit::forward_scope_exit): Pass arguments to
1188         m_bind_function directly, instead of creating a std::bind and
1189         copying that.
1190
1191 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1192
1193         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1194         for static members.
1195         (pass_in_v_vfp_candidate): Likewise.
1196
1197 2019-01-23  Tom Tromey  <tom@tromey.com>
1198             Pedro Alves  <palves@redhat.com>
1199
1200         * regcache.c (class regcache_invalidator): Remove.
1201         (regcache::raw_write): Use make_scope_exit.
1202
1203 2019-01-23  Tom Tromey  <tom@tromey.com>
1204
1205         * ui-out.h (class ui_out_emit_type): Update comment.
1206
1207 2019-01-23  Tom Tromey  <tom@tromey.com>
1208
1209         * infrun.c (fetch_inferior_event): Update comment.
1210
1211 2019-01-23  Tom Tromey  <tom@tromey.com>
1212             Pedro Alves  <palves@redhat.com>
1213
1214         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1215         parameter.
1216         (fetch_inferior_event): Use SCOPE_EXIT.
1217
1218
1219 2019-01-23  Tom Tromey  <tom@tromey.com>
1220             Pedro Alves  <palves@redhat.com>
1221
1222         * infrun.c (disable_thread_events): Delete.
1223         (stop_all_threads): Use SCOPE_EXIT.
1224
1225 2019-01-23  Tom Tromey  <tom@tromey.com>
1226             Pedro Alves  <palves@redhat.com>
1227
1228         * symfile.c: Include forward-scope-exit.h.
1229         (clear_symtab_users_cleanup): Replace forward declaration with
1230         a FORWARD_SCOPE_EXIT.
1231         (syms_from_objfile_1): Use the forward_scope_exit and
1232         gdb::optional instead of cleanup_function.
1233         (reread_symbols): Use the forward_scope_exit instead of
1234         cleanup_function.
1235         (clear_symtab_users_cleanup): Remove function.
1236
1237 2019-01-23  Tom Tromey  <tom@tromey.com>
1238             Pedro Alves  <palves@redhat.com>
1239
1240         * linux-nat.c: Include scope-exit.h.
1241         (cleanup_target_stop): Remove.
1242         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1243         SCOPE_EXIT.
1244
1245 2019-01-23  Tom Tromey  <tom@tromey.com>
1246             Pedro Alves  <palves@redhat.com>
1247
1248         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1249         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1250
1251 2019-01-23  Tom Tromey  <tom@tromey.com>
1252             Andrew Burgess  <andrew.burgess@embecosm.com>
1253             Pedro Alves  <palves@redhat.com>
1254
1255         * infrun.c (fetch_inferior_event): Use scope_exit.
1256         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1257         * top.c (execute_command): Use scope_exit.
1258         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1259         * utils.c (do_bpstat_clear_actions_cleanup)
1260         (make_bpstat_clear_actions_cleanup): Remove.
1261
1262 2019-01-23  Tom Tromey  <tom@tromey.com>
1263             Pedro Alves  <palves@redhat.com>
1264
1265         * infrun.c: Include "common/scope-exit.h"
1266         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1267         (wait_for_inferior): Use SCOPE_EXIT.
1268         (fetch_inferior_event): Use scope_exit.
1269
1270 2019-01-23  Tom Tromey  <tom@tromey.com>
1271             Pedro Alves  <palves@redhat.com>
1272
1273         * breakpoint.c (create_breakpoint): Remove cleanup.
1274
1275 2019-01-23  Tom Tromey  <tom@tromey.com>
1276             Andrew Burgess  <andrew.burgess@embecosm.com>
1277             Pedro Alves  <palves@redhat.com>
1278
1279 2019-01-23  Pedro Alves  <palves@redhat.com>
1280
1281         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1282
1283 2019-01-23  Pedro Alves  <palves@redhat.com>
1284             Andrew Burgess  <andrew.burgess@embecosm.com>
1285
1286         * gdbthread.h: Include "common/forward-scope-exit.h".
1287         (scoped_finish_thread_state): Redefine custom class in terms of
1288         forward_scope_exit.
1289
1290 2019-01-23  Pedro Alves  <palves@redhat.com>
1291             Andrew Burgess  <andrew.burgess@embecosm.com>
1292
1293         * common/forward-scope-exit.h: New file.
1294
1295 2019-01-23  Pedro Alves  <palves@redhat.com>
1296             Andrew Burgess  <andrew.burgess@embecosm.com>
1297             Tom Tromey  <tom@tromey.com>
1298
1299         * common/scope-exit.h: New file.
1300
1301 2019-01-23  Pedro Alves  <palves@redhat.com>
1302
1303         * common/preprocessor.h (ESC): Rename to ...
1304         (ESC_PARENS): ... this.
1305         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1306         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1307
1308 2019-01-23  Tom Tromey  <tom@tromey.com>
1309
1310         * language.h (class scoped_switch_to_sym_language_if_auto):
1311         Initialize m_lang in both cases.
1312
1313 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1314
1315         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1316         with XCNEW.
1317
1318 2019-01-22  Tom Tromey  <tom@tromey.com>
1319
1320         * corelow.c: Do not include sys/file.h.
1321
1322 2019-01-22  Tom Tromey  <tom@tromey.com>
1323
1324         * tui/tui-wingeneral.h: Include gdb_curses.h.
1325
1326 2019-01-22  Tom Tromey  <tom@tromey.com>
1327
1328         * source-cache.h (class source_cache) <get_source_lines,
1329         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1330
1331 2019-01-22  Tom Tromey  <tom@tromey.com>
1332
1333         * remote-fileio.h (struct remote_target): Declare.
1334
1335 2019-01-22  Tom Tromey  <tom@tromey.com>
1336
1337         * python/py-arch.c: Do not include py-ref.h.
1338         * python/py-bpevent.c: Do not include py-ref.h.
1339         * python/py-cmd.c: Do not include py-ref.h.
1340         * python/py-continueevent.c: Do not include py-ref.h.
1341         * python/py-event.h: Do not include py-ref.h.
1342         * python/py-evtregistry.c: Do not include py-ref.h.
1343         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1344         * python/py-frame.c: Do not include py-ref.h.
1345         * python/py-framefilter.c: Do not include py-ref.h.
1346         * python/py-function.c: Do not include py-ref.h.
1347         * python/py-infevents.c: Do not include py-ref.h.
1348         * python/py-linetable.c: Do not include py-ref.h.
1349         * python/py-objfile.c: Do not include py-ref.h.
1350         * python/py-param.c: Do not include py-ref.h.
1351         * python/py-prettyprint.c: Do not include py-ref.h.
1352         * python/py-progspace.c: Do not include py-ref.h.
1353         * python/py-symbol.c: Do not include py-ref.h.
1354         * python/py-symtab.c: Do not include py-ref.h.
1355         * python/py-type.c: Do not include py-ref.h.
1356         * python/py-unwind.c: Do not include py-ref.h.
1357         * python/py-utils.c: Do not include py-ref.h.
1358         * python/py-value.c: Do not include py-ref.h.
1359         * python/py-varobj.c: Do not include py-ref.h.
1360         * python/py-xmethods.c: Do not include py-ref.h.
1361         * python/python.c: Do not include py-ref.h.
1362         * varobj.c: Do not include py-ref.h.
1363
1364 2019-01-22  Tom Tromey  <tom@tromey.com>
1365
1366         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1367         keyword for bcache.
1368
1369 2019-01-22  Tom Tromey  <tom@tromey.com>
1370
1371         * compile/compile-cplus-types.c: Remove a comment by #include.
1372
1373 2019-01-22  Tom Tromey  <tom@tromey.com>
1374
1375         * compile/gcc-c-plugin.h: Include compile-internal.h.
1376
1377 2019-01-22  Tom Tromey  <tom@tromey.com>
1378
1379         * stabsread.c (EXTERN): Do not define.
1380         (symnum, next_symbol_text_func, processing_gcc_compilation)
1381         (within_function, global_sym_chain, global_stabs)
1382         (previous_stab_code, this_object_header_files)
1383         (n_this_object_header_files)
1384         (n_allocated_this_object_header_files): Define.
1385         * stabsread.h (EXTERN): Never define.  Use "extern".
1386
1387 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1388
1389         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1390         history_value.
1391
1392 2019-01-21  Tom Tromey  <tom@tromey.com>
1393
1394         * ui-out.c: Fix includes.
1395         * tui/tui-source.c: Fix includes.
1396         * target.c: Fix includes.
1397         * remote.c: Fix includes.
1398         * regcache.c: Fix includes.
1399         * python/py-block.c: Fix includes.
1400         * printcmd.c: Fix includes.
1401         * or1k-tdep.c: Fix includes.
1402         * mi/mi-main.c: Fix includes.
1403         * m32r-tdep.c: Fix includes.
1404         * csky-tdep.c: Fix includes.
1405         * compile/compile-cplus-types.c: Fix includes.
1406         * cli/cli-interp.c: Fix includes.
1407
1408 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1409
1410         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1411         for padding.
1412
1413 2019-01-16  Tom Tromey  <tom@tromey.com>
1414
1415         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1416         earlier.
1417         (struct objfile) <msymbols_range>: Move from top level.
1418         <msymbols>: New method.
1419         (class objfile_msymbols): Remove.
1420         * symtab.c (default_collect_symbol_completion_matches_break_on):
1421         Update.
1422         * symmisc.c (dump_msymbols): Update.
1423         * stabsread.c (scan_file_globals): Update.
1424         * objc-lang.c (info_selectors_command, info_classes_command)
1425         (find_methods): Update.
1426         * minsyms.c (find_solib_trampoline_target): Update.
1427         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1428         * coffread.c (coff_symfile_read): Update.
1429         * ada-lang.c (ada_lookup_simple_minsym)
1430         (ada_collect_symbol_completion_matches): Update.
1431
1432 2019-01-16  Tom Tromey  <tom@tromey.com>
1433
1434         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1435         type.  Remove no-argument constructor.
1436         <iterator::operator++>: Simplify.
1437         <begin>: Update.
1438         <end>: Use minimal_symbol_count.
1439
1440 2019-01-16  Tom Tromey  <tom@tromey.com>
1441
1442         * objfiles.h (struct objfile) <psymtabs>: New method.
1443         (class objfile_psymtabs): Remove.
1444         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1445         typedef.
1446         <range>: New method.
1447         (require_partial_symbols): Change return type.
1448         * psymtab.c (require_partial_symbols)
1449         (psym_expand_symtabs_matching): Update.
1450         * mdebugread.c (parse_partial_symbols): Update.
1451         * dbxread.c (dbx_end_psymtab): Update.
1452
1453 2019-01-15  Tom Tromey  <tom@tromey.com>
1454
1455         * symtab.c (lookup_objfile_from_block)
1456         (lookup_symbol_in_objfile_symtabs)
1457         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1458         (find_line_symtab, info_sources_command)
1459         (default_collect_symbol_completion_matches_break_on)
1460         (make_source_files_completion_list): Update.
1461         * symmisc.c (print_objfile_statistics, dump_objfile)
1462         (maintenance_print_symbols, maintenance_info_symtabs)
1463         (maintenance_check_symtabs, maintenance_info_line_tables):
1464         Update.
1465         * source.c (select_source_symtab)
1466         (forget_cached_source_info_for_objfile): Update.
1467         * objfiles.h (class objfile_compunits): Remove.
1468         (struct objfile) <compunits_range>: New typedef.
1469         (compunits): New method.
1470         * objfiles.c (objfile_relocate1): Update.
1471         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1472         * maint.c (count_symtabs_and_blocks): Update.
1473         * linespec.c (iterate_over_all_matching_symtabs): Update.
1474         * cp-support.c (add_symbol_overload_list_qualified): Update.
1475         * coffread.c (coff_symtab_read): Update.
1476         * ada-lang.c (add_nonlocal_symbols)
1477         (ada_collect_symbol_completion_matches)
1478         (ada_add_global_exceptions): Update.
1479
1480 2019-01-15  Tom Tromey  <tom@tromey.com>
1481
1482         * progspace.h (program_space) <objfiles_safe_range>: New
1483         typedef.
1484         <objfiles_safe>: New method.
1485         * objfiles.h (class all_objfiles_safe): Remove.
1486         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1487         * jit.c (jit_inferior_exit_hook): Update.
1488
1489 2019-01-17  Tom Tromey  <tom@tromey.com>
1490
1491         * progspace.h (program_space) <objfiles_range>: New typedef.
1492         <objfiles>: New method.
1493         <objfiles_head>: Rename from objfiles.
1494         (object_files): Update.
1495         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1496         * guile/scm-pretty-print.c
1497         (ppscm_find_pretty_printer_from_objfiles): Update.
1498         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1499         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1500         Update.
1501         * python/py-progspace.c (pspy_get_objfiles): Update.
1502         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1503         Update.
1504         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1505         (objfpy_lookup_objfile_by_build_id): Update.
1506         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1507         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1508         Update.
1509         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1510         (expand_symtab_containing_pc, lookup_objfile_from_block)
1511         (lookup_static_symbol, basic_lookup_transparent_type)
1512         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1513         (find_line_symtab, info_sources_command)
1514         (default_collect_symbol_completion_matches_break_on)
1515         (make_source_files_completion_list, find_main_name): Update.
1516         * symmisc.c (print_symbol_bcache_statistics)
1517         (print_objfile_statistics, maintenance_print_symbols)
1518         (maintenance_print_msymbols, maintenance_print_objfiles)
1519         (maintenance_info_symtabs, maintenance_check_symtabs)
1520         (maintenance_expand_symtabs, maintenance_info_line_tables):
1521         Update.
1522         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1523         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1524         (map_overlay_command, unmap_overlay_command)
1525         (simple_overlay_update, expand_symtabs_matching)
1526         (map_symbol_filenames): Update.
1527         * symfile-debug.c (set_debug_symfile): Update.
1528         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1529         Update.
1530         * source.c (select_source_symtab, forget_cached_source_info):
1531         Update.
1532         * solib.c (solib_read_symbols): Update.
1533         * solib-spu.c (append_ocl_sos): Update.
1534         * psymtab.c (maintenance_print_psymbols)
1535         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1536         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1537         * printcmd.c (info_symbol_command): Update.
1538         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1539         Update.
1540         * objfiles.h (class all_objfiles): Remove.
1541         * objfiles.c (have_partial_symbols, have_full_symbols)
1542         (have_minimal_symbols, qsort_cmp, update_section_map)
1543         (shared_objfile_contains_address_p)
1544         (default_iterate_over_objfiles_in_search_order): Update.
1545         * objc-lang.c (info_selectors_command, info_classes_command)
1546         (find_methods): Update.
1547         * minsyms.c (find_solib_trampoline_target): Update.
1548         * maint.c (maintenance_info_sections)
1549         (maintenance_translate_address, count_symtabs_and_blocks):
1550         Update.
1551         * main.c (captured_main_1): Update.
1552         * linux-thread-db.c (try_thread_db_load_from_pdir)
1553         (has_libpthread): Update.
1554         * linespec.c (iterate_over_all_matching_symtabs)
1555         (search_minsyms_for_name): Update.
1556         * jit.c (jit_find_objf_with_entry_addr): Update.
1557         * hppa-tdep.c (find_unwind_entry)
1558         (hppa_lookup_stub_minimal_symbol): Update.
1559         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1560         Update.
1561         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1562         (elf_gnu_ifunc_resolve_by_got): Update.
1563         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1564         * dwarf-index-write.c (save_gdb_index_command): Update.
1565         * cp-support.c (add_symbol_overload_list_qualified): Update.
1566         * breakpoint.c (create_overlay_event_breakpoint)
1567         (create_longjmp_master_breakpoint)
1568         (create_std_terminate_master_breakpoint)
1569         (create_exception_master_breakpoint): Update.
1570         * blockframe.c (find_pc_partial_function): Update.
1571         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1572         (ada_collect_symbol_completion_matches)
1573         (ada_add_global_exceptions): Update.
1574
1575 2019-01-17  Tom Tromey  <tom@tromey.com>
1576
1577         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1578         declare VEC.
1579         (solib_target_parse_libraries): Change return type.
1580         (library_list_start_segment, library_list_start_section)
1581         (library_list_end_library, library_list_start_library); Update.
1582         (solib_target_free_library_list): Remove.
1583         (solib_target_parse_libraries): Remove cleanup.  Change return
1584         type.
1585         (solib_target_current_sos): Update.
1586
1587 2019-01-17  Tom Tromey  <tromey@bapiya>
1588
1589         * valprint.c: Replace "the the" with "the".
1590         * symtab.c: Replace "the the" with "the".
1591         * solib.c: Replace "the the" with "the".
1592         * solib-dsbt.c: Replace "the the" with "the".
1593         * linespec.c: Replace "the the" with "the".
1594         * dwarf2loc.h: Replace "the the" with "the".
1595         * amd64-windows-tdep.c: Replace "the the" with "the".
1596         * aarch64-tdep.c: Replace "the the" with "the".
1597
1598 2019-01-16  Keith Seitz  <keiths@redhat.com>
1599
1600         PR gdb/23773
1601         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1602         <builder>: Rename to ..
1603         <m_builder>: ... this and make private.
1604         (dwarf2_cu::get_builder): New method.  Change all users of
1605         `builder' to use this method.
1606         (dwarf2_start_symtab): Move to ...
1607         (dwarf2_cu::start_symtab): ... here.  Update all callers
1608         (setup_type_unit_groups): Move to ...
1609         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1610         callers.
1611         (dwarf2_cu::reset_builder): New method.
1612         (process_full_compunit, process_full_type_unit): Use
1613         dwarf2_cu::reset_builder.
1614         (follow_die_offset): Record the ancestor CU if it is different
1615         from the followed DIE's CU.
1616         (follow_die_sig_1): Likewise.
1617
1618 2019-01-15  Tom Tromey  <tom@tromey.com>
1619
1620         * remote.c (class remote_state) <buf>: Now a char_vector.
1621         <buf_size>: Remove.
1622         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1623         parameter.
1624         (remote_target::getpkt_or_notif_sane_1)
1625         (remote_target::getpkt_sane)
1626         (remote_target::getpkt_or_notif_sane): Likewise.
1627         (class remote_target) <putpkt>: New overload.
1628         (remote_target::read_frame): Change type of "buf_p".  Remove
1629         sizeof_p parameter.
1630         (packet_ok): New overload.
1631         (packet_check_result): New overload.
1632         Update all uses.
1633
1634 2019-01-14  Tom Tromey  <tom@tromey.com>
1635
1636         * remote-notif.c (handle_notification, remote_notif_ack)
1637         (remote_notif_parse): Make "buf" const.
1638         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1639         const.
1640         (remote_notif_parse, remote_notif_ack, handle_notification):
1641         Likewise.
1642         * remote.c (remote_notif_stop_parse): Make "buf" const.
1643         (remote_target::remote_parse_stop_reply): Make "buf" const.
1644         (remote_notif_stop_ack): Make "buf" const.
1645
1646 2019-01-14  Tom Tromey  <tom@tromey.com>
1647
1648         * remote.c (remote_console_output): Make parameter const.
1649
1650 2019-01-14  Tom Tromey  <tom@tromey.com>
1651
1652         * target-debug.h (target_debug_print_signals): Constify.
1653         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1654         * procfs.c (procfs_target::pass_signals): Update.
1655         * linux-nat.c (linux_nat_target::pass_signals): Update.
1656         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1657         * target-delegates.c: Rebuild.
1658         * remote.c (remote_target::program_signals): Update.
1659         (remote_target::pass_signals): Update.
1660         * target.c (target_pass_signals): Constify argument.
1661         (target_program_signals): Likewise.
1662         * target.h (struct target_ops) <pass_signals, program_signals>:
1663         Constify argument.
1664         (target_pass_signals, target_program_signals): Constify argument.
1665
1666 2019-01-14  Tom Tromey  <tom@tromey.com>
1667
1668         PR tui/28819:
1669         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1670
1671 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1672
1673         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1674         field.
1675         * rs6000-tdep.c: Include reggroups.h.
1676         (IS_V_ALIAS_PSEUDOREG): Define.
1677         (rs6000_register_name): Return names for the "vX" aliases.
1678         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1679         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1680         aliases.  Call default_register_reggroup_p for all other
1681         pseudo-registers.
1682         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1683         New functions.
1684         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1685         Handle "vX" aliases.
1686         (v_alias_pseudo_register_collect): New function.
1687         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1688         (rs6000_gdbarch_init): Initialize "vX" aliases as
1689         pseudo-registers.  Restore registration of
1690         rs6000_pseudo_register_reggroup_p with
1691         set_tdesc_pseudo_register_reggroup_p.
1692
1693 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1694
1695         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1696         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1697         set_gdbarch_num_pseudo_regs.
1698
1699 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1700
1701         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1702         Remove arg prefixname, add do_set and do_show.
1703         Add member functions set_list and show_list.
1704         * cli/cli-style.c (class cli_style_option): Update accordingly.
1705         (style_set_list): Move to file scope.
1706         (style_show_list): Likewise.
1707         (set_style): Call help_list.
1708         (show_style): Call cmd_show_list.
1709         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1710         Update to use the new macro.
1711
1712 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1713
1714         * ada-lang.c (_initialize_ada_language): Expand the help text
1715         for the "catch exception" command.
1716
1717 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1718
1719         * symtab.c (matching_obj_sections): Initialize obj,
1720         declare it closer to its usage.
1721
1722 2019-01-10  Tom Tromey  <tom@tromey.com>
1723
1724         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1725         (basic_inf_threads_range): Remove.
1726         (inf_threads_range, inf_non_exited_threads_range)
1727         (safe_inf_threads_range): Use next_adapter.
1728
1729 2019-01-10  Keith Seitz  <keiths@redhat.com>
1730
1731         PR gdb/23712
1732         PR symtab/23010
1733         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1734         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1735
1736 2019-01-10  Keith Seitz  <keiths@redhat.com>
1737
1738         PR gdb/23712
1739         PR symtab/23010
1740         * dictionary.c (pending_to_vector): Remove.
1741         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1742         Remove _1 suffix, replacing functions of the same name.  Update
1743         all callers.
1744         (dict_create_hashed, dict_create_hashed_expandable)
1745         (dict_create_linear, dict_create_linear_expandable, dict_free)
1746         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1747         Make functions static.
1748
1749 2019-01-10  Keith Seitz  <keiths@redhat.com>
1750
1751         PR gdb/23712
1752         PR symtab/23010
1753         * dictionary.h (struct dictionary): Replace declaration with
1754         multidictionary.
1755         (dict_create_hashed, dict_create_hashed_expandable)
1756         (dict_create_linear, dict_create_linear_expandable)
1757         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1758         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1759         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1760         taking multidictionary argument.
1761         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1762         * block.h (struct block) <dict>: Change to multidictionary
1763         and rename `multidict'.
1764         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1765         symmisc.c: Update all dictionary references to multidictionary.
1766
1767 2019-01-10  Keith Seitz  <keiths@redhat.com>
1768
1769         PR gdb/23712
1770         PR symtab/23010
1771         * dictionary.c: Include unordered_map.
1772         (pending_to_vector): New function.
1773         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1774         Rewrite the non-"_1" functions to take vector instead
1775         of linked list.
1776         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1777         "new" _1 versions of the same name.
1778         (multidictionary): Define.
1779         (std::hash<enum language): New definition.
1780         (collate_pending_symbols_by_language, mdict_create_hashed)
1781         (mdict_create_hashed_expandable, mdict_create_linear)
1782         (mdict_create_linear_expandable, mdict_free)
1783         (find_language_dictionary, create_new_language_dictionary)
1784         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1785         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1786         (mdict_size, mdict_empty): New functions.
1787         * dictionary.h (mdict_iterator): Define.
1788
1789 2019-01-10  Pedro Alves  <palves@redhat.com>
1790
1791         * breakpoint.c (read_uploaded_action)
1792         (create_tracepoint_from_upload): Adjust to use
1793         gdb::unique_xmalloc_ptr.
1794         * ctf.c (ctf_write_uploaded_tp):
1795         (SET_ARRAY_FIELD): Use emplace_back.
1796         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1797         * tracefile-tfile.c (tfile_write_uploaded_tp):
1798         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1799         gdb::unique_xmalloc_ptr.
1800         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1801         at_string, cond_string, cmd_strings>: Replace char pointers
1802         with gdb::unique_xmalloc_ptr.
1803
1804 2019-01-10  Pedro Alves  <palves@redhat.com>
1805
1806         * solib-target.c (library_list_start_library): Don't xstrdup name.
1807
1808 2019-01-10  Pedro Alves  <palves@redhat.com>
1809
1810         * mdebugread.c (parse_partial_symbols): Use
1811         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1812
1813 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1814
1815         * linux-fork.c (scoped_switch_fork_info)
1816         <~scoped_switch_fork_info>: Fix incorrect variable name.
1817
1818 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1819
1820         * linux-fork.c (scoped_switch_fork_info)
1821         <scoped_switch_fork_info>: Make explicit.
1822         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1823
1824 2019-01-10  Tom Tromey  <tom@tromey.com>
1825
1826         * objfiles.h (objfile::reset_psymtabs): Update.
1827         * objfiles.c (objfile::objfile): Update.
1828         * psymtab.h (psymtab_storage::obstack): Update.
1829         (psymtab_storage::m_obstack): Use gdb::optional.
1830         (class psymtab_storage): Update comment.  Remove objfile
1831         parameter.
1832         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1833
1834 2019-01-10  Tom Tromey  <tom@tromey.com>
1835
1836         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1837         <free_psymtabs>: Now private.
1838         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1839         (allocate_psymtab): Use new method.
1840
1841 2019-01-10  Tom Tromey  <tom@tromey.com>
1842
1843         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1844         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1845         * mdebugread.c (parse_partial_symbols): Use
1846         allocate_dependencies.
1847         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1848         allocate_dependencies.
1849         (process_psymtab_comp_unit_reader)
1850         (build_type_psymtab_dependencies): Likewise.
1851         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1852
1853 2019-01-10  Tom Tromey  <tom@tromey.com>
1854
1855         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1856         PSYMBOL_SET_LANGUAGE.
1857         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1858
1859 2019-01-10  Tom Tromey  <tom@tromey.com>
1860
1861         * psymtab.h (psymtab_storage::obstack): New method.
1862         <m_obstack>: Rename from obstack; now private.
1863         * psymtab.c (psymtab_storage): Update.
1864         * dwarf2read.c (create_addrmap_from_index)
1865         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1866         Update.
1867
1868 2019-01-10  Tom Tromey  <tom@tromey.com>
1869
1870         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1871         * objfiles.h (objfile::reset_psymtabs): New method.
1872
1873 2019-01-10  Tom Tromey  <tom@tromey.com>
1874
1875         * symmisc.c (print_symbol_bcache_statistics): Update.
1876         (print_objfile_statistics): Update.
1877         * symfile.c (reread_symbols): Update.
1878         * psymtab.h (class psymtab_storage): New.
1879         * psymtab.c (psymtab_storage): New constructor.
1880         (~psymtab_storage): New destructor.
1881         (require_partial_symbols): Update.
1882         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1883         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1884         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1885         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1886         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1887         (start_psymtab_common, end_psymtab_common)
1888         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1889         (allocate_psymtab): Update.
1890         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1891         Update.
1892         (dump_psymtab_addrmap, maintenance_print_psymbols)
1893         (maintenance_check_psymtabs): Update.
1894         (class objfile_psymtabs): Move to objfiles.h.
1895         * psympriv.h (discard_psymtab): Now inline.
1896         (psymtab_discarder::psymtab_discarder): Update.
1897         (psymtab_discarder::~psymtab_discarder): Update.
1898         (ALL_OBJFILE_PSYMTABS): Rewrite.
1899         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1900         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1901         Remove fields.
1902         <partial_symtabs>: New field.
1903         (class objfile_psymtabs): Move from psymtab.h.  Update.
1904         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1905         psymbol_cache.
1906         (objfile::~objfile): Don't destroy psymbol_cache.
1907         * mdebugread.c (parse_partial_symbols): Update.
1908         * dwarf2read.c (create_addrmap_from_index)
1909         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1910         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1911         (add_partial_subprogram, dwarf2_ranges_read): Update.
1912         * dwarf-index-write.c (write_address_map)
1913         (write_one_signatured_type, recursively_write_psymbols)
1914         (class debug_names, class debug_names, write_psymtabs_to_index):
1915         Update.
1916
1917 2019-01-10  Tom Tromey  <tom@tromey.com>
1918
1919         * symtab.h (SYMBOL_SET_NAMES): Update.
1920         (symbol_set_names): Update.
1921         (MSYMBOL_SET_NAMES): Update.
1922         * symtab.c (symbol_set_names): Change argument to be an
1923         objfile_per_bfd_storage.
1924         * psymtab.c (add_psymbol_to_bcache): Update.
1925         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1926
1927 2019-01-10  Tom Tromey  <tom@tromey.com>
1928
1929         * symtab.c (create_demangled_names_hash): Change argument to be an
1930         objfile_per_bfd_storage.
1931         (symbol_set_names): Update.
1932
1933 2019-01-10  Tom Tromey  <tom@tromey.com>
1934
1935         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1936         init_psymbol_list.
1937         * psymtab.c (init_psymbol_list): Do nothing if already called.
1938         * psympriv.h (init_psymbol_list): Add comment.
1939         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1940         init_psymbol_list.
1941         * dbxread.c (dbx_symfile_read): Unconditionally call
1942         init_psymbol_list.
1943
1944 2019-01-10  Tom Tromey  <tom@tromey.com>
1945
1946         * xcoffread.c (scan_xcoff_symtab): Update.
1947         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1948         "where".
1949         * mdebugread.c (parse_partial_symbols)
1950         (handle_psymbol_enumerators): Update.
1951         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1952         * dbxread.c (read_dbx_symtab): Update.
1953         * psympriv.h (psymbol_placement): New enum.
1954         (add_psymbol_to_list): Update.
1955
1956 2019-01-10  Tom Tromey  <tom@tromey.com>
1957
1958         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1959         static_psymbols parameters.
1960         (scan_xcoff_symtab): Update.
1961         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1962         static_psymbols parameters.
1963         * psympriv.h (start_psymtab_common): Update.
1964         * mdebugread.c (parse_partial_symbols): Update.
1965         * dwarf2read.c (create_partial_symtab): Update.
1966         * dbxread.c (read_dbx_symtab): Update.
1967         (start_psymtab): Remove global_psymbols and static_psymbols
1968         parameters.
1969
1970 2019-01-10  Tom Tromey  <tom@tromey.com>
1971
1972         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1973         * psymtab.c (allocate_psymtab): Add comment.
1974         * psympriv.h (allocate_psymtab): Add comment.
1975         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1976         initializations.
1977         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1978
1979 2019-01-10  Tom Tromey  <tom@tromey.com>
1980
1981         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1982         Don't declare.
1983         * mipsread.c: Include mdebugread.h.
1984         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1985         Declare.
1986         * elfread.c: Include mdebugread.h.
1987
1988 2019-01-09  Tom Tromey  <tom@tromey.com>
1989
1990         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1991         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1992         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1993         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1994         (psym_lookup_symbol, psym_find_last_source_symtab)
1995         (psym_forget_cached_source_info, psym_print_stats)
1996         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1997         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1998         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1999         (psym_find_compunit_symtab_by_address)
2000         (maintenance_print_psymbols, maintenance_info_psymtabs)
2001         (maintenance_check_psymtabs): Use ranged for.
2002         * psymtab.h (class objfile_psymtabs): New.
2003         (require_partial_symbols): Return objfile_psymtabs.
2004         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2005
2006 2019-01-09  Tom Tromey  <tom@tromey.com>
2007
2008         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2009         (find_pc_mapped_section, list_overlays_command)
2010         (map_overlay_command, unmap_overlay_command)
2011         (simple_overlay_update): Use all_objfiles.
2012         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2013         * printcmd.c (info_symbol_command): Use all_objfiles.
2014         * objfiles.h (ALL_OBJSECTIONS): Remove.
2015         * maint.c (maintenance_translate_address): Use all_objfiles.
2016         * gcore.c (gcore_create_callback): Use all_objfiles.
2017         (objfile_find_memory_regions): Likewise.
2018
2019 2019-01-09  Tom Tromey  <tom@tromey.com>
2020
2021         * symtab.c (find_line_symtab, info_sources_command)
2022         (make_source_files_completion_list): Use objfile_compunits.
2023         * source.c (select_source_symtab): Use objfile_compunits.
2024         * objfiles.h (struct objfile): Update comment.
2025         (ALL_OBJFILES): Remove.
2026         (ALL_FILETABS): Remove.
2027         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2028         objfile_compunits.
2029
2030 2019-01-09  Tom Tromey  <tom@tromey.com>
2031
2032         * symmisc.c (print_objfile_statistics, dump_objfile)
2033         (maintenance_print_symbols): Use compunit_filetabs.
2034         * source.c (forget_cached_source_info_for_objfile): Use
2035         compunit_filetabs.
2036         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2037         (ALL_FILETABS): Use compunit_filetabs.
2038         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2039         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2040
2041 2019-01-09  Tom Tromey  <tom@tromey.com>
2042
2043         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2044         (compunit_filetabs): New.
2045         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2046         compunit_filetabs.
2047         (info_sources_command, make_source_files_completion_list): Remove
2048         declaration.
2049         * symmisc.c (print_objfile_statistics, dump_objfile)
2050         (maintenance_print_symbols): Remove declaration.
2051         (maintenance_info_symtabs): Use compunit_filetabs.
2052         (maintenance_info_line_tables): Likewise.
2053         * source.c (select_source_symtab): Change local variable name.
2054         (forget_cached_source_info_for_objfile): Remove declaration.
2055         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2056         * objfiles.c (objfile_relocate1): Remove declaration.
2057         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2058         declaration.
2059         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2060         * coffread.c (coff_symtab_read): Remove declaration.
2061         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2062         compunit_filetabs.
2063
2064 2019-01-09  Tom Tromey  <tom@tromey.com>
2065
2066         * symtab.c (lookup_objfile_from_block)
2067         (find_pc_sect_compunit_symtab, search_symbols)
2068         (default_collect_symbol_completion_matches_break_on): Use
2069         objfile_compunits.
2070         * objfiles.h (ALL_COMPUNITS): Remove.
2071         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2072         * cp-support.c (add_symbol_overload_list_qualified): Use
2073         objfile_compunits.
2074         * ada-lang.c (ada_collect_symbol_completion_matches)
2075         (ada_add_global_exceptions): Use objfile_compunits.
2076
2077 2019-01-09  Tom Tromey  <tom@tromey.com>
2078
2079         * source.c (select_source_symtab)
2080         (forget_cached_source_info_for_objfile): Remove declaration.
2081         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2082         declaration.
2083         * maint.c (count_symtabs_and_blocks): Remove declaration.
2084         * cp-support.c (add_symbol_overload_list_qualified): Remove
2085         declaration.
2086         * coffread.c (coff_symtab_read): Remove declaration.
2087         * symtab.c (lookup_symbol_in_objfile_symtabs)
2088         (basic_lookup_transparent_type_1): Use objfile_compunits.
2089         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2090         (info_sources_command, search_symbols)
2091         (default_collect_symbol_completion_matches_break_on)
2092         (make_source_files_completion_list): Remove declaration.
2093         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2094         (ada_collect_symbol_completion_matches)
2095         (ada_add_global_exceptions): Remove declaration.
2096         * linespec.c (iterate_over_all_matching_symtabs): Use
2097         objfile_compunits.
2098         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2099         (class objfile_compunits): New.
2100         (ALL_COMPUNITS): Use objfile_compunits.
2101         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2102         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2103         objfile_compunits.
2104         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2105
2106 2019-01-09  Tom Tromey  <tom@tromey.com>
2107
2108         * symtab.c (search_symbols)
2109         (default_collect_symbol_completion_matches_break_on): Use
2110         objfile_msymbols.
2111         * ada-lang.c (ada_lookup_simple_minsym)
2112         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2113         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2114         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2115         objfile_msymbols.
2116         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2117         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2118         * objc-lang.c (find_methods): Use objfile_msymbols.
2119         (info_selectors_command, info_classes_command): Likewise.
2120         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2121         * objfiles.h (class objfile_msymbols): New.
2122         (ALL_OBJFILE_MSYMBOLS): Remove.
2123         (ALL_MSYMBOLS): Remove.
2124
2125 2019-01-09  Tom Tromey  <tom@tromey.com>
2126
2127         * common/next-iterator.h (next_adapter): Add Iterator template
2128         parameter.
2129         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2130         (class all_objfiles_safe): New.
2131         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2132         * objfiles.c (put_objfile_before): Update comment.
2133         (add_separate_debug_objfile): Likewise.
2134         (free_all_objfiles): Use all_objfiles_safe.
2135         (objfile_purge_solibs): Likewise.
2136
2137 2019-01-09  Tom Tromey  <tom@tromey.com>
2138
2139         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2140         (expand_symtab_containing_pc, lookup_static_symbol)
2141         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2142         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2143         all_objfiles.
2144         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2145         * breakpoint.c (create_overlay_event_breakpoint)
2146         (create_longjmp_master_breakpoint)
2147         (create_std_terminate_master_breakpoint)
2148         (create_exception_master_breakpoint): Use all_objfiles.
2149         * linux-thread-db.c (try_thread_db_load_from_pdir)
2150         (has_libpthread): Use all_objfiles.
2151         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2152         * linespec.c (iterate_over_all_matching_symtabs)
2153         (search_minsyms_for_name): Use all_objfiles.
2154         * maint.c (maintenance_info_sections): Use all_objfiles.
2155         * main.c (captured_main_1): Use all_objfiles.
2156         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2157         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2158         * guile/scm-pretty-print.c
2159         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2160         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2161         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2162         (maintenance_print_msymbols): Use all_objfiles.
2163         * source.c (select_source_symtab): Use all_objfiles.
2164         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2165         * symfile.c (remove_symbol_file_command)
2166         (expand_symtabs_matching, map_symbol_filenames): Use
2167         all_objfiles.
2168         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2169         all_objfiles.
2170         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2171         * objc-lang.c (find_methods): Use all_objfiles.
2172         * objfiles.c (have_partial_symbols, have_full_symbols)
2173         (have_minimal_symbols, qsort_cmp)
2174         (default_iterate_over_objfiles_in_search_order): Use
2175         all_objfiles.
2176         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2177         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2178         (maintenance_check_psymtabs): Use all_objfiles.
2179         (ALL_PSYMTABS): Remove.
2180         * compile/compile-object-run.c (do_module_cleanup): Use
2181         all_objfiles.
2182         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2183         * cp-support.c (add_symbol_overload_list_qualified): Use
2184         all_objfiles.
2185         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2186         Use all_objfiles.
2187         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2188         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2189         all_objfiles.
2190         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2191         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2192         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2193         Uses all_objfiles.
2194         * solib.c (solib_read_symbols): Use all_objfiles
2195
2196 2019-01-09  Tom Tromey  <tom@tromey.com>
2197
2198         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2199         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2200         all_objfiles.
2201         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2202         * symmisc.c (print_symbol_bcache_statistics)
2203         (print_objfile_statistics, maintenance_print_objfiles)
2204         (maintenance_info_symtabs, maintenance_check_symtabs)
2205         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2206         all_objfiles.
2207         * source.c (forget_cached_source_info): Use all_objfiles.
2208         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2209         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2210         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2211         * objfiles.c (update_section_map): Use all_objfiles.
2212         (shared_objfile_contains_address_p): Likewise.
2213         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2214         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2215
2216 2019-01-09  Tom Tromey  <tom@tromey.com>
2217
2218         * common/next-iterator.h: New file.
2219         * objfiles.h (class all_objfiles): New.
2220         (struct objfile_iterator): New.
2221
2222 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2223
2224         * NEWS: Move the description of the changed "frame", "select-frame",
2225          and "info frame" commands to the Changed commands section.
2226
2227 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2228
2229         * gdbtypes.c (check_stub_method_group): Remove handling of old
2230         mangling schemes.
2231         * linespec.c (find_methods): Likewise.
2232         * stabsread.c (read_member_functions): Likewise.
2233         * valops.c (search_struct_method): Likewise.
2234         (value_struct_elt_for_reference): Likewise.
2235         * NEWS: Mention this change.
2236
2237 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2238
2239         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2240         print_source_lines.
2241         * source.c (print_source_lines_base): Update line number check.
2242         (print_source_lines): New function.
2243         (source_lines_range::source_lines_range): New function.
2244         * source.h (class source_lines_range): New class.
2245         (print_source_lines): New declaration.
2246
2247 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2248
2249         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2250
2251 2019-01-08  Tom Tromey  <tom@tromey.com>
2252             Simon Marchi  <simon.marchi@ericsson.com>
2253
2254         PR gdb/24060
2255         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2256         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2257         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2258         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2259         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2260         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2261
2262 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2263
2264         * source.c (select_source_symtab): Move header comment to
2265         declaration in source.h.
2266         (forget_cached_source_info_for_objfile): Likewise.
2267         (forget_cached_source_info): Likewise.
2268         (identify_source_line): Likewise.
2269         * source.h (identify_source_line): Move declaration from symtab.h
2270         and add comment from source.c
2271         (print_source_lines): Likewise.
2272         (forget_cached_source_info_for_objfile): Likewise.
2273         (forget_cached_source_info): Likewise.
2274         (select_source_symtab): Likewise.
2275         (enum print_source_lines_flag): Move definition from symtab.h.
2276         * symtab.h (identify_source_line): Move declaration to source.h.
2277         (print_source_lines): Likewise.
2278         (forget_cached_source_info_for_objfile): Likewise.
2279         (forget_cached_source_info): Likewise.
2280         (select_source_symtab): Likewise.
2281         (enum print_source_lines_flag): Move definition to source.h.
2282         * tui/tui-hooks.c: Add 'source.h' include.
2283
2284 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2285
2286         * source.c (print_source_lines_base): Handle requests to print
2287         reverse line number sequences, and guard against empty lines
2288         string.
2289
2290 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2291
2292         * source.c (print_source_lines_base): Fix skip of '\r' if next
2293         character is '\n'.
2294
2295 2019-01-06  Tom Tromey  <tom@tromey.com>
2296
2297         * c-exp.y (struct c_parse_state) <macro_original_text,
2298         expansion_obstack>: New member.
2299         (macro_original_text, expansion_obstack): Remove globals.
2300         (scan_macro_expansion, scanning_macro_expansion)
2301         (finished_macro_expansion): Update.
2302         (scan_macro_cleanup): Remove.
2303         (yylex, c_parse): Update.
2304
2305 2019-01-06  Tom Tromey  <tom@tromey.com>
2306
2307         * c-exp.y (struct c_parse_state) <strings>: New member.
2308         (operator_stoken): Update.
2309
2310 2019-01-06  Tom Tromey  <tom@tromey.com>
2311
2312         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2313         (union type_stack_elt) <typelist_val>: Now a pointer to
2314         std::vector.
2315         (type_stack_cleanup): Don't declare.
2316         (push_typelist): Update.
2317         * parse.c (pop_typelist): Return a std::vector.
2318         (push_typelist): Take a std::vector.
2319         (follow_types): Update.  Do not free args.
2320         (type_stack_cleanup): Remove.
2321         * c-exp.y (struct c_parse_state): New.
2322         (cpstate): New global.
2323         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2324         (nonempty_typelist): Update.
2325         (func_mod): Create a new vector.
2326         (c_parse): Create a c_parse_state.
2327         (check_parameter_typelist): Do not delete params.
2328         (function_method): Update.  Do not delete type_list.
2329
2330 2019-01-06  Tom Tromey  <tom@tromey.com>
2331
2332         PR gdb/28155:
2333         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2334         check_typedef.
2335         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2336         (print_return_value): Likewise.
2337
2338 2019-01-05  Tom Tromey  <tom@tromey.com>
2339
2340         * contrib/cleanup_check.py: Remove.
2341         * contrib/gcc-with-excheck: Remove.
2342         * contrib/exsummary.py: Remove.
2343         * contrib/excheck.py: Remove.
2344
2345 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2346
2347         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2348         NULL. Initialize tpprev to NULL instead of assigning it
2349         to NULL on the next statement.
2350         * windows-nat.c (windows_delete_thread): Remove check for
2351         main_thread_id before printing thread exit notifications.
2352         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2353         Remove thread ID check against main_thread_id.
2354         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2355         windows_delete_thread.
2356         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2357
2358 2019-01-04  Tom Tromey  <tom@tromey.com>
2359
2360         * compile/compile.c (_initialize_compile): Use upper case for
2361         metasyntactic variables.
2362         * symmisc.c (_initialize_symmisc): Use upper case for
2363         metasyntactic variables.
2364         * psymtab.c (_initialize_psymtab): Use upper case for
2365         metasyntactic variables.
2366         * demangle.c (demangle_command): Use upper case for metasyntactic
2367         variables.
2368         (_initialize_demangler): Likewise.
2369         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2370         variables.
2371
2372 2019-01-03  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2375
2376 2019-01-03  Tom Tromey  <tom@tromey.com>
2377
2378         * python/py-symtab.c (salpy_str): Update.
2379         (struct salpy_sal_object) <symtab>: Now a PyObject.
2380         (salpy_dealloc): Update.
2381         (del_objfile_sal): Use gdbpy_ref.
2382
2383 2019-01-03  Tom Tromey  <tom@tromey.com>
2384
2385         * python/py-type.c (convert_field): Use new_reference.  Return
2386         gdbpy_ref.
2387         (make_fielditem): Return gdbpy_ref.
2388         (typy_fields): Update.
2389         (typy_getitem): Update.
2390         (field_name): Return gdbpy_ref.  Use new_reference.
2391         (typy_iterator_iternext): Update.
2392
2393 2019-01-03  Tom Tromey  <tom@tromey.com>
2394
2395         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2396
2397 2019-01-03  Tom Tromey  <tom@tromey.com>
2398
2399         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2400         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2401         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2402         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2403         (pspy_set_type_printers): Likewise.
2404         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2405         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2406         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2407         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2408         (objfpy_set_type_printers): Likewise.
2409
2410 2019-01-03  Tom Tromey  <tom@tromey.com>
2411
2412         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2413         (gdbpy_print_stack): Use gdbpy_err_fetch.
2414         * python/python-internal.h (class gdbpy_err_fetch): New class.
2415         (class gdbpy_enter) <m_error_type, m_error_value,
2416         m_error_traceback>: Remove.
2417         <m_error>: New member.
2418         (gdbpy_exception_to_string): Don't declare.
2419         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2420         * python/py-value.c (convert_value_from_python): Use
2421         gdbpy_err_fetch.
2422         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2423         gdbpy_exception_to_string.
2424         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2425         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2426         gdbpy_err_fetch.
2427
2428 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2429
2430         * linux-nat.c (delete_lwp_cleanup): Delete.
2431         (struct lwp_deleter): New struct.
2432         (lwp_info_up): New typedef.
2433         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2434         lwp_info_up.
2435
2436 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2437
2438         * linux-fork.c (class scoped_switch_fork_info): New class.
2439         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2440
2441 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2442
2443         * valops.c (find_overload_match): Remove use of null_cleanup, and
2444         calls to do_cleanups.
2445
2446 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2447
2448         * compile/compile-cplus-types.c
2449         (compile_cplus_instance::decl_name): Handle changes to
2450         cp_func_name.
2451         * cp-support.c (cp_func_name): Update header comment, update
2452         return type.
2453         * cp-support.h (cp_func_name): Update return type in declaration.
2454         * valops.c (find_overload_match): Move temp_func local to top
2455         level of function and change its type.  Use temp_func to hold and
2456         delete temporary string obtained from cp_func_name.
2457
2458 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2459
2460         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2461         gdb::char_vector, remove cleanup, and update uses of `msg`.
2462
2463 2019-01-03  Jim Wilson  <jimw@sifive.com>
2464
2465         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2466
2467 2019-01-02  Tom Tromey  <tom@tromey.com>
2468
2469         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2470         (tdesc_parse_xml): Remove cleanups.
2471         * target-descriptions.h (make_cleanup_free_target_description):
2472         Don't declare.
2473         (target_desc_deleter): New struct.
2474         (target_desc_up): New typedef.
2475         * target-descriptions.c (target_desc_deleter::operator()): Rename
2476         from free_target_description.
2477         (make_cleanup_free_target_description): Remove.
2478
2479 2019-01-02  Tom Tromey  <tom@tromey.com>
2480
2481         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2482         constructor, destructor.
2483         (linespec_parser): Remove typedef.
2484         (~linespec_parser): Rename from linespec_parser_delete.
2485         (linespec_lex_to_end, linespec_complete_label)
2486         (linespec_complete): Update.
2487         (decode_line_full): Remove cleanups.
2488         (decode_line_1): Update.
2489
2490 2019-01-02  Tom Tromey  <tom@tromey.com>
2491
2492         * python/python-internal.h (inferior_to_inferior_object): Change
2493         return type.
2494         * python/py-exitedevent.c (create_exited_event_object): Update.
2495         * python/py-inferior.c (inferior_to_inferior_object): Return
2496         gdbpy_ref.
2497         (python_new_inferior, python_inferior_deleted)
2498         (thread_to_thread_object, delete_thread_object)
2499         (build_inferior_list, gdbpy_selected_inferior): Update.
2500         * python/py-infthread.c (create_thread_object): Update.  Also fail
2501         if inferior_to_inferior_object fails.
2502
2503 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2504
2505         * inferior.h (class inferior) <displaced_step_state>: New field.
2506         * infrun.h (struct displaced_step_state): Move here from
2507         infrun.c.  Initialize fields, add constructor.
2508         <inf>: Remove field.
2509         <reset>: New method.
2510         * infrun.c (struct displaced_step_inferior_state): Move to
2511         infrun.h.
2512         (displaced_step_inferior_states): Remove.
2513         (get_displaced_stepping_state): Adust.
2514         (displaced_step_in_progress_any_inferior): Adjust.
2515         (displaced_step_in_progress_thread): Adjust.
2516         (displaced_step_in_progress): Adjust.
2517         (add_displaced_stepping_state): Remove.
2518         (get_displaced_step_closure_by_addr): Adjust.
2519         (remove_displaced_stepping_state): Remove.
2520         (infrun_inferior_exit): Call displaced_step_state.reset.
2521         (use_displaced_stepping): Don't check for NULL.
2522         (displaced_step_prepare_throw): Call
2523         get_displaced_stepping_state.
2524         (displaced_step_fixup): Don't check for NULL.
2525         (prepare_for_detach): Don't check for NULL.
2526
2527 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2528
2529         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2530          in case of call that did not complete.
2531
2532 2019-01-02  Andrey Utkin  <autkin@undo.io>
2533
2534         * symfile.c (find_separate_debug_file): Fix search of debug files for
2535         remote debuggee.
2536
2537 2019-01-02  Tom Tromey  <tom@tromey.com>
2538
2539         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2540         indentation.
2541         * python/py-frame.c (frapy_older): Remove cast.
2542         (frapy_newer): Likewise.
2543         * python/py-breakpoint.c (local_setattro): Remove cast.
2544         * python/py-arch.c (archpy_name): Remove local variable.
2545         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2546
2547 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2548
2549         * unittests/basic_string_view/element_access/char/empty.cc:
2550         Fix year range in copyright header.
2551
2552 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2555         Delete.
2556         <operator==>: Update with for removed field.
2557         <hash>: Likewise.
2558         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2559         <isa_features>: ...this.
2560         <abi_features>: New field.
2561         (riscv_isa_flen): Update comment.
2562         (riscv_abi_xlen): New declaration.
2563         (riscv_abi_flen): New declaration.
2564         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2565         isa_features.
2566         (riscv_abi_xlen): New function.
2567         (riscv_isa_flen): Update to get answer from isa_features.
2568         (riscv_abi_flen): New function.
2569         (riscv_has_fp_abi): Update to get answer from abi_features.
2570         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2571         xlen and flen.
2572         (riscv_call_info) <xlen, flen>: Update comment.
2573         (riscv_call_arg_struct): Remove invalid assertions
2574         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2575         is removed.
2576         (riscv_gdbarch_init): Gather isa features and abi features
2577         separately, ensure both match on the gdbarch when reusing an old
2578         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2579         a target with 64-bit float hardware.
2580
2581 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2582
2583         * source.c (search_command_helper): Stop reverse search
2584         when line 1 has been searched.
2585
2586 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2587
2588         * record-full.c (record_full_base_target::close): Rewrite
2589         record_full_core_buf_list free logic.
2590
2591 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2592
2593         * break-catch-syscall.c (print_one_catch_syscall): xfree
2594         the last text.
2595
2596 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2597
2598         * top.c (print_gdb_version): Update Copyright year in version
2599         message.
2600
2601 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2602
2603         Update copyright year range in all GDB files.
2604
2605 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2606
2607         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2608
2609 For older changes see ChangeLog-2018.
2610 \f
2611 Local Variables:
2612 mode: change-log
2613 left-margin: 8
2614 fill-column: 74
2615 version-control: never
2616 coding: utf-8
2617 End:
2618