gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
   4         Now static.
   5         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
   6         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
   7
   8 2019-07-17  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui.c: Update.
  11         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
  12         tui-regs.c.
  13         * tui/tui-windata.h: Remove file.
  14         * tui/tui-windata.c: Remove file.
  15         * tui/tui-win.c (tui_data_window::set_new_height)
  16         (tui_data_window::do_make_visible_with_new_height): Move to
  17         tui-regs.c.
  18         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
  19         * tui/tui-regs.c: Remove "structuring" comments.
  20         (tui_data_window::first_data_item_displayed)
  21         (tui_data_window::delete_data_content_windows)
  22         (tui_data_window::erase_data_content)
  23         (tui_data_window::display_all_data)
  24         (tui_data_window::refresh_all)
  25         (tui_data_window::do_scroll_vertical)
  26         (tui_data_window::clear_detail, tui_data_window::set_new_height)
  27         (tui_data_window::do_make_visible_with_new_height)
  28         (tui_data_window::refresh_window): Move from elsewhere.
  29         (_initialize_tui_regs): Move to end of file.
  30         * tui/tui-layout.c: Update.
  31         * tui/tui-hooks.c: Update.
  32         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
  33         * tui/tui-data.c (tui_data_window::clear_detail): Move to
  34         tui-regs.c.
  35         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
  36
  37 2019-07-17  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
  40         seen.
  41
  42 2019-07-17  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-win.c (tui_source_window_base::set_new_height)
  45         (tui_source_window_base::do_make_visible_with_new_height): Use
  46         m_has_locator field directly.
  47         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
  48         method.
  49         (struct tui_source_window_base) <has_locator>: Likewise.
  50
  51 2019-07-17  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
  54         Don't declare.
  55         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
  56         Remove.
  57         * tui/tui-win.c (tui_source_window_base::set_new_height)
  58         (tui_source_window_base::set_new_height)
  59         (make_invisible_and_set_new_height)
  60         (tui_source_window_base::do_make_visible_with_new_height)
  61         (tui_source_window_base::do_make_visible_with_new_height):
  62         Update.
  63         * tui/tui-layout.c (show_source_disasm_command, show_data)
  64         (show_source_or_disasm_and_command): Update.
  65         * tui/tui-layout.c (show_layout): Update.
  66
  67 2019-07-17  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-layout.c (make_data_window): Remove.
  70         (show_data): Unify creation and re-initialization cases.
  71
  72 2019-07-17  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui-layout.c (make_source_window, make_disasm_window):
  75         Remove.
  76         (show_data): Unify creation and re-initialization cases.
  77
  78 2019-07-17  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-layout.c (make_command_window): Remove.
  81         (show_source_disasm_command, show_source_or_disasm_and_command):
  82         Unify creation and re-initialization cases.
  83
  84 2019-07-17  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
  87         creation and re-initialization cases.
  88
  89 2019-07-17  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-regs.c (tui_get_register): Return void.
  92
  93 2019-07-17  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
  96         Simplify.
  97
  98 2019-07-17  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 101         resetting.
 102
 103 2019-07-17  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 106         * tui/tui-regs.c (tui_reg_layout): New function.
 107         (tui_show_registers, tui_reg_command): Use it.
 108         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 109         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 110         parameters.
 111         (tui_layout_command): Remove.
 112
 113 2019-07-17  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-layout.h (tui/tui-layout): Return void.
 116         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 117
 118 2019-07-17  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-layout.c (show_source_disasm_command, show_data):
 121         Update.
 122         (reset_locator): Remove.
 123         (show_source_or_disasm_and_command): Update.
 124
 125 2019-07-17  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-source.c (tui_source_window_base::reset): Remove
 128         win_type parameter.
 129         * tui/tui-layout.c (make_command_window, make_source_window)
 130         (make_disasm_window, make_data_window)
 131         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 132         (reset_locator, show_source_or_disasm_and_command): Update.
 133         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 134         win_type parameter.
 135         (struct tui_source_window_base) <reset>: Likewise.
 136
 137 2019-07-17  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-layout.c (show_source_disasm_command): Use
 140         reset_locator.
 141         (reset_locator): New function.
 142         (init_and_make_win): Remove.
 143         (show_source_or_disasm_and_command): Use reset_locator.
 144
 145 2019-07-17  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 148         condition.
 149         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 150         Remove condition.
 151         * tui/tui-source.c (tui_source_window_base::reset): New method.
 152         * tui/tui-layout.c (make_command_window): Don't call
 153         init_and_make_win.
 154         (make_source_window, make_disasm_window): Don't call
 155         make_source_or_disasm_window.
 156         (make_data_window): Don't call init_and_make_win.  Change calling
 157         convention.
 158         (show_source_disasm_command, show_data): Simplify.
 159         (make_source_or_disasm_window): Remove.
 160         (show_source_or_disasm_and_command): Simplify.
 161         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 162         (struct tui_source_window_base) <reset>: Likewise.
 163         <execution_info>: Remove initializer.
 164         * tui/tui-data.c (tui_source_window_base): Initialize
 165         execution_info.
 166
 167 2019-07-17  Tom Tromey  <tom@tromey.com>
 168
 169         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 170         variable.
 171
 172 2019-07-17  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui.c (tui_rl_other_window): Update.
 175         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 176         superclass method first.  Always iterate over regs_content.
 177         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 178         method.
 179         * tui/tui-win.c (tui_set_focus_command): Update.
 180
 181 2019-07-17  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-win.c (tui_set_focus_command): Rename from
 184         tui_set_focus.  Call tui_enable.
 185         (tui_set_focus_command): Remove.
 186
 187 2019-07-17  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 190         refresh_window.
 191         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 192         touchwin.
 193         (tui_data_window::refresh_window): Call refresh_window on data
 194         items.  Always call superclass refresh_window.
 195         (tui_win_info::refresh): Remove.
 196         (tui_source_window_base::refresh_window): Update.
 197         (tui_refresh_all): Update.
 198         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 199         refresh_window.
 200         (show_source_or_disasm_and_command): Likewise.
 201         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 202         (struct tui_source_window_base) <refresh>: Likewise.
 203
 204 2019-07-17  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-winsource.c (tui_clear_source_content)
 207         (tui_show_source_content): Update.
 208         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 209         whether content is empty.
 210         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 211         Remove.
 212
 213 2019-07-17  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 216         window's contents.
 217         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 218         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 219
 220 2019-07-17  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 223         (struct tui_data_item_window): Update.
 224
 225 2019-07-17  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 228         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 229         defines.
 230
 231 2019-07-17  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-winsource.h (tui_erase_source_content)
 234         (tui_clear_source_content): Remove "display_prompt" parameter.
 235         * tui/tui-winsource.c (tui_update_source_window_as_is)
 236         (tui_update_source_windows_with_addr): Update.
 237         (tui_clear_source_content): Remove "display_prompt" parameter.
 238         (tui_erase_source_content): Likewise.  Simplify.
 239         (tui_show_source_content): Update.
 240         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 241         * tui/tui-stack.c (tui_show_frame_info): Update.
 242         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 243         Remove defines.
 244
 245 2019-07-17  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 248         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 249         parameter.
 250         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 251         parameter.
 252
 253 2019-07-17  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-winsource.c (tui_clear_source_content)
 256         (tui_show_source_content, tui_show_exec_info_content)
 257         (tui_clear_exec_info_content): Update.
 258         * tui/tui-stack.c (tui_show_locator_content): Update.
 259         (tui_show_frame_info): Update.
 260         * tui/tui-source.h (tui_source_window): Don't declare.
 261         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 262         from tui_source_is_displayed.
 263         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 264         Remove field.
 265         (struct tui_source_window_base) <content_in_use>: New field.  Now
 266         bool.
 267         (struct tui_source_window) <showing_source_p>: New method.
 268         (TUI_SRC_WIN): Change cast.
 269         * tui/tui-data.c (tui_initialize_static_data): Update.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 274         location_matches_p.
 275         * tui/tui-source.c (tui_source_window::location_matches_p): New
 276         method.
 277         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 278         method.
 279         * tui/tui-data.h (struct tui_source_window_base)
 280         <location_matches_p>: New method.
 281         (struct tui_source_window, struct tui_disasm_window)
 282         <location_matches_p>: Likewise.
 283
 284 2019-07-17  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-win.c (tui_set_win_height_command): Rename from
 287         tui_set_win_height.
 288         (tui_set_win_height_command): Remove.
 289
 290 2019-07-17  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-source.c (tui_source_window): New constructor.  Add
 293         observer.
 294         (~tui_source_window): New destructor.
 295         (tui_source_window::style_changed): New method.
 296         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 297         (tui_attach_detach_observers): Update.
 298         * tui/tui-data.h (struct tui_source_window): Make constructor not
 299         inline.  Add destructor.
 300         (struct tui_source_window) <style_changed>: New method.
 301         <m_observable>: New member.
 302
 303 2019-07-17  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 306         * tui/tui-win.c (tui_resize_all): Fix typo.
 307
 308 2019-07-17  Tom Tromey  <tom@tromey.com>
 309
 310         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 311         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 312         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 313         * tui/tui-win.c (window_name_completer): Use foreach.
 314         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 315         (update_tab_width): Likewise.
 316         * tui/tui-layout.c (show_layout): Update.
 317         * tui/tui-data.h (class tui_window_iterator): New.
 318         (struct all_tui_windows): New.
 319         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 320
 321 2019-07-17  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 324         parameter.  Don't reference globals.
 325         (tui_reg_command): Update.
 326
 327 2019-07-17  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-regs.c (tui_show_registers): Simplify.
 330
 331 2019-07-17  Tom Tromey  <tom@tromey.com>
 332
 333         * tui/tui-regs.c (tui_show_registers): Update.
 334         (tui_show_register_group): Add win_info parameter.
 335
 336 2019-07-17  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 339         Rename from tui_display_reg_element_at_line.
 340         (tui_data_window::display_registers_from_line): Update.
 341         * tui/tui-data.h (struct tui_data_window)
 342         <display_reg_element_at_line>: New method.
 343
 344 2019-07-17  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-regs.h (tui_display_registers_from)
 347         (tui_display_registers_from_line): Don't declare.
 348         * tui/tui-windata.c (tui_data_window::display_all_data)
 349         (tui_data_window::refresh_all)
 350         (tui_data_window::do_scroll_vertical): Update.
 351         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 352         from tui_display_registers_from.
 353         (tui_display_reg_element_at_line): Update.
 354         (tui_data_window::display_registers_from_line): Rename from
 355         tui_display_registers_from_line.
 356         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 357         display_registers_from_line>: New methods.
 358
 359 2019-07-17  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 362         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 363         from tui_erase_data_content.
 364         (tui_data_window::display_all_data)
 365         (tui_data_window::refresh_all)
 366         (tui_data_window::do_scroll_vertical): Update.
 367         * tui/tui-regs.c (tui_show_registers): Update.
 368         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 369         New method.
 370
 371 2019-07-17  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 374         declare.
 375         * tui/tui-windata.c
 376         (tui_data_window::delete_data_content_windows): Rename from
 377         tui_delete_data_content_windows.
 378         (tui_data_window::display_all_data)
 379         (tui_data_window::do_scroll_vertical): Update.
 380         * tui/tui-data.h (struct tui_data_window)
 381         <delete_data_content_windows>: New method.
 382
 383 2019-07-17  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 386         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 387
 388 2019-07-17  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 391         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 392         from tui_display_all_data.
 393         * tui/tui-win.c
 394         (tui_data_window::do_make_visible_with_new_height): Update.
 395         * tui/tui-regs.c (tui_show_registers): Update.
 396         * tui/tui-layout.c (tui_set_layout): Update.
 397         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 398         method.
 399
 400 2019-07-17  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 403         * tui/tui-windata.c (tui_display_data_from): Remove.
 404         (tui_data_window::refresh_all): Update.
 405
 406 2019-07-17  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 409         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 410         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 411         tui_display_registers_from_line.
 412         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 413         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 414         "force_display" parameter.
 415
 416 2019-07-17  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 419         declare.
 420         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 421         Rename from tui_first_reg_element_no_inline.
 422         (tui_display_reg_element_at_line)
 423         (tui_display_registers_from_line): Update.
 424         * tui/tui-data.h (struct tui_data_window)
 425         <first_reg_element_no_inline>: New method.
 426
 427 2019-07-17  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-windata.c (tui_display_data_from)
 430         (tui_data_window::do_scroll_vertical): Update.
 431         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 432         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 433         Rename from tui_line_from_reg_element_no.
 434         (tui_display_registers_from_line): Update.
 435         * tui/tui-data.h (struct tui_data_window)
 436         <line_from_reg_element_no>: New method.
 437
 438 2019-07-17  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 441         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 442         tui_last_regs_line_no.
 443         (tui_display_reg_element_at_line)
 444         (tui_display_registers_from_line): Update.
 445         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 446         method.
 447
 448 2019-07-17  Tom Tromey  <tom@tromey.com>
 449
 450         PR tui/24722:
 451         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 452         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 453         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 454         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 455         (tui_update_breakpoint_info): Likewise.
 456         * tui/tui-hooks.c (tui_event_create_breakpoint)
 457         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 458         Update.
 459
 460 2019-07-17  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 463
 464 2019-07-17  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-winsource.c (tui_update_source_window_as_is)
 467         (tui_update_source_windows_with_addr): Update.
 468         * tui/tui-source.h (tui_set_source_content)
 469         (tui_show_symtab_source): Add "win_info" parameter.
 470         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 471         parameter.
 472         (tui_show_symtab_source): Likewise.
 473
 474 2019-07-17  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-wingeneral.c
 477         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 478
 479 2019-07-17  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 482         (struct tui_cmd_window) <can_scroll>: New method.
 483         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 484         method.
 485
 486 2019-07-17  Tom Tromey  <tromey@adacore.com>
 487
 488         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 489         do_field_signed>: Rename.  Change type of "value".
 490         * ui-out.c (ui_out::field_signed): Rename from field_int.
 491         Change type of "value".
 492         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 493         type of "value".
 494         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 495         do_field_int.  Change type of "value".
 496         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 497         do_field_int.  Change type of "value".
 498         * tracepoint.c (trace_status_mi, tfind_1)
 499         (print_one_static_tracepoint_marker): Update.
 500         * thread.c (print_thread_info_1, print_selected_thread_frame):
 501         Update.
 502         * stack.c (print_frame, print_frame_info): Update.
 503         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 504         Update.
 505         * source.c (print_source_lines_base): Update.
 506         * skip.c (info_skip_command): Update.
 507         * record-btrace.c (btrace_ui_out_decode_error)
 508         (btrace_call_history_src_line): Update.
 509         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 510         Update.
 511         * progspace.c (print_program_space): Update.
 512         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 513         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 514         do_field_int.  Change type of "value".
 515         * mi/mi-out.c (mi_ui_out::do_table_begin)
 516         (mi_ui_out::do_table_header): Update.
 517         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 518         type of "value".
 519         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 520         (mi_cmd_data_list_changed_registers, output_register)
 521         (mi_cmd_data_read_memory, mi_load_progress)
 522         (mi_cmd_trace_frame_collected): Update.
 523         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 524         Update.
 525         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 526         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 527         (mi_cmd_var_list_children, varobj_update_one): Update.
 528         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 529         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 530         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 531         * inferior.c (print_inferior): Update.
 532         * gdb_bfd.c (print_one_bfd): Update.
 533         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 534         Update.
 535         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 536         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 537         do_field_int.  Change type of "value".
 538         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 539         do_field_int.  Change type of "value".
 540         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 541         (print_one_breakpoint_location, print_it_catch_fork)
 542         (print_one_catch_fork, print_it_catch_vfork)
 543         (print_one_catch_vfork, print_it_catch_solib)
 544         (print_it_catch_exec, print_it_ranged_breakpoint)
 545         (print_mention_watchpoint, print_mention_masked_watchpoint)
 546         (bkpt_print_it, update_static_tracepoint): Update.
 547         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 548         * break-catch-syscall.c (print_it_catch_syscall): Update.
 549         * ada-tasks.c (print_ada_task_info): Update.
 550         * ada-lang.c (print_it_exception, print_mention_exception):
 551         Update.
 552
 553 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 554
 555         PR breakpoints/24541
 556         * gdbarch.c: Regenerate.
 557         * gdbarch.h: Regenerate.
 558         * gdbarch.sh: Adjust return type and parameter types for
 559         'stap_adjust_register'.
 560         (i386_stap_adjust_register): Adjust signature and return new
 561         register name.
 562         * stap-probe.c (stap_parse_register_operand): Adjust use of
 563         'gdbarch_stap_adjust_register'.
 564
 565 2019-07-17  Tom Tromey  <tromey@adacore.com>
 566
 567         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 568         declare VEC.
 569         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 570         std::vector.
 571         (struct s390_process_info): Add initializers.
 572         (s390_add_process): Use new.
 573         (s390_linux_nat_target::low_forget_process): Use delete.
 574         (s390_linux_nat_target::low_new_fork)
 575         (s390_linux_nat_target::stopped_by_watchpoint)
 576         (s390_linux_nat_target::low_prepare_to_resume)
 577         (s390_linux_nat_target::insert_watchpoint)
 578         (s390_linux_nat_target::insert_hw_breakpoint)
 579         (s390_linux_nat_target::remove_watchpoint)
 580         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 581
 582 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 583
 584         * aarch64-fbsd-nat.c: Include regcache.h.
 585         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 586         argument.
 587         (aarch64_fbsd_nat_target::fetch_registers)
 588         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 589         variable.
 590         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 591
 592 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 593
 594         * fbsd-nat.c: Include gdbarch.h.
 595
 596 2019-07-15  Tom Tromey  <tromey@adacore.com>
 597
 598         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 599
 600 2019-07-15  Tom Tromey  <tromey@adacore.com>
 601
 602         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 603         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 604         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 605         * cli-out.c (cli_ui_out::do_field_int): New method.
 606         * ui-out.c (ui_out::field_unsigned): New method.
 607         * symfile.c (generic_load): Use field_unsigned.
 608         (print_transfer_performance): Likewise.
 609         * record-btrace.c (ui_out_field_uint): Remove.
 610         (btrace_call_history_insn_range, btrace_call_history): Use
 611         field_unsigned.
 612         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 613         field_unsigned.
 614         * ui-out.h (class ui_out) <field_unsigned>: New method.
 615         <do_field_unsigned>: Likewise.
 616
 617 2019-07-15  Tom Tromey  <tromey@adacore.com>
 618
 619         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 620         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 621         * target.c (flash_erase_command): Use field_string.
 622         * infrun.c (print_signal_received_reason): Use field_string.
 623         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 624         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 625         field_string.
 626         * ada-tasks.c (print_ada_task_info): Use field_string.
 627
 628 2019-07-15  Tom Tromey  <tromey@adacore.com>
 629
 630         * target.c (flash_erase_command): Use field_core_addr.
 631         * symfile.c (generic_load): Use field_core_addr.
 632         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 633         Use field_core_addr.
 634         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 635         field_core_addr.
 636
 637 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 638
 639         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 640         value if its desired type is smaller than a CORE_ADDR and signed.
 641
 642 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 643
 644         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 645         of changes to field names, and use new is_reference field to
 646         decide if a property is a reference or not.
 647         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 648         field.
 649         (struct dwarf2_property_baton): Update header comment, rename
 650         'referenced_type' to 'property_type' and update comments.
 651         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 652         default property type, store in property baton, update to take
 653         accound of renamed field.
 654         (read_func_scope): Update call to attr_to_dynamic_prop.
 655         (read_array_type): Likewise.
 656         (dwarf2_per_cu_addr_sized_int_type): New function.
 657         (read_subrange_index_type): Move type finding code to
 658         dwarf2_per_cu_addr_sized_int_type.
 659         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 660         (dwarf2_per_cu_addr_type): New function.
 661         (set_die_type): Update calls to attr_to_dynamic_prop.
 662
 663 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 664
 665         * dwarf2read.c (read_subrange_index_type): New function.
 666         (read_subrange_type): Move code into new function and call it.
 667         * gdbtypes.c (create_range_type): Add some asserts.
 668
 669 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 670
 671         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 672         update return statements.
 673         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 674         declaration, and update comment to match.
 675         * gdbtypes.c (resolve_dynamic_array): Update call to
 676         dwarf2_evaluate_property to match new return type.
 677
 678 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 679
 680         * valarith.c (value_subscripted_rvalue): Change lowerbound
 681         parameter type from int to LONGEST.
 682         * value.h (value_subscripted_rvalue): Likewise in declaration.
 683
 684 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 685
 686         * cli/cli-utils.c (info_print_command_completer): New function.
 687         * cli/cli-utils.h: Add 'completer.h' include, and forward
 688         declaration for 'struct cmd_list_element'.
 689         (info_print_command_completer): Declare.
 690         * stack.c (_initialize_stack): Add completer for 'info locals' and
 691         'info args'.
 692         * symtab.c (_initialize_symtab): Add completer for 'info
 693         variables' and 'info functions'.
 694         * NEWS: Mention completion for additional info commands.
 695
 696 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 697
 698         * cli/cli-utils.c (extract_info_print_args): Delete.
 699         (extract_arg_maybe_quoted): Delete.
 700         (info_print_options_defs): New variable.
 701         (make_info_print_options_def_group): New function.
 702         (extract_info_print_options): Define new function.
 703         * cli/cli-utils.h (extract_info_print_args): Delete.
 704         (struct info_print_options): New structure.
 705         (extract_info_print_options): Declare new function.
 706         * stack.c (info_locals_command): Update to use new
 707         extract_info_print_options, also add a header comment.
 708         (info_args_command): Likewise.
 709         * symtab.c (info_variables_command): Likewise.
 710         (info_functions_command): Likewise.
 711
 712 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 713
 714         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 715         to extract string arguments.
 716         * common/common-utils.c (extract_string_maybe_quoted): New function.
 717         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 718
 719 2019-07-11  Tom Tromey  <tromey@adacore.com>
 720
 721         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 722         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 723         * top.h (gdbinit): Don't declare.
 724         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 725         into...
 726         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 727         * top.c (gdb_init): Don't call init_cli_cmds.
 728         (gdbinit): Remove.
 729         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 730
 731 2019-07-11  Tom Tromey  <tromey@adacore.com>
 732
 733         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 734         after it has been moved.
 735
 736 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 737
 738         * valops.c (value_must_coerce_to_target): Change return type to
 739         bool.
 740         * value.h (value_must_coerce_to_target): Likewise.
 741
 742 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 743
 744         * breakpoint.c (is_hardware_watchpoint): Remove
 745         forward-declaration.
 746         (is_masked_watchpoint): Change return type to bool.
 747         (is_tracepoint): Likewise.
 748         (is_breakpoint): Likewise.
 749         (is_hardware_watchpoint): Likewise.
 750         (is_watchpoint): Likewise.
 751         (is_no_memory_software_watchpoint): Likewise.
 752         (is_catchpoint): Likewise.
 753         (breakpoint_1): Make FILTER parameter's return type bool.
 754         is_masked_watchpoint): Change return type to bool.
 755         (save_breakpoints): Make FILTER parameter's return type bool.
 756         * breakpoint.h (is_breakpoint): Change return type to bool.
 757         (is_watchpoint): Likewise.
 758         (is_catchpoint): Likewise.
 759         (is_tracepoint): Likewise.
 760
 761 2019-07-10  Tom Tromey  <tom@tromey.com>
 762
 763         * defs.h: Don't include gdbarch.h.
 764         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 765         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 766         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 767         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 768         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 769         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 770         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 771         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 772         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 773         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 774         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 775         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 776         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 777         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 778         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 779         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 780         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 781         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 782         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 783         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 784         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 785         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 786         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 787         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 788         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 789         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 790         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 791
 792 2019-07-10  Tom Tromey  <tromey@adacore.com>
 793
 794         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 795         * breakpoint.c (init_ada_exception_breakpoint): Register as
 796         bp_catchpoint.
 797         (print_one_breakpoint_location, print_one_breakpoint): Use
 798         is_ada_exception_catchpoint.
 799         * ada-lang.c (class ada_catchpoint_location): Pass
 800         bp_loc_software_breakpoint to bp_location constructor.
 801         (is_ada_exception_catchpoint): New function.
 802
 803 2019-07-10  Tom Tromey  <tromey@adacore.com>
 804
 805         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 806         VEC.
 807         (struct arm_exidx_entry): New method operator<.
 808         (struct arm_exidx_data) <section_maps>: Change type.
 809         (arm_exidx_data_free): Remove.
 810         (arm_exidx_data_key): Change type.  Move lower.
 811         (arm_exidx_new_objfile): Update.
 812         (arm_compare_exidx_entries): Remove.
 813         (arm_find_exidx_entry, _initialize_arm_tdep)
 814
 815 2019-07-10  Tom Tromey  <tromey@adacore.com>
 816
 817         * solib-spu.c (ocl_program_data_key): Change type.
 818         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 819         Update.
 820
 821 2019-07-10  Tom Tromey  <tromey@adacore.com>
 822
 823         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 824         (struct solib_aix_inferior_data) <library_list>: Change type.
 825         (solib_aix_inferior_data_handle): Change type.
 826         (get_solib_aix_inferior_data): Update.
 827         (solib_aix_free_library_list): Remove.
 828         (library_list_start_library): Update.
 829         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 830         return type.
 831         (solib_aix_get_library_list)
 832         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 833         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 834
 835 2019-07-10  Tom Tromey  <tromey@adacore.com>
 836
 837         * solib-dsbt.c (struct dsbt_info): Add initializers.
 838         (solib_dsbt_pspace_data): Change type.
 839         (dsbt_pspace_data_cleanup): Remove.
 840         (get_dsbt_info, _initialize_dsbt_solib): Update.
 841
 842 2019-07-10  Tom Tromey  <tromey@adacore.com>
 843
 844         * spu-tdep.c (spu_overlay_data): Change type.
 845         (spu_get_overlay_table, spu_overlay_new_objfile)
 846         (_initialize_spu_tdep): Update.
 847
 848 2019-07-10  Tom Tromey  <tromey@adacore.com>
 849
 850         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 851         destructor.
 852         (dbx_objfile_data_key): Change type and declare later.
 853         (DBX_SYMFILE_INFO): Rewrite.
 854         * dbxread.c (dbx_objfile_data_key): Change type.
 855         (dbx_symfile_init): Update.
 856         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 857         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 858         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 859
 860 2019-07-10  Tom Tromey  <tromey@adacore.com>
 861
 862         * jit.c (jit_program_space_key): Change type.  Move lower.
 863         (get_jit_program_space_data): Update.
 864         (jit_program_space_data_cleanup): Remove.
 865         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 866         Update.
 867         (struct jit_program_space_data): Add initializers.
 868
 869 2019-07-10  Tom Tromey  <tromey@adacore.com>
 870
 871         * solib-darwin.c (struct darwin_info): Add initializers.
 872         (solib_darwin_pspace_data): Change type.
 873         (darwin_pspace_data_cleanup): Remove.
 874         (get_darwin_info, _initialize_darwin_solib): Update.
 875
 876 2019-07-10  Tom Tromey  <tromey@adacore.com>
 877
 878         * remote-sim.c (struct sim_inferior_data): Add initializers,
 879         constructor, and destructor.
 880         (sim_inferior_data_key): Change type.  Move lower.
 881         (check_for_duplicate_sim_descriptor): Update.
 882         (get_sim_inferior_data): Use new.  Update.
 883         (~sim_inferior_data_cleanup): Rename from
 884         sim_inferior_data_cleanup.  Simplify.
 885         (gdbsim_close_inferior, simulator_command)
 886         (sim_command_completer, _initialize_remote_sim): Update.
 887         (next_pid, INITIAL_PID): Move earlier.
 888
 889 2019-07-10  Tom Tromey  <tromey@adacore.com>
 890
 891         * python/python-internal.h (create_thread_object): Return
 892         gdbpy_ref.
 893         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 894         * python/py-inferior.c (struct threadlist_entry): Add
 895         constructor.
 896         <thread_obj>: Now a gdbpy_ref.
 897         (thread_to_thread_object): Update.
 898         (add_thread_object): Use new.
 899         (delete_thread_object): Use delete.
 900         (infpy_threads): Update.
 901         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 902         GIL.
 903
 904 2019-07-10  Tom Tromey  <tromey@adacore.com>
 905
 906         * valops.c (value_cast): Specialize error message for Ada.
 907
 908 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 909
 910         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 911
 912 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 913
 914         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 915         bpstat_should_step): Return bool, adjust comments.
 916         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 917         bpstat_should_step): Likewise.
 918
 919 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 920
 921         * features/Makefile: Use feature target descriptions for Arm.
 922         * features/arm/arm-core.c: Generate new file.
 923         * features/arm/arm-fpa.c: Likewise.
 924         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 925         * features/arm/arm-m-profile.c: Likewise.
 926         * features/arm/arm-vfpv2.c: Likewise.
 927         * features/arm/arm-vfpv3.c: Likewise.
 928         * features/arm/xscale-iwmmxt.c: Likewise.
 929         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 930
 931 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 932
 933         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 934         ptrace earlier.
 935
 936 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 937
 938         * features/aarch64-pauth.c: Regenerate.
 939
 940 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 941
 942         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 943         bool.
 944         (bpstat_what): Use false instead of 0.
 945
 946 2019-07-09  Pedro Alves  <palves@redhat.com>
 947
 948         * break-catch-throw.c (is_exception_catchpoint): New.
 949         * breakpoint.c (print_one_breakpoint_location): New parameter
 950         'raw_loc'.  Handle it.  Use
 951         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 952         looking at the breakpoint's type.
 953         (print_one_breakpoint): If handling "maint info breakpoints", also
 954         print locations of exception catchpoints.
 955         * breakpoint.h (is_exception_catchpoint): Declare.
 956
 957 2019-07-09  Pedro Alves  <palves@redhat.com>
 958
 959         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 960         "addr" field.
 961         (allocate_location_exception_catchpoint): New.
 962         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 963         (initialize_throw_catchpoint_ops): Install
 964         allocate_location_exception_catchpoint as allocate_location
 965         method.
 966         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 967         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 968         bp_loc_other.
 969         (breakpoint_address_is_meaningful): Delete.
 970         (bl_address_is_meaningful): New.
 971         (breakpoint_locations_match): Adjust comment.
 972         (bp_location_from_bp_type): New, factored out of...
 973         (bp_location::bp_location(breakpoint *)): ... this.
 974         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 975         factored out of...
 976         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 977         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 978         breakpoint_address_is_meaningful.
 979         (bp_locations_compare): Adjust comment.
 980         (update_global_location_list): Use bl_address_is_meaningful
 981         instead of breakpoint_address_is_meaningful.
 982         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 983         explicit.
 984         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 985         * python/py-breakpoint.c (bppy_get_location): No longer check
 986         whether location is null.
 987
 988 2019-07-09  Pedro Alves  <palves@redhat.com>
 989
 990         PR c++/15468
 991         * breakpoint.c (print_one_breakpoint_location): Remove
 992         single-location assert.
 993
 994 2019-07-09  Tom Tromey  <tom@tromey.com>
 995
 996         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 997         * configure: Rebuild.
 998         * configure.ac: Change common to gdbsupport.
 999         * gdbsupport: Rename from common.
1000         * acinclude.m4: Change common to gdbsupport.
1001         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1002         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1003         gdbsupport.
1004         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1005         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1006         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1007         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1008         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1009         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1010         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1011         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1012         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1013         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1014         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1015         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1016         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1017         coff-pe-read.c, command.h, compile/compile-c-support.c,
1018         compile/compile-c.h, compile/compile-cplus-symbols.c,
1019         compile/compile-cplus-types.c, compile/compile-cplus.h,
1020         compile/compile-loc2c.c, compile/compile.c, completer.c,
1021         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1022         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1023         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1024         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1025         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1026         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1027         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1028         features/aarch64-core.c, features/aarch64-fpu.c,
1029         features/aarch64-pauth.c, features/aarch64-sve.c,
1030         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1031         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1032         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1033         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1034         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1035         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1036         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1037         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1038         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1039         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1040         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1041         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1042         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1043         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1044         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1045         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1046         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1047         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1048         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1049         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1050         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1051         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1052         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1053         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1054         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1055         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1056         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1057         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1058         minsyms.c, mips-linux-tdep.c, namespace.h,
1059         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1060         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1061         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1062         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1063         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1064         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1065         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1066         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1067         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1068         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1069         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1070         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1071         procfs.c, producer.c, progspace.h, psymtab.h,
1072         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1073         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1074         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1075         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1076         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1077         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1078         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1079         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1080         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1081         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1082         target-memory.c, target.c, target.h, target/waitstatus.c,
1083         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1084         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1085         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1086         unittests/array-view-selftests.c,
1087         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1088         unittests/common-utils-selftests.c,
1089         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1090         unittests/format_pieces-selftests.c,
1091         unittests/function-view-selftests.c,
1092         unittests/lookup_name_info-selftests.c,
1093         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1094         unittests/mkdir-recursive-selftests.c,
1095         unittests/observable-selftests.c,
1096         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1097         unittests/parse-connection-spec-selftests.c,
1098         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1099         unittests/scoped_fd-selftests.c,
1100         unittests/scoped_mmap-selftests.c,
1101         unittests/scoped_restore-selftests.c,
1102         unittests/string_view-selftests.c, unittests/style-selftests.c,
1103         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1104         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1105         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1106         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1107         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1108         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1109
1110 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1113         bool value.
1114         (decode_digits_ordinary): Set explicit_line field in sal.
1115         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1116         symtab_and_line that was set on an explicit line number in
1117         assembler code.  Do always update the recorded symtab and line if
1118         we do skip the prologue.
1119
1120 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1121
1122         * breakpoint.c (set_breakpoint_location_function): Remove
1123         explicit_loc parameter.
1124         (momentary_breakpoint_from_master): Update call to
1125         set_breakpoint_location_function.
1126         (add_location_to_breakpoint): Likewise.
1127
1128 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1129
1130         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1131         required features based on default bfd type when no specific bfd
1132         is present.
1133
1134 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1135
1136         * NEWS: Mention that GDB printf and eval commands can now print
1137         C-style and Ada-style convenience var strings without
1138         calling the inferior.
1139         * printcmd.c (printf_c_string): Locally print GDB internal var
1140         instead of transiting via the inferior.
1141         (printf_wide_c_string): Likewise.
1142
1143 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1144
1145         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1146
1147 2019-07-04  Tom Tromey  <tom@tromey.com>
1148
1149         PR tui/24724:
1150         * tui/tui-winsource.c (tui_clear_source_content): Update.
1151         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1152         (tui_update_breakpoint_info): Update.
1153         (tui_set_exec_info_content): Update.
1154         * tui/tui-source.c (tui_set_source_content_nil): Update.
1155         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1156         has_break.
1157         * tui/tui-data.h (enum tui_bp_flag): New.
1158         (tui_bp_flags): New enum flags type.
1159         (struct tui_source_element) <break_mode>: Change type.  Rename
1160         from has_break.
1161         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1162         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1163         constants.
1164         * tui/tui-winsource.h: Fix comment.
1165
1166 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1167
1168         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1169         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1170         (store_fpregs_to_thread)
1171         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1172         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1173         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1174         (IWMMXT_REGS_SIZE): Add define.
1175         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1176         (fetch_vfp_regs, store_vfp_regs)
1177         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1178         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1179
1180 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1181
1182         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1183         defines.
1184         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1185         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1186         (ARM_INT_REGISTER_SIZE): ...to this.
1187         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1188         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1189         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1190         (arm_linux_collect_gregset, supply_nwfpe_register)
1191         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1192         defines.
1193         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1194         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1195         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1196         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1197         (arm_return_in_memory, arm_store_return_value)
1198         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1199         (arm_record_ld_st_multiple): Likewise.
1200         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1201         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1202
1203 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1204
1205         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1206         AARCH64_DISPLACED_MODIFIED_INSNS.
1207         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1208         (aarch64_displaced_step_copy_insn): Likewise.
1209         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1210         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1211         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1212         ARM_DISPLACED_MODIFIED_INSNS.
1213         * arm-tdep.c (arm_gdbarch_init): Likewise.
1214         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1215         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1216         (struct arm_displaced_step_closure): Use
1217         ARM_DISPLACED_MODIFIED_INSNS.
1218
1219 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1220
1221         * features/Makefile: Remove unused xml files.
1222         * features/aarch64.xml: Remove.
1223         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1224         * features/i386/amd64-avx-avx512.xml: Remove.
1225         * features/i386/amd64-avx-linux.xml: Remove.
1226         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1227         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1228         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1229         * features/i386/amd64-avx-mpx.xml: Remove.
1230         * features/i386/amd64-avx.xml: Remove.
1231         * features/i386/amd64-linux.xml: Remove.
1232         * features/i386/amd64-mpx-linux.xml: Remove.
1233         * features/i386/amd64-mpx.xml: Remove.
1234         * features/i386/amd64.xml: Remove.
1235         * features/i386/i386-avx-avx512-linux.xml: Remove.
1236         * features/i386/i386-avx-avx512.xml: Remove.
1237         * features/i386/i386-avx-linux.xml: Remove.
1238         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1239         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1240         * features/i386/i386-avx-mpx-linux.xml: Remove.
1241         * features/i386/i386-avx-mpx.xml: Remove.
1242         * features/i386/i386-avx.xml: Remove.
1243         * features/i386/i386-linux.xml: Remove.
1244         * features/i386/i386-mmx-linux.xml: Remove.
1245         * features/i386/i386-mmx.xml: Remove.
1246         * features/i386/i386-mpx-linux.xml: Remove.
1247         * features/i386/i386-mpx.xml: Remove.
1248         * features/i386/i386.xml: Remove.
1249         * features/i386/x32-avx-avx512-linux.xml: Remove.
1250         * features/i386/x32-avx-linux.xml: Remove.
1251         * features/i386/x32-linux.xml: Remove.
1252
1253 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1254
1255         * regformats/aarch64.dat: Remove.
1256         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1257         * regformats/i386/amd64-avx-linux.dat: Remove.
1258         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1259         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1260         * regformats/i386/amd64-linux.dat: Remove.
1261         * regformats/i386/amd64-mpx-linux.dat: Remove.
1262         * regformats/i386/amd64.dat: Remove.
1263         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1264         * regformats/i386/i386-avx-linux.dat: Remove.
1265         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1266         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1267         * regformats/i386/i386-linux.dat: Remove.
1268         * regformats/i386/i386-mmx-linux.dat: Remove.
1269         * regformats/i386/i386-mpx-linux.dat: Remove.
1270         * regformats/i386/i386.dat: Remove.
1271         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1272         * regformats/i386/x32-avx-linux.dat: Remove.
1273         * regformats/i386/x32-linux.dat: Remove.
1274
1275 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1276
1277         * aarch64-tdep.c: Remove xml self tests.
1278         * amd64-linux-tdep.c: Likewise.
1279         * amd64-tdep.c: Likewise.
1280         * i386-linux-tdep.c: Likewise.
1281         * i386-tdep.c: Likewise.
1282
1283 2019-07-03  Pedro Alves  <palves@redhat.com>
1284
1285         PR cli/24732
1286         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1287         (pipe_cmd_option_defs): New.
1288         (make_pipe_cmd_options_def_group): New.
1289         (pipe_command): Use gdb::option::process_options.
1290         (pipe_command_completer): New function.
1291         (_initialize_cli_cmds): Install completer for "pipe" command.
1292
1293 2019-07-03  Pedro Alves  <palves@redhat.com>
1294
1295         * cli/cli-option.c (union option_value) <string>: New field.
1296         (struct option_def_and_value): Add ctor, move ctor, dtor and
1297         use DISABLE_COPY_AND_ASSIGN.
1298         (option_def_and_value::clear_value): New.
1299         (parse_option, save_option_value_in_ctx, get_val_type_str)
1300         (add_setshow_cmds_for_options): Handle var_string.
1301         * cli-option.h (union option_def::var_address) <string>: New
1302         field.
1303         (struct string_option_def): New.
1304         * maint-test-options.c (struct test_options_opts): Add default
1305         ctor and use DISABLE_COPY_AND_ASSIGN.
1306         <string_opt>: New field.
1307         (test_options_opts::~test_options_opts): New.
1308         (test_options_opts::dump): Also dump "-string".
1309         (test_options_option_defs): Install "string.
1310
1311 2019-07-03  Pedro Alves  <palves@redhat.com>
1312
1313         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1314         option_value with a null enumeration.
1315         (complete_options): Save the option values in the context.
1316         (save_option_value_in_ctx): New, factored out from ...
1317         (process_options): ... here.
1318         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1319         of the function.
1320         * maint-test-options.c (test_options_opts::dump): New, factored
1321         out from ...
1322         (maintenance_test_options_command_mode): ... here.
1323         (maintenance_test_options_command_completion_result): Delete.
1324         (maintenance_test_options_command_completion_text): Update
1325         comment.
1326         (maintenance_show_test_options_completion_result): Change
1327         prototype.  Just print
1328         maintenance_test_options_command_completion_text.
1329         (save_completion_result): New.
1330         (maintenance_test_options_completer_mode): Pass options context to
1331         complete_options, and then save a dump.
1332         (_initialize_maint_test_options): Use add_cmd to install "maint
1333         show test-options-completion-result".
1334
1335 2019-07-03  Pedro Alves  <palves@redhat.com>
1336
1337         * NEWS (New commands): Mention "with" and "maint with".
1338         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1339         (with_command, with_command_completer): New.
1340         (pipe_command): Adjust to new repeat_previous
1341         interface.
1342         (_initialize_cli_cmds): Install the "with" command and its "w"
1343         alias.
1344         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1345         declarations.
1346         * cli/cli-setshow.c (parse_cli_var_uinteger)
1347         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1348         argument strings for all var_types.
1349         (get_setshow_command_value_string): New, factored out from ...
1350         (do_show_command): ... this.
1351         * cli/cli-setshow.h: Include <string>.
1352         (get_setshow_command_value_string): Declare.
1353         * command.h (repeat_previous): Now returns const char *.  Adjust
1354         comment.
1355         * maint.c: Include "cli/cli-cmds.h".
1356         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1357         (_initialize_maint_cmds): Register the "maintenance with" command.
1358         * top.c (repeat_previous): Move bits from pipe_command here:
1359         Return the saved command line, if any; error out if there's no
1360         command to relaunch.
1361
1362 2019-07-03  Pedro Alves  <palves@redhat.com>
1363
1364         * NEWS (New commands): Mention "maint set/show test-settings"
1365         instead of "maint test-settings".
1366         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1367         (maintenance_test_settings_set_list): Rename to ...
1368         (maintenance_set_test_settings_list): ... this.
1369         (maintenance_test_settings_show_list): Rename to  ...
1370         (maintenance_show_test_settings_list): ... this.
1371         (maintenance_test_settings_cmd): Delete.
1372         (maintenance_test_settings_set_cmd): ...
1373         (maintenance_set_test_settings_cmd): ... this.
1374         (maintenance_test_settings_show_cmd): ...
1375         (maintenance_show_test_settings_cmd): ... this.
1376         (maintenance_test_settings_show_value_cmd):
1377         (maintenance_show_test_settings_value_cmd): ... this.
1378         (_initialize_maint_test_settings): No longer install the "maint
1379         test-settings" prefix command.  Rename "maint test-settings set"
1380         to "maint set test-settings", and "maint test-settings show" to
1381         "maint show test-settings".  Adjust all subcommands.
1382
1383 2019-07-03  Pedro Alves  <palves@redhat.com>
1384
1385         * maint-test-settings.c: Fix file's intro comment.  Replace all
1386         references to "test-options" with references to "test-settings",
1387         in comments.
1388
1389 2019-07-03  Pedro Alves  <palves@redhat.com>
1390
1391         * maint-test-settings.c (maintenance_test_settings_xxx)
1392         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1393         New.
1394         (maintenance_test_settings_enums): Use them.
1395         (maintenance_test_settings_enum): Default to
1396         maintenance_test_settings_xxx.
1397         (_initialize_maint_test_settings): Initialize
1398         MAINTENANCE_TEST_SETTINGS_FILENAME.
1399
1400 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1401
1402         * breakpoint.h (remove_breakpoints_inf): Change return type to
1403         void, move function documentation here.
1404         * breakpoint.c (remove_breakpoints_inf): Change return type to
1405         void, move function documentation to header.
1406
1407 2019-07-02  Pedro Alves  <palves@redhat.com>
1408
1409         * NEWS (Completion improvements): Mention "info threads".
1410         * thread.c (struct info_threads_opts, info_threads_option_defs)
1411         (make_info_threads_options_def_group): New.
1412         (info_threads_command): Use gdb::option::process_options.
1413         (info_threads_command_completer): New.
1414         (_initialize_thread): Use gdb::option::build_help to build the
1415         help text for "info threads".
1416
1417 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1418
1419         * defs.h (generic_load): Move from here...
1420         * symfile.h (generic_load): ... to here.  Rename name parameter
1421         to args.
1422         * symfile.c (generic_load): Add comment.
1423
1424 2019-07-01  Tom Tromey  <tromey@adacore.com>
1425
1426         * dwarf2read.c
1427         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1428         declaration of without_params.  Fix formatting.
1429
1430 2019-07-01  Tom Tromey  <tromey@adacore.com>
1431
1432         * ada-exp.y (find_primitive_type): Update.
1433         * ada-lang.h (ada_lookup_symbol): Update.
1434         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1435         parameter.
1436         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1437
1438 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1439
1440         PR breakpoints/24541
1441         * gdbarch.c: Regenerate.
1442         * gdbarch.h: Regenerate.
1443         * gdbarch.sh: Add 'stap_adjust_register'.
1444         * i386-tdep.c: Include '<unordered_set>'.
1445         (i386_stap_adjust_register): New function.
1446         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1447         * stap-probe.c (stap_parse_register_operand): Call
1448         'gdbarch_stap_adjust_register'.
1449
1450 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1451
1452         PR python/24742
1453         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1454         * python/python.c (do_start_initialization): Use 'xmalloc'
1455         instead of 'PyMem_Malloc'.
1456
1457 2019-06-28  Tom Tromey  <tromey@adacore.com>
1458
1459         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1460         for Ada.
1461
1462 2019-06-27  Tom Tromey  <tromey@adacore.com>
1463
1464         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1465         objfile_key.
1466         (arm_find_mapping_symbol, arm_record_special_symbol)
1467         (_initialize_arm_tdep): Update.
1468         (arm_objfile_data_free): Remove.
1469
1470 2019-06-27  Tom Tromey  <tromey@adacore.com>
1471
1472         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1473         to cp_print_static_field.
1474
1475 2019-06-26  Tom Tromey  <tromey@adacore.com>
1476
1477         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1478         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1479         declare.
1480
1481 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1482
1483         * features/aarch64-core.c (create_feature_aarch64_core):
1484         Regenerate.
1485         * features/aarch64-core.xml: Add cpsr flags.
1486
1487 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1488
1489         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1490         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1491
1492 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1493
1494         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1495         field.
1496         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1497         use.
1498         (arm_record_special_symbol): Don't insert new symbol in sorted
1499         position, push it at the end.
1500
1501 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1502
1503         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1504         (arm_mapping_symbol_s): Remove.
1505         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1506         (arm_mapping_symbol_vec): New typedef.
1507         (struct arm_per_objfile): Add constructor.
1508         <section_maps>: Change type to
1509         std::unique_ptr<arm_mapping_symbol_vec[]>.
1510         (arm_compare_mapping_symbols): Remove.
1511         (arm_find_mapping_symbol): Adjust to section_maps type change.
1512         (arm_objfile_data_free): Call delete on arm_per_objfile.
1513         (arm_record_special_symbol): Adjust to section_maps type change.
1514         Allocate arm_per_objfile with new.
1515
1516 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1517
1518         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1519         with the command prefix.
1520
1521 2019-06-25  Tom Tromey  <tom@tromey.com>
1522
1523         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1524         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1525
1526 2019-06-25  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1529         type.
1530         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1531         protected.
1532
1533 2019-06-25  Tom Tromey  <tom@tromey.com>
1534
1535         * tui/tui-winsource.c
1536         (tui_source_window_base::set_is_exec_point_at): Add check against
1537         LOA_ADDRESS.
1538
1539 2019-06-25  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-source.c (tui_set_source_content): Don't check before
1542         xfree.
1543         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1544
1545 2019-06-25  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-winsource.h (tui_update_source_window_as_is)
1548         (tui_alloc_source_buffer, tui_line_is_displayed)
1549         (tui_addr_is_displayed): Change type of win_info.
1550         * tui/tui-winsource.c (tui_update_source_window_as_is)
1551         (tui_clear_source_content, tui_show_source_line)
1552         (tui_show_source_content, tui_source_window_base::refill)
1553         (tui_source_window_base::set_is_exec_point_at)
1554         (tui_source_window_base::set_is_exec_point_at)
1555         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1556         (tui_alloc_source_buffer, tui_line_is_displayed)
1557         (tui_addr_is_displayed): Change type of win_info.  Update.
1558         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1559         (tui_source_window_base::do_make_visible_with_new_height):
1560         Update.
1561         * tui/tui-source.c (tui_set_source_content)
1562         (tui_set_source_content_nil)
1563         (tui_source_window::do_scroll_vertical): Update.
1564         * tui/tui-layout.c (show_layout): Update.
1565         * tui/tui-disasm.c (tui_set_disassem_content)
1566         (tui_disasm_window::do_scroll_vertical): Update.
1567         * tui/tui-data.h (tui_win_content): Remove.
1568         (struct tui_gen_win_info) <content, content_size>: Remove.
1569         (struct tui_source_element): Add initializers and destructor.
1570         (union tui_which_element, struct tui_win_element): Remove.
1571         (struct tui_source_window_base) <content>: New field.
1572         (struct tui_data_window): Remove destructor.
1573         (tui_alloc_content, tui_free_win_content)
1574         (tui_free_all_source_wins_content): Don't declare.
1575         * tui/tui-data.c (tui_initialize_static_data): Update.
1576         (init_content_element, tui_alloc_content): Remove.
1577         (~tui_gen_win_info): Update.
1578         (~tui_data_window, tui_free_all_source_wins_content)
1579         (tui_free_win_content, free_content, free_content_elements):
1580         Remove.
1581
1582 2019-06-25  Tom Tromey  <tom@tromey.com>
1583
1584         * tui/tui-winsource.h (tui_clear_source_content)
1585         (tui_erase_source_content, tui_show_source_content): Change type
1586         of win_info.
1587         * tui/tui-winsource.c (tui_clear_source_content)
1588         (tui_erase_source_content, tui_show_source_content): Change type
1589         of win_info.
1590         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1591         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1592         win_info.
1593         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1594         win_info.
1595         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1596
1597 2019-06-25  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-winsource.c (tui_clear_source_content)
1600         (tui_source_window_base::set_is_exec_point_at): Update.
1601         * tui/tui-source.c (tui_set_source_content_nil): Update.
1602         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1603         a bool.
1604         * tui/tui-data.c (init_content_element): Update.
1605
1606 2019-06-25  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1609         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1610         * tui/tui-layout.c (init_and_make_win): Update.
1611         * tui/tui.h (enum tui_win_type): Update.
1612         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1613         tui_win_is_auxillary.
1614         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1615         tui_win_is_auxillary.
1616
1617 2019-06-25  Tom Tromey  <tom@tromey.com>
1618
1619         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1620         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1621         (tui_delete_data_content_windows, tui_display_all_data)
1622         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1623         Update.
1624         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1625         * tui/tui-regs.c (tui_last_regs_line_no)
1626         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1627         (tui_show_registers): Update.
1628         (tui_show_register_group): Return void.  Update.
1629         (tui_display_registers_from, tui_display_reg_element_at_line)
1630         (tui_display_registers_from_line, tui_check_register_values):
1631         Update.
1632         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1633         member.
1634         (struct tui_data_window) <regs_content>: Now a std::vector.
1635         <regs_content_count>: Remove.
1636         (tui_add_content_elements, tui_free_data_content): Don't declare.
1637         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1638         (init_content_element): Remove DATA_WIN case.  Add assert.
1639         (tui_add_content_elements): Remove.
1640         (tui_data_window): Update.
1641         (tui_free_data_content): Remove.
1642         (free_content_elements): Remove DATA_WIN case.
1643
1644 2019-06-25  Tom Tromey  <tom@tromey.com>
1645
1646         * tui/tui-data.c (tui_data_item_window): Update.
1647         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1648         * tui/tui-windata.c (tui_display_all_data)
1649         (tui_display_data_from_line): Update.
1650         (tui_check_data_values): Remove.
1651         * tui/tui-regs.c (tui_show_register_group)
1652         (tui_display_reg_element_at_line): Update.
1653         * tui/tui-hooks.c (tui_register_changed)
1654         (tui_refresh_frame_and_register_information): Call
1655         tui_check_register_values.
1656         * tui/tui-data.h (struct tui_data_window) <data_content,
1657         data_content_count, data_type>: Remove.
1658         (enum tui_data_type): Remove.
1659
1660         * tui/tui-data.c (tui_data_window::clear_detail)
1661         (~tui_data_window): Update.
1662
1663 2019-06-25  Tom Tromey  <tom@tromey.com>
1664
1665         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1666         declare.
1667         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1668         Rename from tui_first_data_item_displayed.  Update.
1669         (tui_data_window::refresh_all)
1670         (tui_data_window::do_scroll_vertical): Update.
1671         * tui/tui-data.h (struct tui_data_window)
1672         <first_data_item_displayed>: Declare new method.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1677         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1678         contents...
1679         (tui_initialize_static_data): ...here.
1680
1681 2019-06-25  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1684         (tui_display_registers_from, tui_check_register_values): Update.
1685         (tui_display_register): Remove win_info parameter; update.
1686         (tui_get_register): Change type of parameters.
1687         * tui/tui-data.h (struct tui_data_element): Remove.
1688         (union tui_which_element) <data>: Remove.
1689         <data_window>: Change type.
1690         (struct tui_data_item_window): New.
1691         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1692         case.  Add assert.
1693         (~tui_data_item_window): New destructor.
1694         (free_content_elements): Remove DATA_ITEM_WIN case.
1695
1696 2019-06-25  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1699         Remove.
1700
1701 2019-06-25  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-data.h (struct tui_command_element): Remove.
1704         (union tui_which_element) <command>: Remove.
1705         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1706         assert.
1707         (free_content_elements): Remove CMD_WIN case.
1708
1709 2019-06-25  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-layout.c (tui_set_layout): Update.
1712         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1713         * tui/tui-data.c (layout_def): Update.
1714
1715 2019-06-25  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1718         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1719         (tui_source_window_base::set_new_height): Update.
1720         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1721         Update.
1722         (tui_set_locator_fullname, tui_set_locator_info)
1723         (tui_show_frame_info): Update.
1724         * tui/tui-source.c (tui_set_source_content)
1725         (tui_source_is_displayed): Update.
1726         * tui/tui-layout.c (show_source_disasm_command, show_data)
1727         (show_source_or_disasm_and_command): Update.
1728         * tui/tui-disasm.c (tui_set_disassem_content)
1729         (tui_get_begin_asm_address): Update.
1730         * tui/tui-data.h (struct tui_locator_element): Remove.
1731         (union tui_which_element) <locator>: Remove.
1732         (struct tui_locator_window): New.
1733         (tui_locator_win_info_ptr): Change return type.
1734         * tui/tui-data.c (_locator): Change type.
1735         (tui_locator_win_info_ptr): Change return type.
1736         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1737         (tui_alloc_content): Add assert.
1738
1739 2019-06-25  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-winsource.c
1742         (tui_exec_info_window::maybe_allocate_content): New method.
1743         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1744         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1745         (make_source_or_disasm_window): Add cast.
1746         * tui/tui-data.h (union tui_which_element) <simple_string>:
1747         Remove.
1748         (struct tui_source_info): New.
1749         (struct tui_source_window_base) <execution_info>: Change type.
1750         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1751         case, and add assert.
1752         (tui_alloc_content): Add assert.
1753
1754 2019-06-25  Tom Tromey  <tom@tromey.com>
1755
1756         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1757         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1758         * tui/tui-data.c (tui_alloc_win_info): Remove.
1759
1760 2019-06-25  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1763         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1764         can_highlight.
1765
1766 2019-06-25  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1769         make_visible_with_new_height method.
1770         (tui_win_info::make_visible_with_new_height): New method.
1771         (tui_source_window_base::do_make_visible_with_new_height)
1772         (tui_data_window::do_make_visible_with_new_height)
1773         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1774         (make_visible_with_new_height): Remove.
1775         (tui_resize_all, tui_adjust_win_heights): Use
1776         make_visible_with_new_height method.
1777         * tui/tui-data.h (struct tui_win_info)
1778         <do_make_visible_with_new_height, make_visible_with_new_height>:
1779         New methods.
1780         (struct tui_source_window_base, struct tui_data_window)
1781         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1782         methods.
1783
1784 2019-06-25  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1787         method.
1788         (update_tab_width): Call update_tab_width method.
1789         * tui/tui-data.h (struct tui_win_info)
1790         (struct tui_source_window_base) <update_tab_width>: New methods.
1791
1792 2019-06-25  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1795         parameter.
1796         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1797         parameter.
1798         (tui_gen_win_info::make_visible): Update.
1799         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1800         parameter.
1801         * tui/tui-data.h (enum tui_box): New enum.
1802         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1803
1804 2019-06-25  Tom Tromey  <tom@tromey.com>
1805
1806         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1807         init_and_make_win for EXEC_INFO_WIN.
1808         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1809         longer inline.
1810         (struct tui_win_info) <~tui_win_info>: Inline.
1811         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1812         Don't declare.
1813         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1814         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1815         Remove.
1816         (tui_initialize_static_data): Update.
1817         (~tui_gen_win_info): Handle more cleanup here.
1818         (~tui_source_window_base): Delete "execution_info".
1819         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1820
1821 2019-06-25  Tom Tromey  <tom@tromey.com>
1822
1823         * tui/tui-layout.c (make_command_window): Don't set
1824         can_highlight.
1825         (show_source_disasm_command): Call the reset method.
1826         (show_data): Don't set can_highlight.  Call the reset method.
1827         (tui_gen_win_info::reset): Rename from init_gen_win_info
1828         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1829         (show_source_or_disasm_and_command): Call the reset method.
1830         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1831         (struct tui_cmd_window): Set can_highlight.
1832
1833 2019-06-25  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1836         from make_visible.
1837         (tui_make_visible, tui_make_invisible): Rewrite.
1838         (tui_win_info::make_visible): Remove.
1839         (tui_source_window_base::make_visible): Update.
1840         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1841         method.  Moved from...
1842         (struct tui_win_info) <make_visible>: ...here.
1843
1844 2019-06-25  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui-winsource.c
1847         (tui_source_window_base::do_scroll_horizontal): Remove direction
1848         parameter.
1849         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1850         direction parameter.
1851         * tui/tui-win.c (tui_win_info::forward_scroll)
1852         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1853         (tui_win_info::right_scroll): Update.
1854         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1855         direction parameter.
1856         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1857         direction parameter.
1858         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1859         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1860         Remove direction parameter.
1861         (struct tui_source_window_base, struct tui_source_window)
1862         (struct tui_disasm_window, struct tui_data_window)
1863         (struct tui_cmd_window): Update.
1864
1865 2019-06-25  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-winsource.h (tui_set_exec_info_content)
1868         (tui_show_exec_info_content, tui_erase_exec_info_content)
1869         (tui_clear_exec_info_content, tui_update_exec_info): Change
1870         argument to tui_source_window_base.
1871         * tui/tui-winsource.c (tui_set_exec_info_content)
1872         (tui_show_exec_info_content, tui_erase_exec_info_content)
1873         (tui_clear_exec_info_content, tui_update_exec_info): Change
1874         argument to tui_source_window_base.
1875
1876 2019-06-25  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1879         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1884         check.
1885
1886 2019-06-25  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1889         type to void.
1890         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1891         type to void.
1892         * tui/tui-source.c (tui_set_source_content): Update.
1893         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1894
1895 2019-06-25  Tom Tromey  <tom@tromey.com>
1896
1897         * tui/tui-win.c (window_name_completer, tui_set_focus)
1898         (tui_all_windows_info): Use name method.
1899         * tui/tui-data.h (struct tui_gen_win_info)
1900         (struct tui_source_window, struct tui_disasm_window)
1901         (struct tui_data_window, struct tui_cmd_window) <name>: New
1902         method.
1903         (tui_win_name): Don't declare.
1904         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1905         (tui_win_name): Remove.
1906
1907 2019-06-25  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-winsource.h (tui_update_source_window)
1910         (tui_update_source_window_as_is): Change parameter type.
1911         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1912         to be a tui_source_window_base.
1913         (tui_update_source_window_as_is): Likewise.
1914         * tui/tui-win.c (make_visible_with_new_height): Update.
1915
1916 2019-06-25  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-winsource.c (tui_erase_source_content)
1919         (tui_show_source_content, tui_show_exec_info_content)
1920         (tui_erase_exec_info_content): Use refresh_window method.
1921         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1922         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1923         from tui_refresh_win.
1924         (tui_data_window::refresh_window): New method.
1925         (tui_win_info::refresh, tui_source_window_base::refresh)
1926         (tui_refresh_all): Use refresh_window method.
1927         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1928         method.
1929         * tui/tui-regs.c (tui_display_register): Call refresh_window
1930         method.
1931         * tui/tui-layout.c (show_source_disasm_command)
1932         (show_source_or_disasm_and_command): Call refresh_window method.
1933         * tui/tui-data.h (struct tui_gen_win_info)
1934         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1935         New method.
1936
1937 2019-06-25  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui.c (tui_rl_other_window, tui_enable)
1940         (tui_is_window_visible, tui_get_command_dimension): Update.
1941         * tui/tui-winsource.c (tui_update_source_window_as_is)
1942         (tui_clear_source_content, tui_erase_source_content)
1943         (tui_show_source_line, tui_source_window_base::refill)
1944         (tui_source_window_base::do_scroll_horizontal)
1945         (tui_source_window_base::set_is_exec_point_at)
1946         (tui_update_breakpoint_info, tui_set_exec_info_content)
1947         (tui_alloc_source_buffer, tui_line_is_displayed)
1948         (tui_addr_is_displayed): Update.
1949         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1950         (tui_check_and_display_highlight_if_needed)
1951         (tui_win_info::make_visible, tui_win_info::refresh)
1952         (tui_refresh_all): Update.
1953         * tui/tui-windata.c (tui_first_data_item_displayed)
1954         (tui_delete_data_content_windows, tui_erase_data_content)
1955         (tui_display_all_data, tui_data_window::refresh_all)
1956         (tui_check_data_values): Update.
1957         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1958         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1959         (tui_win_info::backward_scroll, tui_refresh_all_win)
1960         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1961         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1962         (tui_source_window_base::set_new_height)
1963         (tui_data_window::set_new_height)
1964         (make_invisible_and_set_new_height)
1965         (make_visible_with_new_height, new_height_ok)
1966         (parse_scrolling_args): Update.
1967         * tui/tui-stack.c (tui_show_frame_info): Update.
1968         * tui/tui-source.c (tui_set_source_content)
1969         (tui_set_source_content_nil, tui_source_is_displayed)
1970         (tui_source_window::do_scroll_vertical): Update.
1971         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1972         (tui_display_registers_from, tui_display_reg_element_at_line)
1973         (tui_check_register_values, tui_reg_command): Update.
1974         * tui/tui-layout.c (tui_default_win_height)
1975         (show_source_disasm_command, show_data, init_and_make_win)
1976         (show_source_or_disasm_and_command): Update.
1977         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1978         (tui_redisplay_readline, tui_mld_flush)
1979         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1980         (tui_getc): Update.
1981         * tui/tui-disasm.c (tui_set_disassem_content)
1982         (tui_disasm_window::do_scroll_vertical): Update.
1983         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1984         Now virtual.
1985         (struct tui_win_info): Derive from tui_gen_win_info.
1986         <~tui_win_info>: Mark as override.
1987         <generic>: Remove member.
1988         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1989         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1990         (~tui_data_window, ~tui_win_info)
1991         (tui_free_all_source_wins_content): Update.
1992         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1993
1994 2019-06-25  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui-layout.c (init_and_make_win): Use new.
1997         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1998         destructor, initializers.
1999         (tui_alloc_generic_win_info): Don't declare.
2000         * tui/tui-data.c (_locator): Add argument to constructor.
2001         (source_win, disasm_win): New globals.
2002         (exec_info): Remove.
2003         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2004         Update.
2005         (tui_alloc_generic_win_info): Remove.
2006         (init_content_element): Use new.
2007         (tui_win_info::tui_win_info): Update.
2008         (free_content_elements) <case DATA_WIN>: Use delete.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2013         * tui/tui-windata.c (tui_first_data_item_displayed)
2014         (tui_delete_data_content_windows): Update.
2015         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2016         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2017         (tui_display_registers_from, tui_check_register_values): Update.
2018         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2019         pointer.
2020         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2021         window.
2022         (tui_free_data_content): Update.
2023         (free_content_elements) <case DATA_WIN>: Free the window.
2024
2025 2019-06-25  Tom Tromey  <tom@tromey.com>
2026
2027         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2028         Update.
2029         * tui/tui-layout.c (make_command_window)
2030         (show_source_disasm_command, show_data, init_and_make_win)
2031         (show_source_or_disasm_and_command): Update.
2032         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2033         method.
2034         <can_highight, is_highlighted>: Now bool.
2035         (tui_set_win_highlight): Don't declare.
2036         * tui/tui-data.c (tui_set_win_highlight): Remove.
2037
2038 2019-06-25  Tom Tromey  <tom@tromey.com>
2039
2040         * tui/tui-wingeneral.c (make_visible): Remove check of window
2041         type.
2042
2043 2019-06-25  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-win.c (tui_win_info::max_height)
2046         (tui_cmd_window::max_height): New methods.
2047         (new_height_ok): Call max_height.
2048         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2049         <max_height>: New method.
2050
2051 2019-06-25  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui-win.c (tui_source_window_base::set_new_height)
2054         (tui_data_window::set_new_height): New methods.
2055         (make_invisible_and_set_new_height): Call set_new_height method.
2056         * tui/tui-data.h (struct tui_win_info)
2057         (struct tui_source_window_base, struct tui_data_window)
2058         <set_new_height>: New method.
2059
2060 2019-06-25  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2063         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2064         tui_refresh_data_win.
2065         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2066         method.
2067         (tui_refresh_all_win): Call the refresh_all method.
2068         (tui_set_focus): Likewise.
2069         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2070         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2071         Likewise.
2072
2073 2019-06-25  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-winsource.h (tui_refill_source_window)
2076         (tui_set_is_exec_point_at): Don't declare.
2077         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2078         (tui_source_window_base::refill): Rename from
2079         tui_refill_source_window.
2080         (tui_source_window_base::do_scroll_horizontal): Update.
2081         (tui_source_window_base::set_is_exec_point_at): Rename from
2082         tui_set_is_exec_point_at.
2083         (tui_update_all_breakpoint_info): Update.
2084         * tui/tui-stack.c (tui_show_frame_info): Update.
2085         * tui/tui-layout.c (show_data): Add cast.
2086         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2087         * tui/tui-data.h (struct tui_source_window_base) <refill,
2088         set_is_exec_point_at>: New methods.
2089         (tui_source_windows, tui_add_to_source_windows): Update types.
2090         (tui_add_to_source_windows): Remove redundant declaration.
2091         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2092         (tui_source_windows): Change return type.
2093         (tui_clear_source_windows_detail): Update.
2094         (tui_add_to_source_windows): Change type of parameter.
2095         (tui_free_all_source_wins_content): Update.
2096
2097 2019-06-25  Tom Tromey  <tom@tromey.com>
2098
2099         * tui/tui-wingeneral.c (tui_win_info::refresh)
2100         (tui_source_window_base::refresh): New methods.
2101         (tui_refresh_all): Call the refresh method.
2102         * tui/tui-data.h (struct tui_win_info)
2103         (struct tui_source_window_base) <refresh>: New method.
2104
2105 2019-06-25  Tom Tromey  <tom@tromey.com>
2106
2107         * tui/tui.h (tui_is_window_visible): Return bool.
2108         * tui/tui.c (tui_is_window_visible): Return bool.
2109         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2110         (tui_make_visible, tui_make_invisible)
2111         (tui_win_info::make_visible)
2112         (tui_source_window_base::make_visible, make_all_visible)
2113         (tui_make_all_visible, tui_make_all_invisible): Update.
2114         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2115         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2116         bool.
2117         (struct tui_win_info, struct tui_source_window_base)
2118         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2119         * tui/tui-data.c (tui_init_generic_part): Update.
2120
2121 2019-06-25  Tom Tromey  <tom@tromey.com>
2122
2123         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2124         (tui_source_window_base::make_visible): New methods.
2125         (make_all_visible): Make method call.
2126         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2127         (struct tui_source_window_base, struct tui_cmd_window): Override
2128         make_visible.
2129         (tui_win_is_source_type): Don't declare.
2130         * tui/tui-data.c (tui_win_is_source_type): Remove.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2135         NULL check.
2136
2137 2019-06-25  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2140         Inline constructor.  Add initializers for members.
2141         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2142         constructors; now inline in class.
2143
2144 2019-06-25  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-regs.c (tui_show_registers): Update.
2147         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2148         bool.
2149         * tui/tui-data.c (tui_data_window::clear_detail)
2150         (tui_data_window): Update.
2151
2152 2019-06-25  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui-windata.c (tui_display_all_data)
2155         (tui_display_data_from_line, tui_display_data_from)
2156         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2157         Update.
2158         * tui/tui-regs.c (tui_last_regs_line_no)
2159         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2160         (tui_show_registers, tui_show_register_group)
2161         (tui_display_registers_from, tui_display_reg_element_at_line)
2162         (tui_display_registers_from_line, tui_check_register_values)
2163         (tui_reg_next, tui_reg_prev): Update.
2164         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2165         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2166         tui_data_window.
2167         (struct tui_win_info) <detail>: Remove.  Add new fields from
2168         tui_data_info.
2169         (TUI_DATA_WIN): Add cast.
2170         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2171         (~tui_data_window): Simplify.
2172
2173 2019-06-25  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-layout.c (show_source_disasm_command)
2176         (show_source_or_disasm_and_command): Update.
2177         * tui/tui-io.c (update_cmdwin_start_line)
2178         (tui_redisplay_readline): Update.
2179         * tui/tui-data.h (struct tui_command_info): Remove.
2180         (struct tui_win_info) <detail>: Remove command_info member.
2181         (struct tui_data_window) <start_line>: New member, from
2182         tui_command_info.
2183         (TUI_CMD_WIN): Add casts.
2184
2185 2019-06-25  Tom Tromey  <tom@tromey.com>
2186
2187         * tui/tui-winsource.c (tui_update_source_window)
2188         (tui_refill_source_window)
2189         (tui_source_window_base::do_scroll_horizontal)
2190         (tui_update_breakpoint_info, tui_set_exec_info_content)
2191         (tui_show_exec_info_content, tui_erase_exec_info_content)
2192         (tui_clear_exec_info_content): Update.
2193         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2194         Update.
2195         * tui/tui-win.c (make_invisible_and_set_new_height)
2196         (make_visible_with_new_height): Update.
2197         * tui/tui-source.c (tui_set_source_content)
2198         (tui_show_symtab_source): Update.
2199         * tui/tui-layout.c (extract_display_start_addr)
2200         (show_source_disasm_command, show_data)
2201         (make_source_or_disasm_window)
2202         (show_source_or_disasm_and_command): Update.
2203         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2204         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2205         "gdbarch".
2206         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2207         to tui_source_window_base.
2208         (struct tui_win_info) <detail>: Remove source_info member.
2209         (struct tui_source_window_base) <has_locator>: Inline.
2210         Move contents from tui_source_info; rename has_locator member to
2211         m_has_locator.
2212         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2213         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2214         header file.
2215         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2216         Simplify.
2217         (tui_free_all_source_wins_content): Cast to
2218         tui_source_window_base.
2219
2220 2019-06-25  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-win.c (make_invisible_and_set_new_height)
2223         (make_visible_with_new_height): Call has_locator method.
2224         * tui/tui-layout.c (show_source_disasm_command, show_data)
2225         (show_source_or_disasm_and_command): Update for bool change.
2226         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2227         (tui_win_info) <has_locator>: New method.
2228         (struct tui_source_window_base) <has_locator>: New method.
2229         (tui_win_has_locator): Don't declare.
2230         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2231         from tui_win_has_locator.
2232         (tui_source_window_base): Use false, not FALSE.
2233
2234 2019-06-25  Tom Tromey  <tom@tromey.com>
2235
2236         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2237         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2238         clear_detail method directly.
2239         (tui_clear_win_detail): Remove.
2240
2241 2019-06-25  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2244         "this", not TUI_DISASM_WIN.
2245
2246 2019-06-25  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2249         declare.
2250         * tui/tui-winsource.c
2251         (tui_source_window_base::do_scroll_horizontal): Rename from
2252         tui_horizontal_source_scroll.
2253         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2254         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2255         from tui_vertical_data_scroll.
2256         * tui/tui-win.h (tui_scroll): Don't declare.
2257         * tui/tui-win.c (tui_win_info::forward_scroll)
2258         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2259         (tui_win_info::right_scroll): Rename and update.
2260         (tui_scroll_forward_command, tui_scroll_backward_command)
2261         (tui_scroll_left_command, tui_scroll_right_command): Update.
2262         (tui_scroll): Remove.
2263         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2264         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2265         from tui_vertical_source_scroll.
2266         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2267         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2268         from tui_vertical_disassem_scroll.
2269         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2270         do_scroll_horizontal>: New methods.
2271         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2272         Likewise.
2273         (struct tui_source_window_base): Add do_scroll_horizontal.
2274         (struct tui_source_window, struct tui_disasm_window): Add
2275         do_scroll_vertical.
2276         (struct tui_data_window, struct tui_cmd_window): Add
2277         do_scroll_horizontal and do_scroll_vertical.
2278         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2279
2280 2019-06-25  Tom Tromey  <tom@tromey.com>
2281
2282         * tui/tui-data.h (struct tui_source_window_base): New struct.
2283         (struct tui_source_window): Derive from tui_source_window_base.
2284         (struct tui_disasm_window): New struct.
2285         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2286         from tui_source_window::clear_detail.
2287         (tui_source_window_base): Rename from tui_source_window.
2288         (~tui_source_window_base): Rename from ~tui_source_window.
2289         (tui_alloc_win_info): Create a tui_disasm_window.
2290
2291 2019-06-25  Tom Tromey  <tom@tromey.com>
2292
2293         * tui/tui-data.h (struct tui_source_window)
2294         (struct tui_data_window): Declare destructors.
2295         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2296         destructors.
2297         (tui_win_info): Simplify.
2298
2299 2019-06-25  Tom Tromey  <tom@tromey.com>
2300
2301         * tui/tui-winsource.c (tui_display_main)
2302         (tui_update_source_windows_with_addr)
2303         (tui_update_all_breakpoint_info): Update.
2304         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2305         (new_height_ok, parse_scrolling_args): Update.
2306         * tui/tui-stack.c (tui_show_frame_info): Update.
2307         * tui/tui-data.h (struct tui_list): Remove.
2308         (tui_source_windows): Return a reference to a std::vector.
2309         * tui/tui-data.c (source_windows): Now a std::vector.
2310         (tui_source_windows): Change return type.
2311         (tui_clear_source_windows): Rewrite.
2312         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2313         (tui_free_all_source_wins_content): Rewrite.
2314
2315 2019-06-25  Tom Tromey  <tom@tromey.com>
2316
2317         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2318         (struct tui_data_window, struct tui_cmd_window): Declare
2319         clear_detail method.
2320         * tui/tui-data.c (tui_source_window::clear_detail)
2321         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2322         methods.
2323         (tui_clear_win_detail): Simplify.
2324
2325 2019-06-25  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-layout.c (make_source_window, make_disasm_window)
2328         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2329         Return the new window.
2330         (show_source_disasm_command, show_data)
2331         (show_source_or_disasm_and_command): Update.
2332
2333 2019-06-25  Tom Tromey  <tom@tromey.com>
2334
2335         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2336         parameter.  Return the new window.
2337         (show_source_disasm_command): Update and remove NULL check.
2338         (show_source_or_disasm_and_command): Update.
2339
2340 2019-06-25  Tom Tromey  <tom@tromey.com>
2341
2342         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2343
2344 2019-06-25  Tom Tromey  <tom@tromey.com>
2345
2346         * tui/tui-data.h (struct tui_win_info): Make constructor
2347         protected.  Make destructor virtual.  Add initializers.
2348         (tui_source_window, tui_data_window, tui_cmd_window): New
2349         classes.
2350         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2351         constructor.  Add "type" parameter.
2352         (tui_source_window, tui_data_window, tui_cmd_window): New
2353         constructors.
2354         (tui_alloc_win_info): Instantiate the appropriate subclass.
2355
2356 2019-06-25  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui-win.c (tui_resize_all): Use delete.
2359         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2360         destructor.
2361         (tui_free_window): Don't declare.
2362         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2363         Update.
2364
2365 2019-06-25  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-data.h (struct tui_win_info): Add constructor.
2368         * tui/tui-data.c (tui_alloc_win_info): Use new.
2369         (tui_free_window): Use delete.
2370
2371 2019-06-22  Tom Tromey  <tom@tromey.com>
2372
2373         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2374         declare.
2375         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2376
2377 2019-06-22  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2380         declare.
2381         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2382
2383 2019-06-22  Tom de Vries  <tdevries@suse.de>
2384
2385         * dwarf2read.c (create_addrmap_from_aranges)
2386         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2387         instead of '%zu'.
2388
2389 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2390
2391         * dwarf2read.h (dwarf2_section_info_def): Remove.
2392         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2393         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2394         std::vector<dwarf2_section_info>.
2395         (struct dwo_file) <~dwo_file>: Remove.
2396         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2397         types field.
2398         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2399         (dwarf2_read_debug_names): Likewise.
2400         (create_debug_types_hash_table): Change parameter type to
2401         array_view, adjust code accordingly.
2402         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2403         (partial_die_info::fixup): Likewise.
2404         (determine_prefix): Likewise.
2405         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2406
2407 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2408
2409         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2410         gdb_bfd_ref_ptr.
2411         <~dwo_file>: Remove call to gdb_bfd_unref.
2412         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2413         gdb_bfd_ref_ptr::get.
2414
2415 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2416
2417         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2418         type to htab_up.
2419         * dwarf2read.c (struct dwo_file): Initialize fields.
2420         <~dwo_file>: New.
2421         (free_dwo_file): Remove, move content to ~dwo_file.
2422         (struct dwo_file_deleter): Remove.
2423         (dwo_file_up>: Remove custom deleter.
2424         (free_dwo_files): Remove.
2425         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2426         dwo_files.
2427         (process_skeletonless_type_units): Call unique_ptr::get.
2428         (allocate_dwo_file_hash_table): Add deleter to created hash
2429         table.  Change return type to htab_up.
2430         (lookup_dwo_file_slot): Don't memset dwo_file, call
2431         unique_ptr::get.
2432         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2433         (create_dwo_unit_in_dwp_v2): Likewise.
2434         (open_and_init_dwo_file): Likewise.
2435         (free_dwo_file_from_slot): Remove.
2436
2437 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2438
2439         * dwarf2read.h (struct dwarf2_section_info) <readin,
2440         is_virtual>: Change type to bool.
2441         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2442         true instead of 1.
2443
2444 2019-06-19  Tom Tromey  <tom@tromey.com>
2445
2446         * tui/tui-data.h (tui_init_content_element): Don't declare.
2447
2448 2019-06-19  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui-data.h (tui_init_win_info): Don't declare.
2451
2452 2019-06-19  Tom de Vries  <tdevries@suse.de>
2453
2454         * dwarf2read.h (abstract_to_concrete): Change type to
2455         std::unordered_map<sect_offset, std::vector<sect_offset>,
2456         gdb::hash_enum<sect_offset>>.
2457
2458 2019-06-19  Tom Tromey  <tromey@adacore.com>
2459
2460         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2461         EVAL_AVOID_SIDE_EFFECTS specially.
2462
2463 2019-06-19  Tom Tromey  <tromey@adacore.com>
2464
2465         * source-cache.c (highlighter): New global.
2466         (source_cache::get_source_lines): Create a highlighter on demand.
2467
2468 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2469
2470         * defs.h (deprecated_interactive_hook): Delete declaration.
2471         * interps.c (clear_interpreter_hooks): Remove use of
2472         deprecated_interactive_hook.
2473         * top.c (deprecated_interactive_hook): Delete definition.
2474         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2475
2476 2019-06-18  Tom de Vries  <tdevries@suse.de>
2477
2478         PR gdb/24515
2479         * dwarf2read.h (abstract_to_concrete): Change type from
2480         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2481         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2482         * dwarf2read.c (read_variable): Update.
2483         (dwarf2_fetch_die_loc_sect_off): Update.
2484
2485 2019-06-17  Tom de Vries  <tdevries@suse.de>
2486
2487         PR gdb/24617
2488         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2489         accessing parent[parent_len - 1].
2490
2491 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2492
2493         PR gdb/24364
2494         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2495         call dtrace_process_dof with NULL dof.
2496
2497 2019-06-16  Tom de Vries  <tdevries@suse.de>
2498
2499         PR gdb/24445
2500         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2501
2502 2019-06-16  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2505         (make_all_visible): Use address of member.
2506
2507 2019-06-16  Tom Tromey  <tom@tromey.com>
2508
2509         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2510         (tui_free_window, free_content, free_content_elements): Remove
2511         unnecessary cast.
2512         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2513         cast.
2514         * tui/tui-regs.c (tui_show_register_group)
2515         (tui_display_registers_from, tui_display_reg_element_at_line):
2516         Remove unnecessary cast.
2517
2518 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2519
2520         * linux-nat.c (normal_mask): Delete.
2521         (_initialize_linux_nat): Don't initialise normal_mask.
2522
2523 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2524
2525         PR gdb/24445
2526         * dwarf-index-write.h (write_psymtabs_to_index): Add
2527         dwz_basename parameter.
2528         * dwarf-index-write.c (write_gdbindex): Move file writing to
2529         write_gdbindex_1.  Change return type void.
2530         (assert_file_size): Move up, remove filename parameter.
2531         (write_gdbindex_1): New function.
2532         (write_debug_names): Change return type to void, call
2533         assert_file_size.
2534         (struct index_wip_file): New struct.
2535         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2536         file logic to index_wip_file.  Write index for dwz file if
2537         needed.
2538         (save_gdb_index_command): Pass basename of dwz file, if present.
2539         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2540         build-id of dwz file, if present.
2541         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2542         (dwarf2_get_dwz_file): Likewise.
2543         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2544         (dwarf2_get_dwz_file): Likewise.
2545
2546 2019-06-16  Tom Tromey  <tom@tromey.com>
2547
2548         * coffread.c (process_coff_symbol): Use xstrdup.
2549         * value.c (create_internalvar): Use xstrdup.
2550
2551 2019-06-16  Tom Tromey  <tom@tromey.com>
2552
2553         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2554         * breakpoint.c (stopin_command, stopat_command)
2555         (until_break_command, decode_location_default): Remove unnecessary
2556         cast.
2557         * utils.c (subset_compare): Remove unnecessary cast.
2558         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2559         cast.
2560         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2561         cast.
2562         * infcmd.c (path_command): Remove unnecessary cast.
2563         * coffread.c (decode_type): Remove unnecessary cast.
2564         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2565         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2566         * tui/tui-stack.c (tui_show_locator_content)
2567         (tui_show_frame_info): Remove unnecessary cast.
2568         * tui/tui-win.c (tui_scroll_forward_command)
2569         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2570         (parse_scrolling_args): Remove unnecessary cast.
2571         * tui/tui-data.c (init_win_info, tui_del_window)
2572         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2573         (free_content_elements): Remove unnecessary cast.
2574         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2575         unnecessary cast.
2576         * tui/tui-source.c (tui_set_source_content)
2577         (tui_vertical_source_scroll): Remove unnecessary cast.
2578         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2579         cast.
2580         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2581         * tui/tui-regs.c (tui_display_registers_from)
2582         (tui_display_register): Remove unnecessary cast.
2583         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2584         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2585         (make_visible): Remove unnecessary cast.
2586         * tui/tui-winsource.c (tui_erase_source_content)
2587         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2588         unnecessary cast.
2589         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2590         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2591         * stabsread.c (read_type, read_array_type, read_range_type):
2592         Remove unnecessary cast.
2593         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2594         (parse_symbol, parse_type, upgrade_type, parse_external)
2595         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2596         unnecessary cast.
2597         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2598
2599 2019-06-16  Tom Tromey  <tom@tromey.com>
2600
2601         * tui/tui-data.c (tui_alloc_generic_win_info)
2602         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2603         checks.
2604
2605 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2606             Andrew Burgess  <andrew.burgess@embecosm.com>
2607
2608         * f-typeprint.c (f_print_type): Don't return early for not
2609         associated or not allocated types.
2610         (f_type_print_varspec_suffix): Add print_rank parameter and print
2611         ranks of array types in case they dangling.
2612         (f_type_print_base): Add print_rank parameter.
2613
2614 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2615
2616         * NEWS: Mention new MI commands.
2617         * break-catch-throw.c (enum exception_event_kind): Move to
2618         breakpoint.h.
2619         (print_mention_exception_catchpoint): Output text as a single
2620         message.
2621         (catch_exception_command_1): Rename to...
2622         (catch_exception_event): ...this, make non-static, update header
2623         command, and change some parameter types.
2624         (catch_catch_command): Update for changes to
2625         catch_exception_command_1.
2626         (catch_throw_command): Likewise.
2627         (catch_rethrow_command): Likewise.
2628         * breakpoint.c (enum exception_event_kind): Delete.
2629         * breakpoint.h (enum exception_event_kind): Moved here from
2630         break-catch-throw.c.
2631         (catch_exception_event): Declare.
2632         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2633         (mi_cmd_catch_throw): New function.
2634         (mi_cmd_catch_rethrow): New function.
2635         (mi_cmd_catch_catch): New function.
2636         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2637         'catch-catch' entries.
2638         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2639         (mi_cmd_catch_rethrow): Declare.
2640         (mi_cmd_catch_catch): Declare.
2641
2642 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2643
2644         * annotate.c (annotate_source_line): Change return type to void,
2645         update implementation to match.
2646         * annotate.h (annotate_source_line): Change return type to void,
2647         update header comment.
2648         * stack.c (print_frame_info): Don't change what frame information
2649         is printed based on whether annotations are on or not.
2650
2651 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2652
2653         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2654         (annotate_source): Make static.
2655         (annotate_source_line): Moved from source.c and renamed from
2656         identify_source_line.  Update the return type.
2657         * annotate.h (annotate_source): Delete declaration.
2658         (annotate_source_line): Declaration moved from source.h, and
2659         renamed from identify_source_line.  Return type updated.
2660         * source.c (identify_source_line): Moved to annotate.c and renamed
2661         to annotate_source_line.
2662         (info_line_command): Remove check of annotation_level.
2663         * source.h (identify_source_line): Move declaration to annotate.h
2664         and rename to annotate_source_line.
2665         * stack.c: Add 'annotate.h' include.
2666         (print_frame_info): Remove check of annotation_level before
2667         calling annotate_source_line.
2668
2669 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2670
2671         * source-cache.c (source_cache::get_plain_source_lines): Use
2672         open_source_file_with_line_charpos instead of just
2673         open_source_file, remove call to find_source_lines.
2674         (source_cache::get_source_lines): Likewise.
2675         * source.c (find_source_lines): Make static.
2676         (get_filename_and_charpos): Renamed into...
2677         (open_source_file_with_line_charpos): ..this along with changes to
2678         return a scoped_fd, and some other minor clean ups.
2679         (identify_source_line): Use open_source_file_with_line_charpos.
2680         (search_command_helper): Use open_source_file_with_line_charpos
2681         instead of just open_source_file, remove call to
2682         find_source_lines.
2683         * source.h (open_source_file_with_line_charpos): Declare new
2684         function.
2685         (find_source_lines): Delete declaration.
2686
2687 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2688
2689         * source.c (get_filename_and_charpos): Remove fullname
2690         parameter.
2691         (identify_source_line): Update call to get_filename_and_charpos.
2692
2693 2019-06-14  Tom Tromey  <tromey@adacore.com>
2694
2695         PR gdb/24502:
2696         * ui-style.h (skip_ansi_escape): Update comment.
2697         * ui-file.h (class no_terminal_escape_file): New class.
2698         * ui-file.c (no_terminal_escape_file::write)
2699         (no_terminal_escape_file::puts): New methods.
2700         * cli/cli-logging.c (handle_redirections): Use
2701         no_terminal_escape_file.
2702
2703 2019-06-14  Tom Tromey  <tromey@adacore.com>
2704
2705         * NEWS: Move convenience variable news above Python news.
2706
2707 2019-06-14  Tom Tromey  <tom@tromey.com>
2708
2709         * gnulib: Move directory to top-level.
2710         * configure.ac: Don't configure gnulib.
2711         * configure: Rebuild.
2712         * common/common-defs.h: Use new path to gnulib.
2713         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2714         (GNULIB_H): Remove.
2715         (INCGNU): Look in new gnulib location.
2716         (HFILES_NO_SRCDIR): Remove gnulib files.
2717         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2718         (generated_files): Remove GNULIB_H.
2719         ($(LIBGNU), all-lib): Remove targets.
2720         (distclean): Don't mention GNULIB_BUILDDIR.
2721         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2722
2723 2019-06-14  Tom Tromey  <tromey@adacore.com>
2724
2725         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2726         Warn if symbol file does not provide any symbols.
2727
2728 2019-06-14  Tom Tromey  <tromey@adacore.com>
2729
2730         * source.c (find_and_open_source): Respect basenames_may_differ.
2731
2732 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2733
2734         * annotate.c (annotate_breakpoints_invalid): Make use of
2735         scoped_restore_terminal_state.
2736         (annotate_frames_invalid): Likewise.
2737
2738 2019-06-14  Tom Tromey  <tromey@adacore.com>
2739
2740         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2741         allow assignment to an internalvar.
2742
2743 2019-06-14  Tom Tromey  <tromey@adacore.com>
2744
2745         * ada-lex.l: Allow "_" in attribute names.
2746
2747 2019-06-14  Tom Tromey  <tromey@adacore.com>
2748
2749         PR gdb/24653:
2750         * regcache.c (registers_changed): Don't call alloca.
2751         * top.c (execute_command): Don't call alloca.
2752
2753 2019-06-13  Pedro Alves  <palves@redhat.com>
2754
2755         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2756         'expression'.  When parsing an expression, error out if there's
2757         junk after "unlimited".
2758         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2759         (do_set_command): Adjust calls to is_unlimited_literal.
2760
2761 2019-06-13  Pedro Alves  <palves@redhat.com>
2762
2763         * compile/compile.c (make_compile_options_def_group): Add braces
2764         around array_view initializer.
2765         * thread.c (make_thread_apply_all_options_def_group)
2766         (make_thread_apply_all_options_def_group): Likewise.
2767
2768 2019-06-13  Pedro Alves  <palves@redhat.com>
2769
2770         * NEWS (New commands): Mention "maint test-options
2771         require-delimiter", "maint test-options unknown-is-error", "maint
2772         test-options unknown-is-operand" and "maint show
2773         test-options-completion-result".
2774         (New command options, command completion): New section.
2775         (Completion improvements): New section.
2776         Mention that you can abbreviate "unlimited".
2777
2778 2019-06-13  Pedro Alves  <palves@redhat.com>
2779
2780         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2781         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2782         * unittests/cli-utils-selftests.c (test_parse_flags)
2783         (test_parse_flags_qcs): Delete.
2784         (test_cli_utils): Don't call deleted functions.
2785
2786 2019-06-13  Pedro Alves  <palves@redhat.com>
2787
2788         * thread.c: Include "cli/cli-option.h".
2789         (tp_array_compar_ascending): Global.
2790         (tp_array_compar): Delete function.
2791         (tp_array_compar_ascending, tp_array_compar_descending): New
2792         functions.
2793         (ascending_option_def, qcs_flag_option_def)
2794         (thr_qcs_flags_option_defs)
2795         (make_thread_apply_all_options_def_group)
2796         (make_thread_apply_options_def_group): New.
2797         (thread_apply_all_command): Use gdb::option::process_options.
2798         (thread_apply_command_completer)
2799         (thread_apply_all_command_completer): New.
2800         (thread_apply_command): Use gdb::option::process_options.
2801         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2802         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2803         to generate help text of "thread apply".  Adjust "taas"'s help.
2804         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2805         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2806
2807 2019-06-13  Pedro Alves  <palves@redhat.com>
2808
2809         * thread.c (thread_apply_command): Check for invalid TID with
2810         isdigit instead of !isalpha.
2811
2812 2019-06-13  Pedro Alves  <palves@redhat.com>
2813
2814         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2815         (validate_flags_qcs): New.
2816         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2817         (validate_flags_qcs): Declare.
2818         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2819         (make_frame_apply_options_def_group): New.
2820         (frame_apply_command_count): Process options with
2821         gdb::option::process_options.
2822         (frame_apply_completer): New.
2823         (frame_apply_level_completer, frame_apply_all_completer)
2824         (frame_apply_completer): New.
2825         (_initialize_stack): Update help of "frame apply", "frame apply
2826         level", "frame apply all" and "faas" to mention supported options
2827         and install command completers.
2828         * stack.h (frame_apply_all_completer): Declare.
2829         * thread.c: Include "stack.h".
2830         (tfaas_command): Add "--".
2831         (_initialize_thread): Update help "tfaas" to mention supported
2832         options and install command completer.
2833
2834 2019-06-13  Pedro Alves  <palves@redhat.com>
2835
2836         * completer.c (complete_nested_command_line): New.
2837         (gdb_completion_word_break_characters_throw): Add assertion.
2838         * completer.h (complete_nested_command_line): Declare.
2839
2840 2019-06-13  Pedro Alves  <palves@redhat.com>
2841
2842         * stack.c (parse_backtrace_qualifiers): New.
2843         (backtrace_command): Use it.
2844         (backtrace_command_completer): Complete on qualifiers.
2845
2846 2019-06-13  Pedro Alves  <palves@redhat.com>
2847
2848         * frame.c: Include "cli/cli-option.h.
2849         (user_set_backtrace_options): New.
2850         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2851         Delete.
2852         (get_prev_frame): Adjust.
2853         (boolean_option_def, uinteger_option_def)
2854         (set_backtrace_option_defs): New.
2855         (_initialize_frame): Adjust and use
2856         gdb::option::add_setshow_cmds_for_options to install "set
2857         backtrace past-main" and "set backtrace past-entry".
2858         * frame.h: Include "cli/cli-option.h".
2859         (struct frame_print_options): Forward declare.
2860         (print_frame_arguments_all, print_frame_arguments_scalars)
2861         (print_frame_arguments_none): Declare.
2862         (print_entry_values): Delete declaration.
2863         (struct frame_print_options, user_frame_print_options): New.
2864         (struct set_backtrace_options): New.
2865         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2866         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2867         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2868         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2869         (list_args_or_locals): Add frame_print_options parameter.
2870         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2871         * python/py-framefilter.c (enumerate_args): Pass down
2872         USER_FRAME_PRINT_OPTIONS.
2873         * stack.c: Include "cli/cli-option.h".
2874         (print_frame_arguments_all, print_frame_arguments_scalars)
2875         (print_frame_arguments_none): Declare.
2876         (print_raw_frame_arguments, print_entry_values): Delete.
2877         (user_frame_print_options): New.
2878         (boolean_option_def, enum_option_def, frame_print_option_defs):
2879         New.
2880         (struct backtrace_cmd_options): New.
2881         (bt_flag_option_def): New.
2882         (backtrace_command_option_defs): New.
2883         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2884         (print_frame_arg, read_frame_arg, print_frame_args)
2885         (print_frame_info, print_frame): Add frame_print_options parameter
2886         and use it.
2887         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2888         (backtrace_command_1): Add frame_print_options and
2889         backtrace_cmd_options parameters and use them.
2890         (make_backtrace_options_def_group): New.
2891         (backtrace_command): Process command options with
2892         gdb::option::process_options.
2893         (backtrace_command_completer): New.
2894         (_initialize_stack): Extend "backtrace"'s help to mention
2895         supported options.  Install completer for "backtrace".
2896         Install some settings commands with add_setshow_cmds_for_options.
2897
2898 2019-06-13  Pedro Alves  <palves@redhat.com>
2899
2900         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2901         and that "set/show print raw frame-arguments" are now deprecated.
2902
2903         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2904         command.
2905         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2906         * stack.c (_initialize_stack): Install "set/show print
2907         raw-frame-arguments", and deprecate "set/show print raw
2908         frame-arguments".
2909         * valprint.c (_initialize_valprint): Deprecate "set/show print
2910         raw".
2911
2912 2019-06-13  Pedro Alves  <palves@redhat.com>
2913
2914         * compile/compile.c (struct compile_options): New.
2915         (compile_flag_option_def, compile_command_option_defs)
2916         (make_compile_options_def_group): New.
2917         (compile_file_command): Handle options with
2918         gdb::option::process_options.
2919         (compile_file_command_completer): New function.
2920         (compile_code_command): Handle options with
2921         gdb::option::process_options.
2922         (compile_code_command_completer): New function.
2923         (_initialize_compiler): Install completers for "compile code" and
2924         "compile file".  Mention available options in "compile code" and
2925         "compile code"'s help.
2926         * completer.c (advance_to_completion_word): New, factored out from
2927         ...
2928         (advance_to_expression_complete_word_point): ... this.
2929         (advance_to_filename_complete_word_point): New.
2930         * completer.h (advance_to_filename_complete_word_point): New
2931         declaration.
2932
2933 2019-06-13  Pedro Alves  <palves@redhat.com>
2934
2935         * compile/compile.c: Include "cli/cli-option.h".
2936         (compile_print_value): Scope data pointer is now a
2937         value_print_options pointer; adjust.
2938         (compile_print_command): Process options.  Scope data pointer is
2939         now a value_print_options pointer; adjust.
2940         (_initialize_compile): Update "compile print"'s help to include
2941         supported options.  Install a completer for "compile print".
2942         * cp-valprint.c (show_vtblprint, show_objectprint)
2943         (show_static_field_print): Delete.
2944         (_initialize_cp_valprint): Don't install "set print
2945         static-members", "set print vtbl", "set print object" here.
2946         * printcmd.c: Include "cli/cli-option.h" and
2947         "common/gdb_optional.h".
2948         (print_command_parse_format): Rework to fill in a
2949         value_print_options instead of a format_data.
2950         (print_value): Change parameter type from format_data pointer to
2951         value_print_options reference.  Adjust.
2952         (print_command_1): Process options.  Adjust to pass down a
2953         value_print_options.
2954         (print_command_completer): New.
2955         (_initialize_printcmd): Install print_command_completer as
2956         handle_brkchars completer for the "print" command.  Update
2957         "print"'s help to include supported options.
2958         * valprint.c: Include "cli/cli-option.h".
2959         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2960         here from cp-valprint.c.
2961         (boolean_option_def, uinteger_option_def)
2962         (value_print_option_defs, make_value_print_options_def_group):
2963         New.  Use gdb::option::add_setshow_cmds_for_options to install
2964         "set print elements", "set print null-stop", "set print repeats",
2965         "set print pretty", "set print union", "set print array", "set
2966         print address", "set print symbol", "set print array-indexes".
2967         * valprint.h: Include <string> and "cli/cli-option.h".
2968         (make_value_print_options_def_group): Declare.
2969         (print_value): Change parameter type from format_data pointer to
2970         value_print_options reference.
2971         (print_command_completer): Declare.
2972
2973 2019-06-13  Pedro Alves  <palves@redhat.com>
2974
2975         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2976         (COMMON_SFILES): Add maint-test-settings.c.
2977         * cli/cli-decode.c (boolean_enums): New global, factored out from
2978         ...
2979         (add_setshow_boolean_cmd): ... here.
2980         * cli/cli-decode.h (boolean_enums): Declare.
2981         * cli/cli-option.c: New file.
2982         * cli/cli-option.h: New file.
2983         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2984         factored out from ...
2985         (parse_cli_boolean_value(const char *)): ... this.
2986         (is_unlimited_literal): Change parameter type to pointer to
2987         pointer.  Adjust and advance ARG pointer.
2988         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2989         (parse_cli_var_enum): New, factored out from ...
2990         (do_set_command): ... this.  Adjust.
2991         * cli/cli-setshow.h (parse_cli_boolean_value)
2992         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2993         (parse_cli_var_enum): Declare.
2994         * cli/cli-utils.c: Include "cli/cli-option.h".
2995         (get_ulongest): New.
2996         * cli/cli-utils.h (get_ulongest): Declare.
2997         (check_for_argument): New overloads.
2998         * maint-test-options.c: New file.
2999
3000 2019-06-13  Pedro Alves  <palves@redhat.com>
3001
3002         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3003         parse a range if "-" is at the end of the string.
3004
3005 2019-06-13  Pedro Alves  <palves@redhat.com>
3006
3007         * cli/cli-setshow.c (parse_auto_binary_operation)
3008         (parse_cli_boolean_value): Don't allow "o".
3009
3010 2019-06-13  Pedro Alves  <palves@redhat.com>
3011
3012         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3013         * NEWS: Mention maint test-settings KIND.
3014         * maint-test-settings.c: New file.
3015
3016 2019-06-13  Pedro Alves  <palves@redhat.com>
3017
3018         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3019         completer.
3020         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3021         "set" completers.
3022
3023 2019-06-13  Pedro Alves  <palves@redhat.com>
3024
3025         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3026         after item.
3027
3028 2019-06-13  Pedro Alves  <palves@redhat.com>
3029
3030         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3031
3032 2019-06-13  Pedro Alves <palves@redhat.com>
3033
3034         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3035         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3036         call.
3037         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3038         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3039         calls.
3040         (check_for_argument): Skip spaces after argument.
3041
3042 2019-06-13  Pedro Alves  <palves@redhat.com>
3043
3044         * thread.c (thread_apply_command): Adjust TID parsing.
3045         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3046         detected before end of string.
3047         (tid_is_in_list): Error out if LIST is invalid.
3048
3049 2019-06-13  Pedro Alves  <palves@redhat.com>
3050
3051         * completer.c (complete_line_internal_1): Rewind completion word
3052         point.
3053         (completion_tracker::advance_custom_word_point_by): Change
3054         parameter type to int.
3055         * completer.h (completion_tracker::advance_custom_word_point_by):
3056         Likewise.
3057
3058 2019-06-13  Pedro Alves  <palves@redhat.com>
3059
3060         * completer.c (advance_to_completion_word): Handle delimiters.
3061
3062 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3063
3064         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3065
3066 2019-06-11  Tom Tromey  <tom@tromey.com>
3067
3068         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3069         (xmalloc_failed): Move to alloc.c.
3070         * alloc.c: New file.
3071         * Makefile.in (COMMON_SFILES): Add alloc.c.
3072
3073 2019-06-11  Tom Tromey  <tom@tromey.com>
3074
3075         * nat/linux-waitpid.c: Don't include server.h.
3076         (linux_debug): Remove.
3077         (my_waitpid): Update.
3078
3079 2019-06-11  Tom Tromey  <tromey@adacore.com>
3080
3081         * infcall.c (_initialize_infcall): Remove trailing newline from
3082         help.
3083         * user-regs.c (_initialize_user_regs): Remove trailing newline
3084         from help.
3085         * typeprint.c (_initialize_typeprint): Remove trailing newline
3086         from help.
3087         * reverse.c (_initialize_reverse): Remove trailing newlines from
3088         help.
3089         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3090         from help.
3091         * language.c (add_set_language_command): Remove trailing newline
3092         from help.
3093         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3094         help.
3095         * disasm.c (_initialize_disasm): Remove trailing newline from
3096         help.
3097         * top.c (init_main): Remove trailing newline from help.
3098         * interps.c (_initialize_interpreter): Remove trailing newline
3099         from help.
3100         * btrace.c (_initialize_btrace): Remove trailing newlines from
3101         help.
3102         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3103         from help.
3104         * python/python.c (_initialize_python): Remove trailing newline
3105         from help.
3106         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3107         help.
3108         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3109         from help.  Reformat some text.
3110         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3111         from help.
3112         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3113         newline from help.
3114
3115 2019-06-11  Tom Tromey  <tromey@adacore.com>
3116
3117         * darwin-nat.c (darwin_decode_exception_message)
3118         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3119
3120 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3121
3122         * valops.c (value_slice): Check for not allocated or not
3123         associated values.
3124
3125 2019-06-10  Tom de Vries  <tdevries@suse.de>
3126
3127         PR gdb/24618
3128         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3129         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3130         invalid.
3131
3132 2019-06-10  Tom de Vries  <tdevries@suse.de>
3133
3134         PR gdb/24611
3135         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3136         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3137
3138 2019-06-10  Tom de Vries  <tdevries@suse.de>
3139
3140         PR symtab/24545
3141         * symtab.c (struct demangled_name_entry): Add language field.
3142         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3143         static minimal symbol".  Set and use language field.
3144
3145 2019-06-10  Tom Tromey  <tromey@adacore.com>
3146
3147         * ada-lang.c (_initialize_ada_language): Update help text.
3148
3149 2019-06-10  Tom Tromey  <tromey@adacore.com>
3150
3151         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3152         with a newline.
3153         * guile/guile.c (handle_boot_error): Don't end warning with a
3154         newline.
3155         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3156         warning with a newline.
3157         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3158         newline.
3159         (s12z_frame_cache): Likewise.
3160         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3161         a newline.
3162         * solib-svr4.c (disable_probes_interface): Don't end warning with
3163         a newline.
3164         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3165         newline.
3166         * python/python.c (do_finish_initialization): Don't end warning
3167         with a newline.
3168
3169 2019-06-10  Tom Tromey  <tom@tromey.com>
3170
3171         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3172         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3173         gdbpy_enter.
3174
3175 2019-06-10  Tom Tromey  <tromey@adacore.com>
3176
3177         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3178         data.
3179         (elf_new_init): Don't call stabsread_new_init.
3180         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3181         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3182         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3183
3184 2019-06-10  Tom de Vries  <tdevries@suse.de>
3185
3186         PR symtab/16264
3187         PR symtab/24517
3188         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3189
3190 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3191
3192         * source.c (find_and_open_source): Also rewrite relative file
3193         names.
3194
3195 2019-04-26  Amos Bird  <amosbird@gmail.com>
3196
3197         * annotate.c (annotate_thread_exited): Add "thread-exited"
3198         annotation.
3199
3200 2019-06-06  Tom Tromey  <tromey@adacore.com>
3201
3202         * maint.h (class scoped_command_stats): Use
3203         DISABLE_COPY_AND_ASSIGN.
3204         <print_time>: New method.
3205         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3206         print_time.
3207         (scoped_command_stats::print_time): New method.
3208
3209 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3210
3211         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3212         instructions of lengths 6 or 8 bytes.
3213
3214 2019-06-04  Pedro Alves  <palves@redhat.com>
3215
3216         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3217
3218         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3219         * breakpoint.c (condition_completer): Likewise.
3220         * cli/cli-dump.c (scan_expression): Likewise.
3221         * common/filestuff.c (mkdir_recursive): Likewise.
3222         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3223         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3224         (gdb_abspath): Likewise.
3225         * compile/compile-cplus-types.c
3226         (compile_cplus_instance::decl_name): Likewise.
3227         * completer.c (complete_explicit_location):
3228         (signal_completer, reg_or_group_completer_1): Likewise.
3229         * cp-support.c (cp_remove_params_if_any): Likewise.
3230         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3231         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3232         * infcmd.c (strip_bg_char): Likewise.
3233         * linespec.c (copy_token_string): Likewise.
3234         * mi/mi-main.c (output_cores): Likewise.
3235         * psymtab.c (psymtab_search_name):
3236         * symfile.c (test_set_ext_lang_command): Likewise.
3237         * target.c (target_fileio_read_stralloc): Likewise.
3238         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3239         * value.c (complete_internalvar): Likewise.
3240
3241 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3242
3243         Add objfile property to gdb.Type.
3244         * NEWS: Mention Python API addition.
3245         * python/py-type.c (typy_get_objfile): New method.
3246
3247 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3248
3249         * NEWS: Mention the new set|show style [title|highlight].
3250         Mention changes to "show style", "help" and "apropos".
3251
3252 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3253
3254         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3255         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3256         instead of print_help_for_command.
3257         (print_doc_of_command): New function.
3258         (help_list): Add 'apropos -v word' suggestion.
3259         (print_help_for_command): Style the command name using title style.
3260         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3261         (_initialize_cli_cmds): Describe -v in apropos_command help.
3262
3263 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3264
3265         * cli/cli-style.h (cli_style_option): Add name in constructor,
3266         add m_name class member, add constructor with intensity,
3267         add name class function.
3268         (cli_style_option::add_setshow_commands): Remove name argument.
3269         (highlight_style, title_style): New styles.
3270         * cli/cli-style.c (do_show): New function that shows a style
3271         characteristic styling the style name with itself.
3272         (set_style_name): New function.
3273         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3274         Update all callers according to the changes in cli/cli-style.h.
3275         * utils.h (fputs_highlighted): New function.
3276         * utils.c (fputs_highlighted): Likewise.
3277
3278 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3279
3280         * NEWS: Mention new pipe command and new convenience variables.
3281
3282 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3283
3284         * cli/cli-cmds.c (pipe_command): New function.
3285         (_initialize_cli_cmds): Call add_com for pipe_command.
3286         Define | as an alias for pipe.
3287         (exit_status_set_internal_vars): New function.
3288         (shell_escape): Call exit_status_set_internal_vars.
3289         cli/cli-decode.c (find_command_name_length): Recognize | as
3290         a single character command.
3291
3292 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3293
3294         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3295         top.c (execute_command_to_ui_file): New function, mostly a copy
3296         of execute_command_to_string.
3297         (execute_command_to_string): Implement by calling
3298         execute_command_to_ui_file.
3299
3300 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3301
3302         * top.h (saved_command_line): Remove declaration.
3303         * top.c (previous_saved_command_line, previous_repeat_arguments):
3304         New variables.
3305         (saved_command_line): Make static, define together with other
3306         'repeat variables'.
3307         (dont_repeat): Clear repeat_arguments.
3308         (repeat_previous, get_saved_command_line, save_command_line):
3309         New functions.
3310         (gdb_init): Initialize saved_command_line
3311         and previous_saved_command_line.
3312         * main.c (captured_main_1): Remove saved_command_line initialization.
3313         * event-top.c (handle_line_of_input): Update to use
3314         the new 'repeat' related functions instead of direct access to
3315         saved_command_line.
3316         * command.h (repeat_previous, get_saved_command_line,
3317         save_command_line): New declarations.
3318         (dont_repeat): Add comment.
3319
3320 2019-05-30  Tom Tromey  <tromey@adacore.com>
3321
3322         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3323         Fix comment.
3324         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3325
3326 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3327
3328         PR cli/24587
3329         * completer.c (complete): Initialize variable word.
3330
3331 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3332
3333         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3334         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3335         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3336         'body' is NULL to the outter 'if', protecting the '!is_define'
3337         situation as well.
3338
3339 2019-05-29  Tom Tromey  <tromey@adacore.com>
3340
3341         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3342         (dwarf_unknown): New function.
3343         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3344         (dwarf_type_encoding_name): Use dwarf_unknown.
3345
3346 2019-05-29  Tom Tromey  <tromey@adacore.com>
3347
3348         PR c++/20020:
3349         * cp-valprint.c (cp_print_value_fields): Call
3350         cp_print_static_field inside "try".
3351
3352 2019-05-29  Tom Tromey  <tromey@adacore.com>
3353
3354         * inflow.c (struct terminal_info): Add default operator=.
3355         * configure: Rebuild.
3356         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3357         -Wdeprecated-copy-dtor, -Wredundant-move.
3358
3359 2019-05-29  Tom Tromey  <tromey@adacore.com>
3360
3361         * NEWS: Add entry.
3362         * infcmd.c (print_return_value_1): Handle finish_print
3363         option.
3364         (show_print_finish): New function.
3365         (_initialize_infcmd): Add "set/show print finish" commands.
3366         * valprint.c (user_print_options): Initialize new member.
3367         * valprint.h (struct value_print_options) <finish_print>: New
3368         member.
3369
3370 2019-05-28  Tom Tromey  <tromey@adacore.com>
3371
3372         * ada-lang.c (ada_remove_Xbn_suffix)
3373         (find_old_style_renaming_symbol)
3374         (parse_old_style_renaming): Remove.
3375         (ada_find_renaming_symbol): Don't call
3376         find_old_style_renaming_symbol.
3377         (ada_is_renaming_symbol): Rename from
3378         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3379         bool.  Now static.
3380         (ada_read_var_value): Update and simplify.
3381         * ada-exp.y (write_var_or_type): Remove old code.
3382
3383 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3384
3385         * event-top.c: Remove include comment.
3386         * inflow.c (class scoped_ignore_sigttou): Move from here...
3387         * inflow.h (class scoped_ignore_sigttou): ...to here.
3388         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3389         * top.c:  Remove include comment.
3390
3391 2019-05-27  Tom Tromey  <tom@tromey.com>
3392
3393         * NEWS: Fix typo.
3394
3395 2019-05-22  Tom Tromey  <tromey@adacore.com>
3396
3397         * target.c (target_follow_exec): Constify parameter.
3398         * target-delegates.c: Rebuild.
3399         * remote.c (remote_target::follow_exec): Constify parameter.
3400         * infrun.c (follow_exec): Constify parameter.
3401         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3402         (target_follow_exec): Likewise.
3403
3404 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3405
3406         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3407         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3408
3409 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3410
3411         * NEWS: Add debugredirect and testsuite sections.
3412
3413 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3414
3415         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3416         target descriptions using exclusively floating point register name
3417         aliases.
3418
3419 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3420
3421         PR gdb/18644:
3422         * f-lang.c (build_fortran_types): Handle the case where
3423         gdbarch_floatformat_for_type returns a nullptr.
3424
3425 2019-05-21  Tom de Vries  <tdevries@suse.de>
3426
3427         PR cli/24587
3428         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3429
3430 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3431
3432         PR gdb/18644:
3433         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3434         16-byte floats.
3435         * i386-tdep.c (i386_floatformat_for_type): Use
3436         floatformats_ia64_quad for the 16-byte floating point component
3437         within a fortran 32-byte complex number.
3438
3439 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3440
3441         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3442         delete default constructor.
3443         (find_partial_die): Update to return const struct.
3444         (partial_die_parent_scope): Move variable declaration into scope
3445         of its use and change its type to auto.
3446         (guess_partial_die_structure_name): Likewise.
3447         (partial_die_info::fixup): Likewise.
3448
3449 2019-05-17  Tom Tromey  <tromey@adacore.com>
3450
3451         * source.c (find_and_open_source): Remove cast.
3452
3453 2019-05-17  Tom Tromey  <tromey@adacore.com>
3454
3455         * annotate.c (annotate_source): Make "filename" const.
3456         * annotate.h (annotate_source): Use const.
3457
3458 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3459
3460         * disasm.c (set_disassembler_options): Send errors to stderr.
3461
3462 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3463
3464         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3465         (cli_interp_base::set_logging): Check debug_redirect.
3466         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3467         * cli/cli-logging.c (debug_redirect): Add static variable.
3468         (pop_output_files): Add default param.
3469         (handle_redirections): Print debug setting.
3470         (show_logging_command): Likewise.
3471         (_initialize_cli_logging): Add debugredirect command.
3472         * interps.c (current_interp_set_logging): Add debug_redirect
3473         parameter.
3474         * interps.h (set_logging): Add debug_redirect parameter.
3475         (current_interp_set_logging): Likewise.
3476         * mi/mi-common.h: Likewise.
3477         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3478
3479 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3480             Tom Tromey  <tromey@adacore.com>
3481
3482         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3483         directly.
3484         * cli/cli-interp.h (make_logging_output): Remove declaration.
3485         * cli/cli-logging.c (make_logging_output): Remove function.
3486         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3487         directly.
3488         * ui-file.c (tee_file::tee_file): Remove bools.
3489         (tee_file::~tee_file): Remove deletes.
3490         * ui-file.h (tee_file): Remove bools.
3491
3492 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3493
3494         * mi/mi-cmds.h (mi_cmd_complete): New function.
3495         * mi/mi-main.c (mi_cmd_complete): Likewise.
3496         * mi/mi-cmds.c: Define new MI command -complete.
3497         * NEWS: Mention new -complete command.
3498
3499 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3500
3501         * completer.h (complete): New function.
3502         * completer.c (complete): Likewise.
3503         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3504         function defined in completer.h.
3505
3506 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3507
3508         * MAINTAINERS (Write After Approval): Add myself.
3509
3510 2019-05-17  Tom de Vries  <tdevries@suse.de>
3511
3512         PR gdb/24094
3513         * dwarf2read.c (struct cu_partial_die_info): New struct.
3514         (find_partial_die): Return cu_partial_die_info.
3515         (partial_die_parent_scope, guess_partial_die_structure_name)
3516         (partial_die_info::fixup): Handle new return type of find_partial_die.
3517
3518 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3519
3520         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3521         "std::string", simplifying the algorithm.
3522
3523 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3524
3525         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3526         (stap_static_probe_ops::get_probes): Likewise.
3527
3528 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3529
3530         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3531         '-')" and "else if".
3532         (stap_parse_single_operand): Join checks for
3533         "gdbarch_stap_parse_special_token_p" and
3534         "gdbarch_stap_parse_special_token" in the same "if" statement.
3535         Invert check when verifying for operation on register
3536         displacement.
3537
3538 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3539
3540         * stap-probe.c (stap_get_opcode): Update comment.
3541         (stap_get_expected_argument_type): Likewise.
3542         (handle_stap_probe): Likewise.
3543
3544 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3545
3546         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3547         return type to 'bool'.  Adjust comment.  Use 'bool' when
3548         appropriate.
3549         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3550         * stap-probe.c (stap_parse_argument_1): Likewise.
3551         (stap_is_operator): Likewise.
3552         (stap_is_generic_prefix): Likewise.
3553         (stap_is_register_prefix): Likewise.
3554         (stap_is_register_indirection_prefix): Likewise.
3555         (stap_is_integer_prefix): Likewise.
3556         (stap_generic_check_suffix): Likewise.
3557         (stap_check_integer_suffix): Likewise.
3558         (stap_check_register_suffix): Likewise.
3559         (stap_check_register_indirection_suffix): Likewise.
3560         (stap_parse_register_operand): Likewise.
3561         (stap_parse_single_operand): Likewise.
3562         (stap_parse_argument_1): Likewise.
3563         (stap_probe::get_argument_count): Likewise.
3564         (stap_is_operator): Likewise.
3565
3566 2019-05-16  Tom Tromey  <tromey@adacore.com>
3567
3568         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3569         keyword to foreach.
3570
3571 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3572
3573         * linux-thread-db.c (try_thread_db_load_1): Change return type
3574         to bool.
3575         (try_thread_db_load): Likewise.
3576         (try_thread_db_load_from_pdir_1): Likewise.
3577         (try_thread_db_load_from_pdir): Likewise.
3578         (try_thread_db_load_from_sdir): Likewise.
3579         (try_thread_db_load_from_dir): Likewise.
3580         (thread_db_load_search): Likewise.
3581         (has_libpthread): Likewise.
3582         (thread_db_load): Likewise.
3583
3584 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3585
3586         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3587         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3588         NULL, and complain/return if that's the case.
3589
3590 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3591
3592         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3593         (advance, posn, abstract_read_memory): New functions.
3594         [struct mem_read_abstraction]: New struct.
3595         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3596
3597 2019-05-14  Tom Tromey  <tromey@adacore.com>
3598
3599         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3600         value is not lval_memory.
3601
3602 2019-05-14  Tom Tromey  <tromey@adacore.com>
3603
3604         * solib.c (info_sharedlibrary_command): Style the file name.
3605
3606 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3607
3608         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3609         (aarch64_vnv_type): Likewise.
3610         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3611         * common/tdesc.c: Likewise.
3612         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3613         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3614         * features/aarch64-fpu.xml: Add ieee half view.
3615         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3616         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3617         * gdbtypes.h (struct builtin_type): Likewise.
3618         (struct objfile_type): Likewise.
3619
3620 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3621
3622         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3623         typo.
3624         * location.h (string_to_event_location): Likewise.
3625
3626 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3627
3628         GDB 8.3 released.
3629
3630 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3631
3632         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3633         New variable declaration.
3634         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3635         New variable.
3636         (print_one_breakpoint): Use ui_out::test_flags and new global
3637         variable to compute use_fixed_output.
3638         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3639         Remove.
3640         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3641         (mi_multi_location_breakpoint_output_fixed): Remove.
3642         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3643         new variable.
3644         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3645         fix_multi_location_breakpoint_output flag if version >= 3.
3646         * ui-out.h (enum ui_out_flag)
3647         <fix_multi_location_breakpoint_output>: New enumerator.
3648
3649 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3650
3651         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3652
3653 2019-05-10  Tom Tromey  <tromey@adacore.com>
3654
3655         * ada-lang.c (catch_ada_completer): New function.
3656         (_initialize_ada_language): Use it.
3657
3658 2019-05-10  Tom Tromey  <tromey@adacore.com>
3659
3660         * thread.c (print_thread_info): Make "requested_threads" const.
3661         * gdbthread.h (print_thread_info): Make "requested_threads"
3662         const.
3663         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3664         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3665
3666 2019-05-08  Tom Tromey  <tom@tromey.com>
3667
3668         * gdbtypes.c (objfile_type_data): Change type.
3669         (objfile_type, _initialize_gdbtypes): Update.
3670
3671 2019-05-08  Tom Tromey  <tom@tromey.com>
3672
3673         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3674         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3675         (_initialize_dwarf2_frame): Update.
3676
3677 2019-05-08  Tom Tromey  <tom@tromey.com>
3678
3679         * objc-lang.c (objc_objfile_data): Change type.
3680         (find_methods): Update.
3681         (_initialize_objc_lang): Remove.
3682
3683 2019-05-08  Tom Tromey  <tom@tromey.com>
3684
3685         * stabsread.c (rs6000_builtin_type_data): Change type.
3686         (rs6000_builtin_type, _initialize_stabsread): Update.
3687
3688 2019-05-08  Tom Tromey  <tom@tromey.com>
3689
3690         * mips-tdep.c (mips_pdr_data): Remove.
3691         (_initialize_mips_tdep): Update.
3692
3693 2019-05-08  Tom Tromey  <tom@tromey.com>
3694
3695         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3696         (hppa_init_objfile_priv_data, read_unwind_info)
3697         (find_unwind_entry, _initialize_hppa_tdep): Update.
3698
3699 2019-05-08  Tom Tromey  <tom@tromey.com>
3700
3701         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3702         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3703         on obstack.
3704         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3705
3706 2019-05-08  Tom Tromey  <tom@tromey.com>
3707
3708         * mdebugread.c (basic_type_data): Change type.
3709         (basic_type, _initialize_mdebugread): Update.
3710
3711 2019-05-08  Tom Tromey  <tom@tromey.com>
3712
3713         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3714
3715 2019-05-08  Tom Tromey  <tom@tromey.com>
3716
3717         * nto-tdep.c (nto_inferior_data_reg): Change type.
3718         (nto_inferior_data): Update.
3719         (nto_inferior_data_cleanup, nto_new_inferior_data)
3720         (_initialize_nto_tdep): Remove.
3721         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3722
3723 2019-05-08  Tom Tromey  <tom@tromey.com>
3724
3725         * ada-lang.c (struct ada_inferior_data): Add initializers.
3726         (ada_inferior_data): Change type.
3727         (ada_inferior_data_cleanup): Remove.
3728         (get_ada_inferior_data, ada_inferior_exit)
3729         (struct ada_pspace_data): Add initializers, destructor.
3730         (ada_pspace_data_handle): Change type.
3731         (get_ada_pspace_data): Update.
3732         (ada_pspace_data_cleanup): Remove.
3733
3734 2019-05-08  Tom Tromey  <tom@tromey.com>
3735
3736         * coffread.c (struct coff_symfile_info): Add initializers.
3737         (coff_objfile_data_key): Move lower.  Change type.
3738         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3739         Update.
3740         (coff_free_info): Remove.
3741
3742 2019-05-08  Tom Tromey  <tom@tromey.com>
3743
3744         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3745         (fbsd_pspace_data_handle): Move lower.  Change type.
3746         (get_fbsd_pspace_data): Update.
3747         (fbsd_pspace_data_cleanup): Remove.
3748         (_initialize_fbsd_tdep): Update.
3749
3750 2019-05-08  Tom Tromey  <tom@tromey.com>
3751
3752         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3753         (get_ada_tasks_pspace_data): Update.
3754         (ada_tasks_pspace_data_cleanup): Remove.
3755         (_initialize_tasks): Update.
3756         (ada_tasks_inferior_data_handle): Change type.
3757         (get_ada_tasks_inferior_data): Update.
3758         (ada_tasks_inferior_data_cleanup): Remove.
3759         (struct ada_tasks_pspace_data): Add initializers.
3760
3761 2019-05-08  Tom Tromey  <tom@tromey.com>
3762
3763         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3764         * symfile-debug.c (debug_sym_get_probes): Change type.
3765         * stap-probe.c (handle_stap_probe):
3766         (stap_static_probe_ops::get_probes): Change type.
3767         * probe.h (class static_probe_ops) <get_probes>: Change type.
3768         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3769         (parse_probes_in_pspace): Update.
3770         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3771         Update.
3772         (any_static_probe_ops::get_probes): Change type.
3773         * elfread.c (elfread_data): New typedef.
3774         (probe_key): Change type.
3775         (elf_get_probes): Likewise.  Update.
3776         (probe_key_free): Remove.
3777         (_initialize_elfread): Update.
3778         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3779         Change type.
3780         (dtrace_process_dof_probe, dtrace_process_dof)
3781         (dtrace_static_probe_ops::get_probe): Change type.
3782
3783 2019-05-08  Tom Tromey  <tom@tromey.com>
3784
3785         * xcoffread.c (struct xcoff_symfile_info): Rename from
3786         coff_symfile_info.  Add initializers.
3787         (xcoff_objfile_data_key): Move lower.  Change type.
3788         (XCOFF_DATA): Rewrite.
3789         (xcoff_free_info): Remove.
3790         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3791         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3792         (xcoff_initial_scan): Update.
3793
3794 2019-05-08  Tom Tromey  <tom@tromey.com>
3795
3796         * solib-svr4.c (struct svr4_info): Add initializers and
3797         destructor.
3798         <probes_table>: Now an htab_up.
3799         (solib_svr4_pspace_data): Change type.
3800         (free_probes_table): Simplify.
3801         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3802         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3803         (probes_table_remove_objfile_probes, register_solib_event_probe)
3804         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3805         (_initialize_svr4_solib): Update.
3806
3807 2019-05-08  Tom Tromey  <tom@tromey.com>
3808
3809         * remote.c (remote_pspace_data): Change type.
3810         (remote_pspace_data_cleanup): Remove.
3811         (get_remote_exec_file, set_pspace_remote_exec_file)
3812         (_initialize_remote): Update.
3813
3814 2019-05-08  Tom Tromey  <tom@tromey.com>
3815
3816         * breakpoint.c (breakpoint_objfile_key): Change type.
3817         (get_breakpoint_objfile_data): Update.
3818         (free_breakpoint_objfile_data): Remove.
3819         (_initialize_breakpoint): Update.
3820
3821 2019-05-08  Tom Tromey  <tom@tromey.com>
3822
3823         * linux-tdep.c (struct linux_info): Add initializers.
3824         (linux_inferior_data): Move.  Change type.
3825         (invalidate_linux_cache_inf): Update.
3826         (linux_inferior_data_cleanup): Remove.
3827         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3828
3829 2019-05-08  Tom Tromey  <tom@tromey.com>
3830
3831         * auxv.c (auxv_inferior_data): Move.  Change type.
3832         (auxv_inferior_data_cleanup): Remove.
3833         (invalidate_auxv_cache_inf): Rewrite.
3834         (get_auxv_inferior_data, _initialize_auxv): Update.
3835
3836 2019-05-08  Tom Tromey  <tom@tromey.com>
3837
3838         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3839         (symfile_debug_objfile_data_key): Change type.
3840         (symfile_debug_installed, debug_qf_has_symbols)
3841         (debug_qf_find_last_source_symtab)
3842         (debug_qf_forget_cached_source_info)
3843         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3844         (debug_qf_print_stats, debug_qf_dump)
3845         (debug_qf_expand_symtabs_for_function)
3846         (debug_qf_expand_all_symtabs)
3847         (debug_qf_expand_symtabs_with_fullname)
3848         (debug_qf_map_matching_symbols)
3849         (debug_qf_expand_symtabs_matching)
3850         (debug_qf_find_pc_sect_compunit_symtab)
3851         (debug_qf_map_symbol_filenames)
3852         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3853         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3854         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3855         (debug_sym_read_linetable, debug_sym_relocate): Update.
3856         (symfile_debug_free_objfile): Remove.
3857         (install_symfile_debug_logging, _initialize_symfile_debug):
3858         Update.
3859
3860 2019-05-08  Tom Tromey  <tom@tromey.com>
3861
3862         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3863         allocate_on_obstack.
3864         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3865         (get_dwarf2_per_objfile): Update.
3866         (set_dwarf2_per_objfile): Remove.
3867         (dwarf2_has_info, dwarf2_get_section_info): Update.
3868         (dwarf2_free_objfile): Remove.
3869         (_initialize_dwarf2_read): Update.
3870
3871 2019-05-08  Tom Tromey  <tom@tromey.com>
3872
3873         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3874         initializers.
3875         <unsupported_script_warning_printed,
3876         script_not_found_warning_printed>: Now bool.
3877         (auto_load_pspace_data): Change type.
3878         (~auto_load_pspace_info): Rename from
3879         auto_load_pspace_data_cleanup.
3880         (get_auto_load_pspace_data, init_loaded_scripts_info)
3881         (clear_section_scripts, maybe_print_unsupported_script_warning)
3882         (maybe_print_script_not_found_warning, _initialize_auto_load):
3883         Update.
3884
3885 2019-05-08  Tom Tromey  <tom@tromey.com>
3886
3887         * objfiles.c (objfile_pspace_info): Add destructor and
3888         initializers.
3889         (objfiles_pspace_data): Change type.
3890         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3891         (get_objfile_pspace_data): Update.
3892         (objfiles_bfd_data): Change type.
3893         (get_objfile_bfd_data): Update.
3894         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3895
3896 2019-05-08  Tom Tromey  <tom@tromey.com>
3897
3898         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3899         Change type.
3900         (get_catch_syscall_inferior_data): Update.
3901         (catch_syscall_inferior_data_cleanup): Remove.
3902         (_initialize_break_catch_syscall): Update.
3903
3904 2019-05-08  Tom Tromey  <tom@tromey.com>
3905
3906         * inflow.c (struct terminal_info): Add destructor and
3907         initializers.
3908         (inflow_inferior_data): Change type.
3909         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3910         (get_inflow_inferior_data, inflow_inferior_exit)
3911         (swap_terminal_info, _initialize_inflow): Update.
3912
3913 2019-05-08  Tom Tromey  <tom@tromey.com>
3914
3915         * target-dcache.c (target_dcache_cleanup): Remove.
3916         (target_dcache_aspace_key): Change type.
3917         (target_dcache_init_p, target_dcache_invalidate)
3918         (target_dcache_get, target_dcache_get_or_init)
3919         (_initialize_target_dcache): Update.
3920         * dcache.h (struct dcache_deleter): New.
3921
3922 2019-05-08  Tom Tromey  <tom@tromey.com>
3923
3924         * symtab.c (struct symbol_cache): Add destructor and
3925         initializers.
3926         (symbol_cache_key): Move.  Change type.
3927         (make_symbol_cache, free_symbol_cache): Remove.
3928         (get_symbol_cache): Update.
3929         (symbol_cache_cleanup): Remove.
3930         (ALL_PSPACES, symbol_cache_flush)
3931         (maintenance_print_symbol_cache)
3932         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3933         Update.
3934
3935 2019-05-08  Tom Tromey  <tom@tromey.com>
3936
3937         * symtab.c (struct main_info): Add destructor and initializers.
3938         (main_progspace_key): Move.  Change type.
3939         (get_main_info): Update.
3940         (main_info_cleanup): Remove.
3941         (_initialize_symtab): Update.
3942
3943 2019-05-08  Tom Tromey  <tom@tromey.com>
3944
3945         * registry.h (DECLARE_REGISTRY): Define the _key class.
3946
3947 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3948
3949         * NEWS: Merge two 'New commands' sections.
3950
3951 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3952
3953         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3954         parameter and use Ada language definition instead.
3955         (ada_val_print_ptr): Remove unused language parameter.
3956         (ada_val_print_num): Remove language parameter and use Ada language
3957         definition instead.
3958         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3959         parameter.
3960         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3961         parameter and use Ada language definition instead.
3962         (ada_val_print_1): Update all ada_val_print_xxx calls.
3963         Remove language parameter.
3964         (ada_val_print): Update ada_val_print_1 call.
3965
3966 2019-05-08  Tom Tromey  <tromey@adacore.com>
3967
3968         * remote.c (remote_hw_watchpoint_limit)
3969         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3970         Now static.
3971
3972 2019-05-08  Tom Tromey  <tromey@adacore.com>
3973
3974         * maint.c (_initialize_maint_cmds): Move initialization code to
3975         remote.c.
3976         (watchdog, show_watchdog): Move to remote.c.
3977         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3978         "watchdog" static.
3979         (_initialize_remote): Move initialization code from maint.c.
3980         * defs.h (watchdog): Don't declare.
3981
3982 2019-05-08  Tom Tromey  <tromey@adacore.com>
3983
3984         * tui/tui-interp.c: Include main.h.
3985         * interps.c: Include main.h.
3986         * main.h (interpreter_p): Declare.
3987         * defs.h (interpreter_p): Don't declare.
3988
3989 2019-05-08  Tom Tromey  <tromey@adacore.com>
3990
3991         * dwarf2loc.c: Include dwarf2read.h.
3992         * defs.h (read_unsigned_leb128): Don't declare.
3993         * dwarf2read.h (read_unsigned_leb128): Declare.
3994
3995 2019-05-08  Tom Tromey  <tromey@adacore.com>
3996
3997         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3998         method.
3999
4000 2019-05-08  Tom Tromey  <tromey@adacore.com>
4001
4002         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4003         when no wrap column is set.
4004
4005 2019-05-08  Tom Tromey  <tromey@adacore.com>
4006
4007         * c-lang.c (c_get_string): Handle non-C-style arrays.
4008
4009 2019-05-08  Tom Tromey  <tromey@adacore.com>
4010
4011         * typeprint.c (print_offset_data::update): Print the bit offset,
4012         not the number of bits remaining.
4013
4014 2019-05-08  Tom Tromey  <tromey@adacore.com>
4015
4016         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4017         padding at end of comment.
4018
4019 2019-05-08  Tom Tromey  <tromey@adacore.com>
4020
4021         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4022         Compare main types.
4023
4024 2019-05-06  Tom Tromey  <tom@tromey.com>
4025
4026         * common/scoped_mmap.c: Include common-defs.h.
4027         * common/scoped_mmap.h: Don't include config.h.
4028
4029 2019-05-04  Tom Tromey  <tom@tromey.com>
4030
4031         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4032         (struct aarch64_call_info): Add initializers.
4033         <si>: Now a std::vector.
4034         (pass_on_stack, aarch64_push_dummy_call): Update.
4035
4036 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4037             Tom Tromey  <tom@tromey.com>
4038
4039         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4040         (ppc_threads): Now a std::vector.  Now static.
4041         (hwdebug_find_thread_points_by_tid)
4042         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4043         Update.
4044
4045 2019-05-04  Tom Tromey  <tom@tromey.com>
4046
4047         * arc-tdep.c (arc_tdesc_init): Return bool.
4048
4049 2019-05-04  Tom Tromey  <tom@tromey.com>
4050
4051         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4052         Use gdb_assert_not_reached.
4053
4054 2019-05-04  Tom Tromey  <tom@tromey.com>
4055
4056         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4057         "false".
4058
4059 2019-05-04  Tom Tromey  <tom@tromey.com>
4060
4061         * arc-tdep.c (arc_tdesc_init): Use bool.
4062
4063 2019-05-04  Tom Tromey  <tom@tromey.com>
4064
4065         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4066
4067 2019-05-04  Tom Tromey  <tom@tromey.com>
4068
4069         * cli/cli-cmds.c (valid_command_p): Return bool.
4070
4071 2019-05-04  Tom Tromey  <tom@tromey.com>
4072
4073         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4074         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4075
4076 2019-05-04  Raul Tambre  <raul@tambre.ee>
4077
4078         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4079         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4080         operator for comparison.
4081
4082 2019-05-04  Tom Tromey  <tom@tromey.com>
4083
4084         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4085         (lookup_partial_symbol, print_partial_symbols)
4086         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4087         (psymbol_compare): Update.
4088         (add_psymbol_to_bcache): Clear the entire psymbol.
4089         (maintenance_check_psymtabs): Update.
4090         * psympriv.h (struct partial_symbol): Don't derive from
4091         general_symbol_info.
4092         <obj_section, unrelocated_address, address,
4093         set_unrelocated_address>: Update.
4094         <ginfo>: New member.
4095         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4096         (debug_names::write_psymbols): Update.
4097
4098 2019-05-04  Tom de Vries  <tdevries@suse.de>
4099
4100         * contrib/cc-with-tweaks.sh: Support -n arg.
4101
4102 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4103
4104         * corelow.c (core_target::detach): Ensure frame cache and
4105         register caches are cleared.
4106         inferior.c (exit_inferior_1): Likewise.
4107
4108 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4109             Tom Tromey  <tom@tromey.com>
4110
4111         * dictionary.c (collate_pending_symbols_by_language): Remove
4112         "struct" from foreach.
4113         * symtab.c (lookup_global_symbol_from_objfile)
4114         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4115         foreach.
4116         * ser-tcp.c (net_open): Remove "struct" from foreach.
4117         * objfiles.c (objfile_relocate, objfile_rebase)
4118         (objfile_has_symbols): Remove "struct" from foreach.
4119         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4120         from foreach.
4121         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4122         foreach.
4123         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4124         "struct" from foreach.
4125         * ada-lang.c (create_excep_cond_exprs)
4126         (ada_exception_catchpoint_cond_string): Remove "struct" from
4127         foreach.
4128
4129 2019-05-03  Tom Tromey  <tromey@adacore.com>
4130
4131         * ada-exp.y (convert_char_literal): Check suffix of each
4132         enumerator.
4133
4134 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4135
4136         PR ada/21406:
4137         * ada-exp.y (yywrap): Don't define.
4138         * ada-lex.l (%option): Add noyywrap
4139         (yywrap): Remove.
4140
4141 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4142
4143         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4144         _WIN32_WINNT to the XP level, unless already defined to a higher
4145         level.
4146
4147         * unittests/parse-connection-spec-selftests.c:
4148         * ser-tcp.c:
4149         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4150         override.
4151
4152         * symfile.c (find_separate_debug_file): Remove colon from the
4153         drive spec of DOS/Windows file names of the target, so that the
4154         file name produced from DEBUGDIR and the target's directory will
4155         be valid on DOS/Windows systems.
4156
4157 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * rust-lang.c (val_print_struct): Handle printing structures
4160         containing strings.
4161
4162 2019-05-02  Tom Tromey  <tromey@adacore.com>
4163
4164         * valarith.c (_initialize_valarith): Remove.
4165
4166 2019-05-01  Tom Tromey  <tromey@adacore.com>
4167
4168         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4169         bitfields.
4170
4171 2019-05-01  Tom Tromey  <tromey@adacore.com>
4172
4173         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4174         for big-endian copies.
4175
4176 2019-04-30  Ali Tamur  <tamur@google.com>
4177         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4178         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4179         (read_3_bytes): New function.
4180
4181 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4182
4183         * windows-nat.c (main_thread_id): Delete.
4184         (handle_output_debug_string): Replace main_thread_id by
4185         current_event.dwThreadId.
4186         (fake_create_process): Likewise.
4187         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4188         Do not set main_thread_id.
4189         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4190         current_event.dwThreadId.
4191         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4192
4193 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4194
4195         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4196         Use current_event.dwThreadId instead of main_thread_id.
4197
4198 2019-04-30  Tom Tromey  <tromey@adacore.com>
4199
4200         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4201         (create_excep_cond_exprs): Iterate over program spaces.
4202         (ada_exception_catchpoint_cond_string): Examine all minimal
4203         symbols for exception types.
4204
4205 2019-04-30  Tom Tromey  <tromey@adacore.com>
4206
4207         PR c++/24470:
4208         * dwarf2read.c (process_structure_scope): Handle case where type
4209         has template parameters but no symbol was created.
4210
4211 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4212             Chris January  <chris.january@arm.com>
4213
4214         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4215         qualifier.
4216         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4217
4218 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4219
4220         * f-typeprint.c (f_print_type): Update rules for printing
4221         whitespace.
4222         (f_type_print_varspec_suffix): Likewise.
4223
4224 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4225             Chris January  <chris.january@arm.com>
4226
4227         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4228         function arguments.
4229
4230 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4231
4232         * f-lang.c (build_fortran_types): Change name of void type to
4233         lower case.
4234         * f-typeprint.c (f_type_print_base): Print the name of the void
4235         type, rather than a fixed string.
4236         * f-valprint.c (f_decorations): Use lower case void string.
4237
4238 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4239             Chris January  <chris.january@arm.com>
4240
4241         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4242         types for Fortran.
4243
4244 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4245             Chris January  <chris.january@arm.com>
4246             David Lecomber  <david.lecomber@arm.com>
4247
4248         * f-exp.y (BINOP_INTRINSIC): New token.
4249         (exp): New parser rule handling BINOP_INTRINSIC.
4250         (f77_keywords): Add new builtin procedures.
4251         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4252         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4253         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4254         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4255         (print_unop_subexp_f): New function.
4256         (print_binop_subexp_f): New function.
4257         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4258         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4259         (dump_subexp_body_f): Likewise.
4260         (operator_check_f): Likewise.
4261         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4262         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4263
4264 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4265
4266         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4267         UNOP_KIND.
4268         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4269         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4270         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4271         (operator_length_f): New fuction.
4272         (print_subexp_f): New function.
4273         (op_name_f): New function.
4274         (dump_subexp_body_f): New function.
4275         (operator_check_f): New function.
4276         (exp_descriptor_f): Replace standard expression handling functions
4277         with new functions.
4278         * gdb/fortran-operator.def: New file.
4279         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4280         * gdb/std-operator.def: Remove UNOP_KIND.
4281
4282 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4283
4284         * std-operator.def: Remove unbalanced, stray double quote
4285         character.
4286
4287 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4288             Chris January  <chris.january@arm.com>
4289             Daniel Everett  <daniel.everett@arm.com>
4290             Nick Forrington  <nick.forrington@arm.com>
4291             Richard Bunt  <richard.bunt@arm.com>
4292
4293         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4294         of depth when printing anonymous structs or unions.
4295         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4296         Don't print either the top-level value, or the children if the
4297         max-depth is exceeded.
4298         (ppscm_print_children): When printing the key of a map, allow one
4299         extra level of depth.
4300         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4301         print either the top-level value, or the children if the max-depth
4302         is exceeded.
4303         (print_children): When printing the key of a map, allow one extra
4304         level of depth.
4305         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4306         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4307         (user_print_options): Initialise max_depth field.
4308         (val_print_scalar_or_string_type_p): New function.
4309         (val_print): Check to see if the max depth has been reached.
4310         (val_print_check_max_depth): Define new function.
4311         (show_print_max_depth): New function.
4312         (_initialize_valprint): Add 'print max-depth' option.
4313         * valprint.h (struct value_print_options) <max_depth>: New field.
4314         (val_print_check_max_depth): Declare new function.
4315         * NEWS: Document new feature.
4316
4317 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4318
4319         * ada-lang.c (ada_language_defn): Initialise new field.
4320         * c-lang.c (c_is_string_type_p): New function.
4321         (c_language_defn): Initialise new field.
4322         (cplus_language_defn): Initialise new field.
4323         (asm_language_defn): Initialise new field.
4324         (minimal_language_defn): Initialise new field.
4325         * c-lang.h (c_is_string_type_p): Declare new function.
4326         * d-lang.c (d_language_defn): Initialise new field.
4327         * f-lang.c (f_is_string_type_p): New function.
4328         (f_language_defn): Initialise new field.
4329         * go-lang.c (go_is_string_type_p): New function.
4330         (go_language_defn): Initialise new field.
4331         * language.c (default_is_string_type_p): New function.
4332         (unknown_language_defn): Initialise new field.
4333         (auto_language_defn): Initialise new field.
4334         * language.h (struct language_defn) <la_is_string_type_p>: New
4335         member variable.
4336         (default_is_string_type_p): Declare new function.
4337         * m2-lang.c (m2_language_defn): Initialise new field.
4338         * objc-lang.c (objc_language_defn): Initialise new field.
4339         * opencl-lang.c (opencl_language_defn): Initialise new field.
4340         * p-lang.c (pascal_is_string_type_p): New function.
4341         (pascal_language_defn): Initialise new field.
4342         * rust-lang.c (rust_is_string_type_p): New function.
4343         (rust_language_defn): Initialise new field.
4344
4345 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4346
4347         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4348         New field.
4349         * ada-lang.c (ada_language_defn): Initialise new field.
4350         * c-lang.c (c_language_defn): Likewise.
4351         (cplus_language_defn): Likewise.
4352         (asm_language_defn): Likewise.
4353         (minimal_language_defn): Likewise.
4354         * d-lang.c (d_language_defn): Likewise.
4355         * f-lang.c (f_language_defn): Likewise.
4356         * go-lang.c (go_language_defn): Likewise.
4357         * language.c (unknown_language_defn): Likewise.
4358         (auto_language_defn): Likewise.
4359         * m2-lang.c (m2_language_defn): Likewise.
4360         * objc-lang.c (objc_language_defn): Likewise.
4361         * opencl-lang.c (opencl_language_defn): Likewise.
4362         * p-lang.c (pascal_language_defn): Likewise.
4363         * rust-lang.c (rust_language_defn): Likewise.
4364
4365 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4366
4367         * ada-lang.c (ada_is_character_type): Change return type to bool.
4368         (ada_is_string_type): Likewise.
4369         * ada-lang.h (ada_is_character_type): Update declaration
4370         (ada_is_string_type): Likewise.
4371
4372 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4373
4374         Support style in 'frame|thread apply'
4375
4376         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4377         * record.c (record_start, record_stop): Update callers of
4378         execute_command_to_string with false.
4379         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4380         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4381         methods.
4382         (class string_file): New constructor with term_out parameter.
4383         Override methods term_out and can_emit_style_escape.  New member
4384         term_out.
4385         (class stdio_file): Override can_emit_style_escape.
4386         (class tee_file): Override term_out and can_emit_style_escape.
4387         * utils.h (can_emit_style_escape): Remove.
4388         * utils.c (can_emit_style_escape): Likewise.
4389         Update all callers of can_emit_style_escape (SOMESTREAM) to
4390         SOMESTREAM->can_emit_style_escape.
4391         * source-cache.c (source_cache::get_source_lines): Likewise.
4392         * stack.c (frame_apply_command_count): Call execute_command_to_string
4393         passing the term_out characteristic of the current gdb_stdout.
4394         * thread.c (thr_try_catch_cmd): Likewise.
4395         * top.c (execute_command_to_string): pass term_out parameter
4396         to construct the string_file for the command output.
4397         * ui-file.c (term_cli_styling): New function (most code moved
4398         from utils.c can_emit_style_escape).
4399         (string_file::string_file, string_file::can_emit_style_escape,
4400         stdio_file::can_emit_style_escape, tee_file::term_out,
4401         tee_file::can_emit_style_escape): New functions.
4402
4403 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4404
4405         * NEWS: Mention the new set|show may-call-functions.
4406         * infcall.c (may_call_functions_p): New variable.
4407         (show_may_call_functions_p): New function.
4408         (call_function_by_hand_dummy): Throws an error if not
4409         may-call-functions.
4410         (_initialize_infcall): Call add_setshow_boolean_cmd for
4411         may-call-functions.
4412
4413 2019-04-25  Keith Seitz  <keiths@redhat.com>
4414
4415         PR c++/24367
4416         * cp-support.c (inspect_type): Don't attempt substitutions
4417         of symbol with the same name.
4418
4419 2019-04-25  Tom Tromey  <tromey@adacore.com>
4420
4421         PR gdb/24475:
4422         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4423         static.
4424
4425 2019-04-25  Tom Tromey  <tromey@adacore.com>
4426
4427         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4428         rvalue reference.
4429         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4430         (gdb_xml_parser::parse): Use std::move.
4431         * python/python-internal.h (gdbpy_convert_exception): Take a const
4432         reference.
4433         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4434         std::move.
4435         * python/py-utils.c (gdbpy_convert_exception): Take a const
4436         reference.
4437         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4438         Use std::move.
4439         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4440         Use std::move.
4441         * mi/mi-main.c (mi_print_exception): Take a const reference.
4442         * main.c (handle_command_errors): Take a const reference.
4443         * linespec.c (parse_linespec): Use std::move.
4444         * infcall.c (run_inferior_call): Use std::move.
4445         (call_function_by_hand_dummy): Use std::move.
4446         * exec.c (try_open_exec_file): Use std::move.
4447         * exceptions.h (exception_print, exception_fprintf)
4448         (exception_print_same): Update.
4449         * exceptions.c (print_exception, exception_print)
4450         (exception_fprintf, exception_print_same): Change parameters to
4451         const reference.
4452         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4453         * common/new-op.c: Use std::move.
4454         * common/common-exceptions.h (struct gdb_exception): Add move
4455         constructor.
4456         (struct gdb_exception_error, struct gdb_exception_quit, struct
4457         gdb_quit_bad_alloc): Change constructor to move constructor.
4458         (throw_exception): Change parameter to rvalue reference.
4459         * common/common-exceptions.c (throw_exception): Take rvalue
4460         reference.
4461         * cli/cli-interp.c (safe_execute_command): Use std::move.
4462         * breakpoint.c (insert_bp_location, location_to_sals): Use
4463         std::move.
4464
4465 2019-04-25  Tom Tromey  <tromey@adacore.com>
4466
4467         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4468         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4469         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4470         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4471         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4472         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4473         guile/scm-value.c: Use unpack.
4474         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4475         gdbscm_gdb_exception.
4476         (gdbscm_throw_gdb_exception): Likewise.
4477         (struct gdbscm_gdb_exception): New.
4478         (unpack): New function.
4479         (gdbscm_wrap): Use unpack.
4480
4481 2019-04-25  Tom Tromey  <tromey@adacore.com>
4482
4483         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4484         (gdb_rl_callback_handler): Use std::move.
4485         * common/common-exceptions.h (struct gdb_exception): Add move
4486         assignment operator.
4487         (throw_exception_sjlj): Change "exception" to const reference.
4488         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4489         (throw_exception_sjlj): Change "exception" to const reference.
4490
4491 2019-04-25  Tom Tromey  <tromey@adacore.com>
4492
4493         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4494         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4495         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4496         Update.
4497         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4498         Update.
4499         * mi/mi-interp.c (mi_interp::exec): Update.
4500         * linespec.c (parse_linespec): Update.
4501         * infcall.c (run_inferior_call): Update.
4502         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4503         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4504         (gdbscm_lookup_global_symbol): Update.
4505         * guile/scm-param.c (gdbscm_parameter_value): Update.
4506         * guile/scm-frame.c (gdbscm_frame_read_register)
4507         (gdbscm_frame_read_var): Update.
4508         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4509         * exec.c (try_open_exec_file): Update.
4510         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4511         (gdb_rl_callback_handler): Update.
4512         * common/common-exceptions.h (exception_none): Don't declare.
4513         * common/common-exceptions.c (exception_none): Don't define.
4514         (struct catcher) <exception>: Update.
4515         * cli/cli-interp.c (safe_execute_command): Update.
4516         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4517
4518 2019-04-25  Ali Tamur  <tamur@google.com>
4519
4520         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4521         (read_attribute_value): Likewise.
4522         (dwarf2_read_addr_index): Update comment.
4523         (read_str_index): Add DW_FORM_strx.
4524         (dwarf2_string_attr): Likewise.
4525         (dwarf2_const_value_attr): Likewise.
4526         (dump_die_shallow): Likewise.
4527         (dwarf2_fetch_constant_bytes): Likewise.
4528         (skip_form_bytes): Likewise.
4529         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4530
4531 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4532
4533         PR corefiles/11608
4534         PR corefiles/18187
4535         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4536         OFFSET.  Verify if current mapping contains an ELF header.
4537         (linux_find_memory_regions_full): Adjust call to
4538         dump_mapping_p.
4539
4540 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4541             Kang Li <kanglictf@gmail.com>
4542
4543         PR gdb/21600
4544
4545         * dwarf2-frame.c (read_initial_length): Be consistent about using
4546         unsigned representation of length.
4547         (decode_frame_entry_1): Likewise.  Check for wraparound of
4548         end pointer as well as buffer overflow.
4549
4550 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4551
4552         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4553         "vq".
4554
4555 2019-04-24  Tom Tromey  <tromey@adacore.com>
4556
4557         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4558
4559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4560
4561         * s12z-tdep.c (s12z_unwind_pc): Delete.
4562         (s12z_unwind_sp): Delete.
4563         (s12z_gdbarch_init): Don't register deleted functions with
4564         gdbarch.
4565
4566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * rl78-tdep.c (rl78_unwind_sp): Delete.
4569         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4570
4571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4572
4573         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4574         (xstormy16_unwind_pc): Delete.
4575         (xstormy16_dummy_id): Delete.
4576         (xstormy16_gdbarch_init): Don't register deleted functions with
4577         gdbarch.
4578
4579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4580
4581         * vax-tdep.c (vax_unwind_pc): Delete.
4582         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4583
4584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4585
4586         * v850-tdep.c (v850_unwind_sp): Delete.
4587         (v850_unwind_pc): Delete.
4588         (v850_dummy_id): Delete.
4589         (v850_gdbarch_init): Don't register deleted functions with
4590         gdbarch.
4591
4592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4593
4594         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4595         (tilegx_unwind_pc): Delete.
4596         (tilegx_unwind_dummy_id): Delete.
4597         (tilegx_gdbarch_init): Don't register deleted functions with
4598         gdbarch.
4599
4600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4601
4602         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4603         (tic6x_dummy_id): Delete.
4604         (tic6x_gdbarch_init): Don't register deleted functions with
4605         gdbarch.
4606
4607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4608
4609         * sparc-tdep.c (sparc_unwind_pc): Delete.
4610         (sparc32_gdbarch_init): Don't register deleted function with
4611         gdbarch.
4612
4613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4614
4615         * sh-tdep.c (sh_unwind_sp): Delete.
4616         (sh_unwind_pc): Delete.
4617         (sh_dummy_id): Delete.
4618         (sh_gdbarch_init): Don't register deleted functions with
4619         gdbarch.
4620
4621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4622
4623         * score-tdep.c (score_unwind_sp): Delete.
4624         (score_unwind_pc): Delete.
4625         (score_dummy_id): Delete.
4626         (score_gdbarch_init): Don't register deleted functions with
4627         gdbarch.
4628
4629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4630
4631         * rx-tdep.c (rx_unwind_pc): Delete.
4632         (rx_unwind_sp): Delete.
4633         (rx_dummy_id): Delete.
4634         (rx_gdbarch_init): Don't register deleted functions with
4635         gdbarch.  Update comment.
4636
4637 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4638
4639         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4640         (rs6000_dummy_id): Delete.
4641         (rs6000_gdbarch_init): Don't register deleted functions with
4642         gdbarch.
4643
4644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4645
4646         * or1k-tdep.c (or1k_dummy_id): Delete.
4647         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4648
4649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4650
4651         * nios2-tdep.c (nios2_dummy_id): Delete.
4652         (nios2_unwind_sp): Delete.
4653         (nios2_gdbarch_init): Don't register deleted functions with
4654         gdbarch.
4655
4656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4657
4658         * nds32-tdep.c (nds32_dummy_id): Delete.
4659         (nds32_unwind_pc): Delete.
4660         (nds32_unwind_sp): Delete.
4661         (nds32_gdbarch_init): Don't register deleted functions with
4662         gdbarch.
4663
4664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4665
4666         * msp430-tdep.c (msp430_unwind_pc): Delete.
4667         (msp430_unwind_sp): Delete.
4668         (msp430_dummy_id): Delete.
4669         (msp430_gdbarch_init): Don't register deleted functions with
4670         gdbarch.
4671
4672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4673
4674         * moxie-tdep.c (moxie_unwind_sp): Delete.
4675         (moxie_unwind_pc): Delete.
4676         (moxie_dummy_id): Delete.
4677         (moxie_gdbarch_init): Don't register deleted functions with
4678         gdbarch.
4679
4680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4681
4682         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4683         (mn10300_unwind_pc): Delete.
4684         (mn10300_unwind_sp): Delete.
4685         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4686         mn10300_unwind_sp.
4687         (mn10300_frame_unwind_init): Don't register deleted functions with
4688         gdbarch.
4689
4690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4691
4692         * mep-tdep.c (mep_unwind_pc): Delete.
4693         (mep_unwind_sp): Delete.
4694         (mep_dummy_id): Delete.
4695         (mep_gdbarch_init): Don't register deleted functions with
4696         gdbarch.
4697
4698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4699
4700         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4701         (m68hc11_unwind_sp): Delete.
4702         (m68hc11_gdbarch_init): Don't register deleted functions with
4703         gdbarch.
4704
4705 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4706
4707         * m32r-tdep.c (m32r_unwind_sp): Delete.
4708         (m32r_unwind_pc): Delete.
4709         (m32r_dummy_id): Delete.
4710         (m32r_gdbarch_init): Don't register deleted functions with
4711         gdbarch.
4712
4713 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4714
4715         * m32c-tdep.c (m32c_unwind_pc): Delete.
4716         (m32c_unwind_sp): Delete.
4717         (m32c_dummy_id): Delete.
4718         (m32c_gdbarch_init): Don't register deleted functions with
4719         gdbarch.
4720
4721 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4722
4723         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4724         (lm32_unwind_pc): Delete.
4725         (lm32_dummy_id): Delete.
4726         (lm32_gdbarch_init): Don't register deleted functions with
4727         gdbarch.
4728
4729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4730
4731         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4732         (iq2000_unwind_pc): Delete.
4733         (iq2000_dummy_id): Delete.
4734         (iq2000_gdbarch_init): Don't register deleted functions with
4735         gdbarch.
4736
4737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4738
4739         * nds32-tdep.c (nds32_type_align): Delete.
4740         (nds32_push_dummy_call): Use type_align instead.
4741
4742 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4743
4744         * arm-tdep.c (arm_type_align): Only handle vector override case.
4745         (arm_push_dummy_call): Use type_align.
4746         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4747
4748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4749
4750         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4751         case.
4752         (pass_on_stack): Use type_align.
4753         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4754         function.
4755
4756 2019-04-23  Tom Tromey  <tromey@adacore.com>
4757
4758         * dwarf2read.c (line_header::file_name_at): Remove unused
4759         overload.
4760
4761 2019-04-23  Tom de Vries  <tdevries@suse.de>
4762
4763         PR gdb/24438
4764         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4765         invocation.
4766
4767
4768 2019-03-27  Ali Tamur  <tamur@google.com>
4769
4770         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4771         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4772         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4773         (dwarf_expr_context::get_addr_index): Likewise
4774         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4775         (symbol_needs_eval_context::get_addr_index): Likewise
4776         (disassemble_dwarf_expression): Add DW_OP_addrx
4777         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4778         (read_cutu_die_from_dwo): Update comment
4779         (skip_one_die): Add DW_FORM_addrx
4780         (read_attribute_value): Likewise
4781         (var_decode_location): Add DW_OP_addrx
4782         (dwarf2_const_value_attr): Add DW_FORM_addrx
4783         (dump_die_shallow): Likewise
4784         (dwarf2_fetch_constant_bytes): Likewise
4785         (decode_locdesc): Add DW_OP_addrx
4786         (skip_form_bytes): Add DW_FORM_addrx
4787
4788 2019-04-22  Ali Tamur  <tamur@google.com>
4789
4790         * MAINTAINERS (Write After Approval): Add self.
4791
4792 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4793
4794         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4795         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4796         (open_symbol_file_object): Likewise.
4797         (svr4_default_sos): Add info parameter.
4798         (svr4_read_so_list): Likewise.
4799         (svr4_current_sos_direct): Adjust functions calls to pass down
4800         info.
4801         (svr4_current_sos_1): Add info parameter.
4802         (svr4_current_sos): Call get_svr4_info, pass info down to
4803         svr4_current_sos_1.
4804         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4805         get_svr4_info.
4806         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4807         get_svr4_info.
4808         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4809         to get_svr4_info.
4810         (probes_table_remove_objfile_probes): Likewise.
4811         (register_solib_event_probe): Add info parameter.
4812         (solist_update_incremental): Pass info parameter down to
4813         svr4_read_so_list.
4814         (disable_probes_interface): Add info parameter.
4815         (svr4_handle_solib_event): Pass current_program_space to
4816         get_svr4_info.  Adjust disable_probes_interface cleanup.
4817         (svr4_create_probe_breakpoints): Add info parameter, pass it
4818         down to register_solib_event_probe.
4819         (svr4_create_solib_event_breakpoints): Add info parameter,
4820         pass it down to svr4_create_probe_breakpoints.
4821         (enable_break): Pass info down to
4822         svr4_create_solib_event_breakpoints.
4823         (svr4_solib_create_inferior_hook): Pass current_program_space to
4824         get_svr4_info.
4825         (svr4_clear_solib): Likewise.
4826
4827 2019-04-22  Pedro Alves  <palves@redhat.com>
4828
4829         * solib-svr4.c (svr4_free_objfile_observer): New.
4830         (probe_and_action::objfile): New field.
4831         (probes_table_htab_remove_objfile_probes)
4832         (probes_table_remove_objfile_probes): New functions.
4833         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4834         in the new probe_and_action.  Don't store the probe in 'lookup'.
4835         (svr4_create_probe_breakpoints): Pass objfile to
4836         register_solib_event_probe.
4837         (_initialize_svr4_solib): Register a free_objfile observer.
4838
4839 2019-04-19  Tom Tromey  <tom@tromey.com>
4840
4841         * common/queue.h: Remove.
4842
4843 2019-04-19  Tom Tromey  <tom@tromey.com>
4844
4845         * event-loop.c: Don't include "common/queue.h".
4846
4847 2019-04-19  Tom Tromey  <tom@tromey.com>
4848
4849         * remote.c (remote_target): Use delete.
4850         * remote-notif.h: Include <list>, not "common/queue.h".
4851         (notif_client_p): Remove typedef.
4852         (remote_notif_state): Add constructor, destructor, initializer.
4853         <notif_queue>: Now a std::list.
4854         (remote_notif_state_xfree): Don't declare.
4855         * remote-notif.c (remote_notif_process, handle_notification)
4856         (remote_notif_state_allocate): Update.
4857         (~remote_notif_state): Rename from remote_notif_state_xfree.
4858
4859 2019-04-19  Tom Tromey  <tom@tromey.com>
4860
4861         * symfile.c (reread_symbols): Update.
4862         * objfiles.c (objfile_register_static_link)
4863         (objfile_lookup_static_link): Update
4864         (~objfile) Don't delete static_links.
4865         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4866
4867 2019-04-19  Tom Tromey  <tom@tromey.com>
4868
4869         * type-stack.h (struct type_stack) <insert>: Constify string.
4870         * type-stack.c (type_stack::insert): Constify string.
4871         * gdbtypes.h (lookup_template_type): Update.
4872         (address_space_name_to_int): Update.
4873         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4874         const.
4875         (lookup_template_type): Make name const.
4876         * c-exp.y: Update rules.
4877         (lex_one_token, classify_name, classify_inner_name)
4878         (c_print_token): Update.
4879         * p-exp.y: Update rules.
4880         (yylex): Update.
4881         * f-exp.y: Update rules.
4882         (yylex): Update.
4883         * d-exp.y: Update rules.
4884         (lex_one_token, classify_name, classify_inner_name): Update.
4885         * parse.c (write_dollar_variable, copy_name): Return std::string.
4886         * parser-defs.h (copy_name): Change return type.
4887         * m2-exp.y: Update rules.
4888         (yylex): Update.
4889         * go-exp.y (lex_one_token): Update.
4890         Update rules.
4891         (classify_unsafe_function, classify_packaged_name)
4892         (classify_name, yylex): Update.
4893
4894 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4895
4896         * configure.ac: add --enable-source-highlight switch.
4897         * configure: Regenerate.
4898         * top.c (print_gdb_version): plumb --enable-source-highlight
4899         status to "show configuration".
4900
4901 2019-04-19  Tom Tromey  <tromey@adacore.com>
4902
4903         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4904         Check ADA_TYPE_P.
4905         (empty_record, ada_template_to_fixed_record_type_1)
4906         (template_to_static_fixed_type)
4907         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4908         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4909         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4910         macros.
4911
4912 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4913
4914         PR symtab/24423:
4915         * source.c (print_source_lines_base): Advance "iter" when a
4916         control character is seen.
4917
4918 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4919
4920         * inferior.h (struct infcall_suspend_state_deleter):
4921         Catch exception in destructor to avoid crash.
4922
4923 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4924
4925         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4926         close to the add_com "shell".
4927
4928 2019-04-18  Tom Tromey  <tromey@adacore.com>
4929
4930         * process-stratum-target.h (class process_stratum_target)
4931         <stratum>: Add "final".
4932
4933 2019-04-17  Tom Tromey  <tromey@adacore.com>
4934
4935         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4936         against nullptr before use.
4937
4938 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4939
4940         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4941
4942 2019-04-17  Jim Wilson  <jimw@sifive.com>
4943             Andrew Burgess  <andrew.burgess@embecosm.com>
4944
4945         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4946         code read might fail, assume 4-byte breakpoint in that case.
4947
4948 2019-04-15  Leszek Swirski  <leszeks@google.com>
4949
4950         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4951         rather than a hand-rolled POD check when checking for forced MEMORY
4952         classification.
4953
4954 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4955
4956         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4957         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4958         function.
4959         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4960         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4961         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4962         declaration.
4963
4964 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4965
4966         * aarch64-linux-nat.c
4967         (aarch64_linux_nat_target::thread_architecture): Add override.
4968         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4969         each VQ.
4970
4971 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4972
4973         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4974
4975 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4976
4977         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4978         target types of size 96-bits, add some additional comments, and
4979         check that the builtin type we found was the correct size.
4980
4981 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4982
4983         * utils.c (prompt_for_continue): Don't restore the styling at the
4984         end, as applied_style has the wrong value.  This fixes styling in
4985         long lists of file names that are interrupted by the "Continue?"
4986         prompt.
4987
4988 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4991         * c-lang.c (c_language_defn): Likewise.
4992         (cplus_language_defn): Likewise.
4993         (asm_language_defn): Likewise.
4994         (minimal_language_defn): Likewise.
4995         * d-lang.c (d_language_defn): Likewise.
4996         * f-lang.c (f_language_defn): Likewise.
4997         * go-lang.c (go_language_defn): Likewise.
4998         * language.c (unknown_language_defn): Likewise.
4999         (auto_language_defn): Likewise.
5000         * language.h (struct language_defn): Remove la_magic field.
5001         (LANG_MAGIC): Delete.
5002         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5003         * objc-lang.c (objc_language_defn): Likewise.
5004         * opencl-lang.c (opencl_language_defn): Likewise.
5005         * p-lang.c (pascal_language_defn): Likewise.
5006         * rust-lang.c (rust_language_defn): Likewise.
5007
5008 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5009
5010         * riscv-tdep.c (riscv_type_align): New function.
5011         (riscv_type_alignment): Delete.
5012         (riscv_arg_location): Use 'type_align'.
5013         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5014
5015 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5016
5017         * gdbtypes.c (type_align): A struct with no non-static fields also
5018         has alignment of 1.
5019
5020 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5021
5022         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5023         component to 0.
5024         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5025         member.
5026         (riscv_struct_info::analyse): New implementation using new
5027         analyse_inner member function.
5028         (riscv_struct_info::field_offset): New member function.
5029         (riscv_struct_info::m_offsets): New member variable.
5030         (riscv_struct_info::analyse_inner): New private member function,
5031         takes the old implementation of riscv_struct_info::analyse but
5032         extended to track field offsets.
5033         (riscv_call_arg_struct): Update the struct folding special cases
5034         to handle cases where empty C++ structs, which are non-zero
5035         length, are found.
5036         (riscv_arg_location): Initialise the length of each location, a
5037         non-zero length now indicates the location is in use.
5038         (riscv_push_dummy_call): Allow for the first location having a
5039         non-zero offset when setting up arguments.
5040         (riscv_return_value): Likewise, but for return values.
5041
5042 2019-04-11  Tom Tromey  <tromey@adacore.com>
5043
5044         * utils.c (internal_vproblem): Make "msg" const.
5045
5046 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5047
5048         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5049         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5050         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5051         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5052
5053 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5054
5055         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5056         function.
5057         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5058         of amd64_collect_native_gregset.
5059         (amd64_linux_nat_target::store_registers): Likewise.
5060
5061 2019-04-10  Tom Tromey  <tom@tromey.com>
5062
5063         * symtab.c (lookup_global_symbol_from_objfile)
5064         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5065         * objfiles.h (class separate_debug_iterator): New.
5066         (class separate_debug_range): New.
5067         (struct objfile) <separate_debug_objfiles>: New method.
5068         (objfile_separate_debug_iterate): Don't declare.
5069         * objfiles.c (separate_debug_iterator::operator++): Rename from
5070         objfile_separate_debug_iterate.
5071         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5072         iterator.
5073         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5074         iterator.
5075
5076 2019-04-10  Tom Tromey  <tom@tromey.com>
5077
5078         * symfile.c (reread_symbols): Remove old comment.
5079         * objfiles.c (free_all_objfiles): Fix a typo.
5080
5081 2019-04-10  Tom Tromey  <tom@tromey.com>
5082
5083         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5084         * minsyms.c (lookup_minimal_symbol): Use foreach.
5085         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5086         (lookup_minimal_symbol_solib_trampoline): Likewise.
5087         * symfile.c (reread_symbols): Use foreach.
5088
5089 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5090             Tom Tromey  <tromey@adacore.com>
5091
5092         PR rust/24414:
5093         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5094         (rust_lex_int_test): Change "value" to be LONGEST.
5095         (rust_lex_tests): Add test for long integer literal.
5096
5097 2019-04-09  Tom Tromey  <tromey@adacore.com>
5098
5099         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5100         to bool.
5101         (extended_remote_target::attach): Update.
5102         (remote_target::remote_notice_new_inferior): Update.
5103         (remote_target::add_current_inferior_and_thread): Update.
5104         * inferior.c (exit_inferior_1): Use "false".
5105         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5106
5107 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5108
5109         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5110         the "start" command.
5111
5112 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5113
5114         * python/py-inferior.c (infpy_thread_from_thread_handle):
5115         Adjust comments to reflect renaming of thread_from_thread_handle
5116         to thread_from_handle.  Adjust keywords.  Fix type error message.
5117         (inferior_object_methods): Add thread_from_handle.  Retain
5118         thread_from_thread_handle, but mark it as deprecated.
5119
5120 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5121
5122         * gdbthread.h (find_thread_by_handle): Revise declaration.
5123         * thread.c (find_thread_by_handle): Likewise.  Adjust
5124         implementation too.
5125         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5126         support for buffer objects as handles.
5127
5128 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5129
5130         * python/py-infthread.c (thpy_thread_handle): New function.
5131         (thread_object_methods): Register thpy_thread_handle.
5132
5133 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5134
5135         * gdbthread.h (thread_to_thread_handle): Declare.
5136         * thread.c (gdbtypes.h): Include.
5137         (thread_to_thread_handle): New function.
5138
5139         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5140         (target_thread_info_to_thread_handle): Declare.
5141         * target.c (target_thread_info_to_thread_handle): New function.
5142         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5143         * target-delegates.c: Regenerate.
5144
5145         * linux-thread-db.c (class thread_db_target): Add method
5146         thread_info_to_thread_handle.
5147         (thread_db_target::thread_info_to_thread_handle): Define.
5148         * remote.c (class remote_target): Add new method
5149         thread_info_to_thread_handle.
5150         (remote_target::thread_info_to_thread_handle): Define.
5151
5152 2019-04-08  Pedro Alves  <palves@redhat.com>
5153
5154         * common/common-exceptions.c (throw_exception): Don't create
5155         named object to throw; throw directly.
5156         (throw_it): Likewise.  Don't initialize gdb_exception::message
5157         here, with new; pass FMT and AP to the ctor instead.
5158         * common/common-exceptions.h: Include <string>.
5159         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5160         const char *, va_list)): New ctor.  Use std::make_shared.
5161         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5162         errors)): Delete.
5163         (gdb_exception_error::gdb_exception_error(enum errors, const char
5164         *, va_list)): New.
5165         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5166         Add assertion.
5167         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5168         errors)): Delete.
5169         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5170         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5171         Add assertion.
5172
5173 2019-04-08  Tom Tromey  <tom@tromey.com>
5174
5175         * valops.c (value_rtti_indirect_type): Replace throw_exception
5176         with throw.
5177         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5178         with throw.
5179         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5180         throw.
5181         * target.c (target_translate_tls_address): Replace throw_exception
5182         with throw.
5183         * stack.c (frame_apply_command_count): Replace throw_exception
5184         with throw.
5185         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5186         throw.
5187         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5188         with throw.
5189         * rs6000-tdep.c (rs6000_frame_cache)
5190         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5191         * remote.c: Replace throw_exception with throw.
5192         * record-full.c (record_full_message, record_full_wait_1)
5193         (record_full_restore): Replace throw_exception with throw.
5194         * record-btrace.c:
5195         (get_thread_current_frame_id, record_btrace_start_replaying)
5196         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5197         (cmd_record_btrace_start): Replace throw_exception with throw.
5198         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5199         throw.
5200         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5201         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5202         * linespec.c:
5203         (find_linespec_symbols): Replace throw_exception with throw.
5204         * infrun.c (displaced_step_prepare, resume): Replace
5205         throw_exception with throw.
5206         * infcmd.c (post_create_inferior): Replace throw_exception with
5207         throw.
5208         * inf-loop.c (inferior_event_handler): Replace throw_exception
5209         with throw.
5210         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5211         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5212         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5213         (get_prev_frame_always, get_frame_pc_if_available)
5214         (get_frame_address_in_block_if_available, get_frame_language):
5215         Replace throw_exception with throw.
5216         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5217         throw_exception with throw.
5218         * eval.c (fetch_subexp_value, evaluate_var_value)
5219         (evaluate_funcall, evaluate_subexp_standard): Replace
5220         throw_exception with throw.
5221         * dwarf2loc.c (call_site_find_chain)
5222         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5223         Replace throw_exception with throw.
5224         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5225         with throw.
5226         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5227         throw.
5228         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5229         * completer.c (complete_line_internal): Replace throw_exception
5230         with throw.
5231         * compile/compile-object-run.c (compile_object_run): Replace
5232         throw_exception with throw.
5233         * cli/cli-script.c (process_next_line): Replace throw_exception
5234         with throw.
5235         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5236         (btrace_enable, btrace_maint_update_pt_packets): Replace
5237         throw_exception with throw.
5238         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5239         throw_exception with throw.
5240         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5241         throw_exception with throw.
5242         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5243         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5244         * aarch64-tdep.c (aarch64_make_prologue_cache)
5245         (aarch64_make_stub_cache): Replace throw_exception with throw.
5246
5247 2019-04-08  Tom Tromey  <tom@tromey.com>
5248
5249         * common/common-exceptions.c (throw_exception): Rename from
5250         throw_exception_cxx.  Remove old copy.  Make argument const.
5251         (throw_it): Create and throw exception objects directly.
5252         * common/common-exceptions.h (throw_exception): Make argument
5253         const.
5254         (struct gdb_exception_error): Add constructor.
5255         (struct gdb_exception_quit): Add constructor.
5256
5257 2019-04-08  Tom Tromey  <tom@tromey.com>
5258
5259         * common/common-exceptions.h (exception_rethrow): Don't declare.
5260         (TRY_SJLJ): Update comment.
5261         (TRY, CATCH, END_CATCH): Remove.
5262         * common/common-exceptions.c (exception_rethrow): Remove.
5263
5264 2019-04-08  Tom Tromey  <tom@tromey.com>
5265
5266         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5267         Remove.
5268         (gdb_exception_error): Rename from
5269         gdb_exception_RETURN_MASK_ERROR.
5270         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5271         (gdb_quit_bad_alloc): Update.
5272         * aarch64-tdep.c: Update.
5273         * ada-lang.c: Update.
5274         * ada-typeprint.c: Update.
5275         * ada-valprint.c: Update.
5276         * amd64-tdep.c: Update.
5277         * arch-utils.c: Update.
5278         * break-catch-throw.c: Update.
5279         * breakpoint.c: Update.
5280         * btrace.c: Update.
5281         * c-varobj.c: Update.
5282         * cli/cli-cmds.c: Update.
5283         * cli/cli-interp.c: Update.
5284         * cli/cli-script.c: Update.
5285         * common/common-exceptions.c: Update.
5286         * common/new-op.c: Update.
5287         * common/selftest.c: Update.
5288         * compile/compile-c-symbols.c: Update.
5289         * compile/compile-cplus-symbols.c: Update.
5290         * compile/compile-object-load.c: Update.
5291         * compile/compile-object-run.c: Update.
5292         * completer.c: Update.
5293         * corelow.c: Update.
5294         * cp-abi.c: Update.
5295         * cp-support.c: Update.
5296         * cp-valprint.c: Update.
5297         * darwin-nat.c: Update.
5298         * disasm-selftests.c: Update.
5299         * dtrace-probe.c: Update.
5300         * dwarf-index-cache.c: Update.
5301         * dwarf-index-write.c: Update.
5302         * dwarf2-frame-tailcall.c: Update.
5303         * dwarf2-frame.c: Update.
5304         * dwarf2loc.c: Update.
5305         * dwarf2read.c: Update.
5306         * eval.c: Update.
5307         * event-loop.c: Update.
5308         * event-top.c: Update.
5309         * exec.c: Update.
5310         * f-valprint.c: Update.
5311         * fbsd-tdep.c: Update.
5312         * frame-unwind.c: Update.
5313         * frame.c: Update.
5314         * gdbtypes.c: Update.
5315         * gnu-v3-abi.c: Update.
5316         * guile/guile-internal.h: Update.
5317         * guile/scm-block.c: Update.
5318         * guile/scm-breakpoint.c: Update.
5319         * guile/scm-cmd.c: Update.
5320         * guile/scm-disasm.c: Update.
5321         * guile/scm-frame.c: Update.
5322         * guile/scm-lazy-string.c: Update.
5323         * guile/scm-math.c: Update.
5324         * guile/scm-param.c: Update.
5325         * guile/scm-ports.c: Update.
5326         * guile/scm-pretty-print.c: Update.
5327         * guile/scm-symbol.c: Update.
5328         * guile/scm-symtab.c: Update.
5329         * guile/scm-type.c: Update.
5330         * guile/scm-value.c: Update.
5331         * i386-linux-tdep.c: Update.
5332         * i386-tdep.c: Update.
5333         * inf-loop.c: Update.
5334         * infcall.c: Update.
5335         * infcmd.c: Update.
5336         * infrun.c: Update.
5337         * jit.c: Update.
5338         * language.c: Update.
5339         * linespec.c: Update.
5340         * linux-fork.c: Update.
5341         * linux-nat.c: Update.
5342         * linux-tdep.c: Update.
5343         * linux-thread-db.c: Update.
5344         * main.c: Update.
5345         * mi/mi-cmd-break.c: Update.
5346         * mi/mi-cmd-stack.c: Update.
5347         * mi/mi-interp.c: Update.
5348         * mi/mi-main.c: Update.
5349         * objc-lang.c: Update.
5350         * p-valprint.c: Update.
5351         * parse.c: Update.
5352         * ppc-linux-tdep.c: Update.
5353         * printcmd.c: Update.
5354         * python/py-arch.c: Update.
5355         * python/py-breakpoint.c: Update.
5356         * python/py-cmd.c: Update.
5357         * python/py-finishbreakpoint.c: Update.
5358         * python/py-frame.c: Update.
5359         * python/py-framefilter.c: Update.
5360         * python/py-gdb-readline.c: Update.
5361         * python/py-inferior.c: Update.
5362         * python/py-infthread.c: Update.
5363         * python/py-lazy-string.c: Update.
5364         * python/py-linetable.c: Update.
5365         * python/py-objfile.c: Update.
5366         * python/py-param.c: Update.
5367         * python/py-prettyprint.c: Update.
5368         * python/py-progspace.c: Update.
5369         * python/py-record-btrace.c: Update.
5370         * python/py-record.c: Update.
5371         * python/py-symbol.c: Update.
5372         * python/py-type.c: Update.
5373         * python/py-unwind.c: Update.
5374         * python/py-utils.c: Update.
5375         * python/py-value.c: Update.
5376         * python/python.c: Update.
5377         * record-btrace.c: Update.
5378         * record-full.c: Update.
5379         * remote-fileio.c: Update.
5380         * remote.c: Update.
5381         * riscv-tdep.c: Update.
5382         * rs6000-aix-tdep.c: Update.
5383         * rs6000-tdep.c: Update.
5384         * rust-exp.y: Update.
5385         * rust-lang.c: Update.
5386         * s390-tdep.c: Update.
5387         * selftest-arch.c: Update.
5388         * solib-dsbt.c: Update.
5389         * solib-frv.c: Update.
5390         * solib-spu.c: Update.
5391         * solib-svr4.c: Update.
5392         * solib.c: Update.
5393         * sparc64-linux-tdep.c: Update.
5394         * stack.c: Update.
5395         * symfile-mem.c: Update.
5396         * symmisc.c: Update.
5397         * target.c: Update.
5398         * thread.c: Update.
5399         * top.c: Update.
5400         * tracefile-tfile.c: Update.
5401         * tui/tui.c: Update.
5402         * typeprint.c: Update.
5403         * unittests/cli-utils-selftests.c: Update.
5404         * unittests/parse-connection-spec-selftests.c: Update.
5405         * valops.c: Update.
5406         * valprint.c: Update.
5407         * value.c: Update.
5408         * varobj.c: Update.
5409         * windows-nat.c: Update.
5410         * x86-linux-nat.c: Update.
5411         * xml-support.c: Update.
5412
5413 2019-04-08  Tom Tromey  <tom@tromey.com>
5414
5415         * xml-support.c: Use C++ exception handling.
5416         * x86-linux-nat.c: Use C++ exception handling.
5417         * windows-nat.c: Use C++ exception handling.
5418         * varobj.c: Use C++ exception handling.
5419         * value.c: Use C++ exception handling.
5420         * valprint.c: Use C++ exception handling.
5421         * valops.c: Use C++ exception handling.
5422         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5423         handling.
5424         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5425         * typeprint.c: Use C++ exception handling.
5426         * tui/tui.c: Use C++ exception handling.
5427         * tracefile-tfile.c: Use C++ exception handling.
5428         * top.c: Use C++ exception handling.
5429         * thread.c: Use C++ exception handling.
5430         * target.c: Use C++ exception handling.
5431         * symmisc.c: Use C++ exception handling.
5432         * symfile-mem.c: Use C++ exception handling.
5433         * stack.c: Use C++ exception handling.
5434         * sparc64-linux-tdep.c: Use C++ exception handling.
5435         * solib.c: Use C++ exception handling.
5436         * solib-svr4.c: Use C++ exception handling.
5437         * solib-spu.c: Use C++ exception handling.
5438         * solib-frv.c: Use C++ exception handling.
5439         * solib-dsbt.c: Use C++ exception handling.
5440         * selftest-arch.c: Use C++ exception handling.
5441         * s390-tdep.c: Use C++ exception handling.
5442         * rust-lang.c: Use C++ exception handling.
5443         * rust-exp.y: Use C++ exception handling.
5444         * rs6000-tdep.c: Use C++ exception handling.
5445         * rs6000-aix-tdep.c: Use C++ exception handling.
5446         * riscv-tdep.c: Use C++ exception handling.
5447         * remote.c: Use C++ exception handling.
5448         * remote-fileio.c: Use C++ exception handling.
5449         * record-full.c: Use C++ exception handling.
5450         * record-btrace.c: Use C++ exception handling.
5451         * python/python.c: Use C++ exception handling.
5452         * python/py-value.c: Use C++ exception handling.
5453         * python/py-utils.c: Use C++ exception handling.
5454         * python/py-unwind.c: Use C++ exception handling.
5455         * python/py-type.c: Use C++ exception handling.
5456         * python/py-symbol.c: Use C++ exception handling.
5457         * python/py-record.c: Use C++ exception handling.
5458         * python/py-record-btrace.c: Use C++ exception handling.
5459         * python/py-progspace.c: Use C++ exception handling.
5460         * python/py-prettyprint.c: Use C++ exception handling.
5461         * python/py-param.c: Use C++ exception handling.
5462         * python/py-objfile.c: Use C++ exception handling.
5463         * python/py-linetable.c: Use C++ exception handling.
5464         * python/py-lazy-string.c: Use C++ exception handling.
5465         * python/py-infthread.c: Use C++ exception handling.
5466         * python/py-inferior.c: Use C++ exception handling.
5467         * python/py-gdb-readline.c: Use C++ exception handling.
5468         * python/py-framefilter.c: Use C++ exception handling.
5469         * python/py-frame.c: Use C++ exception handling.
5470         * python/py-finishbreakpoint.c: Use C++ exception handling.
5471         * python/py-cmd.c: Use C++ exception handling.
5472         * python/py-breakpoint.c: Use C++ exception handling.
5473         * python/py-arch.c: Use C++ exception handling.
5474         * printcmd.c: Use C++ exception handling.
5475         * ppc-linux-tdep.c: Use C++ exception handling.
5476         * parse.c: Use C++ exception handling.
5477         * p-valprint.c: Use C++ exception handling.
5478         * objc-lang.c: Use C++ exception handling.
5479         * mi/mi-main.c: Use C++ exception handling.
5480         * mi/mi-interp.c: Use C++ exception handling.
5481         * mi/mi-cmd-stack.c: Use C++ exception handling.
5482         * mi/mi-cmd-break.c: Use C++ exception handling.
5483         * main.c: Use C++ exception handling.
5484         * linux-thread-db.c: Use C++ exception handling.
5485         * linux-tdep.c: Use C++ exception handling.
5486         * linux-nat.c: Use C++ exception handling.
5487         * linux-fork.c: Use C++ exception handling.
5488         * linespec.c: Use C++ exception handling.
5489         * language.c: Use C++ exception handling.
5490         * jit.c: Use C++ exception handling.
5491         * infrun.c: Use C++ exception handling.
5492         * infcmd.c: Use C++ exception handling.
5493         * infcall.c: Use C++ exception handling.
5494         * inf-loop.c: Use C++ exception handling.
5495         * i386-tdep.c: Use C++ exception handling.
5496         * i386-linux-tdep.c: Use C++ exception handling.
5497         * guile/scm-value.c: Use C++ exception handling.
5498         * guile/scm-type.c: Use C++ exception handling.
5499         * guile/scm-symtab.c: Use C++ exception handling.
5500         * guile/scm-symbol.c: Use C++ exception handling.
5501         * guile/scm-pretty-print.c: Use C++ exception handling.
5502         * guile/scm-ports.c: Use C++ exception handling.
5503         * guile/scm-param.c: Use C++ exception handling.
5504         * guile/scm-math.c: Use C++ exception handling.
5505         * guile/scm-lazy-string.c: Use C++ exception handling.
5506         * guile/scm-frame.c: Use C++ exception handling.
5507         * guile/scm-disasm.c: Use C++ exception handling.
5508         * guile/scm-cmd.c: Use C++ exception handling.
5509         * guile/scm-breakpoint.c: Use C++ exception handling.
5510         * guile/scm-block.c: Use C++ exception handling.
5511         * guile/guile-internal.h: Use C++ exception handling.
5512         * gnu-v3-abi.c: Use C++ exception handling.
5513         * gdbtypes.c: Use C++ exception handling.
5514         * frame.c: Use C++ exception handling.
5515         * frame-unwind.c: Use C++ exception handling.
5516         * fbsd-tdep.c: Use C++ exception handling.
5517         * f-valprint.c: Use C++ exception handling.
5518         * exec.c: Use C++ exception handling.
5519         * event-top.c: Use C++ exception handling.
5520         * event-loop.c: Use C++ exception handling.
5521         * eval.c: Use C++ exception handling.
5522         * dwarf2read.c: Use C++ exception handling.
5523         * dwarf2loc.c: Use C++ exception handling.
5524         * dwarf2-frame.c: Use C++ exception handling.
5525         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5526         * dwarf-index-write.c: Use C++ exception handling.
5527         * dwarf-index-cache.c: Use C++ exception handling.
5528         * dtrace-probe.c: Use C++ exception handling.
5529         * disasm-selftests.c: Use C++ exception handling.
5530         * darwin-nat.c: Use C++ exception handling.
5531         * cp-valprint.c: Use C++ exception handling.
5532         * cp-support.c: Use C++ exception handling.
5533         * cp-abi.c: Use C++ exception handling.
5534         * corelow.c: Use C++ exception handling.
5535         * completer.c: Use C++ exception handling.
5536         * compile/compile-object-run.c: Use C++ exception handling.
5537         * compile/compile-object-load.c: Use C++ exception handling.
5538         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5539         * compile/compile-c-symbols.c: Use C++ exception handling.
5540         * common/selftest.c: Use C++ exception handling.
5541         * common/new-op.c: Use C++ exception handling.
5542         * cli/cli-script.c: Use C++ exception handling.
5543         * cli/cli-interp.c: Use C++ exception handling.
5544         * cli/cli-cmds.c: Use C++ exception handling.
5545         * c-varobj.c: Use C++ exception handling.
5546         * btrace.c: Use C++ exception handling.
5547         * breakpoint.c: Use C++ exception handling.
5548         * break-catch-throw.c: Use C++ exception handling.
5549         * arch-utils.c: Use C++ exception handling.
5550         * amd64-tdep.c: Use C++ exception handling.
5551         * ada-valprint.c: Use C++ exception handling.
5552         * ada-typeprint.c: Use C++ exception handling.
5553         * ada-lang.c: Use C++ exception handling.
5554         * aarch64-tdep.c: Use C++ exception handling.
5555
5556 2019-04-08  Tom Tromey  <tom@tromey.com>
5557
5558         * xml-support.c (gdb_xml_parser::parse): Update.
5559         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5560         * value.c (show_convenience): Update.
5561         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5562         (test_parse_flags_qcs): Update.
5563         * thread.c (thr_try_catch_cmd): Update.
5564         * target.c (target_translate_tls_address): Update.
5565         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5566         (info_frame_command_core, frame_apply_command_count): Update.
5567         * rust-exp.y (rust_lex_exception_test): Update.
5568         * riscv-tdep.c (riscv_print_one_register_info): Update.
5569         * remote.c (remote_target::enable_btrace): Update.
5570         * record-btrace.c (record_btrace_enable_warn): Update.
5571         * python/py-utils.c (gdbpy_convert_exception): Update.
5572         * printcmd.c (do_one_display, print_variable_and_value): Update.
5573         * mi/mi-main.c (mi_print_exception): Update.
5574         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5575         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5576         * linux-nat.c (linux_nat_target::attach): Update.
5577         * linux-fork.c (class scoped_switch_fork_info): Update.
5578         * infrun.c (displaced_step_prepare): Update.
5579         * infcall.c (call_function_by_hand_dummy): Update.
5580         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5581         * gnu-v3-abi.c (print_one_vtable): Update.
5582         * frame.c (get_prev_frame_always): Update.
5583         * f-valprint.c (info_common_command_for_block): Update.
5584         * exec.c (try_open_exec_file): Update.
5585         * exceptions.c (print_exception, exception_print)
5586         (exception_fprintf, exception_print_same): Update.
5587         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5588         * dwarf-index-cache.c (index_cache::store)
5589         (index_cache::lookup_gdb_index): Update.
5590         * darwin-nat.c (maybe_cache_shell): Update.
5591         * cp-valprint.c (cp_print_value_fields): Update.
5592         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5593         (gcc_cplus_symbol_address): Update.
5594         * compile/compile-c-symbols.c (gcc_convert_symbol)
5595         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5596         * common/selftest.c: Update.
5597         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5598         a std::string.
5599         (exception_try_scope_entry, exception_try_scope_exit): Don't
5600         declare.
5601         (struct exception_try_scope): Remove.
5602         (TRY): Don't use exception_try_scope.
5603         (struct gdb_exception): Add constructor, operator=.
5604         <what>: New method.
5605         (struct gdb_exception_RETURN_MASK_ALL)
5606         (struct gdb_exception_RETURN_MASK_ERROR)
5607         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5608         (struct gdb_quit_bad_alloc): Update.
5609         * common/common-exceptions.c (exception_none): Change
5610         initializer.
5611         (struct catcher) <state, exception>: Initialize inline.
5612         <prev>: Remove member.
5613         (current_catcher): Remove.
5614         (catchers): New global.
5615         (exceptions_state_mc_init): Simplify.
5616         (catcher_pop): Remove.
5617         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5618         (try_scope_depth, exception_try_scope_entry)
5619         (exception_try_scope_exit): Remove.
5620         (throw_exception_sjlj): Update.
5621         (exception_messages, exception_messages_size): Remove.
5622         (throw_it): Simplify.
5623         (gdb_exception_sliced_copy): Remove.
5624         (throw_exception_cxx): Update.
5625         * cli/cli-script.c (script_from_file): Update.
5626         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5627         Update.
5628         * ada-valprint.c (ada_val_print): Update.
5629         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5630         (create_excep_cond_exprs): Update.
5631
5632 2019-04-08  Tom Tromey  <tom@tromey.com>
5633
5634         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5635         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5636         (TRY, CATCH, END_CATCH): Remove some definitions.
5637         * common/common-exceptions.c: Don't use GDB_XCPT.
5638         (catcher_list_size): Remove.
5639         (throw_exception, throw_it): Simplify.
5640
5641 2019-04-05  Tom Tromey  <tom@tromey.com>
5642
5643         Revert the header-sorting patch.
5644         * ft32-tdep.c: Revert.
5645         * frv-tdep.c: Revert.
5646         * frv-linux-tdep.c: Revert.
5647         * frame.c: Revert.
5648         * frame-unwind.c: Revert.
5649         * frame-base.c: Revert.
5650         * fork-child.c: Revert.
5651         * findvar.c: Revert.
5652         * findcmd.c: Revert.
5653         * filesystem.c: Revert.
5654         * filename-seen-cache.h: Revert.
5655         * filename-seen-cache.c: Revert.
5656         * fbsd-tdep.c: Revert.
5657         * fbsd-nat.h: Revert.
5658         * fbsd-nat.c: Revert.
5659         * f-valprint.c: Revert.
5660         * f-typeprint.c: Revert.
5661         * f-lang.c: Revert.
5662         * extension.h: Revert.
5663         * extension.c: Revert.
5664         * extension-priv.h: Revert.
5665         * expprint.c: Revert.
5666         * exec.h: Revert.
5667         * exec.c: Revert.
5668         * exceptions.c: Revert.
5669         * event-top.c: Revert.
5670         * event-loop.c: Revert.
5671         * eval.c: Revert.
5672         * elfread.c: Revert.
5673         * dwarf2read.h: Revert.
5674         * dwarf2read.c: Revert.
5675         * dwarf2loc.c: Revert.
5676         * dwarf2expr.h: Revert.
5677         * dwarf2expr.c: Revert.
5678         * dwarf2-frame.c: Revert.
5679         * dwarf2-frame-tailcall.c: Revert.
5680         * dwarf-index-write.h: Revert.
5681         * dwarf-index-write.c: Revert.
5682         * dwarf-index-common.c: Revert.
5683         * dwarf-index-cache.h: Revert.
5684         * dwarf-index-cache.c: Revert.
5685         * dummy-frame.c: Revert.
5686         * dtrace-probe.c: Revert.
5687         * disasm.h: Revert.
5688         * disasm.c: Revert.
5689         * disasm-selftests.c: Revert.
5690         * dictionary.c: Revert.
5691         * dicos-tdep.c: Revert.
5692         * demangle.c: Revert.
5693         * dcache.h: Revert.
5694         * dcache.c: Revert.
5695         * darwin-nat.h: Revert.
5696         * darwin-nat.c: Revert.
5697         * darwin-nat-info.c: Revert.
5698         * d-valprint.c: Revert.
5699         * d-namespace.c: Revert.
5700         * d-lang.c: Revert.
5701         * ctf.c: Revert.
5702         * csky-tdep.c: Revert.
5703         * csky-linux-tdep.c: Revert.
5704         * cris-tdep.c: Revert.
5705         * cris-linux-tdep.c: Revert.
5706         * cp-valprint.c: Revert.
5707         * cp-support.c: Revert.
5708         * cp-namespace.c: Revert.
5709         * cp-abi.c: Revert.
5710         * corelow.c: Revert.
5711         * corefile.c: Revert.
5712         * continuations.c: Revert.
5713         * completer.h: Revert.
5714         * completer.c: Revert.
5715         * complaints.c: Revert.
5716         * coffread.c: Revert.
5717         * coff-pe-read.c: Revert.
5718         * cli-out.h: Revert.
5719         * cli-out.c: Revert.
5720         * charset.c: Revert.
5721         * c-varobj.c: Revert.
5722         * c-valprint.c: Revert.
5723         * c-typeprint.c: Revert.
5724         * c-lang.c: Revert.
5725         * buildsym.c: Revert.
5726         * buildsym-legacy.c: Revert.
5727         * build-id.h: Revert.
5728         * build-id.c: Revert.
5729         * btrace.c: Revert.
5730         * bsd-uthread.c: Revert.
5731         * breakpoint.h: Revert.
5732         * breakpoint.c: Revert.
5733         * break-catch-throw.c: Revert.
5734         * break-catch-syscall.c: Revert.
5735         * break-catch-sig.c: Revert.
5736         * blockframe.c: Revert.
5737         * block.c: Revert.
5738         * bfin-tdep.c: Revert.
5739         * bfin-linux-tdep.c: Revert.
5740         * bfd-target.c: Revert.
5741         * bcache.c: Revert.
5742         * ax-general.c: Revert.
5743         * ax-gdb.h: Revert.
5744         * ax-gdb.c: Revert.
5745         * avr-tdep.c: Revert.
5746         * auxv.c: Revert.
5747         * auto-load.c: Revert.
5748         * arm-wince-tdep.c: Revert.
5749         * arm-tdep.c: Revert.
5750         * arm-symbian-tdep.c: Revert.
5751         * arm-pikeos-tdep.c: Revert.
5752         * arm-obsd-tdep.c: Revert.
5753         * arm-nbsd-tdep.c: Revert.
5754         * arm-nbsd-nat.c: Revert.
5755         * arm-linux-tdep.c: Revert.
5756         * arm-linux-nat.c: Revert.
5757         * arm-fbsd-tdep.c: Revert.
5758         * arm-fbsd-nat.c: Revert.
5759         * arm-bsd-tdep.c: Revert.
5760         * arch-utils.c: Revert.
5761         * arc-tdep.c: Revert.
5762         * arc-newlib-tdep.c: Revert.
5763         * annotate.h: Revert.
5764         * annotate.c: Revert.
5765         * amd64-windows-tdep.c: Revert.
5766         * amd64-windows-nat.c: Revert.
5767         * amd64-tdep.c: Revert.
5768         * amd64-sol2-tdep.c: Revert.
5769         * amd64-obsd-tdep.c: Revert.
5770         * amd64-obsd-nat.c: Revert.
5771         * amd64-nbsd-tdep.c: Revert.
5772         * amd64-nbsd-nat.c: Revert.
5773         * amd64-nat.c: Revert.
5774         * amd64-linux-tdep.c: Revert.
5775         * amd64-linux-nat.c: Revert.
5776         * amd64-fbsd-tdep.c: Revert.
5777         * amd64-fbsd-nat.c: Revert.
5778         * amd64-dicos-tdep.c: Revert.
5779         * amd64-darwin-tdep.c: Revert.
5780         * amd64-bsd-nat.c: Revert.
5781         * alpha-tdep.c: Revert.
5782         * alpha-obsd-tdep.c: Revert.
5783         * alpha-nbsd-tdep.c: Revert.
5784         * alpha-mdebug-tdep.c: Revert.
5785         * alpha-linux-tdep.c: Revert.
5786         * alpha-linux-nat.c: Revert.
5787         * alpha-bsd-tdep.c: Revert.
5788         * alpha-bsd-nat.c: Revert.
5789         * aix-thread.c: Revert.
5790         * agent.c: Revert.
5791         * addrmap.c: Revert.
5792         * ada-varobj.c: Revert.
5793         * ada-valprint.c: Revert.
5794         * ada-typeprint.c: Revert.
5795         * ada-tasks.c: Revert.
5796         * ada-lang.c: Revert.
5797         * aarch64-tdep.c: Revert.
5798         * aarch64-ravenscar-thread.c: Revert.
5799         * aarch64-newlib-tdep.c: Revert.
5800         * aarch64-linux-tdep.c: Revert.
5801         * aarch64-linux-nat.c: Revert.
5802         * aarch64-fbsd-tdep.c: Revert.
5803         * aarch64-fbsd-nat.c: Revert.
5804         * aarch32-linux-nat.c: Revert.
5805
5806 2019-04-05  Tom Tromey  <tom@tromey.com>
5807
5808         * ft32-tdep.c: Sort headers.
5809         * frv-tdep.c: Sort headers.
5810         * frv-linux-tdep.c: Sort headers.
5811         * frame.c: Sort headers.
5812         * frame-unwind.c: Sort headers.
5813         * frame-base.c: Sort headers.
5814         * fork-child.c: Sort headers.
5815         * findvar.c: Sort headers.
5816         * findcmd.c: Sort headers.
5817         * filesystem.c: Sort headers.
5818         * filename-seen-cache.h: Sort headers.
5819         * filename-seen-cache.c: Sort headers.
5820         * fbsd-tdep.c: Sort headers.
5821         * fbsd-nat.h: Sort headers.
5822         * fbsd-nat.c: Sort headers.
5823         * f-valprint.c: Sort headers.
5824         * f-typeprint.c: Sort headers.
5825         * f-lang.c: Sort headers.
5826         * extension.h: Sort headers.
5827         * extension.c: Sort headers.
5828         * extension-priv.h: Sort headers.
5829         * expprint.c: Sort headers.
5830         * exec.h: Sort headers.
5831         * exec.c: Sort headers.
5832         * exceptions.c: Sort headers.
5833         * event-top.c: Sort headers.
5834         * event-loop.c: Sort headers.
5835         * eval.c: Sort headers.
5836         * elfread.c: Sort headers.
5837         * dwarf2read.h: Sort headers.
5838         * dwarf2read.c: Sort headers.
5839         * dwarf2loc.c: Sort headers.
5840         * dwarf2expr.h: Sort headers.
5841         * dwarf2expr.c: Sort headers.
5842         * dwarf2-frame.c: Sort headers.
5843         * dwarf2-frame-tailcall.c: Sort headers.
5844         * dwarf-index-write.h: Sort headers.
5845         * dwarf-index-write.c: Sort headers.
5846         * dwarf-index-common.c: Sort headers.
5847         * dwarf-index-cache.h: Sort headers.
5848         * dwarf-index-cache.c: Sort headers.
5849         * dummy-frame.c: Sort headers.
5850         * dtrace-probe.c: Sort headers.
5851         * disasm.h: Sort headers.
5852         * disasm.c: Sort headers.
5853         * disasm-selftests.c: Sort headers.
5854         * dictionary.c: Sort headers.
5855         * dicos-tdep.c: Sort headers.
5856         * demangle.c: Sort headers.
5857         * dcache.h: Sort headers.
5858         * dcache.c: Sort headers.
5859         * darwin-nat.h: Sort headers.
5860         * darwin-nat.c: Sort headers.
5861         * darwin-nat-info.c: Sort headers.
5862         * d-valprint.c: Sort headers.
5863         * d-namespace.c: Sort headers.
5864         * d-lang.c: Sort headers.
5865         * ctf.c: Sort headers.
5866         * csky-tdep.c: Sort headers.
5867         * csky-linux-tdep.c: Sort headers.
5868         * cris-tdep.c: Sort headers.
5869         * cris-linux-tdep.c: Sort headers.
5870         * cp-valprint.c: Sort headers.
5871         * cp-support.c: Sort headers.
5872         * cp-namespace.c: Sort headers.
5873         * cp-abi.c: Sort headers.
5874         * corelow.c: Sort headers.
5875         * corefile.c: Sort headers.
5876         * continuations.c: Sort headers.
5877         * completer.h: Sort headers.
5878         * completer.c: Sort headers.
5879         * complaints.c: Sort headers.
5880         * coffread.c: Sort headers.
5881         * coff-pe-read.c: Sort headers.
5882         * cli-out.h: Sort headers.
5883         * cli-out.c: Sort headers.
5884         * charset.c: Sort headers.
5885         * c-varobj.c: Sort headers.
5886         * c-valprint.c: Sort headers.
5887         * c-typeprint.c: Sort headers.
5888         * c-lang.c: Sort headers.
5889         * buildsym.c: Sort headers.
5890         * buildsym-legacy.c: Sort headers.
5891         * build-id.h: Sort headers.
5892         * build-id.c: Sort headers.
5893         * btrace.c: Sort headers.
5894         * bsd-uthread.c: Sort headers.
5895         * breakpoint.h: Sort headers.
5896         * breakpoint.c: Sort headers.
5897         * break-catch-throw.c: Sort headers.
5898         * break-catch-syscall.c: Sort headers.
5899         * break-catch-sig.c: Sort headers.
5900         * blockframe.c: Sort headers.
5901         * block.c: Sort headers.
5902         * bfin-tdep.c: Sort headers.
5903         * bfin-linux-tdep.c: Sort headers.
5904         * bfd-target.c: Sort headers.
5905         * bcache.c: Sort headers.
5906         * ax-general.c: Sort headers.
5907         * ax-gdb.h: Sort headers.
5908         * ax-gdb.c: Sort headers.
5909         * avr-tdep.c: Sort headers.
5910         * auxv.c: Sort headers.
5911         * auto-load.c: Sort headers.
5912         * arm-wince-tdep.c: Sort headers.
5913         * arm-tdep.c: Sort headers.
5914         * arm-symbian-tdep.c: Sort headers.
5915         * arm-pikeos-tdep.c: Sort headers.
5916         * arm-obsd-tdep.c: Sort headers.
5917         * arm-nbsd-tdep.c: Sort headers.
5918         * arm-nbsd-nat.c: Sort headers.
5919         * arm-linux-tdep.c: Sort headers.
5920         * arm-linux-nat.c: Sort headers.
5921         * arm-fbsd-tdep.c: Sort headers.
5922         * arm-fbsd-nat.c: Sort headers.
5923         * arm-bsd-tdep.c: Sort headers.
5924         * arch-utils.c: Sort headers.
5925         * arc-tdep.c: Sort headers.
5926         * arc-newlib-tdep.c: Sort headers.
5927         * annotate.h: Sort headers.
5928         * annotate.c: Sort headers.
5929         * amd64-windows-tdep.c: Sort headers.
5930         * amd64-windows-nat.c: Sort headers.
5931         * amd64-tdep.c: Sort headers.
5932         * amd64-sol2-tdep.c: Sort headers.
5933         * amd64-obsd-tdep.c: Sort headers.
5934         * amd64-obsd-nat.c: Sort headers.
5935         * amd64-nbsd-tdep.c: Sort headers.
5936         * amd64-nbsd-nat.c: Sort headers.
5937         * amd64-nat.c: Sort headers.
5938         * amd64-linux-tdep.c: Sort headers.
5939         * amd64-linux-nat.c: Sort headers.
5940         * amd64-fbsd-tdep.c: Sort headers.
5941         * amd64-fbsd-nat.c: Sort headers.
5942         * amd64-dicos-tdep.c: Sort headers.
5943         * amd64-darwin-tdep.c: Sort headers.
5944         * amd64-bsd-nat.c: Sort headers.
5945         * alpha-tdep.c: Sort headers.
5946         * alpha-obsd-tdep.c: Sort headers.
5947         * alpha-nbsd-tdep.c: Sort headers.
5948         * alpha-mdebug-tdep.c: Sort headers.
5949         * alpha-linux-tdep.c: Sort headers.
5950         * alpha-linux-nat.c: Sort headers.
5951         * alpha-bsd-tdep.c: Sort headers.
5952         * alpha-bsd-nat.c: Sort headers.
5953         * aix-thread.c: Sort headers.
5954         * agent.c: Sort headers.
5955         * addrmap.c: Sort headers.
5956         * ada-varobj.c: Sort headers.
5957         * ada-valprint.c: Sort headers.
5958         * ada-typeprint.c: Sort headers.
5959         * ada-tasks.c: Sort headers.
5960         * ada-lang.c: Sort headers.
5961         * aarch64-tdep.c: Sort headers.
5962         * aarch64-ravenscar-thread.c: Sort headers.
5963         * aarch64-newlib-tdep.c: Sort headers.
5964         * aarch64-linux-tdep.c: Sort headers.
5965         * aarch64-linux-nat.c: Sort headers.
5966         * aarch64-fbsd-tdep.c: Sort headers.
5967         * aarch64-fbsd-nat.c: Sort headers.
5968         * aarch32-linux-nat.c: Sort headers.
5969
5970 2019-04-04  Tom Tromey  <tom@tromey.com>
5971
5972         * varobj.c (varobj_create): Update.
5973         * rust-exp.y (struct rust_parser) <update_innermost_block,
5974         lookup_symbol>: New methods.
5975         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5976         Rename.
5977         (rust_parser::rust_lookup_type)
5978         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5979         * printcmd.c (display_command, do_one_display): Update.
5980         * parser-defs.h (struct parser_state) <parser_state>: Add
5981         "tracker" parameter.
5982         (block_tracker): New member.
5983         (class innermost_block_tracker) <innermost_block_tracker>: Add
5984         "types" parameter.
5985         <reset>: Remove method.
5986         (innermost_block): Don't declare.
5987         (null_post_parser): Update.
5988         * parse.c (innermost_block): Remove global.
5989         (write_dollar_variable): Update.
5990         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5991         Remove "tracker_types" parameter.
5992         (parse_expression): Add "tracker" parameter.
5993         (parse_expression_for_completion): Update.
5994         (null_post_parser): Add "tracker" parameter.
5995         * p-exp.y: Update rules.
5996         * m2-exp.y: Update rules.
5997         * language.h (struct language_defn) <la_post_parser>: Add
5998         "tracker" parameter.
5999         * go-exp.y: Update rules.
6000         * f-exp.y: Update rules.
6001         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6002         parameter.
6003         * d-exp.y: Update rules.
6004         * c-exp.y: Update rules.
6005         * breakpoint.c (set_breakpoint_condition): Create an
6006         innermost_block_tracker.
6007         (watch_command_1): Likewise.
6008         * ada-lang.c (resolve): Add "tracker" parameter.
6009         (resolve_subexp): Likewise.
6010         * ada-exp.y (write_var_from_sym): Update.
6011
6012 2019-04-04  Tom Tromey  <tom@tromey.com>
6013
6014         * type-stack.h: New file.
6015         * type-stack.c: New file.
6016         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6017         type-stack.h.
6018         (insert_into_type_stack, insert_type, push_type, push_type_int)
6019         (insert_type_address_space, pop_type, pop_type_int)
6020         (pop_typelist, pop_type_stack, append_type_stack)
6021         (push_type_stack, get_type_stack, push_typelist)
6022         (follow_type_instance_flags, follow_types): Don't declare.
6023         * parse.c (type_stack): Remove global.
6024         (parse_exp_in_context): Update.
6025         (insert_into_type_stack, insert_type, push_type, push_type_int)
6026         (insert_type_address_space, pop_type, pop_type_int)
6027         (pop_typelist, pop_type_stack, append_type_stack)
6028         (push_type_stack, get_type_stack, push_typelist)
6029         (follow_type_instance_flags, follow_types): Remove (moved to
6030         type-stack.c).
6031         * f-exp.y (type_stack): New global.
6032         Update rules.
6033         (push_kind_type, f_parse): Update.
6034         * d-exp.y (type_stack): New global.
6035         Update rules.
6036         (d_parse): Update.
6037         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6038         Update rules.
6039         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6040         (HFILES_NO_SRCDIR): Add type-stack.h.
6041
6042 2019-04-04  Tom Tromey  <tom@tromey.com>
6043
6044         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6045         (rust_parser::convert_ast_to_expression, rust_parse)
6046         (rust_lex_test_completion, rust_lex_tests): Update.
6047         * parser-defs.h (struct expr_completion_state): New.
6048         (struct parser_state) <parser_state>: Add completion parameter.
6049         <mark_struct_expression, mark_completion_tag>: New methods.
6050         <parse_completion, m_completion_state>: New members.
6051         (prefixify_expression, null_post_parser): Update.
6052         (mark_struct_expression, mark_completion_tag): Don't declare.
6053         * parse.c (parse_completion, expout_last_struct)
6054         (expout_tag_completion_type, expout_completion_name): Remove
6055         globals.
6056         (parser_state::mark_struct_expression)
6057         (parser_state::mark_completion_tag): Now methods.
6058         (prefixify_expression): Add last_struct parameter.
6059         (prefixify_subexp): Likewise.
6060         (parse_exp_1): Update.
6061         (parse_exp_in_context): Add cstate parameter.  Update.
6062         (parse_expression_for_completion): Create an
6063         expr_completion_state.
6064         (null_post_parser): Add "completion" parameter.
6065         * p-exp.y: Update rules.
6066         (yylex): Update.
6067         * language.h (struct language_defn) <la_post_parser>: Add
6068         "completing" parameter.
6069         * go-exp.y: Update rules.
6070         (lex_one_token): Update.
6071         * expression.h (parse_completion): Don't declare.
6072         * d-exp.y: Update rules.
6073         (lex_one_token): Update rules.
6074         * c-exp.y: Update rules.
6075         (lex_one_token): Update.
6076         * ada-lang.c (resolve): Add "parse_completion" parameter.
6077         (resolve_subexp): Likewise.
6078         (ada_resolve_function): Likewise.
6079
6080 2019-04-04  Tom Tromey  <tom@tromey.com>
6081
6082         * parser-defs.h (struct parser_state) <start_arglist,
6083         end_arglist>: New methods.
6084         <arglist_len, m_funcall_chain>: New members.
6085         (arglist_len, start_arglist, end_arglist): Don't declare.
6086         * parse.c (arglist_len, funcall_chain): Remove global.
6087         (start_arglist, end_arglist): Remove functions.
6088         (parse_exp_in_context): Update.
6089         * p-exp.y: Update rules.
6090         * m2-exp.y: Update rules.
6091         * go-exp.y: Update rules.
6092         * f-exp.y: Update rules.
6093         * d-exp.y: Update rules.
6094         * c-exp.y: Update rules.
6095
6096 2019-04-04  Tom Tromey  <tom@tromey.com>
6097
6098         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6099         lex_operator, push_back>: New methods.
6100         Update all rules.
6101         (rust_parser::lex_hex, lex_escape): Rename and update.
6102         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6103         (rust_parser::lex_operator): Rename and update.
6104         (rust_parser::lex_number, rustyylex, rustyyerror)
6105         (rust_lex_test_init, rust_lex_test_sequence)
6106         (rust_lex_test_push_back, rust_lex_tests): Update.
6107         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6108         parameter.
6109         <lexptr, prev_lexptr>: New members.
6110         (lexptr, prev_lexptr): Don't declare.
6111         * parse.c (lexptr, prev_lexptr): Remove globals.
6112         (parse_exp_in_context): Update.
6113         * p-exp.y (yylex, yyerror): Update.
6114         * m2-exp.y (parse_number, yylex, yyerror): Update.
6115         * go-exp.y (lex_one_token, yyerror): Update.
6116         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6117         * d-exp.y (lex_one_token, yyerror): Update.
6118         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6119         (lex_one_token, yyerror): Update.
6120         * ada-lex.l (YY_INPUT): Update.
6121         (rewind_to_char): Update.
6122         * ada-exp.y (yyerror): Update.
6123
6124 2019-04-04  Tom Tromey  <tom@tromey.com>
6125
6126         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6127         * parser-defs.h (struct parser_state) <parser_state>: Add new
6128         parameter.
6129         <comma_terminates>: New member.
6130         (comma_terminates): Don't declare global.
6131         * parse.c (comma_terminates): Remove global.
6132         (parse_exp_in_context): Update.
6133         * p-exp.y (yylex): Update.
6134         * m2-exp.y (yylex): Update.
6135         * go-exp.y (lex_one_token): Update.
6136         * f-exp.y (yylex): Update.
6137         * d-exp.y (lex_one_token): Update.
6138         * c-exp.y (lex_one_token): Update.
6139         * ada-lex.l: Update.
6140
6141 2019-04-04  Tom Tromey  <tom@tromey.com>
6142
6143         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6144         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6145         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6146         * parser-defs.h (paren_depth): Don't declare.
6147         * parse.c (paren_depth): Remove global.
6148         (parse_exp_in_context): Update.
6149         * p-exp.y (paren_depth): New global.
6150         (pascal_parse): Initialize it.
6151         * m2-exp.y (paren_depth): New global.
6152         (m2_parse): Initialize it.
6153         * go-exp.y (paren_depth): New global.
6154         (go_parse): Initialize it.
6155         * f-exp.y (paren_depth): New global.
6156         (f_parse): Initialize it.
6157         * d-exp.y (paren_depth): New global.
6158         (d_parse): Initialize it.
6159         * c-exp.y (paren_depth): New global.
6160         (c_parse): Initialize it.
6161         * ada-lex.l (paren_depth): New global.
6162         (lexer_init): Initialize it.
6163
6164 2019-04-04  Tom Tromey  <tom@tromey.com>
6165
6166         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6167         (rust_parser::convert_ast_to_type)
6168         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6169         * parser-defs.h (struct parser_state) <parser_state>: Add
6170         parameters.  Initialize new members.
6171         <expression_context_block, expression_context_pc>: New members.
6172         * parse.c (expression_context_block, expression_context_pc):
6173         Remove globals.
6174         (parse_exp_in_context): Update.
6175         * p-exp.y: Update all rules.
6176         (yylex): Update.
6177         * m2-exp.y: Update all rules.
6178         (yylex): Update.
6179         * go-exp.y (yylex): Update.
6180         * f-exp.y (yylex): Update.
6181         * d-exp.y: Update all rules.
6182         (yylex): Update.
6183         * c-exp.y: Update all rules.
6184         (lex_one_token, classify_name, yylex, c_parse): Update.
6185         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6186
6187 2019-04-04  Tom Tromey  <tom@tromey.com>
6188
6189         * gdbarch.h, gdbarch.c: Rebuild.
6190         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6191         * stap-probe.h:
6192         (struct stap_parse_info): Replace "parser_state" with
6193         "expr_builder".
6194         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6195         (parser_state): New class.
6196         * parse.c (expr_builder): Rename.
6197         (expr_builder::release): Rename.
6198         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6199         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6200         (write_exp_elt_longcst, write_exp_elt_floatcst)
6201         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6202         (write_exp_string_vector, write_exp_bitstring)
6203         (write_exp_msymbol, mark_struct_expression)
6204         (write_dollar_variable)
6205         (insert_type_address_space, increase_expout_size): Replace
6206         "parser_state" with "expr_builder".
6207         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6208         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6209         "parser_state" with "expr_builder".
6210
6211 2019-04-04  Tom Tromey  <tom@tromey.com>
6212
6213         * rust-exp.y: Replace "parse_language" with method call.
6214         * p-exp.y:
6215         (yylex): Replace "parse_language" with method call.
6216         * m2-exp.y:
6217         (yylex): Replace "parse_language" with method call.
6218         * go-exp.y (classify_name): Replace "parse_language" with method
6219         call.
6220         * f-exp.y (yylex): Replace "parse_language" with method call.
6221         * d-exp.y (lex_one_token): Replace "parse_language" with method
6222         call.
6223         * c-exp.y:
6224         (lex_one_token, classify_name, yylex): Replace "parse_language"
6225         with method call.
6226         * ada-exp.y (find_primitive_type, type_char)
6227         (type_system_address): Replace "parse_language" with method call.
6228
6229 2019-04-04  Tom Tromey  <tom@tromey.com>
6230
6231         * rust-exp.y: Replace "parse_gdbarch" with method call.
6232         * parse.c (write_dollar_variable, insert_type_address_space):
6233         Replace "parse_gdbarch" with method call.
6234         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6235         call.
6236         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6237         call.
6238         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6239         "parse_gdbarch" with method call.
6240         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6241         with method call.
6242         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6243         "parse_gdbarch" with method call.
6244         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6245         "parse_gdbarch" with method call.
6246         * c-exp.y (parse_type, parse_number, classify_name): Replace
6247         "parse_gdbarch" with method call.
6248         * ada-lex.l: Replace "parse_gdbarch" with method call.
6249         * ada-exp.y (parse_type, find_primitive_type, type_char)
6250         (type_system_address): Replace "parse_gdbarch" with method call.
6251
6252 2019-04-04  Tom Tromey  <tom@tromey.com>
6253
6254         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6255         * stap-probe.c (stap_parse_argument): Update.
6256         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6257         initial_size parameter.
6258         * rust-exp.y (rust_lex_tests): Update.
6259         * parse.c (parser_state): Update.
6260         (parse_exp_in_context): Update.
6261         * parser-defs.h (struct parser_state) <parser_state>: Remove
6262         "initial_size" parameter.
6263
6264 2019-04-04  Tom Tromey  <tom@tromey.com>
6265
6266         * parser-defs.h (increase_expout_size): Don't declare.
6267         * parse.c (increase_expout_size): Now static.
6268
6269 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6270
6271         * gnu-nat.c (gnu_nat_target::wait): Fix
6272         target_waitstatus_to_string call.
6273
6274 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6275
6276         * eval.c (evaluate_subexp_standard): Handle internal functions
6277         during Fortran function call handling.
6278
6279 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6280
6281         * NEWS: Mention new internal functions.
6282         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6283         (read_base_type): Use dwarf2_init_complex_target_type.
6284         * value.c (creal_internal_fn): New function.
6285         (cimag_internal_fn): New function.
6286         (_initialize_values): Register new internal functions.
6287
6288 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6289
6290         * infrun.c (stop_all_threads): If debug_infrun, always
6291         trace the wait status after wait_one, using
6292         target_waitstatus_to_string and target_pid_to_str.
6293         (handle_inferior_event): Replace various trace of
6294         wait status kind by a single trace.
6295         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6296         wait status kind image by target_waitstatus_to_string.
6297         * target/waitstatus.c (target_waitstatus_to_string): Fix
6298         obsolete comment.
6299
6300 2019-04-01  Tom Tromey  <tromey@adacore.com>
6301
6302         PR symtab/23331:
6303         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6304
6305 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6306             Pedro Alves  <palves@redhat.com>
6307
6308         * top.c (quit_force): Call 'finalize_values'.
6309         * value.c (finalize_values): New function.
6310         * value.h (finalize_values): Declare.
6311
6312 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6313
6314         * NEWS: Announce $_gdb_major and $_gdb_minor.
6315
6316         * top.c (init_gdb_version_vars): New function.
6317         (gdb_init): Call init_gdb_version_vars.
6318
6319 2019-03-29  Tom Tromey  <tromey@adacore.com>
6320
6321         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6322         help text.  Remove dead code.
6323
6324 2019-03-29  Keith Seitz  <keiths@redhat.com>
6325
6326         From Siddhesh Poyarekar:
6327         * f-lang.h (f77_get_upperbound): Return LONGEST.
6328         (f77_get_lowerbound): Likewise.
6329         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6330         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6331         print them.
6332         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6333         plongest to format print it.
6334         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6335         (f77_get_upperbound): Likewise.
6336         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6337         LOWER_BOUND to LONGEST.
6338         (f77_create_arrayprint_offset_tbl): Likewise.
6339
6340 2019-03-29  Keith Seitz  <keiths@redhat.com>
6341
6342         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6343         %s/pulongest for TYPE_LENGTH instead of %d in format
6344         strings.
6345         * ada-typerint.c (ada_print_type): Likewise.
6346         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6347         * compile/compile-c-support.c (generate_register_struct): Likewise.
6348         * gdbtypes.c (recursive_dump_type): Likewise.
6349         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6350         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6351         instead of %d in format strings.
6352         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6353         to std::min to ULONGEST.
6354         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6355         instead of %d in format strings.
6356         * tracepoint.c (info_scope_command): Likewise.
6357         * typeprint.c (print_offset_data::update)
6358         (print_offset_data::finish): Likewise.
6359         * xtensa-tdep.c (xtensa_store_return_value)
6360         (xtensa_push_dummy_call): Likewise.
6361
6362 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6363
6364         * windows-nat.c (display_selector): Fixed format specifications
6365         for 64-bit Cygwin.
6366
6367 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6368
6369         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6370
6371 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6372
6373         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6374         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6375         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6376         (nios2_linux_init_abi): Install it.
6377
6378 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6379
6380         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6381
6382 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6383
6384         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6385
6386 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6387             Tom Tromey  <tromey@adacore.com>
6388
6389         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6390
6391 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6392
6393         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6394         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6395         method to compute the bounds of range types. Also print "[evaluated]"
6396         if the bounds' values come from a dynamic evaluation.
6397
6398 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6399
6400         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6401         whitespace when pretty printing is on.
6402
6403 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6404
6405         * ppc-linux-nat.c: Add include.
6406
6407 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6408
6409         * NEWS: Mention AArch64 Pointer Authentication.
6410
6411 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6412
6413         * arm-linux-nat.c: Add include.
6414
6415 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6416
6417         * source-cache.c (source_cache::get_source_lines): Re-read
6418         fullname after calling open_source_file.
6419
6420 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6421
6422         * NEWS: Mention TLS support for FreeBSD.
6423
6424 2019-03-25  Tom Tromey  <tromey@adacore.com>
6425
6426         * minsyms.c (BUNCH_SIZE): Update comment.
6427         (~minimal_symbol_reader): Remove old comment.
6428         (compact_minimal_symbols): Update comment.
6429         (minimal_symbol_reader::install): Remove old comment.  Update
6430         other comments.
6431
6432 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6433
6434         * s390-linux-nat.c: Add include.
6435
6436 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6437
6438         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6439         Call linux_get_hwcap.
6440         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6441         Likewise.
6442         (aarch64_linux_get_hwcap): Remove function.
6443         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6444         declaration.
6445         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6446         linux_get_hwcap.
6447         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6448         * linux-tdep.c (linux_get_hwcap): Add function.
6449         (linux_get_hwcap2): Likewise.
6450         * linux-tdep.h (linux_get_hwcap): Add declaration.
6451         (linux_get_hwcap2): Likewise.
6452         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6453         (ppc_linux_get_hwcap2): Likewise.
6454         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6455         linux_get_hwcap.
6456         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6457         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6458         (ppc_linux_nat_target::read_description): Likewise.
6459         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6460         * s390-linux-nat.c: Likewise.
6461         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6462
6463 2019-03-24  Tom Tromey  <tom@tromey.com>
6464
6465         * ada-lang.c (standard_lookup): Simplify initialization.
6466         (ada_lookup_symbol_nonlocal): Simplify return.
6467         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6468         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6469         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6470         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6471         initialization.
6472         * solib.c (solib_global_lookup): Simplify.
6473         * symtab.c (null_block_symbol): Remove.
6474         (symbol_cache_lookup): Simplify returns.
6475         (lookup_language_this): Simplify returns.
6476         (lookup_symbol_aux): Simplify return.
6477         (lookup_local_symbol): Simplify returns.
6478         (lookup_global_symbol_from_objfile): Simplify return.
6479         (lookup_symbol_in_objfile_symtabs)
6480         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6481         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6482         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6483         * cp-namespace.c (cp_lookup_bare_symbol)
6484         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6485         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6486         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6487         (cp_lookup_symbol_via_imports): Simplify initialization.
6488         (find_symbol_in_baseclass): Likewise.
6489         * symtab.h (null_block_symbol): Remove.
6490         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6491         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6492         (d_lookup_symbol_module): Likewise.
6493         (find_symbol_in_baseclass): Simplify initialization.
6494
6495 2019-03-24  Tom Tromey  <tom@tromey.com>
6496
6497         * expression.h: Don't include symtab.h.
6498         (struct block): Forward declare.
6499
6500 2019-03-24  Tom Tromey  <tom@tromey.com>
6501
6502         * c-exp.y (typebase): Remove casts.
6503         * gdbtypes.c (lookup_unsigned_typename, )
6504         (lookup_signed_typename): Remove cast.
6505         * eval.c (parse_to_comma_and_eval): Remove cast.
6506         * parse.c (write_dollar_variable): Remove cast.
6507         * block.h (struct block) <superblock>: Now const.
6508         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6509         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6510         (map_block): Make "block" const.
6511         * symfile.h (struct quick_symbol_functions)
6512         <map_matching_symbols>: Constify block argument to "callback".
6513         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6514         const.
6515         (find_pc_sect_compunit_symtab): Make "b" const.
6516         (find_symbol_at_address): Likewise.
6517         (search_symbols): Likewise.
6518         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6519         (dw2_debug_names_lookup_symbol): Likewise.
6520         (dw2_map_matching_symbols): Update.
6521         * p-valprint.c (pascal_val_print): Remove "block".
6522         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6523         (aux_add_nonlocal_symbols): Make "block" const.
6524         (resolve_subexp): Remove cast.
6525         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6526         const.
6527         (iterate_over_file_blocks): Likewise.
6528         * f-exp.y (%union) <bval>: Remove.
6529         * coffread.c (patch_opaque_types): Make "b" const.
6530         * spu-tdep.c (spu_catch_start): Make "block" const.
6531         * c-valprint.c (print_unpacked_pointer): Remove "block".
6532         * symmisc.c (dump_symtab_1): Make "b" const.
6533         (block_depth): Make "block" const.
6534         * d-exp.y (%union) <bval>: Remove.
6535         * cp-support.h (cp_lookup_rtti_type): Update.
6536         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6537         * psymtab.c (psym_lookup_symbol): Make "block" const.
6538         (maintenance_check_psymtabs): Make "b" const.
6539         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6540         (enumerate_locals, enumerate_args): Update.
6541         * python/py-symtab.c (stpy_global_block): Make "block" const.
6542         (stpy_static_block): Likewise.
6543         * inline-frame.c (block_starting_point_at): Make "new_block"
6544         const.
6545         * block.c (find_block_in_blockvector): Make return type const.
6546         (blockvector_for_pc_sect): Make "b" const.
6547         (find_block_in_blockvector): Make "b" const.
6548
6549 2019-03-23  Tom Tromey  <tom@tromey.com>
6550
6551         * varobj.c (varobj_create): Update.
6552         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6553         * printcmd.c (display_command, do_one_display): Don't reset
6554         innermost_block.
6555         * parser-defs.h (enum innermost_block_tracker_type): Move to
6556         expression.h.
6557         (innermost_block): Update comment.
6558         * parse.c (parse_exp_1): Add tracker_types parameter.
6559         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6560         tracker_types parameter.  Reset innermost_block.
6561         (parse_exp_in_context): Remove.
6562         (parse_expression_for_completion): Update.
6563         * objfiles.c (~objfile): Don't reset expression_context_block or
6564         innermost_block.
6565         * expression.h (enum innermost_block_tracker_type): Move from
6566         parser-defs.h.
6567         (parse_exp_1): Add tracker_types parameter.
6568         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6569         reset innermost_block.
6570
6571 2019-03-23  Tom Tromey  <tom@tromey.com>
6572
6573         * objfiles.h: Include bcache.h.
6574
6575 2019-03-23  Tom Tromey  <tom@tromey.com>
6576
6577         * linespec.c (get_current_search_block): Use
6578         scoped_restore_current_language.
6579         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6580
6581 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6582             Jiong Wang  <jiong.wang@arm.com>
6583
6584         * aarch64-linux-tdep.c
6585         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6586         section.
6587         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6588
6589 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6590             Jiong Wang  <jiong.wang@arm.com>
6591
6592         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6593         instructions.
6594         (aarch64_analyze_prologue_test): Add PACIASP test.
6595         (aarch64_prologue_prev_register): Unmask PC value.
6596
6597 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6598             Jiong Wang  <jiong.wang@arm.com>
6599
6600         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6601         (aarch64_dwarf2_prev_register): Unmask PC value.
6602         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6603         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6604         DW_CFA_AARCH64_negate_ra_state.
6605         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6606
6607 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6608             Jiong Wang  <jiong.wang@arm.com>
6609
6610         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6611         registers.
6612         (aarch64_pseudo_register_name): Likewise.
6613         (aarch64_pseudo_register_type): Likewise.
6614         (aarch64_pseudo_register_reggroup_p): Likewise.
6615         (aarch64_gdbarch_init): Add pauth registers.
6616         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6617         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6618         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6619         (struct gdbarch_tdep): Add regnum for ra_state.
6620
6621 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6622             Jiong Wang  <jiong.wang@arm.com>
6623
6624         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6625
6626 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6627             Jiong Wang  <jiong.wang@arm.com>
6628
6629         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6630         function.
6631         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6632         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6633         (aarch64_gdbarch_init): Add puth registers.
6634         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6635         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6636         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6637
6638 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6639             Jiong Wang  <jiong.wang@arm.com>
6640
6641         * aarch64-linux-nat.c
6642         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6643         * aarch64-linux-tdep.c
6644         (aarch64_linux_core_read_description): Likewise.
6645         (aarch64_linux_get_hwcap): New function.
6646         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6647         (aarch64_linux_get_hwcap): New declaration.
6648
6649 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6650             Jiong Wang  <jiong.wang@arm.com>
6651
6652         * aarch64-linux-nat.c
6653         (aarch64_linux_nat_target::read_description): Add pauth param.
6654         * aarch64-linux-tdep.c
6655         (aarch64_linux_core_read_description): Likewise.
6656         * aarch64-tdep.c (struct target_desc): Add in pauth.
6657         (aarch64_read_description): Add pauth param.
6658         (aarch64_gdbarch_init): Likewise.
6659         * aarch64-tdep.h (aarch64_read_description): Likewise.
6660         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6661         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6662         * features/Makefile: Add new files.
6663         * features/aarch64-pauth.c: New file.
6664         * features/aarch64-pauth.xml: New file.
6665
6666 2019-03-20  Tom Tromey  <tromey@adacore.com>
6667
6668         * infrun.c (handle_inferior_event): Rename from
6669         handle_inferior_event_1.  Create a scoped_value_mark.
6670         (handle_inferior_event): Remove.
6671
6672 2019-03-19  Tom Tromey  <tromey@adacore.com>
6673
6674         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6675         * infrun.h (print_stop_event): Add "displays" parameter.
6676         * infrun.c (print_stop_event): Add "displays" parameter.
6677
6678 2019-03-19  Pedro Alves  <palves@redhat.com>
6679
6680         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6681         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6682         to -1.  Fix TABs vs spaces.
6683         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6684         * tui/tui-out.h (tui_ui_out) Add intro comments.
6685         <m_line, m_start_of_line>: In-class initialize, and add describing
6686         comment.
6687
6688 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6689
6690         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6691         variable names.
6692         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6693
6694 2019-03-18  Pedro Alves  <palves@redhat.com>
6695             Eli Zaretskii <eliz@gnu.org>
6696
6697         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6698         m_line and m_start_of_line.
6699
6700 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6701
6702         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6703         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6704         it returns a newline.  This fixes a regression in TU mode, whereby
6705         the next line is output on the same screen line as the user input.
6706
6707 2019-03-18  Tom Tromey  <tromey@adacore.com>
6708
6709         * minsyms.c (minimal_symbol_reader::install): Remove call to
6710         obstack_blank.
6711
6712 2019-03-18  Pedro Alves  <palves@redhat.com>
6713
6714         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6715         New globals.
6716         (apply_style): New, factored out from ...
6717         (apply_ansi_escape): ... this.  Handle reverse video mode.
6718         (tui_set_reverse_mode): New function.
6719         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6720         * tui/tui-winsource.c (tui_show_source_line): Use
6721         tui_set_reverse_mode instead of setting A_STANDOUT.
6722         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6723         New setter methods.
6724
6725 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6726
6727         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6728         Handle tabs.
6729
6730 2019-03-18  Tom Tromey  <tromey@adacore.com>
6731
6732         * ada-lang.c (empty_array): Add "high" parameter.
6733         (ada_evaluate_subexp): Update.
6734
6735 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6736
6737         * unittests/string_view-selftests.c: Define
6738         _initialize_string_view_selftests unconditionally.
6739
6740 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6741
6742         PR gdb/24350
6743         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6744
6745 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6746
6747         PR gdb/24351
6748         * windows-nat.c (display_selector): Fix format specifiers.
6749
6750 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6751
6752         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6753         tui_refill_source_window instead of tui_refresh_win, to update the
6754         current execution line.  This fixes redisplay of the current line
6755         when stepping through the code with "next" or "step".
6756
6757 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6758
6759         * source-cache.c (source_cache::get_source_lines): Call
6760         find_source_lines to initialize s->nlines.  This fixes vertical
6761         scrolling of TUI source window when the DOWN arrow is pressed.
6762
6763 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6764
6765         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6766         linux-thread-db.c (_initialize_thread_db): Likewise.
6767
6768 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6769
6770         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6771         wclrtoeol in tui_show_source_line".  This reverts changes made in
6772         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6773
6774 2019-03-15  Tom Tromey  <tom@tromey.com>
6775
6776         * symtab.h (struct minimal_symbol): Derive from
6777         general_symbol_info.
6778         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6779         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6780         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6781         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6782         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6783         (MSYMBOL_SEARCH_NAME): Update.
6784         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6785         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6786         * minsyms.c (minimal_symbol_reader::record_full): Update.
6787
6788 2019-03-15  Tom Tromey  <tom@tromey.com>
6789
6790         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6791
6792 2019-03-15  Tom Tromey  <tom@tromey.com>
6793
6794         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6795         unique_xmalloc_ptr.
6796         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6797         Update.
6798         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6799         (build_minimal_symbol_hash_tables)
6800         (minimal_symbol_reader::install): Update.
6801
6802 2019-03-15  Tom Tromey  <tom@tromey.com>
6803
6804         * symtab.c (create_demangled_names_hash): Update.
6805         (symbol_set_names): Update.
6806         * objfiles.h (struct objfile_per_bfd_storage)
6807         <demangled_names_hash>: Now an htab_up.
6808         * objfiles.c (objfile_per_bfd_storage): Simplify.
6809
6810 2019-03-15  Tom Tromey  <tom@tromey.com>
6811
6812         * objfiles.h (struct objfile_per_bfd_storage): Declare
6813         destructor.
6814         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6815         New.
6816         (get_objfile_bfd_data): Use new.  Don't initialize
6817         language_of_main.
6818         (free_objfile_per_bfd_storage): Remove.
6819         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6820
6821 2019-03-15  Tom Tromey  <tom@tromey.com>
6822
6823         * symfile.c (reread_symbols): Update.
6824         * objfiles.c (objfile::objfile): Update.
6825         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6826         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6827         comment.
6828         (minimal_symbol_reader::install): Update.
6829         (terminate_minimal_symbol_table): Remove.
6830         * jit.c (jit_object_close_impl): Update.
6831
6832 2019-03-15  Tom Tromey  <tom@tromey.com>
6833
6834         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6835         initializations.
6836
6837 2019-03-15  Tom Tromey  <tom@tromey.com>
6838
6839         * objfiles.h (struct objfile_per_bfd_storage)
6840         <demangled_hash_languages>: Now a bitset.
6841         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6842         (lookup_minimal_symbol): Update.
6843
6844 2019-03-15  Tom Tromey  <tom@tromey.com>
6845
6846         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6847         Don't return the symbol.
6848         * coffread.c (record_minimal_symbol): Use record_full.
6849
6850 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6851
6852         The MS-Windows port of ncurses fails to switch to a color pair if
6853         one or both of the colors are the implicit default colors.  This
6854         change records the default colors when TUI is initialized, and
6855         then specifies them explicitly when a color pair uses the default
6856         colors.  This allows color styling in TUI mode on MS-Windows.
6857
6858         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6859         ncurses_norm_attr.
6860         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6861         colors in ncurses_norm_attr.
6862         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6863         "none", replace it with the default color recorded in
6864         ncurses_norm_attr.
6865
6866 2019-03-14  Tom Tromey  <tromey@adacore.com>
6867
6868         * source-cache.h (class source_cache) <get_source_lines>: Return
6869         std::string.
6870         * source-cache.c (source_cache::extract_lines): Handle case where
6871         first_pos==npos.  Return std::string.
6872         (source_cache::get_source_lines): Update.
6873
6874 2019-03-14  Tom Tromey  <tromey@adacore.com>
6875
6876         * NEWS: Add item for "style sources" commands.
6877         * source-cache.c (source_cache::get_source_lines): Check
6878         source_styling.
6879         * cli/cli-style.c (source_styling): New global.
6880         (_initialize_cli_style): Add "style sources" commands.
6881         (show_style_sources): New function.
6882         * cli/cli-style.h (source_styling): Declare.
6883
6884 2019-03-14  Pedro Alves  <palves@redhat.com>
6885             Tom Tromey  <tromey@adacore.com>
6886
6887         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6888         * tui/tui-winsource.c (tui_refill_source_window): New function,
6889         from...
6890         (tui_horizontal_source_scroll): ... here.  Move some logic.
6891         * cli/cli-style.c (set_style_enabled): Notify new observable.
6892         * tui/tui-hooks.c (tui_redisplay_source): New function.
6893         (tui_attach_detach_observers): Attach or detach
6894         tui_redisplay_source.
6895         * observable.h (source_styling_changed): New observable.
6896         * observable.c: Define source_styling_changed observable.
6897
6898 2019-03-13  Tom Tromey  <tromey@adacore.com>
6899
6900         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6901         (i386_gnu_nat_target::store_registers): Update.
6902         * target-debug.h (target_debug_print_std_string): New macro.
6903         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6904         * windows-tdep.c (display_one_tib): Update.
6905         * tui/tui-stack.c (tui_make_status_line): Update.
6906         * top.c (print_inferior_quit_action): Update.
6907         * thread.c (thr_try_catch_cmd): Update.
6908         (add_thread_with_info): Update.
6909         (thread_target_id_str): Update.
6910         (thr_try_catch_cmd): Update.
6911         (thread_command): Update.
6912         (thread_find_command): Update.
6913         * record-btrace.c (record_btrace_target::info_record)
6914         (record_btrace_resume_thread, record_btrace_target::resume)
6915         (record_btrace_cancel_resume, record_btrace_step_thread)
6916         (record_btrace_target::wait, record_btrace_target::wait)
6917         (record_btrace_target::wait, record_btrace_target::stop): Update.
6918         * progspace.c (print_program_space): Update.
6919         * process-stratum-target.c
6920         (process_stratum_target::thread_address_space): Update.
6921         * linux-fork.c (linux_fork_mourn_inferior)
6922         (detach_checkpoint_command, info_checkpoints_command)
6923         (linux_fork_context): Update.
6924         (linux_fork_detach): Update.
6925         (class scoped_switch_fork_info): Update.
6926         (delete_checkpoint_command): Update.
6927         * infrun.c (follow_fork_inferior): Update.
6928         (follow_fork_inferior): Update.
6929         (proceed_after_vfork_done): Update.
6930         (handle_vfork_child_exec_or_exit): Update.
6931         (follow_exec): Update.
6932         (displaced_step_prepare_throw): Update.
6933         (displaced_step_restore): Update.
6934         (start_step_over): Update.
6935         (resume_1): Update.
6936         (clear_proceed_status_thread): Update.
6937         (proceed): Update.
6938         (print_target_wait_results): Update.
6939         (do_target_wait): Update.
6940         (context_switch): Update.
6941         (stop_all_threads): Update.
6942         (restart_threads): Update.
6943         (finish_step_over): Update.
6944         (handle_signal_stop): Update.
6945         (switch_back_to_stepped_thread): Update.
6946         (keep_going_pass_signal): Update.
6947         (print_exited_reason): Update.
6948         (normal_stop): Update.
6949         * inferior.c (inferior_pid_to_str): Change return type.
6950         (print_selected_inferior): Update.
6951         (add_inferior): Update.
6952         (detach_inferior): Update.
6953         * dummy-frame.c (fprint_dummy_frames): Update.
6954         * dcache.c (dcache_info_1): Update.
6955         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6956         (btrace_fetch, btrace_clear): Update.
6957         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6958         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6959         type.
6960         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6961         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6962         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6963         * gdbarch.c, gdbarch.h: Rebuild.
6964         * gdbarch.sh (core_pid_to_str): Change return type.
6965         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6966         return type.
6967         (windows_nat_target::pid_to_str): Change return type.
6968         (windows_delete_thread): Update.
6969         (windows_nat_target::attach): Update.
6970         (windows_nat_target::files_info): Update.
6971         * target-delegates.c: Rebuild.
6972         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6973         return type.
6974         (sol_thread_target::pid_to_str): Change return type.
6975         * remote.c (class remote_target) <pid_to_str>: Change return
6976         type.
6977         (remote_target::pid_to_str): Change return type.
6978         (extended_remote_target::attach, remote_target::remote_stop_ns)
6979         (remote_target::remote_notif_remove_queued_reply)
6980         (remote_target::push_stop_reply, remote_target::disable_btrace):
6981         Update.
6982         (extended_remote_target::attach): Update.
6983         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6984         type.
6985         (gdbsim_target::pid_to_str): Change return type.
6986         * ravenscar-thread.c (struct ravenscar_thread_target)
6987         <pid_to_str>: Change return type.
6988         (ravenscar_thread_target::pid_to_str): Change return type.
6989         * procfs.c (class procfs_target) <pid_to_str>: Change return
6990         type.
6991         (procfs_target::pid_to_str): Change return type.
6992         (procfs_target::attach): Update.
6993         (procfs_target::detach): Update.
6994         (procfs_target::fetch_registers): Update.
6995         (procfs_target::store_registers): Update.
6996         (procfs_target::wait): Update.
6997         (procfs_target::files_info): Update.
6998         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6999         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7000         return type.
7001         (nto_procfs_target::pid_to_str): Change return type.
7002         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7003         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7004         return type.
7005         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7006         (exit_lwp): Update.
7007         (attach_proc_task_lwp_callback, get_detach_signal)
7008         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7009         (linux_nat_target::resume, wait_lwp, stop_callback)
7010         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7011         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7012         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7013         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7014         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7015         type.
7016         (inf_ptrace_target::attach): Update.
7017         (inf_ptrace_target::files_info): Update.
7018         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7019         type.
7020         (go32_nat_target::pid_to_str): Change return type.
7021         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7022         (gnu_nat_target::wait): Update.
7023         (gnu_nat_target::wait): Update.
7024         (gnu_nat_target::resume): Update.
7025         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7026         (fbsd_nat_target::wait): Update.
7027         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7028         type.
7029         (darwin_nat_target::attach): Update.
7030         * corelow.c (class core_target) <pid_to_str>: Change return type.
7031         (core_target::pid_to_str): Change return type.
7032         * target.c (normal_pid_to_str): Change return type.
7033         (default_pid_to_str): Likewise.
7034         (target_pid_to_str): Change return type.
7035         (target_translate_tls_address): Update.
7036         (target_announce_detach): Update.
7037         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7038         return type.
7039         (bsd_uthread_target::pid_to_str): Change return type.
7040         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7041         type.
7042         (bsd_kvm_target::pid_to_str): Change return type.
7043         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7044         return type.
7045         (aix_thread_target::pid_to_str): Change return type.
7046         * target.h (struct target_ops) <pid_to_str>: Change return type.
7047         (target_pid_to_str, normal_pid_to_str): Likewise.
7048         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7049         type.
7050         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7051         type.
7052         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7053         return type.
7054         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7055         type.
7056         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7057         type.
7058         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7059         return type.
7060
7061 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7062
7063         * NEWS: Mention that the new default MI version is 3.  Mention
7064         changes to the output of commands and events that deal with
7065         multi-location breakpoints.
7066         * breakpoint.c: Include "mi/mi-out.h".
7067         (print_one_breakpoint): Change output syntax if using MI version
7068         >= 3.
7069         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7070         New.
7071         (mi_multi_location_breakpoint_output_fixed): New.
7072         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7073         (mi_cmd_fix_multi_location_breakpoint_output): New.
7074         (mi_multi_location_breakpoint_output_fixed): New.
7075         * mi/mi-cmds.c (mi_cmds): Register command
7076         -fix-multi-location-breakpoint-output.
7077         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7078         interpreter "mi".
7079
7080 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7081
7082         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7083         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7084         instantiate mi_ui_out based on interpreter name.
7085         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7086         * mi/mi-main.c (mi_load_progress): Likewise.
7087
7088 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7089
7090         * NEWS: Combine separate "New targets" sections for 8.3.
7091
7092 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7093
7094         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7095         (ppcfbsd_init_abi): Install gdbarch
7096         "fetch_tls_load_module_address" and "get_thread_local_address"
7097         methods.
7098
7099 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7100
7101         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7102         (riscv_fbsd_init_abi): Install gdbarch
7103         "fetch_tls_load_module_address" and "get_thread_local_address"
7104         methods.
7105
7106 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7107
7108         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7109         (i386fbsd_init_abi): Install gdbarch
7110         "fetch_tls_load_module_address" and "get_thread_local_address"
7111         methods.
7112
7113 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7114
7115         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7116         (amd64fbsd_init_abi): Install gdbarch
7117         "fetch_tls_load_module_address" and "get_thread_local_address"
7118         methods.
7119
7120 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7121
7122         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7123         (struct fbsd_pspace_data): New type.
7124         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7125         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7126         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7127         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7128         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7129
7130 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7131
7132         * gdbtypes.c (lookup_struct_elt): New function.
7133         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7134         * gdbtypes.h (struct struct_elt): New type.
7135         (lookup_struct_elt): New prototype.
7136
7137 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7138
7139         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7140         remove disabled code block.
7141
7142 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7143
7144         * gdbarch.sh (get_thread_local_address): New method.
7145         * gdbarch.h, gdbarch.c: Regenerate.
7146         * target.c (target_translate_tls_address): Use
7147         gdbarch_get_thread_local_address if present instead of
7148         target::get_thread_local_address.
7149
7150 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7151
7152         * target.h (target::get_thread_local_address): Update comment.
7153
7154 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7155
7156         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7157         objfile->separate_debug_objfile_backlink if not NULL.
7158
7159 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7160
7161         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7162         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7163         (amd64bsd_store_inferior_registers): Likewise.
7164         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7165         Enable segment base registers.
7166         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7167         PT_GETFSBASE and PT_GETGSBASE.
7168         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7169         PT_SETGSBASE.
7170         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7171         segment base registers.
7172         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7173
7174 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7175
7176         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7177         Update calls to i386_target_description to add 'segments'
7178         parameter.
7179         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7180         add segment base registers.
7181         * arch/i386.c (i386_create_target_description): Add 'segments'
7182         parameter to enable segment base registers.
7183         * arch/i386.h (i386_create_target_description): Likewise.
7184         * features/i386/32bit-segments.xml: New file.
7185         * features/i386/32bit-segments.c: Generate.
7186         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7187         call to i386_target_description to add 'segments' parameter.
7188         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7189         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7190         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7191         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7192         if feature is present.
7193         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7194         Add 'segments' parameter to call to i386_target_description.
7195         (i386_target_description): Add 'segments' parameter to enable
7196         segment base registers.
7197         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7198         to call to i386_target_description.
7199         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7200         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7201         Define I386_NUM_REGS.
7202         (i386_target_description): Add 'segments' parameter to enable
7203         segment base registers.
7204
7205 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7206
7207         PR/24325
7208         * source-cache.c: #undef open and close, to avoid unresolved
7209         externals during linking.
7210
7211 2019-03-12  Tom Tromey  <tromey@adacore.com>
7212
7213         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7214         const.  Add initializers.
7215         (_initialize_remote): Don't initialize ptid globals.
7216
7217 2019-03-12  Pedro Alves  <palves@redhat.com>
7218
7219         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7220
7221 2019-03-12  Pedro Alves  <palves@redhat.com>
7222
7223         * cp-name-parser.y (main): Remove unused 'len' variable.
7224
7225 2019-03-12  Tom Tromey  <tromey@adacore.com>
7226
7227         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7228         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7229
7230 2019-03-12  Tom Tromey  <tromey@adacore.com>
7231
7232         * linux-nat.c (iterate_over_lwps): Update.
7233         (stop_callback): Remove parameter.
7234         (stop_wait_callback, detach_callback, resume_set_callback)
7235         (select_singlestep_lwp_callback, set_ignore_sigint)
7236         (status_callback, resumed_callback, resume_clear_callback)
7237         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7238         data parameter.
7239         (linux_nat_target::detach, linux_nat_target::resume)
7240         (linux_stop_and_wait_all_lwps, select_event_lwp)
7241         (linux_nat_filter_event, linux_nat_wait_1)
7242         (linux_nat_target::kill, linux_nat_target::stop)
7243         (linux_nat_target::stop): Update.
7244         (linux_nat_resume_callback): Change type.
7245         (resume_stopped_resumed_lwps, count_events_callback)
7246         (select_event_lwp_callback): Likewise.
7247         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7248         * arm-linux-nat.c (struct update_registers_data): Remove.
7249         (update_registers_callback): Change type.
7250         (arm_linux_insert_hw_breakpoint1): Update.
7251         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7252         parameter.
7253         (x86_linux_dr_set_addr): Update.
7254         (x86_linux_dr_set_control): Update.
7255         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7256         (iterate_over_lwps): Use gdb::function_view.
7257         * nat/aarch64-linux-hw-point.c (struct
7258         aarch64_dr_update_callback_param): Remove.
7259         (debug_reg_change_callback): Change type.
7260         (aarch64_notify_debug_reg_change): Update.
7261         * s390-linux-nat.c (s390_refresh_per_info): Update.
7262
7263 2019-03-11  Tom Tromey  <tromey@adacore.com>
7264
7265         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7266         redundant assignment to "this_cu".
7267
7268 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7269
7270         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7271
7272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7273
7274         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7275         from...
7276         (rank_one_type): ... this.
7277
7278 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7279
7280         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7281         from...
7282         (rank_one_type): ... this.
7283
7284 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7285
7286         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7287         from...
7288         (rank_one_type): ... this.
7289
7290 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7291
7292         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7293         from...
7294         (rank_one_type): ... this.
7295
7296 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7297
7298         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7299         from...
7300         (rank_one_type): ... this.
7301
7302 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7303
7304         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7305         from...
7306         (rank_one_type): ... this.
7307
7308 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7309
7310         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7311         from...
7312         (rank_one_type): ... this.
7313
7314 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7315
7316         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7317         from...
7318         (rank_one_type): ... this.
7319
7320 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7321
7322         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7323         from...
7324         (rank_one_type): ... this.
7325
7326 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7327
7328         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7329         from...
7330         (rank_one_type): ... this.
7331
7332 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7333
7334         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7335         from...
7336         (rank_one_type): ... this.
7337
7338 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7339
7340         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7341         from...
7342         (rank_one_type): ... this.
7343
7344 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7345
7346         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7347         inferior-events' shows the example events.
7348
7349 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7350
7351         Support styling on native MS-Windows console
7352
7353         PR/24315
7354         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7355         on MS-Windows if $TERM is not defined.
7356
7357         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7358
7359         * posix-hdep.c (gdb_console_fputs):
7360         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7361         functions.
7362         * ui-file.h (gdb_console_fputs): Add prototype.
7363
7364         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7365         back to fputs only if the former returns zero.
7366
7367 2019-03-07  Tom Tromey  <tom@tromey.com>
7368
7369         * symmisc.c (print_symbol_bcache_statistics): Update.
7370         (print_objfile_statistics): Update.
7371         * symfile.c (allocate_symtab): Update.
7372         * stabsread.c: Don't include bcache.h.
7373         * psymtab.h (struct psymbol_bcache): Don't declare.
7374         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7375         (psymbol_bcache_init, psymbol_bcache_free)
7376         (psymbol_bcache_get_bcache): Don't declare.
7377         * psymtab.c (struct psymbol_bcache): Remove.
7378         (psymtab_storage::psymtab_storage): Update.
7379         (psymtab_storage::~psymtab_storage): Update.
7380         (psymbol_bcache_init, psymbol_bcache_free)
7381         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7382         (add_psymbol_to_bcache): Update.
7383         (allocate_psymtab): Update.
7384         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7385         macro_cache>: No longer pointers.
7386         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7387         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7388         * macrotab.c (macro_bcache): Update.
7389         * macroexp.c: Don't include bcache.h.
7390         * gdbtypes.c (check_types_worklist): Update.
7391         (types_deeply_equal): Remove TRY/CATCH.  Update.
7392         * elfread.c (elf_symtab_read): Update.
7393         * dwarf2read.c: Don't include bcache.h.
7394         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7395         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7396         (print_bcache_statistics, bcache_memory_used): Don't declare.
7397         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7398         methods.  Rename all data members.
7399         * bcache.c (struct bcache): Move to bcache.h.
7400         (bcache::expand_hash_table): Rename from expand_hash_table.
7401         (bcache): Remove.
7402         (bcache::insert): Rename from bcache_full.
7403         (bcache::compare): Rename from bcache_compare.
7404         (bcache_xmalloc): Remove.
7405         (bcache::~bcache): Rename from bcache_xfree.
7406         (bcache::print_statistics): Rename from print_bcache_statistics.
7407         (bcache::memory_used): Rename from bcache_memory_used.
7408
7409 2019-03-07  Pedro Alves  <palves@redhat.com>
7410
7411         * infrun.c (normal_stop): Also check for
7412         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7413
7414 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7415
7416         * f-lang.c (value_from_host_double): Moved to...
7417         * value.c (value_from_host_double): ...here.
7418         * value.h (value_from_host_double): Declare.
7419         * guile/scm-math.c (vlscm_convert_typed_number): Use
7420         value_from_host_double.
7421         (vlscm_convert_number): Likewise.
7422         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7423         * python/py-value.c (convert_value_from_python): Likewise.
7424
7425 2019-03-06  Tom Tromey  <tom@tromey.com>
7426
7427         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7428
7429 2019-03-06  Tom Tromey  <tom@tromey.com>
7430
7431         * utils.h (free_current_contents): Don't declare.
7432         * utils.c (free_current_contents): Remove.
7433
7434 2019-03-06  Tom Tromey  <tom@tromey.com>
7435
7436         * top.c (quit_force): Update.
7437         * main.c (captured_command_loop): Update.
7438         * common/new-op.c (operator new): Update.
7439         * common/common-exceptions.c (struct catcher)
7440         <save_cleanup_chain>: Remove member.
7441         (exceptions_state_mc_init): Update.
7442         (exception_try_scope_entry): Return nullptr.
7443         (exception_try_scope_exit, exception_rethrow)
7444         (throw_exception_sjlj, throw_exception_cxx): Update.
7445         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7446         (all_cleanups, do_cleanups, discard_cleanups)
7447         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7448         (restore_cleanups, restore_final_cleanups): Don't declare.
7449         (do_final_cleanups): Remove parameter.
7450         * common/cleanups.c (cleanup_chain, make_cleanup)
7451         (make_cleanup_dtor, all_cleanups, do_cleanups)
7452         (discard_my_cleanups, discard_cleanups)
7453         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7454         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7455         (null_cleanup): Remove.
7456         (do_final_cleanups): Remove parameter.
7457
7458 2019-03-06  Tom Tromey  <tom@tromey.com>
7459
7460         * remote.c (remote_target::remote_parse_stop_reply): Use
7461         unique_xmalloc_ptr.
7462
7463 2019-03-06  Tom Tromey  <tom@tromey.com>
7464
7465         * stabsread.c (struct stabs_field_info): Rename from field_info.
7466         <list, fnlist>: Add initializers.
7467         <obstack>: New member.
7468         (read_member_functions, read_struct_fields, read_baseclasses):
7469         Allocate on obstack.  Don't use cleanups.
7470         (read_one_struct_field, read_member_functions, read_struct_fields)
7471         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7472         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7473         (read_struct_type): Update.
7474
7475 2019-03-06  Tom Tromey  <tom@tromey.com>
7476
7477         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7478         * common/filestuff.h (make_cleanup_close): Don't declare.
7479         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7480         Remove.
7481
7482 2019-03-06  Tom Tromey  <tom@tromey.com>
7483
7484         * solib-aix.c: Use make_scope_exit.
7485
7486 2019-03-06  Tom Tromey  <tom@tromey.com>
7487
7488         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7489         Use make_scope_exit.
7490
7491 2019-03-06  Tom Tromey  <tom@tromey.com>
7492
7493         * solib-svr4.c (disable_probes_interface): Remove parameter.
7494         (svr4_handle_solib_event): Use make_scope_exit.
7495
7496 2019-03-06  Tom Tromey  <tom@tromey.com>
7497
7498         * remote.c (struct stop_reply_deleter): Remove.
7499         (stop_reply_up): Update.
7500         (struct stop_reply): Derive from notif_event.  Don't typedef.
7501         <regcache>: Now a std::vector.
7502         (stop_reply_xfree): Remove.
7503         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7504         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7505         (remote_target::discard_pending_stop_replies): Use delete.
7506         (remote_target::remote_parse_stop_reply): Update.
7507         (remote_target::process_stop_reply): Update.
7508         * remote-notif.h (struct notif_event): Add virtual destructor.
7509         Remove "dtr" member.
7510         (struct notif_client) <alloc_event>: Return a unique_ptr.
7511         (notif_event_xfree): Don't declare.
7512         (notif_event_up): New typedef.
7513         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7514         (notif_event_xfree, do_notif_event_xfree): Remove.
7515         (remote_notif_state_xfree): Update.
7516
7517 2019-03-06  Tom Tromey  <tom@tromey.com>
7518
7519         * infrun.c (displaced_step_clear_cleanup): Now a
7520         forward_scope_exit type.
7521         (displaced_step_prepare_throw): Update.
7522         (displaced_step_fixup): Update.
7523
7524 2019-03-06  Tom Tromey  <tom@tromey.com>
7525
7526         * inferior.h (class inferior): Update comment.
7527         * gdbthread.h (class thread_info): Update comment.
7528
7529 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7530             Tom Tromey  <tom@tromey.com>
7531
7532         * stabsread.h (struct stab_section_list): Remove.
7533         (coffstab_build_psymtabs): Update.
7534         * dbxread.c (symbuf_sections): Now a std::vector.
7535         (sect_idx): New global.
7536         (fill_symbuf): Update.
7537         (coffstab_build_psymtabs): Change type of stabsects parameter.
7538         Update.
7539         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7540         std::vector.
7541         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7542         (coff_locate_sections): Update.
7543         (coff_symfile_read): Remove cleanups.  Update.
7544         (init_stringtab): Add storage parameter.
7545         (free_stringtab, free_stringtab_cleanup): Remove.
7546         (init_lineno): Add storage parameter.
7547         (free_linetab, free_linetab_cleanup): Remove.
7548
7549 2019-03-06  Pedro Alves  <palves@redhat.com>
7550
7551         * linux-fork.c (fork_info::clobber_regs): Delete.
7552         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7553         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7554         comment.  Adjust.
7555         (scoped_switch_fork_info::scoped_switch_fork_info)
7556         (checkpoint_command, linux_fork_context): Adjust
7557         fork_save_infrun_state calls.
7558
7559 2019-03-06  Pedro Alves  <palves@redhat.com>
7560
7561         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7562         (inf_has_multiple_threads): Return 'bool' and rewrite using
7563         inferior_info::threads().
7564
7565 2019-03-06  Pedro Alves  <palves@redhat.com>
7566
7567         * linux-fork.c: Include <list>.
7568         (fork_list): Now a std::list instance.
7569         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7570         (forks_exist_p, find_last_fork): Adjust.
7571         (new_fork): Delete.
7572         (one_fork_p): New.
7573         (add_fork): Adjust.
7574         (free_fork): Delete, folded into fork_info::~fork_info().
7575         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7576         Adjust.
7577         (init_fork_list): Delete.
7578         (linux_fork_killall, linux_fork_mourn_inferior)
7579         (linux_fork_detach, info_checkpoints_command): Adjust.
7580         (_initialize_linux_fork): No longer call init_fork_list.
7581
7582 2019-03-06  Pedro Alves  <palves@redhat.com>
7583
7584         * linux-fork.c (new_fork): New, split out of ...
7585         (add_fork): ... this.  Return void.  Move "first fork" special
7586         case from here, to ...
7587         (checkpoint_command): ... here.
7588         * linux-linux.h (add_fork): Return void.
7589
7590 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7591
7592         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7593
7594 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7595             Chris January  <chris.january@arm.com>
7596             David Lecomber  <david.lecomber@arm.com>
7597
7598         * f-exp.y: New token, UNOP_INTRINSIC.
7599         (exp): New pattern using UNOP_INTRINSIC token.
7600         (f77_keywords): Add 'abs' keyword.
7601         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7602         (value_from_host_double): New function.
7603         (evaluate_subexp_f): Support UNOP_ABS.
7604
7605 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7606
7607         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7608         types.
7609
7610 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7611
7612         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7613         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7614         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7615
7616 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7617
7618         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7619
7620 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7621             Chris January  <chris.january@arm.com>
7622
7623         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7624         * f-exp.y: Define 'KIND' token.
7625         (exp): New pattern for KIND expressions.
7626         (ptype): Handle types with a kind extension.
7627         (direct_abs_decl): Extend to spot kind extensions.
7628         (f77_keywords): Add 'kind' to the list.
7629         (push_kind_type): New function.
7630         (convert_to_kind_type): New function.
7631         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7632         * parse.c (operator_length_standard): Likewise.
7633         * parser-defs.h (enum type_pieces): Add tp_kind.
7634         * std-operator.def: Add UNOP_KIND.
7635
7636 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7637
7638         * f-exp.y (f_parse): Set yydebug.
7639
7640 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7641
7642         * f-lang.c (evaluate_subexp_f): New function.
7643         (exp_descriptor_f): New global.
7644         (f_language_defn): Use exp_descriptor_f instead of
7645         exp_descriptor_standard.
7646
7647 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7648
7649         * f-exp.y (struct token): Add comments.
7650         (dot_ops): Remove uppercase versions and the end marker.
7651         (f77_keywords): Likewise.
7652         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7653         entries in the dot_ops array are case insensitive, and use
7654         strncasecmp to compare strings.  Also some whitespace cleanup in
7655         this area.  Similar for the f77_keywords array, except entries in
7656         this list might be case sensitive.
7657
7658 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7659
7660         * f-exp.y (struct f77_boolean_val): Add comments.
7661         (boolean_values): Remove uppercase versions, and end marker.
7662         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7663         and use strncasecmp to achieve case insensitivity.  Additionally,
7664         perform whitespace cleanup around this code.
7665
7666 2019-03-06  Tom Tromey  <tromey@adacore.com>
7667
7668         * remote-sim.c (gdbsim_target_open): Use result of
7669         gdb_argv::release.
7670
7671 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7672         Dirk Schubert  <dirk.schubert@arm.com>
7673         Chris January  <chris.january@arm.com>
7674
7675         * eval.c (evaluate_subexp_standard): Call Fortran argument
7676         wrapping logic.
7677         * f-lang.c (struct value): A value which can be passed into a
7678         Fortran function call.
7679         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7680         where appropriate.
7681         (struct type): Value ready for a Fortran function call.
7682         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7683         is needed.
7684         * f-lang.h (fortran_argument_convert): Declaration.
7685         (fortran_preserve_arg_pointer): Declaration.
7686         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7687
7688 2019-03-05  Tom Tromey  <tromey@adacore.com>
7689
7690         * python/py-prettyprint.c (print_string_repr): Remove #if.
7691         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7692
7693 2019-03-05  Tom Tromey  <tromey@adacore.com>
7694
7695         * target.c (the_dummy_target): Move later.  Change type to
7696         "dummy_target".
7697         (initialize_targets): Don't initialize the_dummy_target.
7698
7699 2019-03-05  Tom Tromey  <tromey@adacore.com>
7700
7701         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7702         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7703
7704 2019-03-05  Tom Tromey  <tromey@adacore.com>
7705
7706         * windows-nat.c (windows_nat_target::attach)
7707         (windows_nat_target::detach): Don't call gdb_flush.
7708         * valprint.c (generic_val_print, val_print, val_print_string):
7709         Don't call gdb_flush.
7710         * utils.c (defaulted_query): Don't call gdb_flush.
7711         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7712         * target.c (target_announce_detach): Don't call gdb_flush.
7713         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7714         * remote.c (extended_remote_target::attach): Don't call
7715         gdb_flush.
7716         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7717         * printcmd.c (do_examine): Don't call gdb_flush.
7718         (info_display_command): Don't call gdb_flush.
7719         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7720         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7721         * memattr.c (info_mem_command): Don't call gdb_flush.
7722         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7723         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7724         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7725         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7726         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7727         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7728         (gnu_nat_target::detach): Don't call gdb_flush.
7729         * f-valprint.c (f_val_print): Don't call gdb_flush.
7730         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7731         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7732         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7733         gdb_flush.
7734         * c-valprint.c (c_val_print): Don't call gdb_flush.
7735         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7736
7737 2019-03-05  Tom Tromey  <tromey@adacore.com>
7738
7739         * varobj.c (update_dynamic_varobj_children): Update.
7740         (install_default_visualizer): Use reset, not release.
7741         * value.c (set_internalvar): Update.
7742         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7743         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7744         ATTRIBUTE_UNUSED_RESULT.
7745
7746 2019-03-05  Tom Tromey  <tromey@adacore.com>
7747
7748         * remote.c (class scoped_remote_fd) <release>: Add
7749         ATTRIBUTE_UNUSED_RESULT.
7750
7751 2019-03-05  Tom Tromey  <tromey@adacore.com>
7752
7753         * macroexp.c (struct macro_buffer) <release>: Add
7754         ATTRIBUTE_UNUSED_RESULT.
7755
7756 2019-03-05  Tom Tromey  <tromey@adacore.com>
7757
7758         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7759         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7760         ATTRIBUTE_UNUSED_RESULT.
7761
7762 2019-03-05  Tom Tromey  <tromey@adacore.com>
7763
7764         * common/scoped_fd.h (class scoped_fd) <release>: Add
7765         ATTRIBUTE_UNUSED_RESULT.
7766
7767 2019-03-05  Tom Tromey  <tromey@adacore.com>
7768
7769         * parser-defs.h (struct parser_state) <release>: Add
7770         ATTRIBUTE_UNUSED_RESULT.
7771
7772 2019-03-05  Tom Tromey  <tromey@adacore.com>
7773
7774         * utils.h (class gdb_argv) <release>: Add
7775         ATTRIBUTE_UNUSED_RESULT.
7776         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7777
7778 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7779
7780         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7781         for-loop range, to avoid compiler warnings.
7782
7783         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7784         avoid compiler warnings about unused variables.
7785
7786         * NEWS: Mention end of support for native debugging on MS-Windows
7787         before XP.
7788
7789         PR gdb/24292
7790         * common/netstuff.c:
7791         * gdbserver/gdbreplay.c
7792         * gdbserver/remote-utils.c:
7793         * ser-tcp.c:
7794         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7795         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7796         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7797         'getaddrinfo' and 'freeaddrinfo' were not available before
7798         Windows XP, and mingw.org's MinGW headers by default define
7799         _WIN32_WINNT to 0x500.
7800
7801 2019-03-01  Gary Benson <gbenson@redhat.com>
7802
7803         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7804
7805 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7806             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7807
7808         PR gdb/8527
7809         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7810         set_sigint_trap, clear_sigint_trap.
7811
7812 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7813
7814         * target.c (target_detach): Clear the regcache and the
7815         frame cache.
7816
7817 2019-02-27  Pedro Alves  <palves@redhat.com>
7818
7819         * utils.c (set_screen_size): When we cap the height/width sizes,
7820         tweak the corresponding command variable to show "unlimited":
7821
7822 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7823             Pedro Alves  <palves@redhat.com>
7824
7825         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7826         before calling rl_set_screen_size.
7827
7828 2019-02-27  Tom Tromey  <tromey@adacore.com>
7829
7830         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7831         define.
7832         * python/py-value.c: Remove Python 2.4 workaround.
7833         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7834         workaround.
7835         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7836         Python 2.4 workaround.
7837         * python/python-internal.h: Remove Python 2.4 comment.
7838         (Py_ssize_t): Don't define.
7839         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7840         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7841         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7842         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7843         * python/python.c (do_start_initialization): Remove Python 2.4
7844         workaround.
7845         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7846         (print_children): Remove Python 2.4 workaround.
7847         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7848         workaround.
7849         (CHARBUFFERPROC_NAME): Remove.
7850         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7851         Python 2.4 workaround.
7852
7853 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7854
7855         * NEWS: Note minimum Python version.
7856
7857 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7858
7859         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7860         code from these functions.  Remove corresponding ifdefs.  Use
7861         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7862         Remove gotos and target of gotos.
7863         (infpy_search_memory): Likewise.
7864
7865 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7866
7867         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7868         (hppa_gdbarch_init): Don't register deleted functions with
7869         gdbarch.
7870
7871 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7872
7873         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7874         (h8300_unwind_sp): Delete.
7875         (h8300_dummy_id): Delete.
7876         (h8300_gdbarch_init): Don't register deleted functions with
7877         gdbarch.
7878
7879 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7880
7881         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7882         (ft32_unwind_pc): Delete.
7883         (ft32_unwind_sp): Delete.
7884         (ft32_gdbarch_init): Don't register deleted functions with
7885         gdbarch.
7886
7887 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7888
7889         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7890         (frv_unwind_pc): Delete.
7891         (frv_unwind_sp): Delete.
7892         (frv_gdbarch_init): Don't register deleted functions with
7893         gdbarch.
7894
7895 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7896
7897         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7898         (riscv_unwind_pc): Delete.
7899         (riscv_unwind_sp): Delete.
7900         (riscv_gdbarch_init): Don't register deleted functions with
7901         gdbarch.
7902
7903 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7904
7905         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7906         (csky_unwind_pc): Delete.
7907         (csky_unwind_sp): Delete.
7908         (csky_gdbarch_init): Don't register deleted functions with
7909         gdbarch.
7910
7911 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7912
7913         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7914         (cris_unwind_pc): Delete.
7915         (cris_unwind_sp): Delete.
7916         (cris_gdbarch_init): Don't register deleted functions with
7917         gdbarch.
7918
7919 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7920
7921         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7922         (bfin_unwind_pc): Delete.
7923         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7924
7925 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7926
7927         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7928         (arm_unwind_pc): Delete.
7929         (arm_unwind_sp): Delete.
7930         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7931
7932 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7933
7934         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7935         (arc_unwind_pc): Delete.
7936         (arc_unwind_sp): Delete.
7937         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7938
7939 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7940
7941         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7942         (alpha_unwind_pc): Delete.
7943         (alpha_gdbarch_init): Don't register deleted functions with
7944         gdbarch.
7945
7946 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7947
7948         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7949         (aarch64_unwind_pc): Delete.
7950         (aarch64_unwind_sp): Delete.
7951         (aarch64_gdbarch_init): Don't register deleted functions with
7952         gdbarch.
7953
7954 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7955
7956         * gdbtypes.c (type_align): Don't consider static members when
7957         computing structure alignment.
7958
7959 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7960
7961         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7962         return 0 for other types.
7963         * arch-utils.c (default_type_align): Always return 0.
7964         * gdbarch.h: Regenerate.
7965         * gdbarch.sh (type_align): Extend comment.
7966         * gdbtypes.c (type_align): Add additional comments, always call
7967         gdbarch_type_align before applying the default rules.
7968         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7969         generic code will then apply a suitable default.
7970         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7971         types, return 0 for other types.
7972
7973 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7974
7975         * NEWS: Create a new section for the next release branch.
7976         Rename the section of the current branch, now that it has
7977         been cut.
7978
7979 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7980
7981         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7982         * version.in: Bump version to 8.3.50.DATE-git.
7983
7984 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7985
7986         * aix-thread.c (ptid_cmp): Remove unused variable.
7987         (get_signaled_thread): Likewise.
7988         (store_regs_user_thread): Likewise.
7989         (store_regs_kernel_thread): Likewise.
7990         (fetch_regs_kernel_thread): Remove shadowed variable.
7991
7992 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7993
7994         * features/riscv/32bit-cpu.xml: Add register numbers.
7995         * features/riscv/32bit-fpu.c: Regenerate.
7996         * features/riscv/32bit-fpu.xml: Add register numbers.
7997         * features/riscv/64bit-cpu.xml: Add register numbers.
7998         * features/riscv/64bit-fpu.c: Regenerate.
7999         * features/riscv/64bit-fpu.xml: Add register numbers.
8000
8001 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8002
8003         * NEWS: Mention two argument form of gdb.Value constructor.
8004         * python/py-value.c (convert_buffer_and_type_to_value): New
8005         function.
8006         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8007         Add support for handling an optional second argument.  Call
8008         convert_buffer_and_type_to_value as appropriate.
8009         * python/python-internal.h (Py_buffer_deleter): New struct.
8010         (Py_buffer_up): New typedef.
8011
8012 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8013
8014         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8015         instead of releasing ownership.
8016
8017 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8018
8019         * dwarf2read.c (open_and_init_dwp_file): Call
8020         elf_numsections instead of bfd_count_sections to initialize
8021         dwp_file->num_sections.
8022
8023 2019-02-25  Tom Tromey  <tromey@adacore.com>
8024
8025         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8026
8027 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8028
8029         * gcore.in: Add '--readnever' option when invoking GDB.
8030
8031 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8032
8033         * MAINTAINERS: Update my email address.
8034
8035 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8036
8037         * build-id.c (build_id_to_debug_bfd_1): New function.
8038         (build_id_to_debug_bfd): Look for separate debug file in
8039         sysroot.
8040
8041 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8042
8043         * gdbarch.sh: Update the copyright year range that is placed into
8044         generated files.
8045
8046 2019-02-22  Keith Seitz  <keiths@redhat.com>
8047
8048         PR symtab/23853
8049         * linespec.c (create_sals_line_offset): Search for the default
8050         symtab's filename instead of its fullname.
8051
8052 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8053
8054         * NEWS: Update style defaults.
8055
8056 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8057
8058         * main.c (captured_main_1): Disable styling in batch mode.
8059
8060 2019-02-20  Tom Tromey  <tom@tromey.com>
8061
8062         * symtab.c (symtab_symbol_info): Fix typos.
8063
8064 2019-02-20  Tom Tromey  <tromey@adacore.com>
8065
8066         * findcmd.c (_initialize_mem_search): Use upper case for
8067         metasyntactic variables.
8068
8069 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8070
8071         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8072         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8073
8074 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8075
8076         * top.h (source_file_name): Change to std::string.
8077         * top.c (source_file_name): Likewise.
8078         (command_line_input): Adjust.
8079         * cli/cli-script.c (script_from_file): Adjust.
8080
8081 2019-02-19  Tom Tromey  <tromey@adacore.com>
8082
8083         * ravenscar-thread.c
8084         (ravenscar_thread_target::update_thread_list): Don't call
8085         ada_build_task_list.
8086         * ada-lang.h (ada_build_task_list): Don't declare.
8087         * ada-tasks.c (struct ada_tasks_inferior_data)
8088         <task_list_valid_p>: Now bool.
8089         (read_known_tasks, ada_task_list_changed)
8090         (ada_tasks_invalidate_inferior_data): Update.
8091         (read_known_tasks_array): Return bool.
8092         (read_known_tasks_list): Likewise.
8093         (read_known_tasks): Return void.
8094         (ada_build_task_list): Now static.
8095
8096 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8097
8098         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8099         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8100
8101 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8102
8103         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8104         variant for ada_tasks_pspace_data_handle and
8105         ada_tasks_inferior_data_handle.
8106         (ada_tasks_pspace_data_cleanup): New function.
8107         (ada_tasks_inferior_data_cleanup): New function.
8108
8109 2019-02-17  Tom Tromey  <tom@tromey.com>
8110
8111         * macrotab.h (macro_source_fullname): Return a std::string.
8112         * macrotab.c (macro_include, check_for_redefinition)
8113         (macro_undef, macro_lookup_definition, foreach_macro)
8114         (foreach_macro_in_scope): Update.
8115         (macro_source_fullname): Return a std::string.
8116         * macrocmd.c (show_pp_source_pos): Update.
8117
8118 2019-02-17  Tom Tromey  <tom@tromey.com>
8119
8120         * macrocmd.c (show_pp_source_pos): Style the file names.
8121
8122 2019-02-17  Tom Tromey  <tom@tromey.com>
8123
8124         PR tui/24197:
8125         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8126
8127 2019-02-17  Tom Tromey  <tom@tromey.com>
8128
8129         * ada-lang.c (user_select_syms): Use filtered printing.
8130         * utils.c (wrap_style): New global.
8131         (desired_style): Remove.
8132         (emit_style_escape): Add stream parameter.
8133         (set_output_style, reset_terminal_style, prompt_for_continue):
8134         Update.
8135         (flush_wrap_buffer): Only flush gdb_stdout.
8136         (wrap_here): Set wrap_style.
8137         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8138         treat escape sequences as a character.  Change when wrap buffer is
8139         flushed.
8140         (fputs_styled): Do not set the output style when the default is
8141         requested.
8142         * ui-style.h (struct ui_file_style) <is_default>: New method.
8143         * source.c (print_source_lines_base): Emit escape sequences in one
8144         piece.
8145
8146 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8147
8148         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8149         integers and enumeration types.
8150
8151 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8152
8153         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8154         instead of lookup_symbol_in_language
8155         (do_exact_match): New function.
8156         (ada_get_symbol_name_matcher): Return do_exact_match when
8157         doing a verbatim match.
8158
8159 2019-02-15  Tom Tromey  <tromey@adacore.com>
8160
8161         * ravenscar-thread.c (ravenscar_thread_target::resume)
8162         (ravenscar_thread_target::wait): Special case wildcard requests.
8163
8164 2019-02-15  Tom Tromey  <tromey@adacore.com>
8165
8166         * ravenscar-thread.c (base_ptid): Remove.
8167         (struct ravenscar_thread_target) <close>: New method.
8168         <m_base_ptid>: New member.
8169         <update_inferior_ptid, active_task, task_is_currently_active,
8170         runtime_initialized>: Declare methods.
8171         <ravenscar_thread_target>: Add constructor.
8172         (ravenscar_thread_target::task_is_currently_active)
8173         (ravenscar_thread_target::update_inferior_ptid)
8174         (ravenscar_runtime_initialized): Rename.  Now methods.
8175         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8176         (ravenscar_thread_target::update_thread_list): Update.
8177         (ravenscar_thread_target::active_task): Now method.
8178         (ravenscar_thread_target::store_registers)
8179         (ravenscar_thread_target::prepare_to_store)
8180         (ravenscar_thread_target::prepare_to_store)
8181         (ravenscar_thread_target::mourn_inferior): Update.
8182         (ravenscar_inferior_created): Use "new" to create target.
8183         (ravenscar_thread_target::get_ada_task_ptid): Update.
8184         (_initialize_ravenscar): Don't initialize base_ptid.
8185         (ravenscar_ops): Remove global.
8186
8187 2019-02-15  Tom Tromey  <tromey@adacore.com>
8188
8189         * target.h (push_target): Declare new overload.
8190         * target.c (push_target): New overload, taking an rvalue reference.
8191         * remote.c (remote_target::open_1): Use push_target overload.
8192         * corelow.c (core_target_open): Use push_target overload.
8193
8194 2019-02-15  Tom Tromey  <tromey@adacore.com>
8195
8196         * ravenscar-thread.c (is_ravenscar_task)
8197         (ravenscar_task_is_currently_active): Return bool.
8198         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8199         (_initialize_ravenscar): Remove "(void)".
8200         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8201         Return bool.
8202
8203 2019-02-15  Tom Tromey  <tromey@adacore.com>
8204
8205         * ravenscar-thread.c (ravenscar_runtime_initializer)
8206         (has_ravenscar_runtime, get_running_thread_id)
8207         (ravenscar_thread_target::resume): Fix indentation.
8208
8209 2019-02-15  Tom Tromey  <tromey@adacore.com>
8210
8211         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8212         from ravenscar_arch_ops.
8213         (sparc_ravenscar_ops::fetch_registers)
8214         (sparc_ravenscar_ops::store_registers): Now methods.
8215         (sparc_ravenscar_prepare_to_store): Remove.
8216         (sparc_ravenscar_ops): Redefine.
8217         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8218         methods and destructor.  Remove members.
8219         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8220         (ravenscar_thread_target::store_registers)
8221         (ravenscar_thread_target::prepare_to_store): Update.
8222         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8223         Remove.
8224         (struct ppc_ravenscar_powerpc_ops): Derive from
8225         ravenscar_arch_ops.
8226         (ppc_ravenscar_powerpc_ops::fetch_registers)
8227         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8228         (ppc_ravenscar_powerpc_ops): Redefine.
8229         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8230         (ppc_ravenscar_e500_ops::fetch_registers)
8231         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8232         (ppc_ravenscar_e500_ops): Redefine.
8233         * aarch64-ravenscar-thread.c
8234         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8235         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8236         (aarch64_ravenscar_fetch_registers)
8237         (aarch64_ravenscar_store_registers): Now methods.
8238         (aarch64_ravenscar_ops): Redefine.
8239
8240 2019-02-15  Tom Tromey  <tromey@adacore.com>
8241
8242         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8243         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8244         (ravenscar_thread_target::stopped_by_watchpoint)
8245         (ravenscar_thread_target::stopped_data_address)
8246         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8247
8248 2019-02-15  Tom Tromey  <tromey@adacore.com>
8249
8250         * ravenscar-thread.c: Fix some typos.
8251
8252 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8253             Tom Tromey  <tromey@adacore.com>
8254
8255         * ada-lang.c (ada_exception_sal): Change addr_string to a
8256         std::string.
8257         (create_ada_exception_catchpoint): Update.
8258
8259 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8260             Tom Tromey  <tromey@adacore.com>
8261
8262         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8263         (bp_location_ops): Remove.
8264         (base_breakpoint_allocate_location): Update.
8265         (free_bp_location): Update.
8266         * ada-lang.c (class ada_catchpoint_location)
8267         <ada_catchpoint_location>: Remove ops parameter.
8268         (ada_catchpoint_location_dtor): Remove.
8269         (ada_catchpoint_location_ops): Remove.
8270         (allocate_location_exception): Update.
8271         * breakpoint.h (struct bp_location_ops): Remove.
8272         (class bp_location) <bp_location>: Remove bp_location_ops
8273         parameter.
8274         <~bp_location>: Add destructor.
8275         <ops>: Remove.
8276
8277 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8278             Pedro Alves  <palves@redhat.com>
8279
8280         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8281         'PATH_MAX'.
8282
8283 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8284             Samuel Thibault  <samuel.thibault@gnu.org>
8285             Thomas Schwinge  <thomas@codesourcery.com>
8286
8287         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8288         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8289
8290 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8291
8292         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8293         (check_empty): Use "const char *".
8294
8295         * gnu-nat.c (gnu_nat_target::detach): Instead of
8296         'detach_inferior (pid)' call
8297         'detach_inferior (find_inferior_pid (pid))'.
8298
8299         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8300         'nat/fork-inferior.o'.
8301         * gnu-nat.c: #include "nat/fork-inferior.h".
8302
8303         * gnu-nat.c (gnu_nat_target::detach): Instead of
8304         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8305         * gnu-nat.h: #include "inf-child.h".
8306         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8307         'i386_gnu_nat_target::fetch_registers'.
8308         (gnu_store_registers): Rename/move to
8309         'i386_gnu_nat_target::store_registers'.
8310
8311         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8312         * gnu-nat.h (mach_thread_info): New function.
8313         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8314
8315         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8316
8317 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8318
8319         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8320
8321 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8322
8323         * windows-nat.c (windows_add_thread): Add new parameter
8324         "main_thread_p" with default value set to false.  Update
8325         function documentation as well as all callers.
8326         (windows_delete_thread): Likewise.
8327         (fake_create_process): Update call to windows_add_thread.
8328         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8329         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8330         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8331         call to windows_delete_thread.
8332
8333 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8334
8335         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8336
8337 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8338
8339         * symfile.c (find_separate_debug_file): Use canonical path of
8340         sysroot with child_path instead of gdb_sysroot if it is valid.
8341
8342 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8343
8344         * symfile.c (find_separate_debug_file): Use child_path to
8345         determine if an object file is under a sysroot.
8346
8347 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8348
8349         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8350         unittests/child-path-selftests.c.
8351         * common/pathstuff.c (child_path): New function.
8352         * common/pathstuff.h (child_path): New prototype.
8353         * unittests/child-path-selftests.c: New file.
8354
8355 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8356
8357         * symfile.c (find_separate_debug_file): Look for separate debug
8358         files in debug directories under the sysroot.
8359
8360 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8361
8362         * symtab.h (struct minimal_symbol data_p): New const method.
8363         (struct minimal_symbol text_p): Likewise.
8364         * symtab.c (output_source_filename): Use file name style
8365         to print file name.
8366         (print_symbol_info): Likewise.
8367         (print_msymbol_info): Use address style to print addresses.
8368         Use function name style to print executable text symbols.
8369         (expand_symtab_containing_pc): Use data_p.
8370         (find_pc_sect_compunit_symtab): Likewise.
8371
8372 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8373
8374         * breakpoint.c (describe_other_breakpoints): Use address style
8375         to print addresses.
8376         (say_where): Likewise.
8377
8378 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8379
8380         * ada-typeprint.c (print_func_type): Print function name
8381         style to print function name.
8382         * c-typeprint.c (c_print_type_1): Likewise.
8383
8384 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8385
8386         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8387         for execve.
8388
8389 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8390
8391         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8392         type_stack.
8393
8394 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8395
8396         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8397         TYPE_CODE_REF types.
8398
8399 2019-02-08  Jim Wilson  <jimw@sifive.com>
8400
8401         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8402         (riscv_linux_fregset): New.
8403         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8404
8405 2019-02-07  Tom Tromey  <tom@tromey.com>
8406
8407         * thread.c (thread_cancel_execution_command): Update.
8408         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8409         methods.
8410         (struct thread_fsm_ops): Remove.
8411         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8412         (thread_fsm_should_stop, thread_fsm_return_value)
8413         (thread_fsm_set_finished, thread_fsm_finished_p)
8414         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8415         Don't declare.
8416         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8417         * infrun.c (clear_proceed_status_thread)
8418         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8419         (print_stop_event): Update.
8420         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8421         Add constructor.
8422         (step_command_fsm_ops): Remove.
8423         (new_step_command_fsm): Remove.
8424         (step_1): Update.
8425         (step_command_fsm::should_stop): Rename from
8426         step_command_fsm_should_stop.
8427         (step_command_fsm::clean_up): Rename from
8428         step_command_fsm_clean_up.
8429         (step_command_fsm::do_async_reply_reason): Rename from
8430         step_command_fsm_async_reply_reason.
8431         (struct until_next_fsm): Inherit from thread_fsm.  Add
8432         constructor.
8433         (until_next_fsm_ops): Remove.
8434         (new_until_next_fsm): Remove.
8435         (until_next_fsm::should_stop): Rename from
8436         until_next_fsm_should_stop.
8437         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8438         (until_next_fsm::do_async_reply_reason): Rename from
8439         until_next_fsm_async_reply_reason.
8440         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8441         constructor.  Change type of breakpoint.
8442         (finish_command_fsm_ops): Remove.
8443         (new_finish_command_fsm): Remove.
8444         (finish_command_fsm::should_stop): Rename from
8445         finish_command_fsm_should_stop.
8446         (finish_command_fsm::clean_up): Rename from
8447         finish_command_fsm_clean_up.
8448         (finish_command_fsm::return_value): Rename from
8449         finish_command_fsm_return_value.
8450         (finish_command_fsm::do_async_reply_reason): Rename from
8451         finish_command_fsm_async_reply_reason.
8452         (finish_command): Update.
8453         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8454         Add constructor.
8455         (call_thread_fsm_ops): Remove.
8456         (call_thread_fsm::call_thread_fsm): Rename from
8457         new_call_thread_fsm.
8458         (call_thread_fsm::should_stop): Rename from
8459         call_thread_fsm_should_stop.
8460         (call_thread_fsm::should_notify_stop): Rename from
8461         call_thread_fsm_should_notify_stop.
8462         (run_inferior_call, call_function_by_hand_dummy): Update.
8463         * cli/cli-interp.c (should_print_stop_to_console): Update.
8464         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8465         Add constructor.  Change type of location_breakpoint,
8466         caller_breakpoint.
8467         (until_break_fsm_ops): Remove.
8468         (new_until_break_fsm): Remove.
8469         (until_break_fsm::should_stop): Rename from
8470         until_break_fsm_should_stop.
8471         (until_break_fsm::clean_up): Rename from
8472         until_break_fsm_clean_up.
8473         (until_break_fsm::do_async_reply_reason): Rename from
8474         until_break_fsm_async_reply_reason.
8475         (until_break_command): Update.
8476         * thread-fsm.c: Remove.
8477         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8478
8479 2019-02-07  Tom Tromey  <tom@tromey.com>
8480
8481         * yy-remap.h: Add include guard.
8482         * xtensa-tdep.h: Add include guard.
8483         * xcoffread.h: Rename include guard.
8484         * varobj-iter.h: Add include guard.
8485         * tui/tui.h: Rename include guard.
8486         * tui/tui-winsource.h: Rename include guard.
8487         * tui/tui-wingeneral.h: Rename include guard.
8488         * tui/tui-windata.h: Rename include guard.
8489         * tui/tui-win.h: Rename include guard.
8490         * tui/tui-stack.h: Rename include guard.
8491         * tui/tui-source.h: Rename include guard.
8492         * tui/tui-regs.h: Rename include guard.
8493         * tui/tui-out.h: Rename include guard.
8494         * tui/tui-layout.h: Rename include guard.
8495         * tui/tui-io.h: Rename include guard.
8496         * tui/tui-hooks.h: Rename include guard.
8497         * tui/tui-file.h: Rename include guard.
8498         * tui/tui-disasm.h: Rename include guard.
8499         * tui/tui-data.h: Rename include guard.
8500         * tui/tui-command.h: Rename include guard.
8501         * tic6x-tdep.h: Add include guard.
8502         * target/waitstatus.h: Rename include guard.
8503         * target/wait.h: Rename include guard.
8504         * target/target.h: Rename include guard.
8505         * target/resume.h: Rename include guard.
8506         * target-float.h: Rename include guard.
8507         * stabsread.h: Add include guard.
8508         * rs6000-tdep.h: Add include guard.
8509         * riscv-fbsd-tdep.h: Add include guard.
8510         * regformats/regdef.h: Rename include guard.
8511         * record.h: Rename include guard.
8512         * python/python.h: Rename include guard.
8513         * python/python-internal.h: Rename include guard.
8514         * python/py-stopevent.h: Rename include guard.
8515         * python/py-ref.h: Rename include guard.
8516         * python/py-record.h: Rename include guard.
8517         * python/py-record-full.h: Rename include guard.
8518         * python/py-record-btrace.h: Rename include guard.
8519         * python/py-instruction.h: Rename include guard.
8520         * python/py-events.h: Rename include guard.
8521         * python/py-event.h: Rename include guard.
8522         * procfs.h: Add include guard.
8523         * proc-utils.h: Add include guard.
8524         * p-lang.h: Add include guard.
8525         * or1k-tdep.h: Rename include guard.
8526         * observable.h: Rename include guard.
8527         * nto-tdep.h: Rename include guard.
8528         * nat/x86-linux.h: Rename include guard.
8529         * nat/x86-linux-dregs.h: Rename include guard.
8530         * nat/x86-gcc-cpuid.h: Add include guard.
8531         * nat/x86-dregs.h: Rename include guard.
8532         * nat/x86-cpuid.h: Rename include guard.
8533         * nat/ppc-linux.h: Rename include guard.
8534         * nat/mips-linux-watch.h: Rename include guard.
8535         * nat/linux-waitpid.h: Rename include guard.
8536         * nat/linux-ptrace.h: Rename include guard.
8537         * nat/linux-procfs.h: Rename include guard.
8538         * nat/linux-osdata.h: Rename include guard.
8539         * nat/linux-nat.h: Rename include guard.
8540         * nat/linux-namespaces.h: Rename include guard.
8541         * nat/linux-btrace.h: Rename include guard.
8542         * nat/glibc_thread_db.h: Rename include guard.
8543         * nat/gdb_thread_db.h: Rename include guard.
8544         * nat/gdb_ptrace.h: Rename include guard.
8545         * nat/fork-inferior.h: Rename include guard.
8546         * nat/amd64-linux-siginfo.h: Rename include guard.
8547         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8548         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8549         * nat/aarch64-linux.h: Rename include guard.
8550         * nat/aarch64-linux-hw-point.h: Rename include guard.
8551         * mn10300-tdep.h: Add include guard.
8552         * mips-linux-tdep.h: Add include guard.
8553         * mi/mi-parse.h: Rename include guard.
8554         * mi/mi-out.h: Rename include guard.
8555         * mi/mi-main.h: Rename include guard.
8556         * mi/mi-interp.h: Rename include guard.
8557         * mi/mi-getopt.h: Rename include guard.
8558         * mi/mi-console.h: Rename include guard.
8559         * mi/mi-common.h: Rename include guard.
8560         * mi/mi-cmds.h: Rename include guard.
8561         * mi/mi-cmd-break.h: Rename include guard.
8562         * m2-lang.h: Add include guard.
8563         * location.h: Rename include guard.
8564         * linux-record.h: Rename include guard.
8565         * linux-nat.h: Add include guard.
8566         * linux-fork.h: Add include guard.
8567         * i386-darwin-tdep.h: Rename include guard.
8568         * hppa-linux-offsets.h: Add include guard.
8569         * guile/guile.h: Rename include guard.
8570         * guile/guile-internal.h: Rename include guard.
8571         * gnu-nat.h: Rename include guard.
8572         * gdb-stabs.h: Rename include guard.
8573         * frv-tdep.h: Add include guard.
8574         * f-lang.h: Add include guard.
8575         * event-loop.h: Add include guard.
8576         * darwin-nat.h: Rename include guard.
8577         * cp-abi.h: Rename include guard.
8578         * config/sparc/nm-sol2.h: Rename include guard.
8579         * config/nm-nto.h: Rename include guard.
8580         * config/nm-linux.h: Add include guard.
8581         * config/i386/nm-i386gnu.h: Rename include guard.
8582         * config/djgpp/nl_types.h: Rename include guard.
8583         * config/djgpp/langinfo.h: Rename include guard.
8584         * compile/gcc-cp-plugin.h: Add include guard.
8585         * compile/gcc-c-plugin.h: Add include guard.
8586         * compile/compile.h: Rename include guard.
8587         * compile/compile-object-run.h: Rename include guard.
8588         * compile/compile-object-load.h: Rename include guard.
8589         * compile/compile-internal.h: Rename include guard.
8590         * compile/compile-cplus.h: Rename include guard.
8591         * compile/compile-c.h: Rename include guard.
8592         * common/xml-utils.h: Rename include guard.
8593         * common/x86-xstate.h: Rename include guard.
8594         * common/version.h: Rename include guard.
8595         * common/vec.h: Rename include guard.
8596         * common/tdesc.h: Rename include guard.
8597         * common/selftest.h: Rename include guard.
8598         * common/scoped_restore.h: Rename include guard.
8599         * common/scoped_mmap.h: Rename include guard.
8600         * common/scoped_fd.h: Rename include guard.
8601         * common/safe-iterator.h: Rename include guard.
8602         * common/run-time-clock.h: Rename include guard.
8603         * common/refcounted-object.h: Rename include guard.
8604         * common/queue.h: Rename include guard.
8605         * common/ptid.h: Rename include guard.
8606         * common/print-utils.h: Rename include guard.
8607         * common/preprocessor.h: Rename include guard.
8608         * common/pathstuff.h: Rename include guard.
8609         * common/observable.h: Rename include guard.
8610         * common/netstuff.h: Rename include guard.
8611         * common/job-control.h: Rename include guard.
8612         * common/host-defs.h: Rename include guard.
8613         * common/gdb_wait.h: Rename include guard.
8614         * common/gdb_vecs.h: Rename include guard.
8615         * common/gdb_unlinker.h: Rename include guard.
8616         * common/gdb_unique_ptr.h: Rename include guard.
8617         * common/gdb_tilde_expand.h: Rename include guard.
8618         * common/gdb_sys_time.h: Rename include guard.
8619         * common/gdb_string_view.h: Rename include guard.
8620         * common/gdb_splay_tree.h: Rename include guard.
8621         * common/gdb_setjmp.h: Rename include guard.
8622         * common/gdb_ref_ptr.h: Rename include guard.
8623         * common/gdb_optional.h: Rename include guard.
8624         * common/gdb_locale.h: Rename include guard.
8625         * common/gdb_assert.h: Rename include guard.
8626         * common/filtered-iterator.h: Rename include guard.
8627         * common/filestuff.h: Rename include guard.
8628         * common/fileio.h: Rename include guard.
8629         * common/environ.h: Rename include guard.
8630         * common/common-utils.h: Rename include guard.
8631         * common/common-types.h: Rename include guard.
8632         * common/common-regcache.h: Rename include guard.
8633         * common/common-inferior.h: Rename include guard.
8634         * common/common-gdbthread.h: Rename include guard.
8635         * common/common-exceptions.h: Rename include guard.
8636         * common/common-defs.h: Rename include guard.
8637         * common/common-debug.h: Rename include guard.
8638         * common/cleanups.h: Rename include guard.
8639         * common/buffer.h: Rename include guard.
8640         * common/btrace-common.h: Rename include guard.
8641         * common/break-common.h: Rename include guard.
8642         * cli/cli-utils.h: Rename include guard.
8643         * cli/cli-style.h: Rename include guard.
8644         * cli/cli-setshow.h: Rename include guard.
8645         * cli/cli-script.h: Rename include guard.
8646         * cli/cli-interp.h: Rename include guard.
8647         * cli/cli-decode.h: Rename include guard.
8648         * cli/cli-cmds.h: Rename include guard.
8649         * charset-list.h: Add include guard.
8650         * buildsym-legacy.h: Rename include guard.
8651         * bfin-tdep.h: Add include guard.
8652         * ax.h: Rename include guard.
8653         * arm-linux-tdep.h: Add include guard.
8654         * arm-fbsd-tdep.h: Add include guard.
8655         * arch/xtensa.h: Rename include guard.
8656         * arch/tic6x.h: Add include guard.
8657         * arch/i386.h: Add include guard.
8658         * arch/arm.h: Rename include guard.
8659         * arch/arm-linux.h: Rename include guard.
8660         * arch/arm-get-next-pcs.h: Rename include guard.
8661         * arch/amd64.h: Add include guard.
8662         * arch/aarch64-insn.h: Rename include guard.
8663         * arch-utils.h: Rename include guard.
8664         * annotate.h: Add include guard.
8665         * amd64-darwin-tdep.h: Rename include guard.
8666         * aarch64-linux-tdep.h: Add include guard.
8667         * aarch64-fbsd-tdep.h: Add include guard.
8668         * aarch32-linux-nat.h: Add include guard.
8669
8670 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8671
8672         * macrotab.c (macro_define_internal): New function that
8673         factorizes macro_define_object_internal and macro_define_function
8674         code.
8675         (macro_define_object_internal): Use macro_define_internal.
8676         (macro_define_function): Likewise.
8677
8678 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8679
8680         * macrocmd.c (extract_identifier): Return
8681         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8682         callers.
8683
8684 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8685
8686         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8687
8688 2019-02-05  Tom Tromey  <tom@tromey.com>
8689
8690         * target.c (target_stack::unpush): Move assertion earlier.
8691
8692 2019-01-30  Tom Tromey  <tom@tromey.com>
8693
8694         PR python/23615:
8695         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8696         (gdbpy_parse_and_eval): Likewise.
8697         * python/python-internal.h (gdbpy_allow_threads): New class.
8698
8699 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8700
8701         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8702         (aarch64_fbsd_fpregmap): Move earlier.
8703         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8704         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8705         instead of individual calls to trad_frame_set_reg_addr.
8706         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8707         earlier.
8708         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8709         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8710         instead of individual calls to trad_frame_set_reg_addr.
8711
8712 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8713
8714         * CONTRIBUTE: Replace contribution list with wiki link.
8715
8716 2019-01-25  Tom Tromey  <tom@tromey.com>
8717
8718         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8719
8720 2019-01-25  Tom Tromey  <tom@tromey.com>
8721
8722         * xtensa-linux-nat.c: Fix common/ includes.
8723         * xml-support.h: Fix common/ includes.
8724         * xml-support.c: Fix common/ includes.
8725         * x86-linux-nat.c: Fix common/ includes.
8726         * windows-nat.c: Fix common/ includes.
8727         * varobj.h: Fix common/ includes.
8728         * varobj.c: Fix common/ includes.
8729         * value.c: Fix common/ includes.
8730         * valops.c: Fix common/ includes.
8731         * utils.c: Fix common/ includes.
8732         * unittests/xml-utils-selftests.c: Fix common/ includes.
8733         * unittests/utils-selftests.c: Fix common/ includes.
8734         * unittests/unpack-selftests.c: Fix common/ includes.
8735         * unittests/tracepoint-selftests.c: Fix common/ includes.
8736         * unittests/style-selftests.c: Fix common/ includes.
8737         * unittests/string_view-selftests.c: Fix common/ includes.
8738         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8739         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8740         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8741         * unittests/rsp-low-selftests.c: Fix common/ includes.
8742         * unittests/parse-connection-spec-selftests.c: Fix common/
8743         includes.
8744         * unittests/optional-selftests.c: Fix common/ includes.
8745         * unittests/offset-type-selftests.c: Fix common/ includes.
8746         * unittests/observable-selftests.c: Fix common/ includes.
8747         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8748         * unittests/memrange-selftests.c: Fix common/ includes.
8749         * unittests/memory-map-selftests.c: Fix common/ includes.
8750         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8751         * unittests/function-view-selftests.c: Fix common/ includes.
8752         * unittests/environ-selftests.c: Fix common/ includes.
8753         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8754         * unittests/common-utils-selftests.c: Fix common/ includes.
8755         * unittests/cli-utils-selftests.c: Fix common/ includes.
8756         * unittests/array-view-selftests.c: Fix common/ includes.
8757         * ui-file.c: Fix common/ includes.
8758         * tui/tui-io.c: Fix common/ includes.
8759         * tracepoint.h: Fix common/ includes.
8760         * tracepoint.c: Fix common/ includes.
8761         * tracefile-tfile.c: Fix common/ includes.
8762         * top.h: Fix common/ includes.
8763         * top.c: Fix common/ includes.
8764         * thread.c: Fix common/ includes.
8765         * target/waitstatus.h: Fix common/ includes.
8766         * target/waitstatus.c: Fix common/ includes.
8767         * target.h: Fix common/ includes.
8768         * target.c: Fix common/ includes.
8769         * target-memory.c: Fix common/ includes.
8770         * target-descriptions.c: Fix common/ includes.
8771         * symtab.h: Fix common/ includes.
8772         * symfile.c: Fix common/ includes.
8773         * stap-probe.c: Fix common/ includes.
8774         * spu-linux-nat.c: Fix common/ includes.
8775         * sparc-nat.c: Fix common/ includes.
8776         * source.c: Fix common/ includes.
8777         * solib.c: Fix common/ includes.
8778         * solib-target.c: Fix common/ includes.
8779         * ser-unix.c: Fix common/ includes.
8780         * ser-tcp.c: Fix common/ includes.
8781         * ser-pipe.c: Fix common/ includes.
8782         * ser-base.c: Fix common/ includes.
8783         * selftest-arch.c: Fix common/ includes.
8784         * s12z-tdep.c: Fix common/ includes.
8785         * rust-exp.y: Fix common/ includes.
8786         * rs6000-aix-tdep.c: Fix common/ includes.
8787         * riscv-tdep.c: Fix common/ includes.
8788         * remote.c: Fix common/ includes.
8789         * remote-notif.h: Fix common/ includes.
8790         * remote-fileio.h: Fix common/ includes.
8791         * remote-fileio.c: Fix common/ includes.
8792         * regcache.h: Fix common/ includes.
8793         * regcache.c: Fix common/ includes.
8794         * record-btrace.c: Fix common/ includes.
8795         * python/python.c: Fix common/ includes.
8796         * python/py-type.c: Fix common/ includes.
8797         * python/py-inferior.c: Fix common/ includes.
8798         * progspace.h: Fix common/ includes.
8799         * producer.c: Fix common/ includes.
8800         * procfs.c: Fix common/ includes.
8801         * proc-api.c: Fix common/ includes.
8802         * printcmd.c: Fix common/ includes.
8803         * ppc-linux-nat.c: Fix common/ includes.
8804         * parser-defs.h: Fix common/ includes.
8805         * osdata.c: Fix common/ includes.
8806         * obsd-nat.c: Fix common/ includes.
8807         * nat/x86-linux.c: Fix common/ includes.
8808         * nat/x86-linux-dregs.c: Fix common/ includes.
8809         * nat/x86-dregs.h: Fix common/ includes.
8810         * nat/x86-dregs.c: Fix common/ includes.
8811         * nat/ppc-linux.c: Fix common/ includes.
8812         * nat/mips-linux-watch.h: Fix common/ includes.
8813         * nat/mips-linux-watch.c: Fix common/ includes.
8814         * nat/linux-waitpid.c: Fix common/ includes.
8815         * nat/linux-ptrace.h: Fix common/ includes.
8816         * nat/linux-ptrace.c: Fix common/ includes.
8817         * nat/linux-procfs.c: Fix common/ includes.
8818         * nat/linux-personality.c: Fix common/ includes.
8819         * nat/linux-osdata.c: Fix common/ includes.
8820         * nat/linux-namespaces.c: Fix common/ includes.
8821         * nat/linux-btrace.h: Fix common/ includes.
8822         * nat/linux-btrace.c: Fix common/ includes.
8823         * nat/fork-inferior.c: Fix common/ includes.
8824         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8825         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8826         * nat/aarch64-linux.c: Fix common/ includes.
8827         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8828         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8829         * namespace.h: Fix common/ includes.
8830         * mips-linux-tdep.c: Fix common/ includes.
8831         * minsyms.c: Fix common/ includes.
8832         * mi/mi-parse.h: Fix common/ includes.
8833         * mi/mi-main.c: Fix common/ includes.
8834         * mi/mi-cmd-env.c: Fix common/ includes.
8835         * memrange.h: Fix common/ includes.
8836         * memattr.c: Fix common/ includes.
8837         * maint.h: Fix common/ includes.
8838         * maint.c: Fix common/ includes.
8839         * main.c: Fix common/ includes.
8840         * machoread.c: Fix common/ includes.
8841         * location.c: Fix common/ includes.
8842         * linux-thread-db.c: Fix common/ includes.
8843         * linux-nat.c: Fix common/ includes.
8844         * linux-fork.c: Fix common/ includes.
8845         * inline-frame.c: Fix common/ includes.
8846         * infrun.c: Fix common/ includes.
8847         * inflow.c: Fix common/ includes.
8848         * inferior.h: Fix common/ includes.
8849         * inferior.c: Fix common/ includes.
8850         * infcmd.c: Fix common/ includes.
8851         * inf-ptrace.c: Fix common/ includes.
8852         * inf-child.c: Fix common/ includes.
8853         * ia64-linux-nat.c: Fix common/ includes.
8854         * i387-tdep.c: Fix common/ includes.
8855         * i386-tdep.c: Fix common/ includes.
8856         * i386-linux-tdep.c: Fix common/ includes.
8857         * i386-linux-nat.c: Fix common/ includes.
8858         * i386-go32-tdep.c: Fix common/ includes.
8859         * i386-fbsd-tdep.c: Fix common/ includes.
8860         * i386-fbsd-nat.c: Fix common/ includes.
8861         * guile/scm-type.c: Fix common/ includes.
8862         * guile/guile.c: Fix common/ includes.
8863         * go32-nat.c: Fix common/ includes.
8864         * gnu-nat.c: Fix common/ includes.
8865         * gdbthread.h: Fix common/ includes.
8866         * gdbarch-selftests.c: Fix common/ includes.
8867         * gdb_usleep.c: Fix common/ includes.
8868         * gdb_select.h: Fix common/ includes.
8869         * gdb_bfd.c: Fix common/ includes.
8870         * gcore.c: Fix common/ includes.
8871         * fork-child.c: Fix common/ includes.
8872         * findvar.c: Fix common/ includes.
8873         * fbsd-nat.c: Fix common/ includes.
8874         * event-top.c: Fix common/ includes.
8875         * event-loop.c: Fix common/ includes.
8876         * dwarf2read.c: Fix common/ includes.
8877         * dwarf2loc.c: Fix common/ includes.
8878         * dwarf2-frame.c: Fix common/ includes.
8879         * dwarf-index-cache.c: Fix common/ includes.
8880         * dtrace-probe.c: Fix common/ includes.
8881         * disasm-selftests.c: Fix common/ includes.
8882         * defs.h: Fix common/ includes.
8883         * csky-tdep.c: Fix common/ includes.
8884         * cp-valprint.c: Fix common/ includes.
8885         * cp-support.h: Fix common/ includes.
8886         * cp-support.c: Fix common/ includes.
8887         * corelow.c: Fix common/ includes.
8888         * completer.h: Fix common/ includes.
8889         * completer.c: Fix common/ includes.
8890         * compile/compile.c: Fix common/ includes.
8891         * compile/compile-loc2c.c: Fix common/ includes.
8892         * compile/compile-cplus-types.c: Fix common/ includes.
8893         * compile/compile-cplus-symbols.c: Fix common/ includes.
8894         * command.h: Fix common/ includes.
8895         * cli/cli-dump.c: Fix common/ includes.
8896         * cli/cli-cmds.c: Fix common/ includes.
8897         * charset.c: Fix common/ includes.
8898         * build-id.c: Fix common/ includes.
8899         * btrace.h: Fix common/ includes.
8900         * btrace.c: Fix common/ includes.
8901         * breakpoint.h: Fix common/ includes.
8902         * breakpoint.c: Fix common/ includes.
8903         * ax.h:
8904         (enum agent_op): Fix common/ includes.
8905         * ax-general.c (struct aop_map): Fix common/ includes.
8906         * ax-gdb.c: Fix common/ includes.
8907         * auxv.c: Fix common/ includes.
8908         * auto-load.c: Fix common/ includes.
8909         * arm-tdep.c: Fix common/ includes.
8910         * arch/riscv.c: Fix common/ includes.
8911         * arch/ppc-linux-common.c: Fix common/ includes.
8912         * arch/i386.c: Fix common/ includes.
8913         * arch/arm.c: Fix common/ includes.
8914         * arch/arm-linux.c: Fix common/ includes.
8915         * arch/arm-get-next-pcs.c: Fix common/ includes.
8916         * arch/amd64.c: Fix common/ includes.
8917         * arch/aarch64.c: Fix common/ includes.
8918         * arch/aarch64-insn.c: Fix common/ includes.
8919         * arch-utils.c: Fix common/ includes.
8920         * amd64-windows-tdep.c: Fix common/ includes.
8921         * amd64-tdep.c: Fix common/ includes.
8922         * amd64-sol2-tdep.c: Fix common/ includes.
8923         * amd64-obsd-tdep.c: Fix common/ includes.
8924         * amd64-nbsd-tdep.c: Fix common/ includes.
8925         * amd64-linux-tdep.c: Fix common/ includes.
8926         * amd64-linux-nat.c: Fix common/ includes.
8927         * amd64-fbsd-tdep.c: Fix common/ includes.
8928         * amd64-fbsd-nat.c: Fix common/ includes.
8929         * amd64-dicos-tdep.c: Fix common/ includes.
8930         * amd64-darwin-tdep.c: Fix common/ includes.
8931         * agent.c: Fix common/ includes.
8932         * ada-lang.h: Fix common/ includes.
8933         * ada-lang.c: Fix common/ includes.
8934         * aarch64-tdep.c: Fix common/ includes.
8935
8936 2019-01-25  Tom Tromey  <tom@tromey.com>
8937
8938         * common/create-version.sh: Use common/version.h.
8939
8940 2019-01-24  Pedro Alves  <palves@redhat.com>
8941
8942         * infrun.c (signal_stop, signal_print, signal_program)
8943         (signal_catch, signal_pass): Now arrays instead of pointers.
8944         (update_signals_program_target, do_target_resume)
8945         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8946         * linux-nat.c (linux_nat_target::pass_signals)
8947         (linux_nat_target::create_inferior, linux_nat_target::attach):
8948         Adjust.
8949         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8950         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8951         * procfs.c (procfs_target::pass_signals): Adjust.
8952         * record-full.c (record_full_target::resume): Adjust.
8953         * remote.c (remote_target::pass_signals)
8954         (remote_target::program_signals): Adjust.
8955         * target-debug.h (target_debug_print_signals): Now takes a
8956         gdb::array_view as parameter.  Adjust.
8957         * target.h (target_ops) <pass_signals, program_signals>: Replace
8958         pointer and length parameters with gdb::array_view.
8959         (target_pass_signals, target_program_signals): Likewise.
8960         * target-delegates.c: Regenerate.
8961
8962 2019-01-24  Pedro Alves  <palves@redhat.com>
8963
8964         * common/forward-scope-exit.h
8965         (forward_scope_exit::forward_scope_exit): Pass arguments to
8966         m_bind_function directly, instead of creating a std::bind and
8967         copying that.
8968
8969 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8970
8971         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8972         for static members.
8973         (pass_in_v_vfp_candidate): Likewise.
8974
8975 2019-01-23  Tom Tromey  <tom@tromey.com>
8976             Pedro Alves  <palves@redhat.com>
8977
8978         * regcache.c (class regcache_invalidator): Remove.
8979         (regcache::raw_write): Use make_scope_exit.
8980
8981 2019-01-23  Tom Tromey  <tom@tromey.com>
8982
8983         * ui-out.h (class ui_out_emit_type): Update comment.
8984
8985 2019-01-23  Tom Tromey  <tom@tromey.com>
8986
8987         * infrun.c (fetch_inferior_event): Update comment.
8988
8989 2019-01-23  Tom Tromey  <tom@tromey.com>
8990             Pedro Alves  <palves@redhat.com>
8991
8992         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8993         parameter.
8994         (fetch_inferior_event): Use SCOPE_EXIT.
8995
8996
8997 2019-01-23  Tom Tromey  <tom@tromey.com>
8998             Pedro Alves  <palves@redhat.com>
8999
9000         * infrun.c (disable_thread_events): Delete.
9001         (stop_all_threads): Use SCOPE_EXIT.
9002
9003 2019-01-23  Tom Tromey  <tom@tromey.com>
9004             Pedro Alves  <palves@redhat.com>
9005
9006         * symfile.c: Include forward-scope-exit.h.
9007         (clear_symtab_users_cleanup): Replace forward declaration with
9008         a FORWARD_SCOPE_EXIT.
9009         (syms_from_objfile_1): Use the forward_scope_exit and
9010         gdb::optional instead of cleanup_function.
9011         (reread_symbols): Use the forward_scope_exit instead of
9012         cleanup_function.
9013         (clear_symtab_users_cleanup): Remove function.
9014
9015 2019-01-23  Tom Tromey  <tom@tromey.com>
9016             Pedro Alves  <palves@redhat.com>
9017
9018         * linux-nat.c: Include scope-exit.h.
9019         (cleanup_target_stop): Remove.
9020         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9021         SCOPE_EXIT.
9022
9023 2019-01-23  Tom Tromey  <tom@tromey.com>
9024             Pedro Alves  <palves@redhat.com>
9025
9026         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9027         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9028
9029 2019-01-23  Tom Tromey  <tom@tromey.com>
9030             Andrew Burgess  <andrew.burgess@embecosm.com>
9031             Pedro Alves  <palves@redhat.com>
9032
9033         * infrun.c (fetch_inferior_event): Use scope_exit.
9034         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9035         * top.c (execute_command): Use scope_exit.
9036         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9037         * utils.c (do_bpstat_clear_actions_cleanup)
9038         (make_bpstat_clear_actions_cleanup): Remove.
9039
9040 2019-01-23  Tom Tromey  <tom@tromey.com>
9041             Pedro Alves  <palves@redhat.com>
9042
9043         * infrun.c: Include "common/scope-exit.h"
9044         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9045         (wait_for_inferior): Use SCOPE_EXIT.
9046         (fetch_inferior_event): Use scope_exit.
9047
9048 2019-01-23  Tom Tromey  <tom@tromey.com>
9049             Pedro Alves  <palves@redhat.com>
9050
9051         * breakpoint.c (create_breakpoint): Remove cleanup.
9052
9053 2019-01-23  Tom Tromey  <tom@tromey.com>
9054             Andrew Burgess  <andrew.burgess@embecosm.com>
9055             Pedro Alves  <palves@redhat.com>
9056
9057 2019-01-23  Pedro Alves  <palves@redhat.com>
9058
9059         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9060
9061 2019-01-23  Pedro Alves  <palves@redhat.com>
9062             Andrew Burgess  <andrew.burgess@embecosm.com>
9063
9064         * gdbthread.h: Include "common/forward-scope-exit.h".
9065         (scoped_finish_thread_state): Redefine custom class in terms of
9066         forward_scope_exit.
9067
9068 2019-01-23  Pedro Alves  <palves@redhat.com>
9069             Andrew Burgess  <andrew.burgess@embecosm.com>
9070
9071         * common/forward-scope-exit.h: New file.
9072
9073 2019-01-23  Pedro Alves  <palves@redhat.com>
9074             Andrew Burgess  <andrew.burgess@embecosm.com>
9075             Tom Tromey  <tom@tromey.com>
9076
9077         * common/scope-exit.h: New file.
9078
9079 2019-01-23  Pedro Alves  <palves@redhat.com>
9080
9081         * common/preprocessor.h (ESC): Rename to ...
9082         (ESC_PARENS): ... this.
9083         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9084         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9085
9086 2019-01-23  Tom Tromey  <tom@tromey.com>
9087
9088         * language.h (class scoped_switch_to_sym_language_if_auto):
9089         Initialize m_lang in both cases.
9090
9091 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9092
9093         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9094         with XCNEW.
9095
9096 2019-01-22  Tom Tromey  <tom@tromey.com>
9097
9098         * corelow.c: Do not include sys/file.h.
9099
9100 2019-01-22  Tom Tromey  <tom@tromey.com>
9101
9102         * tui/tui-wingeneral.h: Include gdb_curses.h.
9103
9104 2019-01-22  Tom Tromey  <tom@tromey.com>
9105
9106         * source-cache.h (class source_cache) <get_source_lines,
9107         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9108
9109 2019-01-22  Tom Tromey  <tom@tromey.com>
9110
9111         * remote-fileio.h (struct remote_target): Declare.
9112
9113 2019-01-22  Tom Tromey  <tom@tromey.com>
9114
9115         * python/py-arch.c: Do not include py-ref.h.
9116         * python/py-bpevent.c: Do not include py-ref.h.
9117         * python/py-cmd.c: Do not include py-ref.h.
9118         * python/py-continueevent.c: Do not include py-ref.h.
9119         * python/py-event.h: Do not include py-ref.h.
9120         * python/py-evtregistry.c: Do not include py-ref.h.
9121         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9122         * python/py-frame.c: Do not include py-ref.h.
9123         * python/py-framefilter.c: Do not include py-ref.h.
9124         * python/py-function.c: Do not include py-ref.h.
9125         * python/py-infevents.c: Do not include py-ref.h.
9126         * python/py-linetable.c: Do not include py-ref.h.
9127         * python/py-objfile.c: Do not include py-ref.h.
9128         * python/py-param.c: Do not include py-ref.h.
9129         * python/py-prettyprint.c: Do not include py-ref.h.
9130         * python/py-progspace.c: Do not include py-ref.h.
9131         * python/py-symbol.c: Do not include py-ref.h.
9132         * python/py-symtab.c: Do not include py-ref.h.
9133         * python/py-type.c: Do not include py-ref.h.
9134         * python/py-unwind.c: Do not include py-ref.h.
9135         * python/py-utils.c: Do not include py-ref.h.
9136         * python/py-value.c: Do not include py-ref.h.
9137         * python/py-varobj.c: Do not include py-ref.h.
9138         * python/py-xmethods.c: Do not include py-ref.h.
9139         * python/python.c: Do not include py-ref.h.
9140         * varobj.c: Do not include py-ref.h.
9141
9142 2019-01-22  Tom Tromey  <tom@tromey.com>
9143
9144         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9145         keyword for bcache.
9146
9147 2019-01-22  Tom Tromey  <tom@tromey.com>
9148
9149         * compile/compile-cplus-types.c: Remove a comment by #include.
9150
9151 2019-01-22  Tom Tromey  <tom@tromey.com>
9152
9153         * compile/gcc-c-plugin.h: Include compile-internal.h.
9154
9155 2019-01-22  Tom Tromey  <tom@tromey.com>
9156
9157         * stabsread.c (EXTERN): Do not define.
9158         (symnum, next_symbol_text_func, processing_gcc_compilation)
9159         (within_function, global_sym_chain, global_stabs)
9160         (previous_stab_code, this_object_header_files)
9161         (n_this_object_header_files)
9162         (n_allocated_this_object_header_files): Define.
9163         * stabsread.h (EXTERN): Never define.  Use "extern".
9164
9165 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9166
9167         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9168         history_value.
9169
9170 2019-01-21  Tom Tromey  <tom@tromey.com>
9171
9172         * ui-out.c: Fix includes.
9173         * tui/tui-source.c: Fix includes.
9174         * target.c: Fix includes.
9175         * remote.c: Fix includes.
9176         * regcache.c: Fix includes.
9177         * python/py-block.c: Fix includes.
9178         * printcmd.c: Fix includes.
9179         * or1k-tdep.c: Fix includes.
9180         * mi/mi-main.c: Fix includes.
9181         * m32r-tdep.c: Fix includes.
9182         * csky-tdep.c: Fix includes.
9183         * compile/compile-cplus-types.c: Fix includes.
9184         * cli/cli-interp.c: Fix includes.
9185
9186 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9187
9188         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9189         for padding.
9190
9191 2019-01-16  Tom Tromey  <tom@tromey.com>
9192
9193         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9194         earlier.
9195         (struct objfile) <msymbols_range>: Move from top level.
9196         <msymbols>: New method.
9197         (class objfile_msymbols): Remove.
9198         * symtab.c (default_collect_symbol_completion_matches_break_on):
9199         Update.
9200         * symmisc.c (dump_msymbols): Update.
9201         * stabsread.c (scan_file_globals): Update.
9202         * objc-lang.c (info_selectors_command, info_classes_command)
9203         (find_methods): Update.
9204         * minsyms.c (find_solib_trampoline_target): Update.
9205         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9206         * coffread.c (coff_symfile_read): Update.
9207         * ada-lang.c (ada_lookup_simple_minsym)
9208         (ada_collect_symbol_completion_matches): Update.
9209
9210 2019-01-16  Tom Tromey  <tom@tromey.com>
9211
9212         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9213         type.  Remove no-argument constructor.
9214         <iterator::operator++>: Simplify.
9215         <begin>: Update.
9216         <end>: Use minimal_symbol_count.
9217
9218 2019-01-16  Tom Tromey  <tom@tromey.com>
9219
9220         * objfiles.h (struct objfile) <psymtabs>: New method.
9221         (class objfile_psymtabs): Remove.
9222         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9223         typedef.
9224         <range>: New method.
9225         (require_partial_symbols): Change return type.
9226         * psymtab.c (require_partial_symbols)
9227         (psym_expand_symtabs_matching): Update.
9228         * mdebugread.c (parse_partial_symbols): Update.
9229         * dbxread.c (dbx_end_psymtab): Update.
9230
9231 2019-01-15  Tom Tromey  <tom@tromey.com>
9232
9233         * symtab.c (lookup_objfile_from_block)
9234         (lookup_symbol_in_objfile_symtabs)
9235         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9236         (find_line_symtab, info_sources_command)
9237         (default_collect_symbol_completion_matches_break_on)
9238         (make_source_files_completion_list): Update.
9239         * symmisc.c (print_objfile_statistics, dump_objfile)
9240         (maintenance_print_symbols, maintenance_info_symtabs)
9241         (maintenance_check_symtabs, maintenance_info_line_tables):
9242         Update.
9243         * source.c (select_source_symtab)
9244         (forget_cached_source_info_for_objfile): Update.
9245         * objfiles.h (class objfile_compunits): Remove.
9246         (struct objfile) <compunits_range>: New typedef.
9247         (compunits): New method.
9248         * objfiles.c (objfile_relocate1): Update.
9249         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9250         * maint.c (count_symtabs_and_blocks): Update.
9251         * linespec.c (iterate_over_all_matching_symtabs): Update.
9252         * cp-support.c (add_symbol_overload_list_qualified): Update.
9253         * coffread.c (coff_symtab_read): Update.
9254         * ada-lang.c (add_nonlocal_symbols)
9255         (ada_collect_symbol_completion_matches)
9256         (ada_add_global_exceptions): Update.
9257
9258 2019-01-15  Tom Tromey  <tom@tromey.com>
9259
9260         * progspace.h (program_space) <objfiles_safe_range>: New
9261         typedef.
9262         <objfiles_safe>: New method.
9263         * objfiles.h (class all_objfiles_safe): Remove.
9264         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9265         * jit.c (jit_inferior_exit_hook): Update.
9266
9267 2019-01-17  Tom Tromey  <tom@tromey.com>
9268
9269         * progspace.h (program_space) <objfiles_range>: New typedef.
9270         <objfiles>: New method.
9271         <objfiles_head>: Rename from objfiles.
9272         (object_files): Update.
9273         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9274         * guile/scm-pretty-print.c
9275         (ppscm_find_pretty_printer_from_objfiles): Update.
9276         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9277         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9278         Update.
9279         * python/py-progspace.c (pspy_get_objfiles): Update.
9280         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9281         Update.
9282         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9283         (objfpy_lookup_objfile_by_build_id): Update.
9284         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9285         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9286         Update.
9287         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9288         (expand_symtab_containing_pc, lookup_objfile_from_block)
9289         (lookup_static_symbol, basic_lookup_transparent_type)
9290         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9291         (find_line_symtab, info_sources_command)
9292         (default_collect_symbol_completion_matches_break_on)
9293         (make_source_files_completion_list, find_main_name): Update.
9294         * symmisc.c (print_symbol_bcache_statistics)
9295         (print_objfile_statistics, maintenance_print_symbols)
9296         (maintenance_print_msymbols, maintenance_print_objfiles)
9297         (maintenance_info_symtabs, maintenance_check_symtabs)
9298         (maintenance_expand_symtabs, maintenance_info_line_tables):
9299         Update.
9300         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9301         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9302         (map_overlay_command, unmap_overlay_command)
9303         (simple_overlay_update, expand_symtabs_matching)
9304         (map_symbol_filenames): Update.
9305         * symfile-debug.c (set_debug_symfile): Update.
9306         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9307         Update.
9308         * source.c (select_source_symtab, forget_cached_source_info):
9309         Update.
9310         * solib.c (solib_read_symbols): Update.
9311         * solib-spu.c (append_ocl_sos): Update.
9312         * psymtab.c (maintenance_print_psymbols)
9313         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9314         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9315         * printcmd.c (info_symbol_command): Update.
9316         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9317         Update.
9318         * objfiles.h (class all_objfiles): Remove.
9319         * objfiles.c (have_partial_symbols, have_full_symbols)
9320         (have_minimal_symbols, qsort_cmp, update_section_map)
9321         (shared_objfile_contains_address_p)
9322         (default_iterate_over_objfiles_in_search_order): Update.
9323         * objc-lang.c (info_selectors_command, info_classes_command)
9324         (find_methods): Update.
9325         * minsyms.c (find_solib_trampoline_target): Update.
9326         * maint.c (maintenance_info_sections)
9327         (maintenance_translate_address, count_symtabs_and_blocks):
9328         Update.
9329         * main.c (captured_main_1): Update.
9330         * linux-thread-db.c (try_thread_db_load_from_pdir)
9331         (has_libpthread): Update.
9332         * linespec.c (iterate_over_all_matching_symtabs)
9333         (search_minsyms_for_name): Update.
9334         * jit.c (jit_find_objf_with_entry_addr): Update.
9335         * hppa-tdep.c (find_unwind_entry)
9336         (hppa_lookup_stub_minimal_symbol): Update.
9337         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9338         Update.
9339         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9340         (elf_gnu_ifunc_resolve_by_got): Update.
9341         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9342         * dwarf-index-write.c (save_gdb_index_command): Update.
9343         * cp-support.c (add_symbol_overload_list_qualified): Update.
9344         * breakpoint.c (create_overlay_event_breakpoint)
9345         (create_longjmp_master_breakpoint)
9346         (create_std_terminate_master_breakpoint)
9347         (create_exception_master_breakpoint): Update.
9348         * blockframe.c (find_pc_partial_function): Update.
9349         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9350         (ada_collect_symbol_completion_matches)
9351         (ada_add_global_exceptions): Update.
9352
9353 2019-01-17  Tom Tromey  <tom@tromey.com>
9354
9355         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9356         declare VEC.
9357         (solib_target_parse_libraries): Change return type.
9358         (library_list_start_segment, library_list_start_section)
9359         (library_list_end_library, library_list_start_library); Update.
9360         (solib_target_free_library_list): Remove.
9361         (solib_target_parse_libraries): Remove cleanup.  Change return
9362         type.
9363         (solib_target_current_sos): Update.
9364
9365 2019-01-17  Tom Tromey  <tromey@bapiya>
9366
9367         * valprint.c: Replace "the the" with "the".
9368         * symtab.c: Replace "the the" with "the".
9369         * solib.c: Replace "the the" with "the".
9370         * solib-dsbt.c: Replace "the the" with "the".
9371         * linespec.c: Replace "the the" with "the".
9372         * dwarf2loc.h: Replace "the the" with "the".
9373         * amd64-windows-tdep.c: Replace "the the" with "the".
9374         * aarch64-tdep.c: Replace "the the" with "the".
9375
9376 2019-01-16  Keith Seitz  <keiths@redhat.com>
9377
9378         PR gdb/23773
9379         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9380         <builder>: Rename to ..
9381         <m_builder>: ... this and make private.
9382         (dwarf2_cu::get_builder): New method.  Change all users of
9383         `builder' to use this method.
9384         (dwarf2_start_symtab): Move to ...
9385         (dwarf2_cu::start_symtab): ... here.  Update all callers
9386         (setup_type_unit_groups): Move to ...
9387         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9388         callers.
9389         (dwarf2_cu::reset_builder): New method.
9390         (process_full_compunit, process_full_type_unit): Use
9391         dwarf2_cu::reset_builder.
9392         (follow_die_offset): Record the ancestor CU if it is different
9393         from the followed DIE's CU.
9394         (follow_die_sig_1): Likewise.
9395
9396 2019-01-15  Tom Tromey  <tom@tromey.com>
9397
9398         * remote.c (class remote_state) <buf>: Now a char_vector.
9399         <buf_size>: Remove.
9400         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9401         parameter.
9402         (remote_target::getpkt_or_notif_sane_1)
9403         (remote_target::getpkt_sane)
9404         (remote_target::getpkt_or_notif_sane): Likewise.
9405         (class remote_target) <putpkt>: New overload.
9406         (remote_target::read_frame): Change type of "buf_p".  Remove
9407         sizeof_p parameter.
9408         (packet_ok): New overload.
9409         (packet_check_result): New overload.
9410         Update all uses.
9411
9412 2019-01-14  Tom Tromey  <tom@tromey.com>
9413
9414         * remote-notif.c (handle_notification, remote_notif_ack)
9415         (remote_notif_parse): Make "buf" const.
9416         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9417         const.
9418         (remote_notif_parse, remote_notif_ack, handle_notification):
9419         Likewise.
9420         * remote.c (remote_notif_stop_parse): Make "buf" const.
9421         (remote_target::remote_parse_stop_reply): Make "buf" const.
9422         (remote_notif_stop_ack): Make "buf" const.
9423
9424 2019-01-14  Tom Tromey  <tom@tromey.com>
9425
9426         * remote.c (remote_console_output): Make parameter const.
9427
9428 2019-01-14  Tom Tromey  <tom@tromey.com>
9429
9430         * target-debug.h (target_debug_print_signals): Constify.
9431         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9432         * procfs.c (procfs_target::pass_signals): Update.
9433         * linux-nat.c (linux_nat_target::pass_signals): Update.
9434         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9435         * target-delegates.c: Rebuild.
9436         * remote.c (remote_target::program_signals): Update.
9437         (remote_target::pass_signals): Update.
9438         * target.c (target_pass_signals): Constify argument.
9439         (target_program_signals): Likewise.
9440         * target.h (struct target_ops) <pass_signals, program_signals>:
9441         Constify argument.
9442         (target_pass_signals, target_program_signals): Constify argument.
9443
9444 2019-01-14  Tom Tromey  <tom@tromey.com>
9445
9446         PR tui/28819:
9447         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9448
9449 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9450
9451         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9452         field.
9453         * rs6000-tdep.c: Include reggroups.h.
9454         (IS_V_ALIAS_PSEUDOREG): Define.
9455         (rs6000_register_name): Return names for the "vX" aliases.
9456         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9457         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9458         aliases.  Call default_register_reggroup_p for all other
9459         pseudo-registers.
9460         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9461         New functions.
9462         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9463         Handle "vX" aliases.
9464         (v_alias_pseudo_register_collect): New function.
9465         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9466         (rs6000_gdbarch_init): Initialize "vX" aliases as
9467         pseudo-registers.  Restore registration of
9468         rs6000_pseudo_register_reggroup_p with
9469         set_tdesc_pseudo_register_reggroup_p.
9470
9471 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9472
9473         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9474         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9475         set_gdbarch_num_pseudo_regs.
9476
9477 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9478
9479         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9480         Remove arg prefixname, add do_set and do_show.
9481         Add member functions set_list and show_list.
9482         * cli/cli-style.c (class cli_style_option): Update accordingly.
9483         (style_set_list): Move to file scope.
9484         (style_show_list): Likewise.
9485         (set_style): Call help_list.
9486         (show_style): Call cmd_show_list.
9487         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9488         Update to use the new macro.
9489
9490 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9491
9492         * ada-lang.c (_initialize_ada_language): Expand the help text
9493         for the "catch exception" command.
9494
9495 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9496
9497         * symtab.c (matching_obj_sections): Initialize obj,
9498         declare it closer to its usage.
9499
9500 2019-01-10  Tom Tromey  <tom@tromey.com>
9501
9502         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9503         (basic_inf_threads_range): Remove.
9504         (inf_threads_range, inf_non_exited_threads_range)
9505         (safe_inf_threads_range): Use next_adapter.
9506
9507 2019-01-10  Keith Seitz  <keiths@redhat.com>
9508
9509         PR gdb/23712
9510         PR symtab/23010
9511         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9512         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9513
9514 2019-01-10  Keith Seitz  <keiths@redhat.com>
9515
9516         PR gdb/23712
9517         PR symtab/23010
9518         * dictionary.c (pending_to_vector): Remove.
9519         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9520         Remove _1 suffix, replacing functions of the same name.  Update
9521         all callers.
9522         (dict_create_hashed, dict_create_hashed_expandable)
9523         (dict_create_linear, dict_create_linear_expandable, dict_free)
9524         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9525         Make functions static.
9526
9527 2019-01-10  Keith Seitz  <keiths@redhat.com>
9528
9529         PR gdb/23712
9530         PR symtab/23010
9531         * dictionary.h (struct dictionary): Replace declaration with
9532         multidictionary.
9533         (dict_create_hashed, dict_create_hashed_expandable)
9534         (dict_create_linear, dict_create_linear_expandable)
9535         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9536         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9537         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9538         taking multidictionary argument.
9539         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9540         * block.h (struct block) <dict>: Change to multidictionary
9541         and rename `multidict'.
9542         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9543         symmisc.c: Update all dictionary references to multidictionary.
9544
9545 2019-01-10  Keith Seitz  <keiths@redhat.com>
9546
9547         PR gdb/23712
9548         PR symtab/23010
9549         * dictionary.c: Include unordered_map.
9550         (pending_to_vector): New function.
9551         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9552         Rewrite the non-"_1" functions to take vector instead
9553         of linked list.
9554         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9555         "new" _1 versions of the same name.
9556         (multidictionary): Define.
9557         (std::hash<enum language): New definition.
9558         (collate_pending_symbols_by_language, mdict_create_hashed)
9559         (mdict_create_hashed_expandable, mdict_create_linear)
9560         (mdict_create_linear_expandable, mdict_free)
9561         (find_language_dictionary, create_new_language_dictionary)
9562         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9563         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9564         (mdict_size, mdict_empty): New functions.
9565         * dictionary.h (mdict_iterator): Define.
9566
9567 2019-01-10  Pedro Alves  <palves@redhat.com>
9568
9569         * breakpoint.c (read_uploaded_action)
9570         (create_tracepoint_from_upload): Adjust to use
9571         gdb::unique_xmalloc_ptr.
9572         * ctf.c (ctf_write_uploaded_tp):
9573         (SET_ARRAY_FIELD): Use emplace_back.
9574         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9575         * tracefile-tfile.c (tfile_write_uploaded_tp):
9576         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9577         gdb::unique_xmalloc_ptr.
9578         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9579         at_string, cond_string, cmd_strings>: Replace char pointers
9580         with gdb::unique_xmalloc_ptr.
9581
9582 2019-01-10  Pedro Alves  <palves@redhat.com>
9583
9584         * solib-target.c (library_list_start_library): Don't xstrdup name.
9585
9586 2019-01-10  Pedro Alves  <palves@redhat.com>
9587
9588         * mdebugread.c (parse_partial_symbols): Use
9589         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9590
9591 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9592
9593         * linux-fork.c (scoped_switch_fork_info)
9594         <~scoped_switch_fork_info>: Fix incorrect variable name.
9595
9596 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9597
9598         * linux-fork.c (scoped_switch_fork_info)
9599         <scoped_switch_fork_info>: Make explicit.
9600         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9601
9602 2019-01-10  Tom Tromey  <tom@tromey.com>
9603
9604         * objfiles.h (objfile::reset_psymtabs): Update.
9605         * objfiles.c (objfile::objfile): Update.
9606         * psymtab.h (psymtab_storage::obstack): Update.
9607         (psymtab_storage::m_obstack): Use gdb::optional.
9608         (class psymtab_storage): Update comment.  Remove objfile
9609         parameter.
9610         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9611
9612 2019-01-10  Tom Tromey  <tom@tromey.com>
9613
9614         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9615         <free_psymtabs>: Now private.
9616         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9617         (allocate_psymtab): Use new method.
9618
9619 2019-01-10  Tom Tromey  <tom@tromey.com>
9620
9621         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9622         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9623         * mdebugread.c (parse_partial_symbols): Use
9624         allocate_dependencies.
9625         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9626         allocate_dependencies.
9627         (process_psymtab_comp_unit_reader)
9628         (build_type_psymtab_dependencies): Likewise.
9629         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9630
9631 2019-01-10  Tom Tromey  <tom@tromey.com>
9632
9633         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9634         PSYMBOL_SET_LANGUAGE.
9635         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9636
9637 2019-01-10  Tom Tromey  <tom@tromey.com>
9638
9639         * psymtab.h (psymtab_storage::obstack): New method.
9640         <m_obstack>: Rename from obstack; now private.
9641         * psymtab.c (psymtab_storage): Update.
9642         * dwarf2read.c (create_addrmap_from_index)
9643         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9644         Update.
9645
9646 2019-01-10  Tom Tromey  <tom@tromey.com>
9647
9648         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9649         * objfiles.h (objfile::reset_psymtabs): New method.
9650
9651 2019-01-10  Tom Tromey  <tom@tromey.com>
9652
9653         * symmisc.c (print_symbol_bcache_statistics): Update.
9654         (print_objfile_statistics): Update.
9655         * symfile.c (reread_symbols): Update.
9656         * psymtab.h (class psymtab_storage): New.
9657         * psymtab.c (psymtab_storage): New constructor.
9658         (~psymtab_storage): New destructor.
9659         (require_partial_symbols): Update.
9660         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9661         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9662         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9663         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9664         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9665         (start_psymtab_common, end_psymtab_common)
9666         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9667         (allocate_psymtab): Update.
9668         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9669         Update.
9670         (dump_psymtab_addrmap, maintenance_print_psymbols)
9671         (maintenance_check_psymtabs): Update.
9672         (class objfile_psymtabs): Move to objfiles.h.
9673         * psympriv.h (discard_psymtab): Now inline.
9674         (psymtab_discarder::psymtab_discarder): Update.
9675         (psymtab_discarder::~psymtab_discarder): Update.
9676         (ALL_OBJFILE_PSYMTABS): Rewrite.
9677         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9678         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9679         Remove fields.
9680         <partial_symtabs>: New field.
9681         (class objfile_psymtabs): Move from psymtab.h.  Update.
9682         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9683         psymbol_cache.
9684         (objfile::~objfile): Don't destroy psymbol_cache.
9685         * mdebugread.c (parse_partial_symbols): Update.
9686         * dwarf2read.c (create_addrmap_from_index)
9687         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9688         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9689         (add_partial_subprogram, dwarf2_ranges_read): Update.
9690         * dwarf-index-write.c (write_address_map)
9691         (write_one_signatured_type, recursively_write_psymbols)
9692         (class debug_names, class debug_names, write_psymtabs_to_index):
9693         Update.
9694
9695 2019-01-10  Tom Tromey  <tom@tromey.com>
9696
9697         * symtab.h (SYMBOL_SET_NAMES): Update.
9698         (symbol_set_names): Update.
9699         (MSYMBOL_SET_NAMES): Update.
9700         * symtab.c (symbol_set_names): Change argument to be an
9701         objfile_per_bfd_storage.
9702         * psymtab.c (add_psymbol_to_bcache): Update.
9703         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9704
9705 2019-01-10  Tom Tromey  <tom@tromey.com>
9706
9707         * symtab.c (create_demangled_names_hash): Change argument to be an
9708         objfile_per_bfd_storage.
9709         (symbol_set_names): Update.
9710
9711 2019-01-10  Tom Tromey  <tom@tromey.com>
9712
9713         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9714         init_psymbol_list.
9715         * psymtab.c (init_psymbol_list): Do nothing if already called.
9716         * psympriv.h (init_psymbol_list): Add comment.
9717         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9718         init_psymbol_list.
9719         * dbxread.c (dbx_symfile_read): Unconditionally call
9720         init_psymbol_list.
9721
9722 2019-01-10  Tom Tromey  <tom@tromey.com>
9723
9724         * xcoffread.c (scan_xcoff_symtab): Update.
9725         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9726         "where".
9727         * mdebugread.c (parse_partial_symbols)
9728         (handle_psymbol_enumerators): Update.
9729         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9730         * dbxread.c (read_dbx_symtab): Update.
9731         * psympriv.h (psymbol_placement): New enum.
9732         (add_psymbol_to_list): Update.
9733
9734 2019-01-10  Tom Tromey  <tom@tromey.com>
9735
9736         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9737         static_psymbols parameters.
9738         (scan_xcoff_symtab): Update.
9739         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9740         static_psymbols parameters.
9741         * psympriv.h (start_psymtab_common): Update.
9742         * mdebugread.c (parse_partial_symbols): Update.
9743         * dwarf2read.c (create_partial_symtab): Update.
9744         * dbxread.c (read_dbx_symtab): Update.
9745         (start_psymtab): Remove global_psymbols and static_psymbols
9746         parameters.
9747
9748 2019-01-10  Tom Tromey  <tom@tromey.com>
9749
9750         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9751         * psymtab.c (allocate_psymtab): Add comment.
9752         * psympriv.h (allocate_psymtab): Add comment.
9753         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9754         initializations.
9755         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9756
9757 2019-01-10  Tom Tromey  <tom@tromey.com>
9758
9759         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9760         Don't declare.
9761         * mipsread.c: Include mdebugread.h.
9762         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9763         Declare.
9764         * elfread.c: Include mdebugread.h.
9765
9766 2019-01-09  Tom Tromey  <tom@tromey.com>
9767
9768         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9769         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9770         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9771         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9772         (psym_lookup_symbol, psym_find_last_source_symtab)
9773         (psym_forget_cached_source_info, psym_print_stats)
9774         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9775         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9776         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9777         (psym_find_compunit_symtab_by_address)
9778         (maintenance_print_psymbols, maintenance_info_psymtabs)
9779         (maintenance_check_psymtabs): Use ranged for.
9780         * psymtab.h (class objfile_psymtabs): New.
9781         (require_partial_symbols): Return objfile_psymtabs.
9782         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9783
9784 2019-01-09  Tom Tromey  <tom@tromey.com>
9785
9786         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9787         (find_pc_mapped_section, list_overlays_command)
9788         (map_overlay_command, unmap_overlay_command)
9789         (simple_overlay_update): Use all_objfiles.
9790         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9791         * printcmd.c (info_symbol_command): Use all_objfiles.
9792         * objfiles.h (ALL_OBJSECTIONS): Remove.
9793         * maint.c (maintenance_translate_address): Use all_objfiles.
9794         * gcore.c (gcore_create_callback): Use all_objfiles.
9795         (objfile_find_memory_regions): Likewise.
9796
9797 2019-01-09  Tom Tromey  <tom@tromey.com>
9798
9799         * symtab.c (find_line_symtab, info_sources_command)
9800         (make_source_files_completion_list): Use objfile_compunits.
9801         * source.c (select_source_symtab): Use objfile_compunits.
9802         * objfiles.h (struct objfile): Update comment.
9803         (ALL_OBJFILES): Remove.
9804         (ALL_FILETABS): Remove.
9805         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9806         objfile_compunits.
9807
9808 2019-01-09  Tom Tromey  <tom@tromey.com>
9809
9810         * symmisc.c (print_objfile_statistics, dump_objfile)
9811         (maintenance_print_symbols): Use compunit_filetabs.
9812         * source.c (forget_cached_source_info_for_objfile): Use
9813         compunit_filetabs.
9814         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9815         (ALL_FILETABS): Use compunit_filetabs.
9816         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9817         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9818
9819 2019-01-09  Tom Tromey  <tom@tromey.com>
9820
9821         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9822         (compunit_filetabs): New.
9823         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9824         compunit_filetabs.
9825         (info_sources_command, make_source_files_completion_list): Remove
9826         declaration.
9827         * symmisc.c (print_objfile_statistics, dump_objfile)
9828         (maintenance_print_symbols): Remove declaration.
9829         (maintenance_info_symtabs): Use compunit_filetabs.
9830         (maintenance_info_line_tables): Likewise.
9831         * source.c (select_source_symtab): Change local variable name.
9832         (forget_cached_source_info_for_objfile): Remove declaration.
9833         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9834         * objfiles.c (objfile_relocate1): Remove declaration.
9835         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9836         declaration.
9837         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9838         * coffread.c (coff_symtab_read): Remove declaration.
9839         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9840         compunit_filetabs.
9841
9842 2019-01-09  Tom Tromey  <tom@tromey.com>
9843
9844         * symtab.c (lookup_objfile_from_block)
9845         (find_pc_sect_compunit_symtab, search_symbols)
9846         (default_collect_symbol_completion_matches_break_on): Use
9847         objfile_compunits.
9848         * objfiles.h (ALL_COMPUNITS): Remove.
9849         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9850         * cp-support.c (add_symbol_overload_list_qualified): Use
9851         objfile_compunits.
9852         * ada-lang.c (ada_collect_symbol_completion_matches)
9853         (ada_add_global_exceptions): Use objfile_compunits.
9854
9855 2019-01-09  Tom Tromey  <tom@tromey.com>
9856
9857         * source.c (select_source_symtab)
9858         (forget_cached_source_info_for_objfile): Remove declaration.
9859         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9860         declaration.
9861         * maint.c (count_symtabs_and_blocks): Remove declaration.
9862         * cp-support.c (add_symbol_overload_list_qualified): Remove
9863         declaration.
9864         * coffread.c (coff_symtab_read): Remove declaration.
9865         * symtab.c (lookup_symbol_in_objfile_symtabs)
9866         (basic_lookup_transparent_type_1): Use objfile_compunits.
9867         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9868         (info_sources_command, search_symbols)
9869         (default_collect_symbol_completion_matches_break_on)
9870         (make_source_files_completion_list): Remove declaration.
9871         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9872         (ada_collect_symbol_completion_matches)
9873         (ada_add_global_exceptions): Remove declaration.
9874         * linespec.c (iterate_over_all_matching_symtabs): Use
9875         objfile_compunits.
9876         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9877         (class objfile_compunits): New.
9878         (ALL_COMPUNITS): Use objfile_compunits.
9879         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9880         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9881         objfile_compunits.
9882         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9883
9884 2019-01-09  Tom Tromey  <tom@tromey.com>
9885
9886         * symtab.c (search_symbols)
9887         (default_collect_symbol_completion_matches_break_on): Use
9888         objfile_msymbols.
9889         * ada-lang.c (ada_lookup_simple_minsym)
9890         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9891         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9892         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9893         objfile_msymbols.
9894         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9895         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9896         * objc-lang.c (find_methods): Use objfile_msymbols.
9897         (info_selectors_command, info_classes_command): Likewise.
9898         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9899         * objfiles.h (class objfile_msymbols): New.
9900         (ALL_OBJFILE_MSYMBOLS): Remove.
9901         (ALL_MSYMBOLS): Remove.
9902
9903 2019-01-09  Tom Tromey  <tom@tromey.com>
9904
9905         * common/next-iterator.h (next_adapter): Add Iterator template
9906         parameter.
9907         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9908         (class all_objfiles_safe): New.
9909         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9910         * objfiles.c (put_objfile_before): Update comment.
9911         (add_separate_debug_objfile): Likewise.
9912         (free_all_objfiles): Use all_objfiles_safe.
9913         (objfile_purge_solibs): Likewise.
9914
9915 2019-01-09  Tom Tromey  <tom@tromey.com>
9916
9917         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9918         (expand_symtab_containing_pc, lookup_static_symbol)
9919         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9920         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9921         all_objfiles.
9922         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9923         * breakpoint.c (create_overlay_event_breakpoint)
9924         (create_longjmp_master_breakpoint)
9925         (create_std_terminate_master_breakpoint)
9926         (create_exception_master_breakpoint): Use all_objfiles.
9927         * linux-thread-db.c (try_thread_db_load_from_pdir)
9928         (has_libpthread): Use all_objfiles.
9929         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9930         * linespec.c (iterate_over_all_matching_symtabs)
9931         (search_minsyms_for_name): Use all_objfiles.
9932         * maint.c (maintenance_info_sections): Use all_objfiles.
9933         * main.c (captured_main_1): Use all_objfiles.
9934         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9935         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9936         * guile/scm-pretty-print.c
9937         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9938         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9939         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9940         (maintenance_print_msymbols): Use all_objfiles.
9941         * source.c (select_source_symtab): Use all_objfiles.
9942         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9943         * symfile.c (remove_symbol_file_command)
9944         (expand_symtabs_matching, map_symbol_filenames): Use
9945         all_objfiles.
9946         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9947         all_objfiles.
9948         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9949         * objc-lang.c (find_methods): Use all_objfiles.
9950         * objfiles.c (have_partial_symbols, have_full_symbols)
9951         (have_minimal_symbols, qsort_cmp)
9952         (default_iterate_over_objfiles_in_search_order): Use
9953         all_objfiles.
9954         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9955         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9956         (maintenance_check_psymtabs): Use all_objfiles.
9957         (ALL_PSYMTABS): Remove.
9958         * compile/compile-object-run.c (do_module_cleanup): Use
9959         all_objfiles.
9960         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9961         * cp-support.c (add_symbol_overload_list_qualified): Use
9962         all_objfiles.
9963         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9964         Use all_objfiles.
9965         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9966         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9967         all_objfiles.
9968         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9969         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9970         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9971         Uses all_objfiles.
9972         * solib.c (solib_read_symbols): Use all_objfiles
9973
9974 2019-01-09  Tom Tromey  <tom@tromey.com>
9975
9976         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9977         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9978         all_objfiles.
9979         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9980         * symmisc.c (print_symbol_bcache_statistics)
9981         (print_objfile_statistics, maintenance_print_objfiles)
9982         (maintenance_info_symtabs, maintenance_check_symtabs)
9983         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9984         all_objfiles.
9985         * source.c (forget_cached_source_info): Use all_objfiles.
9986         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9987         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9988         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9989         * objfiles.c (update_section_map): Use all_objfiles.
9990         (shared_objfile_contains_address_p): Likewise.
9991         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9992         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9993
9994 2019-01-09  Tom Tromey  <tom@tromey.com>
9995
9996         * common/next-iterator.h: New file.
9997         * objfiles.h (class all_objfiles): New.
9998         (struct objfile_iterator): New.
9999
10000 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10001
10002         * NEWS: Move the description of the changed "frame", "select-frame",
10003          and "info frame" commands to the Changed commands section.
10004
10005 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10006
10007         * gdbtypes.c (check_stub_method_group): Remove handling of old
10008         mangling schemes.
10009         * linespec.c (find_methods): Likewise.
10010         * stabsread.c (read_member_functions): Likewise.
10011         * valops.c (search_struct_method): Likewise.
10012         (value_struct_elt_for_reference): Likewise.
10013         * NEWS: Mention this change.
10014
10015 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10016
10017         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10018         print_source_lines.
10019         * source.c (print_source_lines_base): Update line number check.
10020         (print_source_lines): New function.
10021         (source_lines_range::source_lines_range): New function.
10022         * source.h (class source_lines_range): New class.
10023         (print_source_lines): New declaration.
10024
10025 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10026
10027         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10028
10029 2019-01-08  Tom Tromey  <tom@tromey.com>
10030             Simon Marchi  <simon.marchi@ericsson.com>
10031
10032         PR gdb/24060
10033         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10034         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10035         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10036         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10037         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10038         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10039
10040 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10041
10042         * source.c (select_source_symtab): Move header comment to
10043         declaration in source.h.
10044         (forget_cached_source_info_for_objfile): Likewise.
10045         (forget_cached_source_info): Likewise.
10046         (identify_source_line): Likewise.
10047         * source.h (identify_source_line): Move declaration from symtab.h
10048         and add comment from source.c
10049         (print_source_lines): Likewise.
10050         (forget_cached_source_info_for_objfile): Likewise.
10051         (forget_cached_source_info): Likewise.
10052         (select_source_symtab): Likewise.
10053         (enum print_source_lines_flag): Move definition from symtab.h.
10054         * symtab.h (identify_source_line): Move declaration to source.h.
10055         (print_source_lines): Likewise.
10056         (forget_cached_source_info_for_objfile): Likewise.
10057         (forget_cached_source_info): Likewise.
10058         (select_source_symtab): Likewise.
10059         (enum print_source_lines_flag): Move definition to source.h.
10060         * tui/tui-hooks.c: Add 'source.h' include.
10061
10062 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10063
10064         * source.c (print_source_lines_base): Handle requests to print
10065         reverse line number sequences, and guard against empty lines
10066         string.
10067
10068 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10069
10070         * source.c (print_source_lines_base): Fix skip of '\r' if next
10071         character is '\n'.
10072
10073 2019-01-06  Tom Tromey  <tom@tromey.com>
10074
10075         * c-exp.y (struct c_parse_state) <macro_original_text,
10076         expansion_obstack>: New member.
10077         (macro_original_text, expansion_obstack): Remove globals.
10078         (scan_macro_expansion, scanning_macro_expansion)
10079         (finished_macro_expansion): Update.
10080         (scan_macro_cleanup): Remove.
10081         (yylex, c_parse): Update.
10082
10083 2019-01-06  Tom Tromey  <tom@tromey.com>
10084
10085         * c-exp.y (struct c_parse_state) <strings>: New member.
10086         (operator_stoken): Update.
10087
10088 2019-01-06  Tom Tromey  <tom@tromey.com>
10089
10090         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10091         (union type_stack_elt) <typelist_val>: Now a pointer to
10092         std::vector.
10093         (type_stack_cleanup): Don't declare.
10094         (push_typelist): Update.
10095         * parse.c (pop_typelist): Return a std::vector.
10096         (push_typelist): Take a std::vector.
10097         (follow_types): Update.  Do not free args.
10098         (type_stack_cleanup): Remove.
10099         * c-exp.y (struct c_parse_state): New.
10100         (cpstate): New global.
10101         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10102         (nonempty_typelist): Update.
10103         (func_mod): Create a new vector.
10104         (c_parse): Create a c_parse_state.
10105         (check_parameter_typelist): Do not delete params.
10106         (function_method): Update.  Do not delete type_list.
10107
10108 2019-01-06  Tom Tromey  <tom@tromey.com>
10109
10110         PR gdb/28155:
10111         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10112         check_typedef.
10113         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10114         (print_return_value): Likewise.
10115
10116 2019-01-05  Tom Tromey  <tom@tromey.com>
10117
10118         * contrib/cleanup_check.py: Remove.
10119         * contrib/gcc-with-excheck: Remove.
10120         * contrib/exsummary.py: Remove.
10121         * contrib/excheck.py: Remove.
10122
10123 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10124
10125         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10126         NULL. Initialize tpprev to NULL instead of assigning it
10127         to NULL on the next statement.
10128         * windows-nat.c (windows_delete_thread): Remove check for
10129         main_thread_id before printing thread exit notifications.
10130         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10131         Remove thread ID check against main_thread_id.
10132         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10133         windows_delete_thread.
10134         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10135
10136 2019-01-04  Tom Tromey  <tom@tromey.com>
10137
10138         * compile/compile.c (_initialize_compile): Use upper case for
10139         metasyntactic variables.
10140         * symmisc.c (_initialize_symmisc): Use upper case for
10141         metasyntactic variables.
10142         * psymtab.c (_initialize_psymtab): Use upper case for
10143         metasyntactic variables.
10144         * demangle.c (demangle_command): Use upper case for metasyntactic
10145         variables.
10146         (_initialize_demangler): Likewise.
10147         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10148         variables.
10149
10150 2019-01-03  Tom Tromey  <tom@tromey.com>
10151
10152         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10153
10154 2019-01-03  Tom Tromey  <tom@tromey.com>
10155
10156         * python/py-symtab.c (salpy_str): Update.
10157         (struct salpy_sal_object) <symtab>: Now a PyObject.
10158         (salpy_dealloc): Update.
10159         (del_objfile_sal): Use gdbpy_ref.
10160
10161 2019-01-03  Tom Tromey  <tom@tromey.com>
10162
10163         * python/py-type.c (convert_field): Use new_reference.  Return
10164         gdbpy_ref.
10165         (make_fielditem): Return gdbpy_ref.
10166         (typy_fields): Update.
10167         (typy_getitem): Update.
10168         (field_name): Return gdbpy_ref.  Use new_reference.
10169         (typy_iterator_iternext): Update.
10170
10171 2019-01-03  Tom Tromey  <tom@tromey.com>
10172
10173         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10174
10175 2019-01-03  Tom Tromey  <tom@tromey.com>
10176
10177         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10178         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10179         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10180         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10181         (pspy_set_type_printers): Likewise.
10182         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10183         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10184         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10185         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10186         (objfpy_set_type_printers): Likewise.
10187
10188 2019-01-03  Tom Tromey  <tom@tromey.com>
10189
10190         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10191         (gdbpy_print_stack): Use gdbpy_err_fetch.
10192         * python/python-internal.h (class gdbpy_err_fetch): New class.
10193         (class gdbpy_enter) <m_error_type, m_error_value,
10194         m_error_traceback>: Remove.
10195         <m_error>: New member.
10196         (gdbpy_exception_to_string): Don't declare.
10197         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10198         * python/py-value.c (convert_value_from_python): Use
10199         gdbpy_err_fetch.
10200         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10201         gdbpy_exception_to_string.
10202         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10203         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10204         gdbpy_err_fetch.
10205
10206 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10207
10208         * linux-nat.c (delete_lwp_cleanup): Delete.
10209         (struct lwp_deleter): New struct.
10210         (lwp_info_up): New typedef.
10211         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10212         lwp_info_up.
10213
10214 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10215
10216         * linux-fork.c (class scoped_switch_fork_info): New class.
10217         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10218
10219 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10220
10221         * valops.c (find_overload_match): Remove use of null_cleanup, and
10222         calls to do_cleanups.
10223
10224 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10225
10226         * compile/compile-cplus-types.c
10227         (compile_cplus_instance::decl_name): Handle changes to
10228         cp_func_name.
10229         * cp-support.c (cp_func_name): Update header comment, update
10230         return type.
10231         * cp-support.h (cp_func_name): Update return type in declaration.
10232         * valops.c (find_overload_match): Move temp_func local to top
10233         level of function and change its type.  Use temp_func to hold and
10234         delete temporary string obtained from cp_func_name.
10235
10236 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10237
10238         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10239         gdb::char_vector, remove cleanup, and update uses of `msg`.
10240
10241 2019-01-03  Jim Wilson  <jimw@sifive.com>
10242
10243         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10244
10245 2019-01-02  Tom Tromey  <tom@tromey.com>
10246
10247         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10248         (tdesc_parse_xml): Remove cleanups.
10249         * target-descriptions.h (make_cleanup_free_target_description):
10250         Don't declare.
10251         (target_desc_deleter): New struct.
10252         (target_desc_up): New typedef.
10253         * target-descriptions.c (target_desc_deleter::operator()): Rename
10254         from free_target_description.
10255         (make_cleanup_free_target_description): Remove.
10256
10257 2019-01-02  Tom Tromey  <tom@tromey.com>
10258
10259         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10260         constructor, destructor.
10261         (linespec_parser): Remove typedef.
10262         (~linespec_parser): Rename from linespec_parser_delete.
10263         (linespec_lex_to_end, linespec_complete_label)
10264         (linespec_complete): Update.
10265         (decode_line_full): Remove cleanups.
10266         (decode_line_1): Update.
10267
10268 2019-01-02  Tom Tromey  <tom@tromey.com>
10269
10270         * python/python-internal.h (inferior_to_inferior_object): Change
10271         return type.
10272         * python/py-exitedevent.c (create_exited_event_object): Update.
10273         * python/py-inferior.c (inferior_to_inferior_object): Return
10274         gdbpy_ref.
10275         (python_new_inferior, python_inferior_deleted)
10276         (thread_to_thread_object, delete_thread_object)
10277         (build_inferior_list, gdbpy_selected_inferior): Update.
10278         * python/py-infthread.c (create_thread_object): Update.  Also fail
10279         if inferior_to_inferior_object fails.
10280
10281 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10282
10283         * inferior.h (class inferior) <displaced_step_state>: New field.
10284         * infrun.h (struct displaced_step_state): Move here from
10285         infrun.c.  Initialize fields, add constructor.
10286         <inf>: Remove field.
10287         <reset>: New method.
10288         * infrun.c (struct displaced_step_inferior_state): Move to
10289         infrun.h.
10290         (displaced_step_inferior_states): Remove.
10291         (get_displaced_stepping_state): Adust.
10292         (displaced_step_in_progress_any_inferior): Adjust.
10293         (displaced_step_in_progress_thread): Adjust.
10294         (displaced_step_in_progress): Adjust.
10295         (add_displaced_stepping_state): Remove.
10296         (get_displaced_step_closure_by_addr): Adjust.
10297         (remove_displaced_stepping_state): Remove.
10298         (infrun_inferior_exit): Call displaced_step_state.reset.
10299         (use_displaced_stepping): Don't check for NULL.
10300         (displaced_step_prepare_throw): Call
10301         get_displaced_stepping_state.
10302         (displaced_step_fixup): Don't check for NULL.
10303         (prepare_for_detach): Don't check for NULL.
10304
10305 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10306
10307         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10308          in case of call that did not complete.
10309
10310 2019-01-02  Andrey Utkin  <autkin@undo.io>
10311
10312         * symfile.c (find_separate_debug_file): Fix search of debug files for
10313         remote debuggee.
10314
10315 2019-01-02  Tom Tromey  <tom@tromey.com>
10316
10317         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10318         indentation.
10319         * python/py-frame.c (frapy_older): Remove cast.
10320         (frapy_newer): Likewise.
10321         * python/py-breakpoint.c (local_setattro): Remove cast.
10322         * python/py-arch.c (archpy_name): Remove local variable.
10323         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10324
10325 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10326
10327         * unittests/basic_string_view/element_access/char/empty.cc:
10328         Fix year range in copyright header.
10329
10330 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10331
10332         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10333         Delete.
10334         <operator==>: Update with for removed field.
10335         <hash>: Likewise.
10336         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10337         <isa_features>: ...this.
10338         <abi_features>: New field.
10339         (riscv_isa_flen): Update comment.
10340         (riscv_abi_xlen): New declaration.
10341         (riscv_abi_flen): New declaration.
10342         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10343         isa_features.
10344         (riscv_abi_xlen): New function.
10345         (riscv_isa_flen): Update to get answer from isa_features.
10346         (riscv_abi_flen): New function.
10347         (riscv_has_fp_abi): Update to get answer from abi_features.
10348         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10349         xlen and flen.
10350         (riscv_call_info) <xlen, flen>: Update comment.
10351         (riscv_call_arg_struct): Remove invalid assertions
10352         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10353         is removed.
10354         (riscv_gdbarch_init): Gather isa features and abi features
10355         separately, ensure both match on the gdbarch when reusing an old
10356         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10357         a target with 64-bit float hardware.
10358
10359 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10360
10361         * source.c (search_command_helper): Stop reverse search
10362         when line 1 has been searched.
10363
10364 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10365
10366         * record-full.c (record_full_base_target::close): Rewrite
10367         record_full_core_buf_list free logic.
10368
10369 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10370
10371         * break-catch-syscall.c (print_one_catch_syscall): xfree
10372         the last text.
10373
10374 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10375
10376         * top.c (print_gdb_version): Update Copyright year in version
10377         message.
10378
10379 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10380
10381         Update copyright year range in all GDB files.
10382
10383 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10384
10385         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10386
10387 For older changes see ChangeLog-2018.
10388 \f
10389 Local Variables:
10390 mode: change-log
10391 left-margin: 8
10392 fill-column: 74
10393 version-control: never
10394 coding: utf-8
10395 End:
10396