gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.c (tui_get_register): Return void.
   4
   5 2019-07-17  Tom Tromey  <tom@tromey.com>
   6
   7         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
   8         Simplify.
   9
  10 2019-07-17  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-layout.c (show_source_disasm_command): Simplify window
  13         resetting.
  14
  15 2019-07-17  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui.h (tui_set_layout_by_name): Don't declare.
  18         * tui/tui-regs.c (tui_reg_layout): New function.
  19         (tui_show_registers, tui_reg_command): Use it.
  20         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
  21         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
  22         parameters.
  23         (tui_layout_command): Remove.
  24
  25 2019-07-17  Tom Tromey  <tom@tromey.com>
  26
  27         * tui/tui-layout.h (tui/tui-layout): Return void.
  28         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
  29
  30 2019-07-17  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-layout.c (show_source_disasm_command, show_data):
  33         Update.
  34         (reset_locator): Remove.
  35         (show_source_or_disasm_and_command): Update.
  36
  37 2019-07-17  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-source.c (tui_source_window_base::reset): Remove
  40         win_type parameter.
  41         * tui/tui-layout.c (make_command_window, make_source_window)
  42         (make_disasm_window, make_data_window)
  43         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
  44         (reset_locator, show_source_or_disasm_and_command): Update.
  45         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  46         win_type parameter.
  47         (struct tui_source_window_base) <reset>: Likewise.
  48
  49 2019-07-17  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-layout.c (show_source_disasm_command): Use
  52         reset_locator.
  53         (reset_locator): New function.
  54         (init_and_make_win): Remove.
  55         (show_source_or_disasm_and_command): Use reset_locator.
  56
  57 2019-07-17  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  60         condition.
  61         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
  62         Remove condition.
  63         * tui/tui-source.c (tui_source_window_base::reset): New method.
  64         * tui/tui-layout.c (make_command_window): Don't call
  65         init_and_make_win.
  66         (make_source_window, make_disasm_window): Don't call
  67         make_source_or_disasm_window.
  68         (make_data_window): Don't call init_and_make_win.  Change calling
  69         convention.
  70         (show_source_disasm_command, show_data): Simplify.
  71         (make_source_or_disasm_window): Remove.
  72         (show_source_or_disasm_and_command): Simplify.
  73         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  74         (struct tui_source_window_base) <reset>: Likewise.
  75         <execution_info>: Remove initializer.
  76         * tui/tui-data.c (tui_source_window_base): Initialize
  77         execution_info.
  78
  79 2019-07-17  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
  82         variable.
  83
  84 2019-07-17  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui.c (tui_rl_other_window): Update.
  87         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
  88         superclass method first.  Always iterate over regs_content.
  89         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
  90         method.
  91         * tui/tui-win.c (tui_set_focus_command): Update.
  92
  93 2019-07-17  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-win.c (tui_set_focus_command): Rename from
  96         tui_set_focus.  Call tui_enable.
  97         (tui_set_focus_command): Remove.
  98
  99 2019-07-17  Tom Tromey  <tom@tromey.com>
 100
 101         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 102         refresh_window.
 103         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 104         touchwin.
 105         (tui_data_window::refresh_window): Call refresh_window on data
 106         items.  Always call superclass refresh_window.
 107         (tui_win_info::refresh): Remove.
 108         (tui_source_window_base::refresh_window): Update.
 109         (tui_refresh_all): Update.
 110         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 111         refresh_window.
 112         (show_source_or_disasm_and_command): Likewise.
 113         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 114         (struct tui_source_window_base) <refresh>: Likewise.
 115
 116 2019-07-17  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-winsource.c (tui_clear_source_content)
 119         (tui_show_source_content): Update.
 120         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 121         whether content is empty.
 122         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 123         Remove.
 124
 125 2019-07-17  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 128         window's contents.
 129         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 130         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 131
 132 2019-07-17  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 135         (struct tui_data_item_window): Update.
 136
 137 2019-07-17  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 140         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 141         defines.
 142
 143 2019-07-17  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-winsource.h (tui_erase_source_content)
 146         (tui_clear_source_content): Remove "display_prompt" parameter.
 147         * tui/tui-winsource.c (tui_update_source_window_as_is)
 148         (tui_update_source_windows_with_addr): Update.
 149         (tui_clear_source_content): Remove "display_prompt" parameter.
 150         (tui_erase_source_content): Likewise.  Simplify.
 151         (tui_show_source_content): Update.
 152         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 153         * tui/tui-stack.c (tui_show_frame_info): Update.
 154         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 155         Remove defines.
 156
 157 2019-07-17  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 160         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 161         parameter.
 162         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 163         parameter.
 164
 165 2019-07-17  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-winsource.c (tui_clear_source_content)
 168         (tui_show_source_content, tui_show_exec_info_content)
 169         (tui_clear_exec_info_content): Update.
 170         * tui/tui-stack.c (tui_show_locator_content): Update.
 171         (tui_show_frame_info): Update.
 172         * tui/tui-source.h (tui_source_window): Don't declare.
 173         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 174         from tui_source_is_displayed.
 175         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 176         Remove field.
 177         (struct tui_source_window_base) <content_in_use>: New field.  Now
 178         bool.
 179         (struct tui_source_window) <showing_source_p>: New method.
 180         (TUI_SRC_WIN): Change cast.
 181         * tui/tui-data.c (tui_initialize_static_data): Update.
 182
 183 2019-07-17  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 186         location_matches_p.
 187         * tui/tui-source.c (tui_source_window::location_matches_p): New
 188         method.
 189         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 190         method.
 191         * tui/tui-data.h (struct tui_source_window_base)
 192         <location_matches_p>: New method.
 193         (struct tui_source_window, struct tui_disasm_window)
 194         <location_matches_p>: Likewise.
 195
 196 2019-07-17  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-win.c (tui_set_win_height_command): Rename from
 199         tui_set_win_height.
 200         (tui_set_win_height_command): Remove.
 201
 202 2019-07-17  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-source.c (tui_source_window): New constructor.  Add
 205         observer.
 206         (~tui_source_window): New destructor.
 207         (tui_source_window::style_changed): New method.
 208         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 209         (tui_attach_detach_observers): Update.
 210         * tui/tui-data.h (struct tui_source_window): Make constructor not
 211         inline.  Add destructor.
 212         (struct tui_source_window) <style_changed>: New method.
 213         <m_observable>: New member.
 214
 215 2019-07-17  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 218         * tui/tui-win.c (tui_resize_all): Fix typo.
 219
 220 2019-07-17  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 223         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 224         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 225         * tui/tui-win.c (window_name_completer): Use foreach.
 226         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 227         (update_tab_width): Likewise.
 228         * tui/tui-layout.c (show_layout): Update.
 229         * tui/tui-data.h (class tui_window_iterator): New.
 230         (struct all_tui_windows): New.
 231         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 232
 233 2019-07-17  Tom Tromey  <tom@tromey.com>
 234
 235         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 236         parameter.  Don't reference globals.
 237         (tui_reg_command): Update.
 238
 239 2019-07-17  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-regs.c (tui_show_registers): Simplify.
 242
 243 2019-07-17  Tom Tromey  <tom@tromey.com>
 244
 245         * tui/tui-regs.c (tui_show_registers): Update.
 246         (tui_show_register_group): Add win_info parameter.
 247
 248 2019-07-17  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 251         Rename from tui_display_reg_element_at_line.
 252         (tui_data_window::display_registers_from_line): Update.
 253         * tui/tui-data.h (struct tui_data_window)
 254         <display_reg_element_at_line>: New method.
 255
 256 2019-07-17  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-regs.h (tui_display_registers_from)
 259         (tui_display_registers_from_line): Don't declare.
 260         * tui/tui-windata.c (tui_data_window::display_all_data)
 261         (tui_data_window::refresh_all)
 262         (tui_data_window::do_scroll_vertical): Update.
 263         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 264         from tui_display_registers_from.
 265         (tui_display_reg_element_at_line): Update.
 266         (tui_data_window::display_registers_from_line): Rename from
 267         tui_display_registers_from_line.
 268         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 269         display_registers_from_line>: New methods.
 270
 271 2019-07-17  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 274         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 275         from tui_erase_data_content.
 276         (tui_data_window::display_all_data)
 277         (tui_data_window::refresh_all)
 278         (tui_data_window::do_scroll_vertical): Update.
 279         * tui/tui-regs.c (tui_show_registers): Update.
 280         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 281         New method.
 282
 283 2019-07-17  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 286         declare.
 287         * tui/tui-windata.c
 288         (tui_data_window::delete_data_content_windows): Rename from
 289         tui_delete_data_content_windows.
 290         (tui_data_window::display_all_data)
 291         (tui_data_window::do_scroll_vertical): Update.
 292         * tui/tui-data.h (struct tui_data_window)
 293         <delete_data_content_windows>: New method.
 294
 295 2019-07-17  Tom Tromey  <tom@tromey.com>
 296
 297         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 298         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 299
 300 2019-07-17  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 303         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 304         from tui_display_all_data.
 305         * tui/tui-win.c
 306         (tui_data_window::do_make_visible_with_new_height): Update.
 307         * tui/tui-regs.c (tui_show_registers): Update.
 308         * tui/tui-layout.c (tui_set_layout): Update.
 309         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 310         method.
 311
 312 2019-07-17  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 315         * tui/tui-windata.c (tui_display_data_from): Remove.
 316         (tui_data_window::refresh_all): Update.
 317
 318 2019-07-17  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 321         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 322         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 323         tui_display_registers_from_line.
 324         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 325         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 326         "force_display" parameter.
 327
 328 2019-07-17  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 331         declare.
 332         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 333         Rename from tui_first_reg_element_no_inline.
 334         (tui_display_reg_element_at_line)
 335         (tui_display_registers_from_line): Update.
 336         * tui/tui-data.h (struct tui_data_window)
 337         <first_reg_element_no_inline>: New method.
 338
 339 2019-07-17  Tom Tromey  <tom@tromey.com>
 340
 341         * tui/tui-windata.c (tui_display_data_from)
 342         (tui_data_window::do_scroll_vertical): Update.
 343         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 344         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 345         Rename from tui_line_from_reg_element_no.
 346         (tui_display_registers_from_line): Update.
 347         * tui/tui-data.h (struct tui_data_window)
 348         <line_from_reg_element_no>: New method.
 349
 350 2019-07-17  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 353         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 354         tui_last_regs_line_no.
 355         (tui_display_reg_element_at_line)
 356         (tui_display_registers_from_line): Update.
 357         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 358         method.
 359
 360 2019-07-17  Tom Tromey  <tom@tromey.com>
 361
 362         PR tui/24722:
 363         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 364         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 365         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 366         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 367         (tui_update_breakpoint_info): Likewise.
 368         * tui/tui-hooks.c (tui_event_create_breakpoint)
 369         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 370         Update.
 371
 372 2019-07-17  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 375
 376 2019-07-17  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-winsource.c (tui_update_source_window_as_is)
 379         (tui_update_source_windows_with_addr): Update.
 380         * tui/tui-source.h (tui_set_source_content)
 381         (tui_show_symtab_source): Add "win_info" parameter.
 382         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 383         parameter.
 384         (tui_show_symtab_source): Likewise.
 385
 386 2019-07-17  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-wingeneral.c
 389         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 390
 391 2019-07-17  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 394         (struct tui_cmd_window) <can_scroll>: New method.
 395         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 396         method.
 397
 398 2019-07-17  Tom Tromey  <tromey@adacore.com>
 399
 400         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 401         do_field_signed>: Rename.  Change type of "value".
 402         * ui-out.c (ui_out::field_signed): Rename from field_int.
 403         Change type of "value".
 404         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 405         type of "value".
 406         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 407         do_field_int.  Change type of "value".
 408         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 409         do_field_int.  Change type of "value".
 410         * tracepoint.c (trace_status_mi, tfind_1)
 411         (print_one_static_tracepoint_marker): Update.
 412         * thread.c (print_thread_info_1, print_selected_thread_frame):
 413         Update.
 414         * stack.c (print_frame, print_frame_info): Update.
 415         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 416         Update.
 417         * source.c (print_source_lines_base): Update.
 418         * skip.c (info_skip_command): Update.
 419         * record-btrace.c (btrace_ui_out_decode_error)
 420         (btrace_call_history_src_line): Update.
 421         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 422         Update.
 423         * progspace.c (print_program_space): Update.
 424         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 425         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 426         do_field_int.  Change type of "value".
 427         * mi/mi-out.c (mi_ui_out::do_table_begin)
 428         (mi_ui_out::do_table_header): Update.
 429         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 430         type of "value".
 431         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 432         (mi_cmd_data_list_changed_registers, output_register)
 433         (mi_cmd_data_read_memory, mi_load_progress)
 434         (mi_cmd_trace_frame_collected): Update.
 435         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 436         Update.
 437         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 438         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 439         (mi_cmd_var_list_children, varobj_update_one): Update.
 440         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 441         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 442         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 443         * inferior.c (print_inferior): Update.
 444         * gdb_bfd.c (print_one_bfd): Update.
 445         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 446         Update.
 447         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 448         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 449         do_field_int.  Change type of "value".
 450         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 451         do_field_int.  Change type of "value".
 452         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 453         (print_one_breakpoint_location, print_it_catch_fork)
 454         (print_one_catch_fork, print_it_catch_vfork)
 455         (print_one_catch_vfork, print_it_catch_solib)
 456         (print_it_catch_exec, print_it_ranged_breakpoint)
 457         (print_mention_watchpoint, print_mention_masked_watchpoint)
 458         (bkpt_print_it, update_static_tracepoint): Update.
 459         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 460         * break-catch-syscall.c (print_it_catch_syscall): Update.
 461         * ada-tasks.c (print_ada_task_info): Update.
 462         * ada-lang.c (print_it_exception, print_mention_exception):
 463         Update.
 464
 465 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 466
 467         PR breakpoints/24541
 468         * gdbarch.c: Regenerate.
 469         * gdbarch.h: Regenerate.
 470         * gdbarch.sh: Adjust return type and parameter types for
 471         'stap_adjust_register'.
 472         (i386_stap_adjust_register): Adjust signature and return new
 473         register name.
 474         * stap-probe.c (stap_parse_register_operand): Adjust use of
 475         'gdbarch_stap_adjust_register'.
 476
 477 2019-07-17  Tom Tromey  <tromey@adacore.com>
 478
 479         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 480         declare VEC.
 481         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 482         std::vector.
 483         (struct s390_process_info): Add initializers.
 484         (s390_add_process): Use new.
 485         (s390_linux_nat_target::low_forget_process): Use delete.
 486         (s390_linux_nat_target::low_new_fork)
 487         (s390_linux_nat_target::stopped_by_watchpoint)
 488         (s390_linux_nat_target::low_prepare_to_resume)
 489         (s390_linux_nat_target::insert_watchpoint)
 490         (s390_linux_nat_target::insert_hw_breakpoint)
 491         (s390_linux_nat_target::remove_watchpoint)
 492         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 493
 494 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 495
 496         * aarch64-fbsd-nat.c: Include regcache.h.
 497         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 498         argument.
 499         (aarch64_fbsd_nat_target::fetch_registers)
 500         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 501         variable.
 502         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 503
 504 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 505
 506         * fbsd-nat.c: Include gdbarch.h.
 507
 508 2019-07-15  Tom Tromey  <tromey@adacore.com>
 509
 510         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 511
 512 2019-07-15  Tom Tromey  <tromey@adacore.com>
 513
 514         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 515         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 516         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 517         * cli-out.c (cli_ui_out::do_field_int): New method.
 518         * ui-out.c (ui_out::field_unsigned): New method.
 519         * symfile.c (generic_load): Use field_unsigned.
 520         (print_transfer_performance): Likewise.
 521         * record-btrace.c (ui_out_field_uint): Remove.
 522         (btrace_call_history_insn_range, btrace_call_history): Use
 523         field_unsigned.
 524         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 525         field_unsigned.
 526         * ui-out.h (class ui_out) <field_unsigned>: New method.
 527         <do_field_unsigned>: Likewise.
 528
 529 2019-07-15  Tom Tromey  <tromey@adacore.com>
 530
 531         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 532         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 533         * target.c (flash_erase_command): Use field_string.
 534         * infrun.c (print_signal_received_reason): Use field_string.
 535         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 536         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 537         field_string.
 538         * ada-tasks.c (print_ada_task_info): Use field_string.
 539
 540 2019-07-15  Tom Tromey  <tromey@adacore.com>
 541
 542         * target.c (flash_erase_command): Use field_core_addr.
 543         * symfile.c (generic_load): Use field_core_addr.
 544         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 545         Use field_core_addr.
 546         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 547         field_core_addr.
 548
 549 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 550
 551         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 552         value if its desired type is smaller than a CORE_ADDR and signed.
 553
 554 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 555
 556         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 557         of changes to field names, and use new is_reference field to
 558         decide if a property is a reference or not.
 559         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 560         field.
 561         (struct dwarf2_property_baton): Update header comment, rename
 562         'referenced_type' to 'property_type' and update comments.
 563         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 564         default property type, store in property baton, update to take
 565         accound of renamed field.
 566         (read_func_scope): Update call to attr_to_dynamic_prop.
 567         (read_array_type): Likewise.
 568         (dwarf2_per_cu_addr_sized_int_type): New function.
 569         (read_subrange_index_type): Move type finding code to
 570         dwarf2_per_cu_addr_sized_int_type.
 571         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 572         (dwarf2_per_cu_addr_type): New function.
 573         (set_die_type): Update calls to attr_to_dynamic_prop.
 574
 575 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 576
 577         * dwarf2read.c (read_subrange_index_type): New function.
 578         (read_subrange_type): Move code into new function and call it.
 579         * gdbtypes.c (create_range_type): Add some asserts.
 580
 581 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 582
 583         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 584         update return statements.
 585         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 586         declaration, and update comment to match.
 587         * gdbtypes.c (resolve_dynamic_array): Update call to
 588         dwarf2_evaluate_property to match new return type.
 589
 590 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 591
 592         * valarith.c (value_subscripted_rvalue): Change lowerbound
 593         parameter type from int to LONGEST.
 594         * value.h (value_subscripted_rvalue): Likewise in declaration.
 595
 596 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 597
 598         * cli/cli-utils.c (info_print_command_completer): New function.
 599         * cli/cli-utils.h: Add 'completer.h' include, and forward
 600         declaration for 'struct cmd_list_element'.
 601         (info_print_command_completer): Declare.
 602         * stack.c (_initialize_stack): Add completer for 'info locals' and
 603         'info args'.
 604         * symtab.c (_initialize_symtab): Add completer for 'info
 605         variables' and 'info functions'.
 606         * NEWS: Mention completion for additional info commands.
 607
 608 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 609
 610         * cli/cli-utils.c (extract_info_print_args): Delete.
 611         (extract_arg_maybe_quoted): Delete.
 612         (info_print_options_defs): New variable.
 613         (make_info_print_options_def_group): New function.
 614         (extract_info_print_options): Define new function.
 615         * cli/cli-utils.h (extract_info_print_args): Delete.
 616         (struct info_print_options): New structure.
 617         (extract_info_print_options): Declare new function.
 618         * stack.c (info_locals_command): Update to use new
 619         extract_info_print_options, also add a header comment.
 620         (info_args_command): Likewise.
 621         * symtab.c (info_variables_command): Likewise.
 622         (info_functions_command): Likewise.
 623
 624 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 627         to extract string arguments.
 628         * common/common-utils.c (extract_string_maybe_quoted): New function.
 629         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 630
 631 2019-07-11  Tom Tromey  <tromey@adacore.com>
 632
 633         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 634         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 635         * top.h (gdbinit): Don't declare.
 636         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 637         into...
 638         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 639         * top.c (gdb_init): Don't call init_cli_cmds.
 640         (gdbinit): Remove.
 641         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 642
 643 2019-07-11  Tom Tromey  <tromey@adacore.com>
 644
 645         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 646         after it has been moved.
 647
 648 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 649
 650         * valops.c (value_must_coerce_to_target): Change return type to
 651         bool.
 652         * value.h (value_must_coerce_to_target): Likewise.
 653
 654 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 655
 656         * breakpoint.c (is_hardware_watchpoint): Remove
 657         forward-declaration.
 658         (is_masked_watchpoint): Change return type to bool.
 659         (is_tracepoint): Likewise.
 660         (is_breakpoint): Likewise.
 661         (is_hardware_watchpoint): Likewise.
 662         (is_watchpoint): Likewise.
 663         (is_no_memory_software_watchpoint): Likewise.
 664         (is_catchpoint): Likewise.
 665         (breakpoint_1): Make FILTER parameter's return type bool.
 666         is_masked_watchpoint): Change return type to bool.
 667         (save_breakpoints): Make FILTER parameter's return type bool.
 668         * breakpoint.h (is_breakpoint): Change return type to bool.
 669         (is_watchpoint): Likewise.
 670         (is_catchpoint): Likewise.
 671         (is_tracepoint): Likewise.
 672
 673 2019-07-10  Tom Tromey  <tom@tromey.com>
 674
 675         * defs.h: Don't include gdbarch.h.
 676         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 677         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 678         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 679         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 680         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 681         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 682         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 683         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 684         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 685         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 686         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 687         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 688         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 689         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 690         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 691         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 692         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 693         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 694         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 695         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 696         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 697         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 698         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 699         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 700         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 701         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 702         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 703
 704 2019-07-10  Tom Tromey  <tromey@adacore.com>
 705
 706         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 707         * breakpoint.c (init_ada_exception_breakpoint): Register as
 708         bp_catchpoint.
 709         (print_one_breakpoint_location, print_one_breakpoint): Use
 710         is_ada_exception_catchpoint.
 711         * ada-lang.c (class ada_catchpoint_location): Pass
 712         bp_loc_software_breakpoint to bp_location constructor.
 713         (is_ada_exception_catchpoint): New function.
 714
 715 2019-07-10  Tom Tromey  <tromey@adacore.com>
 716
 717         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 718         VEC.
 719         (struct arm_exidx_entry): New method operator<.
 720         (struct arm_exidx_data) <section_maps>: Change type.
 721         (arm_exidx_data_free): Remove.
 722         (arm_exidx_data_key): Change type.  Move lower.
 723         (arm_exidx_new_objfile): Update.
 724         (arm_compare_exidx_entries): Remove.
 725         (arm_find_exidx_entry, _initialize_arm_tdep)
 726
 727 2019-07-10  Tom Tromey  <tromey@adacore.com>
 728
 729         * solib-spu.c (ocl_program_data_key): Change type.
 730         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 731         Update.
 732
 733 2019-07-10  Tom Tromey  <tromey@adacore.com>
 734
 735         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 736         (struct solib_aix_inferior_data) <library_list>: Change type.
 737         (solib_aix_inferior_data_handle): Change type.
 738         (get_solib_aix_inferior_data): Update.
 739         (solib_aix_free_library_list): Remove.
 740         (library_list_start_library): Update.
 741         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 742         return type.
 743         (solib_aix_get_library_list)
 744         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 745         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 746
 747 2019-07-10  Tom Tromey  <tromey@adacore.com>
 748
 749         * solib-dsbt.c (struct dsbt_info): Add initializers.
 750         (solib_dsbt_pspace_data): Change type.
 751         (dsbt_pspace_data_cleanup): Remove.
 752         (get_dsbt_info, _initialize_dsbt_solib): Update.
 753
 754 2019-07-10  Tom Tromey  <tromey@adacore.com>
 755
 756         * spu-tdep.c (spu_overlay_data): Change type.
 757         (spu_get_overlay_table, spu_overlay_new_objfile)
 758         (_initialize_spu_tdep): Update.
 759
 760 2019-07-10  Tom Tromey  <tromey@adacore.com>
 761
 762         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 763         destructor.
 764         (dbx_objfile_data_key): Change type and declare later.
 765         (DBX_SYMFILE_INFO): Rewrite.
 766         * dbxread.c (dbx_objfile_data_key): Change type.
 767         (dbx_symfile_init): Update.
 768         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 769         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 770         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 771
 772 2019-07-10  Tom Tromey  <tromey@adacore.com>
 773
 774         * jit.c (jit_program_space_key): Change type.  Move lower.
 775         (get_jit_program_space_data): Update.
 776         (jit_program_space_data_cleanup): Remove.
 777         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 778         Update.
 779         (struct jit_program_space_data): Add initializers.
 780
 781 2019-07-10  Tom Tromey  <tromey@adacore.com>
 782
 783         * solib-darwin.c (struct darwin_info): Add initializers.
 784         (solib_darwin_pspace_data): Change type.
 785         (darwin_pspace_data_cleanup): Remove.
 786         (get_darwin_info, _initialize_darwin_solib): Update.
 787
 788 2019-07-10  Tom Tromey  <tromey@adacore.com>
 789
 790         * remote-sim.c (struct sim_inferior_data): Add initializers,
 791         constructor, and destructor.
 792         (sim_inferior_data_key): Change type.  Move lower.
 793         (check_for_duplicate_sim_descriptor): Update.
 794         (get_sim_inferior_data): Use new.  Update.
 795         (~sim_inferior_data_cleanup): Rename from
 796         sim_inferior_data_cleanup.  Simplify.
 797         (gdbsim_close_inferior, simulator_command)
 798         (sim_command_completer, _initialize_remote_sim): Update.
 799         (next_pid, INITIAL_PID): Move earlier.
 800
 801 2019-07-10  Tom Tromey  <tromey@adacore.com>
 802
 803         * python/python-internal.h (create_thread_object): Return
 804         gdbpy_ref.
 805         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 806         * python/py-inferior.c (struct threadlist_entry): Add
 807         constructor.
 808         <thread_obj>: Now a gdbpy_ref.
 809         (thread_to_thread_object): Update.
 810         (add_thread_object): Use new.
 811         (delete_thread_object): Use delete.
 812         (infpy_threads): Update.
 813         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 814         GIL.
 815
 816 2019-07-10  Tom Tromey  <tromey@adacore.com>
 817
 818         * valops.c (value_cast): Specialize error message for Ada.
 819
 820 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 821
 822         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 823
 824 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 825
 826         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 827         bpstat_should_step): Return bool, adjust comments.
 828         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 829         bpstat_should_step): Likewise.
 830
 831 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 832
 833         * features/Makefile: Use feature target descriptions for Arm.
 834         * features/arm/arm-core.c: Generate new file.
 835         * features/arm/arm-fpa.c: Likewise.
 836         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 837         * features/arm/arm-m-profile.c: Likewise.
 838         * features/arm/arm-vfpv2.c: Likewise.
 839         * features/arm/arm-vfpv3.c: Likewise.
 840         * features/arm/xscale-iwmmxt.c: Likewise.
 841         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 842
 843 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 844
 845         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 846         ptrace earlier.
 847
 848 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 849
 850         * features/aarch64-pauth.c: Regenerate.
 851
 852 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 853
 854         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 855         bool.
 856         (bpstat_what): Use false instead of 0.
 857
 858 2019-07-09  Pedro Alves  <palves@redhat.com>
 859
 860         * break-catch-throw.c (is_exception_catchpoint): New.
 861         * breakpoint.c (print_one_breakpoint_location): New parameter
 862         'raw_loc'.  Handle it.  Use
 863         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 864         looking at the breakpoint's type.
 865         (print_one_breakpoint): If handling "maint info breakpoints", also
 866         print locations of exception catchpoints.
 867         * breakpoint.h (is_exception_catchpoint): Declare.
 868
 869 2019-07-09  Pedro Alves  <palves@redhat.com>
 870
 871         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 872         "addr" field.
 873         (allocate_location_exception_catchpoint): New.
 874         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 875         (initialize_throw_catchpoint_ops): Install
 876         allocate_location_exception_catchpoint as allocate_location
 877         method.
 878         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 879         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 880         bp_loc_other.
 881         (breakpoint_address_is_meaningful): Delete.
 882         (bl_address_is_meaningful): New.
 883         (breakpoint_locations_match): Adjust comment.
 884         (bp_location_from_bp_type): New, factored out of...
 885         (bp_location::bp_location(breakpoint *)): ... this.
 886         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 887         factored out of...
 888         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 889         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 890         breakpoint_address_is_meaningful.
 891         (bp_locations_compare): Adjust comment.
 892         (update_global_location_list): Use bl_address_is_meaningful
 893         instead of breakpoint_address_is_meaningful.
 894         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 895         explicit.
 896         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 897         * python/py-breakpoint.c (bppy_get_location): No longer check
 898         whether location is null.
 899
 900 2019-07-09  Pedro Alves  <palves@redhat.com>
 901
 902         PR c++/15468
 903         * breakpoint.c (print_one_breakpoint_location): Remove
 904         single-location assert.
 905
 906 2019-07-09  Tom Tromey  <tom@tromey.com>
 907
 908         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 909         * configure: Rebuild.
 910         * configure.ac: Change common to gdbsupport.
 911         * gdbsupport: Rename from common.
 912         * acinclude.m4: Change common to gdbsupport.
 913         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 914         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 915         gdbsupport.
 916         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 917         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 918         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 919         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 920         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 921         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 922         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 923         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 924         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 925         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 926         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 927         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 928         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 929         coff-pe-read.c, command.h, compile/compile-c-support.c,
 930         compile/compile-c.h, compile/compile-cplus-symbols.c,
 931         compile/compile-cplus-types.c, compile/compile-cplus.h,
 932         compile/compile-loc2c.c, compile/compile.c, completer.c,
 933         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 934         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 935         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 936         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 937         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 938         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 939         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 940         features/aarch64-core.c, features/aarch64-fpu.c,
 941         features/aarch64-pauth.c, features/aarch64-sve.c,
 942         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 943         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 944         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 945         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 946         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 947         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 948         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 949         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 950         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 951         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 952         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 953         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 954         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 955         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 956         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 957         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 958         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 959         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 960         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 961         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 962         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 963         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 964         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 965         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 966         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 967         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 968         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 969         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 970         minsyms.c, mips-linux-tdep.c, namespace.h,
 971         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 972         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 973         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 974         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 975         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 976         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 977         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 978         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 979         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 980         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 981         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 982         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 983         procfs.c, producer.c, progspace.h, psymtab.h,
 984         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 985         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 986         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 987         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 988         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 989         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 990         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 991         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 992         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 993         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 994         target-memory.c, target.c, target.h, target/waitstatus.c,
 995         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 996         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 997         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 998         unittests/array-view-selftests.c,
 999         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1000         unittests/common-utils-selftests.c,
1001         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1002         unittests/format_pieces-selftests.c,
1003         unittests/function-view-selftests.c,
1004         unittests/lookup_name_info-selftests.c,
1005         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1006         unittests/mkdir-recursive-selftests.c,
1007         unittests/observable-selftests.c,
1008         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1009         unittests/parse-connection-spec-selftests.c,
1010         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1011         unittests/scoped_fd-selftests.c,
1012         unittests/scoped_mmap-selftests.c,
1013         unittests/scoped_restore-selftests.c,
1014         unittests/string_view-selftests.c, unittests/style-selftests.c,
1015         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1016         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1017         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1018         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1019         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1020         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1021
1022 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1025         bool value.
1026         (decode_digits_ordinary): Set explicit_line field in sal.
1027         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1028         symtab_and_line that was set on an explicit line number in
1029         assembler code.  Do always update the recorded symtab and line if
1030         we do skip the prologue.
1031
1032 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1033
1034         * breakpoint.c (set_breakpoint_location_function): Remove
1035         explicit_loc parameter.
1036         (momentary_breakpoint_from_master): Update call to
1037         set_breakpoint_location_function.
1038         (add_location_to_breakpoint): Likewise.
1039
1040 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1043         required features based on default bfd type when no specific bfd
1044         is present.
1045
1046 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1047
1048         * NEWS: Mention that GDB printf and eval commands can now print
1049         C-style and Ada-style convenience var strings without
1050         calling the inferior.
1051         * printcmd.c (printf_c_string): Locally print GDB internal var
1052         instead of transiting via the inferior.
1053         (printf_wide_c_string): Likewise.
1054
1055 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1056
1057         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1058
1059 2019-07-04  Tom Tromey  <tom@tromey.com>
1060
1061         PR tui/24724:
1062         * tui/tui-winsource.c (tui_clear_source_content): Update.
1063         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1064         (tui_update_breakpoint_info): Update.
1065         (tui_set_exec_info_content): Update.
1066         * tui/tui-source.c (tui_set_source_content_nil): Update.
1067         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1068         has_break.
1069         * tui/tui-data.h (enum tui_bp_flag): New.
1070         (tui_bp_flags): New enum flags type.
1071         (struct tui_source_element) <break_mode>: Change type.  Rename
1072         from has_break.
1073         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1074         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1075         constants.
1076         * tui/tui-winsource.h: Fix comment.
1077
1078 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1079
1080         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1081         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1082         (store_fpregs_to_thread)
1083         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1084         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1085         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1086         (IWMMXT_REGS_SIZE): Add define.
1087         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1088         (fetch_vfp_regs, store_vfp_regs)
1089         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1090         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1091
1092 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1093
1094         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1095         defines.
1096         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1097         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1098         (ARM_INT_REGISTER_SIZE): ...to this.
1099         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1100         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1101         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1102         (arm_linux_collect_gregset, supply_nwfpe_register)
1103         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1104         defines.
1105         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1106         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1107         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1108         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1109         (arm_return_in_memory, arm_store_return_value)
1110         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1111         (arm_record_ld_st_multiple): Likewise.
1112         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1113         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1114
1115 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1116
1117         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1118         AARCH64_DISPLACED_MODIFIED_INSNS.
1119         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1120         (aarch64_displaced_step_copy_insn): Likewise.
1121         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1122         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1123         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1124         ARM_DISPLACED_MODIFIED_INSNS.
1125         * arm-tdep.c (arm_gdbarch_init): Likewise.
1126         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1127         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1128         (struct arm_displaced_step_closure): Use
1129         ARM_DISPLACED_MODIFIED_INSNS.
1130
1131 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1132
1133         * features/Makefile: Remove unused xml files.
1134         * features/aarch64.xml: Remove.
1135         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1136         * features/i386/amd64-avx-avx512.xml: Remove.
1137         * features/i386/amd64-avx-linux.xml: Remove.
1138         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1139         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1140         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1141         * features/i386/amd64-avx-mpx.xml: Remove.
1142         * features/i386/amd64-avx.xml: Remove.
1143         * features/i386/amd64-linux.xml: Remove.
1144         * features/i386/amd64-mpx-linux.xml: Remove.
1145         * features/i386/amd64-mpx.xml: Remove.
1146         * features/i386/amd64.xml: Remove.
1147         * features/i386/i386-avx-avx512-linux.xml: Remove.
1148         * features/i386/i386-avx-avx512.xml: Remove.
1149         * features/i386/i386-avx-linux.xml: Remove.
1150         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1151         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1152         * features/i386/i386-avx-mpx-linux.xml: Remove.
1153         * features/i386/i386-avx-mpx.xml: Remove.
1154         * features/i386/i386-avx.xml: Remove.
1155         * features/i386/i386-linux.xml: Remove.
1156         * features/i386/i386-mmx-linux.xml: Remove.
1157         * features/i386/i386-mmx.xml: Remove.
1158         * features/i386/i386-mpx-linux.xml: Remove.
1159         * features/i386/i386-mpx.xml: Remove.
1160         * features/i386/i386.xml: Remove.
1161         * features/i386/x32-avx-avx512-linux.xml: Remove.
1162         * features/i386/x32-avx-linux.xml: Remove.
1163         * features/i386/x32-linux.xml: Remove.
1164
1165 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1166
1167         * regformats/aarch64.dat: Remove.
1168         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1169         * regformats/i386/amd64-avx-linux.dat: Remove.
1170         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1171         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1172         * regformats/i386/amd64-linux.dat: Remove.
1173         * regformats/i386/amd64-mpx-linux.dat: Remove.
1174         * regformats/i386/amd64.dat: Remove.
1175         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1176         * regformats/i386/i386-avx-linux.dat: Remove.
1177         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1178         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1179         * regformats/i386/i386-linux.dat: Remove.
1180         * regformats/i386/i386-mmx-linux.dat: Remove.
1181         * regformats/i386/i386-mpx-linux.dat: Remove.
1182         * regformats/i386/i386.dat: Remove.
1183         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1184         * regformats/i386/x32-avx-linux.dat: Remove.
1185         * regformats/i386/x32-linux.dat: Remove.
1186
1187 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1188
1189         * aarch64-tdep.c: Remove xml self tests.
1190         * amd64-linux-tdep.c: Likewise.
1191         * amd64-tdep.c: Likewise.
1192         * i386-linux-tdep.c: Likewise.
1193         * i386-tdep.c: Likewise.
1194
1195 2019-07-03  Pedro Alves  <palves@redhat.com>
1196
1197         PR cli/24732
1198         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1199         (pipe_cmd_option_defs): New.
1200         (make_pipe_cmd_options_def_group): New.
1201         (pipe_command): Use gdb::option::process_options.
1202         (pipe_command_completer): New function.
1203         (_initialize_cli_cmds): Install completer for "pipe" command.
1204
1205 2019-07-03  Pedro Alves  <palves@redhat.com>
1206
1207         * cli/cli-option.c (union option_value) <string>: New field.
1208         (struct option_def_and_value): Add ctor, move ctor, dtor and
1209         use DISABLE_COPY_AND_ASSIGN.
1210         (option_def_and_value::clear_value): New.
1211         (parse_option, save_option_value_in_ctx, get_val_type_str)
1212         (add_setshow_cmds_for_options): Handle var_string.
1213         * cli-option.h (union option_def::var_address) <string>: New
1214         field.
1215         (struct string_option_def): New.
1216         * maint-test-options.c (struct test_options_opts): Add default
1217         ctor and use DISABLE_COPY_AND_ASSIGN.
1218         <string_opt>: New field.
1219         (test_options_opts::~test_options_opts): New.
1220         (test_options_opts::dump): Also dump "-string".
1221         (test_options_option_defs): Install "string.
1222
1223 2019-07-03  Pedro Alves  <palves@redhat.com>
1224
1225         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1226         option_value with a null enumeration.
1227         (complete_options): Save the option values in the context.
1228         (save_option_value_in_ctx): New, factored out from ...
1229         (process_options): ... here.
1230         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1231         of the function.
1232         * maint-test-options.c (test_options_opts::dump): New, factored
1233         out from ...
1234         (maintenance_test_options_command_mode): ... here.
1235         (maintenance_test_options_command_completion_result): Delete.
1236         (maintenance_test_options_command_completion_text): Update
1237         comment.
1238         (maintenance_show_test_options_completion_result): Change
1239         prototype.  Just print
1240         maintenance_test_options_command_completion_text.
1241         (save_completion_result): New.
1242         (maintenance_test_options_completer_mode): Pass options context to
1243         complete_options, and then save a dump.
1244         (_initialize_maint_test_options): Use add_cmd to install "maint
1245         show test-options-completion-result".
1246
1247 2019-07-03  Pedro Alves  <palves@redhat.com>
1248
1249         * NEWS (New commands): Mention "with" and "maint with".
1250         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1251         (with_command, with_command_completer): New.
1252         (pipe_command): Adjust to new repeat_previous
1253         interface.
1254         (_initialize_cli_cmds): Install the "with" command and its "w"
1255         alias.
1256         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1257         declarations.
1258         * cli/cli-setshow.c (parse_cli_var_uinteger)
1259         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1260         argument strings for all var_types.
1261         (get_setshow_command_value_string): New, factored out from ...
1262         (do_show_command): ... this.
1263         * cli/cli-setshow.h: Include <string>.
1264         (get_setshow_command_value_string): Declare.
1265         * command.h (repeat_previous): Now returns const char *.  Adjust
1266         comment.
1267         * maint.c: Include "cli/cli-cmds.h".
1268         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1269         (_initialize_maint_cmds): Register the "maintenance with" command.
1270         * top.c (repeat_previous): Move bits from pipe_command here:
1271         Return the saved command line, if any; error out if there's no
1272         command to relaunch.
1273
1274 2019-07-03  Pedro Alves  <palves@redhat.com>
1275
1276         * NEWS (New commands): Mention "maint set/show test-settings"
1277         instead of "maint test-settings".
1278         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1279         (maintenance_test_settings_set_list): Rename to ...
1280         (maintenance_set_test_settings_list): ... this.
1281         (maintenance_test_settings_show_list): Rename to  ...
1282         (maintenance_show_test_settings_list): ... this.
1283         (maintenance_test_settings_cmd): Delete.
1284         (maintenance_test_settings_set_cmd): ...
1285         (maintenance_set_test_settings_cmd): ... this.
1286         (maintenance_test_settings_show_cmd): ...
1287         (maintenance_show_test_settings_cmd): ... this.
1288         (maintenance_test_settings_show_value_cmd):
1289         (maintenance_show_test_settings_value_cmd): ... this.
1290         (_initialize_maint_test_settings): No longer install the "maint
1291         test-settings" prefix command.  Rename "maint test-settings set"
1292         to "maint set test-settings", and "maint test-settings show" to
1293         "maint show test-settings".  Adjust all subcommands.
1294
1295 2019-07-03  Pedro Alves  <palves@redhat.com>
1296
1297         * maint-test-settings.c: Fix file's intro comment.  Replace all
1298         references to "test-options" with references to "test-settings",
1299         in comments.
1300
1301 2019-07-03  Pedro Alves  <palves@redhat.com>
1302
1303         * maint-test-settings.c (maintenance_test_settings_xxx)
1304         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1305         New.
1306         (maintenance_test_settings_enums): Use them.
1307         (maintenance_test_settings_enum): Default to
1308         maintenance_test_settings_xxx.
1309         (_initialize_maint_test_settings): Initialize
1310         MAINTENANCE_TEST_SETTINGS_FILENAME.
1311
1312 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1313
1314         * breakpoint.h (remove_breakpoints_inf): Change return type to
1315         void, move function documentation here.
1316         * breakpoint.c (remove_breakpoints_inf): Change return type to
1317         void, move function documentation to header.
1318
1319 2019-07-02  Pedro Alves  <palves@redhat.com>
1320
1321         * NEWS (Completion improvements): Mention "info threads".
1322         * thread.c (struct info_threads_opts, info_threads_option_defs)
1323         (make_info_threads_options_def_group): New.
1324         (info_threads_command): Use gdb::option::process_options.
1325         (info_threads_command_completer): New.
1326         (_initialize_thread): Use gdb::option::build_help to build the
1327         help text for "info threads".
1328
1329 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1330
1331         * defs.h (generic_load): Move from here...
1332         * symfile.h (generic_load): ... to here.  Rename name parameter
1333         to args.
1334         * symfile.c (generic_load): Add comment.
1335
1336 2019-07-01  Tom Tromey  <tromey@adacore.com>
1337
1338         * dwarf2read.c
1339         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1340         declaration of without_params.  Fix formatting.
1341
1342 2019-07-01  Tom Tromey  <tromey@adacore.com>
1343
1344         * ada-exp.y (find_primitive_type): Update.
1345         * ada-lang.h (ada_lookup_symbol): Update.
1346         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1347         parameter.
1348         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1349
1350 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1351
1352         PR breakpoints/24541
1353         * gdbarch.c: Regenerate.
1354         * gdbarch.h: Regenerate.
1355         * gdbarch.sh: Add 'stap_adjust_register'.
1356         * i386-tdep.c: Include '<unordered_set>'.
1357         (i386_stap_adjust_register): New function.
1358         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1359         * stap-probe.c (stap_parse_register_operand): Call
1360         'gdbarch_stap_adjust_register'.
1361
1362 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1363
1364         PR python/24742
1365         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1366         * python/python.c (do_start_initialization): Use 'xmalloc'
1367         instead of 'PyMem_Malloc'.
1368
1369 2019-06-28  Tom Tromey  <tromey@adacore.com>
1370
1371         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1372         for Ada.
1373
1374 2019-06-27  Tom Tromey  <tromey@adacore.com>
1375
1376         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1377         objfile_key.
1378         (arm_find_mapping_symbol, arm_record_special_symbol)
1379         (_initialize_arm_tdep): Update.
1380         (arm_objfile_data_free): Remove.
1381
1382 2019-06-27  Tom Tromey  <tromey@adacore.com>
1383
1384         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1385         to cp_print_static_field.
1386
1387 2019-06-26  Tom Tromey  <tromey@adacore.com>
1388
1389         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1390         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1391         declare.
1392
1393 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1394
1395         * features/aarch64-core.c (create_feature_aarch64_core):
1396         Regenerate.
1397         * features/aarch64-core.xml: Add cpsr flags.
1398
1399 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1400
1401         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1402         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1403
1404 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1405
1406         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1407         field.
1408         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1409         use.
1410         (arm_record_special_symbol): Don't insert new symbol in sorted
1411         position, push it at the end.
1412
1413 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1414
1415         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1416         (arm_mapping_symbol_s): Remove.
1417         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1418         (arm_mapping_symbol_vec): New typedef.
1419         (struct arm_per_objfile): Add constructor.
1420         <section_maps>: Change type to
1421         std::unique_ptr<arm_mapping_symbol_vec[]>.
1422         (arm_compare_mapping_symbols): Remove.
1423         (arm_find_mapping_symbol): Adjust to section_maps type change.
1424         (arm_objfile_data_free): Call delete on arm_per_objfile.
1425         (arm_record_special_symbol): Adjust to section_maps type change.
1426         Allocate arm_per_objfile with new.
1427
1428 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1429
1430         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1431         with the command prefix.
1432
1433 2019-06-25  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1436         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1437
1438 2019-06-25  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1441         type.
1442         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1443         protected.
1444
1445 2019-06-25  Tom Tromey  <tom@tromey.com>
1446
1447         * tui/tui-winsource.c
1448         (tui_source_window_base::set_is_exec_point_at): Add check against
1449         LOA_ADDRESS.
1450
1451 2019-06-25  Tom Tromey  <tom@tromey.com>
1452
1453         * tui/tui-source.c (tui_set_source_content): Don't check before
1454         xfree.
1455         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1456
1457 2019-06-25  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-winsource.h (tui_update_source_window_as_is)
1460         (tui_alloc_source_buffer, tui_line_is_displayed)
1461         (tui_addr_is_displayed): Change type of win_info.
1462         * tui/tui-winsource.c (tui_update_source_window_as_is)
1463         (tui_clear_source_content, tui_show_source_line)
1464         (tui_show_source_content, tui_source_window_base::refill)
1465         (tui_source_window_base::set_is_exec_point_at)
1466         (tui_source_window_base::set_is_exec_point_at)
1467         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1468         (tui_alloc_source_buffer, tui_line_is_displayed)
1469         (tui_addr_is_displayed): Change type of win_info.  Update.
1470         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1471         (tui_source_window_base::do_make_visible_with_new_height):
1472         Update.
1473         * tui/tui-source.c (tui_set_source_content)
1474         (tui_set_source_content_nil)
1475         (tui_source_window::do_scroll_vertical): Update.
1476         * tui/tui-layout.c (show_layout): Update.
1477         * tui/tui-disasm.c (tui_set_disassem_content)
1478         (tui_disasm_window::do_scroll_vertical): Update.
1479         * tui/tui-data.h (tui_win_content): Remove.
1480         (struct tui_gen_win_info) <content, content_size>: Remove.
1481         (struct tui_source_element): Add initializers and destructor.
1482         (union tui_which_element, struct tui_win_element): Remove.
1483         (struct tui_source_window_base) <content>: New field.
1484         (struct tui_data_window): Remove destructor.
1485         (tui_alloc_content, tui_free_win_content)
1486         (tui_free_all_source_wins_content): Don't declare.
1487         * tui/tui-data.c (tui_initialize_static_data): Update.
1488         (init_content_element, tui_alloc_content): Remove.
1489         (~tui_gen_win_info): Update.
1490         (~tui_data_window, tui_free_all_source_wins_content)
1491         (tui_free_win_content, free_content, free_content_elements):
1492         Remove.
1493
1494 2019-06-25  Tom Tromey  <tom@tromey.com>
1495
1496         * tui/tui-winsource.h (tui_clear_source_content)
1497         (tui_erase_source_content, tui_show_source_content): Change type
1498         of win_info.
1499         * tui/tui-winsource.c (tui_clear_source_content)
1500         (tui_erase_source_content, tui_show_source_content): Change type
1501         of win_info.
1502         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1503         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1504         win_info.
1505         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1506         win_info.
1507         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1508
1509 2019-06-25  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-winsource.c (tui_clear_source_content)
1512         (tui_source_window_base::set_is_exec_point_at): Update.
1513         * tui/tui-source.c (tui_set_source_content_nil): Update.
1514         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1515         a bool.
1516         * tui/tui-data.c (init_content_element): Update.
1517
1518 2019-06-25  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1521         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1522         * tui/tui-layout.c (init_and_make_win): Update.
1523         * tui/tui.h (enum tui_win_type): Update.
1524         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1525         tui_win_is_auxillary.
1526         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1527         tui_win_is_auxillary.
1528
1529 2019-06-25  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1532         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1533         (tui_delete_data_content_windows, tui_display_all_data)
1534         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1535         Update.
1536         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1537         * tui/tui-regs.c (tui_last_regs_line_no)
1538         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1539         (tui_show_registers): Update.
1540         (tui_show_register_group): Return void.  Update.
1541         (tui_display_registers_from, tui_display_reg_element_at_line)
1542         (tui_display_registers_from_line, tui_check_register_values):
1543         Update.
1544         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1545         member.
1546         (struct tui_data_window) <regs_content>: Now a std::vector.
1547         <regs_content_count>: Remove.
1548         (tui_add_content_elements, tui_free_data_content): Don't declare.
1549         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1550         (init_content_element): Remove DATA_WIN case.  Add assert.
1551         (tui_add_content_elements): Remove.
1552         (tui_data_window): Update.
1553         (tui_free_data_content): Remove.
1554         (free_content_elements): Remove DATA_WIN case.
1555
1556 2019-06-25  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-data.c (tui_data_item_window): Update.
1559         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1560         * tui/tui-windata.c (tui_display_all_data)
1561         (tui_display_data_from_line): Update.
1562         (tui_check_data_values): Remove.
1563         * tui/tui-regs.c (tui_show_register_group)
1564         (tui_display_reg_element_at_line): Update.
1565         * tui/tui-hooks.c (tui_register_changed)
1566         (tui_refresh_frame_and_register_information): Call
1567         tui_check_register_values.
1568         * tui/tui-data.h (struct tui_data_window) <data_content,
1569         data_content_count, data_type>: Remove.
1570         (enum tui_data_type): Remove.
1571
1572         * tui/tui-data.c (tui_data_window::clear_detail)
1573         (~tui_data_window): Update.
1574
1575 2019-06-25  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1578         declare.
1579         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1580         Rename from tui_first_data_item_displayed.  Update.
1581         (tui_data_window::refresh_all)
1582         (tui_data_window::do_scroll_vertical): Update.
1583         * tui/tui-data.h (struct tui_data_window)
1584         <first_data_item_displayed>: Declare new method.
1585
1586 2019-06-25  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1589         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1590         contents...
1591         (tui_initialize_static_data): ...here.
1592
1593 2019-06-25  Tom Tromey  <tom@tromey.com>
1594
1595         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1596         (tui_display_registers_from, tui_check_register_values): Update.
1597         (tui_display_register): Remove win_info parameter; update.
1598         (tui_get_register): Change type of parameters.
1599         * tui/tui-data.h (struct tui_data_element): Remove.
1600         (union tui_which_element) <data>: Remove.
1601         <data_window>: Change type.
1602         (struct tui_data_item_window): New.
1603         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1604         case.  Add assert.
1605         (~tui_data_item_window): New destructor.
1606         (free_content_elements): Remove DATA_ITEM_WIN case.
1607
1608 2019-06-25  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1611         Remove.
1612
1613 2019-06-25  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-data.h (struct tui_command_element): Remove.
1616         (union tui_which_element) <command>: Remove.
1617         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1618         assert.
1619         (free_content_elements): Remove CMD_WIN case.
1620
1621 2019-06-25  Tom Tromey  <tom@tromey.com>
1622
1623         * tui/tui-layout.c (tui_set_layout): Update.
1624         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1625         * tui/tui-data.c (layout_def): Update.
1626
1627 2019-06-25  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1630         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1631         (tui_source_window_base::set_new_height): Update.
1632         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1633         Update.
1634         (tui_set_locator_fullname, tui_set_locator_info)
1635         (tui_show_frame_info): Update.
1636         * tui/tui-source.c (tui_set_source_content)
1637         (tui_source_is_displayed): Update.
1638         * tui/tui-layout.c (show_source_disasm_command, show_data)
1639         (show_source_or_disasm_and_command): Update.
1640         * tui/tui-disasm.c (tui_set_disassem_content)
1641         (tui_get_begin_asm_address): Update.
1642         * tui/tui-data.h (struct tui_locator_element): Remove.
1643         (union tui_which_element) <locator>: Remove.
1644         (struct tui_locator_window): New.
1645         (tui_locator_win_info_ptr): Change return type.
1646         * tui/tui-data.c (_locator): Change type.
1647         (tui_locator_win_info_ptr): Change return type.
1648         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1649         (tui_alloc_content): Add assert.
1650
1651 2019-06-25  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-winsource.c
1654         (tui_exec_info_window::maybe_allocate_content): New method.
1655         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1656         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1657         (make_source_or_disasm_window): Add cast.
1658         * tui/tui-data.h (union tui_which_element) <simple_string>:
1659         Remove.
1660         (struct tui_source_info): New.
1661         (struct tui_source_window_base) <execution_info>: Change type.
1662         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1663         case, and add assert.
1664         (tui_alloc_content): Add assert.
1665
1666 2019-06-25  Tom Tromey  <tom@tromey.com>
1667
1668         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1669         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1670         * tui/tui-data.c (tui_alloc_win_info): Remove.
1671
1672 2019-06-25  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1675         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1676         can_highlight.
1677
1678 2019-06-25  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1681         make_visible_with_new_height method.
1682         (tui_win_info::make_visible_with_new_height): New method.
1683         (tui_source_window_base::do_make_visible_with_new_height)
1684         (tui_data_window::do_make_visible_with_new_height)
1685         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1686         (make_visible_with_new_height): Remove.
1687         (tui_resize_all, tui_adjust_win_heights): Use
1688         make_visible_with_new_height method.
1689         * tui/tui-data.h (struct tui_win_info)
1690         <do_make_visible_with_new_height, make_visible_with_new_height>:
1691         New methods.
1692         (struct tui_source_window_base, struct tui_data_window)
1693         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1694         methods.
1695
1696 2019-06-25  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1699         method.
1700         (update_tab_width): Call update_tab_width method.
1701         * tui/tui-data.h (struct tui_win_info)
1702         (struct tui_source_window_base) <update_tab_width>: New methods.
1703
1704 2019-06-25  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1707         parameter.
1708         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1709         parameter.
1710         (tui_gen_win_info::make_visible): Update.
1711         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1712         parameter.
1713         * tui/tui-data.h (enum tui_box): New enum.
1714         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1715
1716 2019-06-25  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1719         init_and_make_win for EXEC_INFO_WIN.
1720         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1721         longer inline.
1722         (struct tui_win_info) <~tui_win_info>: Inline.
1723         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1724         Don't declare.
1725         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1726         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1727         Remove.
1728         (tui_initialize_static_data): Update.
1729         (~tui_gen_win_info): Handle more cleanup here.
1730         (~tui_source_window_base): Delete "execution_info".
1731         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1732
1733 2019-06-25  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-layout.c (make_command_window): Don't set
1736         can_highlight.
1737         (show_source_disasm_command): Call the reset method.
1738         (show_data): Don't set can_highlight.  Call the reset method.
1739         (tui_gen_win_info::reset): Rename from init_gen_win_info
1740         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1741         (show_source_or_disasm_and_command): Call the reset method.
1742         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1743         (struct tui_cmd_window): Set can_highlight.
1744
1745 2019-06-25  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1748         from make_visible.
1749         (tui_make_visible, tui_make_invisible): Rewrite.
1750         (tui_win_info::make_visible): Remove.
1751         (tui_source_window_base::make_visible): Update.
1752         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1753         method.  Moved from...
1754         (struct tui_win_info) <make_visible>: ...here.
1755
1756 2019-06-25  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-winsource.c
1759         (tui_source_window_base::do_scroll_horizontal): Remove direction
1760         parameter.
1761         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1762         direction parameter.
1763         * tui/tui-win.c (tui_win_info::forward_scroll)
1764         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1765         (tui_win_info::right_scroll): Update.
1766         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1767         direction parameter.
1768         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1769         direction parameter.
1770         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1771         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1772         Remove direction parameter.
1773         (struct tui_source_window_base, struct tui_source_window)
1774         (struct tui_disasm_window, struct tui_data_window)
1775         (struct tui_cmd_window): Update.
1776
1777 2019-06-25  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-winsource.h (tui_set_exec_info_content)
1780         (tui_show_exec_info_content, tui_erase_exec_info_content)
1781         (tui_clear_exec_info_content, tui_update_exec_info): Change
1782         argument to tui_source_window_base.
1783         * tui/tui-winsource.c (tui_set_exec_info_content)
1784         (tui_show_exec_info_content, tui_erase_exec_info_content)
1785         (tui_clear_exec_info_content, tui_update_exec_info): Change
1786         argument to tui_source_window_base.
1787
1788 2019-06-25  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1791         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1792
1793 2019-06-25  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1796         check.
1797
1798 2019-06-25  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1801         type to void.
1802         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1803         type to void.
1804         * tui/tui-source.c (tui_set_source_content): Update.
1805         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1806
1807 2019-06-25  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-win.c (window_name_completer, tui_set_focus)
1810         (tui_all_windows_info): Use name method.
1811         * tui/tui-data.h (struct tui_gen_win_info)
1812         (struct tui_source_window, struct tui_disasm_window)
1813         (struct tui_data_window, struct tui_cmd_window) <name>: New
1814         method.
1815         (tui_win_name): Don't declare.
1816         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1817         (tui_win_name): Remove.
1818
1819 2019-06-25  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-winsource.h (tui_update_source_window)
1822         (tui_update_source_window_as_is): Change parameter type.
1823         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1824         to be a tui_source_window_base.
1825         (tui_update_source_window_as_is): Likewise.
1826         * tui/tui-win.c (make_visible_with_new_height): Update.
1827
1828 2019-06-25  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-winsource.c (tui_erase_source_content)
1831         (tui_show_source_content, tui_show_exec_info_content)
1832         (tui_erase_exec_info_content): Use refresh_window method.
1833         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1834         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1835         from tui_refresh_win.
1836         (tui_data_window::refresh_window): New method.
1837         (tui_win_info::refresh, tui_source_window_base::refresh)
1838         (tui_refresh_all): Use refresh_window method.
1839         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1840         method.
1841         * tui/tui-regs.c (tui_display_register): Call refresh_window
1842         method.
1843         * tui/tui-layout.c (show_source_disasm_command)
1844         (show_source_or_disasm_and_command): Call refresh_window method.
1845         * tui/tui-data.h (struct tui_gen_win_info)
1846         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1847         New method.
1848
1849 2019-06-25  Tom Tromey  <tom@tromey.com>
1850
1851         * tui/tui.c (tui_rl_other_window, tui_enable)
1852         (tui_is_window_visible, tui_get_command_dimension): Update.
1853         * tui/tui-winsource.c (tui_update_source_window_as_is)
1854         (tui_clear_source_content, tui_erase_source_content)
1855         (tui_show_source_line, tui_source_window_base::refill)
1856         (tui_source_window_base::do_scroll_horizontal)
1857         (tui_source_window_base::set_is_exec_point_at)
1858         (tui_update_breakpoint_info, tui_set_exec_info_content)
1859         (tui_alloc_source_buffer, tui_line_is_displayed)
1860         (tui_addr_is_displayed): Update.
1861         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1862         (tui_check_and_display_highlight_if_needed)
1863         (tui_win_info::make_visible, tui_win_info::refresh)
1864         (tui_refresh_all): Update.
1865         * tui/tui-windata.c (tui_first_data_item_displayed)
1866         (tui_delete_data_content_windows, tui_erase_data_content)
1867         (tui_display_all_data, tui_data_window::refresh_all)
1868         (tui_check_data_values): Update.
1869         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1870         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1871         (tui_win_info::backward_scroll, tui_refresh_all_win)
1872         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1873         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1874         (tui_source_window_base::set_new_height)
1875         (tui_data_window::set_new_height)
1876         (make_invisible_and_set_new_height)
1877         (make_visible_with_new_height, new_height_ok)
1878         (parse_scrolling_args): Update.
1879         * tui/tui-stack.c (tui_show_frame_info): Update.
1880         * tui/tui-source.c (tui_set_source_content)
1881         (tui_set_source_content_nil, tui_source_is_displayed)
1882         (tui_source_window::do_scroll_vertical): Update.
1883         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1884         (tui_display_registers_from, tui_display_reg_element_at_line)
1885         (tui_check_register_values, tui_reg_command): Update.
1886         * tui/tui-layout.c (tui_default_win_height)
1887         (show_source_disasm_command, show_data, init_and_make_win)
1888         (show_source_or_disasm_and_command): Update.
1889         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1890         (tui_redisplay_readline, tui_mld_flush)
1891         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1892         (tui_getc): Update.
1893         * tui/tui-disasm.c (tui_set_disassem_content)
1894         (tui_disasm_window::do_scroll_vertical): Update.
1895         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1896         Now virtual.
1897         (struct tui_win_info): Derive from tui_gen_win_info.
1898         <~tui_win_info>: Mark as override.
1899         <generic>: Remove member.
1900         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1901         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1902         (~tui_data_window, ~tui_win_info)
1903         (tui_free_all_source_wins_content): Update.
1904         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1905
1906 2019-06-25  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-layout.c (init_and_make_win): Use new.
1909         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1910         destructor, initializers.
1911         (tui_alloc_generic_win_info): Don't declare.
1912         * tui/tui-data.c (_locator): Add argument to constructor.
1913         (source_win, disasm_win): New globals.
1914         (exec_info): Remove.
1915         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1916         Update.
1917         (tui_alloc_generic_win_info): Remove.
1918         (init_content_element): Use new.
1919         (tui_win_info::tui_win_info): Update.
1920         (free_content_elements) <case DATA_WIN>: Use delete.
1921
1922 2019-06-25  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1925         * tui/tui-windata.c (tui_first_data_item_displayed)
1926         (tui_delete_data_content_windows): Update.
1927         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1928         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1929         (tui_display_registers_from, tui_check_register_values): Update.
1930         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1931         pointer.
1932         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1933         window.
1934         (tui_free_data_content): Update.
1935         (free_content_elements) <case DATA_WIN>: Free the window.
1936
1937 2019-06-25  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1940         Update.
1941         * tui/tui-layout.c (make_command_window)
1942         (show_source_disasm_command, show_data, init_and_make_win)
1943         (show_source_or_disasm_and_command): Update.
1944         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1945         method.
1946         <can_highight, is_highlighted>: Now bool.
1947         (tui_set_win_highlight): Don't declare.
1948         * tui/tui-data.c (tui_set_win_highlight): Remove.
1949
1950 2019-06-25  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-wingeneral.c (make_visible): Remove check of window
1953         type.
1954
1955 2019-06-25  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-win.c (tui_win_info::max_height)
1958         (tui_cmd_window::max_height): New methods.
1959         (new_height_ok): Call max_height.
1960         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1961         <max_height>: New method.
1962
1963 2019-06-25  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-win.c (tui_source_window_base::set_new_height)
1966         (tui_data_window::set_new_height): New methods.
1967         (make_invisible_and_set_new_height): Call set_new_height method.
1968         * tui/tui-data.h (struct tui_win_info)
1969         (struct tui_source_window_base, struct tui_data_window)
1970         <set_new_height>: New method.
1971
1972 2019-06-25  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1975         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1976         tui_refresh_data_win.
1977         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1978         method.
1979         (tui_refresh_all_win): Call the refresh_all method.
1980         (tui_set_focus): Likewise.
1981         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1982         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1983         Likewise.
1984
1985 2019-06-25  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-winsource.h (tui_refill_source_window)
1988         (tui_set_is_exec_point_at): Don't declare.
1989         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1990         (tui_source_window_base::refill): Rename from
1991         tui_refill_source_window.
1992         (tui_source_window_base::do_scroll_horizontal): Update.
1993         (tui_source_window_base::set_is_exec_point_at): Rename from
1994         tui_set_is_exec_point_at.
1995         (tui_update_all_breakpoint_info): Update.
1996         * tui/tui-stack.c (tui_show_frame_info): Update.
1997         * tui/tui-layout.c (show_data): Add cast.
1998         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1999         * tui/tui-data.h (struct tui_source_window_base) <refill,
2000         set_is_exec_point_at>: New methods.
2001         (tui_source_windows, tui_add_to_source_windows): Update types.
2002         (tui_add_to_source_windows): Remove redundant declaration.
2003         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2004         (tui_source_windows): Change return type.
2005         (tui_clear_source_windows_detail): Update.
2006         (tui_add_to_source_windows): Change type of parameter.
2007         (tui_free_all_source_wins_content): Update.
2008
2009 2019-06-25  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-wingeneral.c (tui_win_info::refresh)
2012         (tui_source_window_base::refresh): New methods.
2013         (tui_refresh_all): Call the refresh method.
2014         * tui/tui-data.h (struct tui_win_info)
2015         (struct tui_source_window_base) <refresh>: New method.
2016
2017 2019-06-25  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui.h (tui_is_window_visible): Return bool.
2020         * tui/tui.c (tui_is_window_visible): Return bool.
2021         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2022         (tui_make_visible, tui_make_invisible)
2023         (tui_win_info::make_visible)
2024         (tui_source_window_base::make_visible, make_all_visible)
2025         (tui_make_all_visible, tui_make_all_invisible): Update.
2026         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2027         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2028         bool.
2029         (struct tui_win_info, struct tui_source_window_base)
2030         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2031         * tui/tui-data.c (tui_init_generic_part): Update.
2032
2033 2019-06-25  Tom Tromey  <tom@tromey.com>
2034
2035         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2036         (tui_source_window_base::make_visible): New methods.
2037         (make_all_visible): Make method call.
2038         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2039         (struct tui_source_window_base, struct tui_cmd_window): Override
2040         make_visible.
2041         (tui_win_is_source_type): Don't declare.
2042         * tui/tui-data.c (tui_win_is_source_type): Remove.
2043
2044 2019-06-25  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2047         NULL check.
2048
2049 2019-06-25  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2052         Inline constructor.  Add initializers for members.
2053         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2054         constructors; now inline in class.
2055
2056 2019-06-25  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-regs.c (tui_show_registers): Update.
2059         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2060         bool.
2061         * tui/tui-data.c (tui_data_window::clear_detail)
2062         (tui_data_window): Update.
2063
2064 2019-06-25  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-windata.c (tui_display_all_data)
2067         (tui_display_data_from_line, tui_display_data_from)
2068         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2069         Update.
2070         * tui/tui-regs.c (tui_last_regs_line_no)
2071         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2072         (tui_show_registers, tui_show_register_group)
2073         (tui_display_registers_from, tui_display_reg_element_at_line)
2074         (tui_display_registers_from_line, tui_check_register_values)
2075         (tui_reg_next, tui_reg_prev): Update.
2076         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2077         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2078         tui_data_window.
2079         (struct tui_win_info) <detail>: Remove.  Add new fields from
2080         tui_data_info.
2081         (TUI_DATA_WIN): Add cast.
2082         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2083         (~tui_data_window): Simplify.
2084
2085 2019-06-25  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-layout.c (show_source_disasm_command)
2088         (show_source_or_disasm_and_command): Update.
2089         * tui/tui-io.c (update_cmdwin_start_line)
2090         (tui_redisplay_readline): Update.
2091         * tui/tui-data.h (struct tui_command_info): Remove.
2092         (struct tui_win_info) <detail>: Remove command_info member.
2093         (struct tui_data_window) <start_line>: New member, from
2094         tui_command_info.
2095         (TUI_CMD_WIN): Add casts.
2096
2097 2019-06-25  Tom Tromey  <tom@tromey.com>
2098
2099         * tui/tui-winsource.c (tui_update_source_window)
2100         (tui_refill_source_window)
2101         (tui_source_window_base::do_scroll_horizontal)
2102         (tui_update_breakpoint_info, tui_set_exec_info_content)
2103         (tui_show_exec_info_content, tui_erase_exec_info_content)
2104         (tui_clear_exec_info_content): Update.
2105         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2106         Update.
2107         * tui/tui-win.c (make_invisible_and_set_new_height)
2108         (make_visible_with_new_height): Update.
2109         * tui/tui-source.c (tui_set_source_content)
2110         (tui_show_symtab_source): Update.
2111         * tui/tui-layout.c (extract_display_start_addr)
2112         (show_source_disasm_command, show_data)
2113         (make_source_or_disasm_window)
2114         (show_source_or_disasm_and_command): Update.
2115         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2116         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2117         "gdbarch".
2118         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2119         to tui_source_window_base.
2120         (struct tui_win_info) <detail>: Remove source_info member.
2121         (struct tui_source_window_base) <has_locator>: Inline.
2122         Move contents from tui_source_info; rename has_locator member to
2123         m_has_locator.
2124         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2125         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2126         header file.
2127         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2128         Simplify.
2129         (tui_free_all_source_wins_content): Cast to
2130         tui_source_window_base.
2131
2132 2019-06-25  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-win.c (make_invisible_and_set_new_height)
2135         (make_visible_with_new_height): Call has_locator method.
2136         * tui/tui-layout.c (show_source_disasm_command, show_data)
2137         (show_source_or_disasm_and_command): Update for bool change.
2138         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2139         (tui_win_info) <has_locator>: New method.
2140         (struct tui_source_window_base) <has_locator>: New method.
2141         (tui_win_has_locator): Don't declare.
2142         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2143         from tui_win_has_locator.
2144         (tui_source_window_base): Use false, not FALSE.
2145
2146 2019-06-25  Tom Tromey  <tom@tromey.com>
2147
2148         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2149         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2150         clear_detail method directly.
2151         (tui_clear_win_detail): Remove.
2152
2153 2019-06-25  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2156         "this", not TUI_DISASM_WIN.
2157
2158 2019-06-25  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2161         declare.
2162         * tui/tui-winsource.c
2163         (tui_source_window_base::do_scroll_horizontal): Rename from
2164         tui_horizontal_source_scroll.
2165         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2166         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2167         from tui_vertical_data_scroll.
2168         * tui/tui-win.h (tui_scroll): Don't declare.
2169         * tui/tui-win.c (tui_win_info::forward_scroll)
2170         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2171         (tui_win_info::right_scroll): Rename and update.
2172         (tui_scroll_forward_command, tui_scroll_backward_command)
2173         (tui_scroll_left_command, tui_scroll_right_command): Update.
2174         (tui_scroll): Remove.
2175         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2176         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2177         from tui_vertical_source_scroll.
2178         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2179         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2180         from tui_vertical_disassem_scroll.
2181         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2182         do_scroll_horizontal>: New methods.
2183         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2184         Likewise.
2185         (struct tui_source_window_base): Add do_scroll_horizontal.
2186         (struct tui_source_window, struct tui_disasm_window): Add
2187         do_scroll_vertical.
2188         (struct tui_data_window, struct tui_cmd_window): Add
2189         do_scroll_horizontal and do_scroll_vertical.
2190         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2191
2192 2019-06-25  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-data.h (struct tui_source_window_base): New struct.
2195         (struct tui_source_window): Derive from tui_source_window_base.
2196         (struct tui_disasm_window): New struct.
2197         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2198         from tui_source_window::clear_detail.
2199         (tui_source_window_base): Rename from tui_source_window.
2200         (~tui_source_window_base): Rename from ~tui_source_window.
2201         (tui_alloc_win_info): Create a tui_disasm_window.
2202
2203 2019-06-25  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui-data.h (struct tui_source_window)
2206         (struct tui_data_window): Declare destructors.
2207         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2208         destructors.
2209         (tui_win_info): Simplify.
2210
2211 2019-06-25  Tom Tromey  <tom@tromey.com>
2212
2213         * tui/tui-winsource.c (tui_display_main)
2214         (tui_update_source_windows_with_addr)
2215         (tui_update_all_breakpoint_info): Update.
2216         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2217         (new_height_ok, parse_scrolling_args): Update.
2218         * tui/tui-stack.c (tui_show_frame_info): Update.
2219         * tui/tui-data.h (struct tui_list): Remove.
2220         (tui_source_windows): Return a reference to a std::vector.
2221         * tui/tui-data.c (source_windows): Now a std::vector.
2222         (tui_source_windows): Change return type.
2223         (tui_clear_source_windows): Rewrite.
2224         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2225         (tui_free_all_source_wins_content): Rewrite.
2226
2227 2019-06-25  Tom Tromey  <tom@tromey.com>
2228
2229         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2230         (struct tui_data_window, struct tui_cmd_window): Declare
2231         clear_detail method.
2232         * tui/tui-data.c (tui_source_window::clear_detail)
2233         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2234         methods.
2235         (tui_clear_win_detail): Simplify.
2236
2237 2019-06-25  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-layout.c (make_source_window, make_disasm_window)
2240         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2241         Return the new window.
2242         (show_source_disasm_command, show_data)
2243         (show_source_or_disasm_and_command): Update.
2244
2245 2019-06-25  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2248         parameter.  Return the new window.
2249         (show_source_disasm_command): Update and remove NULL check.
2250         (show_source_or_disasm_and_command): Update.
2251
2252 2019-06-25  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2255
2256 2019-06-25  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-data.h (struct tui_win_info): Make constructor
2259         protected.  Make destructor virtual.  Add initializers.
2260         (tui_source_window, tui_data_window, tui_cmd_window): New
2261         classes.
2262         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2263         constructor.  Add "type" parameter.
2264         (tui_source_window, tui_data_window, tui_cmd_window): New
2265         constructors.
2266         (tui_alloc_win_info): Instantiate the appropriate subclass.
2267
2268 2019-06-25  Tom Tromey  <tom@tromey.com>
2269
2270         * tui/tui-win.c (tui_resize_all): Use delete.
2271         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2272         destructor.
2273         (tui_free_window): Don't declare.
2274         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2275         Update.
2276
2277 2019-06-25  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-data.h (struct tui_win_info): Add constructor.
2280         * tui/tui-data.c (tui_alloc_win_info): Use new.
2281         (tui_free_window): Use delete.
2282
2283 2019-06-22  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2286         declare.
2287         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2288
2289 2019-06-22  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2292         declare.
2293         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2294
2295 2019-06-22  Tom de Vries  <tdevries@suse.de>
2296
2297         * dwarf2read.c (create_addrmap_from_aranges)
2298         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2299         instead of '%zu'.
2300
2301 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2302
2303         * dwarf2read.h (dwarf2_section_info_def): Remove.
2304         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2305         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2306         std::vector<dwarf2_section_info>.
2307         (struct dwo_file) <~dwo_file>: Remove.
2308         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2309         types field.
2310         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2311         (dwarf2_read_debug_names): Likewise.
2312         (create_debug_types_hash_table): Change parameter type to
2313         array_view, adjust code accordingly.
2314         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2315         (partial_die_info::fixup): Likewise.
2316         (determine_prefix): Likewise.
2317         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2318
2319 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2320
2321         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2322         gdb_bfd_ref_ptr.
2323         <~dwo_file>: Remove call to gdb_bfd_unref.
2324         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2325         gdb_bfd_ref_ptr::get.
2326
2327 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2328
2329         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2330         type to htab_up.
2331         * dwarf2read.c (struct dwo_file): Initialize fields.
2332         <~dwo_file>: New.
2333         (free_dwo_file): Remove, move content to ~dwo_file.
2334         (struct dwo_file_deleter): Remove.
2335         (dwo_file_up>: Remove custom deleter.
2336         (free_dwo_files): Remove.
2337         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2338         dwo_files.
2339         (process_skeletonless_type_units): Call unique_ptr::get.
2340         (allocate_dwo_file_hash_table): Add deleter to created hash
2341         table.  Change return type to htab_up.
2342         (lookup_dwo_file_slot): Don't memset dwo_file, call
2343         unique_ptr::get.
2344         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2345         (create_dwo_unit_in_dwp_v2): Likewise.
2346         (open_and_init_dwo_file): Likewise.
2347         (free_dwo_file_from_slot): Remove.
2348
2349 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2350
2351         * dwarf2read.h (struct dwarf2_section_info) <readin,
2352         is_virtual>: Change type to bool.
2353         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2354         true instead of 1.
2355
2356 2019-06-19  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui-data.h (tui_init_content_element): Don't declare.
2359
2360 2019-06-19  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-data.h (tui_init_win_info): Don't declare.
2363
2364 2019-06-19  Tom de Vries  <tdevries@suse.de>
2365
2366         * dwarf2read.h (abstract_to_concrete): Change type to
2367         std::unordered_map<sect_offset, std::vector<sect_offset>,
2368         gdb::hash_enum<sect_offset>>.
2369
2370 2019-06-19  Tom Tromey  <tromey@adacore.com>
2371
2372         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2373         EVAL_AVOID_SIDE_EFFECTS specially.
2374
2375 2019-06-19  Tom Tromey  <tromey@adacore.com>
2376
2377         * source-cache.c (highlighter): New global.
2378         (source_cache::get_source_lines): Create a highlighter on demand.
2379
2380 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2381
2382         * defs.h (deprecated_interactive_hook): Delete declaration.
2383         * interps.c (clear_interpreter_hooks): Remove use of
2384         deprecated_interactive_hook.
2385         * top.c (deprecated_interactive_hook): Delete definition.
2386         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2387
2388 2019-06-18  Tom de Vries  <tdevries@suse.de>
2389
2390         PR gdb/24515
2391         * dwarf2read.h (abstract_to_concrete): Change type from
2392         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2393         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2394         * dwarf2read.c (read_variable): Update.
2395         (dwarf2_fetch_die_loc_sect_off): Update.
2396
2397 2019-06-17  Tom de Vries  <tdevries@suse.de>
2398
2399         PR gdb/24617
2400         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2401         accessing parent[parent_len - 1].
2402
2403 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2404
2405         PR gdb/24364
2406         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2407         call dtrace_process_dof with NULL dof.
2408
2409 2019-06-16  Tom de Vries  <tdevries@suse.de>
2410
2411         PR gdb/24445
2412         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2413
2414 2019-06-16  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2417         (make_all_visible): Use address of member.
2418
2419 2019-06-16  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2422         (tui_free_window, free_content, free_content_elements): Remove
2423         unnecessary cast.
2424         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2425         cast.
2426         * tui/tui-regs.c (tui_show_register_group)
2427         (tui_display_registers_from, tui_display_reg_element_at_line):
2428         Remove unnecessary cast.
2429
2430 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2431
2432         * linux-nat.c (normal_mask): Delete.
2433         (_initialize_linux_nat): Don't initialise normal_mask.
2434
2435 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2436
2437         PR gdb/24445
2438         * dwarf-index-write.h (write_psymtabs_to_index): Add
2439         dwz_basename parameter.
2440         * dwarf-index-write.c (write_gdbindex): Move file writing to
2441         write_gdbindex_1.  Change return type void.
2442         (assert_file_size): Move up, remove filename parameter.
2443         (write_gdbindex_1): New function.
2444         (write_debug_names): Change return type to void, call
2445         assert_file_size.
2446         (struct index_wip_file): New struct.
2447         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2448         file logic to index_wip_file.  Write index for dwz file if
2449         needed.
2450         (save_gdb_index_command): Pass basename of dwz file, if present.
2451         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2452         build-id of dwz file, if present.
2453         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2454         (dwarf2_get_dwz_file): Likewise.
2455         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2456         (dwarf2_get_dwz_file): Likewise.
2457
2458 2019-06-16  Tom Tromey  <tom@tromey.com>
2459
2460         * coffread.c (process_coff_symbol): Use xstrdup.
2461         * value.c (create_internalvar): Use xstrdup.
2462
2463 2019-06-16  Tom Tromey  <tom@tromey.com>
2464
2465         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2466         * breakpoint.c (stopin_command, stopat_command)
2467         (until_break_command, decode_location_default): Remove unnecessary
2468         cast.
2469         * utils.c (subset_compare): Remove unnecessary cast.
2470         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2471         cast.
2472         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2473         cast.
2474         * infcmd.c (path_command): Remove unnecessary cast.
2475         * coffread.c (decode_type): Remove unnecessary cast.
2476         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2477         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2478         * tui/tui-stack.c (tui_show_locator_content)
2479         (tui_show_frame_info): Remove unnecessary cast.
2480         * tui/tui-win.c (tui_scroll_forward_command)
2481         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2482         (parse_scrolling_args): Remove unnecessary cast.
2483         * tui/tui-data.c (init_win_info, tui_del_window)
2484         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2485         (free_content_elements): Remove unnecessary cast.
2486         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2487         unnecessary cast.
2488         * tui/tui-source.c (tui_set_source_content)
2489         (tui_vertical_source_scroll): Remove unnecessary cast.
2490         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2491         cast.
2492         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2493         * tui/tui-regs.c (tui_display_registers_from)
2494         (tui_display_register): Remove unnecessary cast.
2495         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2496         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2497         (make_visible): Remove unnecessary cast.
2498         * tui/tui-winsource.c (tui_erase_source_content)
2499         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2500         unnecessary cast.
2501         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2502         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2503         * stabsread.c (read_type, read_array_type, read_range_type):
2504         Remove unnecessary cast.
2505         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2506         (parse_symbol, parse_type, upgrade_type, parse_external)
2507         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2508         unnecessary cast.
2509         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2510
2511 2019-06-16  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-data.c (tui_alloc_generic_win_info)
2514         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2515         checks.
2516
2517 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2518             Andrew Burgess  <andrew.burgess@embecosm.com>
2519
2520         * f-typeprint.c (f_print_type): Don't return early for not
2521         associated or not allocated types.
2522         (f_type_print_varspec_suffix): Add print_rank parameter and print
2523         ranks of array types in case they dangling.
2524         (f_type_print_base): Add print_rank parameter.
2525
2526 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2527
2528         * NEWS: Mention new MI commands.
2529         * break-catch-throw.c (enum exception_event_kind): Move to
2530         breakpoint.h.
2531         (print_mention_exception_catchpoint): Output text as a single
2532         message.
2533         (catch_exception_command_1): Rename to...
2534         (catch_exception_event): ...this, make non-static, update header
2535         command, and change some parameter types.
2536         (catch_catch_command): Update for changes to
2537         catch_exception_command_1.
2538         (catch_throw_command): Likewise.
2539         (catch_rethrow_command): Likewise.
2540         * breakpoint.c (enum exception_event_kind): Delete.
2541         * breakpoint.h (enum exception_event_kind): Moved here from
2542         break-catch-throw.c.
2543         (catch_exception_event): Declare.
2544         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2545         (mi_cmd_catch_throw): New function.
2546         (mi_cmd_catch_rethrow): New function.
2547         (mi_cmd_catch_catch): New function.
2548         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2549         'catch-catch' entries.
2550         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2551         (mi_cmd_catch_rethrow): Declare.
2552         (mi_cmd_catch_catch): Declare.
2553
2554 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2555
2556         * annotate.c (annotate_source_line): Change return type to void,
2557         update implementation to match.
2558         * annotate.h (annotate_source_line): Change return type to void,
2559         update header comment.
2560         * stack.c (print_frame_info): Don't change what frame information
2561         is printed based on whether annotations are on or not.
2562
2563 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2564
2565         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2566         (annotate_source): Make static.
2567         (annotate_source_line): Moved from source.c and renamed from
2568         identify_source_line.  Update the return type.
2569         * annotate.h (annotate_source): Delete declaration.
2570         (annotate_source_line): Declaration moved from source.h, and
2571         renamed from identify_source_line.  Return type updated.
2572         * source.c (identify_source_line): Moved to annotate.c and renamed
2573         to annotate_source_line.
2574         (info_line_command): Remove check of annotation_level.
2575         * source.h (identify_source_line): Move declaration to annotate.h
2576         and rename to annotate_source_line.
2577         * stack.c: Add 'annotate.h' include.
2578         (print_frame_info): Remove check of annotation_level before
2579         calling annotate_source_line.
2580
2581 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2582
2583         * source-cache.c (source_cache::get_plain_source_lines): Use
2584         open_source_file_with_line_charpos instead of just
2585         open_source_file, remove call to find_source_lines.
2586         (source_cache::get_source_lines): Likewise.
2587         * source.c (find_source_lines): Make static.
2588         (get_filename_and_charpos): Renamed into...
2589         (open_source_file_with_line_charpos): ..this along with changes to
2590         return a scoped_fd, and some other minor clean ups.
2591         (identify_source_line): Use open_source_file_with_line_charpos.
2592         (search_command_helper): Use open_source_file_with_line_charpos
2593         instead of just open_source_file, remove call to
2594         find_source_lines.
2595         * source.h (open_source_file_with_line_charpos): Declare new
2596         function.
2597         (find_source_lines): Delete declaration.
2598
2599 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2600
2601         * source.c (get_filename_and_charpos): Remove fullname
2602         parameter.
2603         (identify_source_line): Update call to get_filename_and_charpos.
2604
2605 2019-06-14  Tom Tromey  <tromey@adacore.com>
2606
2607         PR gdb/24502:
2608         * ui-style.h (skip_ansi_escape): Update comment.
2609         * ui-file.h (class no_terminal_escape_file): New class.
2610         * ui-file.c (no_terminal_escape_file::write)
2611         (no_terminal_escape_file::puts): New methods.
2612         * cli/cli-logging.c (handle_redirections): Use
2613         no_terminal_escape_file.
2614
2615 2019-06-14  Tom Tromey  <tromey@adacore.com>
2616
2617         * NEWS: Move convenience variable news above Python news.
2618
2619 2019-06-14  Tom Tromey  <tom@tromey.com>
2620
2621         * gnulib: Move directory to top-level.
2622         * configure.ac: Don't configure gnulib.
2623         * configure: Rebuild.
2624         * common/common-defs.h: Use new path to gnulib.
2625         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2626         (GNULIB_H): Remove.
2627         (INCGNU): Look in new gnulib location.
2628         (HFILES_NO_SRCDIR): Remove gnulib files.
2629         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2630         (generated_files): Remove GNULIB_H.
2631         ($(LIBGNU), all-lib): Remove targets.
2632         (distclean): Don't mention GNULIB_BUILDDIR.
2633         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2634
2635 2019-06-14  Tom Tromey  <tromey@adacore.com>
2636
2637         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2638         Warn if symbol file does not provide any symbols.
2639
2640 2019-06-14  Tom Tromey  <tromey@adacore.com>
2641
2642         * source.c (find_and_open_source): Respect basenames_may_differ.
2643
2644 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2645
2646         * annotate.c (annotate_breakpoints_invalid): Make use of
2647         scoped_restore_terminal_state.
2648         (annotate_frames_invalid): Likewise.
2649
2650 2019-06-14  Tom Tromey  <tromey@adacore.com>
2651
2652         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2653         allow assignment to an internalvar.
2654
2655 2019-06-14  Tom Tromey  <tromey@adacore.com>
2656
2657         * ada-lex.l: Allow "_" in attribute names.
2658
2659 2019-06-14  Tom Tromey  <tromey@adacore.com>
2660
2661         PR gdb/24653:
2662         * regcache.c (registers_changed): Don't call alloca.
2663         * top.c (execute_command): Don't call alloca.
2664
2665 2019-06-13  Pedro Alves  <palves@redhat.com>
2666
2667         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2668         'expression'.  When parsing an expression, error out if there's
2669         junk after "unlimited".
2670         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2671         (do_set_command): Adjust calls to is_unlimited_literal.
2672
2673 2019-06-13  Pedro Alves  <palves@redhat.com>
2674
2675         * compile/compile.c (make_compile_options_def_group): Add braces
2676         around array_view initializer.
2677         * thread.c (make_thread_apply_all_options_def_group)
2678         (make_thread_apply_all_options_def_group): Likewise.
2679
2680 2019-06-13  Pedro Alves  <palves@redhat.com>
2681
2682         * NEWS (New commands): Mention "maint test-options
2683         require-delimiter", "maint test-options unknown-is-error", "maint
2684         test-options unknown-is-operand" and "maint show
2685         test-options-completion-result".
2686         (New command options, command completion): New section.
2687         (Completion improvements): New section.
2688         Mention that you can abbreviate "unlimited".
2689
2690 2019-06-13  Pedro Alves  <palves@redhat.com>
2691
2692         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2693         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2694         * unittests/cli-utils-selftests.c (test_parse_flags)
2695         (test_parse_flags_qcs): Delete.
2696         (test_cli_utils): Don't call deleted functions.
2697
2698 2019-06-13  Pedro Alves  <palves@redhat.com>
2699
2700         * thread.c: Include "cli/cli-option.h".
2701         (tp_array_compar_ascending): Global.
2702         (tp_array_compar): Delete function.
2703         (tp_array_compar_ascending, tp_array_compar_descending): New
2704         functions.
2705         (ascending_option_def, qcs_flag_option_def)
2706         (thr_qcs_flags_option_defs)
2707         (make_thread_apply_all_options_def_group)
2708         (make_thread_apply_options_def_group): New.
2709         (thread_apply_all_command): Use gdb::option::process_options.
2710         (thread_apply_command_completer)
2711         (thread_apply_all_command_completer): New.
2712         (thread_apply_command): Use gdb::option::process_options.
2713         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2714         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2715         to generate help text of "thread apply".  Adjust "taas"'s help.
2716         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2717         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2718
2719 2019-06-13  Pedro Alves  <palves@redhat.com>
2720
2721         * thread.c (thread_apply_command): Check for invalid TID with
2722         isdigit instead of !isalpha.
2723
2724 2019-06-13  Pedro Alves  <palves@redhat.com>
2725
2726         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2727         (validate_flags_qcs): New.
2728         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2729         (validate_flags_qcs): Declare.
2730         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2731         (make_frame_apply_options_def_group): New.
2732         (frame_apply_command_count): Process options with
2733         gdb::option::process_options.
2734         (frame_apply_completer): New.
2735         (frame_apply_level_completer, frame_apply_all_completer)
2736         (frame_apply_completer): New.
2737         (_initialize_stack): Update help of "frame apply", "frame apply
2738         level", "frame apply all" and "faas" to mention supported options
2739         and install command completers.
2740         * stack.h (frame_apply_all_completer): Declare.
2741         * thread.c: Include "stack.h".
2742         (tfaas_command): Add "--".
2743         (_initialize_thread): Update help "tfaas" to mention supported
2744         options and install command completer.
2745
2746 2019-06-13  Pedro Alves  <palves@redhat.com>
2747
2748         * completer.c (complete_nested_command_line): New.
2749         (gdb_completion_word_break_characters_throw): Add assertion.
2750         * completer.h (complete_nested_command_line): Declare.
2751
2752 2019-06-13  Pedro Alves  <palves@redhat.com>
2753
2754         * stack.c (parse_backtrace_qualifiers): New.
2755         (backtrace_command): Use it.
2756         (backtrace_command_completer): Complete on qualifiers.
2757
2758 2019-06-13  Pedro Alves  <palves@redhat.com>
2759
2760         * frame.c: Include "cli/cli-option.h.
2761         (user_set_backtrace_options): New.
2762         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2763         Delete.
2764         (get_prev_frame): Adjust.
2765         (boolean_option_def, uinteger_option_def)
2766         (set_backtrace_option_defs): New.
2767         (_initialize_frame): Adjust and use
2768         gdb::option::add_setshow_cmds_for_options to install "set
2769         backtrace past-main" and "set backtrace past-entry".
2770         * frame.h: Include "cli/cli-option.h".
2771         (struct frame_print_options): Forward declare.
2772         (print_frame_arguments_all, print_frame_arguments_scalars)
2773         (print_frame_arguments_none): Declare.
2774         (print_entry_values): Delete declaration.
2775         (struct frame_print_options, user_frame_print_options): New.
2776         (struct set_backtrace_options): New.
2777         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2778         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2779         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2780         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2781         (list_args_or_locals): Add frame_print_options parameter.
2782         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2783         * python/py-framefilter.c (enumerate_args): Pass down
2784         USER_FRAME_PRINT_OPTIONS.
2785         * stack.c: Include "cli/cli-option.h".
2786         (print_frame_arguments_all, print_frame_arguments_scalars)
2787         (print_frame_arguments_none): Declare.
2788         (print_raw_frame_arguments, print_entry_values): Delete.
2789         (user_frame_print_options): New.
2790         (boolean_option_def, enum_option_def, frame_print_option_defs):
2791         New.
2792         (struct backtrace_cmd_options): New.
2793         (bt_flag_option_def): New.
2794         (backtrace_command_option_defs): New.
2795         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2796         (print_frame_arg, read_frame_arg, print_frame_args)
2797         (print_frame_info, print_frame): Add frame_print_options parameter
2798         and use it.
2799         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2800         (backtrace_command_1): Add frame_print_options and
2801         backtrace_cmd_options parameters and use them.
2802         (make_backtrace_options_def_group): New.
2803         (backtrace_command): Process command options with
2804         gdb::option::process_options.
2805         (backtrace_command_completer): New.
2806         (_initialize_stack): Extend "backtrace"'s help to mention
2807         supported options.  Install completer for "backtrace".
2808         Install some settings commands with add_setshow_cmds_for_options.
2809
2810 2019-06-13  Pedro Alves  <palves@redhat.com>
2811
2812         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2813         and that "set/show print raw frame-arguments" are now deprecated.
2814
2815         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2816         command.
2817         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2818         * stack.c (_initialize_stack): Install "set/show print
2819         raw-frame-arguments", and deprecate "set/show print raw
2820         frame-arguments".
2821         * valprint.c (_initialize_valprint): Deprecate "set/show print
2822         raw".
2823
2824 2019-06-13  Pedro Alves  <palves@redhat.com>
2825
2826         * compile/compile.c (struct compile_options): New.
2827         (compile_flag_option_def, compile_command_option_defs)
2828         (make_compile_options_def_group): New.
2829         (compile_file_command): Handle options with
2830         gdb::option::process_options.
2831         (compile_file_command_completer): New function.
2832         (compile_code_command): Handle options with
2833         gdb::option::process_options.
2834         (compile_code_command_completer): New function.
2835         (_initialize_compiler): Install completers for "compile code" and
2836         "compile file".  Mention available options in "compile code" and
2837         "compile code"'s help.
2838         * completer.c (advance_to_completion_word): New, factored out from
2839         ...
2840         (advance_to_expression_complete_word_point): ... this.
2841         (advance_to_filename_complete_word_point): New.
2842         * completer.h (advance_to_filename_complete_word_point): New
2843         declaration.
2844
2845 2019-06-13  Pedro Alves  <palves@redhat.com>
2846
2847         * compile/compile.c: Include "cli/cli-option.h".
2848         (compile_print_value): Scope data pointer is now a
2849         value_print_options pointer; adjust.
2850         (compile_print_command): Process options.  Scope data pointer is
2851         now a value_print_options pointer; adjust.
2852         (_initialize_compile): Update "compile print"'s help to include
2853         supported options.  Install a completer for "compile print".
2854         * cp-valprint.c (show_vtblprint, show_objectprint)
2855         (show_static_field_print): Delete.
2856         (_initialize_cp_valprint): Don't install "set print
2857         static-members", "set print vtbl", "set print object" here.
2858         * printcmd.c: Include "cli/cli-option.h" and
2859         "common/gdb_optional.h".
2860         (print_command_parse_format): Rework to fill in a
2861         value_print_options instead of a format_data.
2862         (print_value): Change parameter type from format_data pointer to
2863         value_print_options reference.  Adjust.
2864         (print_command_1): Process options.  Adjust to pass down a
2865         value_print_options.
2866         (print_command_completer): New.
2867         (_initialize_printcmd): Install print_command_completer as
2868         handle_brkchars completer for the "print" command.  Update
2869         "print"'s help to include supported options.
2870         * valprint.c: Include "cli/cli-option.h".
2871         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2872         here from cp-valprint.c.
2873         (boolean_option_def, uinteger_option_def)
2874         (value_print_option_defs, make_value_print_options_def_group):
2875         New.  Use gdb::option::add_setshow_cmds_for_options to install
2876         "set print elements", "set print null-stop", "set print repeats",
2877         "set print pretty", "set print union", "set print array", "set
2878         print address", "set print symbol", "set print array-indexes".
2879         * valprint.h: Include <string> and "cli/cli-option.h".
2880         (make_value_print_options_def_group): Declare.
2881         (print_value): Change parameter type from format_data pointer to
2882         value_print_options reference.
2883         (print_command_completer): Declare.
2884
2885 2019-06-13  Pedro Alves  <palves@redhat.com>
2886
2887         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2888         (COMMON_SFILES): Add maint-test-settings.c.
2889         * cli/cli-decode.c (boolean_enums): New global, factored out from
2890         ...
2891         (add_setshow_boolean_cmd): ... here.
2892         * cli/cli-decode.h (boolean_enums): Declare.
2893         * cli/cli-option.c: New file.
2894         * cli/cli-option.h: New file.
2895         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2896         factored out from ...
2897         (parse_cli_boolean_value(const char *)): ... this.
2898         (is_unlimited_literal): Change parameter type to pointer to
2899         pointer.  Adjust and advance ARG pointer.
2900         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2901         (parse_cli_var_enum): New, factored out from ...
2902         (do_set_command): ... this.  Adjust.
2903         * cli/cli-setshow.h (parse_cli_boolean_value)
2904         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2905         (parse_cli_var_enum): Declare.
2906         * cli/cli-utils.c: Include "cli/cli-option.h".
2907         (get_ulongest): New.
2908         * cli/cli-utils.h (get_ulongest): Declare.
2909         (check_for_argument): New overloads.
2910         * maint-test-options.c: New file.
2911
2912 2019-06-13  Pedro Alves  <palves@redhat.com>
2913
2914         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2915         parse a range if "-" is at the end of the string.
2916
2917 2019-06-13  Pedro Alves  <palves@redhat.com>
2918
2919         * cli/cli-setshow.c (parse_auto_binary_operation)
2920         (parse_cli_boolean_value): Don't allow "o".
2921
2922 2019-06-13  Pedro Alves  <palves@redhat.com>
2923
2924         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2925         * NEWS: Mention maint test-settings KIND.
2926         * maint-test-settings.c: New file.
2927
2928 2019-06-13  Pedro Alves  <palves@redhat.com>
2929
2930         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2931         completer.
2932         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2933         "set" completers.
2934
2935 2019-06-13  Pedro Alves  <palves@redhat.com>
2936
2937         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2938         after item.
2939
2940 2019-06-13  Pedro Alves  <palves@redhat.com>
2941
2942         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2943
2944 2019-06-13  Pedro Alves <palves@redhat.com>
2945
2946         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2947         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2948         call.
2949         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2950         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2951         calls.
2952         (check_for_argument): Skip spaces after argument.
2953
2954 2019-06-13  Pedro Alves  <palves@redhat.com>
2955
2956         * thread.c (thread_apply_command): Adjust TID parsing.
2957         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2958         detected before end of string.
2959         (tid_is_in_list): Error out if LIST is invalid.
2960
2961 2019-06-13  Pedro Alves  <palves@redhat.com>
2962
2963         * completer.c (complete_line_internal_1): Rewind completion word
2964         point.
2965         (completion_tracker::advance_custom_word_point_by): Change
2966         parameter type to int.
2967         * completer.h (completion_tracker::advance_custom_word_point_by):
2968         Likewise.
2969
2970 2019-06-13  Pedro Alves  <palves@redhat.com>
2971
2972         * completer.c (advance_to_completion_word): Handle delimiters.
2973
2974 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2975
2976         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2977
2978 2019-06-11  Tom Tromey  <tom@tromey.com>
2979
2980         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2981         (xmalloc_failed): Move to alloc.c.
2982         * alloc.c: New file.
2983         * Makefile.in (COMMON_SFILES): Add alloc.c.
2984
2985 2019-06-11  Tom Tromey  <tom@tromey.com>
2986
2987         * nat/linux-waitpid.c: Don't include server.h.
2988         (linux_debug): Remove.
2989         (my_waitpid): Update.
2990
2991 2019-06-11  Tom Tromey  <tromey@adacore.com>
2992
2993         * infcall.c (_initialize_infcall): Remove trailing newline from
2994         help.
2995         * user-regs.c (_initialize_user_regs): Remove trailing newline
2996         from help.
2997         * typeprint.c (_initialize_typeprint): Remove trailing newline
2998         from help.
2999         * reverse.c (_initialize_reverse): Remove trailing newlines from
3000         help.
3001         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3002         from help.
3003         * language.c (add_set_language_command): Remove trailing newline
3004         from help.
3005         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3006         help.
3007         * disasm.c (_initialize_disasm): Remove trailing newline from
3008         help.
3009         * top.c (init_main): Remove trailing newline from help.
3010         * interps.c (_initialize_interpreter): Remove trailing newline
3011         from help.
3012         * btrace.c (_initialize_btrace): Remove trailing newlines from
3013         help.
3014         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3015         from help.
3016         * python/python.c (_initialize_python): Remove trailing newline
3017         from help.
3018         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3019         help.
3020         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3021         from help.  Reformat some text.
3022         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3023         from help.
3024         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3025         newline from help.
3026
3027 2019-06-11  Tom Tromey  <tromey@adacore.com>
3028
3029         * darwin-nat.c (darwin_decode_exception_message)
3030         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3031
3032 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3033
3034         * valops.c (value_slice): Check for not allocated or not
3035         associated values.
3036
3037 2019-06-10  Tom de Vries  <tdevries@suse.de>
3038
3039         PR gdb/24618
3040         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3041         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3042         invalid.
3043
3044 2019-06-10  Tom de Vries  <tdevries@suse.de>
3045
3046         PR gdb/24611
3047         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3048         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3049
3050 2019-06-10  Tom de Vries  <tdevries@suse.de>
3051
3052         PR symtab/24545
3053         * symtab.c (struct demangled_name_entry): Add language field.
3054         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3055         static minimal symbol".  Set and use language field.
3056
3057 2019-06-10  Tom Tromey  <tromey@adacore.com>
3058
3059         * ada-lang.c (_initialize_ada_language): Update help text.
3060
3061 2019-06-10  Tom Tromey  <tromey@adacore.com>
3062
3063         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3064         with a newline.
3065         * guile/guile.c (handle_boot_error): Don't end warning with a
3066         newline.
3067         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3068         warning with a newline.
3069         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3070         newline.
3071         (s12z_frame_cache): Likewise.
3072         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3073         a newline.
3074         * solib-svr4.c (disable_probes_interface): Don't end warning with
3075         a newline.
3076         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3077         newline.
3078         * python/python.c (do_finish_initialization): Don't end warning
3079         with a newline.
3080
3081 2019-06-10  Tom Tromey  <tom@tromey.com>
3082
3083         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3084         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3085         gdbpy_enter.
3086
3087 2019-06-10  Tom Tromey  <tromey@adacore.com>
3088
3089         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3090         data.
3091         (elf_new_init): Don't call stabsread_new_init.
3092         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3093         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3094         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3095
3096 2019-06-10  Tom de Vries  <tdevries@suse.de>
3097
3098         PR symtab/16264
3099         PR symtab/24517
3100         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3101
3102 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3103
3104         * source.c (find_and_open_source): Also rewrite relative file
3105         names.
3106
3107 2019-04-26  Amos Bird  <amosbird@gmail.com>
3108
3109         * annotate.c (annotate_thread_exited): Add "thread-exited"
3110         annotation.
3111
3112 2019-06-06  Tom Tromey  <tromey@adacore.com>
3113
3114         * maint.h (class scoped_command_stats): Use
3115         DISABLE_COPY_AND_ASSIGN.
3116         <print_time>: New method.
3117         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3118         print_time.
3119         (scoped_command_stats::print_time): New method.
3120
3121 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3122
3123         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3124         instructions of lengths 6 or 8 bytes.
3125
3126 2019-06-04  Pedro Alves  <palves@redhat.com>
3127
3128         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3129
3130         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3131         * breakpoint.c (condition_completer): Likewise.
3132         * cli/cli-dump.c (scan_expression): Likewise.
3133         * common/filestuff.c (mkdir_recursive): Likewise.
3134         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3135         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3136         (gdb_abspath): Likewise.
3137         * compile/compile-cplus-types.c
3138         (compile_cplus_instance::decl_name): Likewise.
3139         * completer.c (complete_explicit_location):
3140         (signal_completer, reg_or_group_completer_1): Likewise.
3141         * cp-support.c (cp_remove_params_if_any): Likewise.
3142         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3143         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3144         * infcmd.c (strip_bg_char): Likewise.
3145         * linespec.c (copy_token_string): Likewise.
3146         * mi/mi-main.c (output_cores): Likewise.
3147         * psymtab.c (psymtab_search_name):
3148         * symfile.c (test_set_ext_lang_command): Likewise.
3149         * target.c (target_fileio_read_stralloc): Likewise.
3150         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3151         * value.c (complete_internalvar): Likewise.
3152
3153 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3154
3155         Add objfile property to gdb.Type.
3156         * NEWS: Mention Python API addition.
3157         * python/py-type.c (typy_get_objfile): New method.
3158
3159 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3160
3161         * NEWS: Mention the new set|show style [title|highlight].
3162         Mention changes to "show style", "help" and "apropos".
3163
3164 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3165
3166         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3167         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3168         instead of print_help_for_command.
3169         (print_doc_of_command): New function.
3170         (help_list): Add 'apropos -v word' suggestion.
3171         (print_help_for_command): Style the command name using title style.
3172         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3173         (_initialize_cli_cmds): Describe -v in apropos_command help.
3174
3175 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3176
3177         * cli/cli-style.h (cli_style_option): Add name in constructor,
3178         add m_name class member, add constructor with intensity,
3179         add name class function.
3180         (cli_style_option::add_setshow_commands): Remove name argument.
3181         (highlight_style, title_style): New styles.
3182         * cli/cli-style.c (do_show): New function that shows a style
3183         characteristic styling the style name with itself.
3184         (set_style_name): New function.
3185         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3186         Update all callers according to the changes in cli/cli-style.h.
3187         * utils.h (fputs_highlighted): New function.
3188         * utils.c (fputs_highlighted): Likewise.
3189
3190 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3191
3192         * NEWS: Mention new pipe command and new convenience variables.
3193
3194 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3195
3196         * cli/cli-cmds.c (pipe_command): New function.
3197         (_initialize_cli_cmds): Call add_com for pipe_command.
3198         Define | as an alias for pipe.
3199         (exit_status_set_internal_vars): New function.
3200         (shell_escape): Call exit_status_set_internal_vars.
3201         cli/cli-decode.c (find_command_name_length): Recognize | as
3202         a single character command.
3203
3204 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3205
3206         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3207         top.c (execute_command_to_ui_file): New function, mostly a copy
3208         of execute_command_to_string.
3209         (execute_command_to_string): Implement by calling
3210         execute_command_to_ui_file.
3211
3212 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3213
3214         * top.h (saved_command_line): Remove declaration.
3215         * top.c (previous_saved_command_line, previous_repeat_arguments):
3216         New variables.
3217         (saved_command_line): Make static, define together with other
3218         'repeat variables'.
3219         (dont_repeat): Clear repeat_arguments.
3220         (repeat_previous, get_saved_command_line, save_command_line):
3221         New functions.
3222         (gdb_init): Initialize saved_command_line
3223         and previous_saved_command_line.
3224         * main.c (captured_main_1): Remove saved_command_line initialization.
3225         * event-top.c (handle_line_of_input): Update to use
3226         the new 'repeat' related functions instead of direct access to
3227         saved_command_line.
3228         * command.h (repeat_previous, get_saved_command_line,
3229         save_command_line): New declarations.
3230         (dont_repeat): Add comment.
3231
3232 2019-05-30  Tom Tromey  <tromey@adacore.com>
3233
3234         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3235         Fix comment.
3236         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3237
3238 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3239
3240         PR cli/24587
3241         * completer.c (complete): Initialize variable word.
3242
3243 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3244
3245         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3246         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3247         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3248         'body' is NULL to the outter 'if', protecting the '!is_define'
3249         situation as well.
3250
3251 2019-05-29  Tom Tromey  <tromey@adacore.com>
3252
3253         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3254         (dwarf_unknown): New function.
3255         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3256         (dwarf_type_encoding_name): Use dwarf_unknown.
3257
3258 2019-05-29  Tom Tromey  <tromey@adacore.com>
3259
3260         PR c++/20020:
3261         * cp-valprint.c (cp_print_value_fields): Call
3262         cp_print_static_field inside "try".
3263
3264 2019-05-29  Tom Tromey  <tromey@adacore.com>
3265
3266         * inflow.c (struct terminal_info): Add default operator=.
3267         * configure: Rebuild.
3268         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3269         -Wdeprecated-copy-dtor, -Wredundant-move.
3270
3271 2019-05-29  Tom Tromey  <tromey@adacore.com>
3272
3273         * NEWS: Add entry.
3274         * infcmd.c (print_return_value_1): Handle finish_print
3275         option.
3276         (show_print_finish): New function.
3277         (_initialize_infcmd): Add "set/show print finish" commands.
3278         * valprint.c (user_print_options): Initialize new member.
3279         * valprint.h (struct value_print_options) <finish_print>: New
3280         member.
3281
3282 2019-05-28  Tom Tromey  <tromey@adacore.com>
3283
3284         * ada-lang.c (ada_remove_Xbn_suffix)
3285         (find_old_style_renaming_symbol)
3286         (parse_old_style_renaming): Remove.
3287         (ada_find_renaming_symbol): Don't call
3288         find_old_style_renaming_symbol.
3289         (ada_is_renaming_symbol): Rename from
3290         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3291         bool.  Now static.
3292         (ada_read_var_value): Update and simplify.
3293         * ada-exp.y (write_var_or_type): Remove old code.
3294
3295 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3296
3297         * event-top.c: Remove include comment.
3298         * inflow.c (class scoped_ignore_sigttou): Move from here...
3299         * inflow.h (class scoped_ignore_sigttou): ...to here.
3300         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3301         * top.c:  Remove include comment.
3302
3303 2019-05-27  Tom Tromey  <tom@tromey.com>
3304
3305         * NEWS: Fix typo.
3306
3307 2019-05-22  Tom Tromey  <tromey@adacore.com>
3308
3309         * target.c (target_follow_exec): Constify parameter.
3310         * target-delegates.c: Rebuild.
3311         * remote.c (remote_target::follow_exec): Constify parameter.
3312         * infrun.c (follow_exec): Constify parameter.
3313         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3314         (target_follow_exec): Likewise.
3315
3316 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3317
3318         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3319         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3320
3321 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3322
3323         * NEWS: Add debugredirect and testsuite sections.
3324
3325 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3326
3327         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3328         target descriptions using exclusively floating point register name
3329         aliases.
3330
3331 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3332
3333         PR gdb/18644:
3334         * f-lang.c (build_fortran_types): Handle the case where
3335         gdbarch_floatformat_for_type returns a nullptr.
3336
3337 2019-05-21  Tom de Vries  <tdevries@suse.de>
3338
3339         PR cli/24587
3340         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3341
3342 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3343
3344         PR gdb/18644:
3345         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3346         16-byte floats.
3347         * i386-tdep.c (i386_floatformat_for_type): Use
3348         floatformats_ia64_quad for the 16-byte floating point component
3349         within a fortran 32-byte complex number.
3350
3351 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3352
3353         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3354         delete default constructor.
3355         (find_partial_die): Update to return const struct.
3356         (partial_die_parent_scope): Move variable declaration into scope
3357         of its use and change its type to auto.
3358         (guess_partial_die_structure_name): Likewise.
3359         (partial_die_info::fixup): Likewise.
3360
3361 2019-05-17  Tom Tromey  <tromey@adacore.com>
3362
3363         * source.c (find_and_open_source): Remove cast.
3364
3365 2019-05-17  Tom Tromey  <tromey@adacore.com>
3366
3367         * annotate.c (annotate_source): Make "filename" const.
3368         * annotate.h (annotate_source): Use const.
3369
3370 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3371
3372         * disasm.c (set_disassembler_options): Send errors to stderr.
3373
3374 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3375
3376         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3377         (cli_interp_base::set_logging): Check debug_redirect.
3378         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3379         * cli/cli-logging.c (debug_redirect): Add static variable.
3380         (pop_output_files): Add default param.
3381         (handle_redirections): Print debug setting.
3382         (show_logging_command): Likewise.
3383         (_initialize_cli_logging): Add debugredirect command.
3384         * interps.c (current_interp_set_logging): Add debug_redirect
3385         parameter.
3386         * interps.h (set_logging): Add debug_redirect parameter.
3387         (current_interp_set_logging): Likewise.
3388         * mi/mi-common.h: Likewise.
3389         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3390
3391 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3392             Tom Tromey  <tromey@adacore.com>
3393
3394         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3395         directly.
3396         * cli/cli-interp.h (make_logging_output): Remove declaration.
3397         * cli/cli-logging.c (make_logging_output): Remove function.
3398         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3399         directly.
3400         * ui-file.c (tee_file::tee_file): Remove bools.
3401         (tee_file::~tee_file): Remove deletes.
3402         * ui-file.h (tee_file): Remove bools.
3403
3404 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3405
3406         * mi/mi-cmds.h (mi_cmd_complete): New function.
3407         * mi/mi-main.c (mi_cmd_complete): Likewise.
3408         * mi/mi-cmds.c: Define new MI command -complete.
3409         * NEWS: Mention new -complete command.
3410
3411 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3412
3413         * completer.h (complete): New function.
3414         * completer.c (complete): Likewise.
3415         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3416         function defined in completer.h.
3417
3418 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3419
3420         * MAINTAINERS (Write After Approval): Add myself.
3421
3422 2019-05-17  Tom de Vries  <tdevries@suse.de>
3423
3424         PR gdb/24094
3425         * dwarf2read.c (struct cu_partial_die_info): New struct.
3426         (find_partial_die): Return cu_partial_die_info.
3427         (partial_die_parent_scope, guess_partial_die_structure_name)
3428         (partial_die_info::fixup): Handle new return type of find_partial_die.
3429
3430 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3431
3432         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3433         "std::string", simplifying the algorithm.
3434
3435 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3436
3437         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3438         (stap_static_probe_ops::get_probes): Likewise.
3439
3440 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3441
3442         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3443         '-')" and "else if".
3444         (stap_parse_single_operand): Join checks for
3445         "gdbarch_stap_parse_special_token_p" and
3446         "gdbarch_stap_parse_special_token" in the same "if" statement.
3447         Invert check when verifying for operation on register
3448         displacement.
3449
3450 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3451
3452         * stap-probe.c (stap_get_opcode): Update comment.
3453         (stap_get_expected_argument_type): Likewise.
3454         (handle_stap_probe): Likewise.
3455
3456 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3457
3458         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3459         return type to 'bool'.  Adjust comment.  Use 'bool' when
3460         appropriate.
3461         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3462         * stap-probe.c (stap_parse_argument_1): Likewise.
3463         (stap_is_operator): Likewise.
3464         (stap_is_generic_prefix): Likewise.
3465         (stap_is_register_prefix): Likewise.
3466         (stap_is_register_indirection_prefix): Likewise.
3467         (stap_is_integer_prefix): Likewise.
3468         (stap_generic_check_suffix): Likewise.
3469         (stap_check_integer_suffix): Likewise.
3470         (stap_check_register_suffix): Likewise.
3471         (stap_check_register_indirection_suffix): Likewise.
3472         (stap_parse_register_operand): Likewise.
3473         (stap_parse_single_operand): Likewise.
3474         (stap_parse_argument_1): Likewise.
3475         (stap_probe::get_argument_count): Likewise.
3476         (stap_is_operator): Likewise.
3477
3478 2019-05-16  Tom Tromey  <tromey@adacore.com>
3479
3480         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3481         keyword to foreach.
3482
3483 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3484
3485         * linux-thread-db.c (try_thread_db_load_1): Change return type
3486         to bool.
3487         (try_thread_db_load): Likewise.
3488         (try_thread_db_load_from_pdir_1): Likewise.
3489         (try_thread_db_load_from_pdir): Likewise.
3490         (try_thread_db_load_from_sdir): Likewise.
3491         (try_thread_db_load_from_dir): Likewise.
3492         (thread_db_load_search): Likewise.
3493         (has_libpthread): Likewise.
3494         (thread_db_load): Likewise.
3495
3496 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3497
3498         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3499         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3500         NULL, and complain/return if that's the case.
3501
3502 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3503
3504         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3505         (advance, posn, abstract_read_memory): New functions.
3506         [struct mem_read_abstraction]: New struct.
3507         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3508
3509 2019-05-14  Tom Tromey  <tromey@adacore.com>
3510
3511         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3512         value is not lval_memory.
3513
3514 2019-05-14  Tom Tromey  <tromey@adacore.com>
3515
3516         * solib.c (info_sharedlibrary_command): Style the file name.
3517
3518 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3519
3520         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3521         (aarch64_vnv_type): Likewise.
3522         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3523         * common/tdesc.c: Likewise.
3524         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3525         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3526         * features/aarch64-fpu.xml: Add ieee half view.
3527         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3528         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3529         * gdbtypes.h (struct builtin_type): Likewise.
3530         (struct objfile_type): Likewise.
3531
3532 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3533
3534         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3535         typo.
3536         * location.h (string_to_event_location): Likewise.
3537
3538 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3539
3540         GDB 8.3 released.
3541
3542 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3543
3544         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3545         New variable declaration.
3546         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3547         New variable.
3548         (print_one_breakpoint): Use ui_out::test_flags and new global
3549         variable to compute use_fixed_output.
3550         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3551         Remove.
3552         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3553         (mi_multi_location_breakpoint_output_fixed): Remove.
3554         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3555         new variable.
3556         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3557         fix_multi_location_breakpoint_output flag if version >= 3.
3558         * ui-out.h (enum ui_out_flag)
3559         <fix_multi_location_breakpoint_output>: New enumerator.
3560
3561 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3562
3563         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3564
3565 2019-05-10  Tom Tromey  <tromey@adacore.com>
3566
3567         * ada-lang.c (catch_ada_completer): New function.
3568         (_initialize_ada_language): Use it.
3569
3570 2019-05-10  Tom Tromey  <tromey@adacore.com>
3571
3572         * thread.c (print_thread_info): Make "requested_threads" const.
3573         * gdbthread.h (print_thread_info): Make "requested_threads"
3574         const.
3575         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3576         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3577
3578 2019-05-08  Tom Tromey  <tom@tromey.com>
3579
3580         * gdbtypes.c (objfile_type_data): Change type.
3581         (objfile_type, _initialize_gdbtypes): Update.
3582
3583 2019-05-08  Tom Tromey  <tom@tromey.com>
3584
3585         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3586         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3587         (_initialize_dwarf2_frame): Update.
3588
3589 2019-05-08  Tom Tromey  <tom@tromey.com>
3590
3591         * objc-lang.c (objc_objfile_data): Change type.
3592         (find_methods): Update.
3593         (_initialize_objc_lang): Remove.
3594
3595 2019-05-08  Tom Tromey  <tom@tromey.com>
3596
3597         * stabsread.c (rs6000_builtin_type_data): Change type.
3598         (rs6000_builtin_type, _initialize_stabsread): Update.
3599
3600 2019-05-08  Tom Tromey  <tom@tromey.com>
3601
3602         * mips-tdep.c (mips_pdr_data): Remove.
3603         (_initialize_mips_tdep): Update.
3604
3605 2019-05-08  Tom Tromey  <tom@tromey.com>
3606
3607         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3608         (hppa_init_objfile_priv_data, read_unwind_info)
3609         (find_unwind_entry, _initialize_hppa_tdep): Update.
3610
3611 2019-05-08  Tom Tromey  <tom@tromey.com>
3612
3613         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3614         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3615         on obstack.
3616         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3617
3618 2019-05-08  Tom Tromey  <tom@tromey.com>
3619
3620         * mdebugread.c (basic_type_data): Change type.
3621         (basic_type, _initialize_mdebugread): Update.
3622
3623 2019-05-08  Tom Tromey  <tom@tromey.com>
3624
3625         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3626
3627 2019-05-08  Tom Tromey  <tom@tromey.com>
3628
3629         * nto-tdep.c (nto_inferior_data_reg): Change type.
3630         (nto_inferior_data): Update.
3631         (nto_inferior_data_cleanup, nto_new_inferior_data)
3632         (_initialize_nto_tdep): Remove.
3633         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3634
3635 2019-05-08  Tom Tromey  <tom@tromey.com>
3636
3637         * ada-lang.c (struct ada_inferior_data): Add initializers.
3638         (ada_inferior_data): Change type.
3639         (ada_inferior_data_cleanup): Remove.
3640         (get_ada_inferior_data, ada_inferior_exit)
3641         (struct ada_pspace_data): Add initializers, destructor.
3642         (ada_pspace_data_handle): Change type.
3643         (get_ada_pspace_data): Update.
3644         (ada_pspace_data_cleanup): Remove.
3645
3646 2019-05-08  Tom Tromey  <tom@tromey.com>
3647
3648         * coffread.c (struct coff_symfile_info): Add initializers.
3649         (coff_objfile_data_key): Move lower.  Change type.
3650         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3651         Update.
3652         (coff_free_info): Remove.
3653
3654 2019-05-08  Tom Tromey  <tom@tromey.com>
3655
3656         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3657         (fbsd_pspace_data_handle): Move lower.  Change type.
3658         (get_fbsd_pspace_data): Update.
3659         (fbsd_pspace_data_cleanup): Remove.
3660         (_initialize_fbsd_tdep): Update.
3661
3662 2019-05-08  Tom Tromey  <tom@tromey.com>
3663
3664         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3665         (get_ada_tasks_pspace_data): Update.
3666         (ada_tasks_pspace_data_cleanup): Remove.
3667         (_initialize_tasks): Update.
3668         (ada_tasks_inferior_data_handle): Change type.
3669         (get_ada_tasks_inferior_data): Update.
3670         (ada_tasks_inferior_data_cleanup): Remove.
3671         (struct ada_tasks_pspace_data): Add initializers.
3672
3673 2019-05-08  Tom Tromey  <tom@tromey.com>
3674
3675         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3676         * symfile-debug.c (debug_sym_get_probes): Change type.
3677         * stap-probe.c (handle_stap_probe):
3678         (stap_static_probe_ops::get_probes): Change type.
3679         * probe.h (class static_probe_ops) <get_probes>: Change type.
3680         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3681         (parse_probes_in_pspace): Update.
3682         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3683         Update.
3684         (any_static_probe_ops::get_probes): Change type.
3685         * elfread.c (elfread_data): New typedef.
3686         (probe_key): Change type.
3687         (elf_get_probes): Likewise.  Update.
3688         (probe_key_free): Remove.
3689         (_initialize_elfread): Update.
3690         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3691         Change type.
3692         (dtrace_process_dof_probe, dtrace_process_dof)
3693         (dtrace_static_probe_ops::get_probe): Change type.
3694
3695 2019-05-08  Tom Tromey  <tom@tromey.com>
3696
3697         * xcoffread.c (struct xcoff_symfile_info): Rename from
3698         coff_symfile_info.  Add initializers.
3699         (xcoff_objfile_data_key): Move lower.  Change type.
3700         (XCOFF_DATA): Rewrite.
3701         (xcoff_free_info): Remove.
3702         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3703         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3704         (xcoff_initial_scan): Update.
3705
3706 2019-05-08  Tom Tromey  <tom@tromey.com>
3707
3708         * solib-svr4.c (struct svr4_info): Add initializers and
3709         destructor.
3710         <probes_table>: Now an htab_up.
3711         (solib_svr4_pspace_data): Change type.
3712         (free_probes_table): Simplify.
3713         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3714         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3715         (probes_table_remove_objfile_probes, register_solib_event_probe)
3716         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3717         (_initialize_svr4_solib): Update.
3718
3719 2019-05-08  Tom Tromey  <tom@tromey.com>
3720
3721         * remote.c (remote_pspace_data): Change type.
3722         (remote_pspace_data_cleanup): Remove.
3723         (get_remote_exec_file, set_pspace_remote_exec_file)
3724         (_initialize_remote): Update.
3725
3726 2019-05-08  Tom Tromey  <tom@tromey.com>
3727
3728         * breakpoint.c (breakpoint_objfile_key): Change type.
3729         (get_breakpoint_objfile_data): Update.
3730         (free_breakpoint_objfile_data): Remove.
3731         (_initialize_breakpoint): Update.
3732
3733 2019-05-08  Tom Tromey  <tom@tromey.com>
3734
3735         * linux-tdep.c (struct linux_info): Add initializers.
3736         (linux_inferior_data): Move.  Change type.
3737         (invalidate_linux_cache_inf): Update.
3738         (linux_inferior_data_cleanup): Remove.
3739         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3740
3741 2019-05-08  Tom Tromey  <tom@tromey.com>
3742
3743         * auxv.c (auxv_inferior_data): Move.  Change type.
3744         (auxv_inferior_data_cleanup): Remove.
3745         (invalidate_auxv_cache_inf): Rewrite.
3746         (get_auxv_inferior_data, _initialize_auxv): Update.
3747
3748 2019-05-08  Tom Tromey  <tom@tromey.com>
3749
3750         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3751         (symfile_debug_objfile_data_key): Change type.
3752         (symfile_debug_installed, debug_qf_has_symbols)
3753         (debug_qf_find_last_source_symtab)
3754         (debug_qf_forget_cached_source_info)
3755         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3756         (debug_qf_print_stats, debug_qf_dump)
3757         (debug_qf_expand_symtabs_for_function)
3758         (debug_qf_expand_all_symtabs)
3759         (debug_qf_expand_symtabs_with_fullname)
3760         (debug_qf_map_matching_symbols)
3761         (debug_qf_expand_symtabs_matching)
3762         (debug_qf_find_pc_sect_compunit_symtab)
3763         (debug_qf_map_symbol_filenames)
3764         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3765         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3766         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3767         (debug_sym_read_linetable, debug_sym_relocate): Update.
3768         (symfile_debug_free_objfile): Remove.
3769         (install_symfile_debug_logging, _initialize_symfile_debug):
3770         Update.
3771
3772 2019-05-08  Tom Tromey  <tom@tromey.com>
3773
3774         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3775         allocate_on_obstack.
3776         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3777         (get_dwarf2_per_objfile): Update.
3778         (set_dwarf2_per_objfile): Remove.
3779         (dwarf2_has_info, dwarf2_get_section_info): Update.
3780         (dwarf2_free_objfile): Remove.
3781         (_initialize_dwarf2_read): Update.
3782
3783 2019-05-08  Tom Tromey  <tom@tromey.com>
3784
3785         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3786         initializers.
3787         <unsupported_script_warning_printed,
3788         script_not_found_warning_printed>: Now bool.
3789         (auto_load_pspace_data): Change type.
3790         (~auto_load_pspace_info): Rename from
3791         auto_load_pspace_data_cleanup.
3792         (get_auto_load_pspace_data, init_loaded_scripts_info)
3793         (clear_section_scripts, maybe_print_unsupported_script_warning)
3794         (maybe_print_script_not_found_warning, _initialize_auto_load):
3795         Update.
3796
3797 2019-05-08  Tom Tromey  <tom@tromey.com>
3798
3799         * objfiles.c (objfile_pspace_info): Add destructor and
3800         initializers.
3801         (objfiles_pspace_data): Change type.
3802         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3803         (get_objfile_pspace_data): Update.
3804         (objfiles_bfd_data): Change type.
3805         (get_objfile_bfd_data): Update.
3806         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3807
3808 2019-05-08  Tom Tromey  <tom@tromey.com>
3809
3810         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3811         Change type.
3812         (get_catch_syscall_inferior_data): Update.
3813         (catch_syscall_inferior_data_cleanup): Remove.
3814         (_initialize_break_catch_syscall): Update.
3815
3816 2019-05-08  Tom Tromey  <tom@tromey.com>
3817
3818         * inflow.c (struct terminal_info): Add destructor and
3819         initializers.
3820         (inflow_inferior_data): Change type.
3821         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3822         (get_inflow_inferior_data, inflow_inferior_exit)
3823         (swap_terminal_info, _initialize_inflow): Update.
3824
3825 2019-05-08  Tom Tromey  <tom@tromey.com>
3826
3827         * target-dcache.c (target_dcache_cleanup): Remove.
3828         (target_dcache_aspace_key): Change type.
3829         (target_dcache_init_p, target_dcache_invalidate)
3830         (target_dcache_get, target_dcache_get_or_init)
3831         (_initialize_target_dcache): Update.
3832         * dcache.h (struct dcache_deleter): New.
3833
3834 2019-05-08  Tom Tromey  <tom@tromey.com>
3835
3836         * symtab.c (struct symbol_cache): Add destructor and
3837         initializers.
3838         (symbol_cache_key): Move.  Change type.
3839         (make_symbol_cache, free_symbol_cache): Remove.
3840         (get_symbol_cache): Update.
3841         (symbol_cache_cleanup): Remove.
3842         (ALL_PSPACES, symbol_cache_flush)
3843         (maintenance_print_symbol_cache)
3844         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3845         Update.
3846
3847 2019-05-08  Tom Tromey  <tom@tromey.com>
3848
3849         * symtab.c (struct main_info): Add destructor and initializers.
3850         (main_progspace_key): Move.  Change type.
3851         (get_main_info): Update.
3852         (main_info_cleanup): Remove.
3853         (_initialize_symtab): Update.
3854
3855 2019-05-08  Tom Tromey  <tom@tromey.com>
3856
3857         * registry.h (DECLARE_REGISTRY): Define the _key class.
3858
3859 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3860
3861         * NEWS: Merge two 'New commands' sections.
3862
3863 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3864
3865         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3866         parameter and use Ada language definition instead.
3867         (ada_val_print_ptr): Remove unused language parameter.
3868         (ada_val_print_num): Remove language parameter and use Ada language
3869         definition instead.
3870         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3871         parameter.
3872         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3873         parameter and use Ada language definition instead.
3874         (ada_val_print_1): Update all ada_val_print_xxx calls.
3875         Remove language parameter.
3876         (ada_val_print): Update ada_val_print_1 call.
3877
3878 2019-05-08  Tom Tromey  <tromey@adacore.com>
3879
3880         * remote.c (remote_hw_watchpoint_limit)
3881         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3882         Now static.
3883
3884 2019-05-08  Tom Tromey  <tromey@adacore.com>
3885
3886         * maint.c (_initialize_maint_cmds): Move initialization code to
3887         remote.c.
3888         (watchdog, show_watchdog): Move to remote.c.
3889         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3890         "watchdog" static.
3891         (_initialize_remote): Move initialization code from maint.c.
3892         * defs.h (watchdog): Don't declare.
3893
3894 2019-05-08  Tom Tromey  <tromey@adacore.com>
3895
3896         * tui/tui-interp.c: Include main.h.
3897         * interps.c: Include main.h.
3898         * main.h (interpreter_p): Declare.
3899         * defs.h (interpreter_p): Don't declare.
3900
3901 2019-05-08  Tom Tromey  <tromey@adacore.com>
3902
3903         * dwarf2loc.c: Include dwarf2read.h.
3904         * defs.h (read_unsigned_leb128): Don't declare.
3905         * dwarf2read.h (read_unsigned_leb128): Declare.
3906
3907 2019-05-08  Tom Tromey  <tromey@adacore.com>
3908
3909         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3910         method.
3911
3912 2019-05-08  Tom Tromey  <tromey@adacore.com>
3913
3914         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3915         when no wrap column is set.
3916
3917 2019-05-08  Tom Tromey  <tromey@adacore.com>
3918
3919         * c-lang.c (c_get_string): Handle non-C-style arrays.
3920
3921 2019-05-08  Tom Tromey  <tromey@adacore.com>
3922
3923         * typeprint.c (print_offset_data::update): Print the bit offset,
3924         not the number of bits remaining.
3925
3926 2019-05-08  Tom Tromey  <tromey@adacore.com>
3927
3928         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3929         padding at end of comment.
3930
3931 2019-05-08  Tom Tromey  <tromey@adacore.com>
3932
3933         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3934         Compare main types.
3935
3936 2019-05-06  Tom Tromey  <tom@tromey.com>
3937
3938         * common/scoped_mmap.c: Include common-defs.h.
3939         * common/scoped_mmap.h: Don't include config.h.
3940
3941 2019-05-04  Tom Tromey  <tom@tromey.com>
3942
3943         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3944         (struct aarch64_call_info): Add initializers.
3945         <si>: Now a std::vector.
3946         (pass_on_stack, aarch64_push_dummy_call): Update.
3947
3948 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3949             Tom Tromey  <tom@tromey.com>
3950
3951         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3952         (ppc_threads): Now a std::vector.  Now static.
3953         (hwdebug_find_thread_points_by_tid)
3954         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3955         Update.
3956
3957 2019-05-04  Tom Tromey  <tom@tromey.com>
3958
3959         * arc-tdep.c (arc_tdesc_init): Return bool.
3960
3961 2019-05-04  Tom Tromey  <tom@tromey.com>
3962
3963         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3964         Use gdb_assert_not_reached.
3965
3966 2019-05-04  Tom Tromey  <tom@tromey.com>
3967
3968         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3969         "false".
3970
3971 2019-05-04  Tom Tromey  <tom@tromey.com>
3972
3973         * arc-tdep.c (arc_tdesc_init): Use bool.
3974
3975 2019-05-04  Tom Tromey  <tom@tromey.com>
3976
3977         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3978
3979 2019-05-04  Tom Tromey  <tom@tromey.com>
3980
3981         * cli/cli-cmds.c (valid_command_p): Return bool.
3982
3983 2019-05-04  Tom Tromey  <tom@tromey.com>
3984
3985         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3986         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3987
3988 2019-05-04  Raul Tambre  <raul@tambre.ee>
3989
3990         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3991         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3992         operator for comparison.
3993
3994 2019-05-04  Tom Tromey  <tom@tromey.com>
3995
3996         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3997         (lookup_partial_symbol, print_partial_symbols)
3998         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3999         (psymbol_compare): Update.
4000         (add_psymbol_to_bcache): Clear the entire psymbol.
4001         (maintenance_check_psymtabs): Update.
4002         * psympriv.h (struct partial_symbol): Don't derive from
4003         general_symbol_info.
4004         <obj_section, unrelocated_address, address,
4005         set_unrelocated_address>: Update.
4006         <ginfo>: New member.
4007         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4008         (debug_names::write_psymbols): Update.
4009
4010 2019-05-04  Tom de Vries  <tdevries@suse.de>
4011
4012         * contrib/cc-with-tweaks.sh: Support -n arg.
4013
4014 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4015
4016         * corelow.c (core_target::detach): Ensure frame cache and
4017         register caches are cleared.
4018         inferior.c (exit_inferior_1): Likewise.
4019
4020 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4021             Tom Tromey  <tom@tromey.com>
4022
4023         * dictionary.c (collate_pending_symbols_by_language): Remove
4024         "struct" from foreach.
4025         * symtab.c (lookup_global_symbol_from_objfile)
4026         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4027         foreach.
4028         * ser-tcp.c (net_open): Remove "struct" from foreach.
4029         * objfiles.c (objfile_relocate, objfile_rebase)
4030         (objfile_has_symbols): Remove "struct" from foreach.
4031         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4032         from foreach.
4033         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4034         foreach.
4035         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4036         "struct" from foreach.
4037         * ada-lang.c (create_excep_cond_exprs)
4038         (ada_exception_catchpoint_cond_string): Remove "struct" from
4039         foreach.
4040
4041 2019-05-03  Tom Tromey  <tromey@adacore.com>
4042
4043         * ada-exp.y (convert_char_literal): Check suffix of each
4044         enumerator.
4045
4046 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4047
4048         PR ada/21406:
4049         * ada-exp.y (yywrap): Don't define.
4050         * ada-lex.l (%option): Add noyywrap
4051         (yywrap): Remove.
4052
4053 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4054
4055         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4056         _WIN32_WINNT to the XP level, unless already defined to a higher
4057         level.
4058
4059         * unittests/parse-connection-spec-selftests.c:
4060         * ser-tcp.c:
4061         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4062         override.
4063
4064         * symfile.c (find_separate_debug_file): Remove colon from the
4065         drive spec of DOS/Windows file names of the target, so that the
4066         file name produced from DEBUGDIR and the target's directory will
4067         be valid on DOS/Windows systems.
4068
4069 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4070
4071         * rust-lang.c (val_print_struct): Handle printing structures
4072         containing strings.
4073
4074 2019-05-02  Tom Tromey  <tromey@adacore.com>
4075
4076         * valarith.c (_initialize_valarith): Remove.
4077
4078 2019-05-01  Tom Tromey  <tromey@adacore.com>
4079
4080         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4081         bitfields.
4082
4083 2019-05-01  Tom Tromey  <tromey@adacore.com>
4084
4085         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4086         for big-endian copies.
4087
4088 2019-04-30  Ali Tamur  <tamur@google.com>
4089         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4090         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4091         (read_3_bytes): New function.
4092
4093 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4094
4095         * windows-nat.c (main_thread_id): Delete.
4096         (handle_output_debug_string): Replace main_thread_id by
4097         current_event.dwThreadId.
4098         (fake_create_process): Likewise.
4099         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4100         Do not set main_thread_id.
4101         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4102         current_event.dwThreadId.
4103         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4104
4105 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4106
4107         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4108         Use current_event.dwThreadId instead of main_thread_id.
4109
4110 2019-04-30  Tom Tromey  <tromey@adacore.com>
4111
4112         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4113         (create_excep_cond_exprs): Iterate over program spaces.
4114         (ada_exception_catchpoint_cond_string): Examine all minimal
4115         symbols for exception types.
4116
4117 2019-04-30  Tom Tromey  <tromey@adacore.com>
4118
4119         PR c++/24470:
4120         * dwarf2read.c (process_structure_scope): Handle case where type
4121         has template parameters but no symbol was created.
4122
4123 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4124             Chris January  <chris.january@arm.com>
4125
4126         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4127         qualifier.
4128         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4129
4130 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4131
4132         * f-typeprint.c (f_print_type): Update rules for printing
4133         whitespace.
4134         (f_type_print_varspec_suffix): Likewise.
4135
4136 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4137             Chris January  <chris.january@arm.com>
4138
4139         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4140         function arguments.
4141
4142 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4143
4144         * f-lang.c (build_fortran_types): Change name of void type to
4145         lower case.
4146         * f-typeprint.c (f_type_print_base): Print the name of the void
4147         type, rather than a fixed string.
4148         * f-valprint.c (f_decorations): Use lower case void string.
4149
4150 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4151             Chris January  <chris.january@arm.com>
4152
4153         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4154         types for Fortran.
4155
4156 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4157             Chris January  <chris.january@arm.com>
4158             David Lecomber  <david.lecomber@arm.com>
4159
4160         * f-exp.y (BINOP_INTRINSIC): New token.
4161         (exp): New parser rule handling BINOP_INTRINSIC.
4162         (f77_keywords): Add new builtin procedures.
4163         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4164         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4165         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4166         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4167         (print_unop_subexp_f): New function.
4168         (print_binop_subexp_f): New function.
4169         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4170         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4171         (dump_subexp_body_f): Likewise.
4172         (operator_check_f): Likewise.
4173         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4174         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4175
4176 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4177
4178         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4179         UNOP_KIND.
4180         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4181         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4182         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4183         (operator_length_f): New fuction.
4184         (print_subexp_f): New function.
4185         (op_name_f): New function.
4186         (dump_subexp_body_f): New function.
4187         (operator_check_f): New function.
4188         (exp_descriptor_f): Replace standard expression handling functions
4189         with new functions.
4190         * gdb/fortran-operator.def: New file.
4191         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4192         * gdb/std-operator.def: Remove UNOP_KIND.
4193
4194 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4195
4196         * std-operator.def: Remove unbalanced, stray double quote
4197         character.
4198
4199 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4200             Chris January  <chris.january@arm.com>
4201             Daniel Everett  <daniel.everett@arm.com>
4202             Nick Forrington  <nick.forrington@arm.com>
4203             Richard Bunt  <richard.bunt@arm.com>
4204
4205         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4206         of depth when printing anonymous structs or unions.
4207         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4208         Don't print either the top-level value, or the children if the
4209         max-depth is exceeded.
4210         (ppscm_print_children): When printing the key of a map, allow one
4211         extra level of depth.
4212         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4213         print either the top-level value, or the children if the max-depth
4214         is exceeded.
4215         (print_children): When printing the key of a map, allow one extra
4216         level of depth.
4217         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4218         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4219         (user_print_options): Initialise max_depth field.
4220         (val_print_scalar_or_string_type_p): New function.
4221         (val_print): Check to see if the max depth has been reached.
4222         (val_print_check_max_depth): Define new function.
4223         (show_print_max_depth): New function.
4224         (_initialize_valprint): Add 'print max-depth' option.
4225         * valprint.h (struct value_print_options) <max_depth>: New field.
4226         (val_print_check_max_depth): Declare new function.
4227         * NEWS: Document new feature.
4228
4229 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4230
4231         * ada-lang.c (ada_language_defn): Initialise new field.
4232         * c-lang.c (c_is_string_type_p): New function.
4233         (c_language_defn): Initialise new field.
4234         (cplus_language_defn): Initialise new field.
4235         (asm_language_defn): Initialise new field.
4236         (minimal_language_defn): Initialise new field.
4237         * c-lang.h (c_is_string_type_p): Declare new function.
4238         * d-lang.c (d_language_defn): Initialise new field.
4239         * f-lang.c (f_is_string_type_p): New function.
4240         (f_language_defn): Initialise new field.
4241         * go-lang.c (go_is_string_type_p): New function.
4242         (go_language_defn): Initialise new field.
4243         * language.c (default_is_string_type_p): New function.
4244         (unknown_language_defn): Initialise new field.
4245         (auto_language_defn): Initialise new field.
4246         * language.h (struct language_defn) <la_is_string_type_p>: New
4247         member variable.
4248         (default_is_string_type_p): Declare new function.
4249         * m2-lang.c (m2_language_defn): Initialise new field.
4250         * objc-lang.c (objc_language_defn): Initialise new field.
4251         * opencl-lang.c (opencl_language_defn): Initialise new field.
4252         * p-lang.c (pascal_is_string_type_p): New function.
4253         (pascal_language_defn): Initialise new field.
4254         * rust-lang.c (rust_is_string_type_p): New function.
4255         (rust_language_defn): Initialise new field.
4256
4257 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4260         New field.
4261         * ada-lang.c (ada_language_defn): Initialise new field.
4262         * c-lang.c (c_language_defn): Likewise.
4263         (cplus_language_defn): Likewise.
4264         (asm_language_defn): Likewise.
4265         (minimal_language_defn): Likewise.
4266         * d-lang.c (d_language_defn): Likewise.
4267         * f-lang.c (f_language_defn): Likewise.
4268         * go-lang.c (go_language_defn): Likewise.
4269         * language.c (unknown_language_defn): Likewise.
4270         (auto_language_defn): Likewise.
4271         * m2-lang.c (m2_language_defn): Likewise.
4272         * objc-lang.c (objc_language_defn): Likewise.
4273         * opencl-lang.c (opencl_language_defn): Likewise.
4274         * p-lang.c (pascal_language_defn): Likewise.
4275         * rust-lang.c (rust_language_defn): Likewise.
4276
4277 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4278
4279         * ada-lang.c (ada_is_character_type): Change return type to bool.
4280         (ada_is_string_type): Likewise.
4281         * ada-lang.h (ada_is_character_type): Update declaration
4282         (ada_is_string_type): Likewise.
4283
4284 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4285
4286         Support style in 'frame|thread apply'
4287
4288         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4289         * record.c (record_start, record_stop): Update callers of
4290         execute_command_to_string with false.
4291         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4292         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4293         methods.
4294         (class string_file): New constructor with term_out parameter.
4295         Override methods term_out and can_emit_style_escape.  New member
4296         term_out.
4297         (class stdio_file): Override can_emit_style_escape.
4298         (class tee_file): Override term_out and can_emit_style_escape.
4299         * utils.h (can_emit_style_escape): Remove.
4300         * utils.c (can_emit_style_escape): Likewise.
4301         Update all callers of can_emit_style_escape (SOMESTREAM) to
4302         SOMESTREAM->can_emit_style_escape.
4303         * source-cache.c (source_cache::get_source_lines): Likewise.
4304         * stack.c (frame_apply_command_count): Call execute_command_to_string
4305         passing the term_out characteristic of the current gdb_stdout.
4306         * thread.c (thr_try_catch_cmd): Likewise.
4307         * top.c (execute_command_to_string): pass term_out parameter
4308         to construct the string_file for the command output.
4309         * ui-file.c (term_cli_styling): New function (most code moved
4310         from utils.c can_emit_style_escape).
4311         (string_file::string_file, string_file::can_emit_style_escape,
4312         stdio_file::can_emit_style_escape, tee_file::term_out,
4313         tee_file::can_emit_style_escape): New functions.
4314
4315 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4316
4317         * NEWS: Mention the new set|show may-call-functions.
4318         * infcall.c (may_call_functions_p): New variable.
4319         (show_may_call_functions_p): New function.
4320         (call_function_by_hand_dummy): Throws an error if not
4321         may-call-functions.
4322         (_initialize_infcall): Call add_setshow_boolean_cmd for
4323         may-call-functions.
4324
4325 2019-04-25  Keith Seitz  <keiths@redhat.com>
4326
4327         PR c++/24367
4328         * cp-support.c (inspect_type): Don't attempt substitutions
4329         of symbol with the same name.
4330
4331 2019-04-25  Tom Tromey  <tromey@adacore.com>
4332
4333         PR gdb/24475:
4334         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4335         static.
4336
4337 2019-04-25  Tom Tromey  <tromey@adacore.com>
4338
4339         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4340         rvalue reference.
4341         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4342         (gdb_xml_parser::parse): Use std::move.
4343         * python/python-internal.h (gdbpy_convert_exception): Take a const
4344         reference.
4345         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4346         std::move.
4347         * python/py-utils.c (gdbpy_convert_exception): Take a const
4348         reference.
4349         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4350         Use std::move.
4351         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4352         Use std::move.
4353         * mi/mi-main.c (mi_print_exception): Take a const reference.
4354         * main.c (handle_command_errors): Take a const reference.
4355         * linespec.c (parse_linespec): Use std::move.
4356         * infcall.c (run_inferior_call): Use std::move.
4357         (call_function_by_hand_dummy): Use std::move.
4358         * exec.c (try_open_exec_file): Use std::move.
4359         * exceptions.h (exception_print, exception_fprintf)
4360         (exception_print_same): Update.
4361         * exceptions.c (print_exception, exception_print)
4362         (exception_fprintf, exception_print_same): Change parameters to
4363         const reference.
4364         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4365         * common/new-op.c: Use std::move.
4366         * common/common-exceptions.h (struct gdb_exception): Add move
4367         constructor.
4368         (struct gdb_exception_error, struct gdb_exception_quit, struct
4369         gdb_quit_bad_alloc): Change constructor to move constructor.
4370         (throw_exception): Change parameter to rvalue reference.
4371         * common/common-exceptions.c (throw_exception): Take rvalue
4372         reference.
4373         * cli/cli-interp.c (safe_execute_command): Use std::move.
4374         * breakpoint.c (insert_bp_location, location_to_sals): Use
4375         std::move.
4376
4377 2019-04-25  Tom Tromey  <tromey@adacore.com>
4378
4379         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4380         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4381         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4382         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4383         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4384         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4385         guile/scm-value.c: Use unpack.
4386         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4387         gdbscm_gdb_exception.
4388         (gdbscm_throw_gdb_exception): Likewise.
4389         (struct gdbscm_gdb_exception): New.
4390         (unpack): New function.
4391         (gdbscm_wrap): Use unpack.
4392
4393 2019-04-25  Tom Tromey  <tromey@adacore.com>
4394
4395         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4396         (gdb_rl_callback_handler): Use std::move.
4397         * common/common-exceptions.h (struct gdb_exception): Add move
4398         assignment operator.
4399         (throw_exception_sjlj): Change "exception" to const reference.
4400         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4401         (throw_exception_sjlj): Change "exception" to const reference.
4402
4403 2019-04-25  Tom Tromey  <tromey@adacore.com>
4404
4405         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4406         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4407         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4408         Update.
4409         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4410         Update.
4411         * mi/mi-interp.c (mi_interp::exec): Update.
4412         * linespec.c (parse_linespec): Update.
4413         * infcall.c (run_inferior_call): Update.
4414         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4415         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4416         (gdbscm_lookup_global_symbol): Update.
4417         * guile/scm-param.c (gdbscm_parameter_value): Update.
4418         * guile/scm-frame.c (gdbscm_frame_read_register)
4419         (gdbscm_frame_read_var): Update.
4420         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4421         * exec.c (try_open_exec_file): Update.
4422         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4423         (gdb_rl_callback_handler): Update.
4424         * common/common-exceptions.h (exception_none): Don't declare.
4425         * common/common-exceptions.c (exception_none): Don't define.
4426         (struct catcher) <exception>: Update.
4427         * cli/cli-interp.c (safe_execute_command): Update.
4428         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4429
4430 2019-04-25  Ali Tamur  <tamur@google.com>
4431
4432         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4433         (read_attribute_value): Likewise.
4434         (dwarf2_read_addr_index): Update comment.
4435         (read_str_index): Add DW_FORM_strx.
4436         (dwarf2_string_attr): Likewise.
4437         (dwarf2_const_value_attr): Likewise.
4438         (dump_die_shallow): Likewise.
4439         (dwarf2_fetch_constant_bytes): Likewise.
4440         (skip_form_bytes): Likewise.
4441         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4442
4443 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4444
4445         PR corefiles/11608
4446         PR corefiles/18187
4447         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4448         OFFSET.  Verify if current mapping contains an ELF header.
4449         (linux_find_memory_regions_full): Adjust call to
4450         dump_mapping_p.
4451
4452 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4453             Kang Li <kanglictf@gmail.com>
4454
4455         PR gdb/21600
4456
4457         * dwarf2-frame.c (read_initial_length): Be consistent about using
4458         unsigned representation of length.
4459         (decode_frame_entry_1): Likewise.  Check for wraparound of
4460         end pointer as well as buffer overflow.
4461
4462 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4463
4464         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4465         "vq".
4466
4467 2019-04-24  Tom Tromey  <tromey@adacore.com>
4468
4469         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4470
4471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4472
4473         * s12z-tdep.c (s12z_unwind_pc): Delete.
4474         (s12z_unwind_sp): Delete.
4475         (s12z_gdbarch_init): Don't register deleted functions with
4476         gdbarch.
4477
4478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4479
4480         * rl78-tdep.c (rl78_unwind_sp): Delete.
4481         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4482
4483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4484
4485         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4486         (xstormy16_unwind_pc): Delete.
4487         (xstormy16_dummy_id): Delete.
4488         (xstormy16_gdbarch_init): Don't register deleted functions with
4489         gdbarch.
4490
4491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4492
4493         * vax-tdep.c (vax_unwind_pc): Delete.
4494         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4495
4496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4497
4498         * v850-tdep.c (v850_unwind_sp): Delete.
4499         (v850_unwind_pc): Delete.
4500         (v850_dummy_id): Delete.
4501         (v850_gdbarch_init): Don't register deleted functions with
4502         gdbarch.
4503
4504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4505
4506         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4507         (tilegx_unwind_pc): Delete.
4508         (tilegx_unwind_dummy_id): Delete.
4509         (tilegx_gdbarch_init): Don't register deleted functions with
4510         gdbarch.
4511
4512 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4513
4514         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4515         (tic6x_dummy_id): Delete.
4516         (tic6x_gdbarch_init): Don't register deleted functions with
4517         gdbarch.
4518
4519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4520
4521         * sparc-tdep.c (sparc_unwind_pc): Delete.
4522         (sparc32_gdbarch_init): Don't register deleted function with
4523         gdbarch.
4524
4525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4526
4527         * sh-tdep.c (sh_unwind_sp): Delete.
4528         (sh_unwind_pc): Delete.
4529         (sh_dummy_id): Delete.
4530         (sh_gdbarch_init): Don't register deleted functions with
4531         gdbarch.
4532
4533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4534
4535         * score-tdep.c (score_unwind_sp): Delete.
4536         (score_unwind_pc): Delete.
4537         (score_dummy_id): Delete.
4538         (score_gdbarch_init): Don't register deleted functions with
4539         gdbarch.
4540
4541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4542
4543         * rx-tdep.c (rx_unwind_pc): Delete.
4544         (rx_unwind_sp): Delete.
4545         (rx_dummy_id): Delete.
4546         (rx_gdbarch_init): Don't register deleted functions with
4547         gdbarch.  Update comment.
4548
4549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4550
4551         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4552         (rs6000_dummy_id): Delete.
4553         (rs6000_gdbarch_init): Don't register deleted functions with
4554         gdbarch.
4555
4556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4557
4558         * or1k-tdep.c (or1k_dummy_id): Delete.
4559         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4560
4561 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4562
4563         * nios2-tdep.c (nios2_dummy_id): Delete.
4564         (nios2_unwind_sp): Delete.
4565         (nios2_gdbarch_init): Don't register deleted functions with
4566         gdbarch.
4567
4568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4569
4570         * nds32-tdep.c (nds32_dummy_id): Delete.
4571         (nds32_unwind_pc): Delete.
4572         (nds32_unwind_sp): Delete.
4573         (nds32_gdbarch_init): Don't register deleted functions with
4574         gdbarch.
4575
4576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4577
4578         * msp430-tdep.c (msp430_unwind_pc): Delete.
4579         (msp430_unwind_sp): Delete.
4580         (msp430_dummy_id): Delete.
4581         (msp430_gdbarch_init): Don't register deleted functions with
4582         gdbarch.
4583
4584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4585
4586         * moxie-tdep.c (moxie_unwind_sp): Delete.
4587         (moxie_unwind_pc): Delete.
4588         (moxie_dummy_id): Delete.
4589         (moxie_gdbarch_init): Don't register deleted functions with
4590         gdbarch.
4591
4592 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4593
4594         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4595         (mn10300_unwind_pc): Delete.
4596         (mn10300_unwind_sp): Delete.
4597         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4598         mn10300_unwind_sp.
4599         (mn10300_frame_unwind_init): Don't register deleted functions with
4600         gdbarch.
4601
4602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4603
4604         * mep-tdep.c (mep_unwind_pc): Delete.
4605         (mep_unwind_sp): Delete.
4606         (mep_dummy_id): Delete.
4607         (mep_gdbarch_init): Don't register deleted functions with
4608         gdbarch.
4609
4610 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4611
4612         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4613         (m68hc11_unwind_sp): Delete.
4614         (m68hc11_gdbarch_init): Don't register deleted functions with
4615         gdbarch.
4616
4617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4618
4619         * m32r-tdep.c (m32r_unwind_sp): Delete.
4620         (m32r_unwind_pc): Delete.
4621         (m32r_dummy_id): Delete.
4622         (m32r_gdbarch_init): Don't register deleted functions with
4623         gdbarch.
4624
4625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4626
4627         * m32c-tdep.c (m32c_unwind_pc): Delete.
4628         (m32c_unwind_sp): Delete.
4629         (m32c_dummy_id): Delete.
4630         (m32c_gdbarch_init): Don't register deleted functions with
4631         gdbarch.
4632
4633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4634
4635         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4636         (lm32_unwind_pc): Delete.
4637         (lm32_dummy_id): Delete.
4638         (lm32_gdbarch_init): Don't register deleted functions with
4639         gdbarch.
4640
4641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4642
4643         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4644         (iq2000_unwind_pc): Delete.
4645         (iq2000_dummy_id): Delete.
4646         (iq2000_gdbarch_init): Don't register deleted functions with
4647         gdbarch.
4648
4649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4650
4651         * nds32-tdep.c (nds32_type_align): Delete.
4652         (nds32_push_dummy_call): Use type_align instead.
4653
4654 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4655
4656         * arm-tdep.c (arm_type_align): Only handle vector override case.
4657         (arm_push_dummy_call): Use type_align.
4658         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4659
4660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4661
4662         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4663         case.
4664         (pass_on_stack): Use type_align.
4665         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4666         function.
4667
4668 2019-04-23  Tom Tromey  <tromey@adacore.com>
4669
4670         * dwarf2read.c (line_header::file_name_at): Remove unused
4671         overload.
4672
4673 2019-04-23  Tom de Vries  <tdevries@suse.de>
4674
4675         PR gdb/24438
4676         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4677         invocation.
4678
4679
4680 2019-03-27  Ali Tamur  <tamur@google.com>
4681
4682         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4683         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4684         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4685         (dwarf_expr_context::get_addr_index): Likewise
4686         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4687         (symbol_needs_eval_context::get_addr_index): Likewise
4688         (disassemble_dwarf_expression): Add DW_OP_addrx
4689         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4690         (read_cutu_die_from_dwo): Update comment
4691         (skip_one_die): Add DW_FORM_addrx
4692         (read_attribute_value): Likewise
4693         (var_decode_location): Add DW_OP_addrx
4694         (dwarf2_const_value_attr): Add DW_FORM_addrx
4695         (dump_die_shallow): Likewise
4696         (dwarf2_fetch_constant_bytes): Likewise
4697         (decode_locdesc): Add DW_OP_addrx
4698         (skip_form_bytes): Add DW_FORM_addrx
4699
4700 2019-04-22  Ali Tamur  <tamur@google.com>
4701
4702         * MAINTAINERS (Write After Approval): Add self.
4703
4704 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4705
4706         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4707         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4708         (open_symbol_file_object): Likewise.
4709         (svr4_default_sos): Add info parameter.
4710         (svr4_read_so_list): Likewise.
4711         (svr4_current_sos_direct): Adjust functions calls to pass down
4712         info.
4713         (svr4_current_sos_1): Add info parameter.
4714         (svr4_current_sos): Call get_svr4_info, pass info down to
4715         svr4_current_sos_1.
4716         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4717         get_svr4_info.
4718         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4719         get_svr4_info.
4720         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4721         to get_svr4_info.
4722         (probes_table_remove_objfile_probes): Likewise.
4723         (register_solib_event_probe): Add info parameter.
4724         (solist_update_incremental): Pass info parameter down to
4725         svr4_read_so_list.
4726         (disable_probes_interface): Add info parameter.
4727         (svr4_handle_solib_event): Pass current_program_space to
4728         get_svr4_info.  Adjust disable_probes_interface cleanup.
4729         (svr4_create_probe_breakpoints): Add info parameter, pass it
4730         down to register_solib_event_probe.
4731         (svr4_create_solib_event_breakpoints): Add info parameter,
4732         pass it down to svr4_create_probe_breakpoints.
4733         (enable_break): Pass info down to
4734         svr4_create_solib_event_breakpoints.
4735         (svr4_solib_create_inferior_hook): Pass current_program_space to
4736         get_svr4_info.
4737         (svr4_clear_solib): Likewise.
4738
4739 2019-04-22  Pedro Alves  <palves@redhat.com>
4740
4741         * solib-svr4.c (svr4_free_objfile_observer): New.
4742         (probe_and_action::objfile): New field.
4743         (probes_table_htab_remove_objfile_probes)
4744         (probes_table_remove_objfile_probes): New functions.
4745         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4746         in the new probe_and_action.  Don't store the probe in 'lookup'.
4747         (svr4_create_probe_breakpoints): Pass objfile to
4748         register_solib_event_probe.
4749         (_initialize_svr4_solib): Register a free_objfile observer.
4750
4751 2019-04-19  Tom Tromey  <tom@tromey.com>
4752
4753         * common/queue.h: Remove.
4754
4755 2019-04-19  Tom Tromey  <tom@tromey.com>
4756
4757         * event-loop.c: Don't include "common/queue.h".
4758
4759 2019-04-19  Tom Tromey  <tom@tromey.com>
4760
4761         * remote.c (remote_target): Use delete.
4762         * remote-notif.h: Include <list>, not "common/queue.h".
4763         (notif_client_p): Remove typedef.
4764         (remote_notif_state): Add constructor, destructor, initializer.
4765         <notif_queue>: Now a std::list.
4766         (remote_notif_state_xfree): Don't declare.
4767         * remote-notif.c (remote_notif_process, handle_notification)
4768         (remote_notif_state_allocate): Update.
4769         (~remote_notif_state): Rename from remote_notif_state_xfree.
4770
4771 2019-04-19  Tom Tromey  <tom@tromey.com>
4772
4773         * symfile.c (reread_symbols): Update.
4774         * objfiles.c (objfile_register_static_link)
4775         (objfile_lookup_static_link): Update
4776         (~objfile) Don't delete static_links.
4777         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4778
4779 2019-04-19  Tom Tromey  <tom@tromey.com>
4780
4781         * type-stack.h (struct type_stack) <insert>: Constify string.
4782         * type-stack.c (type_stack::insert): Constify string.
4783         * gdbtypes.h (lookup_template_type): Update.
4784         (address_space_name_to_int): Update.
4785         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4786         const.
4787         (lookup_template_type): Make name const.
4788         * c-exp.y: Update rules.
4789         (lex_one_token, classify_name, classify_inner_name)
4790         (c_print_token): Update.
4791         * p-exp.y: Update rules.
4792         (yylex): Update.
4793         * f-exp.y: Update rules.
4794         (yylex): Update.
4795         * d-exp.y: Update rules.
4796         (lex_one_token, classify_name, classify_inner_name): Update.
4797         * parse.c (write_dollar_variable, copy_name): Return std::string.
4798         * parser-defs.h (copy_name): Change return type.
4799         * m2-exp.y: Update rules.
4800         (yylex): Update.
4801         * go-exp.y (lex_one_token): Update.
4802         Update rules.
4803         (classify_unsafe_function, classify_packaged_name)
4804         (classify_name, yylex): Update.
4805
4806 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4807
4808         * configure.ac: add --enable-source-highlight switch.
4809         * configure: Regenerate.
4810         * top.c (print_gdb_version): plumb --enable-source-highlight
4811         status to "show configuration".
4812
4813 2019-04-19  Tom Tromey  <tromey@adacore.com>
4814
4815         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4816         Check ADA_TYPE_P.
4817         (empty_record, ada_template_to_fixed_record_type_1)
4818         (template_to_static_fixed_type)
4819         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4820         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4821         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4822         macros.
4823
4824 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4825
4826         PR symtab/24423:
4827         * source.c (print_source_lines_base): Advance "iter" when a
4828         control character is seen.
4829
4830 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4831
4832         * inferior.h (struct infcall_suspend_state_deleter):
4833         Catch exception in destructor to avoid crash.
4834
4835 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4836
4837         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4838         close to the add_com "shell".
4839
4840 2019-04-18  Tom Tromey  <tromey@adacore.com>
4841
4842         * process-stratum-target.h (class process_stratum_target)
4843         <stratum>: Add "final".
4844
4845 2019-04-17  Tom Tromey  <tromey@adacore.com>
4846
4847         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4848         against nullptr before use.
4849
4850 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4851
4852         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4853
4854 2019-04-17  Jim Wilson  <jimw@sifive.com>
4855             Andrew Burgess  <andrew.burgess@embecosm.com>
4856
4857         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4858         code read might fail, assume 4-byte breakpoint in that case.
4859
4860 2019-04-15  Leszek Swirski  <leszeks@google.com>
4861
4862         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4863         rather than a hand-rolled POD check when checking for forced MEMORY
4864         classification.
4865
4866 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4867
4868         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4869         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4870         function.
4871         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4872         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4873         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4874         declaration.
4875
4876 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4877
4878         * aarch64-linux-nat.c
4879         (aarch64_linux_nat_target::thread_architecture): Add override.
4880         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4881         each VQ.
4882
4883 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4884
4885         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4886
4887 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4888
4889         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4890         target types of size 96-bits, add some additional comments, and
4891         check that the builtin type we found was the correct size.
4892
4893 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4894
4895         * utils.c (prompt_for_continue): Don't restore the styling at the
4896         end, as applied_style has the wrong value.  This fixes styling in
4897         long lists of file names that are interrupted by the "Continue?"
4898         prompt.
4899
4900 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4901
4902         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4903         * c-lang.c (c_language_defn): Likewise.
4904         (cplus_language_defn): Likewise.
4905         (asm_language_defn): Likewise.
4906         (minimal_language_defn): Likewise.
4907         * d-lang.c (d_language_defn): Likewise.
4908         * f-lang.c (f_language_defn): Likewise.
4909         * go-lang.c (go_language_defn): Likewise.
4910         * language.c (unknown_language_defn): Likewise.
4911         (auto_language_defn): Likewise.
4912         * language.h (struct language_defn): Remove la_magic field.
4913         (LANG_MAGIC): Delete.
4914         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4915         * objc-lang.c (objc_language_defn): Likewise.
4916         * opencl-lang.c (opencl_language_defn): Likewise.
4917         * p-lang.c (pascal_language_defn): Likewise.
4918         * rust-lang.c (rust_language_defn): Likewise.
4919
4920 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4921
4922         * riscv-tdep.c (riscv_type_align): New function.
4923         (riscv_type_alignment): Delete.
4924         (riscv_arg_location): Use 'type_align'.
4925         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4926
4927 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4928
4929         * gdbtypes.c (type_align): A struct with no non-static fields also
4930         has alignment of 1.
4931
4932 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4933
4934         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4935         component to 0.
4936         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4937         member.
4938         (riscv_struct_info::analyse): New implementation using new
4939         analyse_inner member function.
4940         (riscv_struct_info::field_offset): New member function.
4941         (riscv_struct_info::m_offsets): New member variable.
4942         (riscv_struct_info::analyse_inner): New private member function,
4943         takes the old implementation of riscv_struct_info::analyse but
4944         extended to track field offsets.
4945         (riscv_call_arg_struct): Update the struct folding special cases
4946         to handle cases where empty C++ structs, which are non-zero
4947         length, are found.
4948         (riscv_arg_location): Initialise the length of each location, a
4949         non-zero length now indicates the location is in use.
4950         (riscv_push_dummy_call): Allow for the first location having a
4951         non-zero offset when setting up arguments.
4952         (riscv_return_value): Likewise, but for return values.
4953
4954 2019-04-11  Tom Tromey  <tromey@adacore.com>
4955
4956         * utils.c (internal_vproblem): Make "msg" const.
4957
4958 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4959
4960         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4961         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4962         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4963         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4964
4965 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4966
4967         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4968         function.
4969         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4970         of amd64_collect_native_gregset.
4971         (amd64_linux_nat_target::store_registers): Likewise.
4972
4973 2019-04-10  Tom Tromey  <tom@tromey.com>
4974
4975         * symtab.c (lookup_global_symbol_from_objfile)
4976         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4977         * objfiles.h (class separate_debug_iterator): New.
4978         (class separate_debug_range): New.
4979         (struct objfile) <separate_debug_objfiles>: New method.
4980         (objfile_separate_debug_iterate): Don't declare.
4981         * objfiles.c (separate_debug_iterator::operator++): Rename from
4982         objfile_separate_debug_iterate.
4983         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4984         iterator.
4985         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4986         iterator.
4987
4988 2019-04-10  Tom Tromey  <tom@tromey.com>
4989
4990         * symfile.c (reread_symbols): Remove old comment.
4991         * objfiles.c (free_all_objfiles): Fix a typo.
4992
4993 2019-04-10  Tom Tromey  <tom@tromey.com>
4994
4995         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4996         * minsyms.c (lookup_minimal_symbol): Use foreach.
4997         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4998         (lookup_minimal_symbol_solib_trampoline): Likewise.
4999         * symfile.c (reread_symbols): Use foreach.
5000
5001 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5002             Tom Tromey  <tromey@adacore.com>
5003
5004         PR rust/24414:
5005         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5006         (rust_lex_int_test): Change "value" to be LONGEST.
5007         (rust_lex_tests): Add test for long integer literal.
5008
5009 2019-04-09  Tom Tromey  <tromey@adacore.com>
5010
5011         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5012         to bool.
5013         (extended_remote_target::attach): Update.
5014         (remote_target::remote_notice_new_inferior): Update.
5015         (remote_target::add_current_inferior_and_thread): Update.
5016         * inferior.c (exit_inferior_1): Use "false".
5017         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5018
5019 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5020
5021         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5022         the "start" command.
5023
5024 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5025
5026         * python/py-inferior.c (infpy_thread_from_thread_handle):
5027         Adjust comments to reflect renaming of thread_from_thread_handle
5028         to thread_from_handle.  Adjust keywords.  Fix type error message.
5029         (inferior_object_methods): Add thread_from_handle.  Retain
5030         thread_from_thread_handle, but mark it as deprecated.
5031
5032 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5033
5034         * gdbthread.h (find_thread_by_handle): Revise declaration.
5035         * thread.c (find_thread_by_handle): Likewise.  Adjust
5036         implementation too.
5037         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5038         support for buffer objects as handles.
5039
5040 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5041
5042         * python/py-infthread.c (thpy_thread_handle): New function.
5043         (thread_object_methods): Register thpy_thread_handle.
5044
5045 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5046
5047         * gdbthread.h (thread_to_thread_handle): Declare.
5048         * thread.c (gdbtypes.h): Include.
5049         (thread_to_thread_handle): New function.
5050
5051         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5052         (target_thread_info_to_thread_handle): Declare.
5053         * target.c (target_thread_info_to_thread_handle): New function.
5054         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5055         * target-delegates.c: Regenerate.
5056
5057         * linux-thread-db.c (class thread_db_target): Add method
5058         thread_info_to_thread_handle.
5059         (thread_db_target::thread_info_to_thread_handle): Define.
5060         * remote.c (class remote_target): Add new method
5061         thread_info_to_thread_handle.
5062         (remote_target::thread_info_to_thread_handle): Define.
5063
5064 2019-04-08  Pedro Alves  <palves@redhat.com>
5065
5066         * common/common-exceptions.c (throw_exception): Don't create
5067         named object to throw; throw directly.
5068         (throw_it): Likewise.  Don't initialize gdb_exception::message
5069         here, with new; pass FMT and AP to the ctor instead.
5070         * common/common-exceptions.h: Include <string>.
5071         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5072         const char *, va_list)): New ctor.  Use std::make_shared.
5073         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5074         errors)): Delete.
5075         (gdb_exception_error::gdb_exception_error(enum errors, const char
5076         *, va_list)): New.
5077         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5078         Add assertion.
5079         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5080         errors)): Delete.
5081         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5082         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5083         Add assertion.
5084
5085 2019-04-08  Tom Tromey  <tom@tromey.com>
5086
5087         * valops.c (value_rtti_indirect_type): Replace throw_exception
5088         with throw.
5089         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5090         with throw.
5091         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5092         throw.
5093         * target.c (target_translate_tls_address): Replace throw_exception
5094         with throw.
5095         * stack.c (frame_apply_command_count): Replace throw_exception
5096         with throw.
5097         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5098         throw.
5099         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5100         with throw.
5101         * rs6000-tdep.c (rs6000_frame_cache)
5102         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5103         * remote.c: Replace throw_exception with throw.
5104         * record-full.c (record_full_message, record_full_wait_1)
5105         (record_full_restore): Replace throw_exception with throw.
5106         * record-btrace.c:
5107         (get_thread_current_frame_id, record_btrace_start_replaying)
5108         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5109         (cmd_record_btrace_start): Replace throw_exception with throw.
5110         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5111         throw.
5112         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5113         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5114         * linespec.c:
5115         (find_linespec_symbols): Replace throw_exception with throw.
5116         * infrun.c (displaced_step_prepare, resume): Replace
5117         throw_exception with throw.
5118         * infcmd.c (post_create_inferior): Replace throw_exception with
5119         throw.
5120         * inf-loop.c (inferior_event_handler): Replace throw_exception
5121         with throw.
5122         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5123         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5124         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5125         (get_prev_frame_always, get_frame_pc_if_available)
5126         (get_frame_address_in_block_if_available, get_frame_language):
5127         Replace throw_exception with throw.
5128         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5129         throw_exception with throw.
5130         * eval.c (fetch_subexp_value, evaluate_var_value)
5131         (evaluate_funcall, evaluate_subexp_standard): Replace
5132         throw_exception with throw.
5133         * dwarf2loc.c (call_site_find_chain)
5134         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5135         Replace throw_exception with throw.
5136         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5137         with throw.
5138         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5139         throw.
5140         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5141         * completer.c (complete_line_internal): Replace throw_exception
5142         with throw.
5143         * compile/compile-object-run.c (compile_object_run): Replace
5144         throw_exception with throw.
5145         * cli/cli-script.c (process_next_line): Replace throw_exception
5146         with throw.
5147         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5148         (btrace_enable, btrace_maint_update_pt_packets): Replace
5149         throw_exception with throw.
5150         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5151         throw_exception with throw.
5152         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5153         throw_exception with throw.
5154         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5155         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5156         * aarch64-tdep.c (aarch64_make_prologue_cache)
5157         (aarch64_make_stub_cache): Replace throw_exception with throw.
5158
5159 2019-04-08  Tom Tromey  <tom@tromey.com>
5160
5161         * common/common-exceptions.c (throw_exception): Rename from
5162         throw_exception_cxx.  Remove old copy.  Make argument const.
5163         (throw_it): Create and throw exception objects directly.
5164         * common/common-exceptions.h (throw_exception): Make argument
5165         const.
5166         (struct gdb_exception_error): Add constructor.
5167         (struct gdb_exception_quit): Add constructor.
5168
5169 2019-04-08  Tom Tromey  <tom@tromey.com>
5170
5171         * common/common-exceptions.h (exception_rethrow): Don't declare.
5172         (TRY_SJLJ): Update comment.
5173         (TRY, CATCH, END_CATCH): Remove.
5174         * common/common-exceptions.c (exception_rethrow): Remove.
5175
5176 2019-04-08  Tom Tromey  <tom@tromey.com>
5177
5178         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5179         Remove.
5180         (gdb_exception_error): Rename from
5181         gdb_exception_RETURN_MASK_ERROR.
5182         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5183         (gdb_quit_bad_alloc): Update.
5184         * aarch64-tdep.c: Update.
5185         * ada-lang.c: Update.
5186         * ada-typeprint.c: Update.
5187         * ada-valprint.c: Update.
5188         * amd64-tdep.c: Update.
5189         * arch-utils.c: Update.
5190         * break-catch-throw.c: Update.
5191         * breakpoint.c: Update.
5192         * btrace.c: Update.
5193         * c-varobj.c: Update.
5194         * cli/cli-cmds.c: Update.
5195         * cli/cli-interp.c: Update.
5196         * cli/cli-script.c: Update.
5197         * common/common-exceptions.c: Update.
5198         * common/new-op.c: Update.
5199         * common/selftest.c: Update.
5200         * compile/compile-c-symbols.c: Update.
5201         * compile/compile-cplus-symbols.c: Update.
5202         * compile/compile-object-load.c: Update.
5203         * compile/compile-object-run.c: Update.
5204         * completer.c: Update.
5205         * corelow.c: Update.
5206         * cp-abi.c: Update.
5207         * cp-support.c: Update.
5208         * cp-valprint.c: Update.
5209         * darwin-nat.c: Update.
5210         * disasm-selftests.c: Update.
5211         * dtrace-probe.c: Update.
5212         * dwarf-index-cache.c: Update.
5213         * dwarf-index-write.c: Update.
5214         * dwarf2-frame-tailcall.c: Update.
5215         * dwarf2-frame.c: Update.
5216         * dwarf2loc.c: Update.
5217         * dwarf2read.c: Update.
5218         * eval.c: Update.
5219         * event-loop.c: Update.
5220         * event-top.c: Update.
5221         * exec.c: Update.
5222         * f-valprint.c: Update.
5223         * fbsd-tdep.c: Update.
5224         * frame-unwind.c: Update.
5225         * frame.c: Update.
5226         * gdbtypes.c: Update.
5227         * gnu-v3-abi.c: Update.
5228         * guile/guile-internal.h: Update.
5229         * guile/scm-block.c: Update.
5230         * guile/scm-breakpoint.c: Update.
5231         * guile/scm-cmd.c: Update.
5232         * guile/scm-disasm.c: Update.
5233         * guile/scm-frame.c: Update.
5234         * guile/scm-lazy-string.c: Update.
5235         * guile/scm-math.c: Update.
5236         * guile/scm-param.c: Update.
5237         * guile/scm-ports.c: Update.
5238         * guile/scm-pretty-print.c: Update.
5239         * guile/scm-symbol.c: Update.
5240         * guile/scm-symtab.c: Update.
5241         * guile/scm-type.c: Update.
5242         * guile/scm-value.c: Update.
5243         * i386-linux-tdep.c: Update.
5244         * i386-tdep.c: Update.
5245         * inf-loop.c: Update.
5246         * infcall.c: Update.
5247         * infcmd.c: Update.
5248         * infrun.c: Update.
5249         * jit.c: Update.
5250         * language.c: Update.
5251         * linespec.c: Update.
5252         * linux-fork.c: Update.
5253         * linux-nat.c: Update.
5254         * linux-tdep.c: Update.
5255         * linux-thread-db.c: Update.
5256         * main.c: Update.
5257         * mi/mi-cmd-break.c: Update.
5258         * mi/mi-cmd-stack.c: Update.
5259         * mi/mi-interp.c: Update.
5260         * mi/mi-main.c: Update.
5261         * objc-lang.c: Update.
5262         * p-valprint.c: Update.
5263         * parse.c: Update.
5264         * ppc-linux-tdep.c: Update.
5265         * printcmd.c: Update.
5266         * python/py-arch.c: Update.
5267         * python/py-breakpoint.c: Update.
5268         * python/py-cmd.c: Update.
5269         * python/py-finishbreakpoint.c: Update.
5270         * python/py-frame.c: Update.
5271         * python/py-framefilter.c: Update.
5272         * python/py-gdb-readline.c: Update.
5273         * python/py-inferior.c: Update.
5274         * python/py-infthread.c: Update.
5275         * python/py-lazy-string.c: Update.
5276         * python/py-linetable.c: Update.
5277         * python/py-objfile.c: Update.
5278         * python/py-param.c: Update.
5279         * python/py-prettyprint.c: Update.
5280         * python/py-progspace.c: Update.
5281         * python/py-record-btrace.c: Update.
5282         * python/py-record.c: Update.
5283         * python/py-symbol.c: Update.
5284         * python/py-type.c: Update.
5285         * python/py-unwind.c: Update.
5286         * python/py-utils.c: Update.
5287         * python/py-value.c: Update.
5288         * python/python.c: Update.
5289         * record-btrace.c: Update.
5290         * record-full.c: Update.
5291         * remote-fileio.c: Update.
5292         * remote.c: Update.
5293         * riscv-tdep.c: Update.
5294         * rs6000-aix-tdep.c: Update.
5295         * rs6000-tdep.c: Update.
5296         * rust-exp.y: Update.
5297         * rust-lang.c: Update.
5298         * s390-tdep.c: Update.
5299         * selftest-arch.c: Update.
5300         * solib-dsbt.c: Update.
5301         * solib-frv.c: Update.
5302         * solib-spu.c: Update.
5303         * solib-svr4.c: Update.
5304         * solib.c: Update.
5305         * sparc64-linux-tdep.c: Update.
5306         * stack.c: Update.
5307         * symfile-mem.c: Update.
5308         * symmisc.c: Update.
5309         * target.c: Update.
5310         * thread.c: Update.
5311         * top.c: Update.
5312         * tracefile-tfile.c: Update.
5313         * tui/tui.c: Update.
5314         * typeprint.c: Update.
5315         * unittests/cli-utils-selftests.c: Update.
5316         * unittests/parse-connection-spec-selftests.c: Update.
5317         * valops.c: Update.
5318         * valprint.c: Update.
5319         * value.c: Update.
5320         * varobj.c: Update.
5321         * windows-nat.c: Update.
5322         * x86-linux-nat.c: Update.
5323         * xml-support.c: Update.
5324
5325 2019-04-08  Tom Tromey  <tom@tromey.com>
5326
5327         * xml-support.c: Use C++ exception handling.
5328         * x86-linux-nat.c: Use C++ exception handling.
5329         * windows-nat.c: Use C++ exception handling.
5330         * varobj.c: Use C++ exception handling.
5331         * value.c: Use C++ exception handling.
5332         * valprint.c: Use C++ exception handling.
5333         * valops.c: Use C++ exception handling.
5334         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5335         handling.
5336         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5337         * typeprint.c: Use C++ exception handling.
5338         * tui/tui.c: Use C++ exception handling.
5339         * tracefile-tfile.c: Use C++ exception handling.
5340         * top.c: Use C++ exception handling.
5341         * thread.c: Use C++ exception handling.
5342         * target.c: Use C++ exception handling.
5343         * symmisc.c: Use C++ exception handling.
5344         * symfile-mem.c: Use C++ exception handling.
5345         * stack.c: Use C++ exception handling.
5346         * sparc64-linux-tdep.c: Use C++ exception handling.
5347         * solib.c: Use C++ exception handling.
5348         * solib-svr4.c: Use C++ exception handling.
5349         * solib-spu.c: Use C++ exception handling.
5350         * solib-frv.c: Use C++ exception handling.
5351         * solib-dsbt.c: Use C++ exception handling.
5352         * selftest-arch.c: Use C++ exception handling.
5353         * s390-tdep.c: Use C++ exception handling.
5354         * rust-lang.c: Use C++ exception handling.
5355         * rust-exp.y: Use C++ exception handling.
5356         * rs6000-tdep.c: Use C++ exception handling.
5357         * rs6000-aix-tdep.c: Use C++ exception handling.
5358         * riscv-tdep.c: Use C++ exception handling.
5359         * remote.c: Use C++ exception handling.
5360         * remote-fileio.c: Use C++ exception handling.
5361         * record-full.c: Use C++ exception handling.
5362         * record-btrace.c: Use C++ exception handling.
5363         * python/python.c: Use C++ exception handling.
5364         * python/py-value.c: Use C++ exception handling.
5365         * python/py-utils.c: Use C++ exception handling.
5366         * python/py-unwind.c: Use C++ exception handling.
5367         * python/py-type.c: Use C++ exception handling.
5368         * python/py-symbol.c: Use C++ exception handling.
5369         * python/py-record.c: Use C++ exception handling.
5370         * python/py-record-btrace.c: Use C++ exception handling.
5371         * python/py-progspace.c: Use C++ exception handling.
5372         * python/py-prettyprint.c: Use C++ exception handling.
5373         * python/py-param.c: Use C++ exception handling.
5374         * python/py-objfile.c: Use C++ exception handling.
5375         * python/py-linetable.c: Use C++ exception handling.
5376         * python/py-lazy-string.c: Use C++ exception handling.
5377         * python/py-infthread.c: Use C++ exception handling.
5378         * python/py-inferior.c: Use C++ exception handling.
5379         * python/py-gdb-readline.c: Use C++ exception handling.
5380         * python/py-framefilter.c: Use C++ exception handling.
5381         * python/py-frame.c: Use C++ exception handling.
5382         * python/py-finishbreakpoint.c: Use C++ exception handling.
5383         * python/py-cmd.c: Use C++ exception handling.
5384         * python/py-breakpoint.c: Use C++ exception handling.
5385         * python/py-arch.c: Use C++ exception handling.
5386         * printcmd.c: Use C++ exception handling.
5387         * ppc-linux-tdep.c: Use C++ exception handling.
5388         * parse.c: Use C++ exception handling.
5389         * p-valprint.c: Use C++ exception handling.
5390         * objc-lang.c: Use C++ exception handling.
5391         * mi/mi-main.c: Use C++ exception handling.
5392         * mi/mi-interp.c: Use C++ exception handling.
5393         * mi/mi-cmd-stack.c: Use C++ exception handling.
5394         * mi/mi-cmd-break.c: Use C++ exception handling.
5395         * main.c: Use C++ exception handling.
5396         * linux-thread-db.c: Use C++ exception handling.
5397         * linux-tdep.c: Use C++ exception handling.
5398         * linux-nat.c: Use C++ exception handling.
5399         * linux-fork.c: Use C++ exception handling.
5400         * linespec.c: Use C++ exception handling.
5401         * language.c: Use C++ exception handling.
5402         * jit.c: Use C++ exception handling.
5403         * infrun.c: Use C++ exception handling.
5404         * infcmd.c: Use C++ exception handling.
5405         * infcall.c: Use C++ exception handling.
5406         * inf-loop.c: Use C++ exception handling.
5407         * i386-tdep.c: Use C++ exception handling.
5408         * i386-linux-tdep.c: Use C++ exception handling.
5409         * guile/scm-value.c: Use C++ exception handling.
5410         * guile/scm-type.c: Use C++ exception handling.
5411         * guile/scm-symtab.c: Use C++ exception handling.
5412         * guile/scm-symbol.c: Use C++ exception handling.
5413         * guile/scm-pretty-print.c: Use C++ exception handling.
5414         * guile/scm-ports.c: Use C++ exception handling.
5415         * guile/scm-param.c: Use C++ exception handling.
5416         * guile/scm-math.c: Use C++ exception handling.
5417         * guile/scm-lazy-string.c: Use C++ exception handling.
5418         * guile/scm-frame.c: Use C++ exception handling.
5419         * guile/scm-disasm.c: Use C++ exception handling.
5420         * guile/scm-cmd.c: Use C++ exception handling.
5421         * guile/scm-breakpoint.c: Use C++ exception handling.
5422         * guile/scm-block.c: Use C++ exception handling.
5423         * guile/guile-internal.h: Use C++ exception handling.
5424         * gnu-v3-abi.c: Use C++ exception handling.
5425         * gdbtypes.c: Use C++ exception handling.
5426         * frame.c: Use C++ exception handling.
5427         * frame-unwind.c: Use C++ exception handling.
5428         * fbsd-tdep.c: Use C++ exception handling.
5429         * f-valprint.c: Use C++ exception handling.
5430         * exec.c: Use C++ exception handling.
5431         * event-top.c: Use C++ exception handling.
5432         * event-loop.c: Use C++ exception handling.
5433         * eval.c: Use C++ exception handling.
5434         * dwarf2read.c: Use C++ exception handling.
5435         * dwarf2loc.c: Use C++ exception handling.
5436         * dwarf2-frame.c: Use C++ exception handling.
5437         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5438         * dwarf-index-write.c: Use C++ exception handling.
5439         * dwarf-index-cache.c: Use C++ exception handling.
5440         * dtrace-probe.c: Use C++ exception handling.
5441         * disasm-selftests.c: Use C++ exception handling.
5442         * darwin-nat.c: Use C++ exception handling.
5443         * cp-valprint.c: Use C++ exception handling.
5444         * cp-support.c: Use C++ exception handling.
5445         * cp-abi.c: Use C++ exception handling.
5446         * corelow.c: Use C++ exception handling.
5447         * completer.c: Use C++ exception handling.
5448         * compile/compile-object-run.c: Use C++ exception handling.
5449         * compile/compile-object-load.c: Use C++ exception handling.
5450         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5451         * compile/compile-c-symbols.c: Use C++ exception handling.
5452         * common/selftest.c: Use C++ exception handling.
5453         * common/new-op.c: Use C++ exception handling.
5454         * cli/cli-script.c: Use C++ exception handling.
5455         * cli/cli-interp.c: Use C++ exception handling.
5456         * cli/cli-cmds.c: Use C++ exception handling.
5457         * c-varobj.c: Use C++ exception handling.
5458         * btrace.c: Use C++ exception handling.
5459         * breakpoint.c: Use C++ exception handling.
5460         * break-catch-throw.c: Use C++ exception handling.
5461         * arch-utils.c: Use C++ exception handling.
5462         * amd64-tdep.c: Use C++ exception handling.
5463         * ada-valprint.c: Use C++ exception handling.
5464         * ada-typeprint.c: Use C++ exception handling.
5465         * ada-lang.c: Use C++ exception handling.
5466         * aarch64-tdep.c: Use C++ exception handling.
5467
5468 2019-04-08  Tom Tromey  <tom@tromey.com>
5469
5470         * xml-support.c (gdb_xml_parser::parse): Update.
5471         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5472         * value.c (show_convenience): Update.
5473         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5474         (test_parse_flags_qcs): Update.
5475         * thread.c (thr_try_catch_cmd): Update.
5476         * target.c (target_translate_tls_address): Update.
5477         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5478         (info_frame_command_core, frame_apply_command_count): Update.
5479         * rust-exp.y (rust_lex_exception_test): Update.
5480         * riscv-tdep.c (riscv_print_one_register_info): Update.
5481         * remote.c (remote_target::enable_btrace): Update.
5482         * record-btrace.c (record_btrace_enable_warn): Update.
5483         * python/py-utils.c (gdbpy_convert_exception): Update.
5484         * printcmd.c (do_one_display, print_variable_and_value): Update.
5485         * mi/mi-main.c (mi_print_exception): Update.
5486         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5487         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5488         * linux-nat.c (linux_nat_target::attach): Update.
5489         * linux-fork.c (class scoped_switch_fork_info): Update.
5490         * infrun.c (displaced_step_prepare): Update.
5491         * infcall.c (call_function_by_hand_dummy): Update.
5492         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5493         * gnu-v3-abi.c (print_one_vtable): Update.
5494         * frame.c (get_prev_frame_always): Update.
5495         * f-valprint.c (info_common_command_for_block): Update.
5496         * exec.c (try_open_exec_file): Update.
5497         * exceptions.c (print_exception, exception_print)
5498         (exception_fprintf, exception_print_same): Update.
5499         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5500         * dwarf-index-cache.c (index_cache::store)
5501         (index_cache::lookup_gdb_index): Update.
5502         * darwin-nat.c (maybe_cache_shell): Update.
5503         * cp-valprint.c (cp_print_value_fields): Update.
5504         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5505         (gcc_cplus_symbol_address): Update.
5506         * compile/compile-c-symbols.c (gcc_convert_symbol)
5507         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5508         * common/selftest.c: Update.
5509         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5510         a std::string.
5511         (exception_try_scope_entry, exception_try_scope_exit): Don't
5512         declare.
5513         (struct exception_try_scope): Remove.
5514         (TRY): Don't use exception_try_scope.
5515         (struct gdb_exception): Add constructor, operator=.
5516         <what>: New method.
5517         (struct gdb_exception_RETURN_MASK_ALL)
5518         (struct gdb_exception_RETURN_MASK_ERROR)
5519         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5520         (struct gdb_quit_bad_alloc): Update.
5521         * common/common-exceptions.c (exception_none): Change
5522         initializer.
5523         (struct catcher) <state, exception>: Initialize inline.
5524         <prev>: Remove member.
5525         (current_catcher): Remove.
5526         (catchers): New global.
5527         (exceptions_state_mc_init): Simplify.
5528         (catcher_pop): Remove.
5529         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5530         (try_scope_depth, exception_try_scope_entry)
5531         (exception_try_scope_exit): Remove.
5532         (throw_exception_sjlj): Update.
5533         (exception_messages, exception_messages_size): Remove.
5534         (throw_it): Simplify.
5535         (gdb_exception_sliced_copy): Remove.
5536         (throw_exception_cxx): Update.
5537         * cli/cli-script.c (script_from_file): Update.
5538         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5539         Update.
5540         * ada-valprint.c (ada_val_print): Update.
5541         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5542         (create_excep_cond_exprs): Update.
5543
5544 2019-04-08  Tom Tromey  <tom@tromey.com>
5545
5546         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5547         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5548         (TRY, CATCH, END_CATCH): Remove some definitions.
5549         * common/common-exceptions.c: Don't use GDB_XCPT.
5550         (catcher_list_size): Remove.
5551         (throw_exception, throw_it): Simplify.
5552
5553 2019-04-05  Tom Tromey  <tom@tromey.com>
5554
5555         Revert the header-sorting patch.
5556         * ft32-tdep.c: Revert.
5557         * frv-tdep.c: Revert.
5558         * frv-linux-tdep.c: Revert.
5559         * frame.c: Revert.
5560         * frame-unwind.c: Revert.
5561         * frame-base.c: Revert.
5562         * fork-child.c: Revert.
5563         * findvar.c: Revert.
5564         * findcmd.c: Revert.
5565         * filesystem.c: Revert.
5566         * filename-seen-cache.h: Revert.
5567         * filename-seen-cache.c: Revert.
5568         * fbsd-tdep.c: Revert.
5569         * fbsd-nat.h: Revert.
5570         * fbsd-nat.c: Revert.
5571         * f-valprint.c: Revert.
5572         * f-typeprint.c: Revert.
5573         * f-lang.c: Revert.
5574         * extension.h: Revert.
5575         * extension.c: Revert.
5576         * extension-priv.h: Revert.
5577         * expprint.c: Revert.
5578         * exec.h: Revert.
5579         * exec.c: Revert.
5580         * exceptions.c: Revert.
5581         * event-top.c: Revert.
5582         * event-loop.c: Revert.
5583         * eval.c: Revert.
5584         * elfread.c: Revert.
5585         * dwarf2read.h: Revert.
5586         * dwarf2read.c: Revert.
5587         * dwarf2loc.c: Revert.
5588         * dwarf2expr.h: Revert.
5589         * dwarf2expr.c: Revert.
5590         * dwarf2-frame.c: Revert.
5591         * dwarf2-frame-tailcall.c: Revert.
5592         * dwarf-index-write.h: Revert.
5593         * dwarf-index-write.c: Revert.
5594         * dwarf-index-common.c: Revert.
5595         * dwarf-index-cache.h: Revert.
5596         * dwarf-index-cache.c: Revert.
5597         * dummy-frame.c: Revert.
5598         * dtrace-probe.c: Revert.
5599         * disasm.h: Revert.
5600         * disasm.c: Revert.
5601         * disasm-selftests.c: Revert.
5602         * dictionary.c: Revert.
5603         * dicos-tdep.c: Revert.
5604         * demangle.c: Revert.
5605         * dcache.h: Revert.
5606         * dcache.c: Revert.
5607         * darwin-nat.h: Revert.
5608         * darwin-nat.c: Revert.
5609         * darwin-nat-info.c: Revert.
5610         * d-valprint.c: Revert.
5611         * d-namespace.c: Revert.
5612         * d-lang.c: Revert.
5613         * ctf.c: Revert.
5614         * csky-tdep.c: Revert.
5615         * csky-linux-tdep.c: Revert.
5616         * cris-tdep.c: Revert.
5617         * cris-linux-tdep.c: Revert.
5618         * cp-valprint.c: Revert.
5619         * cp-support.c: Revert.
5620         * cp-namespace.c: Revert.
5621         * cp-abi.c: Revert.
5622         * corelow.c: Revert.
5623         * corefile.c: Revert.
5624         * continuations.c: Revert.
5625         * completer.h: Revert.
5626         * completer.c: Revert.
5627         * complaints.c: Revert.
5628         * coffread.c: Revert.
5629         * coff-pe-read.c: Revert.
5630         * cli-out.h: Revert.
5631         * cli-out.c: Revert.
5632         * charset.c: Revert.
5633         * c-varobj.c: Revert.
5634         * c-valprint.c: Revert.
5635         * c-typeprint.c: Revert.
5636         * c-lang.c: Revert.
5637         * buildsym.c: Revert.
5638         * buildsym-legacy.c: Revert.
5639         * build-id.h: Revert.
5640         * build-id.c: Revert.
5641         * btrace.c: Revert.
5642         * bsd-uthread.c: Revert.
5643         * breakpoint.h: Revert.
5644         * breakpoint.c: Revert.
5645         * break-catch-throw.c: Revert.
5646         * break-catch-syscall.c: Revert.
5647         * break-catch-sig.c: Revert.
5648         * blockframe.c: Revert.
5649         * block.c: Revert.
5650         * bfin-tdep.c: Revert.
5651         * bfin-linux-tdep.c: Revert.
5652         * bfd-target.c: Revert.
5653         * bcache.c: Revert.
5654         * ax-general.c: Revert.
5655         * ax-gdb.h: Revert.
5656         * ax-gdb.c: Revert.
5657         * avr-tdep.c: Revert.
5658         * auxv.c: Revert.
5659         * auto-load.c: Revert.
5660         * arm-wince-tdep.c: Revert.
5661         * arm-tdep.c: Revert.
5662         * arm-symbian-tdep.c: Revert.
5663         * arm-pikeos-tdep.c: Revert.
5664         * arm-obsd-tdep.c: Revert.
5665         * arm-nbsd-tdep.c: Revert.
5666         * arm-nbsd-nat.c: Revert.
5667         * arm-linux-tdep.c: Revert.
5668         * arm-linux-nat.c: Revert.
5669         * arm-fbsd-tdep.c: Revert.
5670         * arm-fbsd-nat.c: Revert.
5671         * arm-bsd-tdep.c: Revert.
5672         * arch-utils.c: Revert.
5673         * arc-tdep.c: Revert.
5674         * arc-newlib-tdep.c: Revert.
5675         * annotate.h: Revert.
5676         * annotate.c: Revert.
5677         * amd64-windows-tdep.c: Revert.
5678         * amd64-windows-nat.c: Revert.
5679         * amd64-tdep.c: Revert.
5680         * amd64-sol2-tdep.c: Revert.
5681         * amd64-obsd-tdep.c: Revert.
5682         * amd64-obsd-nat.c: Revert.
5683         * amd64-nbsd-tdep.c: Revert.
5684         * amd64-nbsd-nat.c: Revert.
5685         * amd64-nat.c: Revert.
5686         * amd64-linux-tdep.c: Revert.
5687         * amd64-linux-nat.c: Revert.
5688         * amd64-fbsd-tdep.c: Revert.
5689         * amd64-fbsd-nat.c: Revert.
5690         * amd64-dicos-tdep.c: Revert.
5691         * amd64-darwin-tdep.c: Revert.
5692         * amd64-bsd-nat.c: Revert.
5693         * alpha-tdep.c: Revert.
5694         * alpha-obsd-tdep.c: Revert.
5695         * alpha-nbsd-tdep.c: Revert.
5696         * alpha-mdebug-tdep.c: Revert.
5697         * alpha-linux-tdep.c: Revert.
5698         * alpha-linux-nat.c: Revert.
5699         * alpha-bsd-tdep.c: Revert.
5700         * alpha-bsd-nat.c: Revert.
5701         * aix-thread.c: Revert.
5702         * agent.c: Revert.
5703         * addrmap.c: Revert.
5704         * ada-varobj.c: Revert.
5705         * ada-valprint.c: Revert.
5706         * ada-typeprint.c: Revert.
5707         * ada-tasks.c: Revert.
5708         * ada-lang.c: Revert.
5709         * aarch64-tdep.c: Revert.
5710         * aarch64-ravenscar-thread.c: Revert.
5711         * aarch64-newlib-tdep.c: Revert.
5712         * aarch64-linux-tdep.c: Revert.
5713         * aarch64-linux-nat.c: Revert.
5714         * aarch64-fbsd-tdep.c: Revert.
5715         * aarch64-fbsd-nat.c: Revert.
5716         * aarch32-linux-nat.c: Revert.
5717
5718 2019-04-05  Tom Tromey  <tom@tromey.com>
5719
5720         * ft32-tdep.c: Sort headers.
5721         * frv-tdep.c: Sort headers.
5722         * frv-linux-tdep.c: Sort headers.
5723         * frame.c: Sort headers.
5724         * frame-unwind.c: Sort headers.
5725         * frame-base.c: Sort headers.
5726         * fork-child.c: Sort headers.
5727         * findvar.c: Sort headers.
5728         * findcmd.c: Sort headers.
5729         * filesystem.c: Sort headers.
5730         * filename-seen-cache.h: Sort headers.
5731         * filename-seen-cache.c: Sort headers.
5732         * fbsd-tdep.c: Sort headers.
5733         * fbsd-nat.h: Sort headers.
5734         * fbsd-nat.c: Sort headers.
5735         * f-valprint.c: Sort headers.
5736         * f-typeprint.c: Sort headers.
5737         * f-lang.c: Sort headers.
5738         * extension.h: Sort headers.
5739         * extension.c: Sort headers.
5740         * extension-priv.h: Sort headers.
5741         * expprint.c: Sort headers.
5742         * exec.h: Sort headers.
5743         * exec.c: Sort headers.
5744         * exceptions.c: Sort headers.
5745         * event-top.c: Sort headers.
5746         * event-loop.c: Sort headers.
5747         * eval.c: Sort headers.
5748         * elfread.c: Sort headers.
5749         * dwarf2read.h: Sort headers.
5750         * dwarf2read.c: Sort headers.
5751         * dwarf2loc.c: Sort headers.
5752         * dwarf2expr.h: Sort headers.
5753         * dwarf2expr.c: Sort headers.
5754         * dwarf2-frame.c: Sort headers.
5755         * dwarf2-frame-tailcall.c: Sort headers.
5756         * dwarf-index-write.h: Sort headers.
5757         * dwarf-index-write.c: Sort headers.
5758         * dwarf-index-common.c: Sort headers.
5759         * dwarf-index-cache.h: Sort headers.
5760         * dwarf-index-cache.c: Sort headers.
5761         * dummy-frame.c: Sort headers.
5762         * dtrace-probe.c: Sort headers.
5763         * disasm.h: Sort headers.
5764         * disasm.c: Sort headers.
5765         * disasm-selftests.c: Sort headers.
5766         * dictionary.c: Sort headers.
5767         * dicos-tdep.c: Sort headers.
5768         * demangle.c: Sort headers.
5769         * dcache.h: Sort headers.
5770         * dcache.c: Sort headers.
5771         * darwin-nat.h: Sort headers.
5772         * darwin-nat.c: Sort headers.
5773         * darwin-nat-info.c: Sort headers.
5774         * d-valprint.c: Sort headers.
5775         * d-namespace.c: Sort headers.
5776         * d-lang.c: Sort headers.
5777         * ctf.c: Sort headers.
5778         * csky-tdep.c: Sort headers.
5779         * csky-linux-tdep.c: Sort headers.
5780         * cris-tdep.c: Sort headers.
5781         * cris-linux-tdep.c: Sort headers.
5782         * cp-valprint.c: Sort headers.
5783         * cp-support.c: Sort headers.
5784         * cp-namespace.c: Sort headers.
5785         * cp-abi.c: Sort headers.
5786         * corelow.c: Sort headers.
5787         * corefile.c: Sort headers.
5788         * continuations.c: Sort headers.
5789         * completer.h: Sort headers.
5790         * completer.c: Sort headers.
5791         * complaints.c: Sort headers.
5792         * coffread.c: Sort headers.
5793         * coff-pe-read.c: Sort headers.
5794         * cli-out.h: Sort headers.
5795         * cli-out.c: Sort headers.
5796         * charset.c: Sort headers.
5797         * c-varobj.c: Sort headers.
5798         * c-valprint.c: Sort headers.
5799         * c-typeprint.c: Sort headers.
5800         * c-lang.c: Sort headers.
5801         * buildsym.c: Sort headers.
5802         * buildsym-legacy.c: Sort headers.
5803         * build-id.h: Sort headers.
5804         * build-id.c: Sort headers.
5805         * btrace.c: Sort headers.
5806         * bsd-uthread.c: Sort headers.
5807         * breakpoint.h: Sort headers.
5808         * breakpoint.c: Sort headers.
5809         * break-catch-throw.c: Sort headers.
5810         * break-catch-syscall.c: Sort headers.
5811         * break-catch-sig.c: Sort headers.
5812         * blockframe.c: Sort headers.
5813         * block.c: Sort headers.
5814         * bfin-tdep.c: Sort headers.
5815         * bfin-linux-tdep.c: Sort headers.
5816         * bfd-target.c: Sort headers.
5817         * bcache.c: Sort headers.
5818         * ax-general.c: Sort headers.
5819         * ax-gdb.h: Sort headers.
5820         * ax-gdb.c: Sort headers.
5821         * avr-tdep.c: Sort headers.
5822         * auxv.c: Sort headers.
5823         * auto-load.c: Sort headers.
5824         * arm-wince-tdep.c: Sort headers.
5825         * arm-tdep.c: Sort headers.
5826         * arm-symbian-tdep.c: Sort headers.
5827         * arm-pikeos-tdep.c: Sort headers.
5828         * arm-obsd-tdep.c: Sort headers.
5829         * arm-nbsd-tdep.c: Sort headers.
5830         * arm-nbsd-nat.c: Sort headers.
5831         * arm-linux-tdep.c: Sort headers.
5832         * arm-linux-nat.c: Sort headers.
5833         * arm-fbsd-tdep.c: Sort headers.
5834         * arm-fbsd-nat.c: Sort headers.
5835         * arm-bsd-tdep.c: Sort headers.
5836         * arch-utils.c: Sort headers.
5837         * arc-tdep.c: Sort headers.
5838         * arc-newlib-tdep.c: Sort headers.
5839         * annotate.h: Sort headers.
5840         * annotate.c: Sort headers.
5841         * amd64-windows-tdep.c: Sort headers.
5842         * amd64-windows-nat.c: Sort headers.
5843         * amd64-tdep.c: Sort headers.
5844         * amd64-sol2-tdep.c: Sort headers.
5845         * amd64-obsd-tdep.c: Sort headers.
5846         * amd64-obsd-nat.c: Sort headers.
5847         * amd64-nbsd-tdep.c: Sort headers.
5848         * amd64-nbsd-nat.c: Sort headers.
5849         * amd64-nat.c: Sort headers.
5850         * amd64-linux-tdep.c: Sort headers.
5851         * amd64-linux-nat.c: Sort headers.
5852         * amd64-fbsd-tdep.c: Sort headers.
5853         * amd64-fbsd-nat.c: Sort headers.
5854         * amd64-dicos-tdep.c: Sort headers.
5855         * amd64-darwin-tdep.c: Sort headers.
5856         * amd64-bsd-nat.c: Sort headers.
5857         * alpha-tdep.c: Sort headers.
5858         * alpha-obsd-tdep.c: Sort headers.
5859         * alpha-nbsd-tdep.c: Sort headers.
5860         * alpha-mdebug-tdep.c: Sort headers.
5861         * alpha-linux-tdep.c: Sort headers.
5862         * alpha-linux-nat.c: Sort headers.
5863         * alpha-bsd-tdep.c: Sort headers.
5864         * alpha-bsd-nat.c: Sort headers.
5865         * aix-thread.c: Sort headers.
5866         * agent.c: Sort headers.
5867         * addrmap.c: Sort headers.
5868         * ada-varobj.c: Sort headers.
5869         * ada-valprint.c: Sort headers.
5870         * ada-typeprint.c: Sort headers.
5871         * ada-tasks.c: Sort headers.
5872         * ada-lang.c: Sort headers.
5873         * aarch64-tdep.c: Sort headers.
5874         * aarch64-ravenscar-thread.c: Sort headers.
5875         * aarch64-newlib-tdep.c: Sort headers.
5876         * aarch64-linux-tdep.c: Sort headers.
5877         * aarch64-linux-nat.c: Sort headers.
5878         * aarch64-fbsd-tdep.c: Sort headers.
5879         * aarch64-fbsd-nat.c: Sort headers.
5880         * aarch32-linux-nat.c: Sort headers.
5881
5882 2019-04-04  Tom Tromey  <tom@tromey.com>
5883
5884         * varobj.c (varobj_create): Update.
5885         * rust-exp.y (struct rust_parser) <update_innermost_block,
5886         lookup_symbol>: New methods.
5887         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5888         Rename.
5889         (rust_parser::rust_lookup_type)
5890         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5891         * printcmd.c (display_command, do_one_display): Update.
5892         * parser-defs.h (struct parser_state) <parser_state>: Add
5893         "tracker" parameter.
5894         (block_tracker): New member.
5895         (class innermost_block_tracker) <innermost_block_tracker>: Add
5896         "types" parameter.
5897         <reset>: Remove method.
5898         (innermost_block): Don't declare.
5899         (null_post_parser): Update.
5900         * parse.c (innermost_block): Remove global.
5901         (write_dollar_variable): Update.
5902         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5903         Remove "tracker_types" parameter.
5904         (parse_expression): Add "tracker" parameter.
5905         (parse_expression_for_completion): Update.
5906         (null_post_parser): Add "tracker" parameter.
5907         * p-exp.y: Update rules.
5908         * m2-exp.y: Update rules.
5909         * language.h (struct language_defn) <la_post_parser>: Add
5910         "tracker" parameter.
5911         * go-exp.y: Update rules.
5912         * f-exp.y: Update rules.
5913         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5914         parameter.
5915         * d-exp.y: Update rules.
5916         * c-exp.y: Update rules.
5917         * breakpoint.c (set_breakpoint_condition): Create an
5918         innermost_block_tracker.
5919         (watch_command_1): Likewise.
5920         * ada-lang.c (resolve): Add "tracker" parameter.
5921         (resolve_subexp): Likewise.
5922         * ada-exp.y (write_var_from_sym): Update.
5923
5924 2019-04-04  Tom Tromey  <tom@tromey.com>
5925
5926         * type-stack.h: New file.
5927         * type-stack.c: New file.
5928         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5929         type-stack.h.
5930         (insert_into_type_stack, insert_type, push_type, push_type_int)
5931         (insert_type_address_space, pop_type, pop_type_int)
5932         (pop_typelist, pop_type_stack, append_type_stack)
5933         (push_type_stack, get_type_stack, push_typelist)
5934         (follow_type_instance_flags, follow_types): Don't declare.
5935         * parse.c (type_stack): Remove global.
5936         (parse_exp_in_context): Update.
5937         (insert_into_type_stack, insert_type, push_type, push_type_int)
5938         (insert_type_address_space, pop_type, pop_type_int)
5939         (pop_typelist, pop_type_stack, append_type_stack)
5940         (push_type_stack, get_type_stack, push_typelist)
5941         (follow_type_instance_flags, follow_types): Remove (moved to
5942         type-stack.c).
5943         * f-exp.y (type_stack): New global.
5944         Update rules.
5945         (push_kind_type, f_parse): Update.
5946         * d-exp.y (type_stack): New global.
5947         Update rules.
5948         (d_parse): Update.
5949         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5950         Update rules.
5951         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5952         (HFILES_NO_SRCDIR): Add type-stack.h.
5953
5954 2019-04-04  Tom Tromey  <tom@tromey.com>
5955
5956         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5957         (rust_parser::convert_ast_to_expression, rust_parse)
5958         (rust_lex_test_completion, rust_lex_tests): Update.
5959         * parser-defs.h (struct expr_completion_state): New.
5960         (struct parser_state) <parser_state>: Add completion parameter.
5961         <mark_struct_expression, mark_completion_tag>: New methods.
5962         <parse_completion, m_completion_state>: New members.
5963         (prefixify_expression, null_post_parser): Update.
5964         (mark_struct_expression, mark_completion_tag): Don't declare.
5965         * parse.c (parse_completion, expout_last_struct)
5966         (expout_tag_completion_type, expout_completion_name): Remove
5967         globals.
5968         (parser_state::mark_struct_expression)
5969         (parser_state::mark_completion_tag): Now methods.
5970         (prefixify_expression): Add last_struct parameter.
5971         (prefixify_subexp): Likewise.
5972         (parse_exp_1): Update.
5973         (parse_exp_in_context): Add cstate parameter.  Update.
5974         (parse_expression_for_completion): Create an
5975         expr_completion_state.
5976         (null_post_parser): Add "completion" parameter.
5977         * p-exp.y: Update rules.
5978         (yylex): Update.
5979         * language.h (struct language_defn) <la_post_parser>: Add
5980         "completing" parameter.
5981         * go-exp.y: Update rules.
5982         (lex_one_token): Update.
5983         * expression.h (parse_completion): Don't declare.
5984         * d-exp.y: Update rules.
5985         (lex_one_token): Update rules.
5986         * c-exp.y: Update rules.
5987         (lex_one_token): Update.
5988         * ada-lang.c (resolve): Add "parse_completion" parameter.
5989         (resolve_subexp): Likewise.
5990         (ada_resolve_function): Likewise.
5991
5992 2019-04-04  Tom Tromey  <tom@tromey.com>
5993
5994         * parser-defs.h (struct parser_state) <start_arglist,
5995         end_arglist>: New methods.
5996         <arglist_len, m_funcall_chain>: New members.
5997         (arglist_len, start_arglist, end_arglist): Don't declare.
5998         * parse.c (arglist_len, funcall_chain): Remove global.
5999         (start_arglist, end_arglist): Remove functions.
6000         (parse_exp_in_context): Update.
6001         * p-exp.y: Update rules.
6002         * m2-exp.y: Update rules.
6003         * go-exp.y: Update rules.
6004         * f-exp.y: Update rules.
6005         * d-exp.y: Update rules.
6006         * c-exp.y: Update rules.
6007
6008 2019-04-04  Tom Tromey  <tom@tromey.com>
6009
6010         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6011         lex_operator, push_back>: New methods.
6012         Update all rules.
6013         (rust_parser::lex_hex, lex_escape): Rename and update.
6014         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6015         (rust_parser::lex_operator): Rename and update.
6016         (rust_parser::lex_number, rustyylex, rustyyerror)
6017         (rust_lex_test_init, rust_lex_test_sequence)
6018         (rust_lex_test_push_back, rust_lex_tests): Update.
6019         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6020         parameter.
6021         <lexptr, prev_lexptr>: New members.
6022         (lexptr, prev_lexptr): Don't declare.
6023         * parse.c (lexptr, prev_lexptr): Remove globals.
6024         (parse_exp_in_context): Update.
6025         * p-exp.y (yylex, yyerror): Update.
6026         * m2-exp.y (parse_number, yylex, yyerror): Update.
6027         * go-exp.y (lex_one_token, yyerror): Update.
6028         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6029         * d-exp.y (lex_one_token, yyerror): Update.
6030         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6031         (lex_one_token, yyerror): Update.
6032         * ada-lex.l (YY_INPUT): Update.
6033         (rewind_to_char): Update.
6034         * ada-exp.y (yyerror): Update.
6035
6036 2019-04-04  Tom Tromey  <tom@tromey.com>
6037
6038         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6039         * parser-defs.h (struct parser_state) <parser_state>: Add new
6040         parameter.
6041         <comma_terminates>: New member.
6042         (comma_terminates): Don't declare global.
6043         * parse.c (comma_terminates): Remove global.
6044         (parse_exp_in_context): Update.
6045         * p-exp.y (yylex): Update.
6046         * m2-exp.y (yylex): Update.
6047         * go-exp.y (lex_one_token): Update.
6048         * f-exp.y (yylex): Update.
6049         * d-exp.y (lex_one_token): Update.
6050         * c-exp.y (lex_one_token): Update.
6051         * ada-lex.l: Update.
6052
6053 2019-04-04  Tom Tromey  <tom@tromey.com>
6054
6055         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6056         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6057         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6058         * parser-defs.h (paren_depth): Don't declare.
6059         * parse.c (paren_depth): Remove global.
6060         (parse_exp_in_context): Update.
6061         * p-exp.y (paren_depth): New global.
6062         (pascal_parse): Initialize it.
6063         * m2-exp.y (paren_depth): New global.
6064         (m2_parse): Initialize it.
6065         * go-exp.y (paren_depth): New global.
6066         (go_parse): Initialize it.
6067         * f-exp.y (paren_depth): New global.
6068         (f_parse): Initialize it.
6069         * d-exp.y (paren_depth): New global.
6070         (d_parse): Initialize it.
6071         * c-exp.y (paren_depth): New global.
6072         (c_parse): Initialize it.
6073         * ada-lex.l (paren_depth): New global.
6074         (lexer_init): Initialize it.
6075
6076 2019-04-04  Tom Tromey  <tom@tromey.com>
6077
6078         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6079         (rust_parser::convert_ast_to_type)
6080         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6081         * parser-defs.h (struct parser_state) <parser_state>: Add
6082         parameters.  Initialize new members.
6083         <expression_context_block, expression_context_pc>: New members.
6084         * parse.c (expression_context_block, expression_context_pc):
6085         Remove globals.
6086         (parse_exp_in_context): Update.
6087         * p-exp.y: Update all rules.
6088         (yylex): Update.
6089         * m2-exp.y: Update all rules.
6090         (yylex): Update.
6091         * go-exp.y (yylex): Update.
6092         * f-exp.y (yylex): Update.
6093         * d-exp.y: Update all rules.
6094         (yylex): Update.
6095         * c-exp.y: Update all rules.
6096         (lex_one_token, classify_name, yylex, c_parse): Update.
6097         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6098
6099 2019-04-04  Tom Tromey  <tom@tromey.com>
6100
6101         * gdbarch.h, gdbarch.c: Rebuild.
6102         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6103         * stap-probe.h:
6104         (struct stap_parse_info): Replace "parser_state" with
6105         "expr_builder".
6106         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6107         (parser_state): New class.
6108         * parse.c (expr_builder): Rename.
6109         (expr_builder::release): Rename.
6110         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6111         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6112         (write_exp_elt_longcst, write_exp_elt_floatcst)
6113         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6114         (write_exp_string_vector, write_exp_bitstring)
6115         (write_exp_msymbol, mark_struct_expression)
6116         (write_dollar_variable)
6117         (insert_type_address_space, increase_expout_size): Replace
6118         "parser_state" with "expr_builder".
6119         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6120         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6121         "parser_state" with "expr_builder".
6122
6123 2019-04-04  Tom Tromey  <tom@tromey.com>
6124
6125         * rust-exp.y: Replace "parse_language" with method call.
6126         * p-exp.y:
6127         (yylex): Replace "parse_language" with method call.
6128         * m2-exp.y:
6129         (yylex): Replace "parse_language" with method call.
6130         * go-exp.y (classify_name): Replace "parse_language" with method
6131         call.
6132         * f-exp.y (yylex): Replace "parse_language" with method call.
6133         * d-exp.y (lex_one_token): Replace "parse_language" with method
6134         call.
6135         * c-exp.y:
6136         (lex_one_token, classify_name, yylex): Replace "parse_language"
6137         with method call.
6138         * ada-exp.y (find_primitive_type, type_char)
6139         (type_system_address): Replace "parse_language" with method call.
6140
6141 2019-04-04  Tom Tromey  <tom@tromey.com>
6142
6143         * rust-exp.y: Replace "parse_gdbarch" with method call.
6144         * parse.c (write_dollar_variable, insert_type_address_space):
6145         Replace "parse_gdbarch" with method call.
6146         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6147         call.
6148         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6149         call.
6150         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6151         "parse_gdbarch" with method call.
6152         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6153         with method call.
6154         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6155         "parse_gdbarch" with method call.
6156         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6157         "parse_gdbarch" with method call.
6158         * c-exp.y (parse_type, parse_number, classify_name): Replace
6159         "parse_gdbarch" with method call.
6160         * ada-lex.l: Replace "parse_gdbarch" with method call.
6161         * ada-exp.y (parse_type, find_primitive_type, type_char)
6162         (type_system_address): Replace "parse_gdbarch" with method call.
6163
6164 2019-04-04  Tom Tromey  <tom@tromey.com>
6165
6166         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6167         * stap-probe.c (stap_parse_argument): Update.
6168         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6169         initial_size parameter.
6170         * rust-exp.y (rust_lex_tests): Update.
6171         * parse.c (parser_state): Update.
6172         (parse_exp_in_context): Update.
6173         * parser-defs.h (struct parser_state) <parser_state>: Remove
6174         "initial_size" parameter.
6175
6176 2019-04-04  Tom Tromey  <tom@tromey.com>
6177
6178         * parser-defs.h (increase_expout_size): Don't declare.
6179         * parse.c (increase_expout_size): Now static.
6180
6181 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6182
6183         * gnu-nat.c (gnu_nat_target::wait): Fix
6184         target_waitstatus_to_string call.
6185
6186 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6187
6188         * eval.c (evaluate_subexp_standard): Handle internal functions
6189         during Fortran function call handling.
6190
6191 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6192
6193         * NEWS: Mention new internal functions.
6194         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6195         (read_base_type): Use dwarf2_init_complex_target_type.
6196         * value.c (creal_internal_fn): New function.
6197         (cimag_internal_fn): New function.
6198         (_initialize_values): Register new internal functions.
6199
6200 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6201
6202         * infrun.c (stop_all_threads): If debug_infrun, always
6203         trace the wait status after wait_one, using
6204         target_waitstatus_to_string and target_pid_to_str.
6205         (handle_inferior_event): Replace various trace of
6206         wait status kind by a single trace.
6207         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6208         wait status kind image by target_waitstatus_to_string.
6209         * target/waitstatus.c (target_waitstatus_to_string): Fix
6210         obsolete comment.
6211
6212 2019-04-01  Tom Tromey  <tromey@adacore.com>
6213
6214         PR symtab/23331:
6215         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6216
6217 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6218             Pedro Alves  <palves@redhat.com>
6219
6220         * top.c (quit_force): Call 'finalize_values'.
6221         * value.c (finalize_values): New function.
6222         * value.h (finalize_values): Declare.
6223
6224 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6225
6226         * NEWS: Announce $_gdb_major and $_gdb_minor.
6227
6228         * top.c (init_gdb_version_vars): New function.
6229         (gdb_init): Call init_gdb_version_vars.
6230
6231 2019-03-29  Tom Tromey  <tromey@adacore.com>
6232
6233         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6234         help text.  Remove dead code.
6235
6236 2019-03-29  Keith Seitz  <keiths@redhat.com>
6237
6238         From Siddhesh Poyarekar:
6239         * f-lang.h (f77_get_upperbound): Return LONGEST.
6240         (f77_get_lowerbound): Likewise.
6241         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6242         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6243         print them.
6244         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6245         plongest to format print it.
6246         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6247         (f77_get_upperbound): Likewise.
6248         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6249         LOWER_BOUND to LONGEST.
6250         (f77_create_arrayprint_offset_tbl): Likewise.
6251
6252 2019-03-29  Keith Seitz  <keiths@redhat.com>
6253
6254         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6255         %s/pulongest for TYPE_LENGTH instead of %d in format
6256         strings.
6257         * ada-typerint.c (ada_print_type): Likewise.
6258         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6259         * compile/compile-c-support.c (generate_register_struct): Likewise.
6260         * gdbtypes.c (recursive_dump_type): Likewise.
6261         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6262         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6263         instead of %d in format strings.
6264         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6265         to std::min to ULONGEST.
6266         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6267         instead of %d in format strings.
6268         * tracepoint.c (info_scope_command): Likewise.
6269         * typeprint.c (print_offset_data::update)
6270         (print_offset_data::finish): Likewise.
6271         * xtensa-tdep.c (xtensa_store_return_value)
6272         (xtensa_push_dummy_call): Likewise.
6273
6274 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6275
6276         * windows-nat.c (display_selector): Fixed format specifications
6277         for 64-bit Cygwin.
6278
6279 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6280
6281         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6282
6283 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6284
6285         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6286         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6287         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6288         (nios2_linux_init_abi): Install it.
6289
6290 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6291
6292         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6293
6294 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6295
6296         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6297
6298 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6299             Tom Tromey  <tromey@adacore.com>
6300
6301         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6302
6303 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6304
6305         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6306         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6307         method to compute the bounds of range types. Also print "[evaluated]"
6308         if the bounds' values come from a dynamic evaluation.
6309
6310 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6311
6312         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6313         whitespace when pretty printing is on.
6314
6315 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6316
6317         * ppc-linux-nat.c: Add include.
6318
6319 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6320
6321         * NEWS: Mention AArch64 Pointer Authentication.
6322
6323 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6324
6325         * arm-linux-nat.c: Add include.
6326
6327 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6328
6329         * source-cache.c (source_cache::get_source_lines): Re-read
6330         fullname after calling open_source_file.
6331
6332 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6333
6334         * NEWS: Mention TLS support for FreeBSD.
6335
6336 2019-03-25  Tom Tromey  <tromey@adacore.com>
6337
6338         * minsyms.c (BUNCH_SIZE): Update comment.
6339         (~minimal_symbol_reader): Remove old comment.
6340         (compact_minimal_symbols): Update comment.
6341         (minimal_symbol_reader::install): Remove old comment.  Update
6342         other comments.
6343
6344 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6345
6346         * s390-linux-nat.c: Add include.
6347
6348 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6349
6350         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6351         Call linux_get_hwcap.
6352         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6353         Likewise.
6354         (aarch64_linux_get_hwcap): Remove function.
6355         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6356         declaration.
6357         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6358         linux_get_hwcap.
6359         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6360         * linux-tdep.c (linux_get_hwcap): Add function.
6361         (linux_get_hwcap2): Likewise.
6362         * linux-tdep.h (linux_get_hwcap): Add declaration.
6363         (linux_get_hwcap2): Likewise.
6364         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6365         (ppc_linux_get_hwcap2): Likewise.
6366         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6367         linux_get_hwcap.
6368         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6369         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6370         (ppc_linux_nat_target::read_description): Likewise.
6371         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6372         * s390-linux-nat.c: Likewise.
6373         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6374
6375 2019-03-24  Tom Tromey  <tom@tromey.com>
6376
6377         * ada-lang.c (standard_lookup): Simplify initialization.
6378         (ada_lookup_symbol_nonlocal): Simplify return.
6379         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6380         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6381         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6382         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6383         initialization.
6384         * solib.c (solib_global_lookup): Simplify.
6385         * symtab.c (null_block_symbol): Remove.
6386         (symbol_cache_lookup): Simplify returns.
6387         (lookup_language_this): Simplify returns.
6388         (lookup_symbol_aux): Simplify return.
6389         (lookup_local_symbol): Simplify returns.
6390         (lookup_global_symbol_from_objfile): Simplify return.
6391         (lookup_symbol_in_objfile_symtabs)
6392         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6393         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6394         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6395         * cp-namespace.c (cp_lookup_bare_symbol)
6396         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6397         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6398         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6399         (cp_lookup_symbol_via_imports): Simplify initialization.
6400         (find_symbol_in_baseclass): Likewise.
6401         * symtab.h (null_block_symbol): Remove.
6402         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6403         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6404         (d_lookup_symbol_module): Likewise.
6405         (find_symbol_in_baseclass): Simplify initialization.
6406
6407 2019-03-24  Tom Tromey  <tom@tromey.com>
6408
6409         * expression.h: Don't include symtab.h.
6410         (struct block): Forward declare.
6411
6412 2019-03-24  Tom Tromey  <tom@tromey.com>
6413
6414         * c-exp.y (typebase): Remove casts.
6415         * gdbtypes.c (lookup_unsigned_typename, )
6416         (lookup_signed_typename): Remove cast.
6417         * eval.c (parse_to_comma_and_eval): Remove cast.
6418         * parse.c (write_dollar_variable): Remove cast.
6419         * block.h (struct block) <superblock>: Now const.
6420         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6421         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6422         (map_block): Make "block" const.
6423         * symfile.h (struct quick_symbol_functions)
6424         <map_matching_symbols>: Constify block argument to "callback".
6425         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6426         const.
6427         (find_pc_sect_compunit_symtab): Make "b" const.
6428         (find_symbol_at_address): Likewise.
6429         (search_symbols): Likewise.
6430         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6431         (dw2_debug_names_lookup_symbol): Likewise.
6432         (dw2_map_matching_symbols): Update.
6433         * p-valprint.c (pascal_val_print): Remove "block".
6434         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6435         (aux_add_nonlocal_symbols): Make "block" const.
6436         (resolve_subexp): Remove cast.
6437         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6438         const.
6439         (iterate_over_file_blocks): Likewise.
6440         * f-exp.y (%union) <bval>: Remove.
6441         * coffread.c (patch_opaque_types): Make "b" const.
6442         * spu-tdep.c (spu_catch_start): Make "block" const.
6443         * c-valprint.c (print_unpacked_pointer): Remove "block".
6444         * symmisc.c (dump_symtab_1): Make "b" const.
6445         (block_depth): Make "block" const.
6446         * d-exp.y (%union) <bval>: Remove.
6447         * cp-support.h (cp_lookup_rtti_type): Update.
6448         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6449         * psymtab.c (psym_lookup_symbol): Make "block" const.
6450         (maintenance_check_psymtabs): Make "b" const.
6451         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6452         (enumerate_locals, enumerate_args): Update.
6453         * python/py-symtab.c (stpy_global_block): Make "block" const.
6454         (stpy_static_block): Likewise.
6455         * inline-frame.c (block_starting_point_at): Make "new_block"
6456         const.
6457         * block.c (find_block_in_blockvector): Make return type const.
6458         (blockvector_for_pc_sect): Make "b" const.
6459         (find_block_in_blockvector): Make "b" const.
6460
6461 2019-03-23  Tom Tromey  <tom@tromey.com>
6462
6463         * varobj.c (varobj_create): Update.
6464         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6465         * printcmd.c (display_command, do_one_display): Don't reset
6466         innermost_block.
6467         * parser-defs.h (enum innermost_block_tracker_type): Move to
6468         expression.h.
6469         (innermost_block): Update comment.
6470         * parse.c (parse_exp_1): Add tracker_types parameter.
6471         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6472         tracker_types parameter.  Reset innermost_block.
6473         (parse_exp_in_context): Remove.
6474         (parse_expression_for_completion): Update.
6475         * objfiles.c (~objfile): Don't reset expression_context_block or
6476         innermost_block.
6477         * expression.h (enum innermost_block_tracker_type): Move from
6478         parser-defs.h.
6479         (parse_exp_1): Add tracker_types parameter.
6480         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6481         reset innermost_block.
6482
6483 2019-03-23  Tom Tromey  <tom@tromey.com>
6484
6485         * objfiles.h: Include bcache.h.
6486
6487 2019-03-23  Tom Tromey  <tom@tromey.com>
6488
6489         * linespec.c (get_current_search_block): Use
6490         scoped_restore_current_language.
6491         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6492
6493 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6494             Jiong Wang  <jiong.wang@arm.com>
6495
6496         * aarch64-linux-tdep.c
6497         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6498         section.
6499         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6500
6501 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6502             Jiong Wang  <jiong.wang@arm.com>
6503
6504         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6505         instructions.
6506         (aarch64_analyze_prologue_test): Add PACIASP test.
6507         (aarch64_prologue_prev_register): Unmask PC value.
6508
6509 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6510             Jiong Wang  <jiong.wang@arm.com>
6511
6512         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6513         (aarch64_dwarf2_prev_register): Unmask PC value.
6514         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6515         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6516         DW_CFA_AARCH64_negate_ra_state.
6517         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6518
6519 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6520             Jiong Wang  <jiong.wang@arm.com>
6521
6522         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6523         registers.
6524         (aarch64_pseudo_register_name): Likewise.
6525         (aarch64_pseudo_register_type): Likewise.
6526         (aarch64_pseudo_register_reggroup_p): Likewise.
6527         (aarch64_gdbarch_init): Add pauth registers.
6528         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6529         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6530         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6531         (struct gdbarch_tdep): Add regnum for ra_state.
6532
6533 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6534             Jiong Wang  <jiong.wang@arm.com>
6535
6536         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6537
6538 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6539             Jiong Wang  <jiong.wang@arm.com>
6540
6541         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6542         function.
6543         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6544         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6545         (aarch64_gdbarch_init): Add puth registers.
6546         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6547         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6548         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6549
6550 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6551             Jiong Wang  <jiong.wang@arm.com>
6552
6553         * aarch64-linux-nat.c
6554         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6555         * aarch64-linux-tdep.c
6556         (aarch64_linux_core_read_description): Likewise.
6557         (aarch64_linux_get_hwcap): New function.
6558         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6559         (aarch64_linux_get_hwcap): New declaration.
6560
6561 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6562             Jiong Wang  <jiong.wang@arm.com>
6563
6564         * aarch64-linux-nat.c
6565         (aarch64_linux_nat_target::read_description): Add pauth param.
6566         * aarch64-linux-tdep.c
6567         (aarch64_linux_core_read_description): Likewise.
6568         * aarch64-tdep.c (struct target_desc): Add in pauth.
6569         (aarch64_read_description): Add pauth param.
6570         (aarch64_gdbarch_init): Likewise.
6571         * aarch64-tdep.h (aarch64_read_description): Likewise.
6572         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6573         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6574         * features/Makefile: Add new files.
6575         * features/aarch64-pauth.c: New file.
6576         * features/aarch64-pauth.xml: New file.
6577
6578 2019-03-20  Tom Tromey  <tromey@adacore.com>
6579
6580         * infrun.c (handle_inferior_event): Rename from
6581         handle_inferior_event_1.  Create a scoped_value_mark.
6582         (handle_inferior_event): Remove.
6583
6584 2019-03-19  Tom Tromey  <tromey@adacore.com>
6585
6586         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6587         * infrun.h (print_stop_event): Add "displays" parameter.
6588         * infrun.c (print_stop_event): Add "displays" parameter.
6589
6590 2019-03-19  Pedro Alves  <palves@redhat.com>
6591
6592         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6593         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6594         to -1.  Fix TABs vs spaces.
6595         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6596         * tui/tui-out.h (tui_ui_out) Add intro comments.
6597         <m_line, m_start_of_line>: In-class initialize, and add describing
6598         comment.
6599
6600 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6601
6602         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6603         variable names.
6604         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6605
6606 2019-03-18  Pedro Alves  <palves@redhat.com>
6607             Eli Zaretskii <eliz@gnu.org>
6608
6609         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6610         m_line and m_start_of_line.
6611
6612 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6613
6614         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6615         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6616         it returns a newline.  This fixes a regression in TU mode, whereby
6617         the next line is output on the same screen line as the user input.
6618
6619 2019-03-18  Tom Tromey  <tromey@adacore.com>
6620
6621         * minsyms.c (minimal_symbol_reader::install): Remove call to
6622         obstack_blank.
6623
6624 2019-03-18  Pedro Alves  <palves@redhat.com>
6625
6626         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6627         New globals.
6628         (apply_style): New, factored out from ...
6629         (apply_ansi_escape): ... this.  Handle reverse video mode.
6630         (tui_set_reverse_mode): New function.
6631         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6632         * tui/tui-winsource.c (tui_show_source_line): Use
6633         tui_set_reverse_mode instead of setting A_STANDOUT.
6634         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6635         New setter methods.
6636
6637 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6638
6639         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6640         Handle tabs.
6641
6642 2019-03-18  Tom Tromey  <tromey@adacore.com>
6643
6644         * ada-lang.c (empty_array): Add "high" parameter.
6645         (ada_evaluate_subexp): Update.
6646
6647 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6648
6649         * unittests/string_view-selftests.c: Define
6650         _initialize_string_view_selftests unconditionally.
6651
6652 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6653
6654         PR gdb/24350
6655         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6656
6657 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6658
6659         PR gdb/24351
6660         * windows-nat.c (display_selector): Fix format specifiers.
6661
6662 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6663
6664         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6665         tui_refill_source_window instead of tui_refresh_win, to update the
6666         current execution line.  This fixes redisplay of the current line
6667         when stepping through the code with "next" or "step".
6668
6669 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6670
6671         * source-cache.c (source_cache::get_source_lines): Call
6672         find_source_lines to initialize s->nlines.  This fixes vertical
6673         scrolling of TUI source window when the DOWN arrow is pressed.
6674
6675 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6676
6677         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6678         linux-thread-db.c (_initialize_thread_db): Likewise.
6679
6680 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6681
6682         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6683         wclrtoeol in tui_show_source_line".  This reverts changes made in
6684         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6685
6686 2019-03-15  Tom Tromey  <tom@tromey.com>
6687
6688         * symtab.h (struct minimal_symbol): Derive from
6689         general_symbol_info.
6690         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6691         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6692         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6693         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6694         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6695         (MSYMBOL_SEARCH_NAME): Update.
6696         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6697         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6698         * minsyms.c (minimal_symbol_reader::record_full): Update.
6699
6700 2019-03-15  Tom Tromey  <tom@tromey.com>
6701
6702         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6703
6704 2019-03-15  Tom Tromey  <tom@tromey.com>
6705
6706         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6707         unique_xmalloc_ptr.
6708         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6709         Update.
6710         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6711         (build_minimal_symbol_hash_tables)
6712         (minimal_symbol_reader::install): Update.
6713
6714 2019-03-15  Tom Tromey  <tom@tromey.com>
6715
6716         * symtab.c (create_demangled_names_hash): Update.
6717         (symbol_set_names): Update.
6718         * objfiles.h (struct objfile_per_bfd_storage)
6719         <demangled_names_hash>: Now an htab_up.
6720         * objfiles.c (objfile_per_bfd_storage): Simplify.
6721
6722 2019-03-15  Tom Tromey  <tom@tromey.com>
6723
6724         * objfiles.h (struct objfile_per_bfd_storage): Declare
6725         destructor.
6726         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6727         New.
6728         (get_objfile_bfd_data): Use new.  Don't initialize
6729         language_of_main.
6730         (free_objfile_per_bfd_storage): Remove.
6731         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6732
6733 2019-03-15  Tom Tromey  <tom@tromey.com>
6734
6735         * symfile.c (reread_symbols): Update.
6736         * objfiles.c (objfile::objfile): Update.
6737         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6738         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6739         comment.
6740         (minimal_symbol_reader::install): Update.
6741         (terminate_minimal_symbol_table): Remove.
6742         * jit.c (jit_object_close_impl): Update.
6743
6744 2019-03-15  Tom Tromey  <tom@tromey.com>
6745
6746         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6747         initializations.
6748
6749 2019-03-15  Tom Tromey  <tom@tromey.com>
6750
6751         * objfiles.h (struct objfile_per_bfd_storage)
6752         <demangled_hash_languages>: Now a bitset.
6753         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6754         (lookup_minimal_symbol): Update.
6755
6756 2019-03-15  Tom Tromey  <tom@tromey.com>
6757
6758         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6759         Don't return the symbol.
6760         * coffread.c (record_minimal_symbol): Use record_full.
6761
6762 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6763
6764         The MS-Windows port of ncurses fails to switch to a color pair if
6765         one or both of the colors are the implicit default colors.  This
6766         change records the default colors when TUI is initialized, and
6767         then specifies them explicitly when a color pair uses the default
6768         colors.  This allows color styling in TUI mode on MS-Windows.
6769
6770         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6771         ncurses_norm_attr.
6772         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6773         colors in ncurses_norm_attr.
6774         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6775         "none", replace it with the default color recorded in
6776         ncurses_norm_attr.
6777
6778 2019-03-14  Tom Tromey  <tromey@adacore.com>
6779
6780         * source-cache.h (class source_cache) <get_source_lines>: Return
6781         std::string.
6782         * source-cache.c (source_cache::extract_lines): Handle case where
6783         first_pos==npos.  Return std::string.
6784         (source_cache::get_source_lines): Update.
6785
6786 2019-03-14  Tom Tromey  <tromey@adacore.com>
6787
6788         * NEWS: Add item for "style sources" commands.
6789         * source-cache.c (source_cache::get_source_lines): Check
6790         source_styling.
6791         * cli/cli-style.c (source_styling): New global.
6792         (_initialize_cli_style): Add "style sources" commands.
6793         (show_style_sources): New function.
6794         * cli/cli-style.h (source_styling): Declare.
6795
6796 2019-03-14  Pedro Alves  <palves@redhat.com>
6797             Tom Tromey  <tromey@adacore.com>
6798
6799         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6800         * tui/tui-winsource.c (tui_refill_source_window): New function,
6801         from...
6802         (tui_horizontal_source_scroll): ... here.  Move some logic.
6803         * cli/cli-style.c (set_style_enabled): Notify new observable.
6804         * tui/tui-hooks.c (tui_redisplay_source): New function.
6805         (tui_attach_detach_observers): Attach or detach
6806         tui_redisplay_source.
6807         * observable.h (source_styling_changed): New observable.
6808         * observable.c: Define source_styling_changed observable.
6809
6810 2019-03-13  Tom Tromey  <tromey@adacore.com>
6811
6812         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6813         (i386_gnu_nat_target::store_registers): Update.
6814         * target-debug.h (target_debug_print_std_string): New macro.
6815         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6816         * windows-tdep.c (display_one_tib): Update.
6817         * tui/tui-stack.c (tui_make_status_line): Update.
6818         * top.c (print_inferior_quit_action): Update.
6819         * thread.c (thr_try_catch_cmd): Update.
6820         (add_thread_with_info): Update.
6821         (thread_target_id_str): Update.
6822         (thr_try_catch_cmd): Update.
6823         (thread_command): Update.
6824         (thread_find_command): Update.
6825         * record-btrace.c (record_btrace_target::info_record)
6826         (record_btrace_resume_thread, record_btrace_target::resume)
6827         (record_btrace_cancel_resume, record_btrace_step_thread)
6828         (record_btrace_target::wait, record_btrace_target::wait)
6829         (record_btrace_target::wait, record_btrace_target::stop): Update.
6830         * progspace.c (print_program_space): Update.
6831         * process-stratum-target.c
6832         (process_stratum_target::thread_address_space): Update.
6833         * linux-fork.c (linux_fork_mourn_inferior)
6834         (detach_checkpoint_command, info_checkpoints_command)
6835         (linux_fork_context): Update.
6836         (linux_fork_detach): Update.
6837         (class scoped_switch_fork_info): Update.
6838         (delete_checkpoint_command): Update.
6839         * infrun.c (follow_fork_inferior): Update.
6840         (follow_fork_inferior): Update.
6841         (proceed_after_vfork_done): Update.
6842         (handle_vfork_child_exec_or_exit): Update.
6843         (follow_exec): Update.
6844         (displaced_step_prepare_throw): Update.
6845         (displaced_step_restore): Update.
6846         (start_step_over): Update.
6847         (resume_1): Update.
6848         (clear_proceed_status_thread): Update.
6849         (proceed): Update.
6850         (print_target_wait_results): Update.
6851         (do_target_wait): Update.
6852         (context_switch): Update.
6853         (stop_all_threads): Update.
6854         (restart_threads): Update.
6855         (finish_step_over): Update.
6856         (handle_signal_stop): Update.
6857         (switch_back_to_stepped_thread): Update.
6858         (keep_going_pass_signal): Update.
6859         (print_exited_reason): Update.
6860         (normal_stop): Update.
6861         * inferior.c (inferior_pid_to_str): Change return type.
6862         (print_selected_inferior): Update.
6863         (add_inferior): Update.
6864         (detach_inferior): Update.
6865         * dummy-frame.c (fprint_dummy_frames): Update.
6866         * dcache.c (dcache_info_1): Update.
6867         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6868         (btrace_fetch, btrace_clear): Update.
6869         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6870         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6871         type.
6872         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6873         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6874         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6875         * gdbarch.c, gdbarch.h: Rebuild.
6876         * gdbarch.sh (core_pid_to_str): Change return type.
6877         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6878         return type.
6879         (windows_nat_target::pid_to_str): Change return type.
6880         (windows_delete_thread): Update.
6881         (windows_nat_target::attach): Update.
6882         (windows_nat_target::files_info): Update.
6883         * target-delegates.c: Rebuild.
6884         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6885         return type.
6886         (sol_thread_target::pid_to_str): Change return type.
6887         * remote.c (class remote_target) <pid_to_str>: Change return
6888         type.
6889         (remote_target::pid_to_str): Change return type.
6890         (extended_remote_target::attach, remote_target::remote_stop_ns)
6891         (remote_target::remote_notif_remove_queued_reply)
6892         (remote_target::push_stop_reply, remote_target::disable_btrace):
6893         Update.
6894         (extended_remote_target::attach): Update.
6895         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6896         type.
6897         (gdbsim_target::pid_to_str): Change return type.
6898         * ravenscar-thread.c (struct ravenscar_thread_target)
6899         <pid_to_str>: Change return type.
6900         (ravenscar_thread_target::pid_to_str): Change return type.
6901         * procfs.c (class procfs_target) <pid_to_str>: Change return
6902         type.
6903         (procfs_target::pid_to_str): Change return type.
6904         (procfs_target::attach): Update.
6905         (procfs_target::detach): Update.
6906         (procfs_target::fetch_registers): Update.
6907         (procfs_target::store_registers): Update.
6908         (procfs_target::wait): Update.
6909         (procfs_target::files_info): Update.
6910         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6911         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6912         return type.
6913         (nto_procfs_target::pid_to_str): Change return type.
6914         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6915         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6916         return type.
6917         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6918         (exit_lwp): Update.
6919         (attach_proc_task_lwp_callback, get_detach_signal)
6920         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6921         (linux_nat_target::resume, wait_lwp, stop_callback)
6922         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6923         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6924         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6925         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6926         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6927         type.
6928         (inf_ptrace_target::attach): Update.
6929         (inf_ptrace_target::files_info): Update.
6930         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6931         type.
6932         (go32_nat_target::pid_to_str): Change return type.
6933         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6934         (gnu_nat_target::wait): Update.
6935         (gnu_nat_target::wait): Update.
6936         (gnu_nat_target::resume): Update.
6937         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6938         (fbsd_nat_target::wait): Update.
6939         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6940         type.
6941         (darwin_nat_target::attach): Update.
6942         * corelow.c (class core_target) <pid_to_str>: Change return type.
6943         (core_target::pid_to_str): Change return type.
6944         * target.c (normal_pid_to_str): Change return type.
6945         (default_pid_to_str): Likewise.
6946         (target_pid_to_str): Change return type.
6947         (target_translate_tls_address): Update.
6948         (target_announce_detach): Update.
6949         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6950         return type.
6951         (bsd_uthread_target::pid_to_str): Change return type.
6952         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6953         type.
6954         (bsd_kvm_target::pid_to_str): Change return type.
6955         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6956         return type.
6957         (aix_thread_target::pid_to_str): Change return type.
6958         * target.h (struct target_ops) <pid_to_str>: Change return type.
6959         (target_pid_to_str, normal_pid_to_str): Likewise.
6960         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6961         type.
6962         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6963         type.
6964         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6965         return type.
6966         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6967         type.
6968         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6969         type.
6970         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6971         return type.
6972
6973 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6974
6975         * NEWS: Mention that the new default MI version is 3.  Mention
6976         changes to the output of commands and events that deal with
6977         multi-location breakpoints.
6978         * breakpoint.c: Include "mi/mi-out.h".
6979         (print_one_breakpoint): Change output syntax if using MI version
6980         >= 3.
6981         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6982         New.
6983         (mi_multi_location_breakpoint_output_fixed): New.
6984         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6985         (mi_cmd_fix_multi_location_breakpoint_output): New.
6986         (mi_multi_location_breakpoint_output_fixed): New.
6987         * mi/mi-cmds.c (mi_cmds): Register command
6988         -fix-multi-location-breakpoint-output.
6989         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6990         interpreter "mi".
6991
6992 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6993
6994         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6995         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6996         instantiate mi_ui_out based on interpreter name.
6997         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6998         * mi/mi-main.c (mi_load_progress): Likewise.
6999
7000 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7001
7002         * NEWS: Combine separate "New targets" sections for 8.3.
7003
7004 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7005
7006         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7007         (ppcfbsd_init_abi): Install gdbarch
7008         "fetch_tls_load_module_address" and "get_thread_local_address"
7009         methods.
7010
7011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7012
7013         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7014         (riscv_fbsd_init_abi): Install gdbarch
7015         "fetch_tls_load_module_address" and "get_thread_local_address"
7016         methods.
7017
7018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7019
7020         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7021         (i386fbsd_init_abi): Install gdbarch
7022         "fetch_tls_load_module_address" and "get_thread_local_address"
7023         methods.
7024
7025 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7026
7027         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7028         (amd64fbsd_init_abi): Install gdbarch
7029         "fetch_tls_load_module_address" and "get_thread_local_address"
7030         methods.
7031
7032 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7033
7034         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7035         (struct fbsd_pspace_data): New type.
7036         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7037         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7038         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7039         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7040         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7041
7042 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7043
7044         * gdbtypes.c (lookup_struct_elt): New function.
7045         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7046         * gdbtypes.h (struct struct_elt): New type.
7047         (lookup_struct_elt): New prototype.
7048
7049 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7050
7051         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7052         remove disabled code block.
7053
7054 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7055
7056         * gdbarch.sh (get_thread_local_address): New method.
7057         * gdbarch.h, gdbarch.c: Regenerate.
7058         * target.c (target_translate_tls_address): Use
7059         gdbarch_get_thread_local_address if present instead of
7060         target::get_thread_local_address.
7061
7062 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7063
7064         * target.h (target::get_thread_local_address): Update comment.
7065
7066 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7067
7068         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7069         objfile->separate_debug_objfile_backlink if not NULL.
7070
7071 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7072
7073         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7074         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7075         (amd64bsd_store_inferior_registers): Likewise.
7076         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7077         Enable segment base registers.
7078         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7079         PT_GETFSBASE and PT_GETGSBASE.
7080         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7081         PT_SETGSBASE.
7082         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7083         segment base registers.
7084         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7085
7086 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7087
7088         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7089         Update calls to i386_target_description to add 'segments'
7090         parameter.
7091         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7092         add segment base registers.
7093         * arch/i386.c (i386_create_target_description): Add 'segments'
7094         parameter to enable segment base registers.
7095         * arch/i386.h (i386_create_target_description): Likewise.
7096         * features/i386/32bit-segments.xml: New file.
7097         * features/i386/32bit-segments.c: Generate.
7098         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7099         call to i386_target_description to add 'segments' parameter.
7100         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7101         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7102         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7103         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7104         if feature is present.
7105         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7106         Add 'segments' parameter to call to i386_target_description.
7107         (i386_target_description): Add 'segments' parameter to enable
7108         segment base registers.
7109         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7110         to call to i386_target_description.
7111         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7112         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7113         Define I386_NUM_REGS.
7114         (i386_target_description): Add 'segments' parameter to enable
7115         segment base registers.
7116
7117 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7118
7119         PR/24325
7120         * source-cache.c: #undef open and close, to avoid unresolved
7121         externals during linking.
7122
7123 2019-03-12  Tom Tromey  <tromey@adacore.com>
7124
7125         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7126         const.  Add initializers.
7127         (_initialize_remote): Don't initialize ptid globals.
7128
7129 2019-03-12  Pedro Alves  <palves@redhat.com>
7130
7131         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7132
7133 2019-03-12  Pedro Alves  <palves@redhat.com>
7134
7135         * cp-name-parser.y (main): Remove unused 'len' variable.
7136
7137 2019-03-12  Tom Tromey  <tromey@adacore.com>
7138
7139         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7140         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7141
7142 2019-03-12  Tom Tromey  <tromey@adacore.com>
7143
7144         * linux-nat.c (iterate_over_lwps): Update.
7145         (stop_callback): Remove parameter.
7146         (stop_wait_callback, detach_callback, resume_set_callback)
7147         (select_singlestep_lwp_callback, set_ignore_sigint)
7148         (status_callback, resumed_callback, resume_clear_callback)
7149         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7150         data parameter.
7151         (linux_nat_target::detach, linux_nat_target::resume)
7152         (linux_stop_and_wait_all_lwps, select_event_lwp)
7153         (linux_nat_filter_event, linux_nat_wait_1)
7154         (linux_nat_target::kill, linux_nat_target::stop)
7155         (linux_nat_target::stop): Update.
7156         (linux_nat_resume_callback): Change type.
7157         (resume_stopped_resumed_lwps, count_events_callback)
7158         (select_event_lwp_callback): Likewise.
7159         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7160         * arm-linux-nat.c (struct update_registers_data): Remove.
7161         (update_registers_callback): Change type.
7162         (arm_linux_insert_hw_breakpoint1): Update.
7163         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7164         parameter.
7165         (x86_linux_dr_set_addr): Update.
7166         (x86_linux_dr_set_control): Update.
7167         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7168         (iterate_over_lwps): Use gdb::function_view.
7169         * nat/aarch64-linux-hw-point.c (struct
7170         aarch64_dr_update_callback_param): Remove.
7171         (debug_reg_change_callback): Change type.
7172         (aarch64_notify_debug_reg_change): Update.
7173         * s390-linux-nat.c (s390_refresh_per_info): Update.
7174
7175 2019-03-11  Tom Tromey  <tromey@adacore.com>
7176
7177         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7178         redundant assignment to "this_cu".
7179
7180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7181
7182         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7183
7184 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7185
7186         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7187         from...
7188         (rank_one_type): ... this.
7189
7190 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7191
7192         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7193         from...
7194         (rank_one_type): ... this.
7195
7196 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7197
7198         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7199         from...
7200         (rank_one_type): ... this.
7201
7202 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7203
7204         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7205         from...
7206         (rank_one_type): ... this.
7207
7208 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7209
7210         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7211         from...
7212         (rank_one_type): ... this.
7213
7214 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7215
7216         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7217         from...
7218         (rank_one_type): ... this.
7219
7220 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7221
7222         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7223         from...
7224         (rank_one_type): ... this.
7225
7226 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7227
7228         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7229         from...
7230         (rank_one_type): ... this.
7231
7232 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7233
7234         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7235         from...
7236         (rank_one_type): ... this.
7237
7238 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7239
7240         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7241         from...
7242         (rank_one_type): ... this.
7243
7244 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7245
7246         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7247         from...
7248         (rank_one_type): ... this.
7249
7250 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7251
7252         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7253         from...
7254         (rank_one_type): ... this.
7255
7256 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7257
7258         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7259         inferior-events' shows the example events.
7260
7261 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7262
7263         Support styling on native MS-Windows console
7264
7265         PR/24315
7266         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7267         on MS-Windows if $TERM is not defined.
7268
7269         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7270
7271         * posix-hdep.c (gdb_console_fputs):
7272         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7273         functions.
7274         * ui-file.h (gdb_console_fputs): Add prototype.
7275
7276         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7277         back to fputs only if the former returns zero.
7278
7279 2019-03-07  Tom Tromey  <tom@tromey.com>
7280
7281         * symmisc.c (print_symbol_bcache_statistics): Update.
7282         (print_objfile_statistics): Update.
7283         * symfile.c (allocate_symtab): Update.
7284         * stabsread.c: Don't include bcache.h.
7285         * psymtab.h (struct psymbol_bcache): Don't declare.
7286         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7287         (psymbol_bcache_init, psymbol_bcache_free)
7288         (psymbol_bcache_get_bcache): Don't declare.
7289         * psymtab.c (struct psymbol_bcache): Remove.
7290         (psymtab_storage::psymtab_storage): Update.
7291         (psymtab_storage::~psymtab_storage): Update.
7292         (psymbol_bcache_init, psymbol_bcache_free)
7293         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7294         (add_psymbol_to_bcache): Update.
7295         (allocate_psymtab): Update.
7296         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7297         macro_cache>: No longer pointers.
7298         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7299         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7300         * macrotab.c (macro_bcache): Update.
7301         * macroexp.c: Don't include bcache.h.
7302         * gdbtypes.c (check_types_worklist): Update.
7303         (types_deeply_equal): Remove TRY/CATCH.  Update.
7304         * elfread.c (elf_symtab_read): Update.
7305         * dwarf2read.c: Don't include bcache.h.
7306         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7307         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7308         (print_bcache_statistics, bcache_memory_used): Don't declare.
7309         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7310         methods.  Rename all data members.
7311         * bcache.c (struct bcache): Move to bcache.h.
7312         (bcache::expand_hash_table): Rename from expand_hash_table.
7313         (bcache): Remove.
7314         (bcache::insert): Rename from bcache_full.
7315         (bcache::compare): Rename from bcache_compare.
7316         (bcache_xmalloc): Remove.
7317         (bcache::~bcache): Rename from bcache_xfree.
7318         (bcache::print_statistics): Rename from print_bcache_statistics.
7319         (bcache::memory_used): Rename from bcache_memory_used.
7320
7321 2019-03-07  Pedro Alves  <palves@redhat.com>
7322
7323         * infrun.c (normal_stop): Also check for
7324         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7325
7326 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7327
7328         * f-lang.c (value_from_host_double): Moved to...
7329         * value.c (value_from_host_double): ...here.
7330         * value.h (value_from_host_double): Declare.
7331         * guile/scm-math.c (vlscm_convert_typed_number): Use
7332         value_from_host_double.
7333         (vlscm_convert_number): Likewise.
7334         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7335         * python/py-value.c (convert_value_from_python): Likewise.
7336
7337 2019-03-06  Tom Tromey  <tom@tromey.com>
7338
7339         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7340
7341 2019-03-06  Tom Tromey  <tom@tromey.com>
7342
7343         * utils.h (free_current_contents): Don't declare.
7344         * utils.c (free_current_contents): Remove.
7345
7346 2019-03-06  Tom Tromey  <tom@tromey.com>
7347
7348         * top.c (quit_force): Update.
7349         * main.c (captured_command_loop): Update.
7350         * common/new-op.c (operator new): Update.
7351         * common/common-exceptions.c (struct catcher)
7352         <save_cleanup_chain>: Remove member.
7353         (exceptions_state_mc_init): Update.
7354         (exception_try_scope_entry): Return nullptr.
7355         (exception_try_scope_exit, exception_rethrow)
7356         (throw_exception_sjlj, throw_exception_cxx): Update.
7357         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7358         (all_cleanups, do_cleanups, discard_cleanups)
7359         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7360         (restore_cleanups, restore_final_cleanups): Don't declare.
7361         (do_final_cleanups): Remove parameter.
7362         * common/cleanups.c (cleanup_chain, make_cleanup)
7363         (make_cleanup_dtor, all_cleanups, do_cleanups)
7364         (discard_my_cleanups, discard_cleanups)
7365         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7366         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7367         (null_cleanup): Remove.
7368         (do_final_cleanups): Remove parameter.
7369
7370 2019-03-06  Tom Tromey  <tom@tromey.com>
7371
7372         * remote.c (remote_target::remote_parse_stop_reply): Use
7373         unique_xmalloc_ptr.
7374
7375 2019-03-06  Tom Tromey  <tom@tromey.com>
7376
7377         * stabsread.c (struct stabs_field_info): Rename from field_info.
7378         <list, fnlist>: Add initializers.
7379         <obstack>: New member.
7380         (read_member_functions, read_struct_fields, read_baseclasses):
7381         Allocate on obstack.  Don't use cleanups.
7382         (read_one_struct_field, read_member_functions, read_struct_fields)
7383         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7384         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7385         (read_struct_type): Update.
7386
7387 2019-03-06  Tom Tromey  <tom@tromey.com>
7388
7389         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7390         * common/filestuff.h (make_cleanup_close): Don't declare.
7391         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7392         Remove.
7393
7394 2019-03-06  Tom Tromey  <tom@tromey.com>
7395
7396         * solib-aix.c: Use make_scope_exit.
7397
7398 2019-03-06  Tom Tromey  <tom@tromey.com>
7399
7400         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7401         Use make_scope_exit.
7402
7403 2019-03-06  Tom Tromey  <tom@tromey.com>
7404
7405         * solib-svr4.c (disable_probes_interface): Remove parameter.
7406         (svr4_handle_solib_event): Use make_scope_exit.
7407
7408 2019-03-06  Tom Tromey  <tom@tromey.com>
7409
7410         * remote.c (struct stop_reply_deleter): Remove.
7411         (stop_reply_up): Update.
7412         (struct stop_reply): Derive from notif_event.  Don't typedef.
7413         <regcache>: Now a std::vector.
7414         (stop_reply_xfree): Remove.
7415         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7416         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7417         (remote_target::discard_pending_stop_replies): Use delete.
7418         (remote_target::remote_parse_stop_reply): Update.
7419         (remote_target::process_stop_reply): Update.
7420         * remote-notif.h (struct notif_event): Add virtual destructor.
7421         Remove "dtr" member.
7422         (struct notif_client) <alloc_event>: Return a unique_ptr.
7423         (notif_event_xfree): Don't declare.
7424         (notif_event_up): New typedef.
7425         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7426         (notif_event_xfree, do_notif_event_xfree): Remove.
7427         (remote_notif_state_xfree): Update.
7428
7429 2019-03-06  Tom Tromey  <tom@tromey.com>
7430
7431         * infrun.c (displaced_step_clear_cleanup): Now a
7432         forward_scope_exit type.
7433         (displaced_step_prepare_throw): Update.
7434         (displaced_step_fixup): Update.
7435
7436 2019-03-06  Tom Tromey  <tom@tromey.com>
7437
7438         * inferior.h (class inferior): Update comment.
7439         * gdbthread.h (class thread_info): Update comment.
7440
7441 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7442             Tom Tromey  <tom@tromey.com>
7443
7444         * stabsread.h (struct stab_section_list): Remove.
7445         (coffstab_build_psymtabs): Update.
7446         * dbxread.c (symbuf_sections): Now a std::vector.
7447         (sect_idx): New global.
7448         (fill_symbuf): Update.
7449         (coffstab_build_psymtabs): Change type of stabsects parameter.
7450         Update.
7451         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7452         std::vector.
7453         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7454         (coff_locate_sections): Update.
7455         (coff_symfile_read): Remove cleanups.  Update.
7456         (init_stringtab): Add storage parameter.
7457         (free_stringtab, free_stringtab_cleanup): Remove.
7458         (init_lineno): Add storage parameter.
7459         (free_linetab, free_linetab_cleanup): Remove.
7460
7461 2019-03-06  Pedro Alves  <palves@redhat.com>
7462
7463         * linux-fork.c (fork_info::clobber_regs): Delete.
7464         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7465         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7466         comment.  Adjust.
7467         (scoped_switch_fork_info::scoped_switch_fork_info)
7468         (checkpoint_command, linux_fork_context): Adjust
7469         fork_save_infrun_state calls.
7470
7471 2019-03-06  Pedro Alves  <palves@redhat.com>
7472
7473         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7474         (inf_has_multiple_threads): Return 'bool' and rewrite using
7475         inferior_info::threads().
7476
7477 2019-03-06  Pedro Alves  <palves@redhat.com>
7478
7479         * linux-fork.c: Include <list>.
7480         (fork_list): Now a std::list instance.
7481         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7482         (forks_exist_p, find_last_fork): Adjust.
7483         (new_fork): Delete.
7484         (one_fork_p): New.
7485         (add_fork): Adjust.
7486         (free_fork): Delete, folded into fork_info::~fork_info().
7487         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7488         Adjust.
7489         (init_fork_list): Delete.
7490         (linux_fork_killall, linux_fork_mourn_inferior)
7491         (linux_fork_detach, info_checkpoints_command): Adjust.
7492         (_initialize_linux_fork): No longer call init_fork_list.
7493
7494 2019-03-06  Pedro Alves  <palves@redhat.com>
7495
7496         * linux-fork.c (new_fork): New, split out of ...
7497         (add_fork): ... this.  Return void.  Move "first fork" special
7498         case from here, to ...
7499         (checkpoint_command): ... here.
7500         * linux-linux.h (add_fork): Return void.
7501
7502 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7503
7504         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7505
7506 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7507             Chris January  <chris.january@arm.com>
7508             David Lecomber  <david.lecomber@arm.com>
7509
7510         * f-exp.y: New token, UNOP_INTRINSIC.
7511         (exp): New pattern using UNOP_INTRINSIC token.
7512         (f77_keywords): Add 'abs' keyword.
7513         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7514         (value_from_host_double): New function.
7515         (evaluate_subexp_f): Support UNOP_ABS.
7516
7517 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7518
7519         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7520         types.
7521
7522 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7525         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7526         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7527
7528 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7529
7530         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7531
7532 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7533             Chris January  <chris.january@arm.com>
7534
7535         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7536         * f-exp.y: Define 'KIND' token.
7537         (exp): New pattern for KIND expressions.
7538         (ptype): Handle types with a kind extension.
7539         (direct_abs_decl): Extend to spot kind extensions.
7540         (f77_keywords): Add 'kind' to the list.
7541         (push_kind_type): New function.
7542         (convert_to_kind_type): New function.
7543         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7544         * parse.c (operator_length_standard): Likewise.
7545         * parser-defs.h (enum type_pieces): Add tp_kind.
7546         * std-operator.def: Add UNOP_KIND.
7547
7548 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7549
7550         * f-exp.y (f_parse): Set yydebug.
7551
7552 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7553
7554         * f-lang.c (evaluate_subexp_f): New function.
7555         (exp_descriptor_f): New global.
7556         (f_language_defn): Use exp_descriptor_f instead of
7557         exp_descriptor_standard.
7558
7559 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7560
7561         * f-exp.y (struct token): Add comments.
7562         (dot_ops): Remove uppercase versions and the end marker.
7563         (f77_keywords): Likewise.
7564         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7565         entries in the dot_ops array are case insensitive, and use
7566         strncasecmp to compare strings.  Also some whitespace cleanup in
7567         this area.  Similar for the f77_keywords array, except entries in
7568         this list might be case sensitive.
7569
7570 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7571
7572         * f-exp.y (struct f77_boolean_val): Add comments.
7573         (boolean_values): Remove uppercase versions, and end marker.
7574         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7575         and use strncasecmp to achieve case insensitivity.  Additionally,
7576         perform whitespace cleanup around this code.
7577
7578 2019-03-06  Tom Tromey  <tromey@adacore.com>
7579
7580         * remote-sim.c (gdbsim_target_open): Use result of
7581         gdb_argv::release.
7582
7583 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7584         Dirk Schubert  <dirk.schubert@arm.com>
7585         Chris January  <chris.january@arm.com>
7586
7587         * eval.c (evaluate_subexp_standard): Call Fortran argument
7588         wrapping logic.
7589         * f-lang.c (struct value): A value which can be passed into a
7590         Fortran function call.
7591         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7592         where appropriate.
7593         (struct type): Value ready for a Fortran function call.
7594         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7595         is needed.
7596         * f-lang.h (fortran_argument_convert): Declaration.
7597         (fortran_preserve_arg_pointer): Declaration.
7598         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7599
7600 2019-03-05  Tom Tromey  <tromey@adacore.com>
7601
7602         * python/py-prettyprint.c (print_string_repr): Remove #if.
7603         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7604
7605 2019-03-05  Tom Tromey  <tromey@adacore.com>
7606
7607         * target.c (the_dummy_target): Move later.  Change type to
7608         "dummy_target".
7609         (initialize_targets): Don't initialize the_dummy_target.
7610
7611 2019-03-05  Tom Tromey  <tromey@adacore.com>
7612
7613         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7614         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7615
7616 2019-03-05  Tom Tromey  <tromey@adacore.com>
7617
7618         * windows-nat.c (windows_nat_target::attach)
7619         (windows_nat_target::detach): Don't call gdb_flush.
7620         * valprint.c (generic_val_print, val_print, val_print_string):
7621         Don't call gdb_flush.
7622         * utils.c (defaulted_query): Don't call gdb_flush.
7623         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7624         * target.c (target_announce_detach): Don't call gdb_flush.
7625         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7626         * remote.c (extended_remote_target::attach): Don't call
7627         gdb_flush.
7628         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7629         * printcmd.c (do_examine): Don't call gdb_flush.
7630         (info_display_command): Don't call gdb_flush.
7631         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7632         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7633         * memattr.c (info_mem_command): Don't call gdb_flush.
7634         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7635         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7636         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7637         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7638         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7639         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7640         (gnu_nat_target::detach): Don't call gdb_flush.
7641         * f-valprint.c (f_val_print): Don't call gdb_flush.
7642         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7643         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7644         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7645         gdb_flush.
7646         * c-valprint.c (c_val_print): Don't call gdb_flush.
7647         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7648
7649 2019-03-05  Tom Tromey  <tromey@adacore.com>
7650
7651         * varobj.c (update_dynamic_varobj_children): Update.
7652         (install_default_visualizer): Use reset, not release.
7653         * value.c (set_internalvar): Update.
7654         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7655         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7656         ATTRIBUTE_UNUSED_RESULT.
7657
7658 2019-03-05  Tom Tromey  <tromey@adacore.com>
7659
7660         * remote.c (class scoped_remote_fd) <release>: Add
7661         ATTRIBUTE_UNUSED_RESULT.
7662
7663 2019-03-05  Tom Tromey  <tromey@adacore.com>
7664
7665         * macroexp.c (struct macro_buffer) <release>: Add
7666         ATTRIBUTE_UNUSED_RESULT.
7667
7668 2019-03-05  Tom Tromey  <tromey@adacore.com>
7669
7670         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7671         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7672         ATTRIBUTE_UNUSED_RESULT.
7673
7674 2019-03-05  Tom Tromey  <tromey@adacore.com>
7675
7676         * common/scoped_fd.h (class scoped_fd) <release>: Add
7677         ATTRIBUTE_UNUSED_RESULT.
7678
7679 2019-03-05  Tom Tromey  <tromey@adacore.com>
7680
7681         * parser-defs.h (struct parser_state) <release>: Add
7682         ATTRIBUTE_UNUSED_RESULT.
7683
7684 2019-03-05  Tom Tromey  <tromey@adacore.com>
7685
7686         * utils.h (class gdb_argv) <release>: Add
7687         ATTRIBUTE_UNUSED_RESULT.
7688         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7689
7690 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7691
7692         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7693         for-loop range, to avoid compiler warnings.
7694
7695         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7696         avoid compiler warnings about unused variables.
7697
7698         * NEWS: Mention end of support for native debugging on MS-Windows
7699         before XP.
7700
7701         PR gdb/24292
7702         * common/netstuff.c:
7703         * gdbserver/gdbreplay.c
7704         * gdbserver/remote-utils.c:
7705         * ser-tcp.c:
7706         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7707         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7708         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7709         'getaddrinfo' and 'freeaddrinfo' were not available before
7710         Windows XP, and mingw.org's MinGW headers by default define
7711         _WIN32_WINNT to 0x500.
7712
7713 2019-03-01  Gary Benson <gbenson@redhat.com>
7714
7715         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7716
7717 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7718             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7719
7720         PR gdb/8527
7721         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7722         set_sigint_trap, clear_sigint_trap.
7723
7724 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7725
7726         * target.c (target_detach): Clear the regcache and the
7727         frame cache.
7728
7729 2019-02-27  Pedro Alves  <palves@redhat.com>
7730
7731         * utils.c (set_screen_size): When we cap the height/width sizes,
7732         tweak the corresponding command variable to show "unlimited":
7733
7734 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7735             Pedro Alves  <palves@redhat.com>
7736
7737         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7738         before calling rl_set_screen_size.
7739
7740 2019-02-27  Tom Tromey  <tromey@adacore.com>
7741
7742         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7743         define.
7744         * python/py-value.c: Remove Python 2.4 workaround.
7745         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7746         workaround.
7747         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7748         Python 2.4 workaround.
7749         * python/python-internal.h: Remove Python 2.4 comment.
7750         (Py_ssize_t): Don't define.
7751         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7752         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7753         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7754         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7755         * python/python.c (do_start_initialization): Remove Python 2.4
7756         workaround.
7757         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7758         (print_children): Remove Python 2.4 workaround.
7759         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7760         workaround.
7761         (CHARBUFFERPROC_NAME): Remove.
7762         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7763         Python 2.4 workaround.
7764
7765 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7766
7767         * NEWS: Note minimum Python version.
7768
7769 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7770
7771         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7772         code from these functions.  Remove corresponding ifdefs.  Use
7773         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7774         Remove gotos and target of gotos.
7775         (infpy_search_memory): Likewise.
7776
7777 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7778
7779         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7780         (hppa_gdbarch_init): Don't register deleted functions with
7781         gdbarch.
7782
7783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7784
7785         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7786         (h8300_unwind_sp): Delete.
7787         (h8300_dummy_id): Delete.
7788         (h8300_gdbarch_init): Don't register deleted functions with
7789         gdbarch.
7790
7791 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7792
7793         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7794         (ft32_unwind_pc): Delete.
7795         (ft32_unwind_sp): Delete.
7796         (ft32_gdbarch_init): Don't register deleted functions with
7797         gdbarch.
7798
7799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7800
7801         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7802         (frv_unwind_pc): Delete.
7803         (frv_unwind_sp): Delete.
7804         (frv_gdbarch_init): Don't register deleted functions with
7805         gdbarch.
7806
7807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7808
7809         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7810         (riscv_unwind_pc): Delete.
7811         (riscv_unwind_sp): Delete.
7812         (riscv_gdbarch_init): Don't register deleted functions with
7813         gdbarch.
7814
7815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7816
7817         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7818         (csky_unwind_pc): Delete.
7819         (csky_unwind_sp): Delete.
7820         (csky_gdbarch_init): Don't register deleted functions with
7821         gdbarch.
7822
7823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7824
7825         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7826         (cris_unwind_pc): Delete.
7827         (cris_unwind_sp): Delete.
7828         (cris_gdbarch_init): Don't register deleted functions with
7829         gdbarch.
7830
7831 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7832
7833         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7834         (bfin_unwind_pc): Delete.
7835         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7836
7837 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7838
7839         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7840         (arm_unwind_pc): Delete.
7841         (arm_unwind_sp): Delete.
7842         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7843
7844 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7845
7846         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7847         (arc_unwind_pc): Delete.
7848         (arc_unwind_sp): Delete.
7849         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7850
7851 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7852
7853         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7854         (alpha_unwind_pc): Delete.
7855         (alpha_gdbarch_init): Don't register deleted functions with
7856         gdbarch.
7857
7858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7859
7860         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7861         (aarch64_unwind_pc): Delete.
7862         (aarch64_unwind_sp): Delete.
7863         (aarch64_gdbarch_init): Don't register deleted functions with
7864         gdbarch.
7865
7866 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7867
7868         * gdbtypes.c (type_align): Don't consider static members when
7869         computing structure alignment.
7870
7871 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7872
7873         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7874         return 0 for other types.
7875         * arch-utils.c (default_type_align): Always return 0.
7876         * gdbarch.h: Regenerate.
7877         * gdbarch.sh (type_align): Extend comment.
7878         * gdbtypes.c (type_align): Add additional comments, always call
7879         gdbarch_type_align before applying the default rules.
7880         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7881         generic code will then apply a suitable default.
7882         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7883         types, return 0 for other types.
7884
7885 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7886
7887         * NEWS: Create a new section for the next release branch.
7888         Rename the section of the current branch, now that it has
7889         been cut.
7890
7891 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7892
7893         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7894         * version.in: Bump version to 8.3.50.DATE-git.
7895
7896 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7897
7898         * aix-thread.c (ptid_cmp): Remove unused variable.
7899         (get_signaled_thread): Likewise.
7900         (store_regs_user_thread): Likewise.
7901         (store_regs_kernel_thread): Likewise.
7902         (fetch_regs_kernel_thread): Remove shadowed variable.
7903
7904 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7905
7906         * features/riscv/32bit-cpu.xml: Add register numbers.
7907         * features/riscv/32bit-fpu.c: Regenerate.
7908         * features/riscv/32bit-fpu.xml: Add register numbers.
7909         * features/riscv/64bit-cpu.xml: Add register numbers.
7910         * features/riscv/64bit-fpu.c: Regenerate.
7911         * features/riscv/64bit-fpu.xml: Add register numbers.
7912
7913 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7914
7915         * NEWS: Mention two argument form of gdb.Value constructor.
7916         * python/py-value.c (convert_buffer_and_type_to_value): New
7917         function.
7918         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7919         Add support for handling an optional second argument.  Call
7920         convert_buffer_and_type_to_value as appropriate.
7921         * python/python-internal.h (Py_buffer_deleter): New struct.
7922         (Py_buffer_up): New typedef.
7923
7924 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7925
7926         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7927         instead of releasing ownership.
7928
7929 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7930
7931         * dwarf2read.c (open_and_init_dwp_file): Call
7932         elf_numsections instead of bfd_count_sections to initialize
7933         dwp_file->num_sections.
7934
7935 2019-02-25  Tom Tromey  <tromey@adacore.com>
7936
7937         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7938
7939 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7940
7941         * gcore.in: Add '--readnever' option when invoking GDB.
7942
7943 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7944
7945         * MAINTAINERS: Update my email address.
7946
7947 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7948
7949         * build-id.c (build_id_to_debug_bfd_1): New function.
7950         (build_id_to_debug_bfd): Look for separate debug file in
7951         sysroot.
7952
7953 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7954
7955         * gdbarch.sh: Update the copyright year range that is placed into
7956         generated files.
7957
7958 2019-02-22  Keith Seitz  <keiths@redhat.com>
7959
7960         PR symtab/23853
7961         * linespec.c (create_sals_line_offset): Search for the default
7962         symtab's filename instead of its fullname.
7963
7964 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7965
7966         * NEWS: Update style defaults.
7967
7968 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7969
7970         * main.c (captured_main_1): Disable styling in batch mode.
7971
7972 2019-02-20  Tom Tromey  <tom@tromey.com>
7973
7974         * symtab.c (symtab_symbol_info): Fix typos.
7975
7976 2019-02-20  Tom Tromey  <tromey@adacore.com>
7977
7978         * findcmd.c (_initialize_mem_search): Use upper case for
7979         metasyntactic variables.
7980
7981 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7982
7983         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7984         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7985
7986 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7987
7988         * top.h (source_file_name): Change to std::string.
7989         * top.c (source_file_name): Likewise.
7990         (command_line_input): Adjust.
7991         * cli/cli-script.c (script_from_file): Adjust.
7992
7993 2019-02-19  Tom Tromey  <tromey@adacore.com>
7994
7995         * ravenscar-thread.c
7996         (ravenscar_thread_target::update_thread_list): Don't call
7997         ada_build_task_list.
7998         * ada-lang.h (ada_build_task_list): Don't declare.
7999         * ada-tasks.c (struct ada_tasks_inferior_data)
8000         <task_list_valid_p>: Now bool.
8001         (read_known_tasks, ada_task_list_changed)
8002         (ada_tasks_invalidate_inferior_data): Update.
8003         (read_known_tasks_array): Return bool.
8004         (read_known_tasks_list): Likewise.
8005         (read_known_tasks): Return void.
8006         (ada_build_task_list): Now static.
8007
8008 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8009
8010         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8011         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8012
8013 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8014
8015         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8016         variant for ada_tasks_pspace_data_handle and
8017         ada_tasks_inferior_data_handle.
8018         (ada_tasks_pspace_data_cleanup): New function.
8019         (ada_tasks_inferior_data_cleanup): New function.
8020
8021 2019-02-17  Tom Tromey  <tom@tromey.com>
8022
8023         * macrotab.h (macro_source_fullname): Return a std::string.
8024         * macrotab.c (macro_include, check_for_redefinition)
8025         (macro_undef, macro_lookup_definition, foreach_macro)
8026         (foreach_macro_in_scope): Update.
8027         (macro_source_fullname): Return a std::string.
8028         * macrocmd.c (show_pp_source_pos): Update.
8029
8030 2019-02-17  Tom Tromey  <tom@tromey.com>
8031
8032         * macrocmd.c (show_pp_source_pos): Style the file names.
8033
8034 2019-02-17  Tom Tromey  <tom@tromey.com>
8035
8036         PR tui/24197:
8037         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8038
8039 2019-02-17  Tom Tromey  <tom@tromey.com>
8040
8041         * ada-lang.c (user_select_syms): Use filtered printing.
8042         * utils.c (wrap_style): New global.
8043         (desired_style): Remove.
8044         (emit_style_escape): Add stream parameter.
8045         (set_output_style, reset_terminal_style, prompt_for_continue):
8046         Update.
8047         (flush_wrap_buffer): Only flush gdb_stdout.
8048         (wrap_here): Set wrap_style.
8049         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8050         treat escape sequences as a character.  Change when wrap buffer is
8051         flushed.
8052         (fputs_styled): Do not set the output style when the default is
8053         requested.
8054         * ui-style.h (struct ui_file_style) <is_default>: New method.
8055         * source.c (print_source_lines_base): Emit escape sequences in one
8056         piece.
8057
8058 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8059
8060         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8061         integers and enumeration types.
8062
8063 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8064
8065         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8066         instead of lookup_symbol_in_language
8067         (do_exact_match): New function.
8068         (ada_get_symbol_name_matcher): Return do_exact_match when
8069         doing a verbatim match.
8070
8071 2019-02-15  Tom Tromey  <tromey@adacore.com>
8072
8073         * ravenscar-thread.c (ravenscar_thread_target::resume)
8074         (ravenscar_thread_target::wait): Special case wildcard requests.
8075
8076 2019-02-15  Tom Tromey  <tromey@adacore.com>
8077
8078         * ravenscar-thread.c (base_ptid): Remove.
8079         (struct ravenscar_thread_target) <close>: New method.
8080         <m_base_ptid>: New member.
8081         <update_inferior_ptid, active_task, task_is_currently_active,
8082         runtime_initialized>: Declare methods.
8083         <ravenscar_thread_target>: Add constructor.
8084         (ravenscar_thread_target::task_is_currently_active)
8085         (ravenscar_thread_target::update_inferior_ptid)
8086         (ravenscar_runtime_initialized): Rename.  Now methods.
8087         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8088         (ravenscar_thread_target::update_thread_list): Update.
8089         (ravenscar_thread_target::active_task): Now method.
8090         (ravenscar_thread_target::store_registers)
8091         (ravenscar_thread_target::prepare_to_store)
8092         (ravenscar_thread_target::prepare_to_store)
8093         (ravenscar_thread_target::mourn_inferior): Update.
8094         (ravenscar_inferior_created): Use "new" to create target.
8095         (ravenscar_thread_target::get_ada_task_ptid): Update.
8096         (_initialize_ravenscar): Don't initialize base_ptid.
8097         (ravenscar_ops): Remove global.
8098
8099 2019-02-15  Tom Tromey  <tromey@adacore.com>
8100
8101         * target.h (push_target): Declare new overload.
8102         * target.c (push_target): New overload, taking an rvalue reference.
8103         * remote.c (remote_target::open_1): Use push_target overload.
8104         * corelow.c (core_target_open): Use push_target overload.
8105
8106 2019-02-15  Tom Tromey  <tromey@adacore.com>
8107
8108         * ravenscar-thread.c (is_ravenscar_task)
8109         (ravenscar_task_is_currently_active): Return bool.
8110         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8111         (_initialize_ravenscar): Remove "(void)".
8112         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8113         Return bool.
8114
8115 2019-02-15  Tom Tromey  <tromey@adacore.com>
8116
8117         * ravenscar-thread.c (ravenscar_runtime_initializer)
8118         (has_ravenscar_runtime, get_running_thread_id)
8119         (ravenscar_thread_target::resume): Fix indentation.
8120
8121 2019-02-15  Tom Tromey  <tromey@adacore.com>
8122
8123         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8124         from ravenscar_arch_ops.
8125         (sparc_ravenscar_ops::fetch_registers)
8126         (sparc_ravenscar_ops::store_registers): Now methods.
8127         (sparc_ravenscar_prepare_to_store): Remove.
8128         (sparc_ravenscar_ops): Redefine.
8129         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8130         methods and destructor.  Remove members.
8131         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8132         (ravenscar_thread_target::store_registers)
8133         (ravenscar_thread_target::prepare_to_store): Update.
8134         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8135         Remove.
8136         (struct ppc_ravenscar_powerpc_ops): Derive from
8137         ravenscar_arch_ops.
8138         (ppc_ravenscar_powerpc_ops::fetch_registers)
8139         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8140         (ppc_ravenscar_powerpc_ops): Redefine.
8141         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8142         (ppc_ravenscar_e500_ops::fetch_registers)
8143         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8144         (ppc_ravenscar_e500_ops): Redefine.
8145         * aarch64-ravenscar-thread.c
8146         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8147         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8148         (aarch64_ravenscar_fetch_registers)
8149         (aarch64_ravenscar_store_registers): Now methods.
8150         (aarch64_ravenscar_ops): Redefine.
8151
8152 2019-02-15  Tom Tromey  <tromey@adacore.com>
8153
8154         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8155         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8156         (ravenscar_thread_target::stopped_by_watchpoint)
8157         (ravenscar_thread_target::stopped_data_address)
8158         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8159
8160 2019-02-15  Tom Tromey  <tromey@adacore.com>
8161
8162         * ravenscar-thread.c: Fix some typos.
8163
8164 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8165             Tom Tromey  <tromey@adacore.com>
8166
8167         * ada-lang.c (ada_exception_sal): Change addr_string to a
8168         std::string.
8169         (create_ada_exception_catchpoint): Update.
8170
8171 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8172             Tom Tromey  <tromey@adacore.com>
8173
8174         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8175         (bp_location_ops): Remove.
8176         (base_breakpoint_allocate_location): Update.
8177         (free_bp_location): Update.
8178         * ada-lang.c (class ada_catchpoint_location)
8179         <ada_catchpoint_location>: Remove ops parameter.
8180         (ada_catchpoint_location_dtor): Remove.
8181         (ada_catchpoint_location_ops): Remove.
8182         (allocate_location_exception): Update.
8183         * breakpoint.h (struct bp_location_ops): Remove.
8184         (class bp_location) <bp_location>: Remove bp_location_ops
8185         parameter.
8186         <~bp_location>: Add destructor.
8187         <ops>: Remove.
8188
8189 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8190             Pedro Alves  <palves@redhat.com>
8191
8192         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8193         'PATH_MAX'.
8194
8195 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8196             Samuel Thibault  <samuel.thibault@gnu.org>
8197             Thomas Schwinge  <thomas@codesourcery.com>
8198
8199         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8200         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8201
8202 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8203
8204         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8205         (check_empty): Use "const char *".
8206
8207         * gnu-nat.c (gnu_nat_target::detach): Instead of
8208         'detach_inferior (pid)' call
8209         'detach_inferior (find_inferior_pid (pid))'.
8210
8211         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8212         'nat/fork-inferior.o'.
8213         * gnu-nat.c: #include "nat/fork-inferior.h".
8214
8215         * gnu-nat.c (gnu_nat_target::detach): Instead of
8216         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8217         * gnu-nat.h: #include "inf-child.h".
8218         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8219         'i386_gnu_nat_target::fetch_registers'.
8220         (gnu_store_registers): Rename/move to
8221         'i386_gnu_nat_target::store_registers'.
8222
8223         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8224         * gnu-nat.h (mach_thread_info): New function.
8225         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8226
8227         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8228
8229 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8230
8231         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8232
8233 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8234
8235         * windows-nat.c (windows_add_thread): Add new parameter
8236         "main_thread_p" with default value set to false.  Update
8237         function documentation as well as all callers.
8238         (windows_delete_thread): Likewise.
8239         (fake_create_process): Update call to windows_add_thread.
8240         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8241         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8242         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8243         call to windows_delete_thread.
8244
8245 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8246
8247         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8248
8249 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8250
8251         * symfile.c (find_separate_debug_file): Use canonical path of
8252         sysroot with child_path instead of gdb_sysroot if it is valid.
8253
8254 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8255
8256         * symfile.c (find_separate_debug_file): Use child_path to
8257         determine if an object file is under a sysroot.
8258
8259 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8260
8261         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8262         unittests/child-path-selftests.c.
8263         * common/pathstuff.c (child_path): New function.
8264         * common/pathstuff.h (child_path): New prototype.
8265         * unittests/child-path-selftests.c: New file.
8266
8267 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8268
8269         * symfile.c (find_separate_debug_file): Look for separate debug
8270         files in debug directories under the sysroot.
8271
8272 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8273
8274         * symtab.h (struct minimal_symbol data_p): New const method.
8275         (struct minimal_symbol text_p): Likewise.
8276         * symtab.c (output_source_filename): Use file name style
8277         to print file name.
8278         (print_symbol_info): Likewise.
8279         (print_msymbol_info): Use address style to print addresses.
8280         Use function name style to print executable text symbols.
8281         (expand_symtab_containing_pc): Use data_p.
8282         (find_pc_sect_compunit_symtab): Likewise.
8283
8284 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8285
8286         * breakpoint.c (describe_other_breakpoints): Use address style
8287         to print addresses.
8288         (say_where): Likewise.
8289
8290 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8291
8292         * ada-typeprint.c (print_func_type): Print function name
8293         style to print function name.
8294         * c-typeprint.c (c_print_type_1): Likewise.
8295
8296 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8297
8298         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8299         for execve.
8300
8301 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8302
8303         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8304         type_stack.
8305
8306 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8307
8308         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8309         TYPE_CODE_REF types.
8310
8311 2019-02-08  Jim Wilson  <jimw@sifive.com>
8312
8313         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8314         (riscv_linux_fregset): New.
8315         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8316
8317 2019-02-07  Tom Tromey  <tom@tromey.com>
8318
8319         * thread.c (thread_cancel_execution_command): Update.
8320         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8321         methods.
8322         (struct thread_fsm_ops): Remove.
8323         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8324         (thread_fsm_should_stop, thread_fsm_return_value)
8325         (thread_fsm_set_finished, thread_fsm_finished_p)
8326         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8327         Don't declare.
8328         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8329         * infrun.c (clear_proceed_status_thread)
8330         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8331         (print_stop_event): Update.
8332         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8333         Add constructor.
8334         (step_command_fsm_ops): Remove.
8335         (new_step_command_fsm): Remove.
8336         (step_1): Update.
8337         (step_command_fsm::should_stop): Rename from
8338         step_command_fsm_should_stop.
8339         (step_command_fsm::clean_up): Rename from
8340         step_command_fsm_clean_up.
8341         (step_command_fsm::do_async_reply_reason): Rename from
8342         step_command_fsm_async_reply_reason.
8343         (struct until_next_fsm): Inherit from thread_fsm.  Add
8344         constructor.
8345         (until_next_fsm_ops): Remove.
8346         (new_until_next_fsm): Remove.
8347         (until_next_fsm::should_stop): Rename from
8348         until_next_fsm_should_stop.
8349         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8350         (until_next_fsm::do_async_reply_reason): Rename from
8351         until_next_fsm_async_reply_reason.
8352         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8353         constructor.  Change type of breakpoint.
8354         (finish_command_fsm_ops): Remove.
8355         (new_finish_command_fsm): Remove.
8356         (finish_command_fsm::should_stop): Rename from
8357         finish_command_fsm_should_stop.
8358         (finish_command_fsm::clean_up): Rename from
8359         finish_command_fsm_clean_up.
8360         (finish_command_fsm::return_value): Rename from
8361         finish_command_fsm_return_value.
8362         (finish_command_fsm::do_async_reply_reason): Rename from
8363         finish_command_fsm_async_reply_reason.
8364         (finish_command): Update.
8365         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8366         Add constructor.
8367         (call_thread_fsm_ops): Remove.
8368         (call_thread_fsm::call_thread_fsm): Rename from
8369         new_call_thread_fsm.
8370         (call_thread_fsm::should_stop): Rename from
8371         call_thread_fsm_should_stop.
8372         (call_thread_fsm::should_notify_stop): Rename from
8373         call_thread_fsm_should_notify_stop.
8374         (run_inferior_call, call_function_by_hand_dummy): Update.
8375         * cli/cli-interp.c (should_print_stop_to_console): Update.
8376         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8377         Add constructor.  Change type of location_breakpoint,
8378         caller_breakpoint.
8379         (until_break_fsm_ops): Remove.
8380         (new_until_break_fsm): Remove.
8381         (until_break_fsm::should_stop): Rename from
8382         until_break_fsm_should_stop.
8383         (until_break_fsm::clean_up): Rename from
8384         until_break_fsm_clean_up.
8385         (until_break_fsm::do_async_reply_reason): Rename from
8386         until_break_fsm_async_reply_reason.
8387         (until_break_command): Update.
8388         * thread-fsm.c: Remove.
8389         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8390
8391 2019-02-07  Tom Tromey  <tom@tromey.com>
8392
8393         * yy-remap.h: Add include guard.
8394         * xtensa-tdep.h: Add include guard.
8395         * xcoffread.h: Rename include guard.
8396         * varobj-iter.h: Add include guard.
8397         * tui/tui.h: Rename include guard.
8398         * tui/tui-winsource.h: Rename include guard.
8399         * tui/tui-wingeneral.h: Rename include guard.
8400         * tui/tui-windata.h: Rename include guard.
8401         * tui/tui-win.h: Rename include guard.
8402         * tui/tui-stack.h: Rename include guard.
8403         * tui/tui-source.h: Rename include guard.
8404         * tui/tui-regs.h: Rename include guard.
8405         * tui/tui-out.h: Rename include guard.
8406         * tui/tui-layout.h: Rename include guard.
8407         * tui/tui-io.h: Rename include guard.
8408         * tui/tui-hooks.h: Rename include guard.
8409         * tui/tui-file.h: Rename include guard.
8410         * tui/tui-disasm.h: Rename include guard.
8411         * tui/tui-data.h: Rename include guard.
8412         * tui/tui-command.h: Rename include guard.
8413         * tic6x-tdep.h: Add include guard.
8414         * target/waitstatus.h: Rename include guard.
8415         * target/wait.h: Rename include guard.
8416         * target/target.h: Rename include guard.
8417         * target/resume.h: Rename include guard.
8418         * target-float.h: Rename include guard.
8419         * stabsread.h: Add include guard.
8420         * rs6000-tdep.h: Add include guard.
8421         * riscv-fbsd-tdep.h: Add include guard.
8422         * regformats/regdef.h: Rename include guard.
8423         * record.h: Rename include guard.
8424         * python/python.h: Rename include guard.
8425         * python/python-internal.h: Rename include guard.
8426         * python/py-stopevent.h: Rename include guard.
8427         * python/py-ref.h: Rename include guard.
8428         * python/py-record.h: Rename include guard.
8429         * python/py-record-full.h: Rename include guard.
8430         * python/py-record-btrace.h: Rename include guard.
8431         * python/py-instruction.h: Rename include guard.
8432         * python/py-events.h: Rename include guard.
8433         * python/py-event.h: Rename include guard.
8434         * procfs.h: Add include guard.
8435         * proc-utils.h: Add include guard.
8436         * p-lang.h: Add include guard.
8437         * or1k-tdep.h: Rename include guard.
8438         * observable.h: Rename include guard.
8439         * nto-tdep.h: Rename include guard.
8440         * nat/x86-linux.h: Rename include guard.
8441         * nat/x86-linux-dregs.h: Rename include guard.
8442         * nat/x86-gcc-cpuid.h: Add include guard.
8443         * nat/x86-dregs.h: Rename include guard.
8444         * nat/x86-cpuid.h: Rename include guard.
8445         * nat/ppc-linux.h: Rename include guard.
8446         * nat/mips-linux-watch.h: Rename include guard.
8447         * nat/linux-waitpid.h: Rename include guard.
8448         * nat/linux-ptrace.h: Rename include guard.
8449         * nat/linux-procfs.h: Rename include guard.
8450         * nat/linux-osdata.h: Rename include guard.
8451         * nat/linux-nat.h: Rename include guard.
8452         * nat/linux-namespaces.h: Rename include guard.
8453         * nat/linux-btrace.h: Rename include guard.
8454         * nat/glibc_thread_db.h: Rename include guard.
8455         * nat/gdb_thread_db.h: Rename include guard.
8456         * nat/gdb_ptrace.h: Rename include guard.
8457         * nat/fork-inferior.h: Rename include guard.
8458         * nat/amd64-linux-siginfo.h: Rename include guard.
8459         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8460         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8461         * nat/aarch64-linux.h: Rename include guard.
8462         * nat/aarch64-linux-hw-point.h: Rename include guard.
8463         * mn10300-tdep.h: Add include guard.
8464         * mips-linux-tdep.h: Add include guard.
8465         * mi/mi-parse.h: Rename include guard.
8466         * mi/mi-out.h: Rename include guard.
8467         * mi/mi-main.h: Rename include guard.
8468         * mi/mi-interp.h: Rename include guard.
8469         * mi/mi-getopt.h: Rename include guard.
8470         * mi/mi-console.h: Rename include guard.
8471         * mi/mi-common.h: Rename include guard.
8472         * mi/mi-cmds.h: Rename include guard.
8473         * mi/mi-cmd-break.h: Rename include guard.
8474         * m2-lang.h: Add include guard.
8475         * location.h: Rename include guard.
8476         * linux-record.h: Rename include guard.
8477         * linux-nat.h: Add include guard.
8478         * linux-fork.h: Add include guard.
8479         * i386-darwin-tdep.h: Rename include guard.
8480         * hppa-linux-offsets.h: Add include guard.
8481         * guile/guile.h: Rename include guard.
8482         * guile/guile-internal.h: Rename include guard.
8483         * gnu-nat.h: Rename include guard.
8484         * gdb-stabs.h: Rename include guard.
8485         * frv-tdep.h: Add include guard.
8486         * f-lang.h: Add include guard.
8487         * event-loop.h: Add include guard.
8488         * darwin-nat.h: Rename include guard.
8489         * cp-abi.h: Rename include guard.
8490         * config/sparc/nm-sol2.h: Rename include guard.
8491         * config/nm-nto.h: Rename include guard.
8492         * config/nm-linux.h: Add include guard.
8493         * config/i386/nm-i386gnu.h: Rename include guard.
8494         * config/djgpp/nl_types.h: Rename include guard.
8495         * config/djgpp/langinfo.h: Rename include guard.
8496         * compile/gcc-cp-plugin.h: Add include guard.
8497         * compile/gcc-c-plugin.h: Add include guard.
8498         * compile/compile.h: Rename include guard.
8499         * compile/compile-object-run.h: Rename include guard.
8500         * compile/compile-object-load.h: Rename include guard.
8501         * compile/compile-internal.h: Rename include guard.
8502         * compile/compile-cplus.h: Rename include guard.
8503         * compile/compile-c.h: Rename include guard.
8504         * common/xml-utils.h: Rename include guard.
8505         * common/x86-xstate.h: Rename include guard.
8506         * common/version.h: Rename include guard.
8507         * common/vec.h: Rename include guard.
8508         * common/tdesc.h: Rename include guard.
8509         * common/selftest.h: Rename include guard.
8510         * common/scoped_restore.h: Rename include guard.
8511         * common/scoped_mmap.h: Rename include guard.
8512         * common/scoped_fd.h: Rename include guard.
8513         * common/safe-iterator.h: Rename include guard.
8514         * common/run-time-clock.h: Rename include guard.
8515         * common/refcounted-object.h: Rename include guard.
8516         * common/queue.h: Rename include guard.
8517         * common/ptid.h: Rename include guard.
8518         * common/print-utils.h: Rename include guard.
8519         * common/preprocessor.h: Rename include guard.
8520         * common/pathstuff.h: Rename include guard.
8521         * common/observable.h: Rename include guard.
8522         * common/netstuff.h: Rename include guard.
8523         * common/job-control.h: Rename include guard.
8524         * common/host-defs.h: Rename include guard.
8525         * common/gdb_wait.h: Rename include guard.
8526         * common/gdb_vecs.h: Rename include guard.
8527         * common/gdb_unlinker.h: Rename include guard.
8528         * common/gdb_unique_ptr.h: Rename include guard.
8529         * common/gdb_tilde_expand.h: Rename include guard.
8530         * common/gdb_sys_time.h: Rename include guard.
8531         * common/gdb_string_view.h: Rename include guard.
8532         * common/gdb_splay_tree.h: Rename include guard.
8533         * common/gdb_setjmp.h: Rename include guard.
8534         * common/gdb_ref_ptr.h: Rename include guard.
8535         * common/gdb_optional.h: Rename include guard.
8536         * common/gdb_locale.h: Rename include guard.
8537         * common/gdb_assert.h: Rename include guard.
8538         * common/filtered-iterator.h: Rename include guard.
8539         * common/filestuff.h: Rename include guard.
8540         * common/fileio.h: Rename include guard.
8541         * common/environ.h: Rename include guard.
8542         * common/common-utils.h: Rename include guard.
8543         * common/common-types.h: Rename include guard.
8544         * common/common-regcache.h: Rename include guard.
8545         * common/common-inferior.h: Rename include guard.
8546         * common/common-gdbthread.h: Rename include guard.
8547         * common/common-exceptions.h: Rename include guard.
8548         * common/common-defs.h: Rename include guard.
8549         * common/common-debug.h: Rename include guard.
8550         * common/cleanups.h: Rename include guard.
8551         * common/buffer.h: Rename include guard.
8552         * common/btrace-common.h: Rename include guard.
8553         * common/break-common.h: Rename include guard.
8554         * cli/cli-utils.h: Rename include guard.
8555         * cli/cli-style.h: Rename include guard.
8556         * cli/cli-setshow.h: Rename include guard.
8557         * cli/cli-script.h: Rename include guard.
8558         * cli/cli-interp.h: Rename include guard.
8559         * cli/cli-decode.h: Rename include guard.
8560         * cli/cli-cmds.h: Rename include guard.
8561         * charset-list.h: Add include guard.
8562         * buildsym-legacy.h: Rename include guard.
8563         * bfin-tdep.h: Add include guard.
8564         * ax.h: Rename include guard.
8565         * arm-linux-tdep.h: Add include guard.
8566         * arm-fbsd-tdep.h: Add include guard.
8567         * arch/xtensa.h: Rename include guard.
8568         * arch/tic6x.h: Add include guard.
8569         * arch/i386.h: Add include guard.
8570         * arch/arm.h: Rename include guard.
8571         * arch/arm-linux.h: Rename include guard.
8572         * arch/arm-get-next-pcs.h: Rename include guard.
8573         * arch/amd64.h: Add include guard.
8574         * arch/aarch64-insn.h: Rename include guard.
8575         * arch-utils.h: Rename include guard.
8576         * annotate.h: Add include guard.
8577         * amd64-darwin-tdep.h: Rename include guard.
8578         * aarch64-linux-tdep.h: Add include guard.
8579         * aarch64-fbsd-tdep.h: Add include guard.
8580         * aarch32-linux-nat.h: Add include guard.
8581
8582 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8583
8584         * macrotab.c (macro_define_internal): New function that
8585         factorizes macro_define_object_internal and macro_define_function
8586         code.
8587         (macro_define_object_internal): Use macro_define_internal.
8588         (macro_define_function): Likewise.
8589
8590 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8591
8592         * macrocmd.c (extract_identifier): Return
8593         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8594         callers.
8595
8596 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8597
8598         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8599
8600 2019-02-05  Tom Tromey  <tom@tromey.com>
8601
8602         * target.c (target_stack::unpush): Move assertion earlier.
8603
8604 2019-01-30  Tom Tromey  <tom@tromey.com>
8605
8606         PR python/23615:
8607         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8608         (gdbpy_parse_and_eval): Likewise.
8609         * python/python-internal.h (gdbpy_allow_threads): New class.
8610
8611 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8612
8613         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8614         (aarch64_fbsd_fpregmap): Move earlier.
8615         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8616         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8617         instead of individual calls to trad_frame_set_reg_addr.
8618         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8619         earlier.
8620         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8621         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8622         instead of individual calls to trad_frame_set_reg_addr.
8623
8624 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8625
8626         * CONTRIBUTE: Replace contribution list with wiki link.
8627
8628 2019-01-25  Tom Tromey  <tom@tromey.com>
8629
8630         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8631
8632 2019-01-25  Tom Tromey  <tom@tromey.com>
8633
8634         * xtensa-linux-nat.c: Fix common/ includes.
8635         * xml-support.h: Fix common/ includes.
8636         * xml-support.c: Fix common/ includes.
8637         * x86-linux-nat.c: Fix common/ includes.
8638         * windows-nat.c: Fix common/ includes.
8639         * varobj.h: Fix common/ includes.
8640         * varobj.c: Fix common/ includes.
8641         * value.c: Fix common/ includes.
8642         * valops.c: Fix common/ includes.
8643         * utils.c: Fix common/ includes.
8644         * unittests/xml-utils-selftests.c: Fix common/ includes.
8645         * unittests/utils-selftests.c: Fix common/ includes.
8646         * unittests/unpack-selftests.c: Fix common/ includes.
8647         * unittests/tracepoint-selftests.c: Fix common/ includes.
8648         * unittests/style-selftests.c: Fix common/ includes.
8649         * unittests/string_view-selftests.c: Fix common/ includes.
8650         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8651         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8652         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8653         * unittests/rsp-low-selftests.c: Fix common/ includes.
8654         * unittests/parse-connection-spec-selftests.c: Fix common/
8655         includes.
8656         * unittests/optional-selftests.c: Fix common/ includes.
8657         * unittests/offset-type-selftests.c: Fix common/ includes.
8658         * unittests/observable-selftests.c: Fix common/ includes.
8659         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8660         * unittests/memrange-selftests.c: Fix common/ includes.
8661         * unittests/memory-map-selftests.c: Fix common/ includes.
8662         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8663         * unittests/function-view-selftests.c: Fix common/ includes.
8664         * unittests/environ-selftests.c: Fix common/ includes.
8665         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8666         * unittests/common-utils-selftests.c: Fix common/ includes.
8667         * unittests/cli-utils-selftests.c: Fix common/ includes.
8668         * unittests/array-view-selftests.c: Fix common/ includes.
8669         * ui-file.c: Fix common/ includes.
8670         * tui/tui-io.c: Fix common/ includes.
8671         * tracepoint.h: Fix common/ includes.
8672         * tracepoint.c: Fix common/ includes.
8673         * tracefile-tfile.c: Fix common/ includes.
8674         * top.h: Fix common/ includes.
8675         * top.c: Fix common/ includes.
8676         * thread.c: Fix common/ includes.
8677         * target/waitstatus.h: Fix common/ includes.
8678         * target/waitstatus.c: Fix common/ includes.
8679         * target.h: Fix common/ includes.
8680         * target.c: Fix common/ includes.
8681         * target-memory.c: Fix common/ includes.
8682         * target-descriptions.c: Fix common/ includes.
8683         * symtab.h: Fix common/ includes.
8684         * symfile.c: Fix common/ includes.
8685         * stap-probe.c: Fix common/ includes.
8686         * spu-linux-nat.c: Fix common/ includes.
8687         * sparc-nat.c: Fix common/ includes.
8688         * source.c: Fix common/ includes.
8689         * solib.c: Fix common/ includes.
8690         * solib-target.c: Fix common/ includes.
8691         * ser-unix.c: Fix common/ includes.
8692         * ser-tcp.c: Fix common/ includes.
8693         * ser-pipe.c: Fix common/ includes.
8694         * ser-base.c: Fix common/ includes.
8695         * selftest-arch.c: Fix common/ includes.
8696         * s12z-tdep.c: Fix common/ includes.
8697         * rust-exp.y: Fix common/ includes.
8698         * rs6000-aix-tdep.c: Fix common/ includes.
8699         * riscv-tdep.c: Fix common/ includes.
8700         * remote.c: Fix common/ includes.
8701         * remote-notif.h: Fix common/ includes.
8702         * remote-fileio.h: Fix common/ includes.
8703         * remote-fileio.c: Fix common/ includes.
8704         * regcache.h: Fix common/ includes.
8705         * regcache.c: Fix common/ includes.
8706         * record-btrace.c: Fix common/ includes.
8707         * python/python.c: Fix common/ includes.
8708         * python/py-type.c: Fix common/ includes.
8709         * python/py-inferior.c: Fix common/ includes.
8710         * progspace.h: Fix common/ includes.
8711         * producer.c: Fix common/ includes.
8712         * procfs.c: Fix common/ includes.
8713         * proc-api.c: Fix common/ includes.
8714         * printcmd.c: Fix common/ includes.
8715         * ppc-linux-nat.c: Fix common/ includes.
8716         * parser-defs.h: Fix common/ includes.
8717         * osdata.c: Fix common/ includes.
8718         * obsd-nat.c: Fix common/ includes.
8719         * nat/x86-linux.c: Fix common/ includes.
8720         * nat/x86-linux-dregs.c: Fix common/ includes.
8721         * nat/x86-dregs.h: Fix common/ includes.
8722         * nat/x86-dregs.c: Fix common/ includes.
8723         * nat/ppc-linux.c: Fix common/ includes.
8724         * nat/mips-linux-watch.h: Fix common/ includes.
8725         * nat/mips-linux-watch.c: Fix common/ includes.
8726         * nat/linux-waitpid.c: Fix common/ includes.
8727         * nat/linux-ptrace.h: Fix common/ includes.
8728         * nat/linux-ptrace.c: Fix common/ includes.
8729         * nat/linux-procfs.c: Fix common/ includes.
8730         * nat/linux-personality.c: Fix common/ includes.
8731         * nat/linux-osdata.c: Fix common/ includes.
8732         * nat/linux-namespaces.c: Fix common/ includes.
8733         * nat/linux-btrace.h: Fix common/ includes.
8734         * nat/linux-btrace.c: Fix common/ includes.
8735         * nat/fork-inferior.c: Fix common/ includes.
8736         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8737         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8738         * nat/aarch64-linux.c: Fix common/ includes.
8739         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8740         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8741         * namespace.h: Fix common/ includes.
8742         * mips-linux-tdep.c: Fix common/ includes.
8743         * minsyms.c: Fix common/ includes.
8744         * mi/mi-parse.h: Fix common/ includes.
8745         * mi/mi-main.c: Fix common/ includes.
8746         * mi/mi-cmd-env.c: Fix common/ includes.
8747         * memrange.h: Fix common/ includes.
8748         * memattr.c: Fix common/ includes.
8749         * maint.h: Fix common/ includes.
8750         * maint.c: Fix common/ includes.
8751         * main.c: Fix common/ includes.
8752         * machoread.c: Fix common/ includes.
8753         * location.c: Fix common/ includes.
8754         * linux-thread-db.c: Fix common/ includes.
8755         * linux-nat.c: Fix common/ includes.
8756         * linux-fork.c: Fix common/ includes.
8757         * inline-frame.c: Fix common/ includes.
8758         * infrun.c: Fix common/ includes.
8759         * inflow.c: Fix common/ includes.
8760         * inferior.h: Fix common/ includes.
8761         * inferior.c: Fix common/ includes.
8762         * infcmd.c: Fix common/ includes.
8763         * inf-ptrace.c: Fix common/ includes.
8764         * inf-child.c: Fix common/ includes.
8765         * ia64-linux-nat.c: Fix common/ includes.
8766         * i387-tdep.c: Fix common/ includes.
8767         * i386-tdep.c: Fix common/ includes.
8768         * i386-linux-tdep.c: Fix common/ includes.
8769         * i386-linux-nat.c: Fix common/ includes.
8770         * i386-go32-tdep.c: Fix common/ includes.
8771         * i386-fbsd-tdep.c: Fix common/ includes.
8772         * i386-fbsd-nat.c: Fix common/ includes.
8773         * guile/scm-type.c: Fix common/ includes.
8774         * guile/guile.c: Fix common/ includes.
8775         * go32-nat.c: Fix common/ includes.
8776         * gnu-nat.c: Fix common/ includes.
8777         * gdbthread.h: Fix common/ includes.
8778         * gdbarch-selftests.c: Fix common/ includes.
8779         * gdb_usleep.c: Fix common/ includes.
8780         * gdb_select.h: Fix common/ includes.
8781         * gdb_bfd.c: Fix common/ includes.
8782         * gcore.c: Fix common/ includes.
8783         * fork-child.c: Fix common/ includes.
8784         * findvar.c: Fix common/ includes.
8785         * fbsd-nat.c: Fix common/ includes.
8786         * event-top.c: Fix common/ includes.
8787         * event-loop.c: Fix common/ includes.
8788         * dwarf2read.c: Fix common/ includes.
8789         * dwarf2loc.c: Fix common/ includes.
8790         * dwarf2-frame.c: Fix common/ includes.
8791         * dwarf-index-cache.c: Fix common/ includes.
8792         * dtrace-probe.c: Fix common/ includes.
8793         * disasm-selftests.c: Fix common/ includes.
8794         * defs.h: Fix common/ includes.
8795         * csky-tdep.c: Fix common/ includes.
8796         * cp-valprint.c: Fix common/ includes.
8797         * cp-support.h: Fix common/ includes.
8798         * cp-support.c: Fix common/ includes.
8799         * corelow.c: Fix common/ includes.
8800         * completer.h: Fix common/ includes.
8801         * completer.c: Fix common/ includes.
8802         * compile/compile.c: Fix common/ includes.
8803         * compile/compile-loc2c.c: Fix common/ includes.
8804         * compile/compile-cplus-types.c: Fix common/ includes.
8805         * compile/compile-cplus-symbols.c: Fix common/ includes.
8806         * command.h: Fix common/ includes.
8807         * cli/cli-dump.c: Fix common/ includes.
8808         * cli/cli-cmds.c: Fix common/ includes.
8809         * charset.c: Fix common/ includes.
8810         * build-id.c: Fix common/ includes.
8811         * btrace.h: Fix common/ includes.
8812         * btrace.c: Fix common/ includes.
8813         * breakpoint.h: Fix common/ includes.
8814         * breakpoint.c: Fix common/ includes.
8815         * ax.h:
8816         (enum agent_op): Fix common/ includes.
8817         * ax-general.c (struct aop_map): Fix common/ includes.
8818         * ax-gdb.c: Fix common/ includes.
8819         * auxv.c: Fix common/ includes.
8820         * auto-load.c: Fix common/ includes.
8821         * arm-tdep.c: Fix common/ includes.
8822         * arch/riscv.c: Fix common/ includes.
8823         * arch/ppc-linux-common.c: Fix common/ includes.
8824         * arch/i386.c: Fix common/ includes.
8825         * arch/arm.c: Fix common/ includes.
8826         * arch/arm-linux.c: Fix common/ includes.
8827         * arch/arm-get-next-pcs.c: Fix common/ includes.
8828         * arch/amd64.c: Fix common/ includes.
8829         * arch/aarch64.c: Fix common/ includes.
8830         * arch/aarch64-insn.c: Fix common/ includes.
8831         * arch-utils.c: Fix common/ includes.
8832         * amd64-windows-tdep.c: Fix common/ includes.
8833         * amd64-tdep.c: Fix common/ includes.
8834         * amd64-sol2-tdep.c: Fix common/ includes.
8835         * amd64-obsd-tdep.c: Fix common/ includes.
8836         * amd64-nbsd-tdep.c: Fix common/ includes.
8837         * amd64-linux-tdep.c: Fix common/ includes.
8838         * amd64-linux-nat.c: Fix common/ includes.
8839         * amd64-fbsd-tdep.c: Fix common/ includes.
8840         * amd64-fbsd-nat.c: Fix common/ includes.
8841         * amd64-dicos-tdep.c: Fix common/ includes.
8842         * amd64-darwin-tdep.c: Fix common/ includes.
8843         * agent.c: Fix common/ includes.
8844         * ada-lang.h: Fix common/ includes.
8845         * ada-lang.c: Fix common/ includes.
8846         * aarch64-tdep.c: Fix common/ includes.
8847
8848 2019-01-25  Tom Tromey  <tom@tromey.com>
8849
8850         * common/create-version.sh: Use common/version.h.
8851
8852 2019-01-24  Pedro Alves  <palves@redhat.com>
8853
8854         * infrun.c (signal_stop, signal_print, signal_program)
8855         (signal_catch, signal_pass): Now arrays instead of pointers.
8856         (update_signals_program_target, do_target_resume)
8857         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8858         * linux-nat.c (linux_nat_target::pass_signals)
8859         (linux_nat_target::create_inferior, linux_nat_target::attach):
8860         Adjust.
8861         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8862         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8863         * procfs.c (procfs_target::pass_signals): Adjust.
8864         * record-full.c (record_full_target::resume): Adjust.
8865         * remote.c (remote_target::pass_signals)
8866         (remote_target::program_signals): Adjust.
8867         * target-debug.h (target_debug_print_signals): Now takes a
8868         gdb::array_view as parameter.  Adjust.
8869         * target.h (target_ops) <pass_signals, program_signals>: Replace
8870         pointer and length parameters with gdb::array_view.
8871         (target_pass_signals, target_program_signals): Likewise.
8872         * target-delegates.c: Regenerate.
8873
8874 2019-01-24  Pedro Alves  <palves@redhat.com>
8875
8876         * common/forward-scope-exit.h
8877         (forward_scope_exit::forward_scope_exit): Pass arguments to
8878         m_bind_function directly, instead of creating a std::bind and
8879         copying that.
8880
8881 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8882
8883         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8884         for static members.
8885         (pass_in_v_vfp_candidate): Likewise.
8886
8887 2019-01-23  Tom Tromey  <tom@tromey.com>
8888             Pedro Alves  <palves@redhat.com>
8889
8890         * regcache.c (class regcache_invalidator): Remove.
8891         (regcache::raw_write): Use make_scope_exit.
8892
8893 2019-01-23  Tom Tromey  <tom@tromey.com>
8894
8895         * ui-out.h (class ui_out_emit_type): Update comment.
8896
8897 2019-01-23  Tom Tromey  <tom@tromey.com>
8898
8899         * infrun.c (fetch_inferior_event): Update comment.
8900
8901 2019-01-23  Tom Tromey  <tom@tromey.com>
8902             Pedro Alves  <palves@redhat.com>
8903
8904         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8905         parameter.
8906         (fetch_inferior_event): Use SCOPE_EXIT.
8907
8908
8909 2019-01-23  Tom Tromey  <tom@tromey.com>
8910             Pedro Alves  <palves@redhat.com>
8911
8912         * infrun.c (disable_thread_events): Delete.
8913         (stop_all_threads): Use SCOPE_EXIT.
8914
8915 2019-01-23  Tom Tromey  <tom@tromey.com>
8916             Pedro Alves  <palves@redhat.com>
8917
8918         * symfile.c: Include forward-scope-exit.h.
8919         (clear_symtab_users_cleanup): Replace forward declaration with
8920         a FORWARD_SCOPE_EXIT.
8921         (syms_from_objfile_1): Use the forward_scope_exit and
8922         gdb::optional instead of cleanup_function.
8923         (reread_symbols): Use the forward_scope_exit instead of
8924         cleanup_function.
8925         (clear_symtab_users_cleanup): Remove function.
8926
8927 2019-01-23  Tom Tromey  <tom@tromey.com>
8928             Pedro Alves  <palves@redhat.com>
8929
8930         * linux-nat.c: Include scope-exit.h.
8931         (cleanup_target_stop): Remove.
8932         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8933         SCOPE_EXIT.
8934
8935 2019-01-23  Tom Tromey  <tom@tromey.com>
8936             Pedro Alves  <palves@redhat.com>
8937
8938         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8939         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8940
8941 2019-01-23  Tom Tromey  <tom@tromey.com>
8942             Andrew Burgess  <andrew.burgess@embecosm.com>
8943             Pedro Alves  <palves@redhat.com>
8944
8945         * infrun.c (fetch_inferior_event): Use scope_exit.
8946         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8947         * top.c (execute_command): Use scope_exit.
8948         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8949         * utils.c (do_bpstat_clear_actions_cleanup)
8950         (make_bpstat_clear_actions_cleanup): Remove.
8951
8952 2019-01-23  Tom Tromey  <tom@tromey.com>
8953             Pedro Alves  <palves@redhat.com>
8954
8955         * infrun.c: Include "common/scope-exit.h"
8956         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8957         (wait_for_inferior): Use SCOPE_EXIT.
8958         (fetch_inferior_event): Use scope_exit.
8959
8960 2019-01-23  Tom Tromey  <tom@tromey.com>
8961             Pedro Alves  <palves@redhat.com>
8962
8963         * breakpoint.c (create_breakpoint): Remove cleanup.
8964
8965 2019-01-23  Tom Tromey  <tom@tromey.com>
8966             Andrew Burgess  <andrew.burgess@embecosm.com>
8967             Pedro Alves  <palves@redhat.com>
8968
8969 2019-01-23  Pedro Alves  <palves@redhat.com>
8970
8971         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8972
8973 2019-01-23  Pedro Alves  <palves@redhat.com>
8974             Andrew Burgess  <andrew.burgess@embecosm.com>
8975
8976         * gdbthread.h: Include "common/forward-scope-exit.h".
8977         (scoped_finish_thread_state): Redefine custom class in terms of
8978         forward_scope_exit.
8979
8980 2019-01-23  Pedro Alves  <palves@redhat.com>
8981             Andrew Burgess  <andrew.burgess@embecosm.com>
8982
8983         * common/forward-scope-exit.h: New file.
8984
8985 2019-01-23  Pedro Alves  <palves@redhat.com>
8986             Andrew Burgess  <andrew.burgess@embecosm.com>
8987             Tom Tromey  <tom@tromey.com>
8988
8989         * common/scope-exit.h: New file.
8990
8991 2019-01-23  Pedro Alves  <palves@redhat.com>
8992
8993         * common/preprocessor.h (ESC): Rename to ...
8994         (ESC_PARENS): ... this.
8995         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8996         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8997
8998 2019-01-23  Tom Tromey  <tom@tromey.com>
8999
9000         * language.h (class scoped_switch_to_sym_language_if_auto):
9001         Initialize m_lang in both cases.
9002
9003 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9004
9005         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9006         with XCNEW.
9007
9008 2019-01-22  Tom Tromey  <tom@tromey.com>
9009
9010         * corelow.c: Do not include sys/file.h.
9011
9012 2019-01-22  Tom Tromey  <tom@tromey.com>
9013
9014         * tui/tui-wingeneral.h: Include gdb_curses.h.
9015
9016 2019-01-22  Tom Tromey  <tom@tromey.com>
9017
9018         * source-cache.h (class source_cache) <get_source_lines,
9019         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9020
9021 2019-01-22  Tom Tromey  <tom@tromey.com>
9022
9023         * remote-fileio.h (struct remote_target): Declare.
9024
9025 2019-01-22  Tom Tromey  <tom@tromey.com>
9026
9027         * python/py-arch.c: Do not include py-ref.h.
9028         * python/py-bpevent.c: Do not include py-ref.h.
9029         * python/py-cmd.c: Do not include py-ref.h.
9030         * python/py-continueevent.c: Do not include py-ref.h.
9031         * python/py-event.h: Do not include py-ref.h.
9032         * python/py-evtregistry.c: Do not include py-ref.h.
9033         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9034         * python/py-frame.c: Do not include py-ref.h.
9035         * python/py-framefilter.c: Do not include py-ref.h.
9036         * python/py-function.c: Do not include py-ref.h.
9037         * python/py-infevents.c: Do not include py-ref.h.
9038         * python/py-linetable.c: Do not include py-ref.h.
9039         * python/py-objfile.c: Do not include py-ref.h.
9040         * python/py-param.c: Do not include py-ref.h.
9041         * python/py-prettyprint.c: Do not include py-ref.h.
9042         * python/py-progspace.c: Do not include py-ref.h.
9043         * python/py-symbol.c: Do not include py-ref.h.
9044         * python/py-symtab.c: Do not include py-ref.h.
9045         * python/py-type.c: Do not include py-ref.h.
9046         * python/py-unwind.c: Do not include py-ref.h.
9047         * python/py-utils.c: Do not include py-ref.h.
9048         * python/py-value.c: Do not include py-ref.h.
9049         * python/py-varobj.c: Do not include py-ref.h.
9050         * python/py-xmethods.c: Do not include py-ref.h.
9051         * python/python.c: Do not include py-ref.h.
9052         * varobj.c: Do not include py-ref.h.
9053
9054 2019-01-22  Tom Tromey  <tom@tromey.com>
9055
9056         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9057         keyword for bcache.
9058
9059 2019-01-22  Tom Tromey  <tom@tromey.com>
9060
9061         * compile/compile-cplus-types.c: Remove a comment by #include.
9062
9063 2019-01-22  Tom Tromey  <tom@tromey.com>
9064
9065         * compile/gcc-c-plugin.h: Include compile-internal.h.
9066
9067 2019-01-22  Tom Tromey  <tom@tromey.com>
9068
9069         * stabsread.c (EXTERN): Do not define.
9070         (symnum, next_symbol_text_func, processing_gcc_compilation)
9071         (within_function, global_sym_chain, global_stabs)
9072         (previous_stab_code, this_object_header_files)
9073         (n_this_object_header_files)
9074         (n_allocated_this_object_header_files): Define.
9075         * stabsread.h (EXTERN): Never define.  Use "extern".
9076
9077 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9078
9079         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9080         history_value.
9081
9082 2019-01-21  Tom Tromey  <tom@tromey.com>
9083
9084         * ui-out.c: Fix includes.
9085         * tui/tui-source.c: Fix includes.
9086         * target.c: Fix includes.
9087         * remote.c: Fix includes.
9088         * regcache.c: Fix includes.
9089         * python/py-block.c: Fix includes.
9090         * printcmd.c: Fix includes.
9091         * or1k-tdep.c: Fix includes.
9092         * mi/mi-main.c: Fix includes.
9093         * m32r-tdep.c: Fix includes.
9094         * csky-tdep.c: Fix includes.
9095         * compile/compile-cplus-types.c: Fix includes.
9096         * cli/cli-interp.c: Fix includes.
9097
9098 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9099
9100         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9101         for padding.
9102
9103 2019-01-16  Tom Tromey  <tom@tromey.com>
9104
9105         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9106         earlier.
9107         (struct objfile) <msymbols_range>: Move from top level.
9108         <msymbols>: New method.
9109         (class objfile_msymbols): Remove.
9110         * symtab.c (default_collect_symbol_completion_matches_break_on):
9111         Update.
9112         * symmisc.c (dump_msymbols): Update.
9113         * stabsread.c (scan_file_globals): Update.
9114         * objc-lang.c (info_selectors_command, info_classes_command)
9115         (find_methods): Update.
9116         * minsyms.c (find_solib_trampoline_target): Update.
9117         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9118         * coffread.c (coff_symfile_read): Update.
9119         * ada-lang.c (ada_lookup_simple_minsym)
9120         (ada_collect_symbol_completion_matches): Update.
9121
9122 2019-01-16  Tom Tromey  <tom@tromey.com>
9123
9124         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9125         type.  Remove no-argument constructor.
9126         <iterator::operator++>: Simplify.
9127         <begin>: Update.
9128         <end>: Use minimal_symbol_count.
9129
9130 2019-01-16  Tom Tromey  <tom@tromey.com>
9131
9132         * objfiles.h (struct objfile) <psymtabs>: New method.
9133         (class objfile_psymtabs): Remove.
9134         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9135         typedef.
9136         <range>: New method.
9137         (require_partial_symbols): Change return type.
9138         * psymtab.c (require_partial_symbols)
9139         (psym_expand_symtabs_matching): Update.
9140         * mdebugread.c (parse_partial_symbols): Update.
9141         * dbxread.c (dbx_end_psymtab): Update.
9142
9143 2019-01-15  Tom Tromey  <tom@tromey.com>
9144
9145         * symtab.c (lookup_objfile_from_block)
9146         (lookup_symbol_in_objfile_symtabs)
9147         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9148         (find_line_symtab, info_sources_command)
9149         (default_collect_symbol_completion_matches_break_on)
9150         (make_source_files_completion_list): Update.
9151         * symmisc.c (print_objfile_statistics, dump_objfile)
9152         (maintenance_print_symbols, maintenance_info_symtabs)
9153         (maintenance_check_symtabs, maintenance_info_line_tables):
9154         Update.
9155         * source.c (select_source_symtab)
9156         (forget_cached_source_info_for_objfile): Update.
9157         * objfiles.h (class objfile_compunits): Remove.
9158         (struct objfile) <compunits_range>: New typedef.
9159         (compunits): New method.
9160         * objfiles.c (objfile_relocate1): Update.
9161         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9162         * maint.c (count_symtabs_and_blocks): Update.
9163         * linespec.c (iterate_over_all_matching_symtabs): Update.
9164         * cp-support.c (add_symbol_overload_list_qualified): Update.
9165         * coffread.c (coff_symtab_read): Update.
9166         * ada-lang.c (add_nonlocal_symbols)
9167         (ada_collect_symbol_completion_matches)
9168         (ada_add_global_exceptions): Update.
9169
9170 2019-01-15  Tom Tromey  <tom@tromey.com>
9171
9172         * progspace.h (program_space) <objfiles_safe_range>: New
9173         typedef.
9174         <objfiles_safe>: New method.
9175         * objfiles.h (class all_objfiles_safe): Remove.
9176         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9177         * jit.c (jit_inferior_exit_hook): Update.
9178
9179 2019-01-17  Tom Tromey  <tom@tromey.com>
9180
9181         * progspace.h (program_space) <objfiles_range>: New typedef.
9182         <objfiles>: New method.
9183         <objfiles_head>: Rename from objfiles.
9184         (object_files): Update.
9185         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9186         * guile/scm-pretty-print.c
9187         (ppscm_find_pretty_printer_from_objfiles): Update.
9188         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9189         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9190         Update.
9191         * python/py-progspace.c (pspy_get_objfiles): Update.
9192         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9193         Update.
9194         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9195         (objfpy_lookup_objfile_by_build_id): Update.
9196         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9197         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9198         Update.
9199         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9200         (expand_symtab_containing_pc, lookup_objfile_from_block)
9201         (lookup_static_symbol, basic_lookup_transparent_type)
9202         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9203         (find_line_symtab, info_sources_command)
9204         (default_collect_symbol_completion_matches_break_on)
9205         (make_source_files_completion_list, find_main_name): Update.
9206         * symmisc.c (print_symbol_bcache_statistics)
9207         (print_objfile_statistics, maintenance_print_symbols)
9208         (maintenance_print_msymbols, maintenance_print_objfiles)
9209         (maintenance_info_symtabs, maintenance_check_symtabs)
9210         (maintenance_expand_symtabs, maintenance_info_line_tables):
9211         Update.
9212         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9213         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9214         (map_overlay_command, unmap_overlay_command)
9215         (simple_overlay_update, expand_symtabs_matching)
9216         (map_symbol_filenames): Update.
9217         * symfile-debug.c (set_debug_symfile): Update.
9218         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9219         Update.
9220         * source.c (select_source_symtab, forget_cached_source_info):
9221         Update.
9222         * solib.c (solib_read_symbols): Update.
9223         * solib-spu.c (append_ocl_sos): Update.
9224         * psymtab.c (maintenance_print_psymbols)
9225         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9226         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9227         * printcmd.c (info_symbol_command): Update.
9228         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9229         Update.
9230         * objfiles.h (class all_objfiles): Remove.
9231         * objfiles.c (have_partial_symbols, have_full_symbols)
9232         (have_minimal_symbols, qsort_cmp, update_section_map)
9233         (shared_objfile_contains_address_p)
9234         (default_iterate_over_objfiles_in_search_order): Update.
9235         * objc-lang.c (info_selectors_command, info_classes_command)
9236         (find_methods): Update.
9237         * minsyms.c (find_solib_trampoline_target): Update.
9238         * maint.c (maintenance_info_sections)
9239         (maintenance_translate_address, count_symtabs_and_blocks):
9240         Update.
9241         * main.c (captured_main_1): Update.
9242         * linux-thread-db.c (try_thread_db_load_from_pdir)
9243         (has_libpthread): Update.
9244         * linespec.c (iterate_over_all_matching_symtabs)
9245         (search_minsyms_for_name): Update.
9246         * jit.c (jit_find_objf_with_entry_addr): Update.
9247         * hppa-tdep.c (find_unwind_entry)
9248         (hppa_lookup_stub_minimal_symbol): Update.
9249         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9250         Update.
9251         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9252         (elf_gnu_ifunc_resolve_by_got): Update.
9253         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9254         * dwarf-index-write.c (save_gdb_index_command): Update.
9255         * cp-support.c (add_symbol_overload_list_qualified): Update.
9256         * breakpoint.c (create_overlay_event_breakpoint)
9257         (create_longjmp_master_breakpoint)
9258         (create_std_terminate_master_breakpoint)
9259         (create_exception_master_breakpoint): Update.
9260         * blockframe.c (find_pc_partial_function): Update.
9261         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9262         (ada_collect_symbol_completion_matches)
9263         (ada_add_global_exceptions): Update.
9264
9265 2019-01-17  Tom Tromey  <tom@tromey.com>
9266
9267         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9268         declare VEC.
9269         (solib_target_parse_libraries): Change return type.
9270         (library_list_start_segment, library_list_start_section)
9271         (library_list_end_library, library_list_start_library); Update.
9272         (solib_target_free_library_list): Remove.
9273         (solib_target_parse_libraries): Remove cleanup.  Change return
9274         type.
9275         (solib_target_current_sos): Update.
9276
9277 2019-01-17  Tom Tromey  <tromey@bapiya>
9278
9279         * valprint.c: Replace "the the" with "the".
9280         * symtab.c: Replace "the the" with "the".
9281         * solib.c: Replace "the the" with "the".
9282         * solib-dsbt.c: Replace "the the" with "the".
9283         * linespec.c: Replace "the the" with "the".
9284         * dwarf2loc.h: Replace "the the" with "the".
9285         * amd64-windows-tdep.c: Replace "the the" with "the".
9286         * aarch64-tdep.c: Replace "the the" with "the".
9287
9288 2019-01-16  Keith Seitz  <keiths@redhat.com>
9289
9290         PR gdb/23773
9291         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9292         <builder>: Rename to ..
9293         <m_builder>: ... this and make private.
9294         (dwarf2_cu::get_builder): New method.  Change all users of
9295         `builder' to use this method.
9296         (dwarf2_start_symtab): Move to ...
9297         (dwarf2_cu::start_symtab): ... here.  Update all callers
9298         (setup_type_unit_groups): Move to ...
9299         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9300         callers.
9301         (dwarf2_cu::reset_builder): New method.
9302         (process_full_compunit, process_full_type_unit): Use
9303         dwarf2_cu::reset_builder.
9304         (follow_die_offset): Record the ancestor CU if it is different
9305         from the followed DIE's CU.
9306         (follow_die_sig_1): Likewise.
9307
9308 2019-01-15  Tom Tromey  <tom@tromey.com>
9309
9310         * remote.c (class remote_state) <buf>: Now a char_vector.
9311         <buf_size>: Remove.
9312         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9313         parameter.
9314         (remote_target::getpkt_or_notif_sane_1)
9315         (remote_target::getpkt_sane)
9316         (remote_target::getpkt_or_notif_sane): Likewise.
9317         (class remote_target) <putpkt>: New overload.
9318         (remote_target::read_frame): Change type of "buf_p".  Remove
9319         sizeof_p parameter.
9320         (packet_ok): New overload.
9321         (packet_check_result): New overload.
9322         Update all uses.
9323
9324 2019-01-14  Tom Tromey  <tom@tromey.com>
9325
9326         * remote-notif.c (handle_notification, remote_notif_ack)
9327         (remote_notif_parse): Make "buf" const.
9328         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9329         const.
9330         (remote_notif_parse, remote_notif_ack, handle_notification):
9331         Likewise.
9332         * remote.c (remote_notif_stop_parse): Make "buf" const.
9333         (remote_target::remote_parse_stop_reply): Make "buf" const.
9334         (remote_notif_stop_ack): Make "buf" const.
9335
9336 2019-01-14  Tom Tromey  <tom@tromey.com>
9337
9338         * remote.c (remote_console_output): Make parameter const.
9339
9340 2019-01-14  Tom Tromey  <tom@tromey.com>
9341
9342         * target-debug.h (target_debug_print_signals): Constify.
9343         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9344         * procfs.c (procfs_target::pass_signals): Update.
9345         * linux-nat.c (linux_nat_target::pass_signals): Update.
9346         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9347         * target-delegates.c: Rebuild.
9348         * remote.c (remote_target::program_signals): Update.
9349         (remote_target::pass_signals): Update.
9350         * target.c (target_pass_signals): Constify argument.
9351         (target_program_signals): Likewise.
9352         * target.h (struct target_ops) <pass_signals, program_signals>:
9353         Constify argument.
9354         (target_pass_signals, target_program_signals): Constify argument.
9355
9356 2019-01-14  Tom Tromey  <tom@tromey.com>
9357
9358         PR tui/28819:
9359         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9360
9361 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9362
9363         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9364         field.
9365         * rs6000-tdep.c: Include reggroups.h.
9366         (IS_V_ALIAS_PSEUDOREG): Define.
9367         (rs6000_register_name): Return names for the "vX" aliases.
9368         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9369         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9370         aliases.  Call default_register_reggroup_p for all other
9371         pseudo-registers.
9372         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9373         New functions.
9374         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9375         Handle "vX" aliases.
9376         (v_alias_pseudo_register_collect): New function.
9377         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9378         (rs6000_gdbarch_init): Initialize "vX" aliases as
9379         pseudo-registers.  Restore registration of
9380         rs6000_pseudo_register_reggroup_p with
9381         set_tdesc_pseudo_register_reggroup_p.
9382
9383 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9384
9385         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9386         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9387         set_gdbarch_num_pseudo_regs.
9388
9389 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9390
9391         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9392         Remove arg prefixname, add do_set and do_show.
9393         Add member functions set_list and show_list.
9394         * cli/cli-style.c (class cli_style_option): Update accordingly.
9395         (style_set_list): Move to file scope.
9396         (style_show_list): Likewise.
9397         (set_style): Call help_list.
9398         (show_style): Call cmd_show_list.
9399         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9400         Update to use the new macro.
9401
9402 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9403
9404         * ada-lang.c (_initialize_ada_language): Expand the help text
9405         for the "catch exception" command.
9406
9407 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9408
9409         * symtab.c (matching_obj_sections): Initialize obj,
9410         declare it closer to its usage.
9411
9412 2019-01-10  Tom Tromey  <tom@tromey.com>
9413
9414         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9415         (basic_inf_threads_range): Remove.
9416         (inf_threads_range, inf_non_exited_threads_range)
9417         (safe_inf_threads_range): Use next_adapter.
9418
9419 2019-01-10  Keith Seitz  <keiths@redhat.com>
9420
9421         PR gdb/23712
9422         PR symtab/23010
9423         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9424         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9425
9426 2019-01-10  Keith Seitz  <keiths@redhat.com>
9427
9428         PR gdb/23712
9429         PR symtab/23010
9430         * dictionary.c (pending_to_vector): Remove.
9431         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9432         Remove _1 suffix, replacing functions of the same name.  Update
9433         all callers.
9434         (dict_create_hashed, dict_create_hashed_expandable)
9435         (dict_create_linear, dict_create_linear_expandable, dict_free)
9436         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9437         Make functions static.
9438
9439 2019-01-10  Keith Seitz  <keiths@redhat.com>
9440
9441         PR gdb/23712
9442         PR symtab/23010
9443         * dictionary.h (struct dictionary): Replace declaration with
9444         multidictionary.
9445         (dict_create_hashed, dict_create_hashed_expandable)
9446         (dict_create_linear, dict_create_linear_expandable)
9447         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9448         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9449         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9450         taking multidictionary argument.
9451         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9452         * block.h (struct block) <dict>: Change to multidictionary
9453         and rename `multidict'.
9454         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9455         symmisc.c: Update all dictionary references to multidictionary.
9456
9457 2019-01-10  Keith Seitz  <keiths@redhat.com>
9458
9459         PR gdb/23712
9460         PR symtab/23010
9461         * dictionary.c: Include unordered_map.
9462         (pending_to_vector): New function.
9463         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9464         Rewrite the non-"_1" functions to take vector instead
9465         of linked list.
9466         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9467         "new" _1 versions of the same name.
9468         (multidictionary): Define.
9469         (std::hash<enum language): New definition.
9470         (collate_pending_symbols_by_language, mdict_create_hashed)
9471         (mdict_create_hashed_expandable, mdict_create_linear)
9472         (mdict_create_linear_expandable, mdict_free)
9473         (find_language_dictionary, create_new_language_dictionary)
9474         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9475         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9476         (mdict_size, mdict_empty): New functions.
9477         * dictionary.h (mdict_iterator): Define.
9478
9479 2019-01-10  Pedro Alves  <palves@redhat.com>
9480
9481         * breakpoint.c (read_uploaded_action)
9482         (create_tracepoint_from_upload): Adjust to use
9483         gdb::unique_xmalloc_ptr.
9484         * ctf.c (ctf_write_uploaded_tp):
9485         (SET_ARRAY_FIELD): Use emplace_back.
9486         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9487         * tracefile-tfile.c (tfile_write_uploaded_tp):
9488         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9489         gdb::unique_xmalloc_ptr.
9490         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9491         at_string, cond_string, cmd_strings>: Replace char pointers
9492         with gdb::unique_xmalloc_ptr.
9493
9494 2019-01-10  Pedro Alves  <palves@redhat.com>
9495
9496         * solib-target.c (library_list_start_library): Don't xstrdup name.
9497
9498 2019-01-10  Pedro Alves  <palves@redhat.com>
9499
9500         * mdebugread.c (parse_partial_symbols): Use
9501         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9502
9503 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9504
9505         * linux-fork.c (scoped_switch_fork_info)
9506         <~scoped_switch_fork_info>: Fix incorrect variable name.
9507
9508 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9509
9510         * linux-fork.c (scoped_switch_fork_info)
9511         <scoped_switch_fork_info>: Make explicit.
9512         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9513
9514 2019-01-10  Tom Tromey  <tom@tromey.com>
9515
9516         * objfiles.h (objfile::reset_psymtabs): Update.
9517         * objfiles.c (objfile::objfile): Update.
9518         * psymtab.h (psymtab_storage::obstack): Update.
9519         (psymtab_storage::m_obstack): Use gdb::optional.
9520         (class psymtab_storage): Update comment.  Remove objfile
9521         parameter.
9522         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9523
9524 2019-01-10  Tom Tromey  <tom@tromey.com>
9525
9526         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9527         <free_psymtabs>: Now private.
9528         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9529         (allocate_psymtab): Use new method.
9530
9531 2019-01-10  Tom Tromey  <tom@tromey.com>
9532
9533         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9534         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9535         * mdebugread.c (parse_partial_symbols): Use
9536         allocate_dependencies.
9537         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9538         allocate_dependencies.
9539         (process_psymtab_comp_unit_reader)
9540         (build_type_psymtab_dependencies): Likewise.
9541         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9542
9543 2019-01-10  Tom Tromey  <tom@tromey.com>
9544
9545         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9546         PSYMBOL_SET_LANGUAGE.
9547         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9548
9549 2019-01-10  Tom Tromey  <tom@tromey.com>
9550
9551         * psymtab.h (psymtab_storage::obstack): New method.
9552         <m_obstack>: Rename from obstack; now private.
9553         * psymtab.c (psymtab_storage): Update.
9554         * dwarf2read.c (create_addrmap_from_index)
9555         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9556         Update.
9557
9558 2019-01-10  Tom Tromey  <tom@tromey.com>
9559
9560         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9561         * objfiles.h (objfile::reset_psymtabs): New method.
9562
9563 2019-01-10  Tom Tromey  <tom@tromey.com>
9564
9565         * symmisc.c (print_symbol_bcache_statistics): Update.
9566         (print_objfile_statistics): Update.
9567         * symfile.c (reread_symbols): Update.
9568         * psymtab.h (class psymtab_storage): New.
9569         * psymtab.c (psymtab_storage): New constructor.
9570         (~psymtab_storage): New destructor.
9571         (require_partial_symbols): Update.
9572         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9573         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9574         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9575         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9576         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9577         (start_psymtab_common, end_psymtab_common)
9578         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9579         (allocate_psymtab): Update.
9580         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9581         Update.
9582         (dump_psymtab_addrmap, maintenance_print_psymbols)
9583         (maintenance_check_psymtabs): Update.
9584         (class objfile_psymtabs): Move to objfiles.h.
9585         * psympriv.h (discard_psymtab): Now inline.
9586         (psymtab_discarder::psymtab_discarder): Update.
9587         (psymtab_discarder::~psymtab_discarder): Update.
9588         (ALL_OBJFILE_PSYMTABS): Rewrite.
9589         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9590         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9591         Remove fields.
9592         <partial_symtabs>: New field.
9593         (class objfile_psymtabs): Move from psymtab.h.  Update.
9594         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9595         psymbol_cache.
9596         (objfile::~objfile): Don't destroy psymbol_cache.
9597         * mdebugread.c (parse_partial_symbols): Update.
9598         * dwarf2read.c (create_addrmap_from_index)
9599         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9600         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9601         (add_partial_subprogram, dwarf2_ranges_read): Update.
9602         * dwarf-index-write.c (write_address_map)
9603         (write_one_signatured_type, recursively_write_psymbols)
9604         (class debug_names, class debug_names, write_psymtabs_to_index):
9605         Update.
9606
9607 2019-01-10  Tom Tromey  <tom@tromey.com>
9608
9609         * symtab.h (SYMBOL_SET_NAMES): Update.
9610         (symbol_set_names): Update.
9611         (MSYMBOL_SET_NAMES): Update.
9612         * symtab.c (symbol_set_names): Change argument to be an
9613         objfile_per_bfd_storage.
9614         * psymtab.c (add_psymbol_to_bcache): Update.
9615         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9616
9617 2019-01-10  Tom Tromey  <tom@tromey.com>
9618
9619         * symtab.c (create_demangled_names_hash): Change argument to be an
9620         objfile_per_bfd_storage.
9621         (symbol_set_names): Update.
9622
9623 2019-01-10  Tom Tromey  <tom@tromey.com>
9624
9625         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9626         init_psymbol_list.
9627         * psymtab.c (init_psymbol_list): Do nothing if already called.
9628         * psympriv.h (init_psymbol_list): Add comment.
9629         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9630         init_psymbol_list.
9631         * dbxread.c (dbx_symfile_read): Unconditionally call
9632         init_psymbol_list.
9633
9634 2019-01-10  Tom Tromey  <tom@tromey.com>
9635
9636         * xcoffread.c (scan_xcoff_symtab): Update.
9637         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9638         "where".
9639         * mdebugread.c (parse_partial_symbols)
9640         (handle_psymbol_enumerators): Update.
9641         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9642         * dbxread.c (read_dbx_symtab): Update.
9643         * psympriv.h (psymbol_placement): New enum.
9644         (add_psymbol_to_list): Update.
9645
9646 2019-01-10  Tom Tromey  <tom@tromey.com>
9647
9648         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9649         static_psymbols parameters.
9650         (scan_xcoff_symtab): Update.
9651         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9652         static_psymbols parameters.
9653         * psympriv.h (start_psymtab_common): Update.
9654         * mdebugread.c (parse_partial_symbols): Update.
9655         * dwarf2read.c (create_partial_symtab): Update.
9656         * dbxread.c (read_dbx_symtab): Update.
9657         (start_psymtab): Remove global_psymbols and static_psymbols
9658         parameters.
9659
9660 2019-01-10  Tom Tromey  <tom@tromey.com>
9661
9662         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9663         * psymtab.c (allocate_psymtab): Add comment.
9664         * psympriv.h (allocate_psymtab): Add comment.
9665         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9666         initializations.
9667         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9668
9669 2019-01-10  Tom Tromey  <tom@tromey.com>
9670
9671         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9672         Don't declare.
9673         * mipsread.c: Include mdebugread.h.
9674         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9675         Declare.
9676         * elfread.c: Include mdebugread.h.
9677
9678 2019-01-09  Tom Tromey  <tom@tromey.com>
9679
9680         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9681         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9682         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9683         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9684         (psym_lookup_symbol, psym_find_last_source_symtab)
9685         (psym_forget_cached_source_info, psym_print_stats)
9686         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9687         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9688         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9689         (psym_find_compunit_symtab_by_address)
9690         (maintenance_print_psymbols, maintenance_info_psymtabs)
9691         (maintenance_check_psymtabs): Use ranged for.
9692         * psymtab.h (class objfile_psymtabs): New.
9693         (require_partial_symbols): Return objfile_psymtabs.
9694         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9695
9696 2019-01-09  Tom Tromey  <tom@tromey.com>
9697
9698         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9699         (find_pc_mapped_section, list_overlays_command)
9700         (map_overlay_command, unmap_overlay_command)
9701         (simple_overlay_update): Use all_objfiles.
9702         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9703         * printcmd.c (info_symbol_command): Use all_objfiles.
9704         * objfiles.h (ALL_OBJSECTIONS): Remove.
9705         * maint.c (maintenance_translate_address): Use all_objfiles.
9706         * gcore.c (gcore_create_callback): Use all_objfiles.
9707         (objfile_find_memory_regions): Likewise.
9708
9709 2019-01-09  Tom Tromey  <tom@tromey.com>
9710
9711         * symtab.c (find_line_symtab, info_sources_command)
9712         (make_source_files_completion_list): Use objfile_compunits.
9713         * source.c (select_source_symtab): Use objfile_compunits.
9714         * objfiles.h (struct objfile): Update comment.
9715         (ALL_OBJFILES): Remove.
9716         (ALL_FILETABS): Remove.
9717         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9718         objfile_compunits.
9719
9720 2019-01-09  Tom Tromey  <tom@tromey.com>
9721
9722         * symmisc.c (print_objfile_statistics, dump_objfile)
9723         (maintenance_print_symbols): Use compunit_filetabs.
9724         * source.c (forget_cached_source_info_for_objfile): Use
9725         compunit_filetabs.
9726         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9727         (ALL_FILETABS): Use compunit_filetabs.
9728         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9729         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9730
9731 2019-01-09  Tom Tromey  <tom@tromey.com>
9732
9733         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9734         (compunit_filetabs): New.
9735         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9736         compunit_filetabs.
9737         (info_sources_command, make_source_files_completion_list): Remove
9738         declaration.
9739         * symmisc.c (print_objfile_statistics, dump_objfile)
9740         (maintenance_print_symbols): Remove declaration.
9741         (maintenance_info_symtabs): Use compunit_filetabs.
9742         (maintenance_info_line_tables): Likewise.
9743         * source.c (select_source_symtab): Change local variable name.
9744         (forget_cached_source_info_for_objfile): Remove declaration.
9745         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9746         * objfiles.c (objfile_relocate1): Remove declaration.
9747         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9748         declaration.
9749         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9750         * coffread.c (coff_symtab_read): Remove declaration.
9751         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9752         compunit_filetabs.
9753
9754 2019-01-09  Tom Tromey  <tom@tromey.com>
9755
9756         * symtab.c (lookup_objfile_from_block)
9757         (find_pc_sect_compunit_symtab, search_symbols)
9758         (default_collect_symbol_completion_matches_break_on): Use
9759         objfile_compunits.
9760         * objfiles.h (ALL_COMPUNITS): Remove.
9761         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9762         * cp-support.c (add_symbol_overload_list_qualified): Use
9763         objfile_compunits.
9764         * ada-lang.c (ada_collect_symbol_completion_matches)
9765         (ada_add_global_exceptions): Use objfile_compunits.
9766
9767 2019-01-09  Tom Tromey  <tom@tromey.com>
9768
9769         * source.c (select_source_symtab)
9770         (forget_cached_source_info_for_objfile): Remove declaration.
9771         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9772         declaration.
9773         * maint.c (count_symtabs_and_blocks): Remove declaration.
9774         * cp-support.c (add_symbol_overload_list_qualified): Remove
9775         declaration.
9776         * coffread.c (coff_symtab_read): Remove declaration.
9777         * symtab.c (lookup_symbol_in_objfile_symtabs)
9778         (basic_lookup_transparent_type_1): Use objfile_compunits.
9779         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9780         (info_sources_command, search_symbols)
9781         (default_collect_symbol_completion_matches_break_on)
9782         (make_source_files_completion_list): Remove declaration.
9783         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9784         (ada_collect_symbol_completion_matches)
9785         (ada_add_global_exceptions): Remove declaration.
9786         * linespec.c (iterate_over_all_matching_symtabs): Use
9787         objfile_compunits.
9788         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9789         (class objfile_compunits): New.
9790         (ALL_COMPUNITS): Use objfile_compunits.
9791         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9792         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9793         objfile_compunits.
9794         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9795
9796 2019-01-09  Tom Tromey  <tom@tromey.com>
9797
9798         * symtab.c (search_symbols)
9799         (default_collect_symbol_completion_matches_break_on): Use
9800         objfile_msymbols.
9801         * ada-lang.c (ada_lookup_simple_minsym)
9802         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9803         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9804         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9805         objfile_msymbols.
9806         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9807         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9808         * objc-lang.c (find_methods): Use objfile_msymbols.
9809         (info_selectors_command, info_classes_command): Likewise.
9810         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9811         * objfiles.h (class objfile_msymbols): New.
9812         (ALL_OBJFILE_MSYMBOLS): Remove.
9813         (ALL_MSYMBOLS): Remove.
9814
9815 2019-01-09  Tom Tromey  <tom@tromey.com>
9816
9817         * common/next-iterator.h (next_adapter): Add Iterator template
9818         parameter.
9819         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9820         (class all_objfiles_safe): New.
9821         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9822         * objfiles.c (put_objfile_before): Update comment.
9823         (add_separate_debug_objfile): Likewise.
9824         (free_all_objfiles): Use all_objfiles_safe.
9825         (objfile_purge_solibs): Likewise.
9826
9827 2019-01-09  Tom Tromey  <tom@tromey.com>
9828
9829         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9830         (expand_symtab_containing_pc, lookup_static_symbol)
9831         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9832         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9833         all_objfiles.
9834         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9835         * breakpoint.c (create_overlay_event_breakpoint)
9836         (create_longjmp_master_breakpoint)
9837         (create_std_terminate_master_breakpoint)
9838         (create_exception_master_breakpoint): Use all_objfiles.
9839         * linux-thread-db.c (try_thread_db_load_from_pdir)
9840         (has_libpthread): Use all_objfiles.
9841         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9842         * linespec.c (iterate_over_all_matching_symtabs)
9843         (search_minsyms_for_name): Use all_objfiles.
9844         * maint.c (maintenance_info_sections): Use all_objfiles.
9845         * main.c (captured_main_1): Use all_objfiles.
9846         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9847         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9848         * guile/scm-pretty-print.c
9849         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9850         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9851         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9852         (maintenance_print_msymbols): Use all_objfiles.
9853         * source.c (select_source_symtab): Use all_objfiles.
9854         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9855         * symfile.c (remove_symbol_file_command)
9856         (expand_symtabs_matching, map_symbol_filenames): Use
9857         all_objfiles.
9858         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9859         all_objfiles.
9860         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9861         * objc-lang.c (find_methods): Use all_objfiles.
9862         * objfiles.c (have_partial_symbols, have_full_symbols)
9863         (have_minimal_symbols, qsort_cmp)
9864         (default_iterate_over_objfiles_in_search_order): Use
9865         all_objfiles.
9866         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9867         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9868         (maintenance_check_psymtabs): Use all_objfiles.
9869         (ALL_PSYMTABS): Remove.
9870         * compile/compile-object-run.c (do_module_cleanup): Use
9871         all_objfiles.
9872         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9873         * cp-support.c (add_symbol_overload_list_qualified): Use
9874         all_objfiles.
9875         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9876         Use all_objfiles.
9877         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9878         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9879         all_objfiles.
9880         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9881         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9882         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9883         Uses all_objfiles.
9884         * solib.c (solib_read_symbols): Use all_objfiles
9885
9886 2019-01-09  Tom Tromey  <tom@tromey.com>
9887
9888         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9889         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9890         all_objfiles.
9891         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9892         * symmisc.c (print_symbol_bcache_statistics)
9893         (print_objfile_statistics, maintenance_print_objfiles)
9894         (maintenance_info_symtabs, maintenance_check_symtabs)
9895         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9896         all_objfiles.
9897         * source.c (forget_cached_source_info): Use all_objfiles.
9898         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9899         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9900         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9901         * objfiles.c (update_section_map): Use all_objfiles.
9902         (shared_objfile_contains_address_p): Likewise.
9903         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9904         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9905
9906 2019-01-09  Tom Tromey  <tom@tromey.com>
9907
9908         * common/next-iterator.h: New file.
9909         * objfiles.h (class all_objfiles): New.
9910         (struct objfile_iterator): New.
9911
9912 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9913
9914         * NEWS: Move the description of the changed "frame", "select-frame",
9915          and "info frame" commands to the Changed commands section.
9916
9917 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9918
9919         * gdbtypes.c (check_stub_method_group): Remove handling of old
9920         mangling schemes.
9921         * linespec.c (find_methods): Likewise.
9922         * stabsread.c (read_member_functions): Likewise.
9923         * valops.c (search_struct_method): Likewise.
9924         (value_struct_elt_for_reference): Likewise.
9925         * NEWS: Mention this change.
9926
9927 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9928
9929         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9930         print_source_lines.
9931         * source.c (print_source_lines_base): Update line number check.
9932         (print_source_lines): New function.
9933         (source_lines_range::source_lines_range): New function.
9934         * source.h (class source_lines_range): New class.
9935         (print_source_lines): New declaration.
9936
9937 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9938
9939         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9940
9941 2019-01-08  Tom Tromey  <tom@tromey.com>
9942             Simon Marchi  <simon.marchi@ericsson.com>
9943
9944         PR gdb/24060
9945         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9946         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9947         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9948         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9949         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9950         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9951
9952 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9953
9954         * source.c (select_source_symtab): Move header comment to
9955         declaration in source.h.
9956         (forget_cached_source_info_for_objfile): Likewise.
9957         (forget_cached_source_info): Likewise.
9958         (identify_source_line): Likewise.
9959         * source.h (identify_source_line): Move declaration from symtab.h
9960         and add comment from source.c
9961         (print_source_lines): Likewise.
9962         (forget_cached_source_info_for_objfile): Likewise.
9963         (forget_cached_source_info): Likewise.
9964         (select_source_symtab): Likewise.
9965         (enum print_source_lines_flag): Move definition from symtab.h.
9966         * symtab.h (identify_source_line): Move declaration to source.h.
9967         (print_source_lines): Likewise.
9968         (forget_cached_source_info_for_objfile): Likewise.
9969         (forget_cached_source_info): Likewise.
9970         (select_source_symtab): Likewise.
9971         (enum print_source_lines_flag): Move definition to source.h.
9972         * tui/tui-hooks.c: Add 'source.h' include.
9973
9974 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9975
9976         * source.c (print_source_lines_base): Handle requests to print
9977         reverse line number sequences, and guard against empty lines
9978         string.
9979
9980 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9981
9982         * source.c (print_source_lines_base): Fix skip of '\r' if next
9983         character is '\n'.
9984
9985 2019-01-06  Tom Tromey  <tom@tromey.com>
9986
9987         * c-exp.y (struct c_parse_state) <macro_original_text,
9988         expansion_obstack>: New member.
9989         (macro_original_text, expansion_obstack): Remove globals.
9990         (scan_macro_expansion, scanning_macro_expansion)
9991         (finished_macro_expansion): Update.
9992         (scan_macro_cleanup): Remove.
9993         (yylex, c_parse): Update.
9994
9995 2019-01-06  Tom Tromey  <tom@tromey.com>
9996
9997         * c-exp.y (struct c_parse_state) <strings>: New member.
9998         (operator_stoken): Update.
9999
10000 2019-01-06  Tom Tromey  <tom@tromey.com>
10001
10002         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10003         (union type_stack_elt) <typelist_val>: Now a pointer to
10004         std::vector.
10005         (type_stack_cleanup): Don't declare.
10006         (push_typelist): Update.
10007         * parse.c (pop_typelist): Return a std::vector.
10008         (push_typelist): Take a std::vector.
10009         (follow_types): Update.  Do not free args.
10010         (type_stack_cleanup): Remove.
10011         * c-exp.y (struct c_parse_state): New.
10012         (cpstate): New global.
10013         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10014         (nonempty_typelist): Update.
10015         (func_mod): Create a new vector.
10016         (c_parse): Create a c_parse_state.
10017         (check_parameter_typelist): Do not delete params.
10018         (function_method): Update.  Do not delete type_list.
10019
10020 2019-01-06  Tom Tromey  <tom@tromey.com>
10021
10022         PR gdb/28155:
10023         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10024         check_typedef.
10025         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10026         (print_return_value): Likewise.
10027
10028 2019-01-05  Tom Tromey  <tom@tromey.com>
10029
10030         * contrib/cleanup_check.py: Remove.
10031         * contrib/gcc-with-excheck: Remove.
10032         * contrib/exsummary.py: Remove.
10033         * contrib/excheck.py: Remove.
10034
10035 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10036
10037         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10038         NULL. Initialize tpprev to NULL instead of assigning it
10039         to NULL on the next statement.
10040         * windows-nat.c (windows_delete_thread): Remove check for
10041         main_thread_id before printing thread exit notifications.
10042         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10043         Remove thread ID check against main_thread_id.
10044         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10045         windows_delete_thread.
10046         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10047
10048 2019-01-04  Tom Tromey  <tom@tromey.com>
10049
10050         * compile/compile.c (_initialize_compile): Use upper case for
10051         metasyntactic variables.
10052         * symmisc.c (_initialize_symmisc): Use upper case for
10053         metasyntactic variables.
10054         * psymtab.c (_initialize_psymtab): Use upper case for
10055         metasyntactic variables.
10056         * demangle.c (demangle_command): Use upper case for metasyntactic
10057         variables.
10058         (_initialize_demangler): Likewise.
10059         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10060         variables.
10061
10062 2019-01-03  Tom Tromey  <tom@tromey.com>
10063
10064         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10065
10066 2019-01-03  Tom Tromey  <tom@tromey.com>
10067
10068         * python/py-symtab.c (salpy_str): Update.
10069         (struct salpy_sal_object) <symtab>: Now a PyObject.
10070         (salpy_dealloc): Update.
10071         (del_objfile_sal): Use gdbpy_ref.
10072
10073 2019-01-03  Tom Tromey  <tom@tromey.com>
10074
10075         * python/py-type.c (convert_field): Use new_reference.  Return
10076         gdbpy_ref.
10077         (make_fielditem): Return gdbpy_ref.
10078         (typy_fields): Update.
10079         (typy_getitem): Update.
10080         (field_name): Return gdbpy_ref.  Use new_reference.
10081         (typy_iterator_iternext): Update.
10082
10083 2019-01-03  Tom Tromey  <tom@tromey.com>
10084
10085         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10086
10087 2019-01-03  Tom Tromey  <tom@tromey.com>
10088
10089         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10090         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10091         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10092         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10093         (pspy_set_type_printers): Likewise.
10094         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10095         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10096         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10097         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10098         (objfpy_set_type_printers): Likewise.
10099
10100 2019-01-03  Tom Tromey  <tom@tromey.com>
10101
10102         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10103         (gdbpy_print_stack): Use gdbpy_err_fetch.
10104         * python/python-internal.h (class gdbpy_err_fetch): New class.
10105         (class gdbpy_enter) <m_error_type, m_error_value,
10106         m_error_traceback>: Remove.
10107         <m_error>: New member.
10108         (gdbpy_exception_to_string): Don't declare.
10109         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10110         * python/py-value.c (convert_value_from_python): Use
10111         gdbpy_err_fetch.
10112         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10113         gdbpy_exception_to_string.
10114         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10115         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10116         gdbpy_err_fetch.
10117
10118 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10119
10120         * linux-nat.c (delete_lwp_cleanup): Delete.
10121         (struct lwp_deleter): New struct.
10122         (lwp_info_up): New typedef.
10123         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10124         lwp_info_up.
10125
10126 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10127
10128         * linux-fork.c (class scoped_switch_fork_info): New class.
10129         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10130
10131 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10132
10133         * valops.c (find_overload_match): Remove use of null_cleanup, and
10134         calls to do_cleanups.
10135
10136 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10137
10138         * compile/compile-cplus-types.c
10139         (compile_cplus_instance::decl_name): Handle changes to
10140         cp_func_name.
10141         * cp-support.c (cp_func_name): Update header comment, update
10142         return type.
10143         * cp-support.h (cp_func_name): Update return type in declaration.
10144         * valops.c (find_overload_match): Move temp_func local to top
10145         level of function and change its type.  Use temp_func to hold and
10146         delete temporary string obtained from cp_func_name.
10147
10148 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10149
10150         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10151         gdb::char_vector, remove cleanup, and update uses of `msg`.
10152
10153 2019-01-03  Jim Wilson  <jimw@sifive.com>
10154
10155         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10156
10157 2019-01-02  Tom Tromey  <tom@tromey.com>
10158
10159         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10160         (tdesc_parse_xml): Remove cleanups.
10161         * target-descriptions.h (make_cleanup_free_target_description):
10162         Don't declare.
10163         (target_desc_deleter): New struct.
10164         (target_desc_up): New typedef.
10165         * target-descriptions.c (target_desc_deleter::operator()): Rename
10166         from free_target_description.
10167         (make_cleanup_free_target_description): Remove.
10168
10169 2019-01-02  Tom Tromey  <tom@tromey.com>
10170
10171         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10172         constructor, destructor.
10173         (linespec_parser): Remove typedef.
10174         (~linespec_parser): Rename from linespec_parser_delete.
10175         (linespec_lex_to_end, linespec_complete_label)
10176         (linespec_complete): Update.
10177         (decode_line_full): Remove cleanups.
10178         (decode_line_1): Update.
10179
10180 2019-01-02  Tom Tromey  <tom@tromey.com>
10181
10182         * python/python-internal.h (inferior_to_inferior_object): Change
10183         return type.
10184         * python/py-exitedevent.c (create_exited_event_object): Update.
10185         * python/py-inferior.c (inferior_to_inferior_object): Return
10186         gdbpy_ref.
10187         (python_new_inferior, python_inferior_deleted)
10188         (thread_to_thread_object, delete_thread_object)
10189         (build_inferior_list, gdbpy_selected_inferior): Update.
10190         * python/py-infthread.c (create_thread_object): Update.  Also fail
10191         if inferior_to_inferior_object fails.
10192
10193 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10194
10195         * inferior.h (class inferior) <displaced_step_state>: New field.
10196         * infrun.h (struct displaced_step_state): Move here from
10197         infrun.c.  Initialize fields, add constructor.
10198         <inf>: Remove field.
10199         <reset>: New method.
10200         * infrun.c (struct displaced_step_inferior_state): Move to
10201         infrun.h.
10202         (displaced_step_inferior_states): Remove.
10203         (get_displaced_stepping_state): Adust.
10204         (displaced_step_in_progress_any_inferior): Adjust.
10205         (displaced_step_in_progress_thread): Adjust.
10206         (displaced_step_in_progress): Adjust.
10207         (add_displaced_stepping_state): Remove.
10208         (get_displaced_step_closure_by_addr): Adjust.
10209         (remove_displaced_stepping_state): Remove.
10210         (infrun_inferior_exit): Call displaced_step_state.reset.
10211         (use_displaced_stepping): Don't check for NULL.
10212         (displaced_step_prepare_throw): Call
10213         get_displaced_stepping_state.
10214         (displaced_step_fixup): Don't check for NULL.
10215         (prepare_for_detach): Don't check for NULL.
10216
10217 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10218
10219         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10220          in case of call that did not complete.
10221
10222 2019-01-02  Andrey Utkin  <autkin@undo.io>
10223
10224         * symfile.c (find_separate_debug_file): Fix search of debug files for
10225         remote debuggee.
10226
10227 2019-01-02  Tom Tromey  <tom@tromey.com>
10228
10229         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10230         indentation.
10231         * python/py-frame.c (frapy_older): Remove cast.
10232         (frapy_newer): Likewise.
10233         * python/py-breakpoint.c (local_setattro): Remove cast.
10234         * python/py-arch.c (archpy_name): Remove local variable.
10235         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10236
10237 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10238
10239         * unittests/basic_string_view/element_access/char/empty.cc:
10240         Fix year range in copyright header.
10241
10242 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10243
10244         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10245         Delete.
10246         <operator==>: Update with for removed field.
10247         <hash>: Likewise.
10248         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10249         <isa_features>: ...this.
10250         <abi_features>: New field.
10251         (riscv_isa_flen): Update comment.
10252         (riscv_abi_xlen): New declaration.
10253         (riscv_abi_flen): New declaration.
10254         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10255         isa_features.
10256         (riscv_abi_xlen): New function.
10257         (riscv_isa_flen): Update to get answer from isa_features.
10258         (riscv_abi_flen): New function.
10259         (riscv_has_fp_abi): Update to get answer from abi_features.
10260         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10261         xlen and flen.
10262         (riscv_call_info) <xlen, flen>: Update comment.
10263         (riscv_call_arg_struct): Remove invalid assertions
10264         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10265         is removed.
10266         (riscv_gdbarch_init): Gather isa features and abi features
10267         separately, ensure both match on the gdbarch when reusing an old
10268         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10269         a target with 64-bit float hardware.
10270
10271 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10272
10273         * source.c (search_command_helper): Stop reverse search
10274         when line 1 has been searched.
10275
10276 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10277
10278         * record-full.c (record_full_base_target::close): Rewrite
10279         record_full_core_buf_list free logic.
10280
10281 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10282
10283         * break-catch-syscall.c (print_one_catch_syscall): xfree
10284         the last text.
10285
10286 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10287
10288         * top.c (print_gdb_version): Update Copyright year in version
10289         message.
10290
10291 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10292
10293         Update copyright year range in all GDB files.
10294
10295 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10296
10297         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10298
10299 For older changes see ChangeLog-2018.
10300 \f
10301 Local Variables:
10302 mode: change-log
10303 left-margin: 8
10304 fill-column: 74
10305 version-control: never
10306 coding: utf-8
10307 End:
10308