gdb/ChangeLog

   1 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * dwarf2read.c (struct dw2_symtab_iterator):
   4         <want_specific_block>: Remove.
   5         <block_index>: Change type to gdb::optional.
   6         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
   7         change type of BLOCK_INDEX parameter to gdb::optional.
   8         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
   9         (dw2_lookup_symbol): Don't pass argument for
  10         WANT_SPECIFIC_BLOCK.
  11         (dw2_expand_symtabs_for_function): Don't pass argument for
  12         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
  13         (class dw2_debug_names_iterator)
  14         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
  15         parameter, change BLOCK_INDEX type to gdb::optional.
  16         <m_want_specific_block>: Remove.
  17         <m_block_index>: Change type to gdb::optional.
  18         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
  19         gdb::optional.  Re-write in function of gdb::optional.
  20         (dw2_debug_names_lookup_symbol): Don't pass argument for
  21         WANT_SPECIFIC_BLOCK.
  22         (dw2_debug_names_expand_symtabs_for_function): Don't pass
  23         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
  24         BLOCK_INDEX.
  25
  26 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  27
  28         * NEWS: Mention changes to "info sources" command.
  29
  30 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  31
  32         * symtab.c (filename_partial_match_opts): New struct type.
  33         (struct output_source_filename_data): New members
  34         regexp, c_regexp, partial_match.
  35         (output_source_filename): Use new members to decide to print file.
  36         (info_sources_option_defs): New variable.
  37         (make_info_sources_options_def_group, print_info_sources_header,
  38         info_sources_command_completer):
  39         New functions.
  40         (info_sources_command): Read new optional arguments.
  41         (_initialize_symtab): Update info sources help.
  42
  43 2019-08-02  Alexandre Oliva <oliva@adacore.com>
  44
  45         * ada-lang.c (exception_support_info_v0): Renamed from...
  46         (default_exception_support_info): ... this.  Create new
  47         definition for v1.
  48         (ada_has_this_exception_support): Look up catch_handlers_sym.
  49         (ada_exception_support_info_sniffer): Try v0 after default.
  50
  51 2019-08-01  Tom Tromey  <tromey@adacore.com>
  52
  53         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
  54         gdbarch.h.
  55
  56 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
  57
  58         * s12z-tdep.c: Fix include path for s12z-opc.h.
  59
  60 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
  61
  62         * NEWS: Require GNU make 3.82.
  63
  64 2019-07-16  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
  67         declare.
  68
  69 2019-07-30  Tom Tromey  <tromey@adacore.com>
  70
  71         * block.c (contained_in): Remove BLOCK_FUNCTION check.
  72
  73 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
  74
  75         * printcmd.c (print_address_symbolic): Print negative offsets.
  76         (build_address_symbolic): Force signed arithmetic when computing
  77         offset.
  78
  79 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
  80
  81         PR/24474: Add a function to lookup static variables.
  82         * NEWS: Mention this new function.
  83         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
  84         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
  85         * python/python.c (python_GdbMethods): Add new function.
  86
  87 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
  88
  89         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
  90         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
  91         (objfpy_lookup_static_symbol): New function.
  92         (objfile_object_methods): Add new functions.
  93
  94 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  95
  96         * NEWS: Mention 'set|show print frame-info'.  Mention new
  97         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
  98         backtrace argument.  Mention that python frame filtering code
  99         is now consistent with what 'backtrace' command prints.
 100
 101 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 102
 103         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 104         comments.
 105         (print_frame_info_auto, print_frame_info_source_line,
 106         print_frame_info_location, print_frame_info_source_and_location,
 107         print_frame_info_location_and_address, print_frame_info_short_location):
 108         New declarations.
 109         (struct frame_print_options): New member print_frame_info.
 110         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 111         * stack.h (get_user_print_what_frame_info): New declaration.
 112         (frame_show_address): New declaration.
 113         * stack.c (print_frame_arguments_choices): New value 'presence'.
 114         (print_frame_info_auto, print_frame_info_source_line,
 115         print_frame_info_location, print_frame_info_source_and_location,
 116         print_frame_info_location_and_address, print_frame_info_short_location,
 117         print_frame_info_choices, print_frame_info_print_what): New definitions.
 118         (print_frame_args): Only print dots for args if print frame-arguments
 119         is 'presence'.
 120         (frame_print_option_defs): New element for "frame-info".
 121         (get_user_print_what_frame_info): New function.
 122         (frame_show_address): Make non static.  Move comment to stack.h.
 123         (print_frame_info_to_print_what): New function.
 124         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 125         to decide what to print.
 126         (backtrace_command_1): Handle the new print_frame_arguments_presence
 127         value.
 128         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 129         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 130         (py_print_frame): In non-mi mode, use LOCATION as default for
 131         print_what, similarly to frame information printed directly by
 132         backtrace command. Handle frame-info user option in non MI mode.
 133
 134 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 135
 136         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 137         Add case for debugging 32-bit target on 64-bit host.  Revise
 138         comment.
 139
 140 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 141
 142         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 143         instead of find_function_entry_range_from_pc.
 144
 145 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 146
 147         * stack.c (find_frame_funname): Remove code which preferred
 148         minsym over symtab sym in "certain pathological cases".
 149
 150         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 151         parameter.  Change type of "do_demangle" to bool.
 152         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 153         Pass suitable "prefer_sym_over_minsym" flag to
 154         build_address_symbolic().  Don't output "+" for negative offsets.
 155         * printcmd.c (print_address_symbolic): Update invocation of
 156         build_address_symbolic to include a "prefer_sym_over_minsym"
 157         flag.
 158         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 159         Restrict cases in which use of minimal symbol is preferred to that
 160         of a found symbol.  Update comments.
 161
 162         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 163         for entry pc when entry pc is out of range for that FDE.
 164
 165 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 166
 167         PR gdb/24839:
 168         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 169         type.
 170
 171 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 172
 173         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 174         this function's Python signature.
 175
 176
 177 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 178
 179         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 180         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 181         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 182         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 183         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 184
 185
 186 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 187
 188         * h8300-tdep.c (h8300_register_name_common): New.
 189         h8300_register_name): Use h8300_register_name_common.
 190         (h8300s_register_name): Likewise.
 191         (h8300sx_register_name): Likewise.
 192         (h8300h_register_nam): New.
 193         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 194
 195
 196 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 197
 198         * arm-tdep.c (arm_skip_cmse_entry): New function.
 199         (arm_is_sgstubs_section): New function.
 200         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 201
 202 2019-07-22  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 205         Don't self-assign.
 206
 207 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 210         type_print.
 211
 212 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 213
 214         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 215         so that GDB doesn't match any msymbols when searching in the
 216         TYPES_DOMAIN.
 217         (print_symbol_info): Print using typedef_print or type_print based
 218         on the type of the symbol.  Add updated FIXME comment moved from...
 219         (_initialize_symtab): ... move and update FIXME comment to above.
 220
 221 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 222
 223         * NEWS: Mention adding -q option to "info types".
 224         * symtab.c (struct info_types_options): New struct.
 225         (info_types_options_defs): New variable.
 226         (make_info_types_options_def_group): New function.
 227         (info_types_command): Use gdb::option framework to parse options.
 228         (info_types_command_completer): New function.
 229         (_initialize_symtab): Extend the help text on "info types" and
 230         register command completer.
 231
 232 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 233
 234         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 235         (lookup_symbol_in_objfile): Change int to block_enum and add a
 236         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 237
 238 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 239
 240         * MAINTAINERS (Write After Approval): Add self.
 241
 242 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 243
 244         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 245         instruction to the dummy code region.
 246
 247 2019-07-19  Tom Tromey  <tromey@adacore.com>
 248
 249         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 250         (ARGSUSED, PARAMS, __func__): Remove rules.
 251
 252 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 253
 254         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 255         * features/arm/arm-with-iwmmxt.c: Remove.
 256         * features/arm/arm-with-iwmmxt.xml: Remove.
 257         * features/arm/arm-with-m-fpa-layout.c: Remove.
 258         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 259         * features/arm/arm-with-m-vfp-d16.c: Remove.
 260         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 261         * features/arm/arm-with-m.c: Remove.
 262         * features/arm/arm-with-m.xml: Remove.
 263         * features/arm/arm-with-neon.c: Remove.
 264         * features/arm/arm-with-neon.xml: Remove.
 265         * features/arm/arm-with-vfpv2.c: Remove.
 266         * features/arm/arm-with-vfpv2.xml: Remove.
 267         * features/arm/arm-with-vfpv3.c: Remove.
 268         * features/arm/arm-with-vfpv3.xml: Remove.
 269
 270 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 271
 272         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 273
 274 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 275
 276         * arch/aarch32.c (aarch32_create_target_description): Create
 277         target descriptions using features.
 278         * arch/arm.c (arm_create_target_description)
 279         (arm_create_mprofile_target_description): Likewise.
 280         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 281
 282 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 283
 284         * Makefile.in: Add new files.
 285         * aarch32-tdep.c: New file.
 286         * aarch32-tdep.h: New file.
 287         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 288         Call aarch32_read_description.
 289         * arch/aarch32.c: New file.
 290         * arch/aarch32.h: New file.
 291         * arch/arm.c (arm_create_target_description)
 292         (arm_create_mprofile_target_description): New function.
 293         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 294         (arm_create_target_description)
 295         (arm_create_mprofile_target_description): New declaration.
 296         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 297         read_description functions.
 298         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 299         Likewise.
 300         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 301         * arm-tdep.c (tdesc_arm_list): New variable.
 302         (arm_register_g_packet_guesses): Call create description functions.
 303         (arm_read_description) (arm_read_mprofile_description): New
 304         function.
 305         * arm-tdep.h (arm_read_description)
 306         (arm_read_mprofile_description): Add declaration.
 307         * configure.tgt: Add new files.
 308
 309 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 310
 311         * top.c (new_ui_command): Open specified terminal just once.
 312
 313 2019-07-18  Tom Tromey  <tromey@adacore.com>
 314
 315         * symtab.c (main_name): Constify return type.
 316         * symfile.c (set_initial_language): Update.
 317         * symtab.h (main_name): Constify return type.
 318
 319 2019-07-17  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-winsource.c (tui_update_source_window)
 322         (tui_update_source_window_as_is)
 323         (tui_update_source_windows_with_line): Remove return.
 324         * tui/tui-disasm.c (tui_show_disassem)
 325         (tui_show_disassem_and_update_source): Remove return.
 326         * tui/tui.c (tui_reset): Remove return.
 327         * tui/tui-wingeneral.c
 328         (tui_check_and_display_highlight_if_needed): Remove return.
 329
 330 2019-07-17  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 333
 334 2019-07-17  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-winsource.h (struct tui_exec_info_window)
 337         (struct tui_source_window_base): Move from tui-data.h.
 338         * tui/tui-winsource.c: Move many method definitions from
 339         elsewhere.  Remove "structuring" comments.
 340         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 341         (tui_source_window_base::refresh_window): Move to
 342         tui-winsource.c.
 343         * tui/tui-win.c (tui_source_window_base::refresh_all)
 344         (tui_source_window_base::update_tab_width)
 345         (tui_source_window_base::set_new_height)
 346         (tui_source_window_base::do_make_visible_with_new_height): Move to
 347         tui-winsource.c.
 348         * tui/tui-source.h: Update.
 349         * tui/tui-source.c (tui_source_window_base::reset): Move to
 350         tui-winsource.c.
 351         * tui/tui-disasm.h: Update.
 352         * tui/tui-data.h (struct tui_exec_info_window): Move to
 353         tui-winsource.h.
 354         (struct tui_source_window_base): Likewise.
 355         * tui/tui-data.c (tui_source_window_base::clear_detail)
 356         (tui_source_window_base, ~tui_source_window_base): Move to
 357         tui-winsource.c.
 358
 359 2019-07-17  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-win.c (tui_resize_all)
 362         (tui_source_window_base::update_tab_width)
 363         (tui_adjust_win_heights): Update.
 364         (tui_win_info::make_invisible_and_set_new_height): Rename from
 365         make_invisible_and_set_new_height.
 366         * tui/tui-data.h (struct tui_win_info)
 367         <make_invisible_and_set_new_height>: New method.
 368
 369 2019-07-17  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui.c: Update.
 372         * tui/tui-source.h (struct tui_source_window): Move from
 373         tui-data.h.
 374         * tui/tui-layout.c: Update.
 375         * tui/tui-disasm.c: Update.
 376         * tui/tui-data.h (struct tui_source_window): Move to
 377         tui-source.h.
 378
 379 2019-07-17  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 382         tui-data.h.
 383         * tui/tui-data.h (struct tui_disasm_window): Move to
 384         tui-disasm.h.
 385
 386 2019-07-17  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-regs.h (struct tui_data_item_window): Move from
 389         tui-data.h.
 390         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 391         * tui/tui-data.h (struct tui_data_item_window): Move to
 392         tui-regs.h.
 393         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 394
 395 2019-07-17  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui.c: Update.
 398         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 399         (tui_cmd_window::max_height): Move to tui-command.c.
 400         * tui/tui-layout.c: Update.
 401         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 402         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 403         tui-command.c.
 404         * tui/tui-command.h (struct tui_cmd_window): Move from
 405         tui-data.h.
 406         * tui/tui-command.c: Remove "structuring" comments.
 407         (tui_cmd_window::clear_detail)
 408         (tui_cmd_window::do_make_visible_with_new_height)
 409         (tui_cmd_window::max_height): Move from elsewhere.
 410
 411 2019-07-17  Tom Tromey  <tom@tromey.com>
 412
 413         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 414         Now static.
 415         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 416         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 417
 418 2019-07-17  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui.c: Update.
 421         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 422         tui-regs.c.
 423         * tui/tui-windata.h: Remove file.
 424         * tui/tui-windata.c: Remove file.
 425         * tui/tui-win.c (tui_data_window::set_new_height)
 426         (tui_data_window::do_make_visible_with_new_height): Move to
 427         tui-regs.c.
 428         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 429         * tui/tui-regs.c: Remove "structuring" comments.
 430         (tui_data_window::first_data_item_displayed)
 431         (tui_data_window::delete_data_content_windows)
 432         (tui_data_window::erase_data_content)
 433         (tui_data_window::display_all_data)
 434         (tui_data_window::refresh_all)
 435         (tui_data_window::do_scroll_vertical)
 436         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 437         (tui_data_window::do_make_visible_with_new_height)
 438         (tui_data_window::refresh_window): Move from elsewhere.
 439         (_initialize_tui_regs): Move to end of file.
 440         * tui/tui-layout.c: Update.
 441         * tui/tui-hooks.c: Update.
 442         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 443         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 444         tui-regs.c.
 445         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 446
 447 2019-07-17  Tom Tromey  <tom@tromey.com>
 448
 449         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 450         seen.
 451
 452 2019-07-17  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-win.c (tui_source_window_base::set_new_height)
 455         (tui_source_window_base::do_make_visible_with_new_height): Use
 456         m_has_locator field directly.
 457         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 458         method.
 459         (struct tui_source_window_base) <has_locator>: Likewise.
 460
 461 2019-07-17  Tom Tromey  <tom@tromey.com>
 462
 463         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 464         Don't declare.
 465         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 466         Remove.
 467         * tui/tui-win.c (tui_source_window_base::set_new_height)
 468         (tui_source_window_base::set_new_height)
 469         (make_invisible_and_set_new_height)
 470         (tui_source_window_base::do_make_visible_with_new_height)
 471         (tui_source_window_base::do_make_visible_with_new_height):
 472         Update.
 473         * tui/tui-layout.c (show_source_disasm_command, show_data)
 474         (show_source_or_disasm_and_command): Update.
 475         * tui/tui-layout.c (show_layout): Update.
 476
 477 2019-07-17  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-layout.c (make_data_window): Remove.
 480         (show_data): Unify creation and re-initialization cases.
 481
 482 2019-07-17  Tom Tromey  <tom@tromey.com>
 483
 484         * tui/tui-layout.c (make_source_window, make_disasm_window):
 485         Remove.
 486         (show_data): Unify creation and re-initialization cases.
 487
 488 2019-07-17  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-layout.c (make_command_window): Remove.
 491         (show_source_disasm_command, show_source_or_disasm_and_command):
 492         Unify creation and re-initialization cases.
 493
 494 2019-07-17  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 497         creation and re-initialization cases.
 498
 499 2019-07-17  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-regs.c (tui_get_register): Return void.
 502
 503 2019-07-17  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 506         Simplify.
 507
 508 2019-07-17  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 511         resetting.
 512
 513 2019-07-17  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 516         * tui/tui-regs.c (tui_reg_layout): New function.
 517         (tui_show_registers, tui_reg_command): Use it.
 518         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 519         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 520         parameters.
 521         (tui_layout_command): Remove.
 522
 523 2019-07-17  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-layout.h (tui/tui-layout): Return void.
 526         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 527
 528 2019-07-17  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-layout.c (show_source_disasm_command, show_data):
 531         Update.
 532         (reset_locator): Remove.
 533         (show_source_or_disasm_and_command): Update.
 534
 535 2019-07-17  Tom Tromey  <tom@tromey.com>
 536
 537         * tui/tui-source.c (tui_source_window_base::reset): Remove
 538         win_type parameter.
 539         * tui/tui-layout.c (make_command_window, make_source_window)
 540         (make_disasm_window, make_data_window)
 541         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 542         (reset_locator, show_source_or_disasm_and_command): Update.
 543         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 544         win_type parameter.
 545         (struct tui_source_window_base) <reset>: Likewise.
 546
 547 2019-07-17  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-layout.c (show_source_disasm_command): Use
 550         reset_locator.
 551         (reset_locator): New function.
 552         (init_and_make_win): Remove.
 553         (show_source_or_disasm_and_command): Use reset_locator.
 554
 555 2019-07-17  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 558         condition.
 559         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 560         Remove condition.
 561         * tui/tui-source.c (tui_source_window_base::reset): New method.
 562         * tui/tui-layout.c (make_command_window): Don't call
 563         init_and_make_win.
 564         (make_source_window, make_disasm_window): Don't call
 565         make_source_or_disasm_window.
 566         (make_data_window): Don't call init_and_make_win.  Change calling
 567         convention.
 568         (show_source_disasm_command, show_data): Simplify.
 569         (make_source_or_disasm_window): Remove.
 570         (show_source_or_disasm_and_command): Simplify.
 571         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 572         (struct tui_source_window_base) <reset>: Likewise.
 573         <execution_info>: Remove initializer.
 574         * tui/tui-data.c (tui_source_window_base): Initialize
 575         execution_info.
 576
 577 2019-07-17  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 580         variable.
 581
 582 2019-07-17  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui.c (tui_rl_other_window): Update.
 585         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 586         superclass method first.  Always iterate over regs_content.
 587         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 588         method.
 589         * tui/tui-win.c (tui_set_focus_command): Update.
 590
 591 2019-07-17  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-win.c (tui_set_focus_command): Rename from
 594         tui_set_focus.  Call tui_enable.
 595         (tui_set_focus_command): Remove.
 596
 597 2019-07-17  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 600         refresh_window.
 601         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 602         touchwin.
 603         (tui_data_window::refresh_window): Call refresh_window on data
 604         items.  Always call superclass refresh_window.
 605         (tui_win_info::refresh): Remove.
 606         (tui_source_window_base::refresh_window): Update.
 607         (tui_refresh_all): Update.
 608         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 609         refresh_window.
 610         (show_source_or_disasm_and_command): Likewise.
 611         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 612         (struct tui_source_window_base) <refresh>: Likewise.
 613
 614 2019-07-17  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-winsource.c (tui_clear_source_content)
 617         (tui_show_source_content): Update.
 618         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 619         whether content is empty.
 620         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 621         Remove.
 622
 623 2019-07-17  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 626         window's contents.
 627         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 628         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 629
 630 2019-07-17  Tom Tromey  <tom@tromey.com>
 631
 632         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 633         (struct tui_data_item_window): Update.
 634
 635 2019-07-17  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 638         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 639         defines.
 640
 641 2019-07-17  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-winsource.h (tui_erase_source_content)
 644         (tui_clear_source_content): Remove "display_prompt" parameter.
 645         * tui/tui-winsource.c (tui_update_source_window_as_is)
 646         (tui_update_source_windows_with_addr): Update.
 647         (tui_clear_source_content): Remove "display_prompt" parameter.
 648         (tui_erase_source_content): Likewise.  Simplify.
 649         (tui_show_source_content): Update.
 650         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 651         * tui/tui-stack.c (tui_show_frame_info): Update.
 652         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 653         Remove defines.
 654
 655 2019-07-17  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 658         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 659         parameter.
 660         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 661         parameter.
 662
 663 2019-07-17  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-winsource.c (tui_clear_source_content)
 666         (tui_show_source_content, tui_show_exec_info_content)
 667         (tui_clear_exec_info_content): Update.
 668         * tui/tui-stack.c (tui_show_locator_content): Update.
 669         (tui_show_frame_info): Update.
 670         * tui/tui-source.h (tui_source_window): Don't declare.
 671         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 672         from tui_source_is_displayed.
 673         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 674         Remove field.
 675         (struct tui_source_window_base) <content_in_use>: New field.  Now
 676         bool.
 677         (struct tui_source_window) <showing_source_p>: New method.
 678         (TUI_SRC_WIN): Change cast.
 679         * tui/tui-data.c (tui_initialize_static_data): Update.
 680
 681 2019-07-17  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 684         location_matches_p.
 685         * tui/tui-source.c (tui_source_window::location_matches_p): New
 686         method.
 687         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 688         method.
 689         * tui/tui-data.h (struct tui_source_window_base)
 690         <location_matches_p>: New method.
 691         (struct tui_source_window, struct tui_disasm_window)
 692         <location_matches_p>: Likewise.
 693
 694 2019-07-17  Tom Tromey  <tom@tromey.com>
 695
 696         * tui/tui-win.c (tui_set_win_height_command): Rename from
 697         tui_set_win_height.
 698         (tui_set_win_height_command): Remove.
 699
 700 2019-07-17  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui-source.c (tui_source_window): New constructor.  Add
 703         observer.
 704         (~tui_source_window): New destructor.
 705         (tui_source_window::style_changed): New method.
 706         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 707         (tui_attach_detach_observers): Update.
 708         * tui/tui-data.h (struct tui_source_window): Make constructor not
 709         inline.  Add destructor.
 710         (struct tui_source_window) <style_changed>: New method.
 711         <m_observable>: New member.
 712
 713 2019-07-17  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 716         * tui/tui-win.c (tui_resize_all): Fix typo.
 717
 718 2019-07-17  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 721         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 722         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 723         * tui/tui-win.c (window_name_completer): Use foreach.
 724         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 725         (update_tab_width): Likewise.
 726         * tui/tui-layout.c (show_layout): Update.
 727         * tui/tui-data.h (class tui_window_iterator): New.
 728         (struct all_tui_windows): New.
 729         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 730
 731 2019-07-17  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 734         parameter.  Don't reference globals.
 735         (tui_reg_command): Update.
 736
 737 2019-07-17  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-regs.c (tui_show_registers): Simplify.
 740
 741 2019-07-17  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui-regs.c (tui_show_registers): Update.
 744         (tui_show_register_group): Add win_info parameter.
 745
 746 2019-07-17  Tom Tromey  <tom@tromey.com>
 747
 748         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 749         Rename from tui_display_reg_element_at_line.
 750         (tui_data_window::display_registers_from_line): Update.
 751         * tui/tui-data.h (struct tui_data_window)
 752         <display_reg_element_at_line>: New method.
 753
 754 2019-07-17  Tom Tromey  <tom@tromey.com>
 755
 756         * tui/tui-regs.h (tui_display_registers_from)
 757         (tui_display_registers_from_line): Don't declare.
 758         * tui/tui-windata.c (tui_data_window::display_all_data)
 759         (tui_data_window::refresh_all)
 760         (tui_data_window::do_scroll_vertical): Update.
 761         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 762         from tui_display_registers_from.
 763         (tui_display_reg_element_at_line): Update.
 764         (tui_data_window::display_registers_from_line): Rename from
 765         tui_display_registers_from_line.
 766         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 767         display_registers_from_line>: New methods.
 768
 769 2019-07-17  Tom Tromey  <tom@tromey.com>
 770
 771         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 772         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 773         from tui_erase_data_content.
 774         (tui_data_window::display_all_data)
 775         (tui_data_window::refresh_all)
 776         (tui_data_window::do_scroll_vertical): Update.
 777         * tui/tui-regs.c (tui_show_registers): Update.
 778         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 779         New method.
 780
 781 2019-07-17  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 784         declare.
 785         * tui/tui-windata.c
 786         (tui_data_window::delete_data_content_windows): Rename from
 787         tui_delete_data_content_windows.
 788         (tui_data_window::display_all_data)
 789         (tui_data_window::do_scroll_vertical): Update.
 790         * tui/tui-data.h (struct tui_data_window)
 791         <delete_data_content_windows>: New method.
 792
 793 2019-07-17  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 796         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 797
 798 2019-07-17  Tom Tromey  <tom@tromey.com>
 799
 800         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 801         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 802         from tui_display_all_data.
 803         * tui/tui-win.c
 804         (tui_data_window::do_make_visible_with_new_height): Update.
 805         * tui/tui-regs.c (tui_show_registers): Update.
 806         * tui/tui-layout.c (tui_set_layout): Update.
 807         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 808         method.
 809
 810 2019-07-17  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 813         * tui/tui-windata.c (tui_display_data_from): Remove.
 814         (tui_data_window::refresh_all): Update.
 815
 816 2019-07-17  Tom Tromey  <tom@tromey.com>
 817
 818         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 819         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 820         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 821         tui_display_registers_from_line.
 822         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 823         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 824         "force_display" parameter.
 825
 826 2019-07-17  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 829         declare.
 830         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 831         Rename from tui_first_reg_element_no_inline.
 832         (tui_display_reg_element_at_line)
 833         (tui_display_registers_from_line): Update.
 834         * tui/tui-data.h (struct tui_data_window)
 835         <first_reg_element_no_inline>: New method.
 836
 837 2019-07-17  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui-windata.c (tui_display_data_from)
 840         (tui_data_window::do_scroll_vertical): Update.
 841         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 842         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 843         Rename from tui_line_from_reg_element_no.
 844         (tui_display_registers_from_line): Update.
 845         * tui/tui-data.h (struct tui_data_window)
 846         <line_from_reg_element_no>: New method.
 847
 848 2019-07-17  Tom Tromey  <tom@tromey.com>
 849
 850         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 851         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 852         tui_last_regs_line_no.
 853         (tui_display_reg_element_at_line)
 854         (tui_display_registers_from_line): Update.
 855         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 856         method.
 857
 858 2019-07-17  Tom Tromey  <tom@tromey.com>
 859
 860         PR tui/24722:
 861         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 862         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 863         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 864         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 865         (tui_update_breakpoint_info): Likewise.
 866         * tui/tui-hooks.c (tui_event_create_breakpoint)
 867         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 868         Update.
 869
 870 2019-07-17  Tom Tromey  <tom@tromey.com>
 871
 872         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 873
 874 2019-07-17  Tom Tromey  <tom@tromey.com>
 875
 876         * tui/tui-winsource.c (tui_update_source_window_as_is)
 877         (tui_update_source_windows_with_addr): Update.
 878         * tui/tui-source.h (tui_set_source_content)
 879         (tui_show_symtab_source): Add "win_info" parameter.
 880         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 881         parameter.
 882         (tui_show_symtab_source): Likewise.
 883
 884 2019-07-17  Tom Tromey  <tom@tromey.com>
 885
 886         * tui/tui-wingeneral.c
 887         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 888
 889 2019-07-17  Tom Tromey  <tom@tromey.com>
 890
 891         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 892         (struct tui_cmd_window) <can_scroll>: New method.
 893         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 894         method.
 895
 896 2019-07-17  Tom Tromey  <tromey@adacore.com>
 897
 898         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 899         do_field_signed>: Rename.  Change type of "value".
 900         * ui-out.c (ui_out::field_signed): Rename from field_int.
 901         Change type of "value".
 902         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 903         type of "value".
 904         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 905         do_field_int.  Change type of "value".
 906         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 907         do_field_int.  Change type of "value".
 908         * tracepoint.c (trace_status_mi, tfind_1)
 909         (print_one_static_tracepoint_marker): Update.
 910         * thread.c (print_thread_info_1, print_selected_thread_frame):
 911         Update.
 912         * stack.c (print_frame, print_frame_info): Update.
 913         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 914         Update.
 915         * source.c (print_source_lines_base): Update.
 916         * skip.c (info_skip_command): Update.
 917         * record-btrace.c (btrace_ui_out_decode_error)
 918         (btrace_call_history_src_line): Update.
 919         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 920         Update.
 921         * progspace.c (print_program_space): Update.
 922         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 923         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 924         do_field_int.  Change type of "value".
 925         * mi/mi-out.c (mi_ui_out::do_table_begin)
 926         (mi_ui_out::do_table_header): Update.
 927         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 928         type of "value".
 929         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 930         (mi_cmd_data_list_changed_registers, output_register)
 931         (mi_cmd_data_read_memory, mi_load_progress)
 932         (mi_cmd_trace_frame_collected): Update.
 933         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 934         Update.
 935         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 936         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 937         (mi_cmd_var_list_children, varobj_update_one): Update.
 938         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 939         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 940         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 941         * inferior.c (print_inferior): Update.
 942         * gdb_bfd.c (print_one_bfd): Update.
 943         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 944         Update.
 945         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 946         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 947         do_field_int.  Change type of "value".
 948         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 949         do_field_int.  Change type of "value".
 950         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 951         (print_one_breakpoint_location, print_it_catch_fork)
 952         (print_one_catch_fork, print_it_catch_vfork)
 953         (print_one_catch_vfork, print_it_catch_solib)
 954         (print_it_catch_exec, print_it_ranged_breakpoint)
 955         (print_mention_watchpoint, print_mention_masked_watchpoint)
 956         (bkpt_print_it, update_static_tracepoint): Update.
 957         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 958         * break-catch-syscall.c (print_it_catch_syscall): Update.
 959         * ada-tasks.c (print_ada_task_info): Update.
 960         * ada-lang.c (print_it_exception, print_mention_exception):
 961         Update.
 962
 963 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 964
 965         PR breakpoints/24541
 966         * gdbarch.c: Regenerate.
 967         * gdbarch.h: Regenerate.
 968         * gdbarch.sh: Adjust return type and parameter types for
 969         'stap_adjust_register'.
 970         (i386_stap_adjust_register): Adjust signature and return new
 971         register name.
 972         * stap-probe.c (stap_parse_register_operand): Adjust use of
 973         'gdbarch_stap_adjust_register'.
 974
 975 2019-07-17  Tom Tromey  <tromey@adacore.com>
 976
 977         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 978         declare VEC.
 979         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 980         std::vector.
 981         (struct s390_process_info): Add initializers.
 982         (s390_add_process): Use new.
 983         (s390_linux_nat_target::low_forget_process): Use delete.
 984         (s390_linux_nat_target::low_new_fork)
 985         (s390_linux_nat_target::stopped_by_watchpoint)
 986         (s390_linux_nat_target::low_prepare_to_resume)
 987         (s390_linux_nat_target::insert_watchpoint)
 988         (s390_linux_nat_target::insert_hw_breakpoint)
 989         (s390_linux_nat_target::remove_watchpoint)
 990         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 991
 992 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 993
 994         * aarch64-fbsd-nat.c: Include regcache.h.
 995         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 996         argument.
 997         (aarch64_fbsd_nat_target::fetch_registers)
 998         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 999         variable.
1000         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1001
1002 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1003
1004         * fbsd-nat.c: Include gdbarch.h.
1005
1006 2019-07-15  Tom Tromey  <tromey@adacore.com>
1007
1008         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1009
1010 2019-07-15  Tom Tromey  <tromey@adacore.com>
1011
1012         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1013         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1014         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1015         * cli-out.c (cli_ui_out::do_field_int): New method.
1016         * ui-out.c (ui_out::field_unsigned): New method.
1017         * symfile.c (generic_load): Use field_unsigned.
1018         (print_transfer_performance): Likewise.
1019         * record-btrace.c (ui_out_field_uint): Remove.
1020         (btrace_call_history_insn_range, btrace_call_history): Use
1021         field_unsigned.
1022         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1023         field_unsigned.
1024         * ui-out.h (class ui_out) <field_unsigned>: New method.
1025         <do_field_unsigned>: Likewise.
1026
1027 2019-07-15  Tom Tromey  <tromey@adacore.com>
1028
1029         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1030         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1031         * target.c (flash_erase_command): Use field_string.
1032         * infrun.c (print_signal_received_reason): Use field_string.
1033         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1034         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1035         field_string.
1036         * ada-tasks.c (print_ada_task_info): Use field_string.
1037
1038 2019-07-15  Tom Tromey  <tromey@adacore.com>
1039
1040         * target.c (flash_erase_command): Use field_core_addr.
1041         * symfile.c (generic_load): Use field_core_addr.
1042         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1043         Use field_core_addr.
1044         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1045         field_core_addr.
1046
1047 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1048
1049         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1050         value if its desired type is smaller than a CORE_ADDR and signed.
1051
1052 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1053
1054         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1055         of changes to field names, and use new is_reference field to
1056         decide if a property is a reference or not.
1057         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1058         field.
1059         (struct dwarf2_property_baton): Update header comment, rename
1060         'referenced_type' to 'property_type' and update comments.
1061         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1062         default property type, store in property baton, update to take
1063         accound of renamed field.
1064         (read_func_scope): Update call to attr_to_dynamic_prop.
1065         (read_array_type): Likewise.
1066         (dwarf2_per_cu_addr_sized_int_type): New function.
1067         (read_subrange_index_type): Move type finding code to
1068         dwarf2_per_cu_addr_sized_int_type.
1069         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1070         (dwarf2_per_cu_addr_type): New function.
1071         (set_die_type): Update calls to attr_to_dynamic_prop.
1072
1073 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * dwarf2read.c (read_subrange_index_type): New function.
1076         (read_subrange_type): Move code into new function and call it.
1077         * gdbtypes.c (create_range_type): Add some asserts.
1078
1079 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1080
1081         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1082         update return statements.
1083         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1084         declaration, and update comment to match.
1085         * gdbtypes.c (resolve_dynamic_array): Update call to
1086         dwarf2_evaluate_property to match new return type.
1087
1088 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1089
1090         * valarith.c (value_subscripted_rvalue): Change lowerbound
1091         parameter type from int to LONGEST.
1092         * value.h (value_subscripted_rvalue): Likewise in declaration.
1093
1094 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * cli/cli-utils.c (info_print_command_completer): New function.
1097         * cli/cli-utils.h: Add 'completer.h' include, and forward
1098         declaration for 'struct cmd_list_element'.
1099         (info_print_command_completer): Declare.
1100         * stack.c (_initialize_stack): Add completer for 'info locals' and
1101         'info args'.
1102         * symtab.c (_initialize_symtab): Add completer for 'info
1103         variables' and 'info functions'.
1104         * NEWS: Mention completion for additional info commands.
1105
1106 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1107
1108         * cli/cli-utils.c (extract_info_print_args): Delete.
1109         (extract_arg_maybe_quoted): Delete.
1110         (info_print_options_defs): New variable.
1111         (make_info_print_options_def_group): New function.
1112         (extract_info_print_options): Define new function.
1113         * cli/cli-utils.h (extract_info_print_args): Delete.
1114         (struct info_print_options): New structure.
1115         (extract_info_print_options): Declare new function.
1116         * stack.c (info_locals_command): Update to use new
1117         extract_info_print_options, also add a header comment.
1118         (info_args_command): Likewise.
1119         * symtab.c (info_variables_command): Likewise.
1120         (info_functions_command): Likewise.
1121
1122 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1123
1124         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1125         to extract string arguments.
1126         * common/common-utils.c (extract_string_maybe_quoted): New function.
1127         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1128
1129 2019-07-11  Tom Tromey  <tromey@adacore.com>
1130
1131         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1132         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1133         * top.h (gdbinit): Don't declare.
1134         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1135         into...
1136         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1137         * top.c (gdb_init): Don't call init_cli_cmds.
1138         (gdbinit): Remove.
1139         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1140
1141 2019-07-11  Tom Tromey  <tromey@adacore.com>
1142
1143         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1144         after it has been moved.
1145
1146 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1147
1148         * valops.c (value_must_coerce_to_target): Change return type to
1149         bool.
1150         * value.h (value_must_coerce_to_target): Likewise.
1151
1152 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1153
1154         * breakpoint.c (is_hardware_watchpoint): Remove
1155         forward-declaration.
1156         (is_masked_watchpoint): Change return type to bool.
1157         (is_tracepoint): Likewise.
1158         (is_breakpoint): Likewise.
1159         (is_hardware_watchpoint): Likewise.
1160         (is_watchpoint): Likewise.
1161         (is_no_memory_software_watchpoint): Likewise.
1162         (is_catchpoint): Likewise.
1163         (breakpoint_1): Make FILTER parameter's return type bool.
1164         is_masked_watchpoint): Change return type to bool.
1165         (save_breakpoints): Make FILTER parameter's return type bool.
1166         * breakpoint.h (is_breakpoint): Change return type to bool.
1167         (is_watchpoint): Likewise.
1168         (is_catchpoint): Likewise.
1169         (is_tracepoint): Likewise.
1170
1171 2019-07-10  Tom Tromey  <tom@tromey.com>
1172
1173         * defs.h: Don't include gdbarch.h.
1174         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1175         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1176         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1177         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1178         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1179         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1180         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1181         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1182         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1183         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1184         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1185         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1186         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1187         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1188         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1189         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1190         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1191         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1192         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1193         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1194         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1195         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1196         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1197         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1198         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1199         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1200         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1201
1202 2019-07-10  Tom Tromey  <tromey@adacore.com>
1203
1204         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1205         * breakpoint.c (init_ada_exception_breakpoint): Register as
1206         bp_catchpoint.
1207         (print_one_breakpoint_location, print_one_breakpoint): Use
1208         is_ada_exception_catchpoint.
1209         * ada-lang.c (class ada_catchpoint_location): Pass
1210         bp_loc_software_breakpoint to bp_location constructor.
1211         (is_ada_exception_catchpoint): New function.
1212
1213 2019-07-10  Tom Tromey  <tromey@adacore.com>
1214
1215         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1216         VEC.
1217         (struct arm_exidx_entry): New method operator<.
1218         (struct arm_exidx_data) <section_maps>: Change type.
1219         (arm_exidx_data_free): Remove.
1220         (arm_exidx_data_key): Change type.  Move lower.
1221         (arm_exidx_new_objfile): Update.
1222         (arm_compare_exidx_entries): Remove.
1223         (arm_find_exidx_entry, _initialize_arm_tdep)
1224
1225 2019-07-10  Tom Tromey  <tromey@adacore.com>
1226
1227         * solib-spu.c (ocl_program_data_key): Change type.
1228         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1229         Update.
1230
1231 2019-07-10  Tom Tromey  <tromey@adacore.com>
1232
1233         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1234         (struct solib_aix_inferior_data) <library_list>: Change type.
1235         (solib_aix_inferior_data_handle): Change type.
1236         (get_solib_aix_inferior_data): Update.
1237         (solib_aix_free_library_list): Remove.
1238         (library_list_start_library): Update.
1239         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1240         return type.
1241         (solib_aix_get_library_list)
1242         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1243         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1244
1245 2019-07-10  Tom Tromey  <tromey@adacore.com>
1246
1247         * solib-dsbt.c (struct dsbt_info): Add initializers.
1248         (solib_dsbt_pspace_data): Change type.
1249         (dsbt_pspace_data_cleanup): Remove.
1250         (get_dsbt_info, _initialize_dsbt_solib): Update.
1251
1252 2019-07-10  Tom Tromey  <tromey@adacore.com>
1253
1254         * spu-tdep.c (spu_overlay_data): Change type.
1255         (spu_get_overlay_table, spu_overlay_new_objfile)
1256         (_initialize_spu_tdep): Update.
1257
1258 2019-07-10  Tom Tromey  <tromey@adacore.com>
1259
1260         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1261         destructor.
1262         (dbx_objfile_data_key): Change type and declare later.
1263         (DBX_SYMFILE_INFO): Rewrite.
1264         * dbxread.c (dbx_objfile_data_key): Change type.
1265         (dbx_symfile_init): Update.
1266         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1267         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1268         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1269
1270 2019-07-10  Tom Tromey  <tromey@adacore.com>
1271
1272         * jit.c (jit_program_space_key): Change type.  Move lower.
1273         (get_jit_program_space_data): Update.
1274         (jit_program_space_data_cleanup): Remove.
1275         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1276         Update.
1277         (struct jit_program_space_data): Add initializers.
1278
1279 2019-07-10  Tom Tromey  <tromey@adacore.com>
1280
1281         * solib-darwin.c (struct darwin_info): Add initializers.
1282         (solib_darwin_pspace_data): Change type.
1283         (darwin_pspace_data_cleanup): Remove.
1284         (get_darwin_info, _initialize_darwin_solib): Update.
1285
1286 2019-07-10  Tom Tromey  <tromey@adacore.com>
1287
1288         * remote-sim.c (struct sim_inferior_data): Add initializers,
1289         constructor, and destructor.
1290         (sim_inferior_data_key): Change type.  Move lower.
1291         (check_for_duplicate_sim_descriptor): Update.
1292         (get_sim_inferior_data): Use new.  Update.
1293         (~sim_inferior_data_cleanup): Rename from
1294         sim_inferior_data_cleanup.  Simplify.
1295         (gdbsim_close_inferior, simulator_command)
1296         (sim_command_completer, _initialize_remote_sim): Update.
1297         (next_pid, INITIAL_PID): Move earlier.
1298
1299 2019-07-10  Tom Tromey  <tromey@adacore.com>
1300
1301         * python/python-internal.h (create_thread_object): Return
1302         gdbpy_ref.
1303         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1304         * python/py-inferior.c (struct threadlist_entry): Add
1305         constructor.
1306         <thread_obj>: Now a gdbpy_ref.
1307         (thread_to_thread_object): Update.
1308         (add_thread_object): Use new.
1309         (delete_thread_object): Use delete.
1310         (infpy_threads): Update.
1311         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1312         GIL.
1313
1314 2019-07-10  Tom Tromey  <tromey@adacore.com>
1315
1316         * valops.c (value_cast): Specialize error message for Ada.
1317
1318 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1319
1320         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1321
1322 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1323
1324         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1325         bpstat_should_step): Return bool, adjust comments.
1326         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1327         bpstat_should_step): Likewise.
1328
1329 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1330
1331         * features/Makefile: Use feature target descriptions for Arm.
1332         * features/arm/arm-core.c: Generate new file.
1333         * features/arm/arm-fpa.c: Likewise.
1334         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1335         * features/arm/arm-m-profile.c: Likewise.
1336         * features/arm/arm-vfpv2.c: Likewise.
1337         * features/arm/arm-vfpv3.c: Likewise.
1338         * features/arm/xscale-iwmmxt.c: Likewise.
1339         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1340
1341 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1342
1343         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1344         ptrace earlier.
1345
1346 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1347
1348         * features/aarch64-pauth.c: Regenerate.
1349
1350 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1351
1352         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1353         bool.
1354         (bpstat_what): Use false instead of 0.
1355
1356 2019-07-09  Pedro Alves  <palves@redhat.com>
1357
1358         * break-catch-throw.c (is_exception_catchpoint): New.
1359         * breakpoint.c (print_one_breakpoint_location): New parameter
1360         'raw_loc'.  Handle it.  Use
1361         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1362         looking at the breakpoint's type.
1363         (print_one_breakpoint): If handling "maint info breakpoints", also
1364         print locations of exception catchpoints.
1365         * breakpoint.h (is_exception_catchpoint): Declare.
1366
1367 2019-07-09  Pedro Alves  <palves@redhat.com>
1368
1369         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1370         "addr" field.
1371         (allocate_location_exception_catchpoint): New.
1372         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1373         (initialize_throw_catchpoint_ops): Install
1374         allocate_location_exception_catchpoint as allocate_location
1375         method.
1376         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1377         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1378         bp_loc_other.
1379         (breakpoint_address_is_meaningful): Delete.
1380         (bl_address_is_meaningful): New.
1381         (breakpoint_locations_match): Adjust comment.
1382         (bp_location_from_bp_type): New, factored out of...
1383         (bp_location::bp_location(breakpoint *)): ... this.
1384         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1385         factored out of...
1386         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1387         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1388         breakpoint_address_is_meaningful.
1389         (bp_locations_compare): Adjust comment.
1390         (update_global_location_list): Use bl_address_is_meaningful
1391         instead of breakpoint_address_is_meaningful.
1392         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1393         explicit.
1394         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1395         * python/py-breakpoint.c (bppy_get_location): No longer check
1396         whether location is null.
1397
1398 2019-07-09  Pedro Alves  <palves@redhat.com>
1399
1400         PR c++/15468
1401         * breakpoint.c (print_one_breakpoint_location): Remove
1402         single-location assert.
1403
1404 2019-07-09  Tom Tromey  <tom@tromey.com>
1405
1406         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1407         * configure: Rebuild.
1408         * configure.ac: Change common to gdbsupport.
1409         * gdbsupport: Rename from common.
1410         * acinclude.m4: Change common to gdbsupport.
1411         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1412         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1413         gdbsupport.
1414         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1415         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1416         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1417         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1418         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1419         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1420         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1421         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1422         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1423         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1424         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1425         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1426         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1427         coff-pe-read.c, command.h, compile/compile-c-support.c,
1428         compile/compile-c.h, compile/compile-cplus-symbols.c,
1429         compile/compile-cplus-types.c, compile/compile-cplus.h,
1430         compile/compile-loc2c.c, compile/compile.c, completer.c,
1431         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1432         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1433         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1434         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1435         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1436         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1437         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1438         features/aarch64-core.c, features/aarch64-fpu.c,
1439         features/aarch64-pauth.c, features/aarch64-sve.c,
1440         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1441         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1442         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1443         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1444         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1445         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1446         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1447         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1448         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1449         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1450         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1451         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1452         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1453         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1454         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1455         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1456         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1457         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1458         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1459         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1460         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1461         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1462         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1463         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1464         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1465         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1466         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1467         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1468         minsyms.c, mips-linux-tdep.c, namespace.h,
1469         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1470         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1471         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1472         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1473         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1474         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1475         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1476         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1477         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1478         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1479         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1480         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1481         procfs.c, producer.c, progspace.h, psymtab.h,
1482         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1483         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1484         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1485         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1486         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1487         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1488         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1489         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1490         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1491         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1492         target-memory.c, target.c, target.h, target/waitstatus.c,
1493         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1494         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1495         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1496         unittests/array-view-selftests.c,
1497         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1498         unittests/common-utils-selftests.c,
1499         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1500         unittests/format_pieces-selftests.c,
1501         unittests/function-view-selftests.c,
1502         unittests/lookup_name_info-selftests.c,
1503         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1504         unittests/mkdir-recursive-selftests.c,
1505         unittests/observable-selftests.c,
1506         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1507         unittests/parse-connection-spec-selftests.c,
1508         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1509         unittests/scoped_fd-selftests.c,
1510         unittests/scoped_mmap-selftests.c,
1511         unittests/scoped_restore-selftests.c,
1512         unittests/string_view-selftests.c, unittests/style-selftests.c,
1513         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1514         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1515         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1516         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1517         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1518         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1519
1520 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1521
1522         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1523         bool value.
1524         (decode_digits_ordinary): Set explicit_line field in sal.
1525         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1526         symtab_and_line that was set on an explicit line number in
1527         assembler code.  Do always update the recorded symtab and line if
1528         we do skip the prologue.
1529
1530 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1531
1532         * breakpoint.c (set_breakpoint_location_function): Remove
1533         explicit_loc parameter.
1534         (momentary_breakpoint_from_master): Update call to
1535         set_breakpoint_location_function.
1536         (add_location_to_breakpoint): Likewise.
1537
1538 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1539
1540         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1541         required features based on default bfd type when no specific bfd
1542         is present.
1543
1544 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1545
1546         * NEWS: Mention that GDB printf and eval commands can now print
1547         C-style and Ada-style convenience var strings without
1548         calling the inferior.
1549         * printcmd.c (printf_c_string): Locally print GDB internal var
1550         instead of transiting via the inferior.
1551         (printf_wide_c_string): Likewise.
1552
1553 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1554
1555         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1556
1557 2019-07-04  Tom Tromey  <tom@tromey.com>
1558
1559         PR tui/24724:
1560         * tui/tui-winsource.c (tui_clear_source_content): Update.
1561         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1562         (tui_update_breakpoint_info): Update.
1563         (tui_set_exec_info_content): Update.
1564         * tui/tui-source.c (tui_set_source_content_nil): Update.
1565         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1566         has_break.
1567         * tui/tui-data.h (enum tui_bp_flag): New.
1568         (tui_bp_flags): New enum flags type.
1569         (struct tui_source_element) <break_mode>: Change type.  Rename
1570         from has_break.
1571         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1572         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1573         constants.
1574         * tui/tui-winsource.h: Fix comment.
1575
1576 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1577
1578         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1579         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1580         (store_fpregs_to_thread)
1581         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1582         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1583         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1584         (IWMMXT_REGS_SIZE): Add define.
1585         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1586         (fetch_vfp_regs, store_vfp_regs)
1587         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1588         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1589
1590 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1591
1592         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1593         defines.
1594         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1595         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1596         (ARM_INT_REGISTER_SIZE): ...to this.
1597         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1598         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1599         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1600         (arm_linux_collect_gregset, supply_nwfpe_register)
1601         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1602         defines.
1603         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1604         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1605         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1606         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1607         (arm_return_in_memory, arm_store_return_value)
1608         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1609         (arm_record_ld_st_multiple): Likewise.
1610         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1611         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1612
1613 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1614
1615         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1616         AARCH64_DISPLACED_MODIFIED_INSNS.
1617         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1618         (aarch64_displaced_step_copy_insn): Likewise.
1619         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1620         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1621         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1622         ARM_DISPLACED_MODIFIED_INSNS.
1623         * arm-tdep.c (arm_gdbarch_init): Likewise.
1624         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1625         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1626         (struct arm_displaced_step_closure): Use
1627         ARM_DISPLACED_MODIFIED_INSNS.
1628
1629 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1630
1631         * features/Makefile: Remove unused xml files.
1632         * features/aarch64.xml: Remove.
1633         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1634         * features/i386/amd64-avx-avx512.xml: Remove.
1635         * features/i386/amd64-avx-linux.xml: Remove.
1636         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1637         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1638         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1639         * features/i386/amd64-avx-mpx.xml: Remove.
1640         * features/i386/amd64-avx.xml: Remove.
1641         * features/i386/amd64-linux.xml: Remove.
1642         * features/i386/amd64-mpx-linux.xml: Remove.
1643         * features/i386/amd64-mpx.xml: Remove.
1644         * features/i386/amd64.xml: Remove.
1645         * features/i386/i386-avx-avx512-linux.xml: Remove.
1646         * features/i386/i386-avx-avx512.xml: Remove.
1647         * features/i386/i386-avx-linux.xml: Remove.
1648         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1649         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1650         * features/i386/i386-avx-mpx-linux.xml: Remove.
1651         * features/i386/i386-avx-mpx.xml: Remove.
1652         * features/i386/i386-avx.xml: Remove.
1653         * features/i386/i386-linux.xml: Remove.
1654         * features/i386/i386-mmx-linux.xml: Remove.
1655         * features/i386/i386-mmx.xml: Remove.
1656         * features/i386/i386-mpx-linux.xml: Remove.
1657         * features/i386/i386-mpx.xml: Remove.
1658         * features/i386/i386.xml: Remove.
1659         * features/i386/x32-avx-avx512-linux.xml: Remove.
1660         * features/i386/x32-avx-linux.xml: Remove.
1661         * features/i386/x32-linux.xml: Remove.
1662
1663 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1664
1665         * regformats/aarch64.dat: Remove.
1666         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1667         * regformats/i386/amd64-avx-linux.dat: Remove.
1668         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1669         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1670         * regformats/i386/amd64-linux.dat: Remove.
1671         * regformats/i386/amd64-mpx-linux.dat: Remove.
1672         * regformats/i386/amd64.dat: Remove.
1673         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1674         * regformats/i386/i386-avx-linux.dat: Remove.
1675         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1676         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1677         * regformats/i386/i386-linux.dat: Remove.
1678         * regformats/i386/i386-mmx-linux.dat: Remove.
1679         * regformats/i386/i386-mpx-linux.dat: Remove.
1680         * regformats/i386/i386.dat: Remove.
1681         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1682         * regformats/i386/x32-avx-linux.dat: Remove.
1683         * regformats/i386/x32-linux.dat: Remove.
1684
1685 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1686
1687         * aarch64-tdep.c: Remove xml self tests.
1688         * amd64-linux-tdep.c: Likewise.
1689         * amd64-tdep.c: Likewise.
1690         * i386-linux-tdep.c: Likewise.
1691         * i386-tdep.c: Likewise.
1692
1693 2019-07-03  Pedro Alves  <palves@redhat.com>
1694
1695         PR cli/24732
1696         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1697         (pipe_cmd_option_defs): New.
1698         (make_pipe_cmd_options_def_group): New.
1699         (pipe_command): Use gdb::option::process_options.
1700         (pipe_command_completer): New function.
1701         (_initialize_cli_cmds): Install completer for "pipe" command.
1702
1703 2019-07-03  Pedro Alves  <palves@redhat.com>
1704
1705         * cli/cli-option.c (union option_value) <string>: New field.
1706         (struct option_def_and_value): Add ctor, move ctor, dtor and
1707         use DISABLE_COPY_AND_ASSIGN.
1708         (option_def_and_value::clear_value): New.
1709         (parse_option, save_option_value_in_ctx, get_val_type_str)
1710         (add_setshow_cmds_for_options): Handle var_string.
1711         * cli-option.h (union option_def::var_address) <string>: New
1712         field.
1713         (struct string_option_def): New.
1714         * maint-test-options.c (struct test_options_opts): Add default
1715         ctor and use DISABLE_COPY_AND_ASSIGN.
1716         <string_opt>: New field.
1717         (test_options_opts::~test_options_opts): New.
1718         (test_options_opts::dump): Also dump "-string".
1719         (test_options_option_defs): Install "string.
1720
1721 2019-07-03  Pedro Alves  <palves@redhat.com>
1722
1723         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1724         option_value with a null enumeration.
1725         (complete_options): Save the option values in the context.
1726         (save_option_value_in_ctx): New, factored out from ...
1727         (process_options): ... here.
1728         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1729         of the function.
1730         * maint-test-options.c (test_options_opts::dump): New, factored
1731         out from ...
1732         (maintenance_test_options_command_mode): ... here.
1733         (maintenance_test_options_command_completion_result): Delete.
1734         (maintenance_test_options_command_completion_text): Update
1735         comment.
1736         (maintenance_show_test_options_completion_result): Change
1737         prototype.  Just print
1738         maintenance_test_options_command_completion_text.
1739         (save_completion_result): New.
1740         (maintenance_test_options_completer_mode): Pass options context to
1741         complete_options, and then save a dump.
1742         (_initialize_maint_test_options): Use add_cmd to install "maint
1743         show test-options-completion-result".
1744
1745 2019-07-03  Pedro Alves  <palves@redhat.com>
1746
1747         * NEWS (New commands): Mention "with" and "maint with".
1748         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1749         (with_command, with_command_completer): New.
1750         (pipe_command): Adjust to new repeat_previous
1751         interface.
1752         (_initialize_cli_cmds): Install the "with" command and its "w"
1753         alias.
1754         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1755         declarations.
1756         * cli/cli-setshow.c (parse_cli_var_uinteger)
1757         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1758         argument strings for all var_types.
1759         (get_setshow_command_value_string): New, factored out from ...
1760         (do_show_command): ... this.
1761         * cli/cli-setshow.h: Include <string>.
1762         (get_setshow_command_value_string): Declare.
1763         * command.h (repeat_previous): Now returns const char *.  Adjust
1764         comment.
1765         * maint.c: Include "cli/cli-cmds.h".
1766         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1767         (_initialize_maint_cmds): Register the "maintenance with" command.
1768         * top.c (repeat_previous): Move bits from pipe_command here:
1769         Return the saved command line, if any; error out if there's no
1770         command to relaunch.
1771
1772 2019-07-03  Pedro Alves  <palves@redhat.com>
1773
1774         * NEWS (New commands): Mention "maint set/show test-settings"
1775         instead of "maint test-settings".
1776         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1777         (maintenance_test_settings_set_list): Rename to ...
1778         (maintenance_set_test_settings_list): ... this.
1779         (maintenance_test_settings_show_list): Rename to  ...
1780         (maintenance_show_test_settings_list): ... this.
1781         (maintenance_test_settings_cmd): Delete.
1782         (maintenance_test_settings_set_cmd): ...
1783         (maintenance_set_test_settings_cmd): ... this.
1784         (maintenance_test_settings_show_cmd): ...
1785         (maintenance_show_test_settings_cmd): ... this.
1786         (maintenance_test_settings_show_value_cmd):
1787         (maintenance_show_test_settings_value_cmd): ... this.
1788         (_initialize_maint_test_settings): No longer install the "maint
1789         test-settings" prefix command.  Rename "maint test-settings set"
1790         to "maint set test-settings", and "maint test-settings show" to
1791         "maint show test-settings".  Adjust all subcommands.
1792
1793 2019-07-03  Pedro Alves  <palves@redhat.com>
1794
1795         * maint-test-settings.c: Fix file's intro comment.  Replace all
1796         references to "test-options" with references to "test-settings",
1797         in comments.
1798
1799 2019-07-03  Pedro Alves  <palves@redhat.com>
1800
1801         * maint-test-settings.c (maintenance_test_settings_xxx)
1802         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1803         New.
1804         (maintenance_test_settings_enums): Use them.
1805         (maintenance_test_settings_enum): Default to
1806         maintenance_test_settings_xxx.
1807         (_initialize_maint_test_settings): Initialize
1808         MAINTENANCE_TEST_SETTINGS_FILENAME.
1809
1810 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1811
1812         * breakpoint.h (remove_breakpoints_inf): Change return type to
1813         void, move function documentation here.
1814         * breakpoint.c (remove_breakpoints_inf): Change return type to
1815         void, move function documentation to header.
1816
1817 2019-07-02  Pedro Alves  <palves@redhat.com>
1818
1819         * NEWS (Completion improvements): Mention "info threads".
1820         * thread.c (struct info_threads_opts, info_threads_option_defs)
1821         (make_info_threads_options_def_group): New.
1822         (info_threads_command): Use gdb::option::process_options.
1823         (info_threads_command_completer): New.
1824         (_initialize_thread): Use gdb::option::build_help to build the
1825         help text for "info threads".
1826
1827 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1828
1829         * defs.h (generic_load): Move from here...
1830         * symfile.h (generic_load): ... to here.  Rename name parameter
1831         to args.
1832         * symfile.c (generic_load): Add comment.
1833
1834 2019-07-01  Tom Tromey  <tromey@adacore.com>
1835
1836         * dwarf2read.c
1837         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1838         declaration of without_params.  Fix formatting.
1839
1840 2019-07-01  Tom Tromey  <tromey@adacore.com>
1841
1842         * ada-exp.y (find_primitive_type): Update.
1843         * ada-lang.h (ada_lookup_symbol): Update.
1844         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1845         parameter.
1846         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1847
1848 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1849
1850         PR breakpoints/24541
1851         * gdbarch.c: Regenerate.
1852         * gdbarch.h: Regenerate.
1853         * gdbarch.sh: Add 'stap_adjust_register'.
1854         * i386-tdep.c: Include '<unordered_set>'.
1855         (i386_stap_adjust_register): New function.
1856         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1857         * stap-probe.c (stap_parse_register_operand): Call
1858         'gdbarch_stap_adjust_register'.
1859
1860 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1861
1862         PR python/24742
1863         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1864         * python/python.c (do_start_initialization): Use 'xmalloc'
1865         instead of 'PyMem_Malloc'.
1866
1867 2019-06-28  Tom Tromey  <tromey@adacore.com>
1868
1869         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1870         for Ada.
1871
1872 2019-06-27  Tom Tromey  <tromey@adacore.com>
1873
1874         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1875         objfile_key.
1876         (arm_find_mapping_symbol, arm_record_special_symbol)
1877         (_initialize_arm_tdep): Update.
1878         (arm_objfile_data_free): Remove.
1879
1880 2019-06-27  Tom Tromey  <tromey@adacore.com>
1881
1882         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1883         to cp_print_static_field.
1884
1885 2019-06-26  Tom Tromey  <tromey@adacore.com>
1886
1887         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1888         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1889         declare.
1890
1891 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1892
1893         * features/aarch64-core.c (create_feature_aarch64_core):
1894         Regenerate.
1895         * features/aarch64-core.xml: Add cpsr flags.
1896
1897 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1898
1899         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1900         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1901
1902 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1903
1904         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1905         field.
1906         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1907         use.
1908         (arm_record_special_symbol): Don't insert new symbol in sorted
1909         position, push it at the end.
1910
1911 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1912
1913         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1914         (arm_mapping_symbol_s): Remove.
1915         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1916         (arm_mapping_symbol_vec): New typedef.
1917         (struct arm_per_objfile): Add constructor.
1918         <section_maps>: Change type to
1919         std::unique_ptr<arm_mapping_symbol_vec[]>.
1920         (arm_compare_mapping_symbols): Remove.
1921         (arm_find_mapping_symbol): Adjust to section_maps type change.
1922         (arm_objfile_data_free): Call delete on arm_per_objfile.
1923         (arm_record_special_symbol): Adjust to section_maps type change.
1924         Allocate arm_per_objfile with new.
1925
1926 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1927
1928         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1929         with the command prefix.
1930
1931 2019-06-25  Tom Tromey  <tom@tromey.com>
1932
1933         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1934         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1935
1936 2019-06-25  Tom Tromey  <tom@tromey.com>
1937
1938         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1939         type.
1940         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1941         protected.
1942
1943 2019-06-25  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-winsource.c
1946         (tui_source_window_base::set_is_exec_point_at): Add check against
1947         LOA_ADDRESS.
1948
1949 2019-06-25  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-source.c (tui_set_source_content): Don't check before
1952         xfree.
1953         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1954
1955 2019-06-25  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-winsource.h (tui_update_source_window_as_is)
1958         (tui_alloc_source_buffer, tui_line_is_displayed)
1959         (tui_addr_is_displayed): Change type of win_info.
1960         * tui/tui-winsource.c (tui_update_source_window_as_is)
1961         (tui_clear_source_content, tui_show_source_line)
1962         (tui_show_source_content, tui_source_window_base::refill)
1963         (tui_source_window_base::set_is_exec_point_at)
1964         (tui_source_window_base::set_is_exec_point_at)
1965         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1966         (tui_alloc_source_buffer, tui_line_is_displayed)
1967         (tui_addr_is_displayed): Change type of win_info.  Update.
1968         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1969         (tui_source_window_base::do_make_visible_with_new_height):
1970         Update.
1971         * tui/tui-source.c (tui_set_source_content)
1972         (tui_set_source_content_nil)
1973         (tui_source_window::do_scroll_vertical): Update.
1974         * tui/tui-layout.c (show_layout): Update.
1975         * tui/tui-disasm.c (tui_set_disassem_content)
1976         (tui_disasm_window::do_scroll_vertical): Update.
1977         * tui/tui-data.h (tui_win_content): Remove.
1978         (struct tui_gen_win_info) <content, content_size>: Remove.
1979         (struct tui_source_element): Add initializers and destructor.
1980         (union tui_which_element, struct tui_win_element): Remove.
1981         (struct tui_source_window_base) <content>: New field.
1982         (struct tui_data_window): Remove destructor.
1983         (tui_alloc_content, tui_free_win_content)
1984         (tui_free_all_source_wins_content): Don't declare.
1985         * tui/tui-data.c (tui_initialize_static_data): Update.
1986         (init_content_element, tui_alloc_content): Remove.
1987         (~tui_gen_win_info): Update.
1988         (~tui_data_window, tui_free_all_source_wins_content)
1989         (tui_free_win_content, free_content, free_content_elements):
1990         Remove.
1991
1992 2019-06-25  Tom Tromey  <tom@tromey.com>
1993
1994         * tui/tui-winsource.h (tui_clear_source_content)
1995         (tui_erase_source_content, tui_show_source_content): Change type
1996         of win_info.
1997         * tui/tui-winsource.c (tui_clear_source_content)
1998         (tui_erase_source_content, tui_show_source_content): Change type
1999         of win_info.
2000         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2001         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2002         win_info.
2003         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2004         win_info.
2005         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2006
2007 2019-06-25  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-winsource.c (tui_clear_source_content)
2010         (tui_source_window_base::set_is_exec_point_at): Update.
2011         * tui/tui-source.c (tui_set_source_content_nil): Update.
2012         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2013         a bool.
2014         * tui/tui-data.c (init_content_element): Update.
2015
2016 2019-06-25  Tom Tromey  <tom@tromey.com>
2017
2018         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2019         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2020         * tui/tui-layout.c (init_and_make_win): Update.
2021         * tui/tui.h (enum tui_win_type): Update.
2022         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2023         tui_win_is_auxillary.
2024         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2025         tui_win_is_auxillary.
2026
2027 2019-06-25  Tom Tromey  <tom@tromey.com>
2028
2029         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2030         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2031         (tui_delete_data_content_windows, tui_display_all_data)
2032         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2033         Update.
2034         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2035         * tui/tui-regs.c (tui_last_regs_line_no)
2036         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2037         (tui_show_registers): Update.
2038         (tui_show_register_group): Return void.  Update.
2039         (tui_display_registers_from, tui_display_reg_element_at_line)
2040         (tui_display_registers_from_line, tui_check_register_values):
2041         Update.
2042         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2043         member.
2044         (struct tui_data_window) <regs_content>: Now a std::vector.
2045         <regs_content_count>: Remove.
2046         (tui_add_content_elements, tui_free_data_content): Don't declare.
2047         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2048         (init_content_element): Remove DATA_WIN case.  Add assert.
2049         (tui_add_content_elements): Remove.
2050         (tui_data_window): Update.
2051         (tui_free_data_content): Remove.
2052         (free_content_elements): Remove DATA_WIN case.
2053
2054 2019-06-25  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-data.c (tui_data_item_window): Update.
2057         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2058         * tui/tui-windata.c (tui_display_all_data)
2059         (tui_display_data_from_line): Update.
2060         (tui_check_data_values): Remove.
2061         * tui/tui-regs.c (tui_show_register_group)
2062         (tui_display_reg_element_at_line): Update.
2063         * tui/tui-hooks.c (tui_register_changed)
2064         (tui_refresh_frame_and_register_information): Call
2065         tui_check_register_values.
2066         * tui/tui-data.h (struct tui_data_window) <data_content,
2067         data_content_count, data_type>: Remove.
2068         (enum tui_data_type): Remove.
2069
2070         * tui/tui-data.c (tui_data_window::clear_detail)
2071         (~tui_data_window): Update.
2072
2073 2019-06-25  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2076         declare.
2077         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2078         Rename from tui_first_data_item_displayed.  Update.
2079         (tui_data_window::refresh_all)
2080         (tui_data_window::do_scroll_vertical): Update.
2081         * tui/tui-data.h (struct tui_data_window)
2082         <first_data_item_displayed>: Declare new method.
2083
2084 2019-06-25  Tom Tromey  <tom@tromey.com>
2085
2086         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2087         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2088         contents...
2089         (tui_initialize_static_data): ...here.
2090
2091 2019-06-25  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2094         (tui_display_registers_from, tui_check_register_values): Update.
2095         (tui_display_register): Remove win_info parameter; update.
2096         (tui_get_register): Change type of parameters.
2097         * tui/tui-data.h (struct tui_data_element): Remove.
2098         (union tui_which_element) <data>: Remove.
2099         <data_window>: Change type.
2100         (struct tui_data_item_window): New.
2101         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2102         case.  Add assert.
2103         (~tui_data_item_window): New destructor.
2104         (free_content_elements): Remove DATA_ITEM_WIN case.
2105
2106 2019-06-25  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2109         Remove.
2110
2111 2019-06-25  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-data.h (struct tui_command_element): Remove.
2114         (union tui_which_element) <command>: Remove.
2115         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2116         assert.
2117         (free_content_elements): Remove CMD_WIN case.
2118
2119 2019-06-25  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-layout.c (tui_set_layout): Update.
2122         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2123         * tui/tui-data.c (layout_def): Update.
2124
2125 2019-06-25  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2128         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2129         (tui_source_window_base::set_new_height): Update.
2130         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2131         Update.
2132         (tui_set_locator_fullname, tui_set_locator_info)
2133         (tui_show_frame_info): Update.
2134         * tui/tui-source.c (tui_set_source_content)
2135         (tui_source_is_displayed): Update.
2136         * tui/tui-layout.c (show_source_disasm_command, show_data)
2137         (show_source_or_disasm_and_command): Update.
2138         * tui/tui-disasm.c (tui_set_disassem_content)
2139         (tui_get_begin_asm_address): Update.
2140         * tui/tui-data.h (struct tui_locator_element): Remove.
2141         (union tui_which_element) <locator>: Remove.
2142         (struct tui_locator_window): New.
2143         (tui_locator_win_info_ptr): Change return type.
2144         * tui/tui-data.c (_locator): Change type.
2145         (tui_locator_win_info_ptr): Change return type.
2146         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2147         (tui_alloc_content): Add assert.
2148
2149 2019-06-25  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-winsource.c
2152         (tui_exec_info_window::maybe_allocate_content): New method.
2153         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2154         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2155         (make_source_or_disasm_window): Add cast.
2156         * tui/tui-data.h (union tui_which_element) <simple_string>:
2157         Remove.
2158         (struct tui_source_info): New.
2159         (struct tui_source_window_base) <execution_info>: Change type.
2160         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2161         case, and add assert.
2162         (tui_alloc_content): Add assert.
2163
2164 2019-06-25  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2167         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2168         * tui/tui-data.c (tui_alloc_win_info): Remove.
2169
2170 2019-06-25  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2173         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2174         can_highlight.
2175
2176 2019-06-25  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2179         make_visible_with_new_height method.
2180         (tui_win_info::make_visible_with_new_height): New method.
2181         (tui_source_window_base::do_make_visible_with_new_height)
2182         (tui_data_window::do_make_visible_with_new_height)
2183         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2184         (make_visible_with_new_height): Remove.
2185         (tui_resize_all, tui_adjust_win_heights): Use
2186         make_visible_with_new_height method.
2187         * tui/tui-data.h (struct tui_win_info)
2188         <do_make_visible_with_new_height, make_visible_with_new_height>:
2189         New methods.
2190         (struct tui_source_window_base, struct tui_data_window)
2191         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2192         methods.
2193
2194 2019-06-25  Tom Tromey  <tom@tromey.com>
2195
2196         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2197         method.
2198         (update_tab_width): Call update_tab_width method.
2199         * tui/tui-data.h (struct tui_win_info)
2200         (struct tui_source_window_base) <update_tab_width>: New methods.
2201
2202 2019-06-25  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2205         parameter.
2206         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2207         parameter.
2208         (tui_gen_win_info::make_visible): Update.
2209         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2210         parameter.
2211         * tui/tui-data.h (enum tui_box): New enum.
2212         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2213
2214 2019-06-25  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2217         init_and_make_win for EXEC_INFO_WIN.
2218         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2219         longer inline.
2220         (struct tui_win_info) <~tui_win_info>: Inline.
2221         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2222         Don't declare.
2223         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2224         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2225         Remove.
2226         (tui_initialize_static_data): Update.
2227         (~tui_gen_win_info): Handle more cleanup here.
2228         (~tui_source_window_base): Delete "execution_info".
2229         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2230
2231 2019-06-25  Tom Tromey  <tom@tromey.com>
2232
2233         * tui/tui-layout.c (make_command_window): Don't set
2234         can_highlight.
2235         (show_source_disasm_command): Call the reset method.
2236         (show_data): Don't set can_highlight.  Call the reset method.
2237         (tui_gen_win_info::reset): Rename from init_gen_win_info
2238         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2239         (show_source_or_disasm_and_command): Call the reset method.
2240         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2241         (struct tui_cmd_window): Set can_highlight.
2242
2243 2019-06-25  Tom Tromey  <tom@tromey.com>
2244
2245         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2246         from make_visible.
2247         (tui_make_visible, tui_make_invisible): Rewrite.
2248         (tui_win_info::make_visible): Remove.
2249         (tui_source_window_base::make_visible): Update.
2250         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2251         method.  Moved from...
2252         (struct tui_win_info) <make_visible>: ...here.
2253
2254 2019-06-25  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-winsource.c
2257         (tui_source_window_base::do_scroll_horizontal): Remove direction
2258         parameter.
2259         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2260         direction parameter.
2261         * tui/tui-win.c (tui_win_info::forward_scroll)
2262         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2263         (tui_win_info::right_scroll): Update.
2264         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2265         direction parameter.
2266         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2267         direction parameter.
2268         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2269         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2270         Remove direction parameter.
2271         (struct tui_source_window_base, struct tui_source_window)
2272         (struct tui_disasm_window, struct tui_data_window)
2273         (struct tui_cmd_window): Update.
2274
2275 2019-06-25  Tom Tromey  <tom@tromey.com>
2276
2277         * tui/tui-winsource.h (tui_set_exec_info_content)
2278         (tui_show_exec_info_content, tui_erase_exec_info_content)
2279         (tui_clear_exec_info_content, tui_update_exec_info): Change
2280         argument to tui_source_window_base.
2281         * tui/tui-winsource.c (tui_set_exec_info_content)
2282         (tui_show_exec_info_content, tui_erase_exec_info_content)
2283         (tui_clear_exec_info_content, tui_update_exec_info): Change
2284         argument to tui_source_window_base.
2285
2286 2019-06-25  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2289         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2290
2291 2019-06-25  Tom Tromey  <tom@tromey.com>
2292
2293         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2294         check.
2295
2296 2019-06-25  Tom Tromey  <tom@tromey.com>
2297
2298         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2299         type to void.
2300         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2301         type to void.
2302         * tui/tui-source.c (tui_set_source_content): Update.
2303         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2304
2305 2019-06-25  Tom Tromey  <tom@tromey.com>
2306
2307         * tui/tui-win.c (window_name_completer, tui_set_focus)
2308         (tui_all_windows_info): Use name method.
2309         * tui/tui-data.h (struct tui_gen_win_info)
2310         (struct tui_source_window, struct tui_disasm_window)
2311         (struct tui_data_window, struct tui_cmd_window) <name>: New
2312         method.
2313         (tui_win_name): Don't declare.
2314         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2315         (tui_win_name): Remove.
2316
2317 2019-06-25  Tom Tromey  <tom@tromey.com>
2318
2319         * tui/tui-winsource.h (tui_update_source_window)
2320         (tui_update_source_window_as_is): Change parameter type.
2321         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2322         to be a tui_source_window_base.
2323         (tui_update_source_window_as_is): Likewise.
2324         * tui/tui-win.c (make_visible_with_new_height): Update.
2325
2326 2019-06-25  Tom Tromey  <tom@tromey.com>
2327
2328         * tui/tui-winsource.c (tui_erase_source_content)
2329         (tui_show_source_content, tui_show_exec_info_content)
2330         (tui_erase_exec_info_content): Use refresh_window method.
2331         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2332         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2333         from tui_refresh_win.
2334         (tui_data_window::refresh_window): New method.
2335         (tui_win_info::refresh, tui_source_window_base::refresh)
2336         (tui_refresh_all): Use refresh_window method.
2337         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2338         method.
2339         * tui/tui-regs.c (tui_display_register): Call refresh_window
2340         method.
2341         * tui/tui-layout.c (show_source_disasm_command)
2342         (show_source_or_disasm_and_command): Call refresh_window method.
2343         * tui/tui-data.h (struct tui_gen_win_info)
2344         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2345         New method.
2346
2347 2019-06-25  Tom Tromey  <tom@tromey.com>
2348
2349         * tui/tui.c (tui_rl_other_window, tui_enable)
2350         (tui_is_window_visible, tui_get_command_dimension): Update.
2351         * tui/tui-winsource.c (tui_update_source_window_as_is)
2352         (tui_clear_source_content, tui_erase_source_content)
2353         (tui_show_source_line, tui_source_window_base::refill)
2354         (tui_source_window_base::do_scroll_horizontal)
2355         (tui_source_window_base::set_is_exec_point_at)
2356         (tui_update_breakpoint_info, tui_set_exec_info_content)
2357         (tui_alloc_source_buffer, tui_line_is_displayed)
2358         (tui_addr_is_displayed): Update.
2359         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2360         (tui_check_and_display_highlight_if_needed)
2361         (tui_win_info::make_visible, tui_win_info::refresh)
2362         (tui_refresh_all): Update.
2363         * tui/tui-windata.c (tui_first_data_item_displayed)
2364         (tui_delete_data_content_windows, tui_erase_data_content)
2365         (tui_display_all_data, tui_data_window::refresh_all)
2366         (tui_check_data_values): Update.
2367         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2368         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2369         (tui_win_info::backward_scroll, tui_refresh_all_win)
2370         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2371         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2372         (tui_source_window_base::set_new_height)
2373         (tui_data_window::set_new_height)
2374         (make_invisible_and_set_new_height)
2375         (make_visible_with_new_height, new_height_ok)
2376         (parse_scrolling_args): Update.
2377         * tui/tui-stack.c (tui_show_frame_info): Update.
2378         * tui/tui-source.c (tui_set_source_content)
2379         (tui_set_source_content_nil, tui_source_is_displayed)
2380         (tui_source_window::do_scroll_vertical): Update.
2381         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2382         (tui_display_registers_from, tui_display_reg_element_at_line)
2383         (tui_check_register_values, tui_reg_command): Update.
2384         * tui/tui-layout.c (tui_default_win_height)
2385         (show_source_disasm_command, show_data, init_and_make_win)
2386         (show_source_or_disasm_and_command): Update.
2387         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2388         (tui_redisplay_readline, tui_mld_flush)
2389         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2390         (tui_getc): Update.
2391         * tui/tui-disasm.c (tui_set_disassem_content)
2392         (tui_disasm_window::do_scroll_vertical): Update.
2393         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2394         Now virtual.
2395         (struct tui_win_info): Derive from tui_gen_win_info.
2396         <~tui_win_info>: Mark as override.
2397         <generic>: Remove member.
2398         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2399         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2400         (~tui_data_window, ~tui_win_info)
2401         (tui_free_all_source_wins_content): Update.
2402         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2403
2404 2019-06-25  Tom Tromey  <tom@tromey.com>
2405
2406         * tui/tui-layout.c (init_and_make_win): Use new.
2407         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2408         destructor, initializers.
2409         (tui_alloc_generic_win_info): Don't declare.
2410         * tui/tui-data.c (_locator): Add argument to constructor.
2411         (source_win, disasm_win): New globals.
2412         (exec_info): Remove.
2413         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2414         Update.
2415         (tui_alloc_generic_win_info): Remove.
2416         (init_content_element): Use new.
2417         (tui_win_info::tui_win_info): Update.
2418         (free_content_elements) <case DATA_WIN>: Use delete.
2419
2420 2019-06-25  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2423         * tui/tui-windata.c (tui_first_data_item_displayed)
2424         (tui_delete_data_content_windows): Update.
2425         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2426         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2427         (tui_display_registers_from, tui_check_register_values): Update.
2428         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2429         pointer.
2430         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2431         window.
2432         (tui_free_data_content): Update.
2433         (free_content_elements) <case DATA_WIN>: Free the window.
2434
2435 2019-06-25  Tom Tromey  <tom@tromey.com>
2436
2437         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2438         Update.
2439         * tui/tui-layout.c (make_command_window)
2440         (show_source_disasm_command, show_data, init_and_make_win)
2441         (show_source_or_disasm_and_command): Update.
2442         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2443         method.
2444         <can_highight, is_highlighted>: Now bool.
2445         (tui_set_win_highlight): Don't declare.
2446         * tui/tui-data.c (tui_set_win_highlight): Remove.
2447
2448 2019-06-25  Tom Tromey  <tom@tromey.com>
2449
2450         * tui/tui-wingeneral.c (make_visible): Remove check of window
2451         type.
2452
2453 2019-06-25  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui-win.c (tui_win_info::max_height)
2456         (tui_cmd_window::max_height): New methods.
2457         (new_height_ok): Call max_height.
2458         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2459         <max_height>: New method.
2460
2461 2019-06-25  Tom Tromey  <tom@tromey.com>
2462
2463         * tui/tui-win.c (tui_source_window_base::set_new_height)
2464         (tui_data_window::set_new_height): New methods.
2465         (make_invisible_and_set_new_height): Call set_new_height method.
2466         * tui/tui-data.h (struct tui_win_info)
2467         (struct tui_source_window_base, struct tui_data_window)
2468         <set_new_height>: New method.
2469
2470 2019-06-25  Tom Tromey  <tom@tromey.com>
2471
2472         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2473         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2474         tui_refresh_data_win.
2475         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2476         method.
2477         (tui_refresh_all_win): Call the refresh_all method.
2478         (tui_set_focus): Likewise.
2479         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2480         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2481         Likewise.
2482
2483 2019-06-25  Tom Tromey  <tom@tromey.com>
2484
2485         * tui/tui-winsource.h (tui_refill_source_window)
2486         (tui_set_is_exec_point_at): Don't declare.
2487         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2488         (tui_source_window_base::refill): Rename from
2489         tui_refill_source_window.
2490         (tui_source_window_base::do_scroll_horizontal): Update.
2491         (tui_source_window_base::set_is_exec_point_at): Rename from
2492         tui_set_is_exec_point_at.
2493         (tui_update_all_breakpoint_info): Update.
2494         * tui/tui-stack.c (tui_show_frame_info): Update.
2495         * tui/tui-layout.c (show_data): Add cast.
2496         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2497         * tui/tui-data.h (struct tui_source_window_base) <refill,
2498         set_is_exec_point_at>: New methods.
2499         (tui_source_windows, tui_add_to_source_windows): Update types.
2500         (tui_add_to_source_windows): Remove redundant declaration.
2501         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2502         (tui_source_windows): Change return type.
2503         (tui_clear_source_windows_detail): Update.
2504         (tui_add_to_source_windows): Change type of parameter.
2505         (tui_free_all_source_wins_content): Update.
2506
2507 2019-06-25  Tom Tromey  <tom@tromey.com>
2508
2509         * tui/tui-wingeneral.c (tui_win_info::refresh)
2510         (tui_source_window_base::refresh): New methods.
2511         (tui_refresh_all): Call the refresh method.
2512         * tui/tui-data.h (struct tui_win_info)
2513         (struct tui_source_window_base) <refresh>: New method.
2514
2515 2019-06-25  Tom Tromey  <tom@tromey.com>
2516
2517         * tui/tui.h (tui_is_window_visible): Return bool.
2518         * tui/tui.c (tui_is_window_visible): Return bool.
2519         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2520         (tui_make_visible, tui_make_invisible)
2521         (tui_win_info::make_visible)
2522         (tui_source_window_base::make_visible, make_all_visible)
2523         (tui_make_all_visible, tui_make_all_invisible): Update.
2524         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2525         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2526         bool.
2527         (struct tui_win_info, struct tui_source_window_base)
2528         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2529         * tui/tui-data.c (tui_init_generic_part): Update.
2530
2531 2019-06-25  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2534         (tui_source_window_base::make_visible): New methods.
2535         (make_all_visible): Make method call.
2536         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2537         (struct tui_source_window_base, struct tui_cmd_window): Override
2538         make_visible.
2539         (tui_win_is_source_type): Don't declare.
2540         * tui/tui-data.c (tui_win_is_source_type): Remove.
2541
2542 2019-06-25  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2545         NULL check.
2546
2547 2019-06-25  Tom Tromey  <tom@tromey.com>
2548
2549         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2550         Inline constructor.  Add initializers for members.
2551         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2552         constructors; now inline in class.
2553
2554 2019-06-25  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-regs.c (tui_show_registers): Update.
2557         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2558         bool.
2559         * tui/tui-data.c (tui_data_window::clear_detail)
2560         (tui_data_window): Update.
2561
2562 2019-06-25  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-windata.c (tui_display_all_data)
2565         (tui_display_data_from_line, tui_display_data_from)
2566         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2567         Update.
2568         * tui/tui-regs.c (tui_last_regs_line_no)
2569         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2570         (tui_show_registers, tui_show_register_group)
2571         (tui_display_registers_from, tui_display_reg_element_at_line)
2572         (tui_display_registers_from_line, tui_check_register_values)
2573         (tui_reg_next, tui_reg_prev): Update.
2574         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2575         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2576         tui_data_window.
2577         (struct tui_win_info) <detail>: Remove.  Add new fields from
2578         tui_data_info.
2579         (TUI_DATA_WIN): Add cast.
2580         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2581         (~tui_data_window): Simplify.
2582
2583 2019-06-25  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-layout.c (show_source_disasm_command)
2586         (show_source_or_disasm_and_command): Update.
2587         * tui/tui-io.c (update_cmdwin_start_line)
2588         (tui_redisplay_readline): Update.
2589         * tui/tui-data.h (struct tui_command_info): Remove.
2590         (struct tui_win_info) <detail>: Remove command_info member.
2591         (struct tui_data_window) <start_line>: New member, from
2592         tui_command_info.
2593         (TUI_CMD_WIN): Add casts.
2594
2595 2019-06-25  Tom Tromey  <tom@tromey.com>
2596
2597         * tui/tui-winsource.c (tui_update_source_window)
2598         (tui_refill_source_window)
2599         (tui_source_window_base::do_scroll_horizontal)
2600         (tui_update_breakpoint_info, tui_set_exec_info_content)
2601         (tui_show_exec_info_content, tui_erase_exec_info_content)
2602         (tui_clear_exec_info_content): Update.
2603         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2604         Update.
2605         * tui/tui-win.c (make_invisible_and_set_new_height)
2606         (make_visible_with_new_height): Update.
2607         * tui/tui-source.c (tui_set_source_content)
2608         (tui_show_symtab_source): Update.
2609         * tui/tui-layout.c (extract_display_start_addr)
2610         (show_source_disasm_command, show_data)
2611         (make_source_or_disasm_window)
2612         (show_source_or_disasm_and_command): Update.
2613         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2614         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2615         "gdbarch".
2616         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2617         to tui_source_window_base.
2618         (struct tui_win_info) <detail>: Remove source_info member.
2619         (struct tui_source_window_base) <has_locator>: Inline.
2620         Move contents from tui_source_info; rename has_locator member to
2621         m_has_locator.
2622         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2623         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2624         header file.
2625         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2626         Simplify.
2627         (tui_free_all_source_wins_content): Cast to
2628         tui_source_window_base.
2629
2630 2019-06-25  Tom Tromey  <tom@tromey.com>
2631
2632         * tui/tui-win.c (make_invisible_and_set_new_height)
2633         (make_visible_with_new_height): Call has_locator method.
2634         * tui/tui-layout.c (show_source_disasm_command, show_data)
2635         (show_source_or_disasm_and_command): Update for bool change.
2636         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2637         (tui_win_info) <has_locator>: New method.
2638         (struct tui_source_window_base) <has_locator>: New method.
2639         (tui_win_has_locator): Don't declare.
2640         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2641         from tui_win_has_locator.
2642         (tui_source_window_base): Use false, not FALSE.
2643
2644 2019-06-25  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2647         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2648         clear_detail method directly.
2649         (tui_clear_win_detail): Remove.
2650
2651 2019-06-25  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2654         "this", not TUI_DISASM_WIN.
2655
2656 2019-06-25  Tom Tromey  <tom@tromey.com>
2657
2658         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2659         declare.
2660         * tui/tui-winsource.c
2661         (tui_source_window_base::do_scroll_horizontal): Rename from
2662         tui_horizontal_source_scroll.
2663         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2664         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2665         from tui_vertical_data_scroll.
2666         * tui/tui-win.h (tui_scroll): Don't declare.
2667         * tui/tui-win.c (tui_win_info::forward_scroll)
2668         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2669         (tui_win_info::right_scroll): Rename and update.
2670         (tui_scroll_forward_command, tui_scroll_backward_command)
2671         (tui_scroll_left_command, tui_scroll_right_command): Update.
2672         (tui_scroll): Remove.
2673         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2674         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2675         from tui_vertical_source_scroll.
2676         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2677         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2678         from tui_vertical_disassem_scroll.
2679         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2680         do_scroll_horizontal>: New methods.
2681         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2682         Likewise.
2683         (struct tui_source_window_base): Add do_scroll_horizontal.
2684         (struct tui_source_window, struct tui_disasm_window): Add
2685         do_scroll_vertical.
2686         (struct tui_data_window, struct tui_cmd_window): Add
2687         do_scroll_horizontal and do_scroll_vertical.
2688         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2689
2690 2019-06-25  Tom Tromey  <tom@tromey.com>
2691
2692         * tui/tui-data.h (struct tui_source_window_base): New struct.
2693         (struct tui_source_window): Derive from tui_source_window_base.
2694         (struct tui_disasm_window): New struct.
2695         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2696         from tui_source_window::clear_detail.
2697         (tui_source_window_base): Rename from tui_source_window.
2698         (~tui_source_window_base): Rename from ~tui_source_window.
2699         (tui_alloc_win_info): Create a tui_disasm_window.
2700
2701 2019-06-25  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-data.h (struct tui_source_window)
2704         (struct tui_data_window): Declare destructors.
2705         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2706         destructors.
2707         (tui_win_info): Simplify.
2708
2709 2019-06-25  Tom Tromey  <tom@tromey.com>
2710
2711         * tui/tui-winsource.c (tui_display_main)
2712         (tui_update_source_windows_with_addr)
2713         (tui_update_all_breakpoint_info): Update.
2714         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2715         (new_height_ok, parse_scrolling_args): Update.
2716         * tui/tui-stack.c (tui_show_frame_info): Update.
2717         * tui/tui-data.h (struct tui_list): Remove.
2718         (tui_source_windows): Return a reference to a std::vector.
2719         * tui/tui-data.c (source_windows): Now a std::vector.
2720         (tui_source_windows): Change return type.
2721         (tui_clear_source_windows): Rewrite.
2722         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2723         (tui_free_all_source_wins_content): Rewrite.
2724
2725 2019-06-25  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2728         (struct tui_data_window, struct tui_cmd_window): Declare
2729         clear_detail method.
2730         * tui/tui-data.c (tui_source_window::clear_detail)
2731         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2732         methods.
2733         (tui_clear_win_detail): Simplify.
2734
2735 2019-06-25  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-layout.c (make_source_window, make_disasm_window)
2738         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2739         Return the new window.
2740         (show_source_disasm_command, show_data)
2741         (show_source_or_disasm_and_command): Update.
2742
2743 2019-06-25  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2746         parameter.  Return the new window.
2747         (show_source_disasm_command): Update and remove NULL check.
2748         (show_source_or_disasm_and_command): Update.
2749
2750 2019-06-25  Tom Tromey  <tom@tromey.com>
2751
2752         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2753
2754 2019-06-25  Tom Tromey  <tom@tromey.com>
2755
2756         * tui/tui-data.h (struct tui_win_info): Make constructor
2757         protected.  Make destructor virtual.  Add initializers.
2758         (tui_source_window, tui_data_window, tui_cmd_window): New
2759         classes.
2760         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2761         constructor.  Add "type" parameter.
2762         (tui_source_window, tui_data_window, tui_cmd_window): New
2763         constructors.
2764         (tui_alloc_win_info): Instantiate the appropriate subclass.
2765
2766 2019-06-25  Tom Tromey  <tom@tromey.com>
2767
2768         * tui/tui-win.c (tui_resize_all): Use delete.
2769         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2770         destructor.
2771         (tui_free_window): Don't declare.
2772         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2773         Update.
2774
2775 2019-06-25  Tom Tromey  <tom@tromey.com>
2776
2777         * tui/tui-data.h (struct tui_win_info): Add constructor.
2778         * tui/tui-data.c (tui_alloc_win_info): Use new.
2779         (tui_free_window): Use delete.
2780
2781 2019-06-22  Tom Tromey  <tom@tromey.com>
2782
2783         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2784         declare.
2785         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2786
2787 2019-06-22  Tom Tromey  <tom@tromey.com>
2788
2789         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2790         declare.
2791         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2792
2793 2019-06-22  Tom de Vries  <tdevries@suse.de>
2794
2795         * dwarf2read.c (create_addrmap_from_aranges)
2796         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2797         instead of '%zu'.
2798
2799 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2800
2801         * dwarf2read.h (dwarf2_section_info_def): Remove.
2802         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2803         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2804         std::vector<dwarf2_section_info>.
2805         (struct dwo_file) <~dwo_file>: Remove.
2806         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2807         types field.
2808         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2809         (dwarf2_read_debug_names): Likewise.
2810         (create_debug_types_hash_table): Change parameter type to
2811         array_view, adjust code accordingly.
2812         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2813         (partial_die_info::fixup): Likewise.
2814         (determine_prefix): Likewise.
2815         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2816
2817 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2818
2819         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2820         gdb_bfd_ref_ptr.
2821         <~dwo_file>: Remove call to gdb_bfd_unref.
2822         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2823         gdb_bfd_ref_ptr::get.
2824
2825 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2826
2827         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2828         type to htab_up.
2829         * dwarf2read.c (struct dwo_file): Initialize fields.
2830         <~dwo_file>: New.
2831         (free_dwo_file): Remove, move content to ~dwo_file.
2832         (struct dwo_file_deleter): Remove.
2833         (dwo_file_up>: Remove custom deleter.
2834         (free_dwo_files): Remove.
2835         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2836         dwo_files.
2837         (process_skeletonless_type_units): Call unique_ptr::get.
2838         (allocate_dwo_file_hash_table): Add deleter to created hash
2839         table.  Change return type to htab_up.
2840         (lookup_dwo_file_slot): Don't memset dwo_file, call
2841         unique_ptr::get.
2842         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2843         (create_dwo_unit_in_dwp_v2): Likewise.
2844         (open_and_init_dwo_file): Likewise.
2845         (free_dwo_file_from_slot): Remove.
2846
2847 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2848
2849         * dwarf2read.h (struct dwarf2_section_info) <readin,
2850         is_virtual>: Change type to bool.
2851         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2852         true instead of 1.
2853
2854 2019-06-19  Tom Tromey  <tom@tromey.com>
2855
2856         * tui/tui-data.h (tui_init_content_element): Don't declare.
2857
2858 2019-06-19  Tom Tromey  <tom@tromey.com>
2859
2860         * tui/tui-data.h (tui_init_win_info): Don't declare.
2861
2862 2019-06-19  Tom de Vries  <tdevries@suse.de>
2863
2864         * dwarf2read.h (abstract_to_concrete): Change type to
2865         std::unordered_map<sect_offset, std::vector<sect_offset>,
2866         gdb::hash_enum<sect_offset>>.
2867
2868 2019-06-19  Tom Tromey  <tromey@adacore.com>
2869
2870         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2871         EVAL_AVOID_SIDE_EFFECTS specially.
2872
2873 2019-06-19  Tom Tromey  <tromey@adacore.com>
2874
2875         * source-cache.c (highlighter): New global.
2876         (source_cache::get_source_lines): Create a highlighter on demand.
2877
2878 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2879
2880         * defs.h (deprecated_interactive_hook): Delete declaration.
2881         * interps.c (clear_interpreter_hooks): Remove use of
2882         deprecated_interactive_hook.
2883         * top.c (deprecated_interactive_hook): Delete definition.
2884         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2885
2886 2019-06-18  Tom de Vries  <tdevries@suse.de>
2887
2888         PR gdb/24515
2889         * dwarf2read.h (abstract_to_concrete): Change type from
2890         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2891         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2892         * dwarf2read.c (read_variable): Update.
2893         (dwarf2_fetch_die_loc_sect_off): Update.
2894
2895 2019-06-17  Tom de Vries  <tdevries@suse.de>
2896
2897         PR gdb/24617
2898         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2899         accessing parent[parent_len - 1].
2900
2901 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2902
2903         PR gdb/24364
2904         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2905         call dtrace_process_dof with NULL dof.
2906
2907 2019-06-16  Tom de Vries  <tdevries@suse.de>
2908
2909         PR gdb/24445
2910         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2911
2912 2019-06-16  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2915         (make_all_visible): Use address of member.
2916
2917 2019-06-16  Tom Tromey  <tom@tromey.com>
2918
2919         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2920         (tui_free_window, free_content, free_content_elements): Remove
2921         unnecessary cast.
2922         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2923         cast.
2924         * tui/tui-regs.c (tui_show_register_group)
2925         (tui_display_registers_from, tui_display_reg_element_at_line):
2926         Remove unnecessary cast.
2927
2928 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2929
2930         * linux-nat.c (normal_mask): Delete.
2931         (_initialize_linux_nat): Don't initialise normal_mask.
2932
2933 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2934
2935         PR gdb/24445
2936         * dwarf-index-write.h (write_psymtabs_to_index): Add
2937         dwz_basename parameter.
2938         * dwarf-index-write.c (write_gdbindex): Move file writing to
2939         write_gdbindex_1.  Change return type void.
2940         (assert_file_size): Move up, remove filename parameter.
2941         (write_gdbindex_1): New function.
2942         (write_debug_names): Change return type to void, call
2943         assert_file_size.
2944         (struct index_wip_file): New struct.
2945         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2946         file logic to index_wip_file.  Write index for dwz file if
2947         needed.
2948         (save_gdb_index_command): Pass basename of dwz file, if present.
2949         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2950         build-id of dwz file, if present.
2951         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2952         (dwarf2_get_dwz_file): Likewise.
2953         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2954         (dwarf2_get_dwz_file): Likewise.
2955
2956 2019-06-16  Tom Tromey  <tom@tromey.com>
2957
2958         * coffread.c (process_coff_symbol): Use xstrdup.
2959         * value.c (create_internalvar): Use xstrdup.
2960
2961 2019-06-16  Tom Tromey  <tom@tromey.com>
2962
2963         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2964         * breakpoint.c (stopin_command, stopat_command)
2965         (until_break_command, decode_location_default): Remove unnecessary
2966         cast.
2967         * utils.c (subset_compare): Remove unnecessary cast.
2968         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2969         cast.
2970         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2971         cast.
2972         * infcmd.c (path_command): Remove unnecessary cast.
2973         * coffread.c (decode_type): Remove unnecessary cast.
2974         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2975         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2976         * tui/tui-stack.c (tui_show_locator_content)
2977         (tui_show_frame_info): Remove unnecessary cast.
2978         * tui/tui-win.c (tui_scroll_forward_command)
2979         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2980         (parse_scrolling_args): Remove unnecessary cast.
2981         * tui/tui-data.c (init_win_info, tui_del_window)
2982         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2983         (free_content_elements): Remove unnecessary cast.
2984         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2985         unnecessary cast.
2986         * tui/tui-source.c (tui_set_source_content)
2987         (tui_vertical_source_scroll): Remove unnecessary cast.
2988         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2989         cast.
2990         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2991         * tui/tui-regs.c (tui_display_registers_from)
2992         (tui_display_register): Remove unnecessary cast.
2993         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2994         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2995         (make_visible): Remove unnecessary cast.
2996         * tui/tui-winsource.c (tui_erase_source_content)
2997         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2998         unnecessary cast.
2999         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3000         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3001         * stabsread.c (read_type, read_array_type, read_range_type):
3002         Remove unnecessary cast.
3003         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3004         (parse_symbol, parse_type, upgrade_type, parse_external)
3005         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3006         unnecessary cast.
3007         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3008
3009 2019-06-16  Tom Tromey  <tom@tromey.com>
3010
3011         * tui/tui-data.c (tui_alloc_generic_win_info)
3012         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3013         checks.
3014
3015 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3016             Andrew Burgess  <andrew.burgess@embecosm.com>
3017
3018         * f-typeprint.c (f_print_type): Don't return early for not
3019         associated or not allocated types.
3020         (f_type_print_varspec_suffix): Add print_rank parameter and print
3021         ranks of array types in case they dangling.
3022         (f_type_print_base): Add print_rank parameter.
3023
3024 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3025
3026         * NEWS: Mention new MI commands.
3027         * break-catch-throw.c (enum exception_event_kind): Move to
3028         breakpoint.h.
3029         (print_mention_exception_catchpoint): Output text as a single
3030         message.
3031         (catch_exception_command_1): Rename to...
3032         (catch_exception_event): ...this, make non-static, update header
3033         command, and change some parameter types.
3034         (catch_catch_command): Update for changes to
3035         catch_exception_command_1.
3036         (catch_throw_command): Likewise.
3037         (catch_rethrow_command): Likewise.
3038         * breakpoint.c (enum exception_event_kind): Delete.
3039         * breakpoint.h (enum exception_event_kind): Moved here from
3040         break-catch-throw.c.
3041         (catch_exception_event): Declare.
3042         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3043         (mi_cmd_catch_throw): New function.
3044         (mi_cmd_catch_rethrow): New function.
3045         (mi_cmd_catch_catch): New function.
3046         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3047         'catch-catch' entries.
3048         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3049         (mi_cmd_catch_rethrow): Declare.
3050         (mi_cmd_catch_catch): Declare.
3051
3052 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3053
3054         * annotate.c (annotate_source_line): Change return type to void,
3055         update implementation to match.
3056         * annotate.h (annotate_source_line): Change return type to void,
3057         update header comment.
3058         * stack.c (print_frame_info): Don't change what frame information
3059         is printed based on whether annotations are on or not.
3060
3061 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3062
3063         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3064         (annotate_source): Make static.
3065         (annotate_source_line): Moved from source.c and renamed from
3066         identify_source_line.  Update the return type.
3067         * annotate.h (annotate_source): Delete declaration.
3068         (annotate_source_line): Declaration moved from source.h, and
3069         renamed from identify_source_line.  Return type updated.
3070         * source.c (identify_source_line): Moved to annotate.c and renamed
3071         to annotate_source_line.
3072         (info_line_command): Remove check of annotation_level.
3073         * source.h (identify_source_line): Move declaration to annotate.h
3074         and rename to annotate_source_line.
3075         * stack.c: Add 'annotate.h' include.
3076         (print_frame_info): Remove check of annotation_level before
3077         calling annotate_source_line.
3078
3079 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3080
3081         * source-cache.c (source_cache::get_plain_source_lines): Use
3082         open_source_file_with_line_charpos instead of just
3083         open_source_file, remove call to find_source_lines.
3084         (source_cache::get_source_lines): Likewise.
3085         * source.c (find_source_lines): Make static.
3086         (get_filename_and_charpos): Renamed into...
3087         (open_source_file_with_line_charpos): ..this along with changes to
3088         return a scoped_fd, and some other minor clean ups.
3089         (identify_source_line): Use open_source_file_with_line_charpos.
3090         (search_command_helper): Use open_source_file_with_line_charpos
3091         instead of just open_source_file, remove call to
3092         find_source_lines.
3093         * source.h (open_source_file_with_line_charpos): Declare new
3094         function.
3095         (find_source_lines): Delete declaration.
3096
3097 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3098
3099         * source.c (get_filename_and_charpos): Remove fullname
3100         parameter.
3101         (identify_source_line): Update call to get_filename_and_charpos.
3102
3103 2019-06-14  Tom Tromey  <tromey@adacore.com>
3104
3105         PR gdb/24502:
3106         * ui-style.h (skip_ansi_escape): Update comment.
3107         * ui-file.h (class no_terminal_escape_file): New class.
3108         * ui-file.c (no_terminal_escape_file::write)
3109         (no_terminal_escape_file::puts): New methods.
3110         * cli/cli-logging.c (handle_redirections): Use
3111         no_terminal_escape_file.
3112
3113 2019-06-14  Tom Tromey  <tromey@adacore.com>
3114
3115         * NEWS: Move convenience variable news above Python news.
3116
3117 2019-06-14  Tom Tromey  <tom@tromey.com>
3118
3119         * gnulib: Move directory to top-level.
3120         * configure.ac: Don't configure gnulib.
3121         * configure: Rebuild.
3122         * common/common-defs.h: Use new path to gnulib.
3123         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3124         (GNULIB_H): Remove.
3125         (INCGNU): Look in new gnulib location.
3126         (HFILES_NO_SRCDIR): Remove gnulib files.
3127         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3128         (generated_files): Remove GNULIB_H.
3129         ($(LIBGNU), all-lib): Remove targets.
3130         (distclean): Don't mention GNULIB_BUILDDIR.
3131         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3132
3133 2019-06-14  Tom Tromey  <tromey@adacore.com>
3134
3135         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3136         Warn if symbol file does not provide any symbols.
3137
3138 2019-06-14  Tom Tromey  <tromey@adacore.com>
3139
3140         * source.c (find_and_open_source): Respect basenames_may_differ.
3141
3142 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3143
3144         * annotate.c (annotate_breakpoints_invalid): Make use of
3145         scoped_restore_terminal_state.
3146         (annotate_frames_invalid): Likewise.
3147
3148 2019-06-14  Tom Tromey  <tromey@adacore.com>
3149
3150         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3151         allow assignment to an internalvar.
3152
3153 2019-06-14  Tom Tromey  <tromey@adacore.com>
3154
3155         * ada-lex.l: Allow "_" in attribute names.
3156
3157 2019-06-14  Tom Tromey  <tromey@adacore.com>
3158
3159         PR gdb/24653:
3160         * regcache.c (registers_changed): Don't call alloca.
3161         * top.c (execute_command): Don't call alloca.
3162
3163 2019-06-13  Pedro Alves  <palves@redhat.com>
3164
3165         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3166         'expression'.  When parsing an expression, error out if there's
3167         junk after "unlimited".
3168         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3169         (do_set_command): Adjust calls to is_unlimited_literal.
3170
3171 2019-06-13  Pedro Alves  <palves@redhat.com>
3172
3173         * compile/compile.c (make_compile_options_def_group): Add braces
3174         around array_view initializer.
3175         * thread.c (make_thread_apply_all_options_def_group)
3176         (make_thread_apply_all_options_def_group): Likewise.
3177
3178 2019-06-13  Pedro Alves  <palves@redhat.com>
3179
3180         * NEWS (New commands): Mention "maint test-options
3181         require-delimiter", "maint test-options unknown-is-error", "maint
3182         test-options unknown-is-operand" and "maint show
3183         test-options-completion-result".
3184         (New command options, command completion): New section.
3185         (Completion improvements): New section.
3186         Mention that you can abbreviate "unlimited".
3187
3188 2019-06-13  Pedro Alves  <palves@redhat.com>
3189
3190         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3191         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3192         * unittests/cli-utils-selftests.c (test_parse_flags)
3193         (test_parse_flags_qcs): Delete.
3194         (test_cli_utils): Don't call deleted functions.
3195
3196 2019-06-13  Pedro Alves  <palves@redhat.com>
3197
3198         * thread.c: Include "cli/cli-option.h".
3199         (tp_array_compar_ascending): Global.
3200         (tp_array_compar): Delete function.
3201         (tp_array_compar_ascending, tp_array_compar_descending): New
3202         functions.
3203         (ascending_option_def, qcs_flag_option_def)
3204         (thr_qcs_flags_option_defs)
3205         (make_thread_apply_all_options_def_group)
3206         (make_thread_apply_options_def_group): New.
3207         (thread_apply_all_command): Use gdb::option::process_options.
3208         (thread_apply_command_completer)
3209         (thread_apply_all_command_completer): New.
3210         (thread_apply_command): Use gdb::option::process_options.
3211         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3212         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3213         to generate help text of "thread apply".  Adjust "taas"'s help.
3214         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3215         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3216
3217 2019-06-13  Pedro Alves  <palves@redhat.com>
3218
3219         * thread.c (thread_apply_command): Check for invalid TID with
3220         isdigit instead of !isalpha.
3221
3222 2019-06-13  Pedro Alves  <palves@redhat.com>
3223
3224         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3225         (validate_flags_qcs): New.
3226         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3227         (validate_flags_qcs): Declare.
3228         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3229         (make_frame_apply_options_def_group): New.
3230         (frame_apply_command_count): Process options with
3231         gdb::option::process_options.
3232         (frame_apply_completer): New.
3233         (frame_apply_level_completer, frame_apply_all_completer)
3234         (frame_apply_completer): New.
3235         (_initialize_stack): Update help of "frame apply", "frame apply
3236         level", "frame apply all" and "faas" to mention supported options
3237         and install command completers.
3238         * stack.h (frame_apply_all_completer): Declare.
3239         * thread.c: Include "stack.h".
3240         (tfaas_command): Add "--".
3241         (_initialize_thread): Update help "tfaas" to mention supported
3242         options and install command completer.
3243
3244 2019-06-13  Pedro Alves  <palves@redhat.com>
3245
3246         * completer.c (complete_nested_command_line): New.
3247         (gdb_completion_word_break_characters_throw): Add assertion.
3248         * completer.h (complete_nested_command_line): Declare.
3249
3250 2019-06-13  Pedro Alves  <palves@redhat.com>
3251
3252         * stack.c (parse_backtrace_qualifiers): New.
3253         (backtrace_command): Use it.
3254         (backtrace_command_completer): Complete on qualifiers.
3255
3256 2019-06-13  Pedro Alves  <palves@redhat.com>
3257
3258         * frame.c: Include "cli/cli-option.h.
3259         (user_set_backtrace_options): New.
3260         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3261         Delete.
3262         (get_prev_frame): Adjust.
3263         (boolean_option_def, uinteger_option_def)
3264         (set_backtrace_option_defs): New.
3265         (_initialize_frame): Adjust and use
3266         gdb::option::add_setshow_cmds_for_options to install "set
3267         backtrace past-main" and "set backtrace past-entry".
3268         * frame.h: Include "cli/cli-option.h".
3269         (struct frame_print_options): Forward declare.
3270         (print_frame_arguments_all, print_frame_arguments_scalars)
3271         (print_frame_arguments_none): Declare.
3272         (print_entry_values): Delete declaration.
3273         (struct frame_print_options, user_frame_print_options): New.
3274         (struct set_backtrace_options): New.
3275         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3276         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3277         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3278         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3279         (list_args_or_locals): Add frame_print_options parameter.
3280         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3281         * python/py-framefilter.c (enumerate_args): Pass down
3282         USER_FRAME_PRINT_OPTIONS.
3283         * stack.c: Include "cli/cli-option.h".
3284         (print_frame_arguments_all, print_frame_arguments_scalars)
3285         (print_frame_arguments_none): Declare.
3286         (print_raw_frame_arguments, print_entry_values): Delete.
3287         (user_frame_print_options): New.
3288         (boolean_option_def, enum_option_def, frame_print_option_defs):
3289         New.
3290         (struct backtrace_cmd_options): New.
3291         (bt_flag_option_def): New.
3292         (backtrace_command_option_defs): New.
3293         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3294         (print_frame_arg, read_frame_arg, print_frame_args)
3295         (print_frame_info, print_frame): Add frame_print_options parameter
3296         and use it.
3297         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3298         (backtrace_command_1): Add frame_print_options and
3299         backtrace_cmd_options parameters and use them.
3300         (make_backtrace_options_def_group): New.
3301         (backtrace_command): Process command options with
3302         gdb::option::process_options.
3303         (backtrace_command_completer): New.
3304         (_initialize_stack): Extend "backtrace"'s help to mention
3305         supported options.  Install completer for "backtrace".
3306         Install some settings commands with add_setshow_cmds_for_options.
3307
3308 2019-06-13  Pedro Alves  <palves@redhat.com>
3309
3310         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3311         and that "set/show print raw frame-arguments" are now deprecated.
3312
3313         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3314         command.
3315         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3316         * stack.c (_initialize_stack): Install "set/show print
3317         raw-frame-arguments", and deprecate "set/show print raw
3318         frame-arguments".
3319         * valprint.c (_initialize_valprint): Deprecate "set/show print
3320         raw".
3321
3322 2019-06-13  Pedro Alves  <palves@redhat.com>
3323
3324         * compile/compile.c (struct compile_options): New.
3325         (compile_flag_option_def, compile_command_option_defs)
3326         (make_compile_options_def_group): New.
3327         (compile_file_command): Handle options with
3328         gdb::option::process_options.
3329         (compile_file_command_completer): New function.
3330         (compile_code_command): Handle options with
3331         gdb::option::process_options.
3332         (compile_code_command_completer): New function.
3333         (_initialize_compiler): Install completers for "compile code" and
3334         "compile file".  Mention available options in "compile code" and
3335         "compile code"'s help.
3336         * completer.c (advance_to_completion_word): New, factored out from
3337         ...
3338         (advance_to_expression_complete_word_point): ... this.
3339         (advance_to_filename_complete_word_point): New.
3340         * completer.h (advance_to_filename_complete_word_point): New
3341         declaration.
3342
3343 2019-06-13  Pedro Alves  <palves@redhat.com>
3344
3345         * compile/compile.c: Include "cli/cli-option.h".
3346         (compile_print_value): Scope data pointer is now a
3347         value_print_options pointer; adjust.
3348         (compile_print_command): Process options.  Scope data pointer is
3349         now a value_print_options pointer; adjust.
3350         (_initialize_compile): Update "compile print"'s help to include
3351         supported options.  Install a completer for "compile print".
3352         * cp-valprint.c (show_vtblprint, show_objectprint)
3353         (show_static_field_print): Delete.
3354         (_initialize_cp_valprint): Don't install "set print
3355         static-members", "set print vtbl", "set print object" here.
3356         * printcmd.c: Include "cli/cli-option.h" and
3357         "common/gdb_optional.h".
3358         (print_command_parse_format): Rework to fill in a
3359         value_print_options instead of a format_data.
3360         (print_value): Change parameter type from format_data pointer to
3361         value_print_options reference.  Adjust.
3362         (print_command_1): Process options.  Adjust to pass down a
3363         value_print_options.
3364         (print_command_completer): New.
3365         (_initialize_printcmd): Install print_command_completer as
3366         handle_brkchars completer for the "print" command.  Update
3367         "print"'s help to include supported options.
3368         * valprint.c: Include "cli/cli-option.h".
3369         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3370         here from cp-valprint.c.
3371         (boolean_option_def, uinteger_option_def)
3372         (value_print_option_defs, make_value_print_options_def_group):
3373         New.  Use gdb::option::add_setshow_cmds_for_options to install
3374         "set print elements", "set print null-stop", "set print repeats",
3375         "set print pretty", "set print union", "set print array", "set
3376         print address", "set print symbol", "set print array-indexes".
3377         * valprint.h: Include <string> and "cli/cli-option.h".
3378         (make_value_print_options_def_group): Declare.
3379         (print_value): Change parameter type from format_data pointer to
3380         value_print_options reference.
3381         (print_command_completer): Declare.
3382
3383 2019-06-13  Pedro Alves  <palves@redhat.com>
3384
3385         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3386         (COMMON_SFILES): Add maint-test-settings.c.
3387         * cli/cli-decode.c (boolean_enums): New global, factored out from
3388         ...
3389         (add_setshow_boolean_cmd): ... here.
3390         * cli/cli-decode.h (boolean_enums): Declare.
3391         * cli/cli-option.c: New file.
3392         * cli/cli-option.h: New file.
3393         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3394         factored out from ...
3395         (parse_cli_boolean_value(const char *)): ... this.
3396         (is_unlimited_literal): Change parameter type to pointer to
3397         pointer.  Adjust and advance ARG pointer.
3398         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3399         (parse_cli_var_enum): New, factored out from ...
3400         (do_set_command): ... this.  Adjust.
3401         * cli/cli-setshow.h (parse_cli_boolean_value)
3402         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3403         (parse_cli_var_enum): Declare.
3404         * cli/cli-utils.c: Include "cli/cli-option.h".
3405         (get_ulongest): New.
3406         * cli/cli-utils.h (get_ulongest): Declare.
3407         (check_for_argument): New overloads.
3408         * maint-test-options.c: New file.
3409
3410 2019-06-13  Pedro Alves  <palves@redhat.com>
3411
3412         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3413         parse a range if "-" is at the end of the string.
3414
3415 2019-06-13  Pedro Alves  <palves@redhat.com>
3416
3417         * cli/cli-setshow.c (parse_auto_binary_operation)
3418         (parse_cli_boolean_value): Don't allow "o".
3419
3420 2019-06-13  Pedro Alves  <palves@redhat.com>
3421
3422         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3423         * NEWS: Mention maint test-settings KIND.
3424         * maint-test-settings.c: New file.
3425
3426 2019-06-13  Pedro Alves  <palves@redhat.com>
3427
3428         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3429         completer.
3430         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3431         "set" completers.
3432
3433 2019-06-13  Pedro Alves  <palves@redhat.com>
3434
3435         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3436         after item.
3437
3438 2019-06-13  Pedro Alves  <palves@redhat.com>
3439
3440         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3441
3442 2019-06-13  Pedro Alves <palves@redhat.com>
3443
3444         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3445         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3446         call.
3447         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3448         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3449         calls.
3450         (check_for_argument): Skip spaces after argument.
3451
3452 2019-06-13  Pedro Alves  <palves@redhat.com>
3453
3454         * thread.c (thread_apply_command): Adjust TID parsing.
3455         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3456         detected before end of string.
3457         (tid_is_in_list): Error out if LIST is invalid.
3458
3459 2019-06-13  Pedro Alves  <palves@redhat.com>
3460
3461         * completer.c (complete_line_internal_1): Rewind completion word
3462         point.
3463         (completion_tracker::advance_custom_word_point_by): Change
3464         parameter type to int.
3465         * completer.h (completion_tracker::advance_custom_word_point_by):
3466         Likewise.
3467
3468 2019-06-13  Pedro Alves  <palves@redhat.com>
3469
3470         * completer.c (advance_to_completion_word): Handle delimiters.
3471
3472 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3473
3474         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3475
3476 2019-06-11  Tom Tromey  <tom@tromey.com>
3477
3478         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3479         (xmalloc_failed): Move to alloc.c.
3480         * alloc.c: New file.
3481         * Makefile.in (COMMON_SFILES): Add alloc.c.
3482
3483 2019-06-11  Tom Tromey  <tom@tromey.com>
3484
3485         * nat/linux-waitpid.c: Don't include server.h.
3486         (linux_debug): Remove.
3487         (my_waitpid): Update.
3488
3489 2019-06-11  Tom Tromey  <tromey@adacore.com>
3490
3491         * infcall.c (_initialize_infcall): Remove trailing newline from
3492         help.
3493         * user-regs.c (_initialize_user_regs): Remove trailing newline
3494         from help.
3495         * typeprint.c (_initialize_typeprint): Remove trailing newline
3496         from help.
3497         * reverse.c (_initialize_reverse): Remove trailing newlines from
3498         help.
3499         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3500         from help.
3501         * language.c (add_set_language_command): Remove trailing newline
3502         from help.
3503         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3504         help.
3505         * disasm.c (_initialize_disasm): Remove trailing newline from
3506         help.
3507         * top.c (init_main): Remove trailing newline from help.
3508         * interps.c (_initialize_interpreter): Remove trailing newline
3509         from help.
3510         * btrace.c (_initialize_btrace): Remove trailing newlines from
3511         help.
3512         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3513         from help.
3514         * python/python.c (_initialize_python): Remove trailing newline
3515         from help.
3516         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3517         help.
3518         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3519         from help.  Reformat some text.
3520         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3521         from help.
3522         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3523         newline from help.
3524
3525 2019-06-11  Tom Tromey  <tromey@adacore.com>
3526
3527         * darwin-nat.c (darwin_decode_exception_message)
3528         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3529
3530 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3531
3532         * valops.c (value_slice): Check for not allocated or not
3533         associated values.
3534
3535 2019-06-10  Tom de Vries  <tdevries@suse.de>
3536
3537         PR gdb/24618
3538         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3539         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3540         invalid.
3541
3542 2019-06-10  Tom de Vries  <tdevries@suse.de>
3543
3544         PR gdb/24611
3545         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3546         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3547
3548 2019-06-10  Tom de Vries  <tdevries@suse.de>
3549
3550         PR symtab/24545
3551         * symtab.c (struct demangled_name_entry): Add language field.
3552         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3553         static minimal symbol".  Set and use language field.
3554
3555 2019-06-10  Tom Tromey  <tromey@adacore.com>
3556
3557         * ada-lang.c (_initialize_ada_language): Update help text.
3558
3559 2019-06-10  Tom Tromey  <tromey@adacore.com>
3560
3561         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3562         with a newline.
3563         * guile/guile.c (handle_boot_error): Don't end warning with a
3564         newline.
3565         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3566         warning with a newline.
3567         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3568         newline.
3569         (s12z_frame_cache): Likewise.
3570         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3571         a newline.
3572         * solib-svr4.c (disable_probes_interface): Don't end warning with
3573         a newline.
3574         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3575         newline.
3576         * python/python.c (do_finish_initialization): Don't end warning
3577         with a newline.
3578
3579 2019-06-10  Tom Tromey  <tom@tromey.com>
3580
3581         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3582         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3583         gdbpy_enter.
3584
3585 2019-06-10  Tom Tromey  <tromey@adacore.com>
3586
3587         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3588         data.
3589         (elf_new_init): Don't call stabsread_new_init.
3590         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3591         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3592         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3593
3594 2019-06-10  Tom de Vries  <tdevries@suse.de>
3595
3596         PR symtab/16264
3597         PR symtab/24517
3598         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3599
3600 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3601
3602         * source.c (find_and_open_source): Also rewrite relative file
3603         names.
3604
3605 2019-04-26  Amos Bird  <amosbird@gmail.com>
3606
3607         * annotate.c (annotate_thread_exited): Add "thread-exited"
3608         annotation.
3609
3610 2019-06-06  Tom Tromey  <tromey@adacore.com>
3611
3612         * maint.h (class scoped_command_stats): Use
3613         DISABLE_COPY_AND_ASSIGN.
3614         <print_time>: New method.
3615         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3616         print_time.
3617         (scoped_command_stats::print_time): New method.
3618
3619 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3620
3621         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3622         instructions of lengths 6 or 8 bytes.
3623
3624 2019-06-04  Pedro Alves  <palves@redhat.com>
3625
3626         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3627
3628         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3629         * breakpoint.c (condition_completer): Likewise.
3630         * cli/cli-dump.c (scan_expression): Likewise.
3631         * common/filestuff.c (mkdir_recursive): Likewise.
3632         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3633         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3634         (gdb_abspath): Likewise.
3635         * compile/compile-cplus-types.c
3636         (compile_cplus_instance::decl_name): Likewise.
3637         * completer.c (complete_explicit_location):
3638         (signal_completer, reg_or_group_completer_1): Likewise.
3639         * cp-support.c (cp_remove_params_if_any): Likewise.
3640         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3641         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3642         * infcmd.c (strip_bg_char): Likewise.
3643         * linespec.c (copy_token_string): Likewise.
3644         * mi/mi-main.c (output_cores): Likewise.
3645         * psymtab.c (psymtab_search_name):
3646         * symfile.c (test_set_ext_lang_command): Likewise.
3647         * target.c (target_fileio_read_stralloc): Likewise.
3648         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3649         * value.c (complete_internalvar): Likewise.
3650
3651 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3652
3653         Add objfile property to gdb.Type.
3654         * NEWS: Mention Python API addition.
3655         * python/py-type.c (typy_get_objfile): New method.
3656
3657 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3658
3659         * NEWS: Mention the new set|show style [title|highlight].
3660         Mention changes to "show style", "help" and "apropos".
3661
3662 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3663
3664         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3665         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3666         instead of print_help_for_command.
3667         (print_doc_of_command): New function.
3668         (help_list): Add 'apropos -v word' suggestion.
3669         (print_help_for_command): Style the command name using title style.
3670         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3671         (_initialize_cli_cmds): Describe -v in apropos_command help.
3672
3673 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3674
3675         * cli/cli-style.h (cli_style_option): Add name in constructor,
3676         add m_name class member, add constructor with intensity,
3677         add name class function.
3678         (cli_style_option::add_setshow_commands): Remove name argument.
3679         (highlight_style, title_style): New styles.
3680         * cli/cli-style.c (do_show): New function that shows a style
3681         characteristic styling the style name with itself.
3682         (set_style_name): New function.
3683         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3684         Update all callers according to the changes in cli/cli-style.h.
3685         * utils.h (fputs_highlighted): New function.
3686         * utils.c (fputs_highlighted): Likewise.
3687
3688 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3689
3690         * NEWS: Mention new pipe command and new convenience variables.
3691
3692 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3693
3694         * cli/cli-cmds.c (pipe_command): New function.
3695         (_initialize_cli_cmds): Call add_com for pipe_command.
3696         Define | as an alias for pipe.
3697         (exit_status_set_internal_vars): New function.
3698         (shell_escape): Call exit_status_set_internal_vars.
3699         cli/cli-decode.c (find_command_name_length): Recognize | as
3700         a single character command.
3701
3702 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3703
3704         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3705         top.c (execute_command_to_ui_file): New function, mostly a copy
3706         of execute_command_to_string.
3707         (execute_command_to_string): Implement by calling
3708         execute_command_to_ui_file.
3709
3710 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3711
3712         * top.h (saved_command_line): Remove declaration.
3713         * top.c (previous_saved_command_line, previous_repeat_arguments):
3714         New variables.
3715         (saved_command_line): Make static, define together with other
3716         'repeat variables'.
3717         (dont_repeat): Clear repeat_arguments.
3718         (repeat_previous, get_saved_command_line, save_command_line):
3719         New functions.
3720         (gdb_init): Initialize saved_command_line
3721         and previous_saved_command_line.
3722         * main.c (captured_main_1): Remove saved_command_line initialization.
3723         * event-top.c (handle_line_of_input): Update to use
3724         the new 'repeat' related functions instead of direct access to
3725         saved_command_line.
3726         * command.h (repeat_previous, get_saved_command_line,
3727         save_command_line): New declarations.
3728         (dont_repeat): Add comment.
3729
3730 2019-05-30  Tom Tromey  <tromey@adacore.com>
3731
3732         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3733         Fix comment.
3734         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3735
3736 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3737
3738         PR cli/24587
3739         * completer.c (complete): Initialize variable word.
3740
3741 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3742
3743         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3744         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3745         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3746         'body' is NULL to the outter 'if', protecting the '!is_define'
3747         situation as well.
3748
3749 2019-05-29  Tom Tromey  <tromey@adacore.com>
3750
3751         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3752         (dwarf_unknown): New function.
3753         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3754         (dwarf_type_encoding_name): Use dwarf_unknown.
3755
3756 2019-05-29  Tom Tromey  <tromey@adacore.com>
3757
3758         PR c++/20020:
3759         * cp-valprint.c (cp_print_value_fields): Call
3760         cp_print_static_field inside "try".
3761
3762 2019-05-29  Tom Tromey  <tromey@adacore.com>
3763
3764         * inflow.c (struct terminal_info): Add default operator=.
3765         * configure: Rebuild.
3766         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3767         -Wdeprecated-copy-dtor, -Wredundant-move.
3768
3769 2019-05-29  Tom Tromey  <tromey@adacore.com>
3770
3771         * NEWS: Add entry.
3772         * infcmd.c (print_return_value_1): Handle finish_print
3773         option.
3774         (show_print_finish): New function.
3775         (_initialize_infcmd): Add "set/show print finish" commands.
3776         * valprint.c (user_print_options): Initialize new member.
3777         * valprint.h (struct value_print_options) <finish_print>: New
3778         member.
3779
3780 2019-05-28  Tom Tromey  <tromey@adacore.com>
3781
3782         * ada-lang.c (ada_remove_Xbn_suffix)
3783         (find_old_style_renaming_symbol)
3784         (parse_old_style_renaming): Remove.
3785         (ada_find_renaming_symbol): Don't call
3786         find_old_style_renaming_symbol.
3787         (ada_is_renaming_symbol): Rename from
3788         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3789         bool.  Now static.
3790         (ada_read_var_value): Update and simplify.
3791         * ada-exp.y (write_var_or_type): Remove old code.
3792
3793 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3794
3795         * event-top.c: Remove include comment.
3796         * inflow.c (class scoped_ignore_sigttou): Move from here...
3797         * inflow.h (class scoped_ignore_sigttou): ...to here.
3798         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3799         * top.c:  Remove include comment.
3800
3801 2019-05-27  Tom Tromey  <tom@tromey.com>
3802
3803         * NEWS: Fix typo.
3804
3805 2019-05-22  Tom Tromey  <tromey@adacore.com>
3806
3807         * target.c (target_follow_exec): Constify parameter.
3808         * target-delegates.c: Rebuild.
3809         * remote.c (remote_target::follow_exec): Constify parameter.
3810         * infrun.c (follow_exec): Constify parameter.
3811         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3812         (target_follow_exec): Likewise.
3813
3814 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3815
3816         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3817         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3818
3819 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3820
3821         * NEWS: Add debugredirect and testsuite sections.
3822
3823 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3824
3825         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3826         target descriptions using exclusively floating point register name
3827         aliases.
3828
3829 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3830
3831         PR gdb/18644:
3832         * f-lang.c (build_fortran_types): Handle the case where
3833         gdbarch_floatformat_for_type returns a nullptr.
3834
3835 2019-05-21  Tom de Vries  <tdevries@suse.de>
3836
3837         PR cli/24587
3838         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3839
3840 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3841
3842         PR gdb/18644:
3843         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3844         16-byte floats.
3845         * i386-tdep.c (i386_floatformat_for_type): Use
3846         floatformats_ia64_quad for the 16-byte floating point component
3847         within a fortran 32-byte complex number.
3848
3849 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3852         delete default constructor.
3853         (find_partial_die): Update to return const struct.
3854         (partial_die_parent_scope): Move variable declaration into scope
3855         of its use and change its type to auto.
3856         (guess_partial_die_structure_name): Likewise.
3857         (partial_die_info::fixup): Likewise.
3858
3859 2019-05-17  Tom Tromey  <tromey@adacore.com>
3860
3861         * source.c (find_and_open_source): Remove cast.
3862
3863 2019-05-17  Tom Tromey  <tromey@adacore.com>
3864
3865         * annotate.c (annotate_source): Make "filename" const.
3866         * annotate.h (annotate_source): Use const.
3867
3868 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3869
3870         * disasm.c (set_disassembler_options): Send errors to stderr.
3871
3872 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3873
3874         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3875         (cli_interp_base::set_logging): Check debug_redirect.
3876         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3877         * cli/cli-logging.c (debug_redirect): Add static variable.
3878         (pop_output_files): Add default param.
3879         (handle_redirections): Print debug setting.
3880         (show_logging_command): Likewise.
3881         (_initialize_cli_logging): Add debugredirect command.
3882         * interps.c (current_interp_set_logging): Add debug_redirect
3883         parameter.
3884         * interps.h (set_logging): Add debug_redirect parameter.
3885         (current_interp_set_logging): Likewise.
3886         * mi/mi-common.h: Likewise.
3887         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3888
3889 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3890             Tom Tromey  <tromey@adacore.com>
3891
3892         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3893         directly.
3894         * cli/cli-interp.h (make_logging_output): Remove declaration.
3895         * cli/cli-logging.c (make_logging_output): Remove function.
3896         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3897         directly.
3898         * ui-file.c (tee_file::tee_file): Remove bools.
3899         (tee_file::~tee_file): Remove deletes.
3900         * ui-file.h (tee_file): Remove bools.
3901
3902 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3903
3904         * mi/mi-cmds.h (mi_cmd_complete): New function.
3905         * mi/mi-main.c (mi_cmd_complete): Likewise.
3906         * mi/mi-cmds.c: Define new MI command -complete.
3907         * NEWS: Mention new -complete command.
3908
3909 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3910
3911         * completer.h (complete): New function.
3912         * completer.c (complete): Likewise.
3913         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3914         function defined in completer.h.
3915
3916 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3917
3918         * MAINTAINERS (Write After Approval): Add myself.
3919
3920 2019-05-17  Tom de Vries  <tdevries@suse.de>
3921
3922         PR gdb/24094
3923         * dwarf2read.c (struct cu_partial_die_info): New struct.
3924         (find_partial_die): Return cu_partial_die_info.
3925         (partial_die_parent_scope, guess_partial_die_structure_name)
3926         (partial_die_info::fixup): Handle new return type of find_partial_die.
3927
3928 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3929
3930         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3931         "std::string", simplifying the algorithm.
3932
3933 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3934
3935         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3936         (stap_static_probe_ops::get_probes): Likewise.
3937
3938 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3939
3940         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3941         '-')" and "else if".
3942         (stap_parse_single_operand): Join checks for
3943         "gdbarch_stap_parse_special_token_p" and
3944         "gdbarch_stap_parse_special_token" in the same "if" statement.
3945         Invert check when verifying for operation on register
3946         displacement.
3947
3948 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3949
3950         * stap-probe.c (stap_get_opcode): Update comment.
3951         (stap_get_expected_argument_type): Likewise.
3952         (handle_stap_probe): Likewise.
3953
3954 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3955
3956         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3957         return type to 'bool'.  Adjust comment.  Use 'bool' when
3958         appropriate.
3959         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3960         * stap-probe.c (stap_parse_argument_1): Likewise.
3961         (stap_is_operator): Likewise.
3962         (stap_is_generic_prefix): Likewise.
3963         (stap_is_register_prefix): Likewise.
3964         (stap_is_register_indirection_prefix): Likewise.
3965         (stap_is_integer_prefix): Likewise.
3966         (stap_generic_check_suffix): Likewise.
3967         (stap_check_integer_suffix): Likewise.
3968         (stap_check_register_suffix): Likewise.
3969         (stap_check_register_indirection_suffix): Likewise.
3970         (stap_parse_register_operand): Likewise.
3971         (stap_parse_single_operand): Likewise.
3972         (stap_parse_argument_1): Likewise.
3973         (stap_probe::get_argument_count): Likewise.
3974         (stap_is_operator): Likewise.
3975
3976 2019-05-16  Tom Tromey  <tromey@adacore.com>
3977
3978         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3979         keyword to foreach.
3980
3981 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3982
3983         * linux-thread-db.c (try_thread_db_load_1): Change return type
3984         to bool.
3985         (try_thread_db_load): Likewise.
3986         (try_thread_db_load_from_pdir_1): Likewise.
3987         (try_thread_db_load_from_pdir): Likewise.
3988         (try_thread_db_load_from_sdir): Likewise.
3989         (try_thread_db_load_from_dir): Likewise.
3990         (thread_db_load_search): Likewise.
3991         (has_libpthread): Likewise.
3992         (thread_db_load): Likewise.
3993
3994 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3995
3996         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3997         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3998         NULL, and complain/return if that's the case.
3999
4000 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4001
4002         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4003         (advance, posn, abstract_read_memory): New functions.
4004         [struct mem_read_abstraction]: New struct.
4005         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4006
4007 2019-05-14  Tom Tromey  <tromey@adacore.com>
4008
4009         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4010         value is not lval_memory.
4011
4012 2019-05-14  Tom Tromey  <tromey@adacore.com>
4013
4014         * solib.c (info_sharedlibrary_command): Style the file name.
4015
4016 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4017
4018         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4019         (aarch64_vnv_type): Likewise.
4020         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4021         * common/tdesc.c: Likewise.
4022         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4023         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4024         * features/aarch64-fpu.xml: Add ieee half view.
4025         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4026         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4027         * gdbtypes.h (struct builtin_type): Likewise.
4028         (struct objfile_type): Likewise.
4029
4030 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4031
4032         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4033         typo.
4034         * location.h (string_to_event_location): Likewise.
4035
4036 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4037
4038         GDB 8.3 released.
4039
4040 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4041
4042         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4043         New variable declaration.
4044         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4045         New variable.
4046         (print_one_breakpoint): Use ui_out::test_flags and new global
4047         variable to compute use_fixed_output.
4048         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4049         Remove.
4050         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4051         (mi_multi_location_breakpoint_output_fixed): Remove.
4052         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4053         new variable.
4054         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4055         fix_multi_location_breakpoint_output flag if version >= 3.
4056         * ui-out.h (enum ui_out_flag)
4057         <fix_multi_location_breakpoint_output>: New enumerator.
4058
4059 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4060
4061         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4062
4063 2019-05-10  Tom Tromey  <tromey@adacore.com>
4064
4065         * ada-lang.c (catch_ada_completer): New function.
4066         (_initialize_ada_language): Use it.
4067
4068 2019-05-10  Tom Tromey  <tromey@adacore.com>
4069
4070         * thread.c (print_thread_info): Make "requested_threads" const.
4071         * gdbthread.h (print_thread_info): Make "requested_threads"
4072         const.
4073         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4074         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4075
4076 2019-05-08  Tom Tromey  <tom@tromey.com>
4077
4078         * gdbtypes.c (objfile_type_data): Change type.
4079         (objfile_type, _initialize_gdbtypes): Update.
4080
4081 2019-05-08  Tom Tromey  <tom@tromey.com>
4082
4083         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4084         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4085         (_initialize_dwarf2_frame): Update.
4086
4087 2019-05-08  Tom Tromey  <tom@tromey.com>
4088
4089         * objc-lang.c (objc_objfile_data): Change type.
4090         (find_methods): Update.
4091         (_initialize_objc_lang): Remove.
4092
4093 2019-05-08  Tom Tromey  <tom@tromey.com>
4094
4095         * stabsread.c (rs6000_builtin_type_data): Change type.
4096         (rs6000_builtin_type, _initialize_stabsread): Update.
4097
4098 2019-05-08  Tom Tromey  <tom@tromey.com>
4099
4100         * mips-tdep.c (mips_pdr_data): Remove.
4101         (_initialize_mips_tdep): Update.
4102
4103 2019-05-08  Tom Tromey  <tom@tromey.com>
4104
4105         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4106         (hppa_init_objfile_priv_data, read_unwind_info)
4107         (find_unwind_entry, _initialize_hppa_tdep): Update.
4108
4109 2019-05-08  Tom Tromey  <tom@tromey.com>
4110
4111         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4112         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4113         on obstack.
4114         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4115
4116 2019-05-08  Tom Tromey  <tom@tromey.com>
4117
4118         * mdebugread.c (basic_type_data): Change type.
4119         (basic_type, _initialize_mdebugread): Update.
4120
4121 2019-05-08  Tom Tromey  <tom@tromey.com>
4122
4123         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4124
4125 2019-05-08  Tom Tromey  <tom@tromey.com>
4126
4127         * nto-tdep.c (nto_inferior_data_reg): Change type.
4128         (nto_inferior_data): Update.
4129         (nto_inferior_data_cleanup, nto_new_inferior_data)
4130         (_initialize_nto_tdep): Remove.
4131         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4132
4133 2019-05-08  Tom Tromey  <tom@tromey.com>
4134
4135         * ada-lang.c (struct ada_inferior_data): Add initializers.
4136         (ada_inferior_data): Change type.
4137         (ada_inferior_data_cleanup): Remove.
4138         (get_ada_inferior_data, ada_inferior_exit)
4139         (struct ada_pspace_data): Add initializers, destructor.
4140         (ada_pspace_data_handle): Change type.
4141         (get_ada_pspace_data): Update.
4142         (ada_pspace_data_cleanup): Remove.
4143
4144 2019-05-08  Tom Tromey  <tom@tromey.com>
4145
4146         * coffread.c (struct coff_symfile_info): Add initializers.
4147         (coff_objfile_data_key): Move lower.  Change type.
4148         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4149         Update.
4150         (coff_free_info): Remove.
4151
4152 2019-05-08  Tom Tromey  <tom@tromey.com>
4153
4154         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4155         (fbsd_pspace_data_handle): Move lower.  Change type.
4156         (get_fbsd_pspace_data): Update.
4157         (fbsd_pspace_data_cleanup): Remove.
4158         (_initialize_fbsd_tdep): Update.
4159
4160 2019-05-08  Tom Tromey  <tom@tromey.com>
4161
4162         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4163         (get_ada_tasks_pspace_data): Update.
4164         (ada_tasks_pspace_data_cleanup): Remove.
4165         (_initialize_tasks): Update.
4166         (ada_tasks_inferior_data_handle): Change type.
4167         (get_ada_tasks_inferior_data): Update.
4168         (ada_tasks_inferior_data_cleanup): Remove.
4169         (struct ada_tasks_pspace_data): Add initializers.
4170
4171 2019-05-08  Tom Tromey  <tom@tromey.com>
4172
4173         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4174         * symfile-debug.c (debug_sym_get_probes): Change type.
4175         * stap-probe.c (handle_stap_probe):
4176         (stap_static_probe_ops::get_probes): Change type.
4177         * probe.h (class static_probe_ops) <get_probes>: Change type.
4178         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4179         (parse_probes_in_pspace): Update.
4180         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4181         Update.
4182         (any_static_probe_ops::get_probes): Change type.
4183         * elfread.c (elfread_data): New typedef.
4184         (probe_key): Change type.
4185         (elf_get_probes): Likewise.  Update.
4186         (probe_key_free): Remove.
4187         (_initialize_elfread): Update.
4188         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4189         Change type.
4190         (dtrace_process_dof_probe, dtrace_process_dof)
4191         (dtrace_static_probe_ops::get_probe): Change type.
4192
4193 2019-05-08  Tom Tromey  <tom@tromey.com>
4194
4195         * xcoffread.c (struct xcoff_symfile_info): Rename from
4196         coff_symfile_info.  Add initializers.
4197         (xcoff_objfile_data_key): Move lower.  Change type.
4198         (XCOFF_DATA): Rewrite.
4199         (xcoff_free_info): Remove.
4200         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4201         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4202         (xcoff_initial_scan): Update.
4203
4204 2019-05-08  Tom Tromey  <tom@tromey.com>
4205
4206         * solib-svr4.c (struct svr4_info): Add initializers and
4207         destructor.
4208         <probes_table>: Now an htab_up.
4209         (solib_svr4_pspace_data): Change type.
4210         (free_probes_table): Simplify.
4211         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4212         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4213         (probes_table_remove_objfile_probes, register_solib_event_probe)
4214         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4215         (_initialize_svr4_solib): Update.
4216
4217 2019-05-08  Tom Tromey  <tom@tromey.com>
4218
4219         * remote.c (remote_pspace_data): Change type.
4220         (remote_pspace_data_cleanup): Remove.
4221         (get_remote_exec_file, set_pspace_remote_exec_file)
4222         (_initialize_remote): Update.
4223
4224 2019-05-08  Tom Tromey  <tom@tromey.com>
4225
4226         * breakpoint.c (breakpoint_objfile_key): Change type.
4227         (get_breakpoint_objfile_data): Update.
4228         (free_breakpoint_objfile_data): Remove.
4229         (_initialize_breakpoint): Update.
4230
4231 2019-05-08  Tom Tromey  <tom@tromey.com>
4232
4233         * linux-tdep.c (struct linux_info): Add initializers.
4234         (linux_inferior_data): Move.  Change type.
4235         (invalidate_linux_cache_inf): Update.
4236         (linux_inferior_data_cleanup): Remove.
4237         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4238
4239 2019-05-08  Tom Tromey  <tom@tromey.com>
4240
4241         * auxv.c (auxv_inferior_data): Move.  Change type.
4242         (auxv_inferior_data_cleanup): Remove.
4243         (invalidate_auxv_cache_inf): Rewrite.
4244         (get_auxv_inferior_data, _initialize_auxv): Update.
4245
4246 2019-05-08  Tom Tromey  <tom@tromey.com>
4247
4248         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4249         (symfile_debug_objfile_data_key): Change type.
4250         (symfile_debug_installed, debug_qf_has_symbols)
4251         (debug_qf_find_last_source_symtab)
4252         (debug_qf_forget_cached_source_info)
4253         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4254         (debug_qf_print_stats, debug_qf_dump)
4255         (debug_qf_expand_symtabs_for_function)
4256         (debug_qf_expand_all_symtabs)
4257         (debug_qf_expand_symtabs_with_fullname)
4258         (debug_qf_map_matching_symbols)
4259         (debug_qf_expand_symtabs_matching)
4260         (debug_qf_find_pc_sect_compunit_symtab)
4261         (debug_qf_map_symbol_filenames)
4262         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4263         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4264         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4265         (debug_sym_read_linetable, debug_sym_relocate): Update.
4266         (symfile_debug_free_objfile): Remove.
4267         (install_symfile_debug_logging, _initialize_symfile_debug):
4268         Update.
4269
4270 2019-05-08  Tom Tromey  <tom@tromey.com>
4271
4272         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4273         allocate_on_obstack.
4274         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4275         (get_dwarf2_per_objfile): Update.
4276         (set_dwarf2_per_objfile): Remove.
4277         (dwarf2_has_info, dwarf2_get_section_info): Update.
4278         (dwarf2_free_objfile): Remove.
4279         (_initialize_dwarf2_read): Update.
4280
4281 2019-05-08  Tom Tromey  <tom@tromey.com>
4282
4283         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4284         initializers.
4285         <unsupported_script_warning_printed,
4286         script_not_found_warning_printed>: Now bool.
4287         (auto_load_pspace_data): Change type.
4288         (~auto_load_pspace_info): Rename from
4289         auto_load_pspace_data_cleanup.
4290         (get_auto_load_pspace_data, init_loaded_scripts_info)
4291         (clear_section_scripts, maybe_print_unsupported_script_warning)
4292         (maybe_print_script_not_found_warning, _initialize_auto_load):
4293         Update.
4294
4295 2019-05-08  Tom Tromey  <tom@tromey.com>
4296
4297         * objfiles.c (objfile_pspace_info): Add destructor and
4298         initializers.
4299         (objfiles_pspace_data): Change type.
4300         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4301         (get_objfile_pspace_data): Update.
4302         (objfiles_bfd_data): Change type.
4303         (get_objfile_bfd_data): Update.
4304         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4305
4306 2019-05-08  Tom Tromey  <tom@tromey.com>
4307
4308         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4309         Change type.
4310         (get_catch_syscall_inferior_data): Update.
4311         (catch_syscall_inferior_data_cleanup): Remove.
4312         (_initialize_break_catch_syscall): Update.
4313
4314 2019-05-08  Tom Tromey  <tom@tromey.com>
4315
4316         * inflow.c (struct terminal_info): Add destructor and
4317         initializers.
4318         (inflow_inferior_data): Change type.
4319         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4320         (get_inflow_inferior_data, inflow_inferior_exit)
4321         (swap_terminal_info, _initialize_inflow): Update.
4322
4323 2019-05-08  Tom Tromey  <tom@tromey.com>
4324
4325         * target-dcache.c (target_dcache_cleanup): Remove.
4326         (target_dcache_aspace_key): Change type.
4327         (target_dcache_init_p, target_dcache_invalidate)
4328         (target_dcache_get, target_dcache_get_or_init)
4329         (_initialize_target_dcache): Update.
4330         * dcache.h (struct dcache_deleter): New.
4331
4332 2019-05-08  Tom Tromey  <tom@tromey.com>
4333
4334         * symtab.c (struct symbol_cache): Add destructor and
4335         initializers.
4336         (symbol_cache_key): Move.  Change type.
4337         (make_symbol_cache, free_symbol_cache): Remove.
4338         (get_symbol_cache): Update.
4339         (symbol_cache_cleanup): Remove.
4340         (ALL_PSPACES, symbol_cache_flush)
4341         (maintenance_print_symbol_cache)
4342         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4343         Update.
4344
4345 2019-05-08  Tom Tromey  <tom@tromey.com>
4346
4347         * symtab.c (struct main_info): Add destructor and initializers.
4348         (main_progspace_key): Move.  Change type.
4349         (get_main_info): Update.
4350         (main_info_cleanup): Remove.
4351         (_initialize_symtab): Update.
4352
4353 2019-05-08  Tom Tromey  <tom@tromey.com>
4354
4355         * registry.h (DECLARE_REGISTRY): Define the _key class.
4356
4357 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4358
4359         * NEWS: Merge two 'New commands' sections.
4360
4361 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4362
4363         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4364         parameter and use Ada language definition instead.
4365         (ada_val_print_ptr): Remove unused language parameter.
4366         (ada_val_print_num): Remove language parameter and use Ada language
4367         definition instead.
4368         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4369         parameter.
4370         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4371         parameter and use Ada language definition instead.
4372         (ada_val_print_1): Update all ada_val_print_xxx calls.
4373         Remove language parameter.
4374         (ada_val_print): Update ada_val_print_1 call.
4375
4376 2019-05-08  Tom Tromey  <tromey@adacore.com>
4377
4378         * remote.c (remote_hw_watchpoint_limit)
4379         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4380         Now static.
4381
4382 2019-05-08  Tom Tromey  <tromey@adacore.com>
4383
4384         * maint.c (_initialize_maint_cmds): Move initialization code to
4385         remote.c.
4386         (watchdog, show_watchdog): Move to remote.c.
4387         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4388         "watchdog" static.
4389         (_initialize_remote): Move initialization code from maint.c.
4390         * defs.h (watchdog): Don't declare.
4391
4392 2019-05-08  Tom Tromey  <tromey@adacore.com>
4393
4394         * tui/tui-interp.c: Include main.h.
4395         * interps.c: Include main.h.
4396         * main.h (interpreter_p): Declare.
4397         * defs.h (interpreter_p): Don't declare.
4398
4399 2019-05-08  Tom Tromey  <tromey@adacore.com>
4400
4401         * dwarf2loc.c: Include dwarf2read.h.
4402         * defs.h (read_unsigned_leb128): Don't declare.
4403         * dwarf2read.h (read_unsigned_leb128): Declare.
4404
4405 2019-05-08  Tom Tromey  <tromey@adacore.com>
4406
4407         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4408         method.
4409
4410 2019-05-08  Tom Tromey  <tromey@adacore.com>
4411
4412         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4413         when no wrap column is set.
4414
4415 2019-05-08  Tom Tromey  <tromey@adacore.com>
4416
4417         * c-lang.c (c_get_string): Handle non-C-style arrays.
4418
4419 2019-05-08  Tom Tromey  <tromey@adacore.com>
4420
4421         * typeprint.c (print_offset_data::update): Print the bit offset,
4422         not the number of bits remaining.
4423
4424 2019-05-08  Tom Tromey  <tromey@adacore.com>
4425
4426         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4427         padding at end of comment.
4428
4429 2019-05-08  Tom Tromey  <tromey@adacore.com>
4430
4431         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4432         Compare main types.
4433
4434 2019-05-06  Tom Tromey  <tom@tromey.com>
4435
4436         * common/scoped_mmap.c: Include common-defs.h.
4437         * common/scoped_mmap.h: Don't include config.h.
4438
4439 2019-05-04  Tom Tromey  <tom@tromey.com>
4440
4441         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4442         (struct aarch64_call_info): Add initializers.
4443         <si>: Now a std::vector.
4444         (pass_on_stack, aarch64_push_dummy_call): Update.
4445
4446 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4447             Tom Tromey  <tom@tromey.com>
4448
4449         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4450         (ppc_threads): Now a std::vector.  Now static.
4451         (hwdebug_find_thread_points_by_tid)
4452         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4453         Update.
4454
4455 2019-05-04  Tom Tromey  <tom@tromey.com>
4456
4457         * arc-tdep.c (arc_tdesc_init): Return bool.
4458
4459 2019-05-04  Tom Tromey  <tom@tromey.com>
4460
4461         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4462         Use gdb_assert_not_reached.
4463
4464 2019-05-04  Tom Tromey  <tom@tromey.com>
4465
4466         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4467         "false".
4468
4469 2019-05-04  Tom Tromey  <tom@tromey.com>
4470
4471         * arc-tdep.c (arc_tdesc_init): Use bool.
4472
4473 2019-05-04  Tom Tromey  <tom@tromey.com>
4474
4475         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4476
4477 2019-05-04  Tom Tromey  <tom@tromey.com>
4478
4479         * cli/cli-cmds.c (valid_command_p): Return bool.
4480
4481 2019-05-04  Tom Tromey  <tom@tromey.com>
4482
4483         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4484         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4485
4486 2019-05-04  Raul Tambre  <raul@tambre.ee>
4487
4488         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4489         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4490         operator for comparison.
4491
4492 2019-05-04  Tom Tromey  <tom@tromey.com>
4493
4494         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4495         (lookup_partial_symbol, print_partial_symbols)
4496         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4497         (psymbol_compare): Update.
4498         (add_psymbol_to_bcache): Clear the entire psymbol.
4499         (maintenance_check_psymtabs): Update.
4500         * psympriv.h (struct partial_symbol): Don't derive from
4501         general_symbol_info.
4502         <obj_section, unrelocated_address, address,
4503         set_unrelocated_address>: Update.
4504         <ginfo>: New member.
4505         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4506         (debug_names::write_psymbols): Update.
4507
4508 2019-05-04  Tom de Vries  <tdevries@suse.de>
4509
4510         * contrib/cc-with-tweaks.sh: Support -n arg.
4511
4512 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4513
4514         * corelow.c (core_target::detach): Ensure frame cache and
4515         register caches are cleared.
4516         inferior.c (exit_inferior_1): Likewise.
4517
4518 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4519             Tom Tromey  <tom@tromey.com>
4520
4521         * dictionary.c (collate_pending_symbols_by_language): Remove
4522         "struct" from foreach.
4523         * symtab.c (lookup_global_symbol_from_objfile)
4524         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4525         foreach.
4526         * ser-tcp.c (net_open): Remove "struct" from foreach.
4527         * objfiles.c (objfile_relocate, objfile_rebase)
4528         (objfile_has_symbols): Remove "struct" from foreach.
4529         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4530         from foreach.
4531         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4532         foreach.
4533         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4534         "struct" from foreach.
4535         * ada-lang.c (create_excep_cond_exprs)
4536         (ada_exception_catchpoint_cond_string): Remove "struct" from
4537         foreach.
4538
4539 2019-05-03  Tom Tromey  <tromey@adacore.com>
4540
4541         * ada-exp.y (convert_char_literal): Check suffix of each
4542         enumerator.
4543
4544 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4545
4546         PR ada/21406:
4547         * ada-exp.y (yywrap): Don't define.
4548         * ada-lex.l (%option): Add noyywrap
4549         (yywrap): Remove.
4550
4551 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4552
4553         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4554         _WIN32_WINNT to the XP level, unless already defined to a higher
4555         level.
4556
4557         * unittests/parse-connection-spec-selftests.c:
4558         * ser-tcp.c:
4559         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4560         override.
4561
4562         * symfile.c (find_separate_debug_file): Remove colon from the
4563         drive spec of DOS/Windows file names of the target, so that the
4564         file name produced from DEBUGDIR and the target's directory will
4565         be valid on DOS/Windows systems.
4566
4567 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4568
4569         * rust-lang.c (val_print_struct): Handle printing structures
4570         containing strings.
4571
4572 2019-05-02  Tom Tromey  <tromey@adacore.com>
4573
4574         * valarith.c (_initialize_valarith): Remove.
4575
4576 2019-05-01  Tom Tromey  <tromey@adacore.com>
4577
4578         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4579         bitfields.
4580
4581 2019-05-01  Tom Tromey  <tromey@adacore.com>
4582
4583         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4584         for big-endian copies.
4585
4586 2019-04-30  Ali Tamur  <tamur@google.com>
4587         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4588         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4589         (read_3_bytes): New function.
4590
4591 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4592
4593         * windows-nat.c (main_thread_id): Delete.
4594         (handle_output_debug_string): Replace main_thread_id by
4595         current_event.dwThreadId.
4596         (fake_create_process): Likewise.
4597         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4598         Do not set main_thread_id.
4599         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4600         current_event.dwThreadId.
4601         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4602
4603 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4604
4605         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4606         Use current_event.dwThreadId instead of main_thread_id.
4607
4608 2019-04-30  Tom Tromey  <tromey@adacore.com>
4609
4610         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4611         (create_excep_cond_exprs): Iterate over program spaces.
4612         (ada_exception_catchpoint_cond_string): Examine all minimal
4613         symbols for exception types.
4614
4615 2019-04-30  Tom Tromey  <tromey@adacore.com>
4616
4617         PR c++/24470:
4618         * dwarf2read.c (process_structure_scope): Handle case where type
4619         has template parameters but no symbol was created.
4620
4621 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4622             Chris January  <chris.january@arm.com>
4623
4624         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4625         qualifier.
4626         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4627
4628 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4629
4630         * f-typeprint.c (f_print_type): Update rules for printing
4631         whitespace.
4632         (f_type_print_varspec_suffix): Likewise.
4633
4634 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4635             Chris January  <chris.january@arm.com>
4636
4637         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4638         function arguments.
4639
4640 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * f-lang.c (build_fortran_types): Change name of void type to
4643         lower case.
4644         * f-typeprint.c (f_type_print_base): Print the name of the void
4645         type, rather than a fixed string.
4646         * f-valprint.c (f_decorations): Use lower case void string.
4647
4648 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4649             Chris January  <chris.january@arm.com>
4650
4651         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4652         types for Fortran.
4653
4654 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4655             Chris January  <chris.january@arm.com>
4656             David Lecomber  <david.lecomber@arm.com>
4657
4658         * f-exp.y (BINOP_INTRINSIC): New token.
4659         (exp): New parser rule handling BINOP_INTRINSIC.
4660         (f77_keywords): Add new builtin procedures.
4661         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4662         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4663         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4664         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4665         (print_unop_subexp_f): New function.
4666         (print_binop_subexp_f): New function.
4667         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4668         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4669         (dump_subexp_body_f): Likewise.
4670         (operator_check_f): Likewise.
4671         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4672         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4673
4674 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4675
4676         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4677         UNOP_KIND.
4678         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4679         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4680         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4681         (operator_length_f): New fuction.
4682         (print_subexp_f): New function.
4683         (op_name_f): New function.
4684         (dump_subexp_body_f): New function.
4685         (operator_check_f): New function.
4686         (exp_descriptor_f): Replace standard expression handling functions
4687         with new functions.
4688         * gdb/fortran-operator.def: New file.
4689         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4690         * gdb/std-operator.def: Remove UNOP_KIND.
4691
4692 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4693
4694         * std-operator.def: Remove unbalanced, stray double quote
4695         character.
4696
4697 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4698             Chris January  <chris.january@arm.com>
4699             Daniel Everett  <daniel.everett@arm.com>
4700             Nick Forrington  <nick.forrington@arm.com>
4701             Richard Bunt  <richard.bunt@arm.com>
4702
4703         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4704         of depth when printing anonymous structs or unions.
4705         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4706         Don't print either the top-level value, or the children if the
4707         max-depth is exceeded.
4708         (ppscm_print_children): When printing the key of a map, allow one
4709         extra level of depth.
4710         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4711         print either the top-level value, or the children if the max-depth
4712         is exceeded.
4713         (print_children): When printing the key of a map, allow one extra
4714         level of depth.
4715         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4716         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4717         (user_print_options): Initialise max_depth field.
4718         (val_print_scalar_or_string_type_p): New function.
4719         (val_print): Check to see if the max depth has been reached.
4720         (val_print_check_max_depth): Define new function.
4721         (show_print_max_depth): New function.
4722         (_initialize_valprint): Add 'print max-depth' option.
4723         * valprint.h (struct value_print_options) <max_depth>: New field.
4724         (val_print_check_max_depth): Declare new function.
4725         * NEWS: Document new feature.
4726
4727 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4728
4729         * ada-lang.c (ada_language_defn): Initialise new field.
4730         * c-lang.c (c_is_string_type_p): New function.
4731         (c_language_defn): Initialise new field.
4732         (cplus_language_defn): Initialise new field.
4733         (asm_language_defn): Initialise new field.
4734         (minimal_language_defn): Initialise new field.
4735         * c-lang.h (c_is_string_type_p): Declare new function.
4736         * d-lang.c (d_language_defn): Initialise new field.
4737         * f-lang.c (f_is_string_type_p): New function.
4738         (f_language_defn): Initialise new field.
4739         * go-lang.c (go_is_string_type_p): New function.
4740         (go_language_defn): Initialise new field.
4741         * language.c (default_is_string_type_p): New function.
4742         (unknown_language_defn): Initialise new field.
4743         (auto_language_defn): Initialise new field.
4744         * language.h (struct language_defn) <la_is_string_type_p>: New
4745         member variable.
4746         (default_is_string_type_p): Declare new function.
4747         * m2-lang.c (m2_language_defn): Initialise new field.
4748         * objc-lang.c (objc_language_defn): Initialise new field.
4749         * opencl-lang.c (opencl_language_defn): Initialise new field.
4750         * p-lang.c (pascal_is_string_type_p): New function.
4751         (pascal_language_defn): Initialise new field.
4752         * rust-lang.c (rust_is_string_type_p): New function.
4753         (rust_language_defn): Initialise new field.
4754
4755 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4756
4757         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4758         New field.
4759         * ada-lang.c (ada_language_defn): Initialise new field.
4760         * c-lang.c (c_language_defn): Likewise.
4761         (cplus_language_defn): Likewise.
4762         (asm_language_defn): Likewise.
4763         (minimal_language_defn): Likewise.
4764         * d-lang.c (d_language_defn): Likewise.
4765         * f-lang.c (f_language_defn): Likewise.
4766         * go-lang.c (go_language_defn): Likewise.
4767         * language.c (unknown_language_defn): Likewise.
4768         (auto_language_defn): Likewise.
4769         * m2-lang.c (m2_language_defn): Likewise.
4770         * objc-lang.c (objc_language_defn): Likewise.
4771         * opencl-lang.c (opencl_language_defn): Likewise.
4772         * p-lang.c (pascal_language_defn): Likewise.
4773         * rust-lang.c (rust_language_defn): Likewise.
4774
4775 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4776
4777         * ada-lang.c (ada_is_character_type): Change return type to bool.
4778         (ada_is_string_type): Likewise.
4779         * ada-lang.h (ada_is_character_type): Update declaration
4780         (ada_is_string_type): Likewise.
4781
4782 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4783
4784         Support style in 'frame|thread apply'
4785
4786         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4787         * record.c (record_start, record_stop): Update callers of
4788         execute_command_to_string with false.
4789         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4790         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4791         methods.
4792         (class string_file): New constructor with term_out parameter.
4793         Override methods term_out and can_emit_style_escape.  New member
4794         term_out.
4795         (class stdio_file): Override can_emit_style_escape.
4796         (class tee_file): Override term_out and can_emit_style_escape.
4797         * utils.h (can_emit_style_escape): Remove.
4798         * utils.c (can_emit_style_escape): Likewise.
4799         Update all callers of can_emit_style_escape (SOMESTREAM) to
4800         SOMESTREAM->can_emit_style_escape.
4801         * source-cache.c (source_cache::get_source_lines): Likewise.
4802         * stack.c (frame_apply_command_count): Call execute_command_to_string
4803         passing the term_out characteristic of the current gdb_stdout.
4804         * thread.c (thr_try_catch_cmd): Likewise.
4805         * top.c (execute_command_to_string): pass term_out parameter
4806         to construct the string_file for the command output.
4807         * ui-file.c (term_cli_styling): New function (most code moved
4808         from utils.c can_emit_style_escape).
4809         (string_file::string_file, string_file::can_emit_style_escape,
4810         stdio_file::can_emit_style_escape, tee_file::term_out,
4811         tee_file::can_emit_style_escape): New functions.
4812
4813 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4814
4815         * NEWS: Mention the new set|show may-call-functions.
4816         * infcall.c (may_call_functions_p): New variable.
4817         (show_may_call_functions_p): New function.
4818         (call_function_by_hand_dummy): Throws an error if not
4819         may-call-functions.
4820         (_initialize_infcall): Call add_setshow_boolean_cmd for
4821         may-call-functions.
4822
4823 2019-04-25  Keith Seitz  <keiths@redhat.com>
4824
4825         PR c++/24367
4826         * cp-support.c (inspect_type): Don't attempt substitutions
4827         of symbol with the same name.
4828
4829 2019-04-25  Tom Tromey  <tromey@adacore.com>
4830
4831         PR gdb/24475:
4832         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4833         static.
4834
4835 2019-04-25  Tom Tromey  <tromey@adacore.com>
4836
4837         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4838         rvalue reference.
4839         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4840         (gdb_xml_parser::parse): Use std::move.
4841         * python/python-internal.h (gdbpy_convert_exception): Take a const
4842         reference.
4843         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4844         std::move.
4845         * python/py-utils.c (gdbpy_convert_exception): Take a const
4846         reference.
4847         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4848         Use std::move.
4849         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4850         Use std::move.
4851         * mi/mi-main.c (mi_print_exception): Take a const reference.
4852         * main.c (handle_command_errors): Take a const reference.
4853         * linespec.c (parse_linespec): Use std::move.
4854         * infcall.c (run_inferior_call): Use std::move.
4855         (call_function_by_hand_dummy): Use std::move.
4856         * exec.c (try_open_exec_file): Use std::move.
4857         * exceptions.h (exception_print, exception_fprintf)
4858         (exception_print_same): Update.
4859         * exceptions.c (print_exception, exception_print)
4860         (exception_fprintf, exception_print_same): Change parameters to
4861         const reference.
4862         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4863         * common/new-op.c: Use std::move.
4864         * common/common-exceptions.h (struct gdb_exception): Add move
4865         constructor.
4866         (struct gdb_exception_error, struct gdb_exception_quit, struct
4867         gdb_quit_bad_alloc): Change constructor to move constructor.
4868         (throw_exception): Change parameter to rvalue reference.
4869         * common/common-exceptions.c (throw_exception): Take rvalue
4870         reference.
4871         * cli/cli-interp.c (safe_execute_command): Use std::move.
4872         * breakpoint.c (insert_bp_location, location_to_sals): Use
4873         std::move.
4874
4875 2019-04-25  Tom Tromey  <tromey@adacore.com>
4876
4877         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4878         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4879         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4880         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4881         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4882         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4883         guile/scm-value.c: Use unpack.
4884         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4885         gdbscm_gdb_exception.
4886         (gdbscm_throw_gdb_exception): Likewise.
4887         (struct gdbscm_gdb_exception): New.
4888         (unpack): New function.
4889         (gdbscm_wrap): Use unpack.
4890
4891 2019-04-25  Tom Tromey  <tromey@adacore.com>
4892
4893         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4894         (gdb_rl_callback_handler): Use std::move.
4895         * common/common-exceptions.h (struct gdb_exception): Add move
4896         assignment operator.
4897         (throw_exception_sjlj): Change "exception" to const reference.
4898         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4899         (throw_exception_sjlj): Change "exception" to const reference.
4900
4901 2019-04-25  Tom Tromey  <tromey@adacore.com>
4902
4903         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4904         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4905         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4906         Update.
4907         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4908         Update.
4909         * mi/mi-interp.c (mi_interp::exec): Update.
4910         * linespec.c (parse_linespec): Update.
4911         * infcall.c (run_inferior_call): Update.
4912         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4913         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4914         (gdbscm_lookup_global_symbol): Update.
4915         * guile/scm-param.c (gdbscm_parameter_value): Update.
4916         * guile/scm-frame.c (gdbscm_frame_read_register)
4917         (gdbscm_frame_read_var): Update.
4918         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4919         * exec.c (try_open_exec_file): Update.
4920         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4921         (gdb_rl_callback_handler): Update.
4922         * common/common-exceptions.h (exception_none): Don't declare.
4923         * common/common-exceptions.c (exception_none): Don't define.
4924         (struct catcher) <exception>: Update.
4925         * cli/cli-interp.c (safe_execute_command): Update.
4926         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4927
4928 2019-04-25  Ali Tamur  <tamur@google.com>
4929
4930         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4931         (read_attribute_value): Likewise.
4932         (dwarf2_read_addr_index): Update comment.
4933         (read_str_index): Add DW_FORM_strx.
4934         (dwarf2_string_attr): Likewise.
4935         (dwarf2_const_value_attr): Likewise.
4936         (dump_die_shallow): Likewise.
4937         (dwarf2_fetch_constant_bytes): Likewise.
4938         (skip_form_bytes): Likewise.
4939         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4940
4941 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4942
4943         PR corefiles/11608
4944         PR corefiles/18187
4945         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4946         OFFSET.  Verify if current mapping contains an ELF header.
4947         (linux_find_memory_regions_full): Adjust call to
4948         dump_mapping_p.
4949
4950 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4951             Kang Li <kanglictf@gmail.com>
4952
4953         PR gdb/21600
4954
4955         * dwarf2-frame.c (read_initial_length): Be consistent about using
4956         unsigned representation of length.
4957         (decode_frame_entry_1): Likewise.  Check for wraparound of
4958         end pointer as well as buffer overflow.
4959
4960 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4961
4962         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4963         "vq".
4964
4965 2019-04-24  Tom Tromey  <tromey@adacore.com>
4966
4967         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4968
4969 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4970
4971         * s12z-tdep.c (s12z_unwind_pc): Delete.
4972         (s12z_unwind_sp): Delete.
4973         (s12z_gdbarch_init): Don't register deleted functions with
4974         gdbarch.
4975
4976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4977
4978         * rl78-tdep.c (rl78_unwind_sp): Delete.
4979         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4980
4981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4982
4983         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4984         (xstormy16_unwind_pc): Delete.
4985         (xstormy16_dummy_id): Delete.
4986         (xstormy16_gdbarch_init): Don't register deleted functions with
4987         gdbarch.
4988
4989 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4990
4991         * vax-tdep.c (vax_unwind_pc): Delete.
4992         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4993
4994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * v850-tdep.c (v850_unwind_sp): Delete.
4997         (v850_unwind_pc): Delete.
4998         (v850_dummy_id): Delete.
4999         (v850_gdbarch_init): Don't register deleted functions with
5000         gdbarch.
5001
5002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5003
5004         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5005         (tilegx_unwind_pc): Delete.
5006         (tilegx_unwind_dummy_id): Delete.
5007         (tilegx_gdbarch_init): Don't register deleted functions with
5008         gdbarch.
5009
5010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5011
5012         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5013         (tic6x_dummy_id): Delete.
5014         (tic6x_gdbarch_init): Don't register deleted functions with
5015         gdbarch.
5016
5017 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5018
5019         * sparc-tdep.c (sparc_unwind_pc): Delete.
5020         (sparc32_gdbarch_init): Don't register deleted function with
5021         gdbarch.
5022
5023 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5024
5025         * sh-tdep.c (sh_unwind_sp): Delete.
5026         (sh_unwind_pc): Delete.
5027         (sh_dummy_id): Delete.
5028         (sh_gdbarch_init): Don't register deleted functions with
5029         gdbarch.
5030
5031 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5032
5033         * score-tdep.c (score_unwind_sp): Delete.
5034         (score_unwind_pc): Delete.
5035         (score_dummy_id): Delete.
5036         (score_gdbarch_init): Don't register deleted functions with
5037         gdbarch.
5038
5039 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5040
5041         * rx-tdep.c (rx_unwind_pc): Delete.
5042         (rx_unwind_sp): Delete.
5043         (rx_dummy_id): Delete.
5044         (rx_gdbarch_init): Don't register deleted functions with
5045         gdbarch.  Update comment.
5046
5047 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5048
5049         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5050         (rs6000_dummy_id): Delete.
5051         (rs6000_gdbarch_init): Don't register deleted functions with
5052         gdbarch.
5053
5054 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5055
5056         * or1k-tdep.c (or1k_dummy_id): Delete.
5057         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5058
5059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5060
5061         * nios2-tdep.c (nios2_dummy_id): Delete.
5062         (nios2_unwind_sp): Delete.
5063         (nios2_gdbarch_init): Don't register deleted functions with
5064         gdbarch.
5065
5066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5067
5068         * nds32-tdep.c (nds32_dummy_id): Delete.
5069         (nds32_unwind_pc): Delete.
5070         (nds32_unwind_sp): Delete.
5071         (nds32_gdbarch_init): Don't register deleted functions with
5072         gdbarch.
5073
5074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5075
5076         * msp430-tdep.c (msp430_unwind_pc): Delete.
5077         (msp430_unwind_sp): Delete.
5078         (msp430_dummy_id): Delete.
5079         (msp430_gdbarch_init): Don't register deleted functions with
5080         gdbarch.
5081
5082 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5083
5084         * moxie-tdep.c (moxie_unwind_sp): Delete.
5085         (moxie_unwind_pc): Delete.
5086         (moxie_dummy_id): Delete.
5087         (moxie_gdbarch_init): Don't register deleted functions with
5088         gdbarch.
5089
5090 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5091
5092         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5093         (mn10300_unwind_pc): Delete.
5094         (mn10300_unwind_sp): Delete.
5095         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5096         mn10300_unwind_sp.
5097         (mn10300_frame_unwind_init): Don't register deleted functions with
5098         gdbarch.
5099
5100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * mep-tdep.c (mep_unwind_pc): Delete.
5103         (mep_unwind_sp): Delete.
5104         (mep_dummy_id): Delete.
5105         (mep_gdbarch_init): Don't register deleted functions with
5106         gdbarch.
5107
5108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5111         (m68hc11_unwind_sp): Delete.
5112         (m68hc11_gdbarch_init): Don't register deleted functions with
5113         gdbarch.
5114
5115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5116
5117         * m32r-tdep.c (m32r_unwind_sp): Delete.
5118         (m32r_unwind_pc): Delete.
5119         (m32r_dummy_id): Delete.
5120         (m32r_gdbarch_init): Don't register deleted functions with
5121         gdbarch.
5122
5123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5124
5125         * m32c-tdep.c (m32c_unwind_pc): Delete.
5126         (m32c_unwind_sp): Delete.
5127         (m32c_dummy_id): Delete.
5128         (m32c_gdbarch_init): Don't register deleted functions with
5129         gdbarch.
5130
5131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5132
5133         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5134         (lm32_unwind_pc): Delete.
5135         (lm32_dummy_id): Delete.
5136         (lm32_gdbarch_init): Don't register deleted functions with
5137         gdbarch.
5138
5139 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5140
5141         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5142         (iq2000_unwind_pc): Delete.
5143         (iq2000_dummy_id): Delete.
5144         (iq2000_gdbarch_init): Don't register deleted functions with
5145         gdbarch.
5146
5147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5148
5149         * nds32-tdep.c (nds32_type_align): Delete.
5150         (nds32_push_dummy_call): Use type_align instead.
5151
5152 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * arm-tdep.c (arm_type_align): Only handle vector override case.
5155         (arm_push_dummy_call): Use type_align.
5156         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5157
5158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5159
5160         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5161         case.
5162         (pass_on_stack): Use type_align.
5163         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5164         function.
5165
5166 2019-04-23  Tom Tromey  <tromey@adacore.com>
5167
5168         * dwarf2read.c (line_header::file_name_at): Remove unused
5169         overload.
5170
5171 2019-04-23  Tom de Vries  <tdevries@suse.de>
5172
5173         PR gdb/24438
5174         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5175         invocation.
5176
5177
5178 2019-03-27  Ali Tamur  <tamur@google.com>
5179
5180         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5181         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5182         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5183         (dwarf_expr_context::get_addr_index): Likewise
5184         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5185         (symbol_needs_eval_context::get_addr_index): Likewise
5186         (disassemble_dwarf_expression): Add DW_OP_addrx
5187         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5188         (read_cutu_die_from_dwo): Update comment
5189         (skip_one_die): Add DW_FORM_addrx
5190         (read_attribute_value): Likewise
5191         (var_decode_location): Add DW_OP_addrx
5192         (dwarf2_const_value_attr): Add DW_FORM_addrx
5193         (dump_die_shallow): Likewise
5194         (dwarf2_fetch_constant_bytes): Likewise
5195         (decode_locdesc): Add DW_OP_addrx
5196         (skip_form_bytes): Add DW_FORM_addrx
5197
5198 2019-04-22  Ali Tamur  <tamur@google.com>
5199
5200         * MAINTAINERS (Write After Approval): Add self.
5201
5202 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5203
5204         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5205         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5206         (open_symbol_file_object): Likewise.
5207         (svr4_default_sos): Add info parameter.
5208         (svr4_read_so_list): Likewise.
5209         (svr4_current_sos_direct): Adjust functions calls to pass down
5210         info.
5211         (svr4_current_sos_1): Add info parameter.
5212         (svr4_current_sos): Call get_svr4_info, pass info down to
5213         svr4_current_sos_1.
5214         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5215         get_svr4_info.
5216         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5217         get_svr4_info.
5218         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5219         to get_svr4_info.
5220         (probes_table_remove_objfile_probes): Likewise.
5221         (register_solib_event_probe): Add info parameter.
5222         (solist_update_incremental): Pass info parameter down to
5223         svr4_read_so_list.
5224         (disable_probes_interface): Add info parameter.
5225         (svr4_handle_solib_event): Pass current_program_space to
5226         get_svr4_info.  Adjust disable_probes_interface cleanup.
5227         (svr4_create_probe_breakpoints): Add info parameter, pass it
5228         down to register_solib_event_probe.
5229         (svr4_create_solib_event_breakpoints): Add info parameter,
5230         pass it down to svr4_create_probe_breakpoints.
5231         (enable_break): Pass info down to
5232         svr4_create_solib_event_breakpoints.
5233         (svr4_solib_create_inferior_hook): Pass current_program_space to
5234         get_svr4_info.
5235         (svr4_clear_solib): Likewise.
5236
5237 2019-04-22  Pedro Alves  <palves@redhat.com>
5238
5239         * solib-svr4.c (svr4_free_objfile_observer): New.
5240         (probe_and_action::objfile): New field.
5241         (probes_table_htab_remove_objfile_probes)
5242         (probes_table_remove_objfile_probes): New functions.
5243         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5244         in the new probe_and_action.  Don't store the probe in 'lookup'.
5245         (svr4_create_probe_breakpoints): Pass objfile to
5246         register_solib_event_probe.
5247         (_initialize_svr4_solib): Register a free_objfile observer.
5248
5249 2019-04-19  Tom Tromey  <tom@tromey.com>
5250
5251         * common/queue.h: Remove.
5252
5253 2019-04-19  Tom Tromey  <tom@tromey.com>
5254
5255         * event-loop.c: Don't include "common/queue.h".
5256
5257 2019-04-19  Tom Tromey  <tom@tromey.com>
5258
5259         * remote.c (remote_target): Use delete.
5260         * remote-notif.h: Include <list>, not "common/queue.h".
5261         (notif_client_p): Remove typedef.
5262         (remote_notif_state): Add constructor, destructor, initializer.
5263         <notif_queue>: Now a std::list.
5264         (remote_notif_state_xfree): Don't declare.
5265         * remote-notif.c (remote_notif_process, handle_notification)
5266         (remote_notif_state_allocate): Update.
5267         (~remote_notif_state): Rename from remote_notif_state_xfree.
5268
5269 2019-04-19  Tom Tromey  <tom@tromey.com>
5270
5271         * symfile.c (reread_symbols): Update.
5272         * objfiles.c (objfile_register_static_link)
5273         (objfile_lookup_static_link): Update
5274         (~objfile) Don't delete static_links.
5275         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5276
5277 2019-04-19  Tom Tromey  <tom@tromey.com>
5278
5279         * type-stack.h (struct type_stack) <insert>: Constify string.
5280         * type-stack.c (type_stack::insert): Constify string.
5281         * gdbtypes.h (lookup_template_type): Update.
5282         (address_space_name_to_int): Update.
5283         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5284         const.
5285         (lookup_template_type): Make name const.
5286         * c-exp.y: Update rules.
5287         (lex_one_token, classify_name, classify_inner_name)
5288         (c_print_token): Update.
5289         * p-exp.y: Update rules.
5290         (yylex): Update.
5291         * f-exp.y: Update rules.
5292         (yylex): Update.
5293         * d-exp.y: Update rules.
5294         (lex_one_token, classify_name, classify_inner_name): Update.
5295         * parse.c (write_dollar_variable, copy_name): Return std::string.
5296         * parser-defs.h (copy_name): Change return type.
5297         * m2-exp.y: Update rules.
5298         (yylex): Update.
5299         * go-exp.y (lex_one_token): Update.
5300         Update rules.
5301         (classify_unsafe_function, classify_packaged_name)
5302         (classify_name, yylex): Update.
5303
5304 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5305
5306         * configure.ac: add --enable-source-highlight switch.
5307         * configure: Regenerate.
5308         * top.c (print_gdb_version): plumb --enable-source-highlight
5309         status to "show configuration".
5310
5311 2019-04-19  Tom Tromey  <tromey@adacore.com>
5312
5313         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5314         Check ADA_TYPE_P.
5315         (empty_record, ada_template_to_fixed_record_type_1)
5316         (template_to_static_fixed_type)
5317         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5318         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5319         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5320         macros.
5321
5322 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5323
5324         PR symtab/24423:
5325         * source.c (print_source_lines_base): Advance "iter" when a
5326         control character is seen.
5327
5328 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5329
5330         * inferior.h (struct infcall_suspend_state_deleter):
5331         Catch exception in destructor to avoid crash.
5332
5333 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5334
5335         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5336         close to the add_com "shell".
5337
5338 2019-04-18  Tom Tromey  <tromey@adacore.com>
5339
5340         * process-stratum-target.h (class process_stratum_target)
5341         <stratum>: Add "final".
5342
5343 2019-04-17  Tom Tromey  <tromey@adacore.com>
5344
5345         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5346         against nullptr before use.
5347
5348 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5349
5350         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5351
5352 2019-04-17  Jim Wilson  <jimw@sifive.com>
5353             Andrew Burgess  <andrew.burgess@embecosm.com>
5354
5355         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5356         code read might fail, assume 4-byte breakpoint in that case.
5357
5358 2019-04-15  Leszek Swirski  <leszeks@google.com>
5359
5360         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5361         rather than a hand-rolled POD check when checking for forced MEMORY
5362         classification.
5363
5364 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5365
5366         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5367         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5368         function.
5369         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5370         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5371         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5372         declaration.
5373
5374 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5375
5376         * aarch64-linux-nat.c
5377         (aarch64_linux_nat_target::thread_architecture): Add override.
5378         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5379         each VQ.
5380
5381 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5382
5383         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5384
5385 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5386
5387         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5388         target types of size 96-bits, add some additional comments, and
5389         check that the builtin type we found was the correct size.
5390
5391 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5392
5393         * utils.c (prompt_for_continue): Don't restore the styling at the
5394         end, as applied_style has the wrong value.  This fixes styling in
5395         long lists of file names that are interrupted by the "Continue?"
5396         prompt.
5397
5398 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5399
5400         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5401         * c-lang.c (c_language_defn): Likewise.
5402         (cplus_language_defn): Likewise.
5403         (asm_language_defn): Likewise.
5404         (minimal_language_defn): Likewise.
5405         * d-lang.c (d_language_defn): Likewise.
5406         * f-lang.c (f_language_defn): Likewise.
5407         * go-lang.c (go_language_defn): Likewise.
5408         * language.c (unknown_language_defn): Likewise.
5409         (auto_language_defn): Likewise.
5410         * language.h (struct language_defn): Remove la_magic field.
5411         (LANG_MAGIC): Delete.
5412         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5413         * objc-lang.c (objc_language_defn): Likewise.
5414         * opencl-lang.c (opencl_language_defn): Likewise.
5415         * p-lang.c (pascal_language_defn): Likewise.
5416         * rust-lang.c (rust_language_defn): Likewise.
5417
5418 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5419
5420         * riscv-tdep.c (riscv_type_align): New function.
5421         (riscv_type_alignment): Delete.
5422         (riscv_arg_location): Use 'type_align'.
5423         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5424
5425 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5426
5427         * gdbtypes.c (type_align): A struct with no non-static fields also
5428         has alignment of 1.
5429
5430 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5431
5432         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5433         component to 0.
5434         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5435         member.
5436         (riscv_struct_info::analyse): New implementation using new
5437         analyse_inner member function.
5438         (riscv_struct_info::field_offset): New member function.
5439         (riscv_struct_info::m_offsets): New member variable.
5440         (riscv_struct_info::analyse_inner): New private member function,
5441         takes the old implementation of riscv_struct_info::analyse but
5442         extended to track field offsets.
5443         (riscv_call_arg_struct): Update the struct folding special cases
5444         to handle cases where empty C++ structs, which are non-zero
5445         length, are found.
5446         (riscv_arg_location): Initialise the length of each location, a
5447         non-zero length now indicates the location is in use.
5448         (riscv_push_dummy_call): Allow for the first location having a
5449         non-zero offset when setting up arguments.
5450         (riscv_return_value): Likewise, but for return values.
5451
5452 2019-04-11  Tom Tromey  <tromey@adacore.com>
5453
5454         * utils.c (internal_vproblem): Make "msg" const.
5455
5456 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5457
5458         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5459         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5460         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5461         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5462
5463 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5464
5465         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5466         function.
5467         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5468         of amd64_collect_native_gregset.
5469         (amd64_linux_nat_target::store_registers): Likewise.
5470
5471 2019-04-10  Tom Tromey  <tom@tromey.com>
5472
5473         * symtab.c (lookup_global_symbol_from_objfile)
5474         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5475         * objfiles.h (class separate_debug_iterator): New.
5476         (class separate_debug_range): New.
5477         (struct objfile) <separate_debug_objfiles>: New method.
5478         (objfile_separate_debug_iterate): Don't declare.
5479         * objfiles.c (separate_debug_iterator::operator++): Rename from
5480         objfile_separate_debug_iterate.
5481         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5482         iterator.
5483         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5484         iterator.
5485
5486 2019-04-10  Tom Tromey  <tom@tromey.com>
5487
5488         * symfile.c (reread_symbols): Remove old comment.
5489         * objfiles.c (free_all_objfiles): Fix a typo.
5490
5491 2019-04-10  Tom Tromey  <tom@tromey.com>
5492
5493         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5494         * minsyms.c (lookup_minimal_symbol): Use foreach.
5495         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5496         (lookup_minimal_symbol_solib_trampoline): Likewise.
5497         * symfile.c (reread_symbols): Use foreach.
5498
5499 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5500             Tom Tromey  <tromey@adacore.com>
5501
5502         PR rust/24414:
5503         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5504         (rust_lex_int_test): Change "value" to be LONGEST.
5505         (rust_lex_tests): Add test for long integer literal.
5506
5507 2019-04-09  Tom Tromey  <tromey@adacore.com>
5508
5509         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5510         to bool.
5511         (extended_remote_target::attach): Update.
5512         (remote_target::remote_notice_new_inferior): Update.
5513         (remote_target::add_current_inferior_and_thread): Update.
5514         * inferior.c (exit_inferior_1): Use "false".
5515         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5516
5517 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5518
5519         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5520         the "start" command.
5521
5522 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5523
5524         * python/py-inferior.c (infpy_thread_from_thread_handle):
5525         Adjust comments to reflect renaming of thread_from_thread_handle
5526         to thread_from_handle.  Adjust keywords.  Fix type error message.
5527         (inferior_object_methods): Add thread_from_handle.  Retain
5528         thread_from_thread_handle, but mark it as deprecated.
5529
5530 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5531
5532         * gdbthread.h (find_thread_by_handle): Revise declaration.
5533         * thread.c (find_thread_by_handle): Likewise.  Adjust
5534         implementation too.
5535         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5536         support for buffer objects as handles.
5537
5538 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5539
5540         * python/py-infthread.c (thpy_thread_handle): New function.
5541         (thread_object_methods): Register thpy_thread_handle.
5542
5543 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5544
5545         * gdbthread.h (thread_to_thread_handle): Declare.
5546         * thread.c (gdbtypes.h): Include.
5547         (thread_to_thread_handle): New function.
5548
5549         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5550         (target_thread_info_to_thread_handle): Declare.
5551         * target.c (target_thread_info_to_thread_handle): New function.
5552         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5553         * target-delegates.c: Regenerate.
5554
5555         * linux-thread-db.c (class thread_db_target): Add method
5556         thread_info_to_thread_handle.
5557         (thread_db_target::thread_info_to_thread_handle): Define.
5558         * remote.c (class remote_target): Add new method
5559         thread_info_to_thread_handle.
5560         (remote_target::thread_info_to_thread_handle): Define.
5561
5562 2019-04-08  Pedro Alves  <palves@redhat.com>
5563
5564         * common/common-exceptions.c (throw_exception): Don't create
5565         named object to throw; throw directly.
5566         (throw_it): Likewise.  Don't initialize gdb_exception::message
5567         here, with new; pass FMT and AP to the ctor instead.
5568         * common/common-exceptions.h: Include <string>.
5569         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5570         const char *, va_list)): New ctor.  Use std::make_shared.
5571         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5572         errors)): Delete.
5573         (gdb_exception_error::gdb_exception_error(enum errors, const char
5574         *, va_list)): New.
5575         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5576         Add assertion.
5577         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5578         errors)): Delete.
5579         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5580         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5581         Add assertion.
5582
5583 2019-04-08  Tom Tromey  <tom@tromey.com>
5584
5585         * valops.c (value_rtti_indirect_type): Replace throw_exception
5586         with throw.
5587         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5588         with throw.
5589         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5590         throw.
5591         * target.c (target_translate_tls_address): Replace throw_exception
5592         with throw.
5593         * stack.c (frame_apply_command_count): Replace throw_exception
5594         with throw.
5595         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5596         throw.
5597         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5598         with throw.
5599         * rs6000-tdep.c (rs6000_frame_cache)
5600         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5601         * remote.c: Replace throw_exception with throw.
5602         * record-full.c (record_full_message, record_full_wait_1)
5603         (record_full_restore): Replace throw_exception with throw.
5604         * record-btrace.c:
5605         (get_thread_current_frame_id, record_btrace_start_replaying)
5606         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5607         (cmd_record_btrace_start): Replace throw_exception with throw.
5608         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5609         throw.
5610         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5611         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5612         * linespec.c:
5613         (find_linespec_symbols): Replace throw_exception with throw.
5614         * infrun.c (displaced_step_prepare, resume): Replace
5615         throw_exception with throw.
5616         * infcmd.c (post_create_inferior): Replace throw_exception with
5617         throw.
5618         * inf-loop.c (inferior_event_handler): Replace throw_exception
5619         with throw.
5620         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5621         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5622         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5623         (get_prev_frame_always, get_frame_pc_if_available)
5624         (get_frame_address_in_block_if_available, get_frame_language):
5625         Replace throw_exception with throw.
5626         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5627         throw_exception with throw.
5628         * eval.c (fetch_subexp_value, evaluate_var_value)
5629         (evaluate_funcall, evaluate_subexp_standard): Replace
5630         throw_exception with throw.
5631         * dwarf2loc.c (call_site_find_chain)
5632         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5633         Replace throw_exception with throw.
5634         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5635         with throw.
5636         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5637         throw.
5638         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5639         * completer.c (complete_line_internal): Replace throw_exception
5640         with throw.
5641         * compile/compile-object-run.c (compile_object_run): Replace
5642         throw_exception with throw.
5643         * cli/cli-script.c (process_next_line): Replace throw_exception
5644         with throw.
5645         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5646         (btrace_enable, btrace_maint_update_pt_packets): Replace
5647         throw_exception with throw.
5648         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5649         throw_exception with throw.
5650         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5651         throw_exception with throw.
5652         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5653         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5654         * aarch64-tdep.c (aarch64_make_prologue_cache)
5655         (aarch64_make_stub_cache): Replace throw_exception with throw.
5656
5657 2019-04-08  Tom Tromey  <tom@tromey.com>
5658
5659         * common/common-exceptions.c (throw_exception): Rename from
5660         throw_exception_cxx.  Remove old copy.  Make argument const.
5661         (throw_it): Create and throw exception objects directly.
5662         * common/common-exceptions.h (throw_exception): Make argument
5663         const.
5664         (struct gdb_exception_error): Add constructor.
5665         (struct gdb_exception_quit): Add constructor.
5666
5667 2019-04-08  Tom Tromey  <tom@tromey.com>
5668
5669         * common/common-exceptions.h (exception_rethrow): Don't declare.
5670         (TRY_SJLJ): Update comment.
5671         (TRY, CATCH, END_CATCH): Remove.
5672         * common/common-exceptions.c (exception_rethrow): Remove.
5673
5674 2019-04-08  Tom Tromey  <tom@tromey.com>
5675
5676         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5677         Remove.
5678         (gdb_exception_error): Rename from
5679         gdb_exception_RETURN_MASK_ERROR.
5680         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5681         (gdb_quit_bad_alloc): Update.
5682         * aarch64-tdep.c: Update.
5683         * ada-lang.c: Update.
5684         * ada-typeprint.c: Update.
5685         * ada-valprint.c: Update.
5686         * amd64-tdep.c: Update.
5687         * arch-utils.c: Update.
5688         * break-catch-throw.c: Update.
5689         * breakpoint.c: Update.
5690         * btrace.c: Update.
5691         * c-varobj.c: Update.
5692         * cli/cli-cmds.c: Update.
5693         * cli/cli-interp.c: Update.
5694         * cli/cli-script.c: Update.
5695         * common/common-exceptions.c: Update.
5696         * common/new-op.c: Update.
5697         * common/selftest.c: Update.
5698         * compile/compile-c-symbols.c: Update.
5699         * compile/compile-cplus-symbols.c: Update.
5700         * compile/compile-object-load.c: Update.
5701         * compile/compile-object-run.c: Update.
5702         * completer.c: Update.
5703         * corelow.c: Update.
5704         * cp-abi.c: Update.
5705         * cp-support.c: Update.
5706         * cp-valprint.c: Update.
5707         * darwin-nat.c: Update.
5708         * disasm-selftests.c: Update.
5709         * dtrace-probe.c: Update.
5710         * dwarf-index-cache.c: Update.
5711         * dwarf-index-write.c: Update.
5712         * dwarf2-frame-tailcall.c: Update.
5713         * dwarf2-frame.c: Update.
5714         * dwarf2loc.c: Update.
5715         * dwarf2read.c: Update.
5716         * eval.c: Update.
5717         * event-loop.c: Update.
5718         * event-top.c: Update.
5719         * exec.c: Update.
5720         * f-valprint.c: Update.
5721         * fbsd-tdep.c: Update.
5722         * frame-unwind.c: Update.
5723         * frame.c: Update.
5724         * gdbtypes.c: Update.
5725         * gnu-v3-abi.c: Update.
5726         * guile/guile-internal.h: Update.
5727         * guile/scm-block.c: Update.
5728         * guile/scm-breakpoint.c: Update.
5729         * guile/scm-cmd.c: Update.
5730         * guile/scm-disasm.c: Update.
5731         * guile/scm-frame.c: Update.
5732         * guile/scm-lazy-string.c: Update.
5733         * guile/scm-math.c: Update.
5734         * guile/scm-param.c: Update.
5735         * guile/scm-ports.c: Update.
5736         * guile/scm-pretty-print.c: Update.
5737         * guile/scm-symbol.c: Update.
5738         * guile/scm-symtab.c: Update.
5739         * guile/scm-type.c: Update.
5740         * guile/scm-value.c: Update.
5741         * i386-linux-tdep.c: Update.
5742         * i386-tdep.c: Update.
5743         * inf-loop.c: Update.
5744         * infcall.c: Update.
5745         * infcmd.c: Update.
5746         * infrun.c: Update.
5747         * jit.c: Update.
5748         * language.c: Update.
5749         * linespec.c: Update.
5750         * linux-fork.c: Update.
5751         * linux-nat.c: Update.
5752         * linux-tdep.c: Update.
5753         * linux-thread-db.c: Update.
5754         * main.c: Update.
5755         * mi/mi-cmd-break.c: Update.
5756         * mi/mi-cmd-stack.c: Update.
5757         * mi/mi-interp.c: Update.
5758         * mi/mi-main.c: Update.
5759         * objc-lang.c: Update.
5760         * p-valprint.c: Update.
5761         * parse.c: Update.
5762         * ppc-linux-tdep.c: Update.
5763         * printcmd.c: Update.
5764         * python/py-arch.c: Update.
5765         * python/py-breakpoint.c: Update.
5766         * python/py-cmd.c: Update.
5767         * python/py-finishbreakpoint.c: Update.
5768         * python/py-frame.c: Update.
5769         * python/py-framefilter.c: Update.
5770         * python/py-gdb-readline.c: Update.
5771         * python/py-inferior.c: Update.
5772         * python/py-infthread.c: Update.
5773         * python/py-lazy-string.c: Update.
5774         * python/py-linetable.c: Update.
5775         * python/py-objfile.c: Update.
5776         * python/py-param.c: Update.
5777         * python/py-prettyprint.c: Update.
5778         * python/py-progspace.c: Update.
5779         * python/py-record-btrace.c: Update.
5780         * python/py-record.c: Update.
5781         * python/py-symbol.c: Update.
5782         * python/py-type.c: Update.
5783         * python/py-unwind.c: Update.
5784         * python/py-utils.c: Update.
5785         * python/py-value.c: Update.
5786         * python/python.c: Update.
5787         * record-btrace.c: Update.
5788         * record-full.c: Update.
5789         * remote-fileio.c: Update.
5790         * remote.c: Update.
5791         * riscv-tdep.c: Update.
5792         * rs6000-aix-tdep.c: Update.
5793         * rs6000-tdep.c: Update.
5794         * rust-exp.y: Update.
5795         * rust-lang.c: Update.
5796         * s390-tdep.c: Update.
5797         * selftest-arch.c: Update.
5798         * solib-dsbt.c: Update.
5799         * solib-frv.c: Update.
5800         * solib-spu.c: Update.
5801         * solib-svr4.c: Update.
5802         * solib.c: Update.
5803         * sparc64-linux-tdep.c: Update.
5804         * stack.c: Update.
5805         * symfile-mem.c: Update.
5806         * symmisc.c: Update.
5807         * target.c: Update.
5808         * thread.c: Update.
5809         * top.c: Update.
5810         * tracefile-tfile.c: Update.
5811         * tui/tui.c: Update.
5812         * typeprint.c: Update.
5813         * unittests/cli-utils-selftests.c: Update.
5814         * unittests/parse-connection-spec-selftests.c: Update.
5815         * valops.c: Update.
5816         * valprint.c: Update.
5817         * value.c: Update.
5818         * varobj.c: Update.
5819         * windows-nat.c: Update.
5820         * x86-linux-nat.c: Update.
5821         * xml-support.c: Update.
5822
5823 2019-04-08  Tom Tromey  <tom@tromey.com>
5824
5825         * xml-support.c: Use C++ exception handling.
5826         * x86-linux-nat.c: Use C++ exception handling.
5827         * windows-nat.c: Use C++ exception handling.
5828         * varobj.c: Use C++ exception handling.
5829         * value.c: Use C++ exception handling.
5830         * valprint.c: Use C++ exception handling.
5831         * valops.c: Use C++ exception handling.
5832         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5833         handling.
5834         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5835         * typeprint.c: Use C++ exception handling.
5836         * tui/tui.c: Use C++ exception handling.
5837         * tracefile-tfile.c: Use C++ exception handling.
5838         * top.c: Use C++ exception handling.
5839         * thread.c: Use C++ exception handling.
5840         * target.c: Use C++ exception handling.
5841         * symmisc.c: Use C++ exception handling.
5842         * symfile-mem.c: Use C++ exception handling.
5843         * stack.c: Use C++ exception handling.
5844         * sparc64-linux-tdep.c: Use C++ exception handling.
5845         * solib.c: Use C++ exception handling.
5846         * solib-svr4.c: Use C++ exception handling.
5847         * solib-spu.c: Use C++ exception handling.
5848         * solib-frv.c: Use C++ exception handling.
5849         * solib-dsbt.c: Use C++ exception handling.
5850         * selftest-arch.c: Use C++ exception handling.
5851         * s390-tdep.c: Use C++ exception handling.
5852         * rust-lang.c: Use C++ exception handling.
5853         * rust-exp.y: Use C++ exception handling.
5854         * rs6000-tdep.c: Use C++ exception handling.
5855         * rs6000-aix-tdep.c: Use C++ exception handling.
5856         * riscv-tdep.c: Use C++ exception handling.
5857         * remote.c: Use C++ exception handling.
5858         * remote-fileio.c: Use C++ exception handling.
5859         * record-full.c: Use C++ exception handling.
5860         * record-btrace.c: Use C++ exception handling.
5861         * python/python.c: Use C++ exception handling.
5862         * python/py-value.c: Use C++ exception handling.
5863         * python/py-utils.c: Use C++ exception handling.
5864         * python/py-unwind.c: Use C++ exception handling.
5865         * python/py-type.c: Use C++ exception handling.
5866         * python/py-symbol.c: Use C++ exception handling.
5867         * python/py-record.c: Use C++ exception handling.
5868         * python/py-record-btrace.c: Use C++ exception handling.
5869         * python/py-progspace.c: Use C++ exception handling.
5870         * python/py-prettyprint.c: Use C++ exception handling.
5871         * python/py-param.c: Use C++ exception handling.
5872         * python/py-objfile.c: Use C++ exception handling.
5873         * python/py-linetable.c: Use C++ exception handling.
5874         * python/py-lazy-string.c: Use C++ exception handling.
5875         * python/py-infthread.c: Use C++ exception handling.
5876         * python/py-inferior.c: Use C++ exception handling.
5877         * python/py-gdb-readline.c: Use C++ exception handling.
5878         * python/py-framefilter.c: Use C++ exception handling.
5879         * python/py-frame.c: Use C++ exception handling.
5880         * python/py-finishbreakpoint.c: Use C++ exception handling.
5881         * python/py-cmd.c: Use C++ exception handling.
5882         * python/py-breakpoint.c: Use C++ exception handling.
5883         * python/py-arch.c: Use C++ exception handling.
5884         * printcmd.c: Use C++ exception handling.
5885         * ppc-linux-tdep.c: Use C++ exception handling.
5886         * parse.c: Use C++ exception handling.
5887         * p-valprint.c: Use C++ exception handling.
5888         * objc-lang.c: Use C++ exception handling.
5889         * mi/mi-main.c: Use C++ exception handling.
5890         * mi/mi-interp.c: Use C++ exception handling.
5891         * mi/mi-cmd-stack.c: Use C++ exception handling.
5892         * mi/mi-cmd-break.c: Use C++ exception handling.
5893         * main.c: Use C++ exception handling.
5894         * linux-thread-db.c: Use C++ exception handling.
5895         * linux-tdep.c: Use C++ exception handling.
5896         * linux-nat.c: Use C++ exception handling.
5897         * linux-fork.c: Use C++ exception handling.
5898         * linespec.c: Use C++ exception handling.
5899         * language.c: Use C++ exception handling.
5900         * jit.c: Use C++ exception handling.
5901         * infrun.c: Use C++ exception handling.
5902         * infcmd.c: Use C++ exception handling.
5903         * infcall.c: Use C++ exception handling.
5904         * inf-loop.c: Use C++ exception handling.
5905         * i386-tdep.c: Use C++ exception handling.
5906         * i386-linux-tdep.c: Use C++ exception handling.
5907         * guile/scm-value.c: Use C++ exception handling.
5908         * guile/scm-type.c: Use C++ exception handling.
5909         * guile/scm-symtab.c: Use C++ exception handling.
5910         * guile/scm-symbol.c: Use C++ exception handling.
5911         * guile/scm-pretty-print.c: Use C++ exception handling.
5912         * guile/scm-ports.c: Use C++ exception handling.
5913         * guile/scm-param.c: Use C++ exception handling.
5914         * guile/scm-math.c: Use C++ exception handling.
5915         * guile/scm-lazy-string.c: Use C++ exception handling.
5916         * guile/scm-frame.c: Use C++ exception handling.
5917         * guile/scm-disasm.c: Use C++ exception handling.
5918         * guile/scm-cmd.c: Use C++ exception handling.
5919         * guile/scm-breakpoint.c: Use C++ exception handling.
5920         * guile/scm-block.c: Use C++ exception handling.
5921         * guile/guile-internal.h: Use C++ exception handling.
5922         * gnu-v3-abi.c: Use C++ exception handling.
5923         * gdbtypes.c: Use C++ exception handling.
5924         * frame.c: Use C++ exception handling.
5925         * frame-unwind.c: Use C++ exception handling.
5926         * fbsd-tdep.c: Use C++ exception handling.
5927         * f-valprint.c: Use C++ exception handling.
5928         * exec.c: Use C++ exception handling.
5929         * event-top.c: Use C++ exception handling.
5930         * event-loop.c: Use C++ exception handling.
5931         * eval.c: Use C++ exception handling.
5932         * dwarf2read.c: Use C++ exception handling.
5933         * dwarf2loc.c: Use C++ exception handling.
5934         * dwarf2-frame.c: Use C++ exception handling.
5935         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5936         * dwarf-index-write.c: Use C++ exception handling.
5937         * dwarf-index-cache.c: Use C++ exception handling.
5938         * dtrace-probe.c: Use C++ exception handling.
5939         * disasm-selftests.c: Use C++ exception handling.
5940         * darwin-nat.c: Use C++ exception handling.
5941         * cp-valprint.c: Use C++ exception handling.
5942         * cp-support.c: Use C++ exception handling.
5943         * cp-abi.c: Use C++ exception handling.
5944         * corelow.c: Use C++ exception handling.
5945         * completer.c: Use C++ exception handling.
5946         * compile/compile-object-run.c: Use C++ exception handling.
5947         * compile/compile-object-load.c: Use C++ exception handling.
5948         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5949         * compile/compile-c-symbols.c: Use C++ exception handling.
5950         * common/selftest.c: Use C++ exception handling.
5951         * common/new-op.c: Use C++ exception handling.
5952         * cli/cli-script.c: Use C++ exception handling.
5953         * cli/cli-interp.c: Use C++ exception handling.
5954         * cli/cli-cmds.c: Use C++ exception handling.
5955         * c-varobj.c: Use C++ exception handling.
5956         * btrace.c: Use C++ exception handling.
5957         * breakpoint.c: Use C++ exception handling.
5958         * break-catch-throw.c: Use C++ exception handling.
5959         * arch-utils.c: Use C++ exception handling.
5960         * amd64-tdep.c: Use C++ exception handling.
5961         * ada-valprint.c: Use C++ exception handling.
5962         * ada-typeprint.c: Use C++ exception handling.
5963         * ada-lang.c: Use C++ exception handling.
5964         * aarch64-tdep.c: Use C++ exception handling.
5965
5966 2019-04-08  Tom Tromey  <tom@tromey.com>
5967
5968         * xml-support.c (gdb_xml_parser::parse): Update.
5969         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5970         * value.c (show_convenience): Update.
5971         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5972         (test_parse_flags_qcs): Update.
5973         * thread.c (thr_try_catch_cmd): Update.
5974         * target.c (target_translate_tls_address): Update.
5975         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5976         (info_frame_command_core, frame_apply_command_count): Update.
5977         * rust-exp.y (rust_lex_exception_test): Update.
5978         * riscv-tdep.c (riscv_print_one_register_info): Update.
5979         * remote.c (remote_target::enable_btrace): Update.
5980         * record-btrace.c (record_btrace_enable_warn): Update.
5981         * python/py-utils.c (gdbpy_convert_exception): Update.
5982         * printcmd.c (do_one_display, print_variable_and_value): Update.
5983         * mi/mi-main.c (mi_print_exception): Update.
5984         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5985         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5986         * linux-nat.c (linux_nat_target::attach): Update.
5987         * linux-fork.c (class scoped_switch_fork_info): Update.
5988         * infrun.c (displaced_step_prepare): Update.
5989         * infcall.c (call_function_by_hand_dummy): Update.
5990         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5991         * gnu-v3-abi.c (print_one_vtable): Update.
5992         * frame.c (get_prev_frame_always): Update.
5993         * f-valprint.c (info_common_command_for_block): Update.
5994         * exec.c (try_open_exec_file): Update.
5995         * exceptions.c (print_exception, exception_print)
5996         (exception_fprintf, exception_print_same): Update.
5997         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5998         * dwarf-index-cache.c (index_cache::store)
5999         (index_cache::lookup_gdb_index): Update.
6000         * darwin-nat.c (maybe_cache_shell): Update.
6001         * cp-valprint.c (cp_print_value_fields): Update.
6002         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6003         (gcc_cplus_symbol_address): Update.
6004         * compile/compile-c-symbols.c (gcc_convert_symbol)
6005         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6006         * common/selftest.c: Update.
6007         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6008         a std::string.
6009         (exception_try_scope_entry, exception_try_scope_exit): Don't
6010         declare.
6011         (struct exception_try_scope): Remove.
6012         (TRY): Don't use exception_try_scope.
6013         (struct gdb_exception): Add constructor, operator=.
6014         <what>: New method.
6015         (struct gdb_exception_RETURN_MASK_ALL)
6016         (struct gdb_exception_RETURN_MASK_ERROR)
6017         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6018         (struct gdb_quit_bad_alloc): Update.
6019         * common/common-exceptions.c (exception_none): Change
6020         initializer.
6021         (struct catcher) <state, exception>: Initialize inline.
6022         <prev>: Remove member.
6023         (current_catcher): Remove.
6024         (catchers): New global.
6025         (exceptions_state_mc_init): Simplify.
6026         (catcher_pop): Remove.
6027         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6028         (try_scope_depth, exception_try_scope_entry)
6029         (exception_try_scope_exit): Remove.
6030         (throw_exception_sjlj): Update.
6031         (exception_messages, exception_messages_size): Remove.
6032         (throw_it): Simplify.
6033         (gdb_exception_sliced_copy): Remove.
6034         (throw_exception_cxx): Update.
6035         * cli/cli-script.c (script_from_file): Update.
6036         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6037         Update.
6038         * ada-valprint.c (ada_val_print): Update.
6039         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6040         (create_excep_cond_exprs): Update.
6041
6042 2019-04-08  Tom Tromey  <tom@tromey.com>
6043
6044         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6045         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6046         (TRY, CATCH, END_CATCH): Remove some definitions.
6047         * common/common-exceptions.c: Don't use GDB_XCPT.
6048         (catcher_list_size): Remove.
6049         (throw_exception, throw_it): Simplify.
6050
6051 2019-04-05  Tom Tromey  <tom@tromey.com>
6052
6053         Revert the header-sorting patch.
6054         * ft32-tdep.c: Revert.
6055         * frv-tdep.c: Revert.
6056         * frv-linux-tdep.c: Revert.
6057         * frame.c: Revert.
6058         * frame-unwind.c: Revert.
6059         * frame-base.c: Revert.
6060         * fork-child.c: Revert.
6061         * findvar.c: Revert.
6062         * findcmd.c: Revert.
6063         * filesystem.c: Revert.
6064         * filename-seen-cache.h: Revert.
6065         * filename-seen-cache.c: Revert.
6066         * fbsd-tdep.c: Revert.
6067         * fbsd-nat.h: Revert.
6068         * fbsd-nat.c: Revert.
6069         * f-valprint.c: Revert.
6070         * f-typeprint.c: Revert.
6071         * f-lang.c: Revert.
6072         * extension.h: Revert.
6073         * extension.c: Revert.
6074         * extension-priv.h: Revert.
6075         * expprint.c: Revert.
6076         * exec.h: Revert.
6077         * exec.c: Revert.
6078         * exceptions.c: Revert.
6079         * event-top.c: Revert.
6080         * event-loop.c: Revert.
6081         * eval.c: Revert.
6082         * elfread.c: Revert.
6083         * dwarf2read.h: Revert.
6084         * dwarf2read.c: Revert.
6085         * dwarf2loc.c: Revert.
6086         * dwarf2expr.h: Revert.
6087         * dwarf2expr.c: Revert.
6088         * dwarf2-frame.c: Revert.
6089         * dwarf2-frame-tailcall.c: Revert.
6090         * dwarf-index-write.h: Revert.
6091         * dwarf-index-write.c: Revert.
6092         * dwarf-index-common.c: Revert.
6093         * dwarf-index-cache.h: Revert.
6094         * dwarf-index-cache.c: Revert.
6095         * dummy-frame.c: Revert.
6096         * dtrace-probe.c: Revert.
6097         * disasm.h: Revert.
6098         * disasm.c: Revert.
6099         * disasm-selftests.c: Revert.
6100         * dictionary.c: Revert.
6101         * dicos-tdep.c: Revert.
6102         * demangle.c: Revert.
6103         * dcache.h: Revert.
6104         * dcache.c: Revert.
6105         * darwin-nat.h: Revert.
6106         * darwin-nat.c: Revert.
6107         * darwin-nat-info.c: Revert.
6108         * d-valprint.c: Revert.
6109         * d-namespace.c: Revert.
6110         * d-lang.c: Revert.
6111         * ctf.c: Revert.
6112         * csky-tdep.c: Revert.
6113         * csky-linux-tdep.c: Revert.
6114         * cris-tdep.c: Revert.
6115         * cris-linux-tdep.c: Revert.
6116         * cp-valprint.c: Revert.
6117         * cp-support.c: Revert.
6118         * cp-namespace.c: Revert.
6119         * cp-abi.c: Revert.
6120         * corelow.c: Revert.
6121         * corefile.c: Revert.
6122         * continuations.c: Revert.
6123         * completer.h: Revert.
6124         * completer.c: Revert.
6125         * complaints.c: Revert.
6126         * coffread.c: Revert.
6127         * coff-pe-read.c: Revert.
6128         * cli-out.h: Revert.
6129         * cli-out.c: Revert.
6130         * charset.c: Revert.
6131         * c-varobj.c: Revert.
6132         * c-valprint.c: Revert.
6133         * c-typeprint.c: Revert.
6134         * c-lang.c: Revert.
6135         * buildsym.c: Revert.
6136         * buildsym-legacy.c: Revert.
6137         * build-id.h: Revert.
6138         * build-id.c: Revert.
6139         * btrace.c: Revert.
6140         * bsd-uthread.c: Revert.
6141         * breakpoint.h: Revert.
6142         * breakpoint.c: Revert.
6143         * break-catch-throw.c: Revert.
6144         * break-catch-syscall.c: Revert.
6145         * break-catch-sig.c: Revert.
6146         * blockframe.c: Revert.
6147         * block.c: Revert.
6148         * bfin-tdep.c: Revert.
6149         * bfin-linux-tdep.c: Revert.
6150         * bfd-target.c: Revert.
6151         * bcache.c: Revert.
6152         * ax-general.c: Revert.
6153         * ax-gdb.h: Revert.
6154         * ax-gdb.c: Revert.
6155         * avr-tdep.c: Revert.
6156         * auxv.c: Revert.
6157         * auto-load.c: Revert.
6158         * arm-wince-tdep.c: Revert.
6159         * arm-tdep.c: Revert.
6160         * arm-symbian-tdep.c: Revert.
6161         * arm-pikeos-tdep.c: Revert.
6162         * arm-obsd-tdep.c: Revert.
6163         * arm-nbsd-tdep.c: Revert.
6164         * arm-nbsd-nat.c: Revert.
6165         * arm-linux-tdep.c: Revert.
6166         * arm-linux-nat.c: Revert.
6167         * arm-fbsd-tdep.c: Revert.
6168         * arm-fbsd-nat.c: Revert.
6169         * arm-bsd-tdep.c: Revert.
6170         * arch-utils.c: Revert.
6171         * arc-tdep.c: Revert.
6172         * arc-newlib-tdep.c: Revert.
6173         * annotate.h: Revert.
6174         * annotate.c: Revert.
6175         * amd64-windows-tdep.c: Revert.
6176         * amd64-windows-nat.c: Revert.
6177         * amd64-tdep.c: Revert.
6178         * amd64-sol2-tdep.c: Revert.
6179         * amd64-obsd-tdep.c: Revert.
6180         * amd64-obsd-nat.c: Revert.
6181         * amd64-nbsd-tdep.c: Revert.
6182         * amd64-nbsd-nat.c: Revert.
6183         * amd64-nat.c: Revert.
6184         * amd64-linux-tdep.c: Revert.
6185         * amd64-linux-nat.c: Revert.
6186         * amd64-fbsd-tdep.c: Revert.
6187         * amd64-fbsd-nat.c: Revert.
6188         * amd64-dicos-tdep.c: Revert.
6189         * amd64-darwin-tdep.c: Revert.
6190         * amd64-bsd-nat.c: Revert.
6191         * alpha-tdep.c: Revert.
6192         * alpha-obsd-tdep.c: Revert.
6193         * alpha-nbsd-tdep.c: Revert.
6194         * alpha-mdebug-tdep.c: Revert.
6195         * alpha-linux-tdep.c: Revert.
6196         * alpha-linux-nat.c: Revert.
6197         * alpha-bsd-tdep.c: Revert.
6198         * alpha-bsd-nat.c: Revert.
6199         * aix-thread.c: Revert.
6200         * agent.c: Revert.
6201         * addrmap.c: Revert.
6202         * ada-varobj.c: Revert.
6203         * ada-valprint.c: Revert.
6204         * ada-typeprint.c: Revert.
6205         * ada-tasks.c: Revert.
6206         * ada-lang.c: Revert.
6207         * aarch64-tdep.c: Revert.
6208         * aarch64-ravenscar-thread.c: Revert.
6209         * aarch64-newlib-tdep.c: Revert.
6210         * aarch64-linux-tdep.c: Revert.
6211         * aarch64-linux-nat.c: Revert.
6212         * aarch64-fbsd-tdep.c: Revert.
6213         * aarch64-fbsd-nat.c: Revert.
6214         * aarch32-linux-nat.c: Revert.
6215
6216 2019-04-05  Tom Tromey  <tom@tromey.com>
6217
6218         * ft32-tdep.c: Sort headers.
6219         * frv-tdep.c: Sort headers.
6220         * frv-linux-tdep.c: Sort headers.
6221         * frame.c: Sort headers.
6222         * frame-unwind.c: Sort headers.
6223         * frame-base.c: Sort headers.
6224         * fork-child.c: Sort headers.
6225         * findvar.c: Sort headers.
6226         * findcmd.c: Sort headers.
6227         * filesystem.c: Sort headers.
6228         * filename-seen-cache.h: Sort headers.
6229         * filename-seen-cache.c: Sort headers.
6230         * fbsd-tdep.c: Sort headers.
6231         * fbsd-nat.h: Sort headers.
6232         * fbsd-nat.c: Sort headers.
6233         * f-valprint.c: Sort headers.
6234         * f-typeprint.c: Sort headers.
6235         * f-lang.c: Sort headers.
6236         * extension.h: Sort headers.
6237         * extension.c: Sort headers.
6238         * extension-priv.h: Sort headers.
6239         * expprint.c: Sort headers.
6240         * exec.h: Sort headers.
6241         * exec.c: Sort headers.
6242         * exceptions.c: Sort headers.
6243         * event-top.c: Sort headers.
6244         * event-loop.c: Sort headers.
6245         * eval.c: Sort headers.
6246         * elfread.c: Sort headers.
6247         * dwarf2read.h: Sort headers.
6248         * dwarf2read.c: Sort headers.
6249         * dwarf2loc.c: Sort headers.
6250         * dwarf2expr.h: Sort headers.
6251         * dwarf2expr.c: Sort headers.
6252         * dwarf2-frame.c: Sort headers.
6253         * dwarf2-frame-tailcall.c: Sort headers.
6254         * dwarf-index-write.h: Sort headers.
6255         * dwarf-index-write.c: Sort headers.
6256         * dwarf-index-common.c: Sort headers.
6257         * dwarf-index-cache.h: Sort headers.
6258         * dwarf-index-cache.c: Sort headers.
6259         * dummy-frame.c: Sort headers.
6260         * dtrace-probe.c: Sort headers.
6261         * disasm.h: Sort headers.
6262         * disasm.c: Sort headers.
6263         * disasm-selftests.c: Sort headers.
6264         * dictionary.c: Sort headers.
6265         * dicos-tdep.c: Sort headers.
6266         * demangle.c: Sort headers.
6267         * dcache.h: Sort headers.
6268         * dcache.c: Sort headers.
6269         * darwin-nat.h: Sort headers.
6270         * darwin-nat.c: Sort headers.
6271         * darwin-nat-info.c: Sort headers.
6272         * d-valprint.c: Sort headers.
6273         * d-namespace.c: Sort headers.
6274         * d-lang.c: Sort headers.
6275         * ctf.c: Sort headers.
6276         * csky-tdep.c: Sort headers.
6277         * csky-linux-tdep.c: Sort headers.
6278         * cris-tdep.c: Sort headers.
6279         * cris-linux-tdep.c: Sort headers.
6280         * cp-valprint.c: Sort headers.
6281         * cp-support.c: Sort headers.
6282         * cp-namespace.c: Sort headers.
6283         * cp-abi.c: Sort headers.
6284         * corelow.c: Sort headers.
6285         * corefile.c: Sort headers.
6286         * continuations.c: Sort headers.
6287         * completer.h: Sort headers.
6288         * completer.c: Sort headers.
6289         * complaints.c: Sort headers.
6290         * coffread.c: Sort headers.
6291         * coff-pe-read.c: Sort headers.
6292         * cli-out.h: Sort headers.
6293         * cli-out.c: Sort headers.
6294         * charset.c: Sort headers.
6295         * c-varobj.c: Sort headers.
6296         * c-valprint.c: Sort headers.
6297         * c-typeprint.c: Sort headers.
6298         * c-lang.c: Sort headers.
6299         * buildsym.c: Sort headers.
6300         * buildsym-legacy.c: Sort headers.
6301         * build-id.h: Sort headers.
6302         * build-id.c: Sort headers.
6303         * btrace.c: Sort headers.
6304         * bsd-uthread.c: Sort headers.
6305         * breakpoint.h: Sort headers.
6306         * breakpoint.c: Sort headers.
6307         * break-catch-throw.c: Sort headers.
6308         * break-catch-syscall.c: Sort headers.
6309         * break-catch-sig.c: Sort headers.
6310         * blockframe.c: Sort headers.
6311         * block.c: Sort headers.
6312         * bfin-tdep.c: Sort headers.
6313         * bfin-linux-tdep.c: Sort headers.
6314         * bfd-target.c: Sort headers.
6315         * bcache.c: Sort headers.
6316         * ax-general.c: Sort headers.
6317         * ax-gdb.h: Sort headers.
6318         * ax-gdb.c: Sort headers.
6319         * avr-tdep.c: Sort headers.
6320         * auxv.c: Sort headers.
6321         * auto-load.c: Sort headers.
6322         * arm-wince-tdep.c: Sort headers.
6323         * arm-tdep.c: Sort headers.
6324         * arm-symbian-tdep.c: Sort headers.
6325         * arm-pikeos-tdep.c: Sort headers.
6326         * arm-obsd-tdep.c: Sort headers.
6327         * arm-nbsd-tdep.c: Sort headers.
6328         * arm-nbsd-nat.c: Sort headers.
6329         * arm-linux-tdep.c: Sort headers.
6330         * arm-linux-nat.c: Sort headers.
6331         * arm-fbsd-tdep.c: Sort headers.
6332         * arm-fbsd-nat.c: Sort headers.
6333         * arm-bsd-tdep.c: Sort headers.
6334         * arch-utils.c: Sort headers.
6335         * arc-tdep.c: Sort headers.
6336         * arc-newlib-tdep.c: Sort headers.
6337         * annotate.h: Sort headers.
6338         * annotate.c: Sort headers.
6339         * amd64-windows-tdep.c: Sort headers.
6340         * amd64-windows-nat.c: Sort headers.
6341         * amd64-tdep.c: Sort headers.
6342         * amd64-sol2-tdep.c: Sort headers.
6343         * amd64-obsd-tdep.c: Sort headers.
6344         * amd64-obsd-nat.c: Sort headers.
6345         * amd64-nbsd-tdep.c: Sort headers.
6346         * amd64-nbsd-nat.c: Sort headers.
6347         * amd64-nat.c: Sort headers.
6348         * amd64-linux-tdep.c: Sort headers.
6349         * amd64-linux-nat.c: Sort headers.
6350         * amd64-fbsd-tdep.c: Sort headers.
6351         * amd64-fbsd-nat.c: Sort headers.
6352         * amd64-dicos-tdep.c: Sort headers.
6353         * amd64-darwin-tdep.c: Sort headers.
6354         * amd64-bsd-nat.c: Sort headers.
6355         * alpha-tdep.c: Sort headers.
6356         * alpha-obsd-tdep.c: Sort headers.
6357         * alpha-nbsd-tdep.c: Sort headers.
6358         * alpha-mdebug-tdep.c: Sort headers.
6359         * alpha-linux-tdep.c: Sort headers.
6360         * alpha-linux-nat.c: Sort headers.
6361         * alpha-bsd-tdep.c: Sort headers.
6362         * alpha-bsd-nat.c: Sort headers.
6363         * aix-thread.c: Sort headers.
6364         * agent.c: Sort headers.
6365         * addrmap.c: Sort headers.
6366         * ada-varobj.c: Sort headers.
6367         * ada-valprint.c: Sort headers.
6368         * ada-typeprint.c: Sort headers.
6369         * ada-tasks.c: Sort headers.
6370         * ada-lang.c: Sort headers.
6371         * aarch64-tdep.c: Sort headers.
6372         * aarch64-ravenscar-thread.c: Sort headers.
6373         * aarch64-newlib-tdep.c: Sort headers.
6374         * aarch64-linux-tdep.c: Sort headers.
6375         * aarch64-linux-nat.c: Sort headers.
6376         * aarch64-fbsd-tdep.c: Sort headers.
6377         * aarch64-fbsd-nat.c: Sort headers.
6378         * aarch32-linux-nat.c: Sort headers.
6379
6380 2019-04-04  Tom Tromey  <tom@tromey.com>
6381
6382         * varobj.c (varobj_create): Update.
6383         * rust-exp.y (struct rust_parser) <update_innermost_block,
6384         lookup_symbol>: New methods.
6385         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6386         Rename.
6387         (rust_parser::rust_lookup_type)
6388         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6389         * printcmd.c (display_command, do_one_display): Update.
6390         * parser-defs.h (struct parser_state) <parser_state>: Add
6391         "tracker" parameter.
6392         (block_tracker): New member.
6393         (class innermost_block_tracker) <innermost_block_tracker>: Add
6394         "types" parameter.
6395         <reset>: Remove method.
6396         (innermost_block): Don't declare.
6397         (null_post_parser): Update.
6398         * parse.c (innermost_block): Remove global.
6399         (write_dollar_variable): Update.
6400         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6401         Remove "tracker_types" parameter.
6402         (parse_expression): Add "tracker" parameter.
6403         (parse_expression_for_completion): Update.
6404         (null_post_parser): Add "tracker" parameter.
6405         * p-exp.y: Update rules.
6406         * m2-exp.y: Update rules.
6407         * language.h (struct language_defn) <la_post_parser>: Add
6408         "tracker" parameter.
6409         * go-exp.y: Update rules.
6410         * f-exp.y: Update rules.
6411         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6412         parameter.
6413         * d-exp.y: Update rules.
6414         * c-exp.y: Update rules.
6415         * breakpoint.c (set_breakpoint_condition): Create an
6416         innermost_block_tracker.
6417         (watch_command_1): Likewise.
6418         * ada-lang.c (resolve): Add "tracker" parameter.
6419         (resolve_subexp): Likewise.
6420         * ada-exp.y (write_var_from_sym): Update.
6421
6422 2019-04-04  Tom Tromey  <tom@tromey.com>
6423
6424         * type-stack.h: New file.
6425         * type-stack.c: New file.
6426         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6427         type-stack.h.
6428         (insert_into_type_stack, insert_type, push_type, push_type_int)
6429         (insert_type_address_space, pop_type, pop_type_int)
6430         (pop_typelist, pop_type_stack, append_type_stack)
6431         (push_type_stack, get_type_stack, push_typelist)
6432         (follow_type_instance_flags, follow_types): Don't declare.
6433         * parse.c (type_stack): Remove global.
6434         (parse_exp_in_context): Update.
6435         (insert_into_type_stack, insert_type, push_type, push_type_int)
6436         (insert_type_address_space, pop_type, pop_type_int)
6437         (pop_typelist, pop_type_stack, append_type_stack)
6438         (push_type_stack, get_type_stack, push_typelist)
6439         (follow_type_instance_flags, follow_types): Remove (moved to
6440         type-stack.c).
6441         * f-exp.y (type_stack): New global.
6442         Update rules.
6443         (push_kind_type, f_parse): Update.
6444         * d-exp.y (type_stack): New global.
6445         Update rules.
6446         (d_parse): Update.
6447         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6448         Update rules.
6449         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6450         (HFILES_NO_SRCDIR): Add type-stack.h.
6451
6452 2019-04-04  Tom Tromey  <tom@tromey.com>
6453
6454         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6455         (rust_parser::convert_ast_to_expression, rust_parse)
6456         (rust_lex_test_completion, rust_lex_tests): Update.
6457         * parser-defs.h (struct expr_completion_state): New.
6458         (struct parser_state) <parser_state>: Add completion parameter.
6459         <mark_struct_expression, mark_completion_tag>: New methods.
6460         <parse_completion, m_completion_state>: New members.
6461         (prefixify_expression, null_post_parser): Update.
6462         (mark_struct_expression, mark_completion_tag): Don't declare.
6463         * parse.c (parse_completion, expout_last_struct)
6464         (expout_tag_completion_type, expout_completion_name): Remove
6465         globals.
6466         (parser_state::mark_struct_expression)
6467         (parser_state::mark_completion_tag): Now methods.
6468         (prefixify_expression): Add last_struct parameter.
6469         (prefixify_subexp): Likewise.
6470         (parse_exp_1): Update.
6471         (parse_exp_in_context): Add cstate parameter.  Update.
6472         (parse_expression_for_completion): Create an
6473         expr_completion_state.
6474         (null_post_parser): Add "completion" parameter.
6475         * p-exp.y: Update rules.
6476         (yylex): Update.
6477         * language.h (struct language_defn) <la_post_parser>: Add
6478         "completing" parameter.
6479         * go-exp.y: Update rules.
6480         (lex_one_token): Update.
6481         * expression.h (parse_completion): Don't declare.
6482         * d-exp.y: Update rules.
6483         (lex_one_token): Update rules.
6484         * c-exp.y: Update rules.
6485         (lex_one_token): Update.
6486         * ada-lang.c (resolve): Add "parse_completion" parameter.
6487         (resolve_subexp): Likewise.
6488         (ada_resolve_function): Likewise.
6489
6490 2019-04-04  Tom Tromey  <tom@tromey.com>
6491
6492         * parser-defs.h (struct parser_state) <start_arglist,
6493         end_arglist>: New methods.
6494         <arglist_len, m_funcall_chain>: New members.
6495         (arglist_len, start_arglist, end_arglist): Don't declare.
6496         * parse.c (arglist_len, funcall_chain): Remove global.
6497         (start_arglist, end_arglist): Remove functions.
6498         (parse_exp_in_context): Update.
6499         * p-exp.y: Update rules.
6500         * m2-exp.y: Update rules.
6501         * go-exp.y: Update rules.
6502         * f-exp.y: Update rules.
6503         * d-exp.y: Update rules.
6504         * c-exp.y: Update rules.
6505
6506 2019-04-04  Tom Tromey  <tom@tromey.com>
6507
6508         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6509         lex_operator, push_back>: New methods.
6510         Update all rules.
6511         (rust_parser::lex_hex, lex_escape): Rename and update.
6512         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6513         (rust_parser::lex_operator): Rename and update.
6514         (rust_parser::lex_number, rustyylex, rustyyerror)
6515         (rust_lex_test_init, rust_lex_test_sequence)
6516         (rust_lex_test_push_back, rust_lex_tests): Update.
6517         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6518         parameter.
6519         <lexptr, prev_lexptr>: New members.
6520         (lexptr, prev_lexptr): Don't declare.
6521         * parse.c (lexptr, prev_lexptr): Remove globals.
6522         (parse_exp_in_context): Update.
6523         * p-exp.y (yylex, yyerror): Update.
6524         * m2-exp.y (parse_number, yylex, yyerror): Update.
6525         * go-exp.y (lex_one_token, yyerror): Update.
6526         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6527         * d-exp.y (lex_one_token, yyerror): Update.
6528         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6529         (lex_one_token, yyerror): Update.
6530         * ada-lex.l (YY_INPUT): Update.
6531         (rewind_to_char): Update.
6532         * ada-exp.y (yyerror): Update.
6533
6534 2019-04-04  Tom Tromey  <tom@tromey.com>
6535
6536         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6537         * parser-defs.h (struct parser_state) <parser_state>: Add new
6538         parameter.
6539         <comma_terminates>: New member.
6540         (comma_terminates): Don't declare global.
6541         * parse.c (comma_terminates): Remove global.
6542         (parse_exp_in_context): Update.
6543         * p-exp.y (yylex): Update.
6544         * m2-exp.y (yylex): Update.
6545         * go-exp.y (lex_one_token): Update.
6546         * f-exp.y (yylex): Update.
6547         * d-exp.y (lex_one_token): Update.
6548         * c-exp.y (lex_one_token): Update.
6549         * ada-lex.l: Update.
6550
6551 2019-04-04  Tom Tromey  <tom@tromey.com>
6552
6553         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6554         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6555         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6556         * parser-defs.h (paren_depth): Don't declare.
6557         * parse.c (paren_depth): Remove global.
6558         (parse_exp_in_context): Update.
6559         * p-exp.y (paren_depth): New global.
6560         (pascal_parse): Initialize it.
6561         * m2-exp.y (paren_depth): New global.
6562         (m2_parse): Initialize it.
6563         * go-exp.y (paren_depth): New global.
6564         (go_parse): Initialize it.
6565         * f-exp.y (paren_depth): New global.
6566         (f_parse): Initialize it.
6567         * d-exp.y (paren_depth): New global.
6568         (d_parse): Initialize it.
6569         * c-exp.y (paren_depth): New global.
6570         (c_parse): Initialize it.
6571         * ada-lex.l (paren_depth): New global.
6572         (lexer_init): Initialize it.
6573
6574 2019-04-04  Tom Tromey  <tom@tromey.com>
6575
6576         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6577         (rust_parser::convert_ast_to_type)
6578         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6579         * parser-defs.h (struct parser_state) <parser_state>: Add
6580         parameters.  Initialize new members.
6581         <expression_context_block, expression_context_pc>: New members.
6582         * parse.c (expression_context_block, expression_context_pc):
6583         Remove globals.
6584         (parse_exp_in_context): Update.
6585         * p-exp.y: Update all rules.
6586         (yylex): Update.
6587         * m2-exp.y: Update all rules.
6588         (yylex): Update.
6589         * go-exp.y (yylex): Update.
6590         * f-exp.y (yylex): Update.
6591         * d-exp.y: Update all rules.
6592         (yylex): Update.
6593         * c-exp.y: Update all rules.
6594         (lex_one_token, classify_name, yylex, c_parse): Update.
6595         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6596
6597 2019-04-04  Tom Tromey  <tom@tromey.com>
6598
6599         * gdbarch.h, gdbarch.c: Rebuild.
6600         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6601         * stap-probe.h:
6602         (struct stap_parse_info): Replace "parser_state" with
6603         "expr_builder".
6604         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6605         (parser_state): New class.
6606         * parse.c (expr_builder): Rename.
6607         (expr_builder::release): Rename.
6608         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6609         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6610         (write_exp_elt_longcst, write_exp_elt_floatcst)
6611         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6612         (write_exp_string_vector, write_exp_bitstring)
6613         (write_exp_msymbol, mark_struct_expression)
6614         (write_dollar_variable)
6615         (insert_type_address_space, increase_expout_size): Replace
6616         "parser_state" with "expr_builder".
6617         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6618         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6619         "parser_state" with "expr_builder".
6620
6621 2019-04-04  Tom Tromey  <tom@tromey.com>
6622
6623         * rust-exp.y: Replace "parse_language" with method call.
6624         * p-exp.y:
6625         (yylex): Replace "parse_language" with method call.
6626         * m2-exp.y:
6627         (yylex): Replace "parse_language" with method call.
6628         * go-exp.y (classify_name): Replace "parse_language" with method
6629         call.
6630         * f-exp.y (yylex): Replace "parse_language" with method call.
6631         * d-exp.y (lex_one_token): Replace "parse_language" with method
6632         call.
6633         * c-exp.y:
6634         (lex_one_token, classify_name, yylex): Replace "parse_language"
6635         with method call.
6636         * ada-exp.y (find_primitive_type, type_char)
6637         (type_system_address): Replace "parse_language" with method call.
6638
6639 2019-04-04  Tom Tromey  <tom@tromey.com>
6640
6641         * rust-exp.y: Replace "parse_gdbarch" with method call.
6642         * parse.c (write_dollar_variable, insert_type_address_space):
6643         Replace "parse_gdbarch" with method call.
6644         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6645         call.
6646         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6647         call.
6648         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6649         "parse_gdbarch" with method call.
6650         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6651         with method call.
6652         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6653         "parse_gdbarch" with method call.
6654         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6655         "parse_gdbarch" with method call.
6656         * c-exp.y (parse_type, parse_number, classify_name): Replace
6657         "parse_gdbarch" with method call.
6658         * ada-lex.l: Replace "parse_gdbarch" with method call.
6659         * ada-exp.y (parse_type, find_primitive_type, type_char)
6660         (type_system_address): Replace "parse_gdbarch" with method call.
6661
6662 2019-04-04  Tom Tromey  <tom@tromey.com>
6663
6664         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6665         * stap-probe.c (stap_parse_argument): Update.
6666         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6667         initial_size parameter.
6668         * rust-exp.y (rust_lex_tests): Update.
6669         * parse.c (parser_state): Update.
6670         (parse_exp_in_context): Update.
6671         * parser-defs.h (struct parser_state) <parser_state>: Remove
6672         "initial_size" parameter.
6673
6674 2019-04-04  Tom Tromey  <tom@tromey.com>
6675
6676         * parser-defs.h (increase_expout_size): Don't declare.
6677         * parse.c (increase_expout_size): Now static.
6678
6679 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6680
6681         * gnu-nat.c (gnu_nat_target::wait): Fix
6682         target_waitstatus_to_string call.
6683
6684 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6685
6686         * eval.c (evaluate_subexp_standard): Handle internal functions
6687         during Fortran function call handling.
6688
6689 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6690
6691         * NEWS: Mention new internal functions.
6692         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6693         (read_base_type): Use dwarf2_init_complex_target_type.
6694         * value.c (creal_internal_fn): New function.
6695         (cimag_internal_fn): New function.
6696         (_initialize_values): Register new internal functions.
6697
6698 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6699
6700         * infrun.c (stop_all_threads): If debug_infrun, always
6701         trace the wait status after wait_one, using
6702         target_waitstatus_to_string and target_pid_to_str.
6703         (handle_inferior_event): Replace various trace of
6704         wait status kind by a single trace.
6705         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6706         wait status kind image by target_waitstatus_to_string.
6707         * target/waitstatus.c (target_waitstatus_to_string): Fix
6708         obsolete comment.
6709
6710 2019-04-01  Tom Tromey  <tromey@adacore.com>
6711
6712         PR symtab/23331:
6713         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6714
6715 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6716             Pedro Alves  <palves@redhat.com>
6717
6718         * top.c (quit_force): Call 'finalize_values'.
6719         * value.c (finalize_values): New function.
6720         * value.h (finalize_values): Declare.
6721
6722 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6723
6724         * NEWS: Announce $_gdb_major and $_gdb_minor.
6725
6726         * top.c (init_gdb_version_vars): New function.
6727         (gdb_init): Call init_gdb_version_vars.
6728
6729 2019-03-29  Tom Tromey  <tromey@adacore.com>
6730
6731         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6732         help text.  Remove dead code.
6733
6734 2019-03-29  Keith Seitz  <keiths@redhat.com>
6735
6736         From Siddhesh Poyarekar:
6737         * f-lang.h (f77_get_upperbound): Return LONGEST.
6738         (f77_get_lowerbound): Likewise.
6739         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6740         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6741         print them.
6742         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6743         plongest to format print it.
6744         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6745         (f77_get_upperbound): Likewise.
6746         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6747         LOWER_BOUND to LONGEST.
6748         (f77_create_arrayprint_offset_tbl): Likewise.
6749
6750 2019-03-29  Keith Seitz  <keiths@redhat.com>
6751
6752         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6753         %s/pulongest for TYPE_LENGTH instead of %d in format
6754         strings.
6755         * ada-typerint.c (ada_print_type): Likewise.
6756         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6757         * compile/compile-c-support.c (generate_register_struct): Likewise.
6758         * gdbtypes.c (recursive_dump_type): Likewise.
6759         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6760         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6761         instead of %d in format strings.
6762         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6763         to std::min to ULONGEST.
6764         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6765         instead of %d in format strings.
6766         * tracepoint.c (info_scope_command): Likewise.
6767         * typeprint.c (print_offset_data::update)
6768         (print_offset_data::finish): Likewise.
6769         * xtensa-tdep.c (xtensa_store_return_value)
6770         (xtensa_push_dummy_call): Likewise.
6771
6772 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6773
6774         * windows-nat.c (display_selector): Fixed format specifications
6775         for 64-bit Cygwin.
6776
6777 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6778
6779         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6780
6781 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6782
6783         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6784         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6785         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6786         (nios2_linux_init_abi): Install it.
6787
6788 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6789
6790         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6791
6792 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6793
6794         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6795
6796 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6797             Tom Tromey  <tromey@adacore.com>
6798
6799         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6800
6801 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6802
6803         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6804         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6805         method to compute the bounds of range types. Also print "[evaluated]"
6806         if the bounds' values come from a dynamic evaluation.
6807
6808 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6809
6810         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6811         whitespace when pretty printing is on.
6812
6813 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6814
6815         * ppc-linux-nat.c: Add include.
6816
6817 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6818
6819         * NEWS: Mention AArch64 Pointer Authentication.
6820
6821 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6822
6823         * arm-linux-nat.c: Add include.
6824
6825 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6826
6827         * source-cache.c (source_cache::get_source_lines): Re-read
6828         fullname after calling open_source_file.
6829
6830 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6831
6832         * NEWS: Mention TLS support for FreeBSD.
6833
6834 2019-03-25  Tom Tromey  <tromey@adacore.com>
6835
6836         * minsyms.c (BUNCH_SIZE): Update comment.
6837         (~minimal_symbol_reader): Remove old comment.
6838         (compact_minimal_symbols): Update comment.
6839         (minimal_symbol_reader::install): Remove old comment.  Update
6840         other comments.
6841
6842 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6843
6844         * s390-linux-nat.c: Add include.
6845
6846 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6847
6848         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6849         Call linux_get_hwcap.
6850         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6851         Likewise.
6852         (aarch64_linux_get_hwcap): Remove function.
6853         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6854         declaration.
6855         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6856         linux_get_hwcap.
6857         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6858         * linux-tdep.c (linux_get_hwcap): Add function.
6859         (linux_get_hwcap2): Likewise.
6860         * linux-tdep.h (linux_get_hwcap): Add declaration.
6861         (linux_get_hwcap2): Likewise.
6862         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6863         (ppc_linux_get_hwcap2): Likewise.
6864         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6865         linux_get_hwcap.
6866         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6867         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6868         (ppc_linux_nat_target::read_description): Likewise.
6869         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6870         * s390-linux-nat.c: Likewise.
6871         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6872
6873 2019-03-24  Tom Tromey  <tom@tromey.com>
6874
6875         * ada-lang.c (standard_lookup): Simplify initialization.
6876         (ada_lookup_symbol_nonlocal): Simplify return.
6877         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6878         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6879         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6880         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6881         initialization.
6882         * solib.c (solib_global_lookup): Simplify.
6883         * symtab.c (null_block_symbol): Remove.
6884         (symbol_cache_lookup): Simplify returns.
6885         (lookup_language_this): Simplify returns.
6886         (lookup_symbol_aux): Simplify return.
6887         (lookup_local_symbol): Simplify returns.
6888         (lookup_global_symbol_from_objfile): Simplify return.
6889         (lookup_symbol_in_objfile_symtabs)
6890         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6891         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6892         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6893         * cp-namespace.c (cp_lookup_bare_symbol)
6894         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6895         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6896         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6897         (cp_lookup_symbol_via_imports): Simplify initialization.
6898         (find_symbol_in_baseclass): Likewise.
6899         * symtab.h (null_block_symbol): Remove.
6900         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6901         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6902         (d_lookup_symbol_module): Likewise.
6903         (find_symbol_in_baseclass): Simplify initialization.
6904
6905 2019-03-24  Tom Tromey  <tom@tromey.com>
6906
6907         * expression.h: Don't include symtab.h.
6908         (struct block): Forward declare.
6909
6910 2019-03-24  Tom Tromey  <tom@tromey.com>
6911
6912         * c-exp.y (typebase): Remove casts.
6913         * gdbtypes.c (lookup_unsigned_typename, )
6914         (lookup_signed_typename): Remove cast.
6915         * eval.c (parse_to_comma_and_eval): Remove cast.
6916         * parse.c (write_dollar_variable): Remove cast.
6917         * block.h (struct block) <superblock>: Now const.
6918         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6919         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6920         (map_block): Make "block" const.
6921         * symfile.h (struct quick_symbol_functions)
6922         <map_matching_symbols>: Constify block argument to "callback".
6923         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6924         const.
6925         (find_pc_sect_compunit_symtab): Make "b" const.
6926         (find_symbol_at_address): Likewise.
6927         (search_symbols): Likewise.
6928         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6929         (dw2_debug_names_lookup_symbol): Likewise.
6930         (dw2_map_matching_symbols): Update.
6931         * p-valprint.c (pascal_val_print): Remove "block".
6932         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6933         (aux_add_nonlocal_symbols): Make "block" const.
6934         (resolve_subexp): Remove cast.
6935         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6936         const.
6937         (iterate_over_file_blocks): Likewise.
6938         * f-exp.y (%union) <bval>: Remove.
6939         * coffread.c (patch_opaque_types): Make "b" const.
6940         * spu-tdep.c (spu_catch_start): Make "block" const.
6941         * c-valprint.c (print_unpacked_pointer): Remove "block".
6942         * symmisc.c (dump_symtab_1): Make "b" const.
6943         (block_depth): Make "block" const.
6944         * d-exp.y (%union) <bval>: Remove.
6945         * cp-support.h (cp_lookup_rtti_type): Update.
6946         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6947         * psymtab.c (psym_lookup_symbol): Make "block" const.
6948         (maintenance_check_psymtabs): Make "b" const.
6949         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6950         (enumerate_locals, enumerate_args): Update.
6951         * python/py-symtab.c (stpy_global_block): Make "block" const.
6952         (stpy_static_block): Likewise.
6953         * inline-frame.c (block_starting_point_at): Make "new_block"
6954         const.
6955         * block.c (find_block_in_blockvector): Make return type const.
6956         (blockvector_for_pc_sect): Make "b" const.
6957         (find_block_in_blockvector): Make "b" const.
6958
6959 2019-03-23  Tom Tromey  <tom@tromey.com>
6960
6961         * varobj.c (varobj_create): Update.
6962         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6963         * printcmd.c (display_command, do_one_display): Don't reset
6964         innermost_block.
6965         * parser-defs.h (enum innermost_block_tracker_type): Move to
6966         expression.h.
6967         (innermost_block): Update comment.
6968         * parse.c (parse_exp_1): Add tracker_types parameter.
6969         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6970         tracker_types parameter.  Reset innermost_block.
6971         (parse_exp_in_context): Remove.
6972         (parse_expression_for_completion): Update.
6973         * objfiles.c (~objfile): Don't reset expression_context_block or
6974         innermost_block.
6975         * expression.h (enum innermost_block_tracker_type): Move from
6976         parser-defs.h.
6977         (parse_exp_1): Add tracker_types parameter.
6978         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6979         reset innermost_block.
6980
6981 2019-03-23  Tom Tromey  <tom@tromey.com>
6982
6983         * objfiles.h: Include bcache.h.
6984
6985 2019-03-23  Tom Tromey  <tom@tromey.com>
6986
6987         * linespec.c (get_current_search_block): Use
6988         scoped_restore_current_language.
6989         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6990
6991 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6992             Jiong Wang  <jiong.wang@arm.com>
6993
6994         * aarch64-linux-tdep.c
6995         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6996         section.
6997         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6998
6999 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7000             Jiong Wang  <jiong.wang@arm.com>
7001
7002         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7003         instructions.
7004         (aarch64_analyze_prologue_test): Add PACIASP test.
7005         (aarch64_prologue_prev_register): Unmask PC value.
7006
7007 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7008             Jiong Wang  <jiong.wang@arm.com>
7009
7010         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7011         (aarch64_dwarf2_prev_register): Unmask PC value.
7012         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7013         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7014         DW_CFA_AARCH64_negate_ra_state.
7015         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7016
7017 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7018             Jiong Wang  <jiong.wang@arm.com>
7019
7020         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7021         registers.
7022         (aarch64_pseudo_register_name): Likewise.
7023         (aarch64_pseudo_register_type): Likewise.
7024         (aarch64_pseudo_register_reggroup_p): Likewise.
7025         (aarch64_gdbarch_init): Add pauth registers.
7026         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7027         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7028         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7029         (struct gdbarch_tdep): Add regnum for ra_state.
7030
7031 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7032             Jiong Wang  <jiong.wang@arm.com>
7033
7034         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7035
7036 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7037             Jiong Wang  <jiong.wang@arm.com>
7038
7039         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7040         function.
7041         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7042         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7043         (aarch64_gdbarch_init): Add puth registers.
7044         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7045         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7046         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7047
7048 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7049             Jiong Wang  <jiong.wang@arm.com>
7050
7051         * aarch64-linux-nat.c
7052         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7053         * aarch64-linux-tdep.c
7054         (aarch64_linux_core_read_description): Likewise.
7055         (aarch64_linux_get_hwcap): New function.
7056         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7057         (aarch64_linux_get_hwcap): New declaration.
7058
7059 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7060             Jiong Wang  <jiong.wang@arm.com>
7061
7062         * aarch64-linux-nat.c
7063         (aarch64_linux_nat_target::read_description): Add pauth param.
7064         * aarch64-linux-tdep.c
7065         (aarch64_linux_core_read_description): Likewise.
7066         * aarch64-tdep.c (struct target_desc): Add in pauth.
7067         (aarch64_read_description): Add pauth param.
7068         (aarch64_gdbarch_init): Likewise.
7069         * aarch64-tdep.h (aarch64_read_description): Likewise.
7070         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7071         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7072         * features/Makefile: Add new files.
7073         * features/aarch64-pauth.c: New file.
7074         * features/aarch64-pauth.xml: New file.
7075
7076 2019-03-20  Tom Tromey  <tromey@adacore.com>
7077
7078         * infrun.c (handle_inferior_event): Rename from
7079         handle_inferior_event_1.  Create a scoped_value_mark.
7080         (handle_inferior_event): Remove.
7081
7082 2019-03-19  Tom Tromey  <tromey@adacore.com>
7083
7084         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7085         * infrun.h (print_stop_event): Add "displays" parameter.
7086         * infrun.c (print_stop_event): Add "displays" parameter.
7087
7088 2019-03-19  Pedro Alves  <palves@redhat.com>
7089
7090         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7091         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7092         to -1.  Fix TABs vs spaces.
7093         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7094         * tui/tui-out.h (tui_ui_out) Add intro comments.
7095         <m_line, m_start_of_line>: In-class initialize, and add describing
7096         comment.
7097
7098 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7099
7100         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7101         variable names.
7102         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7103
7104 2019-03-18  Pedro Alves  <palves@redhat.com>
7105             Eli Zaretskii <eliz@gnu.org>
7106
7107         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7108         m_line and m_start_of_line.
7109
7110 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7111
7112         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7113         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7114         it returns a newline.  This fixes a regression in TU mode, whereby
7115         the next line is output on the same screen line as the user input.
7116
7117 2019-03-18  Tom Tromey  <tromey@adacore.com>
7118
7119         * minsyms.c (minimal_symbol_reader::install): Remove call to
7120         obstack_blank.
7121
7122 2019-03-18  Pedro Alves  <palves@redhat.com>
7123
7124         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7125         New globals.
7126         (apply_style): New, factored out from ...
7127         (apply_ansi_escape): ... this.  Handle reverse video mode.
7128         (tui_set_reverse_mode): New function.
7129         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7130         * tui/tui-winsource.c (tui_show_source_line): Use
7131         tui_set_reverse_mode instead of setting A_STANDOUT.
7132         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7133         New setter methods.
7134
7135 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7136
7137         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7138         Handle tabs.
7139
7140 2019-03-18  Tom Tromey  <tromey@adacore.com>
7141
7142         * ada-lang.c (empty_array): Add "high" parameter.
7143         (ada_evaluate_subexp): Update.
7144
7145 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7146
7147         * unittests/string_view-selftests.c: Define
7148         _initialize_string_view_selftests unconditionally.
7149
7150 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7151
7152         PR gdb/24350
7153         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7154
7155 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7156
7157         PR gdb/24351
7158         * windows-nat.c (display_selector): Fix format specifiers.
7159
7160 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7161
7162         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7163         tui_refill_source_window instead of tui_refresh_win, to update the
7164         current execution line.  This fixes redisplay of the current line
7165         when stepping through the code with "next" or "step".
7166
7167 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7168
7169         * source-cache.c (source_cache::get_source_lines): Call
7170         find_source_lines to initialize s->nlines.  This fixes vertical
7171         scrolling of TUI source window when the DOWN arrow is pressed.
7172
7173 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7174
7175         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7176         linux-thread-db.c (_initialize_thread_db): Likewise.
7177
7178 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7179
7180         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7181         wclrtoeol in tui_show_source_line".  This reverts changes made in
7182         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7183
7184 2019-03-15  Tom Tromey  <tom@tromey.com>
7185
7186         * symtab.h (struct minimal_symbol): Derive from
7187         general_symbol_info.
7188         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7189         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7190         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7191         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7192         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7193         (MSYMBOL_SEARCH_NAME): Update.
7194         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7195         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7196         * minsyms.c (minimal_symbol_reader::record_full): Update.
7197
7198 2019-03-15  Tom Tromey  <tom@tromey.com>
7199
7200         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7201
7202 2019-03-15  Tom Tromey  <tom@tromey.com>
7203
7204         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7205         unique_xmalloc_ptr.
7206         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7207         Update.
7208         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7209         (build_minimal_symbol_hash_tables)
7210         (minimal_symbol_reader::install): Update.
7211
7212 2019-03-15  Tom Tromey  <tom@tromey.com>
7213
7214         * symtab.c (create_demangled_names_hash): Update.
7215         (symbol_set_names): Update.
7216         * objfiles.h (struct objfile_per_bfd_storage)
7217         <demangled_names_hash>: Now an htab_up.
7218         * objfiles.c (objfile_per_bfd_storage): Simplify.
7219
7220 2019-03-15  Tom Tromey  <tom@tromey.com>
7221
7222         * objfiles.h (struct objfile_per_bfd_storage): Declare
7223         destructor.
7224         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7225         New.
7226         (get_objfile_bfd_data): Use new.  Don't initialize
7227         language_of_main.
7228         (free_objfile_per_bfd_storage): Remove.
7229         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7230
7231 2019-03-15  Tom Tromey  <tom@tromey.com>
7232
7233         * symfile.c (reread_symbols): Update.
7234         * objfiles.c (objfile::objfile): Update.
7235         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7236         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7237         comment.
7238         (minimal_symbol_reader::install): Update.
7239         (terminate_minimal_symbol_table): Remove.
7240         * jit.c (jit_object_close_impl): Update.
7241
7242 2019-03-15  Tom Tromey  <tom@tromey.com>
7243
7244         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7245         initializations.
7246
7247 2019-03-15  Tom Tromey  <tom@tromey.com>
7248
7249         * objfiles.h (struct objfile_per_bfd_storage)
7250         <demangled_hash_languages>: Now a bitset.
7251         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7252         (lookup_minimal_symbol): Update.
7253
7254 2019-03-15  Tom Tromey  <tom@tromey.com>
7255
7256         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7257         Don't return the symbol.
7258         * coffread.c (record_minimal_symbol): Use record_full.
7259
7260 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7261
7262         The MS-Windows port of ncurses fails to switch to a color pair if
7263         one or both of the colors are the implicit default colors.  This
7264         change records the default colors when TUI is initialized, and
7265         then specifies them explicitly when a color pair uses the default
7266         colors.  This allows color styling in TUI mode on MS-Windows.
7267
7268         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7269         ncurses_norm_attr.
7270         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7271         colors in ncurses_norm_attr.
7272         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7273         "none", replace it with the default color recorded in
7274         ncurses_norm_attr.
7275
7276 2019-03-14  Tom Tromey  <tromey@adacore.com>
7277
7278         * source-cache.h (class source_cache) <get_source_lines>: Return
7279         std::string.
7280         * source-cache.c (source_cache::extract_lines): Handle case where
7281         first_pos==npos.  Return std::string.
7282         (source_cache::get_source_lines): Update.
7283
7284 2019-03-14  Tom Tromey  <tromey@adacore.com>
7285
7286         * NEWS: Add item for "style sources" commands.
7287         * source-cache.c (source_cache::get_source_lines): Check
7288         source_styling.
7289         * cli/cli-style.c (source_styling): New global.
7290         (_initialize_cli_style): Add "style sources" commands.
7291         (show_style_sources): New function.
7292         * cli/cli-style.h (source_styling): Declare.
7293
7294 2019-03-14  Pedro Alves  <palves@redhat.com>
7295             Tom Tromey  <tromey@adacore.com>
7296
7297         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7298         * tui/tui-winsource.c (tui_refill_source_window): New function,
7299         from...
7300         (tui_horizontal_source_scroll): ... here.  Move some logic.
7301         * cli/cli-style.c (set_style_enabled): Notify new observable.
7302         * tui/tui-hooks.c (tui_redisplay_source): New function.
7303         (tui_attach_detach_observers): Attach or detach
7304         tui_redisplay_source.
7305         * observable.h (source_styling_changed): New observable.
7306         * observable.c: Define source_styling_changed observable.
7307
7308 2019-03-13  Tom Tromey  <tromey@adacore.com>
7309
7310         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7311         (i386_gnu_nat_target::store_registers): Update.
7312         * target-debug.h (target_debug_print_std_string): New macro.
7313         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7314         * windows-tdep.c (display_one_tib): Update.
7315         * tui/tui-stack.c (tui_make_status_line): Update.
7316         * top.c (print_inferior_quit_action): Update.
7317         * thread.c (thr_try_catch_cmd): Update.
7318         (add_thread_with_info): Update.
7319         (thread_target_id_str): Update.
7320         (thr_try_catch_cmd): Update.
7321         (thread_command): Update.
7322         (thread_find_command): Update.
7323         * record-btrace.c (record_btrace_target::info_record)
7324         (record_btrace_resume_thread, record_btrace_target::resume)
7325         (record_btrace_cancel_resume, record_btrace_step_thread)
7326         (record_btrace_target::wait, record_btrace_target::wait)
7327         (record_btrace_target::wait, record_btrace_target::stop): Update.
7328         * progspace.c (print_program_space): Update.
7329         * process-stratum-target.c
7330         (process_stratum_target::thread_address_space): Update.
7331         * linux-fork.c (linux_fork_mourn_inferior)
7332         (detach_checkpoint_command, info_checkpoints_command)
7333         (linux_fork_context): Update.
7334         (linux_fork_detach): Update.
7335         (class scoped_switch_fork_info): Update.
7336         (delete_checkpoint_command): Update.
7337         * infrun.c (follow_fork_inferior): Update.
7338         (follow_fork_inferior): Update.
7339         (proceed_after_vfork_done): Update.
7340         (handle_vfork_child_exec_or_exit): Update.
7341         (follow_exec): Update.
7342         (displaced_step_prepare_throw): Update.
7343         (displaced_step_restore): Update.
7344         (start_step_over): Update.
7345         (resume_1): Update.
7346         (clear_proceed_status_thread): Update.
7347         (proceed): Update.
7348         (print_target_wait_results): Update.
7349         (do_target_wait): Update.
7350         (context_switch): Update.
7351         (stop_all_threads): Update.
7352         (restart_threads): Update.
7353         (finish_step_over): Update.
7354         (handle_signal_stop): Update.
7355         (switch_back_to_stepped_thread): Update.
7356         (keep_going_pass_signal): Update.
7357         (print_exited_reason): Update.
7358         (normal_stop): Update.
7359         * inferior.c (inferior_pid_to_str): Change return type.
7360         (print_selected_inferior): Update.
7361         (add_inferior): Update.
7362         (detach_inferior): Update.
7363         * dummy-frame.c (fprint_dummy_frames): Update.
7364         * dcache.c (dcache_info_1): Update.
7365         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7366         (btrace_fetch, btrace_clear): Update.
7367         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7368         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7369         type.
7370         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7371         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7372         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7373         * gdbarch.c, gdbarch.h: Rebuild.
7374         * gdbarch.sh (core_pid_to_str): Change return type.
7375         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7376         return type.
7377         (windows_nat_target::pid_to_str): Change return type.
7378         (windows_delete_thread): Update.
7379         (windows_nat_target::attach): Update.
7380         (windows_nat_target::files_info): Update.
7381         * target-delegates.c: Rebuild.
7382         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7383         return type.
7384         (sol_thread_target::pid_to_str): Change return type.
7385         * remote.c (class remote_target) <pid_to_str>: Change return
7386         type.
7387         (remote_target::pid_to_str): Change return type.
7388         (extended_remote_target::attach, remote_target::remote_stop_ns)
7389         (remote_target::remote_notif_remove_queued_reply)
7390         (remote_target::push_stop_reply, remote_target::disable_btrace):
7391         Update.
7392         (extended_remote_target::attach): Update.
7393         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7394         type.
7395         (gdbsim_target::pid_to_str): Change return type.
7396         * ravenscar-thread.c (struct ravenscar_thread_target)
7397         <pid_to_str>: Change return type.
7398         (ravenscar_thread_target::pid_to_str): Change return type.
7399         * procfs.c (class procfs_target) <pid_to_str>: Change return
7400         type.
7401         (procfs_target::pid_to_str): Change return type.
7402         (procfs_target::attach): Update.
7403         (procfs_target::detach): Update.
7404         (procfs_target::fetch_registers): Update.
7405         (procfs_target::store_registers): Update.
7406         (procfs_target::wait): Update.
7407         (procfs_target::files_info): Update.
7408         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7409         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7410         return type.
7411         (nto_procfs_target::pid_to_str): Change return type.
7412         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7413         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7414         return type.
7415         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7416         (exit_lwp): Update.
7417         (attach_proc_task_lwp_callback, get_detach_signal)
7418         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7419         (linux_nat_target::resume, wait_lwp, stop_callback)
7420         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7421         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7422         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7423         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7424         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7425         type.
7426         (inf_ptrace_target::attach): Update.
7427         (inf_ptrace_target::files_info): Update.
7428         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7429         type.
7430         (go32_nat_target::pid_to_str): Change return type.
7431         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7432         (gnu_nat_target::wait): Update.
7433         (gnu_nat_target::wait): Update.
7434         (gnu_nat_target::resume): Update.
7435         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7436         (fbsd_nat_target::wait): Update.
7437         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7438         type.
7439         (darwin_nat_target::attach): Update.
7440         * corelow.c (class core_target) <pid_to_str>: Change return type.
7441         (core_target::pid_to_str): Change return type.
7442         * target.c (normal_pid_to_str): Change return type.
7443         (default_pid_to_str): Likewise.
7444         (target_pid_to_str): Change return type.
7445         (target_translate_tls_address): Update.
7446         (target_announce_detach): Update.
7447         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7448         return type.
7449         (bsd_uthread_target::pid_to_str): Change return type.
7450         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7451         type.
7452         (bsd_kvm_target::pid_to_str): Change return type.
7453         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7454         return type.
7455         (aix_thread_target::pid_to_str): Change return type.
7456         * target.h (struct target_ops) <pid_to_str>: Change return type.
7457         (target_pid_to_str, normal_pid_to_str): Likewise.
7458         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7459         type.
7460         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7461         type.
7462         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7463         return type.
7464         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7465         type.
7466         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7467         type.
7468         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7469         return type.
7470
7471 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7472
7473         * NEWS: Mention that the new default MI version is 3.  Mention
7474         changes to the output of commands and events that deal with
7475         multi-location breakpoints.
7476         * breakpoint.c: Include "mi/mi-out.h".
7477         (print_one_breakpoint): Change output syntax if using MI version
7478         >= 3.
7479         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7480         New.
7481         (mi_multi_location_breakpoint_output_fixed): New.
7482         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7483         (mi_cmd_fix_multi_location_breakpoint_output): New.
7484         (mi_multi_location_breakpoint_output_fixed): New.
7485         * mi/mi-cmds.c (mi_cmds): Register command
7486         -fix-multi-location-breakpoint-output.
7487         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7488         interpreter "mi".
7489
7490 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7491
7492         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7493         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7494         instantiate mi_ui_out based on interpreter name.
7495         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7496         * mi/mi-main.c (mi_load_progress): Likewise.
7497
7498 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7499
7500         * NEWS: Combine separate "New targets" sections for 8.3.
7501
7502 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7503
7504         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7505         (ppcfbsd_init_abi): Install gdbarch
7506         "fetch_tls_load_module_address" and "get_thread_local_address"
7507         methods.
7508
7509 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7510
7511         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7512         (riscv_fbsd_init_abi): Install gdbarch
7513         "fetch_tls_load_module_address" and "get_thread_local_address"
7514         methods.
7515
7516 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7517
7518         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7519         (i386fbsd_init_abi): Install gdbarch
7520         "fetch_tls_load_module_address" and "get_thread_local_address"
7521         methods.
7522
7523 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7524
7525         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7526         (amd64fbsd_init_abi): Install gdbarch
7527         "fetch_tls_load_module_address" and "get_thread_local_address"
7528         methods.
7529
7530 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7531
7532         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7533         (struct fbsd_pspace_data): New type.
7534         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7535         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7536         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7537         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7538         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7539
7540 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7541
7542         * gdbtypes.c (lookup_struct_elt): New function.
7543         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7544         * gdbtypes.h (struct struct_elt): New type.
7545         (lookup_struct_elt): New prototype.
7546
7547 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7548
7549         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7550         remove disabled code block.
7551
7552 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7553
7554         * gdbarch.sh (get_thread_local_address): New method.
7555         * gdbarch.h, gdbarch.c: Regenerate.
7556         * target.c (target_translate_tls_address): Use
7557         gdbarch_get_thread_local_address if present instead of
7558         target::get_thread_local_address.
7559
7560 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7561
7562         * target.h (target::get_thread_local_address): Update comment.
7563
7564 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7565
7566         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7567         objfile->separate_debug_objfile_backlink if not NULL.
7568
7569 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7570
7571         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7572         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7573         (amd64bsd_store_inferior_registers): Likewise.
7574         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7575         Enable segment base registers.
7576         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7577         PT_GETFSBASE and PT_GETGSBASE.
7578         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7579         PT_SETGSBASE.
7580         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7581         segment base registers.
7582         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7583
7584 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7585
7586         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7587         Update calls to i386_target_description to add 'segments'
7588         parameter.
7589         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7590         add segment base registers.
7591         * arch/i386.c (i386_create_target_description): Add 'segments'
7592         parameter to enable segment base registers.
7593         * arch/i386.h (i386_create_target_description): Likewise.
7594         * features/i386/32bit-segments.xml: New file.
7595         * features/i386/32bit-segments.c: Generate.
7596         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7597         call to i386_target_description to add 'segments' parameter.
7598         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7599         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7600         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7601         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7602         if feature is present.
7603         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7604         Add 'segments' parameter to call to i386_target_description.
7605         (i386_target_description): Add 'segments' parameter to enable
7606         segment base registers.
7607         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7608         to call to i386_target_description.
7609         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7610         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7611         Define I386_NUM_REGS.
7612         (i386_target_description): Add 'segments' parameter to enable
7613         segment base registers.
7614
7615 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7616
7617         PR/24325
7618         * source-cache.c: #undef open and close, to avoid unresolved
7619         externals during linking.
7620
7621 2019-03-12  Tom Tromey  <tromey@adacore.com>
7622
7623         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7624         const.  Add initializers.
7625         (_initialize_remote): Don't initialize ptid globals.
7626
7627 2019-03-12  Pedro Alves  <palves@redhat.com>
7628
7629         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7630
7631 2019-03-12  Pedro Alves  <palves@redhat.com>
7632
7633         * cp-name-parser.y (main): Remove unused 'len' variable.
7634
7635 2019-03-12  Tom Tromey  <tromey@adacore.com>
7636
7637         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7638         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7639
7640 2019-03-12  Tom Tromey  <tromey@adacore.com>
7641
7642         * linux-nat.c (iterate_over_lwps): Update.
7643         (stop_callback): Remove parameter.
7644         (stop_wait_callback, detach_callback, resume_set_callback)
7645         (select_singlestep_lwp_callback, set_ignore_sigint)
7646         (status_callback, resumed_callback, resume_clear_callback)
7647         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7648         data parameter.
7649         (linux_nat_target::detach, linux_nat_target::resume)
7650         (linux_stop_and_wait_all_lwps, select_event_lwp)
7651         (linux_nat_filter_event, linux_nat_wait_1)
7652         (linux_nat_target::kill, linux_nat_target::stop)
7653         (linux_nat_target::stop): Update.
7654         (linux_nat_resume_callback): Change type.
7655         (resume_stopped_resumed_lwps, count_events_callback)
7656         (select_event_lwp_callback): Likewise.
7657         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7658         * arm-linux-nat.c (struct update_registers_data): Remove.
7659         (update_registers_callback): Change type.
7660         (arm_linux_insert_hw_breakpoint1): Update.
7661         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7662         parameter.
7663         (x86_linux_dr_set_addr): Update.
7664         (x86_linux_dr_set_control): Update.
7665         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7666         (iterate_over_lwps): Use gdb::function_view.
7667         * nat/aarch64-linux-hw-point.c (struct
7668         aarch64_dr_update_callback_param): Remove.
7669         (debug_reg_change_callback): Change type.
7670         (aarch64_notify_debug_reg_change): Update.
7671         * s390-linux-nat.c (s390_refresh_per_info): Update.
7672
7673 2019-03-11  Tom Tromey  <tromey@adacore.com>
7674
7675         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7676         redundant assignment to "this_cu".
7677
7678 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7679
7680         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7681
7682 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7683
7684         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7685         from...
7686         (rank_one_type): ... this.
7687
7688 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7689
7690         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7691         from...
7692         (rank_one_type): ... this.
7693
7694 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7695
7696         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7697         from...
7698         (rank_one_type): ... this.
7699
7700 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7701
7702         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7703         from...
7704         (rank_one_type): ... this.
7705
7706 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7707
7708         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7709         from...
7710         (rank_one_type): ... this.
7711
7712 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7713
7714         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7715         from...
7716         (rank_one_type): ... this.
7717
7718 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7719
7720         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7721         from...
7722         (rank_one_type): ... this.
7723
7724 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7725
7726         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7727         from...
7728         (rank_one_type): ... this.
7729
7730 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7731
7732         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7733         from...
7734         (rank_one_type): ... this.
7735
7736 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7737
7738         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7739         from...
7740         (rank_one_type): ... this.
7741
7742 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7743
7744         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7745         from...
7746         (rank_one_type): ... this.
7747
7748 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7749
7750         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7751         from...
7752         (rank_one_type): ... this.
7753
7754 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7755
7756         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7757         inferior-events' shows the example events.
7758
7759 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7760
7761         Support styling on native MS-Windows console
7762
7763         PR/24315
7764         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7765         on MS-Windows if $TERM is not defined.
7766
7767         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7768
7769         * posix-hdep.c (gdb_console_fputs):
7770         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7771         functions.
7772         * ui-file.h (gdb_console_fputs): Add prototype.
7773
7774         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7775         back to fputs only if the former returns zero.
7776
7777 2019-03-07  Tom Tromey  <tom@tromey.com>
7778
7779         * symmisc.c (print_symbol_bcache_statistics): Update.
7780         (print_objfile_statistics): Update.
7781         * symfile.c (allocate_symtab): Update.
7782         * stabsread.c: Don't include bcache.h.
7783         * psymtab.h (struct psymbol_bcache): Don't declare.
7784         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7785         (psymbol_bcache_init, psymbol_bcache_free)
7786         (psymbol_bcache_get_bcache): Don't declare.
7787         * psymtab.c (struct psymbol_bcache): Remove.
7788         (psymtab_storage::psymtab_storage): Update.
7789         (psymtab_storage::~psymtab_storage): Update.
7790         (psymbol_bcache_init, psymbol_bcache_free)
7791         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7792         (add_psymbol_to_bcache): Update.
7793         (allocate_psymtab): Update.
7794         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7795         macro_cache>: No longer pointers.
7796         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7797         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7798         * macrotab.c (macro_bcache): Update.
7799         * macroexp.c: Don't include bcache.h.
7800         * gdbtypes.c (check_types_worklist): Update.
7801         (types_deeply_equal): Remove TRY/CATCH.  Update.
7802         * elfread.c (elf_symtab_read): Update.
7803         * dwarf2read.c: Don't include bcache.h.
7804         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7805         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7806         (print_bcache_statistics, bcache_memory_used): Don't declare.
7807         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7808         methods.  Rename all data members.
7809         * bcache.c (struct bcache): Move to bcache.h.
7810         (bcache::expand_hash_table): Rename from expand_hash_table.
7811         (bcache): Remove.
7812         (bcache::insert): Rename from bcache_full.
7813         (bcache::compare): Rename from bcache_compare.
7814         (bcache_xmalloc): Remove.
7815         (bcache::~bcache): Rename from bcache_xfree.
7816         (bcache::print_statistics): Rename from print_bcache_statistics.
7817         (bcache::memory_used): Rename from bcache_memory_used.
7818
7819 2019-03-07  Pedro Alves  <palves@redhat.com>
7820
7821         * infrun.c (normal_stop): Also check for
7822         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7823
7824 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7825
7826         * f-lang.c (value_from_host_double): Moved to...
7827         * value.c (value_from_host_double): ...here.
7828         * value.h (value_from_host_double): Declare.
7829         * guile/scm-math.c (vlscm_convert_typed_number): Use
7830         value_from_host_double.
7831         (vlscm_convert_number): Likewise.
7832         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7833         * python/py-value.c (convert_value_from_python): Likewise.
7834
7835 2019-03-06  Tom Tromey  <tom@tromey.com>
7836
7837         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7838
7839 2019-03-06  Tom Tromey  <tom@tromey.com>
7840
7841         * utils.h (free_current_contents): Don't declare.
7842         * utils.c (free_current_contents): Remove.
7843
7844 2019-03-06  Tom Tromey  <tom@tromey.com>
7845
7846         * top.c (quit_force): Update.
7847         * main.c (captured_command_loop): Update.
7848         * common/new-op.c (operator new): Update.
7849         * common/common-exceptions.c (struct catcher)
7850         <save_cleanup_chain>: Remove member.
7851         (exceptions_state_mc_init): Update.
7852         (exception_try_scope_entry): Return nullptr.
7853         (exception_try_scope_exit, exception_rethrow)
7854         (throw_exception_sjlj, throw_exception_cxx): Update.
7855         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7856         (all_cleanups, do_cleanups, discard_cleanups)
7857         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7858         (restore_cleanups, restore_final_cleanups): Don't declare.
7859         (do_final_cleanups): Remove parameter.
7860         * common/cleanups.c (cleanup_chain, make_cleanup)
7861         (make_cleanup_dtor, all_cleanups, do_cleanups)
7862         (discard_my_cleanups, discard_cleanups)
7863         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7864         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7865         (null_cleanup): Remove.
7866         (do_final_cleanups): Remove parameter.
7867
7868 2019-03-06  Tom Tromey  <tom@tromey.com>
7869
7870         * remote.c (remote_target::remote_parse_stop_reply): Use
7871         unique_xmalloc_ptr.
7872
7873 2019-03-06  Tom Tromey  <tom@tromey.com>
7874
7875         * stabsread.c (struct stabs_field_info): Rename from field_info.
7876         <list, fnlist>: Add initializers.
7877         <obstack>: New member.
7878         (read_member_functions, read_struct_fields, read_baseclasses):
7879         Allocate on obstack.  Don't use cleanups.
7880         (read_one_struct_field, read_member_functions, read_struct_fields)
7881         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7882         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7883         (read_struct_type): Update.
7884
7885 2019-03-06  Tom Tromey  <tom@tromey.com>
7886
7887         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7888         * common/filestuff.h (make_cleanup_close): Don't declare.
7889         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7890         Remove.
7891
7892 2019-03-06  Tom Tromey  <tom@tromey.com>
7893
7894         * solib-aix.c: Use make_scope_exit.
7895
7896 2019-03-06  Tom Tromey  <tom@tromey.com>
7897
7898         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7899         Use make_scope_exit.
7900
7901 2019-03-06  Tom Tromey  <tom@tromey.com>
7902
7903         * solib-svr4.c (disable_probes_interface): Remove parameter.
7904         (svr4_handle_solib_event): Use make_scope_exit.
7905
7906 2019-03-06  Tom Tromey  <tom@tromey.com>
7907
7908         * remote.c (struct stop_reply_deleter): Remove.
7909         (stop_reply_up): Update.
7910         (struct stop_reply): Derive from notif_event.  Don't typedef.
7911         <regcache>: Now a std::vector.
7912         (stop_reply_xfree): Remove.
7913         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7914         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7915         (remote_target::discard_pending_stop_replies): Use delete.
7916         (remote_target::remote_parse_stop_reply): Update.
7917         (remote_target::process_stop_reply): Update.
7918         * remote-notif.h (struct notif_event): Add virtual destructor.
7919         Remove "dtr" member.
7920         (struct notif_client) <alloc_event>: Return a unique_ptr.
7921         (notif_event_xfree): Don't declare.
7922         (notif_event_up): New typedef.
7923         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7924         (notif_event_xfree, do_notif_event_xfree): Remove.
7925         (remote_notif_state_xfree): Update.
7926
7927 2019-03-06  Tom Tromey  <tom@tromey.com>
7928
7929         * infrun.c (displaced_step_clear_cleanup): Now a
7930         forward_scope_exit type.
7931         (displaced_step_prepare_throw): Update.
7932         (displaced_step_fixup): Update.
7933
7934 2019-03-06  Tom Tromey  <tom@tromey.com>
7935
7936         * inferior.h (class inferior): Update comment.
7937         * gdbthread.h (class thread_info): Update comment.
7938
7939 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7940             Tom Tromey  <tom@tromey.com>
7941
7942         * stabsread.h (struct stab_section_list): Remove.
7943         (coffstab_build_psymtabs): Update.
7944         * dbxread.c (symbuf_sections): Now a std::vector.
7945         (sect_idx): New global.
7946         (fill_symbuf): Update.
7947         (coffstab_build_psymtabs): Change type of stabsects parameter.
7948         Update.
7949         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7950         std::vector.
7951         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7952         (coff_locate_sections): Update.
7953         (coff_symfile_read): Remove cleanups.  Update.
7954         (init_stringtab): Add storage parameter.
7955         (free_stringtab, free_stringtab_cleanup): Remove.
7956         (init_lineno): Add storage parameter.
7957         (free_linetab, free_linetab_cleanup): Remove.
7958
7959 2019-03-06  Pedro Alves  <palves@redhat.com>
7960
7961         * linux-fork.c (fork_info::clobber_regs): Delete.
7962         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7963         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7964         comment.  Adjust.
7965         (scoped_switch_fork_info::scoped_switch_fork_info)
7966         (checkpoint_command, linux_fork_context): Adjust
7967         fork_save_infrun_state calls.
7968
7969 2019-03-06  Pedro Alves  <palves@redhat.com>
7970
7971         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7972         (inf_has_multiple_threads): Return 'bool' and rewrite using
7973         inferior_info::threads().
7974
7975 2019-03-06  Pedro Alves  <palves@redhat.com>
7976
7977         * linux-fork.c: Include <list>.
7978         (fork_list): Now a std::list instance.
7979         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7980         (forks_exist_p, find_last_fork): Adjust.
7981         (new_fork): Delete.
7982         (one_fork_p): New.
7983         (add_fork): Adjust.
7984         (free_fork): Delete, folded into fork_info::~fork_info().
7985         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7986         Adjust.
7987         (init_fork_list): Delete.
7988         (linux_fork_killall, linux_fork_mourn_inferior)
7989         (linux_fork_detach, info_checkpoints_command): Adjust.
7990         (_initialize_linux_fork): No longer call init_fork_list.
7991
7992 2019-03-06  Pedro Alves  <palves@redhat.com>
7993
7994         * linux-fork.c (new_fork): New, split out of ...
7995         (add_fork): ... this.  Return void.  Move "first fork" special
7996         case from here, to ...
7997         (checkpoint_command): ... here.
7998         * linux-linux.h (add_fork): Return void.
7999
8000 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8001
8002         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8003
8004 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8005             Chris January  <chris.january@arm.com>
8006             David Lecomber  <david.lecomber@arm.com>
8007
8008         * f-exp.y: New token, UNOP_INTRINSIC.
8009         (exp): New pattern using UNOP_INTRINSIC token.
8010         (f77_keywords): Add 'abs' keyword.
8011         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8012         (value_from_host_double): New function.
8013         (evaluate_subexp_f): Support UNOP_ABS.
8014
8015 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8016
8017         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8018         types.
8019
8020 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8021
8022         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8023         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8024         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8025
8026 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8027
8028         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8029
8030 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8031             Chris January  <chris.january@arm.com>
8032
8033         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8034         * f-exp.y: Define 'KIND' token.
8035         (exp): New pattern for KIND expressions.
8036         (ptype): Handle types with a kind extension.
8037         (direct_abs_decl): Extend to spot kind extensions.
8038         (f77_keywords): Add 'kind' to the list.
8039         (push_kind_type): New function.
8040         (convert_to_kind_type): New function.
8041         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8042         * parse.c (operator_length_standard): Likewise.
8043         * parser-defs.h (enum type_pieces): Add tp_kind.
8044         * std-operator.def: Add UNOP_KIND.
8045
8046 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8047
8048         * f-exp.y (f_parse): Set yydebug.
8049
8050 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8051
8052         * f-lang.c (evaluate_subexp_f): New function.
8053         (exp_descriptor_f): New global.
8054         (f_language_defn): Use exp_descriptor_f instead of
8055         exp_descriptor_standard.
8056
8057 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8058
8059         * f-exp.y (struct token): Add comments.
8060         (dot_ops): Remove uppercase versions and the end marker.
8061         (f77_keywords): Likewise.
8062         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8063         entries in the dot_ops array are case insensitive, and use
8064         strncasecmp to compare strings.  Also some whitespace cleanup in
8065         this area.  Similar for the f77_keywords array, except entries in
8066         this list might be case sensitive.
8067
8068 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8069
8070         * f-exp.y (struct f77_boolean_val): Add comments.
8071         (boolean_values): Remove uppercase versions, and end marker.
8072         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8073         and use strncasecmp to achieve case insensitivity.  Additionally,
8074         perform whitespace cleanup around this code.
8075
8076 2019-03-06  Tom Tromey  <tromey@adacore.com>
8077
8078         * remote-sim.c (gdbsim_target_open): Use result of
8079         gdb_argv::release.
8080
8081 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8082         Dirk Schubert  <dirk.schubert@arm.com>
8083         Chris January  <chris.january@arm.com>
8084
8085         * eval.c (evaluate_subexp_standard): Call Fortran argument
8086         wrapping logic.
8087         * f-lang.c (struct value): A value which can be passed into a
8088         Fortran function call.
8089         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8090         where appropriate.
8091         (struct type): Value ready for a Fortran function call.
8092         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8093         is needed.
8094         * f-lang.h (fortran_argument_convert): Declaration.
8095         (fortran_preserve_arg_pointer): Declaration.
8096         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8097
8098 2019-03-05  Tom Tromey  <tromey@adacore.com>
8099
8100         * python/py-prettyprint.c (print_string_repr): Remove #if.
8101         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8102
8103 2019-03-05  Tom Tromey  <tromey@adacore.com>
8104
8105         * target.c (the_dummy_target): Move later.  Change type to
8106         "dummy_target".
8107         (initialize_targets): Don't initialize the_dummy_target.
8108
8109 2019-03-05  Tom Tromey  <tromey@adacore.com>
8110
8111         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8112         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8113
8114 2019-03-05  Tom Tromey  <tromey@adacore.com>
8115
8116         * windows-nat.c (windows_nat_target::attach)
8117         (windows_nat_target::detach): Don't call gdb_flush.
8118         * valprint.c (generic_val_print, val_print, val_print_string):
8119         Don't call gdb_flush.
8120         * utils.c (defaulted_query): Don't call gdb_flush.
8121         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8122         * target.c (target_announce_detach): Don't call gdb_flush.
8123         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8124         * remote.c (extended_remote_target::attach): Don't call
8125         gdb_flush.
8126         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8127         * printcmd.c (do_examine): Don't call gdb_flush.
8128         (info_display_command): Don't call gdb_flush.
8129         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8130         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8131         * memattr.c (info_mem_command): Don't call gdb_flush.
8132         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8133         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8134         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8135         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8136         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8137         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8138         (gnu_nat_target::detach): Don't call gdb_flush.
8139         * f-valprint.c (f_val_print): Don't call gdb_flush.
8140         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8141         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8142         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8143         gdb_flush.
8144         * c-valprint.c (c_val_print): Don't call gdb_flush.
8145         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8146
8147 2019-03-05  Tom Tromey  <tromey@adacore.com>
8148
8149         * varobj.c (update_dynamic_varobj_children): Update.
8150         (install_default_visualizer): Use reset, not release.
8151         * value.c (set_internalvar): Update.
8152         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8153         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8154         ATTRIBUTE_UNUSED_RESULT.
8155
8156 2019-03-05  Tom Tromey  <tromey@adacore.com>
8157
8158         * remote.c (class scoped_remote_fd) <release>: Add
8159         ATTRIBUTE_UNUSED_RESULT.
8160
8161 2019-03-05  Tom Tromey  <tromey@adacore.com>
8162
8163         * macroexp.c (struct macro_buffer) <release>: Add
8164         ATTRIBUTE_UNUSED_RESULT.
8165
8166 2019-03-05  Tom Tromey  <tromey@adacore.com>
8167
8168         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8169         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8170         ATTRIBUTE_UNUSED_RESULT.
8171
8172 2019-03-05  Tom Tromey  <tromey@adacore.com>
8173
8174         * common/scoped_fd.h (class scoped_fd) <release>: Add
8175         ATTRIBUTE_UNUSED_RESULT.
8176
8177 2019-03-05  Tom Tromey  <tromey@adacore.com>
8178
8179         * parser-defs.h (struct parser_state) <release>: Add
8180         ATTRIBUTE_UNUSED_RESULT.
8181
8182 2019-03-05  Tom Tromey  <tromey@adacore.com>
8183
8184         * utils.h (class gdb_argv) <release>: Add
8185         ATTRIBUTE_UNUSED_RESULT.
8186         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8187
8188 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8189
8190         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8191         for-loop range, to avoid compiler warnings.
8192
8193         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8194         avoid compiler warnings about unused variables.
8195
8196         * NEWS: Mention end of support for native debugging on MS-Windows
8197         before XP.
8198
8199         PR gdb/24292
8200         * common/netstuff.c:
8201         * gdbserver/gdbreplay.c
8202         * gdbserver/remote-utils.c:
8203         * ser-tcp.c:
8204         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8205         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8206         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8207         'getaddrinfo' and 'freeaddrinfo' were not available before
8208         Windows XP, and mingw.org's MinGW headers by default define
8209         _WIN32_WINNT to 0x500.
8210
8211 2019-03-01  Gary Benson <gbenson@redhat.com>
8212
8213         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8214
8215 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8216             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8217
8218         PR gdb/8527
8219         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8220         set_sigint_trap, clear_sigint_trap.
8221
8222 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8223
8224         * target.c (target_detach): Clear the regcache and the
8225         frame cache.
8226
8227 2019-02-27  Pedro Alves  <palves@redhat.com>
8228
8229         * utils.c (set_screen_size): When we cap the height/width sizes,
8230         tweak the corresponding command variable to show "unlimited":
8231
8232 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8233             Pedro Alves  <palves@redhat.com>
8234
8235         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8236         before calling rl_set_screen_size.
8237
8238 2019-02-27  Tom Tromey  <tromey@adacore.com>
8239
8240         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8241         define.
8242         * python/py-value.c: Remove Python 2.4 workaround.
8243         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8244         workaround.
8245         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8246         Python 2.4 workaround.
8247         * python/python-internal.h: Remove Python 2.4 comment.
8248         (Py_ssize_t): Don't define.
8249         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8250         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8251         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8252         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8253         * python/python.c (do_start_initialization): Remove Python 2.4
8254         workaround.
8255         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8256         (print_children): Remove Python 2.4 workaround.
8257         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8258         workaround.
8259         (CHARBUFFERPROC_NAME): Remove.
8260         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8261         Python 2.4 workaround.
8262
8263 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8264
8265         * NEWS: Note minimum Python version.
8266
8267 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8268
8269         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8270         code from these functions.  Remove corresponding ifdefs.  Use
8271         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8272         Remove gotos and target of gotos.
8273         (infpy_search_memory): Likewise.
8274
8275 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8276
8277         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8278         (hppa_gdbarch_init): Don't register deleted functions with
8279         gdbarch.
8280
8281 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8282
8283         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8284         (h8300_unwind_sp): Delete.
8285         (h8300_dummy_id): Delete.
8286         (h8300_gdbarch_init): Don't register deleted functions with
8287         gdbarch.
8288
8289 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8290
8291         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8292         (ft32_unwind_pc): Delete.
8293         (ft32_unwind_sp): Delete.
8294         (ft32_gdbarch_init): Don't register deleted functions with
8295         gdbarch.
8296
8297 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8298
8299         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8300         (frv_unwind_pc): Delete.
8301         (frv_unwind_sp): Delete.
8302         (frv_gdbarch_init): Don't register deleted functions with
8303         gdbarch.
8304
8305 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8306
8307         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8308         (riscv_unwind_pc): Delete.
8309         (riscv_unwind_sp): Delete.
8310         (riscv_gdbarch_init): Don't register deleted functions with
8311         gdbarch.
8312
8313 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8314
8315         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8316         (csky_unwind_pc): Delete.
8317         (csky_unwind_sp): Delete.
8318         (csky_gdbarch_init): Don't register deleted functions with
8319         gdbarch.
8320
8321 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8322
8323         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8324         (cris_unwind_pc): Delete.
8325         (cris_unwind_sp): Delete.
8326         (cris_gdbarch_init): Don't register deleted functions with
8327         gdbarch.
8328
8329 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8330
8331         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8332         (bfin_unwind_pc): Delete.
8333         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8334
8335 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8336
8337         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8338         (arm_unwind_pc): Delete.
8339         (arm_unwind_sp): Delete.
8340         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8341
8342 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8343
8344         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8345         (arc_unwind_pc): Delete.
8346         (arc_unwind_sp): Delete.
8347         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8348
8349 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8350
8351         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8352         (alpha_unwind_pc): Delete.
8353         (alpha_gdbarch_init): Don't register deleted functions with
8354         gdbarch.
8355
8356 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8357
8358         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8359         (aarch64_unwind_pc): Delete.
8360         (aarch64_unwind_sp): Delete.
8361         (aarch64_gdbarch_init): Don't register deleted functions with
8362         gdbarch.
8363
8364 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8365
8366         * gdbtypes.c (type_align): Don't consider static members when
8367         computing structure alignment.
8368
8369 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8370
8371         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8372         return 0 for other types.
8373         * arch-utils.c (default_type_align): Always return 0.
8374         * gdbarch.h: Regenerate.
8375         * gdbarch.sh (type_align): Extend comment.
8376         * gdbtypes.c (type_align): Add additional comments, always call
8377         gdbarch_type_align before applying the default rules.
8378         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8379         generic code will then apply a suitable default.
8380         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8381         types, return 0 for other types.
8382
8383 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8384
8385         * NEWS: Create a new section for the next release branch.
8386         Rename the section of the current branch, now that it has
8387         been cut.
8388
8389 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8390
8391         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8392         * version.in: Bump version to 8.3.50.DATE-git.
8393
8394 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8395
8396         * aix-thread.c (ptid_cmp): Remove unused variable.
8397         (get_signaled_thread): Likewise.
8398         (store_regs_user_thread): Likewise.
8399         (store_regs_kernel_thread): Likewise.
8400         (fetch_regs_kernel_thread): Remove shadowed variable.
8401
8402 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8403
8404         * features/riscv/32bit-cpu.xml: Add register numbers.
8405         * features/riscv/32bit-fpu.c: Regenerate.
8406         * features/riscv/32bit-fpu.xml: Add register numbers.
8407         * features/riscv/64bit-cpu.xml: Add register numbers.
8408         * features/riscv/64bit-fpu.c: Regenerate.
8409         * features/riscv/64bit-fpu.xml: Add register numbers.
8410
8411 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8412
8413         * NEWS: Mention two argument form of gdb.Value constructor.
8414         * python/py-value.c (convert_buffer_and_type_to_value): New
8415         function.
8416         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8417         Add support for handling an optional second argument.  Call
8418         convert_buffer_and_type_to_value as appropriate.
8419         * python/python-internal.h (Py_buffer_deleter): New struct.
8420         (Py_buffer_up): New typedef.
8421
8422 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8423
8424         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8425         instead of releasing ownership.
8426
8427 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8428
8429         * dwarf2read.c (open_and_init_dwp_file): Call
8430         elf_numsections instead of bfd_count_sections to initialize
8431         dwp_file->num_sections.
8432
8433 2019-02-25  Tom Tromey  <tromey@adacore.com>
8434
8435         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8436
8437 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8438
8439         * gcore.in: Add '--readnever' option when invoking GDB.
8440
8441 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8442
8443         * MAINTAINERS: Update my email address.
8444
8445 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8446
8447         * build-id.c (build_id_to_debug_bfd_1): New function.
8448         (build_id_to_debug_bfd): Look for separate debug file in
8449         sysroot.
8450
8451 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8452
8453         * gdbarch.sh: Update the copyright year range that is placed into
8454         generated files.
8455
8456 2019-02-22  Keith Seitz  <keiths@redhat.com>
8457
8458         PR symtab/23853
8459         * linespec.c (create_sals_line_offset): Search for the default
8460         symtab's filename instead of its fullname.
8461
8462 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8463
8464         * NEWS: Update style defaults.
8465
8466 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8467
8468         * main.c (captured_main_1): Disable styling in batch mode.
8469
8470 2019-02-20  Tom Tromey  <tom@tromey.com>
8471
8472         * symtab.c (symtab_symbol_info): Fix typos.
8473
8474 2019-02-20  Tom Tromey  <tromey@adacore.com>
8475
8476         * findcmd.c (_initialize_mem_search): Use upper case for
8477         metasyntactic variables.
8478
8479 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8480
8481         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8482         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8483
8484 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8485
8486         * top.h (source_file_name): Change to std::string.
8487         * top.c (source_file_name): Likewise.
8488         (command_line_input): Adjust.
8489         * cli/cli-script.c (script_from_file): Adjust.
8490
8491 2019-02-19  Tom Tromey  <tromey@adacore.com>
8492
8493         * ravenscar-thread.c
8494         (ravenscar_thread_target::update_thread_list): Don't call
8495         ada_build_task_list.
8496         * ada-lang.h (ada_build_task_list): Don't declare.
8497         * ada-tasks.c (struct ada_tasks_inferior_data)
8498         <task_list_valid_p>: Now bool.
8499         (read_known_tasks, ada_task_list_changed)
8500         (ada_tasks_invalidate_inferior_data): Update.
8501         (read_known_tasks_array): Return bool.
8502         (read_known_tasks_list): Likewise.
8503         (read_known_tasks): Return void.
8504         (ada_build_task_list): Now static.
8505
8506 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8507
8508         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8509         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8510
8511 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8512
8513         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8514         variant for ada_tasks_pspace_data_handle and
8515         ada_tasks_inferior_data_handle.
8516         (ada_tasks_pspace_data_cleanup): New function.
8517         (ada_tasks_inferior_data_cleanup): New function.
8518
8519 2019-02-17  Tom Tromey  <tom@tromey.com>
8520
8521         * macrotab.h (macro_source_fullname): Return a std::string.
8522         * macrotab.c (macro_include, check_for_redefinition)
8523         (macro_undef, macro_lookup_definition, foreach_macro)
8524         (foreach_macro_in_scope): Update.
8525         (macro_source_fullname): Return a std::string.
8526         * macrocmd.c (show_pp_source_pos): Update.
8527
8528 2019-02-17  Tom Tromey  <tom@tromey.com>
8529
8530         * macrocmd.c (show_pp_source_pos): Style the file names.
8531
8532 2019-02-17  Tom Tromey  <tom@tromey.com>
8533
8534         PR tui/24197:
8535         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8536
8537 2019-02-17  Tom Tromey  <tom@tromey.com>
8538
8539         * ada-lang.c (user_select_syms): Use filtered printing.
8540         * utils.c (wrap_style): New global.
8541         (desired_style): Remove.
8542         (emit_style_escape): Add stream parameter.
8543         (set_output_style, reset_terminal_style, prompt_for_continue):
8544         Update.
8545         (flush_wrap_buffer): Only flush gdb_stdout.
8546         (wrap_here): Set wrap_style.
8547         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8548         treat escape sequences as a character.  Change when wrap buffer is
8549         flushed.
8550         (fputs_styled): Do not set the output style when the default is
8551         requested.
8552         * ui-style.h (struct ui_file_style) <is_default>: New method.
8553         * source.c (print_source_lines_base): Emit escape sequences in one
8554         piece.
8555
8556 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8557
8558         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8559         integers and enumeration types.
8560
8561 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8562
8563         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8564         instead of lookup_symbol_in_language
8565         (do_exact_match): New function.
8566         (ada_get_symbol_name_matcher): Return do_exact_match when
8567         doing a verbatim match.
8568
8569 2019-02-15  Tom Tromey  <tromey@adacore.com>
8570
8571         * ravenscar-thread.c (ravenscar_thread_target::resume)
8572         (ravenscar_thread_target::wait): Special case wildcard requests.
8573
8574 2019-02-15  Tom Tromey  <tromey@adacore.com>
8575
8576         * ravenscar-thread.c (base_ptid): Remove.
8577         (struct ravenscar_thread_target) <close>: New method.
8578         <m_base_ptid>: New member.
8579         <update_inferior_ptid, active_task, task_is_currently_active,
8580         runtime_initialized>: Declare methods.
8581         <ravenscar_thread_target>: Add constructor.
8582         (ravenscar_thread_target::task_is_currently_active)
8583         (ravenscar_thread_target::update_inferior_ptid)
8584         (ravenscar_runtime_initialized): Rename.  Now methods.
8585         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8586         (ravenscar_thread_target::update_thread_list): Update.
8587         (ravenscar_thread_target::active_task): Now method.
8588         (ravenscar_thread_target::store_registers)
8589         (ravenscar_thread_target::prepare_to_store)
8590         (ravenscar_thread_target::prepare_to_store)
8591         (ravenscar_thread_target::mourn_inferior): Update.
8592         (ravenscar_inferior_created): Use "new" to create target.
8593         (ravenscar_thread_target::get_ada_task_ptid): Update.
8594         (_initialize_ravenscar): Don't initialize base_ptid.
8595         (ravenscar_ops): Remove global.
8596
8597 2019-02-15  Tom Tromey  <tromey@adacore.com>
8598
8599         * target.h (push_target): Declare new overload.
8600         * target.c (push_target): New overload, taking an rvalue reference.
8601         * remote.c (remote_target::open_1): Use push_target overload.
8602         * corelow.c (core_target_open): Use push_target overload.
8603
8604 2019-02-15  Tom Tromey  <tromey@adacore.com>
8605
8606         * ravenscar-thread.c (is_ravenscar_task)
8607         (ravenscar_task_is_currently_active): Return bool.
8608         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8609         (_initialize_ravenscar): Remove "(void)".
8610         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8611         Return bool.
8612
8613 2019-02-15  Tom Tromey  <tromey@adacore.com>
8614
8615         * ravenscar-thread.c (ravenscar_runtime_initializer)
8616         (has_ravenscar_runtime, get_running_thread_id)
8617         (ravenscar_thread_target::resume): Fix indentation.
8618
8619 2019-02-15  Tom Tromey  <tromey@adacore.com>
8620
8621         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8622         from ravenscar_arch_ops.
8623         (sparc_ravenscar_ops::fetch_registers)
8624         (sparc_ravenscar_ops::store_registers): Now methods.
8625         (sparc_ravenscar_prepare_to_store): Remove.
8626         (sparc_ravenscar_ops): Redefine.
8627         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8628         methods and destructor.  Remove members.
8629         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8630         (ravenscar_thread_target::store_registers)
8631         (ravenscar_thread_target::prepare_to_store): Update.
8632         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8633         Remove.
8634         (struct ppc_ravenscar_powerpc_ops): Derive from
8635         ravenscar_arch_ops.
8636         (ppc_ravenscar_powerpc_ops::fetch_registers)
8637         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8638         (ppc_ravenscar_powerpc_ops): Redefine.
8639         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8640         (ppc_ravenscar_e500_ops::fetch_registers)
8641         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8642         (ppc_ravenscar_e500_ops): Redefine.
8643         * aarch64-ravenscar-thread.c
8644         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8645         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8646         (aarch64_ravenscar_fetch_registers)
8647         (aarch64_ravenscar_store_registers): Now methods.
8648         (aarch64_ravenscar_ops): Redefine.
8649
8650 2019-02-15  Tom Tromey  <tromey@adacore.com>
8651
8652         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8653         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8654         (ravenscar_thread_target::stopped_by_watchpoint)
8655         (ravenscar_thread_target::stopped_data_address)
8656         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8657
8658 2019-02-15  Tom Tromey  <tromey@adacore.com>
8659
8660         * ravenscar-thread.c: Fix some typos.
8661
8662 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8663             Tom Tromey  <tromey@adacore.com>
8664
8665         * ada-lang.c (ada_exception_sal): Change addr_string to a
8666         std::string.
8667         (create_ada_exception_catchpoint): Update.
8668
8669 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8670             Tom Tromey  <tromey@adacore.com>
8671
8672         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8673         (bp_location_ops): Remove.
8674         (base_breakpoint_allocate_location): Update.
8675         (free_bp_location): Update.
8676         * ada-lang.c (class ada_catchpoint_location)
8677         <ada_catchpoint_location>: Remove ops parameter.
8678         (ada_catchpoint_location_dtor): Remove.
8679         (ada_catchpoint_location_ops): Remove.
8680         (allocate_location_exception): Update.
8681         * breakpoint.h (struct bp_location_ops): Remove.
8682         (class bp_location) <bp_location>: Remove bp_location_ops
8683         parameter.
8684         <~bp_location>: Add destructor.
8685         <ops>: Remove.
8686
8687 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8688             Pedro Alves  <palves@redhat.com>
8689
8690         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8691         'PATH_MAX'.
8692
8693 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8694             Samuel Thibault  <samuel.thibault@gnu.org>
8695             Thomas Schwinge  <thomas@codesourcery.com>
8696
8697         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8698         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8699
8700 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8701
8702         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8703         (check_empty): Use "const char *".
8704
8705         * gnu-nat.c (gnu_nat_target::detach): Instead of
8706         'detach_inferior (pid)' call
8707         'detach_inferior (find_inferior_pid (pid))'.
8708
8709         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8710         'nat/fork-inferior.o'.
8711         * gnu-nat.c: #include "nat/fork-inferior.h".
8712
8713         * gnu-nat.c (gnu_nat_target::detach): Instead of
8714         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8715         * gnu-nat.h: #include "inf-child.h".
8716         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8717         'i386_gnu_nat_target::fetch_registers'.
8718         (gnu_store_registers): Rename/move to
8719         'i386_gnu_nat_target::store_registers'.
8720
8721         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8722         * gnu-nat.h (mach_thread_info): New function.
8723         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8724
8725         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8726
8727 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8728
8729         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8730
8731 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8732
8733         * windows-nat.c (windows_add_thread): Add new parameter
8734         "main_thread_p" with default value set to false.  Update
8735         function documentation as well as all callers.
8736         (windows_delete_thread): Likewise.
8737         (fake_create_process): Update call to windows_add_thread.
8738         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8739         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8740         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8741         call to windows_delete_thread.
8742
8743 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8744
8745         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8746
8747 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8748
8749         * symfile.c (find_separate_debug_file): Use canonical path of
8750         sysroot with child_path instead of gdb_sysroot if it is valid.
8751
8752 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8753
8754         * symfile.c (find_separate_debug_file): Use child_path to
8755         determine if an object file is under a sysroot.
8756
8757 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8758
8759         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8760         unittests/child-path-selftests.c.
8761         * common/pathstuff.c (child_path): New function.
8762         * common/pathstuff.h (child_path): New prototype.
8763         * unittests/child-path-selftests.c: New file.
8764
8765 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8766
8767         * symfile.c (find_separate_debug_file): Look for separate debug
8768         files in debug directories under the sysroot.
8769
8770 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8771
8772         * symtab.h (struct minimal_symbol data_p): New const method.
8773         (struct minimal_symbol text_p): Likewise.
8774         * symtab.c (output_source_filename): Use file name style
8775         to print file name.
8776         (print_symbol_info): Likewise.
8777         (print_msymbol_info): Use address style to print addresses.
8778         Use function name style to print executable text symbols.
8779         (expand_symtab_containing_pc): Use data_p.
8780         (find_pc_sect_compunit_symtab): Likewise.
8781
8782 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8783
8784         * breakpoint.c (describe_other_breakpoints): Use address style
8785         to print addresses.
8786         (say_where): Likewise.
8787
8788 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8789
8790         * ada-typeprint.c (print_func_type): Print function name
8791         style to print function name.
8792         * c-typeprint.c (c_print_type_1): Likewise.
8793
8794 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8795
8796         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8797         for execve.
8798
8799 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8800
8801         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8802         type_stack.
8803
8804 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8805
8806         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8807         TYPE_CODE_REF types.
8808
8809 2019-02-08  Jim Wilson  <jimw@sifive.com>
8810
8811         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8812         (riscv_linux_fregset): New.
8813         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8814
8815 2019-02-07  Tom Tromey  <tom@tromey.com>
8816
8817         * thread.c (thread_cancel_execution_command): Update.
8818         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8819         methods.
8820         (struct thread_fsm_ops): Remove.
8821         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8822         (thread_fsm_should_stop, thread_fsm_return_value)
8823         (thread_fsm_set_finished, thread_fsm_finished_p)
8824         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8825         Don't declare.
8826         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8827         * infrun.c (clear_proceed_status_thread)
8828         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8829         (print_stop_event): Update.
8830         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8831         Add constructor.
8832         (step_command_fsm_ops): Remove.
8833         (new_step_command_fsm): Remove.
8834         (step_1): Update.
8835         (step_command_fsm::should_stop): Rename from
8836         step_command_fsm_should_stop.
8837         (step_command_fsm::clean_up): Rename from
8838         step_command_fsm_clean_up.
8839         (step_command_fsm::do_async_reply_reason): Rename from
8840         step_command_fsm_async_reply_reason.
8841         (struct until_next_fsm): Inherit from thread_fsm.  Add
8842         constructor.
8843         (until_next_fsm_ops): Remove.
8844         (new_until_next_fsm): Remove.
8845         (until_next_fsm::should_stop): Rename from
8846         until_next_fsm_should_stop.
8847         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8848         (until_next_fsm::do_async_reply_reason): Rename from
8849         until_next_fsm_async_reply_reason.
8850         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8851         constructor.  Change type of breakpoint.
8852         (finish_command_fsm_ops): Remove.
8853         (new_finish_command_fsm): Remove.
8854         (finish_command_fsm::should_stop): Rename from
8855         finish_command_fsm_should_stop.
8856         (finish_command_fsm::clean_up): Rename from
8857         finish_command_fsm_clean_up.
8858         (finish_command_fsm::return_value): Rename from
8859         finish_command_fsm_return_value.
8860         (finish_command_fsm::do_async_reply_reason): Rename from
8861         finish_command_fsm_async_reply_reason.
8862         (finish_command): Update.
8863         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8864         Add constructor.
8865         (call_thread_fsm_ops): Remove.
8866         (call_thread_fsm::call_thread_fsm): Rename from
8867         new_call_thread_fsm.
8868         (call_thread_fsm::should_stop): Rename from
8869         call_thread_fsm_should_stop.
8870         (call_thread_fsm::should_notify_stop): Rename from
8871         call_thread_fsm_should_notify_stop.
8872         (run_inferior_call, call_function_by_hand_dummy): Update.
8873         * cli/cli-interp.c (should_print_stop_to_console): Update.
8874         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8875         Add constructor.  Change type of location_breakpoint,
8876         caller_breakpoint.
8877         (until_break_fsm_ops): Remove.
8878         (new_until_break_fsm): Remove.
8879         (until_break_fsm::should_stop): Rename from
8880         until_break_fsm_should_stop.
8881         (until_break_fsm::clean_up): Rename from
8882         until_break_fsm_clean_up.
8883         (until_break_fsm::do_async_reply_reason): Rename from
8884         until_break_fsm_async_reply_reason.
8885         (until_break_command): Update.
8886         * thread-fsm.c: Remove.
8887         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8888
8889 2019-02-07  Tom Tromey  <tom@tromey.com>
8890
8891         * yy-remap.h: Add include guard.
8892         * xtensa-tdep.h: Add include guard.
8893         * xcoffread.h: Rename include guard.
8894         * varobj-iter.h: Add include guard.
8895         * tui/tui.h: Rename include guard.
8896         * tui/tui-winsource.h: Rename include guard.
8897         * tui/tui-wingeneral.h: Rename include guard.
8898         * tui/tui-windata.h: Rename include guard.
8899         * tui/tui-win.h: Rename include guard.
8900         * tui/tui-stack.h: Rename include guard.
8901         * tui/tui-source.h: Rename include guard.
8902         * tui/tui-regs.h: Rename include guard.
8903         * tui/tui-out.h: Rename include guard.
8904         * tui/tui-layout.h: Rename include guard.
8905         * tui/tui-io.h: Rename include guard.
8906         * tui/tui-hooks.h: Rename include guard.
8907         * tui/tui-file.h: Rename include guard.
8908         * tui/tui-disasm.h: Rename include guard.
8909         * tui/tui-data.h: Rename include guard.
8910         * tui/tui-command.h: Rename include guard.
8911         * tic6x-tdep.h: Add include guard.
8912         * target/waitstatus.h: Rename include guard.
8913         * target/wait.h: Rename include guard.
8914         * target/target.h: Rename include guard.
8915         * target/resume.h: Rename include guard.
8916         * target-float.h: Rename include guard.
8917         * stabsread.h: Add include guard.
8918         * rs6000-tdep.h: Add include guard.
8919         * riscv-fbsd-tdep.h: Add include guard.
8920         * regformats/regdef.h: Rename include guard.
8921         * record.h: Rename include guard.
8922         * python/python.h: Rename include guard.
8923         * python/python-internal.h: Rename include guard.
8924         * python/py-stopevent.h: Rename include guard.
8925         * python/py-ref.h: Rename include guard.
8926         * python/py-record.h: Rename include guard.
8927         * python/py-record-full.h: Rename include guard.
8928         * python/py-record-btrace.h: Rename include guard.
8929         * python/py-instruction.h: Rename include guard.
8930         * python/py-events.h: Rename include guard.
8931         * python/py-event.h: Rename include guard.
8932         * procfs.h: Add include guard.
8933         * proc-utils.h: Add include guard.
8934         * p-lang.h: Add include guard.
8935         * or1k-tdep.h: Rename include guard.
8936         * observable.h: Rename include guard.
8937         * nto-tdep.h: Rename include guard.
8938         * nat/x86-linux.h: Rename include guard.
8939         * nat/x86-linux-dregs.h: Rename include guard.
8940         * nat/x86-gcc-cpuid.h: Add include guard.
8941         * nat/x86-dregs.h: Rename include guard.
8942         * nat/x86-cpuid.h: Rename include guard.
8943         * nat/ppc-linux.h: Rename include guard.
8944         * nat/mips-linux-watch.h: Rename include guard.
8945         * nat/linux-waitpid.h: Rename include guard.
8946         * nat/linux-ptrace.h: Rename include guard.
8947         * nat/linux-procfs.h: Rename include guard.
8948         * nat/linux-osdata.h: Rename include guard.
8949         * nat/linux-nat.h: Rename include guard.
8950         * nat/linux-namespaces.h: Rename include guard.
8951         * nat/linux-btrace.h: Rename include guard.
8952         * nat/glibc_thread_db.h: Rename include guard.
8953         * nat/gdb_thread_db.h: Rename include guard.
8954         * nat/gdb_ptrace.h: Rename include guard.
8955         * nat/fork-inferior.h: Rename include guard.
8956         * nat/amd64-linux-siginfo.h: Rename include guard.
8957         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8958         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8959         * nat/aarch64-linux.h: Rename include guard.
8960         * nat/aarch64-linux-hw-point.h: Rename include guard.
8961         * mn10300-tdep.h: Add include guard.
8962         * mips-linux-tdep.h: Add include guard.
8963         * mi/mi-parse.h: Rename include guard.
8964         * mi/mi-out.h: Rename include guard.
8965         * mi/mi-main.h: Rename include guard.
8966         * mi/mi-interp.h: Rename include guard.
8967         * mi/mi-getopt.h: Rename include guard.
8968         * mi/mi-console.h: Rename include guard.
8969         * mi/mi-common.h: Rename include guard.
8970         * mi/mi-cmds.h: Rename include guard.
8971         * mi/mi-cmd-break.h: Rename include guard.
8972         * m2-lang.h: Add include guard.
8973         * location.h: Rename include guard.
8974         * linux-record.h: Rename include guard.
8975         * linux-nat.h: Add include guard.
8976         * linux-fork.h: Add include guard.
8977         * i386-darwin-tdep.h: Rename include guard.
8978         * hppa-linux-offsets.h: Add include guard.
8979         * guile/guile.h: Rename include guard.
8980         * guile/guile-internal.h: Rename include guard.
8981         * gnu-nat.h: Rename include guard.
8982         * gdb-stabs.h: Rename include guard.
8983         * frv-tdep.h: Add include guard.
8984         * f-lang.h: Add include guard.
8985         * event-loop.h: Add include guard.
8986         * darwin-nat.h: Rename include guard.
8987         * cp-abi.h: Rename include guard.
8988         * config/sparc/nm-sol2.h: Rename include guard.
8989         * config/nm-nto.h: Rename include guard.
8990         * config/nm-linux.h: Add include guard.
8991         * config/i386/nm-i386gnu.h: Rename include guard.
8992         * config/djgpp/nl_types.h: Rename include guard.
8993         * config/djgpp/langinfo.h: Rename include guard.
8994         * compile/gcc-cp-plugin.h: Add include guard.
8995         * compile/gcc-c-plugin.h: Add include guard.
8996         * compile/compile.h: Rename include guard.
8997         * compile/compile-object-run.h: Rename include guard.
8998         * compile/compile-object-load.h: Rename include guard.
8999         * compile/compile-internal.h: Rename include guard.
9000         * compile/compile-cplus.h: Rename include guard.
9001         * compile/compile-c.h: Rename include guard.
9002         * common/xml-utils.h: Rename include guard.
9003         * common/x86-xstate.h: Rename include guard.
9004         * common/version.h: Rename include guard.
9005         * common/vec.h: Rename include guard.
9006         * common/tdesc.h: Rename include guard.
9007         * common/selftest.h: Rename include guard.
9008         * common/scoped_restore.h: Rename include guard.
9009         * common/scoped_mmap.h: Rename include guard.
9010         * common/scoped_fd.h: Rename include guard.
9011         * common/safe-iterator.h: Rename include guard.
9012         * common/run-time-clock.h: Rename include guard.
9013         * common/refcounted-object.h: Rename include guard.
9014         * common/queue.h: Rename include guard.
9015         * common/ptid.h: Rename include guard.
9016         * common/print-utils.h: Rename include guard.
9017         * common/preprocessor.h: Rename include guard.
9018         * common/pathstuff.h: Rename include guard.
9019         * common/observable.h: Rename include guard.
9020         * common/netstuff.h: Rename include guard.
9021         * common/job-control.h: Rename include guard.
9022         * common/host-defs.h: Rename include guard.
9023         * common/gdb_wait.h: Rename include guard.
9024         * common/gdb_vecs.h: Rename include guard.
9025         * common/gdb_unlinker.h: Rename include guard.
9026         * common/gdb_unique_ptr.h: Rename include guard.
9027         * common/gdb_tilde_expand.h: Rename include guard.
9028         * common/gdb_sys_time.h: Rename include guard.
9029         * common/gdb_string_view.h: Rename include guard.
9030         * common/gdb_splay_tree.h: Rename include guard.
9031         * common/gdb_setjmp.h: Rename include guard.
9032         * common/gdb_ref_ptr.h: Rename include guard.
9033         * common/gdb_optional.h: Rename include guard.
9034         * common/gdb_locale.h: Rename include guard.
9035         * common/gdb_assert.h: Rename include guard.
9036         * common/filtered-iterator.h: Rename include guard.
9037         * common/filestuff.h: Rename include guard.
9038         * common/fileio.h: Rename include guard.
9039         * common/environ.h: Rename include guard.
9040         * common/common-utils.h: Rename include guard.
9041         * common/common-types.h: Rename include guard.
9042         * common/common-regcache.h: Rename include guard.
9043         * common/common-inferior.h: Rename include guard.
9044         * common/common-gdbthread.h: Rename include guard.
9045         * common/common-exceptions.h: Rename include guard.
9046         * common/common-defs.h: Rename include guard.
9047         * common/common-debug.h: Rename include guard.
9048         * common/cleanups.h: Rename include guard.
9049         * common/buffer.h: Rename include guard.
9050         * common/btrace-common.h: Rename include guard.
9051         * common/break-common.h: Rename include guard.
9052         * cli/cli-utils.h: Rename include guard.
9053         * cli/cli-style.h: Rename include guard.
9054         * cli/cli-setshow.h: Rename include guard.
9055         * cli/cli-script.h: Rename include guard.
9056         * cli/cli-interp.h: Rename include guard.
9057         * cli/cli-decode.h: Rename include guard.
9058         * cli/cli-cmds.h: Rename include guard.
9059         * charset-list.h: Add include guard.
9060         * buildsym-legacy.h: Rename include guard.
9061         * bfin-tdep.h: Add include guard.
9062         * ax.h: Rename include guard.
9063         * arm-linux-tdep.h: Add include guard.
9064         * arm-fbsd-tdep.h: Add include guard.
9065         * arch/xtensa.h: Rename include guard.
9066         * arch/tic6x.h: Add include guard.
9067         * arch/i386.h: Add include guard.
9068         * arch/arm.h: Rename include guard.
9069         * arch/arm-linux.h: Rename include guard.
9070         * arch/arm-get-next-pcs.h: Rename include guard.
9071         * arch/amd64.h: Add include guard.
9072         * arch/aarch64-insn.h: Rename include guard.
9073         * arch-utils.h: Rename include guard.
9074         * annotate.h: Add include guard.
9075         * amd64-darwin-tdep.h: Rename include guard.
9076         * aarch64-linux-tdep.h: Add include guard.
9077         * aarch64-fbsd-tdep.h: Add include guard.
9078         * aarch32-linux-nat.h: Add include guard.
9079
9080 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9081
9082         * macrotab.c (macro_define_internal): New function that
9083         factorizes macro_define_object_internal and macro_define_function
9084         code.
9085         (macro_define_object_internal): Use macro_define_internal.
9086         (macro_define_function): Likewise.
9087
9088 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9089
9090         * macrocmd.c (extract_identifier): Return
9091         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9092         callers.
9093
9094 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9095
9096         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9097
9098 2019-02-05  Tom Tromey  <tom@tromey.com>
9099
9100         * target.c (target_stack::unpush): Move assertion earlier.
9101
9102 2019-01-30  Tom Tromey  <tom@tromey.com>
9103
9104         PR python/23615:
9105         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9106         (gdbpy_parse_and_eval): Likewise.
9107         * python/python-internal.h (gdbpy_allow_threads): New class.
9108
9109 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9110
9111         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9112         (aarch64_fbsd_fpregmap): Move earlier.
9113         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9114         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9115         instead of individual calls to trad_frame_set_reg_addr.
9116         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9117         earlier.
9118         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9119         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9120         instead of individual calls to trad_frame_set_reg_addr.
9121
9122 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9123
9124         * CONTRIBUTE: Replace contribution list with wiki link.
9125
9126 2019-01-25  Tom Tromey  <tom@tromey.com>
9127
9128         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9129
9130 2019-01-25  Tom Tromey  <tom@tromey.com>
9131
9132         * xtensa-linux-nat.c: Fix common/ includes.
9133         * xml-support.h: Fix common/ includes.
9134         * xml-support.c: Fix common/ includes.
9135         * x86-linux-nat.c: Fix common/ includes.
9136         * windows-nat.c: Fix common/ includes.
9137         * varobj.h: Fix common/ includes.
9138         * varobj.c: Fix common/ includes.
9139         * value.c: Fix common/ includes.
9140         * valops.c: Fix common/ includes.
9141         * utils.c: Fix common/ includes.
9142         * unittests/xml-utils-selftests.c: Fix common/ includes.
9143         * unittests/utils-selftests.c: Fix common/ includes.
9144         * unittests/unpack-selftests.c: Fix common/ includes.
9145         * unittests/tracepoint-selftests.c: Fix common/ includes.
9146         * unittests/style-selftests.c: Fix common/ includes.
9147         * unittests/string_view-selftests.c: Fix common/ includes.
9148         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9149         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9150         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9151         * unittests/rsp-low-selftests.c: Fix common/ includes.
9152         * unittests/parse-connection-spec-selftests.c: Fix common/
9153         includes.
9154         * unittests/optional-selftests.c: Fix common/ includes.
9155         * unittests/offset-type-selftests.c: Fix common/ includes.
9156         * unittests/observable-selftests.c: Fix common/ includes.
9157         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9158         * unittests/memrange-selftests.c: Fix common/ includes.
9159         * unittests/memory-map-selftests.c: Fix common/ includes.
9160         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9161         * unittests/function-view-selftests.c: Fix common/ includes.
9162         * unittests/environ-selftests.c: Fix common/ includes.
9163         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9164         * unittests/common-utils-selftests.c: Fix common/ includes.
9165         * unittests/cli-utils-selftests.c: Fix common/ includes.
9166         * unittests/array-view-selftests.c: Fix common/ includes.
9167         * ui-file.c: Fix common/ includes.
9168         * tui/tui-io.c: Fix common/ includes.
9169         * tracepoint.h: Fix common/ includes.
9170         * tracepoint.c: Fix common/ includes.
9171         * tracefile-tfile.c: Fix common/ includes.
9172         * top.h: Fix common/ includes.
9173         * top.c: Fix common/ includes.
9174         * thread.c: Fix common/ includes.
9175         * target/waitstatus.h: Fix common/ includes.
9176         * target/waitstatus.c: Fix common/ includes.
9177         * target.h: Fix common/ includes.
9178         * target.c: Fix common/ includes.
9179         * target-memory.c: Fix common/ includes.
9180         * target-descriptions.c: Fix common/ includes.
9181         * symtab.h: Fix common/ includes.
9182         * symfile.c: Fix common/ includes.
9183         * stap-probe.c: Fix common/ includes.
9184         * spu-linux-nat.c: Fix common/ includes.
9185         * sparc-nat.c: Fix common/ includes.
9186         * source.c: Fix common/ includes.
9187         * solib.c: Fix common/ includes.
9188         * solib-target.c: Fix common/ includes.
9189         * ser-unix.c: Fix common/ includes.
9190         * ser-tcp.c: Fix common/ includes.
9191         * ser-pipe.c: Fix common/ includes.
9192         * ser-base.c: Fix common/ includes.
9193         * selftest-arch.c: Fix common/ includes.
9194         * s12z-tdep.c: Fix common/ includes.
9195         * rust-exp.y: Fix common/ includes.
9196         * rs6000-aix-tdep.c: Fix common/ includes.
9197         * riscv-tdep.c: Fix common/ includes.
9198         * remote.c: Fix common/ includes.
9199         * remote-notif.h: Fix common/ includes.
9200         * remote-fileio.h: Fix common/ includes.
9201         * remote-fileio.c: Fix common/ includes.
9202         * regcache.h: Fix common/ includes.
9203         * regcache.c: Fix common/ includes.
9204         * record-btrace.c: Fix common/ includes.
9205         * python/python.c: Fix common/ includes.
9206         * python/py-type.c: Fix common/ includes.
9207         * python/py-inferior.c: Fix common/ includes.
9208         * progspace.h: Fix common/ includes.
9209         * producer.c: Fix common/ includes.
9210         * procfs.c: Fix common/ includes.
9211         * proc-api.c: Fix common/ includes.
9212         * printcmd.c: Fix common/ includes.
9213         * ppc-linux-nat.c: Fix common/ includes.
9214         * parser-defs.h: Fix common/ includes.
9215         * osdata.c: Fix common/ includes.
9216         * obsd-nat.c: Fix common/ includes.
9217         * nat/x86-linux.c: Fix common/ includes.
9218         * nat/x86-linux-dregs.c: Fix common/ includes.
9219         * nat/x86-dregs.h: Fix common/ includes.
9220         * nat/x86-dregs.c: Fix common/ includes.
9221         * nat/ppc-linux.c: Fix common/ includes.
9222         * nat/mips-linux-watch.h: Fix common/ includes.
9223         * nat/mips-linux-watch.c: Fix common/ includes.
9224         * nat/linux-waitpid.c: Fix common/ includes.
9225         * nat/linux-ptrace.h: Fix common/ includes.
9226         * nat/linux-ptrace.c: Fix common/ includes.
9227         * nat/linux-procfs.c: Fix common/ includes.
9228         * nat/linux-personality.c: Fix common/ includes.
9229         * nat/linux-osdata.c: Fix common/ includes.
9230         * nat/linux-namespaces.c: Fix common/ includes.
9231         * nat/linux-btrace.h: Fix common/ includes.
9232         * nat/linux-btrace.c: Fix common/ includes.
9233         * nat/fork-inferior.c: Fix common/ includes.
9234         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9235         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9236         * nat/aarch64-linux.c: Fix common/ includes.
9237         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9238         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9239         * namespace.h: Fix common/ includes.
9240         * mips-linux-tdep.c: Fix common/ includes.
9241         * minsyms.c: Fix common/ includes.
9242         * mi/mi-parse.h: Fix common/ includes.
9243         * mi/mi-main.c: Fix common/ includes.
9244         * mi/mi-cmd-env.c: Fix common/ includes.
9245         * memrange.h: Fix common/ includes.
9246         * memattr.c: Fix common/ includes.
9247         * maint.h: Fix common/ includes.
9248         * maint.c: Fix common/ includes.
9249         * main.c: Fix common/ includes.
9250         * machoread.c: Fix common/ includes.
9251         * location.c: Fix common/ includes.
9252         * linux-thread-db.c: Fix common/ includes.
9253         * linux-nat.c: Fix common/ includes.
9254         * linux-fork.c: Fix common/ includes.
9255         * inline-frame.c: Fix common/ includes.
9256         * infrun.c: Fix common/ includes.
9257         * inflow.c: Fix common/ includes.
9258         * inferior.h: Fix common/ includes.
9259         * inferior.c: Fix common/ includes.
9260         * infcmd.c: Fix common/ includes.
9261         * inf-ptrace.c: Fix common/ includes.
9262         * inf-child.c: Fix common/ includes.
9263         * ia64-linux-nat.c: Fix common/ includes.
9264         * i387-tdep.c: Fix common/ includes.
9265         * i386-tdep.c: Fix common/ includes.
9266         * i386-linux-tdep.c: Fix common/ includes.
9267         * i386-linux-nat.c: Fix common/ includes.
9268         * i386-go32-tdep.c: Fix common/ includes.
9269         * i386-fbsd-tdep.c: Fix common/ includes.
9270         * i386-fbsd-nat.c: Fix common/ includes.
9271         * guile/scm-type.c: Fix common/ includes.
9272         * guile/guile.c: Fix common/ includes.
9273         * go32-nat.c: Fix common/ includes.
9274         * gnu-nat.c: Fix common/ includes.
9275         * gdbthread.h: Fix common/ includes.
9276         * gdbarch-selftests.c: Fix common/ includes.
9277         * gdb_usleep.c: Fix common/ includes.
9278         * gdb_select.h: Fix common/ includes.
9279         * gdb_bfd.c: Fix common/ includes.
9280         * gcore.c: Fix common/ includes.
9281         * fork-child.c: Fix common/ includes.
9282         * findvar.c: Fix common/ includes.
9283         * fbsd-nat.c: Fix common/ includes.
9284         * event-top.c: Fix common/ includes.
9285         * event-loop.c: Fix common/ includes.
9286         * dwarf2read.c: Fix common/ includes.
9287         * dwarf2loc.c: Fix common/ includes.
9288         * dwarf2-frame.c: Fix common/ includes.
9289         * dwarf-index-cache.c: Fix common/ includes.
9290         * dtrace-probe.c: Fix common/ includes.
9291         * disasm-selftests.c: Fix common/ includes.
9292         * defs.h: Fix common/ includes.
9293         * csky-tdep.c: Fix common/ includes.
9294         * cp-valprint.c: Fix common/ includes.
9295         * cp-support.h: Fix common/ includes.
9296         * cp-support.c: Fix common/ includes.
9297         * corelow.c: Fix common/ includes.
9298         * completer.h: Fix common/ includes.
9299         * completer.c: Fix common/ includes.
9300         * compile/compile.c: Fix common/ includes.
9301         * compile/compile-loc2c.c: Fix common/ includes.
9302         * compile/compile-cplus-types.c: Fix common/ includes.
9303         * compile/compile-cplus-symbols.c: Fix common/ includes.
9304         * command.h: Fix common/ includes.
9305         * cli/cli-dump.c: Fix common/ includes.
9306         * cli/cli-cmds.c: Fix common/ includes.
9307         * charset.c: Fix common/ includes.
9308         * build-id.c: Fix common/ includes.
9309         * btrace.h: Fix common/ includes.
9310         * btrace.c: Fix common/ includes.
9311         * breakpoint.h: Fix common/ includes.
9312         * breakpoint.c: Fix common/ includes.
9313         * ax.h:
9314         (enum agent_op): Fix common/ includes.
9315         * ax-general.c (struct aop_map): Fix common/ includes.
9316         * ax-gdb.c: Fix common/ includes.
9317         * auxv.c: Fix common/ includes.
9318         * auto-load.c: Fix common/ includes.
9319         * arm-tdep.c: Fix common/ includes.
9320         * arch/riscv.c: Fix common/ includes.
9321         * arch/ppc-linux-common.c: Fix common/ includes.
9322         * arch/i386.c: Fix common/ includes.
9323         * arch/arm.c: Fix common/ includes.
9324         * arch/arm-linux.c: Fix common/ includes.
9325         * arch/arm-get-next-pcs.c: Fix common/ includes.
9326         * arch/amd64.c: Fix common/ includes.
9327         * arch/aarch64.c: Fix common/ includes.
9328         * arch/aarch64-insn.c: Fix common/ includes.
9329         * arch-utils.c: Fix common/ includes.
9330         * amd64-windows-tdep.c: Fix common/ includes.
9331         * amd64-tdep.c: Fix common/ includes.
9332         * amd64-sol2-tdep.c: Fix common/ includes.
9333         * amd64-obsd-tdep.c: Fix common/ includes.
9334         * amd64-nbsd-tdep.c: Fix common/ includes.
9335         * amd64-linux-tdep.c: Fix common/ includes.
9336         * amd64-linux-nat.c: Fix common/ includes.
9337         * amd64-fbsd-tdep.c: Fix common/ includes.
9338         * amd64-fbsd-nat.c: Fix common/ includes.
9339         * amd64-dicos-tdep.c: Fix common/ includes.
9340         * amd64-darwin-tdep.c: Fix common/ includes.
9341         * agent.c: Fix common/ includes.
9342         * ada-lang.h: Fix common/ includes.
9343         * ada-lang.c: Fix common/ includes.
9344         * aarch64-tdep.c: Fix common/ includes.
9345
9346 2019-01-25  Tom Tromey  <tom@tromey.com>
9347
9348         * common/create-version.sh: Use common/version.h.
9349
9350 2019-01-24  Pedro Alves  <palves@redhat.com>
9351
9352         * infrun.c (signal_stop, signal_print, signal_program)
9353         (signal_catch, signal_pass): Now arrays instead of pointers.
9354         (update_signals_program_target, do_target_resume)
9355         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9356         * linux-nat.c (linux_nat_target::pass_signals)
9357         (linux_nat_target::create_inferior, linux_nat_target::attach):
9358         Adjust.
9359         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9360         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9361         * procfs.c (procfs_target::pass_signals): Adjust.
9362         * record-full.c (record_full_target::resume): Adjust.
9363         * remote.c (remote_target::pass_signals)
9364         (remote_target::program_signals): Adjust.
9365         * target-debug.h (target_debug_print_signals): Now takes a
9366         gdb::array_view as parameter.  Adjust.
9367         * target.h (target_ops) <pass_signals, program_signals>: Replace
9368         pointer and length parameters with gdb::array_view.
9369         (target_pass_signals, target_program_signals): Likewise.
9370         * target-delegates.c: Regenerate.
9371
9372 2019-01-24  Pedro Alves  <palves@redhat.com>
9373
9374         * common/forward-scope-exit.h
9375         (forward_scope_exit::forward_scope_exit): Pass arguments to
9376         m_bind_function directly, instead of creating a std::bind and
9377         copying that.
9378
9379 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9380
9381         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9382         for static members.
9383         (pass_in_v_vfp_candidate): Likewise.
9384
9385 2019-01-23  Tom Tromey  <tom@tromey.com>
9386             Pedro Alves  <palves@redhat.com>
9387
9388         * regcache.c (class regcache_invalidator): Remove.
9389         (regcache::raw_write): Use make_scope_exit.
9390
9391 2019-01-23  Tom Tromey  <tom@tromey.com>
9392
9393         * ui-out.h (class ui_out_emit_type): Update comment.
9394
9395 2019-01-23  Tom Tromey  <tom@tromey.com>
9396
9397         * infrun.c (fetch_inferior_event): Update comment.
9398
9399 2019-01-23  Tom Tromey  <tom@tromey.com>
9400             Pedro Alves  <palves@redhat.com>
9401
9402         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9403         parameter.
9404         (fetch_inferior_event): Use SCOPE_EXIT.
9405
9406
9407 2019-01-23  Tom Tromey  <tom@tromey.com>
9408             Pedro Alves  <palves@redhat.com>
9409
9410         * infrun.c (disable_thread_events): Delete.
9411         (stop_all_threads): Use SCOPE_EXIT.
9412
9413 2019-01-23  Tom Tromey  <tom@tromey.com>
9414             Pedro Alves  <palves@redhat.com>
9415
9416         * symfile.c: Include forward-scope-exit.h.
9417         (clear_symtab_users_cleanup): Replace forward declaration with
9418         a FORWARD_SCOPE_EXIT.
9419         (syms_from_objfile_1): Use the forward_scope_exit and
9420         gdb::optional instead of cleanup_function.
9421         (reread_symbols): Use the forward_scope_exit instead of
9422         cleanup_function.
9423         (clear_symtab_users_cleanup): Remove function.
9424
9425 2019-01-23  Tom Tromey  <tom@tromey.com>
9426             Pedro Alves  <palves@redhat.com>
9427
9428         * linux-nat.c: Include scope-exit.h.
9429         (cleanup_target_stop): Remove.
9430         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9431         SCOPE_EXIT.
9432
9433 2019-01-23  Tom Tromey  <tom@tromey.com>
9434             Pedro Alves  <palves@redhat.com>
9435
9436         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9437         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9438
9439 2019-01-23  Tom Tromey  <tom@tromey.com>
9440             Andrew Burgess  <andrew.burgess@embecosm.com>
9441             Pedro Alves  <palves@redhat.com>
9442
9443         * infrun.c (fetch_inferior_event): Use scope_exit.
9444         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9445         * top.c (execute_command): Use scope_exit.
9446         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9447         * utils.c (do_bpstat_clear_actions_cleanup)
9448         (make_bpstat_clear_actions_cleanup): Remove.
9449
9450 2019-01-23  Tom Tromey  <tom@tromey.com>
9451             Pedro Alves  <palves@redhat.com>
9452
9453         * infrun.c: Include "common/scope-exit.h"
9454         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9455         (wait_for_inferior): Use SCOPE_EXIT.
9456         (fetch_inferior_event): Use scope_exit.
9457
9458 2019-01-23  Tom Tromey  <tom@tromey.com>
9459             Pedro Alves  <palves@redhat.com>
9460
9461         * breakpoint.c (create_breakpoint): Remove cleanup.
9462
9463 2019-01-23  Tom Tromey  <tom@tromey.com>
9464             Andrew Burgess  <andrew.burgess@embecosm.com>
9465             Pedro Alves  <palves@redhat.com>
9466
9467 2019-01-23  Pedro Alves  <palves@redhat.com>
9468
9469         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9470
9471 2019-01-23  Pedro Alves  <palves@redhat.com>
9472             Andrew Burgess  <andrew.burgess@embecosm.com>
9473
9474         * gdbthread.h: Include "common/forward-scope-exit.h".
9475         (scoped_finish_thread_state): Redefine custom class in terms of
9476         forward_scope_exit.
9477
9478 2019-01-23  Pedro Alves  <palves@redhat.com>
9479             Andrew Burgess  <andrew.burgess@embecosm.com>
9480
9481         * common/forward-scope-exit.h: New file.
9482
9483 2019-01-23  Pedro Alves  <palves@redhat.com>
9484             Andrew Burgess  <andrew.burgess@embecosm.com>
9485             Tom Tromey  <tom@tromey.com>
9486
9487         * common/scope-exit.h: New file.
9488
9489 2019-01-23  Pedro Alves  <palves@redhat.com>
9490
9491         * common/preprocessor.h (ESC): Rename to ...
9492         (ESC_PARENS): ... this.
9493         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9494         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9495
9496 2019-01-23  Tom Tromey  <tom@tromey.com>
9497
9498         * language.h (class scoped_switch_to_sym_language_if_auto):
9499         Initialize m_lang in both cases.
9500
9501 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9502
9503         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9504         with XCNEW.
9505
9506 2019-01-22  Tom Tromey  <tom@tromey.com>
9507
9508         * corelow.c: Do not include sys/file.h.
9509
9510 2019-01-22  Tom Tromey  <tom@tromey.com>
9511
9512         * tui/tui-wingeneral.h: Include gdb_curses.h.
9513
9514 2019-01-22  Tom Tromey  <tom@tromey.com>
9515
9516         * source-cache.h (class source_cache) <get_source_lines,
9517         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9518
9519 2019-01-22  Tom Tromey  <tom@tromey.com>
9520
9521         * remote-fileio.h (struct remote_target): Declare.
9522
9523 2019-01-22  Tom Tromey  <tom@tromey.com>
9524
9525         * python/py-arch.c: Do not include py-ref.h.
9526         * python/py-bpevent.c: Do not include py-ref.h.
9527         * python/py-cmd.c: Do not include py-ref.h.
9528         * python/py-continueevent.c: Do not include py-ref.h.
9529         * python/py-event.h: Do not include py-ref.h.
9530         * python/py-evtregistry.c: Do not include py-ref.h.
9531         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9532         * python/py-frame.c: Do not include py-ref.h.
9533         * python/py-framefilter.c: Do not include py-ref.h.
9534         * python/py-function.c: Do not include py-ref.h.
9535         * python/py-infevents.c: Do not include py-ref.h.
9536         * python/py-linetable.c: Do not include py-ref.h.
9537         * python/py-objfile.c: Do not include py-ref.h.
9538         * python/py-param.c: Do not include py-ref.h.
9539         * python/py-prettyprint.c: Do not include py-ref.h.
9540         * python/py-progspace.c: Do not include py-ref.h.
9541         * python/py-symbol.c: Do not include py-ref.h.
9542         * python/py-symtab.c: Do not include py-ref.h.
9543         * python/py-type.c: Do not include py-ref.h.
9544         * python/py-unwind.c: Do not include py-ref.h.
9545         * python/py-utils.c: Do not include py-ref.h.
9546         * python/py-value.c: Do not include py-ref.h.
9547         * python/py-varobj.c: Do not include py-ref.h.
9548         * python/py-xmethods.c: Do not include py-ref.h.
9549         * python/python.c: Do not include py-ref.h.
9550         * varobj.c: Do not include py-ref.h.
9551
9552 2019-01-22  Tom Tromey  <tom@tromey.com>
9553
9554         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9555         keyword for bcache.
9556
9557 2019-01-22  Tom Tromey  <tom@tromey.com>
9558
9559         * compile/compile-cplus-types.c: Remove a comment by #include.
9560
9561 2019-01-22  Tom Tromey  <tom@tromey.com>
9562
9563         * compile/gcc-c-plugin.h: Include compile-internal.h.
9564
9565 2019-01-22  Tom Tromey  <tom@tromey.com>
9566
9567         * stabsread.c (EXTERN): Do not define.
9568         (symnum, next_symbol_text_func, processing_gcc_compilation)
9569         (within_function, global_sym_chain, global_stabs)
9570         (previous_stab_code, this_object_header_files)
9571         (n_this_object_header_files)
9572         (n_allocated_this_object_header_files): Define.
9573         * stabsread.h (EXTERN): Never define.  Use "extern".
9574
9575 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9576
9577         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9578         history_value.
9579
9580 2019-01-21  Tom Tromey  <tom@tromey.com>
9581
9582         * ui-out.c: Fix includes.
9583         * tui/tui-source.c: Fix includes.
9584         * target.c: Fix includes.
9585         * remote.c: Fix includes.
9586         * regcache.c: Fix includes.
9587         * python/py-block.c: Fix includes.
9588         * printcmd.c: Fix includes.
9589         * or1k-tdep.c: Fix includes.
9590         * mi/mi-main.c: Fix includes.
9591         * m32r-tdep.c: Fix includes.
9592         * csky-tdep.c: Fix includes.
9593         * compile/compile-cplus-types.c: Fix includes.
9594         * cli/cli-interp.c: Fix includes.
9595
9596 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9597
9598         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9599         for padding.
9600
9601 2019-01-16  Tom Tromey  <tom@tromey.com>
9602
9603         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9604         earlier.
9605         (struct objfile) <msymbols_range>: Move from top level.
9606         <msymbols>: New method.
9607         (class objfile_msymbols): Remove.
9608         * symtab.c (default_collect_symbol_completion_matches_break_on):
9609         Update.
9610         * symmisc.c (dump_msymbols): Update.
9611         * stabsread.c (scan_file_globals): Update.
9612         * objc-lang.c (info_selectors_command, info_classes_command)
9613         (find_methods): Update.
9614         * minsyms.c (find_solib_trampoline_target): Update.
9615         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9616         * coffread.c (coff_symfile_read): Update.
9617         * ada-lang.c (ada_lookup_simple_minsym)
9618         (ada_collect_symbol_completion_matches): Update.
9619
9620 2019-01-16  Tom Tromey  <tom@tromey.com>
9621
9622         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9623         type.  Remove no-argument constructor.
9624         <iterator::operator++>: Simplify.
9625         <begin>: Update.
9626         <end>: Use minimal_symbol_count.
9627
9628 2019-01-16  Tom Tromey  <tom@tromey.com>
9629
9630         * objfiles.h (struct objfile) <psymtabs>: New method.
9631         (class objfile_psymtabs): Remove.
9632         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9633         typedef.
9634         <range>: New method.
9635         (require_partial_symbols): Change return type.
9636         * psymtab.c (require_partial_symbols)
9637         (psym_expand_symtabs_matching): Update.
9638         * mdebugread.c (parse_partial_symbols): Update.
9639         * dbxread.c (dbx_end_psymtab): Update.
9640
9641 2019-01-15  Tom Tromey  <tom@tromey.com>
9642
9643         * symtab.c (lookup_objfile_from_block)
9644         (lookup_symbol_in_objfile_symtabs)
9645         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9646         (find_line_symtab, info_sources_command)
9647         (default_collect_symbol_completion_matches_break_on)
9648         (make_source_files_completion_list): Update.
9649         * symmisc.c (print_objfile_statistics, dump_objfile)
9650         (maintenance_print_symbols, maintenance_info_symtabs)
9651         (maintenance_check_symtabs, maintenance_info_line_tables):
9652         Update.
9653         * source.c (select_source_symtab)
9654         (forget_cached_source_info_for_objfile): Update.
9655         * objfiles.h (class objfile_compunits): Remove.
9656         (struct objfile) <compunits_range>: New typedef.
9657         (compunits): New method.
9658         * objfiles.c (objfile_relocate1): Update.
9659         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9660         * maint.c (count_symtabs_and_blocks): Update.
9661         * linespec.c (iterate_over_all_matching_symtabs): Update.
9662         * cp-support.c (add_symbol_overload_list_qualified): Update.
9663         * coffread.c (coff_symtab_read): Update.
9664         * ada-lang.c (add_nonlocal_symbols)
9665         (ada_collect_symbol_completion_matches)
9666         (ada_add_global_exceptions): Update.
9667
9668 2019-01-15  Tom Tromey  <tom@tromey.com>
9669
9670         * progspace.h (program_space) <objfiles_safe_range>: New
9671         typedef.
9672         <objfiles_safe>: New method.
9673         * objfiles.h (class all_objfiles_safe): Remove.
9674         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9675         * jit.c (jit_inferior_exit_hook): Update.
9676
9677 2019-01-17  Tom Tromey  <tom@tromey.com>
9678
9679         * progspace.h (program_space) <objfiles_range>: New typedef.
9680         <objfiles>: New method.
9681         <objfiles_head>: Rename from objfiles.
9682         (object_files): Update.
9683         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9684         * guile/scm-pretty-print.c
9685         (ppscm_find_pretty_printer_from_objfiles): Update.
9686         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9687         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9688         Update.
9689         * python/py-progspace.c (pspy_get_objfiles): Update.
9690         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9691         Update.
9692         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9693         (objfpy_lookup_objfile_by_build_id): Update.
9694         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9695         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9696         Update.
9697         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9698         (expand_symtab_containing_pc, lookup_objfile_from_block)
9699         (lookup_static_symbol, basic_lookup_transparent_type)
9700         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9701         (find_line_symtab, info_sources_command)
9702         (default_collect_symbol_completion_matches_break_on)
9703         (make_source_files_completion_list, find_main_name): Update.
9704         * symmisc.c (print_symbol_bcache_statistics)
9705         (print_objfile_statistics, maintenance_print_symbols)
9706         (maintenance_print_msymbols, maintenance_print_objfiles)
9707         (maintenance_info_symtabs, maintenance_check_symtabs)
9708         (maintenance_expand_symtabs, maintenance_info_line_tables):
9709         Update.
9710         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9711         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9712         (map_overlay_command, unmap_overlay_command)
9713         (simple_overlay_update, expand_symtabs_matching)
9714         (map_symbol_filenames): Update.
9715         * symfile-debug.c (set_debug_symfile): Update.
9716         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9717         Update.
9718         * source.c (select_source_symtab, forget_cached_source_info):
9719         Update.
9720         * solib.c (solib_read_symbols): Update.
9721         * solib-spu.c (append_ocl_sos): Update.
9722         * psymtab.c (maintenance_print_psymbols)
9723         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9724         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9725         * printcmd.c (info_symbol_command): Update.
9726         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9727         Update.
9728         * objfiles.h (class all_objfiles): Remove.
9729         * objfiles.c (have_partial_symbols, have_full_symbols)
9730         (have_minimal_symbols, qsort_cmp, update_section_map)
9731         (shared_objfile_contains_address_p)
9732         (default_iterate_over_objfiles_in_search_order): Update.
9733         * objc-lang.c (info_selectors_command, info_classes_command)
9734         (find_methods): Update.
9735         * minsyms.c (find_solib_trampoline_target): Update.
9736         * maint.c (maintenance_info_sections)
9737         (maintenance_translate_address, count_symtabs_and_blocks):
9738         Update.
9739         * main.c (captured_main_1): Update.
9740         * linux-thread-db.c (try_thread_db_load_from_pdir)
9741         (has_libpthread): Update.
9742         * linespec.c (iterate_over_all_matching_symtabs)
9743         (search_minsyms_for_name): Update.
9744         * jit.c (jit_find_objf_with_entry_addr): Update.
9745         * hppa-tdep.c (find_unwind_entry)
9746         (hppa_lookup_stub_minimal_symbol): Update.
9747         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9748         Update.
9749         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9750         (elf_gnu_ifunc_resolve_by_got): Update.
9751         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9752         * dwarf-index-write.c (save_gdb_index_command): Update.
9753         * cp-support.c (add_symbol_overload_list_qualified): Update.
9754         * breakpoint.c (create_overlay_event_breakpoint)
9755         (create_longjmp_master_breakpoint)
9756         (create_std_terminate_master_breakpoint)
9757         (create_exception_master_breakpoint): Update.
9758         * blockframe.c (find_pc_partial_function): Update.
9759         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9760         (ada_collect_symbol_completion_matches)
9761         (ada_add_global_exceptions): Update.
9762
9763 2019-01-17  Tom Tromey  <tom@tromey.com>
9764
9765         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9766         declare VEC.
9767         (solib_target_parse_libraries): Change return type.
9768         (library_list_start_segment, library_list_start_section)
9769         (library_list_end_library, library_list_start_library); Update.
9770         (solib_target_free_library_list): Remove.
9771         (solib_target_parse_libraries): Remove cleanup.  Change return
9772         type.
9773         (solib_target_current_sos): Update.
9774
9775 2019-01-17  Tom Tromey  <tromey@bapiya>
9776
9777         * valprint.c: Replace "the the" with "the".
9778         * symtab.c: Replace "the the" with "the".
9779         * solib.c: Replace "the the" with "the".
9780         * solib-dsbt.c: Replace "the the" with "the".
9781         * linespec.c: Replace "the the" with "the".
9782         * dwarf2loc.h: Replace "the the" with "the".
9783         * amd64-windows-tdep.c: Replace "the the" with "the".
9784         * aarch64-tdep.c: Replace "the the" with "the".
9785
9786 2019-01-16  Keith Seitz  <keiths@redhat.com>
9787
9788         PR gdb/23773
9789         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9790         <builder>: Rename to ..
9791         <m_builder>: ... this and make private.
9792         (dwarf2_cu::get_builder): New method.  Change all users of
9793         `builder' to use this method.
9794         (dwarf2_start_symtab): Move to ...
9795         (dwarf2_cu::start_symtab): ... here.  Update all callers
9796         (setup_type_unit_groups): Move to ...
9797         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9798         callers.
9799         (dwarf2_cu::reset_builder): New method.
9800         (process_full_compunit, process_full_type_unit): Use
9801         dwarf2_cu::reset_builder.
9802         (follow_die_offset): Record the ancestor CU if it is different
9803         from the followed DIE's CU.
9804         (follow_die_sig_1): Likewise.
9805
9806 2019-01-15  Tom Tromey  <tom@tromey.com>
9807
9808         * remote.c (class remote_state) <buf>: Now a char_vector.
9809         <buf_size>: Remove.
9810         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9811         parameter.
9812         (remote_target::getpkt_or_notif_sane_1)
9813         (remote_target::getpkt_sane)
9814         (remote_target::getpkt_or_notif_sane): Likewise.
9815         (class remote_target) <putpkt>: New overload.
9816         (remote_target::read_frame): Change type of "buf_p".  Remove
9817         sizeof_p parameter.
9818         (packet_ok): New overload.
9819         (packet_check_result): New overload.
9820         Update all uses.
9821
9822 2019-01-14  Tom Tromey  <tom@tromey.com>
9823
9824         * remote-notif.c (handle_notification, remote_notif_ack)
9825         (remote_notif_parse): Make "buf" const.
9826         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9827         const.
9828         (remote_notif_parse, remote_notif_ack, handle_notification):
9829         Likewise.
9830         * remote.c (remote_notif_stop_parse): Make "buf" const.
9831         (remote_target::remote_parse_stop_reply): Make "buf" const.
9832         (remote_notif_stop_ack): Make "buf" const.
9833
9834 2019-01-14  Tom Tromey  <tom@tromey.com>
9835
9836         * remote.c (remote_console_output): Make parameter const.
9837
9838 2019-01-14  Tom Tromey  <tom@tromey.com>
9839
9840         * target-debug.h (target_debug_print_signals): Constify.
9841         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9842         * procfs.c (procfs_target::pass_signals): Update.
9843         * linux-nat.c (linux_nat_target::pass_signals): Update.
9844         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9845         * target-delegates.c: Rebuild.
9846         * remote.c (remote_target::program_signals): Update.
9847         (remote_target::pass_signals): Update.
9848         * target.c (target_pass_signals): Constify argument.
9849         (target_program_signals): Likewise.
9850         * target.h (struct target_ops) <pass_signals, program_signals>:
9851         Constify argument.
9852         (target_pass_signals, target_program_signals): Constify argument.
9853
9854 2019-01-14  Tom Tromey  <tom@tromey.com>
9855
9856         PR tui/28819:
9857         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9858
9859 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9860
9861         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9862         field.
9863         * rs6000-tdep.c: Include reggroups.h.
9864         (IS_V_ALIAS_PSEUDOREG): Define.
9865         (rs6000_register_name): Return names for the "vX" aliases.
9866         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9867         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9868         aliases.  Call default_register_reggroup_p for all other
9869         pseudo-registers.
9870         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9871         New functions.
9872         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9873         Handle "vX" aliases.
9874         (v_alias_pseudo_register_collect): New function.
9875         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9876         (rs6000_gdbarch_init): Initialize "vX" aliases as
9877         pseudo-registers.  Restore registration of
9878         rs6000_pseudo_register_reggroup_p with
9879         set_tdesc_pseudo_register_reggroup_p.
9880
9881 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9882
9883         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9884         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9885         set_gdbarch_num_pseudo_regs.
9886
9887 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9888
9889         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9890         Remove arg prefixname, add do_set and do_show.
9891         Add member functions set_list and show_list.
9892         * cli/cli-style.c (class cli_style_option): Update accordingly.
9893         (style_set_list): Move to file scope.
9894         (style_show_list): Likewise.
9895         (set_style): Call help_list.
9896         (show_style): Call cmd_show_list.
9897         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9898         Update to use the new macro.
9899
9900 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9901
9902         * ada-lang.c (_initialize_ada_language): Expand the help text
9903         for the "catch exception" command.
9904
9905 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9906
9907         * symtab.c (matching_obj_sections): Initialize obj,
9908         declare it closer to its usage.
9909
9910 2019-01-10  Tom Tromey  <tom@tromey.com>
9911
9912         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9913         (basic_inf_threads_range): Remove.
9914         (inf_threads_range, inf_non_exited_threads_range)
9915         (safe_inf_threads_range): Use next_adapter.
9916
9917 2019-01-10  Keith Seitz  <keiths@redhat.com>
9918
9919         PR gdb/23712
9920         PR symtab/23010
9921         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9922         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9923
9924 2019-01-10  Keith Seitz  <keiths@redhat.com>
9925
9926         PR gdb/23712
9927         PR symtab/23010
9928         * dictionary.c (pending_to_vector): Remove.
9929         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9930         Remove _1 suffix, replacing functions of the same name.  Update
9931         all callers.
9932         (dict_create_hashed, dict_create_hashed_expandable)
9933         (dict_create_linear, dict_create_linear_expandable, dict_free)
9934         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9935         Make functions static.
9936
9937 2019-01-10  Keith Seitz  <keiths@redhat.com>
9938
9939         PR gdb/23712
9940         PR symtab/23010
9941         * dictionary.h (struct dictionary): Replace declaration with
9942         multidictionary.
9943         (dict_create_hashed, dict_create_hashed_expandable)
9944         (dict_create_linear, dict_create_linear_expandable)
9945         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9946         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9947         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9948         taking multidictionary argument.
9949         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9950         * block.h (struct block) <dict>: Change to multidictionary
9951         and rename `multidict'.
9952         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9953         symmisc.c: Update all dictionary references to multidictionary.
9954
9955 2019-01-10  Keith Seitz  <keiths@redhat.com>
9956
9957         PR gdb/23712
9958         PR symtab/23010
9959         * dictionary.c: Include unordered_map.
9960         (pending_to_vector): New function.
9961         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9962         Rewrite the non-"_1" functions to take vector instead
9963         of linked list.
9964         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9965         "new" _1 versions of the same name.
9966         (multidictionary): Define.
9967         (std::hash<enum language): New definition.
9968         (collate_pending_symbols_by_language, mdict_create_hashed)
9969         (mdict_create_hashed_expandable, mdict_create_linear)
9970         (mdict_create_linear_expandable, mdict_free)
9971         (find_language_dictionary, create_new_language_dictionary)
9972         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9973         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9974         (mdict_size, mdict_empty): New functions.
9975         * dictionary.h (mdict_iterator): Define.
9976
9977 2019-01-10  Pedro Alves  <palves@redhat.com>
9978
9979         * breakpoint.c (read_uploaded_action)
9980         (create_tracepoint_from_upload): Adjust to use
9981         gdb::unique_xmalloc_ptr.
9982         * ctf.c (ctf_write_uploaded_tp):
9983         (SET_ARRAY_FIELD): Use emplace_back.
9984         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9985         * tracefile-tfile.c (tfile_write_uploaded_tp):
9986         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9987         gdb::unique_xmalloc_ptr.
9988         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9989         at_string, cond_string, cmd_strings>: Replace char pointers
9990         with gdb::unique_xmalloc_ptr.
9991
9992 2019-01-10  Pedro Alves  <palves@redhat.com>
9993
9994         * solib-target.c (library_list_start_library): Don't xstrdup name.
9995
9996 2019-01-10  Pedro Alves  <palves@redhat.com>
9997
9998         * mdebugread.c (parse_partial_symbols): Use
9999         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10000
10001 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10002
10003         * linux-fork.c (scoped_switch_fork_info)
10004         <~scoped_switch_fork_info>: Fix incorrect variable name.
10005
10006 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10007
10008         * linux-fork.c (scoped_switch_fork_info)
10009         <scoped_switch_fork_info>: Make explicit.
10010         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10011
10012 2019-01-10  Tom Tromey  <tom@tromey.com>
10013
10014         * objfiles.h (objfile::reset_psymtabs): Update.
10015         * objfiles.c (objfile::objfile): Update.
10016         * psymtab.h (psymtab_storage::obstack): Update.
10017         (psymtab_storage::m_obstack): Use gdb::optional.
10018         (class psymtab_storage): Update comment.  Remove objfile
10019         parameter.
10020         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10021
10022 2019-01-10  Tom Tromey  <tom@tromey.com>
10023
10024         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10025         <free_psymtabs>: Now private.
10026         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10027         (allocate_psymtab): Use new method.
10028
10029 2019-01-10  Tom Tromey  <tom@tromey.com>
10030
10031         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10032         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10033         * mdebugread.c (parse_partial_symbols): Use
10034         allocate_dependencies.
10035         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10036         allocate_dependencies.
10037         (process_psymtab_comp_unit_reader)
10038         (build_type_psymtab_dependencies): Likewise.
10039         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10040
10041 2019-01-10  Tom Tromey  <tom@tromey.com>
10042
10043         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10044         PSYMBOL_SET_LANGUAGE.
10045         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10046
10047 2019-01-10  Tom Tromey  <tom@tromey.com>
10048
10049         * psymtab.h (psymtab_storage::obstack): New method.
10050         <m_obstack>: Rename from obstack; now private.
10051         * psymtab.c (psymtab_storage): Update.
10052         * dwarf2read.c (create_addrmap_from_index)
10053         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10054         Update.
10055
10056 2019-01-10  Tom Tromey  <tom@tromey.com>
10057
10058         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10059         * objfiles.h (objfile::reset_psymtabs): New method.
10060
10061 2019-01-10  Tom Tromey  <tom@tromey.com>
10062
10063         * symmisc.c (print_symbol_bcache_statistics): Update.
10064         (print_objfile_statistics): Update.
10065         * symfile.c (reread_symbols): Update.
10066         * psymtab.h (class psymtab_storage): New.
10067         * psymtab.c (psymtab_storage): New constructor.
10068         (~psymtab_storage): New destructor.
10069         (require_partial_symbols): Update.
10070         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10071         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10072         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10073         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10074         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10075         (start_psymtab_common, end_psymtab_common)
10076         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10077         (allocate_psymtab): Update.
10078         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10079         Update.
10080         (dump_psymtab_addrmap, maintenance_print_psymbols)
10081         (maintenance_check_psymtabs): Update.
10082         (class objfile_psymtabs): Move to objfiles.h.
10083         * psympriv.h (discard_psymtab): Now inline.
10084         (psymtab_discarder::psymtab_discarder): Update.
10085         (psymtab_discarder::~psymtab_discarder): Update.
10086         (ALL_OBJFILE_PSYMTABS): Rewrite.
10087         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10088         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10089         Remove fields.
10090         <partial_symtabs>: New field.
10091         (class objfile_psymtabs): Move from psymtab.h.  Update.
10092         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10093         psymbol_cache.
10094         (objfile::~objfile): Don't destroy psymbol_cache.
10095         * mdebugread.c (parse_partial_symbols): Update.
10096         * dwarf2read.c (create_addrmap_from_index)
10097         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10098         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10099         (add_partial_subprogram, dwarf2_ranges_read): Update.
10100         * dwarf-index-write.c (write_address_map)
10101         (write_one_signatured_type, recursively_write_psymbols)
10102         (class debug_names, class debug_names, write_psymtabs_to_index):
10103         Update.
10104
10105 2019-01-10  Tom Tromey  <tom@tromey.com>
10106
10107         * symtab.h (SYMBOL_SET_NAMES): Update.
10108         (symbol_set_names): Update.
10109         (MSYMBOL_SET_NAMES): Update.
10110         * symtab.c (symbol_set_names): Change argument to be an
10111         objfile_per_bfd_storage.
10112         * psymtab.c (add_psymbol_to_bcache): Update.
10113         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10114
10115 2019-01-10  Tom Tromey  <tom@tromey.com>
10116
10117         * symtab.c (create_demangled_names_hash): Change argument to be an
10118         objfile_per_bfd_storage.
10119         (symbol_set_names): Update.
10120
10121 2019-01-10  Tom Tromey  <tom@tromey.com>
10122
10123         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10124         init_psymbol_list.
10125         * psymtab.c (init_psymbol_list): Do nothing if already called.
10126         * psympriv.h (init_psymbol_list): Add comment.
10127         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10128         init_psymbol_list.
10129         * dbxread.c (dbx_symfile_read): Unconditionally call
10130         init_psymbol_list.
10131
10132 2019-01-10  Tom Tromey  <tom@tromey.com>
10133
10134         * xcoffread.c (scan_xcoff_symtab): Update.
10135         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10136         "where".
10137         * mdebugread.c (parse_partial_symbols)
10138         (handle_psymbol_enumerators): Update.
10139         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10140         * dbxread.c (read_dbx_symtab): Update.
10141         * psympriv.h (psymbol_placement): New enum.
10142         (add_psymbol_to_list): Update.
10143
10144 2019-01-10  Tom Tromey  <tom@tromey.com>
10145
10146         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10147         static_psymbols parameters.
10148         (scan_xcoff_symtab): Update.
10149         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10150         static_psymbols parameters.
10151         * psympriv.h (start_psymtab_common): Update.
10152         * mdebugread.c (parse_partial_symbols): Update.
10153         * dwarf2read.c (create_partial_symtab): Update.
10154         * dbxread.c (read_dbx_symtab): Update.
10155         (start_psymtab): Remove global_psymbols and static_psymbols
10156         parameters.
10157
10158 2019-01-10  Tom Tromey  <tom@tromey.com>
10159
10160         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10161         * psymtab.c (allocate_psymtab): Add comment.
10162         * psympriv.h (allocate_psymtab): Add comment.
10163         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10164         initializations.
10165         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10166
10167 2019-01-10  Tom Tromey  <tom@tromey.com>
10168
10169         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10170         Don't declare.
10171         * mipsread.c: Include mdebugread.h.
10172         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10173         Declare.
10174         * elfread.c: Include mdebugread.h.
10175
10176 2019-01-09  Tom Tromey  <tom@tromey.com>
10177
10178         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10179         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10180         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10181         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10182         (psym_lookup_symbol, psym_find_last_source_symtab)
10183         (psym_forget_cached_source_info, psym_print_stats)
10184         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10185         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10186         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10187         (psym_find_compunit_symtab_by_address)
10188         (maintenance_print_psymbols, maintenance_info_psymtabs)
10189         (maintenance_check_psymtabs): Use ranged for.
10190         * psymtab.h (class objfile_psymtabs): New.
10191         (require_partial_symbols): Return objfile_psymtabs.
10192         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10193
10194 2019-01-09  Tom Tromey  <tom@tromey.com>
10195
10196         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10197         (find_pc_mapped_section, list_overlays_command)
10198         (map_overlay_command, unmap_overlay_command)
10199         (simple_overlay_update): Use all_objfiles.
10200         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10201         * printcmd.c (info_symbol_command): Use all_objfiles.
10202         * objfiles.h (ALL_OBJSECTIONS): Remove.
10203         * maint.c (maintenance_translate_address): Use all_objfiles.
10204         * gcore.c (gcore_create_callback): Use all_objfiles.
10205         (objfile_find_memory_regions): Likewise.
10206
10207 2019-01-09  Tom Tromey  <tom@tromey.com>
10208
10209         * symtab.c (find_line_symtab, info_sources_command)
10210         (make_source_files_completion_list): Use objfile_compunits.
10211         * source.c (select_source_symtab): Use objfile_compunits.
10212         * objfiles.h (struct objfile): Update comment.
10213         (ALL_OBJFILES): Remove.
10214         (ALL_FILETABS): Remove.
10215         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10216         objfile_compunits.
10217
10218 2019-01-09  Tom Tromey  <tom@tromey.com>
10219
10220         * symmisc.c (print_objfile_statistics, dump_objfile)
10221         (maintenance_print_symbols): Use compunit_filetabs.
10222         * source.c (forget_cached_source_info_for_objfile): Use
10223         compunit_filetabs.
10224         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10225         (ALL_FILETABS): Use compunit_filetabs.
10226         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10227         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10228
10229 2019-01-09  Tom Tromey  <tom@tromey.com>
10230
10231         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10232         (compunit_filetabs): New.
10233         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10234         compunit_filetabs.
10235         (info_sources_command, make_source_files_completion_list): Remove
10236         declaration.
10237         * symmisc.c (print_objfile_statistics, dump_objfile)
10238         (maintenance_print_symbols): Remove declaration.
10239         (maintenance_info_symtabs): Use compunit_filetabs.
10240         (maintenance_info_line_tables): Likewise.
10241         * source.c (select_source_symtab): Change local variable name.
10242         (forget_cached_source_info_for_objfile): Remove declaration.
10243         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10244         * objfiles.c (objfile_relocate1): Remove declaration.
10245         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10246         declaration.
10247         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10248         * coffread.c (coff_symtab_read): Remove declaration.
10249         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10250         compunit_filetabs.
10251
10252 2019-01-09  Tom Tromey  <tom@tromey.com>
10253
10254         * symtab.c (lookup_objfile_from_block)
10255         (find_pc_sect_compunit_symtab, search_symbols)
10256         (default_collect_symbol_completion_matches_break_on): Use
10257         objfile_compunits.
10258         * objfiles.h (ALL_COMPUNITS): Remove.
10259         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10260         * cp-support.c (add_symbol_overload_list_qualified): Use
10261         objfile_compunits.
10262         * ada-lang.c (ada_collect_symbol_completion_matches)
10263         (ada_add_global_exceptions): Use objfile_compunits.
10264
10265 2019-01-09  Tom Tromey  <tom@tromey.com>
10266
10267         * source.c (select_source_symtab)
10268         (forget_cached_source_info_for_objfile): Remove declaration.
10269         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10270         declaration.
10271         * maint.c (count_symtabs_and_blocks): Remove declaration.
10272         * cp-support.c (add_symbol_overload_list_qualified): Remove
10273         declaration.
10274         * coffread.c (coff_symtab_read): Remove declaration.
10275         * symtab.c (lookup_symbol_in_objfile_symtabs)
10276         (basic_lookup_transparent_type_1): Use objfile_compunits.
10277         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10278         (info_sources_command, search_symbols)
10279         (default_collect_symbol_completion_matches_break_on)
10280         (make_source_files_completion_list): Remove declaration.
10281         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10282         (ada_collect_symbol_completion_matches)
10283         (ada_add_global_exceptions): Remove declaration.
10284         * linespec.c (iterate_over_all_matching_symtabs): Use
10285         objfile_compunits.
10286         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10287         (class objfile_compunits): New.
10288         (ALL_COMPUNITS): Use objfile_compunits.
10289         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10290         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10291         objfile_compunits.
10292         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10293
10294 2019-01-09  Tom Tromey  <tom@tromey.com>
10295
10296         * symtab.c (search_symbols)
10297         (default_collect_symbol_completion_matches_break_on): Use
10298         objfile_msymbols.
10299         * ada-lang.c (ada_lookup_simple_minsym)
10300         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10301         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10302         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10303         objfile_msymbols.
10304         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10305         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10306         * objc-lang.c (find_methods): Use objfile_msymbols.
10307         (info_selectors_command, info_classes_command): Likewise.
10308         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10309         * objfiles.h (class objfile_msymbols): New.
10310         (ALL_OBJFILE_MSYMBOLS): Remove.
10311         (ALL_MSYMBOLS): Remove.
10312
10313 2019-01-09  Tom Tromey  <tom@tromey.com>
10314
10315         * common/next-iterator.h (next_adapter): Add Iterator template
10316         parameter.
10317         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10318         (class all_objfiles_safe): New.
10319         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10320         * objfiles.c (put_objfile_before): Update comment.
10321         (add_separate_debug_objfile): Likewise.
10322         (free_all_objfiles): Use all_objfiles_safe.
10323         (objfile_purge_solibs): Likewise.
10324
10325 2019-01-09  Tom Tromey  <tom@tromey.com>
10326
10327         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10328         (expand_symtab_containing_pc, lookup_static_symbol)
10329         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10330         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10331         all_objfiles.
10332         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10333         * breakpoint.c (create_overlay_event_breakpoint)
10334         (create_longjmp_master_breakpoint)
10335         (create_std_terminate_master_breakpoint)
10336         (create_exception_master_breakpoint): Use all_objfiles.
10337         * linux-thread-db.c (try_thread_db_load_from_pdir)
10338         (has_libpthread): Use all_objfiles.
10339         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10340         * linespec.c (iterate_over_all_matching_symtabs)
10341         (search_minsyms_for_name): Use all_objfiles.
10342         * maint.c (maintenance_info_sections): Use all_objfiles.
10343         * main.c (captured_main_1): Use all_objfiles.
10344         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10345         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10346         * guile/scm-pretty-print.c
10347         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10348         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10349         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10350         (maintenance_print_msymbols): Use all_objfiles.
10351         * source.c (select_source_symtab): Use all_objfiles.
10352         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10353         * symfile.c (remove_symbol_file_command)
10354         (expand_symtabs_matching, map_symbol_filenames): Use
10355         all_objfiles.
10356         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10357         all_objfiles.
10358         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10359         * objc-lang.c (find_methods): Use all_objfiles.
10360         * objfiles.c (have_partial_symbols, have_full_symbols)
10361         (have_minimal_symbols, qsort_cmp)
10362         (default_iterate_over_objfiles_in_search_order): Use
10363         all_objfiles.
10364         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10365         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10366         (maintenance_check_psymtabs): Use all_objfiles.
10367         (ALL_PSYMTABS): Remove.
10368         * compile/compile-object-run.c (do_module_cleanup): Use
10369         all_objfiles.
10370         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10371         * cp-support.c (add_symbol_overload_list_qualified): Use
10372         all_objfiles.
10373         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10374         Use all_objfiles.
10375         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10376         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10377         all_objfiles.
10378         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10379         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10380         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10381         Uses all_objfiles.
10382         * solib.c (solib_read_symbols): Use all_objfiles
10383
10384 2019-01-09  Tom Tromey  <tom@tromey.com>
10385
10386         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10387         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10388         all_objfiles.
10389         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10390         * symmisc.c (print_symbol_bcache_statistics)
10391         (print_objfile_statistics, maintenance_print_objfiles)
10392         (maintenance_info_symtabs, maintenance_check_symtabs)
10393         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10394         all_objfiles.
10395         * source.c (forget_cached_source_info): Use all_objfiles.
10396         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10397         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10398         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10399         * objfiles.c (update_section_map): Use all_objfiles.
10400         (shared_objfile_contains_address_p): Likewise.
10401         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10402         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10403
10404 2019-01-09  Tom Tromey  <tom@tromey.com>
10405
10406         * common/next-iterator.h: New file.
10407         * objfiles.h (class all_objfiles): New.
10408         (struct objfile_iterator): New.
10409
10410 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10411
10412         * NEWS: Move the description of the changed "frame", "select-frame",
10413          and "info frame" commands to the Changed commands section.
10414
10415 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10416
10417         * gdbtypes.c (check_stub_method_group): Remove handling of old
10418         mangling schemes.
10419         * linespec.c (find_methods): Likewise.
10420         * stabsread.c (read_member_functions): Likewise.
10421         * valops.c (search_struct_method): Likewise.
10422         (value_struct_elt_for_reference): Likewise.
10423         * NEWS: Mention this change.
10424
10425 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10426
10427         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10428         print_source_lines.
10429         * source.c (print_source_lines_base): Update line number check.
10430         (print_source_lines): New function.
10431         (source_lines_range::source_lines_range): New function.
10432         * source.h (class source_lines_range): New class.
10433         (print_source_lines): New declaration.
10434
10435 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10436
10437         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10438
10439 2019-01-08  Tom Tromey  <tom@tromey.com>
10440             Simon Marchi  <simon.marchi@ericsson.com>
10441
10442         PR gdb/24060
10443         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10444         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10445         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10446         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10447         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10448         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10449
10450 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10451
10452         * source.c (select_source_symtab): Move header comment to
10453         declaration in source.h.
10454         (forget_cached_source_info_for_objfile): Likewise.
10455         (forget_cached_source_info): Likewise.
10456         (identify_source_line): Likewise.
10457         * source.h (identify_source_line): Move declaration from symtab.h
10458         and add comment from source.c
10459         (print_source_lines): Likewise.
10460         (forget_cached_source_info_for_objfile): Likewise.
10461         (forget_cached_source_info): Likewise.
10462         (select_source_symtab): Likewise.
10463         (enum print_source_lines_flag): Move definition from symtab.h.
10464         * symtab.h (identify_source_line): Move declaration to source.h.
10465         (print_source_lines): Likewise.
10466         (forget_cached_source_info_for_objfile): Likewise.
10467         (forget_cached_source_info): Likewise.
10468         (select_source_symtab): Likewise.
10469         (enum print_source_lines_flag): Move definition to source.h.
10470         * tui/tui-hooks.c: Add 'source.h' include.
10471
10472 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10473
10474         * source.c (print_source_lines_base): Handle requests to print
10475         reverse line number sequences, and guard against empty lines
10476         string.
10477
10478 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10479
10480         * source.c (print_source_lines_base): Fix skip of '\r' if next
10481         character is '\n'.
10482
10483 2019-01-06  Tom Tromey  <tom@tromey.com>
10484
10485         * c-exp.y (struct c_parse_state) <macro_original_text,
10486         expansion_obstack>: New member.
10487         (macro_original_text, expansion_obstack): Remove globals.
10488         (scan_macro_expansion, scanning_macro_expansion)
10489         (finished_macro_expansion): Update.
10490         (scan_macro_cleanup): Remove.
10491         (yylex, c_parse): Update.
10492
10493 2019-01-06  Tom Tromey  <tom@tromey.com>
10494
10495         * c-exp.y (struct c_parse_state) <strings>: New member.
10496         (operator_stoken): Update.
10497
10498 2019-01-06  Tom Tromey  <tom@tromey.com>
10499
10500         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10501         (union type_stack_elt) <typelist_val>: Now a pointer to
10502         std::vector.
10503         (type_stack_cleanup): Don't declare.
10504         (push_typelist): Update.
10505         * parse.c (pop_typelist): Return a std::vector.
10506         (push_typelist): Take a std::vector.
10507         (follow_types): Update.  Do not free args.
10508         (type_stack_cleanup): Remove.
10509         * c-exp.y (struct c_parse_state): New.
10510         (cpstate): New global.
10511         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10512         (nonempty_typelist): Update.
10513         (func_mod): Create a new vector.
10514         (c_parse): Create a c_parse_state.
10515         (check_parameter_typelist): Do not delete params.
10516         (function_method): Update.  Do not delete type_list.
10517
10518 2019-01-06  Tom Tromey  <tom@tromey.com>
10519
10520         PR gdb/28155:
10521         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10522         check_typedef.
10523         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10524         (print_return_value): Likewise.
10525
10526 2019-01-05  Tom Tromey  <tom@tromey.com>
10527
10528         * contrib/cleanup_check.py: Remove.
10529         * contrib/gcc-with-excheck: Remove.
10530         * contrib/exsummary.py: Remove.
10531         * contrib/excheck.py: Remove.
10532
10533 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10534
10535         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10536         NULL. Initialize tpprev to NULL instead of assigning it
10537         to NULL on the next statement.
10538         * windows-nat.c (windows_delete_thread): Remove check for
10539         main_thread_id before printing thread exit notifications.
10540         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10541         Remove thread ID check against main_thread_id.
10542         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10543         windows_delete_thread.
10544         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10545
10546 2019-01-04  Tom Tromey  <tom@tromey.com>
10547
10548         * compile/compile.c (_initialize_compile): Use upper case for
10549         metasyntactic variables.
10550         * symmisc.c (_initialize_symmisc): Use upper case for
10551         metasyntactic variables.
10552         * psymtab.c (_initialize_psymtab): Use upper case for
10553         metasyntactic variables.
10554         * demangle.c (demangle_command): Use upper case for metasyntactic
10555         variables.
10556         (_initialize_demangler): Likewise.
10557         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10558         variables.
10559
10560 2019-01-03  Tom Tromey  <tom@tromey.com>
10561
10562         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10563
10564 2019-01-03  Tom Tromey  <tom@tromey.com>
10565
10566         * python/py-symtab.c (salpy_str): Update.
10567         (struct salpy_sal_object) <symtab>: Now a PyObject.
10568         (salpy_dealloc): Update.
10569         (del_objfile_sal): Use gdbpy_ref.
10570
10571 2019-01-03  Tom Tromey  <tom@tromey.com>
10572
10573         * python/py-type.c (convert_field): Use new_reference.  Return
10574         gdbpy_ref.
10575         (make_fielditem): Return gdbpy_ref.
10576         (typy_fields): Update.
10577         (typy_getitem): Update.
10578         (field_name): Return gdbpy_ref.  Use new_reference.
10579         (typy_iterator_iternext): Update.
10580
10581 2019-01-03  Tom Tromey  <tom@tromey.com>
10582
10583         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10584
10585 2019-01-03  Tom Tromey  <tom@tromey.com>
10586
10587         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10588         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10589         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10590         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10591         (pspy_set_type_printers): Likewise.
10592         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10593         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10594         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10595         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10596         (objfpy_set_type_printers): Likewise.
10597
10598 2019-01-03  Tom Tromey  <tom@tromey.com>
10599
10600         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10601         (gdbpy_print_stack): Use gdbpy_err_fetch.
10602         * python/python-internal.h (class gdbpy_err_fetch): New class.
10603         (class gdbpy_enter) <m_error_type, m_error_value,
10604         m_error_traceback>: Remove.
10605         <m_error>: New member.
10606         (gdbpy_exception_to_string): Don't declare.
10607         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10608         * python/py-value.c (convert_value_from_python): Use
10609         gdbpy_err_fetch.
10610         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10611         gdbpy_exception_to_string.
10612         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10613         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10614         gdbpy_err_fetch.
10615
10616 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10617
10618         * linux-nat.c (delete_lwp_cleanup): Delete.
10619         (struct lwp_deleter): New struct.
10620         (lwp_info_up): New typedef.
10621         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10622         lwp_info_up.
10623
10624 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10625
10626         * linux-fork.c (class scoped_switch_fork_info): New class.
10627         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10628
10629 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10630
10631         * valops.c (find_overload_match): Remove use of null_cleanup, and
10632         calls to do_cleanups.
10633
10634 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10635
10636         * compile/compile-cplus-types.c
10637         (compile_cplus_instance::decl_name): Handle changes to
10638         cp_func_name.
10639         * cp-support.c (cp_func_name): Update header comment, update
10640         return type.
10641         * cp-support.h (cp_func_name): Update return type in declaration.
10642         * valops.c (find_overload_match): Move temp_func local to top
10643         level of function and change its type.  Use temp_func to hold and
10644         delete temporary string obtained from cp_func_name.
10645
10646 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10647
10648         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10649         gdb::char_vector, remove cleanup, and update uses of `msg`.
10650
10651 2019-01-03  Jim Wilson  <jimw@sifive.com>
10652
10653         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10654
10655 2019-01-02  Tom Tromey  <tom@tromey.com>
10656
10657         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10658         (tdesc_parse_xml): Remove cleanups.
10659         * target-descriptions.h (make_cleanup_free_target_description):
10660         Don't declare.
10661         (target_desc_deleter): New struct.
10662         (target_desc_up): New typedef.
10663         * target-descriptions.c (target_desc_deleter::operator()): Rename
10664         from free_target_description.
10665         (make_cleanup_free_target_description): Remove.
10666
10667 2019-01-02  Tom Tromey  <tom@tromey.com>
10668
10669         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10670         constructor, destructor.
10671         (linespec_parser): Remove typedef.
10672         (~linespec_parser): Rename from linespec_parser_delete.
10673         (linespec_lex_to_end, linespec_complete_label)
10674         (linespec_complete): Update.
10675         (decode_line_full): Remove cleanups.
10676         (decode_line_1): Update.
10677
10678 2019-01-02  Tom Tromey  <tom@tromey.com>
10679
10680         * python/python-internal.h (inferior_to_inferior_object): Change
10681         return type.
10682         * python/py-exitedevent.c (create_exited_event_object): Update.
10683         * python/py-inferior.c (inferior_to_inferior_object): Return
10684         gdbpy_ref.
10685         (python_new_inferior, python_inferior_deleted)
10686         (thread_to_thread_object, delete_thread_object)
10687         (build_inferior_list, gdbpy_selected_inferior): Update.
10688         * python/py-infthread.c (create_thread_object): Update.  Also fail
10689         if inferior_to_inferior_object fails.
10690
10691 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10692
10693         * inferior.h (class inferior) <displaced_step_state>: New field.
10694         * infrun.h (struct displaced_step_state): Move here from
10695         infrun.c.  Initialize fields, add constructor.
10696         <inf>: Remove field.
10697         <reset>: New method.
10698         * infrun.c (struct displaced_step_inferior_state): Move to
10699         infrun.h.
10700         (displaced_step_inferior_states): Remove.
10701         (get_displaced_stepping_state): Adust.
10702         (displaced_step_in_progress_any_inferior): Adjust.
10703         (displaced_step_in_progress_thread): Adjust.
10704         (displaced_step_in_progress): Adjust.
10705         (add_displaced_stepping_state): Remove.
10706         (get_displaced_step_closure_by_addr): Adjust.
10707         (remove_displaced_stepping_state): Remove.
10708         (infrun_inferior_exit): Call displaced_step_state.reset.
10709         (use_displaced_stepping): Don't check for NULL.
10710         (displaced_step_prepare_throw): Call
10711         get_displaced_stepping_state.
10712         (displaced_step_fixup): Don't check for NULL.
10713         (prepare_for_detach): Don't check for NULL.
10714
10715 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10716
10717         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10718          in case of call that did not complete.
10719
10720 2019-01-02  Andrey Utkin  <autkin@undo.io>
10721
10722         * symfile.c (find_separate_debug_file): Fix search of debug files for
10723         remote debuggee.
10724
10725 2019-01-02  Tom Tromey  <tom@tromey.com>
10726
10727         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10728         indentation.
10729         * python/py-frame.c (frapy_older): Remove cast.
10730         (frapy_newer): Likewise.
10731         * python/py-breakpoint.c (local_setattro): Remove cast.
10732         * python/py-arch.c (archpy_name): Remove local variable.
10733         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10734
10735 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10736
10737         * unittests/basic_string_view/element_access/char/empty.cc:
10738         Fix year range in copyright header.
10739
10740 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10741
10742         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10743         Delete.
10744         <operator==>: Update with for removed field.
10745         <hash>: Likewise.
10746         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10747         <isa_features>: ...this.
10748         <abi_features>: New field.
10749         (riscv_isa_flen): Update comment.
10750         (riscv_abi_xlen): New declaration.
10751         (riscv_abi_flen): New declaration.
10752         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10753         isa_features.
10754         (riscv_abi_xlen): New function.
10755         (riscv_isa_flen): Update to get answer from isa_features.
10756         (riscv_abi_flen): New function.
10757         (riscv_has_fp_abi): Update to get answer from abi_features.
10758         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10759         xlen and flen.
10760         (riscv_call_info) <xlen, flen>: Update comment.
10761         (riscv_call_arg_struct): Remove invalid assertions
10762         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10763         is removed.
10764         (riscv_gdbarch_init): Gather isa features and abi features
10765         separately, ensure both match on the gdbarch when reusing an old
10766         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10767         a target with 64-bit float hardware.
10768
10769 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10770
10771         * source.c (search_command_helper): Stop reverse search
10772         when line 1 has been searched.
10773
10774 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10775
10776         * record-full.c (record_full_base_target::close): Rewrite
10777         record_full_core_buf_list free logic.
10778
10779 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10780
10781         * break-catch-syscall.c (print_one_catch_syscall): xfree
10782         the last text.
10783
10784 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10785
10786         * top.c (print_gdb_version): Update Copyright year in version
10787         message.
10788
10789 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10790
10791         Update copyright year range in all GDB files.
10792
10793 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10794
10795         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10796
10797 For older changes see ChangeLog-2018.
10798 \f
10799 Local Variables:
10800 mode: change-log
10801 left-margin: 8
10802 fill-column: 74
10803 version-control: never
10804 coding: utf-8
10805 End:
10806