gdb/ChangeLog

   1 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
   2
   3         * python/py-inferior.c (infpy_thread_from_thread_handle):
   4         Adjust comments to reflect renaming of thread_from_thread_handle
   5         to thread_from_handle.  Adjust keywords.  Fix type error message.
   6         (inferior_object_methods): Add thread_from_handle.  Retain
   7         thread_from_thread_handle, but mark it as deprecated.
   8
   9 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
  10
  11         * gdbthread.h (find_thread_by_handle): Revise declaration.
  12         * thread.c (find_thread_by_handle): Likewise.  Adjust
  13         implementation too.
  14         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
  15         support for buffer objects as handles.
  16
  17 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
  18
  19         * python/py-infthread.c (thpy_thread_handle): New function.
  20         (thread_object_methods): Register thpy_thread_handle.
  21
  22 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
  23
  24         * gdbthread.h (thread_to_thread_handle): Declare.
  25         * thread.c (gdbtypes.h): Include.
  26         (thread_to_thread_handle): New function.
  27
  28         * target.h (struct target_ops): Add thread_info_to_thread_handle.
  29         (target_thread_info_to_thread_handle): Declare.
  30         * target.c (target_thread_info_to_thread_handle): New function.
  31         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
  32         * target-delegates.c: Regenerate.
  33
  34         * linux-thread-db.c (class thread_db_target): Add method
  35         thread_info_to_thread_handle.
  36         (thread_db_target::thread_info_to_thread_handle): Define.
  37         * remote.c (class remote_target): Add new method
  38         thread_info_to_thread_handle.
  39         (remote_target::thread_info_to_thread_handle): Define.
  40
  41 2019-04-08  Pedro Alves  <palves@redhat.com>
  42
  43         * common/common-exceptions.c (throw_exception): Don't create
  44         named object to throw; throw directly.
  45         (throw_it): Likewise.  Don't initialize gdb_exception::message
  46         here, with new; pass FMT and AP to the ctor instead.
  47         * common/common-exceptions.h: Include <string>.
  48         (gdb_exception::gdb_exception(enum return_reason, enum errors,
  49         const char *, va_list)): New ctor.  Use std::make_shared.
  50         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
  51         errors)): Delete.
  52         (gdb_exception_error::gdb_exception_error(enum errors, const char
  53         *, va_list)): New.
  54         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
  55         Add assertion.
  56         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
  57         errors)): Delete.
  58         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
  59         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
  60         Add assertion.
  61
  62 2019-04-08  Tom Tromey  <tom@tromey.com>
  63
  64         * valops.c (value_rtti_indirect_type): Replace throw_exception
  65         with throw.
  66         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
  67         with throw.
  68         * thread.c (thr_try_catch_cmd): Replace throw_exception with
  69         throw.
  70         * target.c (target_translate_tls_address): Replace throw_exception
  71         with throw.
  72         * stack.c (frame_apply_command_count): Replace throw_exception
  73         with throw.
  74         * solib-spu.c (append_ocl_sos): Replace throw_exception with
  75         throw.
  76         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
  77         with throw.
  78         * rs6000-tdep.c (rs6000_frame_cache)
  79         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
  80         * remote.c: Replace throw_exception with throw.
  81         * record-full.c (record_full_message, record_full_wait_1)
  82         (record_full_restore): Replace throw_exception with throw.
  83         * record-btrace.c:
  84         (get_thread_current_frame_id, record_btrace_start_replaying)
  85         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
  86         (cmd_record_btrace_start): Replace throw_exception with throw.
  87         * parse.c (parse_exp_in_context_1): Replace throw_exception with
  88         throw.
  89         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
  90         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
  91         * linespec.c:
  92         (find_linespec_symbols): Replace throw_exception with throw.
  93         * infrun.c (displaced_step_prepare, resume): Replace
  94         throw_exception with throw.
  95         * infcmd.c (post_create_inferior): Replace throw_exception with
  96         throw.
  97         * inf-loop.c (inferior_event_handler): Replace throw_exception
  98         with throw.
  99         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 100         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 101         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 102         (get_prev_frame_always, get_frame_pc_if_available)
 103         (get_frame_address_in_block_if_available, get_frame_language):
 104         Replace throw_exception with throw.
 105         * frame-unwind.c (frame_unwind_try_unwinder): Replace
 106         throw_exception with throw.
 107         * eval.c (fetch_subexp_value, evaluate_var_value)
 108         (evaluate_funcall, evaluate_subexp_standard): Replace
 109         throw_exception with throw.
 110         * dwarf2loc.c (call_site_find_chain)
 111         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
 112         Replace throw_exception with throw.
 113         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
 114         with throw.
 115         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 116         throw.
 117         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
 118         * completer.c (complete_line_internal): Replace throw_exception
 119         with throw.
 120         * compile/compile-object-run.c (compile_object_run): Replace
 121         throw_exception with throw.
 122         * cli/cli-script.c (process_next_line): Replace throw_exception
 123         with throw.
 124         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
 125         (btrace_enable, btrace_maint_update_pt_packets): Replace
 126         throw_exception with throw.
 127         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
 128         throw_exception with throw.
 129         * break-catch-throw.c (re_set_exception_catchpoint): Replace
 130         throw_exception with throw.
 131         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
 132         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
 133         * aarch64-tdep.c (aarch64_make_prologue_cache)
 134         (aarch64_make_stub_cache): Replace throw_exception with throw.
 135
 136 2019-04-08  Tom Tromey  <tom@tromey.com>
 137
 138         * common/common-exceptions.c (throw_exception): Rename from
 139         throw_exception_cxx.  Remove old copy.  Make argument const.
 140         (throw_it): Create and throw exception objects directly.
 141         * common/common-exceptions.h (throw_exception): Make argument
 142         const.
 143         (struct gdb_exception_error): Add constructor.
 144         (struct gdb_exception_quit): Add constructor.
 145
 146 2019-04-08  Tom Tromey  <tom@tromey.com>
 147
 148         * common/common-exceptions.h (exception_rethrow): Don't declare.
 149         (TRY_SJLJ): Update comment.
 150         (TRY, CATCH, END_CATCH): Remove.
 151         * common/common-exceptions.c (exception_rethrow): Remove.
 152
 153 2019-04-08  Tom Tromey  <tom@tromey.com>
 154
 155         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
 156         Remove.
 157         (gdb_exception_error): Rename from
 158         gdb_exception_RETURN_MASK_ERROR.
 159         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
 160         (gdb_quit_bad_alloc): Update.
 161         * aarch64-tdep.c: Update.
 162         * ada-lang.c: Update.
 163         * ada-typeprint.c: Update.
 164         * ada-valprint.c: Update.
 165         * amd64-tdep.c: Update.
 166         * arch-utils.c: Update.
 167         * break-catch-throw.c: Update.
 168         * breakpoint.c: Update.
 169         * btrace.c: Update.
 170         * c-varobj.c: Update.
 171         * cli/cli-cmds.c: Update.
 172         * cli/cli-interp.c: Update.
 173         * cli/cli-script.c: Update.
 174         * common/common-exceptions.c: Update.
 175         * common/new-op.c: Update.
 176         * common/selftest.c: Update.
 177         * compile/compile-c-symbols.c: Update.
 178         * compile/compile-cplus-symbols.c: Update.
 179         * compile/compile-object-load.c: Update.
 180         * compile/compile-object-run.c: Update.
 181         * completer.c: Update.
 182         * corelow.c: Update.
 183         * cp-abi.c: Update.
 184         * cp-support.c: Update.
 185         * cp-valprint.c: Update.
 186         * darwin-nat.c: Update.
 187         * disasm-selftests.c: Update.
 188         * dtrace-probe.c: Update.
 189         * dwarf-index-cache.c: Update.
 190         * dwarf-index-write.c: Update.
 191         * dwarf2-frame-tailcall.c: Update.
 192         * dwarf2-frame.c: Update.
 193         * dwarf2loc.c: Update.
 194         * dwarf2read.c: Update.
 195         * eval.c: Update.
 196         * event-loop.c: Update.
 197         * event-top.c: Update.
 198         * exec.c: Update.
 199         * f-valprint.c: Update.
 200         * fbsd-tdep.c: Update.
 201         * frame-unwind.c: Update.
 202         * frame.c: Update.
 203         * gdbtypes.c: Update.
 204         * gnu-v3-abi.c: Update.
 205         * guile/guile-internal.h: Update.
 206         * guile/scm-block.c: Update.
 207         * guile/scm-breakpoint.c: Update.
 208         * guile/scm-cmd.c: Update.
 209         * guile/scm-disasm.c: Update.
 210         * guile/scm-frame.c: Update.
 211         * guile/scm-lazy-string.c: Update.
 212         * guile/scm-math.c: Update.
 213         * guile/scm-param.c: Update.
 214         * guile/scm-ports.c: Update.
 215         * guile/scm-pretty-print.c: Update.
 216         * guile/scm-symbol.c: Update.
 217         * guile/scm-symtab.c: Update.
 218         * guile/scm-type.c: Update.
 219         * guile/scm-value.c: Update.
 220         * i386-linux-tdep.c: Update.
 221         * i386-tdep.c: Update.
 222         * inf-loop.c: Update.
 223         * infcall.c: Update.
 224         * infcmd.c: Update.
 225         * infrun.c: Update.
 226         * jit.c: Update.
 227         * language.c: Update.
 228         * linespec.c: Update.
 229         * linux-fork.c: Update.
 230         * linux-nat.c: Update.
 231         * linux-tdep.c: Update.
 232         * linux-thread-db.c: Update.
 233         * main.c: Update.
 234         * mi/mi-cmd-break.c: Update.
 235         * mi/mi-cmd-stack.c: Update.
 236         * mi/mi-interp.c: Update.
 237         * mi/mi-main.c: Update.
 238         * objc-lang.c: Update.
 239         * p-valprint.c: Update.
 240         * parse.c: Update.
 241         * ppc-linux-tdep.c: Update.
 242         * printcmd.c: Update.
 243         * python/py-arch.c: Update.
 244         * python/py-breakpoint.c: Update.
 245         * python/py-cmd.c: Update.
 246         * python/py-finishbreakpoint.c: Update.
 247         * python/py-frame.c: Update.
 248         * python/py-framefilter.c: Update.
 249         * python/py-gdb-readline.c: Update.
 250         * python/py-inferior.c: Update.
 251         * python/py-infthread.c: Update.
 252         * python/py-lazy-string.c: Update.
 253         * python/py-linetable.c: Update.
 254         * python/py-objfile.c: Update.
 255         * python/py-param.c: Update.
 256         * python/py-prettyprint.c: Update.
 257         * python/py-progspace.c: Update.
 258         * python/py-record-btrace.c: Update.
 259         * python/py-record.c: Update.
 260         * python/py-symbol.c: Update.
 261         * python/py-type.c: Update.
 262         * python/py-unwind.c: Update.
 263         * python/py-utils.c: Update.
 264         * python/py-value.c: Update.
 265         * python/python.c: Update.
 266         * record-btrace.c: Update.
 267         * record-full.c: Update.
 268         * remote-fileio.c: Update.
 269         * remote.c: Update.
 270         * riscv-tdep.c: Update.
 271         * rs6000-aix-tdep.c: Update.
 272         * rs6000-tdep.c: Update.
 273         * rust-exp.y: Update.
 274         * rust-lang.c: Update.
 275         * s390-tdep.c: Update.
 276         * selftest-arch.c: Update.
 277         * solib-dsbt.c: Update.
 278         * solib-frv.c: Update.
 279         * solib-spu.c: Update.
 280         * solib-svr4.c: Update.
 281         * solib.c: Update.
 282         * sparc64-linux-tdep.c: Update.
 283         * stack.c: Update.
 284         * symfile-mem.c: Update.
 285         * symmisc.c: Update.
 286         * target.c: Update.
 287         * thread.c: Update.
 288         * top.c: Update.
 289         * tracefile-tfile.c: Update.
 290         * tui/tui.c: Update.
 291         * typeprint.c: Update.
 292         * unittests/cli-utils-selftests.c: Update.
 293         * unittests/parse-connection-spec-selftests.c: Update.
 294         * valops.c: Update.
 295         * valprint.c: Update.
 296         * value.c: Update.
 297         * varobj.c: Update.
 298         * windows-nat.c: Update.
 299         * x86-linux-nat.c: Update.
 300         * xml-support.c: Update.
 301
 302 2019-04-08  Tom Tromey  <tom@tromey.com>
 303
 304         * xml-support.c: Use C++ exception handling.
 305         * x86-linux-nat.c: Use C++ exception handling.
 306         * windows-nat.c: Use C++ exception handling.
 307         * varobj.c: Use C++ exception handling.
 308         * value.c: Use C++ exception handling.
 309         * valprint.c: Use C++ exception handling.
 310         * valops.c: Use C++ exception handling.
 311         * unittests/parse-connection-spec-selftests.c: Use C++ exception
 312         handling.
 313         * unittests/cli-utils-selftests.c: Use C++ exception handling.
 314         * typeprint.c: Use C++ exception handling.
 315         * tui/tui.c: Use C++ exception handling.
 316         * tracefile-tfile.c: Use C++ exception handling.
 317         * top.c: Use C++ exception handling.
 318         * thread.c: Use C++ exception handling.
 319         * target.c: Use C++ exception handling.
 320         * symmisc.c: Use C++ exception handling.
 321         * symfile-mem.c: Use C++ exception handling.
 322         * stack.c: Use C++ exception handling.
 323         * sparc64-linux-tdep.c: Use C++ exception handling.
 324         * solib.c: Use C++ exception handling.
 325         * solib-svr4.c: Use C++ exception handling.
 326         * solib-spu.c: Use C++ exception handling.
 327         * solib-frv.c: Use C++ exception handling.
 328         * solib-dsbt.c: Use C++ exception handling.
 329         * selftest-arch.c: Use C++ exception handling.
 330         * s390-tdep.c: Use C++ exception handling.
 331         * rust-lang.c: Use C++ exception handling.
 332         * rust-exp.y: Use C++ exception handling.
 333         * rs6000-tdep.c: Use C++ exception handling.
 334         * rs6000-aix-tdep.c: Use C++ exception handling.
 335         * riscv-tdep.c: Use C++ exception handling.
 336         * remote.c: Use C++ exception handling.
 337         * remote-fileio.c: Use C++ exception handling.
 338         * record-full.c: Use C++ exception handling.
 339         * record-btrace.c: Use C++ exception handling.
 340         * python/python.c: Use C++ exception handling.
 341         * python/py-value.c: Use C++ exception handling.
 342         * python/py-utils.c: Use C++ exception handling.
 343         * python/py-unwind.c: Use C++ exception handling.
 344         * python/py-type.c: Use C++ exception handling.
 345         * python/py-symbol.c: Use C++ exception handling.
 346         * python/py-record.c: Use C++ exception handling.
 347         * python/py-record-btrace.c: Use C++ exception handling.
 348         * python/py-progspace.c: Use C++ exception handling.
 349         * python/py-prettyprint.c: Use C++ exception handling.
 350         * python/py-param.c: Use C++ exception handling.
 351         * python/py-objfile.c: Use C++ exception handling.
 352         * python/py-linetable.c: Use C++ exception handling.
 353         * python/py-lazy-string.c: Use C++ exception handling.
 354         * python/py-infthread.c: Use C++ exception handling.
 355         * python/py-inferior.c: Use C++ exception handling.
 356         * python/py-gdb-readline.c: Use C++ exception handling.
 357         * python/py-framefilter.c: Use C++ exception handling.
 358         * python/py-frame.c: Use C++ exception handling.
 359         * python/py-finishbreakpoint.c: Use C++ exception handling.
 360         * python/py-cmd.c: Use C++ exception handling.
 361         * python/py-breakpoint.c: Use C++ exception handling.
 362         * python/py-arch.c: Use C++ exception handling.
 363         * printcmd.c: Use C++ exception handling.
 364         * ppc-linux-tdep.c: Use C++ exception handling.
 365         * parse.c: Use C++ exception handling.
 366         * p-valprint.c: Use C++ exception handling.
 367         * objc-lang.c: Use C++ exception handling.
 368         * mi/mi-main.c: Use C++ exception handling.
 369         * mi/mi-interp.c: Use C++ exception handling.
 370         * mi/mi-cmd-stack.c: Use C++ exception handling.
 371         * mi/mi-cmd-break.c: Use C++ exception handling.
 372         * main.c: Use C++ exception handling.
 373         * linux-thread-db.c: Use C++ exception handling.
 374         * linux-tdep.c: Use C++ exception handling.
 375         * linux-nat.c: Use C++ exception handling.
 376         * linux-fork.c: Use C++ exception handling.
 377         * linespec.c: Use C++ exception handling.
 378         * language.c: Use C++ exception handling.
 379         * jit.c: Use C++ exception handling.
 380         * infrun.c: Use C++ exception handling.
 381         * infcmd.c: Use C++ exception handling.
 382         * infcall.c: Use C++ exception handling.
 383         * inf-loop.c: Use C++ exception handling.
 384         * i386-tdep.c: Use C++ exception handling.
 385         * i386-linux-tdep.c: Use C++ exception handling.
 386         * guile/scm-value.c: Use C++ exception handling.
 387         * guile/scm-type.c: Use C++ exception handling.
 388         * guile/scm-symtab.c: Use C++ exception handling.
 389         * guile/scm-symbol.c: Use C++ exception handling.
 390         * guile/scm-pretty-print.c: Use C++ exception handling.
 391         * guile/scm-ports.c: Use C++ exception handling.
 392         * guile/scm-param.c: Use C++ exception handling.
 393         * guile/scm-math.c: Use C++ exception handling.
 394         * guile/scm-lazy-string.c: Use C++ exception handling.
 395         * guile/scm-frame.c: Use C++ exception handling.
 396         * guile/scm-disasm.c: Use C++ exception handling.
 397         * guile/scm-cmd.c: Use C++ exception handling.
 398         * guile/scm-breakpoint.c: Use C++ exception handling.
 399         * guile/scm-block.c: Use C++ exception handling.
 400         * guile/guile-internal.h: Use C++ exception handling.
 401         * gnu-v3-abi.c: Use C++ exception handling.
 402         * gdbtypes.c: Use C++ exception handling.
 403         * frame.c: Use C++ exception handling.
 404         * frame-unwind.c: Use C++ exception handling.
 405         * fbsd-tdep.c: Use C++ exception handling.
 406         * f-valprint.c: Use C++ exception handling.
 407         * exec.c: Use C++ exception handling.
 408         * event-top.c: Use C++ exception handling.
 409         * event-loop.c: Use C++ exception handling.
 410         * eval.c: Use C++ exception handling.
 411         * dwarf2read.c: Use C++ exception handling.
 412         * dwarf2loc.c: Use C++ exception handling.
 413         * dwarf2-frame.c: Use C++ exception handling.
 414         * dwarf2-frame-tailcall.c: Use C++ exception handling.
 415         * dwarf-index-write.c: Use C++ exception handling.
 416         * dwarf-index-cache.c: Use C++ exception handling.
 417         * dtrace-probe.c: Use C++ exception handling.
 418         * disasm-selftests.c: Use C++ exception handling.
 419         * darwin-nat.c: Use C++ exception handling.
 420         * cp-valprint.c: Use C++ exception handling.
 421         * cp-support.c: Use C++ exception handling.
 422         * cp-abi.c: Use C++ exception handling.
 423         * corelow.c: Use C++ exception handling.
 424         * completer.c: Use C++ exception handling.
 425         * compile/compile-object-run.c: Use C++ exception handling.
 426         * compile/compile-object-load.c: Use C++ exception handling.
 427         * compile/compile-cplus-symbols.c: Use C++ exception handling.
 428         * compile/compile-c-symbols.c: Use C++ exception handling.
 429         * common/selftest.c: Use C++ exception handling.
 430         * common/new-op.c: Use C++ exception handling.
 431         * cli/cli-script.c: Use C++ exception handling.
 432         * cli/cli-interp.c: Use C++ exception handling.
 433         * cli/cli-cmds.c: Use C++ exception handling.
 434         * c-varobj.c: Use C++ exception handling.
 435         * btrace.c: Use C++ exception handling.
 436         * breakpoint.c: Use C++ exception handling.
 437         * break-catch-throw.c: Use C++ exception handling.
 438         * arch-utils.c: Use C++ exception handling.
 439         * amd64-tdep.c: Use C++ exception handling.
 440         * ada-valprint.c: Use C++ exception handling.
 441         * ada-typeprint.c: Use C++ exception handling.
 442         * ada-lang.c: Use C++ exception handling.
 443         * aarch64-tdep.c: Use C++ exception handling.
 444
 445 2019-04-08  Tom Tromey  <tom@tromey.com>
 446
 447         * xml-support.c (gdb_xml_parser::parse): Update.
 448         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 449         * value.c (show_convenience): Update.
 450         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
 451         (test_parse_flags_qcs): Update.
 452         * thread.c (thr_try_catch_cmd): Update.
 453         * target.c (target_translate_tls_address): Update.
 454         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 455         (info_frame_command_core, frame_apply_command_count): Update.
 456         * rust-exp.y (rust_lex_exception_test): Update.
 457         * riscv-tdep.c (riscv_print_one_register_info): Update.
 458         * remote.c (remote_target::enable_btrace): Update.
 459         * record-btrace.c (record_btrace_enable_warn): Update.
 460         * python/py-utils.c (gdbpy_convert_exception): Update.
 461         * printcmd.c (do_one_display, print_variable_and_value): Update.
 462         * mi/mi-main.c (mi_print_exception): Update.
 463         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
 464         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 465         * linux-nat.c (linux_nat_target::attach): Update.
 466         * linux-fork.c (class scoped_switch_fork_info): Update.
 467         * infrun.c (displaced_step_prepare): Update.
 468         * infcall.c (call_function_by_hand_dummy): Update.
 469         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
 470         * gnu-v3-abi.c (print_one_vtable): Update.
 471         * frame.c (get_prev_frame_always): Update.
 472         * f-valprint.c (info_common_command_for_block): Update.
 473         * exec.c (try_open_exec_file): Update.
 474         * exceptions.c (print_exception, exception_print)
 475         (exception_fprintf, exception_print_same): Update.
 476         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
 477         * dwarf-index-cache.c (index_cache::store)
 478         (index_cache::lookup_gdb_index): Update.
 479         * darwin-nat.c (maybe_cache_shell): Update.
 480         * cp-valprint.c (cp_print_value_fields): Update.
 481         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
 482         (gcc_cplus_symbol_address): Update.
 483         * compile/compile-c-symbols.c (gcc_convert_symbol)
 484         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
 485         * common/selftest.c: Update.
 486         * common/common-exceptions.h (struct gdb_exception) <message>: Now
 487         a std::string.
 488         (exception_try_scope_entry, exception_try_scope_exit): Don't
 489         declare.
 490         (struct exception_try_scope): Remove.
 491         (TRY): Don't use exception_try_scope.
 492         (struct gdb_exception): Add constructor, operator=.
 493         <what>: New method.
 494         (struct gdb_exception_RETURN_MASK_ALL)
 495         (struct gdb_exception_RETURN_MASK_ERROR)
 496         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
 497         (struct gdb_quit_bad_alloc): Update.
 498         * common/common-exceptions.c (exception_none): Change
 499         initializer.
 500         (struct catcher) <state, exception>: Initialize inline.
 501         <prev>: Remove member.
 502         (current_catcher): Remove.
 503         (catchers): New global.
 504         (exceptions_state_mc_init): Simplify.
 505         (catcher_pop): Remove.
 506         (exceptions_state_mc, exceptions_state_mc_catch): Update.
 507         (try_scope_depth, exception_try_scope_entry)
 508         (exception_try_scope_exit): Remove.
 509         (throw_exception_sjlj): Update.
 510         (exception_messages, exception_messages_size): Remove.
 511         (throw_it): Simplify.
 512         (gdb_exception_sliced_copy): Remove.
 513         (throw_exception_cxx): Update.
 514         * cli/cli-script.c (script_from_file): Update.
 515         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
 516         Update.
 517         * ada-valprint.c (ada_val_print): Update.
 518         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
 519         (create_excep_cond_exprs): Update.
 520
 521 2019-04-08  Tom Tromey  <tom@tromey.com>
 522
 523         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
 524         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
 525         (TRY, CATCH, END_CATCH): Remove some definitions.
 526         * common/common-exceptions.c: Don't use GDB_XCPT.
 527         (catcher_list_size): Remove.
 528         (throw_exception, throw_it): Simplify.
 529
 530 2019-04-05  Tom Tromey  <tom@tromey.com>
 531
 532         Revert the header-sorting patch.
 533         * ft32-tdep.c: Revert.
 534         * frv-tdep.c: Revert.
 535         * frv-linux-tdep.c: Revert.
 536         * frame.c: Revert.
 537         * frame-unwind.c: Revert.
 538         * frame-base.c: Revert.
 539         * fork-child.c: Revert.
 540         * findvar.c: Revert.
 541         * findcmd.c: Revert.
 542         * filesystem.c: Revert.
 543         * filename-seen-cache.h: Revert.
 544         * filename-seen-cache.c: Revert.
 545         * fbsd-tdep.c: Revert.
 546         * fbsd-nat.h: Revert.
 547         * fbsd-nat.c: Revert.
 548         * f-valprint.c: Revert.
 549         * f-typeprint.c: Revert.
 550         * f-lang.c: Revert.
 551         * extension.h: Revert.
 552         * extension.c: Revert.
 553         * extension-priv.h: Revert.
 554         * expprint.c: Revert.
 555         * exec.h: Revert.
 556         * exec.c: Revert.
 557         * exceptions.c: Revert.
 558         * event-top.c: Revert.
 559         * event-loop.c: Revert.
 560         * eval.c: Revert.
 561         * elfread.c: Revert.
 562         * dwarf2read.h: Revert.
 563         * dwarf2read.c: Revert.
 564         * dwarf2loc.c: Revert.
 565         * dwarf2expr.h: Revert.
 566         * dwarf2expr.c: Revert.
 567         * dwarf2-frame.c: Revert.
 568         * dwarf2-frame-tailcall.c: Revert.
 569         * dwarf-index-write.h: Revert.
 570         * dwarf-index-write.c: Revert.
 571         * dwarf-index-common.c: Revert.
 572         * dwarf-index-cache.h: Revert.
 573         * dwarf-index-cache.c: Revert.
 574         * dummy-frame.c: Revert.
 575         * dtrace-probe.c: Revert.
 576         * disasm.h: Revert.
 577         * disasm.c: Revert.
 578         * disasm-selftests.c: Revert.
 579         * dictionary.c: Revert.
 580         * dicos-tdep.c: Revert.
 581         * demangle.c: Revert.
 582         * dcache.h: Revert.
 583         * dcache.c: Revert.
 584         * darwin-nat.h: Revert.
 585         * darwin-nat.c: Revert.
 586         * darwin-nat-info.c: Revert.
 587         * d-valprint.c: Revert.
 588         * d-namespace.c: Revert.
 589         * d-lang.c: Revert.
 590         * ctf.c: Revert.
 591         * csky-tdep.c: Revert.
 592         * csky-linux-tdep.c: Revert.
 593         * cris-tdep.c: Revert.
 594         * cris-linux-tdep.c: Revert.
 595         * cp-valprint.c: Revert.
 596         * cp-support.c: Revert.
 597         * cp-namespace.c: Revert.
 598         * cp-abi.c: Revert.
 599         * corelow.c: Revert.
 600         * corefile.c: Revert.
 601         * continuations.c: Revert.
 602         * completer.h: Revert.
 603         * completer.c: Revert.
 604         * complaints.c: Revert.
 605         * coffread.c: Revert.
 606         * coff-pe-read.c: Revert.
 607         * cli-out.h: Revert.
 608         * cli-out.c: Revert.
 609         * charset.c: Revert.
 610         * c-varobj.c: Revert.
 611         * c-valprint.c: Revert.
 612         * c-typeprint.c: Revert.
 613         * c-lang.c: Revert.
 614         * buildsym.c: Revert.
 615         * buildsym-legacy.c: Revert.
 616         * build-id.h: Revert.
 617         * build-id.c: Revert.
 618         * btrace.c: Revert.
 619         * bsd-uthread.c: Revert.
 620         * breakpoint.h: Revert.
 621         * breakpoint.c: Revert.
 622         * break-catch-throw.c: Revert.
 623         * break-catch-syscall.c: Revert.
 624         * break-catch-sig.c: Revert.
 625         * blockframe.c: Revert.
 626         * block.c: Revert.
 627         * bfin-tdep.c: Revert.
 628         * bfin-linux-tdep.c: Revert.
 629         * bfd-target.c: Revert.
 630         * bcache.c: Revert.
 631         * ax-general.c: Revert.
 632         * ax-gdb.h: Revert.
 633         * ax-gdb.c: Revert.
 634         * avr-tdep.c: Revert.
 635         * auxv.c: Revert.
 636         * auto-load.c: Revert.
 637         * arm-wince-tdep.c: Revert.
 638         * arm-tdep.c: Revert.
 639         * arm-symbian-tdep.c: Revert.
 640         * arm-pikeos-tdep.c: Revert.
 641         * arm-obsd-tdep.c: Revert.
 642         * arm-nbsd-tdep.c: Revert.
 643         * arm-nbsd-nat.c: Revert.
 644         * arm-linux-tdep.c: Revert.
 645         * arm-linux-nat.c: Revert.
 646         * arm-fbsd-tdep.c: Revert.
 647         * arm-fbsd-nat.c: Revert.
 648         * arm-bsd-tdep.c: Revert.
 649         * arch-utils.c: Revert.
 650         * arc-tdep.c: Revert.
 651         * arc-newlib-tdep.c: Revert.
 652         * annotate.h: Revert.
 653         * annotate.c: Revert.
 654         * amd64-windows-tdep.c: Revert.
 655         * amd64-windows-nat.c: Revert.
 656         * amd64-tdep.c: Revert.
 657         * amd64-sol2-tdep.c: Revert.
 658         * amd64-obsd-tdep.c: Revert.
 659         * amd64-obsd-nat.c: Revert.
 660         * amd64-nbsd-tdep.c: Revert.
 661         * amd64-nbsd-nat.c: Revert.
 662         * amd64-nat.c: Revert.
 663         * amd64-linux-tdep.c: Revert.
 664         * amd64-linux-nat.c: Revert.
 665         * amd64-fbsd-tdep.c: Revert.
 666         * amd64-fbsd-nat.c: Revert.
 667         * amd64-dicos-tdep.c: Revert.
 668         * amd64-darwin-tdep.c: Revert.
 669         * amd64-bsd-nat.c: Revert.
 670         * alpha-tdep.c: Revert.
 671         * alpha-obsd-tdep.c: Revert.
 672         * alpha-nbsd-tdep.c: Revert.
 673         * alpha-mdebug-tdep.c: Revert.
 674         * alpha-linux-tdep.c: Revert.
 675         * alpha-linux-nat.c: Revert.
 676         * alpha-bsd-tdep.c: Revert.
 677         * alpha-bsd-nat.c: Revert.
 678         * aix-thread.c: Revert.
 679         * agent.c: Revert.
 680         * addrmap.c: Revert.
 681         * ada-varobj.c: Revert.
 682         * ada-valprint.c: Revert.
 683         * ada-typeprint.c: Revert.
 684         * ada-tasks.c: Revert.
 685         * ada-lang.c: Revert.
 686         * aarch64-tdep.c: Revert.
 687         * aarch64-ravenscar-thread.c: Revert.
 688         * aarch64-newlib-tdep.c: Revert.
 689         * aarch64-linux-tdep.c: Revert.
 690         * aarch64-linux-nat.c: Revert.
 691         * aarch64-fbsd-tdep.c: Revert.
 692         * aarch64-fbsd-nat.c: Revert.
 693         * aarch32-linux-nat.c: Revert.
 694
 695 2019-04-05  Tom Tromey  <tom@tromey.com>
 696
 697         * ft32-tdep.c: Sort headers.
 698         * frv-tdep.c: Sort headers.
 699         * frv-linux-tdep.c: Sort headers.
 700         * frame.c: Sort headers.
 701         * frame-unwind.c: Sort headers.
 702         * frame-base.c: Sort headers.
 703         * fork-child.c: Sort headers.
 704         * findvar.c: Sort headers.
 705         * findcmd.c: Sort headers.
 706         * filesystem.c: Sort headers.
 707         * filename-seen-cache.h: Sort headers.
 708         * filename-seen-cache.c: Sort headers.
 709         * fbsd-tdep.c: Sort headers.
 710         * fbsd-nat.h: Sort headers.
 711         * fbsd-nat.c: Sort headers.
 712         * f-valprint.c: Sort headers.
 713         * f-typeprint.c: Sort headers.
 714         * f-lang.c: Sort headers.
 715         * extension.h: Sort headers.
 716         * extension.c: Sort headers.
 717         * extension-priv.h: Sort headers.
 718         * expprint.c: Sort headers.
 719         * exec.h: Sort headers.
 720         * exec.c: Sort headers.
 721         * exceptions.c: Sort headers.
 722         * event-top.c: Sort headers.
 723         * event-loop.c: Sort headers.
 724         * eval.c: Sort headers.
 725         * elfread.c: Sort headers.
 726         * dwarf2read.h: Sort headers.
 727         * dwarf2read.c: Sort headers.
 728         * dwarf2loc.c: Sort headers.
 729         * dwarf2expr.h: Sort headers.
 730         * dwarf2expr.c: Sort headers.
 731         * dwarf2-frame.c: Sort headers.
 732         * dwarf2-frame-tailcall.c: Sort headers.
 733         * dwarf-index-write.h: Sort headers.
 734         * dwarf-index-write.c: Sort headers.
 735         * dwarf-index-common.c: Sort headers.
 736         * dwarf-index-cache.h: Sort headers.
 737         * dwarf-index-cache.c: Sort headers.
 738         * dummy-frame.c: Sort headers.
 739         * dtrace-probe.c: Sort headers.
 740         * disasm.h: Sort headers.
 741         * disasm.c: Sort headers.
 742         * disasm-selftests.c: Sort headers.
 743         * dictionary.c: Sort headers.
 744         * dicos-tdep.c: Sort headers.
 745         * demangle.c: Sort headers.
 746         * dcache.h: Sort headers.
 747         * dcache.c: Sort headers.
 748         * darwin-nat.h: Sort headers.
 749         * darwin-nat.c: Sort headers.
 750         * darwin-nat-info.c: Sort headers.
 751         * d-valprint.c: Sort headers.
 752         * d-namespace.c: Sort headers.
 753         * d-lang.c: Sort headers.
 754         * ctf.c: Sort headers.
 755         * csky-tdep.c: Sort headers.
 756         * csky-linux-tdep.c: Sort headers.
 757         * cris-tdep.c: Sort headers.
 758         * cris-linux-tdep.c: Sort headers.
 759         * cp-valprint.c: Sort headers.
 760         * cp-support.c: Sort headers.
 761         * cp-namespace.c: Sort headers.
 762         * cp-abi.c: Sort headers.
 763         * corelow.c: Sort headers.
 764         * corefile.c: Sort headers.
 765         * continuations.c: Sort headers.
 766         * completer.h: Sort headers.
 767         * completer.c: Sort headers.
 768         * complaints.c: Sort headers.
 769         * coffread.c: Sort headers.
 770         * coff-pe-read.c: Sort headers.
 771         * cli-out.h: Sort headers.
 772         * cli-out.c: Sort headers.
 773         * charset.c: Sort headers.
 774         * c-varobj.c: Sort headers.
 775         * c-valprint.c: Sort headers.
 776         * c-typeprint.c: Sort headers.
 777         * c-lang.c: Sort headers.
 778         * buildsym.c: Sort headers.
 779         * buildsym-legacy.c: Sort headers.
 780         * build-id.h: Sort headers.
 781         * build-id.c: Sort headers.
 782         * btrace.c: Sort headers.
 783         * bsd-uthread.c: Sort headers.
 784         * breakpoint.h: Sort headers.
 785         * breakpoint.c: Sort headers.
 786         * break-catch-throw.c: Sort headers.
 787         * break-catch-syscall.c: Sort headers.
 788         * break-catch-sig.c: Sort headers.
 789         * blockframe.c: Sort headers.
 790         * block.c: Sort headers.
 791         * bfin-tdep.c: Sort headers.
 792         * bfin-linux-tdep.c: Sort headers.
 793         * bfd-target.c: Sort headers.
 794         * bcache.c: Sort headers.
 795         * ax-general.c: Sort headers.
 796         * ax-gdb.h: Sort headers.
 797         * ax-gdb.c: Sort headers.
 798         * avr-tdep.c: Sort headers.
 799         * auxv.c: Sort headers.
 800         * auto-load.c: Sort headers.
 801         * arm-wince-tdep.c: Sort headers.
 802         * arm-tdep.c: Sort headers.
 803         * arm-symbian-tdep.c: Sort headers.
 804         * arm-pikeos-tdep.c: Sort headers.
 805         * arm-obsd-tdep.c: Sort headers.
 806         * arm-nbsd-tdep.c: Sort headers.
 807         * arm-nbsd-nat.c: Sort headers.
 808         * arm-linux-tdep.c: Sort headers.
 809         * arm-linux-nat.c: Sort headers.
 810         * arm-fbsd-tdep.c: Sort headers.
 811         * arm-fbsd-nat.c: Sort headers.
 812         * arm-bsd-tdep.c: Sort headers.
 813         * arch-utils.c: Sort headers.
 814         * arc-tdep.c: Sort headers.
 815         * arc-newlib-tdep.c: Sort headers.
 816         * annotate.h: Sort headers.
 817         * annotate.c: Sort headers.
 818         * amd64-windows-tdep.c: Sort headers.
 819         * amd64-windows-nat.c: Sort headers.
 820         * amd64-tdep.c: Sort headers.
 821         * amd64-sol2-tdep.c: Sort headers.
 822         * amd64-obsd-tdep.c: Sort headers.
 823         * amd64-obsd-nat.c: Sort headers.
 824         * amd64-nbsd-tdep.c: Sort headers.
 825         * amd64-nbsd-nat.c: Sort headers.
 826         * amd64-nat.c: Sort headers.
 827         * amd64-linux-tdep.c: Sort headers.
 828         * amd64-linux-nat.c: Sort headers.
 829         * amd64-fbsd-tdep.c: Sort headers.
 830         * amd64-fbsd-nat.c: Sort headers.
 831         * amd64-dicos-tdep.c: Sort headers.
 832         * amd64-darwin-tdep.c: Sort headers.
 833         * amd64-bsd-nat.c: Sort headers.
 834         * alpha-tdep.c: Sort headers.
 835         * alpha-obsd-tdep.c: Sort headers.
 836         * alpha-nbsd-tdep.c: Sort headers.
 837         * alpha-mdebug-tdep.c: Sort headers.
 838         * alpha-linux-tdep.c: Sort headers.
 839         * alpha-linux-nat.c: Sort headers.
 840         * alpha-bsd-tdep.c: Sort headers.
 841         * alpha-bsd-nat.c: Sort headers.
 842         * aix-thread.c: Sort headers.
 843         * agent.c: Sort headers.
 844         * addrmap.c: Sort headers.
 845         * ada-varobj.c: Sort headers.
 846         * ada-valprint.c: Sort headers.
 847         * ada-typeprint.c: Sort headers.
 848         * ada-tasks.c: Sort headers.
 849         * ada-lang.c: Sort headers.
 850         * aarch64-tdep.c: Sort headers.
 851         * aarch64-ravenscar-thread.c: Sort headers.
 852         * aarch64-newlib-tdep.c: Sort headers.
 853         * aarch64-linux-tdep.c: Sort headers.
 854         * aarch64-linux-nat.c: Sort headers.
 855         * aarch64-fbsd-tdep.c: Sort headers.
 856         * aarch64-fbsd-nat.c: Sort headers.
 857         * aarch32-linux-nat.c: Sort headers.
 858
 859 2019-04-04  Tom Tromey  <tom@tromey.com>
 860
 861         * varobj.c (varobj_create): Update.
 862         * rust-exp.y (struct rust_parser) <update_innermost_block,
 863         lookup_symbol>: New methods.
 864         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
 865         Rename.
 866         (rust_parser::rust_lookup_type)
 867         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 868         * printcmd.c (display_command, do_one_display): Update.
 869         * parser-defs.h (struct parser_state) <parser_state>: Add
 870         "tracker" parameter.
 871         (block_tracker): New member.
 872         (class innermost_block_tracker) <innermost_block_tracker>: Add
 873         "types" parameter.
 874         <reset>: Remove method.
 875         (innermost_block): Don't declare.
 876         (null_post_parser): Update.
 877         * parse.c (innermost_block): Remove global.
 878         (write_dollar_variable): Update.
 879         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
 880         Remove "tracker_types" parameter.
 881         (parse_expression): Add "tracker" parameter.
 882         (parse_expression_for_completion): Update.
 883         (null_post_parser): Add "tracker" parameter.
 884         * p-exp.y: Update rules.
 885         * m2-exp.y: Update rules.
 886         * language.h (struct language_defn) <la_post_parser>: Add
 887         "tracker" parameter.
 888         * go-exp.y: Update rules.
 889         * f-exp.y: Update rules.
 890         * expression.h (parse_expression, parse_exp_1): Add "tracker"
 891         parameter.
 892         * d-exp.y: Update rules.
 893         * c-exp.y: Update rules.
 894         * breakpoint.c (set_breakpoint_condition): Create an
 895         innermost_block_tracker.
 896         (watch_command_1): Likewise.
 897         * ada-lang.c (resolve): Add "tracker" parameter.
 898         (resolve_subexp): Likewise.
 899         * ada-exp.y (write_var_from_sym): Update.
 900
 901 2019-04-04  Tom Tromey  <tom@tromey.com>
 902
 903         * type-stack.h: New file.
 904         * type-stack.c: New file.
 905         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
 906         type-stack.h.
 907         (insert_into_type_stack, insert_type, push_type, push_type_int)
 908         (insert_type_address_space, pop_type, pop_type_int)
 909         (pop_typelist, pop_type_stack, append_type_stack)
 910         (push_type_stack, get_type_stack, push_typelist)
 911         (follow_type_instance_flags, follow_types): Don't declare.
 912         * parse.c (type_stack): Remove global.
 913         (parse_exp_in_context): Update.
 914         (insert_into_type_stack, insert_type, push_type, push_type_int)
 915         (insert_type_address_space, pop_type, pop_type_int)
 916         (pop_typelist, pop_type_stack, append_type_stack)
 917         (push_type_stack, get_type_stack, push_typelist)
 918         (follow_type_instance_flags, follow_types): Remove (moved to
 919         type-stack.c).
 920         * f-exp.y (type_stack): New global.
 921         Update rules.
 922         (push_kind_type, f_parse): Update.
 923         * d-exp.y (type_stack): New global.
 924         Update rules.
 925         (d_parse): Update.
 926         * c-exp.y (struct c_parse_state) <type_stack>: New member.
 927         Update rules.
 928         * Makefile.in (COMMON_SFILES): Add type-stack.c.
 929         (HFILES_NO_SRCDIR): Add type-stack.h.
 930
 931 2019-04-04  Tom Tromey  <tom@tromey.com>
 932
 933         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
 934         (rust_parser::convert_ast_to_expression, rust_parse)
 935         (rust_lex_test_completion, rust_lex_tests): Update.
 936         * parser-defs.h (struct expr_completion_state): New.
 937         (struct parser_state) <parser_state>: Add completion parameter.
 938         <mark_struct_expression, mark_completion_tag>: New methods.
 939         <parse_completion, m_completion_state>: New members.
 940         (prefixify_expression, null_post_parser): Update.
 941         (mark_struct_expression, mark_completion_tag): Don't declare.
 942         * parse.c (parse_completion, expout_last_struct)
 943         (expout_tag_completion_type, expout_completion_name): Remove
 944         globals.
 945         (parser_state::mark_struct_expression)
 946         (parser_state::mark_completion_tag): Now methods.
 947         (prefixify_expression): Add last_struct parameter.
 948         (prefixify_subexp): Likewise.
 949         (parse_exp_1): Update.
 950         (parse_exp_in_context): Add cstate parameter.  Update.
 951         (parse_expression_for_completion): Create an
 952         expr_completion_state.
 953         (null_post_parser): Add "completion" parameter.
 954         * p-exp.y: Update rules.
 955         (yylex): Update.
 956         * language.h (struct language_defn) <la_post_parser>: Add
 957         "completing" parameter.
 958         * go-exp.y: Update rules.
 959         (lex_one_token): Update.
 960         * expression.h (parse_completion): Don't declare.
 961         * d-exp.y: Update rules.
 962         (lex_one_token): Update rules.
 963         * c-exp.y: Update rules.
 964         (lex_one_token): Update.
 965         * ada-lang.c (resolve): Add "parse_completion" parameter.
 966         (resolve_subexp): Likewise.
 967         (ada_resolve_function): Likewise.
 968
 969 2019-04-04  Tom Tromey  <tom@tromey.com>
 970
 971         * parser-defs.h (struct parser_state) <start_arglist,
 972         end_arglist>: New methods.
 973         <arglist_len, m_funcall_chain>: New members.
 974         (arglist_len, start_arglist, end_arglist): Don't declare.
 975         * parse.c (arglist_len, funcall_chain): Remove global.
 976         (start_arglist, end_arglist): Remove functions.
 977         (parse_exp_in_context): Update.
 978         * p-exp.y: Update rules.
 979         * m2-exp.y: Update rules.
 980         * go-exp.y: Update rules.
 981         * f-exp.y: Update rules.
 982         * d-exp.y: Update rules.
 983         * c-exp.y: Update rules.
 984
 985 2019-04-04  Tom Tromey  <tom@tromey.com>
 986
 987         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
 988         lex_operator, push_back>: New methods.
 989         Update all rules.
 990         (rust_parser::lex_hex, lex_escape): Rename and update.
 991         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
 992         (rust_parser::lex_operator): Rename and update.
 993         (rust_parser::lex_number, rustyylex, rustyyerror)
 994         (rust_lex_test_init, rust_lex_test_sequence)
 995         (rust_lex_test_push_back, rust_lex_tests): Update.
 996         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
 997         parameter.
 998         <lexptr, prev_lexptr>: New members.
 999         (lexptr, prev_lexptr): Don't declare.
1000         * parse.c (lexptr, prev_lexptr): Remove globals.
1001         (parse_exp_in_context): Update.
1002         * p-exp.y (yylex, yyerror): Update.
1003         * m2-exp.y (parse_number, yylex, yyerror): Update.
1004         * go-exp.y (lex_one_token, yyerror): Update.
1005         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1006         * d-exp.y (lex_one_token, yyerror): Update.
1007         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1008         (lex_one_token, yyerror): Update.
1009         * ada-lex.l (YY_INPUT): Update.
1010         (rewind_to_char): Update.
1011         * ada-exp.y (yyerror): Update.
1012
1013 2019-04-04  Tom Tromey  <tom@tromey.com>
1014
1015         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1016         * parser-defs.h (struct parser_state) <parser_state>: Add new
1017         parameter.
1018         <comma_terminates>: New member.
1019         (comma_terminates): Don't declare global.
1020         * parse.c (comma_terminates): Remove global.
1021         (parse_exp_in_context): Update.
1022         * p-exp.y (yylex): Update.
1023         * m2-exp.y (yylex): Update.
1024         * go-exp.y (lex_one_token): Update.
1025         * f-exp.y (yylex): Update.
1026         * d-exp.y (lex_one_token): Update.
1027         * c-exp.y (lex_one_token): Update.
1028         * ada-lex.l: Update.
1029
1030 2019-04-04  Tom Tromey  <tom@tromey.com>
1031
1032         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1033         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1034         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1035         * parser-defs.h (paren_depth): Don't declare.
1036         * parse.c (paren_depth): Remove global.
1037         (parse_exp_in_context): Update.
1038         * p-exp.y (paren_depth): New global.
1039         (pascal_parse): Initialize it.
1040         * m2-exp.y (paren_depth): New global.
1041         (m2_parse): Initialize it.
1042         * go-exp.y (paren_depth): New global.
1043         (go_parse): Initialize it.
1044         * f-exp.y (paren_depth): New global.
1045         (f_parse): Initialize it.
1046         * d-exp.y (paren_depth): New global.
1047         (d_parse): Initialize it.
1048         * c-exp.y (paren_depth): New global.
1049         (c_parse): Initialize it.
1050         * ada-lex.l (paren_depth): New global.
1051         (lexer_init): Initialize it.
1052
1053 2019-04-04  Tom Tromey  <tom@tromey.com>
1054
1055         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1056         (rust_parser::convert_ast_to_type)
1057         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1058         * parser-defs.h (struct parser_state) <parser_state>: Add
1059         parameters.  Initialize new members.
1060         <expression_context_block, expression_context_pc>: New members.
1061         * parse.c (expression_context_block, expression_context_pc):
1062         Remove globals.
1063         (parse_exp_in_context): Update.
1064         * p-exp.y: Update all rules.
1065         (yylex): Update.
1066         * m2-exp.y: Update all rules.
1067         (yylex): Update.
1068         * go-exp.y (yylex): Update.
1069         * f-exp.y (yylex): Update.
1070         * d-exp.y: Update all rules.
1071         (yylex): Update.
1072         * c-exp.y: Update all rules.
1073         (lex_one_token, classify_name, yylex, c_parse): Update.
1074         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1075
1076 2019-04-04  Tom Tromey  <tom@tromey.com>
1077
1078         * gdbarch.h, gdbarch.c: Rebuild.
1079         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1080         * stap-probe.h:
1081         (struct stap_parse_info): Replace "parser_state" with
1082         "expr_builder".
1083         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1084         (parser_state): New class.
1085         * parse.c (expr_builder): Rename.
1086         (expr_builder::release): Rename.
1087         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1088         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1089         (write_exp_elt_longcst, write_exp_elt_floatcst)
1090         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1091         (write_exp_string_vector, write_exp_bitstring)
1092         (write_exp_msymbol, mark_struct_expression)
1093         (write_dollar_variable)
1094         (insert_type_address_space, increase_expout_size): Replace
1095         "parser_state" with "expr_builder".
1096         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1097         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1098         "parser_state" with "expr_builder".
1099
1100 2019-04-04  Tom Tromey  <tom@tromey.com>
1101
1102         * rust-exp.y: Replace "parse_language" with method call.
1103         * p-exp.y:
1104         (yylex): Replace "parse_language" with method call.
1105         * m2-exp.y:
1106         (yylex): Replace "parse_language" with method call.
1107         * go-exp.y (classify_name): Replace "parse_language" with method
1108         call.
1109         * f-exp.y (yylex): Replace "parse_language" with method call.
1110         * d-exp.y (lex_one_token): Replace "parse_language" with method
1111         call.
1112         * c-exp.y:
1113         (lex_one_token, classify_name, yylex): Replace "parse_language"
1114         with method call.
1115         * ada-exp.y (find_primitive_type, type_char)
1116         (type_system_address): Replace "parse_language" with method call.
1117
1118 2019-04-04  Tom Tromey  <tom@tromey.com>
1119
1120         * rust-exp.y: Replace "parse_gdbarch" with method call.
1121         * parse.c (write_dollar_variable, insert_type_address_space):
1122         Replace "parse_gdbarch" with method call.
1123         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1124         call.
1125         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1126         call.
1127         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1128         "parse_gdbarch" with method call.
1129         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1130         with method call.
1131         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1132         "parse_gdbarch" with method call.
1133         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1134         "parse_gdbarch" with method call.
1135         * c-exp.y (parse_type, parse_number, classify_name): Replace
1136         "parse_gdbarch" with method call.
1137         * ada-lex.l: Replace "parse_gdbarch" with method call.
1138         * ada-exp.y (parse_type, find_primitive_type, type_char)
1139         (type_system_address): Replace "parse_gdbarch" with method call.
1140
1141 2019-04-04  Tom Tromey  <tom@tromey.com>
1142
1143         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1144         * stap-probe.c (stap_parse_argument): Update.
1145         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1146         initial_size parameter.
1147         * rust-exp.y (rust_lex_tests): Update.
1148         * parse.c (parser_state): Update.
1149         (parse_exp_in_context): Update.
1150         * parser-defs.h (struct parser_state) <parser_state>: Remove
1151         "initial_size" parameter.
1152
1153 2019-04-04  Tom Tromey  <tom@tromey.com>
1154
1155         * parser-defs.h (increase_expout_size): Don't declare.
1156         * parse.c (increase_expout_size): Now static.
1157
1158 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1159
1160         * gnu-nat.c (gnu_nat_target::wait): Fix
1161         target_waitstatus_to_string call.
1162
1163 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1164
1165         * eval.c (evaluate_subexp_standard): Handle internal functions
1166         during Fortran function call handling.
1167
1168 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1169
1170         * NEWS: Mention new internal functions.
1171         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1172         (read_base_type): Use dwarf2_init_complex_target_type.
1173         * value.c (creal_internal_fn): New function.
1174         (cimag_internal_fn): New function.
1175         (_initialize_values): Register new internal functions.
1176
1177 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1178
1179         * infrun.c (stop_all_threads): If debug_infrun, always
1180         trace the wait status after wait_one, using
1181         target_waitstatus_to_string and target_pid_to_str.
1182         (handle_inferior_event): Replace various trace of
1183         wait status kind by a single trace.
1184         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1185         wait status kind image by target_waitstatus_to_string.
1186         * target/waitstatus.c (target_waitstatus_to_string): Fix
1187         obsolete comment.
1188
1189 2019-04-01  Tom Tromey  <tromey@adacore.com>
1190
1191         PR symtab/23331:
1192         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1193
1194 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1195             Pedro Alves  <palves@redhat.com>
1196
1197         * top.c (quit_force): Call 'finalize_values'.
1198         * value.c (finalize_values): New function.
1199         * value.h (finalize_values): Declare.
1200
1201 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1202
1203         * NEWS: Announce $_gdb_major and $_gdb_minor.
1204
1205         * top.c (init_gdb_version_vars): New function.
1206         (gdb_init): Call init_gdb_version_vars.
1207
1208 2019-03-29  Tom Tromey  <tromey@adacore.com>
1209
1210         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1211         help text.  Remove dead code.
1212
1213 2019-03-29  Keith Seitz  <keiths@redhat.com>
1214
1215         From Siddhesh Poyarekar:
1216         * f-lang.h (f77_get_upperbound): Return LONGEST.
1217         (f77_get_lowerbound): Likewise.
1218         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1219         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1220         print them.
1221         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1222         plongest to format print it.
1223         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1224         (f77_get_upperbound): Likewise.
1225         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1226         LOWER_BOUND to LONGEST.
1227         (f77_create_arrayprint_offset_tbl): Likewise.
1228
1229 2019-03-29  Keith Seitz  <keiths@redhat.com>
1230
1231         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1232         %s/pulongest for TYPE_LENGTH instead of %d in format
1233         strings.
1234         * ada-typerint.c (ada_print_type): Likewise.
1235         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1236         * compile/compile-c-support.c (generate_register_struct): Likewise.
1237         * gdbtypes.c (recursive_dump_type): Likewise.
1238         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1239         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1240         instead of %d in format strings.
1241         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1242         to std::min to ULONGEST.
1243         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1244         instead of %d in format strings.
1245         * tracepoint.c (info_scope_command): Likewise.
1246         * typeprint.c (print_offset_data::update)
1247         (print_offset_data::finish): Likewise.
1248         * xtensa-tdep.c (xtensa_store_return_value)
1249         (xtensa_push_dummy_call): Likewise.
1250
1251 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1252
1253         * windows-nat.c (display_selector): Fixed format specifications
1254         for 64-bit Cygwin.
1255
1256 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1257
1258         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1259
1260 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1261
1262         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1263         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1264         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1265         (nios2_linux_init_abi): Install it.
1266
1267 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1268
1269         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1270
1271 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1272
1273         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1274
1275 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1276             Tom Tromey  <tromey@adacore.com>
1277
1278         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1279
1280 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1281
1282         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1283         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1284         method to compute the bounds of range types. Also print "[evaluated]"
1285         if the bounds' values come from a dynamic evaluation.
1286
1287 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1290         whitespace when pretty printing is on.
1291
1292 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1293
1294         * ppc-linux-nat.c: Add include.
1295
1296 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1297
1298         * NEWS: Mention AArch64 Pointer Authentication.
1299
1300 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1301
1302         * arm-linux-nat.c: Add include.
1303
1304 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1305
1306         * source-cache.c (source_cache::get_source_lines): Re-read
1307         fullname after calling open_source_file.
1308
1309 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1310
1311         * NEWS: Mention TLS support for FreeBSD.
1312
1313 2019-03-25  Tom Tromey  <tromey@adacore.com>
1314
1315         * minsyms.c (BUNCH_SIZE): Update comment.
1316         (~minimal_symbol_reader): Remove old comment.
1317         (compact_minimal_symbols): Update comment.
1318         (minimal_symbol_reader::install): Remove old comment.  Update
1319         other comments.
1320
1321 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1322
1323         * s390-linux-nat.c: Add include.
1324
1325 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1326
1327         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1328         Call linux_get_hwcap.
1329         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1330         Likewise.
1331         (aarch64_linux_get_hwcap): Remove function.
1332         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1333         declaration.
1334         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1335         linux_get_hwcap.
1336         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1337         * linux-tdep.c (linux_get_hwcap): Add function.
1338         (linux_get_hwcap2): Likewise.
1339         * linux-tdep.h (linux_get_hwcap): Add declaration.
1340         (linux_get_hwcap2): Likewise.
1341         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1342         (ppc_linux_get_hwcap2): Likewise.
1343         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1344         linux_get_hwcap.
1345         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1346         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1347         (ppc_linux_nat_target::read_description): Likewise.
1348         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1349         * s390-linux-nat.c: Likewise.
1350         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1351
1352 2019-03-24  Tom Tromey  <tom@tromey.com>
1353
1354         * ada-lang.c (standard_lookup): Simplify initialization.
1355         (ada_lookup_symbol_nonlocal): Simplify return.
1356         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1357         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1358         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1359         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1360         initialization.
1361         * solib.c (solib_global_lookup): Simplify.
1362         * symtab.c (null_block_symbol): Remove.
1363         (symbol_cache_lookup): Simplify returns.
1364         (lookup_language_this): Simplify returns.
1365         (lookup_symbol_aux): Simplify return.
1366         (lookup_local_symbol): Simplify returns.
1367         (lookup_global_symbol_from_objfile): Simplify return.
1368         (lookup_symbol_in_objfile_symtabs)
1369         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1370         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1371         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1372         * cp-namespace.c (cp_lookup_bare_symbol)
1373         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1374         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1375         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1376         (cp_lookup_symbol_via_imports): Simplify initialization.
1377         (find_symbol_in_baseclass): Likewise.
1378         * symtab.h (null_block_symbol): Remove.
1379         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1380         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1381         (d_lookup_symbol_module): Likewise.
1382         (find_symbol_in_baseclass): Simplify initialization.
1383
1384 2019-03-24  Tom Tromey  <tom@tromey.com>
1385
1386         * expression.h: Don't include symtab.h.
1387         (struct block): Forward declare.
1388
1389 2019-03-24  Tom Tromey  <tom@tromey.com>
1390
1391         * c-exp.y (typebase): Remove casts.
1392         * gdbtypes.c (lookup_unsigned_typename, )
1393         (lookup_signed_typename): Remove cast.
1394         * eval.c (parse_to_comma_and_eval): Remove cast.
1395         * parse.c (write_dollar_variable): Remove cast.
1396         * block.h (struct block) <superblock>: Now const.
1397         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1398         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1399         (map_block): Make "block" const.
1400         * symfile.h (struct quick_symbol_functions)
1401         <map_matching_symbols>: Constify block argument to "callback".
1402         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1403         const.
1404         (find_pc_sect_compunit_symtab): Make "b" const.
1405         (find_symbol_at_address): Likewise.
1406         (search_symbols): Likewise.
1407         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1408         (dw2_debug_names_lookup_symbol): Likewise.
1409         (dw2_map_matching_symbols): Update.
1410         * p-valprint.c (pascal_val_print): Remove "block".
1411         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1412         (aux_add_nonlocal_symbols): Make "block" const.
1413         (resolve_subexp): Remove cast.
1414         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1415         const.
1416         (iterate_over_file_blocks): Likewise.
1417         * f-exp.y (%union) <bval>: Remove.
1418         * coffread.c (patch_opaque_types): Make "b" const.
1419         * spu-tdep.c (spu_catch_start): Make "block" const.
1420         * c-valprint.c (print_unpacked_pointer): Remove "block".
1421         * symmisc.c (dump_symtab_1): Make "b" const.
1422         (block_depth): Make "block" const.
1423         * d-exp.y (%union) <bval>: Remove.
1424         * cp-support.h (cp_lookup_rtti_type): Update.
1425         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1426         * psymtab.c (psym_lookup_symbol): Make "block" const.
1427         (maintenance_check_psymtabs): Make "b" const.
1428         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1429         (enumerate_locals, enumerate_args): Update.
1430         * python/py-symtab.c (stpy_global_block): Make "block" const.
1431         (stpy_static_block): Likewise.
1432         * inline-frame.c (block_starting_point_at): Make "new_block"
1433         const.
1434         * block.c (find_block_in_blockvector): Make return type const.
1435         (blockvector_for_pc_sect): Make "b" const.
1436         (find_block_in_blockvector): Make "b" const.
1437
1438 2019-03-23  Tom Tromey  <tom@tromey.com>
1439
1440         * varobj.c (varobj_create): Update.
1441         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1442         * printcmd.c (display_command, do_one_display): Don't reset
1443         innermost_block.
1444         * parser-defs.h (enum innermost_block_tracker_type): Move to
1445         expression.h.
1446         (innermost_block): Update comment.
1447         * parse.c (parse_exp_1): Add tracker_types parameter.
1448         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1449         tracker_types parameter.  Reset innermost_block.
1450         (parse_exp_in_context): Remove.
1451         (parse_expression_for_completion): Update.
1452         * objfiles.c (~objfile): Don't reset expression_context_block or
1453         innermost_block.
1454         * expression.h (enum innermost_block_tracker_type): Move from
1455         parser-defs.h.
1456         (parse_exp_1): Add tracker_types parameter.
1457         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1458         reset innermost_block.
1459
1460 2019-03-23  Tom Tromey  <tom@tromey.com>
1461
1462         * objfiles.h: Include bcache.h.
1463
1464 2019-03-23  Tom Tromey  <tom@tromey.com>
1465
1466         * linespec.c (get_current_search_block): Use
1467         scoped_restore_current_language.
1468         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1469
1470 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1471             Jiong Wang  <jiong.wang@arm.com>
1472
1473         * aarch64-linux-tdep.c
1474         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1475         section.
1476         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1477
1478 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1479             Jiong Wang  <jiong.wang@arm.com>
1480
1481         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1482         instructions.
1483         (aarch64_analyze_prologue_test): Add PACIASP test.
1484         (aarch64_prologue_prev_register): Unmask PC value.
1485
1486 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1487             Jiong Wang  <jiong.wang@arm.com>
1488
1489         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1490         (aarch64_dwarf2_prev_register): Unmask PC value.
1491         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1492         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1493         DW_CFA_AARCH64_negate_ra_state.
1494         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1495
1496 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1497             Jiong Wang  <jiong.wang@arm.com>
1498
1499         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1500         registers.
1501         (aarch64_pseudo_register_name): Likewise.
1502         (aarch64_pseudo_register_type): Likewise.
1503         (aarch64_pseudo_register_reggroup_p): Likewise.
1504         (aarch64_gdbarch_init): Add pauth registers.
1505         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1506         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1507         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1508         (struct gdbarch_tdep): Add regnum for ra_state.
1509
1510 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1511             Jiong Wang  <jiong.wang@arm.com>
1512
1513         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1514
1515 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1516             Jiong Wang  <jiong.wang@arm.com>
1517
1518         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1519         function.
1520         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1521         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1522         (aarch64_gdbarch_init): Add puth registers.
1523         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1524         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1525         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1526
1527 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1528             Jiong Wang  <jiong.wang@arm.com>
1529
1530         * aarch64-linux-nat.c
1531         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1532         * aarch64-linux-tdep.c
1533         (aarch64_linux_core_read_description): Likewise.
1534         (aarch64_linux_get_hwcap): New function.
1535         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1536         (aarch64_linux_get_hwcap): New declaration.
1537
1538 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1539             Jiong Wang  <jiong.wang@arm.com>
1540
1541         * aarch64-linux-nat.c
1542         (aarch64_linux_nat_target::read_description): Add pauth param.
1543         * aarch64-linux-tdep.c
1544         (aarch64_linux_core_read_description): Likewise.
1545         * aarch64-tdep.c (struct target_desc): Add in pauth.
1546         (aarch64_read_description): Add pauth param.
1547         (aarch64_gdbarch_init): Likewise.
1548         * aarch64-tdep.h (aarch64_read_description): Likewise.
1549         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1550         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1551         * features/Makefile: Add new files.
1552         * features/aarch64-pauth.c: New file.
1553         * features/aarch64-pauth.xml: New file.
1554
1555 2019-03-20  Tom Tromey  <tromey@adacore.com>
1556
1557         * infrun.c (handle_inferior_event): Rename from
1558         handle_inferior_event_1.  Create a scoped_value_mark.
1559         (handle_inferior_event): Remove.
1560
1561 2019-03-19  Tom Tromey  <tromey@adacore.com>
1562
1563         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1564         * infrun.h (print_stop_event): Add "displays" parameter.
1565         * infrun.c (print_stop_event): Add "displays" parameter.
1566
1567 2019-03-19  Pedro Alves  <palves@redhat.com>
1568
1569         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1570         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1571         to -1.  Fix TABs vs spaces.
1572         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1573         * tui/tui-out.h (tui_ui_out) Add intro comments.
1574         <m_line, m_start_of_line>: In-class initialize, and add describing
1575         comment.
1576
1577 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1578
1579         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1580         variable names.
1581         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1582
1583 2019-03-18  Pedro Alves  <palves@redhat.com>
1584             Eli Zaretskii <eliz@gnu.org>
1585
1586         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1587         m_line and m_start_of_line.
1588
1589 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1590
1591         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1592         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1593         it returns a newline.  This fixes a regression in TU mode, whereby
1594         the next line is output on the same screen line as the user input.
1595
1596 2019-03-18  Tom Tromey  <tromey@adacore.com>
1597
1598         * minsyms.c (minimal_symbol_reader::install): Remove call to
1599         obstack_blank.
1600
1601 2019-03-18  Pedro Alves  <palves@redhat.com>
1602
1603         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1604         New globals.
1605         (apply_style): New, factored out from ...
1606         (apply_ansi_escape): ... this.  Handle reverse video mode.
1607         (tui_set_reverse_mode): New function.
1608         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1609         * tui/tui-winsource.c (tui_show_source_line): Use
1610         tui_set_reverse_mode instead of setting A_STANDOUT.
1611         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1612         New setter methods.
1613
1614 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1615
1616         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1617         Handle tabs.
1618
1619 2019-03-18  Tom Tromey  <tromey@adacore.com>
1620
1621         * ada-lang.c (empty_array): Add "high" parameter.
1622         (ada_evaluate_subexp): Update.
1623
1624 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1625
1626         * unittests/string_view-selftests.c: Define
1627         _initialize_string_view_selftests unconditionally.
1628
1629 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1630
1631         PR gdb/24350
1632         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1633
1634 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1635
1636         PR gdb/24351
1637         * windows-nat.c (display_selector): Fix format specifiers.
1638
1639 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1640
1641         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1642         tui_refill_source_window instead of tui_refresh_win, to update the
1643         current execution line.  This fixes redisplay of the current line
1644         when stepping through the code with "next" or "step".
1645
1646 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1647
1648         * source-cache.c (source_cache::get_source_lines): Call
1649         find_source_lines to initialize s->nlines.  This fixes vertical
1650         scrolling of TUI source window when the DOWN arrow is pressed.
1651
1652 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1653
1654         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1655         linux-thread-db.c (_initialize_thread_db): Likewise.
1656
1657 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1658
1659         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1660         wclrtoeol in tui_show_source_line".  This reverts changes made in
1661         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1662
1663 2019-03-15  Tom Tromey  <tom@tromey.com>
1664
1665         * symtab.h (struct minimal_symbol): Derive from
1666         general_symbol_info.
1667         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1668         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1669         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1670         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1671         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1672         (MSYMBOL_SEARCH_NAME): Update.
1673         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1674         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1675         * minsyms.c (minimal_symbol_reader::record_full): Update.
1676
1677 2019-03-15  Tom Tromey  <tom@tromey.com>
1678
1679         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1680
1681 2019-03-15  Tom Tromey  <tom@tromey.com>
1682
1683         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1684         unique_xmalloc_ptr.
1685         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1686         Update.
1687         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1688         (build_minimal_symbol_hash_tables)
1689         (minimal_symbol_reader::install): Update.
1690
1691 2019-03-15  Tom Tromey  <tom@tromey.com>
1692
1693         * symtab.c (create_demangled_names_hash): Update.
1694         (symbol_set_names): Update.
1695         * objfiles.h (struct objfile_per_bfd_storage)
1696         <demangled_names_hash>: Now an htab_up.
1697         * objfiles.c (objfile_per_bfd_storage): Simplify.
1698
1699 2019-03-15  Tom Tromey  <tom@tromey.com>
1700
1701         * objfiles.h (struct objfile_per_bfd_storage): Declare
1702         destructor.
1703         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1704         New.
1705         (get_objfile_bfd_data): Use new.  Don't initialize
1706         language_of_main.
1707         (free_objfile_per_bfd_storage): Remove.
1708         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1709
1710 2019-03-15  Tom Tromey  <tom@tromey.com>
1711
1712         * symfile.c (reread_symbols): Update.
1713         * objfiles.c (objfile::objfile): Update.
1714         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1715         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1716         comment.
1717         (minimal_symbol_reader::install): Update.
1718         (terminate_minimal_symbol_table): Remove.
1719         * jit.c (jit_object_close_impl): Update.
1720
1721 2019-03-15  Tom Tromey  <tom@tromey.com>
1722
1723         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1724         initializations.
1725
1726 2019-03-15  Tom Tromey  <tom@tromey.com>
1727
1728         * objfiles.h (struct objfile_per_bfd_storage)
1729         <demangled_hash_languages>: Now a bitset.
1730         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1731         (lookup_minimal_symbol): Update.
1732
1733 2019-03-15  Tom Tromey  <tom@tromey.com>
1734
1735         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1736         Don't return the symbol.
1737         * coffread.c (record_minimal_symbol): Use record_full.
1738
1739 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1740
1741         The MS-Windows port of ncurses fails to switch to a color pair if
1742         one or both of the colors are the implicit default colors.  This
1743         change records the default colors when TUI is initialized, and
1744         then specifies them explicitly when a color pair uses the default
1745         colors.  This allows color styling in TUI mode on MS-Windows.
1746
1747         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1748         ncurses_norm_attr.
1749         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1750         colors in ncurses_norm_attr.
1751         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1752         "none", replace it with the default color recorded in
1753         ncurses_norm_attr.
1754
1755 2019-03-14  Tom Tromey  <tromey@adacore.com>
1756
1757         * source-cache.h (class source_cache) <get_source_lines>: Return
1758         std::string.
1759         * source-cache.c (source_cache::extract_lines): Handle case where
1760         first_pos==npos.  Return std::string.
1761         (source_cache::get_source_lines): Update.
1762
1763 2019-03-14  Tom Tromey  <tromey@adacore.com>
1764
1765         * NEWS: Add item for "style sources" commands.
1766         * source-cache.c (source_cache::get_source_lines): Check
1767         source_styling.
1768         * cli/cli-style.c (source_styling): New global.
1769         (_initialize_cli_style): Add "style sources" commands.
1770         (show_style_sources): New function.
1771         * cli/cli-style.h (source_styling): Declare.
1772
1773 2019-03-14  Pedro Alves  <palves@redhat.com>
1774             Tom Tromey  <tromey@adacore.com>
1775
1776         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1777         * tui/tui-winsource.c (tui_refill_source_window): New function,
1778         from...
1779         (tui_horizontal_source_scroll): ... here.  Move some logic.
1780         * cli/cli-style.c (set_style_enabled): Notify new observable.
1781         * tui/tui-hooks.c (tui_redisplay_source): New function.
1782         (tui_attach_detach_observers): Attach or detach
1783         tui_redisplay_source.
1784         * observable.h (source_styling_changed): New observable.
1785         * observable.c: Define source_styling_changed observable.
1786
1787 2019-03-13  Tom Tromey  <tromey@adacore.com>
1788
1789         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1790         (i386_gnu_nat_target::store_registers): Update.
1791         * target-debug.h (target_debug_print_std_string): New macro.
1792         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1793         * windows-tdep.c (display_one_tib): Update.
1794         * tui/tui-stack.c (tui_make_status_line): Update.
1795         * top.c (print_inferior_quit_action): Update.
1796         * thread.c (thr_try_catch_cmd): Update.
1797         (add_thread_with_info): Update.
1798         (thread_target_id_str): Update.
1799         (thr_try_catch_cmd): Update.
1800         (thread_command): Update.
1801         (thread_find_command): Update.
1802         * record-btrace.c (record_btrace_target::info_record)
1803         (record_btrace_resume_thread, record_btrace_target::resume)
1804         (record_btrace_cancel_resume, record_btrace_step_thread)
1805         (record_btrace_target::wait, record_btrace_target::wait)
1806         (record_btrace_target::wait, record_btrace_target::stop): Update.
1807         * progspace.c (print_program_space): Update.
1808         * process-stratum-target.c
1809         (process_stratum_target::thread_address_space): Update.
1810         * linux-fork.c (linux_fork_mourn_inferior)
1811         (detach_checkpoint_command, info_checkpoints_command)
1812         (linux_fork_context): Update.
1813         (linux_fork_detach): Update.
1814         (class scoped_switch_fork_info): Update.
1815         (delete_checkpoint_command): Update.
1816         * infrun.c (follow_fork_inferior): Update.
1817         (follow_fork_inferior): Update.
1818         (proceed_after_vfork_done): Update.
1819         (handle_vfork_child_exec_or_exit): Update.
1820         (follow_exec): Update.
1821         (displaced_step_prepare_throw): Update.
1822         (displaced_step_restore): Update.
1823         (start_step_over): Update.
1824         (resume_1): Update.
1825         (clear_proceed_status_thread): Update.
1826         (proceed): Update.
1827         (print_target_wait_results): Update.
1828         (do_target_wait): Update.
1829         (context_switch): Update.
1830         (stop_all_threads): Update.
1831         (restart_threads): Update.
1832         (finish_step_over): Update.
1833         (handle_signal_stop): Update.
1834         (switch_back_to_stepped_thread): Update.
1835         (keep_going_pass_signal): Update.
1836         (print_exited_reason): Update.
1837         (normal_stop): Update.
1838         * inferior.c (inferior_pid_to_str): Change return type.
1839         (print_selected_inferior): Update.
1840         (add_inferior): Update.
1841         (detach_inferior): Update.
1842         * dummy-frame.c (fprint_dummy_frames): Update.
1843         * dcache.c (dcache_info_1): Update.
1844         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1845         (btrace_fetch, btrace_clear): Update.
1846         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1847         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1848         type.
1849         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1850         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1851         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1852         * gdbarch.c, gdbarch.h: Rebuild.
1853         * gdbarch.sh (core_pid_to_str): Change return type.
1854         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1855         return type.
1856         (windows_nat_target::pid_to_str): Change return type.
1857         (windows_delete_thread): Update.
1858         (windows_nat_target::attach): Update.
1859         (windows_nat_target::files_info): Update.
1860         * target-delegates.c: Rebuild.
1861         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1862         return type.
1863         (sol_thread_target::pid_to_str): Change return type.
1864         * remote.c (class remote_target) <pid_to_str>: Change return
1865         type.
1866         (remote_target::pid_to_str): Change return type.
1867         (extended_remote_target::attach, remote_target::remote_stop_ns)
1868         (remote_target::remote_notif_remove_queued_reply)
1869         (remote_target::push_stop_reply, remote_target::disable_btrace):
1870         Update.
1871         (extended_remote_target::attach): Update.
1872         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1873         type.
1874         (gdbsim_target::pid_to_str): Change return type.
1875         * ravenscar-thread.c (struct ravenscar_thread_target)
1876         <pid_to_str>: Change return type.
1877         (ravenscar_thread_target::pid_to_str): Change return type.
1878         * procfs.c (class procfs_target) <pid_to_str>: Change return
1879         type.
1880         (procfs_target::pid_to_str): Change return type.
1881         (procfs_target::attach): Update.
1882         (procfs_target::detach): Update.
1883         (procfs_target::fetch_registers): Update.
1884         (procfs_target::store_registers): Update.
1885         (procfs_target::wait): Update.
1886         (procfs_target::files_info): Update.
1887         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1888         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1889         return type.
1890         (nto_procfs_target::pid_to_str): Change return type.
1891         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1892         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1893         return type.
1894         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1895         (exit_lwp): Update.
1896         (attach_proc_task_lwp_callback, get_detach_signal)
1897         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1898         (linux_nat_target::resume, wait_lwp, stop_callback)
1899         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1900         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1901         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1902         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1903         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1904         type.
1905         (inf_ptrace_target::attach): Update.
1906         (inf_ptrace_target::files_info): Update.
1907         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1908         type.
1909         (go32_nat_target::pid_to_str): Change return type.
1910         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1911         (gnu_nat_target::wait): Update.
1912         (gnu_nat_target::wait): Update.
1913         (gnu_nat_target::resume): Update.
1914         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1915         (fbsd_nat_target::wait): Update.
1916         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1917         type.
1918         (darwin_nat_target::attach): Update.
1919         * corelow.c (class core_target) <pid_to_str>: Change return type.
1920         (core_target::pid_to_str): Change return type.
1921         * target.c (normal_pid_to_str): Change return type.
1922         (default_pid_to_str): Likewise.
1923         (target_pid_to_str): Change return type.
1924         (target_translate_tls_address): Update.
1925         (target_announce_detach): Update.
1926         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1927         return type.
1928         (bsd_uthread_target::pid_to_str): Change return type.
1929         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1930         type.
1931         (bsd_kvm_target::pid_to_str): Change return type.
1932         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1933         return type.
1934         (aix_thread_target::pid_to_str): Change return type.
1935         * target.h (struct target_ops) <pid_to_str>: Change return type.
1936         (target_pid_to_str, normal_pid_to_str): Likewise.
1937         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1938         type.
1939         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1940         type.
1941         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1942         return type.
1943         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1944         type.
1945         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1946         type.
1947         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1948         return type.
1949
1950 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1951
1952         * NEWS: Mention that the new default MI version is 3.  Mention
1953         changes to the output of commands and events that deal with
1954         multi-location breakpoints.
1955         * breakpoint.c: Include "mi/mi-out.h".
1956         (print_one_breakpoint): Change output syntax if using MI version
1957         >= 3.
1958         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1959         New.
1960         (mi_multi_location_breakpoint_output_fixed): New.
1961         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1962         (mi_cmd_fix_multi_location_breakpoint_output): New.
1963         (mi_multi_location_breakpoint_output_fixed): New.
1964         * mi/mi-cmds.c (mi_cmds): Register command
1965         -fix-multi-location-breakpoint-output.
1966         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1967         interpreter "mi".
1968
1969 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1970
1971         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1972         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1973         instantiate mi_ui_out based on interpreter name.
1974         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1975         * mi/mi-main.c (mi_load_progress): Likewise.
1976
1977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1978
1979         * NEWS: Combine separate "New targets" sections for 8.3.
1980
1981 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1982
1983         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1984         (ppcfbsd_init_abi): Install gdbarch
1985         "fetch_tls_load_module_address" and "get_thread_local_address"
1986         methods.
1987
1988 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1989
1990         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1991         (riscv_fbsd_init_abi): Install gdbarch
1992         "fetch_tls_load_module_address" and "get_thread_local_address"
1993         methods.
1994
1995 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1996
1997         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1998         (i386fbsd_init_abi): Install gdbarch
1999         "fetch_tls_load_module_address" and "get_thread_local_address"
2000         methods.
2001
2002 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2003
2004         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2005         (amd64fbsd_init_abi): Install gdbarch
2006         "fetch_tls_load_module_address" and "get_thread_local_address"
2007         methods.
2008
2009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2010
2011         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2012         (struct fbsd_pspace_data): New type.
2013         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2014         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2015         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2016         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2017         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2018
2019 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2020
2021         * gdbtypes.c (lookup_struct_elt): New function.
2022         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2023         * gdbtypes.h (struct struct_elt): New type.
2024         (lookup_struct_elt): New prototype.
2025
2026 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2027
2028         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2029         remove disabled code block.
2030
2031 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2032
2033         * gdbarch.sh (get_thread_local_address): New method.
2034         * gdbarch.h, gdbarch.c: Regenerate.
2035         * target.c (target_translate_tls_address): Use
2036         gdbarch_get_thread_local_address if present instead of
2037         target::get_thread_local_address.
2038
2039 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2040
2041         * target.h (target::get_thread_local_address): Update comment.
2042
2043 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2044
2045         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2046         objfile->separate_debug_objfile_backlink if not NULL.
2047
2048 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2049
2050         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2051         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2052         (amd64bsd_store_inferior_registers): Likewise.
2053         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2054         Enable segment base registers.
2055         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2056         PT_GETFSBASE and PT_GETGSBASE.
2057         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2058         PT_SETGSBASE.
2059         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2060         segment base registers.
2061         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2062
2063 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2064
2065         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2066         Update calls to i386_target_description to add 'segments'
2067         parameter.
2068         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2069         add segment base registers.
2070         * arch/i386.c (i386_create_target_description): Add 'segments'
2071         parameter to enable segment base registers.
2072         * arch/i386.h (i386_create_target_description): Likewise.
2073         * features/i386/32bit-segments.xml: New file.
2074         * features/i386/32bit-segments.c: Generate.
2075         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2076         call to i386_target_description to add 'segments' parameter.
2077         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2078         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2079         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2080         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2081         if feature is present.
2082         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2083         Add 'segments' parameter to call to i386_target_description.
2084         (i386_target_description): Add 'segments' parameter to enable
2085         segment base registers.
2086         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2087         to call to i386_target_description.
2088         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2089         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2090         Define I386_NUM_REGS.
2091         (i386_target_description): Add 'segments' parameter to enable
2092         segment base registers.
2093
2094 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2095
2096         PR/24325
2097         * source-cache.c: #undef open and close, to avoid unresolved
2098         externals during linking.
2099
2100 2019-03-12  Tom Tromey  <tromey@adacore.com>
2101
2102         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2103         const.  Add initializers.
2104         (_initialize_remote): Don't initialize ptid globals.
2105
2106 2019-03-12  Pedro Alves  <palves@redhat.com>
2107
2108         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2109
2110 2019-03-12  Pedro Alves  <palves@redhat.com>
2111
2112         * cp-name-parser.y (main): Remove unused 'len' variable.
2113
2114 2019-03-12  Tom Tromey  <tromey@adacore.com>
2115
2116         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2117         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2118
2119 2019-03-12  Tom Tromey  <tromey@adacore.com>
2120
2121         * linux-nat.c (iterate_over_lwps): Update.
2122         (stop_callback): Remove parameter.
2123         (stop_wait_callback, detach_callback, resume_set_callback)
2124         (select_singlestep_lwp_callback, set_ignore_sigint)
2125         (status_callback, resumed_callback, resume_clear_callback)
2126         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2127         data parameter.
2128         (linux_nat_target::detach, linux_nat_target::resume)
2129         (linux_stop_and_wait_all_lwps, select_event_lwp)
2130         (linux_nat_filter_event, linux_nat_wait_1)
2131         (linux_nat_target::kill, linux_nat_target::stop)
2132         (linux_nat_target::stop): Update.
2133         (linux_nat_resume_callback): Change type.
2134         (resume_stopped_resumed_lwps, count_events_callback)
2135         (select_event_lwp_callback): Likewise.
2136         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2137         * arm-linux-nat.c (struct update_registers_data): Remove.
2138         (update_registers_callback): Change type.
2139         (arm_linux_insert_hw_breakpoint1): Update.
2140         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2141         parameter.
2142         (x86_linux_dr_set_addr): Update.
2143         (x86_linux_dr_set_control): Update.
2144         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2145         (iterate_over_lwps): Use gdb::function_view.
2146         * nat/aarch64-linux-hw-point.c (struct
2147         aarch64_dr_update_callback_param): Remove.
2148         (debug_reg_change_callback): Change type.
2149         (aarch64_notify_debug_reg_change): Update.
2150         * s390-linux-nat.c (s390_refresh_per_info): Update.
2151
2152 2019-03-11  Tom Tromey  <tromey@adacore.com>
2153
2154         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2155         redundant assignment to "this_cu".
2156
2157 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2158
2159         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2160
2161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2162
2163         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2164         from...
2165         (rank_one_type): ... this.
2166
2167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2168
2169         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2170         from...
2171         (rank_one_type): ... this.
2172
2173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2174
2175         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2176         from...
2177         (rank_one_type): ... this.
2178
2179 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2180
2181         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2182         from...
2183         (rank_one_type): ... this.
2184
2185 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2186
2187         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2188         from...
2189         (rank_one_type): ... this.
2190
2191 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2192
2193         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2194         from...
2195         (rank_one_type): ... this.
2196
2197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2198
2199         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2200         from...
2201         (rank_one_type): ... this.
2202
2203 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2204
2205         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2206         from...
2207         (rank_one_type): ... this.
2208
2209 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2210
2211         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2212         from...
2213         (rank_one_type): ... this.
2214
2215 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2216
2217         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2218         from...
2219         (rank_one_type): ... this.
2220
2221 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2222
2223         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2224         from...
2225         (rank_one_type): ... this.
2226
2227 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2228
2229         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2230         from...
2231         (rank_one_type): ... this.
2232
2233 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2234
2235         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2236         inferior-events' shows the example events.
2237
2238 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2239
2240         Support styling on native MS-Windows console
2241
2242         PR/24315
2243         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2244         on MS-Windows if $TERM is not defined.
2245
2246         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2247
2248         * posix-hdep.c (gdb_console_fputs):
2249         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2250         functions.
2251         * ui-file.h (gdb_console_fputs): Add prototype.
2252
2253         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2254         back to fputs only if the former returns zero.
2255
2256 2019-03-07  Tom Tromey  <tom@tromey.com>
2257
2258         * symmisc.c (print_symbol_bcache_statistics): Update.
2259         (print_objfile_statistics): Update.
2260         * symfile.c (allocate_symtab): Update.
2261         * stabsread.c: Don't include bcache.h.
2262         * psymtab.h (struct psymbol_bcache): Don't declare.
2263         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2264         (psymbol_bcache_init, psymbol_bcache_free)
2265         (psymbol_bcache_get_bcache): Don't declare.
2266         * psymtab.c (struct psymbol_bcache): Remove.
2267         (psymtab_storage::psymtab_storage): Update.
2268         (psymtab_storage::~psymtab_storage): Update.
2269         (psymbol_bcache_init, psymbol_bcache_free)
2270         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2271         (add_psymbol_to_bcache): Update.
2272         (allocate_psymtab): Update.
2273         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2274         macro_cache>: No longer pointers.
2275         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2276         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2277         * macrotab.c (macro_bcache): Update.
2278         * macroexp.c: Don't include bcache.h.
2279         * gdbtypes.c (check_types_worklist): Update.
2280         (types_deeply_equal): Remove TRY/CATCH.  Update.
2281         * elfread.c (elf_symtab_read): Update.
2282         * dwarf2read.c: Don't include bcache.h.
2283         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2284         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2285         (print_bcache_statistics, bcache_memory_used): Don't declare.
2286         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2287         methods.  Rename all data members.
2288         * bcache.c (struct bcache): Move to bcache.h.
2289         (bcache::expand_hash_table): Rename from expand_hash_table.
2290         (bcache): Remove.
2291         (bcache::insert): Rename from bcache_full.
2292         (bcache::compare): Rename from bcache_compare.
2293         (bcache_xmalloc): Remove.
2294         (bcache::~bcache): Rename from bcache_xfree.
2295         (bcache::print_statistics): Rename from print_bcache_statistics.
2296         (bcache::memory_used): Rename from bcache_memory_used.
2297
2298 2019-03-07  Pedro Alves  <palves@redhat.com>
2299
2300         * infrun.c (normal_stop): Also check for
2301         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2302
2303 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2304
2305         * f-lang.c (value_from_host_double): Moved to...
2306         * value.c (value_from_host_double): ...here.
2307         * value.h (value_from_host_double): Declare.
2308         * guile/scm-math.c (vlscm_convert_typed_number): Use
2309         value_from_host_double.
2310         (vlscm_convert_number): Likewise.
2311         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2312         * python/py-value.c (convert_value_from_python): Likewise.
2313
2314 2019-03-06  Tom Tromey  <tom@tromey.com>
2315
2316         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2317
2318 2019-03-06  Tom Tromey  <tom@tromey.com>
2319
2320         * utils.h (free_current_contents): Don't declare.
2321         * utils.c (free_current_contents): Remove.
2322
2323 2019-03-06  Tom Tromey  <tom@tromey.com>
2324
2325         * top.c (quit_force): Update.
2326         * main.c (captured_command_loop): Update.
2327         * common/new-op.c (operator new): Update.
2328         * common/common-exceptions.c (struct catcher)
2329         <save_cleanup_chain>: Remove member.
2330         (exceptions_state_mc_init): Update.
2331         (exception_try_scope_entry): Return nullptr.
2332         (exception_try_scope_exit, exception_rethrow)
2333         (throw_exception_sjlj, throw_exception_cxx): Update.
2334         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2335         (all_cleanups, do_cleanups, discard_cleanups)
2336         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2337         (restore_cleanups, restore_final_cleanups): Don't declare.
2338         (do_final_cleanups): Remove parameter.
2339         * common/cleanups.c (cleanup_chain, make_cleanup)
2340         (make_cleanup_dtor, all_cleanups, do_cleanups)
2341         (discard_my_cleanups, discard_cleanups)
2342         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2343         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2344         (null_cleanup): Remove.
2345         (do_final_cleanups): Remove parameter.
2346
2347 2019-03-06  Tom Tromey  <tom@tromey.com>
2348
2349         * remote.c (remote_target::remote_parse_stop_reply): Use
2350         unique_xmalloc_ptr.
2351
2352 2019-03-06  Tom Tromey  <tom@tromey.com>
2353
2354         * stabsread.c (struct stabs_field_info): Rename from field_info.
2355         <list, fnlist>: Add initializers.
2356         <obstack>: New member.
2357         (read_member_functions, read_struct_fields, read_baseclasses):
2358         Allocate on obstack.  Don't use cleanups.
2359         (read_one_struct_field, read_member_functions, read_struct_fields)
2360         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2361         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2362         (read_struct_type): Update.
2363
2364 2019-03-06  Tom Tromey  <tom@tromey.com>
2365
2366         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2367         * common/filestuff.h (make_cleanup_close): Don't declare.
2368         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2369         Remove.
2370
2371 2019-03-06  Tom Tromey  <tom@tromey.com>
2372
2373         * solib-aix.c: Use make_scope_exit.
2374
2375 2019-03-06  Tom Tromey  <tom@tromey.com>
2376
2377         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2378         Use make_scope_exit.
2379
2380 2019-03-06  Tom Tromey  <tom@tromey.com>
2381
2382         * solib-svr4.c (disable_probes_interface): Remove parameter.
2383         (svr4_handle_solib_event): Use make_scope_exit.
2384
2385 2019-03-06  Tom Tromey  <tom@tromey.com>
2386
2387         * remote.c (struct stop_reply_deleter): Remove.
2388         (stop_reply_up): Update.
2389         (struct stop_reply): Derive from notif_event.  Don't typedef.
2390         <regcache>: Now a std::vector.
2391         (stop_reply_xfree): Remove.
2392         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2393         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2394         (remote_target::discard_pending_stop_replies): Use delete.
2395         (remote_target::remote_parse_stop_reply): Update.
2396         (remote_target::process_stop_reply): Update.
2397         * remote-notif.h (struct notif_event): Add virtual destructor.
2398         Remove "dtr" member.
2399         (struct notif_client) <alloc_event>: Return a unique_ptr.
2400         (notif_event_xfree): Don't declare.
2401         (notif_event_up): New typedef.
2402         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2403         (notif_event_xfree, do_notif_event_xfree): Remove.
2404         (remote_notif_state_xfree): Update.
2405
2406 2019-03-06  Tom Tromey  <tom@tromey.com>
2407
2408         * infrun.c (displaced_step_clear_cleanup): Now a
2409         forward_scope_exit type.
2410         (displaced_step_prepare_throw): Update.
2411         (displaced_step_fixup): Update.
2412
2413 2019-03-06  Tom Tromey  <tom@tromey.com>
2414
2415         * inferior.h (class inferior): Update comment.
2416         * gdbthread.h (class thread_info): Update comment.
2417
2418 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2419             Tom Tromey  <tom@tromey.com>
2420
2421         * stabsread.h (struct stab_section_list): Remove.
2422         (coffstab_build_psymtabs): Update.
2423         * dbxread.c (symbuf_sections): Now a std::vector.
2424         (sect_idx): New global.
2425         (fill_symbuf): Update.
2426         (coffstab_build_psymtabs): Change type of stabsects parameter.
2427         Update.
2428         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2429         std::vector.
2430         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2431         (coff_locate_sections): Update.
2432         (coff_symfile_read): Remove cleanups.  Update.
2433         (init_stringtab): Add storage parameter.
2434         (free_stringtab, free_stringtab_cleanup): Remove.
2435         (init_lineno): Add storage parameter.
2436         (free_linetab, free_linetab_cleanup): Remove.
2437
2438 2019-03-06  Pedro Alves  <palves@redhat.com>
2439
2440         * linux-fork.c (fork_info::clobber_regs): Delete.
2441         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2442         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2443         comment.  Adjust.
2444         (scoped_switch_fork_info::scoped_switch_fork_info)
2445         (checkpoint_command, linux_fork_context): Adjust
2446         fork_save_infrun_state calls.
2447
2448 2019-03-06  Pedro Alves  <palves@redhat.com>
2449
2450         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2451         (inf_has_multiple_threads): Return 'bool' and rewrite using
2452         inferior_info::threads().
2453
2454 2019-03-06  Pedro Alves  <palves@redhat.com>
2455
2456         * linux-fork.c: Include <list>.
2457         (fork_list): Now a std::list instance.
2458         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2459         (forks_exist_p, find_last_fork): Adjust.
2460         (new_fork): Delete.
2461         (one_fork_p): New.
2462         (add_fork): Adjust.
2463         (free_fork): Delete, folded into fork_info::~fork_info().
2464         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2465         Adjust.
2466         (init_fork_list): Delete.
2467         (linux_fork_killall, linux_fork_mourn_inferior)
2468         (linux_fork_detach, info_checkpoints_command): Adjust.
2469         (_initialize_linux_fork): No longer call init_fork_list.
2470
2471 2019-03-06  Pedro Alves  <palves@redhat.com>
2472
2473         * linux-fork.c (new_fork): New, split out of ...
2474         (add_fork): ... this.  Return void.  Move "first fork" special
2475         case from here, to ...
2476         (checkpoint_command): ... here.
2477         * linux-linux.h (add_fork): Return void.
2478
2479 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2480
2481         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2482
2483 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2484             Chris January  <chris.january@arm.com>
2485             David Lecomber  <david.lecomber@arm.com>
2486
2487         * f-exp.y: New token, UNOP_INTRINSIC.
2488         (exp): New pattern using UNOP_INTRINSIC token.
2489         (f77_keywords): Add 'abs' keyword.
2490         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2491         (value_from_host_double): New function.
2492         (evaluate_subexp_f): Support UNOP_ABS.
2493
2494 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2495
2496         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2497         types.
2498
2499 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2500
2501         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2502         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2503         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2504
2505 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2506
2507         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2508
2509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2510             Chris January  <chris.january@arm.com>
2511
2512         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2513         * f-exp.y: Define 'KIND' token.
2514         (exp): New pattern for KIND expressions.
2515         (ptype): Handle types with a kind extension.
2516         (direct_abs_decl): Extend to spot kind extensions.
2517         (f77_keywords): Add 'kind' to the list.
2518         (push_kind_type): New function.
2519         (convert_to_kind_type): New function.
2520         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2521         * parse.c (operator_length_standard): Likewise.
2522         * parser-defs.h (enum type_pieces): Add tp_kind.
2523         * std-operator.def: Add UNOP_KIND.
2524
2525 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2526
2527         * f-exp.y (f_parse): Set yydebug.
2528
2529 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * f-lang.c (evaluate_subexp_f): New function.
2532         (exp_descriptor_f): New global.
2533         (f_language_defn): Use exp_descriptor_f instead of
2534         exp_descriptor_standard.
2535
2536 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2537
2538         * f-exp.y (struct token): Add comments.
2539         (dot_ops): Remove uppercase versions and the end marker.
2540         (f77_keywords): Likewise.
2541         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2542         entries in the dot_ops array are case insensitive, and use
2543         strncasecmp to compare strings.  Also some whitespace cleanup in
2544         this area.  Similar for the f77_keywords array, except entries in
2545         this list might be case sensitive.
2546
2547 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2548
2549         * f-exp.y (struct f77_boolean_val): Add comments.
2550         (boolean_values): Remove uppercase versions, and end marker.
2551         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2552         and use strncasecmp to achieve case insensitivity.  Additionally,
2553         perform whitespace cleanup around this code.
2554
2555 2019-03-06  Tom Tromey  <tromey@adacore.com>
2556
2557         * remote-sim.c (gdbsim_target_open): Use result of
2558         gdb_argv::release.
2559
2560 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2561         Dirk Schubert  <dirk.schubert@arm.com>
2562         Chris January  <chris.january@arm.com>
2563
2564         * eval.c (evaluate_subexp_standard): Call Fortran argument
2565         wrapping logic.
2566         * f-lang.c (struct value): A value which can be passed into a
2567         Fortran function call.
2568         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2569         where appropriate.
2570         (struct type): Value ready for a Fortran function call.
2571         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2572         is needed.
2573         * f-lang.h (fortran_argument_convert): Declaration.
2574         (fortran_preserve_arg_pointer): Declaration.
2575         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2576
2577 2019-03-05  Tom Tromey  <tromey@adacore.com>
2578
2579         * python/py-prettyprint.c (print_string_repr): Remove #if.
2580         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2581
2582 2019-03-05  Tom Tromey  <tromey@adacore.com>
2583
2584         * target.c (the_dummy_target): Move later.  Change type to
2585         "dummy_target".
2586         (initialize_targets): Don't initialize the_dummy_target.
2587
2588 2019-03-05  Tom Tromey  <tromey@adacore.com>
2589
2590         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2591         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2592
2593 2019-03-05  Tom Tromey  <tromey@adacore.com>
2594
2595         * windows-nat.c (windows_nat_target::attach)
2596         (windows_nat_target::detach): Don't call gdb_flush.
2597         * valprint.c (generic_val_print, val_print, val_print_string):
2598         Don't call gdb_flush.
2599         * utils.c (defaulted_query): Don't call gdb_flush.
2600         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2601         * target.c (target_announce_detach): Don't call gdb_flush.
2602         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2603         * remote.c (extended_remote_target::attach): Don't call
2604         gdb_flush.
2605         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2606         * printcmd.c (do_examine): Don't call gdb_flush.
2607         (info_display_command): Don't call gdb_flush.
2608         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2609         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2610         * memattr.c (info_mem_command): Don't call gdb_flush.
2611         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2612         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2613         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2614         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2615         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2616         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2617         (gnu_nat_target::detach): Don't call gdb_flush.
2618         * f-valprint.c (f_val_print): Don't call gdb_flush.
2619         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2620         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2621         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2622         gdb_flush.
2623         * c-valprint.c (c_val_print): Don't call gdb_flush.
2624         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2625
2626 2019-03-05  Tom Tromey  <tromey@adacore.com>
2627
2628         * varobj.c (update_dynamic_varobj_children): Update.
2629         (install_default_visualizer): Use reset, not release.
2630         * value.c (set_internalvar): Update.
2631         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2632         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2633         ATTRIBUTE_UNUSED_RESULT.
2634
2635 2019-03-05  Tom Tromey  <tromey@adacore.com>
2636
2637         * remote.c (class scoped_remote_fd) <release>: Add
2638         ATTRIBUTE_UNUSED_RESULT.
2639
2640 2019-03-05  Tom Tromey  <tromey@adacore.com>
2641
2642         * macroexp.c (struct macro_buffer) <release>: Add
2643         ATTRIBUTE_UNUSED_RESULT.
2644
2645 2019-03-05  Tom Tromey  <tromey@adacore.com>
2646
2647         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2648         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2649         ATTRIBUTE_UNUSED_RESULT.
2650
2651 2019-03-05  Tom Tromey  <tromey@adacore.com>
2652
2653         * common/scoped_fd.h (class scoped_fd) <release>: Add
2654         ATTRIBUTE_UNUSED_RESULT.
2655
2656 2019-03-05  Tom Tromey  <tromey@adacore.com>
2657
2658         * parser-defs.h (struct parser_state) <release>: Add
2659         ATTRIBUTE_UNUSED_RESULT.
2660
2661 2019-03-05  Tom Tromey  <tromey@adacore.com>
2662
2663         * utils.h (class gdb_argv) <release>: Add
2664         ATTRIBUTE_UNUSED_RESULT.
2665         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2666
2667 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2668
2669         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2670         for-loop range, to avoid compiler warnings.
2671
2672         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2673         avoid compiler warnings about unused variables.
2674
2675         * NEWS: Mention end of support for native debugging on MS-Windows
2676         before XP.
2677
2678         PR gdb/24292
2679         * common/netstuff.c:
2680         * gdbserver/gdbreplay.c
2681         * gdbserver/remote-utils.c:
2682         * ser-tcp.c:
2683         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2684         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2685         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2686         'getaddrinfo' and 'freeaddrinfo' were not available before
2687         Windows XP, and mingw.org's MinGW headers by default define
2688         _WIN32_WINNT to 0x500.
2689
2690 2019-03-01  Gary Benson <gbenson@redhat.com>
2691
2692         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2693
2694 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2695             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2696
2697         PR gdb/8527
2698         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2699         set_sigint_trap, clear_sigint_trap.
2700
2701 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2702
2703         * target.c (target_detach): Clear the regcache and the
2704         frame cache.
2705
2706 2019-02-27  Pedro Alves  <palves@redhat.com>
2707
2708         * utils.c (set_screen_size): When we cap the height/width sizes,
2709         tweak the corresponding command variable to show "unlimited":
2710
2711 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2712             Pedro Alves  <palves@redhat.com>
2713
2714         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2715         before calling rl_set_screen_size.
2716
2717 2019-02-27  Tom Tromey  <tromey@adacore.com>
2718
2719         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2720         define.
2721         * python/py-value.c: Remove Python 2.4 workaround.
2722         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2723         workaround.
2724         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2725         Python 2.4 workaround.
2726         * python/python-internal.h: Remove Python 2.4 comment.
2727         (Py_ssize_t): Don't define.
2728         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2729         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2730         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2731         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2732         * python/python.c (do_start_initialization): Remove Python 2.4
2733         workaround.
2734         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2735         (print_children): Remove Python 2.4 workaround.
2736         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2737         workaround.
2738         (CHARBUFFERPROC_NAME): Remove.
2739         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2740         Python 2.4 workaround.
2741
2742 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2743
2744         * NEWS: Note minimum Python version.
2745
2746 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2747
2748         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2749         code from these functions.  Remove corresponding ifdefs.  Use
2750         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2751         Remove gotos and target of gotos.
2752         (infpy_search_memory): Likewise.
2753
2754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2755
2756         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2757         (hppa_gdbarch_init): Don't register deleted functions with
2758         gdbarch.
2759
2760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2761
2762         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2763         (h8300_unwind_sp): Delete.
2764         (h8300_dummy_id): Delete.
2765         (h8300_gdbarch_init): Don't register deleted functions with
2766         gdbarch.
2767
2768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2769
2770         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2771         (ft32_unwind_pc): Delete.
2772         (ft32_unwind_sp): Delete.
2773         (ft32_gdbarch_init): Don't register deleted functions with
2774         gdbarch.
2775
2776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2777
2778         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2779         (frv_unwind_pc): Delete.
2780         (frv_unwind_sp): Delete.
2781         (frv_gdbarch_init): Don't register deleted functions with
2782         gdbarch.
2783
2784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2785
2786         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2787         (riscv_unwind_pc): Delete.
2788         (riscv_unwind_sp): Delete.
2789         (riscv_gdbarch_init): Don't register deleted functions with
2790         gdbarch.
2791
2792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2793
2794         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2795         (csky_unwind_pc): Delete.
2796         (csky_unwind_sp): Delete.
2797         (csky_gdbarch_init): Don't register deleted functions with
2798         gdbarch.
2799
2800 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2801
2802         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2803         (cris_unwind_pc): Delete.
2804         (cris_unwind_sp): Delete.
2805         (cris_gdbarch_init): Don't register deleted functions with
2806         gdbarch.
2807
2808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2809
2810         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2811         (bfin_unwind_pc): Delete.
2812         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2813
2814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2815
2816         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2817         (arm_unwind_pc): Delete.
2818         (arm_unwind_sp): Delete.
2819         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2820
2821 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2822
2823         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2824         (arc_unwind_pc): Delete.
2825         (arc_unwind_sp): Delete.
2826         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2827
2828 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2829
2830         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2831         (alpha_unwind_pc): Delete.
2832         (alpha_gdbarch_init): Don't register deleted functions with
2833         gdbarch.
2834
2835 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2836
2837         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2838         (aarch64_unwind_pc): Delete.
2839         (aarch64_unwind_sp): Delete.
2840         (aarch64_gdbarch_init): Don't register deleted functions with
2841         gdbarch.
2842
2843 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2844
2845         * gdbtypes.c (type_align): Don't consider static members when
2846         computing structure alignment.
2847
2848 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2849
2850         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2851         return 0 for other types.
2852         * arch-utils.c (default_type_align): Always return 0.
2853         * gdbarch.h: Regenerate.
2854         * gdbarch.sh (type_align): Extend comment.
2855         * gdbtypes.c (type_align): Add additional comments, always call
2856         gdbarch_type_align before applying the default rules.
2857         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2858         generic code will then apply a suitable default.
2859         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2860         types, return 0 for other types.
2861
2862 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2863
2864         * NEWS: Create a new section for the next release branch.
2865         Rename the section of the current branch, now that it has
2866         been cut.
2867
2868 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2869
2870         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2871         * version.in: Bump version to 8.3.50.DATE-git.
2872
2873 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2874
2875         * aix-thread.c (ptid_cmp): Remove unused variable.
2876         (get_signaled_thread): Likewise.
2877         (store_regs_user_thread): Likewise.
2878         (store_regs_kernel_thread): Likewise.
2879         (fetch_regs_kernel_thread): Remove shadowed variable.
2880
2881 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2882
2883         * features/riscv/32bit-cpu.xml: Add register numbers.
2884         * features/riscv/32bit-fpu.c: Regenerate.
2885         * features/riscv/32bit-fpu.xml: Add register numbers.
2886         * features/riscv/64bit-cpu.xml: Add register numbers.
2887         * features/riscv/64bit-fpu.c: Regenerate.
2888         * features/riscv/64bit-fpu.xml: Add register numbers.
2889
2890 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2891
2892         * NEWS: Mention two argument form of gdb.Value constructor.
2893         * python/py-value.c (convert_buffer_and_type_to_value): New
2894         function.
2895         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2896         Add support for handling an optional second argument.  Call
2897         convert_buffer_and_type_to_value as appropriate.
2898         * python/python-internal.h (Py_buffer_deleter): New struct.
2899         (Py_buffer_up): New typedef.
2900
2901 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2902
2903         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2904         instead of releasing ownership.
2905
2906 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2907
2908         * dwarf2read.c (open_and_init_dwp_file): Call
2909         elf_numsections instead of bfd_count_sections to initialize
2910         dwp_file->num_sections.
2911
2912 2019-02-25  Tom Tromey  <tromey@adacore.com>
2913
2914         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2915
2916 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2917
2918         * gcore.in: Add '--readnever' option when invoking GDB.
2919
2920 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2921
2922         * MAINTAINERS: Update my email address.
2923
2924 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2925
2926         * build-id.c (build_id_to_debug_bfd_1): New function.
2927         (build_id_to_debug_bfd): Look for separate debug file in
2928         sysroot.
2929
2930 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2931
2932         * gdbarch.sh: Update the copyright year range that is placed into
2933         generated files.
2934
2935 2019-02-22  Keith Seitz  <keiths@redhat.com>
2936
2937         PR symtab/23853
2938         * linespec.c (create_sals_line_offset): Search for the default
2939         symtab's filename instead of its fullname.
2940
2941 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2942
2943         * NEWS: Update style defaults.
2944
2945 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2946
2947         * main.c (captured_main_1): Disable styling in batch mode.
2948
2949 2019-02-20  Tom Tromey  <tom@tromey.com>
2950
2951         * symtab.c (symtab_symbol_info): Fix typos.
2952
2953 2019-02-20  Tom Tromey  <tromey@adacore.com>
2954
2955         * findcmd.c (_initialize_mem_search): Use upper case for
2956         metasyntactic variables.
2957
2958 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2959
2960         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2961         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2962
2963 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2964
2965         * top.h (source_file_name): Change to std::string.
2966         * top.c (source_file_name): Likewise.
2967         (command_line_input): Adjust.
2968         * cli/cli-script.c (script_from_file): Adjust.
2969
2970 2019-02-19  Tom Tromey  <tromey@adacore.com>
2971
2972         * ravenscar-thread.c
2973         (ravenscar_thread_target::update_thread_list): Don't call
2974         ada_build_task_list.
2975         * ada-lang.h (ada_build_task_list): Don't declare.
2976         * ada-tasks.c (struct ada_tasks_inferior_data)
2977         <task_list_valid_p>: Now bool.
2978         (read_known_tasks, ada_task_list_changed)
2979         (ada_tasks_invalidate_inferior_data): Update.
2980         (read_known_tasks_array): Return bool.
2981         (read_known_tasks_list): Likewise.
2982         (read_known_tasks): Return void.
2983         (ada_build_task_list): Now static.
2984
2985 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2986
2987         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2988         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2989
2990 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2991
2992         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2993         variant for ada_tasks_pspace_data_handle and
2994         ada_tasks_inferior_data_handle.
2995         (ada_tasks_pspace_data_cleanup): New function.
2996         (ada_tasks_inferior_data_cleanup): New function.
2997
2998 2019-02-17  Tom Tromey  <tom@tromey.com>
2999
3000         * macrotab.h (macro_source_fullname): Return a std::string.
3001         * macrotab.c (macro_include, check_for_redefinition)
3002         (macro_undef, macro_lookup_definition, foreach_macro)
3003         (foreach_macro_in_scope): Update.
3004         (macro_source_fullname): Return a std::string.
3005         * macrocmd.c (show_pp_source_pos): Update.
3006
3007 2019-02-17  Tom Tromey  <tom@tromey.com>
3008
3009         * macrocmd.c (show_pp_source_pos): Style the file names.
3010
3011 2019-02-17  Tom Tromey  <tom@tromey.com>
3012
3013         PR tui/24197:
3014         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3015
3016 2019-02-17  Tom Tromey  <tom@tromey.com>
3017
3018         * ada-lang.c (user_select_syms): Use filtered printing.
3019         * utils.c (wrap_style): New global.
3020         (desired_style): Remove.
3021         (emit_style_escape): Add stream parameter.
3022         (set_output_style, reset_terminal_style, prompt_for_continue):
3023         Update.
3024         (flush_wrap_buffer): Only flush gdb_stdout.
3025         (wrap_here): Set wrap_style.
3026         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3027         treat escape sequences as a character.  Change when wrap buffer is
3028         flushed.
3029         (fputs_styled): Do not set the output style when the default is
3030         requested.
3031         * ui-style.h (struct ui_file_style) <is_default>: New method.
3032         * source.c (print_source_lines_base): Emit escape sequences in one
3033         piece.
3034
3035 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3036
3037         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3038         integers and enumeration types.
3039
3040 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3041
3042         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3043         instead of lookup_symbol_in_language
3044         (do_exact_match): New function.
3045         (ada_get_symbol_name_matcher): Return do_exact_match when
3046         doing a verbatim match.
3047
3048 2019-02-15  Tom Tromey  <tromey@adacore.com>
3049
3050         * ravenscar-thread.c (ravenscar_thread_target::resume)
3051         (ravenscar_thread_target::wait): Special case wildcard requests.
3052
3053 2019-02-15  Tom Tromey  <tromey@adacore.com>
3054
3055         * ravenscar-thread.c (base_ptid): Remove.
3056         (struct ravenscar_thread_target) <close>: New method.
3057         <m_base_ptid>: New member.
3058         <update_inferior_ptid, active_task, task_is_currently_active,
3059         runtime_initialized>: Declare methods.
3060         <ravenscar_thread_target>: Add constructor.
3061         (ravenscar_thread_target::task_is_currently_active)
3062         (ravenscar_thread_target::update_inferior_ptid)
3063         (ravenscar_runtime_initialized): Rename.  Now methods.
3064         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3065         (ravenscar_thread_target::update_thread_list): Update.
3066         (ravenscar_thread_target::active_task): Now method.
3067         (ravenscar_thread_target::store_registers)
3068         (ravenscar_thread_target::prepare_to_store)
3069         (ravenscar_thread_target::prepare_to_store)
3070         (ravenscar_thread_target::mourn_inferior): Update.
3071         (ravenscar_inferior_created): Use "new" to create target.
3072         (ravenscar_thread_target::get_ada_task_ptid): Update.
3073         (_initialize_ravenscar): Don't initialize base_ptid.
3074         (ravenscar_ops): Remove global.
3075
3076 2019-02-15  Tom Tromey  <tromey@adacore.com>
3077
3078         * target.h (push_target): Declare new overload.
3079         * target.c (push_target): New overload, taking an rvalue reference.
3080         * remote.c (remote_target::open_1): Use push_target overload.
3081         * corelow.c (core_target_open): Use push_target overload.
3082
3083 2019-02-15  Tom Tromey  <tromey@adacore.com>
3084
3085         * ravenscar-thread.c (is_ravenscar_task)
3086         (ravenscar_task_is_currently_active): Return bool.
3087         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3088         (_initialize_ravenscar): Remove "(void)".
3089         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3090         Return bool.
3091
3092 2019-02-15  Tom Tromey  <tromey@adacore.com>
3093
3094         * ravenscar-thread.c (ravenscar_runtime_initializer)
3095         (has_ravenscar_runtime, get_running_thread_id)
3096         (ravenscar_thread_target::resume): Fix indentation.
3097
3098 2019-02-15  Tom Tromey  <tromey@adacore.com>
3099
3100         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3101         from ravenscar_arch_ops.
3102         (sparc_ravenscar_ops::fetch_registers)
3103         (sparc_ravenscar_ops::store_registers): Now methods.
3104         (sparc_ravenscar_prepare_to_store): Remove.
3105         (sparc_ravenscar_ops): Redefine.
3106         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3107         methods and destructor.  Remove members.
3108         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3109         (ravenscar_thread_target::store_registers)
3110         (ravenscar_thread_target::prepare_to_store): Update.
3111         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3112         Remove.
3113         (struct ppc_ravenscar_powerpc_ops): Derive from
3114         ravenscar_arch_ops.
3115         (ppc_ravenscar_powerpc_ops::fetch_registers)
3116         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3117         (ppc_ravenscar_powerpc_ops): Redefine.
3118         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3119         (ppc_ravenscar_e500_ops::fetch_registers)
3120         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3121         (ppc_ravenscar_e500_ops): Redefine.
3122         * aarch64-ravenscar-thread.c
3123         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3124         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3125         (aarch64_ravenscar_fetch_registers)
3126         (aarch64_ravenscar_store_registers): Now methods.
3127         (aarch64_ravenscar_ops): Redefine.
3128
3129 2019-02-15  Tom Tromey  <tromey@adacore.com>
3130
3131         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3132         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3133         (ravenscar_thread_target::stopped_by_watchpoint)
3134         (ravenscar_thread_target::stopped_data_address)
3135         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3136
3137 2019-02-15  Tom Tromey  <tromey@adacore.com>
3138
3139         * ravenscar-thread.c: Fix some typos.
3140
3141 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3142             Tom Tromey  <tromey@adacore.com>
3143
3144         * ada-lang.c (ada_exception_sal): Change addr_string to a
3145         std::string.
3146         (create_ada_exception_catchpoint): Update.
3147
3148 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3149             Tom Tromey  <tromey@adacore.com>
3150
3151         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3152         (bp_location_ops): Remove.
3153         (base_breakpoint_allocate_location): Update.
3154         (free_bp_location): Update.
3155         * ada-lang.c (class ada_catchpoint_location)
3156         <ada_catchpoint_location>: Remove ops parameter.
3157         (ada_catchpoint_location_dtor): Remove.
3158         (ada_catchpoint_location_ops): Remove.
3159         (allocate_location_exception): Update.
3160         * breakpoint.h (struct bp_location_ops): Remove.
3161         (class bp_location) <bp_location>: Remove bp_location_ops
3162         parameter.
3163         <~bp_location>: Add destructor.
3164         <ops>: Remove.
3165
3166 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3167             Pedro Alves  <palves@redhat.com>
3168
3169         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3170         'PATH_MAX'.
3171
3172 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3173             Samuel Thibault  <samuel.thibault@gnu.org>
3174             Thomas Schwinge  <thomas@codesourcery.com>
3175
3176         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3177         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3178
3179 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3180
3181         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3182         (check_empty): Use "const char *".
3183
3184         * gnu-nat.c (gnu_nat_target::detach): Instead of
3185         'detach_inferior (pid)' call
3186         'detach_inferior (find_inferior_pid (pid))'.
3187
3188         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3189         'nat/fork-inferior.o'.
3190         * gnu-nat.c: #include "nat/fork-inferior.h".
3191
3192         * gnu-nat.c (gnu_nat_target::detach): Instead of
3193         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3194         * gnu-nat.h: #include "inf-child.h".
3195         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3196         'i386_gnu_nat_target::fetch_registers'.
3197         (gnu_store_registers): Rename/move to
3198         'i386_gnu_nat_target::store_registers'.
3199
3200         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3201         * gnu-nat.h (mach_thread_info): New function.
3202         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3203
3204         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3205
3206 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3207
3208         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3209
3210 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3211
3212         * windows-nat.c (windows_add_thread): Add new parameter
3213         "main_thread_p" with default value set to false.  Update
3214         function documentation as well as all callers.
3215         (windows_delete_thread): Likewise.
3216         (fake_create_process): Update call to windows_add_thread.
3217         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3218         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3219         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3220         call to windows_delete_thread.
3221
3222 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3223
3224         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3225
3226 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3227
3228         * symfile.c (find_separate_debug_file): Use canonical path of
3229         sysroot with child_path instead of gdb_sysroot if it is valid.
3230
3231 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3232
3233         * symfile.c (find_separate_debug_file): Use child_path to
3234         determine if an object file is under a sysroot.
3235
3236 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3237
3238         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3239         unittests/child-path-selftests.c.
3240         * common/pathstuff.c (child_path): New function.
3241         * common/pathstuff.h (child_path): New prototype.
3242         * unittests/child-path-selftests.c: New file.
3243
3244 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3245
3246         * symfile.c (find_separate_debug_file): Look for separate debug
3247         files in debug directories under the sysroot.
3248
3249 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3250
3251         * symtab.h (struct minimal_symbol data_p): New const method.
3252         (struct minimal_symbol text_p): Likewise.
3253         * symtab.c (output_source_filename): Use file name style
3254         to print file name.
3255         (print_symbol_info): Likewise.
3256         (print_msymbol_info): Use address style to print addresses.
3257         Use function name style to print executable text symbols.
3258         (expand_symtab_containing_pc): Use data_p.
3259         (find_pc_sect_compunit_symtab): Likewise.
3260
3261 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3262
3263         * breakpoint.c (describe_other_breakpoints): Use address style
3264         to print addresses.
3265         (say_where): Likewise.
3266
3267 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3268
3269         * ada-typeprint.c (print_func_type): Print function name
3270         style to print function name.
3271         * c-typeprint.c (c_print_type_1): Likewise.
3272
3273 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3274
3275         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3276         for execve.
3277
3278 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3279
3280         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3281         type_stack.
3282
3283 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3284
3285         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3286         TYPE_CODE_REF types.
3287
3288 2019-02-08  Jim Wilson  <jimw@sifive.com>
3289
3290         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3291         (riscv_linux_fregset): New.
3292         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3293
3294 2019-02-07  Tom Tromey  <tom@tromey.com>
3295
3296         * thread.c (thread_cancel_execution_command): Update.
3297         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3298         methods.
3299         (struct thread_fsm_ops): Remove.
3300         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3301         (thread_fsm_should_stop, thread_fsm_return_value)
3302         (thread_fsm_set_finished, thread_fsm_finished_p)
3303         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3304         Don't declare.
3305         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3306         * infrun.c (clear_proceed_status_thread)
3307         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3308         (print_stop_event): Update.
3309         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3310         Add constructor.
3311         (step_command_fsm_ops): Remove.
3312         (new_step_command_fsm): Remove.
3313         (step_1): Update.
3314         (step_command_fsm::should_stop): Rename from
3315         step_command_fsm_should_stop.
3316         (step_command_fsm::clean_up): Rename from
3317         step_command_fsm_clean_up.
3318         (step_command_fsm::do_async_reply_reason): Rename from
3319         step_command_fsm_async_reply_reason.
3320         (struct until_next_fsm): Inherit from thread_fsm.  Add
3321         constructor.
3322         (until_next_fsm_ops): Remove.
3323         (new_until_next_fsm): Remove.
3324         (until_next_fsm::should_stop): Rename from
3325         until_next_fsm_should_stop.
3326         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3327         (until_next_fsm::do_async_reply_reason): Rename from
3328         until_next_fsm_async_reply_reason.
3329         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3330         constructor.  Change type of breakpoint.
3331         (finish_command_fsm_ops): Remove.
3332         (new_finish_command_fsm): Remove.
3333         (finish_command_fsm::should_stop): Rename from
3334         finish_command_fsm_should_stop.
3335         (finish_command_fsm::clean_up): Rename from
3336         finish_command_fsm_clean_up.
3337         (finish_command_fsm::return_value): Rename from
3338         finish_command_fsm_return_value.
3339         (finish_command_fsm::do_async_reply_reason): Rename from
3340         finish_command_fsm_async_reply_reason.
3341         (finish_command): Update.
3342         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3343         Add constructor.
3344         (call_thread_fsm_ops): Remove.
3345         (call_thread_fsm::call_thread_fsm): Rename from
3346         new_call_thread_fsm.
3347         (call_thread_fsm::should_stop): Rename from
3348         call_thread_fsm_should_stop.
3349         (call_thread_fsm::should_notify_stop): Rename from
3350         call_thread_fsm_should_notify_stop.
3351         (run_inferior_call, call_function_by_hand_dummy): Update.
3352         * cli/cli-interp.c (should_print_stop_to_console): Update.
3353         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3354         Add constructor.  Change type of location_breakpoint,
3355         caller_breakpoint.
3356         (until_break_fsm_ops): Remove.
3357         (new_until_break_fsm): Remove.
3358         (until_break_fsm::should_stop): Rename from
3359         until_break_fsm_should_stop.
3360         (until_break_fsm::clean_up): Rename from
3361         until_break_fsm_clean_up.
3362         (until_break_fsm::do_async_reply_reason): Rename from
3363         until_break_fsm_async_reply_reason.
3364         (until_break_command): Update.
3365         * thread-fsm.c: Remove.
3366         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3367
3368 2019-02-07  Tom Tromey  <tom@tromey.com>
3369
3370         * yy-remap.h: Add include guard.
3371         * xtensa-tdep.h: Add include guard.
3372         * xcoffread.h: Rename include guard.
3373         * varobj-iter.h: Add include guard.
3374         * tui/tui.h: Rename include guard.
3375         * tui/tui-winsource.h: Rename include guard.
3376         * tui/tui-wingeneral.h: Rename include guard.
3377         * tui/tui-windata.h: Rename include guard.
3378         * tui/tui-win.h: Rename include guard.
3379         * tui/tui-stack.h: Rename include guard.
3380         * tui/tui-source.h: Rename include guard.
3381         * tui/tui-regs.h: Rename include guard.
3382         * tui/tui-out.h: Rename include guard.
3383         * tui/tui-layout.h: Rename include guard.
3384         * tui/tui-io.h: Rename include guard.
3385         * tui/tui-hooks.h: Rename include guard.
3386         * tui/tui-file.h: Rename include guard.
3387         * tui/tui-disasm.h: Rename include guard.
3388         * tui/tui-data.h: Rename include guard.
3389         * tui/tui-command.h: Rename include guard.
3390         * tic6x-tdep.h: Add include guard.
3391         * target/waitstatus.h: Rename include guard.
3392         * target/wait.h: Rename include guard.
3393         * target/target.h: Rename include guard.
3394         * target/resume.h: Rename include guard.
3395         * target-float.h: Rename include guard.
3396         * stabsread.h: Add include guard.
3397         * rs6000-tdep.h: Add include guard.
3398         * riscv-fbsd-tdep.h: Add include guard.
3399         * regformats/regdef.h: Rename include guard.
3400         * record.h: Rename include guard.
3401         * python/python.h: Rename include guard.
3402         * python/python-internal.h: Rename include guard.
3403         * python/py-stopevent.h: Rename include guard.
3404         * python/py-ref.h: Rename include guard.
3405         * python/py-record.h: Rename include guard.
3406         * python/py-record-full.h: Rename include guard.
3407         * python/py-record-btrace.h: Rename include guard.
3408         * python/py-instruction.h: Rename include guard.
3409         * python/py-events.h: Rename include guard.
3410         * python/py-event.h: Rename include guard.
3411         * procfs.h: Add include guard.
3412         * proc-utils.h: Add include guard.
3413         * p-lang.h: Add include guard.
3414         * or1k-tdep.h: Rename include guard.
3415         * observable.h: Rename include guard.
3416         * nto-tdep.h: Rename include guard.
3417         * nat/x86-linux.h: Rename include guard.
3418         * nat/x86-linux-dregs.h: Rename include guard.
3419         * nat/x86-gcc-cpuid.h: Add include guard.
3420         * nat/x86-dregs.h: Rename include guard.
3421         * nat/x86-cpuid.h: Rename include guard.
3422         * nat/ppc-linux.h: Rename include guard.
3423         * nat/mips-linux-watch.h: Rename include guard.
3424         * nat/linux-waitpid.h: Rename include guard.
3425         * nat/linux-ptrace.h: Rename include guard.
3426         * nat/linux-procfs.h: Rename include guard.
3427         * nat/linux-osdata.h: Rename include guard.
3428         * nat/linux-nat.h: Rename include guard.
3429         * nat/linux-namespaces.h: Rename include guard.
3430         * nat/linux-btrace.h: Rename include guard.
3431         * nat/glibc_thread_db.h: Rename include guard.
3432         * nat/gdb_thread_db.h: Rename include guard.
3433         * nat/gdb_ptrace.h: Rename include guard.
3434         * nat/fork-inferior.h: Rename include guard.
3435         * nat/amd64-linux-siginfo.h: Rename include guard.
3436         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3437         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3438         * nat/aarch64-linux.h: Rename include guard.
3439         * nat/aarch64-linux-hw-point.h: Rename include guard.
3440         * mn10300-tdep.h: Add include guard.
3441         * mips-linux-tdep.h: Add include guard.
3442         * mi/mi-parse.h: Rename include guard.
3443         * mi/mi-out.h: Rename include guard.
3444         * mi/mi-main.h: Rename include guard.
3445         * mi/mi-interp.h: Rename include guard.
3446         * mi/mi-getopt.h: Rename include guard.
3447         * mi/mi-console.h: Rename include guard.
3448         * mi/mi-common.h: Rename include guard.
3449         * mi/mi-cmds.h: Rename include guard.
3450         * mi/mi-cmd-break.h: Rename include guard.
3451         * m2-lang.h: Add include guard.
3452         * location.h: Rename include guard.
3453         * linux-record.h: Rename include guard.
3454         * linux-nat.h: Add include guard.
3455         * linux-fork.h: Add include guard.
3456         * i386-darwin-tdep.h: Rename include guard.
3457         * hppa-linux-offsets.h: Add include guard.
3458         * guile/guile.h: Rename include guard.
3459         * guile/guile-internal.h: Rename include guard.
3460         * gnu-nat.h: Rename include guard.
3461         * gdb-stabs.h: Rename include guard.
3462         * frv-tdep.h: Add include guard.
3463         * f-lang.h: Add include guard.
3464         * event-loop.h: Add include guard.
3465         * darwin-nat.h: Rename include guard.
3466         * cp-abi.h: Rename include guard.
3467         * config/sparc/nm-sol2.h: Rename include guard.
3468         * config/nm-nto.h: Rename include guard.
3469         * config/nm-linux.h: Add include guard.
3470         * config/i386/nm-i386gnu.h: Rename include guard.
3471         * config/djgpp/nl_types.h: Rename include guard.
3472         * config/djgpp/langinfo.h: Rename include guard.
3473         * compile/gcc-cp-plugin.h: Add include guard.
3474         * compile/gcc-c-plugin.h: Add include guard.
3475         * compile/compile.h: Rename include guard.
3476         * compile/compile-object-run.h: Rename include guard.
3477         * compile/compile-object-load.h: Rename include guard.
3478         * compile/compile-internal.h: Rename include guard.
3479         * compile/compile-cplus.h: Rename include guard.
3480         * compile/compile-c.h: Rename include guard.
3481         * common/xml-utils.h: Rename include guard.
3482         * common/x86-xstate.h: Rename include guard.
3483         * common/version.h: Rename include guard.
3484         * common/vec.h: Rename include guard.
3485         * common/tdesc.h: Rename include guard.
3486         * common/selftest.h: Rename include guard.
3487         * common/scoped_restore.h: Rename include guard.
3488         * common/scoped_mmap.h: Rename include guard.
3489         * common/scoped_fd.h: Rename include guard.
3490         * common/safe-iterator.h: Rename include guard.
3491         * common/run-time-clock.h: Rename include guard.
3492         * common/refcounted-object.h: Rename include guard.
3493         * common/queue.h: Rename include guard.
3494         * common/ptid.h: Rename include guard.
3495         * common/print-utils.h: Rename include guard.
3496         * common/preprocessor.h: Rename include guard.
3497         * common/pathstuff.h: Rename include guard.
3498         * common/observable.h: Rename include guard.
3499         * common/netstuff.h: Rename include guard.
3500         * common/job-control.h: Rename include guard.
3501         * common/host-defs.h: Rename include guard.
3502         * common/gdb_wait.h: Rename include guard.
3503         * common/gdb_vecs.h: Rename include guard.
3504         * common/gdb_unlinker.h: Rename include guard.
3505         * common/gdb_unique_ptr.h: Rename include guard.
3506         * common/gdb_tilde_expand.h: Rename include guard.
3507         * common/gdb_sys_time.h: Rename include guard.
3508         * common/gdb_string_view.h: Rename include guard.
3509         * common/gdb_splay_tree.h: Rename include guard.
3510         * common/gdb_setjmp.h: Rename include guard.
3511         * common/gdb_ref_ptr.h: Rename include guard.
3512         * common/gdb_optional.h: Rename include guard.
3513         * common/gdb_locale.h: Rename include guard.
3514         * common/gdb_assert.h: Rename include guard.
3515         * common/filtered-iterator.h: Rename include guard.
3516         * common/filestuff.h: Rename include guard.
3517         * common/fileio.h: Rename include guard.
3518         * common/environ.h: Rename include guard.
3519         * common/common-utils.h: Rename include guard.
3520         * common/common-types.h: Rename include guard.
3521         * common/common-regcache.h: Rename include guard.
3522         * common/common-inferior.h: Rename include guard.
3523         * common/common-gdbthread.h: Rename include guard.
3524         * common/common-exceptions.h: Rename include guard.
3525         * common/common-defs.h: Rename include guard.
3526         * common/common-debug.h: Rename include guard.
3527         * common/cleanups.h: Rename include guard.
3528         * common/buffer.h: Rename include guard.
3529         * common/btrace-common.h: Rename include guard.
3530         * common/break-common.h: Rename include guard.
3531         * cli/cli-utils.h: Rename include guard.
3532         * cli/cli-style.h: Rename include guard.
3533         * cli/cli-setshow.h: Rename include guard.
3534         * cli/cli-script.h: Rename include guard.
3535         * cli/cli-interp.h: Rename include guard.
3536         * cli/cli-decode.h: Rename include guard.
3537         * cli/cli-cmds.h: Rename include guard.
3538         * charset-list.h: Add include guard.
3539         * buildsym-legacy.h: Rename include guard.
3540         * bfin-tdep.h: Add include guard.
3541         * ax.h: Rename include guard.
3542         * arm-linux-tdep.h: Add include guard.
3543         * arm-fbsd-tdep.h: Add include guard.
3544         * arch/xtensa.h: Rename include guard.
3545         * arch/tic6x.h: Add include guard.
3546         * arch/i386.h: Add include guard.
3547         * arch/arm.h: Rename include guard.
3548         * arch/arm-linux.h: Rename include guard.
3549         * arch/arm-get-next-pcs.h: Rename include guard.
3550         * arch/amd64.h: Add include guard.
3551         * arch/aarch64-insn.h: Rename include guard.
3552         * arch-utils.h: Rename include guard.
3553         * annotate.h: Add include guard.
3554         * amd64-darwin-tdep.h: Rename include guard.
3555         * aarch64-linux-tdep.h: Add include guard.
3556         * aarch64-fbsd-tdep.h: Add include guard.
3557         * aarch32-linux-nat.h: Add include guard.
3558
3559 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3560
3561         * macrotab.c (macro_define_internal): New function that
3562         factorizes macro_define_object_internal and macro_define_function
3563         code.
3564         (macro_define_object_internal): Use macro_define_internal.
3565         (macro_define_function): Likewise.
3566
3567 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3568
3569         * macrocmd.c (extract_identifier): Return
3570         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3571         callers.
3572
3573 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3574
3575         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3576
3577 2019-02-05  Tom Tromey  <tom@tromey.com>
3578
3579         * target.c (target_stack::unpush): Move assertion earlier.
3580
3581 2019-01-30  Tom Tromey  <tom@tromey.com>
3582
3583         PR python/23615:
3584         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3585         (gdbpy_parse_and_eval): Likewise.
3586         * python/python-internal.h (gdbpy_allow_threads): New class.
3587
3588 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3589
3590         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3591         (aarch64_fbsd_fpregmap): Move earlier.
3592         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3593         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3594         instead of individual calls to trad_frame_set_reg_addr.
3595         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3596         earlier.
3597         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3598         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3599         instead of individual calls to trad_frame_set_reg_addr.
3600
3601 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3602
3603         * CONTRIBUTE: Replace contribution list with wiki link.
3604
3605 2019-01-25  Tom Tromey  <tom@tromey.com>
3606
3607         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3608
3609 2019-01-25  Tom Tromey  <tom@tromey.com>
3610
3611         * xtensa-linux-nat.c: Fix common/ includes.
3612         * xml-support.h: Fix common/ includes.
3613         * xml-support.c: Fix common/ includes.
3614         * x86-linux-nat.c: Fix common/ includes.
3615         * windows-nat.c: Fix common/ includes.
3616         * varobj.h: Fix common/ includes.
3617         * varobj.c: Fix common/ includes.
3618         * value.c: Fix common/ includes.
3619         * valops.c: Fix common/ includes.
3620         * utils.c: Fix common/ includes.
3621         * unittests/xml-utils-selftests.c: Fix common/ includes.
3622         * unittests/utils-selftests.c: Fix common/ includes.
3623         * unittests/unpack-selftests.c: Fix common/ includes.
3624         * unittests/tracepoint-selftests.c: Fix common/ includes.
3625         * unittests/style-selftests.c: Fix common/ includes.
3626         * unittests/string_view-selftests.c: Fix common/ includes.
3627         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3628         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3629         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3630         * unittests/rsp-low-selftests.c: Fix common/ includes.
3631         * unittests/parse-connection-spec-selftests.c: Fix common/
3632         includes.
3633         * unittests/optional-selftests.c: Fix common/ includes.
3634         * unittests/offset-type-selftests.c: Fix common/ includes.
3635         * unittests/observable-selftests.c: Fix common/ includes.
3636         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3637         * unittests/memrange-selftests.c: Fix common/ includes.
3638         * unittests/memory-map-selftests.c: Fix common/ includes.
3639         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3640         * unittests/function-view-selftests.c: Fix common/ includes.
3641         * unittests/environ-selftests.c: Fix common/ includes.
3642         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3643         * unittests/common-utils-selftests.c: Fix common/ includes.
3644         * unittests/cli-utils-selftests.c: Fix common/ includes.
3645         * unittests/array-view-selftests.c: Fix common/ includes.
3646         * ui-file.c: Fix common/ includes.
3647         * tui/tui-io.c: Fix common/ includes.
3648         * tracepoint.h: Fix common/ includes.
3649         * tracepoint.c: Fix common/ includes.
3650         * tracefile-tfile.c: Fix common/ includes.
3651         * top.h: Fix common/ includes.
3652         * top.c: Fix common/ includes.
3653         * thread.c: Fix common/ includes.
3654         * target/waitstatus.h: Fix common/ includes.
3655         * target/waitstatus.c: Fix common/ includes.
3656         * target.h: Fix common/ includes.
3657         * target.c: Fix common/ includes.
3658         * target-memory.c: Fix common/ includes.
3659         * target-descriptions.c: Fix common/ includes.
3660         * symtab.h: Fix common/ includes.
3661         * symfile.c: Fix common/ includes.
3662         * stap-probe.c: Fix common/ includes.
3663         * spu-linux-nat.c: Fix common/ includes.
3664         * sparc-nat.c: Fix common/ includes.
3665         * source.c: Fix common/ includes.
3666         * solib.c: Fix common/ includes.
3667         * solib-target.c: Fix common/ includes.
3668         * ser-unix.c: Fix common/ includes.
3669         * ser-tcp.c: Fix common/ includes.
3670         * ser-pipe.c: Fix common/ includes.
3671         * ser-base.c: Fix common/ includes.
3672         * selftest-arch.c: Fix common/ includes.
3673         * s12z-tdep.c: Fix common/ includes.
3674         * rust-exp.y: Fix common/ includes.
3675         * rs6000-aix-tdep.c: Fix common/ includes.
3676         * riscv-tdep.c: Fix common/ includes.
3677         * remote.c: Fix common/ includes.
3678         * remote-notif.h: Fix common/ includes.
3679         * remote-fileio.h: Fix common/ includes.
3680         * remote-fileio.c: Fix common/ includes.
3681         * regcache.h: Fix common/ includes.
3682         * regcache.c: Fix common/ includes.
3683         * record-btrace.c: Fix common/ includes.
3684         * python/python.c: Fix common/ includes.
3685         * python/py-type.c: Fix common/ includes.
3686         * python/py-inferior.c: Fix common/ includes.
3687         * progspace.h: Fix common/ includes.
3688         * producer.c: Fix common/ includes.
3689         * procfs.c: Fix common/ includes.
3690         * proc-api.c: Fix common/ includes.
3691         * printcmd.c: Fix common/ includes.
3692         * ppc-linux-nat.c: Fix common/ includes.
3693         * parser-defs.h: Fix common/ includes.
3694         * osdata.c: Fix common/ includes.
3695         * obsd-nat.c: Fix common/ includes.
3696         * nat/x86-linux.c: Fix common/ includes.
3697         * nat/x86-linux-dregs.c: Fix common/ includes.
3698         * nat/x86-dregs.h: Fix common/ includes.
3699         * nat/x86-dregs.c: Fix common/ includes.
3700         * nat/ppc-linux.c: Fix common/ includes.
3701         * nat/mips-linux-watch.h: Fix common/ includes.
3702         * nat/mips-linux-watch.c: Fix common/ includes.
3703         * nat/linux-waitpid.c: Fix common/ includes.
3704         * nat/linux-ptrace.h: Fix common/ includes.
3705         * nat/linux-ptrace.c: Fix common/ includes.
3706         * nat/linux-procfs.c: Fix common/ includes.
3707         * nat/linux-personality.c: Fix common/ includes.
3708         * nat/linux-osdata.c: Fix common/ includes.
3709         * nat/linux-namespaces.c: Fix common/ includes.
3710         * nat/linux-btrace.h: Fix common/ includes.
3711         * nat/linux-btrace.c: Fix common/ includes.
3712         * nat/fork-inferior.c: Fix common/ includes.
3713         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3714         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3715         * nat/aarch64-linux.c: Fix common/ includes.
3716         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3717         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3718         * namespace.h: Fix common/ includes.
3719         * mips-linux-tdep.c: Fix common/ includes.
3720         * minsyms.c: Fix common/ includes.
3721         * mi/mi-parse.h: Fix common/ includes.
3722         * mi/mi-main.c: Fix common/ includes.
3723         * mi/mi-cmd-env.c: Fix common/ includes.
3724         * memrange.h: Fix common/ includes.
3725         * memattr.c: Fix common/ includes.
3726         * maint.h: Fix common/ includes.
3727         * maint.c: Fix common/ includes.
3728         * main.c: Fix common/ includes.
3729         * machoread.c: Fix common/ includes.
3730         * location.c: Fix common/ includes.
3731         * linux-thread-db.c: Fix common/ includes.
3732         * linux-nat.c: Fix common/ includes.
3733         * linux-fork.c: Fix common/ includes.
3734         * inline-frame.c: Fix common/ includes.
3735         * infrun.c: Fix common/ includes.
3736         * inflow.c: Fix common/ includes.
3737         * inferior.h: Fix common/ includes.
3738         * inferior.c: Fix common/ includes.
3739         * infcmd.c: Fix common/ includes.
3740         * inf-ptrace.c: Fix common/ includes.
3741         * inf-child.c: Fix common/ includes.
3742         * ia64-linux-nat.c: Fix common/ includes.
3743         * i387-tdep.c: Fix common/ includes.
3744         * i386-tdep.c: Fix common/ includes.
3745         * i386-linux-tdep.c: Fix common/ includes.
3746         * i386-linux-nat.c: Fix common/ includes.
3747         * i386-go32-tdep.c: Fix common/ includes.
3748         * i386-fbsd-tdep.c: Fix common/ includes.
3749         * i386-fbsd-nat.c: Fix common/ includes.
3750         * guile/scm-type.c: Fix common/ includes.
3751         * guile/guile.c: Fix common/ includes.
3752         * go32-nat.c: Fix common/ includes.
3753         * gnu-nat.c: Fix common/ includes.
3754         * gdbthread.h: Fix common/ includes.
3755         * gdbarch-selftests.c: Fix common/ includes.
3756         * gdb_usleep.c: Fix common/ includes.
3757         * gdb_select.h: Fix common/ includes.
3758         * gdb_bfd.c: Fix common/ includes.
3759         * gcore.c: Fix common/ includes.
3760         * fork-child.c: Fix common/ includes.
3761         * findvar.c: Fix common/ includes.
3762         * fbsd-nat.c: Fix common/ includes.
3763         * event-top.c: Fix common/ includes.
3764         * event-loop.c: Fix common/ includes.
3765         * dwarf2read.c: Fix common/ includes.
3766         * dwarf2loc.c: Fix common/ includes.
3767         * dwarf2-frame.c: Fix common/ includes.
3768         * dwarf-index-cache.c: Fix common/ includes.
3769         * dtrace-probe.c: Fix common/ includes.
3770         * disasm-selftests.c: Fix common/ includes.
3771         * defs.h: Fix common/ includes.
3772         * csky-tdep.c: Fix common/ includes.
3773         * cp-valprint.c: Fix common/ includes.
3774         * cp-support.h: Fix common/ includes.
3775         * cp-support.c: Fix common/ includes.
3776         * corelow.c: Fix common/ includes.
3777         * completer.h: Fix common/ includes.
3778         * completer.c: Fix common/ includes.
3779         * compile/compile.c: Fix common/ includes.
3780         * compile/compile-loc2c.c: Fix common/ includes.
3781         * compile/compile-cplus-types.c: Fix common/ includes.
3782         * compile/compile-cplus-symbols.c: Fix common/ includes.
3783         * command.h: Fix common/ includes.
3784         * cli/cli-dump.c: Fix common/ includes.
3785         * cli/cli-cmds.c: Fix common/ includes.
3786         * charset.c: Fix common/ includes.
3787         * build-id.c: Fix common/ includes.
3788         * btrace.h: Fix common/ includes.
3789         * btrace.c: Fix common/ includes.
3790         * breakpoint.h: Fix common/ includes.
3791         * breakpoint.c: Fix common/ includes.
3792         * ax.h:
3793         (enum agent_op): Fix common/ includes.
3794         * ax-general.c (struct aop_map): Fix common/ includes.
3795         * ax-gdb.c: Fix common/ includes.
3796         * auxv.c: Fix common/ includes.
3797         * auto-load.c: Fix common/ includes.
3798         * arm-tdep.c: Fix common/ includes.
3799         * arch/riscv.c: Fix common/ includes.
3800         * arch/ppc-linux-common.c: Fix common/ includes.
3801         * arch/i386.c: Fix common/ includes.
3802         * arch/arm.c: Fix common/ includes.
3803         * arch/arm-linux.c: Fix common/ includes.
3804         * arch/arm-get-next-pcs.c: Fix common/ includes.
3805         * arch/amd64.c: Fix common/ includes.
3806         * arch/aarch64.c: Fix common/ includes.
3807         * arch/aarch64-insn.c: Fix common/ includes.
3808         * arch-utils.c: Fix common/ includes.
3809         * amd64-windows-tdep.c: Fix common/ includes.
3810         * amd64-tdep.c: Fix common/ includes.
3811         * amd64-sol2-tdep.c: Fix common/ includes.
3812         * amd64-obsd-tdep.c: Fix common/ includes.
3813         * amd64-nbsd-tdep.c: Fix common/ includes.
3814         * amd64-linux-tdep.c: Fix common/ includes.
3815         * amd64-linux-nat.c: Fix common/ includes.
3816         * amd64-fbsd-tdep.c: Fix common/ includes.
3817         * amd64-fbsd-nat.c: Fix common/ includes.
3818         * amd64-dicos-tdep.c: Fix common/ includes.
3819         * amd64-darwin-tdep.c: Fix common/ includes.
3820         * agent.c: Fix common/ includes.
3821         * ada-lang.h: Fix common/ includes.
3822         * ada-lang.c: Fix common/ includes.
3823         * aarch64-tdep.c: Fix common/ includes.
3824
3825 2019-01-25  Tom Tromey  <tom@tromey.com>
3826
3827         * common/create-version.sh: Use common/version.h.
3828
3829 2019-01-24  Pedro Alves  <palves@redhat.com>
3830
3831         * infrun.c (signal_stop, signal_print, signal_program)
3832         (signal_catch, signal_pass): Now arrays instead of pointers.
3833         (update_signals_program_target, do_target_resume)
3834         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3835         * linux-nat.c (linux_nat_target::pass_signals)
3836         (linux_nat_target::create_inferior, linux_nat_target::attach):
3837         Adjust.
3838         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3839         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3840         * procfs.c (procfs_target::pass_signals): Adjust.
3841         * record-full.c (record_full_target::resume): Adjust.
3842         * remote.c (remote_target::pass_signals)
3843         (remote_target::program_signals): Adjust.
3844         * target-debug.h (target_debug_print_signals): Now takes a
3845         gdb::array_view as parameter.  Adjust.
3846         * target.h (target_ops) <pass_signals, program_signals>: Replace
3847         pointer and length parameters with gdb::array_view.
3848         (target_pass_signals, target_program_signals): Likewise.
3849         * target-delegates.c: Regenerate.
3850
3851 2019-01-24  Pedro Alves  <palves@redhat.com>
3852
3853         * common/forward-scope-exit.h
3854         (forward_scope_exit::forward_scope_exit): Pass arguments to
3855         m_bind_function directly, instead of creating a std::bind and
3856         copying that.
3857
3858 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3859
3860         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3861         for static members.
3862         (pass_in_v_vfp_candidate): Likewise.
3863
3864 2019-01-23  Tom Tromey  <tom@tromey.com>
3865             Pedro Alves  <palves@redhat.com>
3866
3867         * regcache.c (class regcache_invalidator): Remove.
3868         (regcache::raw_write): Use make_scope_exit.
3869
3870 2019-01-23  Tom Tromey  <tom@tromey.com>
3871
3872         * ui-out.h (class ui_out_emit_type): Update comment.
3873
3874 2019-01-23  Tom Tromey  <tom@tromey.com>
3875
3876         * infrun.c (fetch_inferior_event): Update comment.
3877
3878 2019-01-23  Tom Tromey  <tom@tromey.com>
3879             Pedro Alves  <palves@redhat.com>
3880
3881         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3882         parameter.
3883         (fetch_inferior_event): Use SCOPE_EXIT.
3884
3885
3886 2019-01-23  Tom Tromey  <tom@tromey.com>
3887             Pedro Alves  <palves@redhat.com>
3888
3889         * infrun.c (disable_thread_events): Delete.
3890         (stop_all_threads): Use SCOPE_EXIT.
3891
3892 2019-01-23  Tom Tromey  <tom@tromey.com>
3893             Pedro Alves  <palves@redhat.com>
3894
3895         * symfile.c: Include forward-scope-exit.h.
3896         (clear_symtab_users_cleanup): Replace forward declaration with
3897         a FORWARD_SCOPE_EXIT.
3898         (syms_from_objfile_1): Use the forward_scope_exit and
3899         gdb::optional instead of cleanup_function.
3900         (reread_symbols): Use the forward_scope_exit instead of
3901         cleanup_function.
3902         (clear_symtab_users_cleanup): Remove function.
3903
3904 2019-01-23  Tom Tromey  <tom@tromey.com>
3905             Pedro Alves  <palves@redhat.com>
3906
3907         * linux-nat.c: Include scope-exit.h.
3908         (cleanup_target_stop): Remove.
3909         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3910         SCOPE_EXIT.
3911
3912 2019-01-23  Tom Tromey  <tom@tromey.com>
3913             Pedro Alves  <palves@redhat.com>
3914
3915         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3916         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3917
3918 2019-01-23  Tom Tromey  <tom@tromey.com>
3919             Andrew Burgess  <andrew.burgess@embecosm.com>
3920             Pedro Alves  <palves@redhat.com>
3921
3922         * infrun.c (fetch_inferior_event): Use scope_exit.
3923         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3924         * top.c (execute_command): Use scope_exit.
3925         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3926         * utils.c (do_bpstat_clear_actions_cleanup)
3927         (make_bpstat_clear_actions_cleanup): Remove.
3928
3929 2019-01-23  Tom Tromey  <tom@tromey.com>
3930             Pedro Alves  <palves@redhat.com>
3931
3932         * infrun.c: Include "common/scope-exit.h"
3933         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3934         (wait_for_inferior): Use SCOPE_EXIT.
3935         (fetch_inferior_event): Use scope_exit.
3936
3937 2019-01-23  Tom Tromey  <tom@tromey.com>
3938             Pedro Alves  <palves@redhat.com>
3939
3940         * breakpoint.c (create_breakpoint): Remove cleanup.
3941
3942 2019-01-23  Tom Tromey  <tom@tromey.com>
3943             Andrew Burgess  <andrew.burgess@embecosm.com>
3944             Pedro Alves  <palves@redhat.com>
3945
3946 2019-01-23  Pedro Alves  <palves@redhat.com>
3947
3948         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3949
3950 2019-01-23  Pedro Alves  <palves@redhat.com>
3951             Andrew Burgess  <andrew.burgess@embecosm.com>
3952
3953         * gdbthread.h: Include "common/forward-scope-exit.h".
3954         (scoped_finish_thread_state): Redefine custom class in terms of
3955         forward_scope_exit.
3956
3957 2019-01-23  Pedro Alves  <palves@redhat.com>
3958             Andrew Burgess  <andrew.burgess@embecosm.com>
3959
3960         * common/forward-scope-exit.h: New file.
3961
3962 2019-01-23  Pedro Alves  <palves@redhat.com>
3963             Andrew Burgess  <andrew.burgess@embecosm.com>
3964             Tom Tromey  <tom@tromey.com>
3965
3966         * common/scope-exit.h: New file.
3967
3968 2019-01-23  Pedro Alves  <palves@redhat.com>
3969
3970         * common/preprocessor.h (ESC): Rename to ...
3971         (ESC_PARENS): ... this.
3972         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3973         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3974
3975 2019-01-23  Tom Tromey  <tom@tromey.com>
3976
3977         * language.h (class scoped_switch_to_sym_language_if_auto):
3978         Initialize m_lang in both cases.
3979
3980 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3981
3982         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3983         with XCNEW.
3984
3985 2019-01-22  Tom Tromey  <tom@tromey.com>
3986
3987         * corelow.c: Do not include sys/file.h.
3988
3989 2019-01-22  Tom Tromey  <tom@tromey.com>
3990
3991         * tui/tui-wingeneral.h: Include gdb_curses.h.
3992
3993 2019-01-22  Tom Tromey  <tom@tromey.com>
3994
3995         * source-cache.h (class source_cache) <get_source_lines,
3996         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3997
3998 2019-01-22  Tom Tromey  <tom@tromey.com>
3999
4000         * remote-fileio.h (struct remote_target): Declare.
4001
4002 2019-01-22  Tom Tromey  <tom@tromey.com>
4003
4004         * python/py-arch.c: Do not include py-ref.h.
4005         * python/py-bpevent.c: Do not include py-ref.h.
4006         * python/py-cmd.c: Do not include py-ref.h.
4007         * python/py-continueevent.c: Do not include py-ref.h.
4008         * python/py-event.h: Do not include py-ref.h.
4009         * python/py-evtregistry.c: Do not include py-ref.h.
4010         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4011         * python/py-frame.c: Do not include py-ref.h.
4012         * python/py-framefilter.c: Do not include py-ref.h.
4013         * python/py-function.c: Do not include py-ref.h.
4014         * python/py-infevents.c: Do not include py-ref.h.
4015         * python/py-linetable.c: Do not include py-ref.h.
4016         * python/py-objfile.c: Do not include py-ref.h.
4017         * python/py-param.c: Do not include py-ref.h.
4018         * python/py-prettyprint.c: Do not include py-ref.h.
4019         * python/py-progspace.c: Do not include py-ref.h.
4020         * python/py-symbol.c: Do not include py-ref.h.
4021         * python/py-symtab.c: Do not include py-ref.h.
4022         * python/py-type.c: Do not include py-ref.h.
4023         * python/py-unwind.c: Do not include py-ref.h.
4024         * python/py-utils.c: Do not include py-ref.h.
4025         * python/py-value.c: Do not include py-ref.h.
4026         * python/py-varobj.c: Do not include py-ref.h.
4027         * python/py-xmethods.c: Do not include py-ref.h.
4028         * python/python.c: Do not include py-ref.h.
4029         * varobj.c: Do not include py-ref.h.
4030
4031 2019-01-22  Tom Tromey  <tom@tromey.com>
4032
4033         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4034         keyword for bcache.
4035
4036 2019-01-22  Tom Tromey  <tom@tromey.com>
4037
4038         * compile/compile-cplus-types.c: Remove a comment by #include.
4039
4040 2019-01-22  Tom Tromey  <tom@tromey.com>
4041
4042         * compile/gcc-c-plugin.h: Include compile-internal.h.
4043
4044 2019-01-22  Tom Tromey  <tom@tromey.com>
4045
4046         * stabsread.c (EXTERN): Do not define.
4047         (symnum, next_symbol_text_func, processing_gcc_compilation)
4048         (within_function, global_sym_chain, global_stabs)
4049         (previous_stab_code, this_object_header_files)
4050         (n_this_object_header_files)
4051         (n_allocated_this_object_header_files): Define.
4052         * stabsread.h (EXTERN): Never define.  Use "extern".
4053
4054 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4055
4056         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4057         history_value.
4058
4059 2019-01-21  Tom Tromey  <tom@tromey.com>
4060
4061         * ui-out.c: Fix includes.
4062         * tui/tui-source.c: Fix includes.
4063         * target.c: Fix includes.
4064         * remote.c: Fix includes.
4065         * regcache.c: Fix includes.
4066         * python/py-block.c: Fix includes.
4067         * printcmd.c: Fix includes.
4068         * or1k-tdep.c: Fix includes.
4069         * mi/mi-main.c: Fix includes.
4070         * m32r-tdep.c: Fix includes.
4071         * csky-tdep.c: Fix includes.
4072         * compile/compile-cplus-types.c: Fix includes.
4073         * cli/cli-interp.c: Fix includes.
4074
4075 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4076
4077         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4078         for padding.
4079
4080 2019-01-16  Tom Tromey  <tom@tromey.com>
4081
4082         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4083         earlier.
4084         (struct objfile) <msymbols_range>: Move from top level.
4085         <msymbols>: New method.
4086         (class objfile_msymbols): Remove.
4087         * symtab.c (default_collect_symbol_completion_matches_break_on):
4088         Update.
4089         * symmisc.c (dump_msymbols): Update.
4090         * stabsread.c (scan_file_globals): Update.
4091         * objc-lang.c (info_selectors_command, info_classes_command)
4092         (find_methods): Update.
4093         * minsyms.c (find_solib_trampoline_target): Update.
4094         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4095         * coffread.c (coff_symfile_read): Update.
4096         * ada-lang.c (ada_lookup_simple_minsym)
4097         (ada_collect_symbol_completion_matches): Update.
4098
4099 2019-01-16  Tom Tromey  <tom@tromey.com>
4100
4101         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4102         type.  Remove no-argument constructor.
4103         <iterator::operator++>: Simplify.
4104         <begin>: Update.
4105         <end>: Use minimal_symbol_count.
4106
4107 2019-01-16  Tom Tromey  <tom@tromey.com>
4108
4109         * objfiles.h (struct objfile) <psymtabs>: New method.
4110         (class objfile_psymtabs): Remove.
4111         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4112         typedef.
4113         <range>: New method.
4114         (require_partial_symbols): Change return type.
4115         * psymtab.c (require_partial_symbols)
4116         (psym_expand_symtabs_matching): Update.
4117         * mdebugread.c (parse_partial_symbols): Update.
4118         * dbxread.c (dbx_end_psymtab): Update.
4119
4120 2019-01-15  Tom Tromey  <tom@tromey.com>
4121
4122         * symtab.c (lookup_objfile_from_block)
4123         (lookup_symbol_in_objfile_symtabs)
4124         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4125         (find_line_symtab, info_sources_command)
4126         (default_collect_symbol_completion_matches_break_on)
4127         (make_source_files_completion_list): Update.
4128         * symmisc.c (print_objfile_statistics, dump_objfile)
4129         (maintenance_print_symbols, maintenance_info_symtabs)
4130         (maintenance_check_symtabs, maintenance_info_line_tables):
4131         Update.
4132         * source.c (select_source_symtab)
4133         (forget_cached_source_info_for_objfile): Update.
4134         * objfiles.h (class objfile_compunits): Remove.
4135         (struct objfile) <compunits_range>: New typedef.
4136         (compunits): New method.
4137         * objfiles.c (objfile_relocate1): Update.
4138         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4139         * maint.c (count_symtabs_and_blocks): Update.
4140         * linespec.c (iterate_over_all_matching_symtabs): Update.
4141         * cp-support.c (add_symbol_overload_list_qualified): Update.
4142         * coffread.c (coff_symtab_read): Update.
4143         * ada-lang.c (add_nonlocal_symbols)
4144         (ada_collect_symbol_completion_matches)
4145         (ada_add_global_exceptions): Update.
4146
4147 2019-01-15  Tom Tromey  <tom@tromey.com>
4148
4149         * progspace.h (program_space) <objfiles_safe_range>: New
4150         typedef.
4151         <objfiles_safe>: New method.
4152         * objfiles.h (class all_objfiles_safe): Remove.
4153         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4154         * jit.c (jit_inferior_exit_hook): Update.
4155
4156 2019-01-17  Tom Tromey  <tom@tromey.com>
4157
4158         * progspace.h (program_space) <objfiles_range>: New typedef.
4159         <objfiles>: New method.
4160         <objfiles_head>: Rename from objfiles.
4161         (object_files): Update.
4162         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4163         * guile/scm-pretty-print.c
4164         (ppscm_find_pretty_printer_from_objfiles): Update.
4165         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4166         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4167         Update.
4168         * python/py-progspace.c (pspy_get_objfiles): Update.
4169         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4170         Update.
4171         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4172         (objfpy_lookup_objfile_by_build_id): Update.
4173         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4174         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4175         Update.
4176         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4177         (expand_symtab_containing_pc, lookup_objfile_from_block)
4178         (lookup_static_symbol, basic_lookup_transparent_type)
4179         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4180         (find_line_symtab, info_sources_command)
4181         (default_collect_symbol_completion_matches_break_on)
4182         (make_source_files_completion_list, find_main_name): Update.
4183         * symmisc.c (print_symbol_bcache_statistics)
4184         (print_objfile_statistics, maintenance_print_symbols)
4185         (maintenance_print_msymbols, maintenance_print_objfiles)
4186         (maintenance_info_symtabs, maintenance_check_symtabs)
4187         (maintenance_expand_symtabs, maintenance_info_line_tables):
4188         Update.
4189         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4190         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4191         (map_overlay_command, unmap_overlay_command)
4192         (simple_overlay_update, expand_symtabs_matching)
4193         (map_symbol_filenames): Update.
4194         * symfile-debug.c (set_debug_symfile): Update.
4195         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4196         Update.
4197         * source.c (select_source_symtab, forget_cached_source_info):
4198         Update.
4199         * solib.c (solib_read_symbols): Update.
4200         * solib-spu.c (append_ocl_sos): Update.
4201         * psymtab.c (maintenance_print_psymbols)
4202         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4203         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4204         * printcmd.c (info_symbol_command): Update.
4205         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4206         Update.
4207         * objfiles.h (class all_objfiles): Remove.
4208         * objfiles.c (have_partial_symbols, have_full_symbols)
4209         (have_minimal_symbols, qsort_cmp, update_section_map)
4210         (shared_objfile_contains_address_p)
4211         (default_iterate_over_objfiles_in_search_order): Update.
4212         * objc-lang.c (info_selectors_command, info_classes_command)
4213         (find_methods): Update.
4214         * minsyms.c (find_solib_trampoline_target): Update.
4215         * maint.c (maintenance_info_sections)
4216         (maintenance_translate_address, count_symtabs_and_blocks):
4217         Update.
4218         * main.c (captured_main_1): Update.
4219         * linux-thread-db.c (try_thread_db_load_from_pdir)
4220         (has_libpthread): Update.
4221         * linespec.c (iterate_over_all_matching_symtabs)
4222         (search_minsyms_for_name): Update.
4223         * jit.c (jit_find_objf_with_entry_addr): Update.
4224         * hppa-tdep.c (find_unwind_entry)
4225         (hppa_lookup_stub_minimal_symbol): Update.
4226         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4227         Update.
4228         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4229         (elf_gnu_ifunc_resolve_by_got): Update.
4230         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4231         * dwarf-index-write.c (save_gdb_index_command): Update.
4232         * cp-support.c (add_symbol_overload_list_qualified): Update.
4233         * breakpoint.c (create_overlay_event_breakpoint)
4234         (create_longjmp_master_breakpoint)
4235         (create_std_terminate_master_breakpoint)
4236         (create_exception_master_breakpoint): Update.
4237         * blockframe.c (find_pc_partial_function): Update.
4238         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4239         (ada_collect_symbol_completion_matches)
4240         (ada_add_global_exceptions): Update.
4241
4242 2019-01-17  Tom Tromey  <tom@tromey.com>
4243
4244         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4245         declare VEC.
4246         (solib_target_parse_libraries): Change return type.
4247         (library_list_start_segment, library_list_start_section)
4248         (library_list_end_library, library_list_start_library); Update.
4249         (solib_target_free_library_list): Remove.
4250         (solib_target_parse_libraries): Remove cleanup.  Change return
4251         type.
4252         (solib_target_current_sos): Update.
4253
4254 2019-01-17  Tom Tromey  <tromey@bapiya>
4255
4256         * valprint.c: Replace "the the" with "the".
4257         * symtab.c: Replace "the the" with "the".
4258         * solib.c: Replace "the the" with "the".
4259         * solib-dsbt.c: Replace "the the" with "the".
4260         * linespec.c: Replace "the the" with "the".
4261         * dwarf2loc.h: Replace "the the" with "the".
4262         * amd64-windows-tdep.c: Replace "the the" with "the".
4263         * aarch64-tdep.c: Replace "the the" with "the".
4264
4265 2019-01-16  Keith Seitz  <keiths@redhat.com>
4266
4267         PR gdb/23773
4268         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4269         <builder>: Rename to ..
4270         <m_builder>: ... this and make private.
4271         (dwarf2_cu::get_builder): New method.  Change all users of
4272         `builder' to use this method.
4273         (dwarf2_start_symtab): Move to ...
4274         (dwarf2_cu::start_symtab): ... here.  Update all callers
4275         (setup_type_unit_groups): Move to ...
4276         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4277         callers.
4278         (dwarf2_cu::reset_builder): New method.
4279         (process_full_compunit, process_full_type_unit): Use
4280         dwarf2_cu::reset_builder.
4281         (follow_die_offset): Record the ancestor CU if it is different
4282         from the followed DIE's CU.
4283         (follow_die_sig_1): Likewise.
4284
4285 2019-01-15  Tom Tromey  <tom@tromey.com>
4286
4287         * remote.c (class remote_state) <buf>: Now a char_vector.
4288         <buf_size>: Remove.
4289         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4290         parameter.
4291         (remote_target::getpkt_or_notif_sane_1)
4292         (remote_target::getpkt_sane)
4293         (remote_target::getpkt_or_notif_sane): Likewise.
4294         (class remote_target) <putpkt>: New overload.
4295         (remote_target::read_frame): Change type of "buf_p".  Remove
4296         sizeof_p parameter.
4297         (packet_ok): New overload.
4298         (packet_check_result): New overload.
4299         Update all uses.
4300
4301 2019-01-14  Tom Tromey  <tom@tromey.com>
4302
4303         * remote-notif.c (handle_notification, remote_notif_ack)
4304         (remote_notif_parse): Make "buf" const.
4305         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4306         const.
4307         (remote_notif_parse, remote_notif_ack, handle_notification):
4308         Likewise.
4309         * remote.c (remote_notif_stop_parse): Make "buf" const.
4310         (remote_target::remote_parse_stop_reply): Make "buf" const.
4311         (remote_notif_stop_ack): Make "buf" const.
4312
4313 2019-01-14  Tom Tromey  <tom@tromey.com>
4314
4315         * remote.c (remote_console_output): Make parameter const.
4316
4317 2019-01-14  Tom Tromey  <tom@tromey.com>
4318
4319         * target-debug.h (target_debug_print_signals): Constify.
4320         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4321         * procfs.c (procfs_target::pass_signals): Update.
4322         * linux-nat.c (linux_nat_target::pass_signals): Update.
4323         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4324         * target-delegates.c: Rebuild.
4325         * remote.c (remote_target::program_signals): Update.
4326         (remote_target::pass_signals): Update.
4327         * target.c (target_pass_signals): Constify argument.
4328         (target_program_signals): Likewise.
4329         * target.h (struct target_ops) <pass_signals, program_signals>:
4330         Constify argument.
4331         (target_pass_signals, target_program_signals): Constify argument.
4332
4333 2019-01-14  Tom Tromey  <tom@tromey.com>
4334
4335         PR tui/28819:
4336         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4337
4338 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4339
4340         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4341         field.
4342         * rs6000-tdep.c: Include reggroups.h.
4343         (IS_V_ALIAS_PSEUDOREG): Define.
4344         (rs6000_register_name): Return names for the "vX" aliases.
4345         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4346         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4347         aliases.  Call default_register_reggroup_p for all other
4348         pseudo-registers.
4349         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4350         New functions.
4351         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4352         Handle "vX" aliases.
4353         (v_alias_pseudo_register_collect): New function.
4354         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4355         (rs6000_gdbarch_init): Initialize "vX" aliases as
4356         pseudo-registers.  Restore registration of
4357         rs6000_pseudo_register_reggroup_p with
4358         set_tdesc_pseudo_register_reggroup_p.
4359
4360 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4361
4362         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4363         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4364         set_gdbarch_num_pseudo_regs.
4365
4366 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4367
4368         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4369         Remove arg prefixname, add do_set and do_show.
4370         Add member functions set_list and show_list.
4371         * cli/cli-style.c (class cli_style_option): Update accordingly.
4372         (style_set_list): Move to file scope.
4373         (style_show_list): Likewise.
4374         (set_style): Call help_list.
4375         (show_style): Call cmd_show_list.
4376         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4377         Update to use the new macro.
4378
4379 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4380
4381         * ada-lang.c (_initialize_ada_language): Expand the help text
4382         for the "catch exception" command.
4383
4384 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4385
4386         * symtab.c (matching_obj_sections): Initialize obj,
4387         declare it closer to its usage.
4388
4389 2019-01-10  Tom Tromey  <tom@tromey.com>
4390
4391         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4392         (basic_inf_threads_range): Remove.
4393         (inf_threads_range, inf_non_exited_threads_range)
4394         (safe_inf_threads_range): Use next_adapter.
4395
4396 2019-01-10  Keith Seitz  <keiths@redhat.com>
4397
4398         PR gdb/23712
4399         PR symtab/23010
4400         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4401         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4402
4403 2019-01-10  Keith Seitz  <keiths@redhat.com>
4404
4405         PR gdb/23712
4406         PR symtab/23010
4407         * dictionary.c (pending_to_vector): Remove.
4408         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4409         Remove _1 suffix, replacing functions of the same name.  Update
4410         all callers.
4411         (dict_create_hashed, dict_create_hashed_expandable)
4412         (dict_create_linear, dict_create_linear_expandable, dict_free)
4413         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4414         Make functions static.
4415
4416 2019-01-10  Keith Seitz  <keiths@redhat.com>
4417
4418         PR gdb/23712
4419         PR symtab/23010
4420         * dictionary.h (struct dictionary): Replace declaration with
4421         multidictionary.
4422         (dict_create_hashed, dict_create_hashed_expandable)
4423         (dict_create_linear, dict_create_linear_expandable)
4424         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4425         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4426         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4427         taking multidictionary argument.
4428         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4429         * block.h (struct block) <dict>: Change to multidictionary
4430         and rename `multidict'.
4431         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4432         symmisc.c: Update all dictionary references to multidictionary.
4433
4434 2019-01-10  Keith Seitz  <keiths@redhat.com>
4435
4436         PR gdb/23712
4437         PR symtab/23010
4438         * dictionary.c: Include unordered_map.
4439         (pending_to_vector): New function.
4440         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4441         Rewrite the non-"_1" functions to take vector instead
4442         of linked list.
4443         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4444         "new" _1 versions of the same name.
4445         (multidictionary): Define.
4446         (std::hash<enum language): New definition.
4447         (collate_pending_symbols_by_language, mdict_create_hashed)
4448         (mdict_create_hashed_expandable, mdict_create_linear)
4449         (mdict_create_linear_expandable, mdict_free)
4450         (find_language_dictionary, create_new_language_dictionary)
4451         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4452         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4453         (mdict_size, mdict_empty): New functions.
4454         * dictionary.h (mdict_iterator): Define.
4455
4456 2019-01-10  Pedro Alves  <palves@redhat.com>
4457
4458         * breakpoint.c (read_uploaded_action)
4459         (create_tracepoint_from_upload): Adjust to use
4460         gdb::unique_xmalloc_ptr.
4461         * ctf.c (ctf_write_uploaded_tp):
4462         (SET_ARRAY_FIELD): Use emplace_back.
4463         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4464         * tracefile-tfile.c (tfile_write_uploaded_tp):
4465         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4466         gdb::unique_xmalloc_ptr.
4467         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4468         at_string, cond_string, cmd_strings>: Replace char pointers
4469         with gdb::unique_xmalloc_ptr.
4470
4471 2019-01-10  Pedro Alves  <palves@redhat.com>
4472
4473         * solib-target.c (library_list_start_library): Don't xstrdup name.
4474
4475 2019-01-10  Pedro Alves  <palves@redhat.com>
4476
4477         * mdebugread.c (parse_partial_symbols): Use
4478         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4479
4480 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4481
4482         * linux-fork.c (scoped_switch_fork_info)
4483         <~scoped_switch_fork_info>: Fix incorrect variable name.
4484
4485 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4486
4487         * linux-fork.c (scoped_switch_fork_info)
4488         <scoped_switch_fork_info>: Make explicit.
4489         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4490
4491 2019-01-10  Tom Tromey  <tom@tromey.com>
4492
4493         * objfiles.h (objfile::reset_psymtabs): Update.
4494         * objfiles.c (objfile::objfile): Update.
4495         * psymtab.h (psymtab_storage::obstack): Update.
4496         (psymtab_storage::m_obstack): Use gdb::optional.
4497         (class psymtab_storage): Update comment.  Remove objfile
4498         parameter.
4499         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4500
4501 2019-01-10  Tom Tromey  <tom@tromey.com>
4502
4503         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4504         <free_psymtabs>: Now private.
4505         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4506         (allocate_psymtab): Use new method.
4507
4508 2019-01-10  Tom Tromey  <tom@tromey.com>
4509
4510         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4511         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4512         * mdebugread.c (parse_partial_symbols): Use
4513         allocate_dependencies.
4514         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4515         allocate_dependencies.
4516         (process_psymtab_comp_unit_reader)
4517         (build_type_psymtab_dependencies): Likewise.
4518         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4519
4520 2019-01-10  Tom Tromey  <tom@tromey.com>
4521
4522         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4523         PSYMBOL_SET_LANGUAGE.
4524         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4525
4526 2019-01-10  Tom Tromey  <tom@tromey.com>
4527
4528         * psymtab.h (psymtab_storage::obstack): New method.
4529         <m_obstack>: Rename from obstack; now private.
4530         * psymtab.c (psymtab_storage): Update.
4531         * dwarf2read.c (create_addrmap_from_index)
4532         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4533         Update.
4534
4535 2019-01-10  Tom Tromey  <tom@tromey.com>
4536
4537         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4538         * objfiles.h (objfile::reset_psymtabs): New method.
4539
4540 2019-01-10  Tom Tromey  <tom@tromey.com>
4541
4542         * symmisc.c (print_symbol_bcache_statistics): Update.
4543         (print_objfile_statistics): Update.
4544         * symfile.c (reread_symbols): Update.
4545         * psymtab.h (class psymtab_storage): New.
4546         * psymtab.c (psymtab_storage): New constructor.
4547         (~psymtab_storage): New destructor.
4548         (require_partial_symbols): Update.
4549         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4550         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4551         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4552         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4553         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4554         (start_psymtab_common, end_psymtab_common)
4555         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4556         (allocate_psymtab): Update.
4557         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4558         Update.
4559         (dump_psymtab_addrmap, maintenance_print_psymbols)
4560         (maintenance_check_psymtabs): Update.
4561         (class objfile_psymtabs): Move to objfiles.h.
4562         * psympriv.h (discard_psymtab): Now inline.
4563         (psymtab_discarder::psymtab_discarder): Update.
4564         (psymtab_discarder::~psymtab_discarder): Update.
4565         (ALL_OBJFILE_PSYMTABS): Rewrite.
4566         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4567         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4568         Remove fields.
4569         <partial_symtabs>: New field.
4570         (class objfile_psymtabs): Move from psymtab.h.  Update.
4571         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4572         psymbol_cache.
4573         (objfile::~objfile): Don't destroy psymbol_cache.
4574         * mdebugread.c (parse_partial_symbols): Update.
4575         * dwarf2read.c (create_addrmap_from_index)
4576         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4577         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4578         (add_partial_subprogram, dwarf2_ranges_read): Update.
4579         * dwarf-index-write.c (write_address_map)
4580         (write_one_signatured_type, recursively_write_psymbols)
4581         (class debug_names, class debug_names, write_psymtabs_to_index):
4582         Update.
4583
4584 2019-01-10  Tom Tromey  <tom@tromey.com>
4585
4586         * symtab.h (SYMBOL_SET_NAMES): Update.
4587         (symbol_set_names): Update.
4588         (MSYMBOL_SET_NAMES): Update.
4589         * symtab.c (symbol_set_names): Change argument to be an
4590         objfile_per_bfd_storage.
4591         * psymtab.c (add_psymbol_to_bcache): Update.
4592         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4593
4594 2019-01-10  Tom Tromey  <tom@tromey.com>
4595
4596         * symtab.c (create_demangled_names_hash): Change argument to be an
4597         objfile_per_bfd_storage.
4598         (symbol_set_names): Update.
4599
4600 2019-01-10  Tom Tromey  <tom@tromey.com>
4601
4602         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4603         init_psymbol_list.
4604         * psymtab.c (init_psymbol_list): Do nothing if already called.
4605         * psympriv.h (init_psymbol_list): Add comment.
4606         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4607         init_psymbol_list.
4608         * dbxread.c (dbx_symfile_read): Unconditionally call
4609         init_psymbol_list.
4610
4611 2019-01-10  Tom Tromey  <tom@tromey.com>
4612
4613         * xcoffread.c (scan_xcoff_symtab): Update.
4614         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4615         "where".
4616         * mdebugread.c (parse_partial_symbols)
4617         (handle_psymbol_enumerators): Update.
4618         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4619         * dbxread.c (read_dbx_symtab): Update.
4620         * psympriv.h (psymbol_placement): New enum.
4621         (add_psymbol_to_list): Update.
4622
4623 2019-01-10  Tom Tromey  <tom@tromey.com>
4624
4625         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4626         static_psymbols parameters.
4627         (scan_xcoff_symtab): Update.
4628         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4629         static_psymbols parameters.
4630         * psympriv.h (start_psymtab_common): Update.
4631         * mdebugread.c (parse_partial_symbols): Update.
4632         * dwarf2read.c (create_partial_symtab): Update.
4633         * dbxread.c (read_dbx_symtab): Update.
4634         (start_psymtab): Remove global_psymbols and static_psymbols
4635         parameters.
4636
4637 2019-01-10  Tom Tromey  <tom@tromey.com>
4638
4639         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4640         * psymtab.c (allocate_psymtab): Add comment.
4641         * psympriv.h (allocate_psymtab): Add comment.
4642         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4643         initializations.
4644         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4645
4646 2019-01-10  Tom Tromey  <tom@tromey.com>
4647
4648         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4649         Don't declare.
4650         * mipsread.c: Include mdebugread.h.
4651         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4652         Declare.
4653         * elfread.c: Include mdebugread.h.
4654
4655 2019-01-09  Tom Tromey  <tom@tromey.com>
4656
4657         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4658         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4659         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4660         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4661         (psym_lookup_symbol, psym_find_last_source_symtab)
4662         (psym_forget_cached_source_info, psym_print_stats)
4663         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4664         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4665         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4666         (psym_find_compunit_symtab_by_address)
4667         (maintenance_print_psymbols, maintenance_info_psymtabs)
4668         (maintenance_check_psymtabs): Use ranged for.
4669         * psymtab.h (class objfile_psymtabs): New.
4670         (require_partial_symbols): Return objfile_psymtabs.
4671         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4672
4673 2019-01-09  Tom Tromey  <tom@tromey.com>
4674
4675         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4676         (find_pc_mapped_section, list_overlays_command)
4677         (map_overlay_command, unmap_overlay_command)
4678         (simple_overlay_update): Use all_objfiles.
4679         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4680         * printcmd.c (info_symbol_command): Use all_objfiles.
4681         * objfiles.h (ALL_OBJSECTIONS): Remove.
4682         * maint.c (maintenance_translate_address): Use all_objfiles.
4683         * gcore.c (gcore_create_callback): Use all_objfiles.
4684         (objfile_find_memory_regions): Likewise.
4685
4686 2019-01-09  Tom Tromey  <tom@tromey.com>
4687
4688         * symtab.c (find_line_symtab, info_sources_command)
4689         (make_source_files_completion_list): Use objfile_compunits.
4690         * source.c (select_source_symtab): Use objfile_compunits.
4691         * objfiles.h (struct objfile): Update comment.
4692         (ALL_OBJFILES): Remove.
4693         (ALL_FILETABS): Remove.
4694         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4695         objfile_compunits.
4696
4697 2019-01-09  Tom Tromey  <tom@tromey.com>
4698
4699         * symmisc.c (print_objfile_statistics, dump_objfile)
4700         (maintenance_print_symbols): Use compunit_filetabs.
4701         * source.c (forget_cached_source_info_for_objfile): Use
4702         compunit_filetabs.
4703         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4704         (ALL_FILETABS): Use compunit_filetabs.
4705         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4706         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4707
4708 2019-01-09  Tom Tromey  <tom@tromey.com>
4709
4710         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4711         (compunit_filetabs): New.
4712         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4713         compunit_filetabs.
4714         (info_sources_command, make_source_files_completion_list): Remove
4715         declaration.
4716         * symmisc.c (print_objfile_statistics, dump_objfile)
4717         (maintenance_print_symbols): Remove declaration.
4718         (maintenance_info_symtabs): Use compunit_filetabs.
4719         (maintenance_info_line_tables): Likewise.
4720         * source.c (select_source_symtab): Change local variable name.
4721         (forget_cached_source_info_for_objfile): Remove declaration.
4722         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4723         * objfiles.c (objfile_relocate1): Remove declaration.
4724         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4725         declaration.
4726         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4727         * coffread.c (coff_symtab_read): Remove declaration.
4728         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4729         compunit_filetabs.
4730
4731 2019-01-09  Tom Tromey  <tom@tromey.com>
4732
4733         * symtab.c (lookup_objfile_from_block)
4734         (find_pc_sect_compunit_symtab, search_symbols)
4735         (default_collect_symbol_completion_matches_break_on): Use
4736         objfile_compunits.
4737         * objfiles.h (ALL_COMPUNITS): Remove.
4738         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4739         * cp-support.c (add_symbol_overload_list_qualified): Use
4740         objfile_compunits.
4741         * ada-lang.c (ada_collect_symbol_completion_matches)
4742         (ada_add_global_exceptions): Use objfile_compunits.
4743
4744 2019-01-09  Tom Tromey  <tom@tromey.com>
4745
4746         * source.c (select_source_symtab)
4747         (forget_cached_source_info_for_objfile): Remove declaration.
4748         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4749         declaration.
4750         * maint.c (count_symtabs_and_blocks): Remove declaration.
4751         * cp-support.c (add_symbol_overload_list_qualified): Remove
4752         declaration.
4753         * coffread.c (coff_symtab_read): Remove declaration.
4754         * symtab.c (lookup_symbol_in_objfile_symtabs)
4755         (basic_lookup_transparent_type_1): Use objfile_compunits.
4756         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4757         (info_sources_command, search_symbols)
4758         (default_collect_symbol_completion_matches_break_on)
4759         (make_source_files_completion_list): Remove declaration.
4760         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4761         (ada_collect_symbol_completion_matches)
4762         (ada_add_global_exceptions): Remove declaration.
4763         * linespec.c (iterate_over_all_matching_symtabs): Use
4764         objfile_compunits.
4765         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4766         (class objfile_compunits): New.
4767         (ALL_COMPUNITS): Use objfile_compunits.
4768         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4769         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4770         objfile_compunits.
4771         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4772
4773 2019-01-09  Tom Tromey  <tom@tromey.com>
4774
4775         * symtab.c (search_symbols)
4776         (default_collect_symbol_completion_matches_break_on): Use
4777         objfile_msymbols.
4778         * ada-lang.c (ada_lookup_simple_minsym)
4779         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4780         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4781         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4782         objfile_msymbols.
4783         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4784         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4785         * objc-lang.c (find_methods): Use objfile_msymbols.
4786         (info_selectors_command, info_classes_command): Likewise.
4787         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4788         * objfiles.h (class objfile_msymbols): New.
4789         (ALL_OBJFILE_MSYMBOLS): Remove.
4790         (ALL_MSYMBOLS): Remove.
4791
4792 2019-01-09  Tom Tromey  <tom@tromey.com>
4793
4794         * common/next-iterator.h (next_adapter): Add Iterator template
4795         parameter.
4796         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4797         (class all_objfiles_safe): New.
4798         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4799         * objfiles.c (put_objfile_before): Update comment.
4800         (add_separate_debug_objfile): Likewise.
4801         (free_all_objfiles): Use all_objfiles_safe.
4802         (objfile_purge_solibs): Likewise.
4803
4804 2019-01-09  Tom Tromey  <tom@tromey.com>
4805
4806         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4807         (expand_symtab_containing_pc, lookup_static_symbol)
4808         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4809         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4810         all_objfiles.
4811         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4812         * breakpoint.c (create_overlay_event_breakpoint)
4813         (create_longjmp_master_breakpoint)
4814         (create_std_terminate_master_breakpoint)
4815         (create_exception_master_breakpoint): Use all_objfiles.
4816         * linux-thread-db.c (try_thread_db_load_from_pdir)
4817         (has_libpthread): Use all_objfiles.
4818         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4819         * linespec.c (iterate_over_all_matching_symtabs)
4820         (search_minsyms_for_name): Use all_objfiles.
4821         * maint.c (maintenance_info_sections): Use all_objfiles.
4822         * main.c (captured_main_1): Use all_objfiles.
4823         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4824         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4825         * guile/scm-pretty-print.c
4826         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4827         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4828         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4829         (maintenance_print_msymbols): Use all_objfiles.
4830         * source.c (select_source_symtab): Use all_objfiles.
4831         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4832         * symfile.c (remove_symbol_file_command)
4833         (expand_symtabs_matching, map_symbol_filenames): Use
4834         all_objfiles.
4835         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4836         all_objfiles.
4837         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4838         * objc-lang.c (find_methods): Use all_objfiles.
4839         * objfiles.c (have_partial_symbols, have_full_symbols)
4840         (have_minimal_symbols, qsort_cmp)
4841         (default_iterate_over_objfiles_in_search_order): Use
4842         all_objfiles.
4843         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4844         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4845         (maintenance_check_psymtabs): Use all_objfiles.
4846         (ALL_PSYMTABS): Remove.
4847         * compile/compile-object-run.c (do_module_cleanup): Use
4848         all_objfiles.
4849         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4850         * cp-support.c (add_symbol_overload_list_qualified): Use
4851         all_objfiles.
4852         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4853         Use all_objfiles.
4854         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4855         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4856         all_objfiles.
4857         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4858         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4859         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4860         Uses all_objfiles.
4861         * solib.c (solib_read_symbols): Use all_objfiles
4862
4863 2019-01-09  Tom Tromey  <tom@tromey.com>
4864
4865         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4866         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4867         all_objfiles.
4868         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4869         * symmisc.c (print_symbol_bcache_statistics)
4870         (print_objfile_statistics, maintenance_print_objfiles)
4871         (maintenance_info_symtabs, maintenance_check_symtabs)
4872         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4873         all_objfiles.
4874         * source.c (forget_cached_source_info): Use all_objfiles.
4875         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4876         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4877         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4878         * objfiles.c (update_section_map): Use all_objfiles.
4879         (shared_objfile_contains_address_p): Likewise.
4880         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4881         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4882
4883 2019-01-09  Tom Tromey  <tom@tromey.com>
4884
4885         * common/next-iterator.h: New file.
4886         * objfiles.h (class all_objfiles): New.
4887         (struct objfile_iterator): New.
4888
4889 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4890
4891         * NEWS: Move the description of the changed "frame", "select-frame",
4892          and "info frame" commands to the Changed commands section.
4893
4894 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4895
4896         * gdbtypes.c (check_stub_method_group): Remove handling of old
4897         mangling schemes.
4898         * linespec.c (find_methods): Likewise.
4899         * stabsread.c (read_member_functions): Likewise.
4900         * valops.c (search_struct_method): Likewise.
4901         (value_struct_elt_for_reference): Likewise.
4902         * NEWS: Mention this change.
4903
4904 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4905
4906         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4907         print_source_lines.
4908         * source.c (print_source_lines_base): Update line number check.
4909         (print_source_lines): New function.
4910         (source_lines_range::source_lines_range): New function.
4911         * source.h (class source_lines_range): New class.
4912         (print_source_lines): New declaration.
4913
4914 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4915
4916         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4917
4918 2019-01-08  Tom Tromey  <tom@tromey.com>
4919             Simon Marchi  <simon.marchi@ericsson.com>
4920
4921         PR gdb/24060
4922         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4923         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4924         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4925         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4926         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4927         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4928
4929 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4930
4931         * source.c (select_source_symtab): Move header comment to
4932         declaration in source.h.
4933         (forget_cached_source_info_for_objfile): Likewise.
4934         (forget_cached_source_info): Likewise.
4935         (identify_source_line): Likewise.
4936         * source.h (identify_source_line): Move declaration from symtab.h
4937         and add comment from source.c
4938         (print_source_lines): Likewise.
4939         (forget_cached_source_info_for_objfile): Likewise.
4940         (forget_cached_source_info): Likewise.
4941         (select_source_symtab): Likewise.
4942         (enum print_source_lines_flag): Move definition from symtab.h.
4943         * symtab.h (identify_source_line): Move declaration to source.h.
4944         (print_source_lines): Likewise.
4945         (forget_cached_source_info_for_objfile): Likewise.
4946         (forget_cached_source_info): Likewise.
4947         (select_source_symtab): Likewise.
4948         (enum print_source_lines_flag): Move definition to source.h.
4949         * tui/tui-hooks.c: Add 'source.h' include.
4950
4951 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4952
4953         * source.c (print_source_lines_base): Handle requests to print
4954         reverse line number sequences, and guard against empty lines
4955         string.
4956
4957 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4958
4959         * source.c (print_source_lines_base): Fix skip of '\r' if next
4960         character is '\n'.
4961
4962 2019-01-06  Tom Tromey  <tom@tromey.com>
4963
4964         * c-exp.y (struct c_parse_state) <macro_original_text,
4965         expansion_obstack>: New member.
4966         (macro_original_text, expansion_obstack): Remove globals.
4967         (scan_macro_expansion, scanning_macro_expansion)
4968         (finished_macro_expansion): Update.
4969         (scan_macro_cleanup): Remove.
4970         (yylex, c_parse): Update.
4971
4972 2019-01-06  Tom Tromey  <tom@tromey.com>
4973
4974         * c-exp.y (struct c_parse_state) <strings>: New member.
4975         (operator_stoken): Update.
4976
4977 2019-01-06  Tom Tromey  <tom@tromey.com>
4978
4979         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4980         (union type_stack_elt) <typelist_val>: Now a pointer to
4981         std::vector.
4982         (type_stack_cleanup): Don't declare.
4983         (push_typelist): Update.
4984         * parse.c (pop_typelist): Return a std::vector.
4985         (push_typelist): Take a std::vector.
4986         (follow_types): Update.  Do not free args.
4987         (type_stack_cleanup): Remove.
4988         * c-exp.y (struct c_parse_state): New.
4989         (cpstate): New global.
4990         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4991         (nonempty_typelist): Update.
4992         (func_mod): Create a new vector.
4993         (c_parse): Create a c_parse_state.
4994         (check_parameter_typelist): Do not delete params.
4995         (function_method): Update.  Do not delete type_list.
4996
4997 2019-01-06  Tom Tromey  <tom@tromey.com>
4998
4999         PR gdb/28155:
5000         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5001         check_typedef.
5002         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5003         (print_return_value): Likewise.
5004
5005 2019-01-05  Tom Tromey  <tom@tromey.com>
5006
5007         * contrib/cleanup_check.py: Remove.
5008         * contrib/gcc-with-excheck: Remove.
5009         * contrib/exsummary.py: Remove.
5010         * contrib/excheck.py: Remove.
5011
5012 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5013
5014         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5015         NULL. Initialize tpprev to NULL instead of assigning it
5016         to NULL on the next statement.
5017         * windows-nat.c (windows_delete_thread): Remove check for
5018         main_thread_id before printing thread exit notifications.
5019         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5020         Remove thread ID check against main_thread_id.
5021         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5022         windows_delete_thread.
5023         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5024
5025 2019-01-04  Tom Tromey  <tom@tromey.com>
5026
5027         * compile/compile.c (_initialize_compile): Use upper case for
5028         metasyntactic variables.
5029         * symmisc.c (_initialize_symmisc): Use upper case for
5030         metasyntactic variables.
5031         * psymtab.c (_initialize_psymtab): Use upper case for
5032         metasyntactic variables.
5033         * demangle.c (demangle_command): Use upper case for metasyntactic
5034         variables.
5035         (_initialize_demangler): Likewise.
5036         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5037         variables.
5038
5039 2019-01-03  Tom Tromey  <tom@tromey.com>
5040
5041         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5042
5043 2019-01-03  Tom Tromey  <tom@tromey.com>
5044
5045         * python/py-symtab.c (salpy_str): Update.
5046         (struct salpy_sal_object) <symtab>: Now a PyObject.
5047         (salpy_dealloc): Update.
5048         (del_objfile_sal): Use gdbpy_ref.
5049
5050 2019-01-03  Tom Tromey  <tom@tromey.com>
5051
5052         * python/py-type.c (convert_field): Use new_reference.  Return
5053         gdbpy_ref.
5054         (make_fielditem): Return gdbpy_ref.
5055         (typy_fields): Update.
5056         (typy_getitem): Update.
5057         (field_name): Return gdbpy_ref.  Use new_reference.
5058         (typy_iterator_iternext): Update.
5059
5060 2019-01-03  Tom Tromey  <tom@tromey.com>
5061
5062         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5063
5064 2019-01-03  Tom Tromey  <tom@tromey.com>
5065
5066         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5067         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5068         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5069         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5070         (pspy_set_type_printers): Likewise.
5071         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5072         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5073         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5074         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5075         (objfpy_set_type_printers): Likewise.
5076
5077 2019-01-03  Tom Tromey  <tom@tromey.com>
5078
5079         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5080         (gdbpy_print_stack): Use gdbpy_err_fetch.
5081         * python/python-internal.h (class gdbpy_err_fetch): New class.
5082         (class gdbpy_enter) <m_error_type, m_error_value,
5083         m_error_traceback>: Remove.
5084         <m_error>: New member.
5085         (gdbpy_exception_to_string): Don't declare.
5086         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5087         * python/py-value.c (convert_value_from_python): Use
5088         gdbpy_err_fetch.
5089         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5090         gdbpy_exception_to_string.
5091         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5092         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5093         gdbpy_err_fetch.
5094
5095 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5096
5097         * linux-nat.c (delete_lwp_cleanup): Delete.
5098         (struct lwp_deleter): New struct.
5099         (lwp_info_up): New typedef.
5100         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5101         lwp_info_up.
5102
5103 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5104
5105         * linux-fork.c (class scoped_switch_fork_info): New class.
5106         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5107
5108 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * valops.c (find_overload_match): Remove use of null_cleanup, and
5111         calls to do_cleanups.
5112
5113 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5114
5115         * compile/compile-cplus-types.c
5116         (compile_cplus_instance::decl_name): Handle changes to
5117         cp_func_name.
5118         * cp-support.c (cp_func_name): Update header comment, update
5119         return type.
5120         * cp-support.h (cp_func_name): Update return type in declaration.
5121         * valops.c (find_overload_match): Move temp_func local to top
5122         level of function and change its type.  Use temp_func to hold and
5123         delete temporary string obtained from cp_func_name.
5124
5125 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5126
5127         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5128         gdb::char_vector, remove cleanup, and update uses of `msg`.
5129
5130 2019-01-03  Jim Wilson  <jimw@sifive.com>
5131
5132         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5133
5134 2019-01-02  Tom Tromey  <tom@tromey.com>
5135
5136         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5137         (tdesc_parse_xml): Remove cleanups.
5138         * target-descriptions.h (make_cleanup_free_target_description):
5139         Don't declare.
5140         (target_desc_deleter): New struct.
5141         (target_desc_up): New typedef.
5142         * target-descriptions.c (target_desc_deleter::operator()): Rename
5143         from free_target_description.
5144         (make_cleanup_free_target_description): Remove.
5145
5146 2019-01-02  Tom Tromey  <tom@tromey.com>
5147
5148         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5149         constructor, destructor.
5150         (linespec_parser): Remove typedef.
5151         (~linespec_parser): Rename from linespec_parser_delete.
5152         (linespec_lex_to_end, linespec_complete_label)
5153         (linespec_complete): Update.
5154         (decode_line_full): Remove cleanups.
5155         (decode_line_1): Update.
5156
5157 2019-01-02  Tom Tromey  <tom@tromey.com>
5158
5159         * python/python-internal.h (inferior_to_inferior_object): Change
5160         return type.
5161         * python/py-exitedevent.c (create_exited_event_object): Update.
5162         * python/py-inferior.c (inferior_to_inferior_object): Return
5163         gdbpy_ref.
5164         (python_new_inferior, python_inferior_deleted)
5165         (thread_to_thread_object, delete_thread_object)
5166         (build_inferior_list, gdbpy_selected_inferior): Update.
5167         * python/py-infthread.c (create_thread_object): Update.  Also fail
5168         if inferior_to_inferior_object fails.
5169
5170 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5171
5172         * inferior.h (class inferior) <displaced_step_state>: New field.
5173         * infrun.h (struct displaced_step_state): Move here from
5174         infrun.c.  Initialize fields, add constructor.
5175         <inf>: Remove field.
5176         <reset>: New method.
5177         * infrun.c (struct displaced_step_inferior_state): Move to
5178         infrun.h.
5179         (displaced_step_inferior_states): Remove.
5180         (get_displaced_stepping_state): Adust.
5181         (displaced_step_in_progress_any_inferior): Adjust.
5182         (displaced_step_in_progress_thread): Adjust.
5183         (displaced_step_in_progress): Adjust.
5184         (add_displaced_stepping_state): Remove.
5185         (get_displaced_step_closure_by_addr): Adjust.
5186         (remove_displaced_stepping_state): Remove.
5187         (infrun_inferior_exit): Call displaced_step_state.reset.
5188         (use_displaced_stepping): Don't check for NULL.
5189         (displaced_step_prepare_throw): Call
5190         get_displaced_stepping_state.
5191         (displaced_step_fixup): Don't check for NULL.
5192         (prepare_for_detach): Don't check for NULL.
5193
5194 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5195
5196         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5197          in case of call that did not complete.
5198
5199 2019-01-02  Andrey Utkin  <autkin@undo.io>
5200
5201         * symfile.c (find_separate_debug_file): Fix search of debug files for
5202         remote debuggee.
5203
5204 2019-01-02  Tom Tromey  <tom@tromey.com>
5205
5206         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5207         indentation.
5208         * python/py-frame.c (frapy_older): Remove cast.
5209         (frapy_newer): Likewise.
5210         * python/py-breakpoint.c (local_setattro): Remove cast.
5211         * python/py-arch.c (archpy_name): Remove local variable.
5212         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5213
5214 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5215
5216         * unittests/basic_string_view/element_access/char/empty.cc:
5217         Fix year range in copyright header.
5218
5219 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5220
5221         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5222         Delete.
5223         <operator==>: Update with for removed field.
5224         <hash>: Likewise.
5225         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5226         <isa_features>: ...this.
5227         <abi_features>: New field.
5228         (riscv_isa_flen): Update comment.
5229         (riscv_abi_xlen): New declaration.
5230         (riscv_abi_flen): New declaration.
5231         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5232         isa_features.
5233         (riscv_abi_xlen): New function.
5234         (riscv_isa_flen): Update to get answer from isa_features.
5235         (riscv_abi_flen): New function.
5236         (riscv_has_fp_abi): Update to get answer from abi_features.
5237         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5238         xlen and flen.
5239         (riscv_call_info) <xlen, flen>: Update comment.
5240         (riscv_call_arg_struct): Remove invalid assertions
5241         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5242         is removed.
5243         (riscv_gdbarch_init): Gather isa features and abi features
5244         separately, ensure both match on the gdbarch when reusing an old
5245         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5246         a target with 64-bit float hardware.
5247
5248 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5249
5250         * source.c (search_command_helper): Stop reverse search
5251         when line 1 has been searched.
5252
5253 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5254
5255         * record-full.c (record_full_base_target::close): Rewrite
5256         record_full_core_buf_list free logic.
5257
5258 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5259
5260         * break-catch-syscall.c (print_one_catch_syscall): xfree
5261         the last text.
5262
5263 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5264
5265         * top.c (print_gdb_version): Update Copyright year in version
5266         message.
5267
5268 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5269
5270         Update copyright year range in all GDB files.
5271
5272 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5273
5274         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5275
5276 For older changes see ChangeLog-2018.
5277 \f
5278 Local Variables:
5279 mode: change-log
5280 left-margin: 8
5281 fill-column: 74
5282 version-control: never
5283 coding: utf-8
5284 End:
5285