(riscv/ada) fix error when calling functions with range argument
[external/binutils.git] / gdb / ChangeLog
1 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2
3         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4
5 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6
7         * windows-nat.c (windows_add_thread): Add new parameter
8         "main_thread_p" with default value set to false.  Update
9         function documentation as well as all callers.
10         (windows_delete_thread): Likewise.
11         (fake_create_process): Update call to windows_add_thread.
12         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
13         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15         call to windows_delete_thread.
16
17 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
18
19         * MAINTAINERS: Add Andrew Burgess as global maintainer.
20
21 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
22
23         * symfile.c (find_separate_debug_file): Use canonical path of
24         sysroot with child_path instead of gdb_sysroot if it is valid.
25
26 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
27
28         * symfile.c (find_separate_debug_file): Use child_path to
29         determine if an object file is under a sysroot.
30
31 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
32
33         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
34         unittests/child-path-selftests.c.
35         * common/pathstuff.c (child_path): New function.
36         * common/pathstuff.h (child_path): New prototype.
37         * unittests/child-path-selftests.c: New file.
38
39 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
40
41         * symfile.c (find_separate_debug_file): Look for separate debug
42         files in debug directories under the sysroot.
43
44 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
45
46         * symtab.h (struct minimal_symbol data_p): New const method.
47         (struct minimal_symbol text_p): Likewise.
48         * symtab.c (output_source_filename): Use file name style
49         to print file name.
50         (print_symbol_info): Likewise.
51         (print_msymbol_info): Use address style to print addresses.
52         Use function name style to print executable text symbols.
53         (expand_symtab_containing_pc): Use data_p.
54         (find_pc_sect_compunit_symtab): Likewise.
55
56 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
57
58         * breakpoint.c (describe_other_breakpoints): Use address style
59         to print addresses.
60         (say_where): Likewise.
61
62 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
63
64         * ada-typeprint.c (print_func_type): Print function name
65         style to print function name.
66         * c-typeprint.c (c_print_type_1): Likewise.
67
68 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
69
70         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
71         for execve.
72
73 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
74
75         * c-exp.y (direct_abs_decl): Use emplace_back to record the
76         type_stack.
77
78 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
79
80         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
81         TYPE_CODE_REF types.
82
83 2019-02-08  Jim Wilson  <jimw@sifive.com>
84
85         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
86         (riscv_linux_fregset): New.
87         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
88
89 2019-02-07  Tom Tromey  <tom@tromey.com>
90
91         * thread.c (thread_cancel_execution_command): Update.
92         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
93         methods.
94         (struct thread_fsm_ops): Remove.
95         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
96         (thread_fsm_should_stop, thread_fsm_return_value)
97         (thread_fsm_set_finished, thread_fsm_finished_p)
98         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
99         Don't declare.
100         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
101         * infrun.c (clear_proceed_status_thread)
102         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
103         (print_stop_event): Update.
104         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
105         Add constructor.
106         (step_command_fsm_ops): Remove.
107         (new_step_command_fsm): Remove.
108         (step_1): Update.
109         (step_command_fsm::should_stop): Rename from
110         step_command_fsm_should_stop.
111         (step_command_fsm::clean_up): Rename from
112         step_command_fsm_clean_up.
113         (step_command_fsm::do_async_reply_reason): Rename from
114         step_command_fsm_async_reply_reason.
115         (struct until_next_fsm): Inherit from thread_fsm.  Add
116         constructor.
117         (until_next_fsm_ops): Remove.
118         (new_until_next_fsm): Remove.
119         (until_next_fsm::should_stop): Rename from
120         until_next_fsm_should_stop.
121         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
122         (until_next_fsm::do_async_reply_reason): Rename from
123         until_next_fsm_async_reply_reason.
124         (struct finish_command_fsm): Inherit from thread_fsm.  Add
125         constructor.  Change type of breakpoint.
126         (finish_command_fsm_ops): Remove.
127         (new_finish_command_fsm): Remove.
128         (finish_command_fsm::should_stop): Rename from
129         finish_command_fsm_should_stop.
130         (finish_command_fsm::clean_up): Rename from
131         finish_command_fsm_clean_up.
132         (finish_command_fsm::return_value): Rename from
133         finish_command_fsm_return_value.
134         (finish_command_fsm::do_async_reply_reason): Rename from
135         finish_command_fsm_async_reply_reason.
136         (finish_command): Update.
137         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
138         Add constructor.
139         (call_thread_fsm_ops): Remove.
140         (call_thread_fsm::call_thread_fsm): Rename from
141         new_call_thread_fsm.
142         (call_thread_fsm::should_stop): Rename from
143         call_thread_fsm_should_stop.
144         (call_thread_fsm::should_notify_stop): Rename from
145         call_thread_fsm_should_notify_stop.
146         (run_inferior_call, call_function_by_hand_dummy): Update.
147         * cli/cli-interp.c (should_print_stop_to_console): Update.
148         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
149         Add constructor.  Change type of location_breakpoint,
150         caller_breakpoint.
151         (until_break_fsm_ops): Remove.
152         (new_until_break_fsm): Remove.
153         (until_break_fsm::should_stop): Rename from
154         until_break_fsm_should_stop.
155         (until_break_fsm::clean_up): Rename from
156         until_break_fsm_clean_up.
157         (until_break_fsm::do_async_reply_reason): Rename from
158         until_break_fsm_async_reply_reason.
159         (until_break_command): Update.
160         * thread-fsm.c: Remove.
161         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
162
163 2019-02-07  Tom Tromey  <tom@tromey.com>
164
165         * yy-remap.h: Add include guard.
166         * xtensa-tdep.h: Add include guard.
167         * xcoffread.h: Rename include guard.
168         * varobj-iter.h: Add include guard.
169         * tui/tui.h: Rename include guard.
170         * tui/tui-winsource.h: Rename include guard.
171         * tui/tui-wingeneral.h: Rename include guard.
172         * tui/tui-windata.h: Rename include guard.
173         * tui/tui-win.h: Rename include guard.
174         * tui/tui-stack.h: Rename include guard.
175         * tui/tui-source.h: Rename include guard.
176         * tui/tui-regs.h: Rename include guard.
177         * tui/tui-out.h: Rename include guard.
178         * tui/tui-layout.h: Rename include guard.
179         * tui/tui-io.h: Rename include guard.
180         * tui/tui-hooks.h: Rename include guard.
181         * tui/tui-file.h: Rename include guard.
182         * tui/tui-disasm.h: Rename include guard.
183         * tui/tui-data.h: Rename include guard.
184         * tui/tui-command.h: Rename include guard.
185         * tic6x-tdep.h: Add include guard.
186         * target/waitstatus.h: Rename include guard.
187         * target/wait.h: Rename include guard.
188         * target/target.h: Rename include guard.
189         * target/resume.h: Rename include guard.
190         * target-float.h: Rename include guard.
191         * stabsread.h: Add include guard.
192         * rs6000-tdep.h: Add include guard.
193         * riscv-fbsd-tdep.h: Add include guard.
194         * regformats/regdef.h: Rename include guard.
195         * record.h: Rename include guard.
196         * python/python.h: Rename include guard.
197         * python/python-internal.h: Rename include guard.
198         * python/py-stopevent.h: Rename include guard.
199         * python/py-ref.h: Rename include guard.
200         * python/py-record.h: Rename include guard.
201         * python/py-record-full.h: Rename include guard.
202         * python/py-record-btrace.h: Rename include guard.
203         * python/py-instruction.h: Rename include guard.
204         * python/py-events.h: Rename include guard.
205         * python/py-event.h: Rename include guard.
206         * procfs.h: Add include guard.
207         * proc-utils.h: Add include guard.
208         * p-lang.h: Add include guard.
209         * or1k-tdep.h: Rename include guard.
210         * observable.h: Rename include guard.
211         * nto-tdep.h: Rename include guard.
212         * nat/x86-linux.h: Rename include guard.
213         * nat/x86-linux-dregs.h: Rename include guard.
214         * nat/x86-gcc-cpuid.h: Add include guard.
215         * nat/x86-dregs.h: Rename include guard.
216         * nat/x86-cpuid.h: Rename include guard.
217         * nat/ppc-linux.h: Rename include guard.
218         * nat/mips-linux-watch.h: Rename include guard.
219         * nat/linux-waitpid.h: Rename include guard.
220         * nat/linux-ptrace.h: Rename include guard.
221         * nat/linux-procfs.h: Rename include guard.
222         * nat/linux-osdata.h: Rename include guard.
223         * nat/linux-nat.h: Rename include guard.
224         * nat/linux-namespaces.h: Rename include guard.
225         * nat/linux-btrace.h: Rename include guard.
226         * nat/glibc_thread_db.h: Rename include guard.
227         * nat/gdb_thread_db.h: Rename include guard.
228         * nat/gdb_ptrace.h: Rename include guard.
229         * nat/fork-inferior.h: Rename include guard.
230         * nat/amd64-linux-siginfo.h: Rename include guard.
231         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
232         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
233         * nat/aarch64-linux.h: Rename include guard.
234         * nat/aarch64-linux-hw-point.h: Rename include guard.
235         * mn10300-tdep.h: Add include guard.
236         * mips-linux-tdep.h: Add include guard.
237         * mi/mi-parse.h: Rename include guard.
238         * mi/mi-out.h: Rename include guard.
239         * mi/mi-main.h: Rename include guard.
240         * mi/mi-interp.h: Rename include guard.
241         * mi/mi-getopt.h: Rename include guard.
242         * mi/mi-console.h: Rename include guard.
243         * mi/mi-common.h: Rename include guard.
244         * mi/mi-cmds.h: Rename include guard.
245         * mi/mi-cmd-break.h: Rename include guard.
246         * m2-lang.h: Add include guard.
247         * location.h: Rename include guard.
248         * linux-record.h: Rename include guard.
249         * linux-nat.h: Add include guard.
250         * linux-fork.h: Add include guard.
251         * i386-darwin-tdep.h: Rename include guard.
252         * hppa-linux-offsets.h: Add include guard.
253         * guile/guile.h: Rename include guard.
254         * guile/guile-internal.h: Rename include guard.
255         * gnu-nat.h: Rename include guard.
256         * gdb-stabs.h: Rename include guard.
257         * frv-tdep.h: Add include guard.
258         * f-lang.h: Add include guard.
259         * event-loop.h: Add include guard.
260         * darwin-nat.h: Rename include guard.
261         * cp-abi.h: Rename include guard.
262         * config/sparc/nm-sol2.h: Rename include guard.
263         * config/nm-nto.h: Rename include guard.
264         * config/nm-linux.h: Add include guard.
265         * config/i386/nm-i386gnu.h: Rename include guard.
266         * config/djgpp/nl_types.h: Rename include guard.
267         * config/djgpp/langinfo.h: Rename include guard.
268         * compile/gcc-cp-plugin.h: Add include guard.
269         * compile/gcc-c-plugin.h: Add include guard.
270         * compile/compile.h: Rename include guard.
271         * compile/compile-object-run.h: Rename include guard.
272         * compile/compile-object-load.h: Rename include guard.
273         * compile/compile-internal.h: Rename include guard.
274         * compile/compile-cplus.h: Rename include guard.
275         * compile/compile-c.h: Rename include guard.
276         * common/xml-utils.h: Rename include guard.
277         * common/x86-xstate.h: Rename include guard.
278         * common/version.h: Rename include guard.
279         * common/vec.h: Rename include guard.
280         * common/tdesc.h: Rename include guard.
281         * common/selftest.h: Rename include guard.
282         * common/scoped_restore.h: Rename include guard.
283         * common/scoped_mmap.h: Rename include guard.
284         * common/scoped_fd.h: Rename include guard.
285         * common/safe-iterator.h: Rename include guard.
286         * common/run-time-clock.h: Rename include guard.
287         * common/refcounted-object.h: Rename include guard.
288         * common/queue.h: Rename include guard.
289         * common/ptid.h: Rename include guard.
290         * common/print-utils.h: Rename include guard.
291         * common/preprocessor.h: Rename include guard.
292         * common/pathstuff.h: Rename include guard.
293         * common/observable.h: Rename include guard.
294         * common/netstuff.h: Rename include guard.
295         * common/job-control.h: Rename include guard.
296         * common/host-defs.h: Rename include guard.
297         * common/gdb_wait.h: Rename include guard.
298         * common/gdb_vecs.h: Rename include guard.
299         * common/gdb_unlinker.h: Rename include guard.
300         * common/gdb_unique_ptr.h: Rename include guard.
301         * common/gdb_tilde_expand.h: Rename include guard.
302         * common/gdb_sys_time.h: Rename include guard.
303         * common/gdb_string_view.h: Rename include guard.
304         * common/gdb_splay_tree.h: Rename include guard.
305         * common/gdb_setjmp.h: Rename include guard.
306         * common/gdb_ref_ptr.h: Rename include guard.
307         * common/gdb_optional.h: Rename include guard.
308         * common/gdb_locale.h: Rename include guard.
309         * common/gdb_assert.h: Rename include guard.
310         * common/filtered-iterator.h: Rename include guard.
311         * common/filestuff.h: Rename include guard.
312         * common/fileio.h: Rename include guard.
313         * common/environ.h: Rename include guard.
314         * common/common-utils.h: Rename include guard.
315         * common/common-types.h: Rename include guard.
316         * common/common-regcache.h: Rename include guard.
317         * common/common-inferior.h: Rename include guard.
318         * common/common-gdbthread.h: Rename include guard.
319         * common/common-exceptions.h: Rename include guard.
320         * common/common-defs.h: Rename include guard.
321         * common/common-debug.h: Rename include guard.
322         * common/cleanups.h: Rename include guard.
323         * common/buffer.h: Rename include guard.
324         * common/btrace-common.h: Rename include guard.
325         * common/break-common.h: Rename include guard.
326         * cli/cli-utils.h: Rename include guard.
327         * cli/cli-style.h: Rename include guard.
328         * cli/cli-setshow.h: Rename include guard.
329         * cli/cli-script.h: Rename include guard.
330         * cli/cli-interp.h: Rename include guard.
331         * cli/cli-decode.h: Rename include guard.
332         * cli/cli-cmds.h: Rename include guard.
333         * charset-list.h: Add include guard.
334         * buildsym-legacy.h: Rename include guard.
335         * bfin-tdep.h: Add include guard.
336         * ax.h: Rename include guard.
337         * arm-linux-tdep.h: Add include guard.
338         * arm-fbsd-tdep.h: Add include guard.
339         * arch/xtensa.h: Rename include guard.
340         * arch/tic6x.h: Add include guard.
341         * arch/i386.h: Add include guard.
342         * arch/arm.h: Rename include guard.
343         * arch/arm-linux.h: Rename include guard.
344         * arch/arm-get-next-pcs.h: Rename include guard.
345         * arch/amd64.h: Add include guard.
346         * arch/aarch64-insn.h: Rename include guard.
347         * arch-utils.h: Rename include guard.
348         * annotate.h: Add include guard.
349         * amd64-darwin-tdep.h: Rename include guard.
350         * aarch64-linux-tdep.h: Add include guard.
351         * aarch64-fbsd-tdep.h: Add include guard.
352         * aarch32-linux-nat.h: Add include guard.
353
354 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
355
356         * macrotab.c (macro_define_internal): New function that
357         factorizes macro_define_object_internal and macro_define_function
358         code.
359         (macro_define_object_internal): Use macro_define_internal.
360         (macro_define_function): Likewise.
361
362 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
363
364         * macrocmd.c (extract_identifier): Return
365         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
366         callers.
367
368 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
369
370         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
371
372 2019-02-05  Tom Tromey  <tom@tromey.com>
373
374         * target.c (target_stack::unpush): Move assertion earlier.
375
376 2019-01-30  Tom Tromey  <tom@tromey.com>
377
378         PR python/23615:
379         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
380         (gdbpy_parse_and_eval): Likewise.
381         * python/python-internal.h (gdbpy_allow_threads): New class.
382
383 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
384
385         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
386         (aarch64_fbsd_fpregmap): Move earlier.
387         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
388         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
389         instead of individual calls to trad_frame_set_reg_addr.
390         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
391         earlier.
392         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
393         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
394         instead of individual calls to trad_frame_set_reg_addr.
395
396 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
397
398         * CONTRIBUTE: Replace contribution list with wiki link.
399
400 2019-01-25  Tom Tromey  <tom@tromey.com>
401
402         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
403
404 2019-01-25  Tom Tromey  <tom@tromey.com>
405
406         * xtensa-linux-nat.c: Fix common/ includes.
407         * xml-support.h: Fix common/ includes.
408         * xml-support.c: Fix common/ includes.
409         * x86-linux-nat.c: Fix common/ includes.
410         * windows-nat.c: Fix common/ includes.
411         * varobj.h: Fix common/ includes.
412         * varobj.c: Fix common/ includes.
413         * value.c: Fix common/ includes.
414         * valops.c: Fix common/ includes.
415         * utils.c: Fix common/ includes.
416         * unittests/xml-utils-selftests.c: Fix common/ includes.
417         * unittests/utils-selftests.c: Fix common/ includes.
418         * unittests/unpack-selftests.c: Fix common/ includes.
419         * unittests/tracepoint-selftests.c: Fix common/ includes.
420         * unittests/style-selftests.c: Fix common/ includes.
421         * unittests/string_view-selftests.c: Fix common/ includes.
422         * unittests/scoped_restore-selftests.c: Fix common/ includes.
423         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
424         * unittests/scoped_fd-selftests.c: Fix common/ includes.
425         * unittests/rsp-low-selftests.c: Fix common/ includes.
426         * unittests/parse-connection-spec-selftests.c: Fix common/
427         includes.
428         * unittests/optional-selftests.c: Fix common/ includes.
429         * unittests/offset-type-selftests.c: Fix common/ includes.
430         * unittests/observable-selftests.c: Fix common/ includes.
431         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
432         * unittests/memrange-selftests.c: Fix common/ includes.
433         * unittests/memory-map-selftests.c: Fix common/ includes.
434         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
435         * unittests/function-view-selftests.c: Fix common/ includes.
436         * unittests/environ-selftests.c: Fix common/ includes.
437         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
438         * unittests/common-utils-selftests.c: Fix common/ includes.
439         * unittests/cli-utils-selftests.c: Fix common/ includes.
440         * unittests/array-view-selftests.c: Fix common/ includes.
441         * ui-file.c: Fix common/ includes.
442         * tui/tui-io.c: Fix common/ includes.
443         * tracepoint.h: Fix common/ includes.
444         * tracepoint.c: Fix common/ includes.
445         * tracefile-tfile.c: Fix common/ includes.
446         * top.h: Fix common/ includes.
447         * top.c: Fix common/ includes.
448         * thread.c: Fix common/ includes.
449         * target/waitstatus.h: Fix common/ includes.
450         * target/waitstatus.c: Fix common/ includes.
451         * target.h: Fix common/ includes.
452         * target.c: Fix common/ includes.
453         * target-memory.c: Fix common/ includes.
454         * target-descriptions.c: Fix common/ includes.
455         * symtab.h: Fix common/ includes.
456         * symfile.c: Fix common/ includes.
457         * stap-probe.c: Fix common/ includes.
458         * spu-linux-nat.c: Fix common/ includes.
459         * sparc-nat.c: Fix common/ includes.
460         * source.c: Fix common/ includes.
461         * solib.c: Fix common/ includes.
462         * solib-target.c: Fix common/ includes.
463         * ser-unix.c: Fix common/ includes.
464         * ser-tcp.c: Fix common/ includes.
465         * ser-pipe.c: Fix common/ includes.
466         * ser-base.c: Fix common/ includes.
467         * selftest-arch.c: Fix common/ includes.
468         * s12z-tdep.c: Fix common/ includes.
469         * rust-exp.y: Fix common/ includes.
470         * rs6000-aix-tdep.c: Fix common/ includes.
471         * riscv-tdep.c: Fix common/ includes.
472         * remote.c: Fix common/ includes.
473         * remote-notif.h: Fix common/ includes.
474         * remote-fileio.h: Fix common/ includes.
475         * remote-fileio.c: Fix common/ includes.
476         * regcache.h: Fix common/ includes.
477         * regcache.c: Fix common/ includes.
478         * record-btrace.c: Fix common/ includes.
479         * python/python.c: Fix common/ includes.
480         * python/py-type.c: Fix common/ includes.
481         * python/py-inferior.c: Fix common/ includes.
482         * progspace.h: Fix common/ includes.
483         * producer.c: Fix common/ includes.
484         * procfs.c: Fix common/ includes.
485         * proc-api.c: Fix common/ includes.
486         * printcmd.c: Fix common/ includes.
487         * ppc-linux-nat.c: Fix common/ includes.
488         * parser-defs.h: Fix common/ includes.
489         * osdata.c: Fix common/ includes.
490         * obsd-nat.c: Fix common/ includes.
491         * nat/x86-linux.c: Fix common/ includes.
492         * nat/x86-linux-dregs.c: Fix common/ includes.
493         * nat/x86-dregs.h: Fix common/ includes.
494         * nat/x86-dregs.c: Fix common/ includes.
495         * nat/ppc-linux.c: Fix common/ includes.
496         * nat/mips-linux-watch.h: Fix common/ includes.
497         * nat/mips-linux-watch.c: Fix common/ includes.
498         * nat/linux-waitpid.c: Fix common/ includes.
499         * nat/linux-ptrace.h: Fix common/ includes.
500         * nat/linux-ptrace.c: Fix common/ includes.
501         * nat/linux-procfs.c: Fix common/ includes.
502         * nat/linux-personality.c: Fix common/ includes.
503         * nat/linux-osdata.c: Fix common/ includes.
504         * nat/linux-namespaces.c: Fix common/ includes.
505         * nat/linux-btrace.h: Fix common/ includes.
506         * nat/linux-btrace.c: Fix common/ includes.
507         * nat/fork-inferior.c: Fix common/ includes.
508         * nat/amd64-linux-siginfo.c: Fix common/ includes.
509         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
510         * nat/aarch64-linux.c: Fix common/ includes.
511         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
512         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
513         * namespace.h: Fix common/ includes.
514         * mips-linux-tdep.c: Fix common/ includes.
515         * minsyms.c: Fix common/ includes.
516         * mi/mi-parse.h: Fix common/ includes.
517         * mi/mi-main.c: Fix common/ includes.
518         * mi/mi-cmd-env.c: Fix common/ includes.
519         * memrange.h: Fix common/ includes.
520         * memattr.c: Fix common/ includes.
521         * maint.h: Fix common/ includes.
522         * maint.c: Fix common/ includes.
523         * main.c: Fix common/ includes.
524         * machoread.c: Fix common/ includes.
525         * location.c: Fix common/ includes.
526         * linux-thread-db.c: Fix common/ includes.
527         * linux-nat.c: Fix common/ includes.
528         * linux-fork.c: Fix common/ includes.
529         * inline-frame.c: Fix common/ includes.
530         * infrun.c: Fix common/ includes.
531         * inflow.c: Fix common/ includes.
532         * inferior.h: Fix common/ includes.
533         * inferior.c: Fix common/ includes.
534         * infcmd.c: Fix common/ includes.
535         * inf-ptrace.c: Fix common/ includes.
536         * inf-child.c: Fix common/ includes.
537         * ia64-linux-nat.c: Fix common/ includes.
538         * i387-tdep.c: Fix common/ includes.
539         * i386-tdep.c: Fix common/ includes.
540         * i386-linux-tdep.c: Fix common/ includes.
541         * i386-linux-nat.c: Fix common/ includes.
542         * i386-go32-tdep.c: Fix common/ includes.
543         * i386-fbsd-tdep.c: Fix common/ includes.
544         * i386-fbsd-nat.c: Fix common/ includes.
545         * guile/scm-type.c: Fix common/ includes.
546         * guile/guile.c: Fix common/ includes.
547         * go32-nat.c: Fix common/ includes.
548         * gnu-nat.c: Fix common/ includes.
549         * gdbthread.h: Fix common/ includes.
550         * gdbarch-selftests.c: Fix common/ includes.
551         * gdb_usleep.c: Fix common/ includes.
552         * gdb_select.h: Fix common/ includes.
553         * gdb_bfd.c: Fix common/ includes.
554         * gcore.c: Fix common/ includes.
555         * fork-child.c: Fix common/ includes.
556         * findvar.c: Fix common/ includes.
557         * fbsd-nat.c: Fix common/ includes.
558         * event-top.c: Fix common/ includes.
559         * event-loop.c: Fix common/ includes.
560         * dwarf2read.c: Fix common/ includes.
561         * dwarf2loc.c: Fix common/ includes.
562         * dwarf2-frame.c: Fix common/ includes.
563         * dwarf-index-cache.c: Fix common/ includes.
564         * dtrace-probe.c: Fix common/ includes.
565         * disasm-selftests.c: Fix common/ includes.
566         * defs.h: Fix common/ includes.
567         * csky-tdep.c: Fix common/ includes.
568         * cp-valprint.c: Fix common/ includes.
569         * cp-support.h: Fix common/ includes.
570         * cp-support.c: Fix common/ includes.
571         * corelow.c: Fix common/ includes.
572         * completer.h: Fix common/ includes.
573         * completer.c: Fix common/ includes.
574         * compile/compile.c: Fix common/ includes.
575         * compile/compile-loc2c.c: Fix common/ includes.
576         * compile/compile-cplus-types.c: Fix common/ includes.
577         * compile/compile-cplus-symbols.c: Fix common/ includes.
578         * command.h: Fix common/ includes.
579         * cli/cli-dump.c: Fix common/ includes.
580         * cli/cli-cmds.c: Fix common/ includes.
581         * charset.c: Fix common/ includes.
582         * build-id.c: Fix common/ includes.
583         * btrace.h: Fix common/ includes.
584         * btrace.c: Fix common/ includes.
585         * breakpoint.h: Fix common/ includes.
586         * breakpoint.c: Fix common/ includes.
587         * ax.h: 
588         (enum agent_op): Fix common/ includes.
589         * ax-general.c (struct aop_map): Fix common/ includes.
590         * ax-gdb.c: Fix common/ includes.
591         * auxv.c: Fix common/ includes.
592         * auto-load.c: Fix common/ includes.
593         * arm-tdep.c: Fix common/ includes.
594         * arch/riscv.c: Fix common/ includes.
595         * arch/ppc-linux-common.c: Fix common/ includes.
596         * arch/i386.c: Fix common/ includes.
597         * arch/arm.c: Fix common/ includes.
598         * arch/arm-linux.c: Fix common/ includes.
599         * arch/arm-get-next-pcs.c: Fix common/ includes.
600         * arch/amd64.c: Fix common/ includes.
601         * arch/aarch64.c: Fix common/ includes.
602         * arch/aarch64-insn.c: Fix common/ includes.
603         * arch-utils.c: Fix common/ includes.
604         * amd64-windows-tdep.c: Fix common/ includes.
605         * amd64-tdep.c: Fix common/ includes.
606         * amd64-sol2-tdep.c: Fix common/ includes.
607         * amd64-obsd-tdep.c: Fix common/ includes.
608         * amd64-nbsd-tdep.c: Fix common/ includes.
609         * amd64-linux-tdep.c: Fix common/ includes.
610         * amd64-linux-nat.c: Fix common/ includes.
611         * amd64-fbsd-tdep.c: Fix common/ includes.
612         * amd64-fbsd-nat.c: Fix common/ includes.
613         * amd64-dicos-tdep.c: Fix common/ includes.
614         * amd64-darwin-tdep.c: Fix common/ includes.
615         * agent.c: Fix common/ includes.
616         * ada-lang.h: Fix common/ includes.
617         * ada-lang.c: Fix common/ includes.
618         * aarch64-tdep.c: Fix common/ includes.
619
620 2019-01-25  Tom Tromey  <tom@tromey.com>
621
622         * common/create-version.sh: Use common/version.h.
623
624 2019-01-24  Pedro Alves  <palves@redhat.com>
625
626         * infrun.c (signal_stop, signal_print, signal_program)
627         (signal_catch, signal_pass): Now arrays instead of pointers.
628         (update_signals_program_target, do_target_resume)
629         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
630         * linux-nat.c (linux_nat_target::pass_signals)
631         (linux_nat_target::create_inferior, linux_nat_target::attach):
632         Adjust.
633         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
634         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
635         * procfs.c (procfs_target::pass_signals): Adjust.
636         * record-full.c (record_full_target::resume): Adjust.
637         * remote.c (remote_target::pass_signals)
638         (remote_target::program_signals): Adjust.
639         * target-debug.h (target_debug_print_signals): Now takes a
640         gdb::array_view as parameter.  Adjust.
641         * target.h (target_ops) <pass_signals, program_signals>: Replace
642         pointer and length parameters with gdb::array_view.
643         (target_pass_signals, target_program_signals): Likewise.
644         * target-delegates.c: Regenerate.
645
646 2019-01-24  Pedro Alves  <palves@redhat.com>
647
648         * common/forward-scope-exit.h
649         (forward_scope_exit::forward_scope_exit): Pass arguments to
650         m_bind_function directly, instead of creating a std::bind and
651         copying that.
652
653 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
654
655         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
656         for static members.
657         (pass_in_v_vfp_candidate): Likewise.
658
659 2019-01-23  Tom Tromey  <tom@tromey.com>
660             Pedro Alves  <palves@redhat.com>
661
662         * regcache.c (class regcache_invalidator): Remove.
663         (regcache::raw_write): Use make_scope_exit.
664
665 2019-01-23  Tom Tromey  <tom@tromey.com>
666
667         * ui-out.h (class ui_out_emit_type): Update comment.
668
669 2019-01-23  Tom Tromey  <tom@tromey.com>
670
671         * infrun.c (fetch_inferior_event): Update comment.
672
673 2019-01-23  Tom Tromey  <tom@tromey.com>
674             Pedro Alves  <palves@redhat.com>
675
676         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
677         parameter.
678         (fetch_inferior_event): Use SCOPE_EXIT.
679
680
681 2019-01-23  Tom Tromey  <tom@tromey.com>
682             Pedro Alves  <palves@redhat.com>
683
684         * infrun.c (disable_thread_events): Delete.
685         (stop_all_threads): Use SCOPE_EXIT.
686
687 2019-01-23  Tom Tromey  <tom@tromey.com>
688             Pedro Alves  <palves@redhat.com>
689
690         * symfile.c: Include forward-scope-exit.h.
691         (clear_symtab_users_cleanup): Replace forward declaration with
692         a FORWARD_SCOPE_EXIT.
693         (syms_from_objfile_1): Use the forward_scope_exit and
694         gdb::optional instead of cleanup_function.
695         (reread_symbols): Use the forward_scope_exit instead of
696         cleanup_function.
697         (clear_symtab_users_cleanup): Remove function.
698
699 2019-01-23  Tom Tromey  <tom@tromey.com>
700             Pedro Alves  <palves@redhat.com>
701
702         * linux-nat.c: Include scope-exit.h.
703         (cleanup_target_stop): Remove.
704         (linux_nat_target::static_tracepoint_markers_by_strid): Use
705         SCOPE_EXIT.
706
707 2019-01-23  Tom Tromey  <tom@tromey.com>
708             Pedro Alves  <palves@redhat.com>
709
710         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
711         (call_function_by_hand_dummy): Use SCOPE_EXIT.
712
713 2019-01-23  Tom Tromey  <tom@tromey.com>
714             Andrew Burgess  <andrew.burgess@embecosm.com>
715             Pedro Alves  <palves@redhat.com>
716
717         * infrun.c (fetch_inferior_event): Use scope_exit.
718         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
719         * top.c (execute_command): Use scope_exit.
720         * breakpoint.c (bpstat_do_actions): Use scope_exit.
721         * utils.c (do_bpstat_clear_actions_cleanup)
722         (make_bpstat_clear_actions_cleanup): Remove.
723
724 2019-01-23  Tom Tromey  <tom@tromey.com>
725             Pedro Alves  <palves@redhat.com>
726
727         * infrun.c: Include "common/scope-exit.h"
728         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
729         (wait_for_inferior): Use SCOPE_EXIT.
730         (fetch_inferior_event): Use scope_exit.
731
732 2019-01-23  Tom Tromey  <tom@tromey.com>
733             Pedro Alves  <palves@redhat.com>
734
735         * breakpoint.c (create_breakpoint): Remove cleanup.
736
737 2019-01-23  Tom Tromey  <tom@tromey.com>
738             Andrew Burgess  <andrew.burgess@embecosm.com>
739             Pedro Alves  <palves@redhat.com>
740
741 2019-01-23  Pedro Alves  <palves@redhat.com>
742
743         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
744
745 2019-01-23  Pedro Alves  <palves@redhat.com>
746             Andrew Burgess  <andrew.burgess@embecosm.com>
747
748         * gdbthread.h: Include "common/forward-scope-exit.h".
749         (scoped_finish_thread_state): Redefine custom class in terms of
750         forward_scope_exit.
751
752 2019-01-23  Pedro Alves  <palves@redhat.com>
753             Andrew Burgess  <andrew.burgess@embecosm.com>
754
755         * common/forward-scope-exit.h: New file.
756
757 2019-01-23  Pedro Alves  <palves@redhat.com>
758             Andrew Burgess  <andrew.burgess@embecosm.com>
759             Tom Tromey  <tom@tromey.com>
760
761         * common/scope-exit.h: New file.
762
763 2019-01-23  Pedro Alves  <palves@redhat.com>
764
765         * common/preprocessor.h (ESC): Rename to ...
766         (ESC_PARENS): ... this.
767         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
768         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
769
770 2019-01-23  Tom Tromey  <tom@tromey.com>
771
772         * language.h (class scoped_switch_to_sym_language_if_auto):
773         Initialize m_lang in both cases.
774
775 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
776
777         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
778         with XCNEW.
779
780 2019-01-22  Tom Tromey  <tom@tromey.com>
781
782         * corelow.c: Do not include sys/file.h.
783
784 2019-01-22  Tom Tromey  <tom@tromey.com>
785
786         * tui/tui-wingeneral.h: Include gdb_curses.h.
787
788 2019-01-22  Tom Tromey  <tom@tromey.com>
789
790         * source-cache.h (class source_cache) <get_source_lines,
791         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
792
793 2019-01-22  Tom Tromey  <tom@tromey.com>
794
795         * remote-fileio.h (struct remote_target): Declare.
796
797 2019-01-22  Tom Tromey  <tom@tromey.com>
798
799         * python/py-arch.c: Do not include py-ref.h.
800         * python/py-bpevent.c: Do not include py-ref.h.
801         * python/py-cmd.c: Do not include py-ref.h.
802         * python/py-continueevent.c: Do not include py-ref.h.
803         * python/py-event.h: Do not include py-ref.h.
804         * python/py-evtregistry.c: Do not include py-ref.h.
805         * python/py-finishbreakpoint.c: Do not include py-ref.h.
806         * python/py-frame.c: Do not include py-ref.h.
807         * python/py-framefilter.c: Do not include py-ref.h.
808         * python/py-function.c: Do not include py-ref.h.
809         * python/py-infevents.c: Do not include py-ref.h.
810         * python/py-linetable.c: Do not include py-ref.h.
811         * python/py-objfile.c: Do not include py-ref.h.
812         * python/py-param.c: Do not include py-ref.h.
813         * python/py-prettyprint.c: Do not include py-ref.h.
814         * python/py-progspace.c: Do not include py-ref.h.
815         * python/py-symbol.c: Do not include py-ref.h.
816         * python/py-symtab.c: Do not include py-ref.h.
817         * python/py-type.c: Do not include py-ref.h.
818         * python/py-unwind.c: Do not include py-ref.h.
819         * python/py-utils.c: Do not include py-ref.h.
820         * python/py-value.c: Do not include py-ref.h.
821         * python/py-varobj.c: Do not include py-ref.h.
822         * python/py-xmethods.c: Do not include py-ref.h.
823         * python/python.c: Do not include py-ref.h.
824         * varobj.c: Do not include py-ref.h.
825
826 2019-01-22  Tom Tromey  <tom@tromey.com>
827
828         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
829         keyword for bcache.
830
831 2019-01-22  Tom Tromey  <tom@tromey.com>
832
833         * compile/compile-cplus-types.c: Remove a comment by #include.
834
835 2019-01-22  Tom Tromey  <tom@tromey.com>
836
837         * compile/gcc-c-plugin.h: Include compile-internal.h.
838
839 2019-01-22  Tom Tromey  <tom@tromey.com>
840
841         * stabsread.c (EXTERN): Do not define.
842         (symnum, next_symbol_text_func, processing_gcc_compilation)
843         (within_function, global_sym_chain, global_stabs)
844         (previous_stab_code, this_object_header_files)
845         (n_this_object_header_files)
846         (n_allocated_this_object_header_files): Define.
847         * stabsread.h (EXTERN): Never define.  Use "extern".
848
849 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
850
851         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
852         history_value.
853
854 2019-01-21  Tom Tromey  <tom@tromey.com>
855
856         * ui-out.c: Fix includes.
857         * tui/tui-source.c: Fix includes.
858         * target.c: Fix includes.
859         * remote.c: Fix includes.
860         * regcache.c: Fix includes.
861         * python/py-block.c: Fix includes.
862         * printcmd.c: Fix includes.
863         * or1k-tdep.c: Fix includes.
864         * mi/mi-main.c: Fix includes.
865         * m32r-tdep.c: Fix includes.
866         * csky-tdep.c: Fix includes.
867         * compile/compile-cplus-types.c: Fix includes.
868         * cli/cli-interp.c: Fix includes.
869
870 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
871
872         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
873         for padding.
874
875 2019-01-16  Tom Tromey  <tom@tromey.com>
876
877         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
878         earlier.
879         (struct objfile) <msymbols_range>: Move from top level.
880         <msymbols>: New method.
881         (class objfile_msymbols): Remove.
882         * symtab.c (default_collect_symbol_completion_matches_break_on):
883         Update.
884         * symmisc.c (dump_msymbols): Update.
885         * stabsread.c (scan_file_globals): Update.
886         * objc-lang.c (info_selectors_command, info_classes_command)
887         (find_methods): Update.
888         * minsyms.c (find_solib_trampoline_target): Update.
889         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
890         * coffread.c (coff_symfile_read): Update.
891         * ada-lang.c (ada_lookup_simple_minsym)
892         (ada_collect_symbol_completion_matches): Update.
893
894 2019-01-16  Tom Tromey  <tom@tromey.com>
895
896         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
897         type.  Remove no-argument constructor.
898         <iterator::operator++>: Simplify.
899         <begin>: Update.
900         <end>: Use minimal_symbol_count.
901
902 2019-01-16  Tom Tromey  <tom@tromey.com>
903
904         * objfiles.h (struct objfile) <psymtabs>: New method.
905         (class objfile_psymtabs): Remove.
906         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
907         typedef.
908         <range>: New method.
909         (require_partial_symbols): Change return type.
910         * psymtab.c (require_partial_symbols)
911         (psym_expand_symtabs_matching): Update.
912         * mdebugread.c (parse_partial_symbols): Update.
913         * dbxread.c (dbx_end_psymtab): Update.
914
915 2019-01-15  Tom Tromey  <tom@tromey.com>
916
917         * symtab.c (lookup_objfile_from_block)
918         (lookup_symbol_in_objfile_symtabs)
919         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
920         (find_line_symtab, info_sources_command)
921         (default_collect_symbol_completion_matches_break_on)
922         (make_source_files_completion_list): Update.
923         * symmisc.c (print_objfile_statistics, dump_objfile)
924         (maintenance_print_symbols, maintenance_info_symtabs)
925         (maintenance_check_symtabs, maintenance_info_line_tables):
926         Update.
927         * source.c (select_source_symtab)
928         (forget_cached_source_info_for_objfile): Update.
929         * objfiles.h (class objfile_compunits): Remove.
930         (struct objfile) <compunits_range>: New typedef.
931         (compunits): New method.
932         * objfiles.c (objfile_relocate1): Update.
933         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
934         * maint.c (count_symtabs_and_blocks): Update.
935         * linespec.c (iterate_over_all_matching_symtabs): Update.
936         * cp-support.c (add_symbol_overload_list_qualified): Update.
937         * coffread.c (coff_symtab_read): Update.
938         * ada-lang.c (add_nonlocal_symbols)
939         (ada_collect_symbol_completion_matches)
940         (ada_add_global_exceptions): Update.
941
942 2019-01-15  Tom Tromey  <tom@tromey.com>
943
944         * progspace.h (program_space) <objfiles_safe_range>: New
945         typedef.
946         <objfiles_safe>: New method.
947         * objfiles.h (class all_objfiles_safe): Remove.
948         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
949         * jit.c (jit_inferior_exit_hook): Update.
950
951 2019-01-17  Tom Tromey  <tom@tromey.com>
952
953         * progspace.h (program_space) <objfiles_range>: New typedef.
954         <objfiles>: New method.
955         <objfiles_head>: Rename from objfiles.
956         (object_files): Update.
957         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
958         * guile/scm-pretty-print.c
959         (ppscm_find_pretty_printer_from_objfiles): Update.
960         * guile/scm-objfile.c (gdbscm_objfiles): Update.
961         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
962         Update.
963         * python/py-progspace.c (pspy_get_objfiles): Update.
964         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
965         Update.
966         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
967         (objfpy_lookup_objfile_by_build_id): Update.
968         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
969         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
970         Update.
971         * symtab.c (iterate_over_symtabs, matching_obj_sections)
972         (expand_symtab_containing_pc, lookup_objfile_from_block)
973         (lookup_static_symbol, basic_lookup_transparent_type)
974         (find_pc_sect_compunit_symtab, find_symbol_at_address)
975         (find_line_symtab, info_sources_command)
976         (default_collect_symbol_completion_matches_break_on)
977         (make_source_files_completion_list, find_main_name): Update.
978         * symmisc.c (print_symbol_bcache_statistics)
979         (print_objfile_statistics, maintenance_print_symbols)
980         (maintenance_print_msymbols, maintenance_print_objfiles)
981         (maintenance_info_symtabs, maintenance_check_symtabs)
982         (maintenance_expand_symtabs, maintenance_info_line_tables):
983         Update.
984         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
985         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
986         (map_overlay_command, unmap_overlay_command)
987         (simple_overlay_update, expand_symtabs_matching)
988         (map_symbol_filenames): Update.
989         * symfile-debug.c (set_debug_symfile): Update.
990         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
991         Update.
992         * source.c (select_source_symtab, forget_cached_source_info):
993         Update.
994         * solib.c (solib_read_symbols): Update.
995         * solib-spu.c (append_ocl_sos): Update.
996         * psymtab.c (maintenance_print_psymbols)
997         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
998         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
999         * printcmd.c (info_symbol_command): Update.
1000         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1001         Update.
1002         * objfiles.h (class all_objfiles): Remove.
1003         * objfiles.c (have_partial_symbols, have_full_symbols)
1004         (have_minimal_symbols, qsort_cmp, update_section_map)
1005         (shared_objfile_contains_address_p)
1006         (default_iterate_over_objfiles_in_search_order): Update.
1007         * objc-lang.c (info_selectors_command, info_classes_command)
1008         (find_methods): Update.
1009         * minsyms.c (find_solib_trampoline_target): Update.
1010         * maint.c (maintenance_info_sections)
1011         (maintenance_translate_address, count_symtabs_and_blocks):
1012         Update.
1013         * main.c (captured_main_1): Update.
1014         * linux-thread-db.c (try_thread_db_load_from_pdir)
1015         (has_libpthread): Update.
1016         * linespec.c (iterate_over_all_matching_symtabs)
1017         (search_minsyms_for_name): Update.
1018         * jit.c (jit_find_objf_with_entry_addr): Update.
1019         * hppa-tdep.c (find_unwind_entry)
1020         (hppa_lookup_stub_minimal_symbol): Update.
1021         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1022         Update.
1023         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1024         (elf_gnu_ifunc_resolve_by_got): Update.
1025         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1026         * dwarf-index-write.c (save_gdb_index_command): Update.
1027         * cp-support.c (add_symbol_overload_list_qualified): Update.
1028         * breakpoint.c (create_overlay_event_breakpoint)
1029         (create_longjmp_master_breakpoint)
1030         (create_std_terminate_master_breakpoint)
1031         (create_exception_master_breakpoint): Update.
1032         * blockframe.c (find_pc_partial_function): Update.
1033         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1034         (ada_collect_symbol_completion_matches)
1035         (ada_add_global_exceptions): Update.
1036
1037 2019-01-17  Tom Tromey  <tom@tromey.com>
1038
1039         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1040         declare VEC.
1041         (solib_target_parse_libraries): Change return type.
1042         (library_list_start_segment, library_list_start_section)
1043         (library_list_end_library, library_list_start_library); Update.
1044         (solib_target_free_library_list): Remove.
1045         (solib_target_parse_libraries): Remove cleanup.  Change return
1046         type.
1047         (solib_target_current_sos): Update.
1048
1049 2019-01-17  Tom Tromey  <tromey@bapiya>
1050
1051         * valprint.c: Replace "the the" with "the".
1052         * symtab.c: Replace "the the" with "the".
1053         * solib.c: Replace "the the" with "the".
1054         * solib-dsbt.c: Replace "the the" with "the".
1055         * linespec.c: Replace "the the" with "the".
1056         * dwarf2loc.h: Replace "the the" with "the".
1057         * amd64-windows-tdep.c: Replace "the the" with "the".
1058         * aarch64-tdep.c: Replace "the the" with "the".
1059
1060 2019-01-16  Keith Seitz  <keiths@redhat.com>
1061
1062         PR gdb/23773
1063         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1064         <builder>: Rename to ..
1065         <m_builder>: ... this and make private.
1066         (dwarf2_cu::get_builder): New method.  Change all users of
1067         `builder' to use this method.
1068         (dwarf2_start_symtab): Move to ...
1069         (dwarf2_cu::start_symtab): ... here.  Update all callers
1070         (setup_type_unit_groups): Move to ...
1071         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1072         callers.
1073         (dwarf2_cu::reset_builder): New method.
1074         (process_full_compunit, process_full_type_unit): Use
1075         dwarf2_cu::reset_builder.
1076         (follow_die_offset): Record the ancestor CU if it is different
1077         from the followed DIE's CU.
1078         (follow_die_sig_1): Likewise.
1079
1080 2019-01-15  Tom Tromey  <tom@tromey.com>
1081
1082         * remote.c (class remote_state) <buf>: Now a char_vector.
1083         <buf_size>: Remove.
1084         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1085         parameter.
1086         (remote_target::getpkt_or_notif_sane_1)
1087         (remote_target::getpkt_sane)
1088         (remote_target::getpkt_or_notif_sane): Likewise.
1089         (class remote_target) <putpkt>: New overload.
1090         (remote_target::read_frame): Change type of "buf_p".  Remove
1091         sizeof_p parameter.
1092         (packet_ok): New overload.
1093         (packet_check_result): New overload.
1094         Update all uses.
1095
1096 2019-01-14  Tom Tromey  <tom@tromey.com>
1097
1098         * remote-notif.c (handle_notification, remote_notif_ack)
1099         (remote_notif_parse): Make "buf" const.
1100         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1101         const.
1102         (remote_notif_parse, remote_notif_ack, handle_notification):
1103         Likewise.
1104         * remote.c (remote_notif_stop_parse): Make "buf" const.
1105         (remote_target::remote_parse_stop_reply): Make "buf" const.
1106         (remote_notif_stop_ack): Make "buf" const.
1107
1108 2019-01-14  Tom Tromey  <tom@tromey.com>
1109
1110         * remote.c (remote_console_output): Make parameter const.
1111
1112 2019-01-14  Tom Tromey  <tom@tromey.com>
1113
1114         * target-debug.h (target_debug_print_signals): Constify.
1115         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1116         * procfs.c (procfs_target::pass_signals): Update.
1117         * linux-nat.c (linux_nat_target::pass_signals): Update.
1118         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1119         * target-delegates.c: Rebuild.
1120         * remote.c (remote_target::program_signals): Update.
1121         (remote_target::pass_signals): Update.
1122         * target.c (target_pass_signals): Constify argument.
1123         (target_program_signals): Likewise.
1124         * target.h (struct target_ops) <pass_signals, program_signals>:
1125         Constify argument.
1126         (target_pass_signals, target_program_signals): Constify argument.
1127
1128 2019-01-14  Tom Tromey  <tom@tromey.com>
1129
1130         PR tui/28819:
1131         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1132
1133 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1134
1135         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1136         field.
1137         * rs6000-tdep.c: Include reggroups.h.
1138         (IS_V_ALIAS_PSEUDOREG): Define.
1139         (rs6000_register_name): Return names for the "vX" aliases.
1140         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1141         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1142         aliases.  Call default_register_reggroup_p for all other
1143         pseudo-registers.
1144         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1145         New functions.
1146         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1147         Handle "vX" aliases.
1148         (v_alias_pseudo_register_collect): New function.
1149         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1150         (rs6000_gdbarch_init): Initialize "vX" aliases as
1151         pseudo-registers.  Restore registration of
1152         rs6000_pseudo_register_reggroup_p with
1153         set_tdesc_pseudo_register_reggroup_p.
1154
1155 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1156
1157         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1158         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1159         set_gdbarch_num_pseudo_regs.
1160
1161 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1162
1163         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1164         Remove arg prefixname, add do_set and do_show.
1165         Add member functions set_list and show_list.
1166         * cli/cli-style.c (class cli_style_option): Update accordingly.
1167         (style_set_list): Move to file scope.
1168         (style_show_list): Likewise.
1169         (set_style): Call help_list.
1170         (show_style): Call cmd_show_list.
1171         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1172         Update to use the new macro.
1173
1174 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1175
1176         * ada-lang.c (_initialize_ada_language): Expand the help text
1177         for the "catch exception" command.
1178
1179 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1180
1181         * symtab.c (matching_obj_sections): Initialize obj,
1182         declare it closer to its usage.
1183
1184 2019-01-10  Tom Tromey  <tom@tromey.com>
1185
1186         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1187         (basic_inf_threads_range): Remove.
1188         (inf_threads_range, inf_non_exited_threads_range)
1189         (safe_inf_threads_range): Use next_adapter.
1190
1191 2019-01-10  Keith Seitz  <keiths@redhat.com>
1192
1193         PR gdb/23712
1194         PR symtab/23010
1195         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1196         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1197
1198 2019-01-10  Keith Seitz  <keiths@redhat.com>
1199
1200         PR gdb/23712
1201         PR symtab/23010
1202         * dictionary.c (pending_to_vector): Remove.
1203         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1204         Remove _1 suffix, replacing functions of the same name.  Update
1205         all callers.
1206         (dict_create_hashed, dict_create_hashed_expandable)
1207         (dict_create_linear, dict_create_linear_expandable, dict_free)
1208         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1209         Make functions static.
1210
1211 2019-01-10  Keith Seitz  <keiths@redhat.com>
1212
1213         PR gdb/23712
1214         PR symtab/23010
1215         * dictionary.h (struct dictionary): Replace declaration with
1216         multidictionary.
1217         (dict_create_hashed, dict_create_hashed_expandable)
1218         (dict_create_linear, dict_create_linear_expandable)
1219         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1220         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1221         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1222         taking multidictionary argument.
1223         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1224         * block.h (struct block) <dict>: Change to multidictionary
1225         and rename `multidict'.
1226         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1227         symmisc.c: Update all dictionary references to multidictionary.
1228
1229 2019-01-10  Keith Seitz  <keiths@redhat.com>
1230
1231         PR gdb/23712
1232         PR symtab/23010
1233         * dictionary.c: Include unordered_map.
1234         (pending_to_vector): New function.
1235         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1236         Rewrite the non-"_1" functions to take vector instead
1237         of linked list.
1238         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1239         "new" _1 versions of the same name.
1240         (multidictionary): Define.
1241         (std::hash<enum language): New definition.
1242         (collate_pending_symbols_by_language, mdict_create_hashed)
1243         (mdict_create_hashed_expandable, mdict_create_linear)
1244         (mdict_create_linear_expandable, mdict_free)
1245         (find_language_dictionary, create_new_language_dictionary)
1246         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1247         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1248         (mdict_size, mdict_empty): New functions.
1249         * dictionary.h (mdict_iterator): Define.
1250
1251 2019-01-10  Pedro Alves  <palves@redhat.com>
1252
1253         * breakpoint.c (read_uploaded_action)
1254         (create_tracepoint_from_upload): Adjust to use
1255         gdb::unique_xmalloc_ptr.
1256         * ctf.c (ctf_write_uploaded_tp):
1257         (SET_ARRAY_FIELD): Use emplace_back.
1258         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1259         * tracefile-tfile.c (tfile_write_uploaded_tp):
1260         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1261         gdb::unique_xmalloc_ptr.
1262         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1263         at_string, cond_string, cmd_strings>: Replace char pointers
1264         with gdb::unique_xmalloc_ptr.
1265
1266 2019-01-10  Pedro Alves  <palves@redhat.com>
1267
1268         * solib-target.c (library_list_start_library): Don't xstrdup name.
1269
1270 2019-01-10  Pedro Alves  <palves@redhat.com>
1271
1272         * mdebugread.c (parse_partial_symbols): Use
1273         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1274
1275 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1276
1277         * linux-fork.c (scoped_switch_fork_info)
1278         <~scoped_switch_fork_info>: Fix incorrect variable name.
1279
1280 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1281
1282         * linux-fork.c (scoped_switch_fork_info)
1283         <scoped_switch_fork_info>: Make explicit.
1284         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1285
1286 2019-01-10  Tom Tromey  <tom@tromey.com>
1287
1288         * objfiles.h (objfile::reset_psymtabs): Update.
1289         * objfiles.c (objfile::objfile): Update.
1290         * psymtab.h (psymtab_storage::obstack): Update.
1291         (psymtab_storage::m_obstack): Use gdb::optional.
1292         (class psymtab_storage): Update comment.  Remove objfile
1293         parameter.
1294         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1295
1296 2019-01-10  Tom Tromey  <tom@tromey.com>
1297
1298         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1299         <free_psymtabs>: Now private.
1300         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1301         (allocate_psymtab): Use new method.
1302
1303 2019-01-10  Tom Tromey  <tom@tromey.com>
1304
1305         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1306         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1307         * mdebugread.c (parse_partial_symbols): Use
1308         allocate_dependencies.
1309         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1310         allocate_dependencies.
1311         (process_psymtab_comp_unit_reader)
1312         (build_type_psymtab_dependencies): Likewise.
1313         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1314
1315 2019-01-10  Tom Tromey  <tom@tromey.com>
1316
1317         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1318         PSYMBOL_SET_LANGUAGE.
1319         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1320
1321 2019-01-10  Tom Tromey  <tom@tromey.com>
1322
1323         * psymtab.h (psymtab_storage::obstack): New method.
1324         <m_obstack>: Rename from obstack; now private.
1325         * psymtab.c (psymtab_storage): Update.
1326         * dwarf2read.c (create_addrmap_from_index)
1327         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1328         Update.
1329
1330 2019-01-10  Tom Tromey  <tom@tromey.com>
1331
1332         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1333         * objfiles.h (objfile::reset_psymtabs): New method.
1334
1335 2019-01-10  Tom Tromey  <tom@tromey.com>
1336
1337         * symmisc.c (print_symbol_bcache_statistics): Update.
1338         (print_objfile_statistics): Update.
1339         * symfile.c (reread_symbols): Update.
1340         * psymtab.h (class psymtab_storage): New.
1341         * psymtab.c (psymtab_storage): New constructor.
1342         (~psymtab_storage): New destructor.
1343         (require_partial_symbols): Update.
1344         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1345         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1346         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1347         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1348         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1349         (start_psymtab_common, end_psymtab_common)
1350         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1351         (allocate_psymtab): Update.
1352         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1353         Update.
1354         (dump_psymtab_addrmap, maintenance_print_psymbols)
1355         (maintenance_check_psymtabs): Update.
1356         (class objfile_psymtabs): Move to objfiles.h.
1357         * psympriv.h (discard_psymtab): Now inline.
1358         (psymtab_discarder::psymtab_discarder): Update.
1359         (psymtab_discarder::~psymtab_discarder): Update.
1360         (ALL_OBJFILE_PSYMTABS): Rewrite.
1361         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1362         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1363         Remove fields.
1364         <partial_symtabs>: New field.
1365         (class objfile_psymtabs): Move from psymtab.h.  Update.
1366         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1367         psymbol_cache.
1368         (objfile::~objfile): Don't destroy psymbol_cache.
1369         * mdebugread.c (parse_partial_symbols): Update.
1370         * dwarf2read.c (create_addrmap_from_index)
1371         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1372         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1373         (add_partial_subprogram, dwarf2_ranges_read): Update.
1374         * dwarf-index-write.c (write_address_map)
1375         (write_one_signatured_type, recursively_write_psymbols)
1376         (class debug_names, class debug_names, write_psymtabs_to_index):
1377         Update.
1378
1379 2019-01-10  Tom Tromey  <tom@tromey.com>
1380
1381         * symtab.h (SYMBOL_SET_NAMES): Update.
1382         (symbol_set_names): Update.
1383         (MSYMBOL_SET_NAMES): Update.
1384         * symtab.c (symbol_set_names): Change argument to be an
1385         objfile_per_bfd_storage.
1386         * psymtab.c (add_psymbol_to_bcache): Update.
1387         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1388
1389 2019-01-10  Tom Tromey  <tom@tromey.com>
1390
1391         * symtab.c (create_demangled_names_hash): Change argument to be an
1392         objfile_per_bfd_storage.
1393         (symbol_set_names): Update.
1394
1395 2019-01-10  Tom Tromey  <tom@tromey.com>
1396
1397         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1398         init_psymbol_list.
1399         * psymtab.c (init_psymbol_list): Do nothing if already called.
1400         * psympriv.h (init_psymbol_list): Add comment.
1401         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1402         init_psymbol_list.
1403         * dbxread.c (dbx_symfile_read): Unconditionally call
1404         init_psymbol_list.
1405
1406 2019-01-10  Tom Tromey  <tom@tromey.com>
1407
1408         * xcoffread.c (scan_xcoff_symtab): Update.
1409         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1410         "where".
1411         * mdebugread.c (parse_partial_symbols)
1412         (handle_psymbol_enumerators): Update.
1413         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1414         * dbxread.c (read_dbx_symtab): Update.
1415         * psympriv.h (psymbol_placement): New enum.
1416         (add_psymbol_to_list): Update.
1417
1418 2019-01-10  Tom Tromey  <tom@tromey.com>
1419
1420         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1421         static_psymbols parameters.
1422         (scan_xcoff_symtab): Update.
1423         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1424         static_psymbols parameters.
1425         * psympriv.h (start_psymtab_common): Update.
1426         * mdebugread.c (parse_partial_symbols): Update.
1427         * dwarf2read.c (create_partial_symtab): Update.
1428         * dbxread.c (read_dbx_symtab): Update.
1429         (start_psymtab): Remove global_psymbols and static_psymbols
1430         parameters.
1431
1432 2019-01-10  Tom Tromey  <tom@tromey.com>
1433
1434         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1435         * psymtab.c (allocate_psymtab): Add comment.
1436         * psympriv.h (allocate_psymtab): Add comment.
1437         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1438         initializations.
1439         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1440
1441 2019-01-10  Tom Tromey  <tom@tromey.com>
1442
1443         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1444         Don't declare.
1445         * mipsread.c: Include mdebugread.h.
1446         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1447         Declare.
1448         * elfread.c: Include mdebugread.h.
1449
1450 2019-01-09  Tom Tromey  <tom@tromey.com>
1451
1452         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1453         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1454         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1455         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1456         (psym_lookup_symbol, psym_find_last_source_symtab)
1457         (psym_forget_cached_source_info, psym_print_stats)
1458         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1459         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1460         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1461         (psym_find_compunit_symtab_by_address)
1462         (maintenance_print_psymbols, maintenance_info_psymtabs)
1463         (maintenance_check_psymtabs): Use ranged for.
1464         * psymtab.h (class objfile_psymtabs): New.
1465         (require_partial_symbols): Return objfile_psymtabs.
1466         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1467
1468 2019-01-09  Tom Tromey  <tom@tromey.com>
1469
1470         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1471         (find_pc_mapped_section, list_overlays_command)
1472         (map_overlay_command, unmap_overlay_command)
1473         (simple_overlay_update): Use all_objfiles.
1474         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1475         * printcmd.c (info_symbol_command): Use all_objfiles.
1476         * objfiles.h (ALL_OBJSECTIONS): Remove.
1477         * maint.c (maintenance_translate_address): Use all_objfiles.
1478         * gcore.c (gcore_create_callback): Use all_objfiles.
1479         (objfile_find_memory_regions): Likewise.
1480
1481 2019-01-09  Tom Tromey  <tom@tromey.com>
1482
1483         * symtab.c (find_line_symtab, info_sources_command)
1484         (make_source_files_completion_list): Use objfile_compunits.
1485         * source.c (select_source_symtab): Use objfile_compunits.
1486         * objfiles.h (struct objfile): Update comment.
1487         (ALL_OBJFILES): Remove.
1488         (ALL_FILETABS): Remove.
1489         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1490         objfile_compunits.
1491
1492 2019-01-09  Tom Tromey  <tom@tromey.com>
1493
1494         * symmisc.c (print_objfile_statistics, dump_objfile)
1495         (maintenance_print_symbols): Use compunit_filetabs.
1496         * source.c (forget_cached_source_info_for_objfile): Use
1497         compunit_filetabs.
1498         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1499         (ALL_FILETABS): Use compunit_filetabs.
1500         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1501         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1502
1503 2019-01-09  Tom Tromey  <tom@tromey.com>
1504
1505         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1506         (compunit_filetabs): New.
1507         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1508         compunit_filetabs.
1509         (info_sources_command, make_source_files_completion_list): Remove
1510         declaration.
1511         * symmisc.c (print_objfile_statistics, dump_objfile)
1512         (maintenance_print_symbols): Remove declaration.
1513         (maintenance_info_symtabs): Use compunit_filetabs.
1514         (maintenance_info_line_tables): Likewise.
1515         * source.c (select_source_symtab): Change local variable name.
1516         (forget_cached_source_info_for_objfile): Remove declaration.
1517         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1518         * objfiles.c (objfile_relocate1): Remove declaration.
1519         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1520         declaration.
1521         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1522         * coffread.c (coff_symtab_read): Remove declaration.
1523         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1524         compunit_filetabs.
1525
1526 2019-01-09  Tom Tromey  <tom@tromey.com>
1527
1528         * symtab.c (lookup_objfile_from_block)
1529         (find_pc_sect_compunit_symtab, search_symbols)
1530         (default_collect_symbol_completion_matches_break_on): Use
1531         objfile_compunits.
1532         * objfiles.h (ALL_COMPUNITS): Remove.
1533         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1534         * cp-support.c (add_symbol_overload_list_qualified): Use
1535         objfile_compunits.
1536         * ada-lang.c (ada_collect_symbol_completion_matches)
1537         (ada_add_global_exceptions): Use objfile_compunits.
1538
1539 2019-01-09  Tom Tromey  <tom@tromey.com>
1540
1541         * source.c (select_source_symtab)
1542         (forget_cached_source_info_for_objfile): Remove declaration.
1543         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1544         declaration.
1545         * maint.c (count_symtabs_and_blocks): Remove declaration.
1546         * cp-support.c (add_symbol_overload_list_qualified): Remove
1547         declaration.
1548         * coffread.c (coff_symtab_read): Remove declaration.
1549         * symtab.c (lookup_symbol_in_objfile_symtabs)
1550         (basic_lookup_transparent_type_1): Use objfile_compunits.
1551         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1552         (info_sources_command, search_symbols)
1553         (default_collect_symbol_completion_matches_break_on)
1554         (make_source_files_completion_list): Remove declaration.
1555         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1556         (ada_collect_symbol_completion_matches)
1557         (ada_add_global_exceptions): Remove declaration.
1558         * linespec.c (iterate_over_all_matching_symtabs): Use
1559         objfile_compunits.
1560         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1561         (class objfile_compunits): New.
1562         (ALL_COMPUNITS): Use objfile_compunits.
1563         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1564         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1565         objfile_compunits.
1566         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1567
1568 2019-01-09  Tom Tromey  <tom@tromey.com>
1569
1570         * symtab.c (search_symbols)
1571         (default_collect_symbol_completion_matches_break_on): Use
1572         objfile_msymbols.
1573         * ada-lang.c (ada_lookup_simple_minsym)
1574         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1575         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1576         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1577         objfile_msymbols.
1578         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1579         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1580         * objc-lang.c (find_methods): Use objfile_msymbols.
1581         (info_selectors_command, info_classes_command): Likewise.
1582         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1583         * objfiles.h (class objfile_msymbols): New.
1584         (ALL_OBJFILE_MSYMBOLS): Remove.
1585         (ALL_MSYMBOLS): Remove.
1586
1587 2019-01-09  Tom Tromey  <tom@tromey.com>
1588
1589         * common/next-iterator.h (next_adapter): Add Iterator template
1590         parameter.
1591         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1592         (class all_objfiles_safe): New.
1593         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1594         * objfiles.c (put_objfile_before): Update comment.
1595         (add_separate_debug_objfile): Likewise.
1596         (free_all_objfiles): Use all_objfiles_safe.
1597         (objfile_purge_solibs): Likewise.
1598
1599 2019-01-09  Tom Tromey  <tom@tromey.com>
1600
1601         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1602         (expand_symtab_containing_pc, lookup_static_symbol)
1603         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1604         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1605         all_objfiles.
1606         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1607         * breakpoint.c (create_overlay_event_breakpoint)
1608         (create_longjmp_master_breakpoint)
1609         (create_std_terminate_master_breakpoint)
1610         (create_exception_master_breakpoint): Use all_objfiles.
1611         * linux-thread-db.c (try_thread_db_load_from_pdir)
1612         (has_libpthread): Use all_objfiles.
1613         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1614         * linespec.c (iterate_over_all_matching_symtabs)
1615         (search_minsyms_for_name): Use all_objfiles.
1616         * maint.c (maintenance_info_sections): Use all_objfiles.
1617         * main.c (captured_main_1): Use all_objfiles.
1618         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1619         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1620         * guile/scm-pretty-print.c
1621         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1622         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1623         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1624         (maintenance_print_msymbols): Use all_objfiles.
1625         * source.c (select_source_symtab): Use all_objfiles.
1626         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1627         * symfile.c (remove_symbol_file_command)
1628         (expand_symtabs_matching, map_symbol_filenames): Use
1629         all_objfiles.
1630         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1631         all_objfiles.
1632         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1633         * objc-lang.c (find_methods): Use all_objfiles.
1634         * objfiles.c (have_partial_symbols, have_full_symbols)
1635         (have_minimal_symbols, qsort_cmp)
1636         (default_iterate_over_objfiles_in_search_order): Use
1637         all_objfiles.
1638         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1639         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1640         (maintenance_check_psymtabs): Use all_objfiles.
1641         (ALL_PSYMTABS): Remove.
1642         * compile/compile-object-run.c (do_module_cleanup): Use
1643         all_objfiles.
1644         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1645         * cp-support.c (add_symbol_overload_list_qualified): Use
1646         all_objfiles.
1647         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1648         Use all_objfiles.
1649         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1650         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1651         all_objfiles.
1652         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1653         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1654         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1655         Uses all_objfiles.
1656         * solib.c (solib_read_symbols): Use all_objfiles
1657
1658 2019-01-09  Tom Tromey  <tom@tromey.com>
1659
1660         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1661         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1662         all_objfiles.
1663         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1664         * symmisc.c (print_symbol_bcache_statistics)
1665         (print_objfile_statistics, maintenance_print_objfiles)
1666         (maintenance_info_symtabs, maintenance_check_symtabs)
1667         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1668         all_objfiles.
1669         * source.c (forget_cached_source_info): Use all_objfiles.
1670         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1671         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1672         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1673         * objfiles.c (update_section_map): Use all_objfiles.
1674         (shared_objfile_contains_address_p): Likewise.
1675         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1676         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1677
1678 2019-01-09  Tom Tromey  <tom@tromey.com>
1679
1680         * common/next-iterator.h: New file.
1681         * objfiles.h (class all_objfiles): New.
1682         (struct objfile_iterator): New.
1683
1684 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1685
1686         * NEWS: Move the description of the changed "frame", "select-frame",
1687          and "info frame" commands to the Changed commands section.
1688
1689 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1690
1691         * gdbtypes.c (check_stub_method_group): Remove handling of old
1692         mangling schemes.
1693         * linespec.c (find_methods): Likewise.
1694         * stabsread.c (read_member_functions): Likewise.
1695         * valops.c (search_struct_method): Likewise.
1696         (value_struct_elt_for_reference): Likewise.
1697         * NEWS: Mention this change.
1698
1699 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1700
1701         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1702         print_source_lines.
1703         * source.c (print_source_lines_base): Update line number check.
1704         (print_source_lines): New function.
1705         (source_lines_range::source_lines_range): New function.
1706         * source.h (class source_lines_range): New class.
1707         (print_source_lines): New declaration.
1708
1709 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1710
1711         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1712
1713 2019-01-08  Tom Tromey  <tom@tromey.com>
1714             Simon Marchi  <simon.marchi@ericsson.com>
1715
1716         PR gdb/24060
1717         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1718         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1719         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1720         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1721         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1722         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1723
1724 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1725
1726         * source.c (select_source_symtab): Move header comment to
1727         declaration in source.h.
1728         (forget_cached_source_info_for_objfile): Likewise.
1729         (forget_cached_source_info): Likewise.
1730         (identify_source_line): Likewise.
1731         * source.h (identify_source_line): Move declaration from symtab.h
1732         and add comment from source.c
1733         (print_source_lines): Likewise.
1734         (forget_cached_source_info_for_objfile): Likewise.
1735         (forget_cached_source_info): Likewise.
1736         (select_source_symtab): Likewise.
1737         (enum print_source_lines_flag): Move definition from symtab.h.
1738         * symtab.h (identify_source_line): Move declaration to source.h.
1739         (print_source_lines): Likewise.
1740         (forget_cached_source_info_for_objfile): Likewise.
1741         (forget_cached_source_info): Likewise.
1742         (select_source_symtab): Likewise.
1743         (enum print_source_lines_flag): Move definition to source.h.
1744         * tui/tui-hooks.c: Add 'source.h' include.
1745
1746 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1747
1748         * source.c (print_source_lines_base): Handle requests to print
1749         reverse line number sequences, and guard against empty lines
1750         string.
1751
1752 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1753
1754         * source.c (print_source_lines_base): Fix skip of '\r' if next
1755         character is '\n'.
1756
1757 2019-01-06  Tom Tromey  <tom@tromey.com>
1758
1759         * c-exp.y (struct c_parse_state) <macro_original_text,
1760         expansion_obstack>: New member.
1761         (macro_original_text, expansion_obstack): Remove globals.
1762         (scan_macro_expansion, scanning_macro_expansion)
1763         (finished_macro_expansion): Update.
1764         (scan_macro_cleanup): Remove.
1765         (yylex, c_parse): Update.
1766
1767 2019-01-06  Tom Tromey  <tom@tromey.com>
1768
1769         * c-exp.y (struct c_parse_state) <strings>: New member.
1770         (operator_stoken): Update.
1771
1772 2019-01-06  Tom Tromey  <tom@tromey.com>
1773
1774         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1775         (union type_stack_elt) <typelist_val>: Now a pointer to
1776         std::vector.
1777         (type_stack_cleanup): Don't declare.
1778         (push_typelist): Update.
1779         * parse.c (pop_typelist): Return a std::vector.
1780         (push_typelist): Take a std::vector.
1781         (follow_types): Update.  Do not free args.
1782         (type_stack_cleanup): Remove.
1783         * c-exp.y (struct c_parse_state): New.
1784         (cpstate): New global.
1785         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1786         (nonempty_typelist): Update.
1787         (func_mod): Create a new vector.
1788         (c_parse): Create a c_parse_state.
1789         (check_parameter_typelist): Do not delete params.
1790         (function_method): Update.  Do not delete type_list.
1791
1792 2019-01-06  Tom Tromey  <tom@tromey.com>
1793
1794         PR gdb/28155:
1795         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1796         check_typedef.
1797         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1798         (print_return_value): Likewise.
1799
1800 2019-01-05  Tom Tromey  <tom@tromey.com>
1801
1802         * contrib/cleanup_check.py: Remove.
1803         * contrib/gcc-with-excheck: Remove.
1804         * contrib/exsummary.py: Remove.
1805         * contrib/excheck.py: Remove.
1806
1807 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1808
1809         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1810         NULL. Initialize tpprev to NULL instead of assigning it
1811         to NULL on the next statement.
1812         * windows-nat.c (windows_delete_thread): Remove check for
1813         main_thread_id before printing thread exit notifications.
1814         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1815         Remove thread ID check against main_thread_id.
1816         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1817         windows_delete_thread.
1818         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1819
1820 2019-01-04  Tom Tromey  <tom@tromey.com>
1821
1822         * compile/compile.c (_initialize_compile): Use upper case for
1823         metasyntactic variables.
1824         * symmisc.c (_initialize_symmisc): Use upper case for
1825         metasyntactic variables.
1826         * psymtab.c (_initialize_psymtab): Use upper case for
1827         metasyntactic variables.
1828         * demangle.c (demangle_command): Use upper case for metasyntactic
1829         variables.
1830         (_initialize_demangler): Likewise.
1831         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1832         variables.
1833
1834 2019-01-03  Tom Tromey  <tom@tromey.com>
1835
1836         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1837
1838 2019-01-03  Tom Tromey  <tom@tromey.com>
1839
1840         * python/py-symtab.c (salpy_str): Update.
1841         (struct salpy_sal_object) <symtab>: Now a PyObject.
1842         (salpy_dealloc): Update.
1843         (del_objfile_sal): Use gdbpy_ref.
1844
1845 2019-01-03  Tom Tromey  <tom@tromey.com>
1846
1847         * python/py-type.c (convert_field): Use new_reference.  Return
1848         gdbpy_ref.
1849         (make_fielditem): Return gdbpy_ref.
1850         (typy_fields): Update.
1851         (typy_getitem): Update.
1852         (field_name): Return gdbpy_ref.  Use new_reference.
1853         (typy_iterator_iternext): Update.
1854
1855 2019-01-03  Tom Tromey  <tom@tromey.com>
1856
1857         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1858
1859 2019-01-03  Tom Tromey  <tom@tromey.com>
1860
1861         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1862         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1863         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1864         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1865         (pspy_set_type_printers): Likewise.
1866         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1867         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1868         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1869         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1870         (objfpy_set_type_printers): Likewise.
1871
1872 2019-01-03  Tom Tromey  <tom@tromey.com>
1873
1874         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1875         (gdbpy_print_stack): Use gdbpy_err_fetch.
1876         * python/python-internal.h (class gdbpy_err_fetch): New class.
1877         (class gdbpy_enter) <m_error_type, m_error_value,
1878         m_error_traceback>: Remove.
1879         <m_error>: New member.
1880         (gdbpy_exception_to_string): Don't declare.
1881         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1882         * python/py-value.c (convert_value_from_python): Use
1883         gdbpy_err_fetch.
1884         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1885         gdbpy_exception_to_string.
1886         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1887         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1888         gdbpy_err_fetch.
1889
1890 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1891
1892         * linux-nat.c (delete_lwp_cleanup): Delete.
1893         (struct lwp_deleter): New struct.
1894         (lwp_info_up): New typedef.
1895         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1896         lwp_info_up.
1897
1898 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1899
1900         * linux-fork.c (class scoped_switch_fork_info): New class.
1901         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1902
1903 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1904
1905         * valops.c (find_overload_match): Remove use of null_cleanup, and
1906         calls to do_cleanups.
1907
1908 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1909
1910         * compile/compile-cplus-types.c
1911         (compile_cplus_instance::decl_name): Handle changes to
1912         cp_func_name.
1913         * cp-support.c (cp_func_name): Update header comment, update
1914         return type.
1915         * cp-support.h (cp_func_name): Update return type in declaration.
1916         * valops.c (find_overload_match): Move temp_func local to top
1917         level of function and change its type.  Use temp_func to hold and
1918         delete temporary string obtained from cp_func_name.
1919
1920 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1921
1922         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1923         gdb::char_vector, remove cleanup, and update uses of `msg`.
1924
1925 2019-01-03  Jim Wilson  <jimw@sifive.com>
1926
1927         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1928
1929 2019-01-02  Tom Tromey  <tom@tromey.com>
1930
1931         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1932         (tdesc_parse_xml): Remove cleanups.
1933         * target-descriptions.h (make_cleanup_free_target_description):
1934         Don't declare.
1935         (target_desc_deleter): New struct.
1936         (target_desc_up): New typedef.
1937         * target-descriptions.c (target_desc_deleter::operator()): Rename
1938         from free_target_description.
1939         (make_cleanup_free_target_description): Remove.
1940
1941 2019-01-02  Tom Tromey  <tom@tromey.com>
1942
1943         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1944         constructor, destructor.
1945         (linespec_parser): Remove typedef.
1946         (~linespec_parser): Rename from linespec_parser_delete.
1947         (linespec_lex_to_end, linespec_complete_label)
1948         (linespec_complete): Update.
1949         (decode_line_full): Remove cleanups.
1950         (decode_line_1): Update.
1951
1952 2019-01-02  Tom Tromey  <tom@tromey.com>
1953
1954         * python/python-internal.h (inferior_to_inferior_object): Change
1955         return type.
1956         * python/py-exitedevent.c (create_exited_event_object): Update.
1957         * python/py-inferior.c (inferior_to_inferior_object): Return
1958         gdbpy_ref.
1959         (python_new_inferior, python_inferior_deleted)
1960         (thread_to_thread_object, delete_thread_object)
1961         (build_inferior_list, gdbpy_selected_inferior): Update.
1962         * python/py-infthread.c (create_thread_object): Update.  Also fail
1963         if inferior_to_inferior_object fails.
1964
1965 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1966
1967         * inferior.h (class inferior) <displaced_step_state>: New field.
1968         * infrun.h (struct displaced_step_state): Move here from
1969         infrun.c.  Initialize fields, add constructor.
1970         <inf>: Remove field.
1971         <reset>: New method.
1972         * infrun.c (struct displaced_step_inferior_state): Move to
1973         infrun.h.
1974         (displaced_step_inferior_states): Remove.
1975         (get_displaced_stepping_state): Adust.
1976         (displaced_step_in_progress_any_inferior): Adjust.
1977         (displaced_step_in_progress_thread): Adjust.
1978         (displaced_step_in_progress): Adjust.
1979         (add_displaced_stepping_state): Remove.
1980         (get_displaced_step_closure_by_addr): Adjust.
1981         (remove_displaced_stepping_state): Remove.
1982         (infrun_inferior_exit): Call displaced_step_state.reset.
1983         (use_displaced_stepping): Don't check for NULL.
1984         (displaced_step_prepare_throw): Call
1985         get_displaced_stepping_state.
1986         (displaced_step_fixup): Don't check for NULL.
1987         (prepare_for_detach): Don't check for NULL.
1988
1989 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1990
1991         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1992          in case of call that did not complete.
1993
1994 2019-01-02  Andrey Utkin  <autkin@undo.io>
1995
1996         * symfile.c (find_separate_debug_file): Fix search of debug files for
1997         remote debuggee.
1998
1999 2019-01-02  Tom Tromey  <tom@tromey.com>
2000
2001         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2002         indentation.
2003         * python/py-frame.c (frapy_older): Remove cast.
2004         (frapy_newer): Likewise.
2005         * python/py-breakpoint.c (local_setattro): Remove cast.
2006         * python/py-arch.c (archpy_name): Remove local variable.
2007         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2008
2009 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2010
2011         * unittests/basic_string_view/element_access/char/empty.cc:
2012         Fix year range in copyright header.
2013
2014 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2015
2016         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2017         Delete.
2018         <operator==>: Update with for removed field.
2019         <hash>: Likewise.
2020         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2021         <isa_features>: ...this.
2022         <abi_features>: New field.
2023         (riscv_isa_flen): Update comment.
2024         (riscv_abi_xlen): New declaration.
2025         (riscv_abi_flen): New declaration.
2026         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2027         isa_features.
2028         (riscv_abi_xlen): New function.
2029         (riscv_isa_flen): Update to get answer from isa_features.
2030         (riscv_abi_flen): New function.
2031         (riscv_has_fp_abi): Update to get answer from abi_features.
2032         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2033         xlen and flen.
2034         (riscv_call_info) <xlen, flen>: Update comment.
2035         (riscv_call_arg_struct): Remove invalid assertions
2036         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2037         is removed.
2038         (riscv_gdbarch_init): Gather isa features and abi features
2039         separately, ensure both match on the gdbarch when reusing an old
2040         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2041         a target with 64-bit float hardware.
2042
2043 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2044
2045         * source.c (search_command_helper): Stop reverse search
2046         when line 1 has been searched.
2047
2048 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2049
2050         * record-full.c (record_full_base_target::close): Rewrite
2051         record_full_core_buf_list free logic.
2052
2053 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2054
2055         * break-catch-syscall.c (print_one_catch_syscall): xfree
2056         the last text.
2057
2058 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2059
2060         * top.c (print_gdb_version): Update Copyright year in version
2061         message.
2062
2063 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2064
2065         Update copyright year range in all GDB files.
2066
2067 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2068
2069         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2070
2071 For older changes see ChangeLog-2018.
2072 \f
2073 Local Variables:
2074 mode: change-log
2075 left-margin: 8
2076 fill-column: 74
2077 version-control: never
2078 coding: utf-8
2079 End:
2080